[gdb, c++] Improve error message when using libstdcxx without SDT probes
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
5c31b358
TV
12019-08-26 Tom de Vries <tdevries@suse.de>
2
3 PR c++/24852
4 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5 when pc_probe.prob == NULL.
6
23c13d42
SM
72019-08-25 Simon Marchi <simon.marchi@efficios.com>
8
9 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
10 variable symbol_linkage to symbol_linkage_.
11
beadd3e8
SM
122019-08-25 Simon Marchi <simon.marchi@efficios.com>
13
14 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
15 represent whether the symbol is static, dynamic, or we don't
16 know.
17
e3ec872f
YS
182019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
19
20 * gdb/rx-tdep.c (rx_register_names): New.
21 (rx_register_name): Delete.
22 (rx_psw_type): Delete.
23 (rx_fpsw_type): Delete.
24 (rx_register_type): Delete.
25 (rx_gdbarch_init): Convert target-descriptions.
26 (_initialize_rx_tdep): Add initialize_tdesc_rx.
27 * gdb/features/Makefile: Add rx.xml.
28 * gdb/features/rx.xml: New.
29 * gdb/features/rx.c: Generated.
30 * gdb/NEWS: Mention target description support.
31
d0509ba4
CB
322019-08-22 Christian Biesinger <cbiesinger@google.com>
33
34 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
35 *slot_ptr.
36
2d41fa11
SDJ
372019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
38
39 * configure.ac: Don't check for 'dlfcn.h' (moved to
40 gdbsupport/common.m4).
41 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
42 'gdbsupport/'.
43 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
44 * compile/compile-c-support.c: Include
45 'gdbsupport/gdb-dlfcn.h'.
46 * gdbsupport/common.m4: Check for 'dlfcn.h'.
47 * gdb-dlfcn.c: Move to...
48 * gdbsupport/gdb-dlfcn.c: ... here.
49 * gdb-dlfcn.h: Move to...
50 * gdbsupport/gdb-dlfcn.h: ... here.
51
de8af808
SL
522019-08-23 Sandra Loosemore <sandra@codesourcery.com>
53
54 * nios2-tdep.c (struct reg_value): Improve comments. Make
55 the offset field signed.
56
27204489
CB
572019-08-22 Christian Biesinger <cbiesinger@google.com>
58
59 * python/lib/gdb/__init__.py (_execute_file): New function.
60 * python/python.c (python_run_simple_file): Call gdb._execute_file
61 on Windows.
62
43771869
AB
632019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
64
65 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
66 all uses as this was never set to anything but a zero value.
67
26c957f1
PA
682019-08-21 Bogdan Harjoc <harjoc@gmail.com>
69
70 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
71
c07aae6e
CB
722019-08-21 Christian Biesinger <cbiesinger@google.com>
73
74 * tui/tui-data.h (tui_gen_win_info): Add an =default
75 move constructor, required by some GCC versions.
76
3960cb7a
JF
772019-08-21 Jinke Fan <fanjinke51@yeah.net>
78
79 * go32-nat.c (go32_sysinfo): Add hygon_p.
80
04c72a68
TT
812019-08-20 Tom Tromey <tom@tromey.com>
82
83 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
84 line_from_reg_element_no, first_reg_element_no_inline,
85 display_all_data, delete_data_content_windows,
86 erase_data_content>: Now private.
87
072272ce
TT
882019-08-20 Tom Tromey <tom@tromey.com>
89
90 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
91 (tui_unhighlight_win, tui_highlight_win)
92 (tui_win_info::make_window): Update.
93 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
94
973961bd
TT
952019-08-20 Tom Tromey <tom@tromey.com>
96
97 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
98 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
99 (MAX_PID_WIDTH): Move to tui-stack.c.
100 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
101 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
102 (MAX_PID_WIDTH): Move from tui-data.h.
103
ab0e1f1a
TT
1042019-08-20 Tom Tromey <tom@tromey.com>
105
106 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
107 * tui/tui-wingeneral.c (box_win): Change type of win_info.
108 (box_win): Update.
109 (tui_gen_win_info::make_window): Rename from tui_make_window.
110 (tui_win_info::make_window): New method.
111 (tui_gen_win_info::make_visible): Update.
112 * tui/tui-source.c (tui_source_window::set_contents): Update.
113 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
114 (tui_data_window::display_registers_from): Update.
115 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
116 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
117 Declare.
118 <can_box>: Remove.
119 <title>: Remove.
120 (struct tui_win_info) <make_window>: Declare.
121 <can_box>: Now virtual.
122 <title>: New member.
123 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
124 * tui/tui-command.c (tui_cmd_window::resize): Update.
125
100c2bf3
TT
1262019-08-20 Tom Tromey <tom@tromey.com>
127
128 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
129 * tui/tui-regs.c (tui_data_window::show_registers): Update.
130 (tui_data_window::check_register_values): Update.
131
fa4dc567
TT
1322019-08-20 Tom Tromey <tom@tromey.com>
133
134 * tui/tui-regs.h (struct tui_data_window): Use
135 DISABLE_COPY_AND_ASSIGN.
136 <regs_content>: Change type, removing unique_ptr.
137 <tui_data_window>: Add move constructor.
138 * tui/tui-regs.c (tui_data_window::show_registers)
139 (tui_data_window::show_register_group)
140 (tui_data_window::display_registers_from)
141 (tui_data_window::display_registers_from)
142 (tui_data_window::first_data_item_displayed)
143 (tui_data_window::delete_data_content_windows)
144 (tui_data_window::rerender, tui_data_window::refresh_window)
145 (tui_data_window::check_register_values): Update.
146
ca02d7c8
TT
1472019-08-20 Tom Tromey <tom@tromey.com>
148
149 * tui/tui-regs.h (struct tui_data_window) <show_registers,
150 show_register_group>: Declare.
151 (tui_show_register_group): Don't declare.
152 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
153 tui_show_registers.
154 (tui_data_window::show_register_group): Rename from
155 tui_show_register_group.
156 (tui_data_window::check_register_values, tui_reg_command):
157 Update.
158 * tui/tui-layout.c (tui_set_layout): Update.
159
63356bfd
TT
1602019-08-20 Tom Tromey <tom@tromey.com>
161
162 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
163 Declare.
164 (tui_check_register_values): Don't declare.
165 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
166 from tui_check_register_values.
167 * tui/tui-hooks.c (tui_register_changed): Update.
168
42cc14a7
TT
1692019-08-20 Tom Tromey <tom@tromey.com>
170
171 * tui/tui-regs.c (tui_reg_layout): Move later.
172 (tui_show_registers): Don't enable TUI mode or change layout.
173
b9ad3686
TT
1742019-08-20 Tom Tromey <tom@tromey.com>
175
176 * tui/tui-regs.h (struct tui_data_item_window)
177 <~tui_data_item_window>: Remove.
178 <content>: Now a unique_xmalloc_ptr.
179 * tui/tui-regs.c (tui_register_format): Return a
180 unique_xmalloc_ptr.
181 (tui_get_register): Update.
182 (~tui_data_item_window): Remove.
183 (tui_data_window::display_registers_from, tui_display_register):
184 Update.
185 * tui/tui-io.h (tui_expand_tabs): Update.
186 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
187 Remove "col" parameter.
188
8e114aab
TT
1892019-08-20 Tom Tromey <tom@tromey.com>
190
191 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
192 field.
193 * tui/tui-regs.c (~tui_data_item_window): Update.
194
1a4f81dd
TT
1952019-08-20 Tom Tromey <tom@tromey.com>
196
197 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
198 earlier.
199
0f8d8876
TT
2002019-08-20 Tom Tromey <tom@tromey.com>
201
202 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
203
605dc2c2
TT
2042019-08-20 Tom Tromey <tom@tromey.com>
205
206 * tui/tui-source.h (struct tui_source_window): Update.
207 * tui/tui-regs.c (tui_show_registers): Update.
208 * tui/tui-disasm.h (struct tui_disasm_window): Update.
209 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
210 (NO_REGS_STRING): Remove defines.
211
aedbe3bb
CM
2122019-08-20 Conrad Meyer <cem@FreeBSD.org>
213
214 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
215 unnecessary thread walk if remote doesn't support the packet.
216
7ce8f214
TT
2172019-08-19 Tom Tromey <tromey@adacore.com>
218
219 * python/py-value.c (value_has_field): Fix indentation.
220
f21c2bd7
TT
2212019-08-19 Tom Tromey <tromey@adacore.com>
222
223 * printcmd.c (do_one_display, info_display_command): Update.
224 * block.h (contained_in): Return bool. Add allow_nested
225 parameter.
226 * block.c (contained_in): Return bool. Add allow_nested
227 parameter.
228
d806ea2d
TT
2292019-08-19 Tom Tromey <tom@tromey.com>
230
231 * configure: Rebuild.
232 * configure.ac: Disallow the combination of -static-libstdc++ and
233 source highlight.
234 * source-cache.c (get_language_name): Handle rust.
235 (source_cache::get_source_lines): Ignore highlighting exceptions.
236
398fdd60
TT
2372019-08-16 Tom Tromey <tom@tromey.com>
238
239 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
240 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
241 (struct tui_source_window_base) <make_visible, refresh_window,
242 resize>: Remove methods.
243 <execution_info>: Remove field.
244 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
245 (tui_show_source_line, tui_source_window_base)
246 (~tui_source_window_base): Update.
247 (tui_source_window_base::resize)
248 (tui_source_window_base::make_visible)
249 (tui_source_window_base::refresh_window): Remove.
250 (tui_source_window_base::update_exec_info): Update.
251 * tui/tui-source.c (tui_source_window::set_contents): Update.
252 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
253
e699d331
TT
2542019-08-16 Tom Tromey <tom@tromey.com>
255
256 * tui/tui-hooks.c (tui_remove_hooks): Don't set
257 deprecated_query_hook.
258
bb01dbfc
TT
2592019-08-16 Tom Tromey <tom@tromey.com>
260
261 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
262 (tui_update_source_windows_with_line): Update.
263 * tui/tui-source.h (struct tui_source_window)
264 <show_symtab_source>: Declare.
265 (tui_show_symtab_source): Don't declare.
266 * tui/tui-source.c (tui_show_symtab_source): Rename from
267 tui_show_symtab_source.
268
81c82c4b
TT
2692019-08-16 Tom Tromey <tom@tromey.com>
270
271 * tui/tui-winsource.h (struct tui_source_window_base)
272 <set_contents>: Declare.
273 * tui/tui-winsource.c
274 (tui_source_window_base::update_source_window_as_is): Update.
275 * tui/tui-source.h (struct tui_source_window) <set_contents>:
276 Declare.
277 (tui_set_source_content): Don't declare.
278 * tui/tui-source.c (tui_source_window::set_contents): Rename from
279 tui_set_source_content.
280 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
281 Declare.
282 (tui_set_disassem_content): Don't declare.
283 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
284 tui_set_disassem_content.
285
2ddaf614
TT
2862019-08-16 Tom Tromey <tom@tromey.com>
287
288 * tui/tui-winsource.h (struct tui_source_window_base)
289 <update_breakpoint_info>: Declare.
290 (tui_update_breakpoint_info): Don't declare.
291 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
292 (tui_update_all_breakpoint_info): Update.
293 (tui_source_window_base::update_breakpoint_info): Rename from
294 tui_update_breakpoint_info.
295 (tui_source_window_base::update_exec_info): Update.
296
017f9828
TT
2972019-08-16 Tom Tromey <tom@tromey.com>
298
299 * tui/tui-winsource.h (struct tui_source_window_base)
300 <update_source_window>: Declare.
301 (tui_update_source_window): Don't declare.
302 * tui/tui-winsource.c
303 (tui_source_window_base::update_source_window): Rename from
304 tui_update_source_window.
305 (tui_source_window_base::rerender): Update.
306 * tui/tui-source.c (tui_source_window::maybe_update): Update.
307 * tui/tui-disasm.c (tui_show_disassem)
308 (tui_show_disassem_and_update_source)
309 (tui_disasm_window::maybe_update): Update.
310
ed8358e9
TT
3112019-08-16 Tom Tromey <tom@tromey.com>
312
313 * tui/tui-winsource.h (struct tui_source_window_base)
314 <update_source_window_as_is>: Declare.
315 (tui_update_source_window_as_is): Don't declare.
316 * tui/tui-winsource.c (tui_update_source_window): Update
317 (tui_source_window_base::update_source_window_as_is): Rename from
318 tui_update_source_window_as_is.
319 (tui_source_window_base::refill): Update.
320 * tui/tui-source.c (tui_show_symtab_source): Update.
321 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
322 Update.
323
20149b6b
TT
3242019-08-16 Tom Tromey <tom@tromey.com>
325
326 * tui/tui-winsource.h (tui_update_source_window)
327 (tui_update_source_window_as_is): Remove "noerror" parameter.
328 * tui/tui-winsource.c (tui_update_source_window)
329 (tui_update_source_window_as_is): Remove "noerror" parameter.
330 (tui_update_source_windows_with_addr)
331 (tui_update_source_windows_with_line)
332 (tui_source_window_base::rerender)
333 (tui_source_window_base::refill): Update.
334 * tui/tui-source.h (tui_set_source_content)
335 (tui_show_symtab_source): Remove "noerror" parameter.
336 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
337 parameter.
338 (tui_show_symtab_source): Likewise.
339 (tui_source_window::maybe_update): Update.
340 * tui/tui-disasm.c (tui_show_disassem)
341 (tui_show_disassem_and_update_source)
342 (tui_disasm_window::do_scroll_vertical)
343 (tui_disasm_window::maybe_update): Update.
344
2d83e710
TT
3452019-08-16 Tom Tromey <tom@tromey.com>
346
347 * tui/tui.c (tui_is_window_visible): Update.
348 * tui/tui-wingeneral.c (tui_make_window)
349 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
350 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
351 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
352 (tui_set_win_height_command, parse_scrolling_args): Update.
353 * tui/tui-source.c (tui_source_window::style_changed): Update.
354 * tui/tui-regs.c (tui_show_registers)
355 (tui_data_window::first_data_item_displayed)
356 (tui_data_window::delete_data_content_windows)
357 (tui_check_register_values, tui_reg_command): Update.
358 * tui/tui-disasm.c (tui_show_disassem): Update.
359 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
360 method.
361 <is_visible>: Remove field.
362 * tui/tui-data.c (tui_next_win, tui_prev_win)
363 (tui_delete_invisible_windows): Update.
364
d4ab829a
TT
3652019-08-16 Tom Tromey <tom@tromey.com>
366
367 * tui/tui-winsource.h (struct tui_source_window_base)
368 <m_has_locator>: Remove.
369 * tui/tui-layout.c (show_source_disasm_command, show_data)
370 (show_source_or_disasm_and_command): Update.
371
aa7ca1bb
AH
3722019-08-16 Alan Hayward <alan.hayward@arm.com>
373
374 * NEWS (Other MI changes): New subsection.
375 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
376 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
377 * arch-utils.c (default_get_pc_address_flags): New function.
378 * arch-utils.h (default_get_pc_address_flags): New declaration.
379 * gdbarch.sh: Add get_pc_address_flags.
380 * gdbarch.c: Regenerate.
381 * gdbarch.h: Likewise.
382 * stack.c (print_pc): New function.
383 (print_frame_info) (print_frame): Call print_pc.
384
6eac171f
TV
3852019-08-16 Tom de Vries <tdevries@suse.de>
386
387 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
388 print_objfile_section_info.
389
3df505f6
TT
3902019-08-15 Tom Tromey <tom@tromey.com>
391
392 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
393 calling update_cmdwin_start_line.
394 * tui/tui-winsource.h (struct tui_source_window_base)
395 <do_make_visible_with_new_height, set_new_height>: Don't declare.
396 <rerender>: Declare.
397 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
398 Call rerender.
399 (tui_source_window_base::set_new_height): Remove.
400 (tui_source_window_base::rerender): Rename from
401 do_make_visible_with_new_height.
402 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
403 resize method.
404 (tui_win_info::make_invisible_and_set_new_height)
405 (tui_win_info::make_visible_with_new_height): Remove.
406 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
407 Declare.
408 * tui/tui-stack.c (tui_locator_window::rerender): New method.
409 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
410 do_make_visible_with_new_height>: Don't declare.
411 <rerender>: Declare.
412 * tui/tui-regs.c (tui_data_window::rerender): Rename from
413 set_new_height.
414 (tui_data_window::do_make_visible_with_new_height): Remove.
415 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
416 call tui_show_locator_content.
417 (tui_gen_win_info::resize): Call rerender.
418 (show_source_or_disasm_and_command): Don't call
419 tui_show_locator_content.
420 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
421 method.
422 (struct tui_win_info) <rerender>: Declare.
423 <set_new_height, make_invisible_and_set_new_height,
424 make_visible_with_new_height>: Don't declare.
425 * tui/tui-data.c (tui_win_list::rerender): New method.
426 * tui/tui-command.h (struct tui_cmd_window)
427 <do_make_visible_with_new_height>: Don't declare.
428 * tui/tui-command.c
429 (tui_cmd_window::do_make_visible_with_new_height): Remove.
430
272560b5
TT
4312019-08-15 Tom Tromey <tromey@adacore.com>
432
433 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
434 * ada-lang.c (ada_enum_name): Likewise.
435
08235187
CB
4362019-08-15 Christian Biesinger <cbiesinger@google.com>
437
438 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
439 leading underscore.
440 (GdbOutputErrorFile): Likewise.
441 (global scope): Adjust constructor calls to GdbOutput{,Error}File
442 accordingly.
443 (execute_unwinders): Rename to have a leading underscore.
444 (auto_load_packages): Likewise.
445 (global scope): Adjust call to auto_load_packages accordingly.
446 (GdbSetPythonDirectory): Likewise.
447 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
448 instead of execute_unwinders.
449
db502012
TT
4502019-08-15 Tom Tromey <tom@tromey.com>
451
452 * tui/tui-layout.c (show_layout, show_source_disasm_command)
453 (show_data): Don't change window visibility.
454 (tui_gen_win_info::resize): Remove special case for command
455 window. Use wresize, when available.
456 (show_source_or_disasm_and_command): Don't change window
457 visibility.
458 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
459 <make_visible>: New method.
460 * tui/tui-command.c (tui_cmd_window::resize): New method.
461
3891b65e
TT
4622019-08-15 Tom Tromey <tom@tromey.com>
463
464 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
465 (struct tui_source_windows): New.
466 * tui/tui-winsource.c (tui_display_main): Update.
467 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
468 (new_height_ok, parse_scrolling_args): Update.
469 * tui/tui-layout.c (show_layout, show_data): Update.
470 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
471 (tui_add_to_source_windows): Don't declare.
472 * tui/tui-data.c (source_windows, tui_source_windows)
473 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
474
ee556432
TT
4752019-08-15 Tom Tromey <tom@tromey.com>
476
477 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
478 Rename from reset.
479 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
480 * tui/tui-layout.c (show_source_disasm_command, show_data):
481 Update.
482 (tui_gen_win_info::resize): Rename.
483 (show_source_or_disasm_and_command): Update.
484 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
485 reset.
486
46f438e3
TT
4872019-08-15 Tom Tromey <tom@tromey.com>
488
489 * tui/tui-stack.c (tui_initialize_static_data): Remove.
490 * tui/tui-interp.c (tui_interp::init): Don't call
491 tui_initialize_static_data.
492 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
493
f4ce562c
TT
4942019-08-15 Tom Tromey <tom@tromey.com>
495
496 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
497 examine tui_win_list.
498
c398c3d0
TT
4992019-08-15 Tom Tromey <tom@tromey.com>
500
501 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
502 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
503 tui_clear_source_content.
504 (tui_clear_source_content): Remove.
505 (tui_source_window_base::do_erase_source_content): Hoist call to
506 content.clear().
507 * tui/tui-stack.c (tui_show_frame_info): Don't call
508 tui_clear_source_content.
509
e25d2004
TT
5102019-08-15 Tom Tromey <tom@tromey.com>
511
512 * tui/tui-winsource.h (struct tui_source_window_base)
513 <do_erase_source_content>: New method.
514 <erase_source_content>: New method.
515 (tui_erase_source_content): Don't declare.
516 * tui/tui-winsource.c (tui_clear_source_content): Update.
517 (tui_source_window_base::do_erase_source_content): Rename from
518 tui_erase_source_content.
519 (tui_source_window_base::show_source_content): Update.
520 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
521 * tui/tui-source.h (struct tui_source_window)
522 <erase_source_content>: New method.
523 * tui/tui-disasm.h (struct tui_disasm_window)
524 <erase_source_content>: New method.
525
002f15c2
TT
5262019-08-15 Tom Tromey <tom@tromey.com>
527
528 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
529 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
530 constructor.
531 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
532 * tui/tui-source.c (tui_set_source_content): Update.
533 * tui/tui-disasm.c (tui_set_disassem_content): Update.
534
c9033fe8
TT
5352019-08-15 Tom Tromey <tom@tromey.com>
536
537 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
538 * tui/tui-winsource.c (tui_line_is_displayed): Move to
539 tui-source.c.
540 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
541 Declare.
542 * tui/tui-source.c (tui_source_window::line_is_displayed): New
543 method.
544 (tui_source_window::maybe_update): Update.
545
088f37dd
TT
5462019-08-15 Tom Tromey <tom@tromey.com>
547
548 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
549 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
550 tui-disasm.c.
551 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
552 Declare.
553 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
554 method.
555 (tui_disasm_window::maybe_update): Update.
556
a54700c6
TT
5572019-08-15 Tom Tromey <tom@tromey.com>
558
559 * tui/tui-winsource.h (struct tui_source_window_base)
560 <maybe_update>: Declare.
561 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
562 method.
563 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
564 Declare.
565 * tui/tui-source.c (tui_source_window::maybe_update): New method.
566 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
567 Declare.
568 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
569
e2a678a5
TT
5702019-08-15 Tom Tromey <tom@tromey.com>
571
572 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
573
f2dda477
TT
5742019-08-15 Tom Tromey <tom@tromey.com>
575
576 * tui/tui-wingeneral.c: Include tui-stack.h.
577 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
578 (struct tui_locator_window): Move from tui-data.h.
579 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
580 (tui_initialize_static_data): Move from tui-data.c.
581 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
582 (struct tui_locator_window): Move to tui-stack.c.
583 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
584 (tui_initialize_static_data): Move to tui-stack.c.
585
ed4a1084
TT
5862019-08-15 Tom Tromey <tom@tromey.com>
587
588 * tui/tui-layout.c (show_source_disasm_command)
589 (show_source_or_disasm_and_command): Use make_visible method, not
590 tui_make_window.
591 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
592 Remove.
593
65962b20
TT
5942019-08-15 Tom Tromey <tom@tromey.com>
595
596 * tui/tui-wingeneral.h (tui_make_window): Update.
597 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
598 parameter.
599 (tui_gen_win_info::make_visible): Update.
600 * tui/tui-regs.c (tui_data_window::display_registers_from):
601 Update.
602 * tui/tui-layout.c (show_source_disasm_command)
603 (show_source_or_disasm_and_command): Update.
604 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
605 (enum tui_box): Remove.
606 (struct tui_win_info) <can_box>: New method.
607 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
608 method.
609
2208ee91
TV
6102019-08-15 Tom de Vries <tdevries@suse.de>
611
612 * linux-nat-trad.c: Include gdbarch.h.
613
75faf5c4
AH
6142019-08-14 Alan Hayward <alan.hayward@arm.com>
615
616 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
617 register sizes.
618
b1c896b3
TT
6192019-08-14 Tom Tromey <tromey@adacore.com>
620
621 * darwin-nat.c: Include gdbarch.h.
622 * darwin-nat-info.c: Include gdbarch.h.
623
6405cd73
TT
6242019-08-13 Tom Tromey <tom@tromey.com>
625
626 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
627 Remove.
628 * tui/tui-data.c (tui_initialize_static_data): Update.
629
5216580d
TT
6302019-08-13 Tom Tromey <tom@tromey.com>
631
632 * tui/tui-winsource.h (struct tui_exec_info_window)
633 <~tui_exec_info_window, maybe_allocate_content, get_content,
634 m_content>: Remove.
635 (struct tui_source_window_base) <set_exec_info_content,
636 show_exec_info_content>: Don't declare.
637 * tui/tui-winsource.c
638 (tui_exec_info_window::maybe_allocate_content): Remove.
639 (tui_source_window_base::update_exec_info): Rename from
640 set_exec_info_content.
641 (tui_source_window_base::show_exec_info_content)
642 (tui_source_window_base::update_exec_info): Remove.
643
93858ad3
TT
6442019-08-13 Tom Tromey <tom@tromey.com>
645
646 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
647 declare.
648 * tui/tui-winsource.c (tui_update_source_window_as_is)
649 (tui_update_source_windows_with_addr, tui_erase_source_content):
650 Update.
651 (tui_clear_exec_info_content): Remove.
652
e321e7ce
TT
6532019-08-13 Tom Tromey <tom@tromey.com>
654
655 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
656 declare.
657 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
658 call tui_erase_exec_info_content.
659 (tui_clear_exec_info_content): Rename from
660 tui_erase_exec_info_content.
661 (tui_clear_exec_info_content): Delete.
662
8270ac62
TT
6632019-08-13 Tom Tromey <tom@tromey.com>
664
665 * tui/tui-winsource.h (struct tui_source_window_base)
666 <show_exec_info_content>: Declare.
667 (tui_show_exec_info_content): Don't declare.
668 * tui/tui-winsource.c
669 (tui_source_window_base::show_exec_info_content): Rename from
670 tui_show_exec_info_content.
671 (tui_source_window_base::update_exec_info): Update.
672
7b56485d
TT
6732019-08-13 Tom Tromey <tom@tromey.com>
674
675 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
676 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
677 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
678 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
679 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
680 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
681 ... here.
682
7ba913dc
TT
6832019-08-13 Tom Tromey <tom@tromey.com>
684
685 * tui/tui-winsource.h (struct tui_source_window_base)
686 <update_exec_info>: Declare.
687 (tui_update_exec_info): Don't declare.
688 * tui/tui-winsource.c (tui_update_source_window_as_is)
689 (tui_source_window_base::refresh_all)
690 (tui_update_all_breakpoint_info): Update.
691 (tui_source_window_base::update_exec_info): Rename from
692 tui_update_exec_info.
693 * tui/tui-stack.c (tui_show_frame_info): Update.
694
37a4a131
TT
6952019-08-13 Tom Tromey <tom@tromey.com>
696
697 * tui/tui-winsource.h (struct tui_source_window_base)
698 <set_exec_info_content>: Declare.
699 (tui_set_exec_info_content): Don't declare.
700 * tui/tui-winsource.c
701 (tui_source_window_base::set_exec_info_content): Rename from
702 tui_set_exec_info_content.
703 (tui_update_exec_info): Update.
704
0bd27e07
TT
7052019-08-13 Tom Tromey <tom@tromey.com>
706
707 * tui/tui-winsource.h (struct tui_source_window_base)
708 <show_source_content>: Declare.
709 (tui_show_source_content): Don't declare.
710 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
711 (tui_source_window_base::show_source_content): Rename from
712 tui_show_source_content.
713 (tui_source_window_base::refresh_all): Update.
714 * tui/tui-layout.c (show_source_disasm_command)
715 (show_source_or_disasm_and_command): Update.
716
b4ef5aeb
TT
7172019-08-13 Tom Tromey <tom@tromey.com>
718
719 * tui/tui-winsource.c (tui_erase_source_content)
720 (tui_show_source_content, tui_source_window_base::refresh_all):
721 Update.
722 * tui/tui-wingeneral.h
723 (tui_check_and_display_highlight_if_needed): Don't declare.
724 * tui/tui-wingeneral.c
725 (tui_win_info::check_and_display_highlight_if_needed): Rename from
726 check_and_display_highlight_if_needed.
727 * tui/tui-win.c (tui_rehighlight_all)
728 (tui_win_info::make_visible_with_new_height): Update.
729 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
730 (tui_data_window::erase_data_content)
731 (tui_data_window::display_all_data): Update.
732 * tui/tui-data.h (struct tui_win_info)
733 <check_and_display_highlight_if_needed>: Declare.
734
fede5273
TT
7352019-08-13 Tom Tromey <tom@tromey.com>
736
737 * tui/tui-win.c (tui_resize_all): Call
738 tui_delete_invisible_windows.
739 * tui/tui-layout.c (show_layout): Call
740 tui_delete_invisible_windows.
741 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
742 * tui/tui-data.c (tui_delete_invisible_windows): New function.
743
22c3f490
TT
7442019-08-13 Tom Tromey <tom@tromey.com>
745
746 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
747 tui_add_win_to_layout.
748
16cb7910
TT
7492019-08-13 Tom Tromey <tom@tromey.com>
750
751 * tui/tui-layout.h (tui_default_win_height): Don't declare.
752 * tui/tui-layout.c (tui_default_win_height): Now static.
753
cc0c3ffb
TT
7542019-08-13 Tom Tromey <tom@tromey.com>
755
756 * tui/tui-layout.c (show_layout): Unify all layout cases into a
757 single switch.
758 (show_source_disasm_command, show_source_or_disasm_and_command):
759 Don't check current layout.
760
3f3ffe54
TT
7612019-08-13 Tom Tromey <tom@tromey.com>
762
763 * tui/tui-wingeneral.c (make_all_visible): Remove.
764 (tui_make_all_invisible): Simplify.
765 * tui/tui-layout.c (tui_make_all_invisible): Move from
766 tui-wingeneral.c; simplify.
767 (show_layout): Hoist call to tui_make_all_invisible.
768 (show_data): Don't call tui_make_all_invisible.
769
69258091
TT
7702019-08-13 Tom Tromey <tom@tromey.com>
771
772 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
773 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
774
62cf57fe
TT
7752019-08-13 Tom Tromey <tom@tromey.com>
776
777 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
778 tui-data.c.
779 (show_source_disasm_command, show_data)
780 (show_source_or_disasm_and_command): Don't use
781 tui_set_current_layout_to.
782 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
783 * tui/tui-data.c (current_layout, tui_current_layout): Move to
784 tui-layout.c.
785 (tui_set_current_layout_to): Remove.
786
2afade5d
TT
7872019-08-13 Tom Tromey <tom@tromey.com>
788
789 * tui/tui-layout.c (tui_set_layout): Update.
790 * tui/tui-data.h (struct tui_layout_def): Remove.
791 (tui_layout_def): Don't declare.
792 * tui/tui-data.c (layout_def): Remove.
793 (tui_layout_def): Remove.
794
a3504e96
TT
7952019-08-13 Tom Tromey <tom@tromey.com>
796
797 * tui/tui-winsource.h (struct tui_source_window_base)
798 <clear_detail>: No longer "override".
799 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
800 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
801 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
802 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
803 Remove.
804 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
805
29c92911
TT
8062019-08-13 Tom Tromey <tromey@adacore.com>
807
808 * tracepoint.c: Don't include readline.h or history.h.
809
86c6b807
TT
8102019-08-12 Tom Tromey <tom@tromey.com>
811
812 * configure: Rebuild.
813 * configure.ac: Check for readline 7.
814 * NEWS: Mention readline 7 requirement.
815 * README: Update.
816
5db2718c
TT
8172019-08-12 Tom Tromey <tom@tromey.com>
818
819 * mingw-hdep.c (gdb_select): Remove readline hack.
820
dac36daf
PFC
8212019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
822
823 * blockframe.c (find_pc_partial_function): Set *block to nullptr
824 when the function fails.
825
1022c627
AA
8262019-08-09 Andreas Arnez <arnez@linux.ibm.com>
827
828 * s390-tdep.c (s390_type_align): New function.
829 (s390_gdbarch_init): Set it as type_align gdbarch method.
830
eba4caf2
TV
8312019-08-09 Tom de Vries <tdevries@suse.de>
832
833 PR gdb/24591
834 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
835 pc_low with relocation offset.
836
123cd851
TT
8372019-08-07 Tom Tromey <tromey@adacore.com>
838
839 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
840 (print_frame_args): Update.
841 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
842 Update.
843 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
844 * frame.h (struct frame_arg): Add initializers.
845 <error>: Now a unique_xmalloc_ptr.
846
3d31bc39
AH
8472019-08-07 Alan Hayward <alan.hayward@arm.com>
848
849 * NEWS: Expand the Pointer Authentication entry.
850 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
851 (aarch64_frame_unmask_lr): ... to this.
852 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
853 Call aarch64_frame_unmask_lr.
854 * frame.c (struct frame_info): Add "masked" variable.
855 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
856 (fprint_frame): Check for masked pc.
857 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
858 declarations.
859 * python/py-framefilter.c (py_print_frame): Check for masked pc.
860 * stack.c (print_frame): Check for masked pc.
861
0cf9feb9
TT
8622019-08-06 Tom Tromey <tom@tromey.com>
863
864 * stabsread.c (patch_block_stabs, read_one_struct_field)
865 (read_enum_type): Use obstack_strndup.
866 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
867 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
868 * dwarf2read.c (guess_full_die_structure_name)
869 (anonymous_struct_prefix): Use obstack_strndup.
870 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
871 * c-exp.y (yylex): Use obstack_strndup.
872 * ada-exp.y (write_object_renaming, write_ambiguous_var)
873 (write_var_or_type): Use obstack_strndup.
874
efba19b0
TT
8752019-08-06 Tom Tromey <tom@tromey.com>
876
877 * symfile.c (reread_symbols): Use obstack_strdup.
878 * stabsread.c (read_type): Use obstack_strdup.
879 * gdb_obstack.h (obstack_strdup): New overload.
880 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
881 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
882 (dwarf2_canonicalize_name): Use obstack_strdup.
883 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
884 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
885 Use obstack_strdup.
886
f25102f7
TT
8872019-08-06 Tom Tromey <tom@tromey.com>
888
889 * gdb_obstack.h (obstack_strdup): Define.
890 * gdb_obstack.c (obstack_strdup): Don't define.
891
021887d8
TT
8922019-08-06 Tom Tromey <tom@tromey.com>
893
894 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
895 obstack_strdup.
896 * typeprint.c (typedef_hash_table::find_global_typedef): Use
897 obstack_strdup.
898 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
899 * stabsread.c (common_block_start): Use obstack_strdup.
900 * objfiles.c (set_objfile_main_name, objfile): Use
901 obstack_strdup.
902 * namespace.c (add_using_directive): Use obstack_strdup.
903 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
904 * jit.c (finalize_symtab): Use obstack_strdup.
905 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
906 (guess_partial_die_structure_name, partial_die_info::fixup)
907 (dwarf2_name): Use obstack_strdup.
908 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
909 obstack_strdup.
910 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
911 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
912 obstack_strdup.
913 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
914
d2834edc
PW
9152019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
916
917 * unittests/help-doc-selftests.c: New file.
918 * Makefile.in: Add the new file.
919
590042fc
PW
9202019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
921
922 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
923 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
924 the full first line, except when FOR_VALUE_PREFIX. In this case,
925 the trailing '.' is not output, and the first character is uppercased.
926 (print_help_for_command): Update call to print_doc_line.
927 (print_doc_of_command): Likewise.
928 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
929 * cli/cli-option.c (append_indented_doc): Do not append newline.
930 (build_help_option): Append newline after first appended_indented_doc
931 only if a second call is done.
932 (build_help): Append 2 new lines before each option, except the first
933 one.
934 * compile/compile.c (_initialize_compile): Add new lines after
935 %OPTIONS%, when not at the end of the help.
936 Change help doc or code
937 producing the help doc to respect the invariants.
938 * maint-test-options.c (_initialize_maint_test_options): Likewise.
939 Also removed the new line after 'Options:', as all other commands
940 do not put an empty line between 'Options:' and the first option.
941 * printcmd.c (_initialize_printcmd): Likewise.
942 * stack.c (_initialize_stack): Likewise.
943 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
944 incorrectly telling COMMAND is optional.
945 * ada-lang.c (_initialize_ada_language): Change help doc or code
946 producing the help doc to respect the invariants.
947 * ada-tasks.c (_initialize_ada_tasks): Likewise.
948 * breakpoint.c (_initialize_breakpoint): Likewise.
949 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
950 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
951 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
952 * cli/cli-style.c (cli_style_option::add_setshow_commands,
953 _initialize_cli_style): Likewise.
954 * corelow.c (core_target_info): Likewise.
955 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
956 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
957 * filesystem.c (_initialize_filesystem): Likewise.
958 * frame.c (_initialize_frame): Likewise.
959 * gnu-nat.c (add_task_commands): Likewise.
960 * infcall.c (_initialize_infcall): Likewise.
961 * infcmd.c (_initialize_infcmd): Likewise.
962 * interps.c (_initialize_interpreter): Likewise.
963 * language.c (_initialize_language): Likewise.
964 * linux-fork.c (_initialize_linux_fork): Likewise.
965 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
966 * maint.c (_initialize_maint_cmds): Likewise.
967 * memattr.c (_initialize_mem): Likewise.
968 * printcmd.c (_initialize_printcmd): Likewise.
969 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
970 _RegEx): Likewise.
971 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
972 * record-btrace.c (_initialize_record_btrace): Likewise.
973 * record-full.c (_initialize_record_full): Likewise.
974 * record.c (_initialize_record): Likewise.
975 * regcache-dump.c (_initialize_regcache_dump): Likewise.
976 * regcache.c (_initialize_regcache): Likewise.
977 * remote.c (add_packet_config_cmd, init_remote_threadtests,
978 _initialize_remote): Likewise.
979 * ser-tcp.c (_initialize_ser_tcp): Likewise.
980 * serial.c (_initialize_serial): Likewise.
981 * skip.c (_initialize_step_skip): Likewise.
982 * source.c (_initialize_source): Likewise.
983 * stack.c (_initialize_stack): Likewise.
984 * symfile.c (_initialize_symfile): Likewise.
985 * symtab.c (_initialize_symtab): Likewise.
986 * target-descriptions.c (_initialize_target_descriptions): Likewise.
987 * top.c (init_main): Likewise.
988 * tracefile-tfile.c (tfile_target_info): Likewise.
989 * tracepoint.c (_initialize_tracepoint): Likewise.
990 * tui/tui-win.c (_initialize_tui_win): Likewise.
991 * utils.c (add_internal_problem_command): Likewise.
992 * valprint.c (value_print_option_defs): Likewise.
993
404f2902
FCE
9942019-08-06 Frank Ch. Eigler <fche@redhat.com>
995
996 PR build/24886
997 * configure.ac: Drop enable-libmcheck support.
998 * configure, config.in: Rebuild.
999 * libmcheck.m4: Remove.
1000 * acinclude.m4: Don't include it.
1001 * Makefile.in: Don't distribute it.
1002 * top.c (print_gdb_configuration): Don't mention it.
1003
046bebe1
TT
10042019-08-06 Tom Tromey <tom@tromey.com>
1005
1006 * utils.c (set_output_style): Sometimes pass stream to
1007 emit_style_escape.
1008 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1009 * record-btrace.c (btrace_insn_history): Update.
1010 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1011 method.
1012 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1013 Update initializers.
1014 <m_uiout>: New field.
1015 <m_di>: Move lower.
1016 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1017 Remove "uiout" parameter.
1018 (dump_insns): Update.
1019 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1020 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1021
ddbcedf5
CB
10222019-08-06 Christian Biesinger <cbiesinger@google.com>
1023
1024 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1025 (error_in_psymtab_expansion): Likewise.
1026 (lookup_symbol_via_quick_fns): Likewise.
1027 (basic_lookup_transparent_type_quick): Likewise.
1028 (basic_lookup_transparent_type_1): Likewise.
1029
b08b16c8
TT
10302019-08-06 Tom Tromey <tromey@adacore.com>
1031
1032 * source.c (last_source_error): Now bool.
1033 (print_source_lines_base): Make "noprint" bool. Only open
1034 source file when last_source_visited changes.
1035
cb44333d
TT
10362019-08-06 Tom Tromey <tromey@adacore.com>
1037
1038 * annotate.c (annotate_source_line): Use g_source_cache.
1039 * source-cache.c (source_cache::get_plain_source_lines): Change
1040 parameters. Populate m_offset_cache.
1041 (source_cache::ensure): New method.
1042 (source_cache::get_line_charpos): New method.
1043 (extract_lines): Move lower. Change parameters.
1044 (source_cache::get_source_lines): Move lower.
1045 * source-cache.h (class source_cache): Update comment.
1046 <get_line_charpos>: New method.
1047 <get_source_lines>: Update comment.
1048 <clear>: Clear m_offset_cache.
1049 <get_plain_source_lines>: Change parameters.
1050 <ensure>: New method
1051 <m_offset_cache>: New member.
1052 * source.c (forget_cached_source_info_for_objfile): Update.
1053 (info_source_command): Use g_source_cache.
1054 (find_source_lines, open_source_file_with_line_charpos): Remove.
1055 (print_source_lines_base, search_command_helper): Use g_source_cache.
1056 * source.h (open_source_file_with_line_charpos): Don't declare.
1057 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1058 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1059 Use g_source_cache.
1060
872dceaa
TT
10612019-08-06 Tom Tromey <tromey@adacore.com>
1062
1063 * source-cache.c (source_cache::get_plain_source_lines):
1064 Remove "first_line" and "last_line" parameters.
1065 (source_cache::get_source_lines): Cache plain text.
1066 * source-cache.h (class source_cache)
1067 <get_plain_source_lines>: Update.
1068
269249d9
TT
10692019-08-06 Tom Tromey <tromey@adacore.com>
1070
1071 * source-cache.c (extract_lines): No longer a method.
1072 Changed type of parameter. Include final newline.
1073 (selftests::extract_lines_test): New function.
1074 (_initialize_source_cache): Likewise.
1075 * source-cache.h (class source_cache)
1076 <extract_lines>: Don't declare.
1077
c0e8dcd8
TT
10782019-08-06 Tom Tromey <tromey@adacore.com>
1079
1080 * breakpoint.c (init_breakpoint_sal): Update.
1081 (breakpoint): Update.
1082 * breakpoint.h (struct breakpoint) <filter>: Now a
1083 unique_xmalloc_ptr.
1084
0b27c27d
CB
10852019-08-05 Christian Biesinger <cbiesinger@google.com>
1086
1087 * NEWS: Mention dictionary access on blocks.
1088 * python/py-block.c (blpy_getitem): New function.
1089 (block_object_as_mapping): New struct.
1090 (block_object_type): Use new struct for tp_as_mapping field.
1091
4ee94178
CB
10922019-08-05 Christian Biesinger <cbiesinger@google.com>
1093
1094 * objfiles.h (objfile): Add a comment describing partial symbols.
1095
8abfcabc
TT
10962019-08-05 Tom Tromey <tromey@adacore.com>
1097
1098 * compile/compile.c (_initialize_compile): Use _(), not N_().
1099 * thread.c (_initialize_thread): Use _(), not N_().
1100 * stack.c (_initialize_stack): Use _(), not N_().
1101 * printcmd.c (_initialize_printcmd): Use _(), not N_().
1102
2b79f376
SM
11032019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
1104
1105 * dwarf2read.c (struct dw2_symtab_iterator):
1106 <want_specific_block>: Remove.
1107 <block_index>: Change type to gdb::optional.
1108 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1109 change type of BLOCK_INDEX parameter to gdb::optional.
1110 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1111 (dw2_lookup_symbol): Don't pass argument for
1112 WANT_SPECIFIC_BLOCK.
1113 (dw2_expand_symtabs_for_function): Don't pass argument for
1114 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1115 (class dw2_debug_names_iterator)
1116 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1117 parameter, change BLOCK_INDEX type to gdb::optional.
1118 <m_want_specific_block>: Remove.
1119 <m_block_index>: Change type to gdb::optional.
1120 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1121 gdb::optional. Re-write in function of gdb::optional.
1122 (dw2_debug_names_lookup_symbol): Don't pass argument for
1123 WANT_SPECIFIC_BLOCK.
1124 (dw2_debug_names_expand_symtabs_for_function): Don't pass
1125 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1126 BLOCK_INDEX.
1127
ae60f04e
PW
11282019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1129
1130 * NEWS: Mention changes to "info sources" command.
1131
28cd9371
PW
11322019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1133
1134 * symtab.c (filename_partial_match_opts): New struct type.
1135 (struct output_source_filename_data): New members
1136 regexp, c_regexp, partial_match.
1137 (output_source_filename): Use new members to decide to print file.
1138 (info_sources_option_defs): New variable.
1139 (make_info_sources_options_def_group, print_info_sources_header,
1140 info_sources_command_completer):
1141 New functions.
1142 (info_sources_command): Read new optional arguments.
1143 (_initialize_symtab): Update info sources help.
1144
ca683e3a
AO
11452019-08-02 Alexandre Oliva <oliva@adacore.com>
1146
1147 * ada-lang.c (exception_support_info_v0): Renamed from...
1148 (default_exception_support_info): ... this. Create new
1149 definition for v1.
1150 (ada_has_this_exception_support): Look up catch_handlers_sym.
1151 (ada_exception_support_info_sniffer): Try v0 after default.
1152
f1264162
TT
11532019-08-01 Tom Tromey <tromey@adacore.com>
1154
1155 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1156 gdbarch.h.
1157
0a7b2485
CB
11582019-08-01 Christian Biesinger <cbiesinger@google.com>
1159
1160 * s12z-tdep.c: Fix include path for s12z-opc.h.
1161
c6bdbeb7
AH
11622019-08-01 Alan Hayward <alan.hayward@arm.com>
1163
1164 * NEWS: Require GNU make 3.82.
1165
a2bd7b82
TT
11662019-07-16 Tom Tromey <tom@tromey.com>
1167
1168 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1169 declare.
1170
aa3b6533
TT
11712019-07-30 Tom Tromey <tromey@adacore.com>
1172
1173 * block.c (contained_in): Remove BLOCK_FUNCTION check.
1174
a1530dc7
KB
11752019-07-30 Kevin Buettner <kevinb@redhat.com>
1176
1177 * printcmd.c (print_address_symbolic): Print negative offsets.
1178 (build_address_symbolic): Force signed arithmetic when computing
1179 offset.
1180
2906593f
CB
11812019-07-30 Christian Biesinger <cbiesinger@google.com>
1182
1183 PR/24474: Add a function to lookup static variables.
1184 * NEWS: Mention this new function.
1185 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1186 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1187 * python/python.c (python_GdbMethods): Add new function.
1188
c620ed88
CB
11892019-07-29 Christian Biesinger <cbiesinger@google.com>
1190
1191 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1192 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1193 (objfpy_lookup_static_symbol): New function.
1194 (objfile_object_methods): Add new functions.
1195
bc4268a5
PW
11962019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1197
1198 * NEWS: Mention 'set|show print frame-info'. Mention new
1199 'presence' value for 'frame-arguments'. Mention new '-frame-info'
1200 backtrace argument. Mention that python frame filtering code
1201 is now consistent with what 'backtrace' command prints.
1202
4b5e8d19
PW
12032019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1204
1205 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1206 comments.
1207 (print_frame_info_auto, print_frame_info_source_line,
1208 print_frame_info_location, print_frame_info_source_and_location,
1209 print_frame_info_location_and_address, print_frame_info_short_location):
1210 New declarations.
1211 (struct frame_print_options): New member print_frame_info.
1212 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1213 * stack.h (get_user_print_what_frame_info): New declaration.
1214 (frame_show_address): New declaration.
1215 * stack.c (print_frame_arguments_choices): New value 'presence'.
1216 (print_frame_info_auto, print_frame_info_source_line,
1217 print_frame_info_location, print_frame_info_source_and_location,
1218 print_frame_info_location_and_address, print_frame_info_short_location,
1219 print_frame_info_choices, print_frame_info_print_what): New definitions.
1220 (print_frame_args): Only print dots for args if print frame-arguments
1221 is 'presence'.
1222 (frame_print_option_defs): New element for "frame-info".
1223 (get_user_print_what_frame_info): New function.
1224 (frame_show_address): Make non static. Move comment to stack.h.
1225 (print_frame_info_to_print_what): New function.
1226 (print_frame_info): Update comment. Use fp_opts.print_frame_info
1227 to decide what to print.
1228 (backtrace_command_1): Handle the new print_frame_arguments_presence
1229 value.
1230 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1231 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1232 (py_print_frame): In non-mi mode, use LOCATION as default for
1233 print_what, similarly to frame information printed directly by
1234 backtrace command. Handle frame-info user option in non MI mode.
1235
6bdfee81
KB
12362019-07-27 Kevin Buettner <kevinb@redhat.com>
1237
1238 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1239 Add case for debugging 32-bit target on 64-bit host. Revise
1240 comment.
1241
98a617f8
KB
12422019-07-27 Kevin Buettner <kevinb@redhat.com>
1243
1244 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1245 instead of find_function_entry_range_from_pc.
1246
567238c9
KB
12472019-07-27 Kevin Buettner <kevinb@redhat.com>
1248
1249 * stack.c (find_frame_funname): Remove code which preferred
1250 minsym over symtab sym in "certain pathological cases".
1251
2dc80cf8
KB
1252 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1253 parameter. Change type of "do_demangle" to bool.
1254 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1255 Pass suitable "prefer_sym_over_minsym" flag to
1256 build_address_symbolic(). Don't output "+" for negative offsets.
1257 * printcmd.c (print_address_symbolic): Update invocation of
1258 build_address_symbolic to include a "prefer_sym_over_minsym"
1259 flag.
1260 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1261 Restrict cases in which use of minimal symbol is preferred to that
1262 of a found symbol. Update comments.
1263
1aff7173
KB
1264 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1265 for entry pc when entry pc is out of range for that FDE.
1266
89b085ac
BC
12672019-07-26 Brian Callahan <bcallah@openbsd.org>
1268
1269 PR gdb/24839:
1270 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1271 type.
1272
f32feb4a
CB
12732019-07-25 Christian Biesinger <cbiesinger@google.com>
1274
1275 * python/py-objfile.c (add_separate_debug_file): Fix comment about
1276 this function's Python signature.
1277
1278
12792019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
1280
1281 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1282 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1283 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1284 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1285 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1286
1287
c54e4253
YS
12882019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
1289
1290 * h8300-tdep.c (h8300_register_name_common): New.
1291 h8300_register_name): Use h8300_register_name_common.
1292 (h8300s_register_name): Likewise.
1293 (h8300sx_register_name): Likewise.
1294 (h8300h_register_nam): New.
1295 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1296
1297
40eadf04
SP
12982019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
1299
1300 * arm-tdep.c (arm_skip_cmse_entry): New function.
1301 (arm_is_sgstubs_section): New function.
1302 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1303
bfa2a36d
TT
13042019-07-22 Tom Tromey <tom@tromey.com>
1305
1306 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1307 Don't self-assign.
1308
a8e9d247
AB
13092019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1310
1311 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1312 type_print.
1313
eb86c5e2
AB
13142019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1315
1316 * symtab.c (search_symbols): Adjust msymbol matching type arrays
1317 so that GDB doesn't match any msymbols when searching in the
1318 TYPES_DOMAIN.
1319 (print_symbol_info): Print using typedef_print or type_print based
1320 on the type of the symbol. Add updated FIXME comment moved from...
1321 (_initialize_symtab): ... move and update FIXME comment to above.
1322
a8eab7c6
AB
13232019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1324
1325 * NEWS: Mention adding -q option to "info types".
1326 * symtab.c (struct info_types_options): New struct.
1327 (info_types_options_defs): New variable.
1328 (make_info_types_options_def_group): New function.
1329 (info_types_command): Use gdb::option framework to parse options.
1330 (info_types_command_completer): New function.
1331 (_initialize_symtab): Extend the help text on "info types" and
1332 register command completer.
1333
b4603c34
CB
13342019-07-21 Christian Biesinger <cbiesinger@google.com>
1335
1336 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1337 (lookup_symbol_in_objfile): Change int to block_enum and add a
1338 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1339
c8cdc1e0
CB
13402019-07-20 Christian Biesinger <cbiesinger@google.com>
1341
1342 * MAINTAINERS (Write After Approval): Add self.
1343
01e175fe
AB
13442019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
1345
1346 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1347 instruction to the dummy code region.
1348
56f79b63
TT
13492019-07-19 Tom Tromey <tromey@adacore.com>
1350
1351 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1352 (ARGSUSED, PARAMS, __func__): Remove rules.
1353
4c5aa8e0
AH
13542019-07-19 Alan Hayward <alan.hayward@arm.com>
1355
1356 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1357 * features/arm/arm-with-iwmmxt.c: Remove.
1358 * features/arm/arm-with-iwmmxt.xml: Remove.
1359 * features/arm/arm-with-m-fpa-layout.c: Remove.
1360 * features/arm/arm-with-m-fpa-layout.xml: Remove.
1361 * features/arm/arm-with-m-vfp-d16.c: Remove.
1362 * features/arm/arm-with-m-vfp-d16.xml: Remove.
1363 * features/arm/arm-with-m.c: Remove.
1364 * features/arm/arm-with-m.xml: Remove.
1365 * features/arm/arm-with-neon.c: Remove.
1366 * features/arm/arm-with-neon.xml: Remove.
1367 * features/arm/arm-with-vfpv2.c: Remove.
1368 * features/arm/arm-with-vfpv2.xml: Remove.
1369 * features/arm/arm-with-vfpv3.c: Remove.
1370 * features/arm/arm-with-vfpv3.xml: Remove.
1371
f42b2617
AH
13722019-07-19 Alan Hayward <alan.hayward@arm.com>
1373
1374 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1375
f29ec966
AH
13762019-07-19 Alan Hayward <alan.hayward@arm.com>
1377
1378 * arch/aarch32.c (aarch32_create_target_description): Create
1379 target descriptions using features.
1380 * arch/arm.c (arm_create_target_description)
1381 (arm_create_mprofile_target_description): Likewise.
1382 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1383
d105cce5
AH
13842019-07-19 Alan Hayward <alan.hayward@arm.com>
1385
1386 * Makefile.in: Add new files.
1387 * aarch32-tdep.c: New file.
1388 * aarch32-tdep.h: New file.
1389 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1390 Call aarch32_read_description.
1391 * arch/aarch32.c: New file.
1392 * arch/aarch32.h: New file.
1393 * arch/arm.c (arm_create_target_description)
1394 (arm_create_mprofile_target_description): New function.
1395 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1396 (arm_create_target_description)
1397 (arm_create_mprofile_target_description): New declaration.
1398 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1399 read_description functions.
1400 * arm-linux-nat.c (arm_linux_nat_target::read_description):
1401 Likewise.
1402 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1403 * arm-tdep.c (tdesc_arm_list): New variable.
1404 (arm_register_g_packet_guesses): Call create description functions.
1405 (arm_read_description) (arm_read_mprofile_description): New
1406 function.
1407 * arm-tdep.h (arm_read_description)
1408 (arm_read_mprofile_description): Add declaration.
1409 * configure.tgt: Add new files.
1410
afe09f0b
GL
14112019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
1412
1413 * top.c (new_ui_command): Open specified terminal just once.
1414
cd215b2e
TT
14152019-07-18 Tom Tromey <tromey@adacore.com>
1416
1417 * symtab.c (main_name): Constify return type.
1418 * symfile.c (set_initial_language): Update.
1419 * symtab.h (main_name): Constify return type.
1420
d8f68fcb
TT
14212019-07-17 Tom Tromey <tom@tromey.com>
1422
1423 * tui/tui-winsource.c (tui_update_source_window)
1424 (tui_update_source_window_as_is)
1425 (tui_update_source_windows_with_line): Remove return.
1426 * tui/tui-disasm.c (tui_show_disassem)
1427 (tui_show_disassem_and_update_source): Remove return.
1428 * tui/tui.c (tui_reset): Remove return.
1429 * tui/tui-wingeneral.c
1430 (tui_check_and_display_highlight_if_needed): Remove return.
1431
ca5af91e
TT
14322019-07-17 Tom Tromey <tom@tromey.com>
1433
1434 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1435
5104fe36
TT
14362019-07-17 Tom Tromey <tom@tromey.com>
1437
1438 * tui/tui-winsource.h (struct tui_exec_info_window)
1439 (struct tui_source_window_base): Move from tui-data.h.
1440 * tui/tui-winsource.c: Move many method definitions from
1441 elsewhere. Remove "structuring" comments.
1442 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1443 (tui_source_window_base::refresh_window): Move to
1444 tui-winsource.c.
1445 * tui/tui-win.c (tui_source_window_base::refresh_all)
1446 (tui_source_window_base::update_tab_width)
1447 (tui_source_window_base::set_new_height)
1448 (tui_source_window_base::do_make_visible_with_new_height): Move to
1449 tui-winsource.c.
1450 * tui/tui-source.h: Update.
1451 * tui/tui-source.c (tui_source_window_base::reset): Move to
1452 tui-winsource.c.
1453 * tui/tui-disasm.h: Update.
1454 * tui/tui-data.h (struct tui_exec_info_window): Move to
1455 tui-winsource.h.
1456 (struct tui_source_window_base): Likewise.
1457 * tui/tui-data.c (tui_source_window_base::clear_detail)
1458 (tui_source_window_base, ~tui_source_window_base): Move to
1459 tui-winsource.c.
1460
daa15dde
TT
14612019-07-17 Tom Tromey <tom@tromey.com>
1462
1463 * tui/tui-win.c (tui_resize_all)
1464 (tui_source_window_base::update_tab_width)
1465 (tui_adjust_win_heights): Update.
1466 (tui_win_info::make_invisible_and_set_new_height): Rename from
1467 make_invisible_and_set_new_height.
1468 * tui/tui-data.h (struct tui_win_info)
1469 <make_invisible_and_set_new_height>: New method.
1470
bfad4537
TT
14712019-07-17 Tom Tromey <tom@tromey.com>
1472
1473 * tui/tui.c: Update.
1474 * tui/tui-source.h (struct tui_source_window): Move from
1475 tui-data.h.
1476 * tui/tui-layout.c: Update.
1477 * tui/tui-disasm.c: Update.
1478 * tui/tui-data.h (struct tui_source_window): Move to
1479 tui-source.h.
1480
88f7e873
TT
14812019-07-17 Tom Tromey <tom@tromey.com>
1482
1483 * tui/tui-disasm.h (struct tui_disasm_window): Move from
1484 tui-data.h.
1485 * tui/tui-data.h (struct tui_disasm_window): Move to
1486 tui-disasm.h.
1487
96bd6233
TT
14882019-07-17 Tom Tromey <tom@tromey.com>
1489
1490 * tui/tui-regs.h (struct tui_data_item_window): Move from
1491 tui-data.h.
1492 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1493 * tui/tui-data.h (struct tui_data_item_window): Move to
1494 tui-regs.h.
1495 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1496
ce38393b
TT
14972019-07-17 Tom Tromey <tom@tromey.com>
1498
1499 * tui/tui.c: Update.
1500 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1501 (tui_cmd_window::max_height): Move to tui-command.c.
1502 * tui/tui-layout.c: Update.
1503 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1504 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1505 tui-command.c.
1506 * tui/tui-command.h (struct tui_cmd_window): Move from
1507 tui-data.h.
1508 * tui/tui-command.c: Remove "structuring" comments.
1509 (tui_cmd_window::clear_detail)
1510 (tui_cmd_window::do_make_visible_with_new_height)
1511 (tui_cmd_window::max_height): Move from elsewhere.
1512
2d8b51cb
TT
15132019-07-17 Tom Tromey <tom@tromey.com>
1514
1515 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1516 Now static.
1517 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1518 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1519
18ab23af
TT
15202019-07-17 Tom Tromey <tom@tromey.com>
1521
1522 * tui/tui.c: Update.
1523 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1524 tui-regs.c.
1525 * tui/tui-windata.h: Remove file.
1526 * tui/tui-windata.c: Remove file.
1527 * tui/tui-win.c (tui_data_window::set_new_height)
1528 (tui_data_window::do_make_visible_with_new_height): Move to
1529 tui-regs.c.
1530 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1531 * tui/tui-regs.c: Remove "structuring" comments.
1532 (tui_data_window::first_data_item_displayed)
1533 (tui_data_window::delete_data_content_windows)
1534 (tui_data_window::erase_data_content)
1535 (tui_data_window::display_all_data)
1536 (tui_data_window::refresh_all)
1537 (tui_data_window::do_scroll_vertical)
1538 (tui_data_window::clear_detail, tui_data_window::set_new_height)
1539 (tui_data_window::do_make_visible_with_new_height)
1540 (tui_data_window::refresh_window): Move from elsewhere.
1541 (_initialize_tui_regs): Move to end of file.
1542 * tui/tui-layout.c: Update.
1543 * tui/tui-hooks.c: Update.
1544 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1545 * tui/tui-data.c (tui_data_window::clear_detail): Move to
1546 tui-regs.c.
1547 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1548
88b7e7cc
TT
15492019-07-17 Tom Tromey <tom@tromey.com>
1550
1551 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1552 seen.
1553
0fcd3711
TT
15542019-07-17 Tom Tromey <tom@tromey.com>
1555
1556 * tui/tui-win.c (tui_source_window_base::set_new_height)
1557 (tui_source_window_base::do_make_visible_with_new_height): Use
1558 m_has_locator field directly.
1559 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1560 method.
1561 (struct tui_source_window_base) <has_locator>: Likewise.
1562
4a38112d
TT
15632019-07-17 Tom Tromey <tom@tromey.com>
1564
1565 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1566 Don't declare.
1567 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1568 Remove.
1569 * tui/tui-win.c (tui_source_window_base::set_new_height)
1570 (tui_source_window_base::set_new_height)
1571 (make_invisible_and_set_new_height)
1572 (tui_source_window_base::do_make_visible_with_new_height)
1573 (tui_source_window_base::do_make_visible_with_new_height):
1574 Update.
1575 * tui/tui-layout.c (show_source_disasm_command, show_data)
1576 (show_source_or_disasm_and_command): Update.
1577 * tui/tui-layout.c (show_layout): Update.
1578
09129226
TT
15792019-07-17 Tom Tromey <tom@tromey.com>
1580
1581 * tui/tui-layout.c (make_data_window): Remove.
1582 (show_data): Unify creation and re-initialization cases.
1583
4a8a5e84
TT
15842019-07-17 Tom Tromey <tom@tromey.com>
1585
1586 * tui/tui-layout.c (make_source_window, make_disasm_window):
1587 Remove.
1588 (show_data): Unify creation and re-initialization cases.
1589
76d2be8e
TT
15902019-07-17 Tom Tromey <tom@tromey.com>
1591
1592 * tui/tui-layout.c (make_command_window): Remove.
1593 (show_source_disasm_command, show_source_or_disasm_and_command):
1594 Unify creation and re-initialization cases.
1595
890b8bde
TT
15962019-07-17 Tom Tromey <tom@tromey.com>
1597
1598 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1599 creation and re-initialization cases.
1600
2cdfa113
TT
16012019-07-17 Tom Tromey <tom@tromey.com>
1602
1603 * tui/tui-regs.c (tui_get_register): Return void.
1604
8e3cfd09
TT
16052019-07-17 Tom Tromey <tom@tromey.com>
1606
1607 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1608 Simplify.
1609
f4e04977
TT
16102019-07-17 Tom Tromey <tom@tromey.com>
1611
1612 * tui/tui-layout.c (show_source_disasm_command): Simplify window
1613 resetting.
1614
0379b883
TT
16152019-07-17 Tom Tromey <tom@tromey.com>
1616
1617 * tui/tui.h (tui_set_layout_by_name): Don't declare.
1618 * tui/tui-regs.c (tui_reg_layout): New function.
1619 (tui_show_registers, tui_reg_command): Use it.
1620 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1621 (tui_layout_command): Rename from tui_set_layout_by_name. Change
1622 parameters.
1623 (tui_layout_command): Remove.
1624
b7fbad91
TT
16252019-07-17 Tom Tromey <tom@tromey.com>
1626
1627 * tui/tui-layout.h (tui/tui-layout): Return void.
1628 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
1629
4e1e56b9
TT
16302019-07-17 Tom Tromey <tom@tromey.com>
1631
1632 * tui/tui-layout.c (show_source_disasm_command, show_data):
1633 Update.
1634 (reset_locator): Remove.
1635 (show_source_or_disasm_and_command): Update.
1636
1e0c09ba
TT
16372019-07-17 Tom Tromey <tom@tromey.com>
1638
1639 * tui/tui-source.c (tui_source_window_base::reset): Remove
1640 win_type parameter.
1641 * tui/tui-layout.c (make_command_window, make_source_window)
1642 (make_disasm_window, make_data_window)
1643 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1644 (reset_locator, show_source_or_disasm_and_command): Update.
1645 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1646 win_type parameter.
1647 (struct tui_source_window_base) <reset>: Likewise.
1648
1bf605de
TT
16492019-07-17 Tom Tromey <tom@tromey.com>
1650
1651 * tui/tui-layout.c (show_source_disasm_command): Use
1652 reset_locator.
1653 (reset_locator): New function.
1654 (init_and_make_win): Remove.
1655 (show_source_or_disasm_and_command): Use reset_locator.
1656
098f9ed4
TT
16572019-07-17 Tom Tromey <tom@tromey.com>
1658
1659 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1660 condition.
1661 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1662 Remove condition.
1663 * tui/tui-source.c (tui_source_window_base::reset): New method.
1664 * tui/tui-layout.c (make_command_window): Don't call
1665 init_and_make_win.
1666 (make_source_window, make_disasm_window): Don't call
1667 make_source_or_disasm_window.
1668 (make_data_window): Don't call init_and_make_win. Change calling
1669 convention.
1670 (show_source_disasm_command, show_data): Simplify.
1671 (make_source_or_disasm_window): Remove.
1672 (show_source_or_disasm_and_command): Simplify.
1673 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1674 (struct tui_source_window_base) <reset>: Likewise.
1675 <execution_info>: Remove initializer.
1676 * tui/tui-data.c (tui_source_window_base): Initialize
1677 execution_info.
1678
80110957
TT
16792019-07-17 Tom Tromey <tom@tromey.com>
1680
1681 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1682 variable.
1683
cf82af05
TT
16842019-07-17 Tom Tromey <tom@tromey.com>
1685
1686 * tui/tui.c (tui_rl_other_window): Update.
1687 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1688 superclass method first. Always iterate over regs_content.
1689 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1690 method.
1691 * tui/tui-win.c (tui_set_focus_command): Update.
1692
01aeb396
TT
16932019-07-17 Tom Tromey <tom@tromey.com>
1694
1695 * tui/tui-win.c (tui_set_focus_command): Rename from
1696 tui_set_focus. Call tui_enable.
1697 (tui_set_focus_command): Remove.
1698
fd6c75ee
TT
16992019-07-17 Tom Tromey <tom@tromey.com>
1700
1701 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1702 refresh_window.
1703 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1704 touchwin.
1705 (tui_data_window::refresh_window): Call refresh_window on data
1706 items. Always call superclass refresh_window.
1707 (tui_win_info::refresh): Remove.
1708 (tui_source_window_base::refresh_window): Update.
1709 (tui_refresh_all): Update.
1710 * tui/tui-layout.c (show_source_disasm_command): Remove call to
1711 refresh_window.
1712 (show_source_or_disasm_and_command): Likewise.
1713 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1714 (struct tui_source_window_base) <refresh>: Likewise.
1715
f6cc34a9
TT
17162019-07-17 Tom Tromey <tom@tromey.com>
1717
1718 * tui/tui-winsource.c (tui_clear_source_content)
1719 (tui_show_source_content): Update.
1720 * tui/tui-source.c (tui_source_window::showing_source_p): Check
1721 whether content is empty.
1722 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1723 Remove.
1724
f31ec9af
TT
17252019-07-17 Tom Tromey <tom@tromey.com>
1726
1727 * tui/tui-winsource.c (tui_erase_source_content): Clear the
1728 window's contents.
1729 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1730 * tui/tui-source.c (tui_set_source_content_nil): Remove.
1731
d1b6f1e5
TT
17322019-07-17 Tom Tromey <tom@tromey.com>
1733
1734 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1735 (struct tui_data_item_window): Update.
1736
d9743a13
TT
17372019-07-17 Tom Tromey <tom@tromey.com>
1738
1739 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1740 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1741 defines.
1742
caf0bc4e
TT
17432019-07-17 Tom Tromey <tom@tromey.com>
1744
1745 * tui/tui-winsource.h (tui_erase_source_content)
1746 (tui_clear_source_content): Remove "display_prompt" parameter.
1747 * tui/tui-winsource.c (tui_update_source_window_as_is)
1748 (tui_update_source_windows_with_addr): Update.
1749 (tui_clear_source_content): Remove "display_prompt" parameter.
1750 (tui_erase_source_content): Likewise. Simplify.
1751 (tui_show_source_content): Update.
1752 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1753 * tui/tui-stack.c (tui_show_frame_info): Update.
1754 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1755 Remove defines.
1756
9d391078
TT
17572019-07-17 Tom Tromey <tom@tromey.com>
1758
1759 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1760 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1761 parameter.
1762 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1763 parameter.
1764
a38da35d
TT
17652019-07-17 Tom Tromey <tom@tromey.com>
1766
1767 * tui/tui-winsource.c (tui_clear_source_content)
1768 (tui_show_source_content, tui_show_exec_info_content)
1769 (tui_clear_exec_info_content): Update.
1770 * tui/tui-stack.c (tui_show_locator_content): Update.
1771 (tui_show_frame_info): Update.
1772 * tui/tui-source.h (tui_source_window): Don't declare.
1773 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1774 from tui_source_is_displayed.
1775 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1776 Remove field.
1777 (struct tui_source_window_base) <content_in_use>: New field. Now
1778 bool.
1779 (struct tui_source_window) <showing_source_p>: New method.
1780 (TUI_SRC_WIN): Change cast.
1781 * tui/tui-data.c (tui_initialize_static_data): Update.
1782
c2cd8994
TT
17832019-07-17 Tom Tromey <tom@tromey.com>
1784
1785 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1786 location_matches_p.
1787 * tui/tui-source.c (tui_source_window::location_matches_p): New
1788 method.
1789 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1790 method.
1791 * tui/tui-data.h (struct tui_source_window_base)
1792 <location_matches_p>: New method.
1793 (struct tui_source_window, struct tui_disasm_window)
1794 <location_matches_p>: Likewise.
1795
4dde7b34
TT
17962019-07-17 Tom Tromey <tom@tromey.com>
1797
1798 * tui/tui-win.c (tui_set_win_height_command): Rename from
1799 tui_set_win_height.
1800 (tui_set_win_height_command): Remove.
1801
b73dd877
TT
18022019-07-17 Tom Tromey <tom@tromey.com>
1803
1804 * tui/tui-source.c (tui_source_window): New constructor. Add
1805 observer.
1806 (~tui_source_window): New destructor.
1807 (tui_source_window::style_changed): New method.
1808 * tui/tui-hooks.c (tui_redisplay_source): Remove.
1809 (tui_attach_detach_observers): Update.
1810 * tui/tui-data.h (struct tui_source_window): Make constructor not
1811 inline. Add destructor.
1812 (struct tui_source_window) <style_changed>: New method.
1813 <m_observable>: New member.
1814
ae2b5380
TT
18152019-07-17 Tom Tromey <tom@tromey.com>
1816
1817 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1818 * tui/tui-win.c (tui_resize_all): Fix typo.
1819
1ce3e844
TT
18202019-07-17 Tom Tromey <tom@tromey.com>
1821
1822 * tui/tui-wingeneral.h (tui_refresh_all): Update.
1823 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1824 (tui_refresh_all): Remove "list" parameter. Use foreach.
1825 * tui/tui-win.c (window_name_completer): Use foreach.
1826 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1827 (update_tab_width): Likewise.
1828 * tui/tui-layout.c (show_layout): Update.
1829 * tui/tui-data.h (class tui_window_iterator): New.
1830 (struct all_tui_windows): New.
1831 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1832
fe3eaf1c
TT
18332019-07-17 Tom Tromey <tom@tromey.com>
1834
1835 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1836 parameter. Don't reference globals.
1837 (tui_reg_command): Update.
1838
368c1354
TT
18392019-07-17 Tom Tromey <tom@tromey.com>
1840
1841 * tui/tui-regs.c (tui_show_registers): Simplify.
1842
e80cd204
TT
18432019-07-17 Tom Tromey <tom@tromey.com>
1844
1845 * tui/tui-regs.c (tui_show_registers): Update.
1846 (tui_show_register_group): Add win_info parameter.
1847
aca2dd16
TT
18482019-07-17 Tom Tromey <tom@tromey.com>
1849
1850 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1851 Rename from tui_display_reg_element_at_line.
1852 (tui_data_window::display_registers_from_line): Update.
1853 * tui/tui-data.h (struct tui_data_window)
1854 <display_reg_element_at_line>: New method.
1855
517e9505
TT
18562019-07-17 Tom Tromey <tom@tromey.com>
1857
1858 * tui/tui-regs.h (tui_display_registers_from)
1859 (tui_display_registers_from_line): Don't declare.
1860 * tui/tui-windata.c (tui_data_window::display_all_data)
1861 (tui_data_window::refresh_all)
1862 (tui_data_window::do_scroll_vertical): Update.
1863 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1864 from tui_display_registers_from.
1865 (tui_display_reg_element_at_line): Update.
1866 (tui_data_window::display_registers_from_line): Rename from
1867 tui_display_registers_from_line.
1868 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1869 display_registers_from_line>: New methods.
1870
f76d8b19
TT
18712019-07-17 Tom Tromey <tom@tromey.com>
1872
1873 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1874 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1875 from tui_erase_data_content.
1876 (tui_data_window::display_all_data)
1877 (tui_data_window::refresh_all)
1878 (tui_data_window::do_scroll_vertical): Update.
1879 * tui/tui-regs.c (tui_show_registers): Update.
1880 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1881 New method.
1882
b4094625
TT
18832019-07-17 Tom Tromey <tom@tromey.com>
1884
1885 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1886 declare.
1887 * tui/tui-windata.c
1888 (tui_data_window::delete_data_content_windows): Rename from
1889 tui_delete_data_content_windows.
1890 (tui_data_window::display_all_data)
1891 (tui_data_window::do_scroll_vertical): Update.
1892 * tui/tui-data.h (struct tui_data_window)
1893 <delete_data_content_windows>: New method.
1894
c223a729
TT
18952019-07-17 Tom Tromey <tom@tromey.com>
1896
1897 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1898 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1899
50daf268
TT
19002019-07-17 Tom Tromey <tom@tromey.com>
1901
1902 * tui/tui-windata.h (tui_display_all_data): Don't declare.
1903 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1904 from tui_display_all_data.
1905 * tui/tui-win.c
1906 (tui_data_window::do_make_visible_with_new_height): Update.
1907 * tui/tui-regs.c (tui_show_registers): Update.
1908 * tui/tui-layout.c (tui_set_layout): Update.
1909 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1910 method.
1911
df5f8cab
TT
19122019-07-17 Tom Tromey <tom@tromey.com>
1913
1914 * tui/tui-windata.h (tui_display_data_from): Don't declare.
1915 * tui/tui-windata.c (tui_display_data_from): Remove.
1916 (tui_data_window::refresh_all): Update.
1917
80cb6c27
TT
19182019-07-17 Tom Tromey <tom@tromey.com>
1919
1920 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1921 * tui/tui-windata.c (tui_display_data_from_line): Remove.
1922 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1923 tui_display_registers_from_line.
1924 * tui/tui-regs.h (tui_display_registers_from_line): Update.
1925 * tui/tui-regs.c (tui_display_registers_from_line): Remove
1926 "force_display" parameter.
1927
baff0c28
TT
19282019-07-17 Tom Tromey <tom@tromey.com>
1929
1930 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1931 declare.
1932 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1933 Rename from tui_first_reg_element_no_inline.
1934 (tui_display_reg_element_at_line)
1935 (tui_display_registers_from_line): Update.
1936 * tui/tui-data.h (struct tui_data_window)
1937 <first_reg_element_no_inline>: New method.
1938
3b23c5f2
TT
19392019-07-17 Tom Tromey <tom@tromey.com>
1940
1941 * tui/tui-windata.c (tui_display_data_from)
1942 (tui_data_window::do_scroll_vertical): Update.
1943 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1944 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1945 Rename from tui_line_from_reg_element_no.
1946 (tui_display_registers_from_line): Update.
1947 * tui/tui-data.h (struct tui_data_window)
1948 <line_from_reg_element_no>: New method.
1949
0b5ec218
TT
19502019-07-17 Tom Tromey <tom@tromey.com>
1951
1952 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1953 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1954 tui_last_regs_line_no.
1955 (tui_display_reg_element_at_line)
1956 (tui_display_registers_from_line): Update.
1957 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1958 method.
1959
0807ab7b
TT
19602019-07-17 Tom Tromey <tom@tromey.com>
1961
1962 PR tui/24722:
1963 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1964 (tui_update_breakpoint_info): Add "being_deleted" parameter.
1965 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1966 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1967 (tui_update_breakpoint_info): Likewise.
1968 * tui/tui-hooks.c (tui_event_create_breakpoint)
1969 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1970 Update.
1971
9ad7fdef
TT
19722019-07-17 Tom Tromey <tom@tromey.com>
1973
1974 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1975
5813316f
TT
19762019-07-17 Tom Tromey <tom@tromey.com>
1977
1978 * tui/tui-winsource.c (tui_update_source_window_as_is)
1979 (tui_update_source_windows_with_addr): Update.
1980 * tui/tui-source.h (tui_set_source_content)
1981 (tui_show_symtab_source): Add "win_info" parameter.
1982 * tui/tui-source.c (tui_set_source_content): Add "win_info"
1983 parameter.
1984 (tui_show_symtab_source): Likewise.
1985
00e264e7
TT
19862019-07-17 Tom Tromey <tom@tromey.com>
1987
1988 * tui/tui-wingeneral.c
1989 (tui_check_and_display_highlight_if_needed): Check can_highlight.
1990
06210ce4
TT
19912019-07-17 Tom Tromey <tom@tromey.com>
1992
1993 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1994 (struct tui_cmd_window) <can_scroll>: New method.
1995 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1996 method.
1997
381befee
TT
19982019-07-17 Tom Tromey <tromey@adacore.com>
1999
2000 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2001 do_field_signed>: Rename. Change type of "value".
2002 * ui-out.c (ui_out::field_signed): Rename from field_int.
2003 Change type of "value".
2004 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
2005 type of "value".
2006 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2007 do_field_int. Change type of "value".
2008 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2009 do_field_int. Change type of "value".
2010 * tracepoint.c (trace_status_mi, tfind_1)
2011 (print_one_static_tracepoint_marker): Update.
2012 * thread.c (print_thread_info_1, print_selected_thread_frame):
2013 Update.
2014 * stack.c (print_frame, print_frame_info): Update.
2015 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2016 Update.
2017 * source.c (print_source_lines_base): Update.
2018 * skip.c (info_skip_command): Update.
2019 * record-btrace.c (btrace_ui_out_decode_error)
2020 (btrace_call_history_src_line): Update.
2021 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2022 Update.
2023 * progspace.c (print_program_space): Update.
2024 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2025 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2026 do_field_int. Change type of "value".
2027 * mi/mi-out.c (mi_ui_out::do_table_begin)
2028 (mi_ui_out::do_table_header): Update.
2029 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
2030 type of "value".
2031 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2032 (mi_cmd_data_list_changed_registers, output_register)
2033 (mi_cmd_data_read_memory, mi_load_progress)
2034 (mi_cmd_trace_frame_collected): Update.
2035 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2036 Update.
2037 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2038 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2039 (mi_cmd_var_list_children, varobj_update_one): Update.
2040 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2041 (mi_cmd_stack_list_args, list_arg_or_local): Update.
2042 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2043 * inferior.c (print_inferior): Update.
2044 * gdb_bfd.c (print_one_bfd): Update.
2045 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2046 Update.
2047 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2048 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2049 do_field_int. Change type of "value".
2050 * cli-out.c (cli_ui_out::do_field_signed): Rename from
2051 do_field_int. Change type of "value".
2052 * breakpoint.c (watchpoint_check, print_breakpoint_location)
2053 (print_one_breakpoint_location, print_it_catch_fork)
2054 (print_one_catch_fork, print_it_catch_vfork)
2055 (print_one_catch_vfork, print_it_catch_solib)
2056 (print_it_catch_exec, print_it_ranged_breakpoint)
2057 (print_mention_watchpoint, print_mention_masked_watchpoint)
2058 (bkpt_print_it, update_static_tracepoint): Update.
2059 * break-catch-throw.c (print_it_exception_catchpoint): Update.
2060 * break-catch-syscall.c (print_it_catch_syscall): Update.
2061 * ada-tasks.c (print_ada_task_info): Update.
2062 * ada-lang.c (print_it_exception, print_mention_exception):
2063 Update.
2064
6b78c3f8
AB
20652019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
2066
2067 PR breakpoints/24541
2068 * gdbarch.c: Regenerate.
2069 * gdbarch.h: Regenerate.
2070 * gdbarch.sh: Adjust return type and parameter types for
2071 'stap_adjust_register'.
2072 (i386_stap_adjust_register): Adjust signature and return new
2073 register name.
2074 * stap-probe.c (stap_parse_register_operand): Adjust use of
2075 'gdbarch_stap_adjust_register'.
2076
d72a9b85
TT
20772019-07-17 Tom Tromey <tromey@adacore.com>
2078
2079 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
2080 declare VEC.
2081 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2082 std::vector.
2083 (struct s390_process_info): Add initializers.
2084 (s390_add_process): Use new.
2085 (s390_linux_nat_target::low_forget_process): Use delete.
2086 (s390_linux_nat_target::low_new_fork)
2087 (s390_linux_nat_target::stopped_by_watchpoint)
2088 (s390_linux_nat_target::low_prepare_to_resume)
2089 (s390_linux_nat_target::insert_watchpoint)
2090 (s390_linux_nat_target::insert_hw_breakpoint)
2091 (s390_linux_nat_target::remove_watchpoint)
2092 (s390_linux_nat_target::remove_hw_breakpoint): Update.
2093
206e6c58
JB
20942019-07-16 John Baldwin <jhb@FreeBSD.org>
2095
2096 * aarch64-fbsd-nat.c: Include regcache.h.
2097 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2098 argument.
2099 (aarch64_fbsd_nat_target::fetch_registers)
2100 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2101 variable.
2102 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2103
cbde90f2
JB
21042019-07-16 John Baldwin <jhb@FreeBSD.org>
2105
2106 * fbsd-nat.c: Include gdbarch.h.
2107
07128006
TT
21082019-07-15 Tom Tromey <tromey@adacore.com>
2109
2110 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2111
1f77b012
TT
21122019-07-15 Tom Tromey <tromey@adacore.com>
2113
2114 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2115 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2116 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2117 * cli-out.c (cli_ui_out::do_field_int): New method.
2118 * ui-out.c (ui_out::field_unsigned): New method.
2119 * symfile.c (generic_load): Use field_unsigned.
2120 (print_transfer_performance): Likewise.
2121 * record-btrace.c (ui_out_field_uint): Remove.
2122 (btrace_call_history_insn_range, btrace_call_history): Use
2123 field_unsigned.
2124 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2125 field_unsigned.
2126 * ui-out.h (class ui_out) <field_unsigned>: New method.
2127 <do_field_unsigned>: Likewise.
2128
33eca680
TT
21292019-07-15 Tom Tromey <tromey@adacore.com>
2130
2131 * mi/mi-main.c (list_available_thread_groups): Use field_string.
2132 * mi/mi-interp.c (mi_memory_changed): Use field_string.
2133 * target.c (flash_erase_command): Use field_string.
2134 * infrun.c (print_signal_received_reason): Use field_string.
2135 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2136 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2137 field_string.
2138 * ada-tasks.c (print_ada_task_info): Use field_string.
2139
ca8d69be
TT
21402019-07-15 Tom Tromey <tromey@adacore.com>
2141
2142 * target.c (flash_erase_command): Use field_core_addr.
2143 * symfile.c (generic_load): Use field_core_addr.
2144 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2145 Use field_core_addr.
2146 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2147 field_core_addr.
2148
0d4e84ed
AB
21492019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2150
2151 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2152 value if its desired type is smaller than a CORE_ADDR and signed.
2153
9a49df9d
AB
21542019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2155
2156 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2157 of changes to field names, and use new is_reference field to
2158 decide if a property is a reference or not.
2159 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2160 field.
2161 (struct dwarf2_property_baton): Update header comment, rename
2162 'referenced_type' to 'property_type' and update comments.
2163 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2164 default property type, store in property baton, update to take
2165 accound of renamed field.
2166 (read_func_scope): Update call to attr_to_dynamic_prop.
2167 (read_array_type): Likewise.
2168 (dwarf2_per_cu_addr_sized_int_type): New function.
2169 (read_subrange_index_type): Move type finding code to
2170 dwarf2_per_cu_addr_sized_int_type.
2171 (read_subrange_type): Update calls to attr_to_dynamic_prop.
2172 (dwarf2_per_cu_addr_type): New function.
2173 (set_die_type): Update calls to attr_to_dynamic_prop.
2174
b86352cf
AB
21752019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2176
2177 * dwarf2read.c (read_subrange_index_type): New function.
2178 (read_subrange_type): Move code into new function and call it.
2179 * gdbtypes.c (create_range_type): Add some asserts.
2180
603490bf
AB
21812019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2182
2183 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2184 update return statements.
2185 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2186 declaration, and update comment to match.
2187 * gdbtypes.c (resolve_dynamic_array): Update call to
2188 dwarf2_evaluate_property to match new return type.
2189
592f9d27
AB
21902019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2191
2192 * valarith.c (value_subscripted_rvalue): Change lowerbound
2193 parameter type from int to LONGEST.
2194 * value.h (value_subscripted_rvalue): Likewise in declaration.
2195
60cfcb20
AB
21962019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2197
2198 * cli/cli-utils.c (info_print_command_completer): New function.
2199 * cli/cli-utils.h: Add 'completer.h' include, and forward
2200 declaration for 'struct cmd_list_element'.
2201 (info_print_command_completer): Declare.
2202 * stack.c (_initialize_stack): Add completer for 'info locals' and
2203 'info args'.
2204 * symtab.c (_initialize_symtab): Add completer for 'info
2205 variables' and 'info functions'.
2206 * NEWS: Mention completion for additional info commands.
2207
b16507e0
AB
22082019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2209
2210 * cli/cli-utils.c (extract_info_print_args): Delete.
2211 (extract_arg_maybe_quoted): Delete.
2212 (info_print_options_defs): New variable.
2213 (make_info_print_options_def_group): New function.
2214 (extract_info_print_options): Define new function.
2215 * cli/cli-utils.h (extract_info_print_args): Delete.
2216 (struct info_print_options): New structure.
2217 (extract_info_print_options): Declare new function.
2218 * stack.c (info_locals_command): Update to use new
2219 extract_info_print_options, also add a header comment.
2220 (info_args_command): Likewise.
2221 * symtab.c (info_variables_command): Likewise.
2222 (info_functions_command): Likewise.
2223
021d8588
AB
22242019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2225
2226 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2227 to extract string arguments.
2228 * common/common-utils.c (extract_string_maybe_quoted): New function.
2229 * common/common-utils.h (extract_string_maybe_quoted): Declare.
2230
b777eb6d
TT
22312019-07-11 Tom Tromey <tromey@adacore.com>
2232
2233 * main.c (get_init_files): Use GDBINIT, not gdbinit.
2234 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2235 * top.h (gdbinit): Don't declare.
2236 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2237 into...
2238 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
2239 * top.c (gdb_init): Don't call init_cli_cmds.
2240 (gdbinit): Remove.
2241 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2242
72ee03ff
TT
22432019-07-11 Tom Tromey <tromey@adacore.com>
2244
2245 * python/py-inferior.c (add_thread_object): Don't use thread_obj
2246 after it has been moved.
2247
00db9531
SM
22482019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2249
2250 * valops.c (value_must_coerce_to_target): Change return type to
2251 bool.
2252 * value.h (value_must_coerce_to_target): Likewise.
2253
f2478a7e
SM
22542019-07-10 Simon Marchi <simon.marchi@efficios.com>
2255
2256 * breakpoint.c (is_hardware_watchpoint): Remove
2257 forward-declaration.
2258 (is_masked_watchpoint): Change return type to bool.
2259 (is_tracepoint): Likewise.
2260 (is_breakpoint): Likewise.
2261 (is_hardware_watchpoint): Likewise.
2262 (is_watchpoint): Likewise.
2263 (is_no_memory_software_watchpoint): Likewise.
2264 (is_catchpoint): Likewise.
2265 (breakpoint_1): Make FILTER parameter's return type bool.
2266 is_masked_watchpoint): Change return type to bool.
2267 (save_breakpoints): Make FILTER parameter's return type bool.
2268 * breakpoint.h (is_breakpoint): Change return type to bool.
2269 (is_watchpoint): Likewise.
2270 (is_catchpoint): Likewise.
2271 (is_tracepoint): Likewise.
2272
0d12e84c
TT
22732019-07-10 Tom Tromey <tom@tromey.com>
2274
2275 * defs.h: Don't include gdbarch.h.
2276 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2277 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2278 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2279 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2280 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2281 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2282 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2283 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2284 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2285 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2286 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2287 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2288 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2289 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2290 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2291 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2292 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2293 record-btrace.c, record.h, regcache-dump.c, regcache.h,
2294 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2295 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2296 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2297 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2298 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2299 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2300 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2301 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2302 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2303
f06f1252
TT
23042019-07-10 Tom Tromey <tromey@adacore.com>
2305
2306 * ada-lang.h (is_ada_exception_catchpoint): Declare.
2307 * breakpoint.c (init_ada_exception_breakpoint): Register as
2308 bp_catchpoint.
2309 (print_one_breakpoint_location, print_one_breakpoint): Use
2310 is_ada_exception_catchpoint.
2311 * ada-lang.c (class ada_catchpoint_location): Pass
2312 bp_loc_software_breakpoint to bp_location constructor.
2313 (is_ada_exception_catchpoint): New function.
2314
7a5d944b
TT
23152019-07-10 Tom Tromey <tromey@adacore.com>
2316
2317 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
2318 VEC.
2319 (struct arm_exidx_entry): New method operator<.
2320 (struct arm_exidx_data) <section_maps>: Change type.
2321 (arm_exidx_data_free): Remove.
2322 (arm_exidx_data_key): Change type. Move lower.
2323 (arm_exidx_new_objfile): Update.
2324 (arm_compare_exidx_entries): Remove.
2325 (arm_find_exidx_entry, _initialize_arm_tdep)
2326
48c66e1d
TT
23272019-07-10 Tom Tromey <tromey@adacore.com>
2328
2329 * solib-spu.c (ocl_program_data_key): Change type.
2330 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2331 Update.
2332
a269fbf1
TT
23332019-07-10 Tom Tromey <tromey@adacore.com>
2334
2335 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
2336 (struct solib_aix_inferior_data) <library_list>: Change type.
2337 (solib_aix_inferior_data_handle): Change type.
2338 (get_solib_aix_inferior_data): Update.
2339 (solib_aix_free_library_list): Remove.
2340 (library_list_start_library): Update.
2341 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2342 return type.
2343 (solib_aix_get_library_list)
2344 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2345 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2346
c294730c
TT
23472019-07-10 Tom Tromey <tromey@adacore.com>
2348
2349 * solib-dsbt.c (struct dsbt_info): Add initializers.
2350 (solib_dsbt_pspace_data): Change type.
2351 (dsbt_pspace_data_cleanup): Remove.
2352 (get_dsbt_info, _initialize_dsbt_solib): Update.
2353
9d52077d
TT
23542019-07-10 Tom Tromey <tromey@adacore.com>
2355
2356 * spu-tdep.c (spu_overlay_data): Change type.
2357 (spu_get_overlay_table, spu_overlay_new_objfile)
2358 (_initialize_spu_tdep): Update.
2359
22a20dca
TT
23602019-07-10 Tom Tromey <tromey@adacore.com>
2361
2362 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2363 destructor.
2364 (dbx_objfile_data_key): Change type and declare later.
2365 (DBX_SYMFILE_INFO): Rewrite.
2366 * dbxread.c (dbx_objfile_data_key): Change type.
2367 (dbx_symfile_init): Update.
2368 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
2369 (coffstab_build_psymtabs, elfstab_build_psymtabs)
2370 (stabsect_build_psymtabs, _initialize_dbxread): Update.
2371
cb60f420
TT
23722019-07-10 Tom Tromey <tromey@adacore.com>
2373
2374 * jit.c (jit_program_space_key): Change type. Move lower.
2375 (get_jit_program_space_data): Update.
2376 (jit_program_space_data_cleanup): Remove.
2377 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2378 Update.
2379 (struct jit_program_space_data): Add initializers.
2380
51df2ae3
TT
23812019-07-10 Tom Tromey <tromey@adacore.com>
2382
2383 * solib-darwin.c (struct darwin_info): Add initializers.
2384 (solib_darwin_pspace_data): Change type.
2385 (darwin_pspace_data_cleanup): Remove.
2386 (get_darwin_info, _initialize_darwin_solib): Update.
2387
18101a35
TT
23882019-07-10 Tom Tromey <tromey@adacore.com>
2389
2390 * remote-sim.c (struct sim_inferior_data): Add initializers,
2391 constructor, and destructor.
2392 (sim_inferior_data_key): Change type. Move lower.
2393 (check_for_duplicate_sim_descriptor): Update.
2394 (get_sim_inferior_data): Use new. Update.
2395 (~sim_inferior_data_cleanup): Rename from
2396 sim_inferior_data_cleanup. Simplify.
2397 (gdbsim_close_inferior, simulator_command)
2398 (sim_command_completer, _initialize_remote_sim): Update.
2399 (next_pid, INITIAL_PID): Move earlier.
2400
05b08ac1
TT
24012019-07-10 Tom Tromey <tromey@adacore.com>
2402
2403 * python/python-internal.h (create_thread_object): Return
2404 gdbpy_ref.
2405 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2406 * python/py-inferior.c (struct threadlist_entry): Add
2407 constructor.
2408 <thread_obj>: Now a gdbpy_ref.
2409 (thread_to_thread_object): Update.
2410 (add_thread_object): Use new.
2411 (delete_thread_object): Use delete.
2412 (infpy_threads): Update.
2413 (py_free_inferior): Update. Construct "inf_obj" after acquiring
2414 GIL.
2415
32372d80
TT
24162019-07-10 Tom Tromey <tromey@adacore.com>
2417
2418 * valops.c (value_cast): Specialize error message for Ada.
2419
5c458ae8
SM
24202019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2421
2422 * breakpoint.c (breakpoint_1): Update doc and parameter names.
2423
4c462cb0
SM
24242019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2425
2426 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2427 bpstat_should_step): Return bool, adjust comments.
2428 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2429 bpstat_should_step): Likewise.
2430
89abbcc2
AH
24312019-07-10 Alan Hayward <alan.hayward@arm.com>
2432
2433 * features/Makefile: Use feature target descriptions for Arm.
2434 * features/arm/arm-core.c: Generate new file.
2435 * features/arm/arm-fpa.c: Likewise.
2436 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2437 * features/arm/arm-m-profile.c: Likewise.
2438 * features/arm/arm-vfpv2.c: Likewise.
2439 * features/arm/arm-vfpv3.c: Likewise.
2440 * features/arm/xscale-iwmmxt.c: Likewise.
2441 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2442
166a82be
AH
24432019-07-10 Alan Hayward <alan.hayward@arm.com>
2444
2445 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2446 ptrace earlier.
2447
9fb4c7e9
AH
24482019-07-10 Alan Hayward <alan.hayward@arm.com>
2449
2450 * features/aarch64-pauth.c: Regenerate.
2451
e2d0f980
SM
24522019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
2453
2454 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2455 bool.
2456 (bpstat_what): Use false instead of 0.
2457
a38118e5
PA
24582019-07-09 Pedro Alves <palves@redhat.com>
2459
2460 * break-catch-throw.c (is_exception_catchpoint): New.
2461 * breakpoint.c (print_one_breakpoint_location): New parameter
2462 'raw_loc'. Handle it. Use
2463 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2464 looking at the breakpoint's type.
2465 (print_one_breakpoint): If handling "maint info breakpoints", also
2466 print locations of exception catchpoints.
2467 * breakpoint.h (is_exception_catchpoint): Declare.
2468
cb1e4e32
PA
24692019-07-09 Pedro Alves <palves@redhat.com>
2470
2471 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2472 "addr" field.
2473 (allocate_location_exception_catchpoint): New.
2474 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2475 (initialize_throw_catchpoint_ops): Install
2476 allocate_location_exception_catchpoint as allocate_location
2477 method.
2478 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2479 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2480 bp_loc_other.
2481 (breakpoint_address_is_meaningful): Delete.
2482 (bl_address_is_meaningful): New.
2483 (breakpoint_locations_match): Adjust comment.
2484 (bp_location_from_bp_type): New, factored out of...
2485 (bp_location::bp_location(breakpoint *)): ... this.
2486 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2487 factored out of...
2488 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
2489 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2490 breakpoint_address_is_meaningful.
2491 (bp_locations_compare): Adjust comment.
2492 (update_global_location_list): Use bl_address_is_meaningful
2493 instead of breakpoint_address_is_meaningful.
2494 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2495 explicit.
2496 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2497 * python/py-breakpoint.c (bppy_get_location): No longer check
2498 whether location is null.
2499
b58a68fe
PA
25002019-07-09 Pedro Alves <palves@redhat.com>
2501
2502 PR c++/15468
2503 * breakpoint.c (print_one_breakpoint_location): Remove
2504 single-location assert.
2505
268a13a5
TT
25062019-07-09 Tom Tromey <tom@tromey.com>
2507
2508 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2509 * configure: Rebuild.
2510 * configure.ac: Change common to gdbsupport.
2511 * gdbsupport: Rename from common.
2512 * acinclude.m4: Change common to gdbsupport.
2513 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2514 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2515 gdbsupport.
2516 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2517 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2518 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2519 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2520 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2521 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2522 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2523 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2524 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2525 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2526 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2527 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2528 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2529 coff-pe-read.c, command.h, compile/compile-c-support.c,
2530 compile/compile-c.h, compile/compile-cplus-symbols.c,
2531 compile/compile-cplus-types.c, compile/compile-cplus.h,
2532 compile/compile-loc2c.c, compile/compile.c, completer.c,
2533 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2534 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2535 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2536 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2537 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2538 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2539 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2540 features/aarch64-core.c, features/aarch64-fpu.c,
2541 features/aarch64-pauth.c, features/aarch64-sve.c,
2542 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2543 features/i386/32bit-core.c, features/i386/32bit-linux.c,
2544 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2545 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2546 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2547 features/i386/64bit-core.c, features/i386/64bit-linux.c,
2548 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2549 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2550 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2551 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2552 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2553 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2554 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2555 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2556 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2557 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2558 go32-nat.c, guile/guile.c, guile/scm-ports.c,
2559 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2560 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2561 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2562 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2563 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2564 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2565 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2566 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2567 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2568 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2569 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2570 minsyms.c, mips-linux-tdep.c, namespace.h,
2571 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2572 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2573 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2574 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2575 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2576 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2577 nat/linux-waitpid.c, nat/mips-linux-watch.c,
2578 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2579 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2580 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2581 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2582 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2583 procfs.c, producer.c, progspace.h, psymtab.h,
2584 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2585 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2586 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2587 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2588 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2589 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2590 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2591 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2592 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2593 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2594 target-memory.c, target.c, target.h, target/waitstatus.c,
2595 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2596 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2597 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2598 unittests/array-view-selftests.c,
2599 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2600 unittests/common-utils-selftests.c,
2601 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2602 unittests/format_pieces-selftests.c,
2603 unittests/function-view-selftests.c,
2604 unittests/lookup_name_info-selftests.c,
2605 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2606 unittests/mkdir-recursive-selftests.c,
2607 unittests/observable-selftests.c,
2608 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2609 unittests/parse-connection-spec-selftests.c,
2610 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2611 unittests/scoped_fd-selftests.c,
2612 unittests/scoped_mmap-selftests.c,
2613 unittests/scoped_restore-selftests.c,
2614 unittests/string_view-selftests.c, unittests/style-selftests.c,
2615 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2616 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2617 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2618 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2619 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2620 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2621
5b0e2db4
AB
26222019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2623
2624 * linespec.c (decode_digits_list_mode): Set explicit_line to a
2625 bool value.
2626 (decode_digits_ordinary): Set explicit_line field in sal.
2627 * symtab.c (skip_prologue_sal): Don't skip prologue for a
2628 symtab_and_line that was set on an explicit line number in
2629 assembler code. Do always update the recorded symtab and line if
2630 we do skip the prologue.
2631
0ba852ab
AB
26322019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2633
2634 * breakpoint.c (set_breakpoint_location_function): Remove
2635 explicit_loc parameter.
2636 (momentary_breakpoint_from_master): Update call to
2637 set_breakpoint_location_function.
2638 (add_location_to_breakpoint): Likewise.
2639
b3a7d171
AB
26402019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2641
2642 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2643 required features based on default bfd type when no specific bfd
2644 is present.
2645
1f6f6e21
PW
26462019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2647
2648 * NEWS: Mention that GDB printf and eval commands can now print
2649 C-style and Ada-style convenience var strings without
2650 calling the inferior.
2651 * printcmd.c (printf_c_string): Locally print GDB internal var
2652 instead of transiting via the inferior.
2653 (printf_wide_c_string): Likewise.
2654
26552019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
2656
2657 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2658
0598af48
TT
26592019-07-04 Tom Tromey <tom@tromey.com>
2660
2661 PR tui/24724:
2662 * tui/tui-winsource.c (tui_clear_source_content): Update.
2663 (tui_source_window_base::set_is_exec_point_at): Fix comment.
2664 (tui_update_breakpoint_info): Update.
2665 (tui_set_exec_info_content): Update.
2666 * tui/tui-source.c (tui_set_source_content_nil): Update.
2667 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2668 has_break.
2669 * tui/tui-data.h (enum tui_bp_flag): New.
2670 (tui_bp_flags): New enum flags type.
2671 (struct tui_source_element) <break_mode>: Change type. Rename
2672 from has_break.
2673 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2674 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
2675 constants.
2676 * tui/tui-winsource.h: Fix comment.
2677
350fab54
AH
26782019-07-04 Alan Hayward <alan.hayward@arm.com>
2679
2680 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2681 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2682 (store_fpregs_to_thread)
2683 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2684 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2685 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2686 (IWMMXT_REGS_SIZE): Add define.
2687 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2688 (fetch_vfp_regs, store_vfp_regs)
2689 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2690 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2691
f0452268
AH
26922019-07-04 Alan Hayward <alan.hayward@arm.com>
2693
2694 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2695 defines.
2696 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2697 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2698 (ARM_INT_REGISTER_SIZE): ...to this.
2699 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2700 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2701 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2702 (arm_linux_collect_gregset, supply_nwfpe_register)
2703 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2704 defines.
2705 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2706 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2707 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2708 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2709 (arm_return_in_memory, arm_store_return_value)
2710 (arm_get_longjmp_target, arm_register_g_packet_guesses)
2711 (arm_record_ld_st_multiple): Likewise.
2712 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2713 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2714
e935475c
AH
27152019-07-04 Alan Hayward <alan.hayward@arm.com>
2716
2717 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2718 AARCH64_DISPLACED_MODIFIED_INSNS.
2719 * aarch64-tdep.c (struct aarch64_displaced_step_data)
2720 (aarch64_displaced_step_copy_insn): Likewise.
2721 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2722 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2723 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2724 ARM_DISPLACED_MODIFIED_INSNS.
2725 * arm-tdep.c (arm_gdbarch_init): Likewise.
2726 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2727 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2728 (struct arm_displaced_step_closure): Use
2729 ARM_DISPLACED_MODIFIED_INSNS.
2730
df0bb381
AH
27312019-07-04 Alan Hayward <alan.hayward@arm.com>
2732
2733 * features/Makefile: Remove unused xml files.
2734 * features/aarch64.xml: Remove.
2735 * features/i386/amd64-avx-avx512-linux.xml: Remove.
2736 * features/i386/amd64-avx-avx512.xml: Remove.
2737 * features/i386/amd64-avx-linux.xml: Remove.
2738 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2739 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2740 * features/i386/amd64-avx-mpx-linux.xml: Remove.
2741 * features/i386/amd64-avx-mpx.xml: Remove.
2742 * features/i386/amd64-avx.xml: Remove.
2743 * features/i386/amd64-linux.xml: Remove.
2744 * features/i386/amd64-mpx-linux.xml: Remove.
2745 * features/i386/amd64-mpx.xml: Remove.
2746 * features/i386/amd64.xml: Remove.
2747 * features/i386/i386-avx-avx512-linux.xml: Remove.
2748 * features/i386/i386-avx-avx512.xml: Remove.
2749 * features/i386/i386-avx-linux.xml: Remove.
2750 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2751 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2752 * features/i386/i386-avx-mpx-linux.xml: Remove.
2753 * features/i386/i386-avx-mpx.xml: Remove.
2754 * features/i386/i386-avx.xml: Remove.
2755 * features/i386/i386-linux.xml: Remove.
2756 * features/i386/i386-mmx-linux.xml: Remove.
2757 * features/i386/i386-mmx.xml: Remove.
2758 * features/i386/i386-mpx-linux.xml: Remove.
2759 * features/i386/i386-mpx.xml: Remove.
2760 * features/i386/i386.xml: Remove.
2761 * features/i386/x32-avx-avx512-linux.xml: Remove.
2762 * features/i386/x32-avx-linux.xml: Remove.
2763 * features/i386/x32-linux.xml: Remove.
2764
edd6266a
AH
27652019-07-04 Alan Hayward <alan.hayward@arm.com>
2766
2767 * regformats/aarch64.dat: Remove.
2768 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2769 * regformats/i386/amd64-avx-linux.dat: Remove.
2770 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2771 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2772 * regformats/i386/amd64-linux.dat: Remove.
2773 * regformats/i386/amd64-mpx-linux.dat: Remove.
2774 * regformats/i386/amd64.dat: Remove.
2775 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2776 * regformats/i386/i386-avx-linux.dat: Remove.
2777 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2778 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2779 * regformats/i386/i386-linux.dat: Remove.
2780 * regformats/i386/i386-mmx-linux.dat: Remove.
2781 * regformats/i386/i386-mpx-linux.dat: Remove.
2782 * regformats/i386/i386.dat: Remove.
2783 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2784 * regformats/i386/x32-avx-linux.dat: Remove.
2785 * regformats/i386/x32-linux.dat: Remove.
2786
2b40fda7
AH
27872019-07-04 Alan Hayward <alan.hayward@arm.com>
2788
2789 * aarch64-tdep.c: Remove xml self tests.
2790 * amd64-linux-tdep.c: Likewise.
2791 * amd64-tdep.c: Likewise.
2792 * i386-linux-tdep.c: Likewise.
2793 * i386-tdep.c: Likewise.
2794
5f4ba3e7
PA
27952019-07-03 Pedro Alves <palves@redhat.com>
2796
2797 PR cli/24732
2798 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2799 (pipe_cmd_option_defs): New.
2800 (make_pipe_cmd_options_def_group): New.
2801 (pipe_command): Use gdb::option::process_options.
2802 (pipe_command_completer): New function.
2803 (_initialize_cli_cmds): Install completer for "pipe" command.
2804
3d9be6f5
PA
28052019-07-03 Pedro Alves <palves@redhat.com>
2806
2807 * cli/cli-option.c (union option_value) <string>: New field.
2808 (struct option_def_and_value): Add ctor, move ctor, dtor and
2809 use DISABLE_COPY_AND_ASSIGN.
2810 (option_def_and_value::clear_value): New.
2811 (parse_option, save_option_value_in_ctx, get_val_type_str)
2812 (add_setshow_cmds_for_options): Handle var_string.
2813 * cli-option.h (union option_def::var_address) <string>: New
2814 field.
2815 (struct string_option_def): New.
2816 * maint-test-options.c (struct test_options_opts): Add default
2817 ctor and use DISABLE_COPY_AND_ASSIGN.
2818 <string_opt>: New field.
2819 (test_options_opts::~test_options_opts): New.
2820 (test_options_opts::dump): Also dump "-string".
2821 (test_options_option_defs): Install "string.
2822
41fc454c
PA
28232019-07-03 Pedro Alves <palves@redhat.com>
2824
2825 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2826 option_value with a null enumeration.
2827 (complete_options): Save the option values in the context.
2828 (save_option_value_in_ctx): New, factored out from ...
2829 (process_options): ... here.
2830 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2831 of the function.
2832 * maint-test-options.c (test_options_opts::dump): New, factored
2833 out from ...
2834 (maintenance_test_options_command_mode): ... here.
2835 (maintenance_test_options_command_completion_result): Delete.
2836 (maintenance_test_options_command_completion_text): Update
2837 comment.
2838 (maintenance_show_test_options_completion_result): Change
2839 prototype. Just print
2840 maintenance_test_options_command_completion_text.
2841 (save_completion_result): New.
2842 (maintenance_test_options_completer_mode): Pass options context to
2843 complete_options, and then save a dump.
2844 (_initialize_maint_test_options): Use add_cmd to install "maint
2845 show test-options-completion-result".
2846
fdbc9870
PA
28472019-07-03 Pedro Alves <palves@redhat.com>
2848
2849 * NEWS (New commands): Mention "with" and "maint with".
2850 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2851 (with_command, with_command_completer): New.
2852 (pipe_command): Adjust to new repeat_previous
2853 interface.
2854 (_initialize_cli_cmds): Install the "with" command and its "w"
2855 alias.
2856 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2857 declarations.
2858 * cli/cli-setshow.c (parse_cli_var_uinteger)
2859 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2860 argument strings for all var_types.
2861 (get_setshow_command_value_string): New, factored out from ...
2862 (do_show_command): ... this.
2863 * cli/cli-setshow.h: Include <string>.
2864 (get_setshow_command_value_string): Declare.
2865 * command.h (repeat_previous): Now returns const char *. Adjust
2866 comment.
2867 * maint.c: Include "cli/cli-cmds.h".
2868 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2869 (_initialize_maint_cmds): Register the "maintenance with" command.
2870 * top.c (repeat_previous): Move bits from pipe_command here:
2871 Return the saved command line, if any; error out if there's no
2872 command to relaunch.
2873
c6ac8931
PA
28742019-07-03 Pedro Alves <palves@redhat.com>
2875
2876 * NEWS (New commands): Mention "maint set/show test-settings"
2877 instead of "maint test-settings".
2878 * maint-test-settings.c (maintenance_test_settings_list): Delete.
2879 (maintenance_test_settings_set_list): Rename to ...
2880 (maintenance_set_test_settings_list): ... this.
2881 (maintenance_test_settings_show_list): Rename to ...
2882 (maintenance_show_test_settings_list): ... this.
2883 (maintenance_test_settings_cmd): Delete.
2884 (maintenance_test_settings_set_cmd): ...
2885 (maintenance_set_test_settings_cmd): ... this.
2886 (maintenance_test_settings_show_cmd): ...
2887 (maintenance_show_test_settings_cmd): ... this.
2888 (maintenance_test_settings_show_value_cmd):
2889 (maintenance_show_test_settings_value_cmd): ... this.
2890 (_initialize_maint_test_settings): No longer install the "maint
2891 test-settings" prefix command. Rename "maint test-settings set"
2892 to "maint set test-settings", and "maint test-settings show" to
2893 "maint show test-settings". Adjust all subcommands.
2894
d1fcf2fd
PA
28952019-07-03 Pedro Alves <palves@redhat.com>
2896
2897 * maint-test-settings.c: Fix file's intro comment. Replace all
2898 references to "test-options" with references to "test-settings",
2899 in comments.
2900
970f9d09
PA
29012019-07-03 Pedro Alves <palves@redhat.com>
2902
2903 * maint-test-settings.c (maintenance_test_settings_xxx)
2904 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2905 New.
2906 (maintenance_test_settings_enums): Use them.
2907 (maintenance_test_settings_enum): Default to
2908 maintenance_test_settings_xxx.
2909 (_initialize_maint_test_settings): Initialize
2910 MAINTENANCE_TEST_SETTINGS_FILENAME.
2911
f3869b1a
SM
29122019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2913
2914 * breakpoint.h (remove_breakpoints_inf): Change return type to
2915 void, move function documentation here.
2916 * breakpoint.c (remove_breakpoints_inf): Change return type to
2917 void, move function documentation to header.
2918
54d66006
PA
29192019-07-02 Pedro Alves <palves@redhat.com>
2920
2921 * NEWS (Completion improvements): Mention "info threads".
2922 * thread.c (struct info_threads_opts, info_threads_option_defs)
2923 (make_info_threads_options_def_group): New.
2924 (info_threads_command): Use gdb::option::process_options.
2925 (info_threads_command_completer): New.
2926 (_initialize_thread): Use gdb::option::build_help to build the
2927 help text for "info threads".
2928
854f6088
SM
29292019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2930
2931 * defs.h (generic_load): Move from here...
2932 * symfile.h (generic_load): ... to here. Rename name parameter
2933 to args.
2934 * symfile.c (generic_load): Add comment.
2935
54ee4252
TT
29362019-07-01 Tom Tromey <tromey@adacore.com>
2937
2938 * dwarf2read.c
2939 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2940 declaration of without_params. Fix formatting.
2941
65392b3e
TT
29422019-07-01 Tom Tromey <tromey@adacore.com>
2943
2944 * ada-exp.y (find_primitive_type): Update.
2945 * ada-lang.h (ada_lookup_symbol): Update.
2946 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2947 parameter.
2948 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2949
7d7571f0
SDJ
29502019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2951
2952 PR breakpoints/24541
2953 * gdbarch.c: Regenerate.
2954 * gdbarch.h: Regenerate.
2955 * gdbarch.sh: Add 'stap_adjust_register'.
2956 * i386-tdep.c: Include '<unordered_set>'.
2957 (i386_stap_adjust_register): New function.
2958 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2959 * stap-probe.c (stap_parse_register_operand): Call
2960 'gdbarch_stap_adjust_register'.
2961
5af5392a
SDJ
29622019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2963
2964 PR python/24742
2965 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2966 * python/python.c (do_start_initialization): Use 'xmalloc'
2967 instead of 'PyMem_Malloc'.
2968
10d06d82
TT
29692019-06-28 Tom Tromey <tromey@adacore.com>
2970
2971 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2972 for Ada.
2973
1b7f24cd
TT
29742019-06-27 Tom Tromey <tromey@adacore.com>
2975
2976 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
2977 objfile_key.
2978 (arm_find_mapping_symbol, arm_record_special_symbol)
2979 (_initialize_arm_tdep): Update.
2980 (arm_objfile_data_free): Remove.
2981
3d507ff2
TT
29822019-06-27 Tom Tromey <tromey@adacore.com>
2983
2984 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2985 to cp_print_static_field.
2986
762c164d
TT
29872019-06-26 Tom Tromey <tromey@adacore.com>
2988
2989 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2990 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2991 declare.
2992
aa2f9bcf
AH
29932019-06-26 Alan Hayward <alan.hayward@arm.com>
2994
2995 * features/aarch64-core.c (create_feature_aarch64_core):
2996 Regenerate.
2997 * features/aarch64-core.xml: Add cpsr flags.
2998
3426ae57
AH
29992019-06-26 Alan Hayward <alan.hayward@arm.com>
3000
3001 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3002 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3003
4838e44c
SM
30042019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3005
3006 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3007 field.
3008 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3009 use.
3010 (arm_record_special_symbol): Don't insert new symbol in sorted
3011 position, push it at the end.
3012
54cc7474
SM
30132019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3014
3015 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3016 (arm_mapping_symbol_s): Remove.
3017 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3018 (arm_mapping_symbol_vec): New typedef.
3019 (struct arm_per_objfile): Add constructor.
3020 <section_maps>: Change type to
3021 std::unique_ptr<arm_mapping_symbol_vec[]>.
3022 (arm_compare_mapping_symbols): Remove.
3023 (arm_find_mapping_symbol): Adjust to section_maps type change.
3024 (arm_objfile_data_free): Call delete on arm_per_objfile.
3025 (arm_record_special_symbol): Adjust to section_maps type change.
3026 Allocate arm_per_objfile with new.
3027
b65b566c
PW
30282019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3029
3030 * cli/cli-cmds.c (alias_command): Compare the alias prefix
3031 with the command prefix.
3032
c2fc64f5
TT
30332019-06-25 Tom Tromey <tom@tromey.com>
3034
3035 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3036 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3037
fb54fa76
TT
30382019-06-25 Tom Tromey <tom@tromey.com>
3039
3040 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3041 type.
3042 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3043 protected.
3044
f7952c57
TT
30452019-06-25 Tom Tromey <tom@tromey.com>
3046
3047 * tui/tui-winsource.c
3048 (tui_source_window_base::set_is_exec_point_at): Add check against
3049 LOA_ADDRESS.
3050
17568d78
TT
30512019-06-25 Tom Tromey <tom@tromey.com>
3052
3053 * tui/tui-source.c (tui_set_source_content): Don't check before
3054 xfree.
3055 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3056
53e7cdba
TT
30572019-06-25 Tom Tromey <tom@tromey.com>
3058
3059 * tui/tui-winsource.h (tui_update_source_window_as_is)
3060 (tui_alloc_source_buffer, tui_line_is_displayed)
3061 (tui_addr_is_displayed): Change type of win_info.
3062 * tui/tui-winsource.c (tui_update_source_window_as_is)
3063 (tui_clear_source_content, tui_show_source_line)
3064 (tui_show_source_content, tui_source_window_base::refill)
3065 (tui_source_window_base::set_is_exec_point_at)
3066 (tui_source_window_base::set_is_exec_point_at)
3067 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3068 (tui_alloc_source_buffer, tui_line_is_displayed)
3069 (tui_addr_is_displayed): Change type of win_info. Update.
3070 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3071 (tui_source_window_base::do_make_visible_with_new_height):
3072 Update.
3073 * tui/tui-source.c (tui_set_source_content)
3074 (tui_set_source_content_nil)
3075 (tui_source_window::do_scroll_vertical): Update.
3076 * tui/tui-layout.c (show_layout): Update.
3077 * tui/tui-disasm.c (tui_set_disassem_content)
3078 (tui_disasm_window::do_scroll_vertical): Update.
3079 * tui/tui-data.h (tui_win_content): Remove.
3080 (struct tui_gen_win_info) <content, content_size>: Remove.
3081 (struct tui_source_element): Add initializers and destructor.
3082 (union tui_which_element, struct tui_win_element): Remove.
3083 (struct tui_source_window_base) <content>: New field.
3084 (struct tui_data_window): Remove destructor.
3085 (tui_alloc_content, tui_free_win_content)
3086 (tui_free_all_source_wins_content): Don't declare.
3087 * tui/tui-data.c (tui_initialize_static_data): Update.
3088 (init_content_element, tui_alloc_content): Remove.
3089 (~tui_gen_win_info): Update.
3090 (~tui_data_window, tui_free_all_source_wins_content)
3091 (tui_free_win_content, free_content, free_content_elements):
3092 Remove.
3093
7908abbf
TT
30942019-06-25 Tom Tromey <tom@tromey.com>
3095
3096 * tui/tui-winsource.h (tui_clear_source_content)
3097 (tui_erase_source_content, tui_show_source_content): Change type
3098 of win_info.
3099 * tui/tui-winsource.c (tui_clear_source_content)
3100 (tui_erase_source_content, tui_show_source_content): Change type
3101 of win_info.
3102 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3103 * tui/tui-source.h (tui_set_source_content_nil): Change type of
3104 win_info.
3105 * tui/tui-source.c (tui_set_source_content_nil): Change type of
3106 win_info.
3107 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3108
02c28df0
TT
31092019-06-25 Tom Tromey <tom@tromey.com>
3110
3111 * tui/tui-winsource.c (tui_clear_source_content)
3112 (tui_source_window_base::set_is_exec_point_at): Update.
3113 * tui/tui-source.c (tui_set_source_content_nil): Update.
3114 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3115 a bool.
3116 * tui/tui-data.c (init_content_element): Update.
3117
6658b1bf
TT
31182019-06-25 Tom Tromey <tom@tromey.com>
3119
3120 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3121 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3122 * tui/tui-layout.c (init_and_make_win): Update.
3123 * tui/tui.h (enum tui_win_type): Update.
3124 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3125 tui_win_is_auxillary.
3126 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3127 tui_win_is_auxillary.
3128
21e1c91e
TT
31292019-06-25 Tom Tromey <tom@tromey.com>
3130
3131 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3132 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3133 (tui_delete_data_content_windows, tui_display_all_data)
3134 (tui_data_window::do_scroll_vertical, tui_display_data_from):
3135 Update.
3136 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3137 * tui/tui-regs.c (tui_last_regs_line_no)
3138 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3139 (tui_show_registers): Update.
3140 (tui_show_register_group): Return void. Update.
3141 (tui_display_registers_from, tui_display_reg_element_at_line)
3142 (tui_display_registers_from_line, tui_check_register_values):
3143 Update.
3144 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3145 member.
3146 (struct tui_data_window) <regs_content>: Now a std::vector.
3147 <regs_content_count>: Remove.
3148 (tui_add_content_elements, tui_free_data_content): Don't declare.
3149 * tui/tui-data.c (tui_data_window::clear_detail): Update.
3150 (init_content_element): Remove DATA_WIN case. Add assert.
3151 (tui_add_content_elements): Remove.
3152 (tui_data_window): Update.
3153 (tui_free_data_content): Remove.
3154 (free_content_elements): Remove DATA_WIN case.
3155
115ac53b
TT
31562019-06-25 Tom Tromey <tom@tromey.com>
3157
3158 * tui/tui-data.c (tui_data_item_window): Update.
3159 * tui/tui-windata.h (tui_check_data_values): Don't declare.
3160 * tui/tui-windata.c (tui_display_all_data)
3161 (tui_display_data_from_line): Update.
3162 (tui_check_data_values): Remove.
3163 * tui/tui-regs.c (tui_show_register_group)
3164 (tui_display_reg_element_at_line): Update.
3165 * tui/tui-hooks.c (tui_register_changed)
3166 (tui_refresh_frame_and_register_information): Call
3167 tui_check_register_values.
3168 * tui/tui-data.h (struct tui_data_window) <data_content,
3169 data_content_count, data_type>: Remove.
3170 (enum tui_data_type): Remove.
3171
3172 * tui/tui-data.c (tui_data_window::clear_detail)
3173 (~tui_data_window): Update.
3174
eaf9738b
TT
31752019-06-25 Tom Tromey <tom@tromey.com>
3176
3177 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3178 declare.
3179 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3180 Rename from tui_first_data_item_displayed. Update.
3181 (tui_data_window::refresh_all)
3182 (tui_data_window::do_scroll_vertical): Update.
3183 * tui/tui-data.h (struct tui_data_window)
3184 <first_data_item_displayed>: Declare new method.
3185
31ca4723
TT
31862019-06-25 Tom Tromey <tom@tromey.com>
3187
3188 * tui/tui-data.h (tui_init_generic_part): Don't declare.
3189 * tui/tui-data.c (tui_init_generic_part): Remove, moving
3190 contents...
3191 (tui_initialize_static_data): ...here.
3192
41bcff7f
TT
31932019-06-25 Tom Tromey <tom@tromey.com>
3194
3195 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3196 (tui_display_registers_from, tui_check_register_values): Update.
3197 (tui_display_register): Remove win_info parameter; update.
3198 (tui_get_register): Change type of parameters.
3199 * tui/tui-data.h (struct tui_data_element): Remove.
3200 (union tui_which_element) <data>: Remove.
3201 <data_window>: Change type.
3202 (struct tui_data_item_window): New.
3203 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3204 case. Add assert.
3205 (~tui_data_item_window): New destructor.
3206 (free_content_elements): Remove DATA_ITEM_WIN case.
3207
d2802c33
TT
32082019-06-25 Tom Tromey <tom@tromey.com>
3209
3210 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3211 Remove.
3212
dd835f8b
TT
32132019-06-25 Tom Tromey <tom@tromey.com>
3214
3215 * tui/tui-data.h (struct tui_command_element): Remove.
3216 (union tui_which_element) <command>: Remove.
3217 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
3218 assert.
3219 (free_content_elements): Remove CMD_WIN case.
3220
bd7db367
TT
32212019-06-25 Tom Tromey <tom@tromey.com>
3222
3223 * tui/tui-layout.c (tui_set_layout): Update.
3224 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3225 * tui/tui-data.c (layout_def): Update.
3226
3add462f
TT
32272019-06-25 Tom Tromey <tom@tromey.com>
3228
3229 * tui/tui-wingeneral.c (tui_refresh_all): Update.
3230 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3231 (tui_source_window_base::set_new_height): Update.
3232 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3233 Update.
3234 (tui_set_locator_fullname, tui_set_locator_info)
3235 (tui_show_frame_info): Update.
3236 * tui/tui-source.c (tui_set_source_content)
3237 (tui_source_is_displayed): Update.
3238 * tui/tui-layout.c (show_source_disasm_command, show_data)
3239 (show_source_or_disasm_and_command): Update.
3240 * tui/tui-disasm.c (tui_set_disassem_content)
3241 (tui_get_begin_asm_address): Update.
3242 * tui/tui-data.h (struct tui_locator_element): Remove.
3243 (union tui_which_element) <locator>: Remove.
3244 (struct tui_locator_window): New.
3245 (tui_locator_win_info_ptr): Change return type.
3246 * tui/tui-data.c (_locator): Change type.
3247 (tui_locator_win_info_ptr): Change return type.
3248 (init_content_element): Remove LOCATOR_WIN case. Add assert.
3249 (tui_alloc_content): Add assert.
3250
489e9d8b
TT
32512019-06-25 Tom Tromey <tom@tromey.com>
3252
3253 * tui/tui-winsource.c
3254 (tui_exec_info_window::maybe_allocate_content): New method.
3255 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3256 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3257 (make_source_or_disasm_window): Add cast.
3258 * tui/tui-data.h (union tui_which_element) <simple_string>:
3259 Remove.
3260 (struct tui_source_info): New.
3261 (struct tui_source_window_base) <execution_info>: Change type.
3262 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3263 case, and add assert.
3264 (tui_alloc_content): Add assert.
3265
c3fabb7d
TT
32662019-06-25 Tom Tromey <tom@tromey.com>
3267
3268 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3269 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3270 * tui/tui-data.c (tui_alloc_win_info): Remove.
3271
bbc228ee
TT
32722019-06-25 Tom Tromey <tom@tromey.com>
3273
3274 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3275 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3276 can_highlight.
3277
5fcee43a
TT
32782019-06-25 Tom Tromey <tom@tromey.com>
3279
3280 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3281 make_visible_with_new_height method.
3282 (tui_win_info::make_visible_with_new_height): New method.
3283 (tui_source_window_base::do_make_visible_with_new_height)
3284 (tui_data_window::do_make_visible_with_new_height)
3285 (tui_cmd_window::do_make_visible_with_new_height): New methods.
3286 (make_visible_with_new_height): Remove.
3287 (tui_resize_all, tui_adjust_win_heights): Use
3288 make_visible_with_new_height method.
3289 * tui/tui-data.h (struct tui_win_info)
3290 <do_make_visible_with_new_height, make_visible_with_new_height>:
3291 New methods.
3292 (struct tui_source_window_base, struct tui_data_window)
3293 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3294 methods.
3295
d83f1fe6
TT
32962019-06-25 Tom Tromey <tom@tromey.com>
3297
3298 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3299 method.
3300 (update_tab_width): Call update_tab_width method.
3301 * tui/tui-data.h (struct tui_win_info)
3302 (struct tui_source_window_base) <update_tab_width>: New methods.
3303
17374de4
TT
33042019-06-25 Tom Tromey <tom@tromey.com>
3305
3306 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3307 parameter.
3308 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3309 parameter.
3310 (tui_gen_win_info::make_visible): Update.
3311 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3312 parameter.
3313 * tui/tui-data.h (enum tui_box): New enum.
3314 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3315
f936bca2
TT
33162019-06-25 Tom Tromey <tom@tromey.com>
3317
3318 * tui/tui-layout.c (make_source_or_disasm_window): Always use
3319 init_and_make_win for EXEC_INFO_WIN.
3320 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3321 longer inline.
3322 (struct tui_win_info) <~tui_win_info>: Inline.
3323 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3324 Don't declare.
3325 * tui/tui-data.c (source_win, disasm_win): Remove globals.
3326 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3327 Remove.
3328 (tui_initialize_static_data): Update.
3329 (~tui_gen_win_info): Handle more cleanup here.
3330 (~tui_source_window_base): Delete "execution_info".
3331 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3332
d6ba6a11
TT
33332019-06-25 Tom Tromey <tom@tromey.com>
3334
3335 * tui/tui-layout.c (make_command_window): Don't set
3336 can_highlight.
3337 (show_source_disasm_command): Call the reset method.
3338 (show_data): Don't set can_highlight. Call the reset method.
3339 (tui_gen_win_info::reset): Rename from init_gen_win_info
3340 (init_and_make_win): Simplify. Return tui_gen_win_info.
3341 (show_source_or_disasm_and_command): Call the reset method.
3342 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3343 (struct tui_cmd_window): Set can_highlight.
3344
48a3bd16
TT
33452019-06-25 Tom Tromey <tom@tromey.com>
3346
3347 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3348 from make_visible.
3349 (tui_make_visible, tui_make_invisible): Rewrite.
3350 (tui_win_info::make_visible): Remove.
3351 (tui_source_window_base::make_visible): Update.
3352 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3353 method. Moved from...
3354 (struct tui_win_info) <make_visible>: ...here.
3355
c3bd716f
TT
33562019-06-25 Tom Tromey <tom@tromey.com>
3357
3358 * tui/tui-winsource.c
3359 (tui_source_window_base::do_scroll_horizontal): Remove direction
3360 parameter.
3361 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3362 direction parameter.
3363 * tui/tui-win.c (tui_win_info::forward_scroll)
3364 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3365 (tui_win_info::right_scroll): Update.
3366 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3367 direction parameter.
3368 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3369 direction parameter.
3370 * tui/tui-data.h (enum tui_scroll_direction): Remove.
3371 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3372 Remove direction parameter.
3373 (struct tui_source_window_base, struct tui_source_window)
3374 (struct tui_disasm_window, struct tui_data_window)
3375 (struct tui_cmd_window): Update.
3376
21c32dca
TT
33772019-06-25 Tom Tromey <tom@tromey.com>
3378
3379 * tui/tui-winsource.h (tui_set_exec_info_content)
3380 (tui_show_exec_info_content, tui_erase_exec_info_content)
3381 (tui_clear_exec_info_content, tui_update_exec_info): Change
3382 argument to tui_source_window_base.
3383 * tui/tui-winsource.c (tui_set_exec_info_content)
3384 (tui_show_exec_info_content, tui_erase_exec_info_content)
3385 (tui_clear_exec_info_content, tui_update_exec_info): Change
3386 argument to tui_source_window_base.
3387
73fbdc65
TT
33882019-06-25 Tom Tromey <tom@tromey.com>
3389
3390 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3391 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3392
33325343
TT
33932019-06-25 Tom Tromey <tom@tromey.com>
3394
3395 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3396 check.
3397
29d2c474
TT
33982019-06-25 Tom Tromey <tom@tromey.com>
3399
3400 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3401 type to void.
3402 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3403 type to void.
3404 * tui/tui-source.c (tui_set_source_content): Update.
3405 * tui/tui-disasm.c (tui_set_disassem_content): Update.
3406
152f3f4b
TT
34072019-06-25 Tom Tromey <tom@tromey.com>
3408
3409 * tui/tui-win.c (window_name_completer, tui_set_focus)
3410 (tui_all_windows_info): Use name method.
3411 * tui/tui-data.h (struct tui_gen_win_info)
3412 (struct tui_source_window, struct tui_disasm_window)
3413 (struct tui_data_window, struct tui_cmd_window) <name>: New
3414 method.
3415 (tui_win_name): Don't declare.
3416 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3417 (tui_win_name): Remove.
3418
be4da588
TT
34192019-06-25 Tom Tromey <tom@tromey.com>
3420
3421 * tui/tui-winsource.h (tui_update_source_window)
3422 (tui_update_source_window_as_is): Change parameter type.
3423 * tui/tui-winsource.c (tui_update_source_window): Change win_info
3424 to be a tui_source_window_base.
3425 (tui_update_source_window_as_is): Likewise.
3426 * tui/tui-win.c (make_visible_with_new_height): Update.
3427
5b81daba
TT
34282019-06-25 Tom Tromey <tom@tromey.com>
3429
3430 * tui/tui-winsource.c (tui_erase_source_content)
3431 (tui_show_source_content, tui_show_exec_info_content)
3432 (tui_erase_exec_info_content): Use refresh_window method.
3433 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3434 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3435 from tui_refresh_win.
3436 (tui_data_window::refresh_window): New method.
3437 (tui_win_info::refresh, tui_source_window_base::refresh)
3438 (tui_refresh_all): Use refresh_window method.
3439 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3440 method.
3441 * tui/tui-regs.c (tui_display_register): Call refresh_window
3442 method.
3443 * tui/tui-layout.c (show_source_disasm_command)
3444 (show_source_or_disasm_and_command): Call refresh_window method.
3445 * tui/tui-data.h (struct tui_gen_win_info)
3446 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3447 New method.
3448
cb2ce893
TT
34492019-06-25 Tom Tromey <tom@tromey.com>
3450
3451 * tui/tui.c (tui_rl_other_window, tui_enable)
3452 (tui_is_window_visible, tui_get_command_dimension): Update.
3453 * tui/tui-winsource.c (tui_update_source_window_as_is)
3454 (tui_clear_source_content, tui_erase_source_content)
3455 (tui_show_source_line, tui_source_window_base::refill)
3456 (tui_source_window_base::do_scroll_horizontal)
3457 (tui_source_window_base::set_is_exec_point_at)
3458 (tui_update_breakpoint_info, tui_set_exec_info_content)
3459 (tui_alloc_source_buffer, tui_line_is_displayed)
3460 (tui_addr_is_displayed): Update.
3461 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3462 (tui_check_and_display_highlight_if_needed)
3463 (tui_win_info::make_visible, tui_win_info::refresh)
3464 (tui_refresh_all): Update.
3465 * tui/tui-windata.c (tui_first_data_item_displayed)
3466 (tui_delete_data_content_windows, tui_erase_data_content)
3467 (tui_display_all_data, tui_data_window::refresh_all)
3468 (tui_check_data_values): Update.
3469 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3470 (tui_set_win_focus_to, tui_win_info::forward_scroll)
3471 (tui_win_info::backward_scroll, tui_refresh_all_win)
3472 (tui_resize_all, tui_set_focus, tui_all_windows_info)
3473 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3474 (tui_source_window_base::set_new_height)
3475 (tui_data_window::set_new_height)
3476 (make_invisible_and_set_new_height)
3477 (make_visible_with_new_height, new_height_ok)
3478 (parse_scrolling_args): Update.
3479 * tui/tui-stack.c (tui_show_frame_info): Update.
3480 * tui/tui-source.c (tui_set_source_content)
3481 (tui_set_source_content_nil, tui_source_is_displayed)
3482 (tui_source_window::do_scroll_vertical): Update.
3483 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3484 (tui_display_registers_from, tui_display_reg_element_at_line)
3485 (tui_check_register_values, tui_reg_command): Update.
3486 * tui/tui-layout.c (tui_default_win_height)
3487 (show_source_disasm_command, show_data, init_and_make_win)
3488 (show_source_or_disasm_and_command): Update.
3489 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3490 (tui_redisplay_readline, tui_mld_flush)
3491 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3492 (tui_getc): Update.
3493 * tui/tui-disasm.c (tui_set_disassem_content)
3494 (tui_disasm_window::do_scroll_vertical): Update.
3495 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3496 Now virtual.
3497 (struct tui_win_info): Derive from tui_gen_win_info.
3498 <~tui_win_info>: Mark as override.
3499 <generic>: Remove member.
3500 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3501 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3502 (~tui_data_window, ~tui_win_info)
3503 (tui_free_all_source_wins_content): Update.
3504 * tui/tui-command.c (tui_refresh_cmd_win): Update.
3505
ab313b35
TT
35062019-06-25 Tom Tromey <tom@tromey.com>
3507
3508 * tui/tui-layout.c (init_and_make_win): Use new.
3509 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3510 destructor, initializers.
3511 (tui_alloc_generic_win_info): Don't declare.
3512 * tui/tui-data.c (_locator): Add argument to constructor.
3513 (source_win, disasm_win): New globals.
3514 (exec_info): Remove.
3515 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3516 Update.
3517 (tui_alloc_generic_win_info): Remove.
3518 (init_content_element): Use new.
3519 (tui_win_info::tui_win_info): Update.
3520 (free_content_elements) <case DATA_WIN>: Use delete.
3521
dc2c33e4
TT
35222019-06-25 Tom Tromey <tom@tromey.com>
3523
3524 * tui/tui-wingeneral.c (tui_refresh_win): Update.
3525 * tui/tui-windata.c (tui_first_data_item_displayed)
3526 (tui_delete_data_content_windows): Update.
3527 * tui/tui-win.c (tui_data_window::set_new_height): Update.
3528 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3529 (tui_display_registers_from, tui_check_register_values): Update.
3530 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3531 pointer.
3532 * tui/tui-data.c (init_content_element): Update. Allocate the new
3533 window.
3534 (tui_free_data_content): Update.
3535 (free_content_elements) <case DATA_WIN>: Free the window.
3536
214a5cbe
TT
35372019-06-25 Tom Tromey <tom@tromey.com>
3538
3539 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3540 Update.
3541 * tui/tui-layout.c (make_command_window)
3542 (show_source_disasm_command, show_data, init_and_make_win)
3543 (show_source_or_disasm_and_command): Update.
3544 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3545 method.
3546 <can_highight, is_highlighted>: Now bool.
3547 (tui_set_win_highlight): Don't declare.
3548 * tui/tui-data.c (tui_set_win_highlight): Remove.
3549
8e2daf15
TT
35502019-06-25 Tom Tromey <tom@tromey.com>
3551
3552 * tui/tui-wingeneral.c (make_visible): Remove check of window
3553 type.
3554
8903bd8a
TT
35552019-06-25 Tom Tromey <tom@tromey.com>
3556
3557 * tui/tui-win.c (tui_win_info::max_height)
3558 (tui_cmd_window::max_height): New methods.
3559 (new_height_ok): Call max_height.
3560 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3561 <max_height>: New method.
3562
3f02ce1e
TT
35632019-06-25 Tom Tromey <tom@tromey.com>
3564
3565 * tui/tui-win.c (tui_source_window_base::set_new_height)
3566 (tui_data_window::set_new_height): New methods.
3567 (make_invisible_and_set_new_height): Call set_new_height method.
3568 * tui/tui-data.h (struct tui_win_info)
3569 (struct tui_source_window_base, struct tui_data_window)
3570 <set_new_height>: New method.
3571
1825f487
TT
35722019-06-25 Tom Tromey <tom@tromey.com>
3573
3574 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3575 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3576 tui_refresh_data_win.
3577 * tui/tui-win.c (tui_source_window_base::refresh_all): New
3578 method.
3579 (tui_refresh_all_win): Call the refresh_all method.
3580 (tui_set_focus): Likewise.
3581 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3582 (struct tui_source_window_base, struct tui_data_window) <refresh>:
3583 Likewise.
3584
ad54d15b
TT
35852019-06-25 Tom Tromey <tom@tromey.com>
3586
3587 * tui/tui-winsource.h (tui_refill_source_window)
3588 (tui_set_is_exec_point_at): Don't declare.
3589 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3590 (tui_source_window_base::refill): Rename from
3591 tui_refill_source_window.
3592 (tui_source_window_base::do_scroll_horizontal): Update.
3593 (tui_source_window_base::set_is_exec_point_at): Rename from
3594 tui_set_is_exec_point_at.
3595 (tui_update_all_breakpoint_info): Update.
3596 * tui/tui-stack.c (tui_show_frame_info): Update.
3597 * tui/tui-layout.c (show_data): Add cast.
3598 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3599 * tui/tui-data.h (struct tui_source_window_base) <refill,
3600 set_is_exec_point_at>: New methods.
3601 (tui_source_windows, tui_add_to_source_windows): Update types.
3602 (tui_add_to_source_windows): Remove redundant declaration.
3603 * tui/tui-data.c (source_windows): Store tui_source_window_base.
3604 (tui_source_windows): Change return type.
3605 (tui_clear_source_windows_detail): Update.
3606 (tui_add_to_source_windows): Change type of parameter.
3607 (tui_free_all_source_wins_content): Update.
3608
2042b506
TT
36092019-06-25 Tom Tromey <tom@tromey.com>
3610
3611 * tui/tui-wingeneral.c (tui_win_info::refresh)
3612 (tui_source_window_base::refresh): New methods.
3613 (tui_refresh_all): Call the refresh method.
3614 * tui/tui-data.h (struct tui_win_info)
3615 (struct tui_source_window_base) <refresh>: New method.
3616
56122977
TT
36172019-06-25 Tom Tromey <tom@tromey.com>
3618
3619 * tui/tui.h (tui_is_window_visible): Return bool.
3620 * tui/tui.c (tui_is_window_visible): Return bool.
3621 * tui/tui-wingeneral.c (tui_make_window, make_visible)
3622 (tui_make_visible, tui_make_invisible)
3623 (tui_win_info::make_visible)
3624 (tui_source_window_base::make_visible, make_all_visible)
3625 (tui_make_all_visible, tui_make_all_invisible): Update.
3626 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3627 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3628 bool.
3629 (struct tui_win_info, struct tui_source_window_base)
3630 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3631 * tui/tui-data.c (tui_init_generic_part): Update.
3632
cda37efb
TT
36332019-06-25 Tom Tromey <tom@tromey.com>
3634
3635 * tui/tui-wingeneral.c (tui_win_info::make_visible)
3636 (tui_source_window_base::make_visible): New methods.
3637 (make_all_visible): Make method call.
3638 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3639 (struct tui_source_window_base, struct tui_cmd_window): Override
3640 make_visible.
3641 (tui_win_is_source_type): Don't declare.
3642 * tui/tui-data.c (tui_win_is_source_type): Remove.
3643
6a0ee02c
TT
36442019-06-25 Tom Tromey <tom@tromey.com>
3645
3646 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3647 NULL check.
3648
63901aec
TT
36492019-06-25 Tom Tromey <tom@tromey.com>
3650
3651 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3652 Inline constructor. Add initializers for members.
3653 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3654 constructors; now inline in class.
3655
ceb13a13
TT
36562019-06-25 Tom Tromey <tom@tromey.com>
3657
3658 * tui/tui-regs.c (tui_show_registers): Update.
3659 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3660 bool.
3661 * tui/tui-data.c (tui_data_window::clear_detail)
3662 (tui_data_window): Update.
3663
238eb706
TT
36642019-06-25 Tom Tromey <tom@tromey.com>
3665
3666 * tui/tui-windata.c (tui_display_all_data)
3667 (tui_display_data_from_line, tui_display_data_from)
3668 (tui_check_data_values, tui_data_window::do_scroll_vertical):
3669 Update.
3670 * tui/tui-regs.c (tui_last_regs_line_no)
3671 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3672 (tui_show_registers, tui_show_register_group)
3673 (tui_display_registers_from, tui_display_reg_element_at_line)
3674 (tui_display_registers_from_line, tui_check_register_values)
3675 (tui_reg_next, tui_reg_prev): Update.
3676 * tui/tui-layout.c (tui_set_layout, show_data): Update.
3677 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
3678 tui_data_window.
3679 (struct tui_win_info) <detail>: Remove. Add new fields from
3680 tui_data_info.
3681 (TUI_DATA_WIN): Add cast.
3682 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3683 (~tui_data_window): Simplify.
3684
81491aa0
TT
36852019-06-25 Tom Tromey <tom@tromey.com>
3686
3687 * tui/tui-layout.c (show_source_disasm_command)
3688 (show_source_or_disasm_and_command): Update.
3689 * tui/tui-io.c (update_cmdwin_start_line)
3690 (tui_redisplay_readline): Update.
3691 * tui/tui-data.h (struct tui_command_info): Remove.
3692 (struct tui_win_info) <detail>: Remove command_info member.
3693 (struct tui_data_window) <start_line>: New member, from
3694 tui_command_info.
3695 (TUI_CMD_WIN): Add casts.
3696
e6e41501
TT
36972019-06-25 Tom Tromey <tom@tromey.com>
3698
3699 * tui/tui-winsource.c (tui_update_source_window)
3700 (tui_refill_source_window)
3701 (tui_source_window_base::do_scroll_horizontal)
3702 (tui_update_breakpoint_info, tui_set_exec_info_content)
3703 (tui_show_exec_info_content, tui_erase_exec_info_content)
3704 (tui_clear_exec_info_content): Update.
3705 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3706 Update.
3707 * tui/tui-win.c (make_invisible_and_set_new_height)
3708 (make_visible_with_new_height): Update.
3709 * tui/tui-source.c (tui_set_source_content)
3710 (tui_show_symtab_source): Update.
3711 * tui/tui-layout.c (extract_display_start_addr)
3712 (show_source_disasm_command, show_data)
3713 (make_source_or_disasm_window)
3714 (show_source_or_disasm_and_command): Update.
3715 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3716 (tui_disasm_window::do_scroll_vertical): Remove shadowing
3717 "gdbarch".
3718 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
3719 to tui_source_window_base.
3720 (struct tui_win_info) <detail>: Remove source_info member.
3721 (struct tui_source_window_base) <has_locator>: Inline.
3722 Move contents from tui_source_info; rename has_locator member to
3723 m_has_locator.
3724 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3725 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3726 header file.
3727 (tui_source_window_base::clear_detail, ~tui_source_window_base):
3728 Simplify.
3729 (tui_free_all_source_wins_content): Cast to
3730 tui_source_window_base.
3731
44f0e208
TT
37322019-06-25 Tom Tromey <tom@tromey.com>
3733
3734 * tui/tui-win.c (make_invisible_and_set_new_height)
3735 (make_visible_with_new_height): Call has_locator method.
3736 * tui/tui-layout.c (show_source_disasm_command, show_data)
3737 (show_source_or_disasm_and_command): Update for bool change.
3738 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3739 (tui_win_info) <has_locator>: New method.
3740 (struct tui_source_window_base) <has_locator>: New method.
3741 (tui_win_has_locator): Don't declare.
3742 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3743 from tui_win_has_locator.
3744 (tui_source_window_base): Use false, not FALSE.
3745
7778b912
TT
37462019-06-25 Tom Tromey <tom@tromey.com>
3747
3748 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3749 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3750 clear_detail method directly.
3751 (tui_clear_win_detail): Remove.
3752
f83d391c
TT
37532019-06-25 Tom Tromey <tom@tromey.com>
3754
3755 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3756 "this", not TUI_DISASM_WIN.
3757
13446e05
TT
37582019-06-25 Tom Tromey <tom@tromey.com>
3759
3760 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
3761 declare.
3762 * tui/tui-winsource.c
3763 (tui_source_window_base::do_scroll_horizontal): Rename from
3764 tui_horizontal_source_scroll.
3765 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3766 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3767 from tui_vertical_data_scroll.
3768 * tui/tui-win.h (tui_scroll): Don't declare.
3769 * tui/tui-win.c (tui_win_info::forward_scroll)
3770 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3771 (tui_win_info::right_scroll): Rename and update.
3772 (tui_scroll_forward_command, tui_scroll_backward_command)
3773 (tui_scroll_left_command, tui_scroll_right_command): Update.
3774 (tui_scroll): Remove.
3775 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3776 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3777 from tui_vertical_source_scroll.
3778 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3779 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3780 from tui_vertical_disassem_scroll.
3781 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3782 do_scroll_horizontal>: New methods.
3783 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3784 Likewise.
3785 (struct tui_source_window_base): Add do_scroll_horizontal.
3786 (struct tui_source_window, struct tui_disasm_window): Add
3787 do_scroll_vertical.
3788 (struct tui_data_window, struct tui_cmd_window): Add
3789 do_scroll_horizontal and do_scroll_vertical.
3790 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3791
5cf82909
TT
37922019-06-25 Tom Tromey <tom@tromey.com>
3793
3794 * tui/tui-data.h (struct tui_source_window_base): New struct.
3795 (struct tui_source_window): Derive from tui_source_window_base.
3796 (struct tui_disasm_window): New struct.
3797 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3798 from tui_source_window::clear_detail.
3799 (tui_source_window_base): Rename from tui_source_window.
3800 (~tui_source_window_base): Rename from ~tui_source_window.
3801 (tui_alloc_win_info): Create a tui_disasm_window.
3802
ee1d42d6
TT
38032019-06-25 Tom Tromey <tom@tromey.com>
3804
3805 * tui/tui-data.h (struct tui_source_window)
3806 (struct tui_data_window): Declare destructors.
3807 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3808 destructors.
3809 (tui_win_info): Simplify.
3810
b4eb2452
TT
38112019-06-25 Tom Tromey <tom@tromey.com>
3812
3813 * tui/tui-winsource.c (tui_display_main)
3814 (tui_update_source_windows_with_addr)
3815 (tui_update_all_breakpoint_info): Update.
3816 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3817 (new_height_ok, parse_scrolling_args): Update.
3818 * tui/tui-stack.c (tui_show_frame_info): Update.
3819 * tui/tui-data.h (struct tui_list): Remove.
3820 (tui_source_windows): Return a reference to a std::vector.
3821 * tui/tui-data.c (source_windows): Now a std::vector.
3822 (tui_source_windows): Change return type.
3823 (tui_clear_source_windows): Rewrite.
3824 (tui_clear_source_windows_detail, tui_add_to_source_windows)
3825 (tui_free_all_source_wins_content): Rewrite.
3826
8761a91b
TT
38272019-06-25 Tom Tromey <tom@tromey.com>
3828
3829 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3830 (struct tui_data_window, struct tui_cmd_window): Declare
3831 clear_detail method.
3832 * tui/tui-data.c (tui_source_window::clear_detail)
3833 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3834 methods.
3835 (tui_clear_win_detail): Simplify.
3836
0ed69eda
TT
38372019-06-25 Tom Tromey <tom@tromey.com>
3838
3839 * tui/tui-layout.c (make_source_window, make_disasm_window)
3840 (make_source_or_disasm_window): Remove win_info_ptr parameter.
3841 Return the new window.
3842 (show_source_disasm_command, show_data)
3843 (show_source_or_disasm_and_command): Update.
3844
82432e10
TT
38452019-06-25 Tom Tromey <tom@tromey.com>
3846
3847 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3848 parameter. Return the new window.
3849 (show_source_disasm_command): Update and remove NULL check.
3850 (show_source_or_disasm_and_command): Update.
3851
ec328aa5
TT
38522019-06-25 Tom Tromey <tom@tromey.com>
3853
3854 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3855
33b906ab
TT
38562019-06-25 Tom Tromey <tom@tromey.com>
3857
3858 * tui/tui-data.h (struct tui_win_info): Make constructor
3859 protected. Make destructor virtual. Add initializers.
3860 (tui_source_window, tui_data_window, tui_cmd_window): New
3861 classes.
3862 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
3863 constructor. Add "type" parameter.
3864 (tui_source_window, tui_data_window, tui_cmd_window): New
3865 constructors.
3866 (tui_alloc_win_info): Instantiate the appropriate subclass.
3867
e7e11af4
TT
38682019-06-25 Tom Tromey <tom@tromey.com>
3869
3870 * tui/tui-win.c (tui_resize_all): Use delete.
3871 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3872 destructor.
3873 (tui_free_window): Don't declare.
3874 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3875 Update.
3876
6792b55e
TT
38772019-06-25 Tom Tromey <tom@tromey.com>
3878
3879 * tui/tui-data.h (struct tui_win_info): Add constructor.
3880 * tui/tui-data.c (tui_alloc_win_info): Use new.
3881 (tui_free_window): Use delete.
3882
f95675e1
TT
38832019-06-22 Tom Tromey <tom@tromey.com>
3884
3885 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3886 declare.
3887 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3888
5bff081c
TT
38892019-06-22 Tom Tromey <tom@tromey.com>
3890
3891 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3892 declare.
3893 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3894
47e3f474
TV
38952019-06-22 Tom de Vries <tdevries@suse.de>
3896
3897 * dwarf2read.c (create_addrmap_from_aranges)
3898 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3899 instead of '%zu'.
3900
fd5866f6
SM
39012019-06-21 Simon Marchi <simon.marchi@efficios.com>
3902
3903 * dwarf2read.h (dwarf2_section_info_def): Remove.
3904 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3905 * dwarf2read.c (struct dwo_sections) <types>: Change type to
3906 std::vector<dwarf2_section_info>.
3907 (struct dwo_file) <~dwo_file>: Remove.
3908 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3909 types field.
3910 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3911 (dwarf2_read_debug_names): Likewise.
3912 (create_debug_types_hash_table): Change parameter type to
3913 array_view, adjust code accordingly.
3914 (dwarf2_locate_dwo_sections): Adjust to std::vector.
3915 (partial_die_info::fixup): Likewise.
3916 (determine_prefix): Likewise.
3917 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3918
fb1eb2f9
SM
39192019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3920
3921 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3922 gdb_bfd_ref_ptr.
3923 <~dwo_file>: Remove call to gdb_bfd_unref.
3924 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3925 gdb_bfd_ref_ptr::get.
3926
51ac9db5
SM
39272019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3928
3929 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3930 type to htab_up.
3931 * dwarf2read.c (struct dwo_file): Initialize fields.
3932 <~dwo_file>: New.
3933 (free_dwo_file): Remove, move content to ~dwo_file.
3934 (struct dwo_file_deleter): Remove.
3935 (dwo_file_up>: Remove custom deleter.
3936 (free_dwo_files): Remove.
3937 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3938 dwo_files.
3939 (process_skeletonless_type_units): Call unique_ptr::get.
3940 (allocate_dwo_file_hash_table): Add deleter to created hash
3941 table. Change return type to htab_up.
3942 (lookup_dwo_file_slot): Don't memset dwo_file, call
3943 unique_ptr::get.
3944 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3945 (create_dwo_unit_in_dwp_v2): Likewise.
3946 (open_and_init_dwo_file): Likewise.
3947 (free_dwo_file_from_slot): Remove.
3948
dc4ccb6f
SM
39492019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3950
3951 * dwarf2read.h (struct dwarf2_section_info) <readin,
3952 is_virtual>: Change type to bool.
3953 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3954 true instead of 1.
3955
e6a1c5cb
TT
39562019-06-19 Tom Tromey <tom@tromey.com>
3957
3958 * tui/tui-data.h (tui_init_content_element): Don't declare.
3959
6f6ffbeb
TT
39602019-06-19 Tom Tromey <tom@tromey.com>
3961
3962 * tui/tui-data.h (tui_init_win_info): Don't declare.
3963
f23f598e
TV
39642019-06-19 Tom de Vries <tdevries@suse.de>
3965
3966 * dwarf2read.h (abstract_to_concrete): Change type to
3967 std::unordered_map<sect_offset, std::vector<sect_offset>,
3968 gdb::hash_enum<sect_offset>>.
3969
680e1bee
TT
39702019-06-19 Tom Tromey <tromey@adacore.com>
3971
3972 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3973 EVAL_AVOID_SIDE_EFFECTS specially.
3974
dcf37923
TT
39752019-06-19 Tom Tromey <tromey@adacore.com>
3976
3977 * source-cache.c (highlighter): New global.
3978 (source_cache::get_source_lines): Create a highlighter on demand.
3979
494986d5
AB
39802019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
3981
3982 * defs.h (deprecated_interactive_hook): Delete declaration.
3983 * interps.c (clear_interpreter_hooks): Remove use of
3984 deprecated_interactive_hook.
3985 * top.c (deprecated_interactive_hook): Delete definition.
3986 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3987
3360b6e7
TV
39882019-06-18 Tom de Vries <tdevries@suse.de>
3989
3990 PR gdb/24515
3991 * dwarf2read.h (abstract_to_concrete): Change type from
3992 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3993 std::unordered_map<sect_offset, std::vector<sect_offset>>.
3994 * dwarf2read.c (read_variable): Update.
3995 (dwarf2_fetch_die_loc_sect_off): Update.
3996
310b3441
TV
39972019-06-17 Tom de Vries <tdevries@suse.de>
3998
3999 PR gdb/24617
4000 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4001 accessing parent[parent_len - 1].
4002
ba9777be
PP
40032019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
4004
4005 PR gdb/24364
4006 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4007 call dtrace_process_dof with NULL dof.
4008
2b9f6e89
TV
40092019-06-16 Tom de Vries <tdevries@suse.de>
4010
4011 PR gdb/24445
4012 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4013
431b3ead
TT
40142019-06-16 Tom Tromey <tom@tromey.com>
4015
4016 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4017 (make_all_visible): Use address of member.
4018
d04b44a1
TT
40192019-06-16 Tom Tromey <tom@tromey.com>
4020
4021 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4022 (tui_free_window, free_content, free_content_elements): Remove
4023 unnecessary cast.
4024 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4025 cast.
4026 * tui/tui-regs.c (tui_show_register_group)
4027 (tui_display_registers_from, tui_display_reg_element_at_line):
4028 Remove unnecessary cast.
4029
bf5142e7
AB
40302019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
4031
4032 * linux-nat.c (normal_mask): Delete.
4033 (_initialize_linux_nat): Don't initialise normal_mask.
4034
c4973306
SM
40352019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
4036
4037 PR gdb/24445
4038 * dwarf-index-write.h (write_psymtabs_to_index): Add
4039 dwz_basename parameter.
4040 * dwarf-index-write.c (write_gdbindex): Move file writing to
4041 write_gdbindex_1. Change return type void.
4042 (assert_file_size): Move up, remove filename parameter.
4043 (write_gdbindex_1): New function.
4044 (write_debug_names): Change return type to void, call
4045 assert_file_size.
4046 (struct index_wip_file): New struct.
4047 (write_psymtabs_to_index): Add dwz_basename parameter. Move
4048 file logic to index_wip_file. Write index for dwz file if
4049 needed.
4050 (save_gdb_index_command): Pass basename of dwz file, if present.
4051 * dwarf-index-cache.c (index_cache::store): Obtain and pass
4052 build-id of dwz file, if present.
4053 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4054 (dwarf2_get_dwz_file): Likewise.
4055 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4056 (dwarf2_get_dwz_file): Likewise.
4057
395f9c91
TT
40582019-06-16 Tom Tromey <tom@tromey.com>
4059
4060 * coffread.c (process_coff_symbol): Use xstrdup.
4061 * value.c (create_internalvar): Use xstrdup.
4062
cafb3438
TT
40632019-06-16 Tom Tromey <tom@tromey.com>
4064
4065 * valops.c (value_cast, value_slice): Remove unnecessary cast.
4066 * breakpoint.c (stopin_command, stopat_command)
4067 (until_break_command, decode_location_default): Remove unnecessary
4068 cast.
4069 * utils.c (subset_compare): Remove unnecessary cast.
4070 * ada-lang.c (ada_update_initial_language): Remove unnecessary
4071 cast.
4072 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4073 cast.
4074 * infcmd.c (path_command): Remove unnecessary cast.
4075 * coffread.c (decode_type): Remove unnecessary cast.
4076 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4077 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4078 * tui/tui-stack.c (tui_show_locator_content)
4079 (tui_show_frame_info): Remove unnecessary cast.
4080 * tui/tui-win.c (tui_scroll_forward_command)
4081 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4082 (parse_scrolling_args): Remove unnecessary cast.
4083 * tui/tui-data.c (init_win_info, tui_del_window)
4084 (tui_free_window, tui_del_data_windows, tui_free_data_content)
4085 (free_content_elements): Remove unnecessary cast.
4086 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4087 unnecessary cast.
4088 * tui/tui-source.c (tui_set_source_content)
4089 (tui_vertical_source_scroll): Remove unnecessary cast.
4090 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4091 cast.
4092 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4093 * tui/tui-regs.c (tui_display_registers_from)
4094 (tui_display_register): Remove unnecessary cast.
4095 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4096 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4097 (make_visible): Remove unnecessary cast.
4098 * tui/tui-winsource.c (tui_erase_source_content)
4099 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4100 unnecessary cast.
4101 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4102 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4103 * stabsread.c (read_type, read_array_type, read_range_type):
4104 Remove unnecessary cast.
4105 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4106 (parse_symbol, parse_type, upgrade_type, parse_external)
4107 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4108 unnecessary cast.
4109 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4110
730ead81
TT
41112019-06-16 Tom Tromey <tom@tromey.com>
4112
4113 * tui/tui-data.c (tui_alloc_generic_win_info)
4114 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4115 checks.
4116
584a927c
AB
41172019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
4118 Andrew Burgess <andrew.burgess@embecosm.com>
4119
4120 * f-typeprint.c (f_print_type): Don't return early for not
4121 associated or not allocated types.
4122 (f_type_print_varspec_suffix): Add print_rank parameter and print
4123 ranks of array types in case they dangling.
4124 (f_type_print_base): Add print_rank parameter.
4125
30056ea0
AB
41262019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4127
4128 * NEWS: Mention new MI commands.
4129 * break-catch-throw.c (enum exception_event_kind): Move to
4130 breakpoint.h.
4131 (print_mention_exception_catchpoint): Output text as a single
4132 message.
4133 (catch_exception_command_1): Rename to...
4134 (catch_exception_event): ...this, make non-static, update header
4135 command, and change some parameter types.
4136 (catch_catch_command): Update for changes to
4137 catch_exception_command_1.
4138 (catch_throw_command): Likewise.
4139 (catch_rethrow_command): Likewise.
4140 * breakpoint.c (enum exception_event_kind): Delete.
4141 * breakpoint.h (enum exception_event_kind): Moved here from
4142 break-catch-throw.c.
4143 (catch_exception_event): Declare.
4144 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4145 (mi_cmd_catch_throw): New function.
4146 (mi_cmd_catch_rethrow): New function.
4147 (mi_cmd_catch_catch): New function.
4148 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4149 'catch-catch' entries.
4150 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4151 (mi_cmd_catch_rethrow): Declare.
4152 (mi_cmd_catch_catch): Declare.
4153
ec8e2b6d
AB
41542019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4155
4156 * annotate.c (annotate_source_line): Change return type to void,
4157 update implementation to match.
4158 * annotate.h (annotate_source_line): Change return type to void,
4159 update header comment.
4160 * stack.c (print_frame_info): Don't change what frame information
4161 is printed based on whether annotations are on or not.
4162
0d3abd8c
AB
41632019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4164
4165 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4166 (annotate_source): Make static.
4167 (annotate_source_line): Moved from source.c and renamed from
4168 identify_source_line. Update the return type.
4169 * annotate.h (annotate_source): Delete declaration.
4170 (annotate_source_line): Declaration moved from source.h, and
4171 renamed from identify_source_line. Return type updated.
4172 * source.c (identify_source_line): Moved to annotate.c and renamed
4173 to annotate_source_line.
4174 (info_line_command): Remove check of annotation_level.
4175 * source.h (identify_source_line): Move declaration to annotate.h
4176 and rename to annotate_source_line.
4177 * stack.c: Add 'annotate.h' include.
4178 (print_frame_info): Remove check of annotation_level before
4179 calling annotate_source_line.
4180
00df30ae
AB
41812019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4182
4183 * source-cache.c (source_cache::get_plain_source_lines): Use
4184 open_source_file_with_line_charpos instead of just
4185 open_source_file, remove call to find_source_lines.
4186 (source_cache::get_source_lines): Likewise.
4187 * source.c (find_source_lines): Make static.
4188 (get_filename_and_charpos): Renamed into...
4189 (open_source_file_with_line_charpos): ..this along with changes to
4190 return a scoped_fd, and some other minor clean ups.
4191 (identify_source_line): Use open_source_file_with_line_charpos.
4192 (search_command_helper): Use open_source_file_with_line_charpos
4193 instead of just open_source_file, remove call to
4194 find_source_lines.
4195 * source.h (open_source_file_with_line_charpos): Declare new
4196 function.
4197 (find_source_lines): Delete declaration.
4198
afda45a2
AB
41992019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4200
4201 * source.c (get_filename_and_charpos): Remove fullname
4202 parameter.
4203 (identify_source_line): Update call to get_filename_and_charpos.
4204
0735b091
TT
42052019-06-14 Tom Tromey <tromey@adacore.com>
4206
4207 PR gdb/24502:
4208 * ui-style.h (skip_ansi_escape): Update comment.
4209 * ui-file.h (class no_terminal_escape_file): New class.
4210 * ui-file.c (no_terminal_escape_file::write)
4211 (no_terminal_escape_file::puts): New methods.
4212 * cli/cli-logging.c (handle_redirections): Use
4213 no_terminal_escape_file.
4214
52ce35e2
TT
42152019-06-14 Tom Tromey <tromey@adacore.com>
4216
4217 * NEWS: Move convenience variable news above Python news.
4218
73cc7272
TT
42192019-06-14 Tom Tromey <tom@tromey.com>
4220
4221 * gnulib: Move directory to top-level.
4222 * configure.ac: Don't configure gnulib.
4223 * configure: Rebuild.
4224 * common/common-defs.h: Use new path to gnulib.
4225 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4226 (GNULIB_H): Remove.
4227 (INCGNU): Look in new gnulib location.
4228 (HFILES_NO_SRCDIR): Remove gnulib files.
4229 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4230 (generated_files): Remove GNULIB_H.
4231 ($(LIBGNU), all-lib): Remove targets.
4232 (distclean): Don't mention GNULIB_BUILDDIR.
4233 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4234
f5686554
TT
42352019-06-14 Tom Tromey <tromey@adacore.com>
4236
4237 * symfile.c (add_symbol_file_command): Remove obsolete comment.
4238 Warn if symbol file does not provide any symbols.
4239
a0c1ffed
TT
42402019-06-14 Tom Tromey <tromey@adacore.com>
4241
4242 * source.c (find_and_open_source): Respect basenames_may_differ.
4243
7c39e397
AB
42442019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
4245
4246 * annotate.c (annotate_breakpoints_invalid): Make use of
4247 scoped_restore_terminal_state.
4248 (annotate_frames_invalid): Likewise.
4249
f411722c
TT
42502019-06-14 Tom Tromey <tromey@adacore.com>
4251
4252 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4253 allow assignment to an internalvar.
4254
4268ec18
TT
42552019-06-14 Tom Tromey <tromey@adacore.com>
4256
4257 * ada-lex.l: Allow "_" in attribute names.
4258
abdb711e
TT
42592019-06-14 Tom Tromey <tromey@adacore.com>
4260
4261 PR gdb/24653:
4262 * regcache.c (registers_changed): Don't call alloca.
4263 * top.c (execute_command): Don't call alloca.
4264
4c048731
PA
42652019-06-13 Pedro Alves <palves@redhat.com>
4266
4267 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4268 'expression'. When parsing an expression, error out if there's
4269 junk after "unlimited".
4270 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4271 (do_set_command): Adjust calls to is_unlimited_literal.
4272
66eb1ed3
PA
42732019-06-13 Pedro Alves <palves@redhat.com>
4274
4275 * compile/compile.c (make_compile_options_def_group): Add braces
4276 around array_view initializer.
4277 * thread.c (make_thread_apply_all_options_def_group)
4278 (make_thread_apply_all_options_def_group): Likewise.
4279
3345721a
PA
42802019-06-13 Pedro Alves <palves@redhat.com>
4281
4282 * NEWS (New commands): Mention "maint test-options
4283 require-delimiter", "maint test-options unknown-is-error", "maint
4284 test-options unknown-is-operand" and "maint show
4285 test-options-completion-result".
4286 (New command options, command completion): New section.
4287 (Completion improvements): New section.
4288 Mention that you can abbreviate "unlimited".
4289
6206060d
PA
42902019-06-13 Pedro Alves <palves@redhat.com>
4291
4292 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4293 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4294 * unittests/cli-utils-selftests.c (test_parse_flags)
4295 (test_parse_flags_qcs): Delete.
4296 (test_cli_utils): Don't call deleted functions.
4297
6665660a
PA
42982019-06-13 Pedro Alves <palves@redhat.com>
4299
4300 * thread.c: Include "cli/cli-option.h".
4301 (tp_array_compar_ascending): Global.
4302 (tp_array_compar): Delete function.
4303 (tp_array_compar_ascending, tp_array_compar_descending): New
4304 functions.
4305 (ascending_option_def, qcs_flag_option_def)
4306 (thr_qcs_flags_option_defs)
4307 (make_thread_apply_all_options_def_group)
4308 (make_thread_apply_options_def_group): New.
4309 (thread_apply_all_command): Use gdb::option::process_options.
4310 (thread_apply_command_completer)
4311 (thread_apply_all_command_completer): New.
4312 (thread_apply_command): Use gdb::option::process_options.
4313 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4314 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
4315 to generate help text of "thread apply". Adjust "taas"'s help.
4316 * tid-parse.c (tid_range_parser::in_thread_range): New method.
4317 * tid-parse.h (tid_range_parser::in_thread_range): New method.
4318
f7e13587
PA
43192019-06-13 Pedro Alves <palves@redhat.com>
4320
4321 * thread.c (thread_apply_command): Check for invalid TID with
4322 isdigit instead of !isalpha.
4323
5d707134
PA
43242019-06-13 Pedro Alves <palves@redhat.com>
4325
4326 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4327 (validate_flags_qcs): New.
4328 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4329 (validate_flags_qcs): Declare.
4330 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4331 (make_frame_apply_options_def_group): New.
4332 (frame_apply_command_count): Process options with
4333 gdb::option::process_options.
4334 (frame_apply_completer): New.
4335 (frame_apply_level_completer, frame_apply_all_completer)
4336 (frame_apply_completer): New.
4337 (_initialize_stack): Update help of "frame apply", "frame apply
4338 level", "frame apply all" and "faas" to mention supported options
4339 and install command completers.
4340 * stack.h (frame_apply_all_completer): Declare.
4341 * thread.c: Include "stack.h".
4342 (tfaas_command): Add "--".
4343 (_initialize_thread): Update help "tfaas" to mention supported
4344 options and install command completer.
4345
272d4594
PA
43462019-06-13 Pedro Alves <palves@redhat.com>
4347
4348 * completer.c (complete_nested_command_line): New.
4349 (gdb_completion_word_break_characters_throw): Add assertion.
4350 * completer.h (complete_nested_command_line): Declare.
4351
90a1ef87
PA
43522019-06-13 Pedro Alves <palves@redhat.com>
4353
4354 * stack.c (parse_backtrace_qualifiers): New.
4355 (backtrace_command): Use it.
4356 (backtrace_command_completer): Complete on qualifiers.
4357
d4c16835
PA
43582019-06-13 Pedro Alves <palves@redhat.com>
4359
4360 * frame.c: Include "cli/cli-option.h.
4361 (user_set_backtrace_options): New.
4362 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4363 Delete.
4364 (get_prev_frame): Adjust.
4365 (boolean_option_def, uinteger_option_def)
4366 (set_backtrace_option_defs): New.
4367 (_initialize_frame): Adjust and use
4368 gdb::option::add_setshow_cmds_for_options to install "set
4369 backtrace past-main" and "set backtrace past-entry".
4370 * frame.h: Include "cli/cli-option.h".
4371 (struct frame_print_options): Forward declare.
4372 (print_frame_arguments_all, print_frame_arguments_scalars)
4373 (print_frame_arguments_none): Declare.
4374 (print_entry_values): Delete declaration.
4375 (struct frame_print_options, user_frame_print_options): New.
4376 (struct set_backtrace_options): New.
4377 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4378 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4379 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4380 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4381 (list_args_or_locals): Add frame_print_options parameter.
4382 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4383 * python/py-framefilter.c (enumerate_args): Pass down
4384 USER_FRAME_PRINT_OPTIONS.
4385 * stack.c: Include "cli/cli-option.h".
4386 (print_frame_arguments_all, print_frame_arguments_scalars)
4387 (print_frame_arguments_none): Declare.
4388 (print_raw_frame_arguments, print_entry_values): Delete.
4389 (user_frame_print_options): New.
4390 (boolean_option_def, enum_option_def, frame_print_option_defs):
4391 New.
4392 (struct backtrace_cmd_options): New.
4393 (bt_flag_option_def): New.
4394 (backtrace_command_option_defs): New.
4395 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4396 (print_frame_arg, read_frame_arg, print_frame_args)
4397 (print_frame_info, print_frame): Add frame_print_options parameter
4398 and use it.
4399 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4400 (backtrace_command_1): Add frame_print_options and
4401 backtrace_cmd_options parameters and use them.
4402 (make_backtrace_options_def_group): New.
4403 (backtrace_command): Process command options with
4404 gdb::option::process_options.
4405 (backtrace_command_completer): New.
4406 (_initialize_stack): Extend "backtrace"'s help to mention
4407 supported options. Install completer for "backtrace".
4408 Install some settings commands with add_setshow_cmds_for_options.
4409
2daf894e
PA
44102019-06-13 Pedro Alves <palves@redhat.com>
4411
4412 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4413 and that "set/show print raw frame-arguments" are now deprecated.
4414
4415 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4416 command.
4417 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4418 * stack.c (_initialize_stack): Install "set/show print
4419 raw-frame-arguments", and deprecate "set/show print raw
4420 frame-arguments".
4421 * valprint.c (_initialize_valprint): Deprecate "set/show print
4422 raw".
4423
e6ed716c
PA
44242019-06-13 Pedro Alves <palves@redhat.com>
4425
4426 * compile/compile.c (struct compile_options): New.
4427 (compile_flag_option_def, compile_command_option_defs)
4428 (make_compile_options_def_group): New.
4429 (compile_file_command): Handle options with
4430 gdb::option::process_options.
4431 (compile_file_command_completer): New function.
4432 (compile_code_command): Handle options with
4433 gdb::option::process_options.
4434 (compile_code_command_completer): New function.
4435 (_initialize_compiler): Install completers for "compile code" and
4436 "compile file". Mention available options in "compile code" and
4437 "compile code"'s help.
4438 * completer.c (advance_to_completion_word): New, factored out from
4439 ...
4440 (advance_to_expression_complete_word_point): ... this.
4441 (advance_to_filename_complete_word_point): New.
4442 * completer.h (advance_to_filename_complete_word_point): New
4443 declaration.
4444
7d8062de
PA
44452019-06-13 Pedro Alves <palves@redhat.com>
4446
4447 * compile/compile.c: Include "cli/cli-option.h".
4448 (compile_print_value): Scope data pointer is now a
4449 value_print_options pointer; adjust.
4450 (compile_print_command): Process options. Scope data pointer is
4451 now a value_print_options pointer; adjust.
4452 (_initialize_compile): Update "compile print"'s help to include
4453 supported options. Install a completer for "compile print".
4454 * cp-valprint.c (show_vtblprint, show_objectprint)
4455 (show_static_field_print): Delete.
4456 (_initialize_cp_valprint): Don't install "set print
4457 static-members", "set print vtbl", "set print object" here.
4458 * printcmd.c: Include "cli/cli-option.h" and
4459 "common/gdb_optional.h".
4460 (print_command_parse_format): Rework to fill in a
4461 value_print_options instead of a format_data.
4462 (print_value): Change parameter type from format_data pointer to
4463 value_print_options reference. Adjust.
4464 (print_command_1): Process options. Adjust to pass down a
4465 value_print_options.
4466 (print_command_completer): New.
4467 (_initialize_printcmd): Install print_command_completer as
4468 handle_brkchars completer for the "print" command. Update
4469 "print"'s help to include supported options.
4470 * valprint.c: Include "cli/cli-option.h".
4471 (show_vtblprint, show_objectprint, show_static_field_print): Moved
4472 here from cp-valprint.c.
4473 (boolean_option_def, uinteger_option_def)
4474 (value_print_option_defs, make_value_print_options_def_group):
4475 New. Use gdb::option::add_setshow_cmds_for_options to install
4476 "set print elements", "set print null-stop", "set print repeats",
4477 "set print pretty", "set print union", "set print array", "set
4478 print address", "set print symbol", "set print array-indexes".
4479 * valprint.h: Include <string> and "cli/cli-option.h".
4480 (make_value_print_options_def_group): Declare.
4481 (print_value): Change parameter type from format_data pointer to
4482 value_print_options reference.
4483 (print_command_completer): Declare.
4484
9d0faba9
PA
44852019-06-13 Pedro Alves <palves@redhat.com>
4486
4487 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4488 (COMMON_SFILES): Add maint-test-settings.c.
4489 * cli/cli-decode.c (boolean_enums): New global, factored out from
4490 ...
4491 (add_setshow_boolean_cmd): ... here.
4492 * cli/cli-decode.h (boolean_enums): Declare.
4493 * cli/cli-option.c: New file.
4494 * cli/cli-option.h: New file.
4495 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4496 factored out from ...
4497 (parse_cli_boolean_value(const char *)): ... this.
4498 (is_unlimited_literal): Change parameter type to pointer to
4499 pointer. Adjust and advance ARG pointer.
4500 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4501 (parse_cli_var_enum): New, factored out from ...
4502 (do_set_command): ... this. Adjust.
4503 * cli/cli-setshow.h (parse_cli_boolean_value)
4504 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4505 (parse_cli_var_enum): Declare.
4506 * cli/cli-utils.c: Include "cli/cli-option.h".
4507 (get_ulongest): New.
4508 * cli/cli-utils.h (get_ulongest): Declare.
4509 (check_for_argument): New overloads.
4510 * maint-test-options.c: New file.
4511
2c722807
PA
45122019-06-13 Pedro Alves <palves@redhat.com>
4513
4514 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4515 parse a range if "-" is at the end of the string.
4516
dee7b4c8
PA
45172019-06-13 Pedro Alves <palves@redhat.com>
4518
4519 * cli/cli-setshow.c (parse_auto_binary_operation)
4520 (parse_cli_boolean_value): Don't allow "o".
4521
dca0f6c0
PA
45222019-06-13 Pedro Alves <palves@redhat.com>
4523
4524 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4525 * NEWS: Mention maint test-settings KIND.
4526 * maint-test-settings.c: New file.
4527
597bf39d
PA
45282019-06-13 Pedro Alves <palves@redhat.com>
4529
4530 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4531 completer.
4532 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4533 "set" completers.
4534
48c410fb
PA
45352019-06-13 Pedro Alves <palves@redhat.com>
4536
4537 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4538 after item.
4539
93bcb043
PA
45402019-06-13 Pedro Alves <palves@redhat.com>
4541
4542 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4543
cbba3ecd
PA
45442019-06-13 Pedro Alves <palves@redhat.com>
4545
4546 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4547 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4548 call.
4549 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4550 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4551 calls.
4552 (check_for_argument): Skip spaces after argument.
4553
b9a3f842
PA
45542019-06-13 Pedro Alves <palves@redhat.com>
4555
4556 * thread.c (thread_apply_command): Adjust TID parsing.
4557 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4558 detected before end of string.
4559 (tid_is_in_list): Error out if LIST is invalid.
4560
3844e605
PA
45612019-06-13 Pedro Alves <palves@redhat.com>
4562
4563 * completer.c (complete_line_internal_1): Rewind completion word
4564 point.
4565 (completion_tracker::advance_custom_word_point_by): Change
4566 parameter type to int.
4567 * completer.h (completion_tracker::advance_custom_word_point_by):
4568 Likewise.
4569
00b56dbe
PA
45702019-06-13 Pedro Alves <palves@redhat.com>
4571
4572 * completer.c (advance_to_completion_word): Handle delimiters.
4573
d106773e
PA
45742019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
4575
4576 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4577
08f10e02
TT
45782019-06-11 Tom Tromey <tom@tromey.com>
4579
4580 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4581 (xmalloc_failed): Move to alloc.c.
4582 * alloc.c: New file.
4583 * Makefile.in (COMMON_SFILES): Add alloc.c.
4584
1c7fe951
TT
45852019-06-11 Tom Tromey <tom@tromey.com>
4586
4587 * nat/linux-waitpid.c: Don't include server.h.
4588 (linux_debug): Remove.
4589 (my_waitpid): Update.
4590
89549d7f
TT
45912019-06-11 Tom Tromey <tromey@adacore.com>
4592
4593 * infcall.c (_initialize_infcall): Remove trailing newline from
4594 help.
4595 * user-regs.c (_initialize_user_regs): Remove trailing newline
4596 from help.
4597 * typeprint.c (_initialize_typeprint): Remove trailing newline
4598 from help.
4599 * reverse.c (_initialize_reverse): Remove trailing newlines from
4600 help.
4601 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4602 from help.
4603 * language.c (add_set_language_command): Remove trailing newline
4604 from help.
4605 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4606 help.
4607 * disasm.c (_initialize_disasm): Remove trailing newline from
4608 help.
4609 * top.c (init_main): Remove trailing newline from help.
4610 * interps.c (_initialize_interpreter): Remove trailing newline
4611 from help.
4612 * btrace.c (_initialize_btrace): Remove trailing newlines from
4613 help.
4614 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4615 from help.
4616 * python/python.c (_initialize_python): Remove trailing newline
4617 from help.
4618 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4619 help.
4620 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4621 from help. Reformat some text.
4622 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4623 from help.
4624 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4625 newline from help.
4626
86108c13
TT
46272019-06-11 Tom Tromey <tromey@adacore.com>
4628
4629 * darwin-nat.c (darwin_decode_exception_message)
4630 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4631
a7067863
AB
46322019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
4633
4634 * valops.c (value_slice): Check for not allocated or not
4635 associated values.
4636
9ab08412
TV
46372019-06-10 Tom de Vries <tdevries@suse.de>
4638
4639 PR gdb/24618
4640 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4641 sure an empty slot (defined by a 32-bit zero pair) is recognized as
4642 invalid.
4643
f19e22e9
TV
46442019-06-10 Tom de Vries <tdevries@suse.de>
4645
4646 PR gdb/24611
4647 * linespec.c (linespec_lexer_lex_string): Remove incorrect
4648 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
4649
e99f9db0
TV
46502019-06-10 Tom de Vries <tdevries@suse.de>
4651
4652 PR symtab/24545
4653 * symtab.c (struct demangled_name_entry): Add language field.
4654 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
4655 static minimal symbol". Set and use language field.
4656
9bf7038b
TT
46572019-06-10 Tom Tromey <tromey@adacore.com>
4658
4659 * ada-lang.c (_initialize_ada_language): Update help text.
4660
422186a9
TT
46612019-06-10 Tom Tromey <tromey@adacore.com>
4662
4663 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4664 with a newline.
4665 * guile/guile.c (handle_boot_error): Don't end warning with a
4666 newline.
4667 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4668 warning with a newline.
4669 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4670 newline.
4671 (s12z_frame_cache): Likewise.
4672 * dwarf-index-cache.c (index_cache::store): Don't end warning with
4673 a newline.
4674 * solib-svr4.c (disable_probes_interface): Don't end warning with
4675 a newline.
4676 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4677 newline.
4678 * python/python.c (do_finish_initialization): Don't end warning
4679 with a newline.
4680
25ce02ee
TT
46812019-06-10 Tom Tromey <tom@tromey.com>
4682
4683 * python/py-breakpoint.c (gdbpy_breakpoint_created)
4684 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4685 gdbpy_enter.
4686
caa429d8
TT
46872019-06-10 Tom Tromey <tromey@adacore.com>
4688
4689 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4690 data.
4691 (elf_new_init): Don't call stabsread_new_init.
4692 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4693 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
4694 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4695
81873cc8
TV
46962019-06-10 Tom de Vries <tdevries@suse.de>
4697
4698 PR symtab/16264
4699 PR symtab/24517
4700 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4701
4fa0265e
РИ
47022019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
4703
4704 * source.c (find_and_open_source): Also rewrite relative file
4705 names.
4706
1a3da2cd
AB
47072019-04-26 Amos Bird <amosbird@gmail.com>
4708
4709 * annotate.c (annotate_thread_exited): Add "thread-exited"
4710 annotation.
4711
3847a7bf
TT
47122019-06-06 Tom Tromey <tromey@adacore.com>
4713
4714 * maint.h (class scoped_command_stats): Use
4715 DISABLE_COPY_AND_ASSIGN.
4716 <print_time>: New method.
4717 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4718 print_time.
4719 (scoped_command_stats::print_time): New method.
4720
312617a3
AB
47212019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
4722
4723 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4724 instructions of lengths 6 or 8 bytes.
4725
b02f78f9
PA
47262019-06-04 Pedro Alves <palves@redhat.com>
4727
4728 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4729
4730 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4731 * breakpoint.c (condition_completer): Likewise.
4732 * cli/cli-dump.c (scan_expression): Likewise.
4733 * common/filestuff.c (mkdir_recursive): Likewise.
4734 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4735 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4736 (gdb_abspath): Likewise.
4737 * compile/compile-cplus-types.c
4738 (compile_cplus_instance::decl_name): Likewise.
4739 * completer.c (complete_explicit_location):
4740 (signal_completer, reg_or_group_completer_1): Likewise.
4741 * cp-support.c (cp_remove_params_if_any): Likewise.
4742 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4743 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4744 * infcmd.c (strip_bg_char): Likewise.
4745 * linespec.c (copy_token_string): Likewise.
4746 * mi/mi-main.c (output_cores): Likewise.
4747 * psymtab.c (psymtab_search_name):
4748 * symfile.c (test_set_ext_lang_command): Likewise.
4749 * target.c (target_fileio_read_stralloc): Likewise.
4750 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4751 * value.c (complete_internalvar): Likewise.
4752
e1f2e1a2
CB
47532019-06-04 Christian Biesinger <cbiesinger@google.com>
4754
4755 Add objfile property to gdb.Type.
d3238f7d
PA
4756 * NEWS: Mention Python API addition.
4757 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 4758
e664d728
PW
47592019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4760
4761 * NEWS: Mention the new set|show style [title|highlight].
4762 Mention changes to "show style", "help" and "apropos".
4763
66d8c862
PW
47642019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4765
4766 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4767 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
4768 instead of print_help_for_command.
4769 (print_doc_of_command): New function.
4770 (help_list): Add 'apropos -v word' suggestion.
4771 (print_help_for_command): Style the command name using title style.
4772 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4773 (_initialize_cli_cmds): Describe -v in apropos_command help.
4774
9303eb2f
PW
47752019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4776
4777 * cli/cli-style.h (cli_style_option): Add name in constructor,
4778 add m_name class member, add constructor with intensity,
4779 add name class function.
4780 (cli_style_option::add_setshow_commands): Remove name argument.
4781 (highlight_style, title_style): New styles.
4782 * cli/cli-style.c (do_show): New function that shows a style
4783 characteristic styling the style name with itself.
4784 (set_style_name): New function.
4785 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4786 Update all callers according to the changes in cli/cli-style.h.
4787 * utils.h (fputs_highlighted): New function.
4788 * utils.c (fputs_highlighted): Likewise.
4789
e2c52041
PW
47902019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4791
4792 * NEWS: Mention new pipe command and new convenience variables.
4793
947d3946
PW
47942019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4795
4796 * cli/cli-cmds.c (pipe_command): New function.
4797 (_initialize_cli_cmds): Call add_com for pipe_command.
4798 Define | as an alias for pipe.
4799 (exit_status_set_internal_vars): New function.
4800 (shell_escape): Call exit_status_set_internal_vars.
4801 cli/cli-decode.c (find_command_name_length): Recognize | as
4802 a single character command.
4803
b8fd0918
PW
48042019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4805
4806 * gdbcmd.h (execute_command_to_ui_file): New declaration.
4807 top.c (execute_command_to_ui_file): New function, mostly a copy
4808 of execute_command_to_string.
4809 (execute_command_to_string): Implement by calling
4810 execute_command_to_ui_file.
4811
68bb5386
PW
48122019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4813
4814 * top.h (saved_command_line): Remove declaration.
4815 * top.c (previous_saved_command_line, previous_repeat_arguments):
4816 New variables.
4817 (saved_command_line): Make static, define together with other
4818 'repeat variables'.
4819 (dont_repeat): Clear repeat_arguments.
4820 (repeat_previous, get_saved_command_line, save_command_line):
4821 New functions.
4822 (gdb_init): Initialize saved_command_line
4823 and previous_saved_command_line.
4824 * main.c (captured_main_1): Remove saved_command_line initialization.
4825 * event-top.c (handle_line_of_input): Update to use
4826 the new 'repeat' related functions instead of direct access to
4827 saved_command_line.
4828 * command.h (repeat_previous, get_saved_command_line,
4829 save_command_line): New declarations.
4830 (dont_repeat): Add comment.
4831
bfcdb852
TT
48322019-05-30 Tom Tromey <tromey@adacore.com>
4833
4834 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4835 Fix comment.
4836 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4837
0ef209f2
JV
48382019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
4839
4840 PR cli/24587
4841 * completer.c (complete): Initialize variable word.
4842
955b06fa
SDJ
48432019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
4844
4845 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4846 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4847 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4848 'body' is NULL to the outter 'if', protecting the '!is_define'
4849 situation as well.
4850
fa9c3fa0
TT
48512019-05-29 Tom Tromey <tromey@adacore.com>
4852
4853 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4854 (dwarf_unknown): New function.
4855 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4856 (dwarf_type_encoding_name): Use dwarf_unknown.
4857
4330d61d
TT
48582019-05-29 Tom Tromey <tromey@adacore.com>
4859
4860 PR c++/20020:
4861 * cp-valprint.c (cp_print_value_fields): Call
4862 cp_print_static_field inside "try".
4863
33a6bc35
TT
48642019-05-29 Tom Tromey <tromey@adacore.com>
4865
4866 * inflow.c (struct terminal_info): Add default operator=.
4867 * configure: Rebuild.
4868 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4869 -Wdeprecated-copy-dtor, -Wredundant-move.
4870
000439d5
TT
48712019-05-29 Tom Tromey <tromey@adacore.com>
4872
4873 * NEWS: Add entry.
4874 * infcmd.c (print_return_value_1): Handle finish_print
4875 option.
4876 (show_print_finish): New function.
4877 (_initialize_infcmd): Add "set/show print finish" commands.
4878 * valprint.c (user_print_options): Initialize new member.
4879 * valprint.h (struct value_print_options) <finish_print>: New
4880 member.
4881
c0e70c62
TT
48822019-05-28 Tom Tromey <tromey@adacore.com>
4883
4884 * ada-lang.c (ada_remove_Xbn_suffix)
4885 (find_old_style_renaming_symbol)
4886 (parse_old_style_renaming): Remove.
4887 (ada_find_renaming_symbol): Don't call
4888 find_old_style_renaming_symbol.
4889 (ada_is_renaming_symbol): Rename from
4890 ada_find_renaming_symbol. Remove "block" parameter. Return
4891 bool. Now static.
4892 (ada_read_var_value): Update and simplify.
4893 * ada-exp.y (write_var_or_type): Remove old code.
4894
766f8836
AH
48952019-05-28 Alan Hayward <alan.hayward@arm.com>
4896
4897 * event-top.c: Remove include comment.
4898 * inflow.c (class scoped_ignore_sigttou): Move from here...
4899 * inflow.h (class scoped_ignore_sigttou): ...to here.
4900 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4901 * top.c: Remove include comment.
4902
eb41253a
TT
49032019-05-27 Tom Tromey <tom@tromey.com>
4904
4905 * NEWS: Fix typo.
4906
4ca51187
TT
49072019-05-22 Tom Tromey <tromey@adacore.com>
4908
4909 * target.c (target_follow_exec): Constify parameter.
4910 * target-delegates.c: Rebuild.
4911 * remote.c (remote_target::follow_exec): Constify parameter.
4912 * infrun.c (follow_exec): Constify parameter.
4913 * target.h (struct target_ops) <follow_exec>: Constify parameter.
4914 (target_follow_exec): Likewise.
4915
8fca4da0
AH
49162019-05-22 Alan Hayward <alan.hayward@arm.com>
4917
4918 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4919 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4920
b7060614
AH
49212019-05-22 Alan Hayward <alan.hayward@arm.com>
4922
4923 * NEWS: Add debugredirect and testsuite sections.
4924
0a5954bd
SC
49252019-05-22 Simon Cook <simon.cook@embecosm.com>
4926
4927 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4928 target descriptions using exclusively floating point register name
4929 aliases.
4930
dc42e902
AB
49312019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
4932
4933 PR gdb/18644:
4934 * f-lang.c (build_fortran_types): Handle the case where
4935 gdbarch_floatformat_for_type returns a nullptr.
4936
fb7806c7
TV
49372019-05-21 Tom de Vries <tdevries@suse.de>
4938
4939 PR cli/24587
4940 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4941
34d11c68
AB
49422019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4943
4944 PR gdb/18644:
4945 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4946 16-byte floats.
4947 * i386-tdep.c (i386_floatformat_for_type): Use
4948 floatformats_ia64_quad for the 16-byte floating point component
4949 within a fortran 32-byte complex number.
4950
122cf0f2
AB
49512019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4952
4953 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4954 delete default constructor.
4955 (find_partial_die): Update to return const struct.
4956 (partial_die_parent_scope): Move variable declaration into scope
4957 of its use and change its type to auto.
4958 (guess_partial_die_structure_name): Likewise.
4959 (partial_die_info::fixup): Likewise.
4960
33d0e35a
TT
49612019-05-17 Tom Tromey <tromey@adacore.com>
4962
4963 * source.c (find_and_open_source): Remove cast.
4964
a45575b0
TT
49652019-05-17 Tom Tromey <tromey@adacore.com>
4966
4967 * annotate.c (annotate_source): Make "filename" const.
4968 * annotate.h (annotate_source): Use const.
4969
81f47ac2
AH
49702019-05-17 Alan Hayward <alan.hayward@arm.com>
4971
4972 * disasm.c (set_disassembler_options): Send errors to stderr.
4973
ca1285d1
AH
49742019-05-17 Alan Hayward <alan.hayward@arm.com>
4975
4976 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4977 (cli_interp_base::set_logging): Check debug_redirect.
4978 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4979 * cli/cli-logging.c (debug_redirect): Add static variable.
4980 (pop_output_files): Add default param.
4981 (handle_redirections): Print debug setting.
4982 (show_logging_command): Likewise.
4983 (_initialize_cli_logging): Add debugredirect command.
4984 * interps.c (current_interp_set_logging): Add debug_redirect
4985 parameter.
4986 * interps.h (set_logging): Add debug_redirect parameter.
4987 (current_interp_set_logging): Likewise.
4988 * mi/mi-common.h: Likewise.
4989 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4990
49912019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
4992 Tom Tromey <tromey@adacore.com>
4993
4994 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4995 directly.
4996 * cli/cli-interp.h (make_logging_output): Remove declaration.
4997 * cli/cli-logging.c (make_logging_output): Remove function.
4998 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4999 directly.
5000 * ui-file.c (tee_file::tee_file): Remove bools.
5001 (tee_file::~tee_file): Remove deletes.
5002 * ui-file.h (tee_file): Remove bools.
5003
26648588
JV
50042019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
5005
5006 * mi/mi-cmds.h (mi_cmd_complete): New function.
5007 * mi/mi-main.c (mi_cmd_complete): Likewise.
5008 * mi/mi-cmds.c: Define new MI command -complete.
5009 * NEWS: Mention new -complete command.
5010
6e035501
JV
50112019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
5012
5013 * completer.h (complete): New function.
5014 * completer.c (complete): Likewise.
5015 * cli/cli-cmds.c: (complete_command): Update to use new complete()
5016 function defined in completer.h.
5017
7d0e2ece
JV
50182019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
5019
e79be6e5 5020 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 5021
fb816e8b
TV
50222019-05-17 Tom de Vries <tdevries@suse.de>
5023
5024 PR gdb/24094
5025 * dwarf2read.c (struct cu_partial_die_info): New struct.
5026 (find_partial_die): Return cu_partial_die_info.
5027 (partial_die_parent_scope, guess_partial_die_structure_name)
5028 (partial_die_info::fixup): Handle new return type of find_partial_die.
5029
677052f2
SDJ
50302019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5031
5032 * stap-probe.c (stap_parse_register_operand): Make "regname" an
5033 "std::string", simplifying the algorithm.
5034
f3da9116
SDJ
50352019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5036
5037 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5038 (stap_static_probe_ops::get_probes): Likewise.
5039
f1bb75ab
SDJ
50402019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5041
5042 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5043 '-')" and "else if".
5044 (stap_parse_single_operand): Join checks for
5045 "gdbarch_stap_parse_special_token_p" and
5046 "gdbarch_stap_parse_special_token" in the same "if" statement.
5047 Invert check when verifying for operation on register
5048 displacement.
5049
3ca58cde
SDJ
50502019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5051
5052 * stap-probe.c (stap_get_opcode): Update comment.
5053 (stap_get_expected_argument_type): Likewise.
5054 (handle_stap_probe): Likewise.
5055
af2d9bee
SDJ
50562019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5057
5058 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5059 return type to 'bool'. Adjust comment. Use 'bool' when
5060 appropriate.
5061 (i386_stap_parse_special_token_three_arg_disp): Likewise.
5062 * stap-probe.c (stap_parse_argument_1): Likewise.
5063 (stap_is_operator): Likewise.
5064 (stap_is_generic_prefix): Likewise.
5065 (stap_is_register_prefix): Likewise.
5066 (stap_is_register_indirection_prefix): Likewise.
5067 (stap_is_integer_prefix): Likewise.
5068 (stap_generic_check_suffix): Likewise.
5069 (stap_check_integer_suffix): Likewise.
5070 (stap_check_register_suffix): Likewise.
5071 (stap_check_register_indirection_suffix): Likewise.
5072 (stap_parse_register_operand): Likewise.
5073 (stap_parse_single_operand): Likewise.
5074 (stap_parse_argument_1): Likewise.
5075 (stap_probe::get_argument_count): Likewise.
5076 (stap_is_operator): Likewise.
5077
61c9c421
TT
50782019-05-16 Tom Tromey <tromey@adacore.com>
5079
5080 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5081 keyword to foreach.
5082
9ddc1af1
SM
50832019-05-15 Simon Marchi <simon.marchi@efficios.com>
5084
5085 * linux-thread-db.c (try_thread_db_load_1): Change return type
5086 to bool.
5087 (try_thread_db_load): Likewise.
5088 (try_thread_db_load_from_pdir_1): Likewise.
5089 (try_thread_db_load_from_pdir): Likewise.
5090 (try_thread_db_load_from_sdir): Likewise.
5091 (try_thread_db_load_from_dir): Likewise.
5092 (thread_db_load_search): Likewise.
5093 (has_libpthread): Likewise.
5094 (thread_db_load): Likewise.
5095
7bede828
SDJ
50962019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
5097
5098 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5099 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5100 NULL, and complain/return if that's the case.
5101
c5358db4
JD
51022019-05-15 John Darrington <john@darrington.wattle.id.au>
5103
5104 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5105 (advance, posn, abstract_read_memory): New functions.
5106 [struct mem_read_abstraction]: New struct.
5107 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5108
c408a94f
TT
51092019-05-14 Tom Tromey <tromey@adacore.com>
5110
5111 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5112 value is not lval_memory.
5113
e7bd7fba
TT
51142019-05-14 Tom Tromey <tromey@adacore.com>
5115
5116 * solib.c (info_sharedlibrary_command): Style the file name.
5117
a6d0f249
AH
51182019-05-14 Alan Hayward <alan.hayward@arm.com>
5119
5120 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5121 (aarch64_vnv_type): Likewise.
5122 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5123 * common/tdesc.c: Likewise.
5124 * common/tdesc.h (enum tdesc_type_kind): Likewise.
5125 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5126 * features/aarch64-fpu.xml: Add ieee half view.
5127 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5128 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5129 * gdbtypes.h (struct builtin_type): Likewise.
5130 (struct objfile_type): Likewise.
5131
66b8bb74
SM
51322019-05-12 Paul Naert <paul.naert@polymtl.ca>
5133
5134 * language.c (language_sniff_from_mangled_name): Fix "langauge"
5135 typo.
5136 * location.h (string_to_event_location): Likewise.
5137
21c219fd
JB
51382019-05-11 Joel Brobecker <brobecker@adacore.com>
5139
5140 GDB 8.3 released.
5141
13674803
SM
51422019-05-10 Simon Marchi <simon.marchi@efficios.com>
5143
5144 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5145 New variable declaration.
5146 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5147 New variable.
5148 (print_one_breakpoint): Use ui_out::test_flags and new global
5149 variable to compute use_fixed_output.
5150 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5151 Remove.
5152 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5153 (mi_multi_location_breakpoint_output_fixed): Remove.
5154 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5155 new variable.
5156 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5157 fix_multi_location_breakpoint_output flag if version >= 3.
5158 * ui-out.h (enum ui_out_flag)
5159 <fix_multi_location_breakpoint_output>: New enumerator.
5160
a9eac7f9
SM
51612019-05-10 Simon Marchi <simon.marchi@efficios.com>
5162
5163 * contrib/cc-with-tweaks.sh: Validate dwz's work.
5164
71bed2db
TT
51652019-05-10 Tom Tromey <tromey@adacore.com>
5166
5167 * ada-lang.c (catch_ada_completer): New function.
5168 (_initialize_ada_language): Use it.
5169
24c54127
TT
51702019-05-10 Tom Tromey <tromey@adacore.com>
5171
5172 * thread.c (print_thread_info): Make "requested_threads" const.
5173 * gdbthread.h (print_thread_info): Make "requested_threads"
5174 const.
5175 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5176 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5177
7a102139
TT
51782019-05-08 Tom Tromey <tom@tromey.com>
5179
5180 * gdbtypes.c (objfile_type_data): Change type.
5181 (objfile_type, _initialize_gdbtypes): Update.
5182
924d79e2
TT
51832019-05-08 Tom Tromey <tom@tromey.com>
5184
5185 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5186 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5187 (_initialize_dwarf2_frame): Update.
5188
4c58e337
TT
51892019-05-08 Tom Tromey <tom@tromey.com>
5190
5191 * objc-lang.c (objc_objfile_data): Change type.
5192 (find_methods): Update.
5193 (_initialize_objc_lang): Remove.
5194
d772d2ab
TT
51952019-05-08 Tom Tromey <tom@tromey.com>
5196
5197 * stabsread.c (rs6000_builtin_type_data): Change type.
5198 (rs6000_builtin_type, _initialize_stabsread): Update.
5199
d11d83f4
TT
52002019-05-08 Tom Tromey <tom@tromey.com>
5201
5202 * mips-tdep.c (mips_pdr_data): Remove.
5203 (_initialize_mips_tdep): Update.
5204
9a73f0ad
TT
52052019-05-08 Tom Tromey <tom@tromey.com>
5206
5207 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5208 (hppa_init_objfile_priv_data, read_unwind_info)
5209 (find_unwind_entry, _initialize_hppa_tdep): Update.
5210
8127a2fa
TT
52112019-05-08 Tom Tromey <tom@tromey.com>
5212
5213 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5214 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
5215 on obstack.
5216 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5217
91d3055d
TT
52182019-05-08 Tom Tromey <tom@tromey.com>
5219
5220 * mdebugread.c (basic_type_data): Change type.
5221 (basic_type, _initialize_mdebugread): Update.
5222
31930bd3
TT
52232019-05-08 Tom Tromey <tom@tromey.com>
5224
5225 * common/gdb_unique_ptr.h (struct noop_deleter): New.
5226
bdb3ed9e
TT
52272019-05-08 Tom Tromey <tom@tromey.com>
5228
5229 * nto-tdep.c (nto_inferior_data_reg): Change type.
5230 (nto_inferior_data): Update.
5231 (nto_inferior_data_cleanup, nto_new_inferior_data)
5232 (_initialize_nto_tdep): Remove.
5233 * nto-tdep.h (struct nto_inferior_data): Add initializers.
5234
f37b313d
TT
52352019-05-08 Tom Tromey <tom@tromey.com>
5236
5237 * ada-lang.c (struct ada_inferior_data): Add initializers.
5238 (ada_inferior_data): Change type.
5239 (ada_inferior_data_cleanup): Remove.
5240 (get_ada_inferior_data, ada_inferior_exit)
5241 (struct ada_pspace_data): Add initializers, destructor.
5242 (ada_pspace_data_handle): Change type.
5243 (get_ada_pspace_data): Update.
5244 (ada_pspace_data_cleanup): Remove.
5245
24699405
TT
52462019-05-08 Tom Tromey <tom@tromey.com>
5247
5248 * coffread.c (struct coff_symfile_info): Add initializers.
5249 (coff_objfile_data_key): Move lower. Change type.
5250 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5251 Update.
5252 (coff_free_info): Remove.
5253
d4e05d2f
TT
52542019-05-08 Tom Tromey <tom@tromey.com>
5255
5256 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5257 (fbsd_pspace_data_handle): Move lower. Change type.
5258 (get_fbsd_pspace_data): Update.
5259 (fbsd_pspace_data_cleanup): Remove.
5260 (_initialize_fbsd_tdep): Update.
5261
14ef6690
TT
52622019-05-08 Tom Tromey <tom@tromey.com>
5263
5264 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5265 (get_ada_tasks_pspace_data): Update.
5266 (ada_tasks_pspace_data_cleanup): Remove.
5267 (_initialize_tasks): Update.
5268 (ada_tasks_inferior_data_handle): Change type.
5269 (get_ada_tasks_inferior_data): Update.
5270 (ada_tasks_inferior_data_cleanup): Remove.
5271 (struct ada_tasks_pspace_data): Add initializers.
5272
814cf43a
TT
52732019-05-08 Tom Tromey <tom@tromey.com>
5274
5275 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5276 * symfile-debug.c (debug_sym_get_probes): Change type.
5277 * stap-probe.c (handle_stap_probe):
5278 (stap_static_probe_ops::get_probes): Change type.
5279 * probe.h (class static_probe_ops) <get_probes>: Change type.
5280 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5281 (parse_probes_in_pspace): Update.
5282 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5283 Update.
5284 (any_static_probe_ops::get_probes): Change type.
5285 * elfread.c (elfread_data): New typedef.
5286 (probe_key): Change type.
5287 (elf_get_probes): Likewise. Update.
5288 (probe_key_free): Remove.
5289 (_initialize_elfread): Update.
5290 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5291 Change type.
5292 (dtrace_process_dof_probe, dtrace_process_dof)
5293 (dtrace_static_probe_ops::get_probe): Change type.
5294
02dc647e
TT
52952019-05-08 Tom Tromey <tom@tromey.com>
5296
5297 * xcoffread.c (struct xcoff_symfile_info): Rename from
5298 coff_symfile_info. Add initializers.
5299 (xcoff_objfile_data_key): Move lower. Change type.
5300 (XCOFF_DATA): Rewrite.
5301 (xcoff_free_info): Remove.
5302 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5303 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5304 (xcoff_initial_scan): Update.
5305
09232438
TT
53062019-05-08 Tom Tromey <tom@tromey.com>
5307
5308 * solib-svr4.c (struct svr4_info): Add initializers and
5309 destructor.
5310 <probes_table>: Now an htab_up.
5311 (solib_svr4_pspace_data): Change type.
5312 (free_probes_table): Simplify.
5313 (~svr4_info): Rename from svr4_pspace_data_cleanup.
5314 (get_svr4_info, probes_table_htab_remove_objfile_probes)
5315 (probes_table_remove_objfile_probes, register_solib_event_probe)
5316 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5317 (_initialize_svr4_solib): Update.
5318
7b4a314f
TT
53192019-05-08 Tom Tromey <tom@tromey.com>
5320
5321 * remote.c (remote_pspace_data): Change type.
5322 (remote_pspace_data_cleanup): Remove.
5323 (get_remote_exec_file, set_pspace_remote_exec_file)
5324 (_initialize_remote): Update.
5325
51d3063a
TT
53262019-05-08 Tom Tromey <tom@tromey.com>
5327
5328 * breakpoint.c (breakpoint_objfile_key): Change type.
5329 (get_breakpoint_objfile_data): Update.
5330 (free_breakpoint_objfile_data): Remove.
5331 (_initialize_breakpoint): Update.
5332
89fb8848
TT
53332019-05-08 Tom Tromey <tom@tromey.com>
5334
5335 * linux-tdep.c (struct linux_info): Add initializers.
5336 (linux_inferior_data): Move. Change type.
5337 (invalidate_linux_cache_inf): Update.
5338 (linux_inferior_data_cleanup): Remove.
5339 (get_linux_inferior_data, _initialize_linux_tdep): Update.
5340
e9b89e2d
TT
53412019-05-08 Tom Tromey <tom@tromey.com>
5342
5343 * auxv.c (auxv_inferior_data): Move. Change type.
5344 (auxv_inferior_data_cleanup): Remove.
5345 (invalidate_auxv_cache_inf): Rewrite.
5346 (get_auxv_inferior_data, _initialize_auxv): Update.
5347
8c42777c
TT
53482019-05-08 Tom Tromey <tom@tromey.com>
5349
5350 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5351 (symfile_debug_objfile_data_key): Change type.
5352 (symfile_debug_installed, debug_qf_has_symbols)
5353 (debug_qf_find_last_source_symtab)
5354 (debug_qf_forget_cached_source_info)
5355 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5356 (debug_qf_print_stats, debug_qf_dump)
5357 (debug_qf_expand_symtabs_for_function)
5358 (debug_qf_expand_all_symtabs)
5359 (debug_qf_expand_symtabs_with_fullname)
5360 (debug_qf_map_matching_symbols)
5361 (debug_qf_expand_symtabs_matching)
5362 (debug_qf_find_pc_sect_compunit_symtab)
5363 (debug_qf_map_symbol_filenames)
5364 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5365 (debug_sym_new_init, debug_sym_init, debug_sym_read)
5366 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5367 (debug_sym_read_linetable, debug_sym_relocate): Update.
5368 (symfile_debug_free_objfile): Remove.
5369 (install_symfile_debug_logging, _initialize_symfile_debug):
5370 Update.
5371
5bfd760d
TT
53722019-05-08 Tom Tromey <tom@tromey.com>
5373
5374 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5375 allocate_on_obstack.
5376 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5377 (get_dwarf2_per_objfile): Update.
5378 (set_dwarf2_per_objfile): Remove.
5379 (dwarf2_has_info, dwarf2_get_section_info): Update.
5380 (dwarf2_free_objfile): Remove.
5381 (_initialize_dwarf2_read): Update.
5382
e85e19b4
TT
53832019-05-08 Tom Tromey <tom@tromey.com>
5384
5385 * auto-load.c (struct auto_load_pspace_info): Add destructor and
5386 initializers.
5387 <unsupported_script_warning_printed,
5388 script_not_found_warning_printed>: Now bool.
5389 (auto_load_pspace_data): Change type.
5390 (~auto_load_pspace_info): Rename from
5391 auto_load_pspace_data_cleanup.
5392 (get_auto_load_pspace_data, init_loaded_scripts_info)
5393 (clear_section_scripts, maybe_print_unsupported_script_warning)
5394 (maybe_print_script_not_found_warning, _initialize_auto_load):
5395 Update.
5396
f6aa7436
TT
53972019-05-08 Tom Tromey <tom@tromey.com>
5398
5399 * objfiles.c (objfile_pspace_info): Add destructor and
5400 initializers.
5401 (objfiles_pspace_data): Change type.
5402 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5403 (get_objfile_pspace_data): Update.
5404 (objfiles_bfd_data): Change type.
5405 (get_objfile_bfd_data): Update.
5406 (objfile_bfd_data_free, _initialize_objfiles): Remove.
5407
6ae614f6
TT
54082019-05-08 Tom Tromey <tom@tromey.com>
5409
5410 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5411 Change type.
5412 (get_catch_syscall_inferior_data): Update.
5413 (catch_syscall_inferior_data_cleanup): Remove.
5414 (_initialize_break_catch_syscall): Update.
5415
6509b8eb
TT
54162019-05-08 Tom Tromey <tom@tromey.com>
5417
5418 * inflow.c (struct terminal_info): Add destructor and
5419 initializers.
5420 (inflow_inferior_data): Change type.
5421 (~terminal_info): Rename from inflow_inferior_data_cleanup.
5422 (get_inflow_inferior_data, inflow_inferior_exit)
5423 (swap_terminal_info, _initialize_inflow): Update.
5424
35632941
TT
54252019-05-08 Tom Tromey <tom@tromey.com>
5426
5427 * target-dcache.c (target_dcache_cleanup): Remove.
5428 (target_dcache_aspace_key): Change type.
5429 (target_dcache_init_p, target_dcache_invalidate)
5430 (target_dcache_get, target_dcache_get_or_init)
5431 (_initialize_target_dcache): Update.
5432 * dcache.h (struct dcache_deleter): New.
5433
3017b94d
TT
54342019-05-08 Tom Tromey <tom@tromey.com>
5435
5436 * symtab.c (struct symbol_cache): Add destructor and
5437 initializers.
5438 (symbol_cache_key): Move. Change type.
5439 (make_symbol_cache, free_symbol_cache): Remove.
5440 (get_symbol_cache): Update.
5441 (symbol_cache_cleanup): Remove.
5442 (ALL_PSPACES, symbol_cache_flush)
5443 (maintenance_print_symbol_cache)
5444 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5445 Update.
5446
a32ad8c5
TT
54472019-05-08 Tom Tromey <tom@tromey.com>
5448
5449 * symtab.c (struct main_info): Add destructor and initializers.
5450 (main_progspace_key): Move. Change type.
5451 (get_main_info): Update.
5452 (main_info_cleanup): Remove.
5453 (_initialize_symtab): Update.
5454
5f6e90a0
TT
54552019-05-08 Tom Tromey <tom@tromey.com>
5456
5457 * registry.h (DECLARE_REGISTRY): Define the _key class.
5458
1bd0c6e4
AB
54592019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
5460
5461 * NEWS: Merge two 'New commands' sections.
5462
2228ef77
XR
54632019-05-08 Joel Brobecker <brobecker@adacore.com>
5464
5465 * ada-valprint.c (ada_val_print_gnat_array): Remove language
5466 parameter and use Ada language definition instead.
5467 (ada_val_print_ptr): Remove unused language parameter.
5468 (ada_val_print_num): Remove language parameter and use Ada language
5469 definition instead.
5470 (ada_val_print_enum, ada_val_print_flt): Remove unused language
5471 parameter.
5472 (ada_val_print_struct_union, ada_val_print_ref): Remove language
5473 parameter and use Ada language definition instead.
5474 (ada_val_print_1): Update all ada_val_print_xxx calls.
5475 Remove language parameter.
5476 (ada_val_print): Update ada_val_print_1 call.
5477
60fcc1c3
TT
54782019-05-08 Tom Tromey <tromey@adacore.com>
5479
5480 * remote.c (remote_hw_watchpoint_limit)
5481 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5482 Now static.
5483
ed2b7c17
TT
54842019-05-08 Tom Tromey <tromey@adacore.com>
5485
5486 * maint.c (_initialize_maint_cmds): Move initialization code to
5487 remote.c.
5488 (watchdog, show_watchdog): Move to remote.c.
5489 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
5490 "watchdog" static.
5491 (_initialize_remote): Move initialization code from maint.c.
5492 * defs.h (watchdog): Don't declare.
5493
b0be6c91
TT
54942019-05-08 Tom Tromey <tromey@adacore.com>
5495
5496 * tui/tui-interp.c: Include main.h.
5497 * interps.c: Include main.h.
5498 * main.h (interpreter_p): Declare.
5499 * defs.h (interpreter_p): Don't declare.
5500
587ee17b
TT
55012019-05-08 Tom Tromey <tromey@adacore.com>
5502
5503 * dwarf2loc.c: Include dwarf2read.h.
5504 * defs.h (read_unsigned_leb128): Don't declare.
5505 * dwarf2read.h (read_unsigned_leb128): Declare.
5506
ca1df239
TT
55072019-05-08 Tom Tromey <tromey@adacore.com>
5508
5509 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5510 method.
5511
99f20f08
TT
55122019-05-08 Tom Tromey <tromey@adacore.com>
5513
5514 * utils.c (fputs_maybe_filtered): Reset style after paging, even
5515 when no wrap column is set.
5516
80e55b13
TT
55172019-05-08 Tom Tromey <tromey@adacore.com>
5518
5519 * c-lang.c (c_get_string): Handle non-C-style arrays.
5520
9d3421af
TT
55212019-05-08 Tom Tromey <tromey@adacore.com>
5522
5523 * typeprint.c (print_offset_data::update): Print the bit offset,
5524 not the number of bits remaining.
5525
844333e2
TT
55262019-05-08 Tom Tromey <tromey@adacore.com>
5527
5528 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5529 padding at end of comment.
5530
988915ee
TT
55312019-05-08 Tom Tromey <tromey@adacore.com>
5532
5533 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5534 Compare main types.
5535
26bfd823
TT
55362019-05-06 Tom Tromey <tom@tromey.com>
5537
5538 * common/scoped_mmap.c: Include common-defs.h.
5539 * common/scoped_mmap.h: Don't include config.h.
5540
89055eaa
TT
55412019-05-04 Tom Tromey <tom@tromey.com>
5542
5543 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5544 (struct aarch64_call_info): Add initializers.
5545 <si>: Now a std::vector.
5546 (pass_on_stack, aarch64_push_dummy_call): Update.
5547
5da01df5
TT
55482019-05-04 Simon Marchi <simon.marchi@efficios.com>
5549 Tom Tromey <tom@tromey.com>
5550
5551 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5552 (ppc_threads): Now a std::vector. Now static.
5553 (hwdebug_find_thread_points_by_tid)
5554 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5555 Update.
5556
fbdf05a1
TT
55572019-05-04 Tom Tromey <tom@tromey.com>
5558
5559 * arc-tdep.c (arc_tdesc_init): Return bool.
5560
06d16ec9
TT
55612019-05-04 Tom Tromey <tom@tromey.com>
5562
5563 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5564 Use gdb_assert_not_reached.
5565
9c056022
TT
55662019-05-04 Tom Tromey <tom@tromey.com>
5567
5568 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5569 "false".
5570
fa9c2a59
TT
55712019-05-04 Tom Tromey <tom@tromey.com>
5572
5573 * arc-tdep.c (arc_tdesc_init): Use bool.
5574
e2eb806a
TT
55752019-05-04 Tom Tromey <tom@tromey.com>
5576
5577 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5578
6fe87677
TT
55792019-05-04 Tom Tromey <tom@tromey.com>
5580
5581 * cli/cli-cmds.c (valid_command_p): Return bool.
5582
7f008c9e
TT
55832019-05-04 Tom Tromey <tom@tromey.com>
5584
5585 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5586 * command.h (valid_user_defined_cmd_name_p): Channge return type.
5587
b6484282
RT
55882019-05-04 Raul Tambre <raul@tambre.ee>
5589
5590 * python/lib/gdb/prompt.py (_ExtendedPrompt)
5591 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5592 operator for comparison.
5593
af97b416
TT
55942019-05-04 Tom Tromey <tom@tromey.com>
5595
5596 * psymtab.c (psymbol_name_matches, match_partial_symbol)
5597 (lookup_partial_symbol, print_partial_symbols)
5598 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5599 (psymbol_compare): Update.
5600 (add_psymbol_to_bcache): Clear the entire psymbol.
5601 (maintenance_check_psymtabs): Update.
5602 * psympriv.h (struct partial_symbol): Don't derive from
5603 general_symbol_info.
5604 <obj_section, unrelocated_address, address,
5605 set_unrelocated_address>: Update.
5606 <ginfo>: New member.
5607 * dwarf-index-write.c (write_psymbols, debug_names::insert)
5608 (debug_names::write_psymbols): Update.
5609
9d6d4be8
TV
56102019-05-04 Tom de Vries <tdevries@suse.de>
5611
5612 * contrib/cc-with-tweaks.sh: Support -n arg.
5613
66452beb
PW
56142019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5615
5616 * corelow.c (core_target::detach): Ensure frame cache and
5617 register caches are cleared.
5618 inferior.c (exit_inferior_1): Likewise.
5619
bde09ab7
TT
56202019-05-03 Sandra Loosemore <sandra@codesourcery.com>
5621 Tom Tromey <tom@tromey.com>
5622
5623 * dictionary.c (collate_pending_symbols_by_language): Remove
5624 "struct" from foreach.
5625 * symtab.c (lookup_global_symbol_from_objfile)
5626 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5627 foreach.
5628 * ser-tcp.c (net_open): Remove "struct" from foreach.
5629 * objfiles.c (objfile_relocate, objfile_rebase)
5630 (objfile_has_symbols): Remove "struct" from foreach.
5631 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5632 from foreach.
5633 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5634 foreach.
5635 * darwin-nat.c (thread_info_from_private_thread_info): Remove
5636 "struct" from foreach.
5637 * ada-lang.c (create_excep_cond_exprs)
5638 (ada_exception_catchpoint_cond_string): Remove "struct" from
5639 foreach.
5640
222a8d25
TT
56412019-05-03 Tom Tromey <tromey@adacore.com>
5642
5643 * ada-exp.y (convert_char_literal): Check suffix of each
5644 enumerator.
5645
fcd60b84
DP
56462019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
5647
5648 PR ada/21406:
5649 * ada-exp.y (yywrap): Don't define.
5650 * ada-lex.l (%option): Add noyywrap
5651 (yywrap): Remove.
5652
5f2459c2
EZ
56532019-05-03 Eli Zaretskii <eliz@gnu.org>
5654
353ea2d1
EZ
5655 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5656 _WIN32_WINNT to the XP level, unless already defined to a higher
5657 level.
5658
5659 * unittests/parse-connection-spec-selftests.c:
5660 * ser-tcp.c:
5661 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
5662 override.
5663
5f2459c2
EZ
5664 * symfile.c (find_separate_debug_file): Remove colon from the
5665 drive spec of DOS/Windows file names of the target, so that the
5666 file name produced from DEBUGDIR and the target's directory will
5667 be valid on DOS/Windows systems.
5668
80062eb9
AB
56692019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
5670
5671 * rust-lang.c (val_print_struct): Handle printing structures
5672 containing strings.
5673
b8c05e85
TT
56742019-05-02 Tom Tromey <tromey@adacore.com>
5675
5676 * valarith.c (_initialize_valarith): Remove.
5677
4504bbde
TT
56782019-05-01 Tom Tromey <tromey@adacore.com>
5679
5680 * ada-lang.c (ada_value_primitive_field): Treat more fields as
5681 bitfields.
5682
d48e62f4
TT
56832019-05-01 Tom Tromey <tromey@adacore.com>
5684
5685 * ada-lang.c (ada_value_assign): Correctly compute starting offset
5686 for big-endian copies.
5687
15f18d14
AT
56882019-04-30 Ali Tamur <tamur@google.com>
5689 * gdb/dwarf2read.c (read_3_bytes): New declaration.
5690 (read_attribute_value): Added DW_FORM_strx1-4 cases.
5691 (read_3_bytes): New function.
5692
ab4ee614
JB
56932019-04-30 Joel Brobecker <brobecker@adacore.com>
5694
5695 * windows-nat.c (main_thread_id): Delete.
5696 (handle_output_debug_string): Replace main_thread_id by
5697 current_event.dwThreadId.
5698 (fake_create_process): Likewise.
5699 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5700 Do not set main_thread_id.
5701 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5702 current_event.dwThreadId.
5703 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5704
8ed5b76e
JB
57052019-04-30 Joel Brobecker <brobecker@adacore.com>
5706
5707 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5708 Use current_event.dwThreadId instead of main_thread_id.
5709
2ff0a947
TT
57102019-04-30 Tom Tromey <tromey@adacore.com>
5711
5712 * ada-lang.c (ada_lookup_simple_minsyms): New function.
5713 (create_excep_cond_exprs): Iterate over program spaces.
5714 (ada_exception_catchpoint_cond_string): Examine all minimal
5715 symbols for exception types.
5716
a776957c
TT
57172019-04-30 Tom Tromey <tromey@adacore.com>
5718
5719 PR c++/24470:
5720 * dwarf2read.c (process_structure_scope): Handle case where type
5721 has template parameters but no symbol was created.
5722
bc68014d
AB
57232019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5724 Chris January <chris.january@arm.com>
5725
5726 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5727 qualifier.
5728 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5729
f1fdc960
AB
57302019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5731
5732 * f-typeprint.c (f_print_type): Update rules for printing
5733 whitespace.
5734 (f_type_print_varspec_suffix): Likewise.
5735
bf7a4de1
AB
57362019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5737 Chris January <chris.january@arm.com>
5738
5739 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5740 function arguments.
5741
bbe75b9d
AB
57422019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5743
5744 * f-lang.c (build_fortran_types): Change name of void type to
5745 lower case.
5746 * f-typeprint.c (f_type_print_base): Print the name of the void
5747 type, rather than a fixed string.
5748 * f-valprint.c (f_decorations): Use lower case void string.
5749
1db455a7
AB
57502019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5751 Chris January <chris.january@arm.com>
5752
5753 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5754 types for Fortran.
5755
b6d03bb2
AB
57562019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5757 Chris January <chris.january@arm.com>
5758 David Lecomber <david.lecomber@arm.com>
5759
5760 * f-exp.y (BINOP_INTRINSIC): New token.
5761 (exp): New parser rule handling BINOP_INTRINSIC.
5762 (f77_keywords): Add new builtin procedures.
5763 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5764 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5765 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5766 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5767 (print_unop_subexp_f): New function.
5768 (print_binop_subexp_f): New function.
5769 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5770 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5771 (dump_subexp_body_f): Likewise.
5772 (operator_check_f): Likewise.
5773 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5774 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5775
83228e93
AB
57762019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5777
5778 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5779 UNOP_KIND.
5780 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5781 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5782 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5783 (operator_length_f): New fuction.
5784 (print_subexp_f): New function.
5785 (op_name_f): New function.
5786 (dump_subexp_body_f): New function.
5787 (operator_check_f): New function.
5788 (exp_descriptor_f): Replace standard expression handling functions
5789 with new functions.
5790 * gdb/fortran-operator.def: New file.
5791 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5792 * gdb/std-operator.def: Remove UNOP_KIND.
5793
6fdcd7cc
AB
57942019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5795
5796 * std-operator.def: Remove unbalanced, stray double quote
5797 character.
5798
2e62ab40
AB
57992019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5800 Chris January <chris.january@arm.com>
5801 Daniel Everett <daniel.everett@arm.com>
5802 Nick Forrington <nick.forrington@arm.com>
5803 Richard Bunt <richard.bunt@arm.com>
5804
5805 * cp-valprint.c (cp_print_value_fields): Allow an additional level
5806 of depth when printing anonymous structs or unions.
5807 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5808 Don't print either the top-level value, or the children if the
5809 max-depth is exceeded.
5810 (ppscm_print_children): When printing the key of a map, allow one
5811 extra level of depth.
5812 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5813 print either the top-level value, or the children if the max-depth
5814 is exceeded.
5815 (print_children): When printing the key of a map, allow one extra
5816 level of depth.
5817 * python/py-value.c (valpy_format_string): Add max_depth keyword.
5818 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5819 (user_print_options): Initialise max_depth field.
5820 (val_print_scalar_or_string_type_p): New function.
5821 (val_print): Check to see if the max depth has been reached.
5822 (val_print_check_max_depth): Define new function.
5823 (show_print_max_depth): New function.
5824 (_initialize_valprint): Add 'print max-depth' option.
5825 * valprint.h (struct value_print_options) <max_depth>: New field.
5826 (val_print_check_max_depth): Declare new function.
5827 * NEWS: Document new feature.
5828
4be290b2
AB
58292019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5830
5831 * ada-lang.c (ada_language_defn): Initialise new field.
5832 * c-lang.c (c_is_string_type_p): New function.
5833 (c_language_defn): Initialise new field.
5834 (cplus_language_defn): Initialise new field.
5835 (asm_language_defn): Initialise new field.
5836 (minimal_language_defn): Initialise new field.
5837 * c-lang.h (c_is_string_type_p): Declare new function.
5838 * d-lang.c (d_language_defn): Initialise new field.
5839 * f-lang.c (f_is_string_type_p): New function.
5840 (f_language_defn): Initialise new field.
5841 * go-lang.c (go_is_string_type_p): New function.
5842 (go_language_defn): Initialise new field.
5843 * language.c (default_is_string_type_p): New function.
5844 (unknown_language_defn): Initialise new field.
5845 (auto_language_defn): Initialise new field.
5846 * language.h (struct language_defn) <la_is_string_type_p>: New
5847 member variable.
5848 (default_is_string_type_p): Declare new function.
5849 * m2-lang.c (m2_language_defn): Initialise new field.
5850 * objc-lang.c (objc_language_defn): Initialise new field.
5851 * opencl-lang.c (opencl_language_defn): Initialise new field.
5852 * p-lang.c (pascal_is_string_type_p): New function.
5853 (pascal_language_defn): Initialise new field.
5854 * rust-lang.c (rust_is_string_type_p): New function.
5855 (rust_language_defn): Initialise new field.
5856
721b08c6
AB
58572019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5858
5859 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5860 New field.
5861 * ada-lang.c (ada_language_defn): Initialise new field.
5862 * c-lang.c (c_language_defn): Likewise.
5863 (cplus_language_defn): Likewise.
5864 (asm_language_defn): Likewise.
5865 (minimal_language_defn): Likewise.
5866 * d-lang.c (d_language_defn): Likewise.
5867 * f-lang.c (f_language_defn): Likewise.
5868 * go-lang.c (go_language_defn): Likewise.
5869 * language.c (unknown_language_defn): Likewise.
5870 (auto_language_defn): Likewise.
5871 * m2-lang.c (m2_language_defn): Likewise.
5872 * objc-lang.c (objc_language_defn): Likewise.
5873 * opencl-lang.c (opencl_language_defn): Likewise.
5874 * p-lang.c (pascal_language_defn): Likewise.
5875 * rust-lang.c (rust_language_defn): Likewise.
5876
fc913e53
AB
58772019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5878
5879 * ada-lang.c (ada_is_character_type): Change return type to bool.
5880 (ada_is_string_type): Likewise.
5881 * ada-lang.h (ada_is_character_type): Update declaration
5882 (ada_is_string_type): Likewise.
5883
fa731fa0
PW
58842019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5885
5886 Support style in 'frame|thread apply'
5887
5888 * gdbcmd.h (execute_command_to_string): New term_out parameter.
5889 * record.c (record_start, record_stop): Update callers of
5890 execute_command_to_string with false.
5891 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5892 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5893 methods.
5894 (class string_file): New constructor with term_out parameter.
5895 Override methods term_out and can_emit_style_escape. New member
5896 term_out.
5897 (class stdio_file): Override can_emit_style_escape.
5898 (class tee_file): Override term_out and can_emit_style_escape.
5899 * utils.h (can_emit_style_escape): Remove.
5900 * utils.c (can_emit_style_escape): Likewise.
5901 Update all callers of can_emit_style_escape (SOMESTREAM) to
5902 SOMESTREAM->can_emit_style_escape.
5903 * source-cache.c (source_cache::get_source_lines): Likewise.
5904 * stack.c (frame_apply_command_count): Call execute_command_to_string
5905 passing the term_out characteristic of the current gdb_stdout.
5906 * thread.c (thr_try_catch_cmd): Likewise.
5907 * top.c (execute_command_to_string): pass term_out parameter
5908 to construct the string_file for the command output.
5909 * ui-file.c (term_cli_styling): New function (most code moved
5910 from utils.c can_emit_style_escape).
5911 (string_file::string_file, string_file::can_emit_style_escape,
5912 stdio_file::can_emit_style_escape, tee_file::term_out,
5913 tee_file::can_emit_style_escape): New functions.
5914
136afab8
PW
59152019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5916
5917 * NEWS: Mention the new set|show may-call-functions.
5918 * infcall.c (may_call_functions_p): New variable.
5919 (show_may_call_functions_p): New function.
5920 (call_function_by_hand_dummy): Throws an error if not
5921 may-call-functions.
5922 (_initialize_infcall): Call add_setshow_boolean_cmd for
5923 may-call-functions.
5924
725cbb63
KS
59252019-04-25 Keith Seitz <keiths@redhat.com>
5926
5927 PR c++/24367
5928 * cp-support.c (inspect_type): Don't attempt substitutions
5929 of symbol with the same name.
5930
3d1cbb78
TT
59312019-04-25 Tom Tromey <tromey@adacore.com>
5932
5933 PR gdb/24475:
5934 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5935 static.
5936
94aeb44b
TT
59372019-04-25 Tom Tromey <tromey@adacore.com>
5938
5939 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5940 rvalue reference.
5941 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5942 (gdb_xml_parser::parse): Use std::move.
5943 * python/python-internal.h (gdbpy_convert_exception): Take a const
5944 reference.
5945 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5946 std::move.
5947 * python/py-utils.c (gdbpy_convert_exception): Take a const
5948 reference.
5949 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5950 Use std::move.
5951 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5952 Use std::move.
5953 * mi/mi-main.c (mi_print_exception): Take a const reference.
5954 * main.c (handle_command_errors): Take a const reference.
5955 * linespec.c (parse_linespec): Use std::move.
5956 * infcall.c (run_inferior_call): Use std::move.
5957 (call_function_by_hand_dummy): Use std::move.
5958 * exec.c (try_open_exec_file): Use std::move.
5959 * exceptions.h (exception_print, exception_fprintf)
5960 (exception_print_same): Update.
5961 * exceptions.c (print_exception, exception_print)
5962 (exception_fprintf, exception_print_same): Change parameters to
5963 const reference.
5964 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5965 * common/new-op.c: Use std::move.
5966 * common/common-exceptions.h (struct gdb_exception): Add move
5967 constructor.
5968 (struct gdb_exception_error, struct gdb_exception_quit, struct
5969 gdb_quit_bad_alloc): Change constructor to move constructor.
5970 (throw_exception): Change parameter to rvalue reference.
5971 * common/common-exceptions.c (throw_exception): Take rvalue
5972 reference.
5973 * cli/cli-interp.c (safe_execute_command): Use std::move.
5974 * breakpoint.c (insert_bp_location, location_to_sals): Use
5975 std::move.
5976
680d7fd5
TT
59772019-04-25 Tom Tromey <tromey@adacore.com>
5978
5979 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5980 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5981 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5982 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5983 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5984 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5985 guile/scm-value.c: Use unpack.
5986 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5987 gdbscm_gdb_exception.
5988 (gdbscm_throw_gdb_exception): Likewise.
5989 (struct gdbscm_gdb_exception): New.
5990 (unpack): New function.
5991 (gdbscm_wrap): Use unpack.
5992
c6fdd8b2
TT
59932019-04-25 Tom Tromey <tromey@adacore.com>
5994
5995 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5996 (gdb_rl_callback_handler): Use std::move.
5997 * common/common-exceptions.h (struct gdb_exception): Add move
5998 assignment operator.
5999 (throw_exception_sjlj): Change "exception" to const reference.
6000 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6001 (throw_exception_sjlj): Change "exception" to const reference.
6002
cc06b668
TT
60032019-04-25 Tom Tromey <tromey@adacore.com>
6004
6005 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6006 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6007 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6008 Update.
6009 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6010 Update.
6011 * mi/mi-interp.c (mi_interp::exec): Update.
6012 * linespec.c (parse_linespec): Update.
6013 * infcall.c (run_inferior_call): Update.
6014 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6015 * guile/scm-symbol.c (gdbscm_lookup_symbol)
6016 (gdbscm_lookup_global_symbol): Update.
6017 * guile/scm-param.c (gdbscm_parameter_value): Update.
6018 * guile/scm-frame.c (gdbscm_frame_read_register)
6019 (gdbscm_frame_read_var): Update.
6020 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6021 * exec.c (try_open_exec_file): Update.
6022 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6023 (gdb_rl_callback_handler): Update.
6024 * common/common-exceptions.h (exception_none): Don't declare.
6025 * common/common-exceptions.c (exception_none): Don't define.
6026 (struct catcher) <exception>: Update.
6027 * cli/cli-interp.c (safe_execute_command): Update.
6028 * breakpoint.c (insert_bp_location, location_to_sals): Update.
6029
cf532bd1
AT
60302019-04-25 Ali Tamur <tamur@google.com>
6031
6032 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6033 (read_attribute_value): Likewise.
6034 (dwarf2_read_addr_index): Update comment.
6035 (read_str_index): Add DW_FORM_strx.
6036 (dwarf2_string_attr): Likewise.
6037 (dwarf2_const_value_attr): Likewise.
6038 (dump_die_shallow): Likewise.
6039 (dwarf2_fetch_constant_bytes): Likewise.
6040 (skip_form_bytes): Likewise.
6041 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6042
82433e3e
SDJ
60432019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
6044
6045 PR corefiles/11608
6046 PR corefiles/18187
6047 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6048 OFFSET. Verify if current mapping contains an ELF header.
6049 (linux_find_memory_regions_full): Adjust call to
6050 dump_mapping_p.
6051
723adb65
SL
60522019-04-25 Sandra Loosemore <sandra@codesourcery.com>
6053 Kang Li <kanglictf@gmail.com>
6054
6055 PR gdb/21600
6056
6057 * dwarf2-frame.c (read_initial_length): Be consistent about using
6058 unsigned representation of length.
6059 (decode_frame_entry_1): Likewise. Check for wraparound of
6060 end pointer as well as buffer overflow.
6061
596179f7
SDJ
60622019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
6063
6064 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6065 "vq".
6066
a59240a4
TT
60672019-04-24 Tom Tromey <tromey@adacore.com>
6068
6069 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6070
f872fdbb
AB
60712019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6072
6073 * s12z-tdep.c (s12z_unwind_pc): Delete.
6074 (s12z_unwind_sp): Delete.
6075 (s12z_gdbarch_init): Don't register deleted functions with
6076 gdbarch.
6077
b614e6f3
AB
60782019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6079
6080 * rl78-tdep.c (rl78_unwind_sp): Delete.
6081 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6082
14faed38
AB
60832019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6084
6085 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6086 (xstormy16_unwind_pc): Delete.
6087 (xstormy16_dummy_id): Delete.
6088 (xstormy16_gdbarch_init): Don't register deleted functions with
6089 gdbarch.
6090
541aad8a
AB
60912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6092
6093 * vax-tdep.c (vax_unwind_pc): Delete.
6094 (vax_gdbarch_init): Don't register deleted function with gdbarch.
6095
29222070
AB
60962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6097
6098 * v850-tdep.c (v850_unwind_sp): Delete.
6099 (v850_unwind_pc): Delete.
6100 (v850_dummy_id): Delete.
6101 (v850_gdbarch_init): Don't register deleted functions with
6102 gdbarch.
6103
0f534d76
AB
61042019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6105
6106 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6107 (tilegx_unwind_pc): Delete.
6108 (tilegx_unwind_dummy_id): Delete.
6109 (tilegx_gdbarch_init): Don't register deleted functions with
6110 gdbarch.
6111
1ba7b7f9
AB
61122019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6113
6114 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6115 (tic6x_dummy_id): Delete.
6116 (tic6x_gdbarch_init): Don't register deleted functions with
6117 gdbarch.
6118
d31f262c
AB
61192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6120
6121 * sparc-tdep.c (sparc_unwind_pc): Delete.
6122 (sparc32_gdbarch_init): Don't register deleted function with
6123 gdbarch.
6124
6d14d64d
AB
61252019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6126
6127 * sh-tdep.c (sh_unwind_sp): Delete.
6128 (sh_unwind_pc): Delete.
6129 (sh_dummy_id): Delete.
6130 (sh_gdbarch_init): Don't register deleted functions with
6131 gdbarch.
6132
a40dde9d
AB
61332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6134
6135 * score-tdep.c (score_unwind_sp): Delete.
6136 (score_unwind_pc): Delete.
6137 (score_dummy_id): Delete.
6138 (score_gdbarch_init): Don't register deleted functions with
6139 gdbarch.
6140
47c47d69
AB
61412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6142
6143 * rx-tdep.c (rx_unwind_pc): Delete.
6144 (rx_unwind_sp): Delete.
6145 (rx_dummy_id): Delete.
6146 (rx_gdbarch_init): Don't register deleted functions with
6147 gdbarch. Update comment.
6148
833a4480
AB
61492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6150
6151 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6152 (rs6000_dummy_id): Delete.
6153 (rs6000_gdbarch_init): Don't register deleted functions with
6154 gdbarch.
6155
3f2cef49
AB
61562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6157
6158 * or1k-tdep.c (or1k_dummy_id): Delete.
6159 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6160
96acf884
AB
61612019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6162
6163 * nios2-tdep.c (nios2_dummy_id): Delete.
6164 (nios2_unwind_sp): Delete.
6165 (nios2_gdbarch_init): Don't register deleted functions with
6166 gdbarch.
6167
ca0ab0aa
AB
61682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6169
6170 * nds32-tdep.c (nds32_dummy_id): Delete.
6171 (nds32_unwind_pc): Delete.
6172 (nds32_unwind_sp): Delete.
6173 (nds32_gdbarch_init): Don't register deleted functions with
6174 gdbarch.
6175
c8259044
AB
61762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6177
6178 * msp430-tdep.c (msp430_unwind_pc): Delete.
6179 (msp430_unwind_sp): Delete.
6180 (msp430_dummy_id): Delete.
6181 (msp430_gdbarch_init): Don't register deleted functions with
6182 gdbarch.
6183
27f113c8
AB
61842019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6185
6186 * moxie-tdep.c (moxie_unwind_sp): Delete.
6187 (moxie_unwind_pc): Delete.
6188 (moxie_dummy_id): Delete.
6189 (moxie_gdbarch_init): Don't register deleted functions with
6190 gdbarch.
6191
aee6c3cd
AB
61922019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6193
6194 * mn10300-tdep.c (mn10300_dummy_id): Delete.
6195 (mn10300_unwind_pc): Delete.
6196 (mn10300_unwind_sp): Delete.
6197 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6198 mn10300_unwind_sp.
6199 (mn10300_frame_unwind_init): Don't register deleted functions with
6200 gdbarch.
6201
8e2b5aea
AB
62022019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6203
6204 * mep-tdep.c (mep_unwind_pc): Delete.
6205 (mep_unwind_sp): Delete.
6206 (mep_dummy_id): Delete.
6207 (mep_gdbarch_init): Don't register deleted functions with
6208 gdbarch.
6209
43cf3ede
AB
62102019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6211
6212 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6213 (m68hc11_unwind_sp): Delete.
6214 (m68hc11_gdbarch_init): Don't register deleted functions with
6215 gdbarch.
6216
5e79b7bb
AB
62172019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6218
6219 * m32r-tdep.c (m32r_unwind_sp): Delete.
6220 (m32r_unwind_pc): Delete.
6221 (m32r_dummy_id): Delete.
6222 (m32r_gdbarch_init): Don't register deleted functions with
6223 gdbarch.
6224
89b268d8
AB
62252019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6226
6227 * m32c-tdep.c (m32c_unwind_pc): Delete.
6228 (m32c_unwind_sp): Delete.
6229 (m32c_dummy_id): Delete.
6230 (m32c_gdbarch_init): Don't register deleted functions with
6231 gdbarch.
6232
946c28d2
AB
62332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6234
6235 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6236 (lm32_unwind_pc): Delete.
6237 (lm32_dummy_id): Delete.
6238 (lm32_gdbarch_init): Don't register deleted functions with
6239 gdbarch.
6240
bf12844a
AB
62412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6242
6243 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6244 (iq2000_unwind_pc): Delete.
6245 (iq2000_dummy_id): Delete.
6246 (iq2000_gdbarch_init): Don't register deleted functions with
6247 gdbarch.
6248
ecbc06d2
AB
62492019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6250
6251 * nds32-tdep.c (nds32_type_align): Delete.
6252 (nds32_push_dummy_call): Use type_align instead.
6253
030197b4
AB
62542019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6255
6256 * arm-tdep.c (arm_type_align): Only handle vector override case.
6257 (arm_push_dummy_call): Use type_align.
6258 (arm_gdbarch_init): Register arm_type_align gdbarch function.
6259
b907456c
AB
62602019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6261
6262 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6263 case.
6264 (pass_on_stack): Use type_align.
6265 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6266 function.
6267
9e97ba43
TT
62682019-04-23 Tom Tromey <tromey@adacore.com>
6269
6270 * dwarf2read.c (line_header::file_name_at): Remove unused
6271 overload.
6272
6892f601
TV
62732019-04-23 Tom de Vries <tdevries@suse.de>
6274
6275 PR gdb/24438
6276 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6277 invocation.
6278
336d760d
AT
6279
62802019-03-27 Ali Tamur <tamur@google.com>
6281
6282 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6283 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6284 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6285 (dwarf_expr_context::get_addr_index): Likewise
6286 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6287 (symbol_needs_eval_context::get_addr_index): Likewise
6288 (disassemble_dwarf_expression): Add DW_OP_addrx
6289 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6290 (read_cutu_die_from_dwo): Update comment
6291 (skip_one_die): Add DW_FORM_addrx
6292 (read_attribute_value): Likewise
6293 (var_decode_location): Add DW_OP_addrx
6294 (dwarf2_const_value_attr): Add DW_FORM_addrx
6295 (dump_die_shallow): Likewise
6296 (dwarf2_fetch_constant_bytes): Likewise
6297 (decode_locdesc): Add DW_OP_addrx
6298 (skip_form_bytes): Add DW_FORM_addrx
6299
ad9d13f8
AT
63002019-04-22 Ali Tamur <tamur@google.com>
6301
6302 * MAINTAINERS (Write After Approval): Add self.
6303
d70cc3ba
SM
63042019-04-22 Simon Marchi <simon.marchi@efficios.com>
6305
6306 * solib-svr4.c (get_svr4_info): Add pspace parameter.
6307 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6308 (open_symbol_file_object): Likewise.
6309 (svr4_default_sos): Add info parameter.
6310 (svr4_read_so_list): Likewise.
6311 (svr4_current_sos_direct): Adjust functions calls to pass down
6312 info.
6313 (svr4_current_sos_1): Add info parameter.
6314 (svr4_current_sos): Call get_svr4_info, pass info down to
6315 svr4_current_sos_1.
6316 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6317 get_svr4_info.
6318 (svr4_in_dynsym_resolve_code): Pass current_program_space to
6319 get_svr4_info.
6320 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6321 to get_svr4_info.
6322 (probes_table_remove_objfile_probes): Likewise.
6323 (register_solib_event_probe): Add info parameter.
6324 (solist_update_incremental): Pass info parameter down to
6325 svr4_read_so_list.
6326 (disable_probes_interface): Add info parameter.
6327 (svr4_handle_solib_event): Pass current_program_space to
6328 get_svr4_info. Adjust disable_probes_interface cleanup.
6329 (svr4_create_probe_breakpoints): Add info parameter, pass it
6330 down to register_solib_event_probe.
6331 (svr4_create_solib_event_breakpoints): Add info parameter,
6332 pass it down to svr4_create_probe_breakpoints.
6333 (enable_break): Pass info down to
6334 svr4_create_solib_event_breakpoints.
6335 (svr4_solib_create_inferior_hook): Pass current_program_space to
6336 get_svr4_info.
6337 (svr4_clear_solib): Likewise.
6338
7905fc35
PA
63392019-04-22 Pedro Alves <palves@redhat.com>
6340
6341 * solib-svr4.c (svr4_free_objfile_observer): New.
6342 (probe_and_action::objfile): New field.
6343 (probes_table_htab_remove_objfile_probes)
6344 (probes_table_remove_objfile_probes): New functions.
6345 (register_solib_event_probe): Add 'objfile' parameter. Store it
6346 in the new probe_and_action. Don't store the probe in 'lookup'.
6347 (svr4_create_probe_breakpoints): Pass objfile to
6348 register_solib_event_probe.
6349 (_initialize_svr4_solib): Register a free_objfile observer.
6350
fb881986
TT
63512019-04-19 Tom Tromey <tom@tromey.com>
6352
6353 * common/queue.h: Remove.
6354
8732db6c
TT
63552019-04-19 Tom Tromey <tom@tromey.com>
6356
6357 * event-loop.c: Don't include "common/queue.h".
6358
97dfbadd
TT
63592019-04-19 Tom Tromey <tom@tromey.com>
6360
6361 * remote.c (remote_target): Use delete.
6362 * remote-notif.h: Include <list>, not "common/queue.h".
6363 (notif_client_p): Remove typedef.
6364 (remote_notif_state): Add constructor, destructor, initializer.
6365 <notif_queue>: Now a std::list.
6366 (remote_notif_state_xfree): Don't declare.
6367 * remote-notif.c (remote_notif_process, handle_notification)
6368 (remote_notif_state_allocate): Update.
6369 (~remote_notif_state): Rename from remote_notif_state_xfree.
6370
cf250e36
TT
63712019-04-19 Tom Tromey <tom@tromey.com>
6372
6373 * symfile.c (reread_symbols): Update.
6374 * objfiles.c (objfile_register_static_link)
6375 (objfile_lookup_static_link): Update
6376 (~objfile) Don't delete static_links.
6377 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6378
61f4b350
TT
63792019-04-19 Tom Tromey <tom@tromey.com>
6380
6381 * type-stack.h (struct type_stack) <insert>: Constify string.
6382 * type-stack.c (type_stack::insert): Constify string.
6383 * gdbtypes.h (lookup_template_type): Update.
6384 (address_space_name_to_int): Update.
6385 * gdbtypes.c (address_space_name_to_int): Make space_identifier
6386 const.
6387 (lookup_template_type): Make name const.
6388 * c-exp.y: Update rules.
6389 (lex_one_token, classify_name, classify_inner_name)
6390 (c_print_token): Update.
6391 * p-exp.y: Update rules.
6392 (yylex): Update.
6393 * f-exp.y: Update rules.
6394 (yylex): Update.
6395 * d-exp.y: Update rules.
6396 (lex_one_token, classify_name, classify_inner_name): Update.
6397 * parse.c (write_dollar_variable, copy_name): Return std::string.
6398 * parser-defs.h (copy_name): Change return type.
6399 * m2-exp.y: Update rules.
6400 (yylex): Update.
6401 * go-exp.y (lex_one_token): Update.
6402 Update rules.
6403 (classify_unsafe_function, classify_packaged_name)
6404 (classify_name, yylex): Update.
6405
189b8c2e
ST
64062019-04-19 Sergei Trofimovich <siarheit@google.com>
6407
6408 * configure.ac: add --enable-source-highlight switch.
6409 * configure: Regenerate.
6410 * top.c (print_gdb_version): plumb --enable-source-highlight
6411 status to "show configuration".
6412
8ecb59f8
TT
64132019-04-19 Tom Tromey <tromey@adacore.com>
6414
6415 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6416 Check ADA_TYPE_P.
6417 (empty_record, ada_template_to_fixed_record_type_1)
6418 (template_to_static_fixed_type)
6419 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6420 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6421 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6422 macros.
6423
62160ec9
TT
64242019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
6425
6426 PR symtab/24423:
6427 * source.c (print_source_lines_base): Advance "iter" when a
6428 control character is seen.
6429
f2ae8bc8
PW
64302019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6431
6432 * inferior.h (struct infcall_suspend_state_deleter):
6433 Catch exception in destructor to avoid crash.
6434
d563b953
PW
64352019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6436
6437 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6438 close to the add_com "shell".
6439
dc34c897
TT
64402019-04-18 Tom Tromey <tromey@adacore.com>
6441
6442 * process-stratum-target.h (class process_stratum_target)
6443 <stratum>: Add "final".
6444
a12e5744
TT
64452019-04-17 Tom Tromey <tromey@adacore.com>
6446
6447 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6448 against nullptr before use.
6449
a7e559cc
AH
64502019-04-17 Alan Hayward <alan.hayward@arm.com>
6451
6452 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6453
c01660c6
AB
64542019-04-17 Jim Wilson <jimw@sifive.com>
6455 Andrew Burgess <andrew.burgess@embecosm.com>
6456
6457 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6458 code read might fail, assume 4-byte breakpoint in that case.
6459
4aa866af
LS
64602019-04-15 Leszek Swirski <leszeks@google.com>
6461
6462 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6463 rather than a hand-rolled POD check when checking for forced MEMORY
6464 classification.
6465
48574d91
AH
64662019-04-15 Alan Hayward <alan.hayward@arm.com>
6467
6468 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6469 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6470 function.
6471 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6472 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6473 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6474 declaration.
6475
4da037ef
AH
64762019-04-15 Alan Hayward <alan.hayward@arm.com>
6477
6478 * aarch64-linux-nat.c
6479 (aarch64_linux_nat_target::thread_architecture): Add override.
6480 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6481 each VQ.
6482
ccb8d7e8
AH
64832019-04-15 Alan Hayward <alan.hayward@arm.com>
6484
6485 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6486
35add35e
AB
64872019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
6488
6489 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6490 target types of size 96-bits, add some additional comments, and
6491 check that the builtin type we found was the correct size.
6492
51196bbc
EZ
64932019-04-12 Eli Zaretskii <eliz@gnu.org>
6494
6495 * utils.c (prompt_for_continue): Don't restore the styling at the
6496 end, as applied_style has the wrong value. This fixes styling in
6497 long lists of file names that are interrupted by the "Continue?"
6498 prompt.
6499
62253a61
AB
65002019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
6501
6502 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6503 * c-lang.c (c_language_defn): Likewise.
6504 (cplus_language_defn): Likewise.
6505 (asm_language_defn): Likewise.
6506 (minimal_language_defn): Likewise.
6507 * d-lang.c (d_language_defn): Likewise.
6508 * f-lang.c (f_language_defn): Likewise.
6509 * go-lang.c (go_language_defn): Likewise.
6510 * language.c (unknown_language_defn): Likewise.
6511 (auto_language_defn): Likewise.
6512 * language.h (struct language_defn): Remove la_magic field.
6513 (LANG_MAGIC): Delete.
6514 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6515 * objc-lang.c (objc_language_defn): Likewise.
6516 * opencl-lang.c (opencl_language_defn): Likewise.
6517 * p-lang.c (pascal_language_defn): Likewise.
6518 * rust-lang.c (rust_language_defn): Likewise.
6519
a9158a86
AB
65202019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6521
6522 * riscv-tdep.c (riscv_type_align): New function.
6523 (riscv_type_alignment): Delete.
6524 (riscv_arg_location): Use 'type_align'.
6525 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6526
41077b66
AB
65272019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6528
6529 * gdbtypes.c (type_align): A struct with no non-static fields also
6530 has alignment of 1.
6531
9f0272f8
AB
65322019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6533
6534 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6535 component to 0.
6536 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6537 member.
6538 (riscv_struct_info::analyse): New implementation using new
6539 analyse_inner member function.
6540 (riscv_struct_info::field_offset): New member function.
6541 (riscv_struct_info::m_offsets): New member variable.
6542 (riscv_struct_info::analyse_inner): New private member function,
6543 takes the old implementation of riscv_struct_info::analyse but
6544 extended to track field offsets.
6545 (riscv_call_arg_struct): Update the struct folding special cases
6546 to handle cases where empty C++ structs, which are non-zero
6547 length, are found.
6548 (riscv_arg_location): Initialise the length of each location, a
6549 non-zero length now indicates the location is in use.
6550 (riscv_push_dummy_call): Allow for the first location having a
6551 non-zero offset when setting up arguments.
6552 (riscv_return_value): Likewise, but for return values.
6553
02cf60c7
TT
65542019-04-11 Tom Tromey <tromey@adacore.com>
6555
6556 * utils.c (internal_vproblem): Make "msg" const.
6557
68811f8f
AH
65582019-04-11 Alan Hayward <alan.hayward@arm.com>
6559
6560 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6561 * trad-frame.c (trad_frame_reset_saved_regs): New function.
6562 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6563 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6564
3f52fdbc
KB
65652019-04-10 Kevin Buettner <kevinb@redhat.com>
6566
6567 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6568 function.
6569 (fill_gregset): Call amd64_linux_collect_native_gregset instead
6570 of amd64_collect_native_gregset.
6571 (amd64_linux_nat_target::store_registers): Likewise.
6572
e9ad22ee
TT
65732019-04-10 Tom Tromey <tom@tromey.com>
6574
6575 * symtab.c (lookup_global_symbol_from_objfile)
6576 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6577 * objfiles.h (class separate_debug_iterator): New.
6578 (class separate_debug_range): New.
6579 (struct objfile) <separate_debug_objfiles>: New method.
6580 (objfile_separate_debug_iterate): Don't declare.
6581 * objfiles.c (separate_debug_iterator::operator++): Rename from
6582 objfile_separate_debug_iterate.
6583 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6584 iterator.
6585 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6586 iterator.
6587
ee371134
TT
65882019-04-10 Tom Tromey <tom@tromey.com>
6589
6590 * symfile.c (reread_symbols): Remove old comment.
6591 * objfiles.c (free_all_objfiles): Fix a typo.
6592
bf227d61
TT
65932019-04-10 Tom Tromey <tom@tromey.com>
6594
6595 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6596 * minsyms.c (lookup_minimal_symbol): Use foreach.
6597 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6598 (lookup_minimal_symbol_solib_trampoline): Likewise.
6599 * symfile.c (reread_symbols): Use foreach.
6600
8dc433a0
TT
66012019-04-09 Ivan Begert <ivanbegert@gmail.com>
6602 Tom Tromey <tromey@adacore.com>
6603
6604 PR rust/24414:
6605 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6606 (rust_lex_int_test): Change "value" to be LONGEST.
6607 (rust_lex_tests): Add test for long integer literal.
6608
9ab8741a
TT
66092019-04-09 Tom Tromey <tromey@adacore.com>
6610
6611 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6612 to bool.
6613 (extended_remote_target::attach): Update.
6614 (remote_target::remote_notice_new_inferior): Update.
6615 (remote_target::add_current_inferior_and_thread): Update.
6616 * inferior.c (exit_inferior_1): Use "false".
6617 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6618
e242fd12
SM
66192019-04-09 Simon Marchi <simon.marchi@efficios.com>
6620
9ca1957f 6621 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
6622 the "start" command.
6623
2b0c8b01
KB
66242019-04-08 Kevin Buettner <kevinb@redhat.com>
6625
6626 * python/py-inferior.c (infpy_thread_from_thread_handle):
6627 Adjust comments to reflect renaming of thread_from_thread_handle
6628 to thread_from_handle. Adjust keywords. Fix type error message.
6629 (inferior_object_methods): Add thread_from_handle. Retain
6630 thread_from_thread_handle, but mark it as deprecated.
6631
50a82723
KB
66322019-04-08 Kevin Buettner <kevinb@redhat.com>
6633
6634 * gdbthread.h (find_thread_by_handle): Revise declaration.
6635 * thread.c (find_thread_by_handle): Likewise. Adjust
6636 implementation too.
6637 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6638 support for buffer objects as handles.
6639
cf63b016
KB
66402019-04-08 Kevin Buettner <kevinb@redhat.com>
6641
6642 * python/py-infthread.c (thpy_thread_handle): New function.
6643 (thread_object_methods): Register thpy_thread_handle.
6644
3d6c6204
KB
66452019-04-08 Kevin Buettner <kevinb@redhat.com>
6646
6647 * gdbthread.h (thread_to_thread_handle): Declare.
6648 * thread.c (gdbtypes.h): Include.
6649 (thread_to_thread_handle): New function.
6650
6651 * target.h (struct target_ops): Add thread_info_to_thread_handle.
6652 (target_thread_info_to_thread_handle): Declare.
6653 * target.c (target_thread_info_to_thread_handle): New function.
6654 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6655 * target-delegates.c: Regenerate.
6656
6657 * linux-thread-db.c (class thread_db_target): Add method
6658 thread_info_to_thread_handle.
6659 (thread_db_target::thread_info_to_thread_handle): Define.
6660 * remote.c (class remote_target): Add new method
6661 thread_info_to_thread_handle.
6662 (remote_target::thread_info_to_thread_handle): Define.
6663
56be6ea8
PA
66642019-04-08 Pedro Alves <palves@redhat.com>
6665
6666 * common/common-exceptions.c (throw_exception): Don't create
6667 named object to throw; throw directly.
6668 (throw_it): Likewise. Don't initialize gdb_exception::message
6669 here, with new; pass FMT and AP to the ctor instead.
6670 * common/common-exceptions.h: Include <string>.
6671 (gdb_exception::gdb_exception(enum return_reason, enum errors,
6672 const char *, va_list)): New ctor. Use std::make_shared.
6673 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6674 errors)): Delete.
6675 (gdb_exception_error::gdb_exception_error(enum errors, const char
6676 *, va_list)): New.
6677 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6678 Add assertion.
6679 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6680 errors)): Delete.
6681 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6682 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6683 Add assertion.
6684
eedc3f4f
TT
66852019-04-08 Tom Tromey <tom@tromey.com>
6686
6687 * valops.c (value_rtti_indirect_type): Replace throw_exception
6688 with throw.
6689 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6690 with throw.
6691 * thread.c (thr_try_catch_cmd): Replace throw_exception with
6692 throw.
6693 * target.c (target_translate_tls_address): Replace throw_exception
6694 with throw.
6695 * stack.c (frame_apply_command_count): Replace throw_exception
6696 with throw.
6697 * solib-spu.c (append_ocl_sos): Replace throw_exception with
6698 throw.
6699 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6700 with throw.
6701 * rs6000-tdep.c (rs6000_frame_cache)
6702 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6703 * remote.c: Replace throw_exception with throw.
6704 * record-full.c (record_full_message, record_full_wait_1)
6705 (record_full_restore): Replace throw_exception with throw.
6706 * record-btrace.c:
6707 (get_thread_current_frame_id, record_btrace_start_replaying)
6708 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6709 (cmd_record_btrace_start): Replace throw_exception with throw.
6710 * parse.c (parse_exp_in_context_1): Replace throw_exception with
6711 throw.
6712 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6713 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6714 * linespec.c:
6715 (find_linespec_symbols): Replace throw_exception with throw.
6716 * infrun.c (displaced_step_prepare, resume): Replace
6717 throw_exception with throw.
6718 * infcmd.c (post_create_inferior): Replace throw_exception with
6719 throw.
6720 * inf-loop.c (inferior_event_handler): Replace throw_exception
6721 with throw.
6722 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6723 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6724 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6725 (get_prev_frame_always, get_frame_pc_if_available)
6726 (get_frame_address_in_block_if_available, get_frame_language):
6727 Replace throw_exception with throw.
6728 * frame-unwind.c (frame_unwind_try_unwinder): Replace
6729 throw_exception with throw.
6730 * eval.c (fetch_subexp_value, evaluate_var_value)
6731 (evaluate_funcall, evaluate_subexp_standard): Replace
6732 throw_exception with throw.
6733 * dwarf2loc.c (call_site_find_chain)
6734 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6735 Replace throw_exception with throw.
6736 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6737 with throw.
6738 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6739 throw.
6740 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6741 * completer.c (complete_line_internal): Replace throw_exception
6742 with throw.
6743 * compile/compile-object-run.c (compile_object_run): Replace
6744 throw_exception with throw.
6745 * cli/cli-script.c (process_next_line): Replace throw_exception
6746 with throw.
6747 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6748 (btrace_enable, btrace_maint_update_pt_packets): Replace
6749 throw_exception with throw.
6750 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6751 throw_exception with throw.
6752 * break-catch-throw.c (re_set_exception_catchpoint): Replace
6753 throw_exception with throw.
6754 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6755 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6756 * aarch64-tdep.c (aarch64_make_prologue_cache)
6757 (aarch64_make_stub_cache): Replace throw_exception with throw.
6758
26003a20
TT
67592019-04-08 Tom Tromey <tom@tromey.com>
6760
6761 * common/common-exceptions.c (throw_exception): Rename from
6762 throw_exception_cxx. Remove old copy. Make argument const.
6763 (throw_it): Create and throw exception objects directly.
6764 * common/common-exceptions.h (throw_exception): Make argument
6765 const.
6766 (struct gdb_exception_error): Add constructor.
6767 (struct gdb_exception_quit): Add constructor.
6768
d272eb37
TT
67692019-04-08 Tom Tromey <tom@tromey.com>
6770
6771 * common/common-exceptions.h (exception_rethrow): Don't declare.
6772 (TRY_SJLJ): Update comment.
6773 (TRY, CATCH, END_CATCH): Remove.
6774 * common/common-exceptions.c (exception_rethrow): Remove.
6775
230d2906
TT
67762019-04-08 Tom Tromey <tom@tromey.com>
6777
6778 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6779 Remove.
6780 (gdb_exception_error): Rename from
6781 gdb_exception_RETURN_MASK_ERROR.
6782 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6783 (gdb_quit_bad_alloc): Update.
6784 * aarch64-tdep.c: Update.
6785 * ada-lang.c: Update.
6786 * ada-typeprint.c: Update.
6787 * ada-valprint.c: Update.
6788 * amd64-tdep.c: Update.
6789 * arch-utils.c: Update.
6790 * break-catch-throw.c: Update.
6791 * breakpoint.c: Update.
6792 * btrace.c: Update.
6793 * c-varobj.c: Update.
6794 * cli/cli-cmds.c: Update.
6795 * cli/cli-interp.c: Update.
6796 * cli/cli-script.c: Update.
6797 * common/common-exceptions.c: Update.
6798 * common/new-op.c: Update.
6799 * common/selftest.c: Update.
6800 * compile/compile-c-symbols.c: Update.
6801 * compile/compile-cplus-symbols.c: Update.
6802 * compile/compile-object-load.c: Update.
6803 * compile/compile-object-run.c: Update.
6804 * completer.c: Update.
6805 * corelow.c: Update.
6806 * cp-abi.c: Update.
6807 * cp-support.c: Update.
6808 * cp-valprint.c: Update.
6809 * darwin-nat.c: Update.
6810 * disasm-selftests.c: Update.
6811 * dtrace-probe.c: Update.
6812 * dwarf-index-cache.c: Update.
6813 * dwarf-index-write.c: Update.
6814 * dwarf2-frame-tailcall.c: Update.
6815 * dwarf2-frame.c: Update.
6816 * dwarf2loc.c: Update.
6817 * dwarf2read.c: Update.
6818 * eval.c: Update.
6819 * event-loop.c: Update.
6820 * event-top.c: Update.
6821 * exec.c: Update.
6822 * f-valprint.c: Update.
6823 * fbsd-tdep.c: Update.
6824 * frame-unwind.c: Update.
6825 * frame.c: Update.
6826 * gdbtypes.c: Update.
6827 * gnu-v3-abi.c: Update.
6828 * guile/guile-internal.h: Update.
6829 * guile/scm-block.c: Update.
6830 * guile/scm-breakpoint.c: Update.
6831 * guile/scm-cmd.c: Update.
6832 * guile/scm-disasm.c: Update.
6833 * guile/scm-frame.c: Update.
6834 * guile/scm-lazy-string.c: Update.
6835 * guile/scm-math.c: Update.
6836 * guile/scm-param.c: Update.
6837 * guile/scm-ports.c: Update.
6838 * guile/scm-pretty-print.c: Update.
6839 * guile/scm-symbol.c: Update.
6840 * guile/scm-symtab.c: Update.
6841 * guile/scm-type.c: Update.
6842 * guile/scm-value.c: Update.
6843 * i386-linux-tdep.c: Update.
6844 * i386-tdep.c: Update.
6845 * inf-loop.c: Update.
6846 * infcall.c: Update.
6847 * infcmd.c: Update.
6848 * infrun.c: Update.
6849 * jit.c: Update.
6850 * language.c: Update.
6851 * linespec.c: Update.
6852 * linux-fork.c: Update.
6853 * linux-nat.c: Update.
6854 * linux-tdep.c: Update.
6855 * linux-thread-db.c: Update.
6856 * main.c: Update.
6857 * mi/mi-cmd-break.c: Update.
6858 * mi/mi-cmd-stack.c: Update.
6859 * mi/mi-interp.c: Update.
6860 * mi/mi-main.c: Update.
6861 * objc-lang.c: Update.
6862 * p-valprint.c: Update.
6863 * parse.c: Update.
6864 * ppc-linux-tdep.c: Update.
6865 * printcmd.c: Update.
6866 * python/py-arch.c: Update.
6867 * python/py-breakpoint.c: Update.
6868 * python/py-cmd.c: Update.
6869 * python/py-finishbreakpoint.c: Update.
6870 * python/py-frame.c: Update.
6871 * python/py-framefilter.c: Update.
6872 * python/py-gdb-readline.c: Update.
6873 * python/py-inferior.c: Update.
6874 * python/py-infthread.c: Update.
6875 * python/py-lazy-string.c: Update.
6876 * python/py-linetable.c: Update.
6877 * python/py-objfile.c: Update.
6878 * python/py-param.c: Update.
6879 * python/py-prettyprint.c: Update.
6880 * python/py-progspace.c: Update.
6881 * python/py-record-btrace.c: Update.
6882 * python/py-record.c: Update.
6883 * python/py-symbol.c: Update.
6884 * python/py-type.c: Update.
6885 * python/py-unwind.c: Update.
6886 * python/py-utils.c: Update.
6887 * python/py-value.c: Update.
6888 * python/python.c: Update.
6889 * record-btrace.c: Update.
6890 * record-full.c: Update.
6891 * remote-fileio.c: Update.
6892 * remote.c: Update.
6893 * riscv-tdep.c: Update.
6894 * rs6000-aix-tdep.c: Update.
6895 * rs6000-tdep.c: Update.
6896 * rust-exp.y: Update.
6897 * rust-lang.c: Update.
6898 * s390-tdep.c: Update.
6899 * selftest-arch.c: Update.
6900 * solib-dsbt.c: Update.
6901 * solib-frv.c: Update.
6902 * solib-spu.c: Update.
6903 * solib-svr4.c: Update.
6904 * solib.c: Update.
6905 * sparc64-linux-tdep.c: Update.
6906 * stack.c: Update.
6907 * symfile-mem.c: Update.
6908 * symmisc.c: Update.
6909 * target.c: Update.
6910 * thread.c: Update.
6911 * top.c: Update.
6912 * tracefile-tfile.c: Update.
6913 * tui/tui.c: Update.
6914 * typeprint.c: Update.
6915 * unittests/cli-utils-selftests.c: Update.
6916 * unittests/parse-connection-spec-selftests.c: Update.
6917 * valops.c: Update.
6918 * valprint.c: Update.
6919 * value.c: Update.
6920 * varobj.c: Update.
6921 * windows-nat.c: Update.
6922 * x86-linux-nat.c: Update.
6923 * xml-support.c: Update.
6924
a70b8144
TT
69252019-04-08 Tom Tromey <tom@tromey.com>
6926
6927 * xml-support.c: Use C++ exception handling.
6928 * x86-linux-nat.c: Use C++ exception handling.
6929 * windows-nat.c: Use C++ exception handling.
6930 * varobj.c: Use C++ exception handling.
6931 * value.c: Use C++ exception handling.
6932 * valprint.c: Use C++ exception handling.
6933 * valops.c: Use C++ exception handling.
6934 * unittests/parse-connection-spec-selftests.c: Use C++ exception
6935 handling.
6936 * unittests/cli-utils-selftests.c: Use C++ exception handling.
6937 * typeprint.c: Use C++ exception handling.
6938 * tui/tui.c: Use C++ exception handling.
6939 * tracefile-tfile.c: Use C++ exception handling.
6940 * top.c: Use C++ exception handling.
6941 * thread.c: Use C++ exception handling.
6942 * target.c: Use C++ exception handling.
6943 * symmisc.c: Use C++ exception handling.
6944 * symfile-mem.c: Use C++ exception handling.
6945 * stack.c: Use C++ exception handling.
6946 * sparc64-linux-tdep.c: Use C++ exception handling.
6947 * solib.c: Use C++ exception handling.
6948 * solib-svr4.c: Use C++ exception handling.
6949 * solib-spu.c: Use C++ exception handling.
6950 * solib-frv.c: Use C++ exception handling.
6951 * solib-dsbt.c: Use C++ exception handling.
6952 * selftest-arch.c: Use C++ exception handling.
6953 * s390-tdep.c: Use C++ exception handling.
6954 * rust-lang.c: Use C++ exception handling.
6955 * rust-exp.y: Use C++ exception handling.
6956 * rs6000-tdep.c: Use C++ exception handling.
6957 * rs6000-aix-tdep.c: Use C++ exception handling.
6958 * riscv-tdep.c: Use C++ exception handling.
6959 * remote.c: Use C++ exception handling.
6960 * remote-fileio.c: Use C++ exception handling.
6961 * record-full.c: Use C++ exception handling.
6962 * record-btrace.c: Use C++ exception handling.
6963 * python/python.c: Use C++ exception handling.
6964 * python/py-value.c: Use C++ exception handling.
6965 * python/py-utils.c: Use C++ exception handling.
6966 * python/py-unwind.c: Use C++ exception handling.
6967 * python/py-type.c: Use C++ exception handling.
6968 * python/py-symbol.c: Use C++ exception handling.
6969 * python/py-record.c: Use C++ exception handling.
6970 * python/py-record-btrace.c: Use C++ exception handling.
6971 * python/py-progspace.c: Use C++ exception handling.
6972 * python/py-prettyprint.c: Use C++ exception handling.
6973 * python/py-param.c: Use C++ exception handling.
6974 * python/py-objfile.c: Use C++ exception handling.
6975 * python/py-linetable.c: Use C++ exception handling.
6976 * python/py-lazy-string.c: Use C++ exception handling.
6977 * python/py-infthread.c: Use C++ exception handling.
6978 * python/py-inferior.c: Use C++ exception handling.
6979 * python/py-gdb-readline.c: Use C++ exception handling.
6980 * python/py-framefilter.c: Use C++ exception handling.
6981 * python/py-frame.c: Use C++ exception handling.
6982 * python/py-finishbreakpoint.c: Use C++ exception handling.
6983 * python/py-cmd.c: Use C++ exception handling.
6984 * python/py-breakpoint.c: Use C++ exception handling.
6985 * python/py-arch.c: Use C++ exception handling.
6986 * printcmd.c: Use C++ exception handling.
6987 * ppc-linux-tdep.c: Use C++ exception handling.
6988 * parse.c: Use C++ exception handling.
6989 * p-valprint.c: Use C++ exception handling.
6990 * objc-lang.c: Use C++ exception handling.
6991 * mi/mi-main.c: Use C++ exception handling.
6992 * mi/mi-interp.c: Use C++ exception handling.
6993 * mi/mi-cmd-stack.c: Use C++ exception handling.
6994 * mi/mi-cmd-break.c: Use C++ exception handling.
6995 * main.c: Use C++ exception handling.
6996 * linux-thread-db.c: Use C++ exception handling.
6997 * linux-tdep.c: Use C++ exception handling.
6998 * linux-nat.c: Use C++ exception handling.
6999 * linux-fork.c: Use C++ exception handling.
7000 * linespec.c: Use C++ exception handling.
7001 * language.c: Use C++ exception handling.
7002 * jit.c: Use C++ exception handling.
7003 * infrun.c: Use C++ exception handling.
7004 * infcmd.c: Use C++ exception handling.
7005 * infcall.c: Use C++ exception handling.
7006 * inf-loop.c: Use C++ exception handling.
7007 * i386-tdep.c: Use C++ exception handling.
7008 * i386-linux-tdep.c: Use C++ exception handling.
7009 * guile/scm-value.c: Use C++ exception handling.
7010 * guile/scm-type.c: Use C++ exception handling.
7011 * guile/scm-symtab.c: Use C++ exception handling.
7012 * guile/scm-symbol.c: Use C++ exception handling.
7013 * guile/scm-pretty-print.c: Use C++ exception handling.
7014 * guile/scm-ports.c: Use C++ exception handling.
7015 * guile/scm-param.c: Use C++ exception handling.
7016 * guile/scm-math.c: Use C++ exception handling.
7017 * guile/scm-lazy-string.c: Use C++ exception handling.
7018 * guile/scm-frame.c: Use C++ exception handling.
7019 * guile/scm-disasm.c: Use C++ exception handling.
7020 * guile/scm-cmd.c: Use C++ exception handling.
7021 * guile/scm-breakpoint.c: Use C++ exception handling.
7022 * guile/scm-block.c: Use C++ exception handling.
7023 * guile/guile-internal.h: Use C++ exception handling.
7024 * gnu-v3-abi.c: Use C++ exception handling.
7025 * gdbtypes.c: Use C++ exception handling.
7026 * frame.c: Use C++ exception handling.
7027 * frame-unwind.c: Use C++ exception handling.
7028 * fbsd-tdep.c: Use C++ exception handling.
7029 * f-valprint.c: Use C++ exception handling.
7030 * exec.c: Use C++ exception handling.
7031 * event-top.c: Use C++ exception handling.
7032 * event-loop.c: Use C++ exception handling.
7033 * eval.c: Use C++ exception handling.
7034 * dwarf2read.c: Use C++ exception handling.
7035 * dwarf2loc.c: Use C++ exception handling.
7036 * dwarf2-frame.c: Use C++ exception handling.
7037 * dwarf2-frame-tailcall.c: Use C++ exception handling.
7038 * dwarf-index-write.c: Use C++ exception handling.
7039 * dwarf-index-cache.c: Use C++ exception handling.
7040 * dtrace-probe.c: Use C++ exception handling.
7041 * disasm-selftests.c: Use C++ exception handling.
7042 * darwin-nat.c: Use C++ exception handling.
7043 * cp-valprint.c: Use C++ exception handling.
7044 * cp-support.c: Use C++ exception handling.
7045 * cp-abi.c: Use C++ exception handling.
7046 * corelow.c: Use C++ exception handling.
7047 * completer.c: Use C++ exception handling.
7048 * compile/compile-object-run.c: Use C++ exception handling.
7049 * compile/compile-object-load.c: Use C++ exception handling.
7050 * compile/compile-cplus-symbols.c: Use C++ exception handling.
7051 * compile/compile-c-symbols.c: Use C++ exception handling.
7052 * common/selftest.c: Use C++ exception handling.
7053 * common/new-op.c: Use C++ exception handling.
7054 * cli/cli-script.c: Use C++ exception handling.
7055 * cli/cli-interp.c: Use C++ exception handling.
7056 * cli/cli-cmds.c: Use C++ exception handling.
7057 * c-varobj.c: Use C++ exception handling.
7058 * btrace.c: Use C++ exception handling.
7059 * breakpoint.c: Use C++ exception handling.
7060 * break-catch-throw.c: Use C++ exception handling.
7061 * arch-utils.c: Use C++ exception handling.
7062 * amd64-tdep.c: Use C++ exception handling.
7063 * ada-valprint.c: Use C++ exception handling.
7064 * ada-typeprint.c: Use C++ exception handling.
7065 * ada-lang.c: Use C++ exception handling.
7066 * aarch64-tdep.c: Use C++ exception handling.
7067
3d6e9d23
TT
70682019-04-08 Tom Tromey <tom@tromey.com>
7069
7070 * xml-support.c (gdb_xml_parser::parse): Update.
7071 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7072 * value.c (show_convenience): Update.
7073 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7074 (test_parse_flags_qcs): Update.
7075 * thread.c (thr_try_catch_cmd): Update.
7076 * target.c (target_translate_tls_address): Update.
7077 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7078 (info_frame_command_core, frame_apply_command_count): Update.
7079 * rust-exp.y (rust_lex_exception_test): Update.
7080 * riscv-tdep.c (riscv_print_one_register_info): Update.
7081 * remote.c (remote_target::enable_btrace): Update.
7082 * record-btrace.c (record_btrace_enable_warn): Update.
7083 * python/py-utils.c (gdbpy_convert_exception): Update.
7084 * printcmd.c (do_one_display, print_variable_and_value): Update.
7085 * mi/mi-main.c (mi_print_exception): Update.
7086 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7087 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7088 * linux-nat.c (linux_nat_target::attach): Update.
7089 * linux-fork.c (class scoped_switch_fork_info): Update.
7090 * infrun.c (displaced_step_prepare): Update.
7091 * infcall.c (call_function_by_hand_dummy): Update.
7092 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7093 * gnu-v3-abi.c (print_one_vtable): Update.
7094 * frame.c (get_prev_frame_always): Update.
7095 * f-valprint.c (info_common_command_for_block): Update.
7096 * exec.c (try_open_exec_file): Update.
7097 * exceptions.c (print_exception, exception_print)
7098 (exception_fprintf, exception_print_same): Update.
7099 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7100 * dwarf-index-cache.c (index_cache::store)
7101 (index_cache::lookup_gdb_index): Update.
7102 * darwin-nat.c (maybe_cache_shell): Update.
7103 * cp-valprint.c (cp_print_value_fields): Update.
7104 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7105 (gcc_cplus_symbol_address): Update.
7106 * compile/compile-c-symbols.c (gcc_convert_symbol)
7107 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7108 * common/selftest.c: Update.
7109 * common/common-exceptions.h (struct gdb_exception) <message>: Now
7110 a std::string.
7111 (exception_try_scope_entry, exception_try_scope_exit): Don't
7112 declare.
7113 (struct exception_try_scope): Remove.
7114 (TRY): Don't use exception_try_scope.
7115 (struct gdb_exception): Add constructor, operator=.
7116 <what>: New method.
7117 (struct gdb_exception_RETURN_MASK_ALL)
7118 (struct gdb_exception_RETURN_MASK_ERROR)
7119 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7120 (struct gdb_quit_bad_alloc): Update.
7121 * common/common-exceptions.c (exception_none): Change
7122 initializer.
7123 (struct catcher) <state, exception>: Initialize inline.
7124 <prev>: Remove member.
7125 (current_catcher): Remove.
7126 (catchers): New global.
7127 (exceptions_state_mc_init): Simplify.
7128 (catcher_pop): Remove.
7129 (exceptions_state_mc, exceptions_state_mc_catch): Update.
7130 (try_scope_depth, exception_try_scope_entry)
7131 (exception_try_scope_exit): Remove.
7132 (throw_exception_sjlj): Update.
7133 (exception_messages, exception_messages_size): Remove.
7134 (throw_it): Simplify.
7135 (gdb_exception_sliced_copy): Remove.
7136 (throw_exception_cxx): Update.
7137 * cli/cli-script.c (script_from_file): Update.
7138 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7139 Update.
7140 * ada-valprint.c (ada_val_print): Update.
7141 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7142 (create_excep_cond_exprs): Update.
7143
c5c10118
TT
71442019-04-08 Tom Tromey <tom@tromey.com>
7145
7146 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7147 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7148 (TRY, CATCH, END_CATCH): Remove some definitions.
7149 * common/common-exceptions.c: Don't use GDB_XCPT.
7150 (catcher_list_size): Remove.
7151 (throw_exception, throw_it): Simplify.
7152
4de283e4
TT
71532019-04-05 Tom Tromey <tom@tromey.com>
7154
7155 Revert the header-sorting patch.
7156 * ft32-tdep.c: Revert.
7157 * frv-tdep.c: Revert.
7158 * frv-linux-tdep.c: Revert.
7159 * frame.c: Revert.
7160 * frame-unwind.c: Revert.
7161 * frame-base.c: Revert.
7162 * fork-child.c: Revert.
7163 * findvar.c: Revert.
7164 * findcmd.c: Revert.
7165 * filesystem.c: Revert.
7166 * filename-seen-cache.h: Revert.
7167 * filename-seen-cache.c: Revert.
7168 * fbsd-tdep.c: Revert.
7169 * fbsd-nat.h: Revert.
7170 * fbsd-nat.c: Revert.
7171 * f-valprint.c: Revert.
7172 * f-typeprint.c: Revert.
7173 * f-lang.c: Revert.
7174 * extension.h: Revert.
7175 * extension.c: Revert.
7176 * extension-priv.h: Revert.
7177 * expprint.c: Revert.
7178 * exec.h: Revert.
7179 * exec.c: Revert.
7180 * exceptions.c: Revert.
7181 * event-top.c: Revert.
7182 * event-loop.c: Revert.
7183 * eval.c: Revert.
7184 * elfread.c: Revert.
7185 * dwarf2read.h: Revert.
7186 * dwarf2read.c: Revert.
7187 * dwarf2loc.c: Revert.
7188 * dwarf2expr.h: Revert.
7189 * dwarf2expr.c: Revert.
7190 * dwarf2-frame.c: Revert.
7191 * dwarf2-frame-tailcall.c: Revert.
7192 * dwarf-index-write.h: Revert.
7193 * dwarf-index-write.c: Revert.
7194 * dwarf-index-common.c: Revert.
7195 * dwarf-index-cache.h: Revert.
7196 * dwarf-index-cache.c: Revert.
7197 * dummy-frame.c: Revert.
7198 * dtrace-probe.c: Revert.
7199 * disasm.h: Revert.
7200 * disasm.c: Revert.
7201 * disasm-selftests.c: Revert.
7202 * dictionary.c: Revert.
7203 * dicos-tdep.c: Revert.
7204 * demangle.c: Revert.
7205 * dcache.h: Revert.
7206 * dcache.c: Revert.
7207 * darwin-nat.h: Revert.
7208 * darwin-nat.c: Revert.
7209 * darwin-nat-info.c: Revert.
7210 * d-valprint.c: Revert.
7211 * d-namespace.c: Revert.
7212 * d-lang.c: Revert.
7213 * ctf.c: Revert.
7214 * csky-tdep.c: Revert.
7215 * csky-linux-tdep.c: Revert.
7216 * cris-tdep.c: Revert.
7217 * cris-linux-tdep.c: Revert.
7218 * cp-valprint.c: Revert.
7219 * cp-support.c: Revert.
7220 * cp-namespace.c: Revert.
7221 * cp-abi.c: Revert.
7222 * corelow.c: Revert.
7223 * corefile.c: Revert.
7224 * continuations.c: Revert.
7225 * completer.h: Revert.
7226 * completer.c: Revert.
7227 * complaints.c: Revert.
7228 * coffread.c: Revert.
7229 * coff-pe-read.c: Revert.
7230 * cli-out.h: Revert.
7231 * cli-out.c: Revert.
7232 * charset.c: Revert.
7233 * c-varobj.c: Revert.
7234 * c-valprint.c: Revert.
7235 * c-typeprint.c: Revert.
7236 * c-lang.c: Revert.
7237 * buildsym.c: Revert.
7238 * buildsym-legacy.c: Revert.
7239 * build-id.h: Revert.
7240 * build-id.c: Revert.
7241 * btrace.c: Revert.
7242 * bsd-uthread.c: Revert.
7243 * breakpoint.h: Revert.
7244 * breakpoint.c: Revert.
7245 * break-catch-throw.c: Revert.
7246 * break-catch-syscall.c: Revert.
7247 * break-catch-sig.c: Revert.
7248 * blockframe.c: Revert.
7249 * block.c: Revert.
7250 * bfin-tdep.c: Revert.
7251 * bfin-linux-tdep.c: Revert.
7252 * bfd-target.c: Revert.
7253 * bcache.c: Revert.
7254 * ax-general.c: Revert.
7255 * ax-gdb.h: Revert.
7256 * ax-gdb.c: Revert.
7257 * avr-tdep.c: Revert.
7258 * auxv.c: Revert.
7259 * auto-load.c: Revert.
7260 * arm-wince-tdep.c: Revert.
7261 * arm-tdep.c: Revert.
7262 * arm-symbian-tdep.c: Revert.
7263 * arm-pikeos-tdep.c: Revert.
7264 * arm-obsd-tdep.c: Revert.
7265 * arm-nbsd-tdep.c: Revert.
7266 * arm-nbsd-nat.c: Revert.
7267 * arm-linux-tdep.c: Revert.
7268 * arm-linux-nat.c: Revert.
7269 * arm-fbsd-tdep.c: Revert.
7270 * arm-fbsd-nat.c: Revert.
7271 * arm-bsd-tdep.c: Revert.
7272 * arch-utils.c: Revert.
7273 * arc-tdep.c: Revert.
7274 * arc-newlib-tdep.c: Revert.
7275 * annotate.h: Revert.
7276 * annotate.c: Revert.
7277 * amd64-windows-tdep.c: Revert.
7278 * amd64-windows-nat.c: Revert.
7279 * amd64-tdep.c: Revert.
7280 * amd64-sol2-tdep.c: Revert.
7281 * amd64-obsd-tdep.c: Revert.
7282 * amd64-obsd-nat.c: Revert.
7283 * amd64-nbsd-tdep.c: Revert.
7284 * amd64-nbsd-nat.c: Revert.
7285 * amd64-nat.c: Revert.
7286 * amd64-linux-tdep.c: Revert.
7287 * amd64-linux-nat.c: Revert.
7288 * amd64-fbsd-tdep.c: Revert.
7289 * amd64-fbsd-nat.c: Revert.
7290 * amd64-dicos-tdep.c: Revert.
7291 * amd64-darwin-tdep.c: Revert.
7292 * amd64-bsd-nat.c: Revert.
7293 * alpha-tdep.c: Revert.
7294 * alpha-obsd-tdep.c: Revert.
7295 * alpha-nbsd-tdep.c: Revert.
7296 * alpha-mdebug-tdep.c: Revert.
7297 * alpha-linux-tdep.c: Revert.
7298 * alpha-linux-nat.c: Revert.
7299 * alpha-bsd-tdep.c: Revert.
7300 * alpha-bsd-nat.c: Revert.
7301 * aix-thread.c: Revert.
7302 * agent.c: Revert.
7303 * addrmap.c: Revert.
7304 * ada-varobj.c: Revert.
7305 * ada-valprint.c: Revert.
7306 * ada-typeprint.c: Revert.
7307 * ada-tasks.c: Revert.
7308 * ada-lang.c: Revert.
7309 * aarch64-tdep.c: Revert.
7310 * aarch64-ravenscar-thread.c: Revert.
7311 * aarch64-newlib-tdep.c: Revert.
7312 * aarch64-linux-tdep.c: Revert.
7313 * aarch64-linux-nat.c: Revert.
7314 * aarch64-fbsd-tdep.c: Revert.
7315 * aarch64-fbsd-nat.c: Revert.
7316 * aarch32-linux-nat.c: Revert.
7317
d55e5aa6
TT
73182019-04-05 Tom Tromey <tom@tromey.com>
7319
7320 * ft32-tdep.c: Sort headers.
7321 * frv-tdep.c: Sort headers.
7322 * frv-linux-tdep.c: Sort headers.
7323 * frame.c: Sort headers.
7324 * frame-unwind.c: Sort headers.
7325 * frame-base.c: Sort headers.
7326 * fork-child.c: Sort headers.
7327 * findvar.c: Sort headers.
7328 * findcmd.c: Sort headers.
7329 * filesystem.c: Sort headers.
7330 * filename-seen-cache.h: Sort headers.
7331 * filename-seen-cache.c: Sort headers.
7332 * fbsd-tdep.c: Sort headers.
7333 * fbsd-nat.h: Sort headers.
7334 * fbsd-nat.c: Sort headers.
7335 * f-valprint.c: Sort headers.
7336 * f-typeprint.c: Sort headers.
7337 * f-lang.c: Sort headers.
7338 * extension.h: Sort headers.
7339 * extension.c: Sort headers.
7340 * extension-priv.h: Sort headers.
7341 * expprint.c: Sort headers.
7342 * exec.h: Sort headers.
7343 * exec.c: Sort headers.
7344 * exceptions.c: Sort headers.
7345 * event-top.c: Sort headers.
7346 * event-loop.c: Sort headers.
7347 * eval.c: Sort headers.
7348 * elfread.c: Sort headers.
7349 * dwarf2read.h: Sort headers.
7350 * dwarf2read.c: Sort headers.
7351 * dwarf2loc.c: Sort headers.
7352 * dwarf2expr.h: Sort headers.
7353 * dwarf2expr.c: Sort headers.
7354 * dwarf2-frame.c: Sort headers.
7355 * dwarf2-frame-tailcall.c: Sort headers.
7356 * dwarf-index-write.h: Sort headers.
7357 * dwarf-index-write.c: Sort headers.
7358 * dwarf-index-common.c: Sort headers.
7359 * dwarf-index-cache.h: Sort headers.
7360 * dwarf-index-cache.c: Sort headers.
7361 * dummy-frame.c: Sort headers.
7362 * dtrace-probe.c: Sort headers.
7363 * disasm.h: Sort headers.
7364 * disasm.c: Sort headers.
7365 * disasm-selftests.c: Sort headers.
7366 * dictionary.c: Sort headers.
7367 * dicos-tdep.c: Sort headers.
7368 * demangle.c: Sort headers.
7369 * dcache.h: Sort headers.
7370 * dcache.c: Sort headers.
7371 * darwin-nat.h: Sort headers.
7372 * darwin-nat.c: Sort headers.
7373 * darwin-nat-info.c: Sort headers.
7374 * d-valprint.c: Sort headers.
7375 * d-namespace.c: Sort headers.
7376 * d-lang.c: Sort headers.
7377 * ctf.c: Sort headers.
7378 * csky-tdep.c: Sort headers.
7379 * csky-linux-tdep.c: Sort headers.
7380 * cris-tdep.c: Sort headers.
7381 * cris-linux-tdep.c: Sort headers.
7382 * cp-valprint.c: Sort headers.
7383 * cp-support.c: Sort headers.
7384 * cp-namespace.c: Sort headers.
7385 * cp-abi.c: Sort headers.
7386 * corelow.c: Sort headers.
7387 * corefile.c: Sort headers.
7388 * continuations.c: Sort headers.
7389 * completer.h: Sort headers.
7390 * completer.c: Sort headers.
7391 * complaints.c: Sort headers.
7392 * coffread.c: Sort headers.
7393 * coff-pe-read.c: Sort headers.
7394 * cli-out.h: Sort headers.
7395 * cli-out.c: Sort headers.
7396 * charset.c: Sort headers.
7397 * c-varobj.c: Sort headers.
7398 * c-valprint.c: Sort headers.
7399 * c-typeprint.c: Sort headers.
7400 * c-lang.c: Sort headers.
7401 * buildsym.c: Sort headers.
7402 * buildsym-legacy.c: Sort headers.
7403 * build-id.h: Sort headers.
7404 * build-id.c: Sort headers.
7405 * btrace.c: Sort headers.
7406 * bsd-uthread.c: Sort headers.
7407 * breakpoint.h: Sort headers.
7408 * breakpoint.c: Sort headers.
7409 * break-catch-throw.c: Sort headers.
7410 * break-catch-syscall.c: Sort headers.
7411 * break-catch-sig.c: Sort headers.
7412 * blockframe.c: Sort headers.
7413 * block.c: Sort headers.
7414 * bfin-tdep.c: Sort headers.
7415 * bfin-linux-tdep.c: Sort headers.
7416 * bfd-target.c: Sort headers.
7417 * bcache.c: Sort headers.
7418 * ax-general.c: Sort headers.
7419 * ax-gdb.h: Sort headers.
7420 * ax-gdb.c: Sort headers.
7421 * avr-tdep.c: Sort headers.
7422 * auxv.c: Sort headers.
7423 * auto-load.c: Sort headers.
7424 * arm-wince-tdep.c: Sort headers.
7425 * arm-tdep.c: Sort headers.
7426 * arm-symbian-tdep.c: Sort headers.
7427 * arm-pikeos-tdep.c: Sort headers.
7428 * arm-obsd-tdep.c: Sort headers.
7429 * arm-nbsd-tdep.c: Sort headers.
7430 * arm-nbsd-nat.c: Sort headers.
7431 * arm-linux-tdep.c: Sort headers.
7432 * arm-linux-nat.c: Sort headers.
7433 * arm-fbsd-tdep.c: Sort headers.
7434 * arm-fbsd-nat.c: Sort headers.
7435 * arm-bsd-tdep.c: Sort headers.
7436 * arch-utils.c: Sort headers.
7437 * arc-tdep.c: Sort headers.
7438 * arc-newlib-tdep.c: Sort headers.
7439 * annotate.h: Sort headers.
7440 * annotate.c: Sort headers.
7441 * amd64-windows-tdep.c: Sort headers.
7442 * amd64-windows-nat.c: Sort headers.
7443 * amd64-tdep.c: Sort headers.
7444 * amd64-sol2-tdep.c: Sort headers.
7445 * amd64-obsd-tdep.c: Sort headers.
7446 * amd64-obsd-nat.c: Sort headers.
7447 * amd64-nbsd-tdep.c: Sort headers.
7448 * amd64-nbsd-nat.c: Sort headers.
7449 * amd64-nat.c: Sort headers.
7450 * amd64-linux-tdep.c: Sort headers.
7451 * amd64-linux-nat.c: Sort headers.
7452 * amd64-fbsd-tdep.c: Sort headers.
7453 * amd64-fbsd-nat.c: Sort headers.
7454 * amd64-dicos-tdep.c: Sort headers.
7455 * amd64-darwin-tdep.c: Sort headers.
7456 * amd64-bsd-nat.c: Sort headers.
7457 * alpha-tdep.c: Sort headers.
7458 * alpha-obsd-tdep.c: Sort headers.
7459 * alpha-nbsd-tdep.c: Sort headers.
7460 * alpha-mdebug-tdep.c: Sort headers.
7461 * alpha-linux-tdep.c: Sort headers.
7462 * alpha-linux-nat.c: Sort headers.
7463 * alpha-bsd-tdep.c: Sort headers.
7464 * alpha-bsd-nat.c: Sort headers.
7465 * aix-thread.c: Sort headers.
7466 * agent.c: Sort headers.
7467 * addrmap.c: Sort headers.
7468 * ada-varobj.c: Sort headers.
7469 * ada-valprint.c: Sort headers.
7470 * ada-typeprint.c: Sort headers.
7471 * ada-tasks.c: Sort headers.
7472 * ada-lang.c: Sort headers.
7473 * aarch64-tdep.c: Sort headers.
7474 * aarch64-ravenscar-thread.c: Sort headers.
7475 * aarch64-newlib-tdep.c: Sort headers.
7476 * aarch64-linux-tdep.c: Sort headers.
7477 * aarch64-linux-nat.c: Sort headers.
7478 * aarch64-fbsd-tdep.c: Sort headers.
7479 * aarch64-fbsd-nat.c: Sort headers.
7480 * aarch32-linux-nat.c: Sort headers.
7481
699bd4cf
TT
74822019-04-04 Tom Tromey <tom@tromey.com>
7483
7484 * varobj.c (varobj_create): Update.
7485 * rust-exp.y (struct rust_parser) <update_innermost_block,
7486 lookup_symbol>: New methods.
7487 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7488 Rename.
7489 (rust_parser::rust_lookup_type)
7490 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7491 * printcmd.c (display_command, do_one_display): Update.
7492 * parser-defs.h (struct parser_state) <parser_state>: Add
7493 "tracker" parameter.
7494 (block_tracker): New member.
7495 (class innermost_block_tracker) <innermost_block_tracker>: Add
7496 "types" parameter.
7497 <reset>: Remove method.
7498 (innermost_block): Don't declare.
7499 (null_post_parser): Update.
7500 * parse.c (innermost_block): Remove global.
7501 (write_dollar_variable): Update.
7502 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7503 Remove "tracker_types" parameter.
7504 (parse_expression): Add "tracker" parameter.
7505 (parse_expression_for_completion): Update.
7506 (null_post_parser): Add "tracker" parameter.
7507 * p-exp.y: Update rules.
7508 * m2-exp.y: Update rules.
7509 * language.h (struct language_defn) <la_post_parser>: Add
7510 "tracker" parameter.
7511 * go-exp.y: Update rules.
7512 * f-exp.y: Update rules.
7513 * expression.h (parse_expression, parse_exp_1): Add "tracker"
7514 parameter.
7515 * d-exp.y: Update rules.
7516 * c-exp.y: Update rules.
7517 * breakpoint.c (set_breakpoint_condition): Create an
7518 innermost_block_tracker.
7519 (watch_command_1): Likewise.
7520 * ada-lang.c (resolve): Add "tracker" parameter.
7521 (resolve_subexp): Likewise.
7522 * ada-exp.y (write_var_from_sym): Update.
7523
dac43e32
TT
75242019-04-04 Tom Tromey <tom@tromey.com>
7525
7526 * type-stack.h: New file.
7527 * type-stack.c: New file.
7528 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7529 type-stack.h.
7530 (insert_into_type_stack, insert_type, push_type, push_type_int)
7531 (insert_type_address_space, pop_type, pop_type_int)
7532 (pop_typelist, pop_type_stack, append_type_stack)
7533 (push_type_stack, get_type_stack, push_typelist)
7534 (follow_type_instance_flags, follow_types): Don't declare.
7535 * parse.c (type_stack): Remove global.
7536 (parse_exp_in_context): Update.
7537 (insert_into_type_stack, insert_type, push_type, push_type_int)
7538 (insert_type_address_space, pop_type, pop_type_int)
7539 (pop_typelist, pop_type_stack, append_type_stack)
7540 (push_type_stack, get_type_stack, push_typelist)
7541 (follow_type_instance_flags, follow_types): Remove (moved to
7542 type-stack.c).
7543 * f-exp.y (type_stack): New global.
7544 Update rules.
7545 (push_kind_type, f_parse): Update.
7546 * d-exp.y (type_stack): New global.
7547 Update rules.
7548 (d_parse): Update.
7549 * c-exp.y (struct c_parse_state) <type_stack>: New member.
7550 Update rules.
7551 * Makefile.in (COMMON_SFILES): Add type-stack.c.
7552 (HFILES_NO_SRCDIR): Add type-stack.h.
7553
2a612529
TT
75542019-04-04 Tom Tromey <tom@tromey.com>
7555
7556 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7557 (rust_parser::convert_ast_to_expression, rust_parse)
7558 (rust_lex_test_completion, rust_lex_tests): Update.
7559 * parser-defs.h (struct expr_completion_state): New.
7560 (struct parser_state) <parser_state>: Add completion parameter.
7561 <mark_struct_expression, mark_completion_tag>: New methods.
7562 <parse_completion, m_completion_state>: New members.
7563 (prefixify_expression, null_post_parser): Update.
7564 (mark_struct_expression, mark_completion_tag): Don't declare.
7565 * parse.c (parse_completion, expout_last_struct)
7566 (expout_tag_completion_type, expout_completion_name): Remove
7567 globals.
7568 (parser_state::mark_struct_expression)
7569 (parser_state::mark_completion_tag): Now methods.
7570 (prefixify_expression): Add last_struct parameter.
7571 (prefixify_subexp): Likewise.
7572 (parse_exp_1): Update.
7573 (parse_exp_in_context): Add cstate parameter. Update.
7574 (parse_expression_for_completion): Create an
7575 expr_completion_state.
7576 (null_post_parser): Add "completion" parameter.
7577 * p-exp.y: Update rules.
7578 (yylex): Update.
7579 * language.h (struct language_defn) <la_post_parser>: Add
7580 "completing" parameter.
7581 * go-exp.y: Update rules.
7582 (lex_one_token): Update.
7583 * expression.h (parse_completion): Don't declare.
7584 * d-exp.y: Update rules.
7585 (lex_one_token): Update rules.
7586 * c-exp.y: Update rules.
7587 (lex_one_token): Update.
7588 * ada-lang.c (resolve): Add "parse_completion" parameter.
7589 (resolve_subexp): Likewise.
7590 (ada_resolve_function): Likewise.
7591
43476f0b
TT
75922019-04-04 Tom Tromey <tom@tromey.com>
7593
7594 * parser-defs.h (struct parser_state) <start_arglist,
7595 end_arglist>: New methods.
7596 <arglist_len, m_funcall_chain>: New members.
7597 (arglist_len, start_arglist, end_arglist): Don't declare.
7598 * parse.c (arglist_len, funcall_chain): Remove global.
7599 (start_arglist, end_arglist): Remove functions.
7600 (parse_exp_in_context): Update.
7601 * p-exp.y: Update rules.
7602 * m2-exp.y: Update rules.
7603 * go-exp.y: Update rules.
7604 * f-exp.y: Update rules.
7605 * d-exp.y: Update rules.
7606 * c-exp.y: Update rules.
7607
5776fca3
TT
76082019-04-04 Tom Tromey <tom@tromey.com>
7609
7610 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7611 lex_operator, push_back>: New methods.
7612 Update all rules.
7613 (rust_parser::lex_hex, lex_escape): Rename and update.
7614 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7615 (rust_parser::lex_operator): Rename and update.
7616 (rust_parser::lex_number, rustyylex, rustyyerror)
7617 (rust_lex_test_init, rust_lex_test_sequence)
7618 (rust_lex_test_push_back, rust_lex_tests): Update.
7619 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7620 parameter.
7621 <lexptr, prev_lexptr>: New members.
7622 (lexptr, prev_lexptr): Don't declare.
7623 * parse.c (lexptr, prev_lexptr): Remove globals.
7624 (parse_exp_in_context): Update.
7625 * p-exp.y (yylex, yyerror): Update.
7626 * m2-exp.y (parse_number, yylex, yyerror): Update.
7627 * go-exp.y (lex_one_token, yyerror): Update.
7628 * f-exp.y (match_string_literal, yylex, yyerror): Update.
7629 * d-exp.y (lex_one_token, yyerror): Update.
7630 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7631 (lex_one_token, yyerror): Update.
7632 * ada-lex.l (YY_INPUT): Update.
7633 (rewind_to_char): Update.
7634 * ada-exp.y (yyerror): Update.
7635
8621b685
TT
76362019-04-04 Tom Tromey <tom@tromey.com>
7637
7638 * rust-exp.y (rustyylex, rust_lex_tests): Update.
7639 * parser-defs.h (struct parser_state) <parser_state>: Add new
7640 parameter.
7641 <comma_terminates>: New member.
7642 (comma_terminates): Don't declare global.
7643 * parse.c (comma_terminates): Remove global.
7644 (parse_exp_in_context): Update.
7645 * p-exp.y (yylex): Update.
7646 * m2-exp.y (yylex): Update.
7647 * go-exp.y (lex_one_token): Update.
7648 * f-exp.y (yylex): Update.
7649 * d-exp.y (lex_one_token): Update.
7650 * c-exp.y (lex_one_token): Update.
7651 * ada-lex.l: Update.
7652
28aaf3fd
TT
76532019-04-04 Tom Tromey <tom@tromey.com>
7654
7655 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7656 (rustyylex, rust_lex_test_init, rust_lex_test_one)
7657 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7658 * parser-defs.h (paren_depth): Don't declare.
7659 * parse.c (paren_depth): Remove global.
7660 (parse_exp_in_context): Update.
7661 * p-exp.y (paren_depth): New global.
7662 (pascal_parse): Initialize it.
7663 * m2-exp.y (paren_depth): New global.
7664 (m2_parse): Initialize it.
7665 * go-exp.y (paren_depth): New global.
7666 (go_parse): Initialize it.
7667 * f-exp.y (paren_depth): New global.
7668 (f_parse): Initialize it.
7669 * d-exp.y (paren_depth): New global.
7670 (d_parse): Initialize it.
7671 * c-exp.y (paren_depth): New global.
7672 (c_parse): Initialize it.
7673 * ada-lex.l (paren_depth): New global.
7674 (lexer_init): Initialize it.
7675
1e58a4a4
TT
76762019-04-04 Tom Tromey <tom@tromey.com>
7677
7678 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7679 (rust_parser::convert_ast_to_type)
7680 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7681 * parser-defs.h (struct parser_state) <parser_state>: Add
7682 parameters. Initialize new members.
7683 <expression_context_block, expression_context_pc>: New members.
7684 * parse.c (expression_context_block, expression_context_pc):
7685 Remove globals.
7686 (parse_exp_in_context): Update.
7687 * p-exp.y: Update all rules.
7688 (yylex): Update.
7689 * m2-exp.y: Update all rules.
7690 (yylex): Update.
7691 * go-exp.y (yylex): Update.
7692 * f-exp.y (yylex): Update.
7693 * d-exp.y: Update all rules.
7694 (yylex): Update.
7695 * c-exp.y: Update all rules.
7696 (lex_one_token, classify_name, yylex, c_parse): Update.
7697 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7698
37eedb39
TT
76992019-04-04 Tom Tromey <tom@tromey.com>
7700
7701 * gdbarch.h, gdbarch.c: Rebuild.
7702 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7703 * stap-probe.h:
7704 (struct stap_parse_info): Replace "parser_state" with
7705 "expr_builder".
7706 * parser-defs.h (struct expr_builder): Rename from "parser_state".
7707 (parser_state): New class.
7708 * parse.c (expr_builder): Rename.
7709 (expr_builder::release): Rename.
7710 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7711 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7712 (write_exp_elt_longcst, write_exp_elt_floatcst)
7713 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7714 (write_exp_string_vector, write_exp_bitstring)
7715 (write_exp_msymbol, mark_struct_expression)
7716 (write_dollar_variable)
7717 (insert_type_address_space, increase_expout_size): Replace
7718 "parser_state" with "expr_builder".
7719 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7720 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7721 "parser_state" with "expr_builder".
7722
73923d7e
TT
77232019-04-04 Tom Tromey <tom@tromey.com>
7724
7725 * rust-exp.y: Replace "parse_language" with method call.
7726 * p-exp.y:
7727 (yylex): Replace "parse_language" with method call.
7728 * m2-exp.y:
7729 (yylex): Replace "parse_language" with method call.
7730 * go-exp.y (classify_name): Replace "parse_language" with method
7731 call.
7732 * f-exp.y (yylex): Replace "parse_language" with method call.
7733 * d-exp.y (lex_one_token): Replace "parse_language" with method
7734 call.
7735 * c-exp.y:
7736 (lex_one_token, classify_name, yylex): Replace "parse_language"
7737 with method call.
7738 * ada-exp.y (find_primitive_type, type_char)
7739 (type_system_address): Replace "parse_language" with method call.
7740
fa9f5be6
TT
77412019-04-04 Tom Tromey <tom@tromey.com>
7742
7743 * rust-exp.y: Replace "parse_gdbarch" with method call.
7744 * parse.c (write_dollar_variable, insert_type_address_space):
7745 Replace "parse_gdbarch" with method call.
7746 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7747 call.
7748 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7749 call.
7750 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7751 "parse_gdbarch" with method call.
7752 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7753 with method call.
7754 * f-exp.y (parse_type, parse_f_type, yylex): Replace
7755 "parse_gdbarch" with method call.
7756 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7757 "parse_gdbarch" with method call.
7758 * c-exp.y (parse_type, parse_number, classify_name): Replace
7759 "parse_gdbarch" with method call.
7760 * ada-lex.l: Replace "parse_gdbarch" with method call.
7761 * ada-exp.y (parse_type, find_primitive_type, type_char)
7762 (type_system_address): Replace "parse_gdbarch" with method call.
7763
1201a264
TT
77642019-04-04 Tom Tromey <tom@tromey.com>
7765
7766 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7767 * stap-probe.c (stap_parse_argument): Update.
7768 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7769 initial_size parameter.
7770 * rust-exp.y (rust_lex_tests): Update.
7771 * parse.c (parser_state): Update.
7772 (parse_exp_in_context): Update.
7773 * parser-defs.h (struct parser_state) <parser_state>: Remove
7774 "initial_size" parameter.
7775
e3980ce2
TT
77762019-04-04 Tom Tromey <tom@tromey.com>
7777
7778 * parser-defs.h (increase_expout_size): Don't declare.
7779 * parse.c (increase_expout_size): Now static.
7780
e9f8e3f1
TS
77812019-04-04 Thomas Schwinge <thomas@codesourcery.com>
7782
7783 * gnu-nat.c (gnu_nat_target::wait): Fix
7784 target_waitstatus_to_string call.
7785
d7df6549
AB
77862019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7787
7788 * eval.c (evaluate_subexp_standard): Handle internal functions
7789 during Fortran function call handling.
7790
8bdc1658
AB
77912019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7792
7793 * NEWS: Mention new internal functions.
7794 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7795 (read_base_type): Use dwarf2_init_complex_target_type.
7796 * value.c (creal_internal_fn): New function.
7797 (cimag_internal_fn): New function.
7798 (_initialize_values): Register new internal functions.
7799
c29705b7
PW
78002019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7801
7802 * infrun.c (stop_all_threads): If debug_infrun, always
7803 trace the wait status after wait_one, using
7804 target_waitstatus_to_string and target_pid_to_str.
7805 (handle_inferior_event): Replace various trace of
7806 wait status kind by a single trace.
7807 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7808 wait status kind image by target_waitstatus_to_string.
7809 * target/waitstatus.c (target_waitstatus_to_string): Fix
7810 obsolete comment.
7811
05caa1d2
TT
78122019-04-01 Tom Tromey <tromey@adacore.com>
7813
7814 PR symtab/23331:
7815 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7816
9d1447e0
SDJ
78172019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
7818 Pedro Alves <palves@redhat.com>
7819
7820 * top.c (quit_force): Call 'finalize_values'.
7821 * value.c (finalize_values): New function.
7822 * value.h (finalize_values): Declare.
7823
7734102d
EZ
78242019-03-30 Eli Zaretskii <eliz@gnu.org>
7825
7826 * NEWS: Announce $_gdb_major and $_gdb_minor.
7827
7828 * top.c (init_gdb_version_vars): New function.
7829 (gdb_init): Call init_gdb_version_vars.
7830
188e1fa9
TT
78312019-03-29 Tom Tromey <tromey@adacore.com>
7832
7833 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
7834 help text. Remove dead code.
7835
2880242d
KS
78362019-03-29 Keith Seitz <keiths@redhat.com>
7837
7838 From Siddhesh Poyarekar:
7839 * f-lang.h (f77_get_upperbound): Return LONGEST.
7840 (f77_get_lowerbound): Likewise.
7841 * f-typeprint.c (f_type_print_varspec_suffix): Expand
7842 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
7843 print them.
7844 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
7845 plongest to format print it.
7846 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7847 (f77_get_upperbound): Likewise.
7848 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7849 LOWER_BOUND to LONGEST.
7850 (f77_create_arrayprint_offset_tbl): Likewise.
7851
cc1defb1
KS
78522019-03-29 Keith Seitz <keiths@redhat.com>
7853
7854 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7855 %s/pulongest for TYPE_LENGTH instead of %d in format
7856 strings.
7857 * ada-typerint.c (ada_print_type): Likewise.
7858 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7859 * compile/compile-c-support.c (generate_register_struct): Likewise.
7860 * gdbtypes.c (recursive_dump_type): Likewise.
7861 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7862 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
7863 instead of %d in format strings.
7864 * riscv-tdep.c (riscv_type_alignment): Cast second argument
7865 to std::min to ULONGEST.
7866 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7867 instead of %d in format strings.
7868 * tracepoint.c (info_scope_command): Likewise.
7869 * typeprint.c (print_offset_data::update)
7870 (print_offset_data::finish): Likewise.
7871 * xtensa-tdep.c (xtensa_store_return_value)
7872 (xtensa_push_dummy_call): Likewise.
7873
e432ccf1
JT
78742019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
7875
7876 * windows-nat.c (display_selector): Fixed format specifications
7877 for 64-bit Cygwin.
7878
65d2b333
PW
78792019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7880
7881 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7882
f489207e
SL
78832019-03-28 Sandra Loosemore <sandra@codesourcery.com>
7884
7885 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7886 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7887 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7888 (nios2_linux_init_abi): Install it.
7889
bffa1015
AH
78902019-03-28 Alan Hayward <alan.hayward@arm.com>
7891
7892 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7893
fc96163a
AH
78942019-03-28 Alan Hayward <alan.hayward@arm.com>
7895
7896 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7897
20dc7e9b
PW
78982019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7899 Tom Tromey <tromey@adacore.com>
7900
7901 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7902
7f5331a8
JB
79032019-03-26 Joel Brobecker <brobecker@adacore.com>
7904
7905 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7906 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7907 method to compute the bounds of range types. Also print "[evaluated]"
7908 if the bounds' values come from a dynamic evaluation.
7909
18c77628
AB
79102019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
7911
7912 * cp-valprint.c (cp_print_value_fields): Don't print trailing
7913 whitespace when pretty printing is on.
7914
53c973f2
AH
79152019-03-26 Alan Hayward <alan.hayward@arm.com>
7916
e79be6e5 7917 * ppc-linux-nat.c: Add include.
53c973f2 7918
d851aa71
AH
79192019-03-26 Alan Hayward <alan.hayward@arm.com>
7920
e79be6e5 7921 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 7922
2fe7bab7
AH
79232019-03-26 Alan Hayward <alan.hayward@arm.com>
7924
e79be6e5 7925 * arm-linux-nat.c: Add include.
2fe7bab7 7926
068ef30e
SM
79272019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
7928
7929 * source-cache.c (source_cache::get_source_lines): Re-read
7930 fullname after calling open_source_file.
7931
81a24d04
JB
79322019-03-25 John Baldwin <jhb@FreeBSD.org>
7933
7934 * NEWS: Mention TLS support for FreeBSD.
7935
79e7ae11
TT
79362019-03-25 Tom Tromey <tromey@adacore.com>
7937
7938 * minsyms.c (BUNCH_SIZE): Update comment.
7939 (~minimal_symbol_reader): Remove old comment.
7940 (compact_minimal_symbols): Update comment.
7941 (minimal_symbol_reader::install): Remove old comment. Update
7942 other comments.
7943
d45963c2
AH
79442019-03-25 Alan Hayward <alan.hayward@arm.com>
7945
7946 * s390-linux-nat.c: Add include.
7947
0f83012e
AH
79482019-03-25 Alan Hayward <alan.hayward@arm.com>
7949
7950 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7951 Call linux_get_hwcap.
7952 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7953 Likewise.
7954 (aarch64_linux_get_hwcap): Remove function.
7955 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7956 declaration.
7957 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7958 linux_get_hwcap.
7959 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7960 * linux-tdep.c (linux_get_hwcap): Add function.
7961 (linux_get_hwcap2): Likewise.
7962 * linux-tdep.h (linux_get_hwcap): Add declaration.
7963 (linux_get_hwcap2): Likewise.
7964 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7965 (ppc_linux_get_hwcap2): Likewise.
7966 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7967 linux_get_hwcap.
7968 (ppc_linux_nat_target::insert_watchpoint): Likewise.
7969 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7970 (ppc_linux_nat_target::read_description): Likewise.
7971 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7972 * s390-linux-nat.c: Likewise.
7973 * s390-linux-tdep.c (s390_core_read_description): Likewise.
7974
6640a367
TT
79752019-03-24 Tom Tromey <tom@tromey.com>
7976
7977 * ada-lang.c (standard_lookup): Simplify initialization.
7978 (ada_lookup_symbol_nonlocal): Simplify return.
7979 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7980 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7981 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7982 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7983 initialization.
7984 * solib.c (solib_global_lookup): Simplify.
7985 * symtab.c (null_block_symbol): Remove.
7986 (symbol_cache_lookup): Simplify returns.
7987 (lookup_language_this): Simplify returns.
7988 (lookup_symbol_aux): Simplify return.
7989 (lookup_local_symbol): Simplify returns.
7990 (lookup_global_symbol_from_objfile): Simplify return.
7991 (lookup_symbol_in_objfile_symtabs)
7992 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7993 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7994 (lookup_static_symbol, lookup_global_symbol): Simplify return.
7995 * cp-namespace.c (cp_lookup_bare_symbol)
7996 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7997 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7998 (cp_lookup_nested_symbol): Don't use null_block_symbol.
7999 (cp_lookup_symbol_via_imports): Simplify initialization.
8000 (find_symbol_in_baseclass): Likewise.
8001 * symtab.h (null_block_symbol): Remove.
8002 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8003 (d_lookup_nested_symbol, d_lookup_symbol_imports)
8004 (d_lookup_symbol_module): Likewise.
8005 (find_symbol_in_baseclass): Simplify initialization.
8006
a930ebcd
TT
80072019-03-24 Tom Tromey <tom@tromey.com>
8008
8009 * expression.h: Don't include symtab.h.
8010 (struct block): Forward declare.
8011
582942f4
TT
80122019-03-24 Tom Tromey <tom@tromey.com>
8013
8014 * c-exp.y (typebase): Remove casts.
8015 * gdbtypes.c (lookup_unsigned_typename, )
8016 (lookup_signed_typename): Remove cast.
8017 * eval.c (parse_to_comma_and_eval): Remove cast.
8018 * parse.c (write_dollar_variable): Remove cast.
8019 * block.h (struct block) <superblock>: Now const.
8020 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8021 * psymtab.c (psym_map_matching_symbols): Make "block" const.
8022 (map_block): Make "block" const.
8023 * symfile.h (struct quick_symbol_functions)
8024 <map_matching_symbols>: Constify block argument to "callback".
8025 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8026 const.
8027 (find_pc_sect_compunit_symtab): Make "b" const.
8028 (find_symbol_at_address): Likewise.
8029 (search_symbols): Likewise.
8030 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8031 (dw2_debug_names_lookup_symbol): Likewise.
8032 (dw2_map_matching_symbols): Update.
8033 * p-valprint.c (pascal_val_print): Remove "block".
8034 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8035 (aux_add_nonlocal_symbols): Make "block" const.
8036 (resolve_subexp): Remove cast.
8037 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8038 const.
8039 (iterate_over_file_blocks): Likewise.
8040 * f-exp.y (%union) <bval>: Remove.
8041 * coffread.c (patch_opaque_types): Make "b" const.
8042 * spu-tdep.c (spu_catch_start): Make "block" const.
8043 * c-valprint.c (print_unpacked_pointer): Remove "block".
8044 * symmisc.c (dump_symtab_1): Make "b" const.
8045 (block_depth): Make "block" const.
8046 * d-exp.y (%union) <bval>: Remove.
8047 * cp-support.h (cp_lookup_rtti_type): Update.
8048 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8049 * psymtab.c (psym_lookup_symbol): Make "block" const.
8050 (maintenance_check_psymtabs): Make "b" const.
8051 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8052 (enumerate_locals, enumerate_args): Update.
8053 * python/py-symtab.c (stpy_global_block): Make "block" const.
8054 (stpy_static_block): Likewise.
8055 * inline-frame.c (block_starting_point_at): Make "new_block"
8056 const.
8057 * block.c (find_block_in_blockvector): Make return type const.
8058 (blockvector_for_pc_sect): Make "b" const.
8059 (find_block_in_blockvector): Make "b" const.
8060
7ad417dd
TT
80612019-03-23 Tom Tromey <tom@tromey.com>
8062
8063 * varobj.c (varobj_create): Update.
8064 * symfile.c (clear_symtab_users): Don't reset innermost_block.
8065 * printcmd.c (display_command, do_one_display): Don't reset
8066 innermost_block.
8067 * parser-defs.h (enum innermost_block_tracker_type): Move to
8068 expression.h.
8069 (innermost_block): Update comment.
8070 * parse.c (parse_exp_1): Add tracker_types parameter.
8071 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
8072 tracker_types parameter. Reset innermost_block.
8073 (parse_exp_in_context): Remove.
8074 (parse_expression_for_completion): Update.
8075 * objfiles.c (~objfile): Don't reset expression_context_block or
8076 innermost_block.
8077 * expression.h (enum innermost_block_tracker_type): Move from
8078 parser-defs.h.
8079 (parse_exp_1): Add tracker_types parameter.
8080 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8081 reset innermost_block.
8082
b366c208
TT
80832019-03-23 Tom Tromey <tom@tromey.com>
8084
8085 * objfiles.h: Include bcache.h.
8086
9bb9b2f9
TT
80872019-03-23 Tom Tromey <tom@tromey.com>
8088
8089 * linespec.c (get_current_search_block): Use
8090 scoped_restore_current_language.
8091 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8092
59c28372
AH
80932019-03-22 Alan Hayward <alan.hayward@arm.com>
8094 Jiong Wang <jiong.wang@arm.com>
8095
8096 * aarch64-linux-tdep.c
8097 (aarch64_linux_iterate_over_regset_sections): Check for pauth
8098 section.
8099 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8100
17e116a7
AH
81012019-03-22 Alan Hayward <alan.hayward@arm.com>
8102 Jiong Wang <jiong.wang@arm.com>
8103
8104 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8105 instructions.
8106 (aarch64_analyze_prologue_test): Add PACIASP test.
8107 (aarch64_prologue_prev_register): Unmask PC value.
8108
11e1b75f
AH
81092019-03-22 Alan Hayward <alan.hayward@arm.com>
8110 Jiong Wang <jiong.wang@arm.com>
8111
8112 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8113 (aarch64_dwarf2_prev_register): Unmask PC value.
8114 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8115 (aarch64_execute_dwarf_cfa_vendor_op): Check for
8116 DW_CFA_AARCH64_negate_ra_state.
8117 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8118
34dcc7cf
AH
81192019-03-22 Alan Hayward <alan.hayward@arm.com>
8120 Jiong Wang <jiong.wang@arm.com>
8121
8122 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8123 registers.
8124 (aarch64_pseudo_register_name): Likewise.
8125 (aarch64_pseudo_register_type): Likewise.
8126 (aarch64_pseudo_register_reggroup_p): Likewise.
8127 (aarch64_gdbarch_init): Add pauth registers.
8128 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8129 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8130 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8131 (struct gdbarch_tdep): Add regnum for ra_state.
8132
1ef53e6b
AH
81332019-03-22 Alan Hayward <alan.hayward@arm.com>
8134 Jiong Wang <jiong.wang@arm.com>
8135
8136 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8137
76bed0fd
AH
81382019-03-22 Alan Hayward <alan.hayward@arm.com>
8139 Jiong Wang <jiong.wang@arm.com>
8140
8141 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8142 function.
8143 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8144 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8145 (aarch64_gdbarch_init): Add puth registers.
8146 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8147 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8148 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8149
ee4fbcfa
AH
81502019-03-22 Alan Hayward <alan.hayward@arm.com>
8151 Jiong Wang <jiong.wang@arm.com>
8152
8153 * aarch64-linux-nat.c
8154 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8155 * aarch64-linux-tdep.c
8156 (aarch64_linux_core_read_description): Likewise.
8157 (aarch64_linux_get_hwcap): New function.
8158 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8159 (aarch64_linux_get_hwcap): New declaration.
8160
6dc0ebde
AH
81612019-03-22 Alan Hayward <alan.hayward@arm.com>
8162 Jiong Wang <jiong.wang@arm.com>
8163
8164 * aarch64-linux-nat.c
8165 (aarch64_linux_nat_target::read_description): Add pauth param.
8166 * aarch64-linux-tdep.c
8167 (aarch64_linux_core_read_description): Likewise.
8168 * aarch64-tdep.c (struct target_desc): Add in pauth.
8169 (aarch64_read_description): Add pauth param.
8170 (aarch64_gdbarch_init): Likewise.
8171 * aarch64-tdep.h (aarch64_read_description): Likewise.
8172 * arch/aarch64.c (aarch64_create_target_description): Likewise.
8173 * arch/aarch64.h (aarch64_create_target_description): Likewise.
8174 * features/Makefile: Add new files.
8175 * features/aarch64-pauth.c: New file.
8176 * features/aarch64-pauth.xml: New file.
8177
595915c1
TT
81782019-03-20 Tom Tromey <tromey@adacore.com>
8179
8180 * infrun.c (handle_inferior_event): Rename from
8181 handle_inferior_event_1. Create a scoped_value_mark.
8182 (handle_inferior_event): Remove.
8183
4c7d57e7
TT
81842019-03-19 Tom Tromey <tromey@adacore.com>
8185
8186 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8187 * infrun.h (print_stop_event): Add "displays" parameter.
8188 * infrun.c (print_stop_event): Add "displays" parameter.
8189
cb246234
PA
81902019-03-19 Pedro Alves <palves@redhat.com>
8191
8192 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8193 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
8194 to -1. Fix TABs vs spaces.
8195 (tui_ui_out::tui_ui_out): Don't initialize fields here.
8196 * tui/tui-out.h (tui_ui_out) Add intro comments.
8197 <m_line, m_start_of_line>: In-class initialize, and add describing
8198 comment.
8199
3a0e45b2
AH
82002019-03-18 Alan Hayward <alan.hayward@arm.com>
8201
8202 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8203 variable names.
8204 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8205
5371b850
PA
82062019-03-18 Pedro Alves <palves@redhat.com>
8207 Eli Zaretskii <eliz@gnu.org>
8208
8209 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8210 m_line and m_start_of_line.
8211
b17c4cd0
EZ
82122019-03-18 Eli Zaretskii <eliz@gnu.org>
8213
8214 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8215 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8216 it returns a newline. This fixes a regression in TU mode, whereby
8217 the next line is output on the same screen line as the user input.
8218
4bd56d18
TT
82192019-03-18 Tom Tromey <tromey@adacore.com>
8220
8221 * minsyms.c (minimal_symbol_reader::install): Remove call to
8222 obstack_blank.
8223
55c10aca
PA
82242019-03-18 Pedro Alves <palves@redhat.com>
8225
8226 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8227 New globals.
8228 (apply_style): New, factored out from ...
8229 (apply_ansi_escape): ... this. Handle reverse video mode.
8230 (tui_set_reverse_mode): New function.
8231 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8232 * tui/tui-winsource.c (tui_show_source_line): Use
8233 tui_set_reverse_mode instead of setting A_STANDOUT.
8234 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8235 New setter methods.
8236
647bb750
HD
82372019-03-18 Hannes Domani <ssbssa@yahoo.de>
8238
8239 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8240 Handle tabs.
8241
bff8c71f
TT
82422019-03-18 Tom Tromey <tromey@adacore.com>
8243
8244 * ada-lang.c (empty_array): Add "high" parameter.
8245 (ada_evaluate_subexp): Update.
8246
58785d98
ST
82472019-03-17 Sergei Trofimovich <siarheit@google.com>
8248
8249 * unittests/string_view-selftests.c: Define
8250 _initialize_string_view_selftests unconditionally.
8251
d4cbef22
ВМ
82522019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8253
8254 PR gdb/24350
8255 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8256
fce4c071
ВМ
82572019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8258
8259 PR gdb/24351
8260 * windows-nat.c (display_selector): Fix format specifiers.
8261
f7f0a123
EZ
82622019-03-17 Eli Zaretskii <eliz@gnu.org>
8263
8264 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8265 tui_refill_source_window instead of tui_refresh_win, to update the
8266 current execution line. This fixes redisplay of the current line
8267 when stepping through the code with "next" or "step".
8268
ab42892f
EZ
82692019-03-16 Eli Zaretskii <eliz@gnu.org>
8270
8271 * source-cache.c (source_cache::get_source_lines): Call
8272 find_source_lines to initialize s->nlines. This fixes vertical
8273 scrolling of TUI source window when the DOWN arrow is pressed.
8274
8d8c087f
PW
82752019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8276
8277 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8278 linux-thread-db.c (_initialize_thread_db): Likewise.
8279
798e1c30
EZ
82802019-03-16 Eli Zaretskii <eliz@gnu.org>
8281
8282 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8283 wclrtoeol in tui_show_source_line". This reverts changes made in
8284 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8285
eefba3da
TT
82862019-03-15 Tom Tromey <tom@tromey.com>
8287
8288 * symtab.h (struct minimal_symbol): Derive from
8289 general_symbol_info.
8290 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8291 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8292 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8293 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8294 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8295 (MSYMBOL_SEARCH_NAME): Update.
8296 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8297 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8298 * minsyms.c (minimal_symbol_reader::record_full): Update.
8299
0de2420c
TT
83002019-03-15 Tom Tromey <tom@tromey.com>
8301
8302 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8303
042d75e4
TT
83042019-03-15 Tom Tromey <tom@tromey.com>
8305
8306 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8307 unique_xmalloc_ptr.
8308 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8309 Update.
8310 * minsyms.c (lookup_minimal_symbol_by_pc_section)
8311 (build_minimal_symbol_hash_tables)
8312 (minimal_symbol_reader::install): Update.
8313
db92718b
TT
83142019-03-15 Tom Tromey <tom@tromey.com>
8315
8316 * symtab.c (create_demangled_names_hash): Update.
8317 (symbol_set_names): Update.
8318 * objfiles.h (struct objfile_per_bfd_storage)
8319 <demangled_names_hash>: Now an htab_up.
8320 * objfiles.c (objfile_per_bfd_storage): Simplify.
8321
d6797f46
TT
83222019-03-15 Tom Tromey <tom@tromey.com>
8323
8324 * objfiles.h (struct objfile_per_bfd_storage): Declare
8325 destructor.
8326 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8327 New.
8328 (get_objfile_bfd_data): Use new. Don't initialize
8329 language_of_main.
8330 (free_objfile_per_bfd_storage): Remove.
8331 (objfile_bfd_data_free, objfile::~objfile): Use delete.
8332
741d7538
TT
83332019-03-15 Tom Tromey <tom@tromey.com>
8334
8335 * symfile.c (reread_symbols): Update.
8336 * objfiles.c (objfile::objfile): Update.
8337 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8338 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8339 comment.
8340 (minimal_symbol_reader::install): Update.
8341 (terminate_minimal_symbol_table): Remove.
8342 * jit.c (jit_object_close_impl): Update.
8343
788c80d1
TT
83442019-03-15 Tom Tromey <tom@tromey.com>
8345
8346 * minsyms.c (minimal_symbol_reader::record_full): Remove some
8347 initializations.
8348
1b7a07cb
TT
83492019-03-15 Tom Tromey <tom@tromey.com>
8350
8351 * objfiles.h (struct objfile_per_bfd_storage)
8352 <demangled_hash_languages>: Now a bitset.
8353 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8354 (lookup_minimal_symbol): Update.
8355
3db066bc
TT
83562019-03-15 Tom Tromey <tom@tromey.com>
8357
8358 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8359 Don't return the symbol.
8360 * coffread.c (record_minimal_symbol): Use record_full.
8361
3fff2c37
EZ
83622019-03-14 Eli Zaretskii <eliz@gnu.org>
8363
8364 The MS-Windows port of ncurses fails to switch to a color pair if
8365 one or both of the colors are the implicit default colors. This
8366 change records the default colors when TUI is initialized, and
8367 then specifies them explicitly when a color pair uses the default
8368 colors. This allows color styling in TUI mode on MS-Windows.
8369
8370 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
8371 ncurses_norm_attr.
8372 (tui_initialize_io) [__MINGW32__]: Record the default terminal
8373 colors in ncurses_norm_attr.
8374 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8375 "none", replace it with the default color recorded in
8376 ncurses_norm_attr.
8377
3b336828
TT
83782019-03-14 Tom Tromey <tromey@adacore.com>
8379
8380 * source-cache.h (class source_cache) <get_source_lines>: Return
8381 std::string.
8382 * source-cache.c (source_cache::extract_lines): Handle case where
8383 first_pos==npos. Return std::string.
8384 (source_cache::get_source_lines): Update.
8385
d085f989
TT
83862019-03-14 Tom Tromey <tromey@adacore.com>
8387
8388 * NEWS: Add item for "style sources" commands.
8389 * source-cache.c (source_cache::get_source_lines): Check
8390 source_styling.
8391 * cli/cli-style.c (source_styling): New global.
8392 (_initialize_cli_style): Add "style sources" commands.
8393 (show_style_sources): New function.
8394 * cli/cli-style.h (source_styling): Declare.
8395
6f11e682
TT
83962019-03-14 Pedro Alves <palves@redhat.com>
8397 Tom Tromey <tromey@adacore.com>
8398
8399 * tui/tui-winsource.h (tui_refill_source_window): Declare.
8400 * tui/tui-winsource.c (tui_refill_source_window): New function,
8401 from...
8402 (tui_horizontal_source_scroll): ... here. Move some logic.
8403 * cli/cli-style.c (set_style_enabled): Notify new observable.
8404 * tui/tui-hooks.c (tui_redisplay_source): New function.
8405 (tui_attach_detach_observers): Attach or detach
8406 tui_redisplay_source.
8407 * observable.h (source_styling_changed): New observable.
8408 * observable.c: Define source_styling_changed observable.
8409
a068643d
TT
84102019-03-13 Tom Tromey <tromey@adacore.com>
8411
8412 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8413 (i386_gnu_nat_target::store_registers): Update.
8414 * target-debug.h (target_debug_print_std_string): New macro.
8415 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8416 * windows-tdep.c (display_one_tib): Update.
8417 * tui/tui-stack.c (tui_make_status_line): Update.
8418 * top.c (print_inferior_quit_action): Update.
8419 * thread.c (thr_try_catch_cmd): Update.
8420 (add_thread_with_info): Update.
8421 (thread_target_id_str): Update.
8422 (thr_try_catch_cmd): Update.
8423 (thread_command): Update.
8424 (thread_find_command): Update.
8425 * record-btrace.c (record_btrace_target::info_record)
8426 (record_btrace_resume_thread, record_btrace_target::resume)
8427 (record_btrace_cancel_resume, record_btrace_step_thread)
8428 (record_btrace_target::wait, record_btrace_target::wait)
8429 (record_btrace_target::wait, record_btrace_target::stop): Update.
8430 * progspace.c (print_program_space): Update.
8431 * process-stratum-target.c
8432 (process_stratum_target::thread_address_space): Update.
8433 * linux-fork.c (linux_fork_mourn_inferior)
8434 (detach_checkpoint_command, info_checkpoints_command)
8435 (linux_fork_context): Update.
8436 (linux_fork_detach): Update.
8437 (class scoped_switch_fork_info): Update.
8438 (delete_checkpoint_command): Update.
8439 * infrun.c (follow_fork_inferior): Update.
8440 (follow_fork_inferior): Update.
8441 (proceed_after_vfork_done): Update.
8442 (handle_vfork_child_exec_or_exit): Update.
8443 (follow_exec): Update.
8444 (displaced_step_prepare_throw): Update.
8445 (displaced_step_restore): Update.
8446 (start_step_over): Update.
8447 (resume_1): Update.
8448 (clear_proceed_status_thread): Update.
8449 (proceed): Update.
8450 (print_target_wait_results): Update.
8451 (do_target_wait): Update.
8452 (context_switch): Update.
8453 (stop_all_threads): Update.
8454 (restart_threads): Update.
8455 (finish_step_over): Update.
8456 (handle_signal_stop): Update.
8457 (switch_back_to_stepped_thread): Update.
8458 (keep_going_pass_signal): Update.
8459 (print_exited_reason): Update.
8460 (normal_stop): Update.
8461 * inferior.c (inferior_pid_to_str): Change return type.
8462 (print_selected_inferior): Update.
8463 (add_inferior): Update.
8464 (detach_inferior): Update.
8465 * dummy-frame.c (fprint_dummy_frames): Update.
8466 * dcache.c (dcache_info_1): Update.
8467 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8468 (btrace_fetch, btrace_clear): Update.
8469 * linux-tdep.c (linux_core_pid_to_str): Change return type.
8470 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8471 type.
8472 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8473 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8474 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8475 * gdbarch.c, gdbarch.h: Rebuild.
8476 * gdbarch.sh (core_pid_to_str): Change return type.
8477 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8478 return type.
8479 (windows_nat_target::pid_to_str): Change return type.
8480 (windows_delete_thread): Update.
8481 (windows_nat_target::attach): Update.
8482 (windows_nat_target::files_info): Update.
8483 * target-delegates.c: Rebuild.
8484 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8485 return type.
8486 (sol_thread_target::pid_to_str): Change return type.
8487 * remote.c (class remote_target) <pid_to_str>: Change return
8488 type.
8489 (remote_target::pid_to_str): Change return type.
8490 (extended_remote_target::attach, remote_target::remote_stop_ns)
8491 (remote_target::remote_notif_remove_queued_reply)
8492 (remote_target::push_stop_reply, remote_target::disable_btrace):
8493 Update.
8494 (extended_remote_target::attach): Update.
8495 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8496 type.
8497 (gdbsim_target::pid_to_str): Change return type.
8498 * ravenscar-thread.c (struct ravenscar_thread_target)
8499 <pid_to_str>: Change return type.
8500 (ravenscar_thread_target::pid_to_str): Change return type.
8501 * procfs.c (class procfs_target) <pid_to_str>: Change return
8502 type.
8503 (procfs_target::pid_to_str): Change return type.
8504 (procfs_target::attach): Update.
8505 (procfs_target::detach): Update.
8506 (procfs_target::fetch_registers): Update.
8507 (procfs_target::store_registers): Update.
8508 (procfs_target::wait): Update.
8509 (procfs_target::files_info): Update.
8510 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8511 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8512 return type.
8513 (nto_procfs_target::pid_to_str): Change return type.
8514 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8515 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8516 return type.
8517 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8518 (exit_lwp): Update.
8519 (attach_proc_task_lwp_callback, get_detach_signal)
8520 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8521 (linux_nat_target::resume, wait_lwp, stop_callback)
8522 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8523 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8524 (linux_nat_wait_1, resume_stopped_resumed_lwps)
8525 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8526 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8527 type.
8528 (inf_ptrace_target::attach): Update.
8529 (inf_ptrace_target::files_info): Update.
8530 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8531 type.
8532 (go32_nat_target::pid_to_str): Change return type.
8533 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8534 (gnu_nat_target::wait): Update.
8535 (gnu_nat_target::wait): Update.
8536 (gnu_nat_target::resume): Update.
8537 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8538 (fbsd_nat_target::wait): Update.
8539 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8540 type.
8541 (darwin_nat_target::attach): Update.
8542 * corelow.c (class core_target) <pid_to_str>: Change return type.
8543 (core_target::pid_to_str): Change return type.
8544 * target.c (normal_pid_to_str): Change return type.
8545 (default_pid_to_str): Likewise.
8546 (target_pid_to_str): Change return type.
8547 (target_translate_tls_address): Update.
8548 (target_announce_detach): Update.
8549 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8550 return type.
8551 (bsd_uthread_target::pid_to_str): Change return type.
8552 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8553 type.
8554 (bsd_kvm_target::pid_to_str): Change return type.
8555 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8556 return type.
8557 (aix_thread_target::pid_to_str): Change return type.
8558 * target.h (struct target_ops) <pid_to_str>: Change return type.
8559 (target_pid_to_str, normal_pid_to_str): Likewise.
8560 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8561 type.
8562 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8563 type.
8564 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8565 return type.
8566 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8567 type.
8568 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8569 type.
8570 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8571 return type.
8572
b4be1b06
SM
85732019-03-13 Simon Marchi <simon.marchi@ericsson.com>
8574
8575 * NEWS: Mention that the new default MI version is 3. Mention
8576 changes to the output of commands and events that deal with
8577 multi-location breakpoints.
8578 * breakpoint.c: Include "mi/mi-out.h".
8579 (print_one_breakpoint): Change output syntax if using MI version
8580 >= 3.
8581 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8582 New.
8583 (mi_multi_location_breakpoint_output_fixed): New.
8584 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8585 (mi_cmd_fix_multi_location_breakpoint_output): New.
8586 (mi_multi_location_breakpoint_output_fixed): New.
8587 * mi/mi-cmds.c (mi_cmds): Register command
8588 -fix-multi-location-breakpoint-output.
8589 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8590 interpreter "mi".
8591
8e5e5494
SM
85922019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
8593
8594 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8595 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8596 instantiate mi_ui_out based on interpreter name.
8597 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8598 * mi/mi-main.c (mi_load_progress): Likewise.
8599
197df35e
JB
86002019-03-12 John Baldwin <jhb@FreeBSD.org>
8601
8602 * NEWS: Combine separate "New targets" sections for 8.3.
8603
8399425f
JB
86042019-03-12 John Baldwin <jhb@FreeBSD.org>
8605
8606 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8607 (ppcfbsd_init_abi): Install gdbarch
8608 "fetch_tls_load_module_address" and "get_thread_local_address"
8609 methods.
8610
b0f87ed0
JB
86112019-03-12 John Baldwin <jhb@FreeBSD.org>
8612
8613 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8614 (riscv_fbsd_init_abi): Install gdbarch
8615 "fetch_tls_load_module_address" and "get_thread_local_address"
8616 methods.
8617
ce25aa57
JB
86182019-03-12 John Baldwin <jhb@FreeBSD.org>
8619
8620 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8621 (i386fbsd_init_abi): Install gdbarch
8622 "fetch_tls_load_module_address" and "get_thread_local_address"
8623 methods.
8624
f5424cfa
JB
86252019-03-12 John Baldwin <jhb@FreeBSD.org>
8626
8627 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8628 (amd64fbsd_init_abi): Install gdbarch
8629 "fetch_tls_load_module_address" and "get_thread_local_address"
8630 methods.
8631
945f3901
JB
86322019-03-12 John Baldwin <jhb@FreeBSD.org>
8633
8634 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8635 (struct fbsd_pspace_data): New type.
8636 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8637 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8638 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8639 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8640 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8641
ef0bd204
JB
86422019-03-12 John Baldwin <jhb@FreeBSD.org>
8643
8644 * gdbtypes.c (lookup_struct_elt): New function.
8645 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8646 * gdbtypes.h (struct struct_elt): New type.
8647 (lookup_struct_elt): New prototype.
8648
36c53a02
JB
86492019-03-12 John Baldwin <jhb@FreeBSD.org>
8650
8651 * gdbtypes.c (lookup_struct_elt_type): Update comment and
8652 remove disabled code block.
8653
6e056c81
JB
86542019-03-12 John Baldwin <jhb@FreeBSD.org>
8655
8656 * gdbarch.sh (get_thread_local_address): New method.
8657 * gdbarch.h, gdbarch.c: Regenerate.
8658 * target.c (target_translate_tls_address): Use
8659 gdbarch_get_thread_local_address if present instead of
8660 target::get_thread_local_address.
8661
cd250a18
JB
86622019-03-12 John Baldwin <jhb@FreeBSD.org>
8663
8664 * target.h (target::get_thread_local_address): Update comment.
8665
df22c1e5
JB
86662019-03-12 John Baldwin <jhb@FreeBSD.org>
8667
8668 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8669 objfile->separate_debug_objfile_backlink if not NULL.
8670
dd6876c9
JB
86712019-03-12 John Baldwin <jhb@FreeBSD.org>
8672
8673 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8674 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8675 (amd64bsd_store_inferior_registers): Likewise.
8676 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8677 Enable segment base registers.
8678 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8679 PT_GETFSBASE and PT_GETGSBASE.
8680 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8681 PT_SETGSBASE.
8682 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8683 segment base registers.
8684 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8685
1163a4b7
JB
86862019-03-12 John Baldwin <jhb@FreeBSD.org>
8687
8688 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8689 Update calls to i386_target_description to add 'segments'
8690 parameter.
8691 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
8692 add segment base registers.
8693 * arch/i386.c (i386_create_target_description): Add 'segments'
8694 parameter to enable segment base registers.
8695 * arch/i386.h (i386_create_target_description): Likewise.
8696 * features/i386/32bit-segments.xml: New file.
8697 * features/i386/32bit-segments.c: Generate.
8698 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8699 call to i386_target_description to add 'segments' parameter.
8700 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8701 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8702 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8703 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8704 if feature is present.
8705 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8706 Add 'segments' parameter to call to i386_target_description.
8707 (i386_target_description): Add 'segments' parameter to enable
8708 segment base registers.
8709 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8710 to call to i386_target_description.
8711 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8712 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8713 Define I386_NUM_REGS.
8714 (i386_target_description): Add 'segments' parameter to enable
8715 segment base registers.
8716
3a350822
EZ
87172019-03-12 Eli Zaretskii <eliz@gnu.org>
8718
8719 PR/24325
8720 * source-cache.c: #undef open and close, to avoid unresolved
8721 externals during linking.
8722
ffdd69cf
TT
87232019-03-12 Tom Tromey <tromey@adacore.com>
8724
8725 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8726 const. Add initializers.
8727 (_initialize_remote): Don't initialize ptid globals.
8728
ec148c57
PA
87292019-03-12 Pedro Alves <palves@redhat.com>
8730
8731 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8732
32764270
PA
87332019-03-12 Pedro Alves <palves@redhat.com>
8734
8735 * cp-name-parser.y (main): Remove unused 'len' variable.
8736
17547186
TT
87372019-03-12 Tom Tromey <tromey@adacore.com>
8738
8739 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8740 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8741
d3a70e03
TT
87422019-03-12 Tom Tromey <tromey@adacore.com>
8743
8744 * linux-nat.c (iterate_over_lwps): Update.
8745 (stop_callback): Remove parameter.
8746 (stop_wait_callback, detach_callback, resume_set_callback)
8747 (select_singlestep_lwp_callback, set_ignore_sigint)
8748 (status_callback, resumed_callback, resume_clear_callback)
8749 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8750 data parameter.
8751 (linux_nat_target::detach, linux_nat_target::resume)
8752 (linux_stop_and_wait_all_lwps, select_event_lwp)
8753 (linux_nat_filter_event, linux_nat_wait_1)
8754 (linux_nat_target::kill, linux_nat_target::stop)
8755 (linux_nat_target::stop): Update.
8756 (linux_nat_resume_callback): Change type.
8757 (resume_stopped_resumed_lwps, count_events_callback)
8758 (select_event_lwp_callback): Likewise.
8759 (linux_stop_lwp, linux_nat_stop_lwp): Update.
8760 * arm-linux-nat.c (struct update_registers_data): Remove.
8761 (update_registers_callback): Change type.
8762 (arm_linux_insert_hw_breakpoint1): Update.
8763 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8764 parameter.
8765 (x86_linux_dr_set_addr): Update.
8766 (x86_linux_dr_set_control): Update.
8767 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8768 (iterate_over_lwps): Use gdb::function_view.
8769 * nat/aarch64-linux-hw-point.c (struct
8770 aarch64_dr_update_callback_param): Remove.
8771 (debug_reg_change_callback): Change type.
8772 (aarch64_notify_debug_reg_change): Update.
8773 * s390-linux-nat.c (s390_refresh_per_info): Update.
8774
82cb27ff
TT
87752019-03-11 Tom Tromey <tromey@adacore.com>
8776
8777 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8778 redundant assignment to "this_cu".
8779
568c0683
SM
87802019-03-08 Simon Marchi <simon.marchi@efficios.com>
8781
8782 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8783
f09ce22d
SM
87842019-03-08 Simon Marchi <simon.marchi@efficios.com>
8785
8786 * gdbtypes.c (rank_one_type_parm_set): New function extracted
8787 from...
8788 (rank_one_type): ... this.
8789
595f96a9
SM
87902019-03-08 Simon Marchi <simon.marchi@efficios.com>
8791
8792 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8793 from...
8794 (rank_one_type): ... this.
8795
2598a94b
SM
87962019-03-08 Simon Marchi <simon.marchi@efficios.com>
8797
8798 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8799 from...
8800 (rank_one_type): ... this.
8801
7f17b20d
SM
88022019-03-08 Simon Marchi <simon.marchi@efficios.com>
8803
8804 * gdbtypes.c (rank_one_type_parm_float): New function extracted
8805 from...
8806 (rank_one_type): ... this.
8807
2c509035
SM
88082019-03-08 Simon Marchi <simon.marchi@efficios.com>
8809
8810 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8811 from...
8812 (rank_one_type): ... this.
8813
0dd322dc
SM
88142019-03-08 Simon Marchi <simon.marchi@efficios.com>
8815
8816 * gdbtypes.c (rank_one_type_parm_range): New function extracted
8817 from...
8818 (rank_one_type): ... this.
8819
41ea4728
SM
88202019-03-08 Simon Marchi <simon.marchi@efficios.com>
8821
8822 * gdbtypes.c (rank_one_type_parm_char): New function extracted
8823 from...
8824 (rank_one_type): ... this.
8825
793cd1d2
SM
88262019-03-08 Simon Marchi <simon.marchi@efficios.com>
8827
8828 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8829 from...
8830 (rank_one_type): ... this.
8831
34910087
SM
88322019-03-08 Simon Marchi <simon.marchi@efficios.com>
8833
8834 * gdbtypes.c (rank_one_type_parm_int): New function extracted
8835 from...
8836 (rank_one_type): ... this.
8837
f1f832d6
SM
88382019-03-08 Simon Marchi <simon.marchi@efficios.com>
8839
8840 * gdbtypes.c (rank_one_type_parm_func): New function extracted
8841 from...
8842 (rank_one_type): ... this.
8843
b9f4512f
SM
88442019-03-08 Simon Marchi <simon.marchi@efficios.com>
8845
8846 * gdbtypes.c (rank_one_type_parm_array): New function extracted
8847 from...
8848 (rank_one_type): ... this.
8849
9293fc63
SM
88502019-03-08 Simon Marchi <simon.marchi@efficios.com>
8851
8852 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8853 from...
8854 (rank_one_type): ... this.
8855
e3abbe7e
PW
88562019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8857
8858 * inferior.c (initialize_inferiors): Ensure 'help set/show print
8859 inferior-events' shows the example events.
8860
e4adb939
EZ
88612019-03-08 Eli Zaretskii <eliz@gnu.org>
8862
8863 Support styling on native MS-Windows console
8864
8865 PR/24315
8866 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8867 on MS-Windows if $TERM is not defined.
8868
8869 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8870
8871 * posix-hdep.c (gdb_console_fputs):
8872 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8873 functions.
8874 * ui-file.h (gdb_console_fputs): Add prototype.
8875
8876 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8877 back to fputs only if the former returns zero.
8878
25629dfd
TT
88792019-03-07 Tom Tromey <tom@tromey.com>
8880
8881 * symmisc.c (print_symbol_bcache_statistics): Update.
8882 (print_objfile_statistics): Update.
8883 * symfile.c (allocate_symtab): Update.
8884 * stabsread.c: Don't include bcache.h.
8885 * psymtab.h (struct psymbol_bcache): Don't declare.
8886 (class psymtab_storage) <psymbol_cache>: Now a bcache.
8887 (psymbol_bcache_init, psymbol_bcache_free)
8888 (psymbol_bcache_get_bcache): Don't declare.
8889 * psymtab.c (struct psymbol_bcache): Remove.
8890 (psymtab_storage::psymtab_storage): Update.
8891 (psymtab_storage::~psymtab_storage): Update.
8892 (psymbol_bcache_init, psymbol_bcache_free)
8893 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8894 (add_psymbol_to_bcache): Update.
8895 (allocate_psymtab): Update.
8896 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8897 macro_cache>: No longer pointers.
8898 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8899 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8900 * macrotab.c (macro_bcache): Update.
8901 * macroexp.c: Don't include bcache.h.
8902 * gdbtypes.c (check_types_worklist): Update.
8903 (types_deeply_equal): Remove TRY/CATCH. Update.
8904 * elfread.c (elf_symtab_read): Update.
8905 * dwarf2read.c: Don't include bcache.h.
8906 * buildsym.c (buildsym_compunit::get_macro_table): Update.
8907 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8908 (print_bcache_statistics, bcache_memory_used): Don't declare.
8909 (struct bcache): Move from bcache.c. Add constructor, destructor,
8910 methods. Rename all data members.
8911 * bcache.c (struct bcache): Move to bcache.h.
8912 (bcache::expand_hash_table): Rename from expand_hash_table.
8913 (bcache): Remove.
8914 (bcache::insert): Rename from bcache_full.
8915 (bcache::compare): Rename from bcache_compare.
8916 (bcache_xmalloc): Remove.
8917 (bcache::~bcache): Rename from bcache_xfree.
8918 (bcache::print_statistics): Rename from print_bcache_statistics.
8919 (bcache::memory_used): Rename from bcache_memory_used.
8920
fe726667
PA
89212019-03-07 Pedro Alves <palves@redhat.com>
8922
8923 * infrun.c (normal_stop): Also check for
8924 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8925
7584bb30
AB
89262019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
8927
8928 * f-lang.c (value_from_host_double): Moved to...
8929 * value.c (value_from_host_double): ...here.
8930 * value.h (value_from_host_double): Declare.
8931 * guile/scm-math.c (vlscm_convert_typed_number): Use
8932 value_from_host_double.
8933 (vlscm_convert_number): Likewise.
8934 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8935 * python/py-value.c (convert_value_from_python): Likewise.
8936
a7b1986e
TT
89372019-03-06 Tom Tromey <tom@tromey.com>
8938
8939 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8940
0ccf4211
TT
89412019-03-06 Tom Tromey <tom@tromey.com>
8942
8943 * utils.h (free_current_contents): Don't declare.
8944 * utils.c (free_current_contents): Remove.
8945
fe7b42e5
TT
89462019-03-06 Tom Tromey <tom@tromey.com>
8947
8948 * top.c (quit_force): Update.
8949 * main.c (captured_command_loop): Update.
8950 * common/new-op.c (operator new): Update.
8951 * common/common-exceptions.c (struct catcher)
8952 <save_cleanup_chain>: Remove member.
8953 (exceptions_state_mc_init): Update.
8954 (exception_try_scope_entry): Return nullptr.
8955 (exception_try_scope_exit, exception_rethrow)
8956 (throw_exception_sjlj, throw_exception_cxx): Update.
8957 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8958 (all_cleanups, do_cleanups, discard_cleanups)
8959 (discard_final_cleanups, save_cleanups, save_final_cleanups)
8960 (restore_cleanups, restore_final_cleanups): Don't declare.
8961 (do_final_cleanups): Remove parameter.
8962 * common/cleanups.c (cleanup_chain, make_cleanup)
8963 (make_cleanup_dtor, all_cleanups, do_cleanups)
8964 (discard_my_cleanups, discard_cleanups)
8965 (discard_final_cleanups, save_my_cleanups, save_cleanups)
8966 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8967 (null_cleanup): Remove.
8968 (do_final_cleanups): Remove parameter.
8969
c6321f19
TT
89702019-03-06 Tom Tromey <tom@tromey.com>
8971
8972 * remote.c (remote_target::remote_parse_stop_reply): Use
8973 unique_xmalloc_ptr.
8974
61b30099
TT
89752019-03-06 Tom Tromey <tom@tromey.com>
8976
8977 * stabsread.c (struct stabs_field_info): Rename from field_info.
8978 <list, fnlist>: Add initializers.
8979 <obstack>: New member.
8980 (read_member_functions, read_struct_fields, read_baseclasses):
8981 Allocate on obstack. Don't use cleanups.
8982 (read_one_struct_field, read_member_functions, read_struct_fields)
8983 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8984 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8985 (read_struct_type): Update.
8986
6cceac94
TT
89872019-03-06 Tom Tromey <tom@tromey.com>
8988
8989 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8990 * common/filestuff.h (make_cleanup_close): Don't declare.
8991 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8992 Remove.
8993
72412762
TT
89942019-03-06 Tom Tromey <tom@tromey.com>
8995
8996 * solib-aix.c: Use make_scope_exit.
8997
2b6ff1c0
TT
89982019-03-06 Tom Tromey <tom@tromey.com>
8999
9000 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9001 Use make_scope_exit.
9002
d01c5877
TT
90032019-03-06 Tom Tromey <tom@tromey.com>
9004
9005 * solib-svr4.c (disable_probes_interface): Remove parameter.
9006 (svr4_handle_solib_event): Use make_scope_exit.
9007
32603266
TT
90082019-03-06 Tom Tromey <tom@tromey.com>
9009
9010 * remote.c (struct stop_reply_deleter): Remove.
9011 (stop_reply_up): Update.
9012 (struct stop_reply): Derive from notif_event. Don't typedef.
9013 <regcache>: Now a std::vector.
9014 (stop_reply_xfree): Remove.
9015 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9016 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
9017 (remote_target::discard_pending_stop_replies): Use delete.
9018 (remote_target::remote_parse_stop_reply): Update.
9019 (remote_target::process_stop_reply): Update.
9020 * remote-notif.h (struct notif_event): Add virtual destructor.
9021 Remove "dtr" member.
9022 (struct notif_client) <alloc_event>: Return a unique_ptr.
9023 (notif_event_xfree): Don't declare.
9024 (notif_event_up): New typedef.
9025 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9026 (notif_event_xfree, do_notif_event_xfree): Remove.
9027 (remote_notif_state_xfree): Update.
9028
9799571e
TT
90292019-03-06 Tom Tromey <tom@tromey.com>
9030
9031 * infrun.c (displaced_step_clear_cleanup): Now a
9032 forward_scope_exit type.
9033 (displaced_step_prepare_throw): Update.
9034 (displaced_step_fixup): Update.
9035
09e3c4ca
TT
90362019-03-06 Tom Tromey <tom@tromey.com>
9037
9038 * inferior.h (class inferior): Update comment.
9039 * gdbthread.h (class thread_info): Update comment.
9040
e2a03548
TT
90412019-03-06 Joel Brobecker <brobecker@adacore.com>
9042 Tom Tromey <tom@tromey.com>
9043
9044 * stabsread.h (struct stab_section_list): Remove.
9045 (coffstab_build_psymtabs): Update.
9046 * dbxread.c (symbuf_sections): Now a std::vector.
9047 (sect_idx): New global.
9048 (fill_symbuf): Update.
9049 (coffstab_build_psymtabs): Change type of stabsects parameter.
9050 Update.
9051 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9052 std::vector.
9053 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9054 (coff_locate_sections): Update.
9055 (coff_symfile_read): Remove cleanups. Update.
9056 (init_stringtab): Add storage parameter.
9057 (free_stringtab, free_stringtab_cleanup): Remove.
9058 (init_lineno): Add storage parameter.
9059 (free_linetab, free_linetab_cleanup): Remove.
9060
b7e60d85
PA
90612019-03-06 Pedro Alves <palves@redhat.com>
9062
9063 * linux-fork.c (fork_info::clobber_regs): Delete.
9064 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9065 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
9066 comment. Adjust.
9067 (scoped_switch_fork_info::scoped_switch_fork_info)
9068 (checkpoint_command, linux_fork_context): Adjust
9069 fork_save_infrun_state calls.
9070
e52c971f
PA
90712019-03-06 Pedro Alves <palves@redhat.com>
9072
9073 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9074 (inf_has_multiple_threads): Return 'bool' and rewrite using
9075 inferior_info::threads().
9076
06974e6c
PA
90772019-03-06 Pedro Alves <palves@redhat.com>
9078
9079 * linux-fork.c: Include <list>.
9080 (fork_list): Now a std::list instance.
9081 (fork_info): Add ctor, dtor, and in-class initialize all fields.
9082 (forks_exist_p, find_last_fork): Adjust.
9083 (new_fork): Delete.
9084 (one_fork_p): New.
9085 (add_fork): Adjust.
9086 (free_fork): Delete, folded into fork_info::~fork_info().
9087 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9088 Adjust.
9089 (init_fork_list): Delete.
9090 (linux_fork_killall, linux_fork_mourn_inferior)
9091 (linux_fork_detach, info_checkpoints_command): Adjust.
9092 (_initialize_linux_fork): No longer call init_fork_list.
9093
72f31aea
PA
90942019-03-06 Pedro Alves <palves@redhat.com>
9095
9096 * linux-fork.c (new_fork): New, split out of ...
9097 (add_fork): ... this. Return void. Move "first fork" special
9098 case from here, to ...
9099 (checkpoint_command): ... here.
9100 * linux-linux.h (add_fork): Return void.
9101
efbecbc1
AB
91022019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9103
9104 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9105
0841c79a
AB
91062019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9107 Chris January <chris.january@arm.com>
9108 David Lecomber <david.lecomber@arm.com>
9109
9110 * f-exp.y: New token, UNOP_INTRINSIC.
9111 (exp): New pattern using UNOP_INTRINSIC token.
9112 (f77_keywords): Add 'abs' keyword.
9113 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9114 (value_from_host_double): New function.
9115 (evaluate_subexp_f): Support UNOP_ABS.
9116
4a270568
AB
91172019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9118
9119 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9120 types.
9121
067630bd
AB
91222019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9123
9124 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9125 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9126 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9127
3be47f7a
AB
91282019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9129
9130 * f-exp.y (convert_to_kind_type): Handle more type kinds.
9131
4d00f5d8
AB
91322019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9133 Chris January <chris.january@arm.com>
9134
9135 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9136 * f-exp.y: Define 'KIND' token.
9137 (exp): New pattern for KIND expressions.
9138 (ptype): Handle types with a kind extension.
9139 (direct_abs_decl): Extend to spot kind extensions.
9140 (f77_keywords): Add 'kind' to the list.
9141 (push_kind_type): New function.
9142 (convert_to_kind_type): New function.
9143 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9144 * parse.c (operator_length_standard): Likewise.
9145 * parser-defs.h (enum type_pieces): Add tp_kind.
9146 * std-operator.def: Add UNOP_KIND.
9147
e454224f
AB
91482019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9149
9150 * f-exp.y (f_parse): Set yydebug.
9151
9dad4a58
AB
91522019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9153
9154 * f-lang.c (evaluate_subexp_f): New function.
9155 (exp_descriptor_f): New global.
9156 (f_language_defn): Use exp_descriptor_f instead of
9157 exp_descriptor_standard.
9158
c8f91604
AB
91592019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9160
9161 * f-exp.y (struct token): Add comments.
9162 (dot_ops): Remove uppercase versions and the end marker.
9163 (f77_keywords): Likewise.
9164 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9165 entries in the dot_ops array are case insensitive, and use
9166 strncasecmp to compare strings. Also some whitespace cleanup in
9167 this area. Similar for the f77_keywords array, except entries in
9168 this list might be case sensitive.
9169
dd9f2c76
AB
91702019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9171
9172 * f-exp.y (struct f77_boolean_val): Add comments.
9173 (boolean_values): Remove uppercase versions, and end marker.
9174 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9175 and use strncasecmp to achieve case insensitivity. Additionally,
9176 perform whitespace cleanup around this code.
9177
67a3048c
TT
91782019-03-06 Tom Tromey <tromey@adacore.com>
9179
9180 * remote-sim.c (gdbsim_target_open): Use result of
9181 gdb_argv::release.
9182
aa3cfbda
RB
91832019-03-06 Richard Bunt <richard.bunt@arm.com>
9184 Dirk Schubert <dirk.schubert@arm.com>
9185 Chris January <chris.january@arm.com>
9186
9187 * eval.c (evaluate_subexp_standard): Call Fortran argument
9188 wrapping logic.
9189 * f-lang.c (struct value): A value which can be passed into a
9190 Fortran function call.
9191 (fortran_argument_convert): Wrap Fortran arguments in a pointer
9192 where appropriate.
9193 (struct type): Value ready for a Fortran function call.
9194 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9195 is needed.
9196 * f-lang.h (fortran_argument_convert): Declaration.
9197 (fortran_preserve_arg_pointer): Declaration.
9198 * infcall.c (value_arg_coerce): Call Fortran argument logic.
9199
ea38e5df
TT
92002019-03-05 Tom Tromey <tromey@adacore.com>
9201
9202 * python/py-prettyprint.c (print_string_repr): Remove #if.
9203 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9204
06b5b831
TT
92052019-03-05 Tom Tromey <tromey@adacore.com>
9206
9207 * target.c (the_dummy_target): Move later. Change type to
9208 "dummy_target".
9209 (initialize_targets): Don't initialize the_dummy_target.
9210
edbd9e45
TT
92112019-03-05 Tom Tromey <tromey@adacore.com>
9212
9213 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9214 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9215
c119e040
TT
92162019-03-05 Tom Tromey <tromey@adacore.com>
9217
9218 * windows-nat.c (windows_nat_target::attach)
9219 (windows_nat_target::detach): Don't call gdb_flush.
9220 * valprint.c (generic_val_print, val_print, val_print_string):
9221 Don't call gdb_flush.
9222 * utils.c (defaulted_query): Don't call gdb_flush.
9223 * typeprint.c (print_type_scalar): Don't call gdb_flush.
9224 * target.c (target_announce_detach): Don't call gdb_flush.
9225 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9226 * remote.c (extended_remote_target::attach): Don't call
9227 gdb_flush.
9228 * procfs.c (procfs_target::detach): Don't call gdb_flush.
9229 * printcmd.c (do_examine): Don't call gdb_flush.
9230 (info_display_command): Don't call gdb_flush.
9231 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9232 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9233 * memattr.c (info_mem_command): Don't call gdb_flush.
9234 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9235 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9236 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9237 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9238 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9239 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9240 (gnu_nat_target::detach): Don't call gdb_flush.
9241 * f-valprint.c (f_val_print): Don't call gdb_flush.
9242 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9243 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9244 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9245 gdb_flush.
9246 * c-valprint.c (c_val_print): Don't call gdb_flush.
9247 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9248
895dafa6
TT
92492019-03-05 Tom Tromey <tromey@adacore.com>
9250
9251 * varobj.c (update_dynamic_varobj_children): Update.
9252 (install_default_visualizer): Use reset, not release.
9253 * value.c (set_internalvar): Update.
9254 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9255 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9256 ATTRIBUTE_UNUSED_RESULT.
9257
88a774b9
TT
92582019-03-05 Tom Tromey <tromey@adacore.com>
9259
9260 * remote.c (class scoped_remote_fd) <release>: Add
9261 ATTRIBUTE_UNUSED_RESULT.
9262
4e4a8b93
TT
92632019-03-05 Tom Tromey <tromey@adacore.com>
9264
9265 * macroexp.c (struct macro_buffer) <release>: Add
9266 ATTRIBUTE_UNUSED_RESULT.
9267
083eef1f
TT
92682019-03-05 Tom Tromey <tromey@adacore.com>
9269
9270 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9271 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9272 ATTRIBUTE_UNUSED_RESULT.
9273
3cabd438
TT
92742019-03-05 Tom Tromey <tromey@adacore.com>
9275
9276 * common/scoped_fd.h (class scoped_fd) <release>: Add
9277 ATTRIBUTE_UNUSED_RESULT.
9278
41e3300a
TT
92792019-03-05 Tom Tromey <tromey@adacore.com>
9280
9281 * parser-defs.h (struct parser_state) <release>: Add
9282 ATTRIBUTE_UNUSED_RESULT.
9283
18cb7c9f
TT
92842019-03-05 Tom Tromey <tromey@adacore.com>
9285
9286 * utils.h (class gdb_argv) <release>: Add
9287 ATTRIBUTE_UNUSED_RESULT.
9288 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9289
41fa577f
EZ
92902019-03-02 Eli Zaretskii <eliz@gnu.org>
9291
a6a4b2c6
EZ
9292 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9293 for-loop range, to avoid compiler warnings.
9294
9295 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9296 avoid compiler warnings about unused variables.
9297
742a7df5
EZ
9298 * NEWS: Mention end of support for native debugging on MS-Windows
9299 before XP.
9300
41fa577f
EZ
9301 PR gdb/24292
9302 * common/netstuff.c:
9303 * gdbserver/gdbreplay.c
9304 * gdbserver/remote-utils.c:
9305 * ser-tcp.c:
9306 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9307 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
9308 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9309 'getaddrinfo' and 'freeaddrinfo' were not available before
9310 Windows XP, and mingw.org's MinGW headers by default define
9311 _WIN32_WINNT to 0x500.
9312
827f438f
GB
93132019-03-01 Gary Benson <gbenson@redhat.com>
9314
9315 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9316
92137da0
RO
93172019-02-28 Brian Vandenberg <phantall@gmail.com>
9318 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
9319
9320 PR gdb/8527
9321 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9322 set_sigint_trap, clear_sigint_trap.
9323
799efbe8
PW
93242019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9325
9326 * target.c (target_detach): Clear the regcache and the
9327 frame cache.
9328
8ed25214
PA
93292019-02-27 Pedro Alves <palves@redhat.com>
9330
9331 * utils.c (set_screen_size): When we cap the height/width sizes,
9332 tweak the corresponding command variable to show "unlimited":
9333
23031e31
SJ
93342019-02-27 Saagar Jha <saagar@saagarjha.com>
9335 Pedro Alves <palves@redhat.com>
9336
9337 * utils.c (set_screen_size): Reduce "infinite" rows and columns
9338 before calling rl_set_screen_size.
9339
6c28e44a
TT
93402019-02-27 Tom Tromey <tromey@adacore.com>
9341
9342 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9343 define.
9344 * python/py-value.c: Remove Python 2.4 workaround.
9345 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9346 workaround.
9347 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9348 Python 2.4 workaround.
9349 * python/python-internal.h: Remove Python 2.4 comment.
9350 (Py_ssize_t): Don't define.
9351 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9352 (gdb_Py_DECREF): Remove Python 2.4 workaround.
9353 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9354 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9355 * python/python.c (do_start_initialization): Remove Python 2.4
9356 workaround.
9357 * python/py-prettyprint.c (class dummy_python_frame): Remove.
9358 (print_children): Remove Python 2.4 workaround.
9359 * python/py-inferior.c (buffer_procs): Remove Python 2.4
9360 workaround.
9361 (CHARBUFFERPROC_NAME): Remove.
9362 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9363 Python 2.4 workaround.
9364
2c3fc25d 93652019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 9366
2c3fc25d
KB
9367 * NEWS: Note minimum Python version.
9368
6ca62222
KB
93692019-02-27 Kevin Buettner <kevinb@redhat.com>
9370
9371 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9372 code from these functions. Remove corresponding ifdefs. Use
9373 Py_buffer_up instead of explicit calls to PyBuffer_Release.
9374 Remove gotos and target of gotos.
9375 (infpy_search_memory): Likewise.
9376
f4bc7d2c
AB
93772019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9378
9379 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9380 (hppa_gdbarch_init): Don't register deleted functions with
9381 gdbarch.
9382
9734a586
AB
93832019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9384
9385 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9386 (h8300_unwind_sp): Delete.
9387 (h8300_dummy_id): Delete.
9388 (h8300_gdbarch_init): Don't register deleted functions with
9389 gdbarch.
9390
68b867f3
AB
93912019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9392
9393 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9394 (ft32_unwind_pc): Delete.
9395 (ft32_unwind_sp): Delete.
9396 (ft32_gdbarch_init): Don't register deleted functions with
9397 gdbarch.
9398
2fbe7ad0
AB
93992019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9400
9401 * gdb/frv-tdep.c (frv_dummy_id): Delete.
9402 (frv_unwind_pc): Delete.
9403 (frv_unwind_sp): Delete.
9404 (frv_gdbarch_init): Don't register deleted functions with
9405 gdbarch.
9406
76055cbe
AB
94072019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9408
9409 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9410 (riscv_unwind_pc): Delete.
9411 (riscv_unwind_sp): Delete.
9412 (riscv_gdbarch_init): Don't register deleted functions with
9413 gdbarch.
9414
4133e5a1
AB
94152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9416
9417 * gdb/csky-tdep.c (csky_dummy_id): Delete.
9418 (csky_unwind_pc): Delete.
9419 (csky_unwind_sp): Delete.
9420 (csky_gdbarch_init): Don't register deleted functions with
9421 gdbarch.
9422
8010f576
AB
94232019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9424
9425 * gdb/cris-tdep.c (cris_dummy_id): Delete.
9426 (cris_unwind_pc): Delete.
9427 (cris_unwind_sp): Delete.
9428 (cris_gdbarch_init): Don't register deleted functions with
9429 gdbarch.
9430
b56bf084
AB
94312019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9432
9433 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9434 (bfin_unwind_pc): Delete.
9435 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9436
a19a650f
AB
94372019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9438
9439 * gdb/arm-tdep.c (arm_dummy_id): Delete.
9440 (arm_unwind_pc): Delete.
9441 (arm_unwind_sp): Delete.
9442 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9443
f8278c3c
AB
94442019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9445
9446 * gdb/arc-tdep.c (arc_dummy_id): Delete.
9447 (arc_unwind_pc): Delete.
9448 (arc_unwind_sp): Delete.
9449 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9450
480e46cf
AB
94512019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9452
9453 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9454 (alpha_unwind_pc): Delete.
9455 (alpha_gdbarch_init): Don't register deleted functions with
9456 gdbarch.
9457
7a995095
AB
94582019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9459
9460 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9461 (aarch64_unwind_pc): Delete.
9462 (aarch64_unwind_sp): Delete.
9463 (aarch64_gdbarch_init): Don't register deleted functions with
9464 gdbarch.
9465
bf9a735e
AB
94662019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9467
9468 * gdbtypes.c (type_align): Don't consider static members when
9469 computing structure alignment.
9470
5561fc30
AB
94712019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9472
9473 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9474 return 0 for other types.
9475 * arch-utils.c (default_type_align): Always return 0.
9476 * gdbarch.h: Regenerate.
9477 * gdbarch.sh (type_align): Extend comment.
9478 * gdbtypes.c (type_align): Add additional comments, always call
9479 gdbarch_type_align before applying the default rules.
9480 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9481 generic code will then apply a suitable default.
9482 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9483 types, return 0 for other types.
9484
9335e75a
JB
94852019-02-27 Joel Brobecker <brobecker@adacore.com>
9486
9487 * NEWS: Create a new section for the next release branch.
9488 Rename the section of the current branch, now that it has
9489 been cut.
9490
3d34d8de
JB
94912019-02-27 Joel Brobecker <brobecker@adacore.com>
9492
9493 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9494 * version.in: Bump version to 8.3.50.DATE-git.
9495
143420fb
SM
94962019-02-26 Simon Marchi <simon.marchi@efficios.com>
9497
9498 * aix-thread.c (ptid_cmp): Remove unused variable.
9499 (get_signaled_thread): Likewise.
9500 (store_regs_user_thread): Likewise.
9501 (store_regs_kernel_thread): Likewise.
9502 (fetch_regs_kernel_thread): Remove shadowed variable.
9503
172fb711
AB
95042019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
9505
9506 * features/riscv/32bit-cpu.xml: Add register numbers.
9507 * features/riscv/32bit-fpu.c: Regenerate.
9508 * features/riscv/32bit-fpu.xml: Add register numbers.
9509 * features/riscv/64bit-cpu.xml: Add register numbers.
9510 * features/riscv/64bit-fpu.c: Regenerate.
9511 * features/riscv/64bit-fpu.xml: Add register numbers.
9512
26c89782
KB
95132019-02-26 Kevin Buettner <kevinb@redhat.com>
9514
af54ade9 9515 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
9516 * python/py-value.c (convert_buffer_and_type_to_value): New
9517 function.
9518 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9519 Add support for handling an optional second argument. Call
9520 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
9521 * python/python-internal.h (Py_buffer_deleter): New struct.
9522 (Py_buffer_up): New typedef.
9523
0f58c9e8
JB
95242019-02-25 John Baldwin <jhb@FreeBSD.org>
9525
9526 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9527 instead of releasing ownership.
9528
0a0f4c01
JR
95292019-02-25 Jordan Rupprecht <rupprecht@google.com>
9530
9531 * dwarf2read.c (open_and_init_dwp_file): Call
9532 elf_numsections instead of bfd_count_sections to initialize
9533 dwp_file->num_sections.
9534
cd5a152c
TT
95352019-02-25 Tom Tromey <tromey@adacore.com>
9536
9537 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9538
8a6a8513
SDJ
95392019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
9540
9541 * gcore.in: Add '--readnever' option when invoking GDB.
9542
04dcda9c
SM
95432019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9544
9545 * MAINTAINERS: Update my email address.
9546
07bc701d
SM
95472019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9548
9549 * build-id.c (build_id_to_debug_bfd_1): New function.
9550 (build_id_to_debug_bfd): Look for separate debug file in
9551 sysroot.
9552
c6f4a5d0
AB
95532019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
9554
9555 * gdbarch.sh: Update the copyright year range that is placed into
9556 generated files.
9557
9600246d
KS
95582019-02-22 Keith Seitz <keiths@redhat.com>
9559
9560 PR symtab/23853
9561 * linespec.c (create_sals_line_offset): Search for the default
9562 symtab's filename instead of its fullname.
9563
7557a514
AH
95642019-02-21 Alan Hayward <alan.hayward@arm.com>
9565
9566 * NEWS: Update style defaults.
9567
ee2bcb0c
AH
95682019-02-21 Alan Hayward <alan.hayward@arm.com>
9569
9570 * main.c (captured_main_1): Disable styling in batch mode.
9571
0c95f9ed
TT
95722019-02-20 Tom Tromey <tom@tromey.com>
9573
9574 * symtab.c (symtab_symbol_info): Fix typos.
9575
c763b894
TT
95762019-02-20 Tom Tromey <tromey@adacore.com>
9577
9578 * findcmd.c (_initialize_mem_search): Use upper case for
9579 metasyntactic variables.
9580
0ef8a082
AH
95812019-02-20 Alan Hayward <alan.hayward@arm.com>
9582
9583 * aarch64-tdep.c (aarch64_add_reggroups): New function.
9584 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9585
6caa91b6
SM
95862019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
9587
9588 * top.h (source_file_name): Change to std::string.
9589 * top.c (source_file_name): Likewise.
9590 (command_line_input): Adjust.
9591 * cli/cli-script.c (script_from_file): Adjust.
9592
98814c6c
TT
95932019-02-19 Tom Tromey <tromey@adacore.com>
9594
9595 * ravenscar-thread.c
9596 (ravenscar_thread_target::update_thread_list): Don't call
9597 ada_build_task_list.
9598 * ada-lang.h (ada_build_task_list): Don't declare.
9599 * ada-tasks.c (struct ada_tasks_inferior_data)
9600 <task_list_valid_p>: Now bool.
9601 (read_known_tasks, ada_task_list_changed)
9602 (ada_tasks_invalidate_inferior_data): Update.
9603 (read_known_tasks_array): Return bool.
9604 (read_known_tasks_list): Likewise.
9605 (read_known_tasks): Return void.
9606 (ada_build_task_list): Now static.
9607
70cd633e
AB
96082019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
9609
9610 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9611 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9612
040b3e95
PW
96132019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9614
9615 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9616 variant for ada_tasks_pspace_data_handle and
9617 ada_tasks_inferior_data_handle.
9618 (ada_tasks_pspace_data_cleanup): New function.
9619 (ada_tasks_inferior_data_cleanup): New function.
9620
9409233b
TT
96212019-02-17 Tom Tromey <tom@tromey.com>
9622
9623 * macrotab.h (macro_source_fullname): Return a std::string.
9624 * macrotab.c (macro_include, check_for_redefinition)
9625 (macro_undef, macro_lookup_definition, foreach_macro)
9626 (foreach_macro_in_scope): Update.
9627 (macro_source_fullname): Return a std::string.
9628 * macrocmd.c (show_pp_source_pos): Update.
9629
6506371f
TT
96302019-02-17 Tom Tromey <tom@tromey.com>
9631
9632 * macrocmd.c (show_pp_source_pos): Style the file names.
9633
0c820d67
TT
96342019-02-17 Tom Tromey <tom@tromey.com>
9635
9636 PR tui/24197:
9637 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9638
a0087920
TT
96392019-02-17 Tom Tromey <tom@tromey.com>
9640
9641 * ada-lang.c (user_select_syms): Use filtered printing.
9642 * utils.c (wrap_style): New global.
9643 (desired_style): Remove.
9644 (emit_style_escape): Add stream parameter.
9645 (set_output_style, reset_terminal_style, prompt_for_continue):
9646 Update.
9647 (flush_wrap_buffer): Only flush gdb_stdout.
9648 (wrap_here): Set wrap_style.
9649 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
9650 treat escape sequences as a character. Change when wrap buffer is
9651 flushed.
9652 (fputs_styled): Do not set the output style when the default is
9653 requested.
9654 * ui-style.h (struct ui_file_style) <is_default>: New method.
9655 * source.c (print_source_lines_base): Emit escape sequences in one
9656 piece.
9657
75ba10dc
JB
96582019-02-17 Joel Brobecker <brobecker@adacore.com>
9659
9660 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9661 integers and enumeration types.
9662
a2cd4f14
JB
96632019-02-17 Joel Brobecker <brobecker@adacore.com>
9664
9665 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9666 instead of lookup_symbol_in_language
9667 (do_exact_match): New function.
9668 (ada_get_symbol_name_matcher): Return do_exact_match when
9669 doing a verbatim match.
9670
485b851b
TT
96712019-02-15 Tom Tromey <tromey@adacore.com>
9672
9673 * ravenscar-thread.c (ravenscar_thread_target::resume)
9674 (ravenscar_thread_target::wait): Special case wildcard requests.
9675
0b790b1e
TT
96762019-02-15 Tom Tromey <tromey@adacore.com>
9677
9678 * ravenscar-thread.c (base_ptid): Remove.
9679 (struct ravenscar_thread_target) <close>: New method.
9680 <m_base_ptid>: New member.
9681 <update_inferior_ptid, active_task, task_is_currently_active,
9682 runtime_initialized>: Declare methods.
9683 <ravenscar_thread_target>: Add constructor.
9684 (ravenscar_thread_target::task_is_currently_active)
9685 (ravenscar_thread_target::update_inferior_ptid)
9686 (ravenscar_runtime_initialized): Rename. Now methods.
9687 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9688 (ravenscar_thread_target::update_thread_list): Update.
9689 (ravenscar_thread_target::active_task): Now method.
9690 (ravenscar_thread_target::store_registers)
9691 (ravenscar_thread_target::prepare_to_store)
9692 (ravenscar_thread_target::prepare_to_store)
9693 (ravenscar_thread_target::mourn_inferior): Update.
9694 (ravenscar_inferior_created): Use "new" to create target.
9695 (ravenscar_thread_target::get_ada_task_ptid): Update.
9696 (_initialize_ravenscar): Don't initialize base_ptid.
9697 (ravenscar_ops): Remove global.
9698
dea57a62
TT
96992019-02-15 Tom Tromey <tromey@adacore.com>
9700
9701 * target.h (push_target): Declare new overload.
9702 * target.c (push_target): New overload, taking an rvalue reference.
9703 * remote.c (remote_target::open_1): Use push_target overload.
9704 * corelow.c (core_target_open): Use push_target overload.
9705
989f3c58
TT
97062019-02-15 Tom Tromey <tromey@adacore.com>
9707
9708 * ravenscar-thread.c (is_ravenscar_task)
9709 (ravenscar_task_is_currently_active): Return bool.
9710 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9711 (_initialize_ravenscar): Remove "(void)".
9712 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9713 Return bool.
9714
6cbcc006
TT
97152019-02-15 Tom Tromey <tromey@adacore.com>
9716
9717 * ravenscar-thread.c (ravenscar_runtime_initializer)
9718 (has_ravenscar_runtime, get_running_thread_id)
9719 (ravenscar_thread_target::resume): Fix indentation.
9720
7657f14d
TT
97212019-02-15 Tom Tromey <tromey@adacore.com>
9722
9723 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9724 from ravenscar_arch_ops.
9725 (sparc_ravenscar_ops::fetch_registers)
9726 (sparc_ravenscar_ops::store_registers): Now methods.
9727 (sparc_ravenscar_prepare_to_store): Remove.
9728 (sparc_ravenscar_ops): Redefine.
9729 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9730 methods and destructor. Remove members.
9731 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9732 (ravenscar_thread_target::store_registers)
9733 (ravenscar_thread_target::prepare_to_store): Update.
9734 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9735 Remove.
9736 (struct ppc_ravenscar_powerpc_ops): Derive from
9737 ravenscar_arch_ops.
9738 (ppc_ravenscar_powerpc_ops::fetch_registers)
9739 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9740 (ppc_ravenscar_powerpc_ops): Redefine.
9741 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9742 (ppc_ravenscar_e500_ops::fetch_registers)
9743 (ppc_ravenscar_e500_ops::store_registers): Now methods.
9744 (ppc_ravenscar_e500_ops): Redefine.
9745 * aarch64-ravenscar-thread.c
9746 (aarch64_ravenscar_generic_prepare_to_store): Remove.
9747 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9748 (aarch64_ravenscar_fetch_registers)
9749 (aarch64_ravenscar_store_registers): Now methods.
9750 (aarch64_ravenscar_ops): Redefine.
9751
5b6ea500
TT
97522019-02-15 Tom Tromey <tromey@adacore.com>
9753
9754 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9755 (ravenscar_thread_target::stopped_by_hw_breakpoint)
9756 (ravenscar_thread_target::stopped_by_watchpoint)
9757 (ravenscar_thread_target::stopped_data_address)
9758 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9759
e397fd39
TT
97602019-02-15 Tom Tromey <tromey@adacore.com>
9761
9762 * ravenscar-thread.c: Fix some typos.
9763
cc12f4a8
TT
97642019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9765 Tom Tromey <tromey@adacore.com>
9766
9767 * ada-lang.c (ada_exception_sal): Change addr_string to a
9768 std::string.
9769 (create_ada_exception_catchpoint): Update.
9770
5f486660
TT
97712019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9772 Tom Tromey <tromey@adacore.com>
9773
9774 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9775 (bp_location_ops): Remove.
9776 (base_breakpoint_allocate_location): Update.
9777 (free_bp_location): Update.
9778 * ada-lang.c (class ada_catchpoint_location)
9779 <ada_catchpoint_location>: Remove ops parameter.
9780 (ada_catchpoint_location_dtor): Remove.
9781 (ada_catchpoint_location_ops): Remove.
9782 (allocate_location_exception): Update.
9783 * breakpoint.h (struct bp_location_ops): Remove.
9784 (class bp_location) <bp_location>: Remove bp_location_ops
9785 parameter.
9786 <~bp_location>: Add destructor.
9787 <ops>: Remove.
9788
b671c7fb
TS
97892019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9790 Pedro Alves <palves@redhat.com>
9791
9792 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9793 'PATH_MAX'.
9794
8071c5ce
DM
97952019-02-14 David Michael <fedora.dm0@gmail.com>
9796 Samuel Thibault <samuel.thibault@gnu.org>
9797 Thomas Schwinge <thomas@codesourcery.com>
9798
9799 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9800 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9801
b1041ae0
TS
98022019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9803
924514e1
TS
9804 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9805 (check_empty): Use "const char *".
9806
c29ee8d4
TS
9807 * gnu-nat.c (gnu_nat_target::detach): Instead of
9808 'detach_inferior (pid)' call
9809 'detach_inferior (find_inferior_pid (pid))'.
9810
6c6ef69f
TS
9811 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9812 'nat/fork-inferior.o'.
9813 * gnu-nat.c: #include "nat/fork-inferior.h".
9814
2d0a338c
TS
9815 * gnu-nat.c (gnu_nat_target::detach): Instead of
9816 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9817 * gnu-nat.h: #include "inf-child.h".
9818 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9819 'i386_gnu_nat_target::fetch_registers'.
9820 (gnu_store_registers): Rename/move to
9821 'i386_gnu_nat_target::store_registers'.
9822
cabb5f06
TS
9823 * config/i386/nm-i386gnu.h: Don't "#include" any files.
9824 * gnu-nat.h (mach_thread_info): New function.
9825 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9826
b1041ae0
TS
9827 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9828
2988d01e
KF
98292019-02-14 Frederic Konrad <konrad@adacore.com>
9830
9831 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9832
c559d709
JB
98332019-02-14 Joel Brobecker <brobecker@adacore.com>
9834
9835 * windows-nat.c (windows_add_thread): Add new parameter
9836 "main_thread_p" with default value set to false. Update
9837 function documentation as well as all callers.
9838 (windows_delete_thread): Likewise.
9839 (fake_create_process): Update call to windows_add_thread.
9840 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9841 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9842 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9843 call to windows_delete_thread.
9844
007024cc
SM
98452019-02-13 Simon Marchi <simon.marchi@ericsson.com>
9846
9847 * MAINTAINERS: Add Andrew Burgess as global maintainer.
9848
f62318e9
JB
98492019-02-12 John Baldwin <jhb@FreeBSD.org>
9850
9851 * symfile.c (find_separate_debug_file): Use canonical path of
9852 sysroot with child_path instead of gdb_sysroot if it is valid.
9853
cd4b7848
JB
98542019-02-12 John Baldwin <jhb@FreeBSD.org>
9855
9856 * symfile.c (find_separate_debug_file): Use child_path to
9857 determine if an object file is under a sysroot.
9858
efac4bfe
JB
98592019-02-12 John Baldwin <jhb@FreeBSD.org>
9860
9861 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9862 unittests/child-path-selftests.c.
9863 * common/pathstuff.c (child_path): New function.
9864 * common/pathstuff.h (child_path): New prototype.
9865 * unittests/child-path-selftests.c: New file.
9866
402d2bfe
JB
98672019-02-12 John Baldwin <jhb@FreeBSD.org>
9868
9869 * symfile.c (find_separate_debug_file): Look for separate debug
9870 files in debug directories under the sysroot.
9871
1ed9f74e
PW
98722019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9873
9874 * symtab.h (struct minimal_symbol data_p): New const method.
9875 (struct minimal_symbol text_p): Likewise.
9876 * symtab.c (output_source_filename): Use file name style
9877 to print file name.
9878 (print_symbol_info): Likewise.
9879 (print_msymbol_info): Use address style to print addresses.
9880 Use function name style to print executable text symbols.
9881 (expand_symtab_containing_pc): Use data_p.
9882 (find_pc_sect_compunit_symtab): Likewise.
9883
2636d81d
PW
98842019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9885
9886 * breakpoint.c (describe_other_breakpoints): Use address style
9887 to print addresses.
9888 (say_where): Likewise.
9889
ac8c53cc
PW
98902019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9891
9892 * ada-typeprint.c (print_func_type): Print function name
9893 style to print function name.
9894 * c-typeprint.c (c_print_type_1): Likewise.
9895
ea638c43
AH
98962019-02-11 Alan Hayward <alan.hayward@arm.com>
9897
9898 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9899 for execve.
9900
ab759ca8
PW
99012019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9902
9903 * c-exp.y (direct_abs_decl): Use emplace_back to record the
9904 type_stack.
9905
aff29d1c
JB
99062019-02-10 Joel Brobecker <brobecker@adacore.com>
9907
9908 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9909 TYPE_CODE_REF types.
9910
617126bc
JW
99112019-02-08 Jim Wilson <jimw@sifive.com>
9912
9913 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9914 (riscv_linux_fregset): New.
9915 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9916
46e3ed7f
TT
99172019-02-07 Tom Tromey <tom@tromey.com>
9918
9919 * thread.c (thread_cancel_execution_command): Update.
9920 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9921 methods.
9922 (struct thread_fsm_ops): Remove.
9923 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9924 (thread_fsm_should_stop, thread_fsm_return_value)
9925 (thread_fsm_set_finished, thread_fsm_finished_p)
9926 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9927 Don't declare.
9928 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9929 * infrun.c (clear_proceed_status_thread)
9930 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9931 (print_stop_event): Update.
9932 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9933 Add constructor.
9934 (step_command_fsm_ops): Remove.
9935 (new_step_command_fsm): Remove.
9936 (step_1): Update.
9937 (step_command_fsm::should_stop): Rename from
9938 step_command_fsm_should_stop.
9939 (step_command_fsm::clean_up): Rename from
9940 step_command_fsm_clean_up.
9941 (step_command_fsm::do_async_reply_reason): Rename from
9942 step_command_fsm_async_reply_reason.
9943 (struct until_next_fsm): Inherit from thread_fsm. Add
9944 constructor.
9945 (until_next_fsm_ops): Remove.
9946 (new_until_next_fsm): Remove.
9947 (until_next_fsm::should_stop): Rename from
9948 until_next_fsm_should_stop.
9949 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9950 (until_next_fsm::do_async_reply_reason): Rename from
9951 until_next_fsm_async_reply_reason.
9952 (struct finish_command_fsm): Inherit from thread_fsm. Add
9953 constructor. Change type of breakpoint.
9954 (finish_command_fsm_ops): Remove.
9955 (new_finish_command_fsm): Remove.
9956 (finish_command_fsm::should_stop): Rename from
9957 finish_command_fsm_should_stop.
9958 (finish_command_fsm::clean_up): Rename from
9959 finish_command_fsm_clean_up.
9960 (finish_command_fsm::return_value): Rename from
9961 finish_command_fsm_return_value.
9962 (finish_command_fsm::do_async_reply_reason): Rename from
9963 finish_command_fsm_async_reply_reason.
9964 (finish_command): Update.
9965 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9966 Add constructor.
9967 (call_thread_fsm_ops): Remove.
9968 (call_thread_fsm::call_thread_fsm): Rename from
9969 new_call_thread_fsm.
9970 (call_thread_fsm::should_stop): Rename from
9971 call_thread_fsm_should_stop.
9972 (call_thread_fsm::should_notify_stop): Rename from
9973 call_thread_fsm_should_notify_stop.
9974 (run_inferior_call, call_function_by_hand_dummy): Update.
9975 * cli/cli-interp.c (should_print_stop_to_console): Update.
9976 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9977 Add constructor. Change type of location_breakpoint,
9978 caller_breakpoint.
9979 (until_break_fsm_ops): Remove.
9980 (new_until_break_fsm): Remove.
9981 (until_break_fsm::should_stop): Rename from
9982 until_break_fsm_should_stop.
9983 (until_break_fsm::clean_up): Rename from
9984 until_break_fsm_clean_up.
9985 (until_break_fsm::do_async_reply_reason): Rename from
9986 until_break_fsm_async_reply_reason.
9987 (until_break_command): Update.
9988 * thread-fsm.c: Remove.
9989 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9990
1a5c2598
TT
99912019-02-07 Tom Tromey <tom@tromey.com>
9992
9993 * yy-remap.h: Add include guard.
9994 * xtensa-tdep.h: Add include guard.
9995 * xcoffread.h: Rename include guard.
9996 * varobj-iter.h: Add include guard.
9997 * tui/tui.h: Rename include guard.
9998 * tui/tui-winsource.h: Rename include guard.
9999 * tui/tui-wingeneral.h: Rename include guard.
10000 * tui/tui-windata.h: Rename include guard.
10001 * tui/tui-win.h: Rename include guard.
10002 * tui/tui-stack.h: Rename include guard.
10003 * tui/tui-source.h: Rename include guard.
10004 * tui/tui-regs.h: Rename include guard.
10005 * tui/tui-out.h: Rename include guard.
10006 * tui/tui-layout.h: Rename include guard.
10007 * tui/tui-io.h: Rename include guard.
10008 * tui/tui-hooks.h: Rename include guard.
10009 * tui/tui-file.h: Rename include guard.
10010 * tui/tui-disasm.h: Rename include guard.
10011 * tui/tui-data.h: Rename include guard.
10012 * tui/tui-command.h: Rename include guard.
10013 * tic6x-tdep.h: Add include guard.
10014 * target/waitstatus.h: Rename include guard.
10015 * target/wait.h: Rename include guard.
10016 * target/target.h: Rename include guard.
10017 * target/resume.h: Rename include guard.
10018 * target-float.h: Rename include guard.
10019 * stabsread.h: Add include guard.
10020 * rs6000-tdep.h: Add include guard.
10021 * riscv-fbsd-tdep.h: Add include guard.
10022 * regformats/regdef.h: Rename include guard.
10023 * record.h: Rename include guard.
10024 * python/python.h: Rename include guard.
10025 * python/python-internal.h: Rename include guard.
10026 * python/py-stopevent.h: Rename include guard.
10027 * python/py-ref.h: Rename include guard.
10028 * python/py-record.h: Rename include guard.
10029 * python/py-record-full.h: Rename include guard.
10030 * python/py-record-btrace.h: Rename include guard.
10031 * python/py-instruction.h: Rename include guard.
10032 * python/py-events.h: Rename include guard.
10033 * python/py-event.h: Rename include guard.
10034 * procfs.h: Add include guard.
10035 * proc-utils.h: Add include guard.
10036 * p-lang.h: Add include guard.
10037 * or1k-tdep.h: Rename include guard.
10038 * observable.h: Rename include guard.
10039 * nto-tdep.h: Rename include guard.
10040 * nat/x86-linux.h: Rename include guard.
10041 * nat/x86-linux-dregs.h: Rename include guard.
10042 * nat/x86-gcc-cpuid.h: Add include guard.
10043 * nat/x86-dregs.h: Rename include guard.
10044 * nat/x86-cpuid.h: Rename include guard.
10045 * nat/ppc-linux.h: Rename include guard.
10046 * nat/mips-linux-watch.h: Rename include guard.
10047 * nat/linux-waitpid.h: Rename include guard.
10048 * nat/linux-ptrace.h: Rename include guard.
10049 * nat/linux-procfs.h: Rename include guard.
10050 * nat/linux-osdata.h: Rename include guard.
10051 * nat/linux-nat.h: Rename include guard.
10052 * nat/linux-namespaces.h: Rename include guard.
10053 * nat/linux-btrace.h: Rename include guard.
10054 * nat/glibc_thread_db.h: Rename include guard.
10055 * nat/gdb_thread_db.h: Rename include guard.
10056 * nat/gdb_ptrace.h: Rename include guard.
10057 * nat/fork-inferior.h: Rename include guard.
10058 * nat/amd64-linux-siginfo.h: Rename include guard.
10059 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10060 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10061 * nat/aarch64-linux.h: Rename include guard.
10062 * nat/aarch64-linux-hw-point.h: Rename include guard.
10063 * mn10300-tdep.h: Add include guard.
10064 * mips-linux-tdep.h: Add include guard.
10065 * mi/mi-parse.h: Rename include guard.
10066 * mi/mi-out.h: Rename include guard.
10067 * mi/mi-main.h: Rename include guard.
10068 * mi/mi-interp.h: Rename include guard.
10069 * mi/mi-getopt.h: Rename include guard.
10070 * mi/mi-console.h: Rename include guard.
10071 * mi/mi-common.h: Rename include guard.
10072 * mi/mi-cmds.h: Rename include guard.
10073 * mi/mi-cmd-break.h: Rename include guard.
10074 * m2-lang.h: Add include guard.
10075 * location.h: Rename include guard.
10076 * linux-record.h: Rename include guard.
10077 * linux-nat.h: Add include guard.
10078 * linux-fork.h: Add include guard.
10079 * i386-darwin-tdep.h: Rename include guard.
10080 * hppa-linux-offsets.h: Add include guard.
10081 * guile/guile.h: Rename include guard.
10082 * guile/guile-internal.h: Rename include guard.
10083 * gnu-nat.h: Rename include guard.
10084 * gdb-stabs.h: Rename include guard.
10085 * frv-tdep.h: Add include guard.
10086 * f-lang.h: Add include guard.
10087 * event-loop.h: Add include guard.
10088 * darwin-nat.h: Rename include guard.
10089 * cp-abi.h: Rename include guard.
10090 * config/sparc/nm-sol2.h: Rename include guard.
10091 * config/nm-nto.h: Rename include guard.
10092 * config/nm-linux.h: Add include guard.
10093 * config/i386/nm-i386gnu.h: Rename include guard.
10094 * config/djgpp/nl_types.h: Rename include guard.
10095 * config/djgpp/langinfo.h: Rename include guard.
10096 * compile/gcc-cp-plugin.h: Add include guard.
10097 * compile/gcc-c-plugin.h: Add include guard.
10098 * compile/compile.h: Rename include guard.
10099 * compile/compile-object-run.h: Rename include guard.
10100 * compile/compile-object-load.h: Rename include guard.
10101 * compile/compile-internal.h: Rename include guard.
10102 * compile/compile-cplus.h: Rename include guard.
10103 * compile/compile-c.h: Rename include guard.
10104 * common/xml-utils.h: Rename include guard.
10105 * common/x86-xstate.h: Rename include guard.
10106 * common/version.h: Rename include guard.
10107 * common/vec.h: Rename include guard.
10108 * common/tdesc.h: Rename include guard.
10109 * common/selftest.h: Rename include guard.
10110 * common/scoped_restore.h: Rename include guard.
10111 * common/scoped_mmap.h: Rename include guard.
10112 * common/scoped_fd.h: Rename include guard.
10113 * common/safe-iterator.h: Rename include guard.
10114 * common/run-time-clock.h: Rename include guard.
10115 * common/refcounted-object.h: Rename include guard.
10116 * common/queue.h: Rename include guard.
10117 * common/ptid.h: Rename include guard.
10118 * common/print-utils.h: Rename include guard.
10119 * common/preprocessor.h: Rename include guard.
10120 * common/pathstuff.h: Rename include guard.
10121 * common/observable.h: Rename include guard.
10122 * common/netstuff.h: Rename include guard.
10123 * common/job-control.h: Rename include guard.
10124 * common/host-defs.h: Rename include guard.
10125 * common/gdb_wait.h: Rename include guard.
10126 * common/gdb_vecs.h: Rename include guard.
10127 * common/gdb_unlinker.h: Rename include guard.
10128 * common/gdb_unique_ptr.h: Rename include guard.
10129 * common/gdb_tilde_expand.h: Rename include guard.
10130 * common/gdb_sys_time.h: Rename include guard.
10131 * common/gdb_string_view.h: Rename include guard.
10132 * common/gdb_splay_tree.h: Rename include guard.
10133 * common/gdb_setjmp.h: Rename include guard.
10134 * common/gdb_ref_ptr.h: Rename include guard.
10135 * common/gdb_optional.h: Rename include guard.
10136 * common/gdb_locale.h: Rename include guard.
10137 * common/gdb_assert.h: Rename include guard.
10138 * common/filtered-iterator.h: Rename include guard.
10139 * common/filestuff.h: Rename include guard.
10140 * common/fileio.h: Rename include guard.
10141 * common/environ.h: Rename include guard.
10142 * common/common-utils.h: Rename include guard.
10143 * common/common-types.h: Rename include guard.
10144 * common/common-regcache.h: Rename include guard.
10145 * common/common-inferior.h: Rename include guard.
10146 * common/common-gdbthread.h: Rename include guard.
10147 * common/common-exceptions.h: Rename include guard.
10148 * common/common-defs.h: Rename include guard.
10149 * common/common-debug.h: Rename include guard.
10150 * common/cleanups.h: Rename include guard.
10151 * common/buffer.h: Rename include guard.
10152 * common/btrace-common.h: Rename include guard.
10153 * common/break-common.h: Rename include guard.
10154 * cli/cli-utils.h: Rename include guard.
10155 * cli/cli-style.h: Rename include guard.
10156 * cli/cli-setshow.h: Rename include guard.
10157 * cli/cli-script.h: Rename include guard.
10158 * cli/cli-interp.h: Rename include guard.
10159 * cli/cli-decode.h: Rename include guard.
10160 * cli/cli-cmds.h: Rename include guard.
10161 * charset-list.h: Add include guard.
10162 * buildsym-legacy.h: Rename include guard.
10163 * bfin-tdep.h: Add include guard.
10164 * ax.h: Rename include guard.
10165 * arm-linux-tdep.h: Add include guard.
10166 * arm-fbsd-tdep.h: Add include guard.
10167 * arch/xtensa.h: Rename include guard.
10168 * arch/tic6x.h: Add include guard.
10169 * arch/i386.h: Add include guard.
10170 * arch/arm.h: Rename include guard.
10171 * arch/arm-linux.h: Rename include guard.
10172 * arch/arm-get-next-pcs.h: Rename include guard.
10173 * arch/amd64.h: Add include guard.
10174 * arch/aarch64-insn.h: Rename include guard.
10175 * arch-utils.h: Rename include guard.
10176 * annotate.h: Add include guard.
10177 * amd64-darwin-tdep.h: Rename include guard.
10178 * aarch64-linux-tdep.h: Add include guard.
10179 * aarch64-fbsd-tdep.h: Add include guard.
10180 * aarch32-linux-nat.h: Add include guard.
10181
ab9268d2
PW
101822019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10183
10184 * macrotab.c (macro_define_internal): New function that
10185 factorizes macro_define_object_internal and macro_define_function
10186 code.
10187 (macro_define_object_internal): Use macro_define_internal.
10188 (macro_define_function): Likewise.
10189
bb0da2b4
PW
101902019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10191
10192 * macrocmd.c (extract_identifier): Return
10193 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10194 callers.
10195
424eb552
JB
101962019-02-06 John Baldwin <jhb@FreeBSD.org>
10197
10198 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10199
1688cb29
TT
102002019-02-05 Tom Tromey <tom@tromey.com>
10201
10202 * target.c (target_stack::unpush): Move assertion earlier.
10203
b5eba2d8
TT
102042019-01-30 Tom Tromey <tom@tromey.com>
10205
10206 PR python/23615:
10207 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10208 (gdbpy_parse_and_eval): Likewise.
10209 * python/python-internal.h (gdbpy_allow_threads): New class.
10210
7054e2ff
JB
102112019-01-28 John Baldwin <jhb@FreeBSD.org>
10212
10213 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10214 (aarch64_fbsd_fpregmap): Move earlier.
10215 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10216 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10217 instead of individual calls to trad_frame_set_reg_addr.
10218 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10219 earlier.
10220 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10221 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10222 instead of individual calls to trad_frame_set_reg_addr.
10223
36c25ffa
AH
102242019-01-28 Alan Hayward <alan.hayward@arm.com>
10225
10226 * CONTRIBUTE: Replace contribution list with wiki link.
10227
a0707f3c
TT
102282019-01-25 Tom Tromey <tom@tromey.com>
10229
10230 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10231
0747795c
TT
102322019-01-25 Tom Tromey <tom@tromey.com>
10233
10234 * xtensa-linux-nat.c: Fix common/ includes.
10235 * xml-support.h: Fix common/ includes.
10236 * xml-support.c: Fix common/ includes.
10237 * x86-linux-nat.c: Fix common/ includes.
10238 * windows-nat.c: Fix common/ includes.
10239 * varobj.h: Fix common/ includes.
10240 * varobj.c: Fix common/ includes.
10241 * value.c: Fix common/ includes.
10242 * valops.c: Fix common/ includes.
10243 * utils.c: Fix common/ includes.
10244 * unittests/xml-utils-selftests.c: Fix common/ includes.
10245 * unittests/utils-selftests.c: Fix common/ includes.
10246 * unittests/unpack-selftests.c: Fix common/ includes.
10247 * unittests/tracepoint-selftests.c: Fix common/ includes.
10248 * unittests/style-selftests.c: Fix common/ includes.
10249 * unittests/string_view-selftests.c: Fix common/ includes.
10250 * unittests/scoped_restore-selftests.c: Fix common/ includes.
10251 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10252 * unittests/scoped_fd-selftests.c: Fix common/ includes.
10253 * unittests/rsp-low-selftests.c: Fix common/ includes.
10254 * unittests/parse-connection-spec-selftests.c: Fix common/
10255 includes.
10256 * unittests/optional-selftests.c: Fix common/ includes.
10257 * unittests/offset-type-selftests.c: Fix common/ includes.
10258 * unittests/observable-selftests.c: Fix common/ includes.
10259 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10260 * unittests/memrange-selftests.c: Fix common/ includes.
10261 * unittests/memory-map-selftests.c: Fix common/ includes.
10262 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10263 * unittests/function-view-selftests.c: Fix common/ includes.
10264 * unittests/environ-selftests.c: Fix common/ includes.
10265 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10266 * unittests/common-utils-selftests.c: Fix common/ includes.
10267 * unittests/cli-utils-selftests.c: Fix common/ includes.
10268 * unittests/array-view-selftests.c: Fix common/ includes.
10269 * ui-file.c: Fix common/ includes.
10270 * tui/tui-io.c: Fix common/ includes.
10271 * tracepoint.h: Fix common/ includes.
10272 * tracepoint.c: Fix common/ includes.
10273 * tracefile-tfile.c: Fix common/ includes.
10274 * top.h: Fix common/ includes.
10275 * top.c: Fix common/ includes.
10276 * thread.c: Fix common/ includes.
10277 * target/waitstatus.h: Fix common/ includes.
10278 * target/waitstatus.c: Fix common/ includes.
10279 * target.h: Fix common/ includes.
10280 * target.c: Fix common/ includes.
10281 * target-memory.c: Fix common/ includes.
10282 * target-descriptions.c: Fix common/ includes.
10283 * symtab.h: Fix common/ includes.
10284 * symfile.c: Fix common/ includes.
10285 * stap-probe.c: Fix common/ includes.
10286 * spu-linux-nat.c: Fix common/ includes.
10287 * sparc-nat.c: Fix common/ includes.
10288 * source.c: Fix common/ includes.
10289 * solib.c: Fix common/ includes.
10290 * solib-target.c: Fix common/ includes.
10291 * ser-unix.c: Fix common/ includes.
10292 * ser-tcp.c: Fix common/ includes.
10293 * ser-pipe.c: Fix common/ includes.
10294 * ser-base.c: Fix common/ includes.
10295 * selftest-arch.c: Fix common/ includes.
10296 * s12z-tdep.c: Fix common/ includes.
10297 * rust-exp.y: Fix common/ includes.
10298 * rs6000-aix-tdep.c: Fix common/ includes.
10299 * riscv-tdep.c: Fix common/ includes.
10300 * remote.c: Fix common/ includes.
10301 * remote-notif.h: Fix common/ includes.
10302 * remote-fileio.h: Fix common/ includes.
10303 * remote-fileio.c: Fix common/ includes.
10304 * regcache.h: Fix common/ includes.
10305 * regcache.c: Fix common/ includes.
10306 * record-btrace.c: Fix common/ includes.
10307 * python/python.c: Fix common/ includes.
10308 * python/py-type.c: Fix common/ includes.
10309 * python/py-inferior.c: Fix common/ includes.
10310 * progspace.h: Fix common/ includes.
10311 * producer.c: Fix common/ includes.
10312 * procfs.c: Fix common/ includes.
10313 * proc-api.c: Fix common/ includes.
10314 * printcmd.c: Fix common/ includes.
10315 * ppc-linux-nat.c: Fix common/ includes.
10316 * parser-defs.h: Fix common/ includes.
10317 * osdata.c: Fix common/ includes.
10318 * obsd-nat.c: Fix common/ includes.
10319 * nat/x86-linux.c: Fix common/ includes.
10320 * nat/x86-linux-dregs.c: Fix common/ includes.
10321 * nat/x86-dregs.h: Fix common/ includes.
10322 * nat/x86-dregs.c: Fix common/ includes.
10323 * nat/ppc-linux.c: Fix common/ includes.
10324 * nat/mips-linux-watch.h: Fix common/ includes.
10325 * nat/mips-linux-watch.c: Fix common/ includes.
10326 * nat/linux-waitpid.c: Fix common/ includes.
10327 * nat/linux-ptrace.h: Fix common/ includes.
10328 * nat/linux-ptrace.c: Fix common/ includes.
10329 * nat/linux-procfs.c: Fix common/ includes.
10330 * nat/linux-personality.c: Fix common/ includes.
10331 * nat/linux-osdata.c: Fix common/ includes.
10332 * nat/linux-namespaces.c: Fix common/ includes.
10333 * nat/linux-btrace.h: Fix common/ includes.
10334 * nat/linux-btrace.c: Fix common/ includes.
10335 * nat/fork-inferior.c: Fix common/ includes.
10336 * nat/amd64-linux-siginfo.c: Fix common/ includes.
10337 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10338 * nat/aarch64-linux.c: Fix common/ includes.
10339 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10340 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10341 * namespace.h: Fix common/ includes.
10342 * mips-linux-tdep.c: Fix common/ includes.
10343 * minsyms.c: Fix common/ includes.
10344 * mi/mi-parse.h: Fix common/ includes.
10345 * mi/mi-main.c: Fix common/ includes.
10346 * mi/mi-cmd-env.c: Fix common/ includes.
10347 * memrange.h: Fix common/ includes.
10348 * memattr.c: Fix common/ includes.
10349 * maint.h: Fix common/ includes.
10350 * maint.c: Fix common/ includes.
10351 * main.c: Fix common/ includes.
10352 * machoread.c: Fix common/ includes.
10353 * location.c: Fix common/ includes.
10354 * linux-thread-db.c: Fix common/ includes.
10355 * linux-nat.c: Fix common/ includes.
10356 * linux-fork.c: Fix common/ includes.
10357 * inline-frame.c: Fix common/ includes.
10358 * infrun.c: Fix common/ includes.
10359 * inflow.c: Fix common/ includes.
10360 * inferior.h: Fix common/ includes.
10361 * inferior.c: Fix common/ includes.
10362 * infcmd.c: Fix common/ includes.
10363 * inf-ptrace.c: Fix common/ includes.
10364 * inf-child.c: Fix common/ includes.
10365 * ia64-linux-nat.c: Fix common/ includes.
10366 * i387-tdep.c: Fix common/ includes.
10367 * i386-tdep.c: Fix common/ includes.
10368 * i386-linux-tdep.c: Fix common/ includes.
10369 * i386-linux-nat.c: Fix common/ includes.
10370 * i386-go32-tdep.c: Fix common/ includes.
10371 * i386-fbsd-tdep.c: Fix common/ includes.
10372 * i386-fbsd-nat.c: Fix common/ includes.
10373 * guile/scm-type.c: Fix common/ includes.
10374 * guile/guile.c: Fix common/ includes.
10375 * go32-nat.c: Fix common/ includes.
10376 * gnu-nat.c: Fix common/ includes.
10377 * gdbthread.h: Fix common/ includes.
10378 * gdbarch-selftests.c: Fix common/ includes.
10379 * gdb_usleep.c: Fix common/ includes.
10380 * gdb_select.h: Fix common/ includes.
10381 * gdb_bfd.c: Fix common/ includes.
10382 * gcore.c: Fix common/ includes.
10383 * fork-child.c: Fix common/ includes.
10384 * findvar.c: Fix common/ includes.
10385 * fbsd-nat.c: Fix common/ includes.
10386 * event-top.c: Fix common/ includes.
10387 * event-loop.c: Fix common/ includes.
10388 * dwarf2read.c: Fix common/ includes.
10389 * dwarf2loc.c: Fix common/ includes.
10390 * dwarf2-frame.c: Fix common/ includes.
10391 * dwarf-index-cache.c: Fix common/ includes.
10392 * dtrace-probe.c: Fix common/ includes.
10393 * disasm-selftests.c: Fix common/ includes.
10394 * defs.h: Fix common/ includes.
10395 * csky-tdep.c: Fix common/ includes.
10396 * cp-valprint.c: Fix common/ includes.
10397 * cp-support.h: Fix common/ includes.
10398 * cp-support.c: Fix common/ includes.
10399 * corelow.c: Fix common/ includes.
10400 * completer.h: Fix common/ includes.
10401 * completer.c: Fix common/ includes.
10402 * compile/compile.c: Fix common/ includes.
10403 * compile/compile-loc2c.c: Fix common/ includes.
10404 * compile/compile-cplus-types.c: Fix common/ includes.
10405 * compile/compile-cplus-symbols.c: Fix common/ includes.
10406 * command.h: Fix common/ includes.
10407 * cli/cli-dump.c: Fix common/ includes.
10408 * cli/cli-cmds.c: Fix common/ includes.
10409 * charset.c: Fix common/ includes.
10410 * build-id.c: Fix common/ includes.
10411 * btrace.h: Fix common/ includes.
10412 * btrace.c: Fix common/ includes.
10413 * breakpoint.h: Fix common/ includes.
10414 * breakpoint.c: Fix common/ includes.
10415 * ax.h:
10416 (enum agent_op): Fix common/ includes.
10417 * ax-general.c (struct aop_map): Fix common/ includes.
10418 * ax-gdb.c: Fix common/ includes.
10419 * auxv.c: Fix common/ includes.
10420 * auto-load.c: Fix common/ includes.
10421 * arm-tdep.c: Fix common/ includes.
10422 * arch/riscv.c: Fix common/ includes.
10423 * arch/ppc-linux-common.c: Fix common/ includes.
10424 * arch/i386.c: Fix common/ includes.
10425 * arch/arm.c: Fix common/ includes.
10426 * arch/arm-linux.c: Fix common/ includes.
10427 * arch/arm-get-next-pcs.c: Fix common/ includes.
10428 * arch/amd64.c: Fix common/ includes.
10429 * arch/aarch64.c: Fix common/ includes.
10430 * arch/aarch64-insn.c: Fix common/ includes.
10431 * arch-utils.c: Fix common/ includes.
10432 * amd64-windows-tdep.c: Fix common/ includes.
10433 * amd64-tdep.c: Fix common/ includes.
10434 * amd64-sol2-tdep.c: Fix common/ includes.
10435 * amd64-obsd-tdep.c: Fix common/ includes.
10436 * amd64-nbsd-tdep.c: Fix common/ includes.
10437 * amd64-linux-tdep.c: Fix common/ includes.
10438 * amd64-linux-nat.c: Fix common/ includes.
10439 * amd64-fbsd-tdep.c: Fix common/ includes.
10440 * amd64-fbsd-nat.c: Fix common/ includes.
10441 * amd64-dicos-tdep.c: Fix common/ includes.
10442 * amd64-darwin-tdep.c: Fix common/ includes.
10443 * agent.c: Fix common/ includes.
10444 * ada-lang.h: Fix common/ includes.
10445 * ada-lang.c: Fix common/ includes.
10446 * aarch64-tdep.c: Fix common/ includes.
10447
2f5c153e
TT
104482019-01-25 Tom Tromey <tom@tromey.com>
10449
10450 * common/create-version.sh: Use common/version.h.
10451
adc6a863
PA
104522019-01-24 Pedro Alves <palves@redhat.com>
10453
10454 * infrun.c (signal_stop, signal_print, signal_program)
10455 (signal_catch, signal_pass): Now arrays instead of pointers.
10456 (update_signals_program_target, do_target_resume)
10457 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10458 * linux-nat.c (linux_nat_target::pass_signals)
10459 (linux_nat_target::create_inferior, linux_nat_target::attach):
10460 Adjust.
10461 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10462 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10463 * procfs.c (procfs_target::pass_signals): Adjust.
10464 * record-full.c (record_full_target::resume): Adjust.
10465 * remote.c (remote_target::pass_signals)
10466 (remote_target::program_signals): Adjust.
10467 * target-debug.h (target_debug_print_signals): Now takes a
10468 gdb::array_view as parameter. Adjust.
10469 * target.h (target_ops) <pass_signals, program_signals>: Replace
10470 pointer and length parameters with gdb::array_view.
10471 (target_pass_signals, target_program_signals): Likewise.
10472 * target-delegates.c: Regenerate.
10473
3046d67a
PA
104742019-01-24 Pedro Alves <palves@redhat.com>
10475
10476 * common/forward-scope-exit.h
10477 (forward_scope_exit::forward_scope_exit): Pass arguments to
10478 m_bind_function directly, instead of creating a std::bind and
10479 copying that.
10480
353229bf
AH
104812019-01-24 Alan Hayward <alan.hayward@arm.com>
10482
10483 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10484 for static members.
10485 (pass_in_v_vfp_candidate): Likewise.
10486
311dc83a
TT
104872019-01-23 Tom Tromey <tom@tromey.com>
10488 Pedro Alves <palves@redhat.com>
10489
10490 * regcache.c (class regcache_invalidator): Remove.
10491 (regcache::raw_write): Use make_scope_exit.
10492
296bd123
TT
104932019-01-23 Tom Tromey <tom@tromey.com>
10494
10495 * ui-out.h (class ui_out_emit_type): Update comment.
10496
979a0d13
TT
104972019-01-23 Tom Tromey <tom@tromey.com>
10498
10499 * infrun.c (fetch_inferior_event): Update comment.
10500
d238133d
TT
105012019-01-23 Tom Tromey <tom@tromey.com>
10502 Pedro Alves <palves@redhat.com>
10503
10504 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10505 parameter.
10506 (fetch_inferior_event): Use SCOPE_EXIT.
10507
10508
9885e6bb
TT
105092019-01-23 Tom Tromey <tom@tromey.com>
10510 Pedro Alves <palves@redhat.com>
10511
10512 * infrun.c (disable_thread_events): Delete.
10513 (stop_all_threads): Use SCOPE_EXIT.
10514
286526c1
TT
105152019-01-23 Tom Tromey <tom@tromey.com>
10516 Pedro Alves <palves@redhat.com>
10517
10518 * symfile.c: Include forward-scope-exit.h.
10519 (clear_symtab_users_cleanup): Replace forward declaration with
10520 a FORWARD_SCOPE_EXIT.
10521 (syms_from_objfile_1): Use the forward_scope_exit and
10522 gdb::optional instead of cleanup_function.
10523 (reread_symbols): Use the forward_scope_exit instead of
10524 cleanup_function.
10525 (clear_symtab_users_cleanup): Remove function.
10526
1db93f14
TT
105272019-01-23 Tom Tromey <tom@tromey.com>
10528 Pedro Alves <palves@redhat.com>
10529
10530 * linux-nat.c: Include scope-exit.h.
10531 (cleanup_target_stop): Remove.
10532 (linux_nat_target::static_tracepoint_markers_by_strid): Use
10533 SCOPE_EXIT.
10534
2cc83d1e
TT
105352019-01-23 Tom Tromey <tom@tromey.com>
10536 Pedro Alves <palves@redhat.com>
10537
10538 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10539 (call_function_by_hand_dummy): Use SCOPE_EXIT.
10540
694c6bf5
TT
105412019-01-23 Tom Tromey <tom@tromey.com>
10542 Andrew Burgess <andrew.burgess@embecosm.com>
10543 Pedro Alves <palves@redhat.com>
10544
10545 * infrun.c (fetch_inferior_event): Use scope_exit.
10546 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10547 * top.c (execute_command): Use scope_exit.
10548 * breakpoint.c (bpstat_do_actions): Use scope_exit.
10549 * utils.c (do_bpstat_clear_actions_cleanup)
10550 (make_bpstat_clear_actions_cleanup): Remove.
10551
4c41382a
TT
105522019-01-23 Tom Tromey <tom@tromey.com>
10553 Pedro Alves <palves@redhat.com>
10554
10555 * infrun.c: Include "common/scope-exit.h"
10556 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10557 (wait_for_inferior): Use SCOPE_EXIT.
10558 (fetch_inferior_event): Use scope_exit.
10559
89f8fb50
TT
105602019-01-23 Tom Tromey <tom@tromey.com>
10561 Pedro Alves <palves@redhat.com>
10562
10563 * breakpoint.c (create_breakpoint): Remove cleanup.
10564
5419bdae
TT
105652019-01-23 Tom Tromey <tom@tromey.com>
10566 Andrew Burgess <andrew.burgess@embecosm.com>
10567 Pedro Alves <palves@redhat.com>
10568
e587ef42
PA
105692019-01-23 Pedro Alves <palves@redhat.com>
10570
10571 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10572
77f0e74c
PA
105732019-01-23 Pedro Alves <palves@redhat.com>
10574 Andrew Burgess <andrew.burgess@embecosm.com>
10575
10576 * gdbthread.h: Include "common/forward-scope-exit.h".
10577 (scoped_finish_thread_state): Redefine custom class in terms of
10578 forward_scope_exit.
10579
5b9b3e53
PA
105802019-01-23 Pedro Alves <palves@redhat.com>
10581 Andrew Burgess <andrew.burgess@embecosm.com>
10582
10583 * common/forward-scope-exit.h: New file.
10584
54b65c9b
PA
105852019-01-23 Pedro Alves <palves@redhat.com>
10586 Andrew Burgess <andrew.burgess@embecosm.com>
10587 Tom Tromey <tom@tromey.com>
10588
10589 * common/scope-exit.h: New file.
10590
cf08fb29
PA
105912019-01-23 Pedro Alves <palves@redhat.com>
10592
10593 * common/preprocessor.h (ESC): Rename to ...
10594 (ESC_PARENS): ... this.
10595 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10596 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10597
ae73e2e2
TT
105982019-01-23 Tom Tromey <tom@tromey.com>
10599
10600 * language.h (class scoped_switch_to_sym_language_if_auto):
10601 Initialize m_lang in both cases.
10602
6594e122
AH
106032019-01-23 Alan Hayward <alan.hayward@arm.com>
10604
10605 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10606 with XCNEW.
10607
a7c9855d
TT
106082019-01-22 Tom Tromey <tom@tromey.com>
10609
10610 * corelow.c: Do not include sys/file.h.
10611
93cc1d53
TT
106122019-01-22 Tom Tromey <tom@tromey.com>
10613
10614 * tui/tui-wingeneral.h: Include gdb_curses.h.
10615
38561778
TT
106162019-01-22 Tom Tromey <tom@tromey.com>
10617
10618 * source-cache.h (class source_cache) <get_source_lines,
10619 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10620
37b3ab5b
TT
106212019-01-22 Tom Tromey <tom@tromey.com>
10622
10623 * remote-fileio.h (struct remote_target): Declare.
10624
3fabc016
TT
106252019-01-22 Tom Tromey <tom@tromey.com>
10626
10627 * python/py-arch.c: Do not include py-ref.h.
10628 * python/py-bpevent.c: Do not include py-ref.h.
10629 * python/py-cmd.c: Do not include py-ref.h.
10630 * python/py-continueevent.c: Do not include py-ref.h.
10631 * python/py-event.h: Do not include py-ref.h.
10632 * python/py-evtregistry.c: Do not include py-ref.h.
10633 * python/py-finishbreakpoint.c: Do not include py-ref.h.
10634 * python/py-frame.c: Do not include py-ref.h.
10635 * python/py-framefilter.c: Do not include py-ref.h.
10636 * python/py-function.c: Do not include py-ref.h.
10637 * python/py-infevents.c: Do not include py-ref.h.
10638 * python/py-linetable.c: Do not include py-ref.h.
10639 * python/py-objfile.c: Do not include py-ref.h.
10640 * python/py-param.c: Do not include py-ref.h.
10641 * python/py-prettyprint.c: Do not include py-ref.h.
10642 * python/py-progspace.c: Do not include py-ref.h.
10643 * python/py-symbol.c: Do not include py-ref.h.
10644 * python/py-symtab.c: Do not include py-ref.h.
10645 * python/py-type.c: Do not include py-ref.h.
10646 * python/py-unwind.c: Do not include py-ref.h.
10647 * python/py-utils.c: Do not include py-ref.h.
10648 * python/py-value.c: Do not include py-ref.h.
10649 * python/py-varobj.c: Do not include py-ref.h.
10650 * python/py-xmethods.c: Do not include py-ref.h.
10651 * python/python.c: Do not include py-ref.h.
10652 * varobj.c: Do not include py-ref.h.
10653
6b4d7774
TT
106542019-01-22 Tom Tromey <tom@tromey.com>
10655
10656 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10657 keyword for bcache.
10658
7af7e9b5
TT
106592019-01-22 Tom Tromey <tom@tromey.com>
10660
10661 * compile/compile-cplus-types.c: Remove a comment by #include.
10662
951d1049
TT
106632019-01-22 Tom Tromey <tom@tromey.com>
10664
10665 * compile/gcc-c-plugin.h: Include compile-internal.h.
10666
d65d5705
TT
106672019-01-22 Tom Tromey <tom@tromey.com>
10668
10669 * stabsread.c (EXTERN): Do not define.
10670 (symnum, next_symbol_text_func, processing_gcc_compilation)
10671 (within_function, global_sym_chain, global_stabs)
10672 (previous_stab_code, this_object_header_files)
10673 (n_this_object_header_files)
10674 (n_allocated_this_object_header_files): Define.
10675 * stabsread.h (EXTERN): Never define. Use "extern".
10676
b6fb1ee5
PW
106772019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10678
10679 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10680 history_value.
10681
be6d4f74
TT
106822019-01-21 Tom Tromey <tom@tromey.com>
10683
10684 * ui-out.c: Fix includes.
10685 * tui/tui-source.c: Fix includes.
10686 * target.c: Fix includes.
10687 * remote.c: Fix includes.
10688 * regcache.c: Fix includes.
10689 * python/py-block.c: Fix includes.
10690 * printcmd.c: Fix includes.
10691 * or1k-tdep.c: Fix includes.
10692 * mi/mi-main.c: Fix includes.
10693 * m32r-tdep.c: Fix includes.
10694 * csky-tdep.c: Fix includes.
10695 * compile/compile-cplus-types.c: Fix includes.
10696 * cli/cli-interp.c: Fix includes.
10697
73021deb
AH
106982019-01-21 Alan Hayward <alan.hayward@arm.com>
10699
10700 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10701 for padding.
10702
7932255d
TT
107032019-01-16 Tom Tromey <tom@tromey.com>
10704
10705 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
10706 earlier.
10707 (struct objfile) <msymbols_range>: Move from top level.
10708 <msymbols>: New method.
10709 (class objfile_msymbols): Remove.
10710 * symtab.c (default_collect_symbol_completion_matches_break_on):
10711 Update.
10712 * symmisc.c (dump_msymbols): Update.
10713 * stabsread.c (scan_file_globals): Update.
10714 * objc-lang.c (info_selectors_command, info_classes_command)
10715 (find_methods): Update.
10716 * minsyms.c (find_solib_trampoline_target): Update.
10717 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10718 * coffread.c (coff_symfile_read): Update.
10719 * ada-lang.c (ada_lookup_simple_minsym)
10720 (ada_collect_symbol_completion_matches): Update.
10721
604b1bfb
TT
107222019-01-16 Tom Tromey <tom@tromey.com>
10723
10724 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10725 type. Remove no-argument constructor.
10726 <iterator::operator++>: Simplify.
10727 <begin>: Update.
10728 <end>: Use minimal_symbol_count.
10729
f252c6d5
TT
107302019-01-16 Tom Tromey <tom@tromey.com>
10731
10732 * objfiles.h (struct objfile) <psymtabs>: New method.
10733 (class objfile_psymtabs): Remove.
10734 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10735 typedef.
10736 <range>: New method.
10737 (require_partial_symbols): Change return type.
10738 * psymtab.c (require_partial_symbols)
10739 (psym_expand_symtabs_matching): Update.
10740 * mdebugread.c (parse_partial_symbols): Update.
10741 * dbxread.c (dbx_end_psymtab): Update.
10742
b669c953
TT
107432019-01-15 Tom Tromey <tom@tromey.com>
10744
10745 * symtab.c (lookup_objfile_from_block)
10746 (lookup_symbol_in_objfile_symtabs)
10747 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10748 (find_line_symtab, info_sources_command)
10749 (default_collect_symbol_completion_matches_break_on)
10750 (make_source_files_completion_list): Update.
10751 * symmisc.c (print_objfile_statistics, dump_objfile)
10752 (maintenance_print_symbols, maintenance_info_symtabs)
10753 (maintenance_check_symtabs, maintenance_info_line_tables):
10754 Update.
10755 * source.c (select_source_symtab)
10756 (forget_cached_source_info_for_objfile): Update.
10757 * objfiles.h (class objfile_compunits): Remove.
10758 (struct objfile) <compunits_range>: New typedef.
10759 (compunits): New method.
10760 * objfiles.c (objfile_relocate1): Update.
10761 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10762 * maint.c (count_symtabs_and_blocks): Update.
10763 * linespec.c (iterate_over_all_matching_symtabs): Update.
10764 * cp-support.c (add_symbol_overload_list_qualified): Update.
10765 * coffread.c (coff_symtab_read): Update.
10766 * ada-lang.c (add_nonlocal_symbols)
10767 (ada_collect_symbol_completion_matches)
10768 (ada_add_global_exceptions): Update.
10769
7e955d83
TT
107702019-01-15 Tom Tromey <tom@tromey.com>
10771
10772 * progspace.h (program_space) <objfiles_safe_range>: New
10773 typedef.
10774 <objfiles_safe>: New method.
10775 * objfiles.h (class all_objfiles_safe): Remove.
10776 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10777 * jit.c (jit_inferior_exit_hook): Update.
10778
2030c079
TT
107792019-01-17 Tom Tromey <tom@tromey.com>
10780
10781 * progspace.h (program_space) <objfiles_range>: New typedef.
10782 <objfiles>: New method.
10783 <objfiles_head>: Rename from objfiles.
10784 (object_files): Update.
10785 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10786 * guile/scm-pretty-print.c
10787 (ppscm_find_pretty_printer_from_objfiles): Update.
10788 * guile/scm-objfile.c (gdbscm_objfiles): Update.
10789 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10790 Update.
10791 * python/py-progspace.c (pspy_get_objfiles): Update.
10792 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10793 Update.
10794 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10795 (objfpy_lookup_objfile_by_build_id): Update.
10796 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10797 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10798 Update.
10799 * symtab.c (iterate_over_symtabs, matching_obj_sections)
10800 (expand_symtab_containing_pc, lookup_objfile_from_block)
10801 (lookup_static_symbol, basic_lookup_transparent_type)
10802 (find_pc_sect_compunit_symtab, find_symbol_at_address)
10803 (find_line_symtab, info_sources_command)
10804 (default_collect_symbol_completion_matches_break_on)
10805 (make_source_files_completion_list, find_main_name): Update.
10806 * symmisc.c (print_symbol_bcache_statistics)
10807 (print_objfile_statistics, maintenance_print_symbols)
10808 (maintenance_print_msymbols, maintenance_print_objfiles)
10809 (maintenance_info_symtabs, maintenance_check_symtabs)
10810 (maintenance_expand_symtabs, maintenance_info_line_tables):
10811 Update.
10812 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10813 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10814 (map_overlay_command, unmap_overlay_command)
10815 (simple_overlay_update, expand_symtabs_matching)
10816 (map_symbol_filenames): Update.
10817 * symfile-debug.c (set_debug_symfile): Update.
10818 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10819 Update.
10820 * source.c (select_source_symtab, forget_cached_source_info):
10821 Update.
10822 * solib.c (solib_read_symbols): Update.
10823 * solib-spu.c (append_ocl_sos): Update.
10824 * psymtab.c (maintenance_print_psymbols)
10825 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10826 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10827 * printcmd.c (info_symbol_command): Update.
10828 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10829 Update.
10830 * objfiles.h (class all_objfiles): Remove.
10831 * objfiles.c (have_partial_symbols, have_full_symbols)
10832 (have_minimal_symbols, qsort_cmp, update_section_map)
10833 (shared_objfile_contains_address_p)
10834 (default_iterate_over_objfiles_in_search_order): Update.
10835 * objc-lang.c (info_selectors_command, info_classes_command)
10836 (find_methods): Update.
10837 * minsyms.c (find_solib_trampoline_target): Update.
10838 * maint.c (maintenance_info_sections)
10839 (maintenance_translate_address, count_symtabs_and_blocks):
10840 Update.
10841 * main.c (captured_main_1): Update.
10842 * linux-thread-db.c (try_thread_db_load_from_pdir)
10843 (has_libpthread): Update.
10844 * linespec.c (iterate_over_all_matching_symtabs)
10845 (search_minsyms_for_name): Update.
10846 * jit.c (jit_find_objf_with_entry_addr): Update.
10847 * hppa-tdep.c (find_unwind_entry)
10848 (hppa_lookup_stub_minimal_symbol): Update.
10849 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10850 Update.
10851 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10852 (elf_gnu_ifunc_resolve_by_got): Update.
10853 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10854 * dwarf-index-write.c (save_gdb_index_command): Update.
10855 * cp-support.c (add_symbol_overload_list_qualified): Update.
10856 * breakpoint.c (create_overlay_event_breakpoint)
10857 (create_longjmp_master_breakpoint)
10858 (create_std_terminate_master_breakpoint)
10859 (create_exception_master_breakpoint): Update.
10860 * blockframe.c (find_pc_partial_function): Update.
10861 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10862 (ada_collect_symbol_completion_matches)
10863 (ada_add_global_exceptions): Update.
10864
776489e0
TT
108652019-01-17 Tom Tromey <tom@tromey.com>
10866
10867 * solib-target.c (lm_info_target_p): Remove typedef. Don't
10868 declare VEC.
10869 (solib_target_parse_libraries): Change return type.
10870 (library_list_start_segment, library_list_start_section)
10871 (library_list_end_library, library_list_start_library); Update.
10872 (solib_target_free_library_list): Remove.
10873 (solib_target_parse_libraries): Remove cleanup. Change return
10874 type.
10875 (solib_target_current_sos): Update.
10876
6471e7d2
TT
108772019-01-17 Tom Tromey <tromey@bapiya>
10878
10879 * valprint.c: Replace "the the" with "the".
10880 * symtab.c: Replace "the the" with "the".
10881 * solib.c: Replace "the the" with "the".
10882 * solib-dsbt.c: Replace "the the" with "the".
10883 * linespec.c: Replace "the the" with "the".
10884 * dwarf2loc.h: Replace "the the" with "the".
10885 * amd64-windows-tdep.c: Replace "the the" with "the".
10886 * aarch64-tdep.c: Replace "the the" with "the".
10887
c24bdb02
KS
108882019-01-16 Keith Seitz <keiths@redhat.com>
10889
10890 PR gdb/23773
10891 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10892 <builder>: Rename to ..
10893 <m_builder>: ... this and make private.
10894 (dwarf2_cu::get_builder): New method. Change all users of
10895 `builder' to use this method.
10896 (dwarf2_start_symtab): Move to ...
10897 (dwarf2_cu::start_symtab): ... here. Update all callers
10898 (setup_type_unit_groups): Move to ...
10899 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
10900 callers.
10901 (dwarf2_cu::reset_builder): New method.
10902 (process_full_compunit, process_full_type_unit): Use
10903 dwarf2_cu::reset_builder.
10904 (follow_die_offset): Record the ancestor CU if it is different
10905 from the followed DIE's CU.
10906 (follow_die_sig_1): Likewise.
10907
8d64371b
TT
109082019-01-15 Tom Tromey <tom@tromey.com>
10909
10910 * remote.c (class remote_state) <buf>: Now a char_vector.
10911 <buf_size>: Remove.
10912 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
10913 parameter.
10914 (remote_target::getpkt_or_notif_sane_1)
10915 (remote_target::getpkt_sane)
10916 (remote_target::getpkt_or_notif_sane): Likewise.
10917 (class remote_target) <putpkt>: New overload.
10918 (remote_target::read_frame): Change type of "buf_p". Remove
10919 sizeof_p parameter.
10920 (packet_ok): New overload.
10921 (packet_check_result): New overload.
10922 Update all uses.
10923
bb277751
TT
109242019-01-14 Tom Tromey <tom@tromey.com>
10925
10926 * remote-notif.c (handle_notification, remote_notif_ack)
10927 (remote_notif_parse): Make "buf" const.
10928 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10929 const.
10930 (remote_notif_parse, remote_notif_ack, handle_notification):
10931 Likewise.
10932 * remote.c (remote_notif_stop_parse): Make "buf" const.
10933 (remote_target::remote_parse_stop_reply): Make "buf" const.
10934 (remote_notif_stop_ack): Make "buf" const.
10935
05be00a8
TT
109362019-01-14 Tom Tromey <tom@tromey.com>
10937
10938 * remote.c (remote_console_output): Make parameter const.
10939
491adeca
TT
109402019-01-14 Tom Tromey <tom@tromey.com>
10941
10942 * target-debug.h (target_debug_print_signals): Constify.
10943 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10944 * procfs.c (procfs_target::pass_signals): Update.
10945 * linux-nat.c (linux_nat_target::pass_signals): Update.
10946 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10947 * target-delegates.c: Rebuild.
10948 * remote.c (remote_target::program_signals): Update.
10949 (remote_target::pass_signals): Update.
10950 * target.c (target_pass_signals): Constify argument.
10951 (target_program_signals): Likewise.
10952 * target.h (struct target_ops) <pass_signals, program_signals>:
10953 Constify argument.
10954 (target_pass_signals, target_program_signals): Constify argument.
10955
bbd94648
TT
109562019-01-14 Tom Tromey <tom@tromey.com>
10957
10958 PR tui/28819:
10959 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10960
6f072a10
PFC
109612019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
10962
10963 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10964 field.
10965 * rs6000-tdep.c: Include reggroups.h.
10966 (IS_V_ALIAS_PSEUDOREG): Define.
10967 (rs6000_register_name): Return names for the "vX" aliases.
10968 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10969 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
10970 aliases. Call default_register_reggroup_p for all other
10971 pseudo-registers.
10972 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10973 New functions.
10974 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10975 Handle "vX" aliases.
10976 (v_alias_pseudo_register_collect): New function.
10977 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10978 (rs6000_gdbarch_init): Initialize "vX" aliases as
10979 pseudo-registers. Restore registration of
10980 rs6000_pseudo_register_reggroup_p with
10981 set_tdesc_pseudo_register_reggroup_p.
10982
1a782351
MF
109832019-01-13 Max Filippov <jcmvbkbc@gmail.com>
10984
10985 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10986 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10987 set_gdbarch_num_pseudo_regs.
10988
d73cff18
PW
109892019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10990
10991 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10992 Remove arg prefixname, add do_set and do_show.
10993 Add member functions set_list and show_list.
10994 * cli/cli-style.c (class cli_style_option): Update accordingly.
10995 (style_set_list): Move to file scope.
10996 (style_show_list): Likewise.
10997 (set_style): Call help_list.
10998 (show_style): Call cmd_show_list.
10999 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11000 Update to use the new macro.
11001
60a90376
JB
110022019-10-12 Joel Brobecker <brobecker@adacore.com>
11003
11004 * ada-lang.c (_initialize_ada_language): Expand the help text
11005 for the "catch exception" command.
11006
9d7c67bf
PW
110072019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11008
11009 * symtab.c (matching_obj_sections): Initialize obj,
11010 declare it closer to its usage.
11011
7cf47dc4
TT
110122019-01-10 Tom Tromey <tom@tromey.com>
11013
11014 * thread-iter.h (inf_threads_iterator): Use next_iterator.
11015 (basic_inf_threads_range): Remove.
11016 (inf_threads_range, inf_non_exited_threads_range)
11017 (safe_inf_threads_range): Use next_adapter.
11018
d3cb6808
KS
110192019-01-10 Keith Seitz <keiths@redhat.com>
11020
11021 PR gdb/23712
11022 PR symtab/23010
11023 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11024 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11025
63a20375
KS
110262019-01-10 Keith Seitz <keiths@redhat.com>
11027
11028 PR gdb/23712
11029 PR symtab/23010
11030 * dictionary.c (pending_to_vector): Remove.
11031 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11032 Remove _1 suffix, replacing functions of the same name. Update
11033 all callers.
11034 (dict_create_hashed, dict_create_hashed_expandable)
11035 (dict_create_linear, dict_create_linear_expandable, dict_free)
11036 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11037 Make functions static.
11038
b026f593
KS
110392019-01-10 Keith Seitz <keiths@redhat.com>
11040
11041 PR gdb/23712
11042 PR symtab/23010
11043 * dictionary.h (struct dictionary): Replace declaration with
11044 multidictionary.
11045 (dict_create_hashed, dict_create_hashed_expandable)
11046 (dict_create_linear, dict_create_linear_expandable)
11047 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11048 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11049 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11050 taking multidictionary argument.
11051 [ALL_DICT_SYMBOLS]: Update for multidictionary.
11052 * block.h (struct block) <dict>: Change to multidictionary
11053 and rename `multidict'.
11054 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11055 symmisc.c: Update all dictionary references to multidictionary.
11056
c7748ee9
KS
110572019-01-10 Keith Seitz <keiths@redhat.com>
11058
11059 PR gdb/23712
11060 PR symtab/23010
11061 * dictionary.c: Include unordered_map.
11062 (pending_to_vector): New function.
11063 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11064 Rewrite the non-"_1" functions to take vector instead
11065 of linked list.
11066 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11067 "new" _1 versions of the same name.
11068 (multidictionary): Define.
11069 (std::hash<enum language): New definition.
11070 (collate_pending_symbols_by_language, mdict_create_hashed)
11071 (mdict_create_hashed_expandable, mdict_create_linear)
11072 (mdict_create_linear_expandable, mdict_free)
11073 (find_language_dictionary, create_new_language_dictionary)
11074 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11075 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11076 (mdict_size, mdict_empty): New functions.
11077 * dictionary.h (mdict_iterator): Define.
11078
67aa1f3c
PA
110792019-01-10 Pedro Alves <palves@redhat.com>
11080
11081 * breakpoint.c (read_uploaded_action)
11082 (create_tracepoint_from_upload): Adjust to use
11083 gdb::unique_xmalloc_ptr.
11084 * ctf.c (ctf_write_uploaded_tp):
11085 (SET_ARRAY_FIELD): Use emplace_back.
11086 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11087 * tracefile-tfile.c (tfile_write_uploaded_tp):
11088 * tracepoint.c (parse_tracepoint_definition): Adjust to use
11089 gdb::unique_xmalloc_ptr.
11090 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11091 at_string, cond_string, cmd_strings>: Replace char pointers
11092 with gdb::unique_xmalloc_ptr.
11093
2f667667
PA
110942019-01-10 Pedro Alves <palves@redhat.com>
11095
11096 * solib-target.c (library_list_start_library): Don't xstrdup name.
11097
36cb7237
PA
110982019-01-10 Pedro Alves <palves@redhat.com>
11099
11100 * mdebugread.c (parse_partial_symbols): Use
11101 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11102
da584958
AB
111032019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11104
11105 * linux-fork.c (scoped_switch_fork_info)
11106 <~scoped_switch_fork_info>: Fix incorrect variable name.
11107
1ef8573c
AB
111082019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11109
11110 * linux-fork.c (scoped_switch_fork_info)
11111 <scoped_switch_fork_info>: Make explicit.
11112 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11113
8d7bcccb
TT
111142019-01-10 Tom Tromey <tom@tromey.com>
11115
11116 * objfiles.h (objfile::reset_psymtabs): Update.
11117 * objfiles.c (objfile::objfile): Update.
11118 * psymtab.h (psymtab_storage::obstack): Update.
11119 (psymtab_storage::m_obstack): Use gdb::optional.
11120 (class psymtab_storage): Update comment. Remove objfile
11121 parameter.
11122 * psymtab.c (psymtab_storage::psymtab_storage): Update.
11123
b596a3c7
TT
111242019-01-10 Tom Tromey <tom@tromey.com>
11125
11126 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11127 <free_psymtabs>: Now private.
11128 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11129 (allocate_psymtab): Use new method.
11130
a9342b62
TT
111312019-01-10 Tom Tromey <tom@tromey.com>
11132
11133 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11134 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11135 * mdebugread.c (parse_partial_symbols): Use
11136 allocate_dependencies.
11137 * dwarf2read.c (dwarf2_create_include_psymtab): Use
11138 allocate_dependencies.
11139 (process_psymtab_comp_unit_reader)
11140 (build_type_psymtab_dependencies): Likewise.
11141 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11142
5af70966
TT
111432019-01-10 Tom Tromey <tom@tromey.com>
11144
11145 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11146 PSYMBOL_SET_LANGUAGE.
11147 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11148
5923a04c
TT
111492019-01-10 Tom Tromey <tom@tromey.com>
11150
11151 * psymtab.h (psymtab_storage::obstack): New method.
11152 <m_obstack>: Rename from obstack; now private.
11153 * psymtab.c (psymtab_storage): Update.
11154 * dwarf2read.c (create_addrmap_from_index)
11155 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11156 Update.
11157
6d6a12bf
TT
111582019-01-10 Tom Tromey <tom@tromey.com>
11159
11160 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11161 * objfiles.h (objfile::reset_psymtabs): New method.
11162
d320c2b5
TT
111632019-01-10 Tom Tromey <tom@tromey.com>
11164
11165 * symmisc.c (print_symbol_bcache_statistics): Update.
11166 (print_objfile_statistics): Update.
11167 * symfile.c (reread_symbols): Update.
11168 * psymtab.h (class psymtab_storage): New.
11169 * psymtab.c (psymtab_storage): New constructor.
11170 (~psymtab_storage): New destructor.
11171 (require_partial_symbols): Update.
11172 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11173 (find_pc_sect_psymtab, find_pc_sect_psymbol)
11174 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11175 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11176 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11177 (start_psymtab_common, end_psymtab_common)
11178 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11179 (allocate_psymtab): Update.
11180 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11181 Update.
11182 (dump_psymtab_addrmap, maintenance_print_psymbols)
11183 (maintenance_check_psymtabs): Update.
11184 (class objfile_psymtabs): Move to objfiles.h.
11185 * psympriv.h (discard_psymtab): Now inline.
11186 (psymtab_discarder::psymtab_discarder): Update.
11187 (psymtab_discarder::~psymtab_discarder): Update.
11188 (ALL_OBJFILE_PSYMTABS): Rewrite.
11189 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11190 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11191 Remove fields.
11192 <partial_symtabs>: New field.
11193 (class objfile_psymtabs): Move from psymtab.h. Update.
11194 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11195 psymbol_cache.
11196 (objfile::~objfile): Don't destroy psymbol_cache.
11197 * mdebugread.c (parse_partial_symbols): Update.
11198 * dwarf2read.c (create_addrmap_from_index)
11199 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11200 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11201 (add_partial_subprogram, dwarf2_ranges_read): Update.
11202 * dwarf-index-write.c (write_address_map)
11203 (write_one_signatured_type, recursively_write_psymbols)
11204 (class debug_names, class debug_names, write_psymtabs_to_index):
11205 Update.
11206
1d94a5a3
TT
112072019-01-10 Tom Tromey <tom@tromey.com>
11208
11209 * symtab.h (SYMBOL_SET_NAMES): Update.
11210 (symbol_set_names): Update.
11211 (MSYMBOL_SET_NAMES): Update.
11212 * symtab.c (symbol_set_names): Change argument to be an
11213 objfile_per_bfd_storage.
11214 * psymtab.c (add_psymbol_to_bcache): Update.
11215 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11216
0f14768a
TT
112172019-01-10 Tom Tromey <tom@tromey.com>
11218
11219 * symtab.c (create_demangled_names_hash): Change argument to be an
11220 objfile_per_bfd_storage.
11221 (symbol_set_names): Update.
11222
6eee24ce
TT
112232019-01-10 Tom Tromey <tom@tromey.com>
11224
11225 * xcoffread.c (xcoff_initial_scan): Unconditionally call
11226 init_psymbol_list.
11227 * psymtab.c (init_psymbol_list): Do nothing if already called.
11228 * psympriv.h (init_psymbol_list): Add comment.
11229 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11230 init_psymbol_list.
11231 * dbxread.c (dbx_symfile_read): Unconditionally call
11232 init_psymbol_list.
11233
75aedd27
TT
112342019-01-10 Tom Tromey <tom@tromey.com>
11235
11236 * xcoffread.c (scan_xcoff_symtab): Update.
11237 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11238 "where".
11239 * mdebugread.c (parse_partial_symbols)
11240 (handle_psymbol_enumerators): Update.
11241 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11242 * dbxread.c (read_dbx_symtab): Update.
11243 * psympriv.h (psymbol_placement): New enum.
11244 (add_psymbol_to_list): Update.
11245
939652a5
TT
112462019-01-10 Tom Tromey <tom@tromey.com>
11247
11248 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11249 static_psymbols parameters.
11250 (scan_xcoff_symtab): Update.
11251 * psymtab.c (start_psymtab_common): Remove global_psymbols and
11252 static_psymbols parameters.
11253 * psympriv.h (start_psymtab_common): Update.
11254 * mdebugread.c (parse_partial_symbols): Update.
11255 * dwarf2read.c (create_partial_symtab): Update.
11256 * dbxread.c (read_dbx_symtab): Update.
11257 (start_psymtab): Remove global_psymbols and static_psymbols
11258 parameters.
11259
baa62830
TT
112602019-01-10 Tom Tromey <tom@tromey.com>
11261
11262 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11263 * psymtab.c (allocate_psymtab): Add comment.
11264 * psympriv.h (allocate_psymtab): Add comment.
11265 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11266 initializations.
11267 * dbxread.c (dbx_end_psymtab): Remove some initializations.
11268
0e8f53ba
TT
112692019-01-10 Tom Tromey <tom@tromey.com>
11270
11271 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11272 Don't declare.
11273 * mipsread.c: Include mdebugread.h.
11274 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11275 Declare.
11276 * elfread.c: Include mdebugread.h.
11277
b22a7c6a
TT
112782019-01-09 Tom Tromey <tom@tromey.com>
11279
11280 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11281 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11282 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11283 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11284 (psym_lookup_symbol, psym_find_last_source_symtab)
11285 (psym_forget_cached_source_info, psym_print_stats)
11286 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11287 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11288 (psym_map_matching_symbols, psym_expand_symtabs_matching)
11289 (psym_find_compunit_symtab_by_address)
11290 (maintenance_print_psymbols, maintenance_info_psymtabs)
11291 (maintenance_check_psymtabs): Use ranged for.
11292 * psymtab.h (class objfile_psymtabs): New.
11293 (require_partial_symbols): Return objfile_psymtabs.
11294 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11295
3b9d3ac2
TT
112962019-01-09 Tom Tromey <tom@tromey.com>
11297
11298 * symfile.c (overlay_invalidate_all, find_pc_overlay)
11299 (find_pc_mapped_section, list_overlays_command)
11300 (map_overlay_command, unmap_overlay_command)
11301 (simple_overlay_update): Use all_objfiles.
11302 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11303 * printcmd.c (info_symbol_command): Use all_objfiles.
11304 * objfiles.h (ALL_OBJSECTIONS): Remove.
11305 * maint.c (maintenance_translate_address): Use all_objfiles.
11306 * gcore.c (gcore_create_callback): Use all_objfiles.
11307 (objfile_find_memory_regions): Likewise.
11308
8b31193a
TT
113092019-01-09 Tom Tromey <tom@tromey.com>
11310
11311 * symtab.c (find_line_symtab, info_sources_command)
11312 (make_source_files_completion_list): Use objfile_compunits.
11313 * source.c (select_source_symtab): Use objfile_compunits.
11314 * objfiles.h (struct objfile): Update comment.
11315 (ALL_OBJFILES): Remove.
11316 (ALL_FILETABS): Remove.
11317 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11318 objfile_compunits.
11319
d5da8b3c
TT
113202019-01-09 Tom Tromey <tom@tromey.com>
11321
11322 * symmisc.c (print_objfile_statistics, dump_objfile)
11323 (maintenance_print_symbols): Use compunit_filetabs.
11324 * source.c (forget_cached_source_info_for_objfile): Use
11325 compunit_filetabs.
11326 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11327 (ALL_FILETABS): Use compunit_filetabs.
11328 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11329 * coffread.c (coff_symtab_read): Use compunit_filetabs.
11330
5accd1a0
TT
113312019-01-09 Tom Tromey <tom@tromey.com>
11332
11333 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11334 (compunit_filetabs): New.
11335 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11336 compunit_filetabs.
11337 (info_sources_command, make_source_files_completion_list): Remove
11338 declaration.
11339 * symmisc.c (print_objfile_statistics, dump_objfile)
11340 (maintenance_print_symbols): Remove declaration.
11341 (maintenance_info_symtabs): Use compunit_filetabs.
11342 (maintenance_info_line_tables): Likewise.
11343 * source.c (select_source_symtab): Change local variable name.
11344 (forget_cached_source_info_for_objfile): Remove declaration.
11345 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11346 * objfiles.c (objfile_relocate1): Remove declaration.
11347 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11348 declaration.
11349 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11350 * coffread.c (coff_symtab_read): Remove declaration.
11351 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11352 compunit_filetabs.
11353
d8aeb77f
TT
113542019-01-09 Tom Tromey <tom@tromey.com>
11355
11356 * symtab.c (lookup_objfile_from_block)
11357 (find_pc_sect_compunit_symtab, search_symbols)
11358 (default_collect_symbol_completion_matches_break_on): Use
11359 objfile_compunits.
11360 * objfiles.h (ALL_COMPUNITS): Remove.
11361 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11362 * cp-support.c (add_symbol_overload_list_qualified): Use
11363 objfile_compunits.
11364 * ada-lang.c (ada_collect_symbol_completion_matches)
11365 (ada_add_global_exceptions): Use objfile_compunits.
11366
592553c4
TT
113672019-01-09 Tom Tromey <tom@tromey.com>
11368
11369 * source.c (select_source_symtab)
11370 (forget_cached_source_info_for_objfile): Remove declaration.
11371 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11372 declaration.
11373 * maint.c (count_symtabs_and_blocks): Remove declaration.
11374 * cp-support.c (add_symbol_overload_list_qualified): Remove
11375 declaration.
11376 * coffread.c (coff_symtab_read): Remove declaration.
11377 * symtab.c (lookup_symbol_in_objfile_symtabs)
11378 (basic_lookup_transparent_type_1): Use objfile_compunits.
11379 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11380 (info_sources_command, search_symbols)
11381 (default_collect_symbol_completion_matches_break_on)
11382 (make_source_files_completion_list): Remove declaration.
11383 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11384 (ada_collect_symbol_completion_matches)
11385 (ada_add_global_exceptions): Remove declaration.
11386 * linespec.c (iterate_over_all_matching_symtabs): Use
11387 objfile_compunits.
11388 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11389 (class objfile_compunits): New.
11390 (ALL_COMPUNITS): Use objfile_compunits.
11391 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11392 (maintenance_check_symtabs, maintenance_info_line_tables): Use
11393 objfile_compunits.
11394 * objfiles.c (objfile_relocate1): Use objfile_compunits.
11395
5325b9bf
TT
113962019-01-09 Tom Tromey <tom@tromey.com>
11397
11398 * symtab.c (search_symbols)
11399 (default_collect_symbol_completion_matches_break_on): Use
11400 objfile_msymbols.
11401 * ada-lang.c (ada_lookup_simple_minsym)
11402 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11403 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11404 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11405 objfile_msymbols.
11406 * coffread.c (coff_symfile_read): Use objfile_msymbols.
11407 * symmisc.c (dump_msymbols): Use objfile_msymbols.
11408 * objc-lang.c (find_methods): Use objfile_msymbols.
11409 (info_selectors_command, info_classes_command): Likewise.
11410 * stabsread.c (scan_file_globals): Use objfile_msymbols.
11411 * objfiles.h (class objfile_msymbols): New.
11412 (ALL_OBJFILE_MSYMBOLS): Remove.
11413 (ALL_MSYMBOLS): Remove.
11414
cac85af2
TT
114152019-01-09 Tom Tromey <tom@tromey.com>
11416
11417 * common/next-iterator.h (next_adapter): Add Iterator template
11418 parameter.
11419 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11420 (class all_objfiles_safe): New.
11421 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11422 * objfiles.c (put_objfile_before): Update comment.
11423 (add_separate_debug_objfile): Likewise.
11424 (free_all_objfiles): Use all_objfiles_safe.
11425 (objfile_purge_solibs): Likewise.
11426
aed57c53
TT
114272019-01-09 Tom Tromey <tom@tromey.com>
11428
11429 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11430 (expand_symtab_containing_pc, lookup_static_symbol)
11431 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11432 (find_symbol_at_address, find_line_symtab, find_main_name): Use
11433 all_objfiles.
11434 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11435 * breakpoint.c (create_overlay_event_breakpoint)
11436 (create_longjmp_master_breakpoint)
11437 (create_std_terminate_master_breakpoint)
11438 (create_exception_master_breakpoint): Use all_objfiles.
11439 * linux-thread-db.c (try_thread_db_load_from_pdir)
11440 (has_libpthread): Use all_objfiles.
11441 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11442 * linespec.c (iterate_over_all_matching_symtabs)
11443 (search_minsyms_for_name): Use all_objfiles.
11444 * maint.c (maintenance_info_sections): Use all_objfiles.
11445 * main.c (captured_main_1): Use all_objfiles.
11446 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11447 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11448 * guile/scm-pretty-print.c
11449 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11450 * solib-spu.c (append_ocl_sos): Use all_objfiles.
11451 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11452 (maintenance_print_msymbols): Use all_objfiles.
11453 * source.c (select_source_symtab): Use all_objfiles.
11454 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11455 * symfile.c (remove_symbol_file_command)
11456 (expand_symtabs_matching, map_symbol_filenames): Use
11457 all_objfiles.
11458 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11459 all_objfiles.
11460 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11461 * objc-lang.c (find_methods): Use all_objfiles.
11462 * objfiles.c (have_partial_symbols, have_full_symbols)
11463 (have_minimal_symbols, qsort_cmp)
11464 (default_iterate_over_objfiles_in_search_order): Use
11465 all_objfiles.
11466 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11467 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11468 (maintenance_check_psymtabs): Use all_objfiles.
11469 (ALL_PSYMTABS): Remove.
11470 * compile/compile-object-run.c (do_module_cleanup): Use
11471 all_objfiles.
11472 * blockframe.c (find_pc_partial_function): Use all_objfiles.
11473 * cp-support.c (add_symbol_overload_list_qualified): Use
11474 all_objfiles.
11475 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11476 Use all_objfiles.
11477 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11478 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11479 all_objfiles.
11480 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11481 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11482 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11483 Uses all_objfiles.
11484 * solib.c (solib_read_symbols): Use all_objfiles
11485
99d89cde
TT
114862019-01-09 Tom Tromey <tom@tromey.com>
11487
11488 * probe.c (parse_probes_in_pspace): Use all_objfiles.
11489 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11490 all_objfiles.
11491 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11492 * symmisc.c (print_symbol_bcache_statistics)
11493 (print_objfile_statistics, maintenance_print_objfiles)
11494 (maintenance_info_symtabs, maintenance_check_symtabs)
11495 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11496 all_objfiles.
11497 * source.c (forget_cached_source_info): Use all_objfiles.
11498 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11499 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11500 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11501 * objfiles.c (update_section_map): Use all_objfiles.
11502 (shared_objfile_contains_address_p): Likewise.
11503 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11504 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11505
21708325
TT
115062019-01-09 Tom Tromey <tom@tromey.com>
11507
11508 * common/next-iterator.h: New file.
11509 * objfiles.h (class all_objfiles): New.
11510 (struct objfile_iterator): New.
11511
669e09f6
PW
115122019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11513
11514 * NEWS: Move the description of the changed "frame", "select-frame",
11515 and "info frame" commands to the Changed commands section.
11516
041be526
SM
115172019-01-09 Simon Marchi <simon.marchi@ericsson.com>
11518
11519 * gdbtypes.c (check_stub_method_group): Remove handling of old
11520 mangling schemes.
11521 * linespec.c (find_methods): Likewise.
11522 * stabsread.c (read_member_functions): Likewise.
11523 * valops.c (search_struct_method): Likewise.
11524 (value_struct_elt_for_reference): Likewise.
11525 * NEWS: Mention this change.
11526
0e2a2133
AB
115272019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
11528
11529 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11530 print_source_lines.
11531 * source.c (print_source_lines_base): Update line number check.
11532 (print_source_lines): New function.
11533 (source_lines_range::source_lines_range): New function.
11534 * source.h (class source_lines_range): New class.
11535 (print_source_lines): New declaration.
11536
1055a3b4
PW
115372019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11538
11539 * linespec.c (linespec_state_destructor): Free self->canonical_names.
11540
cfeadda5
TT
115412019-01-08 Tom Tromey <tom@tromey.com>
11542 Simon Marchi <simon.marchi@ericsson.com>
11543
11544 PR gdb/24060
11545 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11546 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11547 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11548 * f-exp.y (DOLLAR_VARIABLE): Likewise.
11549 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11550 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11551
583068ca
AB
115522019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11553
11554 * source.c (select_source_symtab): Move header comment to
11555 declaration in source.h.
11556 (forget_cached_source_info_for_objfile): Likewise.
11557 (forget_cached_source_info): Likewise.
11558 (identify_source_line): Likewise.
11559 * source.h (identify_source_line): Move declaration from symtab.h
11560 and add comment from source.c
11561 (print_source_lines): Likewise.
11562 (forget_cached_source_info_for_objfile): Likewise.
11563 (forget_cached_source_info): Likewise.
11564 (select_source_symtab): Likewise.
11565 (enum print_source_lines_flag): Move definition from symtab.h.
11566 * symtab.h (identify_source_line): Move declaration to source.h.
11567 (print_source_lines): Likewise.
11568 (forget_cached_source_info_for_objfile): Likewise.
11569 (forget_cached_source_info): Likewise.
11570 (select_source_symtab): Likewise.
11571 (enum print_source_lines_flag): Move definition to source.h.
11572 * tui/tui-hooks.c: Add 'source.h' include.
11573
ec98a4ad
AB
115742019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11575
11576 * source.c (print_source_lines_base): Handle requests to print
11577 reverse line number sequences, and guard against empty lines
11578 string.
11579
62ea19c1
AB
115802019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11581
11582 * source.c (print_source_lines_base): Fix skip of '\r' if next
11583 character is '\n'.
11584
9d30e1fd
TT
115852019-01-06 Tom Tromey <tom@tromey.com>
11586
11587 * c-exp.y (struct c_parse_state) <macro_original_text,
11588 expansion_obstack>: New member.
11589 (macro_original_text, expansion_obstack): Remove globals.
11590 (scan_macro_expansion, scanning_macro_expansion)
11591 (finished_macro_expansion): Update.
11592 (scan_macro_cleanup): Remove.
11593 (yylex, c_parse): Update.
11594
c65bac38
TT
115952019-01-06 Tom Tromey <tom@tromey.com>
11596
11597 * c-exp.y (struct c_parse_state) <strings>: New member.
11598 (operator_stoken): Update.
11599
02e12e38
TT
116002019-01-06 Tom Tromey <tom@tromey.com>
11601
11602 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
11603 (union type_stack_elt) <typelist_val>: Now a pointer to
11604 std::vector.
11605 (type_stack_cleanup): Don't declare.
11606 (push_typelist): Update.
11607 * parse.c (pop_typelist): Return a std::vector.
11608 (push_typelist): Take a std::vector.
11609 (follow_types): Update. Do not free args.
11610 (type_stack_cleanup): Remove.
11611 * c-exp.y (struct c_parse_state): New.
11612 (cpstate): New global.
11613 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11614 (nonempty_typelist): Update.
11615 (func_mod): Create a new vector.
11616 (c_parse): Create a c_parse_state.
11617 (check_parameter_typelist): Do not delete params.
11618 (function_method): Update. Do not delete type_list.
11619
f097f5ad
TT
116202019-01-06 Tom Tromey <tom@tromey.com>
11621
11622 PR gdb/28155:
11623 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11624 check_typedef.
11625 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11626 (print_return_value): Likewise.
11627
d2adf9f1
TT
116282019-01-05 Tom Tromey <tom@tromey.com>
11629
11630 * contrib/cleanup_check.py: Remove.
11631 * contrib/gcc-with-excheck: Remove.
11632 * contrib/exsummary.py: Remove.
11633 * contrib/excheck.py: Remove.
11634
2eab46b1
JB
116352019-01-05 Joel Brobecker <brobecker@adacore.com>
11636
11637 * thread.c (delete_thread_1): Add gdb_assert that THR is not
11638 NULL. Initialize tpprev to NULL instead of assigning it
11639 to NULL on the next statement.
11640 * windows-nat.c (windows_delete_thread): Remove check for
11641 main_thread_id before printing thread exit notifications.
11642 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11643 Remove thread ID check against main_thread_id.
11644 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11645 windows_delete_thread.
11646 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11647
48c5e7e2
TT
116482019-01-04 Tom Tromey <tom@tromey.com>
11649
11650 * compile/compile.c (_initialize_compile): Use upper case for
11651 metasyntactic variables.
11652 * symmisc.c (_initialize_symmisc): Use upper case for
11653 metasyntactic variables.
11654 * psymtab.c (_initialize_psymtab): Use upper case for
11655 metasyntactic variables.
11656 * demangle.c (demangle_command): Use upper case for metasyntactic
11657 variables.
11658 (_initialize_demangler): Likewise.
11659 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11660 variables.
11661
986041cd
TT
116622019-01-03 Tom Tromey <tom@tromey.com>
11663
11664 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11665
7c711119
TT
116662019-01-03 Tom Tromey <tom@tromey.com>
11667
11668 * python/py-symtab.c (salpy_str): Update.
11669 (struct salpy_sal_object) <symtab>: Now a PyObject.
11670 (salpy_dealloc): Update.
11671 (del_objfile_sal): Use gdbpy_ref.
11672
1b20edf0
TT
116732019-01-03 Tom Tromey <tom@tromey.com>
11674
11675 * python/py-type.c (convert_field): Use new_reference. Return
11676 gdbpy_ref.
11677 (make_fielditem): Return gdbpy_ref.
11678 (typy_fields): Update.
11679 (typy_getitem): Update.
11680 (field_name): Return gdbpy_ref. Use new_reference.
11681 (typy_iterator_iternext): Update.
11682
ea41325b
TT
116832019-01-03 Tom Tromey <tom@tromey.com>
11684
11685 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11686
2a3c71d6
TT
116872019-01-03 Tom Tromey <tom@tromey.com>
11688
11689 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11690 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11691 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11692 (pspy_set_frame_filters, pspy_set_frame_unwinders)
11693 (pspy_set_type_printers): Likewise.
11694 * python/py-function.c (fnpy_init): Use gdbpy_ref.
11695 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11696 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11697 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11698 (objfpy_set_type_printers): Likewise.
11699
5c329e6a
TT
117002019-01-03 Tom Tromey <tom@tromey.com>
11701
11702 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11703 (gdbpy_print_stack): Use gdbpy_err_fetch.
11704 * python/python-internal.h (class gdbpy_err_fetch): New class.
11705 (class gdbpy_enter) <m_error_type, m_error_value,
11706 m_error_traceback>: Remove.
11707 <m_error>: New member.
11708 (gdbpy_exception_to_string): Don't declare.
11709 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11710 * python/py-value.c (convert_value_from_python): Use
11711 gdbpy_err_fetch.
11712 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11713 gdbpy_exception_to_string.
11714 (gdbpy_handle_exception): Use gdbpy_err_fetch.
11715 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11716 gdbpy_err_fetch.
11717
169bb27b
AB
117182019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11719
11720 * linux-nat.c (delete_lwp_cleanup): Delete.
11721 (struct lwp_deleter): New struct.
11722 (lwp_info_up): New typedef.
11723 (linux_nat_target::follow_fork): Delete cleanup, and make use of
11724 lwp_info_up.
11725
a07c8880
AB
117262019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11727
11728 * linux-fork.c (class scoped_switch_fork_info): New class.
11729 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11730
26089c49
AB
117312019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11732
11733 * valops.c (find_overload_match): Remove use of null_cleanup, and
11734 calls to do_cleanups.
11735
06d3e5b0
AB
117362019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11737
11738 * compile/compile-cplus-types.c
11739 (compile_cplus_instance::decl_name): Handle changes to
11740 cp_func_name.
11741 * cp-support.c (cp_func_name): Update header comment, update
11742 return type.
11743 * cp-support.h (cp_func_name): Update return type in declaration.
11744 * valops.c (find_overload_match): Move temp_func local to top
11745 level of function and change its type. Use temp_func to hold and
11746 delete temporary string obtained from cp_func_name.
11747
66644cd3
AB
117482019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11749
11750 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11751 gdb::char_vector, remove cleanup, and update uses of `msg`.
11752
592d8c0a
JW
117532019-01-03 Jim Wilson <jimw@sifive.com>
11754
11755 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11756
c55d06ec
TT
117572019-01-02 Tom Tromey <tom@tromey.com>
11758
11759 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11760 (tdesc_parse_xml): Remove cleanups.
11761 * target-descriptions.h (make_cleanup_free_target_description):
11762 Don't declare.
11763 (target_desc_deleter): New struct.
11764 (target_desc_up): New typedef.
11765 * target-descriptions.c (target_desc_deleter::operator()): Rename
11766 from free_target_description.
11767 (make_cleanup_free_target_description): Remove.
11768
3a6ae42d
TT
117692019-01-02 Tom Tromey <tom@tromey.com>
11770
11771 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
11772 constructor, destructor.
11773 (linespec_parser): Remove typedef.
11774 (~linespec_parser): Rename from linespec_parser_delete.
11775 (linespec_lex_to_end, linespec_complete_label)
11776 (linespec_complete): Update.
11777 (decode_line_full): Remove cleanups.
11778 (decode_line_1): Update.
11779
61fd3e73
TT
117802019-01-02 Tom Tromey <tom@tromey.com>
11781
11782 * python/python-internal.h (inferior_to_inferior_object): Change
11783 return type.
11784 * python/py-exitedevent.c (create_exited_event_object): Update.
11785 * python/py-inferior.c (inferior_to_inferior_object): Return
11786 gdbpy_ref.
11787 (python_new_inferior, python_inferior_deleted)
11788 (thread_to_thread_object, delete_thread_object)
11789 (build_inferior_list, gdbpy_selected_inferior): Update.
11790 * python/py-infthread.c (create_thread_object): Update. Also fail
11791 if inferior_to_inferior_object fails.
11792
d20172fc
SM
117932019-01-02 Simon Marchi <simon.marchi@ericsson.com>
11794
11795 * inferior.h (class inferior) <displaced_step_state>: New field.
11796 * infrun.h (struct displaced_step_state): Move here from
11797 infrun.c. Initialize fields, add constructor.
11798 <inf>: Remove field.
11799 <reset>: New method.
11800 * infrun.c (struct displaced_step_inferior_state): Move to
11801 infrun.h.
11802 (displaced_step_inferior_states): Remove.
11803 (get_displaced_stepping_state): Adust.
11804 (displaced_step_in_progress_any_inferior): Adjust.
11805 (displaced_step_in_progress_thread): Adjust.
11806 (displaced_step_in_progress): Adjust.
11807 (add_displaced_stepping_state): Remove.
11808 (get_displaced_step_closure_by_addr): Adjust.
11809 (remove_displaced_stepping_state): Remove.
11810 (infrun_inferior_exit): Call displaced_step_state.reset.
11811 (use_displaced_stepping): Don't check for NULL.
11812 (displaced_step_prepare_throw): Call
11813 get_displaced_stepping_state.
11814 (displaced_step_fixup): Don't check for NULL.
11815 (prepare_for_detach): Don't check for NULL.
11816
e3319240
PW
118172019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11818
11819 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11820 in case of call that did not complete.
11821
5d36dfb9
AU
118222019-01-02 Andrey Utkin <autkin@undo.io>
11823
11824 * symfile.c (find_separate_debug_file): Fix search of debug files for
11825 remote debuggee.
11826
8833fbf0
TT
118272019-01-02 Tom Tromey <tom@tromey.com>
11828
11829 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11830 indentation.
11831 * python/py-frame.c (frapy_older): Remove cast.
11832 (frapy_newer): Likewise.
11833 * python/py-breakpoint.c (local_setattro): Remove cast.
11834 * python/py-arch.c (archpy_name): Remove local variable.
11835 * python/py-type.c (gdbpy_lookup_type): Remove cast.
11836
4ada3dfd
JB
118372019-01-02 Joel Brobecker <brobecker@adacore.com>
11838
11839 * unittests/basic_string_view/element_access/char/empty.cc:
11840 Fix year range in copyright header.
11841
113b7b81
AB
118422019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
11843
11844 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11845 Delete.
11846 <operator==>: Update with for removed field.
11847 <hash>: Likewise.
11848 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11849 <isa_features>: ...this.
11850 <abi_features>: New field.
11851 (riscv_isa_flen): Update comment.
11852 (riscv_abi_xlen): New declaration.
11853 (riscv_abi_flen): New declaration.
11854 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11855 isa_features.
11856 (riscv_abi_xlen): New function.
11857 (riscv_isa_flen): Update to get answer from isa_features.
11858 (riscv_abi_flen): New function.
11859 (riscv_has_fp_abi): Update to get answer from abi_features.
11860 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11861 xlen and flen.
11862 (riscv_call_info) <xlen, flen>: Update comment.
11863 (riscv_call_arg_struct): Remove invalid assertions
11864 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11865 is removed.
11866 (riscv_gdbarch_init): Gather isa features and abi features
11867 separately, ensure both match on the gdbarch when reusing an old
11868 gdbarch. Relax an error check to allow 32-bit abi float to run on
11869 a target with 64-bit float hardware.
11870
b18ca514
PW
118712019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11872
11873 * source.c (search_command_helper): Stop reverse search
11874 when line 1 has been searched.
11875
ec70d8db
PW
118762019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11877
11878 * record-full.c (record_full_base_target::close): Rewrite
11879 record_full_core_buf_list free logic.
11880
5b38f9c1
PW
118812019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11882
11883 * break-catch-syscall.c (print_one_catch_syscall): xfree
11884 the last text.
11885
66d91b39
JB
118862019-01-01 Joel Brobecker <brobecker@adacore.com>
11887
11888 * top.c (print_gdb_version): Update Copyright year in version
11889 message.
11890
42a4f53d
JB
118912019-01-01 Joel Brobecker <brobecker@adacore.com>
11892
11893 Update copyright year range in all GDB files.
11894
7e955d83 118952019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 11896
5bbd631d 11897 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 11898
5bbd631d 11899For older changes see ChangeLog-2018.
c906108c
SS
11900\f
11901Local Variables:
11902mode: change-log
11903left-margin: 8
11904fill-column: 74
11905version-control: never
57da7796 11906coding: utf-8
c906108c 11907End:
5bbd631d 11908
This page took 2.801472 seconds and 4 git commands to generate.