Make TUI window handle a unique_ptr
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
7523da63
TT
12019-10-09 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
4 * tui/tui-stack.c (tui_locator_window::rerender): Update.
5 * tui/tui-command.c (tui_cmd_window::resize)
6 (tui_refresh_cmd_win): Update.
7 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
8 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
9 * tui/tui-data.c (~tui_gen_win_info): Remove.
10 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
11 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
12 (tui_redisplay_readline, tui_mld_flush)
13 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
14 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
15 (tui_data_window::erase_data_content)
16 (tui_data_item_window::rerender)
17 (tui_data_item_window::refresh_window): Update.
18 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
19 (box_win, tui_gen_win_info::make_window)
20 (tui_gen_win_info::make_visible): Update.
21 (tui_delete_win): Remove.
22 * tui/tui-winsource.c
23 (tui_source_window_base::do_erase_source_content): Update.
24 (tui_show_source_line, tui_source_window_base::update_tab_width)
25 (tui_source_window_base::update_exec_info): Update.
26 * tui/tui-data.h (struct curses_deleter): New.
27 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
28 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
29
a7798e7f
TT
302019-10-09 Tom Tromey <tom@tromey.com>
31
32 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
33
5c45899e
TT
342019-10-09 Tom Tromey <tom@tromey.com>
35
36 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
37 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
38
6d7fd9aa
TT
392019-10-09 Tom Tromey <tom@tromey.com>
40
41 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
42 window height directly.
43 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
44 declare.
45 * tui/tui-layout.c (tui_default_win_height): Remove.
46 (tui_default_win_viewport_height): Remove.
47
d2dd1084
TT
482019-10-09 Tom Tromey <tom@tromey.com>
49
50 * tui/tui.h: Remove comments.
51
cff32449
TV
522019-10-09 Tom de Vries <tdevries@suse.de>
53
54 * python/lib/gdb/printer/bound_registers.py: Use
55 '^builtin_type_bound128' as regexp argument for
56 add_builtin_pretty_printer.
57
6a25e8a2
CB
582019-10-09 Christian Biesinger <cbiesinger@google.com>
59
60 * guile/guile.c (guile_extension_script_ops): Remove forward
61 declaration and mark as static.
62 (guile_script_ops): Likewise.
63 (extension_language_guile): Move further down in the file so
64 it can reference the definitions for guile_{extension_,}script_ops.
65
6d9d6da4
AA
662019-10-09 Andreas Arnez <arnez@linux.ibm.com>
67
68 * s390-tdep.c (390_process_record): Handle new arch13 instructions
69 except SORTL, DFLTCC, and KDSA.
70
3abea05d
TT
712019-10-08 Tom Tromey <tromey@adacore.com>
72
73 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
74 (struct safe_symbol_file_add_args): Remove.
75
dde996e2
TT
762019-10-08 Tom Tromey <tromey@adacore.com>
77
78 * windows-nat.c: Don't include buildsym-legacy.h.
79
cd6fdaa1
TT
802019-10-08 Tom Tromey <tromey@adacore.com>
81
82 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
83
79bb1944
CB
842019-10-08 Christian Biesinger <cbiesinger@google.com>
85
86 * gdbtypes.c (overload_debug): Move comment to header.
87 * gdbtypes.h (overload_debug): Declare.
88 * valops.c: Remove declaration of overload_debug, instead
89 include gdbtypes.h.
90
34916edc
CB
912019-10-08 Christian Biesinger <cbiesinger@google.com>
92
93 * language.c (show_language_command): Pass lang_frame_mismatch_warn
94 through _().
95 (lang_frame_mismatch_warn): Make const, mark with N_(), and
96 move comment...
97 * language.h (lang_frame_mismatch_warn): ... here. Also add
98 declaration.
99 * top.c (lang_frame_mismatch_warn): Remove declaration.
100 (check_frame_language_change): Pass lang_frame_mismatch_warn
101 through _().
102
bad5c026
CB
1032019-10-07 Christian Biesinger <cbiesinger@google.com>
104
105 * c-lang.h (vtbl_ptr_name): Declare.
106 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
107 it from the header.
108 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
109
51f1fdc3
CB
1102019-10-07 Christian Biesinger <cbiesinger@google.com>
111
112 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
113 gdb_static_assert.
114
30d1f018
WP
1152019-10-07 Weimin Pan <weimin.pan@oracle.com>
116
606813d5
WP
117 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
118 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
119 * ctfread.c: New file.
120 * ctfread.h: New file.
121 * elfread.c: Include ctfread.h.
122 (struct elfinfo text_p): New member ctfsect.
123 (elf_locate_sections): Mark CTF section.
124 (elf_symfile_read): Call elfctf_build_psymtabs.
125 * Makefile.in (LIBCTF): Add.
126 (CLIBS): Use it.
127 (CDEPS): Likewise.
128 (DIST): Add ctfread.c.
606813d5
WP
129
1302019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
131
132 * ctfread.c (struct nextfield): Renamed to ...
133 (struct ctf_nextfield): ... this.
134 (struct field_info): Renamed to ...
135 (strut ctf_field_info): ... this.
136 (attach_fields_to_type): Update for renamed structures.
137 (ctf_add_member_cb): Likewise.
138 (ctf_add_enum_member_cb): Likewise.
139 (process_struct_members): Likewise.
140 (process_enum_type): Likewise.
30d1f018 141
518fe38c
WP
1422019-10-07 Weimin Pan <weimin.pan@oracle.com>
143
144 * tracectf.h: Rename, was ctf.h.
145 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
146 * tracefile.c: Likewise.
147 * tracepoint.c: Remove unused include ctf.h.
148 * mi/mi-main.c: Likewise.
149 * Makefile.in Replace ctf.c with tracectf.c.
150
225f296a
JB
1512019-10-06 Joel Brobecker <brobecker@adacore.com>
152
153 * version.in: Change version number to "9.0.50.DATE-git".
154
77c2dba3
TT
1552019-10-03 Tom Tromey <tom@tromey.com>
156
157 PR rust/24976:
158 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
159
179aed7f
AB
1602019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
161
162 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
163 cp_search_name_hash.
164 * NEWS: Add entry about nested function support.
165
0a4b0913
AB
1662019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
167 Andrew Burgess <andrew.burgess@embecosm.com>
168
169 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
170 for nested static variables when searchin VAR_DOMAIN.
171 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
172 global scope, update comment.
173 (add_partial_subprogram): Call add_partial_subprogram recursively
174 for nested subroutines when processinng Fortran.
175 (load_partial_dies): Process the child entities of a subprogram
176 when processing Fortran.
177 (partial_die_parent_scope): Handle building scope
178 for Fortran nested functions.
179 (process_die): Record that nested functions have a scope.
180 (new_symbol): Always record Fortran subprograms on the global
181 symbol list.
182 (determine_prefix): How to build the prefix for Fortran
183 subprograms.
184
d8c06f22
AB
1852019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
186
187 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
188 have just sent the thread a SIGSTOP and are waiting for it to
189 arrive.
190
a8b3b8e9
AB
1912019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
192
193 * btrace.c (btrace_add_pc): Remove whitespace before the template
194 parameter in 'std::vector <...>'.
195 (parse_xml_btrace_block): Likewise.
196 (btrace_maint_decode_pt): Likewise.
197 (btrace_maint_update_packets): Likewise.
198 (btrace_maint_print_packets): Likewise.
199 * btrace.h (struct btrace_maint_info): Likewise.
200 * dwarf2read.c (struct type_unit_group): Likewise.
201 (build_type_psymtabs_reader): Likewise.
202 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
203 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
204 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
205
4d825eab
TV
2062019-10-03 Tom de Vries <tdevries@suse.de>
207
208 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
209 the first line of the help text for set/show style metadata.
210
80fd2826
TT
2112019-10-02 Tom Tromey <tromey@adacore.com>
212
213 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
214 * gdbsupport/common-inferior.c: New file.
215 * infcmd.c (startup_with_shell): Don't define.
216 * nat/fork-inferior.h (startup_with_shell): Don't declare.
217 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
218 * inferior.h (startup_with_shell): Don't declare.
219
70054538
CB
2202019-10-02 Christian Biesinger <cbiesinger@google.com>
221
222 * gdbsupport/gdb_assert.h: Include errors.h.
223 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
224
37f6a7f4
TT
2252019-10-02 Tom Tromey <tromey@adacore.com>
226
227 * NEWS: Add $_ada_exception entry.
228 * ada-lang.c (struct ada_catchpoint): Add constructor.
229 <m_kind>: New member.
230 (allocate_location_exception, re_set_exception): Remove
231 "ex" parameter.
232 (should_stop_exception): Compute $_ada_exception.
233 (check_status_exception, print_it_exception)
234 (print_one_exception, print_mention_exception): Remove
235 "ex" parameter.
236 (allocate_location_catch_exception, re_set_catch_exception)
237 (check_status_exception, print_it_catch_exception)
238 (print_one_catch_exception, print_mention_catch_exception)
239 (print_recreate_catch_exception)
240 (allocate_location_catch_exception_unhandled)
241 (re_set_catch_exception_unhandled)
242 (check_status_exception, print_it_catch_exception_unhandled)
243 (print_one_catch_exception_unhandled)
244 (print_mention_catch_exception_unhandled)
245 (print_recreate_catch_exception_unhandled)
246 (allocate_location_catch_assert, re_set_catch_assert)
247 (check_status_assert, print_it_catch_assert)
248 (print_one_catch_assert, print_mention_catch_assert)
249 (print_recreate_catch_assert)
250 (allocate_location_catch_handlers, re_set_catch_handlers)
251 (check_status_handlers, print_it_catch_handlers)
252 (print_one_catch_handlers, print_mention_catch_handlers)
253 (print_recreate_catch_handlers): Remove.
254 (create_ada_exception_catchpoint): Update.
255 (initialize_ada_catchpoint_ops): Update.
256
fccf9de1
TT
2572019-10-02 Tom Tromey <tromey@adacore.com>
258
259 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
260 (create_excep_cond_exprs): Simplify exception string computation.
261 (ada_exception_catchpoint_cond_string): Likewise.
262
4b610737
TT
2632019-10-02 Tom Tromey <tromey@adacore.com>
264
265 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
266 * ada-lang.c (lesseq_defined_than): Handle
267 LOC_STATIC.
268 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
269 parameter.
270 (dwarf2_has_info): Likewise.
271 (new_symbol): Set maybe_copied on symbol when
272 appropriate.
273 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
274 parameter.
275 <can_copy>: New member.
276 * elfread.c (record_minimal_symbol): Set maybe_copied
277 on symbol when appropriate.
278 (elf_symfile_read): Update call to dwarf2_has_info.
279 * minsyms.c (lookup_minimal_symbol_linkage): New
280 function.
281 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
282 * symtab.c (get_symbol_address, get_msymbol_address):
283 New functions.
284 * symtab.h (get_symbol_address, get_msymbol_address):
285 Declare.
286 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
287 maybe_copied.
288 (struct symbol, struct minimal_symbol) <maybe_copied>:
289 New member.
290
1dd58850
TT
2912019-10-02 Tom Tromey <tromey@adacore.com>
292
293 * source.c (struct current_source_location): New.
294 (current_source_key): New global.
295 (current_source_symtab, current_source_line)
296 (current_source_pspace): Remove.
297 (get_source_location): New function.
298 (get_current_source_symtab_and_line)
299 (set_default_source_symtab_and_line)
300 (set_current_source_symtab_and_line)
301 (clear_current_source_symtab_and_line, select_source_symtab)
302 (info_source_command, print_source_lines_base)
303 (info_line_command, search_command_helper, _initialize_source):
304 Update.
305
5c281dbb
TT
3062019-10-02 Tom Tromey <tromey@adacore.com>
307
308 * source.c (select_source_symtab): Don't call
309 decode_line_with_current_source.
310
d3d32391
AB
3112019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
312
313 * symtab.c (lookup_global_symbol): Search global block.
314
38583298
TT
3152019-10-02 Tom Tromey <tromey@adacore.com>
316
317 * coffread.c (process_coff_symbol): Update.
318 * dwarf2read.c (var_decode_location, new_symbol): Update.
319 * mdebugread.c (parse_symbol): Update.
320 * objfiles.c (relocate_one_symbol): Update.
321 * stabsread.c (define_symbol, fix_common_block)
322 (scan_file_globals): Update.
323 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
324 (SET_SYMBOL_VALUE_ADDRESS): New macro.
325 * xcoffread.c (process_xcoff_symbol): Update.
326
9344c18f
AA
3272019-10-02 Andreas Arnez <arnez@linux.ibm.com>
328
329 * MAINTAINERS: Update my email address.
330
df07e2c7
AB
3312019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
332
333 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
334 std::vector.
335 (build_type_psymtabs_reader): Update for std::vector.
336 (build_type_psymtab_dependencies): Likewise.
337 * dwarf2read.h: Remove use of DEF_VEC_P.
338 (typedef sig_type_ptr): Delete.
339
554ac434
AB
3402019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
341
342 * btrace.c (btrace_maint_clear): Update to handle change from VEC
343 to std::vector.
344 (btrace_maint_decode_pt): Likewise, and move allocation of the
345 vector outside of the loop.
346 (btrace_maint_update_packets): Update to handle change from VEC to
347 std::vector.
348 (btrace_maint_print_packets): Likewise.
349 (maint_info_btrace_cmd): Likewise.
350 * btrace.h: Remove use of DEF_VEC_O.
351 (typedef btrace_pt_packet_s): Delete.
352 (struct btrace_maint_info) <packets>: Change fromm VEC to
353 std::vector.
354 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
355
46f29a9a
AB
3562019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
357
358 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
359 make accesses into the vector constant references.
360 (btrace_add_pc): Update for std::vector.
361 (btrace_stitch_bts): Likewise.
362 (parse_xml_btrace_block): Likewise.
363 (btrace_maint_update_packets): Likewise.
364 (btrace_maint_print_packets): Likewise.
365 (maint_info_btrace_cmd): Likewise.
366 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
367 std::vector.
368 (btrace_data::empty): Likewise.
369 (btrace_data_append): Likewise.
370 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
371 (typedef btrace_block_s): Delete.
372 (struct btrace_block): Add constructor.
373 (struct btrace_data_bts) <blocks>: Change to std::vector.
374 * nat/linux-btrace.c (perf_event_read_bts): Update for
375 std::vector.
376 (linux_read_bts): Likewise.
377
d770d56f
TT
3782019-10-01 Tom Tromey <tom@tromey.com>
379
380 * cli/cli-logging.c (show_logging_filename): Use styled_string.
381
9d636d67
TT
3822019-10-01 Tom Tromey <tom@tromey.com>
383
384 * stack.c (print_frame, info_frame_command_core): Use
385 styled_string.
386 * linux-thread-db.c (try_thread_db_load_1)
387 (try_thread_db_load_from_pdir_1): Use styled_string.
388 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
389 (auto_load_section_scripts, info_auto_load_local_gdbinit)
390 (maybe_print_unsupported_script_warning)
391 (maybe_print_script_not_found_warning): Use styled_string.
392 * ada-lang.c (user_select_syms): Use styled_string.
393
7f6aba03
TT
3942019-10-01 Tom Tromey <tom@tromey.com>
395
396 * p-lang.c (pascal_printstr): Use metadata style.
397 * value.c (show_convenience): Use metadata style.
398 * valprint.c (valprint_check_validity, val_print_optimized_out)
399 (val_print_not_saved, val_print_unavailable)
400 (val_print_invalid_address, generic_val_print, val_print)
401 (value_check_printable, val_print_array_elements): Use metadata
402 style.
403 * ui-out.h (class ui_out) <field_fmt>: New overload.
404 <do_field_fmt>: Add style parameter.
405 * ui-out.c (ui_out::field_fmt): New overload.
406 * typeprint.c (type_print_unknown_return_type)
407 (val_print_not_allocated, val_print_not_associated): Use metadata
408 style.
409 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
410 parameter.
411 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
412 * tracepoint.c (tvariables_info_1): Use metadata style.
413 * stack.c (print_frame_arg, print_frame_info, print_frame)
414 (info_frame_command_core): Use metadata style.
415 * skip.c (info_skip_command): Use metadata style.
416 * rust-lang.c (rust_print_enum): Use metadata style.
417 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
418 metadata style.
419 * python/py-framefilter.c (py_print_single_arg): Use metadata
420 style.
421 * printcmd.c (do_one_display, print_variable_and_value): Use
422 metadata style.
423 * p-valprint.c (pascal_val_print)
424 (pascal_object_print_value_fields): Use metadata style.
425 * p-typeprint.c (pascal_type_print_base): Use metadata style.
426 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
427 parameter.
428 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
429 * m2-valprint.c (m2_print_long_set): Use metadata style.
430 * m2-typeprint.c (m2_print_type): Use metadata style.
431 * infcmd.c (print_return_value_1): Use metadata style.
432 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
433 * f-valprint.c (info_common_command_for_block): Use metadata
434 style.
435 * f-typeprint.c (f_type_print_base): Use metadata style.
436 * expprint.c (print_subexp_standard): Use metadata style.
437 * cp-valprint.c (cp_print_value_fields): Use metadata style.
438 * cli/cli-style.h (class cli_style_option): Add constructor.
439 (metadata_style): Declare.
440 * cli/cli-style.c (metadata_style): New global.
441 (_initialize_cli_style): Register metadata style.
442 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
443 parameter.
444 * cli-out.c (cli_ui_out::do_field_fmt): Update.
445 * c-typeprint.c (c_type_print_base_struct_union)
446 (c_type_print_base_1): Use metadata style.
447 * breakpoint.c (watchpoint_value_print)
448 (print_one_breakpoint_location): Use metadata style.
449 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
450 style.
451 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
452 style.
453 * ada-valprint.c (val_print_packed_array_elements, printstr)
454 (print_field_values, ada_val_print_ref, ada_val_print): Use
455 metadata style.
456 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
457 style.
458 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
459 style.
460 * ada-lang.c (user_select_syms): Use metadata style.
461
14309bb6
TT
4622019-10-01 Tom Tromey <tom@tromey.com>
463
464 * cli/cli-cmds.c (pwd_command): Style output.
465
6a831f06
PA
4662019-10-01 Pedro Alves <palves@redhat.com>
467 Tom Tromey <tom@tromey.com>
468
469 * symtab.c (print_symbol_info): Use %ps.
470 (print_msymbol_info): Use %ps.
471 * symfile.c (symbol_file_add_with_addrs): Use %ps.
472 * printcmd.c (print_variable_and_value): Use %ps.
473 * macrocmd.c (show_pp_source_pos): Use %ps.
474 * infrun.c (print_exited_reason): Use ui_out::message.
475 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
476 (describe_other_breakpoints): Use ui_out::message and new
477 formats.
478 (say_where): Use new formats.
479 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
480 and new formats.
481
2a3c1174
PA
4822019-10-01 Pedro Alves <palves@redhat.com>
483 Tom Tromey <tom@tromey.com>
484
485 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
486 (test_gdb_formats): New function.
487 (run_tests): Call it.
488 (test_format_specifier): Update.
489 * utils.h (fputs_filtered): Update comment.
490 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
491 (fputs_styled_unfiltered): Declare.
492 * utils.c (fputs_styled_unfiltered): New function.
493 (vfprintf_maybe_filtered): Add gdbfmt parameter.
494 (vfprintf_filtered): Update.
495 (vfprintf_unfiltered, vprintf_filtered): Update.
496 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
497 * ui-out.h (enum ui_out_flag) <unfiltered_output,
498 disallow_ui_out_field>: New constants.
499 (enum class field_kind): New.
500 (struct base_field_s, struct signed_field_s): New.
501 (signed_field): New function.
502 (struct string_field_s): New.
503 (string_field): New function.
504 (struct styled_string_s): New.
505 (styled_string): New function.
506 (class ui_out) <message>: Add comment.
507 <vmessage, call_do_message>: New methods.
508 <do_message>: Add style parameter.
509 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
510 methods.
511 (ui_out::message): Rewrite.
512 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
513 parameter.
514 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
515 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
516 gdb_extensions parameter.
517 (class format_piece): Add parameter to constructor.
518 (n_int_args): New field.
519 * gdbsupport/format.c (format_pieces::format_pieces): Add
520 gdb_extensions parameter. Handle '*'.
521 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
522 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
523 vfprintf_styled_no_gdbfmt.
524 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
525 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
526 unfiltered output.
527 * ui-style.h (struct ui_file_style) <ptr>: New method.
528
0dfe5bfb
TT
5292019-10-01 Tom Tromey <tom@tromey.com>
530
531 * unittests/format_pieces-selftests.c: Update. Add final format.
532 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
533 empty literal pieces.
534
e43b10e1
TT
5352019-10-01 Tom Tromey <tom@tromey.com>
536
537 * ui-out.h (enum class ui_out_style_kind): Remove.
538 (class ui_out) <field_string, field_stsream, do_field_string>:
539 Change type of "style".
540 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
541 (ui_out::field_string): Update.
542 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
543 of "style".
544 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
545 * tracepoint.c (print_one_static_tracepoint_marker): Update.
546 * stack.c (print_frame_arg, print_frame_info, print_frame):
547 Update.
548 * source.c (print_source_lines_base): Update.
549 * solib.c (info_sharedlibrary_command): Update.
550 * skip.c (info_skip_command): Update.
551 * record-btrace.c (btrace_call_history_src_line)
552 (btrace_call_history): Update.
553 * python/py-framefilter.c (py_print_frame): Update.
554 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
555 "style".
556 * mi/mi-out.c (mi_ui_out::do_table_header)
557 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
558 (mi_ui_out::do_field_string): Update.
559 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
560 Update.
561 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
562 "style".
563 * cli-out.c (cli_ui_out::do_table_header)
564 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
565 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
566 (cli_ui_out::do_field_fmt): Update.
567 * breakpoint.c (print_breakpoint_location): Update.
568 (update_static_tracepoint): Update.
569
cd7c32c3
PW
5702019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
571
572 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
573 conversion of gdb_datadir.
574 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
575 remove not needed c_str ().
576
8fe0f950
AT
5772019-09-30 Ali Tamur <tamur@google.com>
578
579 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
580 (dwarf2_string_attr): Likewise.
581
5f48f8f3
AT
5822019-09-30 Ali Tamur <tamur@google.com>
583
584 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
585 (process_full_type_unit): Likewise.
586 (dump_die_shallow): Likewise.
587 (cu_debug_loc_section): Likewise.
588
6fb08628
CB
5892019-09-28 Christian Biesinger <cbiesinger@google.com>
590
591 * minsyms.c (compare_minimal_symbols): Rename to...
592 (minimal_symbol_is_less_than): ...this, and adjust to STL
593 conventions (return bool, take arguments as references)
594 (minimal_symbol_reader::install): Call std::sort instead
595 of qsort.
596
c7ee338a
CB
5972019-09-29 Christian Biesinger <cbiesinger@google.com>
598
599 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
600 hash and why.
601 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
602 msymbol_hash, msymbol_demangled_hash>: Improve comments.
603
703a86c2
SM
6042019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
605
606 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
607 * psympriv.h (add_psymbol_to_list): Move comment here and update
608 it.
609
0df0352a
TV
6102019-09-29 Tom de Vries <tdevries@suse.de>
611
612 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
613 Use $tmpdir/$(basename "$output_file").dwz instead of
614 "${output_file}.dwz".
615
ad75efa6
SM
6162019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
617
618 PR gdb/25045
619 * hppa-linux-nat.c: Include gdbarch.h.
620
ececd218
CB
6212019-09-26 Christian Biesinger <cbiesinger@google.com>
622
623 * blockframe.c (find_pc_partial_function): Change return type to bool.
624 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
625 * minsyms.c (in_gnu_ifunc_stub): Likewise.
626 (stub_gnu_ifunc_resolve_name): Likewise.
627 * symtab.c (compare_filenames_for_search): Likewise.
628 (compare_glob_filenames_for_search): Likewise.
629 (matching_obj_sections): Likewise.
630 (symbol_matches_domain): Likewise.
631 (find_line_symtab): Change out param EXACT_MATCH to bool *.
632 (find_line_pc): Change return type to bool.
633 (find_line_pc_range): Likewise.
634 (producer_is_realview): Likewise.
635 * symtab.h (symbol_matches_domain): Likewise.
636 (find_pc_partial_function): Likewise.
637 (find_pc_line_pc_range): Likewise.
638 (in_gnu_ifunc_stub): Likewise.
639 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
640 (find_line_pc): Likewise.
641 (find_line_pc_range): Likewise.
642 (matching_obj_sections): Likewise.
643 (find_line_symtab): Change out parameter to bool.
644 (producer_is_realview): Change return type to bool.
645 (compare_filenames_for_search): Likewise.
646 (compare_glob_filenames_for_search): Likewise.
647
27a900b8
TT
6482019-09-26 Tom Tromey <tom@tromey.com>
649
650 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
651 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
652 * gdb_usleep.h: Remove.
653 * gdb_usleep.c: Remove.
654 * utils.c: Don't include gdb_usleep.h.
655
5d63b30a
TT
6562019-09-26 Tom Tromey <tromey@adacore.com>
657
658 * python/py-type.c (type_to_type_object): Call check_typedef
659 for stub types.
660
12904d37
TT
6612019-09-26 Tom Tromey <tom@tromey.com>
662
663 * utils.h (initialize_utils): Don't declare.
664 * top.c (gdb_init): Don't call initialize_utils.
665 * utils.c (initialize_utils): Remove. Move contents...
666 (_initialize_utils): ... here.
667
858f25f0
TT
6682019-09-25 Tom Tromey <tom@tromey.com>
669
670 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
671 * utils.h (make_hex_string): Don't declare.
672 * utils.c (make_hex_string): Remove.
673
3d435220
TV
6742019-09-24 Tom de Vries <tdevries@suse.de>
675
676 PR gdb/23815
677 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
678 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
679
ddd44b70
DD
6802019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
681
682 * NEWS: Mention new simulator port for PRU.
683
f945dedf
CB
6842019-09-23 Christian Biesinger <cbiesinger@google.com>
685
686 * ada-exp.y (write_object_remaining): Update.
687 * ada-lang.c (ada_decode): Return a std::string instead of a char*
688 and eliminate the static buffer.
689 (ada_decode_symbol): Update.
690 (ada_la_decode): Update.
691 (ada_sniff_from_mangled_name): Update.
692 (is_valid_name_for_wild_match): Update.
693 (ada_lookup_name_info::matches): Update and simplify.
694 (name_matches_regex): Update.
695 (ada_add_global_exceptions): Update.
696 * ada-lang.h (ada_decode): Update signature.
697 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
698 * dwarf-index-write.c (debug_names::insert): Update.
699
7ab78ccb
SM
7002019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
701
702 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
703 formatting.
704
9252448b
SM
7052019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
706
707 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
708 Change "nonzero" to "true" in documentation.
709
626ca2c0
CB
7102019-09-20 Christian Biesinger <cbiesinger@google.com>
711
712 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
713 (_initialize_darwin_solib): Don't set
714 darwin_so_ops.lookup_lib_global_symbol.
715 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
716 set_gdbarch_iterate_over_objfiles_in_search_order.
717 (elf_lookup_lib_symbol): Rename to...
718 (svr4_iterate_over_objfiles_in_search_order): this, and update
719 to iterate semantics.
720 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
721 * solib.c (solib_global_lookup): Remove.
722 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
723 (solib_global_lookup): Remove.
724 * symtab.c (lookup_global_or_static_symbol): Remove call to
725 solib_global_lookup.
726
5a3a0d63
JB
7272019-09-20 Joel Brobecker <brobecker@adacore.com>
728
729 * NEWS: Move entries about default MI version now being
730 version 3, and about the GDB/MI fix for multi-location
731 breakpoints to the "since GDB 8.3" section.
732
ffea1427
JB
7332019-09-20 Joel Brobecker <brobecker@adacore.com>
734
735 GDB 8.3.1 released.
736
abf516c6
UW
7372019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
738
739 * NEWS: Mention that Cell/B.E. debugging support was removed.
740 * MAINTAINERS: Remove spu target.
741
742 * config/djgpp/fnchange.lst: Remove entries for removed files.
743
744 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
745 spu-multiarch.o, and spu-tdep.o.
746 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
747 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
748 spu-multiarch.c, and spu-tdep.c.
749 * spu-linux-nat.c: Remove file.
750 * spu-multiarch.c: Remove file.
751 * spu-tdep.c: Remove file.
752 * spu-tdep.h: Remove file.
753 * solib-spu.c: Remove file.
754 * solib-spu.h: Remove file.
755
756 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
757 * configure.nat (spu-linux): Remove.
758 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
759 solib-multiarch.o from gdb_target_obs.
760 (spu*-*-*): Remove.
761
762 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
763 feature flag.
764 (ppc_linux_no_features): Update.
765 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
766 Cell/B.E. support.
767 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
768 (tdesc_powerpc_cell64l): Likewise.
769 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
770 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
771 Cell/B.E. support.
772 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
773 Do not include "features/rs6000/powerpc-cell32l.c" or
774 "features/rs6000/powerpc-cell64l.c".
775 (ppc_linux_spu_section): Remove.
776 (ppc_linux_core_read_description): Remove Cell/B.E. support.
777 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
778 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
779 (ppc_linux_spe_context_lookup): Remove.
780 (ppc_linux_spe_context_inferior_created): Remove.
781 (ppc_linux_spe_context_solib_loaded): Remove.
782 (ppc_linux_spe_context_solib_unloaded): Remove.
783 (ppc_linux_spe_context): Remove.
784 (struct ppu2spu_cache): Remove.
785 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
786 (struct ppu2spu_data): Remove.
787 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
788 ppu2spu_unwind): Remove.
789 (ppc_linux_init_abi): Remove Cell/B.E. support.
790 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
791
792 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
793 (rs6000/powerpc-cell64l-expedite): Likewise
794 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
795 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
796 rs6000/powerpc-cell64l.xml.
797 * features/rs6000/powerpc-cell32l.xml: Remove.
798 * features/rs6000/powerpc-cell64l.xml: Likewise.
799 * features/rs6000/powerpc-cell32l.c: Remove generated file.
800 * features/rs6000/powerpc-cell64l.c: Likewise.
801 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
802 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
803 * regformats/reg-spu.dat: Remove.
804
805 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
806 * corelow.c (struct spuid_list): Remove.
807 (add_to_spuid_list): Remove.
808 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
809 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
810 (remote_protocol_features): Remove associated entries.
811 (_initialize_remote): No longer initialize them.
812 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
813 * linux-nat.c (SPUFS_MAGIC): Remove.
814 (linux_proc_xfer_spu): Remove.
815 (spu_enumerate_spu_ids): Remove.
816 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
817 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
818 (linux_make_corefile_notes): No longer call it.
819
820 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
821 (cooked_write_test): Likewise.
822
78e8cb91
TT
8232019-09-20 Tom Tromey <tom@tromey.com>
824
825 * NEWS: Mention case-sensitivity of TUI commands.
826 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
827 (tui_set_win_height_command, parse_scrolling_args): Likewise.
828 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
829
f074b67e
TT
8302019-09-20 Tom Tromey <tom@tromey.com>
831
832 * tui/tui-source.c (tui_source_window::set_contents): Use
833 make_unique_xstrdup.
834 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
835 make_unique_xstrdup.
836
63c4bf19
TT
8372019-09-20 Tom Tromey <tom@tromey.com>
838
839 * tui/tui-data.c: Remove separator comments.
840 * tui/tui-layout.c: Remove separator comments.
841 * tui/tui-win.c: Remove separator comments.
842 * tui/tui-wingeneral.c: Remove separator comments.
843
43df9b2f
TT
8442019-09-20 Tom Tromey <tom@tromey.com>
845
846 * tui/tui.h (strcat_to_buf): Don't declare.
847 * tui/tui.c (strcat_to_buf): Remove.
848
7226433c
TT
8492019-09-20 Tom Tromey <tom@tromey.com>
850
851 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
852 from "fullname".
853 * tui/tui-source.c (tui_source_window::set_contents)
854 (tui_source_window::location_matches_p)
855 (tui_source_window::maybe_update): Update.
856
80df3337
TT
8572019-09-20 Tom Tromey <tom@tromey.com>
858
859 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
860 Update.
861 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
862 prefix.
863 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
864 (tui_data_window::line_from_reg_element_no)
865 (tui_data_window::first_reg_element_no_inline)
866 (tui_data_window::show_registers)
867 (tui_data_window::show_register_group)
868 (tui_data_window::display_registers_from)
869 (tui_data_window::display_registers_from_line)
870 (tui_data_window::first_data_item_displayed)
871 (tui_data_window::delete_data_content_windows)
872 (tui_data_window::erase_data_content)
873 (tui_data_window::do_scroll_vertical)
874 (tui_data_window::refresh_window)
875 (tui_data_window::check_register_values): Update.
876
9923f347
TT
8772019-09-20 Tom Tromey <tom@tromey.com>
878
879 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
880 (struct tui_locator_window) <full_name, proc_name>: Now
881 std::string.
882 * tui/tui-stack.c (tui_locator_window::make_status_line)
883 (tui_locator_window::set_locator_fullname)
884 (tui_locator_window::set_locator_info): Update.
885 * tui/tui-source.c (tui_source_window::set_contents)
886 (tui_source_window::showing_source_p): Update.
887
b76251ab
TT
8882019-09-20 Tom Tromey <tom@tromey.com>
889
890 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
891 Don't call tui_locator_win_info_ptr.
892
0891be08
TT
8932019-09-20 Tom Tromey <tom@tromey.com>
894
895 * tui/tui-win.c (tui_resize_all): Don't call refresh.
896
1b935acf
TT
8972019-09-20 Tom Tromey <tom@tromey.com>
898
899 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
900 height for locator.
901 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
902 * tui/tui-layout.c (show_source_disasm_command, show_data)
903 (show_source_or_disasm_and_command): Use 1 as height for locator.
904
9abd8a65
TT
9052019-09-20 Tom Tromey <tom@tromey.com>
906
907 * tui/tui.c (tui_enable): Update.
908 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
909 Update.
910 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
911 Update.
912 * tui/tui-data.c (win_resized): Now bool.
913 (tui_win_resized): Return bool.
914 (tui_set_win_resized_to): Accept a bool.
915
b5457826
TT
9162019-09-20 Tom Tromey <tom@tromey.com>
917
918 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
919 Change type of "refresh_values_only".
920 * tui/tui-regs.c (tui_data_window::show_register_group): Change
921 type of "refresh_values_only".
922
6b915f7d
TT
9232019-09-20 Tom Tromey <tom@tromey.com>
924
925 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
926 std::string.
927 (tui_disassemble): Add "pos" parameter.
928 (tui_disasm_window::set_contents): Simplify.
929
2ad52f6f
TT
9302019-09-20 Tom Tromey <tom@tromey.com>
931
932 * tui/tui-winsource.h (struct tui_source_window_base)
933 <show_source_content>: Now private.
934 * tui/tui-winsource.c
935 (tui_source_window_base::show_source_content): Don't handle empty
936 content case.
937
b3b1bde6
TT
9382019-09-20 Tom Tromey <tom@tromey.com>
939
940 * tui/tui-layout.c (show_source_disasm_command)
941 (show_source_or_disasm_and_command): Don't call
942 show_source_content.
943
71a25ed2
TT
9442019-09-20 Tom Tromey <tom@tromey.com>
945
946 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
947 Declare.
948 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
949 from tui_make_status_line.
950 (tui_locator_window::rerender): Update.
951
f8532154
TT
9522019-09-20 Tom Tromey <tom@tromey.com>
953
954 * tui/tui-stack.c (tui_make_status_line): Return std::string.
955 (tui_locator_window::rerender): Update.
956
2d81b349
TT
9572019-09-20 Tom Tromey <tom@tromey.com>
958
959 * tui/tui-winsource.h (struct tui_source_window_base)
960 <~tui_source_window_base>: Don't declare.
961 <fullname>: Remove.
962 * tui/tui-winsource.c (~tui_source_window_base): Remove.
963 * tui/tui-source.h (struct tui_source_window) <fullname>: New
964 member.
965 * tui/tui-source.c (tui_source_window::set_contents): Update.
966 (tui_source_window::location_matches_p)
967 (tui_source_window::maybe_update): Update.
968
f14bec58
TT
9692019-09-20 Tom Tromey <tom@tromey.com>
970
971 * tui/tui-winsource.h (~tui_source_element): Remove.
972 (tui_source_element): Update.
973 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
974 * tui/tui-winsource.c (tui_show_source_line): Update.
975 * tui/tui-source.c (tui_source_window::set_contents): Update.
976 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
977
78d5933a
TT
9782019-09-20 Tom Tromey <tom@tromey.com>
979
980 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
981 declare.
982 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
983 tui_clear_source_windows_detail.
984 * tui/tui-winsource.h (struct tui_source_window_base)
985 <clear_detail>: Don't declare.
986 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
987 Remove.
988 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
989
d4207696
TT
9902019-09-20 Tom Tromey <tromey@adacore.com>
991
992 PR ada/24919:
993 * block.c (contained_in): Fix final return value.
994
00f93c44
AM
9952019-09-20 Alan Modra <amodra@gmail.com>
996
997 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
998 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
999 (read_indirect_string_from_dwz): Use bfd accessor.
1000 * dwarf2read.h (struct dwz_file <filename>): Likewise.
1001 * machoread.c (macho_symfile_read_all_oso): Likewise.
1002 * solib.c (solib_bfd_open): Likewise.
1003
e4153ae6
CB
10042019-09-19 Christian Biesinger <cbiesinger@google.com>
1005
1006 * eval.c: Move declaration of overload_resolution to...
1007 * value.h: ...here.
1008
c7ae7675
CB
10092019-09-19 Christian Biesinger <cbiesinger@google.com>
1010
1011 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1012 * arm-linux-tdep.c: Likewise.
1013 * arm-nbsd-nat.c: Likewise.
1014 * arm-tdep.h: Declare arm_apcs_32.
1015 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1016
e86f08d2
CB
10172019-09-19 Christian Biesinger <cbiesinger@google.com>
1018
1019 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1020 * dwarf2read.h: Declare dwarf_always_disassemble.
1021
f64e2f40
TV
10222019-09-19 Tom de Vries <tdevries@suse.de>
1023
1024 PR gdb/25009
1025 * source-cache.c (source_cache::ensure): Catch exception thrown during
1026 construction of the highlighter.
1027
fd361982
AM
10282019-09-18 Alan Modra <amodra@gmail.com>
1029
1030 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1031 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1032 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1033 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1034 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1035 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1036 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1037 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1038 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1039 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1040 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1041 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1042 * solib-spu.c, * solib-svr4.c, * solib-target.c,
1043 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1044 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1045 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1046 * mi/mi-interp.c: Update throughout for bfd section macro and
1047 function changes.
1048 * gcore (gcore_create_callback): Use bfd_set_section_lma.
1049 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1050
11061048
TT
10512019-09-18 Tom Tromey <tom@tromey.com>
1052
1053 * NEWS: Add entry.
1054 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
1055 call rl_initialize.
1056 (tui_enable): Do not call rl_initialize.
1057
7a27b85f
CG
10582019-09-18 Christian Groessler <chris@groessler.org>
1059
1060 * alpha-linux-nat.c: Include gdbarch.h.
1061
f64eea3a
SM
10622019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
1063
1064 * ui-file.c: Include cli/cli-style.h.
1065 (term_cli_styling): Remove cli_styling declaration.
1066
e6f7f6d1
AM
10672019-09-18 Alan Modra <amodra@gmail.com>
1068
1069 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1070 to bfd_asymbol_section.
1071
1d38e9d1
AM
10722019-09-18 Alan Modra <amodra@gmail.com>
1073
1074 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1075 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1076 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1077
90d92a63
AM
10782019-09-18 Alan Modra <amodra@gmail.com>
1079
1080 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1081 * spu-linux-nat.c (spu_bfd_open): Likewise.
1082
a3d181d2
CB
10832019-09-18 Christian Biesinger <cbiesinger@google.com>
1084
1085 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1086 to bool to match definition in dwarf2read.c.
1087
491144b5
CB
10882019-09-17 Christian Biesinger <cbiesinger@google.com>
1089
1090 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1091 (print_signatures): Likewise.
1092 (trust_pad_over_xvs): Likewise.
1093 * arch/aarch64-insn.c (aarch64_debug): Likewise.
1094 * arch/aarch64-insn.h (aarch64_debug): Likewise.
1095 * arm-linux-nat.c (arm_apcs_32): Likewise.
1096 * arm-linux-tdep.c (arm_apcs_32): Likewise.
1097 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1098 * arm-tdep.c (arm_debug): Likewise.
1099 (arm_apcs_32): Likewise.
1100 * auto-load.c (debug_auto_load): Likewise.
1101 (auto_load_gdb_scripts): Likewise.
1102 (global_auto_load): Likewise.
1103 (auto_load_local_gdbinit): Likewise.
1104 (auto_load_local_gdbinit_loaded): Likewise.
1105 * auto-load.h (global_auto_load): Likewise.
1106 (auto_load_local_gdbinit): Likewise.
1107 (auto_load_local_gdbinit_loaded): Likewise.
1108 * breakpoint.c (disconnected_dprintf): Likewise.
1109 (breakpoint_proceeded): Likewise.
1110 (automatic_hardware_breakpoints): Likewise.
1111 (always_inserted_mode): Likewise.
1112 (target_exact_watchpoints): Likewise.
1113 (_initialize_breakpoint): Update.
1114 * breakpoint.h (target_exact_watchpoints): Change to bool.
1115 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1116 * cli/cli-cmds.c (trace_commands): Likewise.
1117 * cli/cli-cmds.h (trace_commands): Likewise.
1118 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1119 to bool*.
1120 * cli/cli-logging.c (logging_overwrite): Change to bool.
1121 (logging_redirect): Likewise.
1122 (debug_redirect): Likewise.
1123 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1124 (struct boolean_option_def) <get_var_address_cb_>: Change return type
1125 to bool.
1126 <boolean_option_def>: Update.
1127 (struct flag_option_def): Change default type of Context to bool
1128 from int.
1129 <flag_option_def>: Change return type of var_address_cb_ to bool*.
1130 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1131 (get_setshow_command_value_string): Likewise.
1132 * cli/cli-style.c (cli_styling): Change to bool.
1133 (source_styling): Likewise.
1134 * cli/cli-style.h (source_styling): Likewise.
1135 (cli_styling): Likewise.
1136 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1137 to bool.
1138 * command.h (var_types): Update comment.
1139 (add_setshow_boolean_cmd): Change int* var argument to bool*.
1140 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1141 bool.
1142 (debug_compile_cplus_scopes): Likewise.
1143 * compile/compile-internal.h (compile_debug): Likewise.
1144 * compile/compile.c (compile_debug): Likewise.
1145 (struct compile_options) <raw>: Likewise.
1146 * cp-support.c (catch_demangler_crashes): Likewise.
1147 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1148 (usr_cmd_cris_dwarf2_cfi): Likewise.
1149 * csky-tdep.c (csky_debug): Likewise.
1150 * darwin-nat.c (enable_mach_exceptions): Likewise.
1151 * dcache.c (dcache_enabled_p): Likewise.
1152 * defs.h (info_verbose): Likewise.
1153 * demangle.c (demangle): Likewise.
1154 (asm_demangle): Likewise.
1155 * dwarf-index-cache.c (debug_index_cache): Likewise.
1156 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1157 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1158 * dwarf2read.c (check_physname): Likewise.
1159 (use_deprecated_index_sections): Likewise.
1160 (dwarf_always_disassemble): Likewise.
1161 * eval.c (overload_resolution): Likewise.
1162 * event-top.c (set_editing_cmd_var): Likewise.
1163 (exec_done_display_p): Likewise.
1164 * event-top.h (set_editing_cmd_var): Likewise.
1165 (exec_done_display_p): Likewise.
1166 * exec.c (write_files): Likewise.
1167 * fbsd-nat.c (debug_fbsd_lwp): Likewise
1168 (debug_fbsd_nat): Likewise.
1169 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1170 Likewise.
1171 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1172 <backtrace_past_entry> Likewise.
1173 * gdb-demangle.h (demangle): Likewise.
1174 (asm_demangle): Likewise.
1175 * gdb_bfd.c (bfd_sharing): Likewise.
1176 * gdbcore.h (write_files): Likewise.
1177 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1178 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1179 * gdbthread.h (print_thread_events): Likewise.
1180 * gdbtypes.c (opaque_type_resolution): Likewise.
1181 (strict_type_checking): Likewise.
1182 * gnu-nat.c (gnu_debug_flag): Likewise.
1183 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1184 * guile/scm-param.c (pascm_variable): Add boolval.
1185 (add_setshow_generic): Update.
1186 (pascm_param_value): Update.
1187 (pascm_set_param_value_x): Update.
1188 * hppa-tdep.c (hppa_debug): Change to bool..
1189 * infcall.c (may_call_functions_p): Likewise.
1190 (coerce_float_to_double_p): Likewise.
1191 (unwind_on_signal_p): Likewise.
1192 (unwind_on_terminating_exception_p): Likewise.
1193 * infcmd.c (startup_with_shell): Likewise.
1194 * inferior.c (print_inferior_events): Likewise.
1195 * inferior.h (startup_with_shell): Likewise.
1196 (print_inferior_events): Likewise.
1197 * infrun.c (step_stop_if_no_debug): Likewise.
1198 (detach_fork): Likewise.
1199 (debug_displaced): Likewise.
1200 (disable_randomization): Likewise.
1201 (non_stop): Likewise.
1202 (non_stop_1): Likewise.
1203 (observer_mode): Likewise.
1204 (observer_mode_1): Likewise.
1205 (set_observer_mode): Update.
1206 (sched_multi): Change to bool.
1207 * infrun.h (debug_displaced): Likewise.
1208 (sched_multi): Likewise.
1209 (step_stop_if_no_debug): Likewise.
1210 (non_stop): Likewise.
1211 (disable_randomization): Likewise.
1212 * linux-tdep.c (use_coredump_filter): Likewise.
1213 (dump_excluded_mappings): Likewise.
1214 * linux-thread-db.c (auto_load_thread_db): Likewise.
1215 (check_thread_db_on_load): Likewise.
1216 * main.c (captured_main_1): Update.
1217 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1218 xx2_opt, boolean_opt>: Change to bool.
1219 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1220 * maint.c (maintenance_profile_p): Likewise.
1221 (per_command_time): Likewise.
1222 (per_command_space): Likewise.
1223 (per_command_symtab): Likewise.
1224 * memattr.c (inaccessible_by_default): Likewise.
1225 * mi/mi-main.c (mi_async): Likewise.
1226 (mi_async_1): Likewise.
1227 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1228 * nat/fork-inferior.h (startup_with_shell): Likewise.
1229 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1230 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1231 * nios2-tdep.c (nios2_debug): Likewise.
1232 * or1k-tdep.c (or1k_debug): Likewise.
1233 * parse.c (parser_debug): Likewise.
1234 * parser-defs.h (parser_debug): Likewise.
1235 * printcmd.c (print_symbol_filename): Likewise.
1236 * proc-api.c (procfs_trace): Likewise.
1237 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1238 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1239 (set_parameter_value): Update.
1240 (add_setshow_generic): Update.
1241 * python/py-value.c (copy_py_bool_obj): Change argument from int*
1242 to bool*.
1243 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1244 int*.
1245 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1246 * record-btrace.c (record_btrace_target::store_registers): Update.
1247 * record-full.c (record_full_memory_query): Change to bool.
1248 (record_full_stop_at_limit): Likewise.
1249 * record-full.h (record_full_memory_query): Likewise.
1250 * remote-notif.c (notif_debug): Likewise.
1251 * remote-notif.h (notif_debug): Likewise.
1252 * remote.c (use_range_stepping): Likewise.
1253 (interrupt_on_connect): Likewise.
1254 (remote_break): Likewise.
1255 * ser-tcp.c (tcp_auto_retry): Likewise.
1256 * ser-unix.c (serial_hwflow): Likewise.
1257 * skip.c (debug_skip): Likewise.
1258 * solib-aix.c (solib_aix_debug): Likewise.
1259 * spu-tdep.c (spu_stop_on_load_p): Likewise.
1260 (spu_auto_flush_cache_p): Likewise.
1261 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1262 Likewise.
1263 (struct info_print_options) <quiet>: Likewise.
1264 * symfile-debug.c (debug_symfile): Likewise.
1265 * symfile.c (auto_solib_add): Likewise.
1266 (separate_debug_file_debug): Likewise.
1267 * symfile.h (auto_solib_add): Likewise.
1268 (separate_debug_file_debug): Likewise.
1269 * symtab.c (basenames_may_differ): Likewise.
1270 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1271 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1272 (struct info_types_options) <quiet>: Likewise.
1273 * symtab.h (demangle): Likewise.
1274 (basenames_may_differ): Likewise.
1275 * target-dcache.c (stack_cache_enabled_1): Likewise.
1276 (code_cache_enabled_1): Likewise.
1277 * target.c (trust_readonly): Likewise.
1278 (may_write_registers): Likewise.
1279 (may_write_memory): Likewise.
1280 (may_insert_breakpoints): Likewise.
1281 (may_insert_tracepoints): Likewise.
1282 (may_insert_fast_tracepoints): Likewise.
1283 (may_stop): Likewise.
1284 (auto_connect_native_target): Likewise.
1285 (target_stop_and_wait): Update.
1286 (target_async_permitted): Change to bool.
1287 (target_async_permitted_1): Likewise.
1288 (may_write_registers_1): Likewise.
1289 (may_write_memory_1): Likewise.
1290 (may_insert_breakpoints_1): Likewise.
1291 (may_insert_tracepoints_1): Likewise.
1292 (may_insert_fast_tracepoints_1): Likewise.
1293 (may_stop_1): Likewise.
1294 * target.h (target_async_permitted): Likewise.
1295 (may_write_registers): Likewise.
1296 (may_write_memory): Likewise.
1297 (may_insert_breakpoints): Likewise.
1298 (may_insert_tracepoints): Likewise.
1299 (may_insert_fast_tracepoints): Likewise.
1300 (may_stop): Likewise.
1301 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1302 (make_thread_apply_all_options_def_group): Change argument from int*
1303 to bool*.
1304 (thread_apply_all_command): Update.
1305 (print_thread_events): Change to bool.
1306 * top.c (confirm): Likewise.
1307 (command_editing_p): Likewise.
1308 (history_expansion_p): Likewise.
1309 (write_history_p): Likewise.
1310 (info_verbose): Likewise.
1311 * top.h (confirm): Likewise.
1312 (history_expansion_p): Likewise.
1313 * tracepoint.c (disconnected_tracing): Likewise.
1314 (circular_trace_buffer): Likewise.
1315 * typeprint.c (print_methods): Likewise.
1316 (print_typedefs): Likewise.
1317 * utils.c (debug_timestamp): Likewise.
1318 (sevenbit_strings): Likewise.
1319 (pagination_enabled): Likewise.
1320 * utils.h (sevenbit_strings): Likewise.
1321 (pagination_enabled): Likewise.
1322 * valops.c (overload_resolution): Likewise.
1323 * valprint.h (struct value_print_options) <prettyformat_arrays,
1324 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1325 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1326 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1327 Likewise.
1328 * windows-nat.c (new_console): Likewise.
1329 (cygwin_exceptions): Likewise.
1330 (new_group): Likewise.
1331 (debug_exec): Likewise.
1332 (debug_events): Likewise.
1333 (debug_memory): Likewise.
1334 (debug_exceptions): Likewise.
1335 (useshell): Likewise.
1336 * windows-tdep.c (maint_display_all_tib): Likewise.
1337 * xml-support.c (debug_xml): Likewise.
1338
f1b620e9
MG
13392019-09-17 Mike Gulick <mgulick@mathworks.com>
1340
1341 * source.c (prepare_path_for_appending): New function.
1342 (openp): Make use of new function.
1343 (find_and_open_source): Search for the compilation directory and
1344 source file as a relative path beneath the directory search path.
1345
67f3ed6a
AB
13462019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
1347
1348 * source-cache.c (source_cache::get_line_charpos): Catch
1349 exceptions and return false, this matches the behaviour documented
1350 in the header file.
1351
74332189
JB
13522019-09-17 Joel Brobecker <brobecker@adacore.com>
1353
1354 * ada-tasks.c (info_task): Remove quoting of the task's name.
1355
f2f24aa9
CB
13562019-09-16 Christian Biesinger <cbiesinger@google.com>
1357
1358 * symfile.c (auto_solib_add): Replace comment with a reference
1359 to the header file.
1360
6a062a93
CB
13612019-09-14 Christian Biesinger <cbiesinger@google.com>
1362
1363 * NEWS: Mention that gdb can now be compiled with Python 3
1364 on Windows.
1365
ec6c8338
AB
13662019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1367
1368 * maint.c (maint_print_section_data::maint_print_section_data):
1369 Force use of 'float log10 (float)' by casting the argument to
1370 float.
1371
aa17805f
AB
13722019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1373
1374 * maint.c: Add 'cmath' include.
1375 (struct maint_print_section_data): New structure.
1376 (print_section_index): New function.
1377 (print_bfd_section_info): Add header comment, small whitespace
1378 cleanup, and update to call new print_section_index function.
1379 (print_objfile_section_info): Likewise.
1380 (maint_obj_section_from_bfd_section): New function.
1381 (print_bfd_section_info_maybe_relocated): New function.
1382 (maintenance_info_sections): Add header comment, always use
1383 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1384
3dd9bb46
AB
13852019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
1386
1387 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1388 inner scope, add check that the objfile has psymtabs before
1389 checking psymtabs_addrmap.
1390 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1391
4993045d
PW
13922019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1393
1394 * NEWS: Announce that Ada task names are now shown at more places,
1395 and between quotes (except in info task output).
1396 * gdb/ada-tasks.c (task_to_str): New function.
1397 (display_current_task_id): Call task_to_str.
1398 (task_command_1): Likewise.
1399 (print_ada_task_info): In non-mi mode, Properly align headers and data
1400 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1401
7a289707
RO
14022019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1403
1404 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1405 prstatus.pr_lwp.pr_info instead of making it up.
1406
f2aec7f6
CB
14072019-09-11 Christian Biesinger <cbiesinger@google.com>
1408
1409 * auto-load.c (auto_load_expand_dir_vars): Update.
1410 * defs.h (gdb_datadir): Change to std::string.
1411 (python_libdir): Likewise.
1412 (relocate_gdb_directory): Change return type to std::string.
1413 * guile/guile.c (gdbscm_data_directory): Update.
1414 (initialize_scheme_side): Update.
1415 * jit.c (jit_reader_dir): Change to std::string.
1416 (jit_reader_load_command): Update.
1417 * main.c (gdb_datadir): Change to std::string.
1418 (python_libdir): Likewise.
1419 (set_gdb_data_directory): Update.
1420 (relocate_path): Change to return std::string.
1421 (relocate_gdb_directory): Change to return std::string.
1422 (relocate_gdbinit_path_maybe_in_datadir): Update.
1423 (captured_main_1): Update.
1424 * python/python.c (do_start_initialization): Update.
1425 * top.c (show_gdb_datadir): Update.
1426 * xml-syscall.c (xml_init_syscalls_info): Update.
1427 (init_syscalls_info): Update.
1428
9224a013
CB
14292019-09-11 Christian Biesinger <cbiesinger@google.com>
1430
1431 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1432 out of get_init_files.
1433 (get_init_files): Update.
1434
f48cd836
CB
14352019-09-11 Christian Biesinger <cbiesinger@google.com>
1436
1437 * main.c (get_init_files): Change to use std::string.
1438 (captured_main_1): Update.
1439 (print_gdb_help): Update.
1440
9cab7ecd
AT
14412019-09-11 Ali Tamur <tamur@google.com>
1442
1443 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1444 implementation.
1445
67547d89
CB
14462019-09-11 Christian Biesinger <cbiesinger@google.com>
1447
1448 * dbxread.c (read_dbx_symtab): Update.
1449 * dwarf2read.c (load_partial_dies): Update.
1450 * mdebugread.c (parse_partial_symbols): Update.
1451 (handle_psymbol_enumerators): Update.
1452 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1453 * psymtab.c (add_psymbol_to_bcache): Likewise.
1454 (add_psymbol_to_list): Likewise.
1455 * symtab.c (symbol_set_names): Likewise.
1456 * symtab.h (symbol_set_names): Likewise.
1457 * xcoffread.c (scan_xcoff_symtab): Update.
1458
64b2d4a0
TT
14592019-09-11 Tom Tromey <tom@tromey.com>
1460
1461 * symfile-mem.c (symbol_file_add_from_memory): Use
1462 bfd_set_filename.
1463 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1464 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1465
3b00ef10
TT
14662019-09-10 Tom Tromey <tromey@adacore.com>
1467
1468 * dwarf-index-write.c (write_psymbols): Extend error message.
1469 (debug_names::insert): Add Ada code.
1470 (debug_names::write_psymbols): Remove Ada check.
1471 (debug_names) <m_string_obstack>: New member.
1472 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1473 (gdb_index_symbol_name_matcher::matches): Remove.
1474 (mapped_index_base::find_name_components_bounds): Add "lang"
1475 parameter.
1476 (mapped_index_base::build_name_components): Also split names
1477 according to Ada syntax.
1478 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
1479 type of "match_callback".
1480 (check_match, check_find_bounds_finds)
1481 (dw2_expand_symtabs_matching): Update.
1482 (dw2_debug_names_iterator): Add new constructor.
1483 (dw2_debug_names_map_matching_symbols): New function.
1484 (dw2_debug_names_expand_symtabs_matching): Update.
1485 (dwarf2_debug_names_functions): Use
1486 dw2_debug_names_map_matching_symbols.
1487
aa391654
TT
14882019-09-10 Tom Tromey <tromey@adacore.com>
1489
1490 * dwarf2read.c (dw2_get_file_names_reader): Add the
1491 CU's file name to the results.
1492
b054970d
TT
14932019-09-10 Tom Tromey <tromey@adacore.com>
1494
1495 * ada-lang.c (add_nonlocal_symbols): Combine calls to
1496 map_matching_symbols. Update.
1497 * dwarf2read.c (dw2_map_matching_symbols): Update.
1498 * psymtab.c (match_partial_symbol): Change type; update.
1499 (psym_map_matching_symbols): Likewise.
1500 * symfile-debug.c (debug_qf_map_matching_symbols): Change
1501 type; update.
1502 * symfile.h (struct quick_symbol_functions)
1503 <map_matching_symbols>: Change "name" to be a lookup_name_info.
1504 Remove "match".
1505
6a3dbf1b
TT
15062019-09-10 Tom Tromey <tromey@adacore.com>
1507
1508 * psymtab.c (map_block): Remove.
1509 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1510 * symtab.c (iterate_over_symbols_terminated): New function.
1511 * symtab.c (iterate_over_symbols_terminated): Declare.
1512
6969f124
TT
15132019-09-10 Tom Tromey <tromey@adacore.com>
1514
1515 * ada-lang.c (ada_iterate_over_symbols): Return bool.
1516 * language.h (struct language_defn) <la_iterate_over_symbols>:
1517 Return bool.
1518 * symtab.c (iterate_over_symbols): Return bool.
1519 * symtab.h (iterate_over_symbols): Return bool.
1520
199b4314
TT
15212019-09-10 Tom Tromey <tromey@adacore.com>
1522
1523 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1524 (add_nonlocal_symbols): Update.
1525 * dwarf2read.c (dw2_map_matching_symbols): Change type.
1526 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1527 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1528 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1529 Change type of "callback". Remove "data".
1530
a084a2a6
AT
1531
15322019-09-09 Ali Tamur <tamur@google.com>
1533
1534 * dwarf2read.c (comp_unit_head): Update comment.
1535 (dwarf2_dwo_name): New function declaration.
1536 (dwarf_unit_type_name): New function declaration.
1537 (read_comp_unit_head): Add support for new compilation units,
1538 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1539 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1540 (currently named as "signature") in their header. Also clarify error
1541 messages.
1542 (lookup_dwo_id): New function. Returns the dwo id of the given
1543 compile unit.
1544 (lookup_dwo_unit): Use the new lookup_dwo_id function.
1545 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1546 functions.
1547 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1548 (dwarf2_dwo_name): Get the dwo name if present.
1549 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1550 purposes.
1551
25a2915e
TT
15522019-09-09 Tom Tromey <tom@tromey.com>
1553
1554 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1555
e4df0874
PW
15562019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1557
1558 * python/python.c (do_start_initialization): Make progname_copy static,
1559 to avoid a leak report.
1560
8634b462
TT
15612019-09-08 Tom Tromey <tom@tromey.com>
1562
1563 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1564
c7f839cb
SM
15652019-09-07 Simon Marchi <simon.marchi@efficios.com>
1566
1567 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1568 Change type to gdb::optional<block_enum>.
1569 (dw2_symtab_iter_init): Change block_index parameter type
1570 to gdb::optional<block_enum>.
1571 (dw2_lookup_symbol): Change block_index parameter
1572 type to block_enum.c
1573 (dw2_debug_names_lookup_symbol): Likewise.
1574 * psymtab.c (psym_lookup_symbol): Likewise.
1575 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1576 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1577 Likewise.
1578
ead0e69a
CB
15792019-09-06 Christian Biesinger <cbiesinger@google.com>
1580
1581 * defs.h (relocate_gdb_directory): Change int to bool in
1582 signature and rename flag to relocatable.
1583 * main.c (relocate_path): Likewise.
1584 (relocate_gdb_directory): Likewise.
1585
b16c44de
AM
15862019-09-06 Alan Modra <amodra@gmail.com>
1587
1588 * coffread.c (coff_symfile_read): Constify filename variable.
1589 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1590 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1591 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1592 * solib.c (reload_shared_libraries_1): Likewise.
1593 * symfile.c (reread_symbols): Likewise.
1594 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1595 * solib-darwin.c (darwin_bfd_open): Likewise.
1596 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1597
06ff036e
AB
15982019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
1599
1600 * psymtab.c (print_partial_symbols): Handle missing domain_enum
1601 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1602
4e962e74
TT
16032019-09-03 Tom Tromey <tromey@adacore.com>
1604
1605 * ada-valprint.c (ada_val_print_num): Don't recurse for range
1606 types.
1607 (has_negatives): Unbias a range type bound.
1608 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1609 * gdbtypes.c (operator==): Handle new field.
1610 (create_range_type): Add "bias" parameter.
1611 (create_static_range_type, resolve_dynamic_range): Update.
1612 * gdbtypes.h (struct range_bounds) <bias>: New member.
1613 (create_range_type): Add bias parameter.
1614 * printcmd.c (print_scalar_formatted): Unbias range types.
1615 * value.c (unpack_long): Unbias range types.
1616 (pack_long): Bias range types.
1617
d90b8f26
AH
16182019-09-02 Alan Hayward <alan.hayward@arm.com>
1619
1620 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1621 probe arguments.
1622
fe01123e
AH
16232019-09-02 Alan Hayward <alan.hayward@arm.com>
1624
1625 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1626 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1627 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1628 (compile_probe_arg): Likewise.
1629 * probe.h (get_argument_count): Likewise.
1630 * solib-svr4.c (solib_event_probe_action): Likewise.
1631 * stap-probe.c (stap_probe::get_argument_count): Likewise.
1632
e661ef01
AH
16332019-09-02 Alan Hayward <alan.hayward@arm.com>
1634
1635 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1636 code to here...
1637 (svr4_create_solib_event_breakpoints): ...from here.
1638
47a536d9
SDJ
16392019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
1640
1641 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1642 suffix from warning message.
1643
d6a00eba
TT
16442019-08-30 Tom Tromey <tom@tromey.com>
1645
1646 * tui/tui-winsource.h (struct tui_source_window_base)
1647 <refresh_all>: Don't declare.
1648 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1649 Remove.
1650 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1651 tui_show_locator_content.
1652 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1653 declare.
1654 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1655 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1656 declare.
1657
55b2657b
TT
16582019-08-30 Tom Tromey <tom@tromey.com>
1659
1660 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1661
12a8555a
TT
16622019-08-30 Tom Tromey <tom@tromey.com>
1663
1664 * tui/tui-stack.c (_initialize_tui_stack): Move later.
1665 Remove unnecessary forward declarations.
1666
900ac242
TT
16672019-08-30 Tom Tromey <tom@tromey.com>
1668
1669 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1670 rerender.
1671 (tui_update_locator_fullname, tui_show_frame_info): Don't call
1672 tui_show_locator_content.
1673
99ab33fb
TT
16742019-08-30 Tom Tromey <tom@tromey.com>
1675
1676 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
1677 (tui_locator_window::rerender): Rewrite using body of previous
1678 tui_show_locator_content.
1679
e594a5d1
TT
16802019-08-30 Tom Tromey <tom@tromey.com>
1681
1682 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1683 set_locator_fullname>: New methods.
1684 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1685 Rename from tui_set_locator_fullname.
1686 (tui_locator_window::set_locator_info): Rename from
1687 tui_set_locator_info. Return bool.
1688 (tui_update_locator_fullname, tui_show_frame_info): Update.
1689
715bb467
TT
16902019-08-30 Tom Tromey <tom@tromey.com>
1691
1692 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1693
772f3f03
TT
16942019-08-30 Tom Tromey <tom@tromey.com>
1695
1696 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1697 call touchwin.
1698
108e13ab
TT
16992019-08-30 Tom Tromey <tom@tromey.com>
1700
1701 * tui/tui-wingeneral.c (box_win): Assume win_info and
1702 win_info->handle cannot be NULL.
1703
cdaa6eb4
TT
17042019-08-30 Tom Tromey <tom@tromey.com>
1705
1706 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1707 refresh_window>: Declare.
1708 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1709 resize.
1710 (tui_data_item_window::rerender): Rename from
1711 tui_display_register.
1712 (tui_data_item_window::refresh_window): New method.
1713 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1714 no-op.
1715
89df7f90
TT
17162019-08-30 Tom Tromey <tom@tromey.com>
1717
1718 * tui/tui-regs.h (struct tui_data_window) <regs_content,
1719 regs_column_count, current_group>: Move later. Now private.
1720 <get_current_group>: New method.
1721 * tui/tui-regs.c (tui_reg_command): Update.
1722 * tui/tui-layout.c (tui_set_layout): Update.
1723
1bf2866a
TT
17242019-08-30 Tom Tromey <tom@tromey.com>
1725
1726 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1727 (tui_data_window::rerender): Don't call
1728 check_and_display_highlight_if_needed.
1729 (tui_data_window::refresh_all): Remove call to
1730 erase_data_content.
1731
0670413d
TT
17322019-08-30 Tom Tromey <tom@tromey.com>
1733
1734 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1735 (tui_data_window::display_registers_from)
1736 (tui_data_window::display_reg_element_at_line)
1737 (tui_data_window::display_registers_from_line): Remove checks of
1738 "empty".
1739
18bb55c7
TT
17402019-08-30 Tom Tromey <tom@tromey.com>
1741
1742 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1743 Don't declare.
1744 * tui/tui-regs.c (tui_data_window::show_registers): Call
1745 rerender.
1746 (tui_data_window::rerender): Rename from display_all_data.
1747 (tui_data_window::rerender): Remove old implementation.
1748
1f6d2f10
TT
17492019-08-30 Tom Tromey <tom@tromey.com>
1750
1751 * tui/tui-regs.c (tui_data_window::display_all_data): Change
1752 text.
1753 * tui/tui-data.h (NO_DATA_STRING): Remove define.
1754
16d01f9c
BW
17552019-08-29 Bernhard Wodok <barto@gmx.net>
1756 Sergio Durigan Junior <sergiodj@redhat.com>
1757
1758 PR win32/24284
1759 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1760
d8f27c60
AB
17612019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1762
1763 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1764 when searching for types.
1765
1f20c35e
AB
17662019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
1767
1768 * f-lang.c (f_language_defn): Use f_print_typedef.
1769 * f-lang.h (f_print_typedef): Declare.
1770 * f-typeprint.c (f_print_typedef): Define.
1771
550105b7
CB
17722019-08-27 Christian Biesinger <cbiesinger@google.com>
1773
1774 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1775
4acfdd20
AB
17762019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
1777
1778 * cli/cli-utils.c (info_print_options_defs): Delete.
1779 (make_info_print_options_def_group): Delete.
1780 (extract_info_print_options): Delete.
1781 (info_print_command_completer): Delete.
1782 (info_print_args_help): Add extra parameter, and optionally
1783 include text about -n flag.
1784 * cli/cli-utils.h (struct info_print_options): Delete.
1785 (extract_info_print_options): Delete declaration.
1786 (info_print_command_completer): Delete declaration.
1787 (info_print_args_help): Add extra parameter, extend header
1788 comment.
1789 * python/python.c (gdbpy_rbreak): Pass additional parameter to
1790 search_symbols.
1791 * stack.c (struct info_print_options): New type.
1792 (info_print_options_defs): New file scoped variable.
1793 (make_info_print_options_def_group): New static function.
1794 (info_print_command_completer): New static function.
1795 (info_locals_command): Update to use new local functions.
1796 (info_args_command): Likewise.
1797 (_initialize_stack): Add extra parameter to calls to
1798 info_print_args_help.
1799 * symtab.c (search_symbols): Add extra parameter, use this to
1800 possibly excluse non-debug symbols.
1801 (symtab_symbol_info): Add extra parameter, which is passed on to
1802 search_symbols.
1803 (struct info_print_options): New type.
1804 (info_print_options_defs): New file scoped variable.
1805 (make_info_print_options_def_group): New static function.
1806 (info_print_command_completer): New static function.
1807 (info_variables_command): Update to use local functions, and pass
1808 extra parameter through to symtab_symbol_info.
1809 (info_functions_command): Likewise.
1810 (info_types_command): Pass additional argument through to
1811 symtab_symbol_info.
1812 (rbreak_command): Pass extra argument to search_symbols.
1813 (_initialize_symtab): Add extra arguments for calls to
1814 info_print_args_help, and update help text for 'info variables',
1815 'whereis', and 'info functions' commands.
1816 * symtab.h (search_symbols): Add extra argument to declaration.
1817 * NEWS: Mention new flags.
1818
9aa55206
CB
18192019-08-26 Christian Biesinger <cbiesinger@google.com>
1820
1821 * symtab.c (lookup_static_symbol): Call the new function (and move
1822 it down to be next to lookup_global_symbol).
1823 (struct global_sym_lookup_data): Add block_enum member and rename to...
1824 (struct global_or_static_sym_lookup_data): ...this.
1825 (lookup_symbol_global_iterator_cb): Pass block_index instead of
1826 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1827 (lookup_symbol_global_or_static_iterator_cb): ...this.
1828 (lookup_global_or_static_symbol): New function.
1829 (lookup_global_symbol): Call new function.
1830
5c31b358
TV
18312019-08-26 Tom de Vries <tdevries@suse.de>
1832
1833 PR c++/24852
1834 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1835 when pc_probe.prob == NULL.
1836
23c13d42
SM
18372019-08-25 Simon Marchi <simon.marchi@efficios.com>
1838
1839 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1840 variable symbol_linkage to symbol_linkage_.
1841
beadd3e8
SM
18422019-08-25 Simon Marchi <simon.marchi@efficios.com>
1843
1844 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1845 represent whether the symbol is static, dynamic, or we don't
1846 know.
1847
e3ec872f
YS
18482019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
1849
1850 * gdb/rx-tdep.c (rx_register_names): New.
1851 (rx_register_name): Delete.
1852 (rx_psw_type): Delete.
1853 (rx_fpsw_type): Delete.
1854 (rx_register_type): Delete.
1855 (rx_gdbarch_init): Convert target-descriptions.
1856 (_initialize_rx_tdep): Add initialize_tdesc_rx.
1857 * gdb/features/Makefile: Add rx.xml.
1858 * gdb/features/rx.xml: New.
1859 * gdb/features/rx.c: Generated.
1860 * gdb/NEWS: Mention target description support.
1861
d0509ba4
CB
18622019-08-22 Christian Biesinger <cbiesinger@google.com>
1863
1864 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1865 *slot_ptr.
1866
2d41fa11
SDJ
18672019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
1868
1869 * configure.ac: Don't check for 'dlfcn.h' (moved to
1870 gdbsupport/common.m4).
1871 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1872 'gdbsupport/'.
1873 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1874 * compile/compile-c-support.c: Include
1875 'gdbsupport/gdb-dlfcn.h'.
1876 * gdbsupport/common.m4: Check for 'dlfcn.h'.
1877 * gdb-dlfcn.c: Move to...
1878 * gdbsupport/gdb-dlfcn.c: ... here.
1879 * gdb-dlfcn.h: Move to...
1880 * gdbsupport/gdb-dlfcn.h: ... here.
1881
de8af808
SL
18822019-08-23 Sandra Loosemore <sandra@codesourcery.com>
1883
1884 * nios2-tdep.c (struct reg_value): Improve comments. Make
1885 the offset field signed.
1886
27204489
CB
18872019-08-22 Christian Biesinger <cbiesinger@google.com>
1888
1889 * python/lib/gdb/__init__.py (_execute_file): New function.
1890 * python/python.c (python_run_simple_file): Call gdb._execute_file
1891 on Windows.
1892
43771869
AB
18932019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
1894
1895 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1896 all uses as this was never set to anything but a zero value.
1897
26c957f1
PA
18982019-08-21 Bogdan Harjoc <harjoc@gmail.com>
1899
1900 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1901
c07aae6e
CB
19022019-08-21 Christian Biesinger <cbiesinger@google.com>
1903
1904 * tui/tui-data.h (tui_gen_win_info): Add an =default
1905 move constructor, required by some GCC versions.
1906
3960cb7a
JF
19072019-08-21 Jinke Fan <fanjinke51@yeah.net>
1908
1909 * go32-nat.c (go32_sysinfo): Add hygon_p.
1910
04c72a68
TT
19112019-08-20 Tom Tromey <tom@tromey.com>
1912
1913 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1914 line_from_reg_element_no, first_reg_element_no_inline,
1915 display_all_data, delete_data_content_windows,
1916 erase_data_content>: Now private.
1917
072272ce
TT
19182019-08-20 Tom Tromey <tom@tromey.com>
1919
1920 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1921 (tui_unhighlight_win, tui_highlight_win)
1922 (tui_win_info::make_window): Update.
1923 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1924
973961bd
TT
19252019-08-20 Tom Tromey <tom@tromey.com>
1926
1927 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1928 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1929 (MAX_PID_WIDTH): Move to tui-stack.c.
1930 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1931 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1932 (MAX_PID_WIDTH): Move from tui-data.h.
1933
ab0e1f1a
TT
19342019-08-20 Tom Tromey <tom@tromey.com>
1935
1936 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1937 * tui/tui-wingeneral.c (box_win): Change type of win_info.
1938 (box_win): Update.
1939 (tui_gen_win_info::make_window): Rename from tui_make_window.
1940 (tui_win_info::make_window): New method.
1941 (tui_gen_win_info::make_visible): Update.
1942 * tui/tui-source.c (tui_source_window::set_contents): Update.
1943 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1944 (tui_data_window::display_registers_from): Update.
1945 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1946 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1947 Declare.
1948 <can_box>: Remove.
1949 <title>: Remove.
1950 (struct tui_win_info) <make_window>: Declare.
1951 <can_box>: Now virtual.
1952 <title>: New member.
1953 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1954 * tui/tui-command.c (tui_cmd_window::resize): Update.
1955
100c2bf3
TT
19562019-08-20 Tom Tromey <tom@tromey.com>
1957
1958 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1959 * tui/tui-regs.c (tui_data_window::show_registers): Update.
1960 (tui_data_window::check_register_values): Update.
1961
fa4dc567
TT
19622019-08-20 Tom Tromey <tom@tromey.com>
1963
1964 * tui/tui-regs.h (struct tui_data_window): Use
1965 DISABLE_COPY_AND_ASSIGN.
1966 <regs_content>: Change type, removing unique_ptr.
1967 <tui_data_window>: Add move constructor.
1968 * tui/tui-regs.c (tui_data_window::show_registers)
1969 (tui_data_window::show_register_group)
1970 (tui_data_window::display_registers_from)
1971 (tui_data_window::display_registers_from)
1972 (tui_data_window::first_data_item_displayed)
1973 (tui_data_window::delete_data_content_windows)
1974 (tui_data_window::rerender, tui_data_window::refresh_window)
1975 (tui_data_window::check_register_values): Update.
1976
ca02d7c8
TT
19772019-08-20 Tom Tromey <tom@tromey.com>
1978
1979 * tui/tui-regs.h (struct tui_data_window) <show_registers,
1980 show_register_group>: Declare.
1981 (tui_show_register_group): Don't declare.
1982 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1983 tui_show_registers.
1984 (tui_data_window::show_register_group): Rename from
1985 tui_show_register_group.
1986 (tui_data_window::check_register_values, tui_reg_command):
1987 Update.
1988 * tui/tui-layout.c (tui_set_layout): Update.
1989
63356bfd
TT
19902019-08-20 Tom Tromey <tom@tromey.com>
1991
1992 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1993 Declare.
1994 (tui_check_register_values): Don't declare.
1995 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1996 from tui_check_register_values.
1997 * tui/tui-hooks.c (tui_register_changed): Update.
1998
42cc14a7
TT
19992019-08-20 Tom Tromey <tom@tromey.com>
2000
2001 * tui/tui-regs.c (tui_reg_layout): Move later.
2002 (tui_show_registers): Don't enable TUI mode or change layout.
2003
b9ad3686
TT
20042019-08-20 Tom Tromey <tom@tromey.com>
2005
2006 * tui/tui-regs.h (struct tui_data_item_window)
2007 <~tui_data_item_window>: Remove.
2008 <content>: Now a unique_xmalloc_ptr.
2009 * tui/tui-regs.c (tui_register_format): Return a
2010 unique_xmalloc_ptr.
2011 (tui_get_register): Update.
2012 (~tui_data_item_window): Remove.
2013 (tui_data_window::display_registers_from, tui_display_register):
2014 Update.
2015 * tui/tui-io.h (tui_expand_tabs): Update.
2016 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2017 Remove "col" parameter.
2018
8e114aab
TT
20192019-08-20 Tom Tromey <tom@tromey.com>
2020
2021 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2022 field.
2023 * tui/tui-regs.c (~tui_data_item_window): Update.
2024
1a4f81dd
TT
20252019-08-20 Tom Tromey <tom@tromey.com>
2026
2027 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2028 earlier.
2029
0f8d8876
TT
20302019-08-20 Tom Tromey <tom@tromey.com>
2031
2032 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2033
605dc2c2
TT
20342019-08-20 Tom Tromey <tom@tromey.com>
2035
2036 * tui/tui-source.h (struct tui_source_window): Update.
2037 * tui/tui-regs.c (tui_show_registers): Update.
2038 * tui/tui-disasm.h (struct tui_disasm_window): Update.
2039 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2040 (NO_REGS_STRING): Remove defines.
2041
aedbe3bb
CM
20422019-08-20 Conrad Meyer <cem@FreeBSD.org>
2043
2044 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2045 unnecessary thread walk if remote doesn't support the packet.
2046
7ce8f214
TT
20472019-08-19 Tom Tromey <tromey@adacore.com>
2048
2049 * python/py-value.c (value_has_field): Fix indentation.
2050
f21c2bd7
TT
20512019-08-19 Tom Tromey <tromey@adacore.com>
2052
2053 * printcmd.c (do_one_display, info_display_command): Update.
2054 * block.h (contained_in): Return bool. Add allow_nested
2055 parameter.
2056 * block.c (contained_in): Return bool. Add allow_nested
2057 parameter.
2058
d806ea2d
TT
20592019-08-19 Tom Tromey <tom@tromey.com>
2060
2061 * configure: Rebuild.
2062 * configure.ac: Disallow the combination of -static-libstdc++ and
2063 source highlight.
2064 * source-cache.c (get_language_name): Handle rust.
2065 (source_cache::get_source_lines): Ignore highlighting exceptions.
2066
398fdd60
TT
20672019-08-16 Tom Tromey <tom@tromey.com>
2068
2069 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2070 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2071 (struct tui_source_window_base) <make_visible, refresh_window,
2072 resize>: Remove methods.
2073 <execution_info>: Remove field.
2074 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2075 (tui_show_source_line, tui_source_window_base)
2076 (~tui_source_window_base): Update.
2077 (tui_source_window_base::resize)
2078 (tui_source_window_base::make_visible)
2079 (tui_source_window_base::refresh_window): Remove.
2080 (tui_source_window_base::update_exec_info): Update.
2081 * tui/tui-source.c (tui_source_window::set_contents): Update.
2082 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2083
e699d331
TT
20842019-08-16 Tom Tromey <tom@tromey.com>
2085
2086 * tui/tui-hooks.c (tui_remove_hooks): Don't set
2087 deprecated_query_hook.
2088
bb01dbfc
TT
20892019-08-16 Tom Tromey <tom@tromey.com>
2090
2091 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2092 (tui_update_source_windows_with_line): Update.
2093 * tui/tui-source.h (struct tui_source_window)
2094 <show_symtab_source>: Declare.
2095 (tui_show_symtab_source): Don't declare.
2096 * tui/tui-source.c (tui_show_symtab_source): Rename from
2097 tui_show_symtab_source.
2098
81c82c4b
TT
20992019-08-16 Tom Tromey <tom@tromey.com>
2100
2101 * tui/tui-winsource.h (struct tui_source_window_base)
2102 <set_contents>: Declare.
2103 * tui/tui-winsource.c
2104 (tui_source_window_base::update_source_window_as_is): Update.
2105 * tui/tui-source.h (struct tui_source_window) <set_contents>:
2106 Declare.
2107 (tui_set_source_content): Don't declare.
2108 * tui/tui-source.c (tui_source_window::set_contents): Rename from
2109 tui_set_source_content.
2110 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2111 Declare.
2112 (tui_set_disassem_content): Don't declare.
2113 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2114 tui_set_disassem_content.
2115
2ddaf614
TT
21162019-08-16 Tom Tromey <tom@tromey.com>
2117
2118 * tui/tui-winsource.h (struct tui_source_window_base)
2119 <update_breakpoint_info>: Declare.
2120 (tui_update_breakpoint_info): Don't declare.
2121 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2122 (tui_update_all_breakpoint_info): Update.
2123 (tui_source_window_base::update_breakpoint_info): Rename from
2124 tui_update_breakpoint_info.
2125 (tui_source_window_base::update_exec_info): Update.
2126
017f9828
TT
21272019-08-16 Tom Tromey <tom@tromey.com>
2128
2129 * tui/tui-winsource.h (struct tui_source_window_base)
2130 <update_source_window>: Declare.
2131 (tui_update_source_window): Don't declare.
2132 * tui/tui-winsource.c
2133 (tui_source_window_base::update_source_window): Rename from
2134 tui_update_source_window.
2135 (tui_source_window_base::rerender): Update.
2136 * tui/tui-source.c (tui_source_window::maybe_update): Update.
2137 * tui/tui-disasm.c (tui_show_disassem)
2138 (tui_show_disassem_and_update_source)
2139 (tui_disasm_window::maybe_update): Update.
2140
ed8358e9
TT
21412019-08-16 Tom Tromey <tom@tromey.com>
2142
2143 * tui/tui-winsource.h (struct tui_source_window_base)
2144 <update_source_window_as_is>: Declare.
2145 (tui_update_source_window_as_is): Don't declare.
2146 * tui/tui-winsource.c (tui_update_source_window): Update
2147 (tui_source_window_base::update_source_window_as_is): Rename from
2148 tui_update_source_window_as_is.
2149 (tui_source_window_base::refill): Update.
2150 * tui/tui-source.c (tui_show_symtab_source): Update.
2151 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2152 Update.
2153
20149b6b
TT
21542019-08-16 Tom Tromey <tom@tromey.com>
2155
2156 * tui/tui-winsource.h (tui_update_source_window)
2157 (tui_update_source_window_as_is): Remove "noerror" parameter.
2158 * tui/tui-winsource.c (tui_update_source_window)
2159 (tui_update_source_window_as_is): Remove "noerror" parameter.
2160 (tui_update_source_windows_with_addr)
2161 (tui_update_source_windows_with_line)
2162 (tui_source_window_base::rerender)
2163 (tui_source_window_base::refill): Update.
2164 * tui/tui-source.h (tui_set_source_content)
2165 (tui_show_symtab_source): Remove "noerror" parameter.
2166 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2167 parameter.
2168 (tui_show_symtab_source): Likewise.
2169 (tui_source_window::maybe_update): Update.
2170 * tui/tui-disasm.c (tui_show_disassem)
2171 (tui_show_disassem_and_update_source)
2172 (tui_disasm_window::do_scroll_vertical)
2173 (tui_disasm_window::maybe_update): Update.
2174
2d83e710
TT
21752019-08-16 Tom Tromey <tom@tromey.com>
2176
2177 * tui/tui.c (tui_is_window_visible): Update.
2178 * tui/tui-wingeneral.c (tui_make_window)
2179 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2180 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2181 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2182 (tui_set_win_height_command, parse_scrolling_args): Update.
2183 * tui/tui-source.c (tui_source_window::style_changed): Update.
2184 * tui/tui-regs.c (tui_show_registers)
2185 (tui_data_window::first_data_item_displayed)
2186 (tui_data_window::delete_data_content_windows)
2187 (tui_check_register_values, tui_reg_command): Update.
2188 * tui/tui-disasm.c (tui_show_disassem): Update.
2189 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2190 method.
2191 <is_visible>: Remove field.
2192 * tui/tui-data.c (tui_next_win, tui_prev_win)
2193 (tui_delete_invisible_windows): Update.
2194
d4ab829a
TT
21952019-08-16 Tom Tromey <tom@tromey.com>
2196
2197 * tui/tui-winsource.h (struct tui_source_window_base)
2198 <m_has_locator>: Remove.
2199 * tui/tui-layout.c (show_source_disasm_command, show_data)
2200 (show_source_or_disasm_and_command): Update.
2201
aa7ca1bb
AH
22022019-08-16 Alan Hayward <alan.hayward@arm.com>
2203
2204 * NEWS (Other MI changes): New subsection.
2205 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2206 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2207 * arch-utils.c (default_get_pc_address_flags): New function.
2208 * arch-utils.h (default_get_pc_address_flags): New declaration.
2209 * gdbarch.sh: Add get_pc_address_flags.
2210 * gdbarch.c: Regenerate.
2211 * gdbarch.h: Likewise.
2212 * stack.c (print_pc): New function.
2213 (print_frame_info) (print_frame): Call print_pc.
2214
6eac171f
TV
22152019-08-16 Tom de Vries <tdevries@suse.de>
2216
2217 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2218 print_objfile_section_info.
2219
3df505f6
TT
22202019-08-15 Tom Tromey <tom@tromey.com>
2221
2222 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2223 calling update_cmdwin_start_line.
2224 * tui/tui-winsource.h (struct tui_source_window_base)
2225 <do_make_visible_with_new_height, set_new_height>: Don't declare.
2226 <rerender>: Declare.
2227 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2228 Call rerender.
2229 (tui_source_window_base::set_new_height): Remove.
2230 (tui_source_window_base::rerender): Rename from
2231 do_make_visible_with_new_height.
2232 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2233 resize method.
2234 (tui_win_info::make_invisible_and_set_new_height)
2235 (tui_win_info::make_visible_with_new_height): Remove.
2236 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2237 Declare.
2238 * tui/tui-stack.c (tui_locator_window::rerender): New method.
2239 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2240 do_make_visible_with_new_height>: Don't declare.
2241 <rerender>: Declare.
2242 * tui/tui-regs.c (tui_data_window::rerender): Rename from
2243 set_new_height.
2244 (tui_data_window::do_make_visible_with_new_height): Remove.
2245 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2246 call tui_show_locator_content.
2247 (tui_gen_win_info::resize): Call rerender.
2248 (show_source_or_disasm_and_command): Don't call
2249 tui_show_locator_content.
2250 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2251 method.
2252 (struct tui_win_info) <rerender>: Declare.
2253 <set_new_height, make_invisible_and_set_new_height,
2254 make_visible_with_new_height>: Don't declare.
2255 * tui/tui-data.c (tui_win_list::rerender): New method.
2256 * tui/tui-command.h (struct tui_cmd_window)
2257 <do_make_visible_with_new_height>: Don't declare.
2258 * tui/tui-command.c
2259 (tui_cmd_window::do_make_visible_with_new_height): Remove.
2260
272560b5
TT
22612019-08-15 Tom Tromey <tromey@adacore.com>
2262
2263 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2264 * ada-lang.c (ada_enum_name): Likewise.
2265
08235187
CB
22662019-08-15 Christian Biesinger <cbiesinger@google.com>
2267
2268 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2269 leading underscore.
2270 (GdbOutputErrorFile): Likewise.
2271 (global scope): Adjust constructor calls to GdbOutput{,Error}File
2272 accordingly.
2273 (execute_unwinders): Rename to have a leading underscore.
2274 (auto_load_packages): Likewise.
2275 (global scope): Adjust call to auto_load_packages accordingly.
2276 (GdbSetPythonDirectory): Likewise.
2277 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2278 instead of execute_unwinders.
2279
db502012
TT
22802019-08-15 Tom Tromey <tom@tromey.com>
2281
2282 * tui/tui-layout.c (show_layout, show_source_disasm_command)
2283 (show_data): Don't change window visibility.
2284 (tui_gen_win_info::resize): Remove special case for command
2285 window. Use wresize, when available.
2286 (show_source_or_disasm_and_command): Don't change window
2287 visibility.
2288 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2289 <make_visible>: New method.
2290 * tui/tui-command.c (tui_cmd_window::resize): New method.
2291
3891b65e
TT
22922019-08-15 Tom Tromey <tom@tromey.com>
2293
2294 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2295 (struct tui_source_windows): New.
2296 * tui/tui-winsource.c (tui_display_main): Update.
2297 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2298 (new_height_ok, parse_scrolling_args): Update.
2299 * tui/tui-layout.c (show_layout, show_data): Update.
2300 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2301 (tui_add_to_source_windows): Don't declare.
2302 * tui/tui-data.c (source_windows, tui_source_windows)
2303 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2304
ee556432
TT
23052019-08-15 Tom Tromey <tom@tromey.com>
2306
2307 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2308 Rename from reset.
2309 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2310 * tui/tui-layout.c (show_source_disasm_command, show_data):
2311 Update.
2312 (tui_gen_win_info::resize): Rename.
2313 (show_source_or_disasm_and_command): Update.
2314 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2315 reset.
2316
46f438e3
TT
23172019-08-15 Tom Tromey <tom@tromey.com>
2318
2319 * tui/tui-stack.c (tui_initialize_static_data): Remove.
2320 * tui/tui-interp.c (tui_interp::init): Don't call
2321 tui_initialize_static_data.
2322 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2323
f4ce562c
TT
23242019-08-15 Tom Tromey <tom@tromey.com>
2325
2326 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2327 examine tui_win_list.
2328
c398c3d0
TT
23292019-08-15 Tom Tromey <tom@tromey.com>
2330
2331 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2332 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2333 tui_clear_source_content.
2334 (tui_clear_source_content): Remove.
2335 (tui_source_window_base::do_erase_source_content): Hoist call to
2336 content.clear().
2337 * tui/tui-stack.c (tui_show_frame_info): Don't call
2338 tui_clear_source_content.
2339
e25d2004
TT
23402019-08-15 Tom Tromey <tom@tromey.com>
2341
2342 * tui/tui-winsource.h (struct tui_source_window_base)
2343 <do_erase_source_content>: New method.
2344 <erase_source_content>: New method.
2345 (tui_erase_source_content): Don't declare.
2346 * tui/tui-winsource.c (tui_clear_source_content): Update.
2347 (tui_source_window_base::do_erase_source_content): Rename from
2348 tui_erase_source_content.
2349 (tui_source_window_base::show_source_content): Update.
2350 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2351 * tui/tui-source.h (struct tui_source_window)
2352 <erase_source_content>: New method.
2353 * tui/tui-disasm.h (struct tui_disasm_window)
2354 <erase_source_content>: New method.
2355
002f15c2
TT
23562019-08-15 Tom Tromey <tom@tromey.com>
2357
2358 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2359 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2360 constructor.
2361 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2362 * tui/tui-source.c (tui_set_source_content): Update.
2363 * tui/tui-disasm.c (tui_set_disassem_content): Update.
2364
c9033fe8
TT
23652019-08-15 Tom Tromey <tom@tromey.com>
2366
2367 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2368 * tui/tui-winsource.c (tui_line_is_displayed): Move to
2369 tui-source.c.
2370 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2371 Declare.
2372 * tui/tui-source.c (tui_source_window::line_is_displayed): New
2373 method.
2374 (tui_source_window::maybe_update): Update.
2375
088f37dd
TT
23762019-08-15 Tom Tromey <tom@tromey.com>
2377
2378 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2379 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2380 tui-disasm.c.
2381 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2382 Declare.
2383 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2384 method.
2385 (tui_disasm_window::maybe_update): Update.
2386
a54700c6
TT
23872019-08-15 Tom Tromey <tom@tromey.com>
2388
2389 * tui/tui-winsource.h (struct tui_source_window_base)
2390 <maybe_update>: Declare.
2391 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2392 method.
2393 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2394 Declare.
2395 * tui/tui-source.c (tui_source_window::maybe_update): New method.
2396 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2397 Declare.
2398 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2399
e2a678a5
TT
24002019-08-15 Tom Tromey <tom@tromey.com>
2401
2402 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2403
f2dda477
TT
24042019-08-15 Tom Tromey <tom@tromey.com>
2405
2406 * tui/tui-wingeneral.c: Include tui-stack.h.
2407 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2408 (struct tui_locator_window): Move from tui-data.h.
2409 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2410 (tui_initialize_static_data): Move from tui-data.c.
2411 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2412 (struct tui_locator_window): Move to tui-stack.c.
2413 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2414 (tui_initialize_static_data): Move to tui-stack.c.
2415
ed4a1084
TT
24162019-08-15 Tom Tromey <tom@tromey.com>
2417
2418 * tui/tui-layout.c (show_source_disasm_command)
2419 (show_source_or_disasm_and_command): Use make_visible method, not
2420 tui_make_window.
2421 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2422 Remove.
2423
65962b20
TT
24242019-08-15 Tom Tromey <tom@tromey.com>
2425
2426 * tui/tui-wingeneral.h (tui_make_window): Update.
2427 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2428 parameter.
2429 (tui_gen_win_info::make_visible): Update.
2430 * tui/tui-regs.c (tui_data_window::display_registers_from):
2431 Update.
2432 * tui/tui-layout.c (show_source_disasm_command)
2433 (show_source_or_disasm_and_command): Update.
2434 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2435 (enum tui_box): Remove.
2436 (struct tui_win_info) <can_box>: New method.
2437 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2438 method.
2439
2208ee91
TV
24402019-08-15 Tom de Vries <tdevries@suse.de>
2441
2442 * linux-nat-trad.c: Include gdbarch.h.
2443
75faf5c4
AH
24442019-08-14 Alan Hayward <alan.hayward@arm.com>
2445
2446 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2447 register sizes.
2448
b1c896b3
TT
24492019-08-14 Tom Tromey <tromey@adacore.com>
2450
2451 * darwin-nat.c: Include gdbarch.h.
2452 * darwin-nat-info.c: Include gdbarch.h.
2453
6405cd73
TT
24542019-08-13 Tom Tromey <tom@tromey.com>
2455
2456 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2457 Remove.
2458 * tui/tui-data.c (tui_initialize_static_data): Update.
2459
5216580d
TT
24602019-08-13 Tom Tromey <tom@tromey.com>
2461
2462 * tui/tui-winsource.h (struct tui_exec_info_window)
2463 <~tui_exec_info_window, maybe_allocate_content, get_content,
2464 m_content>: Remove.
2465 (struct tui_source_window_base) <set_exec_info_content,
2466 show_exec_info_content>: Don't declare.
2467 * tui/tui-winsource.c
2468 (tui_exec_info_window::maybe_allocate_content): Remove.
2469 (tui_source_window_base::update_exec_info): Rename from
2470 set_exec_info_content.
2471 (tui_source_window_base::show_exec_info_content)
2472 (tui_source_window_base::update_exec_info): Remove.
2473
93858ad3
TT
24742019-08-13 Tom Tromey <tom@tromey.com>
2475
2476 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2477 declare.
2478 * tui/tui-winsource.c (tui_update_source_window_as_is)
2479 (tui_update_source_windows_with_addr, tui_erase_source_content):
2480 Update.
2481 (tui_clear_exec_info_content): Remove.
2482
e321e7ce
TT
24832019-08-13 Tom Tromey <tom@tromey.com>
2484
2485 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2486 declare.
2487 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2488 call tui_erase_exec_info_content.
2489 (tui_clear_exec_info_content): Rename from
2490 tui_erase_exec_info_content.
2491 (tui_clear_exec_info_content): Delete.
2492
8270ac62
TT
24932019-08-13 Tom Tromey <tom@tromey.com>
2494
2495 * tui/tui-winsource.h (struct tui_source_window_base)
2496 <show_exec_info_content>: Declare.
2497 (tui_show_exec_info_content): Don't declare.
2498 * tui/tui-winsource.c
2499 (tui_source_window_base::show_exec_info_content): Rename from
2500 tui_show_exec_info_content.
2501 (tui_source_window_base::update_exec_info): Update.
2502
7b56485d
TT
25032019-08-13 Tom Tromey <tom@tromey.com>
2504
2505 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2506 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2507 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2508 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2509 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2510 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2511 ... here.
2512
7ba913dc
TT
25132019-08-13 Tom Tromey <tom@tromey.com>
2514
2515 * tui/tui-winsource.h (struct tui_source_window_base)
2516 <update_exec_info>: Declare.
2517 (tui_update_exec_info): Don't declare.
2518 * tui/tui-winsource.c (tui_update_source_window_as_is)
2519 (tui_source_window_base::refresh_all)
2520 (tui_update_all_breakpoint_info): Update.
2521 (tui_source_window_base::update_exec_info): Rename from
2522 tui_update_exec_info.
2523 * tui/tui-stack.c (tui_show_frame_info): Update.
2524
37a4a131
TT
25252019-08-13 Tom Tromey <tom@tromey.com>
2526
2527 * tui/tui-winsource.h (struct tui_source_window_base)
2528 <set_exec_info_content>: Declare.
2529 (tui_set_exec_info_content): Don't declare.
2530 * tui/tui-winsource.c
2531 (tui_source_window_base::set_exec_info_content): Rename from
2532 tui_set_exec_info_content.
2533 (tui_update_exec_info): Update.
2534
0bd27e07
TT
25352019-08-13 Tom Tromey <tom@tromey.com>
2536
2537 * tui/tui-winsource.h (struct tui_source_window_base)
2538 <show_source_content>: Declare.
2539 (tui_show_source_content): Don't declare.
2540 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2541 (tui_source_window_base::show_source_content): Rename from
2542 tui_show_source_content.
2543 (tui_source_window_base::refresh_all): Update.
2544 * tui/tui-layout.c (show_source_disasm_command)
2545 (show_source_or_disasm_and_command): Update.
2546
b4ef5aeb
TT
25472019-08-13 Tom Tromey <tom@tromey.com>
2548
2549 * tui/tui-winsource.c (tui_erase_source_content)
2550 (tui_show_source_content, tui_source_window_base::refresh_all):
2551 Update.
2552 * tui/tui-wingeneral.h
2553 (tui_check_and_display_highlight_if_needed): Don't declare.
2554 * tui/tui-wingeneral.c
2555 (tui_win_info::check_and_display_highlight_if_needed): Rename from
2556 check_and_display_highlight_if_needed.
2557 * tui/tui-win.c (tui_rehighlight_all)
2558 (tui_win_info::make_visible_with_new_height): Update.
2559 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2560 (tui_data_window::erase_data_content)
2561 (tui_data_window::display_all_data): Update.
2562 * tui/tui-data.h (struct tui_win_info)
2563 <check_and_display_highlight_if_needed>: Declare.
2564
fede5273
TT
25652019-08-13 Tom Tromey <tom@tromey.com>
2566
2567 * tui/tui-win.c (tui_resize_all): Call
2568 tui_delete_invisible_windows.
2569 * tui/tui-layout.c (show_layout): Call
2570 tui_delete_invisible_windows.
2571 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2572 * tui/tui-data.c (tui_delete_invisible_windows): New function.
2573
22c3f490
TT
25742019-08-13 Tom Tromey <tom@tromey.com>
2575
2576 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
2577 tui_add_win_to_layout.
2578
16cb7910
TT
25792019-08-13 Tom Tromey <tom@tromey.com>
2580
2581 * tui/tui-layout.h (tui_default_win_height): Don't declare.
2582 * tui/tui-layout.c (tui_default_win_height): Now static.
2583
cc0c3ffb
TT
25842019-08-13 Tom Tromey <tom@tromey.com>
2585
2586 * tui/tui-layout.c (show_layout): Unify all layout cases into a
2587 single switch.
2588 (show_source_disasm_command, show_source_or_disasm_and_command):
2589 Don't check current layout.
2590
3f3ffe54
TT
25912019-08-13 Tom Tromey <tom@tromey.com>
2592
2593 * tui/tui-wingeneral.c (make_all_visible): Remove.
2594 (tui_make_all_invisible): Simplify.
2595 * tui/tui-layout.c (tui_make_all_invisible): Move from
2596 tui-wingeneral.c; simplify.
2597 (show_layout): Hoist call to tui_make_all_invisible.
2598 (show_data): Don't call tui_make_all_invisible.
2599
69258091
TT
26002019-08-13 Tom Tromey <tom@tromey.com>
2601
2602 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2603 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2604
62cf57fe
TT
26052019-08-13 Tom Tromey <tom@tromey.com>
2606
2607 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2608 tui-data.c.
2609 (show_source_disasm_command, show_data)
2610 (show_source_or_disasm_and_command): Don't use
2611 tui_set_current_layout_to.
2612 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2613 * tui/tui-data.c (current_layout, tui_current_layout): Move to
2614 tui-layout.c.
2615 (tui_set_current_layout_to): Remove.
2616
2afade5d
TT
26172019-08-13 Tom Tromey <tom@tromey.com>
2618
2619 * tui/tui-layout.c (tui_set_layout): Update.
2620 * tui/tui-data.h (struct tui_layout_def): Remove.
2621 (tui_layout_def): Don't declare.
2622 * tui/tui-data.c (layout_def): Remove.
2623 (tui_layout_def): Remove.
2624
a3504e96
TT
26252019-08-13 Tom Tromey <tom@tromey.com>
2626
2627 * tui/tui-winsource.h (struct tui_source_window_base)
2628 <clear_detail>: No longer "override".
2629 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2630 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2631 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2632 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2633 Remove.
2634 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2635
29c92911
TT
26362019-08-13 Tom Tromey <tromey@adacore.com>
2637
2638 * tracepoint.c: Don't include readline.h or history.h.
2639
86c6b807
TT
26402019-08-12 Tom Tromey <tom@tromey.com>
2641
2642 * configure: Rebuild.
2643 * configure.ac: Check for readline 7.
2644 * NEWS: Mention readline 7 requirement.
2645 * README: Update.
2646
5db2718c
TT
26472019-08-12 Tom Tromey <tom@tromey.com>
2648
2649 * mingw-hdep.c (gdb_select): Remove readline hack.
2650
dac36daf
PFC
26512019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
2652
2653 * blockframe.c (find_pc_partial_function): Set *block to nullptr
2654 when the function fails.
2655
1022c627
AA
26562019-08-09 Andreas Arnez <arnez@linux.ibm.com>
2657
2658 * s390-tdep.c (s390_type_align): New function.
2659 (s390_gdbarch_init): Set it as type_align gdbarch method.
2660
eba4caf2
TV
26612019-08-09 Tom de Vries <tdevries@suse.de>
2662
2663 PR gdb/24591
2664 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2665 pc_low with relocation offset.
2666
123cd851
TT
26672019-08-07 Tom Tromey <tromey@adacore.com>
2668
2669 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2670 (print_frame_args): Update.
2671 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2672 Update.
2673 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2674 * frame.h (struct frame_arg): Add initializers.
2675 <error>: Now a unique_xmalloc_ptr.
2676
3d31bc39
AH
26772019-08-07 Alan Hayward <alan.hayward@arm.com>
2678
2679 * NEWS: Expand the Pointer Authentication entry.
2680 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2681 (aarch64_frame_unmask_lr): ... to this.
2682 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2683 Call aarch64_frame_unmask_lr.
2684 * frame.c (struct frame_info): Add "masked" variable.
2685 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2686 (fprint_frame): Check for masked pc.
2687 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2688 declarations.
2689 * python/py-framefilter.c (py_print_frame): Check for masked pc.
2690 * stack.c (print_frame): Check for masked pc.
2691
0cf9feb9
TT
26922019-08-06 Tom Tromey <tom@tromey.com>
2693
2694 * stabsread.c (patch_block_stabs, read_one_struct_field)
2695 (read_enum_type): Use obstack_strndup.
2696 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2697 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2698 * dwarf2read.c (guess_full_die_structure_name)
2699 (anonymous_struct_prefix): Use obstack_strndup.
2700 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2701 * c-exp.y (yylex): Use obstack_strndup.
2702 * ada-exp.y (write_object_renaming, write_ambiguous_var)
2703 (write_var_or_type): Use obstack_strndup.
2704
efba19b0
TT
27052019-08-06 Tom Tromey <tom@tromey.com>
2706
2707 * symfile.c (reread_symbols): Use obstack_strdup.
2708 * stabsread.c (read_type): Use obstack_strdup.
2709 * gdb_obstack.h (obstack_strdup): New overload.
2710 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2711 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2712 (dwarf2_canonicalize_name): Use obstack_strdup.
2713 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2714 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2715 Use obstack_strdup.
2716
f25102f7
TT
27172019-08-06 Tom Tromey <tom@tromey.com>
2718
2719 * gdb_obstack.h (obstack_strdup): Define.
2720 * gdb_obstack.c (obstack_strdup): Don't define.
2721
021887d8
TT
27222019-08-06 Tom Tromey <tom@tromey.com>
2723
2724 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2725 obstack_strdup.
2726 * typeprint.c (typedef_hash_table::find_global_typedef): Use
2727 obstack_strdup.
2728 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2729 * stabsread.c (common_block_start): Use obstack_strdup.
2730 * objfiles.c (set_objfile_main_name, objfile): Use
2731 obstack_strdup.
2732 * namespace.c (add_using_directive): Use obstack_strdup.
2733 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2734 * jit.c (finalize_symtab): Use obstack_strdup.
2735 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2736 (guess_partial_die_structure_name, partial_die_info::fixup)
2737 (dwarf2_name): Use obstack_strdup.
2738 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2739 obstack_strdup.
2740 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2741 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2742 obstack_strdup.
2743 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2744
d2834edc
PW
27452019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2746
2747 * unittests/help-doc-selftests.c: New file.
2748 * Makefile.in: Add the new file.
2749
590042fc
PW
27502019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2751
2752 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2753 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
2754 the full first line, except when FOR_VALUE_PREFIX. In this case,
2755 the trailing '.' is not output, and the first character is uppercased.
2756 (print_help_for_command): Update call to print_doc_line.
2757 (print_doc_of_command): Likewise.
2758 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2759 * cli/cli-option.c (append_indented_doc): Do not append newline.
2760 (build_help_option): Append newline after first appended_indented_doc
2761 only if a second call is done.
2762 (build_help): Append 2 new lines before each option, except the first
2763 one.
2764 * compile/compile.c (_initialize_compile): Add new lines after
2765 %OPTIONS%, when not at the end of the help.
2766 Change help doc or code
2767 producing the help doc to respect the invariants.
2768 * maint-test-options.c (_initialize_maint_test_options): Likewise.
2769 Also removed the new line after 'Options:', as all other commands
2770 do not put an empty line between 'Options:' and the first option.
2771 * printcmd.c (_initialize_printcmd): Likewise.
2772 * stack.c (_initialize_stack): Likewise.
2773 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2774 incorrectly telling COMMAND is optional.
2775 * ada-lang.c (_initialize_ada_language): Change help doc or code
2776 producing the help doc to respect the invariants.
2777 * ada-tasks.c (_initialize_ada_tasks): Likewise.
2778 * breakpoint.c (_initialize_breakpoint): Likewise.
2779 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2780 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2781 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2782 * cli/cli-style.c (cli_style_option::add_setshow_commands,
2783 _initialize_cli_style): Likewise.
2784 * corelow.c (core_target_info): Likewise.
2785 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2786 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2787 * filesystem.c (_initialize_filesystem): Likewise.
2788 * frame.c (_initialize_frame): Likewise.
2789 * gnu-nat.c (add_task_commands): Likewise.
2790 * infcall.c (_initialize_infcall): Likewise.
2791 * infcmd.c (_initialize_infcmd): Likewise.
2792 * interps.c (_initialize_interpreter): Likewise.
2793 * language.c (_initialize_language): Likewise.
2794 * linux-fork.c (_initialize_linux_fork): Likewise.
2795 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2796 * maint.c (_initialize_maint_cmds): Likewise.
2797 * memattr.c (_initialize_mem): Likewise.
2798 * printcmd.c (_initialize_printcmd): Likewise.
2799 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2800 _RegEx): Likewise.
2801 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2802 * record-btrace.c (_initialize_record_btrace): Likewise.
2803 * record-full.c (_initialize_record_full): Likewise.
2804 * record.c (_initialize_record): Likewise.
2805 * regcache-dump.c (_initialize_regcache_dump): Likewise.
2806 * regcache.c (_initialize_regcache): Likewise.
2807 * remote.c (add_packet_config_cmd, init_remote_threadtests,
2808 _initialize_remote): Likewise.
2809 * ser-tcp.c (_initialize_ser_tcp): Likewise.
2810 * serial.c (_initialize_serial): Likewise.
2811 * skip.c (_initialize_step_skip): Likewise.
2812 * source.c (_initialize_source): Likewise.
2813 * stack.c (_initialize_stack): Likewise.
2814 * symfile.c (_initialize_symfile): Likewise.
2815 * symtab.c (_initialize_symtab): Likewise.
2816 * target-descriptions.c (_initialize_target_descriptions): Likewise.
2817 * top.c (init_main): Likewise.
2818 * tracefile-tfile.c (tfile_target_info): Likewise.
2819 * tracepoint.c (_initialize_tracepoint): Likewise.
2820 * tui/tui-win.c (_initialize_tui_win): Likewise.
2821 * utils.c (add_internal_problem_command): Likewise.
2822 * valprint.c (value_print_option_defs): Likewise.
2823
404f2902
FCE
28242019-08-06 Frank Ch. Eigler <fche@redhat.com>
2825
2826 PR build/24886
2827 * configure.ac: Drop enable-libmcheck support.
2828 * configure, config.in: Rebuild.
2829 * libmcheck.m4: Remove.
2830 * acinclude.m4: Don't include it.
2831 * Makefile.in: Don't distribute it.
2832 * top.c (print_gdb_configuration): Don't mention it.
2833
046bebe1
TT
28342019-08-06 Tom Tromey <tom@tromey.com>
2835
2836 * utils.c (set_output_style): Sometimes pass stream to
2837 emit_style_escape.
2838 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2839 * record-btrace.c (btrace_insn_history): Update.
2840 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2841 method.
2842 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2843 Update initializers.
2844 <m_uiout>: New field.
2845 <m_di>: Move lower.
2846 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2847 Remove "uiout" parameter.
2848 (dump_insns): Update.
2849 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2850 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2851
ddbcedf5
CB
28522019-08-06 Christian Biesinger <cbiesinger@google.com>
2853
2854 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2855 (error_in_psymtab_expansion): Likewise.
2856 (lookup_symbol_via_quick_fns): Likewise.
2857 (basic_lookup_transparent_type_quick): Likewise.
2858 (basic_lookup_transparent_type_1): Likewise.
2859
b08b16c8
TT
28602019-08-06 Tom Tromey <tromey@adacore.com>
2861
2862 * source.c (last_source_error): Now bool.
2863 (print_source_lines_base): Make "noprint" bool. Only open
2864 source file when last_source_visited changes.
2865
cb44333d
TT
28662019-08-06 Tom Tromey <tromey@adacore.com>
2867
2868 * annotate.c (annotate_source_line): Use g_source_cache.
2869 * source-cache.c (source_cache::get_plain_source_lines): Change
2870 parameters. Populate m_offset_cache.
2871 (source_cache::ensure): New method.
2872 (source_cache::get_line_charpos): New method.
2873 (extract_lines): Move lower. Change parameters.
2874 (source_cache::get_source_lines): Move lower.
2875 * source-cache.h (class source_cache): Update comment.
2876 <get_line_charpos>: New method.
2877 <get_source_lines>: Update comment.
2878 <clear>: Clear m_offset_cache.
2879 <get_plain_source_lines>: Change parameters.
2880 <ensure>: New method
2881 <m_offset_cache>: New member.
2882 * source.c (forget_cached_source_info_for_objfile): Update.
2883 (info_source_command): Use g_source_cache.
2884 (find_source_lines, open_source_file_with_line_charpos): Remove.
2885 (print_source_lines_base, search_command_helper): Use g_source_cache.
2886 * source.h (open_source_file_with_line_charpos): Don't declare.
2887 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2888 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2889 Use g_source_cache.
2890
872dceaa
TT
28912019-08-06 Tom Tromey <tromey@adacore.com>
2892
2893 * source-cache.c (source_cache::get_plain_source_lines):
2894 Remove "first_line" and "last_line" parameters.
2895 (source_cache::get_source_lines): Cache plain text.
2896 * source-cache.h (class source_cache)
2897 <get_plain_source_lines>: Update.
2898
269249d9
TT
28992019-08-06 Tom Tromey <tromey@adacore.com>
2900
2901 * source-cache.c (extract_lines): No longer a method.
2902 Changed type of parameter. Include final newline.
2903 (selftests::extract_lines_test): New function.
2904 (_initialize_source_cache): Likewise.
2905 * source-cache.h (class source_cache)
2906 <extract_lines>: Don't declare.
2907
c0e8dcd8
TT
29082019-08-06 Tom Tromey <tromey@adacore.com>
2909
2910 * breakpoint.c (init_breakpoint_sal): Update.
2911 (breakpoint): Update.
2912 * breakpoint.h (struct breakpoint) <filter>: Now a
2913 unique_xmalloc_ptr.
2914
0b27c27d
CB
29152019-08-05 Christian Biesinger <cbiesinger@google.com>
2916
2917 * NEWS: Mention dictionary access on blocks.
2918 * python/py-block.c (blpy_getitem): New function.
2919 (block_object_as_mapping): New struct.
2920 (block_object_type): Use new struct for tp_as_mapping field.
2921
4ee94178
CB
29222019-08-05 Christian Biesinger <cbiesinger@google.com>
2923
2924 * objfiles.h (objfile): Add a comment describing partial symbols.
2925
8abfcabc
TT
29262019-08-05 Tom Tromey <tromey@adacore.com>
2927
2928 * compile/compile.c (_initialize_compile): Use _(), not N_().
2929 * thread.c (_initialize_thread): Use _(), not N_().
2930 * stack.c (_initialize_stack): Use _(), not N_().
2931 * printcmd.c (_initialize_printcmd): Use _(), not N_().
2932
2b79f376
SM
29332019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
2934
2935 * dwarf2read.c (struct dw2_symtab_iterator):
2936 <want_specific_block>: Remove.
2937 <block_index>: Change type to gdb::optional.
2938 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2939 change type of BLOCK_INDEX parameter to gdb::optional.
2940 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2941 (dw2_lookup_symbol): Don't pass argument for
2942 WANT_SPECIFIC_BLOCK.
2943 (dw2_expand_symtabs_for_function): Don't pass argument for
2944 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2945 (class dw2_debug_names_iterator)
2946 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2947 parameter, change BLOCK_INDEX type to gdb::optional.
2948 <m_want_specific_block>: Remove.
2949 <m_block_index>: Change type to gdb::optional.
2950 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2951 gdb::optional. Re-write in function of gdb::optional.
2952 (dw2_debug_names_lookup_symbol): Don't pass argument for
2953 WANT_SPECIFIC_BLOCK.
2954 (dw2_debug_names_expand_symtabs_for_function): Don't pass
2955 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2956 BLOCK_INDEX.
2957
ae60f04e
PW
29582019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2959
2960 * NEWS: Mention changes to "info sources" command.
2961
28cd9371
PW
29622019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2963
2964 * symtab.c (filename_partial_match_opts): New struct type.
2965 (struct output_source_filename_data): New members
2966 regexp, c_regexp, partial_match.
2967 (output_source_filename): Use new members to decide to print file.
2968 (info_sources_option_defs): New variable.
2969 (make_info_sources_options_def_group, print_info_sources_header,
2970 info_sources_command_completer):
2971 New functions.
2972 (info_sources_command): Read new optional arguments.
2973 (_initialize_symtab): Update info sources help.
2974
ca683e3a
AO
29752019-08-02 Alexandre Oliva <oliva@adacore.com>
2976
2977 * ada-lang.c (exception_support_info_v0): Renamed from...
2978 (default_exception_support_info): ... this. Create new
2979 definition for v1.
2980 (ada_has_this_exception_support): Look up catch_handlers_sym.
2981 (ada_exception_support_info_sniffer): Try v0 after default.
2982
f1264162
TT
29832019-08-01 Tom Tromey <tromey@adacore.com>
2984
2985 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2986 gdbarch.h.
2987
0a7b2485
CB
29882019-08-01 Christian Biesinger <cbiesinger@google.com>
2989
2990 * s12z-tdep.c: Fix include path for s12z-opc.h.
2991
c6bdbeb7
AH
29922019-08-01 Alan Hayward <alan.hayward@arm.com>
2993
2994 * NEWS: Require GNU make 3.82.
2995
a2bd7b82
TT
29962019-07-16 Tom Tromey <tom@tromey.com>
2997
2998 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2999 declare.
3000
aa3b6533
TT
30012019-07-30 Tom Tromey <tromey@adacore.com>
3002
3003 * block.c (contained_in): Remove BLOCK_FUNCTION check.
3004
a1530dc7
KB
30052019-07-30 Kevin Buettner <kevinb@redhat.com>
3006
3007 * printcmd.c (print_address_symbolic): Print negative offsets.
3008 (build_address_symbolic): Force signed arithmetic when computing
3009 offset.
3010
2906593f
CB
30112019-07-30 Christian Biesinger <cbiesinger@google.com>
3012
3013 PR/24474: Add a function to lookup static variables.
3014 * NEWS: Mention this new function.
3015 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3016 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3017 * python/python.c (python_GdbMethods): Add new function.
3018
c620ed88
CB
30192019-07-29 Christian Biesinger <cbiesinger@google.com>
3020
3021 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3022 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3023 (objfpy_lookup_static_symbol): New function.
3024 (objfile_object_methods): Add new functions.
3025
bc4268a5
PW
30262019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3027
3028 * NEWS: Mention 'set|show print frame-info'. Mention new
3029 'presence' value for 'frame-arguments'. Mention new '-frame-info'
3030 backtrace argument. Mention that python frame filtering code
3031 is now consistent with what 'backtrace' command prints.
3032
4b5e8d19
PW
30332019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3034
3035 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3036 comments.
3037 (print_frame_info_auto, print_frame_info_source_line,
3038 print_frame_info_location, print_frame_info_source_and_location,
3039 print_frame_info_location_and_address, print_frame_info_short_location):
3040 New declarations.
3041 (struct frame_print_options): New member print_frame_info.
3042 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3043 * stack.h (get_user_print_what_frame_info): New declaration.
3044 (frame_show_address): New declaration.
3045 * stack.c (print_frame_arguments_choices): New value 'presence'.
3046 (print_frame_info_auto, print_frame_info_source_line,
3047 print_frame_info_location, print_frame_info_source_and_location,
3048 print_frame_info_location_and_address, print_frame_info_short_location,
3049 print_frame_info_choices, print_frame_info_print_what): New definitions.
3050 (print_frame_args): Only print dots for args if print frame-arguments
3051 is 'presence'.
3052 (frame_print_option_defs): New element for "frame-info".
3053 (get_user_print_what_frame_info): New function.
3054 (frame_show_address): Make non static. Move comment to stack.h.
3055 (print_frame_info_to_print_what): New function.
3056 (print_frame_info): Update comment. Use fp_opts.print_frame_info
3057 to decide what to print.
3058 (backtrace_command_1): Handle the new print_frame_arguments_presence
3059 value.
3060 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3061 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3062 (py_print_frame): In non-mi mode, use LOCATION as default for
3063 print_what, similarly to frame information printed directly by
3064 backtrace command. Handle frame-info user option in non MI mode.
3065
6bdfee81
KB
30662019-07-27 Kevin Buettner <kevinb@redhat.com>
3067
3068 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3069 Add case for debugging 32-bit target on 64-bit host. Revise
3070 comment.
3071
98a617f8
KB
30722019-07-27 Kevin Buettner <kevinb@redhat.com>
3073
3074 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3075 instead of find_function_entry_range_from_pc.
3076
567238c9
KB
30772019-07-27 Kevin Buettner <kevinb@redhat.com>
3078
3079 * stack.c (find_frame_funname): Remove code which preferred
3080 minsym over symtab sym in "certain pathological cases".
3081
2dc80cf8
KB
3082 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3083 parameter. Change type of "do_demangle" to bool.
3084 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3085 Pass suitable "prefer_sym_over_minsym" flag to
3086 build_address_symbolic(). Don't output "+" for negative offsets.
3087 * printcmd.c (print_address_symbolic): Update invocation of
3088 build_address_symbolic to include a "prefer_sym_over_minsym"
3089 flag.
3090 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3091 Restrict cases in which use of minimal symbol is preferred to that
3092 of a found symbol. Update comments.
3093
1aff7173
KB
3094 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3095 for entry pc when entry pc is out of range for that FDE.
3096
89b085ac
BC
30972019-07-26 Brian Callahan <bcallah@openbsd.org>
3098
3099 PR gdb/24839:
3100 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3101 type.
3102
f32feb4a
CB
31032019-07-25 Christian Biesinger <cbiesinger@google.com>
3104
3105 * python/py-objfile.c (add_separate_debug_file): Fix comment about
3106 this function's Python signature.
3107
3108
31092019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
3110
3111 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3112 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3113 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3114 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3115 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3116
3117
c54e4253
YS
31182019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
3119
3120 * h8300-tdep.c (h8300_register_name_common): New.
3121 h8300_register_name): Use h8300_register_name_common.
3122 (h8300s_register_name): Likewise.
3123 (h8300sx_register_name): Likewise.
3124 (h8300h_register_nam): New.
3125 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3126
3127
40eadf04
SP
31282019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
3129
3130 * arm-tdep.c (arm_skip_cmse_entry): New function.
3131 (arm_is_sgstubs_section): New function.
3132 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3133
bfa2a36d
TT
31342019-07-22 Tom Tromey <tom@tromey.com>
3135
3136 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3137 Don't self-assign.
3138
a8e9d247
AB
31392019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3140
3141 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3142 type_print.
3143
eb86c5e2
AB
31442019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3145
3146 * symtab.c (search_symbols): Adjust msymbol matching type arrays
3147 so that GDB doesn't match any msymbols when searching in the
3148 TYPES_DOMAIN.
3149 (print_symbol_info): Print using typedef_print or type_print based
3150 on the type of the symbol. Add updated FIXME comment moved from...
3151 (_initialize_symtab): ... move and update FIXME comment to above.
3152
a8eab7c6
AB
31532019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
3154
3155 * NEWS: Mention adding -q option to "info types".
3156 * symtab.c (struct info_types_options): New struct.
3157 (info_types_options_defs): New variable.
3158 (make_info_types_options_def_group): New function.
3159 (info_types_command): Use gdb::option framework to parse options.
3160 (info_types_command_completer): New function.
3161 (_initialize_symtab): Extend the help text on "info types" and
3162 register command completer.
3163
b4603c34
CB
31642019-07-21 Christian Biesinger <cbiesinger@google.com>
3165
3166 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3167 (lookup_symbol_in_objfile): Change int to block_enum and add a
3168 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3169
c8cdc1e0
CB
31702019-07-20 Christian Biesinger <cbiesinger@google.com>
3171
3172 * MAINTAINERS (Write After Approval): Add self.
3173
01e175fe
AB
31742019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
3175
3176 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3177 instruction to the dummy code region.
3178
56f79b63
TT
31792019-07-19 Tom Tromey <tromey@adacore.com>
3180
3181 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3182 (ARGSUSED, PARAMS, __func__): Remove rules.
3183
4c5aa8e0
AH
31842019-07-19 Alan Hayward <alan.hayward@arm.com>
3185
3186 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3187 * features/arm/arm-with-iwmmxt.c: Remove.
3188 * features/arm/arm-with-iwmmxt.xml: Remove.
3189 * features/arm/arm-with-m-fpa-layout.c: Remove.
3190 * features/arm/arm-with-m-fpa-layout.xml: Remove.
3191 * features/arm/arm-with-m-vfp-d16.c: Remove.
3192 * features/arm/arm-with-m-vfp-d16.xml: Remove.
3193 * features/arm/arm-with-m.c: Remove.
3194 * features/arm/arm-with-m.xml: Remove.
3195 * features/arm/arm-with-neon.c: Remove.
3196 * features/arm/arm-with-neon.xml: Remove.
3197 * features/arm/arm-with-vfpv2.c: Remove.
3198 * features/arm/arm-with-vfpv2.xml: Remove.
3199 * features/arm/arm-with-vfpv3.c: Remove.
3200 * features/arm/arm-with-vfpv3.xml: Remove.
3201
f42b2617
AH
32022019-07-19 Alan Hayward <alan.hayward@arm.com>
3203
3204 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3205
f29ec966
AH
32062019-07-19 Alan Hayward <alan.hayward@arm.com>
3207
3208 * arch/aarch32.c (aarch32_create_target_description): Create
3209 target descriptions using features.
3210 * arch/arm.c (arm_create_target_description)
3211 (arm_create_mprofile_target_description): Likewise.
3212 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3213
d105cce5
AH
32142019-07-19 Alan Hayward <alan.hayward@arm.com>
3215
3216 * Makefile.in: Add new files.
3217 * aarch32-tdep.c: New file.
3218 * aarch32-tdep.h: New file.
3219 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3220 Call aarch32_read_description.
3221 * arch/aarch32.c: New file.
3222 * arch/aarch32.h: New file.
3223 * arch/arm.c (arm_create_target_description)
3224 (arm_create_mprofile_target_description): New function.
3225 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3226 (arm_create_target_description)
3227 (arm_create_mprofile_target_description): New declaration.
3228 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3229 read_description functions.
3230 * arm-linux-nat.c (arm_linux_nat_target::read_description):
3231 Likewise.
3232 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3233 * arm-tdep.c (tdesc_arm_list): New variable.
3234 (arm_register_g_packet_guesses): Call create description functions.
3235 (arm_read_description) (arm_read_mprofile_description): New
3236 function.
3237 * arm-tdep.h (arm_read_description)
3238 (arm_read_mprofile_description): Add declaration.
3239 * configure.tgt: Add new files.
3240
afe09f0b
GL
32412019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
3242
3243 * top.c (new_ui_command): Open specified terminal just once.
3244
cd215b2e
TT
32452019-07-18 Tom Tromey <tromey@adacore.com>
3246
3247 * symtab.c (main_name): Constify return type.
3248 * symfile.c (set_initial_language): Update.
3249 * symtab.h (main_name): Constify return type.
3250
d8f68fcb
TT
32512019-07-17 Tom Tromey <tom@tromey.com>
3252
3253 * tui/tui-winsource.c (tui_update_source_window)
3254 (tui_update_source_window_as_is)
3255 (tui_update_source_windows_with_line): Remove return.
3256 * tui/tui-disasm.c (tui_show_disassem)
3257 (tui_show_disassem_and_update_source): Remove return.
3258 * tui/tui.c (tui_reset): Remove return.
3259 * tui/tui-wingeneral.c
3260 (tui_check_and_display_highlight_if_needed): Remove return.
3261
ca5af91e
TT
32622019-07-17 Tom Tromey <tom@tromey.com>
3263
3264 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3265
5104fe36
TT
32662019-07-17 Tom Tromey <tom@tromey.com>
3267
3268 * tui/tui-winsource.h (struct tui_exec_info_window)
3269 (struct tui_source_window_base): Move from tui-data.h.
3270 * tui/tui-winsource.c: Move many method definitions from
3271 elsewhere. Remove "structuring" comments.
3272 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3273 (tui_source_window_base::refresh_window): Move to
3274 tui-winsource.c.
3275 * tui/tui-win.c (tui_source_window_base::refresh_all)
3276 (tui_source_window_base::update_tab_width)
3277 (tui_source_window_base::set_new_height)
3278 (tui_source_window_base::do_make_visible_with_new_height): Move to
3279 tui-winsource.c.
3280 * tui/tui-source.h: Update.
3281 * tui/tui-source.c (tui_source_window_base::reset): Move to
3282 tui-winsource.c.
3283 * tui/tui-disasm.h: Update.
3284 * tui/tui-data.h (struct tui_exec_info_window): Move to
3285 tui-winsource.h.
3286 (struct tui_source_window_base): Likewise.
3287 * tui/tui-data.c (tui_source_window_base::clear_detail)
3288 (tui_source_window_base, ~tui_source_window_base): Move to
3289 tui-winsource.c.
3290
daa15dde
TT
32912019-07-17 Tom Tromey <tom@tromey.com>
3292
3293 * tui/tui-win.c (tui_resize_all)
3294 (tui_source_window_base::update_tab_width)
3295 (tui_adjust_win_heights): Update.
3296 (tui_win_info::make_invisible_and_set_new_height): Rename from
3297 make_invisible_and_set_new_height.
3298 * tui/tui-data.h (struct tui_win_info)
3299 <make_invisible_and_set_new_height>: New method.
3300
bfad4537
TT
33012019-07-17 Tom Tromey <tom@tromey.com>
3302
3303 * tui/tui.c: Update.
3304 * tui/tui-source.h (struct tui_source_window): Move from
3305 tui-data.h.
3306 * tui/tui-layout.c: Update.
3307 * tui/tui-disasm.c: Update.
3308 * tui/tui-data.h (struct tui_source_window): Move to
3309 tui-source.h.
3310
88f7e873
TT
33112019-07-17 Tom Tromey <tom@tromey.com>
3312
3313 * tui/tui-disasm.h (struct tui_disasm_window): Move from
3314 tui-data.h.
3315 * tui/tui-data.h (struct tui_disasm_window): Move to
3316 tui-disasm.h.
3317
96bd6233
TT
33182019-07-17 Tom Tromey <tom@tromey.com>
3319
3320 * tui/tui-regs.h (struct tui_data_item_window): Move from
3321 tui-data.h.
3322 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3323 * tui/tui-data.h (struct tui_data_item_window): Move to
3324 tui-regs.h.
3325 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3326
ce38393b
TT
33272019-07-17 Tom Tromey <tom@tromey.com>
3328
3329 * tui/tui.c: Update.
3330 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3331 (tui_cmd_window::max_height): Move to tui-command.c.
3332 * tui/tui-layout.c: Update.
3333 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3334 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3335 tui-command.c.
3336 * tui/tui-command.h (struct tui_cmd_window): Move from
3337 tui-data.h.
3338 * tui/tui-command.c: Remove "structuring" comments.
3339 (tui_cmd_window::clear_detail)
3340 (tui_cmd_window::do_make_visible_with_new_height)
3341 (tui_cmd_window::max_height): Move from elsewhere.
3342
2d8b51cb
TT
33432019-07-17 Tom Tromey <tom@tromey.com>
3344
3345 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3346 Now static.
3347 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3348 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3349
18ab23af
TT
33502019-07-17 Tom Tromey <tom@tromey.com>
3351
3352 * tui/tui.c: Update.
3353 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3354 tui-regs.c.
3355 * tui/tui-windata.h: Remove file.
3356 * tui/tui-windata.c: Remove file.
3357 * tui/tui-win.c (tui_data_window::set_new_height)
3358 (tui_data_window::do_make_visible_with_new_height): Move to
3359 tui-regs.c.
3360 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3361 * tui/tui-regs.c: Remove "structuring" comments.
3362 (tui_data_window::first_data_item_displayed)
3363 (tui_data_window::delete_data_content_windows)
3364 (tui_data_window::erase_data_content)
3365 (tui_data_window::display_all_data)
3366 (tui_data_window::refresh_all)
3367 (tui_data_window::do_scroll_vertical)
3368 (tui_data_window::clear_detail, tui_data_window::set_new_height)
3369 (tui_data_window::do_make_visible_with_new_height)
3370 (tui_data_window::refresh_window): Move from elsewhere.
3371 (_initialize_tui_regs): Move to end of file.
3372 * tui/tui-layout.c: Update.
3373 * tui/tui-hooks.c: Update.
3374 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3375 * tui/tui-data.c (tui_data_window::clear_detail): Move to
3376 tui-regs.c.
3377 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3378
88b7e7cc
TT
33792019-07-17 Tom Tromey <tom@tromey.com>
3380
3381 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3382 seen.
3383
0fcd3711
TT
33842019-07-17 Tom Tromey <tom@tromey.com>
3385
3386 * tui/tui-win.c (tui_source_window_base::set_new_height)
3387 (tui_source_window_base::do_make_visible_with_new_height): Use
3388 m_has_locator field directly.
3389 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3390 method.
3391 (struct tui_source_window_base) <has_locator>: Likewise.
3392
4a38112d
TT
33932019-07-17 Tom Tromey <tom@tromey.com>
3394
3395 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3396 Don't declare.
3397 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3398 Remove.
3399 * tui/tui-win.c (tui_source_window_base::set_new_height)
3400 (tui_source_window_base::set_new_height)
3401 (make_invisible_and_set_new_height)
3402 (tui_source_window_base::do_make_visible_with_new_height)
3403 (tui_source_window_base::do_make_visible_with_new_height):
3404 Update.
3405 * tui/tui-layout.c (show_source_disasm_command, show_data)
3406 (show_source_or_disasm_and_command): Update.
3407 * tui/tui-layout.c (show_layout): Update.
3408
09129226
TT
34092019-07-17 Tom Tromey <tom@tromey.com>
3410
3411 * tui/tui-layout.c (make_data_window): Remove.
3412 (show_data): Unify creation and re-initialization cases.
3413
4a8a5e84
TT
34142019-07-17 Tom Tromey <tom@tromey.com>
3415
3416 * tui/tui-layout.c (make_source_window, make_disasm_window):
3417 Remove.
3418 (show_data): Unify creation and re-initialization cases.
3419
76d2be8e
TT
34202019-07-17 Tom Tromey <tom@tromey.com>
3421
3422 * tui/tui-layout.c (make_command_window): Remove.
3423 (show_source_disasm_command, show_source_or_disasm_and_command):
3424 Unify creation and re-initialization cases.
3425
890b8bde
TT
34262019-07-17 Tom Tromey <tom@tromey.com>
3427
3428 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3429 creation and re-initialization cases.
3430
2cdfa113
TT
34312019-07-17 Tom Tromey <tom@tromey.com>
3432
3433 * tui/tui-regs.c (tui_get_register): Return void.
3434
8e3cfd09
TT
34352019-07-17 Tom Tromey <tom@tromey.com>
3436
3437 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3438 Simplify.
3439
f4e04977
TT
34402019-07-17 Tom Tromey <tom@tromey.com>
3441
3442 * tui/tui-layout.c (show_source_disasm_command): Simplify window
3443 resetting.
3444
0379b883
TT
34452019-07-17 Tom Tromey <tom@tromey.com>
3446
3447 * tui/tui.h (tui_set_layout_by_name): Don't declare.
3448 * tui/tui-regs.c (tui_reg_layout): New function.
3449 (tui_show_registers, tui_reg_command): Use it.
3450 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3451 (tui_layout_command): Rename from tui_set_layout_by_name. Change
3452 parameters.
3453 (tui_layout_command): Remove.
3454
b7fbad91
TT
34552019-07-17 Tom Tromey <tom@tromey.com>
3456
3457 * tui/tui-layout.h (tui/tui-layout): Return void.
3458 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
3459
4e1e56b9
TT
34602019-07-17 Tom Tromey <tom@tromey.com>
3461
3462 * tui/tui-layout.c (show_source_disasm_command, show_data):
3463 Update.
3464 (reset_locator): Remove.
3465 (show_source_or_disasm_and_command): Update.
3466
1e0c09ba
TT
34672019-07-17 Tom Tromey <tom@tromey.com>
3468
3469 * tui/tui-source.c (tui_source_window_base::reset): Remove
3470 win_type parameter.
3471 * tui/tui-layout.c (make_command_window, make_source_window)
3472 (make_disasm_window, make_data_window)
3473 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3474 (reset_locator, show_source_or_disasm_and_command): Update.
3475 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3476 win_type parameter.
3477 (struct tui_source_window_base) <reset>: Likewise.
3478
1bf605de
TT
34792019-07-17 Tom Tromey <tom@tromey.com>
3480
3481 * tui/tui-layout.c (show_source_disasm_command): Use
3482 reset_locator.
3483 (reset_locator): New function.
3484 (init_and_make_win): Remove.
3485 (show_source_or_disasm_and_command): Use reset_locator.
3486
098f9ed4
TT
34872019-07-17 Tom Tromey <tom@tromey.com>
3488
3489 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3490 condition.
3491 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3492 Remove condition.
3493 * tui/tui-source.c (tui_source_window_base::reset): New method.
3494 * tui/tui-layout.c (make_command_window): Don't call
3495 init_and_make_win.
3496 (make_source_window, make_disasm_window): Don't call
3497 make_source_or_disasm_window.
3498 (make_data_window): Don't call init_and_make_win. Change calling
3499 convention.
3500 (show_source_disasm_command, show_data): Simplify.
3501 (make_source_or_disasm_window): Remove.
3502 (show_source_or_disasm_and_command): Simplify.
3503 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3504 (struct tui_source_window_base) <reset>: Likewise.
3505 <execution_info>: Remove initializer.
3506 * tui/tui-data.c (tui_source_window_base): Initialize
3507 execution_info.
3508
80110957
TT
35092019-07-17 Tom Tromey <tom@tromey.com>
3510
3511 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3512 variable.
3513
cf82af05
TT
35142019-07-17 Tom Tromey <tom@tromey.com>
3515
3516 * tui/tui.c (tui_rl_other_window): Update.
3517 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3518 superclass method first. Always iterate over regs_content.
3519 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3520 method.
3521 * tui/tui-win.c (tui_set_focus_command): Update.
3522
01aeb396
TT
35232019-07-17 Tom Tromey <tom@tromey.com>
3524
3525 * tui/tui-win.c (tui_set_focus_command): Rename from
3526 tui_set_focus. Call tui_enable.
3527 (tui_set_focus_command): Remove.
3528
fd6c75ee
TT
35292019-07-17 Tom Tromey <tom@tromey.com>
3530
3531 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3532 refresh_window.
3533 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3534 touchwin.
3535 (tui_data_window::refresh_window): Call refresh_window on data
3536 items. Always call superclass refresh_window.
3537 (tui_win_info::refresh): Remove.
3538 (tui_source_window_base::refresh_window): Update.
3539 (tui_refresh_all): Update.
3540 * tui/tui-layout.c (show_source_disasm_command): Remove call to
3541 refresh_window.
3542 (show_source_or_disasm_and_command): Likewise.
3543 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3544 (struct tui_source_window_base) <refresh>: Likewise.
3545
f6cc34a9
TT
35462019-07-17 Tom Tromey <tom@tromey.com>
3547
3548 * tui/tui-winsource.c (tui_clear_source_content)
3549 (tui_show_source_content): Update.
3550 * tui/tui-source.c (tui_source_window::showing_source_p): Check
3551 whether content is empty.
3552 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3553 Remove.
3554
f31ec9af
TT
35552019-07-17 Tom Tromey <tom@tromey.com>
3556
3557 * tui/tui-winsource.c (tui_erase_source_content): Clear the
3558 window's contents.
3559 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3560 * tui/tui-source.c (tui_set_source_content_nil): Remove.
3561
d1b6f1e5
TT
35622019-07-17 Tom Tromey <tom@tromey.com>
3563
3564 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3565 (struct tui_data_item_window): Update.
3566
d9743a13
TT
35672019-07-17 Tom Tromey <tom@tromey.com>
3568
3569 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3570 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3571 defines.
3572
caf0bc4e
TT
35732019-07-17 Tom Tromey <tom@tromey.com>
3574
3575 * tui/tui-winsource.h (tui_erase_source_content)
3576 (tui_clear_source_content): Remove "display_prompt" parameter.
3577 * tui/tui-winsource.c (tui_update_source_window_as_is)
3578 (tui_update_source_windows_with_addr): Update.
3579 (tui_clear_source_content): Remove "display_prompt" parameter.
3580 (tui_erase_source_content): Likewise. Simplify.
3581 (tui_show_source_content): Update.
3582 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3583 * tui/tui-stack.c (tui_show_frame_info): Update.
3584 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3585 Remove defines.
3586
9d391078
TT
35872019-07-17 Tom Tromey <tom@tromey.com>
3588
3589 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3590 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3591 parameter.
3592 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3593 parameter.
3594
a38da35d
TT
35952019-07-17 Tom Tromey <tom@tromey.com>
3596
3597 * tui/tui-winsource.c (tui_clear_source_content)
3598 (tui_show_source_content, tui_show_exec_info_content)
3599 (tui_clear_exec_info_content): Update.
3600 * tui/tui-stack.c (tui_show_locator_content): Update.
3601 (tui_show_frame_info): Update.
3602 * tui/tui-source.h (tui_source_window): Don't declare.
3603 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3604 from tui_source_is_displayed.
3605 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3606 Remove field.
3607 (struct tui_source_window_base) <content_in_use>: New field. Now
3608 bool.
3609 (struct tui_source_window) <showing_source_p>: New method.
3610 (TUI_SRC_WIN): Change cast.
3611 * tui/tui-data.c (tui_initialize_static_data): Update.
3612
c2cd8994
TT
36132019-07-17 Tom Tromey <tom@tromey.com>
3614
3615 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3616 location_matches_p.
3617 * tui/tui-source.c (tui_source_window::location_matches_p): New
3618 method.
3619 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3620 method.
3621 * tui/tui-data.h (struct tui_source_window_base)
3622 <location_matches_p>: New method.
3623 (struct tui_source_window, struct tui_disasm_window)
3624 <location_matches_p>: Likewise.
3625
4dde7b34
TT
36262019-07-17 Tom Tromey <tom@tromey.com>
3627
3628 * tui/tui-win.c (tui_set_win_height_command): Rename from
3629 tui_set_win_height.
3630 (tui_set_win_height_command): Remove.
3631
b73dd877
TT
36322019-07-17 Tom Tromey <tom@tromey.com>
3633
3634 * tui/tui-source.c (tui_source_window): New constructor. Add
3635 observer.
3636 (~tui_source_window): New destructor.
3637 (tui_source_window::style_changed): New method.
3638 * tui/tui-hooks.c (tui_redisplay_source): Remove.
3639 (tui_attach_detach_observers): Update.
3640 * tui/tui-data.h (struct tui_source_window): Make constructor not
3641 inline. Add destructor.
3642 (struct tui_source_window) <style_changed>: New method.
3643 <m_observable>: New member.
3644
ae2b5380
TT
36452019-07-17 Tom Tromey <tom@tromey.com>
3646
3647 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3648 * tui/tui-win.c (tui_resize_all): Fix typo.
3649
1ce3e844
TT
36502019-07-17 Tom Tromey <tom@tromey.com>
3651
3652 * tui/tui-wingeneral.h (tui_refresh_all): Update.
3653 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3654 (tui_refresh_all): Remove "list" parameter. Use foreach.
3655 * tui/tui-win.c (window_name_completer): Use foreach.
3656 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3657 (update_tab_width): Likewise.
3658 * tui/tui-layout.c (show_layout): Update.
3659 * tui/tui-data.h (class tui_window_iterator): New.
3660 (struct all_tui_windows): New.
3661 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3662
fe3eaf1c
TT
36632019-07-17 Tom Tromey <tom@tromey.com>
3664
3665 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3666 parameter. Don't reference globals.
3667 (tui_reg_command): Update.
3668
368c1354
TT
36692019-07-17 Tom Tromey <tom@tromey.com>
3670
3671 * tui/tui-regs.c (tui_show_registers): Simplify.
3672
e80cd204
TT
36732019-07-17 Tom Tromey <tom@tromey.com>
3674
3675 * tui/tui-regs.c (tui_show_registers): Update.
3676 (tui_show_register_group): Add win_info parameter.
3677
aca2dd16
TT
36782019-07-17 Tom Tromey <tom@tromey.com>
3679
3680 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3681 Rename from tui_display_reg_element_at_line.
3682 (tui_data_window::display_registers_from_line): Update.
3683 * tui/tui-data.h (struct tui_data_window)
3684 <display_reg_element_at_line>: New method.
3685
517e9505
TT
36862019-07-17 Tom Tromey <tom@tromey.com>
3687
3688 * tui/tui-regs.h (tui_display_registers_from)
3689 (tui_display_registers_from_line): Don't declare.
3690 * tui/tui-windata.c (tui_data_window::display_all_data)
3691 (tui_data_window::refresh_all)
3692 (tui_data_window::do_scroll_vertical): Update.
3693 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3694 from tui_display_registers_from.
3695 (tui_display_reg_element_at_line): Update.
3696 (tui_data_window::display_registers_from_line): Rename from
3697 tui_display_registers_from_line.
3698 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3699 display_registers_from_line>: New methods.
3700
f76d8b19
TT
37012019-07-17 Tom Tromey <tom@tromey.com>
3702
3703 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3704 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3705 from tui_erase_data_content.
3706 (tui_data_window::display_all_data)
3707 (tui_data_window::refresh_all)
3708 (tui_data_window::do_scroll_vertical): Update.
3709 * tui/tui-regs.c (tui_show_registers): Update.
3710 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3711 New method.
3712
b4094625
TT
37132019-07-17 Tom Tromey <tom@tromey.com>
3714
3715 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3716 declare.
3717 * tui/tui-windata.c
3718 (tui_data_window::delete_data_content_windows): Rename from
3719 tui_delete_data_content_windows.
3720 (tui_data_window::display_all_data)
3721 (tui_data_window::do_scroll_vertical): Update.
3722 * tui/tui-data.h (struct tui_data_window)
3723 <delete_data_content_windows>: New method.
3724
c223a729
TT
37252019-07-17 Tom Tromey <tom@tromey.com>
3726
3727 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3728 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3729
50daf268
TT
37302019-07-17 Tom Tromey <tom@tromey.com>
3731
3732 * tui/tui-windata.h (tui_display_all_data): Don't declare.
3733 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3734 from tui_display_all_data.
3735 * tui/tui-win.c
3736 (tui_data_window::do_make_visible_with_new_height): Update.
3737 * tui/tui-regs.c (tui_show_registers): Update.
3738 * tui/tui-layout.c (tui_set_layout): Update.
3739 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3740 method.
3741
df5f8cab
TT
37422019-07-17 Tom Tromey <tom@tromey.com>
3743
3744 * tui/tui-windata.h (tui_display_data_from): Don't declare.
3745 * tui/tui-windata.c (tui_display_data_from): Remove.
3746 (tui_data_window::refresh_all): Update.
3747
80cb6c27
TT
37482019-07-17 Tom Tromey <tom@tromey.com>
3749
3750 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3751 * tui/tui-windata.c (tui_display_data_from_line): Remove.
3752 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3753 tui_display_registers_from_line.
3754 * tui/tui-regs.h (tui_display_registers_from_line): Update.
3755 * tui/tui-regs.c (tui_display_registers_from_line): Remove
3756 "force_display" parameter.
3757
baff0c28
TT
37582019-07-17 Tom Tromey <tom@tromey.com>
3759
3760 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3761 declare.
3762 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3763 Rename from tui_first_reg_element_no_inline.
3764 (tui_display_reg_element_at_line)
3765 (tui_display_registers_from_line): Update.
3766 * tui/tui-data.h (struct tui_data_window)
3767 <first_reg_element_no_inline>: New method.
3768
3b23c5f2
TT
37692019-07-17 Tom Tromey <tom@tromey.com>
3770
3771 * tui/tui-windata.c (tui_display_data_from)
3772 (tui_data_window::do_scroll_vertical): Update.
3773 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3774 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3775 Rename from tui_line_from_reg_element_no.
3776 (tui_display_registers_from_line): Update.
3777 * tui/tui-data.h (struct tui_data_window)
3778 <line_from_reg_element_no>: New method.
3779
0b5ec218
TT
37802019-07-17 Tom Tromey <tom@tromey.com>
3781
3782 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3783 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3784 tui_last_regs_line_no.
3785 (tui_display_reg_element_at_line)
3786 (tui_display_registers_from_line): Update.
3787 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3788 method.
3789
0807ab7b
TT
37902019-07-17 Tom Tromey <tom@tromey.com>
3791
3792 PR tui/24722:
3793 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3794 (tui_update_breakpoint_info): Add "being_deleted" parameter.
3795 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3796 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3797 (tui_update_breakpoint_info): Likewise.
3798 * tui/tui-hooks.c (tui_event_create_breakpoint)
3799 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3800 Update.
3801
9ad7fdef
TT
38022019-07-17 Tom Tromey <tom@tromey.com>
3803
3804 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3805
5813316f
TT
38062019-07-17 Tom Tromey <tom@tromey.com>
3807
3808 * tui/tui-winsource.c (tui_update_source_window_as_is)
3809 (tui_update_source_windows_with_addr): Update.
3810 * tui/tui-source.h (tui_set_source_content)
3811 (tui_show_symtab_source): Add "win_info" parameter.
3812 * tui/tui-source.c (tui_set_source_content): Add "win_info"
3813 parameter.
3814 (tui_show_symtab_source): Likewise.
3815
00e264e7
TT
38162019-07-17 Tom Tromey <tom@tromey.com>
3817
3818 * tui/tui-wingeneral.c
3819 (tui_check_and_display_highlight_if_needed): Check can_highlight.
3820
06210ce4
TT
38212019-07-17 Tom Tromey <tom@tromey.com>
3822
3823 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3824 (struct tui_cmd_window) <can_scroll>: New method.
3825 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3826 method.
3827
381befee
TT
38282019-07-17 Tom Tromey <tromey@adacore.com>
3829
3830 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3831 do_field_signed>: Rename. Change type of "value".
3832 * ui-out.c (ui_out::field_signed): Rename from field_int.
3833 Change type of "value".
3834 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
3835 type of "value".
3836 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3837 do_field_int. Change type of "value".
3838 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3839 do_field_int. Change type of "value".
3840 * tracepoint.c (trace_status_mi, tfind_1)
3841 (print_one_static_tracepoint_marker): Update.
3842 * thread.c (print_thread_info_1, print_selected_thread_frame):
3843 Update.
3844 * stack.c (print_frame, print_frame_info): Update.
3845 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3846 Update.
3847 * source.c (print_source_lines_base): Update.
3848 * skip.c (info_skip_command): Update.
3849 * record-btrace.c (btrace_ui_out_decode_error)
3850 (btrace_call_history_src_line): Update.
3851 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3852 Update.
3853 * progspace.c (print_program_space): Update.
3854 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3855 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3856 do_field_int. Change type of "value".
3857 * mi/mi-out.c (mi_ui_out::do_table_begin)
3858 (mi_ui_out::do_table_header): Update.
3859 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
3860 type of "value".
3861 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3862 (mi_cmd_data_list_changed_registers, output_register)
3863 (mi_cmd_data_read_memory, mi_load_progress)
3864 (mi_cmd_trace_frame_collected): Update.
3865 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3866 Update.
3867 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3868 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3869 (mi_cmd_var_list_children, varobj_update_one): Update.
3870 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3871 (mi_cmd_stack_list_args, list_arg_or_local): Update.
3872 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3873 * inferior.c (print_inferior): Update.
3874 * gdb_bfd.c (print_one_bfd): Update.
3875 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3876 Update.
3877 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3878 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3879 do_field_int. Change type of "value".
3880 * cli-out.c (cli_ui_out::do_field_signed): Rename from
3881 do_field_int. Change type of "value".
3882 * breakpoint.c (watchpoint_check, print_breakpoint_location)
3883 (print_one_breakpoint_location, print_it_catch_fork)
3884 (print_one_catch_fork, print_it_catch_vfork)
3885 (print_one_catch_vfork, print_it_catch_solib)
3886 (print_it_catch_exec, print_it_ranged_breakpoint)
3887 (print_mention_watchpoint, print_mention_masked_watchpoint)
3888 (bkpt_print_it, update_static_tracepoint): Update.
3889 * break-catch-throw.c (print_it_exception_catchpoint): Update.
3890 * break-catch-syscall.c (print_it_catch_syscall): Update.
3891 * ada-tasks.c (print_ada_task_info): Update.
3892 * ada-lang.c (print_it_exception, print_mention_exception):
3893 Update.
3894
6b78c3f8
AB
38952019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
3896
3897 PR breakpoints/24541
3898 * gdbarch.c: Regenerate.
3899 * gdbarch.h: Regenerate.
3900 * gdbarch.sh: Adjust return type and parameter types for
3901 'stap_adjust_register'.
3902 (i386_stap_adjust_register): Adjust signature and return new
3903 register name.
3904 * stap-probe.c (stap_parse_register_operand): Adjust use of
3905 'gdbarch_stap_adjust_register'.
3906
d72a9b85
TT
39072019-07-17 Tom Tromey <tromey@adacore.com>
3908
3909 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
3910 declare VEC.
3911 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3912 std::vector.
3913 (struct s390_process_info): Add initializers.
3914 (s390_add_process): Use new.
3915 (s390_linux_nat_target::low_forget_process): Use delete.
3916 (s390_linux_nat_target::low_new_fork)
3917 (s390_linux_nat_target::stopped_by_watchpoint)
3918 (s390_linux_nat_target::low_prepare_to_resume)
3919 (s390_linux_nat_target::insert_watchpoint)
3920 (s390_linux_nat_target::insert_hw_breakpoint)
3921 (s390_linux_nat_target::remove_watchpoint)
3922 (s390_linux_nat_target::remove_hw_breakpoint): Update.
3923
206e6c58
JB
39242019-07-16 John Baldwin <jhb@FreeBSD.org>
3925
3926 * aarch64-fbsd-nat.c: Include regcache.h.
3927 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3928 argument.
3929 (aarch64_fbsd_nat_target::fetch_registers)
3930 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3931 variable.
3932 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3933
cbde90f2
JB
39342019-07-16 John Baldwin <jhb@FreeBSD.org>
3935
3936 * fbsd-nat.c: Include gdbarch.h.
3937
07128006
TT
39382019-07-15 Tom Tromey <tromey@adacore.com>
3939
3940 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3941
1f77b012
TT
39422019-07-15 Tom Tromey <tromey@adacore.com>
3943
3944 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3945 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3946 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3947 * cli-out.c (cli_ui_out::do_field_int): New method.
3948 * ui-out.c (ui_out::field_unsigned): New method.
3949 * symfile.c (generic_load): Use field_unsigned.
3950 (print_transfer_performance): Likewise.
3951 * record-btrace.c (ui_out_field_uint): Remove.
3952 (btrace_call_history_insn_range, btrace_call_history): Use
3953 field_unsigned.
3954 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3955 field_unsigned.
3956 * ui-out.h (class ui_out) <field_unsigned>: New method.
3957 <do_field_unsigned>: Likewise.
3958
33eca680
TT
39592019-07-15 Tom Tromey <tromey@adacore.com>
3960
3961 * mi/mi-main.c (list_available_thread_groups): Use field_string.
3962 * mi/mi-interp.c (mi_memory_changed): Use field_string.
3963 * target.c (flash_erase_command): Use field_string.
3964 * infrun.c (print_signal_received_reason): Use field_string.
3965 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3966 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3967 field_string.
3968 * ada-tasks.c (print_ada_task_info): Use field_string.
3969
ca8d69be
TT
39702019-07-15 Tom Tromey <tromey@adacore.com>
3971
3972 * target.c (flash_erase_command): Use field_core_addr.
3973 * symfile.c (generic_load): Use field_core_addr.
3974 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3975 Use field_core_addr.
3976 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3977 field_core_addr.
3978
0d4e84ed
AB
39792019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3980
3981 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3982 value if its desired type is smaller than a CORE_ADDR and signed.
3983
9a49df9d
AB
39842019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3985
3986 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3987 of changes to field names, and use new is_reference field to
3988 decide if a property is a reference or not.
3989 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3990 field.
3991 (struct dwarf2_property_baton): Update header comment, rename
3992 'referenced_type' to 'property_type' and update comments.
3993 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3994 default property type, store in property baton, update to take
3995 accound of renamed field.
3996 (read_func_scope): Update call to attr_to_dynamic_prop.
3997 (read_array_type): Likewise.
3998 (dwarf2_per_cu_addr_sized_int_type): New function.
3999 (read_subrange_index_type): Move type finding code to
4000 dwarf2_per_cu_addr_sized_int_type.
4001 (read_subrange_type): Update calls to attr_to_dynamic_prop.
4002 (dwarf2_per_cu_addr_type): New function.
4003 (set_die_type): Update calls to attr_to_dynamic_prop.
4004
b86352cf
AB
40052019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4006
4007 * dwarf2read.c (read_subrange_index_type): New function.
4008 (read_subrange_type): Move code into new function and call it.
4009 * gdbtypes.c (create_range_type): Add some asserts.
4010
603490bf
AB
40112019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4012
4013 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4014 update return statements.
4015 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4016 declaration, and update comment to match.
4017 * gdbtypes.c (resolve_dynamic_array): Update call to
4018 dwarf2_evaluate_property to match new return type.
4019
592f9d27
AB
40202019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
4021
4022 * valarith.c (value_subscripted_rvalue): Change lowerbound
4023 parameter type from int to LONGEST.
4024 * value.h (value_subscripted_rvalue): Likewise in declaration.
4025
60cfcb20
AB
40262019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4027
4028 * cli/cli-utils.c (info_print_command_completer): New function.
4029 * cli/cli-utils.h: Add 'completer.h' include, and forward
4030 declaration for 'struct cmd_list_element'.
4031 (info_print_command_completer): Declare.
4032 * stack.c (_initialize_stack): Add completer for 'info locals' and
4033 'info args'.
4034 * symtab.c (_initialize_symtab): Add completer for 'info
4035 variables' and 'info functions'.
4036 * NEWS: Mention completion for additional info commands.
4037
b16507e0
AB
40382019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4039
4040 * cli/cli-utils.c (extract_info_print_args): Delete.
4041 (extract_arg_maybe_quoted): Delete.
4042 (info_print_options_defs): New variable.
4043 (make_info_print_options_def_group): New function.
4044 (extract_info_print_options): Define new function.
4045 * cli/cli-utils.h (extract_info_print_args): Delete.
4046 (struct info_print_options): New structure.
4047 (extract_info_print_options): Declare new function.
4048 * stack.c (info_locals_command): Update to use new
4049 extract_info_print_options, also add a header comment.
4050 (info_args_command): Likewise.
4051 * symtab.c (info_variables_command): Likewise.
4052 (info_functions_command): Likewise.
4053
021d8588
AB
40542019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
4055
4056 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4057 to extract string arguments.
4058 * common/common-utils.c (extract_string_maybe_quoted): New function.
4059 * common/common-utils.h (extract_string_maybe_quoted): Declare.
4060
b777eb6d
TT
40612019-07-11 Tom Tromey <tromey@adacore.com>
4062
4063 * main.c (get_init_files): Use GDBINIT, not gdbinit.
4064 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4065 * top.h (gdbinit): Don't declare.
4066 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4067 into...
4068 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
4069 * top.c (gdb_init): Don't call init_cli_cmds.
4070 (gdbinit): Remove.
4071 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4072
72ee03ff
TT
40732019-07-11 Tom Tromey <tromey@adacore.com>
4074
4075 * python/py-inferior.c (add_thread_object): Don't use thread_obj
4076 after it has been moved.
4077
00db9531
SM
40782019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4079
4080 * valops.c (value_must_coerce_to_target): Change return type to
4081 bool.
4082 * value.h (value_must_coerce_to_target): Likewise.
4083
f2478a7e
SM
40842019-07-10 Simon Marchi <simon.marchi@efficios.com>
4085
4086 * breakpoint.c (is_hardware_watchpoint): Remove
4087 forward-declaration.
4088 (is_masked_watchpoint): Change return type to bool.
4089 (is_tracepoint): Likewise.
4090 (is_breakpoint): Likewise.
4091 (is_hardware_watchpoint): Likewise.
4092 (is_watchpoint): Likewise.
4093 (is_no_memory_software_watchpoint): Likewise.
4094 (is_catchpoint): Likewise.
4095 (breakpoint_1): Make FILTER parameter's return type bool.
4096 is_masked_watchpoint): Change return type to bool.
4097 (save_breakpoints): Make FILTER parameter's return type bool.
4098 * breakpoint.h (is_breakpoint): Change return type to bool.
4099 (is_watchpoint): Likewise.
4100 (is_catchpoint): Likewise.
4101 (is_tracepoint): Likewise.
4102
0d12e84c
TT
41032019-07-10 Tom Tromey <tom@tromey.com>
4104
4105 * defs.h: Don't include gdbarch.h.
4106 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4107 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4108 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4109 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4110 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4111 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4112 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4113 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4114 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4115 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4116 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4117 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4118 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4119 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4120 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4121 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4122 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4123 record-btrace.c, record.h, regcache-dump.c, regcache.h,
4124 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4125 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4126 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4127 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4128 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4129 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4130 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4131 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4132 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4133
f06f1252
TT
41342019-07-10 Tom Tromey <tromey@adacore.com>
4135
4136 * ada-lang.h (is_ada_exception_catchpoint): Declare.
4137 * breakpoint.c (init_ada_exception_breakpoint): Register as
4138 bp_catchpoint.
4139 (print_one_breakpoint_location, print_one_breakpoint): Use
4140 is_ada_exception_catchpoint.
4141 * ada-lang.c (class ada_catchpoint_location): Pass
4142 bp_loc_software_breakpoint to bp_location constructor.
4143 (is_ada_exception_catchpoint): New function.
4144
7a5d944b
TT
41452019-07-10 Tom Tromey <tromey@adacore.com>
4146
4147 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
4148 VEC.
4149 (struct arm_exidx_entry): New method operator<.
4150 (struct arm_exidx_data) <section_maps>: Change type.
4151 (arm_exidx_data_free): Remove.
4152 (arm_exidx_data_key): Change type. Move lower.
4153 (arm_exidx_new_objfile): Update.
4154 (arm_compare_exidx_entries): Remove.
4155 (arm_find_exidx_entry, _initialize_arm_tdep)
4156
48c66e1d
TT
41572019-07-10 Tom Tromey <tromey@adacore.com>
4158
4159 * solib-spu.c (ocl_program_data_key): Change type.
4160 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4161 Update.
4162
a269fbf1
TT
41632019-07-10 Tom Tromey <tromey@adacore.com>
4164
4165 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
4166 (struct solib_aix_inferior_data) <library_list>: Change type.
4167 (solib_aix_inferior_data_handle): Change type.
4168 (get_solib_aix_inferior_data): Update.
4169 (solib_aix_free_library_list): Remove.
4170 (library_list_start_library): Update.
4171 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4172 return type.
4173 (solib_aix_get_library_list)
4174 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4175 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4176
c294730c
TT
41772019-07-10 Tom Tromey <tromey@adacore.com>
4178
4179 * solib-dsbt.c (struct dsbt_info): Add initializers.
4180 (solib_dsbt_pspace_data): Change type.
4181 (dsbt_pspace_data_cleanup): Remove.
4182 (get_dsbt_info, _initialize_dsbt_solib): Update.
4183
9d52077d
TT
41842019-07-10 Tom Tromey <tromey@adacore.com>
4185
4186 * spu-tdep.c (spu_overlay_data): Change type.
4187 (spu_get_overlay_table, spu_overlay_new_objfile)
4188 (_initialize_spu_tdep): Update.
4189
22a20dca
TT
41902019-07-10 Tom Tromey <tromey@adacore.com>
4191
4192 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4193 destructor.
4194 (dbx_objfile_data_key): Change type and declare later.
4195 (DBX_SYMFILE_INFO): Rewrite.
4196 * dbxread.c (dbx_objfile_data_key): Change type.
4197 (dbx_symfile_init): Update.
4198 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
4199 (coffstab_build_psymtabs, elfstab_build_psymtabs)
4200 (stabsect_build_psymtabs, _initialize_dbxread): Update.
4201
cb60f420
TT
42022019-07-10 Tom Tromey <tromey@adacore.com>
4203
4204 * jit.c (jit_program_space_key): Change type. Move lower.
4205 (get_jit_program_space_data): Update.
4206 (jit_program_space_data_cleanup): Remove.
4207 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4208 Update.
4209 (struct jit_program_space_data): Add initializers.
4210
51df2ae3
TT
42112019-07-10 Tom Tromey <tromey@adacore.com>
4212
4213 * solib-darwin.c (struct darwin_info): Add initializers.
4214 (solib_darwin_pspace_data): Change type.
4215 (darwin_pspace_data_cleanup): Remove.
4216 (get_darwin_info, _initialize_darwin_solib): Update.
4217
18101a35
TT
42182019-07-10 Tom Tromey <tromey@adacore.com>
4219
4220 * remote-sim.c (struct sim_inferior_data): Add initializers,
4221 constructor, and destructor.
4222 (sim_inferior_data_key): Change type. Move lower.
4223 (check_for_duplicate_sim_descriptor): Update.
4224 (get_sim_inferior_data): Use new. Update.
4225 (~sim_inferior_data_cleanup): Rename from
4226 sim_inferior_data_cleanup. Simplify.
4227 (gdbsim_close_inferior, simulator_command)
4228 (sim_command_completer, _initialize_remote_sim): Update.
4229 (next_pid, INITIAL_PID): Move earlier.
4230
05b08ac1
TT
42312019-07-10 Tom Tromey <tromey@adacore.com>
4232
4233 * python/python-internal.h (create_thread_object): Return
4234 gdbpy_ref.
4235 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4236 * python/py-inferior.c (struct threadlist_entry): Add
4237 constructor.
4238 <thread_obj>: Now a gdbpy_ref.
4239 (thread_to_thread_object): Update.
4240 (add_thread_object): Use new.
4241 (delete_thread_object): Use delete.
4242 (infpy_threads): Update.
4243 (py_free_inferior): Update. Construct "inf_obj" after acquiring
4244 GIL.
4245
32372d80
TT
42462019-07-10 Tom Tromey <tromey@adacore.com>
4247
4248 * valops.c (value_cast): Specialize error message for Ada.
4249
5c458ae8
SM
42502019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4251
4252 * breakpoint.c (breakpoint_1): Update doc and parameter names.
4253
4c462cb0
SM
42542019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
4255
4256 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4257 bpstat_should_step): Return bool, adjust comments.
4258 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4259 bpstat_should_step): Likewise.
4260
89abbcc2
AH
42612019-07-10 Alan Hayward <alan.hayward@arm.com>
4262
4263 * features/Makefile: Use feature target descriptions for Arm.
4264 * features/arm/arm-core.c: Generate new file.
4265 * features/arm/arm-fpa.c: Likewise.
4266 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4267 * features/arm/arm-m-profile.c: Likewise.
4268 * features/arm/arm-vfpv2.c: Likewise.
4269 * features/arm/arm-vfpv3.c: Likewise.
4270 * features/arm/xscale-iwmmxt.c: Likewise.
4271 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4272
166a82be
AH
42732019-07-10 Alan Hayward <alan.hayward@arm.com>
4274
4275 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4276 ptrace earlier.
4277
9fb4c7e9
AH
42782019-07-10 Alan Hayward <alan.hayward@arm.com>
4279
4280 * features/aarch64-pauth.c: Regenerate.
4281
e2d0f980
SM
42822019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
4283
4284 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4285 bool.
4286 (bpstat_what): Use false instead of 0.
4287
a38118e5
PA
42882019-07-09 Pedro Alves <palves@redhat.com>
4289
4290 * break-catch-throw.c (is_exception_catchpoint): New.
4291 * breakpoint.c (print_one_breakpoint_location): New parameter
4292 'raw_loc'. Handle it. Use
4293 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4294 looking at the breakpoint's type.
4295 (print_one_breakpoint): If handling "maint info breakpoints", also
4296 print locations of exception catchpoints.
4297 * breakpoint.h (is_exception_catchpoint): Declare.
4298
cb1e4e32
PA
42992019-07-09 Pedro Alves <palves@redhat.com>
4300
4301 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4302 "addr" field.
4303 (allocate_location_exception_catchpoint): New.
4304 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4305 (initialize_throw_catchpoint_ops): Install
4306 allocate_location_exception_catchpoint as allocate_location
4307 method.
4308 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4309 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4310 bp_loc_other.
4311 (breakpoint_address_is_meaningful): Delete.
4312 (bl_address_is_meaningful): New.
4313 (breakpoint_locations_match): Adjust comment.
4314 (bp_location_from_bp_type): New, factored out of...
4315 (bp_location::bp_location(breakpoint *)): ... this.
4316 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4317 factored out of...
4318 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
4319 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4320 breakpoint_address_is_meaningful.
4321 (bp_locations_compare): Adjust comment.
4322 (update_global_location_list): Use bl_address_is_meaningful
4323 instead of breakpoint_address_is_meaningful.
4324 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4325 explicit.
4326 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4327 * python/py-breakpoint.c (bppy_get_location): No longer check
4328 whether location is null.
4329
b58a68fe
PA
43302019-07-09 Pedro Alves <palves@redhat.com>
4331
4332 PR c++/15468
4333 * breakpoint.c (print_one_breakpoint_location): Remove
4334 single-location assert.
4335
268a13a5
TT
43362019-07-09 Tom Tromey <tom@tromey.com>
4337
4338 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4339 * configure: Rebuild.
4340 * configure.ac: Change common to gdbsupport.
4341 * gdbsupport: Rename from common.
4342 * acinclude.m4: Change common to gdbsupport.
4343 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4344 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4345 gdbsupport.
4346 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4347 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4348 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4349 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4350 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4351 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4352 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4353 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4354 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4355 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4356 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4357 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4358 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4359 coff-pe-read.c, command.h, compile/compile-c-support.c,
4360 compile/compile-c.h, compile/compile-cplus-symbols.c,
4361 compile/compile-cplus-types.c, compile/compile-cplus.h,
4362 compile/compile-loc2c.c, compile/compile.c, completer.c,
4363 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4364 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4365 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4366 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4367 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4368 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4369 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4370 features/aarch64-core.c, features/aarch64-fpu.c,
4371 features/aarch64-pauth.c, features/aarch64-sve.c,
4372 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4373 features/i386/32bit-core.c, features/i386/32bit-linux.c,
4374 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4375 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4376 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4377 features/i386/64bit-core.c, features/i386/64bit-linux.c,
4378 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4379 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4380 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4381 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4382 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4383 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4384 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4385 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4386 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4387 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4388 go32-nat.c, guile/guile.c, guile/scm-ports.c,
4389 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4390 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4391 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4392 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4393 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4394 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4395 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4396 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4397 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4398 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4399 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4400 minsyms.c, mips-linux-tdep.c, namespace.h,
4401 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4402 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4403 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4404 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4405 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4406 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4407 nat/linux-waitpid.c, nat/mips-linux-watch.c,
4408 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4409 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4410 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4411 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4412 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4413 procfs.c, producer.c, progspace.h, psymtab.h,
4414 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4415 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4416 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4417 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4418 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4419 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4420 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4421 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4422 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4423 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4424 target-memory.c, target.c, target.h, target/waitstatus.c,
4425 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4426 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4427 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4428 unittests/array-view-selftests.c,
4429 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4430 unittests/common-utils-selftests.c,
4431 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4432 unittests/format_pieces-selftests.c,
4433 unittests/function-view-selftests.c,
4434 unittests/lookup_name_info-selftests.c,
4435 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4436 unittests/mkdir-recursive-selftests.c,
4437 unittests/observable-selftests.c,
4438 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4439 unittests/parse-connection-spec-selftests.c,
4440 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4441 unittests/scoped_fd-selftests.c,
4442 unittests/scoped_mmap-selftests.c,
4443 unittests/scoped_restore-selftests.c,
4444 unittests/string_view-selftests.c, unittests/style-selftests.c,
4445 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4446 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4447 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4448 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4449 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4450 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4451
5b0e2db4
AB
44522019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4453
4454 * linespec.c (decode_digits_list_mode): Set explicit_line to a
4455 bool value.
4456 (decode_digits_ordinary): Set explicit_line field in sal.
4457 * symtab.c (skip_prologue_sal): Don't skip prologue for a
4458 symtab_and_line that was set on an explicit line number in
4459 assembler code. Do always update the recorded symtab and line if
4460 we do skip the prologue.
4461
0ba852ab
AB
44622019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4463
4464 * breakpoint.c (set_breakpoint_location_function): Remove
4465 explicit_loc parameter.
4466 (momentary_breakpoint_from_master): Update call to
4467 set_breakpoint_location_function.
4468 (add_location_to_breakpoint): Likewise.
4469
b3a7d171
AB
44702019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
4471
4472 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4473 required features based on default bfd type when no specific bfd
4474 is present.
4475
1f6f6e21
PW
44762019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4477
4478 * NEWS: Mention that GDB printf and eval commands can now print
4479 C-style and Ada-style convenience var strings without
4480 calling the inferior.
4481 * printcmd.c (printf_c_string): Locally print GDB internal var
4482 instead of transiting via the inferior.
4483 (printf_wide_c_string): Likewise.
4484
44852019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
4486
4487 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4488
0598af48
TT
44892019-07-04 Tom Tromey <tom@tromey.com>
4490
4491 PR tui/24724:
4492 * tui/tui-winsource.c (tui_clear_source_content): Update.
4493 (tui_source_window_base::set_is_exec_point_at): Fix comment.
4494 (tui_update_breakpoint_info): Update.
4495 (tui_set_exec_info_content): Update.
4496 * tui/tui-source.c (tui_set_source_content_nil): Update.
4497 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4498 has_break.
4499 * tui/tui-data.h (enum tui_bp_flag): New.
4500 (tui_bp_flags): New enum flags type.
4501 (struct tui_source_element) <break_mode>: Change type. Rename
4502 from has_break.
4503 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4504 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
4505 constants.
4506 * tui/tui-winsource.h: Fix comment.
4507
350fab54
AH
45082019-07-04 Alan Hayward <alan.hayward@arm.com>
4509
4510 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4511 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4512 (store_fpregs_to_thread)
4513 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4514 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4515 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4516 (IWMMXT_REGS_SIZE): Add define.
4517 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4518 (fetch_vfp_regs, store_vfp_regs)
4519 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4520 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4521
f0452268
AH
45222019-07-04 Alan Hayward <alan.hayward@arm.com>
4523
4524 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4525 defines.
4526 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4527 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4528 (ARM_INT_REGISTER_SIZE): ...to this.
4529 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4530 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4531 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4532 (arm_linux_collect_gregset, supply_nwfpe_register)
4533 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4534 defines.
4535 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4536 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4537 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4538 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4539 (arm_return_in_memory, arm_store_return_value)
4540 (arm_get_longjmp_target, arm_register_g_packet_guesses)
4541 (arm_record_ld_st_multiple): Likewise.
4542 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4543 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4544
e935475c
AH
45452019-07-04 Alan Hayward <alan.hayward@arm.com>
4546
4547 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4548 AARCH64_DISPLACED_MODIFIED_INSNS.
4549 * aarch64-tdep.c (struct aarch64_displaced_step_data)
4550 (aarch64_displaced_step_copy_insn): Likewise.
4551 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4552 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4553 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4554 ARM_DISPLACED_MODIFIED_INSNS.
4555 * arm-tdep.c (arm_gdbarch_init): Likewise.
4556 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4557 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4558 (struct arm_displaced_step_closure): Use
4559 ARM_DISPLACED_MODIFIED_INSNS.
4560
df0bb381
AH
45612019-07-04 Alan Hayward <alan.hayward@arm.com>
4562
4563 * features/Makefile: Remove unused xml files.
4564 * features/aarch64.xml: Remove.
4565 * features/i386/amd64-avx-avx512-linux.xml: Remove.
4566 * features/i386/amd64-avx-avx512.xml: Remove.
4567 * features/i386/amd64-avx-linux.xml: Remove.
4568 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4569 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4570 * features/i386/amd64-avx-mpx-linux.xml: Remove.
4571 * features/i386/amd64-avx-mpx.xml: Remove.
4572 * features/i386/amd64-avx.xml: Remove.
4573 * features/i386/amd64-linux.xml: Remove.
4574 * features/i386/amd64-mpx-linux.xml: Remove.
4575 * features/i386/amd64-mpx.xml: Remove.
4576 * features/i386/amd64.xml: Remove.
4577 * features/i386/i386-avx-avx512-linux.xml: Remove.
4578 * features/i386/i386-avx-avx512.xml: Remove.
4579 * features/i386/i386-avx-linux.xml: Remove.
4580 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4581 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4582 * features/i386/i386-avx-mpx-linux.xml: Remove.
4583 * features/i386/i386-avx-mpx.xml: Remove.
4584 * features/i386/i386-avx.xml: Remove.
4585 * features/i386/i386-linux.xml: Remove.
4586 * features/i386/i386-mmx-linux.xml: Remove.
4587 * features/i386/i386-mmx.xml: Remove.
4588 * features/i386/i386-mpx-linux.xml: Remove.
4589 * features/i386/i386-mpx.xml: Remove.
4590 * features/i386/i386.xml: Remove.
4591 * features/i386/x32-avx-avx512-linux.xml: Remove.
4592 * features/i386/x32-avx-linux.xml: Remove.
4593 * features/i386/x32-linux.xml: Remove.
4594
edd6266a
AH
45952019-07-04 Alan Hayward <alan.hayward@arm.com>
4596
4597 * regformats/aarch64.dat: Remove.
4598 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4599 * regformats/i386/amd64-avx-linux.dat: Remove.
4600 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4601 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4602 * regformats/i386/amd64-linux.dat: Remove.
4603 * regformats/i386/amd64-mpx-linux.dat: Remove.
4604 * regformats/i386/amd64.dat: Remove.
4605 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4606 * regformats/i386/i386-avx-linux.dat: Remove.
4607 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4608 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4609 * regformats/i386/i386-linux.dat: Remove.
4610 * regformats/i386/i386-mmx-linux.dat: Remove.
4611 * regformats/i386/i386-mpx-linux.dat: Remove.
4612 * regformats/i386/i386.dat: Remove.
4613 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4614 * regformats/i386/x32-avx-linux.dat: Remove.
4615 * regformats/i386/x32-linux.dat: Remove.
4616
2b40fda7
AH
46172019-07-04 Alan Hayward <alan.hayward@arm.com>
4618
4619 * aarch64-tdep.c: Remove xml self tests.
4620 * amd64-linux-tdep.c: Likewise.
4621 * amd64-tdep.c: Likewise.
4622 * i386-linux-tdep.c: Likewise.
4623 * i386-tdep.c: Likewise.
4624
5f4ba3e7
PA
46252019-07-03 Pedro Alves <palves@redhat.com>
4626
4627 PR cli/24732
4628 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4629 (pipe_cmd_option_defs): New.
4630 (make_pipe_cmd_options_def_group): New.
4631 (pipe_command): Use gdb::option::process_options.
4632 (pipe_command_completer): New function.
4633 (_initialize_cli_cmds): Install completer for "pipe" command.
4634
3d9be6f5
PA
46352019-07-03 Pedro Alves <palves@redhat.com>
4636
4637 * cli/cli-option.c (union option_value) <string>: New field.
4638 (struct option_def_and_value): Add ctor, move ctor, dtor and
4639 use DISABLE_COPY_AND_ASSIGN.
4640 (option_def_and_value::clear_value): New.
4641 (parse_option, save_option_value_in_ctx, get_val_type_str)
4642 (add_setshow_cmds_for_options): Handle var_string.
4643 * cli-option.h (union option_def::var_address) <string>: New
4644 field.
4645 (struct string_option_def): New.
4646 * maint-test-options.c (struct test_options_opts): Add default
4647 ctor and use DISABLE_COPY_AND_ASSIGN.
4648 <string_opt>: New field.
4649 (test_options_opts::~test_options_opts): New.
4650 (test_options_opts::dump): Also dump "-string".
4651 (test_options_option_defs): Install "string.
4652
41fc454c
PA
46532019-07-03 Pedro Alves <palves@redhat.com>
4654
4655 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4656 option_value with a null enumeration.
4657 (complete_options): Save the option values in the context.
4658 (save_option_value_in_ctx): New, factored out from ...
4659 (process_options): ... here.
4660 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4661 of the function.
4662 * maint-test-options.c (test_options_opts::dump): New, factored
4663 out from ...
4664 (maintenance_test_options_command_mode): ... here.
4665 (maintenance_test_options_command_completion_result): Delete.
4666 (maintenance_test_options_command_completion_text): Update
4667 comment.
4668 (maintenance_show_test_options_completion_result): Change
4669 prototype. Just print
4670 maintenance_test_options_command_completion_text.
4671 (save_completion_result): New.
4672 (maintenance_test_options_completer_mode): Pass options context to
4673 complete_options, and then save a dump.
4674 (_initialize_maint_test_options): Use add_cmd to install "maint
4675 show test-options-completion-result".
4676
fdbc9870
PA
46772019-07-03 Pedro Alves <palves@redhat.com>
4678
4679 * NEWS (New commands): Mention "with" and "maint with".
4680 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4681 (with_command, with_command_completer): New.
4682 (pipe_command): Adjust to new repeat_previous
4683 interface.
4684 (_initialize_cli_cmds): Install the "with" command and its "w"
4685 alias.
4686 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4687 declarations.
4688 * cli/cli-setshow.c (parse_cli_var_uinteger)
4689 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4690 argument strings for all var_types.
4691 (get_setshow_command_value_string): New, factored out from ...
4692 (do_show_command): ... this.
4693 * cli/cli-setshow.h: Include <string>.
4694 (get_setshow_command_value_string): Declare.
4695 * command.h (repeat_previous): Now returns const char *. Adjust
4696 comment.
4697 * maint.c: Include "cli/cli-cmds.h".
4698 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4699 (_initialize_maint_cmds): Register the "maintenance with" command.
4700 * top.c (repeat_previous): Move bits from pipe_command here:
4701 Return the saved command line, if any; error out if there's no
4702 command to relaunch.
4703
c6ac8931
PA
47042019-07-03 Pedro Alves <palves@redhat.com>
4705
4706 * NEWS (New commands): Mention "maint set/show test-settings"
4707 instead of "maint test-settings".
4708 * maint-test-settings.c (maintenance_test_settings_list): Delete.
4709 (maintenance_test_settings_set_list): Rename to ...
4710 (maintenance_set_test_settings_list): ... this.
4711 (maintenance_test_settings_show_list): Rename to ...
4712 (maintenance_show_test_settings_list): ... this.
4713 (maintenance_test_settings_cmd): Delete.
4714 (maintenance_test_settings_set_cmd): ...
4715 (maintenance_set_test_settings_cmd): ... this.
4716 (maintenance_test_settings_show_cmd): ...
4717 (maintenance_show_test_settings_cmd): ... this.
4718 (maintenance_test_settings_show_value_cmd):
4719 (maintenance_show_test_settings_value_cmd): ... this.
4720 (_initialize_maint_test_settings): No longer install the "maint
4721 test-settings" prefix command. Rename "maint test-settings set"
4722 to "maint set test-settings", and "maint test-settings show" to
4723 "maint show test-settings". Adjust all subcommands.
4724
d1fcf2fd
PA
47252019-07-03 Pedro Alves <palves@redhat.com>
4726
4727 * maint-test-settings.c: Fix file's intro comment. Replace all
4728 references to "test-options" with references to "test-settings",
4729 in comments.
4730
970f9d09
PA
47312019-07-03 Pedro Alves <palves@redhat.com>
4732
4733 * maint-test-settings.c (maintenance_test_settings_xxx)
4734 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4735 New.
4736 (maintenance_test_settings_enums): Use them.
4737 (maintenance_test_settings_enum): Default to
4738 maintenance_test_settings_xxx.
4739 (_initialize_maint_test_settings): Initialize
4740 MAINTENANCE_TEST_SETTINGS_FILENAME.
4741
f3869b1a
SM
47422019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4743
4744 * breakpoint.h (remove_breakpoints_inf): Change return type to
4745 void, move function documentation here.
4746 * breakpoint.c (remove_breakpoints_inf): Change return type to
4747 void, move function documentation to header.
4748
54d66006
PA
47492019-07-02 Pedro Alves <palves@redhat.com>
4750
4751 * NEWS (Completion improvements): Mention "info threads".
4752 * thread.c (struct info_threads_opts, info_threads_option_defs)
4753 (make_info_threads_options_def_group): New.
4754 (info_threads_command): Use gdb::option::process_options.
4755 (info_threads_command_completer): New.
4756 (_initialize_thread): Use gdb::option::build_help to build the
4757 help text for "info threads".
4758
854f6088
SM
47592019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
4760
4761 * defs.h (generic_load): Move from here...
4762 * symfile.h (generic_load): ... to here. Rename name parameter
4763 to args.
4764 * symfile.c (generic_load): Add comment.
4765
54ee4252
TT
47662019-07-01 Tom Tromey <tromey@adacore.com>
4767
4768 * dwarf2read.c
4769 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4770 declaration of without_params. Fix formatting.
4771
65392b3e
TT
47722019-07-01 Tom Tromey <tromey@adacore.com>
4773
4774 * ada-exp.y (find_primitive_type): Update.
4775 * ada-lang.h (ada_lookup_symbol): Update.
4776 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4777 parameter.
4778 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4779
7d7571f0
SDJ
47802019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4781
4782 PR breakpoints/24541
4783 * gdbarch.c: Regenerate.
4784 * gdbarch.h: Regenerate.
4785 * gdbarch.sh: Add 'stap_adjust_register'.
4786 * i386-tdep.c: Include '<unordered_set>'.
4787 (i386_stap_adjust_register): New function.
4788 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4789 * stap-probe.c (stap_parse_register_operand): Call
4790 'gdbarch_stap_adjust_register'.
4791
5af5392a
SDJ
47922019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
4793
4794 PR python/24742
4795 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4796 * python/python.c (do_start_initialization): Use 'xmalloc'
4797 instead of 'PyMem_Malloc'.
4798
10d06d82
TT
47992019-06-28 Tom Tromey <tromey@adacore.com>
4800
4801 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4802 for Ada.
4803
1b7f24cd
TT
48042019-06-27 Tom Tromey <tromey@adacore.com>
4805
4806 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
4807 objfile_key.
4808 (arm_find_mapping_symbol, arm_record_special_symbol)
4809 (_initialize_arm_tdep): Update.
4810 (arm_objfile_data_free): Remove.
4811
3d507ff2
TT
48122019-06-27 Tom Tromey <tromey@adacore.com>
4813
4814 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4815 to cp_print_static_field.
4816
762c164d
TT
48172019-06-26 Tom Tromey <tromey@adacore.com>
4818
4819 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4820 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4821 declare.
4822
aa2f9bcf
AH
48232019-06-26 Alan Hayward <alan.hayward@arm.com>
4824
4825 * features/aarch64-core.c (create_feature_aarch64_core):
4826 Regenerate.
4827 * features/aarch64-core.xml: Add cpsr flags.
4828
3426ae57
AH
48292019-06-26 Alan Hayward <alan.hayward@arm.com>
4830
4831 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4832 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4833
4838e44c
SM
48342019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4835
4836 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4837 field.
4838 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4839 use.
4840 (arm_record_special_symbol): Don't insert new symbol in sorted
4841 position, push it at the end.
4842
54cc7474
SM
48432019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
4844
4845 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4846 (arm_mapping_symbol_s): Remove.
4847 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4848 (arm_mapping_symbol_vec): New typedef.
4849 (struct arm_per_objfile): Add constructor.
4850 <section_maps>: Change type to
4851 std::unique_ptr<arm_mapping_symbol_vec[]>.
4852 (arm_compare_mapping_symbols): Remove.
4853 (arm_find_mapping_symbol): Adjust to section_maps type change.
4854 (arm_objfile_data_free): Call delete on arm_per_objfile.
4855 (arm_record_special_symbol): Adjust to section_maps type change.
4856 Allocate arm_per_objfile with new.
4857
b65b566c
PW
48582019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4859
4860 * cli/cli-cmds.c (alias_command): Compare the alias prefix
4861 with the command prefix.
4862
c2fc64f5
TT
48632019-06-25 Tom Tromey <tom@tromey.com>
4864
4865 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4866 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4867
fb54fa76
TT
48682019-06-25 Tom Tromey <tom@tromey.com>
4869
4870 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4871 type.
4872 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4873 protected.
4874
f7952c57
TT
48752019-06-25 Tom Tromey <tom@tromey.com>
4876
4877 * tui/tui-winsource.c
4878 (tui_source_window_base::set_is_exec_point_at): Add check against
4879 LOA_ADDRESS.
4880
17568d78
TT
48812019-06-25 Tom Tromey <tom@tromey.com>
4882
4883 * tui/tui-source.c (tui_set_source_content): Don't check before
4884 xfree.
4885 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4886
53e7cdba
TT
48872019-06-25 Tom Tromey <tom@tromey.com>
4888
4889 * tui/tui-winsource.h (tui_update_source_window_as_is)
4890 (tui_alloc_source_buffer, tui_line_is_displayed)
4891 (tui_addr_is_displayed): Change type of win_info.
4892 * tui/tui-winsource.c (tui_update_source_window_as_is)
4893 (tui_clear_source_content, tui_show_source_line)
4894 (tui_show_source_content, tui_source_window_base::refill)
4895 (tui_source_window_base::set_is_exec_point_at)
4896 (tui_source_window_base::set_is_exec_point_at)
4897 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4898 (tui_alloc_source_buffer, tui_line_is_displayed)
4899 (tui_addr_is_displayed): Change type of win_info. Update.
4900 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4901 (tui_source_window_base::do_make_visible_with_new_height):
4902 Update.
4903 * tui/tui-source.c (tui_set_source_content)
4904 (tui_set_source_content_nil)
4905 (tui_source_window::do_scroll_vertical): Update.
4906 * tui/tui-layout.c (show_layout): Update.
4907 * tui/tui-disasm.c (tui_set_disassem_content)
4908 (tui_disasm_window::do_scroll_vertical): Update.
4909 * tui/tui-data.h (tui_win_content): Remove.
4910 (struct tui_gen_win_info) <content, content_size>: Remove.
4911 (struct tui_source_element): Add initializers and destructor.
4912 (union tui_which_element, struct tui_win_element): Remove.
4913 (struct tui_source_window_base) <content>: New field.
4914 (struct tui_data_window): Remove destructor.
4915 (tui_alloc_content, tui_free_win_content)
4916 (tui_free_all_source_wins_content): Don't declare.
4917 * tui/tui-data.c (tui_initialize_static_data): Update.
4918 (init_content_element, tui_alloc_content): Remove.
4919 (~tui_gen_win_info): Update.
4920 (~tui_data_window, tui_free_all_source_wins_content)
4921 (tui_free_win_content, free_content, free_content_elements):
4922 Remove.
4923
7908abbf
TT
49242019-06-25 Tom Tromey <tom@tromey.com>
4925
4926 * tui/tui-winsource.h (tui_clear_source_content)
4927 (tui_erase_source_content, tui_show_source_content): Change type
4928 of win_info.
4929 * tui/tui-winsource.c (tui_clear_source_content)
4930 (tui_erase_source_content, tui_show_source_content): Change type
4931 of win_info.
4932 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4933 * tui/tui-source.h (tui_set_source_content_nil): Change type of
4934 win_info.
4935 * tui/tui-source.c (tui_set_source_content_nil): Change type of
4936 win_info.
4937 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4938
02c28df0
TT
49392019-06-25 Tom Tromey <tom@tromey.com>
4940
4941 * tui/tui-winsource.c (tui_clear_source_content)
4942 (tui_source_window_base::set_is_exec_point_at): Update.
4943 * tui/tui-source.c (tui_set_source_content_nil): Update.
4944 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4945 a bool.
4946 * tui/tui-data.c (init_content_element): Update.
4947
6658b1bf
TT
49482019-06-25 Tom Tromey <tom@tromey.com>
4949
4950 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4951 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4952 * tui/tui-layout.c (init_and_make_win): Update.
4953 * tui/tui.h (enum tui_win_type): Update.
4954 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4955 tui_win_is_auxillary.
4956 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4957 tui_win_is_auxillary.
4958
21e1c91e
TT
49592019-06-25 Tom Tromey <tom@tromey.com>
4960
4961 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4962 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4963 (tui_delete_data_content_windows, tui_display_all_data)
4964 (tui_data_window::do_scroll_vertical, tui_display_data_from):
4965 Update.
4966 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4967 * tui/tui-regs.c (tui_last_regs_line_no)
4968 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4969 (tui_show_registers): Update.
4970 (tui_show_register_group): Return void. Update.
4971 (tui_display_registers_from, tui_display_reg_element_at_line)
4972 (tui_display_registers_from_line, tui_check_register_values):
4973 Update.
4974 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4975 member.
4976 (struct tui_data_window) <regs_content>: Now a std::vector.
4977 <regs_content_count>: Remove.
4978 (tui_add_content_elements, tui_free_data_content): Don't declare.
4979 * tui/tui-data.c (tui_data_window::clear_detail): Update.
4980 (init_content_element): Remove DATA_WIN case. Add assert.
4981 (tui_add_content_elements): Remove.
4982 (tui_data_window): Update.
4983 (tui_free_data_content): Remove.
4984 (free_content_elements): Remove DATA_WIN case.
4985
115ac53b
TT
49862019-06-25 Tom Tromey <tom@tromey.com>
4987
4988 * tui/tui-data.c (tui_data_item_window): Update.
4989 * tui/tui-windata.h (tui_check_data_values): Don't declare.
4990 * tui/tui-windata.c (tui_display_all_data)
4991 (tui_display_data_from_line): Update.
4992 (tui_check_data_values): Remove.
4993 * tui/tui-regs.c (tui_show_register_group)
4994 (tui_display_reg_element_at_line): Update.
4995 * tui/tui-hooks.c (tui_register_changed)
4996 (tui_refresh_frame_and_register_information): Call
4997 tui_check_register_values.
4998 * tui/tui-data.h (struct tui_data_window) <data_content,
4999 data_content_count, data_type>: Remove.
5000 (enum tui_data_type): Remove.
5001
5002 * tui/tui-data.c (tui_data_window::clear_detail)
5003 (~tui_data_window): Update.
5004
eaf9738b
TT
50052019-06-25 Tom Tromey <tom@tromey.com>
5006
5007 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5008 declare.
5009 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5010 Rename from tui_first_data_item_displayed. Update.
5011 (tui_data_window::refresh_all)
5012 (tui_data_window::do_scroll_vertical): Update.
5013 * tui/tui-data.h (struct tui_data_window)
5014 <first_data_item_displayed>: Declare new method.
5015
31ca4723
TT
50162019-06-25 Tom Tromey <tom@tromey.com>
5017
5018 * tui/tui-data.h (tui_init_generic_part): Don't declare.
5019 * tui/tui-data.c (tui_init_generic_part): Remove, moving
5020 contents...
5021 (tui_initialize_static_data): ...here.
5022
41bcff7f
TT
50232019-06-25 Tom Tromey <tom@tromey.com>
5024
5025 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5026 (tui_display_registers_from, tui_check_register_values): Update.
5027 (tui_display_register): Remove win_info parameter; update.
5028 (tui_get_register): Change type of parameters.
5029 * tui/tui-data.h (struct tui_data_element): Remove.
5030 (union tui_which_element) <data>: Remove.
5031 <data_window>: Change type.
5032 (struct tui_data_item_window): New.
5033 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5034 case. Add assert.
5035 (~tui_data_item_window): New destructor.
5036 (free_content_elements): Remove DATA_ITEM_WIN case.
5037
d2802c33
TT
50382019-06-25 Tom Tromey <tom@tromey.com>
5039
5040 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5041 Remove.
5042
dd835f8b
TT
50432019-06-25 Tom Tromey <tom@tromey.com>
5044
5045 * tui/tui-data.h (struct tui_command_element): Remove.
5046 (union tui_which_element) <command>: Remove.
5047 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
5048 assert.
5049 (free_content_elements): Remove CMD_WIN case.
5050
bd7db367
TT
50512019-06-25 Tom Tromey <tom@tromey.com>
5052
5053 * tui/tui-layout.c (tui_set_layout): Update.
5054 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5055 * tui/tui-data.c (layout_def): Update.
5056
3add462f
TT
50572019-06-25 Tom Tromey <tom@tromey.com>
5058
5059 * tui/tui-wingeneral.c (tui_refresh_all): Update.
5060 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5061 (tui_source_window_base::set_new_height): Update.
5062 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5063 Update.
5064 (tui_set_locator_fullname, tui_set_locator_info)
5065 (tui_show_frame_info): Update.
5066 * tui/tui-source.c (tui_set_source_content)
5067 (tui_source_is_displayed): Update.
5068 * tui/tui-layout.c (show_source_disasm_command, show_data)
5069 (show_source_or_disasm_and_command): Update.
5070 * tui/tui-disasm.c (tui_set_disassem_content)
5071 (tui_get_begin_asm_address): Update.
5072 * tui/tui-data.h (struct tui_locator_element): Remove.
5073 (union tui_which_element) <locator>: Remove.
5074 (struct tui_locator_window): New.
5075 (tui_locator_win_info_ptr): Change return type.
5076 * tui/tui-data.c (_locator): Change type.
5077 (tui_locator_win_info_ptr): Change return type.
5078 (init_content_element): Remove LOCATOR_WIN case. Add assert.
5079 (tui_alloc_content): Add assert.
5080
489e9d8b
TT
50812019-06-25 Tom Tromey <tom@tromey.com>
5082
5083 * tui/tui-winsource.c
5084 (tui_exec_info_window::maybe_allocate_content): New method.
5085 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5086 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5087 (make_source_or_disasm_window): Add cast.
5088 * tui/tui-data.h (union tui_which_element) <simple_string>:
5089 Remove.
5090 (struct tui_source_info): New.
5091 (struct tui_source_window_base) <execution_info>: Change type.
5092 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5093 case, and add assert.
5094 (tui_alloc_content): Add assert.
5095
c3fabb7d
TT
50962019-06-25 Tom Tromey <tom@tromey.com>
5097
5098 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5099 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5100 * tui/tui-data.c (tui_alloc_win_info): Remove.
5101
bbc228ee
TT
51022019-06-25 Tom Tromey <tom@tromey.com>
5103
5104 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5105 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5106 can_highlight.
5107
5fcee43a
TT
51082019-06-25 Tom Tromey <tom@tromey.com>
5109
5110 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5111 make_visible_with_new_height method.
5112 (tui_win_info::make_visible_with_new_height): New method.
5113 (tui_source_window_base::do_make_visible_with_new_height)
5114 (tui_data_window::do_make_visible_with_new_height)
5115 (tui_cmd_window::do_make_visible_with_new_height): New methods.
5116 (make_visible_with_new_height): Remove.
5117 (tui_resize_all, tui_adjust_win_heights): Use
5118 make_visible_with_new_height method.
5119 * tui/tui-data.h (struct tui_win_info)
5120 <do_make_visible_with_new_height, make_visible_with_new_height>:
5121 New methods.
5122 (struct tui_source_window_base, struct tui_data_window)
5123 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5124 methods.
5125
d83f1fe6
TT
51262019-06-25 Tom Tromey <tom@tromey.com>
5127
5128 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5129 method.
5130 (update_tab_width): Call update_tab_width method.
5131 * tui/tui-data.h (struct tui_win_info)
5132 (struct tui_source_window_base) <update_tab_width>: New methods.
5133
17374de4
TT
51342019-06-25 Tom Tromey <tom@tromey.com>
5135
5136 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5137 parameter.
5138 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5139 parameter.
5140 (tui_gen_win_info::make_visible): Update.
5141 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5142 parameter.
5143 * tui/tui-data.h (enum tui_box): New enum.
5144 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5145
f936bca2
TT
51462019-06-25 Tom Tromey <tom@tromey.com>
5147
5148 * tui/tui-layout.c (make_source_or_disasm_window): Always use
5149 init_and_make_win for EXEC_INFO_WIN.
5150 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5151 longer inline.
5152 (struct tui_win_info) <~tui_win_info>: Inline.
5153 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5154 Don't declare.
5155 * tui/tui-data.c (source_win, disasm_win): Remove globals.
5156 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5157 Remove.
5158 (tui_initialize_static_data): Update.
5159 (~tui_gen_win_info): Handle more cleanup here.
5160 (~tui_source_window_base): Delete "execution_info".
5161 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5162
d6ba6a11
TT
51632019-06-25 Tom Tromey <tom@tromey.com>
5164
5165 * tui/tui-layout.c (make_command_window): Don't set
5166 can_highlight.
5167 (show_source_disasm_command): Call the reset method.
5168 (show_data): Don't set can_highlight. Call the reset method.
5169 (tui_gen_win_info::reset): Rename from init_gen_win_info
5170 (init_and_make_win): Simplify. Return tui_gen_win_info.
5171 (show_source_or_disasm_and_command): Call the reset method.
5172 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5173 (struct tui_cmd_window): Set can_highlight.
5174
48a3bd16
TT
51752019-06-25 Tom Tromey <tom@tromey.com>
5176
5177 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5178 from make_visible.
5179 (tui_make_visible, tui_make_invisible): Rewrite.
5180 (tui_win_info::make_visible): Remove.
5181 (tui_source_window_base::make_visible): Update.
5182 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5183 method. Moved from...
5184 (struct tui_win_info) <make_visible>: ...here.
5185
c3bd716f
TT
51862019-06-25 Tom Tromey <tom@tromey.com>
5187
5188 * tui/tui-winsource.c
5189 (tui_source_window_base::do_scroll_horizontal): Remove direction
5190 parameter.
5191 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5192 direction parameter.
5193 * tui/tui-win.c (tui_win_info::forward_scroll)
5194 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5195 (tui_win_info::right_scroll): Update.
5196 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5197 direction parameter.
5198 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5199 direction parameter.
5200 * tui/tui-data.h (enum tui_scroll_direction): Remove.
5201 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5202 Remove direction parameter.
5203 (struct tui_source_window_base, struct tui_source_window)
5204 (struct tui_disasm_window, struct tui_data_window)
5205 (struct tui_cmd_window): Update.
5206
21c32dca
TT
52072019-06-25 Tom Tromey <tom@tromey.com>
5208
5209 * tui/tui-winsource.h (tui_set_exec_info_content)
5210 (tui_show_exec_info_content, tui_erase_exec_info_content)
5211 (tui_clear_exec_info_content, tui_update_exec_info): Change
5212 argument to tui_source_window_base.
5213 * tui/tui-winsource.c (tui_set_exec_info_content)
5214 (tui_show_exec_info_content, tui_erase_exec_info_content)
5215 (tui_clear_exec_info_content, tui_update_exec_info): Change
5216 argument to tui_source_window_base.
5217
73fbdc65
TT
52182019-06-25 Tom Tromey <tom@tromey.com>
5219
5220 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5221 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5222
33325343
TT
52232019-06-25 Tom Tromey <tom@tromey.com>
5224
5225 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5226 check.
5227
29d2c474
TT
52282019-06-25 Tom Tromey <tom@tromey.com>
5229
5230 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5231 type to void.
5232 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5233 type to void.
5234 * tui/tui-source.c (tui_set_source_content): Update.
5235 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5236
152f3f4b
TT
52372019-06-25 Tom Tromey <tom@tromey.com>
5238
5239 * tui/tui-win.c (window_name_completer, tui_set_focus)
5240 (tui_all_windows_info): Use name method.
5241 * tui/tui-data.h (struct tui_gen_win_info)
5242 (struct tui_source_window, struct tui_disasm_window)
5243 (struct tui_data_window, struct tui_cmd_window) <name>: New
5244 method.
5245 (tui_win_name): Don't declare.
5246 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5247 (tui_win_name): Remove.
5248
be4da588
TT
52492019-06-25 Tom Tromey <tom@tromey.com>
5250
5251 * tui/tui-winsource.h (tui_update_source_window)
5252 (tui_update_source_window_as_is): Change parameter type.
5253 * tui/tui-winsource.c (tui_update_source_window): Change win_info
5254 to be a tui_source_window_base.
5255 (tui_update_source_window_as_is): Likewise.
5256 * tui/tui-win.c (make_visible_with_new_height): Update.
5257
5b81daba
TT
52582019-06-25 Tom Tromey <tom@tromey.com>
5259
5260 * tui/tui-winsource.c (tui_erase_source_content)
5261 (tui_show_source_content, tui_show_exec_info_content)
5262 (tui_erase_exec_info_content): Use refresh_window method.
5263 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5264 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5265 from tui_refresh_win.
5266 (tui_data_window::refresh_window): New method.
5267 (tui_win_info::refresh, tui_source_window_base::refresh)
5268 (tui_refresh_all): Use refresh_window method.
5269 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5270 method.
5271 * tui/tui-regs.c (tui_display_register): Call refresh_window
5272 method.
5273 * tui/tui-layout.c (show_source_disasm_command)
5274 (show_source_or_disasm_and_command): Call refresh_window method.
5275 * tui/tui-data.h (struct tui_gen_win_info)
5276 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5277 New method.
5278
cb2ce893
TT
52792019-06-25 Tom Tromey <tom@tromey.com>
5280
5281 * tui/tui.c (tui_rl_other_window, tui_enable)
5282 (tui_is_window_visible, tui_get_command_dimension): Update.
5283 * tui/tui-winsource.c (tui_update_source_window_as_is)
5284 (tui_clear_source_content, tui_erase_source_content)
5285 (tui_show_source_line, tui_source_window_base::refill)
5286 (tui_source_window_base::do_scroll_horizontal)
5287 (tui_source_window_base::set_is_exec_point_at)
5288 (tui_update_breakpoint_info, tui_set_exec_info_content)
5289 (tui_alloc_source_buffer, tui_line_is_displayed)
5290 (tui_addr_is_displayed): Update.
5291 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5292 (tui_check_and_display_highlight_if_needed)
5293 (tui_win_info::make_visible, tui_win_info::refresh)
5294 (tui_refresh_all): Update.
5295 * tui/tui-windata.c (tui_first_data_item_displayed)
5296 (tui_delete_data_content_windows, tui_erase_data_content)
5297 (tui_display_all_data, tui_data_window::refresh_all)
5298 (tui_check_data_values): Update.
5299 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5300 (tui_set_win_focus_to, tui_win_info::forward_scroll)
5301 (tui_win_info::backward_scroll, tui_refresh_all_win)
5302 (tui_resize_all, tui_set_focus, tui_all_windows_info)
5303 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5304 (tui_source_window_base::set_new_height)
5305 (tui_data_window::set_new_height)
5306 (make_invisible_and_set_new_height)
5307 (make_visible_with_new_height, new_height_ok)
5308 (parse_scrolling_args): Update.
5309 * tui/tui-stack.c (tui_show_frame_info): Update.
5310 * tui/tui-source.c (tui_set_source_content)
5311 (tui_set_source_content_nil, tui_source_is_displayed)
5312 (tui_source_window::do_scroll_vertical): Update.
5313 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5314 (tui_display_registers_from, tui_display_reg_element_at_line)
5315 (tui_check_register_values, tui_reg_command): Update.
5316 * tui/tui-layout.c (tui_default_win_height)
5317 (show_source_disasm_command, show_data, init_and_make_win)
5318 (show_source_or_disasm_and_command): Update.
5319 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5320 (tui_redisplay_readline, tui_mld_flush)
5321 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5322 (tui_getc): Update.
5323 * tui/tui-disasm.c (tui_set_disassem_content)
5324 (tui_disasm_window::do_scroll_vertical): Update.
5325 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5326 Now virtual.
5327 (struct tui_win_info): Derive from tui_gen_win_info.
5328 <~tui_win_info>: Mark as override.
5329 <generic>: Remove member.
5330 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5331 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5332 (~tui_data_window, ~tui_win_info)
5333 (tui_free_all_source_wins_content): Update.
5334 * tui/tui-command.c (tui_refresh_cmd_win): Update.
5335
ab313b35
TT
53362019-06-25 Tom Tromey <tom@tromey.com>
5337
5338 * tui/tui-layout.c (init_and_make_win): Use new.
5339 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5340 destructor, initializers.
5341 (tui_alloc_generic_win_info): Don't declare.
5342 * tui/tui-data.c (_locator): Add argument to constructor.
5343 (source_win, disasm_win): New globals.
5344 (exec_info): Remove.
5345 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5346 Update.
5347 (tui_alloc_generic_win_info): Remove.
5348 (init_content_element): Use new.
5349 (tui_win_info::tui_win_info): Update.
5350 (free_content_elements) <case DATA_WIN>: Use delete.
5351
dc2c33e4
TT
53522019-06-25 Tom Tromey <tom@tromey.com>
5353
5354 * tui/tui-wingeneral.c (tui_refresh_win): Update.
5355 * tui/tui-windata.c (tui_first_data_item_displayed)
5356 (tui_delete_data_content_windows): Update.
5357 * tui/tui-win.c (tui_data_window::set_new_height): Update.
5358 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5359 (tui_display_registers_from, tui_check_register_values): Update.
5360 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5361 pointer.
5362 * tui/tui-data.c (init_content_element): Update. Allocate the new
5363 window.
5364 (tui_free_data_content): Update.
5365 (free_content_elements) <case DATA_WIN>: Free the window.
5366
214a5cbe
TT
53672019-06-25 Tom Tromey <tom@tromey.com>
5368
5369 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5370 Update.
5371 * tui/tui-layout.c (make_command_window)
5372 (show_source_disasm_command, show_data, init_and_make_win)
5373 (show_source_or_disasm_and_command): Update.
5374 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5375 method.
5376 <can_highight, is_highlighted>: Now bool.
5377 (tui_set_win_highlight): Don't declare.
5378 * tui/tui-data.c (tui_set_win_highlight): Remove.
5379
8e2daf15
TT
53802019-06-25 Tom Tromey <tom@tromey.com>
5381
5382 * tui/tui-wingeneral.c (make_visible): Remove check of window
5383 type.
5384
8903bd8a
TT
53852019-06-25 Tom Tromey <tom@tromey.com>
5386
5387 * tui/tui-win.c (tui_win_info::max_height)
5388 (tui_cmd_window::max_height): New methods.
5389 (new_height_ok): Call max_height.
5390 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5391 <max_height>: New method.
5392
3f02ce1e
TT
53932019-06-25 Tom Tromey <tom@tromey.com>
5394
5395 * tui/tui-win.c (tui_source_window_base::set_new_height)
5396 (tui_data_window::set_new_height): New methods.
5397 (make_invisible_and_set_new_height): Call set_new_height method.
5398 * tui/tui-data.h (struct tui_win_info)
5399 (struct tui_source_window_base, struct tui_data_window)
5400 <set_new_height>: New method.
5401
1825f487
TT
54022019-06-25 Tom Tromey <tom@tromey.com>
5403
5404 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5405 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5406 tui_refresh_data_win.
5407 * tui/tui-win.c (tui_source_window_base::refresh_all): New
5408 method.
5409 (tui_refresh_all_win): Call the refresh_all method.
5410 (tui_set_focus): Likewise.
5411 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5412 (struct tui_source_window_base, struct tui_data_window) <refresh>:
5413 Likewise.
5414
ad54d15b
TT
54152019-06-25 Tom Tromey <tom@tromey.com>
5416
5417 * tui/tui-winsource.h (tui_refill_source_window)
5418 (tui_set_is_exec_point_at): Don't declare.
5419 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5420 (tui_source_window_base::refill): Rename from
5421 tui_refill_source_window.
5422 (tui_source_window_base::do_scroll_horizontal): Update.
5423 (tui_source_window_base::set_is_exec_point_at): Rename from
5424 tui_set_is_exec_point_at.
5425 (tui_update_all_breakpoint_info): Update.
5426 * tui/tui-stack.c (tui_show_frame_info): Update.
5427 * tui/tui-layout.c (show_data): Add cast.
5428 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5429 * tui/tui-data.h (struct tui_source_window_base) <refill,
5430 set_is_exec_point_at>: New methods.
5431 (tui_source_windows, tui_add_to_source_windows): Update types.
5432 (tui_add_to_source_windows): Remove redundant declaration.
5433 * tui/tui-data.c (source_windows): Store tui_source_window_base.
5434 (tui_source_windows): Change return type.
5435 (tui_clear_source_windows_detail): Update.
5436 (tui_add_to_source_windows): Change type of parameter.
5437 (tui_free_all_source_wins_content): Update.
5438
2042b506
TT
54392019-06-25 Tom Tromey <tom@tromey.com>
5440
5441 * tui/tui-wingeneral.c (tui_win_info::refresh)
5442 (tui_source_window_base::refresh): New methods.
5443 (tui_refresh_all): Call the refresh method.
5444 * tui/tui-data.h (struct tui_win_info)
5445 (struct tui_source_window_base) <refresh>: New method.
5446
56122977
TT
54472019-06-25 Tom Tromey <tom@tromey.com>
5448
5449 * tui/tui.h (tui_is_window_visible): Return bool.
5450 * tui/tui.c (tui_is_window_visible): Return bool.
5451 * tui/tui-wingeneral.c (tui_make_window, make_visible)
5452 (tui_make_visible, tui_make_invisible)
5453 (tui_win_info::make_visible)
5454 (tui_source_window_base::make_visible, make_all_visible)
5455 (tui_make_all_visible, tui_make_all_invisible): Update.
5456 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5457 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5458 bool.
5459 (struct tui_win_info, struct tui_source_window_base)
5460 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5461 * tui/tui-data.c (tui_init_generic_part): Update.
5462
cda37efb
TT
54632019-06-25 Tom Tromey <tom@tromey.com>
5464
5465 * tui/tui-wingeneral.c (tui_win_info::make_visible)
5466 (tui_source_window_base::make_visible): New methods.
5467 (make_all_visible): Make method call.
5468 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5469 (struct tui_source_window_base, struct tui_cmd_window): Override
5470 make_visible.
5471 (tui_win_is_source_type): Don't declare.
5472 * tui/tui-data.c (tui_win_is_source_type): Remove.
5473
6a0ee02c
TT
54742019-06-25 Tom Tromey <tom@tromey.com>
5475
5476 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5477 NULL check.
5478
63901aec
TT
54792019-06-25 Tom Tromey <tom@tromey.com>
5480
5481 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5482 Inline constructor. Add initializers for members.
5483 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5484 constructors; now inline in class.
5485
ceb13a13
TT
54862019-06-25 Tom Tromey <tom@tromey.com>
5487
5488 * tui/tui-regs.c (tui_show_registers): Update.
5489 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5490 bool.
5491 * tui/tui-data.c (tui_data_window::clear_detail)
5492 (tui_data_window): Update.
5493
238eb706
TT
54942019-06-25 Tom Tromey <tom@tromey.com>
5495
5496 * tui/tui-windata.c (tui_display_all_data)
5497 (tui_display_data_from_line, tui_display_data_from)
5498 (tui_check_data_values, tui_data_window::do_scroll_vertical):
5499 Update.
5500 * tui/tui-regs.c (tui_last_regs_line_no)
5501 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5502 (tui_show_registers, tui_show_register_group)
5503 (tui_display_registers_from, tui_display_reg_element_at_line)
5504 (tui_display_registers_from_line, tui_check_register_values)
5505 (tui_reg_next, tui_reg_prev): Update.
5506 * tui/tui-layout.c (tui_set_layout, show_data): Update.
5507 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
5508 tui_data_window.
5509 (struct tui_win_info) <detail>: Remove. Add new fields from
5510 tui_data_info.
5511 (TUI_DATA_WIN): Add cast.
5512 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5513 (~tui_data_window): Simplify.
5514
81491aa0
TT
55152019-06-25 Tom Tromey <tom@tromey.com>
5516
5517 * tui/tui-layout.c (show_source_disasm_command)
5518 (show_source_or_disasm_and_command): Update.
5519 * tui/tui-io.c (update_cmdwin_start_line)
5520 (tui_redisplay_readline): Update.
5521 * tui/tui-data.h (struct tui_command_info): Remove.
5522 (struct tui_win_info) <detail>: Remove command_info member.
5523 (struct tui_data_window) <start_line>: New member, from
5524 tui_command_info.
5525 (TUI_CMD_WIN): Add casts.
5526
e6e41501
TT
55272019-06-25 Tom Tromey <tom@tromey.com>
5528
5529 * tui/tui-winsource.c (tui_update_source_window)
5530 (tui_refill_source_window)
5531 (tui_source_window_base::do_scroll_horizontal)
5532 (tui_update_breakpoint_info, tui_set_exec_info_content)
5533 (tui_show_exec_info_content, tui_erase_exec_info_content)
5534 (tui_clear_exec_info_content): Update.
5535 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5536 Update.
5537 * tui/tui-win.c (make_invisible_and_set_new_height)
5538 (make_visible_with_new_height): Update.
5539 * tui/tui-source.c (tui_set_source_content)
5540 (tui_show_symtab_source): Update.
5541 * tui/tui-layout.c (extract_display_start_addr)
5542 (show_source_disasm_command, show_data)
5543 (make_source_or_disasm_window)
5544 (show_source_or_disasm_and_command): Update.
5545 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5546 (tui_disasm_window::do_scroll_vertical): Remove shadowing
5547 "gdbarch".
5548 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
5549 to tui_source_window_base.
5550 (struct tui_win_info) <detail>: Remove source_info member.
5551 (struct tui_source_window_base) <has_locator>: Inline.
5552 Move contents from tui_source_info; rename has_locator member to
5553 m_has_locator.
5554 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5555 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5556 header file.
5557 (tui_source_window_base::clear_detail, ~tui_source_window_base):
5558 Simplify.
5559 (tui_free_all_source_wins_content): Cast to
5560 tui_source_window_base.
5561
44f0e208
TT
55622019-06-25 Tom Tromey <tom@tromey.com>
5563
5564 * tui/tui-win.c (make_invisible_and_set_new_height)
5565 (make_visible_with_new_height): Call has_locator method.
5566 * tui/tui-layout.c (show_source_disasm_command, show_data)
5567 (show_source_or_disasm_and_command): Update for bool change.
5568 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5569 (tui_win_info) <has_locator>: New method.
5570 (struct tui_source_window_base) <has_locator>: New method.
5571 (tui_win_has_locator): Don't declare.
5572 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5573 from tui_win_has_locator.
5574 (tui_source_window_base): Use false, not FALSE.
5575
7778b912
TT
55762019-06-25 Tom Tromey <tom@tromey.com>
5577
5578 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5579 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5580 clear_detail method directly.
5581 (tui_clear_win_detail): Remove.
5582
f83d391c
TT
55832019-06-25 Tom Tromey <tom@tromey.com>
5584
5585 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5586 "this", not TUI_DISASM_WIN.
5587
13446e05
TT
55882019-06-25 Tom Tromey <tom@tromey.com>
5589
5590 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
5591 declare.
5592 * tui/tui-winsource.c
5593 (tui_source_window_base::do_scroll_horizontal): Rename from
5594 tui_horizontal_source_scroll.
5595 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5596 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5597 from tui_vertical_data_scroll.
5598 * tui/tui-win.h (tui_scroll): Don't declare.
5599 * tui/tui-win.c (tui_win_info::forward_scroll)
5600 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5601 (tui_win_info::right_scroll): Rename and update.
5602 (tui_scroll_forward_command, tui_scroll_backward_command)
5603 (tui_scroll_left_command, tui_scroll_right_command): Update.
5604 (tui_scroll): Remove.
5605 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5606 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5607 from tui_vertical_source_scroll.
5608 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5609 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5610 from tui_vertical_disassem_scroll.
5611 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5612 do_scroll_horizontal>: New methods.
5613 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5614 Likewise.
5615 (struct tui_source_window_base): Add do_scroll_horizontal.
5616 (struct tui_source_window, struct tui_disasm_window): Add
5617 do_scroll_vertical.
5618 (struct tui_data_window, struct tui_cmd_window): Add
5619 do_scroll_horizontal and do_scroll_vertical.
5620 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5621
5cf82909
TT
56222019-06-25 Tom Tromey <tom@tromey.com>
5623
5624 * tui/tui-data.h (struct tui_source_window_base): New struct.
5625 (struct tui_source_window): Derive from tui_source_window_base.
5626 (struct tui_disasm_window): New struct.
5627 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5628 from tui_source_window::clear_detail.
5629 (tui_source_window_base): Rename from tui_source_window.
5630 (~tui_source_window_base): Rename from ~tui_source_window.
5631 (tui_alloc_win_info): Create a tui_disasm_window.
5632
ee1d42d6
TT
56332019-06-25 Tom Tromey <tom@tromey.com>
5634
5635 * tui/tui-data.h (struct tui_source_window)
5636 (struct tui_data_window): Declare destructors.
5637 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5638 destructors.
5639 (tui_win_info): Simplify.
5640
b4eb2452
TT
56412019-06-25 Tom Tromey <tom@tromey.com>
5642
5643 * tui/tui-winsource.c (tui_display_main)
5644 (tui_update_source_windows_with_addr)
5645 (tui_update_all_breakpoint_info): Update.
5646 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5647 (new_height_ok, parse_scrolling_args): Update.
5648 * tui/tui-stack.c (tui_show_frame_info): Update.
5649 * tui/tui-data.h (struct tui_list): Remove.
5650 (tui_source_windows): Return a reference to a std::vector.
5651 * tui/tui-data.c (source_windows): Now a std::vector.
5652 (tui_source_windows): Change return type.
5653 (tui_clear_source_windows): Rewrite.
5654 (tui_clear_source_windows_detail, tui_add_to_source_windows)
5655 (tui_free_all_source_wins_content): Rewrite.
5656
8761a91b
TT
56572019-06-25 Tom Tromey <tom@tromey.com>
5658
5659 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5660 (struct tui_data_window, struct tui_cmd_window): Declare
5661 clear_detail method.
5662 * tui/tui-data.c (tui_source_window::clear_detail)
5663 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5664 methods.
5665 (tui_clear_win_detail): Simplify.
5666
0ed69eda
TT
56672019-06-25 Tom Tromey <tom@tromey.com>
5668
5669 * tui/tui-layout.c (make_source_window, make_disasm_window)
5670 (make_source_or_disasm_window): Remove win_info_ptr parameter.
5671 Return the new window.
5672 (show_source_disasm_command, show_data)
5673 (show_source_or_disasm_and_command): Update.
5674
82432e10
TT
56752019-06-25 Tom Tromey <tom@tromey.com>
5676
5677 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5678 parameter. Return the new window.
5679 (show_source_disasm_command): Update and remove NULL check.
5680 (show_source_or_disasm_and_command): Update.
5681
ec328aa5
TT
56822019-06-25 Tom Tromey <tom@tromey.com>
5683
5684 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5685
33b906ab
TT
56862019-06-25 Tom Tromey <tom@tromey.com>
5687
5688 * tui/tui-data.h (struct tui_win_info): Make constructor
5689 protected. Make destructor virtual. Add initializers.
5690 (tui_source_window, tui_data_window, tui_cmd_window): New
5691 classes.
5692 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
5693 constructor. Add "type" parameter.
5694 (tui_source_window, tui_data_window, tui_cmd_window): New
5695 constructors.
5696 (tui_alloc_win_info): Instantiate the appropriate subclass.
5697
e7e11af4
TT
56982019-06-25 Tom Tromey <tom@tromey.com>
5699
5700 * tui/tui-win.c (tui_resize_all): Use delete.
5701 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5702 destructor.
5703 (tui_free_window): Don't declare.
5704 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5705 Update.
5706
6792b55e
TT
57072019-06-25 Tom Tromey <tom@tromey.com>
5708
5709 * tui/tui-data.h (struct tui_win_info): Add constructor.
5710 * tui/tui-data.c (tui_alloc_win_info): Use new.
5711 (tui_free_window): Use delete.
5712
f95675e1
TT
57132019-06-22 Tom Tromey <tom@tromey.com>
5714
5715 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5716 declare.
5717 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5718
5bff081c
TT
57192019-06-22 Tom Tromey <tom@tromey.com>
5720
5721 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5722 declare.
5723 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5724
47e3f474
TV
57252019-06-22 Tom de Vries <tdevries@suse.de>
5726
5727 * dwarf2read.c (create_addrmap_from_aranges)
5728 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5729 instead of '%zu'.
5730
fd5866f6
SM
57312019-06-21 Simon Marchi <simon.marchi@efficios.com>
5732
5733 * dwarf2read.h (dwarf2_section_info_def): Remove.
5734 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5735 * dwarf2read.c (struct dwo_sections) <types>: Change type to
5736 std::vector<dwarf2_section_info>.
5737 (struct dwo_file) <~dwo_file>: Remove.
5738 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5739 types field.
5740 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5741 (dwarf2_read_debug_names): Likewise.
5742 (create_debug_types_hash_table): Change parameter type to
5743 array_view, adjust code accordingly.
5744 (dwarf2_locate_dwo_sections): Adjust to std::vector.
5745 (partial_die_info::fixup): Likewise.
5746 (determine_prefix): Likewise.
5747 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5748
fb1eb2f9
SM
57492019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5750
5751 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5752 gdb_bfd_ref_ptr.
5753 <~dwo_file>: Remove call to gdb_bfd_unref.
5754 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5755 gdb_bfd_ref_ptr::get.
5756
51ac9db5
SM
57572019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5758
5759 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5760 type to htab_up.
5761 * dwarf2read.c (struct dwo_file): Initialize fields.
5762 <~dwo_file>: New.
5763 (free_dwo_file): Remove, move content to ~dwo_file.
5764 (struct dwo_file_deleter): Remove.
5765 (dwo_file_up>: Remove custom deleter.
5766 (free_dwo_files): Remove.
5767 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5768 dwo_files.
5769 (process_skeletonless_type_units): Call unique_ptr::get.
5770 (allocate_dwo_file_hash_table): Add deleter to created hash
5771 table. Change return type to htab_up.
5772 (lookup_dwo_file_slot): Don't memset dwo_file, call
5773 unique_ptr::get.
5774 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5775 (create_dwo_unit_in_dwp_v2): Likewise.
5776 (open_and_init_dwo_file): Likewise.
5777 (free_dwo_file_from_slot): Remove.
5778
dc4ccb6f
SM
57792019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
5780
5781 * dwarf2read.h (struct dwarf2_section_info) <readin,
5782 is_virtual>: Change type to bool.
5783 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5784 true instead of 1.
5785
e6a1c5cb
TT
57862019-06-19 Tom Tromey <tom@tromey.com>
5787
5788 * tui/tui-data.h (tui_init_content_element): Don't declare.
5789
6f6ffbeb
TT
57902019-06-19 Tom Tromey <tom@tromey.com>
5791
5792 * tui/tui-data.h (tui_init_win_info): Don't declare.
5793
f23f598e
TV
57942019-06-19 Tom de Vries <tdevries@suse.de>
5795
5796 * dwarf2read.h (abstract_to_concrete): Change type to
5797 std::unordered_map<sect_offset, std::vector<sect_offset>,
5798 gdb::hash_enum<sect_offset>>.
5799
680e1bee
TT
58002019-06-19 Tom Tromey <tromey@adacore.com>
5801
5802 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5803 EVAL_AVOID_SIDE_EFFECTS specially.
5804
dcf37923
TT
58052019-06-19 Tom Tromey <tromey@adacore.com>
5806
5807 * source-cache.c (highlighter): New global.
5808 (source_cache::get_source_lines): Create a highlighter on demand.
5809
494986d5
AB
58102019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
5811
5812 * defs.h (deprecated_interactive_hook): Delete declaration.
5813 * interps.c (clear_interpreter_hooks): Remove use of
5814 deprecated_interactive_hook.
5815 * top.c (deprecated_interactive_hook): Delete definition.
5816 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5817
3360b6e7
TV
58182019-06-18 Tom de Vries <tdevries@suse.de>
5819
5820 PR gdb/24515
5821 * dwarf2read.h (abstract_to_concrete): Change type from
5822 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5823 std::unordered_map<sect_offset, std::vector<sect_offset>>.
5824 * dwarf2read.c (read_variable): Update.
5825 (dwarf2_fetch_die_loc_sect_off): Update.
5826
310b3441
TV
58272019-06-17 Tom de Vries <tdevries@suse.de>
5828
5829 PR gdb/24617
5830 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5831 accessing parent[parent_len - 1].
5832
ba9777be
PP
58332019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
5834
5835 PR gdb/24364
5836 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5837 call dtrace_process_dof with NULL dof.
5838
2b9f6e89
TV
58392019-06-16 Tom de Vries <tdevries@suse.de>
5840
5841 PR gdb/24445
5842 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5843
431b3ead
TT
58442019-06-16 Tom Tromey <tom@tromey.com>
5845
5846 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5847 (make_all_visible): Use address of member.
5848
d04b44a1
TT
58492019-06-16 Tom Tromey <tom@tromey.com>
5850
5851 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5852 (tui_free_window, free_content, free_content_elements): Remove
5853 unnecessary cast.
5854 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5855 cast.
5856 * tui/tui-regs.c (tui_show_register_group)
5857 (tui_display_registers_from, tui_display_reg_element_at_line):
5858 Remove unnecessary cast.
5859
bf5142e7
AB
58602019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
5861
5862 * linux-nat.c (normal_mask): Delete.
5863 (_initialize_linux_nat): Don't initialise normal_mask.
5864
c4973306
SM
58652019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
5866
5867 PR gdb/24445
5868 * dwarf-index-write.h (write_psymtabs_to_index): Add
5869 dwz_basename parameter.
5870 * dwarf-index-write.c (write_gdbindex): Move file writing to
5871 write_gdbindex_1. Change return type void.
5872 (assert_file_size): Move up, remove filename parameter.
5873 (write_gdbindex_1): New function.
5874 (write_debug_names): Change return type to void, call
5875 assert_file_size.
5876 (struct index_wip_file): New struct.
5877 (write_psymtabs_to_index): Add dwz_basename parameter. Move
5878 file logic to index_wip_file. Write index for dwz file if
5879 needed.
5880 (save_gdb_index_command): Pass basename of dwz file, if present.
5881 * dwarf-index-cache.c (index_cache::store): Obtain and pass
5882 build-id of dwz file, if present.
5883 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5884 (dwarf2_get_dwz_file): Likewise.
5885 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5886 (dwarf2_get_dwz_file): Likewise.
5887
395f9c91
TT
58882019-06-16 Tom Tromey <tom@tromey.com>
5889
5890 * coffread.c (process_coff_symbol): Use xstrdup.
5891 * value.c (create_internalvar): Use xstrdup.
5892
cafb3438
TT
58932019-06-16 Tom Tromey <tom@tromey.com>
5894
5895 * valops.c (value_cast, value_slice): Remove unnecessary cast.
5896 * breakpoint.c (stopin_command, stopat_command)
5897 (until_break_command, decode_location_default): Remove unnecessary
5898 cast.
5899 * utils.c (subset_compare): Remove unnecessary cast.
5900 * ada-lang.c (ada_update_initial_language): Remove unnecessary
5901 cast.
5902 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5903 cast.
5904 * infcmd.c (path_command): Remove unnecessary cast.
5905 * coffread.c (decode_type): Remove unnecessary cast.
5906 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5907 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5908 * tui/tui-stack.c (tui_show_locator_content)
5909 (tui_show_frame_info): Remove unnecessary cast.
5910 * tui/tui-win.c (tui_scroll_forward_command)
5911 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5912 (parse_scrolling_args): Remove unnecessary cast.
5913 * tui/tui-data.c (init_win_info, tui_del_window)
5914 (tui_free_window, tui_del_data_windows, tui_free_data_content)
5915 (free_content_elements): Remove unnecessary cast.
5916 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5917 unnecessary cast.
5918 * tui/tui-source.c (tui_set_source_content)
5919 (tui_vertical_source_scroll): Remove unnecessary cast.
5920 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5921 cast.
5922 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5923 * tui/tui-regs.c (tui_display_registers_from)
5924 (tui_display_register): Remove unnecessary cast.
5925 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5926 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5927 (make_visible): Remove unnecessary cast.
5928 * tui/tui-winsource.c (tui_erase_source_content)
5929 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5930 unnecessary cast.
5931 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5932 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5933 * stabsread.c (read_type, read_array_type, read_range_type):
5934 Remove unnecessary cast.
5935 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5936 (parse_symbol, parse_type, upgrade_type, parse_external)
5937 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5938 unnecessary cast.
5939 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5940
730ead81
TT
59412019-06-16 Tom Tromey <tom@tromey.com>
5942
5943 * tui/tui-data.c (tui_alloc_generic_win_info)
5944 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5945 checks.
5946
584a927c
AB
59472019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
5948 Andrew Burgess <andrew.burgess@embecosm.com>
5949
5950 * f-typeprint.c (f_print_type): Don't return early for not
5951 associated or not allocated types.
5952 (f_type_print_varspec_suffix): Add print_rank parameter and print
5953 ranks of array types in case they dangling.
5954 (f_type_print_base): Add print_rank parameter.
5955
30056ea0
AB
59562019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5957
5958 * NEWS: Mention new MI commands.
5959 * break-catch-throw.c (enum exception_event_kind): Move to
5960 breakpoint.h.
5961 (print_mention_exception_catchpoint): Output text as a single
5962 message.
5963 (catch_exception_command_1): Rename to...
5964 (catch_exception_event): ...this, make non-static, update header
5965 command, and change some parameter types.
5966 (catch_catch_command): Update for changes to
5967 catch_exception_command_1.
5968 (catch_throw_command): Likewise.
5969 (catch_rethrow_command): Likewise.
5970 * breakpoint.c (enum exception_event_kind): Delete.
5971 * breakpoint.h (enum exception_event_kind): Moved here from
5972 break-catch-throw.c.
5973 (catch_exception_event): Declare.
5974 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5975 (mi_cmd_catch_throw): New function.
5976 (mi_cmd_catch_rethrow): New function.
5977 (mi_cmd_catch_catch): New function.
5978 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5979 'catch-catch' entries.
5980 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5981 (mi_cmd_catch_rethrow): Declare.
5982 (mi_cmd_catch_catch): Declare.
5983
ec8e2b6d
AB
59842019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5985
5986 * annotate.c (annotate_source_line): Change return type to void,
5987 update implementation to match.
5988 * annotate.h (annotate_source_line): Change return type to void,
5989 update header comment.
5990 * stack.c (print_frame_info): Don't change what frame information
5991 is printed based on whether annotations are on or not.
5992
0d3abd8c
AB
59932019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5994
5995 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5996 (annotate_source): Make static.
5997 (annotate_source_line): Moved from source.c and renamed from
5998 identify_source_line. Update the return type.
5999 * annotate.h (annotate_source): Delete declaration.
6000 (annotate_source_line): Declaration moved from source.h, and
6001 renamed from identify_source_line. Return type updated.
6002 * source.c (identify_source_line): Moved to annotate.c and renamed
6003 to annotate_source_line.
6004 (info_line_command): Remove check of annotation_level.
6005 * source.h (identify_source_line): Move declaration to annotate.h
6006 and rename to annotate_source_line.
6007 * stack.c: Add 'annotate.h' include.
6008 (print_frame_info): Remove check of annotation_level before
6009 calling annotate_source_line.
6010
00df30ae
AB
60112019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6012
6013 * source-cache.c (source_cache::get_plain_source_lines): Use
6014 open_source_file_with_line_charpos instead of just
6015 open_source_file, remove call to find_source_lines.
6016 (source_cache::get_source_lines): Likewise.
6017 * source.c (find_source_lines): Make static.
6018 (get_filename_and_charpos): Renamed into...
6019 (open_source_file_with_line_charpos): ..this along with changes to
6020 return a scoped_fd, and some other minor clean ups.
6021 (identify_source_line): Use open_source_file_with_line_charpos.
6022 (search_command_helper): Use open_source_file_with_line_charpos
6023 instead of just open_source_file, remove call to
6024 find_source_lines.
6025 * source.h (open_source_file_with_line_charpos): Declare new
6026 function.
6027 (find_source_lines): Delete declaration.
6028
afda45a2
AB
60292019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
6030
6031 * source.c (get_filename_and_charpos): Remove fullname
6032 parameter.
6033 (identify_source_line): Update call to get_filename_and_charpos.
6034
0735b091
TT
60352019-06-14 Tom Tromey <tromey@adacore.com>
6036
6037 PR gdb/24502:
6038 * ui-style.h (skip_ansi_escape): Update comment.
6039 * ui-file.h (class no_terminal_escape_file): New class.
6040 * ui-file.c (no_terminal_escape_file::write)
6041 (no_terminal_escape_file::puts): New methods.
6042 * cli/cli-logging.c (handle_redirections): Use
6043 no_terminal_escape_file.
6044
52ce35e2
TT
60452019-06-14 Tom Tromey <tromey@adacore.com>
6046
6047 * NEWS: Move convenience variable news above Python news.
6048
73cc7272
TT
60492019-06-14 Tom Tromey <tom@tromey.com>
6050
6051 * gnulib: Move directory to top-level.
6052 * configure.ac: Don't configure gnulib.
6053 * configure: Rebuild.
6054 * common/common-defs.h: Use new path to gnulib.
6055 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6056 (GNULIB_H): Remove.
6057 (INCGNU): Look in new gnulib location.
6058 (HFILES_NO_SRCDIR): Remove gnulib files.
6059 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6060 (generated_files): Remove GNULIB_H.
6061 ($(LIBGNU), all-lib): Remove targets.
6062 (distclean): Don't mention GNULIB_BUILDDIR.
6063 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6064
f5686554
TT
60652019-06-14 Tom Tromey <tromey@adacore.com>
6066
6067 * symfile.c (add_symbol_file_command): Remove obsolete comment.
6068 Warn if symbol file does not provide any symbols.
6069
a0c1ffed
TT
60702019-06-14 Tom Tromey <tromey@adacore.com>
6071
6072 * source.c (find_and_open_source): Respect basenames_may_differ.
6073
7c39e397
AB
60742019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
6075
6076 * annotate.c (annotate_breakpoints_invalid): Make use of
6077 scoped_restore_terminal_state.
6078 (annotate_frames_invalid): Likewise.
6079
f411722c
TT
60802019-06-14 Tom Tromey <tromey@adacore.com>
6081
6082 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6083 allow assignment to an internalvar.
6084
4268ec18
TT
60852019-06-14 Tom Tromey <tromey@adacore.com>
6086
6087 * ada-lex.l: Allow "_" in attribute names.
6088
abdb711e
TT
60892019-06-14 Tom Tromey <tromey@adacore.com>
6090
6091 PR gdb/24653:
6092 * regcache.c (registers_changed): Don't call alloca.
6093 * top.c (execute_command): Don't call alloca.
6094
4c048731
PA
60952019-06-13 Pedro Alves <palves@redhat.com>
6096
6097 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6098 'expression'. When parsing an expression, error out if there's
6099 junk after "unlimited".
6100 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6101 (do_set_command): Adjust calls to is_unlimited_literal.
6102
66eb1ed3
PA
61032019-06-13 Pedro Alves <palves@redhat.com>
6104
6105 * compile/compile.c (make_compile_options_def_group): Add braces
6106 around array_view initializer.
6107 * thread.c (make_thread_apply_all_options_def_group)
6108 (make_thread_apply_all_options_def_group): Likewise.
6109
3345721a
PA
61102019-06-13 Pedro Alves <palves@redhat.com>
6111
6112 * NEWS (New commands): Mention "maint test-options
6113 require-delimiter", "maint test-options unknown-is-error", "maint
6114 test-options unknown-is-operand" and "maint show
6115 test-options-completion-result".
6116 (New command options, command completion): New section.
6117 (Completion improvements): New section.
6118 Mention that you can abbreviate "unlimited".
6119
6206060d
PA
61202019-06-13 Pedro Alves <palves@redhat.com>
6121
6122 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6123 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6124 * unittests/cli-utils-selftests.c (test_parse_flags)
6125 (test_parse_flags_qcs): Delete.
6126 (test_cli_utils): Don't call deleted functions.
6127
6665660a
PA
61282019-06-13 Pedro Alves <palves@redhat.com>
6129
6130 * thread.c: Include "cli/cli-option.h".
6131 (tp_array_compar_ascending): Global.
6132 (tp_array_compar): Delete function.
6133 (tp_array_compar_ascending, tp_array_compar_descending): New
6134 functions.
6135 (ascending_option_def, qcs_flag_option_def)
6136 (thr_qcs_flags_option_defs)
6137 (make_thread_apply_all_options_def_group)
6138 (make_thread_apply_options_def_group): New.
6139 (thread_apply_all_command): Use gdb::option::process_options.
6140 (thread_apply_command_completer)
6141 (thread_apply_all_command_completer): New.
6142 (thread_apply_command): Use gdb::option::process_options.
6143 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6144 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
6145 to generate help text of "thread apply". Adjust "taas"'s help.
6146 * tid-parse.c (tid_range_parser::in_thread_range): New method.
6147 * tid-parse.h (tid_range_parser::in_thread_range): New method.
6148
f7e13587
PA
61492019-06-13 Pedro Alves <palves@redhat.com>
6150
6151 * thread.c (thread_apply_command): Check for invalid TID with
6152 isdigit instead of !isalpha.
6153
5d707134
PA
61542019-06-13 Pedro Alves <palves@redhat.com>
6155
6156 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6157 (validate_flags_qcs): New.
6158 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6159 (validate_flags_qcs): Declare.
6160 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6161 (make_frame_apply_options_def_group): New.
6162 (frame_apply_command_count): Process options with
6163 gdb::option::process_options.
6164 (frame_apply_completer): New.
6165 (frame_apply_level_completer, frame_apply_all_completer)
6166 (frame_apply_completer): New.
6167 (_initialize_stack): Update help of "frame apply", "frame apply
6168 level", "frame apply all" and "faas" to mention supported options
6169 and install command completers.
6170 * stack.h (frame_apply_all_completer): Declare.
6171 * thread.c: Include "stack.h".
6172 (tfaas_command): Add "--".
6173 (_initialize_thread): Update help "tfaas" to mention supported
6174 options and install command completer.
6175
272d4594
PA
61762019-06-13 Pedro Alves <palves@redhat.com>
6177
6178 * completer.c (complete_nested_command_line): New.
6179 (gdb_completion_word_break_characters_throw): Add assertion.
6180 * completer.h (complete_nested_command_line): Declare.
6181
90a1ef87
PA
61822019-06-13 Pedro Alves <palves@redhat.com>
6183
6184 * stack.c (parse_backtrace_qualifiers): New.
6185 (backtrace_command): Use it.
6186 (backtrace_command_completer): Complete on qualifiers.
6187
d4c16835
PA
61882019-06-13 Pedro Alves <palves@redhat.com>
6189
6190 * frame.c: Include "cli/cli-option.h.
6191 (user_set_backtrace_options): New.
6192 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6193 Delete.
6194 (get_prev_frame): Adjust.
6195 (boolean_option_def, uinteger_option_def)
6196 (set_backtrace_option_defs): New.
6197 (_initialize_frame): Adjust and use
6198 gdb::option::add_setshow_cmds_for_options to install "set
6199 backtrace past-main" and "set backtrace past-entry".
6200 * frame.h: Include "cli/cli-option.h".
6201 (struct frame_print_options): Forward declare.
6202 (print_frame_arguments_all, print_frame_arguments_scalars)
6203 (print_frame_arguments_none): Declare.
6204 (print_entry_values): Delete declaration.
6205 (struct frame_print_options, user_frame_print_options): New.
6206 (struct set_backtrace_options): New.
6207 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6208 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6209 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6210 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6211 (list_args_or_locals): Add frame_print_options parameter.
6212 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6213 * python/py-framefilter.c (enumerate_args): Pass down
6214 USER_FRAME_PRINT_OPTIONS.
6215 * stack.c: Include "cli/cli-option.h".
6216 (print_frame_arguments_all, print_frame_arguments_scalars)
6217 (print_frame_arguments_none): Declare.
6218 (print_raw_frame_arguments, print_entry_values): Delete.
6219 (user_frame_print_options): New.
6220 (boolean_option_def, enum_option_def, frame_print_option_defs):
6221 New.
6222 (struct backtrace_cmd_options): New.
6223 (bt_flag_option_def): New.
6224 (backtrace_command_option_defs): New.
6225 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6226 (print_frame_arg, read_frame_arg, print_frame_args)
6227 (print_frame_info, print_frame): Add frame_print_options parameter
6228 and use it.
6229 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6230 (backtrace_command_1): Add frame_print_options and
6231 backtrace_cmd_options parameters and use them.
6232 (make_backtrace_options_def_group): New.
6233 (backtrace_command): Process command options with
6234 gdb::option::process_options.
6235 (backtrace_command_completer): New.
6236 (_initialize_stack): Extend "backtrace"'s help to mention
6237 supported options. Install completer for "backtrace".
6238 Install some settings commands with add_setshow_cmds_for_options.
6239
2daf894e
PA
62402019-06-13 Pedro Alves <palves@redhat.com>
6241
6242 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6243 and that "set/show print raw frame-arguments" are now deprecated.
6244
6245 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6246 command.
6247 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6248 * stack.c (_initialize_stack): Install "set/show print
6249 raw-frame-arguments", and deprecate "set/show print raw
6250 frame-arguments".
6251 * valprint.c (_initialize_valprint): Deprecate "set/show print
6252 raw".
6253
e6ed716c
PA
62542019-06-13 Pedro Alves <palves@redhat.com>
6255
6256 * compile/compile.c (struct compile_options): New.
6257 (compile_flag_option_def, compile_command_option_defs)
6258 (make_compile_options_def_group): New.
6259 (compile_file_command): Handle options with
6260 gdb::option::process_options.
6261 (compile_file_command_completer): New function.
6262 (compile_code_command): Handle options with
6263 gdb::option::process_options.
6264 (compile_code_command_completer): New function.
6265 (_initialize_compiler): Install completers for "compile code" and
6266 "compile file". Mention available options in "compile code" and
6267 "compile code"'s help.
6268 * completer.c (advance_to_completion_word): New, factored out from
6269 ...
6270 (advance_to_expression_complete_word_point): ... this.
6271 (advance_to_filename_complete_word_point): New.
6272 * completer.h (advance_to_filename_complete_word_point): New
6273 declaration.
6274
7d8062de
PA
62752019-06-13 Pedro Alves <palves@redhat.com>
6276
6277 * compile/compile.c: Include "cli/cli-option.h".
6278 (compile_print_value): Scope data pointer is now a
6279 value_print_options pointer; adjust.
6280 (compile_print_command): Process options. Scope data pointer is
6281 now a value_print_options pointer; adjust.
6282 (_initialize_compile): Update "compile print"'s help to include
6283 supported options. Install a completer for "compile print".
6284 * cp-valprint.c (show_vtblprint, show_objectprint)
6285 (show_static_field_print): Delete.
6286 (_initialize_cp_valprint): Don't install "set print
6287 static-members", "set print vtbl", "set print object" here.
6288 * printcmd.c: Include "cli/cli-option.h" and
6289 "common/gdb_optional.h".
6290 (print_command_parse_format): Rework to fill in a
6291 value_print_options instead of a format_data.
6292 (print_value): Change parameter type from format_data pointer to
6293 value_print_options reference. Adjust.
6294 (print_command_1): Process options. Adjust to pass down a
6295 value_print_options.
6296 (print_command_completer): New.
6297 (_initialize_printcmd): Install print_command_completer as
6298 handle_brkchars completer for the "print" command. Update
6299 "print"'s help to include supported options.
6300 * valprint.c: Include "cli/cli-option.h".
6301 (show_vtblprint, show_objectprint, show_static_field_print): Moved
6302 here from cp-valprint.c.
6303 (boolean_option_def, uinteger_option_def)
6304 (value_print_option_defs, make_value_print_options_def_group):
6305 New. Use gdb::option::add_setshow_cmds_for_options to install
6306 "set print elements", "set print null-stop", "set print repeats",
6307 "set print pretty", "set print union", "set print array", "set
6308 print address", "set print symbol", "set print array-indexes".
6309 * valprint.h: Include <string> and "cli/cli-option.h".
6310 (make_value_print_options_def_group): Declare.
6311 (print_value): Change parameter type from format_data pointer to
6312 value_print_options reference.
6313 (print_command_completer): Declare.
6314
9d0faba9
PA
63152019-06-13 Pedro Alves <palves@redhat.com>
6316
6317 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6318 (COMMON_SFILES): Add maint-test-settings.c.
6319 * cli/cli-decode.c (boolean_enums): New global, factored out from
6320 ...
6321 (add_setshow_boolean_cmd): ... here.
6322 * cli/cli-decode.h (boolean_enums): Declare.
6323 * cli/cli-option.c: New file.
6324 * cli/cli-option.h: New file.
6325 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6326 factored out from ...
6327 (parse_cli_boolean_value(const char *)): ... this.
6328 (is_unlimited_literal): Change parameter type to pointer to
6329 pointer. Adjust and advance ARG pointer.
6330 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6331 (parse_cli_var_enum): New, factored out from ...
6332 (do_set_command): ... this. Adjust.
6333 * cli/cli-setshow.h (parse_cli_boolean_value)
6334 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6335 (parse_cli_var_enum): Declare.
6336 * cli/cli-utils.c: Include "cli/cli-option.h".
6337 (get_ulongest): New.
6338 * cli/cli-utils.h (get_ulongest): Declare.
6339 (check_for_argument): New overloads.
6340 * maint-test-options.c: New file.
6341
2c722807
PA
63422019-06-13 Pedro Alves <palves@redhat.com>
6343
6344 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6345 parse a range if "-" is at the end of the string.
6346
dee7b4c8
PA
63472019-06-13 Pedro Alves <palves@redhat.com>
6348
6349 * cli/cli-setshow.c (parse_auto_binary_operation)
6350 (parse_cli_boolean_value): Don't allow "o".
6351
dca0f6c0
PA
63522019-06-13 Pedro Alves <palves@redhat.com>
6353
6354 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6355 * NEWS: Mention maint test-settings KIND.
6356 * maint-test-settings.c: New file.
6357
597bf39d
PA
63582019-06-13 Pedro Alves <palves@redhat.com>
6359
6360 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6361 completer.
6362 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6363 "set" completers.
6364
48c410fb
PA
63652019-06-13 Pedro Alves <palves@redhat.com>
6366
6367 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6368 after item.
6369
93bcb043
PA
63702019-06-13 Pedro Alves <palves@redhat.com>
6371
6372 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6373
cbba3ecd
PA
63742019-06-13 Pedro Alves <palves@redhat.com>
6375
6376 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6377 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6378 call.
6379 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6380 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6381 calls.
6382 (check_for_argument): Skip spaces after argument.
6383
b9a3f842
PA
63842019-06-13 Pedro Alves <palves@redhat.com>
6385
6386 * thread.c (thread_apply_command): Adjust TID parsing.
6387 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6388 detected before end of string.
6389 (tid_is_in_list): Error out if LIST is invalid.
6390
3844e605
PA
63912019-06-13 Pedro Alves <palves@redhat.com>
6392
6393 * completer.c (complete_line_internal_1): Rewind completion word
6394 point.
6395 (completion_tracker::advance_custom_word_point_by): Change
6396 parameter type to int.
6397 * completer.h (completion_tracker::advance_custom_word_point_by):
6398 Likewise.
6399
00b56dbe
PA
64002019-06-13 Pedro Alves <palves@redhat.com>
6401
6402 * completer.c (advance_to_completion_word): Handle delimiters.
6403
d106773e
PA
64042019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
6405
6406 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6407
08f10e02
TT
64082019-06-11 Tom Tromey <tom@tromey.com>
6409
6410 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6411 (xmalloc_failed): Move to alloc.c.
6412 * alloc.c: New file.
6413 * Makefile.in (COMMON_SFILES): Add alloc.c.
6414
1c7fe951
TT
64152019-06-11 Tom Tromey <tom@tromey.com>
6416
6417 * nat/linux-waitpid.c: Don't include server.h.
6418 (linux_debug): Remove.
6419 (my_waitpid): Update.
6420
89549d7f
TT
64212019-06-11 Tom Tromey <tromey@adacore.com>
6422
6423 * infcall.c (_initialize_infcall): Remove trailing newline from
6424 help.
6425 * user-regs.c (_initialize_user_regs): Remove trailing newline
6426 from help.
6427 * typeprint.c (_initialize_typeprint): Remove trailing newline
6428 from help.
6429 * reverse.c (_initialize_reverse): Remove trailing newlines from
6430 help.
6431 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6432 from help.
6433 * language.c (add_set_language_command): Remove trailing newline
6434 from help.
6435 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6436 help.
6437 * disasm.c (_initialize_disasm): Remove trailing newline from
6438 help.
6439 * top.c (init_main): Remove trailing newline from help.
6440 * interps.c (_initialize_interpreter): Remove trailing newline
6441 from help.
6442 * btrace.c (_initialize_btrace): Remove trailing newlines from
6443 help.
6444 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6445 from help.
6446 * python/python.c (_initialize_python): Remove trailing newline
6447 from help.
6448 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6449 help.
6450 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6451 from help. Reformat some text.
6452 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6453 from help.
6454 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6455 newline from help.
6456
86108c13
TT
64572019-06-11 Tom Tromey <tromey@adacore.com>
6458
6459 * darwin-nat.c (darwin_decode_exception_message)
6460 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6461
a7067863
AB
64622019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
6463
6464 * valops.c (value_slice): Check for not allocated or not
6465 associated values.
6466
9ab08412
TV
64672019-06-10 Tom de Vries <tdevries@suse.de>
6468
6469 PR gdb/24618
6470 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6471 sure an empty slot (defined by a 32-bit zero pair) is recognized as
6472 invalid.
6473
f19e22e9
TV
64742019-06-10 Tom de Vries <tdevries@suse.de>
6475
6476 PR gdb/24611
6477 * linespec.c (linespec_lexer_lex_string): Remove incorrect
6478 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
6479
e99f9db0
TV
64802019-06-10 Tom de Vries <tdevries@suse.de>
6481
6482 PR symtab/24545
6483 * symtab.c (struct demangled_name_entry): Add language field.
6484 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
6485 static minimal symbol". Set and use language field.
6486
9bf7038b
TT
64872019-06-10 Tom Tromey <tromey@adacore.com>
6488
6489 * ada-lang.c (_initialize_ada_language): Update help text.
6490
422186a9
TT
64912019-06-10 Tom Tromey <tromey@adacore.com>
6492
6493 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6494 with a newline.
6495 * guile/guile.c (handle_boot_error): Don't end warning with a
6496 newline.
6497 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6498 warning with a newline.
6499 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6500 newline.
6501 (s12z_frame_cache): Likewise.
6502 * dwarf-index-cache.c (index_cache::store): Don't end warning with
6503 a newline.
6504 * solib-svr4.c (disable_probes_interface): Don't end warning with
6505 a newline.
6506 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6507 newline.
6508 * python/python.c (do_finish_initialization): Don't end warning
6509 with a newline.
6510
25ce02ee
TT
65112019-06-10 Tom Tromey <tom@tromey.com>
6512
6513 * python/py-breakpoint.c (gdbpy_breakpoint_created)
6514 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6515 gdbpy_enter.
6516
caa429d8
TT
65172019-06-10 Tom Tromey <tromey@adacore.com>
6518
6519 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6520 data.
6521 (elf_new_init): Don't call stabsread_new_init.
6522 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6523 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
6524 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6525
81873cc8
TV
65262019-06-10 Tom de Vries <tdevries@suse.de>
6527
6528 PR symtab/16264
6529 PR symtab/24517
6530 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6531
4fa0265e
РИ
65322019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
6533
6534 * source.c (find_and_open_source): Also rewrite relative file
6535 names.
6536
1a3da2cd
AB
65372019-04-26 Amos Bird <amosbird@gmail.com>
6538
6539 * annotate.c (annotate_thread_exited): Add "thread-exited"
6540 annotation.
6541
3847a7bf
TT
65422019-06-06 Tom Tromey <tromey@adacore.com>
6543
6544 * maint.h (class scoped_command_stats): Use
6545 DISABLE_COPY_AND_ASSIGN.
6546 <print_time>: New method.
6547 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6548 print_time.
6549 (scoped_command_stats::print_time): New method.
6550
312617a3
AB
65512019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
6552
6553 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6554 instructions of lengths 6 or 8 bytes.
6555
b02f78f9
PA
65562019-06-04 Pedro Alves <palves@redhat.com>
6557
6558 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6559
6560 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6561 * breakpoint.c (condition_completer): Likewise.
6562 * cli/cli-dump.c (scan_expression): Likewise.
6563 * common/filestuff.c (mkdir_recursive): Likewise.
6564 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6565 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6566 (gdb_abspath): Likewise.
6567 * compile/compile-cplus-types.c
6568 (compile_cplus_instance::decl_name): Likewise.
6569 * completer.c (complete_explicit_location):
6570 (signal_completer, reg_or_group_completer_1): Likewise.
6571 * cp-support.c (cp_remove_params_if_any): Likewise.
6572 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6573 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6574 * infcmd.c (strip_bg_char): Likewise.
6575 * linespec.c (copy_token_string): Likewise.
6576 * mi/mi-main.c (output_cores): Likewise.
6577 * psymtab.c (psymtab_search_name):
6578 * symfile.c (test_set_ext_lang_command): Likewise.
6579 * target.c (target_fileio_read_stralloc): Likewise.
6580 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6581 * value.c (complete_internalvar): Likewise.
6582
e1f2e1a2
CB
65832019-06-04 Christian Biesinger <cbiesinger@google.com>
6584
6585 Add objfile property to gdb.Type.
d3238f7d
PA
6586 * NEWS: Mention Python API addition.
6587 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 6588
e664d728
PW
65892019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6590
6591 * NEWS: Mention the new set|show style [title|highlight].
6592 Mention changes to "show style", "help" and "apropos".
6593
66d8c862
PW
65942019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6595
6596 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6597 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
6598 instead of print_help_for_command.
6599 (print_doc_of_command): New function.
6600 (help_list): Add 'apropos -v word' suggestion.
6601 (print_help_for_command): Style the command name using title style.
6602 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6603 (_initialize_cli_cmds): Describe -v in apropos_command help.
6604
9303eb2f
PW
66052019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6606
6607 * cli/cli-style.h (cli_style_option): Add name in constructor,
6608 add m_name class member, add constructor with intensity,
6609 add name class function.
6610 (cli_style_option::add_setshow_commands): Remove name argument.
6611 (highlight_style, title_style): New styles.
6612 * cli/cli-style.c (do_show): New function that shows a style
6613 characteristic styling the style name with itself.
6614 (set_style_name): New function.
6615 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6616 Update all callers according to the changes in cli/cli-style.h.
6617 * utils.h (fputs_highlighted): New function.
6618 * utils.c (fputs_highlighted): Likewise.
6619
e2c52041
PW
66202019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6621
6622 * NEWS: Mention new pipe command and new convenience variables.
6623
947d3946
PW
66242019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6625
6626 * cli/cli-cmds.c (pipe_command): New function.
6627 (_initialize_cli_cmds): Call add_com for pipe_command.
6628 Define | as an alias for pipe.
6629 (exit_status_set_internal_vars): New function.
6630 (shell_escape): Call exit_status_set_internal_vars.
6631 cli/cli-decode.c (find_command_name_length): Recognize | as
6632 a single character command.
6633
b8fd0918
PW
66342019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6635
6636 * gdbcmd.h (execute_command_to_ui_file): New declaration.
6637 top.c (execute_command_to_ui_file): New function, mostly a copy
6638 of execute_command_to_string.
6639 (execute_command_to_string): Implement by calling
6640 execute_command_to_ui_file.
6641
68bb5386
PW
66422019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6643
6644 * top.h (saved_command_line): Remove declaration.
6645 * top.c (previous_saved_command_line, previous_repeat_arguments):
6646 New variables.
6647 (saved_command_line): Make static, define together with other
6648 'repeat variables'.
6649 (dont_repeat): Clear repeat_arguments.
6650 (repeat_previous, get_saved_command_line, save_command_line):
6651 New functions.
6652 (gdb_init): Initialize saved_command_line
6653 and previous_saved_command_line.
6654 * main.c (captured_main_1): Remove saved_command_line initialization.
6655 * event-top.c (handle_line_of_input): Update to use
6656 the new 'repeat' related functions instead of direct access to
6657 saved_command_line.
6658 * command.h (repeat_previous, get_saved_command_line,
6659 save_command_line): New declarations.
6660 (dont_repeat): Add comment.
6661
bfcdb852
TT
66622019-05-30 Tom Tromey <tromey@adacore.com>
6663
6664 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6665 Fix comment.
6666 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6667
0ef209f2
JV
66682019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
6669
6670 PR cli/24587
6671 * completer.c (complete): Initialize variable word.
6672
955b06fa
SDJ
66732019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
6674
6675 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6676 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6677 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6678 'body' is NULL to the outter 'if', protecting the '!is_define'
6679 situation as well.
6680
fa9c3fa0
TT
66812019-05-29 Tom Tromey <tromey@adacore.com>
6682
6683 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6684 (dwarf_unknown): New function.
6685 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6686 (dwarf_type_encoding_name): Use dwarf_unknown.
6687
4330d61d
TT
66882019-05-29 Tom Tromey <tromey@adacore.com>
6689
6690 PR c++/20020:
6691 * cp-valprint.c (cp_print_value_fields): Call
6692 cp_print_static_field inside "try".
6693
33a6bc35
TT
66942019-05-29 Tom Tromey <tromey@adacore.com>
6695
6696 * inflow.c (struct terminal_info): Add default operator=.
6697 * configure: Rebuild.
6698 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6699 -Wdeprecated-copy-dtor, -Wredundant-move.
6700
000439d5
TT
67012019-05-29 Tom Tromey <tromey@adacore.com>
6702
6703 * NEWS: Add entry.
6704 * infcmd.c (print_return_value_1): Handle finish_print
6705 option.
6706 (show_print_finish): New function.
6707 (_initialize_infcmd): Add "set/show print finish" commands.
6708 * valprint.c (user_print_options): Initialize new member.
6709 * valprint.h (struct value_print_options) <finish_print>: New
6710 member.
6711
c0e70c62
TT
67122019-05-28 Tom Tromey <tromey@adacore.com>
6713
6714 * ada-lang.c (ada_remove_Xbn_suffix)
6715 (find_old_style_renaming_symbol)
6716 (parse_old_style_renaming): Remove.
6717 (ada_find_renaming_symbol): Don't call
6718 find_old_style_renaming_symbol.
6719 (ada_is_renaming_symbol): Rename from
6720 ada_find_renaming_symbol. Remove "block" parameter. Return
6721 bool. Now static.
6722 (ada_read_var_value): Update and simplify.
6723 * ada-exp.y (write_var_or_type): Remove old code.
6724
766f8836
AH
67252019-05-28 Alan Hayward <alan.hayward@arm.com>
6726
6727 * event-top.c: Remove include comment.
6728 * inflow.c (class scoped_ignore_sigttou): Move from here...
6729 * inflow.h (class scoped_ignore_sigttou): ...to here.
6730 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6731 * top.c: Remove include comment.
6732
eb41253a
TT
67332019-05-27 Tom Tromey <tom@tromey.com>
6734
6735 * NEWS: Fix typo.
6736
4ca51187
TT
67372019-05-22 Tom Tromey <tromey@adacore.com>
6738
6739 * target.c (target_follow_exec): Constify parameter.
6740 * target-delegates.c: Rebuild.
6741 * remote.c (remote_target::follow_exec): Constify parameter.
6742 * infrun.c (follow_exec): Constify parameter.
6743 * target.h (struct target_ops) <follow_exec>: Constify parameter.
6744 (target_follow_exec): Likewise.
6745
8fca4da0
AH
67462019-05-22 Alan Hayward <alan.hayward@arm.com>
6747
6748 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6749 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6750
b7060614
AH
67512019-05-22 Alan Hayward <alan.hayward@arm.com>
6752
6753 * NEWS: Add debugredirect and testsuite sections.
6754
0a5954bd
SC
67552019-05-22 Simon Cook <simon.cook@embecosm.com>
6756
6757 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6758 target descriptions using exclusively floating point register name
6759 aliases.
6760
dc42e902
AB
67612019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
6762
6763 PR gdb/18644:
6764 * f-lang.c (build_fortran_types): Handle the case where
6765 gdbarch_floatformat_for_type returns a nullptr.
6766
fb7806c7
TV
67672019-05-21 Tom de Vries <tdevries@suse.de>
6768
6769 PR cli/24587
6770 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6771
34d11c68
AB
67722019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6773
6774 PR gdb/18644:
6775 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6776 16-byte floats.
6777 * i386-tdep.c (i386_floatformat_for_type): Use
6778 floatformats_ia64_quad for the 16-byte floating point component
6779 within a fortran 32-byte complex number.
6780
122cf0f2
AB
67812019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
6782
6783 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6784 delete default constructor.
6785 (find_partial_die): Update to return const struct.
6786 (partial_die_parent_scope): Move variable declaration into scope
6787 of its use and change its type to auto.
6788 (guess_partial_die_structure_name): Likewise.
6789 (partial_die_info::fixup): Likewise.
6790
33d0e35a
TT
67912019-05-17 Tom Tromey <tromey@adacore.com>
6792
6793 * source.c (find_and_open_source): Remove cast.
6794
a45575b0
TT
67952019-05-17 Tom Tromey <tromey@adacore.com>
6796
6797 * annotate.c (annotate_source): Make "filename" const.
6798 * annotate.h (annotate_source): Use const.
6799
81f47ac2
AH
68002019-05-17 Alan Hayward <alan.hayward@arm.com>
6801
6802 * disasm.c (set_disassembler_options): Send errors to stderr.
6803
ca1285d1
AH
68042019-05-17 Alan Hayward <alan.hayward@arm.com>
6805
6806 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6807 (cli_interp_base::set_logging): Check debug_redirect.
6808 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6809 * cli/cli-logging.c (debug_redirect): Add static variable.
6810 (pop_output_files): Add default param.
6811 (handle_redirections): Print debug setting.
6812 (show_logging_command): Likewise.
6813 (_initialize_cli_logging): Add debugredirect command.
6814 * interps.c (current_interp_set_logging): Add debug_redirect
6815 parameter.
6816 * interps.h (set_logging): Add debug_redirect parameter.
6817 (current_interp_set_logging): Likewise.
6818 * mi/mi-common.h: Likewise.
6819 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6820
68212019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
6822 Tom Tromey <tromey@adacore.com>
6823
6824 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6825 directly.
6826 * cli/cli-interp.h (make_logging_output): Remove declaration.
6827 * cli/cli-logging.c (make_logging_output): Remove function.
6828 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6829 directly.
6830 * ui-file.c (tee_file::tee_file): Remove bools.
6831 (tee_file::~tee_file): Remove deletes.
6832 * ui-file.h (tee_file): Remove bools.
6833
26648588
JV
68342019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
6835
6836 * mi/mi-cmds.h (mi_cmd_complete): New function.
6837 * mi/mi-main.c (mi_cmd_complete): Likewise.
6838 * mi/mi-cmds.c: Define new MI command -complete.
6839 * NEWS: Mention new -complete command.
6840
6e035501
JV
68412019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
6842
6843 * completer.h (complete): New function.
6844 * completer.c (complete): Likewise.
6845 * cli/cli-cmds.c: (complete_command): Update to use new complete()
6846 function defined in completer.h.
6847
7d0e2ece
JV
68482019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
6849
e79be6e5 6850 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 6851
fb816e8b
TV
68522019-05-17 Tom de Vries <tdevries@suse.de>
6853
6854 PR gdb/24094
6855 * dwarf2read.c (struct cu_partial_die_info): New struct.
6856 (find_partial_die): Return cu_partial_die_info.
6857 (partial_die_parent_scope, guess_partial_die_structure_name)
6858 (partial_die_info::fixup): Handle new return type of find_partial_die.
6859
677052f2
SDJ
68602019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6861
a1726c38 6862 PR breakpoints/24541
677052f2
SDJ
6863 * stap-probe.c (stap_parse_register_operand): Make "regname" an
6864 "std::string", simplifying the algorithm.
6865
f3da9116
SDJ
68662019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6867
6868 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6869 (stap_static_probe_ops::get_probes): Likewise.
6870
f1bb75ab
SDJ
68712019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6872
6873 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6874 '-')" and "else if".
6875 (stap_parse_single_operand): Join checks for
6876 "gdbarch_stap_parse_special_token_p" and
6877 "gdbarch_stap_parse_special_token" in the same "if" statement.
6878 Invert check when verifying for operation on register
6879 displacement.
6880
3ca58cde
SDJ
68812019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6882
6883 * stap-probe.c (stap_get_opcode): Update comment.
6884 (stap_get_expected_argument_type): Likewise.
6885 (handle_stap_probe): Likewise.
6886
af2d9bee
SDJ
68872019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
6888
6889 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6890 return type to 'bool'. Adjust comment. Use 'bool' when
6891 appropriate.
6892 (i386_stap_parse_special_token_three_arg_disp): Likewise.
6893 * stap-probe.c (stap_parse_argument_1): Likewise.
6894 (stap_is_operator): Likewise.
6895 (stap_is_generic_prefix): Likewise.
6896 (stap_is_register_prefix): Likewise.
6897 (stap_is_register_indirection_prefix): Likewise.
6898 (stap_is_integer_prefix): Likewise.
6899 (stap_generic_check_suffix): Likewise.
6900 (stap_check_integer_suffix): Likewise.
6901 (stap_check_register_suffix): Likewise.
6902 (stap_check_register_indirection_suffix): Likewise.
6903 (stap_parse_register_operand): Likewise.
6904 (stap_parse_single_operand): Likewise.
6905 (stap_parse_argument_1): Likewise.
6906 (stap_probe::get_argument_count): Likewise.
6907 (stap_is_operator): Likewise.
6908
61c9c421
TT
69092019-05-16 Tom Tromey <tromey@adacore.com>
6910
6911 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6912 keyword to foreach.
6913
9ddc1af1
SM
69142019-05-15 Simon Marchi <simon.marchi@efficios.com>
6915
6916 * linux-thread-db.c (try_thread_db_load_1): Change return type
6917 to bool.
6918 (try_thread_db_load): Likewise.
6919 (try_thread_db_load_from_pdir_1): Likewise.
6920 (try_thread_db_load_from_pdir): Likewise.
6921 (try_thread_db_load_from_sdir): Likewise.
6922 (try_thread_db_load_from_dir): Likewise.
6923 (thread_db_load_search): Likewise.
6924 (has_libpthread): Likewise.
6925 (thread_db_load): Likewise.
6926
7bede828
SDJ
69272019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
6928
6929 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6930 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6931 NULL, and complain/return if that's the case.
6932
c5358db4
JD
69332019-05-15 John Darrington <john@darrington.wattle.id.au>
6934
6935 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6936 (advance, posn, abstract_read_memory): New functions.
6937 [struct mem_read_abstraction]: New struct.
6938 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6939
c408a94f
TT
69402019-05-14 Tom Tromey <tromey@adacore.com>
6941
6942 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6943 value is not lval_memory.
6944
e7bd7fba
TT
69452019-05-14 Tom Tromey <tromey@adacore.com>
6946
6947 * solib.c (info_sharedlibrary_command): Style the file name.
6948
a6d0f249
AH
69492019-05-14 Alan Hayward <alan.hayward@arm.com>
6950
6951 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6952 (aarch64_vnv_type): Likewise.
6953 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6954 * common/tdesc.c: Likewise.
6955 * common/tdesc.h (enum tdesc_type_kind): Likewise.
6956 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6957 * features/aarch64-fpu.xml: Add ieee half view.
6958 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6959 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6960 * gdbtypes.h (struct builtin_type): Likewise.
6961 (struct objfile_type): Likewise.
6962
66b8bb74
SM
69632019-05-12 Paul Naert <paul.naert@polymtl.ca>
6964
6965 * language.c (language_sniff_from_mangled_name): Fix "langauge"
6966 typo.
6967 * location.h (string_to_event_location): Likewise.
6968
21c219fd
JB
69692019-05-11 Joel Brobecker <brobecker@adacore.com>
6970
6971 GDB 8.3 released.
6972
13674803
SM
69732019-05-10 Simon Marchi <simon.marchi@efficios.com>
6974
6975 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6976 New variable declaration.
6977 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6978 New variable.
6979 (print_one_breakpoint): Use ui_out::test_flags and new global
6980 variable to compute use_fixed_output.
6981 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6982 Remove.
6983 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6984 (mi_multi_location_breakpoint_output_fixed): Remove.
6985 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6986 new variable.
6987 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6988 fix_multi_location_breakpoint_output flag if version >= 3.
6989 * ui-out.h (enum ui_out_flag)
6990 <fix_multi_location_breakpoint_output>: New enumerator.
6991
a9eac7f9
SM
69922019-05-10 Simon Marchi <simon.marchi@efficios.com>
6993
6994 * contrib/cc-with-tweaks.sh: Validate dwz's work.
6995
71bed2db
TT
69962019-05-10 Tom Tromey <tromey@adacore.com>
6997
6998 * ada-lang.c (catch_ada_completer): New function.
6999 (_initialize_ada_language): Use it.
7000
24c54127
TT
70012019-05-10 Tom Tromey <tromey@adacore.com>
7002
7003 * thread.c (print_thread_info): Make "requested_threads" const.
7004 * gdbthread.h (print_thread_info): Make "requested_threads"
7005 const.
7006 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7007 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7008
7a102139
TT
70092019-05-08 Tom Tromey <tom@tromey.com>
7010
7011 * gdbtypes.c (objfile_type_data): Change type.
7012 (objfile_type, _initialize_gdbtypes): Update.
7013
924d79e2
TT
70142019-05-08 Tom Tromey <tom@tromey.com>
7015
7016 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7017 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7018 (_initialize_dwarf2_frame): Update.
7019
4c58e337
TT
70202019-05-08 Tom Tromey <tom@tromey.com>
7021
7022 * objc-lang.c (objc_objfile_data): Change type.
7023 (find_methods): Update.
7024 (_initialize_objc_lang): Remove.
7025
d772d2ab
TT
70262019-05-08 Tom Tromey <tom@tromey.com>
7027
7028 * stabsread.c (rs6000_builtin_type_data): Change type.
7029 (rs6000_builtin_type, _initialize_stabsread): Update.
7030
d11d83f4
TT
70312019-05-08 Tom Tromey <tom@tromey.com>
7032
7033 * mips-tdep.c (mips_pdr_data): Remove.
7034 (_initialize_mips_tdep): Update.
7035
9a73f0ad
TT
70362019-05-08 Tom Tromey <tom@tromey.com>
7037
7038 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7039 (hppa_init_objfile_priv_data, read_unwind_info)
7040 (find_unwind_entry, _initialize_hppa_tdep): Update.
7041
8127a2fa
TT
70422019-05-08 Tom Tromey <tom@tromey.com>
7043
7044 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7045 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
7046 on obstack.
7047 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7048
91d3055d
TT
70492019-05-08 Tom Tromey <tom@tromey.com>
7050
7051 * mdebugread.c (basic_type_data): Change type.
7052 (basic_type, _initialize_mdebugread): Update.
7053
31930bd3
TT
70542019-05-08 Tom Tromey <tom@tromey.com>
7055
7056 * common/gdb_unique_ptr.h (struct noop_deleter): New.
7057
bdb3ed9e
TT
70582019-05-08 Tom Tromey <tom@tromey.com>
7059
7060 * nto-tdep.c (nto_inferior_data_reg): Change type.
7061 (nto_inferior_data): Update.
7062 (nto_inferior_data_cleanup, nto_new_inferior_data)
7063 (_initialize_nto_tdep): Remove.
7064 * nto-tdep.h (struct nto_inferior_data): Add initializers.
7065
f37b313d
TT
70662019-05-08 Tom Tromey <tom@tromey.com>
7067
7068 * ada-lang.c (struct ada_inferior_data): Add initializers.
7069 (ada_inferior_data): Change type.
7070 (ada_inferior_data_cleanup): Remove.
7071 (get_ada_inferior_data, ada_inferior_exit)
7072 (struct ada_pspace_data): Add initializers, destructor.
7073 (ada_pspace_data_handle): Change type.
7074 (get_ada_pspace_data): Update.
7075 (ada_pspace_data_cleanup): Remove.
7076
24699405
TT
70772019-05-08 Tom Tromey <tom@tromey.com>
7078
7079 * coffread.c (struct coff_symfile_info): Add initializers.
7080 (coff_objfile_data_key): Move lower. Change type.
7081 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7082 Update.
7083 (coff_free_info): Remove.
7084
d4e05d2f
TT
70852019-05-08 Tom Tromey <tom@tromey.com>
7086
7087 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7088 (fbsd_pspace_data_handle): Move lower. Change type.
7089 (get_fbsd_pspace_data): Update.
7090 (fbsd_pspace_data_cleanup): Remove.
7091 (_initialize_fbsd_tdep): Update.
7092
14ef6690
TT
70932019-05-08 Tom Tromey <tom@tromey.com>
7094
7095 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7096 (get_ada_tasks_pspace_data): Update.
7097 (ada_tasks_pspace_data_cleanup): Remove.
7098 (_initialize_tasks): Update.
7099 (ada_tasks_inferior_data_handle): Change type.
7100 (get_ada_tasks_inferior_data): Update.
7101 (ada_tasks_inferior_data_cleanup): Remove.
7102 (struct ada_tasks_pspace_data): Add initializers.
7103
814cf43a
TT
71042019-05-08 Tom Tromey <tom@tromey.com>
7105
7106 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7107 * symfile-debug.c (debug_sym_get_probes): Change type.
7108 * stap-probe.c (handle_stap_probe):
7109 (stap_static_probe_ops::get_probes): Change type.
7110 * probe.h (class static_probe_ops) <get_probes>: Change type.
7111 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7112 (parse_probes_in_pspace): Update.
7113 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7114 Update.
7115 (any_static_probe_ops::get_probes): Change type.
7116 * elfread.c (elfread_data): New typedef.
7117 (probe_key): Change type.
7118 (elf_get_probes): Likewise. Update.
7119 (probe_key_free): Remove.
7120 (_initialize_elfread): Update.
7121 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7122 Change type.
7123 (dtrace_process_dof_probe, dtrace_process_dof)
7124 (dtrace_static_probe_ops::get_probe): Change type.
7125
02dc647e
TT
71262019-05-08 Tom Tromey <tom@tromey.com>
7127
7128 * xcoffread.c (struct xcoff_symfile_info): Rename from
7129 coff_symfile_info. Add initializers.
7130 (xcoff_objfile_data_key): Move lower. Change type.
7131 (XCOFF_DATA): Rewrite.
7132 (xcoff_free_info): Remove.
7133 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7134 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7135 (xcoff_initial_scan): Update.
7136
09232438
TT
71372019-05-08 Tom Tromey <tom@tromey.com>
7138
7139 * solib-svr4.c (struct svr4_info): Add initializers and
7140 destructor.
7141 <probes_table>: Now an htab_up.
7142 (solib_svr4_pspace_data): Change type.
7143 (free_probes_table): Simplify.
7144 (~svr4_info): Rename from svr4_pspace_data_cleanup.
7145 (get_svr4_info, probes_table_htab_remove_objfile_probes)
7146 (probes_table_remove_objfile_probes, register_solib_event_probe)
7147 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7148 (_initialize_svr4_solib): Update.
7149
7b4a314f
TT
71502019-05-08 Tom Tromey <tom@tromey.com>
7151
7152 * remote.c (remote_pspace_data): Change type.
7153 (remote_pspace_data_cleanup): Remove.
7154 (get_remote_exec_file, set_pspace_remote_exec_file)
7155 (_initialize_remote): Update.
7156
51d3063a
TT
71572019-05-08 Tom Tromey <tom@tromey.com>
7158
7159 * breakpoint.c (breakpoint_objfile_key): Change type.
7160 (get_breakpoint_objfile_data): Update.
7161 (free_breakpoint_objfile_data): Remove.
7162 (_initialize_breakpoint): Update.
7163
89fb8848
TT
71642019-05-08 Tom Tromey <tom@tromey.com>
7165
7166 * linux-tdep.c (struct linux_info): Add initializers.
7167 (linux_inferior_data): Move. Change type.
7168 (invalidate_linux_cache_inf): Update.
7169 (linux_inferior_data_cleanup): Remove.
7170 (get_linux_inferior_data, _initialize_linux_tdep): Update.
7171
e9b89e2d
TT
71722019-05-08 Tom Tromey <tom@tromey.com>
7173
7174 * auxv.c (auxv_inferior_data): Move. Change type.
7175 (auxv_inferior_data_cleanup): Remove.
7176 (invalidate_auxv_cache_inf): Rewrite.
7177 (get_auxv_inferior_data, _initialize_auxv): Update.
7178
8c42777c
TT
71792019-05-08 Tom Tromey <tom@tromey.com>
7180
7181 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7182 (symfile_debug_objfile_data_key): Change type.
7183 (symfile_debug_installed, debug_qf_has_symbols)
7184 (debug_qf_find_last_source_symtab)
7185 (debug_qf_forget_cached_source_info)
7186 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7187 (debug_qf_print_stats, debug_qf_dump)
7188 (debug_qf_expand_symtabs_for_function)
7189 (debug_qf_expand_all_symtabs)
7190 (debug_qf_expand_symtabs_with_fullname)
7191 (debug_qf_map_matching_symbols)
7192 (debug_qf_expand_symtabs_matching)
7193 (debug_qf_find_pc_sect_compunit_symtab)
7194 (debug_qf_map_symbol_filenames)
7195 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7196 (debug_sym_new_init, debug_sym_init, debug_sym_read)
7197 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7198 (debug_sym_read_linetable, debug_sym_relocate): Update.
7199 (symfile_debug_free_objfile): Remove.
7200 (install_symfile_debug_logging, _initialize_symfile_debug):
7201 Update.
7202
5bfd760d
TT
72032019-05-08 Tom Tromey <tom@tromey.com>
7204
7205 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7206 allocate_on_obstack.
7207 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7208 (get_dwarf2_per_objfile): Update.
7209 (set_dwarf2_per_objfile): Remove.
7210 (dwarf2_has_info, dwarf2_get_section_info): Update.
7211 (dwarf2_free_objfile): Remove.
7212 (_initialize_dwarf2_read): Update.
7213
e85e19b4
TT
72142019-05-08 Tom Tromey <tom@tromey.com>
7215
7216 * auto-load.c (struct auto_load_pspace_info): Add destructor and
7217 initializers.
7218 <unsupported_script_warning_printed,
7219 script_not_found_warning_printed>: Now bool.
7220 (auto_load_pspace_data): Change type.
7221 (~auto_load_pspace_info): Rename from
7222 auto_load_pspace_data_cleanup.
7223 (get_auto_load_pspace_data, init_loaded_scripts_info)
7224 (clear_section_scripts, maybe_print_unsupported_script_warning)
7225 (maybe_print_script_not_found_warning, _initialize_auto_load):
7226 Update.
7227
f6aa7436
TT
72282019-05-08 Tom Tromey <tom@tromey.com>
7229
7230 * objfiles.c (objfile_pspace_info): Add destructor and
7231 initializers.
7232 (objfiles_pspace_data): Change type.
7233 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7234 (get_objfile_pspace_data): Update.
7235 (objfiles_bfd_data): Change type.
7236 (get_objfile_bfd_data): Update.
7237 (objfile_bfd_data_free, _initialize_objfiles): Remove.
7238
6ae614f6
TT
72392019-05-08 Tom Tromey <tom@tromey.com>
7240
7241 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7242 Change type.
7243 (get_catch_syscall_inferior_data): Update.
7244 (catch_syscall_inferior_data_cleanup): Remove.
7245 (_initialize_break_catch_syscall): Update.
7246
6509b8eb
TT
72472019-05-08 Tom Tromey <tom@tromey.com>
7248
7249 * inflow.c (struct terminal_info): Add destructor and
7250 initializers.
7251 (inflow_inferior_data): Change type.
7252 (~terminal_info): Rename from inflow_inferior_data_cleanup.
7253 (get_inflow_inferior_data, inflow_inferior_exit)
7254 (swap_terminal_info, _initialize_inflow): Update.
7255
35632941
TT
72562019-05-08 Tom Tromey <tom@tromey.com>
7257
7258 * target-dcache.c (target_dcache_cleanup): Remove.
7259 (target_dcache_aspace_key): Change type.
7260 (target_dcache_init_p, target_dcache_invalidate)
7261 (target_dcache_get, target_dcache_get_or_init)
7262 (_initialize_target_dcache): Update.
7263 * dcache.h (struct dcache_deleter): New.
7264
3017b94d
TT
72652019-05-08 Tom Tromey <tom@tromey.com>
7266
7267 * symtab.c (struct symbol_cache): Add destructor and
7268 initializers.
7269 (symbol_cache_key): Move. Change type.
7270 (make_symbol_cache, free_symbol_cache): Remove.
7271 (get_symbol_cache): Update.
7272 (symbol_cache_cleanup): Remove.
7273 (ALL_PSPACES, symbol_cache_flush)
7274 (maintenance_print_symbol_cache)
7275 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7276 Update.
7277
a32ad8c5
TT
72782019-05-08 Tom Tromey <tom@tromey.com>
7279
7280 * symtab.c (struct main_info): Add destructor and initializers.
7281 (main_progspace_key): Move. Change type.
7282 (get_main_info): Update.
7283 (main_info_cleanup): Remove.
7284 (_initialize_symtab): Update.
7285
5f6e90a0
TT
72862019-05-08 Tom Tromey <tom@tromey.com>
7287
7288 * registry.h (DECLARE_REGISTRY): Define the _key class.
7289
1bd0c6e4
AB
72902019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
7291
7292 * NEWS: Merge two 'New commands' sections.
7293
2228ef77
XR
72942019-05-08 Joel Brobecker <brobecker@adacore.com>
7295
7296 * ada-valprint.c (ada_val_print_gnat_array): Remove language
7297 parameter and use Ada language definition instead.
7298 (ada_val_print_ptr): Remove unused language parameter.
7299 (ada_val_print_num): Remove language parameter and use Ada language
7300 definition instead.
7301 (ada_val_print_enum, ada_val_print_flt): Remove unused language
7302 parameter.
7303 (ada_val_print_struct_union, ada_val_print_ref): Remove language
7304 parameter and use Ada language definition instead.
7305 (ada_val_print_1): Update all ada_val_print_xxx calls.
7306 Remove language parameter.
7307 (ada_val_print): Update ada_val_print_1 call.
7308
60fcc1c3
TT
73092019-05-08 Tom Tromey <tromey@adacore.com>
7310
7311 * remote.c (remote_hw_watchpoint_limit)
7312 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7313 Now static.
7314
ed2b7c17
TT
73152019-05-08 Tom Tromey <tromey@adacore.com>
7316
7317 * maint.c (_initialize_maint_cmds): Move initialization code to
7318 remote.c.
7319 (watchdog, show_watchdog): Move to remote.c.
7320 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
7321 "watchdog" static.
7322 (_initialize_remote): Move initialization code from maint.c.
7323 * defs.h (watchdog): Don't declare.
7324
b0be6c91
TT
73252019-05-08 Tom Tromey <tromey@adacore.com>
7326
7327 * tui/tui-interp.c: Include main.h.
7328 * interps.c: Include main.h.
7329 * main.h (interpreter_p): Declare.
7330 * defs.h (interpreter_p): Don't declare.
7331
587ee17b
TT
73322019-05-08 Tom Tromey <tromey@adacore.com>
7333
7334 * dwarf2loc.c: Include dwarf2read.h.
7335 * defs.h (read_unsigned_leb128): Don't declare.
7336 * dwarf2read.h (read_unsigned_leb128): Declare.
7337
ca1df239
TT
73382019-05-08 Tom Tromey <tromey@adacore.com>
7339
7340 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7341 method.
7342
99f20f08
TT
73432019-05-08 Tom Tromey <tromey@adacore.com>
7344
7345 * utils.c (fputs_maybe_filtered): Reset style after paging, even
7346 when no wrap column is set.
7347
80e55b13
TT
73482019-05-08 Tom Tromey <tromey@adacore.com>
7349
7350 * c-lang.c (c_get_string): Handle non-C-style arrays.
7351
9d3421af
TT
73522019-05-08 Tom Tromey <tromey@adacore.com>
7353
7354 * typeprint.c (print_offset_data::update): Print the bit offset,
7355 not the number of bits remaining.
7356
844333e2
TT
73572019-05-08 Tom Tromey <tromey@adacore.com>
7358
7359 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7360 padding at end of comment.
7361
988915ee
TT
73622019-05-08 Tom Tromey <tromey@adacore.com>
7363
7364 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7365 Compare main types.
7366
26bfd823
TT
73672019-05-06 Tom Tromey <tom@tromey.com>
7368
7369 * common/scoped_mmap.c: Include common-defs.h.
7370 * common/scoped_mmap.h: Don't include config.h.
7371
89055eaa
TT
73722019-05-04 Tom Tromey <tom@tromey.com>
7373
7374 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7375 (struct aarch64_call_info): Add initializers.
7376 <si>: Now a std::vector.
7377 (pass_on_stack, aarch64_push_dummy_call): Update.
7378
5da01df5
TT
73792019-05-04 Simon Marchi <simon.marchi@efficios.com>
7380 Tom Tromey <tom@tromey.com>
7381
7382 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7383 (ppc_threads): Now a std::vector. Now static.
7384 (hwdebug_find_thread_points_by_tid)
7385 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7386 Update.
7387
fbdf05a1
TT
73882019-05-04 Tom Tromey <tom@tromey.com>
7389
7390 * arc-tdep.c (arc_tdesc_init): Return bool.
7391
06d16ec9
TT
73922019-05-04 Tom Tromey <tom@tromey.com>
7393
7394 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7395 Use gdb_assert_not_reached.
7396
9c056022
TT
73972019-05-04 Tom Tromey <tom@tromey.com>
7398
7399 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7400 "false".
7401
fa9c2a59
TT
74022019-05-04 Tom Tromey <tom@tromey.com>
7403
7404 * arc-tdep.c (arc_tdesc_init): Use bool.
7405
e2eb806a
TT
74062019-05-04 Tom Tromey <tom@tromey.com>
7407
7408 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7409
6fe87677
TT
74102019-05-04 Tom Tromey <tom@tromey.com>
7411
7412 * cli/cli-cmds.c (valid_command_p): Return bool.
7413
7f008c9e
TT
74142019-05-04 Tom Tromey <tom@tromey.com>
7415
7416 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7417 * command.h (valid_user_defined_cmd_name_p): Channge return type.
7418
b6484282
RT
74192019-05-04 Raul Tambre <raul@tambre.ee>
7420
7421 * python/lib/gdb/prompt.py (_ExtendedPrompt)
7422 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7423 operator for comparison.
7424
af97b416
TT
74252019-05-04 Tom Tromey <tom@tromey.com>
7426
7427 * psymtab.c (psymbol_name_matches, match_partial_symbol)
7428 (lookup_partial_symbol, print_partial_symbols)
7429 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7430 (psymbol_compare): Update.
7431 (add_psymbol_to_bcache): Clear the entire psymbol.
7432 (maintenance_check_psymtabs): Update.
7433 * psympriv.h (struct partial_symbol): Don't derive from
7434 general_symbol_info.
7435 <obj_section, unrelocated_address, address,
7436 set_unrelocated_address>: Update.
7437 <ginfo>: New member.
7438 * dwarf-index-write.c (write_psymbols, debug_names::insert)
7439 (debug_names::write_psymbols): Update.
7440
9d6d4be8
TV
74412019-05-04 Tom de Vries <tdevries@suse.de>
7442
7443 * contrib/cc-with-tweaks.sh: Support -n arg.
7444
66452beb
PW
74452019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7446
7447 * corelow.c (core_target::detach): Ensure frame cache and
7448 register caches are cleared.
7449 inferior.c (exit_inferior_1): Likewise.
7450
bde09ab7
TT
74512019-05-03 Sandra Loosemore <sandra@codesourcery.com>
7452 Tom Tromey <tom@tromey.com>
7453
7454 * dictionary.c (collate_pending_symbols_by_language): Remove
7455 "struct" from foreach.
7456 * symtab.c (lookup_global_symbol_from_objfile)
7457 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7458 foreach.
7459 * ser-tcp.c (net_open): Remove "struct" from foreach.
7460 * objfiles.c (objfile_relocate, objfile_rebase)
7461 (objfile_has_symbols): Remove "struct" from foreach.
7462 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7463 from foreach.
7464 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7465 foreach.
7466 * darwin-nat.c (thread_info_from_private_thread_info): Remove
7467 "struct" from foreach.
7468 * ada-lang.c (create_excep_cond_exprs)
7469 (ada_exception_catchpoint_cond_string): Remove "struct" from
7470 foreach.
7471
222a8d25
TT
74722019-05-03 Tom Tromey <tromey@adacore.com>
7473
7474 * ada-exp.y (convert_char_literal): Check suffix of each
7475 enumerator.
7476
fcd60b84
DP
74772019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
7478
7479 PR ada/21406:
7480 * ada-exp.y (yywrap): Don't define.
7481 * ada-lex.l (%option): Add noyywrap
7482 (yywrap): Remove.
7483
5f2459c2
EZ
74842019-05-03 Eli Zaretskii <eliz@gnu.org>
7485
353ea2d1
EZ
7486 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7487 _WIN32_WINNT to the XP level, unless already defined to a higher
7488 level.
7489
7490 * unittests/parse-connection-spec-selftests.c:
7491 * ser-tcp.c:
7492 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
7493 override.
7494
5f2459c2
EZ
7495 * symfile.c (find_separate_debug_file): Remove colon from the
7496 drive spec of DOS/Windows file names of the target, so that the
7497 file name produced from DEBUGDIR and the target's directory will
7498 be valid on DOS/Windows systems.
7499
80062eb9
AB
75002019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
7501
7502 * rust-lang.c (val_print_struct): Handle printing structures
7503 containing strings.
7504
b8c05e85
TT
75052019-05-02 Tom Tromey <tromey@adacore.com>
7506
7507 * valarith.c (_initialize_valarith): Remove.
7508
4504bbde
TT
75092019-05-01 Tom Tromey <tromey@adacore.com>
7510
7511 * ada-lang.c (ada_value_primitive_field): Treat more fields as
7512 bitfields.
7513
d48e62f4
TT
75142019-05-01 Tom Tromey <tromey@adacore.com>
7515
7516 * ada-lang.c (ada_value_assign): Correctly compute starting offset
7517 for big-endian copies.
7518
15f18d14
AT
75192019-04-30 Ali Tamur <tamur@google.com>
7520 * gdb/dwarf2read.c (read_3_bytes): New declaration.
7521 (read_attribute_value): Added DW_FORM_strx1-4 cases.
7522 (read_3_bytes): New function.
7523
ab4ee614
JB
75242019-04-30 Joel Brobecker <brobecker@adacore.com>
7525
7526 * windows-nat.c (main_thread_id): Delete.
7527 (handle_output_debug_string): Replace main_thread_id by
7528 current_event.dwThreadId.
7529 (fake_create_process): Likewise.
7530 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7531 Do not set main_thread_id.
7532 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7533 current_event.dwThreadId.
7534 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7535
8ed5b76e
JB
75362019-04-30 Joel Brobecker <brobecker@adacore.com>
7537
7538 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7539 Use current_event.dwThreadId instead of main_thread_id.
7540
2ff0a947
TT
75412019-04-30 Tom Tromey <tromey@adacore.com>
7542
7543 * ada-lang.c (ada_lookup_simple_minsyms): New function.
7544 (create_excep_cond_exprs): Iterate over program spaces.
7545 (ada_exception_catchpoint_cond_string): Examine all minimal
7546 symbols for exception types.
7547
a776957c
TT
75482019-04-30 Tom Tromey <tromey@adacore.com>
7549
7550 PR c++/24470:
7551 * dwarf2read.c (process_structure_scope): Handle case where type
7552 has template parameters but no symbol was created.
7553
bc68014d
AB
75542019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7555 Chris January <chris.january@arm.com>
7556
7557 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7558 qualifier.
7559 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7560
f1fdc960
AB
75612019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7562
7563 * f-typeprint.c (f_print_type): Update rules for printing
7564 whitespace.
7565 (f_type_print_varspec_suffix): Likewise.
7566
bf7a4de1
AB
75672019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7568 Chris January <chris.january@arm.com>
7569
7570 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7571 function arguments.
7572
bbe75b9d
AB
75732019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7574
7575 * f-lang.c (build_fortran_types): Change name of void type to
7576 lower case.
7577 * f-typeprint.c (f_type_print_base): Print the name of the void
7578 type, rather than a fixed string.
7579 * f-valprint.c (f_decorations): Use lower case void string.
7580
1db455a7
AB
75812019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7582 Chris January <chris.january@arm.com>
7583
7584 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7585 types for Fortran.
7586
b6d03bb2
AB
75872019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7588 Chris January <chris.january@arm.com>
7589 David Lecomber <david.lecomber@arm.com>
7590
7591 * f-exp.y (BINOP_INTRINSIC): New token.
7592 (exp): New parser rule handling BINOP_INTRINSIC.
7593 (f77_keywords): Add new builtin procedures.
7594 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7595 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7596 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7597 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7598 (print_unop_subexp_f): New function.
7599 (print_binop_subexp_f): New function.
7600 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7601 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7602 (dump_subexp_body_f): Likewise.
7603 (operator_check_f): Likewise.
7604 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7605 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7606
83228e93
AB
76072019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7608
7609 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7610 UNOP_KIND.
7611 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7612 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7613 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7614 (operator_length_f): New fuction.
7615 (print_subexp_f): New function.
7616 (op_name_f): New function.
7617 (dump_subexp_body_f): New function.
7618 (operator_check_f): New function.
7619 (exp_descriptor_f): Replace standard expression handling functions
7620 with new functions.
7621 * gdb/fortran-operator.def: New file.
7622 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7623 * gdb/std-operator.def: Remove UNOP_KIND.
7624
6fdcd7cc
AB
76252019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
7626
7627 * std-operator.def: Remove unbalanced, stray double quote
7628 character.
7629
2e62ab40
AB
76302019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7631 Chris January <chris.january@arm.com>
7632 Daniel Everett <daniel.everett@arm.com>
7633 Nick Forrington <nick.forrington@arm.com>
7634 Richard Bunt <richard.bunt@arm.com>
7635
7636 * cp-valprint.c (cp_print_value_fields): Allow an additional level
7637 of depth when printing anonymous structs or unions.
7638 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7639 Don't print either the top-level value, or the children if the
7640 max-depth is exceeded.
7641 (ppscm_print_children): When printing the key of a map, allow one
7642 extra level of depth.
7643 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7644 print either the top-level value, or the children if the max-depth
7645 is exceeded.
7646 (print_children): When printing the key of a map, allow one extra
7647 level of depth.
7648 * python/py-value.c (valpy_format_string): Add max_depth keyword.
7649 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7650 (user_print_options): Initialise max_depth field.
7651 (val_print_scalar_or_string_type_p): New function.
7652 (val_print): Check to see if the max depth has been reached.
7653 (val_print_check_max_depth): Define new function.
7654 (show_print_max_depth): New function.
7655 (_initialize_valprint): Add 'print max-depth' option.
7656 * valprint.h (struct value_print_options) <max_depth>: New field.
7657 (val_print_check_max_depth): Declare new function.
7658 * NEWS: Document new feature.
7659
4be290b2
AB
76602019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7661
7662 * ada-lang.c (ada_language_defn): Initialise new field.
7663 * c-lang.c (c_is_string_type_p): New function.
7664 (c_language_defn): Initialise new field.
7665 (cplus_language_defn): Initialise new field.
7666 (asm_language_defn): Initialise new field.
7667 (minimal_language_defn): Initialise new field.
7668 * c-lang.h (c_is_string_type_p): Declare new function.
7669 * d-lang.c (d_language_defn): Initialise new field.
7670 * f-lang.c (f_is_string_type_p): New function.
7671 (f_language_defn): Initialise new field.
7672 * go-lang.c (go_is_string_type_p): New function.
7673 (go_language_defn): Initialise new field.
7674 * language.c (default_is_string_type_p): New function.
7675 (unknown_language_defn): Initialise new field.
7676 (auto_language_defn): Initialise new field.
7677 * language.h (struct language_defn) <la_is_string_type_p>: New
7678 member variable.
7679 (default_is_string_type_p): Declare new function.
7680 * m2-lang.c (m2_language_defn): Initialise new field.
7681 * objc-lang.c (objc_language_defn): Initialise new field.
7682 * opencl-lang.c (opencl_language_defn): Initialise new field.
7683 * p-lang.c (pascal_is_string_type_p): New function.
7684 (pascal_language_defn): Initialise new field.
7685 * rust-lang.c (rust_is_string_type_p): New function.
7686 (rust_language_defn): Initialise new field.
7687
721b08c6
AB
76882019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7689
7690 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7691 New field.
7692 * ada-lang.c (ada_language_defn): Initialise new field.
7693 * c-lang.c (c_language_defn): Likewise.
7694 (cplus_language_defn): Likewise.
7695 (asm_language_defn): Likewise.
7696 (minimal_language_defn): Likewise.
7697 * d-lang.c (d_language_defn): Likewise.
7698 * f-lang.c (f_language_defn): Likewise.
7699 * go-lang.c (go_language_defn): Likewise.
7700 * language.c (unknown_language_defn): Likewise.
7701 (auto_language_defn): Likewise.
7702 * m2-lang.c (m2_language_defn): Likewise.
7703 * objc-lang.c (objc_language_defn): Likewise.
7704 * opencl-lang.c (opencl_language_defn): Likewise.
7705 * p-lang.c (pascal_language_defn): Likewise.
7706 * rust-lang.c (rust_language_defn): Likewise.
7707
fc913e53
AB
77082019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
7709
7710 * ada-lang.c (ada_is_character_type): Change return type to bool.
7711 (ada_is_string_type): Likewise.
7712 * ada-lang.h (ada_is_character_type): Update declaration
7713 (ada_is_string_type): Likewise.
7714
fa731fa0
PW
77152019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7716
7717 Support style in 'frame|thread apply'
7718
7719 * gdbcmd.h (execute_command_to_string): New term_out parameter.
7720 * record.c (record_start, record_stop): Update callers of
7721 execute_command_to_string with false.
7722 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7723 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7724 methods.
7725 (class string_file): New constructor with term_out parameter.
7726 Override methods term_out and can_emit_style_escape. New member
7727 term_out.
7728 (class stdio_file): Override can_emit_style_escape.
7729 (class tee_file): Override term_out and can_emit_style_escape.
7730 * utils.h (can_emit_style_escape): Remove.
7731 * utils.c (can_emit_style_escape): Likewise.
7732 Update all callers of can_emit_style_escape (SOMESTREAM) to
7733 SOMESTREAM->can_emit_style_escape.
7734 * source-cache.c (source_cache::get_source_lines): Likewise.
7735 * stack.c (frame_apply_command_count): Call execute_command_to_string
7736 passing the term_out characteristic of the current gdb_stdout.
7737 * thread.c (thr_try_catch_cmd): Likewise.
7738 * top.c (execute_command_to_string): pass term_out parameter
7739 to construct the string_file for the command output.
7740 * ui-file.c (term_cli_styling): New function (most code moved
7741 from utils.c can_emit_style_escape).
7742 (string_file::string_file, string_file::can_emit_style_escape,
7743 stdio_file::can_emit_style_escape, tee_file::term_out,
7744 tee_file::can_emit_style_escape): New functions.
7745
136afab8
PW
77462019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7747
7748 * NEWS: Mention the new set|show may-call-functions.
7749 * infcall.c (may_call_functions_p): New variable.
7750 (show_may_call_functions_p): New function.
7751 (call_function_by_hand_dummy): Throws an error if not
7752 may-call-functions.
7753 (_initialize_infcall): Call add_setshow_boolean_cmd for
7754 may-call-functions.
7755
725cbb63
KS
77562019-04-25 Keith Seitz <keiths@redhat.com>
7757
7758 PR c++/24367
7759 * cp-support.c (inspect_type): Don't attempt substitutions
7760 of symbol with the same name.
7761
3d1cbb78
TT
77622019-04-25 Tom Tromey <tromey@adacore.com>
7763
7764 PR gdb/24475:
7765 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7766 static.
7767
94aeb44b
TT
77682019-04-25 Tom Tromey <tromey@adacore.com>
7769
7770 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7771 rvalue reference.
7772 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7773 (gdb_xml_parser::parse): Use std::move.
7774 * python/python-internal.h (gdbpy_convert_exception): Take a const
7775 reference.
7776 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7777 std::move.
7778 * python/py-utils.c (gdbpy_convert_exception): Take a const
7779 reference.
7780 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7781 Use std::move.
7782 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7783 Use std::move.
7784 * mi/mi-main.c (mi_print_exception): Take a const reference.
7785 * main.c (handle_command_errors): Take a const reference.
7786 * linespec.c (parse_linespec): Use std::move.
7787 * infcall.c (run_inferior_call): Use std::move.
7788 (call_function_by_hand_dummy): Use std::move.
7789 * exec.c (try_open_exec_file): Use std::move.
7790 * exceptions.h (exception_print, exception_fprintf)
7791 (exception_print_same): Update.
7792 * exceptions.c (print_exception, exception_print)
7793 (exception_fprintf, exception_print_same): Change parameters to
7794 const reference.
7795 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7796 * common/new-op.c: Use std::move.
7797 * common/common-exceptions.h (struct gdb_exception): Add move
7798 constructor.
7799 (struct gdb_exception_error, struct gdb_exception_quit, struct
7800 gdb_quit_bad_alloc): Change constructor to move constructor.
7801 (throw_exception): Change parameter to rvalue reference.
7802 * common/common-exceptions.c (throw_exception): Take rvalue
7803 reference.
7804 * cli/cli-interp.c (safe_execute_command): Use std::move.
7805 * breakpoint.c (insert_bp_location, location_to_sals): Use
7806 std::move.
7807
680d7fd5
TT
78082019-04-25 Tom Tromey <tromey@adacore.com>
7809
7810 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7811 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7812 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7813 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7814 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7815 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7816 guile/scm-value.c: Use unpack.
7817 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7818 gdbscm_gdb_exception.
7819 (gdbscm_throw_gdb_exception): Likewise.
7820 (struct gdbscm_gdb_exception): New.
7821 (unpack): New function.
7822 (gdbscm_wrap): Use unpack.
7823
c6fdd8b2
TT
78242019-04-25 Tom Tromey <tromey@adacore.com>
7825
7826 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7827 (gdb_rl_callback_handler): Use std::move.
7828 * common/common-exceptions.h (struct gdb_exception): Add move
7829 assignment operator.
7830 (throw_exception_sjlj): Change "exception" to const reference.
7831 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7832 (throw_exception_sjlj): Change "exception" to const reference.
7833
cc06b668
TT
78342019-04-25 Tom Tromey <tromey@adacore.com>
7835
7836 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7837 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7838 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7839 Update.
7840 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7841 Update.
7842 * mi/mi-interp.c (mi_interp::exec): Update.
7843 * linespec.c (parse_linespec): Update.
7844 * infcall.c (run_inferior_call): Update.
7845 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7846 * guile/scm-symbol.c (gdbscm_lookup_symbol)
7847 (gdbscm_lookup_global_symbol): Update.
7848 * guile/scm-param.c (gdbscm_parameter_value): Update.
7849 * guile/scm-frame.c (gdbscm_frame_read_register)
7850 (gdbscm_frame_read_var): Update.
7851 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7852 * exec.c (try_open_exec_file): Update.
7853 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7854 (gdb_rl_callback_handler): Update.
7855 * common/common-exceptions.h (exception_none): Don't declare.
7856 * common/common-exceptions.c (exception_none): Don't define.
7857 (struct catcher) <exception>: Update.
7858 * cli/cli-interp.c (safe_execute_command): Update.
7859 * breakpoint.c (insert_bp_location, location_to_sals): Update.
7860
cf532bd1
AT
78612019-04-25 Ali Tamur <tamur@google.com>
7862
7863 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7864 (read_attribute_value): Likewise.
7865 (dwarf2_read_addr_index): Update comment.
7866 (read_str_index): Add DW_FORM_strx.
7867 (dwarf2_string_attr): Likewise.
7868 (dwarf2_const_value_attr): Likewise.
7869 (dump_die_shallow): Likewise.
7870 (dwarf2_fetch_constant_bytes): Likewise.
7871 (skip_form_bytes): Likewise.
7872 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7873
82433e3e
SDJ
78742019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
7875
7876 PR corefiles/11608
7877 PR corefiles/18187
7878 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7879 OFFSET. Verify if current mapping contains an ELF header.
7880 (linux_find_memory_regions_full): Adjust call to
7881 dump_mapping_p.
7882
723adb65
SL
78832019-04-25 Sandra Loosemore <sandra@codesourcery.com>
7884 Kang Li <kanglictf@gmail.com>
7885
7886 PR gdb/21600
7887
7888 * dwarf2-frame.c (read_initial_length): Be consistent about using
7889 unsigned representation of length.
7890 (decode_frame_entry_1): Likewise. Check for wraparound of
7891 end pointer as well as buffer overflow.
7892
596179f7
SDJ
78932019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
7894
7895 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7896 "vq".
7897
a59240a4
TT
78982019-04-24 Tom Tromey <tromey@adacore.com>
7899
7900 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7901
f872fdbb
AB
79022019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7903
7904 * s12z-tdep.c (s12z_unwind_pc): Delete.
7905 (s12z_unwind_sp): Delete.
7906 (s12z_gdbarch_init): Don't register deleted functions with
7907 gdbarch.
7908
b614e6f3
AB
79092019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7910
7911 * rl78-tdep.c (rl78_unwind_sp): Delete.
7912 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7913
14faed38
AB
79142019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7915
7916 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7917 (xstormy16_unwind_pc): Delete.
7918 (xstormy16_dummy_id): Delete.
7919 (xstormy16_gdbarch_init): Don't register deleted functions with
7920 gdbarch.
7921
541aad8a
AB
79222019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7923
7924 * vax-tdep.c (vax_unwind_pc): Delete.
7925 (vax_gdbarch_init): Don't register deleted function with gdbarch.
7926
29222070
AB
79272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7928
7929 * v850-tdep.c (v850_unwind_sp): Delete.
7930 (v850_unwind_pc): Delete.
7931 (v850_dummy_id): Delete.
7932 (v850_gdbarch_init): Don't register deleted functions with
7933 gdbarch.
7934
0f534d76
AB
79352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7936
7937 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7938 (tilegx_unwind_pc): Delete.
7939 (tilegx_unwind_dummy_id): Delete.
7940 (tilegx_gdbarch_init): Don't register deleted functions with
7941 gdbarch.
7942
1ba7b7f9
AB
79432019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7944
7945 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7946 (tic6x_dummy_id): Delete.
7947 (tic6x_gdbarch_init): Don't register deleted functions with
7948 gdbarch.
7949
d31f262c
AB
79502019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7951
7952 * sparc-tdep.c (sparc_unwind_pc): Delete.
7953 (sparc32_gdbarch_init): Don't register deleted function with
7954 gdbarch.
7955
6d14d64d
AB
79562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7957
7958 * sh-tdep.c (sh_unwind_sp): Delete.
7959 (sh_unwind_pc): Delete.
7960 (sh_dummy_id): Delete.
7961 (sh_gdbarch_init): Don't register deleted functions with
7962 gdbarch.
7963
a40dde9d
AB
79642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7965
7966 * score-tdep.c (score_unwind_sp): Delete.
7967 (score_unwind_pc): Delete.
7968 (score_dummy_id): Delete.
7969 (score_gdbarch_init): Don't register deleted functions with
7970 gdbarch.
7971
47c47d69
AB
79722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7973
7974 * rx-tdep.c (rx_unwind_pc): Delete.
7975 (rx_unwind_sp): Delete.
7976 (rx_dummy_id): Delete.
7977 (rx_gdbarch_init): Don't register deleted functions with
7978 gdbarch. Update comment.
7979
833a4480
AB
79802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7981
7982 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7983 (rs6000_dummy_id): Delete.
7984 (rs6000_gdbarch_init): Don't register deleted functions with
7985 gdbarch.
7986
3f2cef49
AB
79872019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7988
7989 * or1k-tdep.c (or1k_dummy_id): Delete.
7990 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7991
96acf884
AB
79922019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7993
7994 * nios2-tdep.c (nios2_dummy_id): Delete.
7995 (nios2_unwind_sp): Delete.
7996 (nios2_gdbarch_init): Don't register deleted functions with
7997 gdbarch.
7998
ca0ab0aa
AB
79992019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8000
8001 * nds32-tdep.c (nds32_dummy_id): Delete.
8002 (nds32_unwind_pc): Delete.
8003 (nds32_unwind_sp): Delete.
8004 (nds32_gdbarch_init): Don't register deleted functions with
8005 gdbarch.
8006
c8259044
AB
80072019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8008
8009 * msp430-tdep.c (msp430_unwind_pc): Delete.
8010 (msp430_unwind_sp): Delete.
8011 (msp430_dummy_id): Delete.
8012 (msp430_gdbarch_init): Don't register deleted functions with
8013 gdbarch.
8014
27f113c8
AB
80152019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8016
8017 * moxie-tdep.c (moxie_unwind_sp): Delete.
8018 (moxie_unwind_pc): Delete.
8019 (moxie_dummy_id): Delete.
8020 (moxie_gdbarch_init): Don't register deleted functions with
8021 gdbarch.
8022
aee6c3cd
AB
80232019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8024
8025 * mn10300-tdep.c (mn10300_dummy_id): Delete.
8026 (mn10300_unwind_pc): Delete.
8027 (mn10300_unwind_sp): Delete.
8028 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8029 mn10300_unwind_sp.
8030 (mn10300_frame_unwind_init): Don't register deleted functions with
8031 gdbarch.
8032
8e2b5aea
AB
80332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8034
8035 * mep-tdep.c (mep_unwind_pc): Delete.
8036 (mep_unwind_sp): Delete.
8037 (mep_dummy_id): Delete.
8038 (mep_gdbarch_init): Don't register deleted functions with
8039 gdbarch.
8040
43cf3ede
AB
80412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8042
8043 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8044 (m68hc11_unwind_sp): Delete.
8045 (m68hc11_gdbarch_init): Don't register deleted functions with
8046 gdbarch.
8047
5e79b7bb
AB
80482019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8049
8050 * m32r-tdep.c (m32r_unwind_sp): Delete.
8051 (m32r_unwind_pc): Delete.
8052 (m32r_dummy_id): Delete.
8053 (m32r_gdbarch_init): Don't register deleted functions with
8054 gdbarch.
8055
89b268d8
AB
80562019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8057
8058 * m32c-tdep.c (m32c_unwind_pc): Delete.
8059 (m32c_unwind_sp): Delete.
8060 (m32c_dummy_id): Delete.
8061 (m32c_gdbarch_init): Don't register deleted functions with
8062 gdbarch.
8063
946c28d2
AB
80642019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8065
8066 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8067 (lm32_unwind_pc): Delete.
8068 (lm32_dummy_id): Delete.
8069 (lm32_gdbarch_init): Don't register deleted functions with
8070 gdbarch.
8071
bf12844a
AB
80722019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8073
8074 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8075 (iq2000_unwind_pc): Delete.
8076 (iq2000_dummy_id): Delete.
8077 (iq2000_gdbarch_init): Don't register deleted functions with
8078 gdbarch.
8079
ecbc06d2
AB
80802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8081
8082 * nds32-tdep.c (nds32_type_align): Delete.
8083 (nds32_push_dummy_call): Use type_align instead.
8084
030197b4
AB
80852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8086
8087 * arm-tdep.c (arm_type_align): Only handle vector override case.
8088 (arm_push_dummy_call): Use type_align.
8089 (arm_gdbarch_init): Register arm_type_align gdbarch function.
8090
b907456c
AB
80912019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
8092
8093 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8094 case.
8095 (pass_on_stack): Use type_align.
8096 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8097 function.
8098
9e97ba43
TT
80992019-04-23 Tom Tromey <tromey@adacore.com>
8100
8101 * dwarf2read.c (line_header::file_name_at): Remove unused
8102 overload.
8103
6892f601
TV
81042019-04-23 Tom de Vries <tdevries@suse.de>
8105
8106 PR gdb/24438
8107 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8108 invocation.
8109
336d760d
AT
8110
81112019-03-27 Ali Tamur <tamur@google.com>
8112
8113 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8114 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8115 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8116 (dwarf_expr_context::get_addr_index): Likewise
8117 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8118 (symbol_needs_eval_context::get_addr_index): Likewise
8119 (disassemble_dwarf_expression): Add DW_OP_addrx
8120 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8121 (read_cutu_die_from_dwo): Update comment
8122 (skip_one_die): Add DW_FORM_addrx
8123 (read_attribute_value): Likewise
8124 (var_decode_location): Add DW_OP_addrx
8125 (dwarf2_const_value_attr): Add DW_FORM_addrx
8126 (dump_die_shallow): Likewise
8127 (dwarf2_fetch_constant_bytes): Likewise
8128 (decode_locdesc): Add DW_OP_addrx
8129 (skip_form_bytes): Add DW_FORM_addrx
8130
ad9d13f8
AT
81312019-04-22 Ali Tamur <tamur@google.com>
8132
8133 * MAINTAINERS (Write After Approval): Add self.
8134
d70cc3ba
SM
81352019-04-22 Simon Marchi <simon.marchi@efficios.com>
8136
8137 * solib-svr4.c (get_svr4_info): Add pspace parameter.
8138 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8139 (open_symbol_file_object): Likewise.
8140 (svr4_default_sos): Add info parameter.
8141 (svr4_read_so_list): Likewise.
8142 (svr4_current_sos_direct): Adjust functions calls to pass down
8143 info.
8144 (svr4_current_sos_1): Add info parameter.
8145 (svr4_current_sos): Call get_svr4_info, pass info down to
8146 svr4_current_sos_1.
8147 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8148 get_svr4_info.
8149 (svr4_in_dynsym_resolve_code): Pass current_program_space to
8150 get_svr4_info.
8151 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8152 to get_svr4_info.
8153 (probes_table_remove_objfile_probes): Likewise.
8154 (register_solib_event_probe): Add info parameter.
8155 (solist_update_incremental): Pass info parameter down to
8156 svr4_read_so_list.
8157 (disable_probes_interface): Add info parameter.
8158 (svr4_handle_solib_event): Pass current_program_space to
8159 get_svr4_info. Adjust disable_probes_interface cleanup.
8160 (svr4_create_probe_breakpoints): Add info parameter, pass it
8161 down to register_solib_event_probe.
8162 (svr4_create_solib_event_breakpoints): Add info parameter,
8163 pass it down to svr4_create_probe_breakpoints.
8164 (enable_break): Pass info down to
8165 svr4_create_solib_event_breakpoints.
8166 (svr4_solib_create_inferior_hook): Pass current_program_space to
8167 get_svr4_info.
8168 (svr4_clear_solib): Likewise.
8169
7905fc35
PA
81702019-04-22 Pedro Alves <palves@redhat.com>
8171
8172 * solib-svr4.c (svr4_free_objfile_observer): New.
8173 (probe_and_action::objfile): New field.
8174 (probes_table_htab_remove_objfile_probes)
8175 (probes_table_remove_objfile_probes): New functions.
8176 (register_solib_event_probe): Add 'objfile' parameter. Store it
8177 in the new probe_and_action. Don't store the probe in 'lookup'.
8178 (svr4_create_probe_breakpoints): Pass objfile to
8179 register_solib_event_probe.
8180 (_initialize_svr4_solib): Register a free_objfile observer.
8181
fb881986
TT
81822019-04-19 Tom Tromey <tom@tromey.com>
8183
8184 * common/queue.h: Remove.
8185
8732db6c
TT
81862019-04-19 Tom Tromey <tom@tromey.com>
8187
8188 * event-loop.c: Don't include "common/queue.h".
8189
97dfbadd
TT
81902019-04-19 Tom Tromey <tom@tromey.com>
8191
8192 * remote.c (remote_target): Use delete.
8193 * remote-notif.h: Include <list>, not "common/queue.h".
8194 (notif_client_p): Remove typedef.
8195 (remote_notif_state): Add constructor, destructor, initializer.
8196 <notif_queue>: Now a std::list.
8197 (remote_notif_state_xfree): Don't declare.
8198 * remote-notif.c (remote_notif_process, handle_notification)
8199 (remote_notif_state_allocate): Update.
8200 (~remote_notif_state): Rename from remote_notif_state_xfree.
8201
cf250e36
TT
82022019-04-19 Tom Tromey <tom@tromey.com>
8203
8204 * symfile.c (reread_symbols): Update.
8205 * objfiles.c (objfile_register_static_link)
8206 (objfile_lookup_static_link): Update
8207 (~objfile) Don't delete static_links.
8208 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8209
61f4b350
TT
82102019-04-19 Tom Tromey <tom@tromey.com>
8211
8212 * type-stack.h (struct type_stack) <insert>: Constify string.
8213 * type-stack.c (type_stack::insert): Constify string.
8214 * gdbtypes.h (lookup_template_type): Update.
8215 (address_space_name_to_int): Update.
8216 * gdbtypes.c (address_space_name_to_int): Make space_identifier
8217 const.
8218 (lookup_template_type): Make name const.
8219 * c-exp.y: Update rules.
8220 (lex_one_token, classify_name, classify_inner_name)
8221 (c_print_token): Update.
8222 * p-exp.y: Update rules.
8223 (yylex): Update.
8224 * f-exp.y: Update rules.
8225 (yylex): Update.
8226 * d-exp.y: Update rules.
8227 (lex_one_token, classify_name, classify_inner_name): Update.
8228 * parse.c (write_dollar_variable, copy_name): Return std::string.
8229 * parser-defs.h (copy_name): Change return type.
8230 * m2-exp.y: Update rules.
8231 (yylex): Update.
8232 * go-exp.y (lex_one_token): Update.
8233 Update rules.
8234 (classify_unsafe_function, classify_packaged_name)
8235 (classify_name, yylex): Update.
8236
189b8c2e
ST
82372019-04-19 Sergei Trofimovich <siarheit@google.com>
8238
8239 * configure.ac: add --enable-source-highlight switch.
8240 * configure: Regenerate.
8241 * top.c (print_gdb_version): plumb --enable-source-highlight
8242 status to "show configuration".
8243
8ecb59f8
TT
82442019-04-19 Tom Tromey <tromey@adacore.com>
8245
8246 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8247 Check ADA_TYPE_P.
8248 (empty_record, ada_template_to_fixed_record_type_1)
8249 (template_to_static_fixed_type)
8250 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8251 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8252 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8253 macros.
8254
62160ec9
TT
82552019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
8256
8257 PR symtab/24423:
8258 * source.c (print_source_lines_base): Advance "iter" when a
8259 control character is seen.
8260
f2ae8bc8
PW
82612019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8262
8263 * inferior.h (struct infcall_suspend_state_deleter):
8264 Catch exception in destructor to avoid crash.
8265
d563b953
PW
82662019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8267
8268 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8269 close to the add_com "shell".
8270
dc34c897
TT
82712019-04-18 Tom Tromey <tromey@adacore.com>
8272
8273 * process-stratum-target.h (class process_stratum_target)
8274 <stratum>: Add "final".
8275
a12e5744
TT
82762019-04-17 Tom Tromey <tromey@adacore.com>
8277
8278 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8279 against nullptr before use.
8280
a7e559cc
AH
82812019-04-17 Alan Hayward <alan.hayward@arm.com>
8282
8283 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8284
c01660c6
AB
82852019-04-17 Jim Wilson <jimw@sifive.com>
8286 Andrew Burgess <andrew.burgess@embecosm.com>
8287
8288 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8289 code read might fail, assume 4-byte breakpoint in that case.
8290
4aa866af
LS
82912019-04-15 Leszek Swirski <leszeks@google.com>
8292
8293 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8294 rather than a hand-rolled POD check when checking for forced MEMORY
8295 classification.
8296
48574d91
AH
82972019-04-15 Alan Hayward <alan.hayward@arm.com>
8298
8299 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8300 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8301 function.
8302 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8303 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8304 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8305 declaration.
8306
4da037ef
AH
83072019-04-15 Alan Hayward <alan.hayward@arm.com>
8308
8309 * aarch64-linux-nat.c
8310 (aarch64_linux_nat_target::thread_architecture): Add override.
8311 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8312 each VQ.
8313
ccb8d7e8
AH
83142019-04-15 Alan Hayward <alan.hayward@arm.com>
8315
8316 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8317
35add35e
AB
83182019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
8319
8320 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8321 target types of size 96-bits, add some additional comments, and
8322 check that the builtin type we found was the correct size.
8323
51196bbc
EZ
83242019-04-12 Eli Zaretskii <eliz@gnu.org>
8325
8326 * utils.c (prompt_for_continue): Don't restore the styling at the
8327 end, as applied_style has the wrong value. This fixes styling in
8328 long lists of file names that are interrupted by the "Continue?"
8329 prompt.
8330
62253a61
AB
83312019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
8332
8333 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8334 * c-lang.c (c_language_defn): Likewise.
8335 (cplus_language_defn): Likewise.
8336 (asm_language_defn): Likewise.
8337 (minimal_language_defn): Likewise.
8338 * d-lang.c (d_language_defn): Likewise.
8339 * f-lang.c (f_language_defn): Likewise.
8340 * go-lang.c (go_language_defn): Likewise.
8341 * language.c (unknown_language_defn): Likewise.
8342 (auto_language_defn): Likewise.
8343 * language.h (struct language_defn): Remove la_magic field.
8344 (LANG_MAGIC): Delete.
8345 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8346 * objc-lang.c (objc_language_defn): Likewise.
8347 * opencl-lang.c (opencl_language_defn): Likewise.
8348 * p-lang.c (pascal_language_defn): Likewise.
8349 * rust-lang.c (rust_language_defn): Likewise.
8350
a9158a86
AB
83512019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8352
8353 * riscv-tdep.c (riscv_type_align): New function.
8354 (riscv_type_alignment): Delete.
8355 (riscv_arg_location): Use 'type_align'.
8356 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8357
41077b66
AB
83582019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8359
8360 * gdbtypes.c (type_align): A struct with no non-static fields also
8361 has alignment of 1.
8362
9f0272f8
AB
83632019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
8364
8365 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8366 component to 0.
8367 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8368 member.
8369 (riscv_struct_info::analyse): New implementation using new
8370 analyse_inner member function.
8371 (riscv_struct_info::field_offset): New member function.
8372 (riscv_struct_info::m_offsets): New member variable.
8373 (riscv_struct_info::analyse_inner): New private member function,
8374 takes the old implementation of riscv_struct_info::analyse but
8375 extended to track field offsets.
8376 (riscv_call_arg_struct): Update the struct folding special cases
8377 to handle cases where empty C++ structs, which are non-zero
8378 length, are found.
8379 (riscv_arg_location): Initialise the length of each location, a
8380 non-zero length now indicates the location is in use.
8381 (riscv_push_dummy_call): Allow for the first location having a
8382 non-zero offset when setting up arguments.
8383 (riscv_return_value): Likewise, but for return values.
8384
02cf60c7
TT
83852019-04-11 Tom Tromey <tromey@adacore.com>
8386
8387 * utils.c (internal_vproblem): Make "msg" const.
8388
68811f8f
AH
83892019-04-11 Alan Hayward <alan.hayward@arm.com>
8390
8391 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8392 * trad-frame.c (trad_frame_reset_saved_regs): New function.
8393 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8394 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8395
3f52fdbc
KB
83962019-04-10 Kevin Buettner <kevinb@redhat.com>
8397
8398 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8399 function.
8400 (fill_gregset): Call amd64_linux_collect_native_gregset instead
8401 of amd64_collect_native_gregset.
8402 (amd64_linux_nat_target::store_registers): Likewise.
8403
e9ad22ee
TT
84042019-04-10 Tom Tromey <tom@tromey.com>
8405
8406 * symtab.c (lookup_global_symbol_from_objfile)
8407 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8408 * objfiles.h (class separate_debug_iterator): New.
8409 (class separate_debug_range): New.
8410 (struct objfile) <separate_debug_objfiles>: New method.
8411 (objfile_separate_debug_iterate): Don't declare.
8412 * objfiles.c (separate_debug_iterator::operator++): Rename from
8413 objfile_separate_debug_iterate.
8414 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8415 iterator.
8416 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8417 iterator.
8418
ee371134
TT
84192019-04-10 Tom Tromey <tom@tromey.com>
8420
8421 * symfile.c (reread_symbols): Remove old comment.
8422 * objfiles.c (free_all_objfiles): Fix a typo.
8423
bf227d61
TT
84242019-04-10 Tom Tromey <tom@tromey.com>
8425
8426 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8427 * minsyms.c (lookup_minimal_symbol): Use foreach.
8428 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8429 (lookup_minimal_symbol_solib_trampoline): Likewise.
8430 * symfile.c (reread_symbols): Use foreach.
8431
8dc433a0
TT
84322019-04-09 Ivan Begert <ivanbegert@gmail.com>
8433 Tom Tromey <tromey@adacore.com>
8434
8435 PR rust/24414:
8436 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8437 (rust_lex_int_test): Change "value" to be LONGEST.
8438 (rust_lex_tests): Add test for long integer literal.
8439
9ab8741a
TT
84402019-04-09 Tom Tromey <tromey@adacore.com>
8441
8442 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8443 to bool.
8444 (extended_remote_target::attach): Update.
8445 (remote_target::remote_notice_new_inferior): Update.
8446 (remote_target::add_current_inferior_and_thread): Update.
8447 * inferior.c (exit_inferior_1): Use "false".
8448 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8449
e242fd12
SM
84502019-04-09 Simon Marchi <simon.marchi@efficios.com>
8451
9ca1957f 8452 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
8453 the "start" command.
8454
2b0c8b01
KB
84552019-04-08 Kevin Buettner <kevinb@redhat.com>
8456
8457 * python/py-inferior.c (infpy_thread_from_thread_handle):
8458 Adjust comments to reflect renaming of thread_from_thread_handle
8459 to thread_from_handle. Adjust keywords. Fix type error message.
8460 (inferior_object_methods): Add thread_from_handle. Retain
8461 thread_from_thread_handle, but mark it as deprecated.
8462
50a82723
KB
84632019-04-08 Kevin Buettner <kevinb@redhat.com>
8464
8465 * gdbthread.h (find_thread_by_handle): Revise declaration.
8466 * thread.c (find_thread_by_handle): Likewise. Adjust
8467 implementation too.
8468 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8469 support for buffer objects as handles.
8470
cf63b016
KB
84712019-04-08 Kevin Buettner <kevinb@redhat.com>
8472
8473 * python/py-infthread.c (thpy_thread_handle): New function.
8474 (thread_object_methods): Register thpy_thread_handle.
8475
3d6c6204
KB
84762019-04-08 Kevin Buettner <kevinb@redhat.com>
8477
8478 * gdbthread.h (thread_to_thread_handle): Declare.
8479 * thread.c (gdbtypes.h): Include.
8480 (thread_to_thread_handle): New function.
8481
8482 * target.h (struct target_ops): Add thread_info_to_thread_handle.
8483 (target_thread_info_to_thread_handle): Declare.
8484 * target.c (target_thread_info_to_thread_handle): New function.
8485 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8486 * target-delegates.c: Regenerate.
8487
8488 * linux-thread-db.c (class thread_db_target): Add method
8489 thread_info_to_thread_handle.
8490 (thread_db_target::thread_info_to_thread_handle): Define.
8491 * remote.c (class remote_target): Add new method
8492 thread_info_to_thread_handle.
8493 (remote_target::thread_info_to_thread_handle): Define.
8494
56be6ea8
PA
84952019-04-08 Pedro Alves <palves@redhat.com>
8496
8497 * common/common-exceptions.c (throw_exception): Don't create
8498 named object to throw; throw directly.
8499 (throw_it): Likewise. Don't initialize gdb_exception::message
8500 here, with new; pass FMT and AP to the ctor instead.
8501 * common/common-exceptions.h: Include <string>.
8502 (gdb_exception::gdb_exception(enum return_reason, enum errors,
8503 const char *, va_list)): New ctor. Use std::make_shared.
8504 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8505 errors)): Delete.
8506 (gdb_exception_error::gdb_exception_error(enum errors, const char
8507 *, va_list)): New.
8508 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8509 Add assertion.
8510 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8511 errors)): Delete.
8512 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8513 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8514 Add assertion.
8515
eedc3f4f
TT
85162019-04-08 Tom Tromey <tom@tromey.com>
8517
8518 * valops.c (value_rtti_indirect_type): Replace throw_exception
8519 with throw.
8520 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8521 with throw.
8522 * thread.c (thr_try_catch_cmd): Replace throw_exception with
8523 throw.
8524 * target.c (target_translate_tls_address): Replace throw_exception
8525 with throw.
8526 * stack.c (frame_apply_command_count): Replace throw_exception
8527 with throw.
8528 * solib-spu.c (append_ocl_sos): Replace throw_exception with
8529 throw.
8530 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8531 with throw.
8532 * rs6000-tdep.c (rs6000_frame_cache)
8533 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8534 * remote.c: Replace throw_exception with throw.
8535 * record-full.c (record_full_message, record_full_wait_1)
8536 (record_full_restore): Replace throw_exception with throw.
8537 * record-btrace.c:
8538 (get_thread_current_frame_id, record_btrace_start_replaying)
8539 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8540 (cmd_record_btrace_start): Replace throw_exception with throw.
8541 * parse.c (parse_exp_in_context_1): Replace throw_exception with
8542 throw.
8543 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8544 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8545 * linespec.c:
8546 (find_linespec_symbols): Replace throw_exception with throw.
8547 * infrun.c (displaced_step_prepare, resume): Replace
8548 throw_exception with throw.
8549 * infcmd.c (post_create_inferior): Replace throw_exception with
8550 throw.
8551 * inf-loop.c (inferior_event_handler): Replace throw_exception
8552 with throw.
8553 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8554 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8555 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8556 (get_prev_frame_always, get_frame_pc_if_available)
8557 (get_frame_address_in_block_if_available, get_frame_language):
8558 Replace throw_exception with throw.
8559 * frame-unwind.c (frame_unwind_try_unwinder): Replace
8560 throw_exception with throw.
8561 * eval.c (fetch_subexp_value, evaluate_var_value)
8562 (evaluate_funcall, evaluate_subexp_standard): Replace
8563 throw_exception with throw.
8564 * dwarf2loc.c (call_site_find_chain)
8565 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8566 Replace throw_exception with throw.
8567 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8568 with throw.
8569 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8570 throw.
8571 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8572 * completer.c (complete_line_internal): Replace throw_exception
8573 with throw.
8574 * compile/compile-object-run.c (compile_object_run): Replace
8575 throw_exception with throw.
8576 * cli/cli-script.c (process_next_line): Replace throw_exception
8577 with throw.
8578 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8579 (btrace_enable, btrace_maint_update_pt_packets): Replace
8580 throw_exception with throw.
8581 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8582 throw_exception with throw.
8583 * break-catch-throw.c (re_set_exception_catchpoint): Replace
8584 throw_exception with throw.
8585 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8586 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8587 * aarch64-tdep.c (aarch64_make_prologue_cache)
8588 (aarch64_make_stub_cache): Replace throw_exception with throw.
8589
26003a20
TT
85902019-04-08 Tom Tromey <tom@tromey.com>
8591
8592 * common/common-exceptions.c (throw_exception): Rename from
8593 throw_exception_cxx. Remove old copy. Make argument const.
8594 (throw_it): Create and throw exception objects directly.
8595 * common/common-exceptions.h (throw_exception): Make argument
8596 const.
8597 (struct gdb_exception_error): Add constructor.
8598 (struct gdb_exception_quit): Add constructor.
8599
d272eb37
TT
86002019-04-08 Tom Tromey <tom@tromey.com>
8601
8602 * common/common-exceptions.h (exception_rethrow): Don't declare.
8603 (TRY_SJLJ): Update comment.
8604 (TRY, CATCH, END_CATCH): Remove.
8605 * common/common-exceptions.c (exception_rethrow): Remove.
8606
230d2906
TT
86072019-04-08 Tom Tromey <tom@tromey.com>
8608
8609 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8610 Remove.
8611 (gdb_exception_error): Rename from
8612 gdb_exception_RETURN_MASK_ERROR.
8613 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8614 (gdb_quit_bad_alloc): Update.
8615 * aarch64-tdep.c: Update.
8616 * ada-lang.c: Update.
8617 * ada-typeprint.c: Update.
8618 * ada-valprint.c: Update.
8619 * amd64-tdep.c: Update.
8620 * arch-utils.c: Update.
8621 * break-catch-throw.c: Update.
8622 * breakpoint.c: Update.
8623 * btrace.c: Update.
8624 * c-varobj.c: Update.
8625 * cli/cli-cmds.c: Update.
8626 * cli/cli-interp.c: Update.
8627 * cli/cli-script.c: Update.
8628 * common/common-exceptions.c: Update.
8629 * common/new-op.c: Update.
8630 * common/selftest.c: Update.
8631 * compile/compile-c-symbols.c: Update.
8632 * compile/compile-cplus-symbols.c: Update.
8633 * compile/compile-object-load.c: Update.
8634 * compile/compile-object-run.c: Update.
8635 * completer.c: Update.
8636 * corelow.c: Update.
8637 * cp-abi.c: Update.
8638 * cp-support.c: Update.
8639 * cp-valprint.c: Update.
8640 * darwin-nat.c: Update.
8641 * disasm-selftests.c: Update.
8642 * dtrace-probe.c: Update.
8643 * dwarf-index-cache.c: Update.
8644 * dwarf-index-write.c: Update.
8645 * dwarf2-frame-tailcall.c: Update.
8646 * dwarf2-frame.c: Update.
8647 * dwarf2loc.c: Update.
8648 * dwarf2read.c: Update.
8649 * eval.c: Update.
8650 * event-loop.c: Update.
8651 * event-top.c: Update.
8652 * exec.c: Update.
8653 * f-valprint.c: Update.
8654 * fbsd-tdep.c: Update.
8655 * frame-unwind.c: Update.
8656 * frame.c: Update.
8657 * gdbtypes.c: Update.
8658 * gnu-v3-abi.c: Update.
8659 * guile/guile-internal.h: Update.
8660 * guile/scm-block.c: Update.
8661 * guile/scm-breakpoint.c: Update.
8662 * guile/scm-cmd.c: Update.
8663 * guile/scm-disasm.c: Update.
8664 * guile/scm-frame.c: Update.
8665 * guile/scm-lazy-string.c: Update.
8666 * guile/scm-math.c: Update.
8667 * guile/scm-param.c: Update.
8668 * guile/scm-ports.c: Update.
8669 * guile/scm-pretty-print.c: Update.
8670 * guile/scm-symbol.c: Update.
8671 * guile/scm-symtab.c: Update.
8672 * guile/scm-type.c: Update.
8673 * guile/scm-value.c: Update.
8674 * i386-linux-tdep.c: Update.
8675 * i386-tdep.c: Update.
8676 * inf-loop.c: Update.
8677 * infcall.c: Update.
8678 * infcmd.c: Update.
8679 * infrun.c: Update.
8680 * jit.c: Update.
8681 * language.c: Update.
8682 * linespec.c: Update.
8683 * linux-fork.c: Update.
8684 * linux-nat.c: Update.
8685 * linux-tdep.c: Update.
8686 * linux-thread-db.c: Update.
8687 * main.c: Update.
8688 * mi/mi-cmd-break.c: Update.
8689 * mi/mi-cmd-stack.c: Update.
8690 * mi/mi-interp.c: Update.
8691 * mi/mi-main.c: Update.
8692 * objc-lang.c: Update.
8693 * p-valprint.c: Update.
8694 * parse.c: Update.
8695 * ppc-linux-tdep.c: Update.
8696 * printcmd.c: Update.
8697 * python/py-arch.c: Update.
8698 * python/py-breakpoint.c: Update.
8699 * python/py-cmd.c: Update.
8700 * python/py-finishbreakpoint.c: Update.
8701 * python/py-frame.c: Update.
8702 * python/py-framefilter.c: Update.
8703 * python/py-gdb-readline.c: Update.
8704 * python/py-inferior.c: Update.
8705 * python/py-infthread.c: Update.
8706 * python/py-lazy-string.c: Update.
8707 * python/py-linetable.c: Update.
8708 * python/py-objfile.c: Update.
8709 * python/py-param.c: Update.
8710 * python/py-prettyprint.c: Update.
8711 * python/py-progspace.c: Update.
8712 * python/py-record-btrace.c: Update.
8713 * python/py-record.c: Update.
8714 * python/py-symbol.c: Update.
8715 * python/py-type.c: Update.
8716 * python/py-unwind.c: Update.
8717 * python/py-utils.c: Update.
8718 * python/py-value.c: Update.
8719 * python/python.c: Update.
8720 * record-btrace.c: Update.
8721 * record-full.c: Update.
8722 * remote-fileio.c: Update.
8723 * remote.c: Update.
8724 * riscv-tdep.c: Update.
8725 * rs6000-aix-tdep.c: Update.
8726 * rs6000-tdep.c: Update.
8727 * rust-exp.y: Update.
8728 * rust-lang.c: Update.
8729 * s390-tdep.c: Update.
8730 * selftest-arch.c: Update.
8731 * solib-dsbt.c: Update.
8732 * solib-frv.c: Update.
8733 * solib-spu.c: Update.
8734 * solib-svr4.c: Update.
8735 * solib.c: Update.
8736 * sparc64-linux-tdep.c: Update.
8737 * stack.c: Update.
8738 * symfile-mem.c: Update.
8739 * symmisc.c: Update.
8740 * target.c: Update.
8741 * thread.c: Update.
8742 * top.c: Update.
8743 * tracefile-tfile.c: Update.
8744 * tui/tui.c: Update.
8745 * typeprint.c: Update.
8746 * unittests/cli-utils-selftests.c: Update.
8747 * unittests/parse-connection-spec-selftests.c: Update.
8748 * valops.c: Update.
8749 * valprint.c: Update.
8750 * value.c: Update.
8751 * varobj.c: Update.
8752 * windows-nat.c: Update.
8753 * x86-linux-nat.c: Update.
8754 * xml-support.c: Update.
8755
a70b8144
TT
87562019-04-08 Tom Tromey <tom@tromey.com>
8757
8758 * xml-support.c: Use C++ exception handling.
8759 * x86-linux-nat.c: Use C++ exception handling.
8760 * windows-nat.c: Use C++ exception handling.
8761 * varobj.c: Use C++ exception handling.
8762 * value.c: Use C++ exception handling.
8763 * valprint.c: Use C++ exception handling.
8764 * valops.c: Use C++ exception handling.
8765 * unittests/parse-connection-spec-selftests.c: Use C++ exception
8766 handling.
8767 * unittests/cli-utils-selftests.c: Use C++ exception handling.
8768 * typeprint.c: Use C++ exception handling.
8769 * tui/tui.c: Use C++ exception handling.
8770 * tracefile-tfile.c: Use C++ exception handling.
8771 * top.c: Use C++ exception handling.
8772 * thread.c: Use C++ exception handling.
8773 * target.c: Use C++ exception handling.
8774 * symmisc.c: Use C++ exception handling.
8775 * symfile-mem.c: Use C++ exception handling.
8776 * stack.c: Use C++ exception handling.
8777 * sparc64-linux-tdep.c: Use C++ exception handling.
8778 * solib.c: Use C++ exception handling.
8779 * solib-svr4.c: Use C++ exception handling.
8780 * solib-spu.c: Use C++ exception handling.
8781 * solib-frv.c: Use C++ exception handling.
8782 * solib-dsbt.c: Use C++ exception handling.
8783 * selftest-arch.c: Use C++ exception handling.
8784 * s390-tdep.c: Use C++ exception handling.
8785 * rust-lang.c: Use C++ exception handling.
8786 * rust-exp.y: Use C++ exception handling.
8787 * rs6000-tdep.c: Use C++ exception handling.
8788 * rs6000-aix-tdep.c: Use C++ exception handling.
8789 * riscv-tdep.c: Use C++ exception handling.
8790 * remote.c: Use C++ exception handling.
8791 * remote-fileio.c: Use C++ exception handling.
8792 * record-full.c: Use C++ exception handling.
8793 * record-btrace.c: Use C++ exception handling.
8794 * python/python.c: Use C++ exception handling.
8795 * python/py-value.c: Use C++ exception handling.
8796 * python/py-utils.c: Use C++ exception handling.
8797 * python/py-unwind.c: Use C++ exception handling.
8798 * python/py-type.c: Use C++ exception handling.
8799 * python/py-symbol.c: Use C++ exception handling.
8800 * python/py-record.c: Use C++ exception handling.
8801 * python/py-record-btrace.c: Use C++ exception handling.
8802 * python/py-progspace.c: Use C++ exception handling.
8803 * python/py-prettyprint.c: Use C++ exception handling.
8804 * python/py-param.c: Use C++ exception handling.
8805 * python/py-objfile.c: Use C++ exception handling.
8806 * python/py-linetable.c: Use C++ exception handling.
8807 * python/py-lazy-string.c: Use C++ exception handling.
8808 * python/py-infthread.c: Use C++ exception handling.
8809 * python/py-inferior.c: Use C++ exception handling.
8810 * python/py-gdb-readline.c: Use C++ exception handling.
8811 * python/py-framefilter.c: Use C++ exception handling.
8812 * python/py-frame.c: Use C++ exception handling.
8813 * python/py-finishbreakpoint.c: Use C++ exception handling.
8814 * python/py-cmd.c: Use C++ exception handling.
8815 * python/py-breakpoint.c: Use C++ exception handling.
8816 * python/py-arch.c: Use C++ exception handling.
8817 * printcmd.c: Use C++ exception handling.
8818 * ppc-linux-tdep.c: Use C++ exception handling.
8819 * parse.c: Use C++ exception handling.
8820 * p-valprint.c: Use C++ exception handling.
8821 * objc-lang.c: Use C++ exception handling.
8822 * mi/mi-main.c: Use C++ exception handling.
8823 * mi/mi-interp.c: Use C++ exception handling.
8824 * mi/mi-cmd-stack.c: Use C++ exception handling.
8825 * mi/mi-cmd-break.c: Use C++ exception handling.
8826 * main.c: Use C++ exception handling.
8827 * linux-thread-db.c: Use C++ exception handling.
8828 * linux-tdep.c: Use C++ exception handling.
8829 * linux-nat.c: Use C++ exception handling.
8830 * linux-fork.c: Use C++ exception handling.
8831 * linespec.c: Use C++ exception handling.
8832 * language.c: Use C++ exception handling.
8833 * jit.c: Use C++ exception handling.
8834 * infrun.c: Use C++ exception handling.
8835 * infcmd.c: Use C++ exception handling.
8836 * infcall.c: Use C++ exception handling.
8837 * inf-loop.c: Use C++ exception handling.
8838 * i386-tdep.c: Use C++ exception handling.
8839 * i386-linux-tdep.c: Use C++ exception handling.
8840 * guile/scm-value.c: Use C++ exception handling.
8841 * guile/scm-type.c: Use C++ exception handling.
8842 * guile/scm-symtab.c: Use C++ exception handling.
8843 * guile/scm-symbol.c: Use C++ exception handling.
8844 * guile/scm-pretty-print.c: Use C++ exception handling.
8845 * guile/scm-ports.c: Use C++ exception handling.
8846 * guile/scm-param.c: Use C++ exception handling.
8847 * guile/scm-math.c: Use C++ exception handling.
8848 * guile/scm-lazy-string.c: Use C++ exception handling.
8849 * guile/scm-frame.c: Use C++ exception handling.
8850 * guile/scm-disasm.c: Use C++ exception handling.
8851 * guile/scm-cmd.c: Use C++ exception handling.
8852 * guile/scm-breakpoint.c: Use C++ exception handling.
8853 * guile/scm-block.c: Use C++ exception handling.
8854 * guile/guile-internal.h: Use C++ exception handling.
8855 * gnu-v3-abi.c: Use C++ exception handling.
8856 * gdbtypes.c: Use C++ exception handling.
8857 * frame.c: Use C++ exception handling.
8858 * frame-unwind.c: Use C++ exception handling.
8859 * fbsd-tdep.c: Use C++ exception handling.
8860 * f-valprint.c: Use C++ exception handling.
8861 * exec.c: Use C++ exception handling.
8862 * event-top.c: Use C++ exception handling.
8863 * event-loop.c: Use C++ exception handling.
8864 * eval.c: Use C++ exception handling.
8865 * dwarf2read.c: Use C++ exception handling.
8866 * dwarf2loc.c: Use C++ exception handling.
8867 * dwarf2-frame.c: Use C++ exception handling.
8868 * dwarf2-frame-tailcall.c: Use C++ exception handling.
8869 * dwarf-index-write.c: Use C++ exception handling.
8870 * dwarf-index-cache.c: Use C++ exception handling.
8871 * dtrace-probe.c: Use C++ exception handling.
8872 * disasm-selftests.c: Use C++ exception handling.
8873 * darwin-nat.c: Use C++ exception handling.
8874 * cp-valprint.c: Use C++ exception handling.
8875 * cp-support.c: Use C++ exception handling.
8876 * cp-abi.c: Use C++ exception handling.
8877 * corelow.c: Use C++ exception handling.
8878 * completer.c: Use C++ exception handling.
8879 * compile/compile-object-run.c: Use C++ exception handling.
8880 * compile/compile-object-load.c: Use C++ exception handling.
8881 * compile/compile-cplus-symbols.c: Use C++ exception handling.
8882 * compile/compile-c-symbols.c: Use C++ exception handling.
8883 * common/selftest.c: Use C++ exception handling.
8884 * common/new-op.c: Use C++ exception handling.
8885 * cli/cli-script.c: Use C++ exception handling.
8886 * cli/cli-interp.c: Use C++ exception handling.
8887 * cli/cli-cmds.c: Use C++ exception handling.
8888 * c-varobj.c: Use C++ exception handling.
8889 * btrace.c: Use C++ exception handling.
8890 * breakpoint.c: Use C++ exception handling.
8891 * break-catch-throw.c: Use C++ exception handling.
8892 * arch-utils.c: Use C++ exception handling.
8893 * amd64-tdep.c: Use C++ exception handling.
8894 * ada-valprint.c: Use C++ exception handling.
8895 * ada-typeprint.c: Use C++ exception handling.
8896 * ada-lang.c: Use C++ exception handling.
8897 * aarch64-tdep.c: Use C++ exception handling.
8898
3d6e9d23
TT
88992019-04-08 Tom Tromey <tom@tromey.com>
8900
8901 * xml-support.c (gdb_xml_parser::parse): Update.
8902 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8903 * value.c (show_convenience): Update.
8904 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8905 (test_parse_flags_qcs): Update.
8906 * thread.c (thr_try_catch_cmd): Update.
8907 * target.c (target_translate_tls_address): Update.
8908 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8909 (info_frame_command_core, frame_apply_command_count): Update.
8910 * rust-exp.y (rust_lex_exception_test): Update.
8911 * riscv-tdep.c (riscv_print_one_register_info): Update.
8912 * remote.c (remote_target::enable_btrace): Update.
8913 * record-btrace.c (record_btrace_enable_warn): Update.
8914 * python/py-utils.c (gdbpy_convert_exception): Update.
8915 * printcmd.c (do_one_display, print_variable_and_value): Update.
8916 * mi/mi-main.c (mi_print_exception): Update.
8917 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8918 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8919 * linux-nat.c (linux_nat_target::attach): Update.
8920 * linux-fork.c (class scoped_switch_fork_info): Update.
8921 * infrun.c (displaced_step_prepare): Update.
8922 * infcall.c (call_function_by_hand_dummy): Update.
8923 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8924 * gnu-v3-abi.c (print_one_vtable): Update.
8925 * frame.c (get_prev_frame_always): Update.
8926 * f-valprint.c (info_common_command_for_block): Update.
8927 * exec.c (try_open_exec_file): Update.
8928 * exceptions.c (print_exception, exception_print)
8929 (exception_fprintf, exception_print_same): Update.
8930 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8931 * dwarf-index-cache.c (index_cache::store)
8932 (index_cache::lookup_gdb_index): Update.
8933 * darwin-nat.c (maybe_cache_shell): Update.
8934 * cp-valprint.c (cp_print_value_fields): Update.
8935 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8936 (gcc_cplus_symbol_address): Update.
8937 * compile/compile-c-symbols.c (gcc_convert_symbol)
8938 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8939 * common/selftest.c: Update.
8940 * common/common-exceptions.h (struct gdb_exception) <message>: Now
8941 a std::string.
8942 (exception_try_scope_entry, exception_try_scope_exit): Don't
8943 declare.
8944 (struct exception_try_scope): Remove.
8945 (TRY): Don't use exception_try_scope.
8946 (struct gdb_exception): Add constructor, operator=.
8947 <what>: New method.
8948 (struct gdb_exception_RETURN_MASK_ALL)
8949 (struct gdb_exception_RETURN_MASK_ERROR)
8950 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8951 (struct gdb_quit_bad_alloc): Update.
8952 * common/common-exceptions.c (exception_none): Change
8953 initializer.
8954 (struct catcher) <state, exception>: Initialize inline.
8955 <prev>: Remove member.
8956 (current_catcher): Remove.
8957 (catchers): New global.
8958 (exceptions_state_mc_init): Simplify.
8959 (catcher_pop): Remove.
8960 (exceptions_state_mc, exceptions_state_mc_catch): Update.
8961 (try_scope_depth, exception_try_scope_entry)
8962 (exception_try_scope_exit): Remove.
8963 (throw_exception_sjlj): Update.
8964 (exception_messages, exception_messages_size): Remove.
8965 (throw_it): Simplify.
8966 (gdb_exception_sliced_copy): Remove.
8967 (throw_exception_cxx): Update.
8968 * cli/cli-script.c (script_from_file): Update.
8969 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8970 Update.
8971 * ada-valprint.c (ada_val_print): Update.
8972 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8973 (create_excep_cond_exprs): Update.
8974
c5c10118
TT
89752019-04-08 Tom Tromey <tom@tromey.com>
8976
8977 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8978 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8979 (TRY, CATCH, END_CATCH): Remove some definitions.
8980 * common/common-exceptions.c: Don't use GDB_XCPT.
8981 (catcher_list_size): Remove.
8982 (throw_exception, throw_it): Simplify.
8983
4de283e4
TT
89842019-04-05 Tom Tromey <tom@tromey.com>
8985
8986 Revert the header-sorting patch.
8987 * ft32-tdep.c: Revert.
8988 * frv-tdep.c: Revert.
8989 * frv-linux-tdep.c: Revert.
8990 * frame.c: Revert.
8991 * frame-unwind.c: Revert.
8992 * frame-base.c: Revert.
8993 * fork-child.c: Revert.
8994 * findvar.c: Revert.
8995 * findcmd.c: Revert.
8996 * filesystem.c: Revert.
8997 * filename-seen-cache.h: Revert.
8998 * filename-seen-cache.c: Revert.
8999 * fbsd-tdep.c: Revert.
9000 * fbsd-nat.h: Revert.
9001 * fbsd-nat.c: Revert.
9002 * f-valprint.c: Revert.
9003 * f-typeprint.c: Revert.
9004 * f-lang.c: Revert.
9005 * extension.h: Revert.
9006 * extension.c: Revert.
9007 * extension-priv.h: Revert.
9008 * expprint.c: Revert.
9009 * exec.h: Revert.
9010 * exec.c: Revert.
9011 * exceptions.c: Revert.
9012 * event-top.c: Revert.
9013 * event-loop.c: Revert.
9014 * eval.c: Revert.
9015 * elfread.c: Revert.
9016 * dwarf2read.h: Revert.
9017 * dwarf2read.c: Revert.
9018 * dwarf2loc.c: Revert.
9019 * dwarf2expr.h: Revert.
9020 * dwarf2expr.c: Revert.
9021 * dwarf2-frame.c: Revert.
9022 * dwarf2-frame-tailcall.c: Revert.
9023 * dwarf-index-write.h: Revert.
9024 * dwarf-index-write.c: Revert.
9025 * dwarf-index-common.c: Revert.
9026 * dwarf-index-cache.h: Revert.
9027 * dwarf-index-cache.c: Revert.
9028 * dummy-frame.c: Revert.
9029 * dtrace-probe.c: Revert.
9030 * disasm.h: Revert.
9031 * disasm.c: Revert.
9032 * disasm-selftests.c: Revert.
9033 * dictionary.c: Revert.
9034 * dicos-tdep.c: Revert.
9035 * demangle.c: Revert.
9036 * dcache.h: Revert.
9037 * dcache.c: Revert.
9038 * darwin-nat.h: Revert.
9039 * darwin-nat.c: Revert.
9040 * darwin-nat-info.c: Revert.
9041 * d-valprint.c: Revert.
9042 * d-namespace.c: Revert.
9043 * d-lang.c: Revert.
9044 * ctf.c: Revert.
9045 * csky-tdep.c: Revert.
9046 * csky-linux-tdep.c: Revert.
9047 * cris-tdep.c: Revert.
9048 * cris-linux-tdep.c: Revert.
9049 * cp-valprint.c: Revert.
9050 * cp-support.c: Revert.
9051 * cp-namespace.c: Revert.
9052 * cp-abi.c: Revert.
9053 * corelow.c: Revert.
9054 * corefile.c: Revert.
9055 * continuations.c: Revert.
9056 * completer.h: Revert.
9057 * completer.c: Revert.
9058 * complaints.c: Revert.
9059 * coffread.c: Revert.
9060 * coff-pe-read.c: Revert.
9061 * cli-out.h: Revert.
9062 * cli-out.c: Revert.
9063 * charset.c: Revert.
9064 * c-varobj.c: Revert.
9065 * c-valprint.c: Revert.
9066 * c-typeprint.c: Revert.
9067 * c-lang.c: Revert.
9068 * buildsym.c: Revert.
9069 * buildsym-legacy.c: Revert.
9070 * build-id.h: Revert.
9071 * build-id.c: Revert.
9072 * btrace.c: Revert.
9073 * bsd-uthread.c: Revert.
9074 * breakpoint.h: Revert.
9075 * breakpoint.c: Revert.
9076 * break-catch-throw.c: Revert.
9077 * break-catch-syscall.c: Revert.
9078 * break-catch-sig.c: Revert.
9079 * blockframe.c: Revert.
9080 * block.c: Revert.
9081 * bfin-tdep.c: Revert.
9082 * bfin-linux-tdep.c: Revert.
9083 * bfd-target.c: Revert.
9084 * bcache.c: Revert.
9085 * ax-general.c: Revert.
9086 * ax-gdb.h: Revert.
9087 * ax-gdb.c: Revert.
9088 * avr-tdep.c: Revert.
9089 * auxv.c: Revert.
9090 * auto-load.c: Revert.
9091 * arm-wince-tdep.c: Revert.
9092 * arm-tdep.c: Revert.
9093 * arm-symbian-tdep.c: Revert.
9094 * arm-pikeos-tdep.c: Revert.
9095 * arm-obsd-tdep.c: Revert.
9096 * arm-nbsd-tdep.c: Revert.
9097 * arm-nbsd-nat.c: Revert.
9098 * arm-linux-tdep.c: Revert.
9099 * arm-linux-nat.c: Revert.
9100 * arm-fbsd-tdep.c: Revert.
9101 * arm-fbsd-nat.c: Revert.
9102 * arm-bsd-tdep.c: Revert.
9103 * arch-utils.c: Revert.
9104 * arc-tdep.c: Revert.
9105 * arc-newlib-tdep.c: Revert.
9106 * annotate.h: Revert.
9107 * annotate.c: Revert.
9108 * amd64-windows-tdep.c: Revert.
9109 * amd64-windows-nat.c: Revert.
9110 * amd64-tdep.c: Revert.
9111 * amd64-sol2-tdep.c: Revert.
9112 * amd64-obsd-tdep.c: Revert.
9113 * amd64-obsd-nat.c: Revert.
9114 * amd64-nbsd-tdep.c: Revert.
9115 * amd64-nbsd-nat.c: Revert.
9116 * amd64-nat.c: Revert.
9117 * amd64-linux-tdep.c: Revert.
9118 * amd64-linux-nat.c: Revert.
9119 * amd64-fbsd-tdep.c: Revert.
9120 * amd64-fbsd-nat.c: Revert.
9121 * amd64-dicos-tdep.c: Revert.
9122 * amd64-darwin-tdep.c: Revert.
9123 * amd64-bsd-nat.c: Revert.
9124 * alpha-tdep.c: Revert.
9125 * alpha-obsd-tdep.c: Revert.
9126 * alpha-nbsd-tdep.c: Revert.
9127 * alpha-mdebug-tdep.c: Revert.
9128 * alpha-linux-tdep.c: Revert.
9129 * alpha-linux-nat.c: Revert.
9130 * alpha-bsd-tdep.c: Revert.
9131 * alpha-bsd-nat.c: Revert.
9132 * aix-thread.c: Revert.
9133 * agent.c: Revert.
9134 * addrmap.c: Revert.
9135 * ada-varobj.c: Revert.
9136 * ada-valprint.c: Revert.
9137 * ada-typeprint.c: Revert.
9138 * ada-tasks.c: Revert.
9139 * ada-lang.c: Revert.
9140 * aarch64-tdep.c: Revert.
9141 * aarch64-ravenscar-thread.c: Revert.
9142 * aarch64-newlib-tdep.c: Revert.
9143 * aarch64-linux-tdep.c: Revert.
9144 * aarch64-linux-nat.c: Revert.
9145 * aarch64-fbsd-tdep.c: Revert.
9146 * aarch64-fbsd-nat.c: Revert.
9147 * aarch32-linux-nat.c: Revert.
9148
d55e5aa6
TT
91492019-04-05 Tom Tromey <tom@tromey.com>
9150
9151 * ft32-tdep.c: Sort headers.
9152 * frv-tdep.c: Sort headers.
9153 * frv-linux-tdep.c: Sort headers.
9154 * frame.c: Sort headers.
9155 * frame-unwind.c: Sort headers.
9156 * frame-base.c: Sort headers.
9157 * fork-child.c: Sort headers.
9158 * findvar.c: Sort headers.
9159 * findcmd.c: Sort headers.
9160 * filesystem.c: Sort headers.
9161 * filename-seen-cache.h: Sort headers.
9162 * filename-seen-cache.c: Sort headers.
9163 * fbsd-tdep.c: Sort headers.
9164 * fbsd-nat.h: Sort headers.
9165 * fbsd-nat.c: Sort headers.
9166 * f-valprint.c: Sort headers.
9167 * f-typeprint.c: Sort headers.
9168 * f-lang.c: Sort headers.
9169 * extension.h: Sort headers.
9170 * extension.c: Sort headers.
9171 * extension-priv.h: Sort headers.
9172 * expprint.c: Sort headers.
9173 * exec.h: Sort headers.
9174 * exec.c: Sort headers.
9175 * exceptions.c: Sort headers.
9176 * event-top.c: Sort headers.
9177 * event-loop.c: Sort headers.
9178 * eval.c: Sort headers.
9179 * elfread.c: Sort headers.
9180 * dwarf2read.h: Sort headers.
9181 * dwarf2read.c: Sort headers.
9182 * dwarf2loc.c: Sort headers.
9183 * dwarf2expr.h: Sort headers.
9184 * dwarf2expr.c: Sort headers.
9185 * dwarf2-frame.c: Sort headers.
9186 * dwarf2-frame-tailcall.c: Sort headers.
9187 * dwarf-index-write.h: Sort headers.
9188 * dwarf-index-write.c: Sort headers.
9189 * dwarf-index-common.c: Sort headers.
9190 * dwarf-index-cache.h: Sort headers.
9191 * dwarf-index-cache.c: Sort headers.
9192 * dummy-frame.c: Sort headers.
9193 * dtrace-probe.c: Sort headers.
9194 * disasm.h: Sort headers.
9195 * disasm.c: Sort headers.
9196 * disasm-selftests.c: Sort headers.
9197 * dictionary.c: Sort headers.
9198 * dicos-tdep.c: Sort headers.
9199 * demangle.c: Sort headers.
9200 * dcache.h: Sort headers.
9201 * dcache.c: Sort headers.
9202 * darwin-nat.h: Sort headers.
9203 * darwin-nat.c: Sort headers.
9204 * darwin-nat-info.c: Sort headers.
9205 * d-valprint.c: Sort headers.
9206 * d-namespace.c: Sort headers.
9207 * d-lang.c: Sort headers.
9208 * ctf.c: Sort headers.
9209 * csky-tdep.c: Sort headers.
9210 * csky-linux-tdep.c: Sort headers.
9211 * cris-tdep.c: Sort headers.
9212 * cris-linux-tdep.c: Sort headers.
9213 * cp-valprint.c: Sort headers.
9214 * cp-support.c: Sort headers.
9215 * cp-namespace.c: Sort headers.
9216 * cp-abi.c: Sort headers.
9217 * corelow.c: Sort headers.
9218 * corefile.c: Sort headers.
9219 * continuations.c: Sort headers.
9220 * completer.h: Sort headers.
9221 * completer.c: Sort headers.
9222 * complaints.c: Sort headers.
9223 * coffread.c: Sort headers.
9224 * coff-pe-read.c: Sort headers.
9225 * cli-out.h: Sort headers.
9226 * cli-out.c: Sort headers.
9227 * charset.c: Sort headers.
9228 * c-varobj.c: Sort headers.
9229 * c-valprint.c: Sort headers.
9230 * c-typeprint.c: Sort headers.
9231 * c-lang.c: Sort headers.
9232 * buildsym.c: Sort headers.
9233 * buildsym-legacy.c: Sort headers.
9234 * build-id.h: Sort headers.
9235 * build-id.c: Sort headers.
9236 * btrace.c: Sort headers.
9237 * bsd-uthread.c: Sort headers.
9238 * breakpoint.h: Sort headers.
9239 * breakpoint.c: Sort headers.
9240 * break-catch-throw.c: Sort headers.
9241 * break-catch-syscall.c: Sort headers.
9242 * break-catch-sig.c: Sort headers.
9243 * blockframe.c: Sort headers.
9244 * block.c: Sort headers.
9245 * bfin-tdep.c: Sort headers.
9246 * bfin-linux-tdep.c: Sort headers.
9247 * bfd-target.c: Sort headers.
9248 * bcache.c: Sort headers.
9249 * ax-general.c: Sort headers.
9250 * ax-gdb.h: Sort headers.
9251 * ax-gdb.c: Sort headers.
9252 * avr-tdep.c: Sort headers.
9253 * auxv.c: Sort headers.
9254 * auto-load.c: Sort headers.
9255 * arm-wince-tdep.c: Sort headers.
9256 * arm-tdep.c: Sort headers.
9257 * arm-symbian-tdep.c: Sort headers.
9258 * arm-pikeos-tdep.c: Sort headers.
9259 * arm-obsd-tdep.c: Sort headers.
9260 * arm-nbsd-tdep.c: Sort headers.
9261 * arm-nbsd-nat.c: Sort headers.
9262 * arm-linux-tdep.c: Sort headers.
9263 * arm-linux-nat.c: Sort headers.
9264 * arm-fbsd-tdep.c: Sort headers.
9265 * arm-fbsd-nat.c: Sort headers.
9266 * arm-bsd-tdep.c: Sort headers.
9267 * arch-utils.c: Sort headers.
9268 * arc-tdep.c: Sort headers.
9269 * arc-newlib-tdep.c: Sort headers.
9270 * annotate.h: Sort headers.
9271 * annotate.c: Sort headers.
9272 * amd64-windows-tdep.c: Sort headers.
9273 * amd64-windows-nat.c: Sort headers.
9274 * amd64-tdep.c: Sort headers.
9275 * amd64-sol2-tdep.c: Sort headers.
9276 * amd64-obsd-tdep.c: Sort headers.
9277 * amd64-obsd-nat.c: Sort headers.
9278 * amd64-nbsd-tdep.c: Sort headers.
9279 * amd64-nbsd-nat.c: Sort headers.
9280 * amd64-nat.c: Sort headers.
9281 * amd64-linux-tdep.c: Sort headers.
9282 * amd64-linux-nat.c: Sort headers.
9283 * amd64-fbsd-tdep.c: Sort headers.
9284 * amd64-fbsd-nat.c: Sort headers.
9285 * amd64-dicos-tdep.c: Sort headers.
9286 * amd64-darwin-tdep.c: Sort headers.
9287 * amd64-bsd-nat.c: Sort headers.
9288 * alpha-tdep.c: Sort headers.
9289 * alpha-obsd-tdep.c: Sort headers.
9290 * alpha-nbsd-tdep.c: Sort headers.
9291 * alpha-mdebug-tdep.c: Sort headers.
9292 * alpha-linux-tdep.c: Sort headers.
9293 * alpha-linux-nat.c: Sort headers.
9294 * alpha-bsd-tdep.c: Sort headers.
9295 * alpha-bsd-nat.c: Sort headers.
9296 * aix-thread.c: Sort headers.
9297 * agent.c: Sort headers.
9298 * addrmap.c: Sort headers.
9299 * ada-varobj.c: Sort headers.
9300 * ada-valprint.c: Sort headers.
9301 * ada-typeprint.c: Sort headers.
9302 * ada-tasks.c: Sort headers.
9303 * ada-lang.c: Sort headers.
9304 * aarch64-tdep.c: Sort headers.
9305 * aarch64-ravenscar-thread.c: Sort headers.
9306 * aarch64-newlib-tdep.c: Sort headers.
9307 * aarch64-linux-tdep.c: Sort headers.
9308 * aarch64-linux-nat.c: Sort headers.
9309 * aarch64-fbsd-tdep.c: Sort headers.
9310 * aarch64-fbsd-nat.c: Sort headers.
9311 * aarch32-linux-nat.c: Sort headers.
9312
699bd4cf
TT
93132019-04-04 Tom Tromey <tom@tromey.com>
9314
9315 * varobj.c (varobj_create): Update.
9316 * rust-exp.y (struct rust_parser) <update_innermost_block,
9317 lookup_symbol>: New methods.
9318 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9319 Rename.
9320 (rust_parser::rust_lookup_type)
9321 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9322 * printcmd.c (display_command, do_one_display): Update.
9323 * parser-defs.h (struct parser_state) <parser_state>: Add
9324 "tracker" parameter.
9325 (block_tracker): New member.
9326 (class innermost_block_tracker) <innermost_block_tracker>: Add
9327 "types" parameter.
9328 <reset>: Remove method.
9329 (innermost_block): Don't declare.
9330 (null_post_parser): Update.
9331 * parse.c (innermost_block): Remove global.
9332 (write_dollar_variable): Update.
9333 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9334 Remove "tracker_types" parameter.
9335 (parse_expression): Add "tracker" parameter.
9336 (parse_expression_for_completion): Update.
9337 (null_post_parser): Add "tracker" parameter.
9338 * p-exp.y: Update rules.
9339 * m2-exp.y: Update rules.
9340 * language.h (struct language_defn) <la_post_parser>: Add
9341 "tracker" parameter.
9342 * go-exp.y: Update rules.
9343 * f-exp.y: Update rules.
9344 * expression.h (parse_expression, parse_exp_1): Add "tracker"
9345 parameter.
9346 * d-exp.y: Update rules.
9347 * c-exp.y: Update rules.
9348 * breakpoint.c (set_breakpoint_condition): Create an
9349 innermost_block_tracker.
9350 (watch_command_1): Likewise.
9351 * ada-lang.c (resolve): Add "tracker" parameter.
9352 (resolve_subexp): Likewise.
9353 * ada-exp.y (write_var_from_sym): Update.
9354
dac43e32
TT
93552019-04-04 Tom Tromey <tom@tromey.com>
9356
9357 * type-stack.h: New file.
9358 * type-stack.c: New file.
9359 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9360 type-stack.h.
9361 (insert_into_type_stack, insert_type, push_type, push_type_int)
9362 (insert_type_address_space, pop_type, pop_type_int)
9363 (pop_typelist, pop_type_stack, append_type_stack)
9364 (push_type_stack, get_type_stack, push_typelist)
9365 (follow_type_instance_flags, follow_types): Don't declare.
9366 * parse.c (type_stack): Remove global.
9367 (parse_exp_in_context): Update.
9368 (insert_into_type_stack, insert_type, push_type, push_type_int)
9369 (insert_type_address_space, pop_type, pop_type_int)
9370 (pop_typelist, pop_type_stack, append_type_stack)
9371 (push_type_stack, get_type_stack, push_typelist)
9372 (follow_type_instance_flags, follow_types): Remove (moved to
9373 type-stack.c).
9374 * f-exp.y (type_stack): New global.
9375 Update rules.
9376 (push_kind_type, f_parse): Update.
9377 * d-exp.y (type_stack): New global.
9378 Update rules.
9379 (d_parse): Update.
9380 * c-exp.y (struct c_parse_state) <type_stack>: New member.
9381 Update rules.
9382 * Makefile.in (COMMON_SFILES): Add type-stack.c.
9383 (HFILES_NO_SRCDIR): Add type-stack.h.
9384
2a612529
TT
93852019-04-04 Tom Tromey <tom@tromey.com>
9386
9387 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9388 (rust_parser::convert_ast_to_expression, rust_parse)
9389 (rust_lex_test_completion, rust_lex_tests): Update.
9390 * parser-defs.h (struct expr_completion_state): New.
9391 (struct parser_state) <parser_state>: Add completion parameter.
9392 <mark_struct_expression, mark_completion_tag>: New methods.
9393 <parse_completion, m_completion_state>: New members.
9394 (prefixify_expression, null_post_parser): Update.
9395 (mark_struct_expression, mark_completion_tag): Don't declare.
9396 * parse.c (parse_completion, expout_last_struct)
9397 (expout_tag_completion_type, expout_completion_name): Remove
9398 globals.
9399 (parser_state::mark_struct_expression)
9400 (parser_state::mark_completion_tag): Now methods.
9401 (prefixify_expression): Add last_struct parameter.
9402 (prefixify_subexp): Likewise.
9403 (parse_exp_1): Update.
9404 (parse_exp_in_context): Add cstate parameter. Update.
9405 (parse_expression_for_completion): Create an
9406 expr_completion_state.
9407 (null_post_parser): Add "completion" parameter.
9408 * p-exp.y: Update rules.
9409 (yylex): Update.
9410 * language.h (struct language_defn) <la_post_parser>: Add
9411 "completing" parameter.
9412 * go-exp.y: Update rules.
9413 (lex_one_token): Update.
9414 * expression.h (parse_completion): Don't declare.
9415 * d-exp.y: Update rules.
9416 (lex_one_token): Update rules.
9417 * c-exp.y: Update rules.
9418 (lex_one_token): Update.
9419 * ada-lang.c (resolve): Add "parse_completion" parameter.
9420 (resolve_subexp): Likewise.
9421 (ada_resolve_function): Likewise.
9422
43476f0b
TT
94232019-04-04 Tom Tromey <tom@tromey.com>
9424
9425 * parser-defs.h (struct parser_state) <start_arglist,
9426 end_arglist>: New methods.
9427 <arglist_len, m_funcall_chain>: New members.
9428 (arglist_len, start_arglist, end_arglist): Don't declare.
9429 * parse.c (arglist_len, funcall_chain): Remove global.
9430 (start_arglist, end_arglist): Remove functions.
9431 (parse_exp_in_context): Update.
9432 * p-exp.y: Update rules.
9433 * m2-exp.y: Update rules.
9434 * go-exp.y: Update rules.
9435 * f-exp.y: Update rules.
9436 * d-exp.y: Update rules.
9437 * c-exp.y: Update rules.
9438
5776fca3
TT
94392019-04-04 Tom Tromey <tom@tromey.com>
9440
9441 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9442 lex_operator, push_back>: New methods.
9443 Update all rules.
9444 (rust_parser::lex_hex, lex_escape): Rename and update.
9445 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9446 (rust_parser::lex_operator): Rename and update.
9447 (rust_parser::lex_number, rustyylex, rustyyerror)
9448 (rust_lex_test_init, rust_lex_test_sequence)
9449 (rust_lex_test_push_back, rust_lex_tests): Update.
9450 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9451 parameter.
9452 <lexptr, prev_lexptr>: New members.
9453 (lexptr, prev_lexptr): Don't declare.
9454 * parse.c (lexptr, prev_lexptr): Remove globals.
9455 (parse_exp_in_context): Update.
9456 * p-exp.y (yylex, yyerror): Update.
9457 * m2-exp.y (parse_number, yylex, yyerror): Update.
9458 * go-exp.y (lex_one_token, yyerror): Update.
9459 * f-exp.y (match_string_literal, yylex, yyerror): Update.
9460 * d-exp.y (lex_one_token, yyerror): Update.
9461 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9462 (lex_one_token, yyerror): Update.
9463 * ada-lex.l (YY_INPUT): Update.
9464 (rewind_to_char): Update.
9465 * ada-exp.y (yyerror): Update.
9466
8621b685
TT
94672019-04-04 Tom Tromey <tom@tromey.com>
9468
9469 * rust-exp.y (rustyylex, rust_lex_tests): Update.
9470 * parser-defs.h (struct parser_state) <parser_state>: Add new
9471 parameter.
9472 <comma_terminates>: New member.
9473 (comma_terminates): Don't declare global.
9474 * parse.c (comma_terminates): Remove global.
9475 (parse_exp_in_context): Update.
9476 * p-exp.y (yylex): Update.
9477 * m2-exp.y (yylex): Update.
9478 * go-exp.y (lex_one_token): Update.
9479 * f-exp.y (yylex): Update.
9480 * d-exp.y (lex_one_token): Update.
9481 * c-exp.y (lex_one_token): Update.
9482 * ada-lex.l: Update.
9483
28aaf3fd
TT
94842019-04-04 Tom Tromey <tom@tromey.com>
9485
9486 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9487 (rustyylex, rust_lex_test_init, rust_lex_test_one)
9488 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9489 * parser-defs.h (paren_depth): Don't declare.
9490 * parse.c (paren_depth): Remove global.
9491 (parse_exp_in_context): Update.
9492 * p-exp.y (paren_depth): New global.
9493 (pascal_parse): Initialize it.
9494 * m2-exp.y (paren_depth): New global.
9495 (m2_parse): Initialize it.
9496 * go-exp.y (paren_depth): New global.
9497 (go_parse): Initialize it.
9498 * f-exp.y (paren_depth): New global.
9499 (f_parse): Initialize it.
9500 * d-exp.y (paren_depth): New global.
9501 (d_parse): Initialize it.
9502 * c-exp.y (paren_depth): New global.
9503 (c_parse): Initialize it.
9504 * ada-lex.l (paren_depth): New global.
9505 (lexer_init): Initialize it.
9506
1e58a4a4
TT
95072019-04-04 Tom Tromey <tom@tromey.com>
9508
9509 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9510 (rust_parser::convert_ast_to_type)
9511 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9512 * parser-defs.h (struct parser_state) <parser_state>: Add
9513 parameters. Initialize new members.
9514 <expression_context_block, expression_context_pc>: New members.
9515 * parse.c (expression_context_block, expression_context_pc):
9516 Remove globals.
9517 (parse_exp_in_context): Update.
9518 * p-exp.y: Update all rules.
9519 (yylex): Update.
9520 * m2-exp.y: Update all rules.
9521 (yylex): Update.
9522 * go-exp.y (yylex): Update.
9523 * f-exp.y (yylex): Update.
9524 * d-exp.y: Update all rules.
9525 (yylex): Update.
9526 * c-exp.y: Update all rules.
9527 (lex_one_token, classify_name, yylex, c_parse): Update.
9528 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9529
37eedb39
TT
95302019-04-04 Tom Tromey <tom@tromey.com>
9531
9532 * gdbarch.h, gdbarch.c: Rebuild.
9533 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9534 * stap-probe.h:
9535 (struct stap_parse_info): Replace "parser_state" with
9536 "expr_builder".
9537 * parser-defs.h (struct expr_builder): Rename from "parser_state".
9538 (parser_state): New class.
9539 * parse.c (expr_builder): Rename.
9540 (expr_builder::release): Rename.
9541 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9542 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9543 (write_exp_elt_longcst, write_exp_elt_floatcst)
9544 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9545 (write_exp_string_vector, write_exp_bitstring)
9546 (write_exp_msymbol, mark_struct_expression)
9547 (write_dollar_variable)
9548 (insert_type_address_space, increase_expout_size): Replace
9549 "parser_state" with "expr_builder".
9550 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9551 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9552 "parser_state" with "expr_builder".
9553
73923d7e
TT
95542019-04-04 Tom Tromey <tom@tromey.com>
9555
9556 * rust-exp.y: Replace "parse_language" with method call.
9557 * p-exp.y:
9558 (yylex): Replace "parse_language" with method call.
9559 * m2-exp.y:
9560 (yylex): Replace "parse_language" with method call.
9561 * go-exp.y (classify_name): Replace "parse_language" with method
9562 call.
9563 * f-exp.y (yylex): Replace "parse_language" with method call.
9564 * d-exp.y (lex_one_token): Replace "parse_language" with method
9565 call.
9566 * c-exp.y:
9567 (lex_one_token, classify_name, yylex): Replace "parse_language"
9568 with method call.
9569 * ada-exp.y (find_primitive_type, type_char)
9570 (type_system_address): Replace "parse_language" with method call.
9571
fa9f5be6
TT
95722019-04-04 Tom Tromey <tom@tromey.com>
9573
9574 * rust-exp.y: Replace "parse_gdbarch" with method call.
9575 * parse.c (write_dollar_variable, insert_type_address_space):
9576 Replace "parse_gdbarch" with method call.
9577 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9578 call.
9579 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9580 call.
9581 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9582 "parse_gdbarch" with method call.
9583 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9584 with method call.
9585 * f-exp.y (parse_type, parse_f_type, yylex): Replace
9586 "parse_gdbarch" with method call.
9587 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9588 "parse_gdbarch" with method call.
9589 * c-exp.y (parse_type, parse_number, classify_name): Replace
9590 "parse_gdbarch" with method call.
9591 * ada-lex.l: Replace "parse_gdbarch" with method call.
9592 * ada-exp.y (parse_type, find_primitive_type, type_char)
9593 (type_system_address): Replace "parse_gdbarch" with method call.
9594
1201a264
TT
95952019-04-04 Tom Tromey <tom@tromey.com>
9596
9597 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9598 * stap-probe.c (stap_parse_argument): Update.
9599 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9600 initial_size parameter.
9601 * rust-exp.y (rust_lex_tests): Update.
9602 * parse.c (parser_state): Update.
9603 (parse_exp_in_context): Update.
9604 * parser-defs.h (struct parser_state) <parser_state>: Remove
9605 "initial_size" parameter.
9606
e3980ce2
TT
96072019-04-04 Tom Tromey <tom@tromey.com>
9608
9609 * parser-defs.h (increase_expout_size): Don't declare.
9610 * parse.c (increase_expout_size): Now static.
9611
e9f8e3f1
TS
96122019-04-04 Thomas Schwinge <thomas@codesourcery.com>
9613
9614 * gnu-nat.c (gnu_nat_target::wait): Fix
9615 target_waitstatus_to_string call.
9616
d7df6549
AB
96172019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9618
9619 * eval.c (evaluate_subexp_standard): Handle internal functions
9620 during Fortran function call handling.
9621
8bdc1658
AB
96222019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
9623
9624 * NEWS: Mention new internal functions.
9625 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9626 (read_base_type): Use dwarf2_init_complex_target_type.
9627 * value.c (creal_internal_fn): New function.
9628 (cimag_internal_fn): New function.
9629 (_initialize_values): Register new internal functions.
9630
c29705b7
PW
96312019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9632
9633 * infrun.c (stop_all_threads): If debug_infrun, always
9634 trace the wait status after wait_one, using
9635 target_waitstatus_to_string and target_pid_to_str.
9636 (handle_inferior_event): Replace various trace of
9637 wait status kind by a single trace.
9638 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9639 wait status kind image by target_waitstatus_to_string.
9640 * target/waitstatus.c (target_waitstatus_to_string): Fix
9641 obsolete comment.
9642
05caa1d2
TT
96432019-04-01 Tom Tromey <tromey@adacore.com>
9644
9645 PR symtab/23331:
9646 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9647
9d1447e0
SDJ
96482019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
9649 Pedro Alves <palves@redhat.com>
9650
9651 * top.c (quit_force): Call 'finalize_values'.
9652 * value.c (finalize_values): New function.
9653 * value.h (finalize_values): Declare.
9654
7734102d
EZ
96552019-03-30 Eli Zaretskii <eliz@gnu.org>
9656
9657 * NEWS: Announce $_gdb_major and $_gdb_minor.
9658
9659 * top.c (init_gdb_version_vars): New function.
9660 (gdb_init): Call init_gdb_version_vars.
9661
188e1fa9
TT
96622019-03-29 Tom Tromey <tromey@adacore.com>
9663
9664 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
9665 help text. Remove dead code.
9666
2880242d
KS
96672019-03-29 Keith Seitz <keiths@redhat.com>
9668
9669 From Siddhesh Poyarekar:
9670 * f-lang.h (f77_get_upperbound): Return LONGEST.
9671 (f77_get_lowerbound): Likewise.
9672 * f-typeprint.c (f_type_print_varspec_suffix): Expand
9673 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
9674 print them.
9675 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
9676 plongest to format print it.
9677 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9678 (f77_get_upperbound): Likewise.
9679 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9680 LOWER_BOUND to LONGEST.
9681 (f77_create_arrayprint_offset_tbl): Likewise.
9682
cc1defb1
KS
96832019-03-29 Keith Seitz <keiths@redhat.com>
9684
9685 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9686 %s/pulongest for TYPE_LENGTH instead of %d in format
9687 strings.
9688 * ada-typerint.c (ada_print_type): Likewise.
9689 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9690 * compile/compile-c-support.c (generate_register_struct): Likewise.
9691 * gdbtypes.c (recursive_dump_type): Likewise.
9692 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9693 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
9694 instead of %d in format strings.
9695 * riscv-tdep.c (riscv_type_alignment): Cast second argument
9696 to std::min to ULONGEST.
9697 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9698 instead of %d in format strings.
9699 * tracepoint.c (info_scope_command): Likewise.
9700 * typeprint.c (print_offset_data::update)
9701 (print_offset_data::finish): Likewise.
9702 * xtensa-tdep.c (xtensa_store_return_value)
9703 (xtensa_push_dummy_call): Likewise.
9704
e432ccf1
JT
97052019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
9706
9707 * windows-nat.c (display_selector): Fixed format specifications
9708 for 64-bit Cygwin.
9709
65d2b333
PW
97102019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9711
9712 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9713
f489207e
SL
97142019-03-28 Sandra Loosemore <sandra@codesourcery.com>
9715
9716 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9717 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9718 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9719 (nios2_linux_init_abi): Install it.
9720
bffa1015
AH
97212019-03-28 Alan Hayward <alan.hayward@arm.com>
9722
9723 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9724
fc96163a
AH
97252019-03-28 Alan Hayward <alan.hayward@arm.com>
9726
9727 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9728
20dc7e9b
PW
97292019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9730 Tom Tromey <tromey@adacore.com>
9731
9732 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9733
7f5331a8
JB
97342019-03-26 Joel Brobecker <brobecker@adacore.com>
9735
9736 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9737 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9738 method to compute the bounds of range types. Also print "[evaluated]"
9739 if the bounds' values come from a dynamic evaluation.
9740
18c77628
AB
97412019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
9742
9743 * cp-valprint.c (cp_print_value_fields): Don't print trailing
9744 whitespace when pretty printing is on.
9745
53c973f2
AH
97462019-03-26 Alan Hayward <alan.hayward@arm.com>
9747
e79be6e5 9748 * ppc-linux-nat.c: Add include.
53c973f2 9749
d851aa71
AH
97502019-03-26 Alan Hayward <alan.hayward@arm.com>
9751
e79be6e5 9752 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 9753
2fe7bab7
AH
97542019-03-26 Alan Hayward <alan.hayward@arm.com>
9755
e79be6e5 9756 * arm-linux-nat.c: Add include.
2fe7bab7 9757
068ef30e
SM
97582019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
9759
9760 * source-cache.c (source_cache::get_source_lines): Re-read
9761 fullname after calling open_source_file.
9762
81a24d04
JB
97632019-03-25 John Baldwin <jhb@FreeBSD.org>
9764
9765 * NEWS: Mention TLS support for FreeBSD.
9766
79e7ae11
TT
97672019-03-25 Tom Tromey <tromey@adacore.com>
9768
9769 * minsyms.c (BUNCH_SIZE): Update comment.
9770 (~minimal_symbol_reader): Remove old comment.
9771 (compact_minimal_symbols): Update comment.
9772 (minimal_symbol_reader::install): Remove old comment. Update
9773 other comments.
9774
d45963c2
AH
97752019-03-25 Alan Hayward <alan.hayward@arm.com>
9776
9777 * s390-linux-nat.c: Add include.
9778
0f83012e
AH
97792019-03-25 Alan Hayward <alan.hayward@arm.com>
9780
9781 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9782 Call linux_get_hwcap.
9783 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9784 Likewise.
9785 (aarch64_linux_get_hwcap): Remove function.
9786 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9787 declaration.
9788 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9789 linux_get_hwcap.
9790 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9791 * linux-tdep.c (linux_get_hwcap): Add function.
9792 (linux_get_hwcap2): Likewise.
9793 * linux-tdep.h (linux_get_hwcap): Add declaration.
9794 (linux_get_hwcap2): Likewise.
9795 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9796 (ppc_linux_get_hwcap2): Likewise.
9797 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9798 linux_get_hwcap.
9799 (ppc_linux_nat_target::insert_watchpoint): Likewise.
9800 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9801 (ppc_linux_nat_target::read_description): Likewise.
9802 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9803 * s390-linux-nat.c: Likewise.
9804 * s390-linux-tdep.c (s390_core_read_description): Likewise.
9805
6640a367
TT
98062019-03-24 Tom Tromey <tom@tromey.com>
9807
9808 * ada-lang.c (standard_lookup): Simplify initialization.
9809 (ada_lookup_symbol_nonlocal): Simplify return.
9810 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9811 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9812 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9813 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9814 initialization.
9815 * solib.c (solib_global_lookup): Simplify.
9816 * symtab.c (null_block_symbol): Remove.
9817 (symbol_cache_lookup): Simplify returns.
9818 (lookup_language_this): Simplify returns.
9819 (lookup_symbol_aux): Simplify return.
9820 (lookup_local_symbol): Simplify returns.
9821 (lookup_global_symbol_from_objfile): Simplify return.
9822 (lookup_symbol_in_objfile_symtabs)
9823 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9824 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9825 (lookup_static_symbol, lookup_global_symbol): Simplify return.
9826 * cp-namespace.c (cp_lookup_bare_symbol)
9827 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9828 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9829 (cp_lookup_nested_symbol): Don't use null_block_symbol.
9830 (cp_lookup_symbol_via_imports): Simplify initialization.
9831 (find_symbol_in_baseclass): Likewise.
9832 * symtab.h (null_block_symbol): Remove.
9833 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9834 (d_lookup_nested_symbol, d_lookup_symbol_imports)
9835 (d_lookup_symbol_module): Likewise.
9836 (find_symbol_in_baseclass): Simplify initialization.
9837
a930ebcd
TT
98382019-03-24 Tom Tromey <tom@tromey.com>
9839
9840 * expression.h: Don't include symtab.h.
9841 (struct block): Forward declare.
9842
582942f4
TT
98432019-03-24 Tom Tromey <tom@tromey.com>
9844
9845 * c-exp.y (typebase): Remove casts.
9846 * gdbtypes.c (lookup_unsigned_typename, )
9847 (lookup_signed_typename): Remove cast.
9848 * eval.c (parse_to_comma_and_eval): Remove cast.
9849 * parse.c (write_dollar_variable): Remove cast.
9850 * block.h (struct block) <superblock>: Now const.
9851 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9852 * psymtab.c (psym_map_matching_symbols): Make "block" const.
9853 (map_block): Make "block" const.
9854 * symfile.h (struct quick_symbol_functions)
9855 <map_matching_symbols>: Constify block argument to "callback".
9856 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9857 const.
9858 (find_pc_sect_compunit_symtab): Make "b" const.
9859 (find_symbol_at_address): Likewise.
9860 (search_symbols): Likewise.
9861 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9862 (dw2_debug_names_lookup_symbol): Likewise.
9863 (dw2_map_matching_symbols): Update.
9864 * p-valprint.c (pascal_val_print): Remove "block".
9865 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9866 (aux_add_nonlocal_symbols): Make "block" const.
9867 (resolve_subexp): Remove cast.
9868 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9869 const.
9870 (iterate_over_file_blocks): Likewise.
9871 * f-exp.y (%union) <bval>: Remove.
9872 * coffread.c (patch_opaque_types): Make "b" const.
9873 * spu-tdep.c (spu_catch_start): Make "block" const.
9874 * c-valprint.c (print_unpacked_pointer): Remove "block".
9875 * symmisc.c (dump_symtab_1): Make "b" const.
9876 (block_depth): Make "block" const.
9877 * d-exp.y (%union) <bval>: Remove.
9878 * cp-support.h (cp_lookup_rtti_type): Update.
9879 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9880 * psymtab.c (psym_lookup_symbol): Make "block" const.
9881 (maintenance_check_psymtabs): Make "b" const.
9882 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9883 (enumerate_locals, enumerate_args): Update.
9884 * python/py-symtab.c (stpy_global_block): Make "block" const.
9885 (stpy_static_block): Likewise.
9886 * inline-frame.c (block_starting_point_at): Make "new_block"
9887 const.
9888 * block.c (find_block_in_blockvector): Make return type const.
9889 (blockvector_for_pc_sect): Make "b" const.
9890 (find_block_in_blockvector): Make "b" const.
9891
7ad417dd
TT
98922019-03-23 Tom Tromey <tom@tromey.com>
9893
9894 * varobj.c (varobj_create): Update.
9895 * symfile.c (clear_symtab_users): Don't reset innermost_block.
9896 * printcmd.c (display_command, do_one_display): Don't reset
9897 innermost_block.
9898 * parser-defs.h (enum innermost_block_tracker_type): Move to
9899 expression.h.
9900 (innermost_block): Update comment.
9901 * parse.c (parse_exp_1): Add tracker_types parameter.
9902 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
9903 tracker_types parameter. Reset innermost_block.
9904 (parse_exp_in_context): Remove.
9905 (parse_expression_for_completion): Update.
9906 * objfiles.c (~objfile): Don't reset expression_context_block or
9907 innermost_block.
9908 * expression.h (enum innermost_block_tracker_type): Move from
9909 parser-defs.h.
9910 (parse_exp_1): Add tracker_types parameter.
9911 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9912 reset innermost_block.
9913
b366c208
TT
99142019-03-23 Tom Tromey <tom@tromey.com>
9915
9916 * objfiles.h: Include bcache.h.
9917
9bb9b2f9
TT
99182019-03-23 Tom Tromey <tom@tromey.com>
9919
9920 * linespec.c (get_current_search_block): Use
9921 scoped_restore_current_language.
9922 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9923
59c28372
AH
99242019-03-22 Alan Hayward <alan.hayward@arm.com>
9925 Jiong Wang <jiong.wang@arm.com>
9926
9927 * aarch64-linux-tdep.c
9928 (aarch64_linux_iterate_over_regset_sections): Check for pauth
9929 section.
9930 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9931
17e116a7
AH
99322019-03-22 Alan Hayward <alan.hayward@arm.com>
9933 Jiong Wang <jiong.wang@arm.com>
9934
9935 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9936 instructions.
9937 (aarch64_analyze_prologue_test): Add PACIASP test.
9938 (aarch64_prologue_prev_register): Unmask PC value.
9939
11e1b75f
AH
99402019-03-22 Alan Hayward <alan.hayward@arm.com>
9941 Jiong Wang <jiong.wang@arm.com>
9942
9943 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9944 (aarch64_dwarf2_prev_register): Unmask PC value.
9945 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9946 (aarch64_execute_dwarf_cfa_vendor_op): Check for
9947 DW_CFA_AARCH64_negate_ra_state.
9948 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9949
34dcc7cf
AH
99502019-03-22 Alan Hayward <alan.hayward@arm.com>
9951 Jiong Wang <jiong.wang@arm.com>
9952
9953 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9954 registers.
9955 (aarch64_pseudo_register_name): Likewise.
9956 (aarch64_pseudo_register_type): Likewise.
9957 (aarch64_pseudo_register_reggroup_p): Likewise.
9958 (aarch64_gdbarch_init): Add pauth registers.
9959 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9960 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9961 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9962 (struct gdbarch_tdep): Add regnum for ra_state.
9963
1ef53e6b
AH
99642019-03-22 Alan Hayward <alan.hayward@arm.com>
9965 Jiong Wang <jiong.wang@arm.com>
9966
9967 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9968
76bed0fd
AH
99692019-03-22 Alan Hayward <alan.hayward@arm.com>
9970 Jiong Wang <jiong.wang@arm.com>
9971
9972 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9973 function.
9974 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9975 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9976 (aarch64_gdbarch_init): Add puth registers.
9977 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9978 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9979 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9980
ee4fbcfa
AH
99812019-03-22 Alan Hayward <alan.hayward@arm.com>
9982 Jiong Wang <jiong.wang@arm.com>
9983
9984 * aarch64-linux-nat.c
9985 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9986 * aarch64-linux-tdep.c
9987 (aarch64_linux_core_read_description): Likewise.
9988 (aarch64_linux_get_hwcap): New function.
9989 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9990 (aarch64_linux_get_hwcap): New declaration.
9991
6dc0ebde
AH
99922019-03-22 Alan Hayward <alan.hayward@arm.com>
9993 Jiong Wang <jiong.wang@arm.com>
9994
9995 * aarch64-linux-nat.c
9996 (aarch64_linux_nat_target::read_description): Add pauth param.
9997 * aarch64-linux-tdep.c
9998 (aarch64_linux_core_read_description): Likewise.
9999 * aarch64-tdep.c (struct target_desc): Add in pauth.
10000 (aarch64_read_description): Add pauth param.
10001 (aarch64_gdbarch_init): Likewise.
10002 * aarch64-tdep.h (aarch64_read_description): Likewise.
10003 * arch/aarch64.c (aarch64_create_target_description): Likewise.
10004 * arch/aarch64.h (aarch64_create_target_description): Likewise.
10005 * features/Makefile: Add new files.
10006 * features/aarch64-pauth.c: New file.
10007 * features/aarch64-pauth.xml: New file.
10008
595915c1
TT
100092019-03-20 Tom Tromey <tromey@adacore.com>
10010
10011 * infrun.c (handle_inferior_event): Rename from
10012 handle_inferior_event_1. Create a scoped_value_mark.
10013 (handle_inferior_event): Remove.
10014
4c7d57e7
TT
100152019-03-19 Tom Tromey <tromey@adacore.com>
10016
10017 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10018 * infrun.h (print_stop_event): Add "displays" parameter.
10019 * infrun.c (print_stop_event): Add "displays" parameter.
10020
cb246234
PA
100212019-03-19 Pedro Alves <palves@redhat.com>
10022
10023 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10024 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
10025 to -1. Fix TABs vs spaces.
10026 (tui_ui_out::tui_ui_out): Don't initialize fields here.
10027 * tui/tui-out.h (tui_ui_out) Add intro comments.
10028 <m_line, m_start_of_line>: In-class initialize, and add describing
10029 comment.
10030
3a0e45b2
AH
100312019-03-18 Alan Hayward <alan.hayward@arm.com>
10032
10033 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10034 variable names.
10035 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10036
5371b850
PA
100372019-03-18 Pedro Alves <palves@redhat.com>
10038 Eli Zaretskii <eliz@gnu.org>
10039
10040 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10041 m_line and m_start_of_line.
10042
b17c4cd0
EZ
100432019-03-18 Eli Zaretskii <eliz@gnu.org>
10044
10045 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10046 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10047 it returns a newline. This fixes a regression in TU mode, whereby
10048 the next line is output on the same screen line as the user input.
10049
4bd56d18
TT
100502019-03-18 Tom Tromey <tromey@adacore.com>
10051
10052 * minsyms.c (minimal_symbol_reader::install): Remove call to
10053 obstack_blank.
10054
55c10aca
PA
100552019-03-18 Pedro Alves <palves@redhat.com>
10056
10057 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10058 New globals.
10059 (apply_style): New, factored out from ...
10060 (apply_ansi_escape): ... this. Handle reverse video mode.
10061 (tui_set_reverse_mode): New function.
10062 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10063 * tui/tui-winsource.c (tui_show_source_line): Use
10064 tui_set_reverse_mode instead of setting A_STANDOUT.
10065 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10066 New setter methods.
10067
647bb750
HD
100682019-03-18 Hannes Domani <ssbssa@yahoo.de>
10069
10070 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10071 Handle tabs.
10072
bff8c71f
TT
100732019-03-18 Tom Tromey <tromey@adacore.com>
10074
10075 * ada-lang.c (empty_array): Add "high" parameter.
10076 (ada_evaluate_subexp): Update.
10077
58785d98
ST
100782019-03-17 Sergei Trofimovich <siarheit@google.com>
10079
10080 * unittests/string_view-selftests.c: Define
10081 _initialize_string_view_selftests unconditionally.
10082
d4cbef22
ВМ
100832019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10084
10085 PR gdb/24350
10086 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10087
fce4c071
ВМ
100882019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
10089
10090 PR gdb/24351
10091 * windows-nat.c (display_selector): Fix format specifiers.
10092
f7f0a123
EZ
100932019-03-17 Eli Zaretskii <eliz@gnu.org>
10094
10095 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10096 tui_refill_source_window instead of tui_refresh_win, to update the
10097 current execution line. This fixes redisplay of the current line
10098 when stepping through the code with "next" or "step".
10099
ab42892f
EZ
101002019-03-16 Eli Zaretskii <eliz@gnu.org>
10101
10102 * source-cache.c (source_cache::get_source_lines): Call
10103 find_source_lines to initialize s->nlines. This fixes vertical
10104 scrolling of TUI source window when the DOWN arrow is pressed.
10105
8d8c087f
PW
101062019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10107
10108 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10109 linux-thread-db.c (_initialize_thread_db): Likewise.
10110
798e1c30
EZ
101112019-03-16 Eli Zaretskii <eliz@gnu.org>
10112
10113 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10114 wclrtoeol in tui_show_source_line". This reverts changes made in
10115 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10116
eefba3da
TT
101172019-03-15 Tom Tromey <tom@tromey.com>
10118
10119 * symtab.h (struct minimal_symbol): Derive from
10120 general_symbol_info.
10121 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10122 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10123 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10124 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10125 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10126 (MSYMBOL_SEARCH_NAME): Update.
10127 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10128 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10129 * minsyms.c (minimal_symbol_reader::record_full): Update.
10130
0de2420c
TT
101312019-03-15 Tom Tromey <tom@tromey.com>
10132
10133 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10134
042d75e4
TT
101352019-03-15 Tom Tromey <tom@tromey.com>
10136
10137 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10138 unique_xmalloc_ptr.
10139 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10140 Update.
10141 * minsyms.c (lookup_minimal_symbol_by_pc_section)
10142 (build_minimal_symbol_hash_tables)
10143 (minimal_symbol_reader::install): Update.
10144
db92718b
TT
101452019-03-15 Tom Tromey <tom@tromey.com>
10146
10147 * symtab.c (create_demangled_names_hash): Update.
10148 (symbol_set_names): Update.
10149 * objfiles.h (struct objfile_per_bfd_storage)
10150 <demangled_names_hash>: Now an htab_up.
10151 * objfiles.c (objfile_per_bfd_storage): Simplify.
10152
d6797f46
TT
101532019-03-15 Tom Tromey <tom@tromey.com>
10154
10155 * objfiles.h (struct objfile_per_bfd_storage): Declare
10156 destructor.
10157 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10158 New.
10159 (get_objfile_bfd_data): Use new. Don't initialize
10160 language_of_main.
10161 (free_objfile_per_bfd_storage): Remove.
10162 (objfile_bfd_data_free, objfile::~objfile): Use delete.
10163
741d7538
TT
101642019-03-15 Tom Tromey <tom@tromey.com>
10165
10166 * symfile.c (reread_symbols): Update.
10167 * objfiles.c (objfile::objfile): Update.
10168 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10169 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10170 comment.
10171 (minimal_symbol_reader::install): Update.
10172 (terminate_minimal_symbol_table): Remove.
10173 * jit.c (jit_object_close_impl): Update.
10174
788c80d1
TT
101752019-03-15 Tom Tromey <tom@tromey.com>
10176
10177 * minsyms.c (minimal_symbol_reader::record_full): Remove some
10178 initializations.
10179
1b7a07cb
TT
101802019-03-15 Tom Tromey <tom@tromey.com>
10181
10182 * objfiles.h (struct objfile_per_bfd_storage)
10183 <demangled_hash_languages>: Now a bitset.
10184 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10185 (lookup_minimal_symbol): Update.
10186
3db066bc
TT
101872019-03-15 Tom Tromey <tom@tromey.com>
10188
10189 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10190 Don't return the symbol.
10191 * coffread.c (record_minimal_symbol): Use record_full.
10192
3fff2c37
EZ
101932019-03-14 Eli Zaretskii <eliz@gnu.org>
10194
10195 The MS-Windows port of ncurses fails to switch to a color pair if
10196 one or both of the colors are the implicit default colors. This
10197 change records the default colors when TUI is initialized, and
10198 then specifies them explicitly when a color pair uses the default
10199 colors. This allows color styling in TUI mode on MS-Windows.
10200
10201 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
10202 ncurses_norm_attr.
10203 (tui_initialize_io) [__MINGW32__]: Record the default terminal
10204 colors in ncurses_norm_attr.
10205 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10206 "none", replace it with the default color recorded in
10207 ncurses_norm_attr.
10208
3b336828
TT
102092019-03-14 Tom Tromey <tromey@adacore.com>
10210
10211 * source-cache.h (class source_cache) <get_source_lines>: Return
10212 std::string.
10213 * source-cache.c (source_cache::extract_lines): Handle case where
10214 first_pos==npos. Return std::string.
10215 (source_cache::get_source_lines): Update.
10216
d085f989
TT
102172019-03-14 Tom Tromey <tromey@adacore.com>
10218
10219 * NEWS: Add item for "style sources" commands.
10220 * source-cache.c (source_cache::get_source_lines): Check
10221 source_styling.
10222 * cli/cli-style.c (source_styling): New global.
10223 (_initialize_cli_style): Add "style sources" commands.
10224 (show_style_sources): New function.
10225 * cli/cli-style.h (source_styling): Declare.
10226
6f11e682
TT
102272019-03-14 Pedro Alves <palves@redhat.com>
10228 Tom Tromey <tromey@adacore.com>
10229
10230 * tui/tui-winsource.h (tui_refill_source_window): Declare.
10231 * tui/tui-winsource.c (tui_refill_source_window): New function,
10232 from...
10233 (tui_horizontal_source_scroll): ... here. Move some logic.
10234 * cli/cli-style.c (set_style_enabled): Notify new observable.
10235 * tui/tui-hooks.c (tui_redisplay_source): New function.
10236 (tui_attach_detach_observers): Attach or detach
10237 tui_redisplay_source.
10238 * observable.h (source_styling_changed): New observable.
10239 * observable.c: Define source_styling_changed observable.
10240
a068643d
TT
102412019-03-13 Tom Tromey <tromey@adacore.com>
10242
10243 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10244 (i386_gnu_nat_target::store_registers): Update.
10245 * target-debug.h (target_debug_print_std_string): New macro.
10246 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10247 * windows-tdep.c (display_one_tib): Update.
10248 * tui/tui-stack.c (tui_make_status_line): Update.
10249 * top.c (print_inferior_quit_action): Update.
10250 * thread.c (thr_try_catch_cmd): Update.
10251 (add_thread_with_info): Update.
10252 (thread_target_id_str): Update.
10253 (thr_try_catch_cmd): Update.
10254 (thread_command): Update.
10255 (thread_find_command): Update.
10256 * record-btrace.c (record_btrace_target::info_record)
10257 (record_btrace_resume_thread, record_btrace_target::resume)
10258 (record_btrace_cancel_resume, record_btrace_step_thread)
10259 (record_btrace_target::wait, record_btrace_target::wait)
10260 (record_btrace_target::wait, record_btrace_target::stop): Update.
10261 * progspace.c (print_program_space): Update.
10262 * process-stratum-target.c
10263 (process_stratum_target::thread_address_space): Update.
10264 * linux-fork.c (linux_fork_mourn_inferior)
10265 (detach_checkpoint_command, info_checkpoints_command)
10266 (linux_fork_context): Update.
10267 (linux_fork_detach): Update.
10268 (class scoped_switch_fork_info): Update.
10269 (delete_checkpoint_command): Update.
10270 * infrun.c (follow_fork_inferior): Update.
10271 (follow_fork_inferior): Update.
10272 (proceed_after_vfork_done): Update.
10273 (handle_vfork_child_exec_or_exit): Update.
10274 (follow_exec): Update.
10275 (displaced_step_prepare_throw): Update.
10276 (displaced_step_restore): Update.
10277 (start_step_over): Update.
10278 (resume_1): Update.
10279 (clear_proceed_status_thread): Update.
10280 (proceed): Update.
10281 (print_target_wait_results): Update.
10282 (do_target_wait): Update.
10283 (context_switch): Update.
10284 (stop_all_threads): Update.
10285 (restart_threads): Update.
10286 (finish_step_over): Update.
10287 (handle_signal_stop): Update.
10288 (switch_back_to_stepped_thread): Update.
10289 (keep_going_pass_signal): Update.
10290 (print_exited_reason): Update.
10291 (normal_stop): Update.
10292 * inferior.c (inferior_pid_to_str): Change return type.
10293 (print_selected_inferior): Update.
10294 (add_inferior): Update.
10295 (detach_inferior): Update.
10296 * dummy-frame.c (fprint_dummy_frames): Update.
10297 * dcache.c (dcache_info_1): Update.
10298 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10299 (btrace_fetch, btrace_clear): Update.
10300 * linux-tdep.c (linux_core_pid_to_str): Change return type.
10301 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10302 type.
10303 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10304 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10305 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10306 * gdbarch.c, gdbarch.h: Rebuild.
10307 * gdbarch.sh (core_pid_to_str): Change return type.
10308 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10309 return type.
10310 (windows_nat_target::pid_to_str): Change return type.
10311 (windows_delete_thread): Update.
10312 (windows_nat_target::attach): Update.
10313 (windows_nat_target::files_info): Update.
10314 * target-delegates.c: Rebuild.
10315 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10316 return type.
10317 (sol_thread_target::pid_to_str): Change return type.
10318 * remote.c (class remote_target) <pid_to_str>: Change return
10319 type.
10320 (remote_target::pid_to_str): Change return type.
10321 (extended_remote_target::attach, remote_target::remote_stop_ns)
10322 (remote_target::remote_notif_remove_queued_reply)
10323 (remote_target::push_stop_reply, remote_target::disable_btrace):
10324 Update.
10325 (extended_remote_target::attach): Update.
10326 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10327 type.
10328 (gdbsim_target::pid_to_str): Change return type.
10329 * ravenscar-thread.c (struct ravenscar_thread_target)
10330 <pid_to_str>: Change return type.
10331 (ravenscar_thread_target::pid_to_str): Change return type.
10332 * procfs.c (class procfs_target) <pid_to_str>: Change return
10333 type.
10334 (procfs_target::pid_to_str): Change return type.
10335 (procfs_target::attach): Update.
10336 (procfs_target::detach): Update.
10337 (procfs_target::fetch_registers): Update.
10338 (procfs_target::store_registers): Update.
10339 (procfs_target::wait): Update.
10340 (procfs_target::files_info): Update.
10341 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10342 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10343 return type.
10344 (nto_procfs_target::pid_to_str): Change return type.
10345 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10346 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10347 return type.
10348 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10349 (exit_lwp): Update.
10350 (attach_proc_task_lwp_callback, get_detach_signal)
10351 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10352 (linux_nat_target::resume, wait_lwp, stop_callback)
10353 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10354 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10355 (linux_nat_wait_1, resume_stopped_resumed_lwps)
10356 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10357 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10358 type.
10359 (inf_ptrace_target::attach): Update.
10360 (inf_ptrace_target::files_info): Update.
10361 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10362 type.
10363 (go32_nat_target::pid_to_str): Change return type.
10364 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10365 (gnu_nat_target::wait): Update.
10366 (gnu_nat_target::wait): Update.
10367 (gnu_nat_target::resume): Update.
10368 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10369 (fbsd_nat_target::wait): Update.
10370 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10371 type.
10372 (darwin_nat_target::attach): Update.
10373 * corelow.c (class core_target) <pid_to_str>: Change return type.
10374 (core_target::pid_to_str): Change return type.
10375 * target.c (normal_pid_to_str): Change return type.
10376 (default_pid_to_str): Likewise.
10377 (target_pid_to_str): Change return type.
10378 (target_translate_tls_address): Update.
10379 (target_announce_detach): Update.
10380 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10381 return type.
10382 (bsd_uthread_target::pid_to_str): Change return type.
10383 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10384 type.
10385 (bsd_kvm_target::pid_to_str): Change return type.
10386 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10387 return type.
10388 (aix_thread_target::pid_to_str): Change return type.
10389 * target.h (struct target_ops) <pid_to_str>: Change return type.
10390 (target_pid_to_str, normal_pid_to_str): Likewise.
10391 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10392 type.
10393 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10394 type.
10395 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10396 return type.
10397 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10398 type.
10399 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10400 type.
10401 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10402 return type.
10403
b4be1b06
SM
104042019-03-13 Simon Marchi <simon.marchi@ericsson.com>
10405
10406 * NEWS: Mention that the new default MI version is 3. Mention
10407 changes to the output of commands and events that deal with
10408 multi-location breakpoints.
10409 * breakpoint.c: Include "mi/mi-out.h".
10410 (print_one_breakpoint): Change output syntax if using MI version
10411 >= 3.
10412 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10413 New.
10414 (mi_multi_location_breakpoint_output_fixed): New.
10415 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10416 (mi_cmd_fix_multi_location_breakpoint_output): New.
10417 (mi_multi_location_breakpoint_output_fixed): New.
10418 * mi/mi-cmds.c (mi_cmds): Register command
10419 -fix-multi-location-breakpoint-output.
10420 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10421 interpreter "mi".
10422
8e5e5494
SM
104232019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
10424
10425 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10426 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10427 instantiate mi_ui_out based on interpreter name.
10428 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10429 * mi/mi-main.c (mi_load_progress): Likewise.
10430
197df35e
JB
104312019-03-12 John Baldwin <jhb@FreeBSD.org>
10432
10433 * NEWS: Combine separate "New targets" sections for 8.3.
10434
8399425f
JB
104352019-03-12 John Baldwin <jhb@FreeBSD.org>
10436
10437 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10438 (ppcfbsd_init_abi): Install gdbarch
10439 "fetch_tls_load_module_address" and "get_thread_local_address"
10440 methods.
10441
b0f87ed0
JB
104422019-03-12 John Baldwin <jhb@FreeBSD.org>
10443
10444 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10445 (riscv_fbsd_init_abi): Install gdbarch
10446 "fetch_tls_load_module_address" and "get_thread_local_address"
10447 methods.
10448
ce25aa57
JB
104492019-03-12 John Baldwin <jhb@FreeBSD.org>
10450
10451 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10452 (i386fbsd_init_abi): Install gdbarch
10453 "fetch_tls_load_module_address" and "get_thread_local_address"
10454 methods.
10455
f5424cfa
JB
104562019-03-12 John Baldwin <jhb@FreeBSD.org>
10457
10458 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10459 (amd64fbsd_init_abi): Install gdbarch
10460 "fetch_tls_load_module_address" and "get_thread_local_address"
10461 methods.
10462
945f3901
JB
104632019-03-12 John Baldwin <jhb@FreeBSD.org>
10464
10465 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10466 (struct fbsd_pspace_data): New type.
10467 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10468 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10469 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10470 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10471 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10472
ef0bd204
JB
104732019-03-12 John Baldwin <jhb@FreeBSD.org>
10474
10475 * gdbtypes.c (lookup_struct_elt): New function.
10476 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10477 * gdbtypes.h (struct struct_elt): New type.
10478 (lookup_struct_elt): New prototype.
10479
36c53a02
JB
104802019-03-12 John Baldwin <jhb@FreeBSD.org>
10481
10482 * gdbtypes.c (lookup_struct_elt_type): Update comment and
10483 remove disabled code block.
10484
6e056c81
JB
104852019-03-12 John Baldwin <jhb@FreeBSD.org>
10486
10487 * gdbarch.sh (get_thread_local_address): New method.
10488 * gdbarch.h, gdbarch.c: Regenerate.
10489 * target.c (target_translate_tls_address): Use
10490 gdbarch_get_thread_local_address if present instead of
10491 target::get_thread_local_address.
10492
cd250a18
JB
104932019-03-12 John Baldwin <jhb@FreeBSD.org>
10494
10495 * target.h (target::get_thread_local_address): Update comment.
10496
df22c1e5
JB
104972019-03-12 John Baldwin <jhb@FreeBSD.org>
10498
10499 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10500 objfile->separate_debug_objfile_backlink if not NULL.
10501
dd6876c9
JB
105022019-03-12 John Baldwin <jhb@FreeBSD.org>
10503
10504 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10505 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10506 (amd64bsd_store_inferior_registers): Likewise.
10507 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10508 Enable segment base registers.
10509 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10510 PT_GETFSBASE and PT_GETGSBASE.
10511 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10512 PT_SETGSBASE.
10513 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10514 segment base registers.
10515 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10516
1163a4b7
JB
105172019-03-12 John Baldwin <jhb@FreeBSD.org>
10518
10519 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10520 Update calls to i386_target_description to add 'segments'
10521 parameter.
10522 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
10523 add segment base registers.
10524 * arch/i386.c (i386_create_target_description): Add 'segments'
10525 parameter to enable segment base registers.
10526 * arch/i386.h (i386_create_target_description): Likewise.
10527 * features/i386/32bit-segments.xml: New file.
10528 * features/i386/32bit-segments.c: Generate.
10529 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10530 call to i386_target_description to add 'segments' parameter.
10531 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10532 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10533 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10534 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10535 if feature is present.
10536 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10537 Add 'segments' parameter to call to i386_target_description.
10538 (i386_target_description): Add 'segments' parameter to enable
10539 segment base registers.
10540 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10541 to call to i386_target_description.
10542 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10543 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10544 Define I386_NUM_REGS.
10545 (i386_target_description): Add 'segments' parameter to enable
10546 segment base registers.
10547
3a350822
EZ
105482019-03-12 Eli Zaretskii <eliz@gnu.org>
10549
10550 PR/24325
10551 * source-cache.c: #undef open and close, to avoid unresolved
10552 externals during linking.
10553
ffdd69cf
TT
105542019-03-12 Tom Tromey <tromey@adacore.com>
10555
10556 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10557 const. Add initializers.
10558 (_initialize_remote): Don't initialize ptid globals.
10559
ec148c57
PA
105602019-03-12 Pedro Alves <palves@redhat.com>
10561
10562 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10563
32764270
PA
105642019-03-12 Pedro Alves <palves@redhat.com>
10565
10566 * cp-name-parser.y (main): Remove unused 'len' variable.
10567
17547186
TT
105682019-03-12 Tom Tromey <tromey@adacore.com>
10569
10570 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10571 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10572
d3a70e03
TT
105732019-03-12 Tom Tromey <tromey@adacore.com>
10574
10575 * linux-nat.c (iterate_over_lwps): Update.
10576 (stop_callback): Remove parameter.
10577 (stop_wait_callback, detach_callback, resume_set_callback)
10578 (select_singlestep_lwp_callback, set_ignore_sigint)
10579 (status_callback, resumed_callback, resume_clear_callback)
10580 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10581 data parameter.
10582 (linux_nat_target::detach, linux_nat_target::resume)
10583 (linux_stop_and_wait_all_lwps, select_event_lwp)
10584 (linux_nat_filter_event, linux_nat_wait_1)
10585 (linux_nat_target::kill, linux_nat_target::stop)
10586 (linux_nat_target::stop): Update.
10587 (linux_nat_resume_callback): Change type.
10588 (resume_stopped_resumed_lwps, count_events_callback)
10589 (select_event_lwp_callback): Likewise.
10590 (linux_stop_lwp, linux_nat_stop_lwp): Update.
10591 * arm-linux-nat.c (struct update_registers_data): Remove.
10592 (update_registers_callback): Change type.
10593 (arm_linux_insert_hw_breakpoint1): Update.
10594 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10595 parameter.
10596 (x86_linux_dr_set_addr): Update.
10597 (x86_linux_dr_set_control): Update.
10598 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10599 (iterate_over_lwps): Use gdb::function_view.
10600 * nat/aarch64-linux-hw-point.c (struct
10601 aarch64_dr_update_callback_param): Remove.
10602 (debug_reg_change_callback): Change type.
10603 (aarch64_notify_debug_reg_change): Update.
10604 * s390-linux-nat.c (s390_refresh_per_info): Update.
10605
82cb27ff
TT
106062019-03-11 Tom Tromey <tromey@adacore.com>
10607
10608 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10609 redundant assignment to "this_cu".
10610
568c0683
SM
106112019-03-08 Simon Marchi <simon.marchi@efficios.com>
10612
10613 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10614
f09ce22d
SM
106152019-03-08 Simon Marchi <simon.marchi@efficios.com>
10616
10617 * gdbtypes.c (rank_one_type_parm_set): New function extracted
10618 from...
10619 (rank_one_type): ... this.
10620
595f96a9
SM
106212019-03-08 Simon Marchi <simon.marchi@efficios.com>
10622
10623 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10624 from...
10625 (rank_one_type): ... this.
10626
2598a94b
SM
106272019-03-08 Simon Marchi <simon.marchi@efficios.com>
10628
10629 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10630 from...
10631 (rank_one_type): ... this.
10632
7f17b20d
SM
106332019-03-08 Simon Marchi <simon.marchi@efficios.com>
10634
10635 * gdbtypes.c (rank_one_type_parm_float): New function extracted
10636 from...
10637 (rank_one_type): ... this.
10638
2c509035
SM
106392019-03-08 Simon Marchi <simon.marchi@efficios.com>
10640
10641 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10642 from...
10643 (rank_one_type): ... this.
10644
0dd322dc
SM
106452019-03-08 Simon Marchi <simon.marchi@efficios.com>
10646
10647 * gdbtypes.c (rank_one_type_parm_range): New function extracted
10648 from...
10649 (rank_one_type): ... this.
10650
41ea4728
SM
106512019-03-08 Simon Marchi <simon.marchi@efficios.com>
10652
10653 * gdbtypes.c (rank_one_type_parm_char): New function extracted
10654 from...
10655 (rank_one_type): ... this.
10656
793cd1d2
SM
106572019-03-08 Simon Marchi <simon.marchi@efficios.com>
10658
10659 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10660 from...
10661 (rank_one_type): ... this.
10662
34910087
SM
106632019-03-08 Simon Marchi <simon.marchi@efficios.com>
10664
10665 * gdbtypes.c (rank_one_type_parm_int): New function extracted
10666 from...
10667 (rank_one_type): ... this.
10668
f1f832d6
SM
106692019-03-08 Simon Marchi <simon.marchi@efficios.com>
10670
10671 * gdbtypes.c (rank_one_type_parm_func): New function extracted
10672 from...
10673 (rank_one_type): ... this.
10674
b9f4512f
SM
106752019-03-08 Simon Marchi <simon.marchi@efficios.com>
10676
10677 * gdbtypes.c (rank_one_type_parm_array): New function extracted
10678 from...
10679 (rank_one_type): ... this.
10680
9293fc63
SM
106812019-03-08 Simon Marchi <simon.marchi@efficios.com>
10682
10683 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10684 from...
10685 (rank_one_type): ... this.
10686
e3abbe7e
PW
106872019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10688
10689 * inferior.c (initialize_inferiors): Ensure 'help set/show print
10690 inferior-events' shows the example events.
10691
e4adb939
EZ
106922019-03-08 Eli Zaretskii <eliz@gnu.org>
10693
10694 Support styling on native MS-Windows console
10695
10696 PR/24315
10697 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10698 on MS-Windows if $TERM is not defined.
10699
10700 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10701
10702 * posix-hdep.c (gdb_console_fputs):
10703 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10704 functions.
10705 * ui-file.h (gdb_console_fputs): Add prototype.
10706
10707 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10708 back to fputs only if the former returns zero.
10709
25629dfd
TT
107102019-03-07 Tom Tromey <tom@tromey.com>
10711
10712 * symmisc.c (print_symbol_bcache_statistics): Update.
10713 (print_objfile_statistics): Update.
10714 * symfile.c (allocate_symtab): Update.
10715 * stabsread.c: Don't include bcache.h.
10716 * psymtab.h (struct psymbol_bcache): Don't declare.
10717 (class psymtab_storage) <psymbol_cache>: Now a bcache.
10718 (psymbol_bcache_init, psymbol_bcache_free)
10719 (psymbol_bcache_get_bcache): Don't declare.
10720 * psymtab.c (struct psymbol_bcache): Remove.
10721 (psymtab_storage::psymtab_storage): Update.
10722 (psymtab_storage::~psymtab_storage): Update.
10723 (psymbol_bcache_init, psymbol_bcache_free)
10724 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10725 (add_psymbol_to_bcache): Update.
10726 (allocate_psymtab): Update.
10727 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10728 macro_cache>: No longer pointers.
10729 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10730 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10731 * macrotab.c (macro_bcache): Update.
10732 * macroexp.c: Don't include bcache.h.
10733 * gdbtypes.c (check_types_worklist): Update.
10734 (types_deeply_equal): Remove TRY/CATCH. Update.
10735 * elfread.c (elf_symtab_read): Update.
10736 * dwarf2read.c: Don't include bcache.h.
10737 * buildsym.c (buildsym_compunit::get_macro_table): Update.
10738 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10739 (print_bcache_statistics, bcache_memory_used): Don't declare.
10740 (struct bcache): Move from bcache.c. Add constructor, destructor,
10741 methods. Rename all data members.
10742 * bcache.c (struct bcache): Move to bcache.h.
10743 (bcache::expand_hash_table): Rename from expand_hash_table.
10744 (bcache): Remove.
10745 (bcache::insert): Rename from bcache_full.
10746 (bcache::compare): Rename from bcache_compare.
10747 (bcache_xmalloc): Remove.
10748 (bcache::~bcache): Rename from bcache_xfree.
10749 (bcache::print_statistics): Rename from print_bcache_statistics.
10750 (bcache::memory_used): Rename from bcache_memory_used.
10751
fe726667
PA
107522019-03-07 Pedro Alves <palves@redhat.com>
10753
10754 * infrun.c (normal_stop): Also check for
10755 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10756
7584bb30
AB
107572019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
10758
10759 * f-lang.c (value_from_host_double): Moved to...
10760 * value.c (value_from_host_double): ...here.
10761 * value.h (value_from_host_double): Declare.
10762 * guile/scm-math.c (vlscm_convert_typed_number): Use
10763 value_from_host_double.
10764 (vlscm_convert_number): Likewise.
10765 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10766 * python/py-value.c (convert_value_from_python): Likewise.
10767
a7b1986e
TT
107682019-03-06 Tom Tromey <tom@tromey.com>
10769
10770 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10771
0ccf4211
TT
107722019-03-06 Tom Tromey <tom@tromey.com>
10773
10774 * utils.h (free_current_contents): Don't declare.
10775 * utils.c (free_current_contents): Remove.
10776
fe7b42e5
TT
107772019-03-06 Tom Tromey <tom@tromey.com>
10778
10779 * top.c (quit_force): Update.
10780 * main.c (captured_command_loop): Update.
10781 * common/new-op.c (operator new): Update.
10782 * common/common-exceptions.c (struct catcher)
10783 <save_cleanup_chain>: Remove member.
10784 (exceptions_state_mc_init): Update.
10785 (exception_try_scope_entry): Return nullptr.
10786 (exception_try_scope_exit, exception_rethrow)
10787 (throw_exception_sjlj, throw_exception_cxx): Update.
10788 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10789 (all_cleanups, do_cleanups, discard_cleanups)
10790 (discard_final_cleanups, save_cleanups, save_final_cleanups)
10791 (restore_cleanups, restore_final_cleanups): Don't declare.
10792 (do_final_cleanups): Remove parameter.
10793 * common/cleanups.c (cleanup_chain, make_cleanup)
10794 (make_cleanup_dtor, all_cleanups, do_cleanups)
10795 (discard_my_cleanups, discard_cleanups)
10796 (discard_final_cleanups, save_my_cleanups, save_cleanups)
10797 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10798 (null_cleanup): Remove.
10799 (do_final_cleanups): Remove parameter.
10800
c6321f19
TT
108012019-03-06 Tom Tromey <tom@tromey.com>
10802
10803 * remote.c (remote_target::remote_parse_stop_reply): Use
10804 unique_xmalloc_ptr.
10805
61b30099
TT
108062019-03-06 Tom Tromey <tom@tromey.com>
10807
10808 * stabsread.c (struct stabs_field_info): Rename from field_info.
10809 <list, fnlist>: Add initializers.
10810 <obstack>: New member.
10811 (read_member_functions, read_struct_fields, read_baseclasses):
10812 Allocate on obstack. Don't use cleanups.
10813 (read_one_struct_field, read_member_functions, read_struct_fields)
10814 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10815 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10816 (read_struct_type): Update.
10817
6cceac94
TT
108182019-03-06 Tom Tromey <tom@tromey.com>
10819
10820 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10821 * common/filestuff.h (make_cleanup_close): Don't declare.
10822 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10823 Remove.
10824
72412762
TT
108252019-03-06 Tom Tromey <tom@tromey.com>
10826
10827 * solib-aix.c: Use make_scope_exit.
10828
2b6ff1c0
TT
108292019-03-06 Tom Tromey <tom@tromey.com>
10830
10831 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10832 Use make_scope_exit.
10833
d01c5877
TT
108342019-03-06 Tom Tromey <tom@tromey.com>
10835
10836 * solib-svr4.c (disable_probes_interface): Remove parameter.
10837 (svr4_handle_solib_event): Use make_scope_exit.
10838
32603266
TT
108392019-03-06 Tom Tromey <tom@tromey.com>
10840
10841 * remote.c (struct stop_reply_deleter): Remove.
10842 (stop_reply_up): Update.
10843 (struct stop_reply): Derive from notif_event. Don't typedef.
10844 <regcache>: Now a std::vector.
10845 (stop_reply_xfree): Remove.
10846 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10847 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
10848 (remote_target::discard_pending_stop_replies): Use delete.
10849 (remote_target::remote_parse_stop_reply): Update.
10850 (remote_target::process_stop_reply): Update.
10851 * remote-notif.h (struct notif_event): Add virtual destructor.
10852 Remove "dtr" member.
10853 (struct notif_client) <alloc_event>: Return a unique_ptr.
10854 (notif_event_xfree): Don't declare.
10855 (notif_event_up): New typedef.
10856 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10857 (notif_event_xfree, do_notif_event_xfree): Remove.
10858 (remote_notif_state_xfree): Update.
10859
9799571e
TT
108602019-03-06 Tom Tromey <tom@tromey.com>
10861
10862 * infrun.c (displaced_step_clear_cleanup): Now a
10863 forward_scope_exit type.
10864 (displaced_step_prepare_throw): Update.
10865 (displaced_step_fixup): Update.
10866
09e3c4ca
TT
108672019-03-06 Tom Tromey <tom@tromey.com>
10868
10869 * inferior.h (class inferior): Update comment.
10870 * gdbthread.h (class thread_info): Update comment.
10871
e2a03548
TT
108722019-03-06 Joel Brobecker <brobecker@adacore.com>
10873 Tom Tromey <tom@tromey.com>
10874
10875 * stabsread.h (struct stab_section_list): Remove.
10876 (coffstab_build_psymtabs): Update.
10877 * dbxread.c (symbuf_sections): Now a std::vector.
10878 (sect_idx): New global.
10879 (fill_symbuf): Update.
10880 (coffstab_build_psymtabs): Change type of stabsects parameter.
10881 Update.
10882 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10883 std::vector.
10884 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10885 (coff_locate_sections): Update.
10886 (coff_symfile_read): Remove cleanups. Update.
10887 (init_stringtab): Add storage parameter.
10888 (free_stringtab, free_stringtab_cleanup): Remove.
10889 (init_lineno): Add storage parameter.
10890 (free_linetab, free_linetab_cleanup): Remove.
10891
b7e60d85
PA
108922019-03-06 Pedro Alves <palves@redhat.com>
10893
10894 * linux-fork.c (fork_info::clobber_regs): Delete.
10895 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10896 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
10897 comment. Adjust.
10898 (scoped_switch_fork_info::scoped_switch_fork_info)
10899 (checkpoint_command, linux_fork_context): Adjust
10900 fork_save_infrun_state calls.
10901
e52c971f
PA
109022019-03-06 Pedro Alves <palves@redhat.com>
10903
10904 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10905 (inf_has_multiple_threads): Return 'bool' and rewrite using
10906 inferior_info::threads().
10907
06974e6c
PA
109082019-03-06 Pedro Alves <palves@redhat.com>
10909
10910 * linux-fork.c: Include <list>.
10911 (fork_list): Now a std::list instance.
10912 (fork_info): Add ctor, dtor, and in-class initialize all fields.
10913 (forks_exist_p, find_last_fork): Adjust.
10914 (new_fork): Delete.
10915 (one_fork_p): New.
10916 (add_fork): Adjust.
10917 (free_fork): Delete, folded into fork_info::~fork_info().
10918 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10919 Adjust.
10920 (init_fork_list): Delete.
10921 (linux_fork_killall, linux_fork_mourn_inferior)
10922 (linux_fork_detach, info_checkpoints_command): Adjust.
10923 (_initialize_linux_fork): No longer call init_fork_list.
10924
72f31aea
PA
109252019-03-06 Pedro Alves <palves@redhat.com>
10926
10927 * linux-fork.c (new_fork): New, split out of ...
10928 (add_fork): ... this. Return void. Move "first fork" special
10929 case from here, to ...
10930 (checkpoint_command): ... here.
10931 * linux-linux.h (add_fork): Return void.
10932
efbecbc1
AB
109332019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10934
10935 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10936
0841c79a
AB
109372019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10938 Chris January <chris.january@arm.com>
10939 David Lecomber <david.lecomber@arm.com>
10940
10941 * f-exp.y: New token, UNOP_INTRINSIC.
10942 (exp): New pattern using UNOP_INTRINSIC token.
10943 (f77_keywords): Add 'abs' keyword.
10944 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10945 (value_from_host_double): New function.
10946 (evaluate_subexp_f): Support UNOP_ABS.
10947
4a270568
AB
109482019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10949
10950 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10951 types.
10952
067630bd
AB
109532019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10954
10955 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10956 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10957 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10958
3be47f7a
AB
109592019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10960
10961 * f-exp.y (convert_to_kind_type): Handle more type kinds.
10962
4d00f5d8
AB
109632019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10964 Chris January <chris.january@arm.com>
10965
10966 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10967 * f-exp.y: Define 'KIND' token.
10968 (exp): New pattern for KIND expressions.
10969 (ptype): Handle types with a kind extension.
10970 (direct_abs_decl): Extend to spot kind extensions.
10971 (f77_keywords): Add 'kind' to the list.
10972 (push_kind_type): New function.
10973 (convert_to_kind_type): New function.
10974 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10975 * parse.c (operator_length_standard): Likewise.
10976 * parser-defs.h (enum type_pieces): Add tp_kind.
10977 * std-operator.def: Add UNOP_KIND.
10978
e454224f
AB
109792019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10980
10981 * f-exp.y (f_parse): Set yydebug.
10982
9dad4a58
AB
109832019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10984
10985 * f-lang.c (evaluate_subexp_f): New function.
10986 (exp_descriptor_f): New global.
10987 (f_language_defn): Use exp_descriptor_f instead of
10988 exp_descriptor_standard.
10989
c8f91604
AB
109902019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10991
10992 * f-exp.y (struct token): Add comments.
10993 (dot_ops): Remove uppercase versions and the end marker.
10994 (f77_keywords): Likewise.
10995 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10996 entries in the dot_ops array are case insensitive, and use
10997 strncasecmp to compare strings. Also some whitespace cleanup in
10998 this area. Similar for the f77_keywords array, except entries in
10999 this list might be case sensitive.
11000
dd9f2c76
AB
110012019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
11002
11003 * f-exp.y (struct f77_boolean_val): Add comments.
11004 (boolean_values): Remove uppercase versions, and end marker.
11005 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11006 and use strncasecmp to achieve case insensitivity. Additionally,
11007 perform whitespace cleanup around this code.
11008
67a3048c
TT
110092019-03-06 Tom Tromey <tromey@adacore.com>
11010
11011 * remote-sim.c (gdbsim_target_open): Use result of
11012 gdb_argv::release.
11013
aa3cfbda
RB
110142019-03-06 Richard Bunt <richard.bunt@arm.com>
11015 Dirk Schubert <dirk.schubert@arm.com>
11016 Chris January <chris.january@arm.com>
11017
11018 * eval.c (evaluate_subexp_standard): Call Fortran argument
11019 wrapping logic.
11020 * f-lang.c (struct value): A value which can be passed into a
11021 Fortran function call.
11022 (fortran_argument_convert): Wrap Fortran arguments in a pointer
11023 where appropriate.
11024 (struct type): Value ready for a Fortran function call.
11025 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11026 is needed.
11027 * f-lang.h (fortran_argument_convert): Declaration.
11028 (fortran_preserve_arg_pointer): Declaration.
11029 * infcall.c (value_arg_coerce): Call Fortran argument logic.
11030
ea38e5df
TT
110312019-03-05 Tom Tromey <tromey@adacore.com>
11032
11033 * python/py-prettyprint.c (print_string_repr): Remove #if.
11034 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11035
06b5b831
TT
110362019-03-05 Tom Tromey <tromey@adacore.com>
11037
11038 * target.c (the_dummy_target): Move later. Change type to
11039 "dummy_target".
11040 (initialize_targets): Don't initialize the_dummy_target.
11041
edbd9e45
TT
110422019-03-05 Tom Tromey <tromey@adacore.com>
11043
11044 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11045 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11046
c119e040
TT
110472019-03-05 Tom Tromey <tromey@adacore.com>
11048
11049 * windows-nat.c (windows_nat_target::attach)
11050 (windows_nat_target::detach): Don't call gdb_flush.
11051 * valprint.c (generic_val_print, val_print, val_print_string):
11052 Don't call gdb_flush.
11053 * utils.c (defaulted_query): Don't call gdb_flush.
11054 * typeprint.c (print_type_scalar): Don't call gdb_flush.
11055 * target.c (target_announce_detach): Don't call gdb_flush.
11056 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11057 * remote.c (extended_remote_target::attach): Don't call
11058 gdb_flush.
11059 * procfs.c (procfs_target::detach): Don't call gdb_flush.
11060 * printcmd.c (do_examine): Don't call gdb_flush.
11061 (info_display_command): Don't call gdb_flush.
11062 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11063 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11064 * memattr.c (info_mem_command): Don't call gdb_flush.
11065 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11066 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11067 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11068 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11069 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11070 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11071 (gnu_nat_target::detach): Don't call gdb_flush.
11072 * f-valprint.c (f_val_print): Don't call gdb_flush.
11073 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11074 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11075 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11076 gdb_flush.
11077 * c-valprint.c (c_val_print): Don't call gdb_flush.
11078 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11079
895dafa6
TT
110802019-03-05 Tom Tromey <tromey@adacore.com>
11081
11082 * varobj.c (update_dynamic_varobj_children): Update.
11083 (install_default_visualizer): Use reset, not release.
11084 * value.c (set_internalvar): Update.
11085 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11086 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11087 ATTRIBUTE_UNUSED_RESULT.
11088
88a774b9
TT
110892019-03-05 Tom Tromey <tromey@adacore.com>
11090
11091 * remote.c (class scoped_remote_fd) <release>: Add
11092 ATTRIBUTE_UNUSED_RESULT.
11093
4e4a8b93
TT
110942019-03-05 Tom Tromey <tromey@adacore.com>
11095
11096 * macroexp.c (struct macro_buffer) <release>: Add
11097 ATTRIBUTE_UNUSED_RESULT.
11098
083eef1f
TT
110992019-03-05 Tom Tromey <tromey@adacore.com>
11100
11101 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11102 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11103 ATTRIBUTE_UNUSED_RESULT.
11104
3cabd438
TT
111052019-03-05 Tom Tromey <tromey@adacore.com>
11106
11107 * common/scoped_fd.h (class scoped_fd) <release>: Add
11108 ATTRIBUTE_UNUSED_RESULT.
11109
41e3300a
TT
111102019-03-05 Tom Tromey <tromey@adacore.com>
11111
11112 * parser-defs.h (struct parser_state) <release>: Add
11113 ATTRIBUTE_UNUSED_RESULT.
11114
18cb7c9f
TT
111152019-03-05 Tom Tromey <tromey@adacore.com>
11116
11117 * utils.h (class gdb_argv) <release>: Add
11118 ATTRIBUTE_UNUSED_RESULT.
11119 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11120
41fa577f
EZ
111212019-03-02 Eli Zaretskii <eliz@gnu.org>
11122
a6a4b2c6
EZ
11123 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11124 for-loop range, to avoid compiler warnings.
11125
11126 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11127 avoid compiler warnings about unused variables.
11128
742a7df5
EZ
11129 * NEWS: Mention end of support for native debugging on MS-Windows
11130 before XP.
11131
41fa577f
EZ
11132 PR gdb/24292
11133 * common/netstuff.c:
11134 * gdbserver/gdbreplay.c
11135 * gdbserver/remote-utils.c:
11136 * ser-tcp.c:
11137 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11138 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
11139 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11140 'getaddrinfo' and 'freeaddrinfo' were not available before
11141 Windows XP, and mingw.org's MinGW headers by default define
11142 _WIN32_WINNT to 0x500.
11143
827f438f
GB
111442019-03-01 Gary Benson <gbenson@redhat.com>
11145
11146 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11147
92137da0
RO
111482019-02-28 Brian Vandenberg <phantall@gmail.com>
11149 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
11150
11151 PR gdb/8527
11152 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11153 set_sigint_trap, clear_sigint_trap.
11154
799efbe8
PW
111552019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11156
11157 * target.c (target_detach): Clear the regcache and the
11158 frame cache.
11159
8ed25214
PA
111602019-02-27 Pedro Alves <palves@redhat.com>
11161
11162 * utils.c (set_screen_size): When we cap the height/width sizes,
11163 tweak the corresponding command variable to show "unlimited":
11164
23031e31
SJ
111652019-02-27 Saagar Jha <saagar@saagarjha.com>
11166 Pedro Alves <palves@redhat.com>
11167
11168 * utils.c (set_screen_size): Reduce "infinite" rows and columns
11169 before calling rl_set_screen_size.
11170
6c28e44a
TT
111712019-02-27 Tom Tromey <tromey@adacore.com>
11172
11173 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11174 define.
11175 * python/py-value.c: Remove Python 2.4 workaround.
11176 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11177 workaround.
11178 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11179 Python 2.4 workaround.
11180 * python/python-internal.h: Remove Python 2.4 comment.
11181 (Py_ssize_t): Don't define.
11182 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11183 (gdb_Py_DECREF): Remove Python 2.4 workaround.
11184 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11185 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11186 * python/python.c (do_start_initialization): Remove Python 2.4
11187 workaround.
11188 * python/py-prettyprint.c (class dummy_python_frame): Remove.
11189 (print_children): Remove Python 2.4 workaround.
11190 * python/py-inferior.c (buffer_procs): Remove Python 2.4
11191 workaround.
11192 (CHARBUFFERPROC_NAME): Remove.
11193 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11194 Python 2.4 workaround.
11195
2c3fc25d 111962019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 11197
2c3fc25d
KB
11198 * NEWS: Note minimum Python version.
11199
6ca62222
KB
112002019-02-27 Kevin Buettner <kevinb@redhat.com>
11201
11202 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11203 code from these functions. Remove corresponding ifdefs. Use
11204 Py_buffer_up instead of explicit calls to PyBuffer_Release.
11205 Remove gotos and target of gotos.
11206 (infpy_search_memory): Likewise.
11207
f4bc7d2c
AB
112082019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11209
11210 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11211 (hppa_gdbarch_init): Don't register deleted functions with
11212 gdbarch.
11213
9734a586
AB
112142019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11215
11216 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11217 (h8300_unwind_sp): Delete.
11218 (h8300_dummy_id): Delete.
11219 (h8300_gdbarch_init): Don't register deleted functions with
11220 gdbarch.
11221
68b867f3
AB
112222019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11223
11224 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11225 (ft32_unwind_pc): Delete.
11226 (ft32_unwind_sp): Delete.
11227 (ft32_gdbarch_init): Don't register deleted functions with
11228 gdbarch.
11229
2fbe7ad0
AB
112302019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11231
11232 * gdb/frv-tdep.c (frv_dummy_id): Delete.
11233 (frv_unwind_pc): Delete.
11234 (frv_unwind_sp): Delete.
11235 (frv_gdbarch_init): Don't register deleted functions with
11236 gdbarch.
11237
76055cbe
AB
112382019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11239
11240 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11241 (riscv_unwind_pc): Delete.
11242 (riscv_unwind_sp): Delete.
11243 (riscv_gdbarch_init): Don't register deleted functions with
11244 gdbarch.
11245
4133e5a1
AB
112462019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11247
11248 * gdb/csky-tdep.c (csky_dummy_id): Delete.
11249 (csky_unwind_pc): Delete.
11250 (csky_unwind_sp): Delete.
11251 (csky_gdbarch_init): Don't register deleted functions with
11252 gdbarch.
11253
8010f576
AB
112542019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11255
11256 * gdb/cris-tdep.c (cris_dummy_id): Delete.
11257 (cris_unwind_pc): Delete.
11258 (cris_unwind_sp): Delete.
11259 (cris_gdbarch_init): Don't register deleted functions with
11260 gdbarch.
11261
b56bf084
AB
112622019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11263
11264 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11265 (bfin_unwind_pc): Delete.
11266 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11267
a19a650f
AB
112682019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11269
11270 * gdb/arm-tdep.c (arm_dummy_id): Delete.
11271 (arm_unwind_pc): Delete.
11272 (arm_unwind_sp): Delete.
11273 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11274
f8278c3c
AB
112752019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11276
11277 * gdb/arc-tdep.c (arc_dummy_id): Delete.
11278 (arc_unwind_pc): Delete.
11279 (arc_unwind_sp): Delete.
11280 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11281
480e46cf
AB
112822019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11283
11284 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11285 (alpha_unwind_pc): Delete.
11286 (alpha_gdbarch_init): Don't register deleted functions with
11287 gdbarch.
11288
7a995095
AB
112892019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11290
11291 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11292 (aarch64_unwind_pc): Delete.
11293 (aarch64_unwind_sp): Delete.
11294 (aarch64_gdbarch_init): Don't register deleted functions with
11295 gdbarch.
11296
bf9a735e
AB
112972019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11298
11299 * gdbtypes.c (type_align): Don't consider static members when
11300 computing structure alignment.
11301
5561fc30
AB
113022019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
11303
11304 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11305 return 0 for other types.
11306 * arch-utils.c (default_type_align): Always return 0.
11307 * gdbarch.h: Regenerate.
11308 * gdbarch.sh (type_align): Extend comment.
11309 * gdbtypes.c (type_align): Add additional comments, always call
11310 gdbarch_type_align before applying the default rules.
11311 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11312 generic code will then apply a suitable default.
11313 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11314 types, return 0 for other types.
11315
9335e75a
JB
113162019-02-27 Joel Brobecker <brobecker@adacore.com>
11317
11318 * NEWS: Create a new section for the next release branch.
11319 Rename the section of the current branch, now that it has
11320 been cut.
11321
3d34d8de
JB
113222019-02-27 Joel Brobecker <brobecker@adacore.com>
11323
11324 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11325 * version.in: Bump version to 8.3.50.DATE-git.
11326
143420fb
SM
113272019-02-26 Simon Marchi <simon.marchi@efficios.com>
11328
11329 * aix-thread.c (ptid_cmp): Remove unused variable.
11330 (get_signaled_thread): Likewise.
11331 (store_regs_user_thread): Likewise.
11332 (store_regs_kernel_thread): Likewise.
11333 (fetch_regs_kernel_thread): Remove shadowed variable.
11334
172fb711
AB
113352019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
11336
11337 * features/riscv/32bit-cpu.xml: Add register numbers.
11338 * features/riscv/32bit-fpu.c: Regenerate.
11339 * features/riscv/32bit-fpu.xml: Add register numbers.
11340 * features/riscv/64bit-cpu.xml: Add register numbers.
11341 * features/riscv/64bit-fpu.c: Regenerate.
11342 * features/riscv/64bit-fpu.xml: Add register numbers.
11343
26c89782
KB
113442019-02-26 Kevin Buettner <kevinb@redhat.com>
11345
af54ade9 11346 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
11347 * python/py-value.c (convert_buffer_and_type_to_value): New
11348 function.
11349 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11350 Add support for handling an optional second argument. Call
11351 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
11352 * python/python-internal.h (Py_buffer_deleter): New struct.
11353 (Py_buffer_up): New typedef.
11354
0f58c9e8
JB
113552019-02-25 John Baldwin <jhb@FreeBSD.org>
11356
11357 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11358 instead of releasing ownership.
11359
0a0f4c01
JR
113602019-02-25 Jordan Rupprecht <rupprecht@google.com>
11361
11362 * dwarf2read.c (open_and_init_dwp_file): Call
11363 elf_numsections instead of bfd_count_sections to initialize
11364 dwp_file->num_sections.
11365
cd5a152c
TT
113662019-02-25 Tom Tromey <tromey@adacore.com>
11367
11368 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11369
8a6a8513
SDJ
113702019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
11371
11372 * gcore.in: Add '--readnever' option when invoking GDB.
11373
04dcda9c
SM
113742019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11375
11376 * MAINTAINERS: Update my email address.
11377
07bc701d
SM
113782019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
11379
11380 * build-id.c (build_id_to_debug_bfd_1): New function.
11381 (build_id_to_debug_bfd): Look for separate debug file in
11382 sysroot.
11383
c6f4a5d0
AB
113842019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
11385
11386 * gdbarch.sh: Update the copyright year range that is placed into
11387 generated files.
11388
9600246d
KS
113892019-02-22 Keith Seitz <keiths@redhat.com>
11390
11391 PR symtab/23853
11392 * linespec.c (create_sals_line_offset): Search for the default
11393 symtab's filename instead of its fullname.
11394
7557a514
AH
113952019-02-21 Alan Hayward <alan.hayward@arm.com>
11396
11397 * NEWS: Update style defaults.
11398
ee2bcb0c
AH
113992019-02-21 Alan Hayward <alan.hayward@arm.com>
11400
11401 * main.c (captured_main_1): Disable styling in batch mode.
11402
0c95f9ed
TT
114032019-02-20 Tom Tromey <tom@tromey.com>
11404
11405 * symtab.c (symtab_symbol_info): Fix typos.
11406
c763b894
TT
114072019-02-20 Tom Tromey <tromey@adacore.com>
11408
11409 * findcmd.c (_initialize_mem_search): Use upper case for
11410 metasyntactic variables.
11411
0ef8a082
AH
114122019-02-20 Alan Hayward <alan.hayward@arm.com>
11413
11414 * aarch64-tdep.c (aarch64_add_reggroups): New function.
11415 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11416
6caa91b6
SM
114172019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
11418
11419 * top.h (source_file_name): Change to std::string.
11420 * top.c (source_file_name): Likewise.
11421 (command_line_input): Adjust.
11422 * cli/cli-script.c (script_from_file): Adjust.
11423
98814c6c
TT
114242019-02-19 Tom Tromey <tromey@adacore.com>
11425
11426 * ravenscar-thread.c
11427 (ravenscar_thread_target::update_thread_list): Don't call
11428 ada_build_task_list.
11429 * ada-lang.h (ada_build_task_list): Don't declare.
11430 * ada-tasks.c (struct ada_tasks_inferior_data)
11431 <task_list_valid_p>: Now bool.
11432 (read_known_tasks, ada_task_list_changed)
11433 (ada_tasks_invalidate_inferior_data): Update.
11434 (read_known_tasks_array): Return bool.
11435 (read_known_tasks_list): Likewise.
11436 (read_known_tasks): Return void.
11437 (ada_build_task_list): Now static.
11438
70cd633e
AB
114392019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
11440
11441 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11442 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11443
040b3e95
PW
114442019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11445
11446 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11447 variant for ada_tasks_pspace_data_handle and
11448 ada_tasks_inferior_data_handle.
11449 (ada_tasks_pspace_data_cleanup): New function.
11450 (ada_tasks_inferior_data_cleanup): New function.
11451
9409233b
TT
114522019-02-17 Tom Tromey <tom@tromey.com>
11453
11454 * macrotab.h (macro_source_fullname): Return a std::string.
11455 * macrotab.c (macro_include, check_for_redefinition)
11456 (macro_undef, macro_lookup_definition, foreach_macro)
11457 (foreach_macro_in_scope): Update.
11458 (macro_source_fullname): Return a std::string.
11459 * macrocmd.c (show_pp_source_pos): Update.
11460
6506371f
TT
114612019-02-17 Tom Tromey <tom@tromey.com>
11462
11463 * macrocmd.c (show_pp_source_pos): Style the file names.
11464
0c820d67
TT
114652019-02-17 Tom Tromey <tom@tromey.com>
11466
11467 PR tui/24197:
11468 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11469
a0087920
TT
114702019-02-17 Tom Tromey <tom@tromey.com>
11471
11472 * ada-lang.c (user_select_syms): Use filtered printing.
11473 * utils.c (wrap_style): New global.
11474 (desired_style): Remove.
11475 (emit_style_escape): Add stream parameter.
11476 (set_output_style, reset_terminal_style, prompt_for_continue):
11477 Update.
11478 (flush_wrap_buffer): Only flush gdb_stdout.
11479 (wrap_here): Set wrap_style.
11480 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
11481 treat escape sequences as a character. Change when wrap buffer is
11482 flushed.
11483 (fputs_styled): Do not set the output style when the default is
11484 requested.
11485 * ui-style.h (struct ui_file_style) <is_default>: New method.
11486 * source.c (print_source_lines_base): Emit escape sequences in one
11487 piece.
11488
75ba10dc
JB
114892019-02-17 Joel Brobecker <brobecker@adacore.com>
11490
11491 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11492 integers and enumeration types.
11493
a2cd4f14
JB
114942019-02-17 Joel Brobecker <brobecker@adacore.com>
11495
11496 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11497 instead of lookup_symbol_in_language
11498 (do_exact_match): New function.
11499 (ada_get_symbol_name_matcher): Return do_exact_match when
11500 doing a verbatim match.
11501
485b851b
TT
115022019-02-15 Tom Tromey <tromey@adacore.com>
11503
11504 * ravenscar-thread.c (ravenscar_thread_target::resume)
11505 (ravenscar_thread_target::wait): Special case wildcard requests.
11506
0b790b1e
TT
115072019-02-15 Tom Tromey <tromey@adacore.com>
11508
11509 * ravenscar-thread.c (base_ptid): Remove.
11510 (struct ravenscar_thread_target) <close>: New method.
11511 <m_base_ptid>: New member.
11512 <update_inferior_ptid, active_task, task_is_currently_active,
11513 runtime_initialized>: Declare methods.
11514 <ravenscar_thread_target>: Add constructor.
11515 (ravenscar_thread_target::task_is_currently_active)
11516 (ravenscar_thread_target::update_inferior_ptid)
11517 (ravenscar_runtime_initialized): Rename. Now methods.
11518 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11519 (ravenscar_thread_target::update_thread_list): Update.
11520 (ravenscar_thread_target::active_task): Now method.
11521 (ravenscar_thread_target::store_registers)
11522 (ravenscar_thread_target::prepare_to_store)
11523 (ravenscar_thread_target::prepare_to_store)
11524 (ravenscar_thread_target::mourn_inferior): Update.
11525 (ravenscar_inferior_created): Use "new" to create target.
11526 (ravenscar_thread_target::get_ada_task_ptid): Update.
11527 (_initialize_ravenscar): Don't initialize base_ptid.
11528 (ravenscar_ops): Remove global.
11529
dea57a62
TT
115302019-02-15 Tom Tromey <tromey@adacore.com>
11531
11532 * target.h (push_target): Declare new overload.
11533 * target.c (push_target): New overload, taking an rvalue reference.
11534 * remote.c (remote_target::open_1): Use push_target overload.
11535 * corelow.c (core_target_open): Use push_target overload.
11536
989f3c58
TT
115372019-02-15 Tom Tromey <tromey@adacore.com>
11538
11539 * ravenscar-thread.c (is_ravenscar_task)
11540 (ravenscar_task_is_currently_active): Return bool.
11541 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11542 (_initialize_ravenscar): Remove "(void)".
11543 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11544 Return bool.
11545
6cbcc006
TT
115462019-02-15 Tom Tromey <tromey@adacore.com>
11547
11548 * ravenscar-thread.c (ravenscar_runtime_initializer)
11549 (has_ravenscar_runtime, get_running_thread_id)
11550 (ravenscar_thread_target::resume): Fix indentation.
11551
7657f14d
TT
115522019-02-15 Tom Tromey <tromey@adacore.com>
11553
11554 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11555 from ravenscar_arch_ops.
11556 (sparc_ravenscar_ops::fetch_registers)
11557 (sparc_ravenscar_ops::store_registers): Now methods.
11558 (sparc_ravenscar_prepare_to_store): Remove.
11559 (sparc_ravenscar_ops): Redefine.
11560 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11561 methods and destructor. Remove members.
11562 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11563 (ravenscar_thread_target::store_registers)
11564 (ravenscar_thread_target::prepare_to_store): Update.
11565 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11566 Remove.
11567 (struct ppc_ravenscar_powerpc_ops): Derive from
11568 ravenscar_arch_ops.
11569 (ppc_ravenscar_powerpc_ops::fetch_registers)
11570 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11571 (ppc_ravenscar_powerpc_ops): Redefine.
11572 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11573 (ppc_ravenscar_e500_ops::fetch_registers)
11574 (ppc_ravenscar_e500_ops::store_registers): Now methods.
11575 (ppc_ravenscar_e500_ops): Redefine.
11576 * aarch64-ravenscar-thread.c
11577 (aarch64_ravenscar_generic_prepare_to_store): Remove.
11578 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11579 (aarch64_ravenscar_fetch_registers)
11580 (aarch64_ravenscar_store_registers): Now methods.
11581 (aarch64_ravenscar_ops): Redefine.
11582
5b6ea500
TT
115832019-02-15 Tom Tromey <tromey@adacore.com>
11584
11585 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11586 (ravenscar_thread_target::stopped_by_hw_breakpoint)
11587 (ravenscar_thread_target::stopped_by_watchpoint)
11588 (ravenscar_thread_target::stopped_data_address)
11589 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11590
e397fd39
TT
115912019-02-15 Tom Tromey <tromey@adacore.com>
11592
11593 * ravenscar-thread.c: Fix some typos.
11594
cc12f4a8
TT
115952019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11596 Tom Tromey <tromey@adacore.com>
11597
11598 * ada-lang.c (ada_exception_sal): Change addr_string to a
11599 std::string.
11600 (create_ada_exception_catchpoint): Update.
11601
5f486660
TT
116022019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11603 Tom Tromey <tromey@adacore.com>
11604
11605 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11606 (bp_location_ops): Remove.
11607 (base_breakpoint_allocate_location): Update.
11608 (free_bp_location): Update.
11609 * ada-lang.c (class ada_catchpoint_location)
11610 <ada_catchpoint_location>: Remove ops parameter.
11611 (ada_catchpoint_location_dtor): Remove.
11612 (ada_catchpoint_location_ops): Remove.
11613 (allocate_location_exception): Update.
11614 * breakpoint.h (struct bp_location_ops): Remove.
11615 (class bp_location) <bp_location>: Remove bp_location_ops
11616 parameter.
11617 <~bp_location>: Add destructor.
11618 <ops>: Remove.
11619
b671c7fb
TS
116202019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11621 Pedro Alves <palves@redhat.com>
11622
11623 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11624 'PATH_MAX'.
11625
8071c5ce
DM
116262019-02-14 David Michael <fedora.dm0@gmail.com>
11627 Samuel Thibault <samuel.thibault@gnu.org>
11628 Thomas Schwinge <thomas@codesourcery.com>
11629
11630 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11631 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11632
b1041ae0
TS
116332019-02-14 Thomas Schwinge <thomas@codesourcery.com>
11634
924514e1
TS
11635 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11636 (check_empty): Use "const char *".
11637
c29ee8d4
TS
11638 * gnu-nat.c (gnu_nat_target::detach): Instead of
11639 'detach_inferior (pid)' call
11640 'detach_inferior (find_inferior_pid (pid))'.
11641
6c6ef69f
TS
11642 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11643 'nat/fork-inferior.o'.
11644 * gnu-nat.c: #include "nat/fork-inferior.h".
11645
2d0a338c
TS
11646 * gnu-nat.c (gnu_nat_target::detach): Instead of
11647 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11648 * gnu-nat.h: #include "inf-child.h".
11649 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11650 'i386_gnu_nat_target::fetch_registers'.
11651 (gnu_store_registers): Rename/move to
11652 'i386_gnu_nat_target::store_registers'.
11653
cabb5f06
TS
11654 * config/i386/nm-i386gnu.h: Don't "#include" any files.
11655 * gnu-nat.h (mach_thread_info): New function.
11656 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11657
b1041ae0
TS
11658 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11659
2988d01e
KF
116602019-02-14 Frederic Konrad <konrad@adacore.com>
11661
11662 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11663
c559d709
JB
116642019-02-14 Joel Brobecker <brobecker@adacore.com>
11665
11666 * windows-nat.c (windows_add_thread): Add new parameter
11667 "main_thread_p" with default value set to false. Update
11668 function documentation as well as all callers.
11669 (windows_delete_thread): Likewise.
11670 (fake_create_process): Update call to windows_add_thread.
11671 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11672 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11673 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11674 call to windows_delete_thread.
11675
007024cc
SM
116762019-02-13 Simon Marchi <simon.marchi@ericsson.com>
11677
11678 * MAINTAINERS: Add Andrew Burgess as global maintainer.
11679
f62318e9
JB
116802019-02-12 John Baldwin <jhb@FreeBSD.org>
11681
11682 * symfile.c (find_separate_debug_file): Use canonical path of
11683 sysroot with child_path instead of gdb_sysroot if it is valid.
11684
cd4b7848
JB
116852019-02-12 John Baldwin <jhb@FreeBSD.org>
11686
11687 * symfile.c (find_separate_debug_file): Use child_path to
11688 determine if an object file is under a sysroot.
11689
efac4bfe
JB
116902019-02-12 John Baldwin <jhb@FreeBSD.org>
11691
11692 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11693 unittests/child-path-selftests.c.
11694 * common/pathstuff.c (child_path): New function.
11695 * common/pathstuff.h (child_path): New prototype.
11696 * unittests/child-path-selftests.c: New file.
11697
402d2bfe
JB
116982019-02-12 John Baldwin <jhb@FreeBSD.org>
11699
11700 * symfile.c (find_separate_debug_file): Look for separate debug
11701 files in debug directories under the sysroot.
11702
1ed9f74e
PW
117032019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11704
11705 * symtab.h (struct minimal_symbol data_p): New const method.
11706 (struct minimal_symbol text_p): Likewise.
11707 * symtab.c (output_source_filename): Use file name style
11708 to print file name.
11709 (print_symbol_info): Likewise.
11710 (print_msymbol_info): Use address style to print addresses.
11711 Use function name style to print executable text symbols.
11712 (expand_symtab_containing_pc): Use data_p.
11713 (find_pc_sect_compunit_symtab): Likewise.
11714
2636d81d
PW
117152019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11716
11717 * breakpoint.c (describe_other_breakpoints): Use address style
11718 to print addresses.
11719 (say_where): Likewise.
11720
ac8c53cc
PW
117212019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11722
11723 * ada-typeprint.c (print_func_type): Print function name
11724 style to print function name.
11725 * c-typeprint.c (c_print_type_1): Likewise.
11726
ea638c43
AH
117272019-02-11 Alan Hayward <alan.hayward@arm.com>
11728
11729 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11730 for execve.
11731
ab759ca8
PW
117322019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11733
11734 * c-exp.y (direct_abs_decl): Use emplace_back to record the
11735 type_stack.
11736
aff29d1c
JB
117372019-02-10 Joel Brobecker <brobecker@adacore.com>
11738
11739 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11740 TYPE_CODE_REF types.
11741
617126bc
JW
117422019-02-08 Jim Wilson <jimw@sifive.com>
11743
11744 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11745 (riscv_linux_fregset): New.
11746 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11747
46e3ed7f
TT
117482019-02-07 Tom Tromey <tom@tromey.com>
11749
11750 * thread.c (thread_cancel_execution_command): Update.
11751 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11752 methods.
11753 (struct thread_fsm_ops): Remove.
11754 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11755 (thread_fsm_should_stop, thread_fsm_return_value)
11756 (thread_fsm_set_finished, thread_fsm_finished_p)
11757 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11758 Don't declare.
11759 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11760 * infrun.c (clear_proceed_status_thread)
11761 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11762 (print_stop_event): Update.
11763 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11764 Add constructor.
11765 (step_command_fsm_ops): Remove.
11766 (new_step_command_fsm): Remove.
11767 (step_1): Update.
11768 (step_command_fsm::should_stop): Rename from
11769 step_command_fsm_should_stop.
11770 (step_command_fsm::clean_up): Rename from
11771 step_command_fsm_clean_up.
11772 (step_command_fsm::do_async_reply_reason): Rename from
11773 step_command_fsm_async_reply_reason.
11774 (struct until_next_fsm): Inherit from thread_fsm. Add
11775 constructor.
11776 (until_next_fsm_ops): Remove.
11777 (new_until_next_fsm): Remove.
11778 (until_next_fsm::should_stop): Rename from
11779 until_next_fsm_should_stop.
11780 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11781 (until_next_fsm::do_async_reply_reason): Rename from
11782 until_next_fsm_async_reply_reason.
11783 (struct finish_command_fsm): Inherit from thread_fsm. Add
11784 constructor. Change type of breakpoint.
11785 (finish_command_fsm_ops): Remove.
11786 (new_finish_command_fsm): Remove.
11787 (finish_command_fsm::should_stop): Rename from
11788 finish_command_fsm_should_stop.
11789 (finish_command_fsm::clean_up): Rename from
11790 finish_command_fsm_clean_up.
11791 (finish_command_fsm::return_value): Rename from
11792 finish_command_fsm_return_value.
11793 (finish_command_fsm::do_async_reply_reason): Rename from
11794 finish_command_fsm_async_reply_reason.
11795 (finish_command): Update.
11796 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11797 Add constructor.
11798 (call_thread_fsm_ops): Remove.
11799 (call_thread_fsm::call_thread_fsm): Rename from
11800 new_call_thread_fsm.
11801 (call_thread_fsm::should_stop): Rename from
11802 call_thread_fsm_should_stop.
11803 (call_thread_fsm::should_notify_stop): Rename from
11804 call_thread_fsm_should_notify_stop.
11805 (run_inferior_call, call_function_by_hand_dummy): Update.
11806 * cli/cli-interp.c (should_print_stop_to_console): Update.
11807 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11808 Add constructor. Change type of location_breakpoint,
11809 caller_breakpoint.
11810 (until_break_fsm_ops): Remove.
11811 (new_until_break_fsm): Remove.
11812 (until_break_fsm::should_stop): Rename from
11813 until_break_fsm_should_stop.
11814 (until_break_fsm::clean_up): Rename from
11815 until_break_fsm_clean_up.
11816 (until_break_fsm::do_async_reply_reason): Rename from
11817 until_break_fsm_async_reply_reason.
11818 (until_break_command): Update.
11819 * thread-fsm.c: Remove.
11820 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11821
1a5c2598
TT
118222019-02-07 Tom Tromey <tom@tromey.com>
11823
11824 * yy-remap.h: Add include guard.
11825 * xtensa-tdep.h: Add include guard.
11826 * xcoffread.h: Rename include guard.
11827 * varobj-iter.h: Add include guard.
11828 * tui/tui.h: Rename include guard.
11829 * tui/tui-winsource.h: Rename include guard.
11830 * tui/tui-wingeneral.h: Rename include guard.
11831 * tui/tui-windata.h: Rename include guard.
11832 * tui/tui-win.h: Rename include guard.
11833 * tui/tui-stack.h: Rename include guard.
11834 * tui/tui-source.h: Rename include guard.
11835 * tui/tui-regs.h: Rename include guard.
11836 * tui/tui-out.h: Rename include guard.
11837 * tui/tui-layout.h: Rename include guard.
11838 * tui/tui-io.h: Rename include guard.
11839 * tui/tui-hooks.h: Rename include guard.
11840 * tui/tui-file.h: Rename include guard.
11841 * tui/tui-disasm.h: Rename include guard.
11842 * tui/tui-data.h: Rename include guard.
11843 * tui/tui-command.h: Rename include guard.
11844 * tic6x-tdep.h: Add include guard.
11845 * target/waitstatus.h: Rename include guard.
11846 * target/wait.h: Rename include guard.
11847 * target/target.h: Rename include guard.
11848 * target/resume.h: Rename include guard.
11849 * target-float.h: Rename include guard.
11850 * stabsread.h: Add include guard.
11851 * rs6000-tdep.h: Add include guard.
11852 * riscv-fbsd-tdep.h: Add include guard.
11853 * regformats/regdef.h: Rename include guard.
11854 * record.h: Rename include guard.
11855 * python/python.h: Rename include guard.
11856 * python/python-internal.h: Rename include guard.
11857 * python/py-stopevent.h: Rename include guard.
11858 * python/py-ref.h: Rename include guard.
11859 * python/py-record.h: Rename include guard.
11860 * python/py-record-full.h: Rename include guard.
11861 * python/py-record-btrace.h: Rename include guard.
11862 * python/py-instruction.h: Rename include guard.
11863 * python/py-events.h: Rename include guard.
11864 * python/py-event.h: Rename include guard.
11865 * procfs.h: Add include guard.
11866 * proc-utils.h: Add include guard.
11867 * p-lang.h: Add include guard.
11868 * or1k-tdep.h: Rename include guard.
11869 * observable.h: Rename include guard.
11870 * nto-tdep.h: Rename include guard.
11871 * nat/x86-linux.h: Rename include guard.
11872 * nat/x86-linux-dregs.h: Rename include guard.
11873 * nat/x86-gcc-cpuid.h: Add include guard.
11874 * nat/x86-dregs.h: Rename include guard.
11875 * nat/x86-cpuid.h: Rename include guard.
11876 * nat/ppc-linux.h: Rename include guard.
11877 * nat/mips-linux-watch.h: Rename include guard.
11878 * nat/linux-waitpid.h: Rename include guard.
11879 * nat/linux-ptrace.h: Rename include guard.
11880 * nat/linux-procfs.h: Rename include guard.
11881 * nat/linux-osdata.h: Rename include guard.
11882 * nat/linux-nat.h: Rename include guard.
11883 * nat/linux-namespaces.h: Rename include guard.
11884 * nat/linux-btrace.h: Rename include guard.
11885 * nat/glibc_thread_db.h: Rename include guard.
11886 * nat/gdb_thread_db.h: Rename include guard.
11887 * nat/gdb_ptrace.h: Rename include guard.
11888 * nat/fork-inferior.h: Rename include guard.
11889 * nat/amd64-linux-siginfo.h: Rename include guard.
11890 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11891 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11892 * nat/aarch64-linux.h: Rename include guard.
11893 * nat/aarch64-linux-hw-point.h: Rename include guard.
11894 * mn10300-tdep.h: Add include guard.
11895 * mips-linux-tdep.h: Add include guard.
11896 * mi/mi-parse.h: Rename include guard.
11897 * mi/mi-out.h: Rename include guard.
11898 * mi/mi-main.h: Rename include guard.
11899 * mi/mi-interp.h: Rename include guard.
11900 * mi/mi-getopt.h: Rename include guard.
11901 * mi/mi-console.h: Rename include guard.
11902 * mi/mi-common.h: Rename include guard.
11903 * mi/mi-cmds.h: Rename include guard.
11904 * mi/mi-cmd-break.h: Rename include guard.
11905 * m2-lang.h: Add include guard.
11906 * location.h: Rename include guard.
11907 * linux-record.h: Rename include guard.
11908 * linux-nat.h: Add include guard.
11909 * linux-fork.h: Add include guard.
11910 * i386-darwin-tdep.h: Rename include guard.
11911 * hppa-linux-offsets.h: Add include guard.
11912 * guile/guile.h: Rename include guard.
11913 * guile/guile-internal.h: Rename include guard.
11914 * gnu-nat.h: Rename include guard.
11915 * gdb-stabs.h: Rename include guard.
11916 * frv-tdep.h: Add include guard.
11917 * f-lang.h: Add include guard.
11918 * event-loop.h: Add include guard.
11919 * darwin-nat.h: Rename include guard.
11920 * cp-abi.h: Rename include guard.
11921 * config/sparc/nm-sol2.h: Rename include guard.
11922 * config/nm-nto.h: Rename include guard.
11923 * config/nm-linux.h: Add include guard.
11924 * config/i386/nm-i386gnu.h: Rename include guard.
11925 * config/djgpp/nl_types.h: Rename include guard.
11926 * config/djgpp/langinfo.h: Rename include guard.
11927 * compile/gcc-cp-plugin.h: Add include guard.
11928 * compile/gcc-c-plugin.h: Add include guard.
11929 * compile/compile.h: Rename include guard.
11930 * compile/compile-object-run.h: Rename include guard.
11931 * compile/compile-object-load.h: Rename include guard.
11932 * compile/compile-internal.h: Rename include guard.
11933 * compile/compile-cplus.h: Rename include guard.
11934 * compile/compile-c.h: Rename include guard.
11935 * common/xml-utils.h: Rename include guard.
11936 * common/x86-xstate.h: Rename include guard.
11937 * common/version.h: Rename include guard.
11938 * common/vec.h: Rename include guard.
11939 * common/tdesc.h: Rename include guard.
11940 * common/selftest.h: Rename include guard.
11941 * common/scoped_restore.h: Rename include guard.
11942 * common/scoped_mmap.h: Rename include guard.
11943 * common/scoped_fd.h: Rename include guard.
11944 * common/safe-iterator.h: Rename include guard.
11945 * common/run-time-clock.h: Rename include guard.
11946 * common/refcounted-object.h: Rename include guard.
11947 * common/queue.h: Rename include guard.
11948 * common/ptid.h: Rename include guard.
11949 * common/print-utils.h: Rename include guard.
11950 * common/preprocessor.h: Rename include guard.
11951 * common/pathstuff.h: Rename include guard.
11952 * common/observable.h: Rename include guard.
11953 * common/netstuff.h: Rename include guard.
11954 * common/job-control.h: Rename include guard.
11955 * common/host-defs.h: Rename include guard.
11956 * common/gdb_wait.h: Rename include guard.
11957 * common/gdb_vecs.h: Rename include guard.
11958 * common/gdb_unlinker.h: Rename include guard.
11959 * common/gdb_unique_ptr.h: Rename include guard.
11960 * common/gdb_tilde_expand.h: Rename include guard.
11961 * common/gdb_sys_time.h: Rename include guard.
11962 * common/gdb_string_view.h: Rename include guard.
11963 * common/gdb_splay_tree.h: Rename include guard.
11964 * common/gdb_setjmp.h: Rename include guard.
11965 * common/gdb_ref_ptr.h: Rename include guard.
11966 * common/gdb_optional.h: Rename include guard.
11967 * common/gdb_locale.h: Rename include guard.
11968 * common/gdb_assert.h: Rename include guard.
11969 * common/filtered-iterator.h: Rename include guard.
11970 * common/filestuff.h: Rename include guard.
11971 * common/fileio.h: Rename include guard.
11972 * common/environ.h: Rename include guard.
11973 * common/common-utils.h: Rename include guard.
11974 * common/common-types.h: Rename include guard.
11975 * common/common-regcache.h: Rename include guard.
11976 * common/common-inferior.h: Rename include guard.
11977 * common/common-gdbthread.h: Rename include guard.
11978 * common/common-exceptions.h: Rename include guard.
11979 * common/common-defs.h: Rename include guard.
11980 * common/common-debug.h: Rename include guard.
11981 * common/cleanups.h: Rename include guard.
11982 * common/buffer.h: Rename include guard.
11983 * common/btrace-common.h: Rename include guard.
11984 * common/break-common.h: Rename include guard.
11985 * cli/cli-utils.h: Rename include guard.
11986 * cli/cli-style.h: Rename include guard.
11987 * cli/cli-setshow.h: Rename include guard.
11988 * cli/cli-script.h: Rename include guard.
11989 * cli/cli-interp.h: Rename include guard.
11990 * cli/cli-decode.h: Rename include guard.
11991 * cli/cli-cmds.h: Rename include guard.
11992 * charset-list.h: Add include guard.
11993 * buildsym-legacy.h: Rename include guard.
11994 * bfin-tdep.h: Add include guard.
11995 * ax.h: Rename include guard.
11996 * arm-linux-tdep.h: Add include guard.
11997 * arm-fbsd-tdep.h: Add include guard.
11998 * arch/xtensa.h: Rename include guard.
11999 * arch/tic6x.h: Add include guard.
12000 * arch/i386.h: Add include guard.
12001 * arch/arm.h: Rename include guard.
12002 * arch/arm-linux.h: Rename include guard.
12003 * arch/arm-get-next-pcs.h: Rename include guard.
12004 * arch/amd64.h: Add include guard.
12005 * arch/aarch64-insn.h: Rename include guard.
12006 * arch-utils.h: Rename include guard.
12007 * annotate.h: Add include guard.
12008 * amd64-darwin-tdep.h: Rename include guard.
12009 * aarch64-linux-tdep.h: Add include guard.
12010 * aarch64-fbsd-tdep.h: Add include guard.
12011 * aarch32-linux-nat.h: Add include guard.
12012
ab9268d2
PW
120132019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12014
12015 * macrotab.c (macro_define_internal): New function that
12016 factorizes macro_define_object_internal and macro_define_function
12017 code.
12018 (macro_define_object_internal): Use macro_define_internal.
12019 (macro_define_function): Likewise.
12020
bb0da2b4
PW
120212019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12022
12023 * macrocmd.c (extract_identifier): Return
12024 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12025 callers.
12026
424eb552
JB
120272019-02-06 John Baldwin <jhb@FreeBSD.org>
12028
12029 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12030
1688cb29
TT
120312019-02-05 Tom Tromey <tom@tromey.com>
12032
12033 * target.c (target_stack::unpush): Move assertion earlier.
12034
b5eba2d8
TT
120352019-01-30 Tom Tromey <tom@tromey.com>
12036
12037 PR python/23615:
12038 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12039 (gdbpy_parse_and_eval): Likewise.
12040 * python/python-internal.h (gdbpy_allow_threads): New class.
12041
7054e2ff
JB
120422019-01-28 John Baldwin <jhb@FreeBSD.org>
12043
12044 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12045 (aarch64_fbsd_fpregmap): Move earlier.
12046 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12047 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12048 instead of individual calls to trad_frame_set_reg_addr.
12049 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12050 earlier.
12051 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12052 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12053 instead of individual calls to trad_frame_set_reg_addr.
12054
36c25ffa
AH
120552019-01-28 Alan Hayward <alan.hayward@arm.com>
12056
12057 * CONTRIBUTE: Replace contribution list with wiki link.
12058
a0707f3c
TT
120592019-01-25 Tom Tromey <tom@tromey.com>
12060
12061 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12062
0747795c
TT
120632019-01-25 Tom Tromey <tom@tromey.com>
12064
12065 * xtensa-linux-nat.c: Fix common/ includes.
12066 * xml-support.h: Fix common/ includes.
12067 * xml-support.c: Fix common/ includes.
12068 * x86-linux-nat.c: Fix common/ includes.
12069 * windows-nat.c: Fix common/ includes.
12070 * varobj.h: Fix common/ includes.
12071 * varobj.c: Fix common/ includes.
12072 * value.c: Fix common/ includes.
12073 * valops.c: Fix common/ includes.
12074 * utils.c: Fix common/ includes.
12075 * unittests/xml-utils-selftests.c: Fix common/ includes.
12076 * unittests/utils-selftests.c: Fix common/ includes.
12077 * unittests/unpack-selftests.c: Fix common/ includes.
12078 * unittests/tracepoint-selftests.c: Fix common/ includes.
12079 * unittests/style-selftests.c: Fix common/ includes.
12080 * unittests/string_view-selftests.c: Fix common/ includes.
12081 * unittests/scoped_restore-selftests.c: Fix common/ includes.
12082 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12083 * unittests/scoped_fd-selftests.c: Fix common/ includes.
12084 * unittests/rsp-low-selftests.c: Fix common/ includes.
12085 * unittests/parse-connection-spec-selftests.c: Fix common/
12086 includes.
12087 * unittests/optional-selftests.c: Fix common/ includes.
12088 * unittests/offset-type-selftests.c: Fix common/ includes.
12089 * unittests/observable-selftests.c: Fix common/ includes.
12090 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12091 * unittests/memrange-selftests.c: Fix common/ includes.
12092 * unittests/memory-map-selftests.c: Fix common/ includes.
12093 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12094 * unittests/function-view-selftests.c: Fix common/ includes.
12095 * unittests/environ-selftests.c: Fix common/ includes.
12096 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12097 * unittests/common-utils-selftests.c: Fix common/ includes.
12098 * unittests/cli-utils-selftests.c: Fix common/ includes.
12099 * unittests/array-view-selftests.c: Fix common/ includes.
12100 * ui-file.c: Fix common/ includes.
12101 * tui/tui-io.c: Fix common/ includes.
12102 * tracepoint.h: Fix common/ includes.
12103 * tracepoint.c: Fix common/ includes.
12104 * tracefile-tfile.c: Fix common/ includes.
12105 * top.h: Fix common/ includes.
12106 * top.c: Fix common/ includes.
12107 * thread.c: Fix common/ includes.
12108 * target/waitstatus.h: Fix common/ includes.
12109 * target/waitstatus.c: Fix common/ includes.
12110 * target.h: Fix common/ includes.
12111 * target.c: Fix common/ includes.
12112 * target-memory.c: Fix common/ includes.
12113 * target-descriptions.c: Fix common/ includes.
12114 * symtab.h: Fix common/ includes.
12115 * symfile.c: Fix common/ includes.
12116 * stap-probe.c: Fix common/ includes.
12117 * spu-linux-nat.c: Fix common/ includes.
12118 * sparc-nat.c: Fix common/ includes.
12119 * source.c: Fix common/ includes.
12120 * solib.c: Fix common/ includes.
12121 * solib-target.c: Fix common/ includes.
12122 * ser-unix.c: Fix common/ includes.
12123 * ser-tcp.c: Fix common/ includes.
12124 * ser-pipe.c: Fix common/ includes.
12125 * ser-base.c: Fix common/ includes.
12126 * selftest-arch.c: Fix common/ includes.
12127 * s12z-tdep.c: Fix common/ includes.
12128 * rust-exp.y: Fix common/ includes.
12129 * rs6000-aix-tdep.c: Fix common/ includes.
12130 * riscv-tdep.c: Fix common/ includes.
12131 * remote.c: Fix common/ includes.
12132 * remote-notif.h: Fix common/ includes.
12133 * remote-fileio.h: Fix common/ includes.
12134 * remote-fileio.c: Fix common/ includes.
12135 * regcache.h: Fix common/ includes.
12136 * regcache.c: Fix common/ includes.
12137 * record-btrace.c: Fix common/ includes.
12138 * python/python.c: Fix common/ includes.
12139 * python/py-type.c: Fix common/ includes.
12140 * python/py-inferior.c: Fix common/ includes.
12141 * progspace.h: Fix common/ includes.
12142 * producer.c: Fix common/ includes.
12143 * procfs.c: Fix common/ includes.
12144 * proc-api.c: Fix common/ includes.
12145 * printcmd.c: Fix common/ includes.
12146 * ppc-linux-nat.c: Fix common/ includes.
12147 * parser-defs.h: Fix common/ includes.
12148 * osdata.c: Fix common/ includes.
12149 * obsd-nat.c: Fix common/ includes.
12150 * nat/x86-linux.c: Fix common/ includes.
12151 * nat/x86-linux-dregs.c: Fix common/ includes.
12152 * nat/x86-dregs.h: Fix common/ includes.
12153 * nat/x86-dregs.c: Fix common/ includes.
12154 * nat/ppc-linux.c: Fix common/ includes.
12155 * nat/mips-linux-watch.h: Fix common/ includes.
12156 * nat/mips-linux-watch.c: Fix common/ includes.
12157 * nat/linux-waitpid.c: Fix common/ includes.
12158 * nat/linux-ptrace.h: Fix common/ includes.
12159 * nat/linux-ptrace.c: Fix common/ includes.
12160 * nat/linux-procfs.c: Fix common/ includes.
12161 * nat/linux-personality.c: Fix common/ includes.
12162 * nat/linux-osdata.c: Fix common/ includes.
12163 * nat/linux-namespaces.c: Fix common/ includes.
12164 * nat/linux-btrace.h: Fix common/ includes.
12165 * nat/linux-btrace.c: Fix common/ includes.
12166 * nat/fork-inferior.c: Fix common/ includes.
12167 * nat/amd64-linux-siginfo.c: Fix common/ includes.
12168 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12169 * nat/aarch64-linux.c: Fix common/ includes.
12170 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12171 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12172 * namespace.h: Fix common/ includes.
12173 * mips-linux-tdep.c: Fix common/ includes.
12174 * minsyms.c: Fix common/ includes.
12175 * mi/mi-parse.h: Fix common/ includes.
12176 * mi/mi-main.c: Fix common/ includes.
12177 * mi/mi-cmd-env.c: Fix common/ includes.
12178 * memrange.h: Fix common/ includes.
12179 * memattr.c: Fix common/ includes.
12180 * maint.h: Fix common/ includes.
12181 * maint.c: Fix common/ includes.
12182 * main.c: Fix common/ includes.
12183 * machoread.c: Fix common/ includes.
12184 * location.c: Fix common/ includes.
12185 * linux-thread-db.c: Fix common/ includes.
12186 * linux-nat.c: Fix common/ includes.
12187 * linux-fork.c: Fix common/ includes.
12188 * inline-frame.c: Fix common/ includes.
12189 * infrun.c: Fix common/ includes.
12190 * inflow.c: Fix common/ includes.
12191 * inferior.h: Fix common/ includes.
12192 * inferior.c: Fix common/ includes.
12193 * infcmd.c: Fix common/ includes.
12194 * inf-ptrace.c: Fix common/ includes.
12195 * inf-child.c: Fix common/ includes.
12196 * ia64-linux-nat.c: Fix common/ includes.
12197 * i387-tdep.c: Fix common/ includes.
12198 * i386-tdep.c: Fix common/ includes.
12199 * i386-linux-tdep.c: Fix common/ includes.
12200 * i386-linux-nat.c: Fix common/ includes.
12201 * i386-go32-tdep.c: Fix common/ includes.
12202 * i386-fbsd-tdep.c: Fix common/ includes.
12203 * i386-fbsd-nat.c: Fix common/ includes.
12204 * guile/scm-type.c: Fix common/ includes.
12205 * guile/guile.c: Fix common/ includes.
12206 * go32-nat.c: Fix common/ includes.
12207 * gnu-nat.c: Fix common/ includes.
12208 * gdbthread.h: Fix common/ includes.
12209 * gdbarch-selftests.c: Fix common/ includes.
12210 * gdb_usleep.c: Fix common/ includes.
12211 * gdb_select.h: Fix common/ includes.
12212 * gdb_bfd.c: Fix common/ includes.
12213 * gcore.c: Fix common/ includes.
12214 * fork-child.c: Fix common/ includes.
12215 * findvar.c: Fix common/ includes.
12216 * fbsd-nat.c: Fix common/ includes.
12217 * event-top.c: Fix common/ includes.
12218 * event-loop.c: Fix common/ includes.
12219 * dwarf2read.c: Fix common/ includes.
12220 * dwarf2loc.c: Fix common/ includes.
12221 * dwarf2-frame.c: Fix common/ includes.
12222 * dwarf-index-cache.c: Fix common/ includes.
12223 * dtrace-probe.c: Fix common/ includes.
12224 * disasm-selftests.c: Fix common/ includes.
12225 * defs.h: Fix common/ includes.
12226 * csky-tdep.c: Fix common/ includes.
12227 * cp-valprint.c: Fix common/ includes.
12228 * cp-support.h: Fix common/ includes.
12229 * cp-support.c: Fix common/ includes.
12230 * corelow.c: Fix common/ includes.
12231 * completer.h: Fix common/ includes.
12232 * completer.c: Fix common/ includes.
12233 * compile/compile.c: Fix common/ includes.
12234 * compile/compile-loc2c.c: Fix common/ includes.
12235 * compile/compile-cplus-types.c: Fix common/ includes.
12236 * compile/compile-cplus-symbols.c: Fix common/ includes.
12237 * command.h: Fix common/ includes.
12238 * cli/cli-dump.c: Fix common/ includes.
12239 * cli/cli-cmds.c: Fix common/ includes.
12240 * charset.c: Fix common/ includes.
12241 * build-id.c: Fix common/ includes.
12242 * btrace.h: Fix common/ includes.
12243 * btrace.c: Fix common/ includes.
12244 * breakpoint.h: Fix common/ includes.
12245 * breakpoint.c: Fix common/ includes.
12246 * ax.h:
12247 (enum agent_op): Fix common/ includes.
12248 * ax-general.c (struct aop_map): Fix common/ includes.
12249 * ax-gdb.c: Fix common/ includes.
12250 * auxv.c: Fix common/ includes.
12251 * auto-load.c: Fix common/ includes.
12252 * arm-tdep.c: Fix common/ includes.
12253 * arch/riscv.c: Fix common/ includes.
12254 * arch/ppc-linux-common.c: Fix common/ includes.
12255 * arch/i386.c: Fix common/ includes.
12256 * arch/arm.c: Fix common/ includes.
12257 * arch/arm-linux.c: Fix common/ includes.
12258 * arch/arm-get-next-pcs.c: Fix common/ includes.
12259 * arch/amd64.c: Fix common/ includes.
12260 * arch/aarch64.c: Fix common/ includes.
12261 * arch/aarch64-insn.c: Fix common/ includes.
12262 * arch-utils.c: Fix common/ includes.
12263 * amd64-windows-tdep.c: Fix common/ includes.
12264 * amd64-tdep.c: Fix common/ includes.
12265 * amd64-sol2-tdep.c: Fix common/ includes.
12266 * amd64-obsd-tdep.c: Fix common/ includes.
12267 * amd64-nbsd-tdep.c: Fix common/ includes.
12268 * amd64-linux-tdep.c: Fix common/ includes.
12269 * amd64-linux-nat.c: Fix common/ includes.
12270 * amd64-fbsd-tdep.c: Fix common/ includes.
12271 * amd64-fbsd-nat.c: Fix common/ includes.
12272 * amd64-dicos-tdep.c: Fix common/ includes.
12273 * amd64-darwin-tdep.c: Fix common/ includes.
12274 * agent.c: Fix common/ includes.
12275 * ada-lang.h: Fix common/ includes.
12276 * ada-lang.c: Fix common/ includes.
12277 * aarch64-tdep.c: Fix common/ includes.
12278
2f5c153e
TT
122792019-01-25 Tom Tromey <tom@tromey.com>
12280
12281 * common/create-version.sh: Use common/version.h.
12282
adc6a863
PA
122832019-01-24 Pedro Alves <palves@redhat.com>
12284
12285 * infrun.c (signal_stop, signal_print, signal_program)
12286 (signal_catch, signal_pass): Now arrays instead of pointers.
12287 (update_signals_program_target, do_target_resume)
12288 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12289 * linux-nat.c (linux_nat_target::pass_signals)
12290 (linux_nat_target::create_inferior, linux_nat_target::attach):
12291 Adjust.
12292 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12293 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12294 * procfs.c (procfs_target::pass_signals): Adjust.
12295 * record-full.c (record_full_target::resume): Adjust.
12296 * remote.c (remote_target::pass_signals)
12297 (remote_target::program_signals): Adjust.
12298 * target-debug.h (target_debug_print_signals): Now takes a
12299 gdb::array_view as parameter. Adjust.
12300 * target.h (target_ops) <pass_signals, program_signals>: Replace
12301 pointer and length parameters with gdb::array_view.
12302 (target_pass_signals, target_program_signals): Likewise.
12303 * target-delegates.c: Regenerate.
12304
3046d67a
PA
123052019-01-24 Pedro Alves <palves@redhat.com>
12306
12307 * common/forward-scope-exit.h
12308 (forward_scope_exit::forward_scope_exit): Pass arguments to
12309 m_bind_function directly, instead of creating a std::bind and
12310 copying that.
12311
353229bf
AH
123122019-01-24 Alan Hayward <alan.hayward@arm.com>
12313
12314 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12315 for static members.
12316 (pass_in_v_vfp_candidate): Likewise.
12317
311dc83a
TT
123182019-01-23 Tom Tromey <tom@tromey.com>
12319 Pedro Alves <palves@redhat.com>
12320
12321 * regcache.c (class regcache_invalidator): Remove.
12322 (regcache::raw_write): Use make_scope_exit.
12323
296bd123
TT
123242019-01-23 Tom Tromey <tom@tromey.com>
12325
12326 * ui-out.h (class ui_out_emit_type): Update comment.
12327
979a0d13
TT
123282019-01-23 Tom Tromey <tom@tromey.com>
12329
12330 * infrun.c (fetch_inferior_event): Update comment.
12331
d238133d
TT
123322019-01-23 Tom Tromey <tom@tromey.com>
12333 Pedro Alves <palves@redhat.com>
12334
12335 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12336 parameter.
12337 (fetch_inferior_event): Use SCOPE_EXIT.
12338
12339
9885e6bb
TT
123402019-01-23 Tom Tromey <tom@tromey.com>
12341 Pedro Alves <palves@redhat.com>
12342
12343 * infrun.c (disable_thread_events): Delete.
12344 (stop_all_threads): Use SCOPE_EXIT.
12345
286526c1
TT
123462019-01-23 Tom Tromey <tom@tromey.com>
12347 Pedro Alves <palves@redhat.com>
12348
12349 * symfile.c: Include forward-scope-exit.h.
12350 (clear_symtab_users_cleanup): Replace forward declaration with
12351 a FORWARD_SCOPE_EXIT.
12352 (syms_from_objfile_1): Use the forward_scope_exit and
12353 gdb::optional instead of cleanup_function.
12354 (reread_symbols): Use the forward_scope_exit instead of
12355 cleanup_function.
12356 (clear_symtab_users_cleanup): Remove function.
12357
1db93f14
TT
123582019-01-23 Tom Tromey <tom@tromey.com>
12359 Pedro Alves <palves@redhat.com>
12360
12361 * linux-nat.c: Include scope-exit.h.
12362 (cleanup_target_stop): Remove.
12363 (linux_nat_target::static_tracepoint_markers_by_strid): Use
12364 SCOPE_EXIT.
12365
2cc83d1e
TT
123662019-01-23 Tom Tromey <tom@tromey.com>
12367 Pedro Alves <palves@redhat.com>
12368
12369 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12370 (call_function_by_hand_dummy): Use SCOPE_EXIT.
12371
694c6bf5
TT
123722019-01-23 Tom Tromey <tom@tromey.com>
12373 Andrew Burgess <andrew.burgess@embecosm.com>
12374 Pedro Alves <palves@redhat.com>
12375
12376 * infrun.c (fetch_inferior_event): Use scope_exit.
12377 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12378 * top.c (execute_command): Use scope_exit.
12379 * breakpoint.c (bpstat_do_actions): Use scope_exit.
12380 * utils.c (do_bpstat_clear_actions_cleanup)
12381 (make_bpstat_clear_actions_cleanup): Remove.
12382
4c41382a
TT
123832019-01-23 Tom Tromey <tom@tromey.com>
12384 Pedro Alves <palves@redhat.com>
12385
12386 * infrun.c: Include "common/scope-exit.h"
12387 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12388 (wait_for_inferior): Use SCOPE_EXIT.
12389 (fetch_inferior_event): Use scope_exit.
12390
89f8fb50
TT
123912019-01-23 Tom Tromey <tom@tromey.com>
12392 Pedro Alves <palves@redhat.com>
12393
12394 * breakpoint.c (create_breakpoint): Remove cleanup.
12395
5419bdae
TT
123962019-01-23 Tom Tromey <tom@tromey.com>
12397 Andrew Burgess <andrew.burgess@embecosm.com>
12398 Pedro Alves <palves@redhat.com>
12399
e587ef42
PA
124002019-01-23 Pedro Alves <palves@redhat.com>
12401
12402 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12403
77f0e74c
PA
124042019-01-23 Pedro Alves <palves@redhat.com>
12405 Andrew Burgess <andrew.burgess@embecosm.com>
12406
12407 * gdbthread.h: Include "common/forward-scope-exit.h".
12408 (scoped_finish_thread_state): Redefine custom class in terms of
12409 forward_scope_exit.
12410
5b9b3e53
PA
124112019-01-23 Pedro Alves <palves@redhat.com>
12412 Andrew Burgess <andrew.burgess@embecosm.com>
12413
12414 * common/forward-scope-exit.h: New file.
12415
54b65c9b
PA
124162019-01-23 Pedro Alves <palves@redhat.com>
12417 Andrew Burgess <andrew.burgess@embecosm.com>
12418 Tom Tromey <tom@tromey.com>
12419
12420 * common/scope-exit.h: New file.
12421
cf08fb29
PA
124222019-01-23 Pedro Alves <palves@redhat.com>
12423
12424 * common/preprocessor.h (ESC): Rename to ...
12425 (ESC_PARENS): ... this.
12426 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12427 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12428
ae73e2e2
TT
124292019-01-23 Tom Tromey <tom@tromey.com>
12430
12431 * language.h (class scoped_switch_to_sym_language_if_auto):
12432 Initialize m_lang in both cases.
12433
6594e122
AH
124342019-01-23 Alan Hayward <alan.hayward@arm.com>
12435
12436 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12437 with XCNEW.
12438
a7c9855d
TT
124392019-01-22 Tom Tromey <tom@tromey.com>
12440
12441 * corelow.c: Do not include sys/file.h.
12442
93cc1d53
TT
124432019-01-22 Tom Tromey <tom@tromey.com>
12444
12445 * tui/tui-wingeneral.h: Include gdb_curses.h.
12446
38561778
TT
124472019-01-22 Tom Tromey <tom@tromey.com>
12448
12449 * source-cache.h (class source_cache) <get_source_lines,
12450 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12451
37b3ab5b
TT
124522019-01-22 Tom Tromey <tom@tromey.com>
12453
12454 * remote-fileio.h (struct remote_target): Declare.
12455
3fabc016
TT
124562019-01-22 Tom Tromey <tom@tromey.com>
12457
12458 * python/py-arch.c: Do not include py-ref.h.
12459 * python/py-bpevent.c: Do not include py-ref.h.
12460 * python/py-cmd.c: Do not include py-ref.h.
12461 * python/py-continueevent.c: Do not include py-ref.h.
12462 * python/py-event.h: Do not include py-ref.h.
12463 * python/py-evtregistry.c: Do not include py-ref.h.
12464 * python/py-finishbreakpoint.c: Do not include py-ref.h.
12465 * python/py-frame.c: Do not include py-ref.h.
12466 * python/py-framefilter.c: Do not include py-ref.h.
12467 * python/py-function.c: Do not include py-ref.h.
12468 * python/py-infevents.c: Do not include py-ref.h.
12469 * python/py-linetable.c: Do not include py-ref.h.
12470 * python/py-objfile.c: Do not include py-ref.h.
12471 * python/py-param.c: Do not include py-ref.h.
12472 * python/py-prettyprint.c: Do not include py-ref.h.
12473 * python/py-progspace.c: Do not include py-ref.h.
12474 * python/py-symbol.c: Do not include py-ref.h.
12475 * python/py-symtab.c: Do not include py-ref.h.
12476 * python/py-type.c: Do not include py-ref.h.
12477 * python/py-unwind.c: Do not include py-ref.h.
12478 * python/py-utils.c: Do not include py-ref.h.
12479 * python/py-value.c: Do not include py-ref.h.
12480 * python/py-varobj.c: Do not include py-ref.h.
12481 * python/py-xmethods.c: Do not include py-ref.h.
12482 * python/python.c: Do not include py-ref.h.
12483 * varobj.c: Do not include py-ref.h.
12484
6b4d7774
TT
124852019-01-22 Tom Tromey <tom@tromey.com>
12486
12487 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12488 keyword for bcache.
12489
7af7e9b5
TT
124902019-01-22 Tom Tromey <tom@tromey.com>
12491
12492 * compile/compile-cplus-types.c: Remove a comment by #include.
12493
951d1049
TT
124942019-01-22 Tom Tromey <tom@tromey.com>
12495
12496 * compile/gcc-c-plugin.h: Include compile-internal.h.
12497
d65d5705
TT
124982019-01-22 Tom Tromey <tom@tromey.com>
12499
12500 * stabsread.c (EXTERN): Do not define.
12501 (symnum, next_symbol_text_func, processing_gcc_compilation)
12502 (within_function, global_sym_chain, global_stabs)
12503 (previous_stab_code, this_object_header_files)
12504 (n_this_object_header_files)
12505 (n_allocated_this_object_header_files): Define.
12506 * stabsread.h (EXTERN): Never define. Use "extern".
12507
b6fb1ee5
PW
125082019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12509
12510 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12511 history_value.
12512
be6d4f74
TT
125132019-01-21 Tom Tromey <tom@tromey.com>
12514
12515 * ui-out.c: Fix includes.
12516 * tui/tui-source.c: Fix includes.
12517 * target.c: Fix includes.
12518 * remote.c: Fix includes.
12519 * regcache.c: Fix includes.
12520 * python/py-block.c: Fix includes.
12521 * printcmd.c: Fix includes.
12522 * or1k-tdep.c: Fix includes.
12523 * mi/mi-main.c: Fix includes.
12524 * m32r-tdep.c: Fix includes.
12525 * csky-tdep.c: Fix includes.
12526 * compile/compile-cplus-types.c: Fix includes.
12527 * cli/cli-interp.c: Fix includes.
12528
73021deb
AH
125292019-01-21 Alan Hayward <alan.hayward@arm.com>
12530
12531 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12532 for padding.
12533
7932255d
TT
125342019-01-16 Tom Tromey <tom@tromey.com>
12535
12536 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
12537 earlier.
12538 (struct objfile) <msymbols_range>: Move from top level.
12539 <msymbols>: New method.
12540 (class objfile_msymbols): Remove.
12541 * symtab.c (default_collect_symbol_completion_matches_break_on):
12542 Update.
12543 * symmisc.c (dump_msymbols): Update.
12544 * stabsread.c (scan_file_globals): Update.
12545 * objc-lang.c (info_selectors_command, info_classes_command)
12546 (find_methods): Update.
12547 * minsyms.c (find_solib_trampoline_target): Update.
12548 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12549 * coffread.c (coff_symfile_read): Update.
12550 * ada-lang.c (ada_lookup_simple_minsym)
12551 (ada_collect_symbol_completion_matches): Update.
12552
604b1bfb
TT
125532019-01-16 Tom Tromey <tom@tromey.com>
12554
12555 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12556 type. Remove no-argument constructor.
12557 <iterator::operator++>: Simplify.
12558 <begin>: Update.
12559 <end>: Use minimal_symbol_count.
12560
f252c6d5
TT
125612019-01-16 Tom Tromey <tom@tromey.com>
12562
12563 * objfiles.h (struct objfile) <psymtabs>: New method.
12564 (class objfile_psymtabs): Remove.
12565 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12566 typedef.
12567 <range>: New method.
12568 (require_partial_symbols): Change return type.
12569 * psymtab.c (require_partial_symbols)
12570 (psym_expand_symtabs_matching): Update.
12571 * mdebugread.c (parse_partial_symbols): Update.
12572 * dbxread.c (dbx_end_psymtab): Update.
12573
b669c953
TT
125742019-01-15 Tom Tromey <tom@tromey.com>
12575
12576 * symtab.c (lookup_objfile_from_block)
12577 (lookup_symbol_in_objfile_symtabs)
12578 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12579 (find_line_symtab, info_sources_command)
12580 (default_collect_symbol_completion_matches_break_on)
12581 (make_source_files_completion_list): Update.
12582 * symmisc.c (print_objfile_statistics, dump_objfile)
12583 (maintenance_print_symbols, maintenance_info_symtabs)
12584 (maintenance_check_symtabs, maintenance_info_line_tables):
12585 Update.
12586 * source.c (select_source_symtab)
12587 (forget_cached_source_info_for_objfile): Update.
12588 * objfiles.h (class objfile_compunits): Remove.
12589 (struct objfile) <compunits_range>: New typedef.
12590 (compunits): New method.
12591 * objfiles.c (objfile_relocate1): Update.
12592 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12593 * maint.c (count_symtabs_and_blocks): Update.
12594 * linespec.c (iterate_over_all_matching_symtabs): Update.
12595 * cp-support.c (add_symbol_overload_list_qualified): Update.
12596 * coffread.c (coff_symtab_read): Update.
12597 * ada-lang.c (add_nonlocal_symbols)
12598 (ada_collect_symbol_completion_matches)
12599 (ada_add_global_exceptions): Update.
12600
7e955d83
TT
126012019-01-15 Tom Tromey <tom@tromey.com>
12602
12603 * progspace.h (program_space) <objfiles_safe_range>: New
12604 typedef.
12605 <objfiles_safe>: New method.
12606 * objfiles.h (class all_objfiles_safe): Remove.
12607 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12608 * jit.c (jit_inferior_exit_hook): Update.
12609
2030c079
TT
126102019-01-17 Tom Tromey <tom@tromey.com>
12611
12612 * progspace.h (program_space) <objfiles_range>: New typedef.
12613 <objfiles>: New method.
12614 <objfiles_head>: Rename from objfiles.
12615 (object_files): Update.
12616 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12617 * guile/scm-pretty-print.c
12618 (ppscm_find_pretty_printer_from_objfiles): Update.
12619 * guile/scm-objfile.c (gdbscm_objfiles): Update.
12620 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12621 Update.
12622 * python/py-progspace.c (pspy_get_objfiles): Update.
12623 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12624 Update.
12625 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12626 (objfpy_lookup_objfile_by_build_id): Update.
12627 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12628 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12629 Update.
12630 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12631 (expand_symtab_containing_pc, lookup_objfile_from_block)
12632 (lookup_static_symbol, basic_lookup_transparent_type)
12633 (find_pc_sect_compunit_symtab, find_symbol_at_address)
12634 (find_line_symtab, info_sources_command)
12635 (default_collect_symbol_completion_matches_break_on)
12636 (make_source_files_completion_list, find_main_name): Update.
12637 * symmisc.c (print_symbol_bcache_statistics)
12638 (print_objfile_statistics, maintenance_print_symbols)
12639 (maintenance_print_msymbols, maintenance_print_objfiles)
12640 (maintenance_info_symtabs, maintenance_check_symtabs)
12641 (maintenance_expand_symtabs, maintenance_info_line_tables):
12642 Update.
12643 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12644 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12645 (map_overlay_command, unmap_overlay_command)
12646 (simple_overlay_update, expand_symtabs_matching)
12647 (map_symbol_filenames): Update.
12648 * symfile-debug.c (set_debug_symfile): Update.
12649 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12650 Update.
12651 * source.c (select_source_symtab, forget_cached_source_info):
12652 Update.
12653 * solib.c (solib_read_symbols): Update.
12654 * solib-spu.c (append_ocl_sos): Update.
12655 * psymtab.c (maintenance_print_psymbols)
12656 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12657 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12658 * printcmd.c (info_symbol_command): Update.
12659 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12660 Update.
12661 * objfiles.h (class all_objfiles): Remove.
12662 * objfiles.c (have_partial_symbols, have_full_symbols)
12663 (have_minimal_symbols, qsort_cmp, update_section_map)
12664 (shared_objfile_contains_address_p)
12665 (default_iterate_over_objfiles_in_search_order): Update.
12666 * objc-lang.c (info_selectors_command, info_classes_command)
12667 (find_methods): Update.
12668 * minsyms.c (find_solib_trampoline_target): Update.
12669 * maint.c (maintenance_info_sections)
12670 (maintenance_translate_address, count_symtabs_and_blocks):
12671 Update.
12672 * main.c (captured_main_1): Update.
12673 * linux-thread-db.c (try_thread_db_load_from_pdir)
12674 (has_libpthread): Update.
12675 * linespec.c (iterate_over_all_matching_symtabs)
12676 (search_minsyms_for_name): Update.
12677 * jit.c (jit_find_objf_with_entry_addr): Update.
12678 * hppa-tdep.c (find_unwind_entry)
12679 (hppa_lookup_stub_minimal_symbol): Update.
12680 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12681 Update.
12682 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12683 (elf_gnu_ifunc_resolve_by_got): Update.
12684 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12685 * dwarf-index-write.c (save_gdb_index_command): Update.
12686 * cp-support.c (add_symbol_overload_list_qualified): Update.
12687 * breakpoint.c (create_overlay_event_breakpoint)
12688 (create_longjmp_master_breakpoint)
12689 (create_std_terminate_master_breakpoint)
12690 (create_exception_master_breakpoint): Update.
12691 * blockframe.c (find_pc_partial_function): Update.
12692 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12693 (ada_collect_symbol_completion_matches)
12694 (ada_add_global_exceptions): Update.
12695
776489e0
TT
126962019-01-17 Tom Tromey <tom@tromey.com>
12697
12698 * solib-target.c (lm_info_target_p): Remove typedef. Don't
12699 declare VEC.
12700 (solib_target_parse_libraries): Change return type.
12701 (library_list_start_segment, library_list_start_section)
12702 (library_list_end_library, library_list_start_library); Update.
12703 (solib_target_free_library_list): Remove.
12704 (solib_target_parse_libraries): Remove cleanup. Change return
12705 type.
12706 (solib_target_current_sos): Update.
12707
6471e7d2
TT
127082019-01-17 Tom Tromey <tromey@bapiya>
12709
12710 * valprint.c: Replace "the the" with "the".
12711 * symtab.c: Replace "the the" with "the".
12712 * solib.c: Replace "the the" with "the".
12713 * solib-dsbt.c: Replace "the the" with "the".
12714 * linespec.c: Replace "the the" with "the".
12715 * dwarf2loc.h: Replace "the the" with "the".
12716 * amd64-windows-tdep.c: Replace "the the" with "the".
12717 * aarch64-tdep.c: Replace "the the" with "the".
12718
c24bdb02
KS
127192019-01-16 Keith Seitz <keiths@redhat.com>
12720
12721 PR gdb/23773
12722 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12723 <builder>: Rename to ..
12724 <m_builder>: ... this and make private.
12725 (dwarf2_cu::get_builder): New method. Change all users of
12726 `builder' to use this method.
12727 (dwarf2_start_symtab): Move to ...
12728 (dwarf2_cu::start_symtab): ... here. Update all callers
12729 (setup_type_unit_groups): Move to ...
12730 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
12731 callers.
12732 (dwarf2_cu::reset_builder): New method.
12733 (process_full_compunit, process_full_type_unit): Use
12734 dwarf2_cu::reset_builder.
12735 (follow_die_offset): Record the ancestor CU if it is different
12736 from the followed DIE's CU.
12737 (follow_die_sig_1): Likewise.
12738
8d64371b
TT
127392019-01-15 Tom Tromey <tom@tromey.com>
12740
12741 * remote.c (class remote_state) <buf>: Now a char_vector.
12742 <buf_size>: Remove.
12743 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
12744 parameter.
12745 (remote_target::getpkt_or_notif_sane_1)
12746 (remote_target::getpkt_sane)
12747 (remote_target::getpkt_or_notif_sane): Likewise.
12748 (class remote_target) <putpkt>: New overload.
12749 (remote_target::read_frame): Change type of "buf_p". Remove
12750 sizeof_p parameter.
12751 (packet_ok): New overload.
12752 (packet_check_result): New overload.
12753 Update all uses.
12754
bb277751
TT
127552019-01-14 Tom Tromey <tom@tromey.com>
12756
12757 * remote-notif.c (handle_notification, remote_notif_ack)
12758 (remote_notif_parse): Make "buf" const.
12759 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12760 const.
12761 (remote_notif_parse, remote_notif_ack, handle_notification):
12762 Likewise.
12763 * remote.c (remote_notif_stop_parse): Make "buf" const.
12764 (remote_target::remote_parse_stop_reply): Make "buf" const.
12765 (remote_notif_stop_ack): Make "buf" const.
12766
05be00a8
TT
127672019-01-14 Tom Tromey <tom@tromey.com>
12768
12769 * remote.c (remote_console_output): Make parameter const.
12770
491adeca
TT
127712019-01-14 Tom Tromey <tom@tromey.com>
12772
12773 * target-debug.h (target_debug_print_signals): Constify.
12774 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12775 * procfs.c (procfs_target::pass_signals): Update.
12776 * linux-nat.c (linux_nat_target::pass_signals): Update.
12777 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12778 * target-delegates.c: Rebuild.
12779 * remote.c (remote_target::program_signals): Update.
12780 (remote_target::pass_signals): Update.
12781 * target.c (target_pass_signals): Constify argument.
12782 (target_program_signals): Likewise.
12783 * target.h (struct target_ops) <pass_signals, program_signals>:
12784 Constify argument.
12785 (target_pass_signals, target_program_signals): Constify argument.
12786
bbd94648
TT
127872019-01-14 Tom Tromey <tom@tromey.com>
12788
12789 PR tui/28819:
12790 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12791
6f072a10
PFC
127922019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
12793
12794 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12795 field.
12796 * rs6000-tdep.c: Include reggroups.h.
12797 (IS_V_ALIAS_PSEUDOREG): Define.
12798 (rs6000_register_name): Return names for the "vX" aliases.
12799 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12800 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
12801 aliases. Call default_register_reggroup_p for all other
12802 pseudo-registers.
12803 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12804 New functions.
12805 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12806 Handle "vX" aliases.
12807 (v_alias_pseudo_register_collect): New function.
12808 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12809 (rs6000_gdbarch_init): Initialize "vX" aliases as
12810 pseudo-registers. Restore registration of
12811 rs6000_pseudo_register_reggroup_p with
12812 set_tdesc_pseudo_register_reggroup_p.
12813
1a782351
MF
128142019-01-13 Max Filippov <jcmvbkbc@gmail.com>
12815
12816 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12817 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12818 set_gdbarch_num_pseudo_regs.
12819
d73cff18
PW
128202019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12821
12822 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12823 Remove arg prefixname, add do_set and do_show.
12824 Add member functions set_list and show_list.
12825 * cli/cli-style.c (class cli_style_option): Update accordingly.
12826 (style_set_list): Move to file scope.
12827 (style_show_list): Likewise.
12828 (set_style): Call help_list.
12829 (show_style): Call cmd_show_list.
12830 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12831 Update to use the new macro.
12832
60a90376
JB
128332019-10-12 Joel Brobecker <brobecker@adacore.com>
12834
12835 * ada-lang.c (_initialize_ada_language): Expand the help text
12836 for the "catch exception" command.
12837
9d7c67bf
PW
128382019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12839
12840 * symtab.c (matching_obj_sections): Initialize obj,
12841 declare it closer to its usage.
12842
7cf47dc4
TT
128432019-01-10 Tom Tromey <tom@tromey.com>
12844
12845 * thread-iter.h (inf_threads_iterator): Use next_iterator.
12846 (basic_inf_threads_range): Remove.
12847 (inf_threads_range, inf_non_exited_threads_range)
12848 (safe_inf_threads_range): Use next_adapter.
12849
d3cb6808
KS
128502019-01-10 Keith Seitz <keiths@redhat.com>
12851
12852 PR gdb/23712
12853 PR symtab/23010
12854 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12855 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12856
63a20375
KS
128572019-01-10 Keith Seitz <keiths@redhat.com>
12858
12859 PR gdb/23712
12860 PR symtab/23010
12861 * dictionary.c (pending_to_vector): Remove.
12862 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12863 Remove _1 suffix, replacing functions of the same name. Update
12864 all callers.
12865 (dict_create_hashed, dict_create_hashed_expandable)
12866 (dict_create_linear, dict_create_linear_expandable, dict_free)
12867 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12868 Make functions static.
12869
b026f593
KS
128702019-01-10 Keith Seitz <keiths@redhat.com>
12871
12872 PR gdb/23712
12873 PR symtab/23010
12874 * dictionary.h (struct dictionary): Replace declaration with
12875 multidictionary.
12876 (dict_create_hashed, dict_create_hashed_expandable)
12877 (dict_create_linear, dict_create_linear_expandable)
12878 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12879 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12880 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12881 taking multidictionary argument.
12882 [ALL_DICT_SYMBOLS]: Update for multidictionary.
12883 * block.h (struct block) <dict>: Change to multidictionary
12884 and rename `multidict'.
12885 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12886 symmisc.c: Update all dictionary references to multidictionary.
12887
c7748ee9
KS
128882019-01-10 Keith Seitz <keiths@redhat.com>
12889
12890 PR gdb/23712
12891 PR symtab/23010
12892 * dictionary.c: Include unordered_map.
12893 (pending_to_vector): New function.
12894 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12895 Rewrite the non-"_1" functions to take vector instead
12896 of linked list.
12897 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12898 "new" _1 versions of the same name.
12899 (multidictionary): Define.
12900 (std::hash<enum language): New definition.
12901 (collate_pending_symbols_by_language, mdict_create_hashed)
12902 (mdict_create_hashed_expandable, mdict_create_linear)
12903 (mdict_create_linear_expandable, mdict_free)
12904 (find_language_dictionary, create_new_language_dictionary)
12905 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12906 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12907 (mdict_size, mdict_empty): New functions.
12908 * dictionary.h (mdict_iterator): Define.
12909
67aa1f3c
PA
129102019-01-10 Pedro Alves <palves@redhat.com>
12911
12912 * breakpoint.c (read_uploaded_action)
12913 (create_tracepoint_from_upload): Adjust to use
12914 gdb::unique_xmalloc_ptr.
12915 * ctf.c (ctf_write_uploaded_tp):
12916 (SET_ARRAY_FIELD): Use emplace_back.
12917 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12918 * tracefile-tfile.c (tfile_write_uploaded_tp):
12919 * tracepoint.c (parse_tracepoint_definition): Adjust to use
12920 gdb::unique_xmalloc_ptr.
12921 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12922 at_string, cond_string, cmd_strings>: Replace char pointers
12923 with gdb::unique_xmalloc_ptr.
12924
2f667667
PA
129252019-01-10 Pedro Alves <palves@redhat.com>
12926
12927 * solib-target.c (library_list_start_library): Don't xstrdup name.
12928
36cb7237
PA
129292019-01-10 Pedro Alves <palves@redhat.com>
12930
12931 * mdebugread.c (parse_partial_symbols): Use
12932 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12933
da584958
AB
129342019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12935
12936 * linux-fork.c (scoped_switch_fork_info)
12937 <~scoped_switch_fork_info>: Fix incorrect variable name.
12938
1ef8573c
AB
129392019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12940
12941 * linux-fork.c (scoped_switch_fork_info)
12942 <scoped_switch_fork_info>: Make explicit.
12943 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12944
8d7bcccb
TT
129452019-01-10 Tom Tromey <tom@tromey.com>
12946
12947 * objfiles.h (objfile::reset_psymtabs): Update.
12948 * objfiles.c (objfile::objfile): Update.
12949 * psymtab.h (psymtab_storage::obstack): Update.
12950 (psymtab_storage::m_obstack): Use gdb::optional.
12951 (class psymtab_storage): Update comment. Remove objfile
12952 parameter.
12953 * psymtab.c (psymtab_storage::psymtab_storage): Update.
12954
b596a3c7
TT
129552019-01-10 Tom Tromey <tom@tromey.com>
12956
12957 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12958 <free_psymtabs>: Now private.
12959 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12960 (allocate_psymtab): Use new method.
12961
a9342b62
TT
129622019-01-10 Tom Tromey <tom@tromey.com>
12963
12964 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12965 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12966 * mdebugread.c (parse_partial_symbols): Use
12967 allocate_dependencies.
12968 * dwarf2read.c (dwarf2_create_include_psymtab): Use
12969 allocate_dependencies.
12970 (process_psymtab_comp_unit_reader)
12971 (build_type_psymtab_dependencies): Likewise.
12972 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12973
5af70966
TT
129742019-01-10 Tom Tromey <tom@tromey.com>
12975
12976 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12977 PSYMBOL_SET_LANGUAGE.
12978 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12979
5923a04c
TT
129802019-01-10 Tom Tromey <tom@tromey.com>
12981
12982 * psymtab.h (psymtab_storage::obstack): New method.
12983 <m_obstack>: Rename from obstack; now private.
12984 * psymtab.c (psymtab_storage): Update.
12985 * dwarf2read.c (create_addrmap_from_index)
12986 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12987 Update.
12988
6d6a12bf
TT
129892019-01-10 Tom Tromey <tom@tromey.com>
12990
12991 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12992 * objfiles.h (objfile::reset_psymtabs): New method.
12993
d320c2b5
TT
129942019-01-10 Tom Tromey <tom@tromey.com>
12995
12996 * symmisc.c (print_symbol_bcache_statistics): Update.
12997 (print_objfile_statistics): Update.
12998 * symfile.c (reread_symbols): Update.
12999 * psymtab.h (class psymtab_storage): New.
13000 * psymtab.c (psymtab_storage): New constructor.
13001 (~psymtab_storage): New destructor.
13002 (require_partial_symbols): Update.
13003 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13004 (find_pc_sect_psymtab, find_pc_sect_psymbol)
13005 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13006 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13007 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13008 (start_psymtab_common, end_psymtab_common)
13009 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13010 (allocate_psymtab): Update.
13011 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13012 Update.
13013 (dump_psymtab_addrmap, maintenance_print_psymbols)
13014 (maintenance_check_psymtabs): Update.
13015 (class objfile_psymtabs): Move to objfiles.h.
13016 * psympriv.h (discard_psymtab): Now inline.
13017 (psymtab_discarder::psymtab_discarder): Update.
13018 (psymtab_discarder::~psymtab_discarder): Update.
13019 (ALL_OBJFILE_PSYMTABS): Rewrite.
13020 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13021 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13022 Remove fields.
13023 <partial_symtabs>: New field.
13024 (class objfile_psymtabs): Move from psymtab.h. Update.
13025 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13026 psymbol_cache.
13027 (objfile::~objfile): Don't destroy psymbol_cache.
13028 * mdebugread.c (parse_partial_symbols): Update.
13029 * dwarf2read.c (create_addrmap_from_index)
13030 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13031 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13032 (add_partial_subprogram, dwarf2_ranges_read): Update.
13033 * dwarf-index-write.c (write_address_map)
13034 (write_one_signatured_type, recursively_write_psymbols)
13035 (class debug_names, class debug_names, write_psymtabs_to_index):
13036 Update.
13037
1d94a5a3
TT
130382019-01-10 Tom Tromey <tom@tromey.com>
13039
13040 * symtab.h (SYMBOL_SET_NAMES): Update.
13041 (symbol_set_names): Update.
13042 (MSYMBOL_SET_NAMES): Update.
13043 * symtab.c (symbol_set_names): Change argument to be an
13044 objfile_per_bfd_storage.
13045 * psymtab.c (add_psymbol_to_bcache): Update.
13046 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13047
0f14768a
TT
130482019-01-10 Tom Tromey <tom@tromey.com>
13049
13050 * symtab.c (create_demangled_names_hash): Change argument to be an
13051 objfile_per_bfd_storage.
13052 (symbol_set_names): Update.
13053
6eee24ce
TT
130542019-01-10 Tom Tromey <tom@tromey.com>
13055
13056 * xcoffread.c (xcoff_initial_scan): Unconditionally call
13057 init_psymbol_list.
13058 * psymtab.c (init_psymbol_list): Do nothing if already called.
13059 * psympriv.h (init_psymbol_list): Add comment.
13060 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13061 init_psymbol_list.
13062 * dbxread.c (dbx_symfile_read): Unconditionally call
13063 init_psymbol_list.
13064
75aedd27
TT
130652019-01-10 Tom Tromey <tom@tromey.com>
13066
13067 * xcoffread.c (scan_xcoff_symtab): Update.
13068 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13069 "where".
13070 * mdebugread.c (parse_partial_symbols)
13071 (handle_psymbol_enumerators): Update.
13072 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13073 * dbxread.c (read_dbx_symtab): Update.
13074 * psympriv.h (psymbol_placement): New enum.
13075 (add_psymbol_to_list): Update.
13076
939652a5
TT
130772019-01-10 Tom Tromey <tom@tromey.com>
13078
13079 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13080 static_psymbols parameters.
13081 (scan_xcoff_symtab): Update.
13082 * psymtab.c (start_psymtab_common): Remove global_psymbols and
13083 static_psymbols parameters.
13084 * psympriv.h (start_psymtab_common): Update.
13085 * mdebugread.c (parse_partial_symbols): Update.
13086 * dwarf2read.c (create_partial_symtab): Update.
13087 * dbxread.c (read_dbx_symtab): Update.
13088 (start_psymtab): Remove global_psymbols and static_psymbols
13089 parameters.
13090
baa62830
TT
130912019-01-10 Tom Tromey <tom@tromey.com>
13092
13093 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13094 * psymtab.c (allocate_psymtab): Add comment.
13095 * psympriv.h (allocate_psymtab): Add comment.
13096 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13097 initializations.
13098 * dbxread.c (dbx_end_psymtab): Remove some initializations.
13099
0e8f53ba
TT
131002019-01-10 Tom Tromey <tom@tromey.com>
13101
13102 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13103 Don't declare.
13104 * mipsread.c: Include mdebugread.h.
13105 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13106 Declare.
13107 * elfread.c: Include mdebugread.h.
13108
b22a7c6a
TT
131092019-01-09 Tom Tromey <tom@tromey.com>
13110
13111 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13112 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13113 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13114 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13115 (psym_lookup_symbol, psym_find_last_source_symtab)
13116 (psym_forget_cached_source_info, psym_print_stats)
13117 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13118 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13119 (psym_map_matching_symbols, psym_expand_symtabs_matching)
13120 (psym_find_compunit_symtab_by_address)
13121 (maintenance_print_psymbols, maintenance_info_psymtabs)
13122 (maintenance_check_psymtabs): Use ranged for.
13123 * psymtab.h (class objfile_psymtabs): New.
13124 (require_partial_symbols): Return objfile_psymtabs.
13125 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13126
3b9d3ac2
TT
131272019-01-09 Tom Tromey <tom@tromey.com>
13128
13129 * symfile.c (overlay_invalidate_all, find_pc_overlay)
13130 (find_pc_mapped_section, list_overlays_command)
13131 (map_overlay_command, unmap_overlay_command)
13132 (simple_overlay_update): Use all_objfiles.
13133 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13134 * printcmd.c (info_symbol_command): Use all_objfiles.
13135 * objfiles.h (ALL_OBJSECTIONS): Remove.
13136 * maint.c (maintenance_translate_address): Use all_objfiles.
13137 * gcore.c (gcore_create_callback): Use all_objfiles.
13138 (objfile_find_memory_regions): Likewise.
13139
8b31193a
TT
131402019-01-09 Tom Tromey <tom@tromey.com>
13141
13142 * symtab.c (find_line_symtab, info_sources_command)
13143 (make_source_files_completion_list): Use objfile_compunits.
13144 * source.c (select_source_symtab): Use objfile_compunits.
13145 * objfiles.h (struct objfile): Update comment.
13146 (ALL_OBJFILES): Remove.
13147 (ALL_FILETABS): Remove.
13148 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13149 objfile_compunits.
13150
d5da8b3c
TT
131512019-01-09 Tom Tromey <tom@tromey.com>
13152
13153 * symmisc.c (print_objfile_statistics, dump_objfile)
13154 (maintenance_print_symbols): Use compunit_filetabs.
13155 * source.c (forget_cached_source_info_for_objfile): Use
13156 compunit_filetabs.
13157 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13158 (ALL_FILETABS): Use compunit_filetabs.
13159 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13160 * coffread.c (coff_symtab_read): Use compunit_filetabs.
13161
5accd1a0
TT
131622019-01-09 Tom Tromey <tom@tromey.com>
13163
13164 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13165 (compunit_filetabs): New.
13166 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13167 compunit_filetabs.
13168 (info_sources_command, make_source_files_completion_list): Remove
13169 declaration.
13170 * symmisc.c (print_objfile_statistics, dump_objfile)
13171 (maintenance_print_symbols): Remove declaration.
13172 (maintenance_info_symtabs): Use compunit_filetabs.
13173 (maintenance_info_line_tables): Likewise.
13174 * source.c (select_source_symtab): Change local variable name.
13175 (forget_cached_source_info_for_objfile): Remove declaration.
13176 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13177 * objfiles.c (objfile_relocate1): Remove declaration.
13178 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13179 declaration.
13180 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13181 * coffread.c (coff_symtab_read): Remove declaration.
13182 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13183 compunit_filetabs.
13184
d8aeb77f
TT
131852019-01-09 Tom Tromey <tom@tromey.com>
13186
13187 * symtab.c (lookup_objfile_from_block)
13188 (find_pc_sect_compunit_symtab, search_symbols)
13189 (default_collect_symbol_completion_matches_break_on): Use
13190 objfile_compunits.
13191 * objfiles.h (ALL_COMPUNITS): Remove.
13192 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13193 * cp-support.c (add_symbol_overload_list_qualified): Use
13194 objfile_compunits.
13195 * ada-lang.c (ada_collect_symbol_completion_matches)
13196 (ada_add_global_exceptions): Use objfile_compunits.
13197
592553c4
TT
131982019-01-09 Tom Tromey <tom@tromey.com>
13199
13200 * source.c (select_source_symtab)
13201 (forget_cached_source_info_for_objfile): Remove declaration.
13202 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13203 declaration.
13204 * maint.c (count_symtabs_and_blocks): Remove declaration.
13205 * cp-support.c (add_symbol_overload_list_qualified): Remove
13206 declaration.
13207 * coffread.c (coff_symtab_read): Remove declaration.
13208 * symtab.c (lookup_symbol_in_objfile_symtabs)
13209 (basic_lookup_transparent_type_1): Use objfile_compunits.
13210 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13211 (info_sources_command, search_symbols)
13212 (default_collect_symbol_completion_matches_break_on)
13213 (make_source_files_completion_list): Remove declaration.
13214 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13215 (ada_collect_symbol_completion_matches)
13216 (ada_add_global_exceptions): Remove declaration.
13217 * linespec.c (iterate_over_all_matching_symtabs): Use
13218 objfile_compunits.
13219 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13220 (class objfile_compunits): New.
13221 (ALL_COMPUNITS): Use objfile_compunits.
13222 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13223 (maintenance_check_symtabs, maintenance_info_line_tables): Use
13224 objfile_compunits.
13225 * objfiles.c (objfile_relocate1): Use objfile_compunits.
13226
5325b9bf
TT
132272019-01-09 Tom Tromey <tom@tromey.com>
13228
13229 * symtab.c (search_symbols)
13230 (default_collect_symbol_completion_matches_break_on): Use
13231 objfile_msymbols.
13232 * ada-lang.c (ada_lookup_simple_minsym)
13233 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13234 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13235 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13236 objfile_msymbols.
13237 * coffread.c (coff_symfile_read): Use objfile_msymbols.
13238 * symmisc.c (dump_msymbols): Use objfile_msymbols.
13239 * objc-lang.c (find_methods): Use objfile_msymbols.
13240 (info_selectors_command, info_classes_command): Likewise.
13241 * stabsread.c (scan_file_globals): Use objfile_msymbols.
13242 * objfiles.h (class objfile_msymbols): New.
13243 (ALL_OBJFILE_MSYMBOLS): Remove.
13244 (ALL_MSYMBOLS): Remove.
13245
cac85af2
TT
132462019-01-09 Tom Tromey <tom@tromey.com>
13247
13248 * common/next-iterator.h (next_adapter): Add Iterator template
13249 parameter.
13250 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13251 (class all_objfiles_safe): New.
13252 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13253 * objfiles.c (put_objfile_before): Update comment.
13254 (add_separate_debug_objfile): Likewise.
13255 (free_all_objfiles): Use all_objfiles_safe.
13256 (objfile_purge_solibs): Likewise.
13257
aed57c53
TT
132582019-01-09 Tom Tromey <tom@tromey.com>
13259
13260 * symtab.c (iterate_over_symtabs, matching_obj_sections)
13261 (expand_symtab_containing_pc, lookup_static_symbol)
13262 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13263 (find_symbol_at_address, find_line_symtab, find_main_name): Use
13264 all_objfiles.
13265 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13266 * breakpoint.c (create_overlay_event_breakpoint)
13267 (create_longjmp_master_breakpoint)
13268 (create_std_terminate_master_breakpoint)
13269 (create_exception_master_breakpoint): Use all_objfiles.
13270 * linux-thread-db.c (try_thread_db_load_from_pdir)
13271 (has_libpthread): Use all_objfiles.
13272 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13273 * linespec.c (iterate_over_all_matching_symtabs)
13274 (search_minsyms_for_name): Use all_objfiles.
13275 * maint.c (maintenance_info_sections): Use all_objfiles.
13276 * main.c (captured_main_1): Use all_objfiles.
13277 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13278 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13279 * guile/scm-pretty-print.c
13280 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13281 * solib-spu.c (append_ocl_sos): Use all_objfiles.
13282 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13283 (maintenance_print_msymbols): Use all_objfiles.
13284 * source.c (select_source_symtab): Use all_objfiles.
13285 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13286 * symfile.c (remove_symbol_file_command)
13287 (expand_symtabs_matching, map_symbol_filenames): Use
13288 all_objfiles.
13289 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13290 all_objfiles.
13291 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13292 * objc-lang.c (find_methods): Use all_objfiles.
13293 * objfiles.c (have_partial_symbols, have_full_symbols)
13294 (have_minimal_symbols, qsort_cmp)
13295 (default_iterate_over_objfiles_in_search_order): Use
13296 all_objfiles.
13297 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13298 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13299 (maintenance_check_psymtabs): Use all_objfiles.
13300 (ALL_PSYMTABS): Remove.
13301 * compile/compile-object-run.c (do_module_cleanup): Use
13302 all_objfiles.
13303 * blockframe.c (find_pc_partial_function): Use all_objfiles.
13304 * cp-support.c (add_symbol_overload_list_qualified): Use
13305 all_objfiles.
13306 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13307 Use all_objfiles.
13308 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13309 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13310 all_objfiles.
13311 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13312 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13313 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13314 Uses all_objfiles.
13315 * solib.c (solib_read_symbols): Use all_objfiles
13316
99d89cde
TT
133172019-01-09 Tom Tromey <tom@tromey.com>
13318
13319 * probe.c (parse_probes_in_pspace): Use all_objfiles.
13320 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13321 all_objfiles.
13322 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13323 * symmisc.c (print_symbol_bcache_statistics)
13324 (print_objfile_statistics, maintenance_print_objfiles)
13325 (maintenance_info_symtabs, maintenance_check_symtabs)
13326 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13327 all_objfiles.
13328 * source.c (forget_cached_source_info): Use all_objfiles.
13329 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13330 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13331 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13332 * objfiles.c (update_section_map): Use all_objfiles.
13333 (shared_objfile_contains_address_p): Likewise.
13334 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13335 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13336
21708325
TT
133372019-01-09 Tom Tromey <tom@tromey.com>
13338
13339 * common/next-iterator.h: New file.
13340 * objfiles.h (class all_objfiles): New.
13341 (struct objfile_iterator): New.
13342
669e09f6
PW
133432019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13344
13345 * NEWS: Move the description of the changed "frame", "select-frame",
13346 and "info frame" commands to the Changed commands section.
13347
041be526
SM
133482019-01-09 Simon Marchi <simon.marchi@ericsson.com>
13349
13350 * gdbtypes.c (check_stub_method_group): Remove handling of old
13351 mangling schemes.
13352 * linespec.c (find_methods): Likewise.
13353 * stabsread.c (read_member_functions): Likewise.
13354 * valops.c (search_struct_method): Likewise.
13355 (value_struct_elt_for_reference): Likewise.
13356 * NEWS: Mention this change.
13357
0e2a2133
AB
133582019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
13359
13360 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13361 print_source_lines.
13362 * source.c (print_source_lines_base): Update line number check.
13363 (print_source_lines): New function.
13364 (source_lines_range::source_lines_range): New function.
13365 * source.h (class source_lines_range): New class.
13366 (print_source_lines): New declaration.
13367
1055a3b4
PW
133682019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13369
13370 * linespec.c (linespec_state_destructor): Free self->canonical_names.
13371
cfeadda5
TT
133722019-01-08 Tom Tromey <tom@tromey.com>
13373 Simon Marchi <simon.marchi@ericsson.com>
13374
13375 PR gdb/24060
13376 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13377 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13378 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13379 * f-exp.y (DOLLAR_VARIABLE): Likewise.
13380 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13381 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13382
583068ca
AB
133832019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13384
13385 * source.c (select_source_symtab): Move header comment to
13386 declaration in source.h.
13387 (forget_cached_source_info_for_objfile): Likewise.
13388 (forget_cached_source_info): Likewise.
13389 (identify_source_line): Likewise.
13390 * source.h (identify_source_line): Move declaration from symtab.h
13391 and add comment from source.c
13392 (print_source_lines): Likewise.
13393 (forget_cached_source_info_for_objfile): Likewise.
13394 (forget_cached_source_info): Likewise.
13395 (select_source_symtab): Likewise.
13396 (enum print_source_lines_flag): Move definition from symtab.h.
13397 * symtab.h (identify_source_line): Move declaration to source.h.
13398 (print_source_lines): Likewise.
13399 (forget_cached_source_info_for_objfile): Likewise.
13400 (forget_cached_source_info): Likewise.
13401 (select_source_symtab): Likewise.
13402 (enum print_source_lines_flag): Move definition to source.h.
13403 * tui/tui-hooks.c: Add 'source.h' include.
13404
ec98a4ad
AB
134052019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13406
13407 * source.c (print_source_lines_base): Handle requests to print
13408 reverse line number sequences, and guard against empty lines
13409 string.
13410
62ea19c1
AB
134112019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
13412
13413 * source.c (print_source_lines_base): Fix skip of '\r' if next
13414 character is '\n'.
13415
9d30e1fd
TT
134162019-01-06 Tom Tromey <tom@tromey.com>
13417
13418 * c-exp.y (struct c_parse_state) <macro_original_text,
13419 expansion_obstack>: New member.
13420 (macro_original_text, expansion_obstack): Remove globals.
13421 (scan_macro_expansion, scanning_macro_expansion)
13422 (finished_macro_expansion): Update.
13423 (scan_macro_cleanup): Remove.
13424 (yylex, c_parse): Update.
13425
c65bac38
TT
134262019-01-06 Tom Tromey <tom@tromey.com>
13427
13428 * c-exp.y (struct c_parse_state) <strings>: New member.
13429 (operator_stoken): Update.
13430
02e12e38
TT
134312019-01-06 Tom Tromey <tom@tromey.com>
13432
13433 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
13434 (union type_stack_elt) <typelist_val>: Now a pointer to
13435 std::vector.
13436 (type_stack_cleanup): Don't declare.
13437 (push_typelist): Update.
13438 * parse.c (pop_typelist): Return a std::vector.
13439 (push_typelist): Take a std::vector.
13440 (follow_types): Update. Do not free args.
13441 (type_stack_cleanup): Remove.
13442 * c-exp.y (struct c_parse_state): New.
13443 (cpstate): New global.
13444 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13445 (nonempty_typelist): Update.
13446 (func_mod): Create a new vector.
13447 (c_parse): Create a c_parse_state.
13448 (check_parameter_typelist): Do not delete params.
13449 (function_method): Update. Do not delete type_list.
13450
f097f5ad
TT
134512019-01-06 Tom Tromey <tom@tromey.com>
13452
13453 PR gdb/28155:
13454 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13455 check_typedef.
13456 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13457 (print_return_value): Likewise.
13458
d2adf9f1
TT
134592019-01-05 Tom Tromey <tom@tromey.com>
13460
13461 * contrib/cleanup_check.py: Remove.
13462 * contrib/gcc-with-excheck: Remove.
13463 * contrib/exsummary.py: Remove.
13464 * contrib/excheck.py: Remove.
13465
2eab46b1
JB
134662019-01-05 Joel Brobecker <brobecker@adacore.com>
13467
13468 * thread.c (delete_thread_1): Add gdb_assert that THR is not
13469 NULL. Initialize tpprev to NULL instead of assigning it
13470 to NULL on the next statement.
13471 * windows-nat.c (windows_delete_thread): Remove check for
13472 main_thread_id before printing thread exit notifications.
13473 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13474 Remove thread ID check against main_thread_id.
13475 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13476 windows_delete_thread.
13477 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13478
48c5e7e2
TT
134792019-01-04 Tom Tromey <tom@tromey.com>
13480
13481 * compile/compile.c (_initialize_compile): Use upper case for
13482 metasyntactic variables.
13483 * symmisc.c (_initialize_symmisc): Use upper case for
13484 metasyntactic variables.
13485 * psymtab.c (_initialize_psymtab): Use upper case for
13486 metasyntactic variables.
13487 * demangle.c (demangle_command): Use upper case for metasyntactic
13488 variables.
13489 (_initialize_demangler): Likewise.
13490 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13491 variables.
13492
986041cd
TT
134932019-01-03 Tom Tromey <tom@tromey.com>
13494
13495 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13496
7c711119
TT
134972019-01-03 Tom Tromey <tom@tromey.com>
13498
13499 * python/py-symtab.c (salpy_str): Update.
13500 (struct salpy_sal_object) <symtab>: Now a PyObject.
13501 (salpy_dealloc): Update.
13502 (del_objfile_sal): Use gdbpy_ref.
13503
1b20edf0
TT
135042019-01-03 Tom Tromey <tom@tromey.com>
13505
13506 * python/py-type.c (convert_field): Use new_reference. Return
13507 gdbpy_ref.
13508 (make_fielditem): Return gdbpy_ref.
13509 (typy_fields): Update.
13510 (typy_getitem): Update.
13511 (field_name): Return gdbpy_ref. Use new_reference.
13512 (typy_iterator_iternext): Update.
13513
ea41325b
TT
135142019-01-03 Tom Tromey <tom@tromey.com>
13515
13516 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13517
2a3c71d6
TT
135182019-01-03 Tom Tromey <tom@tromey.com>
13519
13520 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13521 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13522 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13523 (pspy_set_frame_filters, pspy_set_frame_unwinders)
13524 (pspy_set_type_printers): Likewise.
13525 * python/py-function.c (fnpy_init): Use gdbpy_ref.
13526 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13527 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13528 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13529 (objfpy_set_type_printers): Likewise.
13530
5c329e6a
TT
135312019-01-03 Tom Tromey <tom@tromey.com>
13532
13533 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13534 (gdbpy_print_stack): Use gdbpy_err_fetch.
13535 * python/python-internal.h (class gdbpy_err_fetch): New class.
13536 (class gdbpy_enter) <m_error_type, m_error_value,
13537 m_error_traceback>: Remove.
13538 <m_error>: New member.
13539 (gdbpy_exception_to_string): Don't declare.
13540 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13541 * python/py-value.c (convert_value_from_python): Use
13542 gdbpy_err_fetch.
13543 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13544 gdbpy_exception_to_string.
13545 (gdbpy_handle_exception): Use gdbpy_err_fetch.
13546 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13547 gdbpy_err_fetch.
13548
169bb27b
AB
135492019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13550
13551 * linux-nat.c (delete_lwp_cleanup): Delete.
13552 (struct lwp_deleter): New struct.
13553 (lwp_info_up): New typedef.
13554 (linux_nat_target::follow_fork): Delete cleanup, and make use of
13555 lwp_info_up.
13556
a07c8880
AB
135572019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13558
13559 * linux-fork.c (class scoped_switch_fork_info): New class.
13560 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13561
26089c49
AB
135622019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13563
13564 * valops.c (find_overload_match): Remove use of null_cleanup, and
13565 calls to do_cleanups.
13566
06d3e5b0
AB
135672019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13568
13569 * compile/compile-cplus-types.c
13570 (compile_cplus_instance::decl_name): Handle changes to
13571 cp_func_name.
13572 * cp-support.c (cp_func_name): Update header comment, update
13573 return type.
13574 * cp-support.h (cp_func_name): Update return type in declaration.
13575 * valops.c (find_overload_match): Move temp_func local to top
13576 level of function and change its type. Use temp_func to hold and
13577 delete temporary string obtained from cp_func_name.
13578
66644cd3
AB
135792019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
13580
13581 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13582 gdb::char_vector, remove cleanup, and update uses of `msg`.
13583
592d8c0a
JW
135842019-01-03 Jim Wilson <jimw@sifive.com>
13585
13586 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13587
c55d06ec
TT
135882019-01-02 Tom Tromey <tom@tromey.com>
13589
13590 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13591 (tdesc_parse_xml): Remove cleanups.
13592 * target-descriptions.h (make_cleanup_free_target_description):
13593 Don't declare.
13594 (target_desc_deleter): New struct.
13595 (target_desc_up): New typedef.
13596 * target-descriptions.c (target_desc_deleter::operator()): Rename
13597 from free_target_description.
13598 (make_cleanup_free_target_description): Remove.
13599
3a6ae42d
TT
136002019-01-02 Tom Tromey <tom@tromey.com>
13601
13602 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
13603 constructor, destructor.
13604 (linespec_parser): Remove typedef.
13605 (~linespec_parser): Rename from linespec_parser_delete.
13606 (linespec_lex_to_end, linespec_complete_label)
13607 (linespec_complete): Update.
13608 (decode_line_full): Remove cleanups.
13609 (decode_line_1): Update.
13610
61fd3e73
TT
136112019-01-02 Tom Tromey <tom@tromey.com>
13612
13613 * python/python-internal.h (inferior_to_inferior_object): Change
13614 return type.
13615 * python/py-exitedevent.c (create_exited_event_object): Update.
13616 * python/py-inferior.c (inferior_to_inferior_object): Return
13617 gdbpy_ref.
13618 (python_new_inferior, python_inferior_deleted)
13619 (thread_to_thread_object, delete_thread_object)
13620 (build_inferior_list, gdbpy_selected_inferior): Update.
13621 * python/py-infthread.c (create_thread_object): Update. Also fail
13622 if inferior_to_inferior_object fails.
13623
d20172fc
SM
136242019-01-02 Simon Marchi <simon.marchi@ericsson.com>
13625
13626 * inferior.h (class inferior) <displaced_step_state>: New field.
13627 * infrun.h (struct displaced_step_state): Move here from
13628 infrun.c. Initialize fields, add constructor.
13629 <inf>: Remove field.
13630 <reset>: New method.
13631 * infrun.c (struct displaced_step_inferior_state): Move to
13632 infrun.h.
13633 (displaced_step_inferior_states): Remove.
13634 (get_displaced_stepping_state): Adust.
13635 (displaced_step_in_progress_any_inferior): Adjust.
13636 (displaced_step_in_progress_thread): Adjust.
13637 (displaced_step_in_progress): Adjust.
13638 (add_displaced_stepping_state): Remove.
13639 (get_displaced_step_closure_by_addr): Adjust.
13640 (remove_displaced_stepping_state): Remove.
13641 (infrun_inferior_exit): Call displaced_step_state.reset.
13642 (use_displaced_stepping): Don't check for NULL.
13643 (displaced_step_prepare_throw): Call
13644 get_displaced_stepping_state.
13645 (displaced_step_fixup): Don't check for NULL.
13646 (prepare_for_detach): Don't check for NULL.
13647
e3319240
PW
136482019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13649
13650 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13651 in case of call that did not complete.
13652
5d36dfb9
AU
136532019-01-02 Andrey Utkin <autkin@undo.io>
13654
13655 * symfile.c (find_separate_debug_file): Fix search of debug files for
13656 remote debuggee.
13657
8833fbf0
TT
136582019-01-02 Tom Tromey <tom@tromey.com>
13659
13660 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13661 indentation.
13662 * python/py-frame.c (frapy_older): Remove cast.
13663 (frapy_newer): Likewise.
13664 * python/py-breakpoint.c (local_setattro): Remove cast.
13665 * python/py-arch.c (archpy_name): Remove local variable.
13666 * python/py-type.c (gdbpy_lookup_type): Remove cast.
13667
4ada3dfd
JB
136682019-01-02 Joel Brobecker <brobecker@adacore.com>
13669
13670 * unittests/basic_string_view/element_access/char/empty.cc:
13671 Fix year range in copyright header.
13672
113b7b81
AB
136732019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
13674
13675 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13676 Delete.
13677 <operator==>: Update with for removed field.
13678 <hash>: Likewise.
13679 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13680 <isa_features>: ...this.
13681 <abi_features>: New field.
13682 (riscv_isa_flen): Update comment.
13683 (riscv_abi_xlen): New declaration.
13684 (riscv_abi_flen): New declaration.
13685 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13686 isa_features.
13687 (riscv_abi_xlen): New function.
13688 (riscv_isa_flen): Update to get answer from isa_features.
13689 (riscv_abi_flen): New function.
13690 (riscv_has_fp_abi): Update to get answer from abi_features.
13691 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13692 xlen and flen.
13693 (riscv_call_info) <xlen, flen>: Update comment.
13694 (riscv_call_arg_struct): Remove invalid assertions
13695 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13696 is removed.
13697 (riscv_gdbarch_init): Gather isa features and abi features
13698 separately, ensure both match on the gdbarch when reusing an old
13699 gdbarch. Relax an error check to allow 32-bit abi float to run on
13700 a target with 64-bit float hardware.
13701
b18ca514
PW
137022019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13703
13704 * source.c (search_command_helper): Stop reverse search
13705 when line 1 has been searched.
13706
ec70d8db
PW
137072019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13708
13709 * record-full.c (record_full_base_target::close): Rewrite
13710 record_full_core_buf_list free logic.
13711
5b38f9c1
PW
137122019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13713
13714 * break-catch-syscall.c (print_one_catch_syscall): xfree
13715 the last text.
13716
66d91b39
JB
137172019-01-01 Joel Brobecker <brobecker@adacore.com>
13718
13719 * top.c (print_gdb_version): Update Copyright year in version
13720 message.
13721
42a4f53d
JB
137222019-01-01 Joel Brobecker <brobecker@adacore.com>
13723
13724 Update copyright year range in all GDB files.
13725
7e955d83 137262019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 13727
5bbd631d 13728 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 13729
5bbd631d 13730For older changes see ChangeLog-2018.
c906108c
SS
13731\f
13732Local Variables:
13733mode: change-log
13734left-margin: 8
13735fill-column: 74
13736version-control: never
57da7796 13737coding: utf-8
c906108c 13738End:
5bbd631d 13739
This page took 3.84513 seconds and 4 git commands to generate.