projects / deliverable / binutils-gdb.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
Revert basenames_may_differ patch
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
76f5096c
TT		 12020-02-07 Tom Tromey <tromey@adacore.com>
2
3 PR breakpoints/24915:
4 * source.c (find_and_open_source): Do not check basenames_may_differ.
5
975292a9
CB		 62020-01-10 Christian Biesinger <cbiesinger@google.com>
7
8 * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
9
3c473fad
TT		 102020-01-07 Tom Tromey <tromey@adacore.com>
11
12 PR build/24937:
13 * stap-probe.c (class stap_static_probe_ops): Add constructor.
14
f7da8e5b
AB		 152020-01-06 Andrew Burgess <andrew.burgess@embecosm.com>
16
17 * stack.c (print_frame_info): Move disassemble_next_line code
18 inside source_print block.
19
b8e46eb9
JB		 202020-01-01 Joel Brobecker <brobecker@adacore.com>
21
22 * gdbarch.sh: Update copyright year range of generated files.
23
11bc5fe4
JB		 242020-01-01 Joel Brobecker <brobecker@adacore.com>
25
26 Update copyright year range in all the GDB files automatically
27 handled by our copyright.py script.
28
8b371634
JB		 292020-01-01 Joel Brobecker <brobecker@adacore.com>
30
31 * copyright.py: Convert to Python 3.
32
a292f79f
JB		 332020-01-01 Joel Brobecker <brobecker@adacore.com>
34
35 * copyright.py: Adapt after move of gnulib directory from gdb
36 directory to toplevel directory.
37
1458b0f3
JB		 382020-01-01 Joel Brobecker <brobecker@adacore.com>
39
40 * copyright.py (main): Exit if run from the wrong directory.
41
e9de78be
JB		 422020-01-01 Joel Brobecker <brobecker@adacore.com>
43
44 * top.c (print_gdb_version): Change copyright year to 2020.
45
c0716f3e
CB		 462019-12-26 Christian Biesinger <cbiesinger@google.com>
47
48 * configure: Regenerate.
49 * configure.ac: Quote variable arguments of test.
50 * gdbsupport/common.m4: Likewise.
51
527178f7
EZ		 522019-12-21 Eli Zaretskii <eliz@gnu.org>
53
54 * top.c (print_gdb_configuration): Print "--with-xxhash" or
55 "--without-xxhash" according to HAVE_LIBXXHASH.
56
4ae7258e
TT		 572019-12-18 Tom Tromey <tromey@adacore.com>
58
59 PR build/25268:
60 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
61 type on macOS. Add comment.
62
1c66314d
TT		 632019-12-18 Tom Tromey <tromey@adacore.com>
64
65 PR build/25250:
66 * ui-out.c (ui_out::vmessage): Update.
67 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
68 Rename.
69 (string_field): Update.
70 (signed_field): Update.
71
be19b699
SM		 722019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
73
74 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
75
3f434671
JB		 762019-12-11 Joel Brobecker <brobecker@adacore.com>
77
78 * version.in: Set GDB version number to 9.0.90.DATE-git.
79
07d5aa38
JB		 802019-12-11 Joel Brobecker <brobecker@adacore.com>
81
82 GDB 9.0.90 released.
83
b06b5486
JB		 842019-12-11 Joel Brobecker <brobecker@adacore.com>
85
86 * version.in: Set GDB version number to 9.0.90.
87
41ec388b
JB		 882019-12-11 Joel Brobecker <brobecker@adacore.com>
89
90 * NEWS: Change "Changes since GDB 8.3" into "Changes in GDB 9".
91
c87abc50
JB		 922019-12-11 Joel Brobecker <brobecker@adacore.com>
93
94 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
95 * version.in: Bump version to 9.0.90.DATE-git.
96
2e744276
TT		 972019-12-11 Tom Tromey <tromey@adacore.com>
98
99 PR build/25268:
100 * gdbsupport/thread-pool.c (set_thread_name): New function.
101 (thread_pool::set_thread_count): Don't call pthread_setname_np.
102 (thread_pool::thread_function): Call set_thread_name.
103
aac4760f
TT		 1042019-12-11 Tom Tromey <tromey@adacore.com>
105
106 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
107 bfd_get_signed_8.
108
d8edc8b7
PW		 1092019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
110
111 * NEWS: Document -raw-values option and the related setting commands.
112 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
113 only set it on when /r is given.
114 * valprint.c (value_print_option_defs): New element raw-values.
115 * Makefile.in: Add the new file.
116
cb511130
CB		 1172019-12-10 Christian Biesinger <cbiesinger@google.com>
118
119 * gdbsupport/safe-strerror.c: Supress the unused function warning
120 for select_strerror_r.
121
ab7d13f0
CB		 1222019-12-10 Christian Biesinger <cbiesinger@google.com>
123
124 * config.in: Regenerate.
125 * configure: Regenerate.
126 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
127 safe_strerror instead of strerror.
128 * gdbsupport/common.m4: Don't check for strerror.
129 * gdbsupport/safe-strerror.c: Support both the glibc version
130 of strerror_r and the XSI version.
131
6c71eb7d
TT		 1322019-12-10 Tom Tromey <tromey@adacore.com>
133
134 * ada-typeprint.c (print_choices): Use a single "?".
135 (print_variant_part): Print "?" if the discriminant name
136 is not known.
137
bac7c5cf
GB		 1382019-12-10 George Barrett <bob@bob131.so>
139
140 Fix scripted probe breakpoints.
141 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
142 declaration forward.
143 (breakpoint_ops_for_event_location_type)
144 (breakpoint_ops_for_event_location): Add function definitions.
145 (break_command_1, trace_command): Use
146 breakpoint_ops_for_event_location.
147 * breakpoint.h (breakpoint_ops_for_event_location): Add function
148 declarations.
149 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
150 breakpoint_ops_for_event_location.
151 * python/py-breakpoint.c (bppy_init): Use
152 breakpoint_ops_for_event_location.
153
330f1d38
TBA		 1542019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
155
156 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
157 when ranking an lvalue argument for an rvalue parameter.
158
b1f0c0b9
WA		 1592019-12-08 Wataru Ashihara <wataash@wataash.com>
160
161 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
162 template argument for scoped_restore_tmpl from bool to int.
163
aa2d5a42
KS		 1642019-12-07 Keith Seitz <keiths@redhat.com>
165
166 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
167 (build_id_to_debug_bfd): Make static, rewriting to use
168 build_id_to_bfd_suffix.
169 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
170 adding `suffix' parameter. Append SUFFIX to file names
171 when searching for matching files.
172 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
173 (build_id_to_exec_bfd): Likewise.
174 * build-id.h (build_id_to_debug_bfd): Clarify that function
175 searches for BFD of debug info file.
176 (build_id_to_exec_bfd): Declare.
177 * corelow.c: Include build-id.h.
178 (locate_exec_from_corefile_build_id): New function.
179 (core_target_open): If no executable BFD is found,
180 search for a core file BFD using build-id.
181
dfb65191
CB		 1822019-12-06 Christian Biesinger <cbiesinger@google.com>
183
184 * bcache.c: Put in namespace gdb.
185 * bcache.h: Likewise.
186 * gdbtypes.c (check_types_worklist): Update.
187 (types_deeply_equal): Update.
188 * macrotab.c (struct macro_table) <bcache>: Update.
189 (new_macro_table): Update.
190 * macrotab.h (struct bcache): Put this forward declaration
191 inside namespace gdb.
192 (new_macro_table): Update.
193 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
194 Update.
195 <macro_cache>: Update.
196 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
197
93e55f0a
TV		 1982019-12-06 Tom de Vries <tdevries@suse.de>
199
200 PR symtab/24971
201 * block.c (best_symbol, better_symbol): New function.
202 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
203 decl.
204
06acc08f
TBA		 2052019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
206
207 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
208 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
209 for ranking see-through reference cases.
210
e0fad1ea
PW		 2112019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
212 * stack.c (faas_command): Check a command is provided.
213 * thread.c (taas_command, tfaas_command): Likewise.
214
908641f5
PW		 2152019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
216 * inferior.c (prune_inferiors): Only call delete_inferior,
217 Do not modify the inferior list.
218
b858499d
SM		 2192019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
220
221 * c-exp.y: Update calls to lookup_typename,
222 lookup_signed_typename and lookup_unsigned_typename.
223 * c-lang.c (evaluate_subexp_c): Likewise.
224 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
225 Likewise.
226 * eval.c (binop_promote): Likewise.
227 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
228 (lookup_unsigned_typename): Likewise.
229 (lookup_signed_typename): Likewise.
230 * gdbtypes.h (lookup_unsigned_typename): Likewise.
231 (lookup_signed_typename): Likewise.
232 (lookup_typename): Likewise.
233 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
234 lookup_typename, lookup_signed_typename,
235 lookup_unsigned_typename.
236 * m2-exp.y: Likewise.
237 * printcmd.c (printf_wide_c_string): Likewise.
238 (ui_printf): Likewise.
239 * python/py-type.c (typy_lookup_typename): Likewise.
240 * python/py-xmethods.c (python_xmethod_worker::invoke):
241 Likewise.
242 * rust-exp.y: Likewise.
243
3a8fa228
CB		 2442019-12-04 Christian Biesinger <cbiesinger@google.com>
245
246 * configure.nat (obsd64): Add missing files x86-nat.o and
247 nat/x86-dregs.o.
248
2dbc041e
TT		 2492019-12-04 Tom Tromey <tom@tromey.com>
250
251 * valprint.c (val_print_string): Use metadata_style.
252 * go-valprint.c (print_go_string): Use metadata style.
253 * p-valprint.c (pascal_object_print_static_field): Use metadata
254 style.
255 * cp-valprint.c (cp_print_static_field): Use metadata style.
256
36c8fb93
AB		 2572019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
258 Chris January <chris.january@arm.com>
259
260 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
261 tokens.
262 (typebase): New patterns for complex, single/double precision, and
263 single/double complex.
264 (f77_keywords): Change token for complex keyword, and add single,
265 double, and precision keywords.
266
c6170c2c
SM		 2672019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
268
269 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
270 "info io_registers".
271
894ecaf4
SM		 2722019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
273
274 * regcache.c (cooked_read_test): Initialize thread list of
275 mock_inferior.
276
be155ebb
SM		 2772019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
278
279 * aarch64-linux-tdep.c: Remove includes.
280
c577cdd7
SM		 2812019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
282
283 * aarch64-tdep.c: Remove includes.
284
610cfd61
SM		 2852019-12-04 Simon Marchi <simon.marchi@efficios.com>
286
287 * filtered-iterator.h (filtered_iterator) <operator==,
288 operator!=>: Compare wrapped iterators, not wrapped pointers.
289 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
290 unittests/filtered_iterator-selftests.c.
291 * unittests/filtered_iterator-selftests.c: New file.
292
a05cf17a
TT		 2932019-12-04 Tom Tromey <tromey@adacore.com>
294
295 * gdbtypes.c (create_range_type): Inherit endianity
296 from base type.
297
d5a22e77
TT		 2982019-12-04 Tom Tromey <tromey@adacore.com>
299
300 * ada-lang.c (decode_constrained_packed_array)
301 (ada_value_assign, value_assign_to_component): Update.
302 * dwarf2loc.c (rw_pieced_value, access_memory)
303 (dwarf2_compile_expr_to_ax): Update.
304 * dwarf2read.c (dwarf2_add_field): Update.
305 * eval.c (evaluate_subexp_standard): Update.
306 * gdbarch.c, gdbarch.h: Rebuild.
307 * gdbarch.sh (bits_big_endian): Remove.
308 * gdbtypes.h (union field_location): Update comment.
309 * target-descriptions.c (make_gdb_type): Update.
310 * valarith.c (value_bit_index): Update.
311 * value.c (struct value) <bitpos>: Update comment.
312 (unpack_bits_as_long, modify_field): Update.
313 * value.h (value_bitpos): Update comment.
314
7ab4a236
TT		 3152019-12-04 Tom Tromey <tromey@adacore.com>
316
317 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
318 endian-ness.
319
103a685e
TT		 3202019-12-04 Tom Tromey <tromey@adacore.com>
321
322 * dwarf2read.c (dwarf2_init_float_type)
323 (dwarf2_init_complex_target_type): Add byte_order parameter.
324 (read_base_type): Compute byte order earlier.
325 * gdbtypes.c (init_float_type): Add byte_order parameter.
326 * gdbtypes.h (init_float_type): Add byte_order parameter.
327
7a9e9f9f
TT		 3282019-12-04 Tom Tromey <tromey@adacore.com>
329
330 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
331
feee869b
TT		 3322019-12-04 Tom Tromey <tromey@adacore.com>
333
334 * dwarf2read.c (process_structure_scope): Initialize
335 "discr_offset".
336
c2512106
AB		 3372019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
338
339 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
340 add it into the search spec.
341 (parse_max_results_option): New function.
342 (mi_info_functions_or_variables): Parse -max-results flag and pass
343 it to mi_symbol_info.
344 (mi_cmd_symbol_info_modules): Likewise.
345 (mi_cmd_symbol_info_types): Likewise.
346 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
347 return type to bool, change result container into a set, and don't
348 add new results if we have enough already.
349 (global_symbol_searcher::add_matching_msymbols): Change return
350 type to bool, and don't add new results if we have enough already.
351 (sort_search_symbols_remove_dups): Delete.
352 (global_symbol_searcher::search): Early exit from search loop when
353 we have enough results. Use a std::set to collect the results
354 from calling add_matching_symbols.
355 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
356 member function.
357 (global_symbol_searcher) <m_max_search_results>: New member
358 variable.
359 (global_symbol_searcher) <add_matching_symbols>: Update header
360 comment and change return type to bool.
361 (global_symbol_searcher) <add_matching_msymbols>: Update header
362 comment and change return type to bool.
363
f97a63c5
AB		 3642019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
365
366 * symtab.c (symbol_search::compare_search_syms): Update header
367 comment.
368 (global_symbol_searcher::is_suitable_msymbol): New function.
369 (global_symbol_searcher::expand_symtabs): New function.
370 (global_symbol_searcher::add_matching_symbols): New function.
371 (global_symbol_searcher::add_matching_msymbols): New function.
372 (global_symbol_searcher::search): Move most of the content
373 into the new functions above, and call them as needed.
374 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
375 function.
376 (global_symbol_searcher) <add_matching_symbols>: New member
377 function.
378 (global_symbol_searcher) <add_matching_msymbols>: New member
379 function.
380 (global_symbol_searcher) <is_suitable_msymbol>: New member
381 function.
382
293b38d6
AB		 3832019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
384
385 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
386 -symbol-info-module-variables entries.
387 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
388 (mi_cmd_symbol_info_module_variables): Declare.
389 * mi/mi-symbol-cmds.c
390 (module_symbol_search_iterator): New typedef.
391 (output_module_symbols_in_single_module_and_file): New function.
392 (output_module_symbols_in_single_module): New function.
393 (mi_info_module_functions_or_variables): New function.
394 (mi_cmd_symbol_info_module_functions): New function.
395 (mi_cmd_symbol_info_module_variables): New function.
396 * NEWS: Mention new MI command.
397
4cbd39b2
CB		 3982019-12-03 Christian Biesinger <cbiesinger@google.com>
399
400 * bcache.c (hash): Remove.
401 (hash_continue): Remove.
402 * bcache.h (hash): Remove.
403 (hash_continue): Remove.
404 (struct bcache) <ctor>: Update.
405 * psymtab.c (psymbol_hash): Update.
406 * stabsread.c (hashname): Update.
407 * utils.h (fast_hash): Add an argument for a start value,
408 defaulting to zero.
409
82f910ea
PW		 4102019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
411 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
412 (destroy_block_symbol_cache): New function.
413 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
414 (resize_symbol_cache): Likewise.
415
de2396d0
TT		 4162019-12-02 Tom Tromey <tom@tromey.com>
417
418 * unittests/tui-selftests.c (run_tests): Make conditional.
419 (_initialize_tui_selftest): Make conditional.
420
638d85bc
CB		 4212019-12-02 Christian Biesinger <cbiesinger@google.com>
422
423 * aix-thread.c (debug_aix_thread): Change type to bool.
424
7532a164
LM		 4252019-12-02 Luis Machado <luis.machado@linaro.org>
426
427 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
428
216a7e6b
AB		 4292019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
430
431 * dwarf2read.c (read_tag_string_type): Read the fields required to
432 make a dynamic string, and possibly create a dynamic range for the
433 string.
434 (attr_to_dynamic_prop): Setup is_reference based on the type of
435 attribute being processed.
436 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
437 (resolve_dynamic_array): Rename to...
438 (resolve_dynamic_array_or_string): ...this, update header comment,
439 and accept TYPE_CODE_STRING.
440 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
441
11a8b164
AB		 4422019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
443
444 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
445 of its implementation from...
446 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
447 the new function.
448
5bbd8269
AB		 4492019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
450
451 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
452 create a range with stride where appropriate.
453 * f-valprint.c: Include 'gdbarch.h'.
454 (f77_print_array_1): Take the stride into account when walking the
455 array. Also convert the stride into addressable units.
456 * gdbtypes.c (create_range_type): Initialise the stride to
457 constant zero.
458 (create_range_type_with_stride): New function, initialise the
459 range as normal, and then setup the stride.
460 (has_static_range): Include the stride here. Also change the
461 return type to bool.
462 (create_array_type_with_stride): Consider the range stride if the
463 array isn't given its own stride.
464 (resolve_dynamic_range): Resolve the stride if needed.
465 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
466 (struct range_bounds) <flag_is_byte_stride>: New member variable.
467 (TYPE_BIT_STRIDE): Define.
468 (TYPE_ARRAY_BIT_STRIDE): Define.
469 (create_range_type_with_stride): Declare.
470 * valarith.c (value_subscripted_rvalue): Take range stride into
471 account when walking the array.
472
82e3b564
TT		 4732019-12-01 Tom Tromey <tom@tromey.com>
474
475 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
476 specially.
477
517d261d
TT		 4782019-12-01 Tom Tromey <tom@tromey.com>
479
480 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
481 \0.
482 * unittests/tui-selftests.c: New file.
483 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
484
484c9b64
TT		 4852019-12-01 Tom Tromey <tom@tromey.com>
486
487 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
488
a2a7af0c
TT		 4892019-12-01 Tom Tromey <tom@tromey.com>
490
491 * NEWS: Document new settings.
492 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
493 * tui/tui-win.c (_initialize_tui_win): Add border style
494 observers.
495 * tui/tui-io.h (tui_apply_style): Declare.
496 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
497 longer static.
498 (apply_ansi_escape, tui_set_reverse_mode): Update.
499 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
500 Add "skip_intensity" parameter.
501 <changed>: New member.
502 <do_set_value>: Declare.
503 (tui_border_style, tui_active_border_style): Declare.
504 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
505 globals.
506 (cli_style_option): Initialize "changed".
507 (cli_style_option::do_set_value): New function.
508 (cli_style_option::add_setshow_commands): Add "skip_intensity"
509 parameter. Update.
510 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
511 (_initialize_cli_style): Update. Create TUI border style
512 commands.
513
d1da6b01
TT		 5142019-12-01 Tom Tromey <tom@tromey.com>
515
516 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
517 parameter.
518 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
519 parameter.
520 * tui/tui-win.h (compact_source): Declare.
521 * tui/tui-win.c (compact_source): New global.
522 (tui_set_compact_source, tui_show_compact_source): New functions.
523 (_initialize_tui_win): Add "compact-source" setting.
524 * tui/tui-source.c (tui_source_window::set_contents): Handle
525 compact_source setting.
526 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
527 * NEWS: Document new setting.
528
489dbda6
TT		 5292019-11-30 Tom Tromey <tom@tromey.com>
530
531 * dwarf2read.c (dwarf2_add_field): Include field offset when
532 computing variant part length.
533
bf498525
PW		 5342019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
535 * NEWS: Mention define-prefix. Tell that command names can now
536 contain a . character.
537
be09caf1
PW		 5382019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
539
540 * command.h (valid_cmd_char_p): Declare.
541 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
542 the check of valid command char.
543 (find_command_name_length, valid_user_defined_cmd_name_p): Use
544 valid_cmd_char_p.
545 * cli/cli-script.c (validate_comname): Likewise.
546 * completer.c (gdb_completer_command_word_break_characters):
547 Do not remove . from the word break char, update comments.
548 (complete_line_internal_1): Use valid_cmd_char_p.
549 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
550 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
551
c6ac7fc9
PW		 5522019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
553
554 * cli/cli-script.c (do_define_command): Ensure a redefined
555 prefix command is kept as a prefix command.
556 (define_prefix_command): New function.
557 (show_user_1): Report user defined prefixes.
558 (_initialize_cli_script): Create the new 'define-prefix' command.
559 Add completers for 'define' and 'document'.
560 * top.c (execute_command): If command is a user-defined prefix only
561 command, report the list of commands for this prefix command.
562
a992a3b0
TBA		 5632019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
564
565 * valops.c (find_oload_champ): Improve debug output.
566
e9194a1a
TBA		 5672019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
568
569 * valops.c (find_oload_champ): Print part of debug messages
570 before the badness vector is std::move'd.
571
53a008a6
TT		 5722019-11-28 Tom Tromey <tom@tromey.com>
573
574 * value.c (creal_internal_fn): Fix comment.
575
bab05c83
TT		 5762019-11-28 Tom Tromey <tom@tromey.com>
577
578 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
579 flag_bound_evaluated>: Now unsigned.
580
2522f049
TT		 5812019-11-28 Tom Tromey <tom@tromey.com>
582
583 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
584 declare.
585
38b49e22
MS		 5862019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
587
588 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
589 debug output.
590 * jit.c (jit_unregister_code): Add debug print to match
591 `jit_register_code`.
592
35125921
CB		 5932019-11-27 Christian Biesinger <cbiesinger@google.com>
594
595 * NEWS: Mention the new multithreaded symbol loading.
596
62e77f56
CB		 5972019-11-27 Christian Biesinger <cbiesinger@google.com>
598
599 * maint.c (n_worker_threads): Default to 0.
600 (worker_threads_disabled): New function.
601 * maint.h (worker_threads_disabled): New function.
602 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
603 here if worker_threads_disabled () is true.
604 (minimal_symbol_reader::install): Skip all threading if
605 worker_threads_disabled () is true.
606
f29d7f6b
CB		 6072019-11-27 Christian Biesinger <cbiesinger@google.com>
608
609 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
610 hash code if possible.
611 (add_minsym_to_demangled_hash_table): Likewise.
612 (minimal_symbol_reader::install): Compute the hash codes for msymbol
613 on the background thread.
614 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
615 Add these fields.
616
e76b2246
CB		 6172019-11-27 Christian Biesinger <cbiesinger@google.com>
618
619 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
620 of the mangled name on the background thread.
621 * symtab.c (symbol_set_names): Allow passing in the hash of the
622 linkage_name.
623 * symtab.h (symbol_set_names): Likewise.
624
8d9a2568
KB		 6252019-11-27 Kevin Buettner <kevinb@redhat.com>
626
627 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
628 physnames are computed for inherited DIEs.
629
fad03f6e
TT		 6302019-11-27 Tom Tromey <tromey@adacore.com>
631
632 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
633 backslashes.
634 * cp-support.c: Remove unnecessary backslashes.
635
43678b0a
CB		 6362019-11-27 Christian Biesinger <cbiesinger@google.com>
637
638 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
639 with sym->set_linkage_name.
640 * coffread.c (coff_read_enum_type): Likewise.
641 * mdebugread.c (parse_symbol): Likewise.
642 * stabsread.c (patch_block_stabs): Likewise.
643 (define_symbol): Likewise.
644 (read_enum_type): Likewise.
645 (common_block_end): Likewise.
646 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
647 function.
648 (SYMBOL_SET_LINKAGE_NAME): Remove.
649 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
650 with sym->set_linkage_name.
651
db5960b4
AB		 6522019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
653
654 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
655 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
656 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
657 * NEWS: Mention new MI command.
658
7dc42066
AB		 6592019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
660
661 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
662 '-symbol-info-types', and '-symbol-info-variables'.
663 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
664 (mi_cmd_symbol_info_types): Declare.
665 (mi_cmd_symbol_info_variables): Declare.
666 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
667 (output_debug_symbol): New function.
668 (output_nondebug_symbol): New function.
669 (mi_symbol_info): New function.
670 (mi_info_functions_or_variables): New function.
671 (mi_cmd_symbol_info_functions): New function.
672 (mi_cmd_symbol_info_types): New function.
673 (mi_cmd_symbol_info_variables): New function.
674 * NEWS: Mention new commands.
675
5f512a7d
AB		 6762019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
677
678 * symtab.c (symbol_to_info_string): New function, most content
679 moved from print_symbol_info, but updated to return a std::string.
680 (print_symbol_info): Update to use symbol_to_info_string and print
681 returned string.
682 * symtab.h (symbol_to_info_string): Declare new function.
683
470c0b1c
AB		 6842019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
685
686 * python/python.c (gdbpy_rbreak): Convert to using
687 global_symbol_searcher.
688 * symtab.c (file_matches): Convert return type to bool, change
689 file list to std::vector, update header comment.
690 (search_symbols): Rename to...
691 (global_symbol_searcher::search): ...this and update now its
692 a member function of global_symbol_searcher. Take account of the
693 changes to file_matches.
694 (symtab_symbol_info): Convert to using global_symbol_searcher.
695 (rbreak_command): Likewise.
696 (search_module_symbols): Likewise.
697 * symtab.h (enum symbol_search): Update comment.
698 (search_symbols): Remove declaration.
699 (class global_symbol_searcher): New class.
700
57357d9d
TT		 7012019-11-26 Tom Tromey <tromey@adacore.com>
702
703 * cp-support.c (_initialize_cp_support): Conditionally initialize
704 gdb_demangle_attempt_core_dump.
705
3ea16160
TT		 7062019-11-26 Tom Tromey <tom@tromey.com>
707
708 * python/py-function.c (fnpy_init): Update.
709 * value.h (add_internal_function): Adjust declaration.
710 * value.c (function_destroyer): Remove.
711 (do_add_internal_function): Don't set destroyer or copy name.
712 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
713 Set name_allocated.
714 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
715 (cmdpy_init): Set name_allocated.
716 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
717 member.
718 (~cmd_list_element): Free "name" if needed.
719
1a6d41c6
TT		 7202019-11-26 Tom Tromey <tom@tromey.com>
721
722 * value.h (add_internal_function): Add new overload. Move
723 documentation from value.h.
724 * value.c (do_add_internal_function): New function.
725 (add_internal_function): Use it. Add new overload.
726 (function_destroyer): Don't free doc.
727 * python/py-function.c (fnpy_init): Update.
728
8318f3c3
TT		 7292019-11-26 Tom Tromey <tom@tromey.com>
730
731 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
732 (cmdpy_init): Set "doc_allocated".
733
4da8c3a8
TT		 7342019-11-26 Tom Tromey <tom@tromey.com>
735
736 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
737 name of worker thread.
738 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
739 pthread_setname_np.
740 * configure, config.in: Rebuild.
741
971db5e2
TT		 7422019-11-26 Tom Tromey <tom@tromey.com>
743
744 * python/python.c (class gdbpy_gil): New.
745 (struct gdbpy_event): Add constructor, destructor, operator().
746 (gdbpy_post_event): Use run_on_main_thread.
747 (gdbpy_initialize_events): Remove.
748 (do_start_initialization): Update.
749
22138db6
TT		 7502019-11-26 Tom Tromey <tom@tromey.com>
751
752 * NEWS: Add entry.
753 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
754 commands. Call update_thread_pool_size.
755 (update_thread_pool_size, maintenance_set_worker_threads): New
756 functions.
757 (n_worker_threads): New global.
758
d55c9a68
TT		 7592019-11-26 Christian Biesinger <cbiesinger@google.com>
760 Tom Tromey <tom@tromey.com>
761
762 * minsyms.c (minimal_symbol_reader::install): Use
763 parallel_for_each.
764 * gdbsupport/parallel-for.h: New file.
765 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
766
a0b57563
CB		 7672019-11-26 Christian Biesinger <cbiesinger@google.com>
768 Tom Tromey <tom@tromey.com>
769
770 * gdbsupport/thread-pool.h: New file.
771 * gdbsupport/thread-pool.c: New file.
772 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
773 (HFILES_NO_SRCDIR): Add thread-pool.h.
774
3b3978bc
TT		 7752019-11-26 Tom Tromey <tom@tromey.com>
776
777 * event-top.h (thread_local_segv_handler): Declare.
778 * event-top.c (thread_local_segv_handler): New global.
779 (install_handle_sigsegv, handle_sigsegv): New functions.
780 (async_init_signals): Install SIGSEGV handler.
781 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
782 thread-local.
783 (report_failed_demangle): New function.
784 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
785 handler-setting code, instead use segv_handler. Run warning code
786 on main thread.
787
9411c49e
TT		 7882019-11-26 Tom Tromey <tom@tromey.com>
789
790 * run-on-main-thread.c: New file.
791 * run-on-main-thread.h: New file.
792 * unittests/main-thread-selftests.c: New file.
793 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
794 main-thread-selftests.c.
795 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
796 (COMMON_SFILES): Add run-on-main-thread.c.
797
c3efb965
TT		 7982019-11-26 Tom Tromey <tom@tromey.com>
799
800 * main.c (setup_alternate_signal_stack): Remove.
801 (captured_main_1): Use gdb::alternate_signal_stack.
802 * gdbsupport/alt-stack.h: New file.
803
21987b9c
TT		 8042019-11-26 Tom Tromey <tom@tromey.com>
805
806 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
807 Remove comment.
808 (save_original_signals_state, restore_original_signals_state): Use
809 gdb_sigmask.
810 * linux-nat.c (block_child_signals, restore_child_signals_mask)
811 (_initialize_linux_nat): Use gdb_sigmask.
812 * guile/guile.c (_initialize_guile): Use block_signals.
813 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
814 * gdbsupport/gdb-sigmask.h: New file.
815 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
816 * cp-support.c (gdb_demangle): Use gdb_sigmask.
817 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
818 pthread_sigmask.
819 * configure, config.in: Rebuild.
820 * gdbsupport/block-signals.h: New file.
821
5e030278
TT		 8222019-11-26 Tom Tromey <tom@tromey.com>
823
824 * acinclude.m4: Include ax_pthread.m4.
825 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
826 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
827 (CLIBS): Use PTHREAD_LIBS.
828 (aclocal_m4_deps): Add ax_pthread.m4.
829 * config.in, configure: Rebuild.
830 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
831
5a79c107
TT		 8322019-11-26 Tom Tromey <tom@tromey.com>
833
834 * symtab.h (struct minimal_symbol) <name_set>: New member.
835 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
836 Don't call symbol_set_names.
837 (minimal_symbol_reader::install): Call symbol_set_names.
838
aa369509
PW		 8392019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
840
841 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
842 restore_active_ext_lang, as GIL is needed for (indirectly)
843 called PyOS_InterruptOccurred.
844
cadc9cb8
SM		 8452019-11-26 Simon Marchi <simon.marchi@efficios.com>
846
847 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
848 definition.
849
d04afd58
SM		 8502019-11-26 Simon Marchi <simon.marchi@efficios.com>
851
852 * remote-sim.c (simulator_command): Make static, remove
853 declaration.
854
dd694d77
SM		 8552019-11-26 Simon Marchi <simon.marchi@efficios.com>
856
857 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
858 static.
859 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
860 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
861 (main): Likewise.
862 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
863 (main): Likewise.
864 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
865 (main): Likewise.
866 * unittests/basic_string_view/element_access/char/1.cc (test01):
867 Likewise.
868 (main): Likewise.
869 * unittests/basic_string_view/element_access/char/empty.cc (main):
870 Likewise.
871 * unittests/basic_string_view/element_access/char/front_back.cc
872 (test01): Likewise.
873 (main): Likewise.
874 * unittests/basic_string_view/inserters/char/2.cc (test05):
875 Likewise.
876 (main): Likewise.
877 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
878 (test01): Likewise.
879 (main): Likewise.
880 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
881 (test01): Likewise.
882 (main): Likewise.
883 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
884 Likewise.
885 * unittests/basic_string_view/operations/compare/char/1.cc
886 (test01): Likewise.
887 (main): Likewise.
888 * unittests/basic_string_view/operations/compare/char/13650.cc
889 (test01): Likewise.
890 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
891 Likewise.
892 (main): Likewise.
893 * unittests/basic_string_view/operations/data/char/1.cc (test01):
894 Likewise.
895 (main): Likewise.
896 * unittests/basic_string_view/operations/find/char/1.cc (test01):
897 Likewise.
898 (main): Likewise.
899 * unittests/basic_string_view/operations/find/char/2.cc (test02):
900 Likewise.
901 (main): Likewise.
902 * unittests/basic_string_view/operations/find/char/3.cc (test03):
903 Likewise.
904 (main): Likewise.
905 * unittests/basic_string_view/operations/find/char/4.cc (main):
906 Likewise.
907 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
908 Likewise.
909 (main): Likewise.
910 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
911 Likewise.
912 (main): Likewise.
913 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
914 Likewise.
915 (main): Likewise.
916 * unittests/basic_string_view/operations/substr/char/1.cc
917 (test01): Likewise.
918 (main): Likewise.
919 * unittests/basic_string_view/operators/char/2.cc (main):
920 Likewise.
921 * unittests/optional/assignment/1.cc (test): Likewise.
922 * unittests/optional/assignment/2.cc (test): Likewise.
923 * unittests/optional/assignment/3.cc (test): Likewise.
924 * unittests/optional/assignment/4.cc (test): Likewise.
925 * unittests/optional/assignment/5.cc (test): Likewise.
926 * unittests/optional/assignment/6.cc (test): Likewise.
927 * unittests/optional/assignment/7.cc (test): Likewise.
928 * unittests/optional/cons/copy.cc (test): Likewise.
929 * unittests/optional/cons/default.cc (test): Likewise.
930 * unittests/optional/cons/move.cc (test): Likewise.
931 * unittests/optional/cons/value.cc (test): Likewise.
932 * unittests/optional/in_place.cc (test): Likewise.
933 * unittests/optional/observers/1.cc (test): Likewise.
934 * unittests/optional/observers/2.cc (test): Likewise.
935
3b5c1d49
SM		 9362019-11-26 Simon Marchi <simon.marchi@efficios.com>
937
938 * tui-win.h (tui_set_var_cmd): Remove.
939 * tui-win.c (tui_set_var_cmd): Make static.
940
adce99fe
SM		 9412019-11-26 Simon Marchi <simon.marchi@efficios.com>
942
943 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
944 rbreak_command_wrapper): Remove.
945 * symtab.c (rbreak_command_wrapper): Remove.
946
fe3adccf
SM		 9472019-11-26 Simon Marchi <simon.marchi@efficios.com>
948
949 * inferior.h (info_terminal_command): Remove declaration.
950 * inflow.c (info_terminal_command): Make static.
951
b926335f
SM		 9522019-11-26 Simon Marchi <simon.marchi@efficios.com>
953
954 * inferior.c (exit_inferior_silent): Remove.
955
b62f6f54
SM		 9562019-11-26 Simon Marchi <simon.marchi@efficios.com>
957
958 * dictionary.c (dict_empty, mdict_empty): Remove.
959 * dictionary.c (mdict_empty): Remove.
960
cb8c24b6
SM		 9612019-11-26 Simon Marchi <simon.marchi@efficios.com>
962
963 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
964 (arc_insn_get_memory_offset): Likewise.
965 (arc_insn_dump): Likewise.
966 * cp-support.c (test_cp_symbol_name_matches): Likewise.
967 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
968 * dictionary.c (dict_iterator_next): Likewise.
969 (dict_iter_match_first): Likewise.
970 (dict_iter_match_next): Likewise.
971 * f-lang.c (evaluate_subexp_f): Likewise.
972 * hppa-tdep.c (hppa_read_pc): Likewise.
973 * i386-tdep.c (i386_floatformat_for_type): Likewise.
974 * parse.c (write_exp_elt_msym): Likewise.
975 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
976 * remote.c (remote_packet_size): Likewise.
977 (remote_notif_stop_parse): Likewise.
978 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
979 * s12z-tdep.c (s12z_disassemble_info): Likewise.
980 * source.c (prepare_path_for_appending): Likewise.
981 * sparc64-linux-tdep.c
982 (sparc64_linux_handle_segmentation_fault); Likewise.
983 * stack.c (frame_selection_by_function_completer): Likewise.
984
781597ff
SM		 9852019-11-26 Simon Marchi <simon.marchi@efficios.com>
986
987 * completer.c (set_gdb_completion_word_break_characters):
988 Remove.
989
23baa4cc
SM		 9902019-11-26 Simon Marchi <simon.marchi@efficios.com>
991
992 * dwarf-index-write.c: Include dwarf-index-write.h.
993 * mi/mi-interp.c: Include mi/mi-interp.h.
994
23767560
SM		 9952019-11-26 Simon Marchi <simon.marchi@efficios.com>
996
997 * aarch32-tdep.c: Include aarch32-tdep.h.
998 * aarch32-tdep.h: Forward-declare struct target_desc.
999
6d91ce9a
CB		 10002019-11-26 Christian Biesinger <cbiesinger@google.com>
1001
1002 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1003 strerror.
1004 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1005 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1006
3cf2f237
TV		 10072019-11-25 Tom de Vries <tdevries@suse.de>
1008
1009 * contrib/words.sh: Add -c option.
1010
5b89c67a
CB		 10112019-11-25 Christian Biesinger <cbiesinger@google.com>
1012
1013 * solib.c (solib_find_1): Change int to bool.
1014 (exec_file_find): Change int to bool.
1015 (solib_find): Change int to bool.
1016 (solib_read_symbols): Change int to bool.
1017 (solib_used): Change int to bool.
1018 (solib_add): Change int to bool.
1019 (info_sharedlibrary_command): Change int to bool.
1020 (solib_contains_address_p): Change int to bool.
1021 (solib_keep_data_in_core): Change int to bool.
1022 (in_solib_dynsym_resolve_code): Change int to bool.
1023 (reload_shared_libraries_1): Change int to bool.
1024 (gdb_sysroot_changed): Change int to bool.
1025 * solib.h (solib_read_symbols): Change int to bool.
1026 (solib_contains_address_p): Change int to bool.
1027 (solib_keep_data_in_core): Change int to bool.
1028 (in_solib_dynsym_resolve_code): Change int to bool.
1029 (libpthread_name_p): Change int to bool.
1030
6cc8564b
LM		 10312019-11-25 Luis Machado <luis.machado@linaro.org>
1032
1033 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1034 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1035 (remote_packet_max_chars): New static global.
1036 (show_remote_packet_max_chars): New function.
1037 (remote_target::putpkt_binary): Adjust to use new
1038 remote_packet_max_chars option.
1039 (remote_target::getpkt_or_notif_sane_1): Likewise.
1040 (_initialize_remote): Register new remote-packet-max-chars option.
1041
a7cdaa91
SM		 10422019-11-24 Simon Marchi <simon.marchi@efficios.com>
1043
1044 * m68k-linux-nat.c: Include gdbarch.h.
1045
26abc753
TT		 10462019-11-24 Tom Tromey <tom@tromey.com>
1047
1048 * symfile.c (read_symbols): Update.
1049 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1050 bool.
1051 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1052 (psym_lookup_symbol, psym_find_last_source_symtab)
1053 (psym_forget_cached_source_info, psym_print_stats)
1054 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1055 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1056 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1057 (psym_find_compunit_symtab_by_address)
1058 (maintenance_print_psymbols, maintenance_info_psymtabs)
1059 (maintenance_check_psymtabs): Update.
1060 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1061 bool.
1062
012fc909
TT		 10632019-11-22 Tom Tromey <tom@tromey.com>
1064
1065 * observable.h: Update comments.
1066
c83d8d32
TT		 10672019-11-22 Tom Tromey <tromey@adacore.com>
1068
1069 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1070 (print_ada_task_info): Don't try to fetch thread id if task is not
1071 alive.
1072
987012b8
CB		 10732019-11-22 Christian Biesinger <cbiesinger@google.com>
1074
1075 * ada-exp.y: Update.
1076 * ada-lang.c (sort_choices): Update.
1077 (ada_print_symbol_signature): Update.
1078 (resolve_subexp): Update.
1079 (ada_parse_renaming): Update.
1080 (ada_read_renaming_var_value): Update.
1081 (lesseq_defined_than): Update.
1082 (remove_extra_symbols): Update.
1083 (remove_irrelevant_renamings): Update.
1084 (ada_add_block_symbols): Update.
1085 (ada_collect_symbol_completion_matches): Update.
1086 (ada_is_renaming_symbol): Update.
1087 (aggregate_assign_from_choices): Update.
1088 (ada_evaluate_subexp): Update.
1089 (ada_has_this_exception_support): Update.
1090 (ada_is_non_standard_exception_sym): Update.
1091 (ada_add_exceptions_from_frame): Update.
1092 (ada_add_global_exceptions): Update.
1093 (ada_print_subexp): Update.
1094 * ax-gdb.c (gen_var_ref): Update.
1095 (gen_maybe_namespace_elt): Update.
1096 (gen_expr_for_cast): Update.
1097 (gen_expr): Update.
1098 * block.h: Update.
1099 * blockframe.c (find_pc_partial_function): Update.
1100 * breakpoint.c (print_breakpoint_location): Update.
1101 (update_static_tracepoint): Update.
1102 * btrace.c (ftrace_print_function_name): Update.
1103 (ftrace_function_switched): Update.
1104 * buildsym.c (find_symbol_in_list): Update.
1105 * c-exp.y: Update.
1106 * c-typeprint.c (c_print_typedef): Update.
1107 (c_type_print_template_args): Update.
1108 * cli/cli-cmds.c (edit_command): Update.
1109 (list_command): Update.
1110 (print_sal_location): Update.
1111 * coffread.c (patch_opaque_types): Update.
1112 (process_coff_symbol): Update.
1113 (coff_read_enum_type): Update.
1114 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1115 (convert_one_symbol): Update.
1116 (hash_symname): Update.
1117 (eq_symname): Update.
1118 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1119 * compile/compile-cplus-types.c (debug_print_scope): Update.
1120 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1121 * compile/compile-object-load.c (get_out_value_type): Update.
1122 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1123 (search_symbol_list): Update.
1124 (cp_lookup_symbol_imports_or_template): Update.
1125 * cp-support.c (overload_list_add_symbol): Update.
1126 * ctfread.c (psymtab_to_symtab): Update.
1127 * dbxread.c (cp_set_block_scope): Update.
1128 * dictionary.c (iter_match_first_hashed): Update.
1129 (iter_match_next_hashed): Update.
1130 (insert_symbol_hashed): Update.
1131 (iter_match_next_linear): Update.
1132 * dictionary.h: Update.
1133 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1134 (locexpr_describe_location_piece): Update.
1135 (locexpr_describe_location_1): Update.
1136 (locexpr_generate_c_location): Update.
1137 (loclist_describe_location): Update.
1138 (loclist_generate_c_location): Update.
1139 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1140 (read_func_scope): Update.
1141 (process_enumeration_scope): Update.
1142 (new_symbol): Update.
1143 (dwarf2_const_value): Update.
1144 (dwarf2_symbol_mark_computed): Update.
1145 * eval.c (evaluate_funcall): Update.
1146 (evaluate_subexp_standard): Update.
1147 * expprint.c (print_subexp_standard): Update.
1148 (dump_subexp_body_standard): Update.
1149 * f-valprint.c (info_common_command_for_block): Update.
1150 * findvar.c (get_hosting_frame): Update.
1151 (default_read_var_value): Update.
1152 * go-lang.c (go_symbol_package_name): Update.
1153 * guile/scm-block.c (bkscm_print_block_smob): Update.
1154 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1155 (gdbscm_symbol_name): Update.
1156 (gdbscm_symbol_linkage_name): Update.
1157 (gdbscm_symbol_print_name): Update.
1158 * infcall.c (get_function_name): Update.
1159 * infcmd.c (jump_command): Update.
1160 (finish_command): Update.
1161 * infrun.c (insert_exception_resume_breakpoint): Update.
1162 * linespec.c (canonicalize_linespec): Update.
1163 (create_sals_line_offset): Update.
1164 (convert_linespec_to_sals): Update.
1165 (complete_label): Update.
1166 (find_label_symbols_in_block): Update.
1167 * m2-typeprint.c (m2_print_typedef): Update.
1168 * mdebugread.c (mdebug_reg_to_regnum): Update.
1169 (parse_symbol): Update.
1170 (mylookup_symbol): Update.
1171 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1172 (list_args_or_locals): Update.
1173 * objc-lang.c (compare_selectors): Update.
1174 (info_selectors_command): Update.
1175 (compare_classes): Update.
1176 (info_classes_command): Update.
1177 (find_imps): Update.
1178 * p-typeprint.c (pascal_print_typedef): Update.
1179 * printcmd.c (build_address_symbolic): Update.
1180 (info_address_command): Update.
1181 (print_variable_and_value): Update.
1182 * python/py-framefilter.c (extract_sym): Update.
1183 (py_print_single_arg): Update.
1184 * python/py-symbol.c (sympy_str): Update.
1185 (sympy_get_name): Update.
1186 (sympy_get_linkage_name): Update.
1187 * python/python.c (gdbpy_rbreak): Update.
1188 * record-btrace.c (btrace_get_bfun_name): Update.
1189 (btrace_call_history): Update.
1190 * rust-lang.c (rust_print_typedef): Update.
1191 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1192 * stabsread.c (stab_reg_to_regnum): Update.
1193 (define_symbol): Update.
1194 (read_enum_type): Update.
1195 (common_block_end): Update.
1196 (cleanup_undefined_types_1): Update.
1197 (scan_file_globals): Update.
1198 * stack.c (print_frame_arg): Update.
1199 (print_frame_args): Update.
1200 (find_frame_funname): Update.
1201 (info_frame_command_core): Update.
1202 (iterate_over_block_locals): Update.
1203 (print_block_frame_labels): Update.
1204 (do_print_variable_and_value): Update.
1205 (iterate_over_block_arg_vars): Update.
1206 (return_command): Update.
1207 * symmisc.c (dump_symtab_1): Update.
1208 (print_symbol): Update.
1209 * symtab.c (eq_symbol_entry): Update.
1210 (symbol_cache_dump): Update.
1211 (lookup_language_this): Update.
1212 (find_pc_sect_line): Update.
1213 (skip_prologue_sal): Update.
1214 (symbol_search::compare_search_syms): Update.
1215 (treg_matches_sym_type_name): Update.
1216 (search_symbols): Update.
1217 (print_symbol_info): Update.
1218 (rbreak_command): Update.
1219 (completion_list_add_symbol): Update.
1220 (find_gnu_ifunc): Update.
1221 (get_symbol_address): Update.
1222 (search_module_symbols): Update.
1223 (info_module_subcommand): Update.
1224 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1225 (SYMBOL_LINKAGE_NAME): Remove.
1226 (SYMBOL_DEMANGLED_NAME): Remove.
1227 (SYMBOL_PRINT_NAME): Remove.
1228 (SYMBOL_SEARCH_NAME): Remove.
1229 * tracepoint.c (set_traceframe_context): Update.
1230 (validate_actionline): Update.
1231 (collection_list::collect_symbol): Update.
1232 (encode_actions_1): Update.
1233 (info_scope_command): Update.
1234 (print_one_static_tracepoint_marker): Update.
1235 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1236 * valops.c (address_of_variable): Update.
1237 (find_overload_match): Update.
1238 (find_oload_champ): Update.
1239
c9d95fa3
CB		 12402019-11-22 Christian Biesinger <cbiesinger@google.com>
1241
1242 * ada-lang.c (ada_lookup_simple_minsym): Update.
1243 (ada_collect_symbol_completion_matches): Update.
1244 * ada-tasks.c (read_atcb): Update.
1245 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1246 (amd64_windows_skip_trampoline_code): Update.
1247 * arm-tdep.c (skip_prologue_function): Update.
1248 (arm_skip_stack_protector): Update.
1249 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1250 (arm_wince_skip_main_prologue): Update.
1251 * ax-gdb.c (gen_expr): Update.
1252 * block.c (call_site_for_pc): Update.
1253 * blockframe.c (find_pc_partial_function): Update.
1254 * breakpoint.c (set_breakpoint_location_function): Update.
1255 * btrace.c (ftrace_print_function_name): Update.
1256 (ftrace_function_switched): Update.
1257 * c-valprint.c (print_unpacked_pointer): Update.
1258 * coffread.c (coff_symfile_read): Update.
1259 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1260 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1261 * dwarf-index-write.c (write_psymbols): Update.
1262 * dwarf2loc.c (call_site_to_target_addr): Update.
1263 (func_verify_no_selftailcall): Update.
1264 (tailcall_dump): Update.
1265 (call_site_find_chain_1): Update.
1266 (dwarf_expr_reg_to_entry_parameter): Update.
1267 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1268 * eval.c (evaluate_funcall): Update.
1269 (evaluate_subexp_standard): Update.
1270 (evaluate_subexp_for_sizeof): Update.
1271 * expprint.c (print_subexp_standard): Update.
1272 (dump_subexp_body_standard): Update.
1273 * frame.c (get_prev_frame_always_1): Update.
1274 * frv-tdep.c (frv_skip_main_prologue): Update.
1275 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1276 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1277 (gnuv3_get_typename_from_type_info): Update.
1278 (gnuv3_skip_trampoline): Update.
1279 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1280 * i386-tdep.c (i386_skip_main_prologue): Update.
1281 (i386_pe_skip_trampoline_code): Update.
1282 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1283 * infcall.c (get_function_name): Update.
1284 * linespec.c (minsym_found): Update.
1285 * linux-fork.c (info_checkpoints_command): Update.
1286 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1287 (m32c_m16c_pointer_to_address): Update.
1288 * maint.c (maintenance_translate_address): Update.
1289 * minsyms.c (add_minsym_to_hash_table): Update.
1290 (add_minsym_to_demangled_hash_table): Update.
1291 (lookup_minimal_symbol_mangled): Update.
1292 (lookup_minimal_symbol_demangled): Update.
1293 (lookup_minimal_symbol_linkage): Update.
1294 (lookup_minimal_symbol_text): Update.
1295 (lookup_minimal_symbol_by_pc_name): Update.
1296 (minimal_symbol_is_less_than): Update.
1297 (compact_minimal_symbols): Update.
1298 (build_minimal_symbol_hash_tables): Update.
1299 (find_solib_trampoline_target): Update.
1300 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1301 (mips_skip_pic_trampoline_code): Update.
1302 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1303 * objc-lang.c (info_selectors_command): Update.
1304 (info_classes_command): Update.
1305 (find_methods): Update.
1306 (find_imps): Update.
1307 * p-valprint.c (pascal_val_print): Update.
1308 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1309 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1310 * printcmd.c (build_address_symbolic): Update.
1311 (info_symbol_command): Update.
1312 * psymtab.c (psymbol_name_matches): Update.
1313 (match_partial_symbol): Update.
1314 (lookup_partial_symbol): Update.
1315 (print_partial_symbols): Update.
1316 (sort_pst_symbols): Update.
1317 (maintenance_check_psymtabs): Update.
1318 * python/py-framefilter.c (py_print_frame): Update.
1319 * python/python.c (gdbpy_rbreak): Update.
1320 * record-btrace.c (btrace_get_bfun_name): Update.
1321 (btrace_call_history): Update.
1322 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1323 (rs6000_skip_trampoline_code): Update.
1324 * sol-thread.c (info_cb): Update.
1325 * stabsread.c (scan_file_globals): Update.
1326 * stack.c (find_frame_funname): Update.
1327 (info_frame_command_core): Update.
1328 * symmisc.c (dump_msymbols): Update.
1329 * symtab.c (symbol_natural_name): Rename to..,
1330 (general_symbol_info::natural_name): ...this.
1331 (symbol_demangled_name): Rename to...
1332 (general_symbol_info::demangled_name): ...this.
1333 (symbol_search_name): Rename to...
1334 (general_symbol_info::search_name): ...this.
1335 (symbol_matches_search_name): Update.
1336 (find_pc_sect_line): Update.
1337 (skip_prologue_sal): Update.
1338 (search_symbols): Update.
1339 (print_msymbol_info): Update.
1340 (rbreak_command): Update.
1341 (completion_list_add_msymbol): Update.
1342 (completion_list_objc_symbol): Update.
1343 (get_msymbol_address): Update.
1344 * symtab.h (struct general_symbol_info): Add member functions
1345 natural_name (), linkage_name (), print_name (), demangled_name (),
1346 and search_name ().
1347 (SYMBOL_NATURAL_NAME): Update.
1348 (symbol_natural_name): Move to a member function on general_symbol_info.
1349 (SYMBOL_DEMANGLED_NAME): Update.
1350 (symbol_demangled_name): Move to a member function on
1351 general_symbol_info.
1352 (SYMBOL_SEARCH_NAME): Update.
1353 (symbol_search_name): Move to a member function on general_symbol_info.
1354 (MSYMBOL_NATURAL_NAME): Remove.
1355 (MSYMBOL_LINKAGE_NAME): Remove.
1356 (MSYMBOL_PRINT_NAME): Remove.
1357 (MSYMBOL_DEMANGLED_NAME): Remove.
1358 (MSYMBOL_SEARCH_NAME): Remove.
1359 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1360
f8bab2d6
CB		 13612019-11-22 Christian Biesinger <cbiesinger@google.com>
1362
1363 * symtab.c (create_demangled_names_hash): Use per_bfd->
1364 minimal_symbol_count for computing the initial size, if greater
1365 than our default size.
1366
85e7588d
TV		 13672019-11-22 Tom de Vries <tdevries@suse.de>
1368
1369 * contrib/words.sh: Improve words extraction.
1370
f6180073
TV		 13712019-11-22 Tom de Vries <tdevries@suse.de>
1372
1373 * contrib/words.sh: Combine sed invocations.
1374
f10ffa41
CB		 13752019-11-21 Christian Biesinger <cbiesinger@google.com>
1376
1377 * Makefile.in: Update.
1378 * demangle.c: Rename to...
1379 * gdb-demangle.c: ..this.
1380 (is_cplus_marker): Change return type to bool.
1381 (_initialize_demangler): Rename to...
1382 (_initialize_gdb_demangle): ...this.
1383 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1384 * symtab.h (demangle): Remove declaration; instead include
1385 gdb-demangle.h.
1386
6ba18521
TT		 13872019-11-21 Tom Tromey <tromey@adacore.com>
1388
1389 * gdbsupport/format.c (format_pieces): Parse %I64d.
1390 * unittests/format_pieces-selftests.c (test_windows_formats): New
1391 function.
1392 (run_tests): Call it.
1393
34877895
PJ		 13942019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1395
1396 Byte reverse display of variables with DW_END_big, DW_END_little
1397 (DW_AT_endianity) dwarf attributes if different than the native
1398 byte order.
1399 * ada-lang.c (ada_value_binop):
1400 Use type_byte_order instead of gdbarch_byte_order.
1401 * ada-valprint.c (printstr):
1402 (ada_val_print_string):
1403 * ada-lang.c (value_pointer):
1404 (ada_value_binop):
1405 Use type_byte_order instead of gdbarch_byte_order.
1406 * c-lang.c (c_get_string):
1407 Use type_byte_order instead of gdbarch_byte_order.
1408 * c-valprint.c (c_val_print_array):
1409 Use type_byte_order instead of gdbarch_byte_order.
1410 * cp-valprint.c (cp_print_class_member):
1411 Use type_byte_order instead of gdbarch_byte_order.
1412 * dwarf2loc.c (rw_pieced_value):
1413 Use type_byte_order instead of gdbarch_byte_order.
1414 * dwarf2read.c (read_base_type): Handle DW_END_big,
1415 DW_END_little
1416 * f-lang.c (f_get_encoding):
1417 Use type_byte_order instead of gdbarch_byte_order.
1418 * findvar.c (default_read_var_value):
1419 Use type_byte_order instead of gdbarch_byte_order.
1420 * gdbtypes.c (check_types_equal):
1421 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1422 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1423 and TYPE_ENDIANITY_LITTLE if set.
1424 (type_byte_order): new function.
1425 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1426 (struct main_type) <flag_endianity_not_default>:
1427 New field.
1428 (type_byte_order): New function.
1429 * infcmd.c (default_print_one_register_info):
1430 Use type_byte_order instead of gdbarch_byte_order.
1431 * p-lang.c (pascal_printstr):
1432 Use type_byte_order instead of gdbarch_byte_order.
1433 * p-valprint.c (pascal_val_print):
1434 Use type_byte_order instead of gdbarch_byte_order.
1435 * printcmd.c (print_scalar_formatted):
1436 Use type_byte_order instead of gdbarch_byte_order.
1437 * solib-darwin.c (darwin_current_sos):
1438 Use type_byte_order instead of gdbarch_byte_order.
1439 * solib-svr4.c (solib_svr4_r_ldsomap):
1440 Use type_byte_order instead of gdbarch_byte_order.
1441 * stap-probe.c (stap_modify_semaphore):
1442 Use type_byte_order instead of gdbarch_byte_order.
1443 * target-float.c (target_float_same_format_p):
1444 Use type_byte_order instead of gdbarch_byte_order.
1445 * valarith.c (scalar_binop):
1446 (value_bit_index):
1447 Use type_byte_order instead of gdbarch_byte_order.
1448 * valops.c (value_cast):
1449 Use type_byte_order instead of gdbarch_byte_order.
1450 * valprint.c (generic_emit_char):
1451 (generic_printstr):
1452 (val_print_string):
1453 Use type_byte_order instead of gdbarch_byte_order.
1454 * value.c (unpack_long):
1455 (unpack_bits_as_long):
1456 (unpack_value_bitfield):
1457 (modify_field):
1458 (pack_long):
1459 (pack_unsigned_long):
1460 Use type_byte_order instead of gdbarch_byte_order.
1461 * findvar.c (unsigned_pointer_to_address):
1462 (signed_pointer_to_address):
1463 (unsigned_address_to_pointer):
1464 (address_to_signed_pointer):
1465 (default_read_var_value):
1466 (default_value_from_register):
1467 Use type_byte_order instead of gdbarch_byte_order.
1468 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1469 Use type_byte_order instead of gdbarch_byte_order.
1470 * riscv-tdep.c (riscv_print_one_register_info):
1471 Use type_byte_order instead of gdbarch_byte_order.
1472
87fb00ea
SM		 14732019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1474
1475 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1476 (current_ui_gdb_stdin_ptr): Likewise.
1477 (current_ui_gdb_stderr_ptr): Likewise.
1478 (current_ui_gdb_stdlog_ptr): Likewise.
1479 (current_ui_current_uiout_ptr): Likewise.
1480 (gen_ret_current_ui_field_ptr): Remove.
1481
65d1cd5f
TV		 14822019-11-21 Tom de Vries <tdevries@suse.de>
1483
1484 PR gdb/24956
1485 * cli/cli-script.c (execute_control_command): Only switch to
1486 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1487
9f6ad286
TT		 14882019-11-19 Tom Tromey <tom@tromey.com>
1489
1490 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1491 Now static. Change type of "name".
1492 (tui_set_win_height_command): Don't copy "arg".
1493 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1494 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1495
435d3d88
AT		 14962019-11-19 Ali Tamur <tamur@google.com>
1497
1498 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1499 "if (attr != nullptr)".
1500 (dwarf2_find_base_address): Likewise.
1501 (dwarf2_build_include_psymtabs): Likewise.
1502 (read_cutu_die_from_dwo): Likewise.
1503 (read_func_scope): Likewise.
1504 (read_call_site_scope): Likewise.
1505 (dwarf2_get_pc_bounds): Likewise.
1506 (dwarf2_record_block_ranges): Likewise.
1507 (dwarf2_add_field): Likewise.
1508 (dwarf2_add_member_fn): Likewise.
1509 (read_structure_type): Likewise.
1510 (read_enumeration_type): Likewise.
1511 (read_array_type): Likewise.
1512 (read_array_order): Likewise.
1513 (read_set_type): Likewise.
1514 (read_common_block): Likewise.
1515 (read_tag_reference_type): Likewise.
1516 (read_tag_string_type): Likewise.
1517 (read_subroutine_type): Likewise.
1518 (read_base_type): Likewise.
1519 (read_subrange_type): Likewise.
1520 (new_symbol): Likewise.
1521 (prepare_one_comp_unit): Likewise.
1522
c9739b6a
TT		 15232019-11-19 Tom Tromey <tromey@adacore.com>
1524
1525 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1526 result in error when DebugActiveProcess fails.
1527
494409bb
SDJ		 15282019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1529 Pedro Alves <palves@redhat.com>
1530
1531 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1532 * target.c (target_stack::push): Call 'unpush' if there's a
1533 target on top of the stack.
1534
2e953aca
PW		 15352019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1536
1537 * python/py-block.c (blpy_dealloc): Call tp_free.
1538 (blpy_block_syms_dealloc): Likewise.
1539 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1540 * python/py-inferior.c (infpy_dealloc): Likewise.
1541 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1542 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1543 * python/py-symbol.c (sympy_dealloc): Likewise.
1544 * python/py-symtab.c (stpy_dealloc): Likewise.
1545 * python/py-type.c (typy_iterator_dealloc): Likewise.
1546
6edc43ec
CB		 15472019-11-18 Christian Biesinger <cbiesinger@google.com>
1548
1549 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1550 constructor instead of using a class initializer.
1551
cd850b40
CB		 15522019-11-15 Christian Biesinger <cbiesinger@google.com>
1553
1554 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1555 * configure: Regenerate.
1556 * configure.ac: Don't source common.host.
1557 * gdbsupport/common.host: Remove.
1558 * gdbsupport/mingw-strerror.c: Remove.
1559 * gdbsupport/posix-strerror.c: Rename to...
1560 * gdbsupport/safe-strerror.c: ...this.
1561
53fea9c7
CB		 15622019-11-15 Christian Biesinger <cbiesinger@google.com>
1563
1564 * maint.c (scoped_command_stats::print_time): Use localtime_r
1565 instead of localtime (provided through gnulib if necessary).
1566 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1567 of ctime.
1568
f8e27d88
CB		 15692019-11-15 Christian Biesinger <cbiesinger@google.com>
1570
1571 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1572 avoid compile errors.
1573
5abebf3c
CB		 15742019-11-15 Christian Biesinger <cbiesinger@google.com>
1575
1576 * config.in: Regenerate.
1577 * configure: Regenerate.
1578 * gdbsupport/common.m4: No longer check for strerror_r.
1579 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1580 POSIX version of strerror_r, now that gnulib provides it if
1581 necessary.
1582
9a351667
CB		 15832019-11-14 Christian Biesinger <cbiesinger@google.com>
1584
1585 * README (`configure' options): Update.
1586
55708e99
TT		 15872019-11-14 Tom Tromey <tromey@adacore.com>
1588
1589 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1590 expected type for the RHS if the LHS is a convenience variable.
1591
4b09bb2e
SM		 15922019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1593
1594 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1595 Provide explicit default and copy constructor.
1596
bd454f8b
PW		 15972019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1598
1599 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1600 only call Py_INCREF (newbp) in the bppy_pending_object case.
1601
d1aa3cf0
TT		 16022019-11-13 Tom Tromey <tromey@adacore.com>
1603
1604 PR build/25182:
1605 * psympriv.h (partial_symbol): Remove static assert.
1606 * symtab.h (general_symbol_info, symbol): Remove static assert.
1607
e06f3d6e
AB		 16082019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1609
1610 * gdbsupport/format.c (format_pieces::format_pieces): Support
1611 printf 'z' size modifier.
1612 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1613 * printcmd.c (ui_printf): Handle size_t_arg.
1614 * ui-out.c (ui_out::vmessage): Likewise.
1615 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1616 function.
1617 (run_tests): Call test_format_int_sizes.
1618
468c0cbb
CB		 16192019-11-12 Christian Biesinger <cbiesinger@google.com>
1620
1621 * ada-exp.y (write_ambiguous_var): Update.
1622 * buildsym.c (add_symbol_to_list): Update.
1623 * dwarf2read.c (read_variable): Update.
1624 (new_symbol): Update.
1625 * jit.c (finalize_symtab): Update.
1626 * language.c (language_alloc_type_symbol): Update.
1627 * symtab.c (fixup_symbol_section): Update.
1628 (initialize_objfile_symbol_1): Move code to...
1629 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1630 (allocate_symbol): Update.
1631 (allocate_template_symbol): Update.
1632 (get_symbol_address): Update.
1633 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1634 of having as a field, and add a constructor.
1635 (SYMBOL_VALUE): Update.
1636 (SYMBOL_VALUE_ADDRESS): Update.
1637 (SET_SYMBOL_VALUE_ADDRESS): Update.
1638 (SYMBOL_VALUE_BYTES): Update.
1639 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1640 (SYMBOL_BLOCK_VALUE): Update.
1641 (SYMBOL_VALUE_CHAIN): Update.
1642 (SYMBOL_LANGUAGE): Update.
1643 (SYMBOL_SECTION): Update.
1644 (SYMBOL_OBJ_SECTION): Update.
1645 (SYMBOL_SET_LANGUAGE): Update.
1646 (SYMBOL_SET_LINKAGE_NAME): Update.
1647 (SYMBOL_SET_NAMES): Update.
1648 (SYMBOL_NATURAL_NAME): Update.
1649 (SYMBOL_LINKAGE_NAME): Update.
1650 (SYMBOL_DEMANGLED_NAME): Update.
1651 (SYMBOL_SEARCH_NAME): Update.
1652 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1653 (struct symbol): Update.
1654 (struct template_symbol): Update.
1655 (struct rust_vtable_symbol): Update.
1656 * xcoffread.c (SYMBOL_DUP): Update.
1657
ed2c82c3
TT		 16582019-11-12 Tom Tromey <tom@tromey.com>
1659
1660 * tui/tui-layout.c (show_layout): Set current_layout.
1661 (show_source_disasm_command, show_data)
1662 (show_source_or_disasm_and_command): Don't set current_layout.
1663
d9fcefd5
TT		 16642019-11-12 Tom Tromey <tom@tromey.com>
1665
1666 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1667
45e42163
TT		 16682019-11-12 Tom Tromey <tom@tromey.com>
1669
1670 * tui/tui-win.c (resize_message): New global.
1671 (show_tui_resize_message): New function.
1672 (tui_async_resize_screen): Print message if requested.
1673 (_initialize_tui_win): Add tui-resize-message setting.
1674 * NEWS: Add entry for new commands.
1675
c86d74cc
TT		 16762019-11-11 Tom Tromey <tom@tromey.com>
1677
1678 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1679 functions.
1680
7b7b9424
CB		 16812019-11-11 Christian Biesinger <cbiesinger@google.com>
1682
1683 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1684
086baaf1
AB		 16852019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1686
1687 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1688 function.
1689 * python/python-internal.h (gdbpy_lookup_static_symbols):
1690 Declare new function.
1691 * python/python.c (python_GdbMethods): Add
1692 gdb.lookup_static_symbols method.
1693 * NEWS: Mention gdb.lookup_static_symbols.
1694
09ff83af
AB		 16952019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1696
1697 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1698 static block of current object file first. Also fix typo in
1699 header comment.
1700
eb2dd8df
AB		 17012019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1702
1703 * stack.c (set_last_displayed_sal): Delete.
1704 (last_displayed_sal_valid): Delete.
1705 (last_displayed_pspace): Delete.
1706 (last_displayed_addr): Delete.
1707 (last_displayed_symtab): Delete.
1708 (last_displayed_line): Delete.
1709 (class last_displayed_symtab_info_type): New.
1710 (last_displayed_symtab_info): New static global variable.
1711 (print_frame_info): Call methods on last_displayed_symtab_info.
1712 (clear_last_displayed_sal): Update header comment, and make use of
1713 last_displayed_symtab_info.
1714 (last_displayed_sal_is_valid): Likewise.
1715 (get_last_displayed_pspace): Likewise.
1716 (get_last_displayed_addr): Likewise.
1717 (get_last_displayed_symtab): Likewise.
1718 (get_last_displayed_line): Likewise.
1719 (get_last_displayed_sal): Likewise.
1720 * stack.h (clear_last_displayed_sal): Update header comment.
1721 (last_displayed_sal_is_valid): Likewise.
1722 (get_last_displayed_pspace): Likewise.
1723 (get_last_displayed_addr): Likewise.
1724 (get_last_displayed_symtab): Likewise.
1725 (get_last_displayed_line): Likewise.
1726 (get_last_displayed_sal): Likewise.
1727
62137775
AB		 17282019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1729
1730 * stack.c (frame_show_address): Convert return type to bool.
1731 * stack.h (frame_show_address): Likewise, and update header
1732 comment.
1733
cf57ad6d
AB		 17342019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1735
1736 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1737 * unittests/vec-utils-selftests.c: New file.
1738 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1739
0b026263
TT		 17402019-11-10 Tom Tromey <tom@tromey.com>
1741
1742 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1743 (tui_highlight_win): Likewise.
1744 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1745 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1746 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1747 Don't set can_highlight.
1748
b049ce2d
TT		 17492019-11-10 Tom Tromey <tom@tromey.com>
1750
1751 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1752 Remove unused declaration.
1753
992a7040
TT		 17542019-11-08 Tom Tromey <tromey@adacore.com>
1755
1756 * top.c (read_command_file): Update.
1757 (command_line_input): Make return type const.
1758 * python/py-gdb-readline.c: Update.
1759 * linespec.c (decode_line_2): Update.
1760 * defs.h (command_line_input): Make return type const.
1761 * cli/cli-script.c (read_next_line): Make return type const.
1762 * ada-lang.c (get_selections): Update.
1763
ca3a04f6
CB		 17642019-11-06 Christian Biesinger <cbiesinger@google.com>
1765
1766 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1767 * mi/mi-main.c (output_cores): Likewise.
1768 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1769 (linux_xfer_osdata_modules): Likewise.
1770 * remote.c (register_remote_support_xml): Likewise.
1771 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1772 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1773
e0eac551
TT		 17742019-11-06 Tom Tromey <tom@tromey.com>
1775
1776 * tui/tui-interp.c: Don't include readline.h.
1777 * tui/tui-hooks.c: Don't include readline.h.
1778 * symmisc.c: Include tilde.h, not readline.h.
1779 * symfile.c: Include tilde.h, not readline.h.
1780 * source.c: Include tilde.h, not readline.h.
1781 * solib.c: Include tilde.h, not readline.h.
1782 * psymtab.c: Include tilde.h, not readline.h.
1783 * exec.c: Include tilde.h, not readline.h.
1784 * corelow.c: Include tilde.h, not readline.h.
1785 * cli/cli-dump.c: Include tilde.h, not readline.h.
1786 * cli/cli-cmds.c: Don't include readline.h.
1787
825165c5
TT		 17882019-11-05 Tom Tromey <tom@tromey.com>
1789
1790 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1791 (tui_disassemble): Set addr_size.
1792 (tui_disasm_window::set_contents): Use addr_size.
1793
91ae903f
TT		 17942019-11-05 Tom Tromey <tom@tromey.com>
1795
1796 * rust-lang.c (rust_language_defn): Update.
1797 * python/py-value.c (valpy_string): Call c_get_string.
1798 * p-lang.c (pascal_language_defn): Update.
1799 * opencl-lang.c (opencl_language_defn): Update.
1800 * objc-lang.c (objc_language_defn): Update.
1801 * m2-lang.c (m2_language_defn): Update.
1802 * language.c (unknown_language_defn, auto_language_defn): Update.
1803 (default_get_string): Remove.
1804 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1805 * go-lang.c (go_language_defn): Update.
1806 * f-lang.c (f_language_defn): Update.
1807 * d-lang.c (d_language_defn): Update.
1808 * c-lang.c (c_language_defn, cplus_language_defn)
1809 (asm_language_defn, minimal_language_defn): Update.
1810 * ada-lang.c (ada_language_defn): Update.
1811 * language.h (struct language_defn) <la_get_string>: Remove.
1812 (LA_GET_STRING): Remove.
1813 (default_get_string): Don't declare.
1814
1df2f9ef
TT		 18152019-11-05 Tom Tromey <tom@tromey.com>
1816
1817 * tui/tui-source.h (struct tui_source_window): Inline
1818 constructor. Remove destructor.
1819 <style_changed, m_observable>: Move to superclass.
1820 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1821 (struct tui_source_window_base): Move private members to end.
1822 <style_changed, m_observable>: Move from tui_source_window.
1823 * tui/tui-winsource.c (tui_copy_source_line): Move from
1824 tui-source.c. Rename from copy_source_line. Add special handling
1825 for negative line number.
1826 (tui_source_window_base::style_changed): Move from
1827 tui_source_window.
1828 (tui_source_window_base): Register observer.
1829 (~tui_source_window_base): New.
1830 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1831 rename.
1832 (tui_source_window::set_contents): Use tui_copy_source_line.
1833 (tui_source_window::tui_source_window): Move to tui-source.h.
1834 (tui_source_window::~tui_source_window): Remove.
1835 (tui_source_window::style_changed): Move to superclass.
1836 * tui/tui-disasm.c (tui_disassemble): Create string file with
1837 styling, when possible. Add "addr_size" parameter.
1838 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1839 Don't compute maximum size.
1840 (len_without_escapes): New function
1841
5d051055
TT		 18422019-11-05 Tom Tromey <tom@tromey.com>
1843
1844 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1845 std::string.
1846 * tui/tui-winsource.c (tui_show_source_line): Update.
1847 * tui/tui-source.c (tui_source_window::set_contents): Update.
1848 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1849
ade7beea
CB		 18502019-11-05 Christian Biesinger <cbiesinger@google.com>
1851
1852 * symtab.h (gdb_static_assert): Put && operator at the beginning
1853 of the line instead of the end.
1854
3573abe1
CB		 18552019-11-04 Christian Biesinger <cbiesinger@google.com>
1856
1857 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1858 and sizeof (symbol).
1859 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1860
dae8b3eb
RO		 18612019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1862
1863 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1864 * configure.host: Mark *-*-solaris2.10* obsolete.
1865 * configure.tgt: Mark Solaris < 11 obsolete.
1866 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1867 Update target triplet.
1868
5df96a4e
TT		 18692019-11-01 Tom Tromey <tromey@adacore.com>
1870
1871 * utils.c (print_sys_errmsg): Simplify.
1872
b7481649
TT		 18732019-11-01 Tom Tromey <tromey@adacore.com>
1874
1875 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1876
e48f6033
CB		 18772019-11-01 Christian Biesinger <cbiesinger@google.com>
1878
1879 * configure: Regenerate.
1880 * configure.ac: Remove check for strerror_r.
1881 * gdbsupport/common.m4: Check for strerror_r.
1882
bd5766ec
LM		 18832019-11-01 Luis Machado <luis.machado@linaro.org>
1884
1885 PR gdb/25124
1886
1887 * arm-tdep.c (arm_per_objfile): Rename to ...
1888 (arm_per_bfd): ... this.
1889 (arm_objfile_data_key): Rename to ...
1890 (arm_bfd_data_key): ... this.
1891 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1892 data.
1893 (arm_record_special_symbol): Likewise.
1894
e1709896
AB		 18952019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1896
1897 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1898 end.
1899 * c-typeprint.c (c_print_typedef): Likewise.
1900 * f-typeprint.c (f_print_typedef): Likewise.
1901 * m2-typeprint.c (m2_print_typedef): Likewise.
1902 * p-typeprint.c (pascal_print_typedef): Likewise.
1903 * rust-lang.c (rust_print_typedef): Likewise.
1904 * symtab.c (print_symbol_info): Print a newline after calling
1905 typedef_print.
1906
165f8965
AB		 19072019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1908
1909 * symtab.c (info_module_cmdlist): New variable.
1910 (info_module_command): New function.
1911 (search_module_symbols): New function.
1912 (info_module_subcommand): New function.
1913 (struct info_modules_var_func_options): New struct.
1914 (info_modules_var_func_options_defs): New variable.
1915 (make_info_modules_var_func_options_def_group): New function.
1916 (info_module_functions_command): New function.
1917 (info_module_variables_command): New function.
1918 (info_module_var_func_command_completer): New function.
1919 (_initialize_symtab): Register new 'info module functions' and
1920 'info module variables' commands.
1921 * symtab.h (typedef symbol_search_in_module): New typedef.
1922 (search_module_symbols): Declare new function.
1923 * NEWS: Mention new commands.
1924
59c35742
AB		 19252019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1926
1927 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1928 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1929 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1930 MODULES_DOMAIN.
1931 (scan_partial_symbols): Only create partial module symbols for non
1932 declarations.
1933 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1934 and MODULES_DOMAIN.
1935 * symtab.c (search_domain_name): Likewise.
1936 (search_symbols): Likewise.
1937 (print_symbol_info): Likewise.
1938 (symtab_symbol_info): Likewise.
1939 (info_modules_command): New function.
1940 (_initialize_symtab): Register 'info modules' command.
1941 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1942 * NEWS: Mention new 'info modules' command.
1943
aed61d02
PW		 19442019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1945
1946 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1947 and $_gdb_maint_setting_str.
1948
9ad9b77d
PW		 19492019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1950
1951 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1952 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1953 (str_value_from_setting, gdb_setting_str_internal_fn)
1954 (gdb_maint_setting_str_internal_fn): New functions.
1955 (_initialize_cli_cmds): Define the new convenience functions.
1956 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1957 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1958
8d6efaa2
CB		 19592019-10-31 Christian Biesinger <cbiesinger@google.com>
1960
1961 * agent.c (set_can_use_agent): When the setting is turned on,
1962 look up agent symbols if we don't have them yet.
1963 (agent_new_objfile): Don't look up agent symbols when the agent
1964 setting is off.
1965
33cb1647
CB		 19662019-10-31 Christian Biesinger <cbiesinger@google.com>
1967
1968 * config.in: Regenerate.
1969
b231e86a
CB		 19702019-10-31 Christian Biesinger <cbiesinger@google.com>
1971
1972 * configure: Regenerate.
1973 * configure.ac: Check for strerror_r.
1974 * gdbsupport/common-utils.h (safe_strerror): Change return value
1975 to const char * and document that this function is now threadsafe.
1976 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1977 thread_local and call strerror_r, if available.
1978 * utils.c (perror_string): Update.
1979 (print_sys_errmsg): Update.
1980
a2726d4f
LM		 19812019-10-31 Luis Machado <luis.machado@linaro.org>
1982
1983 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1984 objfile_key.
1985 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1986 objfile to fetch per-bfd data.
1987 (arm_find_exidx_entry): Likewise.
1988
75cafaa6
CB		 19892019-10-31 Christian Biesinger <cbiesinger@google.com>
1990
1991 * gdbsupport/agent.c (debug_agent): Change type to bool.
1992 (use_agent): Likewise.
1993 (all_agent_symbols_look_up): Likewise.
1994 (agent_loaded_p): Change return value to bool.
1995 (agent_look_up_symbols): Update.
1996 (agent_capability_check): Change return value to bool.
1997 * gdbsupport/agent.h (agent_loaded_p): Likewise.
1998 (debug_agent): Change type to bool.
1999 (use_agent): Likewise.
2000 (agent_capability_check): Change return value to bool.
2001
808590ec
CB		 20022019-10-30 Christian Biesinger <cbiesinger@google.com>
2003
2004 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2005 (build_minimal_symbol_hash_tables): Code to clear the table moved
2006 to clear_minimal_symbol_hash_tables.
2007 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2008 when needed.
2009
f18ad8a1
SM		 20102019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2011
2012 * infcmd.c: Remove includes.
2013 * infrun.c: Remove includes.
2014
de93309a
SM		 20152019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2016
2017 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2018 (grow_vect): Remove declaration.
2019 (ada_type_of_array): Remove declaration.
2020 (ada_update_initial_language): Remove declaration.
2021 (ada_fold_name): Remove declaration.
2022 (ada_fill_in_ada_prototype): Remove declaration.
2023 (user_select_syms): Remove declaration.
2024 (get_selections): Remove declaration.
2025 (ada_tag_type): Remove declaration.
2026 (ada_value_tag): Remove declaration.
2027 (ada_is_others_clause): Remove declaration.
2028 (ada_in_variant): Remove declaration.
2029 (ada_value_struct_elt): Remove declaration.
2030 (ada_attribute_name): Remove declaration.
2031 (ada_system_address_type): Remove declaration.
2032 * ada-lang.c (ada_watch_location_expression): Make static.
2033 (GROW_VECT): Move here from ada-lang.h.
2034 (grow_vect): Make static.
2035 (ada_update_initial_language): Make static.
2036 (ada_fold_name): Make static.
2037 (ada_type_of_array): Make static.
2038 (encoded_ordered_before): Move up.
2039 (sort_choices): Move up.
2040 (print_signatures): Move up.
2041 (ada_print_symbol_signature): Move up.
2042 (get_selections): Move up and make static.
2043 (user_select_syms): Move up and make static.
2044 (ada_value_struct_elt): Move up and make static.
2045 (ada_tag_type): Make static.
2046 (ada_value_tag): Make static.
2047 (ada_is_others_clause): Make static.
2048 (ada_in_variant): Make static.
2049 (ada_attribute_name): Make static.
2050
cdc46a9f
SM		 20512019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2052
2053 * ada-lang.c: Remove includes.
2054 * ada-typeprint.c: Remove includes.
2055 * ada-valprint.c: Remove includes.
2056
90421c56
SM		 20572019-10-29 Simon Marchi <simon.marchi@efficios.com>
2058
2059 * addrmap.c: Add static assertions of type size, moved from
2060 _initialize_addrmap.
2061 (_initialize_addrmap): Remove.
2062
31edb802
CB		 20632019-10-29 Christian Biesinger <cbiesinger@google.com>
2064
2065 * coffread.c (record_minimal_symbol): Update.
2066 (process_coff_symbol): Update.
2067 * dbxread.c (read_dbx_symtab): Update.
2068 * dwarf2read.c (add_partial_symbol): Update.
2069 (fixup_go_packaging): Update.
2070 (load_partial_dies): Update.
2071 (new_symbol): Update.
2072 * elfread.c (record_minimal_symbol): Change signature to use
2073 gdb::string_view instead of name+len.
2074 (elf_symtab_read): Update.
2075 (elf_rel_plt_read): Update.
2076 * mdebugread.c (parse_partial_symbols): Update.
2077 (handle_psymbol_enumerators): Update.
2078 (new_symbol): Update.
2079 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2080 to use gdb::string_view instead of name+len.
2081 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2082 * psympriv.h (add_psymbol_to_list): Likewise.
2083 * psymtab.c (add_psymbol_to_bcache): Likewise.
2084 (add_psymbol_to_list): Likewise.
2085 * stabsread.c (define_symbol): Update.
2086 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2087 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2088 (symbol_set_names): Likewise.
2089 * xcoffread.c (scan_xcoff_symtab): Update.
2090
0c921b21
CB		 20912019-10-29 Christian Biesinger <cbiesinger@google.com>
2092
2093 * symtab.h (symbol_set_names): Document that copy_name must be
2094 set to true for non-nullterminated strings.
2095 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2096 linkage_name if the entry was not found and we need to demangle.
2097
35e65c49
CB		 20982019-10-29 Christian Biesinger <cbiesinger@google.com>
2099
2100 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2101 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2102 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2103 * gdbsupport/gdb_binary_search.h: New file.
2104
ed2a2229
CB		 21052019-10-29 Christian Biesinger <cbiesinger@google.com>
2106
2107 * NEWS: Mention new --with-system-gdbinit-dir option.
2108 * config.in: Regenerate.
2109 * configure: Regenerate.
2110 * configure.ac: Add new option --with-system-gdbinit-dir.
2111 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2112 for a ".gdb" suffix.
2113 * main.c (get_init_files): Change system_gdbinit argument to
2114 a vector and return the files in SYSTEM_GDBINIT_DIR in
2115 addition to SYSTEM_GDBINIT.
2116 (captured_main_1): Update.
2117 (print_gdb_help): Update.
2118 * top.c (print_gdb_configuration): Also print the value of
2119 SYSTEM_GDBINIT_DIR.
2120
87f34879
CB		 21212019-10-28 Christian Biesinger <cbiesinger@google.com>
2122
2123 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2124 that takes gdb::string_view arguments.
2125
30baf67b
TV		 21262019-10-26 Tom de Vries <tdevries@suse.de>
2127
2128 * aarch64-linux-tdep.c: Fix typos in comments.
2129 * aarch64-tdep.c: Same.
2130 * ada-lang.c: Same.
2131 * amd64-nat.c: Same.
2132 * arc-tdep.c: Same.
2133 * arch/aarch64-insn.c: Same.
2134 * block.c: Same.
2135 * breakpoint.h: Same.
2136 * btrace.h: Same.
2137 * c-varobj.c: Same.
2138 * cli/cli-decode.c: Same.
2139 * cli/cli-script.c: Same.
2140 * cli/cli-utils.h: Same.
2141 * coff-pe-read.c: Same.
2142 * coffread.c: Same.
2143 * compile/compile-cplus-symbols.c: Same.
2144 * compile/compile-object-run.c: Same.
2145 * completer.c: Same.
2146 * corelow.c: Same.
2147 * cp-support.c: Same.
2148 * demangle.c: Same.
2149 * dwarf-index-write.c: Same.
2150 * dwarf2-frame.c: Same.
2151 * dwarf2-frame.h: Same.
2152 * eval.c: Same.
2153 * frame-base.h: Same.
2154 * frame.h: Same.
2155 * gdbcmd.h: Same.
2156 * gdbtypes.h: Same.
2157 * gnu-nat.c: Same.
2158 * guile/scm-objfile.c: Same.
2159 * i386-tdep.c: Same.
2160 * i386-tdep.h: Same.
2161 * infcall.c: Same.
2162 * infcall.h: Same.
2163 * linux-nat.c: Same.
2164 * m68k-tdep.c: Same.
2165 * macroexp.c: Same.
2166 * memattr.c: Same.
2167 * mi/mi-cmd-disas.c: Same.
2168 * mi/mi-getopt.h: Same.
2169 * mi/mi-main.c: Same.
2170 * minsyms.c: Same.
2171 * nat/aarch64-sve-linux-sigcontext.h: Same.
2172 * objfiles.h: Same.
2173 * ppc-linux-nat.c: Same.
2174 * ppc-linux-tdep.c: Same.
2175 * ppc-tdep.h: Same.
2176 * progspace.h: Same.
2177 * prologue-value.h: Same.
2178 * python/py-evtregistry.c: Same.
2179 * python/py-instruction.h: Same.
2180 * record-btrace.c: Same.
2181 * record-full.c: Same.
2182 * remote.c: Same.
2183 * rs6000-tdep.c: Same.
2184 * ser-tcp.c: Same.
2185 * sol-thread.c: Same.
2186 * sparc-sol2-tdep.c: Same.
2187 * sparc64-tdep.c: Same.
2188 * stabsread.c: Same.
2189 * symfile.c: Same.
2190 * symtab.h: Same.
2191 * target.c: Same.
2192 * tracepoint.c: Same.
2193 * tui/tui-data.h: Same.
2194 * tui/tui-io.c: Same.
2195 * tui/tui-win.c: Same.
2196 * tui/tui.c: Same.
2197 * unittests/rsp-low-selftests.c: Same.
2198 * user-regs.h: Same.
2199 * utils.c: Same.
2200 * utils.h: Same.
2201 * valarith.c: Same.
2202 * valops.c: Same.
2203 * valprint.c: Same.
2204 * valprint.h: Same.
2205 * value.c: Same.
2206 * value.h: Same.
2207 * varobj.c: Same.
2208 * x86-nat.h: Same.
2209 * xtensa-tdep.c: Same.
2210
1834d45f
AT		 22112019-10-25 Ali Tamur <tamur@google.com>
2212
2213 * charset.c (find_charset_names): Reflect API change.
2214
5396ae17
CB		 22152019-10-25 Christian Biesinger <cbiesinger@google.com>
2216
2217 * symtab.c (struct demangled_name_entry): Change demangled name
2218 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2219 part of the struct anymore.
2220 (symbol_set_names): No longer obstack allocate + copy the demangled
2221 name, just store the allocated name from bfd.
2222
93878f47
TT		 22232019-10-25 Tom Tromey <tromey@adacore.com>
2224
2225 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2226 (bsearch_cie_cmp, add_cie): Remove.
2227 (find_cie): Reimplement.
2228 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2229 (dwarf2_build_frame_info): Update.
2230
7b71fc97
L		 22312019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2232
2233 PR gdb/25126
2234 * symfile.c (reread_symbols): Call forget_cached_source_info to
2235 clear the stale source cache.
2236
cbb5a2ea
CB		 22372019-10-24 Christian Biesinger <cbiesinger@google.com>
2238
2239 * configure: Regenerate.
2240 * configure.ac: Remove code that sets python_has_threads.
2241
71737c43
CB		 22422019-10-24 Christian Biesinger <cbiesinger@google.com>
2243
2244 * config.in: Regenerate.
2245 * configure: Regenerate.
2246 * configure.ac: Remove the code that uses sed to get the python
2247 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2248
33d569b7
AB		 22492019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2250
2251 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2252 error paths.
2253
f16f7b7c
TT		 22542019-10-23 Tom Tromey <tom@tromey.com>
2255
2256 * arc-tdep.c: Remove ".." from include.
2257 * frv-tdep.c: Remove ".." from include.
2258 * lm32-tdep.c: Remove ".." from include.
2259 * microblaze-tdep.c: Remove ".." from include.
2260 * or1k-tdep.h: Remove ".." from include.
2261 * s12z-tdep.c: Remove ".." from include.
2262 * Makefile.in (OPCODES_CFLAGS): Add comment.
2263 (TOP_CFLAGS): New variable.
2264 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2265
6999161a
TT		 22662019-10-23 Tom Tromey <tom@tromey.com>
2267
2268 * Makefile.in (READLINE_DIR): Update.
2269
12e7c35e
TBA		 22702019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2271
2272 * infcall.c (call_function_by_hand_dummy): Fix the function
2273 comment. And extract out a code section into...
2274 (reserve_stack_space): ...this new function.
2275
37055cad
TBA		 22762019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2277
2278 * infcall.c (value_arg_coerce): Remove an unused parameter.
2279 (call_function_by_hand_dummy): Update the call to
2280 'value_arg_coerce'.
2281
39bcc47c
TBA		 22822019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2283
2284 * infcall.c (call_function_by_hand_dummy): Refactor.
2285
bd888c0f
TBA		 22862019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2287
2288 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2289
c12d372d
TT		 22902019-10-23 Tom Tromey <tom@tromey.com>
2291
2292 * configure: Rebuild.
2293 * configure.ac: Don't check for sigprocmask.
2294 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2295
4d0b984b
TT		 22962019-10-23 Tom Tromey <tom@tromey.com>
2297
2298 * configure: Rebuild.
2299 * acinclude.m4: Use m4_include, not sinclude.
2300
7e785608
TV		 23012019-10-23 Tom de Vries <tdevries@suse.de>
2302
2303 PR breakpoints/24687
2304 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2305
403772ef
CB		 23062019-10-22 Christian Biesinger <cbiesinger@google.com>
2307
2308 * symtab.c (struct demangled_name_entry) <language>: Change from
2309 bitfield to regular variable.
2310
3a494279
CB		 23112019-10-22 Christian Biesinger <cbiesinger@google.com>
2312
2313 * symtab.c (struct demangled_name_entry): Add a constructor.
2314 (free_demangled_name_entry): New function to call the destructor
2315 for demangled_name_entry.
2316 (create_demangled_names_hash): Pass free_demangled_name_entry to
2317 htab_create_alloc.
2318 (symbol_set_names): Call placement new for demangled_name_entry.
2319 * utils.c: No longer include xxhash.h here, now that fast_hash
2320 is inlined in the header.
2321 * utils.h: Instead, include it here.
2322
ccb1ba62
CB		 23232019-10-22 Christian Biesinger <cbiesinger@google.com>
2324
2325 * Makefile.in: Link with libxxhash.
2326 * config.in: Regenerate.
2327 * configure: Regenerate.
2328 * configure.ac: Search for libxxhash.
2329 * utils.c (fast_hash): Use xxhash if present.
2330
1a6ff1a9
CB		 23312019-10-22 Christian Biesinger <cbiesinger@google.com>
2332
2333 * utils.h (fast_hash): New function.
2334 * symtab.c (hash_demangled_name_entry): Call new function
2335 fast_hash.
2336
7bb43059
CB		 23372019-10-22 Christian Biesinger <cbiesinger@google.com>
2338
2339 * symtab.c (struct demangled_name_entry): Change type of mangled
2340 to gdb::string_view. Also adds a constructor that takes the
2341 mangled name.
2342 (hash_demangled_name_entry): Update.
2343 (eq_demangled_name_entry): Update.
2344 (free_demangled_name_entry): New function to call the destructor
2345 now that this is not a POD anymore.
2346 (create_demangled_names_hash): Pass free_demangled_name_entry to
2347 htab_create_alloc.
2348 (symbol_set_names): Update.
2349
7ba99d21
AT		 23502019-10-21 Ali Tamur <tamu@google.com>
2351
2352 * dwarf2read.c (dir_index): Change type.
2353 (file_name_index): Likewise.
2354 (line_header::include_dir_at): Change comment and implementation on
2355 whether it is DWARF 5.
2356 (line_header::is_valid_file_index): New function.
2357 (line_header::file_name_at): Change comment and implementation on
2358 whether it is DWARF 5.
2359 (line_header::file_names): Change to private field renamed as
2360 m_file_names and introduce a new accessor method.
2361 (line_header::file_names_size): New method.
2362 (line_header::include_dirs): Change to private field and rename as
2363 m_include_dirs.
2364 (dw2_get_file_names_reader): Define local var at a smaller scope and
2365 reflect API change.
2366 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2367 (process_structure_scope): Likewise.
2368 (line_header::add_include_dir): Change message and reflect renaming.
2369 (line_header::add_file_name): Likewise.
2370 (read_formatted_entries): Handle DW_FORM_data16.
2371 (dwarf_decode_line_header): Fix line header length calculation.
2372 (psymtab_include_file_name): Change comment and API.
2373 (lnp_state_machine::m_file): Update comment and reflect type change.
2374 (lnp_state_machine::record_line): Reflect type change.
2375 (dwarf_decode_lines): Reflect API change.
2376 (file_file_name): Likewise.
2377 (file_full_name): Likewise.
2378
45f47c3a
AB		 23792019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2380
2381 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2382
e5f3c0e3
TT		 23832019-10-21 Tom Tromey <tom@tromey.com>
2384
2385 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2386
a0a461e5
TT		 23872019-10-21 Tom Tromey <tom@tromey.com>
2388
2389 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2390 NM_H. Use AC_CONFIG_LINKS.
2391 * configure: Rebuild.
2392 * Makefile.in (NM_H): New variable.
2393 (generated_files): Add NM_H. Remove gcore.
2394 (nm.h, stamp-nmh): New targets.
2395
54d83b8d
TT		 23962019-10-20 Tom Tromey <tom@tromey.com>
2397
2398 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2399 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2400 obsolete comment.
2401 (put_objfile_before): Now static.
2402
23771117
SM		 24032019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2404
2405 * gdbsupport/common-utils.h (startswith): Change return type to
2406 bool.
2407
39ef2f62
CB		 24082019-10-19 Christian Biesinger <cbiesinger@google.com>
2409
2410 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2411 * breakpoint.c (bp_locations_compare): Rename to...
2412 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2413 (update_global_location_list): Use std::sort instead of qsort.
2414 * buildsym.c (compare_line_numbers): Rename to...
2415 (lte_is_less_than): ...this, and change to std::sort semantics.
2416 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2417 instead of qsort.
2418 * disasm.c (compare_lines): Rename to...
2419 (line_is_less_than): ...this, and change to std::sort semantics.
2420 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2421 of qsort.
2422 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2423 (fde_is_less_than): ...this, and change to std::sort semantics.
2424 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2425 * mdebugread.c (compare_blocks):
2426 (block_is_less_than): ...this, and change to std::sort semantics.
2427 (sort_blocks): Call std::sort instead of qsort.
2428 * objfiles.c (qsort_cmp): Rename to...
2429 (sort_cmp): ...this, and change to std::sort semantics.
2430 (update_section_map): Call std::sort instead of qsort.
2431 * remote.c (compare_pnums): Remove.
2432 (map_regcache_remote_table): Call std::sort instead of qsort.
2433 * utils.c (compare_positive_ints): Remove.
2434 * utils.h (compare_positive_ints): Remove.
2435 * xcoffread.c (compare_lte): Remove.
2436 (arrange_linetable): Call std::sort instead of qsort.
2437
f71433ee
SDJ		 24382019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2439
2440 * symfile.c (init_entry_point_info): Fix typo.
2441 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2442
85102364
TV		 24432019-10-18 Tom de Vries <tdevries@suse.de>
2444
2445 * aarch64-tdep.c: Fix typos in comments.
2446 * ada-lang.c: Same.
2447 * ada-tasks.c: Same.
2448 * alpha-tdep.c: Same.
2449 * alpha-tdep.h: Same.
2450 * amd64-nat.c: Same.
2451 * amd64-windows-tdep.c: Same.
2452 * arc-tdep.c: Same.
2453 * arc-tdep.h: Same.
2454 * arch-utils.c: Same.
2455 * arm-nbsd-tdep.c: Same.
2456 * arm-tdep.c: Same.
2457 * ax-gdb.c: Same.
2458 * blockframe.c: Same.
2459 * btrace.c: Same.
2460 * c-varobj.c: Same.
2461 * coff-pe-read.c: Same.
2462 * coffread.c: Same.
2463 * cris-tdep.c: Same.
2464 * darwin-nat.c: Same.
2465 * dbxread.c: Same.
2466 * dcache.c: Same.
2467 * disasm.c: Same.
2468 * dtrace-probe.c: Same.
2469 * dwarf-index-write.c: Same.
2470 * dwarf2-frame-tailcall.c: Same.
2471 * dwarf2-frame.c: Same.
2472 * dwarf2read.c: Same.
2473 * eval.c: Same.
2474 * exceptions.c: Same.
2475 * fbsd-tdep.c: Same.
2476 * findvar.c: Same.
2477 * frame.c: Same.
2478 * frv-tdep.c: Same.
2479 * gnu-v3-abi.c: Same.
2480 * go32-nat.c: Same.
2481 * h8300-tdep.c: Same.
2482 * hppa-tdep.c: Same.
2483 * i386-linux-tdep.c: Same.
2484 * i386-tdep.c: Same.
2485 * ia64-libunwind-tdep.c: Same.
2486 * ia64-tdep.c: Same.
2487 * infcmd.c: Same.
2488 * infrun.c: Same.
2489 * linespec.c: Same.
2490 * linux-nat.c: Same.
2491 * linux-thread-db.c: Same.
2492 * machoread.c: Same.
2493 * mdebugread.c: Same.
2494 * mep-tdep.c: Same.
2495 * mn10300-tdep.c: Same.
2496 * namespace.c: Same.
2497 * objfiles.c: Same.
2498 * opencl-lang.c: Same.
2499 * or1k-tdep.c: Same.
2500 * osabi.c: Same.
2501 * ppc-linux-nat.c: Same.
2502 * ppc-linux-tdep.c: Same.
2503 * ppc-sysv-tdep.c: Same.
2504 * printcmd.c: Same.
2505 * procfs.c: Same.
2506 * record-btrace.c: Same.
2507 * record-full.c: Same.
2508 * remote-fileio.c: Same.
2509 * remote.c: Same.
2510 * rs6000-tdep.c: Same.
2511 * s12z-tdep.c: Same.
2512 * score-tdep.c: Same.
2513 * ser-base.c: Same.
2514 * ser-go32.c: Same.
2515 * skip.c: Same.
2516 * sol-thread.c: Same.
2517 * solib-svr4.c: Same.
2518 * solib.c: Same.
2519 * source.c: Same.
2520 * sparc-nat.c: Same.
2521 * sparc-sol2-tdep.c: Same.
2522 * sparc-tdep.c: Same.
2523 * sparc64-tdep.c: Same.
2524 * stabsread.c: Same.
2525 * stack.c: Same.
2526 * symfile.c: Same.
2527 * symtab.c: Same.
2528 * target-descriptions.c: Same.
2529 * target-float.c: Same.
2530 * thread.c: Same.
2531 * utils.c: Same.
2532 * valops.c: Same.
2533 * valprint.c: Same.
2534 * value.c: Same.
2535 * varobj.c: Same.
2536 * windows-nat.c: Same.
2537 * xcoffread.c: Same.
2538 * xstormy16-tdep.c: Same.
2539 * xtensa-tdep.c: Same.
2540
c5adaa19
TT		 25412019-10-17 Tom Tromey <tromey@adacore.com>
2542
2543 * configure: Rebuild.
2544 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2545 in AC_CONFIG_FILES invocation.
2546 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2547 new-style config.status invocation.
2548
405feb71
TV		 25492019-10-17 Tom de Vries <tdevries@suse.de>
2550
2551 * arm-nbsd-nat.c: Fix typos in comments.
2552 * arm-tdep.c: Same.
2553 * darwin-nat-info.c: Same.
2554 * dwarf2read.c: Same.
2555 * elfread.c: Same.
2556 * event-top.c: Same.
2557 * findvar.c: Same.
2558 * gdbtypes.c: Same.
2559 * hppa-tdep.c: Same.
2560 * i386-tdep.c: Same.
2561 * jit.c: Same.
2562 * main.c: Same.
2563 * mdebugread.c: Same.
2564 * moxie-tdep.c: Same.
2565 * nto-procfs.c: Same.
2566 * osabi.c: Same.
2567 * ppc-linux-tdep.c: Same.
2568 * remote.c: Same.
2569 * riscv-tdep.c: Same.
2570 * s390-tdep.c: Same.
2571 * sh-tdep.c: Same.
2572 * sparc-linux-tdep.c: Same.
2573 * sparc-nat.c: Same.
2574 * stack.c: Same.
2575 * target-descriptions.c: Same.
2576 * top.c: Same.
2577 * varobj.c: Same.
2578
befcd486
TT		 25792019-10-16 Tom Tromey <tom@tromey.com>
2580
2581 * objfiles.h (struct objfile) <original_name>: Now const.
2582
17bfe554
CB		 25832019-10-16 Christian Biesinger <cbiesinger@google.com>
2584
2585 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2586 pass on to sigsetjmp's second argument.
2587 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2588
950b7495
KS		 25892019-10-16 Keith Seitz <keiths@redhat.com>
2590
2591 PR gdb/23567
2592 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2593 sections whose size is greater than the file size.
2594
ff371ec9
JW		 25952019-10-16 Jim Wilson <jimw@sifive.com>
2596
2597 * riscv-tdep.c (riscv_gcc_target_options): New.
2598 (riscv_gnu_triplet_regexp): New.
2599 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2600 set_gdbarch_gnu_triplet_regexp.
2601
fec4e896
CB		 26022019-10-16 Christian Biesinger <cbiesinger@google.com>
2603
2604 * Makefile.in: Add xml-builtin.h.
2605 * features/feature_to_c.sh: Add an include for xml-builtin.h
2606 to ensure that the compiler checks that the types match.
2607 * xml-builtin.h: New file.
2608 * xml-support.c (fetch_xml_builtin): Add missing const.
2609 * xml-support.h: Remove declaration of xml_builtins.
2610
d10eccaa
TV		 26112019-10-16 Tom de Vries <tdevries@suse.de>
2612
2613 PR tdep/25096
2614 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2615 (amd64_classify_aggregate): ... here.
2616 (amd64_classify_aggregate_field): Handled fiels of nested structs
2617 recursively.
2618
745ff14e
TV		 26192019-10-16 Tom de Vries <tdevries@suse.de>
2620
2621 PR tdep/24104
2622 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2623 that handles 'theclass'.
2624
791b7405
AB		 26252019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2626
2627 * linespec.c (decode_digits_ordinary): Update comment.
2628 * make-target-delegates: No longer need to handle VEC case.
2629 * memrange.c (normalize_mem_ranges): Update comment.
2630 * namespace.c (add_using_directive): Update comment.
2631 * objc-lang.c (uniquify_strings): Update comment.
2632 * ppc-linux-nat.c (struct thread_points): Update comment.
2633 * probe.h (find_probes_in_objfile): Update comment.
2634 * target.h (enum flash_preserve_mode): Update comment.
2635 * varobj.c (varobj_restrict_range): Update comment.
2636 * varobj.h (varobj_list_children): Update comment.
2637
0dc32745
AB		 26382019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2639
2640 * Makefile.in: Remove references to vec.h and vec.c.
2641 * aarch64-tdep.c: No longer include vec.h.
2642 * ada-lang.c: Likewise.
2643 * ada-lang.h: Likewise.
2644 * arm-tdep.c: Likewise.
2645 * ax.h: Likewise.
2646 * breakpoint.h: Likewise.
2647 * charset.c: Likewise.
2648 * cp-support.h: Likewise.
2649 * dtrace-probe.c: Likewise.
2650 * dwarf2read.c: Likewise.
2651 * extension.h: Likewise.
2652 * gdb_bfd.c: Likewise.
2653 * gdbsupport/gdb_vecs.h: Likewise.
2654 * gdbsupport/vec.c: Remove.
2655 * gdbsupport/vec.h: Remove.
2656 * gdbthread.h: Likewise.
2657 * guile/scm-type.c: Likewise.
2658 * inline-frame.c: Likewise.
2659 * machoread.c: Likewise.
2660 * memattr.c: Likewise.
2661 * memrange.h: Likewise.
2662 * namespace.h: Likewise.
2663 * nat/linux-btrace.h: Likewise.
2664 * osdata.c: Likewise.
2665 * parser-defs.h: Likewise.
2666 * progspace.h: Likewise.
2667 * python/py-type.c: Likewise.
2668 * record-btrace.c: Likewise.
2669 * rust-exp.y: Likewise.
2670 * solib-target.c: Likewise.
2671 * stap-probe.c: Likewise.
2672 * target-descriptions.c: Likewise.
2673 * target-memory.c: Likewise.
2674 * target.h: Likewise.
2675 * varobj.c: Likewise.
2676 * varobj.h: Likewise.
2677 * xml-support.h: Likewise.
2678
ae640021
AB		 26792019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2680
2681 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2682 Update for new std::vector based implementation.
2683 (process_psymtab_comp_unit_reader): Likewise.
2684 (scan_partial_symbols): Likewise.
2685 (recursively_compute_inclusions): Likewise.
2686 (compute_compunit_symtab_includes): Likewise.
2687 (process_imported_unit_die): Likewise.
2688 (queue_and_load_dwo_tu): Likewise.
2689 (follow_die_sig_1): Likewise.
2690 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2691 (typedef dwarf2_per_cu_ptr): Remove.
2692 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2693 function.
2694 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2695 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2696 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2697 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2698 std::vector.
2699
55dfc88f
TT		 27002019-10-15 Tom Tromey <tromey@adacore.com>
2701
2702 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2703 TID.
2704
96b49c5e
TT		 27052019-10-15 Tom Tromey <tromey@adacore.com>
2706
2707 * windows-nat.c (windows_nat_target::fetch_registers)
2708 (windows_nat_target::store_registers): Rename "pid" to "tid".
2709
953cff56
TT		 27102019-10-15 Tom Tromey <tromey@adacore.com>
2711
2712 * gdbarch.h, gdbarch.c: Rebuild.
2713 * gdbarch.sh (gcc_target_options): Change return type to
2714 std::string.
2715 * compile/compile.c (get_args): Update.
2716 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2717 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2718 std::string.
2719 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2720 std::string.
2721 * arch-utils.c (default_gcc_target_options): Return std::string.
2722 * arch-utils.h (default_gcc_target_options): Return std::string.
2723 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2724
81e6b8eb
CB		 27252019-10-15 Christian Biesinger <cbiesinger@google.com>
2726
2727 * breakpoint.c (breakpoint_chain): Make static.
2728 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2729 of accessing breakpoint_chain.
2730
95da600f
CB		 27312019-10-15 Christian Biesinger <cbiesinger@google.com>
2732
2733 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2734 to a gdb::function_view and return value to bool.
2735 * breakpoint.h (iterate_over_breakpoints): Likewise.
2736 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2737 (pop_dummy_frame): Update.
2738 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2739 (gdbscm_breakpoints): Update.
2740 * python/py-breakpoint.c (build_bp_list): Update.
2741 (gdbpy_breakpoints): Update.
2742 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2743 Update.
2744 (bpfinishpy_handle_stop): Update.
2745 (bpfinishpy_handle_exit): Update.
2746 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2747 (svr4_update_solib_event_breakpoints): Update.
2748
ba18312d
AA		 27492019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2750
2751 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2752 when unwrapping single-field structs.
2753
6acc1a0b
SM		 27542019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2755
2756 * dwarf2read.c: Remove includes.
2757
284782de
SM		 27582019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2759
2760 * ui-out.c (ui_out::call_do_message): Silence
2761 -Wformat-nonliteral warning.
2762
073bbbb0
SM		 27632019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2764
2765 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2766 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2767 include: readline/tilde.h.
2768
7b9a15e1
CB		 27692019-10-12 Christian Biesinger <cbiesinger@google.com>
2770
2771 * remote.c (remote_target::get_trace_status): Remove declaration of
2772 trace_regblock_size.
2773
cc8dee1f
CB		 27742019-10-12 Christian Biesinger <cbiesinger@google.com>
2775
2776 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2777 (show_user): Remove declaration of cmdlist.
2778 * cli/cli-cmds.h (max_user_call_depth): Declare.
2779 * cli/cli-script.c (execute_user_command): Remove declaration
2780 of max_user_call_depth.
2781
a83d4ef6
JW		 27822019-10-11 Jim Wilson <jimw@sifive.com>
2783
5f93c5a6
JW		 2784 * gdbsupport/print-utils.h (pulongest): Fix comment.
2785 (plongest): Likewise.
2786 (phex): Add missing comment, mention leading zeros.
2787 (phex_nz): Add mention of no leading zeros to comment.
2788
a83d4ef6
JW		 2789 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2790 plongest instead of unsigned long long cast.
2791
26344e0c
CB		 27922019-10-10 Christian Biesinger <cbiesinger@google.com>
2793
2794 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2795 for external_editor_command and gdbtk_test.
2796
c2c440a9
CB		 27972019-10-10 Christian Biesinger <cbiesinger@google.com>
2798
2799 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2800 * varobj.c (varobjdebug): Move comment to...
2801 * varobj.h (varobjdebug): ...here, and declare.
2802
a31bff9d
TT		 28032019-10-09 Tom Tromey <tom@tromey.com>
2804
2805 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2806 erase_data_content.
2807
7523da63
TT		 28082019-10-09 Tom Tromey <tom@tromey.com>
2809
2810 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2811 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2812 * tui/tui-command.c (tui_cmd_window::resize)
2813 (tui_refresh_cmd_win): Update.
2814 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2815 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2816 * tui/tui-data.c (~tui_gen_win_info): Remove.
2817 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2818 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2819 (tui_redisplay_readline, tui_mld_flush)
2820 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2821 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2822 (tui_data_window::erase_data_content)
2823 (tui_data_item_window::rerender)
2824 (tui_data_item_window::refresh_window): Update.
2825 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2826 (box_win, tui_gen_win_info::make_window)
2827 (tui_gen_win_info::make_visible): Update.
2828 (tui_delete_win): Remove.
2829 * tui/tui-winsource.c
2830 (tui_source_window_base::do_erase_source_content): Update.
2831 (tui_show_source_line, tui_source_window_base::update_tab_width)
2832 (tui_source_window_base::update_exec_info): Update.
2833 * tui/tui-data.h (struct curses_deleter): New.
2834 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2835 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2836
a7798e7f
TT		 28372019-10-09 Tom Tromey <tom@tromey.com>
2838
2839 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2840
5c45899e
TT		 28412019-10-09 Tom Tromey <tom@tromey.com>
2842
2843 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2844 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2845
6d7fd9aa
TT		 28462019-10-09 Tom Tromey <tom@tromey.com>
2847
2848 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2849 window height directly.
2850 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2851 declare.
2852 * tui/tui-layout.c (tui_default_win_height): Remove.
2853 (tui_default_win_viewport_height): Remove.
2854
d2dd1084
TT		 28552019-10-09 Tom Tromey <tom@tromey.com>
2856
2857 * tui/tui.h: Remove comments.
2858
cff32449
TV		 28592019-10-09 Tom de Vries <tdevries@suse.de>
2860
2861 * python/lib/gdb/printer/bound_registers.py: Use
2862 '^builtin_type_bound128' as regexp argument for
2863 add_builtin_pretty_printer.
2864
6a25e8a2
CB		 28652019-10-09 Christian Biesinger <cbiesinger@google.com>
2866
2867 * guile/guile.c (guile_extension_script_ops): Remove forward
2868 declaration and mark as static.
2869 (guile_script_ops): Likewise.
2870 (extension_language_guile): Move further down in the file so
2871 it can reference the definitions for guile_{extension_,}script_ops.
2872
6d9d6da4
AA		 28732019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2874
2875 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2876 except SORTL, DFLTCC, and KDSA.
2877
3abea05d
TT		 28782019-10-08 Tom Tromey <tromey@adacore.com>
2879
2880 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2881 (struct safe_symbol_file_add_args): Remove.
2882
dde996e2
TT		 28832019-10-08 Tom Tromey <tromey@adacore.com>
2884
2885 * windows-nat.c: Don't include buildsym-legacy.h.
2886
cd6fdaa1
TT		 28872019-10-08 Tom Tromey <tromey@adacore.com>
2888
2889 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2890
79bb1944
CB		 28912019-10-08 Christian Biesinger <cbiesinger@google.com>
2892
2893 * gdbtypes.c (overload_debug): Move comment to header.
2894 * gdbtypes.h (overload_debug): Declare.
2895 * valops.c: Remove declaration of overload_debug, instead
2896 include gdbtypes.h.
2897
34916edc
CB		 28982019-10-08 Christian Biesinger <cbiesinger@google.com>
2899
2900 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2901 through _().
2902 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2903 move comment...
2904 * language.h (lang_frame_mismatch_warn): ... here. Also add
2905 declaration.
2906 * top.c (lang_frame_mismatch_warn): Remove declaration.
2907 (check_frame_language_change): Pass lang_frame_mismatch_warn
2908 through _().
2909
bad5c026
CB		 29102019-10-07 Christian Biesinger <cbiesinger@google.com>
2911
2912 * c-lang.h (vtbl_ptr_name): Declare.
2913 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2914 it from the header.
2915 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2916
51f1fdc3
CB		 29172019-10-07 Christian Biesinger <cbiesinger@google.com>
2918
2919 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2920 gdb_static_assert.
2921
30d1f018
WP		 29222019-10-07 Weimin Pan <weimin.pan@oracle.com>
2923
606813d5
WP		 2924 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2925 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP		 2926 * ctfread.c: New file.
2927 * ctfread.h: New file.
2928 * elfread.c: Include ctfread.h.
2929 (struct elfinfo text_p): New member ctfsect.
2930 (elf_locate_sections): Mark CTF section.
2931 (elf_symfile_read): Call elfctf_build_psymtabs.
2932 * Makefile.in (LIBCTF): Add.
2933 (CLIBS): Use it.
2934 (CDEPS): Likewise.
2935 (DIST): Add ctfread.c.
606813d5
WP		 2936
29372019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2938
2939 * ctfread.c (struct nextfield): Renamed to ...
2940 (struct ctf_nextfield): ... this.
2941 (struct field_info): Renamed to ...
2942 (strut ctf_field_info): ... this.
2943 (attach_fields_to_type): Update for renamed structures.
2944 (ctf_add_member_cb): Likewise.
2945 (ctf_add_enum_member_cb): Likewise.
2946 (process_struct_members): Likewise.
2947 (process_enum_type): Likewise.
30d1f018 2948
518fe38c
WP		 29492019-10-07 Weimin Pan <weimin.pan@oracle.com>
2950
2951 * tracectf.h: Rename, was ctf.h.
2952 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2953 * tracefile.c: Likewise.
2954 * tracepoint.c: Remove unused include ctf.h.
2955 * mi/mi-main.c: Likewise.
2956 * Makefile.in Replace ctf.c with tracectf.c.
2957
225f296a
JB		 29582019-10-06 Joel Brobecker <brobecker@adacore.com>
2959
2960 * version.in: Change version number to "9.0.50.DATE-git".
2961
77c2dba3
TT		 29622019-10-03 Tom Tromey <tom@tromey.com>
2963
2964 PR rust/24976:
2965 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2966
179aed7f
AB		 29672019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2968
2969 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2970 cp_search_name_hash.
2971 * NEWS: Add entry about nested function support.
2972
0a4b0913
AB		 29732019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
2974 Andrew Burgess <andrew.burgess@embecosm.com>
2975
2976 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2977 for nested static variables when searchin VAR_DOMAIN.
2978 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2979 global scope, update comment.
2980 (add_partial_subprogram): Call add_partial_subprogram recursively
2981 for nested subroutines when processinng Fortran.
2982 (load_partial_dies): Process the child entities of a subprogram
2983 when processing Fortran.
2984 (partial_die_parent_scope): Handle building scope
2985 for Fortran nested functions.
2986 (process_die): Record that nested functions have a scope.
2987 (new_symbol): Always record Fortran subprograms on the global
2988 symbol list.
2989 (determine_prefix): How to build the prefix for Fortran
2990 subprograms.
2991
d8c06f22
AB		 29922019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2993
2994 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2995 have just sent the thread a SIGSTOP and are waiting for it to
2996 arrive.
2997
a8b3b8e9
AB		 29982019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2999
3000 * btrace.c (btrace_add_pc): Remove whitespace before the template
3001 parameter in 'std::vector <...>'.
3002 (parse_xml_btrace_block): Likewise.
3003 (btrace_maint_decode_pt): Likewise.
3004 (btrace_maint_update_packets): Likewise.
3005 (btrace_maint_print_packets): Likewise.
3006 * btrace.h (struct btrace_maint_info): Likewise.
3007 * dwarf2read.c (struct type_unit_group): Likewise.
3008 (build_type_psymtabs_reader): Likewise.
3009 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3010 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3011 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3012
4d825eab
TV		 30132019-10-03 Tom de Vries <tdevries@suse.de>
3014
3015 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3016 the first line of the help text for set/show style metadata.
3017
80fd2826
TT		 30182019-10-02 Tom Tromey <tromey@adacore.com>
3019
3020 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3021 * gdbsupport/common-inferior.c: New file.
3022 * infcmd.c (startup_with_shell): Don't define.
3023 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3024 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3025 * inferior.h (startup_with_shell): Don't declare.
3026
70054538
CB		 30272019-10-02 Christian Biesinger <cbiesinger@google.com>
3028
3029 * gdbsupport/gdb_assert.h: Include errors.h.
3030 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3031
37f6a7f4
TT		 30322019-10-02 Tom Tromey <tromey@adacore.com>
3033
3034 * NEWS: Add $_ada_exception entry.
3035 * ada-lang.c (struct ada_catchpoint): Add constructor.
3036 <m_kind>: New member.
3037 (allocate_location_exception, re_set_exception): Remove
3038 "ex" parameter.
3039 (should_stop_exception): Compute $_ada_exception.
3040 (check_status_exception, print_it_exception)
3041 (print_one_exception, print_mention_exception): Remove
3042 "ex" parameter.
3043 (allocate_location_catch_exception, re_set_catch_exception)
3044 (check_status_exception, print_it_catch_exception)
3045 (print_one_catch_exception, print_mention_catch_exception)
3046 (print_recreate_catch_exception)
3047 (allocate_location_catch_exception_unhandled)
3048 (re_set_catch_exception_unhandled)
3049 (check_status_exception, print_it_catch_exception_unhandled)
3050 (print_one_catch_exception_unhandled)
3051 (print_mention_catch_exception_unhandled)
3052 (print_recreate_catch_exception_unhandled)
3053 (allocate_location_catch_assert, re_set_catch_assert)
3054 (check_status_assert, print_it_catch_assert)
3055 (print_one_catch_assert, print_mention_catch_assert)
3056 (print_recreate_catch_assert)
3057 (allocate_location_catch_handlers, re_set_catch_handlers)
3058 (check_status_handlers, print_it_catch_handlers)
3059 (print_one_catch_handlers, print_mention_catch_handlers)
3060 (print_recreate_catch_handlers): Remove.
3061 (create_ada_exception_catchpoint): Update.
3062 (initialize_ada_catchpoint_ops): Update.
3063
fccf9de1
TT		 30642019-10-02 Tom Tromey <tromey@adacore.com>
3065
3066 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3067 (create_excep_cond_exprs): Simplify exception string computation.
3068 (ada_exception_catchpoint_cond_string): Likewise.
3069
4b610737
TT		 30702019-10-02 Tom Tromey <tromey@adacore.com>
3071
3072 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3073 * ada-lang.c (lesseq_defined_than): Handle
3074 LOC_STATIC.
3075 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3076 parameter.
3077 (dwarf2_has_info): Likewise.
3078 (new_symbol): Set maybe_copied on symbol when
3079 appropriate.
3080 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3081 parameter.
3082 <can_copy>: New member.
3083 * elfread.c (record_minimal_symbol): Set maybe_copied
3084 on symbol when appropriate.
3085 (elf_symfile_read): Update call to dwarf2_has_info.
3086 * minsyms.c (lookup_minimal_symbol_linkage): New
3087 function.
3088 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3089 * symtab.c (get_symbol_address, get_msymbol_address):
3090 New functions.
3091 * symtab.h (get_symbol_address, get_msymbol_address):
3092 Declare.
3093 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3094 maybe_copied.
3095 (struct symbol, struct minimal_symbol) <maybe_copied>:
3096 New member.
3097
1dd58850
TT		 30982019-10-02 Tom Tromey <tromey@adacore.com>
3099
3100 * source.c (struct current_source_location): New.
3101 (current_source_key): New global.
3102 (current_source_symtab, current_source_line)
3103 (current_source_pspace): Remove.
3104 (get_source_location): New function.
3105 (get_current_source_symtab_and_line)
3106 (set_default_source_symtab_and_line)
3107 (set_current_source_symtab_and_line)
3108 (clear_current_source_symtab_and_line, select_source_symtab)
3109 (info_source_command, print_source_lines_base)
3110 (info_line_command, search_command_helper, _initialize_source):
3111 Update.
3112
5c281dbb
TT		 31132019-10-02 Tom Tromey <tromey@adacore.com>
3114
3115 * source.c (select_source_symtab): Don't call
3116 decode_line_with_current_source.
3117
d3d32391
AB		 31182019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3119
3120 * symtab.c (lookup_global_symbol): Search global block.
3121
38583298
TT		 31222019-10-02 Tom Tromey <tromey@adacore.com>
3123
3124 * coffread.c (process_coff_symbol): Update.
3125 * dwarf2read.c (var_decode_location, new_symbol): Update.
3126 * mdebugread.c (parse_symbol): Update.
3127 * objfiles.c (relocate_one_symbol): Update.
3128 * stabsread.c (define_symbol, fix_common_block)
3129 (scan_file_globals): Update.
3130 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3131 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3132 * xcoffread.c (process_xcoff_symbol): Update.
3133
9344c18f
AA		 31342019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3135
3136 * MAINTAINERS: Update my email address.
3137
df07e2c7
AB		 31382019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3139
3140 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3141 std::vector.
3142 (build_type_psymtabs_reader): Update for std::vector.
3143 (build_type_psymtab_dependencies): Likewise.
3144 * dwarf2read.h: Remove use of DEF_VEC_P.
3145 (typedef sig_type_ptr): Delete.
3146
554ac434
AB		 31472019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3148
3149 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3150 to std::vector.
3151 (btrace_maint_decode_pt): Likewise, and move allocation of the
3152 vector outside of the loop.
3153 (btrace_maint_update_packets): Update to handle change from VEC to
3154 std::vector.
3155 (btrace_maint_print_packets): Likewise.
3156 (maint_info_btrace_cmd): Likewise.
3157 * btrace.h: Remove use of DEF_VEC_O.
3158 (typedef btrace_pt_packet_s): Delete.
3159 (struct btrace_maint_info) <packets>: Change fromm VEC to
3160 std::vector.
3161 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3162
46f29a9a
AB		 31632019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3164
3165 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3166 make accesses into the vector constant references.
3167 (btrace_add_pc): Update for std::vector.
3168 (btrace_stitch_bts): Likewise.
3169 (parse_xml_btrace_block): Likewise.
3170 (btrace_maint_update_packets): Likewise.
3171 (btrace_maint_print_packets): Likewise.
3172 (maint_info_btrace_cmd): Likewise.
3173 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3174 std::vector.
3175 (btrace_data::empty): Likewise.
3176 (btrace_data_append): Likewise.
3177 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3178 (typedef btrace_block_s): Delete.
3179 (struct btrace_block): Add constructor.
3180 (struct btrace_data_bts) <blocks>: Change to std::vector.
3181 * nat/linux-btrace.c (perf_event_read_bts): Update for
3182 std::vector.
3183 (linux_read_bts): Likewise.
3184
d770d56f
TT		 31852019-10-01 Tom Tromey <tom@tromey.com>
3186
3187 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3188
9d636d67
TT		 31892019-10-01 Tom Tromey <tom@tromey.com>
3190
3191 * stack.c (print_frame, info_frame_command_core): Use
3192 styled_string.
3193 * linux-thread-db.c (try_thread_db_load_1)
3194 (try_thread_db_load_from_pdir_1): Use styled_string.
3195 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3196 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3197 (maybe_print_unsupported_script_warning)
3198 (maybe_print_script_not_found_warning): Use styled_string.
3199 * ada-lang.c (user_select_syms): Use styled_string.
3200
7f6aba03
TT		 32012019-10-01 Tom Tromey <tom@tromey.com>
3202
3203 * p-lang.c (pascal_printstr): Use metadata style.
3204 * value.c (show_convenience): Use metadata style.
3205 * valprint.c (valprint_check_validity, val_print_optimized_out)
3206 (val_print_not_saved, val_print_unavailable)
3207 (val_print_invalid_address, generic_val_print, val_print)
3208 (value_check_printable, val_print_array_elements): Use metadata
3209 style.
3210 * ui-out.h (class ui_out) <field_fmt>: New overload.
3211 <do_field_fmt>: Add style parameter.
3212 * ui-out.c (ui_out::field_fmt): New overload.
3213 * typeprint.c (type_print_unknown_return_type)
3214 (val_print_not_allocated, val_print_not_associated): Use metadata
3215 style.
3216 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3217 parameter.
3218 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3219 * tracepoint.c (tvariables_info_1): Use metadata style.
3220 * stack.c (print_frame_arg, print_frame_info, print_frame)
3221 (info_frame_command_core): Use metadata style.
3222 * skip.c (info_skip_command): Use metadata style.
3223 * rust-lang.c (rust_print_enum): Use metadata style.
3224 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3225 metadata style.
3226 * python/py-framefilter.c (py_print_single_arg): Use metadata
3227 style.
3228 * printcmd.c (do_one_display, print_variable_and_value): Use
3229 metadata style.
3230 * p-valprint.c (pascal_val_print)
3231 (pascal_object_print_value_fields): Use metadata style.
3232 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3233 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3234 parameter.
3235 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3236 * m2-valprint.c (m2_print_long_set): Use metadata style.
3237 * m2-typeprint.c (m2_print_type): Use metadata style.
3238 * infcmd.c (print_return_value_1): Use metadata style.
3239 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3240 * f-valprint.c (info_common_command_for_block): Use metadata
3241 style.
3242 * f-typeprint.c (f_type_print_base): Use metadata style.
3243 * expprint.c (print_subexp_standard): Use metadata style.
3244 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3245 * cli/cli-style.h (class cli_style_option): Add constructor.
3246 (metadata_style): Declare.
3247 * cli/cli-style.c (metadata_style): New global.
3248 (_initialize_cli_style): Register metadata style.
3249 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3250 parameter.
3251 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3252 * c-typeprint.c (c_type_print_base_struct_union)
3253 (c_type_print_base_1): Use metadata style.
3254 * breakpoint.c (watchpoint_value_print)
3255 (print_one_breakpoint_location): Use metadata style.
3256 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3257 style.
3258 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3259 style.
3260 * ada-valprint.c (val_print_packed_array_elements, printstr)
3261 (print_field_values, ada_val_print_ref, ada_val_print): Use
3262 metadata style.
3263 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3264 style.
3265 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3266 style.
3267 * ada-lang.c (user_select_syms): Use metadata style.
3268
14309bb6
TT		 32692019-10-01 Tom Tromey <tom@tromey.com>
3270
3271 * cli/cli-cmds.c (pwd_command): Style output.
3272
6a831f06
PA		 32732019-10-01 Pedro Alves <palves@redhat.com>
3274 Tom Tromey <tom@tromey.com>
3275
3276 * symtab.c (print_symbol_info): Use %ps.
3277 (print_msymbol_info): Use %ps.
3278 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3279 * printcmd.c (print_variable_and_value): Use %ps.
3280 * macrocmd.c (show_pp_source_pos): Use %ps.
3281 * infrun.c (print_exited_reason): Use ui_out::message.
3282 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3283 (describe_other_breakpoints): Use ui_out::message and new
3284 formats.
3285 (say_where): Use new formats.
3286 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3287 and new formats.
3288
2a3c1174
PA		 32892019-10-01 Pedro Alves <palves@redhat.com>
3290 Tom Tromey <tom@tromey.com>
3291
3292 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3293 (test_gdb_formats): New function.
3294 (run_tests): Call it.
3295 (test_format_specifier): Update.
3296 * utils.h (fputs_filtered): Update comment.
3297 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3298 (fputs_styled_unfiltered): Declare.
3299 * utils.c (fputs_styled_unfiltered): New function.
3300 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3301 (vfprintf_filtered): Update.
3302 (vfprintf_unfiltered, vprintf_filtered): Update.
3303 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3304 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3305 disallow_ui_out_field>: New constants.
3306 (enum class field_kind): New.
3307 (struct base_field_s, struct signed_field_s): New.
3308 (signed_field): New function.
3309 (struct string_field_s): New.
3310 (string_field): New function.
3311 (struct styled_string_s): New.
3312 (styled_string): New function.
3313 (class ui_out) <message>: Add comment.
3314 <vmessage, call_do_message>: New methods.
3315 <do_message>: Add style parameter.
3316 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3317 methods.
3318 (ui_out::message): Rewrite.
3319 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3320 parameter.
3321 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3322 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3323 gdb_extensions parameter.
3324 (class format_piece): Add parameter to constructor.
3325 (n_int_args): New field.
3326 * gdbsupport/format.c (format_pieces::format_pieces): Add
3327 gdb_extensions parameter. Handle '*'.
3328 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3329 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3330 vfprintf_styled_no_gdbfmt.
3331 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3332 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3333 unfiltered output.
3334 * ui-style.h (struct ui_file_style) <ptr>: New method.
3335
0dfe5bfb
TT		 33362019-10-01 Tom Tromey <tom@tromey.com>
3337
3338 * unittests/format_pieces-selftests.c: Update. Add final format.
3339 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3340 empty literal pieces.
3341
e43b10e1
TT		 33422019-10-01 Tom Tromey <tom@tromey.com>
3343
3344 * ui-out.h (enum class ui_out_style_kind): Remove.
3345 (class ui_out) <field_string, field_stsream, do_field_string>:
3346 Change type of "style".
3347 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3348 (ui_out::field_string): Update.
3349 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3350 of "style".
3351 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3352 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3353 * stack.c (print_frame_arg, print_frame_info, print_frame):
3354 Update.
3355 * source.c (print_source_lines_base): Update.
3356 * solib.c (info_sharedlibrary_command): Update.
3357 * skip.c (info_skip_command): Update.
3358 * record-btrace.c (btrace_call_history_src_line)
3359 (btrace_call_history): Update.
3360 * python/py-framefilter.c (py_print_frame): Update.
3361 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3362 "style".
3363 * mi/mi-out.c (mi_ui_out::do_table_header)
3364 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3365 (mi_ui_out::do_field_string): Update.
3366 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3367 Update.
3368 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3369 "style".
3370 * cli-out.c (cli_ui_out::do_table_header)
3371 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3372 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3373 (cli_ui_out::do_field_fmt): Update.
3374 * breakpoint.c (print_breakpoint_location): Update.
3375 (update_static_tracepoint): Update.
3376
cd7c32c3
PW		 33772019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3378
3379 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3380 conversion of gdb_datadir.
3381 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3382 remove not needed c_str ().
3383
8fe0f950
AT		 33842019-09-30 Ali Tamur <tamur@google.com>
3385
3386 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3387 (dwarf2_string_attr): Likewise.
3388
5f48f8f3
AT		 33892019-09-30 Ali Tamur <tamur@google.com>
3390
3391 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3392 (process_full_type_unit): Likewise.
3393 (dump_die_shallow): Likewise.
3394 (cu_debug_loc_section): Likewise.
3395
6fb08628
CB		 33962019-09-28 Christian Biesinger <cbiesinger@google.com>
3397
3398 * minsyms.c (compare_minimal_symbols): Rename to...
3399 (minimal_symbol_is_less_than): ...this, and adjust to STL
3400 conventions (return bool, take arguments as references)
3401 (minimal_symbol_reader::install): Call std::sort instead
3402 of qsort.
3403
c7ee338a
CB		 34042019-09-29 Christian Biesinger <cbiesinger@google.com>
3405
3406 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3407 hash and why.
3408 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3409 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3410
703a86c2
SM		 34112019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3412
3413 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3414 * psympriv.h (add_psymbol_to_list): Move comment here and update
3415 it.
3416
0df0352a
TV		 34172019-09-29 Tom de Vries <tdevries@suse.de>
3418
3419 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3420 Use $tmpdir/$(basename "$output_file").dwz instead of
3421 "${output_file}.dwz".
3422
ad75efa6
SM		 34232019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3424
3425 PR gdb/25045
3426 * hppa-linux-nat.c: Include gdbarch.h.
3427
ececd218
CB		 34282019-09-26 Christian Biesinger <cbiesinger@google.com>
3429
3430 * blockframe.c (find_pc_partial_function): Change return type to bool.
3431 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3432 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3433 (stub_gnu_ifunc_resolve_name): Likewise.
3434 * symtab.c (compare_filenames_for_search): Likewise.
3435 (compare_glob_filenames_for_search): Likewise.
3436 (matching_obj_sections): Likewise.
3437 (symbol_matches_domain): Likewise.
3438 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3439 (find_line_pc): Change return type to bool.
3440 (find_line_pc_range): Likewise.
3441 (producer_is_realview): Likewise.
3442 * symtab.h (symbol_matches_domain): Likewise.
3443 (find_pc_partial_function): Likewise.
3444 (find_pc_line_pc_range): Likewise.
3445 (in_gnu_ifunc_stub): Likewise.
3446 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3447 (find_line_pc): Likewise.
3448 (find_line_pc_range): Likewise.
3449 (matching_obj_sections): Likewise.
3450 (find_line_symtab): Change out parameter to bool.
3451 (producer_is_realview): Change return type to bool.
3452 (compare_filenames_for_search): Likewise.
3453 (compare_glob_filenames_for_search): Likewise.
3454
27a900b8
TT		 34552019-09-26 Tom Tromey <tom@tromey.com>
3456
3457 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3458 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3459 * gdb_usleep.h: Remove.
3460 * gdb_usleep.c: Remove.
3461 * utils.c: Don't include gdb_usleep.h.
3462
5d63b30a
TT		 34632019-09-26 Tom Tromey <tromey@adacore.com>
3464
3465 * python/py-type.c (type_to_type_object): Call check_typedef
3466 for stub types.
3467
12904d37
TT		 34682019-09-26 Tom Tromey <tom@tromey.com>
3469
3470 * utils.h (initialize_utils): Don't declare.
3471 * top.c (gdb_init): Don't call initialize_utils.
3472 * utils.c (initialize_utils): Remove. Move contents...
3473 (_initialize_utils): ... here.
3474
858f25f0
TT		 34752019-09-25 Tom Tromey <tom@tromey.com>
3476
3477 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3478 * utils.h (make_hex_string): Don't declare.
3479 * utils.c (make_hex_string): Remove.
3480
3d435220
TV		 34812019-09-24 Tom de Vries <tdevries@suse.de>
3482
3483 PR gdb/23815
3484 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3485 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3486
ddd44b70
DD		 34872019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3488
3489 * NEWS: Mention new simulator port for PRU.
3490
f945dedf
CB		 34912019-09-23 Christian Biesinger <cbiesinger@google.com>
3492
3493 * ada-exp.y (write_object_remaining): Update.
3494 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3495 and eliminate the static buffer.
3496 (ada_decode_symbol): Update.
3497 (ada_la_decode): Update.
3498 (ada_sniff_from_mangled_name): Update.
3499 (is_valid_name_for_wild_match): Update.
3500 (ada_lookup_name_info::matches): Update and simplify.
3501 (name_matches_regex): Update.
3502 (ada_add_global_exceptions): Update.
3503 * ada-lang.h (ada_decode): Update signature.
3504 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3505 * dwarf-index-write.c (debug_names::insert): Update.
3506
7ab78ccb
SM		 35072019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3508
3509 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3510 formatting.
3511
9252448b
SM		 35122019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3513
3514 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3515 Change "nonzero" to "true" in documentation.
3516
626ca2c0
CB		 35172019-09-20 Christian Biesinger <cbiesinger@google.com>
3518
3519 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3520 (_initialize_darwin_solib): Don't set
3521 darwin_so_ops.lookup_lib_global_symbol.
3522 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3523 set_gdbarch_iterate_over_objfiles_in_search_order.
3524 (elf_lookup_lib_symbol): Rename to...
3525 (svr4_iterate_over_objfiles_in_search_order): this, and update
3526 to iterate semantics.
3527 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3528 * solib.c (solib_global_lookup): Remove.
3529 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3530 (solib_global_lookup): Remove.
3531 * symtab.c (lookup_global_or_static_symbol): Remove call to
3532 solib_global_lookup.
3533
5a3a0d63
JB		 35342019-09-20 Joel Brobecker <brobecker@adacore.com>
3535
3536 * NEWS: Move entries about default MI version now being
3537 version 3, and about the GDB/MI fix for multi-location
3538 breakpoints to the "since GDB 8.3" section.
3539
ffea1427
JB		 35402019-09-20 Joel Brobecker <brobecker@adacore.com>
3541
3542 GDB 8.3.1 released.
3543
abf516c6
UW		 35442019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3545
3546 * NEWS: Mention that Cell/B.E. debugging support was removed.
3547 * MAINTAINERS: Remove spu target.
3548
3549 * config/djgpp/fnchange.lst: Remove entries for removed files.
3550
3551 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3552 spu-multiarch.o, and spu-tdep.o.
3553 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3554 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3555 spu-multiarch.c, and spu-tdep.c.
3556 * spu-linux-nat.c: Remove file.
3557 * spu-multiarch.c: Remove file.
3558 * spu-tdep.c: Remove file.
3559 * spu-tdep.h: Remove file.
3560 * solib-spu.c: Remove file.
3561 * solib-spu.h: Remove file.
3562
3563 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3564 * configure.nat (spu-linux): Remove.
3565 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3566 solib-multiarch.o from gdb_target_obs.
3567 (spu*-*-*): Remove.
3568
3569 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3570 feature flag.
3571 (ppc_linux_no_features): Update.
3572 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3573 Cell/B.E. support.
3574 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3575 (tdesc_powerpc_cell64l): Likewise.
3576 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3577 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3578 Cell/B.E. support.
3579 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3580 Do not include "features/rs6000/powerpc-cell32l.c" or
3581 "features/rs6000/powerpc-cell64l.c".
3582 (ppc_linux_spu_section): Remove.
3583 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3584 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3585 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3586 (ppc_linux_spe_context_lookup): Remove.
3587 (ppc_linux_spe_context_inferior_created): Remove.
3588 (ppc_linux_spe_context_solib_loaded): Remove.
3589 (ppc_linux_spe_context_solib_unloaded): Remove.
3590 (ppc_linux_spe_context): Remove.
3591 (struct ppu2spu_cache): Remove.
3592 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3593 (struct ppu2spu_data): Remove.
3594 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3595 ppu2spu_unwind): Remove.
3596 (ppc_linux_init_abi): Remove Cell/B.E. support.
3597 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3598
3599 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3600 (rs6000/powerpc-cell64l-expedite): Likewise
3601 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3602 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3603 rs6000/powerpc-cell64l.xml.
3604 * features/rs6000/powerpc-cell32l.xml: Remove.
3605 * features/rs6000/powerpc-cell64l.xml: Likewise.
3606 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3607 * features/rs6000/powerpc-cell64l.c: Likewise.
3608 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3609 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3610 * regformats/reg-spu.dat: Remove.
3611
3612 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3613 * corelow.c (struct spuid_list): Remove.
3614 (add_to_spuid_list): Remove.
3615 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3616 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3617 (remote_protocol_features): Remove associated entries.
3618 (_initialize_remote): No longer initialize them.
3619 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3620 * linux-nat.c (SPUFS_MAGIC): Remove.
3621 (linux_proc_xfer_spu): Remove.
3622 (spu_enumerate_spu_ids): Remove.
3623 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3624 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3625 (linux_make_corefile_notes): No longer call it.
3626
3627 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3628 (cooked_write_test): Likewise.
3629
78e8cb91
TT		 36302019-09-20 Tom Tromey <tom@tromey.com>
3631
3632 * NEWS: Mention case-sensitivity of TUI commands.
3633 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3634 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3635 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3636
f074b67e
TT		 36372019-09-20 Tom Tromey <tom@tromey.com>
3638
3639 * tui/tui-source.c (tui_source_window::set_contents): Use
3640 make_unique_xstrdup.
3641 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3642 make_unique_xstrdup.
3643
63c4bf19
TT		 36442019-09-20 Tom Tromey <tom@tromey.com>
3645
3646 * tui/tui-data.c: Remove separator comments.
3647 * tui/tui-layout.c: Remove separator comments.
3648 * tui/tui-win.c: Remove separator comments.
3649 * tui/tui-wingeneral.c: Remove separator comments.
3650
43df9b2f
TT		 36512019-09-20 Tom Tromey <tom@tromey.com>
3652
3653 * tui/tui.h (strcat_to_buf): Don't declare.
3654 * tui/tui.c (strcat_to_buf): Remove.
3655
7226433c
TT		 36562019-09-20 Tom Tromey <tom@tromey.com>
3657
3658 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3659 from "fullname".
3660 * tui/tui-source.c (tui_source_window::set_contents)
3661 (tui_source_window::location_matches_p)
3662 (tui_source_window::maybe_update): Update.
3663
80df3337
TT		 36642019-09-20 Tom Tromey <tom@tromey.com>
3665
3666 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3667 Update.
3668 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3669 prefix.
3670 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3671 (tui_data_window::line_from_reg_element_no)
3672 (tui_data_window::first_reg_element_no_inline)
3673 (tui_data_window::show_registers)
3674 (tui_data_window::show_register_group)
3675 (tui_data_window::display_registers_from)
3676 (tui_data_window::display_registers_from_line)
3677 (tui_data_window::first_data_item_displayed)
3678 (tui_data_window::delete_data_content_windows)
3679 (tui_data_window::erase_data_content)
3680 (tui_data_window::do_scroll_vertical)
3681 (tui_data_window::refresh_window)
3682 (tui_data_window::check_register_values): Update.
3683
9923f347
TT		 36842019-09-20 Tom Tromey <tom@tromey.com>
3685
3686 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3687 (struct tui_locator_window) <full_name, proc_name>: Now
3688 std::string.
3689 * tui/tui-stack.c (tui_locator_window::make_status_line)
3690 (tui_locator_window::set_locator_fullname)
3691 (tui_locator_window::set_locator_info): Update.
3692 * tui/tui-source.c (tui_source_window::set_contents)
3693 (tui_source_window::showing_source_p): Update.
3694
b76251ab
TT		 36952019-09-20 Tom Tromey <tom@tromey.com>
3696
3697 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3698 Don't call tui_locator_win_info_ptr.
3699
0891be08
TT		 37002019-09-20 Tom Tromey <tom@tromey.com>
3701
3702 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3703
1b935acf
TT		 37042019-09-20 Tom Tromey <tom@tromey.com>
3705
3706 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3707 height for locator.
3708 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3709 * tui/tui-layout.c (show_source_disasm_command, show_data)
3710 (show_source_or_disasm_and_command): Use 1 as height for locator.
3711
9abd8a65
TT		 37122019-09-20 Tom Tromey <tom@tromey.com>
3713
3714 * tui/tui.c (tui_enable): Update.
3715 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3716 Update.
3717 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3718 Update.
3719 * tui/tui-data.c (win_resized): Now bool.
3720 (tui_win_resized): Return bool.
3721 (tui_set_win_resized_to): Accept a bool.
3722
b5457826
TT		 37232019-09-20 Tom Tromey <tom@tromey.com>
3724
3725 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3726 Change type of "refresh_values_only".
3727 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3728 type of "refresh_values_only".
3729
6b915f7d
TT		 37302019-09-20 Tom Tromey <tom@tromey.com>
3731
3732 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3733 std::string.
3734 (tui_disassemble): Add "pos" parameter.
3735 (tui_disasm_window::set_contents): Simplify.
3736
2ad52f6f
TT		 37372019-09-20 Tom Tromey <tom@tromey.com>
3738
3739 * tui/tui-winsource.h (struct tui_source_window_base)
3740 <show_source_content>: Now private.
3741 * tui/tui-winsource.c
3742 (tui_source_window_base::show_source_content): Don't handle empty
3743 content case.
3744
b3b1bde6
TT		 37452019-09-20 Tom Tromey <tom@tromey.com>
3746
3747 * tui/tui-layout.c (show_source_disasm_command)
3748 (show_source_or_disasm_and_command): Don't call
3749 show_source_content.
3750
71a25ed2
TT		 37512019-09-20 Tom Tromey <tom@tromey.com>
3752
3753 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3754 Declare.
3755 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3756 from tui_make_status_line.
3757 (tui_locator_window::rerender): Update.
3758
f8532154
TT		 37592019-09-20 Tom Tromey <tom@tromey.com>
3760
3761 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3762 (tui_locator_window::rerender): Update.
3763
2d81b349
TT		 37642019-09-20 Tom Tromey <tom@tromey.com>
3765
3766 * tui/tui-winsource.h (struct tui_source_window_base)
3767 <~tui_source_window_base>: Don't declare.
3768 <fullname>: Remove.
3769 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3770 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3771 member.
3772 * tui/tui-source.c (tui_source_window::set_contents): Update.
3773 (tui_source_window::location_matches_p)
3774 (tui_source_window::maybe_update): Update.
3775
f14bec58
TT		 37762019-09-20 Tom Tromey <tom@tromey.com>
3777
3778 * tui/tui-winsource.h (~tui_source_element): Remove.
3779 (tui_source_element): Update.
3780 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3781 * tui/tui-winsource.c (tui_show_source_line): Update.
3782 * tui/tui-source.c (tui_source_window::set_contents): Update.
3783 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3784
78d5933a
TT		 37852019-09-20 Tom Tromey <tom@tromey.com>
3786
3787 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3788 declare.
3789 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3790 tui_clear_source_windows_detail.
3791 * tui/tui-winsource.h (struct tui_source_window_base)
3792 <clear_detail>: Don't declare.
3793 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3794 Remove.
3795 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3796
d4207696
TT		 37972019-09-20 Tom Tromey <tromey@adacore.com>
3798
3799 PR ada/24919:
3800 * block.c (contained_in): Fix final return value.
3801
00f93c44
AM		 38022019-09-20 Alan Modra <amodra@gmail.com>
3803
3804 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3805 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3806 (read_indirect_string_from_dwz): Use bfd accessor.
3807 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3808 * machoread.c (macho_symfile_read_all_oso): Likewise.
3809 * solib.c (solib_bfd_open): Likewise.
3810
e4153ae6
CB		 38112019-09-19 Christian Biesinger <cbiesinger@google.com>
3812
3813 * eval.c: Move declaration of overload_resolution to...
3814 * value.h: ...here.
3815
c7ae7675
CB		 38162019-09-19 Christian Biesinger <cbiesinger@google.com>
3817
3818 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3819 * arm-linux-tdep.c: Likewise.
3820 * arm-nbsd-nat.c: Likewise.
3821 * arm-tdep.h: Declare arm_apcs_32.
3822 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3823
e86f08d2
CB		 38242019-09-19 Christian Biesinger <cbiesinger@google.com>
3825
3826 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3827 * dwarf2read.h: Declare dwarf_always_disassemble.
3828
f64e2f40
TV		 38292019-09-19 Tom de Vries <tdevries@suse.de>
3830
3831 PR gdb/25009
3832 * source-cache.c (source_cache::ensure): Catch exception thrown during
3833 construction of the highlighter.
3834
fd361982
AM		 38352019-09-18 Alan Modra <amodra@gmail.com>
3836
3837 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3838 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3839 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3840 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3841 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3842 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3843 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3844 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3845 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3846 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3847 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3848 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3849 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3850 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3851 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3852 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3853 * mi/mi-interp.c: Update throughout for bfd section macro and
3854 function changes.
3855 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3856 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3857
11061048
TT		 38582019-09-18 Tom Tromey <tom@tromey.com>
3859
3860 * NEWS: Add entry.
3861 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3862 call rl_initialize.
3863 (tui_enable): Do not call rl_initialize.
3864
7a27b85f
CG		 38652019-09-18 Christian Groessler <chris@groessler.org>
3866
3867 * alpha-linux-nat.c: Include gdbarch.h.
3868
f64eea3a
SM		 38692019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3870
3871 * ui-file.c: Include cli/cli-style.h.
3872 (term_cli_styling): Remove cli_styling declaration.
3873
e6f7f6d1
AM		 38742019-09-18 Alan Modra <amodra@gmail.com>
3875
3876 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3877 to bfd_asymbol_section.
3878
1d38e9d1
AM		 38792019-09-18 Alan Modra <amodra@gmail.com>
3880
3881 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3882 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3883 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3884
90d92a63
AM		 38852019-09-18 Alan Modra <amodra@gmail.com>
3886
3887 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3888 * spu-linux-nat.c (spu_bfd_open): Likewise.
3889
a3d181d2
CB		 38902019-09-18 Christian Biesinger <cbiesinger@google.com>
3891
3892 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3893 to bool to match definition in dwarf2read.c.
3894
491144b5
CB		 38952019-09-17 Christian Biesinger <cbiesinger@google.com>
3896
3897 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3898 (print_signatures): Likewise.
3899 (trust_pad_over_xvs): Likewise.
3900 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3901 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3902 * arm-linux-nat.c (arm_apcs_32): Likewise.
3903 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3904 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3905 * arm-tdep.c (arm_debug): Likewise.
3906 (arm_apcs_32): Likewise.
3907 * auto-load.c (debug_auto_load): Likewise.
3908 (auto_load_gdb_scripts): Likewise.
3909 (global_auto_load): Likewise.
3910 (auto_load_local_gdbinit): Likewise.
3911 (auto_load_local_gdbinit_loaded): Likewise.
3912 * auto-load.h (global_auto_load): Likewise.
3913 (auto_load_local_gdbinit): Likewise.
3914 (auto_load_local_gdbinit_loaded): Likewise.
3915 * breakpoint.c (disconnected_dprintf): Likewise.
3916 (breakpoint_proceeded): Likewise.
3917 (automatic_hardware_breakpoints): Likewise.
3918 (always_inserted_mode): Likewise.
3919 (target_exact_watchpoints): Likewise.
3920 (_initialize_breakpoint): Update.
3921 * breakpoint.h (target_exact_watchpoints): Change to bool.
3922 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3923 * cli/cli-cmds.c (trace_commands): Likewise.
3924 * cli/cli-cmds.h (trace_commands): Likewise.
3925 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3926 to bool*.
3927 * cli/cli-logging.c (logging_overwrite): Change to bool.
3928 (logging_redirect): Likewise.
3929 (debug_redirect): Likewise.
3930 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3931 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3932 to bool.
3933 <boolean_option_def>: Update.
3934 (struct flag_option_def): Change default type of Context to bool
3935 from int.
3936 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3937 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3938 (get_setshow_command_value_string): Likewise.
3939 * cli/cli-style.c (cli_styling): Change to bool.
3940 (source_styling): Likewise.
3941 * cli/cli-style.h (source_styling): Likewise.
3942 (cli_styling): Likewise.
3943 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3944 to bool.
3945 * command.h (var_types): Update comment.
3946 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3947 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3948 bool.
3949 (debug_compile_cplus_scopes): Likewise.
3950 * compile/compile-internal.h (compile_debug): Likewise.
3951 * compile/compile.c (compile_debug): Likewise.
3952 (struct compile_options) <raw>: Likewise.
3953 * cp-support.c (catch_demangler_crashes): Likewise.
3954 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3955 (usr_cmd_cris_dwarf2_cfi): Likewise.
3956 * csky-tdep.c (csky_debug): Likewise.
3957 * darwin-nat.c (enable_mach_exceptions): Likewise.
3958 * dcache.c (dcache_enabled_p): Likewise.
3959 * defs.h (info_verbose): Likewise.
3960 * demangle.c (demangle): Likewise.
3961 (asm_demangle): Likewise.
3962 * dwarf-index-cache.c (debug_index_cache): Likewise.
3963 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3964 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3965 * dwarf2read.c (check_physname): Likewise.
3966 (use_deprecated_index_sections): Likewise.
3967 (dwarf_always_disassemble): Likewise.
3968 * eval.c (overload_resolution): Likewise.
3969 * event-top.c (set_editing_cmd_var): Likewise.
3970 (exec_done_display_p): Likewise.
3971 * event-top.h (set_editing_cmd_var): Likewise.
3972 (exec_done_display_p): Likewise.
3973 * exec.c (write_files): Likewise.
3974 * fbsd-nat.c (debug_fbsd_lwp): Likewise
3975 (debug_fbsd_nat): Likewise.
3976 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3977 Likewise.
3978 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3979 <backtrace_past_entry> Likewise.
3980 * gdb-demangle.h (demangle): Likewise.
3981 (asm_demangle): Likewise.
3982 * gdb_bfd.c (bfd_sharing): Likewise.
3983 * gdbcore.h (write_files): Likewise.
3984 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3985 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3986 * gdbthread.h (print_thread_events): Likewise.
3987 * gdbtypes.c (opaque_type_resolution): Likewise.
3988 (strict_type_checking): Likewise.
3989 * gnu-nat.c (gnu_debug_flag): Likewise.
3990 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3991 * guile/scm-param.c (pascm_variable): Add boolval.
3992 (add_setshow_generic): Update.
3993 (pascm_param_value): Update.
3994 (pascm_set_param_value_x): Update.
3995 * hppa-tdep.c (hppa_debug): Change to bool..
3996 * infcall.c (may_call_functions_p): Likewise.
3997 (coerce_float_to_double_p): Likewise.
3998 (unwind_on_signal_p): Likewise.
3999 (unwind_on_terminating_exception_p): Likewise.
4000 * infcmd.c (startup_with_shell): Likewise.
4001 * inferior.c (print_inferior_events): Likewise.
4002 * inferior.h (startup_with_shell): Likewise.
4003 (print_inferior_events): Likewise.
4004 * infrun.c (step_stop_if_no_debug): Likewise.
4005 (detach_fork): Likewise.
4006 (debug_displaced): Likewise.
4007 (disable_randomization): Likewise.
4008 (non_stop): Likewise.
4009 (non_stop_1): Likewise.
4010 (observer_mode): Likewise.
4011 (observer_mode_1): Likewise.
4012 (set_observer_mode): Update.
4013 (sched_multi): Change to bool.
4014 * infrun.h (debug_displaced): Likewise.
4015 (sched_multi): Likewise.
4016 (step_stop_if_no_debug): Likewise.
4017 (non_stop): Likewise.
4018 (disable_randomization): Likewise.
4019 * linux-tdep.c (use_coredump_filter): Likewise.
4020 (dump_excluded_mappings): Likewise.
4021 * linux-thread-db.c (auto_load_thread_db): Likewise.
4022 (check_thread_db_on_load): Likewise.
4023 * main.c (captured_main_1): Update.
4024 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4025 xx2_opt, boolean_opt>: Change to bool.
4026 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4027 * maint.c (maintenance_profile_p): Likewise.
4028 (per_command_time): Likewise.
4029 (per_command_space): Likewise.
4030 (per_command_symtab): Likewise.
4031 * memattr.c (inaccessible_by_default): Likewise.
4032 * mi/mi-main.c (mi_async): Likewise.
4033 (mi_async_1): Likewise.
4034 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4035 * nat/fork-inferior.h (startup_with_shell): Likewise.
4036 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4037 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4038 * nios2-tdep.c (nios2_debug): Likewise.
4039 * or1k-tdep.c (or1k_debug): Likewise.
4040 * parse.c (parser_debug): Likewise.
4041 * parser-defs.h (parser_debug): Likewise.
4042 * printcmd.c (print_symbol_filename): Likewise.
4043 * proc-api.c (procfs_trace): Likewise.
4044 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4045 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4046 (set_parameter_value): Update.
4047 (add_setshow_generic): Update.
4048 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4049 to bool*.
4050 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4051 int*.
4052 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4053 * record-btrace.c (record_btrace_target::store_registers): Update.
4054 * record-full.c (record_full_memory_query): Change to bool.
4055 (record_full_stop_at_limit): Likewise.
4056 * record-full.h (record_full_memory_query): Likewise.
4057 * remote-notif.c (notif_debug): Likewise.
4058 * remote-notif.h (notif_debug): Likewise.
4059 * remote.c (use_range_stepping): Likewise.
4060 (interrupt_on_connect): Likewise.
4061 (remote_break): Likewise.
4062 * ser-tcp.c (tcp_auto_retry): Likewise.
4063 * ser-unix.c (serial_hwflow): Likewise.
4064 * skip.c (debug_skip): Likewise.
4065 * solib-aix.c (solib_aix_debug): Likewise.
4066 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4067 (spu_auto_flush_cache_p): Likewise.
4068 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4069 Likewise.
4070 (struct info_print_options) <quiet>: Likewise.
4071 * symfile-debug.c (debug_symfile): Likewise.
4072 * symfile.c (auto_solib_add): Likewise.
4073 (separate_debug_file_debug): Likewise.
4074 * symfile.h (auto_solib_add): Likewise.
4075 (separate_debug_file_debug): Likewise.
4076 * symtab.c (basenames_may_differ): Likewise.
4077 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4078 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4079 (struct info_types_options) <quiet>: Likewise.
4080 * symtab.h (demangle): Likewise.
4081 (basenames_may_differ): Likewise.
4082 * target-dcache.c (stack_cache_enabled_1): Likewise.
4083 (code_cache_enabled_1): Likewise.
4084 * target.c (trust_readonly): Likewise.
4085 (may_write_registers): Likewise.
4086 (may_write_memory): Likewise.
4087 (may_insert_breakpoints): Likewise.
4088 (may_insert_tracepoints): Likewise.
4089 (may_insert_fast_tracepoints): Likewise.
4090 (may_stop): Likewise.
4091 (auto_connect_native_target): Likewise.
4092 (target_stop_and_wait): Update.
4093 (target_async_permitted): Change to bool.
4094 (target_async_permitted_1): Likewise.
4095 (may_write_registers_1): Likewise.
4096 (may_write_memory_1): Likewise.
4097 (may_insert_breakpoints_1): Likewise.
4098 (may_insert_tracepoints_1): Likewise.
4099 (may_insert_fast_tracepoints_1): Likewise.
4100 (may_stop_1): Likewise.
4101 * target.h (target_async_permitted): Likewise.
4102 (may_write_registers): Likewise.
4103 (may_write_memory): Likewise.
4104 (may_insert_breakpoints): Likewise.
4105 (may_insert_tracepoints): Likewise.
4106 (may_insert_fast_tracepoints): Likewise.
4107 (may_stop): Likewise.
4108 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4109 (make_thread_apply_all_options_def_group): Change argument from int*
4110 to bool*.
4111 (thread_apply_all_command): Update.
4112 (print_thread_events): Change to bool.
4113 * top.c (confirm): Likewise.
4114 (command_editing_p): Likewise.
4115 (history_expansion_p): Likewise.
4116 (write_history_p): Likewise.
4117 (info_verbose): Likewise.
4118 * top.h (confirm): Likewise.
4119 (history_expansion_p): Likewise.
4120 * tracepoint.c (disconnected_tracing): Likewise.
4121 (circular_trace_buffer): Likewise.
4122 * typeprint.c (print_methods): Likewise.
4123 (print_typedefs): Likewise.
4124 * utils.c (debug_timestamp): Likewise.
4125 (sevenbit_strings): Likewise.
4126 (pagination_enabled): Likewise.
4127 * utils.h (sevenbit_strings): Likewise.
4128 (pagination_enabled): Likewise.
4129 * valops.c (overload_resolution): Likewise.
4130 * valprint.h (struct value_print_options) <prettyformat_arrays,
4131 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4132 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4133 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4134 Likewise.
4135 * windows-nat.c (new_console): Likewise.
4136 (cygwin_exceptions): Likewise.
4137 (new_group): Likewise.
4138 (debug_exec): Likewise.
4139 (debug_events): Likewise.
4140 (debug_memory): Likewise.
4141 (debug_exceptions): Likewise.
4142 (useshell): Likewise.
4143 * windows-tdep.c (maint_display_all_tib): Likewise.
4144 * xml-support.c (debug_xml): Likewise.
4145
f1b620e9
MG		 41462019-09-17 Mike Gulick <mgulick@mathworks.com>
4147
4148 * source.c (prepare_path_for_appending): New function.
4149 (openp): Make use of new function.
4150 (find_and_open_source): Search for the compilation directory and
4151 source file as a relative path beneath the directory search path.
4152
67f3ed6a
AB		 41532019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4154
4155 * source-cache.c (source_cache::get_line_charpos): Catch
4156 exceptions and return false, this matches the behaviour documented
4157 in the header file.
4158
74332189
JB		 41592019-09-17 Joel Brobecker <brobecker@adacore.com>
4160
4161 * ada-tasks.c (info_task): Remove quoting of the task's name.
4162
f2f24aa9
CB		 41632019-09-16 Christian Biesinger <cbiesinger@google.com>
4164
4165 * symfile.c (auto_solib_add): Replace comment with a reference
4166 to the header file.
4167
6a062a93
CB		 41682019-09-14 Christian Biesinger <cbiesinger@google.com>
4169
4170 * NEWS: Mention that gdb can now be compiled with Python 3
4171 on Windows.
4172
ec6c8338
AB		 41732019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4174
4175 * maint.c (maint_print_section_data::maint_print_section_data):
4176 Force use of 'float log10 (float)' by casting the argument to
4177 float.
4178
aa17805f
AB		 41792019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4180
4181 * maint.c: Add 'cmath' include.
4182 (struct maint_print_section_data): New structure.
4183 (print_section_index): New function.
4184 (print_bfd_section_info): Add header comment, small whitespace
4185 cleanup, and update to call new print_section_index function.
4186 (print_objfile_section_info): Likewise.
4187 (maint_obj_section_from_bfd_section): New function.
4188 (print_bfd_section_info_maybe_relocated): New function.
4189 (maintenance_info_sections): Add header comment, always use
4190 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4191
3dd9bb46
AB		 41922019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4193
4194 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4195 inner scope, add check that the objfile has psymtabs before
4196 checking psymtabs_addrmap.
4197 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4198
4993045d
PW		 41992019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4200
4201 * NEWS: Announce that Ada task names are now shown at more places,
4202 and between quotes (except in info task output).
4203 * gdb/ada-tasks.c (task_to_str): New function.
4204 (display_current_task_id): Call task_to_str.
4205 (task_command_1): Likewise.
4206 (print_ada_task_info): In non-mi mode, Properly align headers and data
4207 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4208
7a289707
RO		 42092019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4210
4211 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4212 prstatus.pr_lwp.pr_info instead of making it up.
4213
f2aec7f6
CB		 42142019-09-11 Christian Biesinger <cbiesinger@google.com>
4215
4216 * auto-load.c (auto_load_expand_dir_vars): Update.
4217 * defs.h (gdb_datadir): Change to std::string.
4218 (python_libdir): Likewise.
4219 (relocate_gdb_directory): Change return type to std::string.
4220 * guile/guile.c (gdbscm_data_directory): Update.
4221 (initialize_scheme_side): Update.
4222 * jit.c (jit_reader_dir): Change to std::string.
4223 (jit_reader_load_command): Update.
4224 * main.c (gdb_datadir): Change to std::string.
4225 (python_libdir): Likewise.
4226 (set_gdb_data_directory): Update.
4227 (relocate_path): Change to return std::string.
4228 (relocate_gdb_directory): Change to return std::string.
4229 (relocate_gdbinit_path_maybe_in_datadir): Update.
4230 (captured_main_1): Update.
4231 * python/python.c (do_start_initialization): Update.
4232 * top.c (show_gdb_datadir): Update.
4233 * xml-syscall.c (xml_init_syscalls_info): Update.
4234 (init_syscalls_info): Update.
4235
9224a013
CB		 42362019-09-11 Christian Biesinger <cbiesinger@google.com>
4237
4238 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4239 out of get_init_files.
4240 (get_init_files): Update.
4241
f48cd836
CB		 42422019-09-11 Christian Biesinger <cbiesinger@google.com>
4243
4244 * main.c (get_init_files): Change to use std::string.
4245 (captured_main_1): Update.
4246 (print_gdb_help): Update.
4247
9cab7ecd
AT		 42482019-09-11 Ali Tamur <tamur@google.com>
4249
4250 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4251 implementation.
4252
67547d89
CB		 42532019-09-11 Christian Biesinger <cbiesinger@google.com>
4254
4255 * dbxread.c (read_dbx_symtab): Update.
4256 * dwarf2read.c (load_partial_dies): Update.
4257 * mdebugread.c (parse_partial_symbols): Update.
4258 (handle_psymbol_enumerators): Update.
4259 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4260 * psymtab.c (add_psymbol_to_bcache): Likewise.
4261 (add_psymbol_to_list): Likewise.
4262 * symtab.c (symbol_set_names): Likewise.
4263 * symtab.h (symbol_set_names): Likewise.
4264 * xcoffread.c (scan_xcoff_symtab): Update.
4265
64b2d4a0
TT		 42662019-09-11 Tom Tromey <tom@tromey.com>
4267
4268 * symfile-mem.c (symbol_file_add_from_memory): Use
4269 bfd_set_filename.
4270 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4271 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4272
3b00ef10
TT		 42732019-09-10 Tom Tromey <tromey@adacore.com>
4274
4275 * dwarf-index-write.c (write_psymbols): Extend error message.
4276 (debug_names::insert): Add Ada code.
4277 (debug_names::write_psymbols): Remove Ada check.
4278 (debug_names) <m_string_obstack>: New member.
4279 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4280 (gdb_index_symbol_name_matcher::matches): Remove.
4281 (mapped_index_base::find_name_components_bounds): Add "lang"
4282 parameter.
4283 (mapped_index_base::build_name_components): Also split names
4284 according to Ada syntax.
4285 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4286 type of "match_callback".
4287 (check_match, check_find_bounds_finds)
4288 (dw2_expand_symtabs_matching): Update.
4289 (dw2_debug_names_iterator): Add new constructor.
4290 (dw2_debug_names_map_matching_symbols): New function.
4291 (dw2_debug_names_expand_symtabs_matching): Update.
4292 (dwarf2_debug_names_functions): Use
4293 dw2_debug_names_map_matching_symbols.
4294
aa391654
TT		 42952019-09-10 Tom Tromey <tromey@adacore.com>
4296
4297 * dwarf2read.c (dw2_get_file_names_reader): Add the
4298 CU's file name to the results.
4299
b054970d
TT		 43002019-09-10 Tom Tromey <tromey@adacore.com>
4301
4302 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4303 map_matching_symbols. Update.
4304 * dwarf2read.c (dw2_map_matching_symbols): Update.
4305 * psymtab.c (match_partial_symbol): Change type; update.
4306 (psym_map_matching_symbols): Likewise.
4307 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4308 type; update.
4309 * symfile.h (struct quick_symbol_functions)
4310 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4311 Remove "match".
4312
6a3dbf1b
TT		 43132019-09-10 Tom Tromey <tromey@adacore.com>
4314
4315 * psymtab.c (map_block): Remove.
4316 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4317 * symtab.c (iterate_over_symbols_terminated): New function.
4318 * symtab.c (iterate_over_symbols_terminated): Declare.
4319
6969f124
TT		 43202019-09-10 Tom Tromey <tromey@adacore.com>
4321
4322 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4323 * language.h (struct language_defn) <la_iterate_over_symbols>:
4324 Return bool.
4325 * symtab.c (iterate_over_symbols): Return bool.
4326 * symtab.h (iterate_over_symbols): Return bool.
4327
199b4314
TT		 43282019-09-10 Tom Tromey <tromey@adacore.com>
4329
4330 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4331 (add_nonlocal_symbols): Update.
4332 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4333 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4334 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4335 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4336 Change type of "callback". Remove "data".
4337
a084a2a6
AT		 4338
43392019-09-09 Ali Tamur <tamur@google.com>
4340
4341 * dwarf2read.c (comp_unit_head): Update comment.
4342 (dwarf2_dwo_name): New function declaration.
4343 (dwarf_unit_type_name): New function declaration.
4344 (read_comp_unit_head): Add support for new compilation units,
4345 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4346 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4347 (currently named as "signature") in their header. Also clarify error
4348 messages.
4349 (lookup_dwo_id): New function. Returns the dwo id of the given
4350 compile unit.
4351 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4352 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4353 functions.
4354 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4355 (dwarf2_dwo_name): Get the dwo name if present.
4356 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4357 purposes.
4358
25a2915e
TT		 43592019-09-09 Tom Tromey <tom@tromey.com>
4360
4361 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4362
e4df0874
PW		 43632019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4364
4365 * python/python.c (do_start_initialization): Make progname_copy static,
4366 to avoid a leak report.
4367
8634b462
TT		 43682019-09-08 Tom Tromey <tom@tromey.com>
4369
4370 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4371
c7f839cb
SM		 43722019-09-07 Simon Marchi <simon.marchi@efficios.com>
4373
4374 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4375 Change type to gdb::optional<block_enum>.
4376 (dw2_symtab_iter_init): Change block_index parameter type
4377 to gdb::optional<block_enum>.
4378 (dw2_lookup_symbol): Change block_index parameter
4379 type to block_enum.c
4380 (dw2_debug_names_lookup_symbol): Likewise.
4381 * psymtab.c (psym_lookup_symbol): Likewise.
4382 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4383 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4384 Likewise.
4385
ead0e69a
CB		 43862019-09-06 Christian Biesinger <cbiesinger@google.com>
4387
4388 * defs.h (relocate_gdb_directory): Change int to bool in
4389 signature and rename flag to relocatable.
4390 * main.c (relocate_path): Likewise.
4391 (relocate_gdb_directory): Likewise.
4392
b16c44de
AM		 43932019-09-06 Alan Modra <amodra@gmail.com>
4394
4395 * coffread.c (coff_symfile_read): Constify filename variable.
4396 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4397 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4398 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4399 * solib.c (reload_shared_libraries_1): Likewise.
4400 * symfile.c (reread_symbols): Likewise.
4401 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4402 * solib-darwin.c (darwin_bfd_open): Likewise.
4403 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4404
06ff036e
AB		 44052019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4406
4407 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4408 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4409
4e962e74
TT		 44102019-09-03 Tom Tromey <tromey@adacore.com>
4411
4412 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4413 types.
4414 (has_negatives): Unbias a range type bound.
4415 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4416 * gdbtypes.c (operator==): Handle new field.
4417 (create_range_type): Add "bias" parameter.
4418 (create_static_range_type, resolve_dynamic_range): Update.
4419 * gdbtypes.h (struct range_bounds) <bias>: New member.
4420 (create_range_type): Add bias parameter.
4421 * printcmd.c (print_scalar_formatted): Unbias range types.
4422 * value.c (unpack_long): Unbias range types.
4423 (pack_long): Bias range types.
4424
d90b8f26
AH		 44252019-09-02 Alan Hayward <alan.hayward@arm.com>
4426
4427 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4428 probe arguments.
4429
fe01123e
AH		 44302019-09-02 Alan Hayward <alan.hayward@arm.com>
4431
4432 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4433 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4434 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4435 (compile_probe_arg): Likewise.
4436 * probe.h (get_argument_count): Likewise.
4437 * solib-svr4.c (solib_event_probe_action): Likewise.
4438 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4439
e661ef01
AH		 44402019-09-02 Alan Hayward <alan.hayward@arm.com>
4441
4442 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4443 code to here...
4444 (svr4_create_solib_event_breakpoints): ...from here.
4445
47a536d9
SDJ		 44462019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4447
4448 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4449 suffix from warning message.
4450
d6a00eba
TT		 44512019-08-30 Tom Tromey <tom@tromey.com>
4452
4453 * tui/tui-winsource.h (struct tui_source_window_base)
4454 <refresh_all>: Don't declare.
4455 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4456 Remove.
4457 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4458 tui_show_locator_content.
4459 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4460 declare.
4461 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4462 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4463 declare.
4464
55b2657b
TT		 44652019-08-30 Tom Tromey <tom@tromey.com>
4466
4467 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4468
12a8555a
TT		 44692019-08-30 Tom Tromey <tom@tromey.com>
4470
4471 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4472 Remove unnecessary forward declarations.
4473
900ac242
TT		 44742019-08-30 Tom Tromey <tom@tromey.com>
4475
4476 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4477 rerender.
4478 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4479 tui_show_locator_content.
4480
99ab33fb
TT		 44812019-08-30 Tom Tromey <tom@tromey.com>
4482
4483 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4484 (tui_locator_window::rerender): Rewrite using body of previous
4485 tui_show_locator_content.
4486
e594a5d1
TT		 44872019-08-30 Tom Tromey <tom@tromey.com>
4488
4489 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4490 set_locator_fullname>: New methods.
4491 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4492 Rename from tui_set_locator_fullname.
4493 (tui_locator_window::set_locator_info): Rename from
4494 tui_set_locator_info. Return bool.
4495 (tui_update_locator_fullname, tui_show_frame_info): Update.
4496
715bb467
TT		 44972019-08-30 Tom Tromey <tom@tromey.com>
4498
4499 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4500
772f3f03
TT		 45012019-08-30 Tom Tromey <tom@tromey.com>
4502
4503 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4504 call touchwin.
4505
108e13ab
TT		 45062019-08-30 Tom Tromey <tom@tromey.com>
4507
4508 * tui/tui-wingeneral.c (box_win): Assume win_info and
4509 win_info->handle cannot be NULL.
4510
cdaa6eb4
TT		 45112019-08-30 Tom Tromey <tom@tromey.com>
4512
4513 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4514 refresh_window>: Declare.
4515 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4516 resize.
4517 (tui_data_item_window::rerender): Rename from
4518 tui_display_register.
4519 (tui_data_item_window::refresh_window): New method.
4520 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4521 no-op.
4522
89df7f90
TT		 45232019-08-30 Tom Tromey <tom@tromey.com>
4524
4525 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4526 regs_column_count, current_group>: Move later. Now private.
4527 <get_current_group>: New method.
4528 * tui/tui-regs.c (tui_reg_command): Update.
4529 * tui/tui-layout.c (tui_set_layout): Update.
4530
1bf2866a
TT		 45312019-08-30 Tom Tromey <tom@tromey.com>
4532
4533 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4534 (tui_data_window::rerender): Don't call
4535 check_and_display_highlight_if_needed.
4536 (tui_data_window::refresh_all): Remove call to
4537 erase_data_content.
4538
0670413d
TT		 45392019-08-30 Tom Tromey <tom@tromey.com>
4540
4541 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4542 (tui_data_window::display_registers_from)
4543 (tui_data_window::display_reg_element_at_line)
4544 (tui_data_window::display_registers_from_line): Remove checks of
4545 "empty".
4546
18bb55c7
TT		 45472019-08-30 Tom Tromey <tom@tromey.com>
4548
4549 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4550 Don't declare.
4551 * tui/tui-regs.c (tui_data_window::show_registers): Call
4552 rerender.
4553 (tui_data_window::rerender): Rename from display_all_data.
4554 (tui_data_window::rerender): Remove old implementation.
4555
1f6d2f10
TT		 45562019-08-30 Tom Tromey <tom@tromey.com>
4557
4558 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4559 text.
4560 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4561
16d01f9c
BW		 45622019-08-29 Bernhard Wodok <barto@gmx.net>
4563 Sergio Durigan Junior <sergiodj@redhat.com>
4564
4565 PR win32/24284
4566 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4567
d8f27c60
AB		 45682019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4569
4570 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4571 when searching for types.
4572
1f20c35e
AB		 45732019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4574
4575 * f-lang.c (f_language_defn): Use f_print_typedef.
4576 * f-lang.h (f_print_typedef): Declare.
4577 * f-typeprint.c (f_print_typedef): Define.
4578
550105b7
CB		 45792019-08-27 Christian Biesinger <cbiesinger@google.com>
4580
4581 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4582
4acfdd20
AB		 45832019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4584
4585 * cli/cli-utils.c (info_print_options_defs): Delete.
4586 (make_info_print_options_def_group): Delete.
4587 (extract_info_print_options): Delete.
4588 (info_print_command_completer): Delete.
4589 (info_print_args_help): Add extra parameter, and optionally
4590 include text about -n flag.
4591 * cli/cli-utils.h (struct info_print_options): Delete.
4592 (extract_info_print_options): Delete declaration.
4593 (info_print_command_completer): Delete declaration.
4594 (info_print_args_help): Add extra parameter, extend header
4595 comment.
4596 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4597 search_symbols.
4598 * stack.c (struct info_print_options): New type.
4599 (info_print_options_defs): New file scoped variable.
4600 (make_info_print_options_def_group): New static function.
4601 (info_print_command_completer): New static function.
4602 (info_locals_command): Update to use new local functions.
4603 (info_args_command): Likewise.
4604 (_initialize_stack): Add extra parameter to calls to
4605 info_print_args_help.
4606 * symtab.c (search_symbols): Add extra parameter, use this to
4607 possibly excluse non-debug symbols.
4608 (symtab_symbol_info): Add extra parameter, which is passed on to
4609 search_symbols.
4610 (struct info_print_options): New type.
4611 (info_print_options_defs): New file scoped variable.
4612 (make_info_print_options_def_group): New static function.
4613 (info_print_command_completer): New static function.
4614 (info_variables_command): Update to use local functions, and pass
4615 extra parameter through to symtab_symbol_info.
4616 (info_functions_command): Likewise.
4617 (info_types_command): Pass additional argument through to
4618 symtab_symbol_info.
4619 (rbreak_command): Pass extra argument to search_symbols.
4620 (_initialize_symtab): Add extra arguments for calls to
4621 info_print_args_help, and update help text for 'info variables',
4622 'whereis', and 'info functions' commands.
4623 * symtab.h (search_symbols): Add extra argument to declaration.
4624 * NEWS: Mention new flags.
4625
9aa55206
CB		 46262019-08-26 Christian Biesinger <cbiesinger@google.com>
4627
4628 * symtab.c (lookup_static_symbol): Call the new function (and move
4629 it down to be next to lookup_global_symbol).
4630 (struct global_sym_lookup_data): Add block_enum member and rename to...
4631 (struct global_or_static_sym_lookup_data): ...this.
4632 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4633 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4634 (lookup_symbol_global_or_static_iterator_cb): ...this.
4635 (lookup_global_or_static_symbol): New function.
4636 (lookup_global_symbol): Call new function.
4637
5c31b358
TV		 46382019-08-26 Tom de Vries <tdevries@suse.de>
4639
4640 PR c++/24852
4641 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4642 when pc_probe.prob == NULL.
4643
23c13d42
SM		 46442019-08-25 Simon Marchi <simon.marchi@efficios.com>
4645
4646 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4647 variable symbol_linkage to symbol_linkage_.
4648
beadd3e8
SM		 46492019-08-25 Simon Marchi <simon.marchi@efficios.com>
4650
4651 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4652 represent whether the symbol is static, dynamic, or we don't
4653 know.
4654
e3ec872f
YS		 46552019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4656
4657 * gdb/rx-tdep.c (rx_register_names): New.
4658 (rx_register_name): Delete.
4659 (rx_psw_type): Delete.
4660 (rx_fpsw_type): Delete.
4661 (rx_register_type): Delete.
4662 (rx_gdbarch_init): Convert target-descriptions.
4663 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4664 * gdb/features/Makefile: Add rx.xml.
4665 * gdb/features/rx.xml: New.
4666 * gdb/features/rx.c: Generated.
4667 * gdb/NEWS: Mention target description support.
4668
d0509ba4
CB		 46692019-08-22 Christian Biesinger <cbiesinger@google.com>
4670
4671 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4672 *slot_ptr.
4673
2d41fa11
SDJ		 46742019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4675
4676 * configure.ac: Don't check for 'dlfcn.h' (moved to
4677 gdbsupport/common.m4).
4678 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4679 'gdbsupport/'.
4680 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4681 * compile/compile-c-support.c: Include
4682 'gdbsupport/gdb-dlfcn.h'.
4683 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4684 * gdb-dlfcn.c: Move to...
4685 * gdbsupport/gdb-dlfcn.c: ... here.
4686 * gdb-dlfcn.h: Move to...
4687 * gdbsupport/gdb-dlfcn.h: ... here.
4688
de8af808
SL		 46892019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4690
4691 * nios2-tdep.c (struct reg_value): Improve comments. Make
4692 the offset field signed.
4693
27204489
CB		 46942019-08-22 Christian Biesinger <cbiesinger@google.com>
4695
4696 * python/lib/gdb/__init__.py (_execute_file): New function.
4697 * python/python.c (python_run_simple_file): Call gdb._execute_file
4698 on Windows.
4699
43771869
AB		 47002019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4701
4702 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4703 all uses as this was never set to anything but a zero value.
4704
26c957f1
PA		 47052019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4706
4707 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4708
c07aae6e
CB		 47092019-08-21 Christian Biesinger <cbiesinger@google.com>
4710
4711 * tui/tui-data.h (tui_gen_win_info): Add an =default
4712 move constructor, required by some GCC versions.
4713
3960cb7a
JF		 47142019-08-21 Jinke Fan <fanjinke51@yeah.net>
4715
4716 * go32-nat.c (go32_sysinfo): Add hygon_p.
4717
04c72a68
TT		 47182019-08-20 Tom Tromey <tom@tromey.com>
4719
4720 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4721 line_from_reg_element_no, first_reg_element_no_inline,
4722 display_all_data, delete_data_content_windows,
4723 erase_data_content>: Now private.
4724
072272ce
TT		 47252019-08-20 Tom Tromey <tom@tromey.com>
4726
4727 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4728 (tui_unhighlight_win, tui_highlight_win)
4729 (tui_win_info::make_window): Update.
4730 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4731
973961bd
TT		 47322019-08-20 Tom Tromey <tom@tromey.com>
4733
4734 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4735 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4736 (MAX_PID_WIDTH): Move to tui-stack.c.
4737 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4738 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4739 (MAX_PID_WIDTH): Move from tui-data.h.
4740
ab0e1f1a
TT		 47412019-08-20 Tom Tromey <tom@tromey.com>
4742
4743 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4744 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4745 (box_win): Update.
4746 (tui_gen_win_info::make_window): Rename from tui_make_window.
4747 (tui_win_info::make_window): New method.
4748 (tui_gen_win_info::make_visible): Update.
4749 * tui/tui-source.c (tui_source_window::set_contents): Update.
4750 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4751 (tui_data_window::display_registers_from): Update.
4752 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4753 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4754 Declare.
4755 <can_box>: Remove.
4756 <title>: Remove.
4757 (struct tui_win_info) <make_window>: Declare.
4758 <can_box>: Now virtual.
4759 <title>: New member.
4760 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4761 * tui/tui-command.c (tui_cmd_window::resize): Update.
4762
100c2bf3
TT		 47632019-08-20 Tom Tromey <tom@tromey.com>
4764
4765 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4766 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4767 (tui_data_window::check_register_values): Update.
4768
fa4dc567
TT		 47692019-08-20 Tom Tromey <tom@tromey.com>
4770
4771 * tui/tui-regs.h (struct tui_data_window): Use
4772 DISABLE_COPY_AND_ASSIGN.
4773 <regs_content>: Change type, removing unique_ptr.
4774 <tui_data_window>: Add move constructor.
4775 * tui/tui-regs.c (tui_data_window::show_registers)
4776 (tui_data_window::show_register_group)
4777 (tui_data_window::display_registers_from)
4778 (tui_data_window::display_registers_from)
4779 (tui_data_window::first_data_item_displayed)
4780 (tui_data_window::delete_data_content_windows)
4781 (tui_data_window::rerender, tui_data_window::refresh_window)
4782 (tui_data_window::check_register_values): Update.
4783
ca02d7c8
TT		 47842019-08-20 Tom Tromey <tom@tromey.com>
4785
4786 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4787 show_register_group>: Declare.
4788 (tui_show_register_group): Don't declare.
4789 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4790 tui_show_registers.
4791 (tui_data_window::show_register_group): Rename from
4792 tui_show_register_group.
4793 (tui_data_window::check_register_values, tui_reg_command):
4794 Update.
4795 * tui/tui-layout.c (tui_set_layout): Update.
4796
63356bfd
TT		 47972019-08-20 Tom Tromey <tom@tromey.com>
4798
4799 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4800 Declare.
4801 (tui_check_register_values): Don't declare.
4802 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4803 from tui_check_register_values.
4804 * tui/tui-hooks.c (tui_register_changed): Update.
4805
42cc14a7
TT		 48062019-08-20 Tom Tromey <tom@tromey.com>
4807
4808 * tui/tui-regs.c (tui_reg_layout): Move later.
4809 (tui_show_registers): Don't enable TUI mode or change layout.
4810
b9ad3686
TT		 48112019-08-20 Tom Tromey <tom@tromey.com>
4812
4813 * tui/tui-regs.h (struct tui_data_item_window)
4814 <~tui_data_item_window>: Remove.
4815 <content>: Now a unique_xmalloc_ptr.
4816 * tui/tui-regs.c (tui_register_format): Return a
4817 unique_xmalloc_ptr.
4818 (tui_get_register): Update.
4819 (~tui_data_item_window): Remove.
4820 (tui_data_window::display_registers_from, tui_display_register):
4821 Update.
4822 * tui/tui-io.h (tui_expand_tabs): Update.
4823 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4824 Remove "col" parameter.
4825
8e114aab
TT		 48262019-08-20 Tom Tromey <tom@tromey.com>
4827
4828 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4829 field.
4830 * tui/tui-regs.c (~tui_data_item_window): Update.
4831
1a4f81dd
TT		 48322019-08-20 Tom Tromey <tom@tromey.com>
4833
4834 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4835 earlier.
4836
0f8d8876
TT		 48372019-08-20 Tom Tromey <tom@tromey.com>
4838
4839 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4840
605dc2c2
TT		 48412019-08-20 Tom Tromey <tom@tromey.com>
4842
4843 * tui/tui-source.h (struct tui_source_window): Update.
4844 * tui/tui-regs.c (tui_show_registers): Update.
4845 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4846 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4847 (NO_REGS_STRING): Remove defines.
4848
aedbe3bb
CM		 48492019-08-20 Conrad Meyer <cem@FreeBSD.org>
4850
4851 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4852 unnecessary thread walk if remote doesn't support the packet.
4853
7ce8f214
TT		 48542019-08-19 Tom Tromey <tromey@adacore.com>
4855
4856 * python/py-value.c (value_has_field): Fix indentation.
4857
f21c2bd7
TT		 48582019-08-19 Tom Tromey <tromey@adacore.com>
4859
4860 * printcmd.c (do_one_display, info_display_command): Update.
4861 * block.h (contained_in): Return bool. Add allow_nested
4862 parameter.
4863 * block.c (contained_in): Return bool. Add allow_nested
4864 parameter.
4865
d806ea2d
TT		 48662019-08-19 Tom Tromey <tom@tromey.com>
4867
4868 * configure: Rebuild.
4869 * configure.ac: Disallow the combination of -static-libstdc++ and
4870 source highlight.
4871 * source-cache.c (get_language_name): Handle rust.
4872 (source_cache::get_source_lines): Ignore highlighting exceptions.
4873
398fdd60
TT		 48742019-08-16 Tom Tromey <tom@tromey.com>
4875
4876 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4877 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4878 (struct tui_source_window_base) <make_visible, refresh_window,
4879 resize>: Remove methods.
4880 <execution_info>: Remove field.
4881 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4882 (tui_show_source_line, tui_source_window_base)
4883 (~tui_source_window_base): Update.
4884 (tui_source_window_base::resize)
4885 (tui_source_window_base::make_visible)
4886 (tui_source_window_base::refresh_window): Remove.
4887 (tui_source_window_base::update_exec_info): Update.
4888 * tui/tui-source.c (tui_source_window::set_contents): Update.
4889 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4890
e699d331
TT		 48912019-08-16 Tom Tromey <tom@tromey.com>
4892
4893 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4894 deprecated_query_hook.
4895
bb01dbfc
TT		 48962019-08-16 Tom Tromey <tom@tromey.com>
4897
4898 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4899 (tui_update_source_windows_with_line): Update.
4900 * tui/tui-source.h (struct tui_source_window)
4901 <show_symtab_source>: Declare.
4902 (tui_show_symtab_source): Don't declare.
4903 * tui/tui-source.c (tui_show_symtab_source): Rename from
4904 tui_show_symtab_source.
4905
81c82c4b
TT		 49062019-08-16 Tom Tromey <tom@tromey.com>
4907
4908 * tui/tui-winsource.h (struct tui_source_window_base)
4909 <set_contents>: Declare.
4910 * tui/tui-winsource.c
4911 (tui_source_window_base::update_source_window_as_is): Update.
4912 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4913 Declare.
4914 (tui_set_source_content): Don't declare.
4915 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4916 tui_set_source_content.
4917 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4918 Declare.
4919 (tui_set_disassem_content): Don't declare.
4920 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4921 tui_set_disassem_content.
4922
2ddaf614
TT		 49232019-08-16 Tom Tromey <tom@tromey.com>
4924
4925 * tui/tui-winsource.h (struct tui_source_window_base)
4926 <update_breakpoint_info>: Declare.
4927 (tui_update_breakpoint_info): Don't declare.
4928 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4929 (tui_update_all_breakpoint_info): Update.
4930 (tui_source_window_base::update_breakpoint_info): Rename from
4931 tui_update_breakpoint_info.
4932 (tui_source_window_base::update_exec_info): Update.
4933
017f9828
TT		 49342019-08-16 Tom Tromey <tom@tromey.com>
4935
4936 * tui/tui-winsource.h (struct tui_source_window_base)
4937 <update_source_window>: Declare.
4938 (tui_update_source_window): Don't declare.
4939 * tui/tui-winsource.c
4940 (tui_source_window_base::update_source_window): Rename from
4941 tui_update_source_window.
4942 (tui_source_window_base::rerender): Update.
4943 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4944 * tui/tui-disasm.c (tui_show_disassem)
4945 (tui_show_disassem_and_update_source)
4946 (tui_disasm_window::maybe_update): Update.
4947
ed8358e9
TT		 49482019-08-16 Tom Tromey <tom@tromey.com>
4949
4950 * tui/tui-winsource.h (struct tui_source_window_base)
4951 <update_source_window_as_is>: Declare.
4952 (tui_update_source_window_as_is): Don't declare.
4953 * tui/tui-winsource.c (tui_update_source_window): Update
4954 (tui_source_window_base::update_source_window_as_is): Rename from
4955 tui_update_source_window_as_is.
4956 (tui_source_window_base::refill): Update.
4957 * tui/tui-source.c (tui_show_symtab_source): Update.
4958 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4959 Update.
4960
20149b6b
TT		 49612019-08-16 Tom Tromey <tom@tromey.com>
4962
4963 * tui/tui-winsource.h (tui_update_source_window)
4964 (tui_update_source_window_as_is): Remove "noerror" parameter.
4965 * tui/tui-winsource.c (tui_update_source_window)
4966 (tui_update_source_window_as_is): Remove "noerror" parameter.
4967 (tui_update_source_windows_with_addr)
4968 (tui_update_source_windows_with_line)
4969 (tui_source_window_base::rerender)
4970 (tui_source_window_base::refill): Update.
4971 * tui/tui-source.h (tui_set_source_content)
4972 (tui_show_symtab_source): Remove "noerror" parameter.
4973 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4974 parameter.
4975 (tui_show_symtab_source): Likewise.
4976 (tui_source_window::maybe_update): Update.
4977 * tui/tui-disasm.c (tui_show_disassem)
4978 (tui_show_disassem_and_update_source)
4979 (tui_disasm_window::do_scroll_vertical)
4980 (tui_disasm_window::maybe_update): Update.
4981
2d83e710
TT		 49822019-08-16 Tom Tromey <tom@tromey.com>
4983
4984 * tui/tui.c (tui_is_window_visible): Update.
4985 * tui/tui-wingeneral.c (tui_make_window)
4986 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4987 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4988 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4989 (tui_set_win_height_command, parse_scrolling_args): Update.
4990 * tui/tui-source.c (tui_source_window::style_changed): Update.
4991 * tui/tui-regs.c (tui_show_registers)
4992 (tui_data_window::first_data_item_displayed)
4993 (tui_data_window::delete_data_content_windows)
4994 (tui_check_register_values, tui_reg_command): Update.
4995 * tui/tui-disasm.c (tui_show_disassem): Update.
4996 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4997 method.
4998 <is_visible>: Remove field.
4999 * tui/tui-data.c (tui_next_win, tui_prev_win)
5000 (tui_delete_invisible_windows): Update.
5001
d4ab829a
TT		 50022019-08-16 Tom Tromey <tom@tromey.com>
5003
5004 * tui/tui-winsource.h (struct tui_source_window_base)
5005 <m_has_locator>: Remove.
5006 * tui/tui-layout.c (show_source_disasm_command, show_data)
5007 (show_source_or_disasm_and_command): Update.
5008
aa7ca1bb
AH		 50092019-08-16 Alan Hayward <alan.hayward@arm.com>
5010
5011 * NEWS (Other MI changes): New subsection.
5012 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5013 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5014 * arch-utils.c (default_get_pc_address_flags): New function.
5015 * arch-utils.h (default_get_pc_address_flags): New declaration.
5016 * gdbarch.sh: Add get_pc_address_flags.
5017 * gdbarch.c: Regenerate.
5018 * gdbarch.h: Likewise.
5019 * stack.c (print_pc): New function.
5020 (print_frame_info) (print_frame): Call print_pc.
5021
6eac171f
TV		 50222019-08-16 Tom de Vries <tdevries@suse.de>
5023
5024 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5025 print_objfile_section_info.
5026
3df505f6
TT		 50272019-08-15 Tom Tromey <tom@tromey.com>
5028
5029 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5030 calling update_cmdwin_start_line.
5031 * tui/tui-winsource.h (struct tui_source_window_base)
5032 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5033 <rerender>: Declare.
5034 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5035 Call rerender.
5036 (tui_source_window_base::set_new_height): Remove.
5037 (tui_source_window_base::rerender): Rename from
5038 do_make_visible_with_new_height.
5039 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5040 resize method.
5041 (tui_win_info::make_invisible_and_set_new_height)
5042 (tui_win_info::make_visible_with_new_height): Remove.
5043 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5044 Declare.
5045 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5046 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5047 do_make_visible_with_new_height>: Don't declare.
5048 <rerender>: Declare.
5049 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5050 set_new_height.
5051 (tui_data_window::do_make_visible_with_new_height): Remove.
5052 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5053 call tui_show_locator_content.
5054 (tui_gen_win_info::resize): Call rerender.
5055 (show_source_or_disasm_and_command): Don't call
5056 tui_show_locator_content.
5057 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5058 method.
5059 (struct tui_win_info) <rerender>: Declare.
5060 <set_new_height, make_invisible_and_set_new_height,
5061 make_visible_with_new_height>: Don't declare.
5062 * tui/tui-data.c (tui_win_list::rerender): New method.
5063 * tui/tui-command.h (struct tui_cmd_window)
5064 <do_make_visible_with_new_height>: Don't declare.
5065 * tui/tui-command.c
5066 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5067
272560b5
TT		 50682019-08-15 Tom Tromey <tromey@adacore.com>
5069
5070 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5071 * ada-lang.c (ada_enum_name): Likewise.
5072
08235187
CB		 50732019-08-15 Christian Biesinger <cbiesinger@google.com>
5074
5075 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5076 leading underscore.
5077 (GdbOutputErrorFile): Likewise.
5078 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5079 accordingly.
5080 (execute_unwinders): Rename to have a leading underscore.
5081 (auto_load_packages): Likewise.
5082 (global scope): Adjust call to auto_load_packages accordingly.
5083 (GdbSetPythonDirectory): Likewise.
5084 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5085 instead of execute_unwinders.
5086
db502012
TT		 50872019-08-15 Tom Tromey <tom@tromey.com>
5088
5089 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5090 (show_data): Don't change window visibility.
5091 (tui_gen_win_info::resize): Remove special case for command
5092 window. Use wresize, when available.
5093 (show_source_or_disasm_and_command): Don't change window
5094 visibility.
5095 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5096 <make_visible>: New method.
5097 * tui/tui-command.c (tui_cmd_window::resize): New method.
5098
3891b65e
TT		 50992019-08-15 Tom Tromey <tom@tromey.com>
5100
5101 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5102 (struct tui_source_windows): New.
5103 * tui/tui-winsource.c (tui_display_main): Update.
5104 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5105 (new_height_ok, parse_scrolling_args): Update.
5106 * tui/tui-layout.c (show_layout, show_data): Update.
5107 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5108 (tui_add_to_source_windows): Don't declare.
5109 * tui/tui-data.c (source_windows, tui_source_windows)
5110 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5111
ee556432
TT		 51122019-08-15 Tom Tromey <tom@tromey.com>
5113
5114 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5115 Rename from reset.
5116 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5117 * tui/tui-layout.c (show_source_disasm_command, show_data):
5118 Update.
5119 (tui_gen_win_info::resize): Rename.
5120 (show_source_or_disasm_and_command): Update.
5121 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5122 reset.
5123
46f438e3
TT		 51242019-08-15 Tom Tromey <tom@tromey.com>
5125
5126 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5127 * tui/tui-interp.c (tui_interp::init): Don't call
5128 tui_initialize_static_data.
5129 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5130
f4ce562c
TT		 51312019-08-15 Tom Tromey <tom@tromey.com>
5132
5133 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5134 examine tui_win_list.
5135
c398c3d0
TT		 51362019-08-15 Tom Tromey <tom@tromey.com>
5137
5138 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5139 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5140 tui_clear_source_content.
5141 (tui_clear_source_content): Remove.
5142 (tui_source_window_base::do_erase_source_content): Hoist call to
5143 content.clear().
5144 * tui/tui-stack.c (tui_show_frame_info): Don't call
5145 tui_clear_source_content.
5146
e25d2004
TT		 51472019-08-15 Tom Tromey <tom@tromey.com>
5148
5149 * tui/tui-winsource.h (struct tui_source_window_base)
5150 <do_erase_source_content>: New method.
5151 <erase_source_content>: New method.
5152 (tui_erase_source_content): Don't declare.
5153 * tui/tui-winsource.c (tui_clear_source_content): Update.
5154 (tui_source_window_base::do_erase_source_content): Rename from
5155 tui_erase_source_content.
5156 (tui_source_window_base::show_source_content): Update.
5157 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5158 * tui/tui-source.h (struct tui_source_window)
5159 <erase_source_content>: New method.
5160 * tui/tui-disasm.h (struct tui_disasm_window)
5161 <erase_source_content>: New method.
5162
002f15c2
TT		 51632019-08-15 Tom Tromey <tom@tromey.com>
5164
5165 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5166 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5167 constructor.
5168 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5169 * tui/tui-source.c (tui_set_source_content): Update.
5170 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5171
c9033fe8
TT		 51722019-08-15 Tom Tromey <tom@tromey.com>
5173
5174 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5175 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5176 tui-source.c.
5177 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5178 Declare.
5179 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5180 method.
5181 (tui_source_window::maybe_update): Update.
5182
088f37dd
TT		 51832019-08-15 Tom Tromey <tom@tromey.com>
5184
5185 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5186 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5187 tui-disasm.c.
5188 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5189 Declare.
5190 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5191 method.
5192 (tui_disasm_window::maybe_update): Update.
5193
a54700c6
TT		 51942019-08-15 Tom Tromey <tom@tromey.com>
5195
5196 * tui/tui-winsource.h (struct tui_source_window_base)
5197 <maybe_update>: Declare.
5198 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5199 method.
5200 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5201 Declare.
5202 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5203 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5204 Declare.
5205 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5206
e2a678a5
TT		 52072019-08-15 Tom Tromey <tom@tromey.com>
5208
5209 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5210
f2dda477
TT		 52112019-08-15 Tom Tromey <tom@tromey.com>
5212
5213 * tui/tui-wingeneral.c: Include tui-stack.h.
5214 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5215 (struct tui_locator_window): Move from tui-data.h.
5216 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5217 (tui_initialize_static_data): Move from tui-data.c.
5218 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5219 (struct tui_locator_window): Move to tui-stack.c.
5220 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5221 (tui_initialize_static_data): Move to tui-stack.c.
5222
ed4a1084
TT		 52232019-08-15 Tom Tromey <tom@tromey.com>
5224
5225 * tui/tui-layout.c (show_source_disasm_command)
5226 (show_source_or_disasm_and_command): Use make_visible method, not
5227 tui_make_window.
5228 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5229 Remove.
5230
65962b20
TT		 52312019-08-15 Tom Tromey <tom@tromey.com>
5232
5233 * tui/tui-wingeneral.h (tui_make_window): Update.
5234 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5235 parameter.
5236 (tui_gen_win_info::make_visible): Update.
5237 * tui/tui-regs.c (tui_data_window::display_registers_from):
5238 Update.
5239 * tui/tui-layout.c (show_source_disasm_command)
5240 (show_source_or_disasm_and_command): Update.
5241 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5242 (enum tui_box): Remove.
5243 (struct tui_win_info) <can_box>: New method.
5244 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5245 method.
5246
2208ee91
TV		 52472019-08-15 Tom de Vries <tdevries@suse.de>
5248
5249 * linux-nat-trad.c: Include gdbarch.h.
5250
75faf5c4
AH		 52512019-08-14 Alan Hayward <alan.hayward@arm.com>
5252
5253 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5254 register sizes.
5255
b1c896b3
TT		 52562019-08-14 Tom Tromey <tromey@adacore.com>
5257
5258 * darwin-nat.c: Include gdbarch.h.
5259 * darwin-nat-info.c: Include gdbarch.h.
5260
6405cd73
TT		 52612019-08-13 Tom Tromey <tom@tromey.com>
5262
5263 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5264 Remove.
5265 * tui/tui-data.c (tui_initialize_static_data): Update.
5266
5216580d
TT		 52672019-08-13 Tom Tromey <tom@tromey.com>
5268
5269 * tui/tui-winsource.h (struct tui_exec_info_window)
5270 <~tui_exec_info_window, maybe_allocate_content, get_content,
5271 m_content>: Remove.
5272 (struct tui_source_window_base) <set_exec_info_content,
5273 show_exec_info_content>: Don't declare.
5274 * tui/tui-winsource.c
5275 (tui_exec_info_window::maybe_allocate_content): Remove.
5276 (tui_source_window_base::update_exec_info): Rename from
5277 set_exec_info_content.
5278 (tui_source_window_base::show_exec_info_content)
5279 (tui_source_window_base::update_exec_info): Remove.
5280
93858ad3
TT		 52812019-08-13 Tom Tromey <tom@tromey.com>
5282
5283 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5284 declare.
5285 * tui/tui-winsource.c (tui_update_source_window_as_is)
5286 (tui_update_source_windows_with_addr, tui_erase_source_content):
5287 Update.
5288 (tui_clear_exec_info_content): Remove.
5289
e321e7ce
TT		 52902019-08-13 Tom Tromey <tom@tromey.com>
5291
5292 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5293 declare.
5294 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5295 call tui_erase_exec_info_content.
5296 (tui_clear_exec_info_content): Rename from
5297 tui_erase_exec_info_content.
5298 (tui_clear_exec_info_content): Delete.
5299
8270ac62
TT		 53002019-08-13 Tom Tromey <tom@tromey.com>
5301
5302 * tui/tui-winsource.h (struct tui_source_window_base)
5303 <show_exec_info_content>: Declare.
5304 (tui_show_exec_info_content): Don't declare.
5305 * tui/tui-winsource.c
5306 (tui_source_window_base::show_exec_info_content): Rename from
5307 tui_show_exec_info_content.
5308 (tui_source_window_base::update_exec_info): Update.
5309
7b56485d
TT		 53102019-08-13 Tom Tromey <tom@tromey.com>
5311
5312 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5313 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5314 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5315 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5316 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5317 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5318 ... here.
5319
7ba913dc
TT		 53202019-08-13 Tom Tromey <tom@tromey.com>
5321
5322 * tui/tui-winsource.h (struct tui_source_window_base)
5323 <update_exec_info>: Declare.
5324 (tui_update_exec_info): Don't declare.
5325 * tui/tui-winsource.c (tui_update_source_window_as_is)
5326 (tui_source_window_base::refresh_all)
5327 (tui_update_all_breakpoint_info): Update.
5328 (tui_source_window_base::update_exec_info): Rename from
5329 tui_update_exec_info.
5330 * tui/tui-stack.c (tui_show_frame_info): Update.
5331
37a4a131
TT		 53322019-08-13 Tom Tromey <tom@tromey.com>
5333
5334 * tui/tui-winsource.h (struct tui_source_window_base)
5335 <set_exec_info_content>: Declare.
5336 (tui_set_exec_info_content): Don't declare.
5337 * tui/tui-winsource.c
5338 (tui_source_window_base::set_exec_info_content): Rename from
5339 tui_set_exec_info_content.
5340 (tui_update_exec_info): Update.
5341
0bd27e07
TT		 53422019-08-13 Tom Tromey <tom@tromey.com>
5343
5344 * tui/tui-winsource.h (struct tui_source_window_base)
5345 <show_source_content>: Declare.
5346 (tui_show_source_content): Don't declare.
5347 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5348 (tui_source_window_base::show_source_content): Rename from
5349 tui_show_source_content.
5350 (tui_source_window_base::refresh_all): Update.
5351 * tui/tui-layout.c (show_source_disasm_command)
5352 (show_source_or_disasm_and_command): Update.
5353
b4ef5aeb
TT		 53542019-08-13 Tom Tromey <tom@tromey.com>
5355
5356 * tui/tui-winsource.c (tui_erase_source_content)
5357 (tui_show_source_content, tui_source_window_base::refresh_all):
5358 Update.
5359 * tui/tui-wingeneral.h
5360 (tui_check_and_display_highlight_if_needed): Don't declare.
5361 * tui/tui-wingeneral.c
5362 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5363 check_and_display_highlight_if_needed.
5364 * tui/tui-win.c (tui_rehighlight_all)
5365 (tui_win_info::make_visible_with_new_height): Update.
5366 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5367 (tui_data_window::erase_data_content)
5368 (tui_data_window::display_all_data): Update.
5369 * tui/tui-data.h (struct tui_win_info)
5370 <check_and_display_highlight_if_needed>: Declare.
5371
fede5273
TT		 53722019-08-13 Tom Tromey <tom@tromey.com>
5373
5374 * tui/tui-win.c (tui_resize_all): Call
5375 tui_delete_invisible_windows.
5376 * tui/tui-layout.c (show_layout): Call
5377 tui_delete_invisible_windows.
5378 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5379 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5380
22c3f490
TT		 53812019-08-13 Tom Tromey <tom@tromey.com>
5382
5383 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5384 tui_add_win_to_layout.
5385
16cb7910
TT		 53862019-08-13 Tom Tromey <tom@tromey.com>
5387
5388 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5389 * tui/tui-layout.c (tui_default_win_height): Now static.
5390
cc0c3ffb
TT		 53912019-08-13 Tom Tromey <tom@tromey.com>
5392
5393 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5394 single switch.
5395 (show_source_disasm_command, show_source_or_disasm_and_command):
5396 Don't check current layout.
5397
3f3ffe54
TT		 53982019-08-13 Tom Tromey <tom@tromey.com>
5399
5400 * tui/tui-wingeneral.c (make_all_visible): Remove.
5401 (tui_make_all_invisible): Simplify.
5402 * tui/tui-layout.c (tui_make_all_invisible): Move from
5403 tui-wingeneral.c; simplify.
5404 (show_layout): Hoist call to tui_make_all_invisible.
5405 (show_data): Don't call tui_make_all_invisible.
5406
69258091
TT		 54072019-08-13 Tom Tromey <tom@tromey.com>
5408
5409 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5410 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5411
62cf57fe
TT		 54122019-08-13 Tom Tromey <tom@tromey.com>
5413
5414 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5415 tui-data.c.
5416 (show_source_disasm_command, show_data)
5417 (show_source_or_disasm_and_command): Don't use
5418 tui_set_current_layout_to.
5419 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5420 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5421 tui-layout.c.
5422 (tui_set_current_layout_to): Remove.
5423
2afade5d
TT		 54242019-08-13 Tom Tromey <tom@tromey.com>
5425
5426 * tui/tui-layout.c (tui_set_layout): Update.
5427 * tui/tui-data.h (struct tui_layout_def): Remove.
5428 (tui_layout_def): Don't declare.
5429 * tui/tui-data.c (layout_def): Remove.
5430 (tui_layout_def): Remove.
5431
a3504e96
TT		 54322019-08-13 Tom Tromey <tom@tromey.com>
5433
5434 * tui/tui-winsource.h (struct tui_source_window_base)
5435 <clear_detail>: No longer "override".
5436 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5437 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5438 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5439 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5440 Remove.
5441 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5442
29c92911
TT		 54432019-08-13 Tom Tromey <tromey@adacore.com>
5444
5445 * tracepoint.c: Don't include readline.h or history.h.
5446
86c6b807
TT		 54472019-08-12 Tom Tromey <tom@tromey.com>
5448
5449 * configure: Rebuild.
5450 * configure.ac: Check for readline 7.
5451 * NEWS: Mention readline 7 requirement.
5452 * README: Update.
5453
5db2718c
TT		 54542019-08-12 Tom Tromey <tom@tromey.com>
5455
5456 * mingw-hdep.c (gdb_select): Remove readline hack.
5457
dac36daf
PFC		 54582019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5459
5460 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5461 when the function fails.
5462
1022c627
AA		 54632019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5464
5465 * s390-tdep.c (s390_type_align): New function.
5466 (s390_gdbarch_init): Set it as type_align gdbarch method.
5467
eba4caf2
TV		 54682019-08-09 Tom de Vries <tdevries@suse.de>
5469
5470 PR gdb/24591
5471 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5472 pc_low with relocation offset.
5473
123cd851
TT		 54742019-08-07 Tom Tromey <tromey@adacore.com>
5475
5476 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5477 (print_frame_args): Update.
5478 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5479 Update.
5480 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5481 * frame.h (struct frame_arg): Add initializers.
5482 <error>: Now a unique_xmalloc_ptr.
5483
3d31bc39
AH		 54842019-08-07 Alan Hayward <alan.hayward@arm.com>
5485
5486 * NEWS: Expand the Pointer Authentication entry.
5487 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5488 (aarch64_frame_unmask_lr): ... to this.
5489 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5490 Call aarch64_frame_unmask_lr.
5491 * frame.c (struct frame_info): Add "masked" variable.
5492 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5493 (fprint_frame): Check for masked pc.
5494 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5495 declarations.
5496 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5497 * stack.c (print_frame): Check for masked pc.
5498
0cf9feb9
TT		 54992019-08-06 Tom Tromey <tom@tromey.com>
5500
5501 * stabsread.c (patch_block_stabs, read_one_struct_field)
5502 (read_enum_type): Use obstack_strndup.
5503 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5504 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5505 * dwarf2read.c (guess_full_die_structure_name)
5506 (anonymous_struct_prefix): Use obstack_strndup.
5507 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5508 * c-exp.y (yylex): Use obstack_strndup.
5509 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5510 (write_var_or_type): Use obstack_strndup.
5511
efba19b0
TT		 55122019-08-06 Tom Tromey <tom@tromey.com>
5513
5514 * symfile.c (reread_symbols): Use obstack_strdup.
5515 * stabsread.c (read_type): Use obstack_strdup.
5516 * gdb_obstack.h (obstack_strdup): New overload.
5517 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5518 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5519 (dwarf2_canonicalize_name): Use obstack_strdup.
5520 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5521 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5522 Use obstack_strdup.
5523
f25102f7
TT		 55242019-08-06 Tom Tromey <tom@tromey.com>
5525
5526 * gdb_obstack.h (obstack_strdup): Define.
5527 * gdb_obstack.c (obstack_strdup): Don't define.
5528
021887d8
TT		 55292019-08-06 Tom Tromey <tom@tromey.com>
5530
5531 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5532 obstack_strdup.
5533 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5534 obstack_strdup.
5535 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5536 * stabsread.c (common_block_start): Use obstack_strdup.
5537 * objfiles.c (set_objfile_main_name, objfile): Use
5538 obstack_strdup.
5539 * namespace.c (add_using_directive): Use obstack_strdup.
5540 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5541 * jit.c (finalize_symtab): Use obstack_strdup.
5542 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5543 (guess_partial_die_structure_name, partial_die_info::fixup)
5544 (dwarf2_name): Use obstack_strdup.
5545 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5546 obstack_strdup.
5547 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5548 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5549 obstack_strdup.
5550 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5551
d2834edc
PW		 55522019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5553
5554 * unittests/help-doc-selftests.c: New file.
5555 * Makefile.in: Add the new file.
5556
590042fc
PW		 55572019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5558
5559 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5560 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5561 the full first line, except when FOR_VALUE_PREFIX. In this case,
5562 the trailing '.' is not output, and the first character is uppercased.
5563 (print_help_for_command): Update call to print_doc_line.
5564 (print_doc_of_command): Likewise.
5565 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5566 * cli/cli-option.c (append_indented_doc): Do not append newline.
5567 (build_help_option): Append newline after first appended_indented_doc
5568 only if a second call is done.
5569 (build_help): Append 2 new lines before each option, except the first
5570 one.
5571 * compile/compile.c (_initialize_compile): Add new lines after
5572 %OPTIONS%, when not at the end of the help.
5573 Change help doc or code
5574 producing the help doc to respect the invariants.
5575 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5576 Also removed the new line after 'Options:', as all other commands
5577 do not put an empty line between 'Options:' and the first option.
5578 * printcmd.c (_initialize_printcmd): Likewise.
5579 * stack.c (_initialize_stack): Likewise.
5580 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5581 incorrectly telling COMMAND is optional.
5582 * ada-lang.c (_initialize_ada_language): Change help doc or code
5583 producing the help doc to respect the invariants.
5584 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5585 * breakpoint.c (_initialize_breakpoint): Likewise.
5586 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5587 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5588 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5589 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5590 _initialize_cli_style): Likewise.
5591 * corelow.c (core_target_info): Likewise.
5592 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5593 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5594 * filesystem.c (_initialize_filesystem): Likewise.
5595 * frame.c (_initialize_frame): Likewise.
5596 * gnu-nat.c (add_task_commands): Likewise.
5597 * infcall.c (_initialize_infcall): Likewise.
5598 * infcmd.c (_initialize_infcmd): Likewise.
5599 * interps.c (_initialize_interpreter): Likewise.
5600 * language.c (_initialize_language): Likewise.
5601 * linux-fork.c (_initialize_linux_fork): Likewise.
5602 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5603 * maint.c (_initialize_maint_cmds): Likewise.
5604 * memattr.c (_initialize_mem): Likewise.
5605 * printcmd.c (_initialize_printcmd): Likewise.
5606 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5607 _RegEx): Likewise.
5608 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5609 * record-btrace.c (_initialize_record_btrace): Likewise.
5610 * record-full.c (_initialize_record_full): Likewise.
5611 * record.c (_initialize_record): Likewise.
5612 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5613 * regcache.c (_initialize_regcache): Likewise.
5614 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5615 _initialize_remote): Likewise.
5616 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5617 * serial.c (_initialize_serial): Likewise.
5618 * skip.c (_initialize_step_skip): Likewise.
5619 * source.c (_initialize_source): Likewise.
5620 * stack.c (_initialize_stack): Likewise.
5621 * symfile.c (_initialize_symfile): Likewise.
5622 * symtab.c (_initialize_symtab): Likewise.
5623 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5624 * top.c (init_main): Likewise.
5625 * tracefile-tfile.c (tfile_target_info): Likewise.
5626 * tracepoint.c (_initialize_tracepoint): Likewise.
5627 * tui/tui-win.c (_initialize_tui_win): Likewise.
5628 * utils.c (add_internal_problem_command): Likewise.
5629 * valprint.c (value_print_option_defs): Likewise.
5630
404f2902
FCE		 56312019-08-06 Frank Ch. Eigler <fche@redhat.com>
5632
5633 PR build/24886
5634 * configure.ac: Drop enable-libmcheck support.
5635 * configure, config.in: Rebuild.
5636 * libmcheck.m4: Remove.
5637 * acinclude.m4: Don't include it.
5638 * Makefile.in: Don't distribute it.
5639 * top.c (print_gdb_configuration): Don't mention it.
5640
046bebe1
TT		 56412019-08-06 Tom Tromey <tom@tromey.com>
5642
5643 * utils.c (set_output_style): Sometimes pass stream to
5644 emit_style_escape.
5645 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5646 * record-btrace.c (btrace_insn_history): Update.
5647 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5648 method.
5649 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5650 Update initializers.
5651 <m_uiout>: New field.
5652 <m_di>: Move lower.
5653 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5654 Remove "uiout" parameter.
5655 (dump_insns): Update.
5656 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5657 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5658
ddbcedf5
CB		 56592019-08-06 Christian Biesinger <cbiesinger@google.com>
5660
5661 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5662 (error_in_psymtab_expansion): Likewise.
5663 (lookup_symbol_via_quick_fns): Likewise.
5664 (basic_lookup_transparent_type_quick): Likewise.
5665 (basic_lookup_transparent_type_1): Likewise.
5666
b08b16c8
TT		 56672019-08-06 Tom Tromey <tromey@adacore.com>
5668
5669 * source.c (last_source_error): Now bool.
5670 (print_source_lines_base): Make "noprint" bool. Only open
5671 source file when last_source_visited changes.
5672
cb44333d
TT		 56732019-08-06 Tom Tromey <tromey@adacore.com>
5674
5675 * annotate.c (annotate_source_line): Use g_source_cache.
5676 * source-cache.c (source_cache::get_plain_source_lines): Change
5677 parameters. Populate m_offset_cache.
5678 (source_cache::ensure): New method.
5679 (source_cache::get_line_charpos): New method.
5680 (extract_lines): Move lower. Change parameters.
5681 (source_cache::get_source_lines): Move lower.
5682 * source-cache.h (class source_cache): Update comment.
5683 <get_line_charpos>: New method.
5684 <get_source_lines>: Update comment.
5685 <clear>: Clear m_offset_cache.
5686 <get_plain_source_lines>: Change parameters.
5687 <ensure>: New method
5688 <m_offset_cache>: New member.
5689 * source.c (forget_cached_source_info_for_objfile): Update.
5690 (info_source_command): Use g_source_cache.
5691 (find_source_lines, open_source_file_with_line_charpos): Remove.
5692 (print_source_lines_base, search_command_helper): Use g_source_cache.
5693 * source.h (open_source_file_with_line_charpos): Don't declare.
5694 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5695 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5696 Use g_source_cache.
5697
872dceaa
TT		 56982019-08-06 Tom Tromey <tromey@adacore.com>
5699
5700 * source-cache.c (source_cache::get_plain_source_lines):
5701 Remove "first_line" and "last_line" parameters.
5702 (source_cache::get_source_lines): Cache plain text.
5703 * source-cache.h (class source_cache)
5704 <get_plain_source_lines>: Update.
5705
269249d9
TT		 57062019-08-06 Tom Tromey <tromey@adacore.com>
5707
5708 * source-cache.c (extract_lines): No longer a method.
5709 Changed type of parameter. Include final newline.
5710 (selftests::extract_lines_test): New function.
5711 (_initialize_source_cache): Likewise.
5712 * source-cache.h (class source_cache)
5713 <extract_lines>: Don't declare.
5714
c0e8dcd8
TT		 57152019-08-06 Tom Tromey <tromey@adacore.com>
5716
5717 * breakpoint.c (init_breakpoint_sal): Update.
5718 (breakpoint): Update.
5719 * breakpoint.h (struct breakpoint) <filter>: Now a
5720 unique_xmalloc_ptr.
5721
0b27c27d
CB		 57222019-08-05 Christian Biesinger <cbiesinger@google.com>
5723
5724 * NEWS: Mention dictionary access on blocks.
5725 * python/py-block.c (blpy_getitem): New function.
5726 (block_object_as_mapping): New struct.
5727 (block_object_type): Use new struct for tp_as_mapping field.
5728
4ee94178
CB		 57292019-08-05 Christian Biesinger <cbiesinger@google.com>
5730
5731 * objfiles.h (objfile): Add a comment describing partial symbols.
5732
8abfcabc
TT		 57332019-08-05 Tom Tromey <tromey@adacore.com>
5734
5735 * compile/compile.c (_initialize_compile): Use _(), not N_().
5736 * thread.c (_initialize_thread): Use _(), not N_().
5737 * stack.c (_initialize_stack): Use _(), not N_().
5738 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5739
2b79f376
SM		 57402019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5741
5742 * dwarf2read.c (struct dw2_symtab_iterator):
5743 <want_specific_block>: Remove.
5744 <block_index>: Change type to gdb::optional.
5745 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5746 change type of BLOCK_INDEX parameter to gdb::optional.
5747 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5748 (dw2_lookup_symbol): Don't pass argument for
5749 WANT_SPECIFIC_BLOCK.
5750 (dw2_expand_symtabs_for_function): Don't pass argument for
5751 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5752 (class dw2_debug_names_iterator)
5753 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5754 parameter, change BLOCK_INDEX type to gdb::optional.
5755 <m_want_specific_block>: Remove.
5756 <m_block_index>: Change type to gdb::optional.
5757 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5758 gdb::optional. Re-write in function of gdb::optional.
5759 (dw2_debug_names_lookup_symbol): Don't pass argument for
5760 WANT_SPECIFIC_BLOCK.
5761 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5762 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5763 BLOCK_INDEX.
5764
ae60f04e
PW		 57652019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5766
5767 * NEWS: Mention changes to "info sources" command.
5768
28cd9371
PW		 57692019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5770
5771 * symtab.c (filename_partial_match_opts): New struct type.
5772 (struct output_source_filename_data): New members
5773 regexp, c_regexp, partial_match.
5774 (output_source_filename): Use new members to decide to print file.
5775 (info_sources_option_defs): New variable.
5776 (make_info_sources_options_def_group, print_info_sources_header,
5777 info_sources_command_completer):
5778 New functions.
5779 (info_sources_command): Read new optional arguments.
5780 (_initialize_symtab): Update info sources help.
5781
ca683e3a
AO		 57822019-08-02 Alexandre Oliva <oliva@adacore.com>
5783
5784 * ada-lang.c (exception_support_info_v0): Renamed from...
5785 (default_exception_support_info): ... this. Create new
5786 definition for v1.
5787 (ada_has_this_exception_support): Look up catch_handlers_sym.
5788 (ada_exception_support_info_sniffer): Try v0 after default.
5789
f1264162
TT		 57902019-08-01 Tom Tromey <tromey@adacore.com>
5791
5792 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5793 gdbarch.h.
5794
0a7b2485
CB		 57952019-08-01 Christian Biesinger <cbiesinger@google.com>
5796
5797 * s12z-tdep.c: Fix include path for s12z-opc.h.
5798
c6bdbeb7
AH		 57992019-08-01 Alan Hayward <alan.hayward@arm.com>
5800
5801 * NEWS: Require GNU make 3.82.
5802
a2bd7b82
TT		 58032019-07-16 Tom Tromey <tom@tromey.com>
5804
5805 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5806 declare.
5807
aa3b6533
TT		 58082019-07-30 Tom Tromey <tromey@adacore.com>
5809
5810 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5811
a1530dc7
KB		 58122019-07-30 Kevin Buettner <kevinb@redhat.com>
5813
5814 * printcmd.c (print_address_symbolic): Print negative offsets.
5815 (build_address_symbolic): Force signed arithmetic when computing
5816 offset.
5817
2906593f
CB		 58182019-07-30 Christian Biesinger <cbiesinger@google.com>
5819
5820 PR/24474: Add a function to lookup static variables.
5821 * NEWS: Mention this new function.
5822 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5823 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5824 * python/python.c (python_GdbMethods): Add new function.
5825
c620ed88
CB		 58262019-07-29 Christian Biesinger <cbiesinger@google.com>
5827
5828 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5829 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5830 (objfpy_lookup_static_symbol): New function.
5831 (objfile_object_methods): Add new functions.
5832
bc4268a5
PW		 58332019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5834
5835 * NEWS: Mention 'set|show print frame-info'. Mention new
5836 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5837 backtrace argument. Mention that python frame filtering code
5838 is now consistent with what 'backtrace' command prints.
5839
4b5e8d19
PW		 58402019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5841
5842 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5843 comments.
5844 (print_frame_info_auto, print_frame_info_source_line,
5845 print_frame_info_location, print_frame_info_source_and_location,
5846 print_frame_info_location_and_address, print_frame_info_short_location):
5847 New declarations.
5848 (struct frame_print_options): New member print_frame_info.
5849 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5850 * stack.h (get_user_print_what_frame_info): New declaration.
5851 (frame_show_address): New declaration.
5852 * stack.c (print_frame_arguments_choices): New value 'presence'.
5853 (print_frame_info_auto, print_frame_info_source_line,
5854 print_frame_info_location, print_frame_info_source_and_location,
5855 print_frame_info_location_and_address, print_frame_info_short_location,
5856 print_frame_info_choices, print_frame_info_print_what): New definitions.
5857 (print_frame_args): Only print dots for args if print frame-arguments
5858 is 'presence'.
5859 (frame_print_option_defs): New element for "frame-info".
5860 (get_user_print_what_frame_info): New function.
5861 (frame_show_address): Make non static. Move comment to stack.h.
5862 (print_frame_info_to_print_what): New function.
5863 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5864 to decide what to print.
5865 (backtrace_command_1): Handle the new print_frame_arguments_presence
5866 value.
5867 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5868 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5869 (py_print_frame): In non-mi mode, use LOCATION as default for
5870 print_what, similarly to frame information printed directly by
5871 backtrace command. Handle frame-info user option in non MI mode.
5872
6bdfee81
KB		 58732019-07-27 Kevin Buettner <kevinb@redhat.com>
5874
5875 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5876 Add case for debugging 32-bit target on 64-bit host. Revise
5877 comment.
5878
98a617f8
KB		 58792019-07-27 Kevin Buettner <kevinb@redhat.com>
5880
5881 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5882 instead of find_function_entry_range_from_pc.
5883
567238c9
KB		 58842019-07-27 Kevin Buettner <kevinb@redhat.com>
5885
5886 * stack.c (find_frame_funname): Remove code which preferred
5887 minsym over symtab sym in "certain pathological cases".
5888
2dc80cf8
KB		 5889 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5890 parameter. Change type of "do_demangle" to bool.
5891 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5892 Pass suitable "prefer_sym_over_minsym" flag to
5893 build_address_symbolic(). Don't output "+" for negative offsets.
5894 * printcmd.c (print_address_symbolic): Update invocation of
5895 build_address_symbolic to include a "prefer_sym_over_minsym"
5896 flag.
5897 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5898 Restrict cases in which use of minimal symbol is preferred to that
5899 of a found symbol. Update comments.
5900
1aff7173
KB		 5901 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5902 for entry pc when entry pc is out of range for that FDE.
5903
89b085ac
BC		 59042019-07-26 Brian Callahan <bcallah@openbsd.org>
5905
5906 PR gdb/24839:
5907 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5908 type.
5909
f32feb4a
CB		 59102019-07-25 Christian Biesinger <cbiesinger@google.com>
5911
5912 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5913 this function's Python signature.
5914
5915
59162019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB		 5917
5918 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5919 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5920 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5921 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5922 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5923
5924
c54e4253
YS		 59252019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5926
5927 * h8300-tdep.c (h8300_register_name_common): New.
5928 h8300_register_name): Use h8300_register_name_common.
5929 (h8300s_register_name): Likewise.
5930 (h8300sx_register_name): Likewise.
5931 (h8300h_register_nam): New.
5932 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5933
5934
40eadf04
SP		 59352019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5936
5937 * arm-tdep.c (arm_skip_cmse_entry): New function.
5938 (arm_is_sgstubs_section): New function.
5939 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5940
bfa2a36d
TT		 59412019-07-22 Tom Tromey <tom@tromey.com>
5942
5943 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5944 Don't self-assign.
5945
a8e9d247
AB		 59462019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5947
5948 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5949 type_print.
5950
eb86c5e2
AB		 59512019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5952
5953 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5954 so that GDB doesn't match any msymbols when searching in the
5955 TYPES_DOMAIN.
5956 (print_symbol_info): Print using typedef_print or type_print based
5957 on the type of the symbol. Add updated FIXME comment moved from...
5958 (_initialize_symtab): ... move and update FIXME comment to above.
5959
a8eab7c6
AB		 59602019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5961
5962 * NEWS: Mention adding -q option to "info types".
5963 * symtab.c (struct info_types_options): New struct.
5964 (info_types_options_defs): New variable.
5965 (make_info_types_options_def_group): New function.
5966 (info_types_command): Use gdb::option framework to parse options.
5967 (info_types_command_completer): New function.
5968 (_initialize_symtab): Extend the help text on "info types" and
5969 register command completer.
5970
b4603c34
CB		 59712019-07-21 Christian Biesinger <cbiesinger@google.com>
5972
5973 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5974 (lookup_symbol_in_objfile): Change int to block_enum and add a
5975 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5976
c8cdc1e0
CB		 59772019-07-20 Christian Biesinger <cbiesinger@google.com>
5978
5979 * MAINTAINERS (Write After Approval): Add self.
5980
01e175fe
AB		 59812019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
5982
5983 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5984 instruction to the dummy code region.
5985
56f79b63
TT		 59862019-07-19 Tom Tromey <tromey@adacore.com>
5987
5988 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5989 (ARGSUSED, PARAMS, __func__): Remove rules.
5990
4c5aa8e0
AH		 59912019-07-19 Alan Hayward <alan.hayward@arm.com>
5992
5993 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5994 * features/arm/arm-with-iwmmxt.c: Remove.
5995 * features/arm/arm-with-iwmmxt.xml: Remove.
5996 * features/arm/arm-with-m-fpa-layout.c: Remove.
5997 * features/arm/arm-with-m-fpa-layout.xml: Remove.
5998 * features/arm/arm-with-m-vfp-d16.c: Remove.
5999 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6000 * features/arm/arm-with-m.c: Remove.
6001 * features/arm/arm-with-m.xml: Remove.
6002 * features/arm/arm-with-neon.c: Remove.
6003 * features/arm/arm-with-neon.xml: Remove.
6004 * features/arm/arm-with-vfpv2.c: Remove.
6005 * features/arm/arm-with-vfpv2.xml: Remove.
6006 * features/arm/arm-with-vfpv3.c: Remove.
6007 * features/arm/arm-with-vfpv3.xml: Remove.
6008
f42b2617
AH		 60092019-07-19 Alan Hayward <alan.hayward@arm.com>
6010
6011 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6012
f29ec966
AH		 60132019-07-19 Alan Hayward <alan.hayward@arm.com>
6014
6015 * arch/aarch32.c (aarch32_create_target_description): Create
6016 target descriptions using features.
6017 * arch/arm.c (arm_create_target_description)
6018 (arm_create_mprofile_target_description): Likewise.
6019 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6020
d105cce5
AH		 60212019-07-19 Alan Hayward <alan.hayward@arm.com>
6022
6023 * Makefile.in: Add new files.
6024 * aarch32-tdep.c: New file.
6025 * aarch32-tdep.h: New file.
6026 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6027 Call aarch32_read_description.
6028 * arch/aarch32.c: New file.
6029 * arch/aarch32.h: New file.
6030 * arch/arm.c (arm_create_target_description)
6031 (arm_create_mprofile_target_description): New function.
6032 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6033 (arm_create_target_description)
6034 (arm_create_mprofile_target_description): New declaration.
6035 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6036 read_description functions.
6037 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6038 Likewise.
6039 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6040 * arm-tdep.c (tdesc_arm_list): New variable.
6041 (arm_register_g_packet_guesses): Call create description functions.
6042 (arm_read_description) (arm_read_mprofile_description): New
6043 function.
6044 * arm-tdep.h (arm_read_description)
6045 (arm_read_mprofile_description): Add declaration.
6046 * configure.tgt: Add new files.
6047
afe09f0b
GL		 60482019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6049
6050 * top.c (new_ui_command): Open specified terminal just once.
6051
cd215b2e
TT		 60522019-07-18 Tom Tromey <tromey@adacore.com>
6053
6054 * symtab.c (main_name): Constify return type.
6055 * symfile.c (set_initial_language): Update.
6056 * symtab.h (main_name): Constify return type.
6057
d8f68fcb
TT		 60582019-07-17 Tom Tromey <tom@tromey.com>
6059
6060 * tui/tui-winsource.c (tui_update_source_window)
6061 (tui_update_source_window_as_is)
6062 (tui_update_source_windows_with_line): Remove return.
6063 * tui/tui-disasm.c (tui_show_disassem)
6064 (tui_show_disassem_and_update_source): Remove return.
6065 * tui/tui.c (tui_reset): Remove return.
6066 * tui/tui-wingeneral.c
6067 (tui_check_and_display_highlight_if_needed): Remove return.
6068
ca5af91e
TT		 60692019-07-17 Tom Tromey <tom@tromey.com>
6070
6071 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6072
5104fe36
TT		 60732019-07-17 Tom Tromey <tom@tromey.com>
6074
6075 * tui/tui-winsource.h (struct tui_exec_info_window)
6076 (struct tui_source_window_base): Move from tui-data.h.
6077 * tui/tui-winsource.c: Move many method definitions from
6078 elsewhere. Remove "structuring" comments.
6079 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6080 (tui_source_window_base::refresh_window): Move to
6081 tui-winsource.c.
6082 * tui/tui-win.c (tui_source_window_base::refresh_all)
6083 (tui_source_window_base::update_tab_width)
6084 (tui_source_window_base::set_new_height)
6085 (tui_source_window_base::do_make_visible_with_new_height): Move to
6086 tui-winsource.c.
6087 * tui/tui-source.h: Update.
6088 * tui/tui-source.c (tui_source_window_base::reset): Move to
6089 tui-winsource.c.
6090 * tui/tui-disasm.h: Update.
6091 * tui/tui-data.h (struct tui_exec_info_window): Move to
6092 tui-winsource.h.
6093 (struct tui_source_window_base): Likewise.
6094 * tui/tui-data.c (tui_source_window_base::clear_detail)
6095 (tui_source_window_base, ~tui_source_window_base): Move to
6096 tui-winsource.c.
6097
daa15dde
TT		 60982019-07-17 Tom Tromey <tom@tromey.com>
6099
6100 * tui/tui-win.c (tui_resize_all)
6101 (tui_source_window_base::update_tab_width)
6102 (tui_adjust_win_heights): Update.
6103 (tui_win_info::make_invisible_and_set_new_height): Rename from
6104 make_invisible_and_set_new_height.
6105 * tui/tui-data.h (struct tui_win_info)
6106 <make_invisible_and_set_new_height>: New method.
6107
bfad4537
TT		 61082019-07-17 Tom Tromey <tom@tromey.com>
6109
6110 * tui/tui.c: Update.
6111 * tui/tui-source.h (struct tui_source_window): Move from
6112 tui-data.h.
6113 * tui/tui-layout.c: Update.
6114 * tui/tui-disasm.c: Update.
6115 * tui/tui-data.h (struct tui_source_window): Move to
6116 tui-source.h.
6117
88f7e873
TT		 61182019-07-17 Tom Tromey <tom@tromey.com>
6119
6120 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6121 tui-data.h.
6122 * tui/tui-data.h (struct tui_disasm_window): Move to
6123 tui-disasm.h.
6124
96bd6233
TT		 61252019-07-17 Tom Tromey <tom@tromey.com>
6126
6127 * tui/tui-regs.h (struct tui_data_item_window): Move from
6128 tui-data.h.
6129 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6130 * tui/tui-data.h (struct tui_data_item_window): Move to
6131 tui-regs.h.
6132 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6133
ce38393b
TT		 61342019-07-17 Tom Tromey <tom@tromey.com>
6135
6136 * tui/tui.c: Update.
6137 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6138 (tui_cmd_window::max_height): Move to tui-command.c.
6139 * tui/tui-layout.c: Update.
6140 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6141 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6142 tui-command.c.
6143 * tui/tui-command.h (struct tui_cmd_window): Move from
6144 tui-data.h.
6145 * tui/tui-command.c: Remove "structuring" comments.
6146 (tui_cmd_window::clear_detail)
6147 (tui_cmd_window::do_make_visible_with_new_height)
6148 (tui_cmd_window::max_height): Move from elsewhere.
6149
2d8b51cb
TT		 61502019-07-17 Tom Tromey <tom@tromey.com>
6151
6152 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6153 Now static.
6154 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6155 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6156
18ab23af
TT		 61572019-07-17 Tom Tromey <tom@tromey.com>
6158
6159 * tui/tui.c: Update.
6160 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6161 tui-regs.c.
6162 * tui/tui-windata.h: Remove file.
6163 * tui/tui-windata.c: Remove file.
6164 * tui/tui-win.c (tui_data_window::set_new_height)
6165 (tui_data_window::do_make_visible_with_new_height): Move to
6166 tui-regs.c.
6167 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6168 * tui/tui-regs.c: Remove "structuring" comments.
6169 (tui_data_window::first_data_item_displayed)
6170 (tui_data_window::delete_data_content_windows)
6171 (tui_data_window::erase_data_content)
6172 (tui_data_window::display_all_data)
6173 (tui_data_window::refresh_all)
6174 (tui_data_window::do_scroll_vertical)
6175 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6176 (tui_data_window::do_make_visible_with_new_height)
6177 (tui_data_window::refresh_window): Move from elsewhere.
6178 (_initialize_tui_regs): Move to end of file.
6179 * tui/tui-layout.c: Update.
6180 * tui/tui-hooks.c: Update.
6181 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6182 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6183 tui-regs.c.
6184 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6185
88b7e7cc
TT		 61862019-07-17 Tom Tromey <tom@tromey.com>
6187
6188 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6189 seen.
6190
0fcd3711
TT		 61912019-07-17 Tom Tromey <tom@tromey.com>
6192
6193 * tui/tui-win.c (tui_source_window_base::set_new_height)
6194 (tui_source_window_base::do_make_visible_with_new_height): Use
6195 m_has_locator field directly.
6196 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6197 method.
6198 (struct tui_source_window_base) <has_locator>: Likewise.
6199
4a38112d
TT		 62002019-07-17 Tom Tromey <tom@tromey.com>
6201
6202 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6203 Don't declare.
6204 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6205 Remove.
6206 * tui/tui-win.c (tui_source_window_base::set_new_height)
6207 (tui_source_window_base::set_new_height)
6208 (make_invisible_and_set_new_height)
6209 (tui_source_window_base::do_make_visible_with_new_height)
6210 (tui_source_window_base::do_make_visible_with_new_height):
6211 Update.
6212 * tui/tui-layout.c (show_source_disasm_command, show_data)
6213 (show_source_or_disasm_and_command): Update.
6214 * tui/tui-layout.c (show_layout): Update.
6215
09129226
TT		 62162019-07-17 Tom Tromey <tom@tromey.com>
6217
6218 * tui/tui-layout.c (make_data_window): Remove.
6219 (show_data): Unify creation and re-initialization cases.
6220
4a8a5e84
TT		 62212019-07-17 Tom Tromey <tom@tromey.com>
6222
6223 * tui/tui-layout.c (make_source_window, make_disasm_window):
6224 Remove.
6225 (show_data): Unify creation and re-initialization cases.
6226
76d2be8e
TT		 62272019-07-17 Tom Tromey <tom@tromey.com>
6228
6229 * tui/tui-layout.c (make_command_window): Remove.
6230 (show_source_disasm_command, show_source_or_disasm_and_command):
6231 Unify creation and re-initialization cases.
6232
890b8bde
TT		 62332019-07-17 Tom Tromey <tom@tromey.com>
6234
6235 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6236 creation and re-initialization cases.
6237
2cdfa113
TT		 62382019-07-17 Tom Tromey <tom@tromey.com>
6239
6240 * tui/tui-regs.c (tui_get_register): Return void.
6241
8e3cfd09
TT		 62422019-07-17 Tom Tromey <tom@tromey.com>
6243
6244 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6245 Simplify.
6246
f4e04977
TT		 62472019-07-17 Tom Tromey <tom@tromey.com>
6248
6249 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6250 resetting.
6251
0379b883
TT		 62522019-07-17 Tom Tromey <tom@tromey.com>
6253
6254 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6255 * tui/tui-regs.c (tui_reg_layout): New function.
6256 (tui_show_registers, tui_reg_command): Use it.
6257 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6258 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6259 parameters.
6260 (tui_layout_command): Remove.
6261
b7fbad91
TT		 62622019-07-17 Tom Tromey <tom@tromey.com>
6263
6264 * tui/tui-layout.h (tui/tui-layout): Return void.
6265 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6266
4e1e56b9
TT		 62672019-07-17 Tom Tromey <tom@tromey.com>
6268
6269 * tui/tui-layout.c (show_source_disasm_command, show_data):
6270 Update.
6271 (reset_locator): Remove.
6272 (show_source_or_disasm_and_command): Update.
6273
1e0c09ba
TT		 62742019-07-17 Tom Tromey <tom@tromey.com>
6275
6276 * tui/tui-source.c (tui_source_window_base::reset): Remove
6277 win_type parameter.
6278 * tui/tui-layout.c (make_command_window, make_source_window)
6279 (make_disasm_window, make_data_window)
6280 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6281 (reset_locator, show_source_or_disasm_and_command): Update.
6282 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6283 win_type parameter.
6284 (struct tui_source_window_base) <reset>: Likewise.
6285
1bf605de
TT		 62862019-07-17 Tom Tromey <tom@tromey.com>
6287
6288 * tui/tui-layout.c (show_source_disasm_command): Use
6289 reset_locator.
6290 (reset_locator): New function.
6291 (init_and_make_win): Remove.
6292 (show_source_or_disasm_and_command): Use reset_locator.
6293
098f9ed4
TT		 62942019-07-17 Tom Tromey <tom@tromey.com>
6295
6296 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6297 condition.
6298 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6299 Remove condition.
6300 * tui/tui-source.c (tui_source_window_base::reset): New method.
6301 * tui/tui-layout.c (make_command_window): Don't call
6302 init_and_make_win.
6303 (make_source_window, make_disasm_window): Don't call
6304 make_source_or_disasm_window.
6305 (make_data_window): Don't call init_and_make_win. Change calling
6306 convention.
6307 (show_source_disasm_command, show_data): Simplify.
6308 (make_source_or_disasm_window): Remove.
6309 (show_source_or_disasm_and_command): Simplify.
6310 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6311 (struct tui_source_window_base) <reset>: Likewise.
6312 <execution_info>: Remove initializer.
6313 * tui/tui-data.c (tui_source_window_base): Initialize
6314 execution_info.
6315
80110957
TT		 63162019-07-17 Tom Tromey <tom@tromey.com>
6317
6318 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6319 variable.
6320
cf82af05
TT		 63212019-07-17 Tom Tromey <tom@tromey.com>
6322
6323 * tui/tui.c (tui_rl_other_window): Update.
6324 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6325 superclass method first. Always iterate over regs_content.
6326 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6327 method.
6328 * tui/tui-win.c (tui_set_focus_command): Update.
6329
01aeb396
TT		 63302019-07-17 Tom Tromey <tom@tromey.com>
6331
6332 * tui/tui-win.c (tui_set_focus_command): Rename from
6333 tui_set_focus. Call tui_enable.
6334 (tui_set_focus_command): Remove.
6335
fd6c75ee
TT		 63362019-07-17 Tom Tromey <tom@tromey.com>
6337
6338 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6339 refresh_window.
6340 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6341 touchwin.
6342 (tui_data_window::refresh_window): Call refresh_window on data
6343 items. Always call superclass refresh_window.
6344 (tui_win_info::refresh): Remove.
6345 (tui_source_window_base::refresh_window): Update.
6346 (tui_refresh_all): Update.
6347 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6348 refresh_window.
6349 (show_source_or_disasm_and_command): Likewise.
6350 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6351 (struct tui_source_window_base) <refresh>: Likewise.
6352
f6cc34a9
TT		 63532019-07-17 Tom Tromey <tom@tromey.com>
6354
6355 * tui/tui-winsource.c (tui_clear_source_content)
6356 (tui_show_source_content): Update.
6357 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6358 whether content is empty.
6359 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6360 Remove.
6361
f31ec9af
TT		 63622019-07-17 Tom Tromey <tom@tromey.com>
6363
6364 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6365 window's contents.
6366 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6367 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6368
d1b6f1e5
TT		 63692019-07-17 Tom Tromey <tom@tromey.com>
6370
6371 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6372 (struct tui_data_item_window): Update.
6373
d9743a13
TT		 63742019-07-17 Tom Tromey <tom@tromey.com>
6375
6376 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6377 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6378 defines.
6379
caf0bc4e
TT		 63802019-07-17 Tom Tromey <tom@tromey.com>
6381
6382 * tui/tui-winsource.h (tui_erase_source_content)
6383 (tui_clear_source_content): Remove "display_prompt" parameter.
6384 * tui/tui-winsource.c (tui_update_source_window_as_is)
6385 (tui_update_source_windows_with_addr): Update.
6386 (tui_clear_source_content): Remove "display_prompt" parameter.
6387 (tui_erase_source_content): Likewise. Simplify.
6388 (tui_show_source_content): Update.
6389 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6390 * tui/tui-stack.c (tui_show_frame_info): Update.
6391 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6392 Remove defines.
6393
9d391078
TT		 63942019-07-17 Tom Tromey <tom@tromey.com>
6395
6396 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6397 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6398 parameter.
6399 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6400 parameter.
6401
a38da35d
TT		 64022019-07-17 Tom Tromey <tom@tromey.com>
6403
6404 * tui/tui-winsource.c (tui_clear_source_content)
6405 (tui_show_source_content, tui_show_exec_info_content)
6406 (tui_clear_exec_info_content): Update.
6407 * tui/tui-stack.c (tui_show_locator_content): Update.
6408 (tui_show_frame_info): Update.
6409 * tui/tui-source.h (tui_source_window): Don't declare.
6410 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6411 from tui_source_is_displayed.
6412 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6413 Remove field.
6414 (struct tui_source_window_base) <content_in_use>: New field. Now
6415 bool.
6416 (struct tui_source_window) <showing_source_p>: New method.
6417 (TUI_SRC_WIN): Change cast.
6418 * tui/tui-data.c (tui_initialize_static_data): Update.
6419
c2cd8994
TT		 64202019-07-17 Tom Tromey <tom@tromey.com>
6421
6422 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6423 location_matches_p.
6424 * tui/tui-source.c (tui_source_window::location_matches_p): New
6425 method.
6426 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6427 method.
6428 * tui/tui-data.h (struct tui_source_window_base)
6429 <location_matches_p>: New method.
6430 (struct tui_source_window, struct tui_disasm_window)
6431 <location_matches_p>: Likewise.
6432
4dde7b34
TT		 64332019-07-17 Tom Tromey <tom@tromey.com>
6434
6435 * tui/tui-win.c (tui_set_win_height_command): Rename from
6436 tui_set_win_height.
6437 (tui_set_win_height_command): Remove.
6438
b73dd877
TT		 64392019-07-17 Tom Tromey <tom@tromey.com>
6440
6441 * tui/tui-source.c (tui_source_window): New constructor. Add
6442 observer.
6443 (~tui_source_window): New destructor.
6444 (tui_source_window::style_changed): New method.
6445 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6446 (tui_attach_detach_observers): Update.
6447 * tui/tui-data.h (struct tui_source_window): Make constructor not
6448 inline. Add destructor.
6449 (struct tui_source_window) <style_changed>: New method.
6450 <m_observable>: New member.
6451
ae2b5380
TT		 64522019-07-17 Tom Tromey <tom@tromey.com>
6453
6454 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6455 * tui/tui-win.c (tui_resize_all): Fix typo.
6456
1ce3e844
TT		 64572019-07-17 Tom Tromey <tom@tromey.com>
6458
6459 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6460 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6461 (tui_refresh_all): Remove "list" parameter. Use foreach.
6462 * tui/tui-win.c (window_name_completer): Use foreach.
6463 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6464 (update_tab_width): Likewise.
6465 * tui/tui-layout.c (show_layout): Update.
6466 * tui/tui-data.h (class tui_window_iterator): New.
6467 (struct all_tui_windows): New.
6468 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6469
fe3eaf1c
TT		 64702019-07-17 Tom Tromey <tom@tromey.com>
6471
6472 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6473 parameter. Don't reference globals.
6474 (tui_reg_command): Update.
6475
368c1354
TT		 64762019-07-17 Tom Tromey <tom@tromey.com>
6477
6478 * tui/tui-regs.c (tui_show_registers): Simplify.
6479
e80cd204
TT		 64802019-07-17 Tom Tromey <tom@tromey.com>
6481
6482 * tui/tui-regs.c (tui_show_registers): Update.
6483 (tui_show_register_group): Add win_info parameter.
6484
aca2dd16
TT		 64852019-07-17 Tom Tromey <tom@tromey.com>
6486
6487 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6488 Rename from tui_display_reg_element_at_line.
6489 (tui_data_window::display_registers_from_line): Update.
6490 * tui/tui-data.h (struct tui_data_window)
6491 <display_reg_element_at_line>: New method.
6492
517e9505
TT		 64932019-07-17 Tom Tromey <tom@tromey.com>
6494
6495 * tui/tui-regs.h (tui_display_registers_from)
6496 (tui_display_registers_from_line): Don't declare.
6497 * tui/tui-windata.c (tui_data_window::display_all_data)
6498 (tui_data_window::refresh_all)
6499 (tui_data_window::do_scroll_vertical): Update.
6500 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6501 from tui_display_registers_from.
6502 (tui_display_reg_element_at_line): Update.
6503 (tui_data_window::display_registers_from_line): Rename from
6504 tui_display_registers_from_line.
6505 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6506 display_registers_from_line>: New methods.
6507
f76d8b19
TT		 65082019-07-17 Tom Tromey <tom@tromey.com>
6509
6510 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6511 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6512 from tui_erase_data_content.
6513 (tui_data_window::display_all_data)
6514 (tui_data_window::refresh_all)
6515 (tui_data_window::do_scroll_vertical): Update.
6516 * tui/tui-regs.c (tui_show_registers): Update.
6517 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6518 New method.
6519
b4094625
TT		 65202019-07-17 Tom Tromey <tom@tromey.com>
6521
6522 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6523 declare.
6524 * tui/tui-windata.c
6525 (tui_data_window::delete_data_content_windows): Rename from
6526 tui_delete_data_content_windows.
6527 (tui_data_window::display_all_data)
6528 (tui_data_window::do_scroll_vertical): Update.
6529 * tui/tui-data.h (struct tui_data_window)
6530 <delete_data_content_windows>: New method.
6531
c223a729
TT		 65322019-07-17 Tom Tromey <tom@tromey.com>
6533
6534 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6535 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6536
50daf268
TT		 65372019-07-17 Tom Tromey <tom@tromey.com>
6538
6539 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6540 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6541 from tui_display_all_data.
6542 * tui/tui-win.c
6543 (tui_data_window::do_make_visible_with_new_height): Update.
6544 * tui/tui-regs.c (tui_show_registers): Update.
6545 * tui/tui-layout.c (tui_set_layout): Update.
6546 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6547 method.
6548
df5f8cab
TT		 65492019-07-17 Tom Tromey <tom@tromey.com>
6550
6551 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6552 * tui/tui-windata.c (tui_display_data_from): Remove.
6553 (tui_data_window::refresh_all): Update.
6554
80cb6c27
TT		 65552019-07-17 Tom Tromey <tom@tromey.com>
6556
6557 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6558 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6559 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6560 tui_display_registers_from_line.
6561 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6562 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6563 "force_display" parameter.
6564
baff0c28
TT		 65652019-07-17 Tom Tromey <tom@tromey.com>
6566
6567 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6568 declare.
6569 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6570 Rename from tui_first_reg_element_no_inline.
6571 (tui_display_reg_element_at_line)
6572 (tui_display_registers_from_line): Update.
6573 * tui/tui-data.h (struct tui_data_window)
6574 <first_reg_element_no_inline>: New method.
6575
3b23c5f2
TT		 65762019-07-17 Tom Tromey <tom@tromey.com>
6577
6578 * tui/tui-windata.c (tui_display_data_from)
6579 (tui_data_window::do_scroll_vertical): Update.
6580 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6581 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6582 Rename from tui_line_from_reg_element_no.
6583 (tui_display_registers_from_line): Update.
6584 * tui/tui-data.h (struct tui_data_window)
6585 <line_from_reg_element_no>: New method.
6586
0b5ec218
TT		 65872019-07-17 Tom Tromey <tom@tromey.com>
6588
6589 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6590 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6591 tui_last_regs_line_no.
6592 (tui_display_reg_element_at_line)
6593 (tui_display_registers_from_line): Update.
6594 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6595 method.
6596
0807ab7b
TT		 65972019-07-17 Tom Tromey <tom@tromey.com>
6598
6599 PR tui/24722:
6600 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6601 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6602 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6603 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6604 (tui_update_breakpoint_info): Likewise.
6605 * tui/tui-hooks.c (tui_event_create_breakpoint)
6606 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6607 Update.
6608
9ad7fdef
TT		 66092019-07-17 Tom Tromey <tom@tromey.com>
6610
6611 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6612
5813316f
TT		 66132019-07-17 Tom Tromey <tom@tromey.com>
6614
6615 * tui/tui-winsource.c (tui_update_source_window_as_is)
6616 (tui_update_source_windows_with_addr): Update.
6617 * tui/tui-source.h (tui_set_source_content)
6618 (tui_show_symtab_source): Add "win_info" parameter.
6619 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6620 parameter.
6621 (tui_show_symtab_source): Likewise.
6622
00e264e7
TT		 66232019-07-17 Tom Tromey <tom@tromey.com>
6624
6625 * tui/tui-wingeneral.c
6626 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6627
06210ce4
TT		 66282019-07-17 Tom Tromey <tom@tromey.com>
6629
6630 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6631 (struct tui_cmd_window) <can_scroll>: New method.
6632 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6633 method.
6634
381befee
TT		 66352019-07-17 Tom Tromey <tromey@adacore.com>
6636
6637 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6638 do_field_signed>: Rename. Change type of "value".
6639 * ui-out.c (ui_out::field_signed): Rename from field_int.
6640 Change type of "value".
6641 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6642 type of "value".
6643 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6644 do_field_int. Change type of "value".
6645 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6646 do_field_int. Change type of "value".
6647 * tracepoint.c (trace_status_mi, tfind_1)
6648 (print_one_static_tracepoint_marker): Update.
6649 * thread.c (print_thread_info_1, print_selected_thread_frame):
6650 Update.
6651 * stack.c (print_frame, print_frame_info): Update.
6652 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6653 Update.
6654 * source.c (print_source_lines_base): Update.
6655 * skip.c (info_skip_command): Update.
6656 * record-btrace.c (btrace_ui_out_decode_error)
6657 (btrace_call_history_src_line): Update.
6658 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6659 Update.
6660 * progspace.c (print_program_space): Update.
6661 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6662 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6663 do_field_int. Change type of "value".
6664 * mi/mi-out.c (mi_ui_out::do_table_begin)
6665 (mi_ui_out::do_table_header): Update.
6666 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6667 type of "value".
6668 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6669 (mi_cmd_data_list_changed_registers, output_register)
6670 (mi_cmd_data_read_memory, mi_load_progress)
6671 (mi_cmd_trace_frame_collected): Update.
6672 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6673 Update.
6674 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6675 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6676 (mi_cmd_var_list_children, varobj_update_one): Update.
6677 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6678 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6679 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6680 * inferior.c (print_inferior): Update.
6681 * gdb_bfd.c (print_one_bfd): Update.
6682 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6683 Update.
6684 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6685 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6686 do_field_int. Change type of "value".
6687 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6688 do_field_int. Change type of "value".
6689 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6690 (print_one_breakpoint_location, print_it_catch_fork)
6691 (print_one_catch_fork, print_it_catch_vfork)
6692 (print_one_catch_vfork, print_it_catch_solib)
6693 (print_it_catch_exec, print_it_ranged_breakpoint)
6694 (print_mention_watchpoint, print_mention_masked_watchpoint)
6695 (bkpt_print_it, update_static_tracepoint): Update.
6696 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6697 * break-catch-syscall.c (print_it_catch_syscall): Update.
6698 * ada-tasks.c (print_ada_task_info): Update.
6699 * ada-lang.c (print_it_exception, print_mention_exception):
6700 Update.
6701
6b78c3f8
AB		 67022019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6703
6704 PR breakpoints/24541
6705 * gdbarch.c: Regenerate.
6706 * gdbarch.h: Regenerate.
6707 * gdbarch.sh: Adjust return type and parameter types for
6708 'stap_adjust_register'.
6709 (i386_stap_adjust_register): Adjust signature and return new
6710 register name.
6711 * stap-probe.c (stap_parse_register_operand): Adjust use of
6712 'gdbarch_stap_adjust_register'.
6713
d72a9b85
TT		 67142019-07-17 Tom Tromey <tromey@adacore.com>
6715
6716 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6717 declare VEC.
6718 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6719 std::vector.
6720 (struct s390_process_info): Add initializers.
6721 (s390_add_process): Use new.
6722 (s390_linux_nat_target::low_forget_process): Use delete.
6723 (s390_linux_nat_target::low_new_fork)
6724 (s390_linux_nat_target::stopped_by_watchpoint)
6725 (s390_linux_nat_target::low_prepare_to_resume)
6726 (s390_linux_nat_target::insert_watchpoint)
6727 (s390_linux_nat_target::insert_hw_breakpoint)
6728 (s390_linux_nat_target::remove_watchpoint)
6729 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6730
206e6c58
JB		 67312019-07-16 John Baldwin <jhb@FreeBSD.org>
6732
6733 * aarch64-fbsd-nat.c: Include regcache.h.
6734 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6735 argument.
6736 (aarch64_fbsd_nat_target::fetch_registers)
6737 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6738 variable.
6739 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6740
cbde90f2
JB		 67412019-07-16 John Baldwin <jhb@FreeBSD.org>
6742
6743 * fbsd-nat.c: Include gdbarch.h.
6744
07128006
TT		 67452019-07-15 Tom Tromey <tromey@adacore.com>
6746
6747 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6748
1f77b012
TT		 67492019-07-15 Tom Tromey <tromey@adacore.com>
6750
6751 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6752 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6753 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6754 * cli-out.c (cli_ui_out::do_field_int): New method.
6755 * ui-out.c (ui_out::field_unsigned): New method.
6756 * symfile.c (generic_load): Use field_unsigned.
6757 (print_transfer_performance): Likewise.
6758 * record-btrace.c (ui_out_field_uint): Remove.
6759 (btrace_call_history_insn_range, btrace_call_history): Use
6760 field_unsigned.
6761 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6762 field_unsigned.
6763 * ui-out.h (class ui_out) <field_unsigned>: New method.
6764 <do_field_unsigned>: Likewise.
6765
33eca680
TT		 67662019-07-15 Tom Tromey <tromey@adacore.com>
6767
6768 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6769 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6770 * target.c (flash_erase_command): Use field_string.
6771 * infrun.c (print_signal_received_reason): Use field_string.
6772 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6773 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6774 field_string.
6775 * ada-tasks.c (print_ada_task_info): Use field_string.
6776
ca8d69be
TT		 67772019-07-15 Tom Tromey <tromey@adacore.com>
6778
6779 * target.c (flash_erase_command): Use field_core_addr.
6780 * symfile.c (generic_load): Use field_core_addr.
6781 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6782 Use field_core_addr.
6783 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6784 field_core_addr.
6785
0d4e84ed
AB		 67862019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6787
6788 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6789 value if its desired type is smaller than a CORE_ADDR and signed.
6790
9a49df9d
AB		 67912019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6792
6793 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6794 of changes to field names, and use new is_reference field to
6795 decide if a property is a reference or not.
6796 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6797 field.
6798 (struct dwarf2_property_baton): Update header comment, rename
6799 'referenced_type' to 'property_type' and update comments.
6800 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6801 default property type, store in property baton, update to take
6802 accound of renamed field.
6803 (read_func_scope): Update call to attr_to_dynamic_prop.
6804 (read_array_type): Likewise.
6805 (dwarf2_per_cu_addr_sized_int_type): New function.
6806 (read_subrange_index_type): Move type finding code to
6807 dwarf2_per_cu_addr_sized_int_type.
6808 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6809 (dwarf2_per_cu_addr_type): New function.
6810 (set_die_type): Update calls to attr_to_dynamic_prop.
6811
b86352cf
AB		 68122019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6813
6814 * dwarf2read.c (read_subrange_index_type): New function.
6815 (read_subrange_type): Move code into new function and call it.
6816 * gdbtypes.c (create_range_type): Add some asserts.
6817
603490bf
AB		 68182019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6819
6820 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6821 update return statements.
6822 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6823 declaration, and update comment to match.
6824 * gdbtypes.c (resolve_dynamic_array): Update call to
6825 dwarf2_evaluate_property to match new return type.
6826
592f9d27
AB		 68272019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6828
6829 * valarith.c (value_subscripted_rvalue): Change lowerbound
6830 parameter type from int to LONGEST.
6831 * value.h (value_subscripted_rvalue): Likewise in declaration.
6832
60cfcb20
AB		 68332019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6834
6835 * cli/cli-utils.c (info_print_command_completer): New function.
6836 * cli/cli-utils.h: Add 'completer.h' include, and forward
6837 declaration for 'struct cmd_list_element'.
6838 (info_print_command_completer): Declare.
6839 * stack.c (_initialize_stack): Add completer for 'info locals' and
6840 'info args'.
6841 * symtab.c (_initialize_symtab): Add completer for 'info
6842 variables' and 'info functions'.
6843 * NEWS: Mention completion for additional info commands.
6844
b16507e0
AB		 68452019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6846
6847 * cli/cli-utils.c (extract_info_print_args): Delete.
6848 (extract_arg_maybe_quoted): Delete.
6849 (info_print_options_defs): New variable.
6850 (make_info_print_options_def_group): New function.
6851 (extract_info_print_options): Define new function.
6852 * cli/cli-utils.h (extract_info_print_args): Delete.
6853 (struct info_print_options): New structure.
6854 (extract_info_print_options): Declare new function.
6855 * stack.c (info_locals_command): Update to use new
6856 extract_info_print_options, also add a header comment.
6857 (info_args_command): Likewise.
6858 * symtab.c (info_variables_command): Likewise.
6859 (info_functions_command): Likewise.
6860
021d8588
AB		 68612019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6862
6863 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6864 to extract string arguments.
6865 * common/common-utils.c (extract_string_maybe_quoted): New function.
6866 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6867
b777eb6d
TT		 68682019-07-11 Tom Tromey <tromey@adacore.com>
6869
6870 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6871 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6872 * top.h (gdbinit): Don't declare.
6873 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6874 into...
6875 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6876 * top.c (gdb_init): Don't call init_cli_cmds.
6877 (gdbinit): Remove.
6878 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6879
72ee03ff
TT		 68802019-07-11 Tom Tromey <tromey@adacore.com>
6881
6882 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6883 after it has been moved.
6884
00db9531
SM		 68852019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6886
6887 * valops.c (value_must_coerce_to_target): Change return type to
6888 bool.
6889 * value.h (value_must_coerce_to_target): Likewise.
6890
f2478a7e
SM		 68912019-07-10 Simon Marchi <simon.marchi@efficios.com>
6892
6893 * breakpoint.c (is_hardware_watchpoint): Remove
6894 forward-declaration.
6895 (is_masked_watchpoint): Change return type to bool.
6896 (is_tracepoint): Likewise.
6897 (is_breakpoint): Likewise.
6898 (is_hardware_watchpoint): Likewise.
6899 (is_watchpoint): Likewise.
6900 (is_no_memory_software_watchpoint): Likewise.
6901 (is_catchpoint): Likewise.
6902 (breakpoint_1): Make FILTER parameter's return type bool.
6903 is_masked_watchpoint): Change return type to bool.
6904 (save_breakpoints): Make FILTER parameter's return type bool.
6905 * breakpoint.h (is_breakpoint): Change return type to bool.
6906 (is_watchpoint): Likewise.
6907 (is_catchpoint): Likewise.
6908 (is_tracepoint): Likewise.
6909
0d12e84c
TT		 69102019-07-10 Tom Tromey <tom@tromey.com>
6911
6912 * defs.h: Don't include gdbarch.h.
6913 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6914 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6915 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6916 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6917 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6918 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6919 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6920 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6921 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6922 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6923 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6924 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6925 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6926 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6927 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6928 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6929 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6930 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6931 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6932 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6933 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6934 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6935 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6936 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6937 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6938 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6939 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6940
f06f1252
TT		 69412019-07-10 Tom Tromey <tromey@adacore.com>
6942
6943 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6944 * breakpoint.c (init_ada_exception_breakpoint): Register as
6945 bp_catchpoint.
6946 (print_one_breakpoint_location, print_one_breakpoint): Use
6947 is_ada_exception_catchpoint.
6948 * ada-lang.c (class ada_catchpoint_location): Pass
6949 bp_loc_software_breakpoint to bp_location constructor.
6950 (is_ada_exception_catchpoint): New function.
6951
7a5d944b
TT		 69522019-07-10 Tom Tromey <tromey@adacore.com>
6953
6954 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6955 VEC.
6956 (struct arm_exidx_entry): New method operator<.
6957 (struct arm_exidx_data) <section_maps>: Change type.
6958 (arm_exidx_data_free): Remove.
6959 (arm_exidx_data_key): Change type. Move lower.
6960 (arm_exidx_new_objfile): Update.
6961 (arm_compare_exidx_entries): Remove.
6962 (arm_find_exidx_entry, _initialize_arm_tdep)
6963
48c66e1d
TT		 69642019-07-10 Tom Tromey <tromey@adacore.com>
6965
6966 * solib-spu.c (ocl_program_data_key): Change type.
6967 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6968 Update.
6969
a269fbf1
TT		 69702019-07-10 Tom Tromey <tromey@adacore.com>
6971
6972 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
6973 (struct solib_aix_inferior_data) <library_list>: Change type.
6974 (solib_aix_inferior_data_handle): Change type.
6975 (get_solib_aix_inferior_data): Update.
6976 (solib_aix_free_library_list): Remove.
6977 (library_list_start_library): Update.
6978 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6979 return type.
6980 (solib_aix_get_library_list)
6981 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6982 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6983
c294730c
TT		 69842019-07-10 Tom Tromey <tromey@adacore.com>
6985
6986 * solib-dsbt.c (struct dsbt_info): Add initializers.
6987 (solib_dsbt_pspace_data): Change type.
6988 (dsbt_pspace_data_cleanup): Remove.
6989 (get_dsbt_info, _initialize_dsbt_solib): Update.
6990
9d52077d
TT		 69912019-07-10 Tom Tromey <tromey@adacore.com>
6992
6993 * spu-tdep.c (spu_overlay_data): Change type.
6994 (spu_get_overlay_table, spu_overlay_new_objfile)
6995 (_initialize_spu_tdep): Update.
6996
22a20dca
TT		 69972019-07-10 Tom Tromey <tromey@adacore.com>
6998
6999 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7000 destructor.
7001 (dbx_objfile_data_key): Change type and declare later.
7002 (DBX_SYMFILE_INFO): Rewrite.
7003 * dbxread.c (dbx_objfile_data_key): Change type.
7004 (dbx_symfile_init): Update.
7005 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7006 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7007 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7008
cb60f420
TT		 70092019-07-10 Tom Tromey <tromey@adacore.com>
7010
7011 * jit.c (jit_program_space_key): Change type. Move lower.
7012 (get_jit_program_space_data): Update.
7013 (jit_program_space_data_cleanup): Remove.
7014 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7015 Update.
7016 (struct jit_program_space_data): Add initializers.
7017
51df2ae3
TT		 70182019-07-10 Tom Tromey <tromey@adacore.com>
7019
7020 * solib-darwin.c (struct darwin_info): Add initializers.
7021 (solib_darwin_pspace_data): Change type.
7022 (darwin_pspace_data_cleanup): Remove.
7023 (get_darwin_info, _initialize_darwin_solib): Update.
7024
18101a35
TT		 70252019-07-10 Tom Tromey <tromey@adacore.com>
7026
7027 * remote-sim.c (struct sim_inferior_data): Add initializers,
7028 constructor, and destructor.
7029 (sim_inferior_data_key): Change type. Move lower.
7030 (check_for_duplicate_sim_descriptor): Update.
7031 (get_sim_inferior_data): Use new. Update.
7032 (~sim_inferior_data_cleanup): Rename from
7033 sim_inferior_data_cleanup. Simplify.
7034 (gdbsim_close_inferior, simulator_command)
7035 (sim_command_completer, _initialize_remote_sim): Update.
7036 (next_pid, INITIAL_PID): Move earlier.
7037
05b08ac1
TT		 70382019-07-10 Tom Tromey <tromey@adacore.com>
7039
7040 * python/python-internal.h (create_thread_object): Return
7041 gdbpy_ref.
7042 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7043 * python/py-inferior.c (struct threadlist_entry): Add
7044 constructor.
7045 <thread_obj>: Now a gdbpy_ref.
7046 (thread_to_thread_object): Update.
7047 (add_thread_object): Use new.
7048 (delete_thread_object): Use delete.
7049 (infpy_threads): Update.
7050 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7051 GIL.
7052
32372d80
TT		 70532019-07-10 Tom Tromey <tromey@adacore.com>
7054
7055 * valops.c (value_cast): Specialize error message for Ada.
7056
5c458ae8
SM		 70572019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7058
7059 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7060
4c462cb0
SM		 70612019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7062
7063 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7064 bpstat_should_step): Return bool, adjust comments.
7065 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7066 bpstat_should_step): Likewise.
7067
89abbcc2
AH		 70682019-07-10 Alan Hayward <alan.hayward@arm.com>
7069
7070 * features/Makefile: Use feature target descriptions for Arm.
7071 * features/arm/arm-core.c: Generate new file.
7072 * features/arm/arm-fpa.c: Likewise.
7073 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7074 * features/arm/arm-m-profile.c: Likewise.
7075 * features/arm/arm-vfpv2.c: Likewise.
7076 * features/arm/arm-vfpv3.c: Likewise.
7077 * features/arm/xscale-iwmmxt.c: Likewise.
7078 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7079
166a82be
AH		 70802019-07-10 Alan Hayward <alan.hayward@arm.com>
7081
7082 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7083 ptrace earlier.
7084
9fb4c7e9
AH		 70852019-07-10 Alan Hayward <alan.hayward@arm.com>
7086
7087 * features/aarch64-pauth.c: Regenerate.
7088
e2d0f980
SM		 70892019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7090
7091 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7092 bool.
7093 (bpstat_what): Use false instead of 0.
7094
a38118e5
PA		 70952019-07-09 Pedro Alves <palves@redhat.com>
7096
7097 * break-catch-throw.c (is_exception_catchpoint): New.
7098 * breakpoint.c (print_one_breakpoint_location): New parameter
7099 'raw_loc'. Handle it. Use
7100 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7101 looking at the breakpoint's type.
7102 (print_one_breakpoint): If handling "maint info breakpoints", also
7103 print locations of exception catchpoints.
7104 * breakpoint.h (is_exception_catchpoint): Declare.
7105
cb1e4e32
PA		 71062019-07-09 Pedro Alves <palves@redhat.com>
7107
7108 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7109 "addr" field.
7110 (allocate_location_exception_catchpoint): New.
7111 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7112 (initialize_throw_catchpoint_ops): Install
7113 allocate_location_exception_catchpoint as allocate_location
7114 method.
7115 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7116 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7117 bp_loc_other.
7118 (breakpoint_address_is_meaningful): Delete.
7119 (bl_address_is_meaningful): New.
7120 (breakpoint_locations_match): Adjust comment.
7121 (bp_location_from_bp_type): New, factored out of...
7122 (bp_location::bp_location(breakpoint *)): ... this.
7123 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7124 factored out of...
7125 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7126 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7127 breakpoint_address_is_meaningful.
7128 (bp_locations_compare): Adjust comment.
7129 (update_global_location_list): Use bl_address_is_meaningful
7130 instead of breakpoint_address_is_meaningful.
7131 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7132 explicit.
7133 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7134 * python/py-breakpoint.c (bppy_get_location): No longer check
7135 whether location is null.
7136
b58a68fe
PA		 71372019-07-09 Pedro Alves <palves@redhat.com>
7138
7139 PR c++/15468
7140 * breakpoint.c (print_one_breakpoint_location): Remove
7141 single-location assert.
7142
268a13a5
TT		 71432019-07-09 Tom Tromey <tom@tromey.com>
7144
7145 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7146 * configure: Rebuild.
7147 * configure.ac: Change common to gdbsupport.
7148 * gdbsupport: Rename from common.
7149 * acinclude.m4: Change common to gdbsupport.
7150 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7151 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7152 gdbsupport.
7153 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7154 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7155 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7156 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7157 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7158 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7159 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7160 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7161 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7162 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7163 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7164 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7165 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7166 coff-pe-read.c, command.h, compile/compile-c-support.c,
7167 compile/compile-c.h, compile/compile-cplus-symbols.c,
7168 compile/compile-cplus-types.c, compile/compile-cplus.h,
7169 compile/compile-loc2c.c, compile/compile.c, completer.c,
7170 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7171 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7172 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7173 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7174 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7175 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7176 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7177 features/aarch64-core.c, features/aarch64-fpu.c,
7178 features/aarch64-pauth.c, features/aarch64-sve.c,
7179 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7180 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7181 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7182 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7183 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7184 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7185 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7186 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7187 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7188 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7189 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7190 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7191 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7192 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7193 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7194 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7195 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7196 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7197 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7198 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7199 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7200 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7201 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7202 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7203 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7204 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7205 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7206 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7207 minsyms.c, mips-linux-tdep.c, namespace.h,
7208 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7209 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7210 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7211 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7212 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7213 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7214 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7215 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7216 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7217 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7218 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7219 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7220 procfs.c, producer.c, progspace.h, psymtab.h,
7221 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7222 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7223 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7224 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7225 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7226 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7227 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7228 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7229 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7230 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7231 target-memory.c, target.c, target.h, target/waitstatus.c,
7232 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7233 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7234 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7235 unittests/array-view-selftests.c,
7236 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7237 unittests/common-utils-selftests.c,
7238 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7239 unittests/format_pieces-selftests.c,
7240 unittests/function-view-selftests.c,
7241 unittests/lookup_name_info-selftests.c,
7242 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7243 unittests/mkdir-recursive-selftests.c,
7244 unittests/observable-selftests.c,
7245 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7246 unittests/parse-connection-spec-selftests.c,
7247 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7248 unittests/scoped_fd-selftests.c,
7249 unittests/scoped_mmap-selftests.c,
7250 unittests/scoped_restore-selftests.c,
7251 unittests/string_view-selftests.c, unittests/style-selftests.c,
7252 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7253 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7254 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7255 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7256 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7257 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7258
5b0e2db4
AB		 72592019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7260
7261 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7262 bool value.
7263 (decode_digits_ordinary): Set explicit_line field in sal.
7264 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7265 symtab_and_line that was set on an explicit line number in
7266 assembler code. Do always update the recorded symtab and line if
7267 we do skip the prologue.
7268
0ba852ab
AB		 72692019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7270
7271 * breakpoint.c (set_breakpoint_location_function): Remove
7272 explicit_loc parameter.
7273 (momentary_breakpoint_from_master): Update call to
7274 set_breakpoint_location_function.
7275 (add_location_to_breakpoint): Likewise.
7276
b3a7d171
AB		 72772019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7278
7279 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7280 required features based on default bfd type when no specific bfd
7281 is present.
7282
1f6f6e21
PW		 72832019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7284
7285 * NEWS: Mention that GDB printf and eval commands can now print
7286 C-style and Ada-style convenience var strings without
7287 calling the inferior.
7288 * printcmd.c (printf_c_string): Locally print GDB internal var
7289 instead of transiting via the inferior.
7290 (printf_wide_c_string): Likewise.
7291
72922019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7293
5862c886 7294 PR breakpoints/25011
ea142fbf
AH		 7295 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7296
0598af48
TT		 72972019-07-04 Tom Tromey <tom@tromey.com>
7298
7299 PR tui/24724:
7300 * tui/tui-winsource.c (tui_clear_source_content): Update.
7301 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7302 (tui_update_breakpoint_info): Update.
7303 (tui_set_exec_info_content): Update.
7304 * tui/tui-source.c (tui_set_source_content_nil): Update.
7305 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7306 has_break.
7307 * tui/tui-data.h (enum tui_bp_flag): New.
7308 (tui_bp_flags): New enum flags type.
7309 (struct tui_source_element) <break_mode>: Change type. Rename
7310 from has_break.
7311 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7312 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7313 constants.
7314 * tui/tui-winsource.h: Fix comment.
7315
350fab54
AH		 73162019-07-04 Alan Hayward <alan.hayward@arm.com>
7317
7318 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7319 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7320 (store_fpregs_to_thread)
7321 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7322 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7323 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7324 (IWMMXT_REGS_SIZE): Add define.
7325 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7326 (fetch_vfp_regs, store_vfp_regs)
7327 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7328 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7329
f0452268
AH		 73302019-07-04 Alan Hayward <alan.hayward@arm.com>
7331
7332 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7333 defines.
7334 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7335 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7336 (ARM_INT_REGISTER_SIZE): ...to this.
7337 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7338 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7339 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7340 (arm_linux_collect_gregset, supply_nwfpe_register)
7341 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7342 defines.
7343 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7344 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7345 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7346 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7347 (arm_return_in_memory, arm_store_return_value)
7348 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7349 (arm_record_ld_st_multiple): Likewise.
7350 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7351 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7352
e935475c
AH		 73532019-07-04 Alan Hayward <alan.hayward@arm.com>
7354
7355 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7356 AARCH64_DISPLACED_MODIFIED_INSNS.
7357 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7358 (aarch64_displaced_step_copy_insn): Likewise.
7359 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7360 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7361 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7362 ARM_DISPLACED_MODIFIED_INSNS.
7363 * arm-tdep.c (arm_gdbarch_init): Likewise.
7364 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7365 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7366 (struct arm_displaced_step_closure): Use
7367 ARM_DISPLACED_MODIFIED_INSNS.
7368
df0bb381
AH		 73692019-07-04 Alan Hayward <alan.hayward@arm.com>
7370
7371 * features/Makefile: Remove unused xml files.
7372 * features/aarch64.xml: Remove.
7373 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7374 * features/i386/amd64-avx-avx512.xml: Remove.
7375 * features/i386/amd64-avx-linux.xml: Remove.
7376 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7377 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7378 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7379 * features/i386/amd64-avx-mpx.xml: Remove.
7380 * features/i386/amd64-avx.xml: Remove.
7381 * features/i386/amd64-linux.xml: Remove.
7382 * features/i386/amd64-mpx-linux.xml: Remove.
7383 * features/i386/amd64-mpx.xml: Remove.
7384 * features/i386/amd64.xml: Remove.
7385 * features/i386/i386-avx-avx512-linux.xml: Remove.
7386 * features/i386/i386-avx-avx512.xml: Remove.
7387 * features/i386/i386-avx-linux.xml: Remove.
7388 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7389 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7390 * features/i386/i386-avx-mpx-linux.xml: Remove.
7391 * features/i386/i386-avx-mpx.xml: Remove.
7392 * features/i386/i386-avx.xml: Remove.
7393 * features/i386/i386-linux.xml: Remove.
7394 * features/i386/i386-mmx-linux.xml: Remove.
7395 * features/i386/i386-mmx.xml: Remove.
7396 * features/i386/i386-mpx-linux.xml: Remove.
7397 * features/i386/i386-mpx.xml: Remove.
7398 * features/i386/i386.xml: Remove.
7399 * features/i386/x32-avx-avx512-linux.xml: Remove.
7400 * features/i386/x32-avx-linux.xml: Remove.
7401 * features/i386/x32-linux.xml: Remove.
7402
edd6266a
AH		 74032019-07-04 Alan Hayward <alan.hayward@arm.com>
7404
7405 * regformats/aarch64.dat: Remove.
7406 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7407 * regformats/i386/amd64-avx-linux.dat: Remove.
7408 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7409 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7410 * regformats/i386/amd64-linux.dat: Remove.
7411 * regformats/i386/amd64-mpx-linux.dat: Remove.
7412 * regformats/i386/amd64.dat: Remove.
7413 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7414 * regformats/i386/i386-avx-linux.dat: Remove.
7415 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7416 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7417 * regformats/i386/i386-linux.dat: Remove.
7418 * regformats/i386/i386-mmx-linux.dat: Remove.
7419 * regformats/i386/i386-mpx-linux.dat: Remove.
7420 * regformats/i386/i386.dat: Remove.
7421 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7422 * regformats/i386/x32-avx-linux.dat: Remove.
7423 * regformats/i386/x32-linux.dat: Remove.
7424
2b40fda7
AH		 74252019-07-04 Alan Hayward <alan.hayward@arm.com>
7426
7427 * aarch64-tdep.c: Remove xml self tests.
7428 * amd64-linux-tdep.c: Likewise.
7429 * amd64-tdep.c: Likewise.
7430 * i386-linux-tdep.c: Likewise.
7431 * i386-tdep.c: Likewise.
7432
5f4ba3e7
PA		 74332019-07-03 Pedro Alves <palves@redhat.com>
7434
7435 PR cli/24732
7436 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7437 (pipe_cmd_option_defs): New.
7438 (make_pipe_cmd_options_def_group): New.
7439 (pipe_command): Use gdb::option::process_options.
7440 (pipe_command_completer): New function.
7441 (_initialize_cli_cmds): Install completer for "pipe" command.
7442
3d9be6f5
PA		 74432019-07-03 Pedro Alves <palves@redhat.com>
7444
7445 * cli/cli-option.c (union option_value) <string>: New field.
7446 (struct option_def_and_value): Add ctor, move ctor, dtor and
7447 use DISABLE_COPY_AND_ASSIGN.
7448 (option_def_and_value::clear_value): New.
7449 (parse_option, save_option_value_in_ctx, get_val_type_str)
7450 (add_setshow_cmds_for_options): Handle var_string.
7451 * cli-option.h (union option_def::var_address) <string>: New
7452 field.
7453 (struct string_option_def): New.
7454 * maint-test-options.c (struct test_options_opts): Add default
7455 ctor and use DISABLE_COPY_AND_ASSIGN.
7456 <string_opt>: New field.
7457 (test_options_opts::~test_options_opts): New.
7458 (test_options_opts::dump): Also dump "-string".
7459 (test_options_option_defs): Install "string.
7460
41fc454c
PA		 74612019-07-03 Pedro Alves <palves@redhat.com>
7462
7463 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7464 option_value with a null enumeration.
7465 (complete_options): Save the option values in the context.
7466 (save_option_value_in_ctx): New, factored out from ...
7467 (process_options): ... here.
7468 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7469 of the function.
7470 * maint-test-options.c (test_options_opts::dump): New, factored
7471 out from ...
7472 (maintenance_test_options_command_mode): ... here.
7473 (maintenance_test_options_command_completion_result): Delete.
7474 (maintenance_test_options_command_completion_text): Update
7475 comment.
7476 (maintenance_show_test_options_completion_result): Change
7477 prototype. Just print
7478 maintenance_test_options_command_completion_text.
7479 (save_completion_result): New.
7480 (maintenance_test_options_completer_mode): Pass options context to
7481 complete_options, and then save a dump.
7482 (_initialize_maint_test_options): Use add_cmd to install "maint
7483 show test-options-completion-result".
7484
fdbc9870
PA		 74852019-07-03 Pedro Alves <palves@redhat.com>
7486
7487 * NEWS (New commands): Mention "with" and "maint with".
7488 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7489 (with_command, with_command_completer): New.
7490 (pipe_command): Adjust to new repeat_previous
7491 interface.
7492 (_initialize_cli_cmds): Install the "with" command and its "w"
7493 alias.
7494 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7495 declarations.
7496 * cli/cli-setshow.c (parse_cli_var_uinteger)
7497 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7498 argument strings for all var_types.
7499 (get_setshow_command_value_string): New, factored out from ...
7500 (do_show_command): ... this.
7501 * cli/cli-setshow.h: Include <string>.
7502 (get_setshow_command_value_string): Declare.
7503 * command.h (repeat_previous): Now returns const char *. Adjust
7504 comment.
7505 * maint.c: Include "cli/cli-cmds.h".
7506 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7507 (_initialize_maint_cmds): Register the "maintenance with" command.
7508 * top.c (repeat_previous): Move bits from pipe_command here:
7509 Return the saved command line, if any; error out if there's no
7510 command to relaunch.
7511
c6ac8931
PA		 75122019-07-03 Pedro Alves <palves@redhat.com>
7513
7514 * NEWS (New commands): Mention "maint set/show test-settings"
7515 instead of "maint test-settings".
7516 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7517 (maintenance_test_settings_set_list): Rename to ...
7518 (maintenance_set_test_settings_list): ... this.
7519 (maintenance_test_settings_show_list): Rename to ...
7520 (maintenance_show_test_settings_list): ... this.
7521 (maintenance_test_settings_cmd): Delete.
7522 (maintenance_test_settings_set_cmd): ...
7523 (maintenance_set_test_settings_cmd): ... this.
7524 (maintenance_test_settings_show_cmd): ...
7525 (maintenance_show_test_settings_cmd): ... this.
7526 (maintenance_test_settings_show_value_cmd):
7527 (maintenance_show_test_settings_value_cmd): ... this.
7528 (_initialize_maint_test_settings): No longer install the "maint
7529 test-settings" prefix command. Rename "maint test-settings set"
7530 to "maint set test-settings", and "maint test-settings show" to
7531 "maint show test-settings". Adjust all subcommands.
7532
d1fcf2fd
PA		 75332019-07-03 Pedro Alves <palves@redhat.com>
7534
7535 * maint-test-settings.c: Fix file's intro comment. Replace all
7536 references to "test-options" with references to "test-settings",
7537 in comments.
7538
970f9d09
PA		 75392019-07-03 Pedro Alves <palves@redhat.com>
7540
7541 * maint-test-settings.c (maintenance_test_settings_xxx)
7542 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7543 New.
7544 (maintenance_test_settings_enums): Use them.
7545 (maintenance_test_settings_enum): Default to
7546 maintenance_test_settings_xxx.
7547 (_initialize_maint_test_settings): Initialize
7548 MAINTENANCE_TEST_SETTINGS_FILENAME.
7549
f3869b1a
SM		 75502019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7551
7552 * breakpoint.h (remove_breakpoints_inf): Change return type to
7553 void, move function documentation here.
7554 * breakpoint.c (remove_breakpoints_inf): Change return type to
7555 void, move function documentation to header.
7556
54d66006
PA		 75572019-07-02 Pedro Alves <palves@redhat.com>
7558
7559 * NEWS (Completion improvements): Mention "info threads".
7560 * thread.c (struct info_threads_opts, info_threads_option_defs)
7561 (make_info_threads_options_def_group): New.
7562 (info_threads_command): Use gdb::option::process_options.
7563 (info_threads_command_completer): New.
7564 (_initialize_thread): Use gdb::option::build_help to build the
7565 help text for "info threads".
7566
854f6088
SM		 75672019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7568
7569 * defs.h (generic_load): Move from here...
7570 * symfile.h (generic_load): ... to here. Rename name parameter
7571 to args.
7572 * symfile.c (generic_load): Add comment.
7573
54ee4252
TT		 75742019-07-01 Tom Tromey <tromey@adacore.com>
7575
7576 * dwarf2read.c
7577 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7578 declaration of without_params. Fix formatting.
7579
65392b3e
TT		 75802019-07-01 Tom Tromey <tromey@adacore.com>
7581
7582 * ada-exp.y (find_primitive_type): Update.
7583 * ada-lang.h (ada_lookup_symbol): Update.
7584 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7585 parameter.
7586 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7587
7d7571f0
SDJ		 75882019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7589
7590 PR breakpoints/24541
7591 * gdbarch.c: Regenerate.
7592 * gdbarch.h: Regenerate.
7593 * gdbarch.sh: Add 'stap_adjust_register'.
7594 * i386-tdep.c: Include '<unordered_set>'.
7595 (i386_stap_adjust_register): New function.
7596 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7597 * stap-probe.c (stap_parse_register_operand): Call
7598 'gdbarch_stap_adjust_register'.
7599
5af5392a
SDJ		 76002019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7601
7602 PR python/24742
7603 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7604 * python/python.c (do_start_initialization): Use 'xmalloc'
7605 instead of 'PyMem_Malloc'.
7606
10d06d82
TT		 76072019-06-28 Tom Tromey <tromey@adacore.com>
7608
7609 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7610 for Ada.
7611
1b7f24cd
TT		 76122019-06-27 Tom Tromey <tromey@adacore.com>
7613
7614 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7615 objfile_key.
7616 (arm_find_mapping_symbol, arm_record_special_symbol)
7617 (_initialize_arm_tdep): Update.
7618 (arm_objfile_data_free): Remove.
7619
3d507ff2
TT		 76202019-06-27 Tom Tromey <tromey@adacore.com>
7621
7622 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7623 to cp_print_static_field.
7624
762c164d
TT		 76252019-06-26 Tom Tromey <tromey@adacore.com>
7626
7627 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7628 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7629 declare.
7630
aa2f9bcf
AH		 76312019-06-26 Alan Hayward <alan.hayward@arm.com>
7632
7633 * features/aarch64-core.c (create_feature_aarch64_core):
7634 Regenerate.
7635 * features/aarch64-core.xml: Add cpsr flags.
7636
3426ae57
AH		 76372019-06-26 Alan Hayward <alan.hayward@arm.com>
7638
7639 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7640 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7641
4838e44c
SM		 76422019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7643
7644 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7645 field.
7646 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7647 use.
7648 (arm_record_special_symbol): Don't insert new symbol in sorted
7649 position, push it at the end.
7650
54cc7474
SM		 76512019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7652
7653 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7654 (arm_mapping_symbol_s): Remove.
7655 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7656 (arm_mapping_symbol_vec): New typedef.
7657 (struct arm_per_objfile): Add constructor.
7658 <section_maps>: Change type to
7659 std::unique_ptr<arm_mapping_symbol_vec[]>.
7660 (arm_compare_mapping_symbols): Remove.
7661 (arm_find_mapping_symbol): Adjust to section_maps type change.
7662 (arm_objfile_data_free): Call delete on arm_per_objfile.
7663 (arm_record_special_symbol): Adjust to section_maps type change.
7664 Allocate arm_per_objfile with new.
7665
b65b566c
PW		 76662019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7667
7668 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7669 with the command prefix.
7670
c2fc64f5
TT		 76712019-06-25 Tom Tromey <tom@tromey.com>
7672
7673 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7674 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7675
fb54fa76
TT		 76762019-06-25 Tom Tromey <tom@tromey.com>
7677
7678 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7679 type.
7680 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7681 protected.
7682
f7952c57
TT		 76832019-06-25 Tom Tromey <tom@tromey.com>
7684
7685 * tui/tui-winsource.c
7686 (tui_source_window_base::set_is_exec_point_at): Add check against
7687 LOA_ADDRESS.
7688
17568d78
TT		 76892019-06-25 Tom Tromey <tom@tromey.com>
7690
7691 * tui/tui-source.c (tui_set_source_content): Don't check before
7692 xfree.
7693 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7694
53e7cdba
TT		 76952019-06-25 Tom Tromey <tom@tromey.com>
7696
7697 * tui/tui-winsource.h (tui_update_source_window_as_is)
7698 (tui_alloc_source_buffer, tui_line_is_displayed)
7699 (tui_addr_is_displayed): Change type of win_info.
7700 * tui/tui-winsource.c (tui_update_source_window_as_is)
7701 (tui_clear_source_content, tui_show_source_line)
7702 (tui_show_source_content, tui_source_window_base::refill)
7703 (tui_source_window_base::set_is_exec_point_at)
7704 (tui_source_window_base::set_is_exec_point_at)
7705 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7706 (tui_alloc_source_buffer, tui_line_is_displayed)
7707 (tui_addr_is_displayed): Change type of win_info. Update.
7708 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7709 (tui_source_window_base::do_make_visible_with_new_height):
7710 Update.
7711 * tui/tui-source.c (tui_set_source_content)
7712 (tui_set_source_content_nil)
7713 (tui_source_window::do_scroll_vertical): Update.
7714 * tui/tui-layout.c (show_layout): Update.
7715 * tui/tui-disasm.c (tui_set_disassem_content)
7716 (tui_disasm_window::do_scroll_vertical): Update.
7717 * tui/tui-data.h (tui_win_content): Remove.
7718 (struct tui_gen_win_info) <content, content_size>: Remove.
7719 (struct tui_source_element): Add initializers and destructor.
7720 (union tui_which_element, struct tui_win_element): Remove.
7721 (struct tui_source_window_base) <content>: New field.
7722 (struct tui_data_window): Remove destructor.
7723 (tui_alloc_content, tui_free_win_content)
7724 (tui_free_all_source_wins_content): Don't declare.
7725 * tui/tui-data.c (tui_initialize_static_data): Update.
7726 (init_content_element, tui_alloc_content): Remove.
7727 (~tui_gen_win_info): Update.
7728 (~tui_data_window, tui_free_all_source_wins_content)
7729 (tui_free_win_content, free_content, free_content_elements):
7730 Remove.
7731
7908abbf
TT		 77322019-06-25 Tom Tromey <tom@tromey.com>
7733
7734 * tui/tui-winsource.h (tui_clear_source_content)
7735 (tui_erase_source_content, tui_show_source_content): Change type
7736 of win_info.
7737 * tui/tui-winsource.c (tui_clear_source_content)
7738 (tui_erase_source_content, tui_show_source_content): Change type
7739 of win_info.
7740 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7741 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7742 win_info.
7743 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7744 win_info.
7745 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7746
02c28df0
TT		 77472019-06-25 Tom Tromey <tom@tromey.com>
7748
7749 * tui/tui-winsource.c (tui_clear_source_content)
7750 (tui_source_window_base::set_is_exec_point_at): Update.
7751 * tui/tui-source.c (tui_set_source_content_nil): Update.
7752 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7753 a bool.
7754 * tui/tui-data.c (init_content_element): Update.
7755
6658b1bf
TT		 77562019-06-25 Tom Tromey <tom@tromey.com>
7757
7758 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7759 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7760 * tui/tui-layout.c (init_and_make_win): Update.
7761 * tui/tui.h (enum tui_win_type): Update.
7762 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7763 tui_win_is_auxillary.
7764 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7765 tui_win_is_auxillary.
7766
21e1c91e
TT		 77672019-06-25 Tom Tromey <tom@tromey.com>
7768
7769 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7770 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7771 (tui_delete_data_content_windows, tui_display_all_data)
7772 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7773 Update.
7774 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7775 * tui/tui-regs.c (tui_last_regs_line_no)
7776 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7777 (tui_show_registers): Update.
7778 (tui_show_register_group): Return void. Update.
7779 (tui_display_registers_from, tui_display_reg_element_at_line)
7780 (tui_display_registers_from_line, tui_check_register_values):
7781 Update.
7782 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7783 member.
7784 (struct tui_data_window) <regs_content>: Now a std::vector.
7785 <regs_content_count>: Remove.
7786 (tui_add_content_elements, tui_free_data_content): Don't declare.
7787 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7788 (init_content_element): Remove DATA_WIN case. Add assert.
7789 (tui_add_content_elements): Remove.
7790 (tui_data_window): Update.
7791 (tui_free_data_content): Remove.
7792 (free_content_elements): Remove DATA_WIN case.
7793
115ac53b
TT		 77942019-06-25 Tom Tromey <tom@tromey.com>
7795
7796 * tui/tui-data.c (tui_data_item_window): Update.
7797 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7798 * tui/tui-windata.c (tui_display_all_data)
7799 (tui_display_data_from_line): Update.
7800 (tui_check_data_values): Remove.
7801 * tui/tui-regs.c (tui_show_register_group)
7802 (tui_display_reg_element_at_line): Update.
7803 * tui/tui-hooks.c (tui_register_changed)
7804 (tui_refresh_frame_and_register_information): Call
7805 tui_check_register_values.
7806 * tui/tui-data.h (struct tui_data_window) <data_content,
7807 data_content_count, data_type>: Remove.
7808 (enum tui_data_type): Remove.
7809
7810 * tui/tui-data.c (tui_data_window::clear_detail)
7811 (~tui_data_window): Update.
7812
eaf9738b
TT		 78132019-06-25 Tom Tromey <tom@tromey.com>
7814
7815 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7816 declare.
7817 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7818 Rename from tui_first_data_item_displayed. Update.
7819 (tui_data_window::refresh_all)
7820 (tui_data_window::do_scroll_vertical): Update.
7821 * tui/tui-data.h (struct tui_data_window)
7822 <first_data_item_displayed>: Declare new method.
7823
31ca4723
TT		 78242019-06-25 Tom Tromey <tom@tromey.com>
7825
7826 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7827 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7828 contents...
7829 (tui_initialize_static_data): ...here.
7830
41bcff7f
TT		 78312019-06-25 Tom Tromey <tom@tromey.com>
7832
7833 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7834 (tui_display_registers_from, tui_check_register_values): Update.
7835 (tui_display_register): Remove win_info parameter; update.
7836 (tui_get_register): Change type of parameters.
7837 * tui/tui-data.h (struct tui_data_element): Remove.
7838 (union tui_which_element) <data>: Remove.
7839 <data_window>: Change type.
7840 (struct tui_data_item_window): New.
7841 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7842 case. Add assert.
7843 (~tui_data_item_window): New destructor.
7844 (free_content_elements): Remove DATA_ITEM_WIN case.
7845
d2802c33
TT		 78462019-06-25 Tom Tromey <tom@tromey.com>
7847
7848 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7849 Remove.
7850
dd835f8b
TT		 78512019-06-25 Tom Tromey <tom@tromey.com>
7852
7853 * tui/tui-data.h (struct tui_command_element): Remove.
7854 (union tui_which_element) <command>: Remove.
7855 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7856 assert.
7857 (free_content_elements): Remove CMD_WIN case.
7858
bd7db367
TT		 78592019-06-25 Tom Tromey <tom@tromey.com>
7860
7861 * tui/tui-layout.c (tui_set_layout): Update.
7862 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7863 * tui/tui-data.c (layout_def): Update.
7864
3add462f
TT		 78652019-06-25 Tom Tromey <tom@tromey.com>
7866
7867 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7868 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7869 (tui_source_window_base::set_new_height): Update.
7870 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7871 Update.
7872 (tui_set_locator_fullname, tui_set_locator_info)
7873 (tui_show_frame_info): Update.
7874 * tui/tui-source.c (tui_set_source_content)
7875 (tui_source_is_displayed): Update.
7876 * tui/tui-layout.c (show_source_disasm_command, show_data)
7877 (show_source_or_disasm_and_command): Update.
7878 * tui/tui-disasm.c (tui_set_disassem_content)
7879 (tui_get_begin_asm_address): Update.
7880 * tui/tui-data.h (struct tui_locator_element): Remove.
7881 (union tui_which_element) <locator>: Remove.
7882 (struct tui_locator_window): New.
7883 (tui_locator_win_info_ptr): Change return type.
7884 * tui/tui-data.c (_locator): Change type.
7885 (tui_locator_win_info_ptr): Change return type.
7886 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7887 (tui_alloc_content): Add assert.
7888
489e9d8b
TT		 78892019-06-25 Tom Tromey <tom@tromey.com>
7890
7891 * tui/tui-winsource.c
7892 (tui_exec_info_window::maybe_allocate_content): New method.
7893 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7894 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7895 (make_source_or_disasm_window): Add cast.
7896 * tui/tui-data.h (union tui_which_element) <simple_string>:
7897 Remove.
7898 (struct tui_source_info): New.
7899 (struct tui_source_window_base) <execution_info>: Change type.
7900 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7901 case, and add assert.
7902 (tui_alloc_content): Add assert.
7903
c3fabb7d
TT		 79042019-06-25 Tom Tromey <tom@tromey.com>
7905
7906 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7907 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7908 * tui/tui-data.c (tui_alloc_win_info): Remove.
7909
bbc228ee
TT		 79102019-06-25 Tom Tromey <tom@tromey.com>
7911
7912 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7913 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7914 can_highlight.
7915
5fcee43a
TT		 79162019-06-25 Tom Tromey <tom@tromey.com>
7917
7918 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7919 make_visible_with_new_height method.
7920 (tui_win_info::make_visible_with_new_height): New method.
7921 (tui_source_window_base::do_make_visible_with_new_height)
7922 (tui_data_window::do_make_visible_with_new_height)
7923 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7924 (make_visible_with_new_height): Remove.
7925 (tui_resize_all, tui_adjust_win_heights): Use
7926 make_visible_with_new_height method.
7927 * tui/tui-data.h (struct tui_win_info)
7928 <do_make_visible_with_new_height, make_visible_with_new_height>:
7929 New methods.
7930 (struct tui_source_window_base, struct tui_data_window)
7931 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7932 methods.
7933
d83f1fe6
TT		 79342019-06-25 Tom Tromey <tom@tromey.com>
7935
7936 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7937 method.
7938 (update_tab_width): Call update_tab_width method.
7939 * tui/tui-data.h (struct tui_win_info)
7940 (struct tui_source_window_base) <update_tab_width>: New methods.
7941
17374de4
TT		 79422019-06-25 Tom Tromey <tom@tromey.com>
7943
7944 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7945 parameter.
7946 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7947 parameter.
7948 (tui_gen_win_info::make_visible): Update.
7949 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7950 parameter.
7951 * tui/tui-data.h (enum tui_box): New enum.
7952 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7953
f936bca2
TT		 79542019-06-25 Tom Tromey <tom@tromey.com>
7955
7956 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7957 init_and_make_win for EXEC_INFO_WIN.
7958 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7959 longer inline.
7960 (struct tui_win_info) <~tui_win_info>: Inline.
7961 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7962 Don't declare.
7963 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7964 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7965 Remove.
7966 (tui_initialize_static_data): Update.
7967 (~tui_gen_win_info): Handle more cleanup here.
7968 (~tui_source_window_base): Delete "execution_info".
7969 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7970
d6ba6a11
TT		 79712019-06-25 Tom Tromey <tom@tromey.com>
7972
7973 * tui/tui-layout.c (make_command_window): Don't set
7974 can_highlight.
7975 (show_source_disasm_command): Call the reset method.
7976 (show_data): Don't set can_highlight. Call the reset method.
7977 (tui_gen_win_info::reset): Rename from init_gen_win_info
7978 (init_and_make_win): Simplify. Return tui_gen_win_info.
7979 (show_source_or_disasm_and_command): Call the reset method.
7980 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7981 (struct tui_cmd_window): Set can_highlight.
7982
48a3bd16
TT		 79832019-06-25 Tom Tromey <tom@tromey.com>
7984
7985 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7986 from make_visible.
7987 (tui_make_visible, tui_make_invisible): Rewrite.
7988 (tui_win_info::make_visible): Remove.
7989 (tui_source_window_base::make_visible): Update.
7990 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7991 method. Moved from...
7992 (struct tui_win_info) <make_visible>: ...here.
7993
c3bd716f
TT		 79942019-06-25 Tom Tromey <tom@tromey.com>
7995
7996 * tui/tui-winsource.c
7997 (tui_source_window_base::do_scroll_horizontal): Remove direction
7998 parameter.
7999 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8000 direction parameter.
8001 * tui/tui-win.c (tui_win_info::forward_scroll)
8002 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8003 (tui_win_info::right_scroll): Update.
8004 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8005 direction parameter.
8006 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8007 direction parameter.
8008 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8009 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8010 Remove direction parameter.
8011 (struct tui_source_window_base, struct tui_source_window)
8012 (struct tui_disasm_window, struct tui_data_window)
8013 (struct tui_cmd_window): Update.
8014
21c32dca
TT		 80152019-06-25 Tom Tromey <tom@tromey.com>
8016
8017 * tui/tui-winsource.h (tui_set_exec_info_content)
8018 (tui_show_exec_info_content, tui_erase_exec_info_content)
8019 (tui_clear_exec_info_content, tui_update_exec_info): Change
8020 argument to tui_source_window_base.
8021 * tui/tui-winsource.c (tui_set_exec_info_content)
8022 (tui_show_exec_info_content, tui_erase_exec_info_content)
8023 (tui_clear_exec_info_content, tui_update_exec_info): Change
8024 argument to tui_source_window_base.
8025
73fbdc65
TT		 80262019-06-25 Tom Tromey <tom@tromey.com>
8027
8028 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8029 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8030
33325343
TT		 80312019-06-25 Tom Tromey <tom@tromey.com>
8032
8033 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8034 check.
8035
29d2c474
TT		 80362019-06-25 Tom Tromey <tom@tromey.com>
8037
8038 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8039 type to void.
8040 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8041 type to void.
8042 * tui/tui-source.c (tui_set_source_content): Update.
8043 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8044
152f3f4b
TT		 80452019-06-25 Tom Tromey <tom@tromey.com>
8046
8047 * tui/tui-win.c (window_name_completer, tui_set_focus)
8048 (tui_all_windows_info): Use name method.
8049 * tui/tui-data.h (struct tui_gen_win_info)
8050 (struct tui_source_window, struct tui_disasm_window)
8051 (struct tui_data_window, struct tui_cmd_window) <name>: New
8052 method.
8053 (tui_win_name): Don't declare.
8054 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8055 (tui_win_name): Remove.
8056
be4da588
TT		 80572019-06-25 Tom Tromey <tom@tromey.com>
8058
8059 * tui/tui-winsource.h (tui_update_source_window)
8060 (tui_update_source_window_as_is): Change parameter type.
8061 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8062 to be a tui_source_window_base.
8063 (tui_update_source_window_as_is): Likewise.
8064 * tui/tui-win.c (make_visible_with_new_height): Update.
8065
5b81daba
TT		 80662019-06-25 Tom Tromey <tom@tromey.com>
8067
8068 * tui/tui-winsource.c (tui_erase_source_content)
8069 (tui_show_source_content, tui_show_exec_info_content)
8070 (tui_erase_exec_info_content): Use refresh_window method.
8071 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8072 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8073 from tui_refresh_win.
8074 (tui_data_window::refresh_window): New method.
8075 (tui_win_info::refresh, tui_source_window_base::refresh)
8076 (tui_refresh_all): Use refresh_window method.
8077 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8078 method.
8079 * tui/tui-regs.c (tui_display_register): Call refresh_window
8080 method.
8081 * tui/tui-layout.c (show_source_disasm_command)
8082 (show_source_or_disasm_and_command): Call refresh_window method.
8083 * tui/tui-data.h (struct tui_gen_win_info)
8084 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8085 New method.
8086
cb2ce893
TT		 80872019-06-25 Tom Tromey <tom@tromey.com>
8088
8089 * tui/tui.c (tui_rl_other_window, tui_enable)
8090 (tui_is_window_visible, tui_get_command_dimension): Update.
8091 * tui/tui-winsource.c (tui_update_source_window_as_is)
8092 (tui_clear_source_content, tui_erase_source_content)
8093 (tui_show_source_line, tui_source_window_base::refill)
8094 (tui_source_window_base::do_scroll_horizontal)
8095 (tui_source_window_base::set_is_exec_point_at)
8096 (tui_update_breakpoint_info, tui_set_exec_info_content)
8097 (tui_alloc_source_buffer, tui_line_is_displayed)
8098 (tui_addr_is_displayed): Update.
8099 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8100 (tui_check_and_display_highlight_if_needed)
8101 (tui_win_info::make_visible, tui_win_info::refresh)
8102 (tui_refresh_all): Update.
8103 * tui/tui-windata.c (tui_first_data_item_displayed)
8104 (tui_delete_data_content_windows, tui_erase_data_content)
8105 (tui_display_all_data, tui_data_window::refresh_all)
8106 (tui_check_data_values): Update.
8107 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8108 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8109 (tui_win_info::backward_scroll, tui_refresh_all_win)
8110 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8111 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8112 (tui_source_window_base::set_new_height)
8113 (tui_data_window::set_new_height)
8114 (make_invisible_and_set_new_height)
8115 (make_visible_with_new_height, new_height_ok)
8116 (parse_scrolling_args): Update.
8117 * tui/tui-stack.c (tui_show_frame_info): Update.
8118 * tui/tui-source.c (tui_set_source_content)
8119 (tui_set_source_content_nil, tui_source_is_displayed)
8120 (tui_source_window::do_scroll_vertical): Update.
8121 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8122 (tui_display_registers_from, tui_display_reg_element_at_line)
8123 (tui_check_register_values, tui_reg_command): Update.
8124 * tui/tui-layout.c (tui_default_win_height)
8125 (show_source_disasm_command, show_data, init_and_make_win)
8126 (show_source_or_disasm_and_command): Update.
8127 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8128 (tui_redisplay_readline, tui_mld_flush)
8129 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8130 (tui_getc): Update.
8131 * tui/tui-disasm.c (tui_set_disassem_content)
8132 (tui_disasm_window::do_scroll_vertical): Update.
8133 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8134 Now virtual.
8135 (struct tui_win_info): Derive from tui_gen_win_info.
8136 <~tui_win_info>: Mark as override.
8137 <generic>: Remove member.
8138 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8139 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8140 (~tui_data_window, ~tui_win_info)
8141 (tui_free_all_source_wins_content): Update.
8142 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8143
ab313b35
TT		 81442019-06-25 Tom Tromey <tom@tromey.com>
8145
8146 * tui/tui-layout.c (init_and_make_win): Use new.
8147 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8148 destructor, initializers.
8149 (tui_alloc_generic_win_info): Don't declare.
8150 * tui/tui-data.c (_locator): Add argument to constructor.
8151 (source_win, disasm_win): New globals.
8152 (exec_info): Remove.
8153 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8154 Update.
8155 (tui_alloc_generic_win_info): Remove.
8156 (init_content_element): Use new.
8157 (tui_win_info::tui_win_info): Update.
8158 (free_content_elements) <case DATA_WIN>: Use delete.
8159
dc2c33e4
TT		 81602019-06-25 Tom Tromey <tom@tromey.com>
8161
8162 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8163 * tui/tui-windata.c (tui_first_data_item_displayed)
8164 (tui_delete_data_content_windows): Update.
8165 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8166 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8167 (tui_display_registers_from, tui_check_register_values): Update.
8168 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8169 pointer.
8170 * tui/tui-data.c (init_content_element): Update. Allocate the new
8171 window.
8172 (tui_free_data_content): Update.
8173 (free_content_elements) <case DATA_WIN>: Free the window.
8174
214a5cbe
TT		 81752019-06-25 Tom Tromey <tom@tromey.com>
8176
8177 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8178 Update.
8179 * tui/tui-layout.c (make_command_window)
8180 (show_source_disasm_command, show_data, init_and_make_win)
8181 (show_source_or_disasm_and_command): Update.
8182 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8183 method.
8184 <can_highight, is_highlighted>: Now bool.
8185 (tui_set_win_highlight): Don't declare.
8186 * tui/tui-data.c (tui_set_win_highlight): Remove.
8187
8e2daf15
TT		 81882019-06-25 Tom Tromey <tom@tromey.com>
8189
8190 * tui/tui-wingeneral.c (make_visible): Remove check of window
8191 type.
8192
8903bd8a
TT		 81932019-06-25 Tom Tromey <tom@tromey.com>
8194
8195 * tui/tui-win.c (tui_win_info::max_height)
8196 (tui_cmd_window::max_height): New methods.
8197 (new_height_ok): Call max_height.
8198 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8199 <max_height>: New method.
8200
3f02ce1e
TT		 82012019-06-25 Tom Tromey <tom@tromey.com>
8202
8203 * tui/tui-win.c (tui_source_window_base::set_new_height)
8204 (tui_data_window::set_new_height): New methods.
8205 (make_invisible_and_set_new_height): Call set_new_height method.
8206 * tui/tui-data.h (struct tui_win_info)
8207 (struct tui_source_window_base, struct tui_data_window)
8208 <set_new_height>: New method.
8209
1825f487
TT		 82102019-06-25 Tom Tromey <tom@tromey.com>
8211
8212 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8213 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8214 tui_refresh_data_win.
8215 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8216 method.
8217 (tui_refresh_all_win): Call the refresh_all method.
8218 (tui_set_focus): Likewise.
8219 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8220 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8221 Likewise.
8222
ad54d15b
TT		 82232019-06-25 Tom Tromey <tom@tromey.com>
8224
8225 * tui/tui-winsource.h (tui_refill_source_window)
8226 (tui_set_is_exec_point_at): Don't declare.
8227 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8228 (tui_source_window_base::refill): Rename from
8229 tui_refill_source_window.
8230 (tui_source_window_base::do_scroll_horizontal): Update.
8231 (tui_source_window_base::set_is_exec_point_at): Rename from
8232 tui_set_is_exec_point_at.
8233 (tui_update_all_breakpoint_info): Update.
8234 * tui/tui-stack.c (tui_show_frame_info): Update.
8235 * tui/tui-layout.c (show_data): Add cast.
8236 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8237 * tui/tui-data.h (struct tui_source_window_base) <refill,
8238 set_is_exec_point_at>: New methods.
8239 (tui_source_windows, tui_add_to_source_windows): Update types.
8240 (tui_add_to_source_windows): Remove redundant declaration.
8241 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8242 (tui_source_windows): Change return type.
8243 (tui_clear_source_windows_detail): Update.
8244 (tui_add_to_source_windows): Change type of parameter.
8245 (tui_free_all_source_wins_content): Update.
8246
2042b506
TT		 82472019-06-25 Tom Tromey <tom@tromey.com>
8248
8249 * tui/tui-wingeneral.c (tui_win_info::refresh)
8250 (tui_source_window_base::refresh): New methods.
8251 (tui_refresh_all): Call the refresh method.
8252 * tui/tui-data.h (struct tui_win_info)
8253 (struct tui_source_window_base) <refresh>: New method.
8254
56122977
TT		 82552019-06-25 Tom Tromey <tom@tromey.com>
8256
8257 * tui/tui.h (tui_is_window_visible): Return bool.
8258 * tui/tui.c (tui_is_window_visible): Return bool.
8259 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8260 (tui_make_visible, tui_make_invisible)
8261 (tui_win_info::make_visible)
8262 (tui_source_window_base::make_visible, make_all_visible)
8263 (tui_make_all_visible, tui_make_all_invisible): Update.
8264 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8265 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8266 bool.
8267 (struct tui_win_info, struct tui_source_window_base)
8268 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8269 * tui/tui-data.c (tui_init_generic_part): Update.
8270
cda37efb
TT		 82712019-06-25 Tom Tromey <tom@tromey.com>
8272
8273 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8274 (tui_source_window_base::make_visible): New methods.
8275 (make_all_visible): Make method call.
8276 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8277 (struct tui_source_window_base, struct tui_cmd_window): Override
8278 make_visible.
8279 (tui_win_is_source_type): Don't declare.
8280 * tui/tui-data.c (tui_win_is_source_type): Remove.
8281
6a0ee02c
TT		 82822019-06-25 Tom Tromey <tom@tromey.com>
8283
8284 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8285 NULL check.
8286
63901aec
TT		 82872019-06-25 Tom Tromey <tom@tromey.com>
8288
8289 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8290 Inline constructor. Add initializers for members.
8291 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8292 constructors; now inline in class.
8293
ceb13a13
TT		 82942019-06-25 Tom Tromey <tom@tromey.com>
8295
8296 * tui/tui-regs.c (tui_show_registers): Update.
8297 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8298 bool.
8299 * tui/tui-data.c (tui_data_window::clear_detail)
8300 (tui_data_window): Update.
8301
238eb706
TT		 83022019-06-25 Tom Tromey <tom@tromey.com>
8303
8304 * tui/tui-windata.c (tui_display_all_data)
8305 (tui_display_data_from_line, tui_display_data_from)
8306 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8307 Update.
8308 * tui/tui-regs.c (tui_last_regs_line_no)
8309 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8310 (tui_show_registers, tui_show_register_group)
8311 (tui_display_registers_from, tui_display_reg_element_at_line)
8312 (tui_display_registers_from_line, tui_check_register_values)
8313 (tui_reg_next, tui_reg_prev): Update.
8314 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8315 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8316 tui_data_window.
8317 (struct tui_win_info) <detail>: Remove. Add new fields from
8318 tui_data_info.
8319 (TUI_DATA_WIN): Add cast.
8320 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8321 (~tui_data_window): Simplify.
8322
81491aa0
TT		 83232019-06-25 Tom Tromey <tom@tromey.com>
8324
8325 * tui/tui-layout.c (show_source_disasm_command)
8326 (show_source_or_disasm_and_command): Update.
8327 * tui/tui-io.c (update_cmdwin_start_line)
8328 (tui_redisplay_readline): Update.
8329 * tui/tui-data.h (struct tui_command_info): Remove.
8330 (struct tui_win_info) <detail>: Remove command_info member.
8331 (struct tui_data_window) <start_line>: New member, from
8332 tui_command_info.
8333 (TUI_CMD_WIN): Add casts.
8334
e6e41501
TT		 83352019-06-25 Tom Tromey <tom@tromey.com>
8336
8337 * tui/tui-winsource.c (tui_update_source_window)
8338 (tui_refill_source_window)
8339 (tui_source_window_base::do_scroll_horizontal)
8340 (tui_update_breakpoint_info, tui_set_exec_info_content)
8341 (tui_show_exec_info_content, tui_erase_exec_info_content)
8342 (tui_clear_exec_info_content): Update.
8343 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8344 Update.
8345 * tui/tui-win.c (make_invisible_and_set_new_height)
8346 (make_visible_with_new_height): Update.
8347 * tui/tui-source.c (tui_set_source_content)
8348 (tui_show_symtab_source): Update.
8349 * tui/tui-layout.c (extract_display_start_addr)
8350 (show_source_disasm_command, show_data)
8351 (make_source_or_disasm_window)
8352 (show_source_or_disasm_and_command): Update.
8353 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8354 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8355 "gdbarch".
8356 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8357 to tui_source_window_base.
8358 (struct tui_win_info) <detail>: Remove source_info member.
8359 (struct tui_source_window_base) <has_locator>: Inline.
8360 Move contents from tui_source_info; rename has_locator member to
8361 m_has_locator.
8362 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8363 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8364 header file.
8365 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8366 Simplify.
8367 (tui_free_all_source_wins_content): Cast to
8368 tui_source_window_base.
8369
44f0e208
TT		 83702019-06-25 Tom Tromey <tom@tromey.com>
8371
8372 * tui/tui-win.c (make_invisible_and_set_new_height)
8373 (make_visible_with_new_height): Call has_locator method.
8374 * tui/tui-layout.c (show_source_disasm_command, show_data)
8375 (show_source_or_disasm_and_command): Update for bool change.
8376 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8377 (tui_win_info) <has_locator>: New method.
8378 (struct tui_source_window_base) <has_locator>: New method.
8379 (tui_win_has_locator): Don't declare.
8380 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8381 from tui_win_has_locator.
8382 (tui_source_window_base): Use false, not FALSE.
8383
7778b912
TT		 83842019-06-25 Tom Tromey <tom@tromey.com>
8385
8386 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8387 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8388 clear_detail method directly.
8389 (tui_clear_win_detail): Remove.
8390
f83d391c
TT		 83912019-06-25 Tom Tromey <tom@tromey.com>
8392
8393 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8394 "this", not TUI_DISASM_WIN.
8395
13446e05
TT		 83962019-06-25 Tom Tromey <tom@tromey.com>
8397
8398 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8399 declare.
8400 * tui/tui-winsource.c
8401 (tui_source_window_base::do_scroll_horizontal): Rename from
8402 tui_horizontal_source_scroll.
8403 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8404 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8405 from tui_vertical_data_scroll.
8406 * tui/tui-win.h (tui_scroll): Don't declare.
8407 * tui/tui-win.c (tui_win_info::forward_scroll)
8408 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8409 (tui_win_info::right_scroll): Rename and update.
8410 (tui_scroll_forward_command, tui_scroll_backward_command)
8411 (tui_scroll_left_command, tui_scroll_right_command): Update.
8412 (tui_scroll): Remove.
8413 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8414 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8415 from tui_vertical_source_scroll.
8416 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8417 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8418 from tui_vertical_disassem_scroll.
8419 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8420 do_scroll_horizontal>: New methods.
8421 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8422 Likewise.
8423 (struct tui_source_window_base): Add do_scroll_horizontal.
8424 (struct tui_source_window, struct tui_disasm_window): Add
8425 do_scroll_vertical.
8426 (struct tui_data_window, struct tui_cmd_window): Add
8427 do_scroll_horizontal and do_scroll_vertical.
8428 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8429
5cf82909
TT		 84302019-06-25 Tom Tromey <tom@tromey.com>
8431
8432 * tui/tui-data.h (struct tui_source_window_base): New struct.
8433 (struct tui_source_window): Derive from tui_source_window_base.
8434 (struct tui_disasm_window): New struct.
8435 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8436 from tui_source_window::clear_detail.
8437 (tui_source_window_base): Rename from tui_source_window.
8438 (~tui_source_window_base): Rename from ~tui_source_window.
8439 (tui_alloc_win_info): Create a tui_disasm_window.
8440
ee1d42d6
TT		 84412019-06-25 Tom Tromey <tom@tromey.com>
8442
8443 * tui/tui-data.h (struct tui_source_window)
8444 (struct tui_data_window): Declare destructors.
8445 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8446 destructors.
8447 (tui_win_info): Simplify.
8448
b4eb2452
TT		 84492019-06-25 Tom Tromey <tom@tromey.com>
8450
8451 * tui/tui-winsource.c (tui_display_main)
8452 (tui_update_source_windows_with_addr)
8453 (tui_update_all_breakpoint_info): Update.
8454 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8455 (new_height_ok, parse_scrolling_args): Update.
8456 * tui/tui-stack.c (tui_show_frame_info): Update.
8457 * tui/tui-data.h (struct tui_list): Remove.
8458 (tui_source_windows): Return a reference to a std::vector.
8459 * tui/tui-data.c (source_windows): Now a std::vector.
8460 (tui_source_windows): Change return type.
8461 (tui_clear_source_windows): Rewrite.
8462 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8463 (tui_free_all_source_wins_content): Rewrite.
8464
8761a91b
TT		 84652019-06-25 Tom Tromey <tom@tromey.com>
8466
8467 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8468 (struct tui_data_window, struct tui_cmd_window): Declare
8469 clear_detail method.
8470 * tui/tui-data.c (tui_source_window::clear_detail)
8471 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8472 methods.
8473 (tui_clear_win_detail): Simplify.
8474
0ed69eda
TT		 84752019-06-25 Tom Tromey <tom@tromey.com>
8476
8477 * tui/tui-layout.c (make_source_window, make_disasm_window)
8478 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8479 Return the new window.
8480 (show_source_disasm_command, show_data)
8481 (show_source_or_disasm_and_command): Update.
8482
82432e10
TT		 84832019-06-25 Tom Tromey <tom@tromey.com>
8484
8485 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8486 parameter. Return the new window.
8487 (show_source_disasm_command): Update and remove NULL check.
8488 (show_source_or_disasm_and_command): Update.
8489
ec328aa5
TT		 84902019-06-25 Tom Tromey <tom@tromey.com>
8491
8492 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8493
33b906ab
TT		 84942019-06-25 Tom Tromey <tom@tromey.com>
8495
8496 * tui/tui-data.h (struct tui_win_info): Make constructor
8497 protected. Make destructor virtual. Add initializers.
8498 (tui_source_window, tui_data_window, tui_cmd_window): New
8499 classes.
8500 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8501 constructor. Add "type" parameter.
8502 (tui_source_window, tui_data_window, tui_cmd_window): New
8503 constructors.
8504 (tui_alloc_win_info): Instantiate the appropriate subclass.
8505
e7e11af4
TT		 85062019-06-25 Tom Tromey <tom@tromey.com>
8507
8508 * tui/tui-win.c (tui_resize_all): Use delete.
8509 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8510 destructor.
8511 (tui_free_window): Don't declare.
8512 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8513 Update.
8514
6792b55e
TT		 85152019-06-25 Tom Tromey <tom@tromey.com>
8516
8517 * tui/tui-data.h (struct tui_win_info): Add constructor.
8518 * tui/tui-data.c (tui_alloc_win_info): Use new.
8519 (tui_free_window): Use delete.
8520
f95675e1
TT		 85212019-06-22 Tom Tromey <tom@tromey.com>
8522
8523 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8524 declare.
8525 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8526
5bff081c
TT		 85272019-06-22 Tom Tromey <tom@tromey.com>
8528
8529 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8530 declare.
8531 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8532
47e3f474
TV		 85332019-06-22 Tom de Vries <tdevries@suse.de>
8534
8535 * dwarf2read.c (create_addrmap_from_aranges)
8536 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8537 instead of '%zu'.
8538
fd5866f6
SM		 85392019-06-21 Simon Marchi <simon.marchi@efficios.com>
8540
8541 * dwarf2read.h (dwarf2_section_info_def): Remove.
8542 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8543 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8544 std::vector<dwarf2_section_info>.
8545 (struct dwo_file) <~dwo_file>: Remove.
8546 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8547 types field.
8548 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8549 (dwarf2_read_debug_names): Likewise.
8550 (create_debug_types_hash_table): Change parameter type to
8551 array_view, adjust code accordingly.
8552 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8553 (partial_die_info::fixup): Likewise.
8554 (determine_prefix): Likewise.
8555 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8556
fb1eb2f9
SM		 85572019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8558
8559 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8560 gdb_bfd_ref_ptr.
8561 <~dwo_file>: Remove call to gdb_bfd_unref.
8562 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8563 gdb_bfd_ref_ptr::get.
8564
51ac9db5
SM		 85652019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8566
8567 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8568 type to htab_up.
8569 * dwarf2read.c (struct dwo_file): Initialize fields.
8570 <~dwo_file>: New.
8571 (free_dwo_file): Remove, move content to ~dwo_file.
8572 (struct dwo_file_deleter): Remove.
8573 (dwo_file_up>: Remove custom deleter.
8574 (free_dwo_files): Remove.
8575 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8576 dwo_files.
8577 (process_skeletonless_type_units): Call unique_ptr::get.
8578 (allocate_dwo_file_hash_table): Add deleter to created hash
8579 table. Change return type to htab_up.
8580 (lookup_dwo_file_slot): Don't memset dwo_file, call
8581 unique_ptr::get.
8582 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8583 (create_dwo_unit_in_dwp_v2): Likewise.
8584 (open_and_init_dwo_file): Likewise.
8585 (free_dwo_file_from_slot): Remove.
8586
dc4ccb6f
SM		 85872019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8588
8589 * dwarf2read.h (struct dwarf2_section_info) <readin,
8590 is_virtual>: Change type to bool.
8591 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8592 true instead of 1.
8593
e6a1c5cb
TT		 85942019-06-19 Tom Tromey <tom@tromey.com>
8595
8596 * tui/tui-data.h (tui_init_content_element): Don't declare.
8597
6f6ffbeb
TT		 85982019-06-19 Tom Tromey <tom@tromey.com>
8599
8600 * tui/tui-data.h (tui_init_win_info): Don't declare.
8601
f23f598e
TV		 86022019-06-19 Tom de Vries <tdevries@suse.de>
8603
8604 * dwarf2read.h (abstract_to_concrete): Change type to
8605 std::unordered_map<sect_offset, std::vector<sect_offset>,
8606 gdb::hash_enum<sect_offset>>.
8607
680e1bee
TT		 86082019-06-19 Tom Tromey <tromey@adacore.com>
8609
8610 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8611 EVAL_AVOID_SIDE_EFFECTS specially.
8612
dcf37923
TT		 86132019-06-19 Tom Tromey <tromey@adacore.com>
8614
8615 * source-cache.c (highlighter): New global.
8616 (source_cache::get_source_lines): Create a highlighter on demand.
8617
494986d5
AB		 86182019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8619
8620 * defs.h (deprecated_interactive_hook): Delete declaration.
8621 * interps.c (clear_interpreter_hooks): Remove use of
8622 deprecated_interactive_hook.
8623 * top.c (deprecated_interactive_hook): Delete definition.
8624 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8625
3360b6e7
TV		 86262019-06-18 Tom de Vries <tdevries@suse.de>
8627
8628 PR gdb/24515
8629 * dwarf2read.h (abstract_to_concrete): Change type from
8630 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8631 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8632 * dwarf2read.c (read_variable): Update.
8633 (dwarf2_fetch_die_loc_sect_off): Update.
8634
310b3441
TV		 86352019-06-17 Tom de Vries <tdevries@suse.de>
8636
8637 PR gdb/24617
8638 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8639 accessing parent[parent_len - 1].
8640
ba9777be
PP		 86412019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8642
8643 PR gdb/24364
8644 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8645 call dtrace_process_dof with NULL dof.
8646
2b9f6e89
TV		 86472019-06-16 Tom de Vries <tdevries@suse.de>
8648
8649 PR gdb/24445
8650 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8651
431b3ead
TT		 86522019-06-16 Tom Tromey <tom@tromey.com>
8653
8654 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8655 (make_all_visible): Use address of member.
8656
d04b44a1
TT		 86572019-06-16 Tom Tromey <tom@tromey.com>
8658
8659 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8660 (tui_free_window, free_content, free_content_elements): Remove
8661 unnecessary cast.
8662 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8663 cast.
8664 * tui/tui-regs.c (tui_show_register_group)
8665 (tui_display_registers_from, tui_display_reg_element_at_line):
8666 Remove unnecessary cast.
8667
bf5142e7
AB		 86682019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8669
8670 * linux-nat.c (normal_mask): Delete.
8671 (_initialize_linux_nat): Don't initialise normal_mask.
8672
c4973306
SM		 86732019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8674
8675 PR gdb/24445
8676 * dwarf-index-write.h (write_psymtabs_to_index): Add
8677 dwz_basename parameter.
8678 * dwarf-index-write.c (write_gdbindex): Move file writing to
8679 write_gdbindex_1. Change return type void.
8680 (assert_file_size): Move up, remove filename parameter.
8681 (write_gdbindex_1): New function.
8682 (write_debug_names): Change return type to void, call
8683 assert_file_size.
8684 (struct index_wip_file): New struct.
8685 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8686 file logic to index_wip_file. Write index for dwz file if
8687 needed.
8688 (save_gdb_index_command): Pass basename of dwz file, if present.
8689 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8690 build-id of dwz file, if present.
8691 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8692 (dwarf2_get_dwz_file): Likewise.
8693 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8694 (dwarf2_get_dwz_file): Likewise.
8695
395f9c91
TT		 86962019-06-16 Tom Tromey <tom@tromey.com>
8697
8698 * coffread.c (process_coff_symbol): Use xstrdup.
8699 * value.c (create_internalvar): Use xstrdup.
8700
cafb3438
TT		 87012019-06-16 Tom Tromey <tom@tromey.com>
8702
8703 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8704 * breakpoint.c (stopin_command, stopat_command)
8705 (until_break_command, decode_location_default): Remove unnecessary
8706 cast.
8707 * utils.c (subset_compare): Remove unnecessary cast.
8708 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8709 cast.
8710 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8711 cast.
8712 * infcmd.c (path_command): Remove unnecessary cast.
8713 * coffread.c (decode_type): Remove unnecessary cast.
8714 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8715 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8716 * tui/tui-stack.c (tui_show_locator_content)
8717 (tui_show_frame_info): Remove unnecessary cast.
8718 * tui/tui-win.c (tui_scroll_forward_command)
8719 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8720 (parse_scrolling_args): Remove unnecessary cast.
8721 * tui/tui-data.c (init_win_info, tui_del_window)
8722 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8723 (free_content_elements): Remove unnecessary cast.
8724 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8725 unnecessary cast.
8726 * tui/tui-source.c (tui_set_source_content)
8727 (tui_vertical_source_scroll): Remove unnecessary cast.
8728 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8729 cast.
8730 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8731 * tui/tui-regs.c (tui_display_registers_from)
8732 (tui_display_register): Remove unnecessary cast.
8733 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8734 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8735 (make_visible): Remove unnecessary cast.
8736 * tui/tui-winsource.c (tui_erase_source_content)
8737 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8738 unnecessary cast.
8739 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8740 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8741 * stabsread.c (read_type, read_array_type, read_range_type):
8742 Remove unnecessary cast.
8743 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8744 (parse_symbol, parse_type, upgrade_type, parse_external)
8745 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8746 unnecessary cast.
8747 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8748
730ead81
TT		 87492019-06-16 Tom Tromey <tom@tromey.com>
8750
8751 * tui/tui-data.c (tui_alloc_generic_win_info)
8752 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8753 checks.
8754
584a927c
AB		 87552019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8756 Andrew Burgess <andrew.burgess@embecosm.com>
8757
8758 * f-typeprint.c (f_print_type): Don't return early for not
8759 associated or not allocated types.
8760 (f_type_print_varspec_suffix): Add print_rank parameter and print
8761 ranks of array types in case they dangling.
8762 (f_type_print_base): Add print_rank parameter.
8763
30056ea0
AB		 87642019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8765
8766 * NEWS: Mention new MI commands.
8767 * break-catch-throw.c (enum exception_event_kind): Move to
8768 breakpoint.h.
8769 (print_mention_exception_catchpoint): Output text as a single
8770 message.
8771 (catch_exception_command_1): Rename to...
8772 (catch_exception_event): ...this, make non-static, update header
8773 command, and change some parameter types.
8774 (catch_catch_command): Update for changes to
8775 catch_exception_command_1.
8776 (catch_throw_command): Likewise.
8777 (catch_rethrow_command): Likewise.
8778 * breakpoint.c (enum exception_event_kind): Delete.
8779 * breakpoint.h (enum exception_event_kind): Moved here from
8780 break-catch-throw.c.
8781 (catch_exception_event): Declare.
8782 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8783 (mi_cmd_catch_throw): New function.
8784 (mi_cmd_catch_rethrow): New function.
8785 (mi_cmd_catch_catch): New function.
8786 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8787 'catch-catch' entries.
8788 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8789 (mi_cmd_catch_rethrow): Declare.
8790 (mi_cmd_catch_catch): Declare.
8791
ec8e2b6d
AB		 87922019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8793
8794 * annotate.c (annotate_source_line): Change return type to void,
8795 update implementation to match.
8796 * annotate.h (annotate_source_line): Change return type to void,
8797 update header comment.
8798 * stack.c (print_frame_info): Don't change what frame information
8799 is printed based on whether annotations are on or not.
8800
0d3abd8c
AB		 88012019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8802
8803 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8804 (annotate_source): Make static.
8805 (annotate_source_line): Moved from source.c and renamed from
8806 identify_source_line. Update the return type.
8807 * annotate.h (annotate_source): Delete declaration.
8808 (annotate_source_line): Declaration moved from source.h, and
8809 renamed from identify_source_line. Return type updated.
8810 * source.c (identify_source_line): Moved to annotate.c and renamed
8811 to annotate_source_line.
8812 (info_line_command): Remove check of annotation_level.
8813 * source.h (identify_source_line): Move declaration to annotate.h
8814 and rename to annotate_source_line.
8815 * stack.c: Add 'annotate.h' include.
8816 (print_frame_info): Remove check of annotation_level before
8817 calling annotate_source_line.
8818
00df30ae
AB		 88192019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8820
8821 * source-cache.c (source_cache::get_plain_source_lines): Use
8822 open_source_file_with_line_charpos instead of just
8823 open_source_file, remove call to find_source_lines.
8824 (source_cache::get_source_lines): Likewise.
8825 * source.c (find_source_lines): Make static.
8826 (get_filename_and_charpos): Renamed into...
8827 (open_source_file_with_line_charpos): ..this along with changes to
8828 return a scoped_fd, and some other minor clean ups.
8829 (identify_source_line): Use open_source_file_with_line_charpos.
8830 (search_command_helper): Use open_source_file_with_line_charpos
8831 instead of just open_source_file, remove call to
8832 find_source_lines.
8833 * source.h (open_source_file_with_line_charpos): Declare new
8834 function.
8835 (find_source_lines): Delete declaration.
8836
afda45a2
AB		 88372019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8838
8839 * source.c (get_filename_and_charpos): Remove fullname
8840 parameter.
8841 (identify_source_line): Update call to get_filename_and_charpos.
8842
0735b091
TT		 88432019-06-14 Tom Tromey <tromey@adacore.com>
8844
8845 PR gdb/24502:
8846 * ui-style.h (skip_ansi_escape): Update comment.
8847 * ui-file.h (class no_terminal_escape_file): New class.
8848 * ui-file.c (no_terminal_escape_file::write)
8849 (no_terminal_escape_file::puts): New methods.
8850 * cli/cli-logging.c (handle_redirections): Use
8851 no_terminal_escape_file.
8852
52ce35e2
TT		 88532019-06-14 Tom Tromey <tromey@adacore.com>
8854
8855 * NEWS: Move convenience variable news above Python news.
8856
73cc7272
TT		 88572019-06-14 Tom Tromey <tom@tromey.com>
8858
8859 * gnulib: Move directory to top-level.
8860 * configure.ac: Don't configure gnulib.
8861 * configure: Rebuild.
8862 * common/common-defs.h: Use new path to gnulib.
8863 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8864 (GNULIB_H): Remove.
8865 (INCGNU): Look in new gnulib location.
8866 (HFILES_NO_SRCDIR): Remove gnulib files.
8867 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8868 (generated_files): Remove GNULIB_H.
8869 ($(LIBGNU), all-lib): Remove targets.
8870 (distclean): Don't mention GNULIB_BUILDDIR.
8871 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8872
f5686554
TT		 88732019-06-14 Tom Tromey <tromey@adacore.com>
8874
8875 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8876 Warn if symbol file does not provide any symbols.
8877
a0c1ffed
TT		 88782019-06-14 Tom Tromey <tromey@adacore.com>
8879
8880 * source.c (find_and_open_source): Respect basenames_may_differ.
8881
7c39e397
AB		 88822019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8883
8884 * annotate.c (annotate_breakpoints_invalid): Make use of
8885 scoped_restore_terminal_state.
8886 (annotate_frames_invalid): Likewise.
8887
f411722c
TT		 88882019-06-14 Tom Tromey <tromey@adacore.com>
8889
8890 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8891 allow assignment to an internalvar.
8892
4268ec18
TT		 88932019-06-14 Tom Tromey <tromey@adacore.com>
8894
8895 * ada-lex.l: Allow "_" in attribute names.
8896
abdb711e
TT		 88972019-06-14 Tom Tromey <tromey@adacore.com>
8898
8899 PR gdb/24653:
8900 * regcache.c (registers_changed): Don't call alloca.
8901 * top.c (execute_command): Don't call alloca.
8902
4c048731
PA		 89032019-06-13 Pedro Alves <palves@redhat.com>
8904
8905 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8906 'expression'. When parsing an expression, error out if there's
8907 junk after "unlimited".
8908 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8909 (do_set_command): Adjust calls to is_unlimited_literal.
8910
66eb1ed3
PA		 89112019-06-13 Pedro Alves <palves@redhat.com>
8912
8913 * compile/compile.c (make_compile_options_def_group): Add braces
8914 around array_view initializer.
8915 * thread.c (make_thread_apply_all_options_def_group)
8916 (make_thread_apply_all_options_def_group): Likewise.
8917
3345721a
PA		 89182019-06-13 Pedro Alves <palves@redhat.com>
8919
8920 * NEWS (New commands): Mention "maint test-options
8921 require-delimiter", "maint test-options unknown-is-error", "maint
8922 test-options unknown-is-operand" and "maint show
8923 test-options-completion-result".
8924 (New command options, command completion): New section.
8925 (Completion improvements): New section.
8926 Mention that you can abbreviate "unlimited".
8927
6206060d
PA		 89282019-06-13 Pedro Alves <palves@redhat.com>
8929
8930 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8931 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8932 * unittests/cli-utils-selftests.c (test_parse_flags)
8933 (test_parse_flags_qcs): Delete.
8934 (test_cli_utils): Don't call deleted functions.
8935
6665660a
PA		 89362019-06-13 Pedro Alves <palves@redhat.com>
8937
8938 * thread.c: Include "cli/cli-option.h".
8939 (tp_array_compar_ascending): Global.
8940 (tp_array_compar): Delete function.
8941 (tp_array_compar_ascending, tp_array_compar_descending): New
8942 functions.
8943 (ascending_option_def, qcs_flag_option_def)
8944 (thr_qcs_flags_option_defs)
8945 (make_thread_apply_all_options_def_group)
8946 (make_thread_apply_options_def_group): New.
8947 (thread_apply_all_command): Use gdb::option::process_options.
8948 (thread_apply_command_completer)
8949 (thread_apply_all_command_completer): New.
8950 (thread_apply_command): Use gdb::option::process_options.
8951 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8952 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8953 to generate help text of "thread apply". Adjust "taas"'s help.
8954 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8955 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8956
f7e13587
PA		 89572019-06-13 Pedro Alves <palves@redhat.com>
8958
8959 * thread.c (thread_apply_command): Check for invalid TID with
8960 isdigit instead of !isalpha.
8961
5d707134
PA		 89622019-06-13 Pedro Alves <palves@redhat.com>
8963
8964 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8965 (validate_flags_qcs): New.
8966 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8967 (validate_flags_qcs): Declare.
8968 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8969 (make_frame_apply_options_def_group): New.
8970 (frame_apply_command_count): Process options with
8971 gdb::option::process_options.
8972 (frame_apply_completer): New.
8973 (frame_apply_level_completer, frame_apply_all_completer)
8974 (frame_apply_completer): New.
8975 (_initialize_stack): Update help of "frame apply", "frame apply
8976 level", "frame apply all" and "faas" to mention supported options
8977 and install command completers.
8978 * stack.h (frame_apply_all_completer): Declare.
8979 * thread.c: Include "stack.h".
8980 (tfaas_command): Add "--".
8981 (_initialize_thread): Update help "tfaas" to mention supported
8982 options and install command completer.
8983
272d4594
PA		 89842019-06-13 Pedro Alves <palves@redhat.com>
8985
8986 * completer.c (complete_nested_command_line): New.
8987 (gdb_completion_word_break_characters_throw): Add assertion.
8988 * completer.h (complete_nested_command_line): Declare.
8989
90a1ef87
PA		 89902019-06-13 Pedro Alves <palves@redhat.com>
8991
8992 * stack.c (parse_backtrace_qualifiers): New.
8993 (backtrace_command): Use it.
8994 (backtrace_command_completer): Complete on qualifiers.
8995
d4c16835
PA		 89962019-06-13 Pedro Alves <palves@redhat.com>
8997
8998 * frame.c: Include "cli/cli-option.h.
8999 (user_set_backtrace_options): New.
9000 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9001 Delete.
9002 (get_prev_frame): Adjust.
9003 (boolean_option_def, uinteger_option_def)
9004 (set_backtrace_option_defs): New.
9005 (_initialize_frame): Adjust and use
9006 gdb::option::add_setshow_cmds_for_options to install "set
9007 backtrace past-main" and "set backtrace past-entry".
9008 * frame.h: Include "cli/cli-option.h".
9009 (struct frame_print_options): Forward declare.
9010 (print_frame_arguments_all, print_frame_arguments_scalars)
9011 (print_frame_arguments_none): Declare.
9012 (print_entry_values): Delete declaration.
9013 (struct frame_print_options, user_frame_print_options): New.
9014 (struct set_backtrace_options): New.
9015 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9016 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9017 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9018 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9019 (list_args_or_locals): Add frame_print_options parameter.
9020 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9021 * python/py-framefilter.c (enumerate_args): Pass down
9022 USER_FRAME_PRINT_OPTIONS.
9023 * stack.c: Include "cli/cli-option.h".
9024 (print_frame_arguments_all, print_frame_arguments_scalars)
9025 (print_frame_arguments_none): Declare.
9026 (print_raw_frame_arguments, print_entry_values): Delete.
9027 (user_frame_print_options): New.
9028 (boolean_option_def, enum_option_def, frame_print_option_defs):
9029 New.
9030 (struct backtrace_cmd_options): New.
9031 (bt_flag_option_def): New.
9032 (backtrace_command_option_defs): New.
9033 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9034 (print_frame_arg, read_frame_arg, print_frame_args)
9035 (print_frame_info, print_frame): Add frame_print_options parameter
9036 and use it.
9037 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9038 (backtrace_command_1): Add frame_print_options and
9039 backtrace_cmd_options parameters and use them.
9040 (make_backtrace_options_def_group): New.
9041 (backtrace_command): Process command options with
9042 gdb::option::process_options.
9043 (backtrace_command_completer): New.
9044 (_initialize_stack): Extend "backtrace"'s help to mention
9045 supported options. Install completer for "backtrace".
9046 Install some settings commands with add_setshow_cmds_for_options.
9047
2daf894e
PA		 90482019-06-13 Pedro Alves <palves@redhat.com>
9049
9050 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9051 and that "set/show print raw frame-arguments" are now deprecated.
9052
9053 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9054 command.
9055 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9056 * stack.c (_initialize_stack): Install "set/show print
9057 raw-frame-arguments", and deprecate "set/show print raw
9058 frame-arguments".
9059 * valprint.c (_initialize_valprint): Deprecate "set/show print
9060 raw".
9061
e6ed716c
PA		 90622019-06-13 Pedro Alves <palves@redhat.com>
9063
9064 * compile/compile.c (struct compile_options): New.
9065 (compile_flag_option_def, compile_command_option_defs)
9066 (make_compile_options_def_group): New.
9067 (compile_file_command): Handle options with
9068 gdb::option::process_options.
9069 (compile_file_command_completer): New function.
9070 (compile_code_command): Handle options with
9071 gdb::option::process_options.
9072 (compile_code_command_completer): New function.
9073 (_initialize_compiler): Install completers for "compile code" and
9074 "compile file". Mention available options in "compile code" and
9075 "compile code"'s help.
9076 * completer.c (advance_to_completion_word): New, factored out from
9077 ...
9078 (advance_to_expression_complete_word_point): ... this.
9079 (advance_to_filename_complete_word_point): New.
9080 * completer.h (advance_to_filename_complete_word_point): New
9081 declaration.
9082
7d8062de
PA		 90832019-06-13 Pedro Alves <palves@redhat.com>
9084
9085 * compile/compile.c: Include "cli/cli-option.h".
9086 (compile_print_value): Scope data pointer is now a
9087 value_print_options pointer; adjust.
9088 (compile_print_command): Process options. Scope data pointer is
9089 now a value_print_options pointer; adjust.
9090 (_initialize_compile): Update "compile print"'s help to include
9091 supported options. Install a completer for "compile print".
9092 * cp-valprint.c (show_vtblprint, show_objectprint)
9093 (show_static_field_print): Delete.
9094 (_initialize_cp_valprint): Don't install "set print
9095 static-members", "set print vtbl", "set print object" here.
9096 * printcmd.c: Include "cli/cli-option.h" and
9097 "common/gdb_optional.h".
9098 (print_command_parse_format): Rework to fill in a
9099 value_print_options instead of a format_data.
9100 (print_value): Change parameter type from format_data pointer to
9101 value_print_options reference. Adjust.
9102 (print_command_1): Process options. Adjust to pass down a
9103 value_print_options.
9104 (print_command_completer): New.
9105 (_initialize_printcmd): Install print_command_completer as
9106 handle_brkchars completer for the "print" command. Update
9107 "print"'s help to include supported options.
9108 * valprint.c: Include "cli/cli-option.h".
9109 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9110 here from cp-valprint.c.
9111 (boolean_option_def, uinteger_option_def)
9112 (value_print_option_defs, make_value_print_options_def_group):
9113 New. Use gdb::option::add_setshow_cmds_for_options to install
9114 "set print elements", "set print null-stop", "set print repeats",
9115 "set print pretty", "set print union", "set print array", "set
9116 print address", "set print symbol", "set print array-indexes".
9117 * valprint.h: Include <string> and "cli/cli-option.h".
9118 (make_value_print_options_def_group): Declare.
9119 (print_value): Change parameter type from format_data pointer to
9120 value_print_options reference.
9121 (print_command_completer): Declare.
9122
9d0faba9
PA		 91232019-06-13 Pedro Alves <palves@redhat.com>
9124
9125 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9126 (COMMON_SFILES): Add maint-test-settings.c.
9127 * cli/cli-decode.c (boolean_enums): New global, factored out from
9128 ...
9129 (add_setshow_boolean_cmd): ... here.
9130 * cli/cli-decode.h (boolean_enums): Declare.
9131 * cli/cli-option.c: New file.
9132 * cli/cli-option.h: New file.
9133 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9134 factored out from ...
9135 (parse_cli_boolean_value(const char *)): ... this.
9136 (is_unlimited_literal): Change parameter type to pointer to
9137 pointer. Adjust and advance ARG pointer.
9138 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9139 (parse_cli_var_enum): New, factored out from ...
9140 (do_set_command): ... this. Adjust.
9141 * cli/cli-setshow.h (parse_cli_boolean_value)
9142 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9143 (parse_cli_var_enum): Declare.
9144 * cli/cli-utils.c: Include "cli/cli-option.h".
9145 (get_ulongest): New.
9146 * cli/cli-utils.h (get_ulongest): Declare.
9147 (check_for_argument): New overloads.
9148 * maint-test-options.c: New file.
9149
2c722807
PA		 91502019-06-13 Pedro Alves <palves@redhat.com>
9151
9152 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9153 parse a range if "-" is at the end of the string.
9154
dee7b4c8
PA		 91552019-06-13 Pedro Alves <palves@redhat.com>
9156
9157 * cli/cli-setshow.c (parse_auto_binary_operation)
9158 (parse_cli_boolean_value): Don't allow "o".
9159
dca0f6c0
PA		 91602019-06-13 Pedro Alves <palves@redhat.com>
9161
9162 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9163 * NEWS: Mention maint test-settings KIND.
9164 * maint-test-settings.c: New file.
9165
597bf39d
PA		 91662019-06-13 Pedro Alves <palves@redhat.com>
9167
9168 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9169 completer.
9170 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9171 "set" completers.
9172
48c410fb
PA		 91732019-06-13 Pedro Alves <palves@redhat.com>
9174
9175 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9176 after item.
9177
93bcb043
PA		 91782019-06-13 Pedro Alves <palves@redhat.com>
9179
9180 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9181
cbba3ecd
PA		 91822019-06-13 Pedro Alves <palves@redhat.com>
9183
9184 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9185 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9186 call.
9187 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9188 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9189 calls.
9190 (check_for_argument): Skip spaces after argument.
9191
b9a3f842
PA		 91922019-06-13 Pedro Alves <palves@redhat.com>
9193
9194 * thread.c (thread_apply_command): Adjust TID parsing.
9195 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9196 detected before end of string.
9197 (tid_is_in_list): Error out if LIST is invalid.
9198
3844e605
PA		 91992019-06-13 Pedro Alves <palves@redhat.com>
9200
9201 * completer.c (complete_line_internal_1): Rewind completion word
9202 point.
9203 (completion_tracker::advance_custom_word_point_by): Change
9204 parameter type to int.
9205 * completer.h (completion_tracker::advance_custom_word_point_by):
9206 Likewise.
9207
00b56dbe
PA		 92082019-06-13 Pedro Alves <palves@redhat.com>
9209
9210 * completer.c (advance_to_completion_word): Handle delimiters.
9211
d106773e
PA		 92122019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9213
9214 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9215
08f10e02
TT		 92162019-06-11 Tom Tromey <tom@tromey.com>
9217
9218 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9219 (xmalloc_failed): Move to alloc.c.
9220 * alloc.c: New file.
9221 * Makefile.in (COMMON_SFILES): Add alloc.c.
9222
1c7fe951
TT		 92232019-06-11 Tom Tromey <tom@tromey.com>
9224
9225 * nat/linux-waitpid.c: Don't include server.h.
9226 (linux_debug): Remove.
9227 (my_waitpid): Update.
9228
89549d7f
TT		 92292019-06-11 Tom Tromey <tromey@adacore.com>
9230
9231 * infcall.c (_initialize_infcall): Remove trailing newline from
9232 help.
9233 * user-regs.c (_initialize_user_regs): Remove trailing newline
9234 from help.
9235 * typeprint.c (_initialize_typeprint): Remove trailing newline
9236 from help.
9237 * reverse.c (_initialize_reverse): Remove trailing newlines from
9238 help.
9239 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9240 from help.
9241 * language.c (add_set_language_command): Remove trailing newline
9242 from help.
9243 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9244 help.
9245 * disasm.c (_initialize_disasm): Remove trailing newline from
9246 help.
9247 * top.c (init_main): Remove trailing newline from help.
9248 * interps.c (_initialize_interpreter): Remove trailing newline
9249 from help.
9250 * btrace.c (_initialize_btrace): Remove trailing newlines from
9251 help.
9252 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9253 from help.
9254 * python/python.c (_initialize_python): Remove trailing newline
9255 from help.
9256 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9257 help.
9258 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9259 from help. Reformat some text.
9260 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9261 from help.
9262 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9263 newline from help.
9264
86108c13
TT		 92652019-06-11 Tom Tromey <tromey@adacore.com>
9266
9267 * darwin-nat.c (darwin_decode_exception_message)
9268 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9269
a7067863
AB		 92702019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9271
9272 * valops.c (value_slice): Check for not allocated or not
9273 associated values.
9274
9ab08412
TV		 92752019-06-10 Tom de Vries <tdevries@suse.de>
9276
9277 PR gdb/24618
9278 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9279 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9280 invalid.
9281
f19e22e9
TV		 92822019-06-10 Tom de Vries <tdevries@suse.de>
9283
9284 PR gdb/24611
9285 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9286 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9287
e99f9db0
TV		 92882019-06-10 Tom de Vries <tdevries@suse.de>
9289
9290 PR symtab/24545
9291 * symtab.c (struct demangled_name_entry): Add language field.
9292 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9293 static minimal symbol". Set and use language field.
9294
9bf7038b
TT		 92952019-06-10 Tom Tromey <tromey@adacore.com>
9296
9297 * ada-lang.c (_initialize_ada_language): Update help text.
9298
422186a9
TT		 92992019-06-10 Tom Tromey <tromey@adacore.com>
9300
9301 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9302 with a newline.
9303 * guile/guile.c (handle_boot_error): Don't end warning with a
9304 newline.
9305 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9306 warning with a newline.
9307 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9308 newline.
9309 (s12z_frame_cache): Likewise.
9310 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9311 a newline.
9312 * solib-svr4.c (disable_probes_interface): Don't end warning with
9313 a newline.
9314 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9315 newline.
9316 * python/python.c (do_finish_initialization): Don't end warning
9317 with a newline.
9318
25ce02ee
TT		 93192019-06-10 Tom Tromey <tom@tromey.com>
9320
9321 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9322 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9323 gdbpy_enter.
9324
caa429d8
TT		 93252019-06-10 Tom Tromey <tromey@adacore.com>
9326
9327 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9328 data.
9329 (elf_new_init): Don't call stabsread_new_init.
9330 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9331 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9332 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9333
81873cc8
TV		 93342019-06-10 Tom de Vries <tdevries@suse.de>
9335
9336 PR symtab/16264
9337 PR symtab/24517
9338 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9339
4fa0265e
РИ		 93402019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9341
9342 * source.c (find_and_open_source): Also rewrite relative file
9343 names.
9344
1a3da2cd
AB		 93452019-04-26 Amos Bird <amosbird@gmail.com>
9346
9347 * annotate.c (annotate_thread_exited): Add "thread-exited"
9348 annotation.
9349
3847a7bf
TT		 93502019-06-06 Tom Tromey <tromey@adacore.com>
9351
9352 * maint.h (class scoped_command_stats): Use
9353 DISABLE_COPY_AND_ASSIGN.
9354 <print_time>: New method.
9355 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9356 print_time.
9357 (scoped_command_stats::print_time): New method.
9358
312617a3
AB		 93592019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9360
9361 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9362 instructions of lengths 6 or 8 bytes.
9363
b02f78f9
PA		 93642019-06-04 Pedro Alves <palves@redhat.com>
9365
9366 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9367
9368 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9369 * breakpoint.c (condition_completer): Likewise.
9370 * cli/cli-dump.c (scan_expression): Likewise.
9371 * common/filestuff.c (mkdir_recursive): Likewise.
9372 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9373 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9374 (gdb_abspath): Likewise.
9375 * compile/compile-cplus-types.c
9376 (compile_cplus_instance::decl_name): Likewise.
9377 * completer.c (complete_explicit_location):
9378 (signal_completer, reg_or_group_completer_1): Likewise.
9379 * cp-support.c (cp_remove_params_if_any): Likewise.
9380 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9381 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9382 * infcmd.c (strip_bg_char): Likewise.
9383 * linespec.c (copy_token_string): Likewise.
9384 * mi/mi-main.c (output_cores): Likewise.
9385 * psymtab.c (psymtab_search_name):
9386 * symfile.c (test_set_ext_lang_command): Likewise.
9387 * target.c (target_fileio_read_stralloc): Likewise.
9388 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9389 * value.c (complete_internalvar): Likewise.
9390
e1f2e1a2
CB		 93912019-06-04 Christian Biesinger <cbiesinger@google.com>
9392
9393 Add objfile property to gdb.Type.
d3238f7d
PA		 9394 * NEWS: Mention Python API addition.
9395 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9396
e664d728
PW		 93972019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9398
9399 * NEWS: Mention the new set|show style [title|highlight].
9400 Mention changes to "show style", "help" and "apropos".
9401
66d8c862
PW		 94022019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9403
9404 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9405 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9406 instead of print_help_for_command.
9407 (print_doc_of_command): New function.
9408 (help_list): Add 'apropos -v word' suggestion.
9409 (print_help_for_command): Style the command name using title style.
9410 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9411 (_initialize_cli_cmds): Describe -v in apropos_command help.
9412
9303eb2f
PW		 94132019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9414
9415 * cli/cli-style.h (cli_style_option): Add name in constructor,
9416 add m_name class member, add constructor with intensity,
9417 add name class function.
9418 (cli_style_option::add_setshow_commands): Remove name argument.
9419 (highlight_style, title_style): New styles.
9420 * cli/cli-style.c (do_show): New function that shows a style
9421 characteristic styling the style name with itself.
9422 (set_style_name): New function.
9423 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9424 Update all callers according to the changes in cli/cli-style.h.
9425 * utils.h (fputs_highlighted): New function.
9426 * utils.c (fputs_highlighted): Likewise.
9427
e2c52041
PW		 94282019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9429
9430 * NEWS: Mention new pipe command and new convenience variables.
9431
947d3946
PW		 94322019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9433
9434 * cli/cli-cmds.c (pipe_command): New function.
9435 (_initialize_cli_cmds): Call add_com for pipe_command.
9436 Define | as an alias for pipe.
9437 (exit_status_set_internal_vars): New function.
9438 (shell_escape): Call exit_status_set_internal_vars.
9439 cli/cli-decode.c (find_command_name_length): Recognize | as
9440 a single character command.
9441
b8fd0918
PW		 94422019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9443
9444 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9445 top.c (execute_command_to_ui_file): New function, mostly a copy
9446 of execute_command_to_string.
9447 (execute_command_to_string): Implement by calling
9448 execute_command_to_ui_file.
9449
68bb5386
PW		 94502019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9451
9452 * top.h (saved_command_line): Remove declaration.
9453 * top.c (previous_saved_command_line, previous_repeat_arguments):
9454 New variables.
9455 (saved_command_line): Make static, define together with other
9456 'repeat variables'.
9457 (dont_repeat): Clear repeat_arguments.
9458 (repeat_previous, get_saved_command_line, save_command_line):
9459 New functions.
9460 (gdb_init): Initialize saved_command_line
9461 and previous_saved_command_line.
9462 * main.c (captured_main_1): Remove saved_command_line initialization.
9463 * event-top.c (handle_line_of_input): Update to use
9464 the new 'repeat' related functions instead of direct access to
9465 saved_command_line.
9466 * command.h (repeat_previous, get_saved_command_line,
9467 save_command_line): New declarations.
9468 (dont_repeat): Add comment.
9469
bfcdb852
TT		 94702019-05-30 Tom Tromey <tromey@adacore.com>
9471
9472 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9473 Fix comment.
9474 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9475
0ef209f2
JV		 94762019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9477
9478 PR cli/24587
9479 * completer.c (complete): Initialize variable word.
9480
955b06fa
SDJ		 94812019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9482
9483 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9484 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9485 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9486 'body' is NULL to the outter 'if', protecting the '!is_define'
9487 situation as well.
9488
fa9c3fa0
TT		 94892019-05-29 Tom Tromey <tromey@adacore.com>
9490
9491 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9492 (dwarf_unknown): New function.
9493 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9494 (dwarf_type_encoding_name): Use dwarf_unknown.
9495
4330d61d
TT		 94962019-05-29 Tom Tromey <tromey@adacore.com>
9497
9498 PR c++/20020:
9499 * cp-valprint.c (cp_print_value_fields): Call
9500 cp_print_static_field inside "try".
9501
33a6bc35
TT		 95022019-05-29 Tom Tromey <tromey@adacore.com>
9503
9504 * inflow.c (struct terminal_info): Add default operator=.
9505 * configure: Rebuild.
9506 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9507 -Wdeprecated-copy-dtor, -Wredundant-move.
9508
000439d5
TT		 95092019-05-29 Tom Tromey <tromey@adacore.com>
9510
9511 * NEWS: Add entry.
9512 * infcmd.c (print_return_value_1): Handle finish_print
9513 option.
9514 (show_print_finish): New function.
9515 (_initialize_infcmd): Add "set/show print finish" commands.
9516 * valprint.c (user_print_options): Initialize new member.
9517 * valprint.h (struct value_print_options) <finish_print>: New
9518 member.
9519
c0e70c62
TT		 95202019-05-28 Tom Tromey <tromey@adacore.com>
9521
9522 * ada-lang.c (ada_remove_Xbn_suffix)
9523 (find_old_style_renaming_symbol)
9524 (parse_old_style_renaming): Remove.
9525 (ada_find_renaming_symbol): Don't call
9526 find_old_style_renaming_symbol.
9527 (ada_is_renaming_symbol): Rename from
9528 ada_find_renaming_symbol. Remove "block" parameter. Return
9529 bool. Now static.
9530 (ada_read_var_value): Update and simplify.
9531 * ada-exp.y (write_var_or_type): Remove old code.
9532
766f8836
AH		 95332019-05-28 Alan Hayward <alan.hayward@arm.com>
9534
68255adc 9535 PR gdb/25010
766f8836
AH		 9536 * event-top.c: Remove include comment.
9537 * inflow.c (class scoped_ignore_sigttou): Move from here...
9538 * inflow.h (class scoped_ignore_sigttou): ...to here.
9539 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9540 * top.c: Remove include comment.
9541
eb41253a
TT		 95422019-05-27 Tom Tromey <tom@tromey.com>
9543
9544 * NEWS: Fix typo.
9545
4ca51187
TT		 95462019-05-22 Tom Tromey <tromey@adacore.com>
9547
9548 * target.c (target_follow_exec): Constify parameter.
9549 * target-delegates.c: Rebuild.
9550 * remote.c (remote_target::follow_exec): Constify parameter.
9551 * infrun.c (follow_exec): Constify parameter.
9552 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9553 (target_follow_exec): Likewise.
9554
8fca4da0
AH		 95552019-05-22 Alan Hayward <alan.hayward@arm.com>
9556
9557 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9558 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9559
b7060614
AH		 95602019-05-22 Alan Hayward <alan.hayward@arm.com>
9561
9562 * NEWS: Add debugredirect and testsuite sections.
9563
0a5954bd
SC		 95642019-05-22 Simon Cook <simon.cook@embecosm.com>
9565
9566 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9567 target descriptions using exclusively floating point register name
9568 aliases.
9569
dc42e902
AB		 95702019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9571
9572 PR gdb/18644:
9573 * f-lang.c (build_fortran_types): Handle the case where
9574 gdbarch_floatformat_for_type returns a nullptr.
9575
fb7806c7
TV		 95762019-05-21 Tom de Vries <tdevries@suse.de>
9577
9578 PR cli/24587
9579 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9580
34d11c68
AB		 95812019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9582
9583 PR gdb/18644:
9584 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9585 16-byte floats.
9586 * i386-tdep.c (i386_floatformat_for_type): Use
9587 floatformats_ia64_quad for the 16-byte floating point component
9588 within a fortran 32-byte complex number.
9589
122cf0f2
AB		 95902019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9591
9592 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9593 delete default constructor.
9594 (find_partial_die): Update to return const struct.
9595 (partial_die_parent_scope): Move variable declaration into scope
9596 of its use and change its type to auto.
9597 (guess_partial_die_structure_name): Likewise.
9598 (partial_die_info::fixup): Likewise.
9599
33d0e35a
TT		 96002019-05-17 Tom Tromey <tromey@adacore.com>
9601
9602 * source.c (find_and_open_source): Remove cast.
9603
a45575b0
TT		 96042019-05-17 Tom Tromey <tromey@adacore.com>
9605
9606 * annotate.c (annotate_source): Make "filename" const.
9607 * annotate.h (annotate_source): Use const.
9608
81f47ac2
AH		 96092019-05-17 Alan Hayward <alan.hayward@arm.com>
9610
9611 * disasm.c (set_disassembler_options): Send errors to stderr.
9612
ca1285d1
AH		 96132019-05-17 Alan Hayward <alan.hayward@arm.com>
9614
9615 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9616 (cli_interp_base::set_logging): Check debug_redirect.
9617 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9618 * cli/cli-logging.c (debug_redirect): Add static variable.
9619 (pop_output_files): Add default param.
9620 (handle_redirections): Print debug setting.
9621 (show_logging_command): Likewise.
9622 (_initialize_cli_logging): Add debugredirect command.
9623 * interps.c (current_interp_set_logging): Add debug_redirect
9624 parameter.
9625 * interps.h (set_logging): Add debug_redirect parameter.
9626 (current_interp_set_logging): Likewise.
9627 * mi/mi-common.h: Likewise.
9628 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9629
96302019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH		 9631 Tom Tromey <tromey@adacore.com>
9632
9633 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9634 directly.
9635 * cli/cli-interp.h (make_logging_output): Remove declaration.
9636 * cli/cli-logging.c (make_logging_output): Remove function.
9637 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9638 directly.
9639 * ui-file.c (tee_file::tee_file): Remove bools.
9640 (tee_file::~tee_file): Remove deletes.
9641 * ui-file.h (tee_file): Remove bools.
9642
26648588
JV		 96432019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9644
9645 * mi/mi-cmds.h (mi_cmd_complete): New function.
9646 * mi/mi-main.c (mi_cmd_complete): Likewise.
9647 * mi/mi-cmds.c: Define new MI command -complete.
9648 * NEWS: Mention new -complete command.
9649
6e035501
JV		 96502019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9651
9652 * completer.h (complete): New function.
9653 * completer.c (complete): Likewise.
9654 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9655 function defined in completer.h.
9656
7d0e2ece
JV		 96572019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9658
e79be6e5 9659 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9660
fb816e8b
TV		 96612019-05-17 Tom de Vries <tdevries@suse.de>
9662
9663 PR gdb/24094
9664 * dwarf2read.c (struct cu_partial_die_info): New struct.
9665 (find_partial_die): Return cu_partial_die_info.
9666 (partial_die_parent_scope, guess_partial_die_structure_name)
9667 (partial_die_info::fixup): Handle new return type of find_partial_die.
9668
677052f2
SDJ		 96692019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9670
a1726c38 9671 PR breakpoints/24541
677052f2
SDJ		 9672 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9673 "std::string", simplifying the algorithm.
9674
f3da9116
SDJ		 96752019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9676
9677 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9678 (stap_static_probe_ops::get_probes): Likewise.
9679
f1bb75ab
SDJ		 96802019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9681
9682 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9683 '-')" and "else if".
9684 (stap_parse_single_operand): Join checks for
9685 "gdbarch_stap_parse_special_token_p" and
9686 "gdbarch_stap_parse_special_token" in the same "if" statement.
9687 Invert check when verifying for operation on register
9688 displacement.
9689
3ca58cde
SDJ		 96902019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9691
9692 * stap-probe.c (stap_get_opcode): Update comment.
9693 (stap_get_expected_argument_type): Likewise.
9694 (handle_stap_probe): Likewise.
9695
af2d9bee
SDJ		 96962019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9697
9698 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9699 return type to 'bool'. Adjust comment. Use 'bool' when
9700 appropriate.
9701 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9702 * stap-probe.c (stap_parse_argument_1): Likewise.
9703 (stap_is_operator): Likewise.
9704 (stap_is_generic_prefix): Likewise.
9705 (stap_is_register_prefix): Likewise.
9706 (stap_is_register_indirection_prefix): Likewise.
9707 (stap_is_integer_prefix): Likewise.
9708 (stap_generic_check_suffix): Likewise.
9709 (stap_check_integer_suffix): Likewise.
9710 (stap_check_register_suffix): Likewise.
9711 (stap_check_register_indirection_suffix): Likewise.
9712 (stap_parse_register_operand): Likewise.
9713 (stap_parse_single_operand): Likewise.
9714 (stap_parse_argument_1): Likewise.
9715 (stap_probe::get_argument_count): Likewise.
9716 (stap_is_operator): Likewise.
9717
61c9c421
TT		 97182019-05-16 Tom Tromey <tromey@adacore.com>
9719
9720 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9721 keyword to foreach.
9722
9ddc1af1
SM		 97232019-05-15 Simon Marchi <simon.marchi@efficios.com>
9724
9725 * linux-thread-db.c (try_thread_db_load_1): Change return type
9726 to bool.
9727 (try_thread_db_load): Likewise.
9728 (try_thread_db_load_from_pdir_1): Likewise.
9729 (try_thread_db_load_from_pdir): Likewise.
9730 (try_thread_db_load_from_sdir): Likewise.
9731 (try_thread_db_load_from_dir): Likewise.
9732 (thread_db_load_search): Likewise.
9733 (has_libpthread): Likewise.
9734 (thread_db_load): Likewise.
9735
7bede828
SDJ		 97362019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9737
9738 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9739 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9740 NULL, and complain/return if that's the case.
9741
c5358db4
JD		 97422019-05-15 John Darrington <john@darrington.wattle.id.au>
9743
9744 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9745 (advance, posn, abstract_read_memory): New functions.
9746 [struct mem_read_abstraction]: New struct.
9747 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9748
c408a94f
TT		 97492019-05-14 Tom Tromey <tromey@adacore.com>
9750
9751 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9752 value is not lval_memory.
9753
e7bd7fba
TT		 97542019-05-14 Tom Tromey <tromey@adacore.com>
9755
9756 * solib.c (info_sharedlibrary_command): Style the file name.
9757
a6d0f249
AH		 97582019-05-14 Alan Hayward <alan.hayward@arm.com>
9759
9760 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9761 (aarch64_vnv_type): Likewise.
9762 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9763 * common/tdesc.c: Likewise.
9764 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9765 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9766 * features/aarch64-fpu.xml: Add ieee half view.
9767 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9768 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9769 * gdbtypes.h (struct builtin_type): Likewise.
9770 (struct objfile_type): Likewise.
9771
66b8bb74
SM		 97722019-05-12 Paul Naert <paul.naert@polymtl.ca>
9773
9774 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9775 typo.
9776 * location.h (string_to_event_location): Likewise.
9777
21c219fd
JB		 97782019-05-11 Joel Brobecker <brobecker@adacore.com>
9779
9780 GDB 8.3 released.
9781
13674803
SM		 97822019-05-10 Simon Marchi <simon.marchi@efficios.com>
9783
9784 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9785 New variable declaration.
9786 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9787 New variable.
9788 (print_one_breakpoint): Use ui_out::test_flags and new global
9789 variable to compute use_fixed_output.
9790 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9791 Remove.
9792 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9793 (mi_multi_location_breakpoint_output_fixed): Remove.
9794 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9795 new variable.
9796 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9797 fix_multi_location_breakpoint_output flag if version >= 3.
9798 * ui-out.h (enum ui_out_flag)
9799 <fix_multi_location_breakpoint_output>: New enumerator.
9800
a9eac7f9
SM		 98012019-05-10 Simon Marchi <simon.marchi@efficios.com>
9802
9803 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9804
71bed2db
TT		 98052019-05-10 Tom Tromey <tromey@adacore.com>
9806
9807 * ada-lang.c (catch_ada_completer): New function.
9808 (_initialize_ada_language): Use it.
9809
24c54127
TT		 98102019-05-10 Tom Tromey <tromey@adacore.com>
9811
9812 * thread.c (print_thread_info): Make "requested_threads" const.
9813 * gdbthread.h (print_thread_info): Make "requested_threads"
9814 const.
9815 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9816 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9817
7a102139
TT		 98182019-05-08 Tom Tromey <tom@tromey.com>
9819
9820 * gdbtypes.c (objfile_type_data): Change type.
9821 (objfile_type, _initialize_gdbtypes): Update.
9822
924d79e2
TT		 98232019-05-08 Tom Tromey <tom@tromey.com>
9824
9825 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9826 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9827 (_initialize_dwarf2_frame): Update.
9828
4c58e337
TT		 98292019-05-08 Tom Tromey <tom@tromey.com>
9830
9831 * objc-lang.c (objc_objfile_data): Change type.
9832 (find_methods): Update.
9833 (_initialize_objc_lang): Remove.
9834
d772d2ab
TT		 98352019-05-08 Tom Tromey <tom@tromey.com>
9836
9837 * stabsread.c (rs6000_builtin_type_data): Change type.
9838 (rs6000_builtin_type, _initialize_stabsread): Update.
9839
d11d83f4
TT		 98402019-05-08 Tom Tromey <tom@tromey.com>
9841
9842 * mips-tdep.c (mips_pdr_data): Remove.
9843 (_initialize_mips_tdep): Update.
9844
9a73f0ad
TT		 98452019-05-08 Tom Tromey <tom@tromey.com>
9846
9847 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9848 (hppa_init_objfile_priv_data, read_unwind_info)
9849 (find_unwind_entry, _initialize_hppa_tdep): Update.
9850
8127a2fa
TT		 98512019-05-08 Tom Tromey <tom@tromey.com>
9852
9853 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9854 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9855 on obstack.
9856 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9857
91d3055d
TT		 98582019-05-08 Tom Tromey <tom@tromey.com>
9859
9860 * mdebugread.c (basic_type_data): Change type.
9861 (basic_type, _initialize_mdebugread): Update.
9862
31930bd3
TT		 98632019-05-08 Tom Tromey <tom@tromey.com>
9864
9865 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9866
bdb3ed9e
TT		 98672019-05-08 Tom Tromey <tom@tromey.com>
9868
9869 * nto-tdep.c (nto_inferior_data_reg): Change type.
9870 (nto_inferior_data): Update.
9871 (nto_inferior_data_cleanup, nto_new_inferior_data)
9872 (_initialize_nto_tdep): Remove.
9873 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9874
f37b313d
TT		 98752019-05-08 Tom Tromey <tom@tromey.com>
9876
9877 * ada-lang.c (struct ada_inferior_data): Add initializers.
9878 (ada_inferior_data): Change type.
9879 (ada_inferior_data_cleanup): Remove.
9880 (get_ada_inferior_data, ada_inferior_exit)
9881 (struct ada_pspace_data): Add initializers, destructor.
9882 (ada_pspace_data_handle): Change type.
9883 (get_ada_pspace_data): Update.
9884 (ada_pspace_data_cleanup): Remove.
9885
24699405
TT		 98862019-05-08 Tom Tromey <tom@tromey.com>
9887
9888 * coffread.c (struct coff_symfile_info): Add initializers.
9889 (coff_objfile_data_key): Move lower. Change type.
9890 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9891 Update.
9892 (coff_free_info): Remove.
9893
d4e05d2f
TT		 98942019-05-08 Tom Tromey <tom@tromey.com>
9895
9896 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9897 (fbsd_pspace_data_handle): Move lower. Change type.
9898 (get_fbsd_pspace_data): Update.
9899 (fbsd_pspace_data_cleanup): Remove.
9900 (_initialize_fbsd_tdep): Update.
9901
14ef6690
TT		 99022019-05-08 Tom Tromey <tom@tromey.com>
9903
9904 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9905 (get_ada_tasks_pspace_data): Update.
9906 (ada_tasks_pspace_data_cleanup): Remove.
9907 (_initialize_tasks): Update.
9908 (ada_tasks_inferior_data_handle): Change type.
9909 (get_ada_tasks_inferior_data): Update.
9910 (ada_tasks_inferior_data_cleanup): Remove.
9911 (struct ada_tasks_pspace_data): Add initializers.
9912
814cf43a
TT		 99132019-05-08 Tom Tromey <tom@tromey.com>
9914
9915 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9916 * symfile-debug.c (debug_sym_get_probes): Change type.
9917 * stap-probe.c (handle_stap_probe):
9918 (stap_static_probe_ops::get_probes): Change type.
9919 * probe.h (class static_probe_ops) <get_probes>: Change type.
9920 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9921 (parse_probes_in_pspace): Update.
9922 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9923 Update.
9924 (any_static_probe_ops::get_probes): Change type.
9925 * elfread.c (elfread_data): New typedef.
9926 (probe_key): Change type.
9927 (elf_get_probes): Likewise. Update.
9928 (probe_key_free): Remove.
9929 (_initialize_elfread): Update.
9930 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9931 Change type.
9932 (dtrace_process_dof_probe, dtrace_process_dof)
9933 (dtrace_static_probe_ops::get_probe): Change type.
9934
02dc647e
TT		 99352019-05-08 Tom Tromey <tom@tromey.com>
9936
9937 * xcoffread.c (struct xcoff_symfile_info): Rename from
9938 coff_symfile_info. Add initializers.
9939 (xcoff_objfile_data_key): Move lower. Change type.
9940 (XCOFF_DATA): Rewrite.
9941 (xcoff_free_info): Remove.
9942 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9943 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9944 (xcoff_initial_scan): Update.
9945
09232438
TT		 99462019-05-08 Tom Tromey <tom@tromey.com>
9947
9948 * solib-svr4.c (struct svr4_info): Add initializers and
9949 destructor.
9950 <probes_table>: Now an htab_up.
9951 (solib_svr4_pspace_data): Change type.
9952 (free_probes_table): Simplify.
9953 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9954 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9955 (probes_table_remove_objfile_probes, register_solib_event_probe)
9956 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9957 (_initialize_svr4_solib): Update.
9958
7b4a314f
TT		 99592019-05-08 Tom Tromey <tom@tromey.com>
9960
9961 * remote.c (remote_pspace_data): Change type.
9962 (remote_pspace_data_cleanup): Remove.
9963 (get_remote_exec_file, set_pspace_remote_exec_file)
9964 (_initialize_remote): Update.
9965
51d3063a
TT		 99662019-05-08 Tom Tromey <tom@tromey.com>
9967
9968 * breakpoint.c (breakpoint_objfile_key): Change type.
9969 (get_breakpoint_objfile_data): Update.
9970 (free_breakpoint_objfile_data): Remove.
9971 (_initialize_breakpoint): Update.
9972
89fb8848
TT		 99732019-05-08 Tom Tromey <tom@tromey.com>
9974
9975 * linux-tdep.c (struct linux_info): Add initializers.
9976 (linux_inferior_data): Move. Change type.
9977 (invalidate_linux_cache_inf): Update.
9978 (linux_inferior_data_cleanup): Remove.
9979 (get_linux_inferior_data, _initialize_linux_tdep): Update.
9980
e9b89e2d
TT		 99812019-05-08 Tom Tromey <tom@tromey.com>
9982
9983 * auxv.c (auxv_inferior_data): Move. Change type.
9984 (auxv_inferior_data_cleanup): Remove.
9985 (invalidate_auxv_cache_inf): Rewrite.
9986 (get_auxv_inferior_data, _initialize_auxv): Update.
9987
8c42777c
TT		 99882019-05-08 Tom Tromey <tom@tromey.com>
9989
9990 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9991 (symfile_debug_objfile_data_key): Change type.
9992 (symfile_debug_installed, debug_qf_has_symbols)
9993 (debug_qf_find_last_source_symtab)
9994 (debug_qf_forget_cached_source_info)
9995 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9996 (debug_qf_print_stats, debug_qf_dump)
9997 (debug_qf_expand_symtabs_for_function)
9998 (debug_qf_expand_all_symtabs)
9999 (debug_qf_expand_symtabs_with_fullname)
10000 (debug_qf_map_matching_symbols)
10001 (debug_qf_expand_symtabs_matching)
10002 (debug_qf_find_pc_sect_compunit_symtab)
10003 (debug_qf_map_symbol_filenames)
10004 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10005 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10006 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10007 (debug_sym_read_linetable, debug_sym_relocate): Update.
10008 (symfile_debug_free_objfile): Remove.
10009 (install_symfile_debug_logging, _initialize_symfile_debug):
10010 Update.
10011
5bfd760d
TT		 100122019-05-08 Tom Tromey <tom@tromey.com>
10013
10014 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10015 allocate_on_obstack.
10016 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10017 (get_dwarf2_per_objfile): Update.
10018 (set_dwarf2_per_objfile): Remove.
10019 (dwarf2_has_info, dwarf2_get_section_info): Update.
10020 (dwarf2_free_objfile): Remove.
10021 (_initialize_dwarf2_read): Update.
10022
e85e19b4
TT		 100232019-05-08 Tom Tromey <tom@tromey.com>
10024
10025 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10026 initializers.
10027 <unsupported_script_warning_printed,
10028 script_not_found_warning_printed>: Now bool.
10029 (auto_load_pspace_data): Change type.
10030 (~auto_load_pspace_info): Rename from
10031 auto_load_pspace_data_cleanup.
10032 (get_auto_load_pspace_data, init_loaded_scripts_info)
10033 (clear_section_scripts, maybe_print_unsupported_script_warning)
10034 (maybe_print_script_not_found_warning, _initialize_auto_load):
10035 Update.
10036
f6aa7436
TT		 100372019-05-08 Tom Tromey <tom@tromey.com>
10038
10039 * objfiles.c (objfile_pspace_info): Add destructor and
10040 initializers.
10041 (objfiles_pspace_data): Change type.
10042 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10043 (get_objfile_pspace_data): Update.
10044 (objfiles_bfd_data): Change type.
10045 (get_objfile_bfd_data): Update.
10046 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10047
6ae614f6
TT		 100482019-05-08 Tom Tromey <tom@tromey.com>
10049
10050 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10051 Change type.
10052 (get_catch_syscall_inferior_data): Update.
10053 (catch_syscall_inferior_data_cleanup): Remove.
10054 (_initialize_break_catch_syscall): Update.
10055
6509b8eb
TT		 100562019-05-08 Tom Tromey <tom@tromey.com>
10057
10058 * inflow.c (struct terminal_info): Add destructor and
10059 initializers.
10060 (inflow_inferior_data): Change type.
10061 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10062 (get_inflow_inferior_data, inflow_inferior_exit)
10063 (swap_terminal_info, _initialize_inflow): Update.
10064
35632941
TT		 100652019-05-08 Tom Tromey <tom@tromey.com>
10066
10067 * target-dcache.c (target_dcache_cleanup): Remove.
10068 (target_dcache_aspace_key): Change type.
10069 (target_dcache_init_p, target_dcache_invalidate)
10070 (target_dcache_get, target_dcache_get_or_init)
10071 (_initialize_target_dcache): Update.
10072 * dcache.h (struct dcache_deleter): New.
10073
3017b94d
TT		 100742019-05-08 Tom Tromey <tom@tromey.com>
10075
10076 * symtab.c (struct symbol_cache): Add destructor and
10077 initializers.
10078 (symbol_cache_key): Move. Change type.
10079 (make_symbol_cache, free_symbol_cache): Remove.
10080 (get_symbol_cache): Update.
10081 (symbol_cache_cleanup): Remove.
10082 (ALL_PSPACES, symbol_cache_flush)
10083 (maintenance_print_symbol_cache)
10084 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10085 Update.
10086
a32ad8c5
TT		 100872019-05-08 Tom Tromey <tom@tromey.com>
10088
10089 * symtab.c (struct main_info): Add destructor and initializers.
10090 (main_progspace_key): Move. Change type.
10091 (get_main_info): Update.
10092 (main_info_cleanup): Remove.
10093 (_initialize_symtab): Update.
10094
5f6e90a0
TT		 100952019-05-08 Tom Tromey <tom@tromey.com>
10096
10097 * registry.h (DECLARE_REGISTRY): Define the _key class.
10098
1bd0c6e4
AB		 100992019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10100
10101 * NEWS: Merge two 'New commands' sections.
10102
2228ef77
XR		 101032019-05-08 Joel Brobecker <brobecker@adacore.com>
10104
10105 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10106 parameter and use Ada language definition instead.
10107 (ada_val_print_ptr): Remove unused language parameter.
10108 (ada_val_print_num): Remove language parameter and use Ada language
10109 definition instead.
10110 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10111 parameter.
10112 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10113 parameter and use Ada language definition instead.
10114 (ada_val_print_1): Update all ada_val_print_xxx calls.
10115 Remove language parameter.
10116 (ada_val_print): Update ada_val_print_1 call.
10117
60fcc1c3
TT		 101182019-05-08 Tom Tromey <tromey@adacore.com>
10119
10120 * remote.c (remote_hw_watchpoint_limit)
10121 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10122 Now static.
10123
ed2b7c17
TT		 101242019-05-08 Tom Tromey <tromey@adacore.com>
10125
10126 * maint.c (_initialize_maint_cmds): Move initialization code to
10127 remote.c.
10128 (watchdog, show_watchdog): Move to remote.c.
10129 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10130 "watchdog" static.
10131 (_initialize_remote): Move initialization code from maint.c.
10132 * defs.h (watchdog): Don't declare.
10133
b0be6c91
TT		 101342019-05-08 Tom Tromey <tromey@adacore.com>
10135
10136 * tui/tui-interp.c: Include main.h.
10137 * interps.c: Include main.h.
10138 * main.h (interpreter_p): Declare.
10139 * defs.h (interpreter_p): Don't declare.
10140
587ee17b
TT		 101412019-05-08 Tom Tromey <tromey@adacore.com>
10142
10143 * dwarf2loc.c: Include dwarf2read.h.
10144 * defs.h (read_unsigned_leb128): Don't declare.
10145 * dwarf2read.h (read_unsigned_leb128): Declare.
10146
ca1df239
TT		 101472019-05-08 Tom Tromey <tromey@adacore.com>
10148
10149 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10150 method.
10151
99f20f08
TT		 101522019-05-08 Tom Tromey <tromey@adacore.com>
10153
10154 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10155 when no wrap column is set.
10156
80e55b13
TT		 101572019-05-08 Tom Tromey <tromey@adacore.com>
10158
10159 * c-lang.c (c_get_string): Handle non-C-style arrays.
10160
9d3421af
TT		 101612019-05-08 Tom Tromey <tromey@adacore.com>
10162
10163 * typeprint.c (print_offset_data::update): Print the bit offset,
10164 not the number of bits remaining.
10165
844333e2
TT		 101662019-05-08 Tom Tromey <tromey@adacore.com>
10167
10168 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10169 padding at end of comment.
10170
988915ee
TT		 101712019-05-08 Tom Tromey <tromey@adacore.com>
10172
10173 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10174 Compare main types.
10175
26bfd823
TT		 101762019-05-06 Tom Tromey <tom@tromey.com>
10177
10178 * common/scoped_mmap.c: Include common-defs.h.
10179 * common/scoped_mmap.h: Don't include config.h.
10180
89055eaa
TT		 101812019-05-04 Tom Tromey <tom@tromey.com>
10182
10183 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10184 (struct aarch64_call_info): Add initializers.
10185 <si>: Now a std::vector.
10186 (pass_on_stack, aarch64_push_dummy_call): Update.
10187
5da01df5
TT		 101882019-05-04 Simon Marchi <simon.marchi@efficios.com>
10189 Tom Tromey <tom@tromey.com>
10190
10191 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10192 (ppc_threads): Now a std::vector. Now static.
10193 (hwdebug_find_thread_points_by_tid)
10194 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10195 Update.
10196
fbdf05a1
TT		 101972019-05-04 Tom Tromey <tom@tromey.com>
10198
10199 * arc-tdep.c (arc_tdesc_init): Return bool.
10200
06d16ec9
TT		 102012019-05-04 Tom Tromey <tom@tromey.com>
10202
10203 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10204 Use gdb_assert_not_reached.
10205
9c056022
TT		 102062019-05-04 Tom Tromey <tom@tromey.com>
10207
10208 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10209 "false".
10210
fa9c2a59
TT		 102112019-05-04 Tom Tromey <tom@tromey.com>
10212
10213 * arc-tdep.c (arc_tdesc_init): Use bool.
10214
e2eb806a
TT		 102152019-05-04 Tom Tromey <tom@tromey.com>
10216
10217 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10218
6fe87677
TT		 102192019-05-04 Tom Tromey <tom@tromey.com>
10220
10221 * cli/cli-cmds.c (valid_command_p): Return bool.
10222
7f008c9e
TT		 102232019-05-04 Tom Tromey <tom@tromey.com>
10224
10225 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10226 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10227
b6484282
RT		 102282019-05-04 Raul Tambre <raul@tambre.ee>
10229
10230 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10231 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10232 operator for comparison.
10233
af97b416
TT		 102342019-05-04 Tom Tromey <tom@tromey.com>
10235
10236 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10237 (lookup_partial_symbol, print_partial_symbols)
10238 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10239 (psymbol_compare): Update.
10240 (add_psymbol_to_bcache): Clear the entire psymbol.
10241 (maintenance_check_psymtabs): Update.
10242 * psympriv.h (struct partial_symbol): Don't derive from
10243 general_symbol_info.
10244 <obj_section, unrelocated_address, address,
10245 set_unrelocated_address>: Update.
10246 <ginfo>: New member.
10247 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10248 (debug_names::write_psymbols): Update.
10249
9d6d4be8
TV		 102502019-05-04 Tom de Vries <tdevries@suse.de>
10251
10252 * contrib/cc-with-tweaks.sh: Support -n arg.
10253
66452beb
PW		 102542019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10255
10256 * corelow.c (core_target::detach): Ensure frame cache and
10257 register caches are cleared.
10258 inferior.c (exit_inferior_1): Likewise.
10259
bde09ab7
TT		 102602019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10261 Tom Tromey <tom@tromey.com>
10262
10263 * dictionary.c (collate_pending_symbols_by_language): Remove
10264 "struct" from foreach.
10265 * symtab.c (lookup_global_symbol_from_objfile)
10266 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10267 foreach.
10268 * ser-tcp.c (net_open): Remove "struct" from foreach.
10269 * objfiles.c (objfile_relocate, objfile_rebase)
10270 (objfile_has_symbols): Remove "struct" from foreach.
10271 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10272 from foreach.
10273 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10274 foreach.
10275 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10276 "struct" from foreach.
10277 * ada-lang.c (create_excep_cond_exprs)
10278 (ada_exception_catchpoint_cond_string): Remove "struct" from
10279 foreach.
10280
222a8d25
TT		 102812019-05-03 Tom Tromey <tromey@adacore.com>
10282
10283 * ada-exp.y (convert_char_literal): Check suffix of each
10284 enumerator.
10285
fcd60b84
DP		 102862019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10287
10288 PR ada/21406:
10289 * ada-exp.y (yywrap): Don't define.
10290 * ada-lex.l (%option): Add noyywrap
10291 (yywrap): Remove.
10292
5f2459c2
EZ		 102932019-05-03 Eli Zaretskii <eliz@gnu.org>
10294
353ea2d1
EZ		 10295 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10296 _WIN32_WINNT to the XP level, unless already defined to a higher
10297 level.
10298
10299 * unittests/parse-connection-spec-selftests.c:
10300 * ser-tcp.c:
10301 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10302 override.
10303
5f2459c2
EZ		 10304 * symfile.c (find_separate_debug_file): Remove colon from the
10305 drive spec of DOS/Windows file names of the target, so that the
10306 file name produced from DEBUGDIR and the target's directory will
10307 be valid on DOS/Windows systems.
10308
80062eb9
AB		 103092019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10310
10311 * rust-lang.c (val_print_struct): Handle printing structures
10312 containing strings.
10313
b8c05e85
TT		 103142019-05-02 Tom Tromey <tromey@adacore.com>
10315
10316 * valarith.c (_initialize_valarith): Remove.
10317
4504bbde
TT		 103182019-05-01 Tom Tromey <tromey@adacore.com>
10319
10320 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10321 bitfields.
10322
d48e62f4
TT		 103232019-05-01 Tom Tromey <tromey@adacore.com>
10324
10325 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10326 for big-endian copies.
10327
15f18d14
AT		 103282019-04-30 Ali Tamur <tamur@google.com>
10329 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10330 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10331 (read_3_bytes): New function.
10332
ab4ee614
JB		 103332019-04-30 Joel Brobecker <brobecker@adacore.com>
10334
10335 * windows-nat.c (main_thread_id): Delete.
10336 (handle_output_debug_string): Replace main_thread_id by
10337 current_event.dwThreadId.
10338 (fake_create_process): Likewise.
10339 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10340 Do not set main_thread_id.
10341 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10342 current_event.dwThreadId.
10343 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10344
8ed5b76e
JB		 103452019-04-30 Joel Brobecker <brobecker@adacore.com>
10346
10347 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10348 Use current_event.dwThreadId instead of main_thread_id.
10349
2ff0a947
TT		 103502019-04-30 Tom Tromey <tromey@adacore.com>
10351
10352 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10353 (create_excep_cond_exprs): Iterate over program spaces.
10354 (ada_exception_catchpoint_cond_string): Examine all minimal
10355 symbols for exception types.
10356
a776957c
TT		 103572019-04-30 Tom Tromey <tromey@adacore.com>
10358
10359 PR c++/24470:
10360 * dwarf2read.c (process_structure_scope): Handle case where type
10361 has template parameters but no symbol was created.
10362
bc68014d
AB		 103632019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10364 Chris January <chris.january@arm.com>
10365
10366 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10367 qualifier.
10368 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10369
f1fdc960
AB		 103702019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10371
10372 * f-typeprint.c (f_print_type): Update rules for printing
10373 whitespace.
10374 (f_type_print_varspec_suffix): Likewise.
10375
bf7a4de1
AB		 103762019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10377 Chris January <chris.january@arm.com>
10378
10379 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10380 function arguments.
10381
bbe75b9d
AB		 103822019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10383
10384 * f-lang.c (build_fortran_types): Change name of void type to
10385 lower case.
10386 * f-typeprint.c (f_type_print_base): Print the name of the void
10387 type, rather than a fixed string.
10388 * f-valprint.c (f_decorations): Use lower case void string.
10389
1db455a7
AB		 103902019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10391 Chris January <chris.january@arm.com>
10392
10393 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10394 types for Fortran.
10395
b6d03bb2
AB		 103962019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10397 Chris January <chris.january@arm.com>
10398 David Lecomber <david.lecomber@arm.com>
10399
10400 * f-exp.y (BINOP_INTRINSIC): New token.
10401 (exp): New parser rule handling BINOP_INTRINSIC.
10402 (f77_keywords): Add new builtin procedures.
10403 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10404 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10405 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10406 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10407 (print_unop_subexp_f): New function.
10408 (print_binop_subexp_f): New function.
10409 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10410 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10411 (dump_subexp_body_f): Likewise.
10412 (operator_check_f): Likewise.
10413 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10414 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10415
83228e93
AB		 104162019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10417
10418 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10419 UNOP_KIND.
10420 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10421 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10422 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10423 (operator_length_f): New fuction.
10424 (print_subexp_f): New function.
10425 (op_name_f): New function.
10426 (dump_subexp_body_f): New function.
10427 (operator_check_f): New function.
10428 (exp_descriptor_f): Replace standard expression handling functions
10429 with new functions.
10430 * gdb/fortran-operator.def: New file.
10431 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10432 * gdb/std-operator.def: Remove UNOP_KIND.
10433
6fdcd7cc
AB		 104342019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10435
10436 * std-operator.def: Remove unbalanced, stray double quote
10437 character.
10438
2e62ab40
AB		 104392019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10440 Chris January <chris.january@arm.com>
10441 Daniel Everett <daniel.everett@arm.com>
10442 Nick Forrington <nick.forrington@arm.com>
10443 Richard Bunt <richard.bunt@arm.com>
10444
10445 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10446 of depth when printing anonymous structs or unions.
10447 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10448 Don't print either the top-level value, or the children if the
10449 max-depth is exceeded.
10450 (ppscm_print_children): When printing the key of a map, allow one
10451 extra level of depth.
10452 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10453 print either the top-level value, or the children if the max-depth
10454 is exceeded.
10455 (print_children): When printing the key of a map, allow one extra
10456 level of depth.
10457 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10458 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10459 (user_print_options): Initialise max_depth field.
10460 (val_print_scalar_or_string_type_p): New function.
10461 (val_print): Check to see if the max depth has been reached.
10462 (val_print_check_max_depth): Define new function.
10463 (show_print_max_depth): New function.
10464 (_initialize_valprint): Add 'print max-depth' option.
10465 * valprint.h (struct value_print_options) <max_depth>: New field.
10466 (val_print_check_max_depth): Declare new function.
10467 * NEWS: Document new feature.
10468
4be290b2
AB		 104692019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10470
10471 * ada-lang.c (ada_language_defn): Initialise new field.
10472 * c-lang.c (c_is_string_type_p): New function.
10473 (c_language_defn): Initialise new field.
10474 (cplus_language_defn): Initialise new field.
10475 (asm_language_defn): Initialise new field.
10476 (minimal_language_defn): Initialise new field.
10477 * c-lang.h (c_is_string_type_p): Declare new function.
10478 * d-lang.c (d_language_defn): Initialise new field.
10479 * f-lang.c (f_is_string_type_p): New function.
10480 (f_language_defn): Initialise new field.
10481 * go-lang.c (go_is_string_type_p): New function.
10482 (go_language_defn): Initialise new field.
10483 * language.c (default_is_string_type_p): New function.
10484 (unknown_language_defn): Initialise new field.
10485 (auto_language_defn): Initialise new field.
10486 * language.h (struct language_defn) <la_is_string_type_p>: New
10487 member variable.
10488 (default_is_string_type_p): Declare new function.
10489 * m2-lang.c (m2_language_defn): Initialise new field.
10490 * objc-lang.c (objc_language_defn): Initialise new field.
10491 * opencl-lang.c (opencl_language_defn): Initialise new field.
10492 * p-lang.c (pascal_is_string_type_p): New function.
10493 (pascal_language_defn): Initialise new field.
10494 * rust-lang.c (rust_is_string_type_p): New function.
10495 (rust_language_defn): Initialise new field.
10496
721b08c6
AB		 104972019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10498
10499 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10500 New field.
10501 * ada-lang.c (ada_language_defn): Initialise new field.
10502 * c-lang.c (c_language_defn): Likewise.
10503 (cplus_language_defn): Likewise.
10504 (asm_language_defn): Likewise.
10505 (minimal_language_defn): Likewise.
10506 * d-lang.c (d_language_defn): Likewise.
10507 * f-lang.c (f_language_defn): Likewise.
10508 * go-lang.c (go_language_defn): Likewise.
10509 * language.c (unknown_language_defn): Likewise.
10510 (auto_language_defn): Likewise.
10511 * m2-lang.c (m2_language_defn): Likewise.
10512 * objc-lang.c (objc_language_defn): Likewise.
10513 * opencl-lang.c (opencl_language_defn): Likewise.
10514 * p-lang.c (pascal_language_defn): Likewise.
10515 * rust-lang.c (rust_language_defn): Likewise.
10516
fc913e53
AB		 105172019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10518
10519 * ada-lang.c (ada_is_character_type): Change return type to bool.
10520 (ada_is_string_type): Likewise.
10521 * ada-lang.h (ada_is_character_type): Update declaration
10522 (ada_is_string_type): Likewise.
10523
fa731fa0
PW		 105242019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10525
10526 Support style in 'frame|thread apply'
10527
10528 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10529 * record.c (record_start, record_stop): Update callers of
10530 execute_command_to_string with false.
10531 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10532 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10533 methods.
10534 (class string_file): New constructor with term_out parameter.
10535 Override methods term_out and can_emit_style_escape. New member
10536 term_out.
10537 (class stdio_file): Override can_emit_style_escape.
10538 (class tee_file): Override term_out and can_emit_style_escape.
10539 * utils.h (can_emit_style_escape): Remove.
10540 * utils.c (can_emit_style_escape): Likewise.
10541 Update all callers of can_emit_style_escape (SOMESTREAM) to
10542 SOMESTREAM->can_emit_style_escape.
10543 * source-cache.c (source_cache::get_source_lines): Likewise.
10544 * stack.c (frame_apply_command_count): Call execute_command_to_string
10545 passing the term_out characteristic of the current gdb_stdout.
10546 * thread.c (thr_try_catch_cmd): Likewise.
10547 * top.c (execute_command_to_string): pass term_out parameter
10548 to construct the string_file for the command output.
10549 * ui-file.c (term_cli_styling): New function (most code moved
10550 from utils.c can_emit_style_escape).
10551 (string_file::string_file, string_file::can_emit_style_escape,
10552 stdio_file::can_emit_style_escape, tee_file::term_out,
10553 tee_file::can_emit_style_escape): New functions.
10554
136afab8
PW		 105552019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10556
10557 * NEWS: Mention the new set|show may-call-functions.
10558 * infcall.c (may_call_functions_p): New variable.
10559 (show_may_call_functions_p): New function.
10560 (call_function_by_hand_dummy): Throws an error if not
10561 may-call-functions.
10562 (_initialize_infcall): Call add_setshow_boolean_cmd for
10563 may-call-functions.
10564
725cbb63
KS		 105652019-04-25 Keith Seitz <keiths@redhat.com>
10566
10567 PR c++/24367
10568 * cp-support.c (inspect_type): Don't attempt substitutions
10569 of symbol with the same name.
10570
3d1cbb78
TT		 105712019-04-25 Tom Tromey <tromey@adacore.com>
10572
10573 PR gdb/24475:
10574 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10575 static.
10576
94aeb44b
TT		 105772019-04-25 Tom Tromey <tromey@adacore.com>
10578
10579 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10580 rvalue reference.
10581 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10582 (gdb_xml_parser::parse): Use std::move.
10583 * python/python-internal.h (gdbpy_convert_exception): Take a const
10584 reference.
10585 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10586 std::move.
10587 * python/py-utils.c (gdbpy_convert_exception): Take a const
10588 reference.
10589 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10590 Use std::move.
10591 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10592 Use std::move.
10593 * mi/mi-main.c (mi_print_exception): Take a const reference.
10594 * main.c (handle_command_errors): Take a const reference.
10595 * linespec.c (parse_linespec): Use std::move.
10596 * infcall.c (run_inferior_call): Use std::move.
10597 (call_function_by_hand_dummy): Use std::move.
10598 * exec.c (try_open_exec_file): Use std::move.
10599 * exceptions.h (exception_print, exception_fprintf)
10600 (exception_print_same): Update.
10601 * exceptions.c (print_exception, exception_print)
10602 (exception_fprintf, exception_print_same): Change parameters to
10603 const reference.
10604 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10605 * common/new-op.c: Use std::move.
10606 * common/common-exceptions.h (struct gdb_exception): Add move
10607 constructor.
10608 (struct gdb_exception_error, struct gdb_exception_quit, struct
10609 gdb_quit_bad_alloc): Change constructor to move constructor.
10610 (throw_exception): Change parameter to rvalue reference.
10611 * common/common-exceptions.c (throw_exception): Take rvalue
10612 reference.
10613 * cli/cli-interp.c (safe_execute_command): Use std::move.
10614 * breakpoint.c (insert_bp_location, location_to_sals): Use
10615 std::move.
10616
680d7fd5
TT		 106172019-04-25 Tom Tromey <tromey@adacore.com>
10618
10619 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10620 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10621 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10622 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10623 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10624 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10625 guile/scm-value.c: Use unpack.
10626 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10627 gdbscm_gdb_exception.
10628 (gdbscm_throw_gdb_exception): Likewise.
10629 (struct gdbscm_gdb_exception): New.
10630 (unpack): New function.
10631 (gdbscm_wrap): Use unpack.
10632
c6fdd8b2
TT		 106332019-04-25 Tom Tromey <tromey@adacore.com>
10634
10635 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10636 (gdb_rl_callback_handler): Use std::move.
10637 * common/common-exceptions.h (struct gdb_exception): Add move
10638 assignment operator.
10639 (throw_exception_sjlj): Change "exception" to const reference.
10640 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10641 (throw_exception_sjlj): Change "exception" to const reference.
10642
cc06b668
TT		 106432019-04-25 Tom Tromey <tromey@adacore.com>
10644
10645 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10646 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10647 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10648 Update.
10649 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10650 Update.
10651 * mi/mi-interp.c (mi_interp::exec): Update.
10652 * linespec.c (parse_linespec): Update.
10653 * infcall.c (run_inferior_call): Update.
10654 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10655 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10656 (gdbscm_lookup_global_symbol): Update.
10657 * guile/scm-param.c (gdbscm_parameter_value): Update.
10658 * guile/scm-frame.c (gdbscm_frame_read_register)
10659 (gdbscm_frame_read_var): Update.
10660 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10661 * exec.c (try_open_exec_file): Update.
10662 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10663 (gdb_rl_callback_handler): Update.
10664 * common/common-exceptions.h (exception_none): Don't declare.
10665 * common/common-exceptions.c (exception_none): Don't define.
10666 (struct catcher) <exception>: Update.
10667 * cli/cli-interp.c (safe_execute_command): Update.
10668 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10669
cf532bd1
AT		 106702019-04-25 Ali Tamur <tamur@google.com>
10671
10672 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10673 (read_attribute_value): Likewise.
10674 (dwarf2_read_addr_index): Update comment.
10675 (read_str_index): Add DW_FORM_strx.
10676 (dwarf2_string_attr): Likewise.
10677 (dwarf2_const_value_attr): Likewise.
10678 (dump_die_shallow): Likewise.
10679 (dwarf2_fetch_constant_bytes): Likewise.
10680 (skip_form_bytes): Likewise.
10681 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10682
82433e3e
SDJ		 106832019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10684
10685 PR corefiles/11608
10686 PR corefiles/18187
10687 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10688 OFFSET. Verify if current mapping contains an ELF header.
10689 (linux_find_memory_regions_full): Adjust call to
10690 dump_mapping_p.
10691
723adb65
SL		 106922019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10693 Kang Li <kanglictf@gmail.com>
10694
10695 PR gdb/21600
10696
10697 * dwarf2-frame.c (read_initial_length): Be consistent about using
10698 unsigned representation of length.
10699 (decode_frame_entry_1): Likewise. Check for wraparound of
10700 end pointer as well as buffer overflow.
10701
596179f7
SDJ		 107022019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10703
10704 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10705 "vq".
10706
a59240a4
TT		 107072019-04-24 Tom Tromey <tromey@adacore.com>
10708
10709 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10710
f872fdbb
AB		 107112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10712
10713 * s12z-tdep.c (s12z_unwind_pc): Delete.
10714 (s12z_unwind_sp): Delete.
10715 (s12z_gdbarch_init): Don't register deleted functions with
10716 gdbarch.
10717
b614e6f3
AB		 107182019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10719
10720 * rl78-tdep.c (rl78_unwind_sp): Delete.
10721 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10722
14faed38
AB		 107232019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10724
10725 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10726 (xstormy16_unwind_pc): Delete.
10727 (xstormy16_dummy_id): Delete.
10728 (xstormy16_gdbarch_init): Don't register deleted functions with
10729 gdbarch.
10730
541aad8a
AB		 107312019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10732
10733 * vax-tdep.c (vax_unwind_pc): Delete.
10734 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10735
29222070
AB		 107362019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10737
10738 * v850-tdep.c (v850_unwind_sp): Delete.
10739 (v850_unwind_pc): Delete.
10740 (v850_dummy_id): Delete.
10741 (v850_gdbarch_init): Don't register deleted functions with
10742 gdbarch.
10743
0f534d76
AB		 107442019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10745
10746 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10747 (tilegx_unwind_pc): Delete.
10748 (tilegx_unwind_dummy_id): Delete.
10749 (tilegx_gdbarch_init): Don't register deleted functions with
10750 gdbarch.
10751
1ba7b7f9
AB		 107522019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10753
10754 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10755 (tic6x_dummy_id): Delete.
10756 (tic6x_gdbarch_init): Don't register deleted functions with
10757 gdbarch.
10758
d31f262c
AB		 107592019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10760
10761 * sparc-tdep.c (sparc_unwind_pc): Delete.
10762 (sparc32_gdbarch_init): Don't register deleted function with
10763 gdbarch.
10764
6d14d64d
AB		 107652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10766
10767 * sh-tdep.c (sh_unwind_sp): Delete.
10768 (sh_unwind_pc): Delete.
10769 (sh_dummy_id): Delete.
10770 (sh_gdbarch_init): Don't register deleted functions with
10771 gdbarch.
10772
a40dde9d
AB		 107732019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10774
10775 * score-tdep.c (score_unwind_sp): Delete.
10776 (score_unwind_pc): Delete.
10777 (score_dummy_id): Delete.
10778 (score_gdbarch_init): Don't register deleted functions with
10779 gdbarch.
10780
47c47d69
AB		 107812019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10782
10783 * rx-tdep.c (rx_unwind_pc): Delete.
10784 (rx_unwind_sp): Delete.
10785 (rx_dummy_id): Delete.
10786 (rx_gdbarch_init): Don't register deleted functions with
10787 gdbarch. Update comment.
10788
833a4480
AB		 107892019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10790
10791 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10792 (rs6000_dummy_id): Delete.
10793 (rs6000_gdbarch_init): Don't register deleted functions with
10794 gdbarch.
10795
3f2cef49
AB		 107962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10797
10798 * or1k-tdep.c (or1k_dummy_id): Delete.
10799 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10800
96acf884
AB		 108012019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10802
10803 * nios2-tdep.c (nios2_dummy_id): Delete.
10804 (nios2_unwind_sp): Delete.
10805 (nios2_gdbarch_init): Don't register deleted functions with
10806 gdbarch.
10807
ca0ab0aa
AB		 108082019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10809
10810 * nds32-tdep.c (nds32_dummy_id): Delete.
10811 (nds32_unwind_pc): Delete.
10812 (nds32_unwind_sp): Delete.
10813 (nds32_gdbarch_init): Don't register deleted functions with
10814 gdbarch.
10815
c8259044
AB		 108162019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10817
10818 * msp430-tdep.c (msp430_unwind_pc): Delete.
10819 (msp430_unwind_sp): Delete.
10820 (msp430_dummy_id): Delete.
10821 (msp430_gdbarch_init): Don't register deleted functions with
10822 gdbarch.
10823
27f113c8
AB		 108242019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10825
10826 * moxie-tdep.c (moxie_unwind_sp): Delete.
10827 (moxie_unwind_pc): Delete.
10828 (moxie_dummy_id): Delete.
10829 (moxie_gdbarch_init): Don't register deleted functions with
10830 gdbarch.
10831
aee6c3cd
AB		 108322019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10833
10834 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10835 (mn10300_unwind_pc): Delete.
10836 (mn10300_unwind_sp): Delete.
10837 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10838 mn10300_unwind_sp.
10839 (mn10300_frame_unwind_init): Don't register deleted functions with
10840 gdbarch.
10841
8e2b5aea
AB		 108422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10843
10844 * mep-tdep.c (mep_unwind_pc): Delete.
10845 (mep_unwind_sp): Delete.
10846 (mep_dummy_id): Delete.
10847 (mep_gdbarch_init): Don't register deleted functions with
10848 gdbarch.
10849
43cf3ede
AB		 108502019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10851
10852 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10853 (m68hc11_unwind_sp): Delete.
10854 (m68hc11_gdbarch_init): Don't register deleted functions with
10855 gdbarch.
10856
5e79b7bb
AB		 108572019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10858
10859 * m32r-tdep.c (m32r_unwind_sp): Delete.
10860 (m32r_unwind_pc): Delete.
10861 (m32r_dummy_id): Delete.
10862 (m32r_gdbarch_init): Don't register deleted functions with
10863 gdbarch.
10864
89b268d8
AB		 108652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10866
10867 * m32c-tdep.c (m32c_unwind_pc): Delete.
10868 (m32c_unwind_sp): Delete.
10869 (m32c_dummy_id): Delete.
10870 (m32c_gdbarch_init): Don't register deleted functions with
10871 gdbarch.
10872
946c28d2
AB		 108732019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10874
10875 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10876 (lm32_unwind_pc): Delete.
10877 (lm32_dummy_id): Delete.
10878 (lm32_gdbarch_init): Don't register deleted functions with
10879 gdbarch.
10880
bf12844a
AB		 108812019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10882
10883 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10884 (iq2000_unwind_pc): Delete.
10885 (iq2000_dummy_id): Delete.
10886 (iq2000_gdbarch_init): Don't register deleted functions with
10887 gdbarch.
10888
ecbc06d2
AB		 108892019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10890
10891 * nds32-tdep.c (nds32_type_align): Delete.
10892 (nds32_push_dummy_call): Use type_align instead.
10893
030197b4
AB		 108942019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10895
10896 * arm-tdep.c (arm_type_align): Only handle vector override case.
10897 (arm_push_dummy_call): Use type_align.
10898 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10899
b907456c
AB		 109002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10901
10902 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10903 case.
10904 (pass_on_stack): Use type_align.
10905 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10906 function.
10907
9e97ba43
TT		 109082019-04-23 Tom Tromey <tromey@adacore.com>
10909
10910 * dwarf2read.c (line_header::file_name_at): Remove unused
10911 overload.
10912
6892f601
TV		 109132019-04-23 Tom de Vries <tdevries@suse.de>
10914
10915 PR gdb/24438
10916 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10917 invocation.
10918
336d760d
AT		 10919
109202019-03-27 Ali Tamur <tamur@google.com>
10921
10922 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10923 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10924 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10925 (dwarf_expr_context::get_addr_index): Likewise
10926 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10927 (symbol_needs_eval_context::get_addr_index): Likewise
10928 (disassemble_dwarf_expression): Add DW_OP_addrx
10929 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10930 (read_cutu_die_from_dwo): Update comment
10931 (skip_one_die): Add DW_FORM_addrx
10932 (read_attribute_value): Likewise
10933 (var_decode_location): Add DW_OP_addrx
10934 (dwarf2_const_value_attr): Add DW_FORM_addrx
10935 (dump_die_shallow): Likewise
10936 (dwarf2_fetch_constant_bytes): Likewise
10937 (decode_locdesc): Add DW_OP_addrx
10938 (skip_form_bytes): Add DW_FORM_addrx
10939
ad9d13f8
AT		 109402019-04-22 Ali Tamur <tamur@google.com>
10941
10942 * MAINTAINERS (Write After Approval): Add self.
10943
d70cc3ba
SM		 109442019-04-22 Simon Marchi <simon.marchi@efficios.com>
10945
10946 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10947 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10948 (open_symbol_file_object): Likewise.
10949 (svr4_default_sos): Add info parameter.
10950 (svr4_read_so_list): Likewise.
10951 (svr4_current_sos_direct): Adjust functions calls to pass down
10952 info.
10953 (svr4_current_sos_1): Add info parameter.
10954 (svr4_current_sos): Call get_svr4_info, pass info down to
10955 svr4_current_sos_1.
10956 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10957 get_svr4_info.
10958 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10959 get_svr4_info.
10960 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10961 to get_svr4_info.
10962 (probes_table_remove_objfile_probes): Likewise.
10963 (register_solib_event_probe): Add info parameter.
10964 (solist_update_incremental): Pass info parameter down to
10965 svr4_read_so_list.
10966 (disable_probes_interface): Add info parameter.
10967 (svr4_handle_solib_event): Pass current_program_space to
10968 get_svr4_info. Adjust disable_probes_interface cleanup.
10969 (svr4_create_probe_breakpoints): Add info parameter, pass it
10970 down to register_solib_event_probe.
10971 (svr4_create_solib_event_breakpoints): Add info parameter,
10972 pass it down to svr4_create_probe_breakpoints.
10973 (enable_break): Pass info down to
10974 svr4_create_solib_event_breakpoints.
10975 (svr4_solib_create_inferior_hook): Pass current_program_space to
10976 get_svr4_info.
10977 (svr4_clear_solib): Likewise.
10978
7905fc35
PA		 109792019-04-22 Pedro Alves <palves@redhat.com>
10980
10981 * solib-svr4.c (svr4_free_objfile_observer): New.
10982 (probe_and_action::objfile): New field.
10983 (probes_table_htab_remove_objfile_probes)
10984 (probes_table_remove_objfile_probes): New functions.
10985 (register_solib_event_probe): Add 'objfile' parameter. Store it
10986 in the new probe_and_action. Don't store the probe in 'lookup'.
10987 (svr4_create_probe_breakpoints): Pass objfile to
10988 register_solib_event_probe.
10989 (_initialize_svr4_solib): Register a free_objfile observer.
10990
fb881986
TT		 109912019-04-19 Tom Tromey <tom@tromey.com>
10992
10993 * common/queue.h: Remove.
10994
8732db6c
TT		 109952019-04-19 Tom Tromey <tom@tromey.com>
10996
10997 * event-loop.c: Don't include "common/queue.h".
10998
97dfbadd
TT		 109992019-04-19 Tom Tromey <tom@tromey.com>
11000
11001 * remote.c (remote_target): Use delete.
11002 * remote-notif.h: Include <list>, not "common/queue.h".
11003 (notif_client_p): Remove typedef.
11004 (remote_notif_state): Add constructor, destructor, initializer.
11005 <notif_queue>: Now a std::list.
11006 (remote_notif_state_xfree): Don't declare.
11007 * remote-notif.c (remote_notif_process, handle_notification)
11008 (remote_notif_state_allocate): Update.
11009 (~remote_notif_state): Rename from remote_notif_state_xfree.
11010
cf250e36
TT		 110112019-04-19 Tom Tromey <tom@tromey.com>
11012
11013 * symfile.c (reread_symbols): Update.
11014 * objfiles.c (objfile_register_static_link)
11015 (objfile_lookup_static_link): Update
11016 (~objfile) Don't delete static_links.
11017 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11018
61f4b350
TT		 110192019-04-19 Tom Tromey <tom@tromey.com>
11020
11021 * type-stack.h (struct type_stack) <insert>: Constify string.
11022 * type-stack.c (type_stack::insert): Constify string.
11023 * gdbtypes.h (lookup_template_type): Update.
11024 (address_space_name_to_int): Update.
11025 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11026 const.
11027 (lookup_template_type): Make name const.
11028 * c-exp.y: Update rules.
11029 (lex_one_token, classify_name, classify_inner_name)
11030 (c_print_token): Update.
11031 * p-exp.y: Update rules.
11032 (yylex): Update.
11033 * f-exp.y: Update rules.
11034 (yylex): Update.
11035 * d-exp.y: Update rules.
11036 (lex_one_token, classify_name, classify_inner_name): Update.
11037 * parse.c (write_dollar_variable, copy_name): Return std::string.
11038 * parser-defs.h (copy_name): Change return type.
11039 * m2-exp.y: Update rules.
11040 (yylex): Update.
11041 * go-exp.y (lex_one_token): Update.
11042 Update rules.
11043 (classify_unsafe_function, classify_packaged_name)
11044 (classify_name, yylex): Update.
11045
189b8c2e
ST		 110462019-04-19 Sergei Trofimovich <siarheit@google.com>
11047
11048 * configure.ac: add --enable-source-highlight switch.
11049 * configure: Regenerate.
11050 * top.c (print_gdb_version): plumb --enable-source-highlight
11051 status to "show configuration".
11052
8ecb59f8
TT		 110532019-04-19 Tom Tromey <tromey@adacore.com>
11054
11055 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11056 Check ADA_TYPE_P.
11057 (empty_record, ada_template_to_fixed_record_type_1)
11058 (template_to_static_fixed_type)
11059 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11060 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11061 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11062 macros.
11063
62160ec9
TT		 110642019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11065
11066 PR symtab/24423:
11067 * source.c (print_source_lines_base): Advance "iter" when a
11068 control character is seen.
11069
f2ae8bc8
PW		 110702019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11071
11072 * inferior.h (struct infcall_suspend_state_deleter):
11073 Catch exception in destructor to avoid crash.
11074
d563b953
PW		 110752019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11076
11077 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11078 close to the add_com "shell".
11079
dc34c897
TT		 110802019-04-18 Tom Tromey <tromey@adacore.com>
11081
11082 * process-stratum-target.h (class process_stratum_target)
11083 <stratum>: Add "final".
11084
a12e5744
TT		 110852019-04-17 Tom Tromey <tromey@adacore.com>
11086
11087 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11088 against nullptr before use.
11089
a7e559cc
AH		 110902019-04-17 Alan Hayward <alan.hayward@arm.com>
11091
11092 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11093
c01660c6
AB		 110942019-04-17 Jim Wilson <jimw@sifive.com>
11095 Andrew Burgess <andrew.burgess@embecosm.com>
11096
11097 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11098 code read might fail, assume 4-byte breakpoint in that case.
11099
4aa866af
LS		 111002019-04-15 Leszek Swirski <leszeks@google.com>
11101
11102 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11103 rather than a hand-rolled POD check when checking for forced MEMORY
11104 classification.
11105
48574d91
AH		 111062019-04-15 Alan Hayward <alan.hayward@arm.com>
11107
11108 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11109 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11110 function.
11111 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11112 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11113 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11114 declaration.
11115
4da037ef
AH		 111162019-04-15 Alan Hayward <alan.hayward@arm.com>
11117
11118 * aarch64-linux-nat.c
11119 (aarch64_linux_nat_target::thread_architecture): Add override.
11120 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11121 each VQ.
11122
ccb8d7e8
AH		 111232019-04-15 Alan Hayward <alan.hayward@arm.com>
11124
11125 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11126
35add35e
AB		 111272019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11128
11129 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11130 target types of size 96-bits, add some additional comments, and
11131 check that the builtin type we found was the correct size.
11132
51196bbc
EZ		 111332019-04-12 Eli Zaretskii <eliz@gnu.org>
11134
11135 * utils.c (prompt_for_continue): Don't restore the styling at the
11136 end, as applied_style has the wrong value. This fixes styling in
11137 long lists of file names that are interrupted by the "Continue?"
11138 prompt.
11139
62253a61
AB		 111402019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11141
11142 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11143 * c-lang.c (c_language_defn): Likewise.
11144 (cplus_language_defn): Likewise.
11145 (asm_language_defn): Likewise.
11146 (minimal_language_defn): Likewise.
11147 * d-lang.c (d_language_defn): Likewise.
11148 * f-lang.c (f_language_defn): Likewise.
11149 * go-lang.c (go_language_defn): Likewise.
11150 * language.c (unknown_language_defn): Likewise.
11151 (auto_language_defn): Likewise.
11152 * language.h (struct language_defn): Remove la_magic field.
11153 (LANG_MAGIC): Delete.
11154 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11155 * objc-lang.c (objc_language_defn): Likewise.
11156 * opencl-lang.c (opencl_language_defn): Likewise.
11157 * p-lang.c (pascal_language_defn): Likewise.
11158 * rust-lang.c (rust_language_defn): Likewise.
11159
a9158a86
AB		 111602019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11161
11162 * riscv-tdep.c (riscv_type_align): New function.
11163 (riscv_type_alignment): Delete.
11164 (riscv_arg_location): Use 'type_align'.
11165 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11166
41077b66
AB		 111672019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11168
11169 * gdbtypes.c (type_align): A struct with no non-static fields also
11170 has alignment of 1.
11171
9f0272f8
AB		 111722019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11173
11174 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11175 component to 0.
11176 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11177 member.
11178 (riscv_struct_info::analyse): New implementation using new
11179 analyse_inner member function.
11180 (riscv_struct_info::field_offset): New member function.
11181 (riscv_struct_info::m_offsets): New member variable.
11182 (riscv_struct_info::analyse_inner): New private member function,
11183 takes the old implementation of riscv_struct_info::analyse but
11184 extended to track field offsets.
11185 (riscv_call_arg_struct): Update the struct folding special cases
11186 to handle cases where empty C++ structs, which are non-zero
11187 length, are found.
11188 (riscv_arg_location): Initialise the length of each location, a
11189 non-zero length now indicates the location is in use.
11190 (riscv_push_dummy_call): Allow for the first location having a
11191 non-zero offset when setting up arguments.
11192 (riscv_return_value): Likewise, but for return values.
11193
02cf60c7
TT		 111942019-04-11 Tom Tromey <tromey@adacore.com>
11195
11196 * utils.c (internal_vproblem): Make "msg" const.
11197
68811f8f
AH		 111982019-04-11 Alan Hayward <alan.hayward@arm.com>
11199
11200 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11201 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11202 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11203 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11204
3f52fdbc
KB		 112052019-04-10 Kevin Buettner <kevinb@redhat.com>
11206
11207 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11208 function.
11209 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11210 of amd64_collect_native_gregset.
11211 (amd64_linux_nat_target::store_registers): Likewise.
11212
e9ad22ee
TT		 112132019-04-10 Tom Tromey <tom@tromey.com>
11214
11215 * symtab.c (lookup_global_symbol_from_objfile)
11216 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11217 * objfiles.h (class separate_debug_iterator): New.
11218 (class separate_debug_range): New.
11219 (struct objfile) <separate_debug_objfiles>: New method.
11220 (objfile_separate_debug_iterate): Don't declare.
11221 * objfiles.c (separate_debug_iterator::operator++): Rename from
11222 objfile_separate_debug_iterate.
11223 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11224 iterator.
11225 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11226 iterator.
11227
ee371134
TT		 112282019-04-10 Tom Tromey <tom@tromey.com>
11229
11230 * symfile.c (reread_symbols): Remove old comment.
11231 * objfiles.c (free_all_objfiles): Fix a typo.
11232
bf227d61
TT		 112332019-04-10 Tom Tromey <tom@tromey.com>
11234
11235 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11236 * minsyms.c (lookup_minimal_symbol): Use foreach.
11237 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11238 (lookup_minimal_symbol_solib_trampoline): Likewise.
11239 * symfile.c (reread_symbols): Use foreach.
11240
8dc433a0
TT		 112412019-04-09 Ivan Begert <ivanbegert@gmail.com>
11242 Tom Tromey <tromey@adacore.com>
11243
11244 PR rust/24414:
11245 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11246 (rust_lex_int_test): Change "value" to be LONGEST.
11247 (rust_lex_tests): Add test for long integer literal.
11248
9ab8741a
TT		 112492019-04-09 Tom Tromey <tromey@adacore.com>
11250
11251 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11252 to bool.
11253 (extended_remote_target::attach): Update.
11254 (remote_target::remote_notice_new_inferior): Update.
11255 (remote_target::add_current_inferior_and_thread): Update.
11256 * inferior.c (exit_inferior_1): Use "false".
11257 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11258
e242fd12
SM		 112592019-04-09 Simon Marchi <simon.marchi@efficios.com>
11260
9ca1957f 11261 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM		 11262 the "start" command.
11263
2b0c8b01
KB		 112642019-04-08 Kevin Buettner <kevinb@redhat.com>
11265
11266 * python/py-inferior.c (infpy_thread_from_thread_handle):
11267 Adjust comments to reflect renaming of thread_from_thread_handle
11268 to thread_from_handle. Adjust keywords. Fix type error message.
11269 (inferior_object_methods): Add thread_from_handle. Retain
11270 thread_from_thread_handle, but mark it as deprecated.
11271
50a82723
KB		 112722019-04-08 Kevin Buettner <kevinb@redhat.com>
11273
11274 * gdbthread.h (find_thread_by_handle): Revise declaration.
11275 * thread.c (find_thread_by_handle): Likewise. Adjust
11276 implementation too.
11277 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11278 support for buffer objects as handles.
11279
cf63b016
KB		 112802019-04-08 Kevin Buettner <kevinb@redhat.com>
11281
11282 * python/py-infthread.c (thpy_thread_handle): New function.
11283 (thread_object_methods): Register thpy_thread_handle.
11284
3d6c6204
KB		 112852019-04-08 Kevin Buettner <kevinb@redhat.com>
11286
11287 * gdbthread.h (thread_to_thread_handle): Declare.
11288 * thread.c (gdbtypes.h): Include.
11289 (thread_to_thread_handle): New function.
11290
11291 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11292 (target_thread_info_to_thread_handle): Declare.
11293 * target.c (target_thread_info_to_thread_handle): New function.
11294 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11295 * target-delegates.c: Regenerate.
11296
11297 * linux-thread-db.c (class thread_db_target): Add method
11298 thread_info_to_thread_handle.
11299 (thread_db_target::thread_info_to_thread_handle): Define.
11300 * remote.c (class remote_target): Add new method
11301 thread_info_to_thread_handle.
11302 (remote_target::thread_info_to_thread_handle): Define.
11303
56be6ea8
PA		 113042019-04-08 Pedro Alves <palves@redhat.com>
11305
11306 * common/common-exceptions.c (throw_exception): Don't create
11307 named object to throw; throw directly.
11308 (throw_it): Likewise. Don't initialize gdb_exception::message
11309 here, with new; pass FMT and AP to the ctor instead.
11310 * common/common-exceptions.h: Include <string>.
11311 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11312 const char *, va_list)): New ctor. Use std::make_shared.
11313 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11314 errors)): Delete.
11315 (gdb_exception_error::gdb_exception_error(enum errors, const char
11316 *, va_list)): New.
11317 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11318 Add assertion.
11319 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11320 errors)): Delete.
11321 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11322 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11323 Add assertion.
11324
eedc3f4f
TT		 113252019-04-08 Tom Tromey <tom@tromey.com>
11326
11327 * valops.c (value_rtti_indirect_type): Replace throw_exception
11328 with throw.
11329 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11330 with throw.
11331 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11332 throw.
11333 * target.c (target_translate_tls_address): Replace throw_exception
11334 with throw.
11335 * stack.c (frame_apply_command_count): Replace throw_exception
11336 with throw.
11337 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11338 throw.
11339 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11340 with throw.
11341 * rs6000-tdep.c (rs6000_frame_cache)
11342 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11343 * remote.c: Replace throw_exception with throw.
11344 * record-full.c (record_full_message, record_full_wait_1)
11345 (record_full_restore): Replace throw_exception with throw.
11346 * record-btrace.c:
11347 (get_thread_current_frame_id, record_btrace_start_replaying)
11348 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11349 (cmd_record_btrace_start): Replace throw_exception with throw.
11350 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11351 throw.
11352 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11353 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11354 * linespec.c:
11355 (find_linespec_symbols): Replace throw_exception with throw.
11356 * infrun.c (displaced_step_prepare, resume): Replace
11357 throw_exception with throw.
11358 * infcmd.c (post_create_inferior): Replace throw_exception with
11359 throw.
11360 * inf-loop.c (inferior_event_handler): Replace throw_exception
11361 with throw.
11362 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11363 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11364 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11365 (get_prev_frame_always, get_frame_pc_if_available)
11366 (get_frame_address_in_block_if_available, get_frame_language):
11367 Replace throw_exception with throw.
11368 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11369 throw_exception with throw.
11370 * eval.c (fetch_subexp_value, evaluate_var_value)
11371 (evaluate_funcall, evaluate_subexp_standard): Replace
11372 throw_exception with throw.
11373 * dwarf2loc.c (call_site_find_chain)
11374 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11375 Replace throw_exception with throw.
11376 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11377 with throw.
11378 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11379 throw.
11380 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11381 * completer.c (complete_line_internal): Replace throw_exception
11382 with throw.
11383 * compile/compile-object-run.c (compile_object_run): Replace
11384 throw_exception with throw.
11385 * cli/cli-script.c (process_next_line): Replace throw_exception
11386 with throw.
11387 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11388 (btrace_enable, btrace_maint_update_pt_packets): Replace
11389 throw_exception with throw.
11390 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11391 throw_exception with throw.
11392 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11393 throw_exception with throw.
11394 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11395 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11396 * aarch64-tdep.c (aarch64_make_prologue_cache)
11397 (aarch64_make_stub_cache): Replace throw_exception with throw.
11398
26003a20
TT		 113992019-04-08 Tom Tromey <tom@tromey.com>
11400
11401 * common/common-exceptions.c (throw_exception): Rename from
11402 throw_exception_cxx. Remove old copy. Make argument const.
11403 (throw_it): Create and throw exception objects directly.
11404 * common/common-exceptions.h (throw_exception): Make argument
11405 const.
11406 (struct gdb_exception_error): Add constructor.
11407 (struct gdb_exception_quit): Add constructor.
11408
d272eb37
TT		 114092019-04-08 Tom Tromey <tom@tromey.com>
11410
11411 * common/common-exceptions.h (exception_rethrow): Don't declare.
11412 (TRY_SJLJ): Update comment.
11413 (TRY, CATCH, END_CATCH): Remove.
11414 * common/common-exceptions.c (exception_rethrow): Remove.
11415
230d2906
TT		 114162019-04-08 Tom Tromey <tom@tromey.com>
11417
11418 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11419 Remove.
11420 (gdb_exception_error): Rename from
11421 gdb_exception_RETURN_MASK_ERROR.
11422 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11423 (gdb_quit_bad_alloc): Update.
11424 * aarch64-tdep.c: Update.
11425 * ada-lang.c: Update.
11426 * ada-typeprint.c: Update.
11427 * ada-valprint.c: Update.
11428 * amd64-tdep.c: Update.
11429 * arch-utils.c: Update.
11430 * break-catch-throw.c: Update.
11431 * breakpoint.c: Update.
11432 * btrace.c: Update.
11433 * c-varobj.c: Update.
11434 * cli/cli-cmds.c: Update.
11435 * cli/cli-interp.c: Update.
11436 * cli/cli-script.c: Update.
11437 * common/common-exceptions.c: Update.
11438 * common/new-op.c: Update.
11439 * common/selftest.c: Update.
11440 * compile/compile-c-symbols.c: Update.
11441 * compile/compile-cplus-symbols.c: Update.
11442 * compile/compile-object-load.c: Update.
11443 * compile/compile-object-run.c: Update.
11444 * completer.c: Update.
11445 * corelow.c: Update.
11446 * cp-abi.c: Update.
11447 * cp-support.c: Update.
11448 * cp-valprint.c: Update.
11449 * darwin-nat.c: Update.
11450 * disasm-selftests.c: Update.
11451 * dtrace-probe.c: Update.
11452 * dwarf-index-cache.c: Update.
11453 * dwarf-index-write.c: Update.
11454 * dwarf2-frame-tailcall.c: Update.
11455 * dwarf2-frame.c: Update.
11456 * dwarf2loc.c: Update.
11457 * dwarf2read.c: Update.
11458 * eval.c: Update.
11459 * event-loop.c: Update.
11460 * event-top.c: Update.
11461 * exec.c: Update.
11462 * f-valprint.c: Update.
11463 * fbsd-tdep.c: Update.
11464 * frame-unwind.c: Update.
11465 * frame.c: Update.
11466 * gdbtypes.c: Update.
11467 * gnu-v3-abi.c: Update.
11468 * guile/guile-internal.h: Update.
11469 * guile/scm-block.c: Update.
11470 * guile/scm-breakpoint.c: Update.
11471 * guile/scm-cmd.c: Update.
11472 * guile/scm-disasm.c: Update.
11473 * guile/scm-frame.c: Update.
11474 * guile/scm-lazy-string.c: Update.
11475 * guile/scm-math.c: Update.
11476 * guile/scm-param.c: Update.
11477 * guile/scm-ports.c: Update.
11478 * guile/scm-pretty-print.c: Update.
11479 * guile/scm-symbol.c: Update.
11480 * guile/scm-symtab.c: Update.
11481 * guile/scm-type.c: Update.
11482 * guile/scm-value.c: Update.
11483 * i386-linux-tdep.c: Update.
11484 * i386-tdep.c: Update.
11485 * inf-loop.c: Update.
11486 * infcall.c: Update.
11487 * infcmd.c: Update.
11488 * infrun.c: Update.
11489 * jit.c: Update.
11490 * language.c: Update.
11491 * linespec.c: Update.
11492 * linux-fork.c: Update.
11493 * linux-nat.c: Update.
11494 * linux-tdep.c: Update.
11495 * linux-thread-db.c: Update.
11496 * main.c: Update.
11497 * mi/mi-cmd-break.c: Update.
11498 * mi/mi-cmd-stack.c: Update.
11499 * mi/mi-interp.c: Update.
11500 * mi/mi-main.c: Update.
11501 * objc-lang.c: Update.
11502 * p-valprint.c: Update.
11503 * parse.c: Update.
11504 * ppc-linux-tdep.c: Update.
11505 * printcmd.c: Update.
11506 * python/py-arch.c: Update.
11507 * python/py-breakpoint.c: Update.
11508 * python/py-cmd.c: Update.
11509 * python/py-finishbreakpoint.c: Update.
11510 * python/py-frame.c: Update.
11511 * python/py-framefilter.c: Update.
11512 * python/py-gdb-readline.c: Update.
11513 * python/py-inferior.c: Update.
11514 * python/py-infthread.c: Update.
11515 * python/py-lazy-string.c: Update.
11516 * python/py-linetable.c: Update.
11517 * python/py-objfile.c: Update.
11518 * python/py-param.c: Update.
11519 * python/py-prettyprint.c: Update.
11520 * python/py-progspace.c: Update.
11521 * python/py-record-btrace.c: Update.
11522 * python/py-record.c: Update.
11523 * python/py-symbol.c: Update.
11524 * python/py-type.c: Update.
11525 * python/py-unwind.c: Update.
11526 * python/py-utils.c: Update.
11527 * python/py-value.c: Update.
11528 * python/python.c: Update.
11529 * record-btrace.c: Update.
11530 * record-full.c: Update.
11531 * remote-fileio.c: Update.
11532 * remote.c: Update.
11533 * riscv-tdep.c: Update.
11534 * rs6000-aix-tdep.c: Update.
11535 * rs6000-tdep.c: Update.
11536 * rust-exp.y: Update.
11537 * rust-lang.c: Update.
11538 * s390-tdep.c: Update.
11539 * selftest-arch.c: Update.
11540 * solib-dsbt.c: Update.
11541 * solib-frv.c: Update.
11542 * solib-spu.c: Update.
11543 * solib-svr4.c: Update.
11544 * solib.c: Update.
11545 * sparc64-linux-tdep.c: Update.
11546 * stack.c: Update.
11547 * symfile-mem.c: Update.
11548 * symmisc.c: Update.
11549 * target.c: Update.
11550 * thread.c: Update.
11551 * top.c: Update.
11552 * tracefile-tfile.c: Update.
11553 * tui/tui.c: Update.
11554 * typeprint.c: Update.
11555 * unittests/cli-utils-selftests.c: Update.
11556 * unittests/parse-connection-spec-selftests.c: Update.
11557 * valops.c: Update.
11558 * valprint.c: Update.
11559 * value.c: Update.
11560 * varobj.c: Update.
11561 * windows-nat.c: Update.
11562 * x86-linux-nat.c: Update.
11563 * xml-support.c: Update.
11564
a70b8144
TT		 115652019-04-08 Tom Tromey <tom@tromey.com>
11566
11567 * xml-support.c: Use C++ exception handling.
11568 * x86-linux-nat.c: Use C++ exception handling.
11569 * windows-nat.c: Use C++ exception handling.
11570 * varobj.c: Use C++ exception handling.
11571 * value.c: Use C++ exception handling.
11572 * valprint.c: Use C++ exception handling.
11573 * valops.c: Use C++ exception handling.
11574 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11575 handling.
11576 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11577 * typeprint.c: Use C++ exception handling.
11578 * tui/tui.c: Use C++ exception handling.
11579 * tracefile-tfile.c: Use C++ exception handling.
11580 * top.c: Use C++ exception handling.
11581 * thread.c: Use C++ exception handling.
11582 * target.c: Use C++ exception handling.
11583 * symmisc.c: Use C++ exception handling.
11584 * symfile-mem.c: Use C++ exception handling.
11585 * stack.c: Use C++ exception handling.
11586 * sparc64-linux-tdep.c: Use C++ exception handling.
11587 * solib.c: Use C++ exception handling.
11588 * solib-svr4.c: Use C++ exception handling.
11589 * solib-spu.c: Use C++ exception handling.
11590 * solib-frv.c: Use C++ exception handling.
11591 * solib-dsbt.c: Use C++ exception handling.
11592 * selftest-arch.c: Use C++ exception handling.
11593 * s390-tdep.c: Use C++ exception handling.
11594 * rust-lang.c: Use C++ exception handling.
11595 * rust-exp.y: Use C++ exception handling.
11596 * rs6000-tdep.c: Use C++ exception handling.
11597 * rs6000-aix-tdep.c: Use C++ exception handling.
11598 * riscv-tdep.c: Use C++ exception handling.
11599 * remote.c: Use C++ exception handling.
11600 * remote-fileio.c: Use C++ exception handling.
11601 * record-full.c: Use C++ exception handling.
11602 * record-btrace.c: Use C++ exception handling.
11603 * python/python.c: Use C++ exception handling.
11604 * python/py-value.c: Use C++ exception handling.
11605 * python/py-utils.c: Use C++ exception handling.
11606 * python/py-unwind.c: Use C++ exception handling.
11607 * python/py-type.c: Use C++ exception handling.
11608 * python/py-symbol.c: Use C++ exception handling.
11609 * python/py-record.c: Use C++ exception handling.
11610 * python/py-record-btrace.c: Use C++ exception handling.
11611 * python/py-progspace.c: Use C++ exception handling.
11612 * python/py-prettyprint.c: Use C++ exception handling.
11613 * python/py-param.c: Use C++ exception handling.
11614 * python/py-objfile.c: Use C++ exception handling.
11615 * python/py-linetable.c: Use C++ exception handling.
11616 * python/py-lazy-string.c: Use C++ exception handling.
11617 * python/py-infthread.c: Use C++ exception handling.
11618 * python/py-inferior.c: Use C++ exception handling.
11619 * python/py-gdb-readline.c: Use C++ exception handling.
11620 * python/py-framefilter.c: Use C++ exception handling.
11621 * python/py-frame.c: Use C++ exception handling.
11622 * python/py-finishbreakpoint.c: Use C++ exception handling.
11623 * python/py-cmd.c: Use C++ exception handling.
11624 * python/py-breakpoint.c: Use C++ exception handling.
11625 * python/py-arch.c: Use C++ exception handling.
11626 * printcmd.c: Use C++ exception handling.
11627 * ppc-linux-tdep.c: Use C++ exception handling.
11628 * parse.c: Use C++ exception handling.
11629 * p-valprint.c: Use C++ exception handling.
11630 * objc-lang.c: Use C++ exception handling.
11631 * mi/mi-main.c: Use C++ exception handling.
11632 * mi/mi-interp.c: Use C++ exception handling.
11633 * mi/mi-cmd-stack.c: Use C++ exception handling.
11634 * mi/mi-cmd-break.c: Use C++ exception handling.
11635 * main.c: Use C++ exception handling.
11636 * linux-thread-db.c: Use C++ exception handling.
11637 * linux-tdep.c: Use C++ exception handling.
11638 * linux-nat.c: Use C++ exception handling.
11639 * linux-fork.c: Use C++ exception handling.
11640 * linespec.c: Use C++ exception handling.
11641 * language.c: Use C++ exception handling.
11642 * jit.c: Use C++ exception handling.
11643 * infrun.c: Use C++ exception handling.
11644 * infcmd.c: Use C++ exception handling.
11645 * infcall.c: Use C++ exception handling.
11646 * inf-loop.c: Use C++ exception handling.
11647 * i386-tdep.c: Use C++ exception handling.
11648 * i386-linux-tdep.c: Use C++ exception handling.
11649 * guile/scm-value.c: Use C++ exception handling.
11650 * guile/scm-type.c: Use C++ exception handling.
11651 * guile/scm-symtab.c: Use C++ exception handling.
11652 * guile/scm-symbol.c: Use C++ exception handling.
11653 * guile/scm-pretty-print.c: Use C++ exception handling.
11654 * guile/scm-ports.c: Use C++ exception handling.
11655 * guile/scm-param.c: Use C++ exception handling.
11656 * guile/scm-math.c: Use C++ exception handling.
11657 * guile/scm-lazy-string.c: Use C++ exception handling.
11658 * guile/scm-frame.c: Use C++ exception handling.
11659 * guile/scm-disasm.c: Use C++ exception handling.
11660 * guile/scm-cmd.c: Use C++ exception handling.
11661 * guile/scm-breakpoint.c: Use C++ exception handling.
11662 * guile/scm-block.c: Use C++ exception handling.
11663 * guile/guile-internal.h: Use C++ exception handling.
11664 * gnu-v3-abi.c: Use C++ exception handling.
11665 * gdbtypes.c: Use C++ exception handling.
11666 * frame.c: Use C++ exception handling.
11667 * frame-unwind.c: Use C++ exception handling.
11668 * fbsd-tdep.c: Use C++ exception handling.
11669 * f-valprint.c: Use C++ exception handling.
11670 * exec.c: Use C++ exception handling.
11671 * event-top.c: Use C++ exception handling.
11672 * event-loop.c: Use C++ exception handling.
11673 * eval.c: Use C++ exception handling.
11674 * dwarf2read.c: Use C++ exception handling.
11675 * dwarf2loc.c: Use C++ exception handling.
11676 * dwarf2-frame.c: Use C++ exception handling.
11677 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11678 * dwarf-index-write.c: Use C++ exception handling.
11679 * dwarf-index-cache.c: Use C++ exception handling.
11680 * dtrace-probe.c: Use C++ exception handling.
11681 * disasm-selftests.c: Use C++ exception handling.
11682 * darwin-nat.c: Use C++ exception handling.
11683 * cp-valprint.c: Use C++ exception handling.
11684 * cp-support.c: Use C++ exception handling.
11685 * cp-abi.c: Use C++ exception handling.
11686 * corelow.c: Use C++ exception handling.
11687 * completer.c: Use C++ exception handling.
11688 * compile/compile-object-run.c: Use C++ exception handling.
11689 * compile/compile-object-load.c: Use C++ exception handling.
11690 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11691 * compile/compile-c-symbols.c: Use C++ exception handling.
11692 * common/selftest.c: Use C++ exception handling.
11693 * common/new-op.c: Use C++ exception handling.
11694 * cli/cli-script.c: Use C++ exception handling.
11695 * cli/cli-interp.c: Use C++ exception handling.
11696 * cli/cli-cmds.c: Use C++ exception handling.
11697 * c-varobj.c: Use C++ exception handling.
11698 * btrace.c: Use C++ exception handling.
11699 * breakpoint.c: Use C++ exception handling.
11700 * break-catch-throw.c: Use C++ exception handling.
11701 * arch-utils.c: Use C++ exception handling.
11702 * amd64-tdep.c: Use C++ exception handling.
11703 * ada-valprint.c: Use C++ exception handling.
11704 * ada-typeprint.c: Use C++ exception handling.
11705 * ada-lang.c: Use C++ exception handling.
11706 * aarch64-tdep.c: Use C++ exception handling.
11707
3d6e9d23
TT		 117082019-04-08 Tom Tromey <tom@tromey.com>
11709
11710 * xml-support.c (gdb_xml_parser::parse): Update.
11711 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11712 * value.c (show_convenience): Update.
11713 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11714 (test_parse_flags_qcs): Update.
11715 * thread.c (thr_try_catch_cmd): Update.
11716 * target.c (target_translate_tls_address): Update.
11717 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11718 (info_frame_command_core, frame_apply_command_count): Update.
11719 * rust-exp.y (rust_lex_exception_test): Update.
11720 * riscv-tdep.c (riscv_print_one_register_info): Update.
11721 * remote.c (remote_target::enable_btrace): Update.
11722 * record-btrace.c (record_btrace_enable_warn): Update.
11723 * python/py-utils.c (gdbpy_convert_exception): Update.
11724 * printcmd.c (do_one_display, print_variable_and_value): Update.
11725 * mi/mi-main.c (mi_print_exception): Update.
11726 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11727 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11728 * linux-nat.c (linux_nat_target::attach): Update.
11729 * linux-fork.c (class scoped_switch_fork_info): Update.
11730 * infrun.c (displaced_step_prepare): Update.
11731 * infcall.c (call_function_by_hand_dummy): Update.
11732 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11733 * gnu-v3-abi.c (print_one_vtable): Update.
11734 * frame.c (get_prev_frame_always): Update.
11735 * f-valprint.c (info_common_command_for_block): Update.
11736 * exec.c (try_open_exec_file): Update.
11737 * exceptions.c (print_exception, exception_print)
11738 (exception_fprintf, exception_print_same): Update.
11739 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11740 * dwarf-index-cache.c (index_cache::store)
11741 (index_cache::lookup_gdb_index): Update.
11742 * darwin-nat.c (maybe_cache_shell): Update.
11743 * cp-valprint.c (cp_print_value_fields): Update.
11744 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11745 (gcc_cplus_symbol_address): Update.
11746 * compile/compile-c-symbols.c (gcc_convert_symbol)
11747 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11748 * common/selftest.c: Update.
11749 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11750 a std::string.
11751 (exception_try_scope_entry, exception_try_scope_exit): Don't
11752 declare.
11753 (struct exception_try_scope): Remove.
11754 (TRY): Don't use exception_try_scope.
11755 (struct gdb_exception): Add constructor, operator=.
11756 <what>: New method.
11757 (struct gdb_exception_RETURN_MASK_ALL)
11758 (struct gdb_exception_RETURN_MASK_ERROR)
11759 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11760 (struct gdb_quit_bad_alloc): Update.
11761 * common/common-exceptions.c (exception_none): Change
11762 initializer.
11763 (struct catcher) <state, exception>: Initialize inline.
11764 <prev>: Remove member.
11765 (current_catcher): Remove.
11766 (catchers): New global.
11767 (exceptions_state_mc_init): Simplify.
11768 (catcher_pop): Remove.
11769 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11770 (try_scope_depth, exception_try_scope_entry)
11771 (exception_try_scope_exit): Remove.
11772 (throw_exception_sjlj): Update.
11773 (exception_messages, exception_messages_size): Remove.
11774 (throw_it): Simplify.
11775 (gdb_exception_sliced_copy): Remove.
11776 (throw_exception_cxx): Update.
11777 * cli/cli-script.c (script_from_file): Update.
11778 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11779 Update.
11780 * ada-valprint.c (ada_val_print): Update.
11781 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11782 (create_excep_cond_exprs): Update.
11783
c5c10118
TT		 117842019-04-08 Tom Tromey <tom@tromey.com>
11785
11786 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11787 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11788 (TRY, CATCH, END_CATCH): Remove some definitions.
11789 * common/common-exceptions.c: Don't use GDB_XCPT.
11790 (catcher_list_size): Remove.
11791 (throw_exception, throw_it): Simplify.
11792
4de283e4
TT		 117932019-04-05 Tom Tromey <tom@tromey.com>
11794
11795 Revert the header-sorting patch.
11796 * ft32-tdep.c: Revert.
11797 * frv-tdep.c: Revert.
11798 * frv-linux-tdep.c: Revert.
11799 * frame.c: Revert.
11800 * frame-unwind.c: Revert.
11801 * frame-base.c: Revert.
11802 * fork-child.c: Revert.
11803 * findvar.c: Revert.
11804 * findcmd.c: Revert.
11805 * filesystem.c: Revert.
11806 * filename-seen-cache.h: Revert.
11807 * filename-seen-cache.c: Revert.
11808 * fbsd-tdep.c: Revert.
11809 * fbsd-nat.h: Revert.
11810 * fbsd-nat.c: Revert.
11811 * f-valprint.c: Revert.
11812 * f-typeprint.c: Revert.
11813 * f-lang.c: Revert.
11814 * extension.h: Revert.
11815 * extension.c: Revert.
11816 * extension-priv.h: Revert.
11817 * expprint.c: Revert.
11818 * exec.h: Revert.
11819 * exec.c: Revert.
11820 * exceptions.c: Revert.
11821 * event-top.c: Revert.
11822 * event-loop.c: Revert.
11823 * eval.c: Revert.
11824 * elfread.c: Revert.
11825 * dwarf2read.h: Revert.
11826 * dwarf2read.c: Revert.
11827 * dwarf2loc.c: Revert.
11828 * dwarf2expr.h: Revert.
11829 * dwarf2expr.c: Revert.
11830 * dwarf2-frame.c: Revert.
11831 * dwarf2-frame-tailcall.c: Revert.
11832 * dwarf-index-write.h: Revert.
11833 * dwarf-index-write.c: Revert.
11834 * dwarf-index-common.c: Revert.
11835 * dwarf-index-cache.h: Revert.
11836 * dwarf-index-cache.c: Revert.
11837 * dummy-frame.c: Revert.
11838 * dtrace-probe.c: Revert.
11839 * disasm.h: Revert.
11840 * disasm.c: Revert.
11841 * disasm-selftests.c: Revert.
11842 * dictionary.c: Revert.
11843 * dicos-tdep.c: Revert.
11844 * demangle.c: Revert.
11845 * dcache.h: Revert.
11846 * dcache.c: Revert.
11847 * darwin-nat.h: Revert.
11848 * darwin-nat.c: Revert.
11849 * darwin-nat-info.c: Revert.
11850 * d-valprint.c: Revert.
11851 * d-namespace.c: Revert.
11852 * d-lang.c: Revert.
11853 * ctf.c: Revert.
11854 * csky-tdep.c: Revert.
11855 * csky-linux-tdep.c: Revert.
11856 * cris-tdep.c: Revert.
11857 * cris-linux-tdep.c: Revert.
11858 * cp-valprint.c: Revert.
11859 * cp-support.c: Revert.
11860 * cp-namespace.c: Revert.
11861 * cp-abi.c: Revert.
11862 * corelow.c: Revert.
11863 * corefile.c: Revert.
11864 * continuations.c: Revert.
11865 * completer.h: Revert.
11866 * completer.c: Revert.
11867 * complaints.c: Revert.
11868 * coffread.c: Revert.
11869 * coff-pe-read.c: Revert.
11870 * cli-out.h: Revert.
11871 * cli-out.c: Revert.
11872 * charset.c: Revert.
11873 * c-varobj.c: Revert.
11874 * c-valprint.c: Revert.
11875 * c-typeprint.c: Revert.
11876 * c-lang.c: Revert.
11877 * buildsym.c: Revert.
11878 * buildsym-legacy.c: Revert.
11879 * build-id.h: Revert.
11880 * build-id.c: Revert.
11881 * btrace.c: Revert.
11882 * bsd-uthread.c: Revert.
11883 * breakpoint.h: Revert.
11884 * breakpoint.c: Revert.
11885 * break-catch-throw.c: Revert.
11886 * break-catch-syscall.c: Revert.
11887 * break-catch-sig.c: Revert.
11888 * blockframe.c: Revert.
11889 * block.c: Revert.
11890 * bfin-tdep.c: Revert.
11891 * bfin-linux-tdep.c: Revert.
11892 * bfd-target.c: Revert.
11893 * bcache.c: Revert.
11894 * ax-general.c: Revert.
11895 * ax-gdb.h: Revert.
11896 * ax-gdb.c: Revert.
11897 * avr-tdep.c: Revert.
11898 * auxv.c: Revert.
11899 * auto-load.c: Revert.
11900 * arm-wince-tdep.c: Revert.
11901 * arm-tdep.c: Revert.
11902 * arm-symbian-tdep.c: Revert.
11903 * arm-pikeos-tdep.c: Revert.
11904 * arm-obsd-tdep.c: Revert.
11905 * arm-nbsd-tdep.c: Revert.
11906 * arm-nbsd-nat.c: Revert.
11907 * arm-linux-tdep.c: Revert.
11908 * arm-linux-nat.c: Revert.
11909 * arm-fbsd-tdep.c: Revert.
11910 * arm-fbsd-nat.c: Revert.
11911 * arm-bsd-tdep.c: Revert.
11912 * arch-utils.c: Revert.
11913 * arc-tdep.c: Revert.
11914 * arc-newlib-tdep.c: Revert.
11915 * annotate.h: Revert.
11916 * annotate.c: Revert.
11917 * amd64-windows-tdep.c: Revert.
11918 * amd64-windows-nat.c: Revert.
11919 * amd64-tdep.c: Revert.
11920 * amd64-sol2-tdep.c: Revert.
11921 * amd64-obsd-tdep.c: Revert.
11922 * amd64-obsd-nat.c: Revert.
11923 * amd64-nbsd-tdep.c: Revert.
11924 * amd64-nbsd-nat.c: Revert.
11925 * amd64-nat.c: Revert.
11926 * amd64-linux-tdep.c: Revert.
11927 * amd64-linux-nat.c: Revert.
11928 * amd64-fbsd-tdep.c: Revert.
11929 * amd64-fbsd-nat.c: Revert.
11930 * amd64-dicos-tdep.c: Revert.
11931 * amd64-darwin-tdep.c: Revert.
11932 * amd64-bsd-nat.c: Revert.
11933 * alpha-tdep.c: Revert.
11934 * alpha-obsd-tdep.c: Revert.
11935 * alpha-nbsd-tdep.c: Revert.
11936 * alpha-mdebug-tdep.c: Revert.
11937 * alpha-linux-tdep.c: Revert.
11938 * alpha-linux-nat.c: Revert.
11939 * alpha-bsd-tdep.c: Revert.
11940 * alpha-bsd-nat.c: Revert.
11941 * aix-thread.c: Revert.
11942 * agent.c: Revert.
11943 * addrmap.c: Revert.
11944 * ada-varobj.c: Revert.
11945 * ada-valprint.c: Revert.
11946 * ada-typeprint.c: Revert.
11947 * ada-tasks.c: Revert.
11948 * ada-lang.c: Revert.
11949 * aarch64-tdep.c: Revert.
11950 * aarch64-ravenscar-thread.c: Revert.
11951 * aarch64-newlib-tdep.c: Revert.
11952 * aarch64-linux-tdep.c: Revert.
11953 * aarch64-linux-nat.c: Revert.
11954 * aarch64-fbsd-tdep.c: Revert.
11955 * aarch64-fbsd-nat.c: Revert.
11956 * aarch32-linux-nat.c: Revert.
11957
d55e5aa6
TT		 119582019-04-05 Tom Tromey <tom@tromey.com>
11959
11960 * ft32-tdep.c: Sort headers.
11961 * frv-tdep.c: Sort headers.
11962 * frv-linux-tdep.c: Sort headers.
11963 * frame.c: Sort headers.
11964 * frame-unwind.c: Sort headers.
11965 * frame-base.c: Sort headers.
11966 * fork-child.c: Sort headers.
11967 * findvar.c: Sort headers.
11968 * findcmd.c: Sort headers.
11969 * filesystem.c: Sort headers.
11970 * filename-seen-cache.h: Sort headers.
11971 * filename-seen-cache.c: Sort headers.
11972 * fbsd-tdep.c: Sort headers.
11973 * fbsd-nat.h: Sort headers.
11974 * fbsd-nat.c: Sort headers.
11975 * f-valprint.c: Sort headers.
11976 * f-typeprint.c: Sort headers.
11977 * f-lang.c: Sort headers.
11978 * extension.h: Sort headers.
11979 * extension.c: Sort headers.
11980 * extension-priv.h: Sort headers.
11981 * expprint.c: Sort headers.
11982 * exec.h: Sort headers.
11983 * exec.c: Sort headers.
11984 * exceptions.c: Sort headers.
11985 * event-top.c: Sort headers.
11986 * event-loop.c: Sort headers.
11987 * eval.c: Sort headers.
11988 * elfread.c: Sort headers.
11989 * dwarf2read.h: Sort headers.
11990 * dwarf2read.c: Sort headers.
11991 * dwarf2loc.c: Sort headers.
11992 * dwarf2expr.h: Sort headers.
11993 * dwarf2expr.c: Sort headers.
11994 * dwarf2-frame.c: Sort headers.
11995 * dwarf2-frame-tailcall.c: Sort headers.
11996 * dwarf-index-write.h: Sort headers.
11997 * dwarf-index-write.c: Sort headers.
11998 * dwarf-index-common.c: Sort headers.
11999 * dwarf-index-cache.h: Sort headers.
12000 * dwarf-index-cache.c: Sort headers.
12001 * dummy-frame.c: Sort headers.
12002 * dtrace-probe.c: Sort headers.
12003 * disasm.h: Sort headers.
12004 * disasm.c: Sort headers.
12005 * disasm-selftests.c: Sort headers.
12006 * dictionary.c: Sort headers.
12007 * dicos-tdep.c: Sort headers.
12008 * demangle.c: Sort headers.
12009 * dcache.h: Sort headers.
12010 * dcache.c: Sort headers.
12011 * darwin-nat.h: Sort headers.
12012 * darwin-nat.c: Sort headers.
12013 * darwin-nat-info.c: Sort headers.
12014 * d-valprint.c: Sort headers.
12015 * d-namespace.c: Sort headers.
12016 * d-lang.c: Sort headers.
12017 * ctf.c: Sort headers.
12018 * csky-tdep.c: Sort headers.
12019 * csky-linux-tdep.c: Sort headers.
12020 * cris-tdep.c: Sort headers.
12021 * cris-linux-tdep.c: Sort headers.
12022 * cp-valprint.c: Sort headers.
12023 * cp-support.c: Sort headers.
12024 * cp-namespace.c: Sort headers.
12025 * cp-abi.c: Sort headers.
12026 * corelow.c: Sort headers.
12027 * corefile.c: Sort headers.
12028 * continuations.c: Sort headers.
12029 * completer.h: Sort headers.
12030 * completer.c: Sort headers.
12031 * complaints.c: Sort headers.
12032 * coffread.c: Sort headers.
12033 * coff-pe-read.c: Sort headers.
12034 * cli-out.h: Sort headers.
12035 * cli-out.c: Sort headers.
12036 * charset.c: Sort headers.
12037 * c-varobj.c: Sort headers.
12038 * c-valprint.c: Sort headers.
12039 * c-typeprint.c: Sort headers.
12040 * c-lang.c: Sort headers.
12041 * buildsym.c: Sort headers.
12042 * buildsym-legacy.c: Sort headers.
12043 * build-id.h: Sort headers.
12044 * build-id.c: Sort headers.
12045 * btrace.c: Sort headers.
12046 * bsd-uthread.c: Sort headers.
12047 * breakpoint.h: Sort headers.
12048 * breakpoint.c: Sort headers.
12049 * break-catch-throw.c: Sort headers.
12050 * break-catch-syscall.c: Sort headers.
12051 * break-catch-sig.c: Sort headers.
12052 * blockframe.c: Sort headers.
12053 * block.c: Sort headers.
12054 * bfin-tdep.c: Sort headers.
12055 * bfin-linux-tdep.c: Sort headers.
12056 * bfd-target.c: Sort headers.
12057 * bcache.c: Sort headers.
12058 * ax-general.c: Sort headers.
12059 * ax-gdb.h: Sort headers.
12060 * ax-gdb.c: Sort headers.
12061 * avr-tdep.c: Sort headers.
12062 * auxv.c: Sort headers.
12063 * auto-load.c: Sort headers.
12064 * arm-wince-tdep.c: Sort headers.
12065 * arm-tdep.c: Sort headers.
12066 * arm-symbian-tdep.c: Sort headers.
12067 * arm-pikeos-tdep.c: Sort headers.
12068 * arm-obsd-tdep.c: Sort headers.
12069 * arm-nbsd-tdep.c: Sort headers.
12070 * arm-nbsd-nat.c: Sort headers.
12071 * arm-linux-tdep.c: Sort headers.
12072 * arm-linux-nat.c: Sort headers.
12073 * arm-fbsd-tdep.c: Sort headers.
12074 * arm-fbsd-nat.c: Sort headers.
12075 * arm-bsd-tdep.c: Sort headers.
12076 * arch-utils.c: Sort headers.
12077 * arc-tdep.c: Sort headers.
12078 * arc-newlib-tdep.c: Sort headers.
12079 * annotate.h: Sort headers.
12080 * annotate.c: Sort headers.
12081 * amd64-windows-tdep.c: Sort headers.
12082 * amd64-windows-nat.c: Sort headers.
12083 * amd64-tdep.c: Sort headers.
12084 * amd64-sol2-tdep.c: Sort headers.
12085 * amd64-obsd-tdep.c: Sort headers.
12086 * amd64-obsd-nat.c: Sort headers.
12087 * amd64-nbsd-tdep.c: Sort headers.
12088 * amd64-nbsd-nat.c: Sort headers.
12089 * amd64-nat.c: Sort headers.
12090 * amd64-linux-tdep.c: Sort headers.
12091 * amd64-linux-nat.c: Sort headers.
12092 * amd64-fbsd-tdep.c: Sort headers.
12093 * amd64-fbsd-nat.c: Sort headers.
12094 * amd64-dicos-tdep.c: Sort headers.
12095 * amd64-darwin-tdep.c: Sort headers.
12096 * amd64-bsd-nat.c: Sort headers.
12097 * alpha-tdep.c: Sort headers.
12098 * alpha-obsd-tdep.c: Sort headers.
12099 * alpha-nbsd-tdep.c: Sort headers.
12100 * alpha-mdebug-tdep.c: Sort headers.
12101 * alpha-linux-tdep.c: Sort headers.
12102 * alpha-linux-nat.c: Sort headers.
12103 * alpha-bsd-tdep.c: Sort headers.
12104 * alpha-bsd-nat.c: Sort headers.
12105 * aix-thread.c: Sort headers.
12106 * agent.c: Sort headers.
12107 * addrmap.c: Sort headers.
12108 * ada-varobj.c: Sort headers.
12109 * ada-valprint.c: Sort headers.
12110 * ada-typeprint.c: Sort headers.
12111 * ada-tasks.c: Sort headers.
12112 * ada-lang.c: Sort headers.
12113 * aarch64-tdep.c: Sort headers.
12114 * aarch64-ravenscar-thread.c: Sort headers.
12115 * aarch64-newlib-tdep.c: Sort headers.
12116 * aarch64-linux-tdep.c: Sort headers.
12117 * aarch64-linux-nat.c: Sort headers.
12118 * aarch64-fbsd-tdep.c: Sort headers.
12119 * aarch64-fbsd-nat.c: Sort headers.
12120 * aarch32-linux-nat.c: Sort headers.
12121
699bd4cf
TT		 121222019-04-04 Tom Tromey <tom@tromey.com>
12123
12124 * varobj.c (varobj_create): Update.
12125 * rust-exp.y (struct rust_parser) <update_innermost_block,
12126 lookup_symbol>: New methods.
12127 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12128 Rename.
12129 (rust_parser::rust_lookup_type)
12130 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12131 * printcmd.c (display_command, do_one_display): Update.
12132 * parser-defs.h (struct parser_state) <parser_state>: Add
12133 "tracker" parameter.
12134 (block_tracker): New member.
12135 (class innermost_block_tracker) <innermost_block_tracker>: Add
12136 "types" parameter.
12137 <reset>: Remove method.
12138 (innermost_block): Don't declare.
12139 (null_post_parser): Update.
12140 * parse.c (innermost_block): Remove global.
12141 (write_dollar_variable): Update.
12142 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12143 Remove "tracker_types" parameter.
12144 (parse_expression): Add "tracker" parameter.
12145 (parse_expression_for_completion): Update.
12146 (null_post_parser): Add "tracker" parameter.
12147 * p-exp.y: Update rules.
12148 * m2-exp.y: Update rules.
12149 * language.h (struct language_defn) <la_post_parser>: Add
12150 "tracker" parameter.
12151 * go-exp.y: Update rules.
12152 * f-exp.y: Update rules.
12153 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12154 parameter.
12155 * d-exp.y: Update rules.
12156 * c-exp.y: Update rules.
12157 * breakpoint.c (set_breakpoint_condition): Create an
12158 innermost_block_tracker.
12159 (watch_command_1): Likewise.
12160 * ada-lang.c (resolve): Add "tracker" parameter.
12161 (resolve_subexp): Likewise.
12162 * ada-exp.y (write_var_from_sym): Update.
12163
dac43e32
TT		 121642019-04-04 Tom Tromey <tom@tromey.com>
12165
12166 * type-stack.h: New file.
12167 * type-stack.c: New file.
12168 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12169 type-stack.h.
12170 (insert_into_type_stack, insert_type, push_type, push_type_int)
12171 (insert_type_address_space, pop_type, pop_type_int)
12172 (pop_typelist, pop_type_stack, append_type_stack)
12173 (push_type_stack, get_type_stack, push_typelist)
12174 (follow_type_instance_flags, follow_types): Don't declare.
12175 * parse.c (type_stack): Remove global.
12176 (parse_exp_in_context): Update.
12177 (insert_into_type_stack, insert_type, push_type, push_type_int)
12178 (insert_type_address_space, pop_type, pop_type_int)
12179 (pop_typelist, pop_type_stack, append_type_stack)
12180 (push_type_stack, get_type_stack, push_typelist)
12181 (follow_type_instance_flags, follow_types): Remove (moved to
12182 type-stack.c).
12183 * f-exp.y (type_stack): New global.
12184 Update rules.
12185 (push_kind_type, f_parse): Update.
12186 * d-exp.y (type_stack): New global.
12187 Update rules.
12188 (d_parse): Update.
12189 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12190 Update rules.
12191 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12192 (HFILES_NO_SRCDIR): Add type-stack.h.
12193
2a612529
TT		 121942019-04-04 Tom Tromey <tom@tromey.com>
12195
12196 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12197 (rust_parser::convert_ast_to_expression, rust_parse)
12198 (rust_lex_test_completion, rust_lex_tests): Update.
12199 * parser-defs.h (struct expr_completion_state): New.
12200 (struct parser_state) <parser_state>: Add completion parameter.
12201 <mark_struct_expression, mark_completion_tag>: New methods.
12202 <parse_completion, m_completion_state>: New members.
12203 (prefixify_expression, null_post_parser): Update.
12204 (mark_struct_expression, mark_completion_tag): Don't declare.
12205 * parse.c (parse_completion, expout_last_struct)
12206 (expout_tag_completion_type, expout_completion_name): Remove
12207 globals.
12208 (parser_state::mark_struct_expression)
12209 (parser_state::mark_completion_tag): Now methods.
12210 (prefixify_expression): Add last_struct parameter.
12211 (prefixify_subexp): Likewise.
12212 (parse_exp_1): Update.
12213 (parse_exp_in_context): Add cstate parameter. Update.
12214 (parse_expression_for_completion): Create an
12215 expr_completion_state.
12216 (null_post_parser): Add "completion" parameter.
12217 * p-exp.y: Update rules.
12218 (yylex): Update.
12219 * language.h (struct language_defn) <la_post_parser>: Add
12220 "completing" parameter.
12221 * go-exp.y: Update rules.
12222 (lex_one_token): Update.
12223 * expression.h (parse_completion): Don't declare.
12224 * d-exp.y: Update rules.
12225 (lex_one_token): Update rules.
12226 * c-exp.y: Update rules.
12227 (lex_one_token): Update.
12228 * ada-lang.c (resolve): Add "parse_completion" parameter.
12229 (resolve_subexp): Likewise.
12230 (ada_resolve_function): Likewise.
12231
43476f0b
TT		 122322019-04-04 Tom Tromey <tom@tromey.com>
12233
12234 * parser-defs.h (struct parser_state) <start_arglist,
12235 end_arglist>: New methods.
12236 <arglist_len, m_funcall_chain>: New members.
12237 (arglist_len, start_arglist, end_arglist): Don't declare.
12238 * parse.c (arglist_len, funcall_chain): Remove global.
12239 (start_arglist, end_arglist): Remove functions.
12240 (parse_exp_in_context): Update.
12241 * p-exp.y: Update rules.
12242 * m2-exp.y: Update rules.
12243 * go-exp.y: Update rules.
12244 * f-exp.y: Update rules.
12245 * d-exp.y: Update rules.
12246 * c-exp.y: Update rules.
12247
5776fca3
TT		 122482019-04-04 Tom Tromey <tom@tromey.com>
12249
12250 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12251 lex_operator, push_back>: New methods.
12252 Update all rules.
12253 (rust_parser::lex_hex, lex_escape): Rename and update.
12254 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12255 (rust_parser::lex_operator): Rename and update.
12256 (rust_parser::lex_number, rustyylex, rustyyerror)
12257 (rust_lex_test_init, rust_lex_test_sequence)
12258 (rust_lex_test_push_back, rust_lex_tests): Update.
12259 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12260 parameter.
12261 <lexptr, prev_lexptr>: New members.
12262 (lexptr, prev_lexptr): Don't declare.
12263 * parse.c (lexptr, prev_lexptr): Remove globals.
12264 (parse_exp_in_context): Update.
12265 * p-exp.y (yylex, yyerror): Update.
12266 * m2-exp.y (parse_number, yylex, yyerror): Update.
12267 * go-exp.y (lex_one_token, yyerror): Update.
12268 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12269 * d-exp.y (lex_one_token, yyerror): Update.
12270 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12271 (lex_one_token, yyerror): Update.
12272 * ada-lex.l (YY_INPUT): Update.
12273 (rewind_to_char): Update.
12274 * ada-exp.y (yyerror): Update.
12275
8621b685
TT		 122762019-04-04 Tom Tromey <tom@tromey.com>
12277
12278 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12279 * parser-defs.h (struct parser_state) <parser_state>: Add new
12280 parameter.
12281 <comma_terminates>: New member.
12282 (comma_terminates): Don't declare global.
12283 * parse.c (comma_terminates): Remove global.
12284 (parse_exp_in_context): Update.
12285 * p-exp.y (yylex): Update.
12286 * m2-exp.y (yylex): Update.
12287 * go-exp.y (lex_one_token): Update.
12288 * f-exp.y (yylex): Update.
12289 * d-exp.y (lex_one_token): Update.
12290 * c-exp.y (lex_one_token): Update.
12291 * ada-lex.l: Update.
12292
28aaf3fd
TT		 122932019-04-04 Tom Tromey <tom@tromey.com>
12294
12295 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12296 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12297 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12298 * parser-defs.h (paren_depth): Don't declare.
12299 * parse.c (paren_depth): Remove global.
12300 (parse_exp_in_context): Update.
12301 * p-exp.y (paren_depth): New global.
12302 (pascal_parse): Initialize it.
12303 * m2-exp.y (paren_depth): New global.
12304 (m2_parse): Initialize it.
12305 * go-exp.y (paren_depth): New global.
12306 (go_parse): Initialize it.
12307 * f-exp.y (paren_depth): New global.
12308 (f_parse): Initialize it.
12309 * d-exp.y (paren_depth): New global.
12310 (d_parse): Initialize it.
12311 * c-exp.y (paren_depth): New global.
12312 (c_parse): Initialize it.
12313 * ada-lex.l (paren_depth): New global.
12314 (lexer_init): Initialize it.
12315
1e58a4a4
TT		 123162019-04-04 Tom Tromey <tom@tromey.com>
12317
12318 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12319 (rust_parser::convert_ast_to_type)
12320 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12321 * parser-defs.h (struct parser_state) <parser_state>: Add
12322 parameters. Initialize new members.
12323 <expression_context_block, expression_context_pc>: New members.
12324 * parse.c (expression_context_block, expression_context_pc):
12325 Remove globals.
12326 (parse_exp_in_context): Update.
12327 * p-exp.y: Update all rules.
12328 (yylex): Update.
12329 * m2-exp.y: Update all rules.
12330 (yylex): Update.
12331 * go-exp.y (yylex): Update.
12332 * f-exp.y (yylex): Update.
12333 * d-exp.y: Update all rules.
12334 (yylex): Update.
12335 * c-exp.y: Update all rules.
12336 (lex_one_token, classify_name, yylex, c_parse): Update.
12337 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12338
37eedb39
TT		 123392019-04-04 Tom Tromey <tom@tromey.com>
12340
12341 * gdbarch.h, gdbarch.c: Rebuild.
12342 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12343 * stap-probe.h:
12344 (struct stap_parse_info): Replace "parser_state" with
12345 "expr_builder".
12346 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12347 (parser_state): New class.
12348 * parse.c (expr_builder): Rename.
12349 (expr_builder::release): Rename.
12350 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12351 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12352 (write_exp_elt_longcst, write_exp_elt_floatcst)
12353 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12354 (write_exp_string_vector, write_exp_bitstring)
12355 (write_exp_msymbol, mark_struct_expression)
12356 (write_dollar_variable)
12357 (insert_type_address_space, increase_expout_size): Replace
12358 "parser_state" with "expr_builder".
12359 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12360 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12361 "parser_state" with "expr_builder".
12362
73923d7e
TT		 123632019-04-04 Tom Tromey <tom@tromey.com>
12364
12365 * rust-exp.y: Replace "parse_language" with method call.
12366 * p-exp.y:
12367 (yylex): Replace "parse_language" with method call.
12368 * m2-exp.y:
12369 (yylex): Replace "parse_language" with method call.
12370 * go-exp.y (classify_name): Replace "parse_language" with method
12371 call.
12372 * f-exp.y (yylex): Replace "parse_language" with method call.
12373 * d-exp.y (lex_one_token): Replace "parse_language" with method
12374 call.
12375 * c-exp.y:
12376 (lex_one_token, classify_name, yylex): Replace "parse_language"
12377 with method call.
12378 * ada-exp.y (find_primitive_type, type_char)
12379 (type_system_address): Replace "parse_language" with method call.
12380
fa9f5be6
TT		 123812019-04-04 Tom Tromey <tom@tromey.com>
12382
12383 * rust-exp.y: Replace "parse_gdbarch" with method call.
12384 * parse.c (write_dollar_variable, insert_type_address_space):
12385 Replace "parse_gdbarch" with method call.
12386 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12387 call.
12388 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12389 call.
12390 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12391 "parse_gdbarch" with method call.
12392 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12393 with method call.
12394 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12395 "parse_gdbarch" with method call.
12396 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12397 "parse_gdbarch" with method call.
12398 * c-exp.y (parse_type, parse_number, classify_name): Replace
12399 "parse_gdbarch" with method call.
12400 * ada-lex.l: Replace "parse_gdbarch" with method call.
12401 * ada-exp.y (parse_type, find_primitive_type, type_char)
12402 (type_system_address): Replace "parse_gdbarch" with method call.
12403
1201a264
TT		 124042019-04-04 Tom Tromey <tom@tromey.com>
12405
12406 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12407 * stap-probe.c (stap_parse_argument): Update.
12408 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12409 initial_size parameter.
12410 * rust-exp.y (rust_lex_tests): Update.
12411 * parse.c (parser_state): Update.
12412 (parse_exp_in_context): Update.
12413 * parser-defs.h (struct parser_state) <parser_state>: Remove
12414 "initial_size" parameter.
12415
e3980ce2
TT		 124162019-04-04 Tom Tromey <tom@tromey.com>
12417
12418 * parser-defs.h (increase_expout_size): Don't declare.
12419 * parse.c (increase_expout_size): Now static.
12420
e9f8e3f1
TS		 124212019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12422
12423 * gnu-nat.c (gnu_nat_target::wait): Fix
12424 target_waitstatus_to_string call.
12425
d7df6549
AB		 124262019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12427
12428 * eval.c (evaluate_subexp_standard): Handle internal functions
12429 during Fortran function call handling.
12430
8bdc1658
AB		 124312019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12432
12433 * NEWS: Mention new internal functions.
12434 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12435 (read_base_type): Use dwarf2_init_complex_target_type.
12436 * value.c (creal_internal_fn): New function.
12437 (cimag_internal_fn): New function.
12438 (_initialize_values): Register new internal functions.
12439
c29705b7
PW		 124402019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12441
12442 * infrun.c (stop_all_threads): If debug_infrun, always
12443 trace the wait status after wait_one, using
12444 target_waitstatus_to_string and target_pid_to_str.
12445 (handle_inferior_event): Replace various trace of
12446 wait status kind by a single trace.
12447 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12448 wait status kind image by target_waitstatus_to_string.
12449 * target/waitstatus.c (target_waitstatus_to_string): Fix
12450 obsolete comment.
12451
05caa1d2
TT		 124522019-04-01 Tom Tromey <tromey@adacore.com>
12453
12454 PR symtab/23331:
12455 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12456
9d1447e0
SDJ		 124572019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12458 Pedro Alves <palves@redhat.com>
12459
12460 * top.c (quit_force): Call 'finalize_values'.
12461 * value.c (finalize_values): New function.
12462 * value.h (finalize_values): Declare.
12463
7734102d
EZ		 124642019-03-30 Eli Zaretskii <eliz@gnu.org>
12465
12466 * NEWS: Announce $_gdb_major and $_gdb_minor.
12467
12468 * top.c (init_gdb_version_vars): New function.
12469 (gdb_init): Call init_gdb_version_vars.
12470
188e1fa9
TT		 124712019-03-29 Tom Tromey <tromey@adacore.com>
12472
12473 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12474 help text. Remove dead code.
12475
2880242d
KS		 124762019-03-29 Keith Seitz <keiths@redhat.com>
12477
12478 From Siddhesh Poyarekar:
12479 * f-lang.h (f77_get_upperbound): Return LONGEST.
12480 (f77_get_lowerbound): Likewise.
12481 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12482 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12483 print them.
12484 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12485 plongest to format print it.
12486 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12487 (f77_get_upperbound): Likewise.
12488 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12489 LOWER_BOUND to LONGEST.
12490 (f77_create_arrayprint_offset_tbl): Likewise.
12491
cc1defb1
KS		 124922019-03-29 Keith Seitz <keiths@redhat.com>
12493
12494 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12495 %s/pulongest for TYPE_LENGTH instead of %d in format
12496 strings.
12497 * ada-typerint.c (ada_print_type): Likewise.
12498 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12499 * compile/compile-c-support.c (generate_register_struct): Likewise.
12500 * gdbtypes.c (recursive_dump_type): Likewise.
12501 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12502 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12503 instead of %d in format strings.
12504 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12505 to std::min to ULONGEST.
12506 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12507 instead of %d in format strings.
12508 * tracepoint.c (info_scope_command): Likewise.
12509 * typeprint.c (print_offset_data::update)
12510 (print_offset_data::finish): Likewise.
12511 * xtensa-tdep.c (xtensa_store_return_value)
12512 (xtensa_push_dummy_call): Likewise.
12513
e432ccf1
JT		 125142019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12515
12516 * windows-nat.c (display_selector): Fixed format specifications
12517 for 64-bit Cygwin.
12518
65d2b333
PW		 125192019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12520
12521 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12522
f489207e
SL		 125232019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12524
12525 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12526 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12527 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12528 (nios2_linux_init_abi): Install it.
12529
bffa1015
AH		 125302019-03-28 Alan Hayward <alan.hayward@arm.com>
12531
12532 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12533
fc96163a
AH		 125342019-03-28 Alan Hayward <alan.hayward@arm.com>
12535
12536 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12537
20dc7e9b
PW		 125382019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12539 Tom Tromey <tromey@adacore.com>
12540
12541 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12542
7f5331a8
JB		 125432019-03-26 Joel Brobecker <brobecker@adacore.com>
12544
12545 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12546 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12547 method to compute the bounds of range types. Also print "[evaluated]"
12548 if the bounds' values come from a dynamic evaluation.
12549
18c77628
AB		 125502019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12551
12552 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12553 whitespace when pretty printing is on.
12554
53c973f2
AH		 125552019-03-26 Alan Hayward <alan.hayward@arm.com>
12556
e79be6e5 12557 * ppc-linux-nat.c: Add include.
53c973f2 12558
d851aa71
AH		 125592019-03-26 Alan Hayward <alan.hayward@arm.com>
12560
e79be6e5 12561 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12562
2fe7bab7
AH		 125632019-03-26 Alan Hayward <alan.hayward@arm.com>
12564
e79be6e5 12565 * arm-linux-nat.c: Add include.
2fe7bab7 12566
068ef30e
SM		 125672019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12568
12569 * source-cache.c (source_cache::get_source_lines): Re-read
12570 fullname after calling open_source_file.
12571
81a24d04
JB		 125722019-03-25 John Baldwin <jhb@FreeBSD.org>
12573
12574 * NEWS: Mention TLS support for FreeBSD.
12575
79e7ae11
TT		 125762019-03-25 Tom Tromey <tromey@adacore.com>
12577
12578 * minsyms.c (BUNCH_SIZE): Update comment.
12579 (~minimal_symbol_reader): Remove old comment.
12580 (compact_minimal_symbols): Update comment.
12581 (minimal_symbol_reader::install): Remove old comment. Update
12582 other comments.
12583
d45963c2
AH		 125842019-03-25 Alan Hayward <alan.hayward@arm.com>
12585
12586 * s390-linux-nat.c: Add include.
12587
0f83012e
AH		 125882019-03-25 Alan Hayward <alan.hayward@arm.com>
12589
12590 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12591 Call linux_get_hwcap.
12592 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12593 Likewise.
12594 (aarch64_linux_get_hwcap): Remove function.
12595 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12596 declaration.
12597 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12598 linux_get_hwcap.
12599 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12600 * linux-tdep.c (linux_get_hwcap): Add function.
12601 (linux_get_hwcap2): Likewise.
12602 * linux-tdep.h (linux_get_hwcap): Add declaration.
12603 (linux_get_hwcap2): Likewise.
12604 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12605 (ppc_linux_get_hwcap2): Likewise.
12606 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12607 linux_get_hwcap.
12608 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12609 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12610 (ppc_linux_nat_target::read_description): Likewise.
12611 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12612 * s390-linux-nat.c: Likewise.
12613 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12614
6640a367
TT		 126152019-03-24 Tom Tromey <tom@tromey.com>
12616
12617 * ada-lang.c (standard_lookup): Simplify initialization.
12618 (ada_lookup_symbol_nonlocal): Simplify return.
12619 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12620 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12621 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12622 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12623 initialization.
12624 * solib.c (solib_global_lookup): Simplify.
12625 * symtab.c (null_block_symbol): Remove.
12626 (symbol_cache_lookup): Simplify returns.
12627 (lookup_language_this): Simplify returns.
12628 (lookup_symbol_aux): Simplify return.
12629 (lookup_local_symbol): Simplify returns.
12630 (lookup_global_symbol_from_objfile): Simplify return.
12631 (lookup_symbol_in_objfile_symtabs)
12632 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12633 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12634 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12635 * cp-namespace.c (cp_lookup_bare_symbol)
12636 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12637 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12638 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12639 (cp_lookup_symbol_via_imports): Simplify initialization.
12640 (find_symbol_in_baseclass): Likewise.
12641 * symtab.h (null_block_symbol): Remove.
12642 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12643 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12644 (d_lookup_symbol_module): Likewise.
12645 (find_symbol_in_baseclass): Simplify initialization.
12646
a930ebcd
TT		 126472019-03-24 Tom Tromey <tom@tromey.com>
12648
12649 * expression.h: Don't include symtab.h.
12650 (struct block): Forward declare.
12651
582942f4
TT		 126522019-03-24 Tom Tromey <tom@tromey.com>
12653
12654 * c-exp.y (typebase): Remove casts.
12655 * gdbtypes.c (lookup_unsigned_typename, )
12656 (lookup_signed_typename): Remove cast.
12657 * eval.c (parse_to_comma_and_eval): Remove cast.
12658 * parse.c (write_dollar_variable): Remove cast.
12659 * block.h (struct block) <superblock>: Now const.
12660 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12661 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12662 (map_block): Make "block" const.
12663 * symfile.h (struct quick_symbol_functions)
12664 <map_matching_symbols>: Constify block argument to "callback".
12665 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12666 const.
12667 (find_pc_sect_compunit_symtab): Make "b" const.
12668 (find_symbol_at_address): Likewise.
12669 (search_symbols): Likewise.
12670 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12671 (dw2_debug_names_lookup_symbol): Likewise.
12672 (dw2_map_matching_symbols): Update.
12673 * p-valprint.c (pascal_val_print): Remove "block".
12674 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12675 (aux_add_nonlocal_symbols): Make "block" const.
12676 (resolve_subexp): Remove cast.
12677 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12678 const.
12679 (iterate_over_file_blocks): Likewise.
12680 * f-exp.y (%union) <bval>: Remove.
12681 * coffread.c (patch_opaque_types): Make "b" const.
12682 * spu-tdep.c (spu_catch_start): Make "block" const.
12683 * c-valprint.c (print_unpacked_pointer): Remove "block".
12684 * symmisc.c (dump_symtab_1): Make "b" const.
12685 (block_depth): Make "block" const.
12686 * d-exp.y (%union) <bval>: Remove.
12687 * cp-support.h (cp_lookup_rtti_type): Update.
12688 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12689 * psymtab.c (psym_lookup_symbol): Make "block" const.
12690 (maintenance_check_psymtabs): Make "b" const.
12691 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12692 (enumerate_locals, enumerate_args): Update.
12693 * python/py-symtab.c (stpy_global_block): Make "block" const.
12694 (stpy_static_block): Likewise.
12695 * inline-frame.c (block_starting_point_at): Make "new_block"
12696 const.
12697 * block.c (find_block_in_blockvector): Make return type const.
12698 (blockvector_for_pc_sect): Make "b" const.
12699 (find_block_in_blockvector): Make "b" const.
12700
7ad417dd
TT		 127012019-03-23 Tom Tromey <tom@tromey.com>
12702
12703 * varobj.c (varobj_create): Update.
12704 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12705 * printcmd.c (display_command, do_one_display): Don't reset
12706 innermost_block.
12707 * parser-defs.h (enum innermost_block_tracker_type): Move to
12708 expression.h.
12709 (innermost_block): Update comment.
12710 * parse.c (parse_exp_1): Add tracker_types parameter.
12711 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12712 tracker_types parameter. Reset innermost_block.
12713 (parse_exp_in_context): Remove.
12714 (parse_expression_for_completion): Update.
12715 * objfiles.c (~objfile): Don't reset expression_context_block or
12716 innermost_block.
12717 * expression.h (enum innermost_block_tracker_type): Move from
12718 parser-defs.h.
12719 (parse_exp_1): Add tracker_types parameter.
12720 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12721 reset innermost_block.
12722
b366c208
TT		 127232019-03-23 Tom Tromey <tom@tromey.com>
12724
12725 * objfiles.h: Include bcache.h.
12726
9bb9b2f9
TT		 127272019-03-23 Tom Tromey <tom@tromey.com>
12728
12729 * linespec.c (get_current_search_block): Use
12730 scoped_restore_current_language.
12731 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12732
59c28372
AH		 127332019-03-22 Alan Hayward <alan.hayward@arm.com>
12734 Jiong Wang <jiong.wang@arm.com>
12735
12736 * aarch64-linux-tdep.c
12737 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12738 section.
12739 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12740
17e116a7
AH		 127412019-03-22 Alan Hayward <alan.hayward@arm.com>
12742 Jiong Wang <jiong.wang@arm.com>
12743
12744 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12745 instructions.
12746 (aarch64_analyze_prologue_test): Add PACIASP test.
12747 (aarch64_prologue_prev_register): Unmask PC value.
12748
11e1b75f
AH		 127492019-03-22 Alan Hayward <alan.hayward@arm.com>
12750 Jiong Wang <jiong.wang@arm.com>
12751
12752 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12753 (aarch64_dwarf2_prev_register): Unmask PC value.
12754 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12755 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12756 DW_CFA_AARCH64_negate_ra_state.
12757 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12758
34dcc7cf
AH		 127592019-03-22 Alan Hayward <alan.hayward@arm.com>
12760 Jiong Wang <jiong.wang@arm.com>
12761
12762 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12763 registers.
12764 (aarch64_pseudo_register_name): Likewise.
12765 (aarch64_pseudo_register_type): Likewise.
12766 (aarch64_pseudo_register_reggroup_p): Likewise.
12767 (aarch64_gdbarch_init): Add pauth registers.
12768 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12769 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12770 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12771 (struct gdbarch_tdep): Add regnum for ra_state.
12772
1ef53e6b
AH		 127732019-03-22 Alan Hayward <alan.hayward@arm.com>
12774 Jiong Wang <jiong.wang@arm.com>
12775
12776 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12777
76bed0fd
AH		 127782019-03-22 Alan Hayward <alan.hayward@arm.com>
12779 Jiong Wang <jiong.wang@arm.com>
12780
12781 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12782 function.
12783 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12784 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12785 (aarch64_gdbarch_init): Add puth registers.
12786 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12787 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12788 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12789
ee4fbcfa
AH		 127902019-03-22 Alan Hayward <alan.hayward@arm.com>
12791 Jiong Wang <jiong.wang@arm.com>
12792
12793 * aarch64-linux-nat.c
12794 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12795 * aarch64-linux-tdep.c
12796 (aarch64_linux_core_read_description): Likewise.
12797 (aarch64_linux_get_hwcap): New function.
12798 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12799 (aarch64_linux_get_hwcap): New declaration.
12800
6dc0ebde
AH		 128012019-03-22 Alan Hayward <alan.hayward@arm.com>
12802 Jiong Wang <jiong.wang@arm.com>
12803
12804 * aarch64-linux-nat.c
12805 (aarch64_linux_nat_target::read_description): Add pauth param.
12806 * aarch64-linux-tdep.c
12807 (aarch64_linux_core_read_description): Likewise.
12808 * aarch64-tdep.c (struct target_desc): Add in pauth.
12809 (aarch64_read_description): Add pauth param.
12810 (aarch64_gdbarch_init): Likewise.
12811 * aarch64-tdep.h (aarch64_read_description): Likewise.
12812 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12813 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12814 * features/Makefile: Add new files.
12815 * features/aarch64-pauth.c: New file.
12816 * features/aarch64-pauth.xml: New file.
12817
595915c1
TT		 128182019-03-20 Tom Tromey <tromey@adacore.com>
12819
12820 * infrun.c (handle_inferior_event): Rename from
12821 handle_inferior_event_1. Create a scoped_value_mark.
12822 (handle_inferior_event): Remove.
12823
4c7d57e7
TT		 128242019-03-19 Tom Tromey <tromey@adacore.com>
12825
12826 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12827 * infrun.h (print_stop_event): Add "displays" parameter.
12828 * infrun.c (print_stop_event): Add "displays" parameter.
12829
cb246234
PA		 128302019-03-19 Pedro Alves <palves@redhat.com>
12831
12832 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12833 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12834 to -1. Fix TABs vs spaces.
12835 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12836 * tui/tui-out.h (tui_ui_out) Add intro comments.
12837 <m_line, m_start_of_line>: In-class initialize, and add describing
12838 comment.
12839
3a0e45b2
AH		 128402019-03-18 Alan Hayward <alan.hayward@arm.com>
12841
12842 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12843 variable names.
12844 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12845
5371b850
PA		 128462019-03-18 Pedro Alves <palves@redhat.com>
12847 Eli Zaretskii <eliz@gnu.org>
12848
12849 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12850 m_line and m_start_of_line.
12851
b17c4cd0
EZ		 128522019-03-18 Eli Zaretskii <eliz@gnu.org>
12853
12854 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12855 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12856 it returns a newline. This fixes a regression in TU mode, whereby
12857 the next line is output on the same screen line as the user input.
12858
4bd56d18
TT		 128592019-03-18 Tom Tromey <tromey@adacore.com>
12860
12861 * minsyms.c (minimal_symbol_reader::install): Remove call to
12862 obstack_blank.
12863
55c10aca
PA		 128642019-03-18 Pedro Alves <palves@redhat.com>
12865
12866 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12867 New globals.
12868 (apply_style): New, factored out from ...
12869 (apply_ansi_escape): ... this. Handle reverse video mode.
12870 (tui_set_reverse_mode): New function.
12871 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12872 * tui/tui-winsource.c (tui_show_source_line): Use
12873 tui_set_reverse_mode instead of setting A_STANDOUT.
12874 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12875 New setter methods.
12876
647bb750
HD		 128772019-03-18 Hannes Domani <ssbssa@yahoo.de>
12878
12879 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12880 Handle tabs.
12881
bff8c71f
TT		 128822019-03-18 Tom Tromey <tromey@adacore.com>
12883
12884 * ada-lang.c (empty_array): Add "high" parameter.
12885 (ada_evaluate_subexp): Update.
12886
58785d98
ST		 128872019-03-17 Sergei Trofimovich <siarheit@google.com>
12888
12889 * unittests/string_view-selftests.c: Define
12890 _initialize_string_view_selftests unconditionally.
12891
d4cbef22
ВМ		 128922019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12893
12894 PR gdb/24350
12895 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12896
fce4c071
ВМ		 128972019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12898
12899 PR gdb/24351
12900 * windows-nat.c (display_selector): Fix format specifiers.
12901
f7f0a123
EZ		 129022019-03-17 Eli Zaretskii <eliz@gnu.org>
12903
12904 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12905 tui_refill_source_window instead of tui_refresh_win, to update the
12906 current execution line. This fixes redisplay of the current line
12907 when stepping through the code with "next" or "step".
12908
ab42892f
EZ		 129092019-03-16 Eli Zaretskii <eliz@gnu.org>
12910
12911 * source-cache.c (source_cache::get_source_lines): Call
12912 find_source_lines to initialize s->nlines. This fixes vertical
12913 scrolling of TUI source window when the DOWN arrow is pressed.
12914
8d8c087f
PW		 129152019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12916
12917 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12918 linux-thread-db.c (_initialize_thread_db): Likewise.
12919
798e1c30
EZ		 129202019-03-16 Eli Zaretskii <eliz@gnu.org>
12921
12922 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12923 wclrtoeol in tui_show_source_line". This reverts changes made in
12924 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12925
eefba3da
TT		 129262019-03-15 Tom Tromey <tom@tromey.com>
12927
12928 * symtab.h (struct minimal_symbol): Derive from
12929 general_symbol_info.
12930 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12931 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12932 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12933 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12934 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12935 (MSYMBOL_SEARCH_NAME): Update.
12936 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12937 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12938 * minsyms.c (minimal_symbol_reader::record_full): Update.
12939
0de2420c
TT		 129402019-03-15 Tom Tromey <tom@tromey.com>
12941
12942 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12943
042d75e4
TT		 129442019-03-15 Tom Tromey <tom@tromey.com>
12945
12946 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12947 unique_xmalloc_ptr.
12948 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12949 Update.
12950 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12951 (build_minimal_symbol_hash_tables)
12952 (minimal_symbol_reader::install): Update.
12953
db92718b
TT		 129542019-03-15 Tom Tromey <tom@tromey.com>
12955
12956 * symtab.c (create_demangled_names_hash): Update.
12957 (symbol_set_names): Update.
12958 * objfiles.h (struct objfile_per_bfd_storage)
12959 <demangled_names_hash>: Now an htab_up.
12960 * objfiles.c (objfile_per_bfd_storage): Simplify.
12961
d6797f46
TT		 129622019-03-15 Tom Tromey <tom@tromey.com>
12963
12964 * objfiles.h (struct objfile_per_bfd_storage): Declare
12965 destructor.
12966 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12967 New.
12968 (get_objfile_bfd_data): Use new. Don't initialize
12969 language_of_main.
12970 (free_objfile_per_bfd_storage): Remove.
12971 (objfile_bfd_data_free, objfile::~objfile): Use delete.
12972
741d7538
TT		 129732019-03-15 Tom Tromey <tom@tromey.com>
12974
12975 * symfile.c (reread_symbols): Update.
12976 * objfiles.c (objfile::objfile): Update.
12977 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12978 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12979 comment.
12980 (minimal_symbol_reader::install): Update.
12981 (terminate_minimal_symbol_table): Remove.
12982 * jit.c (jit_object_close_impl): Update.
12983
788c80d1
TT		 129842019-03-15 Tom Tromey <tom@tromey.com>
12985
12986 * minsyms.c (minimal_symbol_reader::record_full): Remove some
12987 initializations.
12988
1b7a07cb
TT		 129892019-03-15 Tom Tromey <tom@tromey.com>
12990
12991 * objfiles.h (struct objfile_per_bfd_storage)
12992 <demangled_hash_languages>: Now a bitset.
12993 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12994 (lookup_minimal_symbol): Update.
12995
3db066bc
TT		 129962019-03-15 Tom Tromey <tom@tromey.com>
12997
12998 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12999 Don't return the symbol.
13000 * coffread.c (record_minimal_symbol): Use record_full.
13001
3fff2c37
EZ		 130022019-03-14 Eli Zaretskii <eliz@gnu.org>
13003
13004 The MS-Windows port of ncurses fails to switch to a color pair if
13005 one or both of the colors are the implicit default colors. This
13006 change records the default colors when TUI is initialized, and
13007 then specifies them explicitly when a color pair uses the default
13008 colors. This allows color styling in TUI mode on MS-Windows.
13009
13010 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13011 ncurses_norm_attr.
13012 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13013 colors in ncurses_norm_attr.
13014 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13015 "none", replace it with the default color recorded in
13016 ncurses_norm_attr.
13017
3b336828
TT		 130182019-03-14 Tom Tromey <tromey@adacore.com>
13019
13020 * source-cache.h (class source_cache) <get_source_lines>: Return
13021 std::string.
13022 * source-cache.c (source_cache::extract_lines): Handle case where
13023 first_pos==npos. Return std::string.
13024 (source_cache::get_source_lines): Update.
13025
d085f989
TT		 130262019-03-14 Tom Tromey <tromey@adacore.com>
13027
13028 * NEWS: Add item for "style sources" commands.
13029 * source-cache.c (source_cache::get_source_lines): Check
13030 source_styling.
13031 * cli/cli-style.c (source_styling): New global.
13032 (_initialize_cli_style): Add "style sources" commands.
13033 (show_style_sources): New function.
13034 * cli/cli-style.h (source_styling): Declare.
13035
6f11e682
TT		 130362019-03-14 Pedro Alves <palves@redhat.com>
13037 Tom Tromey <tromey@adacore.com>
13038
13039 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13040 * tui/tui-winsource.c (tui_refill_source_window): New function,
13041 from...
13042 (tui_horizontal_source_scroll): ... here. Move some logic.
13043 * cli/cli-style.c (set_style_enabled): Notify new observable.
13044 * tui/tui-hooks.c (tui_redisplay_source): New function.
13045 (tui_attach_detach_observers): Attach or detach
13046 tui_redisplay_source.
13047 * observable.h (source_styling_changed): New observable.
13048 * observable.c: Define source_styling_changed observable.
13049
a068643d
TT		 130502019-03-13 Tom Tromey <tromey@adacore.com>
13051
13052 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13053 (i386_gnu_nat_target::store_registers): Update.
13054 * target-debug.h (target_debug_print_std_string): New macro.
13055 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13056 * windows-tdep.c (display_one_tib): Update.
13057 * tui/tui-stack.c (tui_make_status_line): Update.
13058 * top.c (print_inferior_quit_action): Update.
13059 * thread.c (thr_try_catch_cmd): Update.
13060 (add_thread_with_info): Update.
13061 (thread_target_id_str): Update.
13062 (thr_try_catch_cmd): Update.
13063 (thread_command): Update.
13064 (thread_find_command): Update.
13065 * record-btrace.c (record_btrace_target::info_record)
13066 (record_btrace_resume_thread, record_btrace_target::resume)
13067 (record_btrace_cancel_resume, record_btrace_step_thread)
13068 (record_btrace_target::wait, record_btrace_target::wait)
13069 (record_btrace_target::wait, record_btrace_target::stop): Update.
13070 * progspace.c (print_program_space): Update.
13071 * process-stratum-target.c
13072 (process_stratum_target::thread_address_space): Update.
13073 * linux-fork.c (linux_fork_mourn_inferior)
13074 (detach_checkpoint_command, info_checkpoints_command)
13075 (linux_fork_context): Update.
13076 (linux_fork_detach): Update.
13077 (class scoped_switch_fork_info): Update.
13078 (delete_checkpoint_command): Update.
13079 * infrun.c (follow_fork_inferior): Update.
13080 (follow_fork_inferior): Update.
13081 (proceed_after_vfork_done): Update.
13082 (handle_vfork_child_exec_or_exit): Update.
13083 (follow_exec): Update.
13084 (displaced_step_prepare_throw): Update.
13085 (displaced_step_restore): Update.
13086 (start_step_over): Update.
13087 (resume_1): Update.
13088 (clear_proceed_status_thread): Update.
13089 (proceed): Update.
13090 (print_target_wait_results): Update.
13091 (do_target_wait): Update.
13092 (context_switch): Update.
13093 (stop_all_threads): Update.
13094 (restart_threads): Update.
13095 (finish_step_over): Update.
13096 (handle_signal_stop): Update.
13097 (switch_back_to_stepped_thread): Update.
13098 (keep_going_pass_signal): Update.
13099 (print_exited_reason): Update.
13100 (normal_stop): Update.
13101 * inferior.c (inferior_pid_to_str): Change return type.
13102 (print_selected_inferior): Update.
13103 (add_inferior): Update.
13104 (detach_inferior): Update.
13105 * dummy-frame.c (fprint_dummy_frames): Update.
13106 * dcache.c (dcache_info_1): Update.
13107 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13108 (btrace_fetch, btrace_clear): Update.
13109 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13110 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13111 type.
13112 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13113 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13114 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13115 * gdbarch.c, gdbarch.h: Rebuild.
13116 * gdbarch.sh (core_pid_to_str): Change return type.
13117 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13118 return type.
13119 (windows_nat_target::pid_to_str): Change return type.
13120 (windows_delete_thread): Update.
13121 (windows_nat_target::attach): Update.
13122 (windows_nat_target::files_info): Update.
13123 * target-delegates.c: Rebuild.
13124 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13125 return type.
13126 (sol_thread_target::pid_to_str): Change return type.
13127 * remote.c (class remote_target) <pid_to_str>: Change return
13128 type.
13129 (remote_target::pid_to_str): Change return type.
13130 (extended_remote_target::attach, remote_target::remote_stop_ns)
13131 (remote_target::remote_notif_remove_queued_reply)
13132 (remote_target::push_stop_reply, remote_target::disable_btrace):
13133 Update.
13134 (extended_remote_target::attach): Update.
13135 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13136 type.
13137 (gdbsim_target::pid_to_str): Change return type.
13138 * ravenscar-thread.c (struct ravenscar_thread_target)
13139 <pid_to_str>: Change return type.
13140 (ravenscar_thread_target::pid_to_str): Change return type.
13141 * procfs.c (class procfs_target) <pid_to_str>: Change return
13142 type.
13143 (procfs_target::pid_to_str): Change return type.
13144 (procfs_target::attach): Update.
13145 (procfs_target::detach): Update.
13146 (procfs_target::fetch_registers): Update.
13147 (procfs_target::store_registers): Update.
13148 (procfs_target::wait): Update.
13149 (procfs_target::files_info): Update.
13150 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13151 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13152 return type.
13153 (nto_procfs_target::pid_to_str): Change return type.
13154 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13155 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13156 return type.
13157 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13158 (exit_lwp): Update.
13159 (attach_proc_task_lwp_callback, get_detach_signal)
13160 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13161 (linux_nat_target::resume, wait_lwp, stop_callback)
13162 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13163 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13164 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13165 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13166 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13167 type.
13168 (inf_ptrace_target::attach): Update.
13169 (inf_ptrace_target::files_info): Update.
13170 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13171 type.
13172 (go32_nat_target::pid_to_str): Change return type.
13173 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13174 (gnu_nat_target::wait): Update.
13175 (gnu_nat_target::wait): Update.
13176 (gnu_nat_target::resume): Update.
13177 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13178 (fbsd_nat_target::wait): Update.
13179 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13180 type.
13181 (darwin_nat_target::attach): Update.
13182 * corelow.c (class core_target) <pid_to_str>: Change return type.
13183 (core_target::pid_to_str): Change return type.
13184 * target.c (normal_pid_to_str): Change return type.
13185 (default_pid_to_str): Likewise.
13186 (target_pid_to_str): Change return type.
13187 (target_translate_tls_address): Update.
13188 (target_announce_detach): Update.
13189 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13190 return type.
13191 (bsd_uthread_target::pid_to_str): Change return type.
13192 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13193 type.
13194 (bsd_kvm_target::pid_to_str): Change return type.
13195 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13196 return type.
13197 (aix_thread_target::pid_to_str): Change return type.
13198 * target.h (struct target_ops) <pid_to_str>: Change return type.
13199 (target_pid_to_str, normal_pid_to_str): Likewise.
13200 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13201 type.
13202 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13203 type.
13204 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13205 return type.
13206 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13207 type.
13208 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13209 type.
13210 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13211 return type.
13212
b4be1b06
SM		 132132019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13214
13215 * NEWS: Mention that the new default MI version is 3. Mention
13216 changes to the output of commands and events that deal with
13217 multi-location breakpoints.
13218 * breakpoint.c: Include "mi/mi-out.h".
13219 (print_one_breakpoint): Change output syntax if using MI version
13220 >= 3.
13221 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13222 New.
13223 (mi_multi_location_breakpoint_output_fixed): New.
13224 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13225 (mi_cmd_fix_multi_location_breakpoint_output): New.
13226 (mi_multi_location_breakpoint_output_fixed): New.
13227 * mi/mi-cmds.c (mi_cmds): Register command
13228 -fix-multi-location-breakpoint-output.
13229 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13230 interpreter "mi".
13231
8e5e5494
SM		 132322019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13233
13234 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13235 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13236 instantiate mi_ui_out based on interpreter name.
13237 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13238 * mi/mi-main.c (mi_load_progress): Likewise.
13239
197df35e
JB		 132402019-03-12 John Baldwin <jhb@FreeBSD.org>
13241
13242 * NEWS: Combine separate "New targets" sections for 8.3.
13243
8399425f
JB		 132442019-03-12 John Baldwin <jhb@FreeBSD.org>
13245
13246 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13247 (ppcfbsd_init_abi): Install gdbarch
13248 "fetch_tls_load_module_address" and "get_thread_local_address"
13249 methods.
13250
b0f87ed0
JB		 132512019-03-12 John Baldwin <jhb@FreeBSD.org>
13252
13253 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13254 (riscv_fbsd_init_abi): Install gdbarch
13255 "fetch_tls_load_module_address" and "get_thread_local_address"
13256 methods.
13257
ce25aa57
JB		 132582019-03-12 John Baldwin <jhb@FreeBSD.org>
13259
13260 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13261 (i386fbsd_init_abi): Install gdbarch
13262 "fetch_tls_load_module_address" and "get_thread_local_address"
13263 methods.
13264
f5424cfa
JB		 132652019-03-12 John Baldwin <jhb@FreeBSD.org>
13266
13267 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13268 (amd64fbsd_init_abi): Install gdbarch
13269 "fetch_tls_load_module_address" and "get_thread_local_address"
13270 methods.
13271
945f3901
JB		 132722019-03-12 John Baldwin <jhb@FreeBSD.org>
13273
13274 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13275 (struct fbsd_pspace_data): New type.
13276 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13277 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13278 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13279 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13280 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13281
ef0bd204
JB		 132822019-03-12 John Baldwin <jhb@FreeBSD.org>
13283
13284 * gdbtypes.c (lookup_struct_elt): New function.
13285 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13286 * gdbtypes.h (struct struct_elt): New type.
13287 (lookup_struct_elt): New prototype.
13288
36c53a02
JB		 132892019-03-12 John Baldwin <jhb@FreeBSD.org>
13290
13291 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13292 remove disabled code block.
13293
6e056c81
JB		 132942019-03-12 John Baldwin <jhb@FreeBSD.org>
13295
13296 * gdbarch.sh (get_thread_local_address): New method.
13297 * gdbarch.h, gdbarch.c: Regenerate.
13298 * target.c (target_translate_tls_address): Use
13299 gdbarch_get_thread_local_address if present instead of
13300 target::get_thread_local_address.
13301
cd250a18
JB		 133022019-03-12 John Baldwin <jhb@FreeBSD.org>
13303
13304 * target.h (target::get_thread_local_address): Update comment.
13305
df22c1e5
JB		 133062019-03-12 John Baldwin <jhb@FreeBSD.org>
13307
13308 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13309 objfile->separate_debug_objfile_backlink if not NULL.
13310
dd6876c9
JB		 133112019-03-12 John Baldwin <jhb@FreeBSD.org>
13312
13313 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13314 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13315 (amd64bsd_store_inferior_registers): Likewise.
13316 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13317 Enable segment base registers.
13318 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13319 PT_GETFSBASE and PT_GETGSBASE.
13320 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13321 PT_SETGSBASE.
13322 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13323 segment base registers.
13324 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13325
1163a4b7
JB		 133262019-03-12 John Baldwin <jhb@FreeBSD.org>
13327
13328 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13329 Update calls to i386_target_description to add 'segments'
13330 parameter.
13331 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13332 add segment base registers.
13333 * arch/i386.c (i386_create_target_description): Add 'segments'
13334 parameter to enable segment base registers.
13335 * arch/i386.h (i386_create_target_description): Likewise.
13336 * features/i386/32bit-segments.xml: New file.
13337 * features/i386/32bit-segments.c: Generate.
13338 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13339 call to i386_target_description to add 'segments' parameter.
13340 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13341 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13342 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13343 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13344 if feature is present.
13345 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13346 Add 'segments' parameter to call to i386_target_description.
13347 (i386_target_description): Add 'segments' parameter to enable
13348 segment base registers.
13349 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13350 to call to i386_target_description.
13351 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13352 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13353 Define I386_NUM_REGS.
13354 (i386_target_description): Add 'segments' parameter to enable
13355 segment base registers.
13356
3a350822
EZ		 133572019-03-12 Eli Zaretskii <eliz@gnu.org>
13358
13359 PR/24325
13360 * source-cache.c: #undef open and close, to avoid unresolved
13361 externals during linking.
13362
ffdd69cf
TT		 133632019-03-12 Tom Tromey <tromey@adacore.com>
13364
13365 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13366 const. Add initializers.
13367 (_initialize_remote): Don't initialize ptid globals.
13368
ec148c57
PA		 133692019-03-12 Pedro Alves <palves@redhat.com>
13370
13371 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13372
32764270
PA		 133732019-03-12 Pedro Alves <palves@redhat.com>
13374
13375 * cp-name-parser.y (main): Remove unused 'len' variable.
13376
17547186
TT		 133772019-03-12 Tom Tromey <tromey@adacore.com>
13378
13379 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13380 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13381
d3a70e03
TT		 133822019-03-12 Tom Tromey <tromey@adacore.com>
13383
13384 * linux-nat.c (iterate_over_lwps): Update.
13385 (stop_callback): Remove parameter.
13386 (stop_wait_callback, detach_callback, resume_set_callback)
13387 (select_singlestep_lwp_callback, set_ignore_sigint)
13388 (status_callback, resumed_callback, resume_clear_callback)
13389 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13390 data parameter.
13391 (linux_nat_target::detach, linux_nat_target::resume)
13392 (linux_stop_and_wait_all_lwps, select_event_lwp)
13393 (linux_nat_filter_event, linux_nat_wait_1)
13394 (linux_nat_target::kill, linux_nat_target::stop)
13395 (linux_nat_target::stop): Update.
13396 (linux_nat_resume_callback): Change type.
13397 (resume_stopped_resumed_lwps, count_events_callback)
13398 (select_event_lwp_callback): Likewise.
13399 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13400 * arm-linux-nat.c (struct update_registers_data): Remove.
13401 (update_registers_callback): Change type.
13402 (arm_linux_insert_hw_breakpoint1): Update.
13403 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13404 parameter.
13405 (x86_linux_dr_set_addr): Update.
13406 (x86_linux_dr_set_control): Update.
13407 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13408 (iterate_over_lwps): Use gdb::function_view.
13409 * nat/aarch64-linux-hw-point.c (struct
13410 aarch64_dr_update_callback_param): Remove.
13411 (debug_reg_change_callback): Change type.
13412 (aarch64_notify_debug_reg_change): Update.
13413 * s390-linux-nat.c (s390_refresh_per_info): Update.
13414
82cb27ff
TT		 134152019-03-11 Tom Tromey <tromey@adacore.com>
13416
13417 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13418 redundant assignment to "this_cu".
13419
568c0683
SM		 134202019-03-08 Simon Marchi <simon.marchi@efficios.com>
13421
13422 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13423
f09ce22d
SM		 134242019-03-08 Simon Marchi <simon.marchi@efficios.com>
13425
13426 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13427 from...
13428 (rank_one_type): ... this.
13429
595f96a9
SM		 134302019-03-08 Simon Marchi <simon.marchi@efficios.com>
13431
13432 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13433 from...
13434 (rank_one_type): ... this.
13435
2598a94b
SM		 134362019-03-08 Simon Marchi <simon.marchi@efficios.com>
13437
13438 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13439 from...
13440 (rank_one_type): ... this.
13441
7f17b20d
SM		 134422019-03-08 Simon Marchi <simon.marchi@efficios.com>
13443
13444 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13445 from...
13446 (rank_one_type): ... this.
13447
2c509035
SM		 134482019-03-08 Simon Marchi <simon.marchi@efficios.com>
13449
13450 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13451 from...
13452 (rank_one_type): ... this.
13453
0dd322dc
SM		 134542019-03-08 Simon Marchi <simon.marchi@efficios.com>
13455
13456 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13457 from...
13458 (rank_one_type): ... this.
13459
41ea4728
SM		 134602019-03-08 Simon Marchi <simon.marchi@efficios.com>
13461
13462 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13463 from...
13464 (rank_one_type): ... this.
13465
793cd1d2
SM		 134662019-03-08 Simon Marchi <simon.marchi@efficios.com>
13467
13468 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13469 from...
13470 (rank_one_type): ... this.
13471
34910087
SM		 134722019-03-08 Simon Marchi <simon.marchi@efficios.com>
13473
13474 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13475 from...
13476 (rank_one_type): ... this.
13477
f1f832d6
SM		 134782019-03-08 Simon Marchi <simon.marchi@efficios.com>
13479
13480 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13481 from...
13482 (rank_one_type): ... this.
13483
b9f4512f
SM		 134842019-03-08 Simon Marchi <simon.marchi@efficios.com>
13485
13486 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13487 from...
13488 (rank_one_type): ... this.
13489
9293fc63
SM		 134902019-03-08 Simon Marchi <simon.marchi@efficios.com>
13491
13492 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13493 from...
13494 (rank_one_type): ... this.
13495
e3abbe7e
PW		 134962019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13497
13498 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13499 inferior-events' shows the example events.
13500
e4adb939
EZ		 135012019-03-08 Eli Zaretskii <eliz@gnu.org>
13502
13503 Support styling on native MS-Windows console
13504
13505 PR/24315
13506 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13507 on MS-Windows if $TERM is not defined.
13508
13509 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13510
13511 * posix-hdep.c (gdb_console_fputs):
13512 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13513 functions.
13514 * ui-file.h (gdb_console_fputs): Add prototype.
13515
13516 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13517 back to fputs only if the former returns zero.
13518
25629dfd
TT		 135192019-03-07 Tom Tromey <tom@tromey.com>
13520
13521 * symmisc.c (print_symbol_bcache_statistics): Update.
13522 (print_objfile_statistics): Update.
13523 * symfile.c (allocate_symtab): Update.
13524 * stabsread.c: Don't include bcache.h.
13525 * psymtab.h (struct psymbol_bcache): Don't declare.
13526 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13527 (psymbol_bcache_init, psymbol_bcache_free)
13528 (psymbol_bcache_get_bcache): Don't declare.
13529 * psymtab.c (struct psymbol_bcache): Remove.
13530 (psymtab_storage::psymtab_storage): Update.
13531 (psymtab_storage::~psymtab_storage): Update.
13532 (psymbol_bcache_init, psymbol_bcache_free)
13533 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13534 (add_psymbol_to_bcache): Update.
13535 (allocate_psymtab): Update.
13536 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13537 macro_cache>: No longer pointers.
13538 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13539 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13540 * macrotab.c (macro_bcache): Update.
13541 * macroexp.c: Don't include bcache.h.
13542 * gdbtypes.c (check_types_worklist): Update.
13543 (types_deeply_equal): Remove TRY/CATCH. Update.
13544 * elfread.c (elf_symtab_read): Update.
13545 * dwarf2read.c: Don't include bcache.h.
13546 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13547 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13548 (print_bcache_statistics, bcache_memory_used): Don't declare.
13549 (struct bcache): Move from bcache.c. Add constructor, destructor,
13550 methods. Rename all data members.
13551 * bcache.c (struct bcache): Move to bcache.h.
13552 (bcache::expand_hash_table): Rename from expand_hash_table.
13553 (bcache): Remove.
13554 (bcache::insert): Rename from bcache_full.
13555 (bcache::compare): Rename from bcache_compare.
13556 (bcache_xmalloc): Remove.
13557 (bcache::~bcache): Rename from bcache_xfree.
13558 (bcache::print_statistics): Rename from print_bcache_statistics.
13559 (bcache::memory_used): Rename from bcache_memory_used.
13560
fe726667
PA		 135612019-03-07 Pedro Alves <palves@redhat.com>
13562
13563 * infrun.c (normal_stop): Also check for
13564 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13565
7584bb30
AB		 135662019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13567
13568 * f-lang.c (value_from_host_double): Moved to...
13569 * value.c (value_from_host_double): ...here.
13570 * value.h (value_from_host_double): Declare.
13571 * guile/scm-math.c (vlscm_convert_typed_number): Use
13572 value_from_host_double.
13573 (vlscm_convert_number): Likewise.
13574 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13575 * python/py-value.c (convert_value_from_python): Likewise.
13576
a7b1986e
TT		 135772019-03-06 Tom Tromey <tom@tromey.com>
13578
13579 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13580
0ccf4211
TT		 135812019-03-06 Tom Tromey <tom@tromey.com>
13582
13583 * utils.h (free_current_contents): Don't declare.
13584 * utils.c (free_current_contents): Remove.
13585
fe7b42e5
TT		 135862019-03-06 Tom Tromey <tom@tromey.com>
13587
13588 * top.c (quit_force): Update.
13589 * main.c (captured_command_loop): Update.
13590 * common/new-op.c (operator new): Update.
13591 * common/common-exceptions.c (struct catcher)
13592 <save_cleanup_chain>: Remove member.
13593 (exceptions_state_mc_init): Update.
13594 (exception_try_scope_entry): Return nullptr.
13595 (exception_try_scope_exit, exception_rethrow)
13596 (throw_exception_sjlj, throw_exception_cxx): Update.
13597 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13598 (all_cleanups, do_cleanups, discard_cleanups)
13599 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13600 (restore_cleanups, restore_final_cleanups): Don't declare.
13601 (do_final_cleanups): Remove parameter.
13602 * common/cleanups.c (cleanup_chain, make_cleanup)
13603 (make_cleanup_dtor, all_cleanups, do_cleanups)
13604 (discard_my_cleanups, discard_cleanups)
13605 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13606 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13607 (null_cleanup): Remove.
13608 (do_final_cleanups): Remove parameter.
13609
c6321f19
TT		 136102019-03-06 Tom Tromey <tom@tromey.com>
13611
13612 * remote.c (remote_target::remote_parse_stop_reply): Use
13613 unique_xmalloc_ptr.
13614
61b30099
TT		 136152019-03-06 Tom Tromey <tom@tromey.com>
13616
13617 * stabsread.c (struct stabs_field_info): Rename from field_info.
13618 <list, fnlist>: Add initializers.
13619 <obstack>: New member.
13620 (read_member_functions, read_struct_fields, read_baseclasses):
13621 Allocate on obstack. Don't use cleanups.
13622 (read_one_struct_field, read_member_functions, read_struct_fields)
13623 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13624 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13625 (read_struct_type): Update.
13626
6cceac94
TT		 136272019-03-06 Tom Tromey <tom@tromey.com>
13628
13629 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13630 * common/filestuff.h (make_cleanup_close): Don't declare.
13631 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13632 Remove.
13633
72412762
TT		 136342019-03-06 Tom Tromey <tom@tromey.com>
13635
13636 * solib-aix.c: Use make_scope_exit.
13637
2b6ff1c0
TT		 136382019-03-06 Tom Tromey <tom@tromey.com>
13639
13640 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13641 Use make_scope_exit.
13642
d01c5877
TT		 136432019-03-06 Tom Tromey <tom@tromey.com>
13644
13645 * solib-svr4.c (disable_probes_interface): Remove parameter.
13646 (svr4_handle_solib_event): Use make_scope_exit.
13647
32603266
TT		 136482019-03-06 Tom Tromey <tom@tromey.com>
13649
13650 * remote.c (struct stop_reply_deleter): Remove.
13651 (stop_reply_up): Update.
13652 (struct stop_reply): Derive from notif_event. Don't typedef.
13653 <regcache>: Now a std::vector.
13654 (stop_reply_xfree): Remove.
13655 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13656 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13657 (remote_target::discard_pending_stop_replies): Use delete.
13658 (remote_target::remote_parse_stop_reply): Update.
13659 (remote_target::process_stop_reply): Update.
13660 * remote-notif.h (struct notif_event): Add virtual destructor.
13661 Remove "dtr" member.
13662 (struct notif_client) <alloc_event>: Return a unique_ptr.
13663 (notif_event_xfree): Don't declare.
13664 (notif_event_up): New typedef.
13665 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13666 (notif_event_xfree, do_notif_event_xfree): Remove.
13667 (remote_notif_state_xfree): Update.
13668
9799571e
TT		 136692019-03-06 Tom Tromey <tom@tromey.com>
13670
13671 * infrun.c (displaced_step_clear_cleanup): Now a
13672 forward_scope_exit type.
13673 (displaced_step_prepare_throw): Update.
13674 (displaced_step_fixup): Update.
13675
09e3c4ca
TT		 136762019-03-06 Tom Tromey <tom@tromey.com>
13677
13678 * inferior.h (class inferior): Update comment.
13679 * gdbthread.h (class thread_info): Update comment.
13680
e2a03548
TT		 136812019-03-06 Joel Brobecker <brobecker@adacore.com>
13682 Tom Tromey <tom@tromey.com>
13683
13684 * stabsread.h (struct stab_section_list): Remove.
13685 (coffstab_build_psymtabs): Update.
13686 * dbxread.c (symbuf_sections): Now a std::vector.
13687 (sect_idx): New global.
13688 (fill_symbuf): Update.
13689 (coffstab_build_psymtabs): Change type of stabsects parameter.
13690 Update.
13691 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13692 std::vector.
13693 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13694 (coff_locate_sections): Update.
13695 (coff_symfile_read): Remove cleanups. Update.
13696 (init_stringtab): Add storage parameter.
13697 (free_stringtab, free_stringtab_cleanup): Remove.
13698 (init_lineno): Add storage parameter.
13699 (free_linetab, free_linetab_cleanup): Remove.
13700
b7e60d85
PA		 137012019-03-06 Pedro Alves <palves@redhat.com>
13702
13703 * linux-fork.c (fork_info::clobber_regs): Delete.
13704 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13705 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13706 comment. Adjust.
13707 (scoped_switch_fork_info::scoped_switch_fork_info)
13708 (checkpoint_command, linux_fork_context): Adjust
13709 fork_save_infrun_state calls.
13710
e52c971f
PA		 137112019-03-06 Pedro Alves <palves@redhat.com>
13712
13713 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13714 (inf_has_multiple_threads): Return 'bool' and rewrite using
13715 inferior_info::threads().
13716
06974e6c
PA		 137172019-03-06 Pedro Alves <palves@redhat.com>
13718
13719 * linux-fork.c: Include <list>.
13720 (fork_list): Now a std::list instance.
13721 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13722 (forks_exist_p, find_last_fork): Adjust.
13723 (new_fork): Delete.
13724 (one_fork_p): New.
13725 (add_fork): Adjust.
13726 (free_fork): Delete, folded into fork_info::~fork_info().
13727 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13728 Adjust.
13729 (init_fork_list): Delete.
13730 (linux_fork_killall, linux_fork_mourn_inferior)
13731 (linux_fork_detach, info_checkpoints_command): Adjust.
13732 (_initialize_linux_fork): No longer call init_fork_list.
13733
72f31aea
PA		 137342019-03-06 Pedro Alves <palves@redhat.com>
13735
13736 * linux-fork.c (new_fork): New, split out of ...
13737 (add_fork): ... this. Return void. Move "first fork" special
13738 case from here, to ...
13739 (checkpoint_command): ... here.
13740 * linux-linux.h (add_fork): Return void.
13741
efbecbc1
AB		 137422019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13743
13744 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13745
0841c79a
AB		 137462019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13747 Chris January <chris.january@arm.com>
13748 David Lecomber <david.lecomber@arm.com>
13749
13750 * f-exp.y: New token, UNOP_INTRINSIC.
13751 (exp): New pattern using UNOP_INTRINSIC token.
13752 (f77_keywords): Add 'abs' keyword.
13753 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13754 (value_from_host_double): New function.
13755 (evaluate_subexp_f): Support UNOP_ABS.
13756
4a270568
AB		 137572019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13758
13759 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13760 types.
13761
067630bd
AB		 137622019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13763
13764 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13765 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13766 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13767
3be47f7a
AB		 137682019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13769
13770 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13771
4d00f5d8
AB		 137722019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13773 Chris January <chris.january@arm.com>
13774
13775 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13776 * f-exp.y: Define 'KIND' token.
13777 (exp): New pattern for KIND expressions.
13778 (ptype): Handle types with a kind extension.
13779 (direct_abs_decl): Extend to spot kind extensions.
13780 (f77_keywords): Add 'kind' to the list.
13781 (push_kind_type): New function.
13782 (convert_to_kind_type): New function.
13783 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13784 * parse.c (operator_length_standard): Likewise.
13785 * parser-defs.h (enum type_pieces): Add tp_kind.
13786 * std-operator.def: Add UNOP_KIND.
13787
e454224f
AB		 137882019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13789
13790 * f-exp.y (f_parse): Set yydebug.
13791
9dad4a58
AB		 137922019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13793
13794 * f-lang.c (evaluate_subexp_f): New function.
13795 (exp_descriptor_f): New global.
13796 (f_language_defn): Use exp_descriptor_f instead of
13797 exp_descriptor_standard.
13798
c8f91604
AB		 137992019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13800
13801 * f-exp.y (struct token): Add comments.
13802 (dot_ops): Remove uppercase versions and the end marker.
13803 (f77_keywords): Likewise.
13804 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13805 entries in the dot_ops array are case insensitive, and use
13806 strncasecmp to compare strings. Also some whitespace cleanup in
13807 this area. Similar for the f77_keywords array, except entries in
13808 this list might be case sensitive.
13809
dd9f2c76
AB		 138102019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13811
13812 * f-exp.y (struct f77_boolean_val): Add comments.
13813 (boolean_values): Remove uppercase versions, and end marker.
13814 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13815 and use strncasecmp to achieve case insensitivity. Additionally,
13816 perform whitespace cleanup around this code.
13817
67a3048c
TT		 138182019-03-06 Tom Tromey <tromey@adacore.com>
13819
13820 * remote-sim.c (gdbsim_target_open): Use result of
13821 gdb_argv::release.
13822
aa3cfbda
RB		 138232019-03-06 Richard Bunt <richard.bunt@arm.com>
13824 Dirk Schubert <dirk.schubert@arm.com>
13825 Chris January <chris.january@arm.com>
13826
13827 * eval.c (evaluate_subexp_standard): Call Fortran argument
13828 wrapping logic.
13829 * f-lang.c (struct value): A value which can be passed into a
13830 Fortran function call.
13831 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13832 where appropriate.
13833 (struct type): Value ready for a Fortran function call.
13834 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13835 is needed.
13836 * f-lang.h (fortran_argument_convert): Declaration.
13837 (fortran_preserve_arg_pointer): Declaration.
13838 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13839
ea38e5df
TT		 138402019-03-05 Tom Tromey <tromey@adacore.com>
13841
13842 * python/py-prettyprint.c (print_string_repr): Remove #if.
13843 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13844
06b5b831
TT		 138452019-03-05 Tom Tromey <tromey@adacore.com>
13846
13847 * target.c (the_dummy_target): Move later. Change type to
13848 "dummy_target".
13849 (initialize_targets): Don't initialize the_dummy_target.
13850
edbd9e45
TT		 138512019-03-05 Tom Tromey <tromey@adacore.com>
13852
13853 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13854 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13855
c119e040
TT		 138562019-03-05 Tom Tromey <tromey@adacore.com>
13857
13858 * windows-nat.c (windows_nat_target::attach)
13859 (windows_nat_target::detach): Don't call gdb_flush.
13860 * valprint.c (generic_val_print, val_print, val_print_string):
13861 Don't call gdb_flush.
13862 * utils.c (defaulted_query): Don't call gdb_flush.
13863 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13864 * target.c (target_announce_detach): Don't call gdb_flush.
13865 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13866 * remote.c (extended_remote_target::attach): Don't call
13867 gdb_flush.
13868 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13869 * printcmd.c (do_examine): Don't call gdb_flush.
13870 (info_display_command): Don't call gdb_flush.
13871 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13872 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13873 * memattr.c (info_mem_command): Don't call gdb_flush.
13874 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13875 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13876 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13877 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13878 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13879 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13880 (gnu_nat_target::detach): Don't call gdb_flush.
13881 * f-valprint.c (f_val_print): Don't call gdb_flush.
13882 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13883 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13884 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13885 gdb_flush.
13886 * c-valprint.c (c_val_print): Don't call gdb_flush.
13887 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13888
895dafa6
TT		 138892019-03-05 Tom Tromey <tromey@adacore.com>
13890
13891 * varobj.c (update_dynamic_varobj_children): Update.
13892 (install_default_visualizer): Use reset, not release.
13893 * value.c (set_internalvar): Update.
13894 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13895 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13896 ATTRIBUTE_UNUSED_RESULT.
13897
88a774b9
TT		 138982019-03-05 Tom Tromey <tromey@adacore.com>
13899
13900 * remote.c (class scoped_remote_fd) <release>: Add
13901 ATTRIBUTE_UNUSED_RESULT.
13902
4e4a8b93
TT		 139032019-03-05 Tom Tromey <tromey@adacore.com>
13904
13905 * macroexp.c (struct macro_buffer) <release>: Add
13906 ATTRIBUTE_UNUSED_RESULT.
13907
083eef1f
TT		 139082019-03-05 Tom Tromey <tromey@adacore.com>
13909
13910 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13911 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13912 ATTRIBUTE_UNUSED_RESULT.
13913
3cabd438
TT		 139142019-03-05 Tom Tromey <tromey@adacore.com>
13915
13916 * common/scoped_fd.h (class scoped_fd) <release>: Add
13917 ATTRIBUTE_UNUSED_RESULT.
13918
41e3300a
TT		 139192019-03-05 Tom Tromey <tromey@adacore.com>
13920
13921 * parser-defs.h (struct parser_state) <release>: Add
13922 ATTRIBUTE_UNUSED_RESULT.
13923
18cb7c9f
TT		 139242019-03-05 Tom Tromey <tromey@adacore.com>
13925
13926 * utils.h (class gdb_argv) <release>: Add
13927 ATTRIBUTE_UNUSED_RESULT.
13928 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13929
41fa577f
EZ		 139302019-03-02 Eli Zaretskii <eliz@gnu.org>
13931
a6a4b2c6
EZ		 13932 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13933 for-loop range, to avoid compiler warnings.
13934
13935 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13936 avoid compiler warnings about unused variables.
13937
742a7df5
EZ		 13938 * NEWS: Mention end of support for native debugging on MS-Windows
13939 before XP.
13940
41fa577f
EZ		 13941 PR gdb/24292
13942 * common/netstuff.c:
13943 * gdbserver/gdbreplay.c
13944 * gdbserver/remote-utils.c:
13945 * ser-tcp.c:
13946 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13947 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13948 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13949 'getaddrinfo' and 'freeaddrinfo' were not available before
13950 Windows XP, and mingw.org's MinGW headers by default define
13951 _WIN32_WINNT to 0x500.
13952
827f438f
GB		 139532019-03-01 Gary Benson <gbenson@redhat.com>
13954
13955 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13956
92137da0
RO		 139572019-02-28 Brian Vandenberg <phantall@gmail.com>
13958 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13959
13960 PR gdb/8527
13961 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13962 set_sigint_trap, clear_sigint_trap.
13963
799efbe8
PW		 139642019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13965
13966 * target.c (target_detach): Clear the regcache and the
13967 frame cache.
13968
8ed25214
PA		 139692019-02-27 Pedro Alves <palves@redhat.com>
13970
13971 * utils.c (set_screen_size): When we cap the height/width sizes,
13972 tweak the corresponding command variable to show "unlimited":
13973
23031e31
SJ		 139742019-02-27 Saagar Jha <saagar@saagarjha.com>
13975 Pedro Alves <palves@redhat.com>
13976
13977 * utils.c (set_screen_size): Reduce "infinite" rows and columns
13978 before calling rl_set_screen_size.
13979
6c28e44a
TT		 139802019-02-27 Tom Tromey <tromey@adacore.com>
13981
13982 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13983 define.
13984 * python/py-value.c: Remove Python 2.4 workaround.
13985 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13986 workaround.
13987 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13988 Python 2.4 workaround.
13989 * python/python-internal.h: Remove Python 2.4 comment.
13990 (Py_ssize_t): Don't define.
13991 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13992 (gdb_Py_DECREF): Remove Python 2.4 workaround.
13993 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13994 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13995 * python/python.c (do_start_initialization): Remove Python 2.4
13996 workaround.
13997 * python/py-prettyprint.c (class dummy_python_frame): Remove.
13998 (print_children): Remove Python 2.4 workaround.
13999 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14000 workaround.
14001 (CHARBUFFERPROC_NAME): Remove.
14002 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14003 Python 2.4 workaround.
14004
2c3fc25d 140052019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 14006
2c3fc25d
KB		 14007 * NEWS: Note minimum Python version.
14008
6ca62222
KB		 140092019-02-27 Kevin Buettner <kevinb@redhat.com>
14010
14011 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14012 code from these functions. Remove corresponding ifdefs. Use
14013 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14014 Remove gotos and target of gotos.
14015 (infpy_search_memory): Likewise.
14016
f4bc7d2c
AB		 140172019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14018
14019 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14020 (hppa_gdbarch_init): Don't register deleted functions with
14021 gdbarch.
14022
9734a586
AB		 140232019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14024
14025 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14026 (h8300_unwind_sp): Delete.
14027 (h8300_dummy_id): Delete.
14028 (h8300_gdbarch_init): Don't register deleted functions with
14029 gdbarch.
14030
68b867f3
AB		 140312019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14032
14033 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14034 (ft32_unwind_pc): Delete.
14035 (ft32_unwind_sp): Delete.
14036 (ft32_gdbarch_init): Don't register deleted functions with
14037 gdbarch.
14038
2fbe7ad0
AB		 140392019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14040
14041 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14042 (frv_unwind_pc): Delete.
14043 (frv_unwind_sp): Delete.
14044 (frv_gdbarch_init): Don't register deleted functions with
14045 gdbarch.
14046
76055cbe
AB		 140472019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14048
14049 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14050 (riscv_unwind_pc): Delete.
14051 (riscv_unwind_sp): Delete.
14052 (riscv_gdbarch_init): Don't register deleted functions with
14053 gdbarch.
14054
4133e5a1
AB		 140552019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14056
14057 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14058 (csky_unwind_pc): Delete.
14059 (csky_unwind_sp): Delete.
14060 (csky_gdbarch_init): Don't register deleted functions with
14061 gdbarch.
14062
8010f576
AB		 140632019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14064
14065 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14066 (cris_unwind_pc): Delete.
14067 (cris_unwind_sp): Delete.
14068 (cris_gdbarch_init): Don't register deleted functions with
14069 gdbarch.
14070
b56bf084
AB		 140712019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14072
14073 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14074 (bfin_unwind_pc): Delete.
14075 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14076
a19a650f
AB		 140772019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14078
14079 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14080 (arm_unwind_pc): Delete.
14081 (arm_unwind_sp): Delete.
14082 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14083
f8278c3c
AB		 140842019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14085
14086 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14087 (arc_unwind_pc): Delete.
14088 (arc_unwind_sp): Delete.
14089 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14090
480e46cf
AB		 140912019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14092
14093 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14094 (alpha_unwind_pc): Delete.
14095 (alpha_gdbarch_init): Don't register deleted functions with
14096 gdbarch.
14097
7a995095
AB		 140982019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14099
14100 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14101 (aarch64_unwind_pc): Delete.
14102 (aarch64_unwind_sp): Delete.
14103 (aarch64_gdbarch_init): Don't register deleted functions with
14104 gdbarch.
14105
bf9a735e
AB		 141062019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14107
14108 * gdbtypes.c (type_align): Don't consider static members when
14109 computing structure alignment.
14110
5561fc30
AB		 141112019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14112
14113 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14114 return 0 for other types.
14115 * arch-utils.c (default_type_align): Always return 0.
14116 * gdbarch.h: Regenerate.
14117 * gdbarch.sh (type_align): Extend comment.
14118 * gdbtypes.c (type_align): Add additional comments, always call
14119 gdbarch_type_align before applying the default rules.
14120 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14121 generic code will then apply a suitable default.
14122 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14123 types, return 0 for other types.
14124
9335e75a
JB		 141252019-02-27 Joel Brobecker <brobecker@adacore.com>
14126
14127 * NEWS: Create a new section for the next release branch.
14128 Rename the section of the current branch, now that it has
14129 been cut.
14130
3d34d8de
JB		 141312019-02-27 Joel Brobecker <brobecker@adacore.com>
14132
14133 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14134 * version.in: Bump version to 8.3.50.DATE-git.
14135
143420fb
SM		 141362019-02-26 Simon Marchi <simon.marchi@efficios.com>
14137
14138 * aix-thread.c (ptid_cmp): Remove unused variable.
14139 (get_signaled_thread): Likewise.
14140 (store_regs_user_thread): Likewise.
14141 (store_regs_kernel_thread): Likewise.
14142 (fetch_regs_kernel_thread): Remove shadowed variable.
14143
172fb711
AB		 141442019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14145
14146 * features/riscv/32bit-cpu.xml: Add register numbers.
14147 * features/riscv/32bit-fpu.c: Regenerate.
14148 * features/riscv/32bit-fpu.xml: Add register numbers.
14149 * features/riscv/64bit-cpu.xml: Add register numbers.
14150 * features/riscv/64bit-fpu.c: Regenerate.
14151 * features/riscv/64bit-fpu.xml: Add register numbers.
14152
26c89782
KB		 141532019-02-26 Kevin Buettner <kevinb@redhat.com>
14154
af54ade9 14155 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB		 14156 * python/py-value.c (convert_buffer_and_type_to_value): New
14157 function.
14158 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14159 Add support for handling an optional second argument. Call
14160 convert_buffer_and_type_to_value as appropriate.
26c89782
KB		 14161 * python/python-internal.h (Py_buffer_deleter): New struct.
14162 (Py_buffer_up): New typedef.
14163
0f58c9e8
JB		 141642019-02-25 John Baldwin <jhb@FreeBSD.org>
14165
14166 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14167 instead of releasing ownership.
14168
0a0f4c01
JR		 141692019-02-25 Jordan Rupprecht <rupprecht@google.com>
14170
14171 * dwarf2read.c (open_and_init_dwp_file): Call
14172 elf_numsections instead of bfd_count_sections to initialize
14173 dwp_file->num_sections.
14174
cd5a152c
TT		 141752019-02-25 Tom Tromey <tromey@adacore.com>
14176
14177 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14178
8a6a8513
SDJ		 141792019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14180
14181 * gcore.in: Add '--readnever' option when invoking GDB.
14182
04dcda9c
SM		 141832019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14184
14185 * MAINTAINERS: Update my email address.
14186
07bc701d
SM		 141872019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14188
14189 * build-id.c (build_id_to_debug_bfd_1): New function.
14190 (build_id_to_debug_bfd): Look for separate debug file in
14191 sysroot.
14192
c6f4a5d0
AB		 141932019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14194
14195 * gdbarch.sh: Update the copyright year range that is placed into
14196 generated files.
14197
9600246d
KS		 141982019-02-22 Keith Seitz <keiths@redhat.com>
14199
14200 PR symtab/23853
14201 * linespec.c (create_sals_line_offset): Search for the default
14202 symtab's filename instead of its fullname.
14203
7557a514
AH		 142042019-02-21 Alan Hayward <alan.hayward@arm.com>
14205
14206 * NEWS: Update style defaults.
14207
ee2bcb0c
AH		 142082019-02-21 Alan Hayward <alan.hayward@arm.com>
14209
14210 * main.c (captured_main_1): Disable styling in batch mode.
14211
0c95f9ed
TT		 142122019-02-20 Tom Tromey <tom@tromey.com>
14213
14214 * symtab.c (symtab_symbol_info): Fix typos.
14215
c763b894
TT		 142162019-02-20 Tom Tromey <tromey@adacore.com>
14217
14218 * findcmd.c (_initialize_mem_search): Use upper case for
14219 metasyntactic variables.
14220
0ef8a082
AH		 142212019-02-20 Alan Hayward <alan.hayward@arm.com>
14222
14223 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14224 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14225
6caa91b6
SM		 142262019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14227
14228 * top.h (source_file_name): Change to std::string.
14229 * top.c (source_file_name): Likewise.
14230 (command_line_input): Adjust.
14231 * cli/cli-script.c (script_from_file): Adjust.
14232
98814c6c
TT		 142332019-02-19 Tom Tromey <tromey@adacore.com>
14234
14235 * ravenscar-thread.c
14236 (ravenscar_thread_target::update_thread_list): Don't call
14237 ada_build_task_list.
14238 * ada-lang.h (ada_build_task_list): Don't declare.
14239 * ada-tasks.c (struct ada_tasks_inferior_data)
14240 <task_list_valid_p>: Now bool.
14241 (read_known_tasks, ada_task_list_changed)
14242 (ada_tasks_invalidate_inferior_data): Update.
14243 (read_known_tasks_array): Return bool.
14244 (read_known_tasks_list): Likewise.
14245 (read_known_tasks): Return void.
14246 (ada_build_task_list): Now static.
14247
70cd633e
AB		 142482019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14249
14250 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14251 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14252
040b3e95
PW		 142532019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14254
14255 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14256 variant for ada_tasks_pspace_data_handle and
14257 ada_tasks_inferior_data_handle.
14258 (ada_tasks_pspace_data_cleanup): New function.
14259 (ada_tasks_inferior_data_cleanup): New function.
14260
9409233b
TT		 142612019-02-17 Tom Tromey <tom@tromey.com>
14262
14263 * macrotab.h (macro_source_fullname): Return a std::string.
14264 * macrotab.c (macro_include, check_for_redefinition)
14265 (macro_undef, macro_lookup_definition, foreach_macro)
14266 (foreach_macro_in_scope): Update.
14267 (macro_source_fullname): Return a std::string.
14268 * macrocmd.c (show_pp_source_pos): Update.
14269
6506371f
TT		 142702019-02-17 Tom Tromey <tom@tromey.com>
14271
14272 * macrocmd.c (show_pp_source_pos): Style the file names.
14273
0c820d67
TT		 142742019-02-17 Tom Tromey <tom@tromey.com>
14275
14276 PR tui/24197:
14277 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14278
a0087920
TT		 142792019-02-17 Tom Tromey <tom@tromey.com>
14280
14281 * ada-lang.c (user_select_syms): Use filtered printing.
14282 * utils.c (wrap_style): New global.
14283 (desired_style): Remove.
14284 (emit_style_escape): Add stream parameter.
14285 (set_output_style, reset_terminal_style, prompt_for_continue):
14286 Update.
14287 (flush_wrap_buffer): Only flush gdb_stdout.
14288 (wrap_here): Set wrap_style.
14289 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14290 treat escape sequences as a character. Change when wrap buffer is
14291 flushed.
14292 (fputs_styled): Do not set the output style when the default is
14293 requested.
14294 * ui-style.h (struct ui_file_style) <is_default>: New method.
14295 * source.c (print_source_lines_base): Emit escape sequences in one
14296 piece.
14297
75ba10dc
JB		 142982019-02-17 Joel Brobecker <brobecker@adacore.com>
14299
14300 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14301 integers and enumeration types.
14302
a2cd4f14
JB		 143032019-02-17 Joel Brobecker <brobecker@adacore.com>
14304
14305 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14306 instead of lookup_symbol_in_language
14307 (do_exact_match): New function.
14308 (ada_get_symbol_name_matcher): Return do_exact_match when
14309 doing a verbatim match.
14310
485b851b
TT		 143112019-02-15 Tom Tromey <tromey@adacore.com>
14312
14313 * ravenscar-thread.c (ravenscar_thread_target::resume)
14314 (ravenscar_thread_target::wait): Special case wildcard requests.
14315
0b790b1e
TT		 143162019-02-15 Tom Tromey <tromey@adacore.com>
14317
14318 * ravenscar-thread.c (base_ptid): Remove.
14319 (struct ravenscar_thread_target) <close>: New method.
14320 <m_base_ptid>: New member.
14321 <update_inferior_ptid, active_task, task_is_currently_active,
14322 runtime_initialized>: Declare methods.
14323 <ravenscar_thread_target>: Add constructor.
14324 (ravenscar_thread_target::task_is_currently_active)
14325 (ravenscar_thread_target::update_inferior_ptid)
14326 (ravenscar_runtime_initialized): Rename. Now methods.
14327 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14328 (ravenscar_thread_target::update_thread_list): Update.
14329 (ravenscar_thread_target::active_task): Now method.
14330 (ravenscar_thread_target::store_registers)
14331 (ravenscar_thread_target::prepare_to_store)
14332 (ravenscar_thread_target::prepare_to_store)
14333 (ravenscar_thread_target::mourn_inferior): Update.
14334 (ravenscar_inferior_created): Use "new" to create target.
14335 (ravenscar_thread_target::get_ada_task_ptid): Update.
14336 (_initialize_ravenscar): Don't initialize base_ptid.
14337 (ravenscar_ops): Remove global.
14338
dea57a62
TT		 143392019-02-15 Tom Tromey <tromey@adacore.com>
14340
14341 * target.h (push_target): Declare new overload.
14342 * target.c (push_target): New overload, taking an rvalue reference.
14343 * remote.c (remote_target::open_1): Use push_target overload.
14344 * corelow.c (core_target_open): Use push_target overload.
14345
989f3c58
TT		 143462019-02-15 Tom Tromey <tromey@adacore.com>
14347
14348 * ravenscar-thread.c (is_ravenscar_task)
14349 (ravenscar_task_is_currently_active): Return bool.
14350 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14351 (_initialize_ravenscar): Remove "(void)".
14352 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14353 Return bool.
14354
6cbcc006
TT		 143552019-02-15 Tom Tromey <tromey@adacore.com>
14356
14357 * ravenscar-thread.c (ravenscar_runtime_initializer)
14358 (has_ravenscar_runtime, get_running_thread_id)
14359 (ravenscar_thread_target::resume): Fix indentation.
14360
7657f14d
TT		 143612019-02-15 Tom Tromey <tromey@adacore.com>
14362
14363 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14364 from ravenscar_arch_ops.
14365 (sparc_ravenscar_ops::fetch_registers)
14366 (sparc_ravenscar_ops::store_registers): Now methods.
14367 (sparc_ravenscar_prepare_to_store): Remove.
14368 (sparc_ravenscar_ops): Redefine.
14369 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14370 methods and destructor. Remove members.
14371 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14372 (ravenscar_thread_target::store_registers)
14373 (ravenscar_thread_target::prepare_to_store): Update.
14374 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14375 Remove.
14376 (struct ppc_ravenscar_powerpc_ops): Derive from
14377 ravenscar_arch_ops.
14378 (ppc_ravenscar_powerpc_ops::fetch_registers)
14379 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14380 (ppc_ravenscar_powerpc_ops): Redefine.
14381 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14382 (ppc_ravenscar_e500_ops::fetch_registers)
14383 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14384 (ppc_ravenscar_e500_ops): Redefine.
14385 * aarch64-ravenscar-thread.c
14386 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14387 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14388 (aarch64_ravenscar_fetch_registers)
14389 (aarch64_ravenscar_store_registers): Now methods.
14390 (aarch64_ravenscar_ops): Redefine.
14391
5b6ea500
TT		 143922019-02-15 Tom Tromey <tromey@adacore.com>
14393
14394 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14395 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14396 (ravenscar_thread_target::stopped_by_watchpoint)
14397 (ravenscar_thread_target::stopped_data_address)
14398 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14399
e397fd39
TT		 144002019-02-15 Tom Tromey <tromey@adacore.com>
14401
14402 * ravenscar-thread.c: Fix some typos.
14403
cc12f4a8
TT		 144042019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14405 Tom Tromey <tromey@adacore.com>
14406
14407 * ada-lang.c (ada_exception_sal): Change addr_string to a
14408 std::string.
14409 (create_ada_exception_catchpoint): Update.
14410
5f486660
TT		 144112019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14412 Tom Tromey <tromey@adacore.com>
14413
14414 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14415 (bp_location_ops): Remove.
14416 (base_breakpoint_allocate_location): Update.
14417 (free_bp_location): Update.
14418 * ada-lang.c (class ada_catchpoint_location)
14419 <ada_catchpoint_location>: Remove ops parameter.
14420 (ada_catchpoint_location_dtor): Remove.
14421 (ada_catchpoint_location_ops): Remove.
14422 (allocate_location_exception): Update.
14423 * breakpoint.h (struct bp_location_ops): Remove.
14424 (class bp_location) <bp_location>: Remove bp_location_ops
14425 parameter.
14426 <~bp_location>: Add destructor.
14427 <ops>: Remove.
14428
b671c7fb
TS		 144292019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14430 Pedro Alves <palves@redhat.com>
14431
14432 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14433 'PATH_MAX'.
14434
8071c5ce
DM		 144352019-02-14 David Michael <fedora.dm0@gmail.com>
14436 Samuel Thibault <samuel.thibault@gnu.org>
14437 Thomas Schwinge <thomas@codesourcery.com>
14438
14439 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14440 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14441
b1041ae0
TS		 144422019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14443
924514e1
TS		 14444 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14445 (check_empty): Use "const char *".
14446
c29ee8d4
TS		 14447 * gnu-nat.c (gnu_nat_target::detach): Instead of
14448 'detach_inferior (pid)' call
14449 'detach_inferior (find_inferior_pid (pid))'.
14450
6c6ef69f
TS		 14451 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14452 'nat/fork-inferior.o'.
14453 * gnu-nat.c: #include "nat/fork-inferior.h".
14454
2d0a338c
TS		 14455 * gnu-nat.c (gnu_nat_target::detach): Instead of
14456 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14457 * gnu-nat.h: #include "inf-child.h".
14458 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14459 'i386_gnu_nat_target::fetch_registers'.
14460 (gnu_store_registers): Rename/move to
14461 'i386_gnu_nat_target::store_registers'.
14462
cabb5f06
TS		 14463 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14464 * gnu-nat.h (mach_thread_info): New function.
14465 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14466
b1041ae0
TS		 14467 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14468
2988d01e
KF		 144692019-02-14 Frederic Konrad <konrad@adacore.com>
14470
14471 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14472
c559d709
JB		 144732019-02-14 Joel Brobecker <brobecker@adacore.com>
14474
14475 * windows-nat.c (windows_add_thread): Add new parameter
14476 "main_thread_p" with default value set to false. Update
14477 function documentation as well as all callers.
14478 (windows_delete_thread): Likewise.
14479 (fake_create_process): Update call to windows_add_thread.
14480 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14481 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14482 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14483 call to windows_delete_thread.
14484
007024cc
SM		 144852019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14486
14487 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14488
f62318e9
JB		 144892019-02-12 John Baldwin <jhb@FreeBSD.org>
14490
14491 * symfile.c (find_separate_debug_file): Use canonical path of
14492 sysroot with child_path instead of gdb_sysroot if it is valid.
14493
cd4b7848
JB		 144942019-02-12 John Baldwin <jhb@FreeBSD.org>
14495
14496 * symfile.c (find_separate_debug_file): Use child_path to
14497 determine if an object file is under a sysroot.
14498
efac4bfe
JB		 144992019-02-12 John Baldwin <jhb@FreeBSD.org>
14500
14501 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14502 unittests/child-path-selftests.c.
14503 * common/pathstuff.c (child_path): New function.
14504 * common/pathstuff.h (child_path): New prototype.
14505 * unittests/child-path-selftests.c: New file.
14506
402d2bfe
JB		 145072019-02-12 John Baldwin <jhb@FreeBSD.org>
14508
14509 * symfile.c (find_separate_debug_file): Look for separate debug
14510 files in debug directories under the sysroot.
14511
1ed9f74e
PW		 145122019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14513
14514 * symtab.h (struct minimal_symbol data_p): New const method.
14515 (struct minimal_symbol text_p): Likewise.
14516 * symtab.c (output_source_filename): Use file name style
14517 to print file name.
14518 (print_symbol_info): Likewise.
14519 (print_msymbol_info): Use address style to print addresses.
14520 Use function name style to print executable text symbols.
14521 (expand_symtab_containing_pc): Use data_p.
14522 (find_pc_sect_compunit_symtab): Likewise.
14523
2636d81d
PW		 145242019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14525
14526 * breakpoint.c (describe_other_breakpoints): Use address style
14527 to print addresses.
14528 (say_where): Likewise.
14529
ac8c53cc
PW		 145302019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14531
14532 * ada-typeprint.c (print_func_type): Print function name
14533 style to print function name.
14534 * c-typeprint.c (c_print_type_1): Likewise.
14535
ea638c43
AH		 145362019-02-11 Alan Hayward <alan.hayward@arm.com>
14537
14538 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14539 for execve.
14540
ab759ca8
PW		 145412019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14542
14543 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14544 type_stack.
14545
aff29d1c
JB		 145462019-02-10 Joel Brobecker <brobecker@adacore.com>
14547
14548 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14549 TYPE_CODE_REF types.
14550
617126bc
JW		 145512019-02-08 Jim Wilson <jimw@sifive.com>
14552
14553 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14554 (riscv_linux_fregset): New.
14555 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14556
46e3ed7f
TT		 145572019-02-07 Tom Tromey <tom@tromey.com>
14558
14559 * thread.c (thread_cancel_execution_command): Update.
14560 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14561 methods.
14562 (struct thread_fsm_ops): Remove.
14563 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14564 (thread_fsm_should_stop, thread_fsm_return_value)
14565 (thread_fsm_set_finished, thread_fsm_finished_p)
14566 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14567 Don't declare.
14568 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14569 * infrun.c (clear_proceed_status_thread)
14570 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14571 (print_stop_event): Update.
14572 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14573 Add constructor.
14574 (step_command_fsm_ops): Remove.
14575 (new_step_command_fsm): Remove.
14576 (step_1): Update.
14577 (step_command_fsm::should_stop): Rename from
14578 step_command_fsm_should_stop.
14579 (step_command_fsm::clean_up): Rename from
14580 step_command_fsm_clean_up.
14581 (step_command_fsm::do_async_reply_reason): Rename from
14582 step_command_fsm_async_reply_reason.
14583 (struct until_next_fsm): Inherit from thread_fsm. Add
14584 constructor.
14585 (until_next_fsm_ops): Remove.
14586 (new_until_next_fsm): Remove.
14587 (until_next_fsm::should_stop): Rename from
14588 until_next_fsm_should_stop.
14589 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14590 (until_next_fsm::do_async_reply_reason): Rename from
14591 until_next_fsm_async_reply_reason.
14592 (struct finish_command_fsm): Inherit from thread_fsm. Add
14593 constructor. Change type of breakpoint.
14594 (finish_command_fsm_ops): Remove.
14595 (new_finish_command_fsm): Remove.
14596 (finish_command_fsm::should_stop): Rename from
14597 finish_command_fsm_should_stop.
14598 (finish_command_fsm::clean_up): Rename from
14599 finish_command_fsm_clean_up.
14600 (finish_command_fsm::return_value): Rename from
14601 finish_command_fsm_return_value.
14602 (finish_command_fsm::do_async_reply_reason): Rename from
14603 finish_command_fsm_async_reply_reason.
14604 (finish_command): Update.
14605 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14606 Add constructor.
14607 (call_thread_fsm_ops): Remove.
14608 (call_thread_fsm::call_thread_fsm): Rename from
14609 new_call_thread_fsm.
14610 (call_thread_fsm::should_stop): Rename from
14611 call_thread_fsm_should_stop.
14612 (call_thread_fsm::should_notify_stop): Rename from
14613 call_thread_fsm_should_notify_stop.
14614 (run_inferior_call, call_function_by_hand_dummy): Update.
14615 * cli/cli-interp.c (should_print_stop_to_console): Update.
14616 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14617 Add constructor. Change type of location_breakpoint,
14618 caller_breakpoint.
14619 (until_break_fsm_ops): Remove.
14620 (new_until_break_fsm): Remove.
14621 (until_break_fsm::should_stop): Rename from
14622 until_break_fsm_should_stop.
14623 (until_break_fsm::clean_up): Rename from
14624 until_break_fsm_clean_up.
14625 (until_break_fsm::do_async_reply_reason): Rename from
14626 until_break_fsm_async_reply_reason.
14627 (until_break_command): Update.
14628 * thread-fsm.c: Remove.
14629 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14630
1a5c2598
TT		 146312019-02-07 Tom Tromey <tom@tromey.com>
14632
14633 * yy-remap.h: Add include guard.
14634 * xtensa-tdep.h: Add include guard.
14635 * xcoffread.h: Rename include guard.
14636 * varobj-iter.h: Add include guard.
14637 * tui/tui.h: Rename include guard.
14638 * tui/tui-winsource.h: Rename include guard.
14639 * tui/tui-wingeneral.h: Rename include guard.
14640 * tui/tui-windata.h: Rename include guard.
14641 * tui/tui-win.h: Rename include guard.
14642 * tui/tui-stack.h: Rename include guard.
14643 * tui/tui-source.h: Rename include guard.
14644 * tui/tui-regs.h: Rename include guard.
14645 * tui/tui-out.h: Rename include guard.
14646 * tui/tui-layout.h: Rename include guard.
14647 * tui/tui-io.h: Rename include guard.
14648 * tui/tui-hooks.h: Rename include guard.
14649 * tui/tui-file.h: Rename include guard.
14650 * tui/tui-disasm.h: Rename include guard.
14651 * tui/tui-data.h: Rename include guard.
14652 * tui/tui-command.h: Rename include guard.
14653 * tic6x-tdep.h: Add include guard.
14654 * target/waitstatus.h: Rename include guard.
14655 * target/wait.h: Rename include guard.
14656 * target/target.h: Rename include guard.
14657 * target/resume.h: Rename include guard.
14658 * target-float.h: Rename include guard.
14659 * stabsread.h: Add include guard.
14660 * rs6000-tdep.h: Add include guard.
14661 * riscv-fbsd-tdep.h: Add include guard.
14662 * regformats/regdef.h: Rename include guard.
14663 * record.h: Rename include guard.
14664 * python/python.h: Rename include guard.
14665 * python/python-internal.h: Rename include guard.
14666 * python/py-stopevent.h: Rename include guard.
14667 * python/py-ref.h: Rename include guard.
14668 * python/py-record.h: Rename include guard.
14669 * python/py-record-full.h: Rename include guard.
14670 * python/py-record-btrace.h: Rename include guard.
14671 * python/py-instruction.h: Rename include guard.
14672 * python/py-events.h: Rename include guard.
14673 * python/py-event.h: Rename include guard.
14674 * procfs.h: Add include guard.
14675 * proc-utils.h: Add include guard.
14676 * p-lang.h: Add include guard.
14677 * or1k-tdep.h: Rename include guard.
14678 * observable.h: Rename include guard.
14679 * nto-tdep.h: Rename include guard.
14680 * nat/x86-linux.h: Rename include guard.
14681 * nat/x86-linux-dregs.h: Rename include guard.
14682 * nat/x86-gcc-cpuid.h: Add include guard.
14683 * nat/x86-dregs.h: Rename include guard.
14684 * nat/x86-cpuid.h: Rename include guard.
14685 * nat/ppc-linux.h: Rename include guard.
14686 * nat/mips-linux-watch.h: Rename include guard.
14687 * nat/linux-waitpid.h: Rename include guard.
14688 * nat/linux-ptrace.h: Rename include guard.
14689 * nat/linux-procfs.h: Rename include guard.
14690 * nat/linux-osdata.h: Rename include guard.
14691 * nat/linux-nat.h: Rename include guard.
14692 * nat/linux-namespaces.h: Rename include guard.
14693 * nat/linux-btrace.h: Rename include guard.
14694 * nat/glibc_thread_db.h: Rename include guard.
14695 * nat/gdb_thread_db.h: Rename include guard.
14696 * nat/gdb_ptrace.h: Rename include guard.
14697 * nat/fork-inferior.h: Rename include guard.
14698 * nat/amd64-linux-siginfo.h: Rename include guard.
14699 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14700 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14701 * nat/aarch64-linux.h: Rename include guard.
14702 * nat/aarch64-linux-hw-point.h: Rename include guard.
14703 * mn10300-tdep.h: Add include guard.
14704 * mips-linux-tdep.h: Add include guard.
14705 * mi/mi-parse.h: Rename include guard.
14706 * mi/mi-out.h: Rename include guard.
14707 * mi/mi-main.h: Rename include guard.
14708 * mi/mi-interp.h: Rename include guard.
14709 * mi/mi-getopt.h: Rename include guard.
14710 * mi/mi-console.h: Rename include guard.
14711 * mi/mi-common.h: Rename include guard.
14712 * mi/mi-cmds.h: Rename include guard.
14713 * mi/mi-cmd-break.h: Rename include guard.
14714 * m2-lang.h: Add include guard.
14715 * location.h: Rename include guard.
14716 * linux-record.h: Rename include guard.
14717 * linux-nat.h: Add include guard.
14718 * linux-fork.h: Add include guard.
14719 * i386-darwin-tdep.h: Rename include guard.
14720 * hppa-linux-offsets.h: Add include guard.
14721 * guile/guile.h: Rename include guard.
14722 * guile/guile-internal.h: Rename include guard.
14723 * gnu-nat.h: Rename include guard.
14724 * gdb-stabs.h: Rename include guard.
14725 * frv-tdep.h: Add include guard.
14726 * f-lang.h: Add include guard.
14727 * event-loop.h: Add include guard.
14728 * darwin-nat.h: Rename include guard.
14729 * cp-abi.h: Rename include guard.
14730 * config/sparc/nm-sol2.h: Rename include guard.
14731 * config/nm-nto.h: Rename include guard.
14732 * config/nm-linux.h: Add include guard.
14733 * config/i386/nm-i386gnu.h: Rename include guard.
14734 * config/djgpp/nl_types.h: Rename include guard.
14735 * config/djgpp/langinfo.h: Rename include guard.
14736 * compile/gcc-cp-plugin.h: Add include guard.
14737 * compile/gcc-c-plugin.h: Add include guard.
14738 * compile/compile.h: Rename include guard.
14739 * compile/compile-object-run.h: Rename include guard.
14740 * compile/compile-object-load.h: Rename include guard.
14741 * compile/compile-internal.h: Rename include guard.
14742 * compile/compile-cplus.h: Rename include guard.
14743 * compile/compile-c.h: Rename include guard.
14744 * common/xml-utils.h: Rename include guard.
14745 * common/x86-xstate.h: Rename include guard.
14746 * common/version.h: Rename include guard.
14747 * common/vec.h: Rename include guard.
14748 * common/tdesc.h: Rename include guard.
14749 * common/selftest.h: Rename include guard.
14750 * common/scoped_restore.h: Rename include guard.
14751 * common/scoped_mmap.h: Rename include guard.
14752 * common/scoped_fd.h: Rename include guard.
14753 * common/safe-iterator.h: Rename include guard.
14754 * common/run-time-clock.h: Rename include guard.
14755 * common/refcounted-object.h: Rename include guard.
14756 * common/queue.h: Rename include guard.
14757 * common/ptid.h: Rename include guard.
14758 * common/print-utils.h: Rename include guard.
14759 * common/preprocessor.h: Rename include guard.
14760 * common/pathstuff.h: Rename include guard.
14761 * common/observable.h: Rename include guard.
14762 * common/netstuff.h: Rename include guard.
14763 * common/job-control.h: Rename include guard.
14764 * common/host-defs.h: Rename include guard.
14765 * common/gdb_wait.h: Rename include guard.
14766 * common/gdb_vecs.h: Rename include guard.
14767 * common/gdb_unlinker.h: Rename include guard.
14768 * common/gdb_unique_ptr.h: Rename include guard.
14769 * common/gdb_tilde_expand.h: Rename include guard.
14770 * common/gdb_sys_time.h: Rename include guard.
14771 * common/gdb_string_view.h: Rename include guard.
14772 * common/gdb_splay_tree.h: Rename include guard.
14773 * common/gdb_setjmp.h: Rename include guard.
14774 * common/gdb_ref_ptr.h: Rename include guard.
14775 * common/gdb_optional.h: Rename include guard.
14776 * common/gdb_locale.h: Rename include guard.
14777 * common/gdb_assert.h: Rename include guard.
14778 * common/filtered-iterator.h: Rename include guard.
14779 * common/filestuff.h: Rename include guard.
14780 * common/fileio.h: Rename include guard.
14781 * common/environ.h: Rename include guard.
14782 * common/common-utils.h: Rename include guard.
14783 * common/common-types.h: Rename include guard.
14784 * common/common-regcache.h: Rename include guard.
14785 * common/common-inferior.h: Rename include guard.
14786 * common/common-gdbthread.h: Rename include guard.
14787 * common/common-exceptions.h: Rename include guard.
14788 * common/common-defs.h: Rename include guard.
14789 * common/common-debug.h: Rename include guard.
14790 * common/cleanups.h: Rename include guard.
14791 * common/buffer.h: Rename include guard.
14792 * common/btrace-common.h: Rename include guard.
14793 * common/break-common.h: Rename include guard.
14794 * cli/cli-utils.h: Rename include guard.
14795 * cli/cli-style.h: Rename include guard.
14796 * cli/cli-setshow.h: Rename include guard.
14797 * cli/cli-script.h: Rename include guard.
14798 * cli/cli-interp.h: Rename include guard.
14799 * cli/cli-decode.h: Rename include guard.
14800 * cli/cli-cmds.h: Rename include guard.
14801 * charset-list.h: Add include guard.
14802 * buildsym-legacy.h: Rename include guard.
14803 * bfin-tdep.h: Add include guard.
14804 * ax.h: Rename include guard.
14805 * arm-linux-tdep.h: Add include guard.
14806 * arm-fbsd-tdep.h: Add include guard.
14807 * arch/xtensa.h: Rename include guard.
14808 * arch/tic6x.h: Add include guard.
14809 * arch/i386.h: Add include guard.
14810 * arch/arm.h: Rename include guard.
14811 * arch/arm-linux.h: Rename include guard.
14812 * arch/arm-get-next-pcs.h: Rename include guard.
14813 * arch/amd64.h: Add include guard.
14814 * arch/aarch64-insn.h: Rename include guard.
14815 * arch-utils.h: Rename include guard.
14816 * annotate.h: Add include guard.
14817 * amd64-darwin-tdep.h: Rename include guard.
14818 * aarch64-linux-tdep.h: Add include guard.
14819 * aarch64-fbsd-tdep.h: Add include guard.
14820 * aarch32-linux-nat.h: Add include guard.
14821
ab9268d2
PW		 148222019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14823
14824 * macrotab.c (macro_define_internal): New function that
14825 factorizes macro_define_object_internal and macro_define_function
14826 code.
14827 (macro_define_object_internal): Use macro_define_internal.
14828 (macro_define_function): Likewise.
14829
bb0da2b4
PW		 148302019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14831
14832 * macrocmd.c (extract_identifier): Return
14833 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14834 callers.
14835
424eb552
JB		 148362019-02-06 John Baldwin <jhb@FreeBSD.org>
14837
14838 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14839
1688cb29
TT		 148402019-02-05 Tom Tromey <tom@tromey.com>
14841
14842 * target.c (target_stack::unpush): Move assertion earlier.
14843
b5eba2d8
TT		 148442019-01-30 Tom Tromey <tom@tromey.com>
14845
14846 PR python/23615:
14847 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14848 (gdbpy_parse_and_eval): Likewise.
14849 * python/python-internal.h (gdbpy_allow_threads): New class.
14850
7054e2ff
JB		 148512019-01-28 John Baldwin <jhb@FreeBSD.org>
14852
14853 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14854 (aarch64_fbsd_fpregmap): Move earlier.
14855 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14856 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14857 instead of individual calls to trad_frame_set_reg_addr.
14858 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14859 earlier.
14860 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14861 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14862 instead of individual calls to trad_frame_set_reg_addr.
14863
36c25ffa
AH		 148642019-01-28 Alan Hayward <alan.hayward@arm.com>
14865
14866 * CONTRIBUTE: Replace contribution list with wiki link.
14867
a0707f3c
TT		 148682019-01-25 Tom Tromey <tom@tromey.com>
14869
14870 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14871
0747795c
TT		 148722019-01-25 Tom Tromey <tom@tromey.com>
14873
14874 * xtensa-linux-nat.c: Fix common/ includes.
14875 * xml-support.h: Fix common/ includes.
14876 * xml-support.c: Fix common/ includes.
14877 * x86-linux-nat.c: Fix common/ includes.
14878 * windows-nat.c: Fix common/ includes.
14879 * varobj.h: Fix common/ includes.
14880 * varobj.c: Fix common/ includes.
14881 * value.c: Fix common/ includes.
14882 * valops.c: Fix common/ includes.
14883 * utils.c: Fix common/ includes.
14884 * unittests/xml-utils-selftests.c: Fix common/ includes.
14885 * unittests/utils-selftests.c: Fix common/ includes.
14886 * unittests/unpack-selftests.c: Fix common/ includes.
14887 * unittests/tracepoint-selftests.c: Fix common/ includes.
14888 * unittests/style-selftests.c: Fix common/ includes.
14889 * unittests/string_view-selftests.c: Fix common/ includes.
14890 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14891 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14892 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14893 * unittests/rsp-low-selftests.c: Fix common/ includes.
14894 * unittests/parse-connection-spec-selftests.c: Fix common/
14895 includes.
14896 * unittests/optional-selftests.c: Fix common/ includes.
14897 * unittests/offset-type-selftests.c: Fix common/ includes.
14898 * unittests/observable-selftests.c: Fix common/ includes.
14899 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14900 * unittests/memrange-selftests.c: Fix common/ includes.
14901 * unittests/memory-map-selftests.c: Fix common/ includes.
14902 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14903 * unittests/function-view-selftests.c: Fix common/ includes.
14904 * unittests/environ-selftests.c: Fix common/ includes.
14905 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14906 * unittests/common-utils-selftests.c: Fix common/ includes.
14907 * unittests/cli-utils-selftests.c: Fix common/ includes.
14908 * unittests/array-view-selftests.c: Fix common/ includes.
14909 * ui-file.c: Fix common/ includes.
14910 * tui/tui-io.c: Fix common/ includes.
14911 * tracepoint.h: Fix common/ includes.
14912 * tracepoint.c: Fix common/ includes.
14913 * tracefile-tfile.c: Fix common/ includes.
14914 * top.h: Fix common/ includes.
14915 * top.c: Fix common/ includes.
14916 * thread.c: Fix common/ includes.
14917 * target/waitstatus.h: Fix common/ includes.
14918 * target/waitstatus.c: Fix common/ includes.
14919 * target.h: Fix common/ includes.
14920 * target.c: Fix common/ includes.
14921 * target-memory.c: Fix common/ includes.
14922 * target-descriptions.c: Fix common/ includes.
14923 * symtab.h: Fix common/ includes.
14924 * symfile.c: Fix common/ includes.
14925 * stap-probe.c: Fix common/ includes.
14926 * spu-linux-nat.c: Fix common/ includes.
14927 * sparc-nat.c: Fix common/ includes.
14928 * source.c: Fix common/ includes.
14929 * solib.c: Fix common/ includes.
14930 * solib-target.c: Fix common/ includes.
14931 * ser-unix.c: Fix common/ includes.
14932 * ser-tcp.c: Fix common/ includes.
14933 * ser-pipe.c: Fix common/ includes.
14934 * ser-base.c: Fix common/ includes.
14935 * selftest-arch.c: Fix common/ includes.
14936 * s12z-tdep.c: Fix common/ includes.
14937 * rust-exp.y: Fix common/ includes.
14938 * rs6000-aix-tdep.c: Fix common/ includes.
14939 * riscv-tdep.c: Fix common/ includes.
14940 * remote.c: Fix common/ includes.
14941 * remote-notif.h: Fix common/ includes.
14942 * remote-fileio.h: Fix common/ includes.
14943 * remote-fileio.c: Fix common/ includes.
14944 * regcache.h: Fix common/ includes.
14945 * regcache.c: Fix common/ includes.
14946 * record-btrace.c: Fix common/ includes.
14947 * python/python.c: Fix common/ includes.
14948 * python/py-type.c: Fix common/ includes.
14949 * python/py-inferior.c: Fix common/ includes.
14950 * progspace.h: Fix common/ includes.
14951 * producer.c: Fix common/ includes.
14952 * procfs.c: Fix common/ includes.
14953 * proc-api.c: Fix common/ includes.
14954 * printcmd.c: Fix common/ includes.
14955 * ppc-linux-nat.c: Fix common/ includes.
14956 * parser-defs.h: Fix common/ includes.
14957 * osdata.c: Fix common/ includes.
14958 * obsd-nat.c: Fix common/ includes.
14959 * nat/x86-linux.c: Fix common/ includes.
14960 * nat/x86-linux-dregs.c: Fix common/ includes.
14961 * nat/x86-dregs.h: Fix common/ includes.
14962 * nat/x86-dregs.c: Fix common/ includes.
14963 * nat/ppc-linux.c: Fix common/ includes.
14964 * nat/mips-linux-watch.h: Fix common/ includes.
14965 * nat/mips-linux-watch.c: Fix common/ includes.
14966 * nat/linux-waitpid.c: Fix common/ includes.
14967 * nat/linux-ptrace.h: Fix common/ includes.
14968 * nat/linux-ptrace.c: Fix common/ includes.
14969 * nat/linux-procfs.c: Fix common/ includes.
14970 * nat/linux-personality.c: Fix common/ includes.
14971 * nat/linux-osdata.c: Fix common/ includes.
14972 * nat/linux-namespaces.c: Fix common/ includes.
14973 * nat/linux-btrace.h: Fix common/ includes.
14974 * nat/linux-btrace.c: Fix common/ includes.
14975 * nat/fork-inferior.c: Fix common/ includes.
14976 * nat/amd64-linux-siginfo.c: Fix common/ includes.
14977 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14978 * nat/aarch64-linux.c: Fix common/ includes.
14979 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14980 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14981 * namespace.h: Fix common/ includes.
14982 * mips-linux-tdep.c: Fix common/ includes.
14983 * minsyms.c: Fix common/ includes.
14984 * mi/mi-parse.h: Fix common/ includes.
14985 * mi/mi-main.c: Fix common/ includes.
14986 * mi/mi-cmd-env.c: Fix common/ includes.
14987 * memrange.h: Fix common/ includes.
14988 * memattr.c: Fix common/ includes.
14989 * maint.h: Fix common/ includes.
14990 * maint.c: Fix common/ includes.
14991 * main.c: Fix common/ includes.
14992 * machoread.c: Fix common/ includes.
14993 * location.c: Fix common/ includes.
14994 * linux-thread-db.c: Fix common/ includes.
14995 * linux-nat.c: Fix common/ includes.
14996 * linux-fork.c: Fix common/ includes.
14997 * inline-frame.c: Fix common/ includes.
14998 * infrun.c: Fix common/ includes.
14999 * inflow.c: Fix common/ includes.
15000 * inferior.h: Fix common/ includes.
15001 * inferior.c: Fix common/ includes.
15002 * infcmd.c: Fix common/ includes.
15003 * inf-ptrace.c: Fix common/ includes.
15004 * inf-child.c: Fix common/ includes.
15005 * ia64-linux-nat.c: Fix common/ includes.
15006 * i387-tdep.c: Fix common/ includes.
15007 * i386-tdep.c: Fix common/ includes.
15008 * i386-linux-tdep.c: Fix common/ includes.
15009 * i386-linux-nat.c: Fix common/ includes.
15010 * i386-go32-tdep.c: Fix common/ includes.
15011 * i386-fbsd-tdep.c: Fix common/ includes.
15012 * i386-fbsd-nat.c: Fix common/ includes.
15013 * guile/scm-type.c: Fix common/ includes.
15014 * guile/guile.c: Fix common/ includes.
15015 * go32-nat.c: Fix common/ includes.
15016 * gnu-nat.c: Fix common/ includes.
15017 * gdbthread.h: Fix common/ includes.
15018 * gdbarch-selftests.c: Fix common/ includes.
15019 * gdb_usleep.c: Fix common/ includes.
15020 * gdb_select.h: Fix common/ includes.
15021 * gdb_bfd.c: Fix common/ includes.
15022 * gcore.c: Fix common/ includes.
15023 * fork-child.c: Fix common/ includes.
15024 * findvar.c: Fix common/ includes.
15025 * fbsd-nat.c: Fix common/ includes.
15026 * event-top.c: Fix common/ includes.
15027 * event-loop.c: Fix common/ includes.
15028 * dwarf2read.c: Fix common/ includes.
15029 * dwarf2loc.c: Fix common/ includes.
15030 * dwarf2-frame.c: Fix common/ includes.
15031 * dwarf-index-cache.c: Fix common/ includes.
15032 * dtrace-probe.c: Fix common/ includes.
15033 * disasm-selftests.c: Fix common/ includes.
15034 * defs.h: Fix common/ includes.
15035 * csky-tdep.c: Fix common/ includes.
15036 * cp-valprint.c: Fix common/ includes.
15037 * cp-support.h: Fix common/ includes.
15038 * cp-support.c: Fix common/ includes.
15039 * corelow.c: Fix common/ includes.
15040 * completer.h: Fix common/ includes.
15041 * completer.c: Fix common/ includes.
15042 * compile/compile.c: Fix common/ includes.
15043 * compile/compile-loc2c.c: Fix common/ includes.
15044 * compile/compile-cplus-types.c: Fix common/ includes.
15045 * compile/compile-cplus-symbols.c: Fix common/ includes.
15046 * command.h: Fix common/ includes.
15047 * cli/cli-dump.c: Fix common/ includes.
15048 * cli/cli-cmds.c: Fix common/ includes.
15049 * charset.c: Fix common/ includes.
15050 * build-id.c: Fix common/ includes.
15051 * btrace.h: Fix common/ includes.
15052 * btrace.c: Fix common/ includes.
15053 * breakpoint.h: Fix common/ includes.
15054 * breakpoint.c: Fix common/ includes.
15055 * ax.h:
15056 (enum agent_op): Fix common/ includes.
15057 * ax-general.c (struct aop_map): Fix common/ includes.
15058 * ax-gdb.c: Fix common/ includes.
15059 * auxv.c: Fix common/ includes.
15060 * auto-load.c: Fix common/ includes.
15061 * arm-tdep.c: Fix common/ includes.
15062 * arch/riscv.c: Fix common/ includes.
15063 * arch/ppc-linux-common.c: Fix common/ includes.
15064 * arch/i386.c: Fix common/ includes.
15065 * arch/arm.c: Fix common/ includes.
15066 * arch/arm-linux.c: Fix common/ includes.
15067 * arch/arm-get-next-pcs.c: Fix common/ includes.
15068 * arch/amd64.c: Fix common/ includes.
15069 * arch/aarch64.c: Fix common/ includes.
15070 * arch/aarch64-insn.c: Fix common/ includes.
15071 * arch-utils.c: Fix common/ includes.
15072 * amd64-windows-tdep.c: Fix common/ includes.
15073 * amd64-tdep.c: Fix common/ includes.
15074 * amd64-sol2-tdep.c: Fix common/ includes.
15075 * amd64-obsd-tdep.c: Fix common/ includes.
15076 * amd64-nbsd-tdep.c: Fix common/ includes.
15077 * amd64-linux-tdep.c: Fix common/ includes.
15078 * amd64-linux-nat.c: Fix common/ includes.
15079 * amd64-fbsd-tdep.c: Fix common/ includes.
15080 * amd64-fbsd-nat.c: Fix common/ includes.
15081 * amd64-dicos-tdep.c: Fix common/ includes.
15082 * amd64-darwin-tdep.c: Fix common/ includes.
15083 * agent.c: Fix common/ includes.
15084 * ada-lang.h: Fix common/ includes.
15085 * ada-lang.c: Fix common/ includes.
15086 * aarch64-tdep.c: Fix common/ includes.
15087
2f5c153e
TT		 150882019-01-25 Tom Tromey <tom@tromey.com>
15089
15090 * common/create-version.sh: Use common/version.h.
15091
adc6a863
PA		 150922019-01-24 Pedro Alves <palves@redhat.com>
15093
15094 * infrun.c (signal_stop, signal_print, signal_program)
15095 (signal_catch, signal_pass): Now arrays instead of pointers.
15096 (update_signals_program_target, do_target_resume)
15097 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15098 * linux-nat.c (linux_nat_target::pass_signals)
15099 (linux_nat_target::create_inferior, linux_nat_target::attach):
15100 Adjust.
15101 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15102 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15103 * procfs.c (procfs_target::pass_signals): Adjust.
15104 * record-full.c (record_full_target::resume): Adjust.
15105 * remote.c (remote_target::pass_signals)
15106 (remote_target::program_signals): Adjust.
15107 * target-debug.h (target_debug_print_signals): Now takes a
15108 gdb::array_view as parameter. Adjust.
15109 * target.h (target_ops) <pass_signals, program_signals>: Replace
15110 pointer and length parameters with gdb::array_view.
15111 (target_pass_signals, target_program_signals): Likewise.
15112 * target-delegates.c: Regenerate.
15113
3046d67a
PA		 151142019-01-24 Pedro Alves <palves@redhat.com>
15115
15116 * common/forward-scope-exit.h
15117 (forward_scope_exit::forward_scope_exit): Pass arguments to
15118 m_bind_function directly, instead of creating a std::bind and
15119 copying that.
15120
353229bf
AH		 151212019-01-24 Alan Hayward <alan.hayward@arm.com>
15122
15123 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15124 for static members.
15125 (pass_in_v_vfp_candidate): Likewise.
15126
311dc83a
TT		 151272019-01-23 Tom Tromey <tom@tromey.com>
15128 Pedro Alves <palves@redhat.com>
15129
15130 * regcache.c (class regcache_invalidator): Remove.
15131 (regcache::raw_write): Use make_scope_exit.
15132
296bd123
TT		 151332019-01-23 Tom Tromey <tom@tromey.com>
15134
15135 * ui-out.h (class ui_out_emit_type): Update comment.
15136
979a0d13
TT		 151372019-01-23 Tom Tromey <tom@tromey.com>
15138
15139 * infrun.c (fetch_inferior_event): Update comment.
15140
d238133d
TT		 151412019-01-23 Tom Tromey <tom@tromey.com>
15142 Pedro Alves <palves@redhat.com>
15143
15144 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15145 parameter.
15146 (fetch_inferior_event): Use SCOPE_EXIT.
15147
15148
9885e6bb
TT		 151492019-01-23 Tom Tromey <tom@tromey.com>
15150 Pedro Alves <palves@redhat.com>
15151
15152 * infrun.c (disable_thread_events): Delete.
15153 (stop_all_threads): Use SCOPE_EXIT.
15154
286526c1
TT		 151552019-01-23 Tom Tromey <tom@tromey.com>
15156 Pedro Alves <palves@redhat.com>
15157
15158 * symfile.c: Include forward-scope-exit.h.
15159 (clear_symtab_users_cleanup): Replace forward declaration with
15160 a FORWARD_SCOPE_EXIT.
15161 (syms_from_objfile_1): Use the forward_scope_exit and
15162 gdb::optional instead of cleanup_function.
15163 (reread_symbols): Use the forward_scope_exit instead of
15164 cleanup_function.
15165 (clear_symtab_users_cleanup): Remove function.
15166
1db93f14
TT		 151672019-01-23 Tom Tromey <tom@tromey.com>
15168 Pedro Alves <palves@redhat.com>
15169
15170 * linux-nat.c: Include scope-exit.h.
15171 (cleanup_target_stop): Remove.
15172 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15173 SCOPE_EXIT.
15174
2cc83d1e
TT		 151752019-01-23 Tom Tromey <tom@tromey.com>
15176 Pedro Alves <palves@redhat.com>
15177
15178 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15179 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15180
694c6bf5
TT		 151812019-01-23 Tom Tromey <tom@tromey.com>
15182 Andrew Burgess <andrew.burgess@embecosm.com>
15183 Pedro Alves <palves@redhat.com>
15184
15185 * infrun.c (fetch_inferior_event): Use scope_exit.
15186 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15187 * top.c (execute_command): Use scope_exit.
15188 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15189 * utils.c (do_bpstat_clear_actions_cleanup)
15190 (make_bpstat_clear_actions_cleanup): Remove.
15191
4c41382a
TT		 151922019-01-23 Tom Tromey <tom@tromey.com>
15193 Pedro Alves <palves@redhat.com>
15194
15195 * infrun.c: Include "common/scope-exit.h"
15196 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15197 (wait_for_inferior): Use SCOPE_EXIT.
15198 (fetch_inferior_event): Use scope_exit.
15199
89f8fb50
TT		 152002019-01-23 Tom Tromey <tom@tromey.com>
15201 Pedro Alves <palves@redhat.com>
15202
15203 * breakpoint.c (create_breakpoint): Remove cleanup.
15204
5419bdae
TT		 152052019-01-23 Tom Tromey <tom@tromey.com>
15206 Andrew Burgess <andrew.burgess@embecosm.com>
15207 Pedro Alves <palves@redhat.com>
15208
e587ef42
PA		 152092019-01-23 Pedro Alves <palves@redhat.com>
15210
15211 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15212
77f0e74c
PA		 152132019-01-23 Pedro Alves <palves@redhat.com>
15214 Andrew Burgess <andrew.burgess@embecosm.com>
15215
15216 * gdbthread.h: Include "common/forward-scope-exit.h".
15217 (scoped_finish_thread_state): Redefine custom class in terms of
15218 forward_scope_exit.
15219
5b9b3e53
PA		 152202019-01-23 Pedro Alves <palves@redhat.com>
15221 Andrew Burgess <andrew.burgess@embecosm.com>
15222
15223 * common/forward-scope-exit.h: New file.
15224
54b65c9b
PA		 152252019-01-23 Pedro Alves <palves@redhat.com>
15226 Andrew Burgess <andrew.burgess@embecosm.com>
15227 Tom Tromey <tom@tromey.com>
15228
15229 * common/scope-exit.h: New file.
15230
cf08fb29
PA		 152312019-01-23 Pedro Alves <palves@redhat.com>
15232
15233 * common/preprocessor.h (ESC): Rename to ...
15234 (ESC_PARENS): ... this.
15235 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15236 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15237
ae73e2e2
TT		 152382019-01-23 Tom Tromey <tom@tromey.com>
15239
15240 * language.h (class scoped_switch_to_sym_language_if_auto):
15241 Initialize m_lang in both cases.
15242
6594e122
AH		 152432019-01-23 Alan Hayward <alan.hayward@arm.com>
15244
15245 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15246 with XCNEW.
15247
a7c9855d
TT		 152482019-01-22 Tom Tromey <tom@tromey.com>
15249
15250 * corelow.c: Do not include sys/file.h.
15251
93cc1d53
TT		 152522019-01-22 Tom Tromey <tom@tromey.com>
15253
15254 * tui/tui-wingeneral.h: Include gdb_curses.h.
15255
38561778
TT		 152562019-01-22 Tom Tromey <tom@tromey.com>
15257
15258 * source-cache.h (class source_cache) <get_source_lines,
15259 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15260
37b3ab5b
TT		 152612019-01-22 Tom Tromey <tom@tromey.com>
15262
15263 * remote-fileio.h (struct remote_target): Declare.
15264
3fabc016
TT		 152652019-01-22 Tom Tromey <tom@tromey.com>
15266
15267 * python/py-arch.c: Do not include py-ref.h.
15268 * python/py-bpevent.c: Do not include py-ref.h.
15269 * python/py-cmd.c: Do not include py-ref.h.
15270 * python/py-continueevent.c: Do not include py-ref.h.
15271 * python/py-event.h: Do not include py-ref.h.
15272 * python/py-evtregistry.c: Do not include py-ref.h.
15273 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15274 * python/py-frame.c: Do not include py-ref.h.
15275 * python/py-framefilter.c: Do not include py-ref.h.
15276 * python/py-function.c: Do not include py-ref.h.
15277 * python/py-infevents.c: Do not include py-ref.h.
15278 * python/py-linetable.c: Do not include py-ref.h.
15279 * python/py-objfile.c: Do not include py-ref.h.
15280 * python/py-param.c: Do not include py-ref.h.
15281 * python/py-prettyprint.c: Do not include py-ref.h.
15282 * python/py-progspace.c: Do not include py-ref.h.
15283 * python/py-symbol.c: Do not include py-ref.h.
15284 * python/py-symtab.c: Do not include py-ref.h.
15285 * python/py-type.c: Do not include py-ref.h.
15286 * python/py-unwind.c: Do not include py-ref.h.
15287 * python/py-utils.c: Do not include py-ref.h.
15288 * python/py-value.c: Do not include py-ref.h.
15289 * python/py-varobj.c: Do not include py-ref.h.
15290 * python/py-xmethods.c: Do not include py-ref.h.
15291 * python/python.c: Do not include py-ref.h.
15292 * varobj.c: Do not include py-ref.h.
15293
6b4d7774
TT		 152942019-01-22 Tom Tromey <tom@tromey.com>
15295
15296 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15297 keyword for bcache.
15298
7af7e9b5
TT		 152992019-01-22 Tom Tromey <tom@tromey.com>
15300
15301 * compile/compile-cplus-types.c: Remove a comment by #include.
15302
951d1049
TT		 153032019-01-22 Tom Tromey <tom@tromey.com>
15304
15305 * compile/gcc-c-plugin.h: Include compile-internal.h.
15306
d65d5705
TT		 153072019-01-22 Tom Tromey <tom@tromey.com>
15308
15309 * stabsread.c (EXTERN): Do not define.
15310 (symnum, next_symbol_text_func, processing_gcc_compilation)
15311 (within_function, global_sym_chain, global_stabs)
15312 (previous_stab_code, this_object_header_files)
15313 (n_this_object_header_files)
15314 (n_allocated_this_object_header_files): Define.
15315 * stabsread.h (EXTERN): Never define. Use "extern".
15316
b6fb1ee5
PW		 153172019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15318
15319 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15320 history_value.
15321
be6d4f74
TT		 153222019-01-21 Tom Tromey <tom@tromey.com>
15323
15324 * ui-out.c: Fix includes.
15325 * tui/tui-source.c: Fix includes.
15326 * target.c: Fix includes.
15327 * remote.c: Fix includes.
15328 * regcache.c: Fix includes.
15329 * python/py-block.c: Fix includes.
15330 * printcmd.c: Fix includes.
15331 * or1k-tdep.c: Fix includes.
15332 * mi/mi-main.c: Fix includes.
15333 * m32r-tdep.c: Fix includes.
15334 * csky-tdep.c: Fix includes.
15335 * compile/compile-cplus-types.c: Fix includes.
15336 * cli/cli-interp.c: Fix includes.
15337
73021deb
AH		 153382019-01-21 Alan Hayward <alan.hayward@arm.com>
15339
15340 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15341 for padding.
15342
7932255d
TT		 153432019-01-16 Tom Tromey <tom@tromey.com>
15344
15345 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15346 earlier.
15347 (struct objfile) <msymbols_range>: Move from top level.
15348 <msymbols>: New method.
15349 (class objfile_msymbols): Remove.
15350 * symtab.c (default_collect_symbol_completion_matches_break_on):
15351 Update.
15352 * symmisc.c (dump_msymbols): Update.
15353 * stabsread.c (scan_file_globals): Update.
15354 * objc-lang.c (info_selectors_command, info_classes_command)
15355 (find_methods): Update.
15356 * minsyms.c (find_solib_trampoline_target): Update.
15357 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15358 * coffread.c (coff_symfile_read): Update.
15359 * ada-lang.c (ada_lookup_simple_minsym)
15360 (ada_collect_symbol_completion_matches): Update.
15361
604b1bfb
TT		 153622019-01-16 Tom Tromey <tom@tromey.com>
15363
15364 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15365 type. Remove no-argument constructor.
15366 <iterator::operator++>: Simplify.
15367 <begin>: Update.
15368 <end>: Use minimal_symbol_count.
15369
f252c6d5
TT		 153702019-01-16 Tom Tromey <tom@tromey.com>
15371
15372 * objfiles.h (struct objfile) <psymtabs>: New method.
15373 (class objfile_psymtabs): Remove.
15374 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15375 typedef.
15376 <range>: New method.
15377 (require_partial_symbols): Change return type.
15378 * psymtab.c (require_partial_symbols)
15379 (psym_expand_symtabs_matching): Update.
15380 * mdebugread.c (parse_partial_symbols): Update.
15381 * dbxread.c (dbx_end_psymtab): Update.
15382
b669c953
TT		 153832019-01-15 Tom Tromey <tom@tromey.com>
15384
15385 * symtab.c (lookup_objfile_from_block)
15386 (lookup_symbol_in_objfile_symtabs)
15387 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15388 (find_line_symtab, info_sources_command)
15389 (default_collect_symbol_completion_matches_break_on)
15390 (make_source_files_completion_list): Update.
15391 * symmisc.c (print_objfile_statistics, dump_objfile)
15392 (maintenance_print_symbols, maintenance_info_symtabs)
15393 (maintenance_check_symtabs, maintenance_info_line_tables):
15394 Update.
15395 * source.c (select_source_symtab)
15396 (forget_cached_source_info_for_objfile): Update.
15397 * objfiles.h (class objfile_compunits): Remove.
15398 (struct objfile) <compunits_range>: New typedef.
15399 (compunits): New method.
15400 * objfiles.c (objfile_relocate1): Update.
15401 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15402 * maint.c (count_symtabs_and_blocks): Update.
15403 * linespec.c (iterate_over_all_matching_symtabs): Update.
15404 * cp-support.c (add_symbol_overload_list_qualified): Update.
15405 * coffread.c (coff_symtab_read): Update.
15406 * ada-lang.c (add_nonlocal_symbols)
15407 (ada_collect_symbol_completion_matches)
15408 (ada_add_global_exceptions): Update.
15409
7e955d83
TT		 154102019-01-15 Tom Tromey <tom@tromey.com>
15411
15412 * progspace.h (program_space) <objfiles_safe_range>: New
15413 typedef.
15414 <objfiles_safe>: New method.
15415 * objfiles.h (class all_objfiles_safe): Remove.
15416 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15417 * jit.c (jit_inferior_exit_hook): Update.
15418
2030c079
TT		 154192019-01-17 Tom Tromey <tom@tromey.com>
15420
15421 * progspace.h (program_space) <objfiles_range>: New typedef.
15422 <objfiles>: New method.
15423 <objfiles_head>: Rename from objfiles.
15424 (object_files): Update.
15425 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15426 * guile/scm-pretty-print.c
15427 (ppscm_find_pretty_printer_from_objfiles): Update.
15428 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15429 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15430 Update.
15431 * python/py-progspace.c (pspy_get_objfiles): Update.
15432 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15433 Update.
15434 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15435 (objfpy_lookup_objfile_by_build_id): Update.
15436 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15437 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15438 Update.
15439 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15440 (expand_symtab_containing_pc, lookup_objfile_from_block)
15441 (lookup_static_symbol, basic_lookup_transparent_type)
15442 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15443 (find_line_symtab, info_sources_command)
15444 (default_collect_symbol_completion_matches_break_on)
15445 (make_source_files_completion_list, find_main_name): Update.
15446 * symmisc.c (print_symbol_bcache_statistics)
15447 (print_objfile_statistics, maintenance_print_symbols)
15448 (maintenance_print_msymbols, maintenance_print_objfiles)
15449 (maintenance_info_symtabs, maintenance_check_symtabs)
15450 (maintenance_expand_symtabs, maintenance_info_line_tables):
15451 Update.
15452 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15453 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15454 (map_overlay_command, unmap_overlay_command)
15455 (simple_overlay_update, expand_symtabs_matching)
15456 (map_symbol_filenames): Update.
15457 * symfile-debug.c (set_debug_symfile): Update.
15458 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15459 Update.
15460 * source.c (select_source_symtab, forget_cached_source_info):
15461 Update.
15462 * solib.c (solib_read_symbols): Update.
15463 * solib-spu.c (append_ocl_sos): Update.
15464 * psymtab.c (maintenance_print_psymbols)
15465 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15466 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15467 * printcmd.c (info_symbol_command): Update.
15468 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15469 Update.
15470 * objfiles.h (class all_objfiles): Remove.
15471 * objfiles.c (have_partial_symbols, have_full_symbols)
15472 (have_minimal_symbols, qsort_cmp, update_section_map)
15473 (shared_objfile_contains_address_p)
15474 (default_iterate_over_objfiles_in_search_order): Update.
15475 * objc-lang.c (info_selectors_command, info_classes_command)
15476 (find_methods): Update.
15477 * minsyms.c (find_solib_trampoline_target): Update.
15478 * maint.c (maintenance_info_sections)
15479 (maintenance_translate_address, count_symtabs_and_blocks):
15480 Update.
15481 * main.c (captured_main_1): Update.
15482 * linux-thread-db.c (try_thread_db_load_from_pdir)
15483 (has_libpthread): Update.
15484 * linespec.c (iterate_over_all_matching_symtabs)
15485 (search_minsyms_for_name): Update.
15486 * jit.c (jit_find_objf_with_entry_addr): Update.
15487 * hppa-tdep.c (find_unwind_entry)
15488 (hppa_lookup_stub_minimal_symbol): Update.
15489 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15490 Update.
15491 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15492 (elf_gnu_ifunc_resolve_by_got): Update.
15493 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15494 * dwarf-index-write.c (save_gdb_index_command): Update.
15495 * cp-support.c (add_symbol_overload_list_qualified): Update.
15496 * breakpoint.c (create_overlay_event_breakpoint)
15497 (create_longjmp_master_breakpoint)
15498 (create_std_terminate_master_breakpoint)
15499 (create_exception_master_breakpoint): Update.
15500 * blockframe.c (find_pc_partial_function): Update.
15501 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15502 (ada_collect_symbol_completion_matches)
15503 (ada_add_global_exceptions): Update.
15504
776489e0
TT		 155052019-01-17 Tom Tromey <tom@tromey.com>
15506
15507 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15508 declare VEC.
15509 (solib_target_parse_libraries): Change return type.
15510 (library_list_start_segment, library_list_start_section)
15511 (library_list_end_library, library_list_start_library); Update.
15512 (solib_target_free_library_list): Remove.
15513 (solib_target_parse_libraries): Remove cleanup. Change return
15514 type.
15515 (solib_target_current_sos): Update.
15516
6471e7d2
TT		 155172019-01-17 Tom Tromey <tromey@bapiya>
15518
15519 * valprint.c: Replace "the the" with "the".
15520 * symtab.c: Replace "the the" with "the".
15521 * solib.c: Replace "the the" with "the".
15522 * solib-dsbt.c: Replace "the the" with "the".
15523 * linespec.c: Replace "the the" with "the".
15524 * dwarf2loc.h: Replace "the the" with "the".
15525 * amd64-windows-tdep.c: Replace "the the" with "the".
15526 * aarch64-tdep.c: Replace "the the" with "the".
15527
c24bdb02
KS		 155282019-01-16 Keith Seitz <keiths@redhat.com>
15529
15530 PR gdb/23773
15531 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15532 <builder>: Rename to ..
15533 <m_builder>: ... this and make private.
15534 (dwarf2_cu::get_builder): New method. Change all users of
15535 `builder' to use this method.
15536 (dwarf2_start_symtab): Move to ...
15537 (dwarf2_cu::start_symtab): ... here. Update all callers
15538 (setup_type_unit_groups): Move to ...
15539 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15540 callers.
15541 (dwarf2_cu::reset_builder): New method.
15542 (process_full_compunit, process_full_type_unit): Use
15543 dwarf2_cu::reset_builder.
15544 (follow_die_offset): Record the ancestor CU if it is different
15545 from the followed DIE's CU.
15546 (follow_die_sig_1): Likewise.
15547
8d64371b
TT		 155482019-01-15 Tom Tromey <tom@tromey.com>
15549
15550 * remote.c (class remote_state) <buf>: Now a char_vector.
15551 <buf_size>: Remove.
15552 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15553 parameter.
15554 (remote_target::getpkt_or_notif_sane_1)
15555 (remote_target::getpkt_sane)
15556 (remote_target::getpkt_or_notif_sane): Likewise.
15557 (class remote_target) <putpkt>: New overload.
15558 (remote_target::read_frame): Change type of "buf_p". Remove
15559 sizeof_p parameter.
15560 (packet_ok): New overload.
15561 (packet_check_result): New overload.
15562 Update all uses.
15563
bb277751
TT		 155642019-01-14 Tom Tromey <tom@tromey.com>
15565
15566 * remote-notif.c (handle_notification, remote_notif_ack)
15567 (remote_notif_parse): Make "buf" const.
15568 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15569 const.
15570 (remote_notif_parse, remote_notif_ack, handle_notification):
15571 Likewise.
15572 * remote.c (remote_notif_stop_parse): Make "buf" const.
15573 (remote_target::remote_parse_stop_reply): Make "buf" const.
15574 (remote_notif_stop_ack): Make "buf" const.
15575
05be00a8
TT		 155762019-01-14 Tom Tromey <tom@tromey.com>
15577
15578 * remote.c (remote_console_output): Make parameter const.
15579
491adeca
TT		 155802019-01-14 Tom Tromey <tom@tromey.com>
15581
15582 * target-debug.h (target_debug_print_signals): Constify.
15583 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15584 * procfs.c (procfs_target::pass_signals): Update.
15585 * linux-nat.c (linux_nat_target::pass_signals): Update.
15586 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15587 * target-delegates.c: Rebuild.
15588 * remote.c (remote_target::program_signals): Update.
15589 (remote_target::pass_signals): Update.
15590 * target.c (target_pass_signals): Constify argument.
15591 (target_program_signals): Likewise.
15592 * target.h (struct target_ops) <pass_signals, program_signals>:
15593 Constify argument.
15594 (target_pass_signals, target_program_signals): Constify argument.
15595
bbd94648
TT		 155962019-01-14 Tom Tromey <tom@tromey.com>
15597
15598 PR tui/28819:
15599 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15600
6f072a10
PFC		 156012019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15602
15603 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15604 field.
15605 * rs6000-tdep.c: Include reggroups.h.
15606 (IS_V_ALIAS_PSEUDOREG): Define.
15607 (rs6000_register_name): Return names for the "vX" aliases.
15608 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15609 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15610 aliases. Call default_register_reggroup_p for all other
15611 pseudo-registers.
15612 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15613 New functions.
15614 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15615 Handle "vX" aliases.
15616 (v_alias_pseudo_register_collect): New function.
15617 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15618 (rs6000_gdbarch_init): Initialize "vX" aliases as
15619 pseudo-registers. Restore registration of
15620 rs6000_pseudo_register_reggroup_p with
15621 set_tdesc_pseudo_register_reggroup_p.
15622
1a782351
MF		 156232019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15624
15625 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15626 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15627 set_gdbarch_num_pseudo_regs.
15628
d73cff18
PW		 156292019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15630
15631 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15632 Remove arg prefixname, add do_set and do_show.
15633 Add member functions set_list and show_list.
15634 * cli/cli-style.c (class cli_style_option): Update accordingly.
15635 (style_set_list): Move to file scope.
15636 (style_show_list): Likewise.
15637 (set_style): Call help_list.
15638 (show_style): Call cmd_show_list.
15639 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15640 Update to use the new macro.
15641
60a90376
JB		 156422019-10-12 Joel Brobecker <brobecker@adacore.com>
15643
15644 * ada-lang.c (_initialize_ada_language): Expand the help text
15645 for the "catch exception" command.
15646
9d7c67bf
PW		 156472019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15648
15649 * symtab.c (matching_obj_sections): Initialize obj,
15650 declare it closer to its usage.
15651
7cf47dc4
TT		 156522019-01-10 Tom Tromey <tom@tromey.com>
15653
15654 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15655 (basic_inf_threads_range): Remove.
15656 (inf_threads_range, inf_non_exited_threads_range)
15657 (safe_inf_threads_range): Use next_adapter.
15658
d3cb6808
KS		 156592019-01-10 Keith Seitz <keiths@redhat.com>
15660
15661 PR gdb/23712
15662 PR symtab/23010
15663 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15664 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15665
63a20375
KS		 156662019-01-10 Keith Seitz <keiths@redhat.com>
15667
15668 PR gdb/23712
15669 PR symtab/23010
15670 * dictionary.c (pending_to_vector): Remove.
15671 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15672 Remove _1 suffix, replacing functions of the same name. Update
15673 all callers.
15674 (dict_create_hashed, dict_create_hashed_expandable)
15675 (dict_create_linear, dict_create_linear_expandable, dict_free)
15676 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15677 Make functions static.
15678
b026f593
KS		 156792019-01-10 Keith Seitz <keiths@redhat.com>
15680
15681 PR gdb/23712
15682 PR symtab/23010
15683 * dictionary.h (struct dictionary): Replace declaration with
15684 multidictionary.
15685 (dict_create_hashed, dict_create_hashed_expandable)
15686 (dict_create_linear, dict_create_linear_expandable)
15687 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15688 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15689 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15690 taking multidictionary argument.
15691 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15692 * block.h (struct block) <dict>: Change to multidictionary
15693 and rename `multidict'.
15694 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15695 symmisc.c: Update all dictionary references to multidictionary.
15696
c7748ee9
KS		 156972019-01-10 Keith Seitz <keiths@redhat.com>
15698
15699 PR gdb/23712
15700 PR symtab/23010
15701 * dictionary.c: Include unordered_map.
15702 (pending_to_vector): New function.
15703 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15704 Rewrite the non-"_1" functions to take vector instead
15705 of linked list.
15706 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15707 "new" _1 versions of the same name.
15708 (multidictionary): Define.
15709 (std::hash<enum language): New definition.
15710 (collate_pending_symbols_by_language, mdict_create_hashed)
15711 (mdict_create_hashed_expandable, mdict_create_linear)
15712 (mdict_create_linear_expandable, mdict_free)
15713 (find_language_dictionary, create_new_language_dictionary)
15714 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15715 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15716 (mdict_size, mdict_empty): New functions.
15717 * dictionary.h (mdict_iterator): Define.
15718
67aa1f3c
PA		 157192019-01-10 Pedro Alves <palves@redhat.com>
15720
15721 * breakpoint.c (read_uploaded_action)
15722 (create_tracepoint_from_upload): Adjust to use
15723 gdb::unique_xmalloc_ptr.
15724 * ctf.c (ctf_write_uploaded_tp):
15725 (SET_ARRAY_FIELD): Use emplace_back.
15726 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15727 * tracefile-tfile.c (tfile_write_uploaded_tp):
15728 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15729 gdb::unique_xmalloc_ptr.
15730 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15731 at_string, cond_string, cmd_strings>: Replace char pointers
15732 with gdb::unique_xmalloc_ptr.
15733
2f667667
PA		 157342019-01-10 Pedro Alves <palves@redhat.com>
15735
15736 * solib-target.c (library_list_start_library): Don't xstrdup name.
15737
36cb7237
PA		 157382019-01-10 Pedro Alves <palves@redhat.com>
15739
15740 * mdebugread.c (parse_partial_symbols): Use
15741 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15742
da584958
AB		 157432019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15744
15745 * linux-fork.c (scoped_switch_fork_info)
15746 <~scoped_switch_fork_info>: Fix incorrect variable name.
15747
1ef8573c
AB		 157482019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15749
15750 * linux-fork.c (scoped_switch_fork_info)
15751 <scoped_switch_fork_info>: Make explicit.
15752 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15753
8d7bcccb
TT		 157542019-01-10 Tom Tromey <tom@tromey.com>
15755
15756 * objfiles.h (objfile::reset_psymtabs): Update.
15757 * objfiles.c (objfile::objfile): Update.
15758 * psymtab.h (psymtab_storage::obstack): Update.
15759 (psymtab_storage::m_obstack): Use gdb::optional.
15760 (class psymtab_storage): Update comment. Remove objfile
15761 parameter.
15762 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15763
b596a3c7
TT		 157642019-01-10 Tom Tromey <tom@tromey.com>
15765
15766 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15767 <free_psymtabs>: Now private.
15768 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15769 (allocate_psymtab): Use new method.
15770
a9342b62
TT		 157712019-01-10 Tom Tromey <tom@tromey.com>
15772
15773 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15774 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15775 * mdebugread.c (parse_partial_symbols): Use
15776 allocate_dependencies.
15777 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15778 allocate_dependencies.
15779 (process_psymtab_comp_unit_reader)
15780 (build_type_psymtab_dependencies): Likewise.
15781 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15782
5af70966
TT		 157832019-01-10 Tom Tromey <tom@tromey.com>
15784
15785 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15786 PSYMBOL_SET_LANGUAGE.
15787 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15788
5923a04c
TT		 157892019-01-10 Tom Tromey <tom@tromey.com>
15790
15791 * psymtab.h (psymtab_storage::obstack): New method.
15792 <m_obstack>: Rename from obstack; now private.
15793 * psymtab.c (psymtab_storage): Update.
15794 * dwarf2read.c (create_addrmap_from_index)
15795 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15796 Update.
15797
6d6a12bf
TT		 157982019-01-10 Tom Tromey <tom@tromey.com>
15799
15800 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15801 * objfiles.h (objfile::reset_psymtabs): New method.
15802
d320c2b5
TT		 158032019-01-10 Tom Tromey <tom@tromey.com>
15804
15805 * symmisc.c (print_symbol_bcache_statistics): Update.
15806 (print_objfile_statistics): Update.
15807 * symfile.c (reread_symbols): Update.
15808 * psymtab.h (class psymtab_storage): New.
15809 * psymtab.c (psymtab_storage): New constructor.
15810 (~psymtab_storage): New destructor.
15811 (require_partial_symbols): Update.
15812 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15813 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15814 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15815 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15816 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15817 (start_psymtab_common, end_psymtab_common)
15818 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15819 (allocate_psymtab): Update.
15820 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15821 Update.
15822 (dump_psymtab_addrmap, maintenance_print_psymbols)
15823 (maintenance_check_psymtabs): Update.
15824 (class objfile_psymtabs): Move to objfiles.h.
15825 * psympriv.h (discard_psymtab): Now inline.
15826 (psymtab_discarder::psymtab_discarder): Update.
15827 (psymtab_discarder::~psymtab_discarder): Update.
15828 (ALL_OBJFILE_PSYMTABS): Rewrite.
15829 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15830 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15831 Remove fields.
15832 <partial_symtabs>: New field.
15833 (class objfile_psymtabs): Move from psymtab.h. Update.
15834 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15835 psymbol_cache.
15836 (objfile::~objfile): Don't destroy psymbol_cache.
15837 * mdebugread.c (parse_partial_symbols): Update.
15838 * dwarf2read.c (create_addrmap_from_index)
15839 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15840 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15841 (add_partial_subprogram, dwarf2_ranges_read): Update.
15842 * dwarf-index-write.c (write_address_map)
15843 (write_one_signatured_type, recursively_write_psymbols)
15844 (class debug_names, class debug_names, write_psymtabs_to_index):
15845 Update.
15846
1d94a5a3
TT		 158472019-01-10 Tom Tromey <tom@tromey.com>
15848
15849 * symtab.h (SYMBOL_SET_NAMES): Update.
15850 (symbol_set_names): Update.
15851 (MSYMBOL_SET_NAMES): Update.
15852 * symtab.c (symbol_set_names): Change argument to be an
15853 objfile_per_bfd_storage.
15854 * psymtab.c (add_psymbol_to_bcache): Update.
15855 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15856
0f14768a
TT		 158572019-01-10 Tom Tromey <tom@tromey.com>
15858
15859 * symtab.c (create_demangled_names_hash): Change argument to be an
15860 objfile_per_bfd_storage.
15861 (symbol_set_names): Update.
15862
6eee24ce
TT		 158632019-01-10 Tom Tromey <tom@tromey.com>
15864
15865 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15866 init_psymbol_list.
15867 * psymtab.c (init_psymbol_list): Do nothing if already called.
15868 * psympriv.h (init_psymbol_list): Add comment.
15869 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15870 init_psymbol_list.
15871 * dbxread.c (dbx_symfile_read): Unconditionally call
15872 init_psymbol_list.
15873
75aedd27
TT		 158742019-01-10 Tom Tromey <tom@tromey.com>
15875
15876 * xcoffread.c (scan_xcoff_symtab): Update.
15877 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15878 "where".
15879 * mdebugread.c (parse_partial_symbols)
15880 (handle_psymbol_enumerators): Update.
15881 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15882 * dbxread.c (read_dbx_symtab): Update.
15883 * psympriv.h (psymbol_placement): New enum.
15884 (add_psymbol_to_list): Update.
15885
939652a5
TT		 158862019-01-10 Tom Tromey <tom@tromey.com>
15887
15888 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15889 static_psymbols parameters.
15890 (scan_xcoff_symtab): Update.
15891 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15892 static_psymbols parameters.
15893 * psympriv.h (start_psymtab_common): Update.
15894 * mdebugread.c (parse_partial_symbols): Update.
15895 * dwarf2read.c (create_partial_symtab): Update.
15896 * dbxread.c (read_dbx_symtab): Update.
15897 (start_psymtab): Remove global_psymbols and static_psymbols
15898 parameters.
15899
baa62830
TT		 159002019-01-10 Tom Tromey <tom@tromey.com>
15901
15902 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15903 * psymtab.c (allocate_psymtab): Add comment.
15904 * psympriv.h (allocate_psymtab): Add comment.
15905 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15906 initializations.
15907 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15908
0e8f53ba
TT		 159092019-01-10 Tom Tromey <tom@tromey.com>
15910
15911 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15912 Don't declare.
15913 * mipsread.c: Include mdebugread.h.
15914 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15915 Declare.
15916 * elfread.c: Include mdebugread.h.
15917
b22a7c6a
TT		 159182019-01-09 Tom Tromey <tom@tromey.com>
15919
15920 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15921 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15922 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15923 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15924 (psym_lookup_symbol, psym_find_last_source_symtab)
15925 (psym_forget_cached_source_info, psym_print_stats)
15926 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15927 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15928 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15929 (psym_find_compunit_symtab_by_address)
15930 (maintenance_print_psymbols, maintenance_info_psymtabs)
15931 (maintenance_check_psymtabs): Use ranged for.
15932 * psymtab.h (class objfile_psymtabs): New.
15933 (require_partial_symbols): Return objfile_psymtabs.
15934 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15935
3b9d3ac2
TT		 159362019-01-09 Tom Tromey <tom@tromey.com>
15937
15938 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15939 (find_pc_mapped_section, list_overlays_command)
15940 (map_overlay_command, unmap_overlay_command)
15941 (simple_overlay_update): Use all_objfiles.
15942 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15943 * printcmd.c (info_symbol_command): Use all_objfiles.
15944 * objfiles.h (ALL_OBJSECTIONS): Remove.
15945 * maint.c (maintenance_translate_address): Use all_objfiles.
15946 * gcore.c (gcore_create_callback): Use all_objfiles.
15947 (objfile_find_memory_regions): Likewise.
15948
8b31193a
TT		 159492019-01-09 Tom Tromey <tom@tromey.com>
15950
15951 * symtab.c (find_line_symtab, info_sources_command)
15952 (make_source_files_completion_list): Use objfile_compunits.
15953 * source.c (select_source_symtab): Use objfile_compunits.
15954 * objfiles.h (struct objfile): Update comment.
15955 (ALL_OBJFILES): Remove.
15956 (ALL_FILETABS): Remove.
15957 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15958 objfile_compunits.
15959
d5da8b3c
TT		 159602019-01-09 Tom Tromey <tom@tromey.com>
15961
15962 * symmisc.c (print_objfile_statistics, dump_objfile)
15963 (maintenance_print_symbols): Use compunit_filetabs.
15964 * source.c (forget_cached_source_info_for_objfile): Use
15965 compunit_filetabs.
15966 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15967 (ALL_FILETABS): Use compunit_filetabs.
15968 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15969 * coffread.c (coff_symtab_read): Use compunit_filetabs.
15970
5accd1a0
TT		 159712019-01-09 Tom Tromey <tom@tromey.com>
15972
15973 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15974 (compunit_filetabs): New.
15975 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15976 compunit_filetabs.
15977 (info_sources_command, make_source_files_completion_list): Remove
15978 declaration.
15979 * symmisc.c (print_objfile_statistics, dump_objfile)
15980 (maintenance_print_symbols): Remove declaration.
15981 (maintenance_info_symtabs): Use compunit_filetabs.
15982 (maintenance_info_line_tables): Likewise.
15983 * source.c (select_source_symtab): Change local variable name.
15984 (forget_cached_source_info_for_objfile): Remove declaration.
15985 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15986 * objfiles.c (objfile_relocate1): Remove declaration.
15987 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15988 declaration.
15989 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15990 * coffread.c (coff_symtab_read): Remove declaration.
15991 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15992 compunit_filetabs.
15993
d8aeb77f
TT		 159942019-01-09 Tom Tromey <tom@tromey.com>
15995
15996 * symtab.c (lookup_objfile_from_block)
15997 (find_pc_sect_compunit_symtab, search_symbols)
15998 (default_collect_symbol_completion_matches_break_on): Use
15999 objfile_compunits.
16000 * objfiles.h (ALL_COMPUNITS): Remove.
16001 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16002 * cp-support.c (add_symbol_overload_list_qualified): Use
16003 objfile_compunits.
16004 * ada-lang.c (ada_collect_symbol_completion_matches)
16005 (ada_add_global_exceptions): Use objfile_compunits.
16006
592553c4
TT		 160072019-01-09 Tom Tromey <tom@tromey.com>
16008
16009 * source.c (select_source_symtab)
16010 (forget_cached_source_info_for_objfile): Remove declaration.
16011 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16012 declaration.
16013 * maint.c (count_symtabs_and_blocks): Remove declaration.
16014 * cp-support.c (add_symbol_overload_list_qualified): Remove
16015 declaration.
16016 * coffread.c (coff_symtab_read): Remove declaration.
16017 * symtab.c (lookup_symbol_in_objfile_symtabs)
16018 (basic_lookup_transparent_type_1): Use objfile_compunits.
16019 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16020 (info_sources_command, search_symbols)
16021 (default_collect_symbol_completion_matches_break_on)
16022 (make_source_files_completion_list): Remove declaration.
16023 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16024 (ada_collect_symbol_completion_matches)
16025 (ada_add_global_exceptions): Remove declaration.
16026 * linespec.c (iterate_over_all_matching_symtabs): Use
16027 objfile_compunits.
16028 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16029 (class objfile_compunits): New.
16030 (ALL_COMPUNITS): Use objfile_compunits.
16031 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16032 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16033 objfile_compunits.
16034 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16035
5325b9bf
TT		 160362019-01-09 Tom Tromey <tom@tromey.com>
16037
16038 * symtab.c (search_symbols)
16039 (default_collect_symbol_completion_matches_break_on): Use
16040 objfile_msymbols.
16041 * ada-lang.c (ada_lookup_simple_minsym)
16042 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16043 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16044 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16045 objfile_msymbols.
16046 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16047 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16048 * objc-lang.c (find_methods): Use objfile_msymbols.
16049 (info_selectors_command, info_classes_command): Likewise.
16050 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16051 * objfiles.h (class objfile_msymbols): New.
16052 (ALL_OBJFILE_MSYMBOLS): Remove.
16053 (ALL_MSYMBOLS): Remove.
16054
cac85af2
TT		 160552019-01-09 Tom Tromey <tom@tromey.com>
16056
16057 * common/next-iterator.h (next_adapter): Add Iterator template
16058 parameter.
16059 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16060 (class all_objfiles_safe): New.
16061 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16062 * objfiles.c (put_objfile_before): Update comment.
16063 (add_separate_debug_objfile): Likewise.
16064 (free_all_objfiles): Use all_objfiles_safe.
16065 (objfile_purge_solibs): Likewise.
16066
aed57c53
TT		 160672019-01-09 Tom Tromey <tom@tromey.com>
16068
16069 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16070 (expand_symtab_containing_pc, lookup_static_symbol)
16071 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16072 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16073 all_objfiles.
16074 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16075 * breakpoint.c (create_overlay_event_breakpoint)
16076 (create_longjmp_master_breakpoint)
16077 (create_std_terminate_master_breakpoint)
16078 (create_exception_master_breakpoint): Use all_objfiles.
16079 * linux-thread-db.c (try_thread_db_load_from_pdir)
16080 (has_libpthread): Use all_objfiles.
16081 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16082 * linespec.c (iterate_over_all_matching_symtabs)
16083 (search_minsyms_for_name): Use all_objfiles.
16084 * maint.c (maintenance_info_sections): Use all_objfiles.
16085 * main.c (captured_main_1): Use all_objfiles.
16086 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16087 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16088 * guile/scm-pretty-print.c
16089 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16090 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16091 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16092 (maintenance_print_msymbols): Use all_objfiles.
16093 * source.c (select_source_symtab): Use all_objfiles.
16094 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16095 * symfile.c (remove_symbol_file_command)
16096 (expand_symtabs_matching, map_symbol_filenames): Use
16097 all_objfiles.
16098 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16099 all_objfiles.
16100 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16101 * objc-lang.c (find_methods): Use all_objfiles.
16102 * objfiles.c (have_partial_symbols, have_full_symbols)
16103 (have_minimal_symbols, qsort_cmp)
16104 (default_iterate_over_objfiles_in_search_order): Use
16105 all_objfiles.
16106 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16107 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16108 (maintenance_check_psymtabs): Use all_objfiles.
16109 (ALL_PSYMTABS): Remove.
16110 * compile/compile-object-run.c (do_module_cleanup): Use
16111 all_objfiles.
16112 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16113 * cp-support.c (add_symbol_overload_list_qualified): Use
16114 all_objfiles.
16115 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16116 Use all_objfiles.
16117 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16118 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16119 all_objfiles.
16120 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16121 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16122 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16123 Uses all_objfiles.
16124 * solib.c (solib_read_symbols): Use all_objfiles
16125
99d89cde
TT		 161262019-01-09 Tom Tromey <tom@tromey.com>
16127
16128 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16129 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16130 all_objfiles.
16131 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16132 * symmisc.c (print_symbol_bcache_statistics)
16133 (print_objfile_statistics, maintenance_print_objfiles)
16134 (maintenance_info_symtabs, maintenance_check_symtabs)
16135 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16136 all_objfiles.
16137 * source.c (forget_cached_source_info): Use all_objfiles.
16138 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16139 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16140 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16141 * objfiles.c (update_section_map): Use all_objfiles.
16142 (shared_objfile_contains_address_p): Likewise.
16143 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16144 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16145
21708325
TT		 161462019-01-09 Tom Tromey <tom@tromey.com>
16147
16148 * common/next-iterator.h: New file.
16149 * objfiles.h (class all_objfiles): New.
16150 (struct objfile_iterator): New.
16151
669e09f6
PW		 161522019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16153
16154 * NEWS: Move the description of the changed "frame", "select-frame",
16155 and "info frame" commands to the Changed commands section.
16156
041be526
SM		 161572019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16158
16159 * gdbtypes.c (check_stub_method_group): Remove handling of old
16160 mangling schemes.
16161 * linespec.c (find_methods): Likewise.
16162 * stabsread.c (read_member_functions): Likewise.
16163 * valops.c (search_struct_method): Likewise.
16164 (value_struct_elt_for_reference): Likewise.
16165 * NEWS: Mention this change.
16166
0e2a2133
AB		 161672019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16168
16169 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16170 print_source_lines.
16171 * source.c (print_source_lines_base): Update line number check.
16172 (print_source_lines): New function.
16173 (source_lines_range::source_lines_range): New function.
16174 * source.h (class source_lines_range): New class.
16175 (print_source_lines): New declaration.
16176
1055a3b4
PW		 161772019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16178
16179 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16180
cfeadda5
TT		 161812019-01-08 Tom Tromey <tom@tromey.com>
16182 Simon Marchi <simon.marchi@ericsson.com>
16183
16184 PR gdb/24060
16185 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16186 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16187 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16188 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16189 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16190 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16191
583068ca
AB		 161922019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16193
16194 * source.c (select_source_symtab): Move header comment to
16195 declaration in source.h.
16196 (forget_cached_source_info_for_objfile): Likewise.
16197 (forget_cached_source_info): Likewise.
16198 (identify_source_line): Likewise.
16199 * source.h (identify_source_line): Move declaration from symtab.h
16200 and add comment from source.c
16201 (print_source_lines): Likewise.
16202 (forget_cached_source_info_for_objfile): Likewise.
16203 (forget_cached_source_info): Likewise.
16204 (select_source_symtab): Likewise.
16205 (enum print_source_lines_flag): Move definition from symtab.h.
16206 * symtab.h (identify_source_line): Move declaration to source.h.
16207 (print_source_lines): Likewise.
16208 (forget_cached_source_info_for_objfile): Likewise.
16209 (forget_cached_source_info): Likewise.
16210 (select_source_symtab): Likewise.
16211 (enum print_source_lines_flag): Move definition to source.h.
16212 * tui/tui-hooks.c: Add 'source.h' include.
16213
ec98a4ad
AB		 162142019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16215
16216 * source.c (print_source_lines_base): Handle requests to print
16217 reverse line number sequences, and guard against empty lines
16218 string.
16219
62ea19c1
AB		 162202019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16221
16222 * source.c (print_source_lines_base): Fix skip of '\r' if next
16223 character is '\n'.
16224
9d30e1fd
TT		 162252019-01-06 Tom Tromey <tom@tromey.com>
16226
16227 * c-exp.y (struct c_parse_state) <macro_original_text,
16228 expansion_obstack>: New member.
16229 (macro_original_text, expansion_obstack): Remove globals.
16230 (scan_macro_expansion, scanning_macro_expansion)
16231 (finished_macro_expansion): Update.
16232 (scan_macro_cleanup): Remove.
16233 (yylex, c_parse): Update.
16234
c65bac38
TT		 162352019-01-06 Tom Tromey <tom@tromey.com>
16236
16237 * c-exp.y (struct c_parse_state) <strings>: New member.
16238 (operator_stoken): Update.
16239
02e12e38
TT		 162402019-01-06 Tom Tromey <tom@tromey.com>
16241
16242 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16243 (union type_stack_elt) <typelist_val>: Now a pointer to
16244 std::vector.
16245 (type_stack_cleanup): Don't declare.
16246 (push_typelist): Update.
16247 * parse.c (pop_typelist): Return a std::vector.
16248 (push_typelist): Take a std::vector.
16249 (follow_types): Update. Do not free args.
16250 (type_stack_cleanup): Remove.
16251 * c-exp.y (struct c_parse_state): New.
16252 (cpstate): New global.
16253 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16254 (nonempty_typelist): Update.
16255 (func_mod): Create a new vector.
16256 (c_parse): Create a c_parse_state.
16257 (check_parameter_typelist): Do not delete params.
16258 (function_method): Update. Do not delete type_list.
16259
f097f5ad
TT		 162602019-01-06 Tom Tromey <tom@tromey.com>
16261
16262 PR gdb/28155:
16263 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16264 check_typedef.
16265 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16266 (print_return_value): Likewise.
16267
d2adf9f1
TT		 162682019-01-05 Tom Tromey <tom@tromey.com>
16269
16270 * contrib/cleanup_check.py: Remove.
16271 * contrib/gcc-with-excheck: Remove.
16272 * contrib/exsummary.py: Remove.
16273 * contrib/excheck.py: Remove.
16274
2eab46b1
JB		 162752019-01-05 Joel Brobecker <brobecker@adacore.com>
16276
16277 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16278 NULL. Initialize tpprev to NULL instead of assigning it
16279 to NULL on the next statement.
16280 * windows-nat.c (windows_delete_thread): Remove check for
16281 main_thread_id before printing thread exit notifications.
16282 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16283 Remove thread ID check against main_thread_id.
16284 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16285 windows_delete_thread.
16286 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16287
48c5e7e2
TT		 162882019-01-04 Tom Tromey <tom@tromey.com>
16289
16290 * compile/compile.c (_initialize_compile): Use upper case for
16291 metasyntactic variables.
16292 * symmisc.c (_initialize_symmisc): Use upper case for
16293 metasyntactic variables.
16294 * psymtab.c (_initialize_psymtab): Use upper case for
16295 metasyntactic variables.
16296 * demangle.c (demangle_command): Use upper case for metasyntactic
16297 variables.
16298 (_initialize_demangler): Likewise.
16299 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16300 variables.
16301
986041cd
TT		 163022019-01-03 Tom Tromey <tom@tromey.com>
16303
16304 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16305
7c711119
TT		 163062019-01-03 Tom Tromey <tom@tromey.com>
16307
16308 * python/py-symtab.c (salpy_str): Update.
16309 (struct salpy_sal_object) <symtab>: Now a PyObject.
16310 (salpy_dealloc): Update.
16311 (del_objfile_sal): Use gdbpy_ref.
16312
1b20edf0
TT		 163132019-01-03 Tom Tromey <tom@tromey.com>
16314
16315 * python/py-type.c (convert_field): Use new_reference. Return
16316 gdbpy_ref.
16317 (make_fielditem): Return gdbpy_ref.
16318 (typy_fields): Update.
16319 (typy_getitem): Update.
16320 (field_name): Return gdbpy_ref. Use new_reference.
16321 (typy_iterator_iternext): Update.
16322
ea41325b
TT		 163232019-01-03 Tom Tromey <tom@tromey.com>
16324
16325 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16326
2a3c71d6
TT		 163272019-01-03 Tom Tromey <tom@tromey.com>
16328
16329 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16330 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16331 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16332 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16333 (pspy_set_type_printers): Likewise.
16334 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16335 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16336 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16337 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16338 (objfpy_set_type_printers): Likewise.
16339
5c329e6a
TT		 163402019-01-03 Tom Tromey <tom@tromey.com>
16341
16342 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16343 (gdbpy_print_stack): Use gdbpy_err_fetch.
16344 * python/python-internal.h (class gdbpy_err_fetch): New class.
16345 (class gdbpy_enter) <m_error_type, m_error_value,
16346 m_error_traceback>: Remove.
16347 <m_error>: New member.
16348 (gdbpy_exception_to_string): Don't declare.
16349 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16350 * python/py-value.c (convert_value_from_python): Use
16351 gdbpy_err_fetch.
16352 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16353 gdbpy_exception_to_string.
16354 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16355 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16356 gdbpy_err_fetch.
16357
169bb27b
AB		 163582019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16359
16360 * linux-nat.c (delete_lwp_cleanup): Delete.
16361 (struct lwp_deleter): New struct.
16362 (lwp_info_up): New typedef.
16363 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16364 lwp_info_up.
16365
a07c8880
AB		 163662019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16367
16368 * linux-fork.c (class scoped_switch_fork_info): New class.
16369 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16370
26089c49
AB		 163712019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16372
16373 * valops.c (find_overload_match): Remove use of null_cleanup, and
16374 calls to do_cleanups.
16375
06d3e5b0
AB		 163762019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16377
16378 * compile/compile-cplus-types.c
16379 (compile_cplus_instance::decl_name): Handle changes to
16380 cp_func_name.
16381 * cp-support.c (cp_func_name): Update header comment, update
16382 return type.
16383 * cp-support.h (cp_func_name): Update return type in declaration.
16384 * valops.c (find_overload_match): Move temp_func local to top
16385 level of function and change its type. Use temp_func to hold and
16386 delete temporary string obtained from cp_func_name.
16387
66644cd3
AB		 163882019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16389
16390 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16391 gdb::char_vector, remove cleanup, and update uses of `msg`.
16392
592d8c0a
JW		 163932019-01-03 Jim Wilson <jimw@sifive.com>
16394
16395 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16396
c55d06ec
TT		 163972019-01-02 Tom Tromey <tom@tromey.com>
16398
16399 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16400 (tdesc_parse_xml): Remove cleanups.
16401 * target-descriptions.h (make_cleanup_free_target_description):
16402 Don't declare.
16403 (target_desc_deleter): New struct.
16404 (target_desc_up): New typedef.
16405 * target-descriptions.c (target_desc_deleter::operator()): Rename
16406 from free_target_description.
16407 (make_cleanup_free_target_description): Remove.
16408
3a6ae42d
TT		 164092019-01-02 Tom Tromey <tom@tromey.com>
16410
16411 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16412 constructor, destructor.
16413 (linespec_parser): Remove typedef.
16414 (~linespec_parser): Rename from linespec_parser_delete.
16415 (linespec_lex_to_end, linespec_complete_label)
16416 (linespec_complete): Update.
16417 (decode_line_full): Remove cleanups.
16418 (decode_line_1): Update.
16419
61fd3e73
TT		 164202019-01-02 Tom Tromey <tom@tromey.com>
16421
16422 * python/python-internal.h (inferior_to_inferior_object): Change
16423 return type.
16424 * python/py-exitedevent.c (create_exited_event_object): Update.
16425 * python/py-inferior.c (inferior_to_inferior_object): Return
16426 gdbpy_ref.
16427 (python_new_inferior, python_inferior_deleted)
16428 (thread_to_thread_object, delete_thread_object)
16429 (build_inferior_list, gdbpy_selected_inferior): Update.
16430 * python/py-infthread.c (create_thread_object): Update. Also fail
16431 if inferior_to_inferior_object fails.
16432
d20172fc
SM		 164332019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16434
16435 * inferior.h (class inferior) <displaced_step_state>: New field.
16436 * infrun.h (struct displaced_step_state): Move here from
16437 infrun.c. Initialize fields, add constructor.
16438 <inf>: Remove field.
16439 <reset>: New method.
16440 * infrun.c (struct displaced_step_inferior_state): Move to
16441 infrun.h.
16442 (displaced_step_inferior_states): Remove.
16443 (get_displaced_stepping_state): Adust.
16444 (displaced_step_in_progress_any_inferior): Adjust.
16445 (displaced_step_in_progress_thread): Adjust.
16446 (displaced_step_in_progress): Adjust.
16447 (add_displaced_stepping_state): Remove.
16448 (get_displaced_step_closure_by_addr): Adjust.
16449 (remove_displaced_stepping_state): Remove.
16450 (infrun_inferior_exit): Call displaced_step_state.reset.
16451 (use_displaced_stepping): Don't check for NULL.
16452 (displaced_step_prepare_throw): Call
16453 get_displaced_stepping_state.
16454 (displaced_step_fixup): Don't check for NULL.
16455 (prepare_for_detach): Don't check for NULL.
16456
e3319240
PW		 164572019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16458
16459 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16460 in case of call that did not complete.
16461
5d36dfb9
AU		 164622019-01-02 Andrey Utkin <autkin@undo.io>
16463
16464 * symfile.c (find_separate_debug_file): Fix search of debug files for
16465 remote debuggee.
16466
8833fbf0
TT		 164672019-01-02 Tom Tromey <tom@tromey.com>
16468
16469 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16470 indentation.
16471 * python/py-frame.c (frapy_older): Remove cast.
16472 (frapy_newer): Likewise.
16473 * python/py-breakpoint.c (local_setattro): Remove cast.
16474 * python/py-arch.c (archpy_name): Remove local variable.
16475 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16476
4ada3dfd
JB		 164772019-01-02 Joel Brobecker <brobecker@adacore.com>
16478
16479 * unittests/basic_string_view/element_access/char/empty.cc:
16480 Fix year range in copyright header.
16481
113b7b81
AB		 164822019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16483
16484 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16485 Delete.
16486 <operator==>: Update with for removed field.
16487 <hash>: Likewise.
16488 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16489 <isa_features>: ...this.
16490 <abi_features>: New field.
16491 (riscv_isa_flen): Update comment.
16492 (riscv_abi_xlen): New declaration.
16493 (riscv_abi_flen): New declaration.
16494 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16495 isa_features.
16496 (riscv_abi_xlen): New function.
16497 (riscv_isa_flen): Update to get answer from isa_features.
16498 (riscv_abi_flen): New function.
16499 (riscv_has_fp_abi): Update to get answer from abi_features.
16500 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16501 xlen and flen.
16502 (riscv_call_info) <xlen, flen>: Update comment.
16503 (riscv_call_arg_struct): Remove invalid assertions
16504 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16505 is removed.
16506 (riscv_gdbarch_init): Gather isa features and abi features
16507 separately, ensure both match on the gdbarch when reusing an old
16508 gdbarch. Relax an error check to allow 32-bit abi float to run on
16509 a target with 64-bit float hardware.
16510
b18ca514
PW		 165112019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16512
16513 * source.c (search_command_helper): Stop reverse search
16514 when line 1 has been searched.
16515
ec70d8db
PW		 165162019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16517
16518 * record-full.c (record_full_base_target::close): Rewrite
16519 record_full_core_buf_list free logic.
16520
5b38f9c1
PW		 165212019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16522
16523 * break-catch-syscall.c (print_one_catch_syscall): xfree
16524 the last text.
16525
66d91b39
JB		 165262019-01-01 Joel Brobecker <brobecker@adacore.com>
16527
16528 * top.c (print_gdb_version): Update Copyright year in version
16529 message.
16530
42a4f53d
JB		 165312019-01-01 Joel Brobecker <brobecker@adacore.com>
16532
16533 Update copyright year range in all GDB files.
16534
7e955d83 165352019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16536
5bbd631d 16537 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16538
5bbd631d 16539For older changes see ChangeLog-2018.
c906108c
SS		 16540\f
16541Local Variables:
16542mode: change-log
16543left-margin: 8
16544fill-column: 74
16545version-control: never
57da7796 16546coding: utf-8
c906108c 16547End:
5bbd631d 16548
GDB Binutils - Deliverables
This page took 3.155372 seconds and 4 git commands to generate.