projects / deliverable / binutils-gdb.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
record-btrace: fix insn range in function call history
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
7acbe133
MM		 12014-01-16 Markus Metzger <markus.t.metzger@intel.com>
2
3 * record-btrace.c (btrace_call_history_insn_range): Print
4 insn range as [begin, end].
5
23a7fe75
MM		 62014-01-16 Markus Metzger <markus.t.metzger@intel.com>
7
8 * btrace.h (struct btrace_func_link): New.
9 (enum btrace_function_flag): New.
10 (struct btrace_inst): Rename to ...
11 (struct btrace_insn): ...this. Update all users.
12 (struct btrace_func) <ibegin, iend>: Remove.
13 (struct btrace_func_link): New.
14 (struct btrace_func): Rename to ...
15 (struct btrace_function): ...this. Update all users.
16 (struct btrace_function) <segment, flow, up, insn, insn_offset)
17 (number, level, flags>: New.
18 (struct btrace_insn_iterator): Rename to ...
19 (struct btrace_insn_history): ...this.
20 Update all users.
21 (struct btrace_insn_iterator, btrace_call_iterator): New.
22 (struct btrace_target_info) <btrace, itrace, ftrace>: Remove.
23 (struct btrace_target_info) <begin, end, level>
24 <insn_history, call_history>: New.
25 (btrace_insn_get, btrace_insn_number, btrace_insn_begin)
26 (btrace_insn_end, btrace_insn_prev, btrace_insn_next)
27 (btrace_insn_cmp, btrace_find_insn_by_number, btrace_call_get)
28 (btrace_call_number, btrace_call_begin, btrace_call_end)
29 (btrace_call_prev, btrace_call_next, btrace_call_cmp)
30 (btrace_find_function_by_number, btrace_set_insn_history)
31 (btrace_set_call_history): New.
32 * btrace.c (btrace_init_insn_iterator)
33 (btrace_init_func_iterator, compute_itrace): Remove.
34 (ftrace_print_function_name, ftrace_print_filename)
35 (ftrace_skip_file): Change
36 parameter to const.
37 (ftrace_init_func): Remove.
38 (ftrace_debug): Use new btrace_function fields.
39 (ftrace_function_switched): Also consider gaining and
40 losing symbol information).
41 (ftrace_print_insn_addr, ftrace_new_call, ftrace_new_return)
42 (ftrace_new_switch, ftrace_find_caller, ftrace_new_function)
43 (ftrace_update_caller, ftrace_fixup_caller, ftrace_new_tailcall):
44 New.
45 (ftrace_new_function): Move. Remove debug print.
46 (ftrace_update_lines, ftrace_update_insns): New.
47 (ftrace_update_function): Check for call, ret, and jump.
48 (compute_ftrace): Renamed to ...
49 (btrace_compute_ftrace): ...this. Rewritten to compute call
50 stack.
51 (btrace_fetch, btrace_clear): Updated.
52 (btrace_insn_get, btrace_insn_number, btrace_insn_begin)
53 (btrace_insn_end, btrace_insn_prev, btrace_insn_next)
54 (btrace_insn_cmp, btrace_find_insn_by_number, btrace_call_get)
55 (btrace_call_number, btrace_call_begin, btrace_call_end)
56 (btrace_call_prev, btrace_call_next, btrace_call_cmp)
57 (btrace_find_function_by_number, btrace_set_insn_history)
58 (btrace_set_call_history): New.
59 * record-btrace.c (require_btrace): Use new btrace thread
60 info fields.
61 (record_btrace_info, btrace_insn_history)
62 (record_btrace_insn_history, record_btrace_insn_history_range):
63 Use new btrace thread info fields and new iterator.
64 (btrace_func_history_src_line): Rename to ...
65 (btrace_call_history_src_line): ...this. Use new btrace
66 thread info fields.
67 (btrace_func_history): Rename to ...
68 (btrace_call_history): ...this. Use new btrace thread info
69 fields and new iterator.
70 (record_btrace_call_history, record_btrace_call_history_range):
71 Use new btrace thread info fields and new iterator.
72
8372a7cb
MM		 732014-01-16 Markus Metzger <markus.t.metzger@intel.com>
74
75 * frame.h (frame_id_build_unavailable_stack_special): New.
76 * frame.c (frame_id_build_unavailable_stack_special): New.
77
c2170eef
MM		 782014-01-16 Markus Metzger <markus.t.metzger@intel.com>
79
80 * amd64-tdep.c (amd64_classify_insn_at, amd64_insn_is_call)
81 (amd64_insn_is_ret, amd64_insn_is_jump, amd64_jmp_p): New.
82 (amd64_init_abi): Add insn_is_call, insn_is_ret, and insn_is_jump
83 to gdbarch.
84 * i386-tdep.c (i386_insn_is_call, i386_insn_is_ret)
85 (i386_insn_is_jump, i386_jmp_p): New.
86 (i386_gdbarch_init): Add insn_is_call, insn_is_ret, and
87 insn_is_jump to gdbarch.
88 * gdbarch.sh (insn_is_call, insn_is_ret, insn_is_jump): New.
89 * gdbarch.h: Regenerated.
90 * gdbarch.c: Regenerated.
91 * arch-utils.h (default_insn_is_call, default_insn_is_ret)
92 (default_insn_is_jump): New.
93 * arch-utils.c (default_insn_is_call, default_insn_is_ret)
94 (default_insn_is_jump): New.
95
864089d2
MM		 962014-01-16 Markus Metzger <markus.t.metzger@intel.com>
97
98 * common/btrace-common.h (btrace_read_type) <btrace_read_all>:
99 Change to ...
100 (btrace_read_type) <BTRACE_READ_ALL>: ... this. Update users.
101 (btrace_read_type) <btrace_read_new>: Change to ...
102 (btrace_read_type) <BTRACE_READ_NEW>: ... this. Update users.
103
ed9edfb5
MM		 1042014-01-16 Markus Metzger <markus.t.metzger@intel.com>
105
106 * common/linux-btrace.c (linux_read_btrace): Free trace from
107 previous iteration.
108
fbcbc3fd
DE		 1092014-01-15 Doug Evans <dje@google.com>
110
111 * dwarf2read.c (open_and_init_dwp_file): Use pulongest to print
112 uint32_t.
113
3d548a53
TT		 1142014-01-15 Tom Tromey <tromey@redhat.com>
115
116 * dbxread.c (process_one_symbol): Use set_objfile_main_name.
117 * dwarf2read.c (read_partial_die): Use set_objfile_main_name.
118 * objfiles.c (get_objfile_bfd_data): Initialize language_of_main.
119 (set_objfile_main_name): New function.
120 * objfiles.h (struct objfile_per_bfd_storage) <name_of_main,
121 language_of_main>: New fields.
122 (set_objfile_main_name): Declare.
123 * symtab.c (find_main_name): Loop over objfiles to find the main
124 name and language.
125 (set_main_name): Now static.
126 (get_main_info): Add comment.
127 * symtab.h (set_main_name): Don't declare.
128
32ac0d11
TT		 1292014-01-15 Tom Tromey <tromey@redhat.com>
130
131 * symtab.c (main_progspace_key): New global.
132 (struct main_info): New.
133 (name_of_main, language_of_main): Remove.
134 (get_main_info, main_info_cleanup): New function.
135 (set_main_name, main_name, main_language): Use get_main_info.
136 (_initialize_symtab): Initialize main_progspace_key.
137
9e6c82ad
TT		 1382014-01-15 Tom Tromey <tromey@redhat.com>
139
140 * dbxread.c (process_one_symbol): Update.
141 * dwarf2read.c (read_partial_die): Update.
142 * symfile.c (set_initial_language): Call main_language.
143 * symtab.c (language_of_main): Now static.
144 (set_main_name): Add 'lang' parameter.
145 (find_main_name): Update.
146 (main_language): New function.
147 (symtab_observer_executable_changed): Update.
148 * symtab.h (set_main_name): Update.
149 (language_of_main): Remove.
150 (main_language): Declare.
151
6ef55de7
TT		 1522014-01-15 Tom Tromey <tromey@redhat.com>
153
154 * symfile.c (init_entry_point_info): Use new "initialized" field.
155 Update.
156 * objfiles.h (struct entry_point) <initialized>: New field.
157 (struct objfile_per_bfd_storage) <ei>: New field, moved from...
158 (struct objfile) <ei>: ...here. Remove.
159 * objfiles.c (entry_point_address_query): Update.
160
53eddfa6
TT		 1612014-01-15 Tom Tromey <tromey@redhat.com>
162
163 * objfiles.c (entry_point_address_query): Relocate entry point
164 address.
165 (objfile_relocate1): Do not relocate entry point address.
166 * objfiles.h (struct entry_info) <entry_point>: Update comment.
167 <the_bfd_section_index>: New field.
168 * symfile.c (init_entry_point_info): Find the entry point's
169 section.
170
d56e56aa
TT		 1712014-01-15 Tom Tromey <tromey@redhat.com>
172
173 * solib-frv.c (enable_break): Use entry_point_address_query.
174
33a97bbe
OJ		 1752014-01-15 Omair Javaid <omair.javaid@linaro.org>
176
177 * NEWS: Add note on improved process record-replay on
178 arm*-linux* targets.
179
c6ec2b30
OJ		 1802014-01-15 Omair Javaid <omair.javaid@linaro.org>
181
182 * arm-tdep.c (enum arm_record_result): New enum.
183 (arm_record_unsupported_insn): New function.
184 (arm_record_coproc_data_proc): Removed.
185 (thumb2_record_ld_st_multiple): New function.
186 (thumb2_record_ld_st_dual_ex_tbb): New function.
187 (thumb2_record_data_proc_sreg_mimm): New function.
188 (thumb2_record_ps_dest_generic): New function.
189 (thumb2_record_branch_misc_cntrl): New function.
190 (thumb2_record_str_single_data): New function.
191 (thumb2_record_ld_mem_hints): New function.
192 (thumb2_record_ld_word): New function.
193 (thumb2_record_lmul_lmla_div): New function.
194 (thumb2_record_decode_insn_handler): New function.
195 (decode_insn): Add thumb32 instruction handlers.
196
97dfe206
OJ		 1972014-01-15 Omair Javaid <omair.javaid@linaro.org>
198
199 * arm-linux-tdep.c: Include "record-full.h" and "linux-record.h".
200 (struct arm_linux_record_tdep): Declare.
201 (arm_canonicalize_syscall): New function.
202 (arm_all_but_pc_registers_record): New function.
203 (arm_linux_syscall_record): New function.
204 (arm_linux_init_abi): Add syscall recording constructs.
205 * arm-tdep.c (thumb_record_ldm_stm_swi): Update thumb syscall
206 decoding. (arm_record_coproc_data_proc): Update arm syscall
207 decoding.
208 * arm-tdep.h (struct gdbarch_tdep) <arm_swi_record>: Remove.
209 <arm_syscall_record>: New field.
210 * configure.tgt (arm*-*-linux*): Add linux-record.o to
211 gdb_target_obs.
212
9904a494
OJ		 2132014-01-15 Omair Javaid <omair.javaid@linaro.org>
214
215 * arm-tdep.c (thumb_record_misc): Update to use sp as base
216 register for push instruction recording.
217
f969241e
OJ		 2182014-01-15 Omair Javaid <omair.javaid@linaro.org>
219
220 * arm-tdep.c (thumb_record_misc): Update to correct logical
221 error while recording ldm, ldmia and pop instructions.
222
bfbbec00
OJ		 2232014-01-15 Omair Javaid <omair.javaid@linaro.org>
224
225 * arm-tdep.c (struct arm_mem_r) <addr>: Change type to uint32_t.
226
e40adcc9
PA		 2272014-01-15 Pedro Alves <palves@redhat.com>
228
229 * go32-nat.c (go32_open, go32_close, go32_attach, go32_detach)
230 (go32_resume, go32_fetch_registers, store_register)
231 (go32_store_registers, go32_prepare_to_store)
232 (go32_xfer_memory, go32_files_info, go32_kill_inferior)
233 (go32_create_inferior, go32_can_run, go32_terminal_init)
234 (go32_terminal_inferior, go32_terminal_ours): Delete forward
235 declarations.
236
b0a16e66
TT		 2372014-01-15 Tom Tromey <tromey@redhat.com>
238
239 * target.h (async_callback_ftype): New typedef.
240 (struct target_ops) <to_async>: Use it.
241
bf7105a4
JB		 2422014-01-15 Joel Brobecker <brobecker@adacore.com>
243
244 * python/py-value.c (get_field_type): Remove unnecessary curly
245 braces for single-statement if block.
246
a8f35c2e
JB		 2472014-01-15 Joel Brobecker <brobecker@adacore.com>
248
249 * python/py-type.c (convert_field): Add missing empty line
250 after declarations.
251
bb4142cf
DE		 2522014-01-14 Doug Evans <dje@google.com>
253
254 * symfile.h (expand_symtabs_matching): Renamed from
255 expand_partial_symbol_names. Update prototype.
256 (map_symbol_filenames): Renamed from map_partial_symbol_filenames.
257 * symfile.c (expand_symtabs_matching): Renamed from
258 expand_partial_symbol_names. New args file_matcher, kind.
259 Rename arg fun to symbol_matcher.
260 (map_symbol_filenames): Renamed from map_partial_symbol_filenames.
261 * ada-lang.c (ada_complete_symbol_matcher): Renamed from
262 ada_expand_partial_symbol_name.
263 (ada_make_symbol_completion_list): Update to call
264 expand_symtabs_matching.
265 (ada_add_global_exceptions): Call expand_symtabs_matching.
266 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update to
267 call map_symbol_filenames.
268 * symtab.c (sources_info): Update to call map_symbol_filenames.
269 (search_symbols): Call expand_symtabs_matching.
270 (symbol_completion_matcher): Renamed from expand_partial_symbol_name.
271 (default_make_symbol_completion_list_break_on): Update to call
272 expand_symtabs_matching.
273 (make_source_files_completion_list): Update to call
274 map_symbol_filenames.
275
206f2a57
DE		 2762014-01-14 Doug Evans <dje@google.com>
277
278 * symfile.h (expand_symtabs_file_matcher_ftype): New typedef.
279 (expand_symtabs_symbol_matcher_ftype): New typedef.
280 (quick_symbol_functions.expand_symtabs_matching): Update to use.
281 expand_symtabs_file_matcher_ftype, expand_symtabs_symbol_matcher_ftype.
282 * symfile.c (expand_partial_symbol_names): Update to use
283 expand_symtabs_symbol_matcher_ftype.
284 * dwarf2read.c (dw2_expand_symtabs_matching): Update to use
285 expand_symtabs_file_matcher_ftype, expand_symtabs_symbol_matcher_ftype.
286 Arg name_matcher renamed to symbol_matcher.
287 * psymtab.c (recursively_search_psymtabs): Update to use
288 expand_symtabs_symbol_matcher_ftype. Arg name_matcher renamed to
289 sym_matcher.
290 (expand_symtabs_matching_via_partial): Update to use
291 expand_symtabs_file_matcher_ftype, expand_symtabs_symbol_matcher_ftype.
292 Arg name_matcher renamed to symbol_matcher.
293
540c2971
DE		 2942014-01-14 Doug Evans <dje@google.com>
295
296 * psymtab.c (expand_partial_symbol_names): Delete, moved to symfile.c.
297 (map_partial_symbol_filenames): Ditto.
298 * psymtab.h (expand_partial_symbol_names): Delete, moved to symfile.h.
299 (map_partial_symbol_filenames): Ditto.
300 * symfile.c (expand_partial_symbol_names): Moved here from psymtab.c.
301 (map_partial_symbol_filenames): Ditto.
302 * symfile.h (expand_partial_symbol_names): Moved here from psymtab.h.
303 (map_partial_symbol_filenames): Ditto.
304 * symtab.c: Delete #include "psymtab.h".
305
8213266a
PA		 3062014-01-14 Pedro Alves <palves@redhat.com>
307 Tom Tromey <tromey@redhat.com>
308
309 * infrun.c (use_displaced_stepping): Use find_record_target
310 instead of RECORD_IS_USED.
311 (adjust_pc_after_break): Use record_full_is_used instead of
312 RECORD_IS_USED.
313 * record-btrace.c (record_btrace_open): Call record_preopen
314 instead of checking RECORD_IS_USED.
315 * record-full.c (record_full_shortname)
316 (record_full_core_shortname): New globals.
317 (record_full_is_used): New function.
318 (find_full_open): Call record_preopen instead of checking
319 RECORD_IS_USED.
320 (init_record_full_ops): Set the target's shortname to
321 record_full_shortname.
322 (init_record_full_core_ops): Set the target's shortname to
323 record_full_core_shortname.
324 * record-full.h (record_full_is_used): Declare.
325 * record.c (find_record_target): Make extern.
326 (record_preopen): New function.
327 * record.h (RECORD_IS_USED): Delete macro.
328 (find_record_target, record_preopen): Declare functions.
329
7ec1862d
YQ		 3302014-01-14 Yao Qi <yao@codesourcery.com>
331
332 * gdbarch.sh (core_xfer_shared_libraries): Change its argument
333 'len''s type to ULONGEST.
334 (core_xfer_shared_libraries_aix): Likewise.
335 * gdbarch.c, gdbarch.h: Regenerated.
336 * i386-cygwin-tdep.c (windows_core_xfer_shared_libraries):
337 Change type of 'len' to ULONGEST.
338 * rs6000-aix-tdep.c (rs6000_aix_ld_info_to_xml): Likewise.
339 (rs6000_aix_core_xfer_shared_libraries_aix): Likewise.
340
dea80a27
YQ		 3412014-01-14 Yao Qi <yao@codesourcery.com>
342
343 * common/linux-osdata.c (linux_xfer_osdata_processes): Change
344 type of 'len' to ULONGEST.
345 (linux_xfer_osdata_processgroups): Likewise.
346 (linux_xfer_osdata_threads): Likewise.
347 (linux_xfer_osdata_fds): Likewise.
348 (linux_xfer_osdata_isockets): Likewise.
349 (linux_xfer_osdata_shm): Likewise.
350 (linux_xfer_osdata_sem): Likewise.
351 (linux_xfer_osdata_msg): Likewise.
352 (linux_common_xfer_osdata): Likewise.
353 (struct osdata_type) <getter>: Likewise.
354 * common/linux-osdata.h (linux_common_xfer_osdata): Update
355 the declaration.
356
b55e14c7
YQ		 3572014-01-14 Yao Qi <yao@codesourcery.com>
358
359 * target.h (target_xfer_partial_ftype): Update.
360 (struct target_ops) <to_xfer_partial>: Change 'len' type to
361 ULONGEST.
362 * aix-thread.c (aix_thread_xfer_partial): Change type of
363 argument 'len' to ULONGEST.
364 * auxv.c (procfs_xfer_auxv): Likewise.
365 (ld_so_xfer_auxv): Likewise.
366 (memory_xfer_auxv): Likewise.
367 * bfd-target.c (target_bfd_xfer_partial): Likewise.
368 * bsd-kvm.c (bsd_kvm_xfer_partial): Likewise.
369 * bsd-uthread.c (bsd_uthread_xfer_partial): Likewise.
370 * corelow.c (core_xfer_partial): Likewise.
371 * ctf.c (ctf_xfer_partial): Likewise.
372 * darwin-nat.c (darwin_read_write_inferior): Likewise. Use
373 '%u'.
374 (darwin_read_dyld_info): Likewise.
375 (darwin_xfer_partial): Likewise.
376 * exec.c (section_table_xfer_memory_partial): Likewise.
377 (exec_xfer_partial): Likewise.
378 * exec.h (section_table_xfer_memory_partial): Update
379 declaration.
380 * gnu-nat.c (gnu_xfer_memory): Likewise. Call pulongest
381 instead of plongest.
382 (gnu_xfer_partial): Likewise.
383 * ia64-hpux-nat.c (ia64_hpux_xfer_memory): Likewise.
384 (ia64_hpux_xfer_solib_got): Likewise.
385 (ia64_hpux_xfer_partial): Likewise.
386 * ia64-linux-nat.c (ia64_linux_xfer_partial):
387 * inf-ptrace.c (inf_ptrace_xfer_partial):
388 * inf-ttrace.c (inf_ttrace_xfer_partial):
389 * linux-nat.c (linux_xfer_siginfo): Likewise.
390 (linux_nat_xfer_partial): Likewise.
391 (spu_enumerate_spu_ids, linux_proc_xfer_spu): Likewise.
392 (linux_nat_xfer_osdata, linux_xfer_partial): Likewise.
393 * monitor.c (monitor_xfer_memory): Likewise.
394 (monitor_xfer_partial): Likewise.
395 * procfs.c (procfs_xfer_partial): Likewise.
396 * record-full.c (record_full_xfer_partial): Likewise.
397 (record_full_core_xfer_partial): Likewise.
398 * remote-sim.c (gdbsim_xfer_memory): Likewise. Call pulongest
399 instead of plongest.
400 (gdbsim_xfer_partial): Likewise.
401 * remote.c (remote_xfer_partial): Likewise.
402 * rs6000-aix-tdep.c (rs6000_aix_ld_info_to_xml): Likewise.
403 * rs6000-aix-tdep.h (rs6000_aix_ld_info_to_xml): Update
404 declaration.
405 * rs6000-nat.c (rs6000_xfer_partial): Likewise.
406 (rs6000_xfer_shared_libraries): Likewise.
407 * sol-thread.c (sol_thread_xfer_partial): Likewise.
408 * sparc-nat.c (sparc_xfer_wcookie): Likewise.
409 (sparc_xfer_partial): Likewise.
410 * spu-linux-nat.c (spu_proc_xfer_spu): Likewise.
411 (spu_xfer_partial): Likewise.
412 * spu-multiarch.c (spu_xfer_partial): Likewise.
413 * target.c (target_read_live_memory): Likewise.
414 (memory_xfer_live_readonly_partial): Likewise.
415 (memory_xfer_partial, memory_xfer_partial_1): Likewise.
416 (target_xfer_partial, default_xfer_partial): Likewise.
417 (current_xfer_partial): Likewise.
418 * tracepoint.c (tfile_xfer_partial): Likewise.
419 * windows-nat.c (windows_xfer_memory): Likewise. Call
420 pulongest instead of plongest.
421 (windows_xfer_partial): Likewise.
422 (windows_xfer_shared_libraries): Likewise.
423
05804640
YQ		 4242014-01-14 Yao Qi <yao@codesourcery.com>
425
426 * rs6000-nat.c (rs6000_xfer_shared_libraries): Use
427 target_xfer_partial_ftype.
428
b5b08fb4
SC		 4292014-01-13 Siva Chandra Reddy <sivachandra@google.com>
430
431 PR python/15464
432 PR python/16113
433 * valops.c (value_struct_elt_bitpos): New function
434 * py-type.c (convert_field): Set 'name' attribute of a gdb.Field
435 object to 'None' if the field name is an empty string ("").
436 * python/py-value.c (valpy_getitem): Use 'bitpos' and 'type'
437 attribute to look for a field when 'name' is 'None'.
438 (get_field_type): New function
439
13aaf454
DE		 4402014-01-13 Doug Evans <dje@google.com>
441
442 PR symtab/16426
443 * dwarf2read.c (dwarf2_get_dwz_file): Call gdb_bfd_record_inclusion.
444 (try_open_dwop_file): Ditto.
445 * gdb_bfd.c: #include "vec.h".
446 (bfdp): New typedef.
447 (struct gdb_bfd_data): New member included_bfds.
448 (gdb_bfd_unref): Unref all included bfds.
449 (gdb_bfd_record_inclusion): New function.
450 * gdb_bfd.h (gdb_bfd_record_inclusion): Declare.
451
c2cec97c
TT		 4522014-01-13 Tom Tromey <tromey@redhat.com>
453
454 * gdbcore.h (deprecated_core_resize_section_table): Remove.
455
78e5999d
TT		 4562014-01-13 Tom Tromey <tromey@redhat.com>
457
458 * defs.h (use_windows): Remove.
459 * gdb.c (main): Update.
460 * main.c (captured_main, gdb_main): Update.
461 * main.h (struct captured_main_args) <use_windows>: Remove.
462 * top.c (use_windows): Remove.
463
f2052bbe
TT		 4642014-01-13 Tom Tromey <tromey@redhat.com>
465
466 * defs.h (deprecated_flush_hook): Remove.
467
fde4f8ed
JK		 4682014-01-13 Jan Kratochvil <jan.kratochvil@redhat.com>
469
470 PR threads/16216
471 * linux-thread-db.c (try_thread_db_load): Add parameter
472 check_auto_load_safe. Move here the file_is_auto_load_safe call.
473 (try_thread_db_load_from_pdir_1): Move it there from here.
474 (try_thread_db_load_from_sdir): Update caller.
475 (try_thread_db_load_from_dir): Move it there from here.
476
bdf61915
PP		 4772014-01-13 Patrick Palka <patrick@parcs.ath.cx>
478
479 * regformats/regdat.sh: Always rewrite the register file.
480
f71e1a8d
PA		 4812014-01-13 Pedro Alves <palves@redhat.com>
482
483 * Makefile.in (CHECK_HEADERS): New variable.
484 (check-headers:): New rule.
485
42c85435
TT		 4862014-01-13 Tom Tromey <tromey@redhat.com>
487
488 * cli/cli-setshow.c (do_set_command): Update.
489 * defs.h (deprecated_set_hook): Remove.
490 * top.c (deprecated_set_hook): Remove.
491
f8de5129
PA		 4922014-01-13 Pedro Alves <palves@redhat.com>
493
494 * tracepoint.c (tfile_fetch_registers): Don't infer the PC from
495 the tracepoint if the PC is a pseudo-register.
496
fc270c35
TT		 4972014-01-13 Tom Tromey <tromey@redhat.com>
498
499 * defs.h (XCALLOC): Remove.
500 * bcache.c (bcache_xmalloc): Use XCNEW, not XCALLOC.
501 (print_bcache_statistics): Use XCNEWVEC, not XCALLOC.
502 * dwarf2loc.c (allocate_piece_closure): Likewise.
503 * elfread.c (elf_symfile_segments): Likewise.
504 (elf_symfile_segments): Likewise.
505 * gdbtypes.c (copy_type_recursive): Likewise.
506 * i386-tdep.c (i386_gdbarch_init): Use XCNEW, not XCALLOC.
507 * jit.c (jit_frame_sniffer): Use XCNEWVEC, not XCALLOC.
508 * minsyms.c (prim_record_minimal_symbol_full): Use XCNEW, not
509 XCALLOC.
510 * mt-tdep.c (mt_gdbarch_init): Likewise.
511 * opencl-lang.c (allocate_lval_closure): Use XCNEWVEC, not
512 XCALLOC.
513 * psymtab.c (psymbol_compare): Use XCNEW, not XCALLOC.
514 * regcache.c (regcache_xmalloc_1): Use XCNEWVEC, not XCALLOC.
515 * registry.c (registry_alloc_data): Likewise.
516 * rs6000-tdep.c (rs6000_gdbarch_init): Use XCNEW, not XCALLOC.
517 * s390-linux-tdep.c (s390_gdbarch_init): Likewise.
518 * serial.c (serial_fdopen_ops): Likewise.
519 * solib-aix.c (solib_aix_get_section_offsets): Use XCNEWVEC, not
520 XCALLOC.
521 * spu-tdep.c (spu_gdbarch_init): Use XCNEW, not XCALLOC.
522 * symfile.c (default_symfile_segments): Use XCNEW and XCNEWVEC,
523 not XCALLOC.
524
70ba0933
TT		 5252014-01-13 Tom Tromey <tromey@redhat.com>
526
527 * defs.h (XMALLOC): Remove.
528 * avr-tdep.c (avr_gdbarch_init): Use XNEW, not XMALLOC.
529 * bfin-tdep.c (bfin_gdbarch_init): Likewise.
530 * cli-out.c (struct ui_out *): Likewise.
531 * cli/cli-dump.c (add_dump_command): Likewise.
532 (add_dump_command): Likewise.
533 * complaints.c (get_complaints): Likewise.
534 (find_complaint): Likewise.
535 * dwarf2-frame.c (execute_cfa_program): Likewise.
536 * dwarf2read.c (abbrev_table_read_table): Likewise.
537 * gdbarch.sh: Likewise.
538 * gdbarch.c: Rebuild.
539 * inf-ttrace.c (inf_ttrace_add_page): Likewise.
540 * interps.c (interp_new): Likewise.
541 * lm32-tdep.c (lm32_gdbarch_init): Likewise.
542 * m32r-tdep.c (m32r_gdbarch_init): Likewise.
543 * mi/mi-console.c (mi_console_file_new): Likewise.
544 * mi/mi-interp.c (mi_interpreter_init): Likewise.
545 * mi/mi-out.c (mi_out_new): Likewise.
546 * mi/mi-parse.c (mi_parse): Likewise.
547 * microblaze-tdep.c (microblaze_gdbarch_init): Likewise.
548 * moxie-tdep.c (moxie_gdbarch_init): Likewise.
549 * observer.c (xalloc_observer_list_node): Likewise.
550 * regcache.c (regcache_xmalloc_1): Likewise.
551 * reggroups.c (reggroup_new): Likewise.
552 (_initialize_reggroup): Likewise.
553 * registry.c (register_data_with_cleanup): Likewise.
554 * remote.c (remote_notif_stop_alloc_reply): Likewise.
555 * ser-base.c (serial_ttystate): Likewise.
556 * ser-mingw.c (make_pipe_state): Likewise.
557 * ser-pipe.c (pipe_open): Likewise.
558 * serial.c (serial_open): Likewise.
559 * sh64-tdep.c (sh64_gdbarch_init): Likewise.
560 * tui/tui-data.c (tui_alloc_generic_win_info): Likewise.
561 (tui_alloc_win_info): Likewise.
562 (tui_add_content_elements): Likewise.
563 * tui/tui-file.c (tui_file_new): Likewise.
564 * tui/tui-out.c (tui_out_new): Likewise.
565 * ui-file.c (mem_file_new): Likewise.
566 * ui-out.c (push_level): Likewise.
567 (make_cleanup_ui_out_end): Likewise.
568 (append_header_to_list): Likewise.
569 (ui_out_new): Likewise.
570 * user-regs.c (user_reg_add_builtin): Likewise.
571
41bf6aca
TT		 5722014-01-13 Tom Tromey <tromey@redhat.com>
573
574 * defs.h (XZALLOC): Remove.
575 * ada-lang.c (get_ada_inferior_data): Use XCNEW, not XZALLOC.
576 * ada-tasks.c (get_ada_tasks_pspace_data): Likewise.
577 (get_ada_tasks_inferior_data): Likewise.
578 * auto-load.c (get_auto_load_pspace_data): Likewise.
579 * auxv.c (get_auxv_inferior_data): Likewise.
580 * bfd-target.c (target_bfd_reopen): Likewise.
581 * breakpoint.c (get_catch_syscall_inferior_data): Likewise.
582 (deprecated_insert_raw_breakpoint): Likewise.
583 * bsd-uthread.c (bsd_uthread_pid_to_str): Likewise.
584 * corelow.c (core_open): Likewise.
585 * darwin-nat.c (darwin_check_new_threads): Likewise.
586 (darwin_attach_pid): Likewise.
587 * dummy-frame.c (dummy_frame_push): Likewise.
588 * dwarf2-frame.c (dwarf2_frame_cache): Likewise.
589 * dwarf2loc.c (allocate_piece_closure): Likewise.
590 * elfread.c (elf_symfile_segments): Likewise.
591 * eval.c (ptrmath_type_p): Likewise.
592 * exceptions.c (EXCEPTIONS_SIGJMP_BUF): Likewise.
593 * gdbtypes.c (alloc_type_arch): Likewise.
594 (alloc_type_instance): Likewise.
595 * hppa-tdep.c (hppa_gdbarch_init): Likewise.
596 * inf-child.c (inf_child_can_use_agent): Likewise.
597 * inflow.c (get_inflow_inferior_data): Likewise.
598 * infrun.c (save_infcall_suspend_state): Likewise.
599 * jit.c (jit_reader_load): Likewise.
600 (get_jit_objfile_data): Likewise.
601 (get_jit_program_space_data): Likewise.
602 (jit_object_open_impl): Likewise.
603 (jit_symtab_open_impl): Likewise.
604 (jit_block_open_impl): Likewise.
605 (jit_frame_sniffer): Likewise.
606 * linux-fork.c (add_fork): Likewise.
607 * maint.c (make_command_stats_cleanup): Likewise.
608 * objfiles.c (get_objfile_pspace_data): Likewise.
609 * opencl-lang.c (struct lval_closure): Likewise.
610 * osdata.c (osdata_start_osdata): Likewise.
611 * progspace.c (new_address_space): Likewise.
612 (add_program_space): Likewise.
613 * remote-sim.c (get_sim_inferior_data): Likewise.
614 * sh-tdep.c (sh_gdbarch_init): Likewise.
615 * skip.c (Ignore): Likewise.
616 (skip_delete_command): Likewise.
617 * solib-aix.c (get_solib_aix_inferior_data): Likewise.
618 (library_list_start_library): Likewise.
619 (solib_aix_current_sos): Likewise.
620 * solib-darwin.c (get_darwin_info): Likewise.
621 (darwin_current_sos): Likewise.
622 * solib-dsbt.c (get_dsbt_info): Likewise.
623 * solib-ia64-hpux.c (new_so_list): Likewise.
624 (ia64_hpux_get_solib_linkage_addr): Likewise.
625 * solib-spu.c (append_ocl_sos): Likewise.
626 (spu_current_sos): Likewise.
627 * solib-svr4.c (get_svr4_info): Likewise.
628 (svr4_keep_data_in_core): Likewise.
629 (library_list_start_library): Likewise.
630 (svr4_default_sos): Likewise.
631 (svr4_read_so_list): Likewise.
632 * solib-target.c (library_list_start_library): Likewise.
633 (solib_target_current_sos): Likewise.
634 * sparc-tdep.c (sparc32_gdbarch_init): Likewise.
635 * symfile-debug.c (install_symfile_debug_logging): Likewise.
636 * symfile.c (default_symfile_segments): Likewise.
637 * target-descriptions.c (tdesc_data_init): Likewise.
638 (tdesc_create_reg): Likewise.
639 (struct tdesc_type *): Likewise.
640 (tdesc_create_vector): Likewise.
641 (tdesc_set_struct_size): Likewise.
642 (struct tdesc_type *): Likewise.
643 (tdesc_free_feature): Likewise.
644 (tdesc_create_feature): Likewise.
645 * windows-nat.c (windows_add_thread): Likewise.
646 (windows_make_so): Likewise.
647 * xml-support.c (gdb_xml_body_text): Likewise.
648 (gdb_xml_create_parser_and_cleanup): Likewise.
649 (xml_process_xincludes): Likewise.
650 * xml-syscall.c (allocate_syscalls_info): Likewise.
651 (syscall_create_syscall_desc): Likewise.
652
5acfdbae
SDJ		 6532014-01-12 Sergio Durigan Junior <sergiodj@redhat.com>
654
655 * i386-tdep.c (i386_stap_parse_special_token_triplet): New
656 function, with code from i386_stap_parse_special_token.
657 (i386_stap_parse_special_token_three_arg_disp): Likewise.
658 (i386_stap_parse_special_token): Move code to the two functions
659 above; simplify it.
660
0000e5cc
PA		 6612014-01-09 Pedro Alves <palves@redhat.com>
662 Hui Zhu <hui@codesourcery.com>
663
664 PR gdb/16101
665 * breakpoint.c (insert_bp_location): Rename hw_bp_err_string to
666 bp_err_string. Don't mark the location shlib_disabled if the
667 error thrown wasn't a generic or memory error. Catch errors
668 thrown while inserting breakpoints in overlayed code. Output
669 error message of software breakpoints.
670 * remote.c (remote_insert_breakpoint): If this breakpoint has
671 target-side commands but this stub doesn't support Z0 packets,
672 throw NOT_SUPPORTED_ERROR error.
673 * exceptions.h (enum errors) <NOT_SUPPORTED_ERROR>: New error.
674 * target.h (target_insert_breakpoint): Extend comment.
675 (target_insert_hw_breakpoint): Add comment.
676
b7ea362b
PA		 6772014-01-08 Pedro Alves <palves@redhat.com>
678
679 * remote.c (remote_add_thread): Add threads silently if starting
680 up.
681 (remote_notice_new_inferior): If in all-stop, and starting up,
682 don't call notice_new_inferior.
683 (get_current_thread): New function, factored out from ...
684 (add_current_inferior_and_thread): ... this. Adjust.
685 (remote_start_remote) <all-stop>: Fetch the thread list. If we
686 found any thread, then select the remote's current thread as GDB's
687 current thread too.
688
b7bba001
JB		 6892014-01-08 Joel Brobecker <brobecker@adacore.com>
690
691 * NEWS: Create a new section for the next release branch.
692 Rename the section of the current branch, now that it has
693 been cut.
694
16dfbded
JB		 6952014-01-08 Joel Brobecker <brobecker@adacore.com>
696
697 GDB 7.7 branch created (79301218fa0f074c5656db0ec8972a5ddcf91fb5):
698 * version.in: Bump version to 7.7.50.DATE-cvs.
699
22c90ac1
YQ		 7002014-01-08 Yao Qi <yao@codesourcery.com>
701
702 * spu-linux-nat.c (spu_symbol_file_add_from_memory): Change
703 type of 'id' to gdb_byte. Cast 'id' to 'const char *'.
704 (spu_xfer_partial): Cast 'buf' to 'const char *'.
705
d64ad97c
YQ		 7062014-01-08 Yao Qi <yao@codesourcery.com>
707
708 * spu-linux-nat.c (spu_symbol_file_add_from_memory): Pass
709 return value of bfd_get_filename to symbol_file_add_from_bfd.
710
f93ba80c
PM		 7112014-01-08 Pierre Muller <muller@sourceware.org>
712
713 Fix PR16201.
714 * coff-pe-read.c (struct read_pe_section_data): Add index field.
715 (add_pe_exported_sym): Use SECTION_DATA->INDEX for call
716 to prim_record_mininal_symbol_and_info.
717 (add_pe_forwarded_sym): Use known section number of forwarded symbol
718 in call to prim_record_minimal_symbol_and_info.
719 (read_pe_exported_syms): Set index field of section_data.
720
a4d9ba85
AP		 7212014-01-07 Andrew Pinski <apinski@cavium.com>
722
723 * features/aarch64-core.xml (cpsr): Change to be 64bit.
724 * features/aarch64.c: Regenerate.
725
1b67eb02
AS		 7262014-01-07 Andreas Schwab <schwab@linux-m68k.org>
727
728 * target.c (return_null): Define.
729 (update_current_target): Use it instead of return_zero for
730 functions that return a pointer.
731
5e3f4fab
EBM		 7322014-01-07 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
733
734 * source.c (add_path): Fix check for duplicated paths in the previously
735 included paths.
736
e2616788
HK		 7372014-01-07 Honggyu Kim <hong.gyu.kim@lge.com>
738
739 * ada-lang.c: Remove duplicated include statements.
740 * alphabsd-nat.c: Ditto.
741 * amd64-darwin-tdep.c: Ditto.
742 * amd64fbsd-nat.c: Ditto.
743 * auto-load.c: Ditto.
744 * ax-gdb.c: Ditto.
745 * breakpoint.c: Ditto.
746 * dbxread.c: Ditto.
747 * fork-child.c: Ditto.
748 * gdb_usleep.c: Ditto.
749 * i386-darwin-tdep.c: Ditto.
750 * i386fbsd-nat.c: Ditto.
751 * infcmd.c: Ditto.
752 * inferior.c: Ditto.
753 * jv-lang.c: Ditto.
754 * linux-nat.c: Ditto.
755 * linux-tdep.c: Ditto.
756 * m68kbsd-nat.c: Ditto.
757 * m68klinux-nat.c: Ditto.
758 * microblaze-tdep.c: Ditto.
759 * mips-linux-tdep.c: Ditto.
760 * mn10300-tdep.c: Ditto.
761 * nto-tdep.c: Ditto.
762 * opencl-lang.c: Ditto.
763 * osdata.c: Ditto.
764 * printcmd.c: Ditto.
765 * regcache.c: Ditto.
766 * remote-m32r-sdi.c: Ditto.
767 * remote.c: Ditto.
768 * symfile.c: Ditto.
769 * symtab.c: Ditto.
770 * tilegx-linux-nat.c: Ditto.
771 * tilegx-tdep.c: Ditto.
772 * tracepoint.c: Ditto.
773 * valops.c: Ditto.
774 * vaxbsd-nat.c: Ditto.
775 * windows-nat.c: Ditto.
776 * xtensa-tdep.c: Ditto.
777
bd1f7788
YQ		 7782014-01-07 Yao Qi <yao@codesourcery.com>
779
780 * spu-linux-nat.c (_initialize_spu_nat): Declare.
781
79301218
JB		 7822014-01-07 Yao Qi <yao@codesourcery.com>
783 Joel Brobecker <brobecker@adacore.com>
784
785 * aix-thread.c (pdc_read_regs): Cast parameter to uintptr_t.
786 (pdc_write_regs): Likewise.
787 (fetch_regs_kernel_thread): Likewise.
788 (store_regs_kernel_thread): Likewise.
789
7902014-01-07 Joel Brobecker <brobecker@adacore.com>
791
792 * ada-varobj.c (ada_varobj_adjust_for_child_access): Convert
793 tagged type objects to their actual type.
794
8e355c5d
JB		 7952014-01-07 Joel Brobecker <brobecker@adacore.com>
796
797 * ada-valprint.c (print_field_values): Add "language" parameter.
798 Update calls to print_field_values and print_variant_part.
799 Pass new parameter "language" in call to val_print instead
800 of "current_language". Replace call to ada_val_print by call
801 to val_print.
802 (print_variant_part): Add "language" parameter.
803 (ada_val_print_struct_union): Update call to print_field_values.
804
4fbf5aa5
JB		 8052014-01-07 Joel Brobecker <brobecker@adacore.com>
806
807 * ada-valprint.c (ui_memcpy): Delete.
808 (ada_print_floating): Update documentation. Add empty line
809 between between function documentation and implementation.
810 Delete variable "buffer". Use ui_file_xstrdup in place of
811 ui_file_put. Minor adjustments following this change.
812
71855601
JB		 8132014-01-07 Joel Brobecker <brobecker@adacore.com>
814
815 * ada-valprint.c (ada_val_print_string): New function,
816 extracted from ada_val_print_array.
817 (ada_val_print_array): Replace extracted code by call
818 to ada_val_print_string followed by a return. Move
819 "else" branch to the function's top block.
820
4eb27a30
JB		 8212014-01-07 Joel Brobecker <brobecker@adacore.com>
822
823 * ada-valprint.c (ada_val_print_array): Move implementation
824 down. Rename parameter "offset" and "val" into "offset_aligned"
825 and "original_value" respectively. Add parameter "offset".
826
34b27950
JB		 8272014-01-07 Joel Brobecker <brobecker@adacore.com>
828
829 * ada-valprint.c (ada_val_print_ref): Rewrite by mostly
830 re-organizing the code. Change the "???" message printed
831 when target type is a TYPE_CODE_UNDEF into
832 "<ref to undefined type>".
833
079e4591
JB		 8342014-01-07 Joel Brobecker <brobecker@adacore.com>
835
836 * ada-valprint.c (print_record): Delete, implementation inlined...
837 (ada_val_print_struct_union): ... here. Remove call to
838 ada_check_typedef in inlined implementation.
839
8004dfd1
JB		 8402014-01-07 Joel Brobecker <brobecker@adacore.com>
841
842 * ada-valprint.c (ada_val_print_gnat_array): New function,
843 extracted from ada_val_print_1;
844 (ada_val_print_ptr, ada_val_print_num, ada_val_print_enum)
845 (ada_val_print_flt, ada_val_print_struct_union)
846 (ada_val_print_ref): Likewise.
847 (ada_val_print_1): Delete variables i and elttype.
848 Replace extracted-out code by call to corresponding
849 new functions.
850
760a2db0
JB		 8512014-01-07 Joel Brobecker <brobecker@adacore.com>
852
853 * ada-valprint.c (ada_val_print_1): Remove call to gdb_flush.
854
3a92c861
JB		 8552014-01-07 Joel Brobecker <brobecker@adacore.com>
856
857 * ada-valprint.c (ada_val_print_1): Replace calls to
858 ada_val_print_1 by calls to val_print.
859
cd1630f9
JB		 8602014-01-07 Joel Brobecker <brobecker@adacore.com>
861
862 * ada-valprint.c (ada_val_print_1): Add parameter "language".
863 Update calls to self accordingly. Replace calls to c_val_print
864 by calls to val_print.
865
bdf779a0
JB		 8662014-01-07 Joel Brobecker <brobecker@adacore.com>
867
868 * ada-valprint.c (print_record): Delete declaration.
869 (adjust_type_signedness, ada_val_print_1): Likewise.
870 (ada_val_print): Move function implementation down.
871 (print_variant_part, print_field_values, print_record):
872 Move function implementation up.
873
c0d48811
JB		 8742014-01-07 Joel Brobecker <brobecker@adacore.com>
875
876 * python/py-type.c (typy_get_name): New function.
877 (type_object_getset): Add entry for attribute "name".
878 * NEWS: Add entry mentioning this new attribute.
879
c26e9cbb
YQ		 8802014-01-07 Yao Qi <yao@codesourcery.com>
881
882 * gnu-nat.c (set_exceptions_cmd): Remove an empty body 'if'
883 statement.
884
0cc6f43d
YQ		 8852014-01-07 Yao Qi <yao@codesourcery.com>
886
887 * gnu-nat.c (info_port_rights): Add qualifier const to
888 argument args.
889
eec03155
YQ		 8902014-01-07 Yao Qi <yao@codesourcery.com>
891
892 * gnu-nat.c (trace_me): Use 'void' for empty argument list.
893
f04a82ef
YQ		 8942014-01-07 Yao Qi <yao@codesourcery.com>
895
896 * gnu-nat.c (make_inf) Update declaration.
897 (make_inf): Make it static.
898 (inf_set_traced): Likewise.
899 (inf_port_to_thread, inf_task_died_status): Likewise.
900
d57dda0a
YQ		 9012014-01-07 Yao Qi <yao@codesourcery.com>
902
903 * gnu-nat.c (inf_tid_to_proc): Remove declaration.
904
3aa8c969
YQ		 9052014-01-07 Yao Qi <yao@codesourcery.com>
906
907 * gnu-nat.c (_initialize_gnu_nat): Declare.
908
94123b4f
YQ		 9092014-01-07 Yao Qi <yao@codesourcery.com>
910
911 * gdbarch.sh (byte_order, byte_order_for_code): Change type to
912 'enum bfd_endian'.
913 (struct gdbarch_info) <byte_order>: Change type to
914 'enum bfd_endian'.
915 <byte_order_for_code>: Likewise.
916 * gdbarch.c, gdbarch.h: Regenerated.
917
dc81d70a
TT		 9182014-01-06 Sasha Smundak <asmundak@google.com>
919
920 * jit.c: (jit_reader_load_command): Fix JIT reader path creation.
921
cc2f3c35
TT		 9222014-01-06 Tom Tromey <tromey@redhat.com>
923
924 * doublest.c (convert_doublest_to_floatformat): Use const, not
925 CONST.
926 * somread.c (som_symtab_read): Likewise.
927
adcf2eed
HZ		 9282014-01-07 Hui Zhu <hui@codesourcery.com>
929
930 * gdb_bfd.c (gdb_bfd_stash_filename): Removed.
931 (gdb_bfd_open): Removed gdb_bfd_stash_filename.
932 (gdb_bfd_fopen): Ditto.
933 (gdb_bfd_openr): Ditto.
934 (gdb_bfd_openw): Ditto.
935 (gdb_bfd_openr_iovec): Ditto.
936 (gdb_bfd_fdopenr): Ditto.
937 * gdb_bfd.h (gdb_bfd_stash_filename): Removed.
938 * solib-aix.c (solib_aix_bfd_open): Alloc object_bfd->filename
939 with xstrdup.
940 * solib-darwin.c (darwin_bfd_open): Alloc res->filename
941 with xstrdup.
942 * symfile-mem.c (symbol_file_add_from_memory): Removed
943 gdb_bfd_stash_filename.
944
50722198
DE		 9452014-01-03 Doug Evans <dje@google.com>
946
947 * nat/linux-waitpid.c (linux_debug): Remove extraneous \n from
948 output.
949
2fa4b862
JB		 9502014-01-01 Joel Brobecker <brobecker@adacore.com>
951
952 Update year range in copyright notice of all files.
953
28498c42
JB		 9542014-01-01 Joel Brobecker <brobecker@adacore.com>
955
956 * top.c (print_gdb_version): Set copyright year to 2014.
957
7b6e1046
JB		 9582014-01-01 Joel Brobecker <brobecker@adacore.com>
959
960 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2013.
961
df96af55 962For older changes see ChangeLog-2013.
c906108c
SS		 963\f
964Local Variables:
965mode: change-log
966left-margin: 8
967fill-column: 74
968version-control: never
57da7796 969coding: utf-8
c906108c 970End:
GDB Binutils - Deliverables
This page took 1.56144 seconds and 4 git commands to generate.