Change "win_resized" to bool
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
9abd8a65
TT
12019-09-20 Tom Tromey <tom@tromey.com>
2
3 * tui/tui.c (tui_enable): Update.
4 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
5 Update.
6 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
7 Update.
8 * tui/tui-data.c (win_resized): Now bool.
9 (tui_win_resized): Return bool.
10 (tui_set_win_resized_to): Accept a bool.
11
b5457826
TT
122019-09-20 Tom Tromey <tom@tromey.com>
13
14 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
15 Change type of "refresh_values_only".
16 * tui/tui-regs.c (tui_data_window::show_register_group): Change
17 type of "refresh_values_only".
18
6b915f7d
TT
192019-09-20 Tom Tromey <tom@tromey.com>
20
21 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
22 std::string.
23 (tui_disassemble): Add "pos" parameter.
24 (tui_disasm_window::set_contents): Simplify.
25
2ad52f6f
TT
262019-09-20 Tom Tromey <tom@tromey.com>
27
28 * tui/tui-winsource.h (struct tui_source_window_base)
29 <show_source_content>: Now private.
30 * tui/tui-winsource.c
31 (tui_source_window_base::show_source_content): Don't handle empty
32 content case.
33
b3b1bde6
TT
342019-09-20 Tom Tromey <tom@tromey.com>
35
36 * tui/tui-layout.c (show_source_disasm_command)
37 (show_source_or_disasm_and_command): Don't call
38 show_source_content.
39
71a25ed2
TT
402019-09-20 Tom Tromey <tom@tromey.com>
41
42 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
43 Declare.
44 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
45 from tui_make_status_line.
46 (tui_locator_window::rerender): Update.
47
f8532154
TT
482019-09-20 Tom Tromey <tom@tromey.com>
49
50 * tui/tui-stack.c (tui_make_status_line): Return std::string.
51 (tui_locator_window::rerender): Update.
52
2d81b349
TT
532019-09-20 Tom Tromey <tom@tromey.com>
54
55 * tui/tui-winsource.h (struct tui_source_window_base)
56 <~tui_source_window_base>: Don't declare.
57 <fullname>: Remove.
58 * tui/tui-winsource.c (~tui_source_window_base): Remove.
59 * tui/tui-source.h (struct tui_source_window) <fullname>: New
60 member.
61 * tui/tui-source.c (tui_source_window::set_contents): Update.
62 (tui_source_window::location_matches_p)
63 (tui_source_window::maybe_update): Update.
64
f14bec58
TT
652019-09-20 Tom Tromey <tom@tromey.com>
66
67 * tui/tui-winsource.h (~tui_source_element): Remove.
68 (tui_source_element): Update.
69 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
70 * tui/tui-winsource.c (tui_show_source_line): Update.
71 * tui/tui-source.c (tui_source_window::set_contents): Update.
72 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
73
78d5933a
TT
742019-09-20 Tom Tromey <tom@tromey.com>
75
76 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
77 declare.
78 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
79 tui_clear_source_windows_detail.
80 * tui/tui-winsource.h (struct tui_source_window_base)
81 <clear_detail>: Don't declare.
82 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
83 Remove.
84 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
85
d4207696
TT
862019-09-20 Tom Tromey <tromey@adacore.com>
87
88 PR ada/24919:
89 * block.c (contained_in): Fix final return value.
90
00f93c44
AM
912019-09-20 Alan Modra <amodra@gmail.com>
92
93 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
94 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
95 (read_indirect_string_from_dwz): Use bfd accessor.
96 * dwarf2read.h (struct dwz_file <filename>): Likewise.
97 * machoread.c (macho_symfile_read_all_oso): Likewise.
98 * solib.c (solib_bfd_open): Likewise.
99
e4153ae6
CB
1002019-09-19 Christian Biesinger <cbiesinger@google.com>
101
102 * eval.c: Move declaration of overload_resolution to...
103 * value.h: ...here.
104
c7ae7675
CB
1052019-09-19 Christian Biesinger <cbiesinger@google.com>
106
107 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
108 * arm-linux-tdep.c: Likewise.
109 * arm-nbsd-nat.c: Likewise.
110 * arm-tdep.h: Declare arm_apcs_32.
111 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
112
e86f08d2
CB
1132019-09-19 Christian Biesinger <cbiesinger@google.com>
114
115 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
116 * dwarf2read.h: Declare dwarf_always_disassemble.
117
f64e2f40
TV
1182019-09-19 Tom de Vries <tdevries@suse.de>
119
120 PR gdb/25009
121 * source-cache.c (source_cache::ensure): Catch exception thrown during
122 construction of the highlighter.
123
fd361982
AM
1242019-09-18 Alan Modra <amodra@gmail.com>
125
126 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
127 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
128 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
129 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
130 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
131 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
132 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
133 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
134 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
135 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
136 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
137 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
138 * solib-spu.c, * solib-svr4.c, * solib-target.c,
139 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
140 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
141 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
142 * mi/mi-interp.c: Update throughout for bfd section macro and
143 function changes.
144 * gcore (gcore_create_callback): Use bfd_set_section_lma.
145 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
146
11061048
TT
1472019-09-18 Tom Tromey <tom@tromey.com>
148
149 * NEWS: Add entry.
150 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
151 call rl_initialize.
152 (tui_enable): Do not call rl_initialize.
153
7a27b85f
CG
1542019-09-18 Christian Groessler <chris@groessler.org>
155
156 * alpha-linux-nat.c: Include gdbarch.h.
157
f64eea3a
SM
1582019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
159
160 * ui-file.c: Include cli/cli-style.h.
161 (term_cli_styling): Remove cli_styling declaration.
162
e6f7f6d1
AM
1632019-09-18 Alan Modra <amodra@gmail.com>
164
165 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
166 to bfd_asymbol_section.
167
1d38e9d1
AM
1682019-09-18 Alan Modra <amodra@gmail.com>
169
170 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
171 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
172 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
173
90d92a63
AM
1742019-09-18 Alan Modra <amodra@gmail.com>
175
176 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
177 * spu-linux-nat.c (spu_bfd_open): Likewise.
178
a3d181d2
CB
1792019-09-18 Christian Biesinger <cbiesinger@google.com>
180
181 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
182 to bool to match definition in dwarf2read.c.
183
491144b5
CB
1842019-09-17 Christian Biesinger <cbiesinger@google.com>
185
186 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
187 (print_signatures): Likewise.
188 (trust_pad_over_xvs): Likewise.
189 * arch/aarch64-insn.c (aarch64_debug): Likewise.
190 * arch/aarch64-insn.h (aarch64_debug): Likewise.
191 * arm-linux-nat.c (arm_apcs_32): Likewise.
192 * arm-linux-tdep.c (arm_apcs_32): Likewise.
193 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
194 * arm-tdep.c (arm_debug): Likewise.
195 (arm_apcs_32): Likewise.
196 * auto-load.c (debug_auto_load): Likewise.
197 (auto_load_gdb_scripts): Likewise.
198 (global_auto_load): Likewise.
199 (auto_load_local_gdbinit): Likewise.
200 (auto_load_local_gdbinit_loaded): Likewise.
201 * auto-load.h (global_auto_load): Likewise.
202 (auto_load_local_gdbinit): Likewise.
203 (auto_load_local_gdbinit_loaded): Likewise.
204 * breakpoint.c (disconnected_dprintf): Likewise.
205 (breakpoint_proceeded): Likewise.
206 (automatic_hardware_breakpoints): Likewise.
207 (always_inserted_mode): Likewise.
208 (target_exact_watchpoints): Likewise.
209 (_initialize_breakpoint): Update.
210 * breakpoint.h (target_exact_watchpoints): Change to bool.
211 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
212 * cli/cli-cmds.c (trace_commands): Likewise.
213 * cli/cli-cmds.h (trace_commands): Likewise.
214 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
215 to bool*.
216 * cli/cli-logging.c (logging_overwrite): Change to bool.
217 (logging_redirect): Likewise.
218 (debug_redirect): Likewise.
219 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
220 (struct boolean_option_def) <get_var_address_cb_>: Change return type
221 to bool.
222 <boolean_option_def>: Update.
223 (struct flag_option_def): Change default type of Context to bool
224 from int.
225 <flag_option_def>: Change return type of var_address_cb_ to bool*.
226 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
227 (get_setshow_command_value_string): Likewise.
228 * cli/cli-style.c (cli_styling): Change to bool.
229 (source_styling): Likewise.
230 * cli/cli-style.h (source_styling): Likewise.
231 (cli_styling): Likewise.
232 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
233 to bool.
234 * command.h (var_types): Update comment.
235 (add_setshow_boolean_cmd): Change int* var argument to bool*.
236 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
237 bool.
238 (debug_compile_cplus_scopes): Likewise.
239 * compile/compile-internal.h (compile_debug): Likewise.
240 * compile/compile.c (compile_debug): Likewise.
241 (struct compile_options) <raw>: Likewise.
242 * cp-support.c (catch_demangler_crashes): Likewise.
243 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
244 (usr_cmd_cris_dwarf2_cfi): Likewise.
245 * csky-tdep.c (csky_debug): Likewise.
246 * darwin-nat.c (enable_mach_exceptions): Likewise.
247 * dcache.c (dcache_enabled_p): Likewise.
248 * defs.h (info_verbose): Likewise.
249 * demangle.c (demangle): Likewise.
250 (asm_demangle): Likewise.
251 * dwarf-index-cache.c (debug_index_cache): Likewise.
252 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
253 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
254 * dwarf2read.c (check_physname): Likewise.
255 (use_deprecated_index_sections): Likewise.
256 (dwarf_always_disassemble): Likewise.
257 * eval.c (overload_resolution): Likewise.
258 * event-top.c (set_editing_cmd_var): Likewise.
259 (exec_done_display_p): Likewise.
260 * event-top.h (set_editing_cmd_var): Likewise.
261 (exec_done_display_p): Likewise.
262 * exec.c (write_files): Likewise.
263 * fbsd-nat.c (debug_fbsd_lwp): Likewise
264 (debug_fbsd_nat): Likewise.
265 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
266 Likewise.
267 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
268 <backtrace_past_entry> Likewise.
269 * gdb-demangle.h (demangle): Likewise.
270 (asm_demangle): Likewise.
271 * gdb_bfd.c (bfd_sharing): Likewise.
272 * gdbcore.h (write_files): Likewise.
273 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
274 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
275 * gdbthread.h (print_thread_events): Likewise.
276 * gdbtypes.c (opaque_type_resolution): Likewise.
277 (strict_type_checking): Likewise.
278 * gnu-nat.c (gnu_debug_flag): Likewise.
279 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
280 * guile/scm-param.c (pascm_variable): Add boolval.
281 (add_setshow_generic): Update.
282 (pascm_param_value): Update.
283 (pascm_set_param_value_x): Update.
284 * hppa-tdep.c (hppa_debug): Change to bool..
285 * infcall.c (may_call_functions_p): Likewise.
286 (coerce_float_to_double_p): Likewise.
287 (unwind_on_signal_p): Likewise.
288 (unwind_on_terminating_exception_p): Likewise.
289 * infcmd.c (startup_with_shell): Likewise.
290 * inferior.c (print_inferior_events): Likewise.
291 * inferior.h (startup_with_shell): Likewise.
292 (print_inferior_events): Likewise.
293 * infrun.c (step_stop_if_no_debug): Likewise.
294 (detach_fork): Likewise.
295 (debug_displaced): Likewise.
296 (disable_randomization): Likewise.
297 (non_stop): Likewise.
298 (non_stop_1): Likewise.
299 (observer_mode): Likewise.
300 (observer_mode_1): Likewise.
301 (set_observer_mode): Update.
302 (sched_multi): Change to bool.
303 * infrun.h (debug_displaced): Likewise.
304 (sched_multi): Likewise.
305 (step_stop_if_no_debug): Likewise.
306 (non_stop): Likewise.
307 (disable_randomization): Likewise.
308 * linux-tdep.c (use_coredump_filter): Likewise.
309 (dump_excluded_mappings): Likewise.
310 * linux-thread-db.c (auto_load_thread_db): Likewise.
311 (check_thread_db_on_load): Likewise.
312 * main.c (captured_main_1): Update.
313 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
314 xx2_opt, boolean_opt>: Change to bool.
315 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
316 * maint.c (maintenance_profile_p): Likewise.
317 (per_command_time): Likewise.
318 (per_command_space): Likewise.
319 (per_command_symtab): Likewise.
320 * memattr.c (inaccessible_by_default): Likewise.
321 * mi/mi-main.c (mi_async): Likewise.
322 (mi_async_1): Likewise.
323 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
324 * nat/fork-inferior.h (startup_with_shell): Likewise.
325 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
326 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
327 * nios2-tdep.c (nios2_debug): Likewise.
328 * or1k-tdep.c (or1k_debug): Likewise.
329 * parse.c (parser_debug): Likewise.
330 * parser-defs.h (parser_debug): Likewise.
331 * printcmd.c (print_symbol_filename): Likewise.
332 * proc-api.c (procfs_trace): Likewise.
333 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
334 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
335 (set_parameter_value): Update.
336 (add_setshow_generic): Update.
337 * python/py-value.c (copy_py_bool_obj): Change argument from int*
338 to bool*.
339 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
340 int*.
341 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
342 * record-btrace.c (record_btrace_target::store_registers): Update.
343 * record-full.c (record_full_memory_query): Change to bool.
344 (record_full_stop_at_limit): Likewise.
345 * record-full.h (record_full_memory_query): Likewise.
346 * remote-notif.c (notif_debug): Likewise.
347 * remote-notif.h (notif_debug): Likewise.
348 * remote.c (use_range_stepping): Likewise.
349 (interrupt_on_connect): Likewise.
350 (remote_break): Likewise.
351 * ser-tcp.c (tcp_auto_retry): Likewise.
352 * ser-unix.c (serial_hwflow): Likewise.
353 * skip.c (debug_skip): Likewise.
354 * solib-aix.c (solib_aix_debug): Likewise.
355 * spu-tdep.c (spu_stop_on_load_p): Likewise.
356 (spu_auto_flush_cache_p): Likewise.
357 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
358 Likewise.
359 (struct info_print_options) <quiet>: Likewise.
360 * symfile-debug.c (debug_symfile): Likewise.
361 * symfile.c (auto_solib_add): Likewise.
362 (separate_debug_file_debug): Likewise.
363 * symfile.h (auto_solib_add): Likewise.
364 (separate_debug_file_debug): Likewise.
365 * symtab.c (basenames_may_differ): Likewise.
366 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
367 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
368 (struct info_types_options) <quiet>: Likewise.
369 * symtab.h (demangle): Likewise.
370 (basenames_may_differ): Likewise.
371 * target-dcache.c (stack_cache_enabled_1): Likewise.
372 (code_cache_enabled_1): Likewise.
373 * target.c (trust_readonly): Likewise.
374 (may_write_registers): Likewise.
375 (may_write_memory): Likewise.
376 (may_insert_breakpoints): Likewise.
377 (may_insert_tracepoints): Likewise.
378 (may_insert_fast_tracepoints): Likewise.
379 (may_stop): Likewise.
380 (auto_connect_native_target): Likewise.
381 (target_stop_and_wait): Update.
382 (target_async_permitted): Change to bool.
383 (target_async_permitted_1): Likewise.
384 (may_write_registers_1): Likewise.
385 (may_write_memory_1): Likewise.
386 (may_insert_breakpoints_1): Likewise.
387 (may_insert_tracepoints_1): Likewise.
388 (may_insert_fast_tracepoints_1): Likewise.
389 (may_stop_1): Likewise.
390 * target.h (target_async_permitted): Likewise.
391 (may_write_registers): Likewise.
392 (may_write_memory): Likewise.
393 (may_insert_breakpoints): Likewise.
394 (may_insert_tracepoints): Likewise.
395 (may_insert_fast_tracepoints): Likewise.
396 (may_stop): Likewise.
397 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
398 (make_thread_apply_all_options_def_group): Change argument from int*
399 to bool*.
400 (thread_apply_all_command): Update.
401 (print_thread_events): Change to bool.
402 * top.c (confirm): Likewise.
403 (command_editing_p): Likewise.
404 (history_expansion_p): Likewise.
405 (write_history_p): Likewise.
406 (info_verbose): Likewise.
407 * top.h (confirm): Likewise.
408 (history_expansion_p): Likewise.
409 * tracepoint.c (disconnected_tracing): Likewise.
410 (circular_trace_buffer): Likewise.
411 * typeprint.c (print_methods): Likewise.
412 (print_typedefs): Likewise.
413 * utils.c (debug_timestamp): Likewise.
414 (sevenbit_strings): Likewise.
415 (pagination_enabled): Likewise.
416 * utils.h (sevenbit_strings): Likewise.
417 (pagination_enabled): Likewise.
418 * valops.c (overload_resolution): Likewise.
419 * valprint.h (struct value_print_options) <prettyformat_arrays,
420 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
421 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
422 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
423 Likewise.
424 * windows-nat.c (new_console): Likewise.
425 (cygwin_exceptions): Likewise.
426 (new_group): Likewise.
427 (debug_exec): Likewise.
428 (debug_events): Likewise.
429 (debug_memory): Likewise.
430 (debug_exceptions): Likewise.
431 (useshell): Likewise.
432 * windows-tdep.c (maint_display_all_tib): Likewise.
433 * xml-support.c (debug_xml): Likewise.
434
f1b620e9
MG
4352019-09-17 Mike Gulick <mgulick@mathworks.com>
436
437 * source.c (prepare_path_for_appending): New function.
438 (openp): Make use of new function.
439 (find_and_open_source): Search for the compilation directory and
440 source file as a relative path beneath the directory search path.
441
67f3ed6a
AB
4422019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
443
444 * source-cache.c (source_cache::get_line_charpos): Catch
445 exceptions and return false, this matches the behaviour documented
446 in the header file.
447
74332189
JB
4482019-09-17 Joel Brobecker <brobecker@adacore.com>
449
450 * ada-tasks.c (info_task): Remove quoting of the task's name.
451
f2f24aa9
CB
4522019-09-16 Christian Biesinger <cbiesinger@google.com>
453
454 * symfile.c (auto_solib_add): Replace comment with a reference
455 to the header file.
456
6a062a93
CB
4572019-09-14 Christian Biesinger <cbiesinger@google.com>
458
459 * NEWS: Mention that gdb can now be compiled with Python 3
460 on Windows.
461
ec6c8338
AB
4622019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
463
464 * maint.c (maint_print_section_data::maint_print_section_data):
465 Force use of 'float log10 (float)' by casting the argument to
466 float.
467
aa17805f
AB
4682019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
469
470 * maint.c: Add 'cmath' include.
471 (struct maint_print_section_data): New structure.
472 (print_section_index): New function.
473 (print_bfd_section_info): Add header comment, small whitespace
474 cleanup, and update to call new print_section_index function.
475 (print_objfile_section_info): Likewise.
476 (maint_obj_section_from_bfd_section): New function.
477 (print_bfd_section_info_maybe_relocated): New function.
478 (maintenance_info_sections): Add header comment, always use
479 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
480
3dd9bb46
AB
4812019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
482
483 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
484 inner scope, add check that the objfile has psymtabs before
485 checking psymtabs_addrmap.
486 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
487
4993045d
PW
4882019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
489
490 * NEWS: Announce that Ada task names are now shown at more places,
491 and between quotes (except in info task output).
492 * gdb/ada-tasks.c (task_to_str): New function.
493 (display_current_task_id): Call task_to_str.
494 (task_command_1): Likewise.
495 (print_ada_task_info): In non-mi mode, Properly align headers and data
496 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
497
7a289707
RO
4982019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
499
500 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
501 prstatus.pr_lwp.pr_info instead of making it up.
502
f2aec7f6
CB
5032019-09-11 Christian Biesinger <cbiesinger@google.com>
504
505 * auto-load.c (auto_load_expand_dir_vars): Update.
506 * defs.h (gdb_datadir): Change to std::string.
507 (python_libdir): Likewise.
508 (relocate_gdb_directory): Change return type to std::string.
509 * guile/guile.c (gdbscm_data_directory): Update.
510 (initialize_scheme_side): Update.
511 * jit.c (jit_reader_dir): Change to std::string.
512 (jit_reader_load_command): Update.
513 * main.c (gdb_datadir): Change to std::string.
514 (python_libdir): Likewise.
515 (set_gdb_data_directory): Update.
516 (relocate_path): Change to return std::string.
517 (relocate_gdb_directory): Change to return std::string.
518 (relocate_gdbinit_path_maybe_in_datadir): Update.
519 (captured_main_1): Update.
520 * python/python.c (do_start_initialization): Update.
521 * top.c (show_gdb_datadir): Update.
522 * xml-syscall.c (xml_init_syscalls_info): Update.
523 (init_syscalls_info): Update.
524
9224a013
CB
5252019-09-11 Christian Biesinger <cbiesinger@google.com>
526
527 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
528 out of get_init_files.
529 (get_init_files): Update.
530
f48cd836
CB
5312019-09-11 Christian Biesinger <cbiesinger@google.com>
532
533 * main.c (get_init_files): Change to use std::string.
534 (captured_main_1): Update.
535 (print_gdb_help): Update.
536
9cab7ecd
AT
5372019-09-11 Ali Tamur <tamur@google.com>
538
539 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
540 implementation.
541
67547d89
CB
5422019-09-11 Christian Biesinger <cbiesinger@google.com>
543
544 * dbxread.c (read_dbx_symtab): Update.
545 * dwarf2read.c (load_partial_dies): Update.
546 * mdebugread.c (parse_partial_symbols): Update.
547 (handle_psymbol_enumerators): Update.
548 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
549 * psymtab.c (add_psymbol_to_bcache): Likewise.
550 (add_psymbol_to_list): Likewise.
551 * symtab.c (symbol_set_names): Likewise.
552 * symtab.h (symbol_set_names): Likewise.
553 * xcoffread.c (scan_xcoff_symtab): Update.
554
64b2d4a0
TT
5552019-09-11 Tom Tromey <tom@tromey.com>
556
557 * symfile-mem.c (symbol_file_add_from_memory): Use
558 bfd_set_filename.
559 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
560 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
561
3b00ef10
TT
5622019-09-10 Tom Tromey <tromey@adacore.com>
563
564 * dwarf-index-write.c (write_psymbols): Extend error message.
565 (debug_names::insert): Add Ada code.
566 (debug_names::write_psymbols): Remove Ada check.
567 (debug_names) <m_string_obstack>: New member.
568 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
569 (gdb_index_symbol_name_matcher::matches): Remove.
570 (mapped_index_base::find_name_components_bounds): Add "lang"
571 parameter.
572 (mapped_index_base::build_name_components): Also split names
573 according to Ada syntax.
574 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
575 type of "match_callback".
576 (check_match, check_find_bounds_finds)
577 (dw2_expand_symtabs_matching): Update.
578 (dw2_debug_names_iterator): Add new constructor.
579 (dw2_debug_names_map_matching_symbols): New function.
580 (dw2_debug_names_expand_symtabs_matching): Update.
581 (dwarf2_debug_names_functions): Use
582 dw2_debug_names_map_matching_symbols.
583
aa391654
TT
5842019-09-10 Tom Tromey <tromey@adacore.com>
585
586 * dwarf2read.c (dw2_get_file_names_reader): Add the
587 CU's file name to the results.
588
b054970d
TT
5892019-09-10 Tom Tromey <tromey@adacore.com>
590
591 * ada-lang.c (add_nonlocal_symbols): Combine calls to
592 map_matching_symbols. Update.
593 * dwarf2read.c (dw2_map_matching_symbols): Update.
594 * psymtab.c (match_partial_symbol): Change type; update.
595 (psym_map_matching_symbols): Likewise.
596 * symfile-debug.c (debug_qf_map_matching_symbols): Change
597 type; update.
598 * symfile.h (struct quick_symbol_functions)
599 <map_matching_symbols>: Change "name" to be a lookup_name_info.
600 Remove "match".
601
6a3dbf1b
TT
6022019-09-10 Tom Tromey <tromey@adacore.com>
603
604 * psymtab.c (map_block): Remove.
605 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
606 * symtab.c (iterate_over_symbols_terminated): New function.
607 * symtab.c (iterate_over_symbols_terminated): Declare.
608
6969f124
TT
6092019-09-10 Tom Tromey <tromey@adacore.com>
610
611 * ada-lang.c (ada_iterate_over_symbols): Return bool.
612 * language.h (struct language_defn) <la_iterate_over_symbols>:
613 Return bool.
614 * symtab.c (iterate_over_symbols): Return bool.
615 * symtab.h (iterate_over_symbols): Return bool.
616
199b4314
TT
6172019-09-10 Tom Tromey <tromey@adacore.com>
618
619 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
620 (add_nonlocal_symbols): Update.
621 * dwarf2read.c (dw2_map_matching_symbols): Change type.
622 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
623 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
624 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
625 Change type of "callback". Remove "data".
626
a084a2a6
AT
627
6282019-09-09 Ali Tamur <tamur@google.com>
629
630 * dwarf2read.c (comp_unit_head): Update comment.
631 (dwarf2_dwo_name): New function declaration.
632 (dwarf_unit_type_name): New function declaration.
633 (read_comp_unit_head): Add support for new compilation units,
634 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
635 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
636 (currently named as "signature") in their header. Also clarify error
637 messages.
638 (lookup_dwo_id): New function. Returns the dwo id of the given
639 compile unit.
640 (lookup_dwo_unit): Use the new lookup_dwo_id function.
641 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
642 functions.
643 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
644 (dwarf2_dwo_name): Get the dwo name if present.
645 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
646 purposes.
647
25a2915e
TT
6482019-09-09 Tom Tromey <tom@tromey.com>
649
650 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
651
e4df0874
PW
6522019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
653
654 * python/python.c (do_start_initialization): Make progname_copy static,
655 to avoid a leak report.
656
8634b462
TT
6572019-09-08 Tom Tromey <tom@tromey.com>
658
659 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
660
c7f839cb
SM
6612019-09-07 Simon Marchi <simon.marchi@efficios.com>
662
663 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
664 Change type to gdb::optional<block_enum>.
665 (dw2_symtab_iter_init): Change block_index parameter type
666 to gdb::optional<block_enum>.
667 (dw2_lookup_symbol): Change block_index parameter
668 type to block_enum.c
669 (dw2_debug_names_lookup_symbol): Likewise.
670 * psymtab.c (psym_lookup_symbol): Likewise.
671 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
672 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
673 Likewise.
674
ead0e69a
CB
6752019-09-06 Christian Biesinger <cbiesinger@google.com>
676
677 * defs.h (relocate_gdb_directory): Change int to bool in
678 signature and rename flag to relocatable.
679 * main.c (relocate_path): Likewise.
680 (relocate_gdb_directory): Likewise.
681
b16c44de
AM
6822019-09-06 Alan Modra <amodra@gmail.com>
683
684 * coffread.c (coff_symfile_read): Constify filename variable.
685 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
686 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
687 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
688 * solib.c (reload_shared_libraries_1): Likewise.
689 * symfile.c (reread_symbols): Likewise.
690 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
691 * solib-darwin.c (darwin_bfd_open): Likewise.
692 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
693
06ff036e
AB
6942019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
695
696 * psymtab.c (print_partial_symbols): Handle missing domain_enum
697 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
698
4e962e74
TT
6992019-09-03 Tom Tromey <tromey@adacore.com>
700
701 * ada-valprint.c (ada_val_print_num): Don't recurse for range
702 types.
703 (has_negatives): Unbias a range type bound.
704 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
705 * gdbtypes.c (operator==): Handle new field.
706 (create_range_type): Add "bias" parameter.
707 (create_static_range_type, resolve_dynamic_range): Update.
708 * gdbtypes.h (struct range_bounds) <bias>: New member.
709 (create_range_type): Add bias parameter.
710 * printcmd.c (print_scalar_formatted): Unbias range types.
711 * value.c (unpack_long): Unbias range types.
712 (pack_long): Bias range types.
713
d90b8f26
AH
7142019-09-02 Alan Hayward <alan.hayward@arm.com>
715
716 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
717 probe arguments.
718
fe01123e
AH
7192019-09-02 Alan Hayward <alan.hayward@arm.com>
720
721 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
722 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
723 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
724 (compile_probe_arg): Likewise.
725 * probe.h (get_argument_count): Likewise.
726 * solib-svr4.c (solib_event_probe_action): Likewise.
727 * stap-probe.c (stap_probe::get_argument_count): Likewise.
728
e661ef01
AH
7292019-09-02 Alan Hayward <alan.hayward@arm.com>
730
731 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
732 code to here...
733 (svr4_create_solib_event_breakpoints): ...from here.
734
47a536d9
SDJ
7352019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
736
737 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
738 suffix from warning message.
739
d6a00eba
TT
7402019-08-30 Tom Tromey <tom@tromey.com>
741
742 * tui/tui-winsource.h (struct tui_source_window_base)
743 <refresh_all>: Don't declare.
744 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
745 Remove.
746 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
747 tui_show_locator_content.
748 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
749 declare.
750 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
751 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
752 declare.
753
55b2657b
TT
7542019-08-30 Tom Tromey <tom@tromey.com>
755
756 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
757
12a8555a
TT
7582019-08-30 Tom Tromey <tom@tromey.com>
759
760 * tui/tui-stack.c (_initialize_tui_stack): Move later.
761 Remove unnecessary forward declarations.
762
900ac242
TT
7632019-08-30 Tom Tromey <tom@tromey.com>
764
765 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
766 rerender.
767 (tui_update_locator_fullname, tui_show_frame_info): Don't call
768 tui_show_locator_content.
769
99ab33fb
TT
7702019-08-30 Tom Tromey <tom@tromey.com>
771
772 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
773 (tui_locator_window::rerender): Rewrite using body of previous
774 tui_show_locator_content.
775
e594a5d1
TT
7762019-08-30 Tom Tromey <tom@tromey.com>
777
778 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
779 set_locator_fullname>: New methods.
780 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
781 Rename from tui_set_locator_fullname.
782 (tui_locator_window::set_locator_info): Rename from
783 tui_set_locator_info. Return bool.
784 (tui_update_locator_fullname, tui_show_frame_info): Update.
785
715bb467
TT
7862019-08-30 Tom Tromey <tom@tromey.com>
787
788 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
789
772f3f03
TT
7902019-08-30 Tom Tromey <tom@tromey.com>
791
792 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
793 call touchwin.
794
108e13ab
TT
7952019-08-30 Tom Tromey <tom@tromey.com>
796
797 * tui/tui-wingeneral.c (box_win): Assume win_info and
798 win_info->handle cannot be NULL.
799
cdaa6eb4
TT
8002019-08-30 Tom Tromey <tom@tromey.com>
801
802 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
803 refresh_window>: Declare.
804 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
805 resize.
806 (tui_data_item_window::rerender): Rename from
807 tui_display_register.
808 (tui_data_item_window::refresh_window): New method.
809 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
810 no-op.
811
89df7f90
TT
8122019-08-30 Tom Tromey <tom@tromey.com>
813
814 * tui/tui-regs.h (struct tui_data_window) <regs_content,
815 regs_column_count, current_group>: Move later. Now private.
816 <get_current_group>: New method.
817 * tui/tui-regs.c (tui_reg_command): Update.
818 * tui/tui-layout.c (tui_set_layout): Update.
819
1bf2866a
TT
8202019-08-30 Tom Tromey <tom@tromey.com>
821
822 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
823 (tui_data_window::rerender): Don't call
824 check_and_display_highlight_if_needed.
825 (tui_data_window::refresh_all): Remove call to
826 erase_data_content.
827
0670413d
TT
8282019-08-30 Tom Tromey <tom@tromey.com>
829
830 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
831 (tui_data_window::display_registers_from)
832 (tui_data_window::display_reg_element_at_line)
833 (tui_data_window::display_registers_from_line): Remove checks of
834 "empty".
835
18bb55c7
TT
8362019-08-30 Tom Tromey <tom@tromey.com>
837
838 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
839 Don't declare.
840 * tui/tui-regs.c (tui_data_window::show_registers): Call
841 rerender.
842 (tui_data_window::rerender): Rename from display_all_data.
843 (tui_data_window::rerender): Remove old implementation.
844
1f6d2f10
TT
8452019-08-30 Tom Tromey <tom@tromey.com>
846
847 * tui/tui-regs.c (tui_data_window::display_all_data): Change
848 text.
849 * tui/tui-data.h (NO_DATA_STRING): Remove define.
850
16d01f9c
BW
8512019-08-29 Bernhard Wodok <barto@gmx.net>
852 Sergio Durigan Junior <sergiodj@redhat.com>
853
854 PR win32/24284
855 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
856
d8f27c60
AB
8572019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
858
859 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
860 when searching for types.
861
1f20c35e
AB
8622019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
863
864 * f-lang.c (f_language_defn): Use f_print_typedef.
865 * f-lang.h (f_print_typedef): Declare.
866 * f-typeprint.c (f_print_typedef): Define.
867
550105b7
CB
8682019-08-27 Christian Biesinger <cbiesinger@google.com>
869
870 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
871
4acfdd20
AB
8722019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
873
874 * cli/cli-utils.c (info_print_options_defs): Delete.
875 (make_info_print_options_def_group): Delete.
876 (extract_info_print_options): Delete.
877 (info_print_command_completer): Delete.
878 (info_print_args_help): Add extra parameter, and optionally
879 include text about -n flag.
880 * cli/cli-utils.h (struct info_print_options): Delete.
881 (extract_info_print_options): Delete declaration.
882 (info_print_command_completer): Delete declaration.
883 (info_print_args_help): Add extra parameter, extend header
884 comment.
885 * python/python.c (gdbpy_rbreak): Pass additional parameter to
886 search_symbols.
887 * stack.c (struct info_print_options): New type.
888 (info_print_options_defs): New file scoped variable.
889 (make_info_print_options_def_group): New static function.
890 (info_print_command_completer): New static function.
891 (info_locals_command): Update to use new local functions.
892 (info_args_command): Likewise.
893 (_initialize_stack): Add extra parameter to calls to
894 info_print_args_help.
895 * symtab.c (search_symbols): Add extra parameter, use this to
896 possibly excluse non-debug symbols.
897 (symtab_symbol_info): Add extra parameter, which is passed on to
898 search_symbols.
899 (struct info_print_options): New type.
900 (info_print_options_defs): New file scoped variable.
901 (make_info_print_options_def_group): New static function.
902 (info_print_command_completer): New static function.
903 (info_variables_command): Update to use local functions, and pass
904 extra parameter through to symtab_symbol_info.
905 (info_functions_command): Likewise.
906 (info_types_command): Pass additional argument through to
907 symtab_symbol_info.
908 (rbreak_command): Pass extra argument to search_symbols.
909 (_initialize_symtab): Add extra arguments for calls to
910 info_print_args_help, and update help text for 'info variables',
911 'whereis', and 'info functions' commands.
912 * symtab.h (search_symbols): Add extra argument to declaration.
913 * NEWS: Mention new flags.
914
9aa55206
CB
9152019-08-26 Christian Biesinger <cbiesinger@google.com>
916
917 * symtab.c (lookup_static_symbol): Call the new function (and move
918 it down to be next to lookup_global_symbol).
919 (struct global_sym_lookup_data): Add block_enum member and rename to...
920 (struct global_or_static_sym_lookup_data): ...this.
921 (lookup_symbol_global_iterator_cb): Pass block_index instead of
922 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
923 (lookup_symbol_global_or_static_iterator_cb): ...this.
924 (lookup_global_or_static_symbol): New function.
925 (lookup_global_symbol): Call new function.
926
5c31b358
TV
9272019-08-26 Tom de Vries <tdevries@suse.de>
928
929 PR c++/24852
930 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
931 when pc_probe.prob == NULL.
932
23c13d42
SM
9332019-08-25 Simon Marchi <simon.marchi@efficios.com>
934
935 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
936 variable symbol_linkage to symbol_linkage_.
937
beadd3e8
SM
9382019-08-25 Simon Marchi <simon.marchi@efficios.com>
939
940 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
941 represent whether the symbol is static, dynamic, or we don't
942 know.
943
e3ec872f
YS
9442019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
945
946 * gdb/rx-tdep.c (rx_register_names): New.
947 (rx_register_name): Delete.
948 (rx_psw_type): Delete.
949 (rx_fpsw_type): Delete.
950 (rx_register_type): Delete.
951 (rx_gdbarch_init): Convert target-descriptions.
952 (_initialize_rx_tdep): Add initialize_tdesc_rx.
953 * gdb/features/Makefile: Add rx.xml.
954 * gdb/features/rx.xml: New.
955 * gdb/features/rx.c: Generated.
956 * gdb/NEWS: Mention target description support.
957
d0509ba4
CB
9582019-08-22 Christian Biesinger <cbiesinger@google.com>
959
960 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
961 *slot_ptr.
962
2d41fa11
SDJ
9632019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
964
965 * configure.ac: Don't check for 'dlfcn.h' (moved to
966 gdbsupport/common.m4).
967 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
968 'gdbsupport/'.
969 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
970 * compile/compile-c-support.c: Include
971 'gdbsupport/gdb-dlfcn.h'.
972 * gdbsupport/common.m4: Check for 'dlfcn.h'.
973 * gdb-dlfcn.c: Move to...
974 * gdbsupport/gdb-dlfcn.c: ... here.
975 * gdb-dlfcn.h: Move to...
976 * gdbsupport/gdb-dlfcn.h: ... here.
977
de8af808
SL
9782019-08-23 Sandra Loosemore <sandra@codesourcery.com>
979
980 * nios2-tdep.c (struct reg_value): Improve comments. Make
981 the offset field signed.
982
27204489
CB
9832019-08-22 Christian Biesinger <cbiesinger@google.com>
984
985 * python/lib/gdb/__init__.py (_execute_file): New function.
986 * python/python.c (python_run_simple_file): Call gdb._execute_file
987 on Windows.
988
43771869
AB
9892019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
990
991 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
992 all uses as this was never set to anything but a zero value.
993
26c957f1
PA
9942019-08-21 Bogdan Harjoc <harjoc@gmail.com>
995
996 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
997
c07aae6e
CB
9982019-08-21 Christian Biesinger <cbiesinger@google.com>
999
1000 * tui/tui-data.h (tui_gen_win_info): Add an =default
1001 move constructor, required by some GCC versions.
1002
3960cb7a
JF
10032019-08-21 Jinke Fan <fanjinke51@yeah.net>
1004
1005 * go32-nat.c (go32_sysinfo): Add hygon_p.
1006
04c72a68
TT
10072019-08-20 Tom Tromey <tom@tromey.com>
1008
1009 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1010 line_from_reg_element_no, first_reg_element_no_inline,
1011 display_all_data, delete_data_content_windows,
1012 erase_data_content>: Now private.
1013
072272ce
TT
10142019-08-20 Tom Tromey <tom@tromey.com>
1015
1016 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1017 (tui_unhighlight_win, tui_highlight_win)
1018 (tui_win_info::make_window): Update.
1019 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1020
973961bd
TT
10212019-08-20 Tom Tromey <tom@tromey.com>
1022
1023 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1024 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1025 (MAX_PID_WIDTH): Move to tui-stack.c.
1026 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1027 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1028 (MAX_PID_WIDTH): Move from tui-data.h.
1029
ab0e1f1a
TT
10302019-08-20 Tom Tromey <tom@tromey.com>
1031
1032 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1033 * tui/tui-wingeneral.c (box_win): Change type of win_info.
1034 (box_win): Update.
1035 (tui_gen_win_info::make_window): Rename from tui_make_window.
1036 (tui_win_info::make_window): New method.
1037 (tui_gen_win_info::make_visible): Update.
1038 * tui/tui-source.c (tui_source_window::set_contents): Update.
1039 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1040 (tui_data_window::display_registers_from): Update.
1041 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1042 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1043 Declare.
1044 <can_box>: Remove.
1045 <title>: Remove.
1046 (struct tui_win_info) <make_window>: Declare.
1047 <can_box>: Now virtual.
1048 <title>: New member.
1049 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1050 * tui/tui-command.c (tui_cmd_window::resize): Update.
1051
100c2bf3
TT
10522019-08-20 Tom Tromey <tom@tromey.com>
1053
1054 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1055 * tui/tui-regs.c (tui_data_window::show_registers): Update.
1056 (tui_data_window::check_register_values): Update.
1057
fa4dc567
TT
10582019-08-20 Tom Tromey <tom@tromey.com>
1059
1060 * tui/tui-regs.h (struct tui_data_window): Use
1061 DISABLE_COPY_AND_ASSIGN.
1062 <regs_content>: Change type, removing unique_ptr.
1063 <tui_data_window>: Add move constructor.
1064 * tui/tui-regs.c (tui_data_window::show_registers)
1065 (tui_data_window::show_register_group)
1066 (tui_data_window::display_registers_from)
1067 (tui_data_window::display_registers_from)
1068 (tui_data_window::first_data_item_displayed)
1069 (tui_data_window::delete_data_content_windows)
1070 (tui_data_window::rerender, tui_data_window::refresh_window)
1071 (tui_data_window::check_register_values): Update.
1072
ca02d7c8
TT
10732019-08-20 Tom Tromey <tom@tromey.com>
1074
1075 * tui/tui-regs.h (struct tui_data_window) <show_registers,
1076 show_register_group>: Declare.
1077 (tui_show_register_group): Don't declare.
1078 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1079 tui_show_registers.
1080 (tui_data_window::show_register_group): Rename from
1081 tui_show_register_group.
1082 (tui_data_window::check_register_values, tui_reg_command):
1083 Update.
1084 * tui/tui-layout.c (tui_set_layout): Update.
1085
63356bfd
TT
10862019-08-20 Tom Tromey <tom@tromey.com>
1087
1088 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1089 Declare.
1090 (tui_check_register_values): Don't declare.
1091 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1092 from tui_check_register_values.
1093 * tui/tui-hooks.c (tui_register_changed): Update.
1094
42cc14a7
TT
10952019-08-20 Tom Tromey <tom@tromey.com>
1096
1097 * tui/tui-regs.c (tui_reg_layout): Move later.
1098 (tui_show_registers): Don't enable TUI mode or change layout.
1099
b9ad3686
TT
11002019-08-20 Tom Tromey <tom@tromey.com>
1101
1102 * tui/tui-regs.h (struct tui_data_item_window)
1103 <~tui_data_item_window>: Remove.
1104 <content>: Now a unique_xmalloc_ptr.
1105 * tui/tui-regs.c (tui_register_format): Return a
1106 unique_xmalloc_ptr.
1107 (tui_get_register): Update.
1108 (~tui_data_item_window): Remove.
1109 (tui_data_window::display_registers_from, tui_display_register):
1110 Update.
1111 * tui/tui-io.h (tui_expand_tabs): Update.
1112 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1113 Remove "col" parameter.
1114
8e114aab
TT
11152019-08-20 Tom Tromey <tom@tromey.com>
1116
1117 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1118 field.
1119 * tui/tui-regs.c (~tui_data_item_window): Update.
1120
1a4f81dd
TT
11212019-08-20 Tom Tromey <tom@tromey.com>
1122
1123 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1124 earlier.
1125
0f8d8876
TT
11262019-08-20 Tom Tromey <tom@tromey.com>
1127
1128 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1129
605dc2c2
TT
11302019-08-20 Tom Tromey <tom@tromey.com>
1131
1132 * tui/tui-source.h (struct tui_source_window): Update.
1133 * tui/tui-regs.c (tui_show_registers): Update.
1134 * tui/tui-disasm.h (struct tui_disasm_window): Update.
1135 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1136 (NO_REGS_STRING): Remove defines.
1137
aedbe3bb
CM
11382019-08-20 Conrad Meyer <cem@FreeBSD.org>
1139
1140 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1141 unnecessary thread walk if remote doesn't support the packet.
1142
7ce8f214
TT
11432019-08-19 Tom Tromey <tromey@adacore.com>
1144
1145 * python/py-value.c (value_has_field): Fix indentation.
1146
f21c2bd7
TT
11472019-08-19 Tom Tromey <tromey@adacore.com>
1148
1149 * printcmd.c (do_one_display, info_display_command): Update.
1150 * block.h (contained_in): Return bool. Add allow_nested
1151 parameter.
1152 * block.c (contained_in): Return bool. Add allow_nested
1153 parameter.
1154
d806ea2d
TT
11552019-08-19 Tom Tromey <tom@tromey.com>
1156
1157 * configure: Rebuild.
1158 * configure.ac: Disallow the combination of -static-libstdc++ and
1159 source highlight.
1160 * source-cache.c (get_language_name): Handle rust.
1161 (source_cache::get_source_lines): Ignore highlighting exceptions.
1162
398fdd60
TT
11632019-08-16 Tom Tromey <tom@tromey.com>
1164
1165 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1166 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1167 (struct tui_source_window_base) <make_visible, refresh_window,
1168 resize>: Remove methods.
1169 <execution_info>: Remove field.
1170 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1171 (tui_show_source_line, tui_source_window_base)
1172 (~tui_source_window_base): Update.
1173 (tui_source_window_base::resize)
1174 (tui_source_window_base::make_visible)
1175 (tui_source_window_base::refresh_window): Remove.
1176 (tui_source_window_base::update_exec_info): Update.
1177 * tui/tui-source.c (tui_source_window::set_contents): Update.
1178 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1179
e699d331
TT
11802019-08-16 Tom Tromey <tom@tromey.com>
1181
1182 * tui/tui-hooks.c (tui_remove_hooks): Don't set
1183 deprecated_query_hook.
1184
bb01dbfc
TT
11852019-08-16 Tom Tromey <tom@tromey.com>
1186
1187 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1188 (tui_update_source_windows_with_line): Update.
1189 * tui/tui-source.h (struct tui_source_window)
1190 <show_symtab_source>: Declare.
1191 (tui_show_symtab_source): Don't declare.
1192 * tui/tui-source.c (tui_show_symtab_source): Rename from
1193 tui_show_symtab_source.
1194
81c82c4b
TT
11952019-08-16 Tom Tromey <tom@tromey.com>
1196
1197 * tui/tui-winsource.h (struct tui_source_window_base)
1198 <set_contents>: Declare.
1199 * tui/tui-winsource.c
1200 (tui_source_window_base::update_source_window_as_is): Update.
1201 * tui/tui-source.h (struct tui_source_window) <set_contents>:
1202 Declare.
1203 (tui_set_source_content): Don't declare.
1204 * tui/tui-source.c (tui_source_window::set_contents): Rename from
1205 tui_set_source_content.
1206 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1207 Declare.
1208 (tui_set_disassem_content): Don't declare.
1209 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1210 tui_set_disassem_content.
1211
2ddaf614
TT
12122019-08-16 Tom Tromey <tom@tromey.com>
1213
1214 * tui/tui-winsource.h (struct tui_source_window_base)
1215 <update_breakpoint_info>: Declare.
1216 (tui_update_breakpoint_info): Don't declare.
1217 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1218 (tui_update_all_breakpoint_info): Update.
1219 (tui_source_window_base::update_breakpoint_info): Rename from
1220 tui_update_breakpoint_info.
1221 (tui_source_window_base::update_exec_info): Update.
1222
017f9828
TT
12232019-08-16 Tom Tromey <tom@tromey.com>
1224
1225 * tui/tui-winsource.h (struct tui_source_window_base)
1226 <update_source_window>: Declare.
1227 (tui_update_source_window): Don't declare.
1228 * tui/tui-winsource.c
1229 (tui_source_window_base::update_source_window): Rename from
1230 tui_update_source_window.
1231 (tui_source_window_base::rerender): Update.
1232 * tui/tui-source.c (tui_source_window::maybe_update): Update.
1233 * tui/tui-disasm.c (tui_show_disassem)
1234 (tui_show_disassem_and_update_source)
1235 (tui_disasm_window::maybe_update): Update.
1236
ed8358e9
TT
12372019-08-16 Tom Tromey <tom@tromey.com>
1238
1239 * tui/tui-winsource.h (struct tui_source_window_base)
1240 <update_source_window_as_is>: Declare.
1241 (tui_update_source_window_as_is): Don't declare.
1242 * tui/tui-winsource.c (tui_update_source_window): Update
1243 (tui_source_window_base::update_source_window_as_is): Rename from
1244 tui_update_source_window_as_is.
1245 (tui_source_window_base::refill): Update.
1246 * tui/tui-source.c (tui_show_symtab_source): Update.
1247 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1248 Update.
1249
20149b6b
TT
12502019-08-16 Tom Tromey <tom@tromey.com>
1251
1252 * tui/tui-winsource.h (tui_update_source_window)
1253 (tui_update_source_window_as_is): Remove "noerror" parameter.
1254 * tui/tui-winsource.c (tui_update_source_window)
1255 (tui_update_source_window_as_is): Remove "noerror" parameter.
1256 (tui_update_source_windows_with_addr)
1257 (tui_update_source_windows_with_line)
1258 (tui_source_window_base::rerender)
1259 (tui_source_window_base::refill): Update.
1260 * tui/tui-source.h (tui_set_source_content)
1261 (tui_show_symtab_source): Remove "noerror" parameter.
1262 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1263 parameter.
1264 (tui_show_symtab_source): Likewise.
1265 (tui_source_window::maybe_update): Update.
1266 * tui/tui-disasm.c (tui_show_disassem)
1267 (tui_show_disassem_and_update_source)
1268 (tui_disasm_window::do_scroll_vertical)
1269 (tui_disasm_window::maybe_update): Update.
1270
2d83e710
TT
12712019-08-16 Tom Tromey <tom@tromey.com>
1272
1273 * tui/tui.c (tui_is_window_visible): Update.
1274 * tui/tui-wingeneral.c (tui_make_window)
1275 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1276 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1277 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1278 (tui_set_win_height_command, parse_scrolling_args): Update.
1279 * tui/tui-source.c (tui_source_window::style_changed): Update.
1280 * tui/tui-regs.c (tui_show_registers)
1281 (tui_data_window::first_data_item_displayed)
1282 (tui_data_window::delete_data_content_windows)
1283 (tui_check_register_values, tui_reg_command): Update.
1284 * tui/tui-disasm.c (tui_show_disassem): Update.
1285 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1286 method.
1287 <is_visible>: Remove field.
1288 * tui/tui-data.c (tui_next_win, tui_prev_win)
1289 (tui_delete_invisible_windows): Update.
1290
d4ab829a
TT
12912019-08-16 Tom Tromey <tom@tromey.com>
1292
1293 * tui/tui-winsource.h (struct tui_source_window_base)
1294 <m_has_locator>: Remove.
1295 * tui/tui-layout.c (show_source_disasm_command, show_data)
1296 (show_source_or_disasm_and_command): Update.
1297
aa7ca1bb
AH
12982019-08-16 Alan Hayward <alan.hayward@arm.com>
1299
1300 * NEWS (Other MI changes): New subsection.
1301 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1302 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1303 * arch-utils.c (default_get_pc_address_flags): New function.
1304 * arch-utils.h (default_get_pc_address_flags): New declaration.
1305 * gdbarch.sh: Add get_pc_address_flags.
1306 * gdbarch.c: Regenerate.
1307 * gdbarch.h: Likewise.
1308 * stack.c (print_pc): New function.
1309 (print_frame_info) (print_frame): Call print_pc.
1310
6eac171f
TV
13112019-08-16 Tom de Vries <tdevries@suse.de>
1312
1313 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1314 print_objfile_section_info.
1315
3df505f6
TT
13162019-08-15 Tom Tromey <tom@tromey.com>
1317
1318 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1319 calling update_cmdwin_start_line.
1320 * tui/tui-winsource.h (struct tui_source_window_base)
1321 <do_make_visible_with_new_height, set_new_height>: Don't declare.
1322 <rerender>: Declare.
1323 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1324 Call rerender.
1325 (tui_source_window_base::set_new_height): Remove.
1326 (tui_source_window_base::rerender): Rename from
1327 do_make_visible_with_new_height.
1328 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1329 resize method.
1330 (tui_win_info::make_invisible_and_set_new_height)
1331 (tui_win_info::make_visible_with_new_height): Remove.
1332 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1333 Declare.
1334 * tui/tui-stack.c (tui_locator_window::rerender): New method.
1335 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1336 do_make_visible_with_new_height>: Don't declare.
1337 <rerender>: Declare.
1338 * tui/tui-regs.c (tui_data_window::rerender): Rename from
1339 set_new_height.
1340 (tui_data_window::do_make_visible_with_new_height): Remove.
1341 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1342 call tui_show_locator_content.
1343 (tui_gen_win_info::resize): Call rerender.
1344 (show_source_or_disasm_and_command): Don't call
1345 tui_show_locator_content.
1346 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1347 method.
1348 (struct tui_win_info) <rerender>: Declare.
1349 <set_new_height, make_invisible_and_set_new_height,
1350 make_visible_with_new_height>: Don't declare.
1351 * tui/tui-data.c (tui_win_list::rerender): New method.
1352 * tui/tui-command.h (struct tui_cmd_window)
1353 <do_make_visible_with_new_height>: Don't declare.
1354 * tui/tui-command.c
1355 (tui_cmd_window::do_make_visible_with_new_height): Remove.
1356
272560b5
TT
13572019-08-15 Tom Tromey <tromey@adacore.com>
1358
1359 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1360 * ada-lang.c (ada_enum_name): Likewise.
1361
08235187
CB
13622019-08-15 Christian Biesinger <cbiesinger@google.com>
1363
1364 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1365 leading underscore.
1366 (GdbOutputErrorFile): Likewise.
1367 (global scope): Adjust constructor calls to GdbOutput{,Error}File
1368 accordingly.
1369 (execute_unwinders): Rename to have a leading underscore.
1370 (auto_load_packages): Likewise.
1371 (global scope): Adjust call to auto_load_packages accordingly.
1372 (GdbSetPythonDirectory): Likewise.
1373 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1374 instead of execute_unwinders.
1375
db502012
TT
13762019-08-15 Tom Tromey <tom@tromey.com>
1377
1378 * tui/tui-layout.c (show_layout, show_source_disasm_command)
1379 (show_data): Don't change window visibility.
1380 (tui_gen_win_info::resize): Remove special case for command
1381 window. Use wresize, when available.
1382 (show_source_or_disasm_and_command): Don't change window
1383 visibility.
1384 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1385 <make_visible>: New method.
1386 * tui/tui-command.c (tui_cmd_window::resize): New method.
1387
3891b65e
TT
13882019-08-15 Tom Tromey <tom@tromey.com>
1389
1390 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1391 (struct tui_source_windows): New.
1392 * tui/tui-winsource.c (tui_display_main): Update.
1393 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1394 (new_height_ok, parse_scrolling_args): Update.
1395 * tui/tui-layout.c (show_layout, show_data): Update.
1396 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1397 (tui_add_to_source_windows): Don't declare.
1398 * tui/tui-data.c (source_windows, tui_source_windows)
1399 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1400
ee556432
TT
14012019-08-15 Tom Tromey <tom@tromey.com>
1402
1403 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1404 Rename from reset.
1405 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1406 * tui/tui-layout.c (show_source_disasm_command, show_data):
1407 Update.
1408 (tui_gen_win_info::resize): Rename.
1409 (show_source_or_disasm_and_command): Update.
1410 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1411 reset.
1412
46f438e3
TT
14132019-08-15 Tom Tromey <tom@tromey.com>
1414
1415 * tui/tui-stack.c (tui_initialize_static_data): Remove.
1416 * tui/tui-interp.c (tui_interp::init): Don't call
1417 tui_initialize_static_data.
1418 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1419
f4ce562c
TT
14202019-08-15 Tom Tromey <tom@tromey.com>
1421
1422 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1423 examine tui_win_list.
1424
c398c3d0
TT
14252019-08-15 Tom Tromey <tom@tromey.com>
1426
1427 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1428 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1429 tui_clear_source_content.
1430 (tui_clear_source_content): Remove.
1431 (tui_source_window_base::do_erase_source_content): Hoist call to
1432 content.clear().
1433 * tui/tui-stack.c (tui_show_frame_info): Don't call
1434 tui_clear_source_content.
1435
e25d2004
TT
14362019-08-15 Tom Tromey <tom@tromey.com>
1437
1438 * tui/tui-winsource.h (struct tui_source_window_base)
1439 <do_erase_source_content>: New method.
1440 <erase_source_content>: New method.
1441 (tui_erase_source_content): Don't declare.
1442 * tui/tui-winsource.c (tui_clear_source_content): Update.
1443 (tui_source_window_base::do_erase_source_content): Rename from
1444 tui_erase_source_content.
1445 (tui_source_window_base::show_source_content): Update.
1446 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1447 * tui/tui-source.h (struct tui_source_window)
1448 <erase_source_content>: New method.
1449 * tui/tui-disasm.h (struct tui_disasm_window)
1450 <erase_source_content>: New method.
1451
002f15c2
TT
14522019-08-15 Tom Tromey <tom@tromey.com>
1453
1454 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1455 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1456 constructor.
1457 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1458 * tui/tui-source.c (tui_set_source_content): Update.
1459 * tui/tui-disasm.c (tui_set_disassem_content): Update.
1460
c9033fe8
TT
14612019-08-15 Tom Tromey <tom@tromey.com>
1462
1463 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1464 * tui/tui-winsource.c (tui_line_is_displayed): Move to
1465 tui-source.c.
1466 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1467 Declare.
1468 * tui/tui-source.c (tui_source_window::line_is_displayed): New
1469 method.
1470 (tui_source_window::maybe_update): Update.
1471
088f37dd
TT
14722019-08-15 Tom Tromey <tom@tromey.com>
1473
1474 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1475 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1476 tui-disasm.c.
1477 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1478 Declare.
1479 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1480 method.
1481 (tui_disasm_window::maybe_update): Update.
1482
a54700c6
TT
14832019-08-15 Tom Tromey <tom@tromey.com>
1484
1485 * tui/tui-winsource.h (struct tui_source_window_base)
1486 <maybe_update>: Declare.
1487 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1488 method.
1489 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1490 Declare.
1491 * tui/tui-source.c (tui_source_window::maybe_update): New method.
1492 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1493 Declare.
1494 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1495
e2a678a5
TT
14962019-08-15 Tom Tromey <tom@tromey.com>
1497
1498 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1499
f2dda477
TT
15002019-08-15 Tom Tromey <tom@tromey.com>
1501
1502 * tui/tui-wingeneral.c: Include tui-stack.h.
1503 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1504 (struct tui_locator_window): Move from tui-data.h.
1505 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1506 (tui_initialize_static_data): Move from tui-data.c.
1507 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1508 (struct tui_locator_window): Move to tui-stack.c.
1509 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1510 (tui_initialize_static_data): Move to tui-stack.c.
1511
ed4a1084
TT
15122019-08-15 Tom Tromey <tom@tromey.com>
1513
1514 * tui/tui-layout.c (show_source_disasm_command)
1515 (show_source_or_disasm_and_command): Use make_visible method, not
1516 tui_make_window.
1517 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1518 Remove.
1519
65962b20
TT
15202019-08-15 Tom Tromey <tom@tromey.com>
1521
1522 * tui/tui-wingeneral.h (tui_make_window): Update.
1523 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1524 parameter.
1525 (tui_gen_win_info::make_visible): Update.
1526 * tui/tui-regs.c (tui_data_window::display_registers_from):
1527 Update.
1528 * tui/tui-layout.c (show_source_disasm_command)
1529 (show_source_or_disasm_and_command): Update.
1530 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1531 (enum tui_box): Remove.
1532 (struct tui_win_info) <can_box>: New method.
1533 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1534 method.
1535
2208ee91
TV
15362019-08-15 Tom de Vries <tdevries@suse.de>
1537
1538 * linux-nat-trad.c: Include gdbarch.h.
1539
75faf5c4
AH
15402019-08-14 Alan Hayward <alan.hayward@arm.com>
1541
1542 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1543 register sizes.
1544
b1c896b3
TT
15452019-08-14 Tom Tromey <tromey@adacore.com>
1546
1547 * darwin-nat.c: Include gdbarch.h.
1548 * darwin-nat-info.c: Include gdbarch.h.
1549
6405cd73
TT
15502019-08-13 Tom Tromey <tom@tromey.com>
1551
1552 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1553 Remove.
1554 * tui/tui-data.c (tui_initialize_static_data): Update.
1555
5216580d
TT
15562019-08-13 Tom Tromey <tom@tromey.com>
1557
1558 * tui/tui-winsource.h (struct tui_exec_info_window)
1559 <~tui_exec_info_window, maybe_allocate_content, get_content,
1560 m_content>: Remove.
1561 (struct tui_source_window_base) <set_exec_info_content,
1562 show_exec_info_content>: Don't declare.
1563 * tui/tui-winsource.c
1564 (tui_exec_info_window::maybe_allocate_content): Remove.
1565 (tui_source_window_base::update_exec_info): Rename from
1566 set_exec_info_content.
1567 (tui_source_window_base::show_exec_info_content)
1568 (tui_source_window_base::update_exec_info): Remove.
1569
93858ad3
TT
15702019-08-13 Tom Tromey <tom@tromey.com>
1571
1572 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1573 declare.
1574 * tui/tui-winsource.c (tui_update_source_window_as_is)
1575 (tui_update_source_windows_with_addr, tui_erase_source_content):
1576 Update.
1577 (tui_clear_exec_info_content): Remove.
1578
e321e7ce
TT
15792019-08-13 Tom Tromey <tom@tromey.com>
1580
1581 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1582 declare.
1583 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1584 call tui_erase_exec_info_content.
1585 (tui_clear_exec_info_content): Rename from
1586 tui_erase_exec_info_content.
1587 (tui_clear_exec_info_content): Delete.
1588
8270ac62
TT
15892019-08-13 Tom Tromey <tom@tromey.com>
1590
1591 * tui/tui-winsource.h (struct tui_source_window_base)
1592 <show_exec_info_content>: Declare.
1593 (tui_show_exec_info_content): Don't declare.
1594 * tui/tui-winsource.c
1595 (tui_source_window_base::show_exec_info_content): Rename from
1596 tui_show_exec_info_content.
1597 (tui_source_window_base::update_exec_info): Update.
1598
7b56485d
TT
15992019-08-13 Tom Tromey <tom@tromey.com>
1600
1601 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1602 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1603 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1604 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1605 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1606 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1607 ... here.
1608
7ba913dc
TT
16092019-08-13 Tom Tromey <tom@tromey.com>
1610
1611 * tui/tui-winsource.h (struct tui_source_window_base)
1612 <update_exec_info>: Declare.
1613 (tui_update_exec_info): Don't declare.
1614 * tui/tui-winsource.c (tui_update_source_window_as_is)
1615 (tui_source_window_base::refresh_all)
1616 (tui_update_all_breakpoint_info): Update.
1617 (tui_source_window_base::update_exec_info): Rename from
1618 tui_update_exec_info.
1619 * tui/tui-stack.c (tui_show_frame_info): Update.
1620
37a4a131
TT
16212019-08-13 Tom Tromey <tom@tromey.com>
1622
1623 * tui/tui-winsource.h (struct tui_source_window_base)
1624 <set_exec_info_content>: Declare.
1625 (tui_set_exec_info_content): Don't declare.
1626 * tui/tui-winsource.c
1627 (tui_source_window_base::set_exec_info_content): Rename from
1628 tui_set_exec_info_content.
1629 (tui_update_exec_info): Update.
1630
0bd27e07
TT
16312019-08-13 Tom Tromey <tom@tromey.com>
1632
1633 * tui/tui-winsource.h (struct tui_source_window_base)
1634 <show_source_content>: Declare.
1635 (tui_show_source_content): Don't declare.
1636 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1637 (tui_source_window_base::show_source_content): Rename from
1638 tui_show_source_content.
1639 (tui_source_window_base::refresh_all): Update.
1640 * tui/tui-layout.c (show_source_disasm_command)
1641 (show_source_or_disasm_and_command): Update.
1642
b4ef5aeb
TT
16432019-08-13 Tom Tromey <tom@tromey.com>
1644
1645 * tui/tui-winsource.c (tui_erase_source_content)
1646 (tui_show_source_content, tui_source_window_base::refresh_all):
1647 Update.
1648 * tui/tui-wingeneral.h
1649 (tui_check_and_display_highlight_if_needed): Don't declare.
1650 * tui/tui-wingeneral.c
1651 (tui_win_info::check_and_display_highlight_if_needed): Rename from
1652 check_and_display_highlight_if_needed.
1653 * tui/tui-win.c (tui_rehighlight_all)
1654 (tui_win_info::make_visible_with_new_height): Update.
1655 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1656 (tui_data_window::erase_data_content)
1657 (tui_data_window::display_all_data): Update.
1658 * tui/tui-data.h (struct tui_win_info)
1659 <check_and_display_highlight_if_needed>: Declare.
1660
fede5273
TT
16612019-08-13 Tom Tromey <tom@tromey.com>
1662
1663 * tui/tui-win.c (tui_resize_all): Call
1664 tui_delete_invisible_windows.
1665 * tui/tui-layout.c (show_layout): Call
1666 tui_delete_invisible_windows.
1667 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1668 * tui/tui-data.c (tui_delete_invisible_windows): New function.
1669
22c3f490
TT
16702019-08-13 Tom Tromey <tom@tromey.com>
1671
1672 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
1673 tui_add_win_to_layout.
1674
16cb7910
TT
16752019-08-13 Tom Tromey <tom@tromey.com>
1676
1677 * tui/tui-layout.h (tui_default_win_height): Don't declare.
1678 * tui/tui-layout.c (tui_default_win_height): Now static.
1679
cc0c3ffb
TT
16802019-08-13 Tom Tromey <tom@tromey.com>
1681
1682 * tui/tui-layout.c (show_layout): Unify all layout cases into a
1683 single switch.
1684 (show_source_disasm_command, show_source_or_disasm_and_command):
1685 Don't check current layout.
1686
3f3ffe54
TT
16872019-08-13 Tom Tromey <tom@tromey.com>
1688
1689 * tui/tui-wingeneral.c (make_all_visible): Remove.
1690 (tui_make_all_invisible): Simplify.
1691 * tui/tui-layout.c (tui_make_all_invisible): Move from
1692 tui-wingeneral.c; simplify.
1693 (show_layout): Hoist call to tui_make_all_invisible.
1694 (show_data): Don't call tui_make_all_invisible.
1695
69258091
TT
16962019-08-13 Tom Tromey <tom@tromey.com>
1697
1698 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1699 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1700
62cf57fe
TT
17012019-08-13 Tom Tromey <tom@tromey.com>
1702
1703 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1704 tui-data.c.
1705 (show_source_disasm_command, show_data)
1706 (show_source_or_disasm_and_command): Don't use
1707 tui_set_current_layout_to.
1708 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1709 * tui/tui-data.c (current_layout, tui_current_layout): Move to
1710 tui-layout.c.
1711 (tui_set_current_layout_to): Remove.
1712
2afade5d
TT
17132019-08-13 Tom Tromey <tom@tromey.com>
1714
1715 * tui/tui-layout.c (tui_set_layout): Update.
1716 * tui/tui-data.h (struct tui_layout_def): Remove.
1717 (tui_layout_def): Don't declare.
1718 * tui/tui-data.c (layout_def): Remove.
1719 (tui_layout_def): Remove.
1720
a3504e96
TT
17212019-08-13 Tom Tromey <tom@tromey.com>
1722
1723 * tui/tui-winsource.h (struct tui_source_window_base)
1724 <clear_detail>: No longer "override".
1725 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1726 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1727 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1728 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1729 Remove.
1730 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1731
29c92911
TT
17322019-08-13 Tom Tromey <tromey@adacore.com>
1733
1734 * tracepoint.c: Don't include readline.h or history.h.
1735
86c6b807
TT
17362019-08-12 Tom Tromey <tom@tromey.com>
1737
1738 * configure: Rebuild.
1739 * configure.ac: Check for readline 7.
1740 * NEWS: Mention readline 7 requirement.
1741 * README: Update.
1742
5db2718c
TT
17432019-08-12 Tom Tromey <tom@tromey.com>
1744
1745 * mingw-hdep.c (gdb_select): Remove readline hack.
1746
dac36daf
PFC
17472019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
1748
1749 * blockframe.c (find_pc_partial_function): Set *block to nullptr
1750 when the function fails.
1751
1022c627
AA
17522019-08-09 Andreas Arnez <arnez@linux.ibm.com>
1753
1754 * s390-tdep.c (s390_type_align): New function.
1755 (s390_gdbarch_init): Set it as type_align gdbarch method.
1756
eba4caf2
TV
17572019-08-09 Tom de Vries <tdevries@suse.de>
1758
1759 PR gdb/24591
1760 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1761 pc_low with relocation offset.
1762
123cd851
TT
17632019-08-07 Tom Tromey <tromey@adacore.com>
1764
1765 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1766 (print_frame_args): Update.
1767 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1768 Update.
1769 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1770 * frame.h (struct frame_arg): Add initializers.
1771 <error>: Now a unique_xmalloc_ptr.
1772
3d31bc39
AH
17732019-08-07 Alan Hayward <alan.hayward@arm.com>
1774
1775 * NEWS: Expand the Pointer Authentication entry.
1776 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1777 (aarch64_frame_unmask_lr): ... to this.
1778 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1779 Call aarch64_frame_unmask_lr.
1780 * frame.c (struct frame_info): Add "masked" variable.
1781 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1782 (fprint_frame): Check for masked pc.
1783 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1784 declarations.
1785 * python/py-framefilter.c (py_print_frame): Check for masked pc.
1786 * stack.c (print_frame): Check for masked pc.
1787
0cf9feb9
TT
17882019-08-06 Tom Tromey <tom@tromey.com>
1789
1790 * stabsread.c (patch_block_stabs, read_one_struct_field)
1791 (read_enum_type): Use obstack_strndup.
1792 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1793 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1794 * dwarf2read.c (guess_full_die_structure_name)
1795 (anonymous_struct_prefix): Use obstack_strndup.
1796 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1797 * c-exp.y (yylex): Use obstack_strndup.
1798 * ada-exp.y (write_object_renaming, write_ambiguous_var)
1799 (write_var_or_type): Use obstack_strndup.
1800
efba19b0
TT
18012019-08-06 Tom Tromey <tom@tromey.com>
1802
1803 * symfile.c (reread_symbols): Use obstack_strdup.
1804 * stabsread.c (read_type): Use obstack_strdup.
1805 * gdb_obstack.h (obstack_strdup): New overload.
1806 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1807 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1808 (dwarf2_canonicalize_name): Use obstack_strdup.
1809 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1810 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1811 Use obstack_strdup.
1812
f25102f7
TT
18132019-08-06 Tom Tromey <tom@tromey.com>
1814
1815 * gdb_obstack.h (obstack_strdup): Define.
1816 * gdb_obstack.c (obstack_strdup): Don't define.
1817
021887d8
TT
18182019-08-06 Tom Tromey <tom@tromey.com>
1819
1820 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1821 obstack_strdup.
1822 * typeprint.c (typedef_hash_table::find_global_typedef): Use
1823 obstack_strdup.
1824 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1825 * stabsread.c (common_block_start): Use obstack_strdup.
1826 * objfiles.c (set_objfile_main_name, objfile): Use
1827 obstack_strdup.
1828 * namespace.c (add_using_directive): Use obstack_strdup.
1829 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1830 * jit.c (finalize_symtab): Use obstack_strdup.
1831 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1832 (guess_partial_die_structure_name, partial_die_info::fixup)
1833 (dwarf2_name): Use obstack_strdup.
1834 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1835 obstack_strdup.
1836 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1837 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1838 obstack_strdup.
1839 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1840
d2834edc
PW
18412019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1842
1843 * unittests/help-doc-selftests.c: New file.
1844 * Makefile.in: Add the new file.
1845
590042fc
PW
18462019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1847
1848 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1849 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
1850 the full first line, except when FOR_VALUE_PREFIX. In this case,
1851 the trailing '.' is not output, and the first character is uppercased.
1852 (print_help_for_command): Update call to print_doc_line.
1853 (print_doc_of_command): Likewise.
1854 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1855 * cli/cli-option.c (append_indented_doc): Do not append newline.
1856 (build_help_option): Append newline after first appended_indented_doc
1857 only if a second call is done.
1858 (build_help): Append 2 new lines before each option, except the first
1859 one.
1860 * compile/compile.c (_initialize_compile): Add new lines after
1861 %OPTIONS%, when not at the end of the help.
1862 Change help doc or code
1863 producing the help doc to respect the invariants.
1864 * maint-test-options.c (_initialize_maint_test_options): Likewise.
1865 Also removed the new line after 'Options:', as all other commands
1866 do not put an empty line between 'Options:' and the first option.
1867 * printcmd.c (_initialize_printcmd): Likewise.
1868 * stack.c (_initialize_stack): Likewise.
1869 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1870 incorrectly telling COMMAND is optional.
1871 * ada-lang.c (_initialize_ada_language): Change help doc or code
1872 producing the help doc to respect the invariants.
1873 * ada-tasks.c (_initialize_ada_tasks): Likewise.
1874 * breakpoint.c (_initialize_breakpoint): Likewise.
1875 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1876 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1877 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1878 * cli/cli-style.c (cli_style_option::add_setshow_commands,
1879 _initialize_cli_style): Likewise.
1880 * corelow.c (core_target_info): Likewise.
1881 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1882 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1883 * filesystem.c (_initialize_filesystem): Likewise.
1884 * frame.c (_initialize_frame): Likewise.
1885 * gnu-nat.c (add_task_commands): Likewise.
1886 * infcall.c (_initialize_infcall): Likewise.
1887 * infcmd.c (_initialize_infcmd): Likewise.
1888 * interps.c (_initialize_interpreter): Likewise.
1889 * language.c (_initialize_language): Likewise.
1890 * linux-fork.c (_initialize_linux_fork): Likewise.
1891 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1892 * maint.c (_initialize_maint_cmds): Likewise.
1893 * memattr.c (_initialize_mem): Likewise.
1894 * printcmd.c (_initialize_printcmd): Likewise.
1895 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1896 _RegEx): Likewise.
1897 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1898 * record-btrace.c (_initialize_record_btrace): Likewise.
1899 * record-full.c (_initialize_record_full): Likewise.
1900 * record.c (_initialize_record): Likewise.
1901 * regcache-dump.c (_initialize_regcache_dump): Likewise.
1902 * regcache.c (_initialize_regcache): Likewise.
1903 * remote.c (add_packet_config_cmd, init_remote_threadtests,
1904 _initialize_remote): Likewise.
1905 * ser-tcp.c (_initialize_ser_tcp): Likewise.
1906 * serial.c (_initialize_serial): Likewise.
1907 * skip.c (_initialize_step_skip): Likewise.
1908 * source.c (_initialize_source): Likewise.
1909 * stack.c (_initialize_stack): Likewise.
1910 * symfile.c (_initialize_symfile): Likewise.
1911 * symtab.c (_initialize_symtab): Likewise.
1912 * target-descriptions.c (_initialize_target_descriptions): Likewise.
1913 * top.c (init_main): Likewise.
1914 * tracefile-tfile.c (tfile_target_info): Likewise.
1915 * tracepoint.c (_initialize_tracepoint): Likewise.
1916 * tui/tui-win.c (_initialize_tui_win): Likewise.
1917 * utils.c (add_internal_problem_command): Likewise.
1918 * valprint.c (value_print_option_defs): Likewise.
1919
404f2902
FCE
19202019-08-06 Frank Ch. Eigler <fche@redhat.com>
1921
1922 PR build/24886
1923 * configure.ac: Drop enable-libmcheck support.
1924 * configure, config.in: Rebuild.
1925 * libmcheck.m4: Remove.
1926 * acinclude.m4: Don't include it.
1927 * Makefile.in: Don't distribute it.
1928 * top.c (print_gdb_configuration): Don't mention it.
1929
046bebe1
TT
19302019-08-06 Tom Tromey <tom@tromey.com>
1931
1932 * utils.c (set_output_style): Sometimes pass stream to
1933 emit_style_escape.
1934 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1935 * record-btrace.c (btrace_insn_history): Update.
1936 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1937 method.
1938 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1939 Update initializers.
1940 <m_uiout>: New field.
1941 <m_di>: Move lower.
1942 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1943 Remove "uiout" parameter.
1944 (dump_insns): Update.
1945 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1946 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1947
ddbcedf5
CB
19482019-08-06 Christian Biesinger <cbiesinger@google.com>
1949
1950 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1951 (error_in_psymtab_expansion): Likewise.
1952 (lookup_symbol_via_quick_fns): Likewise.
1953 (basic_lookup_transparent_type_quick): Likewise.
1954 (basic_lookup_transparent_type_1): Likewise.
1955
b08b16c8
TT
19562019-08-06 Tom Tromey <tromey@adacore.com>
1957
1958 * source.c (last_source_error): Now bool.
1959 (print_source_lines_base): Make "noprint" bool. Only open
1960 source file when last_source_visited changes.
1961
cb44333d
TT
19622019-08-06 Tom Tromey <tromey@adacore.com>
1963
1964 * annotate.c (annotate_source_line): Use g_source_cache.
1965 * source-cache.c (source_cache::get_plain_source_lines): Change
1966 parameters. Populate m_offset_cache.
1967 (source_cache::ensure): New method.
1968 (source_cache::get_line_charpos): New method.
1969 (extract_lines): Move lower. Change parameters.
1970 (source_cache::get_source_lines): Move lower.
1971 * source-cache.h (class source_cache): Update comment.
1972 <get_line_charpos>: New method.
1973 <get_source_lines>: Update comment.
1974 <clear>: Clear m_offset_cache.
1975 <get_plain_source_lines>: Change parameters.
1976 <ensure>: New method
1977 <m_offset_cache>: New member.
1978 * source.c (forget_cached_source_info_for_objfile): Update.
1979 (info_source_command): Use g_source_cache.
1980 (find_source_lines, open_source_file_with_line_charpos): Remove.
1981 (print_source_lines_base, search_command_helper): Use g_source_cache.
1982 * source.h (open_source_file_with_line_charpos): Don't declare.
1983 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1984 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1985 Use g_source_cache.
1986
872dceaa
TT
19872019-08-06 Tom Tromey <tromey@adacore.com>
1988
1989 * source-cache.c (source_cache::get_plain_source_lines):
1990 Remove "first_line" and "last_line" parameters.
1991 (source_cache::get_source_lines): Cache plain text.
1992 * source-cache.h (class source_cache)
1993 <get_plain_source_lines>: Update.
1994
269249d9
TT
19952019-08-06 Tom Tromey <tromey@adacore.com>
1996
1997 * source-cache.c (extract_lines): No longer a method.
1998 Changed type of parameter. Include final newline.
1999 (selftests::extract_lines_test): New function.
2000 (_initialize_source_cache): Likewise.
2001 * source-cache.h (class source_cache)
2002 <extract_lines>: Don't declare.
2003
c0e8dcd8
TT
20042019-08-06 Tom Tromey <tromey@adacore.com>
2005
2006 * breakpoint.c (init_breakpoint_sal): Update.
2007 (breakpoint): Update.
2008 * breakpoint.h (struct breakpoint) <filter>: Now a
2009 unique_xmalloc_ptr.
2010
0b27c27d
CB
20112019-08-05 Christian Biesinger <cbiesinger@google.com>
2012
2013 * NEWS: Mention dictionary access on blocks.
2014 * python/py-block.c (blpy_getitem): New function.
2015 (block_object_as_mapping): New struct.
2016 (block_object_type): Use new struct for tp_as_mapping field.
2017
4ee94178
CB
20182019-08-05 Christian Biesinger <cbiesinger@google.com>
2019
2020 * objfiles.h (objfile): Add a comment describing partial symbols.
2021
8abfcabc
TT
20222019-08-05 Tom Tromey <tromey@adacore.com>
2023
2024 * compile/compile.c (_initialize_compile): Use _(), not N_().
2025 * thread.c (_initialize_thread): Use _(), not N_().
2026 * stack.c (_initialize_stack): Use _(), not N_().
2027 * printcmd.c (_initialize_printcmd): Use _(), not N_().
2028
2b79f376
SM
20292019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
2030
2031 * dwarf2read.c (struct dw2_symtab_iterator):
2032 <want_specific_block>: Remove.
2033 <block_index>: Change type to gdb::optional.
2034 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2035 change type of BLOCK_INDEX parameter to gdb::optional.
2036 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2037 (dw2_lookup_symbol): Don't pass argument for
2038 WANT_SPECIFIC_BLOCK.
2039 (dw2_expand_symtabs_for_function): Don't pass argument for
2040 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2041 (class dw2_debug_names_iterator)
2042 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2043 parameter, change BLOCK_INDEX type to gdb::optional.
2044 <m_want_specific_block>: Remove.
2045 <m_block_index>: Change type to gdb::optional.
2046 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2047 gdb::optional. Re-write in function of gdb::optional.
2048 (dw2_debug_names_lookup_symbol): Don't pass argument for
2049 WANT_SPECIFIC_BLOCK.
2050 (dw2_debug_names_expand_symtabs_for_function): Don't pass
2051 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2052 BLOCK_INDEX.
2053
ae60f04e
PW
20542019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2055
2056 * NEWS: Mention changes to "info sources" command.
2057
28cd9371
PW
20582019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2059
2060 * symtab.c (filename_partial_match_opts): New struct type.
2061 (struct output_source_filename_data): New members
2062 regexp, c_regexp, partial_match.
2063 (output_source_filename): Use new members to decide to print file.
2064 (info_sources_option_defs): New variable.
2065 (make_info_sources_options_def_group, print_info_sources_header,
2066 info_sources_command_completer):
2067 New functions.
2068 (info_sources_command): Read new optional arguments.
2069 (_initialize_symtab): Update info sources help.
2070
ca683e3a
AO
20712019-08-02 Alexandre Oliva <oliva@adacore.com>
2072
2073 * ada-lang.c (exception_support_info_v0): Renamed from...
2074 (default_exception_support_info): ... this. Create new
2075 definition for v1.
2076 (ada_has_this_exception_support): Look up catch_handlers_sym.
2077 (ada_exception_support_info_sniffer): Try v0 after default.
2078
f1264162
TT
20792019-08-01 Tom Tromey <tromey@adacore.com>
2080
2081 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2082 gdbarch.h.
2083
0a7b2485
CB
20842019-08-01 Christian Biesinger <cbiesinger@google.com>
2085
2086 * s12z-tdep.c: Fix include path for s12z-opc.h.
2087
c6bdbeb7
AH
20882019-08-01 Alan Hayward <alan.hayward@arm.com>
2089
2090 * NEWS: Require GNU make 3.82.
2091
a2bd7b82
TT
20922019-07-16 Tom Tromey <tom@tromey.com>
2093
2094 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2095 declare.
2096
aa3b6533
TT
20972019-07-30 Tom Tromey <tromey@adacore.com>
2098
2099 * block.c (contained_in): Remove BLOCK_FUNCTION check.
2100
a1530dc7
KB
21012019-07-30 Kevin Buettner <kevinb@redhat.com>
2102
2103 * printcmd.c (print_address_symbolic): Print negative offsets.
2104 (build_address_symbolic): Force signed arithmetic when computing
2105 offset.
2106
2906593f
CB
21072019-07-30 Christian Biesinger <cbiesinger@google.com>
2108
2109 PR/24474: Add a function to lookup static variables.
2110 * NEWS: Mention this new function.
2111 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2112 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2113 * python/python.c (python_GdbMethods): Add new function.
2114
c620ed88
CB
21152019-07-29 Christian Biesinger <cbiesinger@google.com>
2116
2117 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2118 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2119 (objfpy_lookup_static_symbol): New function.
2120 (objfile_object_methods): Add new functions.
2121
bc4268a5
PW
21222019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2123
2124 * NEWS: Mention 'set|show print frame-info'. Mention new
2125 'presence' value for 'frame-arguments'. Mention new '-frame-info'
2126 backtrace argument. Mention that python frame filtering code
2127 is now consistent with what 'backtrace' command prints.
2128
4b5e8d19
PW
21292019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2130
2131 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2132 comments.
2133 (print_frame_info_auto, print_frame_info_source_line,
2134 print_frame_info_location, print_frame_info_source_and_location,
2135 print_frame_info_location_and_address, print_frame_info_short_location):
2136 New declarations.
2137 (struct frame_print_options): New member print_frame_info.
2138 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2139 * stack.h (get_user_print_what_frame_info): New declaration.
2140 (frame_show_address): New declaration.
2141 * stack.c (print_frame_arguments_choices): New value 'presence'.
2142 (print_frame_info_auto, print_frame_info_source_line,
2143 print_frame_info_location, print_frame_info_source_and_location,
2144 print_frame_info_location_and_address, print_frame_info_short_location,
2145 print_frame_info_choices, print_frame_info_print_what): New definitions.
2146 (print_frame_args): Only print dots for args if print frame-arguments
2147 is 'presence'.
2148 (frame_print_option_defs): New element for "frame-info".
2149 (get_user_print_what_frame_info): New function.
2150 (frame_show_address): Make non static. Move comment to stack.h.
2151 (print_frame_info_to_print_what): New function.
2152 (print_frame_info): Update comment. Use fp_opts.print_frame_info
2153 to decide what to print.
2154 (backtrace_command_1): Handle the new print_frame_arguments_presence
2155 value.
2156 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2157 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2158 (py_print_frame): In non-mi mode, use LOCATION as default for
2159 print_what, similarly to frame information printed directly by
2160 backtrace command. Handle frame-info user option in non MI mode.
2161
6bdfee81
KB
21622019-07-27 Kevin Buettner <kevinb@redhat.com>
2163
2164 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2165 Add case for debugging 32-bit target on 64-bit host. Revise
2166 comment.
2167
98a617f8
KB
21682019-07-27 Kevin Buettner <kevinb@redhat.com>
2169
2170 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2171 instead of find_function_entry_range_from_pc.
2172
567238c9
KB
21732019-07-27 Kevin Buettner <kevinb@redhat.com>
2174
2175 * stack.c (find_frame_funname): Remove code which preferred
2176 minsym over symtab sym in "certain pathological cases".
2177
2dc80cf8
KB
2178 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2179 parameter. Change type of "do_demangle" to bool.
2180 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2181 Pass suitable "prefer_sym_over_minsym" flag to
2182 build_address_symbolic(). Don't output "+" for negative offsets.
2183 * printcmd.c (print_address_symbolic): Update invocation of
2184 build_address_symbolic to include a "prefer_sym_over_minsym"
2185 flag.
2186 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2187 Restrict cases in which use of minimal symbol is preferred to that
2188 of a found symbol. Update comments.
2189
1aff7173
KB
2190 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2191 for entry pc when entry pc is out of range for that FDE.
2192
89b085ac
BC
21932019-07-26 Brian Callahan <bcallah@openbsd.org>
2194
2195 PR gdb/24839:
2196 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2197 type.
2198
f32feb4a
CB
21992019-07-25 Christian Biesinger <cbiesinger@google.com>
2200
2201 * python/py-objfile.c (add_separate_debug_file): Fix comment about
2202 this function's Python signature.
2203
2204
22052019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
2206
2207 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2208 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2209 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2210 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2211 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2212
2213
c54e4253
YS
22142019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
2215
2216 * h8300-tdep.c (h8300_register_name_common): New.
2217 h8300_register_name): Use h8300_register_name_common.
2218 (h8300s_register_name): Likewise.
2219 (h8300sx_register_name): Likewise.
2220 (h8300h_register_nam): New.
2221 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2222
2223
40eadf04
SP
22242019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
2225
2226 * arm-tdep.c (arm_skip_cmse_entry): New function.
2227 (arm_is_sgstubs_section): New function.
2228 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2229
bfa2a36d
TT
22302019-07-22 Tom Tromey <tom@tromey.com>
2231
2232 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2233 Don't self-assign.
2234
a8e9d247
AB
22352019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2236
2237 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2238 type_print.
2239
eb86c5e2
AB
22402019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2241
2242 * symtab.c (search_symbols): Adjust msymbol matching type arrays
2243 so that GDB doesn't match any msymbols when searching in the
2244 TYPES_DOMAIN.
2245 (print_symbol_info): Print using typedef_print or type_print based
2246 on the type of the symbol. Add updated FIXME comment moved from...
2247 (_initialize_symtab): ... move and update FIXME comment to above.
2248
a8eab7c6
AB
22492019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
2250
2251 * NEWS: Mention adding -q option to "info types".
2252 * symtab.c (struct info_types_options): New struct.
2253 (info_types_options_defs): New variable.
2254 (make_info_types_options_def_group): New function.
2255 (info_types_command): Use gdb::option framework to parse options.
2256 (info_types_command_completer): New function.
2257 (_initialize_symtab): Extend the help text on "info types" and
2258 register command completer.
2259
b4603c34
CB
22602019-07-21 Christian Biesinger <cbiesinger@google.com>
2261
2262 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2263 (lookup_symbol_in_objfile): Change int to block_enum and add a
2264 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2265
c8cdc1e0
CB
22662019-07-20 Christian Biesinger <cbiesinger@google.com>
2267
2268 * MAINTAINERS (Write After Approval): Add self.
2269
01e175fe
AB
22702019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
2271
2272 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2273 instruction to the dummy code region.
2274
56f79b63
TT
22752019-07-19 Tom Tromey <tromey@adacore.com>
2276
2277 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2278 (ARGSUSED, PARAMS, __func__): Remove rules.
2279
4c5aa8e0
AH
22802019-07-19 Alan Hayward <alan.hayward@arm.com>
2281
2282 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2283 * features/arm/arm-with-iwmmxt.c: Remove.
2284 * features/arm/arm-with-iwmmxt.xml: Remove.
2285 * features/arm/arm-with-m-fpa-layout.c: Remove.
2286 * features/arm/arm-with-m-fpa-layout.xml: Remove.
2287 * features/arm/arm-with-m-vfp-d16.c: Remove.
2288 * features/arm/arm-with-m-vfp-d16.xml: Remove.
2289 * features/arm/arm-with-m.c: Remove.
2290 * features/arm/arm-with-m.xml: Remove.
2291 * features/arm/arm-with-neon.c: Remove.
2292 * features/arm/arm-with-neon.xml: Remove.
2293 * features/arm/arm-with-vfpv2.c: Remove.
2294 * features/arm/arm-with-vfpv2.xml: Remove.
2295 * features/arm/arm-with-vfpv3.c: Remove.
2296 * features/arm/arm-with-vfpv3.xml: Remove.
2297
f42b2617
AH
22982019-07-19 Alan Hayward <alan.hayward@arm.com>
2299
2300 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2301
f29ec966
AH
23022019-07-19 Alan Hayward <alan.hayward@arm.com>
2303
2304 * arch/aarch32.c (aarch32_create_target_description): Create
2305 target descriptions using features.
2306 * arch/arm.c (arm_create_target_description)
2307 (arm_create_mprofile_target_description): Likewise.
2308 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2309
d105cce5
AH
23102019-07-19 Alan Hayward <alan.hayward@arm.com>
2311
2312 * Makefile.in: Add new files.
2313 * aarch32-tdep.c: New file.
2314 * aarch32-tdep.h: New file.
2315 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2316 Call aarch32_read_description.
2317 * arch/aarch32.c: New file.
2318 * arch/aarch32.h: New file.
2319 * arch/arm.c (arm_create_target_description)
2320 (arm_create_mprofile_target_description): New function.
2321 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2322 (arm_create_target_description)
2323 (arm_create_mprofile_target_description): New declaration.
2324 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2325 read_description functions.
2326 * arm-linux-nat.c (arm_linux_nat_target::read_description):
2327 Likewise.
2328 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2329 * arm-tdep.c (tdesc_arm_list): New variable.
2330 (arm_register_g_packet_guesses): Call create description functions.
2331 (arm_read_description) (arm_read_mprofile_description): New
2332 function.
2333 * arm-tdep.h (arm_read_description)
2334 (arm_read_mprofile_description): Add declaration.
2335 * configure.tgt: Add new files.
2336
afe09f0b
GL
23372019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
2338
2339 * top.c (new_ui_command): Open specified terminal just once.
2340
cd215b2e
TT
23412019-07-18 Tom Tromey <tromey@adacore.com>
2342
2343 * symtab.c (main_name): Constify return type.
2344 * symfile.c (set_initial_language): Update.
2345 * symtab.h (main_name): Constify return type.
2346
d8f68fcb
TT
23472019-07-17 Tom Tromey <tom@tromey.com>
2348
2349 * tui/tui-winsource.c (tui_update_source_window)
2350 (tui_update_source_window_as_is)
2351 (tui_update_source_windows_with_line): Remove return.
2352 * tui/tui-disasm.c (tui_show_disassem)
2353 (tui_show_disassem_and_update_source): Remove return.
2354 * tui/tui.c (tui_reset): Remove return.
2355 * tui/tui-wingeneral.c
2356 (tui_check_and_display_highlight_if_needed): Remove return.
2357
ca5af91e
TT
23582019-07-17 Tom Tromey <tom@tromey.com>
2359
2360 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2361
5104fe36
TT
23622019-07-17 Tom Tromey <tom@tromey.com>
2363
2364 * tui/tui-winsource.h (struct tui_exec_info_window)
2365 (struct tui_source_window_base): Move from tui-data.h.
2366 * tui/tui-winsource.c: Move many method definitions from
2367 elsewhere. Remove "structuring" comments.
2368 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2369 (tui_source_window_base::refresh_window): Move to
2370 tui-winsource.c.
2371 * tui/tui-win.c (tui_source_window_base::refresh_all)
2372 (tui_source_window_base::update_tab_width)
2373 (tui_source_window_base::set_new_height)
2374 (tui_source_window_base::do_make_visible_with_new_height): Move to
2375 tui-winsource.c.
2376 * tui/tui-source.h: Update.
2377 * tui/tui-source.c (tui_source_window_base::reset): Move to
2378 tui-winsource.c.
2379 * tui/tui-disasm.h: Update.
2380 * tui/tui-data.h (struct tui_exec_info_window): Move to
2381 tui-winsource.h.
2382 (struct tui_source_window_base): Likewise.
2383 * tui/tui-data.c (tui_source_window_base::clear_detail)
2384 (tui_source_window_base, ~tui_source_window_base): Move to
2385 tui-winsource.c.
2386
daa15dde
TT
23872019-07-17 Tom Tromey <tom@tromey.com>
2388
2389 * tui/tui-win.c (tui_resize_all)
2390 (tui_source_window_base::update_tab_width)
2391 (tui_adjust_win_heights): Update.
2392 (tui_win_info::make_invisible_and_set_new_height): Rename from
2393 make_invisible_and_set_new_height.
2394 * tui/tui-data.h (struct tui_win_info)
2395 <make_invisible_and_set_new_height>: New method.
2396
bfad4537
TT
23972019-07-17 Tom Tromey <tom@tromey.com>
2398
2399 * tui/tui.c: Update.
2400 * tui/tui-source.h (struct tui_source_window): Move from
2401 tui-data.h.
2402 * tui/tui-layout.c: Update.
2403 * tui/tui-disasm.c: Update.
2404 * tui/tui-data.h (struct tui_source_window): Move to
2405 tui-source.h.
2406
88f7e873
TT
24072019-07-17 Tom Tromey <tom@tromey.com>
2408
2409 * tui/tui-disasm.h (struct tui_disasm_window): Move from
2410 tui-data.h.
2411 * tui/tui-data.h (struct tui_disasm_window): Move to
2412 tui-disasm.h.
2413
96bd6233
TT
24142019-07-17 Tom Tromey <tom@tromey.com>
2415
2416 * tui/tui-regs.h (struct tui_data_item_window): Move from
2417 tui-data.h.
2418 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2419 * tui/tui-data.h (struct tui_data_item_window): Move to
2420 tui-regs.h.
2421 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2422
ce38393b
TT
24232019-07-17 Tom Tromey <tom@tromey.com>
2424
2425 * tui/tui.c: Update.
2426 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2427 (tui_cmd_window::max_height): Move to tui-command.c.
2428 * tui/tui-layout.c: Update.
2429 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2430 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2431 tui-command.c.
2432 * tui/tui-command.h (struct tui_cmd_window): Move from
2433 tui-data.h.
2434 * tui/tui-command.c: Remove "structuring" comments.
2435 (tui_cmd_window::clear_detail)
2436 (tui_cmd_window::do_make_visible_with_new_height)
2437 (tui_cmd_window::max_height): Move from elsewhere.
2438
2d8b51cb
TT
24392019-07-17 Tom Tromey <tom@tromey.com>
2440
2441 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2442 Now static.
2443 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2444 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2445
18ab23af
TT
24462019-07-17 Tom Tromey <tom@tromey.com>
2447
2448 * tui/tui.c: Update.
2449 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2450 tui-regs.c.
2451 * tui/tui-windata.h: Remove file.
2452 * tui/tui-windata.c: Remove file.
2453 * tui/tui-win.c (tui_data_window::set_new_height)
2454 (tui_data_window::do_make_visible_with_new_height): Move to
2455 tui-regs.c.
2456 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2457 * tui/tui-regs.c: Remove "structuring" comments.
2458 (tui_data_window::first_data_item_displayed)
2459 (tui_data_window::delete_data_content_windows)
2460 (tui_data_window::erase_data_content)
2461 (tui_data_window::display_all_data)
2462 (tui_data_window::refresh_all)
2463 (tui_data_window::do_scroll_vertical)
2464 (tui_data_window::clear_detail, tui_data_window::set_new_height)
2465 (tui_data_window::do_make_visible_with_new_height)
2466 (tui_data_window::refresh_window): Move from elsewhere.
2467 (_initialize_tui_regs): Move to end of file.
2468 * tui/tui-layout.c: Update.
2469 * tui/tui-hooks.c: Update.
2470 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2471 * tui/tui-data.c (tui_data_window::clear_detail): Move to
2472 tui-regs.c.
2473 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2474
88b7e7cc
TT
24752019-07-17 Tom Tromey <tom@tromey.com>
2476
2477 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2478 seen.
2479
0fcd3711
TT
24802019-07-17 Tom Tromey <tom@tromey.com>
2481
2482 * tui/tui-win.c (tui_source_window_base::set_new_height)
2483 (tui_source_window_base::do_make_visible_with_new_height): Use
2484 m_has_locator field directly.
2485 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2486 method.
2487 (struct tui_source_window_base) <has_locator>: Likewise.
2488
4a38112d
TT
24892019-07-17 Tom Tromey <tom@tromey.com>
2490
2491 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2492 Don't declare.
2493 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2494 Remove.
2495 * tui/tui-win.c (tui_source_window_base::set_new_height)
2496 (tui_source_window_base::set_new_height)
2497 (make_invisible_and_set_new_height)
2498 (tui_source_window_base::do_make_visible_with_new_height)
2499 (tui_source_window_base::do_make_visible_with_new_height):
2500 Update.
2501 * tui/tui-layout.c (show_source_disasm_command, show_data)
2502 (show_source_or_disasm_and_command): Update.
2503 * tui/tui-layout.c (show_layout): Update.
2504
09129226
TT
25052019-07-17 Tom Tromey <tom@tromey.com>
2506
2507 * tui/tui-layout.c (make_data_window): Remove.
2508 (show_data): Unify creation and re-initialization cases.
2509
4a8a5e84
TT
25102019-07-17 Tom Tromey <tom@tromey.com>
2511
2512 * tui/tui-layout.c (make_source_window, make_disasm_window):
2513 Remove.
2514 (show_data): Unify creation and re-initialization cases.
2515
76d2be8e
TT
25162019-07-17 Tom Tromey <tom@tromey.com>
2517
2518 * tui/tui-layout.c (make_command_window): Remove.
2519 (show_source_disasm_command, show_source_or_disasm_and_command):
2520 Unify creation and re-initialization cases.
2521
890b8bde
TT
25222019-07-17 Tom Tromey <tom@tromey.com>
2523
2524 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2525 creation and re-initialization cases.
2526
2cdfa113
TT
25272019-07-17 Tom Tromey <tom@tromey.com>
2528
2529 * tui/tui-regs.c (tui_get_register): Return void.
2530
8e3cfd09
TT
25312019-07-17 Tom Tromey <tom@tromey.com>
2532
2533 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2534 Simplify.
2535
f4e04977
TT
25362019-07-17 Tom Tromey <tom@tromey.com>
2537
2538 * tui/tui-layout.c (show_source_disasm_command): Simplify window
2539 resetting.
2540
0379b883
TT
25412019-07-17 Tom Tromey <tom@tromey.com>
2542
2543 * tui/tui.h (tui_set_layout_by_name): Don't declare.
2544 * tui/tui-regs.c (tui_reg_layout): New function.
2545 (tui_show_registers, tui_reg_command): Use it.
2546 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2547 (tui_layout_command): Rename from tui_set_layout_by_name. Change
2548 parameters.
2549 (tui_layout_command): Remove.
2550
b7fbad91
TT
25512019-07-17 Tom Tromey <tom@tromey.com>
2552
2553 * tui/tui-layout.h (tui/tui-layout): Return void.
2554 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
2555
4e1e56b9
TT
25562019-07-17 Tom Tromey <tom@tromey.com>
2557
2558 * tui/tui-layout.c (show_source_disasm_command, show_data):
2559 Update.
2560 (reset_locator): Remove.
2561 (show_source_or_disasm_and_command): Update.
2562
1e0c09ba
TT
25632019-07-17 Tom Tromey <tom@tromey.com>
2564
2565 * tui/tui-source.c (tui_source_window_base::reset): Remove
2566 win_type parameter.
2567 * tui/tui-layout.c (make_command_window, make_source_window)
2568 (make_disasm_window, make_data_window)
2569 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2570 (reset_locator, show_source_or_disasm_and_command): Update.
2571 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2572 win_type parameter.
2573 (struct tui_source_window_base) <reset>: Likewise.
2574
1bf605de
TT
25752019-07-17 Tom Tromey <tom@tromey.com>
2576
2577 * tui/tui-layout.c (show_source_disasm_command): Use
2578 reset_locator.
2579 (reset_locator): New function.
2580 (init_and_make_win): Remove.
2581 (show_source_or_disasm_and_command): Use reset_locator.
2582
098f9ed4
TT
25832019-07-17 Tom Tromey <tom@tromey.com>
2584
2585 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2586 condition.
2587 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2588 Remove condition.
2589 * tui/tui-source.c (tui_source_window_base::reset): New method.
2590 * tui/tui-layout.c (make_command_window): Don't call
2591 init_and_make_win.
2592 (make_source_window, make_disasm_window): Don't call
2593 make_source_or_disasm_window.
2594 (make_data_window): Don't call init_and_make_win. Change calling
2595 convention.
2596 (show_source_disasm_command, show_data): Simplify.
2597 (make_source_or_disasm_window): Remove.
2598 (show_source_or_disasm_and_command): Simplify.
2599 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2600 (struct tui_source_window_base) <reset>: Likewise.
2601 <execution_info>: Remove initializer.
2602 * tui/tui-data.c (tui_source_window_base): Initialize
2603 execution_info.
2604
80110957
TT
26052019-07-17 Tom Tromey <tom@tromey.com>
2606
2607 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2608 variable.
2609
cf82af05
TT
26102019-07-17 Tom Tromey <tom@tromey.com>
2611
2612 * tui/tui.c (tui_rl_other_window): Update.
2613 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2614 superclass method first. Always iterate over regs_content.
2615 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2616 method.
2617 * tui/tui-win.c (tui_set_focus_command): Update.
2618
01aeb396
TT
26192019-07-17 Tom Tromey <tom@tromey.com>
2620
2621 * tui/tui-win.c (tui_set_focus_command): Rename from
2622 tui_set_focus. Call tui_enable.
2623 (tui_set_focus_command): Remove.
2624
fd6c75ee
TT
26252019-07-17 Tom Tromey <tom@tromey.com>
2626
2627 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2628 refresh_window.
2629 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2630 touchwin.
2631 (tui_data_window::refresh_window): Call refresh_window on data
2632 items. Always call superclass refresh_window.
2633 (tui_win_info::refresh): Remove.
2634 (tui_source_window_base::refresh_window): Update.
2635 (tui_refresh_all): Update.
2636 * tui/tui-layout.c (show_source_disasm_command): Remove call to
2637 refresh_window.
2638 (show_source_or_disasm_and_command): Likewise.
2639 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2640 (struct tui_source_window_base) <refresh>: Likewise.
2641
f6cc34a9
TT
26422019-07-17 Tom Tromey <tom@tromey.com>
2643
2644 * tui/tui-winsource.c (tui_clear_source_content)
2645 (tui_show_source_content): Update.
2646 * tui/tui-source.c (tui_source_window::showing_source_p): Check
2647 whether content is empty.
2648 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2649 Remove.
2650
f31ec9af
TT
26512019-07-17 Tom Tromey <tom@tromey.com>
2652
2653 * tui/tui-winsource.c (tui_erase_source_content): Clear the
2654 window's contents.
2655 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2656 * tui/tui-source.c (tui_set_source_content_nil): Remove.
2657
d1b6f1e5
TT
26582019-07-17 Tom Tromey <tom@tromey.com>
2659
2660 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2661 (struct tui_data_item_window): Update.
2662
d9743a13
TT
26632019-07-17 Tom Tromey <tom@tromey.com>
2664
2665 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2666 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2667 defines.
2668
caf0bc4e
TT
26692019-07-17 Tom Tromey <tom@tromey.com>
2670
2671 * tui/tui-winsource.h (tui_erase_source_content)
2672 (tui_clear_source_content): Remove "display_prompt" parameter.
2673 * tui/tui-winsource.c (tui_update_source_window_as_is)
2674 (tui_update_source_windows_with_addr): Update.
2675 (tui_clear_source_content): Remove "display_prompt" parameter.
2676 (tui_erase_source_content): Likewise. Simplify.
2677 (tui_show_source_content): Update.
2678 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2679 * tui/tui-stack.c (tui_show_frame_info): Update.
2680 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2681 Remove defines.
2682
9d391078
TT
26832019-07-17 Tom Tromey <tom@tromey.com>
2684
2685 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2686 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2687 parameter.
2688 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2689 parameter.
2690
a38da35d
TT
26912019-07-17 Tom Tromey <tom@tromey.com>
2692
2693 * tui/tui-winsource.c (tui_clear_source_content)
2694 (tui_show_source_content, tui_show_exec_info_content)
2695 (tui_clear_exec_info_content): Update.
2696 * tui/tui-stack.c (tui_show_locator_content): Update.
2697 (tui_show_frame_info): Update.
2698 * tui/tui-source.h (tui_source_window): Don't declare.
2699 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2700 from tui_source_is_displayed.
2701 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2702 Remove field.
2703 (struct tui_source_window_base) <content_in_use>: New field. Now
2704 bool.
2705 (struct tui_source_window) <showing_source_p>: New method.
2706 (TUI_SRC_WIN): Change cast.
2707 * tui/tui-data.c (tui_initialize_static_data): Update.
2708
c2cd8994
TT
27092019-07-17 Tom Tromey <tom@tromey.com>
2710
2711 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2712 location_matches_p.
2713 * tui/tui-source.c (tui_source_window::location_matches_p): New
2714 method.
2715 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2716 method.
2717 * tui/tui-data.h (struct tui_source_window_base)
2718 <location_matches_p>: New method.
2719 (struct tui_source_window, struct tui_disasm_window)
2720 <location_matches_p>: Likewise.
2721
4dde7b34
TT
27222019-07-17 Tom Tromey <tom@tromey.com>
2723
2724 * tui/tui-win.c (tui_set_win_height_command): Rename from
2725 tui_set_win_height.
2726 (tui_set_win_height_command): Remove.
2727
b73dd877
TT
27282019-07-17 Tom Tromey <tom@tromey.com>
2729
2730 * tui/tui-source.c (tui_source_window): New constructor. Add
2731 observer.
2732 (~tui_source_window): New destructor.
2733 (tui_source_window::style_changed): New method.
2734 * tui/tui-hooks.c (tui_redisplay_source): Remove.
2735 (tui_attach_detach_observers): Update.
2736 * tui/tui-data.h (struct tui_source_window): Make constructor not
2737 inline. Add destructor.
2738 (struct tui_source_window) <style_changed>: New method.
2739 <m_observable>: New member.
2740
ae2b5380
TT
27412019-07-17 Tom Tromey <tom@tromey.com>
2742
2743 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2744 * tui/tui-win.c (tui_resize_all): Fix typo.
2745
1ce3e844
TT
27462019-07-17 Tom Tromey <tom@tromey.com>
2747
2748 * tui/tui-wingeneral.h (tui_refresh_all): Update.
2749 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2750 (tui_refresh_all): Remove "list" parameter. Use foreach.
2751 * tui/tui-win.c (window_name_completer): Use foreach.
2752 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2753 (update_tab_width): Likewise.
2754 * tui/tui-layout.c (show_layout): Update.
2755 * tui/tui-data.h (class tui_window_iterator): New.
2756 (struct all_tui_windows): New.
2757 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2758
fe3eaf1c
TT
27592019-07-17 Tom Tromey <tom@tromey.com>
2760
2761 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2762 parameter. Don't reference globals.
2763 (tui_reg_command): Update.
2764
368c1354
TT
27652019-07-17 Tom Tromey <tom@tromey.com>
2766
2767 * tui/tui-regs.c (tui_show_registers): Simplify.
2768
e80cd204
TT
27692019-07-17 Tom Tromey <tom@tromey.com>
2770
2771 * tui/tui-regs.c (tui_show_registers): Update.
2772 (tui_show_register_group): Add win_info parameter.
2773
aca2dd16
TT
27742019-07-17 Tom Tromey <tom@tromey.com>
2775
2776 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2777 Rename from tui_display_reg_element_at_line.
2778 (tui_data_window::display_registers_from_line): Update.
2779 * tui/tui-data.h (struct tui_data_window)
2780 <display_reg_element_at_line>: New method.
2781
517e9505
TT
27822019-07-17 Tom Tromey <tom@tromey.com>
2783
2784 * tui/tui-regs.h (tui_display_registers_from)
2785 (tui_display_registers_from_line): Don't declare.
2786 * tui/tui-windata.c (tui_data_window::display_all_data)
2787 (tui_data_window::refresh_all)
2788 (tui_data_window::do_scroll_vertical): Update.
2789 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2790 from tui_display_registers_from.
2791 (tui_display_reg_element_at_line): Update.
2792 (tui_data_window::display_registers_from_line): Rename from
2793 tui_display_registers_from_line.
2794 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2795 display_registers_from_line>: New methods.
2796
f76d8b19
TT
27972019-07-17 Tom Tromey <tom@tromey.com>
2798
2799 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2800 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2801 from tui_erase_data_content.
2802 (tui_data_window::display_all_data)
2803 (tui_data_window::refresh_all)
2804 (tui_data_window::do_scroll_vertical): Update.
2805 * tui/tui-regs.c (tui_show_registers): Update.
2806 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2807 New method.
2808
b4094625
TT
28092019-07-17 Tom Tromey <tom@tromey.com>
2810
2811 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2812 declare.
2813 * tui/tui-windata.c
2814 (tui_data_window::delete_data_content_windows): Rename from
2815 tui_delete_data_content_windows.
2816 (tui_data_window::display_all_data)
2817 (tui_data_window::do_scroll_vertical): Update.
2818 * tui/tui-data.h (struct tui_data_window)
2819 <delete_data_content_windows>: New method.
2820
c223a729
TT
28212019-07-17 Tom Tromey <tom@tromey.com>
2822
2823 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2824 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2825
50daf268
TT
28262019-07-17 Tom Tromey <tom@tromey.com>
2827
2828 * tui/tui-windata.h (tui_display_all_data): Don't declare.
2829 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2830 from tui_display_all_data.
2831 * tui/tui-win.c
2832 (tui_data_window::do_make_visible_with_new_height): Update.
2833 * tui/tui-regs.c (tui_show_registers): Update.
2834 * tui/tui-layout.c (tui_set_layout): Update.
2835 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2836 method.
2837
df5f8cab
TT
28382019-07-17 Tom Tromey <tom@tromey.com>
2839
2840 * tui/tui-windata.h (tui_display_data_from): Don't declare.
2841 * tui/tui-windata.c (tui_display_data_from): Remove.
2842 (tui_data_window::refresh_all): Update.
2843
80cb6c27
TT
28442019-07-17 Tom Tromey <tom@tromey.com>
2845
2846 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2847 * tui/tui-windata.c (tui_display_data_from_line): Remove.
2848 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2849 tui_display_registers_from_line.
2850 * tui/tui-regs.h (tui_display_registers_from_line): Update.
2851 * tui/tui-regs.c (tui_display_registers_from_line): Remove
2852 "force_display" parameter.
2853
baff0c28
TT
28542019-07-17 Tom Tromey <tom@tromey.com>
2855
2856 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2857 declare.
2858 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2859 Rename from tui_first_reg_element_no_inline.
2860 (tui_display_reg_element_at_line)
2861 (tui_display_registers_from_line): Update.
2862 * tui/tui-data.h (struct tui_data_window)
2863 <first_reg_element_no_inline>: New method.
2864
3b23c5f2
TT
28652019-07-17 Tom Tromey <tom@tromey.com>
2866
2867 * tui/tui-windata.c (tui_display_data_from)
2868 (tui_data_window::do_scroll_vertical): Update.
2869 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2870 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2871 Rename from tui_line_from_reg_element_no.
2872 (tui_display_registers_from_line): Update.
2873 * tui/tui-data.h (struct tui_data_window)
2874 <line_from_reg_element_no>: New method.
2875
0b5ec218
TT
28762019-07-17 Tom Tromey <tom@tromey.com>
2877
2878 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2879 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2880 tui_last_regs_line_no.
2881 (tui_display_reg_element_at_line)
2882 (tui_display_registers_from_line): Update.
2883 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2884 method.
2885
0807ab7b
TT
28862019-07-17 Tom Tromey <tom@tromey.com>
2887
2888 PR tui/24722:
2889 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2890 (tui_update_breakpoint_info): Add "being_deleted" parameter.
2891 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2892 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2893 (tui_update_breakpoint_info): Likewise.
2894 * tui/tui-hooks.c (tui_event_create_breakpoint)
2895 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2896 Update.
2897
9ad7fdef
TT
28982019-07-17 Tom Tromey <tom@tromey.com>
2899
2900 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2901
5813316f
TT
29022019-07-17 Tom Tromey <tom@tromey.com>
2903
2904 * tui/tui-winsource.c (tui_update_source_window_as_is)
2905 (tui_update_source_windows_with_addr): Update.
2906 * tui/tui-source.h (tui_set_source_content)
2907 (tui_show_symtab_source): Add "win_info" parameter.
2908 * tui/tui-source.c (tui_set_source_content): Add "win_info"
2909 parameter.
2910 (tui_show_symtab_source): Likewise.
2911
00e264e7
TT
29122019-07-17 Tom Tromey <tom@tromey.com>
2913
2914 * tui/tui-wingeneral.c
2915 (tui_check_and_display_highlight_if_needed): Check can_highlight.
2916
06210ce4
TT
29172019-07-17 Tom Tromey <tom@tromey.com>
2918
2919 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2920 (struct tui_cmd_window) <can_scroll>: New method.
2921 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2922 method.
2923
381befee
TT
29242019-07-17 Tom Tromey <tromey@adacore.com>
2925
2926 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2927 do_field_signed>: Rename. Change type of "value".
2928 * ui-out.c (ui_out::field_signed): Rename from field_int.
2929 Change type of "value".
2930 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
2931 type of "value".
2932 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2933 do_field_int. Change type of "value".
2934 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2935 do_field_int. Change type of "value".
2936 * tracepoint.c (trace_status_mi, tfind_1)
2937 (print_one_static_tracepoint_marker): Update.
2938 * thread.c (print_thread_info_1, print_selected_thread_frame):
2939 Update.
2940 * stack.c (print_frame, print_frame_info): Update.
2941 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2942 Update.
2943 * source.c (print_source_lines_base): Update.
2944 * skip.c (info_skip_command): Update.
2945 * record-btrace.c (btrace_ui_out_decode_error)
2946 (btrace_call_history_src_line): Update.
2947 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2948 Update.
2949 * progspace.c (print_program_space): Update.
2950 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2951 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2952 do_field_int. Change type of "value".
2953 * mi/mi-out.c (mi_ui_out::do_table_begin)
2954 (mi_ui_out::do_table_header): Update.
2955 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
2956 type of "value".
2957 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2958 (mi_cmd_data_list_changed_registers, output_register)
2959 (mi_cmd_data_read_memory, mi_load_progress)
2960 (mi_cmd_trace_frame_collected): Update.
2961 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2962 Update.
2963 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2964 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2965 (mi_cmd_var_list_children, varobj_update_one): Update.
2966 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2967 (mi_cmd_stack_list_args, list_arg_or_local): Update.
2968 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2969 * inferior.c (print_inferior): Update.
2970 * gdb_bfd.c (print_one_bfd): Update.
2971 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2972 Update.
2973 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2974 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2975 do_field_int. Change type of "value".
2976 * cli-out.c (cli_ui_out::do_field_signed): Rename from
2977 do_field_int. Change type of "value".
2978 * breakpoint.c (watchpoint_check, print_breakpoint_location)
2979 (print_one_breakpoint_location, print_it_catch_fork)
2980 (print_one_catch_fork, print_it_catch_vfork)
2981 (print_one_catch_vfork, print_it_catch_solib)
2982 (print_it_catch_exec, print_it_ranged_breakpoint)
2983 (print_mention_watchpoint, print_mention_masked_watchpoint)
2984 (bkpt_print_it, update_static_tracepoint): Update.
2985 * break-catch-throw.c (print_it_exception_catchpoint): Update.
2986 * break-catch-syscall.c (print_it_catch_syscall): Update.
2987 * ada-tasks.c (print_ada_task_info): Update.
2988 * ada-lang.c (print_it_exception, print_mention_exception):
2989 Update.
2990
6b78c3f8
AB
29912019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
2992
2993 PR breakpoints/24541
2994 * gdbarch.c: Regenerate.
2995 * gdbarch.h: Regenerate.
2996 * gdbarch.sh: Adjust return type and parameter types for
2997 'stap_adjust_register'.
2998 (i386_stap_adjust_register): Adjust signature and return new
2999 register name.
3000 * stap-probe.c (stap_parse_register_operand): Adjust use of
3001 'gdbarch_stap_adjust_register'.
3002
d72a9b85
TT
30032019-07-17 Tom Tromey <tromey@adacore.com>
3004
3005 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
3006 declare VEC.
3007 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3008 std::vector.
3009 (struct s390_process_info): Add initializers.
3010 (s390_add_process): Use new.
3011 (s390_linux_nat_target::low_forget_process): Use delete.
3012 (s390_linux_nat_target::low_new_fork)
3013 (s390_linux_nat_target::stopped_by_watchpoint)
3014 (s390_linux_nat_target::low_prepare_to_resume)
3015 (s390_linux_nat_target::insert_watchpoint)
3016 (s390_linux_nat_target::insert_hw_breakpoint)
3017 (s390_linux_nat_target::remove_watchpoint)
3018 (s390_linux_nat_target::remove_hw_breakpoint): Update.
3019
206e6c58
JB
30202019-07-16 John Baldwin <jhb@FreeBSD.org>
3021
3022 * aarch64-fbsd-nat.c: Include regcache.h.
3023 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3024 argument.
3025 (aarch64_fbsd_nat_target::fetch_registers)
3026 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3027 variable.
3028 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3029
cbde90f2
JB
30302019-07-16 John Baldwin <jhb@FreeBSD.org>
3031
3032 * fbsd-nat.c: Include gdbarch.h.
3033
07128006
TT
30342019-07-15 Tom Tromey <tromey@adacore.com>
3035
3036 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3037
1f77b012
TT
30382019-07-15 Tom Tromey <tromey@adacore.com>
3039
3040 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3041 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3042 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3043 * cli-out.c (cli_ui_out::do_field_int): New method.
3044 * ui-out.c (ui_out::field_unsigned): New method.
3045 * symfile.c (generic_load): Use field_unsigned.
3046 (print_transfer_performance): Likewise.
3047 * record-btrace.c (ui_out_field_uint): Remove.
3048 (btrace_call_history_insn_range, btrace_call_history): Use
3049 field_unsigned.
3050 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3051 field_unsigned.
3052 * ui-out.h (class ui_out) <field_unsigned>: New method.
3053 <do_field_unsigned>: Likewise.
3054
33eca680
TT
30552019-07-15 Tom Tromey <tromey@adacore.com>
3056
3057 * mi/mi-main.c (list_available_thread_groups): Use field_string.
3058 * mi/mi-interp.c (mi_memory_changed): Use field_string.
3059 * target.c (flash_erase_command): Use field_string.
3060 * infrun.c (print_signal_received_reason): Use field_string.
3061 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3062 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3063 field_string.
3064 * ada-tasks.c (print_ada_task_info): Use field_string.
3065
ca8d69be
TT
30662019-07-15 Tom Tromey <tromey@adacore.com>
3067
3068 * target.c (flash_erase_command): Use field_core_addr.
3069 * symfile.c (generic_load): Use field_core_addr.
3070 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3071 Use field_core_addr.
3072 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3073 field_core_addr.
3074
0d4e84ed
AB
30752019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3076
3077 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3078 value if its desired type is smaller than a CORE_ADDR and signed.
3079
9a49df9d
AB
30802019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3081
3082 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3083 of changes to field names, and use new is_reference field to
3084 decide if a property is a reference or not.
3085 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3086 field.
3087 (struct dwarf2_property_baton): Update header comment, rename
3088 'referenced_type' to 'property_type' and update comments.
3089 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3090 default property type, store in property baton, update to take
3091 accound of renamed field.
3092 (read_func_scope): Update call to attr_to_dynamic_prop.
3093 (read_array_type): Likewise.
3094 (dwarf2_per_cu_addr_sized_int_type): New function.
3095 (read_subrange_index_type): Move type finding code to
3096 dwarf2_per_cu_addr_sized_int_type.
3097 (read_subrange_type): Update calls to attr_to_dynamic_prop.
3098 (dwarf2_per_cu_addr_type): New function.
3099 (set_die_type): Update calls to attr_to_dynamic_prop.
3100
b86352cf
AB
31012019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3102
3103 * dwarf2read.c (read_subrange_index_type): New function.
3104 (read_subrange_type): Move code into new function and call it.
3105 * gdbtypes.c (create_range_type): Add some asserts.
3106
603490bf
AB
31072019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3108
3109 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3110 update return statements.
3111 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3112 declaration, and update comment to match.
3113 * gdbtypes.c (resolve_dynamic_array): Update call to
3114 dwarf2_evaluate_property to match new return type.
3115
592f9d27
AB
31162019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
3117
3118 * valarith.c (value_subscripted_rvalue): Change lowerbound
3119 parameter type from int to LONGEST.
3120 * value.h (value_subscripted_rvalue): Likewise in declaration.
3121
60cfcb20
AB
31222019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3123
3124 * cli/cli-utils.c (info_print_command_completer): New function.
3125 * cli/cli-utils.h: Add 'completer.h' include, and forward
3126 declaration for 'struct cmd_list_element'.
3127 (info_print_command_completer): Declare.
3128 * stack.c (_initialize_stack): Add completer for 'info locals' and
3129 'info args'.
3130 * symtab.c (_initialize_symtab): Add completer for 'info
3131 variables' and 'info functions'.
3132 * NEWS: Mention completion for additional info commands.
3133
b16507e0
AB
31342019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3135
3136 * cli/cli-utils.c (extract_info_print_args): Delete.
3137 (extract_arg_maybe_quoted): Delete.
3138 (info_print_options_defs): New variable.
3139 (make_info_print_options_def_group): New function.
3140 (extract_info_print_options): Define new function.
3141 * cli/cli-utils.h (extract_info_print_args): Delete.
3142 (struct info_print_options): New structure.
3143 (extract_info_print_options): Declare new function.
3144 * stack.c (info_locals_command): Update to use new
3145 extract_info_print_options, also add a header comment.
3146 (info_args_command): Likewise.
3147 * symtab.c (info_variables_command): Likewise.
3148 (info_functions_command): Likewise.
3149
021d8588
AB
31502019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
3151
3152 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3153 to extract string arguments.
3154 * common/common-utils.c (extract_string_maybe_quoted): New function.
3155 * common/common-utils.h (extract_string_maybe_quoted): Declare.
3156
b777eb6d
TT
31572019-07-11 Tom Tromey <tromey@adacore.com>
3158
3159 * main.c (get_init_files): Use GDBINIT, not gdbinit.
3160 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3161 * top.h (gdbinit): Don't declare.
3162 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3163 into...
3164 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
3165 * top.c (gdb_init): Don't call init_cli_cmds.
3166 (gdbinit): Remove.
3167 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3168
72ee03ff
TT
31692019-07-11 Tom Tromey <tromey@adacore.com>
3170
3171 * python/py-inferior.c (add_thread_object): Don't use thread_obj
3172 after it has been moved.
3173
00db9531
SM
31742019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3175
3176 * valops.c (value_must_coerce_to_target): Change return type to
3177 bool.
3178 * value.h (value_must_coerce_to_target): Likewise.
3179
f2478a7e
SM
31802019-07-10 Simon Marchi <simon.marchi@efficios.com>
3181
3182 * breakpoint.c (is_hardware_watchpoint): Remove
3183 forward-declaration.
3184 (is_masked_watchpoint): Change return type to bool.
3185 (is_tracepoint): Likewise.
3186 (is_breakpoint): Likewise.
3187 (is_hardware_watchpoint): Likewise.
3188 (is_watchpoint): Likewise.
3189 (is_no_memory_software_watchpoint): Likewise.
3190 (is_catchpoint): Likewise.
3191 (breakpoint_1): Make FILTER parameter's return type bool.
3192 is_masked_watchpoint): Change return type to bool.
3193 (save_breakpoints): Make FILTER parameter's return type bool.
3194 * breakpoint.h (is_breakpoint): Change return type to bool.
3195 (is_watchpoint): Likewise.
3196 (is_catchpoint): Likewise.
3197 (is_tracepoint): Likewise.
3198
0d12e84c
TT
31992019-07-10 Tom Tromey <tom@tromey.com>
3200
3201 * defs.h: Don't include gdbarch.h.
3202 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3203 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3204 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3205 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3206 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3207 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3208 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3209 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3210 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3211 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3212 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3213 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3214 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3215 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3216 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3217 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3218 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3219 record-btrace.c, record.h, regcache-dump.c, regcache.h,
3220 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3221 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3222 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3223 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3224 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3225 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3226 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3227 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3228 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3229
f06f1252
TT
32302019-07-10 Tom Tromey <tromey@adacore.com>
3231
3232 * ada-lang.h (is_ada_exception_catchpoint): Declare.
3233 * breakpoint.c (init_ada_exception_breakpoint): Register as
3234 bp_catchpoint.
3235 (print_one_breakpoint_location, print_one_breakpoint): Use
3236 is_ada_exception_catchpoint.
3237 * ada-lang.c (class ada_catchpoint_location): Pass
3238 bp_loc_software_breakpoint to bp_location constructor.
3239 (is_ada_exception_catchpoint): New function.
3240
7a5d944b
TT
32412019-07-10 Tom Tromey <tromey@adacore.com>
3242
3243 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
3244 VEC.
3245 (struct arm_exidx_entry): New method operator<.
3246 (struct arm_exidx_data) <section_maps>: Change type.
3247 (arm_exidx_data_free): Remove.
3248 (arm_exidx_data_key): Change type. Move lower.
3249 (arm_exidx_new_objfile): Update.
3250 (arm_compare_exidx_entries): Remove.
3251 (arm_find_exidx_entry, _initialize_arm_tdep)
3252
48c66e1d
TT
32532019-07-10 Tom Tromey <tromey@adacore.com>
3254
3255 * solib-spu.c (ocl_program_data_key): Change type.
3256 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3257 Update.
3258
a269fbf1
TT
32592019-07-10 Tom Tromey <tromey@adacore.com>
3260
3261 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
3262 (struct solib_aix_inferior_data) <library_list>: Change type.
3263 (solib_aix_inferior_data_handle): Change type.
3264 (get_solib_aix_inferior_data): Update.
3265 (solib_aix_free_library_list): Remove.
3266 (library_list_start_library): Update.
3267 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3268 return type.
3269 (solib_aix_get_library_list)
3270 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3271 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3272
c294730c
TT
32732019-07-10 Tom Tromey <tromey@adacore.com>
3274
3275 * solib-dsbt.c (struct dsbt_info): Add initializers.
3276 (solib_dsbt_pspace_data): Change type.
3277 (dsbt_pspace_data_cleanup): Remove.
3278 (get_dsbt_info, _initialize_dsbt_solib): Update.
3279
9d52077d
TT
32802019-07-10 Tom Tromey <tromey@adacore.com>
3281
3282 * spu-tdep.c (spu_overlay_data): Change type.
3283 (spu_get_overlay_table, spu_overlay_new_objfile)
3284 (_initialize_spu_tdep): Update.
3285
22a20dca
TT
32862019-07-10 Tom Tromey <tromey@adacore.com>
3287
3288 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3289 destructor.
3290 (dbx_objfile_data_key): Change type and declare later.
3291 (DBX_SYMFILE_INFO): Rewrite.
3292 * dbxread.c (dbx_objfile_data_key): Change type.
3293 (dbx_symfile_init): Update.
3294 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
3295 (coffstab_build_psymtabs, elfstab_build_psymtabs)
3296 (stabsect_build_psymtabs, _initialize_dbxread): Update.
3297
cb60f420
TT
32982019-07-10 Tom Tromey <tromey@adacore.com>
3299
3300 * jit.c (jit_program_space_key): Change type. Move lower.
3301 (get_jit_program_space_data): Update.
3302 (jit_program_space_data_cleanup): Remove.
3303 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3304 Update.
3305 (struct jit_program_space_data): Add initializers.
3306
51df2ae3
TT
33072019-07-10 Tom Tromey <tromey@adacore.com>
3308
3309 * solib-darwin.c (struct darwin_info): Add initializers.
3310 (solib_darwin_pspace_data): Change type.
3311 (darwin_pspace_data_cleanup): Remove.
3312 (get_darwin_info, _initialize_darwin_solib): Update.
3313
18101a35
TT
33142019-07-10 Tom Tromey <tromey@adacore.com>
3315
3316 * remote-sim.c (struct sim_inferior_data): Add initializers,
3317 constructor, and destructor.
3318 (sim_inferior_data_key): Change type. Move lower.
3319 (check_for_duplicate_sim_descriptor): Update.
3320 (get_sim_inferior_data): Use new. Update.
3321 (~sim_inferior_data_cleanup): Rename from
3322 sim_inferior_data_cleanup. Simplify.
3323 (gdbsim_close_inferior, simulator_command)
3324 (sim_command_completer, _initialize_remote_sim): Update.
3325 (next_pid, INITIAL_PID): Move earlier.
3326
05b08ac1
TT
33272019-07-10 Tom Tromey <tromey@adacore.com>
3328
3329 * python/python-internal.h (create_thread_object): Return
3330 gdbpy_ref.
3331 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3332 * python/py-inferior.c (struct threadlist_entry): Add
3333 constructor.
3334 <thread_obj>: Now a gdbpy_ref.
3335 (thread_to_thread_object): Update.
3336 (add_thread_object): Use new.
3337 (delete_thread_object): Use delete.
3338 (infpy_threads): Update.
3339 (py_free_inferior): Update. Construct "inf_obj" after acquiring
3340 GIL.
3341
32372d80
TT
33422019-07-10 Tom Tromey <tromey@adacore.com>
3343
3344 * valops.c (value_cast): Specialize error message for Ada.
3345
5c458ae8
SM
33462019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3347
3348 * breakpoint.c (breakpoint_1): Update doc and parameter names.
3349
4c462cb0
SM
33502019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
3351
3352 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3353 bpstat_should_step): Return bool, adjust comments.
3354 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3355 bpstat_should_step): Likewise.
3356
89abbcc2
AH
33572019-07-10 Alan Hayward <alan.hayward@arm.com>
3358
3359 * features/Makefile: Use feature target descriptions for Arm.
3360 * features/arm/arm-core.c: Generate new file.
3361 * features/arm/arm-fpa.c: Likewise.
3362 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3363 * features/arm/arm-m-profile.c: Likewise.
3364 * features/arm/arm-vfpv2.c: Likewise.
3365 * features/arm/arm-vfpv3.c: Likewise.
3366 * features/arm/xscale-iwmmxt.c: Likewise.
3367 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3368
166a82be
AH
33692019-07-10 Alan Hayward <alan.hayward@arm.com>
3370
3371 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3372 ptrace earlier.
3373
9fb4c7e9
AH
33742019-07-10 Alan Hayward <alan.hayward@arm.com>
3375
3376 * features/aarch64-pauth.c: Regenerate.
3377
e2d0f980
SM
33782019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
3379
3380 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3381 bool.
3382 (bpstat_what): Use false instead of 0.
3383
a38118e5
PA
33842019-07-09 Pedro Alves <palves@redhat.com>
3385
3386 * break-catch-throw.c (is_exception_catchpoint): New.
3387 * breakpoint.c (print_one_breakpoint_location): New parameter
3388 'raw_loc'. Handle it. Use
3389 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3390 looking at the breakpoint's type.
3391 (print_one_breakpoint): If handling "maint info breakpoints", also
3392 print locations of exception catchpoints.
3393 * breakpoint.h (is_exception_catchpoint): Declare.
3394
cb1e4e32
PA
33952019-07-09 Pedro Alves <palves@redhat.com>
3396
3397 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3398 "addr" field.
3399 (allocate_location_exception_catchpoint): New.
3400 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3401 (initialize_throw_catchpoint_ops): Install
3402 allocate_location_exception_catchpoint as allocate_location
3403 method.
3404 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3405 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3406 bp_loc_other.
3407 (breakpoint_address_is_meaningful): Delete.
3408 (bl_address_is_meaningful): New.
3409 (breakpoint_locations_match): Adjust comment.
3410 (bp_location_from_bp_type): New, factored out of...
3411 (bp_location::bp_location(breakpoint *)): ... this.
3412 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3413 factored out of...
3414 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
3415 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3416 breakpoint_address_is_meaningful.
3417 (bp_locations_compare): Adjust comment.
3418 (update_global_location_list): Use bl_address_is_meaningful
3419 instead of breakpoint_address_is_meaningful.
3420 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3421 explicit.
3422 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3423 * python/py-breakpoint.c (bppy_get_location): No longer check
3424 whether location is null.
3425
b58a68fe
PA
34262019-07-09 Pedro Alves <palves@redhat.com>
3427
3428 PR c++/15468
3429 * breakpoint.c (print_one_breakpoint_location): Remove
3430 single-location assert.
3431
268a13a5
TT
34322019-07-09 Tom Tromey <tom@tromey.com>
3433
3434 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3435 * configure: Rebuild.
3436 * configure.ac: Change common to gdbsupport.
3437 * gdbsupport: Rename from common.
3438 * acinclude.m4: Change common to gdbsupport.
3439 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3440 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3441 gdbsupport.
3442 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3443 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3444 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3445 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3446 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3447 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3448 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3449 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3450 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3451 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3452 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3453 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3454 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3455 coff-pe-read.c, command.h, compile/compile-c-support.c,
3456 compile/compile-c.h, compile/compile-cplus-symbols.c,
3457 compile/compile-cplus-types.c, compile/compile-cplus.h,
3458 compile/compile-loc2c.c, compile/compile.c, completer.c,
3459 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3460 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3461 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3462 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3463 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3464 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3465 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3466 features/aarch64-core.c, features/aarch64-fpu.c,
3467 features/aarch64-pauth.c, features/aarch64-sve.c,
3468 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3469 features/i386/32bit-core.c, features/i386/32bit-linux.c,
3470 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3471 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3472 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3473 features/i386/64bit-core.c, features/i386/64bit-linux.c,
3474 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3475 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3476 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3477 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3478 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3479 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3480 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3481 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3482 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3483 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3484 go32-nat.c, guile/guile.c, guile/scm-ports.c,
3485 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3486 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3487 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3488 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3489 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3490 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3491 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3492 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3493 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3494 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3495 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3496 minsyms.c, mips-linux-tdep.c, namespace.h,
3497 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3498 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3499 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3500 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3501 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3502 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3503 nat/linux-waitpid.c, nat/mips-linux-watch.c,
3504 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3505 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3506 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3507 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3508 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3509 procfs.c, producer.c, progspace.h, psymtab.h,
3510 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3511 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3512 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3513 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3514 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3515 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3516 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3517 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3518 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3519 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3520 target-memory.c, target.c, target.h, target/waitstatus.c,
3521 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3522 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3523 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3524 unittests/array-view-selftests.c,
3525 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3526 unittests/common-utils-selftests.c,
3527 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3528 unittests/format_pieces-selftests.c,
3529 unittests/function-view-selftests.c,
3530 unittests/lookup_name_info-selftests.c,
3531 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3532 unittests/mkdir-recursive-selftests.c,
3533 unittests/observable-selftests.c,
3534 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3535 unittests/parse-connection-spec-selftests.c,
3536 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3537 unittests/scoped_fd-selftests.c,
3538 unittests/scoped_mmap-selftests.c,
3539 unittests/scoped_restore-selftests.c,
3540 unittests/string_view-selftests.c, unittests/style-selftests.c,
3541 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3542 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3543 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3544 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3545 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3546 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3547
5b0e2db4
AB
35482019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3549
3550 * linespec.c (decode_digits_list_mode): Set explicit_line to a
3551 bool value.
3552 (decode_digits_ordinary): Set explicit_line field in sal.
3553 * symtab.c (skip_prologue_sal): Don't skip prologue for a
3554 symtab_and_line that was set on an explicit line number in
3555 assembler code. Do always update the recorded symtab and line if
3556 we do skip the prologue.
3557
0ba852ab
AB
35582019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3559
3560 * breakpoint.c (set_breakpoint_location_function): Remove
3561 explicit_loc parameter.
3562 (momentary_breakpoint_from_master): Update call to
3563 set_breakpoint_location_function.
3564 (add_location_to_breakpoint): Likewise.
3565
b3a7d171
AB
35662019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
3567
3568 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3569 required features based on default bfd type when no specific bfd
3570 is present.
3571
1f6f6e21
PW
35722019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3573
3574 * NEWS: Mention that GDB printf and eval commands can now print
3575 C-style and Ada-style convenience var strings without
3576 calling the inferior.
3577 * printcmd.c (printf_c_string): Locally print GDB internal var
3578 instead of transiting via the inferior.
3579 (printf_wide_c_string): Likewise.
3580
35812019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
3582
3583 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3584
0598af48
TT
35852019-07-04 Tom Tromey <tom@tromey.com>
3586
3587 PR tui/24724:
3588 * tui/tui-winsource.c (tui_clear_source_content): Update.
3589 (tui_source_window_base::set_is_exec_point_at): Fix comment.
3590 (tui_update_breakpoint_info): Update.
3591 (tui_set_exec_info_content): Update.
3592 * tui/tui-source.c (tui_set_source_content_nil): Update.
3593 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3594 has_break.
3595 * tui/tui-data.h (enum tui_bp_flag): New.
3596 (tui_bp_flags): New enum flags type.
3597 (struct tui_source_element) <break_mode>: Change type. Rename
3598 from has_break.
3599 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3600 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
3601 constants.
3602 * tui/tui-winsource.h: Fix comment.
3603
350fab54
AH
36042019-07-04 Alan Hayward <alan.hayward@arm.com>
3605
3606 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3607 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3608 (store_fpregs_to_thread)
3609 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3610 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3611 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3612 (IWMMXT_REGS_SIZE): Add define.
3613 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3614 (fetch_vfp_regs, store_vfp_regs)
3615 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3616 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3617
f0452268
AH
36182019-07-04 Alan Hayward <alan.hayward@arm.com>
3619
3620 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3621 defines.
3622 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3623 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3624 (ARM_INT_REGISTER_SIZE): ...to this.
3625 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3626 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3627 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3628 (arm_linux_collect_gregset, supply_nwfpe_register)
3629 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3630 defines.
3631 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3632 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3633 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3634 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3635 (arm_return_in_memory, arm_store_return_value)
3636 (arm_get_longjmp_target, arm_register_g_packet_guesses)
3637 (arm_record_ld_st_multiple): Likewise.
3638 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3639 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3640
e935475c
AH
36412019-07-04 Alan Hayward <alan.hayward@arm.com>
3642
3643 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3644 AARCH64_DISPLACED_MODIFIED_INSNS.
3645 * aarch64-tdep.c (struct aarch64_displaced_step_data)
3646 (aarch64_displaced_step_copy_insn): Likewise.
3647 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3648 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3649 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3650 ARM_DISPLACED_MODIFIED_INSNS.
3651 * arm-tdep.c (arm_gdbarch_init): Likewise.
3652 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3653 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3654 (struct arm_displaced_step_closure): Use
3655 ARM_DISPLACED_MODIFIED_INSNS.
3656
df0bb381
AH
36572019-07-04 Alan Hayward <alan.hayward@arm.com>
3658
3659 * features/Makefile: Remove unused xml files.
3660 * features/aarch64.xml: Remove.
3661 * features/i386/amd64-avx-avx512-linux.xml: Remove.
3662 * features/i386/amd64-avx-avx512.xml: Remove.
3663 * features/i386/amd64-avx-linux.xml: Remove.
3664 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3665 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3666 * features/i386/amd64-avx-mpx-linux.xml: Remove.
3667 * features/i386/amd64-avx-mpx.xml: Remove.
3668 * features/i386/amd64-avx.xml: Remove.
3669 * features/i386/amd64-linux.xml: Remove.
3670 * features/i386/amd64-mpx-linux.xml: Remove.
3671 * features/i386/amd64-mpx.xml: Remove.
3672 * features/i386/amd64.xml: Remove.
3673 * features/i386/i386-avx-avx512-linux.xml: Remove.
3674 * features/i386/i386-avx-avx512.xml: Remove.
3675 * features/i386/i386-avx-linux.xml: Remove.
3676 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3677 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3678 * features/i386/i386-avx-mpx-linux.xml: Remove.
3679 * features/i386/i386-avx-mpx.xml: Remove.
3680 * features/i386/i386-avx.xml: Remove.
3681 * features/i386/i386-linux.xml: Remove.
3682 * features/i386/i386-mmx-linux.xml: Remove.
3683 * features/i386/i386-mmx.xml: Remove.
3684 * features/i386/i386-mpx-linux.xml: Remove.
3685 * features/i386/i386-mpx.xml: Remove.
3686 * features/i386/i386.xml: Remove.
3687 * features/i386/x32-avx-avx512-linux.xml: Remove.
3688 * features/i386/x32-avx-linux.xml: Remove.
3689 * features/i386/x32-linux.xml: Remove.
3690
edd6266a
AH
36912019-07-04 Alan Hayward <alan.hayward@arm.com>
3692
3693 * regformats/aarch64.dat: Remove.
3694 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3695 * regformats/i386/amd64-avx-linux.dat: Remove.
3696 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3697 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3698 * regformats/i386/amd64-linux.dat: Remove.
3699 * regformats/i386/amd64-mpx-linux.dat: Remove.
3700 * regformats/i386/amd64.dat: Remove.
3701 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3702 * regformats/i386/i386-avx-linux.dat: Remove.
3703 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3704 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3705 * regformats/i386/i386-linux.dat: Remove.
3706 * regformats/i386/i386-mmx-linux.dat: Remove.
3707 * regformats/i386/i386-mpx-linux.dat: Remove.
3708 * regformats/i386/i386.dat: Remove.
3709 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3710 * regformats/i386/x32-avx-linux.dat: Remove.
3711 * regformats/i386/x32-linux.dat: Remove.
3712
2b40fda7
AH
37132019-07-04 Alan Hayward <alan.hayward@arm.com>
3714
3715 * aarch64-tdep.c: Remove xml self tests.
3716 * amd64-linux-tdep.c: Likewise.
3717 * amd64-tdep.c: Likewise.
3718 * i386-linux-tdep.c: Likewise.
3719 * i386-tdep.c: Likewise.
3720
5f4ba3e7
PA
37212019-07-03 Pedro Alves <palves@redhat.com>
3722
3723 PR cli/24732
3724 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3725 (pipe_cmd_option_defs): New.
3726 (make_pipe_cmd_options_def_group): New.
3727 (pipe_command): Use gdb::option::process_options.
3728 (pipe_command_completer): New function.
3729 (_initialize_cli_cmds): Install completer for "pipe" command.
3730
3d9be6f5
PA
37312019-07-03 Pedro Alves <palves@redhat.com>
3732
3733 * cli/cli-option.c (union option_value) <string>: New field.
3734 (struct option_def_and_value): Add ctor, move ctor, dtor and
3735 use DISABLE_COPY_AND_ASSIGN.
3736 (option_def_and_value::clear_value): New.
3737 (parse_option, save_option_value_in_ctx, get_val_type_str)
3738 (add_setshow_cmds_for_options): Handle var_string.
3739 * cli-option.h (union option_def::var_address) <string>: New
3740 field.
3741 (struct string_option_def): New.
3742 * maint-test-options.c (struct test_options_opts): Add default
3743 ctor and use DISABLE_COPY_AND_ASSIGN.
3744 <string_opt>: New field.
3745 (test_options_opts::~test_options_opts): New.
3746 (test_options_opts::dump): Also dump "-string".
3747 (test_options_option_defs): Install "string.
3748
41fc454c
PA
37492019-07-03 Pedro Alves <palves@redhat.com>
3750
3751 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3752 option_value with a null enumeration.
3753 (complete_options): Save the option values in the context.
3754 (save_option_value_in_ctx): New, factored out from ...
3755 (process_options): ... here.
3756 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3757 of the function.
3758 * maint-test-options.c (test_options_opts::dump): New, factored
3759 out from ...
3760 (maintenance_test_options_command_mode): ... here.
3761 (maintenance_test_options_command_completion_result): Delete.
3762 (maintenance_test_options_command_completion_text): Update
3763 comment.
3764 (maintenance_show_test_options_completion_result): Change
3765 prototype. Just print
3766 maintenance_test_options_command_completion_text.
3767 (save_completion_result): New.
3768 (maintenance_test_options_completer_mode): Pass options context to
3769 complete_options, and then save a dump.
3770 (_initialize_maint_test_options): Use add_cmd to install "maint
3771 show test-options-completion-result".
3772
fdbc9870
PA
37732019-07-03 Pedro Alves <palves@redhat.com>
3774
3775 * NEWS (New commands): Mention "with" and "maint with".
3776 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3777 (with_command, with_command_completer): New.
3778 (pipe_command): Adjust to new repeat_previous
3779 interface.
3780 (_initialize_cli_cmds): Install the "with" command and its "w"
3781 alias.
3782 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3783 declarations.
3784 * cli/cli-setshow.c (parse_cli_var_uinteger)
3785 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3786 argument strings for all var_types.
3787 (get_setshow_command_value_string): New, factored out from ...
3788 (do_show_command): ... this.
3789 * cli/cli-setshow.h: Include <string>.
3790 (get_setshow_command_value_string): Declare.
3791 * command.h (repeat_previous): Now returns const char *. Adjust
3792 comment.
3793 * maint.c: Include "cli/cli-cmds.h".
3794 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3795 (_initialize_maint_cmds): Register the "maintenance with" command.
3796 * top.c (repeat_previous): Move bits from pipe_command here:
3797 Return the saved command line, if any; error out if there's no
3798 command to relaunch.
3799
c6ac8931
PA
38002019-07-03 Pedro Alves <palves@redhat.com>
3801
3802 * NEWS (New commands): Mention "maint set/show test-settings"
3803 instead of "maint test-settings".
3804 * maint-test-settings.c (maintenance_test_settings_list): Delete.
3805 (maintenance_test_settings_set_list): Rename to ...
3806 (maintenance_set_test_settings_list): ... this.
3807 (maintenance_test_settings_show_list): Rename to ...
3808 (maintenance_show_test_settings_list): ... this.
3809 (maintenance_test_settings_cmd): Delete.
3810 (maintenance_test_settings_set_cmd): ...
3811 (maintenance_set_test_settings_cmd): ... this.
3812 (maintenance_test_settings_show_cmd): ...
3813 (maintenance_show_test_settings_cmd): ... this.
3814 (maintenance_test_settings_show_value_cmd):
3815 (maintenance_show_test_settings_value_cmd): ... this.
3816 (_initialize_maint_test_settings): No longer install the "maint
3817 test-settings" prefix command. Rename "maint test-settings set"
3818 to "maint set test-settings", and "maint test-settings show" to
3819 "maint show test-settings". Adjust all subcommands.
3820
d1fcf2fd
PA
38212019-07-03 Pedro Alves <palves@redhat.com>
3822
3823 * maint-test-settings.c: Fix file's intro comment. Replace all
3824 references to "test-options" with references to "test-settings",
3825 in comments.
3826
970f9d09
PA
38272019-07-03 Pedro Alves <palves@redhat.com>
3828
3829 * maint-test-settings.c (maintenance_test_settings_xxx)
3830 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3831 New.
3832 (maintenance_test_settings_enums): Use them.
3833 (maintenance_test_settings_enum): Default to
3834 maintenance_test_settings_xxx.
3835 (_initialize_maint_test_settings): Initialize
3836 MAINTENANCE_TEST_SETTINGS_FILENAME.
3837
f3869b1a
SM
38382019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3839
3840 * breakpoint.h (remove_breakpoints_inf): Change return type to
3841 void, move function documentation here.
3842 * breakpoint.c (remove_breakpoints_inf): Change return type to
3843 void, move function documentation to header.
3844
54d66006
PA
38452019-07-02 Pedro Alves <palves@redhat.com>
3846
3847 * NEWS (Completion improvements): Mention "info threads".
3848 * thread.c (struct info_threads_opts, info_threads_option_defs)
3849 (make_info_threads_options_def_group): New.
3850 (info_threads_command): Use gdb::option::process_options.
3851 (info_threads_command_completer): New.
3852 (_initialize_thread): Use gdb::option::build_help to build the
3853 help text for "info threads".
3854
854f6088
SM
38552019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
3856
3857 * defs.h (generic_load): Move from here...
3858 * symfile.h (generic_load): ... to here. Rename name parameter
3859 to args.
3860 * symfile.c (generic_load): Add comment.
3861
54ee4252
TT
38622019-07-01 Tom Tromey <tromey@adacore.com>
3863
3864 * dwarf2read.c
3865 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3866 declaration of without_params. Fix formatting.
3867
65392b3e
TT
38682019-07-01 Tom Tromey <tromey@adacore.com>
3869
3870 * ada-exp.y (find_primitive_type): Update.
3871 * ada-lang.h (ada_lookup_symbol): Update.
3872 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3873 parameter.
3874 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3875
7d7571f0
SDJ
38762019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3877
3878 PR breakpoints/24541
3879 * gdbarch.c: Regenerate.
3880 * gdbarch.h: Regenerate.
3881 * gdbarch.sh: Add 'stap_adjust_register'.
3882 * i386-tdep.c: Include '<unordered_set>'.
3883 (i386_stap_adjust_register): New function.
3884 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3885 * stap-probe.c (stap_parse_register_operand): Call
3886 'gdbarch_stap_adjust_register'.
3887
5af5392a
SDJ
38882019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
3889
3890 PR python/24742
3891 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3892 * python/python.c (do_start_initialization): Use 'xmalloc'
3893 instead of 'PyMem_Malloc'.
3894
10d06d82
TT
38952019-06-28 Tom Tromey <tromey@adacore.com>
3896
3897 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3898 for Ada.
3899
1b7f24cd
TT
39002019-06-27 Tom Tromey <tromey@adacore.com>
3901
3902 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
3903 objfile_key.
3904 (arm_find_mapping_symbol, arm_record_special_symbol)
3905 (_initialize_arm_tdep): Update.
3906 (arm_objfile_data_free): Remove.
3907
3d507ff2
TT
39082019-06-27 Tom Tromey <tromey@adacore.com>
3909
3910 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3911 to cp_print_static_field.
3912
762c164d
TT
39132019-06-26 Tom Tromey <tromey@adacore.com>
3914
3915 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3916 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3917 declare.
3918
aa2f9bcf
AH
39192019-06-26 Alan Hayward <alan.hayward@arm.com>
3920
3921 * features/aarch64-core.c (create_feature_aarch64_core):
3922 Regenerate.
3923 * features/aarch64-core.xml: Add cpsr flags.
3924
3426ae57
AH
39252019-06-26 Alan Hayward <alan.hayward@arm.com>
3926
3927 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3928 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3929
4838e44c
SM
39302019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3931
3932 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3933 field.
3934 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3935 use.
3936 (arm_record_special_symbol): Don't insert new symbol in sorted
3937 position, push it at the end.
3938
54cc7474
SM
39392019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
3940
3941 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3942 (arm_mapping_symbol_s): Remove.
3943 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3944 (arm_mapping_symbol_vec): New typedef.
3945 (struct arm_per_objfile): Add constructor.
3946 <section_maps>: Change type to
3947 std::unique_ptr<arm_mapping_symbol_vec[]>.
3948 (arm_compare_mapping_symbols): Remove.
3949 (arm_find_mapping_symbol): Adjust to section_maps type change.
3950 (arm_objfile_data_free): Call delete on arm_per_objfile.
3951 (arm_record_special_symbol): Adjust to section_maps type change.
3952 Allocate arm_per_objfile with new.
3953
b65b566c
PW
39542019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3955
3956 * cli/cli-cmds.c (alias_command): Compare the alias prefix
3957 with the command prefix.
3958
c2fc64f5
TT
39592019-06-25 Tom Tromey <tom@tromey.com>
3960
3961 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3962 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3963
fb54fa76
TT
39642019-06-25 Tom Tromey <tom@tromey.com>
3965
3966 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3967 type.
3968 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3969 protected.
3970
f7952c57
TT
39712019-06-25 Tom Tromey <tom@tromey.com>
3972
3973 * tui/tui-winsource.c
3974 (tui_source_window_base::set_is_exec_point_at): Add check against
3975 LOA_ADDRESS.
3976
17568d78
TT
39772019-06-25 Tom Tromey <tom@tromey.com>
3978
3979 * tui/tui-source.c (tui_set_source_content): Don't check before
3980 xfree.
3981 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3982
53e7cdba
TT
39832019-06-25 Tom Tromey <tom@tromey.com>
3984
3985 * tui/tui-winsource.h (tui_update_source_window_as_is)
3986 (tui_alloc_source_buffer, tui_line_is_displayed)
3987 (tui_addr_is_displayed): Change type of win_info.
3988 * tui/tui-winsource.c (tui_update_source_window_as_is)
3989 (tui_clear_source_content, tui_show_source_line)
3990 (tui_show_source_content, tui_source_window_base::refill)
3991 (tui_source_window_base::set_is_exec_point_at)
3992 (tui_source_window_base::set_is_exec_point_at)
3993 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3994 (tui_alloc_source_buffer, tui_line_is_displayed)
3995 (tui_addr_is_displayed): Change type of win_info. Update.
3996 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3997 (tui_source_window_base::do_make_visible_with_new_height):
3998 Update.
3999 * tui/tui-source.c (tui_set_source_content)
4000 (tui_set_source_content_nil)
4001 (tui_source_window::do_scroll_vertical): Update.
4002 * tui/tui-layout.c (show_layout): Update.
4003 * tui/tui-disasm.c (tui_set_disassem_content)
4004 (tui_disasm_window::do_scroll_vertical): Update.
4005 * tui/tui-data.h (tui_win_content): Remove.
4006 (struct tui_gen_win_info) <content, content_size>: Remove.
4007 (struct tui_source_element): Add initializers and destructor.
4008 (union tui_which_element, struct tui_win_element): Remove.
4009 (struct tui_source_window_base) <content>: New field.
4010 (struct tui_data_window): Remove destructor.
4011 (tui_alloc_content, tui_free_win_content)
4012 (tui_free_all_source_wins_content): Don't declare.
4013 * tui/tui-data.c (tui_initialize_static_data): Update.
4014 (init_content_element, tui_alloc_content): Remove.
4015 (~tui_gen_win_info): Update.
4016 (~tui_data_window, tui_free_all_source_wins_content)
4017 (tui_free_win_content, free_content, free_content_elements):
4018 Remove.
4019
7908abbf
TT
40202019-06-25 Tom Tromey <tom@tromey.com>
4021
4022 * tui/tui-winsource.h (tui_clear_source_content)
4023 (tui_erase_source_content, tui_show_source_content): Change type
4024 of win_info.
4025 * tui/tui-winsource.c (tui_clear_source_content)
4026 (tui_erase_source_content, tui_show_source_content): Change type
4027 of win_info.
4028 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4029 * tui/tui-source.h (tui_set_source_content_nil): Change type of
4030 win_info.
4031 * tui/tui-source.c (tui_set_source_content_nil): Change type of
4032 win_info.
4033 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4034
02c28df0
TT
40352019-06-25 Tom Tromey <tom@tromey.com>
4036
4037 * tui/tui-winsource.c (tui_clear_source_content)
4038 (tui_source_window_base::set_is_exec_point_at): Update.
4039 * tui/tui-source.c (tui_set_source_content_nil): Update.
4040 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4041 a bool.
4042 * tui/tui-data.c (init_content_element): Update.
4043
6658b1bf
TT
40442019-06-25 Tom Tromey <tom@tromey.com>
4045
4046 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4047 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4048 * tui/tui-layout.c (init_and_make_win): Update.
4049 * tui/tui.h (enum tui_win_type): Update.
4050 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4051 tui_win_is_auxillary.
4052 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4053 tui_win_is_auxillary.
4054
21e1c91e
TT
40552019-06-25 Tom Tromey <tom@tromey.com>
4056
4057 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4058 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4059 (tui_delete_data_content_windows, tui_display_all_data)
4060 (tui_data_window::do_scroll_vertical, tui_display_data_from):
4061 Update.
4062 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4063 * tui/tui-regs.c (tui_last_regs_line_no)
4064 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4065 (tui_show_registers): Update.
4066 (tui_show_register_group): Return void. Update.
4067 (tui_display_registers_from, tui_display_reg_element_at_line)
4068 (tui_display_registers_from_line, tui_check_register_values):
4069 Update.
4070 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4071 member.
4072 (struct tui_data_window) <regs_content>: Now a std::vector.
4073 <regs_content_count>: Remove.
4074 (tui_add_content_elements, tui_free_data_content): Don't declare.
4075 * tui/tui-data.c (tui_data_window::clear_detail): Update.
4076 (init_content_element): Remove DATA_WIN case. Add assert.
4077 (tui_add_content_elements): Remove.
4078 (tui_data_window): Update.
4079 (tui_free_data_content): Remove.
4080 (free_content_elements): Remove DATA_WIN case.
4081
115ac53b
TT
40822019-06-25 Tom Tromey <tom@tromey.com>
4083
4084 * tui/tui-data.c (tui_data_item_window): Update.
4085 * tui/tui-windata.h (tui_check_data_values): Don't declare.
4086 * tui/tui-windata.c (tui_display_all_data)
4087 (tui_display_data_from_line): Update.
4088 (tui_check_data_values): Remove.
4089 * tui/tui-regs.c (tui_show_register_group)
4090 (tui_display_reg_element_at_line): Update.
4091 * tui/tui-hooks.c (tui_register_changed)
4092 (tui_refresh_frame_and_register_information): Call
4093 tui_check_register_values.
4094 * tui/tui-data.h (struct tui_data_window) <data_content,
4095 data_content_count, data_type>: Remove.
4096 (enum tui_data_type): Remove.
4097
4098 * tui/tui-data.c (tui_data_window::clear_detail)
4099 (~tui_data_window): Update.
4100
eaf9738b
TT
41012019-06-25 Tom Tromey <tom@tromey.com>
4102
4103 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4104 declare.
4105 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4106 Rename from tui_first_data_item_displayed. Update.
4107 (tui_data_window::refresh_all)
4108 (tui_data_window::do_scroll_vertical): Update.
4109 * tui/tui-data.h (struct tui_data_window)
4110 <first_data_item_displayed>: Declare new method.
4111
31ca4723
TT
41122019-06-25 Tom Tromey <tom@tromey.com>
4113
4114 * tui/tui-data.h (tui_init_generic_part): Don't declare.
4115 * tui/tui-data.c (tui_init_generic_part): Remove, moving
4116 contents...
4117 (tui_initialize_static_data): ...here.
4118
41bcff7f
TT
41192019-06-25 Tom Tromey <tom@tromey.com>
4120
4121 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4122 (tui_display_registers_from, tui_check_register_values): Update.
4123 (tui_display_register): Remove win_info parameter; update.
4124 (tui_get_register): Change type of parameters.
4125 * tui/tui-data.h (struct tui_data_element): Remove.
4126 (union tui_which_element) <data>: Remove.
4127 <data_window>: Change type.
4128 (struct tui_data_item_window): New.
4129 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4130 case. Add assert.
4131 (~tui_data_item_window): New destructor.
4132 (free_content_elements): Remove DATA_ITEM_WIN case.
4133
d2802c33
TT
41342019-06-25 Tom Tromey <tom@tromey.com>
4135
4136 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4137 Remove.
4138
dd835f8b
TT
41392019-06-25 Tom Tromey <tom@tromey.com>
4140
4141 * tui/tui-data.h (struct tui_command_element): Remove.
4142 (union tui_which_element) <command>: Remove.
4143 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
4144 assert.
4145 (free_content_elements): Remove CMD_WIN case.
4146
bd7db367
TT
41472019-06-25 Tom Tromey <tom@tromey.com>
4148
4149 * tui/tui-layout.c (tui_set_layout): Update.
4150 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4151 * tui/tui-data.c (layout_def): Update.
4152
3add462f
TT
41532019-06-25 Tom Tromey <tom@tromey.com>
4154
4155 * tui/tui-wingeneral.c (tui_refresh_all): Update.
4156 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4157 (tui_source_window_base::set_new_height): Update.
4158 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4159 Update.
4160 (tui_set_locator_fullname, tui_set_locator_info)
4161 (tui_show_frame_info): Update.
4162 * tui/tui-source.c (tui_set_source_content)
4163 (tui_source_is_displayed): Update.
4164 * tui/tui-layout.c (show_source_disasm_command, show_data)
4165 (show_source_or_disasm_and_command): Update.
4166 * tui/tui-disasm.c (tui_set_disassem_content)
4167 (tui_get_begin_asm_address): Update.
4168 * tui/tui-data.h (struct tui_locator_element): Remove.
4169 (union tui_which_element) <locator>: Remove.
4170 (struct tui_locator_window): New.
4171 (tui_locator_win_info_ptr): Change return type.
4172 * tui/tui-data.c (_locator): Change type.
4173 (tui_locator_win_info_ptr): Change return type.
4174 (init_content_element): Remove LOCATOR_WIN case. Add assert.
4175 (tui_alloc_content): Add assert.
4176
489e9d8b
TT
41772019-06-25 Tom Tromey <tom@tromey.com>
4178
4179 * tui/tui-winsource.c
4180 (tui_exec_info_window::maybe_allocate_content): New method.
4181 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4182 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4183 (make_source_or_disasm_window): Add cast.
4184 * tui/tui-data.h (union tui_which_element) <simple_string>:
4185 Remove.
4186 (struct tui_source_info): New.
4187 (struct tui_source_window_base) <execution_info>: Change type.
4188 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4189 case, and add assert.
4190 (tui_alloc_content): Add assert.
4191
c3fabb7d
TT
41922019-06-25 Tom Tromey <tom@tromey.com>
4193
4194 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4195 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4196 * tui/tui-data.c (tui_alloc_win_info): Remove.
4197
bbc228ee
TT
41982019-06-25 Tom Tromey <tom@tromey.com>
4199
4200 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4201 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4202 can_highlight.
4203
5fcee43a
TT
42042019-06-25 Tom Tromey <tom@tromey.com>
4205
4206 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4207 make_visible_with_new_height method.
4208 (tui_win_info::make_visible_with_new_height): New method.
4209 (tui_source_window_base::do_make_visible_with_new_height)
4210 (tui_data_window::do_make_visible_with_new_height)
4211 (tui_cmd_window::do_make_visible_with_new_height): New methods.
4212 (make_visible_with_new_height): Remove.
4213 (tui_resize_all, tui_adjust_win_heights): Use
4214 make_visible_with_new_height method.
4215 * tui/tui-data.h (struct tui_win_info)
4216 <do_make_visible_with_new_height, make_visible_with_new_height>:
4217 New methods.
4218 (struct tui_source_window_base, struct tui_data_window)
4219 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4220 methods.
4221
d83f1fe6
TT
42222019-06-25 Tom Tromey <tom@tromey.com>
4223
4224 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4225 method.
4226 (update_tab_width): Call update_tab_width method.
4227 * tui/tui-data.h (struct tui_win_info)
4228 (struct tui_source_window_base) <update_tab_width>: New methods.
4229
17374de4
TT
42302019-06-25 Tom Tromey <tom@tromey.com>
4231
4232 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4233 parameter.
4234 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4235 parameter.
4236 (tui_gen_win_info::make_visible): Update.
4237 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4238 parameter.
4239 * tui/tui-data.h (enum tui_box): New enum.
4240 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4241
f936bca2
TT
42422019-06-25 Tom Tromey <tom@tromey.com>
4243
4244 * tui/tui-layout.c (make_source_or_disasm_window): Always use
4245 init_and_make_win for EXEC_INFO_WIN.
4246 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4247 longer inline.
4248 (struct tui_win_info) <~tui_win_info>: Inline.
4249 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4250 Don't declare.
4251 * tui/tui-data.c (source_win, disasm_win): Remove globals.
4252 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4253 Remove.
4254 (tui_initialize_static_data): Update.
4255 (~tui_gen_win_info): Handle more cleanup here.
4256 (~tui_source_window_base): Delete "execution_info".
4257 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4258
d6ba6a11
TT
42592019-06-25 Tom Tromey <tom@tromey.com>
4260
4261 * tui/tui-layout.c (make_command_window): Don't set
4262 can_highlight.
4263 (show_source_disasm_command): Call the reset method.
4264 (show_data): Don't set can_highlight. Call the reset method.
4265 (tui_gen_win_info::reset): Rename from init_gen_win_info
4266 (init_and_make_win): Simplify. Return tui_gen_win_info.
4267 (show_source_or_disasm_and_command): Call the reset method.
4268 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4269 (struct tui_cmd_window): Set can_highlight.
4270
48a3bd16
TT
42712019-06-25 Tom Tromey <tom@tromey.com>
4272
4273 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4274 from make_visible.
4275 (tui_make_visible, tui_make_invisible): Rewrite.
4276 (tui_win_info::make_visible): Remove.
4277 (tui_source_window_base::make_visible): Update.
4278 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4279 method. Moved from...
4280 (struct tui_win_info) <make_visible>: ...here.
4281
c3bd716f
TT
42822019-06-25 Tom Tromey <tom@tromey.com>
4283
4284 * tui/tui-winsource.c
4285 (tui_source_window_base::do_scroll_horizontal): Remove direction
4286 parameter.
4287 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4288 direction parameter.
4289 * tui/tui-win.c (tui_win_info::forward_scroll)
4290 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4291 (tui_win_info::right_scroll): Update.
4292 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4293 direction parameter.
4294 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4295 direction parameter.
4296 * tui/tui-data.h (enum tui_scroll_direction): Remove.
4297 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4298 Remove direction parameter.
4299 (struct tui_source_window_base, struct tui_source_window)
4300 (struct tui_disasm_window, struct tui_data_window)
4301 (struct tui_cmd_window): Update.
4302
21c32dca
TT
43032019-06-25 Tom Tromey <tom@tromey.com>
4304
4305 * tui/tui-winsource.h (tui_set_exec_info_content)
4306 (tui_show_exec_info_content, tui_erase_exec_info_content)
4307 (tui_clear_exec_info_content, tui_update_exec_info): Change
4308 argument to tui_source_window_base.
4309 * tui/tui-winsource.c (tui_set_exec_info_content)
4310 (tui_show_exec_info_content, tui_erase_exec_info_content)
4311 (tui_clear_exec_info_content, tui_update_exec_info): Change
4312 argument to tui_source_window_base.
4313
73fbdc65
TT
43142019-06-25 Tom Tromey <tom@tromey.com>
4315
4316 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4317 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4318
33325343
TT
43192019-06-25 Tom Tromey <tom@tromey.com>
4320
4321 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4322 check.
4323
29d2c474
TT
43242019-06-25 Tom Tromey <tom@tromey.com>
4325
4326 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4327 type to void.
4328 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4329 type to void.
4330 * tui/tui-source.c (tui_set_source_content): Update.
4331 * tui/tui-disasm.c (tui_set_disassem_content): Update.
4332
152f3f4b
TT
43332019-06-25 Tom Tromey <tom@tromey.com>
4334
4335 * tui/tui-win.c (window_name_completer, tui_set_focus)
4336 (tui_all_windows_info): Use name method.
4337 * tui/tui-data.h (struct tui_gen_win_info)
4338 (struct tui_source_window, struct tui_disasm_window)
4339 (struct tui_data_window, struct tui_cmd_window) <name>: New
4340 method.
4341 (tui_win_name): Don't declare.
4342 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4343 (tui_win_name): Remove.
4344
be4da588
TT
43452019-06-25 Tom Tromey <tom@tromey.com>
4346
4347 * tui/tui-winsource.h (tui_update_source_window)
4348 (tui_update_source_window_as_is): Change parameter type.
4349 * tui/tui-winsource.c (tui_update_source_window): Change win_info
4350 to be a tui_source_window_base.
4351 (tui_update_source_window_as_is): Likewise.
4352 * tui/tui-win.c (make_visible_with_new_height): Update.
4353
5b81daba
TT
43542019-06-25 Tom Tromey <tom@tromey.com>
4355
4356 * tui/tui-winsource.c (tui_erase_source_content)
4357 (tui_show_source_content, tui_show_exec_info_content)
4358 (tui_erase_exec_info_content): Use refresh_window method.
4359 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4360 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4361 from tui_refresh_win.
4362 (tui_data_window::refresh_window): New method.
4363 (tui_win_info::refresh, tui_source_window_base::refresh)
4364 (tui_refresh_all): Use refresh_window method.
4365 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4366 method.
4367 * tui/tui-regs.c (tui_display_register): Call refresh_window
4368 method.
4369 * tui/tui-layout.c (show_source_disasm_command)
4370 (show_source_or_disasm_and_command): Call refresh_window method.
4371 * tui/tui-data.h (struct tui_gen_win_info)
4372 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4373 New method.
4374
cb2ce893
TT
43752019-06-25 Tom Tromey <tom@tromey.com>
4376
4377 * tui/tui.c (tui_rl_other_window, tui_enable)
4378 (tui_is_window_visible, tui_get_command_dimension): Update.
4379 * tui/tui-winsource.c (tui_update_source_window_as_is)
4380 (tui_clear_source_content, tui_erase_source_content)
4381 (tui_show_source_line, tui_source_window_base::refill)
4382 (tui_source_window_base::do_scroll_horizontal)
4383 (tui_source_window_base::set_is_exec_point_at)
4384 (tui_update_breakpoint_info, tui_set_exec_info_content)
4385 (tui_alloc_source_buffer, tui_line_is_displayed)
4386 (tui_addr_is_displayed): Update.
4387 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4388 (tui_check_and_display_highlight_if_needed)
4389 (tui_win_info::make_visible, tui_win_info::refresh)
4390 (tui_refresh_all): Update.
4391 * tui/tui-windata.c (tui_first_data_item_displayed)
4392 (tui_delete_data_content_windows, tui_erase_data_content)
4393 (tui_display_all_data, tui_data_window::refresh_all)
4394 (tui_check_data_values): Update.
4395 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4396 (tui_set_win_focus_to, tui_win_info::forward_scroll)
4397 (tui_win_info::backward_scroll, tui_refresh_all_win)
4398 (tui_resize_all, tui_set_focus, tui_all_windows_info)
4399 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4400 (tui_source_window_base::set_new_height)
4401 (tui_data_window::set_new_height)
4402 (make_invisible_and_set_new_height)
4403 (make_visible_with_new_height, new_height_ok)
4404 (parse_scrolling_args): Update.
4405 * tui/tui-stack.c (tui_show_frame_info): Update.
4406 * tui/tui-source.c (tui_set_source_content)
4407 (tui_set_source_content_nil, tui_source_is_displayed)
4408 (tui_source_window::do_scroll_vertical): Update.
4409 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4410 (tui_display_registers_from, tui_display_reg_element_at_line)
4411 (tui_check_register_values, tui_reg_command): Update.
4412 * tui/tui-layout.c (tui_default_win_height)
4413 (show_source_disasm_command, show_data, init_and_make_win)
4414 (show_source_or_disasm_and_command): Update.
4415 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4416 (tui_redisplay_readline, tui_mld_flush)
4417 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4418 (tui_getc): Update.
4419 * tui/tui-disasm.c (tui_set_disassem_content)
4420 (tui_disasm_window::do_scroll_vertical): Update.
4421 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4422 Now virtual.
4423 (struct tui_win_info): Derive from tui_gen_win_info.
4424 <~tui_win_info>: Mark as override.
4425 <generic>: Remove member.
4426 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4427 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4428 (~tui_data_window, ~tui_win_info)
4429 (tui_free_all_source_wins_content): Update.
4430 * tui/tui-command.c (tui_refresh_cmd_win): Update.
4431
ab313b35
TT
44322019-06-25 Tom Tromey <tom@tromey.com>
4433
4434 * tui/tui-layout.c (init_and_make_win): Use new.
4435 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4436 destructor, initializers.
4437 (tui_alloc_generic_win_info): Don't declare.
4438 * tui/tui-data.c (_locator): Add argument to constructor.
4439 (source_win, disasm_win): New globals.
4440 (exec_info): Remove.
4441 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4442 Update.
4443 (tui_alloc_generic_win_info): Remove.
4444 (init_content_element): Use new.
4445 (tui_win_info::tui_win_info): Update.
4446 (free_content_elements) <case DATA_WIN>: Use delete.
4447
dc2c33e4
TT
44482019-06-25 Tom Tromey <tom@tromey.com>
4449
4450 * tui/tui-wingeneral.c (tui_refresh_win): Update.
4451 * tui/tui-windata.c (tui_first_data_item_displayed)
4452 (tui_delete_data_content_windows): Update.
4453 * tui/tui-win.c (tui_data_window::set_new_height): Update.
4454 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4455 (tui_display_registers_from, tui_check_register_values): Update.
4456 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4457 pointer.
4458 * tui/tui-data.c (init_content_element): Update. Allocate the new
4459 window.
4460 (tui_free_data_content): Update.
4461 (free_content_elements) <case DATA_WIN>: Free the window.
4462
214a5cbe
TT
44632019-06-25 Tom Tromey <tom@tromey.com>
4464
4465 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4466 Update.
4467 * tui/tui-layout.c (make_command_window)
4468 (show_source_disasm_command, show_data, init_and_make_win)
4469 (show_source_or_disasm_and_command): Update.
4470 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4471 method.
4472 <can_highight, is_highlighted>: Now bool.
4473 (tui_set_win_highlight): Don't declare.
4474 * tui/tui-data.c (tui_set_win_highlight): Remove.
4475
8e2daf15
TT
44762019-06-25 Tom Tromey <tom@tromey.com>
4477
4478 * tui/tui-wingeneral.c (make_visible): Remove check of window
4479 type.
4480
8903bd8a
TT
44812019-06-25 Tom Tromey <tom@tromey.com>
4482
4483 * tui/tui-win.c (tui_win_info::max_height)
4484 (tui_cmd_window::max_height): New methods.
4485 (new_height_ok): Call max_height.
4486 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4487 <max_height>: New method.
4488
3f02ce1e
TT
44892019-06-25 Tom Tromey <tom@tromey.com>
4490
4491 * tui/tui-win.c (tui_source_window_base::set_new_height)
4492 (tui_data_window::set_new_height): New methods.
4493 (make_invisible_and_set_new_height): Call set_new_height method.
4494 * tui/tui-data.h (struct tui_win_info)
4495 (struct tui_source_window_base, struct tui_data_window)
4496 <set_new_height>: New method.
4497
1825f487
TT
44982019-06-25 Tom Tromey <tom@tromey.com>
4499
4500 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4501 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4502 tui_refresh_data_win.
4503 * tui/tui-win.c (tui_source_window_base::refresh_all): New
4504 method.
4505 (tui_refresh_all_win): Call the refresh_all method.
4506 (tui_set_focus): Likewise.
4507 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4508 (struct tui_source_window_base, struct tui_data_window) <refresh>:
4509 Likewise.
4510
ad54d15b
TT
45112019-06-25 Tom Tromey <tom@tromey.com>
4512
4513 * tui/tui-winsource.h (tui_refill_source_window)
4514 (tui_set_is_exec_point_at): Don't declare.
4515 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4516 (tui_source_window_base::refill): Rename from
4517 tui_refill_source_window.
4518 (tui_source_window_base::do_scroll_horizontal): Update.
4519 (tui_source_window_base::set_is_exec_point_at): Rename from
4520 tui_set_is_exec_point_at.
4521 (tui_update_all_breakpoint_info): Update.
4522 * tui/tui-stack.c (tui_show_frame_info): Update.
4523 * tui/tui-layout.c (show_data): Add cast.
4524 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4525 * tui/tui-data.h (struct tui_source_window_base) <refill,
4526 set_is_exec_point_at>: New methods.
4527 (tui_source_windows, tui_add_to_source_windows): Update types.
4528 (tui_add_to_source_windows): Remove redundant declaration.
4529 * tui/tui-data.c (source_windows): Store tui_source_window_base.
4530 (tui_source_windows): Change return type.
4531 (tui_clear_source_windows_detail): Update.
4532 (tui_add_to_source_windows): Change type of parameter.
4533 (tui_free_all_source_wins_content): Update.
4534
2042b506
TT
45352019-06-25 Tom Tromey <tom@tromey.com>
4536
4537 * tui/tui-wingeneral.c (tui_win_info::refresh)
4538 (tui_source_window_base::refresh): New methods.
4539 (tui_refresh_all): Call the refresh method.
4540 * tui/tui-data.h (struct tui_win_info)
4541 (struct tui_source_window_base) <refresh>: New method.
4542
56122977
TT
45432019-06-25 Tom Tromey <tom@tromey.com>
4544
4545 * tui/tui.h (tui_is_window_visible): Return bool.
4546 * tui/tui.c (tui_is_window_visible): Return bool.
4547 * tui/tui-wingeneral.c (tui_make_window, make_visible)
4548 (tui_make_visible, tui_make_invisible)
4549 (tui_win_info::make_visible)
4550 (tui_source_window_base::make_visible, make_all_visible)
4551 (tui_make_all_visible, tui_make_all_invisible): Update.
4552 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4553 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4554 bool.
4555 (struct tui_win_info, struct tui_source_window_base)
4556 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4557 * tui/tui-data.c (tui_init_generic_part): Update.
4558
cda37efb
TT
45592019-06-25 Tom Tromey <tom@tromey.com>
4560
4561 * tui/tui-wingeneral.c (tui_win_info::make_visible)
4562 (tui_source_window_base::make_visible): New methods.
4563 (make_all_visible): Make method call.
4564 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4565 (struct tui_source_window_base, struct tui_cmd_window): Override
4566 make_visible.
4567 (tui_win_is_source_type): Don't declare.
4568 * tui/tui-data.c (tui_win_is_source_type): Remove.
4569
6a0ee02c
TT
45702019-06-25 Tom Tromey <tom@tromey.com>
4571
4572 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4573 NULL check.
4574
63901aec
TT
45752019-06-25 Tom Tromey <tom@tromey.com>
4576
4577 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4578 Inline constructor. Add initializers for members.
4579 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4580 constructors; now inline in class.
4581
ceb13a13
TT
45822019-06-25 Tom Tromey <tom@tromey.com>
4583
4584 * tui/tui-regs.c (tui_show_registers): Update.
4585 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4586 bool.
4587 * tui/tui-data.c (tui_data_window::clear_detail)
4588 (tui_data_window): Update.
4589
238eb706
TT
45902019-06-25 Tom Tromey <tom@tromey.com>
4591
4592 * tui/tui-windata.c (tui_display_all_data)
4593 (tui_display_data_from_line, tui_display_data_from)
4594 (tui_check_data_values, tui_data_window::do_scroll_vertical):
4595 Update.
4596 * tui/tui-regs.c (tui_last_regs_line_no)
4597 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4598 (tui_show_registers, tui_show_register_group)
4599 (tui_display_registers_from, tui_display_reg_element_at_line)
4600 (tui_display_registers_from_line, tui_check_register_values)
4601 (tui_reg_next, tui_reg_prev): Update.
4602 * tui/tui-layout.c (tui_set_layout, show_data): Update.
4603 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
4604 tui_data_window.
4605 (struct tui_win_info) <detail>: Remove. Add new fields from
4606 tui_data_info.
4607 (TUI_DATA_WIN): Add cast.
4608 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4609 (~tui_data_window): Simplify.
4610
81491aa0
TT
46112019-06-25 Tom Tromey <tom@tromey.com>
4612
4613 * tui/tui-layout.c (show_source_disasm_command)
4614 (show_source_or_disasm_and_command): Update.
4615 * tui/tui-io.c (update_cmdwin_start_line)
4616 (tui_redisplay_readline): Update.
4617 * tui/tui-data.h (struct tui_command_info): Remove.
4618 (struct tui_win_info) <detail>: Remove command_info member.
4619 (struct tui_data_window) <start_line>: New member, from
4620 tui_command_info.
4621 (TUI_CMD_WIN): Add casts.
4622
e6e41501
TT
46232019-06-25 Tom Tromey <tom@tromey.com>
4624
4625 * tui/tui-winsource.c (tui_update_source_window)
4626 (tui_refill_source_window)
4627 (tui_source_window_base::do_scroll_horizontal)
4628 (tui_update_breakpoint_info, tui_set_exec_info_content)
4629 (tui_show_exec_info_content, tui_erase_exec_info_content)
4630 (tui_clear_exec_info_content): Update.
4631 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4632 Update.
4633 * tui/tui-win.c (make_invisible_and_set_new_height)
4634 (make_visible_with_new_height): Update.
4635 * tui/tui-source.c (tui_set_source_content)
4636 (tui_show_symtab_source): Update.
4637 * tui/tui-layout.c (extract_display_start_addr)
4638 (show_source_disasm_command, show_data)
4639 (make_source_or_disasm_window)
4640 (show_source_or_disasm_and_command): Update.
4641 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4642 (tui_disasm_window::do_scroll_vertical): Remove shadowing
4643 "gdbarch".
4644 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
4645 to tui_source_window_base.
4646 (struct tui_win_info) <detail>: Remove source_info member.
4647 (struct tui_source_window_base) <has_locator>: Inline.
4648 Move contents from tui_source_info; rename has_locator member to
4649 m_has_locator.
4650 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4651 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4652 header file.
4653 (tui_source_window_base::clear_detail, ~tui_source_window_base):
4654 Simplify.
4655 (tui_free_all_source_wins_content): Cast to
4656 tui_source_window_base.
4657
44f0e208
TT
46582019-06-25 Tom Tromey <tom@tromey.com>
4659
4660 * tui/tui-win.c (make_invisible_and_set_new_height)
4661 (make_visible_with_new_height): Call has_locator method.
4662 * tui/tui-layout.c (show_source_disasm_command, show_data)
4663 (show_source_or_disasm_and_command): Update for bool change.
4664 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4665 (tui_win_info) <has_locator>: New method.
4666 (struct tui_source_window_base) <has_locator>: New method.
4667 (tui_win_has_locator): Don't declare.
4668 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4669 from tui_win_has_locator.
4670 (tui_source_window_base): Use false, not FALSE.
4671
7778b912
TT
46722019-06-25 Tom Tromey <tom@tromey.com>
4673
4674 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4675 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4676 clear_detail method directly.
4677 (tui_clear_win_detail): Remove.
4678
f83d391c
TT
46792019-06-25 Tom Tromey <tom@tromey.com>
4680
4681 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4682 "this", not TUI_DISASM_WIN.
4683
13446e05
TT
46842019-06-25 Tom Tromey <tom@tromey.com>
4685
4686 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
4687 declare.
4688 * tui/tui-winsource.c
4689 (tui_source_window_base::do_scroll_horizontal): Rename from
4690 tui_horizontal_source_scroll.
4691 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4692 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4693 from tui_vertical_data_scroll.
4694 * tui/tui-win.h (tui_scroll): Don't declare.
4695 * tui/tui-win.c (tui_win_info::forward_scroll)
4696 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4697 (tui_win_info::right_scroll): Rename and update.
4698 (tui_scroll_forward_command, tui_scroll_backward_command)
4699 (tui_scroll_left_command, tui_scroll_right_command): Update.
4700 (tui_scroll): Remove.
4701 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4702 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4703 from tui_vertical_source_scroll.
4704 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4705 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4706 from tui_vertical_disassem_scroll.
4707 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4708 do_scroll_horizontal>: New methods.
4709 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4710 Likewise.
4711 (struct tui_source_window_base): Add do_scroll_horizontal.
4712 (struct tui_source_window, struct tui_disasm_window): Add
4713 do_scroll_vertical.
4714 (struct tui_data_window, struct tui_cmd_window): Add
4715 do_scroll_horizontal and do_scroll_vertical.
4716 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4717
5cf82909
TT
47182019-06-25 Tom Tromey <tom@tromey.com>
4719
4720 * tui/tui-data.h (struct tui_source_window_base): New struct.
4721 (struct tui_source_window): Derive from tui_source_window_base.
4722 (struct tui_disasm_window): New struct.
4723 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4724 from tui_source_window::clear_detail.
4725 (tui_source_window_base): Rename from tui_source_window.
4726 (~tui_source_window_base): Rename from ~tui_source_window.
4727 (tui_alloc_win_info): Create a tui_disasm_window.
4728
ee1d42d6
TT
47292019-06-25 Tom Tromey <tom@tromey.com>
4730
4731 * tui/tui-data.h (struct tui_source_window)
4732 (struct tui_data_window): Declare destructors.
4733 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4734 destructors.
4735 (tui_win_info): Simplify.
4736
b4eb2452
TT
47372019-06-25 Tom Tromey <tom@tromey.com>
4738
4739 * tui/tui-winsource.c (tui_display_main)
4740 (tui_update_source_windows_with_addr)
4741 (tui_update_all_breakpoint_info): Update.
4742 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4743 (new_height_ok, parse_scrolling_args): Update.
4744 * tui/tui-stack.c (tui_show_frame_info): Update.
4745 * tui/tui-data.h (struct tui_list): Remove.
4746 (tui_source_windows): Return a reference to a std::vector.
4747 * tui/tui-data.c (source_windows): Now a std::vector.
4748 (tui_source_windows): Change return type.
4749 (tui_clear_source_windows): Rewrite.
4750 (tui_clear_source_windows_detail, tui_add_to_source_windows)
4751 (tui_free_all_source_wins_content): Rewrite.
4752
8761a91b
TT
47532019-06-25 Tom Tromey <tom@tromey.com>
4754
4755 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4756 (struct tui_data_window, struct tui_cmd_window): Declare
4757 clear_detail method.
4758 * tui/tui-data.c (tui_source_window::clear_detail)
4759 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4760 methods.
4761 (tui_clear_win_detail): Simplify.
4762
0ed69eda
TT
47632019-06-25 Tom Tromey <tom@tromey.com>
4764
4765 * tui/tui-layout.c (make_source_window, make_disasm_window)
4766 (make_source_or_disasm_window): Remove win_info_ptr parameter.
4767 Return the new window.
4768 (show_source_disasm_command, show_data)
4769 (show_source_or_disasm_and_command): Update.
4770
82432e10
TT
47712019-06-25 Tom Tromey <tom@tromey.com>
4772
4773 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4774 parameter. Return the new window.
4775 (show_source_disasm_command): Update and remove NULL check.
4776 (show_source_or_disasm_and_command): Update.
4777
ec328aa5
TT
47782019-06-25 Tom Tromey <tom@tromey.com>
4779
4780 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4781
33b906ab
TT
47822019-06-25 Tom Tromey <tom@tromey.com>
4783
4784 * tui/tui-data.h (struct tui_win_info): Make constructor
4785 protected. Make destructor virtual. Add initializers.
4786 (tui_source_window, tui_data_window, tui_cmd_window): New
4787 classes.
4788 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
4789 constructor. Add "type" parameter.
4790 (tui_source_window, tui_data_window, tui_cmd_window): New
4791 constructors.
4792 (tui_alloc_win_info): Instantiate the appropriate subclass.
4793
e7e11af4
TT
47942019-06-25 Tom Tromey <tom@tromey.com>
4795
4796 * tui/tui-win.c (tui_resize_all): Use delete.
4797 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4798 destructor.
4799 (tui_free_window): Don't declare.
4800 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4801 Update.
4802
6792b55e
TT
48032019-06-25 Tom Tromey <tom@tromey.com>
4804
4805 * tui/tui-data.h (struct tui_win_info): Add constructor.
4806 * tui/tui-data.c (tui_alloc_win_info): Use new.
4807 (tui_free_window): Use delete.
4808
f95675e1
TT
48092019-06-22 Tom Tromey <tom@tromey.com>
4810
4811 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4812 declare.
4813 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4814
5bff081c
TT
48152019-06-22 Tom Tromey <tom@tromey.com>
4816
4817 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4818 declare.
4819 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4820
47e3f474
TV
48212019-06-22 Tom de Vries <tdevries@suse.de>
4822
4823 * dwarf2read.c (create_addrmap_from_aranges)
4824 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4825 instead of '%zu'.
4826
fd5866f6
SM
48272019-06-21 Simon Marchi <simon.marchi@efficios.com>
4828
4829 * dwarf2read.h (dwarf2_section_info_def): Remove.
4830 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4831 * dwarf2read.c (struct dwo_sections) <types>: Change type to
4832 std::vector<dwarf2_section_info>.
4833 (struct dwo_file) <~dwo_file>: Remove.
4834 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4835 types field.
4836 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4837 (dwarf2_read_debug_names): Likewise.
4838 (create_debug_types_hash_table): Change parameter type to
4839 array_view, adjust code accordingly.
4840 (dwarf2_locate_dwo_sections): Adjust to std::vector.
4841 (partial_die_info::fixup): Likewise.
4842 (determine_prefix): Likewise.
4843 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4844
fb1eb2f9
SM
48452019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4846
4847 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4848 gdb_bfd_ref_ptr.
4849 <~dwo_file>: Remove call to gdb_bfd_unref.
4850 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4851 gdb_bfd_ref_ptr::get.
4852
51ac9db5
SM
48532019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4854
4855 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4856 type to htab_up.
4857 * dwarf2read.c (struct dwo_file): Initialize fields.
4858 <~dwo_file>: New.
4859 (free_dwo_file): Remove, move content to ~dwo_file.
4860 (struct dwo_file_deleter): Remove.
4861 (dwo_file_up>: Remove custom deleter.
4862 (free_dwo_files): Remove.
4863 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4864 dwo_files.
4865 (process_skeletonless_type_units): Call unique_ptr::get.
4866 (allocate_dwo_file_hash_table): Add deleter to created hash
4867 table. Change return type to htab_up.
4868 (lookup_dwo_file_slot): Don't memset dwo_file, call
4869 unique_ptr::get.
4870 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4871 (create_dwo_unit_in_dwp_v2): Likewise.
4872 (open_and_init_dwo_file): Likewise.
4873 (free_dwo_file_from_slot): Remove.
4874
dc4ccb6f
SM
48752019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
4876
4877 * dwarf2read.h (struct dwarf2_section_info) <readin,
4878 is_virtual>: Change type to bool.
4879 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4880 true instead of 1.
4881
e6a1c5cb
TT
48822019-06-19 Tom Tromey <tom@tromey.com>
4883
4884 * tui/tui-data.h (tui_init_content_element): Don't declare.
4885
6f6ffbeb
TT
48862019-06-19 Tom Tromey <tom@tromey.com>
4887
4888 * tui/tui-data.h (tui_init_win_info): Don't declare.
4889
f23f598e
TV
48902019-06-19 Tom de Vries <tdevries@suse.de>
4891
4892 * dwarf2read.h (abstract_to_concrete): Change type to
4893 std::unordered_map<sect_offset, std::vector<sect_offset>,
4894 gdb::hash_enum<sect_offset>>.
4895
680e1bee
TT
48962019-06-19 Tom Tromey <tromey@adacore.com>
4897
4898 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4899 EVAL_AVOID_SIDE_EFFECTS specially.
4900
dcf37923
TT
49012019-06-19 Tom Tromey <tromey@adacore.com>
4902
4903 * source-cache.c (highlighter): New global.
4904 (source_cache::get_source_lines): Create a highlighter on demand.
4905
494986d5
AB
49062019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
4907
4908 * defs.h (deprecated_interactive_hook): Delete declaration.
4909 * interps.c (clear_interpreter_hooks): Remove use of
4910 deprecated_interactive_hook.
4911 * top.c (deprecated_interactive_hook): Delete definition.
4912 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4913
3360b6e7
TV
49142019-06-18 Tom de Vries <tdevries@suse.de>
4915
4916 PR gdb/24515
4917 * dwarf2read.h (abstract_to_concrete): Change type from
4918 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4919 std::unordered_map<sect_offset, std::vector<sect_offset>>.
4920 * dwarf2read.c (read_variable): Update.
4921 (dwarf2_fetch_die_loc_sect_off): Update.
4922
310b3441
TV
49232019-06-17 Tom de Vries <tdevries@suse.de>
4924
4925 PR gdb/24617
4926 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4927 accessing parent[parent_len - 1].
4928
ba9777be
PP
49292019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
4930
4931 PR gdb/24364
4932 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4933 call dtrace_process_dof with NULL dof.
4934
2b9f6e89
TV
49352019-06-16 Tom de Vries <tdevries@suse.de>
4936
4937 PR gdb/24445
4938 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4939
431b3ead
TT
49402019-06-16 Tom Tromey <tom@tromey.com>
4941
4942 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4943 (make_all_visible): Use address of member.
4944
d04b44a1
TT
49452019-06-16 Tom Tromey <tom@tromey.com>
4946
4947 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4948 (tui_free_window, free_content, free_content_elements): Remove
4949 unnecessary cast.
4950 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4951 cast.
4952 * tui/tui-regs.c (tui_show_register_group)
4953 (tui_display_registers_from, tui_display_reg_element_at_line):
4954 Remove unnecessary cast.
4955
bf5142e7
AB
49562019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
4957
4958 * linux-nat.c (normal_mask): Delete.
4959 (_initialize_linux_nat): Don't initialise normal_mask.
4960
c4973306
SM
49612019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
4962
4963 PR gdb/24445
4964 * dwarf-index-write.h (write_psymtabs_to_index): Add
4965 dwz_basename parameter.
4966 * dwarf-index-write.c (write_gdbindex): Move file writing to
4967 write_gdbindex_1. Change return type void.
4968 (assert_file_size): Move up, remove filename parameter.
4969 (write_gdbindex_1): New function.
4970 (write_debug_names): Change return type to void, call
4971 assert_file_size.
4972 (struct index_wip_file): New struct.
4973 (write_psymtabs_to_index): Add dwz_basename parameter. Move
4974 file logic to index_wip_file. Write index for dwz file if
4975 needed.
4976 (save_gdb_index_command): Pass basename of dwz file, if present.
4977 * dwarf-index-cache.c (index_cache::store): Obtain and pass
4978 build-id of dwz file, if present.
4979 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4980 (dwarf2_get_dwz_file): Likewise.
4981 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4982 (dwarf2_get_dwz_file): Likewise.
4983
395f9c91
TT
49842019-06-16 Tom Tromey <tom@tromey.com>
4985
4986 * coffread.c (process_coff_symbol): Use xstrdup.
4987 * value.c (create_internalvar): Use xstrdup.
4988
cafb3438
TT
49892019-06-16 Tom Tromey <tom@tromey.com>
4990
4991 * valops.c (value_cast, value_slice): Remove unnecessary cast.
4992 * breakpoint.c (stopin_command, stopat_command)
4993 (until_break_command, decode_location_default): Remove unnecessary
4994 cast.
4995 * utils.c (subset_compare): Remove unnecessary cast.
4996 * ada-lang.c (ada_update_initial_language): Remove unnecessary
4997 cast.
4998 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4999 cast.
5000 * infcmd.c (path_command): Remove unnecessary cast.
5001 * coffread.c (decode_type): Remove unnecessary cast.
5002 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5003 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5004 * tui/tui-stack.c (tui_show_locator_content)
5005 (tui_show_frame_info): Remove unnecessary cast.
5006 * tui/tui-win.c (tui_scroll_forward_command)
5007 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5008 (parse_scrolling_args): Remove unnecessary cast.
5009 * tui/tui-data.c (init_win_info, tui_del_window)
5010 (tui_free_window, tui_del_data_windows, tui_free_data_content)
5011 (free_content_elements): Remove unnecessary cast.
5012 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5013 unnecessary cast.
5014 * tui/tui-source.c (tui_set_source_content)
5015 (tui_vertical_source_scroll): Remove unnecessary cast.
5016 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5017 cast.
5018 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5019 * tui/tui-regs.c (tui_display_registers_from)
5020 (tui_display_register): Remove unnecessary cast.
5021 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5022 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5023 (make_visible): Remove unnecessary cast.
5024 * tui/tui-winsource.c (tui_erase_source_content)
5025 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5026 unnecessary cast.
5027 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5028 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5029 * stabsread.c (read_type, read_array_type, read_range_type):
5030 Remove unnecessary cast.
5031 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5032 (parse_symbol, parse_type, upgrade_type, parse_external)
5033 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5034 unnecessary cast.
5035 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5036
730ead81
TT
50372019-06-16 Tom Tromey <tom@tromey.com>
5038
5039 * tui/tui-data.c (tui_alloc_generic_win_info)
5040 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5041 checks.
5042
584a927c
AB
50432019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
5044 Andrew Burgess <andrew.burgess@embecosm.com>
5045
5046 * f-typeprint.c (f_print_type): Don't return early for not
5047 associated or not allocated types.
5048 (f_type_print_varspec_suffix): Add print_rank parameter and print
5049 ranks of array types in case they dangling.
5050 (f_type_print_base): Add print_rank parameter.
5051
30056ea0
AB
50522019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5053
5054 * NEWS: Mention new MI commands.
5055 * break-catch-throw.c (enum exception_event_kind): Move to
5056 breakpoint.h.
5057 (print_mention_exception_catchpoint): Output text as a single
5058 message.
5059 (catch_exception_command_1): Rename to...
5060 (catch_exception_event): ...this, make non-static, update header
5061 command, and change some parameter types.
5062 (catch_catch_command): Update for changes to
5063 catch_exception_command_1.
5064 (catch_throw_command): Likewise.
5065 (catch_rethrow_command): Likewise.
5066 * breakpoint.c (enum exception_event_kind): Delete.
5067 * breakpoint.h (enum exception_event_kind): Moved here from
5068 break-catch-throw.c.
5069 (catch_exception_event): Declare.
5070 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5071 (mi_cmd_catch_throw): New function.
5072 (mi_cmd_catch_rethrow): New function.
5073 (mi_cmd_catch_catch): New function.
5074 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5075 'catch-catch' entries.
5076 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5077 (mi_cmd_catch_rethrow): Declare.
5078 (mi_cmd_catch_catch): Declare.
5079
ec8e2b6d
AB
50802019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5081
5082 * annotate.c (annotate_source_line): Change return type to void,
5083 update implementation to match.
5084 * annotate.h (annotate_source_line): Change return type to void,
5085 update header comment.
5086 * stack.c (print_frame_info): Don't change what frame information
5087 is printed based on whether annotations are on or not.
5088
0d3abd8c
AB
50892019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5090
5091 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5092 (annotate_source): Make static.
5093 (annotate_source_line): Moved from source.c and renamed from
5094 identify_source_line. Update the return type.
5095 * annotate.h (annotate_source): Delete declaration.
5096 (annotate_source_line): Declaration moved from source.h, and
5097 renamed from identify_source_line. Return type updated.
5098 * source.c (identify_source_line): Moved to annotate.c and renamed
5099 to annotate_source_line.
5100 (info_line_command): Remove check of annotation_level.
5101 * source.h (identify_source_line): Move declaration to annotate.h
5102 and rename to annotate_source_line.
5103 * stack.c: Add 'annotate.h' include.
5104 (print_frame_info): Remove check of annotation_level before
5105 calling annotate_source_line.
5106
00df30ae
AB
51072019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5108
5109 * source-cache.c (source_cache::get_plain_source_lines): Use
5110 open_source_file_with_line_charpos instead of just
5111 open_source_file, remove call to find_source_lines.
5112 (source_cache::get_source_lines): Likewise.
5113 * source.c (find_source_lines): Make static.
5114 (get_filename_and_charpos): Renamed into...
5115 (open_source_file_with_line_charpos): ..this along with changes to
5116 return a scoped_fd, and some other minor clean ups.
5117 (identify_source_line): Use open_source_file_with_line_charpos.
5118 (search_command_helper): Use open_source_file_with_line_charpos
5119 instead of just open_source_file, remove call to
5120 find_source_lines.
5121 * source.h (open_source_file_with_line_charpos): Declare new
5122 function.
5123 (find_source_lines): Delete declaration.
5124
afda45a2
AB
51252019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
5126
5127 * source.c (get_filename_and_charpos): Remove fullname
5128 parameter.
5129 (identify_source_line): Update call to get_filename_and_charpos.
5130
0735b091
TT
51312019-06-14 Tom Tromey <tromey@adacore.com>
5132
5133 PR gdb/24502:
5134 * ui-style.h (skip_ansi_escape): Update comment.
5135 * ui-file.h (class no_terminal_escape_file): New class.
5136 * ui-file.c (no_terminal_escape_file::write)
5137 (no_terminal_escape_file::puts): New methods.
5138 * cli/cli-logging.c (handle_redirections): Use
5139 no_terminal_escape_file.
5140
52ce35e2
TT
51412019-06-14 Tom Tromey <tromey@adacore.com>
5142
5143 * NEWS: Move convenience variable news above Python news.
5144
73cc7272
TT
51452019-06-14 Tom Tromey <tom@tromey.com>
5146
5147 * gnulib: Move directory to top-level.
5148 * configure.ac: Don't configure gnulib.
5149 * configure: Rebuild.
5150 * common/common-defs.h: Use new path to gnulib.
5151 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5152 (GNULIB_H): Remove.
5153 (INCGNU): Look in new gnulib location.
5154 (HFILES_NO_SRCDIR): Remove gnulib files.
5155 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5156 (generated_files): Remove GNULIB_H.
5157 ($(LIBGNU), all-lib): Remove targets.
5158 (distclean): Don't mention GNULIB_BUILDDIR.
5159 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5160
f5686554
TT
51612019-06-14 Tom Tromey <tromey@adacore.com>
5162
5163 * symfile.c (add_symbol_file_command): Remove obsolete comment.
5164 Warn if symbol file does not provide any symbols.
5165
a0c1ffed
TT
51662019-06-14 Tom Tromey <tromey@adacore.com>
5167
5168 * source.c (find_and_open_source): Respect basenames_may_differ.
5169
7c39e397
AB
51702019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
5171
5172 * annotate.c (annotate_breakpoints_invalid): Make use of
5173 scoped_restore_terminal_state.
5174 (annotate_frames_invalid): Likewise.
5175
f411722c
TT
51762019-06-14 Tom Tromey <tromey@adacore.com>
5177
5178 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5179 allow assignment to an internalvar.
5180
4268ec18
TT
51812019-06-14 Tom Tromey <tromey@adacore.com>
5182
5183 * ada-lex.l: Allow "_" in attribute names.
5184
abdb711e
TT
51852019-06-14 Tom Tromey <tromey@adacore.com>
5186
5187 PR gdb/24653:
5188 * regcache.c (registers_changed): Don't call alloca.
5189 * top.c (execute_command): Don't call alloca.
5190
4c048731
PA
51912019-06-13 Pedro Alves <palves@redhat.com>
5192
5193 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5194 'expression'. When parsing an expression, error out if there's
5195 junk after "unlimited".
5196 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5197 (do_set_command): Adjust calls to is_unlimited_literal.
5198
66eb1ed3
PA
51992019-06-13 Pedro Alves <palves@redhat.com>
5200
5201 * compile/compile.c (make_compile_options_def_group): Add braces
5202 around array_view initializer.
5203 * thread.c (make_thread_apply_all_options_def_group)
5204 (make_thread_apply_all_options_def_group): Likewise.
5205
3345721a
PA
52062019-06-13 Pedro Alves <palves@redhat.com>
5207
5208 * NEWS (New commands): Mention "maint test-options
5209 require-delimiter", "maint test-options unknown-is-error", "maint
5210 test-options unknown-is-operand" and "maint show
5211 test-options-completion-result".
5212 (New command options, command completion): New section.
5213 (Completion improvements): New section.
5214 Mention that you can abbreviate "unlimited".
5215
6206060d
PA
52162019-06-13 Pedro Alves <palves@redhat.com>
5217
5218 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5219 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5220 * unittests/cli-utils-selftests.c (test_parse_flags)
5221 (test_parse_flags_qcs): Delete.
5222 (test_cli_utils): Don't call deleted functions.
5223
6665660a
PA
52242019-06-13 Pedro Alves <palves@redhat.com>
5225
5226 * thread.c: Include "cli/cli-option.h".
5227 (tp_array_compar_ascending): Global.
5228 (tp_array_compar): Delete function.
5229 (tp_array_compar_ascending, tp_array_compar_descending): New
5230 functions.
5231 (ascending_option_def, qcs_flag_option_def)
5232 (thr_qcs_flags_option_defs)
5233 (make_thread_apply_all_options_def_group)
5234 (make_thread_apply_options_def_group): New.
5235 (thread_apply_all_command): Use gdb::option::process_options.
5236 (thread_apply_command_completer)
5237 (thread_apply_all_command_completer): New.
5238 (thread_apply_command): Use gdb::option::process_options.
5239 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5240 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
5241 to generate help text of "thread apply". Adjust "taas"'s help.
5242 * tid-parse.c (tid_range_parser::in_thread_range): New method.
5243 * tid-parse.h (tid_range_parser::in_thread_range): New method.
5244
f7e13587
PA
52452019-06-13 Pedro Alves <palves@redhat.com>
5246
5247 * thread.c (thread_apply_command): Check for invalid TID with
5248 isdigit instead of !isalpha.
5249
5d707134
PA
52502019-06-13 Pedro Alves <palves@redhat.com>
5251
5252 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5253 (validate_flags_qcs): New.
5254 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5255 (validate_flags_qcs): Declare.
5256 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5257 (make_frame_apply_options_def_group): New.
5258 (frame_apply_command_count): Process options with
5259 gdb::option::process_options.
5260 (frame_apply_completer): New.
5261 (frame_apply_level_completer, frame_apply_all_completer)
5262 (frame_apply_completer): New.
5263 (_initialize_stack): Update help of "frame apply", "frame apply
5264 level", "frame apply all" and "faas" to mention supported options
5265 and install command completers.
5266 * stack.h (frame_apply_all_completer): Declare.
5267 * thread.c: Include "stack.h".
5268 (tfaas_command): Add "--".
5269 (_initialize_thread): Update help "tfaas" to mention supported
5270 options and install command completer.
5271
272d4594
PA
52722019-06-13 Pedro Alves <palves@redhat.com>
5273
5274 * completer.c (complete_nested_command_line): New.
5275 (gdb_completion_word_break_characters_throw): Add assertion.
5276 * completer.h (complete_nested_command_line): Declare.
5277
90a1ef87
PA
52782019-06-13 Pedro Alves <palves@redhat.com>
5279
5280 * stack.c (parse_backtrace_qualifiers): New.
5281 (backtrace_command): Use it.
5282 (backtrace_command_completer): Complete on qualifiers.
5283
d4c16835
PA
52842019-06-13 Pedro Alves <palves@redhat.com>
5285
5286 * frame.c: Include "cli/cli-option.h.
5287 (user_set_backtrace_options): New.
5288 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5289 Delete.
5290 (get_prev_frame): Adjust.
5291 (boolean_option_def, uinteger_option_def)
5292 (set_backtrace_option_defs): New.
5293 (_initialize_frame): Adjust and use
5294 gdb::option::add_setshow_cmds_for_options to install "set
5295 backtrace past-main" and "set backtrace past-entry".
5296 * frame.h: Include "cli/cli-option.h".
5297 (struct frame_print_options): Forward declare.
5298 (print_frame_arguments_all, print_frame_arguments_scalars)
5299 (print_frame_arguments_none): Declare.
5300 (print_entry_values): Delete declaration.
5301 (struct frame_print_options, user_frame_print_options): New.
5302 (struct set_backtrace_options): New.
5303 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5304 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5305 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5306 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5307 (list_args_or_locals): Add frame_print_options parameter.
5308 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5309 * python/py-framefilter.c (enumerate_args): Pass down
5310 USER_FRAME_PRINT_OPTIONS.
5311 * stack.c: Include "cli/cli-option.h".
5312 (print_frame_arguments_all, print_frame_arguments_scalars)
5313 (print_frame_arguments_none): Declare.
5314 (print_raw_frame_arguments, print_entry_values): Delete.
5315 (user_frame_print_options): New.
5316 (boolean_option_def, enum_option_def, frame_print_option_defs):
5317 New.
5318 (struct backtrace_cmd_options): New.
5319 (bt_flag_option_def): New.
5320 (backtrace_command_option_defs): New.
5321 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5322 (print_frame_arg, read_frame_arg, print_frame_args)
5323 (print_frame_info, print_frame): Add frame_print_options parameter
5324 and use it.
5325 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5326 (backtrace_command_1): Add frame_print_options and
5327 backtrace_cmd_options parameters and use them.
5328 (make_backtrace_options_def_group): New.
5329 (backtrace_command): Process command options with
5330 gdb::option::process_options.
5331 (backtrace_command_completer): New.
5332 (_initialize_stack): Extend "backtrace"'s help to mention
5333 supported options. Install completer for "backtrace".
5334 Install some settings commands with add_setshow_cmds_for_options.
5335
2daf894e
PA
53362019-06-13 Pedro Alves <palves@redhat.com>
5337
5338 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5339 and that "set/show print raw frame-arguments" are now deprecated.
5340
5341 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5342 command.
5343 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5344 * stack.c (_initialize_stack): Install "set/show print
5345 raw-frame-arguments", and deprecate "set/show print raw
5346 frame-arguments".
5347 * valprint.c (_initialize_valprint): Deprecate "set/show print
5348 raw".
5349
e6ed716c
PA
53502019-06-13 Pedro Alves <palves@redhat.com>
5351
5352 * compile/compile.c (struct compile_options): New.
5353 (compile_flag_option_def, compile_command_option_defs)
5354 (make_compile_options_def_group): New.
5355 (compile_file_command): Handle options with
5356 gdb::option::process_options.
5357 (compile_file_command_completer): New function.
5358 (compile_code_command): Handle options with
5359 gdb::option::process_options.
5360 (compile_code_command_completer): New function.
5361 (_initialize_compiler): Install completers for "compile code" and
5362 "compile file". Mention available options in "compile code" and
5363 "compile code"'s help.
5364 * completer.c (advance_to_completion_word): New, factored out from
5365 ...
5366 (advance_to_expression_complete_word_point): ... this.
5367 (advance_to_filename_complete_word_point): New.
5368 * completer.h (advance_to_filename_complete_word_point): New
5369 declaration.
5370
7d8062de
PA
53712019-06-13 Pedro Alves <palves@redhat.com>
5372
5373 * compile/compile.c: Include "cli/cli-option.h".
5374 (compile_print_value): Scope data pointer is now a
5375 value_print_options pointer; adjust.
5376 (compile_print_command): Process options. Scope data pointer is
5377 now a value_print_options pointer; adjust.
5378 (_initialize_compile): Update "compile print"'s help to include
5379 supported options. Install a completer for "compile print".
5380 * cp-valprint.c (show_vtblprint, show_objectprint)
5381 (show_static_field_print): Delete.
5382 (_initialize_cp_valprint): Don't install "set print
5383 static-members", "set print vtbl", "set print object" here.
5384 * printcmd.c: Include "cli/cli-option.h" and
5385 "common/gdb_optional.h".
5386 (print_command_parse_format): Rework to fill in a
5387 value_print_options instead of a format_data.
5388 (print_value): Change parameter type from format_data pointer to
5389 value_print_options reference. Adjust.
5390 (print_command_1): Process options. Adjust to pass down a
5391 value_print_options.
5392 (print_command_completer): New.
5393 (_initialize_printcmd): Install print_command_completer as
5394 handle_brkchars completer for the "print" command. Update
5395 "print"'s help to include supported options.
5396 * valprint.c: Include "cli/cli-option.h".
5397 (show_vtblprint, show_objectprint, show_static_field_print): Moved
5398 here from cp-valprint.c.
5399 (boolean_option_def, uinteger_option_def)
5400 (value_print_option_defs, make_value_print_options_def_group):
5401 New. Use gdb::option::add_setshow_cmds_for_options to install
5402 "set print elements", "set print null-stop", "set print repeats",
5403 "set print pretty", "set print union", "set print array", "set
5404 print address", "set print symbol", "set print array-indexes".
5405 * valprint.h: Include <string> and "cli/cli-option.h".
5406 (make_value_print_options_def_group): Declare.
5407 (print_value): Change parameter type from format_data pointer to
5408 value_print_options reference.
5409 (print_command_completer): Declare.
5410
9d0faba9
PA
54112019-06-13 Pedro Alves <palves@redhat.com>
5412
5413 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5414 (COMMON_SFILES): Add maint-test-settings.c.
5415 * cli/cli-decode.c (boolean_enums): New global, factored out from
5416 ...
5417 (add_setshow_boolean_cmd): ... here.
5418 * cli/cli-decode.h (boolean_enums): Declare.
5419 * cli/cli-option.c: New file.
5420 * cli/cli-option.h: New file.
5421 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5422 factored out from ...
5423 (parse_cli_boolean_value(const char *)): ... this.
5424 (is_unlimited_literal): Change parameter type to pointer to
5425 pointer. Adjust and advance ARG pointer.
5426 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5427 (parse_cli_var_enum): New, factored out from ...
5428 (do_set_command): ... this. Adjust.
5429 * cli/cli-setshow.h (parse_cli_boolean_value)
5430 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5431 (parse_cli_var_enum): Declare.
5432 * cli/cli-utils.c: Include "cli/cli-option.h".
5433 (get_ulongest): New.
5434 * cli/cli-utils.h (get_ulongest): Declare.
5435 (check_for_argument): New overloads.
5436 * maint-test-options.c: New file.
5437
2c722807
PA
54382019-06-13 Pedro Alves <palves@redhat.com>
5439
5440 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5441 parse a range if "-" is at the end of the string.
5442
dee7b4c8
PA
54432019-06-13 Pedro Alves <palves@redhat.com>
5444
5445 * cli/cli-setshow.c (parse_auto_binary_operation)
5446 (parse_cli_boolean_value): Don't allow "o".
5447
dca0f6c0
PA
54482019-06-13 Pedro Alves <palves@redhat.com>
5449
5450 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5451 * NEWS: Mention maint test-settings KIND.
5452 * maint-test-settings.c: New file.
5453
597bf39d
PA
54542019-06-13 Pedro Alves <palves@redhat.com>
5455
5456 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5457 completer.
5458 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5459 "set" completers.
5460
48c410fb
PA
54612019-06-13 Pedro Alves <palves@redhat.com>
5462
5463 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5464 after item.
5465
93bcb043
PA
54662019-06-13 Pedro Alves <palves@redhat.com>
5467
5468 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5469
cbba3ecd
PA
54702019-06-13 Pedro Alves <palves@redhat.com>
5471
5472 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5473 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5474 call.
5475 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5476 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5477 calls.
5478 (check_for_argument): Skip spaces after argument.
5479
b9a3f842
PA
54802019-06-13 Pedro Alves <palves@redhat.com>
5481
5482 * thread.c (thread_apply_command): Adjust TID parsing.
5483 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5484 detected before end of string.
5485 (tid_is_in_list): Error out if LIST is invalid.
5486
3844e605
PA
54872019-06-13 Pedro Alves <palves@redhat.com>
5488
5489 * completer.c (complete_line_internal_1): Rewind completion word
5490 point.
5491 (completion_tracker::advance_custom_word_point_by): Change
5492 parameter type to int.
5493 * completer.h (completion_tracker::advance_custom_word_point_by):
5494 Likewise.
5495
00b56dbe
PA
54962019-06-13 Pedro Alves <palves@redhat.com>
5497
5498 * completer.c (advance_to_completion_word): Handle delimiters.
5499
d106773e
PA
55002019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
5501
5502 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5503
08f10e02
TT
55042019-06-11 Tom Tromey <tom@tromey.com>
5505
5506 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5507 (xmalloc_failed): Move to alloc.c.
5508 * alloc.c: New file.
5509 * Makefile.in (COMMON_SFILES): Add alloc.c.
5510
1c7fe951
TT
55112019-06-11 Tom Tromey <tom@tromey.com>
5512
5513 * nat/linux-waitpid.c: Don't include server.h.
5514 (linux_debug): Remove.
5515 (my_waitpid): Update.
5516
89549d7f
TT
55172019-06-11 Tom Tromey <tromey@adacore.com>
5518
5519 * infcall.c (_initialize_infcall): Remove trailing newline from
5520 help.
5521 * user-regs.c (_initialize_user_regs): Remove trailing newline
5522 from help.
5523 * typeprint.c (_initialize_typeprint): Remove trailing newline
5524 from help.
5525 * reverse.c (_initialize_reverse): Remove trailing newlines from
5526 help.
5527 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5528 from help.
5529 * language.c (add_set_language_command): Remove trailing newline
5530 from help.
5531 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5532 help.
5533 * disasm.c (_initialize_disasm): Remove trailing newline from
5534 help.
5535 * top.c (init_main): Remove trailing newline from help.
5536 * interps.c (_initialize_interpreter): Remove trailing newline
5537 from help.
5538 * btrace.c (_initialize_btrace): Remove trailing newlines from
5539 help.
5540 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5541 from help.
5542 * python/python.c (_initialize_python): Remove trailing newline
5543 from help.
5544 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5545 help.
5546 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5547 from help. Reformat some text.
5548 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5549 from help.
5550 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5551 newline from help.
5552
86108c13
TT
55532019-06-11 Tom Tromey <tromey@adacore.com>
5554
5555 * darwin-nat.c (darwin_decode_exception_message)
5556 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5557
a7067863
AB
55582019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
5559
5560 * valops.c (value_slice): Check for not allocated or not
5561 associated values.
5562
9ab08412
TV
55632019-06-10 Tom de Vries <tdevries@suse.de>
5564
5565 PR gdb/24618
5566 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5567 sure an empty slot (defined by a 32-bit zero pair) is recognized as
5568 invalid.
5569
f19e22e9
TV
55702019-06-10 Tom de Vries <tdevries@suse.de>
5571
5572 PR gdb/24611
5573 * linespec.c (linespec_lexer_lex_string): Remove incorrect
5574 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
5575
e99f9db0
TV
55762019-06-10 Tom de Vries <tdevries@suse.de>
5577
5578 PR symtab/24545
5579 * symtab.c (struct demangled_name_entry): Add language field.
5580 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
5581 static minimal symbol". Set and use language field.
5582
9bf7038b
TT
55832019-06-10 Tom Tromey <tromey@adacore.com>
5584
5585 * ada-lang.c (_initialize_ada_language): Update help text.
5586
422186a9
TT
55872019-06-10 Tom Tromey <tromey@adacore.com>
5588
5589 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5590 with a newline.
5591 * guile/guile.c (handle_boot_error): Don't end warning with a
5592 newline.
5593 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5594 warning with a newline.
5595 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5596 newline.
5597 (s12z_frame_cache): Likewise.
5598 * dwarf-index-cache.c (index_cache::store): Don't end warning with
5599 a newline.
5600 * solib-svr4.c (disable_probes_interface): Don't end warning with
5601 a newline.
5602 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5603 newline.
5604 * python/python.c (do_finish_initialization): Don't end warning
5605 with a newline.
5606
25ce02ee
TT
56072019-06-10 Tom Tromey <tom@tromey.com>
5608
5609 * python/py-breakpoint.c (gdbpy_breakpoint_created)
5610 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5611 gdbpy_enter.
5612
caa429d8
TT
56132019-06-10 Tom Tromey <tromey@adacore.com>
5614
5615 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5616 data.
5617 (elf_new_init): Don't call stabsread_new_init.
5618 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5619 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
5620 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5621
81873cc8
TV
56222019-06-10 Tom de Vries <tdevries@suse.de>
5623
5624 PR symtab/16264
5625 PR symtab/24517
5626 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5627
4fa0265e
РИ
56282019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
5629
5630 * source.c (find_and_open_source): Also rewrite relative file
5631 names.
5632
1a3da2cd
AB
56332019-04-26 Amos Bird <amosbird@gmail.com>
5634
5635 * annotate.c (annotate_thread_exited): Add "thread-exited"
5636 annotation.
5637
3847a7bf
TT
56382019-06-06 Tom Tromey <tromey@adacore.com>
5639
5640 * maint.h (class scoped_command_stats): Use
5641 DISABLE_COPY_AND_ASSIGN.
5642 <print_time>: New method.
5643 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5644 print_time.
5645 (scoped_command_stats::print_time): New method.
5646
312617a3
AB
56472019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
5648
5649 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5650 instructions of lengths 6 or 8 bytes.
5651
b02f78f9
PA
56522019-06-04 Pedro Alves <palves@redhat.com>
5653
5654 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5655
5656 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5657 * breakpoint.c (condition_completer): Likewise.
5658 * cli/cli-dump.c (scan_expression): Likewise.
5659 * common/filestuff.c (mkdir_recursive): Likewise.
5660 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5661 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5662 (gdb_abspath): Likewise.
5663 * compile/compile-cplus-types.c
5664 (compile_cplus_instance::decl_name): Likewise.
5665 * completer.c (complete_explicit_location):
5666 (signal_completer, reg_or_group_completer_1): Likewise.
5667 * cp-support.c (cp_remove_params_if_any): Likewise.
5668 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5669 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5670 * infcmd.c (strip_bg_char): Likewise.
5671 * linespec.c (copy_token_string): Likewise.
5672 * mi/mi-main.c (output_cores): Likewise.
5673 * psymtab.c (psymtab_search_name):
5674 * symfile.c (test_set_ext_lang_command): Likewise.
5675 * target.c (target_fileio_read_stralloc): Likewise.
5676 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5677 * value.c (complete_internalvar): Likewise.
5678
e1f2e1a2
CB
56792019-06-04 Christian Biesinger <cbiesinger@google.com>
5680
5681 Add objfile property to gdb.Type.
d3238f7d
PA
5682 * NEWS: Mention Python API addition.
5683 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 5684
e664d728
PW
56852019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5686
5687 * NEWS: Mention the new set|show style [title|highlight].
5688 Mention changes to "show style", "help" and "apropos".
5689
66d8c862
PW
56902019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5691
5692 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5693 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
5694 instead of print_help_for_command.
5695 (print_doc_of_command): New function.
5696 (help_list): Add 'apropos -v word' suggestion.
5697 (print_help_for_command): Style the command name using title style.
5698 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5699 (_initialize_cli_cmds): Describe -v in apropos_command help.
5700
9303eb2f
PW
57012019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5702
5703 * cli/cli-style.h (cli_style_option): Add name in constructor,
5704 add m_name class member, add constructor with intensity,
5705 add name class function.
5706 (cli_style_option::add_setshow_commands): Remove name argument.
5707 (highlight_style, title_style): New styles.
5708 * cli/cli-style.c (do_show): New function that shows a style
5709 characteristic styling the style name with itself.
5710 (set_style_name): New function.
5711 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5712 Update all callers according to the changes in cli/cli-style.h.
5713 * utils.h (fputs_highlighted): New function.
5714 * utils.c (fputs_highlighted): Likewise.
5715
e2c52041
PW
57162019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5717
5718 * NEWS: Mention new pipe command and new convenience variables.
5719
947d3946
PW
57202019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5721
5722 * cli/cli-cmds.c (pipe_command): New function.
5723 (_initialize_cli_cmds): Call add_com for pipe_command.
5724 Define | as an alias for pipe.
5725 (exit_status_set_internal_vars): New function.
5726 (shell_escape): Call exit_status_set_internal_vars.
5727 cli/cli-decode.c (find_command_name_length): Recognize | as
5728 a single character command.
5729
b8fd0918
PW
57302019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5731
5732 * gdbcmd.h (execute_command_to_ui_file): New declaration.
5733 top.c (execute_command_to_ui_file): New function, mostly a copy
5734 of execute_command_to_string.
5735 (execute_command_to_string): Implement by calling
5736 execute_command_to_ui_file.
5737
68bb5386
PW
57382019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5739
5740 * top.h (saved_command_line): Remove declaration.
5741 * top.c (previous_saved_command_line, previous_repeat_arguments):
5742 New variables.
5743 (saved_command_line): Make static, define together with other
5744 'repeat variables'.
5745 (dont_repeat): Clear repeat_arguments.
5746 (repeat_previous, get_saved_command_line, save_command_line):
5747 New functions.
5748 (gdb_init): Initialize saved_command_line
5749 and previous_saved_command_line.
5750 * main.c (captured_main_1): Remove saved_command_line initialization.
5751 * event-top.c (handle_line_of_input): Update to use
5752 the new 'repeat' related functions instead of direct access to
5753 saved_command_line.
5754 * command.h (repeat_previous, get_saved_command_line,
5755 save_command_line): New declarations.
5756 (dont_repeat): Add comment.
5757
bfcdb852
TT
57582019-05-30 Tom Tromey <tromey@adacore.com>
5759
5760 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5761 Fix comment.
5762 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5763
0ef209f2
JV
57642019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
5765
5766 PR cli/24587
5767 * completer.c (complete): Initialize variable word.
5768
955b06fa
SDJ
57692019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
5770
5771 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5772 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5773 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5774 'body' is NULL to the outter 'if', protecting the '!is_define'
5775 situation as well.
5776
fa9c3fa0
TT
57772019-05-29 Tom Tromey <tromey@adacore.com>
5778
5779 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5780 (dwarf_unknown): New function.
5781 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5782 (dwarf_type_encoding_name): Use dwarf_unknown.
5783
4330d61d
TT
57842019-05-29 Tom Tromey <tromey@adacore.com>
5785
5786 PR c++/20020:
5787 * cp-valprint.c (cp_print_value_fields): Call
5788 cp_print_static_field inside "try".
5789
33a6bc35
TT
57902019-05-29 Tom Tromey <tromey@adacore.com>
5791
5792 * inflow.c (struct terminal_info): Add default operator=.
5793 * configure: Rebuild.
5794 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5795 -Wdeprecated-copy-dtor, -Wredundant-move.
5796
000439d5
TT
57972019-05-29 Tom Tromey <tromey@adacore.com>
5798
5799 * NEWS: Add entry.
5800 * infcmd.c (print_return_value_1): Handle finish_print
5801 option.
5802 (show_print_finish): New function.
5803 (_initialize_infcmd): Add "set/show print finish" commands.
5804 * valprint.c (user_print_options): Initialize new member.
5805 * valprint.h (struct value_print_options) <finish_print>: New
5806 member.
5807
c0e70c62
TT
58082019-05-28 Tom Tromey <tromey@adacore.com>
5809
5810 * ada-lang.c (ada_remove_Xbn_suffix)
5811 (find_old_style_renaming_symbol)
5812 (parse_old_style_renaming): Remove.
5813 (ada_find_renaming_symbol): Don't call
5814 find_old_style_renaming_symbol.
5815 (ada_is_renaming_symbol): Rename from
5816 ada_find_renaming_symbol. Remove "block" parameter. Return
5817 bool. Now static.
5818 (ada_read_var_value): Update and simplify.
5819 * ada-exp.y (write_var_or_type): Remove old code.
5820
766f8836
AH
58212019-05-28 Alan Hayward <alan.hayward@arm.com>
5822
5823 * event-top.c: Remove include comment.
5824 * inflow.c (class scoped_ignore_sigttou): Move from here...
5825 * inflow.h (class scoped_ignore_sigttou): ...to here.
5826 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5827 * top.c: Remove include comment.
5828
eb41253a
TT
58292019-05-27 Tom Tromey <tom@tromey.com>
5830
5831 * NEWS: Fix typo.
5832
4ca51187
TT
58332019-05-22 Tom Tromey <tromey@adacore.com>
5834
5835 * target.c (target_follow_exec): Constify parameter.
5836 * target-delegates.c: Rebuild.
5837 * remote.c (remote_target::follow_exec): Constify parameter.
5838 * infrun.c (follow_exec): Constify parameter.
5839 * target.h (struct target_ops) <follow_exec>: Constify parameter.
5840 (target_follow_exec): Likewise.
5841
8fca4da0
AH
58422019-05-22 Alan Hayward <alan.hayward@arm.com>
5843
5844 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5845 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5846
b7060614
AH
58472019-05-22 Alan Hayward <alan.hayward@arm.com>
5848
5849 * NEWS: Add debugredirect and testsuite sections.
5850
0a5954bd
SC
58512019-05-22 Simon Cook <simon.cook@embecosm.com>
5852
5853 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5854 target descriptions using exclusively floating point register name
5855 aliases.
5856
dc42e902
AB
58572019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
5858
5859 PR gdb/18644:
5860 * f-lang.c (build_fortran_types): Handle the case where
5861 gdbarch_floatformat_for_type returns a nullptr.
5862
fb7806c7
TV
58632019-05-21 Tom de Vries <tdevries@suse.de>
5864
5865 PR cli/24587
5866 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5867
34d11c68
AB
58682019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5869
5870 PR gdb/18644:
5871 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5872 16-byte floats.
5873 * i386-tdep.c (i386_floatformat_for_type): Use
5874 floatformats_ia64_quad for the 16-byte floating point component
5875 within a fortran 32-byte complex number.
5876
122cf0f2
AB
58772019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
5878
5879 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5880 delete default constructor.
5881 (find_partial_die): Update to return const struct.
5882 (partial_die_parent_scope): Move variable declaration into scope
5883 of its use and change its type to auto.
5884 (guess_partial_die_structure_name): Likewise.
5885 (partial_die_info::fixup): Likewise.
5886
33d0e35a
TT
58872019-05-17 Tom Tromey <tromey@adacore.com>
5888
5889 * source.c (find_and_open_source): Remove cast.
5890
a45575b0
TT
58912019-05-17 Tom Tromey <tromey@adacore.com>
5892
5893 * annotate.c (annotate_source): Make "filename" const.
5894 * annotate.h (annotate_source): Use const.
5895
81f47ac2
AH
58962019-05-17 Alan Hayward <alan.hayward@arm.com>
5897
5898 * disasm.c (set_disassembler_options): Send errors to stderr.
5899
ca1285d1
AH
59002019-05-17 Alan Hayward <alan.hayward@arm.com>
5901
5902 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5903 (cli_interp_base::set_logging): Check debug_redirect.
5904 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5905 * cli/cli-logging.c (debug_redirect): Add static variable.
5906 (pop_output_files): Add default param.
5907 (handle_redirections): Print debug setting.
5908 (show_logging_command): Likewise.
5909 (_initialize_cli_logging): Add debugredirect command.
5910 * interps.c (current_interp_set_logging): Add debug_redirect
5911 parameter.
5912 * interps.h (set_logging): Add debug_redirect parameter.
5913 (current_interp_set_logging): Likewise.
5914 * mi/mi-common.h: Likewise.
5915 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5916
59172019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
5918 Tom Tromey <tromey@adacore.com>
5919
5920 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5921 directly.
5922 * cli/cli-interp.h (make_logging_output): Remove declaration.
5923 * cli/cli-logging.c (make_logging_output): Remove function.
5924 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5925 directly.
5926 * ui-file.c (tee_file::tee_file): Remove bools.
5927 (tee_file::~tee_file): Remove deletes.
5928 * ui-file.h (tee_file): Remove bools.
5929
26648588
JV
59302019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
5931
5932 * mi/mi-cmds.h (mi_cmd_complete): New function.
5933 * mi/mi-main.c (mi_cmd_complete): Likewise.
5934 * mi/mi-cmds.c: Define new MI command -complete.
5935 * NEWS: Mention new -complete command.
5936
6e035501
JV
59372019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
5938
5939 * completer.h (complete): New function.
5940 * completer.c (complete): Likewise.
5941 * cli/cli-cmds.c: (complete_command): Update to use new complete()
5942 function defined in completer.h.
5943
7d0e2ece
JV
59442019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
5945
e79be6e5 5946 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 5947
fb816e8b
TV
59482019-05-17 Tom de Vries <tdevries@suse.de>
5949
5950 PR gdb/24094
5951 * dwarf2read.c (struct cu_partial_die_info): New struct.
5952 (find_partial_die): Return cu_partial_die_info.
5953 (partial_die_parent_scope, guess_partial_die_structure_name)
5954 (partial_die_info::fixup): Handle new return type of find_partial_die.
5955
677052f2
SDJ
59562019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5957
a1726c38 5958 PR breakpoints/24541
677052f2
SDJ
5959 * stap-probe.c (stap_parse_register_operand): Make "regname" an
5960 "std::string", simplifying the algorithm.
5961
f3da9116
SDJ
59622019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5963
5964 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5965 (stap_static_probe_ops::get_probes): Likewise.
5966
f1bb75ab
SDJ
59672019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5968
5969 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5970 '-')" and "else if".
5971 (stap_parse_single_operand): Join checks for
5972 "gdbarch_stap_parse_special_token_p" and
5973 "gdbarch_stap_parse_special_token" in the same "if" statement.
5974 Invert check when verifying for operation on register
5975 displacement.
5976
3ca58cde
SDJ
59772019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5978
5979 * stap-probe.c (stap_get_opcode): Update comment.
5980 (stap_get_expected_argument_type): Likewise.
5981 (handle_stap_probe): Likewise.
5982
af2d9bee
SDJ
59832019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5984
5985 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5986 return type to 'bool'. Adjust comment. Use 'bool' when
5987 appropriate.
5988 (i386_stap_parse_special_token_three_arg_disp): Likewise.
5989 * stap-probe.c (stap_parse_argument_1): Likewise.
5990 (stap_is_operator): Likewise.
5991 (stap_is_generic_prefix): Likewise.
5992 (stap_is_register_prefix): Likewise.
5993 (stap_is_register_indirection_prefix): Likewise.
5994 (stap_is_integer_prefix): Likewise.
5995 (stap_generic_check_suffix): Likewise.
5996 (stap_check_integer_suffix): Likewise.
5997 (stap_check_register_suffix): Likewise.
5998 (stap_check_register_indirection_suffix): Likewise.
5999 (stap_parse_register_operand): Likewise.
6000 (stap_parse_single_operand): Likewise.
6001 (stap_parse_argument_1): Likewise.
6002 (stap_probe::get_argument_count): Likewise.
6003 (stap_is_operator): Likewise.
6004
61c9c421
TT
60052019-05-16 Tom Tromey <tromey@adacore.com>
6006
6007 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6008 keyword to foreach.
6009
9ddc1af1
SM
60102019-05-15 Simon Marchi <simon.marchi@efficios.com>
6011
6012 * linux-thread-db.c (try_thread_db_load_1): Change return type
6013 to bool.
6014 (try_thread_db_load): Likewise.
6015 (try_thread_db_load_from_pdir_1): Likewise.
6016 (try_thread_db_load_from_pdir): Likewise.
6017 (try_thread_db_load_from_sdir): Likewise.
6018 (try_thread_db_load_from_dir): Likewise.
6019 (thread_db_load_search): Likewise.
6020 (has_libpthread): Likewise.
6021 (thread_db_load): Likewise.
6022
7bede828
SDJ
60232019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
6024
6025 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6026 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6027 NULL, and complain/return if that's the case.
6028
c5358db4
JD
60292019-05-15 John Darrington <john@darrington.wattle.id.au>
6030
6031 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6032 (advance, posn, abstract_read_memory): New functions.
6033 [struct mem_read_abstraction]: New struct.
6034 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6035
c408a94f
TT
60362019-05-14 Tom Tromey <tromey@adacore.com>
6037
6038 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6039 value is not lval_memory.
6040
e7bd7fba
TT
60412019-05-14 Tom Tromey <tromey@adacore.com>
6042
6043 * solib.c (info_sharedlibrary_command): Style the file name.
6044
a6d0f249
AH
60452019-05-14 Alan Hayward <alan.hayward@arm.com>
6046
6047 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6048 (aarch64_vnv_type): Likewise.
6049 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6050 * common/tdesc.c: Likewise.
6051 * common/tdesc.h (enum tdesc_type_kind): Likewise.
6052 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6053 * features/aarch64-fpu.xml: Add ieee half view.
6054 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6055 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6056 * gdbtypes.h (struct builtin_type): Likewise.
6057 (struct objfile_type): Likewise.
6058
66b8bb74
SM
60592019-05-12 Paul Naert <paul.naert@polymtl.ca>
6060
6061 * language.c (language_sniff_from_mangled_name): Fix "langauge"
6062 typo.
6063 * location.h (string_to_event_location): Likewise.
6064
21c219fd
JB
60652019-05-11 Joel Brobecker <brobecker@adacore.com>
6066
6067 GDB 8.3 released.
6068
13674803
SM
60692019-05-10 Simon Marchi <simon.marchi@efficios.com>
6070
6071 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6072 New variable declaration.
6073 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6074 New variable.
6075 (print_one_breakpoint): Use ui_out::test_flags and new global
6076 variable to compute use_fixed_output.
6077 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6078 Remove.
6079 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6080 (mi_multi_location_breakpoint_output_fixed): Remove.
6081 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6082 new variable.
6083 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6084 fix_multi_location_breakpoint_output flag if version >= 3.
6085 * ui-out.h (enum ui_out_flag)
6086 <fix_multi_location_breakpoint_output>: New enumerator.
6087
a9eac7f9
SM
60882019-05-10 Simon Marchi <simon.marchi@efficios.com>
6089
6090 * contrib/cc-with-tweaks.sh: Validate dwz's work.
6091
71bed2db
TT
60922019-05-10 Tom Tromey <tromey@adacore.com>
6093
6094 * ada-lang.c (catch_ada_completer): New function.
6095 (_initialize_ada_language): Use it.
6096
24c54127
TT
60972019-05-10 Tom Tromey <tromey@adacore.com>
6098
6099 * thread.c (print_thread_info): Make "requested_threads" const.
6100 * gdbthread.h (print_thread_info): Make "requested_threads"
6101 const.
6102 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6103 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6104
7a102139
TT
61052019-05-08 Tom Tromey <tom@tromey.com>
6106
6107 * gdbtypes.c (objfile_type_data): Change type.
6108 (objfile_type, _initialize_gdbtypes): Update.
6109
924d79e2
TT
61102019-05-08 Tom Tromey <tom@tromey.com>
6111
6112 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6113 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6114 (_initialize_dwarf2_frame): Update.
6115
4c58e337
TT
61162019-05-08 Tom Tromey <tom@tromey.com>
6117
6118 * objc-lang.c (objc_objfile_data): Change type.
6119 (find_methods): Update.
6120 (_initialize_objc_lang): Remove.
6121
d772d2ab
TT
61222019-05-08 Tom Tromey <tom@tromey.com>
6123
6124 * stabsread.c (rs6000_builtin_type_data): Change type.
6125 (rs6000_builtin_type, _initialize_stabsread): Update.
6126
d11d83f4
TT
61272019-05-08 Tom Tromey <tom@tromey.com>
6128
6129 * mips-tdep.c (mips_pdr_data): Remove.
6130 (_initialize_mips_tdep): Update.
6131
9a73f0ad
TT
61322019-05-08 Tom Tromey <tom@tromey.com>
6133
6134 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6135 (hppa_init_objfile_priv_data, read_unwind_info)
6136 (find_unwind_entry, _initialize_hppa_tdep): Update.
6137
8127a2fa
TT
61382019-05-08 Tom Tromey <tom@tromey.com>
6139
6140 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6141 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
6142 on obstack.
6143 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6144
91d3055d
TT
61452019-05-08 Tom Tromey <tom@tromey.com>
6146
6147 * mdebugread.c (basic_type_data): Change type.
6148 (basic_type, _initialize_mdebugread): Update.
6149
31930bd3
TT
61502019-05-08 Tom Tromey <tom@tromey.com>
6151
6152 * common/gdb_unique_ptr.h (struct noop_deleter): New.
6153
bdb3ed9e
TT
61542019-05-08 Tom Tromey <tom@tromey.com>
6155
6156 * nto-tdep.c (nto_inferior_data_reg): Change type.
6157 (nto_inferior_data): Update.
6158 (nto_inferior_data_cleanup, nto_new_inferior_data)
6159 (_initialize_nto_tdep): Remove.
6160 * nto-tdep.h (struct nto_inferior_data): Add initializers.
6161
f37b313d
TT
61622019-05-08 Tom Tromey <tom@tromey.com>
6163
6164 * ada-lang.c (struct ada_inferior_data): Add initializers.
6165 (ada_inferior_data): Change type.
6166 (ada_inferior_data_cleanup): Remove.
6167 (get_ada_inferior_data, ada_inferior_exit)
6168 (struct ada_pspace_data): Add initializers, destructor.
6169 (ada_pspace_data_handle): Change type.
6170 (get_ada_pspace_data): Update.
6171 (ada_pspace_data_cleanup): Remove.
6172
24699405
TT
61732019-05-08 Tom Tromey <tom@tromey.com>
6174
6175 * coffread.c (struct coff_symfile_info): Add initializers.
6176 (coff_objfile_data_key): Move lower. Change type.
6177 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6178 Update.
6179 (coff_free_info): Remove.
6180
d4e05d2f
TT
61812019-05-08 Tom Tromey <tom@tromey.com>
6182
6183 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6184 (fbsd_pspace_data_handle): Move lower. Change type.
6185 (get_fbsd_pspace_data): Update.
6186 (fbsd_pspace_data_cleanup): Remove.
6187 (_initialize_fbsd_tdep): Update.
6188
14ef6690
TT
61892019-05-08 Tom Tromey <tom@tromey.com>
6190
6191 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6192 (get_ada_tasks_pspace_data): Update.
6193 (ada_tasks_pspace_data_cleanup): Remove.
6194 (_initialize_tasks): Update.
6195 (ada_tasks_inferior_data_handle): Change type.
6196 (get_ada_tasks_inferior_data): Update.
6197 (ada_tasks_inferior_data_cleanup): Remove.
6198 (struct ada_tasks_pspace_data): Add initializers.
6199
814cf43a
TT
62002019-05-08 Tom Tromey <tom@tromey.com>
6201
6202 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6203 * symfile-debug.c (debug_sym_get_probes): Change type.
6204 * stap-probe.c (handle_stap_probe):
6205 (stap_static_probe_ops::get_probes): Change type.
6206 * probe.h (class static_probe_ops) <get_probes>: Change type.
6207 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6208 (parse_probes_in_pspace): Update.
6209 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6210 Update.
6211 (any_static_probe_ops::get_probes): Change type.
6212 * elfread.c (elfread_data): New typedef.
6213 (probe_key): Change type.
6214 (elf_get_probes): Likewise. Update.
6215 (probe_key_free): Remove.
6216 (_initialize_elfread): Update.
6217 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6218 Change type.
6219 (dtrace_process_dof_probe, dtrace_process_dof)
6220 (dtrace_static_probe_ops::get_probe): Change type.
6221
02dc647e
TT
62222019-05-08 Tom Tromey <tom@tromey.com>
6223
6224 * xcoffread.c (struct xcoff_symfile_info): Rename from
6225 coff_symfile_info. Add initializers.
6226 (xcoff_objfile_data_key): Move lower. Change type.
6227 (XCOFF_DATA): Rewrite.
6228 (xcoff_free_info): Remove.
6229 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6230 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6231 (xcoff_initial_scan): Update.
6232
09232438
TT
62332019-05-08 Tom Tromey <tom@tromey.com>
6234
6235 * solib-svr4.c (struct svr4_info): Add initializers and
6236 destructor.
6237 <probes_table>: Now an htab_up.
6238 (solib_svr4_pspace_data): Change type.
6239 (free_probes_table): Simplify.
6240 (~svr4_info): Rename from svr4_pspace_data_cleanup.
6241 (get_svr4_info, probes_table_htab_remove_objfile_probes)
6242 (probes_table_remove_objfile_probes, register_solib_event_probe)
6243 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6244 (_initialize_svr4_solib): Update.
6245
7b4a314f
TT
62462019-05-08 Tom Tromey <tom@tromey.com>
6247
6248 * remote.c (remote_pspace_data): Change type.
6249 (remote_pspace_data_cleanup): Remove.
6250 (get_remote_exec_file, set_pspace_remote_exec_file)
6251 (_initialize_remote): Update.
6252
51d3063a
TT
62532019-05-08 Tom Tromey <tom@tromey.com>
6254
6255 * breakpoint.c (breakpoint_objfile_key): Change type.
6256 (get_breakpoint_objfile_data): Update.
6257 (free_breakpoint_objfile_data): Remove.
6258 (_initialize_breakpoint): Update.
6259
89fb8848
TT
62602019-05-08 Tom Tromey <tom@tromey.com>
6261
6262 * linux-tdep.c (struct linux_info): Add initializers.
6263 (linux_inferior_data): Move. Change type.
6264 (invalidate_linux_cache_inf): Update.
6265 (linux_inferior_data_cleanup): Remove.
6266 (get_linux_inferior_data, _initialize_linux_tdep): Update.
6267
e9b89e2d
TT
62682019-05-08 Tom Tromey <tom@tromey.com>
6269
6270 * auxv.c (auxv_inferior_data): Move. Change type.
6271 (auxv_inferior_data_cleanup): Remove.
6272 (invalidate_auxv_cache_inf): Rewrite.
6273 (get_auxv_inferior_data, _initialize_auxv): Update.
6274
8c42777c
TT
62752019-05-08 Tom Tromey <tom@tromey.com>
6276
6277 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6278 (symfile_debug_objfile_data_key): Change type.
6279 (symfile_debug_installed, debug_qf_has_symbols)
6280 (debug_qf_find_last_source_symtab)
6281 (debug_qf_forget_cached_source_info)
6282 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6283 (debug_qf_print_stats, debug_qf_dump)
6284 (debug_qf_expand_symtabs_for_function)
6285 (debug_qf_expand_all_symtabs)
6286 (debug_qf_expand_symtabs_with_fullname)
6287 (debug_qf_map_matching_symbols)
6288 (debug_qf_expand_symtabs_matching)
6289 (debug_qf_find_pc_sect_compunit_symtab)
6290 (debug_qf_map_symbol_filenames)
6291 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6292 (debug_sym_new_init, debug_sym_init, debug_sym_read)
6293 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6294 (debug_sym_read_linetable, debug_sym_relocate): Update.
6295 (symfile_debug_free_objfile): Remove.
6296 (install_symfile_debug_logging, _initialize_symfile_debug):
6297 Update.
6298
5bfd760d
TT
62992019-05-08 Tom Tromey <tom@tromey.com>
6300
6301 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6302 allocate_on_obstack.
6303 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6304 (get_dwarf2_per_objfile): Update.
6305 (set_dwarf2_per_objfile): Remove.
6306 (dwarf2_has_info, dwarf2_get_section_info): Update.
6307 (dwarf2_free_objfile): Remove.
6308 (_initialize_dwarf2_read): Update.
6309
e85e19b4
TT
63102019-05-08 Tom Tromey <tom@tromey.com>
6311
6312 * auto-load.c (struct auto_load_pspace_info): Add destructor and
6313 initializers.
6314 <unsupported_script_warning_printed,
6315 script_not_found_warning_printed>: Now bool.
6316 (auto_load_pspace_data): Change type.
6317 (~auto_load_pspace_info): Rename from
6318 auto_load_pspace_data_cleanup.
6319 (get_auto_load_pspace_data, init_loaded_scripts_info)
6320 (clear_section_scripts, maybe_print_unsupported_script_warning)
6321 (maybe_print_script_not_found_warning, _initialize_auto_load):
6322 Update.
6323
f6aa7436
TT
63242019-05-08 Tom Tromey <tom@tromey.com>
6325
6326 * objfiles.c (objfile_pspace_info): Add destructor and
6327 initializers.
6328 (objfiles_pspace_data): Change type.
6329 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6330 (get_objfile_pspace_data): Update.
6331 (objfiles_bfd_data): Change type.
6332 (get_objfile_bfd_data): Update.
6333 (objfile_bfd_data_free, _initialize_objfiles): Remove.
6334
6ae614f6
TT
63352019-05-08 Tom Tromey <tom@tromey.com>
6336
6337 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6338 Change type.
6339 (get_catch_syscall_inferior_data): Update.
6340 (catch_syscall_inferior_data_cleanup): Remove.
6341 (_initialize_break_catch_syscall): Update.
6342
6509b8eb
TT
63432019-05-08 Tom Tromey <tom@tromey.com>
6344
6345 * inflow.c (struct terminal_info): Add destructor and
6346 initializers.
6347 (inflow_inferior_data): Change type.
6348 (~terminal_info): Rename from inflow_inferior_data_cleanup.
6349 (get_inflow_inferior_data, inflow_inferior_exit)
6350 (swap_terminal_info, _initialize_inflow): Update.
6351
35632941
TT
63522019-05-08 Tom Tromey <tom@tromey.com>
6353
6354 * target-dcache.c (target_dcache_cleanup): Remove.
6355 (target_dcache_aspace_key): Change type.
6356 (target_dcache_init_p, target_dcache_invalidate)
6357 (target_dcache_get, target_dcache_get_or_init)
6358 (_initialize_target_dcache): Update.
6359 * dcache.h (struct dcache_deleter): New.
6360
3017b94d
TT
63612019-05-08 Tom Tromey <tom@tromey.com>
6362
6363 * symtab.c (struct symbol_cache): Add destructor and
6364 initializers.
6365 (symbol_cache_key): Move. Change type.
6366 (make_symbol_cache, free_symbol_cache): Remove.
6367 (get_symbol_cache): Update.
6368 (symbol_cache_cleanup): Remove.
6369 (ALL_PSPACES, symbol_cache_flush)
6370 (maintenance_print_symbol_cache)
6371 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6372 Update.
6373
a32ad8c5
TT
63742019-05-08 Tom Tromey <tom@tromey.com>
6375
6376 * symtab.c (struct main_info): Add destructor and initializers.
6377 (main_progspace_key): Move. Change type.
6378 (get_main_info): Update.
6379 (main_info_cleanup): Remove.
6380 (_initialize_symtab): Update.
6381
5f6e90a0
TT
63822019-05-08 Tom Tromey <tom@tromey.com>
6383
6384 * registry.h (DECLARE_REGISTRY): Define the _key class.
6385
1bd0c6e4
AB
63862019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
6387
6388 * NEWS: Merge two 'New commands' sections.
6389
2228ef77
XR
63902019-05-08 Joel Brobecker <brobecker@adacore.com>
6391
6392 * ada-valprint.c (ada_val_print_gnat_array): Remove language
6393 parameter and use Ada language definition instead.
6394 (ada_val_print_ptr): Remove unused language parameter.
6395 (ada_val_print_num): Remove language parameter and use Ada language
6396 definition instead.
6397 (ada_val_print_enum, ada_val_print_flt): Remove unused language
6398 parameter.
6399 (ada_val_print_struct_union, ada_val_print_ref): Remove language
6400 parameter and use Ada language definition instead.
6401 (ada_val_print_1): Update all ada_val_print_xxx calls.
6402 Remove language parameter.
6403 (ada_val_print): Update ada_val_print_1 call.
6404
60fcc1c3
TT
64052019-05-08 Tom Tromey <tromey@adacore.com>
6406
6407 * remote.c (remote_hw_watchpoint_limit)
6408 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6409 Now static.
6410
ed2b7c17
TT
64112019-05-08 Tom Tromey <tromey@adacore.com>
6412
6413 * maint.c (_initialize_maint_cmds): Move initialization code to
6414 remote.c.
6415 (watchdog, show_watchdog): Move to remote.c.
6416 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
6417 "watchdog" static.
6418 (_initialize_remote): Move initialization code from maint.c.
6419 * defs.h (watchdog): Don't declare.
6420
b0be6c91
TT
64212019-05-08 Tom Tromey <tromey@adacore.com>
6422
6423 * tui/tui-interp.c: Include main.h.
6424 * interps.c: Include main.h.
6425 * main.h (interpreter_p): Declare.
6426 * defs.h (interpreter_p): Don't declare.
6427
587ee17b
TT
64282019-05-08 Tom Tromey <tromey@adacore.com>
6429
6430 * dwarf2loc.c: Include dwarf2read.h.
6431 * defs.h (read_unsigned_leb128): Don't declare.
6432 * dwarf2read.h (read_unsigned_leb128): Declare.
6433
ca1df239
TT
64342019-05-08 Tom Tromey <tromey@adacore.com>
6435
6436 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6437 method.
6438
99f20f08
TT
64392019-05-08 Tom Tromey <tromey@adacore.com>
6440
6441 * utils.c (fputs_maybe_filtered): Reset style after paging, even
6442 when no wrap column is set.
6443
80e55b13
TT
64442019-05-08 Tom Tromey <tromey@adacore.com>
6445
6446 * c-lang.c (c_get_string): Handle non-C-style arrays.
6447
9d3421af
TT
64482019-05-08 Tom Tromey <tromey@adacore.com>
6449
6450 * typeprint.c (print_offset_data::update): Print the bit offset,
6451 not the number of bits remaining.
6452
844333e2
TT
64532019-05-08 Tom Tromey <tromey@adacore.com>
6454
6455 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6456 padding at end of comment.
6457
988915ee
TT
64582019-05-08 Tom Tromey <tromey@adacore.com>
6459
6460 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6461 Compare main types.
6462
26bfd823
TT
64632019-05-06 Tom Tromey <tom@tromey.com>
6464
6465 * common/scoped_mmap.c: Include common-defs.h.
6466 * common/scoped_mmap.h: Don't include config.h.
6467
89055eaa
TT
64682019-05-04 Tom Tromey <tom@tromey.com>
6469
6470 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6471 (struct aarch64_call_info): Add initializers.
6472 <si>: Now a std::vector.
6473 (pass_on_stack, aarch64_push_dummy_call): Update.
6474
5da01df5
TT
64752019-05-04 Simon Marchi <simon.marchi@efficios.com>
6476 Tom Tromey <tom@tromey.com>
6477
6478 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6479 (ppc_threads): Now a std::vector. Now static.
6480 (hwdebug_find_thread_points_by_tid)
6481 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6482 Update.
6483
fbdf05a1
TT
64842019-05-04 Tom Tromey <tom@tromey.com>
6485
6486 * arc-tdep.c (arc_tdesc_init): Return bool.
6487
06d16ec9
TT
64882019-05-04 Tom Tromey <tom@tromey.com>
6489
6490 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6491 Use gdb_assert_not_reached.
6492
9c056022
TT
64932019-05-04 Tom Tromey <tom@tromey.com>
6494
6495 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6496 "false".
6497
fa9c2a59
TT
64982019-05-04 Tom Tromey <tom@tromey.com>
6499
6500 * arc-tdep.c (arc_tdesc_init): Use bool.
6501
e2eb806a
TT
65022019-05-04 Tom Tromey <tom@tromey.com>
6503
6504 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6505
6fe87677
TT
65062019-05-04 Tom Tromey <tom@tromey.com>
6507
6508 * cli/cli-cmds.c (valid_command_p): Return bool.
6509
7f008c9e
TT
65102019-05-04 Tom Tromey <tom@tromey.com>
6511
6512 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6513 * command.h (valid_user_defined_cmd_name_p): Channge return type.
6514
b6484282
RT
65152019-05-04 Raul Tambre <raul@tambre.ee>
6516
6517 * python/lib/gdb/prompt.py (_ExtendedPrompt)
6518 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6519 operator for comparison.
6520
af97b416
TT
65212019-05-04 Tom Tromey <tom@tromey.com>
6522
6523 * psymtab.c (psymbol_name_matches, match_partial_symbol)
6524 (lookup_partial_symbol, print_partial_symbols)
6525 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6526 (psymbol_compare): Update.
6527 (add_psymbol_to_bcache): Clear the entire psymbol.
6528 (maintenance_check_psymtabs): Update.
6529 * psympriv.h (struct partial_symbol): Don't derive from
6530 general_symbol_info.
6531 <obj_section, unrelocated_address, address,
6532 set_unrelocated_address>: Update.
6533 <ginfo>: New member.
6534 * dwarf-index-write.c (write_psymbols, debug_names::insert)
6535 (debug_names::write_psymbols): Update.
6536
9d6d4be8
TV
65372019-05-04 Tom de Vries <tdevries@suse.de>
6538
6539 * contrib/cc-with-tweaks.sh: Support -n arg.
6540
66452beb
PW
65412019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6542
6543 * corelow.c (core_target::detach): Ensure frame cache and
6544 register caches are cleared.
6545 inferior.c (exit_inferior_1): Likewise.
6546
bde09ab7
TT
65472019-05-03 Sandra Loosemore <sandra@codesourcery.com>
6548 Tom Tromey <tom@tromey.com>
6549
6550 * dictionary.c (collate_pending_symbols_by_language): Remove
6551 "struct" from foreach.
6552 * symtab.c (lookup_global_symbol_from_objfile)
6553 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6554 foreach.
6555 * ser-tcp.c (net_open): Remove "struct" from foreach.
6556 * objfiles.c (objfile_relocate, objfile_rebase)
6557 (objfile_has_symbols): Remove "struct" from foreach.
6558 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6559 from foreach.
6560 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6561 foreach.
6562 * darwin-nat.c (thread_info_from_private_thread_info): Remove
6563 "struct" from foreach.
6564 * ada-lang.c (create_excep_cond_exprs)
6565 (ada_exception_catchpoint_cond_string): Remove "struct" from
6566 foreach.
6567
222a8d25
TT
65682019-05-03 Tom Tromey <tromey@adacore.com>
6569
6570 * ada-exp.y (convert_char_literal): Check suffix of each
6571 enumerator.
6572
fcd60b84
DP
65732019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
6574
6575 PR ada/21406:
6576 * ada-exp.y (yywrap): Don't define.
6577 * ada-lex.l (%option): Add noyywrap
6578 (yywrap): Remove.
6579
5f2459c2
EZ
65802019-05-03 Eli Zaretskii <eliz@gnu.org>
6581
353ea2d1
EZ
6582 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6583 _WIN32_WINNT to the XP level, unless already defined to a higher
6584 level.
6585
6586 * unittests/parse-connection-spec-selftests.c:
6587 * ser-tcp.c:
6588 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
6589 override.
6590
5f2459c2
EZ
6591 * symfile.c (find_separate_debug_file): Remove colon from the
6592 drive spec of DOS/Windows file names of the target, so that the
6593 file name produced from DEBUGDIR and the target's directory will
6594 be valid on DOS/Windows systems.
6595
80062eb9
AB
65962019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
6597
6598 * rust-lang.c (val_print_struct): Handle printing structures
6599 containing strings.
6600
b8c05e85
TT
66012019-05-02 Tom Tromey <tromey@adacore.com>
6602
6603 * valarith.c (_initialize_valarith): Remove.
6604
4504bbde
TT
66052019-05-01 Tom Tromey <tromey@adacore.com>
6606
6607 * ada-lang.c (ada_value_primitive_field): Treat more fields as
6608 bitfields.
6609
d48e62f4
TT
66102019-05-01 Tom Tromey <tromey@adacore.com>
6611
6612 * ada-lang.c (ada_value_assign): Correctly compute starting offset
6613 for big-endian copies.
6614
15f18d14
AT
66152019-04-30 Ali Tamur <tamur@google.com>
6616 * gdb/dwarf2read.c (read_3_bytes): New declaration.
6617 (read_attribute_value): Added DW_FORM_strx1-4 cases.
6618 (read_3_bytes): New function.
6619
ab4ee614
JB
66202019-04-30 Joel Brobecker <brobecker@adacore.com>
6621
6622 * windows-nat.c (main_thread_id): Delete.
6623 (handle_output_debug_string): Replace main_thread_id by
6624 current_event.dwThreadId.
6625 (fake_create_process): Likewise.
6626 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6627 Do not set main_thread_id.
6628 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6629 current_event.dwThreadId.
6630 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6631
8ed5b76e
JB
66322019-04-30 Joel Brobecker <brobecker@adacore.com>
6633
6634 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6635 Use current_event.dwThreadId instead of main_thread_id.
6636
2ff0a947
TT
66372019-04-30 Tom Tromey <tromey@adacore.com>
6638
6639 * ada-lang.c (ada_lookup_simple_minsyms): New function.
6640 (create_excep_cond_exprs): Iterate over program spaces.
6641 (ada_exception_catchpoint_cond_string): Examine all minimal
6642 symbols for exception types.
6643
a776957c
TT
66442019-04-30 Tom Tromey <tromey@adacore.com>
6645
6646 PR c++/24470:
6647 * dwarf2read.c (process_structure_scope): Handle case where type
6648 has template parameters but no symbol was created.
6649
bc68014d
AB
66502019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6651 Chris January <chris.january@arm.com>
6652
6653 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6654 qualifier.
6655 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6656
f1fdc960
AB
66572019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6658
6659 * f-typeprint.c (f_print_type): Update rules for printing
6660 whitespace.
6661 (f_type_print_varspec_suffix): Likewise.
6662
bf7a4de1
AB
66632019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6664 Chris January <chris.january@arm.com>
6665
6666 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6667 function arguments.
6668
bbe75b9d
AB
66692019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6670
6671 * f-lang.c (build_fortran_types): Change name of void type to
6672 lower case.
6673 * f-typeprint.c (f_type_print_base): Print the name of the void
6674 type, rather than a fixed string.
6675 * f-valprint.c (f_decorations): Use lower case void string.
6676
1db455a7
AB
66772019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6678 Chris January <chris.january@arm.com>
6679
6680 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6681 types for Fortran.
6682
b6d03bb2
AB
66832019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6684 Chris January <chris.january@arm.com>
6685 David Lecomber <david.lecomber@arm.com>
6686
6687 * f-exp.y (BINOP_INTRINSIC): New token.
6688 (exp): New parser rule handling BINOP_INTRINSIC.
6689 (f77_keywords): Add new builtin procedures.
6690 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6691 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6692 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6693 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6694 (print_unop_subexp_f): New function.
6695 (print_binop_subexp_f): New function.
6696 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6697 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6698 (dump_subexp_body_f): Likewise.
6699 (operator_check_f): Likewise.
6700 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6701 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6702
83228e93
AB
67032019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6704
6705 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6706 UNOP_KIND.
6707 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6708 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6709 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6710 (operator_length_f): New fuction.
6711 (print_subexp_f): New function.
6712 (op_name_f): New function.
6713 (dump_subexp_body_f): New function.
6714 (operator_check_f): New function.
6715 (exp_descriptor_f): Replace standard expression handling functions
6716 with new functions.
6717 * gdb/fortran-operator.def: New file.
6718 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6719 * gdb/std-operator.def: Remove UNOP_KIND.
6720
6fdcd7cc
AB
67212019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
6722
6723 * std-operator.def: Remove unbalanced, stray double quote
6724 character.
6725
2e62ab40
AB
67262019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6727 Chris January <chris.january@arm.com>
6728 Daniel Everett <daniel.everett@arm.com>
6729 Nick Forrington <nick.forrington@arm.com>
6730 Richard Bunt <richard.bunt@arm.com>
6731
6732 * cp-valprint.c (cp_print_value_fields): Allow an additional level
6733 of depth when printing anonymous structs or unions.
6734 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6735 Don't print either the top-level value, or the children if the
6736 max-depth is exceeded.
6737 (ppscm_print_children): When printing the key of a map, allow one
6738 extra level of depth.
6739 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6740 print either the top-level value, or the children if the max-depth
6741 is exceeded.
6742 (print_children): When printing the key of a map, allow one extra
6743 level of depth.
6744 * python/py-value.c (valpy_format_string): Add max_depth keyword.
6745 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6746 (user_print_options): Initialise max_depth field.
6747 (val_print_scalar_or_string_type_p): New function.
6748 (val_print): Check to see if the max depth has been reached.
6749 (val_print_check_max_depth): Define new function.
6750 (show_print_max_depth): New function.
6751 (_initialize_valprint): Add 'print max-depth' option.
6752 * valprint.h (struct value_print_options) <max_depth>: New field.
6753 (val_print_check_max_depth): Declare new function.
6754 * NEWS: Document new feature.
6755
4be290b2
AB
67562019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6757
6758 * ada-lang.c (ada_language_defn): Initialise new field.
6759 * c-lang.c (c_is_string_type_p): New function.
6760 (c_language_defn): Initialise new field.
6761 (cplus_language_defn): Initialise new field.
6762 (asm_language_defn): Initialise new field.
6763 (minimal_language_defn): Initialise new field.
6764 * c-lang.h (c_is_string_type_p): Declare new function.
6765 * d-lang.c (d_language_defn): Initialise new field.
6766 * f-lang.c (f_is_string_type_p): New function.
6767 (f_language_defn): Initialise new field.
6768 * go-lang.c (go_is_string_type_p): New function.
6769 (go_language_defn): Initialise new field.
6770 * language.c (default_is_string_type_p): New function.
6771 (unknown_language_defn): Initialise new field.
6772 (auto_language_defn): Initialise new field.
6773 * language.h (struct language_defn) <la_is_string_type_p>: New
6774 member variable.
6775 (default_is_string_type_p): Declare new function.
6776 * m2-lang.c (m2_language_defn): Initialise new field.
6777 * objc-lang.c (objc_language_defn): Initialise new field.
6778 * opencl-lang.c (opencl_language_defn): Initialise new field.
6779 * p-lang.c (pascal_is_string_type_p): New function.
6780 (pascal_language_defn): Initialise new field.
6781 * rust-lang.c (rust_is_string_type_p): New function.
6782 (rust_language_defn): Initialise new field.
6783
721b08c6
AB
67842019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6785
6786 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6787 New field.
6788 * ada-lang.c (ada_language_defn): Initialise new field.
6789 * c-lang.c (c_language_defn): Likewise.
6790 (cplus_language_defn): Likewise.
6791 (asm_language_defn): Likewise.
6792 (minimal_language_defn): Likewise.
6793 * d-lang.c (d_language_defn): Likewise.
6794 * f-lang.c (f_language_defn): Likewise.
6795 * go-lang.c (go_language_defn): Likewise.
6796 * language.c (unknown_language_defn): Likewise.
6797 (auto_language_defn): Likewise.
6798 * m2-lang.c (m2_language_defn): Likewise.
6799 * objc-lang.c (objc_language_defn): Likewise.
6800 * opencl-lang.c (opencl_language_defn): Likewise.
6801 * p-lang.c (pascal_language_defn): Likewise.
6802 * rust-lang.c (rust_language_defn): Likewise.
6803
fc913e53
AB
68042019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
6805
6806 * ada-lang.c (ada_is_character_type): Change return type to bool.
6807 (ada_is_string_type): Likewise.
6808 * ada-lang.h (ada_is_character_type): Update declaration
6809 (ada_is_string_type): Likewise.
6810
fa731fa0
PW
68112019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6812
6813 Support style in 'frame|thread apply'
6814
6815 * gdbcmd.h (execute_command_to_string): New term_out parameter.
6816 * record.c (record_start, record_stop): Update callers of
6817 execute_command_to_string with false.
6818 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6819 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6820 methods.
6821 (class string_file): New constructor with term_out parameter.
6822 Override methods term_out and can_emit_style_escape. New member
6823 term_out.
6824 (class stdio_file): Override can_emit_style_escape.
6825 (class tee_file): Override term_out and can_emit_style_escape.
6826 * utils.h (can_emit_style_escape): Remove.
6827 * utils.c (can_emit_style_escape): Likewise.
6828 Update all callers of can_emit_style_escape (SOMESTREAM) to
6829 SOMESTREAM->can_emit_style_escape.
6830 * source-cache.c (source_cache::get_source_lines): Likewise.
6831 * stack.c (frame_apply_command_count): Call execute_command_to_string
6832 passing the term_out characteristic of the current gdb_stdout.
6833 * thread.c (thr_try_catch_cmd): Likewise.
6834 * top.c (execute_command_to_string): pass term_out parameter
6835 to construct the string_file for the command output.
6836 * ui-file.c (term_cli_styling): New function (most code moved
6837 from utils.c can_emit_style_escape).
6838 (string_file::string_file, string_file::can_emit_style_escape,
6839 stdio_file::can_emit_style_escape, tee_file::term_out,
6840 tee_file::can_emit_style_escape): New functions.
6841
136afab8
PW
68422019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6843
6844 * NEWS: Mention the new set|show may-call-functions.
6845 * infcall.c (may_call_functions_p): New variable.
6846 (show_may_call_functions_p): New function.
6847 (call_function_by_hand_dummy): Throws an error if not
6848 may-call-functions.
6849 (_initialize_infcall): Call add_setshow_boolean_cmd for
6850 may-call-functions.
6851
725cbb63
KS
68522019-04-25 Keith Seitz <keiths@redhat.com>
6853
6854 PR c++/24367
6855 * cp-support.c (inspect_type): Don't attempt substitutions
6856 of symbol with the same name.
6857
3d1cbb78
TT
68582019-04-25 Tom Tromey <tromey@adacore.com>
6859
6860 PR gdb/24475:
6861 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6862 static.
6863
94aeb44b
TT
68642019-04-25 Tom Tromey <tromey@adacore.com>
6865
6866 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6867 rvalue reference.
6868 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6869 (gdb_xml_parser::parse): Use std::move.
6870 * python/python-internal.h (gdbpy_convert_exception): Take a const
6871 reference.
6872 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6873 std::move.
6874 * python/py-utils.c (gdbpy_convert_exception): Take a const
6875 reference.
6876 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6877 Use std::move.
6878 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6879 Use std::move.
6880 * mi/mi-main.c (mi_print_exception): Take a const reference.
6881 * main.c (handle_command_errors): Take a const reference.
6882 * linespec.c (parse_linespec): Use std::move.
6883 * infcall.c (run_inferior_call): Use std::move.
6884 (call_function_by_hand_dummy): Use std::move.
6885 * exec.c (try_open_exec_file): Use std::move.
6886 * exceptions.h (exception_print, exception_fprintf)
6887 (exception_print_same): Update.
6888 * exceptions.c (print_exception, exception_print)
6889 (exception_fprintf, exception_print_same): Change parameters to
6890 const reference.
6891 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6892 * common/new-op.c: Use std::move.
6893 * common/common-exceptions.h (struct gdb_exception): Add move
6894 constructor.
6895 (struct gdb_exception_error, struct gdb_exception_quit, struct
6896 gdb_quit_bad_alloc): Change constructor to move constructor.
6897 (throw_exception): Change parameter to rvalue reference.
6898 * common/common-exceptions.c (throw_exception): Take rvalue
6899 reference.
6900 * cli/cli-interp.c (safe_execute_command): Use std::move.
6901 * breakpoint.c (insert_bp_location, location_to_sals): Use
6902 std::move.
6903
680d7fd5
TT
69042019-04-25 Tom Tromey <tromey@adacore.com>
6905
6906 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6907 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6908 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6909 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6910 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6911 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6912 guile/scm-value.c: Use unpack.
6913 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6914 gdbscm_gdb_exception.
6915 (gdbscm_throw_gdb_exception): Likewise.
6916 (struct gdbscm_gdb_exception): New.
6917 (unpack): New function.
6918 (gdbscm_wrap): Use unpack.
6919
c6fdd8b2
TT
69202019-04-25 Tom Tromey <tromey@adacore.com>
6921
6922 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6923 (gdb_rl_callback_handler): Use std::move.
6924 * common/common-exceptions.h (struct gdb_exception): Add move
6925 assignment operator.
6926 (throw_exception_sjlj): Change "exception" to const reference.
6927 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6928 (throw_exception_sjlj): Change "exception" to const reference.
6929
cc06b668
TT
69302019-04-25 Tom Tromey <tromey@adacore.com>
6931
6932 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6933 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6934 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6935 Update.
6936 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6937 Update.
6938 * mi/mi-interp.c (mi_interp::exec): Update.
6939 * linespec.c (parse_linespec): Update.
6940 * infcall.c (run_inferior_call): Update.
6941 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6942 * guile/scm-symbol.c (gdbscm_lookup_symbol)
6943 (gdbscm_lookup_global_symbol): Update.
6944 * guile/scm-param.c (gdbscm_parameter_value): Update.
6945 * guile/scm-frame.c (gdbscm_frame_read_register)
6946 (gdbscm_frame_read_var): Update.
6947 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6948 * exec.c (try_open_exec_file): Update.
6949 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6950 (gdb_rl_callback_handler): Update.
6951 * common/common-exceptions.h (exception_none): Don't declare.
6952 * common/common-exceptions.c (exception_none): Don't define.
6953 (struct catcher) <exception>: Update.
6954 * cli/cli-interp.c (safe_execute_command): Update.
6955 * breakpoint.c (insert_bp_location, location_to_sals): Update.
6956
cf532bd1
AT
69572019-04-25 Ali Tamur <tamur@google.com>
6958
6959 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6960 (read_attribute_value): Likewise.
6961 (dwarf2_read_addr_index): Update comment.
6962 (read_str_index): Add DW_FORM_strx.
6963 (dwarf2_string_attr): Likewise.
6964 (dwarf2_const_value_attr): Likewise.
6965 (dump_die_shallow): Likewise.
6966 (dwarf2_fetch_constant_bytes): Likewise.
6967 (skip_form_bytes): Likewise.
6968 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6969
82433e3e
SDJ
69702019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
6971
6972 PR corefiles/11608
6973 PR corefiles/18187
6974 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6975 OFFSET. Verify if current mapping contains an ELF header.
6976 (linux_find_memory_regions_full): Adjust call to
6977 dump_mapping_p.
6978
723adb65
SL
69792019-04-25 Sandra Loosemore <sandra@codesourcery.com>
6980 Kang Li <kanglictf@gmail.com>
6981
6982 PR gdb/21600
6983
6984 * dwarf2-frame.c (read_initial_length): Be consistent about using
6985 unsigned representation of length.
6986 (decode_frame_entry_1): Likewise. Check for wraparound of
6987 end pointer as well as buffer overflow.
6988
596179f7
SDJ
69892019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
6990
6991 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6992 "vq".
6993
a59240a4
TT
69942019-04-24 Tom Tromey <tromey@adacore.com>
6995
6996 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6997
f872fdbb
AB
69982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6999
7000 * s12z-tdep.c (s12z_unwind_pc): Delete.
7001 (s12z_unwind_sp): Delete.
7002 (s12z_gdbarch_init): Don't register deleted functions with
7003 gdbarch.
7004
b614e6f3
AB
70052019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7006
7007 * rl78-tdep.c (rl78_unwind_sp): Delete.
7008 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7009
14faed38
AB
70102019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7011
7012 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7013 (xstormy16_unwind_pc): Delete.
7014 (xstormy16_dummy_id): Delete.
7015 (xstormy16_gdbarch_init): Don't register deleted functions with
7016 gdbarch.
7017
541aad8a
AB
70182019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7019
7020 * vax-tdep.c (vax_unwind_pc): Delete.
7021 (vax_gdbarch_init): Don't register deleted function with gdbarch.
7022
29222070
AB
70232019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7024
7025 * v850-tdep.c (v850_unwind_sp): Delete.
7026 (v850_unwind_pc): Delete.
7027 (v850_dummy_id): Delete.
7028 (v850_gdbarch_init): Don't register deleted functions with
7029 gdbarch.
7030
0f534d76
AB
70312019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7032
7033 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7034 (tilegx_unwind_pc): Delete.
7035 (tilegx_unwind_dummy_id): Delete.
7036 (tilegx_gdbarch_init): Don't register deleted functions with
7037 gdbarch.
7038
1ba7b7f9
AB
70392019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7040
7041 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7042 (tic6x_dummy_id): Delete.
7043 (tic6x_gdbarch_init): Don't register deleted functions with
7044 gdbarch.
7045
d31f262c
AB
70462019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7047
7048 * sparc-tdep.c (sparc_unwind_pc): Delete.
7049 (sparc32_gdbarch_init): Don't register deleted function with
7050 gdbarch.
7051
6d14d64d
AB
70522019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7053
7054 * sh-tdep.c (sh_unwind_sp): Delete.
7055 (sh_unwind_pc): Delete.
7056 (sh_dummy_id): Delete.
7057 (sh_gdbarch_init): Don't register deleted functions with
7058 gdbarch.
7059
a40dde9d
AB
70602019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7061
7062 * score-tdep.c (score_unwind_sp): Delete.
7063 (score_unwind_pc): Delete.
7064 (score_dummy_id): Delete.
7065 (score_gdbarch_init): Don't register deleted functions with
7066 gdbarch.
7067
47c47d69
AB
70682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7069
7070 * rx-tdep.c (rx_unwind_pc): Delete.
7071 (rx_unwind_sp): Delete.
7072 (rx_dummy_id): Delete.
7073 (rx_gdbarch_init): Don't register deleted functions with
7074 gdbarch. Update comment.
7075
833a4480
AB
70762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7077
7078 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7079 (rs6000_dummy_id): Delete.
7080 (rs6000_gdbarch_init): Don't register deleted functions with
7081 gdbarch.
7082
3f2cef49
AB
70832019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7084
7085 * or1k-tdep.c (or1k_dummy_id): Delete.
7086 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7087
96acf884
AB
70882019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7089
7090 * nios2-tdep.c (nios2_dummy_id): Delete.
7091 (nios2_unwind_sp): Delete.
7092 (nios2_gdbarch_init): Don't register deleted functions with
7093 gdbarch.
7094
ca0ab0aa
AB
70952019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7096
7097 * nds32-tdep.c (nds32_dummy_id): Delete.
7098 (nds32_unwind_pc): Delete.
7099 (nds32_unwind_sp): Delete.
7100 (nds32_gdbarch_init): Don't register deleted functions with
7101 gdbarch.
7102
c8259044
AB
71032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7104
7105 * msp430-tdep.c (msp430_unwind_pc): Delete.
7106 (msp430_unwind_sp): Delete.
7107 (msp430_dummy_id): Delete.
7108 (msp430_gdbarch_init): Don't register deleted functions with
7109 gdbarch.
7110
27f113c8
AB
71112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7112
7113 * moxie-tdep.c (moxie_unwind_sp): Delete.
7114 (moxie_unwind_pc): Delete.
7115 (moxie_dummy_id): Delete.
7116 (moxie_gdbarch_init): Don't register deleted functions with
7117 gdbarch.
7118
aee6c3cd
AB
71192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7120
7121 * mn10300-tdep.c (mn10300_dummy_id): Delete.
7122 (mn10300_unwind_pc): Delete.
7123 (mn10300_unwind_sp): Delete.
7124 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7125 mn10300_unwind_sp.
7126 (mn10300_frame_unwind_init): Don't register deleted functions with
7127 gdbarch.
7128
8e2b5aea
AB
71292019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7130
7131 * mep-tdep.c (mep_unwind_pc): Delete.
7132 (mep_unwind_sp): Delete.
7133 (mep_dummy_id): Delete.
7134 (mep_gdbarch_init): Don't register deleted functions with
7135 gdbarch.
7136
43cf3ede
AB
71372019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7138
7139 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7140 (m68hc11_unwind_sp): Delete.
7141 (m68hc11_gdbarch_init): Don't register deleted functions with
7142 gdbarch.
7143
5e79b7bb
AB
71442019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7145
7146 * m32r-tdep.c (m32r_unwind_sp): Delete.
7147 (m32r_unwind_pc): Delete.
7148 (m32r_dummy_id): Delete.
7149 (m32r_gdbarch_init): Don't register deleted functions with
7150 gdbarch.
7151
89b268d8
AB
71522019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7153
7154 * m32c-tdep.c (m32c_unwind_pc): Delete.
7155 (m32c_unwind_sp): Delete.
7156 (m32c_dummy_id): Delete.
7157 (m32c_gdbarch_init): Don't register deleted functions with
7158 gdbarch.
7159
946c28d2
AB
71602019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7161
7162 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7163 (lm32_unwind_pc): Delete.
7164 (lm32_dummy_id): Delete.
7165 (lm32_gdbarch_init): Don't register deleted functions with
7166 gdbarch.
7167
bf12844a
AB
71682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7169
7170 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7171 (iq2000_unwind_pc): Delete.
7172 (iq2000_dummy_id): Delete.
7173 (iq2000_gdbarch_init): Don't register deleted functions with
7174 gdbarch.
7175
ecbc06d2
AB
71762019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7177
7178 * nds32-tdep.c (nds32_type_align): Delete.
7179 (nds32_push_dummy_call): Use type_align instead.
7180
030197b4
AB
71812019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7182
7183 * arm-tdep.c (arm_type_align): Only handle vector override case.
7184 (arm_push_dummy_call): Use type_align.
7185 (arm_gdbarch_init): Register arm_type_align gdbarch function.
7186
b907456c
AB
71872019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
7188
7189 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7190 case.
7191 (pass_on_stack): Use type_align.
7192 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7193 function.
7194
9e97ba43
TT
71952019-04-23 Tom Tromey <tromey@adacore.com>
7196
7197 * dwarf2read.c (line_header::file_name_at): Remove unused
7198 overload.
7199
6892f601
TV
72002019-04-23 Tom de Vries <tdevries@suse.de>
7201
7202 PR gdb/24438
7203 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7204 invocation.
7205
336d760d
AT
7206
72072019-03-27 Ali Tamur <tamur@google.com>
7208
7209 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7210 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7211 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7212 (dwarf_expr_context::get_addr_index): Likewise
7213 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7214 (symbol_needs_eval_context::get_addr_index): Likewise
7215 (disassemble_dwarf_expression): Add DW_OP_addrx
7216 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7217 (read_cutu_die_from_dwo): Update comment
7218 (skip_one_die): Add DW_FORM_addrx
7219 (read_attribute_value): Likewise
7220 (var_decode_location): Add DW_OP_addrx
7221 (dwarf2_const_value_attr): Add DW_FORM_addrx
7222 (dump_die_shallow): Likewise
7223 (dwarf2_fetch_constant_bytes): Likewise
7224 (decode_locdesc): Add DW_OP_addrx
7225 (skip_form_bytes): Add DW_FORM_addrx
7226
ad9d13f8
AT
72272019-04-22 Ali Tamur <tamur@google.com>
7228
7229 * MAINTAINERS (Write After Approval): Add self.
7230
d70cc3ba
SM
72312019-04-22 Simon Marchi <simon.marchi@efficios.com>
7232
7233 * solib-svr4.c (get_svr4_info): Add pspace parameter.
7234 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7235 (open_symbol_file_object): Likewise.
7236 (svr4_default_sos): Add info parameter.
7237 (svr4_read_so_list): Likewise.
7238 (svr4_current_sos_direct): Adjust functions calls to pass down
7239 info.
7240 (svr4_current_sos_1): Add info parameter.
7241 (svr4_current_sos): Call get_svr4_info, pass info down to
7242 svr4_current_sos_1.
7243 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7244 get_svr4_info.
7245 (svr4_in_dynsym_resolve_code): Pass current_program_space to
7246 get_svr4_info.
7247 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7248 to get_svr4_info.
7249 (probes_table_remove_objfile_probes): Likewise.
7250 (register_solib_event_probe): Add info parameter.
7251 (solist_update_incremental): Pass info parameter down to
7252 svr4_read_so_list.
7253 (disable_probes_interface): Add info parameter.
7254 (svr4_handle_solib_event): Pass current_program_space to
7255 get_svr4_info. Adjust disable_probes_interface cleanup.
7256 (svr4_create_probe_breakpoints): Add info parameter, pass it
7257 down to register_solib_event_probe.
7258 (svr4_create_solib_event_breakpoints): Add info parameter,
7259 pass it down to svr4_create_probe_breakpoints.
7260 (enable_break): Pass info down to
7261 svr4_create_solib_event_breakpoints.
7262 (svr4_solib_create_inferior_hook): Pass current_program_space to
7263 get_svr4_info.
7264 (svr4_clear_solib): Likewise.
7265
7905fc35
PA
72662019-04-22 Pedro Alves <palves@redhat.com>
7267
7268 * solib-svr4.c (svr4_free_objfile_observer): New.
7269 (probe_and_action::objfile): New field.
7270 (probes_table_htab_remove_objfile_probes)
7271 (probes_table_remove_objfile_probes): New functions.
7272 (register_solib_event_probe): Add 'objfile' parameter. Store it
7273 in the new probe_and_action. Don't store the probe in 'lookup'.
7274 (svr4_create_probe_breakpoints): Pass objfile to
7275 register_solib_event_probe.
7276 (_initialize_svr4_solib): Register a free_objfile observer.
7277
fb881986
TT
72782019-04-19 Tom Tromey <tom@tromey.com>
7279
7280 * common/queue.h: Remove.
7281
8732db6c
TT
72822019-04-19 Tom Tromey <tom@tromey.com>
7283
7284 * event-loop.c: Don't include "common/queue.h".
7285
97dfbadd
TT
72862019-04-19 Tom Tromey <tom@tromey.com>
7287
7288 * remote.c (remote_target): Use delete.
7289 * remote-notif.h: Include <list>, not "common/queue.h".
7290 (notif_client_p): Remove typedef.
7291 (remote_notif_state): Add constructor, destructor, initializer.
7292 <notif_queue>: Now a std::list.
7293 (remote_notif_state_xfree): Don't declare.
7294 * remote-notif.c (remote_notif_process, handle_notification)
7295 (remote_notif_state_allocate): Update.
7296 (~remote_notif_state): Rename from remote_notif_state_xfree.
7297
cf250e36
TT
72982019-04-19 Tom Tromey <tom@tromey.com>
7299
7300 * symfile.c (reread_symbols): Update.
7301 * objfiles.c (objfile_register_static_link)
7302 (objfile_lookup_static_link): Update
7303 (~objfile) Don't delete static_links.
7304 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7305
61f4b350
TT
73062019-04-19 Tom Tromey <tom@tromey.com>
7307
7308 * type-stack.h (struct type_stack) <insert>: Constify string.
7309 * type-stack.c (type_stack::insert): Constify string.
7310 * gdbtypes.h (lookup_template_type): Update.
7311 (address_space_name_to_int): Update.
7312 * gdbtypes.c (address_space_name_to_int): Make space_identifier
7313 const.
7314 (lookup_template_type): Make name const.
7315 * c-exp.y: Update rules.
7316 (lex_one_token, classify_name, classify_inner_name)
7317 (c_print_token): Update.
7318 * p-exp.y: Update rules.
7319 (yylex): Update.
7320 * f-exp.y: Update rules.
7321 (yylex): Update.
7322 * d-exp.y: Update rules.
7323 (lex_one_token, classify_name, classify_inner_name): Update.
7324 * parse.c (write_dollar_variable, copy_name): Return std::string.
7325 * parser-defs.h (copy_name): Change return type.
7326 * m2-exp.y: Update rules.
7327 (yylex): Update.
7328 * go-exp.y (lex_one_token): Update.
7329 Update rules.
7330 (classify_unsafe_function, classify_packaged_name)
7331 (classify_name, yylex): Update.
7332
189b8c2e
ST
73332019-04-19 Sergei Trofimovich <siarheit@google.com>
7334
7335 * configure.ac: add --enable-source-highlight switch.
7336 * configure: Regenerate.
7337 * top.c (print_gdb_version): plumb --enable-source-highlight
7338 status to "show configuration".
7339
8ecb59f8
TT
73402019-04-19 Tom Tromey <tromey@adacore.com>
7341
7342 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7343 Check ADA_TYPE_P.
7344 (empty_record, ada_template_to_fixed_record_type_1)
7345 (template_to_static_fixed_type)
7346 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7347 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7348 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7349 macros.
7350
62160ec9
TT
73512019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
7352
7353 PR symtab/24423:
7354 * source.c (print_source_lines_base): Advance "iter" when a
7355 control character is seen.
7356
f2ae8bc8
PW
73572019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7358
7359 * inferior.h (struct infcall_suspend_state_deleter):
7360 Catch exception in destructor to avoid crash.
7361
d563b953
PW
73622019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7363
7364 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7365 close to the add_com "shell".
7366
dc34c897
TT
73672019-04-18 Tom Tromey <tromey@adacore.com>
7368
7369 * process-stratum-target.h (class process_stratum_target)
7370 <stratum>: Add "final".
7371
a12e5744
TT
73722019-04-17 Tom Tromey <tromey@adacore.com>
7373
7374 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7375 against nullptr before use.
7376
a7e559cc
AH
73772019-04-17 Alan Hayward <alan.hayward@arm.com>
7378
7379 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7380
c01660c6
AB
73812019-04-17 Jim Wilson <jimw@sifive.com>
7382 Andrew Burgess <andrew.burgess@embecosm.com>
7383
7384 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7385 code read might fail, assume 4-byte breakpoint in that case.
7386
4aa866af
LS
73872019-04-15 Leszek Swirski <leszeks@google.com>
7388
7389 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7390 rather than a hand-rolled POD check when checking for forced MEMORY
7391 classification.
7392
48574d91
AH
73932019-04-15 Alan Hayward <alan.hayward@arm.com>
7394
7395 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7396 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7397 function.
7398 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7399 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7400 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7401 declaration.
7402
4da037ef
AH
74032019-04-15 Alan Hayward <alan.hayward@arm.com>
7404
7405 * aarch64-linux-nat.c
7406 (aarch64_linux_nat_target::thread_architecture): Add override.
7407 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7408 each VQ.
7409
ccb8d7e8
AH
74102019-04-15 Alan Hayward <alan.hayward@arm.com>
7411
7412 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7413
35add35e
AB
74142019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
7415
7416 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7417 target types of size 96-bits, add some additional comments, and
7418 check that the builtin type we found was the correct size.
7419
51196bbc
EZ
74202019-04-12 Eli Zaretskii <eliz@gnu.org>
7421
7422 * utils.c (prompt_for_continue): Don't restore the styling at the
7423 end, as applied_style has the wrong value. This fixes styling in
7424 long lists of file names that are interrupted by the "Continue?"
7425 prompt.
7426
62253a61
AB
74272019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
7428
7429 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7430 * c-lang.c (c_language_defn): Likewise.
7431 (cplus_language_defn): Likewise.
7432 (asm_language_defn): Likewise.
7433 (minimal_language_defn): Likewise.
7434 * d-lang.c (d_language_defn): Likewise.
7435 * f-lang.c (f_language_defn): Likewise.
7436 * go-lang.c (go_language_defn): Likewise.
7437 * language.c (unknown_language_defn): Likewise.
7438 (auto_language_defn): Likewise.
7439 * language.h (struct language_defn): Remove la_magic field.
7440 (LANG_MAGIC): Delete.
7441 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7442 * objc-lang.c (objc_language_defn): Likewise.
7443 * opencl-lang.c (opencl_language_defn): Likewise.
7444 * p-lang.c (pascal_language_defn): Likewise.
7445 * rust-lang.c (rust_language_defn): Likewise.
7446
a9158a86
AB
74472019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7448
7449 * riscv-tdep.c (riscv_type_align): New function.
7450 (riscv_type_alignment): Delete.
7451 (riscv_arg_location): Use 'type_align'.
7452 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7453
41077b66
AB
74542019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7455
7456 * gdbtypes.c (type_align): A struct with no non-static fields also
7457 has alignment of 1.
7458
9f0272f8
AB
74592019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
7460
7461 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7462 component to 0.
7463 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7464 member.
7465 (riscv_struct_info::analyse): New implementation using new
7466 analyse_inner member function.
7467 (riscv_struct_info::field_offset): New member function.
7468 (riscv_struct_info::m_offsets): New member variable.
7469 (riscv_struct_info::analyse_inner): New private member function,
7470 takes the old implementation of riscv_struct_info::analyse but
7471 extended to track field offsets.
7472 (riscv_call_arg_struct): Update the struct folding special cases
7473 to handle cases where empty C++ structs, which are non-zero
7474 length, are found.
7475 (riscv_arg_location): Initialise the length of each location, a
7476 non-zero length now indicates the location is in use.
7477 (riscv_push_dummy_call): Allow for the first location having a
7478 non-zero offset when setting up arguments.
7479 (riscv_return_value): Likewise, but for return values.
7480
02cf60c7
TT
74812019-04-11 Tom Tromey <tromey@adacore.com>
7482
7483 * utils.c (internal_vproblem): Make "msg" const.
7484
68811f8f
AH
74852019-04-11 Alan Hayward <alan.hayward@arm.com>
7486
7487 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7488 * trad-frame.c (trad_frame_reset_saved_regs): New function.
7489 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7490 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7491
3f52fdbc
KB
74922019-04-10 Kevin Buettner <kevinb@redhat.com>
7493
7494 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7495 function.
7496 (fill_gregset): Call amd64_linux_collect_native_gregset instead
7497 of amd64_collect_native_gregset.
7498 (amd64_linux_nat_target::store_registers): Likewise.
7499
e9ad22ee
TT
75002019-04-10 Tom Tromey <tom@tromey.com>
7501
7502 * symtab.c (lookup_global_symbol_from_objfile)
7503 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7504 * objfiles.h (class separate_debug_iterator): New.
7505 (class separate_debug_range): New.
7506 (struct objfile) <separate_debug_objfiles>: New method.
7507 (objfile_separate_debug_iterate): Don't declare.
7508 * objfiles.c (separate_debug_iterator::operator++): Rename from
7509 objfile_separate_debug_iterate.
7510 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7511 iterator.
7512 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7513 iterator.
7514
ee371134
TT
75152019-04-10 Tom Tromey <tom@tromey.com>
7516
7517 * symfile.c (reread_symbols): Remove old comment.
7518 * objfiles.c (free_all_objfiles): Fix a typo.
7519
bf227d61
TT
75202019-04-10 Tom Tromey <tom@tromey.com>
7521
7522 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7523 * minsyms.c (lookup_minimal_symbol): Use foreach.
7524 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7525 (lookup_minimal_symbol_solib_trampoline): Likewise.
7526 * symfile.c (reread_symbols): Use foreach.
7527
8dc433a0
TT
75282019-04-09 Ivan Begert <ivanbegert@gmail.com>
7529 Tom Tromey <tromey@adacore.com>
7530
7531 PR rust/24414:
7532 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7533 (rust_lex_int_test): Change "value" to be LONGEST.
7534 (rust_lex_tests): Add test for long integer literal.
7535
9ab8741a
TT
75362019-04-09 Tom Tromey <tromey@adacore.com>
7537
7538 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7539 to bool.
7540 (extended_remote_target::attach): Update.
7541 (remote_target::remote_notice_new_inferior): Update.
7542 (remote_target::add_current_inferior_and_thread): Update.
7543 * inferior.c (exit_inferior_1): Use "false".
7544 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7545
e242fd12
SM
75462019-04-09 Simon Marchi <simon.marchi@efficios.com>
7547
9ca1957f 7548 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
7549 the "start" command.
7550
2b0c8b01
KB
75512019-04-08 Kevin Buettner <kevinb@redhat.com>
7552
7553 * python/py-inferior.c (infpy_thread_from_thread_handle):
7554 Adjust comments to reflect renaming of thread_from_thread_handle
7555 to thread_from_handle. Adjust keywords. Fix type error message.
7556 (inferior_object_methods): Add thread_from_handle. Retain
7557 thread_from_thread_handle, but mark it as deprecated.
7558
50a82723
KB
75592019-04-08 Kevin Buettner <kevinb@redhat.com>
7560
7561 * gdbthread.h (find_thread_by_handle): Revise declaration.
7562 * thread.c (find_thread_by_handle): Likewise. Adjust
7563 implementation too.
7564 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7565 support for buffer objects as handles.
7566
cf63b016
KB
75672019-04-08 Kevin Buettner <kevinb@redhat.com>
7568
7569 * python/py-infthread.c (thpy_thread_handle): New function.
7570 (thread_object_methods): Register thpy_thread_handle.
7571
3d6c6204
KB
75722019-04-08 Kevin Buettner <kevinb@redhat.com>
7573
7574 * gdbthread.h (thread_to_thread_handle): Declare.
7575 * thread.c (gdbtypes.h): Include.
7576 (thread_to_thread_handle): New function.
7577
7578 * target.h (struct target_ops): Add thread_info_to_thread_handle.
7579 (target_thread_info_to_thread_handle): Declare.
7580 * target.c (target_thread_info_to_thread_handle): New function.
7581 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7582 * target-delegates.c: Regenerate.
7583
7584 * linux-thread-db.c (class thread_db_target): Add method
7585 thread_info_to_thread_handle.
7586 (thread_db_target::thread_info_to_thread_handle): Define.
7587 * remote.c (class remote_target): Add new method
7588 thread_info_to_thread_handle.
7589 (remote_target::thread_info_to_thread_handle): Define.
7590
56be6ea8
PA
75912019-04-08 Pedro Alves <palves@redhat.com>
7592
7593 * common/common-exceptions.c (throw_exception): Don't create
7594 named object to throw; throw directly.
7595 (throw_it): Likewise. Don't initialize gdb_exception::message
7596 here, with new; pass FMT and AP to the ctor instead.
7597 * common/common-exceptions.h: Include <string>.
7598 (gdb_exception::gdb_exception(enum return_reason, enum errors,
7599 const char *, va_list)): New ctor. Use std::make_shared.
7600 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7601 errors)): Delete.
7602 (gdb_exception_error::gdb_exception_error(enum errors, const char
7603 *, va_list)): New.
7604 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7605 Add assertion.
7606 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7607 errors)): Delete.
7608 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7609 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7610 Add assertion.
7611
eedc3f4f
TT
76122019-04-08 Tom Tromey <tom@tromey.com>
7613
7614 * valops.c (value_rtti_indirect_type): Replace throw_exception
7615 with throw.
7616 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7617 with throw.
7618 * thread.c (thr_try_catch_cmd): Replace throw_exception with
7619 throw.
7620 * target.c (target_translate_tls_address): Replace throw_exception
7621 with throw.
7622 * stack.c (frame_apply_command_count): Replace throw_exception
7623 with throw.
7624 * solib-spu.c (append_ocl_sos): Replace throw_exception with
7625 throw.
7626 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7627 with throw.
7628 * rs6000-tdep.c (rs6000_frame_cache)
7629 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7630 * remote.c: Replace throw_exception with throw.
7631 * record-full.c (record_full_message, record_full_wait_1)
7632 (record_full_restore): Replace throw_exception with throw.
7633 * record-btrace.c:
7634 (get_thread_current_frame_id, record_btrace_start_replaying)
7635 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7636 (cmd_record_btrace_start): Replace throw_exception with throw.
7637 * parse.c (parse_exp_in_context_1): Replace throw_exception with
7638 throw.
7639 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7640 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7641 * linespec.c:
7642 (find_linespec_symbols): Replace throw_exception with throw.
7643 * infrun.c (displaced_step_prepare, resume): Replace
7644 throw_exception with throw.
7645 * infcmd.c (post_create_inferior): Replace throw_exception with
7646 throw.
7647 * inf-loop.c (inferior_event_handler): Replace throw_exception
7648 with throw.
7649 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7650 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7651 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7652 (get_prev_frame_always, get_frame_pc_if_available)
7653 (get_frame_address_in_block_if_available, get_frame_language):
7654 Replace throw_exception with throw.
7655 * frame-unwind.c (frame_unwind_try_unwinder): Replace
7656 throw_exception with throw.
7657 * eval.c (fetch_subexp_value, evaluate_var_value)
7658 (evaluate_funcall, evaluate_subexp_standard): Replace
7659 throw_exception with throw.
7660 * dwarf2loc.c (call_site_find_chain)
7661 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7662 Replace throw_exception with throw.
7663 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7664 with throw.
7665 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7666 throw.
7667 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7668 * completer.c (complete_line_internal): Replace throw_exception
7669 with throw.
7670 * compile/compile-object-run.c (compile_object_run): Replace
7671 throw_exception with throw.
7672 * cli/cli-script.c (process_next_line): Replace throw_exception
7673 with throw.
7674 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7675 (btrace_enable, btrace_maint_update_pt_packets): Replace
7676 throw_exception with throw.
7677 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7678 throw_exception with throw.
7679 * break-catch-throw.c (re_set_exception_catchpoint): Replace
7680 throw_exception with throw.
7681 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7682 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7683 * aarch64-tdep.c (aarch64_make_prologue_cache)
7684 (aarch64_make_stub_cache): Replace throw_exception with throw.
7685
26003a20
TT
76862019-04-08 Tom Tromey <tom@tromey.com>
7687
7688 * common/common-exceptions.c (throw_exception): Rename from
7689 throw_exception_cxx. Remove old copy. Make argument const.
7690 (throw_it): Create and throw exception objects directly.
7691 * common/common-exceptions.h (throw_exception): Make argument
7692 const.
7693 (struct gdb_exception_error): Add constructor.
7694 (struct gdb_exception_quit): Add constructor.
7695
d272eb37
TT
76962019-04-08 Tom Tromey <tom@tromey.com>
7697
7698 * common/common-exceptions.h (exception_rethrow): Don't declare.
7699 (TRY_SJLJ): Update comment.
7700 (TRY, CATCH, END_CATCH): Remove.
7701 * common/common-exceptions.c (exception_rethrow): Remove.
7702
230d2906
TT
77032019-04-08 Tom Tromey <tom@tromey.com>
7704
7705 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7706 Remove.
7707 (gdb_exception_error): Rename from
7708 gdb_exception_RETURN_MASK_ERROR.
7709 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7710 (gdb_quit_bad_alloc): Update.
7711 * aarch64-tdep.c: Update.
7712 * ada-lang.c: Update.
7713 * ada-typeprint.c: Update.
7714 * ada-valprint.c: Update.
7715 * amd64-tdep.c: Update.
7716 * arch-utils.c: Update.
7717 * break-catch-throw.c: Update.
7718 * breakpoint.c: Update.
7719 * btrace.c: Update.
7720 * c-varobj.c: Update.
7721 * cli/cli-cmds.c: Update.
7722 * cli/cli-interp.c: Update.
7723 * cli/cli-script.c: Update.
7724 * common/common-exceptions.c: Update.
7725 * common/new-op.c: Update.
7726 * common/selftest.c: Update.
7727 * compile/compile-c-symbols.c: Update.
7728 * compile/compile-cplus-symbols.c: Update.
7729 * compile/compile-object-load.c: Update.
7730 * compile/compile-object-run.c: Update.
7731 * completer.c: Update.
7732 * corelow.c: Update.
7733 * cp-abi.c: Update.
7734 * cp-support.c: Update.
7735 * cp-valprint.c: Update.
7736 * darwin-nat.c: Update.
7737 * disasm-selftests.c: Update.
7738 * dtrace-probe.c: Update.
7739 * dwarf-index-cache.c: Update.
7740 * dwarf-index-write.c: Update.
7741 * dwarf2-frame-tailcall.c: Update.
7742 * dwarf2-frame.c: Update.
7743 * dwarf2loc.c: Update.
7744 * dwarf2read.c: Update.
7745 * eval.c: Update.
7746 * event-loop.c: Update.
7747 * event-top.c: Update.
7748 * exec.c: Update.
7749 * f-valprint.c: Update.
7750 * fbsd-tdep.c: Update.
7751 * frame-unwind.c: Update.
7752 * frame.c: Update.
7753 * gdbtypes.c: Update.
7754 * gnu-v3-abi.c: Update.
7755 * guile/guile-internal.h: Update.
7756 * guile/scm-block.c: Update.
7757 * guile/scm-breakpoint.c: Update.
7758 * guile/scm-cmd.c: Update.
7759 * guile/scm-disasm.c: Update.
7760 * guile/scm-frame.c: Update.
7761 * guile/scm-lazy-string.c: Update.
7762 * guile/scm-math.c: Update.
7763 * guile/scm-param.c: Update.
7764 * guile/scm-ports.c: Update.
7765 * guile/scm-pretty-print.c: Update.
7766 * guile/scm-symbol.c: Update.
7767 * guile/scm-symtab.c: Update.
7768 * guile/scm-type.c: Update.
7769 * guile/scm-value.c: Update.
7770 * i386-linux-tdep.c: Update.
7771 * i386-tdep.c: Update.
7772 * inf-loop.c: Update.
7773 * infcall.c: Update.
7774 * infcmd.c: Update.
7775 * infrun.c: Update.
7776 * jit.c: Update.
7777 * language.c: Update.
7778 * linespec.c: Update.
7779 * linux-fork.c: Update.
7780 * linux-nat.c: Update.
7781 * linux-tdep.c: Update.
7782 * linux-thread-db.c: Update.
7783 * main.c: Update.
7784 * mi/mi-cmd-break.c: Update.
7785 * mi/mi-cmd-stack.c: Update.
7786 * mi/mi-interp.c: Update.
7787 * mi/mi-main.c: Update.
7788 * objc-lang.c: Update.
7789 * p-valprint.c: Update.
7790 * parse.c: Update.
7791 * ppc-linux-tdep.c: Update.
7792 * printcmd.c: Update.
7793 * python/py-arch.c: Update.
7794 * python/py-breakpoint.c: Update.
7795 * python/py-cmd.c: Update.
7796 * python/py-finishbreakpoint.c: Update.
7797 * python/py-frame.c: Update.
7798 * python/py-framefilter.c: Update.
7799 * python/py-gdb-readline.c: Update.
7800 * python/py-inferior.c: Update.
7801 * python/py-infthread.c: Update.
7802 * python/py-lazy-string.c: Update.
7803 * python/py-linetable.c: Update.
7804 * python/py-objfile.c: Update.
7805 * python/py-param.c: Update.
7806 * python/py-prettyprint.c: Update.
7807 * python/py-progspace.c: Update.
7808 * python/py-record-btrace.c: Update.
7809 * python/py-record.c: Update.
7810 * python/py-symbol.c: Update.
7811 * python/py-type.c: Update.
7812 * python/py-unwind.c: Update.
7813 * python/py-utils.c: Update.
7814 * python/py-value.c: Update.
7815 * python/python.c: Update.
7816 * record-btrace.c: Update.
7817 * record-full.c: Update.
7818 * remote-fileio.c: Update.
7819 * remote.c: Update.
7820 * riscv-tdep.c: Update.
7821 * rs6000-aix-tdep.c: Update.
7822 * rs6000-tdep.c: Update.
7823 * rust-exp.y: Update.
7824 * rust-lang.c: Update.
7825 * s390-tdep.c: Update.
7826 * selftest-arch.c: Update.
7827 * solib-dsbt.c: Update.
7828 * solib-frv.c: Update.
7829 * solib-spu.c: Update.
7830 * solib-svr4.c: Update.
7831 * solib.c: Update.
7832 * sparc64-linux-tdep.c: Update.
7833 * stack.c: Update.
7834 * symfile-mem.c: Update.
7835 * symmisc.c: Update.
7836 * target.c: Update.
7837 * thread.c: Update.
7838 * top.c: Update.
7839 * tracefile-tfile.c: Update.
7840 * tui/tui.c: Update.
7841 * typeprint.c: Update.
7842 * unittests/cli-utils-selftests.c: Update.
7843 * unittests/parse-connection-spec-selftests.c: Update.
7844 * valops.c: Update.
7845 * valprint.c: Update.
7846 * value.c: Update.
7847 * varobj.c: Update.
7848 * windows-nat.c: Update.
7849 * x86-linux-nat.c: Update.
7850 * xml-support.c: Update.
7851
a70b8144
TT
78522019-04-08 Tom Tromey <tom@tromey.com>
7853
7854 * xml-support.c: Use C++ exception handling.
7855 * x86-linux-nat.c: Use C++ exception handling.
7856 * windows-nat.c: Use C++ exception handling.
7857 * varobj.c: Use C++ exception handling.
7858 * value.c: Use C++ exception handling.
7859 * valprint.c: Use C++ exception handling.
7860 * valops.c: Use C++ exception handling.
7861 * unittests/parse-connection-spec-selftests.c: Use C++ exception
7862 handling.
7863 * unittests/cli-utils-selftests.c: Use C++ exception handling.
7864 * typeprint.c: Use C++ exception handling.
7865 * tui/tui.c: Use C++ exception handling.
7866 * tracefile-tfile.c: Use C++ exception handling.
7867 * top.c: Use C++ exception handling.
7868 * thread.c: Use C++ exception handling.
7869 * target.c: Use C++ exception handling.
7870 * symmisc.c: Use C++ exception handling.
7871 * symfile-mem.c: Use C++ exception handling.
7872 * stack.c: Use C++ exception handling.
7873 * sparc64-linux-tdep.c: Use C++ exception handling.
7874 * solib.c: Use C++ exception handling.
7875 * solib-svr4.c: Use C++ exception handling.
7876 * solib-spu.c: Use C++ exception handling.
7877 * solib-frv.c: Use C++ exception handling.
7878 * solib-dsbt.c: Use C++ exception handling.
7879 * selftest-arch.c: Use C++ exception handling.
7880 * s390-tdep.c: Use C++ exception handling.
7881 * rust-lang.c: Use C++ exception handling.
7882 * rust-exp.y: Use C++ exception handling.
7883 * rs6000-tdep.c: Use C++ exception handling.
7884 * rs6000-aix-tdep.c: Use C++ exception handling.
7885 * riscv-tdep.c: Use C++ exception handling.
7886 * remote.c: Use C++ exception handling.
7887 * remote-fileio.c: Use C++ exception handling.
7888 * record-full.c: Use C++ exception handling.
7889 * record-btrace.c: Use C++ exception handling.
7890 * python/python.c: Use C++ exception handling.
7891 * python/py-value.c: Use C++ exception handling.
7892 * python/py-utils.c: Use C++ exception handling.
7893 * python/py-unwind.c: Use C++ exception handling.
7894 * python/py-type.c: Use C++ exception handling.
7895 * python/py-symbol.c: Use C++ exception handling.
7896 * python/py-record.c: Use C++ exception handling.
7897 * python/py-record-btrace.c: Use C++ exception handling.
7898 * python/py-progspace.c: Use C++ exception handling.
7899 * python/py-prettyprint.c: Use C++ exception handling.
7900 * python/py-param.c: Use C++ exception handling.
7901 * python/py-objfile.c: Use C++ exception handling.
7902 * python/py-linetable.c: Use C++ exception handling.
7903 * python/py-lazy-string.c: Use C++ exception handling.
7904 * python/py-infthread.c: Use C++ exception handling.
7905 * python/py-inferior.c: Use C++ exception handling.
7906 * python/py-gdb-readline.c: Use C++ exception handling.
7907 * python/py-framefilter.c: Use C++ exception handling.
7908 * python/py-frame.c: Use C++ exception handling.
7909 * python/py-finishbreakpoint.c: Use C++ exception handling.
7910 * python/py-cmd.c: Use C++ exception handling.
7911 * python/py-breakpoint.c: Use C++ exception handling.
7912 * python/py-arch.c: Use C++ exception handling.
7913 * printcmd.c: Use C++ exception handling.
7914 * ppc-linux-tdep.c: Use C++ exception handling.
7915 * parse.c: Use C++ exception handling.
7916 * p-valprint.c: Use C++ exception handling.
7917 * objc-lang.c: Use C++ exception handling.
7918 * mi/mi-main.c: Use C++ exception handling.
7919 * mi/mi-interp.c: Use C++ exception handling.
7920 * mi/mi-cmd-stack.c: Use C++ exception handling.
7921 * mi/mi-cmd-break.c: Use C++ exception handling.
7922 * main.c: Use C++ exception handling.
7923 * linux-thread-db.c: Use C++ exception handling.
7924 * linux-tdep.c: Use C++ exception handling.
7925 * linux-nat.c: Use C++ exception handling.
7926 * linux-fork.c: Use C++ exception handling.
7927 * linespec.c: Use C++ exception handling.
7928 * language.c: Use C++ exception handling.
7929 * jit.c: Use C++ exception handling.
7930 * infrun.c: Use C++ exception handling.
7931 * infcmd.c: Use C++ exception handling.
7932 * infcall.c: Use C++ exception handling.
7933 * inf-loop.c: Use C++ exception handling.
7934 * i386-tdep.c: Use C++ exception handling.
7935 * i386-linux-tdep.c: Use C++ exception handling.
7936 * guile/scm-value.c: Use C++ exception handling.
7937 * guile/scm-type.c: Use C++ exception handling.
7938 * guile/scm-symtab.c: Use C++ exception handling.
7939 * guile/scm-symbol.c: Use C++ exception handling.
7940 * guile/scm-pretty-print.c: Use C++ exception handling.
7941 * guile/scm-ports.c: Use C++ exception handling.
7942 * guile/scm-param.c: Use C++ exception handling.
7943 * guile/scm-math.c: Use C++ exception handling.
7944 * guile/scm-lazy-string.c: Use C++ exception handling.
7945 * guile/scm-frame.c: Use C++ exception handling.
7946 * guile/scm-disasm.c: Use C++ exception handling.
7947 * guile/scm-cmd.c: Use C++ exception handling.
7948 * guile/scm-breakpoint.c: Use C++ exception handling.
7949 * guile/scm-block.c: Use C++ exception handling.
7950 * guile/guile-internal.h: Use C++ exception handling.
7951 * gnu-v3-abi.c: Use C++ exception handling.
7952 * gdbtypes.c: Use C++ exception handling.
7953 * frame.c: Use C++ exception handling.
7954 * frame-unwind.c: Use C++ exception handling.
7955 * fbsd-tdep.c: Use C++ exception handling.
7956 * f-valprint.c: Use C++ exception handling.
7957 * exec.c: Use C++ exception handling.
7958 * event-top.c: Use C++ exception handling.
7959 * event-loop.c: Use C++ exception handling.
7960 * eval.c: Use C++ exception handling.
7961 * dwarf2read.c: Use C++ exception handling.
7962 * dwarf2loc.c: Use C++ exception handling.
7963 * dwarf2-frame.c: Use C++ exception handling.
7964 * dwarf2-frame-tailcall.c: Use C++ exception handling.
7965 * dwarf-index-write.c: Use C++ exception handling.
7966 * dwarf-index-cache.c: Use C++ exception handling.
7967 * dtrace-probe.c: Use C++ exception handling.
7968 * disasm-selftests.c: Use C++ exception handling.
7969 * darwin-nat.c: Use C++ exception handling.
7970 * cp-valprint.c: Use C++ exception handling.
7971 * cp-support.c: Use C++ exception handling.
7972 * cp-abi.c: Use C++ exception handling.
7973 * corelow.c: Use C++ exception handling.
7974 * completer.c: Use C++ exception handling.
7975 * compile/compile-object-run.c: Use C++ exception handling.
7976 * compile/compile-object-load.c: Use C++ exception handling.
7977 * compile/compile-cplus-symbols.c: Use C++ exception handling.
7978 * compile/compile-c-symbols.c: Use C++ exception handling.
7979 * common/selftest.c: Use C++ exception handling.
7980 * common/new-op.c: Use C++ exception handling.
7981 * cli/cli-script.c: Use C++ exception handling.
7982 * cli/cli-interp.c: Use C++ exception handling.
7983 * cli/cli-cmds.c: Use C++ exception handling.
7984 * c-varobj.c: Use C++ exception handling.
7985 * btrace.c: Use C++ exception handling.
7986 * breakpoint.c: Use C++ exception handling.
7987 * break-catch-throw.c: Use C++ exception handling.
7988 * arch-utils.c: Use C++ exception handling.
7989 * amd64-tdep.c: Use C++ exception handling.
7990 * ada-valprint.c: Use C++ exception handling.
7991 * ada-typeprint.c: Use C++ exception handling.
7992 * ada-lang.c: Use C++ exception handling.
7993 * aarch64-tdep.c: Use C++ exception handling.
7994
3d6e9d23
TT
79952019-04-08 Tom Tromey <tom@tromey.com>
7996
7997 * xml-support.c (gdb_xml_parser::parse): Update.
7998 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7999 * value.c (show_convenience): Update.
8000 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8001 (test_parse_flags_qcs): Update.
8002 * thread.c (thr_try_catch_cmd): Update.
8003 * target.c (target_translate_tls_address): Update.
8004 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8005 (info_frame_command_core, frame_apply_command_count): Update.
8006 * rust-exp.y (rust_lex_exception_test): Update.
8007 * riscv-tdep.c (riscv_print_one_register_info): Update.
8008 * remote.c (remote_target::enable_btrace): Update.
8009 * record-btrace.c (record_btrace_enable_warn): Update.
8010 * python/py-utils.c (gdbpy_convert_exception): Update.
8011 * printcmd.c (do_one_display, print_variable_and_value): Update.
8012 * mi/mi-main.c (mi_print_exception): Update.
8013 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8014 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8015 * linux-nat.c (linux_nat_target::attach): Update.
8016 * linux-fork.c (class scoped_switch_fork_info): Update.
8017 * infrun.c (displaced_step_prepare): Update.
8018 * infcall.c (call_function_by_hand_dummy): Update.
8019 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8020 * gnu-v3-abi.c (print_one_vtable): Update.
8021 * frame.c (get_prev_frame_always): Update.
8022 * f-valprint.c (info_common_command_for_block): Update.
8023 * exec.c (try_open_exec_file): Update.
8024 * exceptions.c (print_exception, exception_print)
8025 (exception_fprintf, exception_print_same): Update.
8026 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8027 * dwarf-index-cache.c (index_cache::store)
8028 (index_cache::lookup_gdb_index): Update.
8029 * darwin-nat.c (maybe_cache_shell): Update.
8030 * cp-valprint.c (cp_print_value_fields): Update.
8031 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8032 (gcc_cplus_symbol_address): Update.
8033 * compile/compile-c-symbols.c (gcc_convert_symbol)
8034 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8035 * common/selftest.c: Update.
8036 * common/common-exceptions.h (struct gdb_exception) <message>: Now
8037 a std::string.
8038 (exception_try_scope_entry, exception_try_scope_exit): Don't
8039 declare.
8040 (struct exception_try_scope): Remove.
8041 (TRY): Don't use exception_try_scope.
8042 (struct gdb_exception): Add constructor, operator=.
8043 <what>: New method.
8044 (struct gdb_exception_RETURN_MASK_ALL)
8045 (struct gdb_exception_RETURN_MASK_ERROR)
8046 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8047 (struct gdb_quit_bad_alloc): Update.
8048 * common/common-exceptions.c (exception_none): Change
8049 initializer.
8050 (struct catcher) <state, exception>: Initialize inline.
8051 <prev>: Remove member.
8052 (current_catcher): Remove.
8053 (catchers): New global.
8054 (exceptions_state_mc_init): Simplify.
8055 (catcher_pop): Remove.
8056 (exceptions_state_mc, exceptions_state_mc_catch): Update.
8057 (try_scope_depth, exception_try_scope_entry)
8058 (exception_try_scope_exit): Remove.
8059 (throw_exception_sjlj): Update.
8060 (exception_messages, exception_messages_size): Remove.
8061 (throw_it): Simplify.
8062 (gdb_exception_sliced_copy): Remove.
8063 (throw_exception_cxx): Update.
8064 * cli/cli-script.c (script_from_file): Update.
8065 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8066 Update.
8067 * ada-valprint.c (ada_val_print): Update.
8068 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8069 (create_excep_cond_exprs): Update.
8070
c5c10118
TT
80712019-04-08 Tom Tromey <tom@tromey.com>
8072
8073 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8074 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8075 (TRY, CATCH, END_CATCH): Remove some definitions.
8076 * common/common-exceptions.c: Don't use GDB_XCPT.
8077 (catcher_list_size): Remove.
8078 (throw_exception, throw_it): Simplify.
8079
4de283e4
TT
80802019-04-05 Tom Tromey <tom@tromey.com>
8081
8082 Revert the header-sorting patch.
8083 * ft32-tdep.c: Revert.
8084 * frv-tdep.c: Revert.
8085 * frv-linux-tdep.c: Revert.
8086 * frame.c: Revert.
8087 * frame-unwind.c: Revert.
8088 * frame-base.c: Revert.
8089 * fork-child.c: Revert.
8090 * findvar.c: Revert.
8091 * findcmd.c: Revert.
8092 * filesystem.c: Revert.
8093 * filename-seen-cache.h: Revert.
8094 * filename-seen-cache.c: Revert.
8095 * fbsd-tdep.c: Revert.
8096 * fbsd-nat.h: Revert.
8097 * fbsd-nat.c: Revert.
8098 * f-valprint.c: Revert.
8099 * f-typeprint.c: Revert.
8100 * f-lang.c: Revert.
8101 * extension.h: Revert.
8102 * extension.c: Revert.
8103 * extension-priv.h: Revert.
8104 * expprint.c: Revert.
8105 * exec.h: Revert.
8106 * exec.c: Revert.
8107 * exceptions.c: Revert.
8108 * event-top.c: Revert.
8109 * event-loop.c: Revert.
8110 * eval.c: Revert.
8111 * elfread.c: Revert.
8112 * dwarf2read.h: Revert.
8113 * dwarf2read.c: Revert.
8114 * dwarf2loc.c: Revert.
8115 * dwarf2expr.h: Revert.
8116 * dwarf2expr.c: Revert.
8117 * dwarf2-frame.c: Revert.
8118 * dwarf2-frame-tailcall.c: Revert.
8119 * dwarf-index-write.h: Revert.
8120 * dwarf-index-write.c: Revert.
8121 * dwarf-index-common.c: Revert.
8122 * dwarf-index-cache.h: Revert.
8123 * dwarf-index-cache.c: Revert.
8124 * dummy-frame.c: Revert.
8125 * dtrace-probe.c: Revert.
8126 * disasm.h: Revert.
8127 * disasm.c: Revert.
8128 * disasm-selftests.c: Revert.
8129 * dictionary.c: Revert.
8130 * dicos-tdep.c: Revert.
8131 * demangle.c: Revert.
8132 * dcache.h: Revert.
8133 * dcache.c: Revert.
8134 * darwin-nat.h: Revert.
8135 * darwin-nat.c: Revert.
8136 * darwin-nat-info.c: Revert.
8137 * d-valprint.c: Revert.
8138 * d-namespace.c: Revert.
8139 * d-lang.c: Revert.
8140 * ctf.c: Revert.
8141 * csky-tdep.c: Revert.
8142 * csky-linux-tdep.c: Revert.
8143 * cris-tdep.c: Revert.
8144 * cris-linux-tdep.c: Revert.
8145 * cp-valprint.c: Revert.
8146 * cp-support.c: Revert.
8147 * cp-namespace.c: Revert.
8148 * cp-abi.c: Revert.
8149 * corelow.c: Revert.
8150 * corefile.c: Revert.
8151 * continuations.c: Revert.
8152 * completer.h: Revert.
8153 * completer.c: Revert.
8154 * complaints.c: Revert.
8155 * coffread.c: Revert.
8156 * coff-pe-read.c: Revert.
8157 * cli-out.h: Revert.
8158 * cli-out.c: Revert.
8159 * charset.c: Revert.
8160 * c-varobj.c: Revert.
8161 * c-valprint.c: Revert.
8162 * c-typeprint.c: Revert.
8163 * c-lang.c: Revert.
8164 * buildsym.c: Revert.
8165 * buildsym-legacy.c: Revert.
8166 * build-id.h: Revert.
8167 * build-id.c: Revert.
8168 * btrace.c: Revert.
8169 * bsd-uthread.c: Revert.
8170 * breakpoint.h: Revert.
8171 * breakpoint.c: Revert.
8172 * break-catch-throw.c: Revert.
8173 * break-catch-syscall.c: Revert.
8174 * break-catch-sig.c: Revert.
8175 * blockframe.c: Revert.
8176 * block.c: Revert.
8177 * bfin-tdep.c: Revert.
8178 * bfin-linux-tdep.c: Revert.
8179 * bfd-target.c: Revert.
8180 * bcache.c: Revert.
8181 * ax-general.c: Revert.
8182 * ax-gdb.h: Revert.
8183 * ax-gdb.c: Revert.
8184 * avr-tdep.c: Revert.
8185 * auxv.c: Revert.
8186 * auto-load.c: Revert.
8187 * arm-wince-tdep.c: Revert.
8188 * arm-tdep.c: Revert.
8189 * arm-symbian-tdep.c: Revert.
8190 * arm-pikeos-tdep.c: Revert.
8191 * arm-obsd-tdep.c: Revert.
8192 * arm-nbsd-tdep.c: Revert.
8193 * arm-nbsd-nat.c: Revert.
8194 * arm-linux-tdep.c: Revert.
8195 * arm-linux-nat.c: Revert.
8196 * arm-fbsd-tdep.c: Revert.
8197 * arm-fbsd-nat.c: Revert.
8198 * arm-bsd-tdep.c: Revert.
8199 * arch-utils.c: Revert.
8200 * arc-tdep.c: Revert.
8201 * arc-newlib-tdep.c: Revert.
8202 * annotate.h: Revert.
8203 * annotate.c: Revert.
8204 * amd64-windows-tdep.c: Revert.
8205 * amd64-windows-nat.c: Revert.
8206 * amd64-tdep.c: Revert.
8207 * amd64-sol2-tdep.c: Revert.
8208 * amd64-obsd-tdep.c: Revert.
8209 * amd64-obsd-nat.c: Revert.
8210 * amd64-nbsd-tdep.c: Revert.
8211 * amd64-nbsd-nat.c: Revert.
8212 * amd64-nat.c: Revert.
8213 * amd64-linux-tdep.c: Revert.
8214 * amd64-linux-nat.c: Revert.
8215 * amd64-fbsd-tdep.c: Revert.
8216 * amd64-fbsd-nat.c: Revert.
8217 * amd64-dicos-tdep.c: Revert.
8218 * amd64-darwin-tdep.c: Revert.
8219 * amd64-bsd-nat.c: Revert.
8220 * alpha-tdep.c: Revert.
8221 * alpha-obsd-tdep.c: Revert.
8222 * alpha-nbsd-tdep.c: Revert.
8223 * alpha-mdebug-tdep.c: Revert.
8224 * alpha-linux-tdep.c: Revert.
8225 * alpha-linux-nat.c: Revert.
8226 * alpha-bsd-tdep.c: Revert.
8227 * alpha-bsd-nat.c: Revert.
8228 * aix-thread.c: Revert.
8229 * agent.c: Revert.
8230 * addrmap.c: Revert.
8231 * ada-varobj.c: Revert.
8232 * ada-valprint.c: Revert.
8233 * ada-typeprint.c: Revert.
8234 * ada-tasks.c: Revert.
8235 * ada-lang.c: Revert.
8236 * aarch64-tdep.c: Revert.
8237 * aarch64-ravenscar-thread.c: Revert.
8238 * aarch64-newlib-tdep.c: Revert.
8239 * aarch64-linux-tdep.c: Revert.
8240 * aarch64-linux-nat.c: Revert.
8241 * aarch64-fbsd-tdep.c: Revert.
8242 * aarch64-fbsd-nat.c: Revert.
8243 * aarch32-linux-nat.c: Revert.
8244
d55e5aa6
TT
82452019-04-05 Tom Tromey <tom@tromey.com>
8246
8247 * ft32-tdep.c: Sort headers.
8248 * frv-tdep.c: Sort headers.
8249 * frv-linux-tdep.c: Sort headers.
8250 * frame.c: Sort headers.
8251 * frame-unwind.c: Sort headers.
8252 * frame-base.c: Sort headers.
8253 * fork-child.c: Sort headers.
8254 * findvar.c: Sort headers.
8255 * findcmd.c: Sort headers.
8256 * filesystem.c: Sort headers.
8257 * filename-seen-cache.h: Sort headers.
8258 * filename-seen-cache.c: Sort headers.
8259 * fbsd-tdep.c: Sort headers.
8260 * fbsd-nat.h: Sort headers.
8261 * fbsd-nat.c: Sort headers.
8262 * f-valprint.c: Sort headers.
8263 * f-typeprint.c: Sort headers.
8264 * f-lang.c: Sort headers.
8265 * extension.h: Sort headers.
8266 * extension.c: Sort headers.
8267 * extension-priv.h: Sort headers.
8268 * expprint.c: Sort headers.
8269 * exec.h: Sort headers.
8270 * exec.c: Sort headers.
8271 * exceptions.c: Sort headers.
8272 * event-top.c: Sort headers.
8273 * event-loop.c: Sort headers.
8274 * eval.c: Sort headers.
8275 * elfread.c: Sort headers.
8276 * dwarf2read.h: Sort headers.
8277 * dwarf2read.c: Sort headers.
8278 * dwarf2loc.c: Sort headers.
8279 * dwarf2expr.h: Sort headers.
8280 * dwarf2expr.c: Sort headers.
8281 * dwarf2-frame.c: Sort headers.
8282 * dwarf2-frame-tailcall.c: Sort headers.
8283 * dwarf-index-write.h: Sort headers.
8284 * dwarf-index-write.c: Sort headers.
8285 * dwarf-index-common.c: Sort headers.
8286 * dwarf-index-cache.h: Sort headers.
8287 * dwarf-index-cache.c: Sort headers.
8288 * dummy-frame.c: Sort headers.
8289 * dtrace-probe.c: Sort headers.
8290 * disasm.h: Sort headers.
8291 * disasm.c: Sort headers.
8292 * disasm-selftests.c: Sort headers.
8293 * dictionary.c: Sort headers.
8294 * dicos-tdep.c: Sort headers.
8295 * demangle.c: Sort headers.
8296 * dcache.h: Sort headers.
8297 * dcache.c: Sort headers.
8298 * darwin-nat.h: Sort headers.
8299 * darwin-nat.c: Sort headers.
8300 * darwin-nat-info.c: Sort headers.
8301 * d-valprint.c: Sort headers.
8302 * d-namespace.c: Sort headers.
8303 * d-lang.c: Sort headers.
8304 * ctf.c: Sort headers.
8305 * csky-tdep.c: Sort headers.
8306 * csky-linux-tdep.c: Sort headers.
8307 * cris-tdep.c: Sort headers.
8308 * cris-linux-tdep.c: Sort headers.
8309 * cp-valprint.c: Sort headers.
8310 * cp-support.c: Sort headers.
8311 * cp-namespace.c: Sort headers.
8312 * cp-abi.c: Sort headers.
8313 * corelow.c: Sort headers.
8314 * corefile.c: Sort headers.
8315 * continuations.c: Sort headers.
8316 * completer.h: Sort headers.
8317 * completer.c: Sort headers.
8318 * complaints.c: Sort headers.
8319 * coffread.c: Sort headers.
8320 * coff-pe-read.c: Sort headers.
8321 * cli-out.h: Sort headers.
8322 * cli-out.c: Sort headers.
8323 * charset.c: Sort headers.
8324 * c-varobj.c: Sort headers.
8325 * c-valprint.c: Sort headers.
8326 * c-typeprint.c: Sort headers.
8327 * c-lang.c: Sort headers.
8328 * buildsym.c: Sort headers.
8329 * buildsym-legacy.c: Sort headers.
8330 * build-id.h: Sort headers.
8331 * build-id.c: Sort headers.
8332 * btrace.c: Sort headers.
8333 * bsd-uthread.c: Sort headers.
8334 * breakpoint.h: Sort headers.
8335 * breakpoint.c: Sort headers.
8336 * break-catch-throw.c: Sort headers.
8337 * break-catch-syscall.c: Sort headers.
8338 * break-catch-sig.c: Sort headers.
8339 * blockframe.c: Sort headers.
8340 * block.c: Sort headers.
8341 * bfin-tdep.c: Sort headers.
8342 * bfin-linux-tdep.c: Sort headers.
8343 * bfd-target.c: Sort headers.
8344 * bcache.c: Sort headers.
8345 * ax-general.c: Sort headers.
8346 * ax-gdb.h: Sort headers.
8347 * ax-gdb.c: Sort headers.
8348 * avr-tdep.c: Sort headers.
8349 * auxv.c: Sort headers.
8350 * auto-load.c: Sort headers.
8351 * arm-wince-tdep.c: Sort headers.
8352 * arm-tdep.c: Sort headers.
8353 * arm-symbian-tdep.c: Sort headers.
8354 * arm-pikeos-tdep.c: Sort headers.
8355 * arm-obsd-tdep.c: Sort headers.
8356 * arm-nbsd-tdep.c: Sort headers.
8357 * arm-nbsd-nat.c: Sort headers.
8358 * arm-linux-tdep.c: Sort headers.
8359 * arm-linux-nat.c: Sort headers.
8360 * arm-fbsd-tdep.c: Sort headers.
8361 * arm-fbsd-nat.c: Sort headers.
8362 * arm-bsd-tdep.c: Sort headers.
8363 * arch-utils.c: Sort headers.
8364 * arc-tdep.c: Sort headers.
8365 * arc-newlib-tdep.c: Sort headers.
8366 * annotate.h: Sort headers.
8367 * annotate.c: Sort headers.
8368 * amd64-windows-tdep.c: Sort headers.
8369 * amd64-windows-nat.c: Sort headers.
8370 * amd64-tdep.c: Sort headers.
8371 * amd64-sol2-tdep.c: Sort headers.
8372 * amd64-obsd-tdep.c: Sort headers.
8373 * amd64-obsd-nat.c: Sort headers.
8374 * amd64-nbsd-tdep.c: Sort headers.
8375 * amd64-nbsd-nat.c: Sort headers.
8376 * amd64-nat.c: Sort headers.
8377 * amd64-linux-tdep.c: Sort headers.
8378 * amd64-linux-nat.c: Sort headers.
8379 * amd64-fbsd-tdep.c: Sort headers.
8380 * amd64-fbsd-nat.c: Sort headers.
8381 * amd64-dicos-tdep.c: Sort headers.
8382 * amd64-darwin-tdep.c: Sort headers.
8383 * amd64-bsd-nat.c: Sort headers.
8384 * alpha-tdep.c: Sort headers.
8385 * alpha-obsd-tdep.c: Sort headers.
8386 * alpha-nbsd-tdep.c: Sort headers.
8387 * alpha-mdebug-tdep.c: Sort headers.
8388 * alpha-linux-tdep.c: Sort headers.
8389 * alpha-linux-nat.c: Sort headers.
8390 * alpha-bsd-tdep.c: Sort headers.
8391 * alpha-bsd-nat.c: Sort headers.
8392 * aix-thread.c: Sort headers.
8393 * agent.c: Sort headers.
8394 * addrmap.c: Sort headers.
8395 * ada-varobj.c: Sort headers.
8396 * ada-valprint.c: Sort headers.
8397 * ada-typeprint.c: Sort headers.
8398 * ada-tasks.c: Sort headers.
8399 * ada-lang.c: Sort headers.
8400 * aarch64-tdep.c: Sort headers.
8401 * aarch64-ravenscar-thread.c: Sort headers.
8402 * aarch64-newlib-tdep.c: Sort headers.
8403 * aarch64-linux-tdep.c: Sort headers.
8404 * aarch64-linux-nat.c: Sort headers.
8405 * aarch64-fbsd-tdep.c: Sort headers.
8406 * aarch64-fbsd-nat.c: Sort headers.
8407 * aarch32-linux-nat.c: Sort headers.
8408
699bd4cf
TT
84092019-04-04 Tom Tromey <tom@tromey.com>
8410
8411 * varobj.c (varobj_create): Update.
8412 * rust-exp.y (struct rust_parser) <update_innermost_block,
8413 lookup_symbol>: New methods.
8414 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8415 Rename.
8416 (rust_parser::rust_lookup_type)
8417 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8418 * printcmd.c (display_command, do_one_display): Update.
8419 * parser-defs.h (struct parser_state) <parser_state>: Add
8420 "tracker" parameter.
8421 (block_tracker): New member.
8422 (class innermost_block_tracker) <innermost_block_tracker>: Add
8423 "types" parameter.
8424 <reset>: Remove method.
8425 (innermost_block): Don't declare.
8426 (null_post_parser): Update.
8427 * parse.c (innermost_block): Remove global.
8428 (write_dollar_variable): Update.
8429 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8430 Remove "tracker_types" parameter.
8431 (parse_expression): Add "tracker" parameter.
8432 (parse_expression_for_completion): Update.
8433 (null_post_parser): Add "tracker" parameter.
8434 * p-exp.y: Update rules.
8435 * m2-exp.y: Update rules.
8436 * language.h (struct language_defn) <la_post_parser>: Add
8437 "tracker" parameter.
8438 * go-exp.y: Update rules.
8439 * f-exp.y: Update rules.
8440 * expression.h (parse_expression, parse_exp_1): Add "tracker"
8441 parameter.
8442 * d-exp.y: Update rules.
8443 * c-exp.y: Update rules.
8444 * breakpoint.c (set_breakpoint_condition): Create an
8445 innermost_block_tracker.
8446 (watch_command_1): Likewise.
8447 * ada-lang.c (resolve): Add "tracker" parameter.
8448 (resolve_subexp): Likewise.
8449 * ada-exp.y (write_var_from_sym): Update.
8450
dac43e32
TT
84512019-04-04 Tom Tromey <tom@tromey.com>
8452
8453 * type-stack.h: New file.
8454 * type-stack.c: New file.
8455 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8456 type-stack.h.
8457 (insert_into_type_stack, insert_type, push_type, push_type_int)
8458 (insert_type_address_space, pop_type, pop_type_int)
8459 (pop_typelist, pop_type_stack, append_type_stack)
8460 (push_type_stack, get_type_stack, push_typelist)
8461 (follow_type_instance_flags, follow_types): Don't declare.
8462 * parse.c (type_stack): Remove global.
8463 (parse_exp_in_context): Update.
8464 (insert_into_type_stack, insert_type, push_type, push_type_int)
8465 (insert_type_address_space, pop_type, pop_type_int)
8466 (pop_typelist, pop_type_stack, append_type_stack)
8467 (push_type_stack, get_type_stack, push_typelist)
8468 (follow_type_instance_flags, follow_types): Remove (moved to
8469 type-stack.c).
8470 * f-exp.y (type_stack): New global.
8471 Update rules.
8472 (push_kind_type, f_parse): Update.
8473 * d-exp.y (type_stack): New global.
8474 Update rules.
8475 (d_parse): Update.
8476 * c-exp.y (struct c_parse_state) <type_stack>: New member.
8477 Update rules.
8478 * Makefile.in (COMMON_SFILES): Add type-stack.c.
8479 (HFILES_NO_SRCDIR): Add type-stack.h.
8480
2a612529
TT
84812019-04-04 Tom Tromey <tom@tromey.com>
8482
8483 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8484 (rust_parser::convert_ast_to_expression, rust_parse)
8485 (rust_lex_test_completion, rust_lex_tests): Update.
8486 * parser-defs.h (struct expr_completion_state): New.
8487 (struct parser_state) <parser_state>: Add completion parameter.
8488 <mark_struct_expression, mark_completion_tag>: New methods.
8489 <parse_completion, m_completion_state>: New members.
8490 (prefixify_expression, null_post_parser): Update.
8491 (mark_struct_expression, mark_completion_tag): Don't declare.
8492 * parse.c (parse_completion, expout_last_struct)
8493 (expout_tag_completion_type, expout_completion_name): Remove
8494 globals.
8495 (parser_state::mark_struct_expression)
8496 (parser_state::mark_completion_tag): Now methods.
8497 (prefixify_expression): Add last_struct parameter.
8498 (prefixify_subexp): Likewise.
8499 (parse_exp_1): Update.
8500 (parse_exp_in_context): Add cstate parameter. Update.
8501 (parse_expression_for_completion): Create an
8502 expr_completion_state.
8503 (null_post_parser): Add "completion" parameter.
8504 * p-exp.y: Update rules.
8505 (yylex): Update.
8506 * language.h (struct language_defn) <la_post_parser>: Add
8507 "completing" parameter.
8508 * go-exp.y: Update rules.
8509 (lex_one_token): Update.
8510 * expression.h (parse_completion): Don't declare.
8511 * d-exp.y: Update rules.
8512 (lex_one_token): Update rules.
8513 * c-exp.y: Update rules.
8514 (lex_one_token): Update.
8515 * ada-lang.c (resolve): Add "parse_completion" parameter.
8516 (resolve_subexp): Likewise.
8517 (ada_resolve_function): Likewise.
8518
43476f0b
TT
85192019-04-04 Tom Tromey <tom@tromey.com>
8520
8521 * parser-defs.h (struct parser_state) <start_arglist,
8522 end_arglist>: New methods.
8523 <arglist_len, m_funcall_chain>: New members.
8524 (arglist_len, start_arglist, end_arglist): Don't declare.
8525 * parse.c (arglist_len, funcall_chain): Remove global.
8526 (start_arglist, end_arglist): Remove functions.
8527 (parse_exp_in_context): Update.
8528 * p-exp.y: Update rules.
8529 * m2-exp.y: Update rules.
8530 * go-exp.y: Update rules.
8531 * f-exp.y: Update rules.
8532 * d-exp.y: Update rules.
8533 * c-exp.y: Update rules.
8534
5776fca3
TT
85352019-04-04 Tom Tromey <tom@tromey.com>
8536
8537 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8538 lex_operator, push_back>: New methods.
8539 Update all rules.
8540 (rust_parser::lex_hex, lex_escape): Rename and update.
8541 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8542 (rust_parser::lex_operator): Rename and update.
8543 (rust_parser::lex_number, rustyylex, rustyyerror)
8544 (rust_lex_test_init, rust_lex_test_sequence)
8545 (rust_lex_test_push_back, rust_lex_tests): Update.
8546 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8547 parameter.
8548 <lexptr, prev_lexptr>: New members.
8549 (lexptr, prev_lexptr): Don't declare.
8550 * parse.c (lexptr, prev_lexptr): Remove globals.
8551 (parse_exp_in_context): Update.
8552 * p-exp.y (yylex, yyerror): Update.
8553 * m2-exp.y (parse_number, yylex, yyerror): Update.
8554 * go-exp.y (lex_one_token, yyerror): Update.
8555 * f-exp.y (match_string_literal, yylex, yyerror): Update.
8556 * d-exp.y (lex_one_token, yyerror): Update.
8557 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8558 (lex_one_token, yyerror): Update.
8559 * ada-lex.l (YY_INPUT): Update.
8560 (rewind_to_char): Update.
8561 * ada-exp.y (yyerror): Update.
8562
8621b685
TT
85632019-04-04 Tom Tromey <tom@tromey.com>
8564
8565 * rust-exp.y (rustyylex, rust_lex_tests): Update.
8566 * parser-defs.h (struct parser_state) <parser_state>: Add new
8567 parameter.
8568 <comma_terminates>: New member.
8569 (comma_terminates): Don't declare global.
8570 * parse.c (comma_terminates): Remove global.
8571 (parse_exp_in_context): Update.
8572 * p-exp.y (yylex): Update.
8573 * m2-exp.y (yylex): Update.
8574 * go-exp.y (lex_one_token): Update.
8575 * f-exp.y (yylex): Update.
8576 * d-exp.y (lex_one_token): Update.
8577 * c-exp.y (lex_one_token): Update.
8578 * ada-lex.l: Update.
8579
28aaf3fd
TT
85802019-04-04 Tom Tromey <tom@tromey.com>
8581
8582 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8583 (rustyylex, rust_lex_test_init, rust_lex_test_one)
8584 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8585 * parser-defs.h (paren_depth): Don't declare.
8586 * parse.c (paren_depth): Remove global.
8587 (parse_exp_in_context): Update.
8588 * p-exp.y (paren_depth): New global.
8589 (pascal_parse): Initialize it.
8590 * m2-exp.y (paren_depth): New global.
8591 (m2_parse): Initialize it.
8592 * go-exp.y (paren_depth): New global.
8593 (go_parse): Initialize it.
8594 * f-exp.y (paren_depth): New global.
8595 (f_parse): Initialize it.
8596 * d-exp.y (paren_depth): New global.
8597 (d_parse): Initialize it.
8598 * c-exp.y (paren_depth): New global.
8599 (c_parse): Initialize it.
8600 * ada-lex.l (paren_depth): New global.
8601 (lexer_init): Initialize it.
8602
1e58a4a4
TT
86032019-04-04 Tom Tromey <tom@tromey.com>
8604
8605 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8606 (rust_parser::convert_ast_to_type)
8607 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8608 * parser-defs.h (struct parser_state) <parser_state>: Add
8609 parameters. Initialize new members.
8610 <expression_context_block, expression_context_pc>: New members.
8611 * parse.c (expression_context_block, expression_context_pc):
8612 Remove globals.
8613 (parse_exp_in_context): Update.
8614 * p-exp.y: Update all rules.
8615 (yylex): Update.
8616 * m2-exp.y: Update all rules.
8617 (yylex): Update.
8618 * go-exp.y (yylex): Update.
8619 * f-exp.y (yylex): Update.
8620 * d-exp.y: Update all rules.
8621 (yylex): Update.
8622 * c-exp.y: Update all rules.
8623 (lex_one_token, classify_name, yylex, c_parse): Update.
8624 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8625
37eedb39
TT
86262019-04-04 Tom Tromey <tom@tromey.com>
8627
8628 * gdbarch.h, gdbarch.c: Rebuild.
8629 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8630 * stap-probe.h:
8631 (struct stap_parse_info): Replace "parser_state" with
8632 "expr_builder".
8633 * parser-defs.h (struct expr_builder): Rename from "parser_state".
8634 (parser_state): New class.
8635 * parse.c (expr_builder): Rename.
8636 (expr_builder::release): Rename.
8637 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8638 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8639 (write_exp_elt_longcst, write_exp_elt_floatcst)
8640 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8641 (write_exp_string_vector, write_exp_bitstring)
8642 (write_exp_msymbol, mark_struct_expression)
8643 (write_dollar_variable)
8644 (insert_type_address_space, increase_expout_size): Replace
8645 "parser_state" with "expr_builder".
8646 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8647 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8648 "parser_state" with "expr_builder".
8649
73923d7e
TT
86502019-04-04 Tom Tromey <tom@tromey.com>
8651
8652 * rust-exp.y: Replace "parse_language" with method call.
8653 * p-exp.y:
8654 (yylex): Replace "parse_language" with method call.
8655 * m2-exp.y:
8656 (yylex): Replace "parse_language" with method call.
8657 * go-exp.y (classify_name): Replace "parse_language" with method
8658 call.
8659 * f-exp.y (yylex): Replace "parse_language" with method call.
8660 * d-exp.y (lex_one_token): Replace "parse_language" with method
8661 call.
8662 * c-exp.y:
8663 (lex_one_token, classify_name, yylex): Replace "parse_language"
8664 with method call.
8665 * ada-exp.y (find_primitive_type, type_char)
8666 (type_system_address): Replace "parse_language" with method call.
8667
fa9f5be6
TT
86682019-04-04 Tom Tromey <tom@tromey.com>
8669
8670 * rust-exp.y: Replace "parse_gdbarch" with method call.
8671 * parse.c (write_dollar_variable, insert_type_address_space):
8672 Replace "parse_gdbarch" with method call.
8673 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8674 call.
8675 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8676 call.
8677 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8678 "parse_gdbarch" with method call.
8679 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8680 with method call.
8681 * f-exp.y (parse_type, parse_f_type, yylex): Replace
8682 "parse_gdbarch" with method call.
8683 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8684 "parse_gdbarch" with method call.
8685 * c-exp.y (parse_type, parse_number, classify_name): Replace
8686 "parse_gdbarch" with method call.
8687 * ada-lex.l: Replace "parse_gdbarch" with method call.
8688 * ada-exp.y (parse_type, find_primitive_type, type_char)
8689 (type_system_address): Replace "parse_gdbarch" with method call.
8690
1201a264
TT
86912019-04-04 Tom Tromey <tom@tromey.com>
8692
8693 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8694 * stap-probe.c (stap_parse_argument): Update.
8695 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8696 initial_size parameter.
8697 * rust-exp.y (rust_lex_tests): Update.
8698 * parse.c (parser_state): Update.
8699 (parse_exp_in_context): Update.
8700 * parser-defs.h (struct parser_state) <parser_state>: Remove
8701 "initial_size" parameter.
8702
e3980ce2
TT
87032019-04-04 Tom Tromey <tom@tromey.com>
8704
8705 * parser-defs.h (increase_expout_size): Don't declare.
8706 * parse.c (increase_expout_size): Now static.
8707
e9f8e3f1
TS
87082019-04-04 Thomas Schwinge <thomas@codesourcery.com>
8709
8710 * gnu-nat.c (gnu_nat_target::wait): Fix
8711 target_waitstatus_to_string call.
8712
d7df6549
AB
87132019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8714
8715 * eval.c (evaluate_subexp_standard): Handle internal functions
8716 during Fortran function call handling.
8717
8bdc1658
AB
87182019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
8719
8720 * NEWS: Mention new internal functions.
8721 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8722 (read_base_type): Use dwarf2_init_complex_target_type.
8723 * value.c (creal_internal_fn): New function.
8724 (cimag_internal_fn): New function.
8725 (_initialize_values): Register new internal functions.
8726
c29705b7
PW
87272019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8728
8729 * infrun.c (stop_all_threads): If debug_infrun, always
8730 trace the wait status after wait_one, using
8731 target_waitstatus_to_string and target_pid_to_str.
8732 (handle_inferior_event): Replace various trace of
8733 wait status kind by a single trace.
8734 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8735 wait status kind image by target_waitstatus_to_string.
8736 * target/waitstatus.c (target_waitstatus_to_string): Fix
8737 obsolete comment.
8738
05caa1d2
TT
87392019-04-01 Tom Tromey <tromey@adacore.com>
8740
8741 PR symtab/23331:
8742 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8743
9d1447e0
SDJ
87442019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
8745 Pedro Alves <palves@redhat.com>
8746
8747 * top.c (quit_force): Call 'finalize_values'.
8748 * value.c (finalize_values): New function.
8749 * value.h (finalize_values): Declare.
8750
7734102d
EZ
87512019-03-30 Eli Zaretskii <eliz@gnu.org>
8752
8753 * NEWS: Announce $_gdb_major and $_gdb_minor.
8754
8755 * top.c (init_gdb_version_vars): New function.
8756 (gdb_init): Call init_gdb_version_vars.
8757
188e1fa9
TT
87582019-03-29 Tom Tromey <tromey@adacore.com>
8759
8760 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
8761 help text. Remove dead code.
8762
2880242d
KS
87632019-03-29 Keith Seitz <keiths@redhat.com>
8764
8765 From Siddhesh Poyarekar:
8766 * f-lang.h (f77_get_upperbound): Return LONGEST.
8767 (f77_get_lowerbound): Likewise.
8768 * f-typeprint.c (f_type_print_varspec_suffix): Expand
8769 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
8770 print them.
8771 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
8772 plongest to format print it.
8773 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8774 (f77_get_upperbound): Likewise.
8775 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8776 LOWER_BOUND to LONGEST.
8777 (f77_create_arrayprint_offset_tbl): Likewise.
8778
cc1defb1
KS
87792019-03-29 Keith Seitz <keiths@redhat.com>
8780
8781 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8782 %s/pulongest for TYPE_LENGTH instead of %d in format
8783 strings.
8784 * ada-typerint.c (ada_print_type): Likewise.
8785 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8786 * compile/compile-c-support.c (generate_register_struct): Likewise.
8787 * gdbtypes.c (recursive_dump_type): Likewise.
8788 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8789 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
8790 instead of %d in format strings.
8791 * riscv-tdep.c (riscv_type_alignment): Cast second argument
8792 to std::min to ULONGEST.
8793 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8794 instead of %d in format strings.
8795 * tracepoint.c (info_scope_command): Likewise.
8796 * typeprint.c (print_offset_data::update)
8797 (print_offset_data::finish): Likewise.
8798 * xtensa-tdep.c (xtensa_store_return_value)
8799 (xtensa_push_dummy_call): Likewise.
8800
e432ccf1
JT
88012019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
8802
8803 * windows-nat.c (display_selector): Fixed format specifications
8804 for 64-bit Cygwin.
8805
65d2b333
PW
88062019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8807
8808 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8809
f489207e
SL
88102019-03-28 Sandra Loosemore <sandra@codesourcery.com>
8811
8812 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8813 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8814 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8815 (nios2_linux_init_abi): Install it.
8816
bffa1015
AH
88172019-03-28 Alan Hayward <alan.hayward@arm.com>
8818
8819 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8820
fc96163a
AH
88212019-03-28 Alan Hayward <alan.hayward@arm.com>
8822
8823 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8824
20dc7e9b
PW
88252019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8826 Tom Tromey <tromey@adacore.com>
8827
8828 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8829
7f5331a8
JB
88302019-03-26 Joel Brobecker <brobecker@adacore.com>
8831
8832 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8833 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8834 method to compute the bounds of range types. Also print "[evaluated]"
8835 if the bounds' values come from a dynamic evaluation.
8836
18c77628
AB
88372019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
8838
8839 * cp-valprint.c (cp_print_value_fields): Don't print trailing
8840 whitespace when pretty printing is on.
8841
53c973f2
AH
88422019-03-26 Alan Hayward <alan.hayward@arm.com>
8843
e79be6e5 8844 * ppc-linux-nat.c: Add include.
53c973f2 8845
d851aa71
AH
88462019-03-26 Alan Hayward <alan.hayward@arm.com>
8847
e79be6e5 8848 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 8849
2fe7bab7
AH
88502019-03-26 Alan Hayward <alan.hayward@arm.com>
8851
e79be6e5 8852 * arm-linux-nat.c: Add include.
2fe7bab7 8853
068ef30e
SM
88542019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
8855
8856 * source-cache.c (source_cache::get_source_lines): Re-read
8857 fullname after calling open_source_file.
8858
81a24d04
JB
88592019-03-25 John Baldwin <jhb@FreeBSD.org>
8860
8861 * NEWS: Mention TLS support for FreeBSD.
8862
79e7ae11
TT
88632019-03-25 Tom Tromey <tromey@adacore.com>
8864
8865 * minsyms.c (BUNCH_SIZE): Update comment.
8866 (~minimal_symbol_reader): Remove old comment.
8867 (compact_minimal_symbols): Update comment.
8868 (minimal_symbol_reader::install): Remove old comment. Update
8869 other comments.
8870
d45963c2
AH
88712019-03-25 Alan Hayward <alan.hayward@arm.com>
8872
8873 * s390-linux-nat.c: Add include.
8874
0f83012e
AH
88752019-03-25 Alan Hayward <alan.hayward@arm.com>
8876
8877 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8878 Call linux_get_hwcap.
8879 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8880 Likewise.
8881 (aarch64_linux_get_hwcap): Remove function.
8882 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8883 declaration.
8884 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8885 linux_get_hwcap.
8886 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8887 * linux-tdep.c (linux_get_hwcap): Add function.
8888 (linux_get_hwcap2): Likewise.
8889 * linux-tdep.h (linux_get_hwcap): Add declaration.
8890 (linux_get_hwcap2): Likewise.
8891 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8892 (ppc_linux_get_hwcap2): Likewise.
8893 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8894 linux_get_hwcap.
8895 (ppc_linux_nat_target::insert_watchpoint): Likewise.
8896 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8897 (ppc_linux_nat_target::read_description): Likewise.
8898 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8899 * s390-linux-nat.c: Likewise.
8900 * s390-linux-tdep.c (s390_core_read_description): Likewise.
8901
6640a367
TT
89022019-03-24 Tom Tromey <tom@tromey.com>
8903
8904 * ada-lang.c (standard_lookup): Simplify initialization.
8905 (ada_lookup_symbol_nonlocal): Simplify return.
8906 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8907 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8908 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8909 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8910 initialization.
8911 * solib.c (solib_global_lookup): Simplify.
8912 * symtab.c (null_block_symbol): Remove.
8913 (symbol_cache_lookup): Simplify returns.
8914 (lookup_language_this): Simplify returns.
8915 (lookup_symbol_aux): Simplify return.
8916 (lookup_local_symbol): Simplify returns.
8917 (lookup_global_symbol_from_objfile): Simplify return.
8918 (lookup_symbol_in_objfile_symtabs)
8919 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8920 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8921 (lookup_static_symbol, lookup_global_symbol): Simplify return.
8922 * cp-namespace.c (cp_lookup_bare_symbol)
8923 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8924 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8925 (cp_lookup_nested_symbol): Don't use null_block_symbol.
8926 (cp_lookup_symbol_via_imports): Simplify initialization.
8927 (find_symbol_in_baseclass): Likewise.
8928 * symtab.h (null_block_symbol): Remove.
8929 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8930 (d_lookup_nested_symbol, d_lookup_symbol_imports)
8931 (d_lookup_symbol_module): Likewise.
8932 (find_symbol_in_baseclass): Simplify initialization.
8933
a930ebcd
TT
89342019-03-24 Tom Tromey <tom@tromey.com>
8935
8936 * expression.h: Don't include symtab.h.
8937 (struct block): Forward declare.
8938
582942f4
TT
89392019-03-24 Tom Tromey <tom@tromey.com>
8940
8941 * c-exp.y (typebase): Remove casts.
8942 * gdbtypes.c (lookup_unsigned_typename, )
8943 (lookup_signed_typename): Remove cast.
8944 * eval.c (parse_to_comma_and_eval): Remove cast.
8945 * parse.c (write_dollar_variable): Remove cast.
8946 * block.h (struct block) <superblock>: Now const.
8947 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8948 * psymtab.c (psym_map_matching_symbols): Make "block" const.
8949 (map_block): Make "block" const.
8950 * symfile.h (struct quick_symbol_functions)
8951 <map_matching_symbols>: Constify block argument to "callback".
8952 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8953 const.
8954 (find_pc_sect_compunit_symtab): Make "b" const.
8955 (find_symbol_at_address): Likewise.
8956 (search_symbols): Likewise.
8957 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8958 (dw2_debug_names_lookup_symbol): Likewise.
8959 (dw2_map_matching_symbols): Update.
8960 * p-valprint.c (pascal_val_print): Remove "block".
8961 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8962 (aux_add_nonlocal_symbols): Make "block" const.
8963 (resolve_subexp): Remove cast.
8964 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8965 const.
8966 (iterate_over_file_blocks): Likewise.
8967 * f-exp.y (%union) <bval>: Remove.
8968 * coffread.c (patch_opaque_types): Make "b" const.
8969 * spu-tdep.c (spu_catch_start): Make "block" const.
8970 * c-valprint.c (print_unpacked_pointer): Remove "block".
8971 * symmisc.c (dump_symtab_1): Make "b" const.
8972 (block_depth): Make "block" const.
8973 * d-exp.y (%union) <bval>: Remove.
8974 * cp-support.h (cp_lookup_rtti_type): Update.
8975 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8976 * psymtab.c (psym_lookup_symbol): Make "block" const.
8977 (maintenance_check_psymtabs): Make "b" const.
8978 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8979 (enumerate_locals, enumerate_args): Update.
8980 * python/py-symtab.c (stpy_global_block): Make "block" const.
8981 (stpy_static_block): Likewise.
8982 * inline-frame.c (block_starting_point_at): Make "new_block"
8983 const.
8984 * block.c (find_block_in_blockvector): Make return type const.
8985 (blockvector_for_pc_sect): Make "b" const.
8986 (find_block_in_blockvector): Make "b" const.
8987
7ad417dd
TT
89882019-03-23 Tom Tromey <tom@tromey.com>
8989
8990 * varobj.c (varobj_create): Update.
8991 * symfile.c (clear_symtab_users): Don't reset innermost_block.
8992 * printcmd.c (display_command, do_one_display): Don't reset
8993 innermost_block.
8994 * parser-defs.h (enum innermost_block_tracker_type): Move to
8995 expression.h.
8996 (innermost_block): Update comment.
8997 * parse.c (parse_exp_1): Add tracker_types parameter.
8998 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
8999 tracker_types parameter. Reset innermost_block.
9000 (parse_exp_in_context): Remove.
9001 (parse_expression_for_completion): Update.
9002 * objfiles.c (~objfile): Don't reset expression_context_block or
9003 innermost_block.
9004 * expression.h (enum innermost_block_tracker_type): Move from
9005 parser-defs.h.
9006 (parse_exp_1): Add tracker_types parameter.
9007 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9008 reset innermost_block.
9009
b366c208
TT
90102019-03-23 Tom Tromey <tom@tromey.com>
9011
9012 * objfiles.h: Include bcache.h.
9013
9bb9b2f9
TT
90142019-03-23 Tom Tromey <tom@tromey.com>
9015
9016 * linespec.c (get_current_search_block): Use
9017 scoped_restore_current_language.
9018 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9019
59c28372
AH
90202019-03-22 Alan Hayward <alan.hayward@arm.com>
9021 Jiong Wang <jiong.wang@arm.com>
9022
9023 * aarch64-linux-tdep.c
9024 (aarch64_linux_iterate_over_regset_sections): Check for pauth
9025 section.
9026 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9027
17e116a7
AH
90282019-03-22 Alan Hayward <alan.hayward@arm.com>
9029 Jiong Wang <jiong.wang@arm.com>
9030
9031 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9032 instructions.
9033 (aarch64_analyze_prologue_test): Add PACIASP test.
9034 (aarch64_prologue_prev_register): Unmask PC value.
9035
11e1b75f
AH
90362019-03-22 Alan Hayward <alan.hayward@arm.com>
9037 Jiong Wang <jiong.wang@arm.com>
9038
9039 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9040 (aarch64_dwarf2_prev_register): Unmask PC value.
9041 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9042 (aarch64_execute_dwarf_cfa_vendor_op): Check for
9043 DW_CFA_AARCH64_negate_ra_state.
9044 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9045
34dcc7cf
AH
90462019-03-22 Alan Hayward <alan.hayward@arm.com>
9047 Jiong Wang <jiong.wang@arm.com>
9048
9049 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9050 registers.
9051 (aarch64_pseudo_register_name): Likewise.
9052 (aarch64_pseudo_register_type): Likewise.
9053 (aarch64_pseudo_register_reggroup_p): Likewise.
9054 (aarch64_gdbarch_init): Add pauth registers.
9055 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9056 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9057 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9058 (struct gdbarch_tdep): Add regnum for ra_state.
9059
1ef53e6b
AH
90602019-03-22 Alan Hayward <alan.hayward@arm.com>
9061 Jiong Wang <jiong.wang@arm.com>
9062
9063 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9064
76bed0fd
AH
90652019-03-22 Alan Hayward <alan.hayward@arm.com>
9066 Jiong Wang <jiong.wang@arm.com>
9067
9068 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9069 function.
9070 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9071 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9072 (aarch64_gdbarch_init): Add puth registers.
9073 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9074 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9075 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9076
ee4fbcfa
AH
90772019-03-22 Alan Hayward <alan.hayward@arm.com>
9078 Jiong Wang <jiong.wang@arm.com>
9079
9080 * aarch64-linux-nat.c
9081 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9082 * aarch64-linux-tdep.c
9083 (aarch64_linux_core_read_description): Likewise.
9084 (aarch64_linux_get_hwcap): New function.
9085 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9086 (aarch64_linux_get_hwcap): New declaration.
9087
6dc0ebde
AH
90882019-03-22 Alan Hayward <alan.hayward@arm.com>
9089 Jiong Wang <jiong.wang@arm.com>
9090
9091 * aarch64-linux-nat.c
9092 (aarch64_linux_nat_target::read_description): Add pauth param.
9093 * aarch64-linux-tdep.c
9094 (aarch64_linux_core_read_description): Likewise.
9095 * aarch64-tdep.c (struct target_desc): Add in pauth.
9096 (aarch64_read_description): Add pauth param.
9097 (aarch64_gdbarch_init): Likewise.
9098 * aarch64-tdep.h (aarch64_read_description): Likewise.
9099 * arch/aarch64.c (aarch64_create_target_description): Likewise.
9100 * arch/aarch64.h (aarch64_create_target_description): Likewise.
9101 * features/Makefile: Add new files.
9102 * features/aarch64-pauth.c: New file.
9103 * features/aarch64-pauth.xml: New file.
9104
595915c1
TT
91052019-03-20 Tom Tromey <tromey@adacore.com>
9106
9107 * infrun.c (handle_inferior_event): Rename from
9108 handle_inferior_event_1. Create a scoped_value_mark.
9109 (handle_inferior_event): Remove.
9110
4c7d57e7
TT
91112019-03-19 Tom Tromey <tromey@adacore.com>
9112
9113 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9114 * infrun.h (print_stop_event): Add "displays" parameter.
9115 * infrun.c (print_stop_event): Add "displays" parameter.
9116
cb246234
PA
91172019-03-19 Pedro Alves <palves@redhat.com>
9118
9119 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9120 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
9121 to -1. Fix TABs vs spaces.
9122 (tui_ui_out::tui_ui_out): Don't initialize fields here.
9123 * tui/tui-out.h (tui_ui_out) Add intro comments.
9124 <m_line, m_start_of_line>: In-class initialize, and add describing
9125 comment.
9126
3a0e45b2
AH
91272019-03-18 Alan Hayward <alan.hayward@arm.com>
9128
9129 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9130 variable names.
9131 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9132
5371b850
PA
91332019-03-18 Pedro Alves <palves@redhat.com>
9134 Eli Zaretskii <eliz@gnu.org>
9135
9136 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9137 m_line and m_start_of_line.
9138
b17c4cd0
EZ
91392019-03-18 Eli Zaretskii <eliz@gnu.org>
9140
9141 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9142 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9143 it returns a newline. This fixes a regression in TU mode, whereby
9144 the next line is output on the same screen line as the user input.
9145
4bd56d18
TT
91462019-03-18 Tom Tromey <tromey@adacore.com>
9147
9148 * minsyms.c (minimal_symbol_reader::install): Remove call to
9149 obstack_blank.
9150
55c10aca
PA
91512019-03-18 Pedro Alves <palves@redhat.com>
9152
9153 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9154 New globals.
9155 (apply_style): New, factored out from ...
9156 (apply_ansi_escape): ... this. Handle reverse video mode.
9157 (tui_set_reverse_mode): New function.
9158 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9159 * tui/tui-winsource.c (tui_show_source_line): Use
9160 tui_set_reverse_mode instead of setting A_STANDOUT.
9161 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9162 New setter methods.
9163
647bb750
HD
91642019-03-18 Hannes Domani <ssbssa@yahoo.de>
9165
9166 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9167 Handle tabs.
9168
bff8c71f
TT
91692019-03-18 Tom Tromey <tromey@adacore.com>
9170
9171 * ada-lang.c (empty_array): Add "high" parameter.
9172 (ada_evaluate_subexp): Update.
9173
58785d98
ST
91742019-03-17 Sergei Trofimovich <siarheit@google.com>
9175
9176 * unittests/string_view-selftests.c: Define
9177 _initialize_string_view_selftests unconditionally.
9178
d4cbef22
ВМ
91792019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9180
9181 PR gdb/24350
9182 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9183
fce4c071
ВМ
91842019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
9185
9186 PR gdb/24351
9187 * windows-nat.c (display_selector): Fix format specifiers.
9188
f7f0a123
EZ
91892019-03-17 Eli Zaretskii <eliz@gnu.org>
9190
9191 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9192 tui_refill_source_window instead of tui_refresh_win, to update the
9193 current execution line. This fixes redisplay of the current line
9194 when stepping through the code with "next" or "step".
9195
ab42892f
EZ
91962019-03-16 Eli Zaretskii <eliz@gnu.org>
9197
9198 * source-cache.c (source_cache::get_source_lines): Call
9199 find_source_lines to initialize s->nlines. This fixes vertical
9200 scrolling of TUI source window when the DOWN arrow is pressed.
9201
8d8c087f
PW
92022019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9203
9204 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9205 linux-thread-db.c (_initialize_thread_db): Likewise.
9206
798e1c30
EZ
92072019-03-16 Eli Zaretskii <eliz@gnu.org>
9208
9209 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9210 wclrtoeol in tui_show_source_line". This reverts changes made in
9211 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9212
eefba3da
TT
92132019-03-15 Tom Tromey <tom@tromey.com>
9214
9215 * symtab.h (struct minimal_symbol): Derive from
9216 general_symbol_info.
9217 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9218 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9219 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9220 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9221 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9222 (MSYMBOL_SEARCH_NAME): Update.
9223 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9224 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9225 * minsyms.c (minimal_symbol_reader::record_full): Update.
9226
0de2420c
TT
92272019-03-15 Tom Tromey <tom@tromey.com>
9228
9229 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9230
042d75e4
TT
92312019-03-15 Tom Tromey <tom@tromey.com>
9232
9233 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9234 unique_xmalloc_ptr.
9235 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9236 Update.
9237 * minsyms.c (lookup_minimal_symbol_by_pc_section)
9238 (build_minimal_symbol_hash_tables)
9239 (minimal_symbol_reader::install): Update.
9240
db92718b
TT
92412019-03-15 Tom Tromey <tom@tromey.com>
9242
9243 * symtab.c (create_demangled_names_hash): Update.
9244 (symbol_set_names): Update.
9245 * objfiles.h (struct objfile_per_bfd_storage)
9246 <demangled_names_hash>: Now an htab_up.
9247 * objfiles.c (objfile_per_bfd_storage): Simplify.
9248
d6797f46
TT
92492019-03-15 Tom Tromey <tom@tromey.com>
9250
9251 * objfiles.h (struct objfile_per_bfd_storage): Declare
9252 destructor.
9253 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9254 New.
9255 (get_objfile_bfd_data): Use new. Don't initialize
9256 language_of_main.
9257 (free_objfile_per_bfd_storage): Remove.
9258 (objfile_bfd_data_free, objfile::~objfile): Use delete.
9259
741d7538
TT
92602019-03-15 Tom Tromey <tom@tromey.com>
9261
9262 * symfile.c (reread_symbols): Update.
9263 * objfiles.c (objfile::objfile): Update.
9264 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9265 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9266 comment.
9267 (minimal_symbol_reader::install): Update.
9268 (terminate_minimal_symbol_table): Remove.
9269 * jit.c (jit_object_close_impl): Update.
9270
788c80d1
TT
92712019-03-15 Tom Tromey <tom@tromey.com>
9272
9273 * minsyms.c (minimal_symbol_reader::record_full): Remove some
9274 initializations.
9275
1b7a07cb
TT
92762019-03-15 Tom Tromey <tom@tromey.com>
9277
9278 * objfiles.h (struct objfile_per_bfd_storage)
9279 <demangled_hash_languages>: Now a bitset.
9280 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9281 (lookup_minimal_symbol): Update.
9282
3db066bc
TT
92832019-03-15 Tom Tromey <tom@tromey.com>
9284
9285 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9286 Don't return the symbol.
9287 * coffread.c (record_minimal_symbol): Use record_full.
9288
3fff2c37
EZ
92892019-03-14 Eli Zaretskii <eliz@gnu.org>
9290
9291 The MS-Windows port of ncurses fails to switch to a color pair if
9292 one or both of the colors are the implicit default colors. This
9293 change records the default colors when TUI is initialized, and
9294 then specifies them explicitly when a color pair uses the default
9295 colors. This allows color styling in TUI mode on MS-Windows.
9296
9297 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
9298 ncurses_norm_attr.
9299 (tui_initialize_io) [__MINGW32__]: Record the default terminal
9300 colors in ncurses_norm_attr.
9301 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9302 "none", replace it with the default color recorded in
9303 ncurses_norm_attr.
9304
3b336828
TT
93052019-03-14 Tom Tromey <tromey@adacore.com>
9306
9307 * source-cache.h (class source_cache) <get_source_lines>: Return
9308 std::string.
9309 * source-cache.c (source_cache::extract_lines): Handle case where
9310 first_pos==npos. Return std::string.
9311 (source_cache::get_source_lines): Update.
9312
d085f989
TT
93132019-03-14 Tom Tromey <tromey@adacore.com>
9314
9315 * NEWS: Add item for "style sources" commands.
9316 * source-cache.c (source_cache::get_source_lines): Check
9317 source_styling.
9318 * cli/cli-style.c (source_styling): New global.
9319 (_initialize_cli_style): Add "style sources" commands.
9320 (show_style_sources): New function.
9321 * cli/cli-style.h (source_styling): Declare.
9322
6f11e682
TT
93232019-03-14 Pedro Alves <palves@redhat.com>
9324 Tom Tromey <tromey@adacore.com>
9325
9326 * tui/tui-winsource.h (tui_refill_source_window): Declare.
9327 * tui/tui-winsource.c (tui_refill_source_window): New function,
9328 from...
9329 (tui_horizontal_source_scroll): ... here. Move some logic.
9330 * cli/cli-style.c (set_style_enabled): Notify new observable.
9331 * tui/tui-hooks.c (tui_redisplay_source): New function.
9332 (tui_attach_detach_observers): Attach or detach
9333 tui_redisplay_source.
9334 * observable.h (source_styling_changed): New observable.
9335 * observable.c: Define source_styling_changed observable.
9336
a068643d
TT
93372019-03-13 Tom Tromey <tromey@adacore.com>
9338
9339 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9340 (i386_gnu_nat_target::store_registers): Update.
9341 * target-debug.h (target_debug_print_std_string): New macro.
9342 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9343 * windows-tdep.c (display_one_tib): Update.
9344 * tui/tui-stack.c (tui_make_status_line): Update.
9345 * top.c (print_inferior_quit_action): Update.
9346 * thread.c (thr_try_catch_cmd): Update.
9347 (add_thread_with_info): Update.
9348 (thread_target_id_str): Update.
9349 (thr_try_catch_cmd): Update.
9350 (thread_command): Update.
9351 (thread_find_command): Update.
9352 * record-btrace.c (record_btrace_target::info_record)
9353 (record_btrace_resume_thread, record_btrace_target::resume)
9354 (record_btrace_cancel_resume, record_btrace_step_thread)
9355 (record_btrace_target::wait, record_btrace_target::wait)
9356 (record_btrace_target::wait, record_btrace_target::stop): Update.
9357 * progspace.c (print_program_space): Update.
9358 * process-stratum-target.c
9359 (process_stratum_target::thread_address_space): Update.
9360 * linux-fork.c (linux_fork_mourn_inferior)
9361 (detach_checkpoint_command, info_checkpoints_command)
9362 (linux_fork_context): Update.
9363 (linux_fork_detach): Update.
9364 (class scoped_switch_fork_info): Update.
9365 (delete_checkpoint_command): Update.
9366 * infrun.c (follow_fork_inferior): Update.
9367 (follow_fork_inferior): Update.
9368 (proceed_after_vfork_done): Update.
9369 (handle_vfork_child_exec_or_exit): Update.
9370 (follow_exec): Update.
9371 (displaced_step_prepare_throw): Update.
9372 (displaced_step_restore): Update.
9373 (start_step_over): Update.
9374 (resume_1): Update.
9375 (clear_proceed_status_thread): Update.
9376 (proceed): Update.
9377 (print_target_wait_results): Update.
9378 (do_target_wait): Update.
9379 (context_switch): Update.
9380 (stop_all_threads): Update.
9381 (restart_threads): Update.
9382 (finish_step_over): Update.
9383 (handle_signal_stop): Update.
9384 (switch_back_to_stepped_thread): Update.
9385 (keep_going_pass_signal): Update.
9386 (print_exited_reason): Update.
9387 (normal_stop): Update.
9388 * inferior.c (inferior_pid_to_str): Change return type.
9389 (print_selected_inferior): Update.
9390 (add_inferior): Update.
9391 (detach_inferior): Update.
9392 * dummy-frame.c (fprint_dummy_frames): Update.
9393 * dcache.c (dcache_info_1): Update.
9394 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9395 (btrace_fetch, btrace_clear): Update.
9396 * linux-tdep.c (linux_core_pid_to_str): Change return type.
9397 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9398 type.
9399 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9400 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9401 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9402 * gdbarch.c, gdbarch.h: Rebuild.
9403 * gdbarch.sh (core_pid_to_str): Change return type.
9404 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9405 return type.
9406 (windows_nat_target::pid_to_str): Change return type.
9407 (windows_delete_thread): Update.
9408 (windows_nat_target::attach): Update.
9409 (windows_nat_target::files_info): Update.
9410 * target-delegates.c: Rebuild.
9411 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9412 return type.
9413 (sol_thread_target::pid_to_str): Change return type.
9414 * remote.c (class remote_target) <pid_to_str>: Change return
9415 type.
9416 (remote_target::pid_to_str): Change return type.
9417 (extended_remote_target::attach, remote_target::remote_stop_ns)
9418 (remote_target::remote_notif_remove_queued_reply)
9419 (remote_target::push_stop_reply, remote_target::disable_btrace):
9420 Update.
9421 (extended_remote_target::attach): Update.
9422 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9423 type.
9424 (gdbsim_target::pid_to_str): Change return type.
9425 * ravenscar-thread.c (struct ravenscar_thread_target)
9426 <pid_to_str>: Change return type.
9427 (ravenscar_thread_target::pid_to_str): Change return type.
9428 * procfs.c (class procfs_target) <pid_to_str>: Change return
9429 type.
9430 (procfs_target::pid_to_str): Change return type.
9431 (procfs_target::attach): Update.
9432 (procfs_target::detach): Update.
9433 (procfs_target::fetch_registers): Update.
9434 (procfs_target::store_registers): Update.
9435 (procfs_target::wait): Update.
9436 (procfs_target::files_info): Update.
9437 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9438 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9439 return type.
9440 (nto_procfs_target::pid_to_str): Change return type.
9441 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9442 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9443 return type.
9444 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9445 (exit_lwp): Update.
9446 (attach_proc_task_lwp_callback, get_detach_signal)
9447 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9448 (linux_nat_target::resume, wait_lwp, stop_callback)
9449 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9450 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9451 (linux_nat_wait_1, resume_stopped_resumed_lwps)
9452 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9453 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9454 type.
9455 (inf_ptrace_target::attach): Update.
9456 (inf_ptrace_target::files_info): Update.
9457 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9458 type.
9459 (go32_nat_target::pid_to_str): Change return type.
9460 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9461 (gnu_nat_target::wait): Update.
9462 (gnu_nat_target::wait): Update.
9463 (gnu_nat_target::resume): Update.
9464 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9465 (fbsd_nat_target::wait): Update.
9466 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9467 type.
9468 (darwin_nat_target::attach): Update.
9469 * corelow.c (class core_target) <pid_to_str>: Change return type.
9470 (core_target::pid_to_str): Change return type.
9471 * target.c (normal_pid_to_str): Change return type.
9472 (default_pid_to_str): Likewise.
9473 (target_pid_to_str): Change return type.
9474 (target_translate_tls_address): Update.
9475 (target_announce_detach): Update.
9476 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9477 return type.
9478 (bsd_uthread_target::pid_to_str): Change return type.
9479 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9480 type.
9481 (bsd_kvm_target::pid_to_str): Change return type.
9482 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9483 return type.
9484 (aix_thread_target::pid_to_str): Change return type.
9485 * target.h (struct target_ops) <pid_to_str>: Change return type.
9486 (target_pid_to_str, normal_pid_to_str): Likewise.
9487 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9488 type.
9489 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9490 type.
9491 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9492 return type.
9493 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9494 type.
9495 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9496 type.
9497 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9498 return type.
9499
b4be1b06
SM
95002019-03-13 Simon Marchi <simon.marchi@ericsson.com>
9501
9502 * NEWS: Mention that the new default MI version is 3. Mention
9503 changes to the output of commands and events that deal with
9504 multi-location breakpoints.
9505 * breakpoint.c: Include "mi/mi-out.h".
9506 (print_one_breakpoint): Change output syntax if using MI version
9507 >= 3.
9508 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9509 New.
9510 (mi_multi_location_breakpoint_output_fixed): New.
9511 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9512 (mi_cmd_fix_multi_location_breakpoint_output): New.
9513 (mi_multi_location_breakpoint_output_fixed): New.
9514 * mi/mi-cmds.c (mi_cmds): Register command
9515 -fix-multi-location-breakpoint-output.
9516 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9517 interpreter "mi".
9518
8e5e5494
SM
95192019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
9520
9521 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9522 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9523 instantiate mi_ui_out based on interpreter name.
9524 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9525 * mi/mi-main.c (mi_load_progress): Likewise.
9526
197df35e
JB
95272019-03-12 John Baldwin <jhb@FreeBSD.org>
9528
9529 * NEWS: Combine separate "New targets" sections for 8.3.
9530
8399425f
JB
95312019-03-12 John Baldwin <jhb@FreeBSD.org>
9532
9533 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9534 (ppcfbsd_init_abi): Install gdbarch
9535 "fetch_tls_load_module_address" and "get_thread_local_address"
9536 methods.
9537
b0f87ed0
JB
95382019-03-12 John Baldwin <jhb@FreeBSD.org>
9539
9540 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9541 (riscv_fbsd_init_abi): Install gdbarch
9542 "fetch_tls_load_module_address" and "get_thread_local_address"
9543 methods.
9544
ce25aa57
JB
95452019-03-12 John Baldwin <jhb@FreeBSD.org>
9546
9547 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9548 (i386fbsd_init_abi): Install gdbarch
9549 "fetch_tls_load_module_address" and "get_thread_local_address"
9550 methods.
9551
f5424cfa
JB
95522019-03-12 John Baldwin <jhb@FreeBSD.org>
9553
9554 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9555 (amd64fbsd_init_abi): Install gdbarch
9556 "fetch_tls_load_module_address" and "get_thread_local_address"
9557 methods.
9558
945f3901
JB
95592019-03-12 John Baldwin <jhb@FreeBSD.org>
9560
9561 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9562 (struct fbsd_pspace_data): New type.
9563 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9564 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9565 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9566 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9567 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9568
ef0bd204
JB
95692019-03-12 John Baldwin <jhb@FreeBSD.org>
9570
9571 * gdbtypes.c (lookup_struct_elt): New function.
9572 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9573 * gdbtypes.h (struct struct_elt): New type.
9574 (lookup_struct_elt): New prototype.
9575
36c53a02
JB
95762019-03-12 John Baldwin <jhb@FreeBSD.org>
9577
9578 * gdbtypes.c (lookup_struct_elt_type): Update comment and
9579 remove disabled code block.
9580
6e056c81
JB
95812019-03-12 John Baldwin <jhb@FreeBSD.org>
9582
9583 * gdbarch.sh (get_thread_local_address): New method.
9584 * gdbarch.h, gdbarch.c: Regenerate.
9585 * target.c (target_translate_tls_address): Use
9586 gdbarch_get_thread_local_address if present instead of
9587 target::get_thread_local_address.
9588
cd250a18
JB
95892019-03-12 John Baldwin <jhb@FreeBSD.org>
9590
9591 * target.h (target::get_thread_local_address): Update comment.
9592
df22c1e5
JB
95932019-03-12 John Baldwin <jhb@FreeBSD.org>
9594
9595 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9596 objfile->separate_debug_objfile_backlink if not NULL.
9597
dd6876c9
JB
95982019-03-12 John Baldwin <jhb@FreeBSD.org>
9599
9600 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9601 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9602 (amd64bsd_store_inferior_registers): Likewise.
9603 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9604 Enable segment base registers.
9605 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9606 PT_GETFSBASE and PT_GETGSBASE.
9607 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9608 PT_SETGSBASE.
9609 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9610 segment base registers.
9611 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9612
1163a4b7
JB
96132019-03-12 John Baldwin <jhb@FreeBSD.org>
9614
9615 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9616 Update calls to i386_target_description to add 'segments'
9617 parameter.
9618 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
9619 add segment base registers.
9620 * arch/i386.c (i386_create_target_description): Add 'segments'
9621 parameter to enable segment base registers.
9622 * arch/i386.h (i386_create_target_description): Likewise.
9623 * features/i386/32bit-segments.xml: New file.
9624 * features/i386/32bit-segments.c: Generate.
9625 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9626 call to i386_target_description to add 'segments' parameter.
9627 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9628 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9629 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9630 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9631 if feature is present.
9632 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9633 Add 'segments' parameter to call to i386_target_description.
9634 (i386_target_description): Add 'segments' parameter to enable
9635 segment base registers.
9636 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9637 to call to i386_target_description.
9638 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9639 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9640 Define I386_NUM_REGS.
9641 (i386_target_description): Add 'segments' parameter to enable
9642 segment base registers.
9643
3a350822
EZ
96442019-03-12 Eli Zaretskii <eliz@gnu.org>
9645
9646 PR/24325
9647 * source-cache.c: #undef open and close, to avoid unresolved
9648 externals during linking.
9649
ffdd69cf
TT
96502019-03-12 Tom Tromey <tromey@adacore.com>
9651
9652 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9653 const. Add initializers.
9654 (_initialize_remote): Don't initialize ptid globals.
9655
ec148c57
PA
96562019-03-12 Pedro Alves <palves@redhat.com>
9657
9658 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9659
32764270
PA
96602019-03-12 Pedro Alves <palves@redhat.com>
9661
9662 * cp-name-parser.y (main): Remove unused 'len' variable.
9663
17547186
TT
96642019-03-12 Tom Tromey <tromey@adacore.com>
9665
9666 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9667 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9668
d3a70e03
TT
96692019-03-12 Tom Tromey <tromey@adacore.com>
9670
9671 * linux-nat.c (iterate_over_lwps): Update.
9672 (stop_callback): Remove parameter.
9673 (stop_wait_callback, detach_callback, resume_set_callback)
9674 (select_singlestep_lwp_callback, set_ignore_sigint)
9675 (status_callback, resumed_callback, resume_clear_callback)
9676 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9677 data parameter.
9678 (linux_nat_target::detach, linux_nat_target::resume)
9679 (linux_stop_and_wait_all_lwps, select_event_lwp)
9680 (linux_nat_filter_event, linux_nat_wait_1)
9681 (linux_nat_target::kill, linux_nat_target::stop)
9682 (linux_nat_target::stop): Update.
9683 (linux_nat_resume_callback): Change type.
9684 (resume_stopped_resumed_lwps, count_events_callback)
9685 (select_event_lwp_callback): Likewise.
9686 (linux_stop_lwp, linux_nat_stop_lwp): Update.
9687 * arm-linux-nat.c (struct update_registers_data): Remove.
9688 (update_registers_callback): Change type.
9689 (arm_linux_insert_hw_breakpoint1): Update.
9690 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9691 parameter.
9692 (x86_linux_dr_set_addr): Update.
9693 (x86_linux_dr_set_control): Update.
9694 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9695 (iterate_over_lwps): Use gdb::function_view.
9696 * nat/aarch64-linux-hw-point.c (struct
9697 aarch64_dr_update_callback_param): Remove.
9698 (debug_reg_change_callback): Change type.
9699 (aarch64_notify_debug_reg_change): Update.
9700 * s390-linux-nat.c (s390_refresh_per_info): Update.
9701
82cb27ff
TT
97022019-03-11 Tom Tromey <tromey@adacore.com>
9703
9704 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9705 redundant assignment to "this_cu".
9706
568c0683
SM
97072019-03-08 Simon Marchi <simon.marchi@efficios.com>
9708
9709 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9710
f09ce22d
SM
97112019-03-08 Simon Marchi <simon.marchi@efficios.com>
9712
9713 * gdbtypes.c (rank_one_type_parm_set): New function extracted
9714 from...
9715 (rank_one_type): ... this.
9716
595f96a9
SM
97172019-03-08 Simon Marchi <simon.marchi@efficios.com>
9718
9719 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9720 from...
9721 (rank_one_type): ... this.
9722
2598a94b
SM
97232019-03-08 Simon Marchi <simon.marchi@efficios.com>
9724
9725 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9726 from...
9727 (rank_one_type): ... this.
9728
7f17b20d
SM
97292019-03-08 Simon Marchi <simon.marchi@efficios.com>
9730
9731 * gdbtypes.c (rank_one_type_parm_float): New function extracted
9732 from...
9733 (rank_one_type): ... this.
9734
2c509035
SM
97352019-03-08 Simon Marchi <simon.marchi@efficios.com>
9736
9737 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9738 from...
9739 (rank_one_type): ... this.
9740
0dd322dc
SM
97412019-03-08 Simon Marchi <simon.marchi@efficios.com>
9742
9743 * gdbtypes.c (rank_one_type_parm_range): New function extracted
9744 from...
9745 (rank_one_type): ... this.
9746
41ea4728
SM
97472019-03-08 Simon Marchi <simon.marchi@efficios.com>
9748
9749 * gdbtypes.c (rank_one_type_parm_char): New function extracted
9750 from...
9751 (rank_one_type): ... this.
9752
793cd1d2
SM
97532019-03-08 Simon Marchi <simon.marchi@efficios.com>
9754
9755 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9756 from...
9757 (rank_one_type): ... this.
9758
34910087
SM
97592019-03-08 Simon Marchi <simon.marchi@efficios.com>
9760
9761 * gdbtypes.c (rank_one_type_parm_int): New function extracted
9762 from...
9763 (rank_one_type): ... this.
9764
f1f832d6
SM
97652019-03-08 Simon Marchi <simon.marchi@efficios.com>
9766
9767 * gdbtypes.c (rank_one_type_parm_func): New function extracted
9768 from...
9769 (rank_one_type): ... this.
9770
b9f4512f
SM
97712019-03-08 Simon Marchi <simon.marchi@efficios.com>
9772
9773 * gdbtypes.c (rank_one_type_parm_array): New function extracted
9774 from...
9775 (rank_one_type): ... this.
9776
9293fc63
SM
97772019-03-08 Simon Marchi <simon.marchi@efficios.com>
9778
9779 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9780 from...
9781 (rank_one_type): ... this.
9782
e3abbe7e
PW
97832019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9784
9785 * inferior.c (initialize_inferiors): Ensure 'help set/show print
9786 inferior-events' shows the example events.
9787
e4adb939
EZ
97882019-03-08 Eli Zaretskii <eliz@gnu.org>
9789
9790 Support styling on native MS-Windows console
9791
9792 PR/24315
9793 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9794 on MS-Windows if $TERM is not defined.
9795
9796 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9797
9798 * posix-hdep.c (gdb_console_fputs):
9799 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9800 functions.
9801 * ui-file.h (gdb_console_fputs): Add prototype.
9802
9803 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9804 back to fputs only if the former returns zero.
9805
25629dfd
TT
98062019-03-07 Tom Tromey <tom@tromey.com>
9807
9808 * symmisc.c (print_symbol_bcache_statistics): Update.
9809 (print_objfile_statistics): Update.
9810 * symfile.c (allocate_symtab): Update.
9811 * stabsread.c: Don't include bcache.h.
9812 * psymtab.h (struct psymbol_bcache): Don't declare.
9813 (class psymtab_storage) <psymbol_cache>: Now a bcache.
9814 (psymbol_bcache_init, psymbol_bcache_free)
9815 (psymbol_bcache_get_bcache): Don't declare.
9816 * psymtab.c (struct psymbol_bcache): Remove.
9817 (psymtab_storage::psymtab_storage): Update.
9818 (psymtab_storage::~psymtab_storage): Update.
9819 (psymbol_bcache_init, psymbol_bcache_free)
9820 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9821 (add_psymbol_to_bcache): Update.
9822 (allocate_psymtab): Update.
9823 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9824 macro_cache>: No longer pointers.
9825 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9826 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9827 * macrotab.c (macro_bcache): Update.
9828 * macroexp.c: Don't include bcache.h.
9829 * gdbtypes.c (check_types_worklist): Update.
9830 (types_deeply_equal): Remove TRY/CATCH. Update.
9831 * elfread.c (elf_symtab_read): Update.
9832 * dwarf2read.c: Don't include bcache.h.
9833 * buildsym.c (buildsym_compunit::get_macro_table): Update.
9834 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9835 (print_bcache_statistics, bcache_memory_used): Don't declare.
9836 (struct bcache): Move from bcache.c. Add constructor, destructor,
9837 methods. Rename all data members.
9838 * bcache.c (struct bcache): Move to bcache.h.
9839 (bcache::expand_hash_table): Rename from expand_hash_table.
9840 (bcache): Remove.
9841 (bcache::insert): Rename from bcache_full.
9842 (bcache::compare): Rename from bcache_compare.
9843 (bcache_xmalloc): Remove.
9844 (bcache::~bcache): Rename from bcache_xfree.
9845 (bcache::print_statistics): Rename from print_bcache_statistics.
9846 (bcache::memory_used): Rename from bcache_memory_used.
9847
fe726667
PA
98482019-03-07 Pedro Alves <palves@redhat.com>
9849
9850 * infrun.c (normal_stop): Also check for
9851 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9852
7584bb30
AB
98532019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
9854
9855 * f-lang.c (value_from_host_double): Moved to...
9856 * value.c (value_from_host_double): ...here.
9857 * value.h (value_from_host_double): Declare.
9858 * guile/scm-math.c (vlscm_convert_typed_number): Use
9859 value_from_host_double.
9860 (vlscm_convert_number): Likewise.
9861 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9862 * python/py-value.c (convert_value_from_python): Likewise.
9863
a7b1986e
TT
98642019-03-06 Tom Tromey <tom@tromey.com>
9865
9866 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9867
0ccf4211
TT
98682019-03-06 Tom Tromey <tom@tromey.com>
9869
9870 * utils.h (free_current_contents): Don't declare.
9871 * utils.c (free_current_contents): Remove.
9872
fe7b42e5
TT
98732019-03-06 Tom Tromey <tom@tromey.com>
9874
9875 * top.c (quit_force): Update.
9876 * main.c (captured_command_loop): Update.
9877 * common/new-op.c (operator new): Update.
9878 * common/common-exceptions.c (struct catcher)
9879 <save_cleanup_chain>: Remove member.
9880 (exceptions_state_mc_init): Update.
9881 (exception_try_scope_entry): Return nullptr.
9882 (exception_try_scope_exit, exception_rethrow)
9883 (throw_exception_sjlj, throw_exception_cxx): Update.
9884 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9885 (all_cleanups, do_cleanups, discard_cleanups)
9886 (discard_final_cleanups, save_cleanups, save_final_cleanups)
9887 (restore_cleanups, restore_final_cleanups): Don't declare.
9888 (do_final_cleanups): Remove parameter.
9889 * common/cleanups.c (cleanup_chain, make_cleanup)
9890 (make_cleanup_dtor, all_cleanups, do_cleanups)
9891 (discard_my_cleanups, discard_cleanups)
9892 (discard_final_cleanups, save_my_cleanups, save_cleanups)
9893 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9894 (null_cleanup): Remove.
9895 (do_final_cleanups): Remove parameter.
9896
c6321f19
TT
98972019-03-06 Tom Tromey <tom@tromey.com>
9898
9899 * remote.c (remote_target::remote_parse_stop_reply): Use
9900 unique_xmalloc_ptr.
9901
61b30099
TT
99022019-03-06 Tom Tromey <tom@tromey.com>
9903
9904 * stabsread.c (struct stabs_field_info): Rename from field_info.
9905 <list, fnlist>: Add initializers.
9906 <obstack>: New member.
9907 (read_member_functions, read_struct_fields, read_baseclasses):
9908 Allocate on obstack. Don't use cleanups.
9909 (read_one_struct_field, read_member_functions, read_struct_fields)
9910 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9911 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9912 (read_struct_type): Update.
9913
6cceac94
TT
99142019-03-06 Tom Tromey <tom@tromey.com>
9915
9916 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9917 * common/filestuff.h (make_cleanup_close): Don't declare.
9918 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9919 Remove.
9920
72412762
TT
99212019-03-06 Tom Tromey <tom@tromey.com>
9922
9923 * solib-aix.c: Use make_scope_exit.
9924
2b6ff1c0
TT
99252019-03-06 Tom Tromey <tom@tromey.com>
9926
9927 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9928 Use make_scope_exit.
9929
d01c5877
TT
99302019-03-06 Tom Tromey <tom@tromey.com>
9931
9932 * solib-svr4.c (disable_probes_interface): Remove parameter.
9933 (svr4_handle_solib_event): Use make_scope_exit.
9934
32603266
TT
99352019-03-06 Tom Tromey <tom@tromey.com>
9936
9937 * remote.c (struct stop_reply_deleter): Remove.
9938 (stop_reply_up): Update.
9939 (struct stop_reply): Derive from notif_event. Don't typedef.
9940 <regcache>: Now a std::vector.
9941 (stop_reply_xfree): Remove.
9942 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9943 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
9944 (remote_target::discard_pending_stop_replies): Use delete.
9945 (remote_target::remote_parse_stop_reply): Update.
9946 (remote_target::process_stop_reply): Update.
9947 * remote-notif.h (struct notif_event): Add virtual destructor.
9948 Remove "dtr" member.
9949 (struct notif_client) <alloc_event>: Return a unique_ptr.
9950 (notif_event_xfree): Don't declare.
9951 (notif_event_up): New typedef.
9952 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9953 (notif_event_xfree, do_notif_event_xfree): Remove.
9954 (remote_notif_state_xfree): Update.
9955
9799571e
TT
99562019-03-06 Tom Tromey <tom@tromey.com>
9957
9958 * infrun.c (displaced_step_clear_cleanup): Now a
9959 forward_scope_exit type.
9960 (displaced_step_prepare_throw): Update.
9961 (displaced_step_fixup): Update.
9962
09e3c4ca
TT
99632019-03-06 Tom Tromey <tom@tromey.com>
9964
9965 * inferior.h (class inferior): Update comment.
9966 * gdbthread.h (class thread_info): Update comment.
9967
e2a03548
TT
99682019-03-06 Joel Brobecker <brobecker@adacore.com>
9969 Tom Tromey <tom@tromey.com>
9970
9971 * stabsread.h (struct stab_section_list): Remove.
9972 (coffstab_build_psymtabs): Update.
9973 * dbxread.c (symbuf_sections): Now a std::vector.
9974 (sect_idx): New global.
9975 (fill_symbuf): Update.
9976 (coffstab_build_psymtabs): Change type of stabsects parameter.
9977 Update.
9978 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9979 std::vector.
9980 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9981 (coff_locate_sections): Update.
9982 (coff_symfile_read): Remove cleanups. Update.
9983 (init_stringtab): Add storage parameter.
9984 (free_stringtab, free_stringtab_cleanup): Remove.
9985 (init_lineno): Add storage parameter.
9986 (free_linetab, free_linetab_cleanup): Remove.
9987
b7e60d85
PA
99882019-03-06 Pedro Alves <palves@redhat.com>
9989
9990 * linux-fork.c (fork_info::clobber_regs): Delete.
9991 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9992 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
9993 comment. Adjust.
9994 (scoped_switch_fork_info::scoped_switch_fork_info)
9995 (checkpoint_command, linux_fork_context): Adjust
9996 fork_save_infrun_state calls.
9997
e52c971f
PA
99982019-03-06 Pedro Alves <palves@redhat.com>
9999
10000 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10001 (inf_has_multiple_threads): Return 'bool' and rewrite using
10002 inferior_info::threads().
10003
06974e6c
PA
100042019-03-06 Pedro Alves <palves@redhat.com>
10005
10006 * linux-fork.c: Include <list>.
10007 (fork_list): Now a std::list instance.
10008 (fork_info): Add ctor, dtor, and in-class initialize all fields.
10009 (forks_exist_p, find_last_fork): Adjust.
10010 (new_fork): Delete.
10011 (one_fork_p): New.
10012 (add_fork): Adjust.
10013 (free_fork): Delete, folded into fork_info::~fork_info().
10014 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10015 Adjust.
10016 (init_fork_list): Delete.
10017 (linux_fork_killall, linux_fork_mourn_inferior)
10018 (linux_fork_detach, info_checkpoints_command): Adjust.
10019 (_initialize_linux_fork): No longer call init_fork_list.
10020
72f31aea
PA
100212019-03-06 Pedro Alves <palves@redhat.com>
10022
10023 * linux-fork.c (new_fork): New, split out of ...
10024 (add_fork): ... this. Return void. Move "first fork" special
10025 case from here, to ...
10026 (checkpoint_command): ... here.
10027 * linux-linux.h (add_fork): Return void.
10028
efbecbc1
AB
100292019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10030
10031 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10032
0841c79a
AB
100332019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10034 Chris January <chris.january@arm.com>
10035 David Lecomber <david.lecomber@arm.com>
10036
10037 * f-exp.y: New token, UNOP_INTRINSIC.
10038 (exp): New pattern using UNOP_INTRINSIC token.
10039 (f77_keywords): Add 'abs' keyword.
10040 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10041 (value_from_host_double): New function.
10042 (evaluate_subexp_f): Support UNOP_ABS.
10043
4a270568
AB
100442019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10045
10046 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10047 types.
10048
067630bd
AB
100492019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10050
10051 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10052 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10053 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10054
3be47f7a
AB
100552019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10056
10057 * f-exp.y (convert_to_kind_type): Handle more type kinds.
10058
4d00f5d8
AB
100592019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10060 Chris January <chris.january@arm.com>
10061
10062 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10063 * f-exp.y: Define 'KIND' token.
10064 (exp): New pattern for KIND expressions.
10065 (ptype): Handle types with a kind extension.
10066 (direct_abs_decl): Extend to spot kind extensions.
10067 (f77_keywords): Add 'kind' to the list.
10068 (push_kind_type): New function.
10069 (convert_to_kind_type): New function.
10070 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10071 * parse.c (operator_length_standard): Likewise.
10072 * parser-defs.h (enum type_pieces): Add tp_kind.
10073 * std-operator.def: Add UNOP_KIND.
10074
e454224f
AB
100752019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10076
10077 * f-exp.y (f_parse): Set yydebug.
10078
9dad4a58
AB
100792019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10080
10081 * f-lang.c (evaluate_subexp_f): New function.
10082 (exp_descriptor_f): New global.
10083 (f_language_defn): Use exp_descriptor_f instead of
10084 exp_descriptor_standard.
10085
c8f91604
AB
100862019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10087
10088 * f-exp.y (struct token): Add comments.
10089 (dot_ops): Remove uppercase versions and the end marker.
10090 (f77_keywords): Likewise.
10091 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10092 entries in the dot_ops array are case insensitive, and use
10093 strncasecmp to compare strings. Also some whitespace cleanup in
10094 this area. Similar for the f77_keywords array, except entries in
10095 this list might be case sensitive.
10096
dd9f2c76
AB
100972019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
10098
10099 * f-exp.y (struct f77_boolean_val): Add comments.
10100 (boolean_values): Remove uppercase versions, and end marker.
10101 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10102 and use strncasecmp to achieve case insensitivity. Additionally,
10103 perform whitespace cleanup around this code.
10104
67a3048c
TT
101052019-03-06 Tom Tromey <tromey@adacore.com>
10106
10107 * remote-sim.c (gdbsim_target_open): Use result of
10108 gdb_argv::release.
10109
aa3cfbda
RB
101102019-03-06 Richard Bunt <richard.bunt@arm.com>
10111 Dirk Schubert <dirk.schubert@arm.com>
10112 Chris January <chris.january@arm.com>
10113
10114 * eval.c (evaluate_subexp_standard): Call Fortran argument
10115 wrapping logic.
10116 * f-lang.c (struct value): A value which can be passed into a
10117 Fortran function call.
10118 (fortran_argument_convert): Wrap Fortran arguments in a pointer
10119 where appropriate.
10120 (struct type): Value ready for a Fortran function call.
10121 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10122 is needed.
10123 * f-lang.h (fortran_argument_convert): Declaration.
10124 (fortran_preserve_arg_pointer): Declaration.
10125 * infcall.c (value_arg_coerce): Call Fortran argument logic.
10126
ea38e5df
TT
101272019-03-05 Tom Tromey <tromey@adacore.com>
10128
10129 * python/py-prettyprint.c (print_string_repr): Remove #if.
10130 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10131
06b5b831
TT
101322019-03-05 Tom Tromey <tromey@adacore.com>
10133
10134 * target.c (the_dummy_target): Move later. Change type to
10135 "dummy_target".
10136 (initialize_targets): Don't initialize the_dummy_target.
10137
edbd9e45
TT
101382019-03-05 Tom Tromey <tromey@adacore.com>
10139
10140 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10141 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10142
c119e040
TT
101432019-03-05 Tom Tromey <tromey@adacore.com>
10144
10145 * windows-nat.c (windows_nat_target::attach)
10146 (windows_nat_target::detach): Don't call gdb_flush.
10147 * valprint.c (generic_val_print, val_print, val_print_string):
10148 Don't call gdb_flush.
10149 * utils.c (defaulted_query): Don't call gdb_flush.
10150 * typeprint.c (print_type_scalar): Don't call gdb_flush.
10151 * target.c (target_announce_detach): Don't call gdb_flush.
10152 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10153 * remote.c (extended_remote_target::attach): Don't call
10154 gdb_flush.
10155 * procfs.c (procfs_target::detach): Don't call gdb_flush.
10156 * printcmd.c (do_examine): Don't call gdb_flush.
10157 (info_display_command): Don't call gdb_flush.
10158 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10159 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10160 * memattr.c (info_mem_command): Don't call gdb_flush.
10161 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10162 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10163 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10164 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10165 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10166 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10167 (gnu_nat_target::detach): Don't call gdb_flush.
10168 * f-valprint.c (f_val_print): Don't call gdb_flush.
10169 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10170 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10171 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10172 gdb_flush.
10173 * c-valprint.c (c_val_print): Don't call gdb_flush.
10174 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10175
895dafa6
TT
101762019-03-05 Tom Tromey <tromey@adacore.com>
10177
10178 * varobj.c (update_dynamic_varobj_children): Update.
10179 (install_default_visualizer): Use reset, not release.
10180 * value.c (set_internalvar): Update.
10181 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10182 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10183 ATTRIBUTE_UNUSED_RESULT.
10184
88a774b9
TT
101852019-03-05 Tom Tromey <tromey@adacore.com>
10186
10187 * remote.c (class scoped_remote_fd) <release>: Add
10188 ATTRIBUTE_UNUSED_RESULT.
10189
4e4a8b93
TT
101902019-03-05 Tom Tromey <tromey@adacore.com>
10191
10192 * macroexp.c (struct macro_buffer) <release>: Add
10193 ATTRIBUTE_UNUSED_RESULT.
10194
083eef1f
TT
101952019-03-05 Tom Tromey <tromey@adacore.com>
10196
10197 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10198 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10199 ATTRIBUTE_UNUSED_RESULT.
10200
3cabd438
TT
102012019-03-05 Tom Tromey <tromey@adacore.com>
10202
10203 * common/scoped_fd.h (class scoped_fd) <release>: Add
10204 ATTRIBUTE_UNUSED_RESULT.
10205
41e3300a
TT
102062019-03-05 Tom Tromey <tromey@adacore.com>
10207
10208 * parser-defs.h (struct parser_state) <release>: Add
10209 ATTRIBUTE_UNUSED_RESULT.
10210
18cb7c9f
TT
102112019-03-05 Tom Tromey <tromey@adacore.com>
10212
10213 * utils.h (class gdb_argv) <release>: Add
10214 ATTRIBUTE_UNUSED_RESULT.
10215 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10216
41fa577f
EZ
102172019-03-02 Eli Zaretskii <eliz@gnu.org>
10218
a6a4b2c6
EZ
10219 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10220 for-loop range, to avoid compiler warnings.
10221
10222 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10223 avoid compiler warnings about unused variables.
10224
742a7df5
EZ
10225 * NEWS: Mention end of support for native debugging on MS-Windows
10226 before XP.
10227
41fa577f
EZ
10228 PR gdb/24292
10229 * common/netstuff.c:
10230 * gdbserver/gdbreplay.c
10231 * gdbserver/remote-utils.c:
10232 * ser-tcp.c:
10233 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10234 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
10235 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10236 'getaddrinfo' and 'freeaddrinfo' were not available before
10237 Windows XP, and mingw.org's MinGW headers by default define
10238 _WIN32_WINNT to 0x500.
10239
827f438f
GB
102402019-03-01 Gary Benson <gbenson@redhat.com>
10241
10242 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10243
92137da0
RO
102442019-02-28 Brian Vandenberg <phantall@gmail.com>
10245 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
10246
10247 PR gdb/8527
10248 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10249 set_sigint_trap, clear_sigint_trap.
10250
799efbe8
PW
102512019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10252
10253 * target.c (target_detach): Clear the regcache and the
10254 frame cache.
10255
8ed25214
PA
102562019-02-27 Pedro Alves <palves@redhat.com>
10257
10258 * utils.c (set_screen_size): When we cap the height/width sizes,
10259 tweak the corresponding command variable to show "unlimited":
10260
23031e31
SJ
102612019-02-27 Saagar Jha <saagar@saagarjha.com>
10262 Pedro Alves <palves@redhat.com>
10263
10264 * utils.c (set_screen_size): Reduce "infinite" rows and columns
10265 before calling rl_set_screen_size.
10266
6c28e44a
TT
102672019-02-27 Tom Tromey <tromey@adacore.com>
10268
10269 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10270 define.
10271 * python/py-value.c: Remove Python 2.4 workaround.
10272 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10273 workaround.
10274 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10275 Python 2.4 workaround.
10276 * python/python-internal.h: Remove Python 2.4 comment.
10277 (Py_ssize_t): Don't define.
10278 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10279 (gdb_Py_DECREF): Remove Python 2.4 workaround.
10280 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10281 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10282 * python/python.c (do_start_initialization): Remove Python 2.4
10283 workaround.
10284 * python/py-prettyprint.c (class dummy_python_frame): Remove.
10285 (print_children): Remove Python 2.4 workaround.
10286 * python/py-inferior.c (buffer_procs): Remove Python 2.4
10287 workaround.
10288 (CHARBUFFERPROC_NAME): Remove.
10289 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10290 Python 2.4 workaround.
10291
2c3fc25d 102922019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 10293
2c3fc25d
KB
10294 * NEWS: Note minimum Python version.
10295
6ca62222
KB
102962019-02-27 Kevin Buettner <kevinb@redhat.com>
10297
10298 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10299 code from these functions. Remove corresponding ifdefs. Use
10300 Py_buffer_up instead of explicit calls to PyBuffer_Release.
10301 Remove gotos and target of gotos.
10302 (infpy_search_memory): Likewise.
10303
f4bc7d2c
AB
103042019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10305
10306 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10307 (hppa_gdbarch_init): Don't register deleted functions with
10308 gdbarch.
10309
9734a586
AB
103102019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10311
10312 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10313 (h8300_unwind_sp): Delete.
10314 (h8300_dummy_id): Delete.
10315 (h8300_gdbarch_init): Don't register deleted functions with
10316 gdbarch.
10317
68b867f3
AB
103182019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10319
10320 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10321 (ft32_unwind_pc): Delete.
10322 (ft32_unwind_sp): Delete.
10323 (ft32_gdbarch_init): Don't register deleted functions with
10324 gdbarch.
10325
2fbe7ad0
AB
103262019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10327
10328 * gdb/frv-tdep.c (frv_dummy_id): Delete.
10329 (frv_unwind_pc): Delete.
10330 (frv_unwind_sp): Delete.
10331 (frv_gdbarch_init): Don't register deleted functions with
10332 gdbarch.
10333
76055cbe
AB
103342019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10335
10336 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10337 (riscv_unwind_pc): Delete.
10338 (riscv_unwind_sp): Delete.
10339 (riscv_gdbarch_init): Don't register deleted functions with
10340 gdbarch.
10341
4133e5a1
AB
103422019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10343
10344 * gdb/csky-tdep.c (csky_dummy_id): Delete.
10345 (csky_unwind_pc): Delete.
10346 (csky_unwind_sp): Delete.
10347 (csky_gdbarch_init): Don't register deleted functions with
10348 gdbarch.
10349
8010f576
AB
103502019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10351
10352 * gdb/cris-tdep.c (cris_dummy_id): Delete.
10353 (cris_unwind_pc): Delete.
10354 (cris_unwind_sp): Delete.
10355 (cris_gdbarch_init): Don't register deleted functions with
10356 gdbarch.
10357
b56bf084
AB
103582019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10359
10360 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10361 (bfin_unwind_pc): Delete.
10362 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10363
a19a650f
AB
103642019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10365
10366 * gdb/arm-tdep.c (arm_dummy_id): Delete.
10367 (arm_unwind_pc): Delete.
10368 (arm_unwind_sp): Delete.
10369 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10370
f8278c3c
AB
103712019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10372
10373 * gdb/arc-tdep.c (arc_dummy_id): Delete.
10374 (arc_unwind_pc): Delete.
10375 (arc_unwind_sp): Delete.
10376 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10377
480e46cf
AB
103782019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10379
10380 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10381 (alpha_unwind_pc): Delete.
10382 (alpha_gdbarch_init): Don't register deleted functions with
10383 gdbarch.
10384
7a995095
AB
103852019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10386
10387 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10388 (aarch64_unwind_pc): Delete.
10389 (aarch64_unwind_sp): Delete.
10390 (aarch64_gdbarch_init): Don't register deleted functions with
10391 gdbarch.
10392
bf9a735e
AB
103932019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10394
10395 * gdbtypes.c (type_align): Don't consider static members when
10396 computing structure alignment.
10397
5561fc30
AB
103982019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
10399
10400 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10401 return 0 for other types.
10402 * arch-utils.c (default_type_align): Always return 0.
10403 * gdbarch.h: Regenerate.
10404 * gdbarch.sh (type_align): Extend comment.
10405 * gdbtypes.c (type_align): Add additional comments, always call
10406 gdbarch_type_align before applying the default rules.
10407 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10408 generic code will then apply a suitable default.
10409 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10410 types, return 0 for other types.
10411
9335e75a
JB
104122019-02-27 Joel Brobecker <brobecker@adacore.com>
10413
10414 * NEWS: Create a new section for the next release branch.
10415 Rename the section of the current branch, now that it has
10416 been cut.
10417
3d34d8de
JB
104182019-02-27 Joel Brobecker <brobecker@adacore.com>
10419
10420 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10421 * version.in: Bump version to 8.3.50.DATE-git.
10422
143420fb
SM
104232019-02-26 Simon Marchi <simon.marchi@efficios.com>
10424
10425 * aix-thread.c (ptid_cmp): Remove unused variable.
10426 (get_signaled_thread): Likewise.
10427 (store_regs_user_thread): Likewise.
10428 (store_regs_kernel_thread): Likewise.
10429 (fetch_regs_kernel_thread): Remove shadowed variable.
10430
172fb711
AB
104312019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
10432
10433 * features/riscv/32bit-cpu.xml: Add register numbers.
10434 * features/riscv/32bit-fpu.c: Regenerate.
10435 * features/riscv/32bit-fpu.xml: Add register numbers.
10436 * features/riscv/64bit-cpu.xml: Add register numbers.
10437 * features/riscv/64bit-fpu.c: Regenerate.
10438 * features/riscv/64bit-fpu.xml: Add register numbers.
10439
26c89782
KB
104402019-02-26 Kevin Buettner <kevinb@redhat.com>
10441
af54ade9 10442 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
10443 * python/py-value.c (convert_buffer_and_type_to_value): New
10444 function.
10445 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10446 Add support for handling an optional second argument. Call
10447 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
10448 * python/python-internal.h (Py_buffer_deleter): New struct.
10449 (Py_buffer_up): New typedef.
10450
0f58c9e8
JB
104512019-02-25 John Baldwin <jhb@FreeBSD.org>
10452
10453 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10454 instead of releasing ownership.
10455
0a0f4c01
JR
104562019-02-25 Jordan Rupprecht <rupprecht@google.com>
10457
10458 * dwarf2read.c (open_and_init_dwp_file): Call
10459 elf_numsections instead of bfd_count_sections to initialize
10460 dwp_file->num_sections.
10461
cd5a152c
TT
104622019-02-25 Tom Tromey <tromey@adacore.com>
10463
10464 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10465
8a6a8513
SDJ
104662019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
10467
10468 * gcore.in: Add '--readnever' option when invoking GDB.
10469
04dcda9c
SM
104702019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10471
10472 * MAINTAINERS: Update my email address.
10473
07bc701d
SM
104742019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
10475
10476 * build-id.c (build_id_to_debug_bfd_1): New function.
10477 (build_id_to_debug_bfd): Look for separate debug file in
10478 sysroot.
10479
c6f4a5d0
AB
104802019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
10481
10482 * gdbarch.sh: Update the copyright year range that is placed into
10483 generated files.
10484
9600246d
KS
104852019-02-22 Keith Seitz <keiths@redhat.com>
10486
10487 PR symtab/23853
10488 * linespec.c (create_sals_line_offset): Search for the default
10489 symtab's filename instead of its fullname.
10490
7557a514
AH
104912019-02-21 Alan Hayward <alan.hayward@arm.com>
10492
10493 * NEWS: Update style defaults.
10494
ee2bcb0c
AH
104952019-02-21 Alan Hayward <alan.hayward@arm.com>
10496
10497 * main.c (captured_main_1): Disable styling in batch mode.
10498
0c95f9ed
TT
104992019-02-20 Tom Tromey <tom@tromey.com>
10500
10501 * symtab.c (symtab_symbol_info): Fix typos.
10502
c763b894
TT
105032019-02-20 Tom Tromey <tromey@adacore.com>
10504
10505 * findcmd.c (_initialize_mem_search): Use upper case for
10506 metasyntactic variables.
10507
0ef8a082
AH
105082019-02-20 Alan Hayward <alan.hayward@arm.com>
10509
10510 * aarch64-tdep.c (aarch64_add_reggroups): New function.
10511 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10512
6caa91b6
SM
105132019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
10514
10515 * top.h (source_file_name): Change to std::string.
10516 * top.c (source_file_name): Likewise.
10517 (command_line_input): Adjust.
10518 * cli/cli-script.c (script_from_file): Adjust.
10519
98814c6c
TT
105202019-02-19 Tom Tromey <tromey@adacore.com>
10521
10522 * ravenscar-thread.c
10523 (ravenscar_thread_target::update_thread_list): Don't call
10524 ada_build_task_list.
10525 * ada-lang.h (ada_build_task_list): Don't declare.
10526 * ada-tasks.c (struct ada_tasks_inferior_data)
10527 <task_list_valid_p>: Now bool.
10528 (read_known_tasks, ada_task_list_changed)
10529 (ada_tasks_invalidate_inferior_data): Update.
10530 (read_known_tasks_array): Return bool.
10531 (read_known_tasks_list): Likewise.
10532 (read_known_tasks): Return void.
10533 (ada_build_task_list): Now static.
10534
70cd633e
AB
105352019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
10536
10537 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10538 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10539
040b3e95
PW
105402019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10541
10542 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10543 variant for ada_tasks_pspace_data_handle and
10544 ada_tasks_inferior_data_handle.
10545 (ada_tasks_pspace_data_cleanup): New function.
10546 (ada_tasks_inferior_data_cleanup): New function.
10547
9409233b
TT
105482019-02-17 Tom Tromey <tom@tromey.com>
10549
10550 * macrotab.h (macro_source_fullname): Return a std::string.
10551 * macrotab.c (macro_include, check_for_redefinition)
10552 (macro_undef, macro_lookup_definition, foreach_macro)
10553 (foreach_macro_in_scope): Update.
10554 (macro_source_fullname): Return a std::string.
10555 * macrocmd.c (show_pp_source_pos): Update.
10556
6506371f
TT
105572019-02-17 Tom Tromey <tom@tromey.com>
10558
10559 * macrocmd.c (show_pp_source_pos): Style the file names.
10560
0c820d67
TT
105612019-02-17 Tom Tromey <tom@tromey.com>
10562
10563 PR tui/24197:
10564 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10565
a0087920
TT
105662019-02-17 Tom Tromey <tom@tromey.com>
10567
10568 * ada-lang.c (user_select_syms): Use filtered printing.
10569 * utils.c (wrap_style): New global.
10570 (desired_style): Remove.
10571 (emit_style_escape): Add stream parameter.
10572 (set_output_style, reset_terminal_style, prompt_for_continue):
10573 Update.
10574 (flush_wrap_buffer): Only flush gdb_stdout.
10575 (wrap_here): Set wrap_style.
10576 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
10577 treat escape sequences as a character. Change when wrap buffer is
10578 flushed.
10579 (fputs_styled): Do not set the output style when the default is
10580 requested.
10581 * ui-style.h (struct ui_file_style) <is_default>: New method.
10582 * source.c (print_source_lines_base): Emit escape sequences in one
10583 piece.
10584
75ba10dc
JB
105852019-02-17 Joel Brobecker <brobecker@adacore.com>
10586
10587 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10588 integers and enumeration types.
10589
a2cd4f14
JB
105902019-02-17 Joel Brobecker <brobecker@adacore.com>
10591
10592 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10593 instead of lookup_symbol_in_language
10594 (do_exact_match): New function.
10595 (ada_get_symbol_name_matcher): Return do_exact_match when
10596 doing a verbatim match.
10597
485b851b
TT
105982019-02-15 Tom Tromey <tromey@adacore.com>
10599
10600 * ravenscar-thread.c (ravenscar_thread_target::resume)
10601 (ravenscar_thread_target::wait): Special case wildcard requests.
10602
0b790b1e
TT
106032019-02-15 Tom Tromey <tromey@adacore.com>
10604
10605 * ravenscar-thread.c (base_ptid): Remove.
10606 (struct ravenscar_thread_target) <close>: New method.
10607 <m_base_ptid>: New member.
10608 <update_inferior_ptid, active_task, task_is_currently_active,
10609 runtime_initialized>: Declare methods.
10610 <ravenscar_thread_target>: Add constructor.
10611 (ravenscar_thread_target::task_is_currently_active)
10612 (ravenscar_thread_target::update_inferior_ptid)
10613 (ravenscar_runtime_initialized): Rename. Now methods.
10614 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10615 (ravenscar_thread_target::update_thread_list): Update.
10616 (ravenscar_thread_target::active_task): Now method.
10617 (ravenscar_thread_target::store_registers)
10618 (ravenscar_thread_target::prepare_to_store)
10619 (ravenscar_thread_target::prepare_to_store)
10620 (ravenscar_thread_target::mourn_inferior): Update.
10621 (ravenscar_inferior_created): Use "new" to create target.
10622 (ravenscar_thread_target::get_ada_task_ptid): Update.
10623 (_initialize_ravenscar): Don't initialize base_ptid.
10624 (ravenscar_ops): Remove global.
10625
dea57a62
TT
106262019-02-15 Tom Tromey <tromey@adacore.com>
10627
10628 * target.h (push_target): Declare new overload.
10629 * target.c (push_target): New overload, taking an rvalue reference.
10630 * remote.c (remote_target::open_1): Use push_target overload.
10631 * corelow.c (core_target_open): Use push_target overload.
10632
989f3c58
TT
106332019-02-15 Tom Tromey <tromey@adacore.com>
10634
10635 * ravenscar-thread.c (is_ravenscar_task)
10636 (ravenscar_task_is_currently_active): Return bool.
10637 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10638 (_initialize_ravenscar): Remove "(void)".
10639 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10640 Return bool.
10641
6cbcc006
TT
106422019-02-15 Tom Tromey <tromey@adacore.com>
10643
10644 * ravenscar-thread.c (ravenscar_runtime_initializer)
10645 (has_ravenscar_runtime, get_running_thread_id)
10646 (ravenscar_thread_target::resume): Fix indentation.
10647
7657f14d
TT
106482019-02-15 Tom Tromey <tromey@adacore.com>
10649
10650 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10651 from ravenscar_arch_ops.
10652 (sparc_ravenscar_ops::fetch_registers)
10653 (sparc_ravenscar_ops::store_registers): Now methods.
10654 (sparc_ravenscar_prepare_to_store): Remove.
10655 (sparc_ravenscar_ops): Redefine.
10656 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10657 methods and destructor. Remove members.
10658 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10659 (ravenscar_thread_target::store_registers)
10660 (ravenscar_thread_target::prepare_to_store): Update.
10661 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10662 Remove.
10663 (struct ppc_ravenscar_powerpc_ops): Derive from
10664 ravenscar_arch_ops.
10665 (ppc_ravenscar_powerpc_ops::fetch_registers)
10666 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10667 (ppc_ravenscar_powerpc_ops): Redefine.
10668 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10669 (ppc_ravenscar_e500_ops::fetch_registers)
10670 (ppc_ravenscar_e500_ops::store_registers): Now methods.
10671 (ppc_ravenscar_e500_ops): Redefine.
10672 * aarch64-ravenscar-thread.c
10673 (aarch64_ravenscar_generic_prepare_to_store): Remove.
10674 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10675 (aarch64_ravenscar_fetch_registers)
10676 (aarch64_ravenscar_store_registers): Now methods.
10677 (aarch64_ravenscar_ops): Redefine.
10678
5b6ea500
TT
106792019-02-15 Tom Tromey <tromey@adacore.com>
10680
10681 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10682 (ravenscar_thread_target::stopped_by_hw_breakpoint)
10683 (ravenscar_thread_target::stopped_by_watchpoint)
10684 (ravenscar_thread_target::stopped_data_address)
10685 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10686
e397fd39
TT
106872019-02-15 Tom Tromey <tromey@adacore.com>
10688
10689 * ravenscar-thread.c: Fix some typos.
10690
cc12f4a8
TT
106912019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10692 Tom Tromey <tromey@adacore.com>
10693
10694 * ada-lang.c (ada_exception_sal): Change addr_string to a
10695 std::string.
10696 (create_ada_exception_catchpoint): Update.
10697
5f486660
TT
106982019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10699 Tom Tromey <tromey@adacore.com>
10700
10701 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10702 (bp_location_ops): Remove.
10703 (base_breakpoint_allocate_location): Update.
10704 (free_bp_location): Update.
10705 * ada-lang.c (class ada_catchpoint_location)
10706 <ada_catchpoint_location>: Remove ops parameter.
10707 (ada_catchpoint_location_dtor): Remove.
10708 (ada_catchpoint_location_ops): Remove.
10709 (allocate_location_exception): Update.
10710 * breakpoint.h (struct bp_location_ops): Remove.
10711 (class bp_location) <bp_location>: Remove bp_location_ops
10712 parameter.
10713 <~bp_location>: Add destructor.
10714 <ops>: Remove.
10715
b671c7fb
TS
107162019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10717 Pedro Alves <palves@redhat.com>
10718
10719 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10720 'PATH_MAX'.
10721
8071c5ce
DM
107222019-02-14 David Michael <fedora.dm0@gmail.com>
10723 Samuel Thibault <samuel.thibault@gnu.org>
10724 Thomas Schwinge <thomas@codesourcery.com>
10725
10726 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10727 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10728
b1041ae0
TS
107292019-02-14 Thomas Schwinge <thomas@codesourcery.com>
10730
924514e1
TS
10731 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10732 (check_empty): Use "const char *".
10733
c29ee8d4
TS
10734 * gnu-nat.c (gnu_nat_target::detach): Instead of
10735 'detach_inferior (pid)' call
10736 'detach_inferior (find_inferior_pid (pid))'.
10737
6c6ef69f
TS
10738 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10739 'nat/fork-inferior.o'.
10740 * gnu-nat.c: #include "nat/fork-inferior.h".
10741
2d0a338c
TS
10742 * gnu-nat.c (gnu_nat_target::detach): Instead of
10743 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10744 * gnu-nat.h: #include "inf-child.h".
10745 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10746 'i386_gnu_nat_target::fetch_registers'.
10747 (gnu_store_registers): Rename/move to
10748 'i386_gnu_nat_target::store_registers'.
10749
cabb5f06
TS
10750 * config/i386/nm-i386gnu.h: Don't "#include" any files.
10751 * gnu-nat.h (mach_thread_info): New function.
10752 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10753
b1041ae0
TS
10754 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10755
2988d01e
KF
107562019-02-14 Frederic Konrad <konrad@adacore.com>
10757
10758 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10759
c559d709
JB
107602019-02-14 Joel Brobecker <brobecker@adacore.com>
10761
10762 * windows-nat.c (windows_add_thread): Add new parameter
10763 "main_thread_p" with default value set to false. Update
10764 function documentation as well as all callers.
10765 (windows_delete_thread): Likewise.
10766 (fake_create_process): Update call to windows_add_thread.
10767 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10768 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10769 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10770 call to windows_delete_thread.
10771
007024cc
SM
107722019-02-13 Simon Marchi <simon.marchi@ericsson.com>
10773
10774 * MAINTAINERS: Add Andrew Burgess as global maintainer.
10775
f62318e9
JB
107762019-02-12 John Baldwin <jhb@FreeBSD.org>
10777
10778 * symfile.c (find_separate_debug_file): Use canonical path of
10779 sysroot with child_path instead of gdb_sysroot if it is valid.
10780
cd4b7848
JB
107812019-02-12 John Baldwin <jhb@FreeBSD.org>
10782
10783 * symfile.c (find_separate_debug_file): Use child_path to
10784 determine if an object file is under a sysroot.
10785
efac4bfe
JB
107862019-02-12 John Baldwin <jhb@FreeBSD.org>
10787
10788 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10789 unittests/child-path-selftests.c.
10790 * common/pathstuff.c (child_path): New function.
10791 * common/pathstuff.h (child_path): New prototype.
10792 * unittests/child-path-selftests.c: New file.
10793
402d2bfe
JB
107942019-02-12 John Baldwin <jhb@FreeBSD.org>
10795
10796 * symfile.c (find_separate_debug_file): Look for separate debug
10797 files in debug directories under the sysroot.
10798
1ed9f74e
PW
107992019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10800
10801 * symtab.h (struct minimal_symbol data_p): New const method.
10802 (struct minimal_symbol text_p): Likewise.
10803 * symtab.c (output_source_filename): Use file name style
10804 to print file name.
10805 (print_symbol_info): Likewise.
10806 (print_msymbol_info): Use address style to print addresses.
10807 Use function name style to print executable text symbols.
10808 (expand_symtab_containing_pc): Use data_p.
10809 (find_pc_sect_compunit_symtab): Likewise.
10810
2636d81d
PW
108112019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10812
10813 * breakpoint.c (describe_other_breakpoints): Use address style
10814 to print addresses.
10815 (say_where): Likewise.
10816
ac8c53cc
PW
108172019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10818
10819 * ada-typeprint.c (print_func_type): Print function name
10820 style to print function name.
10821 * c-typeprint.c (c_print_type_1): Likewise.
10822
ea638c43
AH
108232019-02-11 Alan Hayward <alan.hayward@arm.com>
10824
10825 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10826 for execve.
10827
ab759ca8
PW
108282019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10829
10830 * c-exp.y (direct_abs_decl): Use emplace_back to record the
10831 type_stack.
10832
aff29d1c
JB
108332019-02-10 Joel Brobecker <brobecker@adacore.com>
10834
10835 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10836 TYPE_CODE_REF types.
10837
617126bc
JW
108382019-02-08 Jim Wilson <jimw@sifive.com>
10839
10840 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10841 (riscv_linux_fregset): New.
10842 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10843
46e3ed7f
TT
108442019-02-07 Tom Tromey <tom@tromey.com>
10845
10846 * thread.c (thread_cancel_execution_command): Update.
10847 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10848 methods.
10849 (struct thread_fsm_ops): Remove.
10850 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10851 (thread_fsm_should_stop, thread_fsm_return_value)
10852 (thread_fsm_set_finished, thread_fsm_finished_p)
10853 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10854 Don't declare.
10855 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10856 * infrun.c (clear_proceed_status_thread)
10857 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10858 (print_stop_event): Update.
10859 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10860 Add constructor.
10861 (step_command_fsm_ops): Remove.
10862 (new_step_command_fsm): Remove.
10863 (step_1): Update.
10864 (step_command_fsm::should_stop): Rename from
10865 step_command_fsm_should_stop.
10866 (step_command_fsm::clean_up): Rename from
10867 step_command_fsm_clean_up.
10868 (step_command_fsm::do_async_reply_reason): Rename from
10869 step_command_fsm_async_reply_reason.
10870 (struct until_next_fsm): Inherit from thread_fsm. Add
10871 constructor.
10872 (until_next_fsm_ops): Remove.
10873 (new_until_next_fsm): Remove.
10874 (until_next_fsm::should_stop): Rename from
10875 until_next_fsm_should_stop.
10876 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10877 (until_next_fsm::do_async_reply_reason): Rename from
10878 until_next_fsm_async_reply_reason.
10879 (struct finish_command_fsm): Inherit from thread_fsm. Add
10880 constructor. Change type of breakpoint.
10881 (finish_command_fsm_ops): Remove.
10882 (new_finish_command_fsm): Remove.
10883 (finish_command_fsm::should_stop): Rename from
10884 finish_command_fsm_should_stop.
10885 (finish_command_fsm::clean_up): Rename from
10886 finish_command_fsm_clean_up.
10887 (finish_command_fsm::return_value): Rename from
10888 finish_command_fsm_return_value.
10889 (finish_command_fsm::do_async_reply_reason): Rename from
10890 finish_command_fsm_async_reply_reason.
10891 (finish_command): Update.
10892 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10893 Add constructor.
10894 (call_thread_fsm_ops): Remove.
10895 (call_thread_fsm::call_thread_fsm): Rename from
10896 new_call_thread_fsm.
10897 (call_thread_fsm::should_stop): Rename from
10898 call_thread_fsm_should_stop.
10899 (call_thread_fsm::should_notify_stop): Rename from
10900 call_thread_fsm_should_notify_stop.
10901 (run_inferior_call, call_function_by_hand_dummy): Update.
10902 * cli/cli-interp.c (should_print_stop_to_console): Update.
10903 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10904 Add constructor. Change type of location_breakpoint,
10905 caller_breakpoint.
10906 (until_break_fsm_ops): Remove.
10907 (new_until_break_fsm): Remove.
10908 (until_break_fsm::should_stop): Rename from
10909 until_break_fsm_should_stop.
10910 (until_break_fsm::clean_up): Rename from
10911 until_break_fsm_clean_up.
10912 (until_break_fsm::do_async_reply_reason): Rename from
10913 until_break_fsm_async_reply_reason.
10914 (until_break_command): Update.
10915 * thread-fsm.c: Remove.
10916 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10917
1a5c2598
TT
109182019-02-07 Tom Tromey <tom@tromey.com>
10919
10920 * yy-remap.h: Add include guard.
10921 * xtensa-tdep.h: Add include guard.
10922 * xcoffread.h: Rename include guard.
10923 * varobj-iter.h: Add include guard.
10924 * tui/tui.h: Rename include guard.
10925 * tui/tui-winsource.h: Rename include guard.
10926 * tui/tui-wingeneral.h: Rename include guard.
10927 * tui/tui-windata.h: Rename include guard.
10928 * tui/tui-win.h: Rename include guard.
10929 * tui/tui-stack.h: Rename include guard.
10930 * tui/tui-source.h: Rename include guard.
10931 * tui/tui-regs.h: Rename include guard.
10932 * tui/tui-out.h: Rename include guard.
10933 * tui/tui-layout.h: Rename include guard.
10934 * tui/tui-io.h: Rename include guard.
10935 * tui/tui-hooks.h: Rename include guard.
10936 * tui/tui-file.h: Rename include guard.
10937 * tui/tui-disasm.h: Rename include guard.
10938 * tui/tui-data.h: Rename include guard.
10939 * tui/tui-command.h: Rename include guard.
10940 * tic6x-tdep.h: Add include guard.
10941 * target/waitstatus.h: Rename include guard.
10942 * target/wait.h: Rename include guard.
10943 * target/target.h: Rename include guard.
10944 * target/resume.h: Rename include guard.
10945 * target-float.h: Rename include guard.
10946 * stabsread.h: Add include guard.
10947 * rs6000-tdep.h: Add include guard.
10948 * riscv-fbsd-tdep.h: Add include guard.
10949 * regformats/regdef.h: Rename include guard.
10950 * record.h: Rename include guard.
10951 * python/python.h: Rename include guard.
10952 * python/python-internal.h: Rename include guard.
10953 * python/py-stopevent.h: Rename include guard.
10954 * python/py-ref.h: Rename include guard.
10955 * python/py-record.h: Rename include guard.
10956 * python/py-record-full.h: Rename include guard.
10957 * python/py-record-btrace.h: Rename include guard.
10958 * python/py-instruction.h: Rename include guard.
10959 * python/py-events.h: Rename include guard.
10960 * python/py-event.h: Rename include guard.
10961 * procfs.h: Add include guard.
10962 * proc-utils.h: Add include guard.
10963 * p-lang.h: Add include guard.
10964 * or1k-tdep.h: Rename include guard.
10965 * observable.h: Rename include guard.
10966 * nto-tdep.h: Rename include guard.
10967 * nat/x86-linux.h: Rename include guard.
10968 * nat/x86-linux-dregs.h: Rename include guard.
10969 * nat/x86-gcc-cpuid.h: Add include guard.
10970 * nat/x86-dregs.h: Rename include guard.
10971 * nat/x86-cpuid.h: Rename include guard.
10972 * nat/ppc-linux.h: Rename include guard.
10973 * nat/mips-linux-watch.h: Rename include guard.
10974 * nat/linux-waitpid.h: Rename include guard.
10975 * nat/linux-ptrace.h: Rename include guard.
10976 * nat/linux-procfs.h: Rename include guard.
10977 * nat/linux-osdata.h: Rename include guard.
10978 * nat/linux-nat.h: Rename include guard.
10979 * nat/linux-namespaces.h: Rename include guard.
10980 * nat/linux-btrace.h: Rename include guard.
10981 * nat/glibc_thread_db.h: Rename include guard.
10982 * nat/gdb_thread_db.h: Rename include guard.
10983 * nat/gdb_ptrace.h: Rename include guard.
10984 * nat/fork-inferior.h: Rename include guard.
10985 * nat/amd64-linux-siginfo.h: Rename include guard.
10986 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10987 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10988 * nat/aarch64-linux.h: Rename include guard.
10989 * nat/aarch64-linux-hw-point.h: Rename include guard.
10990 * mn10300-tdep.h: Add include guard.
10991 * mips-linux-tdep.h: Add include guard.
10992 * mi/mi-parse.h: Rename include guard.
10993 * mi/mi-out.h: Rename include guard.
10994 * mi/mi-main.h: Rename include guard.
10995 * mi/mi-interp.h: Rename include guard.
10996 * mi/mi-getopt.h: Rename include guard.
10997 * mi/mi-console.h: Rename include guard.
10998 * mi/mi-common.h: Rename include guard.
10999 * mi/mi-cmds.h: Rename include guard.
11000 * mi/mi-cmd-break.h: Rename include guard.
11001 * m2-lang.h: Add include guard.
11002 * location.h: Rename include guard.
11003 * linux-record.h: Rename include guard.
11004 * linux-nat.h: Add include guard.
11005 * linux-fork.h: Add include guard.
11006 * i386-darwin-tdep.h: Rename include guard.
11007 * hppa-linux-offsets.h: Add include guard.
11008 * guile/guile.h: Rename include guard.
11009 * guile/guile-internal.h: Rename include guard.
11010 * gnu-nat.h: Rename include guard.
11011 * gdb-stabs.h: Rename include guard.
11012 * frv-tdep.h: Add include guard.
11013 * f-lang.h: Add include guard.
11014 * event-loop.h: Add include guard.
11015 * darwin-nat.h: Rename include guard.
11016 * cp-abi.h: Rename include guard.
11017 * config/sparc/nm-sol2.h: Rename include guard.
11018 * config/nm-nto.h: Rename include guard.
11019 * config/nm-linux.h: Add include guard.
11020 * config/i386/nm-i386gnu.h: Rename include guard.
11021 * config/djgpp/nl_types.h: Rename include guard.
11022 * config/djgpp/langinfo.h: Rename include guard.
11023 * compile/gcc-cp-plugin.h: Add include guard.
11024 * compile/gcc-c-plugin.h: Add include guard.
11025 * compile/compile.h: Rename include guard.
11026 * compile/compile-object-run.h: Rename include guard.
11027 * compile/compile-object-load.h: Rename include guard.
11028 * compile/compile-internal.h: Rename include guard.
11029 * compile/compile-cplus.h: Rename include guard.
11030 * compile/compile-c.h: Rename include guard.
11031 * common/xml-utils.h: Rename include guard.
11032 * common/x86-xstate.h: Rename include guard.
11033 * common/version.h: Rename include guard.
11034 * common/vec.h: Rename include guard.
11035 * common/tdesc.h: Rename include guard.
11036 * common/selftest.h: Rename include guard.
11037 * common/scoped_restore.h: Rename include guard.
11038 * common/scoped_mmap.h: Rename include guard.
11039 * common/scoped_fd.h: Rename include guard.
11040 * common/safe-iterator.h: Rename include guard.
11041 * common/run-time-clock.h: Rename include guard.
11042 * common/refcounted-object.h: Rename include guard.
11043 * common/queue.h: Rename include guard.
11044 * common/ptid.h: Rename include guard.
11045 * common/print-utils.h: Rename include guard.
11046 * common/preprocessor.h: Rename include guard.
11047 * common/pathstuff.h: Rename include guard.
11048 * common/observable.h: Rename include guard.
11049 * common/netstuff.h: Rename include guard.
11050 * common/job-control.h: Rename include guard.
11051 * common/host-defs.h: Rename include guard.
11052 * common/gdb_wait.h: Rename include guard.
11053 * common/gdb_vecs.h: Rename include guard.
11054 * common/gdb_unlinker.h: Rename include guard.
11055 * common/gdb_unique_ptr.h: Rename include guard.
11056 * common/gdb_tilde_expand.h: Rename include guard.
11057 * common/gdb_sys_time.h: Rename include guard.
11058 * common/gdb_string_view.h: Rename include guard.
11059 * common/gdb_splay_tree.h: Rename include guard.
11060 * common/gdb_setjmp.h: Rename include guard.
11061 * common/gdb_ref_ptr.h: Rename include guard.
11062 * common/gdb_optional.h: Rename include guard.
11063 * common/gdb_locale.h: Rename include guard.
11064 * common/gdb_assert.h: Rename include guard.
11065 * common/filtered-iterator.h: Rename include guard.
11066 * common/filestuff.h: Rename include guard.
11067 * common/fileio.h: Rename include guard.
11068 * common/environ.h: Rename include guard.
11069 * common/common-utils.h: Rename include guard.
11070 * common/common-types.h: Rename include guard.
11071 * common/common-regcache.h: Rename include guard.
11072 * common/common-inferior.h: Rename include guard.
11073 * common/common-gdbthread.h: Rename include guard.
11074 * common/common-exceptions.h: Rename include guard.
11075 * common/common-defs.h: Rename include guard.
11076 * common/common-debug.h: Rename include guard.
11077 * common/cleanups.h: Rename include guard.
11078 * common/buffer.h: Rename include guard.
11079 * common/btrace-common.h: Rename include guard.
11080 * common/break-common.h: Rename include guard.
11081 * cli/cli-utils.h: Rename include guard.
11082 * cli/cli-style.h: Rename include guard.
11083 * cli/cli-setshow.h: Rename include guard.
11084 * cli/cli-script.h: Rename include guard.
11085 * cli/cli-interp.h: Rename include guard.
11086 * cli/cli-decode.h: Rename include guard.
11087 * cli/cli-cmds.h: Rename include guard.
11088 * charset-list.h: Add include guard.
11089 * buildsym-legacy.h: Rename include guard.
11090 * bfin-tdep.h: Add include guard.
11091 * ax.h: Rename include guard.
11092 * arm-linux-tdep.h: Add include guard.
11093 * arm-fbsd-tdep.h: Add include guard.
11094 * arch/xtensa.h: Rename include guard.
11095 * arch/tic6x.h: Add include guard.
11096 * arch/i386.h: Add include guard.
11097 * arch/arm.h: Rename include guard.
11098 * arch/arm-linux.h: Rename include guard.
11099 * arch/arm-get-next-pcs.h: Rename include guard.
11100 * arch/amd64.h: Add include guard.
11101 * arch/aarch64-insn.h: Rename include guard.
11102 * arch-utils.h: Rename include guard.
11103 * annotate.h: Add include guard.
11104 * amd64-darwin-tdep.h: Rename include guard.
11105 * aarch64-linux-tdep.h: Add include guard.
11106 * aarch64-fbsd-tdep.h: Add include guard.
11107 * aarch32-linux-nat.h: Add include guard.
11108
ab9268d2
PW
111092019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11110
11111 * macrotab.c (macro_define_internal): New function that
11112 factorizes macro_define_object_internal and macro_define_function
11113 code.
11114 (macro_define_object_internal): Use macro_define_internal.
11115 (macro_define_function): Likewise.
11116
bb0da2b4
PW
111172019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11118
11119 * macrocmd.c (extract_identifier): Return
11120 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11121 callers.
11122
424eb552
JB
111232019-02-06 John Baldwin <jhb@FreeBSD.org>
11124
11125 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11126
1688cb29
TT
111272019-02-05 Tom Tromey <tom@tromey.com>
11128
11129 * target.c (target_stack::unpush): Move assertion earlier.
11130
b5eba2d8
TT
111312019-01-30 Tom Tromey <tom@tromey.com>
11132
11133 PR python/23615:
11134 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11135 (gdbpy_parse_and_eval): Likewise.
11136 * python/python-internal.h (gdbpy_allow_threads): New class.
11137
7054e2ff
JB
111382019-01-28 John Baldwin <jhb@FreeBSD.org>
11139
11140 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11141 (aarch64_fbsd_fpregmap): Move earlier.
11142 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11143 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11144 instead of individual calls to trad_frame_set_reg_addr.
11145 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11146 earlier.
11147 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11148 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11149 instead of individual calls to trad_frame_set_reg_addr.
11150
36c25ffa
AH
111512019-01-28 Alan Hayward <alan.hayward@arm.com>
11152
11153 * CONTRIBUTE: Replace contribution list with wiki link.
11154
a0707f3c
TT
111552019-01-25 Tom Tromey <tom@tromey.com>
11156
11157 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11158
0747795c
TT
111592019-01-25 Tom Tromey <tom@tromey.com>
11160
11161 * xtensa-linux-nat.c: Fix common/ includes.
11162 * xml-support.h: Fix common/ includes.
11163 * xml-support.c: Fix common/ includes.
11164 * x86-linux-nat.c: Fix common/ includes.
11165 * windows-nat.c: Fix common/ includes.
11166 * varobj.h: Fix common/ includes.
11167 * varobj.c: Fix common/ includes.
11168 * value.c: Fix common/ includes.
11169 * valops.c: Fix common/ includes.
11170 * utils.c: Fix common/ includes.
11171 * unittests/xml-utils-selftests.c: Fix common/ includes.
11172 * unittests/utils-selftests.c: Fix common/ includes.
11173 * unittests/unpack-selftests.c: Fix common/ includes.
11174 * unittests/tracepoint-selftests.c: Fix common/ includes.
11175 * unittests/style-selftests.c: Fix common/ includes.
11176 * unittests/string_view-selftests.c: Fix common/ includes.
11177 * unittests/scoped_restore-selftests.c: Fix common/ includes.
11178 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11179 * unittests/scoped_fd-selftests.c: Fix common/ includes.
11180 * unittests/rsp-low-selftests.c: Fix common/ includes.
11181 * unittests/parse-connection-spec-selftests.c: Fix common/
11182 includes.
11183 * unittests/optional-selftests.c: Fix common/ includes.
11184 * unittests/offset-type-selftests.c: Fix common/ includes.
11185 * unittests/observable-selftests.c: Fix common/ includes.
11186 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11187 * unittests/memrange-selftests.c: Fix common/ includes.
11188 * unittests/memory-map-selftests.c: Fix common/ includes.
11189 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11190 * unittests/function-view-selftests.c: Fix common/ includes.
11191 * unittests/environ-selftests.c: Fix common/ includes.
11192 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11193 * unittests/common-utils-selftests.c: Fix common/ includes.
11194 * unittests/cli-utils-selftests.c: Fix common/ includes.
11195 * unittests/array-view-selftests.c: Fix common/ includes.
11196 * ui-file.c: Fix common/ includes.
11197 * tui/tui-io.c: Fix common/ includes.
11198 * tracepoint.h: Fix common/ includes.
11199 * tracepoint.c: Fix common/ includes.
11200 * tracefile-tfile.c: Fix common/ includes.
11201 * top.h: Fix common/ includes.
11202 * top.c: Fix common/ includes.
11203 * thread.c: Fix common/ includes.
11204 * target/waitstatus.h: Fix common/ includes.
11205 * target/waitstatus.c: Fix common/ includes.
11206 * target.h: Fix common/ includes.
11207 * target.c: Fix common/ includes.
11208 * target-memory.c: Fix common/ includes.
11209 * target-descriptions.c: Fix common/ includes.
11210 * symtab.h: Fix common/ includes.
11211 * symfile.c: Fix common/ includes.
11212 * stap-probe.c: Fix common/ includes.
11213 * spu-linux-nat.c: Fix common/ includes.
11214 * sparc-nat.c: Fix common/ includes.
11215 * source.c: Fix common/ includes.
11216 * solib.c: Fix common/ includes.
11217 * solib-target.c: Fix common/ includes.
11218 * ser-unix.c: Fix common/ includes.
11219 * ser-tcp.c: Fix common/ includes.
11220 * ser-pipe.c: Fix common/ includes.
11221 * ser-base.c: Fix common/ includes.
11222 * selftest-arch.c: Fix common/ includes.
11223 * s12z-tdep.c: Fix common/ includes.
11224 * rust-exp.y: Fix common/ includes.
11225 * rs6000-aix-tdep.c: Fix common/ includes.
11226 * riscv-tdep.c: Fix common/ includes.
11227 * remote.c: Fix common/ includes.
11228 * remote-notif.h: Fix common/ includes.
11229 * remote-fileio.h: Fix common/ includes.
11230 * remote-fileio.c: Fix common/ includes.
11231 * regcache.h: Fix common/ includes.
11232 * regcache.c: Fix common/ includes.
11233 * record-btrace.c: Fix common/ includes.
11234 * python/python.c: Fix common/ includes.
11235 * python/py-type.c: Fix common/ includes.
11236 * python/py-inferior.c: Fix common/ includes.
11237 * progspace.h: Fix common/ includes.
11238 * producer.c: Fix common/ includes.
11239 * procfs.c: Fix common/ includes.
11240 * proc-api.c: Fix common/ includes.
11241 * printcmd.c: Fix common/ includes.
11242 * ppc-linux-nat.c: Fix common/ includes.
11243 * parser-defs.h: Fix common/ includes.
11244 * osdata.c: Fix common/ includes.
11245 * obsd-nat.c: Fix common/ includes.
11246 * nat/x86-linux.c: Fix common/ includes.
11247 * nat/x86-linux-dregs.c: Fix common/ includes.
11248 * nat/x86-dregs.h: Fix common/ includes.
11249 * nat/x86-dregs.c: Fix common/ includes.
11250 * nat/ppc-linux.c: Fix common/ includes.
11251 * nat/mips-linux-watch.h: Fix common/ includes.
11252 * nat/mips-linux-watch.c: Fix common/ includes.
11253 * nat/linux-waitpid.c: Fix common/ includes.
11254 * nat/linux-ptrace.h: Fix common/ includes.
11255 * nat/linux-ptrace.c: Fix common/ includes.
11256 * nat/linux-procfs.c: Fix common/ includes.
11257 * nat/linux-personality.c: Fix common/ includes.
11258 * nat/linux-osdata.c: Fix common/ includes.
11259 * nat/linux-namespaces.c: Fix common/ includes.
11260 * nat/linux-btrace.h: Fix common/ includes.
11261 * nat/linux-btrace.c: Fix common/ includes.
11262 * nat/fork-inferior.c: Fix common/ includes.
11263 * nat/amd64-linux-siginfo.c: Fix common/ includes.
11264 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11265 * nat/aarch64-linux.c: Fix common/ includes.
11266 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11267 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11268 * namespace.h: Fix common/ includes.
11269 * mips-linux-tdep.c: Fix common/ includes.
11270 * minsyms.c: Fix common/ includes.
11271 * mi/mi-parse.h: Fix common/ includes.
11272 * mi/mi-main.c: Fix common/ includes.
11273 * mi/mi-cmd-env.c: Fix common/ includes.
11274 * memrange.h: Fix common/ includes.
11275 * memattr.c: Fix common/ includes.
11276 * maint.h: Fix common/ includes.
11277 * maint.c: Fix common/ includes.
11278 * main.c: Fix common/ includes.
11279 * machoread.c: Fix common/ includes.
11280 * location.c: Fix common/ includes.
11281 * linux-thread-db.c: Fix common/ includes.
11282 * linux-nat.c: Fix common/ includes.
11283 * linux-fork.c: Fix common/ includes.
11284 * inline-frame.c: Fix common/ includes.
11285 * infrun.c: Fix common/ includes.
11286 * inflow.c: Fix common/ includes.
11287 * inferior.h: Fix common/ includes.
11288 * inferior.c: Fix common/ includes.
11289 * infcmd.c: Fix common/ includes.
11290 * inf-ptrace.c: Fix common/ includes.
11291 * inf-child.c: Fix common/ includes.
11292 * ia64-linux-nat.c: Fix common/ includes.
11293 * i387-tdep.c: Fix common/ includes.
11294 * i386-tdep.c: Fix common/ includes.
11295 * i386-linux-tdep.c: Fix common/ includes.
11296 * i386-linux-nat.c: Fix common/ includes.
11297 * i386-go32-tdep.c: Fix common/ includes.
11298 * i386-fbsd-tdep.c: Fix common/ includes.
11299 * i386-fbsd-nat.c: Fix common/ includes.
11300 * guile/scm-type.c: Fix common/ includes.
11301 * guile/guile.c: Fix common/ includes.
11302 * go32-nat.c: Fix common/ includes.
11303 * gnu-nat.c: Fix common/ includes.
11304 * gdbthread.h: Fix common/ includes.
11305 * gdbarch-selftests.c: Fix common/ includes.
11306 * gdb_usleep.c: Fix common/ includes.
11307 * gdb_select.h: Fix common/ includes.
11308 * gdb_bfd.c: Fix common/ includes.
11309 * gcore.c: Fix common/ includes.
11310 * fork-child.c: Fix common/ includes.
11311 * findvar.c: Fix common/ includes.
11312 * fbsd-nat.c: Fix common/ includes.
11313 * event-top.c: Fix common/ includes.
11314 * event-loop.c: Fix common/ includes.
11315 * dwarf2read.c: Fix common/ includes.
11316 * dwarf2loc.c: Fix common/ includes.
11317 * dwarf2-frame.c: Fix common/ includes.
11318 * dwarf-index-cache.c: Fix common/ includes.
11319 * dtrace-probe.c: Fix common/ includes.
11320 * disasm-selftests.c: Fix common/ includes.
11321 * defs.h: Fix common/ includes.
11322 * csky-tdep.c: Fix common/ includes.
11323 * cp-valprint.c: Fix common/ includes.
11324 * cp-support.h: Fix common/ includes.
11325 * cp-support.c: Fix common/ includes.
11326 * corelow.c: Fix common/ includes.
11327 * completer.h: Fix common/ includes.
11328 * completer.c: Fix common/ includes.
11329 * compile/compile.c: Fix common/ includes.
11330 * compile/compile-loc2c.c: Fix common/ includes.
11331 * compile/compile-cplus-types.c: Fix common/ includes.
11332 * compile/compile-cplus-symbols.c: Fix common/ includes.
11333 * command.h: Fix common/ includes.
11334 * cli/cli-dump.c: Fix common/ includes.
11335 * cli/cli-cmds.c: Fix common/ includes.
11336 * charset.c: Fix common/ includes.
11337 * build-id.c: Fix common/ includes.
11338 * btrace.h: Fix common/ includes.
11339 * btrace.c: Fix common/ includes.
11340 * breakpoint.h: Fix common/ includes.
11341 * breakpoint.c: Fix common/ includes.
11342 * ax.h:
11343 (enum agent_op): Fix common/ includes.
11344 * ax-general.c (struct aop_map): Fix common/ includes.
11345 * ax-gdb.c: Fix common/ includes.
11346 * auxv.c: Fix common/ includes.
11347 * auto-load.c: Fix common/ includes.
11348 * arm-tdep.c: Fix common/ includes.
11349 * arch/riscv.c: Fix common/ includes.
11350 * arch/ppc-linux-common.c: Fix common/ includes.
11351 * arch/i386.c: Fix common/ includes.
11352 * arch/arm.c: Fix common/ includes.
11353 * arch/arm-linux.c: Fix common/ includes.
11354 * arch/arm-get-next-pcs.c: Fix common/ includes.
11355 * arch/amd64.c: Fix common/ includes.
11356 * arch/aarch64.c: Fix common/ includes.
11357 * arch/aarch64-insn.c: Fix common/ includes.
11358 * arch-utils.c: Fix common/ includes.
11359 * amd64-windows-tdep.c: Fix common/ includes.
11360 * amd64-tdep.c: Fix common/ includes.
11361 * amd64-sol2-tdep.c: Fix common/ includes.
11362 * amd64-obsd-tdep.c: Fix common/ includes.
11363 * amd64-nbsd-tdep.c: Fix common/ includes.
11364 * amd64-linux-tdep.c: Fix common/ includes.
11365 * amd64-linux-nat.c: Fix common/ includes.
11366 * amd64-fbsd-tdep.c: Fix common/ includes.
11367 * amd64-fbsd-nat.c: Fix common/ includes.
11368 * amd64-dicos-tdep.c: Fix common/ includes.
11369 * amd64-darwin-tdep.c: Fix common/ includes.
11370 * agent.c: Fix common/ includes.
11371 * ada-lang.h: Fix common/ includes.
11372 * ada-lang.c: Fix common/ includes.
11373 * aarch64-tdep.c: Fix common/ includes.
11374
2f5c153e
TT
113752019-01-25 Tom Tromey <tom@tromey.com>
11376
11377 * common/create-version.sh: Use common/version.h.
11378
adc6a863
PA
113792019-01-24 Pedro Alves <palves@redhat.com>
11380
11381 * infrun.c (signal_stop, signal_print, signal_program)
11382 (signal_catch, signal_pass): Now arrays instead of pointers.
11383 (update_signals_program_target, do_target_resume)
11384 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11385 * linux-nat.c (linux_nat_target::pass_signals)
11386 (linux_nat_target::create_inferior, linux_nat_target::attach):
11387 Adjust.
11388 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11389 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11390 * procfs.c (procfs_target::pass_signals): Adjust.
11391 * record-full.c (record_full_target::resume): Adjust.
11392 * remote.c (remote_target::pass_signals)
11393 (remote_target::program_signals): Adjust.
11394 * target-debug.h (target_debug_print_signals): Now takes a
11395 gdb::array_view as parameter. Adjust.
11396 * target.h (target_ops) <pass_signals, program_signals>: Replace
11397 pointer and length parameters with gdb::array_view.
11398 (target_pass_signals, target_program_signals): Likewise.
11399 * target-delegates.c: Regenerate.
11400
3046d67a
PA
114012019-01-24 Pedro Alves <palves@redhat.com>
11402
11403 * common/forward-scope-exit.h
11404 (forward_scope_exit::forward_scope_exit): Pass arguments to
11405 m_bind_function directly, instead of creating a std::bind and
11406 copying that.
11407
353229bf
AH
114082019-01-24 Alan Hayward <alan.hayward@arm.com>
11409
11410 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11411 for static members.
11412 (pass_in_v_vfp_candidate): Likewise.
11413
311dc83a
TT
114142019-01-23 Tom Tromey <tom@tromey.com>
11415 Pedro Alves <palves@redhat.com>
11416
11417 * regcache.c (class regcache_invalidator): Remove.
11418 (regcache::raw_write): Use make_scope_exit.
11419
296bd123
TT
114202019-01-23 Tom Tromey <tom@tromey.com>
11421
11422 * ui-out.h (class ui_out_emit_type): Update comment.
11423
979a0d13
TT
114242019-01-23 Tom Tromey <tom@tromey.com>
11425
11426 * infrun.c (fetch_inferior_event): Update comment.
11427
d238133d
TT
114282019-01-23 Tom Tromey <tom@tromey.com>
11429 Pedro Alves <palves@redhat.com>
11430
11431 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11432 parameter.
11433 (fetch_inferior_event): Use SCOPE_EXIT.
11434
11435
9885e6bb
TT
114362019-01-23 Tom Tromey <tom@tromey.com>
11437 Pedro Alves <palves@redhat.com>
11438
11439 * infrun.c (disable_thread_events): Delete.
11440 (stop_all_threads): Use SCOPE_EXIT.
11441
286526c1
TT
114422019-01-23 Tom Tromey <tom@tromey.com>
11443 Pedro Alves <palves@redhat.com>
11444
11445 * symfile.c: Include forward-scope-exit.h.
11446 (clear_symtab_users_cleanup): Replace forward declaration with
11447 a FORWARD_SCOPE_EXIT.
11448 (syms_from_objfile_1): Use the forward_scope_exit and
11449 gdb::optional instead of cleanup_function.
11450 (reread_symbols): Use the forward_scope_exit instead of
11451 cleanup_function.
11452 (clear_symtab_users_cleanup): Remove function.
11453
1db93f14
TT
114542019-01-23 Tom Tromey <tom@tromey.com>
11455 Pedro Alves <palves@redhat.com>
11456
11457 * linux-nat.c: Include scope-exit.h.
11458 (cleanup_target_stop): Remove.
11459 (linux_nat_target::static_tracepoint_markers_by_strid): Use
11460 SCOPE_EXIT.
11461
2cc83d1e
TT
114622019-01-23 Tom Tromey <tom@tromey.com>
11463 Pedro Alves <palves@redhat.com>
11464
11465 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11466 (call_function_by_hand_dummy): Use SCOPE_EXIT.
11467
694c6bf5
TT
114682019-01-23 Tom Tromey <tom@tromey.com>
11469 Andrew Burgess <andrew.burgess@embecosm.com>
11470 Pedro Alves <palves@redhat.com>
11471
11472 * infrun.c (fetch_inferior_event): Use scope_exit.
11473 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11474 * top.c (execute_command): Use scope_exit.
11475 * breakpoint.c (bpstat_do_actions): Use scope_exit.
11476 * utils.c (do_bpstat_clear_actions_cleanup)
11477 (make_bpstat_clear_actions_cleanup): Remove.
11478
4c41382a
TT
114792019-01-23 Tom Tromey <tom@tromey.com>
11480 Pedro Alves <palves@redhat.com>
11481
11482 * infrun.c: Include "common/scope-exit.h"
11483 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11484 (wait_for_inferior): Use SCOPE_EXIT.
11485 (fetch_inferior_event): Use scope_exit.
11486
89f8fb50
TT
114872019-01-23 Tom Tromey <tom@tromey.com>
11488 Pedro Alves <palves@redhat.com>
11489
11490 * breakpoint.c (create_breakpoint): Remove cleanup.
11491
5419bdae
TT
114922019-01-23 Tom Tromey <tom@tromey.com>
11493 Andrew Burgess <andrew.burgess@embecosm.com>
11494 Pedro Alves <palves@redhat.com>
11495
e587ef42
PA
114962019-01-23 Pedro Alves <palves@redhat.com>
11497
11498 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11499
77f0e74c
PA
115002019-01-23 Pedro Alves <palves@redhat.com>
11501 Andrew Burgess <andrew.burgess@embecosm.com>
11502
11503 * gdbthread.h: Include "common/forward-scope-exit.h".
11504 (scoped_finish_thread_state): Redefine custom class in terms of
11505 forward_scope_exit.
11506
5b9b3e53
PA
115072019-01-23 Pedro Alves <palves@redhat.com>
11508 Andrew Burgess <andrew.burgess@embecosm.com>
11509
11510 * common/forward-scope-exit.h: New file.
11511
54b65c9b
PA
115122019-01-23 Pedro Alves <palves@redhat.com>
11513 Andrew Burgess <andrew.burgess@embecosm.com>
11514 Tom Tromey <tom@tromey.com>
11515
11516 * common/scope-exit.h: New file.
11517
cf08fb29
PA
115182019-01-23 Pedro Alves <palves@redhat.com>
11519
11520 * common/preprocessor.h (ESC): Rename to ...
11521 (ESC_PARENS): ... this.
11522 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11523 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11524
ae73e2e2
TT
115252019-01-23 Tom Tromey <tom@tromey.com>
11526
11527 * language.h (class scoped_switch_to_sym_language_if_auto):
11528 Initialize m_lang in both cases.
11529
6594e122
AH
115302019-01-23 Alan Hayward <alan.hayward@arm.com>
11531
11532 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11533 with XCNEW.
11534
a7c9855d
TT
115352019-01-22 Tom Tromey <tom@tromey.com>
11536
11537 * corelow.c: Do not include sys/file.h.
11538
93cc1d53
TT
115392019-01-22 Tom Tromey <tom@tromey.com>
11540
11541 * tui/tui-wingeneral.h: Include gdb_curses.h.
11542
38561778
TT
115432019-01-22 Tom Tromey <tom@tromey.com>
11544
11545 * source-cache.h (class source_cache) <get_source_lines,
11546 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11547
37b3ab5b
TT
115482019-01-22 Tom Tromey <tom@tromey.com>
11549
11550 * remote-fileio.h (struct remote_target): Declare.
11551
3fabc016
TT
115522019-01-22 Tom Tromey <tom@tromey.com>
11553
11554 * python/py-arch.c: Do not include py-ref.h.
11555 * python/py-bpevent.c: Do not include py-ref.h.
11556 * python/py-cmd.c: Do not include py-ref.h.
11557 * python/py-continueevent.c: Do not include py-ref.h.
11558 * python/py-event.h: Do not include py-ref.h.
11559 * python/py-evtregistry.c: Do not include py-ref.h.
11560 * python/py-finishbreakpoint.c: Do not include py-ref.h.
11561 * python/py-frame.c: Do not include py-ref.h.
11562 * python/py-framefilter.c: Do not include py-ref.h.
11563 * python/py-function.c: Do not include py-ref.h.
11564 * python/py-infevents.c: Do not include py-ref.h.
11565 * python/py-linetable.c: Do not include py-ref.h.
11566 * python/py-objfile.c: Do not include py-ref.h.
11567 * python/py-param.c: Do not include py-ref.h.
11568 * python/py-prettyprint.c: Do not include py-ref.h.
11569 * python/py-progspace.c: Do not include py-ref.h.
11570 * python/py-symbol.c: Do not include py-ref.h.
11571 * python/py-symtab.c: Do not include py-ref.h.
11572 * python/py-type.c: Do not include py-ref.h.
11573 * python/py-unwind.c: Do not include py-ref.h.
11574 * python/py-utils.c: Do not include py-ref.h.
11575 * python/py-value.c: Do not include py-ref.h.
11576 * python/py-varobj.c: Do not include py-ref.h.
11577 * python/py-xmethods.c: Do not include py-ref.h.
11578 * python/python.c: Do not include py-ref.h.
11579 * varobj.c: Do not include py-ref.h.
11580
6b4d7774
TT
115812019-01-22 Tom Tromey <tom@tromey.com>
11582
11583 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11584 keyword for bcache.
11585
7af7e9b5
TT
115862019-01-22 Tom Tromey <tom@tromey.com>
11587
11588 * compile/compile-cplus-types.c: Remove a comment by #include.
11589
951d1049
TT
115902019-01-22 Tom Tromey <tom@tromey.com>
11591
11592 * compile/gcc-c-plugin.h: Include compile-internal.h.
11593
d65d5705
TT
115942019-01-22 Tom Tromey <tom@tromey.com>
11595
11596 * stabsread.c (EXTERN): Do not define.
11597 (symnum, next_symbol_text_func, processing_gcc_compilation)
11598 (within_function, global_sym_chain, global_stabs)
11599 (previous_stab_code, this_object_header_files)
11600 (n_this_object_header_files)
11601 (n_allocated_this_object_header_files): Define.
11602 * stabsread.h (EXTERN): Never define. Use "extern".
11603
b6fb1ee5
PW
116042019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11605
11606 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11607 history_value.
11608
be6d4f74
TT
116092019-01-21 Tom Tromey <tom@tromey.com>
11610
11611 * ui-out.c: Fix includes.
11612 * tui/tui-source.c: Fix includes.
11613 * target.c: Fix includes.
11614 * remote.c: Fix includes.
11615 * regcache.c: Fix includes.
11616 * python/py-block.c: Fix includes.
11617 * printcmd.c: Fix includes.
11618 * or1k-tdep.c: Fix includes.
11619 * mi/mi-main.c: Fix includes.
11620 * m32r-tdep.c: Fix includes.
11621 * csky-tdep.c: Fix includes.
11622 * compile/compile-cplus-types.c: Fix includes.
11623 * cli/cli-interp.c: Fix includes.
11624
73021deb
AH
116252019-01-21 Alan Hayward <alan.hayward@arm.com>
11626
11627 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11628 for padding.
11629
7932255d
TT
116302019-01-16 Tom Tromey <tom@tromey.com>
11631
11632 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
11633 earlier.
11634 (struct objfile) <msymbols_range>: Move from top level.
11635 <msymbols>: New method.
11636 (class objfile_msymbols): Remove.
11637 * symtab.c (default_collect_symbol_completion_matches_break_on):
11638 Update.
11639 * symmisc.c (dump_msymbols): Update.
11640 * stabsread.c (scan_file_globals): Update.
11641 * objc-lang.c (info_selectors_command, info_classes_command)
11642 (find_methods): Update.
11643 * minsyms.c (find_solib_trampoline_target): Update.
11644 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11645 * coffread.c (coff_symfile_read): Update.
11646 * ada-lang.c (ada_lookup_simple_minsym)
11647 (ada_collect_symbol_completion_matches): Update.
11648
604b1bfb
TT
116492019-01-16 Tom Tromey <tom@tromey.com>
11650
11651 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11652 type. Remove no-argument constructor.
11653 <iterator::operator++>: Simplify.
11654 <begin>: Update.
11655 <end>: Use minimal_symbol_count.
11656
f252c6d5
TT
116572019-01-16 Tom Tromey <tom@tromey.com>
11658
11659 * objfiles.h (struct objfile) <psymtabs>: New method.
11660 (class objfile_psymtabs): Remove.
11661 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11662 typedef.
11663 <range>: New method.
11664 (require_partial_symbols): Change return type.
11665 * psymtab.c (require_partial_symbols)
11666 (psym_expand_symtabs_matching): Update.
11667 * mdebugread.c (parse_partial_symbols): Update.
11668 * dbxread.c (dbx_end_psymtab): Update.
11669
b669c953
TT
116702019-01-15 Tom Tromey <tom@tromey.com>
11671
11672 * symtab.c (lookup_objfile_from_block)
11673 (lookup_symbol_in_objfile_symtabs)
11674 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11675 (find_line_symtab, info_sources_command)
11676 (default_collect_symbol_completion_matches_break_on)
11677 (make_source_files_completion_list): Update.
11678 * symmisc.c (print_objfile_statistics, dump_objfile)
11679 (maintenance_print_symbols, maintenance_info_symtabs)
11680 (maintenance_check_symtabs, maintenance_info_line_tables):
11681 Update.
11682 * source.c (select_source_symtab)
11683 (forget_cached_source_info_for_objfile): Update.
11684 * objfiles.h (class objfile_compunits): Remove.
11685 (struct objfile) <compunits_range>: New typedef.
11686 (compunits): New method.
11687 * objfiles.c (objfile_relocate1): Update.
11688 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11689 * maint.c (count_symtabs_and_blocks): Update.
11690 * linespec.c (iterate_over_all_matching_symtabs): Update.
11691 * cp-support.c (add_symbol_overload_list_qualified): Update.
11692 * coffread.c (coff_symtab_read): Update.
11693 * ada-lang.c (add_nonlocal_symbols)
11694 (ada_collect_symbol_completion_matches)
11695 (ada_add_global_exceptions): Update.
11696
7e955d83
TT
116972019-01-15 Tom Tromey <tom@tromey.com>
11698
11699 * progspace.h (program_space) <objfiles_safe_range>: New
11700 typedef.
11701 <objfiles_safe>: New method.
11702 * objfiles.h (class all_objfiles_safe): Remove.
11703 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11704 * jit.c (jit_inferior_exit_hook): Update.
11705
2030c079
TT
117062019-01-17 Tom Tromey <tom@tromey.com>
11707
11708 * progspace.h (program_space) <objfiles_range>: New typedef.
11709 <objfiles>: New method.
11710 <objfiles_head>: Rename from objfiles.
11711 (object_files): Update.
11712 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11713 * guile/scm-pretty-print.c
11714 (ppscm_find_pretty_printer_from_objfiles): Update.
11715 * guile/scm-objfile.c (gdbscm_objfiles): Update.
11716 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11717 Update.
11718 * python/py-progspace.c (pspy_get_objfiles): Update.
11719 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11720 Update.
11721 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11722 (objfpy_lookup_objfile_by_build_id): Update.
11723 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11724 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11725 Update.
11726 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11727 (expand_symtab_containing_pc, lookup_objfile_from_block)
11728 (lookup_static_symbol, basic_lookup_transparent_type)
11729 (find_pc_sect_compunit_symtab, find_symbol_at_address)
11730 (find_line_symtab, info_sources_command)
11731 (default_collect_symbol_completion_matches_break_on)
11732 (make_source_files_completion_list, find_main_name): Update.
11733 * symmisc.c (print_symbol_bcache_statistics)
11734 (print_objfile_statistics, maintenance_print_symbols)
11735 (maintenance_print_msymbols, maintenance_print_objfiles)
11736 (maintenance_info_symtabs, maintenance_check_symtabs)
11737 (maintenance_expand_symtabs, maintenance_info_line_tables):
11738 Update.
11739 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11740 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11741 (map_overlay_command, unmap_overlay_command)
11742 (simple_overlay_update, expand_symtabs_matching)
11743 (map_symbol_filenames): Update.
11744 * symfile-debug.c (set_debug_symfile): Update.
11745 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11746 Update.
11747 * source.c (select_source_symtab, forget_cached_source_info):
11748 Update.
11749 * solib.c (solib_read_symbols): Update.
11750 * solib-spu.c (append_ocl_sos): Update.
11751 * psymtab.c (maintenance_print_psymbols)
11752 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11753 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11754 * printcmd.c (info_symbol_command): Update.
11755 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11756 Update.
11757 * objfiles.h (class all_objfiles): Remove.
11758 * objfiles.c (have_partial_symbols, have_full_symbols)
11759 (have_minimal_symbols, qsort_cmp, update_section_map)
11760 (shared_objfile_contains_address_p)
11761 (default_iterate_over_objfiles_in_search_order): Update.
11762 * objc-lang.c (info_selectors_command, info_classes_command)
11763 (find_methods): Update.
11764 * minsyms.c (find_solib_trampoline_target): Update.
11765 * maint.c (maintenance_info_sections)
11766 (maintenance_translate_address, count_symtabs_and_blocks):
11767 Update.
11768 * main.c (captured_main_1): Update.
11769 * linux-thread-db.c (try_thread_db_load_from_pdir)
11770 (has_libpthread): Update.
11771 * linespec.c (iterate_over_all_matching_symtabs)
11772 (search_minsyms_for_name): Update.
11773 * jit.c (jit_find_objf_with_entry_addr): Update.
11774 * hppa-tdep.c (find_unwind_entry)
11775 (hppa_lookup_stub_minimal_symbol): Update.
11776 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11777 Update.
11778 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11779 (elf_gnu_ifunc_resolve_by_got): Update.
11780 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11781 * dwarf-index-write.c (save_gdb_index_command): Update.
11782 * cp-support.c (add_symbol_overload_list_qualified): Update.
11783 * breakpoint.c (create_overlay_event_breakpoint)
11784 (create_longjmp_master_breakpoint)
11785 (create_std_terminate_master_breakpoint)
11786 (create_exception_master_breakpoint): Update.
11787 * blockframe.c (find_pc_partial_function): Update.
11788 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11789 (ada_collect_symbol_completion_matches)
11790 (ada_add_global_exceptions): Update.
11791
776489e0
TT
117922019-01-17 Tom Tromey <tom@tromey.com>
11793
11794 * solib-target.c (lm_info_target_p): Remove typedef. Don't
11795 declare VEC.
11796 (solib_target_parse_libraries): Change return type.
11797 (library_list_start_segment, library_list_start_section)
11798 (library_list_end_library, library_list_start_library); Update.
11799 (solib_target_free_library_list): Remove.
11800 (solib_target_parse_libraries): Remove cleanup. Change return
11801 type.
11802 (solib_target_current_sos): Update.
11803
6471e7d2
TT
118042019-01-17 Tom Tromey <tromey@bapiya>
11805
11806 * valprint.c: Replace "the the" with "the".
11807 * symtab.c: Replace "the the" with "the".
11808 * solib.c: Replace "the the" with "the".
11809 * solib-dsbt.c: Replace "the the" with "the".
11810 * linespec.c: Replace "the the" with "the".
11811 * dwarf2loc.h: Replace "the the" with "the".
11812 * amd64-windows-tdep.c: Replace "the the" with "the".
11813 * aarch64-tdep.c: Replace "the the" with "the".
11814
c24bdb02
KS
118152019-01-16 Keith Seitz <keiths@redhat.com>
11816
11817 PR gdb/23773
11818 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11819 <builder>: Rename to ..
11820 <m_builder>: ... this and make private.
11821 (dwarf2_cu::get_builder): New method. Change all users of
11822 `builder' to use this method.
11823 (dwarf2_start_symtab): Move to ...
11824 (dwarf2_cu::start_symtab): ... here. Update all callers
11825 (setup_type_unit_groups): Move to ...
11826 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
11827 callers.
11828 (dwarf2_cu::reset_builder): New method.
11829 (process_full_compunit, process_full_type_unit): Use
11830 dwarf2_cu::reset_builder.
11831 (follow_die_offset): Record the ancestor CU if it is different
11832 from the followed DIE's CU.
11833 (follow_die_sig_1): Likewise.
11834
8d64371b
TT
118352019-01-15 Tom Tromey <tom@tromey.com>
11836
11837 * remote.c (class remote_state) <buf>: Now a char_vector.
11838 <buf_size>: Remove.
11839 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
11840 parameter.
11841 (remote_target::getpkt_or_notif_sane_1)
11842 (remote_target::getpkt_sane)
11843 (remote_target::getpkt_or_notif_sane): Likewise.
11844 (class remote_target) <putpkt>: New overload.
11845 (remote_target::read_frame): Change type of "buf_p". Remove
11846 sizeof_p parameter.
11847 (packet_ok): New overload.
11848 (packet_check_result): New overload.
11849 Update all uses.
11850
bb277751
TT
118512019-01-14 Tom Tromey <tom@tromey.com>
11852
11853 * remote-notif.c (handle_notification, remote_notif_ack)
11854 (remote_notif_parse): Make "buf" const.
11855 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11856 const.
11857 (remote_notif_parse, remote_notif_ack, handle_notification):
11858 Likewise.
11859 * remote.c (remote_notif_stop_parse): Make "buf" const.
11860 (remote_target::remote_parse_stop_reply): Make "buf" const.
11861 (remote_notif_stop_ack): Make "buf" const.
11862
05be00a8
TT
118632019-01-14 Tom Tromey <tom@tromey.com>
11864
11865 * remote.c (remote_console_output): Make parameter const.
11866
491adeca
TT
118672019-01-14 Tom Tromey <tom@tromey.com>
11868
11869 * target-debug.h (target_debug_print_signals): Constify.
11870 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11871 * procfs.c (procfs_target::pass_signals): Update.
11872 * linux-nat.c (linux_nat_target::pass_signals): Update.
11873 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11874 * target-delegates.c: Rebuild.
11875 * remote.c (remote_target::program_signals): Update.
11876 (remote_target::pass_signals): Update.
11877 * target.c (target_pass_signals): Constify argument.
11878 (target_program_signals): Likewise.
11879 * target.h (struct target_ops) <pass_signals, program_signals>:
11880 Constify argument.
11881 (target_pass_signals, target_program_signals): Constify argument.
11882
bbd94648
TT
118832019-01-14 Tom Tromey <tom@tromey.com>
11884
11885 PR tui/28819:
11886 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11887
6f072a10
PFC
118882019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
11889
11890 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11891 field.
11892 * rs6000-tdep.c: Include reggroups.h.
11893 (IS_V_ALIAS_PSEUDOREG): Define.
11894 (rs6000_register_name): Return names for the "vX" aliases.
11895 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11896 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
11897 aliases. Call default_register_reggroup_p for all other
11898 pseudo-registers.
11899 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11900 New functions.
11901 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11902 Handle "vX" aliases.
11903 (v_alias_pseudo_register_collect): New function.
11904 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11905 (rs6000_gdbarch_init): Initialize "vX" aliases as
11906 pseudo-registers. Restore registration of
11907 rs6000_pseudo_register_reggroup_p with
11908 set_tdesc_pseudo_register_reggroup_p.
11909
1a782351
MF
119102019-01-13 Max Filippov <jcmvbkbc@gmail.com>
11911
11912 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11913 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11914 set_gdbarch_num_pseudo_regs.
11915
d73cff18
PW
119162019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11917
11918 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11919 Remove arg prefixname, add do_set and do_show.
11920 Add member functions set_list and show_list.
11921 * cli/cli-style.c (class cli_style_option): Update accordingly.
11922 (style_set_list): Move to file scope.
11923 (style_show_list): Likewise.
11924 (set_style): Call help_list.
11925 (show_style): Call cmd_show_list.
11926 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11927 Update to use the new macro.
11928
60a90376
JB
119292019-10-12 Joel Brobecker <brobecker@adacore.com>
11930
11931 * ada-lang.c (_initialize_ada_language): Expand the help text
11932 for the "catch exception" command.
11933
9d7c67bf
PW
119342019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11935
11936 * symtab.c (matching_obj_sections): Initialize obj,
11937 declare it closer to its usage.
11938
7cf47dc4
TT
119392019-01-10 Tom Tromey <tom@tromey.com>
11940
11941 * thread-iter.h (inf_threads_iterator): Use next_iterator.
11942 (basic_inf_threads_range): Remove.
11943 (inf_threads_range, inf_non_exited_threads_range)
11944 (safe_inf_threads_range): Use next_adapter.
11945
d3cb6808
KS
119462019-01-10 Keith Seitz <keiths@redhat.com>
11947
11948 PR gdb/23712
11949 PR symtab/23010
11950 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11951 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11952
63a20375
KS
119532019-01-10 Keith Seitz <keiths@redhat.com>
11954
11955 PR gdb/23712
11956 PR symtab/23010
11957 * dictionary.c (pending_to_vector): Remove.
11958 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11959 Remove _1 suffix, replacing functions of the same name. Update
11960 all callers.
11961 (dict_create_hashed, dict_create_hashed_expandable)
11962 (dict_create_linear, dict_create_linear_expandable, dict_free)
11963 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11964 Make functions static.
11965
b026f593
KS
119662019-01-10 Keith Seitz <keiths@redhat.com>
11967
11968 PR gdb/23712
11969 PR symtab/23010
11970 * dictionary.h (struct dictionary): Replace declaration with
11971 multidictionary.
11972 (dict_create_hashed, dict_create_hashed_expandable)
11973 (dict_create_linear, dict_create_linear_expandable)
11974 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11975 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11976 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11977 taking multidictionary argument.
11978 [ALL_DICT_SYMBOLS]: Update for multidictionary.
11979 * block.h (struct block) <dict>: Change to multidictionary
11980 and rename `multidict'.
11981 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11982 symmisc.c: Update all dictionary references to multidictionary.
11983
c7748ee9
KS
119842019-01-10 Keith Seitz <keiths@redhat.com>
11985
11986 PR gdb/23712
11987 PR symtab/23010
11988 * dictionary.c: Include unordered_map.
11989 (pending_to_vector): New function.
11990 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11991 Rewrite the non-"_1" functions to take vector instead
11992 of linked list.
11993 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11994 "new" _1 versions of the same name.
11995 (multidictionary): Define.
11996 (std::hash<enum language): New definition.
11997 (collate_pending_symbols_by_language, mdict_create_hashed)
11998 (mdict_create_hashed_expandable, mdict_create_linear)
11999 (mdict_create_linear_expandable, mdict_free)
12000 (find_language_dictionary, create_new_language_dictionary)
12001 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12002 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12003 (mdict_size, mdict_empty): New functions.
12004 * dictionary.h (mdict_iterator): Define.
12005
67aa1f3c
PA
120062019-01-10 Pedro Alves <palves@redhat.com>
12007
12008 * breakpoint.c (read_uploaded_action)
12009 (create_tracepoint_from_upload): Adjust to use
12010 gdb::unique_xmalloc_ptr.
12011 * ctf.c (ctf_write_uploaded_tp):
12012 (SET_ARRAY_FIELD): Use emplace_back.
12013 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12014 * tracefile-tfile.c (tfile_write_uploaded_tp):
12015 * tracepoint.c (parse_tracepoint_definition): Adjust to use
12016 gdb::unique_xmalloc_ptr.
12017 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12018 at_string, cond_string, cmd_strings>: Replace char pointers
12019 with gdb::unique_xmalloc_ptr.
12020
2f667667
PA
120212019-01-10 Pedro Alves <palves@redhat.com>
12022
12023 * solib-target.c (library_list_start_library): Don't xstrdup name.
12024
36cb7237
PA
120252019-01-10 Pedro Alves <palves@redhat.com>
12026
12027 * mdebugread.c (parse_partial_symbols): Use
12028 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12029
da584958
AB
120302019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12031
12032 * linux-fork.c (scoped_switch_fork_info)
12033 <~scoped_switch_fork_info>: Fix incorrect variable name.
12034
1ef8573c
AB
120352019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
12036
12037 * linux-fork.c (scoped_switch_fork_info)
12038 <scoped_switch_fork_info>: Make explicit.
12039 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12040
8d7bcccb
TT
120412019-01-10 Tom Tromey <tom@tromey.com>
12042
12043 * objfiles.h (objfile::reset_psymtabs): Update.
12044 * objfiles.c (objfile::objfile): Update.
12045 * psymtab.h (psymtab_storage::obstack): Update.
12046 (psymtab_storage::m_obstack): Use gdb::optional.
12047 (class psymtab_storage): Update comment. Remove objfile
12048 parameter.
12049 * psymtab.c (psymtab_storage::psymtab_storage): Update.
12050
b596a3c7
TT
120512019-01-10 Tom Tromey <tom@tromey.com>
12052
12053 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12054 <free_psymtabs>: Now private.
12055 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12056 (allocate_psymtab): Use new method.
12057
a9342b62
TT
120582019-01-10 Tom Tromey <tom@tromey.com>
12059
12060 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12061 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12062 * mdebugread.c (parse_partial_symbols): Use
12063 allocate_dependencies.
12064 * dwarf2read.c (dwarf2_create_include_psymtab): Use
12065 allocate_dependencies.
12066 (process_psymtab_comp_unit_reader)
12067 (build_type_psymtab_dependencies): Likewise.
12068 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12069
5af70966
TT
120702019-01-10 Tom Tromey <tom@tromey.com>
12071
12072 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12073 PSYMBOL_SET_LANGUAGE.
12074 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12075
5923a04c
TT
120762019-01-10 Tom Tromey <tom@tromey.com>
12077
12078 * psymtab.h (psymtab_storage::obstack): New method.
12079 <m_obstack>: Rename from obstack; now private.
12080 * psymtab.c (psymtab_storage): Update.
12081 * dwarf2read.c (create_addrmap_from_index)
12082 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12083 Update.
12084
6d6a12bf
TT
120852019-01-10 Tom Tromey <tom@tromey.com>
12086
12087 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12088 * objfiles.h (objfile::reset_psymtabs): New method.
12089
d320c2b5
TT
120902019-01-10 Tom Tromey <tom@tromey.com>
12091
12092 * symmisc.c (print_symbol_bcache_statistics): Update.
12093 (print_objfile_statistics): Update.
12094 * symfile.c (reread_symbols): Update.
12095 * psymtab.h (class psymtab_storage): New.
12096 * psymtab.c (psymtab_storage): New constructor.
12097 (~psymtab_storage): New destructor.
12098 (require_partial_symbols): Update.
12099 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12100 (find_pc_sect_psymtab, find_pc_sect_psymbol)
12101 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12102 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12103 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12104 (start_psymtab_common, end_psymtab_common)
12105 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12106 (allocate_psymtab): Update.
12107 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12108 Update.
12109 (dump_psymtab_addrmap, maintenance_print_psymbols)
12110 (maintenance_check_psymtabs): Update.
12111 (class objfile_psymtabs): Move to objfiles.h.
12112 * psympriv.h (discard_psymtab): Now inline.
12113 (psymtab_discarder::psymtab_discarder): Update.
12114 (psymtab_discarder::~psymtab_discarder): Update.
12115 (ALL_OBJFILE_PSYMTABS): Rewrite.
12116 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12117 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12118 Remove fields.
12119 <partial_symtabs>: New field.
12120 (class objfile_psymtabs): Move from psymtab.h. Update.
12121 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12122 psymbol_cache.
12123 (objfile::~objfile): Don't destroy psymbol_cache.
12124 * mdebugread.c (parse_partial_symbols): Update.
12125 * dwarf2read.c (create_addrmap_from_index)
12126 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12127 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12128 (add_partial_subprogram, dwarf2_ranges_read): Update.
12129 * dwarf-index-write.c (write_address_map)
12130 (write_one_signatured_type, recursively_write_psymbols)
12131 (class debug_names, class debug_names, write_psymtabs_to_index):
12132 Update.
12133
1d94a5a3
TT
121342019-01-10 Tom Tromey <tom@tromey.com>
12135
12136 * symtab.h (SYMBOL_SET_NAMES): Update.
12137 (symbol_set_names): Update.
12138 (MSYMBOL_SET_NAMES): Update.
12139 * symtab.c (symbol_set_names): Change argument to be an
12140 objfile_per_bfd_storage.
12141 * psymtab.c (add_psymbol_to_bcache): Update.
12142 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12143
0f14768a
TT
121442019-01-10 Tom Tromey <tom@tromey.com>
12145
12146 * symtab.c (create_demangled_names_hash): Change argument to be an
12147 objfile_per_bfd_storage.
12148 (symbol_set_names): Update.
12149
6eee24ce
TT
121502019-01-10 Tom Tromey <tom@tromey.com>
12151
12152 * xcoffread.c (xcoff_initial_scan): Unconditionally call
12153 init_psymbol_list.
12154 * psymtab.c (init_psymbol_list): Do nothing if already called.
12155 * psympriv.h (init_psymbol_list): Add comment.
12156 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12157 init_psymbol_list.
12158 * dbxread.c (dbx_symfile_read): Unconditionally call
12159 init_psymbol_list.
12160
75aedd27
TT
121612019-01-10 Tom Tromey <tom@tromey.com>
12162
12163 * xcoffread.c (scan_xcoff_symtab): Update.
12164 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12165 "where".
12166 * mdebugread.c (parse_partial_symbols)
12167 (handle_psymbol_enumerators): Update.
12168 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12169 * dbxread.c (read_dbx_symtab): Update.
12170 * psympriv.h (psymbol_placement): New enum.
12171 (add_psymbol_to_list): Update.
12172
939652a5
TT
121732019-01-10 Tom Tromey <tom@tromey.com>
12174
12175 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12176 static_psymbols parameters.
12177 (scan_xcoff_symtab): Update.
12178 * psymtab.c (start_psymtab_common): Remove global_psymbols and
12179 static_psymbols parameters.
12180 * psympriv.h (start_psymtab_common): Update.
12181 * mdebugread.c (parse_partial_symbols): Update.
12182 * dwarf2read.c (create_partial_symtab): Update.
12183 * dbxread.c (read_dbx_symtab): Update.
12184 (start_psymtab): Remove global_psymbols and static_psymbols
12185 parameters.
12186
baa62830
TT
121872019-01-10 Tom Tromey <tom@tromey.com>
12188
12189 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12190 * psymtab.c (allocate_psymtab): Add comment.
12191 * psympriv.h (allocate_psymtab): Add comment.
12192 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12193 initializations.
12194 * dbxread.c (dbx_end_psymtab): Remove some initializations.
12195
0e8f53ba
TT
121962019-01-10 Tom Tromey <tom@tromey.com>
12197
12198 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12199 Don't declare.
12200 * mipsread.c: Include mdebugread.h.
12201 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12202 Declare.
12203 * elfread.c: Include mdebugread.h.
12204
b22a7c6a
TT
122052019-01-09 Tom Tromey <tom@tromey.com>
12206
12207 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12208 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12209 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12210 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12211 (psym_lookup_symbol, psym_find_last_source_symtab)
12212 (psym_forget_cached_source_info, psym_print_stats)
12213 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12214 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12215 (psym_map_matching_symbols, psym_expand_symtabs_matching)
12216 (psym_find_compunit_symtab_by_address)
12217 (maintenance_print_psymbols, maintenance_info_psymtabs)
12218 (maintenance_check_psymtabs): Use ranged for.
12219 * psymtab.h (class objfile_psymtabs): New.
12220 (require_partial_symbols): Return objfile_psymtabs.
12221 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12222
3b9d3ac2
TT
122232019-01-09 Tom Tromey <tom@tromey.com>
12224
12225 * symfile.c (overlay_invalidate_all, find_pc_overlay)
12226 (find_pc_mapped_section, list_overlays_command)
12227 (map_overlay_command, unmap_overlay_command)
12228 (simple_overlay_update): Use all_objfiles.
12229 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12230 * printcmd.c (info_symbol_command): Use all_objfiles.
12231 * objfiles.h (ALL_OBJSECTIONS): Remove.
12232 * maint.c (maintenance_translate_address): Use all_objfiles.
12233 * gcore.c (gcore_create_callback): Use all_objfiles.
12234 (objfile_find_memory_regions): Likewise.
12235
8b31193a
TT
122362019-01-09 Tom Tromey <tom@tromey.com>
12237
12238 * symtab.c (find_line_symtab, info_sources_command)
12239 (make_source_files_completion_list): Use objfile_compunits.
12240 * source.c (select_source_symtab): Use objfile_compunits.
12241 * objfiles.h (struct objfile): Update comment.
12242 (ALL_OBJFILES): Remove.
12243 (ALL_FILETABS): Remove.
12244 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12245 objfile_compunits.
12246
d5da8b3c
TT
122472019-01-09 Tom Tromey <tom@tromey.com>
12248
12249 * symmisc.c (print_objfile_statistics, dump_objfile)
12250 (maintenance_print_symbols): Use compunit_filetabs.
12251 * source.c (forget_cached_source_info_for_objfile): Use
12252 compunit_filetabs.
12253 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12254 (ALL_FILETABS): Use compunit_filetabs.
12255 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12256 * coffread.c (coff_symtab_read): Use compunit_filetabs.
12257
5accd1a0
TT
122582019-01-09 Tom Tromey <tom@tromey.com>
12259
12260 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12261 (compunit_filetabs): New.
12262 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12263 compunit_filetabs.
12264 (info_sources_command, make_source_files_completion_list): Remove
12265 declaration.
12266 * symmisc.c (print_objfile_statistics, dump_objfile)
12267 (maintenance_print_symbols): Remove declaration.
12268 (maintenance_info_symtabs): Use compunit_filetabs.
12269 (maintenance_info_line_tables): Likewise.
12270 * source.c (select_source_symtab): Change local variable name.
12271 (forget_cached_source_info_for_objfile): Remove declaration.
12272 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12273 * objfiles.c (objfile_relocate1): Remove declaration.
12274 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12275 declaration.
12276 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12277 * coffread.c (coff_symtab_read): Remove declaration.
12278 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12279 compunit_filetabs.
12280
d8aeb77f
TT
122812019-01-09 Tom Tromey <tom@tromey.com>
12282
12283 * symtab.c (lookup_objfile_from_block)
12284 (find_pc_sect_compunit_symtab, search_symbols)
12285 (default_collect_symbol_completion_matches_break_on): Use
12286 objfile_compunits.
12287 * objfiles.h (ALL_COMPUNITS): Remove.
12288 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12289 * cp-support.c (add_symbol_overload_list_qualified): Use
12290 objfile_compunits.
12291 * ada-lang.c (ada_collect_symbol_completion_matches)
12292 (ada_add_global_exceptions): Use objfile_compunits.
12293
592553c4
TT
122942019-01-09 Tom Tromey <tom@tromey.com>
12295
12296 * source.c (select_source_symtab)
12297 (forget_cached_source_info_for_objfile): Remove declaration.
12298 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12299 declaration.
12300 * maint.c (count_symtabs_and_blocks): Remove declaration.
12301 * cp-support.c (add_symbol_overload_list_qualified): Remove
12302 declaration.
12303 * coffread.c (coff_symtab_read): Remove declaration.
12304 * symtab.c (lookup_symbol_in_objfile_symtabs)
12305 (basic_lookup_transparent_type_1): Use objfile_compunits.
12306 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12307 (info_sources_command, search_symbols)
12308 (default_collect_symbol_completion_matches_break_on)
12309 (make_source_files_completion_list): Remove declaration.
12310 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12311 (ada_collect_symbol_completion_matches)
12312 (ada_add_global_exceptions): Remove declaration.
12313 * linespec.c (iterate_over_all_matching_symtabs): Use
12314 objfile_compunits.
12315 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12316 (class objfile_compunits): New.
12317 (ALL_COMPUNITS): Use objfile_compunits.
12318 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12319 (maintenance_check_symtabs, maintenance_info_line_tables): Use
12320 objfile_compunits.
12321 * objfiles.c (objfile_relocate1): Use objfile_compunits.
12322
5325b9bf
TT
123232019-01-09 Tom Tromey <tom@tromey.com>
12324
12325 * symtab.c (search_symbols)
12326 (default_collect_symbol_completion_matches_break_on): Use
12327 objfile_msymbols.
12328 * ada-lang.c (ada_lookup_simple_minsym)
12329 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12330 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12331 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12332 objfile_msymbols.
12333 * coffread.c (coff_symfile_read): Use objfile_msymbols.
12334 * symmisc.c (dump_msymbols): Use objfile_msymbols.
12335 * objc-lang.c (find_methods): Use objfile_msymbols.
12336 (info_selectors_command, info_classes_command): Likewise.
12337 * stabsread.c (scan_file_globals): Use objfile_msymbols.
12338 * objfiles.h (class objfile_msymbols): New.
12339 (ALL_OBJFILE_MSYMBOLS): Remove.
12340 (ALL_MSYMBOLS): Remove.
12341
cac85af2
TT
123422019-01-09 Tom Tromey <tom@tromey.com>
12343
12344 * common/next-iterator.h (next_adapter): Add Iterator template
12345 parameter.
12346 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12347 (class all_objfiles_safe): New.
12348 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12349 * objfiles.c (put_objfile_before): Update comment.
12350 (add_separate_debug_objfile): Likewise.
12351 (free_all_objfiles): Use all_objfiles_safe.
12352 (objfile_purge_solibs): Likewise.
12353
aed57c53
TT
123542019-01-09 Tom Tromey <tom@tromey.com>
12355
12356 * symtab.c (iterate_over_symtabs, matching_obj_sections)
12357 (expand_symtab_containing_pc, lookup_static_symbol)
12358 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12359 (find_symbol_at_address, find_line_symtab, find_main_name): Use
12360 all_objfiles.
12361 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12362 * breakpoint.c (create_overlay_event_breakpoint)
12363 (create_longjmp_master_breakpoint)
12364 (create_std_terminate_master_breakpoint)
12365 (create_exception_master_breakpoint): Use all_objfiles.
12366 * linux-thread-db.c (try_thread_db_load_from_pdir)
12367 (has_libpthread): Use all_objfiles.
12368 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12369 * linespec.c (iterate_over_all_matching_symtabs)
12370 (search_minsyms_for_name): Use all_objfiles.
12371 * maint.c (maintenance_info_sections): Use all_objfiles.
12372 * main.c (captured_main_1): Use all_objfiles.
12373 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12374 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12375 * guile/scm-pretty-print.c
12376 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12377 * solib-spu.c (append_ocl_sos): Use all_objfiles.
12378 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12379 (maintenance_print_msymbols): Use all_objfiles.
12380 * source.c (select_source_symtab): Use all_objfiles.
12381 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12382 * symfile.c (remove_symbol_file_command)
12383 (expand_symtabs_matching, map_symbol_filenames): Use
12384 all_objfiles.
12385 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12386 all_objfiles.
12387 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12388 * objc-lang.c (find_methods): Use all_objfiles.
12389 * objfiles.c (have_partial_symbols, have_full_symbols)
12390 (have_minimal_symbols, qsort_cmp)
12391 (default_iterate_over_objfiles_in_search_order): Use
12392 all_objfiles.
12393 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12394 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12395 (maintenance_check_psymtabs): Use all_objfiles.
12396 (ALL_PSYMTABS): Remove.
12397 * compile/compile-object-run.c (do_module_cleanup): Use
12398 all_objfiles.
12399 * blockframe.c (find_pc_partial_function): Use all_objfiles.
12400 * cp-support.c (add_symbol_overload_list_qualified): Use
12401 all_objfiles.
12402 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12403 Use all_objfiles.
12404 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12405 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12406 all_objfiles.
12407 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12408 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12409 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12410 Uses all_objfiles.
12411 * solib.c (solib_read_symbols): Use all_objfiles
12412
99d89cde
TT
124132019-01-09 Tom Tromey <tom@tromey.com>
12414
12415 * probe.c (parse_probes_in_pspace): Use all_objfiles.
12416 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12417 all_objfiles.
12418 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12419 * symmisc.c (print_symbol_bcache_statistics)
12420 (print_objfile_statistics, maintenance_print_objfiles)
12421 (maintenance_info_symtabs, maintenance_check_symtabs)
12422 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12423 all_objfiles.
12424 * source.c (forget_cached_source_info): Use all_objfiles.
12425 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12426 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12427 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12428 * objfiles.c (update_section_map): Use all_objfiles.
12429 (shared_objfile_contains_address_p): Likewise.
12430 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12431 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12432
21708325
TT
124332019-01-09 Tom Tromey <tom@tromey.com>
12434
12435 * common/next-iterator.h: New file.
12436 * objfiles.h (class all_objfiles): New.
12437 (struct objfile_iterator): New.
12438
669e09f6
PW
124392019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12440
12441 * NEWS: Move the description of the changed "frame", "select-frame",
12442 and "info frame" commands to the Changed commands section.
12443
041be526
SM
124442019-01-09 Simon Marchi <simon.marchi@ericsson.com>
12445
12446 * gdbtypes.c (check_stub_method_group): Remove handling of old
12447 mangling schemes.
12448 * linespec.c (find_methods): Likewise.
12449 * stabsread.c (read_member_functions): Likewise.
12450 * valops.c (search_struct_method): Likewise.
12451 (value_struct_elt_for_reference): Likewise.
12452 * NEWS: Mention this change.
12453
0e2a2133
AB
124542019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
12455
12456 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12457 print_source_lines.
12458 * source.c (print_source_lines_base): Update line number check.
12459 (print_source_lines): New function.
12460 (source_lines_range::source_lines_range): New function.
12461 * source.h (class source_lines_range): New class.
12462 (print_source_lines): New declaration.
12463
1055a3b4
PW
124642019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12465
12466 * linespec.c (linespec_state_destructor): Free self->canonical_names.
12467
cfeadda5
TT
124682019-01-08 Tom Tromey <tom@tromey.com>
12469 Simon Marchi <simon.marchi@ericsson.com>
12470
12471 PR gdb/24060
12472 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12473 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12474 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12475 * f-exp.y (DOLLAR_VARIABLE): Likewise.
12476 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12477 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12478
583068ca
AB
124792019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12480
12481 * source.c (select_source_symtab): Move header comment to
12482 declaration in source.h.
12483 (forget_cached_source_info_for_objfile): Likewise.
12484 (forget_cached_source_info): Likewise.
12485 (identify_source_line): Likewise.
12486 * source.h (identify_source_line): Move declaration from symtab.h
12487 and add comment from source.c
12488 (print_source_lines): Likewise.
12489 (forget_cached_source_info_for_objfile): Likewise.
12490 (forget_cached_source_info): Likewise.
12491 (select_source_symtab): Likewise.
12492 (enum print_source_lines_flag): Move definition from symtab.h.
12493 * symtab.h (identify_source_line): Move declaration to source.h.
12494 (print_source_lines): Likewise.
12495 (forget_cached_source_info_for_objfile): Likewise.
12496 (forget_cached_source_info): Likewise.
12497 (select_source_symtab): Likewise.
12498 (enum print_source_lines_flag): Move definition to source.h.
12499 * tui/tui-hooks.c: Add 'source.h' include.
12500
ec98a4ad
AB
125012019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12502
12503 * source.c (print_source_lines_base): Handle requests to print
12504 reverse line number sequences, and guard against empty lines
12505 string.
12506
62ea19c1
AB
125072019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
12508
12509 * source.c (print_source_lines_base): Fix skip of '\r' if next
12510 character is '\n'.
12511
9d30e1fd
TT
125122019-01-06 Tom Tromey <tom@tromey.com>
12513
12514 * c-exp.y (struct c_parse_state) <macro_original_text,
12515 expansion_obstack>: New member.
12516 (macro_original_text, expansion_obstack): Remove globals.
12517 (scan_macro_expansion, scanning_macro_expansion)
12518 (finished_macro_expansion): Update.
12519 (scan_macro_cleanup): Remove.
12520 (yylex, c_parse): Update.
12521
c65bac38
TT
125222019-01-06 Tom Tromey <tom@tromey.com>
12523
12524 * c-exp.y (struct c_parse_state) <strings>: New member.
12525 (operator_stoken): Update.
12526
02e12e38
TT
125272019-01-06 Tom Tromey <tom@tromey.com>
12528
12529 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
12530 (union type_stack_elt) <typelist_val>: Now a pointer to
12531 std::vector.
12532 (type_stack_cleanup): Don't declare.
12533 (push_typelist): Update.
12534 * parse.c (pop_typelist): Return a std::vector.
12535 (push_typelist): Take a std::vector.
12536 (follow_types): Update. Do not free args.
12537 (type_stack_cleanup): Remove.
12538 * c-exp.y (struct c_parse_state): New.
12539 (cpstate): New global.
12540 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12541 (nonempty_typelist): Update.
12542 (func_mod): Create a new vector.
12543 (c_parse): Create a c_parse_state.
12544 (check_parameter_typelist): Do not delete params.
12545 (function_method): Update. Do not delete type_list.
12546
f097f5ad
TT
125472019-01-06 Tom Tromey <tom@tromey.com>
12548
12549 PR gdb/28155:
12550 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12551 check_typedef.
12552 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12553 (print_return_value): Likewise.
12554
d2adf9f1
TT
125552019-01-05 Tom Tromey <tom@tromey.com>
12556
12557 * contrib/cleanup_check.py: Remove.
12558 * contrib/gcc-with-excheck: Remove.
12559 * contrib/exsummary.py: Remove.
12560 * contrib/excheck.py: Remove.
12561
2eab46b1
JB
125622019-01-05 Joel Brobecker <brobecker@adacore.com>
12563
12564 * thread.c (delete_thread_1): Add gdb_assert that THR is not
12565 NULL. Initialize tpprev to NULL instead of assigning it
12566 to NULL on the next statement.
12567 * windows-nat.c (windows_delete_thread): Remove check for
12568 main_thread_id before printing thread exit notifications.
12569 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12570 Remove thread ID check against main_thread_id.
12571 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12572 windows_delete_thread.
12573 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12574
48c5e7e2
TT
125752019-01-04 Tom Tromey <tom@tromey.com>
12576
12577 * compile/compile.c (_initialize_compile): Use upper case for
12578 metasyntactic variables.
12579 * symmisc.c (_initialize_symmisc): Use upper case for
12580 metasyntactic variables.
12581 * psymtab.c (_initialize_psymtab): Use upper case for
12582 metasyntactic variables.
12583 * demangle.c (demangle_command): Use upper case for metasyntactic
12584 variables.
12585 (_initialize_demangler): Likewise.
12586 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12587 variables.
12588
986041cd
TT
125892019-01-03 Tom Tromey <tom@tromey.com>
12590
12591 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12592
7c711119
TT
125932019-01-03 Tom Tromey <tom@tromey.com>
12594
12595 * python/py-symtab.c (salpy_str): Update.
12596 (struct salpy_sal_object) <symtab>: Now a PyObject.
12597 (salpy_dealloc): Update.
12598 (del_objfile_sal): Use gdbpy_ref.
12599
1b20edf0
TT
126002019-01-03 Tom Tromey <tom@tromey.com>
12601
12602 * python/py-type.c (convert_field): Use new_reference. Return
12603 gdbpy_ref.
12604 (make_fielditem): Return gdbpy_ref.
12605 (typy_fields): Update.
12606 (typy_getitem): Update.
12607 (field_name): Return gdbpy_ref. Use new_reference.
12608 (typy_iterator_iternext): Update.
12609
ea41325b
TT
126102019-01-03 Tom Tromey <tom@tromey.com>
12611
12612 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12613
2a3c71d6
TT
126142019-01-03 Tom Tromey <tom@tromey.com>
12615
12616 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12617 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12618 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12619 (pspy_set_frame_filters, pspy_set_frame_unwinders)
12620 (pspy_set_type_printers): Likewise.
12621 * python/py-function.c (fnpy_init): Use gdbpy_ref.
12622 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12623 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12624 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12625 (objfpy_set_type_printers): Likewise.
12626
5c329e6a
TT
126272019-01-03 Tom Tromey <tom@tromey.com>
12628
12629 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12630 (gdbpy_print_stack): Use gdbpy_err_fetch.
12631 * python/python-internal.h (class gdbpy_err_fetch): New class.
12632 (class gdbpy_enter) <m_error_type, m_error_value,
12633 m_error_traceback>: Remove.
12634 <m_error>: New member.
12635 (gdbpy_exception_to_string): Don't declare.
12636 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12637 * python/py-value.c (convert_value_from_python): Use
12638 gdbpy_err_fetch.
12639 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12640 gdbpy_exception_to_string.
12641 (gdbpy_handle_exception): Use gdbpy_err_fetch.
12642 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12643 gdbpy_err_fetch.
12644
169bb27b
AB
126452019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12646
12647 * linux-nat.c (delete_lwp_cleanup): Delete.
12648 (struct lwp_deleter): New struct.
12649 (lwp_info_up): New typedef.
12650 (linux_nat_target::follow_fork): Delete cleanup, and make use of
12651 lwp_info_up.
12652
a07c8880
AB
126532019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12654
12655 * linux-fork.c (class scoped_switch_fork_info): New class.
12656 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12657
26089c49
AB
126582019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12659
12660 * valops.c (find_overload_match): Remove use of null_cleanup, and
12661 calls to do_cleanups.
12662
06d3e5b0
AB
126632019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12664
12665 * compile/compile-cplus-types.c
12666 (compile_cplus_instance::decl_name): Handle changes to
12667 cp_func_name.
12668 * cp-support.c (cp_func_name): Update header comment, update
12669 return type.
12670 * cp-support.h (cp_func_name): Update return type in declaration.
12671 * valops.c (find_overload_match): Move temp_func local to top
12672 level of function and change its type. Use temp_func to hold and
12673 delete temporary string obtained from cp_func_name.
12674
66644cd3
AB
126752019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
12676
12677 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12678 gdb::char_vector, remove cleanup, and update uses of `msg`.
12679
592d8c0a
JW
126802019-01-03 Jim Wilson <jimw@sifive.com>
12681
12682 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12683
c55d06ec
TT
126842019-01-02 Tom Tromey <tom@tromey.com>
12685
12686 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12687 (tdesc_parse_xml): Remove cleanups.
12688 * target-descriptions.h (make_cleanup_free_target_description):
12689 Don't declare.
12690 (target_desc_deleter): New struct.
12691 (target_desc_up): New typedef.
12692 * target-descriptions.c (target_desc_deleter::operator()): Rename
12693 from free_target_description.
12694 (make_cleanup_free_target_description): Remove.
12695
3a6ae42d
TT
126962019-01-02 Tom Tromey <tom@tromey.com>
12697
12698 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
12699 constructor, destructor.
12700 (linespec_parser): Remove typedef.
12701 (~linespec_parser): Rename from linespec_parser_delete.
12702 (linespec_lex_to_end, linespec_complete_label)
12703 (linespec_complete): Update.
12704 (decode_line_full): Remove cleanups.
12705 (decode_line_1): Update.
12706
61fd3e73
TT
127072019-01-02 Tom Tromey <tom@tromey.com>
12708
12709 * python/python-internal.h (inferior_to_inferior_object): Change
12710 return type.
12711 * python/py-exitedevent.c (create_exited_event_object): Update.
12712 * python/py-inferior.c (inferior_to_inferior_object): Return
12713 gdbpy_ref.
12714 (python_new_inferior, python_inferior_deleted)
12715 (thread_to_thread_object, delete_thread_object)
12716 (build_inferior_list, gdbpy_selected_inferior): Update.
12717 * python/py-infthread.c (create_thread_object): Update. Also fail
12718 if inferior_to_inferior_object fails.
12719
d20172fc
SM
127202019-01-02 Simon Marchi <simon.marchi@ericsson.com>
12721
12722 * inferior.h (class inferior) <displaced_step_state>: New field.
12723 * infrun.h (struct displaced_step_state): Move here from
12724 infrun.c. Initialize fields, add constructor.
12725 <inf>: Remove field.
12726 <reset>: New method.
12727 * infrun.c (struct displaced_step_inferior_state): Move to
12728 infrun.h.
12729 (displaced_step_inferior_states): Remove.
12730 (get_displaced_stepping_state): Adust.
12731 (displaced_step_in_progress_any_inferior): Adjust.
12732 (displaced_step_in_progress_thread): Adjust.
12733 (displaced_step_in_progress): Adjust.
12734 (add_displaced_stepping_state): Remove.
12735 (get_displaced_step_closure_by_addr): Adjust.
12736 (remove_displaced_stepping_state): Remove.
12737 (infrun_inferior_exit): Call displaced_step_state.reset.
12738 (use_displaced_stepping): Don't check for NULL.
12739 (displaced_step_prepare_throw): Call
12740 get_displaced_stepping_state.
12741 (displaced_step_fixup): Don't check for NULL.
12742 (prepare_for_detach): Don't check for NULL.
12743
e3319240
PW
127442019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12745
12746 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12747 in case of call that did not complete.
12748
5d36dfb9
AU
127492019-01-02 Andrey Utkin <autkin@undo.io>
12750
12751 * symfile.c (find_separate_debug_file): Fix search of debug files for
12752 remote debuggee.
12753
8833fbf0
TT
127542019-01-02 Tom Tromey <tom@tromey.com>
12755
12756 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12757 indentation.
12758 * python/py-frame.c (frapy_older): Remove cast.
12759 (frapy_newer): Likewise.
12760 * python/py-breakpoint.c (local_setattro): Remove cast.
12761 * python/py-arch.c (archpy_name): Remove local variable.
12762 * python/py-type.c (gdbpy_lookup_type): Remove cast.
12763
4ada3dfd
JB
127642019-01-02 Joel Brobecker <brobecker@adacore.com>
12765
12766 * unittests/basic_string_view/element_access/char/empty.cc:
12767 Fix year range in copyright header.
12768
113b7b81
AB
127692019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
12770
12771 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12772 Delete.
12773 <operator==>: Update with for removed field.
12774 <hash>: Likewise.
12775 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12776 <isa_features>: ...this.
12777 <abi_features>: New field.
12778 (riscv_isa_flen): Update comment.
12779 (riscv_abi_xlen): New declaration.
12780 (riscv_abi_flen): New declaration.
12781 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12782 isa_features.
12783 (riscv_abi_xlen): New function.
12784 (riscv_isa_flen): Update to get answer from isa_features.
12785 (riscv_abi_flen): New function.
12786 (riscv_has_fp_abi): Update to get answer from abi_features.
12787 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12788 xlen and flen.
12789 (riscv_call_info) <xlen, flen>: Update comment.
12790 (riscv_call_arg_struct): Remove invalid assertions
12791 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12792 is removed.
12793 (riscv_gdbarch_init): Gather isa features and abi features
12794 separately, ensure both match on the gdbarch when reusing an old
12795 gdbarch. Relax an error check to allow 32-bit abi float to run on
12796 a target with 64-bit float hardware.
12797
b18ca514
PW
127982019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12799
12800 * source.c (search_command_helper): Stop reverse search
12801 when line 1 has been searched.
12802
ec70d8db
PW
128032019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12804
12805 * record-full.c (record_full_base_target::close): Rewrite
12806 record_full_core_buf_list free logic.
12807
5b38f9c1
PW
128082019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12809
12810 * break-catch-syscall.c (print_one_catch_syscall): xfree
12811 the last text.
12812
66d91b39
JB
128132019-01-01 Joel Brobecker <brobecker@adacore.com>
12814
12815 * top.c (print_gdb_version): Update Copyright year in version
12816 message.
12817
42a4f53d
JB
128182019-01-01 Joel Brobecker <brobecker@adacore.com>
12819
12820 Update copyright year range in all GDB files.
12821
7e955d83 128222019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 12823
5bbd631d 12824 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 12825
5bbd631d 12826For older changes see ChangeLog-2018.
c906108c
SS
12827\f
12828Local Variables:
12829mode: change-log
12830left-margin: 8
12831fill-column: 74
12832version-control: never
57da7796 12833coding: utf-8
c906108c 12834End:
5bbd631d 12835
This page took 4.019216 seconds and 4 git commands to generate.