projects / deliverable / binutils-gdb.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
Automatic date update in version.in
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
59c28372
AH		 12019-03-22 Alan Hayward <alan.hayward@arm.com>
2 Jiong Wang <jiong.wang@arm.com>
3
4 * aarch64-linux-tdep.c
5 (aarch64_linux_iterate_over_regset_sections): Check for pauth
6 section.
7 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8
17e116a7
AH		 92019-03-22 Alan Hayward <alan.hayward@arm.com>
10 Jiong Wang <jiong.wang@arm.com>
11
12 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13 instructions.
14 (aarch64_analyze_prologue_test): Add PACIASP test.
15 (aarch64_prologue_prev_register): Unmask PC value.
16
11e1b75f
AH		 172019-03-22 Alan Hayward <alan.hayward@arm.com>
18 Jiong Wang <jiong.wang@arm.com>
19
20 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
21 (aarch64_dwarf2_prev_register): Unmask PC value.
22 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
23 (aarch64_execute_dwarf_cfa_vendor_op): Check for
24 DW_CFA_AARCH64_negate_ra_state.
25 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
26
34dcc7cf
AH		 272019-03-22 Alan Hayward <alan.hayward@arm.com>
28 Jiong Wang <jiong.wang@arm.com>
29
30 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
31 registers.
32 (aarch64_pseudo_register_name): Likewise.
33 (aarch64_pseudo_register_type): Likewise.
34 (aarch64_pseudo_register_reggroup_p): Likewise.
35 (aarch64_gdbarch_init): Add pauth registers.
36 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
37 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
38 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
39 (struct gdbarch_tdep): Add regnum for ra_state.
40
1ef53e6b
AH		 412019-03-22 Alan Hayward <alan.hayward@arm.com>
42 Jiong Wang <jiong.wang@arm.com>
43
44 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
45
76bed0fd
AH		 462019-03-22 Alan Hayward <alan.hayward@arm.com>
47 Jiong Wang <jiong.wang@arm.com>
48
49 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
50 function.
51 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
52 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
53 (aarch64_gdbarch_init): Add puth registers.
54 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
55 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
56 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
57
ee4fbcfa
AH		 582019-03-22 Alan Hayward <alan.hayward@arm.com>
59 Jiong Wang <jiong.wang@arm.com>
60
61 * aarch64-linux-nat.c
62 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
63 * aarch64-linux-tdep.c
64 (aarch64_linux_core_read_description): Likewise.
65 (aarch64_linux_get_hwcap): New function.
66 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
67 (aarch64_linux_get_hwcap): New declaration.
68
6dc0ebde
AH		 692019-03-22 Alan Hayward <alan.hayward@arm.com>
70 Jiong Wang <jiong.wang@arm.com>
71
72 * aarch64-linux-nat.c
73 (aarch64_linux_nat_target::read_description): Add pauth param.
74 * aarch64-linux-tdep.c
75 (aarch64_linux_core_read_description): Likewise.
76 * aarch64-tdep.c (struct target_desc): Add in pauth.
77 (aarch64_read_description): Add pauth param.
78 (aarch64_gdbarch_init): Likewise.
79 * aarch64-tdep.h (aarch64_read_description): Likewise.
80 * arch/aarch64.c (aarch64_create_target_description): Likewise.
81 * arch/aarch64.h (aarch64_create_target_description): Likewise.
82 * features/Makefile: Add new files.
83 * features/aarch64-pauth.c: New file.
84 * features/aarch64-pauth.xml: New file.
85
595915c1
TT		 862019-03-20 Tom Tromey <tromey@adacore.com>
87
88 * infrun.c (handle_inferior_event): Rename from
89 handle_inferior_event_1. Create a scoped_value_mark.
90 (handle_inferior_event): Remove.
91
4c7d57e7
TT		 922019-03-19 Tom Tromey <tromey@adacore.com>
93
94 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
95 * infrun.h (print_stop_event): Add "displays" parameter.
96 * infrun.c (print_stop_event): Add "displays" parameter.
97
cb246234
PA		 982019-03-19 Pedro Alves <palves@redhat.com>
99
100 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
101 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
102 to -1. Fix TABs vs spaces.
103 (tui_ui_out::tui_ui_out): Don't initialize fields here.
104 * tui/tui-out.h (tui_ui_out) Add intro comments.
105 <m_line, m_start_of_line>: In-class initialize, and add describing
106 comment.
107
3a0e45b2
AH		 1082019-03-18 Alan Hayward <alan.hayward@arm.com>
109
110 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
111 variable names.
112 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
113
5371b850
PA		 1142019-03-18 Pedro Alves <palves@redhat.com>
115 Eli Zaretskii <eliz@gnu.org>
116
117 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
118 m_line and m_start_of_line.
119
b17c4cd0
EZ		 1202019-03-18 Eli Zaretskii <eliz@gnu.org>
121
122 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
123 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
124 it returns a newline. This fixes a regression in TU mode, whereby
125 the next line is output on the same screen line as the user input.
126
4bd56d18
TT		 1272019-03-18 Tom Tromey <tromey@adacore.com>
128
129 * minsyms.c (minimal_symbol_reader::install): Remove call to
130 obstack_blank.
131
55c10aca
PA		 1322019-03-18 Pedro Alves <palves@redhat.com>
133
134 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
135 New globals.
136 (apply_style): New, factored out from ...
137 (apply_ansi_escape): ... this. Handle reverse video mode.
138 (tui_set_reverse_mode): New function.
139 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
140 * tui/tui-winsource.c (tui_show_source_line): Use
141 tui_set_reverse_mode instead of setting A_STANDOUT.
142 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
143 New setter methods.
144
647bb750
HD		 1452019-03-18 Hannes Domani <ssbssa@yahoo.de>
146
147 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
148 Handle tabs.
149
bff8c71f
TT		 1502019-03-18 Tom Tromey <tromey@adacore.com>
151
152 * ada-lang.c (empty_array): Add "high" parameter.
153 (ada_evaluate_subexp): Update.
154
58785d98
ST		 1552019-03-17 Sergei Trofimovich <siarheit@google.com>
156
157 * unittests/string_view-selftests.c: Define
158 _initialize_string_view_selftests unconditionally.
159
d4cbef22
ВМ		 1602019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
161
162 PR gdb/24350
163 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
164
fce4c071
ВМ		 1652019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
166
167 PR gdb/24351
168 * windows-nat.c (display_selector): Fix format specifiers.
169
f7f0a123
EZ		 1702019-03-17 Eli Zaretskii <eliz@gnu.org>
171
172 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
173 tui_refill_source_window instead of tui_refresh_win, to update the
174 current execution line. This fixes redisplay of the current line
175 when stepping through the code with "next" or "step".
176
ab42892f
EZ		 1772019-03-16 Eli Zaretskii <eliz@gnu.org>
178
179 * source-cache.c (source_cache::get_source_lines): Call
180 find_source_lines to initialize s->nlines. This fixes vertical
181 scrolling of TUI source window when the DOWN arrow is pressed.
182
8d8c087f
PW		 1832019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
184
185 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
186 linux-thread-db.c (_initialize_thread_db): Likewise.
187
798e1c30
EZ		 1882019-03-16 Eli Zaretskii <eliz@gnu.org>
189
190 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
191 wclrtoeol in tui_show_source_line". This reverts changes made in
192 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
193
eefba3da
TT		 1942019-03-15 Tom Tromey <tom@tromey.com>
195
196 * symtab.h (struct minimal_symbol): Derive from
197 general_symbol_info.
198 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
199 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
200 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
201 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
202 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
203 (MSYMBOL_SEARCH_NAME): Update.
204 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
205 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
206 * minsyms.c (minimal_symbol_reader::record_full): Update.
207
0de2420c
TT		 2082019-03-15 Tom Tromey <tom@tromey.com>
209
210 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
211
042d75e4
TT		 2122019-03-15 Tom Tromey <tom@tromey.com>
213
214 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
215 unique_xmalloc_ptr.
216 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
217 Update.
218 * minsyms.c (lookup_minimal_symbol_by_pc_section)
219 (build_minimal_symbol_hash_tables)
220 (minimal_symbol_reader::install): Update.
221
db92718b
TT		 2222019-03-15 Tom Tromey <tom@tromey.com>
223
224 * symtab.c (create_demangled_names_hash): Update.
225 (symbol_set_names): Update.
226 * objfiles.h (struct objfile_per_bfd_storage)
227 <demangled_names_hash>: Now an htab_up.
228 * objfiles.c (objfile_per_bfd_storage): Simplify.
229
d6797f46
TT		 2302019-03-15 Tom Tromey <tom@tromey.com>
231
232 * objfiles.h (struct objfile_per_bfd_storage): Declare
233 destructor.
234 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
235 New.
236 (get_objfile_bfd_data): Use new. Don't initialize
237 language_of_main.
238 (free_objfile_per_bfd_storage): Remove.
239 (objfile_bfd_data_free, objfile::~objfile): Use delete.
240
741d7538
TT		 2412019-03-15 Tom Tromey <tom@tromey.com>
242
243 * symfile.c (reread_symbols): Update.
244 * objfiles.c (objfile::objfile): Update.
245 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
246 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
247 comment.
248 (minimal_symbol_reader::install): Update.
249 (terminate_minimal_symbol_table): Remove.
250 * jit.c (jit_object_close_impl): Update.
251
788c80d1
TT		 2522019-03-15 Tom Tromey <tom@tromey.com>
253
254 * minsyms.c (minimal_symbol_reader::record_full): Remove some
255 initializations.
256
1b7a07cb
TT		 2572019-03-15 Tom Tromey <tom@tromey.com>
258
259 * objfiles.h (struct objfile_per_bfd_storage)
260 <demangled_hash_languages>: Now a bitset.
261 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
262 (lookup_minimal_symbol): Update.
263
3db066bc
TT		 2642019-03-15 Tom Tromey <tom@tromey.com>
265
266 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
267 Don't return the symbol.
268 * coffread.c (record_minimal_symbol): Use record_full.
269
3fff2c37
EZ		 2702019-03-14 Eli Zaretskii <eliz@gnu.org>
271
272 The MS-Windows port of ncurses fails to switch to a color pair if
273 one or both of the colors are the implicit default colors. This
274 change records the default colors when TUI is initialized, and
275 then specifies them explicitly when a color pair uses the default
276 colors. This allows color styling in TUI mode on MS-Windows.
277
278 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
279 ncurses_norm_attr.
280 (tui_initialize_io) [__MINGW32__]: Record the default terminal
281 colors in ncurses_norm_attr.
282 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
283 "none", replace it with the default color recorded in
284 ncurses_norm_attr.
285
3b336828
TT		 2862019-03-14 Tom Tromey <tromey@adacore.com>
287
288 * source-cache.h (class source_cache) <get_source_lines>: Return
289 std::string.
290 * source-cache.c (source_cache::extract_lines): Handle case where
291 first_pos==npos. Return std::string.
292 (source_cache::get_source_lines): Update.
293
d085f989
TT		 2942019-03-14 Tom Tromey <tromey@adacore.com>
295
296 * NEWS: Add item for "style sources" commands.
297 * source-cache.c (source_cache::get_source_lines): Check
298 source_styling.
299 * cli/cli-style.c (source_styling): New global.
300 (_initialize_cli_style): Add "style sources" commands.
301 (show_style_sources): New function.
302 * cli/cli-style.h (source_styling): Declare.
303
6f11e682
TT		 3042019-03-14 Pedro Alves <palves@redhat.com>
305 Tom Tromey <tromey@adacore.com>
306
307 * tui/tui-winsource.h (tui_refill_source_window): Declare.
308 * tui/tui-winsource.c (tui_refill_source_window): New function,
309 from...
310 (tui_horizontal_source_scroll): ... here. Move some logic.
311 * cli/cli-style.c (set_style_enabled): Notify new observable.
312 * tui/tui-hooks.c (tui_redisplay_source): New function.
313 (tui_attach_detach_observers): Attach or detach
314 tui_redisplay_source.
315 * observable.h (source_styling_changed): New observable.
316 * observable.c: Define source_styling_changed observable.
317
a068643d
TT		 3182019-03-13 Tom Tromey <tromey@adacore.com>
319
320 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
321 (i386_gnu_nat_target::store_registers): Update.
322 * target-debug.h (target_debug_print_std_string): New macro.
323 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
324 * windows-tdep.c (display_one_tib): Update.
325 * tui/tui-stack.c (tui_make_status_line): Update.
326 * top.c (print_inferior_quit_action): Update.
327 * thread.c (thr_try_catch_cmd): Update.
328 (add_thread_with_info): Update.
329 (thread_target_id_str): Update.
330 (thr_try_catch_cmd): Update.
331 (thread_command): Update.
332 (thread_find_command): Update.
333 * record-btrace.c (record_btrace_target::info_record)
334 (record_btrace_resume_thread, record_btrace_target::resume)
335 (record_btrace_cancel_resume, record_btrace_step_thread)
336 (record_btrace_target::wait, record_btrace_target::wait)
337 (record_btrace_target::wait, record_btrace_target::stop): Update.
338 * progspace.c (print_program_space): Update.
339 * process-stratum-target.c
340 (process_stratum_target::thread_address_space): Update.
341 * linux-fork.c (linux_fork_mourn_inferior)
342 (detach_checkpoint_command, info_checkpoints_command)
343 (linux_fork_context): Update.
344 (linux_fork_detach): Update.
345 (class scoped_switch_fork_info): Update.
346 (delete_checkpoint_command): Update.
347 * infrun.c (follow_fork_inferior): Update.
348 (follow_fork_inferior): Update.
349 (proceed_after_vfork_done): Update.
350 (handle_vfork_child_exec_or_exit): Update.
351 (follow_exec): Update.
352 (displaced_step_prepare_throw): Update.
353 (displaced_step_restore): Update.
354 (start_step_over): Update.
355 (resume_1): Update.
356 (clear_proceed_status_thread): Update.
357 (proceed): Update.
358 (print_target_wait_results): Update.
359 (do_target_wait): Update.
360 (context_switch): Update.
361 (stop_all_threads): Update.
362 (restart_threads): Update.
363 (finish_step_over): Update.
364 (handle_signal_stop): Update.
365 (switch_back_to_stepped_thread): Update.
366 (keep_going_pass_signal): Update.
367 (print_exited_reason): Update.
368 (normal_stop): Update.
369 * inferior.c (inferior_pid_to_str): Change return type.
370 (print_selected_inferior): Update.
371 (add_inferior): Update.
372 (detach_inferior): Update.
373 * dummy-frame.c (fprint_dummy_frames): Update.
374 * dcache.c (dcache_info_1): Update.
375 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
376 (btrace_fetch, btrace_clear): Update.
377 * linux-tdep.c (linux_core_pid_to_str): Change return type.
378 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
379 type.
380 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
381 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
382 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
383 * gdbarch.c, gdbarch.h: Rebuild.
384 * gdbarch.sh (core_pid_to_str): Change return type.
385 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
386 return type.
387 (windows_nat_target::pid_to_str): Change return type.
388 (windows_delete_thread): Update.
389 (windows_nat_target::attach): Update.
390 (windows_nat_target::files_info): Update.
391 * target-delegates.c: Rebuild.
392 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
393 return type.
394 (sol_thread_target::pid_to_str): Change return type.
395 * remote.c (class remote_target) <pid_to_str>: Change return
396 type.
397 (remote_target::pid_to_str): Change return type.
398 (extended_remote_target::attach, remote_target::remote_stop_ns)
399 (remote_target::remote_notif_remove_queued_reply)
400 (remote_target::push_stop_reply, remote_target::disable_btrace):
401 Update.
402 (extended_remote_target::attach): Update.
403 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
404 type.
405 (gdbsim_target::pid_to_str): Change return type.
406 * ravenscar-thread.c (struct ravenscar_thread_target)
407 <pid_to_str>: Change return type.
408 (ravenscar_thread_target::pid_to_str): Change return type.
409 * procfs.c (class procfs_target) <pid_to_str>: Change return
410 type.
411 (procfs_target::pid_to_str): Change return type.
412 (procfs_target::attach): Update.
413 (procfs_target::detach): Update.
414 (procfs_target::fetch_registers): Update.
415 (procfs_target::store_registers): Update.
416 (procfs_target::wait): Update.
417 (procfs_target::files_info): Update.
418 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
419 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
420 return type.
421 (nto_procfs_target::pid_to_str): Change return type.
422 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
423 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
424 return type.
425 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
426 (exit_lwp): Update.
427 (attach_proc_task_lwp_callback, get_detach_signal)
428 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
429 (linux_nat_target::resume, wait_lwp, stop_callback)
430 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
431 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
432 (linux_nat_wait_1, resume_stopped_resumed_lwps)
433 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
434 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
435 type.
436 (inf_ptrace_target::attach): Update.
437 (inf_ptrace_target::files_info): Update.
438 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
439 type.
440 (go32_nat_target::pid_to_str): Change return type.
441 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
442 (gnu_nat_target::wait): Update.
443 (gnu_nat_target::wait): Update.
444 (gnu_nat_target::resume): Update.
445 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
446 (fbsd_nat_target::wait): Update.
447 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
448 type.
449 (darwin_nat_target::attach): Update.
450 * corelow.c (class core_target) <pid_to_str>: Change return type.
451 (core_target::pid_to_str): Change return type.
452 * target.c (normal_pid_to_str): Change return type.
453 (default_pid_to_str): Likewise.
454 (target_pid_to_str): Change return type.
455 (target_translate_tls_address): Update.
456 (target_announce_detach): Update.
457 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
458 return type.
459 (bsd_uthread_target::pid_to_str): Change return type.
460 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
461 type.
462 (bsd_kvm_target::pid_to_str): Change return type.
463 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
464 return type.
465 (aix_thread_target::pid_to_str): Change return type.
466 * target.h (struct target_ops) <pid_to_str>: Change return type.
467 (target_pid_to_str, normal_pid_to_str): Likewise.
468 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
469 type.
470 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
471 type.
472 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
473 return type.
474 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
475 type.
476 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
477 type.
478 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
479 return type.
480
b4be1b06
SM		 4812019-03-13 Simon Marchi <simon.marchi@ericsson.com>
482
483 * NEWS: Mention that the new default MI version is 3. Mention
484 changes to the output of commands and events that deal with
485 multi-location breakpoints.
486 * breakpoint.c: Include "mi/mi-out.h".
487 (print_one_breakpoint): Change output syntax if using MI version
488 >= 3.
489 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
490 New.
491 (mi_multi_location_breakpoint_output_fixed): New.
492 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
493 (mi_cmd_fix_multi_location_breakpoint_output): New.
494 (mi_multi_location_breakpoint_output_fixed): New.
495 * mi/mi-cmds.c (mi_cmds): Register command
496 -fix-multi-location-breakpoint-output.
497 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
498 interpreter "mi".
499
8e5e5494
SM		 5002019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
501
502 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
503 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
504 instantiate mi_ui_out based on interpreter name.
505 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
506 * mi/mi-main.c (mi_load_progress): Likewise.
507
197df35e
JB		 5082019-03-12 John Baldwin <jhb@FreeBSD.org>
509
510 * NEWS: Combine separate "New targets" sections for 8.3.
511
8399425f
JB		 5122019-03-12 John Baldwin <jhb@FreeBSD.org>
513
514 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
515 (ppcfbsd_init_abi): Install gdbarch
516 "fetch_tls_load_module_address" and "get_thread_local_address"
517 methods.
518
b0f87ed0
JB		 5192019-03-12 John Baldwin <jhb@FreeBSD.org>
520
521 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
522 (riscv_fbsd_init_abi): Install gdbarch
523 "fetch_tls_load_module_address" and "get_thread_local_address"
524 methods.
525
ce25aa57
JB		 5262019-03-12 John Baldwin <jhb@FreeBSD.org>
527
528 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
529 (i386fbsd_init_abi): Install gdbarch
530 "fetch_tls_load_module_address" and "get_thread_local_address"
531 methods.
532
f5424cfa
JB		 5332019-03-12 John Baldwin <jhb@FreeBSD.org>
534
535 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
536 (amd64fbsd_init_abi): Install gdbarch
537 "fetch_tls_load_module_address" and "get_thread_local_address"
538 methods.
539
945f3901
JB		 5402019-03-12 John Baldwin <jhb@FreeBSD.org>
541
542 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
543 (struct fbsd_pspace_data): New type.
544 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
545 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
546 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
547 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
548 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
549
ef0bd204
JB		 5502019-03-12 John Baldwin <jhb@FreeBSD.org>
551
552 * gdbtypes.c (lookup_struct_elt): New function.
553 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
554 * gdbtypes.h (struct struct_elt): New type.
555 (lookup_struct_elt): New prototype.
556
36c53a02
JB		 5572019-03-12 John Baldwin <jhb@FreeBSD.org>
558
559 * gdbtypes.c (lookup_struct_elt_type): Update comment and
560 remove disabled code block.
561
6e056c81
JB		 5622019-03-12 John Baldwin <jhb@FreeBSD.org>
563
564 * gdbarch.sh (get_thread_local_address): New method.
565 * gdbarch.h, gdbarch.c: Regenerate.
566 * target.c (target_translate_tls_address): Use
567 gdbarch_get_thread_local_address if present instead of
568 target::get_thread_local_address.
569
cd250a18
JB		 5702019-03-12 John Baldwin <jhb@FreeBSD.org>
571
572 * target.h (target::get_thread_local_address): Update comment.
573
df22c1e5
JB		 5742019-03-12 John Baldwin <jhb@FreeBSD.org>
575
576 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
577 objfile->separate_debug_objfile_backlink if not NULL.
578
dd6876c9
JB		 5792019-03-12 John Baldwin <jhb@FreeBSD.org>
580
581 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
582 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
583 (amd64bsd_store_inferior_registers): Likewise.
584 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
585 Enable segment base registers.
586 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
587 PT_GETFSBASE and PT_GETGSBASE.
588 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
589 PT_SETGSBASE.
590 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
591 segment base registers.
592 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
593
1163a4b7
JB		 5942019-03-12 John Baldwin <jhb@FreeBSD.org>
595
596 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
597 Update calls to i386_target_description to add 'segments'
598 parameter.
599 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
600 add segment base registers.
601 * arch/i386.c (i386_create_target_description): Add 'segments'
602 parameter to enable segment base registers.
603 * arch/i386.h (i386_create_target_description): Likewise.
604 * features/i386/32bit-segments.xml: New file.
605 * features/i386/32bit-segments.c: Generate.
606 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
607 call to i386_target_description to add 'segments' parameter.
608 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
609 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
610 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
611 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
612 if feature is present.
613 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
614 Add 'segments' parameter to call to i386_target_description.
615 (i386_target_description): Add 'segments' parameter to enable
616 segment base registers.
617 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
618 to call to i386_target_description.
619 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
620 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
621 Define I386_NUM_REGS.
622 (i386_target_description): Add 'segments' parameter to enable
623 segment base registers.
624
3a350822
EZ		 6252019-03-12 Eli Zaretskii <eliz@gnu.org>
626
627 PR/24325
628 * source-cache.c: #undef open and close, to avoid unresolved
629 externals during linking.
630
ffdd69cf
TT		 6312019-03-12 Tom Tromey <tromey@adacore.com>
632
633 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
634 const. Add initializers.
635 (_initialize_remote): Don't initialize ptid globals.
636
ec148c57
PA		 6372019-03-12 Pedro Alves <palves@redhat.com>
638
639 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
640
32764270
PA		 6412019-03-12 Pedro Alves <palves@redhat.com>
642
643 * cp-name-parser.y (main): Remove unused 'len' variable.
644
17547186
TT		 6452019-03-12 Tom Tromey <tromey@adacore.com>
646
647 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
648 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
649
d3a70e03
TT		 6502019-03-12 Tom Tromey <tromey@adacore.com>
651
652 * linux-nat.c (iterate_over_lwps): Update.
653 (stop_callback): Remove parameter.
654 (stop_wait_callback, detach_callback, resume_set_callback)
655 (select_singlestep_lwp_callback, set_ignore_sigint)
656 (status_callback, resumed_callback, resume_clear_callback)
657 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
658 data parameter.
659 (linux_nat_target::detach, linux_nat_target::resume)
660 (linux_stop_and_wait_all_lwps, select_event_lwp)
661 (linux_nat_filter_event, linux_nat_wait_1)
662 (linux_nat_target::kill, linux_nat_target::stop)
663 (linux_nat_target::stop): Update.
664 (linux_nat_resume_callback): Change type.
665 (resume_stopped_resumed_lwps, count_events_callback)
666 (select_event_lwp_callback): Likewise.
667 (linux_stop_lwp, linux_nat_stop_lwp): Update.
668 * arm-linux-nat.c (struct update_registers_data): Remove.
669 (update_registers_callback): Change type.
670 (arm_linux_insert_hw_breakpoint1): Update.
671 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
672 parameter.
673 (x86_linux_dr_set_addr): Update.
674 (x86_linux_dr_set_control): Update.
675 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
676 (iterate_over_lwps): Use gdb::function_view.
677 * nat/aarch64-linux-hw-point.c (struct
678 aarch64_dr_update_callback_param): Remove.
679 (debug_reg_change_callback): Change type.
680 (aarch64_notify_debug_reg_change): Update.
681 * s390-linux-nat.c (s390_refresh_per_info): Update.
682
82cb27ff
TT		 6832019-03-11 Tom Tromey <tromey@adacore.com>
684
685 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
686 redundant assignment to "this_cu".
687
568c0683
SM		 6882019-03-08 Simon Marchi <simon.marchi@efficios.com>
689
690 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
691
f09ce22d
SM		 6922019-03-08 Simon Marchi <simon.marchi@efficios.com>
693
694 * gdbtypes.c (rank_one_type_parm_set): New function extracted
695 from...
696 (rank_one_type): ... this.
697
595f96a9
SM		 6982019-03-08 Simon Marchi <simon.marchi@efficios.com>
699
700 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
701 from...
702 (rank_one_type): ... this.
703
2598a94b
SM		 7042019-03-08 Simon Marchi <simon.marchi@efficios.com>
705
706 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
707 from...
708 (rank_one_type): ... this.
709
7f17b20d
SM		 7102019-03-08 Simon Marchi <simon.marchi@efficios.com>
711
712 * gdbtypes.c (rank_one_type_parm_float): New function extracted
713 from...
714 (rank_one_type): ... this.
715
2c509035
SM		 7162019-03-08 Simon Marchi <simon.marchi@efficios.com>
717
718 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
719 from...
720 (rank_one_type): ... this.
721
0dd322dc
SM		 7222019-03-08 Simon Marchi <simon.marchi@efficios.com>
723
724 * gdbtypes.c (rank_one_type_parm_range): New function extracted
725 from...
726 (rank_one_type): ... this.
727
41ea4728
SM		 7282019-03-08 Simon Marchi <simon.marchi@efficios.com>
729
730 * gdbtypes.c (rank_one_type_parm_char): New function extracted
731 from...
732 (rank_one_type): ... this.
733
793cd1d2
SM		 7342019-03-08 Simon Marchi <simon.marchi@efficios.com>
735
736 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
737 from...
738 (rank_one_type): ... this.
739
34910087
SM		 7402019-03-08 Simon Marchi <simon.marchi@efficios.com>
741
742 * gdbtypes.c (rank_one_type_parm_int): New function extracted
743 from...
744 (rank_one_type): ... this.
745
f1f832d6
SM		 7462019-03-08 Simon Marchi <simon.marchi@efficios.com>
747
748 * gdbtypes.c (rank_one_type_parm_func): New function extracted
749 from...
750 (rank_one_type): ... this.
751
b9f4512f
SM		 7522019-03-08 Simon Marchi <simon.marchi@efficios.com>
753
754 * gdbtypes.c (rank_one_type_parm_array): New function extracted
755 from...
756 (rank_one_type): ... this.
757
9293fc63
SM		 7582019-03-08 Simon Marchi <simon.marchi@efficios.com>
759
760 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
761 from...
762 (rank_one_type): ... this.
763
e3abbe7e
PW		 7642019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
765
766 * inferior.c (initialize_inferiors): Ensure 'help set/show print
767 inferior-events' shows the example events.
768
e4adb939
EZ		 7692019-03-08 Eli Zaretskii <eliz@gnu.org>
770
771 Support styling on native MS-Windows console
772
773 PR/24315
774 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
775 on MS-Windows if $TERM is not defined.
776
777 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
778
779 * posix-hdep.c (gdb_console_fputs):
780 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
781 functions.
782 * ui-file.h (gdb_console_fputs): Add prototype.
783
784 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
785 back to fputs only if the former returns zero.
786
25629dfd
TT		 7872019-03-07 Tom Tromey <tom@tromey.com>
788
789 * symmisc.c (print_symbol_bcache_statistics): Update.
790 (print_objfile_statistics): Update.
791 * symfile.c (allocate_symtab): Update.
792 * stabsread.c: Don't include bcache.h.
793 * psymtab.h (struct psymbol_bcache): Don't declare.
794 (class psymtab_storage) <psymbol_cache>: Now a bcache.
795 (psymbol_bcache_init, psymbol_bcache_free)
796 (psymbol_bcache_get_bcache): Don't declare.
797 * psymtab.c (struct psymbol_bcache): Remove.
798 (psymtab_storage::psymtab_storage): Update.
799 (psymtab_storage::~psymtab_storage): Update.
800 (psymbol_bcache_init, psymbol_bcache_free)
801 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
802 (add_psymbol_to_bcache): Update.
803 (allocate_psymtab): Update.
804 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
805 macro_cache>: No longer pointers.
806 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
807 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
808 * macrotab.c (macro_bcache): Update.
809 * macroexp.c: Don't include bcache.h.
810 * gdbtypes.c (check_types_worklist): Update.
811 (types_deeply_equal): Remove TRY/CATCH. Update.
812 * elfread.c (elf_symtab_read): Update.
813 * dwarf2read.c: Don't include bcache.h.
814 * buildsym.c (buildsym_compunit::get_macro_table): Update.
815 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
816 (print_bcache_statistics, bcache_memory_used): Don't declare.
817 (struct bcache): Move from bcache.c. Add constructor, destructor,
818 methods. Rename all data members.
819 * bcache.c (struct bcache): Move to bcache.h.
820 (bcache::expand_hash_table): Rename from expand_hash_table.
821 (bcache): Remove.
822 (bcache::insert): Rename from bcache_full.
823 (bcache::compare): Rename from bcache_compare.
824 (bcache_xmalloc): Remove.
825 (bcache::~bcache): Rename from bcache_xfree.
826 (bcache::print_statistics): Rename from print_bcache_statistics.
827 (bcache::memory_used): Rename from bcache_memory_used.
828
fe726667
PA		 8292019-03-07 Pedro Alves <palves@redhat.com>
830
831 * infrun.c (normal_stop): Also check for
832 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
833
7584bb30
AB		 8342019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
835
836 * f-lang.c (value_from_host_double): Moved to...
837 * value.c (value_from_host_double): ...here.
838 * value.h (value_from_host_double): Declare.
839 * guile/scm-math.c (vlscm_convert_typed_number): Use
840 value_from_host_double.
841 (vlscm_convert_number): Likewise.
842 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
843 * python/py-value.c (convert_value_from_python): Likewise.
844
a7b1986e
TT		 8452019-03-06 Tom Tromey <tom@tromey.com>
846
847 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
848
0ccf4211
TT		 8492019-03-06 Tom Tromey <tom@tromey.com>
850
851 * utils.h (free_current_contents): Don't declare.
852 * utils.c (free_current_contents): Remove.
853
fe7b42e5
TT		 8542019-03-06 Tom Tromey <tom@tromey.com>
855
856 * top.c (quit_force): Update.
857 * main.c (captured_command_loop): Update.
858 * common/new-op.c (operator new): Update.
859 * common/common-exceptions.c (struct catcher)
860 <save_cleanup_chain>: Remove member.
861 (exceptions_state_mc_init): Update.
862 (exception_try_scope_entry): Return nullptr.
863 (exception_try_scope_exit, exception_rethrow)
864 (throw_exception_sjlj, throw_exception_cxx): Update.
865 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
866 (all_cleanups, do_cleanups, discard_cleanups)
867 (discard_final_cleanups, save_cleanups, save_final_cleanups)
868 (restore_cleanups, restore_final_cleanups): Don't declare.
869 (do_final_cleanups): Remove parameter.
870 * common/cleanups.c (cleanup_chain, make_cleanup)
871 (make_cleanup_dtor, all_cleanups, do_cleanups)
872 (discard_my_cleanups, discard_cleanups)
873 (discard_final_cleanups, save_my_cleanups, save_cleanups)
874 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
875 (null_cleanup): Remove.
876 (do_final_cleanups): Remove parameter.
877
c6321f19
TT		 8782019-03-06 Tom Tromey <tom@tromey.com>
879
880 * remote.c (remote_target::remote_parse_stop_reply): Use
881 unique_xmalloc_ptr.
882
61b30099
TT		 8832019-03-06 Tom Tromey <tom@tromey.com>
884
885 * stabsread.c (struct stabs_field_info): Rename from field_info.
886 <list, fnlist>: Add initializers.
887 <obstack>: New member.
888 (read_member_functions, read_struct_fields, read_baseclasses):
889 Allocate on obstack. Don't use cleanups.
890 (read_one_struct_field, read_member_functions, read_struct_fields)
891 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
892 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
893 (read_struct_type): Update.
894
6cceac94
TT		 8952019-03-06 Tom Tromey <tom@tromey.com>
896
897 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
898 * common/filestuff.h (make_cleanup_close): Don't declare.
899 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
900 Remove.
901
72412762
TT		 9022019-03-06 Tom Tromey <tom@tromey.com>
903
904 * solib-aix.c: Use make_scope_exit.
905
2b6ff1c0
TT		 9062019-03-06 Tom Tromey <tom@tromey.com>
907
908 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
909 Use make_scope_exit.
910
d01c5877
TT		 9112019-03-06 Tom Tromey <tom@tromey.com>
912
913 * solib-svr4.c (disable_probes_interface): Remove parameter.
914 (svr4_handle_solib_event): Use make_scope_exit.
915
32603266
TT		 9162019-03-06 Tom Tromey <tom@tromey.com>
917
918 * remote.c (struct stop_reply_deleter): Remove.
919 (stop_reply_up): Update.
920 (struct stop_reply): Derive from notif_event. Don't typedef.
921 <regcache>: Now a std::vector.
922 (stop_reply_xfree): Remove.
923 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
924 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
925 (remote_target::discard_pending_stop_replies): Use delete.
926 (remote_target::remote_parse_stop_reply): Update.
927 (remote_target::process_stop_reply): Update.
928 * remote-notif.h (struct notif_event): Add virtual destructor.
929 Remove "dtr" member.
930 (struct notif_client) <alloc_event>: Return a unique_ptr.
931 (notif_event_xfree): Don't declare.
932 (notif_event_up): New typedef.
933 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
934 (notif_event_xfree, do_notif_event_xfree): Remove.
935 (remote_notif_state_xfree): Update.
936
9799571e
TT		 9372019-03-06 Tom Tromey <tom@tromey.com>
938
939 * infrun.c (displaced_step_clear_cleanup): Now a
940 forward_scope_exit type.
941 (displaced_step_prepare_throw): Update.
942 (displaced_step_fixup): Update.
943
09e3c4ca
TT		 9442019-03-06 Tom Tromey <tom@tromey.com>
945
946 * inferior.h (class inferior): Update comment.
947 * gdbthread.h (class thread_info): Update comment.
948
e2a03548
TT		 9492019-03-06 Joel Brobecker <brobecker@adacore.com>
950 Tom Tromey <tom@tromey.com>
951
952 * stabsread.h (struct stab_section_list): Remove.
953 (coffstab_build_psymtabs): Update.
954 * dbxread.c (symbuf_sections): Now a std::vector.
955 (sect_idx): New global.
956 (fill_symbuf): Update.
957 (coffstab_build_psymtabs): Change type of stabsects parameter.
958 Update.
959 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
960 std::vector.
961 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
962 (coff_locate_sections): Update.
963 (coff_symfile_read): Remove cleanups. Update.
964 (init_stringtab): Add storage parameter.
965 (free_stringtab, free_stringtab_cleanup): Remove.
966 (init_lineno): Add storage parameter.
967 (free_linetab, free_linetab_cleanup): Remove.
968
b7e60d85
PA		 9692019-03-06 Pedro Alves <palves@redhat.com>
970
971 * linux-fork.c (fork_info::clobber_regs): Delete.
972 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
973 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
974 comment. Adjust.
975 (scoped_switch_fork_info::scoped_switch_fork_info)
976 (checkpoint_command, linux_fork_context): Adjust
977 fork_save_infrun_state calls.
978
e52c971f
PA		 9792019-03-06 Pedro Alves <palves@redhat.com>
980
981 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
982 (inf_has_multiple_threads): Return 'bool' and rewrite using
983 inferior_info::threads().
984
06974e6c
PA		 9852019-03-06 Pedro Alves <palves@redhat.com>
986
987 * linux-fork.c: Include <list>.
988 (fork_list): Now a std::list instance.
989 (fork_info): Add ctor, dtor, and in-class initialize all fields.
990 (forks_exist_p, find_last_fork): Adjust.
991 (new_fork): Delete.
992 (one_fork_p): New.
993 (add_fork): Adjust.
994 (free_fork): Delete, folded into fork_info::~fork_info().
995 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
996 Adjust.
997 (init_fork_list): Delete.
998 (linux_fork_killall, linux_fork_mourn_inferior)
999 (linux_fork_detach, info_checkpoints_command): Adjust.
1000 (_initialize_linux_fork): No longer call init_fork_list.
1001
72f31aea
PA		 10022019-03-06 Pedro Alves <palves@redhat.com>
1003
1004 * linux-fork.c (new_fork): New, split out of ...
1005 (add_fork): ... this. Return void. Move "first fork" special
1006 case from here, to ...
1007 (checkpoint_command): ... here.
1008 * linux-linux.h (add_fork): Return void.
1009
efbecbc1
AB		 10102019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
1011
1012 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
1013
0841c79a
AB		 10142019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
1015 Chris January <chris.january@arm.com>
1016 David Lecomber <david.lecomber@arm.com>
1017
1018 * f-exp.y: New token, UNOP_INTRINSIC.
1019 (exp): New pattern using UNOP_INTRINSIC token.
1020 (f77_keywords): Add 'abs' keyword.
1021 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
1022 (value_from_host_double): New function.
1023 (evaluate_subexp_f): Support UNOP_ABS.
1024
4a270568
AB		 10252019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
1026
1027 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
1028 types.
1029
067630bd
AB		 10302019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
1031
1032 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
1033 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
1034 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
1035
3be47f7a
AB		 10362019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
1037
1038 * f-exp.y (convert_to_kind_type): Handle more type kinds.
1039
4d00f5d8
AB		 10402019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
1041 Chris January <chris.january@arm.com>
1042
1043 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
1044 * f-exp.y: Define 'KIND' token.
1045 (exp): New pattern for KIND expressions.
1046 (ptype): Handle types with a kind extension.
1047 (direct_abs_decl): Extend to spot kind extensions.
1048 (f77_keywords): Add 'kind' to the list.
1049 (push_kind_type): New function.
1050 (convert_to_kind_type): New function.
1051 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
1052 * parse.c (operator_length_standard): Likewise.
1053 * parser-defs.h (enum type_pieces): Add tp_kind.
1054 * std-operator.def: Add UNOP_KIND.
1055
e454224f
AB		 10562019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
1057
1058 * f-exp.y (f_parse): Set yydebug.
1059
9dad4a58
AB		 10602019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
1061
1062 * f-lang.c (evaluate_subexp_f): New function.
1063 (exp_descriptor_f): New global.
1064 (f_language_defn): Use exp_descriptor_f instead of
1065 exp_descriptor_standard.
1066
c8f91604
AB		 10672019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
1068
1069 * f-exp.y (struct token): Add comments.
1070 (dot_ops): Remove uppercase versions and the end marker.
1071 (f77_keywords): Likewise.
1072 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
1073 entries in the dot_ops array are case insensitive, and use
1074 strncasecmp to compare strings. Also some whitespace cleanup in
1075 this area. Similar for the f77_keywords array, except entries in
1076 this list might be case sensitive.
1077
dd9f2c76
AB		 10782019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
1079
1080 * f-exp.y (struct f77_boolean_val): Add comments.
1081 (boolean_values): Remove uppercase versions, and end marker.
1082 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
1083 and use strncasecmp to achieve case insensitivity. Additionally,
1084 perform whitespace cleanup around this code.
1085
67a3048c
TT		 10862019-03-06 Tom Tromey <tromey@adacore.com>
1087
1088 * remote-sim.c (gdbsim_target_open): Use result of
1089 gdb_argv::release.
1090
aa3cfbda
RB		 10912019-03-06 Richard Bunt <richard.bunt@arm.com>
1092 Dirk Schubert <dirk.schubert@arm.com>
1093 Chris January <chris.january@arm.com>
1094
1095 * eval.c (evaluate_subexp_standard): Call Fortran argument
1096 wrapping logic.
1097 * f-lang.c (struct value): A value which can be passed into a
1098 Fortran function call.
1099 (fortran_argument_convert): Wrap Fortran arguments in a pointer
1100 where appropriate.
1101 (struct type): Value ready for a Fortran function call.
1102 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
1103 is needed.
1104 * f-lang.h (fortran_argument_convert): Declaration.
1105 (fortran_preserve_arg_pointer): Declaration.
1106 * infcall.c (value_arg_coerce): Call Fortran argument logic.
1107
ea38e5df
TT		 11082019-03-05 Tom Tromey <tromey@adacore.com>
1109
1110 * python/py-prettyprint.c (print_string_repr): Remove #if.
1111 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
1112
06b5b831
TT		 11132019-03-05 Tom Tromey <tromey@adacore.com>
1114
1115 * target.c (the_dummy_target): Move later. Change type to
1116 "dummy_target".
1117 (initialize_targets): Don't initialize the_dummy_target.
1118
edbd9e45
TT		 11192019-03-05 Tom Tromey <tromey@adacore.com>
1120
1121 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
1122 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
1123
c119e040
TT		 11242019-03-05 Tom Tromey <tromey@adacore.com>
1125
1126 * windows-nat.c (windows_nat_target::attach)
1127 (windows_nat_target::detach): Don't call gdb_flush.
1128 * valprint.c (generic_val_print, val_print, val_print_string):
1129 Don't call gdb_flush.
1130 * utils.c (defaulted_query): Don't call gdb_flush.
1131 * typeprint.c (print_type_scalar): Don't call gdb_flush.
1132 * target.c (target_announce_detach): Don't call gdb_flush.
1133 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1134 * remote.c (extended_remote_target::attach): Don't call
1135 gdb_flush.
1136 * procfs.c (procfs_target::detach): Don't call gdb_flush.
1137 * printcmd.c (do_examine): Don't call gdb_flush.
1138 (info_display_command): Don't call gdb_flush.
1139 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1140 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1141 * memattr.c (info_mem_command): Don't call gdb_flush.
1142 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1143 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1144 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1145 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1146 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1147 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1148 (gnu_nat_target::detach): Don't call gdb_flush.
1149 * f-valprint.c (f_val_print): Don't call gdb_flush.
1150 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1151 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1152 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1153 gdb_flush.
1154 * c-valprint.c (c_val_print): Don't call gdb_flush.
1155 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1156
895dafa6
TT		 11572019-03-05 Tom Tromey <tromey@adacore.com>
1158
1159 * varobj.c (update_dynamic_varobj_children): Update.
1160 (install_default_visualizer): Use reset, not release.
1161 * value.c (set_internalvar): Update.
1162 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1163 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1164 ATTRIBUTE_UNUSED_RESULT.
1165
88a774b9
TT		 11662019-03-05 Tom Tromey <tromey@adacore.com>
1167
1168 * remote.c (class scoped_remote_fd) <release>: Add
1169 ATTRIBUTE_UNUSED_RESULT.
1170
4e4a8b93
TT		 11712019-03-05 Tom Tromey <tromey@adacore.com>
1172
1173 * macroexp.c (struct macro_buffer) <release>: Add
1174 ATTRIBUTE_UNUSED_RESULT.
1175
083eef1f
TT		 11762019-03-05 Tom Tromey <tromey@adacore.com>
1177
1178 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1179 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1180 ATTRIBUTE_UNUSED_RESULT.
1181
3cabd438
TT		 11822019-03-05 Tom Tromey <tromey@adacore.com>
1183
1184 * common/scoped_fd.h (class scoped_fd) <release>: Add
1185 ATTRIBUTE_UNUSED_RESULT.
1186
41e3300a
TT		 11872019-03-05 Tom Tromey <tromey@adacore.com>
1188
1189 * parser-defs.h (struct parser_state) <release>: Add
1190 ATTRIBUTE_UNUSED_RESULT.
1191
18cb7c9f
TT		 11922019-03-05 Tom Tromey <tromey@adacore.com>
1193
1194 * utils.h (class gdb_argv) <release>: Add
1195 ATTRIBUTE_UNUSED_RESULT.
1196 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1197
41fa577f
EZ		 11982019-03-02 Eli Zaretskii <eliz@gnu.org>
1199
a6a4b2c6
EZ		 1200 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1201 for-loop range, to avoid compiler warnings.
1202
1203 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1204 avoid compiler warnings about unused variables.
1205
742a7df5
EZ		 1206 * NEWS: Mention end of support for native debugging on MS-Windows
1207 before XP.
1208
41fa577f
EZ		 1209 PR gdb/24292
1210 * common/netstuff.c:
1211 * gdbserver/gdbreplay.c
1212 * gdbserver/remote-utils.c:
1213 * ser-tcp.c:
1214 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1215 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
1216 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1217 'getaddrinfo' and 'freeaddrinfo' were not available before
1218 Windows XP, and mingw.org's MinGW headers by default define
1219 _WIN32_WINNT to 0x500.
1220
827f438f
GB		 12212019-03-01 Gary Benson <gbenson@redhat.com>
1222
1223 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1224
92137da0
RO		 12252019-02-28 Brian Vandenberg <phantall@gmail.com>
1226 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1227
1228 PR gdb/8527
1229 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1230 set_sigint_trap, clear_sigint_trap.
1231
799efbe8
PW		 12322019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1233
1234 * target.c (target_detach): Clear the regcache and the
1235 frame cache.
1236
8ed25214
PA		 12372019-02-27 Pedro Alves <palves@redhat.com>
1238
1239 * utils.c (set_screen_size): When we cap the height/width sizes,
1240 tweak the corresponding command variable to show "unlimited":
1241
23031e31
SJ		 12422019-02-27 Saagar Jha <saagar@saagarjha.com>
1243 Pedro Alves <palves@redhat.com>
1244
1245 * utils.c (set_screen_size): Reduce "infinite" rows and columns
1246 before calling rl_set_screen_size.
1247
6c28e44a
TT		 12482019-02-27 Tom Tromey <tromey@adacore.com>
1249
1250 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1251 define.
1252 * python/py-value.c: Remove Python 2.4 workaround.
1253 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1254 workaround.
1255 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1256 Python 2.4 workaround.
1257 * python/python-internal.h: Remove Python 2.4 comment.
1258 (Py_ssize_t): Don't define.
1259 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1260 (gdb_Py_DECREF): Remove Python 2.4 workaround.
1261 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1262 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1263 * python/python.c (do_start_initialization): Remove Python 2.4
1264 workaround.
1265 * python/py-prettyprint.c (class dummy_python_frame): Remove.
1266 (print_children): Remove Python 2.4 workaround.
1267 * python/py-inferior.c (buffer_procs): Remove Python 2.4
1268 workaround.
1269 (CHARBUFFERPROC_NAME): Remove.
1270 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1271 Python 2.4 workaround.
1272
2c3fc25d 12732019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 1274
2c3fc25d
KB		 1275 * NEWS: Note minimum Python version.
1276
6ca62222
KB		 12772019-02-27 Kevin Buettner <kevinb@redhat.com>
1278
1279 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1280 code from these functions. Remove corresponding ifdefs. Use
1281 Py_buffer_up instead of explicit calls to PyBuffer_Release.
1282 Remove gotos and target of gotos.
1283 (infpy_search_memory): Likewise.
1284
f4bc7d2c
AB		 12852019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
1286
1287 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1288 (hppa_gdbarch_init): Don't register deleted functions with
1289 gdbarch.
1290
9734a586
AB		 12912019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
1292
1293 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1294 (h8300_unwind_sp): Delete.
1295 (h8300_dummy_id): Delete.
1296 (h8300_gdbarch_init): Don't register deleted functions with
1297 gdbarch.
1298
68b867f3
AB		 12992019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
1300
1301 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1302 (ft32_unwind_pc): Delete.
1303 (ft32_unwind_sp): Delete.
1304 (ft32_gdbarch_init): Don't register deleted functions with
1305 gdbarch.
1306
2fbe7ad0
AB		 13072019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
1308
1309 * gdb/frv-tdep.c (frv_dummy_id): Delete.
1310 (frv_unwind_pc): Delete.
1311 (frv_unwind_sp): Delete.
1312 (frv_gdbarch_init): Don't register deleted functions with
1313 gdbarch.
1314
76055cbe
AB		 13152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
1316
1317 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1318 (riscv_unwind_pc): Delete.
1319 (riscv_unwind_sp): Delete.
1320 (riscv_gdbarch_init): Don't register deleted functions with
1321 gdbarch.
1322
4133e5a1
AB		 13232019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
1324
1325 * gdb/csky-tdep.c (csky_dummy_id): Delete.
1326 (csky_unwind_pc): Delete.
1327 (csky_unwind_sp): Delete.
1328 (csky_gdbarch_init): Don't register deleted functions with
1329 gdbarch.
1330
8010f576
AB		 13312019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
1332
1333 * gdb/cris-tdep.c (cris_dummy_id): Delete.
1334 (cris_unwind_pc): Delete.
1335 (cris_unwind_sp): Delete.
1336 (cris_gdbarch_init): Don't register deleted functions with
1337 gdbarch.
1338
b56bf084
AB		 13392019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
1340
1341 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1342 (bfin_unwind_pc): Delete.
1343 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1344
a19a650f
AB		 13452019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
1346
1347 * gdb/arm-tdep.c (arm_dummy_id): Delete.
1348 (arm_unwind_pc): Delete.
1349 (arm_unwind_sp): Delete.
1350 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1351
f8278c3c
AB		 13522019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
1353
1354 * gdb/arc-tdep.c (arc_dummy_id): Delete.
1355 (arc_unwind_pc): Delete.
1356 (arc_unwind_sp): Delete.
1357 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1358
480e46cf
AB		 13592019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
1360
1361 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1362 (alpha_unwind_pc): Delete.
1363 (alpha_gdbarch_init): Don't register deleted functions with
1364 gdbarch.
1365
7a995095
AB		 13662019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
1367
1368 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1369 (aarch64_unwind_pc): Delete.
1370 (aarch64_unwind_sp): Delete.
1371 (aarch64_gdbarch_init): Don't register deleted functions with
1372 gdbarch.
1373
bf9a735e
AB		 13742019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
1375
1376 * gdbtypes.c (type_align): Don't consider static members when
1377 computing structure alignment.
1378
5561fc30
AB		 13792019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
1380
1381 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1382 return 0 for other types.
1383 * arch-utils.c (default_type_align): Always return 0.
1384 * gdbarch.h: Regenerate.
1385 * gdbarch.sh (type_align): Extend comment.
1386 * gdbtypes.c (type_align): Add additional comments, always call
1387 gdbarch_type_align before applying the default rules.
1388 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1389 generic code will then apply a suitable default.
1390 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1391 types, return 0 for other types.
1392
9335e75a
JB		 13932019-02-27 Joel Brobecker <brobecker@adacore.com>
1394
1395 * NEWS: Create a new section for the next release branch.
1396 Rename the section of the current branch, now that it has
1397 been cut.
1398
3d34d8de
JB		 13992019-02-27 Joel Brobecker <brobecker@adacore.com>
1400
1401 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1402 * version.in: Bump version to 8.3.50.DATE-git.
1403
143420fb
SM		 14042019-02-26 Simon Marchi <simon.marchi@efficios.com>
1405
1406 * aix-thread.c (ptid_cmp): Remove unused variable.
1407 (get_signaled_thread): Likewise.
1408 (store_regs_user_thread): Likewise.
1409 (store_regs_kernel_thread): Likewise.
1410 (fetch_regs_kernel_thread): Remove shadowed variable.
1411
172fb711
AB		 14122019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
1413
1414 * features/riscv/32bit-cpu.xml: Add register numbers.
1415 * features/riscv/32bit-fpu.c: Regenerate.
1416 * features/riscv/32bit-fpu.xml: Add register numbers.
1417 * features/riscv/64bit-cpu.xml: Add register numbers.
1418 * features/riscv/64bit-fpu.c: Regenerate.
1419 * features/riscv/64bit-fpu.xml: Add register numbers.
1420
26c89782
KB		 14212019-02-26 Kevin Buettner <kevinb@redhat.com>
1422
af54ade9 1423 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB		 1424 * python/py-value.c (convert_buffer_and_type_to_value): New
1425 function.
1426 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1427 Add support for handling an optional second argument. Call
1428 convert_buffer_and_type_to_value as appropriate.
26c89782
KB		 1429 * python/python-internal.h (Py_buffer_deleter): New struct.
1430 (Py_buffer_up): New typedef.
1431
0f58c9e8
JB		 14322019-02-25 John Baldwin <jhb@FreeBSD.org>
1433
1434 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1435 instead of releasing ownership.
1436
0a0f4c01
JR		 14372019-02-25 Jordan Rupprecht <rupprecht@google.com>
1438
1439 * dwarf2read.c (open_and_init_dwp_file): Call
1440 elf_numsections instead of bfd_count_sections to initialize
1441 dwp_file->num_sections.
1442
cd5a152c
TT		 14432019-02-25 Tom Tromey <tromey@adacore.com>
1444
1445 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1446
8a6a8513
SDJ		 14472019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
1448
1449 * gcore.in: Add '--readnever' option when invoking GDB.
1450
04dcda9c
SM		 14512019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
1452
1453 * MAINTAINERS: Update my email address.
1454
07bc701d
SM		 14552019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
1456
1457 * build-id.c (build_id_to_debug_bfd_1): New function.
1458 (build_id_to_debug_bfd): Look for separate debug file in
1459 sysroot.
1460
c6f4a5d0
AB		 14612019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
1462
1463 * gdbarch.sh: Update the copyright year range that is placed into
1464 generated files.
1465
9600246d
KS		 14662019-02-22 Keith Seitz <keiths@redhat.com>
1467
1468 PR symtab/23853
1469 * linespec.c (create_sals_line_offset): Search for the default
1470 symtab's filename instead of its fullname.
1471
7557a514
AH		 14722019-02-21 Alan Hayward <alan.hayward@arm.com>
1473
1474 * NEWS: Update style defaults.
1475
ee2bcb0c
AH		 14762019-02-21 Alan Hayward <alan.hayward@arm.com>
1477
1478 * main.c (captured_main_1): Disable styling in batch mode.
1479
0c95f9ed
TT		 14802019-02-20 Tom Tromey <tom@tromey.com>
1481
1482 * symtab.c (symtab_symbol_info): Fix typos.
1483
c763b894
TT		 14842019-02-20 Tom Tromey <tromey@adacore.com>
1485
1486 * findcmd.c (_initialize_mem_search): Use upper case for
1487 metasyntactic variables.
1488
0ef8a082
AH		 14892019-02-20 Alan Hayward <alan.hayward@arm.com>
1490
1491 * aarch64-tdep.c (aarch64_add_reggroups): New function.
1492 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1493
6caa91b6
SM		 14942019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
1495
1496 * top.h (source_file_name): Change to std::string.
1497 * top.c (source_file_name): Likewise.
1498 (command_line_input): Adjust.
1499 * cli/cli-script.c (script_from_file): Adjust.
1500
98814c6c
TT		 15012019-02-19 Tom Tromey <tromey@adacore.com>
1502
1503 * ravenscar-thread.c
1504 (ravenscar_thread_target::update_thread_list): Don't call
1505 ada_build_task_list.
1506 * ada-lang.h (ada_build_task_list): Don't declare.
1507 * ada-tasks.c (struct ada_tasks_inferior_data)
1508 <task_list_valid_p>: Now bool.
1509 (read_known_tasks, ada_task_list_changed)
1510 (ada_tasks_invalidate_inferior_data): Update.
1511 (read_known_tasks_array): Return bool.
1512 (read_known_tasks_list): Likewise.
1513 (read_known_tasks): Return void.
1514 (ada_build_task_list): Now static.
1515
70cd633e
AB		 15162019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
1517
1518 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1519 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1520
040b3e95
PW		 15212019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1522
1523 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1524 variant for ada_tasks_pspace_data_handle and
1525 ada_tasks_inferior_data_handle.
1526 (ada_tasks_pspace_data_cleanup): New function.
1527 (ada_tasks_inferior_data_cleanup): New function.
1528
9409233b
TT		 15292019-02-17 Tom Tromey <tom@tromey.com>
1530
1531 * macrotab.h (macro_source_fullname): Return a std::string.
1532 * macrotab.c (macro_include, check_for_redefinition)
1533 (macro_undef, macro_lookup_definition, foreach_macro)
1534 (foreach_macro_in_scope): Update.
1535 (macro_source_fullname): Return a std::string.
1536 * macrocmd.c (show_pp_source_pos): Update.
1537
6506371f
TT		 15382019-02-17 Tom Tromey <tom@tromey.com>
1539
1540 * macrocmd.c (show_pp_source_pos): Style the file names.
1541
0c820d67
TT		 15422019-02-17 Tom Tromey <tom@tromey.com>
1543
1544 PR tui/24197:
1545 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1546
a0087920
TT		 15472019-02-17 Tom Tromey <tom@tromey.com>
1548
1549 * ada-lang.c (user_select_syms): Use filtered printing.
1550 * utils.c (wrap_style): New global.
1551 (desired_style): Remove.
1552 (emit_style_escape): Add stream parameter.
1553 (set_output_style, reset_terminal_style, prompt_for_continue):
1554 Update.
1555 (flush_wrap_buffer): Only flush gdb_stdout.
1556 (wrap_here): Set wrap_style.
1557 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
1558 treat escape sequences as a character. Change when wrap buffer is
1559 flushed.
1560 (fputs_styled): Do not set the output style when the default is
1561 requested.
1562 * ui-style.h (struct ui_file_style) <is_default>: New method.
1563 * source.c (print_source_lines_base): Emit escape sequences in one
1564 piece.
1565
75ba10dc
JB		 15662019-02-17 Joel Brobecker <brobecker@adacore.com>
1567
1568 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1569 integers and enumeration types.
1570
a2cd4f14
JB		 15712019-02-17 Joel Brobecker <brobecker@adacore.com>
1572
1573 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1574 instead of lookup_symbol_in_language
1575 (do_exact_match): New function.
1576 (ada_get_symbol_name_matcher): Return do_exact_match when
1577 doing a verbatim match.
1578
485b851b
TT		 15792019-02-15 Tom Tromey <tromey@adacore.com>
1580
1581 * ravenscar-thread.c (ravenscar_thread_target::resume)
1582 (ravenscar_thread_target::wait): Special case wildcard requests.
1583
0b790b1e
TT		 15842019-02-15 Tom Tromey <tromey@adacore.com>
1585
1586 * ravenscar-thread.c (base_ptid): Remove.
1587 (struct ravenscar_thread_target) <close>: New method.
1588 <m_base_ptid>: New member.
1589 <update_inferior_ptid, active_task, task_is_currently_active,
1590 runtime_initialized>: Declare methods.
1591 <ravenscar_thread_target>: Add constructor.
1592 (ravenscar_thread_target::task_is_currently_active)
1593 (ravenscar_thread_target::update_inferior_ptid)
1594 (ravenscar_runtime_initialized): Rename. Now methods.
1595 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1596 (ravenscar_thread_target::update_thread_list): Update.
1597 (ravenscar_thread_target::active_task): Now method.
1598 (ravenscar_thread_target::store_registers)
1599 (ravenscar_thread_target::prepare_to_store)
1600 (ravenscar_thread_target::prepare_to_store)
1601 (ravenscar_thread_target::mourn_inferior): Update.
1602 (ravenscar_inferior_created): Use "new" to create target.
1603 (ravenscar_thread_target::get_ada_task_ptid): Update.
1604 (_initialize_ravenscar): Don't initialize base_ptid.
1605 (ravenscar_ops): Remove global.
1606
dea57a62
TT		 16072019-02-15 Tom Tromey <tromey@adacore.com>
1608
1609 * target.h (push_target): Declare new overload.
1610 * target.c (push_target): New overload, taking an rvalue reference.
1611 * remote.c (remote_target::open_1): Use push_target overload.
1612 * corelow.c (core_target_open): Use push_target overload.
1613
989f3c58
TT		 16142019-02-15 Tom Tromey <tromey@adacore.com>
1615
1616 * ravenscar-thread.c (is_ravenscar_task)
1617 (ravenscar_task_is_currently_active): Return bool.
1618 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1619 (_initialize_ravenscar): Remove "(void)".
1620 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1621 Return bool.
1622
6cbcc006
TT		 16232019-02-15 Tom Tromey <tromey@adacore.com>
1624
1625 * ravenscar-thread.c (ravenscar_runtime_initializer)
1626 (has_ravenscar_runtime, get_running_thread_id)
1627 (ravenscar_thread_target::resume): Fix indentation.
1628
7657f14d
TT		 16292019-02-15 Tom Tromey <tromey@adacore.com>
1630
1631 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1632 from ravenscar_arch_ops.
1633 (sparc_ravenscar_ops::fetch_registers)
1634 (sparc_ravenscar_ops::store_registers): Now methods.
1635 (sparc_ravenscar_prepare_to_store): Remove.
1636 (sparc_ravenscar_ops): Redefine.
1637 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1638 methods and destructor. Remove members.
1639 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1640 (ravenscar_thread_target::store_registers)
1641 (ravenscar_thread_target::prepare_to_store): Update.
1642 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1643 Remove.
1644 (struct ppc_ravenscar_powerpc_ops): Derive from
1645 ravenscar_arch_ops.
1646 (ppc_ravenscar_powerpc_ops::fetch_registers)
1647 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1648 (ppc_ravenscar_powerpc_ops): Redefine.
1649 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1650 (ppc_ravenscar_e500_ops::fetch_registers)
1651 (ppc_ravenscar_e500_ops::store_registers): Now methods.
1652 (ppc_ravenscar_e500_ops): Redefine.
1653 * aarch64-ravenscar-thread.c
1654 (aarch64_ravenscar_generic_prepare_to_store): Remove.
1655 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1656 (aarch64_ravenscar_fetch_registers)
1657 (aarch64_ravenscar_store_registers): Now methods.
1658 (aarch64_ravenscar_ops): Redefine.
1659
5b6ea500
TT		 16602019-02-15 Tom Tromey <tromey@adacore.com>
1661
1662 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1663 (ravenscar_thread_target::stopped_by_hw_breakpoint)
1664 (ravenscar_thread_target::stopped_by_watchpoint)
1665 (ravenscar_thread_target::stopped_data_address)
1666 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1667
e397fd39
TT		 16682019-02-15 Tom Tromey <tromey@adacore.com>
1669
1670 * ravenscar-thread.c: Fix some typos.
1671
cc12f4a8
TT		 16722019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1673 Tom Tromey <tromey@adacore.com>
1674
1675 * ada-lang.c (ada_exception_sal): Change addr_string to a
1676 std::string.
1677 (create_ada_exception_catchpoint): Update.
1678
5f486660
TT		 16792019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1680 Tom Tromey <tromey@adacore.com>
1681
1682 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1683 (bp_location_ops): Remove.
1684 (base_breakpoint_allocate_location): Update.
1685 (free_bp_location): Update.
1686 * ada-lang.c (class ada_catchpoint_location)
1687 <ada_catchpoint_location>: Remove ops parameter.
1688 (ada_catchpoint_location_dtor): Remove.
1689 (ada_catchpoint_location_ops): Remove.
1690 (allocate_location_exception): Update.
1691 * breakpoint.h (struct bp_location_ops): Remove.
1692 (class bp_location) <bp_location>: Remove bp_location_ops
1693 parameter.
1694 <~bp_location>: Add destructor.
1695 <ops>: Remove.
1696
b671c7fb
TS		 16972019-02-14 Thomas Schwinge <thomas@codesourcery.com>
1698 Pedro Alves <palves@redhat.com>
1699
1700 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1701 'PATH_MAX'.
1702
8071c5ce
DM		 17032019-02-14 David Michael <fedora.dm0@gmail.com>
1704 Samuel Thibault <samuel.thibault@gnu.org>
1705 Thomas Schwinge <thomas@codesourcery.com>
1706
1707 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1708 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1709
b1041ae0
TS		 17102019-02-14 Thomas Schwinge <thomas@codesourcery.com>
1711
924514e1
TS		 1712 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1713 (check_empty): Use "const char *".
1714
c29ee8d4
TS		 1715 * gnu-nat.c (gnu_nat_target::detach): Instead of
1716 'detach_inferior (pid)' call
1717 'detach_inferior (find_inferior_pid (pid))'.
1718
6c6ef69f
TS		 1719 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1720 'nat/fork-inferior.o'.
1721 * gnu-nat.c: #include "nat/fork-inferior.h".
1722
2d0a338c
TS		 1723 * gnu-nat.c (gnu_nat_target::detach): Instead of
1724 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1725 * gnu-nat.h: #include "inf-child.h".
1726 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1727 'i386_gnu_nat_target::fetch_registers'.
1728 (gnu_store_registers): Rename/move to
1729 'i386_gnu_nat_target::store_registers'.
1730
cabb5f06
TS		 1731 * config/i386/nm-i386gnu.h: Don't "#include" any files.
1732 * gnu-nat.h (mach_thread_info): New function.
1733 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1734
b1041ae0
TS		 1735 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1736
2988d01e
KF		 17372019-02-14 Frederic Konrad <konrad@adacore.com>
1738
1739 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1740
c559d709
JB		 17412019-02-14 Joel Brobecker <brobecker@adacore.com>
1742
1743 * windows-nat.c (windows_add_thread): Add new parameter
1744 "main_thread_p" with default value set to false. Update
1745 function documentation as well as all callers.
1746 (windows_delete_thread): Likewise.
1747 (fake_create_process): Update call to windows_add_thread.
1748 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1749 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1750 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1751 call to windows_delete_thread.
1752
007024cc
SM		 17532019-02-13 Simon Marchi <simon.marchi@ericsson.com>
1754
1755 * MAINTAINERS: Add Andrew Burgess as global maintainer.
1756
f62318e9
JB		 17572019-02-12 John Baldwin <jhb@FreeBSD.org>
1758
1759 * symfile.c (find_separate_debug_file): Use canonical path of
1760 sysroot with child_path instead of gdb_sysroot if it is valid.
1761
cd4b7848
JB		 17622019-02-12 John Baldwin <jhb@FreeBSD.org>
1763
1764 * symfile.c (find_separate_debug_file): Use child_path to
1765 determine if an object file is under a sysroot.
1766
efac4bfe
JB		 17672019-02-12 John Baldwin <jhb@FreeBSD.org>
1768
1769 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1770 unittests/child-path-selftests.c.
1771 * common/pathstuff.c (child_path): New function.
1772 * common/pathstuff.h (child_path): New prototype.
1773 * unittests/child-path-selftests.c: New file.
1774
402d2bfe
JB		 17752019-02-12 John Baldwin <jhb@FreeBSD.org>
1776
1777 * symfile.c (find_separate_debug_file): Look for separate debug
1778 files in debug directories under the sysroot.
1779
1ed9f74e
PW		 17802019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1781
1782 * symtab.h (struct minimal_symbol data_p): New const method.
1783 (struct minimal_symbol text_p): Likewise.
1784 * symtab.c (output_source_filename): Use file name style
1785 to print file name.
1786 (print_symbol_info): Likewise.
1787 (print_msymbol_info): Use address style to print addresses.
1788 Use function name style to print executable text symbols.
1789 (expand_symtab_containing_pc): Use data_p.
1790 (find_pc_sect_compunit_symtab): Likewise.
1791
2636d81d
PW		 17922019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1793
1794 * breakpoint.c (describe_other_breakpoints): Use address style
1795 to print addresses.
1796 (say_where): Likewise.
1797
ac8c53cc
PW		 17982019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1799
1800 * ada-typeprint.c (print_func_type): Print function name
1801 style to print function name.
1802 * c-typeprint.c (c_print_type_1): Likewise.
1803
ea638c43
AH		 18042019-02-11 Alan Hayward <alan.hayward@arm.com>
1805
1806 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1807 for execve.
1808
ab759ca8
PW		 18092019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1810
1811 * c-exp.y (direct_abs_decl): Use emplace_back to record the
1812 type_stack.
1813
aff29d1c
JB		 18142019-02-10 Joel Brobecker <brobecker@adacore.com>
1815
1816 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1817 TYPE_CODE_REF types.
1818
617126bc
JW		 18192019-02-08 Jim Wilson <jimw@sifive.com>
1820
1821 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1822 (riscv_linux_fregset): New.
1823 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1824
46e3ed7f
TT		 18252019-02-07 Tom Tromey <tom@tromey.com>
1826
1827 * thread.c (thread_cancel_execution_command): Update.
1828 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1829 methods.
1830 (struct thread_fsm_ops): Remove.
1831 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1832 (thread_fsm_should_stop, thread_fsm_return_value)
1833 (thread_fsm_set_finished, thread_fsm_finished_p)
1834 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1835 Don't declare.
1836 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1837 * infrun.c (clear_proceed_status_thread)
1838 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1839 (print_stop_event): Update.
1840 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1841 Add constructor.
1842 (step_command_fsm_ops): Remove.
1843 (new_step_command_fsm): Remove.
1844 (step_1): Update.
1845 (step_command_fsm::should_stop): Rename from
1846 step_command_fsm_should_stop.
1847 (step_command_fsm::clean_up): Rename from
1848 step_command_fsm_clean_up.
1849 (step_command_fsm::do_async_reply_reason): Rename from
1850 step_command_fsm_async_reply_reason.
1851 (struct until_next_fsm): Inherit from thread_fsm. Add
1852 constructor.
1853 (until_next_fsm_ops): Remove.
1854 (new_until_next_fsm): Remove.
1855 (until_next_fsm::should_stop): Rename from
1856 until_next_fsm_should_stop.
1857 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1858 (until_next_fsm::do_async_reply_reason): Rename from
1859 until_next_fsm_async_reply_reason.
1860 (struct finish_command_fsm): Inherit from thread_fsm. Add
1861 constructor. Change type of breakpoint.
1862 (finish_command_fsm_ops): Remove.
1863 (new_finish_command_fsm): Remove.
1864 (finish_command_fsm::should_stop): Rename from
1865 finish_command_fsm_should_stop.
1866 (finish_command_fsm::clean_up): Rename from
1867 finish_command_fsm_clean_up.
1868 (finish_command_fsm::return_value): Rename from
1869 finish_command_fsm_return_value.
1870 (finish_command_fsm::do_async_reply_reason): Rename from
1871 finish_command_fsm_async_reply_reason.
1872 (finish_command): Update.
1873 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1874 Add constructor.
1875 (call_thread_fsm_ops): Remove.
1876 (call_thread_fsm::call_thread_fsm): Rename from
1877 new_call_thread_fsm.
1878 (call_thread_fsm::should_stop): Rename from
1879 call_thread_fsm_should_stop.
1880 (call_thread_fsm::should_notify_stop): Rename from
1881 call_thread_fsm_should_notify_stop.
1882 (run_inferior_call, call_function_by_hand_dummy): Update.
1883 * cli/cli-interp.c (should_print_stop_to_console): Update.
1884 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1885 Add constructor. Change type of location_breakpoint,
1886 caller_breakpoint.
1887 (until_break_fsm_ops): Remove.
1888 (new_until_break_fsm): Remove.
1889 (until_break_fsm::should_stop): Rename from
1890 until_break_fsm_should_stop.
1891 (until_break_fsm::clean_up): Rename from
1892 until_break_fsm_clean_up.
1893 (until_break_fsm::do_async_reply_reason): Rename from
1894 until_break_fsm_async_reply_reason.
1895 (until_break_command): Update.
1896 * thread-fsm.c: Remove.
1897 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1898
1a5c2598
TT		 18992019-02-07 Tom Tromey <tom@tromey.com>
1900
1901 * yy-remap.h: Add include guard.
1902 * xtensa-tdep.h: Add include guard.
1903 * xcoffread.h: Rename include guard.
1904 * varobj-iter.h: Add include guard.
1905 * tui/tui.h: Rename include guard.
1906 * tui/tui-winsource.h: Rename include guard.
1907 * tui/tui-wingeneral.h: Rename include guard.
1908 * tui/tui-windata.h: Rename include guard.
1909 * tui/tui-win.h: Rename include guard.
1910 * tui/tui-stack.h: Rename include guard.
1911 * tui/tui-source.h: Rename include guard.
1912 * tui/tui-regs.h: Rename include guard.
1913 * tui/tui-out.h: Rename include guard.
1914 * tui/tui-layout.h: Rename include guard.
1915 * tui/tui-io.h: Rename include guard.
1916 * tui/tui-hooks.h: Rename include guard.
1917 * tui/tui-file.h: Rename include guard.
1918 * tui/tui-disasm.h: Rename include guard.
1919 * tui/tui-data.h: Rename include guard.
1920 * tui/tui-command.h: Rename include guard.
1921 * tic6x-tdep.h: Add include guard.
1922 * target/waitstatus.h: Rename include guard.
1923 * target/wait.h: Rename include guard.
1924 * target/target.h: Rename include guard.
1925 * target/resume.h: Rename include guard.
1926 * target-float.h: Rename include guard.
1927 * stabsread.h: Add include guard.
1928 * rs6000-tdep.h: Add include guard.
1929 * riscv-fbsd-tdep.h: Add include guard.
1930 * regformats/regdef.h: Rename include guard.
1931 * record.h: Rename include guard.
1932 * python/python.h: Rename include guard.
1933 * python/python-internal.h: Rename include guard.
1934 * python/py-stopevent.h: Rename include guard.
1935 * python/py-ref.h: Rename include guard.
1936 * python/py-record.h: Rename include guard.
1937 * python/py-record-full.h: Rename include guard.
1938 * python/py-record-btrace.h: Rename include guard.
1939 * python/py-instruction.h: Rename include guard.
1940 * python/py-events.h: Rename include guard.
1941 * python/py-event.h: Rename include guard.
1942 * procfs.h: Add include guard.
1943 * proc-utils.h: Add include guard.
1944 * p-lang.h: Add include guard.
1945 * or1k-tdep.h: Rename include guard.
1946 * observable.h: Rename include guard.
1947 * nto-tdep.h: Rename include guard.
1948 * nat/x86-linux.h: Rename include guard.
1949 * nat/x86-linux-dregs.h: Rename include guard.
1950 * nat/x86-gcc-cpuid.h: Add include guard.
1951 * nat/x86-dregs.h: Rename include guard.
1952 * nat/x86-cpuid.h: Rename include guard.
1953 * nat/ppc-linux.h: Rename include guard.
1954 * nat/mips-linux-watch.h: Rename include guard.
1955 * nat/linux-waitpid.h: Rename include guard.
1956 * nat/linux-ptrace.h: Rename include guard.
1957 * nat/linux-procfs.h: Rename include guard.
1958 * nat/linux-osdata.h: Rename include guard.
1959 * nat/linux-nat.h: Rename include guard.
1960 * nat/linux-namespaces.h: Rename include guard.
1961 * nat/linux-btrace.h: Rename include guard.
1962 * nat/glibc_thread_db.h: Rename include guard.
1963 * nat/gdb_thread_db.h: Rename include guard.
1964 * nat/gdb_ptrace.h: Rename include guard.
1965 * nat/fork-inferior.h: Rename include guard.
1966 * nat/amd64-linux-siginfo.h: Rename include guard.
1967 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1968 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1969 * nat/aarch64-linux.h: Rename include guard.
1970 * nat/aarch64-linux-hw-point.h: Rename include guard.
1971 * mn10300-tdep.h: Add include guard.
1972 * mips-linux-tdep.h: Add include guard.
1973 * mi/mi-parse.h: Rename include guard.
1974 * mi/mi-out.h: Rename include guard.
1975 * mi/mi-main.h: Rename include guard.
1976 * mi/mi-interp.h: Rename include guard.
1977 * mi/mi-getopt.h: Rename include guard.
1978 * mi/mi-console.h: Rename include guard.
1979 * mi/mi-common.h: Rename include guard.
1980 * mi/mi-cmds.h: Rename include guard.
1981 * mi/mi-cmd-break.h: Rename include guard.
1982 * m2-lang.h: Add include guard.
1983 * location.h: Rename include guard.
1984 * linux-record.h: Rename include guard.
1985 * linux-nat.h: Add include guard.
1986 * linux-fork.h: Add include guard.
1987 * i386-darwin-tdep.h: Rename include guard.
1988 * hppa-linux-offsets.h: Add include guard.
1989 * guile/guile.h: Rename include guard.
1990 * guile/guile-internal.h: Rename include guard.
1991 * gnu-nat.h: Rename include guard.
1992 * gdb-stabs.h: Rename include guard.
1993 * frv-tdep.h: Add include guard.
1994 * f-lang.h: Add include guard.
1995 * event-loop.h: Add include guard.
1996 * darwin-nat.h: Rename include guard.
1997 * cp-abi.h: Rename include guard.
1998 * config/sparc/nm-sol2.h: Rename include guard.
1999 * config/nm-nto.h: Rename include guard.
2000 * config/nm-linux.h: Add include guard.
2001 * config/i386/nm-i386gnu.h: Rename include guard.
2002 * config/djgpp/nl_types.h: Rename include guard.
2003 * config/djgpp/langinfo.h: Rename include guard.
2004 * compile/gcc-cp-plugin.h: Add include guard.
2005 * compile/gcc-c-plugin.h: Add include guard.
2006 * compile/compile.h: Rename include guard.
2007 * compile/compile-object-run.h: Rename include guard.
2008 * compile/compile-object-load.h: Rename include guard.
2009 * compile/compile-internal.h: Rename include guard.
2010 * compile/compile-cplus.h: Rename include guard.
2011 * compile/compile-c.h: Rename include guard.
2012 * common/xml-utils.h: Rename include guard.
2013 * common/x86-xstate.h: Rename include guard.
2014 * common/version.h: Rename include guard.
2015 * common/vec.h: Rename include guard.
2016 * common/tdesc.h: Rename include guard.
2017 * common/selftest.h: Rename include guard.
2018 * common/scoped_restore.h: Rename include guard.
2019 * common/scoped_mmap.h: Rename include guard.
2020 * common/scoped_fd.h: Rename include guard.
2021 * common/safe-iterator.h: Rename include guard.
2022 * common/run-time-clock.h: Rename include guard.
2023 * common/refcounted-object.h: Rename include guard.
2024 * common/queue.h: Rename include guard.
2025 * common/ptid.h: Rename include guard.
2026 * common/print-utils.h: Rename include guard.
2027 * common/preprocessor.h: Rename include guard.
2028 * common/pathstuff.h: Rename include guard.
2029 * common/observable.h: Rename include guard.
2030 * common/netstuff.h: Rename include guard.
2031 * common/job-control.h: Rename include guard.
2032 * common/host-defs.h: Rename include guard.
2033 * common/gdb_wait.h: Rename include guard.
2034 * common/gdb_vecs.h: Rename include guard.
2035 * common/gdb_unlinker.h: Rename include guard.
2036 * common/gdb_unique_ptr.h: Rename include guard.
2037 * common/gdb_tilde_expand.h: Rename include guard.
2038 * common/gdb_sys_time.h: Rename include guard.
2039 * common/gdb_string_view.h: Rename include guard.
2040 * common/gdb_splay_tree.h: Rename include guard.
2041 * common/gdb_setjmp.h: Rename include guard.
2042 * common/gdb_ref_ptr.h: Rename include guard.
2043 * common/gdb_optional.h: Rename include guard.
2044 * common/gdb_locale.h: Rename include guard.
2045 * common/gdb_assert.h: Rename include guard.
2046 * common/filtered-iterator.h: Rename include guard.
2047 * common/filestuff.h: Rename include guard.
2048 * common/fileio.h: Rename include guard.
2049 * common/environ.h: Rename include guard.
2050 * common/common-utils.h: Rename include guard.
2051 * common/common-types.h: Rename include guard.
2052 * common/common-regcache.h: Rename include guard.
2053 * common/common-inferior.h: Rename include guard.
2054 * common/common-gdbthread.h: Rename include guard.
2055 * common/common-exceptions.h: Rename include guard.
2056 * common/common-defs.h: Rename include guard.
2057 * common/common-debug.h: Rename include guard.
2058 * common/cleanups.h: Rename include guard.
2059 * common/buffer.h: Rename include guard.
2060 * common/btrace-common.h: Rename include guard.
2061 * common/break-common.h: Rename include guard.
2062 * cli/cli-utils.h: Rename include guard.
2063 * cli/cli-style.h: Rename include guard.
2064 * cli/cli-setshow.h: Rename include guard.
2065 * cli/cli-script.h: Rename include guard.
2066 * cli/cli-interp.h: Rename include guard.
2067 * cli/cli-decode.h: Rename include guard.
2068 * cli/cli-cmds.h: Rename include guard.
2069 * charset-list.h: Add include guard.
2070 * buildsym-legacy.h: Rename include guard.
2071 * bfin-tdep.h: Add include guard.
2072 * ax.h: Rename include guard.
2073 * arm-linux-tdep.h: Add include guard.
2074 * arm-fbsd-tdep.h: Add include guard.
2075 * arch/xtensa.h: Rename include guard.
2076 * arch/tic6x.h: Add include guard.
2077 * arch/i386.h: Add include guard.
2078 * arch/arm.h: Rename include guard.
2079 * arch/arm-linux.h: Rename include guard.
2080 * arch/arm-get-next-pcs.h: Rename include guard.
2081 * arch/amd64.h: Add include guard.
2082 * arch/aarch64-insn.h: Rename include guard.
2083 * arch-utils.h: Rename include guard.
2084 * annotate.h: Add include guard.
2085 * amd64-darwin-tdep.h: Rename include guard.
2086 * aarch64-linux-tdep.h: Add include guard.
2087 * aarch64-fbsd-tdep.h: Add include guard.
2088 * aarch32-linux-nat.h: Add include guard.
2089
ab9268d2
PW		 20902019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2091
2092 * macrotab.c (macro_define_internal): New function that
2093 factorizes macro_define_object_internal and macro_define_function
2094 code.
2095 (macro_define_object_internal): Use macro_define_internal.
2096 (macro_define_function): Likewise.
2097
bb0da2b4
PW		 20982019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2099
2100 * macrocmd.c (extract_identifier): Return
2101 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
2102 callers.
2103
424eb552
JB		 21042019-02-06 John Baldwin <jhb@FreeBSD.org>
2105
2106 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
2107
1688cb29
TT		 21082019-02-05 Tom Tromey <tom@tromey.com>
2109
2110 * target.c (target_stack::unpush): Move assertion earlier.
2111
b5eba2d8
TT		 21122019-01-30 Tom Tromey <tom@tromey.com>
2113
2114 PR python/23615:
2115 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
2116 (gdbpy_parse_and_eval): Likewise.
2117 * python/python-internal.h (gdbpy_allow_threads): New class.
2118
7054e2ff
JB		 21192019-01-28 John Baldwin <jhb@FreeBSD.org>
2120
2121 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
2122 (aarch64_fbsd_fpregmap): Move earlier.
2123 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
2124 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2125 instead of individual calls to trad_frame_set_reg_addr.
2126 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
2127 earlier.
2128 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
2129 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
2130 instead of individual calls to trad_frame_set_reg_addr.
2131
36c25ffa
AH		 21322019-01-28 Alan Hayward <alan.hayward@arm.com>
2133
2134 * CONTRIBUTE: Replace contribution list with wiki link.
2135
a0707f3c
TT		 21362019-01-25 Tom Tromey <tom@tromey.com>
2137
2138 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2139
0747795c
TT		 21402019-01-25 Tom Tromey <tom@tromey.com>
2141
2142 * xtensa-linux-nat.c: Fix common/ includes.
2143 * xml-support.h: Fix common/ includes.
2144 * xml-support.c: Fix common/ includes.
2145 * x86-linux-nat.c: Fix common/ includes.
2146 * windows-nat.c: Fix common/ includes.
2147 * varobj.h: Fix common/ includes.
2148 * varobj.c: Fix common/ includes.
2149 * value.c: Fix common/ includes.
2150 * valops.c: Fix common/ includes.
2151 * utils.c: Fix common/ includes.
2152 * unittests/xml-utils-selftests.c: Fix common/ includes.
2153 * unittests/utils-selftests.c: Fix common/ includes.
2154 * unittests/unpack-selftests.c: Fix common/ includes.
2155 * unittests/tracepoint-selftests.c: Fix common/ includes.
2156 * unittests/style-selftests.c: Fix common/ includes.
2157 * unittests/string_view-selftests.c: Fix common/ includes.
2158 * unittests/scoped_restore-selftests.c: Fix common/ includes.
2159 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2160 * unittests/scoped_fd-selftests.c: Fix common/ includes.
2161 * unittests/rsp-low-selftests.c: Fix common/ includes.
2162 * unittests/parse-connection-spec-selftests.c: Fix common/
2163 includes.
2164 * unittests/optional-selftests.c: Fix common/ includes.
2165 * unittests/offset-type-selftests.c: Fix common/ includes.
2166 * unittests/observable-selftests.c: Fix common/ includes.
2167 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2168 * unittests/memrange-selftests.c: Fix common/ includes.
2169 * unittests/memory-map-selftests.c: Fix common/ includes.
2170 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2171 * unittests/function-view-selftests.c: Fix common/ includes.
2172 * unittests/environ-selftests.c: Fix common/ includes.
2173 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2174 * unittests/common-utils-selftests.c: Fix common/ includes.
2175 * unittests/cli-utils-selftests.c: Fix common/ includes.
2176 * unittests/array-view-selftests.c: Fix common/ includes.
2177 * ui-file.c: Fix common/ includes.
2178 * tui/tui-io.c: Fix common/ includes.
2179 * tracepoint.h: Fix common/ includes.
2180 * tracepoint.c: Fix common/ includes.
2181 * tracefile-tfile.c: Fix common/ includes.
2182 * top.h: Fix common/ includes.
2183 * top.c: Fix common/ includes.
2184 * thread.c: Fix common/ includes.
2185 * target/waitstatus.h: Fix common/ includes.
2186 * target/waitstatus.c: Fix common/ includes.
2187 * target.h: Fix common/ includes.
2188 * target.c: Fix common/ includes.
2189 * target-memory.c: Fix common/ includes.
2190 * target-descriptions.c: Fix common/ includes.
2191 * symtab.h: Fix common/ includes.
2192 * symfile.c: Fix common/ includes.
2193 * stap-probe.c: Fix common/ includes.
2194 * spu-linux-nat.c: Fix common/ includes.
2195 * sparc-nat.c: Fix common/ includes.
2196 * source.c: Fix common/ includes.
2197 * solib.c: Fix common/ includes.
2198 * solib-target.c: Fix common/ includes.
2199 * ser-unix.c: Fix common/ includes.
2200 * ser-tcp.c: Fix common/ includes.
2201 * ser-pipe.c: Fix common/ includes.
2202 * ser-base.c: Fix common/ includes.
2203 * selftest-arch.c: Fix common/ includes.
2204 * s12z-tdep.c: Fix common/ includes.
2205 * rust-exp.y: Fix common/ includes.
2206 * rs6000-aix-tdep.c: Fix common/ includes.
2207 * riscv-tdep.c: Fix common/ includes.
2208 * remote.c: Fix common/ includes.
2209 * remote-notif.h: Fix common/ includes.
2210 * remote-fileio.h: Fix common/ includes.
2211 * remote-fileio.c: Fix common/ includes.
2212 * regcache.h: Fix common/ includes.
2213 * regcache.c: Fix common/ includes.
2214 * record-btrace.c: Fix common/ includes.
2215 * python/python.c: Fix common/ includes.
2216 * python/py-type.c: Fix common/ includes.
2217 * python/py-inferior.c: Fix common/ includes.
2218 * progspace.h: Fix common/ includes.
2219 * producer.c: Fix common/ includes.
2220 * procfs.c: Fix common/ includes.
2221 * proc-api.c: Fix common/ includes.
2222 * printcmd.c: Fix common/ includes.
2223 * ppc-linux-nat.c: Fix common/ includes.
2224 * parser-defs.h: Fix common/ includes.
2225 * osdata.c: Fix common/ includes.
2226 * obsd-nat.c: Fix common/ includes.
2227 * nat/x86-linux.c: Fix common/ includes.
2228 * nat/x86-linux-dregs.c: Fix common/ includes.
2229 * nat/x86-dregs.h: Fix common/ includes.
2230 * nat/x86-dregs.c: Fix common/ includes.
2231 * nat/ppc-linux.c: Fix common/ includes.
2232 * nat/mips-linux-watch.h: Fix common/ includes.
2233 * nat/mips-linux-watch.c: Fix common/ includes.
2234 * nat/linux-waitpid.c: Fix common/ includes.
2235 * nat/linux-ptrace.h: Fix common/ includes.
2236 * nat/linux-ptrace.c: Fix common/ includes.
2237 * nat/linux-procfs.c: Fix common/ includes.
2238 * nat/linux-personality.c: Fix common/ includes.
2239 * nat/linux-osdata.c: Fix common/ includes.
2240 * nat/linux-namespaces.c: Fix common/ includes.
2241 * nat/linux-btrace.h: Fix common/ includes.
2242 * nat/linux-btrace.c: Fix common/ includes.
2243 * nat/fork-inferior.c: Fix common/ includes.
2244 * nat/amd64-linux-siginfo.c: Fix common/ includes.
2245 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2246 * nat/aarch64-linux.c: Fix common/ includes.
2247 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2248 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2249 * namespace.h: Fix common/ includes.
2250 * mips-linux-tdep.c: Fix common/ includes.
2251 * minsyms.c: Fix common/ includes.
2252 * mi/mi-parse.h: Fix common/ includes.
2253 * mi/mi-main.c: Fix common/ includes.
2254 * mi/mi-cmd-env.c: Fix common/ includes.
2255 * memrange.h: Fix common/ includes.
2256 * memattr.c: Fix common/ includes.
2257 * maint.h: Fix common/ includes.
2258 * maint.c: Fix common/ includes.
2259 * main.c: Fix common/ includes.
2260 * machoread.c: Fix common/ includes.
2261 * location.c: Fix common/ includes.
2262 * linux-thread-db.c: Fix common/ includes.
2263 * linux-nat.c: Fix common/ includes.
2264 * linux-fork.c: Fix common/ includes.
2265 * inline-frame.c: Fix common/ includes.
2266 * infrun.c: Fix common/ includes.
2267 * inflow.c: Fix common/ includes.
2268 * inferior.h: Fix common/ includes.
2269 * inferior.c: Fix common/ includes.
2270 * infcmd.c: Fix common/ includes.
2271 * inf-ptrace.c: Fix common/ includes.
2272 * inf-child.c: Fix common/ includes.
2273 * ia64-linux-nat.c: Fix common/ includes.
2274 * i387-tdep.c: Fix common/ includes.
2275 * i386-tdep.c: Fix common/ includes.
2276 * i386-linux-tdep.c: Fix common/ includes.
2277 * i386-linux-nat.c: Fix common/ includes.
2278 * i386-go32-tdep.c: Fix common/ includes.
2279 * i386-fbsd-tdep.c: Fix common/ includes.
2280 * i386-fbsd-nat.c: Fix common/ includes.
2281 * guile/scm-type.c: Fix common/ includes.
2282 * guile/guile.c: Fix common/ includes.
2283 * go32-nat.c: Fix common/ includes.
2284 * gnu-nat.c: Fix common/ includes.
2285 * gdbthread.h: Fix common/ includes.
2286 * gdbarch-selftests.c: Fix common/ includes.
2287 * gdb_usleep.c: Fix common/ includes.
2288 * gdb_select.h: Fix common/ includes.
2289 * gdb_bfd.c: Fix common/ includes.
2290 * gcore.c: Fix common/ includes.
2291 * fork-child.c: Fix common/ includes.
2292 * findvar.c: Fix common/ includes.
2293 * fbsd-nat.c: Fix common/ includes.
2294 * event-top.c: Fix common/ includes.
2295 * event-loop.c: Fix common/ includes.
2296 * dwarf2read.c: Fix common/ includes.
2297 * dwarf2loc.c: Fix common/ includes.
2298 * dwarf2-frame.c: Fix common/ includes.
2299 * dwarf-index-cache.c: Fix common/ includes.
2300 * dtrace-probe.c: Fix common/ includes.
2301 * disasm-selftests.c: Fix common/ includes.
2302 * defs.h: Fix common/ includes.
2303 * csky-tdep.c: Fix common/ includes.
2304 * cp-valprint.c: Fix common/ includes.
2305 * cp-support.h: Fix common/ includes.
2306 * cp-support.c: Fix common/ includes.
2307 * corelow.c: Fix common/ includes.
2308 * completer.h: Fix common/ includes.
2309 * completer.c: Fix common/ includes.
2310 * compile/compile.c: Fix common/ includes.
2311 * compile/compile-loc2c.c: Fix common/ includes.
2312 * compile/compile-cplus-types.c: Fix common/ includes.
2313 * compile/compile-cplus-symbols.c: Fix common/ includes.
2314 * command.h: Fix common/ includes.
2315 * cli/cli-dump.c: Fix common/ includes.
2316 * cli/cli-cmds.c: Fix common/ includes.
2317 * charset.c: Fix common/ includes.
2318 * build-id.c: Fix common/ includes.
2319 * btrace.h: Fix common/ includes.
2320 * btrace.c: Fix common/ includes.
2321 * breakpoint.h: Fix common/ includes.
2322 * breakpoint.c: Fix common/ includes.
2323 * ax.h:
2324 (enum agent_op): Fix common/ includes.
2325 * ax-general.c (struct aop_map): Fix common/ includes.
2326 * ax-gdb.c: Fix common/ includes.
2327 * auxv.c: Fix common/ includes.
2328 * auto-load.c: Fix common/ includes.
2329 * arm-tdep.c: Fix common/ includes.
2330 * arch/riscv.c: Fix common/ includes.
2331 * arch/ppc-linux-common.c: Fix common/ includes.
2332 * arch/i386.c: Fix common/ includes.
2333 * arch/arm.c: Fix common/ includes.
2334 * arch/arm-linux.c: Fix common/ includes.
2335 * arch/arm-get-next-pcs.c: Fix common/ includes.
2336 * arch/amd64.c: Fix common/ includes.
2337 * arch/aarch64.c: Fix common/ includes.
2338 * arch/aarch64-insn.c: Fix common/ includes.
2339 * arch-utils.c: Fix common/ includes.
2340 * amd64-windows-tdep.c: Fix common/ includes.
2341 * amd64-tdep.c: Fix common/ includes.
2342 * amd64-sol2-tdep.c: Fix common/ includes.
2343 * amd64-obsd-tdep.c: Fix common/ includes.
2344 * amd64-nbsd-tdep.c: Fix common/ includes.
2345 * amd64-linux-tdep.c: Fix common/ includes.
2346 * amd64-linux-nat.c: Fix common/ includes.
2347 * amd64-fbsd-tdep.c: Fix common/ includes.
2348 * amd64-fbsd-nat.c: Fix common/ includes.
2349 * amd64-dicos-tdep.c: Fix common/ includes.
2350 * amd64-darwin-tdep.c: Fix common/ includes.
2351 * agent.c: Fix common/ includes.
2352 * ada-lang.h: Fix common/ includes.
2353 * ada-lang.c: Fix common/ includes.
2354 * aarch64-tdep.c: Fix common/ includes.
2355
2f5c153e
TT		 23562019-01-25 Tom Tromey <tom@tromey.com>
2357
2358 * common/create-version.sh: Use common/version.h.
2359
adc6a863
PA		 23602019-01-24 Pedro Alves <palves@redhat.com>
2361
2362 * infrun.c (signal_stop, signal_print, signal_program)
2363 (signal_catch, signal_pass): Now arrays instead of pointers.
2364 (update_signals_program_target, do_target_resume)
2365 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2366 * linux-nat.c (linux_nat_target::pass_signals)
2367 (linux_nat_target::create_inferior, linux_nat_target::attach):
2368 Adjust.
2369 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2370 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2371 * procfs.c (procfs_target::pass_signals): Adjust.
2372 * record-full.c (record_full_target::resume): Adjust.
2373 * remote.c (remote_target::pass_signals)
2374 (remote_target::program_signals): Adjust.
2375 * target-debug.h (target_debug_print_signals): Now takes a
2376 gdb::array_view as parameter. Adjust.
2377 * target.h (target_ops) <pass_signals, program_signals>: Replace
2378 pointer and length parameters with gdb::array_view.
2379 (target_pass_signals, target_program_signals): Likewise.
2380 * target-delegates.c: Regenerate.
2381
3046d67a
PA		 23822019-01-24 Pedro Alves <palves@redhat.com>
2383
2384 * common/forward-scope-exit.h
2385 (forward_scope_exit::forward_scope_exit): Pass arguments to
2386 m_bind_function directly, instead of creating a std::bind and
2387 copying that.
2388
353229bf
AH		 23892019-01-24 Alan Hayward <alan.hayward@arm.com>
2390
2391 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2392 for static members.
2393 (pass_in_v_vfp_candidate): Likewise.
2394
311dc83a
TT		 23952019-01-23 Tom Tromey <tom@tromey.com>
2396 Pedro Alves <palves@redhat.com>
2397
2398 * regcache.c (class regcache_invalidator): Remove.
2399 (regcache::raw_write): Use make_scope_exit.
2400
296bd123
TT		 24012019-01-23 Tom Tromey <tom@tromey.com>
2402
2403 * ui-out.h (class ui_out_emit_type): Update comment.
2404
979a0d13
TT		 24052019-01-23 Tom Tromey <tom@tromey.com>
2406
2407 * infrun.c (fetch_inferior_event): Update comment.
2408
d238133d
TT		 24092019-01-23 Tom Tromey <tom@tromey.com>
2410 Pedro Alves <palves@redhat.com>
2411
2412 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2413 parameter.
2414 (fetch_inferior_event): Use SCOPE_EXIT.
2415
2416
9885e6bb
TT		 24172019-01-23 Tom Tromey <tom@tromey.com>
2418 Pedro Alves <palves@redhat.com>
2419
2420 * infrun.c (disable_thread_events): Delete.
2421 (stop_all_threads): Use SCOPE_EXIT.
2422
286526c1
TT		 24232019-01-23 Tom Tromey <tom@tromey.com>
2424 Pedro Alves <palves@redhat.com>
2425
2426 * symfile.c: Include forward-scope-exit.h.
2427 (clear_symtab_users_cleanup): Replace forward declaration with
2428 a FORWARD_SCOPE_EXIT.
2429 (syms_from_objfile_1): Use the forward_scope_exit and
2430 gdb::optional instead of cleanup_function.
2431 (reread_symbols): Use the forward_scope_exit instead of
2432 cleanup_function.
2433 (clear_symtab_users_cleanup): Remove function.
2434
1db93f14
TT		 24352019-01-23 Tom Tromey <tom@tromey.com>
2436 Pedro Alves <palves@redhat.com>
2437
2438 * linux-nat.c: Include scope-exit.h.
2439 (cleanup_target_stop): Remove.
2440 (linux_nat_target::static_tracepoint_markers_by_strid): Use
2441 SCOPE_EXIT.
2442
2cc83d1e
TT		 24432019-01-23 Tom Tromey <tom@tromey.com>
2444 Pedro Alves <palves@redhat.com>
2445
2446 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2447 (call_function_by_hand_dummy): Use SCOPE_EXIT.
2448
694c6bf5
TT		 24492019-01-23 Tom Tromey <tom@tromey.com>
2450 Andrew Burgess <andrew.burgess@embecosm.com>
2451 Pedro Alves <palves@redhat.com>
2452
2453 * infrun.c (fetch_inferior_event): Use scope_exit.
2454 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2455 * top.c (execute_command): Use scope_exit.
2456 * breakpoint.c (bpstat_do_actions): Use scope_exit.
2457 * utils.c (do_bpstat_clear_actions_cleanup)
2458 (make_bpstat_clear_actions_cleanup): Remove.
2459
4c41382a
TT		 24602019-01-23 Tom Tromey <tom@tromey.com>
2461 Pedro Alves <palves@redhat.com>
2462
2463 * infrun.c: Include "common/scope-exit.h"
2464 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2465 (wait_for_inferior): Use SCOPE_EXIT.
2466 (fetch_inferior_event): Use scope_exit.
2467
89f8fb50
TT		 24682019-01-23 Tom Tromey <tom@tromey.com>
2469 Pedro Alves <palves@redhat.com>
2470
2471 * breakpoint.c (create_breakpoint): Remove cleanup.
2472
5419bdae
TT		 24732019-01-23 Tom Tromey <tom@tromey.com>
2474 Andrew Burgess <andrew.burgess@embecosm.com>
2475 Pedro Alves <palves@redhat.com>
2476
e587ef42
PA		 24772019-01-23 Pedro Alves <palves@redhat.com>
2478
2479 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2480
77f0e74c
PA		 24812019-01-23 Pedro Alves <palves@redhat.com>
2482 Andrew Burgess <andrew.burgess@embecosm.com>
2483
2484 * gdbthread.h: Include "common/forward-scope-exit.h".
2485 (scoped_finish_thread_state): Redefine custom class in terms of
2486 forward_scope_exit.
2487
5b9b3e53
PA		 24882019-01-23 Pedro Alves <palves@redhat.com>
2489 Andrew Burgess <andrew.burgess@embecosm.com>
2490
2491 * common/forward-scope-exit.h: New file.
2492
54b65c9b
PA		 24932019-01-23 Pedro Alves <palves@redhat.com>
2494 Andrew Burgess <andrew.burgess@embecosm.com>
2495 Tom Tromey <tom@tromey.com>
2496
2497 * common/scope-exit.h: New file.
2498
cf08fb29
PA		 24992019-01-23 Pedro Alves <palves@redhat.com>
2500
2501 * common/preprocessor.h (ESC): Rename to ...
2502 (ESC_PARENS): ... this.
2503 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2504 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2505
ae73e2e2
TT		 25062019-01-23 Tom Tromey <tom@tromey.com>
2507
2508 * language.h (class scoped_switch_to_sym_language_if_auto):
2509 Initialize m_lang in both cases.
2510
6594e122
AH		 25112019-01-23 Alan Hayward <alan.hayward@arm.com>
2512
2513 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2514 with XCNEW.
2515
a7c9855d
TT		 25162019-01-22 Tom Tromey <tom@tromey.com>
2517
2518 * corelow.c: Do not include sys/file.h.
2519
93cc1d53
TT		 25202019-01-22 Tom Tromey <tom@tromey.com>
2521
2522 * tui/tui-wingeneral.h: Include gdb_curses.h.
2523
38561778
TT		 25242019-01-22 Tom Tromey <tom@tromey.com>
2525
2526 * source-cache.h (class source_cache) <get_source_lines,
2527 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2528
37b3ab5b
TT		 25292019-01-22 Tom Tromey <tom@tromey.com>
2530
2531 * remote-fileio.h (struct remote_target): Declare.
2532
3fabc016
TT		 25332019-01-22 Tom Tromey <tom@tromey.com>
2534
2535 * python/py-arch.c: Do not include py-ref.h.
2536 * python/py-bpevent.c: Do not include py-ref.h.
2537 * python/py-cmd.c: Do not include py-ref.h.
2538 * python/py-continueevent.c: Do not include py-ref.h.
2539 * python/py-event.h: Do not include py-ref.h.
2540 * python/py-evtregistry.c: Do not include py-ref.h.
2541 * python/py-finishbreakpoint.c: Do not include py-ref.h.
2542 * python/py-frame.c: Do not include py-ref.h.
2543 * python/py-framefilter.c: Do not include py-ref.h.
2544 * python/py-function.c: Do not include py-ref.h.
2545 * python/py-infevents.c: Do not include py-ref.h.
2546 * python/py-linetable.c: Do not include py-ref.h.
2547 * python/py-objfile.c: Do not include py-ref.h.
2548 * python/py-param.c: Do not include py-ref.h.
2549 * python/py-prettyprint.c: Do not include py-ref.h.
2550 * python/py-progspace.c: Do not include py-ref.h.
2551 * python/py-symbol.c: Do not include py-ref.h.
2552 * python/py-symtab.c: Do not include py-ref.h.
2553 * python/py-type.c: Do not include py-ref.h.
2554 * python/py-unwind.c: Do not include py-ref.h.
2555 * python/py-utils.c: Do not include py-ref.h.
2556 * python/py-value.c: Do not include py-ref.h.
2557 * python/py-varobj.c: Do not include py-ref.h.
2558 * python/py-xmethods.c: Do not include py-ref.h.
2559 * python/python.c: Do not include py-ref.h.
2560 * varobj.c: Do not include py-ref.h.
2561
6b4d7774
TT		 25622019-01-22 Tom Tromey <tom@tromey.com>
2563
2564 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2565 keyword for bcache.
2566
7af7e9b5
TT		 25672019-01-22 Tom Tromey <tom@tromey.com>
2568
2569 * compile/compile-cplus-types.c: Remove a comment by #include.
2570
951d1049
TT		 25712019-01-22 Tom Tromey <tom@tromey.com>
2572
2573 * compile/gcc-c-plugin.h: Include compile-internal.h.
2574
d65d5705
TT		 25752019-01-22 Tom Tromey <tom@tromey.com>
2576
2577 * stabsread.c (EXTERN): Do not define.
2578 (symnum, next_symbol_text_func, processing_gcc_compilation)
2579 (within_function, global_sym_chain, global_stabs)
2580 (previous_stab_code, this_object_header_files)
2581 (n_this_object_header_files)
2582 (n_allocated_this_object_header_files): Define.
2583 * stabsread.h (EXTERN): Never define. Use "extern".
2584
b6fb1ee5
PW		 25852019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2586
2587 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2588 history_value.
2589
be6d4f74
TT		 25902019-01-21 Tom Tromey <tom@tromey.com>
2591
2592 * ui-out.c: Fix includes.
2593 * tui/tui-source.c: Fix includes.
2594 * target.c: Fix includes.
2595 * remote.c: Fix includes.
2596 * regcache.c: Fix includes.
2597 * python/py-block.c: Fix includes.
2598 * printcmd.c: Fix includes.
2599 * or1k-tdep.c: Fix includes.
2600 * mi/mi-main.c: Fix includes.
2601 * m32r-tdep.c: Fix includes.
2602 * csky-tdep.c: Fix includes.
2603 * compile/compile-cplus-types.c: Fix includes.
2604 * cli/cli-interp.c: Fix includes.
2605
73021deb
AH		 26062019-01-21 Alan Hayward <alan.hayward@arm.com>
2607
2608 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2609 for padding.
2610
7932255d
TT		 26112019-01-16 Tom Tromey <tom@tromey.com>
2612
2613 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
2614 earlier.
2615 (struct objfile) <msymbols_range>: Move from top level.
2616 <msymbols>: New method.
2617 (class objfile_msymbols): Remove.
2618 * symtab.c (default_collect_symbol_completion_matches_break_on):
2619 Update.
2620 * symmisc.c (dump_msymbols): Update.
2621 * stabsread.c (scan_file_globals): Update.
2622 * objc-lang.c (info_selectors_command, info_classes_command)
2623 (find_methods): Update.
2624 * minsyms.c (find_solib_trampoline_target): Update.
2625 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2626 * coffread.c (coff_symfile_read): Update.
2627 * ada-lang.c (ada_lookup_simple_minsym)
2628 (ada_collect_symbol_completion_matches): Update.
2629
604b1bfb
TT		 26302019-01-16 Tom Tromey <tom@tromey.com>
2631
2632 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2633 type. Remove no-argument constructor.
2634 <iterator::operator++>: Simplify.
2635 <begin>: Update.
2636 <end>: Use minimal_symbol_count.
2637
f252c6d5
TT		 26382019-01-16 Tom Tromey <tom@tromey.com>
2639
2640 * objfiles.h (struct objfile) <psymtabs>: New method.
2641 (class objfile_psymtabs): Remove.
2642 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2643 typedef.
2644 <range>: New method.
2645 (require_partial_symbols): Change return type.
2646 * psymtab.c (require_partial_symbols)
2647 (psym_expand_symtabs_matching): Update.
2648 * mdebugread.c (parse_partial_symbols): Update.
2649 * dbxread.c (dbx_end_psymtab): Update.
2650
b669c953
TT		 26512019-01-15 Tom Tromey <tom@tromey.com>
2652
2653 * symtab.c (lookup_objfile_from_block)
2654 (lookup_symbol_in_objfile_symtabs)
2655 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2656 (find_line_symtab, info_sources_command)
2657 (default_collect_symbol_completion_matches_break_on)
2658 (make_source_files_completion_list): Update.
2659 * symmisc.c (print_objfile_statistics, dump_objfile)
2660 (maintenance_print_symbols, maintenance_info_symtabs)
2661 (maintenance_check_symtabs, maintenance_info_line_tables):
2662 Update.
2663 * source.c (select_source_symtab)
2664 (forget_cached_source_info_for_objfile): Update.
2665 * objfiles.h (class objfile_compunits): Remove.
2666 (struct objfile) <compunits_range>: New typedef.
2667 (compunits): New method.
2668 * objfiles.c (objfile_relocate1): Update.
2669 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2670 * maint.c (count_symtabs_and_blocks): Update.
2671 * linespec.c (iterate_over_all_matching_symtabs): Update.
2672 * cp-support.c (add_symbol_overload_list_qualified): Update.
2673 * coffread.c (coff_symtab_read): Update.
2674 * ada-lang.c (add_nonlocal_symbols)
2675 (ada_collect_symbol_completion_matches)
2676 (ada_add_global_exceptions): Update.
2677
7e955d83
TT		 26782019-01-15 Tom Tromey <tom@tromey.com>
2679
2680 * progspace.h (program_space) <objfiles_safe_range>: New
2681 typedef.
2682 <objfiles_safe>: New method.
2683 * objfiles.h (class all_objfiles_safe): Remove.
2684 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2685 * jit.c (jit_inferior_exit_hook): Update.
2686
2030c079
TT		 26872019-01-17 Tom Tromey <tom@tromey.com>
2688
2689 * progspace.h (program_space) <objfiles_range>: New typedef.
2690 <objfiles>: New method.
2691 <objfiles_head>: Rename from objfiles.
2692 (object_files): Update.
2693 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2694 * guile/scm-pretty-print.c
2695 (ppscm_find_pretty_printer_from_objfiles): Update.
2696 * guile/scm-objfile.c (gdbscm_objfiles): Update.
2697 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2698 Update.
2699 * python/py-progspace.c (pspy_get_objfiles): Update.
2700 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2701 Update.
2702 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2703 (objfpy_lookup_objfile_by_build_id): Update.
2704 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2705 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2706 Update.
2707 * symtab.c (iterate_over_symtabs, matching_obj_sections)
2708 (expand_symtab_containing_pc, lookup_objfile_from_block)
2709 (lookup_static_symbol, basic_lookup_transparent_type)
2710 (find_pc_sect_compunit_symtab, find_symbol_at_address)
2711 (find_line_symtab, info_sources_command)
2712 (default_collect_symbol_completion_matches_break_on)
2713 (make_source_files_completion_list, find_main_name): Update.
2714 * symmisc.c (print_symbol_bcache_statistics)
2715 (print_objfile_statistics, maintenance_print_symbols)
2716 (maintenance_print_msymbols, maintenance_print_objfiles)
2717 (maintenance_info_symtabs, maintenance_check_symtabs)
2718 (maintenance_expand_symtabs, maintenance_info_line_tables):
2719 Update.
2720 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2721 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2722 (map_overlay_command, unmap_overlay_command)
2723 (simple_overlay_update, expand_symtabs_matching)
2724 (map_symbol_filenames): Update.
2725 * symfile-debug.c (set_debug_symfile): Update.
2726 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2727 Update.
2728 * source.c (select_source_symtab, forget_cached_source_info):
2729 Update.
2730 * solib.c (solib_read_symbols): Update.
2731 * solib-spu.c (append_ocl_sos): Update.
2732 * psymtab.c (maintenance_print_psymbols)
2733 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2734 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2735 * printcmd.c (info_symbol_command): Update.
2736 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2737 Update.
2738 * objfiles.h (class all_objfiles): Remove.
2739 * objfiles.c (have_partial_symbols, have_full_symbols)
2740 (have_minimal_symbols, qsort_cmp, update_section_map)
2741 (shared_objfile_contains_address_p)
2742 (default_iterate_over_objfiles_in_search_order): Update.
2743 * objc-lang.c (info_selectors_command, info_classes_command)
2744 (find_methods): Update.
2745 * minsyms.c (find_solib_trampoline_target): Update.
2746 * maint.c (maintenance_info_sections)
2747 (maintenance_translate_address, count_symtabs_and_blocks):
2748 Update.
2749 * main.c (captured_main_1): Update.
2750 * linux-thread-db.c (try_thread_db_load_from_pdir)
2751 (has_libpthread): Update.
2752 * linespec.c (iterate_over_all_matching_symtabs)
2753 (search_minsyms_for_name): Update.
2754 * jit.c (jit_find_objf_with_entry_addr): Update.
2755 * hppa-tdep.c (find_unwind_entry)
2756 (hppa_lookup_stub_minimal_symbol): Update.
2757 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2758 Update.
2759 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2760 (elf_gnu_ifunc_resolve_by_got): Update.
2761 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2762 * dwarf-index-write.c (save_gdb_index_command): Update.
2763 * cp-support.c (add_symbol_overload_list_qualified): Update.
2764 * breakpoint.c (create_overlay_event_breakpoint)
2765 (create_longjmp_master_breakpoint)
2766 (create_std_terminate_master_breakpoint)
2767 (create_exception_master_breakpoint): Update.
2768 * blockframe.c (find_pc_partial_function): Update.
2769 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2770 (ada_collect_symbol_completion_matches)
2771 (ada_add_global_exceptions): Update.
2772
776489e0
TT		 27732019-01-17 Tom Tromey <tom@tromey.com>
2774
2775 * solib-target.c (lm_info_target_p): Remove typedef. Don't
2776 declare VEC.
2777 (solib_target_parse_libraries): Change return type.
2778 (library_list_start_segment, library_list_start_section)
2779 (library_list_end_library, library_list_start_library); Update.
2780 (solib_target_free_library_list): Remove.
2781 (solib_target_parse_libraries): Remove cleanup. Change return
2782 type.
2783 (solib_target_current_sos): Update.
2784
6471e7d2
TT		 27852019-01-17 Tom Tromey <tromey@bapiya>
2786
2787 * valprint.c: Replace "the the" with "the".
2788 * symtab.c: Replace "the the" with "the".
2789 * solib.c: Replace "the the" with "the".
2790 * solib-dsbt.c: Replace "the the" with "the".
2791 * linespec.c: Replace "the the" with "the".
2792 * dwarf2loc.h: Replace "the the" with "the".
2793 * amd64-windows-tdep.c: Replace "the the" with "the".
2794 * aarch64-tdep.c: Replace "the the" with "the".
2795
c24bdb02
KS		 27962019-01-16 Keith Seitz <keiths@redhat.com>
2797
2798 PR gdb/23773
2799 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2800 <builder>: Rename to ..
2801 <m_builder>: ... this and make private.
2802 (dwarf2_cu::get_builder): New method. Change all users of
2803 `builder' to use this method.
2804 (dwarf2_start_symtab): Move to ...
2805 (dwarf2_cu::start_symtab): ... here. Update all callers
2806 (setup_type_unit_groups): Move to ...
2807 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
2808 callers.
2809 (dwarf2_cu::reset_builder): New method.
2810 (process_full_compunit, process_full_type_unit): Use
2811 dwarf2_cu::reset_builder.
2812 (follow_die_offset): Record the ancestor CU if it is different
2813 from the followed DIE's CU.
2814 (follow_die_sig_1): Likewise.
2815
8d64371b
TT		 28162019-01-15 Tom Tromey <tom@tromey.com>
2817
2818 * remote.c (class remote_state) <buf>: Now a char_vector.
2819 <buf_size>: Remove.
2820 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
2821 parameter.
2822 (remote_target::getpkt_or_notif_sane_1)
2823 (remote_target::getpkt_sane)
2824 (remote_target::getpkt_or_notif_sane): Likewise.
2825 (class remote_target) <putpkt>: New overload.
2826 (remote_target::read_frame): Change type of "buf_p". Remove
2827 sizeof_p parameter.
2828 (packet_ok): New overload.
2829 (packet_check_result): New overload.
2830 Update all uses.
2831
bb277751
TT		 28322019-01-14 Tom Tromey <tom@tromey.com>
2833
2834 * remote-notif.c (handle_notification, remote_notif_ack)
2835 (remote_notif_parse): Make "buf" const.
2836 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2837 const.
2838 (remote_notif_parse, remote_notif_ack, handle_notification):
2839 Likewise.
2840 * remote.c (remote_notif_stop_parse): Make "buf" const.
2841 (remote_target::remote_parse_stop_reply): Make "buf" const.
2842 (remote_notif_stop_ack): Make "buf" const.
2843
05be00a8
TT		 28442019-01-14 Tom Tromey <tom@tromey.com>
2845
2846 * remote.c (remote_console_output): Make parameter const.
2847
491adeca
TT		 28482019-01-14 Tom Tromey <tom@tromey.com>
2849
2850 * target-debug.h (target_debug_print_signals): Constify.
2851 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2852 * procfs.c (procfs_target::pass_signals): Update.
2853 * linux-nat.c (linux_nat_target::pass_signals): Update.
2854 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2855 * target-delegates.c: Rebuild.
2856 * remote.c (remote_target::program_signals): Update.
2857 (remote_target::pass_signals): Update.
2858 * target.c (target_pass_signals): Constify argument.
2859 (target_program_signals): Likewise.
2860 * target.h (struct target_ops) <pass_signals, program_signals>:
2861 Constify argument.
2862 (target_pass_signals, target_program_signals): Constify argument.
2863
bbd94648
TT		 28642019-01-14 Tom Tromey <tom@tromey.com>
2865
2866 PR tui/28819:
2867 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2868
6f072a10
PFC		 28692019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
2870
2871 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2872 field.
2873 * rs6000-tdep.c: Include reggroups.h.
2874 (IS_V_ALIAS_PSEUDOREG): Define.
2875 (rs6000_register_name): Return names for the "vX" aliases.
2876 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2877 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
2878 aliases. Call default_register_reggroup_p for all other
2879 pseudo-registers.
2880 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2881 New functions.
2882 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2883 Handle "vX" aliases.
2884 (v_alias_pseudo_register_collect): New function.
2885 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2886 (rs6000_gdbarch_init): Initialize "vX" aliases as
2887 pseudo-registers. Restore registration of
2888 rs6000_pseudo_register_reggroup_p with
2889 set_tdesc_pseudo_register_reggroup_p.
2890
1a782351
MF		 28912019-01-13 Max Filippov <jcmvbkbc@gmail.com>
2892
2893 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2894 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2895 set_gdbarch_num_pseudo_regs.
2896
d73cff18
PW		 28972019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2898
2899 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2900 Remove arg prefixname, add do_set and do_show.
2901 Add member functions set_list and show_list.
2902 * cli/cli-style.c (class cli_style_option): Update accordingly.
2903 (style_set_list): Move to file scope.
2904 (style_show_list): Likewise.
2905 (set_style): Call help_list.
2906 (show_style): Call cmd_show_list.
2907 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2908 Update to use the new macro.
2909
60a90376
JB		 29102019-10-12 Joel Brobecker <brobecker@adacore.com>
2911
2912 * ada-lang.c (_initialize_ada_language): Expand the help text
2913 for the "catch exception" command.
2914
9d7c67bf
PW		 29152019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2916
2917 * symtab.c (matching_obj_sections): Initialize obj,
2918 declare it closer to its usage.
2919
7cf47dc4
TT		 29202019-01-10 Tom Tromey <tom@tromey.com>
2921
2922 * thread-iter.h (inf_threads_iterator): Use next_iterator.
2923 (basic_inf_threads_range): Remove.
2924 (inf_threads_range, inf_non_exited_threads_range)
2925 (safe_inf_threads_range): Use next_adapter.
2926
d3cb6808
KS		 29272019-01-10 Keith Seitz <keiths@redhat.com>
2928
2929 PR gdb/23712
2930 PR symtab/23010
2931 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2932 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2933
63a20375
KS		 29342019-01-10 Keith Seitz <keiths@redhat.com>
2935
2936 PR gdb/23712
2937 PR symtab/23010
2938 * dictionary.c (pending_to_vector): Remove.
2939 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2940 Remove _1 suffix, replacing functions of the same name. Update
2941 all callers.
2942 (dict_create_hashed, dict_create_hashed_expandable)
2943 (dict_create_linear, dict_create_linear_expandable, dict_free)
2944 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2945 Make functions static.
2946
b026f593
KS		 29472019-01-10 Keith Seitz <keiths@redhat.com>
2948
2949 PR gdb/23712
2950 PR symtab/23010
2951 * dictionary.h (struct dictionary): Replace declaration with
2952 multidictionary.
2953 (dict_create_hashed, dict_create_hashed_expandable)
2954 (dict_create_linear, dict_create_linear_expandable)
2955 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2956 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2957 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2958 taking multidictionary argument.
2959 [ALL_DICT_SYMBOLS]: Update for multidictionary.
2960 * block.h (struct block) <dict>: Change to multidictionary
2961 and rename `multidict'.
2962 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2963 symmisc.c: Update all dictionary references to multidictionary.
2964
c7748ee9
KS		 29652019-01-10 Keith Seitz <keiths@redhat.com>
2966
2967 PR gdb/23712
2968 PR symtab/23010
2969 * dictionary.c: Include unordered_map.
2970 (pending_to_vector): New function.
2971 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2972 Rewrite the non-"_1" functions to take vector instead
2973 of linked list.
2974 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2975 "new" _1 versions of the same name.
2976 (multidictionary): Define.
2977 (std::hash<enum language): New definition.
2978 (collate_pending_symbols_by_language, mdict_create_hashed)
2979 (mdict_create_hashed_expandable, mdict_create_linear)
2980 (mdict_create_linear_expandable, mdict_free)
2981 (find_language_dictionary, create_new_language_dictionary)
2982 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2983 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2984 (mdict_size, mdict_empty): New functions.
2985 * dictionary.h (mdict_iterator): Define.
2986
67aa1f3c
PA		 29872019-01-10 Pedro Alves <palves@redhat.com>
2988
2989 * breakpoint.c (read_uploaded_action)
2990 (create_tracepoint_from_upload): Adjust to use
2991 gdb::unique_xmalloc_ptr.
2992 * ctf.c (ctf_write_uploaded_tp):
2993 (SET_ARRAY_FIELD): Use emplace_back.
2994 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2995 * tracefile-tfile.c (tfile_write_uploaded_tp):
2996 * tracepoint.c (parse_tracepoint_definition): Adjust to use
2997 gdb::unique_xmalloc_ptr.
2998 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2999 at_string, cond_string, cmd_strings>: Replace char pointers
3000 with gdb::unique_xmalloc_ptr.
3001
2f667667
PA		 30022019-01-10 Pedro Alves <palves@redhat.com>
3003
3004 * solib-target.c (library_list_start_library): Don't xstrdup name.
3005
36cb7237
PA		 30062019-01-10 Pedro Alves <palves@redhat.com>
3007
3008 * mdebugread.c (parse_partial_symbols): Use
3009 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
3010
da584958
AB		 30112019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
3012
3013 * linux-fork.c (scoped_switch_fork_info)
3014 <~scoped_switch_fork_info>: Fix incorrect variable name.
3015
1ef8573c
AB		 30162019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
3017
3018 * linux-fork.c (scoped_switch_fork_info)
3019 <scoped_switch_fork_info>: Make explicit.
3020 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
3021
8d7bcccb
TT		 30222019-01-10 Tom Tromey <tom@tromey.com>
3023
3024 * objfiles.h (objfile::reset_psymtabs): Update.
3025 * objfiles.c (objfile::objfile): Update.
3026 * psymtab.h (psymtab_storage::obstack): Update.
3027 (psymtab_storage::m_obstack): Use gdb::optional.
3028 (class psymtab_storage): Update comment. Remove objfile
3029 parameter.
3030 * psymtab.c (psymtab_storage::psymtab_storage): Update.
3031
b596a3c7
TT		 30322019-01-10 Tom Tromey <tom@tromey.com>
3033
3034 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
3035 <free_psymtabs>: Now private.
3036 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
3037 (allocate_psymtab): Use new method.
3038
a9342b62
TT		 30392019-01-10 Tom Tromey <tom@tromey.com>
3040
3041 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
3042 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
3043 * mdebugread.c (parse_partial_symbols): Use
3044 allocate_dependencies.
3045 * dwarf2read.c (dwarf2_create_include_psymtab): Use
3046 allocate_dependencies.
3047 (process_psymtab_comp_unit_reader)
3048 (build_type_psymtab_dependencies): Likewise.
3049 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
3050
5af70966
TT		 30512019-01-10 Tom Tromey <tom@tromey.com>
3052
3053 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
3054 PSYMBOL_SET_LANGUAGE.
3055 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
3056
5923a04c
TT		 30572019-01-10 Tom Tromey <tom@tromey.com>
3058
3059 * psymtab.h (psymtab_storage::obstack): New method.
3060 <m_obstack>: Rename from obstack; now private.
3061 * psymtab.c (psymtab_storage): Update.
3062 * dwarf2read.c (create_addrmap_from_index)
3063 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
3064 Update.
3065
6d6a12bf
TT		 30662019-01-10 Tom Tromey <tom@tromey.com>
3067
3068 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
3069 * objfiles.h (objfile::reset_psymtabs): New method.
3070
d320c2b5
TT		 30712019-01-10 Tom Tromey <tom@tromey.com>
3072
3073 * symmisc.c (print_symbol_bcache_statistics): Update.
3074 (print_objfile_statistics): Update.
3075 * symfile.c (reread_symbols): Update.
3076 * psymtab.h (class psymtab_storage): New.
3077 * psymtab.c (psymtab_storage): New constructor.
3078 (~psymtab_storage): New destructor.
3079 (require_partial_symbols): Update.
3080 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
3081 (find_pc_sect_psymtab, find_pc_sect_psymbol)
3082 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
3083 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
3084 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
3085 (start_psymtab_common, end_psymtab_common)
3086 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
3087 (allocate_psymtab): Update.
3088 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
3089 Update.
3090 (dump_psymtab_addrmap, maintenance_print_psymbols)
3091 (maintenance_check_psymtabs): Update.
3092 (class objfile_psymtabs): Move to objfiles.h.
3093 * psympriv.h (discard_psymtab): Now inline.
3094 (psymtab_discarder::psymtab_discarder): Update.
3095 (psymtab_discarder::~psymtab_discarder): Update.
3096 (ALL_OBJFILE_PSYMTABS): Rewrite.
3097 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
3098 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
3099 Remove fields.
3100 <partial_symtabs>: New field.
3101 (class objfile_psymtabs): Move from psymtab.h. Update.
3102 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
3103 psymbol_cache.
3104 (objfile::~objfile): Don't destroy psymbol_cache.
3105 * mdebugread.c (parse_partial_symbols): Update.
3106 * dwarf2read.c (create_addrmap_from_index)
3107 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3108 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
3109 (add_partial_subprogram, dwarf2_ranges_read): Update.
3110 * dwarf-index-write.c (write_address_map)
3111 (write_one_signatured_type, recursively_write_psymbols)
3112 (class debug_names, class debug_names, write_psymtabs_to_index):
3113 Update.
3114
1d94a5a3
TT		 31152019-01-10 Tom Tromey <tom@tromey.com>
3116
3117 * symtab.h (SYMBOL_SET_NAMES): Update.
3118 (symbol_set_names): Update.
3119 (MSYMBOL_SET_NAMES): Update.
3120 * symtab.c (symbol_set_names): Change argument to be an
3121 objfile_per_bfd_storage.
3122 * psymtab.c (add_psymbol_to_bcache): Update.
3123 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
3124
0f14768a
TT		 31252019-01-10 Tom Tromey <tom@tromey.com>
3126
3127 * symtab.c (create_demangled_names_hash): Change argument to be an
3128 objfile_per_bfd_storage.
3129 (symbol_set_names): Update.
3130
6eee24ce
TT		 31312019-01-10 Tom Tromey <tom@tromey.com>
3132
3133 * xcoffread.c (xcoff_initial_scan): Unconditionally call
3134 init_psymbol_list.
3135 * psymtab.c (init_psymbol_list): Do nothing if already called.
3136 * psympriv.h (init_psymbol_list): Add comment.
3137 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3138 init_psymbol_list.
3139 * dbxread.c (dbx_symfile_read): Unconditionally call
3140 init_psymbol_list.
3141
75aedd27
TT		 31422019-01-10 Tom Tromey <tom@tromey.com>
3143
3144 * xcoffread.c (scan_xcoff_symtab): Update.
3145 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3146 "where".
3147 * mdebugread.c (parse_partial_symbols)
3148 (handle_psymbol_enumerators): Update.
3149 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3150 * dbxread.c (read_dbx_symtab): Update.
3151 * psympriv.h (psymbol_placement): New enum.
3152 (add_psymbol_to_list): Update.
3153
939652a5
TT		 31542019-01-10 Tom Tromey <tom@tromey.com>
3155
3156 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3157 static_psymbols parameters.
3158 (scan_xcoff_symtab): Update.
3159 * psymtab.c (start_psymtab_common): Remove global_psymbols and
3160 static_psymbols parameters.
3161 * psympriv.h (start_psymtab_common): Update.
3162 * mdebugread.c (parse_partial_symbols): Update.
3163 * dwarf2read.c (create_partial_symtab): Update.
3164 * dbxread.c (read_dbx_symtab): Update.
3165 (start_psymtab): Remove global_psymbols and static_psymbols
3166 parameters.
3167
baa62830
TT		 31682019-01-10 Tom Tromey <tom@tromey.com>
3169
3170 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3171 * psymtab.c (allocate_psymtab): Add comment.
3172 * psympriv.h (allocate_psymtab): Add comment.
3173 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3174 initializations.
3175 * dbxread.c (dbx_end_psymtab): Remove some initializations.
3176
0e8f53ba
TT		 31772019-01-10 Tom Tromey <tom@tromey.com>
3178
3179 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3180 Don't declare.
3181 * mipsread.c: Include mdebugread.h.
3182 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3183 Declare.
3184 * elfread.c: Include mdebugread.h.
3185
b22a7c6a
TT		 31862019-01-09 Tom Tromey <tom@tromey.com>
3187
3188 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3189 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3190 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3191 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3192 (psym_lookup_symbol, psym_find_last_source_symtab)
3193 (psym_forget_cached_source_info, psym_print_stats)
3194 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3195 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3196 (psym_map_matching_symbols, psym_expand_symtabs_matching)
3197 (psym_find_compunit_symtab_by_address)
3198 (maintenance_print_psymbols, maintenance_info_psymtabs)
3199 (maintenance_check_psymtabs): Use ranged for.
3200 * psymtab.h (class objfile_psymtabs): New.
3201 (require_partial_symbols): Return objfile_psymtabs.
3202 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3203
3b9d3ac2
TT		 32042019-01-09 Tom Tromey <tom@tromey.com>
3205
3206 * symfile.c (overlay_invalidate_all, find_pc_overlay)
3207 (find_pc_mapped_section, list_overlays_command)
3208 (map_overlay_command, unmap_overlay_command)
3209 (simple_overlay_update): Use all_objfiles.
3210 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3211 * printcmd.c (info_symbol_command): Use all_objfiles.
3212 * objfiles.h (ALL_OBJSECTIONS): Remove.
3213 * maint.c (maintenance_translate_address): Use all_objfiles.
3214 * gcore.c (gcore_create_callback): Use all_objfiles.
3215 (objfile_find_memory_regions): Likewise.
3216
8b31193a
TT		 32172019-01-09 Tom Tromey <tom@tromey.com>
3218
3219 * symtab.c (find_line_symtab, info_sources_command)
3220 (make_source_files_completion_list): Use objfile_compunits.
3221 * source.c (select_source_symtab): Use objfile_compunits.
3222 * objfiles.h (struct objfile): Update comment.
3223 (ALL_OBJFILES): Remove.
3224 (ALL_FILETABS): Remove.
3225 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3226 objfile_compunits.
3227
d5da8b3c
TT		 32282019-01-09 Tom Tromey <tom@tromey.com>
3229
3230 * symmisc.c (print_objfile_statistics, dump_objfile)
3231 (maintenance_print_symbols): Use compunit_filetabs.
3232 * source.c (forget_cached_source_info_for_objfile): Use
3233 compunit_filetabs.
3234 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3235 (ALL_FILETABS): Use compunit_filetabs.
3236 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3237 * coffread.c (coff_symtab_read): Use compunit_filetabs.
3238
5accd1a0
TT		 32392019-01-09 Tom Tromey <tom@tromey.com>
3240
3241 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3242 (compunit_filetabs): New.
3243 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3244 compunit_filetabs.
3245 (info_sources_command, make_source_files_completion_list): Remove
3246 declaration.
3247 * symmisc.c (print_objfile_statistics, dump_objfile)
3248 (maintenance_print_symbols): Remove declaration.
3249 (maintenance_info_symtabs): Use compunit_filetabs.
3250 (maintenance_info_line_tables): Likewise.
3251 * source.c (select_source_symtab): Change local variable name.
3252 (forget_cached_source_info_for_objfile): Remove declaration.
3253 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3254 * objfiles.c (objfile_relocate1): Remove declaration.
3255 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3256 declaration.
3257 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3258 * coffread.c (coff_symtab_read): Remove declaration.
3259 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3260 compunit_filetabs.
3261
d8aeb77f
TT		 32622019-01-09 Tom Tromey <tom@tromey.com>
3263
3264 * symtab.c (lookup_objfile_from_block)
3265 (find_pc_sect_compunit_symtab, search_symbols)
3266 (default_collect_symbol_completion_matches_break_on): Use
3267 objfile_compunits.
3268 * objfiles.h (ALL_COMPUNITS): Remove.
3269 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3270 * cp-support.c (add_symbol_overload_list_qualified): Use
3271 objfile_compunits.
3272 * ada-lang.c (ada_collect_symbol_completion_matches)
3273 (ada_add_global_exceptions): Use objfile_compunits.
3274
592553c4
TT		 32752019-01-09 Tom Tromey <tom@tromey.com>
3276
3277 * source.c (select_source_symtab)
3278 (forget_cached_source_info_for_objfile): Remove declaration.
3279 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3280 declaration.
3281 * maint.c (count_symtabs_and_blocks): Remove declaration.
3282 * cp-support.c (add_symbol_overload_list_qualified): Remove
3283 declaration.
3284 * coffread.c (coff_symtab_read): Remove declaration.
3285 * symtab.c (lookup_symbol_in_objfile_symtabs)
3286 (basic_lookup_transparent_type_1): Use objfile_compunits.
3287 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3288 (info_sources_command, search_symbols)
3289 (default_collect_symbol_completion_matches_break_on)
3290 (make_source_files_completion_list): Remove declaration.
3291 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3292 (ada_collect_symbol_completion_matches)
3293 (ada_add_global_exceptions): Remove declaration.
3294 * linespec.c (iterate_over_all_matching_symtabs): Use
3295 objfile_compunits.
3296 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3297 (class objfile_compunits): New.
3298 (ALL_COMPUNITS): Use objfile_compunits.
3299 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3300 (maintenance_check_symtabs, maintenance_info_line_tables): Use
3301 objfile_compunits.
3302 * objfiles.c (objfile_relocate1): Use objfile_compunits.
3303
5325b9bf
TT		 33042019-01-09 Tom Tromey <tom@tromey.com>
3305
3306 * symtab.c (search_symbols)
3307 (default_collect_symbol_completion_matches_break_on): Use
3308 objfile_msymbols.
3309 * ada-lang.c (ada_lookup_simple_minsym)
3310 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3311 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3312 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3313 objfile_msymbols.
3314 * coffread.c (coff_symfile_read): Use objfile_msymbols.
3315 * symmisc.c (dump_msymbols): Use objfile_msymbols.
3316 * objc-lang.c (find_methods): Use objfile_msymbols.
3317 (info_selectors_command, info_classes_command): Likewise.
3318 * stabsread.c (scan_file_globals): Use objfile_msymbols.
3319 * objfiles.h (class objfile_msymbols): New.
3320 (ALL_OBJFILE_MSYMBOLS): Remove.
3321 (ALL_MSYMBOLS): Remove.
3322
cac85af2
TT		 33232019-01-09 Tom Tromey <tom@tromey.com>
3324
3325 * common/next-iterator.h (next_adapter): Add Iterator template
3326 parameter.
3327 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3328 (class all_objfiles_safe): New.
3329 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3330 * objfiles.c (put_objfile_before): Update comment.
3331 (add_separate_debug_objfile): Likewise.
3332 (free_all_objfiles): Use all_objfiles_safe.
3333 (objfile_purge_solibs): Likewise.
3334
aed57c53
TT		 33352019-01-09 Tom Tromey <tom@tromey.com>
3336
3337 * symtab.c (iterate_over_symtabs, matching_obj_sections)
3338 (expand_symtab_containing_pc, lookup_static_symbol)
3339 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3340 (find_symbol_at_address, find_line_symtab, find_main_name): Use
3341 all_objfiles.
3342 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3343 * breakpoint.c (create_overlay_event_breakpoint)
3344 (create_longjmp_master_breakpoint)
3345 (create_std_terminate_master_breakpoint)
3346 (create_exception_master_breakpoint): Use all_objfiles.
3347 * linux-thread-db.c (try_thread_db_load_from_pdir)
3348 (has_libpthread): Use all_objfiles.
3349 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3350 * linespec.c (iterate_over_all_matching_symtabs)
3351 (search_minsyms_for_name): Use all_objfiles.
3352 * maint.c (maintenance_info_sections): Use all_objfiles.
3353 * main.c (captured_main_1): Use all_objfiles.
3354 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3355 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3356 * guile/scm-pretty-print.c
3357 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3358 * solib-spu.c (append_ocl_sos): Use all_objfiles.
3359 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3360 (maintenance_print_msymbols): Use all_objfiles.
3361 * source.c (select_source_symtab): Use all_objfiles.
3362 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3363 * symfile.c (remove_symbol_file_command)
3364 (expand_symtabs_matching, map_symbol_filenames): Use
3365 all_objfiles.
3366 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3367 all_objfiles.
3368 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3369 * objc-lang.c (find_methods): Use all_objfiles.
3370 * objfiles.c (have_partial_symbols, have_full_symbols)
3371 (have_minimal_symbols, qsort_cmp)
3372 (default_iterate_over_objfiles_in_search_order): Use
3373 all_objfiles.
3374 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3375 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3376 (maintenance_check_psymtabs): Use all_objfiles.
3377 (ALL_PSYMTABS): Remove.
3378 * compile/compile-object-run.c (do_module_cleanup): Use
3379 all_objfiles.
3380 * blockframe.c (find_pc_partial_function): Use all_objfiles.
3381 * cp-support.c (add_symbol_overload_list_qualified): Use
3382 all_objfiles.
3383 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3384 Use all_objfiles.
3385 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3386 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3387 all_objfiles.
3388 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3389 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3390 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3391 Uses all_objfiles.
3392 * solib.c (solib_read_symbols): Use all_objfiles
3393
99d89cde
TT		 33942019-01-09 Tom Tromey <tom@tromey.com>
3395
3396 * probe.c (parse_probes_in_pspace): Use all_objfiles.
3397 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3398 all_objfiles.
3399 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3400 * symmisc.c (print_symbol_bcache_statistics)
3401 (print_objfile_statistics, maintenance_print_objfiles)
3402 (maintenance_info_symtabs, maintenance_check_symtabs)
3403 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3404 all_objfiles.
3405 * source.c (forget_cached_source_info): Use all_objfiles.
3406 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3407 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3408 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3409 * objfiles.c (update_section_map): Use all_objfiles.
3410 (shared_objfile_contains_address_p): Likewise.
3411 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3412 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3413
21708325
TT		 34142019-01-09 Tom Tromey <tom@tromey.com>
3415
3416 * common/next-iterator.h: New file.
3417 * objfiles.h (class all_objfiles): New.
3418 (struct objfile_iterator): New.
3419
669e09f6
PW		 34202019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3421
3422 * NEWS: Move the description of the changed "frame", "select-frame",
3423 and "info frame" commands to the Changed commands section.
3424
041be526
SM		 34252019-01-09 Simon Marchi <simon.marchi@ericsson.com>
3426
3427 * gdbtypes.c (check_stub_method_group): Remove handling of old
3428 mangling schemes.
3429 * linespec.c (find_methods): Likewise.
3430 * stabsread.c (read_member_functions): Likewise.
3431 * valops.c (search_struct_method): Likewise.
3432 (value_struct_elt_for_reference): Likewise.
3433 * NEWS: Mention this change.
3434
0e2a2133
AB		 34352019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
3436
3437 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3438 print_source_lines.
3439 * source.c (print_source_lines_base): Update line number check.
3440 (print_source_lines): New function.
3441 (source_lines_range::source_lines_range): New function.
3442 * source.h (class source_lines_range): New class.
3443 (print_source_lines): New declaration.
3444
1055a3b4
PW		 34452019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3446
3447 * linespec.c (linespec_state_destructor): Free self->canonical_names.
3448
cfeadda5
TT		 34492019-01-08 Tom Tromey <tom@tromey.com>
3450 Simon Marchi <simon.marchi@ericsson.com>
3451
3452 PR gdb/24060
3453 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3454 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3455 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3456 * f-exp.y (DOLLAR_VARIABLE): Likewise.
3457 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3458 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3459
583068ca
AB		 34602019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
3461
3462 * source.c (select_source_symtab): Move header comment to
3463 declaration in source.h.
3464 (forget_cached_source_info_for_objfile): Likewise.
3465 (forget_cached_source_info): Likewise.
3466 (identify_source_line): Likewise.
3467 * source.h (identify_source_line): Move declaration from symtab.h
3468 and add comment from source.c
3469 (print_source_lines): Likewise.
3470 (forget_cached_source_info_for_objfile): Likewise.
3471 (forget_cached_source_info): Likewise.
3472 (select_source_symtab): Likewise.
3473 (enum print_source_lines_flag): Move definition from symtab.h.
3474 * symtab.h (identify_source_line): Move declaration to source.h.
3475 (print_source_lines): Likewise.
3476 (forget_cached_source_info_for_objfile): Likewise.
3477 (forget_cached_source_info): Likewise.
3478 (select_source_symtab): Likewise.
3479 (enum print_source_lines_flag): Move definition to source.h.
3480 * tui/tui-hooks.c: Add 'source.h' include.
3481
ec98a4ad
AB		 34822019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
3483
3484 * source.c (print_source_lines_base): Handle requests to print
3485 reverse line number sequences, and guard against empty lines
3486 string.
3487
62ea19c1
AB		 34882019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
3489
3490 * source.c (print_source_lines_base): Fix skip of '\r' if next
3491 character is '\n'.
3492
9d30e1fd
TT		 34932019-01-06 Tom Tromey <tom@tromey.com>
3494
3495 * c-exp.y (struct c_parse_state) <macro_original_text,
3496 expansion_obstack>: New member.
3497 (macro_original_text, expansion_obstack): Remove globals.
3498 (scan_macro_expansion, scanning_macro_expansion)
3499 (finished_macro_expansion): Update.
3500 (scan_macro_cleanup): Remove.
3501 (yylex, c_parse): Update.
3502
c65bac38
TT		 35032019-01-06 Tom Tromey <tom@tromey.com>
3504
3505 * c-exp.y (struct c_parse_state) <strings>: New member.
3506 (operator_stoken): Update.
3507
02e12e38
TT		 35082019-01-06 Tom Tromey <tom@tromey.com>
3509
3510 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
3511 (union type_stack_elt) <typelist_val>: Now a pointer to
3512 std::vector.
3513 (type_stack_cleanup): Don't declare.
3514 (push_typelist): Update.
3515 * parse.c (pop_typelist): Return a std::vector.
3516 (push_typelist): Take a std::vector.
3517 (follow_types): Update. Do not free args.
3518 (type_stack_cleanup): Remove.
3519 * c-exp.y (struct c_parse_state): New.
3520 (cpstate): New global.
3521 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3522 (nonempty_typelist): Update.
3523 (func_mod): Create a new vector.
3524 (c_parse): Create a c_parse_state.
3525 (check_parameter_typelist): Do not delete params.
3526 (function_method): Update. Do not delete type_list.
3527
f097f5ad
TT		 35282019-01-06 Tom Tromey <tom@tromey.com>
3529
3530 PR gdb/28155:
3531 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3532 check_typedef.
3533 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3534 (print_return_value): Likewise.
3535
d2adf9f1
TT		 35362019-01-05 Tom Tromey <tom@tromey.com>
3537
3538 * contrib/cleanup_check.py: Remove.
3539 * contrib/gcc-with-excheck: Remove.
3540 * contrib/exsummary.py: Remove.
3541 * contrib/excheck.py: Remove.
3542
2eab46b1
JB		 35432019-01-05 Joel Brobecker <brobecker@adacore.com>
3544
3545 * thread.c (delete_thread_1): Add gdb_assert that THR is not
3546 NULL. Initialize tpprev to NULL instead of assigning it
3547 to NULL on the next statement.
3548 * windows-nat.c (windows_delete_thread): Remove check for
3549 main_thread_id before printing thread exit notifications.
3550 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3551 Remove thread ID check against main_thread_id.
3552 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3553 windows_delete_thread.
3554 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3555
48c5e7e2
TT		 35562019-01-04 Tom Tromey <tom@tromey.com>
3557
3558 * compile/compile.c (_initialize_compile): Use upper case for
3559 metasyntactic variables.
3560 * symmisc.c (_initialize_symmisc): Use upper case for
3561 metasyntactic variables.
3562 * psymtab.c (_initialize_psymtab): Use upper case for
3563 metasyntactic variables.
3564 * demangle.c (demangle_command): Use upper case for metasyntactic
3565 variables.
3566 (_initialize_demangler): Likewise.
3567 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3568 variables.
3569
986041cd
TT		 35702019-01-03 Tom Tromey <tom@tromey.com>
3571
3572 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3573
7c711119
TT		 35742019-01-03 Tom Tromey <tom@tromey.com>
3575
3576 * python/py-symtab.c (salpy_str): Update.
3577 (struct salpy_sal_object) <symtab>: Now a PyObject.
3578 (salpy_dealloc): Update.
3579 (del_objfile_sal): Use gdbpy_ref.
3580
1b20edf0
TT		 35812019-01-03 Tom Tromey <tom@tromey.com>
3582
3583 * python/py-type.c (convert_field): Use new_reference. Return
3584 gdbpy_ref.
3585 (make_fielditem): Return gdbpy_ref.
3586 (typy_fields): Update.
3587 (typy_getitem): Update.
3588 (field_name): Return gdbpy_ref. Use new_reference.
3589 (typy_iterator_iternext): Update.
3590
ea41325b
TT		 35912019-01-03 Tom Tromey <tom@tromey.com>
3592
3593 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3594
2a3c71d6
TT		 35952019-01-03 Tom Tromey <tom@tromey.com>
3596
3597 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3598 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3599 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3600 (pspy_set_frame_filters, pspy_set_frame_unwinders)
3601 (pspy_set_type_printers): Likewise.
3602 * python/py-function.c (fnpy_init): Use gdbpy_ref.
3603 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3604 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3605 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3606 (objfpy_set_type_printers): Likewise.
3607
5c329e6a
TT		 36082019-01-03 Tom Tromey <tom@tromey.com>
3609
3610 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3611 (gdbpy_print_stack): Use gdbpy_err_fetch.
3612 * python/python-internal.h (class gdbpy_err_fetch): New class.
3613 (class gdbpy_enter) <m_error_type, m_error_value,
3614 m_error_traceback>: Remove.
3615 <m_error>: New member.
3616 (gdbpy_exception_to_string): Don't declare.
3617 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3618 * python/py-value.c (convert_value_from_python): Use
3619 gdbpy_err_fetch.
3620 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3621 gdbpy_exception_to_string.
3622 (gdbpy_handle_exception): Use gdbpy_err_fetch.
3623 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3624 gdbpy_err_fetch.
3625
169bb27b
AB		 36262019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
3627
3628 * linux-nat.c (delete_lwp_cleanup): Delete.
3629 (struct lwp_deleter): New struct.
3630 (lwp_info_up): New typedef.
3631 (linux_nat_target::follow_fork): Delete cleanup, and make use of
3632 lwp_info_up.
3633
a07c8880
AB		 36342019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
3635
3636 * linux-fork.c (class scoped_switch_fork_info): New class.
3637 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3638
26089c49
AB		 36392019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
3640
3641 * valops.c (find_overload_match): Remove use of null_cleanup, and
3642 calls to do_cleanups.
3643
06d3e5b0
AB		 36442019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
3645
3646 * compile/compile-cplus-types.c
3647 (compile_cplus_instance::decl_name): Handle changes to
3648 cp_func_name.
3649 * cp-support.c (cp_func_name): Update header comment, update
3650 return type.
3651 * cp-support.h (cp_func_name): Update return type in declaration.
3652 * valops.c (find_overload_match): Move temp_func local to top
3653 level of function and change its type. Use temp_func to hold and
3654 delete temporary string obtained from cp_func_name.
3655
66644cd3
AB		 36562019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
3657
3658 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3659 gdb::char_vector, remove cleanup, and update uses of `msg`.
3660
592d8c0a
JW		 36612019-01-03 Jim Wilson <jimw@sifive.com>
3662
3663 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3664
c55d06ec
TT		 36652019-01-02 Tom Tromey <tom@tromey.com>
3666
3667 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3668 (tdesc_parse_xml): Remove cleanups.
3669 * target-descriptions.h (make_cleanup_free_target_description):
3670 Don't declare.
3671 (target_desc_deleter): New struct.
3672 (target_desc_up): New typedef.
3673 * target-descriptions.c (target_desc_deleter::operator()): Rename
3674 from free_target_description.
3675 (make_cleanup_free_target_description): Remove.
3676
3a6ae42d
TT		 36772019-01-02 Tom Tromey <tom@tromey.com>
3678
3679 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
3680 constructor, destructor.
3681 (linespec_parser): Remove typedef.
3682 (~linespec_parser): Rename from linespec_parser_delete.
3683 (linespec_lex_to_end, linespec_complete_label)
3684 (linespec_complete): Update.
3685 (decode_line_full): Remove cleanups.
3686 (decode_line_1): Update.
3687
61fd3e73
TT		 36882019-01-02 Tom Tromey <tom@tromey.com>
3689
3690 * python/python-internal.h (inferior_to_inferior_object): Change
3691 return type.
3692 * python/py-exitedevent.c (create_exited_event_object): Update.
3693 * python/py-inferior.c (inferior_to_inferior_object): Return
3694 gdbpy_ref.
3695 (python_new_inferior, python_inferior_deleted)
3696 (thread_to_thread_object, delete_thread_object)
3697 (build_inferior_list, gdbpy_selected_inferior): Update.
3698 * python/py-infthread.c (create_thread_object): Update. Also fail
3699 if inferior_to_inferior_object fails.
3700
d20172fc
SM		 37012019-01-02 Simon Marchi <simon.marchi@ericsson.com>
3702
3703 * inferior.h (class inferior) <displaced_step_state>: New field.
3704 * infrun.h (struct displaced_step_state): Move here from
3705 infrun.c. Initialize fields, add constructor.
3706 <inf>: Remove field.
3707 <reset>: New method.
3708 * infrun.c (struct displaced_step_inferior_state): Move to
3709 infrun.h.
3710 (displaced_step_inferior_states): Remove.
3711 (get_displaced_stepping_state): Adust.
3712 (displaced_step_in_progress_any_inferior): Adjust.
3713 (displaced_step_in_progress_thread): Adjust.
3714 (displaced_step_in_progress): Adjust.
3715 (add_displaced_stepping_state): Remove.
3716 (get_displaced_step_closure_by_addr): Adjust.
3717 (remove_displaced_stepping_state): Remove.
3718 (infrun_inferior_exit): Call displaced_step_state.reset.
3719 (use_displaced_stepping): Don't check for NULL.
3720 (displaced_step_prepare_throw): Call
3721 get_displaced_stepping_state.
3722 (displaced_step_fixup): Don't check for NULL.
3723 (prepare_for_detach): Don't check for NULL.
3724
e3319240
PW		 37252019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3726
3727 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3728 in case of call that did not complete.
3729
5d36dfb9
AU		 37302019-01-02 Andrey Utkin <autkin@undo.io>
3731
3732 * symfile.c (find_separate_debug_file): Fix search of debug files for
3733 remote debuggee.
3734
8833fbf0
TT		 37352019-01-02 Tom Tromey <tom@tromey.com>
3736
3737 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3738 indentation.
3739 * python/py-frame.c (frapy_older): Remove cast.
3740 (frapy_newer): Likewise.
3741 * python/py-breakpoint.c (local_setattro): Remove cast.
3742 * python/py-arch.c (archpy_name): Remove local variable.
3743 * python/py-type.c (gdbpy_lookup_type): Remove cast.
3744
4ada3dfd
JB		 37452019-01-02 Joel Brobecker <brobecker@adacore.com>
3746
3747 * unittests/basic_string_view/element_access/char/empty.cc:
3748 Fix year range in copyright header.
3749
113b7b81
AB		 37502019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
3751
3752 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3753 Delete.
3754 <operator==>: Update with for removed field.
3755 <hash>: Likewise.
3756 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3757 <isa_features>: ...this.
3758 <abi_features>: New field.
3759 (riscv_isa_flen): Update comment.
3760 (riscv_abi_xlen): New declaration.
3761 (riscv_abi_flen): New declaration.
3762 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3763 isa_features.
3764 (riscv_abi_xlen): New function.
3765 (riscv_isa_flen): Update to get answer from isa_features.
3766 (riscv_abi_flen): New function.
3767 (riscv_has_fp_abi): Update to get answer from abi_features.
3768 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3769 xlen and flen.
3770 (riscv_call_info) <xlen, flen>: Update comment.
3771 (riscv_call_arg_struct): Remove invalid assertions
3772 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3773 is removed.
3774 (riscv_gdbarch_init): Gather isa features and abi features
3775 separately, ensure both match on the gdbarch when reusing an old
3776 gdbarch. Relax an error check to allow 32-bit abi float to run on
3777 a target with 64-bit float hardware.
3778
b18ca514
PW		 37792019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3780
3781 * source.c (search_command_helper): Stop reverse search
3782 when line 1 has been searched.
3783
ec70d8db
PW		 37842019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3785
3786 * record-full.c (record_full_base_target::close): Rewrite
3787 record_full_core_buf_list free logic.
3788
5b38f9c1
PW		 37892019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3790
3791 * break-catch-syscall.c (print_one_catch_syscall): xfree
3792 the last text.
3793
66d91b39
JB		 37942019-01-01 Joel Brobecker <brobecker@adacore.com>
3795
3796 * top.c (print_gdb_version): Update Copyright year in version
3797 message.
3798
42a4f53d
JB		 37992019-01-01 Joel Brobecker <brobecker@adacore.com>
3800
3801 Update copyright year range in all GDB files.
3802
7e955d83 38032019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 3804
5bbd631d 3805 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 3806
5bbd631d 3807For older changes see ChangeLog-2018.
c906108c
SS		 3808\f
3809Local Variables:
3810mode: change-log
3811left-margin: 8
3812fill-column: 74
3813version-control: never
57da7796 3814coding: utf-8
c906108c 3815End:
5bbd631d 3816
GDB Binutils - Deliverables
This page took 2.968823 seconds and 4 git commands to generate.