Bump version to 10.0.50.DATE-git.
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
d746744e
JB
12019-12-11 Joel Brobecker <brobecker@adacore.com>
2
3 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
4 * version.in: Bump version to 10.0.50.DATE-git.
5
2e744276
TT
62019-12-11 Tom Tromey <tromey@adacore.com>
7
8 PR build/25268:
9 * gdbsupport/thread-pool.c (set_thread_name): New function.
10 (thread_pool::set_thread_count): Don't call pthread_setname_np.
11 (thread_pool::thread_function): Call set_thread_name.
12
aac4760f
TT
132019-12-11 Tom Tromey <tromey@adacore.com>
14
15 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
16 bfd_get_signed_8.
17
d8edc8b7
PW
182019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
19
20 * NEWS: Document -raw-values option and the related setting commands.
21 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
22 only set it on when /r is given.
23 * valprint.c (value_print_option_defs): New element raw-values.
24 * Makefile.in: Add the new file.
25
cb511130
CB
262019-12-10 Christian Biesinger <cbiesinger@google.com>
27
28 * gdbsupport/safe-strerror.c: Supress the unused function warning
29 for select_strerror_r.
30
ab7d13f0
CB
312019-12-10 Christian Biesinger <cbiesinger@google.com>
32
33 * config.in: Regenerate.
34 * configure: Regenerate.
35 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
36 safe_strerror instead of strerror.
37 * gdbsupport/common.m4: Don't check for strerror.
38 * gdbsupport/safe-strerror.c: Support both the glibc version
39 of strerror_r and the XSI version.
40
6c71eb7d
TT
412019-12-10 Tom Tromey <tromey@adacore.com>
42
43 * ada-typeprint.c (print_choices): Use a single "?".
44 (print_variant_part): Print "?" if the discriminant name
45 is not known.
46
bac7c5cf
GB
472019-12-10 George Barrett <bob@bob131.so>
48
49 Fix scripted probe breakpoints.
50 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
51 declaration forward.
52 (breakpoint_ops_for_event_location_type)
53 (breakpoint_ops_for_event_location): Add function definitions.
54 (break_command_1, trace_command): Use
55 breakpoint_ops_for_event_location.
56 * breakpoint.h (breakpoint_ops_for_event_location): Add function
57 declarations.
58 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
59 breakpoint_ops_for_event_location.
60 * python/py-breakpoint.c (bppy_init): Use
61 breakpoint_ops_for_event_location.
62
330f1d38
TBA
632019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
64
65 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
66 when ranking an lvalue argument for an rvalue parameter.
67
b1f0c0b9
WA
682019-12-08 Wataru Ashihara <wataash@wataash.com>
69
70 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
71 template argument for scoped_restore_tmpl from bool to int.
72
aa2d5a42
KS
732019-12-07 Keith Seitz <keiths@redhat.com>
74
75 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
76 (build_id_to_debug_bfd): Make static, rewriting to use
77 build_id_to_bfd_suffix.
78 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
79 adding `suffix' parameter. Append SUFFIX to file names
80 when searching for matching files.
81 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
82 (build_id_to_exec_bfd): Likewise.
83 * build-id.h (build_id_to_debug_bfd): Clarify that function
84 searches for BFD of debug info file.
85 (build_id_to_exec_bfd): Declare.
86 * corelow.c: Include build-id.h.
87 (locate_exec_from_corefile_build_id): New function.
88 (core_target_open): If no executable BFD is found,
89 search for a core file BFD using build-id.
90
dfb65191
CB
912019-12-06 Christian Biesinger <cbiesinger@google.com>
92
93 * bcache.c: Put in namespace gdb.
94 * bcache.h: Likewise.
95 * gdbtypes.c (check_types_worklist): Update.
96 (types_deeply_equal): Update.
97 * macrotab.c (struct macro_table) <bcache>: Update.
98 (new_macro_table): Update.
99 * macrotab.h (struct bcache): Put this forward declaration
100 inside namespace gdb.
101 (new_macro_table): Update.
102 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
103 Update.
104 <macro_cache>: Update.
105 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
106
93e55f0a
TV
1072019-12-06 Tom de Vries <tdevries@suse.de>
108
109 PR symtab/24971
110 * block.c (best_symbol, better_symbol): New function.
111 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
112 decl.
113
06acc08f
TBA
1142019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
115
116 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
117 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
118 for ranking see-through reference cases.
119
e0fad1ea
PW
1202019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
121 * stack.c (faas_command): Check a command is provided.
122 * thread.c (taas_command, tfaas_command): Likewise.
123
908641f5
PW
1242019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
125 * inferior.c (prune_inferiors): Only call delete_inferior,
126 Do not modify the inferior list.
127
b858499d
SM
1282019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
129
130 * c-exp.y: Update calls to lookup_typename,
131 lookup_signed_typename and lookup_unsigned_typename.
132 * c-lang.c (evaluate_subexp_c): Likewise.
133 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
134 Likewise.
135 * eval.c (binop_promote): Likewise.
136 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
137 (lookup_unsigned_typename): Likewise.
138 (lookup_signed_typename): Likewise.
139 * gdbtypes.h (lookup_unsigned_typename): Likewise.
140 (lookup_signed_typename): Likewise.
141 (lookup_typename): Likewise.
142 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
143 lookup_typename, lookup_signed_typename,
144 lookup_unsigned_typename.
145 * m2-exp.y: Likewise.
146 * printcmd.c (printf_wide_c_string): Likewise.
147 (ui_printf): Likewise.
148 * python/py-type.c (typy_lookup_typename): Likewise.
149 * python/py-xmethods.c (python_xmethod_worker::invoke):
150 Likewise.
151 * rust-exp.y: Likewise.
152
3a8fa228
CB
1532019-12-04 Christian Biesinger <cbiesinger@google.com>
154
155 * configure.nat (obsd64): Add missing files x86-nat.o and
156 nat/x86-dregs.o.
157
2dbc041e
TT
1582019-12-04 Tom Tromey <tom@tromey.com>
159
160 * valprint.c (val_print_string): Use metadata_style.
161 * go-valprint.c (print_go_string): Use metadata style.
162 * p-valprint.c (pascal_object_print_static_field): Use metadata
163 style.
164 * cp-valprint.c (cp_print_static_field): Use metadata style.
165
36c8fb93
AB
1662019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
167 Chris January <chris.january@arm.com>
168
169 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
170 tokens.
171 (typebase): New patterns for complex, single/double precision, and
172 single/double complex.
173 (f77_keywords): Change token for complex keyword, and add single,
174 double, and precision keywords.
175
c6170c2c
SM
1762019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
177
178 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
179 "info io_registers".
180
894ecaf4
SM
1812019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
182
183 * regcache.c (cooked_read_test): Initialize thread list of
184 mock_inferior.
185
be155ebb
SM
1862019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
187
188 * aarch64-linux-tdep.c: Remove includes.
189
c577cdd7
SM
1902019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
191
192 * aarch64-tdep.c: Remove includes.
193
610cfd61
SM
1942019-12-04 Simon Marchi <simon.marchi@efficios.com>
195
196 * filtered-iterator.h (filtered_iterator) <operator==,
197 operator!=>: Compare wrapped iterators, not wrapped pointers.
198 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
199 unittests/filtered_iterator-selftests.c.
200 * unittests/filtered_iterator-selftests.c: New file.
201
a05cf17a
TT
2022019-12-04 Tom Tromey <tromey@adacore.com>
203
204 * gdbtypes.c (create_range_type): Inherit endianity
205 from base type.
206
d5a22e77
TT
2072019-12-04 Tom Tromey <tromey@adacore.com>
208
209 * ada-lang.c (decode_constrained_packed_array)
210 (ada_value_assign, value_assign_to_component): Update.
211 * dwarf2loc.c (rw_pieced_value, access_memory)
212 (dwarf2_compile_expr_to_ax): Update.
213 * dwarf2read.c (dwarf2_add_field): Update.
214 * eval.c (evaluate_subexp_standard): Update.
215 * gdbarch.c, gdbarch.h: Rebuild.
216 * gdbarch.sh (bits_big_endian): Remove.
217 * gdbtypes.h (union field_location): Update comment.
218 * target-descriptions.c (make_gdb_type): Update.
219 * valarith.c (value_bit_index): Update.
220 * value.c (struct value) <bitpos>: Update comment.
221 (unpack_bits_as_long, modify_field): Update.
222 * value.h (value_bitpos): Update comment.
223
7ab4a236
TT
2242019-12-04 Tom Tromey <tromey@adacore.com>
225
226 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
227 endian-ness.
228
103a685e
TT
2292019-12-04 Tom Tromey <tromey@adacore.com>
230
231 * dwarf2read.c (dwarf2_init_float_type)
232 (dwarf2_init_complex_target_type): Add byte_order parameter.
233 (read_base_type): Compute byte order earlier.
234 * gdbtypes.c (init_float_type): Add byte_order parameter.
235 * gdbtypes.h (init_float_type): Add byte_order parameter.
236
7a9e9f9f
TT
2372019-12-04 Tom Tromey <tromey@adacore.com>
238
239 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
240
feee869b
TT
2412019-12-04 Tom Tromey <tromey@adacore.com>
242
243 * dwarf2read.c (process_structure_scope): Initialize
244 "discr_offset".
245
c2512106
AB
2462019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
247
248 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
249 add it into the search spec.
250 (parse_max_results_option): New function.
251 (mi_info_functions_or_variables): Parse -max-results flag and pass
252 it to mi_symbol_info.
253 (mi_cmd_symbol_info_modules): Likewise.
254 (mi_cmd_symbol_info_types): Likewise.
255 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
256 return type to bool, change result container into a set, and don't
257 add new results if we have enough already.
258 (global_symbol_searcher::add_matching_msymbols): Change return
259 type to bool, and don't add new results if we have enough already.
260 (sort_search_symbols_remove_dups): Delete.
261 (global_symbol_searcher::search): Early exit from search loop when
262 we have enough results. Use a std::set to collect the results
263 from calling add_matching_symbols.
264 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
265 member function.
266 (global_symbol_searcher) <m_max_search_results>: New member
267 variable.
268 (global_symbol_searcher) <add_matching_symbols>: Update header
269 comment and change return type to bool.
270 (global_symbol_searcher) <add_matching_msymbols>: Update header
271 comment and change return type to bool.
272
f97a63c5
AB
2732019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
274
275 * symtab.c (symbol_search::compare_search_syms): Update header
276 comment.
277 (global_symbol_searcher::is_suitable_msymbol): New function.
278 (global_symbol_searcher::expand_symtabs): New function.
279 (global_symbol_searcher::add_matching_symbols): New function.
280 (global_symbol_searcher::add_matching_msymbols): New function.
281 (global_symbol_searcher::search): Move most of the content
282 into the new functions above, and call them as needed.
283 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
284 function.
285 (global_symbol_searcher) <add_matching_symbols>: New member
286 function.
287 (global_symbol_searcher) <add_matching_msymbols>: New member
288 function.
289 (global_symbol_searcher) <is_suitable_msymbol>: New member
290 function.
291
293b38d6
AB
2922019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
293
294 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
295 -symbol-info-module-variables entries.
296 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
297 (mi_cmd_symbol_info_module_variables): Declare.
298 * mi/mi-symbol-cmds.c
299 (module_symbol_search_iterator): New typedef.
300 (output_module_symbols_in_single_module_and_file): New function.
301 (output_module_symbols_in_single_module): New function.
302 (mi_info_module_functions_or_variables): New function.
303 (mi_cmd_symbol_info_module_functions): New function.
304 (mi_cmd_symbol_info_module_variables): New function.
305 * NEWS: Mention new MI command.
306
4cbd39b2
CB
3072019-12-03 Christian Biesinger <cbiesinger@google.com>
308
309 * bcache.c (hash): Remove.
310 (hash_continue): Remove.
311 * bcache.h (hash): Remove.
312 (hash_continue): Remove.
313 (struct bcache) <ctor>: Update.
314 * psymtab.c (psymbol_hash): Update.
315 * stabsread.c (hashname): Update.
316 * utils.h (fast_hash): Add an argument for a start value,
317 defaulting to zero.
318
82f910ea
PW
3192019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
320 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
321 (destroy_block_symbol_cache): New function.
322 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
323 (resize_symbol_cache): Likewise.
324
de2396d0
TT
3252019-12-02 Tom Tromey <tom@tromey.com>
326
327 * unittests/tui-selftests.c (run_tests): Make conditional.
328 (_initialize_tui_selftest): Make conditional.
329
638d85bc
CB
3302019-12-02 Christian Biesinger <cbiesinger@google.com>
331
332 * aix-thread.c (debug_aix_thread): Change type to bool.
333
7532a164
LM
3342019-12-02 Luis Machado <luis.machado@linaro.org>
335
336 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
337
216a7e6b
AB
3382019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
339
340 * dwarf2read.c (read_tag_string_type): Read the fields required to
341 make a dynamic string, and possibly create a dynamic range for the
342 string.
343 (attr_to_dynamic_prop): Setup is_reference based on the type of
344 attribute being processed.
345 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
346 (resolve_dynamic_array): Rename to...
347 (resolve_dynamic_array_or_string): ...this, update header comment,
348 and accept TYPE_CODE_STRING.
349 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
350
11a8b164
AB
3512019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
352
353 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
354 of its implementation from...
355 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
356 the new function.
357
5bbd8269
AB
3582019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
359
360 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
361 create a range with stride where appropriate.
362 * f-valprint.c: Include 'gdbarch.h'.
363 (f77_print_array_1): Take the stride into account when walking the
364 array. Also convert the stride into addressable units.
365 * gdbtypes.c (create_range_type): Initialise the stride to
366 constant zero.
367 (create_range_type_with_stride): New function, initialise the
368 range as normal, and then setup the stride.
369 (has_static_range): Include the stride here. Also change the
370 return type to bool.
371 (create_array_type_with_stride): Consider the range stride if the
372 array isn't given its own stride.
373 (resolve_dynamic_range): Resolve the stride if needed.
374 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
375 (struct range_bounds) <flag_is_byte_stride>: New member variable.
376 (TYPE_BIT_STRIDE): Define.
377 (TYPE_ARRAY_BIT_STRIDE): Define.
378 (create_range_type_with_stride): Declare.
379 * valarith.c (value_subscripted_rvalue): Take range stride into
380 account when walking the array.
381
82e3b564
TT
3822019-12-01 Tom Tromey <tom@tromey.com>
383
384 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
385 specially.
386
517d261d
TT
3872019-12-01 Tom Tromey <tom@tromey.com>
388
389 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
390 \0.
391 * unittests/tui-selftests.c: New file.
392 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
393
484c9b64
TT
3942019-12-01 Tom Tromey <tom@tromey.com>
395
396 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
397
a2a7af0c
TT
3982019-12-01 Tom Tromey <tom@tromey.com>
399
400 * NEWS: Document new settings.
401 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
402 * tui/tui-win.c (_initialize_tui_win): Add border style
403 observers.
404 * tui/tui-io.h (tui_apply_style): Declare.
405 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
406 longer static.
407 (apply_ansi_escape, tui_set_reverse_mode): Update.
408 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
409 Add "skip_intensity" parameter.
410 <changed>: New member.
411 <do_set_value>: Declare.
412 (tui_border_style, tui_active_border_style): Declare.
413 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
414 globals.
415 (cli_style_option): Initialize "changed".
416 (cli_style_option::do_set_value): New function.
417 (cli_style_option::add_setshow_commands): Add "skip_intensity"
418 parameter. Update.
419 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
420 (_initialize_cli_style): Update. Create TUI border style
421 commands.
422
d1da6b01
TT
4232019-12-01 Tom Tromey <tom@tromey.com>
424
425 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
426 parameter.
427 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
428 parameter.
429 * tui/tui-win.h (compact_source): Declare.
430 * tui/tui-win.c (compact_source): New global.
431 (tui_set_compact_source, tui_show_compact_source): New functions.
432 (_initialize_tui_win): Add "compact-source" setting.
433 * tui/tui-source.c (tui_source_window::set_contents): Handle
434 compact_source setting.
435 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
436 * NEWS: Document new setting.
437
489dbda6
TT
4382019-11-30 Tom Tromey <tom@tromey.com>
439
440 * dwarf2read.c (dwarf2_add_field): Include field offset when
441 computing variant part length.
442
bf498525
PW
4432019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
444 * NEWS: Mention define-prefix. Tell that command names can now
445 contain a . character.
446
be09caf1
PW
4472019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
448
449 * command.h (valid_cmd_char_p): Declare.
450 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
451 the check of valid command char.
452 (find_command_name_length, valid_user_defined_cmd_name_p): Use
453 valid_cmd_char_p.
454 * cli/cli-script.c (validate_comname): Likewise.
455 * completer.c (gdb_completer_command_word_break_characters):
456 Do not remove . from the word break char, update comments.
457 (complete_line_internal_1): Use valid_cmd_char_p.
458 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
459 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
460
c6ac7fc9
PW
4612019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
462
463 * cli/cli-script.c (do_define_command): Ensure a redefined
464 prefix command is kept as a prefix command.
465 (define_prefix_command): New function.
466 (show_user_1): Report user defined prefixes.
467 (_initialize_cli_script): Create the new 'define-prefix' command.
468 Add completers for 'define' and 'document'.
469 * top.c (execute_command): If command is a user-defined prefix only
470 command, report the list of commands for this prefix command.
471
a992a3b0
TBA
4722019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
473
474 * valops.c (find_oload_champ): Improve debug output.
475
e9194a1a
TBA
4762019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
477
478 * valops.c (find_oload_champ): Print part of debug messages
479 before the badness vector is std::move'd.
480
53a008a6
TT
4812019-11-28 Tom Tromey <tom@tromey.com>
482
483 * value.c (creal_internal_fn): Fix comment.
484
bab05c83
TT
4852019-11-28 Tom Tromey <tom@tromey.com>
486
487 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
488 flag_bound_evaluated>: Now unsigned.
489
2522f049
TT
4902019-11-28 Tom Tromey <tom@tromey.com>
491
492 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
493 declare.
494
38b49e22
MS
4952019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
496
497 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
498 debug output.
499 * jit.c (jit_unregister_code): Add debug print to match
500 `jit_register_code`.
501
35125921
CB
5022019-11-27 Christian Biesinger <cbiesinger@google.com>
503
504 * NEWS: Mention the new multithreaded symbol loading.
505
62e77f56
CB
5062019-11-27 Christian Biesinger <cbiesinger@google.com>
507
508 * maint.c (n_worker_threads): Default to 0.
509 (worker_threads_disabled): New function.
510 * maint.h (worker_threads_disabled): New function.
511 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
512 here if worker_threads_disabled () is true.
513 (minimal_symbol_reader::install): Skip all threading if
514 worker_threads_disabled () is true.
515
f29d7f6b
CB
5162019-11-27 Christian Biesinger <cbiesinger@google.com>
517
518 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
519 hash code if possible.
520 (add_minsym_to_demangled_hash_table): Likewise.
521 (minimal_symbol_reader::install): Compute the hash codes for msymbol
522 on the background thread.
523 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
524 Add these fields.
525
e76b2246
CB
5262019-11-27 Christian Biesinger <cbiesinger@google.com>
527
528 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
529 of the mangled name on the background thread.
530 * symtab.c (symbol_set_names): Allow passing in the hash of the
531 linkage_name.
532 * symtab.h (symbol_set_names): Likewise.
533
8d9a2568
KB
5342019-11-27 Kevin Buettner <kevinb@redhat.com>
535
536 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
537 physnames are computed for inherited DIEs.
538
fad03f6e
TT
5392019-11-27 Tom Tromey <tromey@adacore.com>
540
541 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
542 backslashes.
543 * cp-support.c: Remove unnecessary backslashes.
544
43678b0a
CB
5452019-11-27 Christian Biesinger <cbiesinger@google.com>
546
547 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
548 with sym->set_linkage_name.
549 * coffread.c (coff_read_enum_type): Likewise.
550 * mdebugread.c (parse_symbol): Likewise.
551 * stabsread.c (patch_block_stabs): Likewise.
552 (define_symbol): Likewise.
553 (read_enum_type): Likewise.
554 (common_block_end): Likewise.
555 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
556 function.
557 (SYMBOL_SET_LINKAGE_NAME): Remove.
558 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
559 with sym->set_linkage_name.
560
db5960b4
AB
5612019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
562
563 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
564 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
565 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
566 * NEWS: Mention new MI command.
567
7dc42066
AB
5682019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
569
570 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
571 '-symbol-info-types', and '-symbol-info-variables'.
572 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
573 (mi_cmd_symbol_info_types): Declare.
574 (mi_cmd_symbol_info_variables): Declare.
575 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
576 (output_debug_symbol): New function.
577 (output_nondebug_symbol): New function.
578 (mi_symbol_info): New function.
579 (mi_info_functions_or_variables): New function.
580 (mi_cmd_symbol_info_functions): New function.
581 (mi_cmd_symbol_info_types): New function.
582 (mi_cmd_symbol_info_variables): New function.
583 * NEWS: Mention new commands.
584
5f512a7d
AB
5852019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
586
587 * symtab.c (symbol_to_info_string): New function, most content
588 moved from print_symbol_info, but updated to return a std::string.
589 (print_symbol_info): Update to use symbol_to_info_string and print
590 returned string.
591 * symtab.h (symbol_to_info_string): Declare new function.
592
470c0b1c
AB
5932019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
594
595 * python/python.c (gdbpy_rbreak): Convert to using
596 global_symbol_searcher.
597 * symtab.c (file_matches): Convert return type to bool, change
598 file list to std::vector, update header comment.
599 (search_symbols): Rename to...
600 (global_symbol_searcher::search): ...this and update now its
601 a member function of global_symbol_searcher. Take account of the
602 changes to file_matches.
603 (symtab_symbol_info): Convert to using global_symbol_searcher.
604 (rbreak_command): Likewise.
605 (search_module_symbols): Likewise.
606 * symtab.h (enum symbol_search): Update comment.
607 (search_symbols): Remove declaration.
608 (class global_symbol_searcher): New class.
609
57357d9d
TT
6102019-11-26 Tom Tromey <tromey@adacore.com>
611
612 * cp-support.c (_initialize_cp_support): Conditionally initialize
613 gdb_demangle_attempt_core_dump.
614
3ea16160
TT
6152019-11-26 Tom Tromey <tom@tromey.com>
616
617 * python/py-function.c (fnpy_init): Update.
618 * value.h (add_internal_function): Adjust declaration.
619 * value.c (function_destroyer): Remove.
620 (do_add_internal_function): Don't set destroyer or copy name.
621 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
622 Set name_allocated.
623 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
624 (cmdpy_init): Set name_allocated.
625 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
626 member.
627 (~cmd_list_element): Free "name" if needed.
628
1a6d41c6
TT
6292019-11-26 Tom Tromey <tom@tromey.com>
630
631 * value.h (add_internal_function): Add new overload. Move
632 documentation from value.h.
633 * value.c (do_add_internal_function): New function.
634 (add_internal_function): Use it. Add new overload.
635 (function_destroyer): Don't free doc.
636 * python/py-function.c (fnpy_init): Update.
637
8318f3c3
TT
6382019-11-26 Tom Tromey <tom@tromey.com>
639
640 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
641 (cmdpy_init): Set "doc_allocated".
642
4da8c3a8
TT
6432019-11-26 Tom Tromey <tom@tromey.com>
644
645 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
646 name of worker thread.
647 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
648 pthread_setname_np.
649 * configure, config.in: Rebuild.
650
971db5e2
TT
6512019-11-26 Tom Tromey <tom@tromey.com>
652
653 * python/python.c (class gdbpy_gil): New.
654 (struct gdbpy_event): Add constructor, destructor, operator().
655 (gdbpy_post_event): Use run_on_main_thread.
656 (gdbpy_initialize_events): Remove.
657 (do_start_initialization): Update.
658
22138db6
TT
6592019-11-26 Tom Tromey <tom@tromey.com>
660
661 * NEWS: Add entry.
662 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
663 commands. Call update_thread_pool_size.
664 (update_thread_pool_size, maintenance_set_worker_threads): New
665 functions.
666 (n_worker_threads): New global.
667
d55c9a68
TT
6682019-11-26 Christian Biesinger <cbiesinger@google.com>
669 Tom Tromey <tom@tromey.com>
670
671 * minsyms.c (minimal_symbol_reader::install): Use
672 parallel_for_each.
673 * gdbsupport/parallel-for.h: New file.
674 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
675
a0b57563
CB
6762019-11-26 Christian Biesinger <cbiesinger@google.com>
677 Tom Tromey <tom@tromey.com>
678
679 * gdbsupport/thread-pool.h: New file.
680 * gdbsupport/thread-pool.c: New file.
681 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
682 (HFILES_NO_SRCDIR): Add thread-pool.h.
683
3b3978bc
TT
6842019-11-26 Tom Tromey <tom@tromey.com>
685
686 * event-top.h (thread_local_segv_handler): Declare.
687 * event-top.c (thread_local_segv_handler): New global.
688 (install_handle_sigsegv, handle_sigsegv): New functions.
689 (async_init_signals): Install SIGSEGV handler.
690 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
691 thread-local.
692 (report_failed_demangle): New function.
693 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
694 handler-setting code, instead use segv_handler. Run warning code
695 on main thread.
696
9411c49e
TT
6972019-11-26 Tom Tromey <tom@tromey.com>
698
699 * run-on-main-thread.c: New file.
700 * run-on-main-thread.h: New file.
701 * unittests/main-thread-selftests.c: New file.
702 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
703 main-thread-selftests.c.
704 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
705 (COMMON_SFILES): Add run-on-main-thread.c.
706
c3efb965
TT
7072019-11-26 Tom Tromey <tom@tromey.com>
708
709 * main.c (setup_alternate_signal_stack): Remove.
710 (captured_main_1): Use gdb::alternate_signal_stack.
711 * gdbsupport/alt-stack.h: New file.
712
21987b9c
TT
7132019-11-26 Tom Tromey <tom@tromey.com>
714
715 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
716 Remove comment.
717 (save_original_signals_state, restore_original_signals_state): Use
718 gdb_sigmask.
719 * linux-nat.c (block_child_signals, restore_child_signals_mask)
720 (_initialize_linux_nat): Use gdb_sigmask.
721 * guile/guile.c (_initialize_guile): Use block_signals.
722 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
723 * gdbsupport/gdb-sigmask.h: New file.
724 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
725 * cp-support.c (gdb_demangle): Use gdb_sigmask.
726 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
727 pthread_sigmask.
728 * configure, config.in: Rebuild.
729 * gdbsupport/block-signals.h: New file.
730
5e030278
TT
7312019-11-26 Tom Tromey <tom@tromey.com>
732
733 * acinclude.m4: Include ax_pthread.m4.
734 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
735 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
736 (CLIBS): Use PTHREAD_LIBS.
737 (aclocal_m4_deps): Add ax_pthread.m4.
738 * config.in, configure: Rebuild.
739 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
740
5a79c107
TT
7412019-11-26 Tom Tromey <tom@tromey.com>
742
743 * symtab.h (struct minimal_symbol) <name_set>: New member.
744 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
745 Don't call symbol_set_names.
746 (minimal_symbol_reader::install): Call symbol_set_names.
747
aa369509
PW
7482019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
749
750 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
751 restore_active_ext_lang, as GIL is needed for (indirectly)
752 called PyOS_InterruptOccurred.
753
cadc9cb8
SM
7542019-11-26 Simon Marchi <simon.marchi@efficios.com>
755
756 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
757 definition.
758
d04afd58
SM
7592019-11-26 Simon Marchi <simon.marchi@efficios.com>
760
761 * remote-sim.c (simulator_command): Make static, remove
762 declaration.
763
dd694d77
SM
7642019-11-26 Simon Marchi <simon.marchi@efficios.com>
765
766 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
767 static.
768 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
769 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
770 (main): Likewise.
771 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
772 (main): Likewise.
773 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
774 (main): Likewise.
775 * unittests/basic_string_view/element_access/char/1.cc (test01):
776 Likewise.
777 (main): Likewise.
778 * unittests/basic_string_view/element_access/char/empty.cc (main):
779 Likewise.
780 * unittests/basic_string_view/element_access/char/front_back.cc
781 (test01): Likewise.
782 (main): Likewise.
783 * unittests/basic_string_view/inserters/char/2.cc (test05):
784 Likewise.
785 (main): Likewise.
786 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
787 (test01): Likewise.
788 (main): Likewise.
789 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
790 (test01): Likewise.
791 (main): Likewise.
792 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
793 Likewise.
794 * unittests/basic_string_view/operations/compare/char/1.cc
795 (test01): Likewise.
796 (main): Likewise.
797 * unittests/basic_string_view/operations/compare/char/13650.cc
798 (test01): Likewise.
799 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
800 Likewise.
801 (main): Likewise.
802 * unittests/basic_string_view/operations/data/char/1.cc (test01):
803 Likewise.
804 (main): Likewise.
805 * unittests/basic_string_view/operations/find/char/1.cc (test01):
806 Likewise.
807 (main): Likewise.
808 * unittests/basic_string_view/operations/find/char/2.cc (test02):
809 Likewise.
810 (main): Likewise.
811 * unittests/basic_string_view/operations/find/char/3.cc (test03):
812 Likewise.
813 (main): Likewise.
814 * unittests/basic_string_view/operations/find/char/4.cc (main):
815 Likewise.
816 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
817 Likewise.
818 (main): Likewise.
819 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
820 Likewise.
821 (main): Likewise.
822 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
823 Likewise.
824 (main): Likewise.
825 * unittests/basic_string_view/operations/substr/char/1.cc
826 (test01): Likewise.
827 (main): Likewise.
828 * unittests/basic_string_view/operators/char/2.cc (main):
829 Likewise.
830 * unittests/optional/assignment/1.cc (test): Likewise.
831 * unittests/optional/assignment/2.cc (test): Likewise.
832 * unittests/optional/assignment/3.cc (test): Likewise.
833 * unittests/optional/assignment/4.cc (test): Likewise.
834 * unittests/optional/assignment/5.cc (test): Likewise.
835 * unittests/optional/assignment/6.cc (test): Likewise.
836 * unittests/optional/assignment/7.cc (test): Likewise.
837 * unittests/optional/cons/copy.cc (test): Likewise.
838 * unittests/optional/cons/default.cc (test): Likewise.
839 * unittests/optional/cons/move.cc (test): Likewise.
840 * unittests/optional/cons/value.cc (test): Likewise.
841 * unittests/optional/in_place.cc (test): Likewise.
842 * unittests/optional/observers/1.cc (test): Likewise.
843 * unittests/optional/observers/2.cc (test): Likewise.
844
3b5c1d49
SM
8452019-11-26 Simon Marchi <simon.marchi@efficios.com>
846
847 * tui-win.h (tui_set_var_cmd): Remove.
848 * tui-win.c (tui_set_var_cmd): Make static.
849
adce99fe
SM
8502019-11-26 Simon Marchi <simon.marchi@efficios.com>
851
852 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
853 rbreak_command_wrapper): Remove.
854 * symtab.c (rbreak_command_wrapper): Remove.
855
fe3adccf
SM
8562019-11-26 Simon Marchi <simon.marchi@efficios.com>
857
858 * inferior.h (info_terminal_command): Remove declaration.
859 * inflow.c (info_terminal_command): Make static.
860
b926335f
SM
8612019-11-26 Simon Marchi <simon.marchi@efficios.com>
862
863 * inferior.c (exit_inferior_silent): Remove.
864
b62f6f54
SM
8652019-11-26 Simon Marchi <simon.marchi@efficios.com>
866
867 * dictionary.c (dict_empty, mdict_empty): Remove.
868 * dictionary.c (mdict_empty): Remove.
869
cb8c24b6
SM
8702019-11-26 Simon Marchi <simon.marchi@efficios.com>
871
872 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
873 (arc_insn_get_memory_offset): Likewise.
874 (arc_insn_dump): Likewise.
875 * cp-support.c (test_cp_symbol_name_matches): Likewise.
876 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
877 * dictionary.c (dict_iterator_next): Likewise.
878 (dict_iter_match_first): Likewise.
879 (dict_iter_match_next): Likewise.
880 * f-lang.c (evaluate_subexp_f): Likewise.
881 * hppa-tdep.c (hppa_read_pc): Likewise.
882 * i386-tdep.c (i386_floatformat_for_type): Likewise.
883 * parse.c (write_exp_elt_msym): Likewise.
884 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
885 * remote.c (remote_packet_size): Likewise.
886 (remote_notif_stop_parse): Likewise.
887 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
888 * s12z-tdep.c (s12z_disassemble_info): Likewise.
889 * source.c (prepare_path_for_appending): Likewise.
890 * sparc64-linux-tdep.c
891 (sparc64_linux_handle_segmentation_fault); Likewise.
892 * stack.c (frame_selection_by_function_completer): Likewise.
893
781597ff
SM
8942019-11-26 Simon Marchi <simon.marchi@efficios.com>
895
896 * completer.c (set_gdb_completion_word_break_characters):
897 Remove.
898
23baa4cc
SM
8992019-11-26 Simon Marchi <simon.marchi@efficios.com>
900
901 * dwarf-index-write.c: Include dwarf-index-write.h.
902 * mi/mi-interp.c: Include mi/mi-interp.h.
903
23767560
SM
9042019-11-26 Simon Marchi <simon.marchi@efficios.com>
905
906 * aarch32-tdep.c: Include aarch32-tdep.h.
907 * aarch32-tdep.h: Forward-declare struct target_desc.
908
6d91ce9a
CB
9092019-11-26 Christian Biesinger <cbiesinger@google.com>
910
911 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
912 strerror.
913 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
914 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
915
3cf2f237
TV
9162019-11-25 Tom de Vries <tdevries@suse.de>
917
918 * contrib/words.sh: Add -c option.
919
5b89c67a
CB
9202019-11-25 Christian Biesinger <cbiesinger@google.com>
921
922 * solib.c (solib_find_1): Change int to bool.
923 (exec_file_find): Change int to bool.
924 (solib_find): Change int to bool.
925 (solib_read_symbols): Change int to bool.
926 (solib_used): Change int to bool.
927 (solib_add): Change int to bool.
928 (info_sharedlibrary_command): Change int to bool.
929 (solib_contains_address_p): Change int to bool.
930 (solib_keep_data_in_core): Change int to bool.
931 (in_solib_dynsym_resolve_code): Change int to bool.
932 (reload_shared_libraries_1): Change int to bool.
933 (gdb_sysroot_changed): Change int to bool.
934 * solib.h (solib_read_symbols): Change int to bool.
935 (solib_contains_address_p): Change int to bool.
936 (solib_keep_data_in_core): Change int to bool.
937 (in_solib_dynsym_resolve_code): Change int to bool.
938 (libpthread_name_p): Change int to bool.
939
6cc8564b
LM
9402019-11-25 Luis Machado <luis.machado@linaro.org>
941
942 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
943 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
944 (remote_packet_max_chars): New static global.
945 (show_remote_packet_max_chars): New function.
946 (remote_target::putpkt_binary): Adjust to use new
947 remote_packet_max_chars option.
948 (remote_target::getpkt_or_notif_sane_1): Likewise.
949 (_initialize_remote): Register new remote-packet-max-chars option.
950
a7cdaa91
SM
9512019-11-24 Simon Marchi <simon.marchi@efficios.com>
952
953 * m68k-linux-nat.c: Include gdbarch.h.
954
26abc753
TT
9552019-11-24 Tom Tromey <tom@tromey.com>
956
957 * symfile.c (read_symbols): Update.
958 * psymtab.c (require_partial_symbols): Change type of "verbose" to
959 bool.
960 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
961 (psym_lookup_symbol, psym_find_last_source_symtab)
962 (psym_forget_cached_source_info, psym_print_stats)
963 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
964 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
965 (psym_map_matching_symbols, psym_expand_symtabs_matching)
966 (psym_find_compunit_symtab_by_address)
967 (maintenance_print_psymbols, maintenance_info_psymtabs)
968 (maintenance_check_psymtabs): Update.
969 * psymtab.h (require_partial_symbols): Change type of "verbose" to
970 bool.
971
012fc909
TT
9722019-11-22 Tom Tromey <tom@tromey.com>
973
974 * observable.h: Update comments.
975
c83d8d32
TT
9762019-11-22 Tom Tromey <tromey@adacore.com>
977
978 * ada-tasks.c (ada_task_is_alive): Make parameter const.
979 (print_ada_task_info): Don't try to fetch thread id if task is not
980 alive.
981
987012b8
CB
9822019-11-22 Christian Biesinger <cbiesinger@google.com>
983
984 * ada-exp.y: Update.
985 * ada-lang.c (sort_choices): Update.
986 (ada_print_symbol_signature): Update.
987 (resolve_subexp): Update.
988 (ada_parse_renaming): Update.
989 (ada_read_renaming_var_value): Update.
990 (lesseq_defined_than): Update.
991 (remove_extra_symbols): Update.
992 (remove_irrelevant_renamings): Update.
993 (ada_add_block_symbols): Update.
994 (ada_collect_symbol_completion_matches): Update.
995 (ada_is_renaming_symbol): Update.
996 (aggregate_assign_from_choices): Update.
997 (ada_evaluate_subexp): Update.
998 (ada_has_this_exception_support): Update.
999 (ada_is_non_standard_exception_sym): Update.
1000 (ada_add_exceptions_from_frame): Update.
1001 (ada_add_global_exceptions): Update.
1002 (ada_print_subexp): Update.
1003 * ax-gdb.c (gen_var_ref): Update.
1004 (gen_maybe_namespace_elt): Update.
1005 (gen_expr_for_cast): Update.
1006 (gen_expr): Update.
1007 * block.h: Update.
1008 * blockframe.c (find_pc_partial_function): Update.
1009 * breakpoint.c (print_breakpoint_location): Update.
1010 (update_static_tracepoint): Update.
1011 * btrace.c (ftrace_print_function_name): Update.
1012 (ftrace_function_switched): Update.
1013 * buildsym.c (find_symbol_in_list): Update.
1014 * c-exp.y: Update.
1015 * c-typeprint.c (c_print_typedef): Update.
1016 (c_type_print_template_args): Update.
1017 * cli/cli-cmds.c (edit_command): Update.
1018 (list_command): Update.
1019 (print_sal_location): Update.
1020 * coffread.c (patch_opaque_types): Update.
1021 (process_coff_symbol): Update.
1022 (coff_read_enum_type): Update.
1023 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1024 (convert_one_symbol): Update.
1025 (hash_symname): Update.
1026 (eq_symname): Update.
1027 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1028 * compile/compile-cplus-types.c (debug_print_scope): Update.
1029 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1030 * compile/compile-object-load.c (get_out_value_type): Update.
1031 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1032 (search_symbol_list): Update.
1033 (cp_lookup_symbol_imports_or_template): Update.
1034 * cp-support.c (overload_list_add_symbol): Update.
1035 * ctfread.c (psymtab_to_symtab): Update.
1036 * dbxread.c (cp_set_block_scope): Update.
1037 * dictionary.c (iter_match_first_hashed): Update.
1038 (iter_match_next_hashed): Update.
1039 (insert_symbol_hashed): Update.
1040 (iter_match_next_linear): Update.
1041 * dictionary.h: Update.
1042 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1043 (locexpr_describe_location_piece): Update.
1044 (locexpr_describe_location_1): Update.
1045 (locexpr_generate_c_location): Update.
1046 (loclist_describe_location): Update.
1047 (loclist_generate_c_location): Update.
1048 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1049 (read_func_scope): Update.
1050 (process_enumeration_scope): Update.
1051 (new_symbol): Update.
1052 (dwarf2_const_value): Update.
1053 (dwarf2_symbol_mark_computed): Update.
1054 * eval.c (evaluate_funcall): Update.
1055 (evaluate_subexp_standard): Update.
1056 * expprint.c (print_subexp_standard): Update.
1057 (dump_subexp_body_standard): Update.
1058 * f-valprint.c (info_common_command_for_block): Update.
1059 * findvar.c (get_hosting_frame): Update.
1060 (default_read_var_value): Update.
1061 * go-lang.c (go_symbol_package_name): Update.
1062 * guile/scm-block.c (bkscm_print_block_smob): Update.
1063 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1064 (gdbscm_symbol_name): Update.
1065 (gdbscm_symbol_linkage_name): Update.
1066 (gdbscm_symbol_print_name): Update.
1067 * infcall.c (get_function_name): Update.
1068 * infcmd.c (jump_command): Update.
1069 (finish_command): Update.
1070 * infrun.c (insert_exception_resume_breakpoint): Update.
1071 * linespec.c (canonicalize_linespec): Update.
1072 (create_sals_line_offset): Update.
1073 (convert_linespec_to_sals): Update.
1074 (complete_label): Update.
1075 (find_label_symbols_in_block): Update.
1076 * m2-typeprint.c (m2_print_typedef): Update.
1077 * mdebugread.c (mdebug_reg_to_regnum): Update.
1078 (parse_symbol): Update.
1079 (mylookup_symbol): Update.
1080 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1081 (list_args_or_locals): Update.
1082 * objc-lang.c (compare_selectors): Update.
1083 (info_selectors_command): Update.
1084 (compare_classes): Update.
1085 (info_classes_command): Update.
1086 (find_imps): Update.
1087 * p-typeprint.c (pascal_print_typedef): Update.
1088 * printcmd.c (build_address_symbolic): Update.
1089 (info_address_command): Update.
1090 (print_variable_and_value): Update.
1091 * python/py-framefilter.c (extract_sym): Update.
1092 (py_print_single_arg): Update.
1093 * python/py-symbol.c (sympy_str): Update.
1094 (sympy_get_name): Update.
1095 (sympy_get_linkage_name): Update.
1096 * python/python.c (gdbpy_rbreak): Update.
1097 * record-btrace.c (btrace_get_bfun_name): Update.
1098 (btrace_call_history): Update.
1099 * rust-lang.c (rust_print_typedef): Update.
1100 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1101 * stabsread.c (stab_reg_to_regnum): Update.
1102 (define_symbol): Update.
1103 (read_enum_type): Update.
1104 (common_block_end): Update.
1105 (cleanup_undefined_types_1): Update.
1106 (scan_file_globals): Update.
1107 * stack.c (print_frame_arg): Update.
1108 (print_frame_args): Update.
1109 (find_frame_funname): Update.
1110 (info_frame_command_core): Update.
1111 (iterate_over_block_locals): Update.
1112 (print_block_frame_labels): Update.
1113 (do_print_variable_and_value): Update.
1114 (iterate_over_block_arg_vars): Update.
1115 (return_command): Update.
1116 * symmisc.c (dump_symtab_1): Update.
1117 (print_symbol): Update.
1118 * symtab.c (eq_symbol_entry): Update.
1119 (symbol_cache_dump): Update.
1120 (lookup_language_this): Update.
1121 (find_pc_sect_line): Update.
1122 (skip_prologue_sal): Update.
1123 (symbol_search::compare_search_syms): Update.
1124 (treg_matches_sym_type_name): Update.
1125 (search_symbols): Update.
1126 (print_symbol_info): Update.
1127 (rbreak_command): Update.
1128 (completion_list_add_symbol): Update.
1129 (find_gnu_ifunc): Update.
1130 (get_symbol_address): Update.
1131 (search_module_symbols): Update.
1132 (info_module_subcommand): Update.
1133 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1134 (SYMBOL_LINKAGE_NAME): Remove.
1135 (SYMBOL_DEMANGLED_NAME): Remove.
1136 (SYMBOL_PRINT_NAME): Remove.
1137 (SYMBOL_SEARCH_NAME): Remove.
1138 * tracepoint.c (set_traceframe_context): Update.
1139 (validate_actionline): Update.
1140 (collection_list::collect_symbol): Update.
1141 (encode_actions_1): Update.
1142 (info_scope_command): Update.
1143 (print_one_static_tracepoint_marker): Update.
1144 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1145 * valops.c (address_of_variable): Update.
1146 (find_overload_match): Update.
1147 (find_oload_champ): Update.
1148
c9d95fa3
CB
11492019-11-22 Christian Biesinger <cbiesinger@google.com>
1150
1151 * ada-lang.c (ada_lookup_simple_minsym): Update.
1152 (ada_collect_symbol_completion_matches): Update.
1153 * ada-tasks.c (read_atcb): Update.
1154 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1155 (amd64_windows_skip_trampoline_code): Update.
1156 * arm-tdep.c (skip_prologue_function): Update.
1157 (arm_skip_stack_protector): Update.
1158 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1159 (arm_wince_skip_main_prologue): Update.
1160 * ax-gdb.c (gen_expr): Update.
1161 * block.c (call_site_for_pc): Update.
1162 * blockframe.c (find_pc_partial_function): Update.
1163 * breakpoint.c (set_breakpoint_location_function): Update.
1164 * btrace.c (ftrace_print_function_name): Update.
1165 (ftrace_function_switched): Update.
1166 * c-valprint.c (print_unpacked_pointer): Update.
1167 * coffread.c (coff_symfile_read): Update.
1168 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1169 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1170 * dwarf-index-write.c (write_psymbols): Update.
1171 * dwarf2loc.c (call_site_to_target_addr): Update.
1172 (func_verify_no_selftailcall): Update.
1173 (tailcall_dump): Update.
1174 (call_site_find_chain_1): Update.
1175 (dwarf_expr_reg_to_entry_parameter): Update.
1176 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1177 * eval.c (evaluate_funcall): Update.
1178 (evaluate_subexp_standard): Update.
1179 (evaluate_subexp_for_sizeof): Update.
1180 * expprint.c (print_subexp_standard): Update.
1181 (dump_subexp_body_standard): Update.
1182 * frame.c (get_prev_frame_always_1): Update.
1183 * frv-tdep.c (frv_skip_main_prologue): Update.
1184 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1185 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1186 (gnuv3_get_typename_from_type_info): Update.
1187 (gnuv3_skip_trampoline): Update.
1188 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1189 * i386-tdep.c (i386_skip_main_prologue): Update.
1190 (i386_pe_skip_trampoline_code): Update.
1191 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1192 * infcall.c (get_function_name): Update.
1193 * linespec.c (minsym_found): Update.
1194 * linux-fork.c (info_checkpoints_command): Update.
1195 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1196 (m32c_m16c_pointer_to_address): Update.
1197 * maint.c (maintenance_translate_address): Update.
1198 * minsyms.c (add_minsym_to_hash_table): Update.
1199 (add_minsym_to_demangled_hash_table): Update.
1200 (lookup_minimal_symbol_mangled): Update.
1201 (lookup_minimal_symbol_demangled): Update.
1202 (lookup_minimal_symbol_linkage): Update.
1203 (lookup_minimal_symbol_text): Update.
1204 (lookup_minimal_symbol_by_pc_name): Update.
1205 (minimal_symbol_is_less_than): Update.
1206 (compact_minimal_symbols): Update.
1207 (build_minimal_symbol_hash_tables): Update.
1208 (find_solib_trampoline_target): Update.
1209 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1210 (mips_skip_pic_trampoline_code): Update.
1211 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1212 * objc-lang.c (info_selectors_command): Update.
1213 (info_classes_command): Update.
1214 (find_methods): Update.
1215 (find_imps): Update.
1216 * p-valprint.c (pascal_val_print): Update.
1217 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1218 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1219 * printcmd.c (build_address_symbolic): Update.
1220 (info_symbol_command): Update.
1221 * psymtab.c (psymbol_name_matches): Update.
1222 (match_partial_symbol): Update.
1223 (lookup_partial_symbol): Update.
1224 (print_partial_symbols): Update.
1225 (sort_pst_symbols): Update.
1226 (maintenance_check_psymtabs): Update.
1227 * python/py-framefilter.c (py_print_frame): Update.
1228 * python/python.c (gdbpy_rbreak): Update.
1229 * record-btrace.c (btrace_get_bfun_name): Update.
1230 (btrace_call_history): Update.
1231 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1232 (rs6000_skip_trampoline_code): Update.
1233 * sol-thread.c (info_cb): Update.
1234 * stabsread.c (scan_file_globals): Update.
1235 * stack.c (find_frame_funname): Update.
1236 (info_frame_command_core): Update.
1237 * symmisc.c (dump_msymbols): Update.
1238 * symtab.c (symbol_natural_name): Rename to..,
1239 (general_symbol_info::natural_name): ...this.
1240 (symbol_demangled_name): Rename to...
1241 (general_symbol_info::demangled_name): ...this.
1242 (symbol_search_name): Rename to...
1243 (general_symbol_info::search_name): ...this.
1244 (symbol_matches_search_name): Update.
1245 (find_pc_sect_line): Update.
1246 (skip_prologue_sal): Update.
1247 (search_symbols): Update.
1248 (print_msymbol_info): Update.
1249 (rbreak_command): Update.
1250 (completion_list_add_msymbol): Update.
1251 (completion_list_objc_symbol): Update.
1252 (get_msymbol_address): Update.
1253 * symtab.h (struct general_symbol_info): Add member functions
1254 natural_name (), linkage_name (), print_name (), demangled_name (),
1255 and search_name ().
1256 (SYMBOL_NATURAL_NAME): Update.
1257 (symbol_natural_name): Move to a member function on general_symbol_info.
1258 (SYMBOL_DEMANGLED_NAME): Update.
1259 (symbol_demangled_name): Move to a member function on
1260 general_symbol_info.
1261 (SYMBOL_SEARCH_NAME): Update.
1262 (symbol_search_name): Move to a member function on general_symbol_info.
1263 (MSYMBOL_NATURAL_NAME): Remove.
1264 (MSYMBOL_LINKAGE_NAME): Remove.
1265 (MSYMBOL_PRINT_NAME): Remove.
1266 (MSYMBOL_DEMANGLED_NAME): Remove.
1267 (MSYMBOL_SEARCH_NAME): Remove.
1268 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1269
f8bab2d6
CB
12702019-11-22 Christian Biesinger <cbiesinger@google.com>
1271
1272 * symtab.c (create_demangled_names_hash): Use per_bfd->
1273 minimal_symbol_count for computing the initial size, if greater
1274 than our default size.
1275
85e7588d
TV
12762019-11-22 Tom de Vries <tdevries@suse.de>
1277
1278 * contrib/words.sh: Improve words extraction.
1279
f6180073
TV
12802019-11-22 Tom de Vries <tdevries@suse.de>
1281
1282 * contrib/words.sh: Combine sed invocations.
1283
f10ffa41
CB
12842019-11-21 Christian Biesinger <cbiesinger@google.com>
1285
1286 * Makefile.in: Update.
1287 * demangle.c: Rename to...
1288 * gdb-demangle.c: ..this.
1289 (is_cplus_marker): Change return type to bool.
1290 (_initialize_demangler): Rename to...
1291 (_initialize_gdb_demangle): ...this.
1292 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1293 * symtab.h (demangle): Remove declaration; instead include
1294 gdb-demangle.h.
1295
6ba18521
TT
12962019-11-21 Tom Tromey <tromey@adacore.com>
1297
1298 * gdbsupport/format.c (format_pieces): Parse %I64d.
1299 * unittests/format_pieces-selftests.c (test_windows_formats): New
1300 function.
1301 (run_tests): Call it.
1302
34877895
PJ
13032019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1304
1305 Byte reverse display of variables with DW_END_big, DW_END_little
1306 (DW_AT_endianity) dwarf attributes if different than the native
1307 byte order.
1308 * ada-lang.c (ada_value_binop):
1309 Use type_byte_order instead of gdbarch_byte_order.
1310 * ada-valprint.c (printstr):
1311 (ada_val_print_string):
1312 * ada-lang.c (value_pointer):
1313 (ada_value_binop):
1314 Use type_byte_order instead of gdbarch_byte_order.
1315 * c-lang.c (c_get_string):
1316 Use type_byte_order instead of gdbarch_byte_order.
1317 * c-valprint.c (c_val_print_array):
1318 Use type_byte_order instead of gdbarch_byte_order.
1319 * cp-valprint.c (cp_print_class_member):
1320 Use type_byte_order instead of gdbarch_byte_order.
1321 * dwarf2loc.c (rw_pieced_value):
1322 Use type_byte_order instead of gdbarch_byte_order.
1323 * dwarf2read.c (read_base_type): Handle DW_END_big,
1324 DW_END_little
1325 * f-lang.c (f_get_encoding):
1326 Use type_byte_order instead of gdbarch_byte_order.
1327 * findvar.c (default_read_var_value):
1328 Use type_byte_order instead of gdbarch_byte_order.
1329 * gdbtypes.c (check_types_equal):
1330 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1331 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1332 and TYPE_ENDIANITY_LITTLE if set.
1333 (type_byte_order): new function.
1334 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1335 (struct main_type) <flag_endianity_not_default>:
1336 New field.
1337 (type_byte_order): New function.
1338 * infcmd.c (default_print_one_register_info):
1339 Use type_byte_order instead of gdbarch_byte_order.
1340 * p-lang.c (pascal_printstr):
1341 Use type_byte_order instead of gdbarch_byte_order.
1342 * p-valprint.c (pascal_val_print):
1343 Use type_byte_order instead of gdbarch_byte_order.
1344 * printcmd.c (print_scalar_formatted):
1345 Use type_byte_order instead of gdbarch_byte_order.
1346 * solib-darwin.c (darwin_current_sos):
1347 Use type_byte_order instead of gdbarch_byte_order.
1348 * solib-svr4.c (solib_svr4_r_ldsomap):
1349 Use type_byte_order instead of gdbarch_byte_order.
1350 * stap-probe.c (stap_modify_semaphore):
1351 Use type_byte_order instead of gdbarch_byte_order.
1352 * target-float.c (target_float_same_format_p):
1353 Use type_byte_order instead of gdbarch_byte_order.
1354 * valarith.c (scalar_binop):
1355 (value_bit_index):
1356 Use type_byte_order instead of gdbarch_byte_order.
1357 * valops.c (value_cast):
1358 Use type_byte_order instead of gdbarch_byte_order.
1359 * valprint.c (generic_emit_char):
1360 (generic_printstr):
1361 (val_print_string):
1362 Use type_byte_order instead of gdbarch_byte_order.
1363 * value.c (unpack_long):
1364 (unpack_bits_as_long):
1365 (unpack_value_bitfield):
1366 (modify_field):
1367 (pack_long):
1368 (pack_unsigned_long):
1369 Use type_byte_order instead of gdbarch_byte_order.
1370 * findvar.c (unsigned_pointer_to_address):
1371 (signed_pointer_to_address):
1372 (unsigned_address_to_pointer):
1373 (address_to_signed_pointer):
1374 (default_read_var_value):
1375 (default_value_from_register):
1376 Use type_byte_order instead of gdbarch_byte_order.
1377 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1378 Use type_byte_order instead of gdbarch_byte_order.
1379 * riscv-tdep.c (riscv_print_one_register_info):
1380 Use type_byte_order instead of gdbarch_byte_order.
1381
87fb00ea
SM
13822019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1383
1384 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1385 (current_ui_gdb_stdin_ptr): Likewise.
1386 (current_ui_gdb_stderr_ptr): Likewise.
1387 (current_ui_gdb_stdlog_ptr): Likewise.
1388 (current_ui_current_uiout_ptr): Likewise.
1389 (gen_ret_current_ui_field_ptr): Remove.
1390
65d1cd5f
TV
13912019-11-21 Tom de Vries <tdevries@suse.de>
1392
1393 PR gdb/24956
1394 * cli/cli-script.c (execute_control_command): Only switch to
1395 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1396
9f6ad286
TT
13972019-11-19 Tom Tromey <tom@tromey.com>
1398
1399 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1400 Now static. Change type of "name".
1401 (tui_set_win_height_command): Don't copy "arg".
1402 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1403 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1404
435d3d88
AT
14052019-11-19 Ali Tamur <tamur@google.com>
1406
1407 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1408 "if (attr != nullptr)".
1409 (dwarf2_find_base_address): Likewise.
1410 (dwarf2_build_include_psymtabs): Likewise.
1411 (read_cutu_die_from_dwo): Likewise.
1412 (read_func_scope): Likewise.
1413 (read_call_site_scope): Likewise.
1414 (dwarf2_get_pc_bounds): Likewise.
1415 (dwarf2_record_block_ranges): Likewise.
1416 (dwarf2_add_field): Likewise.
1417 (dwarf2_add_member_fn): Likewise.
1418 (read_structure_type): Likewise.
1419 (read_enumeration_type): Likewise.
1420 (read_array_type): Likewise.
1421 (read_array_order): Likewise.
1422 (read_set_type): Likewise.
1423 (read_common_block): Likewise.
1424 (read_tag_reference_type): Likewise.
1425 (read_tag_string_type): Likewise.
1426 (read_subroutine_type): Likewise.
1427 (read_base_type): Likewise.
1428 (read_subrange_type): Likewise.
1429 (new_symbol): Likewise.
1430 (prepare_one_comp_unit): Likewise.
1431
c9739b6a
TT
14322019-11-19 Tom Tromey <tromey@adacore.com>
1433
1434 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1435 result in error when DebugActiveProcess fails.
1436
494409bb
SDJ
14372019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1438 Pedro Alves <palves@redhat.com>
1439
1440 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1441 * target.c (target_stack::push): Call 'unpush' if there's a
1442 target on top of the stack.
1443
2e953aca
PW
14442019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1445
1446 * python/py-block.c (blpy_dealloc): Call tp_free.
1447 (blpy_block_syms_dealloc): Likewise.
1448 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1449 * python/py-inferior.c (infpy_dealloc): Likewise.
1450 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1451 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1452 * python/py-symbol.c (sympy_dealloc): Likewise.
1453 * python/py-symtab.c (stpy_dealloc): Likewise.
1454 * python/py-type.c (typy_iterator_dealloc): Likewise.
1455
6edc43ec
CB
14562019-11-18 Christian Biesinger <cbiesinger@google.com>
1457
1458 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1459 constructor instead of using a class initializer.
1460
cd850b40
CB
14612019-11-15 Christian Biesinger <cbiesinger@google.com>
1462
1463 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1464 * configure: Regenerate.
1465 * configure.ac: Don't source common.host.
1466 * gdbsupport/common.host: Remove.
1467 * gdbsupport/mingw-strerror.c: Remove.
1468 * gdbsupport/posix-strerror.c: Rename to...
1469 * gdbsupport/safe-strerror.c: ...this.
1470
53fea9c7
CB
14712019-11-15 Christian Biesinger <cbiesinger@google.com>
1472
1473 * maint.c (scoped_command_stats::print_time): Use localtime_r
1474 instead of localtime (provided through gnulib if necessary).
1475 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1476 of ctime.
1477
f8e27d88
CB
14782019-11-15 Christian Biesinger <cbiesinger@google.com>
1479
1480 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1481 avoid compile errors.
1482
5abebf3c
CB
14832019-11-15 Christian Biesinger <cbiesinger@google.com>
1484
1485 * config.in: Regenerate.
1486 * configure: Regenerate.
1487 * gdbsupport/common.m4: No longer check for strerror_r.
1488 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1489 POSIX version of strerror_r, now that gnulib provides it if
1490 necessary.
1491
9a351667
CB
14922019-11-14 Christian Biesinger <cbiesinger@google.com>
1493
1494 * README (`configure' options): Update.
1495
55708e99
TT
14962019-11-14 Tom Tromey <tromey@adacore.com>
1497
1498 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1499 expected type for the RHS if the LHS is a convenience variable.
1500
4b09bb2e
SM
15012019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1502
1503 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1504 Provide explicit default and copy constructor.
1505
bd454f8b
PW
15062019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1507
1508 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1509 only call Py_INCREF (newbp) in the bppy_pending_object case.
1510
d1aa3cf0
TT
15112019-11-13 Tom Tromey <tromey@adacore.com>
1512
1513 PR build/25182:
1514 * psympriv.h (partial_symbol): Remove static assert.
1515 * symtab.h (general_symbol_info, symbol): Remove static assert.
1516
e06f3d6e
AB
15172019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1518
1519 * gdbsupport/format.c (format_pieces::format_pieces): Support
1520 printf 'z' size modifier.
1521 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1522 * printcmd.c (ui_printf): Handle size_t_arg.
1523 * ui-out.c (ui_out::vmessage): Likewise.
1524 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1525 function.
1526 (run_tests): Call test_format_int_sizes.
1527
468c0cbb
CB
15282019-11-12 Christian Biesinger <cbiesinger@google.com>
1529
1530 * ada-exp.y (write_ambiguous_var): Update.
1531 * buildsym.c (add_symbol_to_list): Update.
1532 * dwarf2read.c (read_variable): Update.
1533 (new_symbol): Update.
1534 * jit.c (finalize_symtab): Update.
1535 * language.c (language_alloc_type_symbol): Update.
1536 * symtab.c (fixup_symbol_section): Update.
1537 (initialize_objfile_symbol_1): Move code to...
1538 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1539 (allocate_symbol): Update.
1540 (allocate_template_symbol): Update.
1541 (get_symbol_address): Update.
1542 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1543 of having as a field, and add a constructor.
1544 (SYMBOL_VALUE): Update.
1545 (SYMBOL_VALUE_ADDRESS): Update.
1546 (SET_SYMBOL_VALUE_ADDRESS): Update.
1547 (SYMBOL_VALUE_BYTES): Update.
1548 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1549 (SYMBOL_BLOCK_VALUE): Update.
1550 (SYMBOL_VALUE_CHAIN): Update.
1551 (SYMBOL_LANGUAGE): Update.
1552 (SYMBOL_SECTION): Update.
1553 (SYMBOL_OBJ_SECTION): Update.
1554 (SYMBOL_SET_LANGUAGE): Update.
1555 (SYMBOL_SET_LINKAGE_NAME): Update.
1556 (SYMBOL_SET_NAMES): Update.
1557 (SYMBOL_NATURAL_NAME): Update.
1558 (SYMBOL_LINKAGE_NAME): Update.
1559 (SYMBOL_DEMANGLED_NAME): Update.
1560 (SYMBOL_SEARCH_NAME): Update.
1561 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1562 (struct symbol): Update.
1563 (struct template_symbol): Update.
1564 (struct rust_vtable_symbol): Update.
1565 * xcoffread.c (SYMBOL_DUP): Update.
1566
ed2c82c3
TT
15672019-11-12 Tom Tromey <tom@tromey.com>
1568
1569 * tui/tui-layout.c (show_layout): Set current_layout.
1570 (show_source_disasm_command, show_data)
1571 (show_source_or_disasm_and_command): Don't set current_layout.
1572
d9fcefd5
TT
15732019-11-12 Tom Tromey <tom@tromey.com>
1574
1575 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1576
45e42163
TT
15772019-11-12 Tom Tromey <tom@tromey.com>
1578
1579 * tui/tui-win.c (resize_message): New global.
1580 (show_tui_resize_message): New function.
1581 (tui_async_resize_screen): Print message if requested.
1582 (_initialize_tui_win): Add tui-resize-message setting.
1583 * NEWS: Add entry for new commands.
1584
c86d74cc
TT
15852019-11-11 Tom Tromey <tom@tromey.com>
1586
1587 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1588 functions.
1589
7b7b9424
CB
15902019-11-11 Christian Biesinger <cbiesinger@google.com>
1591
1592 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1593
086baaf1
AB
15942019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1595
1596 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1597 function.
1598 * python/python-internal.h (gdbpy_lookup_static_symbols):
1599 Declare new function.
1600 * python/python.c (python_GdbMethods): Add
1601 gdb.lookup_static_symbols method.
1602 * NEWS: Mention gdb.lookup_static_symbols.
1603
09ff83af
AB
16042019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1605
1606 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1607 static block of current object file first. Also fix typo in
1608 header comment.
1609
eb2dd8df
AB
16102019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1611
1612 * stack.c (set_last_displayed_sal): Delete.
1613 (last_displayed_sal_valid): Delete.
1614 (last_displayed_pspace): Delete.
1615 (last_displayed_addr): Delete.
1616 (last_displayed_symtab): Delete.
1617 (last_displayed_line): Delete.
1618 (class last_displayed_symtab_info_type): New.
1619 (last_displayed_symtab_info): New static global variable.
1620 (print_frame_info): Call methods on last_displayed_symtab_info.
1621 (clear_last_displayed_sal): Update header comment, and make use of
1622 last_displayed_symtab_info.
1623 (last_displayed_sal_is_valid): Likewise.
1624 (get_last_displayed_pspace): Likewise.
1625 (get_last_displayed_addr): Likewise.
1626 (get_last_displayed_symtab): Likewise.
1627 (get_last_displayed_line): Likewise.
1628 (get_last_displayed_sal): Likewise.
1629 * stack.h (clear_last_displayed_sal): Update header comment.
1630 (last_displayed_sal_is_valid): Likewise.
1631 (get_last_displayed_pspace): Likewise.
1632 (get_last_displayed_addr): Likewise.
1633 (get_last_displayed_symtab): Likewise.
1634 (get_last_displayed_line): Likewise.
1635 (get_last_displayed_sal): Likewise.
1636
62137775
AB
16372019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1638
1639 * stack.c (frame_show_address): Convert return type to bool.
1640 * stack.h (frame_show_address): Likewise, and update header
1641 comment.
1642
cf57ad6d
AB
16432019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1644
1645 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1646 * unittests/vec-utils-selftests.c: New file.
1647 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1648
0b026263
TT
16492019-11-10 Tom Tromey <tom@tromey.com>
1650
1651 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1652 (tui_highlight_win): Likewise.
1653 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1654 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1655 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1656 Don't set can_highlight.
1657
b049ce2d
TT
16582019-11-10 Tom Tromey <tom@tromey.com>
1659
1660 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1661 Remove unused declaration.
1662
992a7040
TT
16632019-11-08 Tom Tromey <tromey@adacore.com>
1664
1665 * top.c (read_command_file): Update.
1666 (command_line_input): Make return type const.
1667 * python/py-gdb-readline.c: Update.
1668 * linespec.c (decode_line_2): Update.
1669 * defs.h (command_line_input): Make return type const.
1670 * cli/cli-script.c (read_next_line): Make return type const.
1671 * ada-lang.c (get_selections): Update.
1672
ca3a04f6
CB
16732019-11-06 Christian Biesinger <cbiesinger@google.com>
1674
1675 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1676 * mi/mi-main.c (output_cores): Likewise.
1677 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1678 (linux_xfer_osdata_modules): Likewise.
1679 * remote.c (register_remote_support_xml): Likewise.
1680 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1681 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1682
e0eac551
TT
16832019-11-06 Tom Tromey <tom@tromey.com>
1684
1685 * tui/tui-interp.c: Don't include readline.h.
1686 * tui/tui-hooks.c: Don't include readline.h.
1687 * symmisc.c: Include tilde.h, not readline.h.
1688 * symfile.c: Include tilde.h, not readline.h.
1689 * source.c: Include tilde.h, not readline.h.
1690 * solib.c: Include tilde.h, not readline.h.
1691 * psymtab.c: Include tilde.h, not readline.h.
1692 * exec.c: Include tilde.h, not readline.h.
1693 * corelow.c: Include tilde.h, not readline.h.
1694 * cli/cli-dump.c: Include tilde.h, not readline.h.
1695 * cli/cli-cmds.c: Don't include readline.h.
1696
825165c5
TT
16972019-11-05 Tom Tromey <tom@tromey.com>
1698
1699 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1700 (tui_disassemble): Set addr_size.
1701 (tui_disasm_window::set_contents): Use addr_size.
1702
91ae903f
TT
17032019-11-05 Tom Tromey <tom@tromey.com>
1704
1705 * rust-lang.c (rust_language_defn): Update.
1706 * python/py-value.c (valpy_string): Call c_get_string.
1707 * p-lang.c (pascal_language_defn): Update.
1708 * opencl-lang.c (opencl_language_defn): Update.
1709 * objc-lang.c (objc_language_defn): Update.
1710 * m2-lang.c (m2_language_defn): Update.
1711 * language.c (unknown_language_defn, auto_language_defn): Update.
1712 (default_get_string): Remove.
1713 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1714 * go-lang.c (go_language_defn): Update.
1715 * f-lang.c (f_language_defn): Update.
1716 * d-lang.c (d_language_defn): Update.
1717 * c-lang.c (c_language_defn, cplus_language_defn)
1718 (asm_language_defn, minimal_language_defn): Update.
1719 * ada-lang.c (ada_language_defn): Update.
1720 * language.h (struct language_defn) <la_get_string>: Remove.
1721 (LA_GET_STRING): Remove.
1722 (default_get_string): Don't declare.
1723
1df2f9ef
TT
17242019-11-05 Tom Tromey <tom@tromey.com>
1725
1726 * tui/tui-source.h (struct tui_source_window): Inline
1727 constructor. Remove destructor.
1728 <style_changed, m_observable>: Move to superclass.
1729 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1730 (struct tui_source_window_base): Move private members to end.
1731 <style_changed, m_observable>: Move from tui_source_window.
1732 * tui/tui-winsource.c (tui_copy_source_line): Move from
1733 tui-source.c. Rename from copy_source_line. Add special handling
1734 for negative line number.
1735 (tui_source_window_base::style_changed): Move from
1736 tui_source_window.
1737 (tui_source_window_base): Register observer.
1738 (~tui_source_window_base): New.
1739 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1740 rename.
1741 (tui_source_window::set_contents): Use tui_copy_source_line.
1742 (tui_source_window::tui_source_window): Move to tui-source.h.
1743 (tui_source_window::~tui_source_window): Remove.
1744 (tui_source_window::style_changed): Move to superclass.
1745 * tui/tui-disasm.c (tui_disassemble): Create string file with
1746 styling, when possible. Add "addr_size" parameter.
1747 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1748 Don't compute maximum size.
1749 (len_without_escapes): New function
1750
5d051055
TT
17512019-11-05 Tom Tromey <tom@tromey.com>
1752
1753 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1754 std::string.
1755 * tui/tui-winsource.c (tui_show_source_line): Update.
1756 * tui/tui-source.c (tui_source_window::set_contents): Update.
1757 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1758
ade7beea
CB
17592019-11-05 Christian Biesinger <cbiesinger@google.com>
1760
1761 * symtab.h (gdb_static_assert): Put && operator at the beginning
1762 of the line instead of the end.
1763
3573abe1
CB
17642019-11-04 Christian Biesinger <cbiesinger@google.com>
1765
1766 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1767 and sizeof (symbol).
1768 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1769
dae8b3eb
RO
17702019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1771
1772 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1773 * configure.host: Mark *-*-solaris2.10* obsolete.
1774 * configure.tgt: Mark Solaris < 11 obsolete.
1775 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1776 Update target triplet.
1777
5df96a4e
TT
17782019-11-01 Tom Tromey <tromey@adacore.com>
1779
1780 * utils.c (print_sys_errmsg): Simplify.
1781
b7481649
TT
17822019-11-01 Tom Tromey <tromey@adacore.com>
1783
1784 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1785
e48f6033
CB
17862019-11-01 Christian Biesinger <cbiesinger@google.com>
1787
1788 * configure: Regenerate.
1789 * configure.ac: Remove check for strerror_r.
1790 * gdbsupport/common.m4: Check for strerror_r.
1791
bd5766ec
LM
17922019-11-01 Luis Machado <luis.machado@linaro.org>
1793
1794 PR gdb/25124
1795
1796 * arm-tdep.c (arm_per_objfile): Rename to ...
1797 (arm_per_bfd): ... this.
1798 (arm_objfile_data_key): Rename to ...
1799 (arm_bfd_data_key): ... this.
1800 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1801 data.
1802 (arm_record_special_symbol): Likewise.
1803
e1709896
AB
18042019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1805
1806 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1807 end.
1808 * c-typeprint.c (c_print_typedef): Likewise.
1809 * f-typeprint.c (f_print_typedef): Likewise.
1810 * m2-typeprint.c (m2_print_typedef): Likewise.
1811 * p-typeprint.c (pascal_print_typedef): Likewise.
1812 * rust-lang.c (rust_print_typedef): Likewise.
1813 * symtab.c (print_symbol_info): Print a newline after calling
1814 typedef_print.
1815
165f8965
AB
18162019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1817
1818 * symtab.c (info_module_cmdlist): New variable.
1819 (info_module_command): New function.
1820 (search_module_symbols): New function.
1821 (info_module_subcommand): New function.
1822 (struct info_modules_var_func_options): New struct.
1823 (info_modules_var_func_options_defs): New variable.
1824 (make_info_modules_var_func_options_def_group): New function.
1825 (info_module_functions_command): New function.
1826 (info_module_variables_command): New function.
1827 (info_module_var_func_command_completer): New function.
1828 (_initialize_symtab): Register new 'info module functions' and
1829 'info module variables' commands.
1830 * symtab.h (typedef symbol_search_in_module): New typedef.
1831 (search_module_symbols): Declare new function.
1832 * NEWS: Mention new commands.
1833
59c35742
AB
18342019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1835
1836 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1837 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1838 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1839 MODULES_DOMAIN.
1840 (scan_partial_symbols): Only create partial module symbols for non
1841 declarations.
1842 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1843 and MODULES_DOMAIN.
1844 * symtab.c (search_domain_name): Likewise.
1845 (search_symbols): Likewise.
1846 (print_symbol_info): Likewise.
1847 (symtab_symbol_info): Likewise.
1848 (info_modules_command): New function.
1849 (_initialize_symtab): Register 'info modules' command.
1850 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1851 * NEWS: Mention new 'info modules' command.
1852
aed61d02
PW
18532019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1854
1855 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1856 and $_gdb_maint_setting_str.
1857
9ad9b77d
PW
18582019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1859
1860 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1861 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1862 (str_value_from_setting, gdb_setting_str_internal_fn)
1863 (gdb_maint_setting_str_internal_fn): New functions.
1864 (_initialize_cli_cmds): Define the new convenience functions.
1865 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1866 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1867
8d6efaa2
CB
18682019-10-31 Christian Biesinger <cbiesinger@google.com>
1869
1870 * agent.c (set_can_use_agent): When the setting is turned on,
1871 look up agent symbols if we don't have them yet.
1872 (agent_new_objfile): Don't look up agent symbols when the agent
1873 setting is off.
1874
33cb1647
CB
18752019-10-31 Christian Biesinger <cbiesinger@google.com>
1876
1877 * config.in: Regenerate.
1878
b231e86a
CB
18792019-10-31 Christian Biesinger <cbiesinger@google.com>
1880
1881 * configure: Regenerate.
1882 * configure.ac: Check for strerror_r.
1883 * gdbsupport/common-utils.h (safe_strerror): Change return value
1884 to const char * and document that this function is now threadsafe.
1885 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1886 thread_local and call strerror_r, if available.
1887 * utils.c (perror_string): Update.
1888 (print_sys_errmsg): Update.
1889
a2726d4f
LM
18902019-10-31 Luis Machado <luis.machado@linaro.org>
1891
1892 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1893 objfile_key.
1894 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1895 objfile to fetch per-bfd data.
1896 (arm_find_exidx_entry): Likewise.
1897
75cafaa6
CB
18982019-10-31 Christian Biesinger <cbiesinger@google.com>
1899
1900 * gdbsupport/agent.c (debug_agent): Change type to bool.
1901 (use_agent): Likewise.
1902 (all_agent_symbols_look_up): Likewise.
1903 (agent_loaded_p): Change return value to bool.
1904 (agent_look_up_symbols): Update.
1905 (agent_capability_check): Change return value to bool.
1906 * gdbsupport/agent.h (agent_loaded_p): Likewise.
1907 (debug_agent): Change type to bool.
1908 (use_agent): Likewise.
1909 (agent_capability_check): Change return value to bool.
1910
808590ec
CB
19112019-10-30 Christian Biesinger <cbiesinger@google.com>
1912
1913 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1914 (build_minimal_symbol_hash_tables): Code to clear the table moved
1915 to clear_minimal_symbol_hash_tables.
1916 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1917 when needed.
1918
f18ad8a1
SM
19192019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1920
1921 * infcmd.c: Remove includes.
1922 * infrun.c: Remove includes.
1923
de93309a
SM
19242019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1925
1926 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1927 (grow_vect): Remove declaration.
1928 (ada_type_of_array): Remove declaration.
1929 (ada_update_initial_language): Remove declaration.
1930 (ada_fold_name): Remove declaration.
1931 (ada_fill_in_ada_prototype): Remove declaration.
1932 (user_select_syms): Remove declaration.
1933 (get_selections): Remove declaration.
1934 (ada_tag_type): Remove declaration.
1935 (ada_value_tag): Remove declaration.
1936 (ada_is_others_clause): Remove declaration.
1937 (ada_in_variant): Remove declaration.
1938 (ada_value_struct_elt): Remove declaration.
1939 (ada_attribute_name): Remove declaration.
1940 (ada_system_address_type): Remove declaration.
1941 * ada-lang.c (ada_watch_location_expression): Make static.
1942 (GROW_VECT): Move here from ada-lang.h.
1943 (grow_vect): Make static.
1944 (ada_update_initial_language): Make static.
1945 (ada_fold_name): Make static.
1946 (ada_type_of_array): Make static.
1947 (encoded_ordered_before): Move up.
1948 (sort_choices): Move up.
1949 (print_signatures): Move up.
1950 (ada_print_symbol_signature): Move up.
1951 (get_selections): Move up and make static.
1952 (user_select_syms): Move up and make static.
1953 (ada_value_struct_elt): Move up and make static.
1954 (ada_tag_type): Make static.
1955 (ada_value_tag): Make static.
1956 (ada_is_others_clause): Make static.
1957 (ada_in_variant): Make static.
1958 (ada_attribute_name): Make static.
1959
cdc46a9f
SM
19602019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1961
1962 * ada-lang.c: Remove includes.
1963 * ada-typeprint.c: Remove includes.
1964 * ada-valprint.c: Remove includes.
1965
90421c56
SM
19662019-10-29 Simon Marchi <simon.marchi@efficios.com>
1967
1968 * addrmap.c: Add static assertions of type size, moved from
1969 _initialize_addrmap.
1970 (_initialize_addrmap): Remove.
1971
31edb802
CB
19722019-10-29 Christian Biesinger <cbiesinger@google.com>
1973
1974 * coffread.c (record_minimal_symbol): Update.
1975 (process_coff_symbol): Update.
1976 * dbxread.c (read_dbx_symtab): Update.
1977 * dwarf2read.c (add_partial_symbol): Update.
1978 (fixup_go_packaging): Update.
1979 (load_partial_dies): Update.
1980 (new_symbol): Update.
1981 * elfread.c (record_minimal_symbol): Change signature to use
1982 gdb::string_view instead of name+len.
1983 (elf_symtab_read): Update.
1984 (elf_rel_plt_read): Update.
1985 * mdebugread.c (parse_partial_symbols): Update.
1986 (handle_psymbol_enumerators): Update.
1987 (new_symbol): Update.
1988 * minsyms.c (minimal_symbol_reader::record_full): Change signature
1989 to use gdb::string_view instead of name+len.
1990 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1991 * psympriv.h (add_psymbol_to_list): Likewise.
1992 * psymtab.c (add_psymbol_to_bcache): Likewise.
1993 (add_psymbol_to_list): Likewise.
1994 * stabsread.c (define_symbol): Update.
1995 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1996 * symtab.h (SYMBOL_SET_NAMES): Likewise.
1997 (symbol_set_names): Likewise.
1998 * xcoffread.c (scan_xcoff_symtab): Update.
1999
0c921b21
CB
20002019-10-29 Christian Biesinger <cbiesinger@google.com>
2001
2002 * symtab.h (symbol_set_names): Document that copy_name must be
2003 set to true for non-nullterminated strings.
2004 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2005 linkage_name if the entry was not found and we need to demangle.
2006
35e65c49
CB
20072019-10-29 Christian Biesinger <cbiesinger@google.com>
2008
2009 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2010 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2011 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2012 * gdbsupport/gdb_binary_search.h: New file.
2013
ed2a2229
CB
20142019-10-29 Christian Biesinger <cbiesinger@google.com>
2015
2016 * NEWS: Mention new --with-system-gdbinit-dir option.
2017 * config.in: Regenerate.
2018 * configure: Regenerate.
2019 * configure.ac: Add new option --with-system-gdbinit-dir.
2020 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2021 for a ".gdb" suffix.
2022 * main.c (get_init_files): Change system_gdbinit argument to
2023 a vector and return the files in SYSTEM_GDBINIT_DIR in
2024 addition to SYSTEM_GDBINIT.
2025 (captured_main_1): Update.
2026 (print_gdb_help): Update.
2027 * top.c (print_gdb_configuration): Also print the value of
2028 SYSTEM_GDBINIT_DIR.
2029
87f34879
CB
20302019-10-28 Christian Biesinger <cbiesinger@google.com>
2031
2032 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2033 that takes gdb::string_view arguments.
2034
30baf67b
TV
20352019-10-26 Tom de Vries <tdevries@suse.de>
2036
2037 * aarch64-linux-tdep.c: Fix typos in comments.
2038 * aarch64-tdep.c: Same.
2039 * ada-lang.c: Same.
2040 * amd64-nat.c: Same.
2041 * arc-tdep.c: Same.
2042 * arch/aarch64-insn.c: Same.
2043 * block.c: Same.
2044 * breakpoint.h: Same.
2045 * btrace.h: Same.
2046 * c-varobj.c: Same.
2047 * cli/cli-decode.c: Same.
2048 * cli/cli-script.c: Same.
2049 * cli/cli-utils.h: Same.
2050 * coff-pe-read.c: Same.
2051 * coffread.c: Same.
2052 * compile/compile-cplus-symbols.c: Same.
2053 * compile/compile-object-run.c: Same.
2054 * completer.c: Same.
2055 * corelow.c: Same.
2056 * cp-support.c: Same.
2057 * demangle.c: Same.
2058 * dwarf-index-write.c: Same.
2059 * dwarf2-frame.c: Same.
2060 * dwarf2-frame.h: Same.
2061 * eval.c: Same.
2062 * frame-base.h: Same.
2063 * frame.h: Same.
2064 * gdbcmd.h: Same.
2065 * gdbtypes.h: Same.
2066 * gnu-nat.c: Same.
2067 * guile/scm-objfile.c: Same.
2068 * i386-tdep.c: Same.
2069 * i386-tdep.h: Same.
2070 * infcall.c: Same.
2071 * infcall.h: Same.
2072 * linux-nat.c: Same.
2073 * m68k-tdep.c: Same.
2074 * macroexp.c: Same.
2075 * memattr.c: Same.
2076 * mi/mi-cmd-disas.c: Same.
2077 * mi/mi-getopt.h: Same.
2078 * mi/mi-main.c: Same.
2079 * minsyms.c: Same.
2080 * nat/aarch64-sve-linux-sigcontext.h: Same.
2081 * objfiles.h: Same.
2082 * ppc-linux-nat.c: Same.
2083 * ppc-linux-tdep.c: Same.
2084 * ppc-tdep.h: Same.
2085 * progspace.h: Same.
2086 * prologue-value.h: Same.
2087 * python/py-evtregistry.c: Same.
2088 * python/py-instruction.h: Same.
2089 * record-btrace.c: Same.
2090 * record-full.c: Same.
2091 * remote.c: Same.
2092 * rs6000-tdep.c: Same.
2093 * ser-tcp.c: Same.
2094 * sol-thread.c: Same.
2095 * sparc-sol2-tdep.c: Same.
2096 * sparc64-tdep.c: Same.
2097 * stabsread.c: Same.
2098 * symfile.c: Same.
2099 * symtab.h: Same.
2100 * target.c: Same.
2101 * tracepoint.c: Same.
2102 * tui/tui-data.h: Same.
2103 * tui/tui-io.c: Same.
2104 * tui/tui-win.c: Same.
2105 * tui/tui.c: Same.
2106 * unittests/rsp-low-selftests.c: Same.
2107 * user-regs.h: Same.
2108 * utils.c: Same.
2109 * utils.h: Same.
2110 * valarith.c: Same.
2111 * valops.c: Same.
2112 * valprint.c: Same.
2113 * valprint.h: Same.
2114 * value.c: Same.
2115 * value.h: Same.
2116 * varobj.c: Same.
2117 * x86-nat.h: Same.
2118 * xtensa-tdep.c: Same.
2119
1834d45f
AT
21202019-10-25 Ali Tamur <tamur@google.com>
2121
2122 * charset.c (find_charset_names): Reflect API change.
2123
5396ae17
CB
21242019-10-25 Christian Biesinger <cbiesinger@google.com>
2125
2126 * symtab.c (struct demangled_name_entry): Change demangled name
2127 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2128 part of the struct anymore.
2129 (symbol_set_names): No longer obstack allocate + copy the demangled
2130 name, just store the allocated name from bfd.
2131
93878f47
TT
21322019-10-25 Tom Tromey <tromey@adacore.com>
2133
2134 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2135 (bsearch_cie_cmp, add_cie): Remove.
2136 (find_cie): Reimplement.
2137 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2138 (dwarf2_build_frame_info): Update.
2139
7b71fc97
L
21402019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2141
2142 PR gdb/25126
2143 * symfile.c (reread_symbols): Call forget_cached_source_info to
2144 clear the stale source cache.
2145
cbb5a2ea
CB
21462019-10-24 Christian Biesinger <cbiesinger@google.com>
2147
2148 * configure: Regenerate.
2149 * configure.ac: Remove code that sets python_has_threads.
2150
71737c43
CB
21512019-10-24 Christian Biesinger <cbiesinger@google.com>
2152
2153 * config.in: Regenerate.
2154 * configure: Regenerate.
2155 * configure.ac: Remove the code that uses sed to get the python
2156 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2157
33d569b7
AB
21582019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2159
2160 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2161 error paths.
2162
f16f7b7c
TT
21632019-10-23 Tom Tromey <tom@tromey.com>
2164
2165 * arc-tdep.c: Remove ".." from include.
2166 * frv-tdep.c: Remove ".." from include.
2167 * lm32-tdep.c: Remove ".." from include.
2168 * microblaze-tdep.c: Remove ".." from include.
2169 * or1k-tdep.h: Remove ".." from include.
2170 * s12z-tdep.c: Remove ".." from include.
2171 * Makefile.in (OPCODES_CFLAGS): Add comment.
2172 (TOP_CFLAGS): New variable.
2173 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2174
6999161a
TT
21752019-10-23 Tom Tromey <tom@tromey.com>
2176
2177 * Makefile.in (READLINE_DIR): Update.
2178
12e7c35e
TBA
21792019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2180
2181 * infcall.c (call_function_by_hand_dummy): Fix the function
2182 comment. And extract out a code section into...
2183 (reserve_stack_space): ...this new function.
2184
37055cad
TBA
21852019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2186
2187 * infcall.c (value_arg_coerce): Remove an unused parameter.
2188 (call_function_by_hand_dummy): Update the call to
2189 'value_arg_coerce'.
2190
39bcc47c
TBA
21912019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2192
2193 * infcall.c (call_function_by_hand_dummy): Refactor.
2194
bd888c0f
TBA
21952019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2196
2197 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2198
c12d372d
TT
21992019-10-23 Tom Tromey <tom@tromey.com>
2200
2201 * configure: Rebuild.
2202 * configure.ac: Don't check for sigprocmask.
2203 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2204
4d0b984b
TT
22052019-10-23 Tom Tromey <tom@tromey.com>
2206
2207 * configure: Rebuild.
2208 * acinclude.m4: Use m4_include, not sinclude.
2209
7e785608
TV
22102019-10-23 Tom de Vries <tdevries@suse.de>
2211
2212 PR breakpoints/24687
2213 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2214
403772ef
CB
22152019-10-22 Christian Biesinger <cbiesinger@google.com>
2216
2217 * symtab.c (struct demangled_name_entry) <language>: Change from
2218 bitfield to regular variable.
2219
3a494279
CB
22202019-10-22 Christian Biesinger <cbiesinger@google.com>
2221
2222 * symtab.c (struct demangled_name_entry): Add a constructor.
2223 (free_demangled_name_entry): New function to call the destructor
2224 for demangled_name_entry.
2225 (create_demangled_names_hash): Pass free_demangled_name_entry to
2226 htab_create_alloc.
2227 (symbol_set_names): Call placement new for demangled_name_entry.
2228 * utils.c: No longer include xxhash.h here, now that fast_hash
2229 is inlined in the header.
2230 * utils.h: Instead, include it here.
2231
ccb1ba62
CB
22322019-10-22 Christian Biesinger <cbiesinger@google.com>
2233
2234 * Makefile.in: Link with libxxhash.
2235 * config.in: Regenerate.
2236 * configure: Regenerate.
2237 * configure.ac: Search for libxxhash.
2238 * utils.c (fast_hash): Use xxhash if present.
2239
1a6ff1a9
CB
22402019-10-22 Christian Biesinger <cbiesinger@google.com>
2241
2242 * utils.h (fast_hash): New function.
2243 * symtab.c (hash_demangled_name_entry): Call new function
2244 fast_hash.
2245
7bb43059
CB
22462019-10-22 Christian Biesinger <cbiesinger@google.com>
2247
2248 * symtab.c (struct demangled_name_entry): Change type of mangled
2249 to gdb::string_view. Also adds a constructor that takes the
2250 mangled name.
2251 (hash_demangled_name_entry): Update.
2252 (eq_demangled_name_entry): Update.
2253 (free_demangled_name_entry): New function to call the destructor
2254 now that this is not a POD anymore.
2255 (create_demangled_names_hash): Pass free_demangled_name_entry to
2256 htab_create_alloc.
2257 (symbol_set_names): Update.
2258
7ba99d21
AT
22592019-10-21 Ali Tamur <tamu@google.com>
2260
2261 * dwarf2read.c (dir_index): Change type.
2262 (file_name_index): Likewise.
2263 (line_header::include_dir_at): Change comment and implementation on
2264 whether it is DWARF 5.
2265 (line_header::is_valid_file_index): New function.
2266 (line_header::file_name_at): Change comment and implementation on
2267 whether it is DWARF 5.
2268 (line_header::file_names): Change to private field renamed as
2269 m_file_names and introduce a new accessor method.
2270 (line_header::file_names_size): New method.
2271 (line_header::include_dirs): Change to private field and rename as
2272 m_include_dirs.
2273 (dw2_get_file_names_reader): Define local var at a smaller scope and
2274 reflect API change.
2275 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2276 (process_structure_scope): Likewise.
2277 (line_header::add_include_dir): Change message and reflect renaming.
2278 (line_header::add_file_name): Likewise.
2279 (read_formatted_entries): Handle DW_FORM_data16.
2280 (dwarf_decode_line_header): Fix line header length calculation.
2281 (psymtab_include_file_name): Change comment and API.
2282 (lnp_state_machine::m_file): Update comment and reflect type change.
2283 (lnp_state_machine::record_line): Reflect type change.
2284 (dwarf_decode_lines): Reflect API change.
2285 (file_file_name): Likewise.
2286 (file_full_name): Likewise.
2287
45f47c3a
AB
22882019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2289
2290 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2291
e5f3c0e3
TT
22922019-10-21 Tom Tromey <tom@tromey.com>
2293
2294 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2295
a0a461e5
TT
22962019-10-21 Tom Tromey <tom@tromey.com>
2297
2298 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2299 NM_H. Use AC_CONFIG_LINKS.
2300 * configure: Rebuild.
2301 * Makefile.in (NM_H): New variable.
2302 (generated_files): Add NM_H. Remove gcore.
2303 (nm.h, stamp-nmh): New targets.
2304
54d83b8d
TT
23052019-10-20 Tom Tromey <tom@tromey.com>
2306
2307 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2308 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2309 obsolete comment.
2310 (put_objfile_before): Now static.
2311
23771117
SM
23122019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2313
2314 * gdbsupport/common-utils.h (startswith): Change return type to
2315 bool.
2316
39ef2f62
CB
23172019-10-19 Christian Biesinger <cbiesinger@google.com>
2318
2319 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2320 * breakpoint.c (bp_locations_compare): Rename to...
2321 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2322 (update_global_location_list): Use std::sort instead of qsort.
2323 * buildsym.c (compare_line_numbers): Rename to...
2324 (lte_is_less_than): ...this, and change to std::sort semantics.
2325 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2326 instead of qsort.
2327 * disasm.c (compare_lines): Rename to...
2328 (line_is_less_than): ...this, and change to std::sort semantics.
2329 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2330 of qsort.
2331 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2332 (fde_is_less_than): ...this, and change to std::sort semantics.
2333 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2334 * mdebugread.c (compare_blocks):
2335 (block_is_less_than): ...this, and change to std::sort semantics.
2336 (sort_blocks): Call std::sort instead of qsort.
2337 * objfiles.c (qsort_cmp): Rename to...
2338 (sort_cmp): ...this, and change to std::sort semantics.
2339 (update_section_map): Call std::sort instead of qsort.
2340 * remote.c (compare_pnums): Remove.
2341 (map_regcache_remote_table): Call std::sort instead of qsort.
2342 * utils.c (compare_positive_ints): Remove.
2343 * utils.h (compare_positive_ints): Remove.
2344 * xcoffread.c (compare_lte): Remove.
2345 (arrange_linetable): Call std::sort instead of qsort.
2346
f71433ee
SDJ
23472019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2348
2349 * symfile.c (init_entry_point_info): Fix typo.
2350 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2351
85102364
TV
23522019-10-18 Tom de Vries <tdevries@suse.de>
2353
2354 * aarch64-tdep.c: Fix typos in comments.
2355 * ada-lang.c: Same.
2356 * ada-tasks.c: Same.
2357 * alpha-tdep.c: Same.
2358 * alpha-tdep.h: Same.
2359 * amd64-nat.c: Same.
2360 * amd64-windows-tdep.c: Same.
2361 * arc-tdep.c: Same.
2362 * arc-tdep.h: Same.
2363 * arch-utils.c: Same.
2364 * arm-nbsd-tdep.c: Same.
2365 * arm-tdep.c: Same.
2366 * ax-gdb.c: Same.
2367 * blockframe.c: Same.
2368 * btrace.c: Same.
2369 * c-varobj.c: Same.
2370 * coff-pe-read.c: Same.
2371 * coffread.c: Same.
2372 * cris-tdep.c: Same.
2373 * darwin-nat.c: Same.
2374 * dbxread.c: Same.
2375 * dcache.c: Same.
2376 * disasm.c: Same.
2377 * dtrace-probe.c: Same.
2378 * dwarf-index-write.c: Same.
2379 * dwarf2-frame-tailcall.c: Same.
2380 * dwarf2-frame.c: Same.
2381 * dwarf2read.c: Same.
2382 * eval.c: Same.
2383 * exceptions.c: Same.
2384 * fbsd-tdep.c: Same.
2385 * findvar.c: Same.
2386 * frame.c: Same.
2387 * frv-tdep.c: Same.
2388 * gnu-v3-abi.c: Same.
2389 * go32-nat.c: Same.
2390 * h8300-tdep.c: Same.
2391 * hppa-tdep.c: Same.
2392 * i386-linux-tdep.c: Same.
2393 * i386-tdep.c: Same.
2394 * ia64-libunwind-tdep.c: Same.
2395 * ia64-tdep.c: Same.
2396 * infcmd.c: Same.
2397 * infrun.c: Same.
2398 * linespec.c: Same.
2399 * linux-nat.c: Same.
2400 * linux-thread-db.c: Same.
2401 * machoread.c: Same.
2402 * mdebugread.c: Same.
2403 * mep-tdep.c: Same.
2404 * mn10300-tdep.c: Same.
2405 * namespace.c: Same.
2406 * objfiles.c: Same.
2407 * opencl-lang.c: Same.
2408 * or1k-tdep.c: Same.
2409 * osabi.c: Same.
2410 * ppc-linux-nat.c: Same.
2411 * ppc-linux-tdep.c: Same.
2412 * ppc-sysv-tdep.c: Same.
2413 * printcmd.c: Same.
2414 * procfs.c: Same.
2415 * record-btrace.c: Same.
2416 * record-full.c: Same.
2417 * remote-fileio.c: Same.
2418 * remote.c: Same.
2419 * rs6000-tdep.c: Same.
2420 * s12z-tdep.c: Same.
2421 * score-tdep.c: Same.
2422 * ser-base.c: Same.
2423 * ser-go32.c: Same.
2424 * skip.c: Same.
2425 * sol-thread.c: Same.
2426 * solib-svr4.c: Same.
2427 * solib.c: Same.
2428 * source.c: Same.
2429 * sparc-nat.c: Same.
2430 * sparc-sol2-tdep.c: Same.
2431 * sparc-tdep.c: Same.
2432 * sparc64-tdep.c: Same.
2433 * stabsread.c: Same.
2434 * stack.c: Same.
2435 * symfile.c: Same.
2436 * symtab.c: Same.
2437 * target-descriptions.c: Same.
2438 * target-float.c: Same.
2439 * thread.c: Same.
2440 * utils.c: Same.
2441 * valops.c: Same.
2442 * valprint.c: Same.
2443 * value.c: Same.
2444 * varobj.c: Same.
2445 * windows-nat.c: Same.
2446 * xcoffread.c: Same.
2447 * xstormy16-tdep.c: Same.
2448 * xtensa-tdep.c: Same.
2449
c5adaa19
TT
24502019-10-17 Tom Tromey <tromey@adacore.com>
2451
2452 * configure: Rebuild.
2453 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2454 in AC_CONFIG_FILES invocation.
2455 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2456 new-style config.status invocation.
2457
405feb71
TV
24582019-10-17 Tom de Vries <tdevries@suse.de>
2459
2460 * arm-nbsd-nat.c: Fix typos in comments.
2461 * arm-tdep.c: Same.
2462 * darwin-nat-info.c: Same.
2463 * dwarf2read.c: Same.
2464 * elfread.c: Same.
2465 * event-top.c: Same.
2466 * findvar.c: Same.
2467 * gdbtypes.c: Same.
2468 * hppa-tdep.c: Same.
2469 * i386-tdep.c: Same.
2470 * jit.c: Same.
2471 * main.c: Same.
2472 * mdebugread.c: Same.
2473 * moxie-tdep.c: Same.
2474 * nto-procfs.c: Same.
2475 * osabi.c: Same.
2476 * ppc-linux-tdep.c: Same.
2477 * remote.c: Same.
2478 * riscv-tdep.c: Same.
2479 * s390-tdep.c: Same.
2480 * sh-tdep.c: Same.
2481 * sparc-linux-tdep.c: Same.
2482 * sparc-nat.c: Same.
2483 * stack.c: Same.
2484 * target-descriptions.c: Same.
2485 * top.c: Same.
2486 * varobj.c: Same.
2487
befcd486
TT
24882019-10-16 Tom Tromey <tom@tromey.com>
2489
2490 * objfiles.h (struct objfile) <original_name>: Now const.
2491
17bfe554
CB
24922019-10-16 Christian Biesinger <cbiesinger@google.com>
2493
2494 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2495 pass on to sigsetjmp's second argument.
2496 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2497
950b7495
KS
24982019-10-16 Keith Seitz <keiths@redhat.com>
2499
2500 PR gdb/23567
2501 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2502 sections whose size is greater than the file size.
2503
ff371ec9
JW
25042019-10-16 Jim Wilson <jimw@sifive.com>
2505
2506 * riscv-tdep.c (riscv_gcc_target_options): New.
2507 (riscv_gnu_triplet_regexp): New.
2508 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2509 set_gdbarch_gnu_triplet_regexp.
2510
fec4e896
CB
25112019-10-16 Christian Biesinger <cbiesinger@google.com>
2512
2513 * Makefile.in: Add xml-builtin.h.
2514 * features/feature_to_c.sh: Add an include for xml-builtin.h
2515 to ensure that the compiler checks that the types match.
2516 * xml-builtin.h: New file.
2517 * xml-support.c (fetch_xml_builtin): Add missing const.
2518 * xml-support.h: Remove declaration of xml_builtins.
2519
d10eccaa
TV
25202019-10-16 Tom de Vries <tdevries@suse.de>
2521
2522 PR tdep/25096
2523 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2524 (amd64_classify_aggregate): ... here.
2525 (amd64_classify_aggregate_field): Handled fiels of nested structs
2526 recursively.
2527
745ff14e
TV
25282019-10-16 Tom de Vries <tdevries@suse.de>
2529
2530 PR tdep/24104
2531 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2532 that handles 'theclass'.
2533
791b7405
AB
25342019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2535
2536 * linespec.c (decode_digits_ordinary): Update comment.
2537 * make-target-delegates: No longer need to handle VEC case.
2538 * memrange.c (normalize_mem_ranges): Update comment.
2539 * namespace.c (add_using_directive): Update comment.
2540 * objc-lang.c (uniquify_strings): Update comment.
2541 * ppc-linux-nat.c (struct thread_points): Update comment.
2542 * probe.h (find_probes_in_objfile): Update comment.
2543 * target.h (enum flash_preserve_mode): Update comment.
2544 * varobj.c (varobj_restrict_range): Update comment.
2545 * varobj.h (varobj_list_children): Update comment.
2546
0dc32745
AB
25472019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2548
2549 * Makefile.in: Remove references to vec.h and vec.c.
2550 * aarch64-tdep.c: No longer include vec.h.
2551 * ada-lang.c: Likewise.
2552 * ada-lang.h: Likewise.
2553 * arm-tdep.c: Likewise.
2554 * ax.h: Likewise.
2555 * breakpoint.h: Likewise.
2556 * charset.c: Likewise.
2557 * cp-support.h: Likewise.
2558 * dtrace-probe.c: Likewise.
2559 * dwarf2read.c: Likewise.
2560 * extension.h: Likewise.
2561 * gdb_bfd.c: Likewise.
2562 * gdbsupport/gdb_vecs.h: Likewise.
2563 * gdbsupport/vec.c: Remove.
2564 * gdbsupport/vec.h: Remove.
2565 * gdbthread.h: Likewise.
2566 * guile/scm-type.c: Likewise.
2567 * inline-frame.c: Likewise.
2568 * machoread.c: Likewise.
2569 * memattr.c: Likewise.
2570 * memrange.h: Likewise.
2571 * namespace.h: Likewise.
2572 * nat/linux-btrace.h: Likewise.
2573 * osdata.c: Likewise.
2574 * parser-defs.h: Likewise.
2575 * progspace.h: Likewise.
2576 * python/py-type.c: Likewise.
2577 * record-btrace.c: Likewise.
2578 * rust-exp.y: Likewise.
2579 * solib-target.c: Likewise.
2580 * stap-probe.c: Likewise.
2581 * target-descriptions.c: Likewise.
2582 * target-memory.c: Likewise.
2583 * target.h: Likewise.
2584 * varobj.c: Likewise.
2585 * varobj.h: Likewise.
2586 * xml-support.h: Likewise.
2587
ae640021
AB
25882019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2589
2590 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2591 Update for new std::vector based implementation.
2592 (process_psymtab_comp_unit_reader): Likewise.
2593 (scan_partial_symbols): Likewise.
2594 (recursively_compute_inclusions): Likewise.
2595 (compute_compunit_symtab_includes): Likewise.
2596 (process_imported_unit_die): Likewise.
2597 (queue_and_load_dwo_tu): Likewise.
2598 (follow_die_sig_1): Likewise.
2599 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2600 (typedef dwarf2_per_cu_ptr): Remove.
2601 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2602 function.
2603 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2604 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2605 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2606 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2607 std::vector.
2608
55dfc88f
TT
26092019-10-15 Tom Tromey <tromey@adacore.com>
2610
2611 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2612 TID.
2613
96b49c5e
TT
26142019-10-15 Tom Tromey <tromey@adacore.com>
2615
2616 * windows-nat.c (windows_nat_target::fetch_registers)
2617 (windows_nat_target::store_registers): Rename "pid" to "tid".
2618
953cff56
TT
26192019-10-15 Tom Tromey <tromey@adacore.com>
2620
2621 * gdbarch.h, gdbarch.c: Rebuild.
2622 * gdbarch.sh (gcc_target_options): Change return type to
2623 std::string.
2624 * compile/compile.c (get_args): Update.
2625 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2626 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2627 std::string.
2628 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2629 std::string.
2630 * arch-utils.c (default_gcc_target_options): Return std::string.
2631 * arch-utils.h (default_gcc_target_options): Return std::string.
2632 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2633
81e6b8eb
CB
26342019-10-15 Christian Biesinger <cbiesinger@google.com>
2635
2636 * breakpoint.c (breakpoint_chain): Make static.
2637 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2638 of accessing breakpoint_chain.
2639
95da600f
CB
26402019-10-15 Christian Biesinger <cbiesinger@google.com>
2641
2642 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2643 to a gdb::function_view and return value to bool.
2644 * breakpoint.h (iterate_over_breakpoints): Likewise.
2645 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2646 (pop_dummy_frame): Update.
2647 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2648 (gdbscm_breakpoints): Update.
2649 * python/py-breakpoint.c (build_bp_list): Update.
2650 (gdbpy_breakpoints): Update.
2651 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2652 Update.
2653 (bpfinishpy_handle_stop): Update.
2654 (bpfinishpy_handle_exit): Update.
2655 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2656 (svr4_update_solib_event_breakpoints): Update.
2657
ba18312d
AA
26582019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2659
2660 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2661 when unwrapping single-field structs.
2662
6acc1a0b
SM
26632019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2664
2665 * dwarf2read.c: Remove includes.
2666
284782de
SM
26672019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2668
2669 * ui-out.c (ui_out::call_do_message): Silence
2670 -Wformat-nonliteral warning.
2671
073bbbb0
SM
26722019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2673
2674 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2675 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2676 include: readline/tilde.h.
2677
7b9a15e1
CB
26782019-10-12 Christian Biesinger <cbiesinger@google.com>
2679
2680 * remote.c (remote_target::get_trace_status): Remove declaration of
2681 trace_regblock_size.
2682
cc8dee1f
CB
26832019-10-12 Christian Biesinger <cbiesinger@google.com>
2684
2685 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2686 (show_user): Remove declaration of cmdlist.
2687 * cli/cli-cmds.h (max_user_call_depth): Declare.
2688 * cli/cli-script.c (execute_user_command): Remove declaration
2689 of max_user_call_depth.
2690
a83d4ef6
JW
26912019-10-11 Jim Wilson <jimw@sifive.com>
2692
5f93c5a6
JW
2693 * gdbsupport/print-utils.h (pulongest): Fix comment.
2694 (plongest): Likewise.
2695 (phex): Add missing comment, mention leading zeros.
2696 (phex_nz): Add mention of no leading zeros to comment.
2697
a83d4ef6
JW
2698 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2699 plongest instead of unsigned long long cast.
2700
26344e0c
CB
27012019-10-10 Christian Biesinger <cbiesinger@google.com>
2702
2703 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2704 for external_editor_command and gdbtk_test.
2705
c2c440a9
CB
27062019-10-10 Christian Biesinger <cbiesinger@google.com>
2707
2708 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2709 * varobj.c (varobjdebug): Move comment to...
2710 * varobj.h (varobjdebug): ...here, and declare.
2711
a31bff9d
TT
27122019-10-09 Tom Tromey <tom@tromey.com>
2713
2714 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2715 erase_data_content.
2716
7523da63
TT
27172019-10-09 Tom Tromey <tom@tromey.com>
2718
2719 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2720 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2721 * tui/tui-command.c (tui_cmd_window::resize)
2722 (tui_refresh_cmd_win): Update.
2723 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2724 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2725 * tui/tui-data.c (~tui_gen_win_info): Remove.
2726 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2727 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2728 (tui_redisplay_readline, tui_mld_flush)
2729 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2730 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2731 (tui_data_window::erase_data_content)
2732 (tui_data_item_window::rerender)
2733 (tui_data_item_window::refresh_window): Update.
2734 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2735 (box_win, tui_gen_win_info::make_window)
2736 (tui_gen_win_info::make_visible): Update.
2737 (tui_delete_win): Remove.
2738 * tui/tui-winsource.c
2739 (tui_source_window_base::do_erase_source_content): Update.
2740 (tui_show_source_line, tui_source_window_base::update_tab_width)
2741 (tui_source_window_base::update_exec_info): Update.
2742 * tui/tui-data.h (struct curses_deleter): New.
2743 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2744 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2745
a7798e7f
TT
27462019-10-09 Tom Tromey <tom@tromey.com>
2747
2748 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2749
5c45899e
TT
27502019-10-09 Tom Tromey <tom@tromey.com>
2751
2752 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2753 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2754
6d7fd9aa
TT
27552019-10-09 Tom Tromey <tom@tromey.com>
2756
2757 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2758 window height directly.
2759 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2760 declare.
2761 * tui/tui-layout.c (tui_default_win_height): Remove.
2762 (tui_default_win_viewport_height): Remove.
2763
d2dd1084
TT
27642019-10-09 Tom Tromey <tom@tromey.com>
2765
2766 * tui/tui.h: Remove comments.
2767
cff32449
TV
27682019-10-09 Tom de Vries <tdevries@suse.de>
2769
2770 * python/lib/gdb/printer/bound_registers.py: Use
2771 '^builtin_type_bound128' as regexp argument for
2772 add_builtin_pretty_printer.
2773
6a25e8a2
CB
27742019-10-09 Christian Biesinger <cbiesinger@google.com>
2775
2776 * guile/guile.c (guile_extension_script_ops): Remove forward
2777 declaration and mark as static.
2778 (guile_script_ops): Likewise.
2779 (extension_language_guile): Move further down in the file so
2780 it can reference the definitions for guile_{extension_,}script_ops.
2781
6d9d6da4
AA
27822019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2783
2784 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2785 except SORTL, DFLTCC, and KDSA.
2786
3abea05d
TT
27872019-10-08 Tom Tromey <tromey@adacore.com>
2788
2789 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2790 (struct safe_symbol_file_add_args): Remove.
2791
dde996e2
TT
27922019-10-08 Tom Tromey <tromey@adacore.com>
2793
2794 * windows-nat.c: Don't include buildsym-legacy.h.
2795
cd6fdaa1
TT
27962019-10-08 Tom Tromey <tromey@adacore.com>
2797
2798 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2799
79bb1944
CB
28002019-10-08 Christian Biesinger <cbiesinger@google.com>
2801
2802 * gdbtypes.c (overload_debug): Move comment to header.
2803 * gdbtypes.h (overload_debug): Declare.
2804 * valops.c: Remove declaration of overload_debug, instead
2805 include gdbtypes.h.
2806
34916edc
CB
28072019-10-08 Christian Biesinger <cbiesinger@google.com>
2808
2809 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2810 through _().
2811 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2812 move comment...
2813 * language.h (lang_frame_mismatch_warn): ... here. Also add
2814 declaration.
2815 * top.c (lang_frame_mismatch_warn): Remove declaration.
2816 (check_frame_language_change): Pass lang_frame_mismatch_warn
2817 through _().
2818
bad5c026
CB
28192019-10-07 Christian Biesinger <cbiesinger@google.com>
2820
2821 * c-lang.h (vtbl_ptr_name): Declare.
2822 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2823 it from the header.
2824 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2825
51f1fdc3
CB
28262019-10-07 Christian Biesinger <cbiesinger@google.com>
2827
2828 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2829 gdb_static_assert.
2830
30d1f018
WP
28312019-10-07 Weimin Pan <weimin.pan@oracle.com>
2832
606813d5
WP
2833 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2834 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP
2835 * ctfread.c: New file.
2836 * ctfread.h: New file.
2837 * elfread.c: Include ctfread.h.
2838 (struct elfinfo text_p): New member ctfsect.
2839 (elf_locate_sections): Mark CTF section.
2840 (elf_symfile_read): Call elfctf_build_psymtabs.
2841 * Makefile.in (LIBCTF): Add.
2842 (CLIBS): Use it.
2843 (CDEPS): Likewise.
2844 (DIST): Add ctfread.c.
606813d5
WP
2845
28462019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2847
2848 * ctfread.c (struct nextfield): Renamed to ...
2849 (struct ctf_nextfield): ... this.
2850 (struct field_info): Renamed to ...
2851 (strut ctf_field_info): ... this.
2852 (attach_fields_to_type): Update for renamed structures.
2853 (ctf_add_member_cb): Likewise.
2854 (ctf_add_enum_member_cb): Likewise.
2855 (process_struct_members): Likewise.
2856 (process_enum_type): Likewise.
30d1f018 2857
518fe38c
WP
28582019-10-07 Weimin Pan <weimin.pan@oracle.com>
2859
2860 * tracectf.h: Rename, was ctf.h.
2861 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2862 * tracefile.c: Likewise.
2863 * tracepoint.c: Remove unused include ctf.h.
2864 * mi/mi-main.c: Likewise.
2865 * Makefile.in Replace ctf.c with tracectf.c.
2866
225f296a
JB
28672019-10-06 Joel Brobecker <brobecker@adacore.com>
2868
2869 * version.in: Change version number to "9.0.50.DATE-git".
2870
77c2dba3
TT
28712019-10-03 Tom Tromey <tom@tromey.com>
2872
2873 PR rust/24976:
2874 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2875
179aed7f
AB
28762019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2877
2878 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2879 cp_search_name_hash.
2880 * NEWS: Add entry about nested function support.
2881
0a4b0913
AB
28822019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
2883 Andrew Burgess <andrew.burgess@embecosm.com>
2884
2885 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2886 for nested static variables when searchin VAR_DOMAIN.
2887 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2888 global scope, update comment.
2889 (add_partial_subprogram): Call add_partial_subprogram recursively
2890 for nested subroutines when processinng Fortran.
2891 (load_partial_dies): Process the child entities of a subprogram
2892 when processing Fortran.
2893 (partial_die_parent_scope): Handle building scope
2894 for Fortran nested functions.
2895 (process_die): Record that nested functions have a scope.
2896 (new_symbol): Always record Fortran subprograms on the global
2897 symbol list.
2898 (determine_prefix): How to build the prefix for Fortran
2899 subprograms.
2900
d8c06f22
AB
29012019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2902
2903 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2904 have just sent the thread a SIGSTOP and are waiting for it to
2905 arrive.
2906
a8b3b8e9
AB
29072019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2908
2909 * btrace.c (btrace_add_pc): Remove whitespace before the template
2910 parameter in 'std::vector <...>'.
2911 (parse_xml_btrace_block): Likewise.
2912 (btrace_maint_decode_pt): Likewise.
2913 (btrace_maint_update_packets): Likewise.
2914 (btrace_maint_print_packets): Likewise.
2915 * btrace.h (struct btrace_maint_info): Likewise.
2916 * dwarf2read.c (struct type_unit_group): Likewise.
2917 (build_type_psymtabs_reader): Likewise.
2918 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2919 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2920 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2921
4d825eab
TV
29222019-10-03 Tom de Vries <tdevries@suse.de>
2923
2924 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2925 the first line of the help text for set/show style metadata.
2926
80fd2826
TT
29272019-10-02 Tom Tromey <tromey@adacore.com>
2928
2929 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2930 * gdbsupport/common-inferior.c: New file.
2931 * infcmd.c (startup_with_shell): Don't define.
2932 * nat/fork-inferior.h (startup_with_shell): Don't declare.
2933 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2934 * inferior.h (startup_with_shell): Don't declare.
2935
70054538
CB
29362019-10-02 Christian Biesinger <cbiesinger@google.com>
2937
2938 * gdbsupport/gdb_assert.h: Include errors.h.
2939 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2940
37f6a7f4
TT
29412019-10-02 Tom Tromey <tromey@adacore.com>
2942
2943 * NEWS: Add $_ada_exception entry.
2944 * ada-lang.c (struct ada_catchpoint): Add constructor.
2945 <m_kind>: New member.
2946 (allocate_location_exception, re_set_exception): Remove
2947 "ex" parameter.
2948 (should_stop_exception): Compute $_ada_exception.
2949 (check_status_exception, print_it_exception)
2950 (print_one_exception, print_mention_exception): Remove
2951 "ex" parameter.
2952 (allocate_location_catch_exception, re_set_catch_exception)
2953 (check_status_exception, print_it_catch_exception)
2954 (print_one_catch_exception, print_mention_catch_exception)
2955 (print_recreate_catch_exception)
2956 (allocate_location_catch_exception_unhandled)
2957 (re_set_catch_exception_unhandled)
2958 (check_status_exception, print_it_catch_exception_unhandled)
2959 (print_one_catch_exception_unhandled)
2960 (print_mention_catch_exception_unhandled)
2961 (print_recreate_catch_exception_unhandled)
2962 (allocate_location_catch_assert, re_set_catch_assert)
2963 (check_status_assert, print_it_catch_assert)
2964 (print_one_catch_assert, print_mention_catch_assert)
2965 (print_recreate_catch_assert)
2966 (allocate_location_catch_handlers, re_set_catch_handlers)
2967 (check_status_handlers, print_it_catch_handlers)
2968 (print_one_catch_handlers, print_mention_catch_handlers)
2969 (print_recreate_catch_handlers): Remove.
2970 (create_ada_exception_catchpoint): Update.
2971 (initialize_ada_catchpoint_ops): Update.
2972
fccf9de1
TT
29732019-10-02 Tom Tromey <tromey@adacore.com>
2974
2975 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2976 (create_excep_cond_exprs): Simplify exception string computation.
2977 (ada_exception_catchpoint_cond_string): Likewise.
2978
4b610737
TT
29792019-10-02 Tom Tromey <tromey@adacore.com>
2980
2981 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2982 * ada-lang.c (lesseq_defined_than): Handle
2983 LOC_STATIC.
2984 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2985 parameter.
2986 (dwarf2_has_info): Likewise.
2987 (new_symbol): Set maybe_copied on symbol when
2988 appropriate.
2989 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2990 parameter.
2991 <can_copy>: New member.
2992 * elfread.c (record_minimal_symbol): Set maybe_copied
2993 on symbol when appropriate.
2994 (elf_symfile_read): Update call to dwarf2_has_info.
2995 * minsyms.c (lookup_minimal_symbol_linkage): New
2996 function.
2997 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2998 * symtab.c (get_symbol_address, get_msymbol_address):
2999 New functions.
3000 * symtab.h (get_symbol_address, get_msymbol_address):
3001 Declare.
3002 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3003 maybe_copied.
3004 (struct symbol, struct minimal_symbol) <maybe_copied>:
3005 New member.
3006
1dd58850
TT
30072019-10-02 Tom Tromey <tromey@adacore.com>
3008
3009 * source.c (struct current_source_location): New.
3010 (current_source_key): New global.
3011 (current_source_symtab, current_source_line)
3012 (current_source_pspace): Remove.
3013 (get_source_location): New function.
3014 (get_current_source_symtab_and_line)
3015 (set_default_source_symtab_and_line)
3016 (set_current_source_symtab_and_line)
3017 (clear_current_source_symtab_and_line, select_source_symtab)
3018 (info_source_command, print_source_lines_base)
3019 (info_line_command, search_command_helper, _initialize_source):
3020 Update.
3021
5c281dbb
TT
30222019-10-02 Tom Tromey <tromey@adacore.com>
3023
3024 * source.c (select_source_symtab): Don't call
3025 decode_line_with_current_source.
3026
d3d32391
AB
30272019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3028
3029 * symtab.c (lookup_global_symbol): Search global block.
3030
38583298
TT
30312019-10-02 Tom Tromey <tromey@adacore.com>
3032
3033 * coffread.c (process_coff_symbol): Update.
3034 * dwarf2read.c (var_decode_location, new_symbol): Update.
3035 * mdebugread.c (parse_symbol): Update.
3036 * objfiles.c (relocate_one_symbol): Update.
3037 * stabsread.c (define_symbol, fix_common_block)
3038 (scan_file_globals): Update.
3039 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3040 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3041 * xcoffread.c (process_xcoff_symbol): Update.
3042
9344c18f
AA
30432019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3044
3045 * MAINTAINERS: Update my email address.
3046
df07e2c7
AB
30472019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3048
3049 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3050 std::vector.
3051 (build_type_psymtabs_reader): Update for std::vector.
3052 (build_type_psymtab_dependencies): Likewise.
3053 * dwarf2read.h: Remove use of DEF_VEC_P.
3054 (typedef sig_type_ptr): Delete.
3055
554ac434
AB
30562019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3057
3058 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3059 to std::vector.
3060 (btrace_maint_decode_pt): Likewise, and move allocation of the
3061 vector outside of the loop.
3062 (btrace_maint_update_packets): Update to handle change from VEC to
3063 std::vector.
3064 (btrace_maint_print_packets): Likewise.
3065 (maint_info_btrace_cmd): Likewise.
3066 * btrace.h: Remove use of DEF_VEC_O.
3067 (typedef btrace_pt_packet_s): Delete.
3068 (struct btrace_maint_info) <packets>: Change fromm VEC to
3069 std::vector.
3070 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3071
46f29a9a
AB
30722019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3073
3074 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3075 make accesses into the vector constant references.
3076 (btrace_add_pc): Update for std::vector.
3077 (btrace_stitch_bts): Likewise.
3078 (parse_xml_btrace_block): Likewise.
3079 (btrace_maint_update_packets): Likewise.
3080 (btrace_maint_print_packets): Likewise.
3081 (maint_info_btrace_cmd): Likewise.
3082 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3083 std::vector.
3084 (btrace_data::empty): Likewise.
3085 (btrace_data_append): Likewise.
3086 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3087 (typedef btrace_block_s): Delete.
3088 (struct btrace_block): Add constructor.
3089 (struct btrace_data_bts) <blocks>: Change to std::vector.
3090 * nat/linux-btrace.c (perf_event_read_bts): Update for
3091 std::vector.
3092 (linux_read_bts): Likewise.
3093
d770d56f
TT
30942019-10-01 Tom Tromey <tom@tromey.com>
3095
3096 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3097
9d636d67
TT
30982019-10-01 Tom Tromey <tom@tromey.com>
3099
3100 * stack.c (print_frame, info_frame_command_core): Use
3101 styled_string.
3102 * linux-thread-db.c (try_thread_db_load_1)
3103 (try_thread_db_load_from_pdir_1): Use styled_string.
3104 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3105 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3106 (maybe_print_unsupported_script_warning)
3107 (maybe_print_script_not_found_warning): Use styled_string.
3108 * ada-lang.c (user_select_syms): Use styled_string.
3109
7f6aba03
TT
31102019-10-01 Tom Tromey <tom@tromey.com>
3111
3112 * p-lang.c (pascal_printstr): Use metadata style.
3113 * value.c (show_convenience): Use metadata style.
3114 * valprint.c (valprint_check_validity, val_print_optimized_out)
3115 (val_print_not_saved, val_print_unavailable)
3116 (val_print_invalid_address, generic_val_print, val_print)
3117 (value_check_printable, val_print_array_elements): Use metadata
3118 style.
3119 * ui-out.h (class ui_out) <field_fmt>: New overload.
3120 <do_field_fmt>: Add style parameter.
3121 * ui-out.c (ui_out::field_fmt): New overload.
3122 * typeprint.c (type_print_unknown_return_type)
3123 (val_print_not_allocated, val_print_not_associated): Use metadata
3124 style.
3125 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3126 parameter.
3127 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3128 * tracepoint.c (tvariables_info_1): Use metadata style.
3129 * stack.c (print_frame_arg, print_frame_info, print_frame)
3130 (info_frame_command_core): Use metadata style.
3131 * skip.c (info_skip_command): Use metadata style.
3132 * rust-lang.c (rust_print_enum): Use metadata style.
3133 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3134 metadata style.
3135 * python/py-framefilter.c (py_print_single_arg): Use metadata
3136 style.
3137 * printcmd.c (do_one_display, print_variable_and_value): Use
3138 metadata style.
3139 * p-valprint.c (pascal_val_print)
3140 (pascal_object_print_value_fields): Use metadata style.
3141 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3142 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3143 parameter.
3144 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3145 * m2-valprint.c (m2_print_long_set): Use metadata style.
3146 * m2-typeprint.c (m2_print_type): Use metadata style.
3147 * infcmd.c (print_return_value_1): Use metadata style.
3148 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3149 * f-valprint.c (info_common_command_for_block): Use metadata
3150 style.
3151 * f-typeprint.c (f_type_print_base): Use metadata style.
3152 * expprint.c (print_subexp_standard): Use metadata style.
3153 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3154 * cli/cli-style.h (class cli_style_option): Add constructor.
3155 (metadata_style): Declare.
3156 * cli/cli-style.c (metadata_style): New global.
3157 (_initialize_cli_style): Register metadata style.
3158 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3159 parameter.
3160 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3161 * c-typeprint.c (c_type_print_base_struct_union)
3162 (c_type_print_base_1): Use metadata style.
3163 * breakpoint.c (watchpoint_value_print)
3164 (print_one_breakpoint_location): Use metadata style.
3165 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3166 style.
3167 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3168 style.
3169 * ada-valprint.c (val_print_packed_array_elements, printstr)
3170 (print_field_values, ada_val_print_ref, ada_val_print): Use
3171 metadata style.
3172 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3173 style.
3174 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3175 style.
3176 * ada-lang.c (user_select_syms): Use metadata style.
3177
14309bb6
TT
31782019-10-01 Tom Tromey <tom@tromey.com>
3179
3180 * cli/cli-cmds.c (pwd_command): Style output.
3181
6a831f06
PA
31822019-10-01 Pedro Alves <palves@redhat.com>
3183 Tom Tromey <tom@tromey.com>
3184
3185 * symtab.c (print_symbol_info): Use %ps.
3186 (print_msymbol_info): Use %ps.
3187 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3188 * printcmd.c (print_variable_and_value): Use %ps.
3189 * macrocmd.c (show_pp_source_pos): Use %ps.
3190 * infrun.c (print_exited_reason): Use ui_out::message.
3191 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3192 (describe_other_breakpoints): Use ui_out::message and new
3193 formats.
3194 (say_where): Use new formats.
3195 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3196 and new formats.
3197
2a3c1174
PA
31982019-10-01 Pedro Alves <palves@redhat.com>
3199 Tom Tromey <tom@tromey.com>
3200
3201 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3202 (test_gdb_formats): New function.
3203 (run_tests): Call it.
3204 (test_format_specifier): Update.
3205 * utils.h (fputs_filtered): Update comment.
3206 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3207 (fputs_styled_unfiltered): Declare.
3208 * utils.c (fputs_styled_unfiltered): New function.
3209 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3210 (vfprintf_filtered): Update.
3211 (vfprintf_unfiltered, vprintf_filtered): Update.
3212 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3213 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3214 disallow_ui_out_field>: New constants.
3215 (enum class field_kind): New.
3216 (struct base_field_s, struct signed_field_s): New.
3217 (signed_field): New function.
3218 (struct string_field_s): New.
3219 (string_field): New function.
3220 (struct styled_string_s): New.
3221 (styled_string): New function.
3222 (class ui_out) <message>: Add comment.
3223 <vmessage, call_do_message>: New methods.
3224 <do_message>: Add style parameter.
3225 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3226 methods.
3227 (ui_out::message): Rewrite.
3228 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3229 parameter.
3230 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3231 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3232 gdb_extensions parameter.
3233 (class format_piece): Add parameter to constructor.
3234 (n_int_args): New field.
3235 * gdbsupport/format.c (format_pieces::format_pieces): Add
3236 gdb_extensions parameter. Handle '*'.
3237 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3238 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3239 vfprintf_styled_no_gdbfmt.
3240 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3241 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3242 unfiltered output.
3243 * ui-style.h (struct ui_file_style) <ptr>: New method.
3244
0dfe5bfb
TT
32452019-10-01 Tom Tromey <tom@tromey.com>
3246
3247 * unittests/format_pieces-selftests.c: Update. Add final format.
3248 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3249 empty literal pieces.
3250
e43b10e1
TT
32512019-10-01 Tom Tromey <tom@tromey.com>
3252
3253 * ui-out.h (enum class ui_out_style_kind): Remove.
3254 (class ui_out) <field_string, field_stsream, do_field_string>:
3255 Change type of "style".
3256 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3257 (ui_out::field_string): Update.
3258 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3259 of "style".
3260 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3261 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3262 * stack.c (print_frame_arg, print_frame_info, print_frame):
3263 Update.
3264 * source.c (print_source_lines_base): Update.
3265 * solib.c (info_sharedlibrary_command): Update.
3266 * skip.c (info_skip_command): Update.
3267 * record-btrace.c (btrace_call_history_src_line)
3268 (btrace_call_history): Update.
3269 * python/py-framefilter.c (py_print_frame): Update.
3270 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3271 "style".
3272 * mi/mi-out.c (mi_ui_out::do_table_header)
3273 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3274 (mi_ui_out::do_field_string): Update.
3275 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3276 Update.
3277 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3278 "style".
3279 * cli-out.c (cli_ui_out::do_table_header)
3280 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3281 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3282 (cli_ui_out::do_field_fmt): Update.
3283 * breakpoint.c (print_breakpoint_location): Update.
3284 (update_static_tracepoint): Update.
3285
cd7c32c3
PW
32862019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3287
3288 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3289 conversion of gdb_datadir.
3290 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3291 remove not needed c_str ().
3292
8fe0f950
AT
32932019-09-30 Ali Tamur <tamur@google.com>
3294
3295 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3296 (dwarf2_string_attr): Likewise.
3297
5f48f8f3
AT
32982019-09-30 Ali Tamur <tamur@google.com>
3299
3300 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3301 (process_full_type_unit): Likewise.
3302 (dump_die_shallow): Likewise.
3303 (cu_debug_loc_section): Likewise.
3304
6fb08628
CB
33052019-09-28 Christian Biesinger <cbiesinger@google.com>
3306
3307 * minsyms.c (compare_minimal_symbols): Rename to...
3308 (minimal_symbol_is_less_than): ...this, and adjust to STL
3309 conventions (return bool, take arguments as references)
3310 (minimal_symbol_reader::install): Call std::sort instead
3311 of qsort.
3312
c7ee338a
CB
33132019-09-29 Christian Biesinger <cbiesinger@google.com>
3314
3315 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3316 hash and why.
3317 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3318 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3319
703a86c2
SM
33202019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3321
3322 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3323 * psympriv.h (add_psymbol_to_list): Move comment here and update
3324 it.
3325
0df0352a
TV
33262019-09-29 Tom de Vries <tdevries@suse.de>
3327
3328 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3329 Use $tmpdir/$(basename "$output_file").dwz instead of
3330 "${output_file}.dwz".
3331
ad75efa6
SM
33322019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3333
3334 PR gdb/25045
3335 * hppa-linux-nat.c: Include gdbarch.h.
3336
ececd218
CB
33372019-09-26 Christian Biesinger <cbiesinger@google.com>
3338
3339 * blockframe.c (find_pc_partial_function): Change return type to bool.
3340 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3341 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3342 (stub_gnu_ifunc_resolve_name): Likewise.
3343 * symtab.c (compare_filenames_for_search): Likewise.
3344 (compare_glob_filenames_for_search): Likewise.
3345 (matching_obj_sections): Likewise.
3346 (symbol_matches_domain): Likewise.
3347 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3348 (find_line_pc): Change return type to bool.
3349 (find_line_pc_range): Likewise.
3350 (producer_is_realview): Likewise.
3351 * symtab.h (symbol_matches_domain): Likewise.
3352 (find_pc_partial_function): Likewise.
3353 (find_pc_line_pc_range): Likewise.
3354 (in_gnu_ifunc_stub): Likewise.
3355 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3356 (find_line_pc): Likewise.
3357 (find_line_pc_range): Likewise.
3358 (matching_obj_sections): Likewise.
3359 (find_line_symtab): Change out parameter to bool.
3360 (producer_is_realview): Change return type to bool.
3361 (compare_filenames_for_search): Likewise.
3362 (compare_glob_filenames_for_search): Likewise.
3363
27a900b8
TT
33642019-09-26 Tom Tromey <tom@tromey.com>
3365
3366 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3367 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3368 * gdb_usleep.h: Remove.
3369 * gdb_usleep.c: Remove.
3370 * utils.c: Don't include gdb_usleep.h.
3371
5d63b30a
TT
33722019-09-26 Tom Tromey <tromey@adacore.com>
3373
3374 * python/py-type.c (type_to_type_object): Call check_typedef
3375 for stub types.
3376
12904d37
TT
33772019-09-26 Tom Tromey <tom@tromey.com>
3378
3379 * utils.h (initialize_utils): Don't declare.
3380 * top.c (gdb_init): Don't call initialize_utils.
3381 * utils.c (initialize_utils): Remove. Move contents...
3382 (_initialize_utils): ... here.
3383
858f25f0
TT
33842019-09-25 Tom Tromey <tom@tromey.com>
3385
3386 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3387 * utils.h (make_hex_string): Don't declare.
3388 * utils.c (make_hex_string): Remove.
3389
3d435220
TV
33902019-09-24 Tom de Vries <tdevries@suse.de>
3391
3392 PR gdb/23815
3393 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3394 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3395
ddd44b70
DD
33962019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3397
3398 * NEWS: Mention new simulator port for PRU.
3399
f945dedf
CB
34002019-09-23 Christian Biesinger <cbiesinger@google.com>
3401
3402 * ada-exp.y (write_object_remaining): Update.
3403 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3404 and eliminate the static buffer.
3405 (ada_decode_symbol): Update.
3406 (ada_la_decode): Update.
3407 (ada_sniff_from_mangled_name): Update.
3408 (is_valid_name_for_wild_match): Update.
3409 (ada_lookup_name_info::matches): Update and simplify.
3410 (name_matches_regex): Update.
3411 (ada_add_global_exceptions): Update.
3412 * ada-lang.h (ada_decode): Update signature.
3413 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3414 * dwarf-index-write.c (debug_names::insert): Update.
3415
7ab78ccb
SM
34162019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3417
3418 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3419 formatting.
3420
9252448b
SM
34212019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3422
3423 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3424 Change "nonzero" to "true" in documentation.
3425
626ca2c0
CB
34262019-09-20 Christian Biesinger <cbiesinger@google.com>
3427
3428 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3429 (_initialize_darwin_solib): Don't set
3430 darwin_so_ops.lookup_lib_global_symbol.
3431 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3432 set_gdbarch_iterate_over_objfiles_in_search_order.
3433 (elf_lookup_lib_symbol): Rename to...
3434 (svr4_iterate_over_objfiles_in_search_order): this, and update
3435 to iterate semantics.
3436 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3437 * solib.c (solib_global_lookup): Remove.
3438 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3439 (solib_global_lookup): Remove.
3440 * symtab.c (lookup_global_or_static_symbol): Remove call to
3441 solib_global_lookup.
3442
5a3a0d63
JB
34432019-09-20 Joel Brobecker <brobecker@adacore.com>
3444
3445 * NEWS: Move entries about default MI version now being
3446 version 3, and about the GDB/MI fix for multi-location
3447 breakpoints to the "since GDB 8.3" section.
3448
ffea1427
JB
34492019-09-20 Joel Brobecker <brobecker@adacore.com>
3450
3451 GDB 8.3.1 released.
3452
abf516c6
UW
34532019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3454
3455 * NEWS: Mention that Cell/B.E. debugging support was removed.
3456 * MAINTAINERS: Remove spu target.
3457
3458 * config/djgpp/fnchange.lst: Remove entries for removed files.
3459
3460 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3461 spu-multiarch.o, and spu-tdep.o.
3462 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3463 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3464 spu-multiarch.c, and spu-tdep.c.
3465 * spu-linux-nat.c: Remove file.
3466 * spu-multiarch.c: Remove file.
3467 * spu-tdep.c: Remove file.
3468 * spu-tdep.h: Remove file.
3469 * solib-spu.c: Remove file.
3470 * solib-spu.h: Remove file.
3471
3472 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3473 * configure.nat (spu-linux): Remove.
3474 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3475 solib-multiarch.o from gdb_target_obs.
3476 (spu*-*-*): Remove.
3477
3478 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3479 feature flag.
3480 (ppc_linux_no_features): Update.
3481 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3482 Cell/B.E. support.
3483 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3484 (tdesc_powerpc_cell64l): Likewise.
3485 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3486 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3487 Cell/B.E. support.
3488 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3489 Do not include "features/rs6000/powerpc-cell32l.c" or
3490 "features/rs6000/powerpc-cell64l.c".
3491 (ppc_linux_spu_section): Remove.
3492 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3493 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3494 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3495 (ppc_linux_spe_context_lookup): Remove.
3496 (ppc_linux_spe_context_inferior_created): Remove.
3497 (ppc_linux_spe_context_solib_loaded): Remove.
3498 (ppc_linux_spe_context_solib_unloaded): Remove.
3499 (ppc_linux_spe_context): Remove.
3500 (struct ppu2spu_cache): Remove.
3501 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3502 (struct ppu2spu_data): Remove.
3503 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3504 ppu2spu_unwind): Remove.
3505 (ppc_linux_init_abi): Remove Cell/B.E. support.
3506 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3507
3508 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3509 (rs6000/powerpc-cell64l-expedite): Likewise
3510 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3511 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3512 rs6000/powerpc-cell64l.xml.
3513 * features/rs6000/powerpc-cell32l.xml: Remove.
3514 * features/rs6000/powerpc-cell64l.xml: Likewise.
3515 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3516 * features/rs6000/powerpc-cell64l.c: Likewise.
3517 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3518 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3519 * regformats/reg-spu.dat: Remove.
3520
3521 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3522 * corelow.c (struct spuid_list): Remove.
3523 (add_to_spuid_list): Remove.
3524 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3525 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3526 (remote_protocol_features): Remove associated entries.
3527 (_initialize_remote): No longer initialize them.
3528 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3529 * linux-nat.c (SPUFS_MAGIC): Remove.
3530 (linux_proc_xfer_spu): Remove.
3531 (spu_enumerate_spu_ids): Remove.
3532 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3533 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3534 (linux_make_corefile_notes): No longer call it.
3535
3536 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3537 (cooked_write_test): Likewise.
3538
78e8cb91
TT
35392019-09-20 Tom Tromey <tom@tromey.com>
3540
3541 * NEWS: Mention case-sensitivity of TUI commands.
3542 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3543 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3544 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3545
f074b67e
TT
35462019-09-20 Tom Tromey <tom@tromey.com>
3547
3548 * tui/tui-source.c (tui_source_window::set_contents): Use
3549 make_unique_xstrdup.
3550 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3551 make_unique_xstrdup.
3552
63c4bf19
TT
35532019-09-20 Tom Tromey <tom@tromey.com>
3554
3555 * tui/tui-data.c: Remove separator comments.
3556 * tui/tui-layout.c: Remove separator comments.
3557 * tui/tui-win.c: Remove separator comments.
3558 * tui/tui-wingeneral.c: Remove separator comments.
3559
43df9b2f
TT
35602019-09-20 Tom Tromey <tom@tromey.com>
3561
3562 * tui/tui.h (strcat_to_buf): Don't declare.
3563 * tui/tui.c (strcat_to_buf): Remove.
3564
7226433c
TT
35652019-09-20 Tom Tromey <tom@tromey.com>
3566
3567 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3568 from "fullname".
3569 * tui/tui-source.c (tui_source_window::set_contents)
3570 (tui_source_window::location_matches_p)
3571 (tui_source_window::maybe_update): Update.
3572
80df3337
TT
35732019-09-20 Tom Tromey <tom@tromey.com>
3574
3575 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3576 Update.
3577 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3578 prefix.
3579 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3580 (tui_data_window::line_from_reg_element_no)
3581 (tui_data_window::first_reg_element_no_inline)
3582 (tui_data_window::show_registers)
3583 (tui_data_window::show_register_group)
3584 (tui_data_window::display_registers_from)
3585 (tui_data_window::display_registers_from_line)
3586 (tui_data_window::first_data_item_displayed)
3587 (tui_data_window::delete_data_content_windows)
3588 (tui_data_window::erase_data_content)
3589 (tui_data_window::do_scroll_vertical)
3590 (tui_data_window::refresh_window)
3591 (tui_data_window::check_register_values): Update.
3592
9923f347
TT
35932019-09-20 Tom Tromey <tom@tromey.com>
3594
3595 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3596 (struct tui_locator_window) <full_name, proc_name>: Now
3597 std::string.
3598 * tui/tui-stack.c (tui_locator_window::make_status_line)
3599 (tui_locator_window::set_locator_fullname)
3600 (tui_locator_window::set_locator_info): Update.
3601 * tui/tui-source.c (tui_source_window::set_contents)
3602 (tui_source_window::showing_source_p): Update.
3603
b76251ab
TT
36042019-09-20 Tom Tromey <tom@tromey.com>
3605
3606 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3607 Don't call tui_locator_win_info_ptr.
3608
0891be08
TT
36092019-09-20 Tom Tromey <tom@tromey.com>
3610
3611 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3612
1b935acf
TT
36132019-09-20 Tom Tromey <tom@tromey.com>
3614
3615 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3616 height for locator.
3617 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3618 * tui/tui-layout.c (show_source_disasm_command, show_data)
3619 (show_source_or_disasm_and_command): Use 1 as height for locator.
3620
9abd8a65
TT
36212019-09-20 Tom Tromey <tom@tromey.com>
3622
3623 * tui/tui.c (tui_enable): Update.
3624 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3625 Update.
3626 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3627 Update.
3628 * tui/tui-data.c (win_resized): Now bool.
3629 (tui_win_resized): Return bool.
3630 (tui_set_win_resized_to): Accept a bool.
3631
b5457826
TT
36322019-09-20 Tom Tromey <tom@tromey.com>
3633
3634 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3635 Change type of "refresh_values_only".
3636 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3637 type of "refresh_values_only".
3638
6b915f7d
TT
36392019-09-20 Tom Tromey <tom@tromey.com>
3640
3641 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3642 std::string.
3643 (tui_disassemble): Add "pos" parameter.
3644 (tui_disasm_window::set_contents): Simplify.
3645
2ad52f6f
TT
36462019-09-20 Tom Tromey <tom@tromey.com>
3647
3648 * tui/tui-winsource.h (struct tui_source_window_base)
3649 <show_source_content>: Now private.
3650 * tui/tui-winsource.c
3651 (tui_source_window_base::show_source_content): Don't handle empty
3652 content case.
3653
b3b1bde6
TT
36542019-09-20 Tom Tromey <tom@tromey.com>
3655
3656 * tui/tui-layout.c (show_source_disasm_command)
3657 (show_source_or_disasm_and_command): Don't call
3658 show_source_content.
3659
71a25ed2
TT
36602019-09-20 Tom Tromey <tom@tromey.com>
3661
3662 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3663 Declare.
3664 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3665 from tui_make_status_line.
3666 (tui_locator_window::rerender): Update.
3667
f8532154
TT
36682019-09-20 Tom Tromey <tom@tromey.com>
3669
3670 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3671 (tui_locator_window::rerender): Update.
3672
2d81b349
TT
36732019-09-20 Tom Tromey <tom@tromey.com>
3674
3675 * tui/tui-winsource.h (struct tui_source_window_base)
3676 <~tui_source_window_base>: Don't declare.
3677 <fullname>: Remove.
3678 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3679 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3680 member.
3681 * tui/tui-source.c (tui_source_window::set_contents): Update.
3682 (tui_source_window::location_matches_p)
3683 (tui_source_window::maybe_update): Update.
3684
f14bec58
TT
36852019-09-20 Tom Tromey <tom@tromey.com>
3686
3687 * tui/tui-winsource.h (~tui_source_element): Remove.
3688 (tui_source_element): Update.
3689 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3690 * tui/tui-winsource.c (tui_show_source_line): Update.
3691 * tui/tui-source.c (tui_source_window::set_contents): Update.
3692 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3693
78d5933a
TT
36942019-09-20 Tom Tromey <tom@tromey.com>
3695
3696 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3697 declare.
3698 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3699 tui_clear_source_windows_detail.
3700 * tui/tui-winsource.h (struct tui_source_window_base)
3701 <clear_detail>: Don't declare.
3702 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3703 Remove.
3704 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3705
d4207696
TT
37062019-09-20 Tom Tromey <tromey@adacore.com>
3707
3708 PR ada/24919:
3709 * block.c (contained_in): Fix final return value.
3710
00f93c44
AM
37112019-09-20 Alan Modra <amodra@gmail.com>
3712
3713 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3714 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3715 (read_indirect_string_from_dwz): Use bfd accessor.
3716 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3717 * machoread.c (macho_symfile_read_all_oso): Likewise.
3718 * solib.c (solib_bfd_open): Likewise.
3719
e4153ae6
CB
37202019-09-19 Christian Biesinger <cbiesinger@google.com>
3721
3722 * eval.c: Move declaration of overload_resolution to...
3723 * value.h: ...here.
3724
c7ae7675
CB
37252019-09-19 Christian Biesinger <cbiesinger@google.com>
3726
3727 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3728 * arm-linux-tdep.c: Likewise.
3729 * arm-nbsd-nat.c: Likewise.
3730 * arm-tdep.h: Declare arm_apcs_32.
3731 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3732
e86f08d2
CB
37332019-09-19 Christian Biesinger <cbiesinger@google.com>
3734
3735 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3736 * dwarf2read.h: Declare dwarf_always_disassemble.
3737
f64e2f40
TV
37382019-09-19 Tom de Vries <tdevries@suse.de>
3739
3740 PR gdb/25009
3741 * source-cache.c (source_cache::ensure): Catch exception thrown during
3742 construction of the highlighter.
3743
fd361982
AM
37442019-09-18 Alan Modra <amodra@gmail.com>
3745
3746 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3747 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3748 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3749 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3750 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3751 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3752 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3753 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3754 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3755 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3756 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3757 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3758 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3759 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3760 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3761 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3762 * mi/mi-interp.c: Update throughout for bfd section macro and
3763 function changes.
3764 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3765 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3766
11061048
TT
37672019-09-18 Tom Tromey <tom@tromey.com>
3768
3769 * NEWS: Add entry.
3770 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3771 call rl_initialize.
3772 (tui_enable): Do not call rl_initialize.
3773
7a27b85f
CG
37742019-09-18 Christian Groessler <chris@groessler.org>
3775
3776 * alpha-linux-nat.c: Include gdbarch.h.
3777
f64eea3a
SM
37782019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3779
3780 * ui-file.c: Include cli/cli-style.h.
3781 (term_cli_styling): Remove cli_styling declaration.
3782
e6f7f6d1
AM
37832019-09-18 Alan Modra <amodra@gmail.com>
3784
3785 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3786 to bfd_asymbol_section.
3787
1d38e9d1
AM
37882019-09-18 Alan Modra <amodra@gmail.com>
3789
3790 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3791 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3792 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3793
90d92a63
AM
37942019-09-18 Alan Modra <amodra@gmail.com>
3795
3796 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3797 * spu-linux-nat.c (spu_bfd_open): Likewise.
3798
a3d181d2
CB
37992019-09-18 Christian Biesinger <cbiesinger@google.com>
3800
3801 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3802 to bool to match definition in dwarf2read.c.
3803
491144b5
CB
38042019-09-17 Christian Biesinger <cbiesinger@google.com>
3805
3806 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3807 (print_signatures): Likewise.
3808 (trust_pad_over_xvs): Likewise.
3809 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3810 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3811 * arm-linux-nat.c (arm_apcs_32): Likewise.
3812 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3813 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3814 * arm-tdep.c (arm_debug): Likewise.
3815 (arm_apcs_32): Likewise.
3816 * auto-load.c (debug_auto_load): Likewise.
3817 (auto_load_gdb_scripts): Likewise.
3818 (global_auto_load): Likewise.
3819 (auto_load_local_gdbinit): Likewise.
3820 (auto_load_local_gdbinit_loaded): Likewise.
3821 * auto-load.h (global_auto_load): Likewise.
3822 (auto_load_local_gdbinit): Likewise.
3823 (auto_load_local_gdbinit_loaded): Likewise.
3824 * breakpoint.c (disconnected_dprintf): Likewise.
3825 (breakpoint_proceeded): Likewise.
3826 (automatic_hardware_breakpoints): Likewise.
3827 (always_inserted_mode): Likewise.
3828 (target_exact_watchpoints): Likewise.
3829 (_initialize_breakpoint): Update.
3830 * breakpoint.h (target_exact_watchpoints): Change to bool.
3831 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3832 * cli/cli-cmds.c (trace_commands): Likewise.
3833 * cli/cli-cmds.h (trace_commands): Likewise.
3834 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3835 to bool*.
3836 * cli/cli-logging.c (logging_overwrite): Change to bool.
3837 (logging_redirect): Likewise.
3838 (debug_redirect): Likewise.
3839 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3840 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3841 to bool.
3842 <boolean_option_def>: Update.
3843 (struct flag_option_def): Change default type of Context to bool
3844 from int.
3845 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3846 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3847 (get_setshow_command_value_string): Likewise.
3848 * cli/cli-style.c (cli_styling): Change to bool.
3849 (source_styling): Likewise.
3850 * cli/cli-style.h (source_styling): Likewise.
3851 (cli_styling): Likewise.
3852 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3853 to bool.
3854 * command.h (var_types): Update comment.
3855 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3856 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3857 bool.
3858 (debug_compile_cplus_scopes): Likewise.
3859 * compile/compile-internal.h (compile_debug): Likewise.
3860 * compile/compile.c (compile_debug): Likewise.
3861 (struct compile_options) <raw>: Likewise.
3862 * cp-support.c (catch_demangler_crashes): Likewise.
3863 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3864 (usr_cmd_cris_dwarf2_cfi): Likewise.
3865 * csky-tdep.c (csky_debug): Likewise.
3866 * darwin-nat.c (enable_mach_exceptions): Likewise.
3867 * dcache.c (dcache_enabled_p): Likewise.
3868 * defs.h (info_verbose): Likewise.
3869 * demangle.c (demangle): Likewise.
3870 (asm_demangle): Likewise.
3871 * dwarf-index-cache.c (debug_index_cache): Likewise.
3872 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3873 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3874 * dwarf2read.c (check_physname): Likewise.
3875 (use_deprecated_index_sections): Likewise.
3876 (dwarf_always_disassemble): Likewise.
3877 * eval.c (overload_resolution): Likewise.
3878 * event-top.c (set_editing_cmd_var): Likewise.
3879 (exec_done_display_p): Likewise.
3880 * event-top.h (set_editing_cmd_var): Likewise.
3881 (exec_done_display_p): Likewise.
3882 * exec.c (write_files): Likewise.
3883 * fbsd-nat.c (debug_fbsd_lwp): Likewise
3884 (debug_fbsd_nat): Likewise.
3885 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3886 Likewise.
3887 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3888 <backtrace_past_entry> Likewise.
3889 * gdb-demangle.h (demangle): Likewise.
3890 (asm_demangle): Likewise.
3891 * gdb_bfd.c (bfd_sharing): Likewise.
3892 * gdbcore.h (write_files): Likewise.
3893 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3894 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3895 * gdbthread.h (print_thread_events): Likewise.
3896 * gdbtypes.c (opaque_type_resolution): Likewise.
3897 (strict_type_checking): Likewise.
3898 * gnu-nat.c (gnu_debug_flag): Likewise.
3899 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3900 * guile/scm-param.c (pascm_variable): Add boolval.
3901 (add_setshow_generic): Update.
3902 (pascm_param_value): Update.
3903 (pascm_set_param_value_x): Update.
3904 * hppa-tdep.c (hppa_debug): Change to bool..
3905 * infcall.c (may_call_functions_p): Likewise.
3906 (coerce_float_to_double_p): Likewise.
3907 (unwind_on_signal_p): Likewise.
3908 (unwind_on_terminating_exception_p): Likewise.
3909 * infcmd.c (startup_with_shell): Likewise.
3910 * inferior.c (print_inferior_events): Likewise.
3911 * inferior.h (startup_with_shell): Likewise.
3912 (print_inferior_events): Likewise.
3913 * infrun.c (step_stop_if_no_debug): Likewise.
3914 (detach_fork): Likewise.
3915 (debug_displaced): Likewise.
3916 (disable_randomization): Likewise.
3917 (non_stop): Likewise.
3918 (non_stop_1): Likewise.
3919 (observer_mode): Likewise.
3920 (observer_mode_1): Likewise.
3921 (set_observer_mode): Update.
3922 (sched_multi): Change to bool.
3923 * infrun.h (debug_displaced): Likewise.
3924 (sched_multi): Likewise.
3925 (step_stop_if_no_debug): Likewise.
3926 (non_stop): Likewise.
3927 (disable_randomization): Likewise.
3928 * linux-tdep.c (use_coredump_filter): Likewise.
3929 (dump_excluded_mappings): Likewise.
3930 * linux-thread-db.c (auto_load_thread_db): Likewise.
3931 (check_thread_db_on_load): Likewise.
3932 * main.c (captured_main_1): Update.
3933 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3934 xx2_opt, boolean_opt>: Change to bool.
3935 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3936 * maint.c (maintenance_profile_p): Likewise.
3937 (per_command_time): Likewise.
3938 (per_command_space): Likewise.
3939 (per_command_symtab): Likewise.
3940 * memattr.c (inaccessible_by_default): Likewise.
3941 * mi/mi-main.c (mi_async): Likewise.
3942 (mi_async_1): Likewise.
3943 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3944 * nat/fork-inferior.h (startup_with_shell): Likewise.
3945 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3946 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3947 * nios2-tdep.c (nios2_debug): Likewise.
3948 * or1k-tdep.c (or1k_debug): Likewise.
3949 * parse.c (parser_debug): Likewise.
3950 * parser-defs.h (parser_debug): Likewise.
3951 * printcmd.c (print_symbol_filename): Likewise.
3952 * proc-api.c (procfs_trace): Likewise.
3953 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3954 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3955 (set_parameter_value): Update.
3956 (add_setshow_generic): Update.
3957 * python/py-value.c (copy_py_bool_obj): Change argument from int*
3958 to bool*.
3959 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3960 int*.
3961 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3962 * record-btrace.c (record_btrace_target::store_registers): Update.
3963 * record-full.c (record_full_memory_query): Change to bool.
3964 (record_full_stop_at_limit): Likewise.
3965 * record-full.h (record_full_memory_query): Likewise.
3966 * remote-notif.c (notif_debug): Likewise.
3967 * remote-notif.h (notif_debug): Likewise.
3968 * remote.c (use_range_stepping): Likewise.
3969 (interrupt_on_connect): Likewise.
3970 (remote_break): Likewise.
3971 * ser-tcp.c (tcp_auto_retry): Likewise.
3972 * ser-unix.c (serial_hwflow): Likewise.
3973 * skip.c (debug_skip): Likewise.
3974 * solib-aix.c (solib_aix_debug): Likewise.
3975 * spu-tdep.c (spu_stop_on_load_p): Likewise.
3976 (spu_auto_flush_cache_p): Likewise.
3977 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3978 Likewise.
3979 (struct info_print_options) <quiet>: Likewise.
3980 * symfile-debug.c (debug_symfile): Likewise.
3981 * symfile.c (auto_solib_add): Likewise.
3982 (separate_debug_file_debug): Likewise.
3983 * symfile.h (auto_solib_add): Likewise.
3984 (separate_debug_file_debug): Likewise.
3985 * symtab.c (basenames_may_differ): Likewise.
3986 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3987 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3988 (struct info_types_options) <quiet>: Likewise.
3989 * symtab.h (demangle): Likewise.
3990 (basenames_may_differ): Likewise.
3991 * target-dcache.c (stack_cache_enabled_1): Likewise.
3992 (code_cache_enabled_1): Likewise.
3993 * target.c (trust_readonly): Likewise.
3994 (may_write_registers): Likewise.
3995 (may_write_memory): Likewise.
3996 (may_insert_breakpoints): Likewise.
3997 (may_insert_tracepoints): Likewise.
3998 (may_insert_fast_tracepoints): Likewise.
3999 (may_stop): Likewise.
4000 (auto_connect_native_target): Likewise.
4001 (target_stop_and_wait): Update.
4002 (target_async_permitted): Change to bool.
4003 (target_async_permitted_1): Likewise.
4004 (may_write_registers_1): Likewise.
4005 (may_write_memory_1): Likewise.
4006 (may_insert_breakpoints_1): Likewise.
4007 (may_insert_tracepoints_1): Likewise.
4008 (may_insert_fast_tracepoints_1): Likewise.
4009 (may_stop_1): Likewise.
4010 * target.h (target_async_permitted): Likewise.
4011 (may_write_registers): Likewise.
4012 (may_write_memory): Likewise.
4013 (may_insert_breakpoints): Likewise.
4014 (may_insert_tracepoints): Likewise.
4015 (may_insert_fast_tracepoints): Likewise.
4016 (may_stop): Likewise.
4017 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4018 (make_thread_apply_all_options_def_group): Change argument from int*
4019 to bool*.
4020 (thread_apply_all_command): Update.
4021 (print_thread_events): Change to bool.
4022 * top.c (confirm): Likewise.
4023 (command_editing_p): Likewise.
4024 (history_expansion_p): Likewise.
4025 (write_history_p): Likewise.
4026 (info_verbose): Likewise.
4027 * top.h (confirm): Likewise.
4028 (history_expansion_p): Likewise.
4029 * tracepoint.c (disconnected_tracing): Likewise.
4030 (circular_trace_buffer): Likewise.
4031 * typeprint.c (print_methods): Likewise.
4032 (print_typedefs): Likewise.
4033 * utils.c (debug_timestamp): Likewise.
4034 (sevenbit_strings): Likewise.
4035 (pagination_enabled): Likewise.
4036 * utils.h (sevenbit_strings): Likewise.
4037 (pagination_enabled): Likewise.
4038 * valops.c (overload_resolution): Likewise.
4039 * valprint.h (struct value_print_options) <prettyformat_arrays,
4040 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4041 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4042 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4043 Likewise.
4044 * windows-nat.c (new_console): Likewise.
4045 (cygwin_exceptions): Likewise.
4046 (new_group): Likewise.
4047 (debug_exec): Likewise.
4048 (debug_events): Likewise.
4049 (debug_memory): Likewise.
4050 (debug_exceptions): Likewise.
4051 (useshell): Likewise.
4052 * windows-tdep.c (maint_display_all_tib): Likewise.
4053 * xml-support.c (debug_xml): Likewise.
4054
f1b620e9
MG
40552019-09-17 Mike Gulick <mgulick@mathworks.com>
4056
4057 * source.c (prepare_path_for_appending): New function.
4058 (openp): Make use of new function.
4059 (find_and_open_source): Search for the compilation directory and
4060 source file as a relative path beneath the directory search path.
4061
67f3ed6a
AB
40622019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4063
4064 * source-cache.c (source_cache::get_line_charpos): Catch
4065 exceptions and return false, this matches the behaviour documented
4066 in the header file.
4067
74332189
JB
40682019-09-17 Joel Brobecker <brobecker@adacore.com>
4069
4070 * ada-tasks.c (info_task): Remove quoting of the task's name.
4071
f2f24aa9
CB
40722019-09-16 Christian Biesinger <cbiesinger@google.com>
4073
4074 * symfile.c (auto_solib_add): Replace comment with a reference
4075 to the header file.
4076
6a062a93
CB
40772019-09-14 Christian Biesinger <cbiesinger@google.com>
4078
4079 * NEWS: Mention that gdb can now be compiled with Python 3
4080 on Windows.
4081
ec6c8338
AB
40822019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4083
4084 * maint.c (maint_print_section_data::maint_print_section_data):
4085 Force use of 'float log10 (float)' by casting the argument to
4086 float.
4087
aa17805f
AB
40882019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4089
4090 * maint.c: Add 'cmath' include.
4091 (struct maint_print_section_data): New structure.
4092 (print_section_index): New function.
4093 (print_bfd_section_info): Add header comment, small whitespace
4094 cleanup, and update to call new print_section_index function.
4095 (print_objfile_section_info): Likewise.
4096 (maint_obj_section_from_bfd_section): New function.
4097 (print_bfd_section_info_maybe_relocated): New function.
4098 (maintenance_info_sections): Add header comment, always use
4099 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4100
3dd9bb46
AB
41012019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4102
4103 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4104 inner scope, add check that the objfile has psymtabs before
4105 checking psymtabs_addrmap.
4106 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4107
4993045d
PW
41082019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4109
4110 * NEWS: Announce that Ada task names are now shown at more places,
4111 and between quotes (except in info task output).
4112 * gdb/ada-tasks.c (task_to_str): New function.
4113 (display_current_task_id): Call task_to_str.
4114 (task_command_1): Likewise.
4115 (print_ada_task_info): In non-mi mode, Properly align headers and data
4116 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4117
7a289707
RO
41182019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4119
4120 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4121 prstatus.pr_lwp.pr_info instead of making it up.
4122
f2aec7f6
CB
41232019-09-11 Christian Biesinger <cbiesinger@google.com>
4124
4125 * auto-load.c (auto_load_expand_dir_vars): Update.
4126 * defs.h (gdb_datadir): Change to std::string.
4127 (python_libdir): Likewise.
4128 (relocate_gdb_directory): Change return type to std::string.
4129 * guile/guile.c (gdbscm_data_directory): Update.
4130 (initialize_scheme_side): Update.
4131 * jit.c (jit_reader_dir): Change to std::string.
4132 (jit_reader_load_command): Update.
4133 * main.c (gdb_datadir): Change to std::string.
4134 (python_libdir): Likewise.
4135 (set_gdb_data_directory): Update.
4136 (relocate_path): Change to return std::string.
4137 (relocate_gdb_directory): Change to return std::string.
4138 (relocate_gdbinit_path_maybe_in_datadir): Update.
4139 (captured_main_1): Update.
4140 * python/python.c (do_start_initialization): Update.
4141 * top.c (show_gdb_datadir): Update.
4142 * xml-syscall.c (xml_init_syscalls_info): Update.
4143 (init_syscalls_info): Update.
4144
9224a013
CB
41452019-09-11 Christian Biesinger <cbiesinger@google.com>
4146
4147 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4148 out of get_init_files.
4149 (get_init_files): Update.
4150
f48cd836
CB
41512019-09-11 Christian Biesinger <cbiesinger@google.com>
4152
4153 * main.c (get_init_files): Change to use std::string.
4154 (captured_main_1): Update.
4155 (print_gdb_help): Update.
4156
9cab7ecd
AT
41572019-09-11 Ali Tamur <tamur@google.com>
4158
4159 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4160 implementation.
4161
67547d89
CB
41622019-09-11 Christian Biesinger <cbiesinger@google.com>
4163
4164 * dbxread.c (read_dbx_symtab): Update.
4165 * dwarf2read.c (load_partial_dies): Update.
4166 * mdebugread.c (parse_partial_symbols): Update.
4167 (handle_psymbol_enumerators): Update.
4168 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4169 * psymtab.c (add_psymbol_to_bcache): Likewise.
4170 (add_psymbol_to_list): Likewise.
4171 * symtab.c (symbol_set_names): Likewise.
4172 * symtab.h (symbol_set_names): Likewise.
4173 * xcoffread.c (scan_xcoff_symtab): Update.
4174
64b2d4a0
TT
41752019-09-11 Tom Tromey <tom@tromey.com>
4176
4177 * symfile-mem.c (symbol_file_add_from_memory): Use
4178 bfd_set_filename.
4179 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4180 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4181
3b00ef10
TT
41822019-09-10 Tom Tromey <tromey@adacore.com>
4183
4184 * dwarf-index-write.c (write_psymbols): Extend error message.
4185 (debug_names::insert): Add Ada code.
4186 (debug_names::write_psymbols): Remove Ada check.
4187 (debug_names) <m_string_obstack>: New member.
4188 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4189 (gdb_index_symbol_name_matcher::matches): Remove.
4190 (mapped_index_base::find_name_components_bounds): Add "lang"
4191 parameter.
4192 (mapped_index_base::build_name_components): Also split names
4193 according to Ada syntax.
4194 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4195 type of "match_callback".
4196 (check_match, check_find_bounds_finds)
4197 (dw2_expand_symtabs_matching): Update.
4198 (dw2_debug_names_iterator): Add new constructor.
4199 (dw2_debug_names_map_matching_symbols): New function.
4200 (dw2_debug_names_expand_symtabs_matching): Update.
4201 (dwarf2_debug_names_functions): Use
4202 dw2_debug_names_map_matching_symbols.
4203
aa391654
TT
42042019-09-10 Tom Tromey <tromey@adacore.com>
4205
4206 * dwarf2read.c (dw2_get_file_names_reader): Add the
4207 CU's file name to the results.
4208
b054970d
TT
42092019-09-10 Tom Tromey <tromey@adacore.com>
4210
4211 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4212 map_matching_symbols. Update.
4213 * dwarf2read.c (dw2_map_matching_symbols): Update.
4214 * psymtab.c (match_partial_symbol): Change type; update.
4215 (psym_map_matching_symbols): Likewise.
4216 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4217 type; update.
4218 * symfile.h (struct quick_symbol_functions)
4219 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4220 Remove "match".
4221
6a3dbf1b
TT
42222019-09-10 Tom Tromey <tromey@adacore.com>
4223
4224 * psymtab.c (map_block): Remove.
4225 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4226 * symtab.c (iterate_over_symbols_terminated): New function.
4227 * symtab.c (iterate_over_symbols_terminated): Declare.
4228
6969f124
TT
42292019-09-10 Tom Tromey <tromey@adacore.com>
4230
4231 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4232 * language.h (struct language_defn) <la_iterate_over_symbols>:
4233 Return bool.
4234 * symtab.c (iterate_over_symbols): Return bool.
4235 * symtab.h (iterate_over_symbols): Return bool.
4236
199b4314
TT
42372019-09-10 Tom Tromey <tromey@adacore.com>
4238
4239 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4240 (add_nonlocal_symbols): Update.
4241 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4242 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4243 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4244 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4245 Change type of "callback". Remove "data".
4246
a084a2a6
AT
4247
42482019-09-09 Ali Tamur <tamur@google.com>
4249
4250 * dwarf2read.c (comp_unit_head): Update comment.
4251 (dwarf2_dwo_name): New function declaration.
4252 (dwarf_unit_type_name): New function declaration.
4253 (read_comp_unit_head): Add support for new compilation units,
4254 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4255 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4256 (currently named as "signature") in their header. Also clarify error
4257 messages.
4258 (lookup_dwo_id): New function. Returns the dwo id of the given
4259 compile unit.
4260 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4261 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4262 functions.
4263 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4264 (dwarf2_dwo_name): Get the dwo name if present.
4265 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4266 purposes.
4267
25a2915e
TT
42682019-09-09 Tom Tromey <tom@tromey.com>
4269
4270 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4271
e4df0874
PW
42722019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4273
4274 * python/python.c (do_start_initialization): Make progname_copy static,
4275 to avoid a leak report.
4276
8634b462
TT
42772019-09-08 Tom Tromey <tom@tromey.com>
4278
4279 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4280
c7f839cb
SM
42812019-09-07 Simon Marchi <simon.marchi@efficios.com>
4282
4283 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4284 Change type to gdb::optional<block_enum>.
4285 (dw2_symtab_iter_init): Change block_index parameter type
4286 to gdb::optional<block_enum>.
4287 (dw2_lookup_symbol): Change block_index parameter
4288 type to block_enum.c
4289 (dw2_debug_names_lookup_symbol): Likewise.
4290 * psymtab.c (psym_lookup_symbol): Likewise.
4291 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4292 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4293 Likewise.
4294
ead0e69a
CB
42952019-09-06 Christian Biesinger <cbiesinger@google.com>
4296
4297 * defs.h (relocate_gdb_directory): Change int to bool in
4298 signature and rename flag to relocatable.
4299 * main.c (relocate_path): Likewise.
4300 (relocate_gdb_directory): Likewise.
4301
b16c44de
AM
43022019-09-06 Alan Modra <amodra@gmail.com>
4303
4304 * coffread.c (coff_symfile_read): Constify filename variable.
4305 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4306 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4307 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4308 * solib.c (reload_shared_libraries_1): Likewise.
4309 * symfile.c (reread_symbols): Likewise.
4310 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4311 * solib-darwin.c (darwin_bfd_open): Likewise.
4312 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4313
06ff036e
AB
43142019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4315
4316 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4317 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4318
4e962e74
TT
43192019-09-03 Tom Tromey <tromey@adacore.com>
4320
4321 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4322 types.
4323 (has_negatives): Unbias a range type bound.
4324 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4325 * gdbtypes.c (operator==): Handle new field.
4326 (create_range_type): Add "bias" parameter.
4327 (create_static_range_type, resolve_dynamic_range): Update.
4328 * gdbtypes.h (struct range_bounds) <bias>: New member.
4329 (create_range_type): Add bias parameter.
4330 * printcmd.c (print_scalar_formatted): Unbias range types.
4331 * value.c (unpack_long): Unbias range types.
4332 (pack_long): Bias range types.
4333
d90b8f26
AH
43342019-09-02 Alan Hayward <alan.hayward@arm.com>
4335
4336 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4337 probe arguments.
4338
fe01123e
AH
43392019-09-02 Alan Hayward <alan.hayward@arm.com>
4340
4341 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4342 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4343 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4344 (compile_probe_arg): Likewise.
4345 * probe.h (get_argument_count): Likewise.
4346 * solib-svr4.c (solib_event_probe_action): Likewise.
4347 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4348
e661ef01
AH
43492019-09-02 Alan Hayward <alan.hayward@arm.com>
4350
4351 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4352 code to here...
4353 (svr4_create_solib_event_breakpoints): ...from here.
4354
47a536d9
SDJ
43552019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4356
4357 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4358 suffix from warning message.
4359
d6a00eba
TT
43602019-08-30 Tom Tromey <tom@tromey.com>
4361
4362 * tui/tui-winsource.h (struct tui_source_window_base)
4363 <refresh_all>: Don't declare.
4364 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4365 Remove.
4366 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4367 tui_show_locator_content.
4368 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4369 declare.
4370 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4371 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4372 declare.
4373
55b2657b
TT
43742019-08-30 Tom Tromey <tom@tromey.com>
4375
4376 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4377
12a8555a
TT
43782019-08-30 Tom Tromey <tom@tromey.com>
4379
4380 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4381 Remove unnecessary forward declarations.
4382
900ac242
TT
43832019-08-30 Tom Tromey <tom@tromey.com>
4384
4385 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4386 rerender.
4387 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4388 tui_show_locator_content.
4389
99ab33fb
TT
43902019-08-30 Tom Tromey <tom@tromey.com>
4391
4392 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4393 (tui_locator_window::rerender): Rewrite using body of previous
4394 tui_show_locator_content.
4395
e594a5d1
TT
43962019-08-30 Tom Tromey <tom@tromey.com>
4397
4398 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4399 set_locator_fullname>: New methods.
4400 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4401 Rename from tui_set_locator_fullname.
4402 (tui_locator_window::set_locator_info): Rename from
4403 tui_set_locator_info. Return bool.
4404 (tui_update_locator_fullname, tui_show_frame_info): Update.
4405
715bb467
TT
44062019-08-30 Tom Tromey <tom@tromey.com>
4407
4408 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4409
772f3f03
TT
44102019-08-30 Tom Tromey <tom@tromey.com>
4411
4412 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4413 call touchwin.
4414
108e13ab
TT
44152019-08-30 Tom Tromey <tom@tromey.com>
4416
4417 * tui/tui-wingeneral.c (box_win): Assume win_info and
4418 win_info->handle cannot be NULL.
4419
cdaa6eb4
TT
44202019-08-30 Tom Tromey <tom@tromey.com>
4421
4422 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4423 refresh_window>: Declare.
4424 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4425 resize.
4426 (tui_data_item_window::rerender): Rename from
4427 tui_display_register.
4428 (tui_data_item_window::refresh_window): New method.
4429 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4430 no-op.
4431
89df7f90
TT
44322019-08-30 Tom Tromey <tom@tromey.com>
4433
4434 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4435 regs_column_count, current_group>: Move later. Now private.
4436 <get_current_group>: New method.
4437 * tui/tui-regs.c (tui_reg_command): Update.
4438 * tui/tui-layout.c (tui_set_layout): Update.
4439
1bf2866a
TT
44402019-08-30 Tom Tromey <tom@tromey.com>
4441
4442 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4443 (tui_data_window::rerender): Don't call
4444 check_and_display_highlight_if_needed.
4445 (tui_data_window::refresh_all): Remove call to
4446 erase_data_content.
4447
0670413d
TT
44482019-08-30 Tom Tromey <tom@tromey.com>
4449
4450 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4451 (tui_data_window::display_registers_from)
4452 (tui_data_window::display_reg_element_at_line)
4453 (tui_data_window::display_registers_from_line): Remove checks of
4454 "empty".
4455
18bb55c7
TT
44562019-08-30 Tom Tromey <tom@tromey.com>
4457
4458 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4459 Don't declare.
4460 * tui/tui-regs.c (tui_data_window::show_registers): Call
4461 rerender.
4462 (tui_data_window::rerender): Rename from display_all_data.
4463 (tui_data_window::rerender): Remove old implementation.
4464
1f6d2f10
TT
44652019-08-30 Tom Tromey <tom@tromey.com>
4466
4467 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4468 text.
4469 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4470
16d01f9c
BW
44712019-08-29 Bernhard Wodok <barto@gmx.net>
4472 Sergio Durigan Junior <sergiodj@redhat.com>
4473
4474 PR win32/24284
4475 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4476
d8f27c60
AB
44772019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4478
4479 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4480 when searching for types.
4481
1f20c35e
AB
44822019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4483
4484 * f-lang.c (f_language_defn): Use f_print_typedef.
4485 * f-lang.h (f_print_typedef): Declare.
4486 * f-typeprint.c (f_print_typedef): Define.
4487
550105b7
CB
44882019-08-27 Christian Biesinger <cbiesinger@google.com>
4489
4490 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4491
4acfdd20
AB
44922019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4493
4494 * cli/cli-utils.c (info_print_options_defs): Delete.
4495 (make_info_print_options_def_group): Delete.
4496 (extract_info_print_options): Delete.
4497 (info_print_command_completer): Delete.
4498 (info_print_args_help): Add extra parameter, and optionally
4499 include text about -n flag.
4500 * cli/cli-utils.h (struct info_print_options): Delete.
4501 (extract_info_print_options): Delete declaration.
4502 (info_print_command_completer): Delete declaration.
4503 (info_print_args_help): Add extra parameter, extend header
4504 comment.
4505 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4506 search_symbols.
4507 * stack.c (struct info_print_options): New type.
4508 (info_print_options_defs): New file scoped variable.
4509 (make_info_print_options_def_group): New static function.
4510 (info_print_command_completer): New static function.
4511 (info_locals_command): Update to use new local functions.
4512 (info_args_command): Likewise.
4513 (_initialize_stack): Add extra parameter to calls to
4514 info_print_args_help.
4515 * symtab.c (search_symbols): Add extra parameter, use this to
4516 possibly excluse non-debug symbols.
4517 (symtab_symbol_info): Add extra parameter, which is passed on to
4518 search_symbols.
4519 (struct info_print_options): New type.
4520 (info_print_options_defs): New file scoped variable.
4521 (make_info_print_options_def_group): New static function.
4522 (info_print_command_completer): New static function.
4523 (info_variables_command): Update to use local functions, and pass
4524 extra parameter through to symtab_symbol_info.
4525 (info_functions_command): Likewise.
4526 (info_types_command): Pass additional argument through to
4527 symtab_symbol_info.
4528 (rbreak_command): Pass extra argument to search_symbols.
4529 (_initialize_symtab): Add extra arguments for calls to
4530 info_print_args_help, and update help text for 'info variables',
4531 'whereis', and 'info functions' commands.
4532 * symtab.h (search_symbols): Add extra argument to declaration.
4533 * NEWS: Mention new flags.
4534
9aa55206
CB
45352019-08-26 Christian Biesinger <cbiesinger@google.com>
4536
4537 * symtab.c (lookup_static_symbol): Call the new function (and move
4538 it down to be next to lookup_global_symbol).
4539 (struct global_sym_lookup_data): Add block_enum member and rename to...
4540 (struct global_or_static_sym_lookup_data): ...this.
4541 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4542 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4543 (lookup_symbol_global_or_static_iterator_cb): ...this.
4544 (lookup_global_or_static_symbol): New function.
4545 (lookup_global_symbol): Call new function.
4546
5c31b358
TV
45472019-08-26 Tom de Vries <tdevries@suse.de>
4548
4549 PR c++/24852
4550 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4551 when pc_probe.prob == NULL.
4552
23c13d42
SM
45532019-08-25 Simon Marchi <simon.marchi@efficios.com>
4554
4555 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4556 variable symbol_linkage to symbol_linkage_.
4557
beadd3e8
SM
45582019-08-25 Simon Marchi <simon.marchi@efficios.com>
4559
4560 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4561 represent whether the symbol is static, dynamic, or we don't
4562 know.
4563
e3ec872f
YS
45642019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4565
4566 * gdb/rx-tdep.c (rx_register_names): New.
4567 (rx_register_name): Delete.
4568 (rx_psw_type): Delete.
4569 (rx_fpsw_type): Delete.
4570 (rx_register_type): Delete.
4571 (rx_gdbarch_init): Convert target-descriptions.
4572 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4573 * gdb/features/Makefile: Add rx.xml.
4574 * gdb/features/rx.xml: New.
4575 * gdb/features/rx.c: Generated.
4576 * gdb/NEWS: Mention target description support.
4577
d0509ba4
CB
45782019-08-22 Christian Biesinger <cbiesinger@google.com>
4579
4580 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4581 *slot_ptr.
4582
2d41fa11
SDJ
45832019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4584
4585 * configure.ac: Don't check for 'dlfcn.h' (moved to
4586 gdbsupport/common.m4).
4587 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4588 'gdbsupport/'.
4589 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4590 * compile/compile-c-support.c: Include
4591 'gdbsupport/gdb-dlfcn.h'.
4592 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4593 * gdb-dlfcn.c: Move to...
4594 * gdbsupport/gdb-dlfcn.c: ... here.
4595 * gdb-dlfcn.h: Move to...
4596 * gdbsupport/gdb-dlfcn.h: ... here.
4597
de8af808
SL
45982019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4599
4600 * nios2-tdep.c (struct reg_value): Improve comments. Make
4601 the offset field signed.
4602
27204489
CB
46032019-08-22 Christian Biesinger <cbiesinger@google.com>
4604
4605 * python/lib/gdb/__init__.py (_execute_file): New function.
4606 * python/python.c (python_run_simple_file): Call gdb._execute_file
4607 on Windows.
4608
43771869
AB
46092019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4610
4611 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4612 all uses as this was never set to anything but a zero value.
4613
26c957f1
PA
46142019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4615
4616 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4617
c07aae6e
CB
46182019-08-21 Christian Biesinger <cbiesinger@google.com>
4619
4620 * tui/tui-data.h (tui_gen_win_info): Add an =default
4621 move constructor, required by some GCC versions.
4622
3960cb7a
JF
46232019-08-21 Jinke Fan <fanjinke51@yeah.net>
4624
4625 * go32-nat.c (go32_sysinfo): Add hygon_p.
4626
04c72a68
TT
46272019-08-20 Tom Tromey <tom@tromey.com>
4628
4629 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4630 line_from_reg_element_no, first_reg_element_no_inline,
4631 display_all_data, delete_data_content_windows,
4632 erase_data_content>: Now private.
4633
072272ce
TT
46342019-08-20 Tom Tromey <tom@tromey.com>
4635
4636 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4637 (tui_unhighlight_win, tui_highlight_win)
4638 (tui_win_info::make_window): Update.
4639 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4640
973961bd
TT
46412019-08-20 Tom Tromey <tom@tromey.com>
4642
4643 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4644 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4645 (MAX_PID_WIDTH): Move to tui-stack.c.
4646 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4647 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4648 (MAX_PID_WIDTH): Move from tui-data.h.
4649
ab0e1f1a
TT
46502019-08-20 Tom Tromey <tom@tromey.com>
4651
4652 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4653 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4654 (box_win): Update.
4655 (tui_gen_win_info::make_window): Rename from tui_make_window.
4656 (tui_win_info::make_window): New method.
4657 (tui_gen_win_info::make_visible): Update.
4658 * tui/tui-source.c (tui_source_window::set_contents): Update.
4659 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4660 (tui_data_window::display_registers_from): Update.
4661 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4662 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4663 Declare.
4664 <can_box>: Remove.
4665 <title>: Remove.
4666 (struct tui_win_info) <make_window>: Declare.
4667 <can_box>: Now virtual.
4668 <title>: New member.
4669 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4670 * tui/tui-command.c (tui_cmd_window::resize): Update.
4671
100c2bf3
TT
46722019-08-20 Tom Tromey <tom@tromey.com>
4673
4674 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4675 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4676 (tui_data_window::check_register_values): Update.
4677
fa4dc567
TT
46782019-08-20 Tom Tromey <tom@tromey.com>
4679
4680 * tui/tui-regs.h (struct tui_data_window): Use
4681 DISABLE_COPY_AND_ASSIGN.
4682 <regs_content>: Change type, removing unique_ptr.
4683 <tui_data_window>: Add move constructor.
4684 * tui/tui-regs.c (tui_data_window::show_registers)
4685 (tui_data_window::show_register_group)
4686 (tui_data_window::display_registers_from)
4687 (tui_data_window::display_registers_from)
4688 (tui_data_window::first_data_item_displayed)
4689 (tui_data_window::delete_data_content_windows)
4690 (tui_data_window::rerender, tui_data_window::refresh_window)
4691 (tui_data_window::check_register_values): Update.
4692
ca02d7c8
TT
46932019-08-20 Tom Tromey <tom@tromey.com>
4694
4695 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4696 show_register_group>: Declare.
4697 (tui_show_register_group): Don't declare.
4698 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4699 tui_show_registers.
4700 (tui_data_window::show_register_group): Rename from
4701 tui_show_register_group.
4702 (tui_data_window::check_register_values, tui_reg_command):
4703 Update.
4704 * tui/tui-layout.c (tui_set_layout): Update.
4705
63356bfd
TT
47062019-08-20 Tom Tromey <tom@tromey.com>
4707
4708 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4709 Declare.
4710 (tui_check_register_values): Don't declare.
4711 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4712 from tui_check_register_values.
4713 * tui/tui-hooks.c (tui_register_changed): Update.
4714
42cc14a7
TT
47152019-08-20 Tom Tromey <tom@tromey.com>
4716
4717 * tui/tui-regs.c (tui_reg_layout): Move later.
4718 (tui_show_registers): Don't enable TUI mode or change layout.
4719
b9ad3686
TT
47202019-08-20 Tom Tromey <tom@tromey.com>
4721
4722 * tui/tui-regs.h (struct tui_data_item_window)
4723 <~tui_data_item_window>: Remove.
4724 <content>: Now a unique_xmalloc_ptr.
4725 * tui/tui-regs.c (tui_register_format): Return a
4726 unique_xmalloc_ptr.
4727 (tui_get_register): Update.
4728 (~tui_data_item_window): Remove.
4729 (tui_data_window::display_registers_from, tui_display_register):
4730 Update.
4731 * tui/tui-io.h (tui_expand_tabs): Update.
4732 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4733 Remove "col" parameter.
4734
8e114aab
TT
47352019-08-20 Tom Tromey <tom@tromey.com>
4736
4737 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4738 field.
4739 * tui/tui-regs.c (~tui_data_item_window): Update.
4740
1a4f81dd
TT
47412019-08-20 Tom Tromey <tom@tromey.com>
4742
4743 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4744 earlier.
4745
0f8d8876
TT
47462019-08-20 Tom Tromey <tom@tromey.com>
4747
4748 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4749
605dc2c2
TT
47502019-08-20 Tom Tromey <tom@tromey.com>
4751
4752 * tui/tui-source.h (struct tui_source_window): Update.
4753 * tui/tui-regs.c (tui_show_registers): Update.
4754 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4755 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4756 (NO_REGS_STRING): Remove defines.
4757
aedbe3bb
CM
47582019-08-20 Conrad Meyer <cem@FreeBSD.org>
4759
4760 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4761 unnecessary thread walk if remote doesn't support the packet.
4762
7ce8f214
TT
47632019-08-19 Tom Tromey <tromey@adacore.com>
4764
4765 * python/py-value.c (value_has_field): Fix indentation.
4766
f21c2bd7
TT
47672019-08-19 Tom Tromey <tromey@adacore.com>
4768
4769 * printcmd.c (do_one_display, info_display_command): Update.
4770 * block.h (contained_in): Return bool. Add allow_nested
4771 parameter.
4772 * block.c (contained_in): Return bool. Add allow_nested
4773 parameter.
4774
d806ea2d
TT
47752019-08-19 Tom Tromey <tom@tromey.com>
4776
4777 * configure: Rebuild.
4778 * configure.ac: Disallow the combination of -static-libstdc++ and
4779 source highlight.
4780 * source-cache.c (get_language_name): Handle rust.
4781 (source_cache::get_source_lines): Ignore highlighting exceptions.
4782
398fdd60
TT
47832019-08-16 Tom Tromey <tom@tromey.com>
4784
4785 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4786 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4787 (struct tui_source_window_base) <make_visible, refresh_window,
4788 resize>: Remove methods.
4789 <execution_info>: Remove field.
4790 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4791 (tui_show_source_line, tui_source_window_base)
4792 (~tui_source_window_base): Update.
4793 (tui_source_window_base::resize)
4794 (tui_source_window_base::make_visible)
4795 (tui_source_window_base::refresh_window): Remove.
4796 (tui_source_window_base::update_exec_info): Update.
4797 * tui/tui-source.c (tui_source_window::set_contents): Update.
4798 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4799
e699d331
TT
48002019-08-16 Tom Tromey <tom@tromey.com>
4801
4802 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4803 deprecated_query_hook.
4804
bb01dbfc
TT
48052019-08-16 Tom Tromey <tom@tromey.com>
4806
4807 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4808 (tui_update_source_windows_with_line): Update.
4809 * tui/tui-source.h (struct tui_source_window)
4810 <show_symtab_source>: Declare.
4811 (tui_show_symtab_source): Don't declare.
4812 * tui/tui-source.c (tui_show_symtab_source): Rename from
4813 tui_show_symtab_source.
4814
81c82c4b
TT
48152019-08-16 Tom Tromey <tom@tromey.com>
4816
4817 * tui/tui-winsource.h (struct tui_source_window_base)
4818 <set_contents>: Declare.
4819 * tui/tui-winsource.c
4820 (tui_source_window_base::update_source_window_as_is): Update.
4821 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4822 Declare.
4823 (tui_set_source_content): Don't declare.
4824 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4825 tui_set_source_content.
4826 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4827 Declare.
4828 (tui_set_disassem_content): Don't declare.
4829 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4830 tui_set_disassem_content.
4831
2ddaf614
TT
48322019-08-16 Tom Tromey <tom@tromey.com>
4833
4834 * tui/tui-winsource.h (struct tui_source_window_base)
4835 <update_breakpoint_info>: Declare.
4836 (tui_update_breakpoint_info): Don't declare.
4837 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4838 (tui_update_all_breakpoint_info): Update.
4839 (tui_source_window_base::update_breakpoint_info): Rename from
4840 tui_update_breakpoint_info.
4841 (tui_source_window_base::update_exec_info): Update.
4842
017f9828
TT
48432019-08-16 Tom Tromey <tom@tromey.com>
4844
4845 * tui/tui-winsource.h (struct tui_source_window_base)
4846 <update_source_window>: Declare.
4847 (tui_update_source_window): Don't declare.
4848 * tui/tui-winsource.c
4849 (tui_source_window_base::update_source_window): Rename from
4850 tui_update_source_window.
4851 (tui_source_window_base::rerender): Update.
4852 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4853 * tui/tui-disasm.c (tui_show_disassem)
4854 (tui_show_disassem_and_update_source)
4855 (tui_disasm_window::maybe_update): Update.
4856
ed8358e9
TT
48572019-08-16 Tom Tromey <tom@tromey.com>
4858
4859 * tui/tui-winsource.h (struct tui_source_window_base)
4860 <update_source_window_as_is>: Declare.
4861 (tui_update_source_window_as_is): Don't declare.
4862 * tui/tui-winsource.c (tui_update_source_window): Update
4863 (tui_source_window_base::update_source_window_as_is): Rename from
4864 tui_update_source_window_as_is.
4865 (tui_source_window_base::refill): Update.
4866 * tui/tui-source.c (tui_show_symtab_source): Update.
4867 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4868 Update.
4869
20149b6b
TT
48702019-08-16 Tom Tromey <tom@tromey.com>
4871
4872 * tui/tui-winsource.h (tui_update_source_window)
4873 (tui_update_source_window_as_is): Remove "noerror" parameter.
4874 * tui/tui-winsource.c (tui_update_source_window)
4875 (tui_update_source_window_as_is): Remove "noerror" parameter.
4876 (tui_update_source_windows_with_addr)
4877 (tui_update_source_windows_with_line)
4878 (tui_source_window_base::rerender)
4879 (tui_source_window_base::refill): Update.
4880 * tui/tui-source.h (tui_set_source_content)
4881 (tui_show_symtab_source): Remove "noerror" parameter.
4882 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4883 parameter.
4884 (tui_show_symtab_source): Likewise.
4885 (tui_source_window::maybe_update): Update.
4886 * tui/tui-disasm.c (tui_show_disassem)
4887 (tui_show_disassem_and_update_source)
4888 (tui_disasm_window::do_scroll_vertical)
4889 (tui_disasm_window::maybe_update): Update.
4890
2d83e710
TT
48912019-08-16 Tom Tromey <tom@tromey.com>
4892
4893 * tui/tui.c (tui_is_window_visible): Update.
4894 * tui/tui-wingeneral.c (tui_make_window)
4895 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4896 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4897 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4898 (tui_set_win_height_command, parse_scrolling_args): Update.
4899 * tui/tui-source.c (tui_source_window::style_changed): Update.
4900 * tui/tui-regs.c (tui_show_registers)
4901 (tui_data_window::first_data_item_displayed)
4902 (tui_data_window::delete_data_content_windows)
4903 (tui_check_register_values, tui_reg_command): Update.
4904 * tui/tui-disasm.c (tui_show_disassem): Update.
4905 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4906 method.
4907 <is_visible>: Remove field.
4908 * tui/tui-data.c (tui_next_win, tui_prev_win)
4909 (tui_delete_invisible_windows): Update.
4910
d4ab829a
TT
49112019-08-16 Tom Tromey <tom@tromey.com>
4912
4913 * tui/tui-winsource.h (struct tui_source_window_base)
4914 <m_has_locator>: Remove.
4915 * tui/tui-layout.c (show_source_disasm_command, show_data)
4916 (show_source_or_disasm_and_command): Update.
4917
aa7ca1bb
AH
49182019-08-16 Alan Hayward <alan.hayward@arm.com>
4919
4920 * NEWS (Other MI changes): New subsection.
4921 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4922 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4923 * arch-utils.c (default_get_pc_address_flags): New function.
4924 * arch-utils.h (default_get_pc_address_flags): New declaration.
4925 * gdbarch.sh: Add get_pc_address_flags.
4926 * gdbarch.c: Regenerate.
4927 * gdbarch.h: Likewise.
4928 * stack.c (print_pc): New function.
4929 (print_frame_info) (print_frame): Call print_pc.
4930
6eac171f
TV
49312019-08-16 Tom de Vries <tdevries@suse.de>
4932
4933 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4934 print_objfile_section_info.
4935
3df505f6
TT
49362019-08-15 Tom Tromey <tom@tromey.com>
4937
4938 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4939 calling update_cmdwin_start_line.
4940 * tui/tui-winsource.h (struct tui_source_window_base)
4941 <do_make_visible_with_new_height, set_new_height>: Don't declare.
4942 <rerender>: Declare.
4943 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4944 Call rerender.
4945 (tui_source_window_base::set_new_height): Remove.
4946 (tui_source_window_base::rerender): Rename from
4947 do_make_visible_with_new_height.
4948 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4949 resize method.
4950 (tui_win_info::make_invisible_and_set_new_height)
4951 (tui_win_info::make_visible_with_new_height): Remove.
4952 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4953 Declare.
4954 * tui/tui-stack.c (tui_locator_window::rerender): New method.
4955 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4956 do_make_visible_with_new_height>: Don't declare.
4957 <rerender>: Declare.
4958 * tui/tui-regs.c (tui_data_window::rerender): Rename from
4959 set_new_height.
4960 (tui_data_window::do_make_visible_with_new_height): Remove.
4961 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4962 call tui_show_locator_content.
4963 (tui_gen_win_info::resize): Call rerender.
4964 (show_source_or_disasm_and_command): Don't call
4965 tui_show_locator_content.
4966 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4967 method.
4968 (struct tui_win_info) <rerender>: Declare.
4969 <set_new_height, make_invisible_and_set_new_height,
4970 make_visible_with_new_height>: Don't declare.
4971 * tui/tui-data.c (tui_win_list::rerender): New method.
4972 * tui/tui-command.h (struct tui_cmd_window)
4973 <do_make_visible_with_new_height>: Don't declare.
4974 * tui/tui-command.c
4975 (tui_cmd_window::do_make_visible_with_new_height): Remove.
4976
272560b5
TT
49772019-08-15 Tom Tromey <tromey@adacore.com>
4978
4979 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4980 * ada-lang.c (ada_enum_name): Likewise.
4981
08235187
CB
49822019-08-15 Christian Biesinger <cbiesinger@google.com>
4983
4984 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4985 leading underscore.
4986 (GdbOutputErrorFile): Likewise.
4987 (global scope): Adjust constructor calls to GdbOutput{,Error}File
4988 accordingly.
4989 (execute_unwinders): Rename to have a leading underscore.
4990 (auto_load_packages): Likewise.
4991 (global scope): Adjust call to auto_load_packages accordingly.
4992 (GdbSetPythonDirectory): Likewise.
4993 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4994 instead of execute_unwinders.
4995
db502012
TT
49962019-08-15 Tom Tromey <tom@tromey.com>
4997
4998 * tui/tui-layout.c (show_layout, show_source_disasm_command)
4999 (show_data): Don't change window visibility.
5000 (tui_gen_win_info::resize): Remove special case for command
5001 window. Use wresize, when available.
5002 (show_source_or_disasm_and_command): Don't change window
5003 visibility.
5004 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5005 <make_visible>: New method.
5006 * tui/tui-command.c (tui_cmd_window::resize): New method.
5007
3891b65e
TT
50082019-08-15 Tom Tromey <tom@tromey.com>
5009
5010 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5011 (struct tui_source_windows): New.
5012 * tui/tui-winsource.c (tui_display_main): Update.
5013 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5014 (new_height_ok, parse_scrolling_args): Update.
5015 * tui/tui-layout.c (show_layout, show_data): Update.
5016 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5017 (tui_add_to_source_windows): Don't declare.
5018 * tui/tui-data.c (source_windows, tui_source_windows)
5019 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5020
ee556432
TT
50212019-08-15 Tom Tromey <tom@tromey.com>
5022
5023 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5024 Rename from reset.
5025 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5026 * tui/tui-layout.c (show_source_disasm_command, show_data):
5027 Update.
5028 (tui_gen_win_info::resize): Rename.
5029 (show_source_or_disasm_and_command): Update.
5030 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5031 reset.
5032
46f438e3
TT
50332019-08-15 Tom Tromey <tom@tromey.com>
5034
5035 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5036 * tui/tui-interp.c (tui_interp::init): Don't call
5037 tui_initialize_static_data.
5038 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5039
f4ce562c
TT
50402019-08-15 Tom Tromey <tom@tromey.com>
5041
5042 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5043 examine tui_win_list.
5044
c398c3d0
TT
50452019-08-15 Tom Tromey <tom@tromey.com>
5046
5047 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5048 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5049 tui_clear_source_content.
5050 (tui_clear_source_content): Remove.
5051 (tui_source_window_base::do_erase_source_content): Hoist call to
5052 content.clear().
5053 * tui/tui-stack.c (tui_show_frame_info): Don't call
5054 tui_clear_source_content.
5055
e25d2004
TT
50562019-08-15 Tom Tromey <tom@tromey.com>
5057
5058 * tui/tui-winsource.h (struct tui_source_window_base)
5059 <do_erase_source_content>: New method.
5060 <erase_source_content>: New method.
5061 (tui_erase_source_content): Don't declare.
5062 * tui/tui-winsource.c (tui_clear_source_content): Update.
5063 (tui_source_window_base::do_erase_source_content): Rename from
5064 tui_erase_source_content.
5065 (tui_source_window_base::show_source_content): Update.
5066 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5067 * tui/tui-source.h (struct tui_source_window)
5068 <erase_source_content>: New method.
5069 * tui/tui-disasm.h (struct tui_disasm_window)
5070 <erase_source_content>: New method.
5071
002f15c2
TT
50722019-08-15 Tom Tromey <tom@tromey.com>
5073
5074 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5075 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5076 constructor.
5077 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5078 * tui/tui-source.c (tui_set_source_content): Update.
5079 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5080
c9033fe8
TT
50812019-08-15 Tom Tromey <tom@tromey.com>
5082
5083 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5084 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5085 tui-source.c.
5086 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5087 Declare.
5088 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5089 method.
5090 (tui_source_window::maybe_update): Update.
5091
088f37dd
TT
50922019-08-15 Tom Tromey <tom@tromey.com>
5093
5094 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5095 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5096 tui-disasm.c.
5097 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5098 Declare.
5099 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5100 method.
5101 (tui_disasm_window::maybe_update): Update.
5102
a54700c6
TT
51032019-08-15 Tom Tromey <tom@tromey.com>
5104
5105 * tui/tui-winsource.h (struct tui_source_window_base)
5106 <maybe_update>: Declare.
5107 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5108 method.
5109 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5110 Declare.
5111 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5112 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5113 Declare.
5114 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5115
e2a678a5
TT
51162019-08-15 Tom Tromey <tom@tromey.com>
5117
5118 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5119
f2dda477
TT
51202019-08-15 Tom Tromey <tom@tromey.com>
5121
5122 * tui/tui-wingeneral.c: Include tui-stack.h.
5123 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5124 (struct tui_locator_window): Move from tui-data.h.
5125 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5126 (tui_initialize_static_data): Move from tui-data.c.
5127 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5128 (struct tui_locator_window): Move to tui-stack.c.
5129 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5130 (tui_initialize_static_data): Move to tui-stack.c.
5131
ed4a1084
TT
51322019-08-15 Tom Tromey <tom@tromey.com>
5133
5134 * tui/tui-layout.c (show_source_disasm_command)
5135 (show_source_or_disasm_and_command): Use make_visible method, not
5136 tui_make_window.
5137 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5138 Remove.
5139
65962b20
TT
51402019-08-15 Tom Tromey <tom@tromey.com>
5141
5142 * tui/tui-wingeneral.h (tui_make_window): Update.
5143 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5144 parameter.
5145 (tui_gen_win_info::make_visible): Update.
5146 * tui/tui-regs.c (tui_data_window::display_registers_from):
5147 Update.
5148 * tui/tui-layout.c (show_source_disasm_command)
5149 (show_source_or_disasm_and_command): Update.
5150 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5151 (enum tui_box): Remove.
5152 (struct tui_win_info) <can_box>: New method.
5153 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5154 method.
5155
2208ee91
TV
51562019-08-15 Tom de Vries <tdevries@suse.de>
5157
5158 * linux-nat-trad.c: Include gdbarch.h.
5159
75faf5c4
AH
51602019-08-14 Alan Hayward <alan.hayward@arm.com>
5161
5162 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5163 register sizes.
5164
b1c896b3
TT
51652019-08-14 Tom Tromey <tromey@adacore.com>
5166
5167 * darwin-nat.c: Include gdbarch.h.
5168 * darwin-nat-info.c: Include gdbarch.h.
5169
6405cd73
TT
51702019-08-13 Tom Tromey <tom@tromey.com>
5171
5172 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5173 Remove.
5174 * tui/tui-data.c (tui_initialize_static_data): Update.
5175
5216580d
TT
51762019-08-13 Tom Tromey <tom@tromey.com>
5177
5178 * tui/tui-winsource.h (struct tui_exec_info_window)
5179 <~tui_exec_info_window, maybe_allocate_content, get_content,
5180 m_content>: Remove.
5181 (struct tui_source_window_base) <set_exec_info_content,
5182 show_exec_info_content>: Don't declare.
5183 * tui/tui-winsource.c
5184 (tui_exec_info_window::maybe_allocate_content): Remove.
5185 (tui_source_window_base::update_exec_info): Rename from
5186 set_exec_info_content.
5187 (tui_source_window_base::show_exec_info_content)
5188 (tui_source_window_base::update_exec_info): Remove.
5189
93858ad3
TT
51902019-08-13 Tom Tromey <tom@tromey.com>
5191
5192 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5193 declare.
5194 * tui/tui-winsource.c (tui_update_source_window_as_is)
5195 (tui_update_source_windows_with_addr, tui_erase_source_content):
5196 Update.
5197 (tui_clear_exec_info_content): Remove.
5198
e321e7ce
TT
51992019-08-13 Tom Tromey <tom@tromey.com>
5200
5201 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5202 declare.
5203 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5204 call tui_erase_exec_info_content.
5205 (tui_clear_exec_info_content): Rename from
5206 tui_erase_exec_info_content.
5207 (tui_clear_exec_info_content): Delete.
5208
8270ac62
TT
52092019-08-13 Tom Tromey <tom@tromey.com>
5210
5211 * tui/tui-winsource.h (struct tui_source_window_base)
5212 <show_exec_info_content>: Declare.
5213 (tui_show_exec_info_content): Don't declare.
5214 * tui/tui-winsource.c
5215 (tui_source_window_base::show_exec_info_content): Rename from
5216 tui_show_exec_info_content.
5217 (tui_source_window_base::update_exec_info): Update.
5218
7b56485d
TT
52192019-08-13 Tom Tromey <tom@tromey.com>
5220
5221 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5222 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5223 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5224 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5225 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5226 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5227 ... here.
5228
7ba913dc
TT
52292019-08-13 Tom Tromey <tom@tromey.com>
5230
5231 * tui/tui-winsource.h (struct tui_source_window_base)
5232 <update_exec_info>: Declare.
5233 (tui_update_exec_info): Don't declare.
5234 * tui/tui-winsource.c (tui_update_source_window_as_is)
5235 (tui_source_window_base::refresh_all)
5236 (tui_update_all_breakpoint_info): Update.
5237 (tui_source_window_base::update_exec_info): Rename from
5238 tui_update_exec_info.
5239 * tui/tui-stack.c (tui_show_frame_info): Update.
5240
37a4a131
TT
52412019-08-13 Tom Tromey <tom@tromey.com>
5242
5243 * tui/tui-winsource.h (struct tui_source_window_base)
5244 <set_exec_info_content>: Declare.
5245 (tui_set_exec_info_content): Don't declare.
5246 * tui/tui-winsource.c
5247 (tui_source_window_base::set_exec_info_content): Rename from
5248 tui_set_exec_info_content.
5249 (tui_update_exec_info): Update.
5250
0bd27e07
TT
52512019-08-13 Tom Tromey <tom@tromey.com>
5252
5253 * tui/tui-winsource.h (struct tui_source_window_base)
5254 <show_source_content>: Declare.
5255 (tui_show_source_content): Don't declare.
5256 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5257 (tui_source_window_base::show_source_content): Rename from
5258 tui_show_source_content.
5259 (tui_source_window_base::refresh_all): Update.
5260 * tui/tui-layout.c (show_source_disasm_command)
5261 (show_source_or_disasm_and_command): Update.
5262
b4ef5aeb
TT
52632019-08-13 Tom Tromey <tom@tromey.com>
5264
5265 * tui/tui-winsource.c (tui_erase_source_content)
5266 (tui_show_source_content, tui_source_window_base::refresh_all):
5267 Update.
5268 * tui/tui-wingeneral.h
5269 (tui_check_and_display_highlight_if_needed): Don't declare.
5270 * tui/tui-wingeneral.c
5271 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5272 check_and_display_highlight_if_needed.
5273 * tui/tui-win.c (tui_rehighlight_all)
5274 (tui_win_info::make_visible_with_new_height): Update.
5275 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5276 (tui_data_window::erase_data_content)
5277 (tui_data_window::display_all_data): Update.
5278 * tui/tui-data.h (struct tui_win_info)
5279 <check_and_display_highlight_if_needed>: Declare.
5280
fede5273
TT
52812019-08-13 Tom Tromey <tom@tromey.com>
5282
5283 * tui/tui-win.c (tui_resize_all): Call
5284 tui_delete_invisible_windows.
5285 * tui/tui-layout.c (show_layout): Call
5286 tui_delete_invisible_windows.
5287 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5288 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5289
22c3f490
TT
52902019-08-13 Tom Tromey <tom@tromey.com>
5291
5292 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5293 tui_add_win_to_layout.
5294
16cb7910
TT
52952019-08-13 Tom Tromey <tom@tromey.com>
5296
5297 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5298 * tui/tui-layout.c (tui_default_win_height): Now static.
5299
cc0c3ffb
TT
53002019-08-13 Tom Tromey <tom@tromey.com>
5301
5302 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5303 single switch.
5304 (show_source_disasm_command, show_source_or_disasm_and_command):
5305 Don't check current layout.
5306
3f3ffe54
TT
53072019-08-13 Tom Tromey <tom@tromey.com>
5308
5309 * tui/tui-wingeneral.c (make_all_visible): Remove.
5310 (tui_make_all_invisible): Simplify.
5311 * tui/tui-layout.c (tui_make_all_invisible): Move from
5312 tui-wingeneral.c; simplify.
5313 (show_layout): Hoist call to tui_make_all_invisible.
5314 (show_data): Don't call tui_make_all_invisible.
5315
69258091
TT
53162019-08-13 Tom Tromey <tom@tromey.com>
5317
5318 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5319 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5320
62cf57fe
TT
53212019-08-13 Tom Tromey <tom@tromey.com>
5322
5323 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5324 tui-data.c.
5325 (show_source_disasm_command, show_data)
5326 (show_source_or_disasm_and_command): Don't use
5327 tui_set_current_layout_to.
5328 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5329 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5330 tui-layout.c.
5331 (tui_set_current_layout_to): Remove.
5332
2afade5d
TT
53332019-08-13 Tom Tromey <tom@tromey.com>
5334
5335 * tui/tui-layout.c (tui_set_layout): Update.
5336 * tui/tui-data.h (struct tui_layout_def): Remove.
5337 (tui_layout_def): Don't declare.
5338 * tui/tui-data.c (layout_def): Remove.
5339 (tui_layout_def): Remove.
5340
a3504e96
TT
53412019-08-13 Tom Tromey <tom@tromey.com>
5342
5343 * tui/tui-winsource.h (struct tui_source_window_base)
5344 <clear_detail>: No longer "override".
5345 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5346 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5347 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5348 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5349 Remove.
5350 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5351
29c92911
TT
53522019-08-13 Tom Tromey <tromey@adacore.com>
5353
5354 * tracepoint.c: Don't include readline.h or history.h.
5355
86c6b807
TT
53562019-08-12 Tom Tromey <tom@tromey.com>
5357
5358 * configure: Rebuild.
5359 * configure.ac: Check for readline 7.
5360 * NEWS: Mention readline 7 requirement.
5361 * README: Update.
5362
5db2718c
TT
53632019-08-12 Tom Tromey <tom@tromey.com>
5364
5365 * mingw-hdep.c (gdb_select): Remove readline hack.
5366
dac36daf
PFC
53672019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5368
5369 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5370 when the function fails.
5371
1022c627
AA
53722019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5373
5374 * s390-tdep.c (s390_type_align): New function.
5375 (s390_gdbarch_init): Set it as type_align gdbarch method.
5376
eba4caf2
TV
53772019-08-09 Tom de Vries <tdevries@suse.de>
5378
5379 PR gdb/24591
5380 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5381 pc_low with relocation offset.
5382
123cd851
TT
53832019-08-07 Tom Tromey <tromey@adacore.com>
5384
5385 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5386 (print_frame_args): Update.
5387 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5388 Update.
5389 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5390 * frame.h (struct frame_arg): Add initializers.
5391 <error>: Now a unique_xmalloc_ptr.
5392
3d31bc39
AH
53932019-08-07 Alan Hayward <alan.hayward@arm.com>
5394
5395 * NEWS: Expand the Pointer Authentication entry.
5396 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5397 (aarch64_frame_unmask_lr): ... to this.
5398 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5399 Call aarch64_frame_unmask_lr.
5400 * frame.c (struct frame_info): Add "masked" variable.
5401 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5402 (fprint_frame): Check for masked pc.
5403 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5404 declarations.
5405 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5406 * stack.c (print_frame): Check for masked pc.
5407
0cf9feb9
TT
54082019-08-06 Tom Tromey <tom@tromey.com>
5409
5410 * stabsread.c (patch_block_stabs, read_one_struct_field)
5411 (read_enum_type): Use obstack_strndup.
5412 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5413 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5414 * dwarf2read.c (guess_full_die_structure_name)
5415 (anonymous_struct_prefix): Use obstack_strndup.
5416 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5417 * c-exp.y (yylex): Use obstack_strndup.
5418 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5419 (write_var_or_type): Use obstack_strndup.
5420
efba19b0
TT
54212019-08-06 Tom Tromey <tom@tromey.com>
5422
5423 * symfile.c (reread_symbols): Use obstack_strdup.
5424 * stabsread.c (read_type): Use obstack_strdup.
5425 * gdb_obstack.h (obstack_strdup): New overload.
5426 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5427 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5428 (dwarf2_canonicalize_name): Use obstack_strdup.
5429 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5430 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5431 Use obstack_strdup.
5432
f25102f7
TT
54332019-08-06 Tom Tromey <tom@tromey.com>
5434
5435 * gdb_obstack.h (obstack_strdup): Define.
5436 * gdb_obstack.c (obstack_strdup): Don't define.
5437
021887d8
TT
54382019-08-06 Tom Tromey <tom@tromey.com>
5439
5440 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5441 obstack_strdup.
5442 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5443 obstack_strdup.
5444 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5445 * stabsread.c (common_block_start): Use obstack_strdup.
5446 * objfiles.c (set_objfile_main_name, objfile): Use
5447 obstack_strdup.
5448 * namespace.c (add_using_directive): Use obstack_strdup.
5449 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5450 * jit.c (finalize_symtab): Use obstack_strdup.
5451 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5452 (guess_partial_die_structure_name, partial_die_info::fixup)
5453 (dwarf2_name): Use obstack_strdup.
5454 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5455 obstack_strdup.
5456 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5457 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5458 obstack_strdup.
5459 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5460
d2834edc
PW
54612019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5462
5463 * unittests/help-doc-selftests.c: New file.
5464 * Makefile.in: Add the new file.
5465
590042fc
PW
54662019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5467
5468 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5469 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5470 the full first line, except when FOR_VALUE_PREFIX. In this case,
5471 the trailing '.' is not output, and the first character is uppercased.
5472 (print_help_for_command): Update call to print_doc_line.
5473 (print_doc_of_command): Likewise.
5474 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5475 * cli/cli-option.c (append_indented_doc): Do not append newline.
5476 (build_help_option): Append newline after first appended_indented_doc
5477 only if a second call is done.
5478 (build_help): Append 2 new lines before each option, except the first
5479 one.
5480 * compile/compile.c (_initialize_compile): Add new lines after
5481 %OPTIONS%, when not at the end of the help.
5482 Change help doc or code
5483 producing the help doc to respect the invariants.
5484 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5485 Also removed the new line after 'Options:', as all other commands
5486 do not put an empty line between 'Options:' and the first option.
5487 * printcmd.c (_initialize_printcmd): Likewise.
5488 * stack.c (_initialize_stack): Likewise.
5489 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5490 incorrectly telling COMMAND is optional.
5491 * ada-lang.c (_initialize_ada_language): Change help doc or code
5492 producing the help doc to respect the invariants.
5493 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5494 * breakpoint.c (_initialize_breakpoint): Likewise.
5495 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5496 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5497 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5498 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5499 _initialize_cli_style): Likewise.
5500 * corelow.c (core_target_info): Likewise.
5501 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5502 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5503 * filesystem.c (_initialize_filesystem): Likewise.
5504 * frame.c (_initialize_frame): Likewise.
5505 * gnu-nat.c (add_task_commands): Likewise.
5506 * infcall.c (_initialize_infcall): Likewise.
5507 * infcmd.c (_initialize_infcmd): Likewise.
5508 * interps.c (_initialize_interpreter): Likewise.
5509 * language.c (_initialize_language): Likewise.
5510 * linux-fork.c (_initialize_linux_fork): Likewise.
5511 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5512 * maint.c (_initialize_maint_cmds): Likewise.
5513 * memattr.c (_initialize_mem): Likewise.
5514 * printcmd.c (_initialize_printcmd): Likewise.
5515 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5516 _RegEx): Likewise.
5517 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5518 * record-btrace.c (_initialize_record_btrace): Likewise.
5519 * record-full.c (_initialize_record_full): Likewise.
5520 * record.c (_initialize_record): Likewise.
5521 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5522 * regcache.c (_initialize_regcache): Likewise.
5523 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5524 _initialize_remote): Likewise.
5525 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5526 * serial.c (_initialize_serial): Likewise.
5527 * skip.c (_initialize_step_skip): Likewise.
5528 * source.c (_initialize_source): Likewise.
5529 * stack.c (_initialize_stack): Likewise.
5530 * symfile.c (_initialize_symfile): Likewise.
5531 * symtab.c (_initialize_symtab): Likewise.
5532 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5533 * top.c (init_main): Likewise.
5534 * tracefile-tfile.c (tfile_target_info): Likewise.
5535 * tracepoint.c (_initialize_tracepoint): Likewise.
5536 * tui/tui-win.c (_initialize_tui_win): Likewise.
5537 * utils.c (add_internal_problem_command): Likewise.
5538 * valprint.c (value_print_option_defs): Likewise.
5539
404f2902
FCE
55402019-08-06 Frank Ch. Eigler <fche@redhat.com>
5541
5542 PR build/24886
5543 * configure.ac: Drop enable-libmcheck support.
5544 * configure, config.in: Rebuild.
5545 * libmcheck.m4: Remove.
5546 * acinclude.m4: Don't include it.
5547 * Makefile.in: Don't distribute it.
5548 * top.c (print_gdb_configuration): Don't mention it.
5549
046bebe1
TT
55502019-08-06 Tom Tromey <tom@tromey.com>
5551
5552 * utils.c (set_output_style): Sometimes pass stream to
5553 emit_style_escape.
5554 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5555 * record-btrace.c (btrace_insn_history): Update.
5556 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5557 method.
5558 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5559 Update initializers.
5560 <m_uiout>: New field.
5561 <m_di>: Move lower.
5562 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5563 Remove "uiout" parameter.
5564 (dump_insns): Update.
5565 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5566 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5567
ddbcedf5
CB
55682019-08-06 Christian Biesinger <cbiesinger@google.com>
5569
5570 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5571 (error_in_psymtab_expansion): Likewise.
5572 (lookup_symbol_via_quick_fns): Likewise.
5573 (basic_lookup_transparent_type_quick): Likewise.
5574 (basic_lookup_transparent_type_1): Likewise.
5575
b08b16c8
TT
55762019-08-06 Tom Tromey <tromey@adacore.com>
5577
5578 * source.c (last_source_error): Now bool.
5579 (print_source_lines_base): Make "noprint" bool. Only open
5580 source file when last_source_visited changes.
5581
cb44333d
TT
55822019-08-06 Tom Tromey <tromey@adacore.com>
5583
5584 * annotate.c (annotate_source_line): Use g_source_cache.
5585 * source-cache.c (source_cache::get_plain_source_lines): Change
5586 parameters. Populate m_offset_cache.
5587 (source_cache::ensure): New method.
5588 (source_cache::get_line_charpos): New method.
5589 (extract_lines): Move lower. Change parameters.
5590 (source_cache::get_source_lines): Move lower.
5591 * source-cache.h (class source_cache): Update comment.
5592 <get_line_charpos>: New method.
5593 <get_source_lines>: Update comment.
5594 <clear>: Clear m_offset_cache.
5595 <get_plain_source_lines>: Change parameters.
5596 <ensure>: New method
5597 <m_offset_cache>: New member.
5598 * source.c (forget_cached_source_info_for_objfile): Update.
5599 (info_source_command): Use g_source_cache.
5600 (find_source_lines, open_source_file_with_line_charpos): Remove.
5601 (print_source_lines_base, search_command_helper): Use g_source_cache.
5602 * source.h (open_source_file_with_line_charpos): Don't declare.
5603 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5604 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5605 Use g_source_cache.
5606
872dceaa
TT
56072019-08-06 Tom Tromey <tromey@adacore.com>
5608
5609 * source-cache.c (source_cache::get_plain_source_lines):
5610 Remove "first_line" and "last_line" parameters.
5611 (source_cache::get_source_lines): Cache plain text.
5612 * source-cache.h (class source_cache)
5613 <get_plain_source_lines>: Update.
5614
269249d9
TT
56152019-08-06 Tom Tromey <tromey@adacore.com>
5616
5617 * source-cache.c (extract_lines): No longer a method.
5618 Changed type of parameter. Include final newline.
5619 (selftests::extract_lines_test): New function.
5620 (_initialize_source_cache): Likewise.
5621 * source-cache.h (class source_cache)
5622 <extract_lines>: Don't declare.
5623
c0e8dcd8
TT
56242019-08-06 Tom Tromey <tromey@adacore.com>
5625
5626 * breakpoint.c (init_breakpoint_sal): Update.
5627 (breakpoint): Update.
5628 * breakpoint.h (struct breakpoint) <filter>: Now a
5629 unique_xmalloc_ptr.
5630
0b27c27d
CB
56312019-08-05 Christian Biesinger <cbiesinger@google.com>
5632
5633 * NEWS: Mention dictionary access on blocks.
5634 * python/py-block.c (blpy_getitem): New function.
5635 (block_object_as_mapping): New struct.
5636 (block_object_type): Use new struct for tp_as_mapping field.
5637
4ee94178
CB
56382019-08-05 Christian Biesinger <cbiesinger@google.com>
5639
5640 * objfiles.h (objfile): Add a comment describing partial symbols.
5641
8abfcabc
TT
56422019-08-05 Tom Tromey <tromey@adacore.com>
5643
5644 * compile/compile.c (_initialize_compile): Use _(), not N_().
5645 * thread.c (_initialize_thread): Use _(), not N_().
5646 * stack.c (_initialize_stack): Use _(), not N_().
5647 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5648
2b79f376
SM
56492019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5650
5651 * dwarf2read.c (struct dw2_symtab_iterator):
5652 <want_specific_block>: Remove.
5653 <block_index>: Change type to gdb::optional.
5654 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5655 change type of BLOCK_INDEX parameter to gdb::optional.
5656 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5657 (dw2_lookup_symbol): Don't pass argument for
5658 WANT_SPECIFIC_BLOCK.
5659 (dw2_expand_symtabs_for_function): Don't pass argument for
5660 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5661 (class dw2_debug_names_iterator)
5662 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5663 parameter, change BLOCK_INDEX type to gdb::optional.
5664 <m_want_specific_block>: Remove.
5665 <m_block_index>: Change type to gdb::optional.
5666 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5667 gdb::optional. Re-write in function of gdb::optional.
5668 (dw2_debug_names_lookup_symbol): Don't pass argument for
5669 WANT_SPECIFIC_BLOCK.
5670 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5671 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5672 BLOCK_INDEX.
5673
ae60f04e
PW
56742019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5675
5676 * NEWS: Mention changes to "info sources" command.
5677
28cd9371
PW
56782019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5679
5680 * symtab.c (filename_partial_match_opts): New struct type.
5681 (struct output_source_filename_data): New members
5682 regexp, c_regexp, partial_match.
5683 (output_source_filename): Use new members to decide to print file.
5684 (info_sources_option_defs): New variable.
5685 (make_info_sources_options_def_group, print_info_sources_header,
5686 info_sources_command_completer):
5687 New functions.
5688 (info_sources_command): Read new optional arguments.
5689 (_initialize_symtab): Update info sources help.
5690
ca683e3a
AO
56912019-08-02 Alexandre Oliva <oliva@adacore.com>
5692
5693 * ada-lang.c (exception_support_info_v0): Renamed from...
5694 (default_exception_support_info): ... this. Create new
5695 definition for v1.
5696 (ada_has_this_exception_support): Look up catch_handlers_sym.
5697 (ada_exception_support_info_sniffer): Try v0 after default.
5698
f1264162
TT
56992019-08-01 Tom Tromey <tromey@adacore.com>
5700
5701 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5702 gdbarch.h.
5703
0a7b2485
CB
57042019-08-01 Christian Biesinger <cbiesinger@google.com>
5705
5706 * s12z-tdep.c: Fix include path for s12z-opc.h.
5707
c6bdbeb7
AH
57082019-08-01 Alan Hayward <alan.hayward@arm.com>
5709
5710 * NEWS: Require GNU make 3.82.
5711
a2bd7b82
TT
57122019-07-16 Tom Tromey <tom@tromey.com>
5713
5714 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5715 declare.
5716
aa3b6533
TT
57172019-07-30 Tom Tromey <tromey@adacore.com>
5718
5719 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5720
a1530dc7
KB
57212019-07-30 Kevin Buettner <kevinb@redhat.com>
5722
5723 * printcmd.c (print_address_symbolic): Print negative offsets.
5724 (build_address_symbolic): Force signed arithmetic when computing
5725 offset.
5726
2906593f
CB
57272019-07-30 Christian Biesinger <cbiesinger@google.com>
5728
5729 PR/24474: Add a function to lookup static variables.
5730 * NEWS: Mention this new function.
5731 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5732 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5733 * python/python.c (python_GdbMethods): Add new function.
5734
c620ed88
CB
57352019-07-29 Christian Biesinger <cbiesinger@google.com>
5736
5737 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5738 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5739 (objfpy_lookup_static_symbol): New function.
5740 (objfile_object_methods): Add new functions.
5741
bc4268a5
PW
57422019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5743
5744 * NEWS: Mention 'set|show print frame-info'. Mention new
5745 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5746 backtrace argument. Mention that python frame filtering code
5747 is now consistent with what 'backtrace' command prints.
5748
4b5e8d19
PW
57492019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5750
5751 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5752 comments.
5753 (print_frame_info_auto, print_frame_info_source_line,
5754 print_frame_info_location, print_frame_info_source_and_location,
5755 print_frame_info_location_and_address, print_frame_info_short_location):
5756 New declarations.
5757 (struct frame_print_options): New member print_frame_info.
5758 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5759 * stack.h (get_user_print_what_frame_info): New declaration.
5760 (frame_show_address): New declaration.
5761 * stack.c (print_frame_arguments_choices): New value 'presence'.
5762 (print_frame_info_auto, print_frame_info_source_line,
5763 print_frame_info_location, print_frame_info_source_and_location,
5764 print_frame_info_location_and_address, print_frame_info_short_location,
5765 print_frame_info_choices, print_frame_info_print_what): New definitions.
5766 (print_frame_args): Only print dots for args if print frame-arguments
5767 is 'presence'.
5768 (frame_print_option_defs): New element for "frame-info".
5769 (get_user_print_what_frame_info): New function.
5770 (frame_show_address): Make non static. Move comment to stack.h.
5771 (print_frame_info_to_print_what): New function.
5772 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5773 to decide what to print.
5774 (backtrace_command_1): Handle the new print_frame_arguments_presence
5775 value.
5776 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5777 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5778 (py_print_frame): In non-mi mode, use LOCATION as default for
5779 print_what, similarly to frame information printed directly by
5780 backtrace command. Handle frame-info user option in non MI mode.
5781
6bdfee81
KB
57822019-07-27 Kevin Buettner <kevinb@redhat.com>
5783
5784 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5785 Add case for debugging 32-bit target on 64-bit host. Revise
5786 comment.
5787
98a617f8
KB
57882019-07-27 Kevin Buettner <kevinb@redhat.com>
5789
5790 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5791 instead of find_function_entry_range_from_pc.
5792
567238c9
KB
57932019-07-27 Kevin Buettner <kevinb@redhat.com>
5794
5795 * stack.c (find_frame_funname): Remove code which preferred
5796 minsym over symtab sym in "certain pathological cases".
5797
2dc80cf8
KB
5798 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5799 parameter. Change type of "do_demangle" to bool.
5800 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5801 Pass suitable "prefer_sym_over_minsym" flag to
5802 build_address_symbolic(). Don't output "+" for negative offsets.
5803 * printcmd.c (print_address_symbolic): Update invocation of
5804 build_address_symbolic to include a "prefer_sym_over_minsym"
5805 flag.
5806 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5807 Restrict cases in which use of minimal symbol is preferred to that
5808 of a found symbol. Update comments.
5809
1aff7173
KB
5810 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5811 for entry pc when entry pc is out of range for that FDE.
5812
89b085ac
BC
58132019-07-26 Brian Callahan <bcallah@openbsd.org>
5814
5815 PR gdb/24839:
5816 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5817 type.
5818
f32feb4a
CB
58192019-07-25 Christian Biesinger <cbiesinger@google.com>
5820
5821 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5822 this function's Python signature.
5823
5824
58252019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
5826
5827 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5828 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5829 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5830 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5831 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5832
5833
c54e4253
YS
58342019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5835
5836 * h8300-tdep.c (h8300_register_name_common): New.
5837 h8300_register_name): Use h8300_register_name_common.
5838 (h8300s_register_name): Likewise.
5839 (h8300sx_register_name): Likewise.
5840 (h8300h_register_nam): New.
5841 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5842
5843
40eadf04
SP
58442019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5845
5846 * arm-tdep.c (arm_skip_cmse_entry): New function.
5847 (arm_is_sgstubs_section): New function.
5848 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5849
bfa2a36d
TT
58502019-07-22 Tom Tromey <tom@tromey.com>
5851
5852 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5853 Don't self-assign.
5854
a8e9d247
AB
58552019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5856
5857 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5858 type_print.
5859
eb86c5e2
AB
58602019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5861
5862 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5863 so that GDB doesn't match any msymbols when searching in the
5864 TYPES_DOMAIN.
5865 (print_symbol_info): Print using typedef_print or type_print based
5866 on the type of the symbol. Add updated FIXME comment moved from...
5867 (_initialize_symtab): ... move and update FIXME comment to above.
5868
a8eab7c6
AB
58692019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5870
5871 * NEWS: Mention adding -q option to "info types".
5872 * symtab.c (struct info_types_options): New struct.
5873 (info_types_options_defs): New variable.
5874 (make_info_types_options_def_group): New function.
5875 (info_types_command): Use gdb::option framework to parse options.
5876 (info_types_command_completer): New function.
5877 (_initialize_symtab): Extend the help text on "info types" and
5878 register command completer.
5879
b4603c34
CB
58802019-07-21 Christian Biesinger <cbiesinger@google.com>
5881
5882 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5883 (lookup_symbol_in_objfile): Change int to block_enum and add a
5884 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5885
c8cdc1e0
CB
58862019-07-20 Christian Biesinger <cbiesinger@google.com>
5887
5888 * MAINTAINERS (Write After Approval): Add self.
5889
01e175fe
AB
58902019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
5891
5892 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5893 instruction to the dummy code region.
5894
56f79b63
TT
58952019-07-19 Tom Tromey <tromey@adacore.com>
5896
5897 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5898 (ARGSUSED, PARAMS, __func__): Remove rules.
5899
4c5aa8e0
AH
59002019-07-19 Alan Hayward <alan.hayward@arm.com>
5901
5902 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5903 * features/arm/arm-with-iwmmxt.c: Remove.
5904 * features/arm/arm-with-iwmmxt.xml: Remove.
5905 * features/arm/arm-with-m-fpa-layout.c: Remove.
5906 * features/arm/arm-with-m-fpa-layout.xml: Remove.
5907 * features/arm/arm-with-m-vfp-d16.c: Remove.
5908 * features/arm/arm-with-m-vfp-d16.xml: Remove.
5909 * features/arm/arm-with-m.c: Remove.
5910 * features/arm/arm-with-m.xml: Remove.
5911 * features/arm/arm-with-neon.c: Remove.
5912 * features/arm/arm-with-neon.xml: Remove.
5913 * features/arm/arm-with-vfpv2.c: Remove.
5914 * features/arm/arm-with-vfpv2.xml: Remove.
5915 * features/arm/arm-with-vfpv3.c: Remove.
5916 * features/arm/arm-with-vfpv3.xml: Remove.
5917
f42b2617
AH
59182019-07-19 Alan Hayward <alan.hayward@arm.com>
5919
5920 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5921
f29ec966
AH
59222019-07-19 Alan Hayward <alan.hayward@arm.com>
5923
5924 * arch/aarch32.c (aarch32_create_target_description): Create
5925 target descriptions using features.
5926 * arch/arm.c (arm_create_target_description)
5927 (arm_create_mprofile_target_description): Likewise.
5928 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5929
d105cce5
AH
59302019-07-19 Alan Hayward <alan.hayward@arm.com>
5931
5932 * Makefile.in: Add new files.
5933 * aarch32-tdep.c: New file.
5934 * aarch32-tdep.h: New file.
5935 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5936 Call aarch32_read_description.
5937 * arch/aarch32.c: New file.
5938 * arch/aarch32.h: New file.
5939 * arch/arm.c (arm_create_target_description)
5940 (arm_create_mprofile_target_description): New function.
5941 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5942 (arm_create_target_description)
5943 (arm_create_mprofile_target_description): New declaration.
5944 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5945 read_description functions.
5946 * arm-linux-nat.c (arm_linux_nat_target::read_description):
5947 Likewise.
5948 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5949 * arm-tdep.c (tdesc_arm_list): New variable.
5950 (arm_register_g_packet_guesses): Call create description functions.
5951 (arm_read_description) (arm_read_mprofile_description): New
5952 function.
5953 * arm-tdep.h (arm_read_description)
5954 (arm_read_mprofile_description): Add declaration.
5955 * configure.tgt: Add new files.
5956
afe09f0b
GL
59572019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
5958
5959 * top.c (new_ui_command): Open specified terminal just once.
5960
cd215b2e
TT
59612019-07-18 Tom Tromey <tromey@adacore.com>
5962
5963 * symtab.c (main_name): Constify return type.
5964 * symfile.c (set_initial_language): Update.
5965 * symtab.h (main_name): Constify return type.
5966
d8f68fcb
TT
59672019-07-17 Tom Tromey <tom@tromey.com>
5968
5969 * tui/tui-winsource.c (tui_update_source_window)
5970 (tui_update_source_window_as_is)
5971 (tui_update_source_windows_with_line): Remove return.
5972 * tui/tui-disasm.c (tui_show_disassem)
5973 (tui_show_disassem_and_update_source): Remove return.
5974 * tui/tui.c (tui_reset): Remove return.
5975 * tui/tui-wingeneral.c
5976 (tui_check_and_display_highlight_if_needed): Remove return.
5977
ca5af91e
TT
59782019-07-17 Tom Tromey <tom@tromey.com>
5979
5980 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5981
5104fe36
TT
59822019-07-17 Tom Tromey <tom@tromey.com>
5983
5984 * tui/tui-winsource.h (struct tui_exec_info_window)
5985 (struct tui_source_window_base): Move from tui-data.h.
5986 * tui/tui-winsource.c: Move many method definitions from
5987 elsewhere. Remove "structuring" comments.
5988 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5989 (tui_source_window_base::refresh_window): Move to
5990 tui-winsource.c.
5991 * tui/tui-win.c (tui_source_window_base::refresh_all)
5992 (tui_source_window_base::update_tab_width)
5993 (tui_source_window_base::set_new_height)
5994 (tui_source_window_base::do_make_visible_with_new_height): Move to
5995 tui-winsource.c.
5996 * tui/tui-source.h: Update.
5997 * tui/tui-source.c (tui_source_window_base::reset): Move to
5998 tui-winsource.c.
5999 * tui/tui-disasm.h: Update.
6000 * tui/tui-data.h (struct tui_exec_info_window): Move to
6001 tui-winsource.h.
6002 (struct tui_source_window_base): Likewise.
6003 * tui/tui-data.c (tui_source_window_base::clear_detail)
6004 (tui_source_window_base, ~tui_source_window_base): Move to
6005 tui-winsource.c.
6006
daa15dde
TT
60072019-07-17 Tom Tromey <tom@tromey.com>
6008
6009 * tui/tui-win.c (tui_resize_all)
6010 (tui_source_window_base::update_tab_width)
6011 (tui_adjust_win_heights): Update.
6012 (tui_win_info::make_invisible_and_set_new_height): Rename from
6013 make_invisible_and_set_new_height.
6014 * tui/tui-data.h (struct tui_win_info)
6015 <make_invisible_and_set_new_height>: New method.
6016
bfad4537
TT
60172019-07-17 Tom Tromey <tom@tromey.com>
6018
6019 * tui/tui.c: Update.
6020 * tui/tui-source.h (struct tui_source_window): Move from
6021 tui-data.h.
6022 * tui/tui-layout.c: Update.
6023 * tui/tui-disasm.c: Update.
6024 * tui/tui-data.h (struct tui_source_window): Move to
6025 tui-source.h.
6026
88f7e873
TT
60272019-07-17 Tom Tromey <tom@tromey.com>
6028
6029 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6030 tui-data.h.
6031 * tui/tui-data.h (struct tui_disasm_window): Move to
6032 tui-disasm.h.
6033
96bd6233
TT
60342019-07-17 Tom Tromey <tom@tromey.com>
6035
6036 * tui/tui-regs.h (struct tui_data_item_window): Move from
6037 tui-data.h.
6038 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6039 * tui/tui-data.h (struct tui_data_item_window): Move to
6040 tui-regs.h.
6041 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6042
ce38393b
TT
60432019-07-17 Tom Tromey <tom@tromey.com>
6044
6045 * tui/tui.c: Update.
6046 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6047 (tui_cmd_window::max_height): Move to tui-command.c.
6048 * tui/tui-layout.c: Update.
6049 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6050 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6051 tui-command.c.
6052 * tui/tui-command.h (struct tui_cmd_window): Move from
6053 tui-data.h.
6054 * tui/tui-command.c: Remove "structuring" comments.
6055 (tui_cmd_window::clear_detail)
6056 (tui_cmd_window::do_make_visible_with_new_height)
6057 (tui_cmd_window::max_height): Move from elsewhere.
6058
2d8b51cb
TT
60592019-07-17 Tom Tromey <tom@tromey.com>
6060
6061 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6062 Now static.
6063 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6064 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6065
18ab23af
TT
60662019-07-17 Tom Tromey <tom@tromey.com>
6067
6068 * tui/tui.c: Update.
6069 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6070 tui-regs.c.
6071 * tui/tui-windata.h: Remove file.
6072 * tui/tui-windata.c: Remove file.
6073 * tui/tui-win.c (tui_data_window::set_new_height)
6074 (tui_data_window::do_make_visible_with_new_height): Move to
6075 tui-regs.c.
6076 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6077 * tui/tui-regs.c: Remove "structuring" comments.
6078 (tui_data_window::first_data_item_displayed)
6079 (tui_data_window::delete_data_content_windows)
6080 (tui_data_window::erase_data_content)
6081 (tui_data_window::display_all_data)
6082 (tui_data_window::refresh_all)
6083 (tui_data_window::do_scroll_vertical)
6084 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6085 (tui_data_window::do_make_visible_with_new_height)
6086 (tui_data_window::refresh_window): Move from elsewhere.
6087 (_initialize_tui_regs): Move to end of file.
6088 * tui/tui-layout.c: Update.
6089 * tui/tui-hooks.c: Update.
6090 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6091 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6092 tui-regs.c.
6093 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6094
88b7e7cc
TT
60952019-07-17 Tom Tromey <tom@tromey.com>
6096
6097 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6098 seen.
6099
0fcd3711
TT
61002019-07-17 Tom Tromey <tom@tromey.com>
6101
6102 * tui/tui-win.c (tui_source_window_base::set_new_height)
6103 (tui_source_window_base::do_make_visible_with_new_height): Use
6104 m_has_locator field directly.
6105 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6106 method.
6107 (struct tui_source_window_base) <has_locator>: Likewise.
6108
4a38112d
TT
61092019-07-17 Tom Tromey <tom@tromey.com>
6110
6111 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6112 Don't declare.
6113 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6114 Remove.
6115 * tui/tui-win.c (tui_source_window_base::set_new_height)
6116 (tui_source_window_base::set_new_height)
6117 (make_invisible_and_set_new_height)
6118 (tui_source_window_base::do_make_visible_with_new_height)
6119 (tui_source_window_base::do_make_visible_with_new_height):
6120 Update.
6121 * tui/tui-layout.c (show_source_disasm_command, show_data)
6122 (show_source_or_disasm_and_command): Update.
6123 * tui/tui-layout.c (show_layout): Update.
6124
09129226
TT
61252019-07-17 Tom Tromey <tom@tromey.com>
6126
6127 * tui/tui-layout.c (make_data_window): Remove.
6128 (show_data): Unify creation and re-initialization cases.
6129
4a8a5e84
TT
61302019-07-17 Tom Tromey <tom@tromey.com>
6131
6132 * tui/tui-layout.c (make_source_window, make_disasm_window):
6133 Remove.
6134 (show_data): Unify creation and re-initialization cases.
6135
76d2be8e
TT
61362019-07-17 Tom Tromey <tom@tromey.com>
6137
6138 * tui/tui-layout.c (make_command_window): Remove.
6139 (show_source_disasm_command, show_source_or_disasm_and_command):
6140 Unify creation and re-initialization cases.
6141
890b8bde
TT
61422019-07-17 Tom Tromey <tom@tromey.com>
6143
6144 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6145 creation and re-initialization cases.
6146
2cdfa113
TT
61472019-07-17 Tom Tromey <tom@tromey.com>
6148
6149 * tui/tui-regs.c (tui_get_register): Return void.
6150
8e3cfd09
TT
61512019-07-17 Tom Tromey <tom@tromey.com>
6152
6153 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6154 Simplify.
6155
f4e04977
TT
61562019-07-17 Tom Tromey <tom@tromey.com>
6157
6158 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6159 resetting.
6160
0379b883
TT
61612019-07-17 Tom Tromey <tom@tromey.com>
6162
6163 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6164 * tui/tui-regs.c (tui_reg_layout): New function.
6165 (tui_show_registers, tui_reg_command): Use it.
6166 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6167 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6168 parameters.
6169 (tui_layout_command): Remove.
6170
b7fbad91
TT
61712019-07-17 Tom Tromey <tom@tromey.com>
6172
6173 * tui/tui-layout.h (tui/tui-layout): Return void.
6174 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6175
4e1e56b9
TT
61762019-07-17 Tom Tromey <tom@tromey.com>
6177
6178 * tui/tui-layout.c (show_source_disasm_command, show_data):
6179 Update.
6180 (reset_locator): Remove.
6181 (show_source_or_disasm_and_command): Update.
6182
1e0c09ba
TT
61832019-07-17 Tom Tromey <tom@tromey.com>
6184
6185 * tui/tui-source.c (tui_source_window_base::reset): Remove
6186 win_type parameter.
6187 * tui/tui-layout.c (make_command_window, make_source_window)
6188 (make_disasm_window, make_data_window)
6189 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6190 (reset_locator, show_source_or_disasm_and_command): Update.
6191 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6192 win_type parameter.
6193 (struct tui_source_window_base) <reset>: Likewise.
6194
1bf605de
TT
61952019-07-17 Tom Tromey <tom@tromey.com>
6196
6197 * tui/tui-layout.c (show_source_disasm_command): Use
6198 reset_locator.
6199 (reset_locator): New function.
6200 (init_and_make_win): Remove.
6201 (show_source_or_disasm_and_command): Use reset_locator.
6202
098f9ed4
TT
62032019-07-17 Tom Tromey <tom@tromey.com>
6204
6205 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6206 condition.
6207 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6208 Remove condition.
6209 * tui/tui-source.c (tui_source_window_base::reset): New method.
6210 * tui/tui-layout.c (make_command_window): Don't call
6211 init_and_make_win.
6212 (make_source_window, make_disasm_window): Don't call
6213 make_source_or_disasm_window.
6214 (make_data_window): Don't call init_and_make_win. Change calling
6215 convention.
6216 (show_source_disasm_command, show_data): Simplify.
6217 (make_source_or_disasm_window): Remove.
6218 (show_source_or_disasm_and_command): Simplify.
6219 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6220 (struct tui_source_window_base) <reset>: Likewise.
6221 <execution_info>: Remove initializer.
6222 * tui/tui-data.c (tui_source_window_base): Initialize
6223 execution_info.
6224
80110957
TT
62252019-07-17 Tom Tromey <tom@tromey.com>
6226
6227 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6228 variable.
6229
cf82af05
TT
62302019-07-17 Tom Tromey <tom@tromey.com>
6231
6232 * tui/tui.c (tui_rl_other_window): Update.
6233 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6234 superclass method first. Always iterate over regs_content.
6235 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6236 method.
6237 * tui/tui-win.c (tui_set_focus_command): Update.
6238
01aeb396
TT
62392019-07-17 Tom Tromey <tom@tromey.com>
6240
6241 * tui/tui-win.c (tui_set_focus_command): Rename from
6242 tui_set_focus. Call tui_enable.
6243 (tui_set_focus_command): Remove.
6244
fd6c75ee
TT
62452019-07-17 Tom Tromey <tom@tromey.com>
6246
6247 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6248 refresh_window.
6249 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6250 touchwin.
6251 (tui_data_window::refresh_window): Call refresh_window on data
6252 items. Always call superclass refresh_window.
6253 (tui_win_info::refresh): Remove.
6254 (tui_source_window_base::refresh_window): Update.
6255 (tui_refresh_all): Update.
6256 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6257 refresh_window.
6258 (show_source_or_disasm_and_command): Likewise.
6259 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6260 (struct tui_source_window_base) <refresh>: Likewise.
6261
f6cc34a9
TT
62622019-07-17 Tom Tromey <tom@tromey.com>
6263
6264 * tui/tui-winsource.c (tui_clear_source_content)
6265 (tui_show_source_content): Update.
6266 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6267 whether content is empty.
6268 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6269 Remove.
6270
f31ec9af
TT
62712019-07-17 Tom Tromey <tom@tromey.com>
6272
6273 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6274 window's contents.
6275 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6276 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6277
d1b6f1e5
TT
62782019-07-17 Tom Tromey <tom@tromey.com>
6279
6280 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6281 (struct tui_data_item_window): Update.
6282
d9743a13
TT
62832019-07-17 Tom Tromey <tom@tromey.com>
6284
6285 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6286 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6287 defines.
6288
caf0bc4e
TT
62892019-07-17 Tom Tromey <tom@tromey.com>
6290
6291 * tui/tui-winsource.h (tui_erase_source_content)
6292 (tui_clear_source_content): Remove "display_prompt" parameter.
6293 * tui/tui-winsource.c (tui_update_source_window_as_is)
6294 (tui_update_source_windows_with_addr): Update.
6295 (tui_clear_source_content): Remove "display_prompt" parameter.
6296 (tui_erase_source_content): Likewise. Simplify.
6297 (tui_show_source_content): Update.
6298 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6299 * tui/tui-stack.c (tui_show_frame_info): Update.
6300 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6301 Remove defines.
6302
9d391078
TT
63032019-07-17 Tom Tromey <tom@tromey.com>
6304
6305 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6306 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6307 parameter.
6308 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6309 parameter.
6310
a38da35d
TT
63112019-07-17 Tom Tromey <tom@tromey.com>
6312
6313 * tui/tui-winsource.c (tui_clear_source_content)
6314 (tui_show_source_content, tui_show_exec_info_content)
6315 (tui_clear_exec_info_content): Update.
6316 * tui/tui-stack.c (tui_show_locator_content): Update.
6317 (tui_show_frame_info): Update.
6318 * tui/tui-source.h (tui_source_window): Don't declare.
6319 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6320 from tui_source_is_displayed.
6321 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6322 Remove field.
6323 (struct tui_source_window_base) <content_in_use>: New field. Now
6324 bool.
6325 (struct tui_source_window) <showing_source_p>: New method.
6326 (TUI_SRC_WIN): Change cast.
6327 * tui/tui-data.c (tui_initialize_static_data): Update.
6328
c2cd8994
TT
63292019-07-17 Tom Tromey <tom@tromey.com>
6330
6331 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6332 location_matches_p.
6333 * tui/tui-source.c (tui_source_window::location_matches_p): New
6334 method.
6335 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6336 method.
6337 * tui/tui-data.h (struct tui_source_window_base)
6338 <location_matches_p>: New method.
6339 (struct tui_source_window, struct tui_disasm_window)
6340 <location_matches_p>: Likewise.
6341
4dde7b34
TT
63422019-07-17 Tom Tromey <tom@tromey.com>
6343
6344 * tui/tui-win.c (tui_set_win_height_command): Rename from
6345 tui_set_win_height.
6346 (tui_set_win_height_command): Remove.
6347
b73dd877
TT
63482019-07-17 Tom Tromey <tom@tromey.com>
6349
6350 * tui/tui-source.c (tui_source_window): New constructor. Add
6351 observer.
6352 (~tui_source_window): New destructor.
6353 (tui_source_window::style_changed): New method.
6354 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6355 (tui_attach_detach_observers): Update.
6356 * tui/tui-data.h (struct tui_source_window): Make constructor not
6357 inline. Add destructor.
6358 (struct tui_source_window) <style_changed>: New method.
6359 <m_observable>: New member.
6360
ae2b5380
TT
63612019-07-17 Tom Tromey <tom@tromey.com>
6362
6363 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6364 * tui/tui-win.c (tui_resize_all): Fix typo.
6365
1ce3e844
TT
63662019-07-17 Tom Tromey <tom@tromey.com>
6367
6368 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6369 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6370 (tui_refresh_all): Remove "list" parameter. Use foreach.
6371 * tui/tui-win.c (window_name_completer): Use foreach.
6372 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6373 (update_tab_width): Likewise.
6374 * tui/tui-layout.c (show_layout): Update.
6375 * tui/tui-data.h (class tui_window_iterator): New.
6376 (struct all_tui_windows): New.
6377 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6378
fe3eaf1c
TT
63792019-07-17 Tom Tromey <tom@tromey.com>
6380
6381 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6382 parameter. Don't reference globals.
6383 (tui_reg_command): Update.
6384
368c1354
TT
63852019-07-17 Tom Tromey <tom@tromey.com>
6386
6387 * tui/tui-regs.c (tui_show_registers): Simplify.
6388
e80cd204
TT
63892019-07-17 Tom Tromey <tom@tromey.com>
6390
6391 * tui/tui-regs.c (tui_show_registers): Update.
6392 (tui_show_register_group): Add win_info parameter.
6393
aca2dd16
TT
63942019-07-17 Tom Tromey <tom@tromey.com>
6395
6396 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6397 Rename from tui_display_reg_element_at_line.
6398 (tui_data_window::display_registers_from_line): Update.
6399 * tui/tui-data.h (struct tui_data_window)
6400 <display_reg_element_at_line>: New method.
6401
517e9505
TT
64022019-07-17 Tom Tromey <tom@tromey.com>
6403
6404 * tui/tui-regs.h (tui_display_registers_from)
6405 (tui_display_registers_from_line): Don't declare.
6406 * tui/tui-windata.c (tui_data_window::display_all_data)
6407 (tui_data_window::refresh_all)
6408 (tui_data_window::do_scroll_vertical): Update.
6409 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6410 from tui_display_registers_from.
6411 (tui_display_reg_element_at_line): Update.
6412 (tui_data_window::display_registers_from_line): Rename from
6413 tui_display_registers_from_line.
6414 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6415 display_registers_from_line>: New methods.
6416
f76d8b19
TT
64172019-07-17 Tom Tromey <tom@tromey.com>
6418
6419 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6420 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6421 from tui_erase_data_content.
6422 (tui_data_window::display_all_data)
6423 (tui_data_window::refresh_all)
6424 (tui_data_window::do_scroll_vertical): Update.
6425 * tui/tui-regs.c (tui_show_registers): Update.
6426 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6427 New method.
6428
b4094625
TT
64292019-07-17 Tom Tromey <tom@tromey.com>
6430
6431 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6432 declare.
6433 * tui/tui-windata.c
6434 (tui_data_window::delete_data_content_windows): Rename from
6435 tui_delete_data_content_windows.
6436 (tui_data_window::display_all_data)
6437 (tui_data_window::do_scroll_vertical): Update.
6438 * tui/tui-data.h (struct tui_data_window)
6439 <delete_data_content_windows>: New method.
6440
c223a729
TT
64412019-07-17 Tom Tromey <tom@tromey.com>
6442
6443 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6444 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6445
50daf268
TT
64462019-07-17 Tom Tromey <tom@tromey.com>
6447
6448 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6449 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6450 from tui_display_all_data.
6451 * tui/tui-win.c
6452 (tui_data_window::do_make_visible_with_new_height): Update.
6453 * tui/tui-regs.c (tui_show_registers): Update.
6454 * tui/tui-layout.c (tui_set_layout): Update.
6455 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6456 method.
6457
df5f8cab
TT
64582019-07-17 Tom Tromey <tom@tromey.com>
6459
6460 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6461 * tui/tui-windata.c (tui_display_data_from): Remove.
6462 (tui_data_window::refresh_all): Update.
6463
80cb6c27
TT
64642019-07-17 Tom Tromey <tom@tromey.com>
6465
6466 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6467 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6468 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6469 tui_display_registers_from_line.
6470 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6471 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6472 "force_display" parameter.
6473
baff0c28
TT
64742019-07-17 Tom Tromey <tom@tromey.com>
6475
6476 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6477 declare.
6478 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6479 Rename from tui_first_reg_element_no_inline.
6480 (tui_display_reg_element_at_line)
6481 (tui_display_registers_from_line): Update.
6482 * tui/tui-data.h (struct tui_data_window)
6483 <first_reg_element_no_inline>: New method.
6484
3b23c5f2
TT
64852019-07-17 Tom Tromey <tom@tromey.com>
6486
6487 * tui/tui-windata.c (tui_display_data_from)
6488 (tui_data_window::do_scroll_vertical): Update.
6489 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6490 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6491 Rename from tui_line_from_reg_element_no.
6492 (tui_display_registers_from_line): Update.
6493 * tui/tui-data.h (struct tui_data_window)
6494 <line_from_reg_element_no>: New method.
6495
0b5ec218
TT
64962019-07-17 Tom Tromey <tom@tromey.com>
6497
6498 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6499 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6500 tui_last_regs_line_no.
6501 (tui_display_reg_element_at_line)
6502 (tui_display_registers_from_line): Update.
6503 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6504 method.
6505
0807ab7b
TT
65062019-07-17 Tom Tromey <tom@tromey.com>
6507
6508 PR tui/24722:
6509 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6510 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6511 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6512 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6513 (tui_update_breakpoint_info): Likewise.
6514 * tui/tui-hooks.c (tui_event_create_breakpoint)
6515 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6516 Update.
6517
9ad7fdef
TT
65182019-07-17 Tom Tromey <tom@tromey.com>
6519
6520 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6521
5813316f
TT
65222019-07-17 Tom Tromey <tom@tromey.com>
6523
6524 * tui/tui-winsource.c (tui_update_source_window_as_is)
6525 (tui_update_source_windows_with_addr): Update.
6526 * tui/tui-source.h (tui_set_source_content)
6527 (tui_show_symtab_source): Add "win_info" parameter.
6528 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6529 parameter.
6530 (tui_show_symtab_source): Likewise.
6531
00e264e7
TT
65322019-07-17 Tom Tromey <tom@tromey.com>
6533
6534 * tui/tui-wingeneral.c
6535 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6536
06210ce4
TT
65372019-07-17 Tom Tromey <tom@tromey.com>
6538
6539 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6540 (struct tui_cmd_window) <can_scroll>: New method.
6541 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6542 method.
6543
381befee
TT
65442019-07-17 Tom Tromey <tromey@adacore.com>
6545
6546 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6547 do_field_signed>: Rename. Change type of "value".
6548 * ui-out.c (ui_out::field_signed): Rename from field_int.
6549 Change type of "value".
6550 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6551 type of "value".
6552 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6553 do_field_int. Change type of "value".
6554 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6555 do_field_int. Change type of "value".
6556 * tracepoint.c (trace_status_mi, tfind_1)
6557 (print_one_static_tracepoint_marker): Update.
6558 * thread.c (print_thread_info_1, print_selected_thread_frame):
6559 Update.
6560 * stack.c (print_frame, print_frame_info): Update.
6561 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6562 Update.
6563 * source.c (print_source_lines_base): Update.
6564 * skip.c (info_skip_command): Update.
6565 * record-btrace.c (btrace_ui_out_decode_error)
6566 (btrace_call_history_src_line): Update.
6567 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6568 Update.
6569 * progspace.c (print_program_space): Update.
6570 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6571 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6572 do_field_int. Change type of "value".
6573 * mi/mi-out.c (mi_ui_out::do_table_begin)
6574 (mi_ui_out::do_table_header): Update.
6575 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6576 type of "value".
6577 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6578 (mi_cmd_data_list_changed_registers, output_register)
6579 (mi_cmd_data_read_memory, mi_load_progress)
6580 (mi_cmd_trace_frame_collected): Update.
6581 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6582 Update.
6583 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6584 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6585 (mi_cmd_var_list_children, varobj_update_one): Update.
6586 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6587 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6588 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6589 * inferior.c (print_inferior): Update.
6590 * gdb_bfd.c (print_one_bfd): Update.
6591 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6592 Update.
6593 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6594 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6595 do_field_int. Change type of "value".
6596 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6597 do_field_int. Change type of "value".
6598 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6599 (print_one_breakpoint_location, print_it_catch_fork)
6600 (print_one_catch_fork, print_it_catch_vfork)
6601 (print_one_catch_vfork, print_it_catch_solib)
6602 (print_it_catch_exec, print_it_ranged_breakpoint)
6603 (print_mention_watchpoint, print_mention_masked_watchpoint)
6604 (bkpt_print_it, update_static_tracepoint): Update.
6605 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6606 * break-catch-syscall.c (print_it_catch_syscall): Update.
6607 * ada-tasks.c (print_ada_task_info): Update.
6608 * ada-lang.c (print_it_exception, print_mention_exception):
6609 Update.
6610
6b78c3f8
AB
66112019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6612
6613 PR breakpoints/24541
6614 * gdbarch.c: Regenerate.
6615 * gdbarch.h: Regenerate.
6616 * gdbarch.sh: Adjust return type and parameter types for
6617 'stap_adjust_register'.
6618 (i386_stap_adjust_register): Adjust signature and return new
6619 register name.
6620 * stap-probe.c (stap_parse_register_operand): Adjust use of
6621 'gdbarch_stap_adjust_register'.
6622
d72a9b85
TT
66232019-07-17 Tom Tromey <tromey@adacore.com>
6624
6625 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6626 declare VEC.
6627 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6628 std::vector.
6629 (struct s390_process_info): Add initializers.
6630 (s390_add_process): Use new.
6631 (s390_linux_nat_target::low_forget_process): Use delete.
6632 (s390_linux_nat_target::low_new_fork)
6633 (s390_linux_nat_target::stopped_by_watchpoint)
6634 (s390_linux_nat_target::low_prepare_to_resume)
6635 (s390_linux_nat_target::insert_watchpoint)
6636 (s390_linux_nat_target::insert_hw_breakpoint)
6637 (s390_linux_nat_target::remove_watchpoint)
6638 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6639
206e6c58
JB
66402019-07-16 John Baldwin <jhb@FreeBSD.org>
6641
6642 * aarch64-fbsd-nat.c: Include regcache.h.
6643 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6644 argument.
6645 (aarch64_fbsd_nat_target::fetch_registers)
6646 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6647 variable.
6648 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6649
cbde90f2
JB
66502019-07-16 John Baldwin <jhb@FreeBSD.org>
6651
6652 * fbsd-nat.c: Include gdbarch.h.
6653
07128006
TT
66542019-07-15 Tom Tromey <tromey@adacore.com>
6655
6656 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6657
1f77b012
TT
66582019-07-15 Tom Tromey <tromey@adacore.com>
6659
6660 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6661 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6662 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6663 * cli-out.c (cli_ui_out::do_field_int): New method.
6664 * ui-out.c (ui_out::field_unsigned): New method.
6665 * symfile.c (generic_load): Use field_unsigned.
6666 (print_transfer_performance): Likewise.
6667 * record-btrace.c (ui_out_field_uint): Remove.
6668 (btrace_call_history_insn_range, btrace_call_history): Use
6669 field_unsigned.
6670 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6671 field_unsigned.
6672 * ui-out.h (class ui_out) <field_unsigned>: New method.
6673 <do_field_unsigned>: Likewise.
6674
33eca680
TT
66752019-07-15 Tom Tromey <tromey@adacore.com>
6676
6677 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6678 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6679 * target.c (flash_erase_command): Use field_string.
6680 * infrun.c (print_signal_received_reason): Use field_string.
6681 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6682 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6683 field_string.
6684 * ada-tasks.c (print_ada_task_info): Use field_string.
6685
ca8d69be
TT
66862019-07-15 Tom Tromey <tromey@adacore.com>
6687
6688 * target.c (flash_erase_command): Use field_core_addr.
6689 * symfile.c (generic_load): Use field_core_addr.
6690 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6691 Use field_core_addr.
6692 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6693 field_core_addr.
6694
0d4e84ed
AB
66952019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6696
6697 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6698 value if its desired type is smaller than a CORE_ADDR and signed.
6699
9a49df9d
AB
67002019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6701
6702 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6703 of changes to field names, and use new is_reference field to
6704 decide if a property is a reference or not.
6705 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6706 field.
6707 (struct dwarf2_property_baton): Update header comment, rename
6708 'referenced_type' to 'property_type' and update comments.
6709 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6710 default property type, store in property baton, update to take
6711 accound of renamed field.
6712 (read_func_scope): Update call to attr_to_dynamic_prop.
6713 (read_array_type): Likewise.
6714 (dwarf2_per_cu_addr_sized_int_type): New function.
6715 (read_subrange_index_type): Move type finding code to
6716 dwarf2_per_cu_addr_sized_int_type.
6717 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6718 (dwarf2_per_cu_addr_type): New function.
6719 (set_die_type): Update calls to attr_to_dynamic_prop.
6720
b86352cf
AB
67212019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6722
6723 * dwarf2read.c (read_subrange_index_type): New function.
6724 (read_subrange_type): Move code into new function and call it.
6725 * gdbtypes.c (create_range_type): Add some asserts.
6726
603490bf
AB
67272019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6728
6729 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6730 update return statements.
6731 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6732 declaration, and update comment to match.
6733 * gdbtypes.c (resolve_dynamic_array): Update call to
6734 dwarf2_evaluate_property to match new return type.
6735
592f9d27
AB
67362019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6737
6738 * valarith.c (value_subscripted_rvalue): Change lowerbound
6739 parameter type from int to LONGEST.
6740 * value.h (value_subscripted_rvalue): Likewise in declaration.
6741
60cfcb20
AB
67422019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6743
6744 * cli/cli-utils.c (info_print_command_completer): New function.
6745 * cli/cli-utils.h: Add 'completer.h' include, and forward
6746 declaration for 'struct cmd_list_element'.
6747 (info_print_command_completer): Declare.
6748 * stack.c (_initialize_stack): Add completer for 'info locals' and
6749 'info args'.
6750 * symtab.c (_initialize_symtab): Add completer for 'info
6751 variables' and 'info functions'.
6752 * NEWS: Mention completion for additional info commands.
6753
b16507e0
AB
67542019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6755
6756 * cli/cli-utils.c (extract_info_print_args): Delete.
6757 (extract_arg_maybe_quoted): Delete.
6758 (info_print_options_defs): New variable.
6759 (make_info_print_options_def_group): New function.
6760 (extract_info_print_options): Define new function.
6761 * cli/cli-utils.h (extract_info_print_args): Delete.
6762 (struct info_print_options): New structure.
6763 (extract_info_print_options): Declare new function.
6764 * stack.c (info_locals_command): Update to use new
6765 extract_info_print_options, also add a header comment.
6766 (info_args_command): Likewise.
6767 * symtab.c (info_variables_command): Likewise.
6768 (info_functions_command): Likewise.
6769
021d8588
AB
67702019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6771
6772 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6773 to extract string arguments.
6774 * common/common-utils.c (extract_string_maybe_quoted): New function.
6775 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6776
b777eb6d
TT
67772019-07-11 Tom Tromey <tromey@adacore.com>
6778
6779 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6780 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6781 * top.h (gdbinit): Don't declare.
6782 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6783 into...
6784 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6785 * top.c (gdb_init): Don't call init_cli_cmds.
6786 (gdbinit): Remove.
6787 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6788
72ee03ff
TT
67892019-07-11 Tom Tromey <tromey@adacore.com>
6790
6791 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6792 after it has been moved.
6793
00db9531
SM
67942019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6795
6796 * valops.c (value_must_coerce_to_target): Change return type to
6797 bool.
6798 * value.h (value_must_coerce_to_target): Likewise.
6799
f2478a7e
SM
68002019-07-10 Simon Marchi <simon.marchi@efficios.com>
6801
6802 * breakpoint.c (is_hardware_watchpoint): Remove
6803 forward-declaration.
6804 (is_masked_watchpoint): Change return type to bool.
6805 (is_tracepoint): Likewise.
6806 (is_breakpoint): Likewise.
6807 (is_hardware_watchpoint): Likewise.
6808 (is_watchpoint): Likewise.
6809 (is_no_memory_software_watchpoint): Likewise.
6810 (is_catchpoint): Likewise.
6811 (breakpoint_1): Make FILTER parameter's return type bool.
6812 is_masked_watchpoint): Change return type to bool.
6813 (save_breakpoints): Make FILTER parameter's return type bool.
6814 * breakpoint.h (is_breakpoint): Change return type to bool.
6815 (is_watchpoint): Likewise.
6816 (is_catchpoint): Likewise.
6817 (is_tracepoint): Likewise.
6818
0d12e84c
TT
68192019-07-10 Tom Tromey <tom@tromey.com>
6820
6821 * defs.h: Don't include gdbarch.h.
6822 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6823 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6824 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6825 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6826 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6827 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6828 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6829 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6830 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6831 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6832 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6833 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6834 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6835 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6836 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6837 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6838 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6839 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6840 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6841 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6842 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6843 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6844 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6845 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6846 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6847 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6848 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6849
f06f1252
TT
68502019-07-10 Tom Tromey <tromey@adacore.com>
6851
6852 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6853 * breakpoint.c (init_ada_exception_breakpoint): Register as
6854 bp_catchpoint.
6855 (print_one_breakpoint_location, print_one_breakpoint): Use
6856 is_ada_exception_catchpoint.
6857 * ada-lang.c (class ada_catchpoint_location): Pass
6858 bp_loc_software_breakpoint to bp_location constructor.
6859 (is_ada_exception_catchpoint): New function.
6860
7a5d944b
TT
68612019-07-10 Tom Tromey <tromey@adacore.com>
6862
6863 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6864 VEC.
6865 (struct arm_exidx_entry): New method operator<.
6866 (struct arm_exidx_data) <section_maps>: Change type.
6867 (arm_exidx_data_free): Remove.
6868 (arm_exidx_data_key): Change type. Move lower.
6869 (arm_exidx_new_objfile): Update.
6870 (arm_compare_exidx_entries): Remove.
6871 (arm_find_exidx_entry, _initialize_arm_tdep)
6872
48c66e1d
TT
68732019-07-10 Tom Tromey <tromey@adacore.com>
6874
6875 * solib-spu.c (ocl_program_data_key): Change type.
6876 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6877 Update.
6878
a269fbf1
TT
68792019-07-10 Tom Tromey <tromey@adacore.com>
6880
6881 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
6882 (struct solib_aix_inferior_data) <library_list>: Change type.
6883 (solib_aix_inferior_data_handle): Change type.
6884 (get_solib_aix_inferior_data): Update.
6885 (solib_aix_free_library_list): Remove.
6886 (library_list_start_library): Update.
6887 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6888 return type.
6889 (solib_aix_get_library_list)
6890 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6891 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6892
c294730c
TT
68932019-07-10 Tom Tromey <tromey@adacore.com>
6894
6895 * solib-dsbt.c (struct dsbt_info): Add initializers.
6896 (solib_dsbt_pspace_data): Change type.
6897 (dsbt_pspace_data_cleanup): Remove.
6898 (get_dsbt_info, _initialize_dsbt_solib): Update.
6899
9d52077d
TT
69002019-07-10 Tom Tromey <tromey@adacore.com>
6901
6902 * spu-tdep.c (spu_overlay_data): Change type.
6903 (spu_get_overlay_table, spu_overlay_new_objfile)
6904 (_initialize_spu_tdep): Update.
6905
22a20dca
TT
69062019-07-10 Tom Tromey <tromey@adacore.com>
6907
6908 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6909 destructor.
6910 (dbx_objfile_data_key): Change type and declare later.
6911 (DBX_SYMFILE_INFO): Rewrite.
6912 * dbxread.c (dbx_objfile_data_key): Change type.
6913 (dbx_symfile_init): Update.
6914 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
6915 (coffstab_build_psymtabs, elfstab_build_psymtabs)
6916 (stabsect_build_psymtabs, _initialize_dbxread): Update.
6917
cb60f420
TT
69182019-07-10 Tom Tromey <tromey@adacore.com>
6919
6920 * jit.c (jit_program_space_key): Change type. Move lower.
6921 (get_jit_program_space_data): Update.
6922 (jit_program_space_data_cleanup): Remove.
6923 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6924 Update.
6925 (struct jit_program_space_data): Add initializers.
6926
51df2ae3
TT
69272019-07-10 Tom Tromey <tromey@adacore.com>
6928
6929 * solib-darwin.c (struct darwin_info): Add initializers.
6930 (solib_darwin_pspace_data): Change type.
6931 (darwin_pspace_data_cleanup): Remove.
6932 (get_darwin_info, _initialize_darwin_solib): Update.
6933
18101a35
TT
69342019-07-10 Tom Tromey <tromey@adacore.com>
6935
6936 * remote-sim.c (struct sim_inferior_data): Add initializers,
6937 constructor, and destructor.
6938 (sim_inferior_data_key): Change type. Move lower.
6939 (check_for_duplicate_sim_descriptor): Update.
6940 (get_sim_inferior_data): Use new. Update.
6941 (~sim_inferior_data_cleanup): Rename from
6942 sim_inferior_data_cleanup. Simplify.
6943 (gdbsim_close_inferior, simulator_command)
6944 (sim_command_completer, _initialize_remote_sim): Update.
6945 (next_pid, INITIAL_PID): Move earlier.
6946
05b08ac1
TT
69472019-07-10 Tom Tromey <tromey@adacore.com>
6948
6949 * python/python-internal.h (create_thread_object): Return
6950 gdbpy_ref.
6951 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6952 * python/py-inferior.c (struct threadlist_entry): Add
6953 constructor.
6954 <thread_obj>: Now a gdbpy_ref.
6955 (thread_to_thread_object): Update.
6956 (add_thread_object): Use new.
6957 (delete_thread_object): Use delete.
6958 (infpy_threads): Update.
6959 (py_free_inferior): Update. Construct "inf_obj" after acquiring
6960 GIL.
6961
32372d80
TT
69622019-07-10 Tom Tromey <tromey@adacore.com>
6963
6964 * valops.c (value_cast): Specialize error message for Ada.
6965
5c458ae8
SM
69662019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6967
6968 * breakpoint.c (breakpoint_1): Update doc and parameter names.
6969
4c462cb0
SM
69702019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6971
6972 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6973 bpstat_should_step): Return bool, adjust comments.
6974 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6975 bpstat_should_step): Likewise.
6976
89abbcc2
AH
69772019-07-10 Alan Hayward <alan.hayward@arm.com>
6978
6979 * features/Makefile: Use feature target descriptions for Arm.
6980 * features/arm/arm-core.c: Generate new file.
6981 * features/arm/arm-fpa.c: Likewise.
6982 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6983 * features/arm/arm-m-profile.c: Likewise.
6984 * features/arm/arm-vfpv2.c: Likewise.
6985 * features/arm/arm-vfpv3.c: Likewise.
6986 * features/arm/xscale-iwmmxt.c: Likewise.
6987 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6988
166a82be
AH
69892019-07-10 Alan Hayward <alan.hayward@arm.com>
6990
6991 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6992 ptrace earlier.
6993
9fb4c7e9
AH
69942019-07-10 Alan Hayward <alan.hayward@arm.com>
6995
6996 * features/aarch64-pauth.c: Regenerate.
6997
e2d0f980
SM
69982019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
6999
7000 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7001 bool.
7002 (bpstat_what): Use false instead of 0.
7003
a38118e5
PA
70042019-07-09 Pedro Alves <palves@redhat.com>
7005
7006 * break-catch-throw.c (is_exception_catchpoint): New.
7007 * breakpoint.c (print_one_breakpoint_location): New parameter
7008 'raw_loc'. Handle it. Use
7009 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7010 looking at the breakpoint's type.
7011 (print_one_breakpoint): If handling "maint info breakpoints", also
7012 print locations of exception catchpoints.
7013 * breakpoint.h (is_exception_catchpoint): Declare.
7014
cb1e4e32
PA
70152019-07-09 Pedro Alves <palves@redhat.com>
7016
7017 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7018 "addr" field.
7019 (allocate_location_exception_catchpoint): New.
7020 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7021 (initialize_throw_catchpoint_ops): Install
7022 allocate_location_exception_catchpoint as allocate_location
7023 method.
7024 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7025 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7026 bp_loc_other.
7027 (breakpoint_address_is_meaningful): Delete.
7028 (bl_address_is_meaningful): New.
7029 (breakpoint_locations_match): Adjust comment.
7030 (bp_location_from_bp_type): New, factored out of...
7031 (bp_location::bp_location(breakpoint *)): ... this.
7032 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7033 factored out of...
7034 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7035 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7036 breakpoint_address_is_meaningful.
7037 (bp_locations_compare): Adjust comment.
7038 (update_global_location_list): Use bl_address_is_meaningful
7039 instead of breakpoint_address_is_meaningful.
7040 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7041 explicit.
7042 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7043 * python/py-breakpoint.c (bppy_get_location): No longer check
7044 whether location is null.
7045
b58a68fe
PA
70462019-07-09 Pedro Alves <palves@redhat.com>
7047
7048 PR c++/15468
7049 * breakpoint.c (print_one_breakpoint_location): Remove
7050 single-location assert.
7051
268a13a5
TT
70522019-07-09 Tom Tromey <tom@tromey.com>
7053
7054 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7055 * configure: Rebuild.
7056 * configure.ac: Change common to gdbsupport.
7057 * gdbsupport: Rename from common.
7058 * acinclude.m4: Change common to gdbsupport.
7059 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7060 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7061 gdbsupport.
7062 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7063 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7064 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7065 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7066 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7067 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7068 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7069 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7070 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7071 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7072 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7073 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7074 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7075 coff-pe-read.c, command.h, compile/compile-c-support.c,
7076 compile/compile-c.h, compile/compile-cplus-symbols.c,
7077 compile/compile-cplus-types.c, compile/compile-cplus.h,
7078 compile/compile-loc2c.c, compile/compile.c, completer.c,
7079 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7080 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7081 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7082 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7083 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7084 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7085 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7086 features/aarch64-core.c, features/aarch64-fpu.c,
7087 features/aarch64-pauth.c, features/aarch64-sve.c,
7088 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7089 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7090 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7091 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7092 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7093 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7094 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7095 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7096 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7097 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7098 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7099 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7100 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7101 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7102 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7103 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7104 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7105 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7106 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7107 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7108 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7109 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7110 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7111 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7112 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7113 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7114 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7115 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7116 minsyms.c, mips-linux-tdep.c, namespace.h,
7117 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7118 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7119 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7120 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7121 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7122 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7123 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7124 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7125 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7126 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7127 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7128 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7129 procfs.c, producer.c, progspace.h, psymtab.h,
7130 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7131 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7132 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7133 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7134 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7135 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7136 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7137 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7138 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7139 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7140 target-memory.c, target.c, target.h, target/waitstatus.c,
7141 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7142 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7143 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7144 unittests/array-view-selftests.c,
7145 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7146 unittests/common-utils-selftests.c,
7147 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7148 unittests/format_pieces-selftests.c,
7149 unittests/function-view-selftests.c,
7150 unittests/lookup_name_info-selftests.c,
7151 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7152 unittests/mkdir-recursive-selftests.c,
7153 unittests/observable-selftests.c,
7154 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7155 unittests/parse-connection-spec-selftests.c,
7156 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7157 unittests/scoped_fd-selftests.c,
7158 unittests/scoped_mmap-selftests.c,
7159 unittests/scoped_restore-selftests.c,
7160 unittests/string_view-selftests.c, unittests/style-selftests.c,
7161 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7162 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7163 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7164 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7165 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7166 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7167
5b0e2db4
AB
71682019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7169
7170 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7171 bool value.
7172 (decode_digits_ordinary): Set explicit_line field in sal.
7173 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7174 symtab_and_line that was set on an explicit line number in
7175 assembler code. Do always update the recorded symtab and line if
7176 we do skip the prologue.
7177
0ba852ab
AB
71782019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7179
7180 * breakpoint.c (set_breakpoint_location_function): Remove
7181 explicit_loc parameter.
7182 (momentary_breakpoint_from_master): Update call to
7183 set_breakpoint_location_function.
7184 (add_location_to_breakpoint): Likewise.
7185
b3a7d171
AB
71862019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7187
7188 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7189 required features based on default bfd type when no specific bfd
7190 is present.
7191
1f6f6e21
PW
71922019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7193
7194 * NEWS: Mention that GDB printf and eval commands can now print
7195 C-style and Ada-style convenience var strings without
7196 calling the inferior.
7197 * printcmd.c (printf_c_string): Locally print GDB internal var
7198 instead of transiting via the inferior.
7199 (printf_wide_c_string): Likewise.
7200
72012019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 7202
5862c886 7203 PR breakpoints/25011
ea142fbf
AH
7204 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7205
0598af48
TT
72062019-07-04 Tom Tromey <tom@tromey.com>
7207
7208 PR tui/24724:
7209 * tui/tui-winsource.c (tui_clear_source_content): Update.
7210 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7211 (tui_update_breakpoint_info): Update.
7212 (tui_set_exec_info_content): Update.
7213 * tui/tui-source.c (tui_set_source_content_nil): Update.
7214 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7215 has_break.
7216 * tui/tui-data.h (enum tui_bp_flag): New.
7217 (tui_bp_flags): New enum flags type.
7218 (struct tui_source_element) <break_mode>: Change type. Rename
7219 from has_break.
7220 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7221 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7222 constants.
7223 * tui/tui-winsource.h: Fix comment.
7224
350fab54
AH
72252019-07-04 Alan Hayward <alan.hayward@arm.com>
7226
7227 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7228 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7229 (store_fpregs_to_thread)
7230 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7231 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7232 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7233 (IWMMXT_REGS_SIZE): Add define.
7234 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7235 (fetch_vfp_regs, store_vfp_regs)
7236 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7237 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7238
f0452268
AH
72392019-07-04 Alan Hayward <alan.hayward@arm.com>
7240
7241 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7242 defines.
7243 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7244 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7245 (ARM_INT_REGISTER_SIZE): ...to this.
7246 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7247 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7248 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7249 (arm_linux_collect_gregset, supply_nwfpe_register)
7250 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7251 defines.
7252 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7253 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7254 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7255 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7256 (arm_return_in_memory, arm_store_return_value)
7257 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7258 (arm_record_ld_st_multiple): Likewise.
7259 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7260 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7261
e935475c
AH
72622019-07-04 Alan Hayward <alan.hayward@arm.com>
7263
7264 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7265 AARCH64_DISPLACED_MODIFIED_INSNS.
7266 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7267 (aarch64_displaced_step_copy_insn): Likewise.
7268 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7269 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7270 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7271 ARM_DISPLACED_MODIFIED_INSNS.
7272 * arm-tdep.c (arm_gdbarch_init): Likewise.
7273 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7274 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7275 (struct arm_displaced_step_closure): Use
7276 ARM_DISPLACED_MODIFIED_INSNS.
7277
df0bb381
AH
72782019-07-04 Alan Hayward <alan.hayward@arm.com>
7279
7280 * features/Makefile: Remove unused xml files.
7281 * features/aarch64.xml: Remove.
7282 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7283 * features/i386/amd64-avx-avx512.xml: Remove.
7284 * features/i386/amd64-avx-linux.xml: Remove.
7285 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7286 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7287 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7288 * features/i386/amd64-avx-mpx.xml: Remove.
7289 * features/i386/amd64-avx.xml: Remove.
7290 * features/i386/amd64-linux.xml: Remove.
7291 * features/i386/amd64-mpx-linux.xml: Remove.
7292 * features/i386/amd64-mpx.xml: Remove.
7293 * features/i386/amd64.xml: Remove.
7294 * features/i386/i386-avx-avx512-linux.xml: Remove.
7295 * features/i386/i386-avx-avx512.xml: Remove.
7296 * features/i386/i386-avx-linux.xml: Remove.
7297 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7298 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7299 * features/i386/i386-avx-mpx-linux.xml: Remove.
7300 * features/i386/i386-avx-mpx.xml: Remove.
7301 * features/i386/i386-avx.xml: Remove.
7302 * features/i386/i386-linux.xml: Remove.
7303 * features/i386/i386-mmx-linux.xml: Remove.
7304 * features/i386/i386-mmx.xml: Remove.
7305 * features/i386/i386-mpx-linux.xml: Remove.
7306 * features/i386/i386-mpx.xml: Remove.
7307 * features/i386/i386.xml: Remove.
7308 * features/i386/x32-avx-avx512-linux.xml: Remove.
7309 * features/i386/x32-avx-linux.xml: Remove.
7310 * features/i386/x32-linux.xml: Remove.
7311
edd6266a
AH
73122019-07-04 Alan Hayward <alan.hayward@arm.com>
7313
7314 * regformats/aarch64.dat: Remove.
7315 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7316 * regformats/i386/amd64-avx-linux.dat: Remove.
7317 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7318 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7319 * regformats/i386/amd64-linux.dat: Remove.
7320 * regformats/i386/amd64-mpx-linux.dat: Remove.
7321 * regformats/i386/amd64.dat: Remove.
7322 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7323 * regformats/i386/i386-avx-linux.dat: Remove.
7324 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7325 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7326 * regformats/i386/i386-linux.dat: Remove.
7327 * regformats/i386/i386-mmx-linux.dat: Remove.
7328 * regformats/i386/i386-mpx-linux.dat: Remove.
7329 * regformats/i386/i386.dat: Remove.
7330 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7331 * regformats/i386/x32-avx-linux.dat: Remove.
7332 * regformats/i386/x32-linux.dat: Remove.
7333
2b40fda7
AH
73342019-07-04 Alan Hayward <alan.hayward@arm.com>
7335
7336 * aarch64-tdep.c: Remove xml self tests.
7337 * amd64-linux-tdep.c: Likewise.
7338 * amd64-tdep.c: Likewise.
7339 * i386-linux-tdep.c: Likewise.
7340 * i386-tdep.c: Likewise.
7341
5f4ba3e7
PA
73422019-07-03 Pedro Alves <palves@redhat.com>
7343
7344 PR cli/24732
7345 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7346 (pipe_cmd_option_defs): New.
7347 (make_pipe_cmd_options_def_group): New.
7348 (pipe_command): Use gdb::option::process_options.
7349 (pipe_command_completer): New function.
7350 (_initialize_cli_cmds): Install completer for "pipe" command.
7351
3d9be6f5
PA
73522019-07-03 Pedro Alves <palves@redhat.com>
7353
7354 * cli/cli-option.c (union option_value) <string>: New field.
7355 (struct option_def_and_value): Add ctor, move ctor, dtor and
7356 use DISABLE_COPY_AND_ASSIGN.
7357 (option_def_and_value::clear_value): New.
7358 (parse_option, save_option_value_in_ctx, get_val_type_str)
7359 (add_setshow_cmds_for_options): Handle var_string.
7360 * cli-option.h (union option_def::var_address) <string>: New
7361 field.
7362 (struct string_option_def): New.
7363 * maint-test-options.c (struct test_options_opts): Add default
7364 ctor and use DISABLE_COPY_AND_ASSIGN.
7365 <string_opt>: New field.
7366 (test_options_opts::~test_options_opts): New.
7367 (test_options_opts::dump): Also dump "-string".
7368 (test_options_option_defs): Install "string.
7369
41fc454c
PA
73702019-07-03 Pedro Alves <palves@redhat.com>
7371
7372 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7373 option_value with a null enumeration.
7374 (complete_options): Save the option values in the context.
7375 (save_option_value_in_ctx): New, factored out from ...
7376 (process_options): ... here.
7377 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7378 of the function.
7379 * maint-test-options.c (test_options_opts::dump): New, factored
7380 out from ...
7381 (maintenance_test_options_command_mode): ... here.
7382 (maintenance_test_options_command_completion_result): Delete.
7383 (maintenance_test_options_command_completion_text): Update
7384 comment.
7385 (maintenance_show_test_options_completion_result): Change
7386 prototype. Just print
7387 maintenance_test_options_command_completion_text.
7388 (save_completion_result): New.
7389 (maintenance_test_options_completer_mode): Pass options context to
7390 complete_options, and then save a dump.
7391 (_initialize_maint_test_options): Use add_cmd to install "maint
7392 show test-options-completion-result".
7393
fdbc9870
PA
73942019-07-03 Pedro Alves <palves@redhat.com>
7395
7396 * NEWS (New commands): Mention "with" and "maint with".
7397 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7398 (with_command, with_command_completer): New.
7399 (pipe_command): Adjust to new repeat_previous
7400 interface.
7401 (_initialize_cli_cmds): Install the "with" command and its "w"
7402 alias.
7403 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7404 declarations.
7405 * cli/cli-setshow.c (parse_cli_var_uinteger)
7406 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7407 argument strings for all var_types.
7408 (get_setshow_command_value_string): New, factored out from ...
7409 (do_show_command): ... this.
7410 * cli/cli-setshow.h: Include <string>.
7411 (get_setshow_command_value_string): Declare.
7412 * command.h (repeat_previous): Now returns const char *. Adjust
7413 comment.
7414 * maint.c: Include "cli/cli-cmds.h".
7415 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7416 (_initialize_maint_cmds): Register the "maintenance with" command.
7417 * top.c (repeat_previous): Move bits from pipe_command here:
7418 Return the saved command line, if any; error out if there's no
7419 command to relaunch.
7420
c6ac8931
PA
74212019-07-03 Pedro Alves <palves@redhat.com>
7422
7423 * NEWS (New commands): Mention "maint set/show test-settings"
7424 instead of "maint test-settings".
7425 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7426 (maintenance_test_settings_set_list): Rename to ...
7427 (maintenance_set_test_settings_list): ... this.
7428 (maintenance_test_settings_show_list): Rename to ...
7429 (maintenance_show_test_settings_list): ... this.
7430 (maintenance_test_settings_cmd): Delete.
7431 (maintenance_test_settings_set_cmd): ...
7432 (maintenance_set_test_settings_cmd): ... this.
7433 (maintenance_test_settings_show_cmd): ...
7434 (maintenance_show_test_settings_cmd): ... this.
7435 (maintenance_test_settings_show_value_cmd):
7436 (maintenance_show_test_settings_value_cmd): ... this.
7437 (_initialize_maint_test_settings): No longer install the "maint
7438 test-settings" prefix command. Rename "maint test-settings set"
7439 to "maint set test-settings", and "maint test-settings show" to
7440 "maint show test-settings". Adjust all subcommands.
7441
d1fcf2fd
PA
74422019-07-03 Pedro Alves <palves@redhat.com>
7443
7444 * maint-test-settings.c: Fix file's intro comment. Replace all
7445 references to "test-options" with references to "test-settings",
7446 in comments.
7447
970f9d09
PA
74482019-07-03 Pedro Alves <palves@redhat.com>
7449
7450 * maint-test-settings.c (maintenance_test_settings_xxx)
7451 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7452 New.
7453 (maintenance_test_settings_enums): Use them.
7454 (maintenance_test_settings_enum): Default to
7455 maintenance_test_settings_xxx.
7456 (_initialize_maint_test_settings): Initialize
7457 MAINTENANCE_TEST_SETTINGS_FILENAME.
7458
f3869b1a
SM
74592019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7460
7461 * breakpoint.h (remove_breakpoints_inf): Change return type to
7462 void, move function documentation here.
7463 * breakpoint.c (remove_breakpoints_inf): Change return type to
7464 void, move function documentation to header.
7465
54d66006
PA
74662019-07-02 Pedro Alves <palves@redhat.com>
7467
7468 * NEWS (Completion improvements): Mention "info threads".
7469 * thread.c (struct info_threads_opts, info_threads_option_defs)
7470 (make_info_threads_options_def_group): New.
7471 (info_threads_command): Use gdb::option::process_options.
7472 (info_threads_command_completer): New.
7473 (_initialize_thread): Use gdb::option::build_help to build the
7474 help text for "info threads".
7475
854f6088
SM
74762019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7477
7478 * defs.h (generic_load): Move from here...
7479 * symfile.h (generic_load): ... to here. Rename name parameter
7480 to args.
7481 * symfile.c (generic_load): Add comment.
7482
54ee4252
TT
74832019-07-01 Tom Tromey <tromey@adacore.com>
7484
7485 * dwarf2read.c
7486 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7487 declaration of without_params. Fix formatting.
7488
65392b3e
TT
74892019-07-01 Tom Tromey <tromey@adacore.com>
7490
7491 * ada-exp.y (find_primitive_type): Update.
7492 * ada-lang.h (ada_lookup_symbol): Update.
7493 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7494 parameter.
7495 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7496
7d7571f0
SDJ
74972019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7498
7499 PR breakpoints/24541
7500 * gdbarch.c: Regenerate.
7501 * gdbarch.h: Regenerate.
7502 * gdbarch.sh: Add 'stap_adjust_register'.
7503 * i386-tdep.c: Include '<unordered_set>'.
7504 (i386_stap_adjust_register): New function.
7505 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7506 * stap-probe.c (stap_parse_register_operand): Call
7507 'gdbarch_stap_adjust_register'.
7508
5af5392a
SDJ
75092019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7510
7511 PR python/24742
7512 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7513 * python/python.c (do_start_initialization): Use 'xmalloc'
7514 instead of 'PyMem_Malloc'.
7515
10d06d82
TT
75162019-06-28 Tom Tromey <tromey@adacore.com>
7517
7518 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7519 for Ada.
7520
1b7f24cd
TT
75212019-06-27 Tom Tromey <tromey@adacore.com>
7522
7523 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7524 objfile_key.
7525 (arm_find_mapping_symbol, arm_record_special_symbol)
7526 (_initialize_arm_tdep): Update.
7527 (arm_objfile_data_free): Remove.
7528
3d507ff2
TT
75292019-06-27 Tom Tromey <tromey@adacore.com>
7530
7531 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7532 to cp_print_static_field.
7533
762c164d
TT
75342019-06-26 Tom Tromey <tromey@adacore.com>
7535
7536 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7537 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7538 declare.
7539
aa2f9bcf
AH
75402019-06-26 Alan Hayward <alan.hayward@arm.com>
7541
7542 * features/aarch64-core.c (create_feature_aarch64_core):
7543 Regenerate.
7544 * features/aarch64-core.xml: Add cpsr flags.
7545
3426ae57
AH
75462019-06-26 Alan Hayward <alan.hayward@arm.com>
7547
7548 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7549 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7550
4838e44c
SM
75512019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7552
7553 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7554 field.
7555 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7556 use.
7557 (arm_record_special_symbol): Don't insert new symbol in sorted
7558 position, push it at the end.
7559
54cc7474
SM
75602019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7561
7562 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7563 (arm_mapping_symbol_s): Remove.
7564 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7565 (arm_mapping_symbol_vec): New typedef.
7566 (struct arm_per_objfile): Add constructor.
7567 <section_maps>: Change type to
7568 std::unique_ptr<arm_mapping_symbol_vec[]>.
7569 (arm_compare_mapping_symbols): Remove.
7570 (arm_find_mapping_symbol): Adjust to section_maps type change.
7571 (arm_objfile_data_free): Call delete on arm_per_objfile.
7572 (arm_record_special_symbol): Adjust to section_maps type change.
7573 Allocate arm_per_objfile with new.
7574
b65b566c
PW
75752019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7576
7577 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7578 with the command prefix.
7579
c2fc64f5
TT
75802019-06-25 Tom Tromey <tom@tromey.com>
7581
7582 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7583 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7584
fb54fa76
TT
75852019-06-25 Tom Tromey <tom@tromey.com>
7586
7587 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7588 type.
7589 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7590 protected.
7591
f7952c57
TT
75922019-06-25 Tom Tromey <tom@tromey.com>
7593
7594 * tui/tui-winsource.c
7595 (tui_source_window_base::set_is_exec_point_at): Add check against
7596 LOA_ADDRESS.
7597
17568d78
TT
75982019-06-25 Tom Tromey <tom@tromey.com>
7599
7600 * tui/tui-source.c (tui_set_source_content): Don't check before
7601 xfree.
7602 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7603
53e7cdba
TT
76042019-06-25 Tom Tromey <tom@tromey.com>
7605
7606 * tui/tui-winsource.h (tui_update_source_window_as_is)
7607 (tui_alloc_source_buffer, tui_line_is_displayed)
7608 (tui_addr_is_displayed): Change type of win_info.
7609 * tui/tui-winsource.c (tui_update_source_window_as_is)
7610 (tui_clear_source_content, tui_show_source_line)
7611 (tui_show_source_content, tui_source_window_base::refill)
7612 (tui_source_window_base::set_is_exec_point_at)
7613 (tui_source_window_base::set_is_exec_point_at)
7614 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7615 (tui_alloc_source_buffer, tui_line_is_displayed)
7616 (tui_addr_is_displayed): Change type of win_info. Update.
7617 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7618 (tui_source_window_base::do_make_visible_with_new_height):
7619 Update.
7620 * tui/tui-source.c (tui_set_source_content)
7621 (tui_set_source_content_nil)
7622 (tui_source_window::do_scroll_vertical): Update.
7623 * tui/tui-layout.c (show_layout): Update.
7624 * tui/tui-disasm.c (tui_set_disassem_content)
7625 (tui_disasm_window::do_scroll_vertical): Update.
7626 * tui/tui-data.h (tui_win_content): Remove.
7627 (struct tui_gen_win_info) <content, content_size>: Remove.
7628 (struct tui_source_element): Add initializers and destructor.
7629 (union tui_which_element, struct tui_win_element): Remove.
7630 (struct tui_source_window_base) <content>: New field.
7631 (struct tui_data_window): Remove destructor.
7632 (tui_alloc_content, tui_free_win_content)
7633 (tui_free_all_source_wins_content): Don't declare.
7634 * tui/tui-data.c (tui_initialize_static_data): Update.
7635 (init_content_element, tui_alloc_content): Remove.
7636 (~tui_gen_win_info): Update.
7637 (~tui_data_window, tui_free_all_source_wins_content)
7638 (tui_free_win_content, free_content, free_content_elements):
7639 Remove.
7640
7908abbf
TT
76412019-06-25 Tom Tromey <tom@tromey.com>
7642
7643 * tui/tui-winsource.h (tui_clear_source_content)
7644 (tui_erase_source_content, tui_show_source_content): Change type
7645 of win_info.
7646 * tui/tui-winsource.c (tui_clear_source_content)
7647 (tui_erase_source_content, tui_show_source_content): Change type
7648 of win_info.
7649 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7650 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7651 win_info.
7652 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7653 win_info.
7654 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7655
02c28df0
TT
76562019-06-25 Tom Tromey <tom@tromey.com>
7657
7658 * tui/tui-winsource.c (tui_clear_source_content)
7659 (tui_source_window_base::set_is_exec_point_at): Update.
7660 * tui/tui-source.c (tui_set_source_content_nil): Update.
7661 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7662 a bool.
7663 * tui/tui-data.c (init_content_element): Update.
7664
6658b1bf
TT
76652019-06-25 Tom Tromey <tom@tromey.com>
7666
7667 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7668 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7669 * tui/tui-layout.c (init_and_make_win): Update.
7670 * tui/tui.h (enum tui_win_type): Update.
7671 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7672 tui_win_is_auxillary.
7673 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7674 tui_win_is_auxillary.
7675
21e1c91e
TT
76762019-06-25 Tom Tromey <tom@tromey.com>
7677
7678 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7679 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7680 (tui_delete_data_content_windows, tui_display_all_data)
7681 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7682 Update.
7683 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7684 * tui/tui-regs.c (tui_last_regs_line_no)
7685 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7686 (tui_show_registers): Update.
7687 (tui_show_register_group): Return void. Update.
7688 (tui_display_registers_from, tui_display_reg_element_at_line)
7689 (tui_display_registers_from_line, tui_check_register_values):
7690 Update.
7691 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7692 member.
7693 (struct tui_data_window) <regs_content>: Now a std::vector.
7694 <regs_content_count>: Remove.
7695 (tui_add_content_elements, tui_free_data_content): Don't declare.
7696 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7697 (init_content_element): Remove DATA_WIN case. Add assert.
7698 (tui_add_content_elements): Remove.
7699 (tui_data_window): Update.
7700 (tui_free_data_content): Remove.
7701 (free_content_elements): Remove DATA_WIN case.
7702
115ac53b
TT
77032019-06-25 Tom Tromey <tom@tromey.com>
7704
7705 * tui/tui-data.c (tui_data_item_window): Update.
7706 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7707 * tui/tui-windata.c (tui_display_all_data)
7708 (tui_display_data_from_line): Update.
7709 (tui_check_data_values): Remove.
7710 * tui/tui-regs.c (tui_show_register_group)
7711 (tui_display_reg_element_at_line): Update.
7712 * tui/tui-hooks.c (tui_register_changed)
7713 (tui_refresh_frame_and_register_information): Call
7714 tui_check_register_values.
7715 * tui/tui-data.h (struct tui_data_window) <data_content,
7716 data_content_count, data_type>: Remove.
7717 (enum tui_data_type): Remove.
7718
7719 * tui/tui-data.c (tui_data_window::clear_detail)
7720 (~tui_data_window): Update.
7721
eaf9738b
TT
77222019-06-25 Tom Tromey <tom@tromey.com>
7723
7724 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7725 declare.
7726 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7727 Rename from tui_first_data_item_displayed. Update.
7728 (tui_data_window::refresh_all)
7729 (tui_data_window::do_scroll_vertical): Update.
7730 * tui/tui-data.h (struct tui_data_window)
7731 <first_data_item_displayed>: Declare new method.
7732
31ca4723
TT
77332019-06-25 Tom Tromey <tom@tromey.com>
7734
7735 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7736 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7737 contents...
7738 (tui_initialize_static_data): ...here.
7739
41bcff7f
TT
77402019-06-25 Tom Tromey <tom@tromey.com>
7741
7742 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7743 (tui_display_registers_from, tui_check_register_values): Update.
7744 (tui_display_register): Remove win_info parameter; update.
7745 (tui_get_register): Change type of parameters.
7746 * tui/tui-data.h (struct tui_data_element): Remove.
7747 (union tui_which_element) <data>: Remove.
7748 <data_window>: Change type.
7749 (struct tui_data_item_window): New.
7750 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7751 case. Add assert.
7752 (~tui_data_item_window): New destructor.
7753 (free_content_elements): Remove DATA_ITEM_WIN case.
7754
d2802c33
TT
77552019-06-25 Tom Tromey <tom@tromey.com>
7756
7757 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7758 Remove.
7759
dd835f8b
TT
77602019-06-25 Tom Tromey <tom@tromey.com>
7761
7762 * tui/tui-data.h (struct tui_command_element): Remove.
7763 (union tui_which_element) <command>: Remove.
7764 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7765 assert.
7766 (free_content_elements): Remove CMD_WIN case.
7767
bd7db367
TT
77682019-06-25 Tom Tromey <tom@tromey.com>
7769
7770 * tui/tui-layout.c (tui_set_layout): Update.
7771 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7772 * tui/tui-data.c (layout_def): Update.
7773
3add462f
TT
77742019-06-25 Tom Tromey <tom@tromey.com>
7775
7776 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7777 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7778 (tui_source_window_base::set_new_height): Update.
7779 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7780 Update.
7781 (tui_set_locator_fullname, tui_set_locator_info)
7782 (tui_show_frame_info): Update.
7783 * tui/tui-source.c (tui_set_source_content)
7784 (tui_source_is_displayed): Update.
7785 * tui/tui-layout.c (show_source_disasm_command, show_data)
7786 (show_source_or_disasm_and_command): Update.
7787 * tui/tui-disasm.c (tui_set_disassem_content)
7788 (tui_get_begin_asm_address): Update.
7789 * tui/tui-data.h (struct tui_locator_element): Remove.
7790 (union tui_which_element) <locator>: Remove.
7791 (struct tui_locator_window): New.
7792 (tui_locator_win_info_ptr): Change return type.
7793 * tui/tui-data.c (_locator): Change type.
7794 (tui_locator_win_info_ptr): Change return type.
7795 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7796 (tui_alloc_content): Add assert.
7797
489e9d8b
TT
77982019-06-25 Tom Tromey <tom@tromey.com>
7799
7800 * tui/tui-winsource.c
7801 (tui_exec_info_window::maybe_allocate_content): New method.
7802 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7803 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7804 (make_source_or_disasm_window): Add cast.
7805 * tui/tui-data.h (union tui_which_element) <simple_string>:
7806 Remove.
7807 (struct tui_source_info): New.
7808 (struct tui_source_window_base) <execution_info>: Change type.
7809 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7810 case, and add assert.
7811 (tui_alloc_content): Add assert.
7812
c3fabb7d
TT
78132019-06-25 Tom Tromey <tom@tromey.com>
7814
7815 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7816 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7817 * tui/tui-data.c (tui_alloc_win_info): Remove.
7818
bbc228ee
TT
78192019-06-25 Tom Tromey <tom@tromey.com>
7820
7821 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7822 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7823 can_highlight.
7824
5fcee43a
TT
78252019-06-25 Tom Tromey <tom@tromey.com>
7826
7827 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7828 make_visible_with_new_height method.
7829 (tui_win_info::make_visible_with_new_height): New method.
7830 (tui_source_window_base::do_make_visible_with_new_height)
7831 (tui_data_window::do_make_visible_with_new_height)
7832 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7833 (make_visible_with_new_height): Remove.
7834 (tui_resize_all, tui_adjust_win_heights): Use
7835 make_visible_with_new_height method.
7836 * tui/tui-data.h (struct tui_win_info)
7837 <do_make_visible_with_new_height, make_visible_with_new_height>:
7838 New methods.
7839 (struct tui_source_window_base, struct tui_data_window)
7840 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7841 methods.
7842
d83f1fe6
TT
78432019-06-25 Tom Tromey <tom@tromey.com>
7844
7845 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7846 method.
7847 (update_tab_width): Call update_tab_width method.
7848 * tui/tui-data.h (struct tui_win_info)
7849 (struct tui_source_window_base) <update_tab_width>: New methods.
7850
17374de4
TT
78512019-06-25 Tom Tromey <tom@tromey.com>
7852
7853 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7854 parameter.
7855 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7856 parameter.
7857 (tui_gen_win_info::make_visible): Update.
7858 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7859 parameter.
7860 * tui/tui-data.h (enum tui_box): New enum.
7861 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7862
f936bca2
TT
78632019-06-25 Tom Tromey <tom@tromey.com>
7864
7865 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7866 init_and_make_win for EXEC_INFO_WIN.
7867 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7868 longer inline.
7869 (struct tui_win_info) <~tui_win_info>: Inline.
7870 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7871 Don't declare.
7872 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7873 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7874 Remove.
7875 (tui_initialize_static_data): Update.
7876 (~tui_gen_win_info): Handle more cleanup here.
7877 (~tui_source_window_base): Delete "execution_info".
7878 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7879
d6ba6a11
TT
78802019-06-25 Tom Tromey <tom@tromey.com>
7881
7882 * tui/tui-layout.c (make_command_window): Don't set
7883 can_highlight.
7884 (show_source_disasm_command): Call the reset method.
7885 (show_data): Don't set can_highlight. Call the reset method.
7886 (tui_gen_win_info::reset): Rename from init_gen_win_info
7887 (init_and_make_win): Simplify. Return tui_gen_win_info.
7888 (show_source_or_disasm_and_command): Call the reset method.
7889 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7890 (struct tui_cmd_window): Set can_highlight.
7891
48a3bd16
TT
78922019-06-25 Tom Tromey <tom@tromey.com>
7893
7894 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7895 from make_visible.
7896 (tui_make_visible, tui_make_invisible): Rewrite.
7897 (tui_win_info::make_visible): Remove.
7898 (tui_source_window_base::make_visible): Update.
7899 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7900 method. Moved from...
7901 (struct tui_win_info) <make_visible>: ...here.
7902
c3bd716f
TT
79032019-06-25 Tom Tromey <tom@tromey.com>
7904
7905 * tui/tui-winsource.c
7906 (tui_source_window_base::do_scroll_horizontal): Remove direction
7907 parameter.
7908 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7909 direction parameter.
7910 * tui/tui-win.c (tui_win_info::forward_scroll)
7911 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7912 (tui_win_info::right_scroll): Update.
7913 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7914 direction parameter.
7915 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7916 direction parameter.
7917 * tui/tui-data.h (enum tui_scroll_direction): Remove.
7918 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7919 Remove direction parameter.
7920 (struct tui_source_window_base, struct tui_source_window)
7921 (struct tui_disasm_window, struct tui_data_window)
7922 (struct tui_cmd_window): Update.
7923
21c32dca
TT
79242019-06-25 Tom Tromey <tom@tromey.com>
7925
7926 * tui/tui-winsource.h (tui_set_exec_info_content)
7927 (tui_show_exec_info_content, tui_erase_exec_info_content)
7928 (tui_clear_exec_info_content, tui_update_exec_info): Change
7929 argument to tui_source_window_base.
7930 * tui/tui-winsource.c (tui_set_exec_info_content)
7931 (tui_show_exec_info_content, tui_erase_exec_info_content)
7932 (tui_clear_exec_info_content, tui_update_exec_info): Change
7933 argument to tui_source_window_base.
7934
73fbdc65
TT
79352019-06-25 Tom Tromey <tom@tromey.com>
7936
7937 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7938 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7939
33325343
TT
79402019-06-25 Tom Tromey <tom@tromey.com>
7941
7942 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7943 check.
7944
29d2c474
TT
79452019-06-25 Tom Tromey <tom@tromey.com>
7946
7947 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7948 type to void.
7949 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7950 type to void.
7951 * tui/tui-source.c (tui_set_source_content): Update.
7952 * tui/tui-disasm.c (tui_set_disassem_content): Update.
7953
152f3f4b
TT
79542019-06-25 Tom Tromey <tom@tromey.com>
7955
7956 * tui/tui-win.c (window_name_completer, tui_set_focus)
7957 (tui_all_windows_info): Use name method.
7958 * tui/tui-data.h (struct tui_gen_win_info)
7959 (struct tui_source_window, struct tui_disasm_window)
7960 (struct tui_data_window, struct tui_cmd_window) <name>: New
7961 method.
7962 (tui_win_name): Don't declare.
7963 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7964 (tui_win_name): Remove.
7965
be4da588
TT
79662019-06-25 Tom Tromey <tom@tromey.com>
7967
7968 * tui/tui-winsource.h (tui_update_source_window)
7969 (tui_update_source_window_as_is): Change parameter type.
7970 * tui/tui-winsource.c (tui_update_source_window): Change win_info
7971 to be a tui_source_window_base.
7972 (tui_update_source_window_as_is): Likewise.
7973 * tui/tui-win.c (make_visible_with_new_height): Update.
7974
5b81daba
TT
79752019-06-25 Tom Tromey <tom@tromey.com>
7976
7977 * tui/tui-winsource.c (tui_erase_source_content)
7978 (tui_show_source_content, tui_show_exec_info_content)
7979 (tui_erase_exec_info_content): Use refresh_window method.
7980 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7981 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7982 from tui_refresh_win.
7983 (tui_data_window::refresh_window): New method.
7984 (tui_win_info::refresh, tui_source_window_base::refresh)
7985 (tui_refresh_all): Use refresh_window method.
7986 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7987 method.
7988 * tui/tui-regs.c (tui_display_register): Call refresh_window
7989 method.
7990 * tui/tui-layout.c (show_source_disasm_command)
7991 (show_source_or_disasm_and_command): Call refresh_window method.
7992 * tui/tui-data.h (struct tui_gen_win_info)
7993 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7994 New method.
7995
cb2ce893
TT
79962019-06-25 Tom Tromey <tom@tromey.com>
7997
7998 * tui/tui.c (tui_rl_other_window, tui_enable)
7999 (tui_is_window_visible, tui_get_command_dimension): Update.
8000 * tui/tui-winsource.c (tui_update_source_window_as_is)
8001 (tui_clear_source_content, tui_erase_source_content)
8002 (tui_show_source_line, tui_source_window_base::refill)
8003 (tui_source_window_base::do_scroll_horizontal)
8004 (tui_source_window_base::set_is_exec_point_at)
8005 (tui_update_breakpoint_info, tui_set_exec_info_content)
8006 (tui_alloc_source_buffer, tui_line_is_displayed)
8007 (tui_addr_is_displayed): Update.
8008 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8009 (tui_check_and_display_highlight_if_needed)
8010 (tui_win_info::make_visible, tui_win_info::refresh)
8011 (tui_refresh_all): Update.
8012 * tui/tui-windata.c (tui_first_data_item_displayed)
8013 (tui_delete_data_content_windows, tui_erase_data_content)
8014 (tui_display_all_data, tui_data_window::refresh_all)
8015 (tui_check_data_values): Update.
8016 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8017 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8018 (tui_win_info::backward_scroll, tui_refresh_all_win)
8019 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8020 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8021 (tui_source_window_base::set_new_height)
8022 (tui_data_window::set_new_height)
8023 (make_invisible_and_set_new_height)
8024 (make_visible_with_new_height, new_height_ok)
8025 (parse_scrolling_args): Update.
8026 * tui/tui-stack.c (tui_show_frame_info): Update.
8027 * tui/tui-source.c (tui_set_source_content)
8028 (tui_set_source_content_nil, tui_source_is_displayed)
8029 (tui_source_window::do_scroll_vertical): Update.
8030 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8031 (tui_display_registers_from, tui_display_reg_element_at_line)
8032 (tui_check_register_values, tui_reg_command): Update.
8033 * tui/tui-layout.c (tui_default_win_height)
8034 (show_source_disasm_command, show_data, init_and_make_win)
8035 (show_source_or_disasm_and_command): Update.
8036 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8037 (tui_redisplay_readline, tui_mld_flush)
8038 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8039 (tui_getc): Update.
8040 * tui/tui-disasm.c (tui_set_disassem_content)
8041 (tui_disasm_window::do_scroll_vertical): Update.
8042 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8043 Now virtual.
8044 (struct tui_win_info): Derive from tui_gen_win_info.
8045 <~tui_win_info>: Mark as override.
8046 <generic>: Remove member.
8047 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8048 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8049 (~tui_data_window, ~tui_win_info)
8050 (tui_free_all_source_wins_content): Update.
8051 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8052
ab313b35
TT
80532019-06-25 Tom Tromey <tom@tromey.com>
8054
8055 * tui/tui-layout.c (init_and_make_win): Use new.
8056 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8057 destructor, initializers.
8058 (tui_alloc_generic_win_info): Don't declare.
8059 * tui/tui-data.c (_locator): Add argument to constructor.
8060 (source_win, disasm_win): New globals.
8061 (exec_info): Remove.
8062 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8063 Update.
8064 (tui_alloc_generic_win_info): Remove.
8065 (init_content_element): Use new.
8066 (tui_win_info::tui_win_info): Update.
8067 (free_content_elements) <case DATA_WIN>: Use delete.
8068
dc2c33e4
TT
80692019-06-25 Tom Tromey <tom@tromey.com>
8070
8071 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8072 * tui/tui-windata.c (tui_first_data_item_displayed)
8073 (tui_delete_data_content_windows): Update.
8074 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8075 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8076 (tui_display_registers_from, tui_check_register_values): Update.
8077 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8078 pointer.
8079 * tui/tui-data.c (init_content_element): Update. Allocate the new
8080 window.
8081 (tui_free_data_content): Update.
8082 (free_content_elements) <case DATA_WIN>: Free the window.
8083
214a5cbe
TT
80842019-06-25 Tom Tromey <tom@tromey.com>
8085
8086 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8087 Update.
8088 * tui/tui-layout.c (make_command_window)
8089 (show_source_disasm_command, show_data, init_and_make_win)
8090 (show_source_or_disasm_and_command): Update.
8091 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8092 method.
8093 <can_highight, is_highlighted>: Now bool.
8094 (tui_set_win_highlight): Don't declare.
8095 * tui/tui-data.c (tui_set_win_highlight): Remove.
8096
8e2daf15
TT
80972019-06-25 Tom Tromey <tom@tromey.com>
8098
8099 * tui/tui-wingeneral.c (make_visible): Remove check of window
8100 type.
8101
8903bd8a
TT
81022019-06-25 Tom Tromey <tom@tromey.com>
8103
8104 * tui/tui-win.c (tui_win_info::max_height)
8105 (tui_cmd_window::max_height): New methods.
8106 (new_height_ok): Call max_height.
8107 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8108 <max_height>: New method.
8109
3f02ce1e
TT
81102019-06-25 Tom Tromey <tom@tromey.com>
8111
8112 * tui/tui-win.c (tui_source_window_base::set_new_height)
8113 (tui_data_window::set_new_height): New methods.
8114 (make_invisible_and_set_new_height): Call set_new_height method.
8115 * tui/tui-data.h (struct tui_win_info)
8116 (struct tui_source_window_base, struct tui_data_window)
8117 <set_new_height>: New method.
8118
1825f487
TT
81192019-06-25 Tom Tromey <tom@tromey.com>
8120
8121 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8122 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8123 tui_refresh_data_win.
8124 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8125 method.
8126 (tui_refresh_all_win): Call the refresh_all method.
8127 (tui_set_focus): Likewise.
8128 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8129 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8130 Likewise.
8131
ad54d15b
TT
81322019-06-25 Tom Tromey <tom@tromey.com>
8133
8134 * tui/tui-winsource.h (tui_refill_source_window)
8135 (tui_set_is_exec_point_at): Don't declare.
8136 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8137 (tui_source_window_base::refill): Rename from
8138 tui_refill_source_window.
8139 (tui_source_window_base::do_scroll_horizontal): Update.
8140 (tui_source_window_base::set_is_exec_point_at): Rename from
8141 tui_set_is_exec_point_at.
8142 (tui_update_all_breakpoint_info): Update.
8143 * tui/tui-stack.c (tui_show_frame_info): Update.
8144 * tui/tui-layout.c (show_data): Add cast.
8145 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8146 * tui/tui-data.h (struct tui_source_window_base) <refill,
8147 set_is_exec_point_at>: New methods.
8148 (tui_source_windows, tui_add_to_source_windows): Update types.
8149 (tui_add_to_source_windows): Remove redundant declaration.
8150 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8151 (tui_source_windows): Change return type.
8152 (tui_clear_source_windows_detail): Update.
8153 (tui_add_to_source_windows): Change type of parameter.
8154 (tui_free_all_source_wins_content): Update.
8155
2042b506
TT
81562019-06-25 Tom Tromey <tom@tromey.com>
8157
8158 * tui/tui-wingeneral.c (tui_win_info::refresh)
8159 (tui_source_window_base::refresh): New methods.
8160 (tui_refresh_all): Call the refresh method.
8161 * tui/tui-data.h (struct tui_win_info)
8162 (struct tui_source_window_base) <refresh>: New method.
8163
56122977
TT
81642019-06-25 Tom Tromey <tom@tromey.com>
8165
8166 * tui/tui.h (tui_is_window_visible): Return bool.
8167 * tui/tui.c (tui_is_window_visible): Return bool.
8168 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8169 (tui_make_visible, tui_make_invisible)
8170 (tui_win_info::make_visible)
8171 (tui_source_window_base::make_visible, make_all_visible)
8172 (tui_make_all_visible, tui_make_all_invisible): Update.
8173 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8174 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8175 bool.
8176 (struct tui_win_info, struct tui_source_window_base)
8177 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8178 * tui/tui-data.c (tui_init_generic_part): Update.
8179
cda37efb
TT
81802019-06-25 Tom Tromey <tom@tromey.com>
8181
8182 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8183 (tui_source_window_base::make_visible): New methods.
8184 (make_all_visible): Make method call.
8185 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8186 (struct tui_source_window_base, struct tui_cmd_window): Override
8187 make_visible.
8188 (tui_win_is_source_type): Don't declare.
8189 * tui/tui-data.c (tui_win_is_source_type): Remove.
8190
6a0ee02c
TT
81912019-06-25 Tom Tromey <tom@tromey.com>
8192
8193 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8194 NULL check.
8195
63901aec
TT
81962019-06-25 Tom Tromey <tom@tromey.com>
8197
8198 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8199 Inline constructor. Add initializers for members.
8200 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8201 constructors; now inline in class.
8202
ceb13a13
TT
82032019-06-25 Tom Tromey <tom@tromey.com>
8204
8205 * tui/tui-regs.c (tui_show_registers): Update.
8206 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8207 bool.
8208 * tui/tui-data.c (tui_data_window::clear_detail)
8209 (tui_data_window): Update.
8210
238eb706
TT
82112019-06-25 Tom Tromey <tom@tromey.com>
8212
8213 * tui/tui-windata.c (tui_display_all_data)
8214 (tui_display_data_from_line, tui_display_data_from)
8215 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8216 Update.
8217 * tui/tui-regs.c (tui_last_regs_line_no)
8218 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8219 (tui_show_registers, tui_show_register_group)
8220 (tui_display_registers_from, tui_display_reg_element_at_line)
8221 (tui_display_registers_from_line, tui_check_register_values)
8222 (tui_reg_next, tui_reg_prev): Update.
8223 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8224 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8225 tui_data_window.
8226 (struct tui_win_info) <detail>: Remove. Add new fields from
8227 tui_data_info.
8228 (TUI_DATA_WIN): Add cast.
8229 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8230 (~tui_data_window): Simplify.
8231
81491aa0
TT
82322019-06-25 Tom Tromey <tom@tromey.com>
8233
8234 * tui/tui-layout.c (show_source_disasm_command)
8235 (show_source_or_disasm_and_command): Update.
8236 * tui/tui-io.c (update_cmdwin_start_line)
8237 (tui_redisplay_readline): Update.
8238 * tui/tui-data.h (struct tui_command_info): Remove.
8239 (struct tui_win_info) <detail>: Remove command_info member.
8240 (struct tui_data_window) <start_line>: New member, from
8241 tui_command_info.
8242 (TUI_CMD_WIN): Add casts.
8243
e6e41501
TT
82442019-06-25 Tom Tromey <tom@tromey.com>
8245
8246 * tui/tui-winsource.c (tui_update_source_window)
8247 (tui_refill_source_window)
8248 (tui_source_window_base::do_scroll_horizontal)
8249 (tui_update_breakpoint_info, tui_set_exec_info_content)
8250 (tui_show_exec_info_content, tui_erase_exec_info_content)
8251 (tui_clear_exec_info_content): Update.
8252 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8253 Update.
8254 * tui/tui-win.c (make_invisible_and_set_new_height)
8255 (make_visible_with_new_height): Update.
8256 * tui/tui-source.c (tui_set_source_content)
8257 (tui_show_symtab_source): Update.
8258 * tui/tui-layout.c (extract_display_start_addr)
8259 (show_source_disasm_command, show_data)
8260 (make_source_or_disasm_window)
8261 (show_source_or_disasm_and_command): Update.
8262 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8263 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8264 "gdbarch".
8265 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8266 to tui_source_window_base.
8267 (struct tui_win_info) <detail>: Remove source_info member.
8268 (struct tui_source_window_base) <has_locator>: Inline.
8269 Move contents from tui_source_info; rename has_locator member to
8270 m_has_locator.
8271 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8272 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8273 header file.
8274 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8275 Simplify.
8276 (tui_free_all_source_wins_content): Cast to
8277 tui_source_window_base.
8278
44f0e208
TT
82792019-06-25 Tom Tromey <tom@tromey.com>
8280
8281 * tui/tui-win.c (make_invisible_and_set_new_height)
8282 (make_visible_with_new_height): Call has_locator method.
8283 * tui/tui-layout.c (show_source_disasm_command, show_data)
8284 (show_source_or_disasm_and_command): Update for bool change.
8285 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8286 (tui_win_info) <has_locator>: New method.
8287 (struct tui_source_window_base) <has_locator>: New method.
8288 (tui_win_has_locator): Don't declare.
8289 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8290 from tui_win_has_locator.
8291 (tui_source_window_base): Use false, not FALSE.
8292
7778b912
TT
82932019-06-25 Tom Tromey <tom@tromey.com>
8294
8295 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8296 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8297 clear_detail method directly.
8298 (tui_clear_win_detail): Remove.
8299
f83d391c
TT
83002019-06-25 Tom Tromey <tom@tromey.com>
8301
8302 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8303 "this", not TUI_DISASM_WIN.
8304
13446e05
TT
83052019-06-25 Tom Tromey <tom@tromey.com>
8306
8307 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8308 declare.
8309 * tui/tui-winsource.c
8310 (tui_source_window_base::do_scroll_horizontal): Rename from
8311 tui_horizontal_source_scroll.
8312 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8313 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8314 from tui_vertical_data_scroll.
8315 * tui/tui-win.h (tui_scroll): Don't declare.
8316 * tui/tui-win.c (tui_win_info::forward_scroll)
8317 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8318 (tui_win_info::right_scroll): Rename and update.
8319 (tui_scroll_forward_command, tui_scroll_backward_command)
8320 (tui_scroll_left_command, tui_scroll_right_command): Update.
8321 (tui_scroll): Remove.
8322 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8323 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8324 from tui_vertical_source_scroll.
8325 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8326 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8327 from tui_vertical_disassem_scroll.
8328 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8329 do_scroll_horizontal>: New methods.
8330 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8331 Likewise.
8332 (struct tui_source_window_base): Add do_scroll_horizontal.
8333 (struct tui_source_window, struct tui_disasm_window): Add
8334 do_scroll_vertical.
8335 (struct tui_data_window, struct tui_cmd_window): Add
8336 do_scroll_horizontal and do_scroll_vertical.
8337 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8338
5cf82909
TT
83392019-06-25 Tom Tromey <tom@tromey.com>
8340
8341 * tui/tui-data.h (struct tui_source_window_base): New struct.
8342 (struct tui_source_window): Derive from tui_source_window_base.
8343 (struct tui_disasm_window): New struct.
8344 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8345 from tui_source_window::clear_detail.
8346 (tui_source_window_base): Rename from tui_source_window.
8347 (~tui_source_window_base): Rename from ~tui_source_window.
8348 (tui_alloc_win_info): Create a tui_disasm_window.
8349
ee1d42d6
TT
83502019-06-25 Tom Tromey <tom@tromey.com>
8351
8352 * tui/tui-data.h (struct tui_source_window)
8353 (struct tui_data_window): Declare destructors.
8354 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8355 destructors.
8356 (tui_win_info): Simplify.
8357
b4eb2452
TT
83582019-06-25 Tom Tromey <tom@tromey.com>
8359
8360 * tui/tui-winsource.c (tui_display_main)
8361 (tui_update_source_windows_with_addr)
8362 (tui_update_all_breakpoint_info): Update.
8363 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8364 (new_height_ok, parse_scrolling_args): Update.
8365 * tui/tui-stack.c (tui_show_frame_info): Update.
8366 * tui/tui-data.h (struct tui_list): Remove.
8367 (tui_source_windows): Return a reference to a std::vector.
8368 * tui/tui-data.c (source_windows): Now a std::vector.
8369 (tui_source_windows): Change return type.
8370 (tui_clear_source_windows): Rewrite.
8371 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8372 (tui_free_all_source_wins_content): Rewrite.
8373
8761a91b
TT
83742019-06-25 Tom Tromey <tom@tromey.com>
8375
8376 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8377 (struct tui_data_window, struct tui_cmd_window): Declare
8378 clear_detail method.
8379 * tui/tui-data.c (tui_source_window::clear_detail)
8380 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8381 methods.
8382 (tui_clear_win_detail): Simplify.
8383
0ed69eda
TT
83842019-06-25 Tom Tromey <tom@tromey.com>
8385
8386 * tui/tui-layout.c (make_source_window, make_disasm_window)
8387 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8388 Return the new window.
8389 (show_source_disasm_command, show_data)
8390 (show_source_or_disasm_and_command): Update.
8391
82432e10
TT
83922019-06-25 Tom Tromey <tom@tromey.com>
8393
8394 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8395 parameter. Return the new window.
8396 (show_source_disasm_command): Update and remove NULL check.
8397 (show_source_or_disasm_and_command): Update.
8398
ec328aa5
TT
83992019-06-25 Tom Tromey <tom@tromey.com>
8400
8401 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8402
33b906ab
TT
84032019-06-25 Tom Tromey <tom@tromey.com>
8404
8405 * tui/tui-data.h (struct tui_win_info): Make constructor
8406 protected. Make destructor virtual. Add initializers.
8407 (tui_source_window, tui_data_window, tui_cmd_window): New
8408 classes.
8409 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8410 constructor. Add "type" parameter.
8411 (tui_source_window, tui_data_window, tui_cmd_window): New
8412 constructors.
8413 (tui_alloc_win_info): Instantiate the appropriate subclass.
8414
e7e11af4
TT
84152019-06-25 Tom Tromey <tom@tromey.com>
8416
8417 * tui/tui-win.c (tui_resize_all): Use delete.
8418 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8419 destructor.
8420 (tui_free_window): Don't declare.
8421 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8422 Update.
8423
6792b55e
TT
84242019-06-25 Tom Tromey <tom@tromey.com>
8425
8426 * tui/tui-data.h (struct tui_win_info): Add constructor.
8427 * tui/tui-data.c (tui_alloc_win_info): Use new.
8428 (tui_free_window): Use delete.
8429
f95675e1
TT
84302019-06-22 Tom Tromey <tom@tromey.com>
8431
8432 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8433 declare.
8434 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8435
5bff081c
TT
84362019-06-22 Tom Tromey <tom@tromey.com>
8437
8438 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8439 declare.
8440 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8441
47e3f474
TV
84422019-06-22 Tom de Vries <tdevries@suse.de>
8443
8444 * dwarf2read.c (create_addrmap_from_aranges)
8445 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8446 instead of '%zu'.
8447
fd5866f6
SM
84482019-06-21 Simon Marchi <simon.marchi@efficios.com>
8449
8450 * dwarf2read.h (dwarf2_section_info_def): Remove.
8451 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8452 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8453 std::vector<dwarf2_section_info>.
8454 (struct dwo_file) <~dwo_file>: Remove.
8455 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8456 types field.
8457 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8458 (dwarf2_read_debug_names): Likewise.
8459 (create_debug_types_hash_table): Change parameter type to
8460 array_view, adjust code accordingly.
8461 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8462 (partial_die_info::fixup): Likewise.
8463 (determine_prefix): Likewise.
8464 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8465
fb1eb2f9
SM
84662019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8467
8468 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8469 gdb_bfd_ref_ptr.
8470 <~dwo_file>: Remove call to gdb_bfd_unref.
8471 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8472 gdb_bfd_ref_ptr::get.
8473
51ac9db5
SM
84742019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8475
8476 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8477 type to htab_up.
8478 * dwarf2read.c (struct dwo_file): Initialize fields.
8479 <~dwo_file>: New.
8480 (free_dwo_file): Remove, move content to ~dwo_file.
8481 (struct dwo_file_deleter): Remove.
8482 (dwo_file_up>: Remove custom deleter.
8483 (free_dwo_files): Remove.
8484 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8485 dwo_files.
8486 (process_skeletonless_type_units): Call unique_ptr::get.
8487 (allocate_dwo_file_hash_table): Add deleter to created hash
8488 table. Change return type to htab_up.
8489 (lookup_dwo_file_slot): Don't memset dwo_file, call
8490 unique_ptr::get.
8491 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8492 (create_dwo_unit_in_dwp_v2): Likewise.
8493 (open_and_init_dwo_file): Likewise.
8494 (free_dwo_file_from_slot): Remove.
8495
dc4ccb6f
SM
84962019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8497
8498 * dwarf2read.h (struct dwarf2_section_info) <readin,
8499 is_virtual>: Change type to bool.
8500 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8501 true instead of 1.
8502
e6a1c5cb
TT
85032019-06-19 Tom Tromey <tom@tromey.com>
8504
8505 * tui/tui-data.h (tui_init_content_element): Don't declare.
8506
6f6ffbeb
TT
85072019-06-19 Tom Tromey <tom@tromey.com>
8508
8509 * tui/tui-data.h (tui_init_win_info): Don't declare.
8510
f23f598e
TV
85112019-06-19 Tom de Vries <tdevries@suse.de>
8512
8513 * dwarf2read.h (abstract_to_concrete): Change type to
8514 std::unordered_map<sect_offset, std::vector<sect_offset>,
8515 gdb::hash_enum<sect_offset>>.
8516
680e1bee
TT
85172019-06-19 Tom Tromey <tromey@adacore.com>
8518
8519 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8520 EVAL_AVOID_SIDE_EFFECTS specially.
8521
dcf37923
TT
85222019-06-19 Tom Tromey <tromey@adacore.com>
8523
8524 * source-cache.c (highlighter): New global.
8525 (source_cache::get_source_lines): Create a highlighter on demand.
8526
494986d5
AB
85272019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8528
8529 * defs.h (deprecated_interactive_hook): Delete declaration.
8530 * interps.c (clear_interpreter_hooks): Remove use of
8531 deprecated_interactive_hook.
8532 * top.c (deprecated_interactive_hook): Delete definition.
8533 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8534
3360b6e7
TV
85352019-06-18 Tom de Vries <tdevries@suse.de>
8536
8537 PR gdb/24515
8538 * dwarf2read.h (abstract_to_concrete): Change type from
8539 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8540 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8541 * dwarf2read.c (read_variable): Update.
8542 (dwarf2_fetch_die_loc_sect_off): Update.
8543
310b3441
TV
85442019-06-17 Tom de Vries <tdevries@suse.de>
8545
8546 PR gdb/24617
8547 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8548 accessing parent[parent_len - 1].
8549
ba9777be
PP
85502019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8551
8552 PR gdb/24364
8553 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8554 call dtrace_process_dof with NULL dof.
8555
2b9f6e89
TV
85562019-06-16 Tom de Vries <tdevries@suse.de>
8557
8558 PR gdb/24445
8559 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8560
431b3ead
TT
85612019-06-16 Tom Tromey <tom@tromey.com>
8562
8563 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8564 (make_all_visible): Use address of member.
8565
d04b44a1
TT
85662019-06-16 Tom Tromey <tom@tromey.com>
8567
8568 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8569 (tui_free_window, free_content, free_content_elements): Remove
8570 unnecessary cast.
8571 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8572 cast.
8573 * tui/tui-regs.c (tui_show_register_group)
8574 (tui_display_registers_from, tui_display_reg_element_at_line):
8575 Remove unnecessary cast.
8576
bf5142e7
AB
85772019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8578
8579 * linux-nat.c (normal_mask): Delete.
8580 (_initialize_linux_nat): Don't initialise normal_mask.
8581
c4973306
SM
85822019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8583
8584 PR gdb/24445
8585 * dwarf-index-write.h (write_psymtabs_to_index): Add
8586 dwz_basename parameter.
8587 * dwarf-index-write.c (write_gdbindex): Move file writing to
8588 write_gdbindex_1. Change return type void.
8589 (assert_file_size): Move up, remove filename parameter.
8590 (write_gdbindex_1): New function.
8591 (write_debug_names): Change return type to void, call
8592 assert_file_size.
8593 (struct index_wip_file): New struct.
8594 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8595 file logic to index_wip_file. Write index for dwz file if
8596 needed.
8597 (save_gdb_index_command): Pass basename of dwz file, if present.
8598 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8599 build-id of dwz file, if present.
8600 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8601 (dwarf2_get_dwz_file): Likewise.
8602 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8603 (dwarf2_get_dwz_file): Likewise.
8604
395f9c91
TT
86052019-06-16 Tom Tromey <tom@tromey.com>
8606
8607 * coffread.c (process_coff_symbol): Use xstrdup.
8608 * value.c (create_internalvar): Use xstrdup.
8609
cafb3438
TT
86102019-06-16 Tom Tromey <tom@tromey.com>
8611
8612 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8613 * breakpoint.c (stopin_command, stopat_command)
8614 (until_break_command, decode_location_default): Remove unnecessary
8615 cast.
8616 * utils.c (subset_compare): Remove unnecessary cast.
8617 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8618 cast.
8619 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8620 cast.
8621 * infcmd.c (path_command): Remove unnecessary cast.
8622 * coffread.c (decode_type): Remove unnecessary cast.
8623 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8624 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8625 * tui/tui-stack.c (tui_show_locator_content)
8626 (tui_show_frame_info): Remove unnecessary cast.
8627 * tui/tui-win.c (tui_scroll_forward_command)
8628 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8629 (parse_scrolling_args): Remove unnecessary cast.
8630 * tui/tui-data.c (init_win_info, tui_del_window)
8631 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8632 (free_content_elements): Remove unnecessary cast.
8633 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8634 unnecessary cast.
8635 * tui/tui-source.c (tui_set_source_content)
8636 (tui_vertical_source_scroll): Remove unnecessary cast.
8637 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8638 cast.
8639 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8640 * tui/tui-regs.c (tui_display_registers_from)
8641 (tui_display_register): Remove unnecessary cast.
8642 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8643 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8644 (make_visible): Remove unnecessary cast.
8645 * tui/tui-winsource.c (tui_erase_source_content)
8646 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8647 unnecessary cast.
8648 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8649 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8650 * stabsread.c (read_type, read_array_type, read_range_type):
8651 Remove unnecessary cast.
8652 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8653 (parse_symbol, parse_type, upgrade_type, parse_external)
8654 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8655 unnecessary cast.
8656 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8657
730ead81
TT
86582019-06-16 Tom Tromey <tom@tromey.com>
8659
8660 * tui/tui-data.c (tui_alloc_generic_win_info)
8661 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8662 checks.
8663
584a927c
AB
86642019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8665 Andrew Burgess <andrew.burgess@embecosm.com>
8666
8667 * f-typeprint.c (f_print_type): Don't return early for not
8668 associated or not allocated types.
8669 (f_type_print_varspec_suffix): Add print_rank parameter and print
8670 ranks of array types in case they dangling.
8671 (f_type_print_base): Add print_rank parameter.
8672
30056ea0
AB
86732019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8674
8675 * NEWS: Mention new MI commands.
8676 * break-catch-throw.c (enum exception_event_kind): Move to
8677 breakpoint.h.
8678 (print_mention_exception_catchpoint): Output text as a single
8679 message.
8680 (catch_exception_command_1): Rename to...
8681 (catch_exception_event): ...this, make non-static, update header
8682 command, and change some parameter types.
8683 (catch_catch_command): Update for changes to
8684 catch_exception_command_1.
8685 (catch_throw_command): Likewise.
8686 (catch_rethrow_command): Likewise.
8687 * breakpoint.c (enum exception_event_kind): Delete.
8688 * breakpoint.h (enum exception_event_kind): Moved here from
8689 break-catch-throw.c.
8690 (catch_exception_event): Declare.
8691 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8692 (mi_cmd_catch_throw): New function.
8693 (mi_cmd_catch_rethrow): New function.
8694 (mi_cmd_catch_catch): New function.
8695 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8696 'catch-catch' entries.
8697 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8698 (mi_cmd_catch_rethrow): Declare.
8699 (mi_cmd_catch_catch): Declare.
8700
ec8e2b6d
AB
87012019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8702
8703 * annotate.c (annotate_source_line): Change return type to void,
8704 update implementation to match.
8705 * annotate.h (annotate_source_line): Change return type to void,
8706 update header comment.
8707 * stack.c (print_frame_info): Don't change what frame information
8708 is printed based on whether annotations are on or not.
8709
0d3abd8c
AB
87102019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8711
8712 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8713 (annotate_source): Make static.
8714 (annotate_source_line): Moved from source.c and renamed from
8715 identify_source_line. Update the return type.
8716 * annotate.h (annotate_source): Delete declaration.
8717 (annotate_source_line): Declaration moved from source.h, and
8718 renamed from identify_source_line. Return type updated.
8719 * source.c (identify_source_line): Moved to annotate.c and renamed
8720 to annotate_source_line.
8721 (info_line_command): Remove check of annotation_level.
8722 * source.h (identify_source_line): Move declaration to annotate.h
8723 and rename to annotate_source_line.
8724 * stack.c: Add 'annotate.h' include.
8725 (print_frame_info): Remove check of annotation_level before
8726 calling annotate_source_line.
8727
00df30ae
AB
87282019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8729
8730 * source-cache.c (source_cache::get_plain_source_lines): Use
8731 open_source_file_with_line_charpos instead of just
8732 open_source_file, remove call to find_source_lines.
8733 (source_cache::get_source_lines): Likewise.
8734 * source.c (find_source_lines): Make static.
8735 (get_filename_and_charpos): Renamed into...
8736 (open_source_file_with_line_charpos): ..this along with changes to
8737 return a scoped_fd, and some other minor clean ups.
8738 (identify_source_line): Use open_source_file_with_line_charpos.
8739 (search_command_helper): Use open_source_file_with_line_charpos
8740 instead of just open_source_file, remove call to
8741 find_source_lines.
8742 * source.h (open_source_file_with_line_charpos): Declare new
8743 function.
8744 (find_source_lines): Delete declaration.
8745
afda45a2
AB
87462019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8747
8748 * source.c (get_filename_and_charpos): Remove fullname
8749 parameter.
8750 (identify_source_line): Update call to get_filename_and_charpos.
8751
0735b091
TT
87522019-06-14 Tom Tromey <tromey@adacore.com>
8753
8754 PR gdb/24502:
8755 * ui-style.h (skip_ansi_escape): Update comment.
8756 * ui-file.h (class no_terminal_escape_file): New class.
8757 * ui-file.c (no_terminal_escape_file::write)
8758 (no_terminal_escape_file::puts): New methods.
8759 * cli/cli-logging.c (handle_redirections): Use
8760 no_terminal_escape_file.
8761
52ce35e2
TT
87622019-06-14 Tom Tromey <tromey@adacore.com>
8763
8764 * NEWS: Move convenience variable news above Python news.
8765
73cc7272
TT
87662019-06-14 Tom Tromey <tom@tromey.com>
8767
8768 * gnulib: Move directory to top-level.
8769 * configure.ac: Don't configure gnulib.
8770 * configure: Rebuild.
8771 * common/common-defs.h: Use new path to gnulib.
8772 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8773 (GNULIB_H): Remove.
8774 (INCGNU): Look in new gnulib location.
8775 (HFILES_NO_SRCDIR): Remove gnulib files.
8776 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8777 (generated_files): Remove GNULIB_H.
8778 ($(LIBGNU), all-lib): Remove targets.
8779 (distclean): Don't mention GNULIB_BUILDDIR.
8780 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8781
f5686554
TT
87822019-06-14 Tom Tromey <tromey@adacore.com>
8783
8784 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8785 Warn if symbol file does not provide any symbols.
8786
a0c1ffed
TT
87872019-06-14 Tom Tromey <tromey@adacore.com>
8788
8789 * source.c (find_and_open_source): Respect basenames_may_differ.
8790
7c39e397
AB
87912019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8792
8793 * annotate.c (annotate_breakpoints_invalid): Make use of
8794 scoped_restore_terminal_state.
8795 (annotate_frames_invalid): Likewise.
8796
f411722c
TT
87972019-06-14 Tom Tromey <tromey@adacore.com>
8798
8799 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8800 allow assignment to an internalvar.
8801
4268ec18
TT
88022019-06-14 Tom Tromey <tromey@adacore.com>
8803
8804 * ada-lex.l: Allow "_" in attribute names.
8805
abdb711e
TT
88062019-06-14 Tom Tromey <tromey@adacore.com>
8807
8808 PR gdb/24653:
8809 * regcache.c (registers_changed): Don't call alloca.
8810 * top.c (execute_command): Don't call alloca.
8811
4c048731
PA
88122019-06-13 Pedro Alves <palves@redhat.com>
8813
8814 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8815 'expression'. When parsing an expression, error out if there's
8816 junk after "unlimited".
8817 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8818 (do_set_command): Adjust calls to is_unlimited_literal.
8819
66eb1ed3
PA
88202019-06-13 Pedro Alves <palves@redhat.com>
8821
8822 * compile/compile.c (make_compile_options_def_group): Add braces
8823 around array_view initializer.
8824 * thread.c (make_thread_apply_all_options_def_group)
8825 (make_thread_apply_all_options_def_group): Likewise.
8826
3345721a
PA
88272019-06-13 Pedro Alves <palves@redhat.com>
8828
8829 * NEWS (New commands): Mention "maint test-options
8830 require-delimiter", "maint test-options unknown-is-error", "maint
8831 test-options unknown-is-operand" and "maint show
8832 test-options-completion-result".
8833 (New command options, command completion): New section.
8834 (Completion improvements): New section.
8835 Mention that you can abbreviate "unlimited".
8836
6206060d
PA
88372019-06-13 Pedro Alves <palves@redhat.com>
8838
8839 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8840 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8841 * unittests/cli-utils-selftests.c (test_parse_flags)
8842 (test_parse_flags_qcs): Delete.
8843 (test_cli_utils): Don't call deleted functions.
8844
6665660a
PA
88452019-06-13 Pedro Alves <palves@redhat.com>
8846
8847 * thread.c: Include "cli/cli-option.h".
8848 (tp_array_compar_ascending): Global.
8849 (tp_array_compar): Delete function.
8850 (tp_array_compar_ascending, tp_array_compar_descending): New
8851 functions.
8852 (ascending_option_def, qcs_flag_option_def)
8853 (thr_qcs_flags_option_defs)
8854 (make_thread_apply_all_options_def_group)
8855 (make_thread_apply_options_def_group): New.
8856 (thread_apply_all_command): Use gdb::option::process_options.
8857 (thread_apply_command_completer)
8858 (thread_apply_all_command_completer): New.
8859 (thread_apply_command): Use gdb::option::process_options.
8860 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8861 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8862 to generate help text of "thread apply". Adjust "taas"'s help.
8863 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8864 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8865
f7e13587
PA
88662019-06-13 Pedro Alves <palves@redhat.com>
8867
8868 * thread.c (thread_apply_command): Check for invalid TID with
8869 isdigit instead of !isalpha.
8870
5d707134
PA
88712019-06-13 Pedro Alves <palves@redhat.com>
8872
8873 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8874 (validate_flags_qcs): New.
8875 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8876 (validate_flags_qcs): Declare.
8877 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8878 (make_frame_apply_options_def_group): New.
8879 (frame_apply_command_count): Process options with
8880 gdb::option::process_options.
8881 (frame_apply_completer): New.
8882 (frame_apply_level_completer, frame_apply_all_completer)
8883 (frame_apply_completer): New.
8884 (_initialize_stack): Update help of "frame apply", "frame apply
8885 level", "frame apply all" and "faas" to mention supported options
8886 and install command completers.
8887 * stack.h (frame_apply_all_completer): Declare.
8888 * thread.c: Include "stack.h".
8889 (tfaas_command): Add "--".
8890 (_initialize_thread): Update help "tfaas" to mention supported
8891 options and install command completer.
8892
272d4594
PA
88932019-06-13 Pedro Alves <palves@redhat.com>
8894
8895 * completer.c (complete_nested_command_line): New.
8896 (gdb_completion_word_break_characters_throw): Add assertion.
8897 * completer.h (complete_nested_command_line): Declare.
8898
90a1ef87
PA
88992019-06-13 Pedro Alves <palves@redhat.com>
8900
8901 * stack.c (parse_backtrace_qualifiers): New.
8902 (backtrace_command): Use it.
8903 (backtrace_command_completer): Complete on qualifiers.
8904
d4c16835
PA
89052019-06-13 Pedro Alves <palves@redhat.com>
8906
8907 * frame.c: Include "cli/cli-option.h.
8908 (user_set_backtrace_options): New.
8909 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8910 Delete.
8911 (get_prev_frame): Adjust.
8912 (boolean_option_def, uinteger_option_def)
8913 (set_backtrace_option_defs): New.
8914 (_initialize_frame): Adjust and use
8915 gdb::option::add_setshow_cmds_for_options to install "set
8916 backtrace past-main" and "set backtrace past-entry".
8917 * frame.h: Include "cli/cli-option.h".
8918 (struct frame_print_options): Forward declare.
8919 (print_frame_arguments_all, print_frame_arguments_scalars)
8920 (print_frame_arguments_none): Declare.
8921 (print_entry_values): Delete declaration.
8922 (struct frame_print_options, user_frame_print_options): New.
8923 (struct set_backtrace_options): New.
8924 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8925 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8926 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8927 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8928 (list_args_or_locals): Add frame_print_options parameter.
8929 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8930 * python/py-framefilter.c (enumerate_args): Pass down
8931 USER_FRAME_PRINT_OPTIONS.
8932 * stack.c: Include "cli/cli-option.h".
8933 (print_frame_arguments_all, print_frame_arguments_scalars)
8934 (print_frame_arguments_none): Declare.
8935 (print_raw_frame_arguments, print_entry_values): Delete.
8936 (user_frame_print_options): New.
8937 (boolean_option_def, enum_option_def, frame_print_option_defs):
8938 New.
8939 (struct backtrace_cmd_options): New.
8940 (bt_flag_option_def): New.
8941 (backtrace_command_option_defs): New.
8942 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8943 (print_frame_arg, read_frame_arg, print_frame_args)
8944 (print_frame_info, print_frame): Add frame_print_options parameter
8945 and use it.
8946 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8947 (backtrace_command_1): Add frame_print_options and
8948 backtrace_cmd_options parameters and use them.
8949 (make_backtrace_options_def_group): New.
8950 (backtrace_command): Process command options with
8951 gdb::option::process_options.
8952 (backtrace_command_completer): New.
8953 (_initialize_stack): Extend "backtrace"'s help to mention
8954 supported options. Install completer for "backtrace".
8955 Install some settings commands with add_setshow_cmds_for_options.
8956
2daf894e
PA
89572019-06-13 Pedro Alves <palves@redhat.com>
8958
8959 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8960 and that "set/show print raw frame-arguments" are now deprecated.
8961
8962 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8963 command.
8964 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8965 * stack.c (_initialize_stack): Install "set/show print
8966 raw-frame-arguments", and deprecate "set/show print raw
8967 frame-arguments".
8968 * valprint.c (_initialize_valprint): Deprecate "set/show print
8969 raw".
8970
e6ed716c
PA
89712019-06-13 Pedro Alves <palves@redhat.com>
8972
8973 * compile/compile.c (struct compile_options): New.
8974 (compile_flag_option_def, compile_command_option_defs)
8975 (make_compile_options_def_group): New.
8976 (compile_file_command): Handle options with
8977 gdb::option::process_options.
8978 (compile_file_command_completer): New function.
8979 (compile_code_command): Handle options with
8980 gdb::option::process_options.
8981 (compile_code_command_completer): New function.
8982 (_initialize_compiler): Install completers for "compile code" and
8983 "compile file". Mention available options in "compile code" and
8984 "compile code"'s help.
8985 * completer.c (advance_to_completion_word): New, factored out from
8986 ...
8987 (advance_to_expression_complete_word_point): ... this.
8988 (advance_to_filename_complete_word_point): New.
8989 * completer.h (advance_to_filename_complete_word_point): New
8990 declaration.
8991
7d8062de
PA
89922019-06-13 Pedro Alves <palves@redhat.com>
8993
8994 * compile/compile.c: Include "cli/cli-option.h".
8995 (compile_print_value): Scope data pointer is now a
8996 value_print_options pointer; adjust.
8997 (compile_print_command): Process options. Scope data pointer is
8998 now a value_print_options pointer; adjust.
8999 (_initialize_compile): Update "compile print"'s help to include
9000 supported options. Install a completer for "compile print".
9001 * cp-valprint.c (show_vtblprint, show_objectprint)
9002 (show_static_field_print): Delete.
9003 (_initialize_cp_valprint): Don't install "set print
9004 static-members", "set print vtbl", "set print object" here.
9005 * printcmd.c: Include "cli/cli-option.h" and
9006 "common/gdb_optional.h".
9007 (print_command_parse_format): Rework to fill in a
9008 value_print_options instead of a format_data.
9009 (print_value): Change parameter type from format_data pointer to
9010 value_print_options reference. Adjust.
9011 (print_command_1): Process options. Adjust to pass down a
9012 value_print_options.
9013 (print_command_completer): New.
9014 (_initialize_printcmd): Install print_command_completer as
9015 handle_brkchars completer for the "print" command. Update
9016 "print"'s help to include supported options.
9017 * valprint.c: Include "cli/cli-option.h".
9018 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9019 here from cp-valprint.c.
9020 (boolean_option_def, uinteger_option_def)
9021 (value_print_option_defs, make_value_print_options_def_group):
9022 New. Use gdb::option::add_setshow_cmds_for_options to install
9023 "set print elements", "set print null-stop", "set print repeats",
9024 "set print pretty", "set print union", "set print array", "set
9025 print address", "set print symbol", "set print array-indexes".
9026 * valprint.h: Include <string> and "cli/cli-option.h".
9027 (make_value_print_options_def_group): Declare.
9028 (print_value): Change parameter type from format_data pointer to
9029 value_print_options reference.
9030 (print_command_completer): Declare.
9031
9d0faba9
PA
90322019-06-13 Pedro Alves <palves@redhat.com>
9033
9034 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9035 (COMMON_SFILES): Add maint-test-settings.c.
9036 * cli/cli-decode.c (boolean_enums): New global, factored out from
9037 ...
9038 (add_setshow_boolean_cmd): ... here.
9039 * cli/cli-decode.h (boolean_enums): Declare.
9040 * cli/cli-option.c: New file.
9041 * cli/cli-option.h: New file.
9042 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9043 factored out from ...
9044 (parse_cli_boolean_value(const char *)): ... this.
9045 (is_unlimited_literal): Change parameter type to pointer to
9046 pointer. Adjust and advance ARG pointer.
9047 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9048 (parse_cli_var_enum): New, factored out from ...
9049 (do_set_command): ... this. Adjust.
9050 * cli/cli-setshow.h (parse_cli_boolean_value)
9051 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9052 (parse_cli_var_enum): Declare.
9053 * cli/cli-utils.c: Include "cli/cli-option.h".
9054 (get_ulongest): New.
9055 * cli/cli-utils.h (get_ulongest): Declare.
9056 (check_for_argument): New overloads.
9057 * maint-test-options.c: New file.
9058
2c722807
PA
90592019-06-13 Pedro Alves <palves@redhat.com>
9060
9061 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9062 parse a range if "-" is at the end of the string.
9063
dee7b4c8
PA
90642019-06-13 Pedro Alves <palves@redhat.com>
9065
9066 * cli/cli-setshow.c (parse_auto_binary_operation)
9067 (parse_cli_boolean_value): Don't allow "o".
9068
dca0f6c0
PA
90692019-06-13 Pedro Alves <palves@redhat.com>
9070
9071 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9072 * NEWS: Mention maint test-settings KIND.
9073 * maint-test-settings.c: New file.
9074
597bf39d
PA
90752019-06-13 Pedro Alves <palves@redhat.com>
9076
9077 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9078 completer.
9079 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9080 "set" completers.
9081
48c410fb
PA
90822019-06-13 Pedro Alves <palves@redhat.com>
9083
9084 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9085 after item.
9086
93bcb043
PA
90872019-06-13 Pedro Alves <palves@redhat.com>
9088
9089 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9090
cbba3ecd
PA
90912019-06-13 Pedro Alves <palves@redhat.com>
9092
9093 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9094 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9095 call.
9096 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9097 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9098 calls.
9099 (check_for_argument): Skip spaces after argument.
9100
b9a3f842
PA
91012019-06-13 Pedro Alves <palves@redhat.com>
9102
9103 * thread.c (thread_apply_command): Adjust TID parsing.
9104 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9105 detected before end of string.
9106 (tid_is_in_list): Error out if LIST is invalid.
9107
3844e605
PA
91082019-06-13 Pedro Alves <palves@redhat.com>
9109
9110 * completer.c (complete_line_internal_1): Rewind completion word
9111 point.
9112 (completion_tracker::advance_custom_word_point_by): Change
9113 parameter type to int.
9114 * completer.h (completion_tracker::advance_custom_word_point_by):
9115 Likewise.
9116
00b56dbe
PA
91172019-06-13 Pedro Alves <palves@redhat.com>
9118
9119 * completer.c (advance_to_completion_word): Handle delimiters.
9120
d106773e
PA
91212019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9122
9123 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9124
08f10e02
TT
91252019-06-11 Tom Tromey <tom@tromey.com>
9126
9127 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9128 (xmalloc_failed): Move to alloc.c.
9129 * alloc.c: New file.
9130 * Makefile.in (COMMON_SFILES): Add alloc.c.
9131
1c7fe951
TT
91322019-06-11 Tom Tromey <tom@tromey.com>
9133
9134 * nat/linux-waitpid.c: Don't include server.h.
9135 (linux_debug): Remove.
9136 (my_waitpid): Update.
9137
89549d7f
TT
91382019-06-11 Tom Tromey <tromey@adacore.com>
9139
9140 * infcall.c (_initialize_infcall): Remove trailing newline from
9141 help.
9142 * user-regs.c (_initialize_user_regs): Remove trailing newline
9143 from help.
9144 * typeprint.c (_initialize_typeprint): Remove trailing newline
9145 from help.
9146 * reverse.c (_initialize_reverse): Remove trailing newlines from
9147 help.
9148 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9149 from help.
9150 * language.c (add_set_language_command): Remove trailing newline
9151 from help.
9152 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9153 help.
9154 * disasm.c (_initialize_disasm): Remove trailing newline from
9155 help.
9156 * top.c (init_main): Remove trailing newline from help.
9157 * interps.c (_initialize_interpreter): Remove trailing newline
9158 from help.
9159 * btrace.c (_initialize_btrace): Remove trailing newlines from
9160 help.
9161 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9162 from help.
9163 * python/python.c (_initialize_python): Remove trailing newline
9164 from help.
9165 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9166 help.
9167 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9168 from help. Reformat some text.
9169 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9170 from help.
9171 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9172 newline from help.
9173
86108c13
TT
91742019-06-11 Tom Tromey <tromey@adacore.com>
9175
9176 * darwin-nat.c (darwin_decode_exception_message)
9177 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9178
a7067863
AB
91792019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9180
9181 * valops.c (value_slice): Check for not allocated or not
9182 associated values.
9183
9ab08412
TV
91842019-06-10 Tom de Vries <tdevries@suse.de>
9185
9186 PR gdb/24618
9187 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9188 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9189 invalid.
9190
f19e22e9
TV
91912019-06-10 Tom de Vries <tdevries@suse.de>
9192
9193 PR gdb/24611
9194 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9195 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9196
e99f9db0
TV
91972019-06-10 Tom de Vries <tdevries@suse.de>
9198
9199 PR symtab/24545
9200 * symtab.c (struct demangled_name_entry): Add language field.
9201 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9202 static minimal symbol". Set and use language field.
9203
9bf7038b
TT
92042019-06-10 Tom Tromey <tromey@adacore.com>
9205
9206 * ada-lang.c (_initialize_ada_language): Update help text.
9207
422186a9
TT
92082019-06-10 Tom Tromey <tromey@adacore.com>
9209
9210 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9211 with a newline.
9212 * guile/guile.c (handle_boot_error): Don't end warning with a
9213 newline.
9214 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9215 warning with a newline.
9216 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9217 newline.
9218 (s12z_frame_cache): Likewise.
9219 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9220 a newline.
9221 * solib-svr4.c (disable_probes_interface): Don't end warning with
9222 a newline.
9223 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9224 newline.
9225 * python/python.c (do_finish_initialization): Don't end warning
9226 with a newline.
9227
25ce02ee
TT
92282019-06-10 Tom Tromey <tom@tromey.com>
9229
9230 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9231 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9232 gdbpy_enter.
9233
caa429d8
TT
92342019-06-10 Tom Tromey <tromey@adacore.com>
9235
9236 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9237 data.
9238 (elf_new_init): Don't call stabsread_new_init.
9239 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9240 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9241 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9242
81873cc8
TV
92432019-06-10 Tom de Vries <tdevries@suse.de>
9244
9245 PR symtab/16264
9246 PR symtab/24517
9247 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9248
4fa0265e
РИ
92492019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9250
9251 * source.c (find_and_open_source): Also rewrite relative file
9252 names.
9253
1a3da2cd
AB
92542019-04-26 Amos Bird <amosbird@gmail.com>
9255
9256 * annotate.c (annotate_thread_exited): Add "thread-exited"
9257 annotation.
9258
3847a7bf
TT
92592019-06-06 Tom Tromey <tromey@adacore.com>
9260
9261 * maint.h (class scoped_command_stats): Use
9262 DISABLE_COPY_AND_ASSIGN.
9263 <print_time>: New method.
9264 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9265 print_time.
9266 (scoped_command_stats::print_time): New method.
9267
312617a3
AB
92682019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9269
9270 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9271 instructions of lengths 6 or 8 bytes.
9272
b02f78f9
PA
92732019-06-04 Pedro Alves <palves@redhat.com>
9274
9275 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9276
9277 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9278 * breakpoint.c (condition_completer): Likewise.
9279 * cli/cli-dump.c (scan_expression): Likewise.
9280 * common/filestuff.c (mkdir_recursive): Likewise.
9281 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9282 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9283 (gdb_abspath): Likewise.
9284 * compile/compile-cplus-types.c
9285 (compile_cplus_instance::decl_name): Likewise.
9286 * completer.c (complete_explicit_location):
9287 (signal_completer, reg_or_group_completer_1): Likewise.
9288 * cp-support.c (cp_remove_params_if_any): Likewise.
9289 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9290 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9291 * infcmd.c (strip_bg_char): Likewise.
9292 * linespec.c (copy_token_string): Likewise.
9293 * mi/mi-main.c (output_cores): Likewise.
9294 * psymtab.c (psymtab_search_name):
9295 * symfile.c (test_set_ext_lang_command): Likewise.
9296 * target.c (target_fileio_read_stralloc): Likewise.
9297 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9298 * value.c (complete_internalvar): Likewise.
9299
e1f2e1a2
CB
93002019-06-04 Christian Biesinger <cbiesinger@google.com>
9301
9302 Add objfile property to gdb.Type.
d3238f7d
PA
9303 * NEWS: Mention Python API addition.
9304 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9305
e664d728
PW
93062019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9307
9308 * NEWS: Mention the new set|show style [title|highlight].
9309 Mention changes to "show style", "help" and "apropos".
9310
66d8c862
PW
93112019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9312
9313 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9314 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9315 instead of print_help_for_command.
9316 (print_doc_of_command): New function.
9317 (help_list): Add 'apropos -v word' suggestion.
9318 (print_help_for_command): Style the command name using title style.
9319 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9320 (_initialize_cli_cmds): Describe -v in apropos_command help.
9321
9303eb2f
PW
93222019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9323
9324 * cli/cli-style.h (cli_style_option): Add name in constructor,
9325 add m_name class member, add constructor with intensity,
9326 add name class function.
9327 (cli_style_option::add_setshow_commands): Remove name argument.
9328 (highlight_style, title_style): New styles.
9329 * cli/cli-style.c (do_show): New function that shows a style
9330 characteristic styling the style name with itself.
9331 (set_style_name): New function.
9332 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9333 Update all callers according to the changes in cli/cli-style.h.
9334 * utils.h (fputs_highlighted): New function.
9335 * utils.c (fputs_highlighted): Likewise.
9336
e2c52041
PW
93372019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9338
9339 * NEWS: Mention new pipe command and new convenience variables.
9340
947d3946
PW
93412019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9342
9343 * cli/cli-cmds.c (pipe_command): New function.
9344 (_initialize_cli_cmds): Call add_com for pipe_command.
9345 Define | as an alias for pipe.
9346 (exit_status_set_internal_vars): New function.
9347 (shell_escape): Call exit_status_set_internal_vars.
9348 cli/cli-decode.c (find_command_name_length): Recognize | as
9349 a single character command.
9350
b8fd0918
PW
93512019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9352
9353 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9354 top.c (execute_command_to_ui_file): New function, mostly a copy
9355 of execute_command_to_string.
9356 (execute_command_to_string): Implement by calling
9357 execute_command_to_ui_file.
9358
68bb5386
PW
93592019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9360
9361 * top.h (saved_command_line): Remove declaration.
9362 * top.c (previous_saved_command_line, previous_repeat_arguments):
9363 New variables.
9364 (saved_command_line): Make static, define together with other
9365 'repeat variables'.
9366 (dont_repeat): Clear repeat_arguments.
9367 (repeat_previous, get_saved_command_line, save_command_line):
9368 New functions.
9369 (gdb_init): Initialize saved_command_line
9370 and previous_saved_command_line.
9371 * main.c (captured_main_1): Remove saved_command_line initialization.
9372 * event-top.c (handle_line_of_input): Update to use
9373 the new 'repeat' related functions instead of direct access to
9374 saved_command_line.
9375 * command.h (repeat_previous, get_saved_command_line,
9376 save_command_line): New declarations.
9377 (dont_repeat): Add comment.
9378
bfcdb852
TT
93792019-05-30 Tom Tromey <tromey@adacore.com>
9380
9381 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9382 Fix comment.
9383 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9384
0ef209f2
JV
93852019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9386
9387 PR cli/24587
9388 * completer.c (complete): Initialize variable word.
9389
955b06fa
SDJ
93902019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9391
9392 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9393 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9394 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9395 'body' is NULL to the outter 'if', protecting the '!is_define'
9396 situation as well.
9397
fa9c3fa0
TT
93982019-05-29 Tom Tromey <tromey@adacore.com>
9399
9400 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9401 (dwarf_unknown): New function.
9402 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9403 (dwarf_type_encoding_name): Use dwarf_unknown.
9404
4330d61d
TT
94052019-05-29 Tom Tromey <tromey@adacore.com>
9406
9407 PR c++/20020:
9408 * cp-valprint.c (cp_print_value_fields): Call
9409 cp_print_static_field inside "try".
9410
33a6bc35
TT
94112019-05-29 Tom Tromey <tromey@adacore.com>
9412
9413 * inflow.c (struct terminal_info): Add default operator=.
9414 * configure: Rebuild.
9415 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9416 -Wdeprecated-copy-dtor, -Wredundant-move.
9417
000439d5
TT
94182019-05-29 Tom Tromey <tromey@adacore.com>
9419
9420 * NEWS: Add entry.
9421 * infcmd.c (print_return_value_1): Handle finish_print
9422 option.
9423 (show_print_finish): New function.
9424 (_initialize_infcmd): Add "set/show print finish" commands.
9425 * valprint.c (user_print_options): Initialize new member.
9426 * valprint.h (struct value_print_options) <finish_print>: New
9427 member.
9428
c0e70c62
TT
94292019-05-28 Tom Tromey <tromey@adacore.com>
9430
9431 * ada-lang.c (ada_remove_Xbn_suffix)
9432 (find_old_style_renaming_symbol)
9433 (parse_old_style_renaming): Remove.
9434 (ada_find_renaming_symbol): Don't call
9435 find_old_style_renaming_symbol.
9436 (ada_is_renaming_symbol): Rename from
9437 ada_find_renaming_symbol. Remove "block" parameter. Return
9438 bool. Now static.
9439 (ada_read_var_value): Update and simplify.
9440 * ada-exp.y (write_var_or_type): Remove old code.
9441
766f8836
AH
94422019-05-28 Alan Hayward <alan.hayward@arm.com>
9443
68255adc 9444 PR gdb/25010
766f8836
AH
9445 * event-top.c: Remove include comment.
9446 * inflow.c (class scoped_ignore_sigttou): Move from here...
9447 * inflow.h (class scoped_ignore_sigttou): ...to here.
9448 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9449 * top.c: Remove include comment.
9450
eb41253a
TT
94512019-05-27 Tom Tromey <tom@tromey.com>
9452
9453 * NEWS: Fix typo.
9454
4ca51187
TT
94552019-05-22 Tom Tromey <tromey@adacore.com>
9456
9457 * target.c (target_follow_exec): Constify parameter.
9458 * target-delegates.c: Rebuild.
9459 * remote.c (remote_target::follow_exec): Constify parameter.
9460 * infrun.c (follow_exec): Constify parameter.
9461 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9462 (target_follow_exec): Likewise.
9463
8fca4da0
AH
94642019-05-22 Alan Hayward <alan.hayward@arm.com>
9465
9466 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9467 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9468
b7060614
AH
94692019-05-22 Alan Hayward <alan.hayward@arm.com>
9470
9471 * NEWS: Add debugredirect and testsuite sections.
9472
0a5954bd
SC
94732019-05-22 Simon Cook <simon.cook@embecosm.com>
9474
9475 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9476 target descriptions using exclusively floating point register name
9477 aliases.
9478
dc42e902
AB
94792019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9480
9481 PR gdb/18644:
9482 * f-lang.c (build_fortran_types): Handle the case where
9483 gdbarch_floatformat_for_type returns a nullptr.
9484
fb7806c7
TV
94852019-05-21 Tom de Vries <tdevries@suse.de>
9486
9487 PR cli/24587
9488 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9489
34d11c68
AB
94902019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9491
9492 PR gdb/18644:
9493 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9494 16-byte floats.
9495 * i386-tdep.c (i386_floatformat_for_type): Use
9496 floatformats_ia64_quad for the 16-byte floating point component
9497 within a fortran 32-byte complex number.
9498
122cf0f2
AB
94992019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9500
9501 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9502 delete default constructor.
9503 (find_partial_die): Update to return const struct.
9504 (partial_die_parent_scope): Move variable declaration into scope
9505 of its use and change its type to auto.
9506 (guess_partial_die_structure_name): Likewise.
9507 (partial_die_info::fixup): Likewise.
9508
33d0e35a
TT
95092019-05-17 Tom Tromey <tromey@adacore.com>
9510
9511 * source.c (find_and_open_source): Remove cast.
9512
a45575b0
TT
95132019-05-17 Tom Tromey <tromey@adacore.com>
9514
9515 * annotate.c (annotate_source): Make "filename" const.
9516 * annotate.h (annotate_source): Use const.
9517
81f47ac2
AH
95182019-05-17 Alan Hayward <alan.hayward@arm.com>
9519
9520 * disasm.c (set_disassembler_options): Send errors to stderr.
9521
ca1285d1
AH
95222019-05-17 Alan Hayward <alan.hayward@arm.com>
9523
9524 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9525 (cli_interp_base::set_logging): Check debug_redirect.
9526 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9527 * cli/cli-logging.c (debug_redirect): Add static variable.
9528 (pop_output_files): Add default param.
9529 (handle_redirections): Print debug setting.
9530 (show_logging_command): Likewise.
9531 (_initialize_cli_logging): Add debugredirect command.
9532 * interps.c (current_interp_set_logging): Add debug_redirect
9533 parameter.
9534 * interps.h (set_logging): Add debug_redirect parameter.
9535 (current_interp_set_logging): Likewise.
9536 * mi/mi-common.h: Likewise.
9537 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9538
95392019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
9540 Tom Tromey <tromey@adacore.com>
9541
9542 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9543 directly.
9544 * cli/cli-interp.h (make_logging_output): Remove declaration.
9545 * cli/cli-logging.c (make_logging_output): Remove function.
9546 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9547 directly.
9548 * ui-file.c (tee_file::tee_file): Remove bools.
9549 (tee_file::~tee_file): Remove deletes.
9550 * ui-file.h (tee_file): Remove bools.
9551
26648588
JV
95522019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9553
9554 * mi/mi-cmds.h (mi_cmd_complete): New function.
9555 * mi/mi-main.c (mi_cmd_complete): Likewise.
9556 * mi/mi-cmds.c: Define new MI command -complete.
9557 * NEWS: Mention new -complete command.
9558
6e035501
JV
95592019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9560
9561 * completer.h (complete): New function.
9562 * completer.c (complete): Likewise.
9563 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9564 function defined in completer.h.
9565
7d0e2ece
JV
95662019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9567
e79be6e5 9568 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9569
fb816e8b
TV
95702019-05-17 Tom de Vries <tdevries@suse.de>
9571
9572 PR gdb/24094
9573 * dwarf2read.c (struct cu_partial_die_info): New struct.
9574 (find_partial_die): Return cu_partial_die_info.
9575 (partial_die_parent_scope, guess_partial_die_structure_name)
9576 (partial_die_info::fixup): Handle new return type of find_partial_die.
9577
677052f2
SDJ
95782019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9579
a1726c38 9580 PR breakpoints/24541
677052f2
SDJ
9581 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9582 "std::string", simplifying the algorithm.
9583
f3da9116
SDJ
95842019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9585
9586 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9587 (stap_static_probe_ops::get_probes): Likewise.
9588
f1bb75ab
SDJ
95892019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9590
9591 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9592 '-')" and "else if".
9593 (stap_parse_single_operand): Join checks for
9594 "gdbarch_stap_parse_special_token_p" and
9595 "gdbarch_stap_parse_special_token" in the same "if" statement.
9596 Invert check when verifying for operation on register
9597 displacement.
9598
3ca58cde
SDJ
95992019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9600
9601 * stap-probe.c (stap_get_opcode): Update comment.
9602 (stap_get_expected_argument_type): Likewise.
9603 (handle_stap_probe): Likewise.
9604
af2d9bee
SDJ
96052019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9606
9607 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9608 return type to 'bool'. Adjust comment. Use 'bool' when
9609 appropriate.
9610 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9611 * stap-probe.c (stap_parse_argument_1): Likewise.
9612 (stap_is_operator): Likewise.
9613 (stap_is_generic_prefix): Likewise.
9614 (stap_is_register_prefix): Likewise.
9615 (stap_is_register_indirection_prefix): Likewise.
9616 (stap_is_integer_prefix): Likewise.
9617 (stap_generic_check_suffix): Likewise.
9618 (stap_check_integer_suffix): Likewise.
9619 (stap_check_register_suffix): Likewise.
9620 (stap_check_register_indirection_suffix): Likewise.
9621 (stap_parse_register_operand): Likewise.
9622 (stap_parse_single_operand): Likewise.
9623 (stap_parse_argument_1): Likewise.
9624 (stap_probe::get_argument_count): Likewise.
9625 (stap_is_operator): Likewise.
9626
61c9c421
TT
96272019-05-16 Tom Tromey <tromey@adacore.com>
9628
9629 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9630 keyword to foreach.
9631
9ddc1af1
SM
96322019-05-15 Simon Marchi <simon.marchi@efficios.com>
9633
9634 * linux-thread-db.c (try_thread_db_load_1): Change return type
9635 to bool.
9636 (try_thread_db_load): Likewise.
9637 (try_thread_db_load_from_pdir_1): Likewise.
9638 (try_thread_db_load_from_pdir): Likewise.
9639 (try_thread_db_load_from_sdir): Likewise.
9640 (try_thread_db_load_from_dir): Likewise.
9641 (thread_db_load_search): Likewise.
9642 (has_libpthread): Likewise.
9643 (thread_db_load): Likewise.
9644
7bede828
SDJ
96452019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9646
9647 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9648 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9649 NULL, and complain/return if that's the case.
9650
c5358db4
JD
96512019-05-15 John Darrington <john@darrington.wattle.id.au>
9652
9653 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9654 (advance, posn, abstract_read_memory): New functions.
9655 [struct mem_read_abstraction]: New struct.
9656 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9657
c408a94f
TT
96582019-05-14 Tom Tromey <tromey@adacore.com>
9659
9660 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9661 value is not lval_memory.
9662
e7bd7fba
TT
96632019-05-14 Tom Tromey <tromey@adacore.com>
9664
9665 * solib.c (info_sharedlibrary_command): Style the file name.
9666
a6d0f249
AH
96672019-05-14 Alan Hayward <alan.hayward@arm.com>
9668
9669 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9670 (aarch64_vnv_type): Likewise.
9671 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9672 * common/tdesc.c: Likewise.
9673 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9674 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9675 * features/aarch64-fpu.xml: Add ieee half view.
9676 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9677 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9678 * gdbtypes.h (struct builtin_type): Likewise.
9679 (struct objfile_type): Likewise.
9680
66b8bb74
SM
96812019-05-12 Paul Naert <paul.naert@polymtl.ca>
9682
9683 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9684 typo.
9685 * location.h (string_to_event_location): Likewise.
9686
21c219fd
JB
96872019-05-11 Joel Brobecker <brobecker@adacore.com>
9688
9689 GDB 8.3 released.
9690
13674803
SM
96912019-05-10 Simon Marchi <simon.marchi@efficios.com>
9692
9693 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9694 New variable declaration.
9695 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9696 New variable.
9697 (print_one_breakpoint): Use ui_out::test_flags and new global
9698 variable to compute use_fixed_output.
9699 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9700 Remove.
9701 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9702 (mi_multi_location_breakpoint_output_fixed): Remove.
9703 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9704 new variable.
9705 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9706 fix_multi_location_breakpoint_output flag if version >= 3.
9707 * ui-out.h (enum ui_out_flag)
9708 <fix_multi_location_breakpoint_output>: New enumerator.
9709
a9eac7f9
SM
97102019-05-10 Simon Marchi <simon.marchi@efficios.com>
9711
9712 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9713
71bed2db
TT
97142019-05-10 Tom Tromey <tromey@adacore.com>
9715
9716 * ada-lang.c (catch_ada_completer): New function.
9717 (_initialize_ada_language): Use it.
9718
24c54127
TT
97192019-05-10 Tom Tromey <tromey@adacore.com>
9720
9721 * thread.c (print_thread_info): Make "requested_threads" const.
9722 * gdbthread.h (print_thread_info): Make "requested_threads"
9723 const.
9724 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9725 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9726
7a102139
TT
97272019-05-08 Tom Tromey <tom@tromey.com>
9728
9729 * gdbtypes.c (objfile_type_data): Change type.
9730 (objfile_type, _initialize_gdbtypes): Update.
9731
924d79e2
TT
97322019-05-08 Tom Tromey <tom@tromey.com>
9733
9734 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9735 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9736 (_initialize_dwarf2_frame): Update.
9737
4c58e337
TT
97382019-05-08 Tom Tromey <tom@tromey.com>
9739
9740 * objc-lang.c (objc_objfile_data): Change type.
9741 (find_methods): Update.
9742 (_initialize_objc_lang): Remove.
9743
d772d2ab
TT
97442019-05-08 Tom Tromey <tom@tromey.com>
9745
9746 * stabsread.c (rs6000_builtin_type_data): Change type.
9747 (rs6000_builtin_type, _initialize_stabsread): Update.
9748
d11d83f4
TT
97492019-05-08 Tom Tromey <tom@tromey.com>
9750
9751 * mips-tdep.c (mips_pdr_data): Remove.
9752 (_initialize_mips_tdep): Update.
9753
9a73f0ad
TT
97542019-05-08 Tom Tromey <tom@tromey.com>
9755
9756 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9757 (hppa_init_objfile_priv_data, read_unwind_info)
9758 (find_unwind_entry, _initialize_hppa_tdep): Update.
9759
8127a2fa
TT
97602019-05-08 Tom Tromey <tom@tromey.com>
9761
9762 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9763 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9764 on obstack.
9765 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9766
91d3055d
TT
97672019-05-08 Tom Tromey <tom@tromey.com>
9768
9769 * mdebugread.c (basic_type_data): Change type.
9770 (basic_type, _initialize_mdebugread): Update.
9771
31930bd3
TT
97722019-05-08 Tom Tromey <tom@tromey.com>
9773
9774 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9775
bdb3ed9e
TT
97762019-05-08 Tom Tromey <tom@tromey.com>
9777
9778 * nto-tdep.c (nto_inferior_data_reg): Change type.
9779 (nto_inferior_data): Update.
9780 (nto_inferior_data_cleanup, nto_new_inferior_data)
9781 (_initialize_nto_tdep): Remove.
9782 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9783
f37b313d
TT
97842019-05-08 Tom Tromey <tom@tromey.com>
9785
9786 * ada-lang.c (struct ada_inferior_data): Add initializers.
9787 (ada_inferior_data): Change type.
9788 (ada_inferior_data_cleanup): Remove.
9789 (get_ada_inferior_data, ada_inferior_exit)
9790 (struct ada_pspace_data): Add initializers, destructor.
9791 (ada_pspace_data_handle): Change type.
9792 (get_ada_pspace_data): Update.
9793 (ada_pspace_data_cleanup): Remove.
9794
24699405
TT
97952019-05-08 Tom Tromey <tom@tromey.com>
9796
9797 * coffread.c (struct coff_symfile_info): Add initializers.
9798 (coff_objfile_data_key): Move lower. Change type.
9799 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9800 Update.
9801 (coff_free_info): Remove.
9802
d4e05d2f
TT
98032019-05-08 Tom Tromey <tom@tromey.com>
9804
9805 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9806 (fbsd_pspace_data_handle): Move lower. Change type.
9807 (get_fbsd_pspace_data): Update.
9808 (fbsd_pspace_data_cleanup): Remove.
9809 (_initialize_fbsd_tdep): Update.
9810
14ef6690
TT
98112019-05-08 Tom Tromey <tom@tromey.com>
9812
9813 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9814 (get_ada_tasks_pspace_data): Update.
9815 (ada_tasks_pspace_data_cleanup): Remove.
9816 (_initialize_tasks): Update.
9817 (ada_tasks_inferior_data_handle): Change type.
9818 (get_ada_tasks_inferior_data): Update.
9819 (ada_tasks_inferior_data_cleanup): Remove.
9820 (struct ada_tasks_pspace_data): Add initializers.
9821
814cf43a
TT
98222019-05-08 Tom Tromey <tom@tromey.com>
9823
9824 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9825 * symfile-debug.c (debug_sym_get_probes): Change type.
9826 * stap-probe.c (handle_stap_probe):
9827 (stap_static_probe_ops::get_probes): Change type.
9828 * probe.h (class static_probe_ops) <get_probes>: Change type.
9829 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9830 (parse_probes_in_pspace): Update.
9831 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9832 Update.
9833 (any_static_probe_ops::get_probes): Change type.
9834 * elfread.c (elfread_data): New typedef.
9835 (probe_key): Change type.
9836 (elf_get_probes): Likewise. Update.
9837 (probe_key_free): Remove.
9838 (_initialize_elfread): Update.
9839 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9840 Change type.
9841 (dtrace_process_dof_probe, dtrace_process_dof)
9842 (dtrace_static_probe_ops::get_probe): Change type.
9843
02dc647e
TT
98442019-05-08 Tom Tromey <tom@tromey.com>
9845
9846 * xcoffread.c (struct xcoff_symfile_info): Rename from
9847 coff_symfile_info. Add initializers.
9848 (xcoff_objfile_data_key): Move lower. Change type.
9849 (XCOFF_DATA): Rewrite.
9850 (xcoff_free_info): Remove.
9851 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9852 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9853 (xcoff_initial_scan): Update.
9854
09232438
TT
98552019-05-08 Tom Tromey <tom@tromey.com>
9856
9857 * solib-svr4.c (struct svr4_info): Add initializers and
9858 destructor.
9859 <probes_table>: Now an htab_up.
9860 (solib_svr4_pspace_data): Change type.
9861 (free_probes_table): Simplify.
9862 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9863 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9864 (probes_table_remove_objfile_probes, register_solib_event_probe)
9865 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9866 (_initialize_svr4_solib): Update.
9867
7b4a314f
TT
98682019-05-08 Tom Tromey <tom@tromey.com>
9869
9870 * remote.c (remote_pspace_data): Change type.
9871 (remote_pspace_data_cleanup): Remove.
9872 (get_remote_exec_file, set_pspace_remote_exec_file)
9873 (_initialize_remote): Update.
9874
51d3063a
TT
98752019-05-08 Tom Tromey <tom@tromey.com>
9876
9877 * breakpoint.c (breakpoint_objfile_key): Change type.
9878 (get_breakpoint_objfile_data): Update.
9879 (free_breakpoint_objfile_data): Remove.
9880 (_initialize_breakpoint): Update.
9881
89fb8848
TT
98822019-05-08 Tom Tromey <tom@tromey.com>
9883
9884 * linux-tdep.c (struct linux_info): Add initializers.
9885 (linux_inferior_data): Move. Change type.
9886 (invalidate_linux_cache_inf): Update.
9887 (linux_inferior_data_cleanup): Remove.
9888 (get_linux_inferior_data, _initialize_linux_tdep): Update.
9889
e9b89e2d
TT
98902019-05-08 Tom Tromey <tom@tromey.com>
9891
9892 * auxv.c (auxv_inferior_data): Move. Change type.
9893 (auxv_inferior_data_cleanup): Remove.
9894 (invalidate_auxv_cache_inf): Rewrite.
9895 (get_auxv_inferior_data, _initialize_auxv): Update.
9896
8c42777c
TT
98972019-05-08 Tom Tromey <tom@tromey.com>
9898
9899 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9900 (symfile_debug_objfile_data_key): Change type.
9901 (symfile_debug_installed, debug_qf_has_symbols)
9902 (debug_qf_find_last_source_symtab)
9903 (debug_qf_forget_cached_source_info)
9904 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9905 (debug_qf_print_stats, debug_qf_dump)
9906 (debug_qf_expand_symtabs_for_function)
9907 (debug_qf_expand_all_symtabs)
9908 (debug_qf_expand_symtabs_with_fullname)
9909 (debug_qf_map_matching_symbols)
9910 (debug_qf_expand_symtabs_matching)
9911 (debug_qf_find_pc_sect_compunit_symtab)
9912 (debug_qf_map_symbol_filenames)
9913 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9914 (debug_sym_new_init, debug_sym_init, debug_sym_read)
9915 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9916 (debug_sym_read_linetable, debug_sym_relocate): Update.
9917 (symfile_debug_free_objfile): Remove.
9918 (install_symfile_debug_logging, _initialize_symfile_debug):
9919 Update.
9920
5bfd760d
TT
99212019-05-08 Tom Tromey <tom@tromey.com>
9922
9923 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9924 allocate_on_obstack.
9925 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9926 (get_dwarf2_per_objfile): Update.
9927 (set_dwarf2_per_objfile): Remove.
9928 (dwarf2_has_info, dwarf2_get_section_info): Update.
9929 (dwarf2_free_objfile): Remove.
9930 (_initialize_dwarf2_read): Update.
9931
e85e19b4
TT
99322019-05-08 Tom Tromey <tom@tromey.com>
9933
9934 * auto-load.c (struct auto_load_pspace_info): Add destructor and
9935 initializers.
9936 <unsupported_script_warning_printed,
9937 script_not_found_warning_printed>: Now bool.
9938 (auto_load_pspace_data): Change type.
9939 (~auto_load_pspace_info): Rename from
9940 auto_load_pspace_data_cleanup.
9941 (get_auto_load_pspace_data, init_loaded_scripts_info)
9942 (clear_section_scripts, maybe_print_unsupported_script_warning)
9943 (maybe_print_script_not_found_warning, _initialize_auto_load):
9944 Update.
9945
f6aa7436
TT
99462019-05-08 Tom Tromey <tom@tromey.com>
9947
9948 * objfiles.c (objfile_pspace_info): Add destructor and
9949 initializers.
9950 (objfiles_pspace_data): Change type.
9951 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9952 (get_objfile_pspace_data): Update.
9953 (objfiles_bfd_data): Change type.
9954 (get_objfile_bfd_data): Update.
9955 (objfile_bfd_data_free, _initialize_objfiles): Remove.
9956
6ae614f6
TT
99572019-05-08 Tom Tromey <tom@tromey.com>
9958
9959 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9960 Change type.
9961 (get_catch_syscall_inferior_data): Update.
9962 (catch_syscall_inferior_data_cleanup): Remove.
9963 (_initialize_break_catch_syscall): Update.
9964
6509b8eb
TT
99652019-05-08 Tom Tromey <tom@tromey.com>
9966
9967 * inflow.c (struct terminal_info): Add destructor and
9968 initializers.
9969 (inflow_inferior_data): Change type.
9970 (~terminal_info): Rename from inflow_inferior_data_cleanup.
9971 (get_inflow_inferior_data, inflow_inferior_exit)
9972 (swap_terminal_info, _initialize_inflow): Update.
9973
35632941
TT
99742019-05-08 Tom Tromey <tom@tromey.com>
9975
9976 * target-dcache.c (target_dcache_cleanup): Remove.
9977 (target_dcache_aspace_key): Change type.
9978 (target_dcache_init_p, target_dcache_invalidate)
9979 (target_dcache_get, target_dcache_get_or_init)
9980 (_initialize_target_dcache): Update.
9981 * dcache.h (struct dcache_deleter): New.
9982
3017b94d
TT
99832019-05-08 Tom Tromey <tom@tromey.com>
9984
9985 * symtab.c (struct symbol_cache): Add destructor and
9986 initializers.
9987 (symbol_cache_key): Move. Change type.
9988 (make_symbol_cache, free_symbol_cache): Remove.
9989 (get_symbol_cache): Update.
9990 (symbol_cache_cleanup): Remove.
9991 (ALL_PSPACES, symbol_cache_flush)
9992 (maintenance_print_symbol_cache)
9993 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9994 Update.
9995
a32ad8c5
TT
99962019-05-08 Tom Tromey <tom@tromey.com>
9997
9998 * symtab.c (struct main_info): Add destructor and initializers.
9999 (main_progspace_key): Move. Change type.
10000 (get_main_info): Update.
10001 (main_info_cleanup): Remove.
10002 (_initialize_symtab): Update.
10003
5f6e90a0
TT
100042019-05-08 Tom Tromey <tom@tromey.com>
10005
10006 * registry.h (DECLARE_REGISTRY): Define the _key class.
10007
1bd0c6e4
AB
100082019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10009
10010 * NEWS: Merge two 'New commands' sections.
10011
2228ef77
XR
100122019-05-08 Joel Brobecker <brobecker@adacore.com>
10013
10014 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10015 parameter and use Ada language definition instead.
10016 (ada_val_print_ptr): Remove unused language parameter.
10017 (ada_val_print_num): Remove language parameter and use Ada language
10018 definition instead.
10019 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10020 parameter.
10021 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10022 parameter and use Ada language definition instead.
10023 (ada_val_print_1): Update all ada_val_print_xxx calls.
10024 Remove language parameter.
10025 (ada_val_print): Update ada_val_print_1 call.
10026
60fcc1c3
TT
100272019-05-08 Tom Tromey <tromey@adacore.com>
10028
10029 * remote.c (remote_hw_watchpoint_limit)
10030 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10031 Now static.
10032
ed2b7c17
TT
100332019-05-08 Tom Tromey <tromey@adacore.com>
10034
10035 * maint.c (_initialize_maint_cmds): Move initialization code to
10036 remote.c.
10037 (watchdog, show_watchdog): Move to remote.c.
10038 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10039 "watchdog" static.
10040 (_initialize_remote): Move initialization code from maint.c.
10041 * defs.h (watchdog): Don't declare.
10042
b0be6c91
TT
100432019-05-08 Tom Tromey <tromey@adacore.com>
10044
10045 * tui/tui-interp.c: Include main.h.
10046 * interps.c: Include main.h.
10047 * main.h (interpreter_p): Declare.
10048 * defs.h (interpreter_p): Don't declare.
10049
587ee17b
TT
100502019-05-08 Tom Tromey <tromey@adacore.com>
10051
10052 * dwarf2loc.c: Include dwarf2read.h.
10053 * defs.h (read_unsigned_leb128): Don't declare.
10054 * dwarf2read.h (read_unsigned_leb128): Declare.
10055
ca1df239
TT
100562019-05-08 Tom Tromey <tromey@adacore.com>
10057
10058 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10059 method.
10060
99f20f08
TT
100612019-05-08 Tom Tromey <tromey@adacore.com>
10062
10063 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10064 when no wrap column is set.
10065
80e55b13
TT
100662019-05-08 Tom Tromey <tromey@adacore.com>
10067
10068 * c-lang.c (c_get_string): Handle non-C-style arrays.
10069
9d3421af
TT
100702019-05-08 Tom Tromey <tromey@adacore.com>
10071
10072 * typeprint.c (print_offset_data::update): Print the bit offset,
10073 not the number of bits remaining.
10074
844333e2
TT
100752019-05-08 Tom Tromey <tromey@adacore.com>
10076
10077 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10078 padding at end of comment.
10079
988915ee
TT
100802019-05-08 Tom Tromey <tromey@adacore.com>
10081
10082 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10083 Compare main types.
10084
26bfd823
TT
100852019-05-06 Tom Tromey <tom@tromey.com>
10086
10087 * common/scoped_mmap.c: Include common-defs.h.
10088 * common/scoped_mmap.h: Don't include config.h.
10089
89055eaa
TT
100902019-05-04 Tom Tromey <tom@tromey.com>
10091
10092 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10093 (struct aarch64_call_info): Add initializers.
10094 <si>: Now a std::vector.
10095 (pass_on_stack, aarch64_push_dummy_call): Update.
10096
5da01df5
TT
100972019-05-04 Simon Marchi <simon.marchi@efficios.com>
10098 Tom Tromey <tom@tromey.com>
10099
10100 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10101 (ppc_threads): Now a std::vector. Now static.
10102 (hwdebug_find_thread_points_by_tid)
10103 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10104 Update.
10105
fbdf05a1
TT
101062019-05-04 Tom Tromey <tom@tromey.com>
10107
10108 * arc-tdep.c (arc_tdesc_init): Return bool.
10109
06d16ec9
TT
101102019-05-04 Tom Tromey <tom@tromey.com>
10111
10112 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10113 Use gdb_assert_not_reached.
10114
9c056022
TT
101152019-05-04 Tom Tromey <tom@tromey.com>
10116
10117 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10118 "false".
10119
fa9c2a59
TT
101202019-05-04 Tom Tromey <tom@tromey.com>
10121
10122 * arc-tdep.c (arc_tdesc_init): Use bool.
10123
e2eb806a
TT
101242019-05-04 Tom Tromey <tom@tromey.com>
10125
10126 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10127
6fe87677
TT
101282019-05-04 Tom Tromey <tom@tromey.com>
10129
10130 * cli/cli-cmds.c (valid_command_p): Return bool.
10131
7f008c9e
TT
101322019-05-04 Tom Tromey <tom@tromey.com>
10133
10134 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10135 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10136
b6484282
RT
101372019-05-04 Raul Tambre <raul@tambre.ee>
10138
10139 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10140 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10141 operator for comparison.
10142
af97b416
TT
101432019-05-04 Tom Tromey <tom@tromey.com>
10144
10145 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10146 (lookup_partial_symbol, print_partial_symbols)
10147 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10148 (psymbol_compare): Update.
10149 (add_psymbol_to_bcache): Clear the entire psymbol.
10150 (maintenance_check_psymtabs): Update.
10151 * psympriv.h (struct partial_symbol): Don't derive from
10152 general_symbol_info.
10153 <obj_section, unrelocated_address, address,
10154 set_unrelocated_address>: Update.
10155 <ginfo>: New member.
10156 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10157 (debug_names::write_psymbols): Update.
10158
9d6d4be8
TV
101592019-05-04 Tom de Vries <tdevries@suse.de>
10160
10161 * contrib/cc-with-tweaks.sh: Support -n arg.
10162
66452beb
PW
101632019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10164
10165 * corelow.c (core_target::detach): Ensure frame cache and
10166 register caches are cleared.
10167 inferior.c (exit_inferior_1): Likewise.
10168
bde09ab7
TT
101692019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10170 Tom Tromey <tom@tromey.com>
10171
10172 * dictionary.c (collate_pending_symbols_by_language): Remove
10173 "struct" from foreach.
10174 * symtab.c (lookup_global_symbol_from_objfile)
10175 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10176 foreach.
10177 * ser-tcp.c (net_open): Remove "struct" from foreach.
10178 * objfiles.c (objfile_relocate, objfile_rebase)
10179 (objfile_has_symbols): Remove "struct" from foreach.
10180 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10181 from foreach.
10182 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10183 foreach.
10184 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10185 "struct" from foreach.
10186 * ada-lang.c (create_excep_cond_exprs)
10187 (ada_exception_catchpoint_cond_string): Remove "struct" from
10188 foreach.
10189
222a8d25
TT
101902019-05-03 Tom Tromey <tromey@adacore.com>
10191
10192 * ada-exp.y (convert_char_literal): Check suffix of each
10193 enumerator.
10194
fcd60b84
DP
101952019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10196
10197 PR ada/21406:
10198 * ada-exp.y (yywrap): Don't define.
10199 * ada-lex.l (%option): Add noyywrap
10200 (yywrap): Remove.
10201
5f2459c2
EZ
102022019-05-03 Eli Zaretskii <eliz@gnu.org>
10203
353ea2d1
EZ
10204 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10205 _WIN32_WINNT to the XP level, unless already defined to a higher
10206 level.
10207
10208 * unittests/parse-connection-spec-selftests.c:
10209 * ser-tcp.c:
10210 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10211 override.
10212
5f2459c2
EZ
10213 * symfile.c (find_separate_debug_file): Remove colon from the
10214 drive spec of DOS/Windows file names of the target, so that the
10215 file name produced from DEBUGDIR and the target's directory will
10216 be valid on DOS/Windows systems.
10217
80062eb9
AB
102182019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10219
10220 * rust-lang.c (val_print_struct): Handle printing structures
10221 containing strings.
10222
b8c05e85
TT
102232019-05-02 Tom Tromey <tromey@adacore.com>
10224
10225 * valarith.c (_initialize_valarith): Remove.
10226
4504bbde
TT
102272019-05-01 Tom Tromey <tromey@adacore.com>
10228
10229 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10230 bitfields.
10231
d48e62f4
TT
102322019-05-01 Tom Tromey <tromey@adacore.com>
10233
10234 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10235 for big-endian copies.
10236
15f18d14
AT
102372019-04-30 Ali Tamur <tamur@google.com>
10238 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10239 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10240 (read_3_bytes): New function.
10241
ab4ee614
JB
102422019-04-30 Joel Brobecker <brobecker@adacore.com>
10243
10244 * windows-nat.c (main_thread_id): Delete.
10245 (handle_output_debug_string): Replace main_thread_id by
10246 current_event.dwThreadId.
10247 (fake_create_process): Likewise.
10248 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10249 Do not set main_thread_id.
10250 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10251 current_event.dwThreadId.
10252 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10253
8ed5b76e
JB
102542019-04-30 Joel Brobecker <brobecker@adacore.com>
10255
10256 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10257 Use current_event.dwThreadId instead of main_thread_id.
10258
2ff0a947
TT
102592019-04-30 Tom Tromey <tromey@adacore.com>
10260
10261 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10262 (create_excep_cond_exprs): Iterate over program spaces.
10263 (ada_exception_catchpoint_cond_string): Examine all minimal
10264 symbols for exception types.
10265
a776957c
TT
102662019-04-30 Tom Tromey <tromey@adacore.com>
10267
10268 PR c++/24470:
10269 * dwarf2read.c (process_structure_scope): Handle case where type
10270 has template parameters but no symbol was created.
10271
bc68014d
AB
102722019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10273 Chris January <chris.january@arm.com>
10274
10275 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10276 qualifier.
10277 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10278
f1fdc960
AB
102792019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10280
10281 * f-typeprint.c (f_print_type): Update rules for printing
10282 whitespace.
10283 (f_type_print_varspec_suffix): Likewise.
10284
bf7a4de1
AB
102852019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10286 Chris January <chris.january@arm.com>
10287
10288 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10289 function arguments.
10290
bbe75b9d
AB
102912019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10292
10293 * f-lang.c (build_fortran_types): Change name of void type to
10294 lower case.
10295 * f-typeprint.c (f_type_print_base): Print the name of the void
10296 type, rather than a fixed string.
10297 * f-valprint.c (f_decorations): Use lower case void string.
10298
1db455a7
AB
102992019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10300 Chris January <chris.january@arm.com>
10301
10302 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10303 types for Fortran.
10304
b6d03bb2
AB
103052019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10306 Chris January <chris.january@arm.com>
10307 David Lecomber <david.lecomber@arm.com>
10308
10309 * f-exp.y (BINOP_INTRINSIC): New token.
10310 (exp): New parser rule handling BINOP_INTRINSIC.
10311 (f77_keywords): Add new builtin procedures.
10312 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10313 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10314 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10315 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10316 (print_unop_subexp_f): New function.
10317 (print_binop_subexp_f): New function.
10318 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10319 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10320 (dump_subexp_body_f): Likewise.
10321 (operator_check_f): Likewise.
10322 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10323 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10324
83228e93
AB
103252019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10326
10327 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10328 UNOP_KIND.
10329 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10330 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10331 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10332 (operator_length_f): New fuction.
10333 (print_subexp_f): New function.
10334 (op_name_f): New function.
10335 (dump_subexp_body_f): New function.
10336 (operator_check_f): New function.
10337 (exp_descriptor_f): Replace standard expression handling functions
10338 with new functions.
10339 * gdb/fortran-operator.def: New file.
10340 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10341 * gdb/std-operator.def: Remove UNOP_KIND.
10342
6fdcd7cc
AB
103432019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10344
10345 * std-operator.def: Remove unbalanced, stray double quote
10346 character.
10347
2e62ab40
AB
103482019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10349 Chris January <chris.january@arm.com>
10350 Daniel Everett <daniel.everett@arm.com>
10351 Nick Forrington <nick.forrington@arm.com>
10352 Richard Bunt <richard.bunt@arm.com>
10353
10354 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10355 of depth when printing anonymous structs or unions.
10356 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10357 Don't print either the top-level value, or the children if the
10358 max-depth is exceeded.
10359 (ppscm_print_children): When printing the key of a map, allow one
10360 extra level of depth.
10361 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10362 print either the top-level value, or the children if the max-depth
10363 is exceeded.
10364 (print_children): When printing the key of a map, allow one extra
10365 level of depth.
10366 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10367 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10368 (user_print_options): Initialise max_depth field.
10369 (val_print_scalar_or_string_type_p): New function.
10370 (val_print): Check to see if the max depth has been reached.
10371 (val_print_check_max_depth): Define new function.
10372 (show_print_max_depth): New function.
10373 (_initialize_valprint): Add 'print max-depth' option.
10374 * valprint.h (struct value_print_options) <max_depth>: New field.
10375 (val_print_check_max_depth): Declare new function.
10376 * NEWS: Document new feature.
10377
4be290b2
AB
103782019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10379
10380 * ada-lang.c (ada_language_defn): Initialise new field.
10381 * c-lang.c (c_is_string_type_p): New function.
10382 (c_language_defn): Initialise new field.
10383 (cplus_language_defn): Initialise new field.
10384 (asm_language_defn): Initialise new field.
10385 (minimal_language_defn): Initialise new field.
10386 * c-lang.h (c_is_string_type_p): Declare new function.
10387 * d-lang.c (d_language_defn): Initialise new field.
10388 * f-lang.c (f_is_string_type_p): New function.
10389 (f_language_defn): Initialise new field.
10390 * go-lang.c (go_is_string_type_p): New function.
10391 (go_language_defn): Initialise new field.
10392 * language.c (default_is_string_type_p): New function.
10393 (unknown_language_defn): Initialise new field.
10394 (auto_language_defn): Initialise new field.
10395 * language.h (struct language_defn) <la_is_string_type_p>: New
10396 member variable.
10397 (default_is_string_type_p): Declare new function.
10398 * m2-lang.c (m2_language_defn): Initialise new field.
10399 * objc-lang.c (objc_language_defn): Initialise new field.
10400 * opencl-lang.c (opencl_language_defn): Initialise new field.
10401 * p-lang.c (pascal_is_string_type_p): New function.
10402 (pascal_language_defn): Initialise new field.
10403 * rust-lang.c (rust_is_string_type_p): New function.
10404 (rust_language_defn): Initialise new field.
10405
721b08c6
AB
104062019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10407
10408 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10409 New field.
10410 * ada-lang.c (ada_language_defn): Initialise new field.
10411 * c-lang.c (c_language_defn): Likewise.
10412 (cplus_language_defn): Likewise.
10413 (asm_language_defn): Likewise.
10414 (minimal_language_defn): Likewise.
10415 * d-lang.c (d_language_defn): Likewise.
10416 * f-lang.c (f_language_defn): Likewise.
10417 * go-lang.c (go_language_defn): Likewise.
10418 * language.c (unknown_language_defn): Likewise.
10419 (auto_language_defn): Likewise.
10420 * m2-lang.c (m2_language_defn): Likewise.
10421 * objc-lang.c (objc_language_defn): Likewise.
10422 * opencl-lang.c (opencl_language_defn): Likewise.
10423 * p-lang.c (pascal_language_defn): Likewise.
10424 * rust-lang.c (rust_language_defn): Likewise.
10425
fc913e53
AB
104262019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10427
10428 * ada-lang.c (ada_is_character_type): Change return type to bool.
10429 (ada_is_string_type): Likewise.
10430 * ada-lang.h (ada_is_character_type): Update declaration
10431 (ada_is_string_type): Likewise.
10432
fa731fa0
PW
104332019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10434
10435 Support style in 'frame|thread apply'
10436
10437 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10438 * record.c (record_start, record_stop): Update callers of
10439 execute_command_to_string with false.
10440 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10441 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10442 methods.
10443 (class string_file): New constructor with term_out parameter.
10444 Override methods term_out and can_emit_style_escape. New member
10445 term_out.
10446 (class stdio_file): Override can_emit_style_escape.
10447 (class tee_file): Override term_out and can_emit_style_escape.
10448 * utils.h (can_emit_style_escape): Remove.
10449 * utils.c (can_emit_style_escape): Likewise.
10450 Update all callers of can_emit_style_escape (SOMESTREAM) to
10451 SOMESTREAM->can_emit_style_escape.
10452 * source-cache.c (source_cache::get_source_lines): Likewise.
10453 * stack.c (frame_apply_command_count): Call execute_command_to_string
10454 passing the term_out characteristic of the current gdb_stdout.
10455 * thread.c (thr_try_catch_cmd): Likewise.
10456 * top.c (execute_command_to_string): pass term_out parameter
10457 to construct the string_file for the command output.
10458 * ui-file.c (term_cli_styling): New function (most code moved
10459 from utils.c can_emit_style_escape).
10460 (string_file::string_file, string_file::can_emit_style_escape,
10461 stdio_file::can_emit_style_escape, tee_file::term_out,
10462 tee_file::can_emit_style_escape): New functions.
10463
136afab8
PW
104642019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10465
10466 * NEWS: Mention the new set|show may-call-functions.
10467 * infcall.c (may_call_functions_p): New variable.
10468 (show_may_call_functions_p): New function.
10469 (call_function_by_hand_dummy): Throws an error if not
10470 may-call-functions.
10471 (_initialize_infcall): Call add_setshow_boolean_cmd for
10472 may-call-functions.
10473
725cbb63
KS
104742019-04-25 Keith Seitz <keiths@redhat.com>
10475
10476 PR c++/24367
10477 * cp-support.c (inspect_type): Don't attempt substitutions
10478 of symbol with the same name.
10479
3d1cbb78
TT
104802019-04-25 Tom Tromey <tromey@adacore.com>
10481
10482 PR gdb/24475:
10483 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10484 static.
10485
94aeb44b
TT
104862019-04-25 Tom Tromey <tromey@adacore.com>
10487
10488 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10489 rvalue reference.
10490 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10491 (gdb_xml_parser::parse): Use std::move.
10492 * python/python-internal.h (gdbpy_convert_exception): Take a const
10493 reference.
10494 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10495 std::move.
10496 * python/py-utils.c (gdbpy_convert_exception): Take a const
10497 reference.
10498 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10499 Use std::move.
10500 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10501 Use std::move.
10502 * mi/mi-main.c (mi_print_exception): Take a const reference.
10503 * main.c (handle_command_errors): Take a const reference.
10504 * linespec.c (parse_linespec): Use std::move.
10505 * infcall.c (run_inferior_call): Use std::move.
10506 (call_function_by_hand_dummy): Use std::move.
10507 * exec.c (try_open_exec_file): Use std::move.
10508 * exceptions.h (exception_print, exception_fprintf)
10509 (exception_print_same): Update.
10510 * exceptions.c (print_exception, exception_print)
10511 (exception_fprintf, exception_print_same): Change parameters to
10512 const reference.
10513 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10514 * common/new-op.c: Use std::move.
10515 * common/common-exceptions.h (struct gdb_exception): Add move
10516 constructor.
10517 (struct gdb_exception_error, struct gdb_exception_quit, struct
10518 gdb_quit_bad_alloc): Change constructor to move constructor.
10519 (throw_exception): Change parameter to rvalue reference.
10520 * common/common-exceptions.c (throw_exception): Take rvalue
10521 reference.
10522 * cli/cli-interp.c (safe_execute_command): Use std::move.
10523 * breakpoint.c (insert_bp_location, location_to_sals): Use
10524 std::move.
10525
680d7fd5
TT
105262019-04-25 Tom Tromey <tromey@adacore.com>
10527
10528 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10529 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10530 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10531 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10532 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10533 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10534 guile/scm-value.c: Use unpack.
10535 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10536 gdbscm_gdb_exception.
10537 (gdbscm_throw_gdb_exception): Likewise.
10538 (struct gdbscm_gdb_exception): New.
10539 (unpack): New function.
10540 (gdbscm_wrap): Use unpack.
10541
c6fdd8b2
TT
105422019-04-25 Tom Tromey <tromey@adacore.com>
10543
10544 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10545 (gdb_rl_callback_handler): Use std::move.
10546 * common/common-exceptions.h (struct gdb_exception): Add move
10547 assignment operator.
10548 (throw_exception_sjlj): Change "exception" to const reference.
10549 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10550 (throw_exception_sjlj): Change "exception" to const reference.
10551
cc06b668
TT
105522019-04-25 Tom Tromey <tromey@adacore.com>
10553
10554 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10555 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10556 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10557 Update.
10558 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10559 Update.
10560 * mi/mi-interp.c (mi_interp::exec): Update.
10561 * linespec.c (parse_linespec): Update.
10562 * infcall.c (run_inferior_call): Update.
10563 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10564 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10565 (gdbscm_lookup_global_symbol): Update.
10566 * guile/scm-param.c (gdbscm_parameter_value): Update.
10567 * guile/scm-frame.c (gdbscm_frame_read_register)
10568 (gdbscm_frame_read_var): Update.
10569 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10570 * exec.c (try_open_exec_file): Update.
10571 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10572 (gdb_rl_callback_handler): Update.
10573 * common/common-exceptions.h (exception_none): Don't declare.
10574 * common/common-exceptions.c (exception_none): Don't define.
10575 (struct catcher) <exception>: Update.
10576 * cli/cli-interp.c (safe_execute_command): Update.
10577 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10578
cf532bd1
AT
105792019-04-25 Ali Tamur <tamur@google.com>
10580
10581 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10582 (read_attribute_value): Likewise.
10583 (dwarf2_read_addr_index): Update comment.
10584 (read_str_index): Add DW_FORM_strx.
10585 (dwarf2_string_attr): Likewise.
10586 (dwarf2_const_value_attr): Likewise.
10587 (dump_die_shallow): Likewise.
10588 (dwarf2_fetch_constant_bytes): Likewise.
10589 (skip_form_bytes): Likewise.
10590 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10591
82433e3e
SDJ
105922019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10593
10594 PR corefiles/11608
10595 PR corefiles/18187
10596 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10597 OFFSET. Verify if current mapping contains an ELF header.
10598 (linux_find_memory_regions_full): Adjust call to
10599 dump_mapping_p.
10600
723adb65
SL
106012019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10602 Kang Li <kanglictf@gmail.com>
10603
10604 PR gdb/21600
10605
10606 * dwarf2-frame.c (read_initial_length): Be consistent about using
10607 unsigned representation of length.
10608 (decode_frame_entry_1): Likewise. Check for wraparound of
10609 end pointer as well as buffer overflow.
10610
596179f7
SDJ
106112019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10612
10613 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10614 "vq".
10615
a59240a4
TT
106162019-04-24 Tom Tromey <tromey@adacore.com>
10617
10618 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10619
f872fdbb
AB
106202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10621
10622 * s12z-tdep.c (s12z_unwind_pc): Delete.
10623 (s12z_unwind_sp): Delete.
10624 (s12z_gdbarch_init): Don't register deleted functions with
10625 gdbarch.
10626
b614e6f3
AB
106272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10628
10629 * rl78-tdep.c (rl78_unwind_sp): Delete.
10630 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10631
14faed38
AB
106322019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10633
10634 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10635 (xstormy16_unwind_pc): Delete.
10636 (xstormy16_dummy_id): Delete.
10637 (xstormy16_gdbarch_init): Don't register deleted functions with
10638 gdbarch.
10639
541aad8a
AB
106402019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10641
10642 * vax-tdep.c (vax_unwind_pc): Delete.
10643 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10644
29222070
AB
106452019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10646
10647 * v850-tdep.c (v850_unwind_sp): Delete.
10648 (v850_unwind_pc): Delete.
10649 (v850_dummy_id): Delete.
10650 (v850_gdbarch_init): Don't register deleted functions with
10651 gdbarch.
10652
0f534d76
AB
106532019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10654
10655 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10656 (tilegx_unwind_pc): Delete.
10657 (tilegx_unwind_dummy_id): Delete.
10658 (tilegx_gdbarch_init): Don't register deleted functions with
10659 gdbarch.
10660
1ba7b7f9
AB
106612019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10662
10663 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10664 (tic6x_dummy_id): Delete.
10665 (tic6x_gdbarch_init): Don't register deleted functions with
10666 gdbarch.
10667
d31f262c
AB
106682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10669
10670 * sparc-tdep.c (sparc_unwind_pc): Delete.
10671 (sparc32_gdbarch_init): Don't register deleted function with
10672 gdbarch.
10673
6d14d64d
AB
106742019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10675
10676 * sh-tdep.c (sh_unwind_sp): Delete.
10677 (sh_unwind_pc): Delete.
10678 (sh_dummy_id): Delete.
10679 (sh_gdbarch_init): Don't register deleted functions with
10680 gdbarch.
10681
a40dde9d
AB
106822019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10683
10684 * score-tdep.c (score_unwind_sp): Delete.
10685 (score_unwind_pc): Delete.
10686 (score_dummy_id): Delete.
10687 (score_gdbarch_init): Don't register deleted functions with
10688 gdbarch.
10689
47c47d69
AB
106902019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10691
10692 * rx-tdep.c (rx_unwind_pc): Delete.
10693 (rx_unwind_sp): Delete.
10694 (rx_dummy_id): Delete.
10695 (rx_gdbarch_init): Don't register deleted functions with
10696 gdbarch. Update comment.
10697
833a4480
AB
106982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10699
10700 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10701 (rs6000_dummy_id): Delete.
10702 (rs6000_gdbarch_init): Don't register deleted functions with
10703 gdbarch.
10704
3f2cef49
AB
107052019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10706
10707 * or1k-tdep.c (or1k_dummy_id): Delete.
10708 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10709
96acf884
AB
107102019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10711
10712 * nios2-tdep.c (nios2_dummy_id): Delete.
10713 (nios2_unwind_sp): Delete.
10714 (nios2_gdbarch_init): Don't register deleted functions with
10715 gdbarch.
10716
ca0ab0aa
AB
107172019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10718
10719 * nds32-tdep.c (nds32_dummy_id): Delete.
10720 (nds32_unwind_pc): Delete.
10721 (nds32_unwind_sp): Delete.
10722 (nds32_gdbarch_init): Don't register deleted functions with
10723 gdbarch.
10724
c8259044
AB
107252019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10726
10727 * msp430-tdep.c (msp430_unwind_pc): Delete.
10728 (msp430_unwind_sp): Delete.
10729 (msp430_dummy_id): Delete.
10730 (msp430_gdbarch_init): Don't register deleted functions with
10731 gdbarch.
10732
27f113c8
AB
107332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10734
10735 * moxie-tdep.c (moxie_unwind_sp): Delete.
10736 (moxie_unwind_pc): Delete.
10737 (moxie_dummy_id): Delete.
10738 (moxie_gdbarch_init): Don't register deleted functions with
10739 gdbarch.
10740
aee6c3cd
AB
107412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10742
10743 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10744 (mn10300_unwind_pc): Delete.
10745 (mn10300_unwind_sp): Delete.
10746 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10747 mn10300_unwind_sp.
10748 (mn10300_frame_unwind_init): Don't register deleted functions with
10749 gdbarch.
10750
8e2b5aea
AB
107512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10752
10753 * mep-tdep.c (mep_unwind_pc): Delete.
10754 (mep_unwind_sp): Delete.
10755 (mep_dummy_id): Delete.
10756 (mep_gdbarch_init): Don't register deleted functions with
10757 gdbarch.
10758
43cf3ede
AB
107592019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10760
10761 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10762 (m68hc11_unwind_sp): Delete.
10763 (m68hc11_gdbarch_init): Don't register deleted functions with
10764 gdbarch.
10765
5e79b7bb
AB
107662019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10767
10768 * m32r-tdep.c (m32r_unwind_sp): Delete.
10769 (m32r_unwind_pc): Delete.
10770 (m32r_dummy_id): Delete.
10771 (m32r_gdbarch_init): Don't register deleted functions with
10772 gdbarch.
10773
89b268d8
AB
107742019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10775
10776 * m32c-tdep.c (m32c_unwind_pc): Delete.
10777 (m32c_unwind_sp): Delete.
10778 (m32c_dummy_id): Delete.
10779 (m32c_gdbarch_init): Don't register deleted functions with
10780 gdbarch.
10781
946c28d2
AB
107822019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10783
10784 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10785 (lm32_unwind_pc): Delete.
10786 (lm32_dummy_id): Delete.
10787 (lm32_gdbarch_init): Don't register deleted functions with
10788 gdbarch.
10789
bf12844a
AB
107902019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10791
10792 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10793 (iq2000_unwind_pc): Delete.
10794 (iq2000_dummy_id): Delete.
10795 (iq2000_gdbarch_init): Don't register deleted functions with
10796 gdbarch.
10797
ecbc06d2
AB
107982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10799
10800 * nds32-tdep.c (nds32_type_align): Delete.
10801 (nds32_push_dummy_call): Use type_align instead.
10802
030197b4
AB
108032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10804
10805 * arm-tdep.c (arm_type_align): Only handle vector override case.
10806 (arm_push_dummy_call): Use type_align.
10807 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10808
b907456c
AB
108092019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10810
10811 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10812 case.
10813 (pass_on_stack): Use type_align.
10814 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10815 function.
10816
9e97ba43
TT
108172019-04-23 Tom Tromey <tromey@adacore.com>
10818
10819 * dwarf2read.c (line_header::file_name_at): Remove unused
10820 overload.
10821
6892f601
TV
108222019-04-23 Tom de Vries <tdevries@suse.de>
10823
10824 PR gdb/24438
10825 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10826 invocation.
10827
336d760d
AT
10828
108292019-03-27 Ali Tamur <tamur@google.com>
10830
10831 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10832 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10833 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10834 (dwarf_expr_context::get_addr_index): Likewise
10835 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10836 (symbol_needs_eval_context::get_addr_index): Likewise
10837 (disassemble_dwarf_expression): Add DW_OP_addrx
10838 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10839 (read_cutu_die_from_dwo): Update comment
10840 (skip_one_die): Add DW_FORM_addrx
10841 (read_attribute_value): Likewise
10842 (var_decode_location): Add DW_OP_addrx
10843 (dwarf2_const_value_attr): Add DW_FORM_addrx
10844 (dump_die_shallow): Likewise
10845 (dwarf2_fetch_constant_bytes): Likewise
10846 (decode_locdesc): Add DW_OP_addrx
10847 (skip_form_bytes): Add DW_FORM_addrx
10848
ad9d13f8
AT
108492019-04-22 Ali Tamur <tamur@google.com>
10850
10851 * MAINTAINERS (Write After Approval): Add self.
10852
d70cc3ba
SM
108532019-04-22 Simon Marchi <simon.marchi@efficios.com>
10854
10855 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10856 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10857 (open_symbol_file_object): Likewise.
10858 (svr4_default_sos): Add info parameter.
10859 (svr4_read_so_list): Likewise.
10860 (svr4_current_sos_direct): Adjust functions calls to pass down
10861 info.
10862 (svr4_current_sos_1): Add info parameter.
10863 (svr4_current_sos): Call get_svr4_info, pass info down to
10864 svr4_current_sos_1.
10865 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10866 get_svr4_info.
10867 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10868 get_svr4_info.
10869 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10870 to get_svr4_info.
10871 (probes_table_remove_objfile_probes): Likewise.
10872 (register_solib_event_probe): Add info parameter.
10873 (solist_update_incremental): Pass info parameter down to
10874 svr4_read_so_list.
10875 (disable_probes_interface): Add info parameter.
10876 (svr4_handle_solib_event): Pass current_program_space to
10877 get_svr4_info. Adjust disable_probes_interface cleanup.
10878 (svr4_create_probe_breakpoints): Add info parameter, pass it
10879 down to register_solib_event_probe.
10880 (svr4_create_solib_event_breakpoints): Add info parameter,
10881 pass it down to svr4_create_probe_breakpoints.
10882 (enable_break): Pass info down to
10883 svr4_create_solib_event_breakpoints.
10884 (svr4_solib_create_inferior_hook): Pass current_program_space to
10885 get_svr4_info.
10886 (svr4_clear_solib): Likewise.
10887
7905fc35
PA
108882019-04-22 Pedro Alves <palves@redhat.com>
10889
10890 * solib-svr4.c (svr4_free_objfile_observer): New.
10891 (probe_and_action::objfile): New field.
10892 (probes_table_htab_remove_objfile_probes)
10893 (probes_table_remove_objfile_probes): New functions.
10894 (register_solib_event_probe): Add 'objfile' parameter. Store it
10895 in the new probe_and_action. Don't store the probe in 'lookup'.
10896 (svr4_create_probe_breakpoints): Pass objfile to
10897 register_solib_event_probe.
10898 (_initialize_svr4_solib): Register a free_objfile observer.
10899
fb881986
TT
109002019-04-19 Tom Tromey <tom@tromey.com>
10901
10902 * common/queue.h: Remove.
10903
8732db6c
TT
109042019-04-19 Tom Tromey <tom@tromey.com>
10905
10906 * event-loop.c: Don't include "common/queue.h".
10907
97dfbadd
TT
109082019-04-19 Tom Tromey <tom@tromey.com>
10909
10910 * remote.c (remote_target): Use delete.
10911 * remote-notif.h: Include <list>, not "common/queue.h".
10912 (notif_client_p): Remove typedef.
10913 (remote_notif_state): Add constructor, destructor, initializer.
10914 <notif_queue>: Now a std::list.
10915 (remote_notif_state_xfree): Don't declare.
10916 * remote-notif.c (remote_notif_process, handle_notification)
10917 (remote_notif_state_allocate): Update.
10918 (~remote_notif_state): Rename from remote_notif_state_xfree.
10919
cf250e36
TT
109202019-04-19 Tom Tromey <tom@tromey.com>
10921
10922 * symfile.c (reread_symbols): Update.
10923 * objfiles.c (objfile_register_static_link)
10924 (objfile_lookup_static_link): Update
10925 (~objfile) Don't delete static_links.
10926 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10927
61f4b350
TT
109282019-04-19 Tom Tromey <tom@tromey.com>
10929
10930 * type-stack.h (struct type_stack) <insert>: Constify string.
10931 * type-stack.c (type_stack::insert): Constify string.
10932 * gdbtypes.h (lookup_template_type): Update.
10933 (address_space_name_to_int): Update.
10934 * gdbtypes.c (address_space_name_to_int): Make space_identifier
10935 const.
10936 (lookup_template_type): Make name const.
10937 * c-exp.y: Update rules.
10938 (lex_one_token, classify_name, classify_inner_name)
10939 (c_print_token): Update.
10940 * p-exp.y: Update rules.
10941 (yylex): Update.
10942 * f-exp.y: Update rules.
10943 (yylex): Update.
10944 * d-exp.y: Update rules.
10945 (lex_one_token, classify_name, classify_inner_name): Update.
10946 * parse.c (write_dollar_variable, copy_name): Return std::string.
10947 * parser-defs.h (copy_name): Change return type.
10948 * m2-exp.y: Update rules.
10949 (yylex): Update.
10950 * go-exp.y (lex_one_token): Update.
10951 Update rules.
10952 (classify_unsafe_function, classify_packaged_name)
10953 (classify_name, yylex): Update.
10954
189b8c2e
ST
109552019-04-19 Sergei Trofimovich <siarheit@google.com>
10956
10957 * configure.ac: add --enable-source-highlight switch.
10958 * configure: Regenerate.
10959 * top.c (print_gdb_version): plumb --enable-source-highlight
10960 status to "show configuration".
10961
8ecb59f8
TT
109622019-04-19 Tom Tromey <tromey@adacore.com>
10963
10964 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10965 Check ADA_TYPE_P.
10966 (empty_record, ada_template_to_fixed_record_type_1)
10967 (template_to_static_fixed_type)
10968 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10969 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10970 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10971 macros.
10972
62160ec9
TT
109732019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
10974
10975 PR symtab/24423:
10976 * source.c (print_source_lines_base): Advance "iter" when a
10977 control character is seen.
10978
f2ae8bc8
PW
109792019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10980
10981 * inferior.h (struct infcall_suspend_state_deleter):
10982 Catch exception in destructor to avoid crash.
10983
d563b953
PW
109842019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10985
10986 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10987 close to the add_com "shell".
10988
dc34c897
TT
109892019-04-18 Tom Tromey <tromey@adacore.com>
10990
10991 * process-stratum-target.h (class process_stratum_target)
10992 <stratum>: Add "final".
10993
a12e5744
TT
109942019-04-17 Tom Tromey <tromey@adacore.com>
10995
10996 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10997 against nullptr before use.
10998
a7e559cc
AH
109992019-04-17 Alan Hayward <alan.hayward@arm.com>
11000
11001 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11002
c01660c6
AB
110032019-04-17 Jim Wilson <jimw@sifive.com>
11004 Andrew Burgess <andrew.burgess@embecosm.com>
11005
11006 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11007 code read might fail, assume 4-byte breakpoint in that case.
11008
4aa866af
LS
110092019-04-15 Leszek Swirski <leszeks@google.com>
11010
11011 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11012 rather than a hand-rolled POD check when checking for forced MEMORY
11013 classification.
11014
48574d91
AH
110152019-04-15 Alan Hayward <alan.hayward@arm.com>
11016
11017 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11018 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11019 function.
11020 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11021 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11022 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11023 declaration.
11024
4da037ef
AH
110252019-04-15 Alan Hayward <alan.hayward@arm.com>
11026
11027 * aarch64-linux-nat.c
11028 (aarch64_linux_nat_target::thread_architecture): Add override.
11029 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11030 each VQ.
11031
ccb8d7e8
AH
110322019-04-15 Alan Hayward <alan.hayward@arm.com>
11033
11034 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11035
35add35e
AB
110362019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11037
11038 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11039 target types of size 96-bits, add some additional comments, and
11040 check that the builtin type we found was the correct size.
11041
51196bbc
EZ
110422019-04-12 Eli Zaretskii <eliz@gnu.org>
11043
11044 * utils.c (prompt_for_continue): Don't restore the styling at the
11045 end, as applied_style has the wrong value. This fixes styling in
11046 long lists of file names that are interrupted by the "Continue?"
11047 prompt.
11048
62253a61
AB
110492019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11050
11051 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11052 * c-lang.c (c_language_defn): Likewise.
11053 (cplus_language_defn): Likewise.
11054 (asm_language_defn): Likewise.
11055 (minimal_language_defn): Likewise.
11056 * d-lang.c (d_language_defn): Likewise.
11057 * f-lang.c (f_language_defn): Likewise.
11058 * go-lang.c (go_language_defn): Likewise.
11059 * language.c (unknown_language_defn): Likewise.
11060 (auto_language_defn): Likewise.
11061 * language.h (struct language_defn): Remove la_magic field.
11062 (LANG_MAGIC): Delete.
11063 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11064 * objc-lang.c (objc_language_defn): Likewise.
11065 * opencl-lang.c (opencl_language_defn): Likewise.
11066 * p-lang.c (pascal_language_defn): Likewise.
11067 * rust-lang.c (rust_language_defn): Likewise.
11068
a9158a86
AB
110692019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11070
11071 * riscv-tdep.c (riscv_type_align): New function.
11072 (riscv_type_alignment): Delete.
11073 (riscv_arg_location): Use 'type_align'.
11074 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11075
41077b66
AB
110762019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11077
11078 * gdbtypes.c (type_align): A struct with no non-static fields also
11079 has alignment of 1.
11080
9f0272f8
AB
110812019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11082
11083 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11084 component to 0.
11085 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11086 member.
11087 (riscv_struct_info::analyse): New implementation using new
11088 analyse_inner member function.
11089 (riscv_struct_info::field_offset): New member function.
11090 (riscv_struct_info::m_offsets): New member variable.
11091 (riscv_struct_info::analyse_inner): New private member function,
11092 takes the old implementation of riscv_struct_info::analyse but
11093 extended to track field offsets.
11094 (riscv_call_arg_struct): Update the struct folding special cases
11095 to handle cases where empty C++ structs, which are non-zero
11096 length, are found.
11097 (riscv_arg_location): Initialise the length of each location, a
11098 non-zero length now indicates the location is in use.
11099 (riscv_push_dummy_call): Allow for the first location having a
11100 non-zero offset when setting up arguments.
11101 (riscv_return_value): Likewise, but for return values.
11102
02cf60c7
TT
111032019-04-11 Tom Tromey <tromey@adacore.com>
11104
11105 * utils.c (internal_vproblem): Make "msg" const.
11106
68811f8f
AH
111072019-04-11 Alan Hayward <alan.hayward@arm.com>
11108
11109 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11110 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11111 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11112 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11113
3f52fdbc
KB
111142019-04-10 Kevin Buettner <kevinb@redhat.com>
11115
11116 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11117 function.
11118 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11119 of amd64_collect_native_gregset.
11120 (amd64_linux_nat_target::store_registers): Likewise.
11121
e9ad22ee
TT
111222019-04-10 Tom Tromey <tom@tromey.com>
11123
11124 * symtab.c (lookup_global_symbol_from_objfile)
11125 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11126 * objfiles.h (class separate_debug_iterator): New.
11127 (class separate_debug_range): New.
11128 (struct objfile) <separate_debug_objfiles>: New method.
11129 (objfile_separate_debug_iterate): Don't declare.
11130 * objfiles.c (separate_debug_iterator::operator++): Rename from
11131 objfile_separate_debug_iterate.
11132 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11133 iterator.
11134 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11135 iterator.
11136
ee371134
TT
111372019-04-10 Tom Tromey <tom@tromey.com>
11138
11139 * symfile.c (reread_symbols): Remove old comment.
11140 * objfiles.c (free_all_objfiles): Fix a typo.
11141
bf227d61
TT
111422019-04-10 Tom Tromey <tom@tromey.com>
11143
11144 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11145 * minsyms.c (lookup_minimal_symbol): Use foreach.
11146 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11147 (lookup_minimal_symbol_solib_trampoline): Likewise.
11148 * symfile.c (reread_symbols): Use foreach.
11149
8dc433a0
TT
111502019-04-09 Ivan Begert <ivanbegert@gmail.com>
11151 Tom Tromey <tromey@adacore.com>
11152
11153 PR rust/24414:
11154 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11155 (rust_lex_int_test): Change "value" to be LONGEST.
11156 (rust_lex_tests): Add test for long integer literal.
11157
9ab8741a
TT
111582019-04-09 Tom Tromey <tromey@adacore.com>
11159
11160 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11161 to bool.
11162 (extended_remote_target::attach): Update.
11163 (remote_target::remote_notice_new_inferior): Update.
11164 (remote_target::add_current_inferior_and_thread): Update.
11165 * inferior.c (exit_inferior_1): Use "false".
11166 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11167
e242fd12
SM
111682019-04-09 Simon Marchi <simon.marchi@efficios.com>
11169
9ca1957f 11170 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
11171 the "start" command.
11172
2b0c8b01
KB
111732019-04-08 Kevin Buettner <kevinb@redhat.com>
11174
11175 * python/py-inferior.c (infpy_thread_from_thread_handle):
11176 Adjust comments to reflect renaming of thread_from_thread_handle
11177 to thread_from_handle. Adjust keywords. Fix type error message.
11178 (inferior_object_methods): Add thread_from_handle. Retain
11179 thread_from_thread_handle, but mark it as deprecated.
11180
50a82723
KB
111812019-04-08 Kevin Buettner <kevinb@redhat.com>
11182
11183 * gdbthread.h (find_thread_by_handle): Revise declaration.
11184 * thread.c (find_thread_by_handle): Likewise. Adjust
11185 implementation too.
11186 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11187 support for buffer objects as handles.
11188
cf63b016
KB
111892019-04-08 Kevin Buettner <kevinb@redhat.com>
11190
11191 * python/py-infthread.c (thpy_thread_handle): New function.
11192 (thread_object_methods): Register thpy_thread_handle.
11193
3d6c6204
KB
111942019-04-08 Kevin Buettner <kevinb@redhat.com>
11195
11196 * gdbthread.h (thread_to_thread_handle): Declare.
11197 * thread.c (gdbtypes.h): Include.
11198 (thread_to_thread_handle): New function.
11199
11200 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11201 (target_thread_info_to_thread_handle): Declare.
11202 * target.c (target_thread_info_to_thread_handle): New function.
11203 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11204 * target-delegates.c: Regenerate.
11205
11206 * linux-thread-db.c (class thread_db_target): Add method
11207 thread_info_to_thread_handle.
11208 (thread_db_target::thread_info_to_thread_handle): Define.
11209 * remote.c (class remote_target): Add new method
11210 thread_info_to_thread_handle.
11211 (remote_target::thread_info_to_thread_handle): Define.
11212
56be6ea8
PA
112132019-04-08 Pedro Alves <palves@redhat.com>
11214
11215 * common/common-exceptions.c (throw_exception): Don't create
11216 named object to throw; throw directly.
11217 (throw_it): Likewise. Don't initialize gdb_exception::message
11218 here, with new; pass FMT and AP to the ctor instead.
11219 * common/common-exceptions.h: Include <string>.
11220 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11221 const char *, va_list)): New ctor. Use std::make_shared.
11222 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11223 errors)): Delete.
11224 (gdb_exception_error::gdb_exception_error(enum errors, const char
11225 *, va_list)): New.
11226 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11227 Add assertion.
11228 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11229 errors)): Delete.
11230 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11231 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11232 Add assertion.
11233
eedc3f4f
TT
112342019-04-08 Tom Tromey <tom@tromey.com>
11235
11236 * valops.c (value_rtti_indirect_type): Replace throw_exception
11237 with throw.
11238 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11239 with throw.
11240 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11241 throw.
11242 * target.c (target_translate_tls_address): Replace throw_exception
11243 with throw.
11244 * stack.c (frame_apply_command_count): Replace throw_exception
11245 with throw.
11246 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11247 throw.
11248 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11249 with throw.
11250 * rs6000-tdep.c (rs6000_frame_cache)
11251 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11252 * remote.c: Replace throw_exception with throw.
11253 * record-full.c (record_full_message, record_full_wait_1)
11254 (record_full_restore): Replace throw_exception with throw.
11255 * record-btrace.c:
11256 (get_thread_current_frame_id, record_btrace_start_replaying)
11257 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11258 (cmd_record_btrace_start): Replace throw_exception with throw.
11259 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11260 throw.
11261 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11262 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11263 * linespec.c:
11264 (find_linespec_symbols): Replace throw_exception with throw.
11265 * infrun.c (displaced_step_prepare, resume): Replace
11266 throw_exception with throw.
11267 * infcmd.c (post_create_inferior): Replace throw_exception with
11268 throw.
11269 * inf-loop.c (inferior_event_handler): Replace throw_exception
11270 with throw.
11271 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11272 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11273 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11274 (get_prev_frame_always, get_frame_pc_if_available)
11275 (get_frame_address_in_block_if_available, get_frame_language):
11276 Replace throw_exception with throw.
11277 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11278 throw_exception with throw.
11279 * eval.c (fetch_subexp_value, evaluate_var_value)
11280 (evaluate_funcall, evaluate_subexp_standard): Replace
11281 throw_exception with throw.
11282 * dwarf2loc.c (call_site_find_chain)
11283 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11284 Replace throw_exception with throw.
11285 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11286 with throw.
11287 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11288 throw.
11289 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11290 * completer.c (complete_line_internal): Replace throw_exception
11291 with throw.
11292 * compile/compile-object-run.c (compile_object_run): Replace
11293 throw_exception with throw.
11294 * cli/cli-script.c (process_next_line): Replace throw_exception
11295 with throw.
11296 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11297 (btrace_enable, btrace_maint_update_pt_packets): Replace
11298 throw_exception with throw.
11299 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11300 throw_exception with throw.
11301 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11302 throw_exception with throw.
11303 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11304 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11305 * aarch64-tdep.c (aarch64_make_prologue_cache)
11306 (aarch64_make_stub_cache): Replace throw_exception with throw.
11307
26003a20
TT
113082019-04-08 Tom Tromey <tom@tromey.com>
11309
11310 * common/common-exceptions.c (throw_exception): Rename from
11311 throw_exception_cxx. Remove old copy. Make argument const.
11312 (throw_it): Create and throw exception objects directly.
11313 * common/common-exceptions.h (throw_exception): Make argument
11314 const.
11315 (struct gdb_exception_error): Add constructor.
11316 (struct gdb_exception_quit): Add constructor.
11317
d272eb37
TT
113182019-04-08 Tom Tromey <tom@tromey.com>
11319
11320 * common/common-exceptions.h (exception_rethrow): Don't declare.
11321 (TRY_SJLJ): Update comment.
11322 (TRY, CATCH, END_CATCH): Remove.
11323 * common/common-exceptions.c (exception_rethrow): Remove.
11324
230d2906
TT
113252019-04-08 Tom Tromey <tom@tromey.com>
11326
11327 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11328 Remove.
11329 (gdb_exception_error): Rename from
11330 gdb_exception_RETURN_MASK_ERROR.
11331 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11332 (gdb_quit_bad_alloc): Update.
11333 * aarch64-tdep.c: Update.
11334 * ada-lang.c: Update.
11335 * ada-typeprint.c: Update.
11336 * ada-valprint.c: Update.
11337 * amd64-tdep.c: Update.
11338 * arch-utils.c: Update.
11339 * break-catch-throw.c: Update.
11340 * breakpoint.c: Update.
11341 * btrace.c: Update.
11342 * c-varobj.c: Update.
11343 * cli/cli-cmds.c: Update.
11344 * cli/cli-interp.c: Update.
11345 * cli/cli-script.c: Update.
11346 * common/common-exceptions.c: Update.
11347 * common/new-op.c: Update.
11348 * common/selftest.c: Update.
11349 * compile/compile-c-symbols.c: Update.
11350 * compile/compile-cplus-symbols.c: Update.
11351 * compile/compile-object-load.c: Update.
11352 * compile/compile-object-run.c: Update.
11353 * completer.c: Update.
11354 * corelow.c: Update.
11355 * cp-abi.c: Update.
11356 * cp-support.c: Update.
11357 * cp-valprint.c: Update.
11358 * darwin-nat.c: Update.
11359 * disasm-selftests.c: Update.
11360 * dtrace-probe.c: Update.
11361 * dwarf-index-cache.c: Update.
11362 * dwarf-index-write.c: Update.
11363 * dwarf2-frame-tailcall.c: Update.
11364 * dwarf2-frame.c: Update.
11365 * dwarf2loc.c: Update.
11366 * dwarf2read.c: Update.
11367 * eval.c: Update.
11368 * event-loop.c: Update.
11369 * event-top.c: Update.
11370 * exec.c: Update.
11371 * f-valprint.c: Update.
11372 * fbsd-tdep.c: Update.
11373 * frame-unwind.c: Update.
11374 * frame.c: Update.
11375 * gdbtypes.c: Update.
11376 * gnu-v3-abi.c: Update.
11377 * guile/guile-internal.h: Update.
11378 * guile/scm-block.c: Update.
11379 * guile/scm-breakpoint.c: Update.
11380 * guile/scm-cmd.c: Update.
11381 * guile/scm-disasm.c: Update.
11382 * guile/scm-frame.c: Update.
11383 * guile/scm-lazy-string.c: Update.
11384 * guile/scm-math.c: Update.
11385 * guile/scm-param.c: Update.
11386 * guile/scm-ports.c: Update.
11387 * guile/scm-pretty-print.c: Update.
11388 * guile/scm-symbol.c: Update.
11389 * guile/scm-symtab.c: Update.
11390 * guile/scm-type.c: Update.
11391 * guile/scm-value.c: Update.
11392 * i386-linux-tdep.c: Update.
11393 * i386-tdep.c: Update.
11394 * inf-loop.c: Update.
11395 * infcall.c: Update.
11396 * infcmd.c: Update.
11397 * infrun.c: Update.
11398 * jit.c: Update.
11399 * language.c: Update.
11400 * linespec.c: Update.
11401 * linux-fork.c: Update.
11402 * linux-nat.c: Update.
11403 * linux-tdep.c: Update.
11404 * linux-thread-db.c: Update.
11405 * main.c: Update.
11406 * mi/mi-cmd-break.c: Update.
11407 * mi/mi-cmd-stack.c: Update.
11408 * mi/mi-interp.c: Update.
11409 * mi/mi-main.c: Update.
11410 * objc-lang.c: Update.
11411 * p-valprint.c: Update.
11412 * parse.c: Update.
11413 * ppc-linux-tdep.c: Update.
11414 * printcmd.c: Update.
11415 * python/py-arch.c: Update.
11416 * python/py-breakpoint.c: Update.
11417 * python/py-cmd.c: Update.
11418 * python/py-finishbreakpoint.c: Update.
11419 * python/py-frame.c: Update.
11420 * python/py-framefilter.c: Update.
11421 * python/py-gdb-readline.c: Update.
11422 * python/py-inferior.c: Update.
11423 * python/py-infthread.c: Update.
11424 * python/py-lazy-string.c: Update.
11425 * python/py-linetable.c: Update.
11426 * python/py-objfile.c: Update.
11427 * python/py-param.c: Update.
11428 * python/py-prettyprint.c: Update.
11429 * python/py-progspace.c: Update.
11430 * python/py-record-btrace.c: Update.
11431 * python/py-record.c: Update.
11432 * python/py-symbol.c: Update.
11433 * python/py-type.c: Update.
11434 * python/py-unwind.c: Update.
11435 * python/py-utils.c: Update.
11436 * python/py-value.c: Update.
11437 * python/python.c: Update.
11438 * record-btrace.c: Update.
11439 * record-full.c: Update.
11440 * remote-fileio.c: Update.
11441 * remote.c: Update.
11442 * riscv-tdep.c: Update.
11443 * rs6000-aix-tdep.c: Update.
11444 * rs6000-tdep.c: Update.
11445 * rust-exp.y: Update.
11446 * rust-lang.c: Update.
11447 * s390-tdep.c: Update.
11448 * selftest-arch.c: Update.
11449 * solib-dsbt.c: Update.
11450 * solib-frv.c: Update.
11451 * solib-spu.c: Update.
11452 * solib-svr4.c: Update.
11453 * solib.c: Update.
11454 * sparc64-linux-tdep.c: Update.
11455 * stack.c: Update.
11456 * symfile-mem.c: Update.
11457 * symmisc.c: Update.
11458 * target.c: Update.
11459 * thread.c: Update.
11460 * top.c: Update.
11461 * tracefile-tfile.c: Update.
11462 * tui/tui.c: Update.
11463 * typeprint.c: Update.
11464 * unittests/cli-utils-selftests.c: Update.
11465 * unittests/parse-connection-spec-selftests.c: Update.
11466 * valops.c: Update.
11467 * valprint.c: Update.
11468 * value.c: Update.
11469 * varobj.c: Update.
11470 * windows-nat.c: Update.
11471 * x86-linux-nat.c: Update.
11472 * xml-support.c: Update.
11473
a70b8144
TT
114742019-04-08 Tom Tromey <tom@tromey.com>
11475
11476 * xml-support.c: Use C++ exception handling.
11477 * x86-linux-nat.c: Use C++ exception handling.
11478 * windows-nat.c: Use C++ exception handling.
11479 * varobj.c: Use C++ exception handling.
11480 * value.c: Use C++ exception handling.
11481 * valprint.c: Use C++ exception handling.
11482 * valops.c: Use C++ exception handling.
11483 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11484 handling.
11485 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11486 * typeprint.c: Use C++ exception handling.
11487 * tui/tui.c: Use C++ exception handling.
11488 * tracefile-tfile.c: Use C++ exception handling.
11489 * top.c: Use C++ exception handling.
11490 * thread.c: Use C++ exception handling.
11491 * target.c: Use C++ exception handling.
11492 * symmisc.c: Use C++ exception handling.
11493 * symfile-mem.c: Use C++ exception handling.
11494 * stack.c: Use C++ exception handling.
11495 * sparc64-linux-tdep.c: Use C++ exception handling.
11496 * solib.c: Use C++ exception handling.
11497 * solib-svr4.c: Use C++ exception handling.
11498 * solib-spu.c: Use C++ exception handling.
11499 * solib-frv.c: Use C++ exception handling.
11500 * solib-dsbt.c: Use C++ exception handling.
11501 * selftest-arch.c: Use C++ exception handling.
11502 * s390-tdep.c: Use C++ exception handling.
11503 * rust-lang.c: Use C++ exception handling.
11504 * rust-exp.y: Use C++ exception handling.
11505 * rs6000-tdep.c: Use C++ exception handling.
11506 * rs6000-aix-tdep.c: Use C++ exception handling.
11507 * riscv-tdep.c: Use C++ exception handling.
11508 * remote.c: Use C++ exception handling.
11509 * remote-fileio.c: Use C++ exception handling.
11510 * record-full.c: Use C++ exception handling.
11511 * record-btrace.c: Use C++ exception handling.
11512 * python/python.c: Use C++ exception handling.
11513 * python/py-value.c: Use C++ exception handling.
11514 * python/py-utils.c: Use C++ exception handling.
11515 * python/py-unwind.c: Use C++ exception handling.
11516 * python/py-type.c: Use C++ exception handling.
11517 * python/py-symbol.c: Use C++ exception handling.
11518 * python/py-record.c: Use C++ exception handling.
11519 * python/py-record-btrace.c: Use C++ exception handling.
11520 * python/py-progspace.c: Use C++ exception handling.
11521 * python/py-prettyprint.c: Use C++ exception handling.
11522 * python/py-param.c: Use C++ exception handling.
11523 * python/py-objfile.c: Use C++ exception handling.
11524 * python/py-linetable.c: Use C++ exception handling.
11525 * python/py-lazy-string.c: Use C++ exception handling.
11526 * python/py-infthread.c: Use C++ exception handling.
11527 * python/py-inferior.c: Use C++ exception handling.
11528 * python/py-gdb-readline.c: Use C++ exception handling.
11529 * python/py-framefilter.c: Use C++ exception handling.
11530 * python/py-frame.c: Use C++ exception handling.
11531 * python/py-finishbreakpoint.c: Use C++ exception handling.
11532 * python/py-cmd.c: Use C++ exception handling.
11533 * python/py-breakpoint.c: Use C++ exception handling.
11534 * python/py-arch.c: Use C++ exception handling.
11535 * printcmd.c: Use C++ exception handling.
11536 * ppc-linux-tdep.c: Use C++ exception handling.
11537 * parse.c: Use C++ exception handling.
11538 * p-valprint.c: Use C++ exception handling.
11539 * objc-lang.c: Use C++ exception handling.
11540 * mi/mi-main.c: Use C++ exception handling.
11541 * mi/mi-interp.c: Use C++ exception handling.
11542 * mi/mi-cmd-stack.c: Use C++ exception handling.
11543 * mi/mi-cmd-break.c: Use C++ exception handling.
11544 * main.c: Use C++ exception handling.
11545 * linux-thread-db.c: Use C++ exception handling.
11546 * linux-tdep.c: Use C++ exception handling.
11547 * linux-nat.c: Use C++ exception handling.
11548 * linux-fork.c: Use C++ exception handling.
11549 * linespec.c: Use C++ exception handling.
11550 * language.c: Use C++ exception handling.
11551 * jit.c: Use C++ exception handling.
11552 * infrun.c: Use C++ exception handling.
11553 * infcmd.c: Use C++ exception handling.
11554 * infcall.c: Use C++ exception handling.
11555 * inf-loop.c: Use C++ exception handling.
11556 * i386-tdep.c: Use C++ exception handling.
11557 * i386-linux-tdep.c: Use C++ exception handling.
11558 * guile/scm-value.c: Use C++ exception handling.
11559 * guile/scm-type.c: Use C++ exception handling.
11560 * guile/scm-symtab.c: Use C++ exception handling.
11561 * guile/scm-symbol.c: Use C++ exception handling.
11562 * guile/scm-pretty-print.c: Use C++ exception handling.
11563 * guile/scm-ports.c: Use C++ exception handling.
11564 * guile/scm-param.c: Use C++ exception handling.
11565 * guile/scm-math.c: Use C++ exception handling.
11566 * guile/scm-lazy-string.c: Use C++ exception handling.
11567 * guile/scm-frame.c: Use C++ exception handling.
11568 * guile/scm-disasm.c: Use C++ exception handling.
11569 * guile/scm-cmd.c: Use C++ exception handling.
11570 * guile/scm-breakpoint.c: Use C++ exception handling.
11571 * guile/scm-block.c: Use C++ exception handling.
11572 * guile/guile-internal.h: Use C++ exception handling.
11573 * gnu-v3-abi.c: Use C++ exception handling.
11574 * gdbtypes.c: Use C++ exception handling.
11575 * frame.c: Use C++ exception handling.
11576 * frame-unwind.c: Use C++ exception handling.
11577 * fbsd-tdep.c: Use C++ exception handling.
11578 * f-valprint.c: Use C++ exception handling.
11579 * exec.c: Use C++ exception handling.
11580 * event-top.c: Use C++ exception handling.
11581 * event-loop.c: Use C++ exception handling.
11582 * eval.c: Use C++ exception handling.
11583 * dwarf2read.c: Use C++ exception handling.
11584 * dwarf2loc.c: Use C++ exception handling.
11585 * dwarf2-frame.c: Use C++ exception handling.
11586 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11587 * dwarf-index-write.c: Use C++ exception handling.
11588 * dwarf-index-cache.c: Use C++ exception handling.
11589 * dtrace-probe.c: Use C++ exception handling.
11590 * disasm-selftests.c: Use C++ exception handling.
11591 * darwin-nat.c: Use C++ exception handling.
11592 * cp-valprint.c: Use C++ exception handling.
11593 * cp-support.c: Use C++ exception handling.
11594 * cp-abi.c: Use C++ exception handling.
11595 * corelow.c: Use C++ exception handling.
11596 * completer.c: Use C++ exception handling.
11597 * compile/compile-object-run.c: Use C++ exception handling.
11598 * compile/compile-object-load.c: Use C++ exception handling.
11599 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11600 * compile/compile-c-symbols.c: Use C++ exception handling.
11601 * common/selftest.c: Use C++ exception handling.
11602 * common/new-op.c: Use C++ exception handling.
11603 * cli/cli-script.c: Use C++ exception handling.
11604 * cli/cli-interp.c: Use C++ exception handling.
11605 * cli/cli-cmds.c: Use C++ exception handling.
11606 * c-varobj.c: Use C++ exception handling.
11607 * btrace.c: Use C++ exception handling.
11608 * breakpoint.c: Use C++ exception handling.
11609 * break-catch-throw.c: Use C++ exception handling.
11610 * arch-utils.c: Use C++ exception handling.
11611 * amd64-tdep.c: Use C++ exception handling.
11612 * ada-valprint.c: Use C++ exception handling.
11613 * ada-typeprint.c: Use C++ exception handling.
11614 * ada-lang.c: Use C++ exception handling.
11615 * aarch64-tdep.c: Use C++ exception handling.
11616
3d6e9d23
TT
116172019-04-08 Tom Tromey <tom@tromey.com>
11618
11619 * xml-support.c (gdb_xml_parser::parse): Update.
11620 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11621 * value.c (show_convenience): Update.
11622 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11623 (test_parse_flags_qcs): Update.
11624 * thread.c (thr_try_catch_cmd): Update.
11625 * target.c (target_translate_tls_address): Update.
11626 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11627 (info_frame_command_core, frame_apply_command_count): Update.
11628 * rust-exp.y (rust_lex_exception_test): Update.
11629 * riscv-tdep.c (riscv_print_one_register_info): Update.
11630 * remote.c (remote_target::enable_btrace): Update.
11631 * record-btrace.c (record_btrace_enable_warn): Update.
11632 * python/py-utils.c (gdbpy_convert_exception): Update.
11633 * printcmd.c (do_one_display, print_variable_and_value): Update.
11634 * mi/mi-main.c (mi_print_exception): Update.
11635 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11636 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11637 * linux-nat.c (linux_nat_target::attach): Update.
11638 * linux-fork.c (class scoped_switch_fork_info): Update.
11639 * infrun.c (displaced_step_prepare): Update.
11640 * infcall.c (call_function_by_hand_dummy): Update.
11641 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11642 * gnu-v3-abi.c (print_one_vtable): Update.
11643 * frame.c (get_prev_frame_always): Update.
11644 * f-valprint.c (info_common_command_for_block): Update.
11645 * exec.c (try_open_exec_file): Update.
11646 * exceptions.c (print_exception, exception_print)
11647 (exception_fprintf, exception_print_same): Update.
11648 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11649 * dwarf-index-cache.c (index_cache::store)
11650 (index_cache::lookup_gdb_index): Update.
11651 * darwin-nat.c (maybe_cache_shell): Update.
11652 * cp-valprint.c (cp_print_value_fields): Update.
11653 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11654 (gcc_cplus_symbol_address): Update.
11655 * compile/compile-c-symbols.c (gcc_convert_symbol)
11656 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11657 * common/selftest.c: Update.
11658 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11659 a std::string.
11660 (exception_try_scope_entry, exception_try_scope_exit): Don't
11661 declare.
11662 (struct exception_try_scope): Remove.
11663 (TRY): Don't use exception_try_scope.
11664 (struct gdb_exception): Add constructor, operator=.
11665 <what>: New method.
11666 (struct gdb_exception_RETURN_MASK_ALL)
11667 (struct gdb_exception_RETURN_MASK_ERROR)
11668 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11669 (struct gdb_quit_bad_alloc): Update.
11670 * common/common-exceptions.c (exception_none): Change
11671 initializer.
11672 (struct catcher) <state, exception>: Initialize inline.
11673 <prev>: Remove member.
11674 (current_catcher): Remove.
11675 (catchers): New global.
11676 (exceptions_state_mc_init): Simplify.
11677 (catcher_pop): Remove.
11678 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11679 (try_scope_depth, exception_try_scope_entry)
11680 (exception_try_scope_exit): Remove.
11681 (throw_exception_sjlj): Update.
11682 (exception_messages, exception_messages_size): Remove.
11683 (throw_it): Simplify.
11684 (gdb_exception_sliced_copy): Remove.
11685 (throw_exception_cxx): Update.
11686 * cli/cli-script.c (script_from_file): Update.
11687 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11688 Update.
11689 * ada-valprint.c (ada_val_print): Update.
11690 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11691 (create_excep_cond_exprs): Update.
11692
c5c10118
TT
116932019-04-08 Tom Tromey <tom@tromey.com>
11694
11695 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11696 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11697 (TRY, CATCH, END_CATCH): Remove some definitions.
11698 * common/common-exceptions.c: Don't use GDB_XCPT.
11699 (catcher_list_size): Remove.
11700 (throw_exception, throw_it): Simplify.
11701
4de283e4
TT
117022019-04-05 Tom Tromey <tom@tromey.com>
11703
11704 Revert the header-sorting patch.
11705 * ft32-tdep.c: Revert.
11706 * frv-tdep.c: Revert.
11707 * frv-linux-tdep.c: Revert.
11708 * frame.c: Revert.
11709 * frame-unwind.c: Revert.
11710 * frame-base.c: Revert.
11711 * fork-child.c: Revert.
11712 * findvar.c: Revert.
11713 * findcmd.c: Revert.
11714 * filesystem.c: Revert.
11715 * filename-seen-cache.h: Revert.
11716 * filename-seen-cache.c: Revert.
11717 * fbsd-tdep.c: Revert.
11718 * fbsd-nat.h: Revert.
11719 * fbsd-nat.c: Revert.
11720 * f-valprint.c: Revert.
11721 * f-typeprint.c: Revert.
11722 * f-lang.c: Revert.
11723 * extension.h: Revert.
11724 * extension.c: Revert.
11725 * extension-priv.h: Revert.
11726 * expprint.c: Revert.
11727 * exec.h: Revert.
11728 * exec.c: Revert.
11729 * exceptions.c: Revert.
11730 * event-top.c: Revert.
11731 * event-loop.c: Revert.
11732 * eval.c: Revert.
11733 * elfread.c: Revert.
11734 * dwarf2read.h: Revert.
11735 * dwarf2read.c: Revert.
11736 * dwarf2loc.c: Revert.
11737 * dwarf2expr.h: Revert.
11738 * dwarf2expr.c: Revert.
11739 * dwarf2-frame.c: Revert.
11740 * dwarf2-frame-tailcall.c: Revert.
11741 * dwarf-index-write.h: Revert.
11742 * dwarf-index-write.c: Revert.
11743 * dwarf-index-common.c: Revert.
11744 * dwarf-index-cache.h: Revert.
11745 * dwarf-index-cache.c: Revert.
11746 * dummy-frame.c: Revert.
11747 * dtrace-probe.c: Revert.
11748 * disasm.h: Revert.
11749 * disasm.c: Revert.
11750 * disasm-selftests.c: Revert.
11751 * dictionary.c: Revert.
11752 * dicos-tdep.c: Revert.
11753 * demangle.c: Revert.
11754 * dcache.h: Revert.
11755 * dcache.c: Revert.
11756 * darwin-nat.h: Revert.
11757 * darwin-nat.c: Revert.
11758 * darwin-nat-info.c: Revert.
11759 * d-valprint.c: Revert.
11760 * d-namespace.c: Revert.
11761 * d-lang.c: Revert.
11762 * ctf.c: Revert.
11763 * csky-tdep.c: Revert.
11764 * csky-linux-tdep.c: Revert.
11765 * cris-tdep.c: Revert.
11766 * cris-linux-tdep.c: Revert.
11767 * cp-valprint.c: Revert.
11768 * cp-support.c: Revert.
11769 * cp-namespace.c: Revert.
11770 * cp-abi.c: Revert.
11771 * corelow.c: Revert.
11772 * corefile.c: Revert.
11773 * continuations.c: Revert.
11774 * completer.h: Revert.
11775 * completer.c: Revert.
11776 * complaints.c: Revert.
11777 * coffread.c: Revert.
11778 * coff-pe-read.c: Revert.
11779 * cli-out.h: Revert.
11780 * cli-out.c: Revert.
11781 * charset.c: Revert.
11782 * c-varobj.c: Revert.
11783 * c-valprint.c: Revert.
11784 * c-typeprint.c: Revert.
11785 * c-lang.c: Revert.
11786 * buildsym.c: Revert.
11787 * buildsym-legacy.c: Revert.
11788 * build-id.h: Revert.
11789 * build-id.c: Revert.
11790 * btrace.c: Revert.
11791 * bsd-uthread.c: Revert.
11792 * breakpoint.h: Revert.
11793 * breakpoint.c: Revert.
11794 * break-catch-throw.c: Revert.
11795 * break-catch-syscall.c: Revert.
11796 * break-catch-sig.c: Revert.
11797 * blockframe.c: Revert.
11798 * block.c: Revert.
11799 * bfin-tdep.c: Revert.
11800 * bfin-linux-tdep.c: Revert.
11801 * bfd-target.c: Revert.
11802 * bcache.c: Revert.
11803 * ax-general.c: Revert.
11804 * ax-gdb.h: Revert.
11805 * ax-gdb.c: Revert.
11806 * avr-tdep.c: Revert.
11807 * auxv.c: Revert.
11808 * auto-load.c: Revert.
11809 * arm-wince-tdep.c: Revert.
11810 * arm-tdep.c: Revert.
11811 * arm-symbian-tdep.c: Revert.
11812 * arm-pikeos-tdep.c: Revert.
11813 * arm-obsd-tdep.c: Revert.
11814 * arm-nbsd-tdep.c: Revert.
11815 * arm-nbsd-nat.c: Revert.
11816 * arm-linux-tdep.c: Revert.
11817 * arm-linux-nat.c: Revert.
11818 * arm-fbsd-tdep.c: Revert.
11819 * arm-fbsd-nat.c: Revert.
11820 * arm-bsd-tdep.c: Revert.
11821 * arch-utils.c: Revert.
11822 * arc-tdep.c: Revert.
11823 * arc-newlib-tdep.c: Revert.
11824 * annotate.h: Revert.
11825 * annotate.c: Revert.
11826 * amd64-windows-tdep.c: Revert.
11827 * amd64-windows-nat.c: Revert.
11828 * amd64-tdep.c: Revert.
11829 * amd64-sol2-tdep.c: Revert.
11830 * amd64-obsd-tdep.c: Revert.
11831 * amd64-obsd-nat.c: Revert.
11832 * amd64-nbsd-tdep.c: Revert.
11833 * amd64-nbsd-nat.c: Revert.
11834 * amd64-nat.c: Revert.
11835 * amd64-linux-tdep.c: Revert.
11836 * amd64-linux-nat.c: Revert.
11837 * amd64-fbsd-tdep.c: Revert.
11838 * amd64-fbsd-nat.c: Revert.
11839 * amd64-dicos-tdep.c: Revert.
11840 * amd64-darwin-tdep.c: Revert.
11841 * amd64-bsd-nat.c: Revert.
11842 * alpha-tdep.c: Revert.
11843 * alpha-obsd-tdep.c: Revert.
11844 * alpha-nbsd-tdep.c: Revert.
11845 * alpha-mdebug-tdep.c: Revert.
11846 * alpha-linux-tdep.c: Revert.
11847 * alpha-linux-nat.c: Revert.
11848 * alpha-bsd-tdep.c: Revert.
11849 * alpha-bsd-nat.c: Revert.
11850 * aix-thread.c: Revert.
11851 * agent.c: Revert.
11852 * addrmap.c: Revert.
11853 * ada-varobj.c: Revert.
11854 * ada-valprint.c: Revert.
11855 * ada-typeprint.c: Revert.
11856 * ada-tasks.c: Revert.
11857 * ada-lang.c: Revert.
11858 * aarch64-tdep.c: Revert.
11859 * aarch64-ravenscar-thread.c: Revert.
11860 * aarch64-newlib-tdep.c: Revert.
11861 * aarch64-linux-tdep.c: Revert.
11862 * aarch64-linux-nat.c: Revert.
11863 * aarch64-fbsd-tdep.c: Revert.
11864 * aarch64-fbsd-nat.c: Revert.
11865 * aarch32-linux-nat.c: Revert.
11866
d55e5aa6
TT
118672019-04-05 Tom Tromey <tom@tromey.com>
11868
11869 * ft32-tdep.c: Sort headers.
11870 * frv-tdep.c: Sort headers.
11871 * frv-linux-tdep.c: Sort headers.
11872 * frame.c: Sort headers.
11873 * frame-unwind.c: Sort headers.
11874 * frame-base.c: Sort headers.
11875 * fork-child.c: Sort headers.
11876 * findvar.c: Sort headers.
11877 * findcmd.c: Sort headers.
11878 * filesystem.c: Sort headers.
11879 * filename-seen-cache.h: Sort headers.
11880 * filename-seen-cache.c: Sort headers.
11881 * fbsd-tdep.c: Sort headers.
11882 * fbsd-nat.h: Sort headers.
11883 * fbsd-nat.c: Sort headers.
11884 * f-valprint.c: Sort headers.
11885 * f-typeprint.c: Sort headers.
11886 * f-lang.c: Sort headers.
11887 * extension.h: Sort headers.
11888 * extension.c: Sort headers.
11889 * extension-priv.h: Sort headers.
11890 * expprint.c: Sort headers.
11891 * exec.h: Sort headers.
11892 * exec.c: Sort headers.
11893 * exceptions.c: Sort headers.
11894 * event-top.c: Sort headers.
11895 * event-loop.c: Sort headers.
11896 * eval.c: Sort headers.
11897 * elfread.c: Sort headers.
11898 * dwarf2read.h: Sort headers.
11899 * dwarf2read.c: Sort headers.
11900 * dwarf2loc.c: Sort headers.
11901 * dwarf2expr.h: Sort headers.
11902 * dwarf2expr.c: Sort headers.
11903 * dwarf2-frame.c: Sort headers.
11904 * dwarf2-frame-tailcall.c: Sort headers.
11905 * dwarf-index-write.h: Sort headers.
11906 * dwarf-index-write.c: Sort headers.
11907 * dwarf-index-common.c: Sort headers.
11908 * dwarf-index-cache.h: Sort headers.
11909 * dwarf-index-cache.c: Sort headers.
11910 * dummy-frame.c: Sort headers.
11911 * dtrace-probe.c: Sort headers.
11912 * disasm.h: Sort headers.
11913 * disasm.c: Sort headers.
11914 * disasm-selftests.c: Sort headers.
11915 * dictionary.c: Sort headers.
11916 * dicos-tdep.c: Sort headers.
11917 * demangle.c: Sort headers.
11918 * dcache.h: Sort headers.
11919 * dcache.c: Sort headers.
11920 * darwin-nat.h: Sort headers.
11921 * darwin-nat.c: Sort headers.
11922 * darwin-nat-info.c: Sort headers.
11923 * d-valprint.c: Sort headers.
11924 * d-namespace.c: Sort headers.
11925 * d-lang.c: Sort headers.
11926 * ctf.c: Sort headers.
11927 * csky-tdep.c: Sort headers.
11928 * csky-linux-tdep.c: Sort headers.
11929 * cris-tdep.c: Sort headers.
11930 * cris-linux-tdep.c: Sort headers.
11931 * cp-valprint.c: Sort headers.
11932 * cp-support.c: Sort headers.
11933 * cp-namespace.c: Sort headers.
11934 * cp-abi.c: Sort headers.
11935 * corelow.c: Sort headers.
11936 * corefile.c: Sort headers.
11937 * continuations.c: Sort headers.
11938 * completer.h: Sort headers.
11939 * completer.c: Sort headers.
11940 * complaints.c: Sort headers.
11941 * coffread.c: Sort headers.
11942 * coff-pe-read.c: Sort headers.
11943 * cli-out.h: Sort headers.
11944 * cli-out.c: Sort headers.
11945 * charset.c: Sort headers.
11946 * c-varobj.c: Sort headers.
11947 * c-valprint.c: Sort headers.
11948 * c-typeprint.c: Sort headers.
11949 * c-lang.c: Sort headers.
11950 * buildsym.c: Sort headers.
11951 * buildsym-legacy.c: Sort headers.
11952 * build-id.h: Sort headers.
11953 * build-id.c: Sort headers.
11954 * btrace.c: Sort headers.
11955 * bsd-uthread.c: Sort headers.
11956 * breakpoint.h: Sort headers.
11957 * breakpoint.c: Sort headers.
11958 * break-catch-throw.c: Sort headers.
11959 * break-catch-syscall.c: Sort headers.
11960 * break-catch-sig.c: Sort headers.
11961 * blockframe.c: Sort headers.
11962 * block.c: Sort headers.
11963 * bfin-tdep.c: Sort headers.
11964 * bfin-linux-tdep.c: Sort headers.
11965 * bfd-target.c: Sort headers.
11966 * bcache.c: Sort headers.
11967 * ax-general.c: Sort headers.
11968 * ax-gdb.h: Sort headers.
11969 * ax-gdb.c: Sort headers.
11970 * avr-tdep.c: Sort headers.
11971 * auxv.c: Sort headers.
11972 * auto-load.c: Sort headers.
11973 * arm-wince-tdep.c: Sort headers.
11974 * arm-tdep.c: Sort headers.
11975 * arm-symbian-tdep.c: Sort headers.
11976 * arm-pikeos-tdep.c: Sort headers.
11977 * arm-obsd-tdep.c: Sort headers.
11978 * arm-nbsd-tdep.c: Sort headers.
11979 * arm-nbsd-nat.c: Sort headers.
11980 * arm-linux-tdep.c: Sort headers.
11981 * arm-linux-nat.c: Sort headers.
11982 * arm-fbsd-tdep.c: Sort headers.
11983 * arm-fbsd-nat.c: Sort headers.
11984 * arm-bsd-tdep.c: Sort headers.
11985 * arch-utils.c: Sort headers.
11986 * arc-tdep.c: Sort headers.
11987 * arc-newlib-tdep.c: Sort headers.
11988 * annotate.h: Sort headers.
11989 * annotate.c: Sort headers.
11990 * amd64-windows-tdep.c: Sort headers.
11991 * amd64-windows-nat.c: Sort headers.
11992 * amd64-tdep.c: Sort headers.
11993 * amd64-sol2-tdep.c: Sort headers.
11994 * amd64-obsd-tdep.c: Sort headers.
11995 * amd64-obsd-nat.c: Sort headers.
11996 * amd64-nbsd-tdep.c: Sort headers.
11997 * amd64-nbsd-nat.c: Sort headers.
11998 * amd64-nat.c: Sort headers.
11999 * amd64-linux-tdep.c: Sort headers.
12000 * amd64-linux-nat.c: Sort headers.
12001 * amd64-fbsd-tdep.c: Sort headers.
12002 * amd64-fbsd-nat.c: Sort headers.
12003 * amd64-dicos-tdep.c: Sort headers.
12004 * amd64-darwin-tdep.c: Sort headers.
12005 * amd64-bsd-nat.c: Sort headers.
12006 * alpha-tdep.c: Sort headers.
12007 * alpha-obsd-tdep.c: Sort headers.
12008 * alpha-nbsd-tdep.c: Sort headers.
12009 * alpha-mdebug-tdep.c: Sort headers.
12010 * alpha-linux-tdep.c: Sort headers.
12011 * alpha-linux-nat.c: Sort headers.
12012 * alpha-bsd-tdep.c: Sort headers.
12013 * alpha-bsd-nat.c: Sort headers.
12014 * aix-thread.c: Sort headers.
12015 * agent.c: Sort headers.
12016 * addrmap.c: Sort headers.
12017 * ada-varobj.c: Sort headers.
12018 * ada-valprint.c: Sort headers.
12019 * ada-typeprint.c: Sort headers.
12020 * ada-tasks.c: Sort headers.
12021 * ada-lang.c: Sort headers.
12022 * aarch64-tdep.c: Sort headers.
12023 * aarch64-ravenscar-thread.c: Sort headers.
12024 * aarch64-newlib-tdep.c: Sort headers.
12025 * aarch64-linux-tdep.c: Sort headers.
12026 * aarch64-linux-nat.c: Sort headers.
12027 * aarch64-fbsd-tdep.c: Sort headers.
12028 * aarch64-fbsd-nat.c: Sort headers.
12029 * aarch32-linux-nat.c: Sort headers.
12030
699bd4cf
TT
120312019-04-04 Tom Tromey <tom@tromey.com>
12032
12033 * varobj.c (varobj_create): Update.
12034 * rust-exp.y (struct rust_parser) <update_innermost_block,
12035 lookup_symbol>: New methods.
12036 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12037 Rename.
12038 (rust_parser::rust_lookup_type)
12039 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12040 * printcmd.c (display_command, do_one_display): Update.
12041 * parser-defs.h (struct parser_state) <parser_state>: Add
12042 "tracker" parameter.
12043 (block_tracker): New member.
12044 (class innermost_block_tracker) <innermost_block_tracker>: Add
12045 "types" parameter.
12046 <reset>: Remove method.
12047 (innermost_block): Don't declare.
12048 (null_post_parser): Update.
12049 * parse.c (innermost_block): Remove global.
12050 (write_dollar_variable): Update.
12051 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12052 Remove "tracker_types" parameter.
12053 (parse_expression): Add "tracker" parameter.
12054 (parse_expression_for_completion): Update.
12055 (null_post_parser): Add "tracker" parameter.
12056 * p-exp.y: Update rules.
12057 * m2-exp.y: Update rules.
12058 * language.h (struct language_defn) <la_post_parser>: Add
12059 "tracker" parameter.
12060 * go-exp.y: Update rules.
12061 * f-exp.y: Update rules.
12062 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12063 parameter.
12064 * d-exp.y: Update rules.
12065 * c-exp.y: Update rules.
12066 * breakpoint.c (set_breakpoint_condition): Create an
12067 innermost_block_tracker.
12068 (watch_command_1): Likewise.
12069 * ada-lang.c (resolve): Add "tracker" parameter.
12070 (resolve_subexp): Likewise.
12071 * ada-exp.y (write_var_from_sym): Update.
12072
dac43e32
TT
120732019-04-04 Tom Tromey <tom@tromey.com>
12074
12075 * type-stack.h: New file.
12076 * type-stack.c: New file.
12077 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12078 type-stack.h.
12079 (insert_into_type_stack, insert_type, push_type, push_type_int)
12080 (insert_type_address_space, pop_type, pop_type_int)
12081 (pop_typelist, pop_type_stack, append_type_stack)
12082 (push_type_stack, get_type_stack, push_typelist)
12083 (follow_type_instance_flags, follow_types): Don't declare.
12084 * parse.c (type_stack): Remove global.
12085 (parse_exp_in_context): Update.
12086 (insert_into_type_stack, insert_type, push_type, push_type_int)
12087 (insert_type_address_space, pop_type, pop_type_int)
12088 (pop_typelist, pop_type_stack, append_type_stack)
12089 (push_type_stack, get_type_stack, push_typelist)
12090 (follow_type_instance_flags, follow_types): Remove (moved to
12091 type-stack.c).
12092 * f-exp.y (type_stack): New global.
12093 Update rules.
12094 (push_kind_type, f_parse): Update.
12095 * d-exp.y (type_stack): New global.
12096 Update rules.
12097 (d_parse): Update.
12098 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12099 Update rules.
12100 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12101 (HFILES_NO_SRCDIR): Add type-stack.h.
12102
2a612529
TT
121032019-04-04 Tom Tromey <tom@tromey.com>
12104
12105 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12106 (rust_parser::convert_ast_to_expression, rust_parse)
12107 (rust_lex_test_completion, rust_lex_tests): Update.
12108 * parser-defs.h (struct expr_completion_state): New.
12109 (struct parser_state) <parser_state>: Add completion parameter.
12110 <mark_struct_expression, mark_completion_tag>: New methods.
12111 <parse_completion, m_completion_state>: New members.
12112 (prefixify_expression, null_post_parser): Update.
12113 (mark_struct_expression, mark_completion_tag): Don't declare.
12114 * parse.c (parse_completion, expout_last_struct)
12115 (expout_tag_completion_type, expout_completion_name): Remove
12116 globals.
12117 (parser_state::mark_struct_expression)
12118 (parser_state::mark_completion_tag): Now methods.
12119 (prefixify_expression): Add last_struct parameter.
12120 (prefixify_subexp): Likewise.
12121 (parse_exp_1): Update.
12122 (parse_exp_in_context): Add cstate parameter. Update.
12123 (parse_expression_for_completion): Create an
12124 expr_completion_state.
12125 (null_post_parser): Add "completion" parameter.
12126 * p-exp.y: Update rules.
12127 (yylex): Update.
12128 * language.h (struct language_defn) <la_post_parser>: Add
12129 "completing" parameter.
12130 * go-exp.y: Update rules.
12131 (lex_one_token): Update.
12132 * expression.h (parse_completion): Don't declare.
12133 * d-exp.y: Update rules.
12134 (lex_one_token): Update rules.
12135 * c-exp.y: Update rules.
12136 (lex_one_token): Update.
12137 * ada-lang.c (resolve): Add "parse_completion" parameter.
12138 (resolve_subexp): Likewise.
12139 (ada_resolve_function): Likewise.
12140
43476f0b
TT
121412019-04-04 Tom Tromey <tom@tromey.com>
12142
12143 * parser-defs.h (struct parser_state) <start_arglist,
12144 end_arglist>: New methods.
12145 <arglist_len, m_funcall_chain>: New members.
12146 (arglist_len, start_arglist, end_arglist): Don't declare.
12147 * parse.c (arglist_len, funcall_chain): Remove global.
12148 (start_arglist, end_arglist): Remove functions.
12149 (parse_exp_in_context): Update.
12150 * p-exp.y: Update rules.
12151 * m2-exp.y: Update rules.
12152 * go-exp.y: Update rules.
12153 * f-exp.y: Update rules.
12154 * d-exp.y: Update rules.
12155 * c-exp.y: Update rules.
12156
5776fca3
TT
121572019-04-04 Tom Tromey <tom@tromey.com>
12158
12159 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12160 lex_operator, push_back>: New methods.
12161 Update all rules.
12162 (rust_parser::lex_hex, lex_escape): Rename and update.
12163 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12164 (rust_parser::lex_operator): Rename and update.
12165 (rust_parser::lex_number, rustyylex, rustyyerror)
12166 (rust_lex_test_init, rust_lex_test_sequence)
12167 (rust_lex_test_push_back, rust_lex_tests): Update.
12168 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12169 parameter.
12170 <lexptr, prev_lexptr>: New members.
12171 (lexptr, prev_lexptr): Don't declare.
12172 * parse.c (lexptr, prev_lexptr): Remove globals.
12173 (parse_exp_in_context): Update.
12174 * p-exp.y (yylex, yyerror): Update.
12175 * m2-exp.y (parse_number, yylex, yyerror): Update.
12176 * go-exp.y (lex_one_token, yyerror): Update.
12177 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12178 * d-exp.y (lex_one_token, yyerror): Update.
12179 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12180 (lex_one_token, yyerror): Update.
12181 * ada-lex.l (YY_INPUT): Update.
12182 (rewind_to_char): Update.
12183 * ada-exp.y (yyerror): Update.
12184
8621b685
TT
121852019-04-04 Tom Tromey <tom@tromey.com>
12186
12187 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12188 * parser-defs.h (struct parser_state) <parser_state>: Add new
12189 parameter.
12190 <comma_terminates>: New member.
12191 (comma_terminates): Don't declare global.
12192 * parse.c (comma_terminates): Remove global.
12193 (parse_exp_in_context): Update.
12194 * p-exp.y (yylex): Update.
12195 * m2-exp.y (yylex): Update.
12196 * go-exp.y (lex_one_token): Update.
12197 * f-exp.y (yylex): Update.
12198 * d-exp.y (lex_one_token): Update.
12199 * c-exp.y (lex_one_token): Update.
12200 * ada-lex.l: Update.
12201
28aaf3fd
TT
122022019-04-04 Tom Tromey <tom@tromey.com>
12203
12204 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12205 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12206 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12207 * parser-defs.h (paren_depth): Don't declare.
12208 * parse.c (paren_depth): Remove global.
12209 (parse_exp_in_context): Update.
12210 * p-exp.y (paren_depth): New global.
12211 (pascal_parse): Initialize it.
12212 * m2-exp.y (paren_depth): New global.
12213 (m2_parse): Initialize it.
12214 * go-exp.y (paren_depth): New global.
12215 (go_parse): Initialize it.
12216 * f-exp.y (paren_depth): New global.
12217 (f_parse): Initialize it.
12218 * d-exp.y (paren_depth): New global.
12219 (d_parse): Initialize it.
12220 * c-exp.y (paren_depth): New global.
12221 (c_parse): Initialize it.
12222 * ada-lex.l (paren_depth): New global.
12223 (lexer_init): Initialize it.
12224
1e58a4a4
TT
122252019-04-04 Tom Tromey <tom@tromey.com>
12226
12227 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12228 (rust_parser::convert_ast_to_type)
12229 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12230 * parser-defs.h (struct parser_state) <parser_state>: Add
12231 parameters. Initialize new members.
12232 <expression_context_block, expression_context_pc>: New members.
12233 * parse.c (expression_context_block, expression_context_pc):
12234 Remove globals.
12235 (parse_exp_in_context): Update.
12236 * p-exp.y: Update all rules.
12237 (yylex): Update.
12238 * m2-exp.y: Update all rules.
12239 (yylex): Update.
12240 * go-exp.y (yylex): Update.
12241 * f-exp.y (yylex): Update.
12242 * d-exp.y: Update all rules.
12243 (yylex): Update.
12244 * c-exp.y: Update all rules.
12245 (lex_one_token, classify_name, yylex, c_parse): Update.
12246 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12247
37eedb39
TT
122482019-04-04 Tom Tromey <tom@tromey.com>
12249
12250 * gdbarch.h, gdbarch.c: Rebuild.
12251 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12252 * stap-probe.h:
12253 (struct stap_parse_info): Replace "parser_state" with
12254 "expr_builder".
12255 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12256 (parser_state): New class.
12257 * parse.c (expr_builder): Rename.
12258 (expr_builder::release): Rename.
12259 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12260 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12261 (write_exp_elt_longcst, write_exp_elt_floatcst)
12262 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12263 (write_exp_string_vector, write_exp_bitstring)
12264 (write_exp_msymbol, mark_struct_expression)
12265 (write_dollar_variable)
12266 (insert_type_address_space, increase_expout_size): Replace
12267 "parser_state" with "expr_builder".
12268 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12269 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12270 "parser_state" with "expr_builder".
12271
73923d7e
TT
122722019-04-04 Tom Tromey <tom@tromey.com>
12273
12274 * rust-exp.y: Replace "parse_language" with method call.
12275 * p-exp.y:
12276 (yylex): Replace "parse_language" with method call.
12277 * m2-exp.y:
12278 (yylex): Replace "parse_language" with method call.
12279 * go-exp.y (classify_name): Replace "parse_language" with method
12280 call.
12281 * f-exp.y (yylex): Replace "parse_language" with method call.
12282 * d-exp.y (lex_one_token): Replace "parse_language" with method
12283 call.
12284 * c-exp.y:
12285 (lex_one_token, classify_name, yylex): Replace "parse_language"
12286 with method call.
12287 * ada-exp.y (find_primitive_type, type_char)
12288 (type_system_address): Replace "parse_language" with method call.
12289
fa9f5be6
TT
122902019-04-04 Tom Tromey <tom@tromey.com>
12291
12292 * rust-exp.y: Replace "parse_gdbarch" with method call.
12293 * parse.c (write_dollar_variable, insert_type_address_space):
12294 Replace "parse_gdbarch" with method call.
12295 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12296 call.
12297 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12298 call.
12299 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12300 "parse_gdbarch" with method call.
12301 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12302 with method call.
12303 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12304 "parse_gdbarch" with method call.
12305 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12306 "parse_gdbarch" with method call.
12307 * c-exp.y (parse_type, parse_number, classify_name): Replace
12308 "parse_gdbarch" with method call.
12309 * ada-lex.l: Replace "parse_gdbarch" with method call.
12310 * ada-exp.y (parse_type, find_primitive_type, type_char)
12311 (type_system_address): Replace "parse_gdbarch" with method call.
12312
1201a264
TT
123132019-04-04 Tom Tromey <tom@tromey.com>
12314
12315 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12316 * stap-probe.c (stap_parse_argument): Update.
12317 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12318 initial_size parameter.
12319 * rust-exp.y (rust_lex_tests): Update.
12320 * parse.c (parser_state): Update.
12321 (parse_exp_in_context): Update.
12322 * parser-defs.h (struct parser_state) <parser_state>: Remove
12323 "initial_size" parameter.
12324
e3980ce2
TT
123252019-04-04 Tom Tromey <tom@tromey.com>
12326
12327 * parser-defs.h (increase_expout_size): Don't declare.
12328 * parse.c (increase_expout_size): Now static.
12329
e9f8e3f1
TS
123302019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12331
12332 * gnu-nat.c (gnu_nat_target::wait): Fix
12333 target_waitstatus_to_string call.
12334
d7df6549
AB
123352019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12336
12337 * eval.c (evaluate_subexp_standard): Handle internal functions
12338 during Fortran function call handling.
12339
8bdc1658
AB
123402019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12341
12342 * NEWS: Mention new internal functions.
12343 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12344 (read_base_type): Use dwarf2_init_complex_target_type.
12345 * value.c (creal_internal_fn): New function.
12346 (cimag_internal_fn): New function.
12347 (_initialize_values): Register new internal functions.
12348
c29705b7
PW
123492019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12350
12351 * infrun.c (stop_all_threads): If debug_infrun, always
12352 trace the wait status after wait_one, using
12353 target_waitstatus_to_string and target_pid_to_str.
12354 (handle_inferior_event): Replace various trace of
12355 wait status kind by a single trace.
12356 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12357 wait status kind image by target_waitstatus_to_string.
12358 * target/waitstatus.c (target_waitstatus_to_string): Fix
12359 obsolete comment.
12360
05caa1d2
TT
123612019-04-01 Tom Tromey <tromey@adacore.com>
12362
12363 PR symtab/23331:
12364 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12365
9d1447e0
SDJ
123662019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12367 Pedro Alves <palves@redhat.com>
12368
12369 * top.c (quit_force): Call 'finalize_values'.
12370 * value.c (finalize_values): New function.
12371 * value.h (finalize_values): Declare.
12372
7734102d
EZ
123732019-03-30 Eli Zaretskii <eliz@gnu.org>
12374
12375 * NEWS: Announce $_gdb_major and $_gdb_minor.
12376
12377 * top.c (init_gdb_version_vars): New function.
12378 (gdb_init): Call init_gdb_version_vars.
12379
188e1fa9
TT
123802019-03-29 Tom Tromey <tromey@adacore.com>
12381
12382 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12383 help text. Remove dead code.
12384
2880242d
KS
123852019-03-29 Keith Seitz <keiths@redhat.com>
12386
12387 From Siddhesh Poyarekar:
12388 * f-lang.h (f77_get_upperbound): Return LONGEST.
12389 (f77_get_lowerbound): Likewise.
12390 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12391 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12392 print them.
12393 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12394 plongest to format print it.
12395 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12396 (f77_get_upperbound): Likewise.
12397 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12398 LOWER_BOUND to LONGEST.
12399 (f77_create_arrayprint_offset_tbl): Likewise.
12400
cc1defb1
KS
124012019-03-29 Keith Seitz <keiths@redhat.com>
12402
12403 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12404 %s/pulongest for TYPE_LENGTH instead of %d in format
12405 strings.
12406 * ada-typerint.c (ada_print_type): Likewise.
12407 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12408 * compile/compile-c-support.c (generate_register_struct): Likewise.
12409 * gdbtypes.c (recursive_dump_type): Likewise.
12410 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12411 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12412 instead of %d in format strings.
12413 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12414 to std::min to ULONGEST.
12415 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12416 instead of %d in format strings.
12417 * tracepoint.c (info_scope_command): Likewise.
12418 * typeprint.c (print_offset_data::update)
12419 (print_offset_data::finish): Likewise.
12420 * xtensa-tdep.c (xtensa_store_return_value)
12421 (xtensa_push_dummy_call): Likewise.
12422
e432ccf1
JT
124232019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12424
12425 * windows-nat.c (display_selector): Fixed format specifications
12426 for 64-bit Cygwin.
12427
65d2b333
PW
124282019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12429
12430 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12431
f489207e
SL
124322019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12433
12434 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12435 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12436 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12437 (nios2_linux_init_abi): Install it.
12438
bffa1015
AH
124392019-03-28 Alan Hayward <alan.hayward@arm.com>
12440
12441 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12442
fc96163a
AH
124432019-03-28 Alan Hayward <alan.hayward@arm.com>
12444
12445 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12446
20dc7e9b
PW
124472019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12448 Tom Tromey <tromey@adacore.com>
12449
12450 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12451
7f5331a8
JB
124522019-03-26 Joel Brobecker <brobecker@adacore.com>
12453
12454 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12455 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12456 method to compute the bounds of range types. Also print "[evaluated]"
12457 if the bounds' values come from a dynamic evaluation.
12458
18c77628
AB
124592019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12460
12461 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12462 whitespace when pretty printing is on.
12463
53c973f2
AH
124642019-03-26 Alan Hayward <alan.hayward@arm.com>
12465
e79be6e5 12466 * ppc-linux-nat.c: Add include.
53c973f2 12467
d851aa71
AH
124682019-03-26 Alan Hayward <alan.hayward@arm.com>
12469
e79be6e5 12470 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12471
2fe7bab7
AH
124722019-03-26 Alan Hayward <alan.hayward@arm.com>
12473
e79be6e5 12474 * arm-linux-nat.c: Add include.
2fe7bab7 12475
068ef30e
SM
124762019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12477
12478 * source-cache.c (source_cache::get_source_lines): Re-read
12479 fullname after calling open_source_file.
12480
81a24d04
JB
124812019-03-25 John Baldwin <jhb@FreeBSD.org>
12482
12483 * NEWS: Mention TLS support for FreeBSD.
12484
79e7ae11
TT
124852019-03-25 Tom Tromey <tromey@adacore.com>
12486
12487 * minsyms.c (BUNCH_SIZE): Update comment.
12488 (~minimal_symbol_reader): Remove old comment.
12489 (compact_minimal_symbols): Update comment.
12490 (minimal_symbol_reader::install): Remove old comment. Update
12491 other comments.
12492
d45963c2
AH
124932019-03-25 Alan Hayward <alan.hayward@arm.com>
12494
12495 * s390-linux-nat.c: Add include.
12496
0f83012e
AH
124972019-03-25 Alan Hayward <alan.hayward@arm.com>
12498
12499 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12500 Call linux_get_hwcap.
12501 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12502 Likewise.
12503 (aarch64_linux_get_hwcap): Remove function.
12504 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12505 declaration.
12506 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12507 linux_get_hwcap.
12508 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12509 * linux-tdep.c (linux_get_hwcap): Add function.
12510 (linux_get_hwcap2): Likewise.
12511 * linux-tdep.h (linux_get_hwcap): Add declaration.
12512 (linux_get_hwcap2): Likewise.
12513 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12514 (ppc_linux_get_hwcap2): Likewise.
12515 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12516 linux_get_hwcap.
12517 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12518 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12519 (ppc_linux_nat_target::read_description): Likewise.
12520 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12521 * s390-linux-nat.c: Likewise.
12522 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12523
6640a367
TT
125242019-03-24 Tom Tromey <tom@tromey.com>
12525
12526 * ada-lang.c (standard_lookup): Simplify initialization.
12527 (ada_lookup_symbol_nonlocal): Simplify return.
12528 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12529 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12530 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12531 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12532 initialization.
12533 * solib.c (solib_global_lookup): Simplify.
12534 * symtab.c (null_block_symbol): Remove.
12535 (symbol_cache_lookup): Simplify returns.
12536 (lookup_language_this): Simplify returns.
12537 (lookup_symbol_aux): Simplify return.
12538 (lookup_local_symbol): Simplify returns.
12539 (lookup_global_symbol_from_objfile): Simplify return.
12540 (lookup_symbol_in_objfile_symtabs)
12541 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12542 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12543 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12544 * cp-namespace.c (cp_lookup_bare_symbol)
12545 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12546 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12547 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12548 (cp_lookup_symbol_via_imports): Simplify initialization.
12549 (find_symbol_in_baseclass): Likewise.
12550 * symtab.h (null_block_symbol): Remove.
12551 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12552 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12553 (d_lookup_symbol_module): Likewise.
12554 (find_symbol_in_baseclass): Simplify initialization.
12555
a930ebcd
TT
125562019-03-24 Tom Tromey <tom@tromey.com>
12557
12558 * expression.h: Don't include symtab.h.
12559 (struct block): Forward declare.
12560
582942f4
TT
125612019-03-24 Tom Tromey <tom@tromey.com>
12562
12563 * c-exp.y (typebase): Remove casts.
12564 * gdbtypes.c (lookup_unsigned_typename, )
12565 (lookup_signed_typename): Remove cast.
12566 * eval.c (parse_to_comma_and_eval): Remove cast.
12567 * parse.c (write_dollar_variable): Remove cast.
12568 * block.h (struct block) <superblock>: Now const.
12569 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12570 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12571 (map_block): Make "block" const.
12572 * symfile.h (struct quick_symbol_functions)
12573 <map_matching_symbols>: Constify block argument to "callback".
12574 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12575 const.
12576 (find_pc_sect_compunit_symtab): Make "b" const.
12577 (find_symbol_at_address): Likewise.
12578 (search_symbols): Likewise.
12579 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12580 (dw2_debug_names_lookup_symbol): Likewise.
12581 (dw2_map_matching_symbols): Update.
12582 * p-valprint.c (pascal_val_print): Remove "block".
12583 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12584 (aux_add_nonlocal_symbols): Make "block" const.
12585 (resolve_subexp): Remove cast.
12586 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12587 const.
12588 (iterate_over_file_blocks): Likewise.
12589 * f-exp.y (%union) <bval>: Remove.
12590 * coffread.c (patch_opaque_types): Make "b" const.
12591 * spu-tdep.c (spu_catch_start): Make "block" const.
12592 * c-valprint.c (print_unpacked_pointer): Remove "block".
12593 * symmisc.c (dump_symtab_1): Make "b" const.
12594 (block_depth): Make "block" const.
12595 * d-exp.y (%union) <bval>: Remove.
12596 * cp-support.h (cp_lookup_rtti_type): Update.
12597 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12598 * psymtab.c (psym_lookup_symbol): Make "block" const.
12599 (maintenance_check_psymtabs): Make "b" const.
12600 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12601 (enumerate_locals, enumerate_args): Update.
12602 * python/py-symtab.c (stpy_global_block): Make "block" const.
12603 (stpy_static_block): Likewise.
12604 * inline-frame.c (block_starting_point_at): Make "new_block"
12605 const.
12606 * block.c (find_block_in_blockvector): Make return type const.
12607 (blockvector_for_pc_sect): Make "b" const.
12608 (find_block_in_blockvector): Make "b" const.
12609
7ad417dd
TT
126102019-03-23 Tom Tromey <tom@tromey.com>
12611
12612 * varobj.c (varobj_create): Update.
12613 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12614 * printcmd.c (display_command, do_one_display): Don't reset
12615 innermost_block.
12616 * parser-defs.h (enum innermost_block_tracker_type): Move to
12617 expression.h.
12618 (innermost_block): Update comment.
12619 * parse.c (parse_exp_1): Add tracker_types parameter.
12620 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12621 tracker_types parameter. Reset innermost_block.
12622 (parse_exp_in_context): Remove.
12623 (parse_expression_for_completion): Update.
12624 * objfiles.c (~objfile): Don't reset expression_context_block or
12625 innermost_block.
12626 * expression.h (enum innermost_block_tracker_type): Move from
12627 parser-defs.h.
12628 (parse_exp_1): Add tracker_types parameter.
12629 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12630 reset innermost_block.
12631
b366c208
TT
126322019-03-23 Tom Tromey <tom@tromey.com>
12633
12634 * objfiles.h: Include bcache.h.
12635
9bb9b2f9
TT
126362019-03-23 Tom Tromey <tom@tromey.com>
12637
12638 * linespec.c (get_current_search_block): Use
12639 scoped_restore_current_language.
12640 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12641
59c28372
AH
126422019-03-22 Alan Hayward <alan.hayward@arm.com>
12643 Jiong Wang <jiong.wang@arm.com>
12644
12645 * aarch64-linux-tdep.c
12646 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12647 section.
12648 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12649
17e116a7
AH
126502019-03-22 Alan Hayward <alan.hayward@arm.com>
12651 Jiong Wang <jiong.wang@arm.com>
12652
12653 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12654 instructions.
12655 (aarch64_analyze_prologue_test): Add PACIASP test.
12656 (aarch64_prologue_prev_register): Unmask PC value.
12657
11e1b75f
AH
126582019-03-22 Alan Hayward <alan.hayward@arm.com>
12659 Jiong Wang <jiong.wang@arm.com>
12660
12661 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12662 (aarch64_dwarf2_prev_register): Unmask PC value.
12663 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12664 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12665 DW_CFA_AARCH64_negate_ra_state.
12666 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12667
34dcc7cf
AH
126682019-03-22 Alan Hayward <alan.hayward@arm.com>
12669 Jiong Wang <jiong.wang@arm.com>
12670
12671 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12672 registers.
12673 (aarch64_pseudo_register_name): Likewise.
12674 (aarch64_pseudo_register_type): Likewise.
12675 (aarch64_pseudo_register_reggroup_p): Likewise.
12676 (aarch64_gdbarch_init): Add pauth registers.
12677 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12678 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12679 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12680 (struct gdbarch_tdep): Add regnum for ra_state.
12681
1ef53e6b
AH
126822019-03-22 Alan Hayward <alan.hayward@arm.com>
12683 Jiong Wang <jiong.wang@arm.com>
12684
12685 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12686
76bed0fd
AH
126872019-03-22 Alan Hayward <alan.hayward@arm.com>
12688 Jiong Wang <jiong.wang@arm.com>
12689
12690 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12691 function.
12692 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12693 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12694 (aarch64_gdbarch_init): Add puth registers.
12695 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12696 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12697 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12698
ee4fbcfa
AH
126992019-03-22 Alan Hayward <alan.hayward@arm.com>
12700 Jiong Wang <jiong.wang@arm.com>
12701
12702 * aarch64-linux-nat.c
12703 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12704 * aarch64-linux-tdep.c
12705 (aarch64_linux_core_read_description): Likewise.
12706 (aarch64_linux_get_hwcap): New function.
12707 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12708 (aarch64_linux_get_hwcap): New declaration.
12709
6dc0ebde
AH
127102019-03-22 Alan Hayward <alan.hayward@arm.com>
12711 Jiong Wang <jiong.wang@arm.com>
12712
12713 * aarch64-linux-nat.c
12714 (aarch64_linux_nat_target::read_description): Add pauth param.
12715 * aarch64-linux-tdep.c
12716 (aarch64_linux_core_read_description): Likewise.
12717 * aarch64-tdep.c (struct target_desc): Add in pauth.
12718 (aarch64_read_description): Add pauth param.
12719 (aarch64_gdbarch_init): Likewise.
12720 * aarch64-tdep.h (aarch64_read_description): Likewise.
12721 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12722 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12723 * features/Makefile: Add new files.
12724 * features/aarch64-pauth.c: New file.
12725 * features/aarch64-pauth.xml: New file.
12726
595915c1
TT
127272019-03-20 Tom Tromey <tromey@adacore.com>
12728
12729 * infrun.c (handle_inferior_event): Rename from
12730 handle_inferior_event_1. Create a scoped_value_mark.
12731 (handle_inferior_event): Remove.
12732
4c7d57e7
TT
127332019-03-19 Tom Tromey <tromey@adacore.com>
12734
12735 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12736 * infrun.h (print_stop_event): Add "displays" parameter.
12737 * infrun.c (print_stop_event): Add "displays" parameter.
12738
cb246234
PA
127392019-03-19 Pedro Alves <palves@redhat.com>
12740
12741 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12742 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12743 to -1. Fix TABs vs spaces.
12744 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12745 * tui/tui-out.h (tui_ui_out) Add intro comments.
12746 <m_line, m_start_of_line>: In-class initialize, and add describing
12747 comment.
12748
3a0e45b2
AH
127492019-03-18 Alan Hayward <alan.hayward@arm.com>
12750
12751 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12752 variable names.
12753 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12754
5371b850
PA
127552019-03-18 Pedro Alves <palves@redhat.com>
12756 Eli Zaretskii <eliz@gnu.org>
12757
12758 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12759 m_line and m_start_of_line.
12760
b17c4cd0
EZ
127612019-03-18 Eli Zaretskii <eliz@gnu.org>
12762
12763 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12764 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12765 it returns a newline. This fixes a regression in TU mode, whereby
12766 the next line is output on the same screen line as the user input.
12767
4bd56d18
TT
127682019-03-18 Tom Tromey <tromey@adacore.com>
12769
12770 * minsyms.c (minimal_symbol_reader::install): Remove call to
12771 obstack_blank.
12772
55c10aca
PA
127732019-03-18 Pedro Alves <palves@redhat.com>
12774
12775 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12776 New globals.
12777 (apply_style): New, factored out from ...
12778 (apply_ansi_escape): ... this. Handle reverse video mode.
12779 (tui_set_reverse_mode): New function.
12780 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12781 * tui/tui-winsource.c (tui_show_source_line): Use
12782 tui_set_reverse_mode instead of setting A_STANDOUT.
12783 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12784 New setter methods.
12785
647bb750
HD
127862019-03-18 Hannes Domani <ssbssa@yahoo.de>
12787
12788 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12789 Handle tabs.
12790
bff8c71f
TT
127912019-03-18 Tom Tromey <tromey@adacore.com>
12792
12793 * ada-lang.c (empty_array): Add "high" parameter.
12794 (ada_evaluate_subexp): Update.
12795
58785d98
ST
127962019-03-17 Sergei Trofimovich <siarheit@google.com>
12797
12798 * unittests/string_view-selftests.c: Define
12799 _initialize_string_view_selftests unconditionally.
12800
d4cbef22
ВМ
128012019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12802
12803 PR gdb/24350
12804 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12805
fce4c071
ВМ
128062019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12807
12808 PR gdb/24351
12809 * windows-nat.c (display_selector): Fix format specifiers.
12810
f7f0a123
EZ
128112019-03-17 Eli Zaretskii <eliz@gnu.org>
12812
12813 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12814 tui_refill_source_window instead of tui_refresh_win, to update the
12815 current execution line. This fixes redisplay of the current line
12816 when stepping through the code with "next" or "step".
12817
ab42892f
EZ
128182019-03-16 Eli Zaretskii <eliz@gnu.org>
12819
12820 * source-cache.c (source_cache::get_source_lines): Call
12821 find_source_lines to initialize s->nlines. This fixes vertical
12822 scrolling of TUI source window when the DOWN arrow is pressed.
12823
8d8c087f
PW
128242019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12825
12826 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12827 linux-thread-db.c (_initialize_thread_db): Likewise.
12828
798e1c30
EZ
128292019-03-16 Eli Zaretskii <eliz@gnu.org>
12830
12831 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12832 wclrtoeol in tui_show_source_line". This reverts changes made in
12833 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12834
eefba3da
TT
128352019-03-15 Tom Tromey <tom@tromey.com>
12836
12837 * symtab.h (struct minimal_symbol): Derive from
12838 general_symbol_info.
12839 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12840 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12841 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12842 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12843 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12844 (MSYMBOL_SEARCH_NAME): Update.
12845 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12846 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12847 * minsyms.c (minimal_symbol_reader::record_full): Update.
12848
0de2420c
TT
128492019-03-15 Tom Tromey <tom@tromey.com>
12850
12851 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12852
042d75e4
TT
128532019-03-15 Tom Tromey <tom@tromey.com>
12854
12855 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12856 unique_xmalloc_ptr.
12857 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12858 Update.
12859 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12860 (build_minimal_symbol_hash_tables)
12861 (minimal_symbol_reader::install): Update.
12862
db92718b
TT
128632019-03-15 Tom Tromey <tom@tromey.com>
12864
12865 * symtab.c (create_demangled_names_hash): Update.
12866 (symbol_set_names): Update.
12867 * objfiles.h (struct objfile_per_bfd_storage)
12868 <demangled_names_hash>: Now an htab_up.
12869 * objfiles.c (objfile_per_bfd_storage): Simplify.
12870
d6797f46
TT
128712019-03-15 Tom Tromey <tom@tromey.com>
12872
12873 * objfiles.h (struct objfile_per_bfd_storage): Declare
12874 destructor.
12875 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12876 New.
12877 (get_objfile_bfd_data): Use new. Don't initialize
12878 language_of_main.
12879 (free_objfile_per_bfd_storage): Remove.
12880 (objfile_bfd_data_free, objfile::~objfile): Use delete.
12881
741d7538
TT
128822019-03-15 Tom Tromey <tom@tromey.com>
12883
12884 * symfile.c (reread_symbols): Update.
12885 * objfiles.c (objfile::objfile): Update.
12886 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12887 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12888 comment.
12889 (minimal_symbol_reader::install): Update.
12890 (terminate_minimal_symbol_table): Remove.
12891 * jit.c (jit_object_close_impl): Update.
12892
788c80d1
TT
128932019-03-15 Tom Tromey <tom@tromey.com>
12894
12895 * minsyms.c (minimal_symbol_reader::record_full): Remove some
12896 initializations.
12897
1b7a07cb
TT
128982019-03-15 Tom Tromey <tom@tromey.com>
12899
12900 * objfiles.h (struct objfile_per_bfd_storage)
12901 <demangled_hash_languages>: Now a bitset.
12902 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12903 (lookup_minimal_symbol): Update.
12904
3db066bc
TT
129052019-03-15 Tom Tromey <tom@tromey.com>
12906
12907 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12908 Don't return the symbol.
12909 * coffread.c (record_minimal_symbol): Use record_full.
12910
3fff2c37
EZ
129112019-03-14 Eli Zaretskii <eliz@gnu.org>
12912
12913 The MS-Windows port of ncurses fails to switch to a color pair if
12914 one or both of the colors are the implicit default colors. This
12915 change records the default colors when TUI is initialized, and
12916 then specifies them explicitly when a color pair uses the default
12917 colors. This allows color styling in TUI mode on MS-Windows.
12918
12919 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
12920 ncurses_norm_attr.
12921 (tui_initialize_io) [__MINGW32__]: Record the default terminal
12922 colors in ncurses_norm_attr.
12923 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12924 "none", replace it with the default color recorded in
12925 ncurses_norm_attr.
12926
3b336828
TT
129272019-03-14 Tom Tromey <tromey@adacore.com>
12928
12929 * source-cache.h (class source_cache) <get_source_lines>: Return
12930 std::string.
12931 * source-cache.c (source_cache::extract_lines): Handle case where
12932 first_pos==npos. Return std::string.
12933 (source_cache::get_source_lines): Update.
12934
d085f989
TT
129352019-03-14 Tom Tromey <tromey@adacore.com>
12936
12937 * NEWS: Add item for "style sources" commands.
12938 * source-cache.c (source_cache::get_source_lines): Check
12939 source_styling.
12940 * cli/cli-style.c (source_styling): New global.
12941 (_initialize_cli_style): Add "style sources" commands.
12942 (show_style_sources): New function.
12943 * cli/cli-style.h (source_styling): Declare.
12944
6f11e682
TT
129452019-03-14 Pedro Alves <palves@redhat.com>
12946 Tom Tromey <tromey@adacore.com>
12947
12948 * tui/tui-winsource.h (tui_refill_source_window): Declare.
12949 * tui/tui-winsource.c (tui_refill_source_window): New function,
12950 from...
12951 (tui_horizontal_source_scroll): ... here. Move some logic.
12952 * cli/cli-style.c (set_style_enabled): Notify new observable.
12953 * tui/tui-hooks.c (tui_redisplay_source): New function.
12954 (tui_attach_detach_observers): Attach or detach
12955 tui_redisplay_source.
12956 * observable.h (source_styling_changed): New observable.
12957 * observable.c: Define source_styling_changed observable.
12958
a068643d
TT
129592019-03-13 Tom Tromey <tromey@adacore.com>
12960
12961 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12962 (i386_gnu_nat_target::store_registers): Update.
12963 * target-debug.h (target_debug_print_std_string): New macro.
12964 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12965 * windows-tdep.c (display_one_tib): Update.
12966 * tui/tui-stack.c (tui_make_status_line): Update.
12967 * top.c (print_inferior_quit_action): Update.
12968 * thread.c (thr_try_catch_cmd): Update.
12969 (add_thread_with_info): Update.
12970 (thread_target_id_str): Update.
12971 (thr_try_catch_cmd): Update.
12972 (thread_command): Update.
12973 (thread_find_command): Update.
12974 * record-btrace.c (record_btrace_target::info_record)
12975 (record_btrace_resume_thread, record_btrace_target::resume)
12976 (record_btrace_cancel_resume, record_btrace_step_thread)
12977 (record_btrace_target::wait, record_btrace_target::wait)
12978 (record_btrace_target::wait, record_btrace_target::stop): Update.
12979 * progspace.c (print_program_space): Update.
12980 * process-stratum-target.c
12981 (process_stratum_target::thread_address_space): Update.
12982 * linux-fork.c (linux_fork_mourn_inferior)
12983 (detach_checkpoint_command, info_checkpoints_command)
12984 (linux_fork_context): Update.
12985 (linux_fork_detach): Update.
12986 (class scoped_switch_fork_info): Update.
12987 (delete_checkpoint_command): Update.
12988 * infrun.c (follow_fork_inferior): Update.
12989 (follow_fork_inferior): Update.
12990 (proceed_after_vfork_done): Update.
12991 (handle_vfork_child_exec_or_exit): Update.
12992 (follow_exec): Update.
12993 (displaced_step_prepare_throw): Update.
12994 (displaced_step_restore): Update.
12995 (start_step_over): Update.
12996 (resume_1): Update.
12997 (clear_proceed_status_thread): Update.
12998 (proceed): Update.
12999 (print_target_wait_results): Update.
13000 (do_target_wait): Update.
13001 (context_switch): Update.
13002 (stop_all_threads): Update.
13003 (restart_threads): Update.
13004 (finish_step_over): Update.
13005 (handle_signal_stop): Update.
13006 (switch_back_to_stepped_thread): Update.
13007 (keep_going_pass_signal): Update.
13008 (print_exited_reason): Update.
13009 (normal_stop): Update.
13010 * inferior.c (inferior_pid_to_str): Change return type.
13011 (print_selected_inferior): Update.
13012 (add_inferior): Update.
13013 (detach_inferior): Update.
13014 * dummy-frame.c (fprint_dummy_frames): Update.
13015 * dcache.c (dcache_info_1): Update.
13016 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13017 (btrace_fetch, btrace_clear): Update.
13018 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13019 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13020 type.
13021 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13022 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13023 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13024 * gdbarch.c, gdbarch.h: Rebuild.
13025 * gdbarch.sh (core_pid_to_str): Change return type.
13026 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13027 return type.
13028 (windows_nat_target::pid_to_str): Change return type.
13029 (windows_delete_thread): Update.
13030 (windows_nat_target::attach): Update.
13031 (windows_nat_target::files_info): Update.
13032 * target-delegates.c: Rebuild.
13033 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13034 return type.
13035 (sol_thread_target::pid_to_str): Change return type.
13036 * remote.c (class remote_target) <pid_to_str>: Change return
13037 type.
13038 (remote_target::pid_to_str): Change return type.
13039 (extended_remote_target::attach, remote_target::remote_stop_ns)
13040 (remote_target::remote_notif_remove_queued_reply)
13041 (remote_target::push_stop_reply, remote_target::disable_btrace):
13042 Update.
13043 (extended_remote_target::attach): Update.
13044 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13045 type.
13046 (gdbsim_target::pid_to_str): Change return type.
13047 * ravenscar-thread.c (struct ravenscar_thread_target)
13048 <pid_to_str>: Change return type.
13049 (ravenscar_thread_target::pid_to_str): Change return type.
13050 * procfs.c (class procfs_target) <pid_to_str>: Change return
13051 type.
13052 (procfs_target::pid_to_str): Change return type.
13053 (procfs_target::attach): Update.
13054 (procfs_target::detach): Update.
13055 (procfs_target::fetch_registers): Update.
13056 (procfs_target::store_registers): Update.
13057 (procfs_target::wait): Update.
13058 (procfs_target::files_info): Update.
13059 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13060 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13061 return type.
13062 (nto_procfs_target::pid_to_str): Change return type.
13063 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13064 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13065 return type.
13066 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13067 (exit_lwp): Update.
13068 (attach_proc_task_lwp_callback, get_detach_signal)
13069 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13070 (linux_nat_target::resume, wait_lwp, stop_callback)
13071 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13072 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13073 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13074 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13075 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13076 type.
13077 (inf_ptrace_target::attach): Update.
13078 (inf_ptrace_target::files_info): Update.
13079 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13080 type.
13081 (go32_nat_target::pid_to_str): Change return type.
13082 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13083 (gnu_nat_target::wait): Update.
13084 (gnu_nat_target::wait): Update.
13085 (gnu_nat_target::resume): Update.
13086 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13087 (fbsd_nat_target::wait): Update.
13088 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13089 type.
13090 (darwin_nat_target::attach): Update.
13091 * corelow.c (class core_target) <pid_to_str>: Change return type.
13092 (core_target::pid_to_str): Change return type.
13093 * target.c (normal_pid_to_str): Change return type.
13094 (default_pid_to_str): Likewise.
13095 (target_pid_to_str): Change return type.
13096 (target_translate_tls_address): Update.
13097 (target_announce_detach): Update.
13098 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13099 return type.
13100 (bsd_uthread_target::pid_to_str): Change return type.
13101 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13102 type.
13103 (bsd_kvm_target::pid_to_str): Change return type.
13104 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13105 return type.
13106 (aix_thread_target::pid_to_str): Change return type.
13107 * target.h (struct target_ops) <pid_to_str>: Change return type.
13108 (target_pid_to_str, normal_pid_to_str): Likewise.
13109 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13110 type.
13111 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13112 type.
13113 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13114 return type.
13115 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13116 type.
13117 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13118 type.
13119 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13120 return type.
13121
b4be1b06
SM
131222019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13123
13124 * NEWS: Mention that the new default MI version is 3. Mention
13125 changes to the output of commands and events that deal with
13126 multi-location breakpoints.
13127 * breakpoint.c: Include "mi/mi-out.h".
13128 (print_one_breakpoint): Change output syntax if using MI version
13129 >= 3.
13130 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13131 New.
13132 (mi_multi_location_breakpoint_output_fixed): New.
13133 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13134 (mi_cmd_fix_multi_location_breakpoint_output): New.
13135 (mi_multi_location_breakpoint_output_fixed): New.
13136 * mi/mi-cmds.c (mi_cmds): Register command
13137 -fix-multi-location-breakpoint-output.
13138 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13139 interpreter "mi".
13140
8e5e5494
SM
131412019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13142
13143 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13144 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13145 instantiate mi_ui_out based on interpreter name.
13146 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13147 * mi/mi-main.c (mi_load_progress): Likewise.
13148
197df35e
JB
131492019-03-12 John Baldwin <jhb@FreeBSD.org>
13150
13151 * NEWS: Combine separate "New targets" sections for 8.3.
13152
8399425f
JB
131532019-03-12 John Baldwin <jhb@FreeBSD.org>
13154
13155 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13156 (ppcfbsd_init_abi): Install gdbarch
13157 "fetch_tls_load_module_address" and "get_thread_local_address"
13158 methods.
13159
b0f87ed0
JB
131602019-03-12 John Baldwin <jhb@FreeBSD.org>
13161
13162 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13163 (riscv_fbsd_init_abi): Install gdbarch
13164 "fetch_tls_load_module_address" and "get_thread_local_address"
13165 methods.
13166
ce25aa57
JB
131672019-03-12 John Baldwin <jhb@FreeBSD.org>
13168
13169 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13170 (i386fbsd_init_abi): Install gdbarch
13171 "fetch_tls_load_module_address" and "get_thread_local_address"
13172 methods.
13173
f5424cfa
JB
131742019-03-12 John Baldwin <jhb@FreeBSD.org>
13175
13176 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13177 (amd64fbsd_init_abi): Install gdbarch
13178 "fetch_tls_load_module_address" and "get_thread_local_address"
13179 methods.
13180
945f3901
JB
131812019-03-12 John Baldwin <jhb@FreeBSD.org>
13182
13183 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13184 (struct fbsd_pspace_data): New type.
13185 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13186 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13187 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13188 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13189 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13190
ef0bd204
JB
131912019-03-12 John Baldwin <jhb@FreeBSD.org>
13192
13193 * gdbtypes.c (lookup_struct_elt): New function.
13194 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13195 * gdbtypes.h (struct struct_elt): New type.
13196 (lookup_struct_elt): New prototype.
13197
36c53a02
JB
131982019-03-12 John Baldwin <jhb@FreeBSD.org>
13199
13200 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13201 remove disabled code block.
13202
6e056c81
JB
132032019-03-12 John Baldwin <jhb@FreeBSD.org>
13204
13205 * gdbarch.sh (get_thread_local_address): New method.
13206 * gdbarch.h, gdbarch.c: Regenerate.
13207 * target.c (target_translate_tls_address): Use
13208 gdbarch_get_thread_local_address if present instead of
13209 target::get_thread_local_address.
13210
cd250a18
JB
132112019-03-12 John Baldwin <jhb@FreeBSD.org>
13212
13213 * target.h (target::get_thread_local_address): Update comment.
13214
df22c1e5
JB
132152019-03-12 John Baldwin <jhb@FreeBSD.org>
13216
13217 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13218 objfile->separate_debug_objfile_backlink if not NULL.
13219
dd6876c9
JB
132202019-03-12 John Baldwin <jhb@FreeBSD.org>
13221
13222 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13223 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13224 (amd64bsd_store_inferior_registers): Likewise.
13225 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13226 Enable segment base registers.
13227 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13228 PT_GETFSBASE and PT_GETGSBASE.
13229 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13230 PT_SETGSBASE.
13231 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13232 segment base registers.
13233 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13234
1163a4b7
JB
132352019-03-12 John Baldwin <jhb@FreeBSD.org>
13236
13237 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13238 Update calls to i386_target_description to add 'segments'
13239 parameter.
13240 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13241 add segment base registers.
13242 * arch/i386.c (i386_create_target_description): Add 'segments'
13243 parameter to enable segment base registers.
13244 * arch/i386.h (i386_create_target_description): Likewise.
13245 * features/i386/32bit-segments.xml: New file.
13246 * features/i386/32bit-segments.c: Generate.
13247 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13248 call to i386_target_description to add 'segments' parameter.
13249 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13250 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13251 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13252 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13253 if feature is present.
13254 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13255 Add 'segments' parameter to call to i386_target_description.
13256 (i386_target_description): Add 'segments' parameter to enable
13257 segment base registers.
13258 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13259 to call to i386_target_description.
13260 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13261 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13262 Define I386_NUM_REGS.
13263 (i386_target_description): Add 'segments' parameter to enable
13264 segment base registers.
13265
3a350822
EZ
132662019-03-12 Eli Zaretskii <eliz@gnu.org>
13267
13268 PR/24325
13269 * source-cache.c: #undef open and close, to avoid unresolved
13270 externals during linking.
13271
ffdd69cf
TT
132722019-03-12 Tom Tromey <tromey@adacore.com>
13273
13274 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13275 const. Add initializers.
13276 (_initialize_remote): Don't initialize ptid globals.
13277
ec148c57
PA
132782019-03-12 Pedro Alves <palves@redhat.com>
13279
13280 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13281
32764270
PA
132822019-03-12 Pedro Alves <palves@redhat.com>
13283
13284 * cp-name-parser.y (main): Remove unused 'len' variable.
13285
17547186
TT
132862019-03-12 Tom Tromey <tromey@adacore.com>
13287
13288 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13289 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13290
d3a70e03
TT
132912019-03-12 Tom Tromey <tromey@adacore.com>
13292
13293 * linux-nat.c (iterate_over_lwps): Update.
13294 (stop_callback): Remove parameter.
13295 (stop_wait_callback, detach_callback, resume_set_callback)
13296 (select_singlestep_lwp_callback, set_ignore_sigint)
13297 (status_callback, resumed_callback, resume_clear_callback)
13298 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13299 data parameter.
13300 (linux_nat_target::detach, linux_nat_target::resume)
13301 (linux_stop_and_wait_all_lwps, select_event_lwp)
13302 (linux_nat_filter_event, linux_nat_wait_1)
13303 (linux_nat_target::kill, linux_nat_target::stop)
13304 (linux_nat_target::stop): Update.
13305 (linux_nat_resume_callback): Change type.
13306 (resume_stopped_resumed_lwps, count_events_callback)
13307 (select_event_lwp_callback): Likewise.
13308 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13309 * arm-linux-nat.c (struct update_registers_data): Remove.
13310 (update_registers_callback): Change type.
13311 (arm_linux_insert_hw_breakpoint1): Update.
13312 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13313 parameter.
13314 (x86_linux_dr_set_addr): Update.
13315 (x86_linux_dr_set_control): Update.
13316 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13317 (iterate_over_lwps): Use gdb::function_view.
13318 * nat/aarch64-linux-hw-point.c (struct
13319 aarch64_dr_update_callback_param): Remove.
13320 (debug_reg_change_callback): Change type.
13321 (aarch64_notify_debug_reg_change): Update.
13322 * s390-linux-nat.c (s390_refresh_per_info): Update.
13323
82cb27ff
TT
133242019-03-11 Tom Tromey <tromey@adacore.com>
13325
13326 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13327 redundant assignment to "this_cu".
13328
568c0683
SM
133292019-03-08 Simon Marchi <simon.marchi@efficios.com>
13330
13331 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13332
f09ce22d
SM
133332019-03-08 Simon Marchi <simon.marchi@efficios.com>
13334
13335 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13336 from...
13337 (rank_one_type): ... this.
13338
595f96a9
SM
133392019-03-08 Simon Marchi <simon.marchi@efficios.com>
13340
13341 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13342 from...
13343 (rank_one_type): ... this.
13344
2598a94b
SM
133452019-03-08 Simon Marchi <simon.marchi@efficios.com>
13346
13347 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13348 from...
13349 (rank_one_type): ... this.
13350
7f17b20d
SM
133512019-03-08 Simon Marchi <simon.marchi@efficios.com>
13352
13353 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13354 from...
13355 (rank_one_type): ... this.
13356
2c509035
SM
133572019-03-08 Simon Marchi <simon.marchi@efficios.com>
13358
13359 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13360 from...
13361 (rank_one_type): ... this.
13362
0dd322dc
SM
133632019-03-08 Simon Marchi <simon.marchi@efficios.com>
13364
13365 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13366 from...
13367 (rank_one_type): ... this.
13368
41ea4728
SM
133692019-03-08 Simon Marchi <simon.marchi@efficios.com>
13370
13371 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13372 from...
13373 (rank_one_type): ... this.
13374
793cd1d2
SM
133752019-03-08 Simon Marchi <simon.marchi@efficios.com>
13376
13377 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13378 from...
13379 (rank_one_type): ... this.
13380
34910087
SM
133812019-03-08 Simon Marchi <simon.marchi@efficios.com>
13382
13383 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13384 from...
13385 (rank_one_type): ... this.
13386
f1f832d6
SM
133872019-03-08 Simon Marchi <simon.marchi@efficios.com>
13388
13389 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13390 from...
13391 (rank_one_type): ... this.
13392
b9f4512f
SM
133932019-03-08 Simon Marchi <simon.marchi@efficios.com>
13394
13395 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13396 from...
13397 (rank_one_type): ... this.
13398
9293fc63
SM
133992019-03-08 Simon Marchi <simon.marchi@efficios.com>
13400
13401 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13402 from...
13403 (rank_one_type): ... this.
13404
e3abbe7e
PW
134052019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13406
13407 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13408 inferior-events' shows the example events.
13409
e4adb939
EZ
134102019-03-08 Eli Zaretskii <eliz@gnu.org>
13411
13412 Support styling on native MS-Windows console
13413
13414 PR/24315
13415 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13416 on MS-Windows if $TERM is not defined.
13417
13418 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13419
13420 * posix-hdep.c (gdb_console_fputs):
13421 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13422 functions.
13423 * ui-file.h (gdb_console_fputs): Add prototype.
13424
13425 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13426 back to fputs only if the former returns zero.
13427
25629dfd
TT
134282019-03-07 Tom Tromey <tom@tromey.com>
13429
13430 * symmisc.c (print_symbol_bcache_statistics): Update.
13431 (print_objfile_statistics): Update.
13432 * symfile.c (allocate_symtab): Update.
13433 * stabsread.c: Don't include bcache.h.
13434 * psymtab.h (struct psymbol_bcache): Don't declare.
13435 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13436 (psymbol_bcache_init, psymbol_bcache_free)
13437 (psymbol_bcache_get_bcache): Don't declare.
13438 * psymtab.c (struct psymbol_bcache): Remove.
13439 (psymtab_storage::psymtab_storage): Update.
13440 (psymtab_storage::~psymtab_storage): Update.
13441 (psymbol_bcache_init, psymbol_bcache_free)
13442 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13443 (add_psymbol_to_bcache): Update.
13444 (allocate_psymtab): Update.
13445 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13446 macro_cache>: No longer pointers.
13447 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13448 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13449 * macrotab.c (macro_bcache): Update.
13450 * macroexp.c: Don't include bcache.h.
13451 * gdbtypes.c (check_types_worklist): Update.
13452 (types_deeply_equal): Remove TRY/CATCH. Update.
13453 * elfread.c (elf_symtab_read): Update.
13454 * dwarf2read.c: Don't include bcache.h.
13455 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13456 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13457 (print_bcache_statistics, bcache_memory_used): Don't declare.
13458 (struct bcache): Move from bcache.c. Add constructor, destructor,
13459 methods. Rename all data members.
13460 * bcache.c (struct bcache): Move to bcache.h.
13461 (bcache::expand_hash_table): Rename from expand_hash_table.
13462 (bcache): Remove.
13463 (bcache::insert): Rename from bcache_full.
13464 (bcache::compare): Rename from bcache_compare.
13465 (bcache_xmalloc): Remove.
13466 (bcache::~bcache): Rename from bcache_xfree.
13467 (bcache::print_statistics): Rename from print_bcache_statistics.
13468 (bcache::memory_used): Rename from bcache_memory_used.
13469
fe726667
PA
134702019-03-07 Pedro Alves <palves@redhat.com>
13471
13472 * infrun.c (normal_stop): Also check for
13473 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13474
7584bb30
AB
134752019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13476
13477 * f-lang.c (value_from_host_double): Moved to...
13478 * value.c (value_from_host_double): ...here.
13479 * value.h (value_from_host_double): Declare.
13480 * guile/scm-math.c (vlscm_convert_typed_number): Use
13481 value_from_host_double.
13482 (vlscm_convert_number): Likewise.
13483 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13484 * python/py-value.c (convert_value_from_python): Likewise.
13485
a7b1986e
TT
134862019-03-06 Tom Tromey <tom@tromey.com>
13487
13488 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13489
0ccf4211
TT
134902019-03-06 Tom Tromey <tom@tromey.com>
13491
13492 * utils.h (free_current_contents): Don't declare.
13493 * utils.c (free_current_contents): Remove.
13494
fe7b42e5
TT
134952019-03-06 Tom Tromey <tom@tromey.com>
13496
13497 * top.c (quit_force): Update.
13498 * main.c (captured_command_loop): Update.
13499 * common/new-op.c (operator new): Update.
13500 * common/common-exceptions.c (struct catcher)
13501 <save_cleanup_chain>: Remove member.
13502 (exceptions_state_mc_init): Update.
13503 (exception_try_scope_entry): Return nullptr.
13504 (exception_try_scope_exit, exception_rethrow)
13505 (throw_exception_sjlj, throw_exception_cxx): Update.
13506 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13507 (all_cleanups, do_cleanups, discard_cleanups)
13508 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13509 (restore_cleanups, restore_final_cleanups): Don't declare.
13510 (do_final_cleanups): Remove parameter.
13511 * common/cleanups.c (cleanup_chain, make_cleanup)
13512 (make_cleanup_dtor, all_cleanups, do_cleanups)
13513 (discard_my_cleanups, discard_cleanups)
13514 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13515 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13516 (null_cleanup): Remove.
13517 (do_final_cleanups): Remove parameter.
13518
c6321f19
TT
135192019-03-06 Tom Tromey <tom@tromey.com>
13520
13521 * remote.c (remote_target::remote_parse_stop_reply): Use
13522 unique_xmalloc_ptr.
13523
61b30099
TT
135242019-03-06 Tom Tromey <tom@tromey.com>
13525
13526 * stabsread.c (struct stabs_field_info): Rename from field_info.
13527 <list, fnlist>: Add initializers.
13528 <obstack>: New member.
13529 (read_member_functions, read_struct_fields, read_baseclasses):
13530 Allocate on obstack. Don't use cleanups.
13531 (read_one_struct_field, read_member_functions, read_struct_fields)
13532 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13533 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13534 (read_struct_type): Update.
13535
6cceac94
TT
135362019-03-06 Tom Tromey <tom@tromey.com>
13537
13538 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13539 * common/filestuff.h (make_cleanup_close): Don't declare.
13540 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13541 Remove.
13542
72412762
TT
135432019-03-06 Tom Tromey <tom@tromey.com>
13544
13545 * solib-aix.c: Use make_scope_exit.
13546
2b6ff1c0
TT
135472019-03-06 Tom Tromey <tom@tromey.com>
13548
13549 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13550 Use make_scope_exit.
13551
d01c5877
TT
135522019-03-06 Tom Tromey <tom@tromey.com>
13553
13554 * solib-svr4.c (disable_probes_interface): Remove parameter.
13555 (svr4_handle_solib_event): Use make_scope_exit.
13556
32603266
TT
135572019-03-06 Tom Tromey <tom@tromey.com>
13558
13559 * remote.c (struct stop_reply_deleter): Remove.
13560 (stop_reply_up): Update.
13561 (struct stop_reply): Derive from notif_event. Don't typedef.
13562 <regcache>: Now a std::vector.
13563 (stop_reply_xfree): Remove.
13564 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13565 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13566 (remote_target::discard_pending_stop_replies): Use delete.
13567 (remote_target::remote_parse_stop_reply): Update.
13568 (remote_target::process_stop_reply): Update.
13569 * remote-notif.h (struct notif_event): Add virtual destructor.
13570 Remove "dtr" member.
13571 (struct notif_client) <alloc_event>: Return a unique_ptr.
13572 (notif_event_xfree): Don't declare.
13573 (notif_event_up): New typedef.
13574 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13575 (notif_event_xfree, do_notif_event_xfree): Remove.
13576 (remote_notif_state_xfree): Update.
13577
9799571e
TT
135782019-03-06 Tom Tromey <tom@tromey.com>
13579
13580 * infrun.c (displaced_step_clear_cleanup): Now a
13581 forward_scope_exit type.
13582 (displaced_step_prepare_throw): Update.
13583 (displaced_step_fixup): Update.
13584
09e3c4ca
TT
135852019-03-06 Tom Tromey <tom@tromey.com>
13586
13587 * inferior.h (class inferior): Update comment.
13588 * gdbthread.h (class thread_info): Update comment.
13589
e2a03548
TT
135902019-03-06 Joel Brobecker <brobecker@adacore.com>
13591 Tom Tromey <tom@tromey.com>
13592
13593 * stabsread.h (struct stab_section_list): Remove.
13594 (coffstab_build_psymtabs): Update.
13595 * dbxread.c (symbuf_sections): Now a std::vector.
13596 (sect_idx): New global.
13597 (fill_symbuf): Update.
13598 (coffstab_build_psymtabs): Change type of stabsects parameter.
13599 Update.
13600 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13601 std::vector.
13602 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13603 (coff_locate_sections): Update.
13604 (coff_symfile_read): Remove cleanups. Update.
13605 (init_stringtab): Add storage parameter.
13606 (free_stringtab, free_stringtab_cleanup): Remove.
13607 (init_lineno): Add storage parameter.
13608 (free_linetab, free_linetab_cleanup): Remove.
13609
b7e60d85
PA
136102019-03-06 Pedro Alves <palves@redhat.com>
13611
13612 * linux-fork.c (fork_info::clobber_regs): Delete.
13613 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13614 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13615 comment. Adjust.
13616 (scoped_switch_fork_info::scoped_switch_fork_info)
13617 (checkpoint_command, linux_fork_context): Adjust
13618 fork_save_infrun_state calls.
13619
e52c971f
PA
136202019-03-06 Pedro Alves <palves@redhat.com>
13621
13622 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13623 (inf_has_multiple_threads): Return 'bool' and rewrite using
13624 inferior_info::threads().
13625
06974e6c
PA
136262019-03-06 Pedro Alves <palves@redhat.com>
13627
13628 * linux-fork.c: Include <list>.
13629 (fork_list): Now a std::list instance.
13630 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13631 (forks_exist_p, find_last_fork): Adjust.
13632 (new_fork): Delete.
13633 (one_fork_p): New.
13634 (add_fork): Adjust.
13635 (free_fork): Delete, folded into fork_info::~fork_info().
13636 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13637 Adjust.
13638 (init_fork_list): Delete.
13639 (linux_fork_killall, linux_fork_mourn_inferior)
13640 (linux_fork_detach, info_checkpoints_command): Adjust.
13641 (_initialize_linux_fork): No longer call init_fork_list.
13642
72f31aea
PA
136432019-03-06 Pedro Alves <palves@redhat.com>
13644
13645 * linux-fork.c (new_fork): New, split out of ...
13646 (add_fork): ... this. Return void. Move "first fork" special
13647 case from here, to ...
13648 (checkpoint_command): ... here.
13649 * linux-linux.h (add_fork): Return void.
13650
efbecbc1
AB
136512019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13652
13653 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13654
0841c79a
AB
136552019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13656 Chris January <chris.january@arm.com>
13657 David Lecomber <david.lecomber@arm.com>
13658
13659 * f-exp.y: New token, UNOP_INTRINSIC.
13660 (exp): New pattern using UNOP_INTRINSIC token.
13661 (f77_keywords): Add 'abs' keyword.
13662 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13663 (value_from_host_double): New function.
13664 (evaluate_subexp_f): Support UNOP_ABS.
13665
4a270568
AB
136662019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13667
13668 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13669 types.
13670
067630bd
AB
136712019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13672
13673 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13674 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13675 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13676
3be47f7a
AB
136772019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13678
13679 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13680
4d00f5d8
AB
136812019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13682 Chris January <chris.january@arm.com>
13683
13684 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13685 * f-exp.y: Define 'KIND' token.
13686 (exp): New pattern for KIND expressions.
13687 (ptype): Handle types with a kind extension.
13688 (direct_abs_decl): Extend to spot kind extensions.
13689 (f77_keywords): Add 'kind' to the list.
13690 (push_kind_type): New function.
13691 (convert_to_kind_type): New function.
13692 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13693 * parse.c (operator_length_standard): Likewise.
13694 * parser-defs.h (enum type_pieces): Add tp_kind.
13695 * std-operator.def: Add UNOP_KIND.
13696
e454224f
AB
136972019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13698
13699 * f-exp.y (f_parse): Set yydebug.
13700
9dad4a58
AB
137012019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13702
13703 * f-lang.c (evaluate_subexp_f): New function.
13704 (exp_descriptor_f): New global.
13705 (f_language_defn): Use exp_descriptor_f instead of
13706 exp_descriptor_standard.
13707
c8f91604
AB
137082019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13709
13710 * f-exp.y (struct token): Add comments.
13711 (dot_ops): Remove uppercase versions and the end marker.
13712 (f77_keywords): Likewise.
13713 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13714 entries in the dot_ops array are case insensitive, and use
13715 strncasecmp to compare strings. Also some whitespace cleanup in
13716 this area. Similar for the f77_keywords array, except entries in
13717 this list might be case sensitive.
13718
dd9f2c76
AB
137192019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13720
13721 * f-exp.y (struct f77_boolean_val): Add comments.
13722 (boolean_values): Remove uppercase versions, and end marker.
13723 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13724 and use strncasecmp to achieve case insensitivity. Additionally,
13725 perform whitespace cleanup around this code.
13726
67a3048c
TT
137272019-03-06 Tom Tromey <tromey@adacore.com>
13728
13729 * remote-sim.c (gdbsim_target_open): Use result of
13730 gdb_argv::release.
13731
aa3cfbda
RB
137322019-03-06 Richard Bunt <richard.bunt@arm.com>
13733 Dirk Schubert <dirk.schubert@arm.com>
13734 Chris January <chris.january@arm.com>
13735
13736 * eval.c (evaluate_subexp_standard): Call Fortran argument
13737 wrapping logic.
13738 * f-lang.c (struct value): A value which can be passed into a
13739 Fortran function call.
13740 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13741 where appropriate.
13742 (struct type): Value ready for a Fortran function call.
13743 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13744 is needed.
13745 * f-lang.h (fortran_argument_convert): Declaration.
13746 (fortran_preserve_arg_pointer): Declaration.
13747 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13748
ea38e5df
TT
137492019-03-05 Tom Tromey <tromey@adacore.com>
13750
13751 * python/py-prettyprint.c (print_string_repr): Remove #if.
13752 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13753
06b5b831
TT
137542019-03-05 Tom Tromey <tromey@adacore.com>
13755
13756 * target.c (the_dummy_target): Move later. Change type to
13757 "dummy_target".
13758 (initialize_targets): Don't initialize the_dummy_target.
13759
edbd9e45
TT
137602019-03-05 Tom Tromey <tromey@adacore.com>
13761
13762 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13763 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13764
c119e040
TT
137652019-03-05 Tom Tromey <tromey@adacore.com>
13766
13767 * windows-nat.c (windows_nat_target::attach)
13768 (windows_nat_target::detach): Don't call gdb_flush.
13769 * valprint.c (generic_val_print, val_print, val_print_string):
13770 Don't call gdb_flush.
13771 * utils.c (defaulted_query): Don't call gdb_flush.
13772 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13773 * target.c (target_announce_detach): Don't call gdb_flush.
13774 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13775 * remote.c (extended_remote_target::attach): Don't call
13776 gdb_flush.
13777 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13778 * printcmd.c (do_examine): Don't call gdb_flush.
13779 (info_display_command): Don't call gdb_flush.
13780 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13781 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13782 * memattr.c (info_mem_command): Don't call gdb_flush.
13783 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13784 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13785 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13786 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13787 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13788 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13789 (gnu_nat_target::detach): Don't call gdb_flush.
13790 * f-valprint.c (f_val_print): Don't call gdb_flush.
13791 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13792 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13793 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13794 gdb_flush.
13795 * c-valprint.c (c_val_print): Don't call gdb_flush.
13796 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13797
895dafa6
TT
137982019-03-05 Tom Tromey <tromey@adacore.com>
13799
13800 * varobj.c (update_dynamic_varobj_children): Update.
13801 (install_default_visualizer): Use reset, not release.
13802 * value.c (set_internalvar): Update.
13803 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13804 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13805 ATTRIBUTE_UNUSED_RESULT.
13806
88a774b9
TT
138072019-03-05 Tom Tromey <tromey@adacore.com>
13808
13809 * remote.c (class scoped_remote_fd) <release>: Add
13810 ATTRIBUTE_UNUSED_RESULT.
13811
4e4a8b93
TT
138122019-03-05 Tom Tromey <tromey@adacore.com>
13813
13814 * macroexp.c (struct macro_buffer) <release>: Add
13815 ATTRIBUTE_UNUSED_RESULT.
13816
083eef1f
TT
138172019-03-05 Tom Tromey <tromey@adacore.com>
13818
13819 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13820 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13821 ATTRIBUTE_UNUSED_RESULT.
13822
3cabd438
TT
138232019-03-05 Tom Tromey <tromey@adacore.com>
13824
13825 * common/scoped_fd.h (class scoped_fd) <release>: Add
13826 ATTRIBUTE_UNUSED_RESULT.
13827
41e3300a
TT
138282019-03-05 Tom Tromey <tromey@adacore.com>
13829
13830 * parser-defs.h (struct parser_state) <release>: Add
13831 ATTRIBUTE_UNUSED_RESULT.
13832
18cb7c9f
TT
138332019-03-05 Tom Tromey <tromey@adacore.com>
13834
13835 * utils.h (class gdb_argv) <release>: Add
13836 ATTRIBUTE_UNUSED_RESULT.
13837 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13838
41fa577f
EZ
138392019-03-02 Eli Zaretskii <eliz@gnu.org>
13840
a6a4b2c6
EZ
13841 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13842 for-loop range, to avoid compiler warnings.
13843
13844 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13845 avoid compiler warnings about unused variables.
13846
742a7df5
EZ
13847 * NEWS: Mention end of support for native debugging on MS-Windows
13848 before XP.
13849
41fa577f
EZ
13850 PR gdb/24292
13851 * common/netstuff.c:
13852 * gdbserver/gdbreplay.c
13853 * gdbserver/remote-utils.c:
13854 * ser-tcp.c:
13855 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13856 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13857 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13858 'getaddrinfo' and 'freeaddrinfo' were not available before
13859 Windows XP, and mingw.org's MinGW headers by default define
13860 _WIN32_WINNT to 0x500.
13861
827f438f
GB
138622019-03-01 Gary Benson <gbenson@redhat.com>
13863
13864 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13865
92137da0
RO
138662019-02-28 Brian Vandenberg <phantall@gmail.com>
13867 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13868
13869 PR gdb/8527
13870 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13871 set_sigint_trap, clear_sigint_trap.
13872
799efbe8
PW
138732019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13874
13875 * target.c (target_detach): Clear the regcache and the
13876 frame cache.
13877
8ed25214
PA
138782019-02-27 Pedro Alves <palves@redhat.com>
13879
13880 * utils.c (set_screen_size): When we cap the height/width sizes,
13881 tweak the corresponding command variable to show "unlimited":
13882
23031e31
SJ
138832019-02-27 Saagar Jha <saagar@saagarjha.com>
13884 Pedro Alves <palves@redhat.com>
13885
13886 * utils.c (set_screen_size): Reduce "infinite" rows and columns
13887 before calling rl_set_screen_size.
13888
6c28e44a
TT
138892019-02-27 Tom Tromey <tromey@adacore.com>
13890
13891 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13892 define.
13893 * python/py-value.c: Remove Python 2.4 workaround.
13894 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13895 workaround.
13896 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13897 Python 2.4 workaround.
13898 * python/python-internal.h: Remove Python 2.4 comment.
13899 (Py_ssize_t): Don't define.
13900 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13901 (gdb_Py_DECREF): Remove Python 2.4 workaround.
13902 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13903 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13904 * python/python.c (do_start_initialization): Remove Python 2.4
13905 workaround.
13906 * python/py-prettyprint.c (class dummy_python_frame): Remove.
13907 (print_children): Remove Python 2.4 workaround.
13908 * python/py-inferior.c (buffer_procs): Remove Python 2.4
13909 workaround.
13910 (CHARBUFFERPROC_NAME): Remove.
13911 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13912 Python 2.4 workaround.
13913
2c3fc25d 139142019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 13915
2c3fc25d
KB
13916 * NEWS: Note minimum Python version.
13917
6ca62222
KB
139182019-02-27 Kevin Buettner <kevinb@redhat.com>
13919
13920 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13921 code from these functions. Remove corresponding ifdefs. Use
13922 Py_buffer_up instead of explicit calls to PyBuffer_Release.
13923 Remove gotos and target of gotos.
13924 (infpy_search_memory): Likewise.
13925
f4bc7d2c
AB
139262019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13927
13928 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13929 (hppa_gdbarch_init): Don't register deleted functions with
13930 gdbarch.
13931
9734a586
AB
139322019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13933
13934 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13935 (h8300_unwind_sp): Delete.
13936 (h8300_dummy_id): Delete.
13937 (h8300_gdbarch_init): Don't register deleted functions with
13938 gdbarch.
13939
68b867f3
AB
139402019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13941
13942 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13943 (ft32_unwind_pc): Delete.
13944 (ft32_unwind_sp): Delete.
13945 (ft32_gdbarch_init): Don't register deleted functions with
13946 gdbarch.
13947
2fbe7ad0
AB
139482019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13949
13950 * gdb/frv-tdep.c (frv_dummy_id): Delete.
13951 (frv_unwind_pc): Delete.
13952 (frv_unwind_sp): Delete.
13953 (frv_gdbarch_init): Don't register deleted functions with
13954 gdbarch.
13955
76055cbe
AB
139562019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13957
13958 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13959 (riscv_unwind_pc): Delete.
13960 (riscv_unwind_sp): Delete.
13961 (riscv_gdbarch_init): Don't register deleted functions with
13962 gdbarch.
13963
4133e5a1
AB
139642019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13965
13966 * gdb/csky-tdep.c (csky_dummy_id): Delete.
13967 (csky_unwind_pc): Delete.
13968 (csky_unwind_sp): Delete.
13969 (csky_gdbarch_init): Don't register deleted functions with
13970 gdbarch.
13971
8010f576
AB
139722019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13973
13974 * gdb/cris-tdep.c (cris_dummy_id): Delete.
13975 (cris_unwind_pc): Delete.
13976 (cris_unwind_sp): Delete.
13977 (cris_gdbarch_init): Don't register deleted functions with
13978 gdbarch.
13979
b56bf084
AB
139802019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13981
13982 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13983 (bfin_unwind_pc): Delete.
13984 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13985
a19a650f
AB
139862019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13987
13988 * gdb/arm-tdep.c (arm_dummy_id): Delete.
13989 (arm_unwind_pc): Delete.
13990 (arm_unwind_sp): Delete.
13991 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13992
f8278c3c
AB
139932019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13994
13995 * gdb/arc-tdep.c (arc_dummy_id): Delete.
13996 (arc_unwind_pc): Delete.
13997 (arc_unwind_sp): Delete.
13998 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13999
480e46cf
AB
140002019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14001
14002 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14003 (alpha_unwind_pc): Delete.
14004 (alpha_gdbarch_init): Don't register deleted functions with
14005 gdbarch.
14006
7a995095
AB
140072019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14008
14009 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14010 (aarch64_unwind_pc): Delete.
14011 (aarch64_unwind_sp): Delete.
14012 (aarch64_gdbarch_init): Don't register deleted functions with
14013 gdbarch.
14014
bf9a735e
AB
140152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14016
14017 * gdbtypes.c (type_align): Don't consider static members when
14018 computing structure alignment.
14019
5561fc30
AB
140202019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14021
14022 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14023 return 0 for other types.
14024 * arch-utils.c (default_type_align): Always return 0.
14025 * gdbarch.h: Regenerate.
14026 * gdbarch.sh (type_align): Extend comment.
14027 * gdbtypes.c (type_align): Add additional comments, always call
14028 gdbarch_type_align before applying the default rules.
14029 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14030 generic code will then apply a suitable default.
14031 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14032 types, return 0 for other types.
14033
9335e75a
JB
140342019-02-27 Joel Brobecker <brobecker@adacore.com>
14035
14036 * NEWS: Create a new section for the next release branch.
14037 Rename the section of the current branch, now that it has
14038 been cut.
14039
3d34d8de
JB
140402019-02-27 Joel Brobecker <brobecker@adacore.com>
14041
14042 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14043 * version.in: Bump version to 8.3.50.DATE-git.
14044
143420fb
SM
140452019-02-26 Simon Marchi <simon.marchi@efficios.com>
14046
14047 * aix-thread.c (ptid_cmp): Remove unused variable.
14048 (get_signaled_thread): Likewise.
14049 (store_regs_user_thread): Likewise.
14050 (store_regs_kernel_thread): Likewise.
14051 (fetch_regs_kernel_thread): Remove shadowed variable.
14052
172fb711
AB
140532019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14054
14055 * features/riscv/32bit-cpu.xml: Add register numbers.
14056 * features/riscv/32bit-fpu.c: Regenerate.
14057 * features/riscv/32bit-fpu.xml: Add register numbers.
14058 * features/riscv/64bit-cpu.xml: Add register numbers.
14059 * features/riscv/64bit-fpu.c: Regenerate.
14060 * features/riscv/64bit-fpu.xml: Add register numbers.
14061
26c89782
KB
140622019-02-26 Kevin Buettner <kevinb@redhat.com>
14063
af54ade9 14064 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
14065 * python/py-value.c (convert_buffer_and_type_to_value): New
14066 function.
14067 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14068 Add support for handling an optional second argument. Call
14069 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
14070 * python/python-internal.h (Py_buffer_deleter): New struct.
14071 (Py_buffer_up): New typedef.
14072
0f58c9e8
JB
140732019-02-25 John Baldwin <jhb@FreeBSD.org>
14074
14075 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14076 instead of releasing ownership.
14077
0a0f4c01
JR
140782019-02-25 Jordan Rupprecht <rupprecht@google.com>
14079
14080 * dwarf2read.c (open_and_init_dwp_file): Call
14081 elf_numsections instead of bfd_count_sections to initialize
14082 dwp_file->num_sections.
14083
cd5a152c
TT
140842019-02-25 Tom Tromey <tromey@adacore.com>
14085
14086 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14087
8a6a8513
SDJ
140882019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14089
14090 * gcore.in: Add '--readnever' option when invoking GDB.
14091
04dcda9c
SM
140922019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14093
14094 * MAINTAINERS: Update my email address.
14095
07bc701d
SM
140962019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14097
14098 * build-id.c (build_id_to_debug_bfd_1): New function.
14099 (build_id_to_debug_bfd): Look for separate debug file in
14100 sysroot.
14101
c6f4a5d0
AB
141022019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14103
14104 * gdbarch.sh: Update the copyright year range that is placed into
14105 generated files.
14106
9600246d
KS
141072019-02-22 Keith Seitz <keiths@redhat.com>
14108
14109 PR symtab/23853
14110 * linespec.c (create_sals_line_offset): Search for the default
14111 symtab's filename instead of its fullname.
14112
7557a514
AH
141132019-02-21 Alan Hayward <alan.hayward@arm.com>
14114
14115 * NEWS: Update style defaults.
14116
ee2bcb0c
AH
141172019-02-21 Alan Hayward <alan.hayward@arm.com>
14118
14119 * main.c (captured_main_1): Disable styling in batch mode.
14120
0c95f9ed
TT
141212019-02-20 Tom Tromey <tom@tromey.com>
14122
14123 * symtab.c (symtab_symbol_info): Fix typos.
14124
c763b894
TT
141252019-02-20 Tom Tromey <tromey@adacore.com>
14126
14127 * findcmd.c (_initialize_mem_search): Use upper case for
14128 metasyntactic variables.
14129
0ef8a082
AH
141302019-02-20 Alan Hayward <alan.hayward@arm.com>
14131
14132 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14133 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14134
6caa91b6
SM
141352019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14136
14137 * top.h (source_file_name): Change to std::string.
14138 * top.c (source_file_name): Likewise.
14139 (command_line_input): Adjust.
14140 * cli/cli-script.c (script_from_file): Adjust.
14141
98814c6c
TT
141422019-02-19 Tom Tromey <tromey@adacore.com>
14143
14144 * ravenscar-thread.c
14145 (ravenscar_thread_target::update_thread_list): Don't call
14146 ada_build_task_list.
14147 * ada-lang.h (ada_build_task_list): Don't declare.
14148 * ada-tasks.c (struct ada_tasks_inferior_data)
14149 <task_list_valid_p>: Now bool.
14150 (read_known_tasks, ada_task_list_changed)
14151 (ada_tasks_invalidate_inferior_data): Update.
14152 (read_known_tasks_array): Return bool.
14153 (read_known_tasks_list): Likewise.
14154 (read_known_tasks): Return void.
14155 (ada_build_task_list): Now static.
14156
70cd633e
AB
141572019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14158
14159 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14160 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14161
040b3e95
PW
141622019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14163
14164 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14165 variant for ada_tasks_pspace_data_handle and
14166 ada_tasks_inferior_data_handle.
14167 (ada_tasks_pspace_data_cleanup): New function.
14168 (ada_tasks_inferior_data_cleanup): New function.
14169
9409233b
TT
141702019-02-17 Tom Tromey <tom@tromey.com>
14171
14172 * macrotab.h (macro_source_fullname): Return a std::string.
14173 * macrotab.c (macro_include, check_for_redefinition)
14174 (macro_undef, macro_lookup_definition, foreach_macro)
14175 (foreach_macro_in_scope): Update.
14176 (macro_source_fullname): Return a std::string.
14177 * macrocmd.c (show_pp_source_pos): Update.
14178
6506371f
TT
141792019-02-17 Tom Tromey <tom@tromey.com>
14180
14181 * macrocmd.c (show_pp_source_pos): Style the file names.
14182
0c820d67
TT
141832019-02-17 Tom Tromey <tom@tromey.com>
14184
14185 PR tui/24197:
14186 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14187
a0087920
TT
141882019-02-17 Tom Tromey <tom@tromey.com>
14189
14190 * ada-lang.c (user_select_syms): Use filtered printing.
14191 * utils.c (wrap_style): New global.
14192 (desired_style): Remove.
14193 (emit_style_escape): Add stream parameter.
14194 (set_output_style, reset_terminal_style, prompt_for_continue):
14195 Update.
14196 (flush_wrap_buffer): Only flush gdb_stdout.
14197 (wrap_here): Set wrap_style.
14198 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14199 treat escape sequences as a character. Change when wrap buffer is
14200 flushed.
14201 (fputs_styled): Do not set the output style when the default is
14202 requested.
14203 * ui-style.h (struct ui_file_style) <is_default>: New method.
14204 * source.c (print_source_lines_base): Emit escape sequences in one
14205 piece.
14206
75ba10dc
JB
142072019-02-17 Joel Brobecker <brobecker@adacore.com>
14208
14209 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14210 integers and enumeration types.
14211
a2cd4f14
JB
142122019-02-17 Joel Brobecker <brobecker@adacore.com>
14213
14214 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14215 instead of lookup_symbol_in_language
14216 (do_exact_match): New function.
14217 (ada_get_symbol_name_matcher): Return do_exact_match when
14218 doing a verbatim match.
14219
485b851b
TT
142202019-02-15 Tom Tromey <tromey@adacore.com>
14221
14222 * ravenscar-thread.c (ravenscar_thread_target::resume)
14223 (ravenscar_thread_target::wait): Special case wildcard requests.
14224
0b790b1e
TT
142252019-02-15 Tom Tromey <tromey@adacore.com>
14226
14227 * ravenscar-thread.c (base_ptid): Remove.
14228 (struct ravenscar_thread_target) <close>: New method.
14229 <m_base_ptid>: New member.
14230 <update_inferior_ptid, active_task, task_is_currently_active,
14231 runtime_initialized>: Declare methods.
14232 <ravenscar_thread_target>: Add constructor.
14233 (ravenscar_thread_target::task_is_currently_active)
14234 (ravenscar_thread_target::update_inferior_ptid)
14235 (ravenscar_runtime_initialized): Rename. Now methods.
14236 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14237 (ravenscar_thread_target::update_thread_list): Update.
14238 (ravenscar_thread_target::active_task): Now method.
14239 (ravenscar_thread_target::store_registers)
14240 (ravenscar_thread_target::prepare_to_store)
14241 (ravenscar_thread_target::prepare_to_store)
14242 (ravenscar_thread_target::mourn_inferior): Update.
14243 (ravenscar_inferior_created): Use "new" to create target.
14244 (ravenscar_thread_target::get_ada_task_ptid): Update.
14245 (_initialize_ravenscar): Don't initialize base_ptid.
14246 (ravenscar_ops): Remove global.
14247
dea57a62
TT
142482019-02-15 Tom Tromey <tromey@adacore.com>
14249
14250 * target.h (push_target): Declare new overload.
14251 * target.c (push_target): New overload, taking an rvalue reference.
14252 * remote.c (remote_target::open_1): Use push_target overload.
14253 * corelow.c (core_target_open): Use push_target overload.
14254
989f3c58
TT
142552019-02-15 Tom Tromey <tromey@adacore.com>
14256
14257 * ravenscar-thread.c (is_ravenscar_task)
14258 (ravenscar_task_is_currently_active): Return bool.
14259 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14260 (_initialize_ravenscar): Remove "(void)".
14261 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14262 Return bool.
14263
6cbcc006
TT
142642019-02-15 Tom Tromey <tromey@adacore.com>
14265
14266 * ravenscar-thread.c (ravenscar_runtime_initializer)
14267 (has_ravenscar_runtime, get_running_thread_id)
14268 (ravenscar_thread_target::resume): Fix indentation.
14269
7657f14d
TT
142702019-02-15 Tom Tromey <tromey@adacore.com>
14271
14272 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14273 from ravenscar_arch_ops.
14274 (sparc_ravenscar_ops::fetch_registers)
14275 (sparc_ravenscar_ops::store_registers): Now methods.
14276 (sparc_ravenscar_prepare_to_store): Remove.
14277 (sparc_ravenscar_ops): Redefine.
14278 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14279 methods and destructor. Remove members.
14280 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14281 (ravenscar_thread_target::store_registers)
14282 (ravenscar_thread_target::prepare_to_store): Update.
14283 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14284 Remove.
14285 (struct ppc_ravenscar_powerpc_ops): Derive from
14286 ravenscar_arch_ops.
14287 (ppc_ravenscar_powerpc_ops::fetch_registers)
14288 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14289 (ppc_ravenscar_powerpc_ops): Redefine.
14290 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14291 (ppc_ravenscar_e500_ops::fetch_registers)
14292 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14293 (ppc_ravenscar_e500_ops): Redefine.
14294 * aarch64-ravenscar-thread.c
14295 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14296 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14297 (aarch64_ravenscar_fetch_registers)
14298 (aarch64_ravenscar_store_registers): Now methods.
14299 (aarch64_ravenscar_ops): Redefine.
14300
5b6ea500
TT
143012019-02-15 Tom Tromey <tromey@adacore.com>
14302
14303 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14304 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14305 (ravenscar_thread_target::stopped_by_watchpoint)
14306 (ravenscar_thread_target::stopped_data_address)
14307 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14308
e397fd39
TT
143092019-02-15 Tom Tromey <tromey@adacore.com>
14310
14311 * ravenscar-thread.c: Fix some typos.
14312
cc12f4a8
TT
143132019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14314 Tom Tromey <tromey@adacore.com>
14315
14316 * ada-lang.c (ada_exception_sal): Change addr_string to a
14317 std::string.
14318 (create_ada_exception_catchpoint): Update.
14319
5f486660
TT
143202019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14321 Tom Tromey <tromey@adacore.com>
14322
14323 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14324 (bp_location_ops): Remove.
14325 (base_breakpoint_allocate_location): Update.
14326 (free_bp_location): Update.
14327 * ada-lang.c (class ada_catchpoint_location)
14328 <ada_catchpoint_location>: Remove ops parameter.
14329 (ada_catchpoint_location_dtor): Remove.
14330 (ada_catchpoint_location_ops): Remove.
14331 (allocate_location_exception): Update.
14332 * breakpoint.h (struct bp_location_ops): Remove.
14333 (class bp_location) <bp_location>: Remove bp_location_ops
14334 parameter.
14335 <~bp_location>: Add destructor.
14336 <ops>: Remove.
14337
b671c7fb
TS
143382019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14339 Pedro Alves <palves@redhat.com>
14340
14341 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14342 'PATH_MAX'.
14343
8071c5ce
DM
143442019-02-14 David Michael <fedora.dm0@gmail.com>
14345 Samuel Thibault <samuel.thibault@gnu.org>
14346 Thomas Schwinge <thomas@codesourcery.com>
14347
14348 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14349 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14350
b1041ae0
TS
143512019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14352
924514e1
TS
14353 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14354 (check_empty): Use "const char *".
14355
c29ee8d4
TS
14356 * gnu-nat.c (gnu_nat_target::detach): Instead of
14357 'detach_inferior (pid)' call
14358 'detach_inferior (find_inferior_pid (pid))'.
14359
6c6ef69f
TS
14360 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14361 'nat/fork-inferior.o'.
14362 * gnu-nat.c: #include "nat/fork-inferior.h".
14363
2d0a338c
TS
14364 * gnu-nat.c (gnu_nat_target::detach): Instead of
14365 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14366 * gnu-nat.h: #include "inf-child.h".
14367 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14368 'i386_gnu_nat_target::fetch_registers'.
14369 (gnu_store_registers): Rename/move to
14370 'i386_gnu_nat_target::store_registers'.
14371
cabb5f06
TS
14372 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14373 * gnu-nat.h (mach_thread_info): New function.
14374 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14375
b1041ae0
TS
14376 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14377
2988d01e
KF
143782019-02-14 Frederic Konrad <konrad@adacore.com>
14379
14380 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14381
c559d709
JB
143822019-02-14 Joel Brobecker <brobecker@adacore.com>
14383
14384 * windows-nat.c (windows_add_thread): Add new parameter
14385 "main_thread_p" with default value set to false. Update
14386 function documentation as well as all callers.
14387 (windows_delete_thread): Likewise.
14388 (fake_create_process): Update call to windows_add_thread.
14389 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14390 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14391 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14392 call to windows_delete_thread.
14393
007024cc
SM
143942019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14395
14396 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14397
f62318e9
JB
143982019-02-12 John Baldwin <jhb@FreeBSD.org>
14399
14400 * symfile.c (find_separate_debug_file): Use canonical path of
14401 sysroot with child_path instead of gdb_sysroot if it is valid.
14402
cd4b7848
JB
144032019-02-12 John Baldwin <jhb@FreeBSD.org>
14404
14405 * symfile.c (find_separate_debug_file): Use child_path to
14406 determine if an object file is under a sysroot.
14407
efac4bfe
JB
144082019-02-12 John Baldwin <jhb@FreeBSD.org>
14409
14410 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14411 unittests/child-path-selftests.c.
14412 * common/pathstuff.c (child_path): New function.
14413 * common/pathstuff.h (child_path): New prototype.
14414 * unittests/child-path-selftests.c: New file.
14415
402d2bfe
JB
144162019-02-12 John Baldwin <jhb@FreeBSD.org>
14417
14418 * symfile.c (find_separate_debug_file): Look for separate debug
14419 files in debug directories under the sysroot.
14420
1ed9f74e
PW
144212019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14422
14423 * symtab.h (struct minimal_symbol data_p): New const method.
14424 (struct minimal_symbol text_p): Likewise.
14425 * symtab.c (output_source_filename): Use file name style
14426 to print file name.
14427 (print_symbol_info): Likewise.
14428 (print_msymbol_info): Use address style to print addresses.
14429 Use function name style to print executable text symbols.
14430 (expand_symtab_containing_pc): Use data_p.
14431 (find_pc_sect_compunit_symtab): Likewise.
14432
2636d81d
PW
144332019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14434
14435 * breakpoint.c (describe_other_breakpoints): Use address style
14436 to print addresses.
14437 (say_where): Likewise.
14438
ac8c53cc
PW
144392019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14440
14441 * ada-typeprint.c (print_func_type): Print function name
14442 style to print function name.
14443 * c-typeprint.c (c_print_type_1): Likewise.
14444
ea638c43
AH
144452019-02-11 Alan Hayward <alan.hayward@arm.com>
14446
14447 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14448 for execve.
14449
ab759ca8
PW
144502019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14451
14452 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14453 type_stack.
14454
aff29d1c
JB
144552019-02-10 Joel Brobecker <brobecker@adacore.com>
14456
14457 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14458 TYPE_CODE_REF types.
14459
617126bc
JW
144602019-02-08 Jim Wilson <jimw@sifive.com>
14461
14462 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14463 (riscv_linux_fregset): New.
14464 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14465
46e3ed7f
TT
144662019-02-07 Tom Tromey <tom@tromey.com>
14467
14468 * thread.c (thread_cancel_execution_command): Update.
14469 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14470 methods.
14471 (struct thread_fsm_ops): Remove.
14472 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14473 (thread_fsm_should_stop, thread_fsm_return_value)
14474 (thread_fsm_set_finished, thread_fsm_finished_p)
14475 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14476 Don't declare.
14477 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14478 * infrun.c (clear_proceed_status_thread)
14479 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14480 (print_stop_event): Update.
14481 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14482 Add constructor.
14483 (step_command_fsm_ops): Remove.
14484 (new_step_command_fsm): Remove.
14485 (step_1): Update.
14486 (step_command_fsm::should_stop): Rename from
14487 step_command_fsm_should_stop.
14488 (step_command_fsm::clean_up): Rename from
14489 step_command_fsm_clean_up.
14490 (step_command_fsm::do_async_reply_reason): Rename from
14491 step_command_fsm_async_reply_reason.
14492 (struct until_next_fsm): Inherit from thread_fsm. Add
14493 constructor.
14494 (until_next_fsm_ops): Remove.
14495 (new_until_next_fsm): Remove.
14496 (until_next_fsm::should_stop): Rename from
14497 until_next_fsm_should_stop.
14498 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14499 (until_next_fsm::do_async_reply_reason): Rename from
14500 until_next_fsm_async_reply_reason.
14501 (struct finish_command_fsm): Inherit from thread_fsm. Add
14502 constructor. Change type of breakpoint.
14503 (finish_command_fsm_ops): Remove.
14504 (new_finish_command_fsm): Remove.
14505 (finish_command_fsm::should_stop): Rename from
14506 finish_command_fsm_should_stop.
14507 (finish_command_fsm::clean_up): Rename from
14508 finish_command_fsm_clean_up.
14509 (finish_command_fsm::return_value): Rename from
14510 finish_command_fsm_return_value.
14511 (finish_command_fsm::do_async_reply_reason): Rename from
14512 finish_command_fsm_async_reply_reason.
14513 (finish_command): Update.
14514 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14515 Add constructor.
14516 (call_thread_fsm_ops): Remove.
14517 (call_thread_fsm::call_thread_fsm): Rename from
14518 new_call_thread_fsm.
14519 (call_thread_fsm::should_stop): Rename from
14520 call_thread_fsm_should_stop.
14521 (call_thread_fsm::should_notify_stop): Rename from
14522 call_thread_fsm_should_notify_stop.
14523 (run_inferior_call, call_function_by_hand_dummy): Update.
14524 * cli/cli-interp.c (should_print_stop_to_console): Update.
14525 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14526 Add constructor. Change type of location_breakpoint,
14527 caller_breakpoint.
14528 (until_break_fsm_ops): Remove.
14529 (new_until_break_fsm): Remove.
14530 (until_break_fsm::should_stop): Rename from
14531 until_break_fsm_should_stop.
14532 (until_break_fsm::clean_up): Rename from
14533 until_break_fsm_clean_up.
14534 (until_break_fsm::do_async_reply_reason): Rename from
14535 until_break_fsm_async_reply_reason.
14536 (until_break_command): Update.
14537 * thread-fsm.c: Remove.
14538 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14539
1a5c2598
TT
145402019-02-07 Tom Tromey <tom@tromey.com>
14541
14542 * yy-remap.h: Add include guard.
14543 * xtensa-tdep.h: Add include guard.
14544 * xcoffread.h: Rename include guard.
14545 * varobj-iter.h: Add include guard.
14546 * tui/tui.h: Rename include guard.
14547 * tui/tui-winsource.h: Rename include guard.
14548 * tui/tui-wingeneral.h: Rename include guard.
14549 * tui/tui-windata.h: Rename include guard.
14550 * tui/tui-win.h: Rename include guard.
14551 * tui/tui-stack.h: Rename include guard.
14552 * tui/tui-source.h: Rename include guard.
14553 * tui/tui-regs.h: Rename include guard.
14554 * tui/tui-out.h: Rename include guard.
14555 * tui/tui-layout.h: Rename include guard.
14556 * tui/tui-io.h: Rename include guard.
14557 * tui/tui-hooks.h: Rename include guard.
14558 * tui/tui-file.h: Rename include guard.
14559 * tui/tui-disasm.h: Rename include guard.
14560 * tui/tui-data.h: Rename include guard.
14561 * tui/tui-command.h: Rename include guard.
14562 * tic6x-tdep.h: Add include guard.
14563 * target/waitstatus.h: Rename include guard.
14564 * target/wait.h: Rename include guard.
14565 * target/target.h: Rename include guard.
14566 * target/resume.h: Rename include guard.
14567 * target-float.h: Rename include guard.
14568 * stabsread.h: Add include guard.
14569 * rs6000-tdep.h: Add include guard.
14570 * riscv-fbsd-tdep.h: Add include guard.
14571 * regformats/regdef.h: Rename include guard.
14572 * record.h: Rename include guard.
14573 * python/python.h: Rename include guard.
14574 * python/python-internal.h: Rename include guard.
14575 * python/py-stopevent.h: Rename include guard.
14576 * python/py-ref.h: Rename include guard.
14577 * python/py-record.h: Rename include guard.
14578 * python/py-record-full.h: Rename include guard.
14579 * python/py-record-btrace.h: Rename include guard.
14580 * python/py-instruction.h: Rename include guard.
14581 * python/py-events.h: Rename include guard.
14582 * python/py-event.h: Rename include guard.
14583 * procfs.h: Add include guard.
14584 * proc-utils.h: Add include guard.
14585 * p-lang.h: Add include guard.
14586 * or1k-tdep.h: Rename include guard.
14587 * observable.h: Rename include guard.
14588 * nto-tdep.h: Rename include guard.
14589 * nat/x86-linux.h: Rename include guard.
14590 * nat/x86-linux-dregs.h: Rename include guard.
14591 * nat/x86-gcc-cpuid.h: Add include guard.
14592 * nat/x86-dregs.h: Rename include guard.
14593 * nat/x86-cpuid.h: Rename include guard.
14594 * nat/ppc-linux.h: Rename include guard.
14595 * nat/mips-linux-watch.h: Rename include guard.
14596 * nat/linux-waitpid.h: Rename include guard.
14597 * nat/linux-ptrace.h: Rename include guard.
14598 * nat/linux-procfs.h: Rename include guard.
14599 * nat/linux-osdata.h: Rename include guard.
14600 * nat/linux-nat.h: Rename include guard.
14601 * nat/linux-namespaces.h: Rename include guard.
14602 * nat/linux-btrace.h: Rename include guard.
14603 * nat/glibc_thread_db.h: Rename include guard.
14604 * nat/gdb_thread_db.h: Rename include guard.
14605 * nat/gdb_ptrace.h: Rename include guard.
14606 * nat/fork-inferior.h: Rename include guard.
14607 * nat/amd64-linux-siginfo.h: Rename include guard.
14608 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14609 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14610 * nat/aarch64-linux.h: Rename include guard.
14611 * nat/aarch64-linux-hw-point.h: Rename include guard.
14612 * mn10300-tdep.h: Add include guard.
14613 * mips-linux-tdep.h: Add include guard.
14614 * mi/mi-parse.h: Rename include guard.
14615 * mi/mi-out.h: Rename include guard.
14616 * mi/mi-main.h: Rename include guard.
14617 * mi/mi-interp.h: Rename include guard.
14618 * mi/mi-getopt.h: Rename include guard.
14619 * mi/mi-console.h: Rename include guard.
14620 * mi/mi-common.h: Rename include guard.
14621 * mi/mi-cmds.h: Rename include guard.
14622 * mi/mi-cmd-break.h: Rename include guard.
14623 * m2-lang.h: Add include guard.
14624 * location.h: Rename include guard.
14625 * linux-record.h: Rename include guard.
14626 * linux-nat.h: Add include guard.
14627 * linux-fork.h: Add include guard.
14628 * i386-darwin-tdep.h: Rename include guard.
14629 * hppa-linux-offsets.h: Add include guard.
14630 * guile/guile.h: Rename include guard.
14631 * guile/guile-internal.h: Rename include guard.
14632 * gnu-nat.h: Rename include guard.
14633 * gdb-stabs.h: Rename include guard.
14634 * frv-tdep.h: Add include guard.
14635 * f-lang.h: Add include guard.
14636 * event-loop.h: Add include guard.
14637 * darwin-nat.h: Rename include guard.
14638 * cp-abi.h: Rename include guard.
14639 * config/sparc/nm-sol2.h: Rename include guard.
14640 * config/nm-nto.h: Rename include guard.
14641 * config/nm-linux.h: Add include guard.
14642 * config/i386/nm-i386gnu.h: Rename include guard.
14643 * config/djgpp/nl_types.h: Rename include guard.
14644 * config/djgpp/langinfo.h: Rename include guard.
14645 * compile/gcc-cp-plugin.h: Add include guard.
14646 * compile/gcc-c-plugin.h: Add include guard.
14647 * compile/compile.h: Rename include guard.
14648 * compile/compile-object-run.h: Rename include guard.
14649 * compile/compile-object-load.h: Rename include guard.
14650 * compile/compile-internal.h: Rename include guard.
14651 * compile/compile-cplus.h: Rename include guard.
14652 * compile/compile-c.h: Rename include guard.
14653 * common/xml-utils.h: Rename include guard.
14654 * common/x86-xstate.h: Rename include guard.
14655 * common/version.h: Rename include guard.
14656 * common/vec.h: Rename include guard.
14657 * common/tdesc.h: Rename include guard.
14658 * common/selftest.h: Rename include guard.
14659 * common/scoped_restore.h: Rename include guard.
14660 * common/scoped_mmap.h: Rename include guard.
14661 * common/scoped_fd.h: Rename include guard.
14662 * common/safe-iterator.h: Rename include guard.
14663 * common/run-time-clock.h: Rename include guard.
14664 * common/refcounted-object.h: Rename include guard.
14665 * common/queue.h: Rename include guard.
14666 * common/ptid.h: Rename include guard.
14667 * common/print-utils.h: Rename include guard.
14668 * common/preprocessor.h: Rename include guard.
14669 * common/pathstuff.h: Rename include guard.
14670 * common/observable.h: Rename include guard.
14671 * common/netstuff.h: Rename include guard.
14672 * common/job-control.h: Rename include guard.
14673 * common/host-defs.h: Rename include guard.
14674 * common/gdb_wait.h: Rename include guard.
14675 * common/gdb_vecs.h: Rename include guard.
14676 * common/gdb_unlinker.h: Rename include guard.
14677 * common/gdb_unique_ptr.h: Rename include guard.
14678 * common/gdb_tilde_expand.h: Rename include guard.
14679 * common/gdb_sys_time.h: Rename include guard.
14680 * common/gdb_string_view.h: Rename include guard.
14681 * common/gdb_splay_tree.h: Rename include guard.
14682 * common/gdb_setjmp.h: Rename include guard.
14683 * common/gdb_ref_ptr.h: Rename include guard.
14684 * common/gdb_optional.h: Rename include guard.
14685 * common/gdb_locale.h: Rename include guard.
14686 * common/gdb_assert.h: Rename include guard.
14687 * common/filtered-iterator.h: Rename include guard.
14688 * common/filestuff.h: Rename include guard.
14689 * common/fileio.h: Rename include guard.
14690 * common/environ.h: Rename include guard.
14691 * common/common-utils.h: Rename include guard.
14692 * common/common-types.h: Rename include guard.
14693 * common/common-regcache.h: Rename include guard.
14694 * common/common-inferior.h: Rename include guard.
14695 * common/common-gdbthread.h: Rename include guard.
14696 * common/common-exceptions.h: Rename include guard.
14697 * common/common-defs.h: Rename include guard.
14698 * common/common-debug.h: Rename include guard.
14699 * common/cleanups.h: Rename include guard.
14700 * common/buffer.h: Rename include guard.
14701 * common/btrace-common.h: Rename include guard.
14702 * common/break-common.h: Rename include guard.
14703 * cli/cli-utils.h: Rename include guard.
14704 * cli/cli-style.h: Rename include guard.
14705 * cli/cli-setshow.h: Rename include guard.
14706 * cli/cli-script.h: Rename include guard.
14707 * cli/cli-interp.h: Rename include guard.
14708 * cli/cli-decode.h: Rename include guard.
14709 * cli/cli-cmds.h: Rename include guard.
14710 * charset-list.h: Add include guard.
14711 * buildsym-legacy.h: Rename include guard.
14712 * bfin-tdep.h: Add include guard.
14713 * ax.h: Rename include guard.
14714 * arm-linux-tdep.h: Add include guard.
14715 * arm-fbsd-tdep.h: Add include guard.
14716 * arch/xtensa.h: Rename include guard.
14717 * arch/tic6x.h: Add include guard.
14718 * arch/i386.h: Add include guard.
14719 * arch/arm.h: Rename include guard.
14720 * arch/arm-linux.h: Rename include guard.
14721 * arch/arm-get-next-pcs.h: Rename include guard.
14722 * arch/amd64.h: Add include guard.
14723 * arch/aarch64-insn.h: Rename include guard.
14724 * arch-utils.h: Rename include guard.
14725 * annotate.h: Add include guard.
14726 * amd64-darwin-tdep.h: Rename include guard.
14727 * aarch64-linux-tdep.h: Add include guard.
14728 * aarch64-fbsd-tdep.h: Add include guard.
14729 * aarch32-linux-nat.h: Add include guard.
14730
ab9268d2
PW
147312019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14732
14733 * macrotab.c (macro_define_internal): New function that
14734 factorizes macro_define_object_internal and macro_define_function
14735 code.
14736 (macro_define_object_internal): Use macro_define_internal.
14737 (macro_define_function): Likewise.
14738
bb0da2b4
PW
147392019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14740
14741 * macrocmd.c (extract_identifier): Return
14742 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14743 callers.
14744
424eb552
JB
147452019-02-06 John Baldwin <jhb@FreeBSD.org>
14746
14747 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14748
1688cb29
TT
147492019-02-05 Tom Tromey <tom@tromey.com>
14750
14751 * target.c (target_stack::unpush): Move assertion earlier.
14752
b5eba2d8
TT
147532019-01-30 Tom Tromey <tom@tromey.com>
14754
14755 PR python/23615:
14756 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14757 (gdbpy_parse_and_eval): Likewise.
14758 * python/python-internal.h (gdbpy_allow_threads): New class.
14759
7054e2ff
JB
147602019-01-28 John Baldwin <jhb@FreeBSD.org>
14761
14762 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14763 (aarch64_fbsd_fpregmap): Move earlier.
14764 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14765 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14766 instead of individual calls to trad_frame_set_reg_addr.
14767 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14768 earlier.
14769 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14770 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14771 instead of individual calls to trad_frame_set_reg_addr.
14772
36c25ffa
AH
147732019-01-28 Alan Hayward <alan.hayward@arm.com>
14774
14775 * CONTRIBUTE: Replace contribution list with wiki link.
14776
a0707f3c
TT
147772019-01-25 Tom Tromey <tom@tromey.com>
14778
14779 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14780
0747795c
TT
147812019-01-25 Tom Tromey <tom@tromey.com>
14782
14783 * xtensa-linux-nat.c: Fix common/ includes.
14784 * xml-support.h: Fix common/ includes.
14785 * xml-support.c: Fix common/ includes.
14786 * x86-linux-nat.c: Fix common/ includes.
14787 * windows-nat.c: Fix common/ includes.
14788 * varobj.h: Fix common/ includes.
14789 * varobj.c: Fix common/ includes.
14790 * value.c: Fix common/ includes.
14791 * valops.c: Fix common/ includes.
14792 * utils.c: Fix common/ includes.
14793 * unittests/xml-utils-selftests.c: Fix common/ includes.
14794 * unittests/utils-selftests.c: Fix common/ includes.
14795 * unittests/unpack-selftests.c: Fix common/ includes.
14796 * unittests/tracepoint-selftests.c: Fix common/ includes.
14797 * unittests/style-selftests.c: Fix common/ includes.
14798 * unittests/string_view-selftests.c: Fix common/ includes.
14799 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14800 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14801 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14802 * unittests/rsp-low-selftests.c: Fix common/ includes.
14803 * unittests/parse-connection-spec-selftests.c: Fix common/
14804 includes.
14805 * unittests/optional-selftests.c: Fix common/ includes.
14806 * unittests/offset-type-selftests.c: Fix common/ includes.
14807 * unittests/observable-selftests.c: Fix common/ includes.
14808 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14809 * unittests/memrange-selftests.c: Fix common/ includes.
14810 * unittests/memory-map-selftests.c: Fix common/ includes.
14811 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14812 * unittests/function-view-selftests.c: Fix common/ includes.
14813 * unittests/environ-selftests.c: Fix common/ includes.
14814 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14815 * unittests/common-utils-selftests.c: Fix common/ includes.
14816 * unittests/cli-utils-selftests.c: Fix common/ includes.
14817 * unittests/array-view-selftests.c: Fix common/ includes.
14818 * ui-file.c: Fix common/ includes.
14819 * tui/tui-io.c: Fix common/ includes.
14820 * tracepoint.h: Fix common/ includes.
14821 * tracepoint.c: Fix common/ includes.
14822 * tracefile-tfile.c: Fix common/ includes.
14823 * top.h: Fix common/ includes.
14824 * top.c: Fix common/ includes.
14825 * thread.c: Fix common/ includes.
14826 * target/waitstatus.h: Fix common/ includes.
14827 * target/waitstatus.c: Fix common/ includes.
14828 * target.h: Fix common/ includes.
14829 * target.c: Fix common/ includes.
14830 * target-memory.c: Fix common/ includes.
14831 * target-descriptions.c: Fix common/ includes.
14832 * symtab.h: Fix common/ includes.
14833 * symfile.c: Fix common/ includes.
14834 * stap-probe.c: Fix common/ includes.
14835 * spu-linux-nat.c: Fix common/ includes.
14836 * sparc-nat.c: Fix common/ includes.
14837 * source.c: Fix common/ includes.
14838 * solib.c: Fix common/ includes.
14839 * solib-target.c: Fix common/ includes.
14840 * ser-unix.c: Fix common/ includes.
14841 * ser-tcp.c: Fix common/ includes.
14842 * ser-pipe.c: Fix common/ includes.
14843 * ser-base.c: Fix common/ includes.
14844 * selftest-arch.c: Fix common/ includes.
14845 * s12z-tdep.c: Fix common/ includes.
14846 * rust-exp.y: Fix common/ includes.
14847 * rs6000-aix-tdep.c: Fix common/ includes.
14848 * riscv-tdep.c: Fix common/ includes.
14849 * remote.c: Fix common/ includes.
14850 * remote-notif.h: Fix common/ includes.
14851 * remote-fileio.h: Fix common/ includes.
14852 * remote-fileio.c: Fix common/ includes.
14853 * regcache.h: Fix common/ includes.
14854 * regcache.c: Fix common/ includes.
14855 * record-btrace.c: Fix common/ includes.
14856 * python/python.c: Fix common/ includes.
14857 * python/py-type.c: Fix common/ includes.
14858 * python/py-inferior.c: Fix common/ includes.
14859 * progspace.h: Fix common/ includes.
14860 * producer.c: Fix common/ includes.
14861 * procfs.c: Fix common/ includes.
14862 * proc-api.c: Fix common/ includes.
14863 * printcmd.c: Fix common/ includes.
14864 * ppc-linux-nat.c: Fix common/ includes.
14865 * parser-defs.h: Fix common/ includes.
14866 * osdata.c: Fix common/ includes.
14867 * obsd-nat.c: Fix common/ includes.
14868 * nat/x86-linux.c: Fix common/ includes.
14869 * nat/x86-linux-dregs.c: Fix common/ includes.
14870 * nat/x86-dregs.h: Fix common/ includes.
14871 * nat/x86-dregs.c: Fix common/ includes.
14872 * nat/ppc-linux.c: Fix common/ includes.
14873 * nat/mips-linux-watch.h: Fix common/ includes.
14874 * nat/mips-linux-watch.c: Fix common/ includes.
14875 * nat/linux-waitpid.c: Fix common/ includes.
14876 * nat/linux-ptrace.h: Fix common/ includes.
14877 * nat/linux-ptrace.c: Fix common/ includes.
14878 * nat/linux-procfs.c: Fix common/ includes.
14879 * nat/linux-personality.c: Fix common/ includes.
14880 * nat/linux-osdata.c: Fix common/ includes.
14881 * nat/linux-namespaces.c: Fix common/ includes.
14882 * nat/linux-btrace.h: Fix common/ includes.
14883 * nat/linux-btrace.c: Fix common/ includes.
14884 * nat/fork-inferior.c: Fix common/ includes.
14885 * nat/amd64-linux-siginfo.c: Fix common/ includes.
14886 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14887 * nat/aarch64-linux.c: Fix common/ includes.
14888 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14889 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14890 * namespace.h: Fix common/ includes.
14891 * mips-linux-tdep.c: Fix common/ includes.
14892 * minsyms.c: Fix common/ includes.
14893 * mi/mi-parse.h: Fix common/ includes.
14894 * mi/mi-main.c: Fix common/ includes.
14895 * mi/mi-cmd-env.c: Fix common/ includes.
14896 * memrange.h: Fix common/ includes.
14897 * memattr.c: Fix common/ includes.
14898 * maint.h: Fix common/ includes.
14899 * maint.c: Fix common/ includes.
14900 * main.c: Fix common/ includes.
14901 * machoread.c: Fix common/ includes.
14902 * location.c: Fix common/ includes.
14903 * linux-thread-db.c: Fix common/ includes.
14904 * linux-nat.c: Fix common/ includes.
14905 * linux-fork.c: Fix common/ includes.
14906 * inline-frame.c: Fix common/ includes.
14907 * infrun.c: Fix common/ includes.
14908 * inflow.c: Fix common/ includes.
14909 * inferior.h: Fix common/ includes.
14910 * inferior.c: Fix common/ includes.
14911 * infcmd.c: Fix common/ includes.
14912 * inf-ptrace.c: Fix common/ includes.
14913 * inf-child.c: Fix common/ includes.
14914 * ia64-linux-nat.c: Fix common/ includes.
14915 * i387-tdep.c: Fix common/ includes.
14916 * i386-tdep.c: Fix common/ includes.
14917 * i386-linux-tdep.c: Fix common/ includes.
14918 * i386-linux-nat.c: Fix common/ includes.
14919 * i386-go32-tdep.c: Fix common/ includes.
14920 * i386-fbsd-tdep.c: Fix common/ includes.
14921 * i386-fbsd-nat.c: Fix common/ includes.
14922 * guile/scm-type.c: Fix common/ includes.
14923 * guile/guile.c: Fix common/ includes.
14924 * go32-nat.c: Fix common/ includes.
14925 * gnu-nat.c: Fix common/ includes.
14926 * gdbthread.h: Fix common/ includes.
14927 * gdbarch-selftests.c: Fix common/ includes.
14928 * gdb_usleep.c: Fix common/ includes.
14929 * gdb_select.h: Fix common/ includes.
14930 * gdb_bfd.c: Fix common/ includes.
14931 * gcore.c: Fix common/ includes.
14932 * fork-child.c: Fix common/ includes.
14933 * findvar.c: Fix common/ includes.
14934 * fbsd-nat.c: Fix common/ includes.
14935 * event-top.c: Fix common/ includes.
14936 * event-loop.c: Fix common/ includes.
14937 * dwarf2read.c: Fix common/ includes.
14938 * dwarf2loc.c: Fix common/ includes.
14939 * dwarf2-frame.c: Fix common/ includes.
14940 * dwarf-index-cache.c: Fix common/ includes.
14941 * dtrace-probe.c: Fix common/ includes.
14942 * disasm-selftests.c: Fix common/ includes.
14943 * defs.h: Fix common/ includes.
14944 * csky-tdep.c: Fix common/ includes.
14945 * cp-valprint.c: Fix common/ includes.
14946 * cp-support.h: Fix common/ includes.
14947 * cp-support.c: Fix common/ includes.
14948 * corelow.c: Fix common/ includes.
14949 * completer.h: Fix common/ includes.
14950 * completer.c: Fix common/ includes.
14951 * compile/compile.c: Fix common/ includes.
14952 * compile/compile-loc2c.c: Fix common/ includes.
14953 * compile/compile-cplus-types.c: Fix common/ includes.
14954 * compile/compile-cplus-symbols.c: Fix common/ includes.
14955 * command.h: Fix common/ includes.
14956 * cli/cli-dump.c: Fix common/ includes.
14957 * cli/cli-cmds.c: Fix common/ includes.
14958 * charset.c: Fix common/ includes.
14959 * build-id.c: Fix common/ includes.
14960 * btrace.h: Fix common/ includes.
14961 * btrace.c: Fix common/ includes.
14962 * breakpoint.h: Fix common/ includes.
14963 * breakpoint.c: Fix common/ includes.
14964 * ax.h:
14965 (enum agent_op): Fix common/ includes.
14966 * ax-general.c (struct aop_map): Fix common/ includes.
14967 * ax-gdb.c: Fix common/ includes.
14968 * auxv.c: Fix common/ includes.
14969 * auto-load.c: Fix common/ includes.
14970 * arm-tdep.c: Fix common/ includes.
14971 * arch/riscv.c: Fix common/ includes.
14972 * arch/ppc-linux-common.c: Fix common/ includes.
14973 * arch/i386.c: Fix common/ includes.
14974 * arch/arm.c: Fix common/ includes.
14975 * arch/arm-linux.c: Fix common/ includes.
14976 * arch/arm-get-next-pcs.c: Fix common/ includes.
14977 * arch/amd64.c: Fix common/ includes.
14978 * arch/aarch64.c: Fix common/ includes.
14979 * arch/aarch64-insn.c: Fix common/ includes.
14980 * arch-utils.c: Fix common/ includes.
14981 * amd64-windows-tdep.c: Fix common/ includes.
14982 * amd64-tdep.c: Fix common/ includes.
14983 * amd64-sol2-tdep.c: Fix common/ includes.
14984 * amd64-obsd-tdep.c: Fix common/ includes.
14985 * amd64-nbsd-tdep.c: Fix common/ includes.
14986 * amd64-linux-tdep.c: Fix common/ includes.
14987 * amd64-linux-nat.c: Fix common/ includes.
14988 * amd64-fbsd-tdep.c: Fix common/ includes.
14989 * amd64-fbsd-nat.c: Fix common/ includes.
14990 * amd64-dicos-tdep.c: Fix common/ includes.
14991 * amd64-darwin-tdep.c: Fix common/ includes.
14992 * agent.c: Fix common/ includes.
14993 * ada-lang.h: Fix common/ includes.
14994 * ada-lang.c: Fix common/ includes.
14995 * aarch64-tdep.c: Fix common/ includes.
14996
2f5c153e
TT
149972019-01-25 Tom Tromey <tom@tromey.com>
14998
14999 * common/create-version.sh: Use common/version.h.
15000
adc6a863
PA
150012019-01-24 Pedro Alves <palves@redhat.com>
15002
15003 * infrun.c (signal_stop, signal_print, signal_program)
15004 (signal_catch, signal_pass): Now arrays instead of pointers.
15005 (update_signals_program_target, do_target_resume)
15006 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15007 * linux-nat.c (linux_nat_target::pass_signals)
15008 (linux_nat_target::create_inferior, linux_nat_target::attach):
15009 Adjust.
15010 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15011 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15012 * procfs.c (procfs_target::pass_signals): Adjust.
15013 * record-full.c (record_full_target::resume): Adjust.
15014 * remote.c (remote_target::pass_signals)
15015 (remote_target::program_signals): Adjust.
15016 * target-debug.h (target_debug_print_signals): Now takes a
15017 gdb::array_view as parameter. Adjust.
15018 * target.h (target_ops) <pass_signals, program_signals>: Replace
15019 pointer and length parameters with gdb::array_view.
15020 (target_pass_signals, target_program_signals): Likewise.
15021 * target-delegates.c: Regenerate.
15022
3046d67a
PA
150232019-01-24 Pedro Alves <palves@redhat.com>
15024
15025 * common/forward-scope-exit.h
15026 (forward_scope_exit::forward_scope_exit): Pass arguments to
15027 m_bind_function directly, instead of creating a std::bind and
15028 copying that.
15029
353229bf
AH
150302019-01-24 Alan Hayward <alan.hayward@arm.com>
15031
15032 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15033 for static members.
15034 (pass_in_v_vfp_candidate): Likewise.
15035
311dc83a
TT
150362019-01-23 Tom Tromey <tom@tromey.com>
15037 Pedro Alves <palves@redhat.com>
15038
15039 * regcache.c (class regcache_invalidator): Remove.
15040 (regcache::raw_write): Use make_scope_exit.
15041
296bd123
TT
150422019-01-23 Tom Tromey <tom@tromey.com>
15043
15044 * ui-out.h (class ui_out_emit_type): Update comment.
15045
979a0d13
TT
150462019-01-23 Tom Tromey <tom@tromey.com>
15047
15048 * infrun.c (fetch_inferior_event): Update comment.
15049
d238133d
TT
150502019-01-23 Tom Tromey <tom@tromey.com>
15051 Pedro Alves <palves@redhat.com>
15052
15053 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15054 parameter.
15055 (fetch_inferior_event): Use SCOPE_EXIT.
15056
15057
9885e6bb
TT
150582019-01-23 Tom Tromey <tom@tromey.com>
15059 Pedro Alves <palves@redhat.com>
15060
15061 * infrun.c (disable_thread_events): Delete.
15062 (stop_all_threads): Use SCOPE_EXIT.
15063
286526c1
TT
150642019-01-23 Tom Tromey <tom@tromey.com>
15065 Pedro Alves <palves@redhat.com>
15066
15067 * symfile.c: Include forward-scope-exit.h.
15068 (clear_symtab_users_cleanup): Replace forward declaration with
15069 a FORWARD_SCOPE_EXIT.
15070 (syms_from_objfile_1): Use the forward_scope_exit and
15071 gdb::optional instead of cleanup_function.
15072 (reread_symbols): Use the forward_scope_exit instead of
15073 cleanup_function.
15074 (clear_symtab_users_cleanup): Remove function.
15075
1db93f14
TT
150762019-01-23 Tom Tromey <tom@tromey.com>
15077 Pedro Alves <palves@redhat.com>
15078
15079 * linux-nat.c: Include scope-exit.h.
15080 (cleanup_target_stop): Remove.
15081 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15082 SCOPE_EXIT.
15083
2cc83d1e
TT
150842019-01-23 Tom Tromey <tom@tromey.com>
15085 Pedro Alves <palves@redhat.com>
15086
15087 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15088 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15089
694c6bf5
TT
150902019-01-23 Tom Tromey <tom@tromey.com>
15091 Andrew Burgess <andrew.burgess@embecosm.com>
15092 Pedro Alves <palves@redhat.com>
15093
15094 * infrun.c (fetch_inferior_event): Use scope_exit.
15095 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15096 * top.c (execute_command): Use scope_exit.
15097 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15098 * utils.c (do_bpstat_clear_actions_cleanup)
15099 (make_bpstat_clear_actions_cleanup): Remove.
15100
4c41382a
TT
151012019-01-23 Tom Tromey <tom@tromey.com>
15102 Pedro Alves <palves@redhat.com>
15103
15104 * infrun.c: Include "common/scope-exit.h"
15105 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15106 (wait_for_inferior): Use SCOPE_EXIT.
15107 (fetch_inferior_event): Use scope_exit.
15108
89f8fb50
TT
151092019-01-23 Tom Tromey <tom@tromey.com>
15110 Pedro Alves <palves@redhat.com>
15111
15112 * breakpoint.c (create_breakpoint): Remove cleanup.
15113
5419bdae
TT
151142019-01-23 Tom Tromey <tom@tromey.com>
15115 Andrew Burgess <andrew.burgess@embecosm.com>
15116 Pedro Alves <palves@redhat.com>
15117
e587ef42
PA
151182019-01-23 Pedro Alves <palves@redhat.com>
15119
15120 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15121
77f0e74c
PA
151222019-01-23 Pedro Alves <palves@redhat.com>
15123 Andrew Burgess <andrew.burgess@embecosm.com>
15124
15125 * gdbthread.h: Include "common/forward-scope-exit.h".
15126 (scoped_finish_thread_state): Redefine custom class in terms of
15127 forward_scope_exit.
15128
5b9b3e53
PA
151292019-01-23 Pedro Alves <palves@redhat.com>
15130 Andrew Burgess <andrew.burgess@embecosm.com>
15131
15132 * common/forward-scope-exit.h: New file.
15133
54b65c9b
PA
151342019-01-23 Pedro Alves <palves@redhat.com>
15135 Andrew Burgess <andrew.burgess@embecosm.com>
15136 Tom Tromey <tom@tromey.com>
15137
15138 * common/scope-exit.h: New file.
15139
cf08fb29
PA
151402019-01-23 Pedro Alves <palves@redhat.com>
15141
15142 * common/preprocessor.h (ESC): Rename to ...
15143 (ESC_PARENS): ... this.
15144 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15145 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15146
ae73e2e2
TT
151472019-01-23 Tom Tromey <tom@tromey.com>
15148
15149 * language.h (class scoped_switch_to_sym_language_if_auto):
15150 Initialize m_lang in both cases.
15151
6594e122
AH
151522019-01-23 Alan Hayward <alan.hayward@arm.com>
15153
15154 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15155 with XCNEW.
15156
a7c9855d
TT
151572019-01-22 Tom Tromey <tom@tromey.com>
15158
15159 * corelow.c: Do not include sys/file.h.
15160
93cc1d53
TT
151612019-01-22 Tom Tromey <tom@tromey.com>
15162
15163 * tui/tui-wingeneral.h: Include gdb_curses.h.
15164
38561778
TT
151652019-01-22 Tom Tromey <tom@tromey.com>
15166
15167 * source-cache.h (class source_cache) <get_source_lines,
15168 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15169
37b3ab5b
TT
151702019-01-22 Tom Tromey <tom@tromey.com>
15171
15172 * remote-fileio.h (struct remote_target): Declare.
15173
3fabc016
TT
151742019-01-22 Tom Tromey <tom@tromey.com>
15175
15176 * python/py-arch.c: Do not include py-ref.h.
15177 * python/py-bpevent.c: Do not include py-ref.h.
15178 * python/py-cmd.c: Do not include py-ref.h.
15179 * python/py-continueevent.c: Do not include py-ref.h.
15180 * python/py-event.h: Do not include py-ref.h.
15181 * python/py-evtregistry.c: Do not include py-ref.h.
15182 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15183 * python/py-frame.c: Do not include py-ref.h.
15184 * python/py-framefilter.c: Do not include py-ref.h.
15185 * python/py-function.c: Do not include py-ref.h.
15186 * python/py-infevents.c: Do not include py-ref.h.
15187 * python/py-linetable.c: Do not include py-ref.h.
15188 * python/py-objfile.c: Do not include py-ref.h.
15189 * python/py-param.c: Do not include py-ref.h.
15190 * python/py-prettyprint.c: Do not include py-ref.h.
15191 * python/py-progspace.c: Do not include py-ref.h.
15192 * python/py-symbol.c: Do not include py-ref.h.
15193 * python/py-symtab.c: Do not include py-ref.h.
15194 * python/py-type.c: Do not include py-ref.h.
15195 * python/py-unwind.c: Do not include py-ref.h.
15196 * python/py-utils.c: Do not include py-ref.h.
15197 * python/py-value.c: Do not include py-ref.h.
15198 * python/py-varobj.c: Do not include py-ref.h.
15199 * python/py-xmethods.c: Do not include py-ref.h.
15200 * python/python.c: Do not include py-ref.h.
15201 * varobj.c: Do not include py-ref.h.
15202
6b4d7774
TT
152032019-01-22 Tom Tromey <tom@tromey.com>
15204
15205 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15206 keyword for bcache.
15207
7af7e9b5
TT
152082019-01-22 Tom Tromey <tom@tromey.com>
15209
15210 * compile/compile-cplus-types.c: Remove a comment by #include.
15211
951d1049
TT
152122019-01-22 Tom Tromey <tom@tromey.com>
15213
15214 * compile/gcc-c-plugin.h: Include compile-internal.h.
15215
d65d5705
TT
152162019-01-22 Tom Tromey <tom@tromey.com>
15217
15218 * stabsread.c (EXTERN): Do not define.
15219 (symnum, next_symbol_text_func, processing_gcc_compilation)
15220 (within_function, global_sym_chain, global_stabs)
15221 (previous_stab_code, this_object_header_files)
15222 (n_this_object_header_files)
15223 (n_allocated_this_object_header_files): Define.
15224 * stabsread.h (EXTERN): Never define. Use "extern".
15225
b6fb1ee5
PW
152262019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15227
15228 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15229 history_value.
15230
be6d4f74
TT
152312019-01-21 Tom Tromey <tom@tromey.com>
15232
15233 * ui-out.c: Fix includes.
15234 * tui/tui-source.c: Fix includes.
15235 * target.c: Fix includes.
15236 * remote.c: Fix includes.
15237 * regcache.c: Fix includes.
15238 * python/py-block.c: Fix includes.
15239 * printcmd.c: Fix includes.
15240 * or1k-tdep.c: Fix includes.
15241 * mi/mi-main.c: Fix includes.
15242 * m32r-tdep.c: Fix includes.
15243 * csky-tdep.c: Fix includes.
15244 * compile/compile-cplus-types.c: Fix includes.
15245 * cli/cli-interp.c: Fix includes.
15246
73021deb
AH
152472019-01-21 Alan Hayward <alan.hayward@arm.com>
15248
15249 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15250 for padding.
15251
7932255d
TT
152522019-01-16 Tom Tromey <tom@tromey.com>
15253
15254 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15255 earlier.
15256 (struct objfile) <msymbols_range>: Move from top level.
15257 <msymbols>: New method.
15258 (class objfile_msymbols): Remove.
15259 * symtab.c (default_collect_symbol_completion_matches_break_on):
15260 Update.
15261 * symmisc.c (dump_msymbols): Update.
15262 * stabsread.c (scan_file_globals): Update.
15263 * objc-lang.c (info_selectors_command, info_classes_command)
15264 (find_methods): Update.
15265 * minsyms.c (find_solib_trampoline_target): Update.
15266 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15267 * coffread.c (coff_symfile_read): Update.
15268 * ada-lang.c (ada_lookup_simple_minsym)
15269 (ada_collect_symbol_completion_matches): Update.
15270
604b1bfb
TT
152712019-01-16 Tom Tromey <tom@tromey.com>
15272
15273 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15274 type. Remove no-argument constructor.
15275 <iterator::operator++>: Simplify.
15276 <begin>: Update.
15277 <end>: Use minimal_symbol_count.
15278
f252c6d5
TT
152792019-01-16 Tom Tromey <tom@tromey.com>
15280
15281 * objfiles.h (struct objfile) <psymtabs>: New method.
15282 (class objfile_psymtabs): Remove.
15283 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15284 typedef.
15285 <range>: New method.
15286 (require_partial_symbols): Change return type.
15287 * psymtab.c (require_partial_symbols)
15288 (psym_expand_symtabs_matching): Update.
15289 * mdebugread.c (parse_partial_symbols): Update.
15290 * dbxread.c (dbx_end_psymtab): Update.
15291
b669c953
TT
152922019-01-15 Tom Tromey <tom@tromey.com>
15293
15294 * symtab.c (lookup_objfile_from_block)
15295 (lookup_symbol_in_objfile_symtabs)
15296 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15297 (find_line_symtab, info_sources_command)
15298 (default_collect_symbol_completion_matches_break_on)
15299 (make_source_files_completion_list): Update.
15300 * symmisc.c (print_objfile_statistics, dump_objfile)
15301 (maintenance_print_symbols, maintenance_info_symtabs)
15302 (maintenance_check_symtabs, maintenance_info_line_tables):
15303 Update.
15304 * source.c (select_source_symtab)
15305 (forget_cached_source_info_for_objfile): Update.
15306 * objfiles.h (class objfile_compunits): Remove.
15307 (struct objfile) <compunits_range>: New typedef.
15308 (compunits): New method.
15309 * objfiles.c (objfile_relocate1): Update.
15310 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15311 * maint.c (count_symtabs_and_blocks): Update.
15312 * linespec.c (iterate_over_all_matching_symtabs): Update.
15313 * cp-support.c (add_symbol_overload_list_qualified): Update.
15314 * coffread.c (coff_symtab_read): Update.
15315 * ada-lang.c (add_nonlocal_symbols)
15316 (ada_collect_symbol_completion_matches)
15317 (ada_add_global_exceptions): Update.
15318
7e955d83
TT
153192019-01-15 Tom Tromey <tom@tromey.com>
15320
15321 * progspace.h (program_space) <objfiles_safe_range>: New
15322 typedef.
15323 <objfiles_safe>: New method.
15324 * objfiles.h (class all_objfiles_safe): Remove.
15325 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15326 * jit.c (jit_inferior_exit_hook): Update.
15327
2030c079
TT
153282019-01-17 Tom Tromey <tom@tromey.com>
15329
15330 * progspace.h (program_space) <objfiles_range>: New typedef.
15331 <objfiles>: New method.
15332 <objfiles_head>: Rename from objfiles.
15333 (object_files): Update.
15334 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15335 * guile/scm-pretty-print.c
15336 (ppscm_find_pretty_printer_from_objfiles): Update.
15337 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15338 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15339 Update.
15340 * python/py-progspace.c (pspy_get_objfiles): Update.
15341 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15342 Update.
15343 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15344 (objfpy_lookup_objfile_by_build_id): Update.
15345 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15346 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15347 Update.
15348 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15349 (expand_symtab_containing_pc, lookup_objfile_from_block)
15350 (lookup_static_symbol, basic_lookup_transparent_type)
15351 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15352 (find_line_symtab, info_sources_command)
15353 (default_collect_symbol_completion_matches_break_on)
15354 (make_source_files_completion_list, find_main_name): Update.
15355 * symmisc.c (print_symbol_bcache_statistics)
15356 (print_objfile_statistics, maintenance_print_symbols)
15357 (maintenance_print_msymbols, maintenance_print_objfiles)
15358 (maintenance_info_symtabs, maintenance_check_symtabs)
15359 (maintenance_expand_symtabs, maintenance_info_line_tables):
15360 Update.
15361 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15362 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15363 (map_overlay_command, unmap_overlay_command)
15364 (simple_overlay_update, expand_symtabs_matching)
15365 (map_symbol_filenames): Update.
15366 * symfile-debug.c (set_debug_symfile): Update.
15367 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15368 Update.
15369 * source.c (select_source_symtab, forget_cached_source_info):
15370 Update.
15371 * solib.c (solib_read_symbols): Update.
15372 * solib-spu.c (append_ocl_sos): Update.
15373 * psymtab.c (maintenance_print_psymbols)
15374 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15375 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15376 * printcmd.c (info_symbol_command): Update.
15377 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15378 Update.
15379 * objfiles.h (class all_objfiles): Remove.
15380 * objfiles.c (have_partial_symbols, have_full_symbols)
15381 (have_minimal_symbols, qsort_cmp, update_section_map)
15382 (shared_objfile_contains_address_p)
15383 (default_iterate_over_objfiles_in_search_order): Update.
15384 * objc-lang.c (info_selectors_command, info_classes_command)
15385 (find_methods): Update.
15386 * minsyms.c (find_solib_trampoline_target): Update.
15387 * maint.c (maintenance_info_sections)
15388 (maintenance_translate_address, count_symtabs_and_blocks):
15389 Update.
15390 * main.c (captured_main_1): Update.
15391 * linux-thread-db.c (try_thread_db_load_from_pdir)
15392 (has_libpthread): Update.
15393 * linespec.c (iterate_over_all_matching_symtabs)
15394 (search_minsyms_for_name): Update.
15395 * jit.c (jit_find_objf_with_entry_addr): Update.
15396 * hppa-tdep.c (find_unwind_entry)
15397 (hppa_lookup_stub_minimal_symbol): Update.
15398 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15399 Update.
15400 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15401 (elf_gnu_ifunc_resolve_by_got): Update.
15402 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15403 * dwarf-index-write.c (save_gdb_index_command): Update.
15404 * cp-support.c (add_symbol_overload_list_qualified): Update.
15405 * breakpoint.c (create_overlay_event_breakpoint)
15406 (create_longjmp_master_breakpoint)
15407 (create_std_terminate_master_breakpoint)
15408 (create_exception_master_breakpoint): Update.
15409 * blockframe.c (find_pc_partial_function): Update.
15410 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15411 (ada_collect_symbol_completion_matches)
15412 (ada_add_global_exceptions): Update.
15413
776489e0
TT
154142019-01-17 Tom Tromey <tom@tromey.com>
15415
15416 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15417 declare VEC.
15418 (solib_target_parse_libraries): Change return type.
15419 (library_list_start_segment, library_list_start_section)
15420 (library_list_end_library, library_list_start_library); Update.
15421 (solib_target_free_library_list): Remove.
15422 (solib_target_parse_libraries): Remove cleanup. Change return
15423 type.
15424 (solib_target_current_sos): Update.
15425
6471e7d2
TT
154262019-01-17 Tom Tromey <tromey@bapiya>
15427
15428 * valprint.c: Replace "the the" with "the".
15429 * symtab.c: Replace "the the" with "the".
15430 * solib.c: Replace "the the" with "the".
15431 * solib-dsbt.c: Replace "the the" with "the".
15432 * linespec.c: Replace "the the" with "the".
15433 * dwarf2loc.h: Replace "the the" with "the".
15434 * amd64-windows-tdep.c: Replace "the the" with "the".
15435 * aarch64-tdep.c: Replace "the the" with "the".
15436
c24bdb02
KS
154372019-01-16 Keith Seitz <keiths@redhat.com>
15438
15439 PR gdb/23773
15440 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15441 <builder>: Rename to ..
15442 <m_builder>: ... this and make private.
15443 (dwarf2_cu::get_builder): New method. Change all users of
15444 `builder' to use this method.
15445 (dwarf2_start_symtab): Move to ...
15446 (dwarf2_cu::start_symtab): ... here. Update all callers
15447 (setup_type_unit_groups): Move to ...
15448 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15449 callers.
15450 (dwarf2_cu::reset_builder): New method.
15451 (process_full_compunit, process_full_type_unit): Use
15452 dwarf2_cu::reset_builder.
15453 (follow_die_offset): Record the ancestor CU if it is different
15454 from the followed DIE's CU.
15455 (follow_die_sig_1): Likewise.
15456
8d64371b
TT
154572019-01-15 Tom Tromey <tom@tromey.com>
15458
15459 * remote.c (class remote_state) <buf>: Now a char_vector.
15460 <buf_size>: Remove.
15461 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15462 parameter.
15463 (remote_target::getpkt_or_notif_sane_1)
15464 (remote_target::getpkt_sane)
15465 (remote_target::getpkt_or_notif_sane): Likewise.
15466 (class remote_target) <putpkt>: New overload.
15467 (remote_target::read_frame): Change type of "buf_p". Remove
15468 sizeof_p parameter.
15469 (packet_ok): New overload.
15470 (packet_check_result): New overload.
15471 Update all uses.
15472
bb277751
TT
154732019-01-14 Tom Tromey <tom@tromey.com>
15474
15475 * remote-notif.c (handle_notification, remote_notif_ack)
15476 (remote_notif_parse): Make "buf" const.
15477 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15478 const.
15479 (remote_notif_parse, remote_notif_ack, handle_notification):
15480 Likewise.
15481 * remote.c (remote_notif_stop_parse): Make "buf" const.
15482 (remote_target::remote_parse_stop_reply): Make "buf" const.
15483 (remote_notif_stop_ack): Make "buf" const.
15484
05be00a8
TT
154852019-01-14 Tom Tromey <tom@tromey.com>
15486
15487 * remote.c (remote_console_output): Make parameter const.
15488
491adeca
TT
154892019-01-14 Tom Tromey <tom@tromey.com>
15490
15491 * target-debug.h (target_debug_print_signals): Constify.
15492 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15493 * procfs.c (procfs_target::pass_signals): Update.
15494 * linux-nat.c (linux_nat_target::pass_signals): Update.
15495 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15496 * target-delegates.c: Rebuild.
15497 * remote.c (remote_target::program_signals): Update.
15498 (remote_target::pass_signals): Update.
15499 * target.c (target_pass_signals): Constify argument.
15500 (target_program_signals): Likewise.
15501 * target.h (struct target_ops) <pass_signals, program_signals>:
15502 Constify argument.
15503 (target_pass_signals, target_program_signals): Constify argument.
15504
bbd94648
TT
155052019-01-14 Tom Tromey <tom@tromey.com>
15506
15507 PR tui/28819:
15508 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15509
6f072a10
PFC
155102019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15511
15512 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15513 field.
15514 * rs6000-tdep.c: Include reggroups.h.
15515 (IS_V_ALIAS_PSEUDOREG): Define.
15516 (rs6000_register_name): Return names for the "vX" aliases.
15517 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15518 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15519 aliases. Call default_register_reggroup_p for all other
15520 pseudo-registers.
15521 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15522 New functions.
15523 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15524 Handle "vX" aliases.
15525 (v_alias_pseudo_register_collect): New function.
15526 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15527 (rs6000_gdbarch_init): Initialize "vX" aliases as
15528 pseudo-registers. Restore registration of
15529 rs6000_pseudo_register_reggroup_p with
15530 set_tdesc_pseudo_register_reggroup_p.
15531
1a782351
MF
155322019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15533
15534 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15535 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15536 set_gdbarch_num_pseudo_regs.
15537
d73cff18
PW
155382019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15539
15540 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15541 Remove arg prefixname, add do_set and do_show.
15542 Add member functions set_list and show_list.
15543 * cli/cli-style.c (class cli_style_option): Update accordingly.
15544 (style_set_list): Move to file scope.
15545 (style_show_list): Likewise.
15546 (set_style): Call help_list.
15547 (show_style): Call cmd_show_list.
15548 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15549 Update to use the new macro.
15550
60a90376
JB
155512019-10-12 Joel Brobecker <brobecker@adacore.com>
15552
15553 * ada-lang.c (_initialize_ada_language): Expand the help text
15554 for the "catch exception" command.
15555
9d7c67bf
PW
155562019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15557
15558 * symtab.c (matching_obj_sections): Initialize obj,
15559 declare it closer to its usage.
15560
7cf47dc4
TT
155612019-01-10 Tom Tromey <tom@tromey.com>
15562
15563 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15564 (basic_inf_threads_range): Remove.
15565 (inf_threads_range, inf_non_exited_threads_range)
15566 (safe_inf_threads_range): Use next_adapter.
15567
d3cb6808
KS
155682019-01-10 Keith Seitz <keiths@redhat.com>
15569
15570 PR gdb/23712
15571 PR symtab/23010
15572 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15573 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15574
63a20375
KS
155752019-01-10 Keith Seitz <keiths@redhat.com>
15576
15577 PR gdb/23712
15578 PR symtab/23010
15579 * dictionary.c (pending_to_vector): Remove.
15580 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15581 Remove _1 suffix, replacing functions of the same name. Update
15582 all callers.
15583 (dict_create_hashed, dict_create_hashed_expandable)
15584 (dict_create_linear, dict_create_linear_expandable, dict_free)
15585 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15586 Make functions static.
15587
b026f593
KS
155882019-01-10 Keith Seitz <keiths@redhat.com>
15589
15590 PR gdb/23712
15591 PR symtab/23010
15592 * dictionary.h (struct dictionary): Replace declaration with
15593 multidictionary.
15594 (dict_create_hashed, dict_create_hashed_expandable)
15595 (dict_create_linear, dict_create_linear_expandable)
15596 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15597 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15598 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15599 taking multidictionary argument.
15600 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15601 * block.h (struct block) <dict>: Change to multidictionary
15602 and rename `multidict'.
15603 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15604 symmisc.c: Update all dictionary references to multidictionary.
15605
c7748ee9
KS
156062019-01-10 Keith Seitz <keiths@redhat.com>
15607
15608 PR gdb/23712
15609 PR symtab/23010
15610 * dictionary.c: Include unordered_map.
15611 (pending_to_vector): New function.
15612 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15613 Rewrite the non-"_1" functions to take vector instead
15614 of linked list.
15615 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15616 "new" _1 versions of the same name.
15617 (multidictionary): Define.
15618 (std::hash<enum language): New definition.
15619 (collate_pending_symbols_by_language, mdict_create_hashed)
15620 (mdict_create_hashed_expandable, mdict_create_linear)
15621 (mdict_create_linear_expandable, mdict_free)
15622 (find_language_dictionary, create_new_language_dictionary)
15623 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15624 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15625 (mdict_size, mdict_empty): New functions.
15626 * dictionary.h (mdict_iterator): Define.
15627
67aa1f3c
PA
156282019-01-10 Pedro Alves <palves@redhat.com>
15629
15630 * breakpoint.c (read_uploaded_action)
15631 (create_tracepoint_from_upload): Adjust to use
15632 gdb::unique_xmalloc_ptr.
15633 * ctf.c (ctf_write_uploaded_tp):
15634 (SET_ARRAY_FIELD): Use emplace_back.
15635 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15636 * tracefile-tfile.c (tfile_write_uploaded_tp):
15637 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15638 gdb::unique_xmalloc_ptr.
15639 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15640 at_string, cond_string, cmd_strings>: Replace char pointers
15641 with gdb::unique_xmalloc_ptr.
15642
2f667667
PA
156432019-01-10 Pedro Alves <palves@redhat.com>
15644
15645 * solib-target.c (library_list_start_library): Don't xstrdup name.
15646
36cb7237
PA
156472019-01-10 Pedro Alves <palves@redhat.com>
15648
15649 * mdebugread.c (parse_partial_symbols): Use
15650 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15651
da584958
AB
156522019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15653
15654 * linux-fork.c (scoped_switch_fork_info)
15655 <~scoped_switch_fork_info>: Fix incorrect variable name.
15656
1ef8573c
AB
156572019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15658
15659 * linux-fork.c (scoped_switch_fork_info)
15660 <scoped_switch_fork_info>: Make explicit.
15661 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15662
8d7bcccb
TT
156632019-01-10 Tom Tromey <tom@tromey.com>
15664
15665 * objfiles.h (objfile::reset_psymtabs): Update.
15666 * objfiles.c (objfile::objfile): Update.
15667 * psymtab.h (psymtab_storage::obstack): Update.
15668 (psymtab_storage::m_obstack): Use gdb::optional.
15669 (class psymtab_storage): Update comment. Remove objfile
15670 parameter.
15671 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15672
b596a3c7
TT
156732019-01-10 Tom Tromey <tom@tromey.com>
15674
15675 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15676 <free_psymtabs>: Now private.
15677 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15678 (allocate_psymtab): Use new method.
15679
a9342b62
TT
156802019-01-10 Tom Tromey <tom@tromey.com>
15681
15682 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15683 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15684 * mdebugread.c (parse_partial_symbols): Use
15685 allocate_dependencies.
15686 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15687 allocate_dependencies.
15688 (process_psymtab_comp_unit_reader)
15689 (build_type_psymtab_dependencies): Likewise.
15690 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15691
5af70966
TT
156922019-01-10 Tom Tromey <tom@tromey.com>
15693
15694 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15695 PSYMBOL_SET_LANGUAGE.
15696 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15697
5923a04c
TT
156982019-01-10 Tom Tromey <tom@tromey.com>
15699
15700 * psymtab.h (psymtab_storage::obstack): New method.
15701 <m_obstack>: Rename from obstack; now private.
15702 * psymtab.c (psymtab_storage): Update.
15703 * dwarf2read.c (create_addrmap_from_index)
15704 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15705 Update.
15706
6d6a12bf
TT
157072019-01-10 Tom Tromey <tom@tromey.com>
15708
15709 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15710 * objfiles.h (objfile::reset_psymtabs): New method.
15711
d320c2b5
TT
157122019-01-10 Tom Tromey <tom@tromey.com>
15713
15714 * symmisc.c (print_symbol_bcache_statistics): Update.
15715 (print_objfile_statistics): Update.
15716 * symfile.c (reread_symbols): Update.
15717 * psymtab.h (class psymtab_storage): New.
15718 * psymtab.c (psymtab_storage): New constructor.
15719 (~psymtab_storage): New destructor.
15720 (require_partial_symbols): Update.
15721 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15722 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15723 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15724 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15725 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15726 (start_psymtab_common, end_psymtab_common)
15727 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15728 (allocate_psymtab): Update.
15729 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15730 Update.
15731 (dump_psymtab_addrmap, maintenance_print_psymbols)
15732 (maintenance_check_psymtabs): Update.
15733 (class objfile_psymtabs): Move to objfiles.h.
15734 * psympriv.h (discard_psymtab): Now inline.
15735 (psymtab_discarder::psymtab_discarder): Update.
15736 (psymtab_discarder::~psymtab_discarder): Update.
15737 (ALL_OBJFILE_PSYMTABS): Rewrite.
15738 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15739 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15740 Remove fields.
15741 <partial_symtabs>: New field.
15742 (class objfile_psymtabs): Move from psymtab.h. Update.
15743 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15744 psymbol_cache.
15745 (objfile::~objfile): Don't destroy psymbol_cache.
15746 * mdebugread.c (parse_partial_symbols): Update.
15747 * dwarf2read.c (create_addrmap_from_index)
15748 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15749 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15750 (add_partial_subprogram, dwarf2_ranges_read): Update.
15751 * dwarf-index-write.c (write_address_map)
15752 (write_one_signatured_type, recursively_write_psymbols)
15753 (class debug_names, class debug_names, write_psymtabs_to_index):
15754 Update.
15755
1d94a5a3
TT
157562019-01-10 Tom Tromey <tom@tromey.com>
15757
15758 * symtab.h (SYMBOL_SET_NAMES): Update.
15759 (symbol_set_names): Update.
15760 (MSYMBOL_SET_NAMES): Update.
15761 * symtab.c (symbol_set_names): Change argument to be an
15762 objfile_per_bfd_storage.
15763 * psymtab.c (add_psymbol_to_bcache): Update.
15764 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15765
0f14768a
TT
157662019-01-10 Tom Tromey <tom@tromey.com>
15767
15768 * symtab.c (create_demangled_names_hash): Change argument to be an
15769 objfile_per_bfd_storage.
15770 (symbol_set_names): Update.
15771
6eee24ce
TT
157722019-01-10 Tom Tromey <tom@tromey.com>
15773
15774 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15775 init_psymbol_list.
15776 * psymtab.c (init_psymbol_list): Do nothing if already called.
15777 * psympriv.h (init_psymbol_list): Add comment.
15778 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15779 init_psymbol_list.
15780 * dbxread.c (dbx_symfile_read): Unconditionally call
15781 init_psymbol_list.
15782
75aedd27
TT
157832019-01-10 Tom Tromey <tom@tromey.com>
15784
15785 * xcoffread.c (scan_xcoff_symtab): Update.
15786 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15787 "where".
15788 * mdebugread.c (parse_partial_symbols)
15789 (handle_psymbol_enumerators): Update.
15790 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15791 * dbxread.c (read_dbx_symtab): Update.
15792 * psympriv.h (psymbol_placement): New enum.
15793 (add_psymbol_to_list): Update.
15794
939652a5
TT
157952019-01-10 Tom Tromey <tom@tromey.com>
15796
15797 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15798 static_psymbols parameters.
15799 (scan_xcoff_symtab): Update.
15800 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15801 static_psymbols parameters.
15802 * psympriv.h (start_psymtab_common): Update.
15803 * mdebugread.c (parse_partial_symbols): Update.
15804 * dwarf2read.c (create_partial_symtab): Update.
15805 * dbxread.c (read_dbx_symtab): Update.
15806 (start_psymtab): Remove global_psymbols and static_psymbols
15807 parameters.
15808
baa62830
TT
158092019-01-10 Tom Tromey <tom@tromey.com>
15810
15811 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15812 * psymtab.c (allocate_psymtab): Add comment.
15813 * psympriv.h (allocate_psymtab): Add comment.
15814 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15815 initializations.
15816 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15817
0e8f53ba
TT
158182019-01-10 Tom Tromey <tom@tromey.com>
15819
15820 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15821 Don't declare.
15822 * mipsread.c: Include mdebugread.h.
15823 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15824 Declare.
15825 * elfread.c: Include mdebugread.h.
15826
b22a7c6a
TT
158272019-01-09 Tom Tromey <tom@tromey.com>
15828
15829 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15830 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15831 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15832 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15833 (psym_lookup_symbol, psym_find_last_source_symtab)
15834 (psym_forget_cached_source_info, psym_print_stats)
15835 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15836 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15837 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15838 (psym_find_compunit_symtab_by_address)
15839 (maintenance_print_psymbols, maintenance_info_psymtabs)
15840 (maintenance_check_psymtabs): Use ranged for.
15841 * psymtab.h (class objfile_psymtabs): New.
15842 (require_partial_symbols): Return objfile_psymtabs.
15843 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15844
3b9d3ac2
TT
158452019-01-09 Tom Tromey <tom@tromey.com>
15846
15847 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15848 (find_pc_mapped_section, list_overlays_command)
15849 (map_overlay_command, unmap_overlay_command)
15850 (simple_overlay_update): Use all_objfiles.
15851 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15852 * printcmd.c (info_symbol_command): Use all_objfiles.
15853 * objfiles.h (ALL_OBJSECTIONS): Remove.
15854 * maint.c (maintenance_translate_address): Use all_objfiles.
15855 * gcore.c (gcore_create_callback): Use all_objfiles.
15856 (objfile_find_memory_regions): Likewise.
15857
8b31193a
TT
158582019-01-09 Tom Tromey <tom@tromey.com>
15859
15860 * symtab.c (find_line_symtab, info_sources_command)
15861 (make_source_files_completion_list): Use objfile_compunits.
15862 * source.c (select_source_symtab): Use objfile_compunits.
15863 * objfiles.h (struct objfile): Update comment.
15864 (ALL_OBJFILES): Remove.
15865 (ALL_FILETABS): Remove.
15866 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15867 objfile_compunits.
15868
d5da8b3c
TT
158692019-01-09 Tom Tromey <tom@tromey.com>
15870
15871 * symmisc.c (print_objfile_statistics, dump_objfile)
15872 (maintenance_print_symbols): Use compunit_filetabs.
15873 * source.c (forget_cached_source_info_for_objfile): Use
15874 compunit_filetabs.
15875 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15876 (ALL_FILETABS): Use compunit_filetabs.
15877 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15878 * coffread.c (coff_symtab_read): Use compunit_filetabs.
15879
5accd1a0
TT
158802019-01-09 Tom Tromey <tom@tromey.com>
15881
15882 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15883 (compunit_filetabs): New.
15884 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15885 compunit_filetabs.
15886 (info_sources_command, make_source_files_completion_list): Remove
15887 declaration.
15888 * symmisc.c (print_objfile_statistics, dump_objfile)
15889 (maintenance_print_symbols): Remove declaration.
15890 (maintenance_info_symtabs): Use compunit_filetabs.
15891 (maintenance_info_line_tables): Likewise.
15892 * source.c (select_source_symtab): Change local variable name.
15893 (forget_cached_source_info_for_objfile): Remove declaration.
15894 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15895 * objfiles.c (objfile_relocate1): Remove declaration.
15896 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15897 declaration.
15898 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15899 * coffread.c (coff_symtab_read): Remove declaration.
15900 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15901 compunit_filetabs.
15902
d8aeb77f
TT
159032019-01-09 Tom Tromey <tom@tromey.com>
15904
15905 * symtab.c (lookup_objfile_from_block)
15906 (find_pc_sect_compunit_symtab, search_symbols)
15907 (default_collect_symbol_completion_matches_break_on): Use
15908 objfile_compunits.
15909 * objfiles.h (ALL_COMPUNITS): Remove.
15910 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15911 * cp-support.c (add_symbol_overload_list_qualified): Use
15912 objfile_compunits.
15913 * ada-lang.c (ada_collect_symbol_completion_matches)
15914 (ada_add_global_exceptions): Use objfile_compunits.
15915
592553c4
TT
159162019-01-09 Tom Tromey <tom@tromey.com>
15917
15918 * source.c (select_source_symtab)
15919 (forget_cached_source_info_for_objfile): Remove declaration.
15920 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15921 declaration.
15922 * maint.c (count_symtabs_and_blocks): Remove declaration.
15923 * cp-support.c (add_symbol_overload_list_qualified): Remove
15924 declaration.
15925 * coffread.c (coff_symtab_read): Remove declaration.
15926 * symtab.c (lookup_symbol_in_objfile_symtabs)
15927 (basic_lookup_transparent_type_1): Use objfile_compunits.
15928 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15929 (info_sources_command, search_symbols)
15930 (default_collect_symbol_completion_matches_break_on)
15931 (make_source_files_completion_list): Remove declaration.
15932 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15933 (ada_collect_symbol_completion_matches)
15934 (ada_add_global_exceptions): Remove declaration.
15935 * linespec.c (iterate_over_all_matching_symtabs): Use
15936 objfile_compunits.
15937 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15938 (class objfile_compunits): New.
15939 (ALL_COMPUNITS): Use objfile_compunits.
15940 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15941 (maintenance_check_symtabs, maintenance_info_line_tables): Use
15942 objfile_compunits.
15943 * objfiles.c (objfile_relocate1): Use objfile_compunits.
15944
5325b9bf
TT
159452019-01-09 Tom Tromey <tom@tromey.com>
15946
15947 * symtab.c (search_symbols)
15948 (default_collect_symbol_completion_matches_break_on): Use
15949 objfile_msymbols.
15950 * ada-lang.c (ada_lookup_simple_minsym)
15951 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15952 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15953 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15954 objfile_msymbols.
15955 * coffread.c (coff_symfile_read): Use objfile_msymbols.
15956 * symmisc.c (dump_msymbols): Use objfile_msymbols.
15957 * objc-lang.c (find_methods): Use objfile_msymbols.
15958 (info_selectors_command, info_classes_command): Likewise.
15959 * stabsread.c (scan_file_globals): Use objfile_msymbols.
15960 * objfiles.h (class objfile_msymbols): New.
15961 (ALL_OBJFILE_MSYMBOLS): Remove.
15962 (ALL_MSYMBOLS): Remove.
15963
cac85af2
TT
159642019-01-09 Tom Tromey <tom@tromey.com>
15965
15966 * common/next-iterator.h (next_adapter): Add Iterator template
15967 parameter.
15968 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15969 (class all_objfiles_safe): New.
15970 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15971 * objfiles.c (put_objfile_before): Update comment.
15972 (add_separate_debug_objfile): Likewise.
15973 (free_all_objfiles): Use all_objfiles_safe.
15974 (objfile_purge_solibs): Likewise.
15975
aed57c53
TT
159762019-01-09 Tom Tromey <tom@tromey.com>
15977
15978 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15979 (expand_symtab_containing_pc, lookup_static_symbol)
15980 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15981 (find_symbol_at_address, find_line_symtab, find_main_name): Use
15982 all_objfiles.
15983 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15984 * breakpoint.c (create_overlay_event_breakpoint)
15985 (create_longjmp_master_breakpoint)
15986 (create_std_terminate_master_breakpoint)
15987 (create_exception_master_breakpoint): Use all_objfiles.
15988 * linux-thread-db.c (try_thread_db_load_from_pdir)
15989 (has_libpthread): Use all_objfiles.
15990 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15991 * linespec.c (iterate_over_all_matching_symtabs)
15992 (search_minsyms_for_name): Use all_objfiles.
15993 * maint.c (maintenance_info_sections): Use all_objfiles.
15994 * main.c (captured_main_1): Use all_objfiles.
15995 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15996 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15997 * guile/scm-pretty-print.c
15998 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15999 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16000 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16001 (maintenance_print_msymbols): Use all_objfiles.
16002 * source.c (select_source_symtab): Use all_objfiles.
16003 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16004 * symfile.c (remove_symbol_file_command)
16005 (expand_symtabs_matching, map_symbol_filenames): Use
16006 all_objfiles.
16007 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16008 all_objfiles.
16009 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16010 * objc-lang.c (find_methods): Use all_objfiles.
16011 * objfiles.c (have_partial_symbols, have_full_symbols)
16012 (have_minimal_symbols, qsort_cmp)
16013 (default_iterate_over_objfiles_in_search_order): Use
16014 all_objfiles.
16015 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16016 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16017 (maintenance_check_psymtabs): Use all_objfiles.
16018 (ALL_PSYMTABS): Remove.
16019 * compile/compile-object-run.c (do_module_cleanup): Use
16020 all_objfiles.
16021 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16022 * cp-support.c (add_symbol_overload_list_qualified): Use
16023 all_objfiles.
16024 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16025 Use all_objfiles.
16026 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16027 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16028 all_objfiles.
16029 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16030 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16031 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16032 Uses all_objfiles.
16033 * solib.c (solib_read_symbols): Use all_objfiles
16034
99d89cde
TT
160352019-01-09 Tom Tromey <tom@tromey.com>
16036
16037 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16038 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16039 all_objfiles.
16040 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16041 * symmisc.c (print_symbol_bcache_statistics)
16042 (print_objfile_statistics, maintenance_print_objfiles)
16043 (maintenance_info_symtabs, maintenance_check_symtabs)
16044 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16045 all_objfiles.
16046 * source.c (forget_cached_source_info): Use all_objfiles.
16047 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16048 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16049 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16050 * objfiles.c (update_section_map): Use all_objfiles.
16051 (shared_objfile_contains_address_p): Likewise.
16052 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16053 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16054
21708325
TT
160552019-01-09 Tom Tromey <tom@tromey.com>
16056
16057 * common/next-iterator.h: New file.
16058 * objfiles.h (class all_objfiles): New.
16059 (struct objfile_iterator): New.
16060
669e09f6
PW
160612019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16062
16063 * NEWS: Move the description of the changed "frame", "select-frame",
16064 and "info frame" commands to the Changed commands section.
16065
041be526
SM
160662019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16067
16068 * gdbtypes.c (check_stub_method_group): Remove handling of old
16069 mangling schemes.
16070 * linespec.c (find_methods): Likewise.
16071 * stabsread.c (read_member_functions): Likewise.
16072 * valops.c (search_struct_method): Likewise.
16073 (value_struct_elt_for_reference): Likewise.
16074 * NEWS: Mention this change.
16075
0e2a2133
AB
160762019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16077
16078 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16079 print_source_lines.
16080 * source.c (print_source_lines_base): Update line number check.
16081 (print_source_lines): New function.
16082 (source_lines_range::source_lines_range): New function.
16083 * source.h (class source_lines_range): New class.
16084 (print_source_lines): New declaration.
16085
1055a3b4
PW
160862019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16087
16088 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16089
cfeadda5
TT
160902019-01-08 Tom Tromey <tom@tromey.com>
16091 Simon Marchi <simon.marchi@ericsson.com>
16092
16093 PR gdb/24060
16094 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16095 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16096 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16097 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16098 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16099 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16100
583068ca
AB
161012019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16102
16103 * source.c (select_source_symtab): Move header comment to
16104 declaration in source.h.
16105 (forget_cached_source_info_for_objfile): Likewise.
16106 (forget_cached_source_info): Likewise.
16107 (identify_source_line): Likewise.
16108 * source.h (identify_source_line): Move declaration from symtab.h
16109 and add comment from source.c
16110 (print_source_lines): Likewise.
16111 (forget_cached_source_info_for_objfile): Likewise.
16112 (forget_cached_source_info): Likewise.
16113 (select_source_symtab): Likewise.
16114 (enum print_source_lines_flag): Move definition from symtab.h.
16115 * symtab.h (identify_source_line): Move declaration to source.h.
16116 (print_source_lines): Likewise.
16117 (forget_cached_source_info_for_objfile): Likewise.
16118 (forget_cached_source_info): Likewise.
16119 (select_source_symtab): Likewise.
16120 (enum print_source_lines_flag): Move definition to source.h.
16121 * tui/tui-hooks.c: Add 'source.h' include.
16122
ec98a4ad
AB
161232019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16124
16125 * source.c (print_source_lines_base): Handle requests to print
16126 reverse line number sequences, and guard against empty lines
16127 string.
16128
62ea19c1
AB
161292019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16130
16131 * source.c (print_source_lines_base): Fix skip of '\r' if next
16132 character is '\n'.
16133
9d30e1fd
TT
161342019-01-06 Tom Tromey <tom@tromey.com>
16135
16136 * c-exp.y (struct c_parse_state) <macro_original_text,
16137 expansion_obstack>: New member.
16138 (macro_original_text, expansion_obstack): Remove globals.
16139 (scan_macro_expansion, scanning_macro_expansion)
16140 (finished_macro_expansion): Update.
16141 (scan_macro_cleanup): Remove.
16142 (yylex, c_parse): Update.
16143
c65bac38
TT
161442019-01-06 Tom Tromey <tom@tromey.com>
16145
16146 * c-exp.y (struct c_parse_state) <strings>: New member.
16147 (operator_stoken): Update.
16148
02e12e38
TT
161492019-01-06 Tom Tromey <tom@tromey.com>
16150
16151 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16152 (union type_stack_elt) <typelist_val>: Now a pointer to
16153 std::vector.
16154 (type_stack_cleanup): Don't declare.
16155 (push_typelist): Update.
16156 * parse.c (pop_typelist): Return a std::vector.
16157 (push_typelist): Take a std::vector.
16158 (follow_types): Update. Do not free args.
16159 (type_stack_cleanup): Remove.
16160 * c-exp.y (struct c_parse_state): New.
16161 (cpstate): New global.
16162 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16163 (nonempty_typelist): Update.
16164 (func_mod): Create a new vector.
16165 (c_parse): Create a c_parse_state.
16166 (check_parameter_typelist): Do not delete params.
16167 (function_method): Update. Do not delete type_list.
16168
f097f5ad
TT
161692019-01-06 Tom Tromey <tom@tromey.com>
16170
16171 PR gdb/28155:
16172 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16173 check_typedef.
16174 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16175 (print_return_value): Likewise.
16176
d2adf9f1
TT
161772019-01-05 Tom Tromey <tom@tromey.com>
16178
16179 * contrib/cleanup_check.py: Remove.
16180 * contrib/gcc-with-excheck: Remove.
16181 * contrib/exsummary.py: Remove.
16182 * contrib/excheck.py: Remove.
16183
2eab46b1
JB
161842019-01-05 Joel Brobecker <brobecker@adacore.com>
16185
16186 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16187 NULL. Initialize tpprev to NULL instead of assigning it
16188 to NULL on the next statement.
16189 * windows-nat.c (windows_delete_thread): Remove check for
16190 main_thread_id before printing thread exit notifications.
16191 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16192 Remove thread ID check against main_thread_id.
16193 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16194 windows_delete_thread.
16195 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16196
48c5e7e2
TT
161972019-01-04 Tom Tromey <tom@tromey.com>
16198
16199 * compile/compile.c (_initialize_compile): Use upper case for
16200 metasyntactic variables.
16201 * symmisc.c (_initialize_symmisc): Use upper case for
16202 metasyntactic variables.
16203 * psymtab.c (_initialize_psymtab): Use upper case for
16204 metasyntactic variables.
16205 * demangle.c (demangle_command): Use upper case for metasyntactic
16206 variables.
16207 (_initialize_demangler): Likewise.
16208 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16209 variables.
16210
986041cd
TT
162112019-01-03 Tom Tromey <tom@tromey.com>
16212
16213 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16214
7c711119
TT
162152019-01-03 Tom Tromey <tom@tromey.com>
16216
16217 * python/py-symtab.c (salpy_str): Update.
16218 (struct salpy_sal_object) <symtab>: Now a PyObject.
16219 (salpy_dealloc): Update.
16220 (del_objfile_sal): Use gdbpy_ref.
16221
1b20edf0
TT
162222019-01-03 Tom Tromey <tom@tromey.com>
16223
16224 * python/py-type.c (convert_field): Use new_reference. Return
16225 gdbpy_ref.
16226 (make_fielditem): Return gdbpy_ref.
16227 (typy_fields): Update.
16228 (typy_getitem): Update.
16229 (field_name): Return gdbpy_ref. Use new_reference.
16230 (typy_iterator_iternext): Update.
16231
ea41325b
TT
162322019-01-03 Tom Tromey <tom@tromey.com>
16233
16234 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16235
2a3c71d6
TT
162362019-01-03 Tom Tromey <tom@tromey.com>
16237
16238 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16239 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16240 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16241 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16242 (pspy_set_type_printers): Likewise.
16243 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16244 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16245 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16246 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16247 (objfpy_set_type_printers): Likewise.
16248
5c329e6a
TT
162492019-01-03 Tom Tromey <tom@tromey.com>
16250
16251 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16252 (gdbpy_print_stack): Use gdbpy_err_fetch.
16253 * python/python-internal.h (class gdbpy_err_fetch): New class.
16254 (class gdbpy_enter) <m_error_type, m_error_value,
16255 m_error_traceback>: Remove.
16256 <m_error>: New member.
16257 (gdbpy_exception_to_string): Don't declare.
16258 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16259 * python/py-value.c (convert_value_from_python): Use
16260 gdbpy_err_fetch.
16261 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16262 gdbpy_exception_to_string.
16263 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16264 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16265 gdbpy_err_fetch.
16266
169bb27b
AB
162672019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16268
16269 * linux-nat.c (delete_lwp_cleanup): Delete.
16270 (struct lwp_deleter): New struct.
16271 (lwp_info_up): New typedef.
16272 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16273 lwp_info_up.
16274
a07c8880
AB
162752019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16276
16277 * linux-fork.c (class scoped_switch_fork_info): New class.
16278 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16279
26089c49
AB
162802019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16281
16282 * valops.c (find_overload_match): Remove use of null_cleanup, and
16283 calls to do_cleanups.
16284
06d3e5b0
AB
162852019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16286
16287 * compile/compile-cplus-types.c
16288 (compile_cplus_instance::decl_name): Handle changes to
16289 cp_func_name.
16290 * cp-support.c (cp_func_name): Update header comment, update
16291 return type.
16292 * cp-support.h (cp_func_name): Update return type in declaration.
16293 * valops.c (find_overload_match): Move temp_func local to top
16294 level of function and change its type. Use temp_func to hold and
16295 delete temporary string obtained from cp_func_name.
16296
66644cd3
AB
162972019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16298
16299 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16300 gdb::char_vector, remove cleanup, and update uses of `msg`.
16301
592d8c0a
JW
163022019-01-03 Jim Wilson <jimw@sifive.com>
16303
16304 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16305
c55d06ec
TT
163062019-01-02 Tom Tromey <tom@tromey.com>
16307
16308 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16309 (tdesc_parse_xml): Remove cleanups.
16310 * target-descriptions.h (make_cleanup_free_target_description):
16311 Don't declare.
16312 (target_desc_deleter): New struct.
16313 (target_desc_up): New typedef.
16314 * target-descriptions.c (target_desc_deleter::operator()): Rename
16315 from free_target_description.
16316 (make_cleanup_free_target_description): Remove.
16317
3a6ae42d
TT
163182019-01-02 Tom Tromey <tom@tromey.com>
16319
16320 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16321 constructor, destructor.
16322 (linespec_parser): Remove typedef.
16323 (~linespec_parser): Rename from linespec_parser_delete.
16324 (linespec_lex_to_end, linespec_complete_label)
16325 (linespec_complete): Update.
16326 (decode_line_full): Remove cleanups.
16327 (decode_line_1): Update.
16328
61fd3e73
TT
163292019-01-02 Tom Tromey <tom@tromey.com>
16330
16331 * python/python-internal.h (inferior_to_inferior_object): Change
16332 return type.
16333 * python/py-exitedevent.c (create_exited_event_object): Update.
16334 * python/py-inferior.c (inferior_to_inferior_object): Return
16335 gdbpy_ref.
16336 (python_new_inferior, python_inferior_deleted)
16337 (thread_to_thread_object, delete_thread_object)
16338 (build_inferior_list, gdbpy_selected_inferior): Update.
16339 * python/py-infthread.c (create_thread_object): Update. Also fail
16340 if inferior_to_inferior_object fails.
16341
d20172fc
SM
163422019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16343
16344 * inferior.h (class inferior) <displaced_step_state>: New field.
16345 * infrun.h (struct displaced_step_state): Move here from
16346 infrun.c. Initialize fields, add constructor.
16347 <inf>: Remove field.
16348 <reset>: New method.
16349 * infrun.c (struct displaced_step_inferior_state): Move to
16350 infrun.h.
16351 (displaced_step_inferior_states): Remove.
16352 (get_displaced_stepping_state): Adust.
16353 (displaced_step_in_progress_any_inferior): Adjust.
16354 (displaced_step_in_progress_thread): Adjust.
16355 (displaced_step_in_progress): Adjust.
16356 (add_displaced_stepping_state): Remove.
16357 (get_displaced_step_closure_by_addr): Adjust.
16358 (remove_displaced_stepping_state): Remove.
16359 (infrun_inferior_exit): Call displaced_step_state.reset.
16360 (use_displaced_stepping): Don't check for NULL.
16361 (displaced_step_prepare_throw): Call
16362 get_displaced_stepping_state.
16363 (displaced_step_fixup): Don't check for NULL.
16364 (prepare_for_detach): Don't check for NULL.
16365
e3319240
PW
163662019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16367
16368 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16369 in case of call that did not complete.
16370
5d36dfb9
AU
163712019-01-02 Andrey Utkin <autkin@undo.io>
16372
16373 * symfile.c (find_separate_debug_file): Fix search of debug files for
16374 remote debuggee.
16375
8833fbf0
TT
163762019-01-02 Tom Tromey <tom@tromey.com>
16377
16378 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16379 indentation.
16380 * python/py-frame.c (frapy_older): Remove cast.
16381 (frapy_newer): Likewise.
16382 * python/py-breakpoint.c (local_setattro): Remove cast.
16383 * python/py-arch.c (archpy_name): Remove local variable.
16384 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16385
4ada3dfd
JB
163862019-01-02 Joel Brobecker <brobecker@adacore.com>
16387
16388 * unittests/basic_string_view/element_access/char/empty.cc:
16389 Fix year range in copyright header.
16390
113b7b81
AB
163912019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16392
16393 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16394 Delete.
16395 <operator==>: Update with for removed field.
16396 <hash>: Likewise.
16397 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16398 <isa_features>: ...this.
16399 <abi_features>: New field.
16400 (riscv_isa_flen): Update comment.
16401 (riscv_abi_xlen): New declaration.
16402 (riscv_abi_flen): New declaration.
16403 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16404 isa_features.
16405 (riscv_abi_xlen): New function.
16406 (riscv_isa_flen): Update to get answer from isa_features.
16407 (riscv_abi_flen): New function.
16408 (riscv_has_fp_abi): Update to get answer from abi_features.
16409 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16410 xlen and flen.
16411 (riscv_call_info) <xlen, flen>: Update comment.
16412 (riscv_call_arg_struct): Remove invalid assertions
16413 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16414 is removed.
16415 (riscv_gdbarch_init): Gather isa features and abi features
16416 separately, ensure both match on the gdbarch when reusing an old
16417 gdbarch. Relax an error check to allow 32-bit abi float to run on
16418 a target with 64-bit float hardware.
16419
b18ca514
PW
164202019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16421
16422 * source.c (search_command_helper): Stop reverse search
16423 when line 1 has been searched.
16424
ec70d8db
PW
164252019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16426
16427 * record-full.c (record_full_base_target::close): Rewrite
16428 record_full_core_buf_list free logic.
16429
5b38f9c1
PW
164302019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16431
16432 * break-catch-syscall.c (print_one_catch_syscall): xfree
16433 the last text.
16434
66d91b39
JB
164352019-01-01 Joel Brobecker <brobecker@adacore.com>
16436
16437 * top.c (print_gdb_version): Update Copyright year in version
16438 message.
16439
42a4f53d
JB
164402019-01-01 Joel Brobecker <brobecker@adacore.com>
16441
16442 Update copyright year range in all GDB files.
16443
7e955d83 164442019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16445
5bbd631d 16446 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16447
5bbd631d 16448For older changes see ChangeLog-2018.
c906108c
SS
16449\f
16450Local Variables:
16451mode: change-log
16452left-margin: 8
16453fill-column: 74
16454version-control: never
57da7796 16455coding: utf-8
c906108c 16456End:
5bbd631d 16457
This page took 3.818421 seconds and 4 git commands to generate.