Fix bug in nios2 prologue analysis.
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
de8af808
SL
12019-08-23 Sandra Loosemore <sandra@codesourcery.com>
2
3 * nios2-tdep.c (struct reg_value): Improve comments. Make
4 the offset field signed.
5
27204489
CB
62019-08-22 Christian Biesinger <cbiesinger@google.com>
7
8 * python/lib/gdb/__init__.py (_execute_file): New function.
9 * python/python.c (python_run_simple_file): Call gdb._execute_file
10 on Windows.
11
43771869
AB
122019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
13
14 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
15 all uses as this was never set to anything but a zero value.
16
26c957f1
PA
172019-08-21 Bogdan Harjoc <harjoc@gmail.com>
18
19 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
20
c07aae6e
CB
212019-08-21 Christian Biesinger <cbiesinger@google.com>
22
23 * tui/tui-data.h (tui_gen_win_info): Add an =default
24 move constructor, required by some GCC versions.
25
3960cb7a
JF
262019-08-21 Jinke Fan <fanjinke51@yeah.net>
27
28 * go32-nat.c (go32_sysinfo): Add hygon_p.
29
04c72a68
TT
302019-08-20 Tom Tromey <tom@tromey.com>
31
32 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
33 line_from_reg_element_no, first_reg_element_no_inline,
34 display_all_data, delete_data_content_windows,
35 erase_data_content>: Now private.
36
072272ce
TT
372019-08-20 Tom Tromey <tom@tromey.com>
38
39 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
40 (tui_unhighlight_win, tui_highlight_win)
41 (tui_win_info::make_window): Update.
42 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
43
973961bd
TT
442019-08-20 Tom Tromey <tom@tromey.com>
45
46 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
47 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
48 (MAX_PID_WIDTH): Move to tui-stack.c.
49 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
50 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
51 (MAX_PID_WIDTH): Move from tui-data.h.
52
ab0e1f1a
TT
532019-08-20 Tom Tromey <tom@tromey.com>
54
55 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
56 * tui/tui-wingeneral.c (box_win): Change type of win_info.
57 (box_win): Update.
58 (tui_gen_win_info::make_window): Rename from tui_make_window.
59 (tui_win_info::make_window): New method.
60 (tui_gen_win_info::make_visible): Update.
61 * tui/tui-source.c (tui_source_window::set_contents): Update.
62 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
63 (tui_data_window::display_registers_from): Update.
64 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
65 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
66 Declare.
67 <can_box>: Remove.
68 <title>: Remove.
69 (struct tui_win_info) <make_window>: Declare.
70 <can_box>: Now virtual.
71 <title>: New member.
72 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
73 * tui/tui-command.c (tui_cmd_window::resize): Update.
74
100c2bf3
TT
752019-08-20 Tom Tromey <tom@tromey.com>
76
77 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
78 * tui/tui-regs.c (tui_data_window::show_registers): Update.
79 (tui_data_window::check_register_values): Update.
80
fa4dc567
TT
812019-08-20 Tom Tromey <tom@tromey.com>
82
83 * tui/tui-regs.h (struct tui_data_window): Use
84 DISABLE_COPY_AND_ASSIGN.
85 <regs_content>: Change type, removing unique_ptr.
86 <tui_data_window>: Add move constructor.
87 * tui/tui-regs.c (tui_data_window::show_registers)
88 (tui_data_window::show_register_group)
89 (tui_data_window::display_registers_from)
90 (tui_data_window::display_registers_from)
91 (tui_data_window::first_data_item_displayed)
92 (tui_data_window::delete_data_content_windows)
93 (tui_data_window::rerender, tui_data_window::refresh_window)
94 (tui_data_window::check_register_values): Update.
95
ca02d7c8
TT
962019-08-20 Tom Tromey <tom@tromey.com>
97
98 * tui/tui-regs.h (struct tui_data_window) <show_registers,
99 show_register_group>: Declare.
100 (tui_show_register_group): Don't declare.
101 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
102 tui_show_registers.
103 (tui_data_window::show_register_group): Rename from
104 tui_show_register_group.
105 (tui_data_window::check_register_values, tui_reg_command):
106 Update.
107 * tui/tui-layout.c (tui_set_layout): Update.
108
63356bfd
TT
1092019-08-20 Tom Tromey <tom@tromey.com>
110
111 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
112 Declare.
113 (tui_check_register_values): Don't declare.
114 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
115 from tui_check_register_values.
116 * tui/tui-hooks.c (tui_register_changed): Update.
117
42cc14a7
TT
1182019-08-20 Tom Tromey <tom@tromey.com>
119
120 * tui/tui-regs.c (tui_reg_layout): Move later.
121 (tui_show_registers): Don't enable TUI mode or change layout.
122
b9ad3686
TT
1232019-08-20 Tom Tromey <tom@tromey.com>
124
125 * tui/tui-regs.h (struct tui_data_item_window)
126 <~tui_data_item_window>: Remove.
127 <content>: Now a unique_xmalloc_ptr.
128 * tui/tui-regs.c (tui_register_format): Return a
129 unique_xmalloc_ptr.
130 (tui_get_register): Update.
131 (~tui_data_item_window): Remove.
132 (tui_data_window::display_registers_from, tui_display_register):
133 Update.
134 * tui/tui-io.h (tui_expand_tabs): Update.
135 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
136 Remove "col" parameter.
137
8e114aab
TT
1382019-08-20 Tom Tromey <tom@tromey.com>
139
140 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
141 field.
142 * tui/tui-regs.c (~tui_data_item_window): Update.
143
1a4f81dd
TT
1442019-08-20 Tom Tromey <tom@tromey.com>
145
146 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
147 earlier.
148
0f8d8876
TT
1492019-08-20 Tom Tromey <tom@tromey.com>
150
151 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
152
605dc2c2
TT
1532019-08-20 Tom Tromey <tom@tromey.com>
154
155 * tui/tui-source.h (struct tui_source_window): Update.
156 * tui/tui-regs.c (tui_show_registers): Update.
157 * tui/tui-disasm.h (struct tui_disasm_window): Update.
158 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
159 (NO_REGS_STRING): Remove defines.
160
aedbe3bb
CM
1612019-08-20 Conrad Meyer <cem@FreeBSD.org>
162
163 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
164 unnecessary thread walk if remote doesn't support the packet.
165
7ce8f214
TT
1662019-08-19 Tom Tromey <tromey@adacore.com>
167
168 * python/py-value.c (value_has_field): Fix indentation.
169
f21c2bd7
TT
1702019-08-19 Tom Tromey <tromey@adacore.com>
171
172 * printcmd.c (do_one_display, info_display_command): Update.
173 * block.h (contained_in): Return bool. Add allow_nested
174 parameter.
175 * block.c (contained_in): Return bool. Add allow_nested
176 parameter.
177
d806ea2d
TT
1782019-08-19 Tom Tromey <tom@tromey.com>
179
180 * configure: Rebuild.
181 * configure.ac: Disallow the combination of -static-libstdc++ and
182 source highlight.
183 * source-cache.c (get_language_name): Handle rust.
184 (source_cache::get_source_lines): Ignore highlighting exceptions.
185
398fdd60
TT
1862019-08-16 Tom Tromey <tom@tromey.com>
187
188 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
189 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
190 (struct tui_source_window_base) <make_visible, refresh_window,
191 resize>: Remove methods.
192 <execution_info>: Remove field.
193 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
194 (tui_show_source_line, tui_source_window_base)
195 (~tui_source_window_base): Update.
196 (tui_source_window_base::resize)
197 (tui_source_window_base::make_visible)
198 (tui_source_window_base::refresh_window): Remove.
199 (tui_source_window_base::update_exec_info): Update.
200 * tui/tui-source.c (tui_source_window::set_contents): Update.
201 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
202
e699d331
TT
2032019-08-16 Tom Tromey <tom@tromey.com>
204
205 * tui/tui-hooks.c (tui_remove_hooks): Don't set
206 deprecated_query_hook.
207
bb01dbfc
TT
2082019-08-16 Tom Tromey <tom@tromey.com>
209
210 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
211 (tui_update_source_windows_with_line): Update.
212 * tui/tui-source.h (struct tui_source_window)
213 <show_symtab_source>: Declare.
214 (tui_show_symtab_source): Don't declare.
215 * tui/tui-source.c (tui_show_symtab_source): Rename from
216 tui_show_symtab_source.
217
81c82c4b
TT
2182019-08-16 Tom Tromey <tom@tromey.com>
219
220 * tui/tui-winsource.h (struct tui_source_window_base)
221 <set_contents>: Declare.
222 * tui/tui-winsource.c
223 (tui_source_window_base::update_source_window_as_is): Update.
224 * tui/tui-source.h (struct tui_source_window) <set_contents>:
225 Declare.
226 (tui_set_source_content): Don't declare.
227 * tui/tui-source.c (tui_source_window::set_contents): Rename from
228 tui_set_source_content.
229 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
230 Declare.
231 (tui_set_disassem_content): Don't declare.
232 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
233 tui_set_disassem_content.
234
2ddaf614
TT
2352019-08-16 Tom Tromey <tom@tromey.com>
236
237 * tui/tui-winsource.h (struct tui_source_window_base)
238 <update_breakpoint_info>: Declare.
239 (tui_update_breakpoint_info): Don't declare.
240 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
241 (tui_update_all_breakpoint_info): Update.
242 (tui_source_window_base::update_breakpoint_info): Rename from
243 tui_update_breakpoint_info.
244 (tui_source_window_base::update_exec_info): Update.
245
017f9828
TT
2462019-08-16 Tom Tromey <tom@tromey.com>
247
248 * tui/tui-winsource.h (struct tui_source_window_base)
249 <update_source_window>: Declare.
250 (tui_update_source_window): Don't declare.
251 * tui/tui-winsource.c
252 (tui_source_window_base::update_source_window): Rename from
253 tui_update_source_window.
254 (tui_source_window_base::rerender): Update.
255 * tui/tui-source.c (tui_source_window::maybe_update): Update.
256 * tui/tui-disasm.c (tui_show_disassem)
257 (tui_show_disassem_and_update_source)
258 (tui_disasm_window::maybe_update): Update.
259
ed8358e9
TT
2602019-08-16 Tom Tromey <tom@tromey.com>
261
262 * tui/tui-winsource.h (struct tui_source_window_base)
263 <update_source_window_as_is>: Declare.
264 (tui_update_source_window_as_is): Don't declare.
265 * tui/tui-winsource.c (tui_update_source_window): Update
266 (tui_source_window_base::update_source_window_as_is): Rename from
267 tui_update_source_window_as_is.
268 (tui_source_window_base::refill): Update.
269 * tui/tui-source.c (tui_show_symtab_source): Update.
270 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
271 Update.
272
20149b6b
TT
2732019-08-16 Tom Tromey <tom@tromey.com>
274
275 * tui/tui-winsource.h (tui_update_source_window)
276 (tui_update_source_window_as_is): Remove "noerror" parameter.
277 * tui/tui-winsource.c (tui_update_source_window)
278 (tui_update_source_window_as_is): Remove "noerror" parameter.
279 (tui_update_source_windows_with_addr)
280 (tui_update_source_windows_with_line)
281 (tui_source_window_base::rerender)
282 (tui_source_window_base::refill): Update.
283 * tui/tui-source.h (tui_set_source_content)
284 (tui_show_symtab_source): Remove "noerror" parameter.
285 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
286 parameter.
287 (tui_show_symtab_source): Likewise.
288 (tui_source_window::maybe_update): Update.
289 * tui/tui-disasm.c (tui_show_disassem)
290 (tui_show_disassem_and_update_source)
291 (tui_disasm_window::do_scroll_vertical)
292 (tui_disasm_window::maybe_update): Update.
293
2d83e710
TT
2942019-08-16 Tom Tromey <tom@tromey.com>
295
296 * tui/tui.c (tui_is_window_visible): Update.
297 * tui/tui-wingeneral.c (tui_make_window)
298 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
299 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
300 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
301 (tui_set_win_height_command, parse_scrolling_args): Update.
302 * tui/tui-source.c (tui_source_window::style_changed): Update.
303 * tui/tui-regs.c (tui_show_registers)
304 (tui_data_window::first_data_item_displayed)
305 (tui_data_window::delete_data_content_windows)
306 (tui_check_register_values, tui_reg_command): Update.
307 * tui/tui-disasm.c (tui_show_disassem): Update.
308 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
309 method.
310 <is_visible>: Remove field.
311 * tui/tui-data.c (tui_next_win, tui_prev_win)
312 (tui_delete_invisible_windows): Update.
313
d4ab829a
TT
3142019-08-16 Tom Tromey <tom@tromey.com>
315
316 * tui/tui-winsource.h (struct tui_source_window_base)
317 <m_has_locator>: Remove.
318 * tui/tui-layout.c (show_source_disasm_command, show_data)
319 (show_source_or_disasm_and_command): Update.
320
aa7ca1bb
AH
3212019-08-16 Alan Hayward <alan.hayward@arm.com>
322
323 * NEWS (Other MI changes): New subsection.
324 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
325 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
326 * arch-utils.c (default_get_pc_address_flags): New function.
327 * arch-utils.h (default_get_pc_address_flags): New declaration.
328 * gdbarch.sh: Add get_pc_address_flags.
329 * gdbarch.c: Regenerate.
330 * gdbarch.h: Likewise.
331 * stack.c (print_pc): New function.
332 (print_frame_info) (print_frame): Call print_pc.
333
6eac171f
TV
3342019-08-16 Tom de Vries <tdevries@suse.de>
335
336 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
337 print_objfile_section_info.
338
3df505f6
TT
3392019-08-15 Tom Tromey <tom@tromey.com>
340
341 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
342 calling update_cmdwin_start_line.
343 * tui/tui-winsource.h (struct tui_source_window_base)
344 <do_make_visible_with_new_height, set_new_height>: Don't declare.
345 <rerender>: Declare.
346 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
347 Call rerender.
348 (tui_source_window_base::set_new_height): Remove.
349 (tui_source_window_base::rerender): Rename from
350 do_make_visible_with_new_height.
351 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
352 resize method.
353 (tui_win_info::make_invisible_and_set_new_height)
354 (tui_win_info::make_visible_with_new_height): Remove.
355 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
356 Declare.
357 * tui/tui-stack.c (tui_locator_window::rerender): New method.
358 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
359 do_make_visible_with_new_height>: Don't declare.
360 <rerender>: Declare.
361 * tui/tui-regs.c (tui_data_window::rerender): Rename from
362 set_new_height.
363 (tui_data_window::do_make_visible_with_new_height): Remove.
364 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
365 call tui_show_locator_content.
366 (tui_gen_win_info::resize): Call rerender.
367 (show_source_or_disasm_and_command): Don't call
368 tui_show_locator_content.
369 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
370 method.
371 (struct tui_win_info) <rerender>: Declare.
372 <set_new_height, make_invisible_and_set_new_height,
373 make_visible_with_new_height>: Don't declare.
374 * tui/tui-data.c (tui_win_list::rerender): New method.
375 * tui/tui-command.h (struct tui_cmd_window)
376 <do_make_visible_with_new_height>: Don't declare.
377 * tui/tui-command.c
378 (tui_cmd_window::do_make_visible_with_new_height): Remove.
379
272560b5
TT
3802019-08-15 Tom Tromey <tromey@adacore.com>
381
382 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
383 * ada-lang.c (ada_enum_name): Likewise.
384
08235187
CB
3852019-08-15 Christian Biesinger <cbiesinger@google.com>
386
387 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
388 leading underscore.
389 (GdbOutputErrorFile): Likewise.
390 (global scope): Adjust constructor calls to GdbOutput{,Error}File
391 accordingly.
392 (execute_unwinders): Rename to have a leading underscore.
393 (auto_load_packages): Likewise.
394 (global scope): Adjust call to auto_load_packages accordingly.
395 (GdbSetPythonDirectory): Likewise.
396 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
397 instead of execute_unwinders.
398
db502012
TT
3992019-08-15 Tom Tromey <tom@tromey.com>
400
401 * tui/tui-layout.c (show_layout, show_source_disasm_command)
402 (show_data): Don't change window visibility.
403 (tui_gen_win_info::resize): Remove special case for command
404 window. Use wresize, when available.
405 (show_source_or_disasm_and_command): Don't change window
406 visibility.
407 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
408 <make_visible>: New method.
409 * tui/tui-command.c (tui_cmd_window::resize): New method.
410
3891b65e
TT
4112019-08-15 Tom Tromey <tom@tromey.com>
412
413 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
414 (struct tui_source_windows): New.
415 * tui/tui-winsource.c (tui_display_main): Update.
416 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
417 (new_height_ok, parse_scrolling_args): Update.
418 * tui/tui-layout.c (show_layout, show_data): Update.
419 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
420 (tui_add_to_source_windows): Don't declare.
421 * tui/tui-data.c (source_windows, tui_source_windows)
422 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
423
ee556432
TT
4242019-08-15 Tom Tromey <tom@tromey.com>
425
426 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
427 Rename from reset.
428 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
429 * tui/tui-layout.c (show_source_disasm_command, show_data):
430 Update.
431 (tui_gen_win_info::resize): Rename.
432 (show_source_or_disasm_and_command): Update.
433 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
434 reset.
435
46f438e3
TT
4362019-08-15 Tom Tromey <tom@tromey.com>
437
438 * tui/tui-stack.c (tui_initialize_static_data): Remove.
439 * tui/tui-interp.c (tui_interp::init): Don't call
440 tui_initialize_static_data.
441 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
442
f4ce562c
TT
4432019-08-15 Tom Tromey <tom@tromey.com>
444
445 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
446 examine tui_win_list.
447
c398c3d0
TT
4482019-08-15 Tom Tromey <tom@tromey.com>
449
450 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
451 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
452 tui_clear_source_content.
453 (tui_clear_source_content): Remove.
454 (tui_source_window_base::do_erase_source_content): Hoist call to
455 content.clear().
456 * tui/tui-stack.c (tui_show_frame_info): Don't call
457 tui_clear_source_content.
458
e25d2004
TT
4592019-08-15 Tom Tromey <tom@tromey.com>
460
461 * tui/tui-winsource.h (struct tui_source_window_base)
462 <do_erase_source_content>: New method.
463 <erase_source_content>: New method.
464 (tui_erase_source_content): Don't declare.
465 * tui/tui-winsource.c (tui_clear_source_content): Update.
466 (tui_source_window_base::do_erase_source_content): Rename from
467 tui_erase_source_content.
468 (tui_source_window_base::show_source_content): Update.
469 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
470 * tui/tui-source.h (struct tui_source_window)
471 <erase_source_content>: New method.
472 * tui/tui-disasm.h (struct tui_disasm_window)
473 <erase_source_content>: New method.
474
002f15c2
TT
4752019-08-15 Tom Tromey <tom@tromey.com>
476
477 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
478 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
479 constructor.
480 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
481 * tui/tui-source.c (tui_set_source_content): Update.
482 * tui/tui-disasm.c (tui_set_disassem_content): Update.
483
c9033fe8
TT
4842019-08-15 Tom Tromey <tom@tromey.com>
485
486 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
487 * tui/tui-winsource.c (tui_line_is_displayed): Move to
488 tui-source.c.
489 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
490 Declare.
491 * tui/tui-source.c (tui_source_window::line_is_displayed): New
492 method.
493 (tui_source_window::maybe_update): Update.
494
088f37dd
TT
4952019-08-15 Tom Tromey <tom@tromey.com>
496
497 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
498 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
499 tui-disasm.c.
500 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
501 Declare.
502 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
503 method.
504 (tui_disasm_window::maybe_update): Update.
505
a54700c6
TT
5062019-08-15 Tom Tromey <tom@tromey.com>
507
508 * tui/tui-winsource.h (struct tui_source_window_base)
509 <maybe_update>: Declare.
510 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
511 method.
512 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
513 Declare.
514 * tui/tui-source.c (tui_source_window::maybe_update): New method.
515 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
516 Declare.
517 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
518
e2a678a5
TT
5192019-08-15 Tom Tromey <tom@tromey.com>
520
521 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
522
f2dda477
TT
5232019-08-15 Tom Tromey <tom@tromey.com>
524
525 * tui/tui-wingeneral.c: Include tui-stack.h.
526 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
527 (struct tui_locator_window): Move from tui-data.h.
528 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
529 (tui_initialize_static_data): Move from tui-data.c.
530 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
531 (struct tui_locator_window): Move to tui-stack.c.
532 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
533 (tui_initialize_static_data): Move to tui-stack.c.
534
ed4a1084
TT
5352019-08-15 Tom Tromey <tom@tromey.com>
536
537 * tui/tui-layout.c (show_source_disasm_command)
538 (show_source_or_disasm_and_command): Use make_visible method, not
539 tui_make_window.
540 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
541 Remove.
542
65962b20
TT
5432019-08-15 Tom Tromey <tom@tromey.com>
544
545 * tui/tui-wingeneral.h (tui_make_window): Update.
546 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
547 parameter.
548 (tui_gen_win_info::make_visible): Update.
549 * tui/tui-regs.c (tui_data_window::display_registers_from):
550 Update.
551 * tui/tui-layout.c (show_source_disasm_command)
552 (show_source_or_disasm_and_command): Update.
553 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
554 (enum tui_box): Remove.
555 (struct tui_win_info) <can_box>: New method.
556 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
557 method.
558
2208ee91
TV
5592019-08-15 Tom de Vries <tdevries@suse.de>
560
561 * linux-nat-trad.c: Include gdbarch.h.
562
75faf5c4
AH
5632019-08-14 Alan Hayward <alan.hayward@arm.com>
564
565 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
566 register sizes.
567
b1c896b3
TT
5682019-08-14 Tom Tromey <tromey@adacore.com>
569
570 * darwin-nat.c: Include gdbarch.h.
571 * darwin-nat-info.c: Include gdbarch.h.
572
6405cd73
TT
5732019-08-13 Tom Tromey <tom@tromey.com>
574
575 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
576 Remove.
577 * tui/tui-data.c (tui_initialize_static_data): Update.
578
5216580d
TT
5792019-08-13 Tom Tromey <tom@tromey.com>
580
581 * tui/tui-winsource.h (struct tui_exec_info_window)
582 <~tui_exec_info_window, maybe_allocate_content, get_content,
583 m_content>: Remove.
584 (struct tui_source_window_base) <set_exec_info_content,
585 show_exec_info_content>: Don't declare.
586 * tui/tui-winsource.c
587 (tui_exec_info_window::maybe_allocate_content): Remove.
588 (tui_source_window_base::update_exec_info): Rename from
589 set_exec_info_content.
590 (tui_source_window_base::show_exec_info_content)
591 (tui_source_window_base::update_exec_info): Remove.
592
93858ad3
TT
5932019-08-13 Tom Tromey <tom@tromey.com>
594
595 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
596 declare.
597 * tui/tui-winsource.c (tui_update_source_window_as_is)
598 (tui_update_source_windows_with_addr, tui_erase_source_content):
599 Update.
600 (tui_clear_exec_info_content): Remove.
601
e321e7ce
TT
6022019-08-13 Tom Tromey <tom@tromey.com>
603
604 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
605 declare.
606 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
607 call tui_erase_exec_info_content.
608 (tui_clear_exec_info_content): Rename from
609 tui_erase_exec_info_content.
610 (tui_clear_exec_info_content): Delete.
611
8270ac62
TT
6122019-08-13 Tom Tromey <tom@tromey.com>
613
614 * tui/tui-winsource.h (struct tui_source_window_base)
615 <show_exec_info_content>: Declare.
616 (tui_show_exec_info_content): Don't declare.
617 * tui/tui-winsource.c
618 (tui_source_window_base::show_exec_info_content): Rename from
619 tui_show_exec_info_content.
620 (tui_source_window_base::update_exec_info): Update.
621
7b56485d
TT
6222019-08-13 Tom Tromey <tom@tromey.com>
623
624 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
625 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
626 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
627 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
628 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
629 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
630 ... here.
631
7ba913dc
TT
6322019-08-13 Tom Tromey <tom@tromey.com>
633
634 * tui/tui-winsource.h (struct tui_source_window_base)
635 <update_exec_info>: Declare.
636 (tui_update_exec_info): Don't declare.
637 * tui/tui-winsource.c (tui_update_source_window_as_is)
638 (tui_source_window_base::refresh_all)
639 (tui_update_all_breakpoint_info): Update.
640 (tui_source_window_base::update_exec_info): Rename from
641 tui_update_exec_info.
642 * tui/tui-stack.c (tui_show_frame_info): Update.
643
37a4a131
TT
6442019-08-13 Tom Tromey <tom@tromey.com>
645
646 * tui/tui-winsource.h (struct tui_source_window_base)
647 <set_exec_info_content>: Declare.
648 (tui_set_exec_info_content): Don't declare.
649 * tui/tui-winsource.c
650 (tui_source_window_base::set_exec_info_content): Rename from
651 tui_set_exec_info_content.
652 (tui_update_exec_info): Update.
653
0bd27e07
TT
6542019-08-13 Tom Tromey <tom@tromey.com>
655
656 * tui/tui-winsource.h (struct tui_source_window_base)
657 <show_source_content>: Declare.
658 (tui_show_source_content): Don't declare.
659 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
660 (tui_source_window_base::show_source_content): Rename from
661 tui_show_source_content.
662 (tui_source_window_base::refresh_all): Update.
663 * tui/tui-layout.c (show_source_disasm_command)
664 (show_source_or_disasm_and_command): Update.
665
b4ef5aeb
TT
6662019-08-13 Tom Tromey <tom@tromey.com>
667
668 * tui/tui-winsource.c (tui_erase_source_content)
669 (tui_show_source_content, tui_source_window_base::refresh_all):
670 Update.
671 * tui/tui-wingeneral.h
672 (tui_check_and_display_highlight_if_needed): Don't declare.
673 * tui/tui-wingeneral.c
674 (tui_win_info::check_and_display_highlight_if_needed): Rename from
675 check_and_display_highlight_if_needed.
676 * tui/tui-win.c (tui_rehighlight_all)
677 (tui_win_info::make_visible_with_new_height): Update.
678 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
679 (tui_data_window::erase_data_content)
680 (tui_data_window::display_all_data): Update.
681 * tui/tui-data.h (struct tui_win_info)
682 <check_and_display_highlight_if_needed>: Declare.
683
fede5273
TT
6842019-08-13 Tom Tromey <tom@tromey.com>
685
686 * tui/tui-win.c (tui_resize_all): Call
687 tui_delete_invisible_windows.
688 * tui/tui-layout.c (show_layout): Call
689 tui_delete_invisible_windows.
690 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
691 * tui/tui-data.c (tui_delete_invisible_windows): New function.
692
22c3f490
TT
6932019-08-13 Tom Tromey <tom@tromey.com>
694
695 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
696 tui_add_win_to_layout.
697
16cb7910
TT
6982019-08-13 Tom Tromey <tom@tromey.com>
699
700 * tui/tui-layout.h (tui_default_win_height): Don't declare.
701 * tui/tui-layout.c (tui_default_win_height): Now static.
702
cc0c3ffb
TT
7032019-08-13 Tom Tromey <tom@tromey.com>
704
705 * tui/tui-layout.c (show_layout): Unify all layout cases into a
706 single switch.
707 (show_source_disasm_command, show_source_or_disasm_and_command):
708 Don't check current layout.
709
3f3ffe54
TT
7102019-08-13 Tom Tromey <tom@tromey.com>
711
712 * tui/tui-wingeneral.c (make_all_visible): Remove.
713 (tui_make_all_invisible): Simplify.
714 * tui/tui-layout.c (tui_make_all_invisible): Move from
715 tui-wingeneral.c; simplify.
716 (show_layout): Hoist call to tui_make_all_invisible.
717 (show_data): Don't call tui_make_all_invisible.
718
69258091
TT
7192019-08-13 Tom Tromey <tom@tromey.com>
720
721 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
722 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
723
62cf57fe
TT
7242019-08-13 Tom Tromey <tom@tromey.com>
725
726 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
727 tui-data.c.
728 (show_source_disasm_command, show_data)
729 (show_source_or_disasm_and_command): Don't use
730 tui_set_current_layout_to.
731 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
732 * tui/tui-data.c (current_layout, tui_current_layout): Move to
733 tui-layout.c.
734 (tui_set_current_layout_to): Remove.
735
2afade5d
TT
7362019-08-13 Tom Tromey <tom@tromey.com>
737
738 * tui/tui-layout.c (tui_set_layout): Update.
739 * tui/tui-data.h (struct tui_layout_def): Remove.
740 (tui_layout_def): Don't declare.
741 * tui/tui-data.c (layout_def): Remove.
742 (tui_layout_def): Remove.
743
a3504e96
TT
7442019-08-13 Tom Tromey <tom@tromey.com>
745
746 * tui/tui-winsource.h (struct tui_source_window_base)
747 <clear_detail>: No longer "override".
748 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
749 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
750 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
751 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
752 Remove.
753 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
754
29c92911
TT
7552019-08-13 Tom Tromey <tromey@adacore.com>
756
757 * tracepoint.c: Don't include readline.h or history.h.
758
86c6b807
TT
7592019-08-12 Tom Tromey <tom@tromey.com>
760
761 * configure: Rebuild.
762 * configure.ac: Check for readline 7.
763 * NEWS: Mention readline 7 requirement.
764 * README: Update.
765
5db2718c
TT
7662019-08-12 Tom Tromey <tom@tromey.com>
767
768 * mingw-hdep.c (gdb_select): Remove readline hack.
769
dac36daf
PFC
7702019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
771
772 * blockframe.c (find_pc_partial_function): Set *block to nullptr
773 when the function fails.
774
1022c627
AA
7752019-08-09 Andreas Arnez <arnez@linux.ibm.com>
776
777 * s390-tdep.c (s390_type_align): New function.
778 (s390_gdbarch_init): Set it as type_align gdbarch method.
779
eba4caf2
TV
7802019-08-09 Tom de Vries <tdevries@suse.de>
781
782 PR gdb/24591
783 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
784 pc_low with relocation offset.
785
123cd851
TT
7862019-08-07 Tom Tromey <tromey@adacore.com>
787
788 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
789 (print_frame_args): Update.
790 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
791 Update.
792 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
793 * frame.h (struct frame_arg): Add initializers.
794 <error>: Now a unique_xmalloc_ptr.
795
3d31bc39
AH
7962019-08-07 Alan Hayward <alan.hayward@arm.com>
797
798 * NEWS: Expand the Pointer Authentication entry.
799 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
800 (aarch64_frame_unmask_lr): ... to this.
801 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
802 Call aarch64_frame_unmask_lr.
803 * frame.c (struct frame_info): Add "masked" variable.
804 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
805 (fprint_frame): Check for masked pc.
806 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
807 declarations.
808 * python/py-framefilter.c (py_print_frame): Check for masked pc.
809 * stack.c (print_frame): Check for masked pc.
810
0cf9feb9
TT
8112019-08-06 Tom Tromey <tom@tromey.com>
812
813 * stabsread.c (patch_block_stabs, read_one_struct_field)
814 (read_enum_type): Use obstack_strndup.
815 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
816 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
817 * dwarf2read.c (guess_full_die_structure_name)
818 (anonymous_struct_prefix): Use obstack_strndup.
819 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
820 * c-exp.y (yylex): Use obstack_strndup.
821 * ada-exp.y (write_object_renaming, write_ambiguous_var)
822 (write_var_or_type): Use obstack_strndup.
823
efba19b0
TT
8242019-08-06 Tom Tromey <tom@tromey.com>
825
826 * symfile.c (reread_symbols): Use obstack_strdup.
827 * stabsread.c (read_type): Use obstack_strdup.
828 * gdb_obstack.h (obstack_strdup): New overload.
829 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
830 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
831 (dwarf2_canonicalize_name): Use obstack_strdup.
832 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
833 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
834 Use obstack_strdup.
835
f25102f7
TT
8362019-08-06 Tom Tromey <tom@tromey.com>
837
838 * gdb_obstack.h (obstack_strdup): Define.
839 * gdb_obstack.c (obstack_strdup): Don't define.
840
021887d8
TT
8412019-08-06 Tom Tromey <tom@tromey.com>
842
843 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
844 obstack_strdup.
845 * typeprint.c (typedef_hash_table::find_global_typedef): Use
846 obstack_strdup.
847 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
848 * stabsread.c (common_block_start): Use obstack_strdup.
849 * objfiles.c (set_objfile_main_name, objfile): Use
850 obstack_strdup.
851 * namespace.c (add_using_directive): Use obstack_strdup.
852 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
853 * jit.c (finalize_symtab): Use obstack_strdup.
854 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
855 (guess_partial_die_structure_name, partial_die_info::fixup)
856 (dwarf2_name): Use obstack_strdup.
857 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
858 obstack_strdup.
859 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
860 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
861 obstack_strdup.
862 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
863
d2834edc
PW
8642019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
865
866 * unittests/help-doc-selftests.c: New file.
867 * Makefile.in: Add the new file.
868
590042fc
PW
8692019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
870
871 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
872 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
873 the full first line, except when FOR_VALUE_PREFIX. In this case,
874 the trailing '.' is not output, and the first character is uppercased.
875 (print_help_for_command): Update call to print_doc_line.
876 (print_doc_of_command): Likewise.
877 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
878 * cli/cli-option.c (append_indented_doc): Do not append newline.
879 (build_help_option): Append newline after first appended_indented_doc
880 only if a second call is done.
881 (build_help): Append 2 new lines before each option, except the first
882 one.
883 * compile/compile.c (_initialize_compile): Add new lines after
884 %OPTIONS%, when not at the end of the help.
885 Change help doc or code
886 producing the help doc to respect the invariants.
887 * maint-test-options.c (_initialize_maint_test_options): Likewise.
888 Also removed the new line after 'Options:', as all other commands
889 do not put an empty line between 'Options:' and the first option.
890 * printcmd.c (_initialize_printcmd): Likewise.
891 * stack.c (_initialize_stack): Likewise.
892 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
893 incorrectly telling COMMAND is optional.
894 * ada-lang.c (_initialize_ada_language): Change help doc or code
895 producing the help doc to respect the invariants.
896 * ada-tasks.c (_initialize_ada_tasks): Likewise.
897 * breakpoint.c (_initialize_breakpoint): Likewise.
898 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
899 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
900 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
901 * cli/cli-style.c (cli_style_option::add_setshow_commands,
902 _initialize_cli_style): Likewise.
903 * corelow.c (core_target_info): Likewise.
904 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
905 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
906 * filesystem.c (_initialize_filesystem): Likewise.
907 * frame.c (_initialize_frame): Likewise.
908 * gnu-nat.c (add_task_commands): Likewise.
909 * infcall.c (_initialize_infcall): Likewise.
910 * infcmd.c (_initialize_infcmd): Likewise.
911 * interps.c (_initialize_interpreter): Likewise.
912 * language.c (_initialize_language): Likewise.
913 * linux-fork.c (_initialize_linux_fork): Likewise.
914 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
915 * maint.c (_initialize_maint_cmds): Likewise.
916 * memattr.c (_initialize_mem): Likewise.
917 * printcmd.c (_initialize_printcmd): Likewise.
918 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
919 _RegEx): Likewise.
920 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
921 * record-btrace.c (_initialize_record_btrace): Likewise.
922 * record-full.c (_initialize_record_full): Likewise.
923 * record.c (_initialize_record): Likewise.
924 * regcache-dump.c (_initialize_regcache_dump): Likewise.
925 * regcache.c (_initialize_regcache): Likewise.
926 * remote.c (add_packet_config_cmd, init_remote_threadtests,
927 _initialize_remote): Likewise.
928 * ser-tcp.c (_initialize_ser_tcp): Likewise.
929 * serial.c (_initialize_serial): Likewise.
930 * skip.c (_initialize_step_skip): Likewise.
931 * source.c (_initialize_source): Likewise.
932 * stack.c (_initialize_stack): Likewise.
933 * symfile.c (_initialize_symfile): Likewise.
934 * symtab.c (_initialize_symtab): Likewise.
935 * target-descriptions.c (_initialize_target_descriptions): Likewise.
936 * top.c (init_main): Likewise.
937 * tracefile-tfile.c (tfile_target_info): Likewise.
938 * tracepoint.c (_initialize_tracepoint): Likewise.
939 * tui/tui-win.c (_initialize_tui_win): Likewise.
940 * utils.c (add_internal_problem_command): Likewise.
941 * valprint.c (value_print_option_defs): Likewise.
942
404f2902
FCE
9432019-08-06 Frank Ch. Eigler <fche@redhat.com>
944
945 PR build/24886
946 * configure.ac: Drop enable-libmcheck support.
947 * configure, config.in: Rebuild.
948 * libmcheck.m4: Remove.
949 * acinclude.m4: Don't include it.
950 * Makefile.in: Don't distribute it.
951 * top.c (print_gdb_configuration): Don't mention it.
952
046bebe1
TT
9532019-08-06 Tom Tromey <tom@tromey.com>
954
955 * utils.c (set_output_style): Sometimes pass stream to
956 emit_style_escape.
957 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
958 * record-btrace.c (btrace_insn_history): Update.
959 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
960 method.
961 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
962 Update initializers.
963 <m_uiout>: New field.
964 <m_di>: Move lower.
965 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
966 Remove "uiout" parameter.
967 (dump_insns): Update.
968 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
969 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
970
ddbcedf5
CB
9712019-08-06 Christian Biesinger <cbiesinger@google.com>
972
973 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
974 (error_in_psymtab_expansion): Likewise.
975 (lookup_symbol_via_quick_fns): Likewise.
976 (basic_lookup_transparent_type_quick): Likewise.
977 (basic_lookup_transparent_type_1): Likewise.
978
b08b16c8
TT
9792019-08-06 Tom Tromey <tromey@adacore.com>
980
981 * source.c (last_source_error): Now bool.
982 (print_source_lines_base): Make "noprint" bool. Only open
983 source file when last_source_visited changes.
984
cb44333d
TT
9852019-08-06 Tom Tromey <tromey@adacore.com>
986
987 * annotate.c (annotate_source_line): Use g_source_cache.
988 * source-cache.c (source_cache::get_plain_source_lines): Change
989 parameters. Populate m_offset_cache.
990 (source_cache::ensure): New method.
991 (source_cache::get_line_charpos): New method.
992 (extract_lines): Move lower. Change parameters.
993 (source_cache::get_source_lines): Move lower.
994 * source-cache.h (class source_cache): Update comment.
995 <get_line_charpos>: New method.
996 <get_source_lines>: Update comment.
997 <clear>: Clear m_offset_cache.
998 <get_plain_source_lines>: Change parameters.
999 <ensure>: New method
1000 <m_offset_cache>: New member.
1001 * source.c (forget_cached_source_info_for_objfile): Update.
1002 (info_source_command): Use g_source_cache.
1003 (find_source_lines, open_source_file_with_line_charpos): Remove.
1004 (print_source_lines_base, search_command_helper): Use g_source_cache.
1005 * source.h (open_source_file_with_line_charpos): Don't declare.
1006 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1007 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1008 Use g_source_cache.
1009
872dceaa
TT
10102019-08-06 Tom Tromey <tromey@adacore.com>
1011
1012 * source-cache.c (source_cache::get_plain_source_lines):
1013 Remove "first_line" and "last_line" parameters.
1014 (source_cache::get_source_lines): Cache plain text.
1015 * source-cache.h (class source_cache)
1016 <get_plain_source_lines>: Update.
1017
269249d9
TT
10182019-08-06 Tom Tromey <tromey@adacore.com>
1019
1020 * source-cache.c (extract_lines): No longer a method.
1021 Changed type of parameter. Include final newline.
1022 (selftests::extract_lines_test): New function.
1023 (_initialize_source_cache): Likewise.
1024 * source-cache.h (class source_cache)
1025 <extract_lines>: Don't declare.
1026
c0e8dcd8
TT
10272019-08-06 Tom Tromey <tromey@adacore.com>
1028
1029 * breakpoint.c (init_breakpoint_sal): Update.
1030 (breakpoint): Update.
1031 * breakpoint.h (struct breakpoint) <filter>: Now a
1032 unique_xmalloc_ptr.
1033
0b27c27d
CB
10342019-08-05 Christian Biesinger <cbiesinger@google.com>
1035
1036 * NEWS: Mention dictionary access on blocks.
1037 * python/py-block.c (blpy_getitem): New function.
1038 (block_object_as_mapping): New struct.
1039 (block_object_type): Use new struct for tp_as_mapping field.
1040
4ee94178
CB
10412019-08-05 Christian Biesinger <cbiesinger@google.com>
1042
1043 * objfiles.h (objfile): Add a comment describing partial symbols.
1044
8abfcabc
TT
10452019-08-05 Tom Tromey <tromey@adacore.com>
1046
1047 * compile/compile.c (_initialize_compile): Use _(), not N_().
1048 * thread.c (_initialize_thread): Use _(), not N_().
1049 * stack.c (_initialize_stack): Use _(), not N_().
1050 * printcmd.c (_initialize_printcmd): Use _(), not N_().
1051
2b79f376
SM
10522019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
1053
1054 * dwarf2read.c (struct dw2_symtab_iterator):
1055 <want_specific_block>: Remove.
1056 <block_index>: Change type to gdb::optional.
1057 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1058 change type of BLOCK_INDEX parameter to gdb::optional.
1059 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1060 (dw2_lookup_symbol): Don't pass argument for
1061 WANT_SPECIFIC_BLOCK.
1062 (dw2_expand_symtabs_for_function): Don't pass argument for
1063 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1064 (class dw2_debug_names_iterator)
1065 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1066 parameter, change BLOCK_INDEX type to gdb::optional.
1067 <m_want_specific_block>: Remove.
1068 <m_block_index>: Change type to gdb::optional.
1069 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1070 gdb::optional. Re-write in function of gdb::optional.
1071 (dw2_debug_names_lookup_symbol): Don't pass argument for
1072 WANT_SPECIFIC_BLOCK.
1073 (dw2_debug_names_expand_symtabs_for_function): Don't pass
1074 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1075 BLOCK_INDEX.
1076
ae60f04e
PW
10772019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1078
1079 * NEWS: Mention changes to "info sources" command.
1080
28cd9371
PW
10812019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1082
1083 * symtab.c (filename_partial_match_opts): New struct type.
1084 (struct output_source_filename_data): New members
1085 regexp, c_regexp, partial_match.
1086 (output_source_filename): Use new members to decide to print file.
1087 (info_sources_option_defs): New variable.
1088 (make_info_sources_options_def_group, print_info_sources_header,
1089 info_sources_command_completer):
1090 New functions.
1091 (info_sources_command): Read new optional arguments.
1092 (_initialize_symtab): Update info sources help.
1093
ca683e3a
AO
10942019-08-02 Alexandre Oliva <oliva@adacore.com>
1095
1096 * ada-lang.c (exception_support_info_v0): Renamed from...
1097 (default_exception_support_info): ... this. Create new
1098 definition for v1.
1099 (ada_has_this_exception_support): Look up catch_handlers_sym.
1100 (ada_exception_support_info_sniffer): Try v0 after default.
1101
f1264162
TT
11022019-08-01 Tom Tromey <tromey@adacore.com>
1103
1104 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1105 gdbarch.h.
1106
0a7b2485
CB
11072019-08-01 Christian Biesinger <cbiesinger@google.com>
1108
1109 * s12z-tdep.c: Fix include path for s12z-opc.h.
1110
c6bdbeb7
AH
11112019-08-01 Alan Hayward <alan.hayward@arm.com>
1112
1113 * NEWS: Require GNU make 3.82.
1114
a2bd7b82
TT
11152019-07-16 Tom Tromey <tom@tromey.com>
1116
1117 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1118 declare.
1119
aa3b6533
TT
11202019-07-30 Tom Tromey <tromey@adacore.com>
1121
1122 * block.c (contained_in): Remove BLOCK_FUNCTION check.
1123
a1530dc7
KB
11242019-07-30 Kevin Buettner <kevinb@redhat.com>
1125
1126 * printcmd.c (print_address_symbolic): Print negative offsets.
1127 (build_address_symbolic): Force signed arithmetic when computing
1128 offset.
1129
2906593f
CB
11302019-07-30 Christian Biesinger <cbiesinger@google.com>
1131
1132 PR/24474: Add a function to lookup static variables.
1133 * NEWS: Mention this new function.
1134 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1135 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1136 * python/python.c (python_GdbMethods): Add new function.
1137
c620ed88
CB
11382019-07-29 Christian Biesinger <cbiesinger@google.com>
1139
1140 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1141 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1142 (objfpy_lookup_static_symbol): New function.
1143 (objfile_object_methods): Add new functions.
1144
bc4268a5
PW
11452019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1146
1147 * NEWS: Mention 'set|show print frame-info'. Mention new
1148 'presence' value for 'frame-arguments'. Mention new '-frame-info'
1149 backtrace argument. Mention that python frame filtering code
1150 is now consistent with what 'backtrace' command prints.
1151
4b5e8d19
PW
11522019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1153
1154 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1155 comments.
1156 (print_frame_info_auto, print_frame_info_source_line,
1157 print_frame_info_location, print_frame_info_source_and_location,
1158 print_frame_info_location_and_address, print_frame_info_short_location):
1159 New declarations.
1160 (struct frame_print_options): New member print_frame_info.
1161 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1162 * stack.h (get_user_print_what_frame_info): New declaration.
1163 (frame_show_address): New declaration.
1164 * stack.c (print_frame_arguments_choices): New value 'presence'.
1165 (print_frame_info_auto, print_frame_info_source_line,
1166 print_frame_info_location, print_frame_info_source_and_location,
1167 print_frame_info_location_and_address, print_frame_info_short_location,
1168 print_frame_info_choices, print_frame_info_print_what): New definitions.
1169 (print_frame_args): Only print dots for args if print frame-arguments
1170 is 'presence'.
1171 (frame_print_option_defs): New element for "frame-info".
1172 (get_user_print_what_frame_info): New function.
1173 (frame_show_address): Make non static. Move comment to stack.h.
1174 (print_frame_info_to_print_what): New function.
1175 (print_frame_info): Update comment. Use fp_opts.print_frame_info
1176 to decide what to print.
1177 (backtrace_command_1): Handle the new print_frame_arguments_presence
1178 value.
1179 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1180 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1181 (py_print_frame): In non-mi mode, use LOCATION as default for
1182 print_what, similarly to frame information printed directly by
1183 backtrace command. Handle frame-info user option in non MI mode.
1184
6bdfee81
KB
11852019-07-27 Kevin Buettner <kevinb@redhat.com>
1186
1187 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1188 Add case for debugging 32-bit target on 64-bit host. Revise
1189 comment.
1190
98a617f8
KB
11912019-07-27 Kevin Buettner <kevinb@redhat.com>
1192
1193 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1194 instead of find_function_entry_range_from_pc.
1195
567238c9
KB
11962019-07-27 Kevin Buettner <kevinb@redhat.com>
1197
1198 * stack.c (find_frame_funname): Remove code which preferred
1199 minsym over symtab sym in "certain pathological cases".
1200
2dc80cf8
KB
1201 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1202 parameter. Change type of "do_demangle" to bool.
1203 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1204 Pass suitable "prefer_sym_over_minsym" flag to
1205 build_address_symbolic(). Don't output "+" for negative offsets.
1206 * printcmd.c (print_address_symbolic): Update invocation of
1207 build_address_symbolic to include a "prefer_sym_over_minsym"
1208 flag.
1209 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1210 Restrict cases in which use of minimal symbol is preferred to that
1211 of a found symbol. Update comments.
1212
1aff7173
KB
1213 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1214 for entry pc when entry pc is out of range for that FDE.
1215
89b085ac
BC
12162019-07-26 Brian Callahan <bcallah@openbsd.org>
1217
1218 PR gdb/24839:
1219 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1220 type.
1221
f32feb4a
CB
12222019-07-25 Christian Biesinger <cbiesinger@google.com>
1223
1224 * python/py-objfile.c (add_separate_debug_file): Fix comment about
1225 this function's Python signature.
1226
1227
12282019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB
1229
1230 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1231 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1232 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1233 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1234 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1235
1236
c54e4253
YS
12372019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
1238
1239 * h8300-tdep.c (h8300_register_name_common): New.
1240 h8300_register_name): Use h8300_register_name_common.
1241 (h8300s_register_name): Likewise.
1242 (h8300sx_register_name): Likewise.
1243 (h8300h_register_nam): New.
1244 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1245
1246
40eadf04
SP
12472019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
1248
1249 * arm-tdep.c (arm_skip_cmse_entry): New function.
1250 (arm_is_sgstubs_section): New function.
1251 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1252
bfa2a36d
TT
12532019-07-22 Tom Tromey <tom@tromey.com>
1254
1255 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1256 Don't self-assign.
1257
a8e9d247
AB
12582019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1259
1260 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1261 type_print.
1262
eb86c5e2
AB
12632019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1264
1265 * symtab.c (search_symbols): Adjust msymbol matching type arrays
1266 so that GDB doesn't match any msymbols when searching in the
1267 TYPES_DOMAIN.
1268 (print_symbol_info): Print using typedef_print or type_print based
1269 on the type of the symbol. Add updated FIXME comment moved from...
1270 (_initialize_symtab): ... move and update FIXME comment to above.
1271
a8eab7c6
AB
12722019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
1273
1274 * NEWS: Mention adding -q option to "info types".
1275 * symtab.c (struct info_types_options): New struct.
1276 (info_types_options_defs): New variable.
1277 (make_info_types_options_def_group): New function.
1278 (info_types_command): Use gdb::option framework to parse options.
1279 (info_types_command_completer): New function.
1280 (_initialize_symtab): Extend the help text on "info types" and
1281 register command completer.
1282
b4603c34
CB
12832019-07-21 Christian Biesinger <cbiesinger@google.com>
1284
1285 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1286 (lookup_symbol_in_objfile): Change int to block_enum and add a
1287 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1288
c8cdc1e0
CB
12892019-07-20 Christian Biesinger <cbiesinger@google.com>
1290
1291 * MAINTAINERS (Write After Approval): Add self.
1292
01e175fe
AB
12932019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
1294
1295 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1296 instruction to the dummy code region.
1297
56f79b63
TT
12982019-07-19 Tom Tromey <tromey@adacore.com>
1299
1300 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1301 (ARGSUSED, PARAMS, __func__): Remove rules.
1302
4c5aa8e0
AH
13032019-07-19 Alan Hayward <alan.hayward@arm.com>
1304
1305 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1306 * features/arm/arm-with-iwmmxt.c: Remove.
1307 * features/arm/arm-with-iwmmxt.xml: Remove.
1308 * features/arm/arm-with-m-fpa-layout.c: Remove.
1309 * features/arm/arm-with-m-fpa-layout.xml: Remove.
1310 * features/arm/arm-with-m-vfp-d16.c: Remove.
1311 * features/arm/arm-with-m-vfp-d16.xml: Remove.
1312 * features/arm/arm-with-m.c: Remove.
1313 * features/arm/arm-with-m.xml: Remove.
1314 * features/arm/arm-with-neon.c: Remove.
1315 * features/arm/arm-with-neon.xml: Remove.
1316 * features/arm/arm-with-vfpv2.c: Remove.
1317 * features/arm/arm-with-vfpv2.xml: Remove.
1318 * features/arm/arm-with-vfpv3.c: Remove.
1319 * features/arm/arm-with-vfpv3.xml: Remove.
1320
f42b2617
AH
13212019-07-19 Alan Hayward <alan.hayward@arm.com>
1322
1323 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1324
f29ec966
AH
13252019-07-19 Alan Hayward <alan.hayward@arm.com>
1326
1327 * arch/aarch32.c (aarch32_create_target_description): Create
1328 target descriptions using features.
1329 * arch/arm.c (arm_create_target_description)
1330 (arm_create_mprofile_target_description): Likewise.
1331 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1332
d105cce5
AH
13332019-07-19 Alan Hayward <alan.hayward@arm.com>
1334
1335 * Makefile.in: Add new files.
1336 * aarch32-tdep.c: New file.
1337 * aarch32-tdep.h: New file.
1338 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1339 Call aarch32_read_description.
1340 * arch/aarch32.c: New file.
1341 * arch/aarch32.h: New file.
1342 * arch/arm.c (arm_create_target_description)
1343 (arm_create_mprofile_target_description): New function.
1344 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1345 (arm_create_target_description)
1346 (arm_create_mprofile_target_description): New declaration.
1347 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1348 read_description functions.
1349 * arm-linux-nat.c (arm_linux_nat_target::read_description):
1350 Likewise.
1351 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1352 * arm-tdep.c (tdesc_arm_list): New variable.
1353 (arm_register_g_packet_guesses): Call create description functions.
1354 (arm_read_description) (arm_read_mprofile_description): New
1355 function.
1356 * arm-tdep.h (arm_read_description)
1357 (arm_read_mprofile_description): Add declaration.
1358 * configure.tgt: Add new files.
1359
afe09f0b
GL
13602019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
1361
1362 * top.c (new_ui_command): Open specified terminal just once.
1363
cd215b2e
TT
13642019-07-18 Tom Tromey <tromey@adacore.com>
1365
1366 * symtab.c (main_name): Constify return type.
1367 * symfile.c (set_initial_language): Update.
1368 * symtab.h (main_name): Constify return type.
1369
d8f68fcb
TT
13702019-07-17 Tom Tromey <tom@tromey.com>
1371
1372 * tui/tui-winsource.c (tui_update_source_window)
1373 (tui_update_source_window_as_is)
1374 (tui_update_source_windows_with_line): Remove return.
1375 * tui/tui-disasm.c (tui_show_disassem)
1376 (tui_show_disassem_and_update_source): Remove return.
1377 * tui/tui.c (tui_reset): Remove return.
1378 * tui/tui-wingeneral.c
1379 (tui_check_and_display_highlight_if_needed): Remove return.
1380
ca5af91e
TT
13812019-07-17 Tom Tromey <tom@tromey.com>
1382
1383 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1384
5104fe36
TT
13852019-07-17 Tom Tromey <tom@tromey.com>
1386
1387 * tui/tui-winsource.h (struct tui_exec_info_window)
1388 (struct tui_source_window_base): Move from tui-data.h.
1389 * tui/tui-winsource.c: Move many method definitions from
1390 elsewhere. Remove "structuring" comments.
1391 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1392 (tui_source_window_base::refresh_window): Move to
1393 tui-winsource.c.
1394 * tui/tui-win.c (tui_source_window_base::refresh_all)
1395 (tui_source_window_base::update_tab_width)
1396 (tui_source_window_base::set_new_height)
1397 (tui_source_window_base::do_make_visible_with_new_height): Move to
1398 tui-winsource.c.
1399 * tui/tui-source.h: Update.
1400 * tui/tui-source.c (tui_source_window_base::reset): Move to
1401 tui-winsource.c.
1402 * tui/tui-disasm.h: Update.
1403 * tui/tui-data.h (struct tui_exec_info_window): Move to
1404 tui-winsource.h.
1405 (struct tui_source_window_base): Likewise.
1406 * tui/tui-data.c (tui_source_window_base::clear_detail)
1407 (tui_source_window_base, ~tui_source_window_base): Move to
1408 tui-winsource.c.
1409
daa15dde
TT
14102019-07-17 Tom Tromey <tom@tromey.com>
1411
1412 * tui/tui-win.c (tui_resize_all)
1413 (tui_source_window_base::update_tab_width)
1414 (tui_adjust_win_heights): Update.
1415 (tui_win_info::make_invisible_and_set_new_height): Rename from
1416 make_invisible_and_set_new_height.
1417 * tui/tui-data.h (struct tui_win_info)
1418 <make_invisible_and_set_new_height>: New method.
1419
bfad4537
TT
14202019-07-17 Tom Tromey <tom@tromey.com>
1421
1422 * tui/tui.c: Update.
1423 * tui/tui-source.h (struct tui_source_window): Move from
1424 tui-data.h.
1425 * tui/tui-layout.c: Update.
1426 * tui/tui-disasm.c: Update.
1427 * tui/tui-data.h (struct tui_source_window): Move to
1428 tui-source.h.
1429
88f7e873
TT
14302019-07-17 Tom Tromey <tom@tromey.com>
1431
1432 * tui/tui-disasm.h (struct tui_disasm_window): Move from
1433 tui-data.h.
1434 * tui/tui-data.h (struct tui_disasm_window): Move to
1435 tui-disasm.h.
1436
96bd6233
TT
14372019-07-17 Tom Tromey <tom@tromey.com>
1438
1439 * tui/tui-regs.h (struct tui_data_item_window): Move from
1440 tui-data.h.
1441 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1442 * tui/tui-data.h (struct tui_data_item_window): Move to
1443 tui-regs.h.
1444 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1445
ce38393b
TT
14462019-07-17 Tom Tromey <tom@tromey.com>
1447
1448 * tui/tui.c: Update.
1449 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1450 (tui_cmd_window::max_height): Move to tui-command.c.
1451 * tui/tui-layout.c: Update.
1452 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1453 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1454 tui-command.c.
1455 * tui/tui-command.h (struct tui_cmd_window): Move from
1456 tui-data.h.
1457 * tui/tui-command.c: Remove "structuring" comments.
1458 (tui_cmd_window::clear_detail)
1459 (tui_cmd_window::do_make_visible_with_new_height)
1460 (tui_cmd_window::max_height): Move from elsewhere.
1461
2d8b51cb
TT
14622019-07-17 Tom Tromey <tom@tromey.com>
1463
1464 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1465 Now static.
1466 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1467 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1468
18ab23af
TT
14692019-07-17 Tom Tromey <tom@tromey.com>
1470
1471 * tui/tui.c: Update.
1472 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1473 tui-regs.c.
1474 * tui/tui-windata.h: Remove file.
1475 * tui/tui-windata.c: Remove file.
1476 * tui/tui-win.c (tui_data_window::set_new_height)
1477 (tui_data_window::do_make_visible_with_new_height): Move to
1478 tui-regs.c.
1479 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
1480 * tui/tui-regs.c: Remove "structuring" comments.
1481 (tui_data_window::first_data_item_displayed)
1482 (tui_data_window::delete_data_content_windows)
1483 (tui_data_window::erase_data_content)
1484 (tui_data_window::display_all_data)
1485 (tui_data_window::refresh_all)
1486 (tui_data_window::do_scroll_vertical)
1487 (tui_data_window::clear_detail, tui_data_window::set_new_height)
1488 (tui_data_window::do_make_visible_with_new_height)
1489 (tui_data_window::refresh_window): Move from elsewhere.
1490 (_initialize_tui_regs): Move to end of file.
1491 * tui/tui-layout.c: Update.
1492 * tui/tui-hooks.c: Update.
1493 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
1494 * tui/tui-data.c (tui_data_window::clear_detail): Move to
1495 tui-regs.c.
1496 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
1497
88b7e7cc
TT
14982019-07-17 Tom Tromey <tom@tromey.com>
1499
1500 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
1501 seen.
1502
0fcd3711
TT
15032019-07-17 Tom Tromey <tom@tromey.com>
1504
1505 * tui/tui-win.c (tui_source_window_base::set_new_height)
1506 (tui_source_window_base::do_make_visible_with_new_height): Use
1507 m_has_locator field directly.
1508 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
1509 method.
1510 (struct tui_source_window_base) <has_locator>: Likewise.
1511
4a38112d
TT
15122019-07-17 Tom Tromey <tom@tromey.com>
1513
1514 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
1515 Don't declare.
1516 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
1517 Remove.
1518 * tui/tui-win.c (tui_source_window_base::set_new_height)
1519 (tui_source_window_base::set_new_height)
1520 (make_invisible_and_set_new_height)
1521 (tui_source_window_base::do_make_visible_with_new_height)
1522 (tui_source_window_base::do_make_visible_with_new_height):
1523 Update.
1524 * tui/tui-layout.c (show_source_disasm_command, show_data)
1525 (show_source_or_disasm_and_command): Update.
1526 * tui/tui-layout.c (show_layout): Update.
1527
09129226
TT
15282019-07-17 Tom Tromey <tom@tromey.com>
1529
1530 * tui/tui-layout.c (make_data_window): Remove.
1531 (show_data): Unify creation and re-initialization cases.
1532
4a8a5e84
TT
15332019-07-17 Tom Tromey <tom@tromey.com>
1534
1535 * tui/tui-layout.c (make_source_window, make_disasm_window):
1536 Remove.
1537 (show_data): Unify creation and re-initialization cases.
1538
76d2be8e
TT
15392019-07-17 Tom Tromey <tom@tromey.com>
1540
1541 * tui/tui-layout.c (make_command_window): Remove.
1542 (show_source_disasm_command, show_source_or_disasm_and_command):
1543 Unify creation and re-initialization cases.
1544
890b8bde
TT
15452019-07-17 Tom Tromey <tom@tromey.com>
1546
1547 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
1548 creation and re-initialization cases.
1549
2cdfa113
TT
15502019-07-17 Tom Tromey <tom@tromey.com>
1551
1552 * tui/tui-regs.c (tui_get_register): Return void.
1553
8e3cfd09
TT
15542019-07-17 Tom Tromey <tom@tromey.com>
1555
1556 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
1557 Simplify.
1558
f4e04977
TT
15592019-07-17 Tom Tromey <tom@tromey.com>
1560
1561 * tui/tui-layout.c (show_source_disasm_command): Simplify window
1562 resetting.
1563
0379b883
TT
15642019-07-17 Tom Tromey <tom@tromey.com>
1565
1566 * tui/tui.h (tui_set_layout_by_name): Don't declare.
1567 * tui/tui-regs.c (tui_reg_layout): New function.
1568 (tui_show_registers, tui_reg_command): Use it.
1569 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
1570 (tui_layout_command): Rename from tui_set_layout_by_name. Change
1571 parameters.
1572 (tui_layout_command): Remove.
1573
b7fbad91
TT
15742019-07-17 Tom Tromey <tom@tromey.com>
1575
1576 * tui/tui-layout.h (tui/tui-layout): Return void.
1577 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
1578
4e1e56b9
TT
15792019-07-17 Tom Tromey <tom@tromey.com>
1580
1581 * tui/tui-layout.c (show_source_disasm_command, show_data):
1582 Update.
1583 (reset_locator): Remove.
1584 (show_source_or_disasm_and_command): Update.
1585
1e0c09ba
TT
15862019-07-17 Tom Tromey <tom@tromey.com>
1587
1588 * tui/tui-source.c (tui_source_window_base::reset): Remove
1589 win_type parameter.
1590 * tui/tui-layout.c (make_command_window, make_source_window)
1591 (make_disasm_window, make_data_window)
1592 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
1593 (reset_locator, show_source_or_disasm_and_command): Update.
1594 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
1595 win_type parameter.
1596 (struct tui_source_window_base) <reset>: Likewise.
1597
1bf605de
TT
15982019-07-17 Tom Tromey <tom@tromey.com>
1599
1600 * tui/tui-layout.c (show_source_disasm_command): Use
1601 reset_locator.
1602 (reset_locator): New function.
1603 (init_and_make_win): Remove.
1604 (show_source_or_disasm_and_command): Use reset_locator.
1605
098f9ed4
TT
16062019-07-17 Tom Tromey <tom@tromey.com>
1607
1608 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
1609 condition.
1610 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
1611 Remove condition.
1612 * tui/tui-source.c (tui_source_window_base::reset): New method.
1613 * tui/tui-layout.c (make_command_window): Don't call
1614 init_and_make_win.
1615 (make_source_window, make_disasm_window): Don't call
1616 make_source_or_disasm_window.
1617 (make_data_window): Don't call init_and_make_win. Change calling
1618 convention.
1619 (show_source_disasm_command, show_data): Simplify.
1620 (make_source_or_disasm_window): Remove.
1621 (show_source_or_disasm_and_command): Simplify.
1622 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
1623 (struct tui_source_window_base) <reset>: Likewise.
1624 <execution_info>: Remove initializer.
1625 * tui/tui-data.c (tui_source_window_base): Initialize
1626 execution_info.
1627
80110957
TT
16282019-07-17 Tom Tromey <tom@tromey.com>
1629
1630 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
1631 variable.
1632
cf82af05
TT
16332019-07-17 Tom Tromey <tom@tromey.com>
1634
1635 * tui/tui.c (tui_rl_other_window): Update.
1636 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
1637 superclass method first. Always iterate over regs_content.
1638 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
1639 method.
1640 * tui/tui-win.c (tui_set_focus_command): Update.
1641
01aeb396
TT
16422019-07-17 Tom Tromey <tom@tromey.com>
1643
1644 * tui/tui-win.c (tui_set_focus_command): Rename from
1645 tui_set_focus. Call tui_enable.
1646 (tui_set_focus_command): Remove.
1647
fd6c75ee
TT
16482019-07-17 Tom Tromey <tom@tromey.com>
1649
1650 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
1651 refresh_window.
1652 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
1653 touchwin.
1654 (tui_data_window::refresh_window): Call refresh_window on data
1655 items. Always call superclass refresh_window.
1656 (tui_win_info::refresh): Remove.
1657 (tui_source_window_base::refresh_window): Update.
1658 (tui_refresh_all): Update.
1659 * tui/tui-layout.c (show_source_disasm_command): Remove call to
1660 refresh_window.
1661 (show_source_or_disasm_and_command): Likewise.
1662 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
1663 (struct tui_source_window_base) <refresh>: Likewise.
1664
f6cc34a9
TT
16652019-07-17 Tom Tromey <tom@tromey.com>
1666
1667 * tui/tui-winsource.c (tui_clear_source_content)
1668 (tui_show_source_content): Update.
1669 * tui/tui-source.c (tui_source_window::showing_source_p): Check
1670 whether content is empty.
1671 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
1672 Remove.
1673
f31ec9af
TT
16742019-07-17 Tom Tromey <tom@tromey.com>
1675
1676 * tui/tui-winsource.c (tui_erase_source_content): Clear the
1677 window's contents.
1678 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
1679 * tui/tui-source.c (tui_set_source_content_nil): Remove.
1680
d1b6f1e5
TT
16812019-07-17 Tom Tromey <tom@tromey.com>
1682
1683 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
1684 (struct tui_data_item_window): Update.
1685
d9743a13
TT
16862019-07-17 Tom Tromey <tom@tromey.com>
1687
1688 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
1689 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
1690 defines.
1691
caf0bc4e
TT
16922019-07-17 Tom Tromey <tom@tromey.com>
1693
1694 * tui/tui-winsource.h (tui_erase_source_content)
1695 (tui_clear_source_content): Remove "display_prompt" parameter.
1696 * tui/tui-winsource.c (tui_update_source_window_as_is)
1697 (tui_update_source_windows_with_addr): Update.
1698 (tui_clear_source_content): Remove "display_prompt" parameter.
1699 (tui_erase_source_content): Likewise. Simplify.
1700 (tui_show_source_content): Update.
1701 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1702 * tui/tui-stack.c (tui_show_frame_info): Update.
1703 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
1704 Remove defines.
1705
9d391078
TT
17062019-07-17 Tom Tromey <tom@tromey.com>
1707
1708 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1709 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
1710 parameter.
1711 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
1712 parameter.
1713
a38da35d
TT
17142019-07-17 Tom Tromey <tom@tromey.com>
1715
1716 * tui/tui-winsource.c (tui_clear_source_content)
1717 (tui_show_source_content, tui_show_exec_info_content)
1718 (tui_clear_exec_info_content): Update.
1719 * tui/tui-stack.c (tui_show_locator_content): Update.
1720 (tui_show_frame_info): Update.
1721 * tui/tui-source.h (tui_source_window): Don't declare.
1722 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
1723 from tui_source_is_displayed.
1724 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
1725 Remove field.
1726 (struct tui_source_window_base) <content_in_use>: New field. Now
1727 bool.
1728 (struct tui_source_window) <showing_source_p>: New method.
1729 (TUI_SRC_WIN): Change cast.
1730 * tui/tui-data.c (tui_initialize_static_data): Update.
1731
c2cd8994
TT
17322019-07-17 Tom Tromey <tom@tromey.com>
1733
1734 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
1735 location_matches_p.
1736 * tui/tui-source.c (tui_source_window::location_matches_p): New
1737 method.
1738 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
1739 method.
1740 * tui/tui-data.h (struct tui_source_window_base)
1741 <location_matches_p>: New method.
1742 (struct tui_source_window, struct tui_disasm_window)
1743 <location_matches_p>: Likewise.
1744
4dde7b34
TT
17452019-07-17 Tom Tromey <tom@tromey.com>
1746
1747 * tui/tui-win.c (tui_set_win_height_command): Rename from
1748 tui_set_win_height.
1749 (tui_set_win_height_command): Remove.
1750
b73dd877
TT
17512019-07-17 Tom Tromey <tom@tromey.com>
1752
1753 * tui/tui-source.c (tui_source_window): New constructor. Add
1754 observer.
1755 (~tui_source_window): New destructor.
1756 (tui_source_window::style_changed): New method.
1757 * tui/tui-hooks.c (tui_redisplay_source): Remove.
1758 (tui_attach_detach_observers): Update.
1759 * tui/tui-data.h (struct tui_source_window): Make constructor not
1760 inline. Add destructor.
1761 (struct tui_source_window) <style_changed>: New method.
1762 <m_observable>: New member.
1763
ae2b5380
TT
17642019-07-17 Tom Tromey <tom@tromey.com>
1765
1766 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
1767 * tui/tui-win.c (tui_resize_all): Fix typo.
1768
1ce3e844
TT
17692019-07-17 Tom Tromey <tom@tromey.com>
1770
1771 * tui/tui-wingeneral.h (tui_refresh_all): Update.
1772 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
1773 (tui_refresh_all): Remove "list" parameter. Use foreach.
1774 * tui/tui-win.c (window_name_completer): Use foreach.
1775 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
1776 (update_tab_width): Likewise.
1777 * tui/tui-layout.c (show_layout): Update.
1778 * tui/tui-data.h (class tui_window_iterator): New.
1779 (struct all_tui_windows): New.
1780 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
1781
fe3eaf1c
TT
17822019-07-17 Tom Tromey <tom@tromey.com>
1783
1784 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
1785 parameter. Don't reference globals.
1786 (tui_reg_command): Update.
1787
368c1354
TT
17882019-07-17 Tom Tromey <tom@tromey.com>
1789
1790 * tui/tui-regs.c (tui_show_registers): Simplify.
1791
e80cd204
TT
17922019-07-17 Tom Tromey <tom@tromey.com>
1793
1794 * tui/tui-regs.c (tui_show_registers): Update.
1795 (tui_show_register_group): Add win_info parameter.
1796
aca2dd16
TT
17972019-07-17 Tom Tromey <tom@tromey.com>
1798
1799 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
1800 Rename from tui_display_reg_element_at_line.
1801 (tui_data_window::display_registers_from_line): Update.
1802 * tui/tui-data.h (struct tui_data_window)
1803 <display_reg_element_at_line>: New method.
1804
517e9505
TT
18052019-07-17 Tom Tromey <tom@tromey.com>
1806
1807 * tui/tui-regs.h (tui_display_registers_from)
1808 (tui_display_registers_from_line): Don't declare.
1809 * tui/tui-windata.c (tui_data_window::display_all_data)
1810 (tui_data_window::refresh_all)
1811 (tui_data_window::do_scroll_vertical): Update.
1812 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
1813 from tui_display_registers_from.
1814 (tui_display_reg_element_at_line): Update.
1815 (tui_data_window::display_registers_from_line): Rename from
1816 tui_display_registers_from_line.
1817 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
1818 display_registers_from_line>: New methods.
1819
f76d8b19
TT
18202019-07-17 Tom Tromey <tom@tromey.com>
1821
1822 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
1823 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
1824 from tui_erase_data_content.
1825 (tui_data_window::display_all_data)
1826 (tui_data_window::refresh_all)
1827 (tui_data_window::do_scroll_vertical): Update.
1828 * tui/tui-regs.c (tui_show_registers): Update.
1829 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
1830 New method.
1831
b4094625
TT
18322019-07-17 Tom Tromey <tom@tromey.com>
1833
1834 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
1835 declare.
1836 * tui/tui-windata.c
1837 (tui_data_window::delete_data_content_windows): Rename from
1838 tui_delete_data_content_windows.
1839 (tui_data_window::display_all_data)
1840 (tui_data_window::do_scroll_vertical): Update.
1841 * tui/tui-data.h (struct tui_data_window)
1842 <delete_data_content_windows>: New method.
1843
c223a729
TT
18442019-07-17 Tom Tromey <tom@tromey.com>
1845
1846 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
1847 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
1848
50daf268
TT
18492019-07-17 Tom Tromey <tom@tromey.com>
1850
1851 * tui/tui-windata.h (tui_display_all_data): Don't declare.
1852 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
1853 from tui_display_all_data.
1854 * tui/tui-win.c
1855 (tui_data_window::do_make_visible_with_new_height): Update.
1856 * tui/tui-regs.c (tui_show_registers): Update.
1857 * tui/tui-layout.c (tui_set_layout): Update.
1858 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
1859 method.
1860
df5f8cab
TT
18612019-07-17 Tom Tromey <tom@tromey.com>
1862
1863 * tui/tui-windata.h (tui_display_data_from): Don't declare.
1864 * tui/tui-windata.c (tui_display_data_from): Remove.
1865 (tui_data_window::refresh_all): Update.
1866
80cb6c27
TT
18672019-07-17 Tom Tromey <tom@tromey.com>
1868
1869 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
1870 * tui/tui-windata.c (tui_display_data_from_line): Remove.
1871 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
1872 tui_display_registers_from_line.
1873 * tui/tui-regs.h (tui_display_registers_from_line): Update.
1874 * tui/tui-regs.c (tui_display_registers_from_line): Remove
1875 "force_display" parameter.
1876
baff0c28
TT
18772019-07-17 Tom Tromey <tom@tromey.com>
1878
1879 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
1880 declare.
1881 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
1882 Rename from tui_first_reg_element_no_inline.
1883 (tui_display_reg_element_at_line)
1884 (tui_display_registers_from_line): Update.
1885 * tui/tui-data.h (struct tui_data_window)
1886 <first_reg_element_no_inline>: New method.
1887
3b23c5f2
TT
18882019-07-17 Tom Tromey <tom@tromey.com>
1889
1890 * tui/tui-windata.c (tui_display_data_from)
1891 (tui_data_window::do_scroll_vertical): Update.
1892 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
1893 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
1894 Rename from tui_line_from_reg_element_no.
1895 (tui_display_registers_from_line): Update.
1896 * tui/tui-data.h (struct tui_data_window)
1897 <line_from_reg_element_no>: New method.
1898
0b5ec218
TT
18992019-07-17 Tom Tromey <tom@tromey.com>
1900
1901 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
1902 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
1903 tui_last_regs_line_no.
1904 (tui_display_reg_element_at_line)
1905 (tui_display_registers_from_line): Update.
1906 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
1907 method.
1908
0807ab7b
TT
19092019-07-17 Tom Tromey <tom@tromey.com>
1910
1911 PR tui/24722:
1912 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
1913 (tui_update_breakpoint_info): Add "being_deleted" parameter.
1914 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1915 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
1916 (tui_update_breakpoint_info): Likewise.
1917 * tui/tui-hooks.c (tui_event_create_breakpoint)
1918 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
1919 Update.
1920
9ad7fdef
TT
19212019-07-17 Tom Tromey <tom@tromey.com>
1922
1923 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
1924
5813316f
TT
19252019-07-17 Tom Tromey <tom@tromey.com>
1926
1927 * tui/tui-winsource.c (tui_update_source_window_as_is)
1928 (tui_update_source_windows_with_addr): Update.
1929 * tui/tui-source.h (tui_set_source_content)
1930 (tui_show_symtab_source): Add "win_info" parameter.
1931 * tui/tui-source.c (tui_set_source_content): Add "win_info"
1932 parameter.
1933 (tui_show_symtab_source): Likewise.
1934
00e264e7
TT
19352019-07-17 Tom Tromey <tom@tromey.com>
1936
1937 * tui/tui-wingeneral.c
1938 (tui_check_and_display_highlight_if_needed): Check can_highlight.
1939
06210ce4
TT
19402019-07-17 Tom Tromey <tom@tromey.com>
1941
1942 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
1943 (struct tui_cmd_window) <can_scroll>: New method.
1944 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
1945 method.
1946
381befee
TT
19472019-07-17 Tom Tromey <tromey@adacore.com>
1948
1949 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
1950 do_field_signed>: Rename. Change type of "value".
1951 * ui-out.c (ui_out::field_signed): Rename from field_int.
1952 Change type of "value".
1953 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
1954 type of "value".
1955 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
1956 do_field_int. Change type of "value".
1957 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
1958 do_field_int. Change type of "value".
1959 * tracepoint.c (trace_status_mi, tfind_1)
1960 (print_one_static_tracepoint_marker): Update.
1961 * thread.c (print_thread_info_1, print_selected_thread_frame):
1962 Update.
1963 * stack.c (print_frame, print_frame_info): Update.
1964 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
1965 Update.
1966 * source.c (print_source_lines_base): Update.
1967 * skip.c (info_skip_command): Update.
1968 * record-btrace.c (btrace_ui_out_decode_error)
1969 (btrace_call_history_src_line): Update.
1970 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
1971 Update.
1972 * progspace.c (print_program_space): Update.
1973 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
1974 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
1975 do_field_int. Change type of "value".
1976 * mi/mi-out.c (mi_ui_out::do_table_begin)
1977 (mi_ui_out::do_table_header): Update.
1978 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
1979 type of "value".
1980 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
1981 (mi_cmd_data_list_changed_registers, output_register)
1982 (mi_cmd_data_read_memory, mi_load_progress)
1983 (mi_cmd_trace_frame_collected): Update.
1984 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
1985 Update.
1986 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
1987 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
1988 (mi_cmd_var_list_children, varobj_update_one): Update.
1989 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
1990 (mi_cmd_stack_list_args, list_arg_or_local): Update.
1991 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
1992 * inferior.c (print_inferior): Update.
1993 * gdb_bfd.c (print_one_bfd): Update.
1994 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1995 Update.
1996 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
1997 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
1998 do_field_int. Change type of "value".
1999 * cli-out.c (cli_ui_out::do_field_signed): Rename from
2000 do_field_int. Change type of "value".
2001 * breakpoint.c (watchpoint_check, print_breakpoint_location)
2002 (print_one_breakpoint_location, print_it_catch_fork)
2003 (print_one_catch_fork, print_it_catch_vfork)
2004 (print_one_catch_vfork, print_it_catch_solib)
2005 (print_it_catch_exec, print_it_ranged_breakpoint)
2006 (print_mention_watchpoint, print_mention_masked_watchpoint)
2007 (bkpt_print_it, update_static_tracepoint): Update.
2008 * break-catch-throw.c (print_it_exception_catchpoint): Update.
2009 * break-catch-syscall.c (print_it_catch_syscall): Update.
2010 * ada-tasks.c (print_ada_task_info): Update.
2011 * ada-lang.c (print_it_exception, print_mention_exception):
2012 Update.
2013
6b78c3f8
AB
20142019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
2015
2016 PR breakpoints/24541
2017 * gdbarch.c: Regenerate.
2018 * gdbarch.h: Regenerate.
2019 * gdbarch.sh: Adjust return type and parameter types for
2020 'stap_adjust_register'.
2021 (i386_stap_adjust_register): Adjust signature and return new
2022 register name.
2023 * stap-probe.c (stap_parse_register_operand): Adjust use of
2024 'gdbarch_stap_adjust_register'.
2025
d72a9b85
TT
20262019-07-17 Tom Tromey <tromey@adacore.com>
2027
2028 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
2029 declare VEC.
2030 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2031 std::vector.
2032 (struct s390_process_info): Add initializers.
2033 (s390_add_process): Use new.
2034 (s390_linux_nat_target::low_forget_process): Use delete.
2035 (s390_linux_nat_target::low_new_fork)
2036 (s390_linux_nat_target::stopped_by_watchpoint)
2037 (s390_linux_nat_target::low_prepare_to_resume)
2038 (s390_linux_nat_target::insert_watchpoint)
2039 (s390_linux_nat_target::insert_hw_breakpoint)
2040 (s390_linux_nat_target::remove_watchpoint)
2041 (s390_linux_nat_target::remove_hw_breakpoint): Update.
2042
206e6c58
JB
20432019-07-16 John Baldwin <jhb@FreeBSD.org>
2044
2045 * aarch64-fbsd-nat.c: Include regcache.h.
2046 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2047 argument.
2048 (aarch64_fbsd_nat_target::fetch_registers)
2049 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2050 variable.
2051 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2052
cbde90f2
JB
20532019-07-16 John Baldwin <jhb@FreeBSD.org>
2054
2055 * fbsd-nat.c: Include gdbarch.h.
2056
07128006
TT
20572019-07-15 Tom Tromey <tromey@adacore.com>
2058
2059 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2060
1f77b012
TT
20612019-07-15 Tom Tromey <tromey@adacore.com>
2062
2063 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2064 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2065 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2066 * cli-out.c (cli_ui_out::do_field_int): New method.
2067 * ui-out.c (ui_out::field_unsigned): New method.
2068 * symfile.c (generic_load): Use field_unsigned.
2069 (print_transfer_performance): Likewise.
2070 * record-btrace.c (ui_out_field_uint): Remove.
2071 (btrace_call_history_insn_range, btrace_call_history): Use
2072 field_unsigned.
2073 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2074 field_unsigned.
2075 * ui-out.h (class ui_out) <field_unsigned>: New method.
2076 <do_field_unsigned>: Likewise.
2077
33eca680
TT
20782019-07-15 Tom Tromey <tromey@adacore.com>
2079
2080 * mi/mi-main.c (list_available_thread_groups): Use field_string.
2081 * mi/mi-interp.c (mi_memory_changed): Use field_string.
2082 * target.c (flash_erase_command): Use field_string.
2083 * infrun.c (print_signal_received_reason): Use field_string.
2084 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2085 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2086 field_string.
2087 * ada-tasks.c (print_ada_task_info): Use field_string.
2088
ca8d69be
TT
20892019-07-15 Tom Tromey <tromey@adacore.com>
2090
2091 * target.c (flash_erase_command): Use field_core_addr.
2092 * symfile.c (generic_load): Use field_core_addr.
2093 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2094 Use field_core_addr.
2095 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2096 field_core_addr.
2097
0d4e84ed
AB
20982019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2099
2100 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2101 value if its desired type is smaller than a CORE_ADDR and signed.
2102
9a49df9d
AB
21032019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2104
2105 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2106 of changes to field names, and use new is_reference field to
2107 decide if a property is a reference or not.
2108 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2109 field.
2110 (struct dwarf2_property_baton): Update header comment, rename
2111 'referenced_type' to 'property_type' and update comments.
2112 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2113 default property type, store in property baton, update to take
2114 accound of renamed field.
2115 (read_func_scope): Update call to attr_to_dynamic_prop.
2116 (read_array_type): Likewise.
2117 (dwarf2_per_cu_addr_sized_int_type): New function.
2118 (read_subrange_index_type): Move type finding code to
2119 dwarf2_per_cu_addr_sized_int_type.
2120 (read_subrange_type): Update calls to attr_to_dynamic_prop.
2121 (dwarf2_per_cu_addr_type): New function.
2122 (set_die_type): Update calls to attr_to_dynamic_prop.
2123
b86352cf
AB
21242019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2125
2126 * dwarf2read.c (read_subrange_index_type): New function.
2127 (read_subrange_type): Move code into new function and call it.
2128 * gdbtypes.c (create_range_type): Add some asserts.
2129
603490bf
AB
21302019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2131
2132 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2133 update return statements.
2134 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2135 declaration, and update comment to match.
2136 * gdbtypes.c (resolve_dynamic_array): Update call to
2137 dwarf2_evaluate_property to match new return type.
2138
592f9d27
AB
21392019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
2140
2141 * valarith.c (value_subscripted_rvalue): Change lowerbound
2142 parameter type from int to LONGEST.
2143 * value.h (value_subscripted_rvalue): Likewise in declaration.
2144
60cfcb20
AB
21452019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2146
2147 * cli/cli-utils.c (info_print_command_completer): New function.
2148 * cli/cli-utils.h: Add 'completer.h' include, and forward
2149 declaration for 'struct cmd_list_element'.
2150 (info_print_command_completer): Declare.
2151 * stack.c (_initialize_stack): Add completer for 'info locals' and
2152 'info args'.
2153 * symtab.c (_initialize_symtab): Add completer for 'info
2154 variables' and 'info functions'.
2155 * NEWS: Mention completion for additional info commands.
2156
b16507e0
AB
21572019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2158
2159 * cli/cli-utils.c (extract_info_print_args): Delete.
2160 (extract_arg_maybe_quoted): Delete.
2161 (info_print_options_defs): New variable.
2162 (make_info_print_options_def_group): New function.
2163 (extract_info_print_options): Define new function.
2164 * cli/cli-utils.h (extract_info_print_args): Delete.
2165 (struct info_print_options): New structure.
2166 (extract_info_print_options): Declare new function.
2167 * stack.c (info_locals_command): Update to use new
2168 extract_info_print_options, also add a header comment.
2169 (info_args_command): Likewise.
2170 * symtab.c (info_variables_command): Likewise.
2171 (info_functions_command): Likewise.
2172
021d8588
AB
21732019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
2174
2175 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2176 to extract string arguments.
2177 * common/common-utils.c (extract_string_maybe_quoted): New function.
2178 * common/common-utils.h (extract_string_maybe_quoted): Declare.
2179
b777eb6d
TT
21802019-07-11 Tom Tromey <tromey@adacore.com>
2181
2182 * main.c (get_init_files): Use GDBINIT, not gdbinit.
2183 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2184 * top.h (gdbinit): Don't declare.
2185 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2186 into...
2187 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
2188 * top.c (gdb_init): Don't call init_cli_cmds.
2189 (gdbinit): Remove.
2190 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2191
72ee03ff
TT
21922019-07-11 Tom Tromey <tromey@adacore.com>
2193
2194 * python/py-inferior.c (add_thread_object): Don't use thread_obj
2195 after it has been moved.
2196
00db9531
SM
21972019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2198
2199 * valops.c (value_must_coerce_to_target): Change return type to
2200 bool.
2201 * value.h (value_must_coerce_to_target): Likewise.
2202
f2478a7e
SM
22032019-07-10 Simon Marchi <simon.marchi@efficios.com>
2204
2205 * breakpoint.c (is_hardware_watchpoint): Remove
2206 forward-declaration.
2207 (is_masked_watchpoint): Change return type to bool.
2208 (is_tracepoint): Likewise.
2209 (is_breakpoint): Likewise.
2210 (is_hardware_watchpoint): Likewise.
2211 (is_watchpoint): Likewise.
2212 (is_no_memory_software_watchpoint): Likewise.
2213 (is_catchpoint): Likewise.
2214 (breakpoint_1): Make FILTER parameter's return type bool.
2215 is_masked_watchpoint): Change return type to bool.
2216 (save_breakpoints): Make FILTER parameter's return type bool.
2217 * breakpoint.h (is_breakpoint): Change return type to bool.
2218 (is_watchpoint): Likewise.
2219 (is_catchpoint): Likewise.
2220 (is_tracepoint): Likewise.
2221
0d12e84c
TT
22222019-07-10 Tom Tromey <tom@tromey.com>
2223
2224 * defs.h: Don't include gdbarch.h.
2225 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2226 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2227 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2228 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2229 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2230 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2231 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2232 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2233 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2234 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2235 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2236 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2237 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2238 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2239 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2240 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2241 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2242 record-btrace.c, record.h, regcache-dump.c, regcache.h,
2243 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2244 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2245 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2246 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2247 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2248 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2249 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2250 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2251 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2252
f06f1252
TT
22532019-07-10 Tom Tromey <tromey@adacore.com>
2254
2255 * ada-lang.h (is_ada_exception_catchpoint): Declare.
2256 * breakpoint.c (init_ada_exception_breakpoint): Register as
2257 bp_catchpoint.
2258 (print_one_breakpoint_location, print_one_breakpoint): Use
2259 is_ada_exception_catchpoint.
2260 * ada-lang.c (class ada_catchpoint_location): Pass
2261 bp_loc_software_breakpoint to bp_location constructor.
2262 (is_ada_exception_catchpoint): New function.
2263
7a5d944b
TT
22642019-07-10 Tom Tromey <tromey@adacore.com>
2265
2266 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
2267 VEC.
2268 (struct arm_exidx_entry): New method operator<.
2269 (struct arm_exidx_data) <section_maps>: Change type.
2270 (arm_exidx_data_free): Remove.
2271 (arm_exidx_data_key): Change type. Move lower.
2272 (arm_exidx_new_objfile): Update.
2273 (arm_compare_exidx_entries): Remove.
2274 (arm_find_exidx_entry, _initialize_arm_tdep)
2275
48c66e1d
TT
22762019-07-10 Tom Tromey <tromey@adacore.com>
2277
2278 * solib-spu.c (ocl_program_data_key): Change type.
2279 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2280 Update.
2281
a269fbf1
TT
22822019-07-10 Tom Tromey <tromey@adacore.com>
2283
2284 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
2285 (struct solib_aix_inferior_data) <library_list>: Change type.
2286 (solib_aix_inferior_data_handle): Change type.
2287 (get_solib_aix_inferior_data): Update.
2288 (solib_aix_free_library_list): Remove.
2289 (library_list_start_library): Update.
2290 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2291 return type.
2292 (solib_aix_get_library_list)
2293 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2294 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2295
c294730c
TT
22962019-07-10 Tom Tromey <tromey@adacore.com>
2297
2298 * solib-dsbt.c (struct dsbt_info): Add initializers.
2299 (solib_dsbt_pspace_data): Change type.
2300 (dsbt_pspace_data_cleanup): Remove.
2301 (get_dsbt_info, _initialize_dsbt_solib): Update.
2302
9d52077d
TT
23032019-07-10 Tom Tromey <tromey@adacore.com>
2304
2305 * spu-tdep.c (spu_overlay_data): Change type.
2306 (spu_get_overlay_table, spu_overlay_new_objfile)
2307 (_initialize_spu_tdep): Update.
2308
22a20dca
TT
23092019-07-10 Tom Tromey <tromey@adacore.com>
2310
2311 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2312 destructor.
2313 (dbx_objfile_data_key): Change type and declare later.
2314 (DBX_SYMFILE_INFO): Rewrite.
2315 * dbxread.c (dbx_objfile_data_key): Change type.
2316 (dbx_symfile_init): Update.
2317 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
2318 (coffstab_build_psymtabs, elfstab_build_psymtabs)
2319 (stabsect_build_psymtabs, _initialize_dbxread): Update.
2320
cb60f420
TT
23212019-07-10 Tom Tromey <tromey@adacore.com>
2322
2323 * jit.c (jit_program_space_key): Change type. Move lower.
2324 (get_jit_program_space_data): Update.
2325 (jit_program_space_data_cleanup): Remove.
2326 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2327 Update.
2328 (struct jit_program_space_data): Add initializers.
2329
51df2ae3
TT
23302019-07-10 Tom Tromey <tromey@adacore.com>
2331
2332 * solib-darwin.c (struct darwin_info): Add initializers.
2333 (solib_darwin_pspace_data): Change type.
2334 (darwin_pspace_data_cleanup): Remove.
2335 (get_darwin_info, _initialize_darwin_solib): Update.
2336
18101a35
TT
23372019-07-10 Tom Tromey <tromey@adacore.com>
2338
2339 * remote-sim.c (struct sim_inferior_data): Add initializers,
2340 constructor, and destructor.
2341 (sim_inferior_data_key): Change type. Move lower.
2342 (check_for_duplicate_sim_descriptor): Update.
2343 (get_sim_inferior_data): Use new. Update.
2344 (~sim_inferior_data_cleanup): Rename from
2345 sim_inferior_data_cleanup. Simplify.
2346 (gdbsim_close_inferior, simulator_command)
2347 (sim_command_completer, _initialize_remote_sim): Update.
2348 (next_pid, INITIAL_PID): Move earlier.
2349
05b08ac1
TT
23502019-07-10 Tom Tromey <tromey@adacore.com>
2351
2352 * python/python-internal.h (create_thread_object): Return
2353 gdbpy_ref.
2354 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2355 * python/py-inferior.c (struct threadlist_entry): Add
2356 constructor.
2357 <thread_obj>: Now a gdbpy_ref.
2358 (thread_to_thread_object): Update.
2359 (add_thread_object): Use new.
2360 (delete_thread_object): Use delete.
2361 (infpy_threads): Update.
2362 (py_free_inferior): Update. Construct "inf_obj" after acquiring
2363 GIL.
2364
32372d80
TT
23652019-07-10 Tom Tromey <tromey@adacore.com>
2366
2367 * valops.c (value_cast): Specialize error message for Ada.
2368
5c458ae8
SM
23692019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2370
2371 * breakpoint.c (breakpoint_1): Update doc and parameter names.
2372
4c462cb0
SM
23732019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
2374
2375 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2376 bpstat_should_step): Return bool, adjust comments.
2377 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2378 bpstat_should_step): Likewise.
2379
89abbcc2
AH
23802019-07-10 Alan Hayward <alan.hayward@arm.com>
2381
2382 * features/Makefile: Use feature target descriptions for Arm.
2383 * features/arm/arm-core.c: Generate new file.
2384 * features/arm/arm-fpa.c: Likewise.
2385 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2386 * features/arm/arm-m-profile.c: Likewise.
2387 * features/arm/arm-vfpv2.c: Likewise.
2388 * features/arm/arm-vfpv3.c: Likewise.
2389 * features/arm/xscale-iwmmxt.c: Likewise.
2390 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2391
166a82be
AH
23922019-07-10 Alan Hayward <alan.hayward@arm.com>
2393
2394 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2395 ptrace earlier.
2396
9fb4c7e9
AH
23972019-07-10 Alan Hayward <alan.hayward@arm.com>
2398
2399 * features/aarch64-pauth.c: Regenerate.
2400
e2d0f980
SM
24012019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
2402
2403 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2404 bool.
2405 (bpstat_what): Use false instead of 0.
2406
a38118e5
PA
24072019-07-09 Pedro Alves <palves@redhat.com>
2408
2409 * break-catch-throw.c (is_exception_catchpoint): New.
2410 * breakpoint.c (print_one_breakpoint_location): New parameter
2411 'raw_loc'. Handle it. Use
2412 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2413 looking at the breakpoint's type.
2414 (print_one_breakpoint): If handling "maint info breakpoints", also
2415 print locations of exception catchpoints.
2416 * breakpoint.h (is_exception_catchpoint): Declare.
2417
cb1e4e32
PA
24182019-07-09 Pedro Alves <palves@redhat.com>
2419
2420 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2421 "addr" field.
2422 (allocate_location_exception_catchpoint): New.
2423 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2424 (initialize_throw_catchpoint_ops): Install
2425 allocate_location_exception_catchpoint as allocate_location
2426 method.
2427 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2428 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2429 bp_loc_other.
2430 (breakpoint_address_is_meaningful): Delete.
2431 (bl_address_is_meaningful): New.
2432 (breakpoint_locations_match): Adjust comment.
2433 (bp_location_from_bp_type): New, factored out of...
2434 (bp_location::bp_location(breakpoint *)): ... this.
2435 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2436 factored out of...
2437 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
2438 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2439 breakpoint_address_is_meaningful.
2440 (bp_locations_compare): Adjust comment.
2441 (update_global_location_list): Use bl_address_is_meaningful
2442 instead of breakpoint_address_is_meaningful.
2443 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2444 explicit.
2445 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2446 * python/py-breakpoint.c (bppy_get_location): No longer check
2447 whether location is null.
2448
b58a68fe
PA
24492019-07-09 Pedro Alves <palves@redhat.com>
2450
2451 PR c++/15468
2452 * breakpoint.c (print_one_breakpoint_location): Remove
2453 single-location assert.
2454
268a13a5
TT
24552019-07-09 Tom Tromey <tom@tromey.com>
2456
2457 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2458 * configure: Rebuild.
2459 * configure.ac: Change common to gdbsupport.
2460 * gdbsupport: Rename from common.
2461 * acinclude.m4: Change common to gdbsupport.
2462 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2463 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2464 gdbsupport.
2465 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2466 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2467 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2468 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2469 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2470 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2471 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2472 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2473 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2474 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2475 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2476 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2477 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2478 coff-pe-read.c, command.h, compile/compile-c-support.c,
2479 compile/compile-c.h, compile/compile-cplus-symbols.c,
2480 compile/compile-cplus-types.c, compile/compile-cplus.h,
2481 compile/compile-loc2c.c, compile/compile.c, completer.c,
2482 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
2483 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
2484 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
2485 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
2486 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
2487 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
2488 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
2489 features/aarch64-core.c, features/aarch64-fpu.c,
2490 features/aarch64-pauth.c, features/aarch64-sve.c,
2491 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
2492 features/i386/32bit-core.c, features/i386/32bit-linux.c,
2493 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
2494 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
2495 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
2496 features/i386/64bit-core.c, features/i386/64bit-linux.c,
2497 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
2498 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
2499 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
2500 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
2501 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
2502 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
2503 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
2504 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
2505 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
2506 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
2507 go32-nat.c, guile/guile.c, guile/scm-ports.c,
2508 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
2509 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
2510 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
2511 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
2512 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
2513 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
2514 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
2515 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
2516 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
2517 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
2518 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
2519 minsyms.c, mips-linux-tdep.c, namespace.h,
2520 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
2521 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
2522 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
2523 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
2524 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
2525 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
2526 nat/linux-waitpid.c, nat/mips-linux-watch.c,
2527 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
2528 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
2529 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
2530 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
2531 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
2532 procfs.c, producer.c, progspace.h, psymtab.h,
2533 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
2534 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
2535 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
2536 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
2537 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
2538 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
2539 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
2540 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
2541 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
2542 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
2543 target-memory.c, target.c, target.h, target/waitstatus.c,
2544 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
2545 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
2546 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
2547 unittests/array-view-selftests.c,
2548 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
2549 unittests/common-utils-selftests.c,
2550 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
2551 unittests/format_pieces-selftests.c,
2552 unittests/function-view-selftests.c,
2553 unittests/lookup_name_info-selftests.c,
2554 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
2555 unittests/mkdir-recursive-selftests.c,
2556 unittests/observable-selftests.c,
2557 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
2558 unittests/parse-connection-spec-selftests.c,
2559 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
2560 unittests/scoped_fd-selftests.c,
2561 unittests/scoped_mmap-selftests.c,
2562 unittests/scoped_restore-selftests.c,
2563 unittests/string_view-selftests.c, unittests/style-selftests.c,
2564 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
2565 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
2566 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
2567 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
2568 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
2569 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
2570
5b0e2db4
AB
25712019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2572
2573 * linespec.c (decode_digits_list_mode): Set explicit_line to a
2574 bool value.
2575 (decode_digits_ordinary): Set explicit_line field in sal.
2576 * symtab.c (skip_prologue_sal): Don't skip prologue for a
2577 symtab_and_line that was set on an explicit line number in
2578 assembler code. Do always update the recorded symtab and line if
2579 we do skip the prologue.
2580
0ba852ab
AB
25812019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2582
2583 * breakpoint.c (set_breakpoint_location_function): Remove
2584 explicit_loc parameter.
2585 (momentary_breakpoint_from_master): Update call to
2586 set_breakpoint_location_function.
2587 (add_location_to_breakpoint): Likewise.
2588
b3a7d171
AB
25892019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
2590
2591 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
2592 required features based on default bfd type when no specific bfd
2593 is present.
2594
1f6f6e21
PW
25952019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2596
2597 * NEWS: Mention that GDB printf and eval commands can now print
2598 C-style and Ada-style convenience var strings without
2599 calling the inferior.
2600 * printcmd.c (printf_c_string): Locally print GDB internal var
2601 instead of transiting via the inferior.
2602 (printf_wide_c_string): Likewise.
2603
26042019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf
AH
2605
2606 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
2607
0598af48
TT
26082019-07-04 Tom Tromey <tom@tromey.com>
2609
2610 PR tui/24724:
2611 * tui/tui-winsource.c (tui_clear_source_content): Update.
2612 (tui_source_window_base::set_is_exec_point_at): Fix comment.
2613 (tui_update_breakpoint_info): Update.
2614 (tui_set_exec_info_content): Update.
2615 * tui/tui-source.c (tui_set_source_content_nil): Update.
2616 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
2617 has_break.
2618 * tui/tui-data.h (enum tui_bp_flag): New.
2619 (tui_bp_flags): New enum flags type.
2620 (struct tui_source_element) <break_mode>: Change type. Rename
2621 from has_break.
2622 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
2623 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
2624 constants.
2625 * tui/tui-winsource.h: Fix comment.
2626
350fab54
AH
26272019-07-04 Alan Hayward <alan.hayward@arm.com>
2628
2629 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
2630 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
2631 (store_fpregs_to_thread)
2632 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2633 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
2634 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
2635 (IWMMXT_REGS_SIZE): Add define.
2636 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
2637 (fetch_vfp_regs, store_vfp_regs)
2638 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
2639 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
2640
f0452268
AH
26412019-07-04 Alan Hayward <alan.hayward@arm.com>
2642
2643 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
2644 defines.
2645 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
2646 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
2647 (ARM_INT_REGISTER_SIZE): ...to this.
2648 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
2649 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
2650 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
2651 (arm_linux_collect_gregset, supply_nwfpe_register)
2652 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
2653 defines.
2654 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
2655 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
2656 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
2657 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
2658 (arm_return_in_memory, arm_store_return_value)
2659 (arm_get_longjmp_target, arm_register_g_packet_guesses)
2660 (arm_record_ld_st_multiple): Likewise.
2661 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
2662 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
2663
e935475c
AH
26642019-07-04 Alan Hayward <alan.hayward@arm.com>
2665
2666 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
2667 AARCH64_DISPLACED_MODIFIED_INSNS.
2668 * aarch64-tdep.c (struct aarch64_displaced_step_data)
2669 (aarch64_displaced_step_copy_insn): Likewise.
2670 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2671 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
2672 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
2673 ARM_DISPLACED_MODIFIED_INSNS.
2674 * arm-tdep.c (arm_gdbarch_init): Likewise.
2675 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
2676 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
2677 (struct arm_displaced_step_closure): Use
2678 ARM_DISPLACED_MODIFIED_INSNS.
2679
df0bb381
AH
26802019-07-04 Alan Hayward <alan.hayward@arm.com>
2681
2682 * features/Makefile: Remove unused xml files.
2683 * features/aarch64.xml: Remove.
2684 * features/i386/amd64-avx-avx512-linux.xml: Remove.
2685 * features/i386/amd64-avx-avx512.xml: Remove.
2686 * features/i386/amd64-avx-linux.xml: Remove.
2687 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
2688 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
2689 * features/i386/amd64-avx-mpx-linux.xml: Remove.
2690 * features/i386/amd64-avx-mpx.xml: Remove.
2691 * features/i386/amd64-avx.xml: Remove.
2692 * features/i386/amd64-linux.xml: Remove.
2693 * features/i386/amd64-mpx-linux.xml: Remove.
2694 * features/i386/amd64-mpx.xml: Remove.
2695 * features/i386/amd64.xml: Remove.
2696 * features/i386/i386-avx-avx512-linux.xml: Remove.
2697 * features/i386/i386-avx-avx512.xml: Remove.
2698 * features/i386/i386-avx-linux.xml: Remove.
2699 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
2700 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
2701 * features/i386/i386-avx-mpx-linux.xml: Remove.
2702 * features/i386/i386-avx-mpx.xml: Remove.
2703 * features/i386/i386-avx.xml: Remove.
2704 * features/i386/i386-linux.xml: Remove.
2705 * features/i386/i386-mmx-linux.xml: Remove.
2706 * features/i386/i386-mmx.xml: Remove.
2707 * features/i386/i386-mpx-linux.xml: Remove.
2708 * features/i386/i386-mpx.xml: Remove.
2709 * features/i386/i386.xml: Remove.
2710 * features/i386/x32-avx-avx512-linux.xml: Remove.
2711 * features/i386/x32-avx-linux.xml: Remove.
2712 * features/i386/x32-linux.xml: Remove.
2713
edd6266a
AH
27142019-07-04 Alan Hayward <alan.hayward@arm.com>
2715
2716 * regformats/aarch64.dat: Remove.
2717 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
2718 * regformats/i386/amd64-avx-linux.dat: Remove.
2719 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
2720 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
2721 * regformats/i386/amd64-linux.dat: Remove.
2722 * regformats/i386/amd64-mpx-linux.dat: Remove.
2723 * regformats/i386/amd64.dat: Remove.
2724 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
2725 * regformats/i386/i386-avx-linux.dat: Remove.
2726 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
2727 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
2728 * regformats/i386/i386-linux.dat: Remove.
2729 * regformats/i386/i386-mmx-linux.dat: Remove.
2730 * regformats/i386/i386-mpx-linux.dat: Remove.
2731 * regformats/i386/i386.dat: Remove.
2732 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
2733 * regformats/i386/x32-avx-linux.dat: Remove.
2734 * regformats/i386/x32-linux.dat: Remove.
2735
2b40fda7
AH
27362019-07-04 Alan Hayward <alan.hayward@arm.com>
2737
2738 * aarch64-tdep.c: Remove xml self tests.
2739 * amd64-linux-tdep.c: Likewise.
2740 * amd64-tdep.c: Likewise.
2741 * i386-linux-tdep.c: Likewise.
2742 * i386-tdep.c: Likewise.
2743
5f4ba3e7
PA
27442019-07-03 Pedro Alves <palves@redhat.com>
2745
2746 PR cli/24732
2747 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
2748 (pipe_cmd_option_defs): New.
2749 (make_pipe_cmd_options_def_group): New.
2750 (pipe_command): Use gdb::option::process_options.
2751 (pipe_command_completer): New function.
2752 (_initialize_cli_cmds): Install completer for "pipe" command.
2753
3d9be6f5
PA
27542019-07-03 Pedro Alves <palves@redhat.com>
2755
2756 * cli/cli-option.c (union option_value) <string>: New field.
2757 (struct option_def_and_value): Add ctor, move ctor, dtor and
2758 use DISABLE_COPY_AND_ASSIGN.
2759 (option_def_and_value::clear_value): New.
2760 (parse_option, save_option_value_in_ctx, get_val_type_str)
2761 (add_setshow_cmds_for_options): Handle var_string.
2762 * cli-option.h (union option_def::var_address) <string>: New
2763 field.
2764 (struct string_option_def): New.
2765 * maint-test-options.c (struct test_options_opts): Add default
2766 ctor and use DISABLE_COPY_AND_ASSIGN.
2767 <string_opt>: New field.
2768 (test_options_opts::~test_options_opts): New.
2769 (test_options_opts::dump): Also dump "-string".
2770 (test_options_option_defs): Install "string.
2771
41fc454c
PA
27722019-07-03 Pedro Alves <palves@redhat.com>
2773
2774 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
2775 option_value with a null enumeration.
2776 (complete_options): Save the option values in the context.
2777 (save_option_value_in_ctx): New, factored out from ...
2778 (process_options): ... here.
2779 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
2780 of the function.
2781 * maint-test-options.c (test_options_opts::dump): New, factored
2782 out from ...
2783 (maintenance_test_options_command_mode): ... here.
2784 (maintenance_test_options_command_completion_result): Delete.
2785 (maintenance_test_options_command_completion_text): Update
2786 comment.
2787 (maintenance_show_test_options_completion_result): Change
2788 prototype. Just print
2789 maintenance_test_options_command_completion_text.
2790 (save_completion_result): New.
2791 (maintenance_test_options_completer_mode): Pass options context to
2792 complete_options, and then save a dump.
2793 (_initialize_maint_test_options): Use add_cmd to install "maint
2794 show test-options-completion-result".
2795
fdbc9870
PA
27962019-07-03 Pedro Alves <palves@redhat.com>
2797
2798 * NEWS (New commands): Mention "with" and "maint with".
2799 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
2800 (with_command, with_command_completer): New.
2801 (pipe_command): Adjust to new repeat_previous
2802 interface.
2803 (_initialize_cli_cmds): Install the "with" command and its "w"
2804 alias.
2805 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
2806 declarations.
2807 * cli/cli-setshow.c (parse_cli_var_uinteger)
2808 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
2809 argument strings for all var_types.
2810 (get_setshow_command_value_string): New, factored out from ...
2811 (do_show_command): ... this.
2812 * cli/cli-setshow.h: Include <string>.
2813 (get_setshow_command_value_string): Declare.
2814 * command.h (repeat_previous): Now returns const char *. Adjust
2815 comment.
2816 * maint.c: Include "cli/cli-cmds.h".
2817 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
2818 (_initialize_maint_cmds): Register the "maintenance with" command.
2819 * top.c (repeat_previous): Move bits from pipe_command here:
2820 Return the saved command line, if any; error out if there's no
2821 command to relaunch.
2822
c6ac8931
PA
28232019-07-03 Pedro Alves <palves@redhat.com>
2824
2825 * NEWS (New commands): Mention "maint set/show test-settings"
2826 instead of "maint test-settings".
2827 * maint-test-settings.c (maintenance_test_settings_list): Delete.
2828 (maintenance_test_settings_set_list): Rename to ...
2829 (maintenance_set_test_settings_list): ... this.
2830 (maintenance_test_settings_show_list): Rename to ...
2831 (maintenance_show_test_settings_list): ... this.
2832 (maintenance_test_settings_cmd): Delete.
2833 (maintenance_test_settings_set_cmd): ...
2834 (maintenance_set_test_settings_cmd): ... this.
2835 (maintenance_test_settings_show_cmd): ...
2836 (maintenance_show_test_settings_cmd): ... this.
2837 (maintenance_test_settings_show_value_cmd):
2838 (maintenance_show_test_settings_value_cmd): ... this.
2839 (_initialize_maint_test_settings): No longer install the "maint
2840 test-settings" prefix command. Rename "maint test-settings set"
2841 to "maint set test-settings", and "maint test-settings show" to
2842 "maint show test-settings". Adjust all subcommands.
2843
d1fcf2fd
PA
28442019-07-03 Pedro Alves <palves@redhat.com>
2845
2846 * maint-test-settings.c: Fix file's intro comment. Replace all
2847 references to "test-options" with references to "test-settings",
2848 in comments.
2849
970f9d09
PA
28502019-07-03 Pedro Alves <palves@redhat.com>
2851
2852 * maint-test-settings.c (maintenance_test_settings_xxx)
2853 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
2854 New.
2855 (maintenance_test_settings_enums): Use them.
2856 (maintenance_test_settings_enum): Default to
2857 maintenance_test_settings_xxx.
2858 (_initialize_maint_test_settings): Initialize
2859 MAINTENANCE_TEST_SETTINGS_FILENAME.
2860
f3869b1a
SM
28612019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2862
2863 * breakpoint.h (remove_breakpoints_inf): Change return type to
2864 void, move function documentation here.
2865 * breakpoint.c (remove_breakpoints_inf): Change return type to
2866 void, move function documentation to header.
2867
54d66006
PA
28682019-07-02 Pedro Alves <palves@redhat.com>
2869
2870 * NEWS (Completion improvements): Mention "info threads".
2871 * thread.c (struct info_threads_opts, info_threads_option_defs)
2872 (make_info_threads_options_def_group): New.
2873 (info_threads_command): Use gdb::option::process_options.
2874 (info_threads_command_completer): New.
2875 (_initialize_thread): Use gdb::option::build_help to build the
2876 help text for "info threads".
2877
854f6088
SM
28782019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
2879
2880 * defs.h (generic_load): Move from here...
2881 * symfile.h (generic_load): ... to here. Rename name parameter
2882 to args.
2883 * symfile.c (generic_load): Add comment.
2884
54ee4252
TT
28852019-07-01 Tom Tromey <tromey@adacore.com>
2886
2887 * dwarf2read.c
2888 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
2889 declaration of without_params. Fix formatting.
2890
65392b3e
TT
28912019-07-01 Tom Tromey <tromey@adacore.com>
2892
2893 * ada-exp.y (find_primitive_type): Update.
2894 * ada-lang.h (ada_lookup_symbol): Update.
2895 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
2896 parameter.
2897 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
2898
7d7571f0
SDJ
28992019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2900
2901 PR breakpoints/24541
2902 * gdbarch.c: Regenerate.
2903 * gdbarch.h: Regenerate.
2904 * gdbarch.sh: Add 'stap_adjust_register'.
2905 * i386-tdep.c: Include '<unordered_set>'.
2906 (i386_stap_adjust_register): New function.
2907 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
2908 * stap-probe.c (stap_parse_register_operand): Call
2909 'gdbarch_stap_adjust_register'.
2910
5af5392a
SDJ
29112019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
2912
2913 PR python/24742
2914 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
2915 * python/python.c (do_start_initialization): Use 'xmalloc'
2916 instead of 'PyMem_Malloc'.
2917
10d06d82
TT
29182019-06-28 Tom Tromey <tromey@adacore.com>
2919
2920 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
2921 for Ada.
2922
1b7f24cd
TT
29232019-06-27 Tom Tromey <tromey@adacore.com>
2924
2925 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
2926 objfile_key.
2927 (arm_find_mapping_symbol, arm_record_special_symbol)
2928 (_initialize_arm_tdep): Update.
2929 (arm_objfile_data_free): Remove.
2930
3d507ff2
TT
29312019-06-27 Tom Tromey <tromey@adacore.com>
2932
2933 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
2934 to cp_print_static_field.
2935
762c164d
TT
29362019-06-26 Tom Tromey <tromey@adacore.com>
2937
2938 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
2939 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
2940 declare.
2941
aa2f9bcf
AH
29422019-06-26 Alan Hayward <alan.hayward@arm.com>
2943
2944 * features/aarch64-core.c (create_feature_aarch64_core):
2945 Regenerate.
2946 * features/aarch64-core.xml: Add cpsr flags.
2947
3426ae57
AH
29482019-06-26 Alan Hayward <alan.hayward@arm.com>
2949
2950 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
2951 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
2952
4838e44c
SM
29532019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2954
2955 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
2956 field.
2957 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
2958 use.
2959 (arm_record_special_symbol): Don't insert new symbol in sorted
2960 position, push it at the end.
2961
54cc7474
SM
29622019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
2963
2964 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
2965 (arm_mapping_symbol_s): Remove.
2966 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
2967 (arm_mapping_symbol_vec): New typedef.
2968 (struct arm_per_objfile): Add constructor.
2969 <section_maps>: Change type to
2970 std::unique_ptr<arm_mapping_symbol_vec[]>.
2971 (arm_compare_mapping_symbols): Remove.
2972 (arm_find_mapping_symbol): Adjust to section_maps type change.
2973 (arm_objfile_data_free): Call delete on arm_per_objfile.
2974 (arm_record_special_symbol): Adjust to section_maps type change.
2975 Allocate arm_per_objfile with new.
2976
b65b566c
PW
29772019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2978
2979 * cli/cli-cmds.c (alias_command): Compare the alias prefix
2980 with the command prefix.
2981
c2fc64f5
TT
29822019-06-25 Tom Tromey <tom@tromey.com>
2983
2984 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
2985 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
2986
fb54fa76
TT
29872019-06-25 Tom Tromey <tom@tromey.com>
2988
2989 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
2990 type.
2991 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
2992 protected.
2993
f7952c57
TT
29942019-06-25 Tom Tromey <tom@tromey.com>
2995
2996 * tui/tui-winsource.c
2997 (tui_source_window_base::set_is_exec_point_at): Add check against
2998 LOA_ADDRESS.
2999
17568d78
TT
30002019-06-25 Tom Tromey <tom@tromey.com>
3001
3002 * tui/tui-source.c (tui_set_source_content): Don't check before
3003 xfree.
3004 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3005
53e7cdba
TT
30062019-06-25 Tom Tromey <tom@tromey.com>
3007
3008 * tui/tui-winsource.h (tui_update_source_window_as_is)
3009 (tui_alloc_source_buffer, tui_line_is_displayed)
3010 (tui_addr_is_displayed): Change type of win_info.
3011 * tui/tui-winsource.c (tui_update_source_window_as_is)
3012 (tui_clear_source_content, tui_show_source_line)
3013 (tui_show_source_content, tui_source_window_base::refill)
3014 (tui_source_window_base::set_is_exec_point_at)
3015 (tui_source_window_base::set_is_exec_point_at)
3016 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3017 (tui_alloc_source_buffer, tui_line_is_displayed)
3018 (tui_addr_is_displayed): Change type of win_info. Update.
3019 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3020 (tui_source_window_base::do_make_visible_with_new_height):
3021 Update.
3022 * tui/tui-source.c (tui_set_source_content)
3023 (tui_set_source_content_nil)
3024 (tui_source_window::do_scroll_vertical): Update.
3025 * tui/tui-layout.c (show_layout): Update.
3026 * tui/tui-disasm.c (tui_set_disassem_content)
3027 (tui_disasm_window::do_scroll_vertical): Update.
3028 * tui/tui-data.h (tui_win_content): Remove.
3029 (struct tui_gen_win_info) <content, content_size>: Remove.
3030 (struct tui_source_element): Add initializers and destructor.
3031 (union tui_which_element, struct tui_win_element): Remove.
3032 (struct tui_source_window_base) <content>: New field.
3033 (struct tui_data_window): Remove destructor.
3034 (tui_alloc_content, tui_free_win_content)
3035 (tui_free_all_source_wins_content): Don't declare.
3036 * tui/tui-data.c (tui_initialize_static_data): Update.
3037 (init_content_element, tui_alloc_content): Remove.
3038 (~tui_gen_win_info): Update.
3039 (~tui_data_window, tui_free_all_source_wins_content)
3040 (tui_free_win_content, free_content, free_content_elements):
3041 Remove.
3042
7908abbf
TT
30432019-06-25 Tom Tromey <tom@tromey.com>
3044
3045 * tui/tui-winsource.h (tui_clear_source_content)
3046 (tui_erase_source_content, tui_show_source_content): Change type
3047 of win_info.
3048 * tui/tui-winsource.c (tui_clear_source_content)
3049 (tui_erase_source_content, tui_show_source_content): Change type
3050 of win_info.
3051 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3052 * tui/tui-source.h (tui_set_source_content_nil): Change type of
3053 win_info.
3054 * tui/tui-source.c (tui_set_source_content_nil): Change type of
3055 win_info.
3056 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3057
02c28df0
TT
30582019-06-25 Tom Tromey <tom@tromey.com>
3059
3060 * tui/tui-winsource.c (tui_clear_source_content)
3061 (tui_source_window_base::set_is_exec_point_at): Update.
3062 * tui/tui-source.c (tui_set_source_content_nil): Update.
3063 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3064 a bool.
3065 * tui/tui-data.c (init_content_element): Update.
3066
6658b1bf
TT
30672019-06-25 Tom Tromey <tom@tromey.com>
3068
3069 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3070 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3071 * tui/tui-layout.c (init_and_make_win): Update.
3072 * tui/tui.h (enum tui_win_type): Update.
3073 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3074 tui_win_is_auxillary.
3075 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3076 tui_win_is_auxillary.
3077
21e1c91e
TT
30782019-06-25 Tom Tromey <tom@tromey.com>
3079
3080 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3081 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3082 (tui_delete_data_content_windows, tui_display_all_data)
3083 (tui_data_window::do_scroll_vertical, tui_display_data_from):
3084 Update.
3085 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3086 * tui/tui-regs.c (tui_last_regs_line_no)
3087 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3088 (tui_show_registers): Update.
3089 (tui_show_register_group): Return void. Update.
3090 (tui_display_registers_from, tui_display_reg_element_at_line)
3091 (tui_display_registers_from_line, tui_check_register_values):
3092 Update.
3093 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3094 member.
3095 (struct tui_data_window) <regs_content>: Now a std::vector.
3096 <regs_content_count>: Remove.
3097 (tui_add_content_elements, tui_free_data_content): Don't declare.
3098 * tui/tui-data.c (tui_data_window::clear_detail): Update.
3099 (init_content_element): Remove DATA_WIN case. Add assert.
3100 (tui_add_content_elements): Remove.
3101 (tui_data_window): Update.
3102 (tui_free_data_content): Remove.
3103 (free_content_elements): Remove DATA_WIN case.
3104
115ac53b
TT
31052019-06-25 Tom Tromey <tom@tromey.com>
3106
3107 * tui/tui-data.c (tui_data_item_window): Update.
3108 * tui/tui-windata.h (tui_check_data_values): Don't declare.
3109 * tui/tui-windata.c (tui_display_all_data)
3110 (tui_display_data_from_line): Update.
3111 (tui_check_data_values): Remove.
3112 * tui/tui-regs.c (tui_show_register_group)
3113 (tui_display_reg_element_at_line): Update.
3114 * tui/tui-hooks.c (tui_register_changed)
3115 (tui_refresh_frame_and_register_information): Call
3116 tui_check_register_values.
3117 * tui/tui-data.h (struct tui_data_window) <data_content,
3118 data_content_count, data_type>: Remove.
3119 (enum tui_data_type): Remove.
3120
3121 * tui/tui-data.c (tui_data_window::clear_detail)
3122 (~tui_data_window): Update.
3123
eaf9738b
TT
31242019-06-25 Tom Tromey <tom@tromey.com>
3125
3126 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3127 declare.
3128 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3129 Rename from tui_first_data_item_displayed. Update.
3130 (tui_data_window::refresh_all)
3131 (tui_data_window::do_scroll_vertical): Update.
3132 * tui/tui-data.h (struct tui_data_window)
3133 <first_data_item_displayed>: Declare new method.
3134
31ca4723
TT
31352019-06-25 Tom Tromey <tom@tromey.com>
3136
3137 * tui/tui-data.h (tui_init_generic_part): Don't declare.
3138 * tui/tui-data.c (tui_init_generic_part): Remove, moving
3139 contents...
3140 (tui_initialize_static_data): ...here.
3141
41bcff7f
TT
31422019-06-25 Tom Tromey <tom@tromey.com>
3143
3144 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3145 (tui_display_registers_from, tui_check_register_values): Update.
3146 (tui_display_register): Remove win_info parameter; update.
3147 (tui_get_register): Change type of parameters.
3148 * tui/tui-data.h (struct tui_data_element): Remove.
3149 (union tui_which_element) <data>: Remove.
3150 <data_window>: Change type.
3151 (struct tui_data_item_window): New.
3152 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3153 case. Add assert.
3154 (~tui_data_item_window): New destructor.
3155 (free_content_elements): Remove DATA_ITEM_WIN case.
3156
d2802c33
TT
31572019-06-25 Tom Tromey <tom@tromey.com>
3158
3159 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3160 Remove.
3161
dd835f8b
TT
31622019-06-25 Tom Tromey <tom@tromey.com>
3163
3164 * tui/tui-data.h (struct tui_command_element): Remove.
3165 (union tui_which_element) <command>: Remove.
3166 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
3167 assert.
3168 (free_content_elements): Remove CMD_WIN case.
3169
bd7db367
TT
31702019-06-25 Tom Tromey <tom@tromey.com>
3171
3172 * tui/tui-layout.c (tui_set_layout): Update.
3173 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3174 * tui/tui-data.c (layout_def): Update.
3175
3add462f
TT
31762019-06-25 Tom Tromey <tom@tromey.com>
3177
3178 * tui/tui-wingeneral.c (tui_refresh_all): Update.
3179 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3180 (tui_source_window_base::set_new_height): Update.
3181 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3182 Update.
3183 (tui_set_locator_fullname, tui_set_locator_info)
3184 (tui_show_frame_info): Update.
3185 * tui/tui-source.c (tui_set_source_content)
3186 (tui_source_is_displayed): Update.
3187 * tui/tui-layout.c (show_source_disasm_command, show_data)
3188 (show_source_or_disasm_and_command): Update.
3189 * tui/tui-disasm.c (tui_set_disassem_content)
3190 (tui_get_begin_asm_address): Update.
3191 * tui/tui-data.h (struct tui_locator_element): Remove.
3192 (union tui_which_element) <locator>: Remove.
3193 (struct tui_locator_window): New.
3194 (tui_locator_win_info_ptr): Change return type.
3195 * tui/tui-data.c (_locator): Change type.
3196 (tui_locator_win_info_ptr): Change return type.
3197 (init_content_element): Remove LOCATOR_WIN case. Add assert.
3198 (tui_alloc_content): Add assert.
3199
489e9d8b
TT
32002019-06-25 Tom Tromey <tom@tromey.com>
3201
3202 * tui/tui-winsource.c
3203 (tui_exec_info_window::maybe_allocate_content): New method.
3204 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3205 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3206 (make_source_or_disasm_window): Add cast.
3207 * tui/tui-data.h (union tui_which_element) <simple_string>:
3208 Remove.
3209 (struct tui_source_info): New.
3210 (struct tui_source_window_base) <execution_info>: Change type.
3211 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3212 case, and add assert.
3213 (tui_alloc_content): Add assert.
3214
c3fabb7d
TT
32152019-06-25 Tom Tromey <tom@tromey.com>
3216
3217 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3218 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3219 * tui/tui-data.c (tui_alloc_win_info): Remove.
3220
bbc228ee
TT
32212019-06-25 Tom Tromey <tom@tromey.com>
3222
3223 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3224 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3225 can_highlight.
3226
5fcee43a
TT
32272019-06-25 Tom Tromey <tom@tromey.com>
3228
3229 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3230 make_visible_with_new_height method.
3231 (tui_win_info::make_visible_with_new_height): New method.
3232 (tui_source_window_base::do_make_visible_with_new_height)
3233 (tui_data_window::do_make_visible_with_new_height)
3234 (tui_cmd_window::do_make_visible_with_new_height): New methods.
3235 (make_visible_with_new_height): Remove.
3236 (tui_resize_all, tui_adjust_win_heights): Use
3237 make_visible_with_new_height method.
3238 * tui/tui-data.h (struct tui_win_info)
3239 <do_make_visible_with_new_height, make_visible_with_new_height>:
3240 New methods.
3241 (struct tui_source_window_base, struct tui_data_window)
3242 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3243 methods.
3244
d83f1fe6
TT
32452019-06-25 Tom Tromey <tom@tromey.com>
3246
3247 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3248 method.
3249 (update_tab_width): Call update_tab_width method.
3250 * tui/tui-data.h (struct tui_win_info)
3251 (struct tui_source_window_base) <update_tab_width>: New methods.
3252
17374de4
TT
32532019-06-25 Tom Tromey <tom@tromey.com>
3254
3255 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3256 parameter.
3257 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3258 parameter.
3259 (tui_gen_win_info::make_visible): Update.
3260 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3261 parameter.
3262 * tui/tui-data.h (enum tui_box): New enum.
3263 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3264
f936bca2
TT
32652019-06-25 Tom Tromey <tom@tromey.com>
3266
3267 * tui/tui-layout.c (make_source_or_disasm_window): Always use
3268 init_and_make_win for EXEC_INFO_WIN.
3269 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3270 longer inline.
3271 (struct tui_win_info) <~tui_win_info>: Inline.
3272 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3273 Don't declare.
3274 * tui/tui-data.c (source_win, disasm_win): Remove globals.
3275 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3276 Remove.
3277 (tui_initialize_static_data): Update.
3278 (~tui_gen_win_info): Handle more cleanup here.
3279 (~tui_source_window_base): Delete "execution_info".
3280 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3281
d6ba6a11
TT
32822019-06-25 Tom Tromey <tom@tromey.com>
3283
3284 * tui/tui-layout.c (make_command_window): Don't set
3285 can_highlight.
3286 (show_source_disasm_command): Call the reset method.
3287 (show_data): Don't set can_highlight. Call the reset method.
3288 (tui_gen_win_info::reset): Rename from init_gen_win_info
3289 (init_and_make_win): Simplify. Return tui_gen_win_info.
3290 (show_source_or_disasm_and_command): Call the reset method.
3291 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3292 (struct tui_cmd_window): Set can_highlight.
3293
48a3bd16
TT
32942019-06-25 Tom Tromey <tom@tromey.com>
3295
3296 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3297 from make_visible.
3298 (tui_make_visible, tui_make_invisible): Rewrite.
3299 (tui_win_info::make_visible): Remove.
3300 (tui_source_window_base::make_visible): Update.
3301 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3302 method. Moved from...
3303 (struct tui_win_info) <make_visible>: ...here.
3304
c3bd716f
TT
33052019-06-25 Tom Tromey <tom@tromey.com>
3306
3307 * tui/tui-winsource.c
3308 (tui_source_window_base::do_scroll_horizontal): Remove direction
3309 parameter.
3310 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3311 direction parameter.
3312 * tui/tui-win.c (tui_win_info::forward_scroll)
3313 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3314 (tui_win_info::right_scroll): Update.
3315 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3316 direction parameter.
3317 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3318 direction parameter.
3319 * tui/tui-data.h (enum tui_scroll_direction): Remove.
3320 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3321 Remove direction parameter.
3322 (struct tui_source_window_base, struct tui_source_window)
3323 (struct tui_disasm_window, struct tui_data_window)
3324 (struct tui_cmd_window): Update.
3325
21c32dca
TT
33262019-06-25 Tom Tromey <tom@tromey.com>
3327
3328 * tui/tui-winsource.h (tui_set_exec_info_content)
3329 (tui_show_exec_info_content, tui_erase_exec_info_content)
3330 (tui_clear_exec_info_content, tui_update_exec_info): Change
3331 argument to tui_source_window_base.
3332 * tui/tui-winsource.c (tui_set_exec_info_content)
3333 (tui_show_exec_info_content, tui_erase_exec_info_content)
3334 (tui_clear_exec_info_content, tui_update_exec_info): Change
3335 argument to tui_source_window_base.
3336
73fbdc65
TT
33372019-06-25 Tom Tromey <tom@tromey.com>
3338
3339 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3340 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3341
33325343
TT
33422019-06-25 Tom Tromey <tom@tromey.com>
3343
3344 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3345 check.
3346
29d2c474
TT
33472019-06-25 Tom Tromey <tom@tromey.com>
3348
3349 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3350 type to void.
3351 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3352 type to void.
3353 * tui/tui-source.c (tui_set_source_content): Update.
3354 * tui/tui-disasm.c (tui_set_disassem_content): Update.
3355
152f3f4b
TT
33562019-06-25 Tom Tromey <tom@tromey.com>
3357
3358 * tui/tui-win.c (window_name_completer, tui_set_focus)
3359 (tui_all_windows_info): Use name method.
3360 * tui/tui-data.h (struct tui_gen_win_info)
3361 (struct tui_source_window, struct tui_disasm_window)
3362 (struct tui_data_window, struct tui_cmd_window) <name>: New
3363 method.
3364 (tui_win_name): Don't declare.
3365 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3366 (tui_win_name): Remove.
3367
be4da588
TT
33682019-06-25 Tom Tromey <tom@tromey.com>
3369
3370 * tui/tui-winsource.h (tui_update_source_window)
3371 (tui_update_source_window_as_is): Change parameter type.
3372 * tui/tui-winsource.c (tui_update_source_window): Change win_info
3373 to be a tui_source_window_base.
3374 (tui_update_source_window_as_is): Likewise.
3375 * tui/tui-win.c (make_visible_with_new_height): Update.
3376
5b81daba
TT
33772019-06-25 Tom Tromey <tom@tromey.com>
3378
3379 * tui/tui-winsource.c (tui_erase_source_content)
3380 (tui_show_source_content, tui_show_exec_info_content)
3381 (tui_erase_exec_info_content): Use refresh_window method.
3382 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3383 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3384 from tui_refresh_win.
3385 (tui_data_window::refresh_window): New method.
3386 (tui_win_info::refresh, tui_source_window_base::refresh)
3387 (tui_refresh_all): Use refresh_window method.
3388 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3389 method.
3390 * tui/tui-regs.c (tui_display_register): Call refresh_window
3391 method.
3392 * tui/tui-layout.c (show_source_disasm_command)
3393 (show_source_or_disasm_and_command): Call refresh_window method.
3394 * tui/tui-data.h (struct tui_gen_win_info)
3395 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3396 New method.
3397
cb2ce893
TT
33982019-06-25 Tom Tromey <tom@tromey.com>
3399
3400 * tui/tui.c (tui_rl_other_window, tui_enable)
3401 (tui_is_window_visible, tui_get_command_dimension): Update.
3402 * tui/tui-winsource.c (tui_update_source_window_as_is)
3403 (tui_clear_source_content, tui_erase_source_content)
3404 (tui_show_source_line, tui_source_window_base::refill)
3405 (tui_source_window_base::do_scroll_horizontal)
3406 (tui_source_window_base::set_is_exec_point_at)
3407 (tui_update_breakpoint_info, tui_set_exec_info_content)
3408 (tui_alloc_source_buffer, tui_line_is_displayed)
3409 (tui_addr_is_displayed): Update.
3410 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3411 (tui_check_and_display_highlight_if_needed)
3412 (tui_win_info::make_visible, tui_win_info::refresh)
3413 (tui_refresh_all): Update.
3414 * tui/tui-windata.c (tui_first_data_item_displayed)
3415 (tui_delete_data_content_windows, tui_erase_data_content)
3416 (tui_display_all_data, tui_data_window::refresh_all)
3417 (tui_check_data_values): Update.
3418 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3419 (tui_set_win_focus_to, tui_win_info::forward_scroll)
3420 (tui_win_info::backward_scroll, tui_refresh_all_win)
3421 (tui_resize_all, tui_set_focus, tui_all_windows_info)
3422 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3423 (tui_source_window_base::set_new_height)
3424 (tui_data_window::set_new_height)
3425 (make_invisible_and_set_new_height)
3426 (make_visible_with_new_height, new_height_ok)
3427 (parse_scrolling_args): Update.
3428 * tui/tui-stack.c (tui_show_frame_info): Update.
3429 * tui/tui-source.c (tui_set_source_content)
3430 (tui_set_source_content_nil, tui_source_is_displayed)
3431 (tui_source_window::do_scroll_vertical): Update.
3432 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3433 (tui_display_registers_from, tui_display_reg_element_at_line)
3434 (tui_check_register_values, tui_reg_command): Update.
3435 * tui/tui-layout.c (tui_default_win_height)
3436 (show_source_disasm_command, show_data, init_and_make_win)
3437 (show_source_or_disasm_and_command): Update.
3438 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3439 (tui_redisplay_readline, tui_mld_flush)
3440 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3441 (tui_getc): Update.
3442 * tui/tui-disasm.c (tui_set_disassem_content)
3443 (tui_disasm_window::do_scroll_vertical): Update.
3444 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3445 Now virtual.
3446 (struct tui_win_info): Derive from tui_gen_win_info.
3447 <~tui_win_info>: Mark as override.
3448 <generic>: Remove member.
3449 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3450 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3451 (~tui_data_window, ~tui_win_info)
3452 (tui_free_all_source_wins_content): Update.
3453 * tui/tui-command.c (tui_refresh_cmd_win): Update.
3454
ab313b35
TT
34552019-06-25 Tom Tromey <tom@tromey.com>
3456
3457 * tui/tui-layout.c (init_and_make_win): Use new.
3458 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3459 destructor, initializers.
3460 (tui_alloc_generic_win_info): Don't declare.
3461 * tui/tui-data.c (_locator): Add argument to constructor.
3462 (source_win, disasm_win): New globals.
3463 (exec_info): Remove.
3464 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3465 Update.
3466 (tui_alloc_generic_win_info): Remove.
3467 (init_content_element): Use new.
3468 (tui_win_info::tui_win_info): Update.
3469 (free_content_elements) <case DATA_WIN>: Use delete.
3470
dc2c33e4
TT
34712019-06-25 Tom Tromey <tom@tromey.com>
3472
3473 * tui/tui-wingeneral.c (tui_refresh_win): Update.
3474 * tui/tui-windata.c (tui_first_data_item_displayed)
3475 (tui_delete_data_content_windows): Update.
3476 * tui/tui-win.c (tui_data_window::set_new_height): Update.
3477 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3478 (tui_display_registers_from, tui_check_register_values): Update.
3479 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
3480 pointer.
3481 * tui/tui-data.c (init_content_element): Update. Allocate the new
3482 window.
3483 (tui_free_data_content): Update.
3484 (free_content_elements) <case DATA_WIN>: Free the window.
3485
214a5cbe
TT
34862019-06-25 Tom Tromey <tom@tromey.com>
3487
3488 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
3489 Update.
3490 * tui/tui-layout.c (make_command_window)
3491 (show_source_disasm_command, show_data, init_and_make_win)
3492 (show_source_or_disasm_and_command): Update.
3493 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
3494 method.
3495 <can_highight, is_highlighted>: Now bool.
3496 (tui_set_win_highlight): Don't declare.
3497 * tui/tui-data.c (tui_set_win_highlight): Remove.
3498
8e2daf15
TT
34992019-06-25 Tom Tromey <tom@tromey.com>
3500
3501 * tui/tui-wingeneral.c (make_visible): Remove check of window
3502 type.
3503
8903bd8a
TT
35042019-06-25 Tom Tromey <tom@tromey.com>
3505
3506 * tui/tui-win.c (tui_win_info::max_height)
3507 (tui_cmd_window::max_height): New methods.
3508 (new_height_ok): Call max_height.
3509 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
3510 <max_height>: New method.
3511
3f02ce1e
TT
35122019-06-25 Tom Tromey <tom@tromey.com>
3513
3514 * tui/tui-win.c (tui_source_window_base::set_new_height)
3515 (tui_data_window::set_new_height): New methods.
3516 (make_invisible_and_set_new_height): Call set_new_height method.
3517 * tui/tui-data.h (struct tui_win_info)
3518 (struct tui_source_window_base, struct tui_data_window)
3519 <set_new_height>: New method.
3520
1825f487
TT
35212019-06-25 Tom Tromey <tom@tromey.com>
3522
3523 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
3524 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
3525 tui_refresh_data_win.
3526 * tui/tui-win.c (tui_source_window_base::refresh_all): New
3527 method.
3528 (tui_refresh_all_win): Call the refresh_all method.
3529 (tui_set_focus): Likewise.
3530 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
3531 (struct tui_source_window_base, struct tui_data_window) <refresh>:
3532 Likewise.
3533
ad54d15b
TT
35342019-06-25 Tom Tromey <tom@tromey.com>
3535
3536 * tui/tui-winsource.h (tui_refill_source_window)
3537 (tui_set_is_exec_point_at): Don't declare.
3538 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3539 (tui_source_window_base::refill): Rename from
3540 tui_refill_source_window.
3541 (tui_source_window_base::do_scroll_horizontal): Update.
3542 (tui_source_window_base::set_is_exec_point_at): Rename from
3543 tui_set_is_exec_point_at.
3544 (tui_update_all_breakpoint_info): Update.
3545 * tui/tui-stack.c (tui_show_frame_info): Update.
3546 * tui/tui-layout.c (show_data): Add cast.
3547 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
3548 * tui/tui-data.h (struct tui_source_window_base) <refill,
3549 set_is_exec_point_at>: New methods.
3550 (tui_source_windows, tui_add_to_source_windows): Update types.
3551 (tui_add_to_source_windows): Remove redundant declaration.
3552 * tui/tui-data.c (source_windows): Store tui_source_window_base.
3553 (tui_source_windows): Change return type.
3554 (tui_clear_source_windows_detail): Update.
3555 (tui_add_to_source_windows): Change type of parameter.
3556 (tui_free_all_source_wins_content): Update.
3557
2042b506
TT
35582019-06-25 Tom Tromey <tom@tromey.com>
3559
3560 * tui/tui-wingeneral.c (tui_win_info::refresh)
3561 (tui_source_window_base::refresh): New methods.
3562 (tui_refresh_all): Call the refresh method.
3563 * tui/tui-data.h (struct tui_win_info)
3564 (struct tui_source_window_base) <refresh>: New method.
3565
56122977
TT
35662019-06-25 Tom Tromey <tom@tromey.com>
3567
3568 * tui/tui.h (tui_is_window_visible): Return bool.
3569 * tui/tui.c (tui_is_window_visible): Return bool.
3570 * tui/tui-wingeneral.c (tui_make_window, make_visible)
3571 (tui_make_visible, tui_make_invisible)
3572 (tui_win_info::make_visible)
3573 (tui_source_window_base::make_visible, make_all_visible)
3574 (tui_make_all_visible, tui_make_all_invisible): Update.
3575 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
3576 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
3577 bool.
3578 (struct tui_win_info, struct tui_source_window_base)
3579 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
3580 * tui/tui-data.c (tui_init_generic_part): Update.
3581
cda37efb
TT
35822019-06-25 Tom Tromey <tom@tromey.com>
3583
3584 * tui/tui-wingeneral.c (tui_win_info::make_visible)
3585 (tui_source_window_base::make_visible): New methods.
3586 (make_all_visible): Make method call.
3587 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
3588 (struct tui_source_window_base, struct tui_cmd_window): Override
3589 make_visible.
3590 (tui_win_is_source_type): Don't declare.
3591 * tui/tui-data.c (tui_win_is_source_type): Remove.
3592
6a0ee02c
TT
35932019-06-25 Tom Tromey <tom@tromey.com>
3594
3595 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
3596 NULL check.
3597
63901aec
TT
35982019-06-25 Tom Tromey <tom@tromey.com>
3599
3600 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
3601 Inline constructor. Add initializers for members.
3602 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
3603 constructors; now inline in class.
3604
ceb13a13
TT
36052019-06-25 Tom Tromey <tom@tromey.com>
3606
3607 * tui/tui-regs.c (tui_show_registers): Update.
3608 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
3609 bool.
3610 * tui/tui-data.c (tui_data_window::clear_detail)
3611 (tui_data_window): Update.
3612
238eb706
TT
36132019-06-25 Tom Tromey <tom@tromey.com>
3614
3615 * tui/tui-windata.c (tui_display_all_data)
3616 (tui_display_data_from_line, tui_display_data_from)
3617 (tui_check_data_values, tui_data_window::do_scroll_vertical):
3618 Update.
3619 * tui/tui-regs.c (tui_last_regs_line_no)
3620 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3621 (tui_show_registers, tui_show_register_group)
3622 (tui_display_registers_from, tui_display_reg_element_at_line)
3623 (tui_display_registers_from_line, tui_check_register_values)
3624 (tui_reg_next, tui_reg_prev): Update.
3625 * tui/tui-layout.c (tui_set_layout, show_data): Update.
3626 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
3627 tui_data_window.
3628 (struct tui_win_info) <detail>: Remove. Add new fields from
3629 tui_data_info.
3630 (TUI_DATA_WIN): Add cast.
3631 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
3632 (~tui_data_window): Simplify.
3633
81491aa0
TT
36342019-06-25 Tom Tromey <tom@tromey.com>
3635
3636 * tui/tui-layout.c (show_source_disasm_command)
3637 (show_source_or_disasm_and_command): Update.
3638 * tui/tui-io.c (update_cmdwin_start_line)
3639 (tui_redisplay_readline): Update.
3640 * tui/tui-data.h (struct tui_command_info): Remove.
3641 (struct tui_win_info) <detail>: Remove command_info member.
3642 (struct tui_data_window) <start_line>: New member, from
3643 tui_command_info.
3644 (TUI_CMD_WIN): Add casts.
3645
e6e41501
TT
36462019-06-25 Tom Tromey <tom@tromey.com>
3647
3648 * tui/tui-winsource.c (tui_update_source_window)
3649 (tui_refill_source_window)
3650 (tui_source_window_base::do_scroll_horizontal)
3651 (tui_update_breakpoint_info, tui_set_exec_info_content)
3652 (tui_show_exec_info_content, tui_erase_exec_info_content)
3653 (tui_clear_exec_info_content): Update.
3654 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
3655 Update.
3656 * tui/tui-win.c (make_invisible_and_set_new_height)
3657 (make_visible_with_new_height): Update.
3658 * tui/tui-source.c (tui_set_source_content)
3659 (tui_show_symtab_source): Update.
3660 * tui/tui-layout.c (extract_display_start_addr)
3661 (show_source_disasm_command, show_data)
3662 (make_source_or_disasm_window)
3663 (show_source_or_disasm_and_command): Update.
3664 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
3665 (tui_disasm_window::do_scroll_vertical): Remove shadowing
3666 "gdbarch".
3667 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
3668 to tui_source_window_base.
3669 (struct tui_win_info) <detail>: Remove source_info member.
3670 (struct tui_source_window_base) <has_locator>: Inline.
3671 Move contents from tui_source_info; rename has_locator member to
3672 m_has_locator.
3673 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
3674 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
3675 header file.
3676 (tui_source_window_base::clear_detail, ~tui_source_window_base):
3677 Simplify.
3678 (tui_free_all_source_wins_content): Cast to
3679 tui_source_window_base.
3680
44f0e208
TT
36812019-06-25 Tom Tromey <tom@tromey.com>
3682
3683 * tui/tui-win.c (make_invisible_and_set_new_height)
3684 (make_visible_with_new_height): Call has_locator method.
3685 * tui/tui-layout.c (show_source_disasm_command, show_data)
3686 (show_source_or_disasm_and_command): Update for bool change.
3687 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
3688 (tui_win_info) <has_locator>: New method.
3689 (struct tui_source_window_base) <has_locator>: New method.
3690 (tui_win_has_locator): Don't declare.
3691 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
3692 from tui_win_has_locator.
3693 (tui_source_window_base): Use false, not FALSE.
3694
7778b912
TT
36952019-06-25 Tom Tromey <tom@tromey.com>
3696
3697 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
3698 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
3699 clear_detail method directly.
3700 (tui_clear_win_detail): Remove.
3701
f83d391c
TT
37022019-06-25 Tom Tromey <tom@tromey.com>
3703
3704 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
3705 "this", not TUI_DISASM_WIN.
3706
13446e05
TT
37072019-06-25 Tom Tromey <tom@tromey.com>
3708
3709 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
3710 declare.
3711 * tui/tui-winsource.c
3712 (tui_source_window_base::do_scroll_horizontal): Rename from
3713 tui_horizontal_source_scroll.
3714 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
3715 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
3716 from tui_vertical_data_scroll.
3717 * tui/tui-win.h (tui_scroll): Don't declare.
3718 * tui/tui-win.c (tui_win_info::forward_scroll)
3719 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3720 (tui_win_info::right_scroll): Rename and update.
3721 (tui_scroll_forward_command, tui_scroll_backward_command)
3722 (tui_scroll_left_command, tui_scroll_right_command): Update.
3723 (tui_scroll): Remove.
3724 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
3725 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
3726 from tui_vertical_source_scroll.
3727 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
3728 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
3729 from tui_vertical_disassem_scroll.
3730 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
3731 do_scroll_horizontal>: New methods.
3732 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
3733 Likewise.
3734 (struct tui_source_window_base): Add do_scroll_horizontal.
3735 (struct tui_source_window, struct tui_disasm_window): Add
3736 do_scroll_vertical.
3737 (struct tui_data_window, struct tui_cmd_window): Add
3738 do_scroll_horizontal and do_scroll_vertical.
3739 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
3740
5cf82909
TT
37412019-06-25 Tom Tromey <tom@tromey.com>
3742
3743 * tui/tui-data.h (struct tui_source_window_base): New struct.
3744 (struct tui_source_window): Derive from tui_source_window_base.
3745 (struct tui_disasm_window): New struct.
3746 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
3747 from tui_source_window::clear_detail.
3748 (tui_source_window_base): Rename from tui_source_window.
3749 (~tui_source_window_base): Rename from ~tui_source_window.
3750 (tui_alloc_win_info): Create a tui_disasm_window.
3751
ee1d42d6
TT
37522019-06-25 Tom Tromey <tom@tromey.com>
3753
3754 * tui/tui-data.h (struct tui_source_window)
3755 (struct tui_data_window): Declare destructors.
3756 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
3757 destructors.
3758 (tui_win_info): Simplify.
3759
b4eb2452
TT
37602019-06-25 Tom Tromey <tom@tromey.com>
3761
3762 * tui/tui-winsource.c (tui_display_main)
3763 (tui_update_source_windows_with_addr)
3764 (tui_update_all_breakpoint_info): Update.
3765 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3766 (new_height_ok, parse_scrolling_args): Update.
3767 * tui/tui-stack.c (tui_show_frame_info): Update.
3768 * tui/tui-data.h (struct tui_list): Remove.
3769 (tui_source_windows): Return a reference to a std::vector.
3770 * tui/tui-data.c (source_windows): Now a std::vector.
3771 (tui_source_windows): Change return type.
3772 (tui_clear_source_windows): Rewrite.
3773 (tui_clear_source_windows_detail, tui_add_to_source_windows)
3774 (tui_free_all_source_wins_content): Rewrite.
3775
8761a91b
TT
37762019-06-25 Tom Tromey <tom@tromey.com>
3777
3778 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
3779 (struct tui_data_window, struct tui_cmd_window): Declare
3780 clear_detail method.
3781 * tui/tui-data.c (tui_source_window::clear_detail)
3782 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
3783 methods.
3784 (tui_clear_win_detail): Simplify.
3785
0ed69eda
TT
37862019-06-25 Tom Tromey <tom@tromey.com>
3787
3788 * tui/tui-layout.c (make_source_window, make_disasm_window)
3789 (make_source_or_disasm_window): Remove win_info_ptr parameter.
3790 Return the new window.
3791 (show_source_disasm_command, show_data)
3792 (show_source_or_disasm_and_command): Update.
3793
82432e10
TT
37942019-06-25 Tom Tromey <tom@tromey.com>
3795
3796 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
3797 parameter. Return the new window.
3798 (show_source_disasm_command): Update and remove NULL check.
3799 (show_source_or_disasm_and_command): Update.
3800
ec328aa5
TT
38012019-06-25 Tom Tromey <tom@tromey.com>
3802
3803 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
3804
33b906ab
TT
38052019-06-25 Tom Tromey <tom@tromey.com>
3806
3807 * tui/tui-data.h (struct tui_win_info): Make constructor
3808 protected. Make destructor virtual. Add initializers.
3809 (tui_source_window, tui_data_window, tui_cmd_window): New
3810 classes.
3811 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
3812 constructor. Add "type" parameter.
3813 (tui_source_window, tui_data_window, tui_cmd_window): New
3814 constructors.
3815 (tui_alloc_win_info): Instantiate the appropriate subclass.
3816
e7e11af4
TT
38172019-06-25 Tom Tromey <tom@tromey.com>
3818
3819 * tui/tui-win.c (tui_resize_all): Use delete.
3820 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
3821 destructor.
3822 (tui_free_window): Don't declare.
3823 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
3824 Update.
3825
6792b55e
TT
38262019-06-25 Tom Tromey <tom@tromey.com>
3827
3828 * tui/tui-data.h (struct tui_win_info): Add constructor.
3829 * tui/tui-data.c (tui_alloc_win_info): Use new.
3830 (tui_free_window): Use delete.
3831
f95675e1
TT
38322019-06-22 Tom Tromey <tom@tromey.com>
3833
3834 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
3835 declare.
3836 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
3837
5bff081c
TT
38382019-06-22 Tom Tromey <tom@tromey.com>
3839
3840 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
3841 declare.
3842 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
3843
47e3f474
TV
38442019-06-22 Tom de Vries <tdevries@suse.de>
3845
3846 * dwarf2read.c (create_addrmap_from_aranges)
3847 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
3848 instead of '%zu'.
3849
fd5866f6
SM
38502019-06-21 Simon Marchi <simon.marchi@efficios.com>
3851
3852 * dwarf2read.h (dwarf2_section_info_def): Remove.
3853 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
3854 * dwarf2read.c (struct dwo_sections) <types>: Change type to
3855 std::vector<dwarf2_section_info>.
3856 (struct dwo_file) <~dwo_file>: Remove.
3857 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
3858 types field.
3859 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
3860 (dwarf2_read_debug_names): Likewise.
3861 (create_debug_types_hash_table): Change parameter type to
3862 array_view, adjust code accordingly.
3863 (dwarf2_locate_dwo_sections): Adjust to std::vector.
3864 (partial_die_info::fixup): Likewise.
3865 (determine_prefix): Likewise.
3866 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
3867
fb1eb2f9
SM
38682019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3869
3870 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
3871 gdb_bfd_ref_ptr.
3872 <~dwo_file>: Remove call to gdb_bfd_unref.
3873 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
3874 gdb_bfd_ref_ptr::get.
3875
51ac9db5
SM
38762019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3877
3878 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
3879 type to htab_up.
3880 * dwarf2read.c (struct dwo_file): Initialize fields.
3881 <~dwo_file>: New.
3882 (free_dwo_file): Remove, move content to ~dwo_file.
3883 (struct dwo_file_deleter): Remove.
3884 (dwo_file_up>: Remove custom deleter.
3885 (free_dwo_files): Remove.
3886 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
3887 dwo_files.
3888 (process_skeletonless_type_units): Call unique_ptr::get.
3889 (allocate_dwo_file_hash_table): Add deleter to created hash
3890 table. Change return type to htab_up.
3891 (lookup_dwo_file_slot): Don't memset dwo_file, call
3892 unique_ptr::get.
3893 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
3894 (create_dwo_unit_in_dwp_v2): Likewise.
3895 (open_and_init_dwo_file): Likewise.
3896 (free_dwo_file_from_slot): Remove.
3897
dc4ccb6f
SM
38982019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
3899
3900 * dwarf2read.h (struct dwarf2_section_info) <readin,
3901 is_virtual>: Change type to bool.
3902 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
3903 true instead of 1.
3904
e6a1c5cb
TT
39052019-06-19 Tom Tromey <tom@tromey.com>
3906
3907 * tui/tui-data.h (tui_init_content_element): Don't declare.
3908
6f6ffbeb
TT
39092019-06-19 Tom Tromey <tom@tromey.com>
3910
3911 * tui/tui-data.h (tui_init_win_info): Don't declare.
3912
f23f598e
TV
39132019-06-19 Tom de Vries <tdevries@suse.de>
3914
3915 * dwarf2read.h (abstract_to_concrete): Change type to
3916 std::unordered_map<sect_offset, std::vector<sect_offset>,
3917 gdb::hash_enum<sect_offset>>.
3918
680e1bee
TT
39192019-06-19 Tom Tromey <tromey@adacore.com>
3920
3921 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
3922 EVAL_AVOID_SIDE_EFFECTS specially.
3923
dcf37923
TT
39242019-06-19 Tom Tromey <tromey@adacore.com>
3925
3926 * source-cache.c (highlighter): New global.
3927 (source_cache::get_source_lines): Create a highlighter on demand.
3928
494986d5
AB
39292019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
3930
3931 * defs.h (deprecated_interactive_hook): Delete declaration.
3932 * interps.c (clear_interpreter_hooks): Remove use of
3933 deprecated_interactive_hook.
3934 * top.c (deprecated_interactive_hook): Delete definition.
3935 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
3936
3360b6e7
TV
39372019-06-18 Tom de Vries <tdevries@suse.de>
3938
3939 PR gdb/24515
3940 * dwarf2read.h (abstract_to_concrete): Change type from
3941 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
3942 std::unordered_map<sect_offset, std::vector<sect_offset>>.
3943 * dwarf2read.c (read_variable): Update.
3944 (dwarf2_fetch_die_loc_sect_off): Update.
3945
310b3441
TV
39462019-06-17 Tom de Vries <tdevries@suse.de>
3947
3948 PR gdb/24617
3949 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
3950 accessing parent[parent_len - 1].
3951
ba9777be
PP
39522019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
3953
3954 PR gdb/24364
3955 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
3956 call dtrace_process_dof with NULL dof.
3957
2b9f6e89
TV
39582019-06-16 Tom de Vries <tdevries@suse.de>
3959
3960 PR gdb/24445
3961 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
3962
431b3ead
TT
39632019-06-16 Tom Tromey <tom@tromey.com>
3964
3965 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3966 (make_all_visible): Use address of member.
3967
d04b44a1
TT
39682019-06-16 Tom Tromey <tom@tromey.com>
3969
3970 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
3971 (tui_free_window, free_content, free_content_elements): Remove
3972 unnecessary cast.
3973 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
3974 cast.
3975 * tui/tui-regs.c (tui_show_register_group)
3976 (tui_display_registers_from, tui_display_reg_element_at_line):
3977 Remove unnecessary cast.
3978
bf5142e7
AB
39792019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
3980
3981 * linux-nat.c (normal_mask): Delete.
3982 (_initialize_linux_nat): Don't initialise normal_mask.
3983
c4973306
SM
39842019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
3985
3986 PR gdb/24445
3987 * dwarf-index-write.h (write_psymtabs_to_index): Add
3988 dwz_basename parameter.
3989 * dwarf-index-write.c (write_gdbindex): Move file writing to
3990 write_gdbindex_1. Change return type void.
3991 (assert_file_size): Move up, remove filename parameter.
3992 (write_gdbindex_1): New function.
3993 (write_debug_names): Change return type to void, call
3994 assert_file_size.
3995 (struct index_wip_file): New struct.
3996 (write_psymtabs_to_index): Add dwz_basename parameter. Move
3997 file logic to index_wip_file. Write index for dwz file if
3998 needed.
3999 (save_gdb_index_command): Pass basename of dwz file, if present.
4000 * dwarf-index-cache.c (index_cache::store): Obtain and pass
4001 build-id of dwz file, if present.
4002 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4003 (dwarf2_get_dwz_file): Likewise.
4004 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4005 (dwarf2_get_dwz_file): Likewise.
4006
395f9c91
TT
40072019-06-16 Tom Tromey <tom@tromey.com>
4008
4009 * coffread.c (process_coff_symbol): Use xstrdup.
4010 * value.c (create_internalvar): Use xstrdup.
4011
cafb3438
TT
40122019-06-16 Tom Tromey <tom@tromey.com>
4013
4014 * valops.c (value_cast, value_slice): Remove unnecessary cast.
4015 * breakpoint.c (stopin_command, stopat_command)
4016 (until_break_command, decode_location_default): Remove unnecessary
4017 cast.
4018 * utils.c (subset_compare): Remove unnecessary cast.
4019 * ada-lang.c (ada_update_initial_language): Remove unnecessary
4020 cast.
4021 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4022 cast.
4023 * infcmd.c (path_command): Remove unnecessary cast.
4024 * coffread.c (decode_type): Remove unnecessary cast.
4025 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4026 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4027 * tui/tui-stack.c (tui_show_locator_content)
4028 (tui_show_frame_info): Remove unnecessary cast.
4029 * tui/tui-win.c (tui_scroll_forward_command)
4030 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4031 (parse_scrolling_args): Remove unnecessary cast.
4032 * tui/tui-data.c (init_win_info, tui_del_window)
4033 (tui_free_window, tui_del_data_windows, tui_free_data_content)
4034 (free_content_elements): Remove unnecessary cast.
4035 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4036 unnecessary cast.
4037 * tui/tui-source.c (tui_set_source_content)
4038 (tui_vertical_source_scroll): Remove unnecessary cast.
4039 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4040 cast.
4041 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4042 * tui/tui-regs.c (tui_display_registers_from)
4043 (tui_display_register): Remove unnecessary cast.
4044 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4045 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4046 (make_visible): Remove unnecessary cast.
4047 * tui/tui-winsource.c (tui_erase_source_content)
4048 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4049 unnecessary cast.
4050 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4051 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4052 * stabsread.c (read_type, read_array_type, read_range_type):
4053 Remove unnecessary cast.
4054 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4055 (parse_symbol, parse_type, upgrade_type, parse_external)
4056 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4057 unnecessary cast.
4058 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4059
730ead81
TT
40602019-06-16 Tom Tromey <tom@tromey.com>
4061
4062 * tui/tui-data.c (tui_alloc_generic_win_info)
4063 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4064 checks.
4065
584a927c
AB
40662019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
4067 Andrew Burgess <andrew.burgess@embecosm.com>
4068
4069 * f-typeprint.c (f_print_type): Don't return early for not
4070 associated or not allocated types.
4071 (f_type_print_varspec_suffix): Add print_rank parameter and print
4072 ranks of array types in case they dangling.
4073 (f_type_print_base): Add print_rank parameter.
4074
30056ea0
AB
40752019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4076
4077 * NEWS: Mention new MI commands.
4078 * break-catch-throw.c (enum exception_event_kind): Move to
4079 breakpoint.h.
4080 (print_mention_exception_catchpoint): Output text as a single
4081 message.
4082 (catch_exception_command_1): Rename to...
4083 (catch_exception_event): ...this, make non-static, update header
4084 command, and change some parameter types.
4085 (catch_catch_command): Update for changes to
4086 catch_exception_command_1.
4087 (catch_throw_command): Likewise.
4088 (catch_rethrow_command): Likewise.
4089 * breakpoint.c (enum exception_event_kind): Delete.
4090 * breakpoint.h (enum exception_event_kind): Moved here from
4091 break-catch-throw.c.
4092 (catch_exception_event): Declare.
4093 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4094 (mi_cmd_catch_throw): New function.
4095 (mi_cmd_catch_rethrow): New function.
4096 (mi_cmd_catch_catch): New function.
4097 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4098 'catch-catch' entries.
4099 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4100 (mi_cmd_catch_rethrow): Declare.
4101 (mi_cmd_catch_catch): Declare.
4102
ec8e2b6d
AB
41032019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4104
4105 * annotate.c (annotate_source_line): Change return type to void,
4106 update implementation to match.
4107 * annotate.h (annotate_source_line): Change return type to void,
4108 update header comment.
4109 * stack.c (print_frame_info): Don't change what frame information
4110 is printed based on whether annotations are on or not.
4111
0d3abd8c
AB
41122019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4113
4114 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4115 (annotate_source): Make static.
4116 (annotate_source_line): Moved from source.c and renamed from
4117 identify_source_line. Update the return type.
4118 * annotate.h (annotate_source): Delete declaration.
4119 (annotate_source_line): Declaration moved from source.h, and
4120 renamed from identify_source_line. Return type updated.
4121 * source.c (identify_source_line): Moved to annotate.c and renamed
4122 to annotate_source_line.
4123 (info_line_command): Remove check of annotation_level.
4124 * source.h (identify_source_line): Move declaration to annotate.h
4125 and rename to annotate_source_line.
4126 * stack.c: Add 'annotate.h' include.
4127 (print_frame_info): Remove check of annotation_level before
4128 calling annotate_source_line.
4129
00df30ae
AB
41302019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4131
4132 * source-cache.c (source_cache::get_plain_source_lines): Use
4133 open_source_file_with_line_charpos instead of just
4134 open_source_file, remove call to find_source_lines.
4135 (source_cache::get_source_lines): Likewise.
4136 * source.c (find_source_lines): Make static.
4137 (get_filename_and_charpos): Renamed into...
4138 (open_source_file_with_line_charpos): ..this along with changes to
4139 return a scoped_fd, and some other minor clean ups.
4140 (identify_source_line): Use open_source_file_with_line_charpos.
4141 (search_command_helper): Use open_source_file_with_line_charpos
4142 instead of just open_source_file, remove call to
4143 find_source_lines.
4144 * source.h (open_source_file_with_line_charpos): Declare new
4145 function.
4146 (find_source_lines): Delete declaration.
4147
afda45a2
AB
41482019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
4149
4150 * source.c (get_filename_and_charpos): Remove fullname
4151 parameter.
4152 (identify_source_line): Update call to get_filename_and_charpos.
4153
0735b091
TT
41542019-06-14 Tom Tromey <tromey@adacore.com>
4155
4156 PR gdb/24502:
4157 * ui-style.h (skip_ansi_escape): Update comment.
4158 * ui-file.h (class no_terminal_escape_file): New class.
4159 * ui-file.c (no_terminal_escape_file::write)
4160 (no_terminal_escape_file::puts): New methods.
4161 * cli/cli-logging.c (handle_redirections): Use
4162 no_terminal_escape_file.
4163
52ce35e2
TT
41642019-06-14 Tom Tromey <tromey@adacore.com>
4165
4166 * NEWS: Move convenience variable news above Python news.
4167
73cc7272
TT
41682019-06-14 Tom Tromey <tom@tromey.com>
4169
4170 * gnulib: Move directory to top-level.
4171 * configure.ac: Don't configure gnulib.
4172 * configure: Rebuild.
4173 * common/common-defs.h: Use new path to gnulib.
4174 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4175 (GNULIB_H): Remove.
4176 (INCGNU): Look in new gnulib location.
4177 (HFILES_NO_SRCDIR): Remove gnulib files.
4178 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4179 (generated_files): Remove GNULIB_H.
4180 ($(LIBGNU), all-lib): Remove targets.
4181 (distclean): Don't mention GNULIB_BUILDDIR.
4182 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4183
f5686554
TT
41842019-06-14 Tom Tromey <tromey@adacore.com>
4185
4186 * symfile.c (add_symbol_file_command): Remove obsolete comment.
4187 Warn if symbol file does not provide any symbols.
4188
a0c1ffed
TT
41892019-06-14 Tom Tromey <tromey@adacore.com>
4190
4191 * source.c (find_and_open_source): Respect basenames_may_differ.
4192
7c39e397
AB
41932019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
4194
4195 * annotate.c (annotate_breakpoints_invalid): Make use of
4196 scoped_restore_terminal_state.
4197 (annotate_frames_invalid): Likewise.
4198
f411722c
TT
41992019-06-14 Tom Tromey <tromey@adacore.com>
4200
4201 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4202 allow assignment to an internalvar.
4203
4268ec18
TT
42042019-06-14 Tom Tromey <tromey@adacore.com>
4205
4206 * ada-lex.l: Allow "_" in attribute names.
4207
abdb711e
TT
42082019-06-14 Tom Tromey <tromey@adacore.com>
4209
4210 PR gdb/24653:
4211 * regcache.c (registers_changed): Don't call alloca.
4212 * top.c (execute_command): Don't call alloca.
4213
4c048731
PA
42142019-06-13 Pedro Alves <palves@redhat.com>
4215
4216 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4217 'expression'. When parsing an expression, error out if there's
4218 junk after "unlimited".
4219 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4220 (do_set_command): Adjust calls to is_unlimited_literal.
4221
66eb1ed3
PA
42222019-06-13 Pedro Alves <palves@redhat.com>
4223
4224 * compile/compile.c (make_compile_options_def_group): Add braces
4225 around array_view initializer.
4226 * thread.c (make_thread_apply_all_options_def_group)
4227 (make_thread_apply_all_options_def_group): Likewise.
4228
3345721a
PA
42292019-06-13 Pedro Alves <palves@redhat.com>
4230
4231 * NEWS (New commands): Mention "maint test-options
4232 require-delimiter", "maint test-options unknown-is-error", "maint
4233 test-options unknown-is-operand" and "maint show
4234 test-options-completion-result".
4235 (New command options, command completion): New section.
4236 (Completion improvements): New section.
4237 Mention that you can abbreviate "unlimited".
4238
6206060d
PA
42392019-06-13 Pedro Alves <palves@redhat.com>
4240
4241 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4242 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4243 * unittests/cli-utils-selftests.c (test_parse_flags)
4244 (test_parse_flags_qcs): Delete.
4245 (test_cli_utils): Don't call deleted functions.
4246
6665660a
PA
42472019-06-13 Pedro Alves <palves@redhat.com>
4248
4249 * thread.c: Include "cli/cli-option.h".
4250 (tp_array_compar_ascending): Global.
4251 (tp_array_compar): Delete function.
4252 (tp_array_compar_ascending, tp_array_compar_descending): New
4253 functions.
4254 (ascending_option_def, qcs_flag_option_def)
4255 (thr_qcs_flags_option_defs)
4256 (make_thread_apply_all_options_def_group)
4257 (make_thread_apply_options_def_group): New.
4258 (thread_apply_all_command): Use gdb::option::process_options.
4259 (thread_apply_command_completer)
4260 (thread_apply_all_command_completer): New.
4261 (thread_apply_command): Use gdb::option::process_options.
4262 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4263 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
4264 to generate help text of "thread apply". Adjust "taas"'s help.
4265 * tid-parse.c (tid_range_parser::in_thread_range): New method.
4266 * tid-parse.h (tid_range_parser::in_thread_range): New method.
4267
f7e13587
PA
42682019-06-13 Pedro Alves <palves@redhat.com>
4269
4270 * thread.c (thread_apply_command): Check for invalid TID with
4271 isdigit instead of !isalpha.
4272
5d707134
PA
42732019-06-13 Pedro Alves <palves@redhat.com>
4274
4275 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4276 (validate_flags_qcs): New.
4277 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4278 (validate_flags_qcs): Declare.
4279 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4280 (make_frame_apply_options_def_group): New.
4281 (frame_apply_command_count): Process options with
4282 gdb::option::process_options.
4283 (frame_apply_completer): New.
4284 (frame_apply_level_completer, frame_apply_all_completer)
4285 (frame_apply_completer): New.
4286 (_initialize_stack): Update help of "frame apply", "frame apply
4287 level", "frame apply all" and "faas" to mention supported options
4288 and install command completers.
4289 * stack.h (frame_apply_all_completer): Declare.
4290 * thread.c: Include "stack.h".
4291 (tfaas_command): Add "--".
4292 (_initialize_thread): Update help "tfaas" to mention supported
4293 options and install command completer.
4294
272d4594
PA
42952019-06-13 Pedro Alves <palves@redhat.com>
4296
4297 * completer.c (complete_nested_command_line): New.
4298 (gdb_completion_word_break_characters_throw): Add assertion.
4299 * completer.h (complete_nested_command_line): Declare.
4300
90a1ef87
PA
43012019-06-13 Pedro Alves <palves@redhat.com>
4302
4303 * stack.c (parse_backtrace_qualifiers): New.
4304 (backtrace_command): Use it.
4305 (backtrace_command_completer): Complete on qualifiers.
4306
d4c16835
PA
43072019-06-13 Pedro Alves <palves@redhat.com>
4308
4309 * frame.c: Include "cli/cli-option.h.
4310 (user_set_backtrace_options): New.
4311 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4312 Delete.
4313 (get_prev_frame): Adjust.
4314 (boolean_option_def, uinteger_option_def)
4315 (set_backtrace_option_defs): New.
4316 (_initialize_frame): Adjust and use
4317 gdb::option::add_setshow_cmds_for_options to install "set
4318 backtrace past-main" and "set backtrace past-entry".
4319 * frame.h: Include "cli/cli-option.h".
4320 (struct frame_print_options): Forward declare.
4321 (print_frame_arguments_all, print_frame_arguments_scalars)
4322 (print_frame_arguments_none): Declare.
4323 (print_entry_values): Delete declaration.
4324 (struct frame_print_options, user_frame_print_options): New.
4325 (struct set_backtrace_options): New.
4326 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4327 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4328 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4329 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4330 (list_args_or_locals): Add frame_print_options parameter.
4331 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4332 * python/py-framefilter.c (enumerate_args): Pass down
4333 USER_FRAME_PRINT_OPTIONS.
4334 * stack.c: Include "cli/cli-option.h".
4335 (print_frame_arguments_all, print_frame_arguments_scalars)
4336 (print_frame_arguments_none): Declare.
4337 (print_raw_frame_arguments, print_entry_values): Delete.
4338 (user_frame_print_options): New.
4339 (boolean_option_def, enum_option_def, frame_print_option_defs):
4340 New.
4341 (struct backtrace_cmd_options): New.
4342 (bt_flag_option_def): New.
4343 (backtrace_command_option_defs): New.
4344 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4345 (print_frame_arg, read_frame_arg, print_frame_args)
4346 (print_frame_info, print_frame): Add frame_print_options parameter
4347 and use it.
4348 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4349 (backtrace_command_1): Add frame_print_options and
4350 backtrace_cmd_options parameters and use them.
4351 (make_backtrace_options_def_group): New.
4352 (backtrace_command): Process command options with
4353 gdb::option::process_options.
4354 (backtrace_command_completer): New.
4355 (_initialize_stack): Extend "backtrace"'s help to mention
4356 supported options. Install completer for "backtrace".
4357 Install some settings commands with add_setshow_cmds_for_options.
4358
2daf894e
PA
43592019-06-13 Pedro Alves <palves@redhat.com>
4360
4361 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4362 and that "set/show print raw frame-arguments" are now deprecated.
4363
4364 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4365 command.
4366 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4367 * stack.c (_initialize_stack): Install "set/show print
4368 raw-frame-arguments", and deprecate "set/show print raw
4369 frame-arguments".
4370 * valprint.c (_initialize_valprint): Deprecate "set/show print
4371 raw".
4372
e6ed716c
PA
43732019-06-13 Pedro Alves <palves@redhat.com>
4374
4375 * compile/compile.c (struct compile_options): New.
4376 (compile_flag_option_def, compile_command_option_defs)
4377 (make_compile_options_def_group): New.
4378 (compile_file_command): Handle options with
4379 gdb::option::process_options.
4380 (compile_file_command_completer): New function.
4381 (compile_code_command): Handle options with
4382 gdb::option::process_options.
4383 (compile_code_command_completer): New function.
4384 (_initialize_compiler): Install completers for "compile code" and
4385 "compile file". Mention available options in "compile code" and
4386 "compile code"'s help.
4387 * completer.c (advance_to_completion_word): New, factored out from
4388 ...
4389 (advance_to_expression_complete_word_point): ... this.
4390 (advance_to_filename_complete_word_point): New.
4391 * completer.h (advance_to_filename_complete_word_point): New
4392 declaration.
4393
7d8062de
PA
43942019-06-13 Pedro Alves <palves@redhat.com>
4395
4396 * compile/compile.c: Include "cli/cli-option.h".
4397 (compile_print_value): Scope data pointer is now a
4398 value_print_options pointer; adjust.
4399 (compile_print_command): Process options. Scope data pointer is
4400 now a value_print_options pointer; adjust.
4401 (_initialize_compile): Update "compile print"'s help to include
4402 supported options. Install a completer for "compile print".
4403 * cp-valprint.c (show_vtblprint, show_objectprint)
4404 (show_static_field_print): Delete.
4405 (_initialize_cp_valprint): Don't install "set print
4406 static-members", "set print vtbl", "set print object" here.
4407 * printcmd.c: Include "cli/cli-option.h" and
4408 "common/gdb_optional.h".
4409 (print_command_parse_format): Rework to fill in a
4410 value_print_options instead of a format_data.
4411 (print_value): Change parameter type from format_data pointer to
4412 value_print_options reference. Adjust.
4413 (print_command_1): Process options. Adjust to pass down a
4414 value_print_options.
4415 (print_command_completer): New.
4416 (_initialize_printcmd): Install print_command_completer as
4417 handle_brkchars completer for the "print" command. Update
4418 "print"'s help to include supported options.
4419 * valprint.c: Include "cli/cli-option.h".
4420 (show_vtblprint, show_objectprint, show_static_field_print): Moved
4421 here from cp-valprint.c.
4422 (boolean_option_def, uinteger_option_def)
4423 (value_print_option_defs, make_value_print_options_def_group):
4424 New. Use gdb::option::add_setshow_cmds_for_options to install
4425 "set print elements", "set print null-stop", "set print repeats",
4426 "set print pretty", "set print union", "set print array", "set
4427 print address", "set print symbol", "set print array-indexes".
4428 * valprint.h: Include <string> and "cli/cli-option.h".
4429 (make_value_print_options_def_group): Declare.
4430 (print_value): Change parameter type from format_data pointer to
4431 value_print_options reference.
4432 (print_command_completer): Declare.
4433
9d0faba9
PA
44342019-06-13 Pedro Alves <palves@redhat.com>
4435
4436 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4437 (COMMON_SFILES): Add maint-test-settings.c.
4438 * cli/cli-decode.c (boolean_enums): New global, factored out from
4439 ...
4440 (add_setshow_boolean_cmd): ... here.
4441 * cli/cli-decode.h (boolean_enums): Declare.
4442 * cli/cli-option.c: New file.
4443 * cli/cli-option.h: New file.
4444 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4445 factored out from ...
4446 (parse_cli_boolean_value(const char *)): ... this.
4447 (is_unlimited_literal): Change parameter type to pointer to
4448 pointer. Adjust and advance ARG pointer.
4449 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4450 (parse_cli_var_enum): New, factored out from ...
4451 (do_set_command): ... this. Adjust.
4452 * cli/cli-setshow.h (parse_cli_boolean_value)
4453 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4454 (parse_cli_var_enum): Declare.
4455 * cli/cli-utils.c: Include "cli/cli-option.h".
4456 (get_ulongest): New.
4457 * cli/cli-utils.h (get_ulongest): Declare.
4458 (check_for_argument): New overloads.
4459 * maint-test-options.c: New file.
4460
2c722807
PA
44612019-06-13 Pedro Alves <palves@redhat.com>
4462
4463 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4464 parse a range if "-" is at the end of the string.
4465
dee7b4c8
PA
44662019-06-13 Pedro Alves <palves@redhat.com>
4467
4468 * cli/cli-setshow.c (parse_auto_binary_operation)
4469 (parse_cli_boolean_value): Don't allow "o".
4470
dca0f6c0
PA
44712019-06-13 Pedro Alves <palves@redhat.com>
4472
4473 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4474 * NEWS: Mention maint test-settings KIND.
4475 * maint-test-settings.c: New file.
4476
597bf39d
PA
44772019-06-13 Pedro Alves <palves@redhat.com>
4478
4479 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
4480 completer.
4481 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
4482 "set" completers.
4483
48c410fb
PA
44842019-06-13 Pedro Alves <palves@redhat.com>
4485
4486 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
4487 after item.
4488
93bcb043
PA
44892019-06-13 Pedro Alves <palves@redhat.com>
4490
4491 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
4492
cbba3ecd
PA
44932019-06-13 Pedro Alves <palves@redhat.com>
4494
4495 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
4496 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
4497 call.
4498 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
4499 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
4500 calls.
4501 (check_for_argument): Skip spaces after argument.
4502
b9a3f842
PA
45032019-06-13 Pedro Alves <palves@redhat.com>
4504
4505 * thread.c (thread_apply_command): Adjust TID parsing.
4506 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
4507 detected before end of string.
4508 (tid_is_in_list): Error out if LIST is invalid.
4509
3844e605
PA
45102019-06-13 Pedro Alves <palves@redhat.com>
4511
4512 * completer.c (complete_line_internal_1): Rewind completion word
4513 point.
4514 (completion_tracker::advance_custom_word_point_by): Change
4515 parameter type to int.
4516 * completer.h (completion_tracker::advance_custom_word_point_by):
4517 Likewise.
4518
00b56dbe
PA
45192019-06-13 Pedro Alves <palves@redhat.com>
4520
4521 * completer.c (advance_to_completion_word): Handle delimiters.
4522
d106773e
PA
45232019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
4524
4525 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
4526
08f10e02
TT
45272019-06-11 Tom Tromey <tom@tromey.com>
4528
4529 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
4530 (xmalloc_failed): Move to alloc.c.
4531 * alloc.c: New file.
4532 * Makefile.in (COMMON_SFILES): Add alloc.c.
4533
1c7fe951
TT
45342019-06-11 Tom Tromey <tom@tromey.com>
4535
4536 * nat/linux-waitpid.c: Don't include server.h.
4537 (linux_debug): Remove.
4538 (my_waitpid): Update.
4539
89549d7f
TT
45402019-06-11 Tom Tromey <tromey@adacore.com>
4541
4542 * infcall.c (_initialize_infcall): Remove trailing newline from
4543 help.
4544 * user-regs.c (_initialize_user_regs): Remove trailing newline
4545 from help.
4546 * typeprint.c (_initialize_typeprint): Remove trailing newline
4547 from help.
4548 * reverse.c (_initialize_reverse): Remove trailing newlines from
4549 help.
4550 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
4551 from help.
4552 * language.c (add_set_language_command): Remove trailing newline
4553 from help.
4554 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
4555 help.
4556 * disasm.c (_initialize_disasm): Remove trailing newline from
4557 help.
4558 * top.c (init_main): Remove trailing newline from help.
4559 * interps.c (_initialize_interpreter): Remove trailing newline
4560 from help.
4561 * btrace.c (_initialize_btrace): Remove trailing newlines from
4562 help.
4563 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
4564 from help.
4565 * python/python.c (_initialize_python): Remove trailing newline
4566 from help.
4567 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
4568 help.
4569 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
4570 from help. Reformat some text.
4571 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
4572 from help.
4573 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
4574 newline from help.
4575
86108c13
TT
45762019-06-11 Tom Tromey <tromey@adacore.com>
4577
4578 * darwin-nat.c (darwin_decode_exception_message)
4579 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
4580
a7067863
AB
45812019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
4582
4583 * valops.c (value_slice): Check for not allocated or not
4584 associated values.
4585
9ab08412
TV
45862019-06-10 Tom de Vries <tdevries@suse.de>
4587
4588 PR gdb/24618
4589 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
4590 sure an empty slot (defined by a 32-bit zero pair) is recognized as
4591 invalid.
4592
f19e22e9
TV
45932019-06-10 Tom de Vries <tdevries@suse.de>
4594
4595 PR gdb/24611
4596 * linespec.c (linespec_lexer_lex_string): Remove incorrect
4597 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
4598
e99f9db0
TV
45992019-06-10 Tom de Vries <tdevries@suse.de>
4600
4601 PR symtab/24545
4602 * symtab.c (struct demangled_name_entry): Add language field.
4603 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
4604 static minimal symbol". Set and use language field.
4605
9bf7038b
TT
46062019-06-10 Tom Tromey <tromey@adacore.com>
4607
4608 * ada-lang.c (_initialize_ada_language): Update help text.
4609
422186a9
TT
46102019-06-10 Tom Tromey <tromey@adacore.com>
4611
4612 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
4613 with a newline.
4614 * guile/guile.c (handle_boot_error): Don't end warning with a
4615 newline.
4616 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
4617 warning with a newline.
4618 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
4619 newline.
4620 (s12z_frame_cache): Likewise.
4621 * dwarf-index-cache.c (index_cache::store): Don't end warning with
4622 a newline.
4623 * solib-svr4.c (disable_probes_interface): Don't end warning with
4624 a newline.
4625 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
4626 newline.
4627 * python/python.c (do_finish_initialization): Don't end warning
4628 with a newline.
4629
25ce02ee
TT
46302019-06-10 Tom Tromey <tom@tromey.com>
4631
4632 * python/py-breakpoint.c (gdbpy_breakpoint_created)
4633 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
4634 gdbpy_enter.
4635
caa429d8
TT
46362019-06-10 Tom Tromey <tromey@adacore.com>
4637
4638 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
4639 data.
4640 (elf_new_init): Don't call stabsread_new_init.
4641 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
4642 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
4643 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
4644
81873cc8
TV
46452019-06-10 Tom de Vries <tdevries@suse.de>
4646
4647 PR symtab/16264
4648 PR symtab/24517
4649 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
4650
4fa0265e
РИ
46512019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
4652
4653 * source.c (find_and_open_source): Also rewrite relative file
4654 names.
4655
1a3da2cd
AB
46562019-04-26 Amos Bird <amosbird@gmail.com>
4657
4658 * annotate.c (annotate_thread_exited): Add "thread-exited"
4659 annotation.
4660
3847a7bf
TT
46612019-06-06 Tom Tromey <tromey@adacore.com>
4662
4663 * maint.h (class scoped_command_stats): Use
4664 DISABLE_COPY_AND_ASSIGN.
4665 <print_time>: New method.
4666 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
4667 print_time.
4668 (scoped_command_stats::print_time): New method.
4669
312617a3
AB
46702019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
4671
4672 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
4673 instructions of lengths 6 or 8 bytes.
4674
b02f78f9
PA
46752019-06-04 Pedro Alves <palves@redhat.com>
4676
4677 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
4678
4679 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
4680 * breakpoint.c (condition_completer): Likewise.
4681 * cli/cli-dump.c (scan_expression): Likewise.
4682 * common/filestuff.c (mkdir_recursive): Likewise.
4683 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
4684 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
4685 (gdb_abspath): Likewise.
4686 * compile/compile-cplus-types.c
4687 (compile_cplus_instance::decl_name): Likewise.
4688 * completer.c (complete_explicit_location):
4689 (signal_completer, reg_or_group_completer_1): Likewise.
4690 * cp-support.c (cp_remove_params_if_any): Likewise.
4691 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
4692 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
4693 * infcmd.c (strip_bg_char): Likewise.
4694 * linespec.c (copy_token_string): Likewise.
4695 * mi/mi-main.c (output_cores): Likewise.
4696 * psymtab.c (psymtab_search_name):
4697 * symfile.c (test_set_ext_lang_command): Likewise.
4698 * target.c (target_fileio_read_stralloc): Likewise.
4699 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
4700 * value.c (complete_internalvar): Likewise.
4701
e1f2e1a2
CB
47022019-06-04 Christian Biesinger <cbiesinger@google.com>
4703
4704 Add objfile property to gdb.Type.
d3238f7d
PA
4705 * NEWS: Mention Python API addition.
4706 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 4707
e664d728
PW
47082019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4709
4710 * NEWS: Mention the new set|show style [title|highlight].
4711 Mention changes to "show style", "help" and "apropos".
4712
66d8c862
PW
47132019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4714
4715 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
4716 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
4717 instead of print_help_for_command.
4718 (print_doc_of_command): New function.
4719 (help_list): Add 'apropos -v word' suggestion.
4720 (print_help_for_command): Style the command name using title style.
4721 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
4722 (_initialize_cli_cmds): Describe -v in apropos_command help.
4723
9303eb2f
PW
47242019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4725
4726 * cli/cli-style.h (cli_style_option): Add name in constructor,
4727 add m_name class member, add constructor with intensity,
4728 add name class function.
4729 (cli_style_option::add_setshow_commands): Remove name argument.
4730 (highlight_style, title_style): New styles.
4731 * cli/cli-style.c (do_show): New function that shows a style
4732 characteristic styling the style name with itself.
4733 (set_style_name): New function.
4734 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
4735 Update all callers according to the changes in cli/cli-style.h.
4736 * utils.h (fputs_highlighted): New function.
4737 * utils.c (fputs_highlighted): Likewise.
4738
e2c52041
PW
47392019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4740
4741 * NEWS: Mention new pipe command and new convenience variables.
4742
947d3946
PW
47432019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4744
4745 * cli/cli-cmds.c (pipe_command): New function.
4746 (_initialize_cli_cmds): Call add_com for pipe_command.
4747 Define | as an alias for pipe.
4748 (exit_status_set_internal_vars): New function.
4749 (shell_escape): Call exit_status_set_internal_vars.
4750 cli/cli-decode.c (find_command_name_length): Recognize | as
4751 a single character command.
4752
b8fd0918
PW
47532019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4754
4755 * gdbcmd.h (execute_command_to_ui_file): New declaration.
4756 top.c (execute_command_to_ui_file): New function, mostly a copy
4757 of execute_command_to_string.
4758 (execute_command_to_string): Implement by calling
4759 execute_command_to_ui_file.
4760
68bb5386
PW
47612019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4762
4763 * top.h (saved_command_line): Remove declaration.
4764 * top.c (previous_saved_command_line, previous_repeat_arguments):
4765 New variables.
4766 (saved_command_line): Make static, define together with other
4767 'repeat variables'.
4768 (dont_repeat): Clear repeat_arguments.
4769 (repeat_previous, get_saved_command_line, save_command_line):
4770 New functions.
4771 (gdb_init): Initialize saved_command_line
4772 and previous_saved_command_line.
4773 * main.c (captured_main_1): Remove saved_command_line initialization.
4774 * event-top.c (handle_line_of_input): Update to use
4775 the new 'repeat' related functions instead of direct access to
4776 saved_command_line.
4777 * command.h (repeat_previous, get_saved_command_line,
4778 save_command_line): New declarations.
4779 (dont_repeat): Add comment.
4780
bfcdb852
TT
47812019-05-30 Tom Tromey <tromey@adacore.com>
4782
4783 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
4784 Fix comment.
4785 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
4786
0ef209f2
JV
47872019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
4788
4789 PR cli/24587
4790 * completer.c (complete): Initialize variable word.
4791
955b06fa
SDJ
47922019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
4793
4794 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
4795 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
4796 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
4797 'body' is NULL to the outter 'if', protecting the '!is_define'
4798 situation as well.
4799
fa9c3fa0
TT
48002019-05-29 Tom Tromey <tromey@adacore.com>
4801
4802 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
4803 (dwarf_unknown): New function.
4804 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
4805 (dwarf_type_encoding_name): Use dwarf_unknown.
4806
4330d61d
TT
48072019-05-29 Tom Tromey <tromey@adacore.com>
4808
4809 PR c++/20020:
4810 * cp-valprint.c (cp_print_value_fields): Call
4811 cp_print_static_field inside "try".
4812
33a6bc35
TT
48132019-05-29 Tom Tromey <tromey@adacore.com>
4814
4815 * inflow.c (struct terminal_info): Add default operator=.
4816 * configure: Rebuild.
4817 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
4818 -Wdeprecated-copy-dtor, -Wredundant-move.
4819
000439d5
TT
48202019-05-29 Tom Tromey <tromey@adacore.com>
4821
4822 * NEWS: Add entry.
4823 * infcmd.c (print_return_value_1): Handle finish_print
4824 option.
4825 (show_print_finish): New function.
4826 (_initialize_infcmd): Add "set/show print finish" commands.
4827 * valprint.c (user_print_options): Initialize new member.
4828 * valprint.h (struct value_print_options) <finish_print>: New
4829 member.
4830
c0e70c62
TT
48312019-05-28 Tom Tromey <tromey@adacore.com>
4832
4833 * ada-lang.c (ada_remove_Xbn_suffix)
4834 (find_old_style_renaming_symbol)
4835 (parse_old_style_renaming): Remove.
4836 (ada_find_renaming_symbol): Don't call
4837 find_old_style_renaming_symbol.
4838 (ada_is_renaming_symbol): Rename from
4839 ada_find_renaming_symbol. Remove "block" parameter. Return
4840 bool. Now static.
4841 (ada_read_var_value): Update and simplify.
4842 * ada-exp.y (write_var_or_type): Remove old code.
4843
766f8836
AH
48442019-05-28 Alan Hayward <alan.hayward@arm.com>
4845
4846 * event-top.c: Remove include comment.
4847 * inflow.c (class scoped_ignore_sigttou): Move from here...
4848 * inflow.h (class scoped_ignore_sigttou): ...to here.
4849 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
4850 * top.c: Remove include comment.
4851
eb41253a
TT
48522019-05-27 Tom Tromey <tom@tromey.com>
4853
4854 * NEWS: Fix typo.
4855
4ca51187
TT
48562019-05-22 Tom Tromey <tromey@adacore.com>
4857
4858 * target.c (target_follow_exec): Constify parameter.
4859 * target-delegates.c: Rebuild.
4860 * remote.c (remote_target::follow_exec): Constify parameter.
4861 * infrun.c (follow_exec): Constify parameter.
4862 * target.h (struct target_ops) <follow_exec>: Constify parameter.
4863 (target_follow_exec): Likewise.
4864
8fca4da0
AH
48652019-05-22 Alan Hayward <alan.hayward@arm.com>
4866
4867 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
4868 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
4869
b7060614
AH
48702019-05-22 Alan Hayward <alan.hayward@arm.com>
4871
4872 * NEWS: Add debugredirect and testsuite sections.
4873
0a5954bd
SC
48742019-05-22 Simon Cook <simon.cook@embecosm.com>
4875
4876 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
4877 target descriptions using exclusively floating point register name
4878 aliases.
4879
dc42e902
AB
48802019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
4881
4882 PR gdb/18644:
4883 * f-lang.c (build_fortran_types): Handle the case where
4884 gdbarch_floatformat_for_type returns a nullptr.
4885
fb7806c7
TV
48862019-05-21 Tom de Vries <tdevries@suse.de>
4887
4888 PR cli/24587
4889 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
4890
34d11c68
AB
48912019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4892
4893 PR gdb/18644:
4894 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
4895 16-byte floats.
4896 * i386-tdep.c (i386_floatformat_for_type): Use
4897 floatformats_ia64_quad for the 16-byte floating point component
4898 within a fortran 32-byte complex number.
4899
122cf0f2
AB
49002019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
4901
4902 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
4903 delete default constructor.
4904 (find_partial_die): Update to return const struct.
4905 (partial_die_parent_scope): Move variable declaration into scope
4906 of its use and change its type to auto.
4907 (guess_partial_die_structure_name): Likewise.
4908 (partial_die_info::fixup): Likewise.
4909
33d0e35a
TT
49102019-05-17 Tom Tromey <tromey@adacore.com>
4911
4912 * source.c (find_and_open_source): Remove cast.
4913
a45575b0
TT
49142019-05-17 Tom Tromey <tromey@adacore.com>
4915
4916 * annotate.c (annotate_source): Make "filename" const.
4917 * annotate.h (annotate_source): Use const.
4918
81f47ac2
AH
49192019-05-17 Alan Hayward <alan.hayward@arm.com>
4920
4921 * disasm.c (set_disassembler_options): Send errors to stderr.
4922
ca1285d1
AH
49232019-05-17 Alan Hayward <alan.hayward@arm.com>
4924
4925 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
4926 (cli_interp_base::set_logging): Check debug_redirect.
4927 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
4928 * cli/cli-logging.c (debug_redirect): Add static variable.
4929 (pop_output_files): Add default param.
4930 (handle_redirections): Print debug setting.
4931 (show_logging_command): Likewise.
4932 (_initialize_cli_logging): Add debugredirect command.
4933 * interps.c (current_interp_set_logging): Add debug_redirect
4934 parameter.
4935 * interps.h (set_logging): Add debug_redirect parameter.
4936 (current_interp_set_logging): Likewise.
4937 * mi/mi-common.h: Likewise.
4938 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
4939
49402019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH
4941 Tom Tromey <tromey@adacore.com>
4942
4943 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
4944 directly.
4945 * cli/cli-interp.h (make_logging_output): Remove declaration.
4946 * cli/cli-logging.c (make_logging_output): Remove function.
4947 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
4948 directly.
4949 * ui-file.c (tee_file::tee_file): Remove bools.
4950 (tee_file::~tee_file): Remove deletes.
4951 * ui-file.h (tee_file): Remove bools.
4952
26648588
JV
49532019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
4954
4955 * mi/mi-cmds.h (mi_cmd_complete): New function.
4956 * mi/mi-main.c (mi_cmd_complete): Likewise.
4957 * mi/mi-cmds.c: Define new MI command -complete.
4958 * NEWS: Mention new -complete command.
4959
6e035501
JV
49602019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
4961
4962 * completer.h (complete): New function.
4963 * completer.c (complete): Likewise.
4964 * cli/cli-cmds.c: (complete_command): Update to use new complete()
4965 function defined in completer.h.
4966
7d0e2ece
JV
49672019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
4968
e79be6e5 4969 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 4970
fb816e8b
TV
49712019-05-17 Tom de Vries <tdevries@suse.de>
4972
4973 PR gdb/24094
4974 * dwarf2read.c (struct cu_partial_die_info): New struct.
4975 (find_partial_die): Return cu_partial_die_info.
4976 (partial_die_parent_scope, guess_partial_die_structure_name)
4977 (partial_die_info::fixup): Handle new return type of find_partial_die.
4978
677052f2
SDJ
49792019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4980
4981 * stap-probe.c (stap_parse_register_operand): Make "regname" an
4982 "std::string", simplifying the algorithm.
4983
f3da9116
SDJ
49842019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4985
4986 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
4987 (stap_static_probe_ops::get_probes): Likewise.
4988
f1bb75ab
SDJ
49892019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
4990
4991 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
4992 '-')" and "else if".
4993 (stap_parse_single_operand): Join checks for
4994 "gdbarch_stap_parse_special_token_p" and
4995 "gdbarch_stap_parse_special_token" in the same "if" statement.
4996 Invert check when verifying for operation on register
4997 displacement.
4998
3ca58cde
SDJ
49992019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5000
5001 * stap-probe.c (stap_get_opcode): Update comment.
5002 (stap_get_expected_argument_type): Likewise.
5003 (handle_stap_probe): Likewise.
5004
af2d9bee
SDJ
50052019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
5006
5007 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5008 return type to 'bool'. Adjust comment. Use 'bool' when
5009 appropriate.
5010 (i386_stap_parse_special_token_three_arg_disp): Likewise.
5011 * stap-probe.c (stap_parse_argument_1): Likewise.
5012 (stap_is_operator): Likewise.
5013 (stap_is_generic_prefix): Likewise.
5014 (stap_is_register_prefix): Likewise.
5015 (stap_is_register_indirection_prefix): Likewise.
5016 (stap_is_integer_prefix): Likewise.
5017 (stap_generic_check_suffix): Likewise.
5018 (stap_check_integer_suffix): Likewise.
5019 (stap_check_register_suffix): Likewise.
5020 (stap_check_register_indirection_suffix): Likewise.
5021 (stap_parse_register_operand): Likewise.
5022 (stap_parse_single_operand): Likewise.
5023 (stap_parse_argument_1): Likewise.
5024 (stap_probe::get_argument_count): Likewise.
5025 (stap_is_operator): Likewise.
5026
61c9c421
TT
50272019-05-16 Tom Tromey <tromey@adacore.com>
5028
5029 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5030 keyword to foreach.
5031
9ddc1af1
SM
50322019-05-15 Simon Marchi <simon.marchi@efficios.com>
5033
5034 * linux-thread-db.c (try_thread_db_load_1): Change return type
5035 to bool.
5036 (try_thread_db_load): Likewise.
5037 (try_thread_db_load_from_pdir_1): Likewise.
5038 (try_thread_db_load_from_pdir): Likewise.
5039 (try_thread_db_load_from_sdir): Likewise.
5040 (try_thread_db_load_from_dir): Likewise.
5041 (thread_db_load_search): Likewise.
5042 (has_libpthread): Likewise.
5043 (thread_db_load): Likewise.
5044
7bede828
SDJ
50452019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
5046
5047 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5048 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5049 NULL, and complain/return if that's the case.
5050
c5358db4
JD
50512019-05-15 John Darrington <john@darrington.wattle.id.au>
5052
5053 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5054 (advance, posn, abstract_read_memory): New functions.
5055 [struct mem_read_abstraction]: New struct.
5056 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5057
c408a94f
TT
50582019-05-14 Tom Tromey <tromey@adacore.com>
5059
5060 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5061 value is not lval_memory.
5062
e7bd7fba
TT
50632019-05-14 Tom Tromey <tromey@adacore.com>
5064
5065 * solib.c (info_sharedlibrary_command): Style the file name.
5066
a6d0f249
AH
50672019-05-14 Alan Hayward <alan.hayward@arm.com>
5068
5069 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5070 (aarch64_vnv_type): Likewise.
5071 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5072 * common/tdesc.c: Likewise.
5073 * common/tdesc.h (enum tdesc_type_kind): Likewise.
5074 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5075 * features/aarch64-fpu.xml: Add ieee half view.
5076 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5077 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5078 * gdbtypes.h (struct builtin_type): Likewise.
5079 (struct objfile_type): Likewise.
5080
66b8bb74
SM
50812019-05-12 Paul Naert <paul.naert@polymtl.ca>
5082
5083 * language.c (language_sniff_from_mangled_name): Fix "langauge"
5084 typo.
5085 * location.h (string_to_event_location): Likewise.
5086
21c219fd
JB
50872019-05-11 Joel Brobecker <brobecker@adacore.com>
5088
5089 GDB 8.3 released.
5090
13674803
SM
50912019-05-10 Simon Marchi <simon.marchi@efficios.com>
5092
5093 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5094 New variable declaration.
5095 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5096 New variable.
5097 (print_one_breakpoint): Use ui_out::test_flags and new global
5098 variable to compute use_fixed_output.
5099 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5100 Remove.
5101 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5102 (mi_multi_location_breakpoint_output_fixed): Remove.
5103 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5104 new variable.
5105 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5106 fix_multi_location_breakpoint_output flag if version >= 3.
5107 * ui-out.h (enum ui_out_flag)
5108 <fix_multi_location_breakpoint_output>: New enumerator.
5109
a9eac7f9
SM
51102019-05-10 Simon Marchi <simon.marchi@efficios.com>
5111
5112 * contrib/cc-with-tweaks.sh: Validate dwz's work.
5113
71bed2db
TT
51142019-05-10 Tom Tromey <tromey@adacore.com>
5115
5116 * ada-lang.c (catch_ada_completer): New function.
5117 (_initialize_ada_language): Use it.
5118
24c54127
TT
51192019-05-10 Tom Tromey <tromey@adacore.com>
5120
5121 * thread.c (print_thread_info): Make "requested_threads" const.
5122 * gdbthread.h (print_thread_info): Make "requested_threads"
5123 const.
5124 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5125 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5126
7a102139
TT
51272019-05-08 Tom Tromey <tom@tromey.com>
5128
5129 * gdbtypes.c (objfile_type_data): Change type.
5130 (objfile_type, _initialize_gdbtypes): Update.
5131
924d79e2
TT
51322019-05-08 Tom Tromey <tom@tromey.com>
5133
5134 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5135 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5136 (_initialize_dwarf2_frame): Update.
5137
4c58e337
TT
51382019-05-08 Tom Tromey <tom@tromey.com>
5139
5140 * objc-lang.c (objc_objfile_data): Change type.
5141 (find_methods): Update.
5142 (_initialize_objc_lang): Remove.
5143
d772d2ab
TT
51442019-05-08 Tom Tromey <tom@tromey.com>
5145
5146 * stabsread.c (rs6000_builtin_type_data): Change type.
5147 (rs6000_builtin_type, _initialize_stabsread): Update.
5148
d11d83f4
TT
51492019-05-08 Tom Tromey <tom@tromey.com>
5150
5151 * mips-tdep.c (mips_pdr_data): Remove.
5152 (_initialize_mips_tdep): Update.
5153
9a73f0ad
TT
51542019-05-08 Tom Tromey <tom@tromey.com>
5155
5156 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5157 (hppa_init_objfile_priv_data, read_unwind_info)
5158 (find_unwind_entry, _initialize_hppa_tdep): Update.
5159
8127a2fa
TT
51602019-05-08 Tom Tromey <tom@tromey.com>
5161
5162 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5163 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
5164 on obstack.
5165 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5166
91d3055d
TT
51672019-05-08 Tom Tromey <tom@tromey.com>
5168
5169 * mdebugread.c (basic_type_data): Change type.
5170 (basic_type, _initialize_mdebugread): Update.
5171
31930bd3
TT
51722019-05-08 Tom Tromey <tom@tromey.com>
5173
5174 * common/gdb_unique_ptr.h (struct noop_deleter): New.
5175
bdb3ed9e
TT
51762019-05-08 Tom Tromey <tom@tromey.com>
5177
5178 * nto-tdep.c (nto_inferior_data_reg): Change type.
5179 (nto_inferior_data): Update.
5180 (nto_inferior_data_cleanup, nto_new_inferior_data)
5181 (_initialize_nto_tdep): Remove.
5182 * nto-tdep.h (struct nto_inferior_data): Add initializers.
5183
f37b313d
TT
51842019-05-08 Tom Tromey <tom@tromey.com>
5185
5186 * ada-lang.c (struct ada_inferior_data): Add initializers.
5187 (ada_inferior_data): Change type.
5188 (ada_inferior_data_cleanup): Remove.
5189 (get_ada_inferior_data, ada_inferior_exit)
5190 (struct ada_pspace_data): Add initializers, destructor.
5191 (ada_pspace_data_handle): Change type.
5192 (get_ada_pspace_data): Update.
5193 (ada_pspace_data_cleanup): Remove.
5194
24699405
TT
51952019-05-08 Tom Tromey <tom@tromey.com>
5196
5197 * coffread.c (struct coff_symfile_info): Add initializers.
5198 (coff_objfile_data_key): Move lower. Change type.
5199 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5200 Update.
5201 (coff_free_info): Remove.
5202
d4e05d2f
TT
52032019-05-08 Tom Tromey <tom@tromey.com>
5204
5205 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5206 (fbsd_pspace_data_handle): Move lower. Change type.
5207 (get_fbsd_pspace_data): Update.
5208 (fbsd_pspace_data_cleanup): Remove.
5209 (_initialize_fbsd_tdep): Update.
5210
14ef6690
TT
52112019-05-08 Tom Tromey <tom@tromey.com>
5212
5213 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5214 (get_ada_tasks_pspace_data): Update.
5215 (ada_tasks_pspace_data_cleanup): Remove.
5216 (_initialize_tasks): Update.
5217 (ada_tasks_inferior_data_handle): Change type.
5218 (get_ada_tasks_inferior_data): Update.
5219 (ada_tasks_inferior_data_cleanup): Remove.
5220 (struct ada_tasks_pspace_data): Add initializers.
5221
814cf43a
TT
52222019-05-08 Tom Tromey <tom@tromey.com>
5223
5224 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5225 * symfile-debug.c (debug_sym_get_probes): Change type.
5226 * stap-probe.c (handle_stap_probe):
5227 (stap_static_probe_ops::get_probes): Change type.
5228 * probe.h (class static_probe_ops) <get_probes>: Change type.
5229 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5230 (parse_probes_in_pspace): Update.
5231 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5232 Update.
5233 (any_static_probe_ops::get_probes): Change type.
5234 * elfread.c (elfread_data): New typedef.
5235 (probe_key): Change type.
5236 (elf_get_probes): Likewise. Update.
5237 (probe_key_free): Remove.
5238 (_initialize_elfread): Update.
5239 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5240 Change type.
5241 (dtrace_process_dof_probe, dtrace_process_dof)
5242 (dtrace_static_probe_ops::get_probe): Change type.
5243
02dc647e
TT
52442019-05-08 Tom Tromey <tom@tromey.com>
5245
5246 * xcoffread.c (struct xcoff_symfile_info): Rename from
5247 coff_symfile_info. Add initializers.
5248 (xcoff_objfile_data_key): Move lower. Change type.
5249 (XCOFF_DATA): Rewrite.
5250 (xcoff_free_info): Remove.
5251 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5252 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5253 (xcoff_initial_scan): Update.
5254
09232438
TT
52552019-05-08 Tom Tromey <tom@tromey.com>
5256
5257 * solib-svr4.c (struct svr4_info): Add initializers and
5258 destructor.
5259 <probes_table>: Now an htab_up.
5260 (solib_svr4_pspace_data): Change type.
5261 (free_probes_table): Simplify.
5262 (~svr4_info): Rename from svr4_pspace_data_cleanup.
5263 (get_svr4_info, probes_table_htab_remove_objfile_probes)
5264 (probes_table_remove_objfile_probes, register_solib_event_probe)
5265 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5266 (_initialize_svr4_solib): Update.
5267
7b4a314f
TT
52682019-05-08 Tom Tromey <tom@tromey.com>
5269
5270 * remote.c (remote_pspace_data): Change type.
5271 (remote_pspace_data_cleanup): Remove.
5272 (get_remote_exec_file, set_pspace_remote_exec_file)
5273 (_initialize_remote): Update.
5274
51d3063a
TT
52752019-05-08 Tom Tromey <tom@tromey.com>
5276
5277 * breakpoint.c (breakpoint_objfile_key): Change type.
5278 (get_breakpoint_objfile_data): Update.
5279 (free_breakpoint_objfile_data): Remove.
5280 (_initialize_breakpoint): Update.
5281
89fb8848
TT
52822019-05-08 Tom Tromey <tom@tromey.com>
5283
5284 * linux-tdep.c (struct linux_info): Add initializers.
5285 (linux_inferior_data): Move. Change type.
5286 (invalidate_linux_cache_inf): Update.
5287 (linux_inferior_data_cleanup): Remove.
5288 (get_linux_inferior_data, _initialize_linux_tdep): Update.
5289
e9b89e2d
TT
52902019-05-08 Tom Tromey <tom@tromey.com>
5291
5292 * auxv.c (auxv_inferior_data): Move. Change type.
5293 (auxv_inferior_data_cleanup): Remove.
5294 (invalidate_auxv_cache_inf): Rewrite.
5295 (get_auxv_inferior_data, _initialize_auxv): Update.
5296
8c42777c
TT
52972019-05-08 Tom Tromey <tom@tromey.com>
5298
5299 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5300 (symfile_debug_objfile_data_key): Change type.
5301 (symfile_debug_installed, debug_qf_has_symbols)
5302 (debug_qf_find_last_source_symtab)
5303 (debug_qf_forget_cached_source_info)
5304 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5305 (debug_qf_print_stats, debug_qf_dump)
5306 (debug_qf_expand_symtabs_for_function)
5307 (debug_qf_expand_all_symtabs)
5308 (debug_qf_expand_symtabs_with_fullname)
5309 (debug_qf_map_matching_symbols)
5310 (debug_qf_expand_symtabs_matching)
5311 (debug_qf_find_pc_sect_compunit_symtab)
5312 (debug_qf_map_symbol_filenames)
5313 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5314 (debug_sym_new_init, debug_sym_init, debug_sym_read)
5315 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5316 (debug_sym_read_linetable, debug_sym_relocate): Update.
5317 (symfile_debug_free_objfile): Remove.
5318 (install_symfile_debug_logging, _initialize_symfile_debug):
5319 Update.
5320
5bfd760d
TT
53212019-05-08 Tom Tromey <tom@tromey.com>
5322
5323 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5324 allocate_on_obstack.
5325 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5326 (get_dwarf2_per_objfile): Update.
5327 (set_dwarf2_per_objfile): Remove.
5328 (dwarf2_has_info, dwarf2_get_section_info): Update.
5329 (dwarf2_free_objfile): Remove.
5330 (_initialize_dwarf2_read): Update.
5331
e85e19b4
TT
53322019-05-08 Tom Tromey <tom@tromey.com>
5333
5334 * auto-load.c (struct auto_load_pspace_info): Add destructor and
5335 initializers.
5336 <unsupported_script_warning_printed,
5337 script_not_found_warning_printed>: Now bool.
5338 (auto_load_pspace_data): Change type.
5339 (~auto_load_pspace_info): Rename from
5340 auto_load_pspace_data_cleanup.
5341 (get_auto_load_pspace_data, init_loaded_scripts_info)
5342 (clear_section_scripts, maybe_print_unsupported_script_warning)
5343 (maybe_print_script_not_found_warning, _initialize_auto_load):
5344 Update.
5345
f6aa7436
TT
53462019-05-08 Tom Tromey <tom@tromey.com>
5347
5348 * objfiles.c (objfile_pspace_info): Add destructor and
5349 initializers.
5350 (objfiles_pspace_data): Change type.
5351 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5352 (get_objfile_pspace_data): Update.
5353 (objfiles_bfd_data): Change type.
5354 (get_objfile_bfd_data): Update.
5355 (objfile_bfd_data_free, _initialize_objfiles): Remove.
5356
6ae614f6
TT
53572019-05-08 Tom Tromey <tom@tromey.com>
5358
5359 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5360 Change type.
5361 (get_catch_syscall_inferior_data): Update.
5362 (catch_syscall_inferior_data_cleanup): Remove.
5363 (_initialize_break_catch_syscall): Update.
5364
6509b8eb
TT
53652019-05-08 Tom Tromey <tom@tromey.com>
5366
5367 * inflow.c (struct terminal_info): Add destructor and
5368 initializers.
5369 (inflow_inferior_data): Change type.
5370 (~terminal_info): Rename from inflow_inferior_data_cleanup.
5371 (get_inflow_inferior_data, inflow_inferior_exit)
5372 (swap_terminal_info, _initialize_inflow): Update.
5373
35632941
TT
53742019-05-08 Tom Tromey <tom@tromey.com>
5375
5376 * target-dcache.c (target_dcache_cleanup): Remove.
5377 (target_dcache_aspace_key): Change type.
5378 (target_dcache_init_p, target_dcache_invalidate)
5379 (target_dcache_get, target_dcache_get_or_init)
5380 (_initialize_target_dcache): Update.
5381 * dcache.h (struct dcache_deleter): New.
5382
3017b94d
TT
53832019-05-08 Tom Tromey <tom@tromey.com>
5384
5385 * symtab.c (struct symbol_cache): Add destructor and
5386 initializers.
5387 (symbol_cache_key): Move. Change type.
5388 (make_symbol_cache, free_symbol_cache): Remove.
5389 (get_symbol_cache): Update.
5390 (symbol_cache_cleanup): Remove.
5391 (ALL_PSPACES, symbol_cache_flush)
5392 (maintenance_print_symbol_cache)
5393 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5394 Update.
5395
a32ad8c5
TT
53962019-05-08 Tom Tromey <tom@tromey.com>
5397
5398 * symtab.c (struct main_info): Add destructor and initializers.
5399 (main_progspace_key): Move. Change type.
5400 (get_main_info): Update.
5401 (main_info_cleanup): Remove.
5402 (_initialize_symtab): Update.
5403
5f6e90a0
TT
54042019-05-08 Tom Tromey <tom@tromey.com>
5405
5406 * registry.h (DECLARE_REGISTRY): Define the _key class.
5407
1bd0c6e4
AB
54082019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
5409
5410 * NEWS: Merge two 'New commands' sections.
5411
2228ef77
XR
54122019-05-08 Joel Brobecker <brobecker@adacore.com>
5413
5414 * ada-valprint.c (ada_val_print_gnat_array): Remove language
5415 parameter and use Ada language definition instead.
5416 (ada_val_print_ptr): Remove unused language parameter.
5417 (ada_val_print_num): Remove language parameter and use Ada language
5418 definition instead.
5419 (ada_val_print_enum, ada_val_print_flt): Remove unused language
5420 parameter.
5421 (ada_val_print_struct_union, ada_val_print_ref): Remove language
5422 parameter and use Ada language definition instead.
5423 (ada_val_print_1): Update all ada_val_print_xxx calls.
5424 Remove language parameter.
5425 (ada_val_print): Update ada_val_print_1 call.
5426
60fcc1c3
TT
54272019-05-08 Tom Tromey <tromey@adacore.com>
5428
5429 * remote.c (remote_hw_watchpoint_limit)
5430 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5431 Now static.
5432
ed2b7c17
TT
54332019-05-08 Tom Tromey <tromey@adacore.com>
5434
5435 * maint.c (_initialize_maint_cmds): Move initialization code to
5436 remote.c.
5437 (watchdog, show_watchdog): Move to remote.c.
5438 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
5439 "watchdog" static.
5440 (_initialize_remote): Move initialization code from maint.c.
5441 * defs.h (watchdog): Don't declare.
5442
b0be6c91
TT
54432019-05-08 Tom Tromey <tromey@adacore.com>
5444
5445 * tui/tui-interp.c: Include main.h.
5446 * interps.c: Include main.h.
5447 * main.h (interpreter_p): Declare.
5448 * defs.h (interpreter_p): Don't declare.
5449
587ee17b
TT
54502019-05-08 Tom Tromey <tromey@adacore.com>
5451
5452 * dwarf2loc.c: Include dwarf2read.h.
5453 * defs.h (read_unsigned_leb128): Don't declare.
5454 * dwarf2read.h (read_unsigned_leb128): Declare.
5455
ca1df239
TT
54562019-05-08 Tom Tromey <tromey@adacore.com>
5457
5458 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5459 method.
5460
99f20f08
TT
54612019-05-08 Tom Tromey <tromey@adacore.com>
5462
5463 * utils.c (fputs_maybe_filtered): Reset style after paging, even
5464 when no wrap column is set.
5465
80e55b13
TT
54662019-05-08 Tom Tromey <tromey@adacore.com>
5467
5468 * c-lang.c (c_get_string): Handle non-C-style arrays.
5469
9d3421af
TT
54702019-05-08 Tom Tromey <tromey@adacore.com>
5471
5472 * typeprint.c (print_offset_data::update): Print the bit offset,
5473 not the number of bits remaining.
5474
844333e2
TT
54752019-05-08 Tom Tromey <tromey@adacore.com>
5476
5477 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5478 padding at end of comment.
5479
988915ee
TT
54802019-05-08 Tom Tromey <tromey@adacore.com>
5481
5482 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
5483 Compare main types.
5484
26bfd823
TT
54852019-05-06 Tom Tromey <tom@tromey.com>
5486
5487 * common/scoped_mmap.c: Include common-defs.h.
5488 * common/scoped_mmap.h: Don't include config.h.
5489
89055eaa
TT
54902019-05-04 Tom Tromey <tom@tromey.com>
5491
5492 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
5493 (struct aarch64_call_info): Add initializers.
5494 <si>: Now a std::vector.
5495 (pass_on_stack, aarch64_push_dummy_call): Update.
5496
5da01df5
TT
54972019-05-04 Simon Marchi <simon.marchi@efficios.com>
5498 Tom Tromey <tom@tromey.com>
5499
5500 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
5501 (ppc_threads): Now a std::vector. Now static.
5502 (hwdebug_find_thread_points_by_tid)
5503 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
5504 Update.
5505
fbdf05a1
TT
55062019-05-04 Tom Tromey <tom@tromey.com>
5507
5508 * arc-tdep.c (arc_tdesc_init): Return bool.
5509
06d16ec9
TT
55102019-05-04 Tom Tromey <tom@tromey.com>
5511
5512 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
5513 Use gdb_assert_not_reached.
5514
9c056022
TT
55152019-05-04 Tom Tromey <tom@tromey.com>
5516
5517 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
5518 "false".
5519
fa9c2a59
TT
55202019-05-04 Tom Tromey <tom@tromey.com>
5521
5522 * arc-tdep.c (arc_tdesc_init): Use bool.
5523
e2eb806a
TT
55242019-05-04 Tom Tromey <tom@tromey.com>
5525
5526 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
5527
6fe87677
TT
55282019-05-04 Tom Tromey <tom@tromey.com>
5529
5530 * cli/cli-cmds.c (valid_command_p): Return bool.
5531
7f008c9e
TT
55322019-05-04 Tom Tromey <tom@tromey.com>
5533
5534 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
5535 * command.h (valid_user_defined_cmd_name_p): Channge return type.
5536
b6484282
RT
55372019-05-04 Raul Tambre <raul@tambre.ee>
5538
5539 * python/lib/gdb/prompt.py (_ExtendedPrompt)
5540 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
5541 operator for comparison.
5542
af97b416
TT
55432019-05-04 Tom Tromey <tom@tromey.com>
5544
5545 * psymtab.c (psymbol_name_matches, match_partial_symbol)
5546 (lookup_partial_symbol, print_partial_symbols)
5547 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
5548 (psymbol_compare): Update.
5549 (add_psymbol_to_bcache): Clear the entire psymbol.
5550 (maintenance_check_psymtabs): Update.
5551 * psympriv.h (struct partial_symbol): Don't derive from
5552 general_symbol_info.
5553 <obj_section, unrelocated_address, address,
5554 set_unrelocated_address>: Update.
5555 <ginfo>: New member.
5556 * dwarf-index-write.c (write_psymbols, debug_names::insert)
5557 (debug_names::write_psymbols): Update.
5558
9d6d4be8
TV
55592019-05-04 Tom de Vries <tdevries@suse.de>
5560
5561 * contrib/cc-with-tweaks.sh: Support -n arg.
5562
66452beb
PW
55632019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5564
5565 * corelow.c (core_target::detach): Ensure frame cache and
5566 register caches are cleared.
5567 inferior.c (exit_inferior_1): Likewise.
5568
bde09ab7
TT
55692019-05-03 Sandra Loosemore <sandra@codesourcery.com>
5570 Tom Tromey <tom@tromey.com>
5571
5572 * dictionary.c (collate_pending_symbols_by_language): Remove
5573 "struct" from foreach.
5574 * symtab.c (lookup_global_symbol_from_objfile)
5575 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
5576 foreach.
5577 * ser-tcp.c (net_open): Remove "struct" from foreach.
5578 * objfiles.c (objfile_relocate, objfile_rebase)
5579 (objfile_has_symbols): Remove "struct" from foreach.
5580 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
5581 from foreach.
5582 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
5583 foreach.
5584 * darwin-nat.c (thread_info_from_private_thread_info): Remove
5585 "struct" from foreach.
5586 * ada-lang.c (create_excep_cond_exprs)
5587 (ada_exception_catchpoint_cond_string): Remove "struct" from
5588 foreach.
5589
222a8d25
TT
55902019-05-03 Tom Tromey <tromey@adacore.com>
5591
5592 * ada-exp.y (convert_char_literal): Check suffix of each
5593 enumerator.
5594
fcd60b84
DP
55952019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
5596
5597 PR ada/21406:
5598 * ada-exp.y (yywrap): Don't define.
5599 * ada-lex.l (%option): Add noyywrap
5600 (yywrap): Remove.
5601
5f2459c2
EZ
56022019-05-03 Eli Zaretskii <eliz@gnu.org>
5603
353ea2d1
EZ
5604 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
5605 _WIN32_WINNT to the XP level, unless already defined to a higher
5606 level.
5607
5608 * unittests/parse-connection-spec-selftests.c:
5609 * ser-tcp.c:
5610 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
5611 override.
5612
5f2459c2
EZ
5613 * symfile.c (find_separate_debug_file): Remove colon from the
5614 drive spec of DOS/Windows file names of the target, so that the
5615 file name produced from DEBUGDIR and the target's directory will
5616 be valid on DOS/Windows systems.
5617
80062eb9
AB
56182019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
5619
5620 * rust-lang.c (val_print_struct): Handle printing structures
5621 containing strings.
5622
b8c05e85
TT
56232019-05-02 Tom Tromey <tromey@adacore.com>
5624
5625 * valarith.c (_initialize_valarith): Remove.
5626
4504bbde
TT
56272019-05-01 Tom Tromey <tromey@adacore.com>
5628
5629 * ada-lang.c (ada_value_primitive_field): Treat more fields as
5630 bitfields.
5631
d48e62f4
TT
56322019-05-01 Tom Tromey <tromey@adacore.com>
5633
5634 * ada-lang.c (ada_value_assign): Correctly compute starting offset
5635 for big-endian copies.
5636
15f18d14
AT
56372019-04-30 Ali Tamur <tamur@google.com>
5638 * gdb/dwarf2read.c (read_3_bytes): New declaration.
5639 (read_attribute_value): Added DW_FORM_strx1-4 cases.
5640 (read_3_bytes): New function.
5641
ab4ee614
JB
56422019-04-30 Joel Brobecker <brobecker@adacore.com>
5643
5644 * windows-nat.c (main_thread_id): Delete.
5645 (handle_output_debug_string): Replace main_thread_id by
5646 current_event.dwThreadId.
5647 (fake_create_process): Likewise.
5648 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
5649 Do not set main_thread_id.
5650 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
5651 current_event.dwThreadId.
5652 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
5653
8ed5b76e
JB
56542019-04-30 Joel Brobecker <brobecker@adacore.com>
5655
5656 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
5657 Use current_event.dwThreadId instead of main_thread_id.
5658
2ff0a947
TT
56592019-04-30 Tom Tromey <tromey@adacore.com>
5660
5661 * ada-lang.c (ada_lookup_simple_minsyms): New function.
5662 (create_excep_cond_exprs): Iterate over program spaces.
5663 (ada_exception_catchpoint_cond_string): Examine all minimal
5664 symbols for exception types.
5665
a776957c
TT
56662019-04-30 Tom Tromey <tromey@adacore.com>
5667
5668 PR c++/24470:
5669 * dwarf2read.c (process_structure_scope): Handle case where type
5670 has template parameters but no symbol was created.
5671
bc68014d
AB
56722019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5673 Chris January <chris.january@arm.com>
5674
5675 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
5676 qualifier.
5677 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
5678
f1fdc960
AB
56792019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5680
5681 * f-typeprint.c (f_print_type): Update rules for printing
5682 whitespace.
5683 (f_type_print_varspec_suffix): Likewise.
5684
bf7a4de1
AB
56852019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5686 Chris January <chris.january@arm.com>
5687
5688 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
5689 function arguments.
5690
bbe75b9d
AB
56912019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5692
5693 * f-lang.c (build_fortran_types): Change name of void type to
5694 lower case.
5695 * f-typeprint.c (f_type_print_base): Print the name of the void
5696 type, rather than a fixed string.
5697 * f-valprint.c (f_decorations): Use lower case void string.
5698
1db455a7
AB
56992019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5700 Chris January <chris.january@arm.com>
5701
5702 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
5703 types for Fortran.
5704
b6d03bb2
AB
57052019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5706 Chris January <chris.january@arm.com>
5707 David Lecomber <david.lecomber@arm.com>
5708
5709 * f-exp.y (BINOP_INTRINSIC): New token.
5710 (exp): New parser rule handling BINOP_INTRINSIC.
5711 (f77_keywords): Add new builtin procedures.
5712 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
5713 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5714 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
5715 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5716 (print_unop_subexp_f): New function.
5717 (print_binop_subexp_f): New function.
5718 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5719 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
5720 (dump_subexp_body_f): Likewise.
5721 (operator_check_f): Likewise.
5722 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
5723 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
5724
83228e93
AB
57252019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5726
5727 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
5728 UNOP_KIND.
5729 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
5730 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
5731 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
5732 (operator_length_f): New fuction.
5733 (print_subexp_f): New function.
5734 (op_name_f): New function.
5735 (dump_subexp_body_f): New function.
5736 (operator_check_f): New function.
5737 (exp_descriptor_f): Replace standard expression handling functions
5738 with new functions.
5739 * gdb/fortran-operator.def: New file.
5740 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
5741 * gdb/std-operator.def: Remove UNOP_KIND.
5742
6fdcd7cc
AB
57432019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
5744
5745 * std-operator.def: Remove unbalanced, stray double quote
5746 character.
5747
2e62ab40
AB
57482019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5749 Chris January <chris.january@arm.com>
5750 Daniel Everett <daniel.everett@arm.com>
5751 Nick Forrington <nick.forrington@arm.com>
5752 Richard Bunt <richard.bunt@arm.com>
5753
5754 * cp-valprint.c (cp_print_value_fields): Allow an additional level
5755 of depth when printing anonymous structs or unions.
5756 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
5757 Don't print either the top-level value, or the children if the
5758 max-depth is exceeded.
5759 (ppscm_print_children): When printing the key of a map, allow one
5760 extra level of depth.
5761 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
5762 print either the top-level value, or the children if the max-depth
5763 is exceeded.
5764 (print_children): When printing the key of a map, allow one extra
5765 level of depth.
5766 * python/py-value.c (valpy_format_string): Add max_depth keyword.
5767 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
5768 (user_print_options): Initialise max_depth field.
5769 (val_print_scalar_or_string_type_p): New function.
5770 (val_print): Check to see if the max depth has been reached.
5771 (val_print_check_max_depth): Define new function.
5772 (show_print_max_depth): New function.
5773 (_initialize_valprint): Add 'print max-depth' option.
5774 * valprint.h (struct value_print_options) <max_depth>: New field.
5775 (val_print_check_max_depth): Declare new function.
5776 * NEWS: Document new feature.
5777
4be290b2
AB
57782019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5779
5780 * ada-lang.c (ada_language_defn): Initialise new field.
5781 * c-lang.c (c_is_string_type_p): New function.
5782 (c_language_defn): Initialise new field.
5783 (cplus_language_defn): Initialise new field.
5784 (asm_language_defn): Initialise new field.
5785 (minimal_language_defn): Initialise new field.
5786 * c-lang.h (c_is_string_type_p): Declare new function.
5787 * d-lang.c (d_language_defn): Initialise new field.
5788 * f-lang.c (f_is_string_type_p): New function.
5789 (f_language_defn): Initialise new field.
5790 * go-lang.c (go_is_string_type_p): New function.
5791 (go_language_defn): Initialise new field.
5792 * language.c (default_is_string_type_p): New function.
5793 (unknown_language_defn): Initialise new field.
5794 (auto_language_defn): Initialise new field.
5795 * language.h (struct language_defn) <la_is_string_type_p>: New
5796 member variable.
5797 (default_is_string_type_p): Declare new function.
5798 * m2-lang.c (m2_language_defn): Initialise new field.
5799 * objc-lang.c (objc_language_defn): Initialise new field.
5800 * opencl-lang.c (opencl_language_defn): Initialise new field.
5801 * p-lang.c (pascal_is_string_type_p): New function.
5802 (pascal_language_defn): Initialise new field.
5803 * rust-lang.c (rust_is_string_type_p): New function.
5804 (rust_language_defn): Initialise new field.
5805
721b08c6
AB
58062019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5807
5808 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
5809 New field.
5810 * ada-lang.c (ada_language_defn): Initialise new field.
5811 * c-lang.c (c_language_defn): Likewise.
5812 (cplus_language_defn): Likewise.
5813 (asm_language_defn): Likewise.
5814 (minimal_language_defn): Likewise.
5815 * d-lang.c (d_language_defn): Likewise.
5816 * f-lang.c (f_language_defn): Likewise.
5817 * go-lang.c (go_language_defn): Likewise.
5818 * language.c (unknown_language_defn): Likewise.
5819 (auto_language_defn): Likewise.
5820 * m2-lang.c (m2_language_defn): Likewise.
5821 * objc-lang.c (objc_language_defn): Likewise.
5822 * opencl-lang.c (opencl_language_defn): Likewise.
5823 * p-lang.c (pascal_language_defn): Likewise.
5824 * rust-lang.c (rust_language_defn): Likewise.
5825
fc913e53
AB
58262019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
5827
5828 * ada-lang.c (ada_is_character_type): Change return type to bool.
5829 (ada_is_string_type): Likewise.
5830 * ada-lang.h (ada_is_character_type): Update declaration
5831 (ada_is_string_type): Likewise.
5832
fa731fa0
PW
58332019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5834
5835 Support style in 'frame|thread apply'
5836
5837 * gdbcmd.h (execute_command_to_string): New term_out parameter.
5838 * record.c (record_start, record_stop): Update callers of
5839 execute_command_to_string with false.
5840 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
5841 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
5842 methods.
5843 (class string_file): New constructor with term_out parameter.
5844 Override methods term_out and can_emit_style_escape. New member
5845 term_out.
5846 (class stdio_file): Override can_emit_style_escape.
5847 (class tee_file): Override term_out and can_emit_style_escape.
5848 * utils.h (can_emit_style_escape): Remove.
5849 * utils.c (can_emit_style_escape): Likewise.
5850 Update all callers of can_emit_style_escape (SOMESTREAM) to
5851 SOMESTREAM->can_emit_style_escape.
5852 * source-cache.c (source_cache::get_source_lines): Likewise.
5853 * stack.c (frame_apply_command_count): Call execute_command_to_string
5854 passing the term_out characteristic of the current gdb_stdout.
5855 * thread.c (thr_try_catch_cmd): Likewise.
5856 * top.c (execute_command_to_string): pass term_out parameter
5857 to construct the string_file for the command output.
5858 * ui-file.c (term_cli_styling): New function (most code moved
5859 from utils.c can_emit_style_escape).
5860 (string_file::string_file, string_file::can_emit_style_escape,
5861 stdio_file::can_emit_style_escape, tee_file::term_out,
5862 tee_file::can_emit_style_escape): New functions.
5863
136afab8
PW
58642019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5865
5866 * NEWS: Mention the new set|show may-call-functions.
5867 * infcall.c (may_call_functions_p): New variable.
5868 (show_may_call_functions_p): New function.
5869 (call_function_by_hand_dummy): Throws an error if not
5870 may-call-functions.
5871 (_initialize_infcall): Call add_setshow_boolean_cmd for
5872 may-call-functions.
5873
725cbb63
KS
58742019-04-25 Keith Seitz <keiths@redhat.com>
5875
5876 PR c++/24367
5877 * cp-support.c (inspect_type): Don't attempt substitutions
5878 of symbol with the same name.
5879
3d1cbb78
TT
58802019-04-25 Tom Tromey <tromey@adacore.com>
5881
5882 PR gdb/24475:
5883 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
5884 static.
5885
94aeb44b
TT
58862019-04-25 Tom Tromey <tromey@adacore.com>
5887
5888 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
5889 rvalue reference.
5890 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
5891 (gdb_xml_parser::parse): Use std::move.
5892 * python/python-internal.h (gdbpy_convert_exception): Take a const
5893 reference.
5894 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
5895 std::move.
5896 * python/py-utils.c (gdbpy_convert_exception): Take a const
5897 reference.
5898 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5899 Use std::move.
5900 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5901 Use std::move.
5902 * mi/mi-main.c (mi_print_exception): Take a const reference.
5903 * main.c (handle_command_errors): Take a const reference.
5904 * linespec.c (parse_linespec): Use std::move.
5905 * infcall.c (run_inferior_call): Use std::move.
5906 (call_function_by_hand_dummy): Use std::move.
5907 * exec.c (try_open_exec_file): Use std::move.
5908 * exceptions.h (exception_print, exception_fprintf)
5909 (exception_print_same): Update.
5910 * exceptions.c (print_exception, exception_print)
5911 (exception_fprintf, exception_print_same): Change parameters to
5912 const reference.
5913 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
5914 * common/new-op.c: Use std::move.
5915 * common/common-exceptions.h (struct gdb_exception): Add move
5916 constructor.
5917 (struct gdb_exception_error, struct gdb_exception_quit, struct
5918 gdb_quit_bad_alloc): Change constructor to move constructor.
5919 (throw_exception): Change parameter to rvalue reference.
5920 * common/common-exceptions.c (throw_exception): Take rvalue
5921 reference.
5922 * cli/cli-interp.c (safe_execute_command): Use std::move.
5923 * breakpoint.c (insert_bp_location, location_to_sals): Use
5924 std::move.
5925
680d7fd5
TT
59262019-04-25 Tom Tromey <tromey@adacore.com>
5927
5928 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
5929 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
5930 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
5931 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
5932 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
5933 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
5934 guile/scm-value.c: Use unpack.
5935 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
5936 gdbscm_gdb_exception.
5937 (gdbscm_throw_gdb_exception): Likewise.
5938 (struct gdbscm_gdb_exception): New.
5939 (unpack): New function.
5940 (gdbscm_wrap): Use unpack.
5941
c6fdd8b2
TT
59422019-04-25 Tom Tromey <tromey@adacore.com>
5943
5944 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5945 (gdb_rl_callback_handler): Use std::move.
5946 * common/common-exceptions.h (struct gdb_exception): Add move
5947 assignment operator.
5948 (throw_exception_sjlj): Change "exception" to const reference.
5949 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
5950 (throw_exception_sjlj): Change "exception" to const reference.
5951
cc06b668
TT
59522019-04-25 Tom Tromey <tromey@adacore.com>
5953
5954 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
5955 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
5956 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
5957 Update.
5958 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
5959 Update.
5960 * mi/mi-interp.c (mi_interp::exec): Update.
5961 * linespec.c (parse_linespec): Update.
5962 * infcall.c (run_inferior_call): Update.
5963 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
5964 * guile/scm-symbol.c (gdbscm_lookup_symbol)
5965 (gdbscm_lookup_global_symbol): Update.
5966 * guile/scm-param.c (gdbscm_parameter_value): Update.
5967 * guile/scm-frame.c (gdbscm_frame_read_register)
5968 (gdbscm_frame_read_var): Update.
5969 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
5970 * exec.c (try_open_exec_file): Update.
5971 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
5972 (gdb_rl_callback_handler): Update.
5973 * common/common-exceptions.h (exception_none): Don't declare.
5974 * common/common-exceptions.c (exception_none): Don't define.
5975 (struct catcher) <exception>: Update.
5976 * cli/cli-interp.c (safe_execute_command): Update.
5977 * breakpoint.c (insert_bp_location, location_to_sals): Update.
5978
cf532bd1
AT
59792019-04-25 Ali Tamur <tamur@google.com>
5980
5981 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
5982 (read_attribute_value): Likewise.
5983 (dwarf2_read_addr_index): Update comment.
5984 (read_str_index): Add DW_FORM_strx.
5985 (dwarf2_string_attr): Likewise.
5986 (dwarf2_const_value_attr): Likewise.
5987 (dump_die_shallow): Likewise.
5988 (dwarf2_fetch_constant_bytes): Likewise.
5989 (skip_form_bytes): Likewise.
5990 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
5991
82433e3e
SDJ
59922019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
5993
5994 PR corefiles/11608
5995 PR corefiles/18187
5996 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
5997 OFFSET. Verify if current mapping contains an ELF header.
5998 (linux_find_memory_regions_full): Adjust call to
5999 dump_mapping_p.
6000
723adb65
SL
60012019-04-25 Sandra Loosemore <sandra@codesourcery.com>
6002 Kang Li <kanglictf@gmail.com>
6003
6004 PR gdb/21600
6005
6006 * dwarf2-frame.c (read_initial_length): Be consistent about using
6007 unsigned representation of length.
6008 (decode_frame_entry_1): Likewise. Check for wraparound of
6009 end pointer as well as buffer overflow.
6010
596179f7
SDJ
60112019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
6012
6013 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6014 "vq".
6015
a59240a4
TT
60162019-04-24 Tom Tromey <tromey@adacore.com>
6017
6018 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6019
f872fdbb
AB
60202019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6021
6022 * s12z-tdep.c (s12z_unwind_pc): Delete.
6023 (s12z_unwind_sp): Delete.
6024 (s12z_gdbarch_init): Don't register deleted functions with
6025 gdbarch.
6026
b614e6f3
AB
60272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6028
6029 * rl78-tdep.c (rl78_unwind_sp): Delete.
6030 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6031
14faed38
AB
60322019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6033
6034 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6035 (xstormy16_unwind_pc): Delete.
6036 (xstormy16_dummy_id): Delete.
6037 (xstormy16_gdbarch_init): Don't register deleted functions with
6038 gdbarch.
6039
541aad8a
AB
60402019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6041
6042 * vax-tdep.c (vax_unwind_pc): Delete.
6043 (vax_gdbarch_init): Don't register deleted function with gdbarch.
6044
29222070
AB
60452019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6046
6047 * v850-tdep.c (v850_unwind_sp): Delete.
6048 (v850_unwind_pc): Delete.
6049 (v850_dummy_id): Delete.
6050 (v850_gdbarch_init): Don't register deleted functions with
6051 gdbarch.
6052
0f534d76
AB
60532019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6054
6055 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6056 (tilegx_unwind_pc): Delete.
6057 (tilegx_unwind_dummy_id): Delete.
6058 (tilegx_gdbarch_init): Don't register deleted functions with
6059 gdbarch.
6060
1ba7b7f9
AB
60612019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6062
6063 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6064 (tic6x_dummy_id): Delete.
6065 (tic6x_gdbarch_init): Don't register deleted functions with
6066 gdbarch.
6067
d31f262c
AB
60682019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6069
6070 * sparc-tdep.c (sparc_unwind_pc): Delete.
6071 (sparc32_gdbarch_init): Don't register deleted function with
6072 gdbarch.
6073
6d14d64d
AB
60742019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6075
6076 * sh-tdep.c (sh_unwind_sp): Delete.
6077 (sh_unwind_pc): Delete.
6078 (sh_dummy_id): Delete.
6079 (sh_gdbarch_init): Don't register deleted functions with
6080 gdbarch.
6081
a40dde9d
AB
60822019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6083
6084 * score-tdep.c (score_unwind_sp): Delete.
6085 (score_unwind_pc): Delete.
6086 (score_dummy_id): Delete.
6087 (score_gdbarch_init): Don't register deleted functions with
6088 gdbarch.
6089
47c47d69
AB
60902019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6091
6092 * rx-tdep.c (rx_unwind_pc): Delete.
6093 (rx_unwind_sp): Delete.
6094 (rx_dummy_id): Delete.
6095 (rx_gdbarch_init): Don't register deleted functions with
6096 gdbarch. Update comment.
6097
833a4480
AB
60982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6099
6100 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6101 (rs6000_dummy_id): Delete.
6102 (rs6000_gdbarch_init): Don't register deleted functions with
6103 gdbarch.
6104
3f2cef49
AB
61052019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6106
6107 * or1k-tdep.c (or1k_dummy_id): Delete.
6108 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6109
96acf884
AB
61102019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6111
6112 * nios2-tdep.c (nios2_dummy_id): Delete.
6113 (nios2_unwind_sp): Delete.
6114 (nios2_gdbarch_init): Don't register deleted functions with
6115 gdbarch.
6116
ca0ab0aa
AB
61172019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6118
6119 * nds32-tdep.c (nds32_dummy_id): Delete.
6120 (nds32_unwind_pc): Delete.
6121 (nds32_unwind_sp): Delete.
6122 (nds32_gdbarch_init): Don't register deleted functions with
6123 gdbarch.
6124
c8259044
AB
61252019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6126
6127 * msp430-tdep.c (msp430_unwind_pc): Delete.
6128 (msp430_unwind_sp): Delete.
6129 (msp430_dummy_id): Delete.
6130 (msp430_gdbarch_init): Don't register deleted functions with
6131 gdbarch.
6132
27f113c8
AB
61332019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6134
6135 * moxie-tdep.c (moxie_unwind_sp): Delete.
6136 (moxie_unwind_pc): Delete.
6137 (moxie_dummy_id): Delete.
6138 (moxie_gdbarch_init): Don't register deleted functions with
6139 gdbarch.
6140
aee6c3cd
AB
61412019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6142
6143 * mn10300-tdep.c (mn10300_dummy_id): Delete.
6144 (mn10300_unwind_pc): Delete.
6145 (mn10300_unwind_sp): Delete.
6146 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6147 mn10300_unwind_sp.
6148 (mn10300_frame_unwind_init): Don't register deleted functions with
6149 gdbarch.
6150
8e2b5aea
AB
61512019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6152
6153 * mep-tdep.c (mep_unwind_pc): Delete.
6154 (mep_unwind_sp): Delete.
6155 (mep_dummy_id): Delete.
6156 (mep_gdbarch_init): Don't register deleted functions with
6157 gdbarch.
6158
43cf3ede
AB
61592019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6160
6161 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6162 (m68hc11_unwind_sp): Delete.
6163 (m68hc11_gdbarch_init): Don't register deleted functions with
6164 gdbarch.
6165
5e79b7bb
AB
61662019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6167
6168 * m32r-tdep.c (m32r_unwind_sp): Delete.
6169 (m32r_unwind_pc): Delete.
6170 (m32r_dummy_id): Delete.
6171 (m32r_gdbarch_init): Don't register deleted functions with
6172 gdbarch.
6173
89b268d8
AB
61742019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6175
6176 * m32c-tdep.c (m32c_unwind_pc): Delete.
6177 (m32c_unwind_sp): Delete.
6178 (m32c_dummy_id): Delete.
6179 (m32c_gdbarch_init): Don't register deleted functions with
6180 gdbarch.
6181
946c28d2
AB
61822019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6183
6184 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6185 (lm32_unwind_pc): Delete.
6186 (lm32_dummy_id): Delete.
6187 (lm32_gdbarch_init): Don't register deleted functions with
6188 gdbarch.
6189
bf12844a
AB
61902019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6191
6192 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6193 (iq2000_unwind_pc): Delete.
6194 (iq2000_dummy_id): Delete.
6195 (iq2000_gdbarch_init): Don't register deleted functions with
6196 gdbarch.
6197
ecbc06d2
AB
61982019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6199
6200 * nds32-tdep.c (nds32_type_align): Delete.
6201 (nds32_push_dummy_call): Use type_align instead.
6202
030197b4
AB
62032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6204
6205 * arm-tdep.c (arm_type_align): Only handle vector override case.
6206 (arm_push_dummy_call): Use type_align.
6207 (arm_gdbarch_init): Register arm_type_align gdbarch function.
6208
b907456c
AB
62092019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
6210
6211 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6212 case.
6213 (pass_on_stack): Use type_align.
6214 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6215 function.
6216
9e97ba43
TT
62172019-04-23 Tom Tromey <tromey@adacore.com>
6218
6219 * dwarf2read.c (line_header::file_name_at): Remove unused
6220 overload.
6221
6892f601
TV
62222019-04-23 Tom de Vries <tdevries@suse.de>
6223
6224 PR gdb/24438
6225 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6226 invocation.
6227
336d760d
AT
6228
62292019-03-27 Ali Tamur <tamur@google.com>
6230
6231 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6232 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6233 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6234 (dwarf_expr_context::get_addr_index): Likewise
6235 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6236 (symbol_needs_eval_context::get_addr_index): Likewise
6237 (disassemble_dwarf_expression): Add DW_OP_addrx
6238 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6239 (read_cutu_die_from_dwo): Update comment
6240 (skip_one_die): Add DW_FORM_addrx
6241 (read_attribute_value): Likewise
6242 (var_decode_location): Add DW_OP_addrx
6243 (dwarf2_const_value_attr): Add DW_FORM_addrx
6244 (dump_die_shallow): Likewise
6245 (dwarf2_fetch_constant_bytes): Likewise
6246 (decode_locdesc): Add DW_OP_addrx
6247 (skip_form_bytes): Add DW_FORM_addrx
6248
ad9d13f8
AT
62492019-04-22 Ali Tamur <tamur@google.com>
6250
6251 * MAINTAINERS (Write After Approval): Add self.
6252
d70cc3ba
SM
62532019-04-22 Simon Marchi <simon.marchi@efficios.com>
6254
6255 * solib-svr4.c (get_svr4_info): Add pspace parameter.
6256 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6257 (open_symbol_file_object): Likewise.
6258 (svr4_default_sos): Add info parameter.
6259 (svr4_read_so_list): Likewise.
6260 (svr4_current_sos_direct): Adjust functions calls to pass down
6261 info.
6262 (svr4_current_sos_1): Add info parameter.
6263 (svr4_current_sos): Call get_svr4_info, pass info down to
6264 svr4_current_sos_1.
6265 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6266 get_svr4_info.
6267 (svr4_in_dynsym_resolve_code): Pass current_program_space to
6268 get_svr4_info.
6269 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6270 to get_svr4_info.
6271 (probes_table_remove_objfile_probes): Likewise.
6272 (register_solib_event_probe): Add info parameter.
6273 (solist_update_incremental): Pass info parameter down to
6274 svr4_read_so_list.
6275 (disable_probes_interface): Add info parameter.
6276 (svr4_handle_solib_event): Pass current_program_space to
6277 get_svr4_info. Adjust disable_probes_interface cleanup.
6278 (svr4_create_probe_breakpoints): Add info parameter, pass it
6279 down to register_solib_event_probe.
6280 (svr4_create_solib_event_breakpoints): Add info parameter,
6281 pass it down to svr4_create_probe_breakpoints.
6282 (enable_break): Pass info down to
6283 svr4_create_solib_event_breakpoints.
6284 (svr4_solib_create_inferior_hook): Pass current_program_space to
6285 get_svr4_info.
6286 (svr4_clear_solib): Likewise.
6287
7905fc35
PA
62882019-04-22 Pedro Alves <palves@redhat.com>
6289
6290 * solib-svr4.c (svr4_free_objfile_observer): New.
6291 (probe_and_action::objfile): New field.
6292 (probes_table_htab_remove_objfile_probes)
6293 (probes_table_remove_objfile_probes): New functions.
6294 (register_solib_event_probe): Add 'objfile' parameter. Store it
6295 in the new probe_and_action. Don't store the probe in 'lookup'.
6296 (svr4_create_probe_breakpoints): Pass objfile to
6297 register_solib_event_probe.
6298 (_initialize_svr4_solib): Register a free_objfile observer.
6299
fb881986
TT
63002019-04-19 Tom Tromey <tom@tromey.com>
6301
6302 * common/queue.h: Remove.
6303
8732db6c
TT
63042019-04-19 Tom Tromey <tom@tromey.com>
6305
6306 * event-loop.c: Don't include "common/queue.h".
6307
97dfbadd
TT
63082019-04-19 Tom Tromey <tom@tromey.com>
6309
6310 * remote.c (remote_target): Use delete.
6311 * remote-notif.h: Include <list>, not "common/queue.h".
6312 (notif_client_p): Remove typedef.
6313 (remote_notif_state): Add constructor, destructor, initializer.
6314 <notif_queue>: Now a std::list.
6315 (remote_notif_state_xfree): Don't declare.
6316 * remote-notif.c (remote_notif_process, handle_notification)
6317 (remote_notif_state_allocate): Update.
6318 (~remote_notif_state): Rename from remote_notif_state_xfree.
6319
cf250e36
TT
63202019-04-19 Tom Tromey <tom@tromey.com>
6321
6322 * symfile.c (reread_symbols): Update.
6323 * objfiles.c (objfile_register_static_link)
6324 (objfile_lookup_static_link): Update
6325 (~objfile) Don't delete static_links.
6326 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6327
61f4b350
TT
63282019-04-19 Tom Tromey <tom@tromey.com>
6329
6330 * type-stack.h (struct type_stack) <insert>: Constify string.
6331 * type-stack.c (type_stack::insert): Constify string.
6332 * gdbtypes.h (lookup_template_type): Update.
6333 (address_space_name_to_int): Update.
6334 * gdbtypes.c (address_space_name_to_int): Make space_identifier
6335 const.
6336 (lookup_template_type): Make name const.
6337 * c-exp.y: Update rules.
6338 (lex_one_token, classify_name, classify_inner_name)
6339 (c_print_token): Update.
6340 * p-exp.y: Update rules.
6341 (yylex): Update.
6342 * f-exp.y: Update rules.
6343 (yylex): Update.
6344 * d-exp.y: Update rules.
6345 (lex_one_token, classify_name, classify_inner_name): Update.
6346 * parse.c (write_dollar_variable, copy_name): Return std::string.
6347 * parser-defs.h (copy_name): Change return type.
6348 * m2-exp.y: Update rules.
6349 (yylex): Update.
6350 * go-exp.y (lex_one_token): Update.
6351 Update rules.
6352 (classify_unsafe_function, classify_packaged_name)
6353 (classify_name, yylex): Update.
6354
189b8c2e
ST
63552019-04-19 Sergei Trofimovich <siarheit@google.com>
6356
6357 * configure.ac: add --enable-source-highlight switch.
6358 * configure: Regenerate.
6359 * top.c (print_gdb_version): plumb --enable-source-highlight
6360 status to "show configuration".
6361
8ecb59f8
TT
63622019-04-19 Tom Tromey <tromey@adacore.com>
6363
6364 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6365 Check ADA_TYPE_P.
6366 (empty_record, ada_template_to_fixed_record_type_1)
6367 (template_to_static_fixed_type)
6368 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6369 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6370 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6371 macros.
6372
62160ec9
TT
63732019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
6374
6375 PR symtab/24423:
6376 * source.c (print_source_lines_base): Advance "iter" when a
6377 control character is seen.
6378
f2ae8bc8
PW
63792019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6380
6381 * inferior.h (struct infcall_suspend_state_deleter):
6382 Catch exception in destructor to avoid crash.
6383
d563b953
PW
63842019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6385
6386 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6387 close to the add_com "shell".
6388
dc34c897
TT
63892019-04-18 Tom Tromey <tromey@adacore.com>
6390
6391 * process-stratum-target.h (class process_stratum_target)
6392 <stratum>: Add "final".
6393
a12e5744
TT
63942019-04-17 Tom Tromey <tromey@adacore.com>
6395
6396 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6397 against nullptr before use.
6398
a7e559cc
AH
63992019-04-17 Alan Hayward <alan.hayward@arm.com>
6400
6401 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6402
c01660c6
AB
64032019-04-17 Jim Wilson <jimw@sifive.com>
6404 Andrew Burgess <andrew.burgess@embecosm.com>
6405
6406 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6407 code read might fail, assume 4-byte breakpoint in that case.
6408
4aa866af
LS
64092019-04-15 Leszek Swirski <leszeks@google.com>
6410
6411 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6412 rather than a hand-rolled POD check when checking for forced MEMORY
6413 classification.
6414
48574d91
AH
64152019-04-15 Alan Hayward <alan.hayward@arm.com>
6416
6417 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6418 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6419 function.
6420 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6421 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6422 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6423 declaration.
6424
4da037ef
AH
64252019-04-15 Alan Hayward <alan.hayward@arm.com>
6426
6427 * aarch64-linux-nat.c
6428 (aarch64_linux_nat_target::thread_architecture): Add override.
6429 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6430 each VQ.
6431
ccb8d7e8
AH
64322019-04-15 Alan Hayward <alan.hayward@arm.com>
6433
6434 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6435
35add35e
AB
64362019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
6437
6438 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6439 target types of size 96-bits, add some additional comments, and
6440 check that the builtin type we found was the correct size.
6441
51196bbc
EZ
64422019-04-12 Eli Zaretskii <eliz@gnu.org>
6443
6444 * utils.c (prompt_for_continue): Don't restore the styling at the
6445 end, as applied_style has the wrong value. This fixes styling in
6446 long lists of file names that are interrupted by the "Continue?"
6447 prompt.
6448
62253a61
AB
64492019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
6450
6451 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6452 * c-lang.c (c_language_defn): Likewise.
6453 (cplus_language_defn): Likewise.
6454 (asm_language_defn): Likewise.
6455 (minimal_language_defn): Likewise.
6456 * d-lang.c (d_language_defn): Likewise.
6457 * f-lang.c (f_language_defn): Likewise.
6458 * go-lang.c (go_language_defn): Likewise.
6459 * language.c (unknown_language_defn): Likewise.
6460 (auto_language_defn): Likewise.
6461 * language.h (struct language_defn): Remove la_magic field.
6462 (LANG_MAGIC): Delete.
6463 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6464 * objc-lang.c (objc_language_defn): Likewise.
6465 * opencl-lang.c (opencl_language_defn): Likewise.
6466 * p-lang.c (pascal_language_defn): Likewise.
6467 * rust-lang.c (rust_language_defn): Likewise.
6468
a9158a86
AB
64692019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6470
6471 * riscv-tdep.c (riscv_type_align): New function.
6472 (riscv_type_alignment): Delete.
6473 (riscv_arg_location): Use 'type_align'.
6474 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6475
41077b66
AB
64762019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6477
6478 * gdbtypes.c (type_align): A struct with no non-static fields also
6479 has alignment of 1.
6480
9f0272f8
AB
64812019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
6482
6483 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
6484 component to 0.
6485 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
6486 member.
6487 (riscv_struct_info::analyse): New implementation using new
6488 analyse_inner member function.
6489 (riscv_struct_info::field_offset): New member function.
6490 (riscv_struct_info::m_offsets): New member variable.
6491 (riscv_struct_info::analyse_inner): New private member function,
6492 takes the old implementation of riscv_struct_info::analyse but
6493 extended to track field offsets.
6494 (riscv_call_arg_struct): Update the struct folding special cases
6495 to handle cases where empty C++ structs, which are non-zero
6496 length, are found.
6497 (riscv_arg_location): Initialise the length of each location, a
6498 non-zero length now indicates the location is in use.
6499 (riscv_push_dummy_call): Allow for the first location having a
6500 non-zero offset when setting up arguments.
6501 (riscv_return_value): Likewise, but for return values.
6502
02cf60c7
TT
65032019-04-11 Tom Tromey <tromey@adacore.com>
6504
6505 * utils.c (internal_vproblem): Make "msg" const.
6506
68811f8f
AH
65072019-04-11 Alan Hayward <alan.hayward@arm.com>
6508
6509 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
6510 * trad-frame.c (trad_frame_reset_saved_regs): New function.
6511 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
6512 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
6513
3f52fdbc
KB
65142019-04-10 Kevin Buettner <kevinb@redhat.com>
6515
6516 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
6517 function.
6518 (fill_gregset): Call amd64_linux_collect_native_gregset instead
6519 of amd64_collect_native_gregset.
6520 (amd64_linux_nat_target::store_registers): Likewise.
6521
e9ad22ee
TT
65222019-04-10 Tom Tromey <tom@tromey.com>
6523
6524 * symtab.c (lookup_global_symbol_from_objfile)
6525 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
6526 * objfiles.h (class separate_debug_iterator): New.
6527 (class separate_debug_range): New.
6528 (struct objfile) <separate_debug_objfiles>: New method.
6529 (objfile_separate_debug_iterate): Don't declare.
6530 * objfiles.c (separate_debug_iterator::operator++): Rename from
6531 objfile_separate_debug_iterate.
6532 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
6533 iterator.
6534 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
6535 iterator.
6536
ee371134
TT
65372019-04-10 Tom Tromey <tom@tromey.com>
6538
6539 * symfile.c (reread_symbols): Remove old comment.
6540 * objfiles.c (free_all_objfiles): Fix a typo.
6541
bf227d61
TT
65422019-04-10 Tom Tromey <tom@tromey.com>
6543
6544 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
6545 * minsyms.c (lookup_minimal_symbol): Use foreach.
6546 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
6547 (lookup_minimal_symbol_solib_trampoline): Likewise.
6548 * symfile.c (reread_symbols): Use foreach.
6549
8dc433a0
TT
65502019-04-09 Ivan Begert <ivanbegert@gmail.com>
6551 Tom Tromey <tromey@adacore.com>
6552
6553 PR rust/24414:
6554 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
6555 (rust_lex_int_test): Change "value" to be LONGEST.
6556 (rust_lex_tests): Add test for long integer literal.
6557
9ab8741a
TT
65582019-04-09 Tom Tromey <tromey@adacore.com>
6559
6560 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
6561 to bool.
6562 (extended_remote_target::attach): Update.
6563 (remote_target::remote_notice_new_inferior): Update.
6564 (remote_target::add_current_inferior_and_thread): Update.
6565 * inferior.c (exit_inferior_1): Use "false".
6566 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
6567
e242fd12
SM
65682019-04-09 Simon Marchi <simon.marchi@efficios.com>
6569
9ca1957f 6570 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM
6571 the "start" command.
6572
2b0c8b01
KB
65732019-04-08 Kevin Buettner <kevinb@redhat.com>
6574
6575 * python/py-inferior.c (infpy_thread_from_thread_handle):
6576 Adjust comments to reflect renaming of thread_from_thread_handle
6577 to thread_from_handle. Adjust keywords. Fix type error message.
6578 (inferior_object_methods): Add thread_from_handle. Retain
6579 thread_from_thread_handle, but mark it as deprecated.
6580
50a82723
KB
65812019-04-08 Kevin Buettner <kevinb@redhat.com>
6582
6583 * gdbthread.h (find_thread_by_handle): Revise declaration.
6584 * thread.c (find_thread_by_handle): Likewise. Adjust
6585 implementation too.
6586 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
6587 support for buffer objects as handles.
6588
cf63b016
KB
65892019-04-08 Kevin Buettner <kevinb@redhat.com>
6590
6591 * python/py-infthread.c (thpy_thread_handle): New function.
6592 (thread_object_methods): Register thpy_thread_handle.
6593
3d6c6204
KB
65942019-04-08 Kevin Buettner <kevinb@redhat.com>
6595
6596 * gdbthread.h (thread_to_thread_handle): Declare.
6597 * thread.c (gdbtypes.h): Include.
6598 (thread_to_thread_handle): New function.
6599
6600 * target.h (struct target_ops): Add thread_info_to_thread_handle.
6601 (target_thread_info_to_thread_handle): Declare.
6602 * target.c (target_thread_info_to_thread_handle): New function.
6603 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
6604 * target-delegates.c: Regenerate.
6605
6606 * linux-thread-db.c (class thread_db_target): Add method
6607 thread_info_to_thread_handle.
6608 (thread_db_target::thread_info_to_thread_handle): Define.
6609 * remote.c (class remote_target): Add new method
6610 thread_info_to_thread_handle.
6611 (remote_target::thread_info_to_thread_handle): Define.
6612
56be6ea8
PA
66132019-04-08 Pedro Alves <palves@redhat.com>
6614
6615 * common/common-exceptions.c (throw_exception): Don't create
6616 named object to throw; throw directly.
6617 (throw_it): Likewise. Don't initialize gdb_exception::message
6618 here, with new; pass FMT and AP to the ctor instead.
6619 * common/common-exceptions.h: Include <string>.
6620 (gdb_exception::gdb_exception(enum return_reason, enum errors,
6621 const char *, va_list)): New ctor. Use std::make_shared.
6622 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
6623 errors)): Delete.
6624 (gdb_exception_error::gdb_exception_error(enum errors, const char
6625 *, va_list)): New.
6626 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
6627 Add assertion.
6628 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
6629 errors)): Delete.
6630 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
6631 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
6632 Add assertion.
6633
eedc3f4f
TT
66342019-04-08 Tom Tromey <tom@tromey.com>
6635
6636 * valops.c (value_rtti_indirect_type): Replace throw_exception
6637 with throw.
6638 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
6639 with throw.
6640 * thread.c (thr_try_catch_cmd): Replace throw_exception with
6641 throw.
6642 * target.c (target_translate_tls_address): Replace throw_exception
6643 with throw.
6644 * stack.c (frame_apply_command_count): Replace throw_exception
6645 with throw.
6646 * solib-spu.c (append_ocl_sos): Replace throw_exception with
6647 throw.
6648 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
6649 with throw.
6650 * rs6000-tdep.c (rs6000_frame_cache)
6651 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
6652 * remote.c: Replace throw_exception with throw.
6653 * record-full.c (record_full_message, record_full_wait_1)
6654 (record_full_restore): Replace throw_exception with throw.
6655 * record-btrace.c:
6656 (get_thread_current_frame_id, record_btrace_start_replaying)
6657 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
6658 (cmd_record_btrace_start): Replace throw_exception with throw.
6659 * parse.c (parse_exp_in_context_1): Replace throw_exception with
6660 throw.
6661 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
6662 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
6663 * linespec.c:
6664 (find_linespec_symbols): Replace throw_exception with throw.
6665 * infrun.c (displaced_step_prepare, resume): Replace
6666 throw_exception with throw.
6667 * infcmd.c (post_create_inferior): Replace throw_exception with
6668 throw.
6669 * inf-loop.c (inferior_event_handler): Replace throw_exception
6670 with throw.
6671 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
6672 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
6673 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
6674 (get_prev_frame_always, get_frame_pc_if_available)
6675 (get_frame_address_in_block_if_available, get_frame_language):
6676 Replace throw_exception with throw.
6677 * frame-unwind.c (frame_unwind_try_unwinder): Replace
6678 throw_exception with throw.
6679 * eval.c (fetch_subexp_value, evaluate_var_value)
6680 (evaluate_funcall, evaluate_subexp_standard): Replace
6681 throw_exception with throw.
6682 * dwarf2loc.c (call_site_find_chain)
6683 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
6684 Replace throw_exception with throw.
6685 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
6686 with throw.
6687 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
6688 throw.
6689 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
6690 * completer.c (complete_line_internal): Replace throw_exception
6691 with throw.
6692 * compile/compile-object-run.c (compile_object_run): Replace
6693 throw_exception with throw.
6694 * cli/cli-script.c (process_next_line): Replace throw_exception
6695 with throw.
6696 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
6697 (btrace_enable, btrace_maint_update_pt_packets): Replace
6698 throw_exception with throw.
6699 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
6700 throw_exception with throw.
6701 * break-catch-throw.c (re_set_exception_catchpoint): Replace
6702 throw_exception with throw.
6703 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
6704 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
6705 * aarch64-tdep.c (aarch64_make_prologue_cache)
6706 (aarch64_make_stub_cache): Replace throw_exception with throw.
6707
26003a20
TT
67082019-04-08 Tom Tromey <tom@tromey.com>
6709
6710 * common/common-exceptions.c (throw_exception): Rename from
6711 throw_exception_cxx. Remove old copy. Make argument const.
6712 (throw_it): Create and throw exception objects directly.
6713 * common/common-exceptions.h (throw_exception): Make argument
6714 const.
6715 (struct gdb_exception_error): Add constructor.
6716 (struct gdb_exception_quit): Add constructor.
6717
d272eb37
TT
67182019-04-08 Tom Tromey <tom@tromey.com>
6719
6720 * common/common-exceptions.h (exception_rethrow): Don't declare.
6721 (TRY_SJLJ): Update comment.
6722 (TRY, CATCH, END_CATCH): Remove.
6723 * common/common-exceptions.c (exception_rethrow): Remove.
6724
230d2906
TT
67252019-04-08 Tom Tromey <tom@tromey.com>
6726
6727 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
6728 Remove.
6729 (gdb_exception_error): Rename from
6730 gdb_exception_RETURN_MASK_ERROR.
6731 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
6732 (gdb_quit_bad_alloc): Update.
6733 * aarch64-tdep.c: Update.
6734 * ada-lang.c: Update.
6735 * ada-typeprint.c: Update.
6736 * ada-valprint.c: Update.
6737 * amd64-tdep.c: Update.
6738 * arch-utils.c: Update.
6739 * break-catch-throw.c: Update.
6740 * breakpoint.c: Update.
6741 * btrace.c: Update.
6742 * c-varobj.c: Update.
6743 * cli/cli-cmds.c: Update.
6744 * cli/cli-interp.c: Update.
6745 * cli/cli-script.c: Update.
6746 * common/common-exceptions.c: Update.
6747 * common/new-op.c: Update.
6748 * common/selftest.c: Update.
6749 * compile/compile-c-symbols.c: Update.
6750 * compile/compile-cplus-symbols.c: Update.
6751 * compile/compile-object-load.c: Update.
6752 * compile/compile-object-run.c: Update.
6753 * completer.c: Update.
6754 * corelow.c: Update.
6755 * cp-abi.c: Update.
6756 * cp-support.c: Update.
6757 * cp-valprint.c: Update.
6758 * darwin-nat.c: Update.
6759 * disasm-selftests.c: Update.
6760 * dtrace-probe.c: Update.
6761 * dwarf-index-cache.c: Update.
6762 * dwarf-index-write.c: Update.
6763 * dwarf2-frame-tailcall.c: Update.
6764 * dwarf2-frame.c: Update.
6765 * dwarf2loc.c: Update.
6766 * dwarf2read.c: Update.
6767 * eval.c: Update.
6768 * event-loop.c: Update.
6769 * event-top.c: Update.
6770 * exec.c: Update.
6771 * f-valprint.c: Update.
6772 * fbsd-tdep.c: Update.
6773 * frame-unwind.c: Update.
6774 * frame.c: Update.
6775 * gdbtypes.c: Update.
6776 * gnu-v3-abi.c: Update.
6777 * guile/guile-internal.h: Update.
6778 * guile/scm-block.c: Update.
6779 * guile/scm-breakpoint.c: Update.
6780 * guile/scm-cmd.c: Update.
6781 * guile/scm-disasm.c: Update.
6782 * guile/scm-frame.c: Update.
6783 * guile/scm-lazy-string.c: Update.
6784 * guile/scm-math.c: Update.
6785 * guile/scm-param.c: Update.
6786 * guile/scm-ports.c: Update.
6787 * guile/scm-pretty-print.c: Update.
6788 * guile/scm-symbol.c: Update.
6789 * guile/scm-symtab.c: Update.
6790 * guile/scm-type.c: Update.
6791 * guile/scm-value.c: Update.
6792 * i386-linux-tdep.c: Update.
6793 * i386-tdep.c: Update.
6794 * inf-loop.c: Update.
6795 * infcall.c: Update.
6796 * infcmd.c: Update.
6797 * infrun.c: Update.
6798 * jit.c: Update.
6799 * language.c: Update.
6800 * linespec.c: Update.
6801 * linux-fork.c: Update.
6802 * linux-nat.c: Update.
6803 * linux-tdep.c: Update.
6804 * linux-thread-db.c: Update.
6805 * main.c: Update.
6806 * mi/mi-cmd-break.c: Update.
6807 * mi/mi-cmd-stack.c: Update.
6808 * mi/mi-interp.c: Update.
6809 * mi/mi-main.c: Update.
6810 * objc-lang.c: Update.
6811 * p-valprint.c: Update.
6812 * parse.c: Update.
6813 * ppc-linux-tdep.c: Update.
6814 * printcmd.c: Update.
6815 * python/py-arch.c: Update.
6816 * python/py-breakpoint.c: Update.
6817 * python/py-cmd.c: Update.
6818 * python/py-finishbreakpoint.c: Update.
6819 * python/py-frame.c: Update.
6820 * python/py-framefilter.c: Update.
6821 * python/py-gdb-readline.c: Update.
6822 * python/py-inferior.c: Update.
6823 * python/py-infthread.c: Update.
6824 * python/py-lazy-string.c: Update.
6825 * python/py-linetable.c: Update.
6826 * python/py-objfile.c: Update.
6827 * python/py-param.c: Update.
6828 * python/py-prettyprint.c: Update.
6829 * python/py-progspace.c: Update.
6830 * python/py-record-btrace.c: Update.
6831 * python/py-record.c: Update.
6832 * python/py-symbol.c: Update.
6833 * python/py-type.c: Update.
6834 * python/py-unwind.c: Update.
6835 * python/py-utils.c: Update.
6836 * python/py-value.c: Update.
6837 * python/python.c: Update.
6838 * record-btrace.c: Update.
6839 * record-full.c: Update.
6840 * remote-fileio.c: Update.
6841 * remote.c: Update.
6842 * riscv-tdep.c: Update.
6843 * rs6000-aix-tdep.c: Update.
6844 * rs6000-tdep.c: Update.
6845 * rust-exp.y: Update.
6846 * rust-lang.c: Update.
6847 * s390-tdep.c: Update.
6848 * selftest-arch.c: Update.
6849 * solib-dsbt.c: Update.
6850 * solib-frv.c: Update.
6851 * solib-spu.c: Update.
6852 * solib-svr4.c: Update.
6853 * solib.c: Update.
6854 * sparc64-linux-tdep.c: Update.
6855 * stack.c: Update.
6856 * symfile-mem.c: Update.
6857 * symmisc.c: Update.
6858 * target.c: Update.
6859 * thread.c: Update.
6860 * top.c: Update.
6861 * tracefile-tfile.c: Update.
6862 * tui/tui.c: Update.
6863 * typeprint.c: Update.
6864 * unittests/cli-utils-selftests.c: Update.
6865 * unittests/parse-connection-spec-selftests.c: Update.
6866 * valops.c: Update.
6867 * valprint.c: Update.
6868 * value.c: Update.
6869 * varobj.c: Update.
6870 * windows-nat.c: Update.
6871 * x86-linux-nat.c: Update.
6872 * xml-support.c: Update.
6873
a70b8144
TT
68742019-04-08 Tom Tromey <tom@tromey.com>
6875
6876 * xml-support.c: Use C++ exception handling.
6877 * x86-linux-nat.c: Use C++ exception handling.
6878 * windows-nat.c: Use C++ exception handling.
6879 * varobj.c: Use C++ exception handling.
6880 * value.c: Use C++ exception handling.
6881 * valprint.c: Use C++ exception handling.
6882 * valops.c: Use C++ exception handling.
6883 * unittests/parse-connection-spec-selftests.c: Use C++ exception
6884 handling.
6885 * unittests/cli-utils-selftests.c: Use C++ exception handling.
6886 * typeprint.c: Use C++ exception handling.
6887 * tui/tui.c: Use C++ exception handling.
6888 * tracefile-tfile.c: Use C++ exception handling.
6889 * top.c: Use C++ exception handling.
6890 * thread.c: Use C++ exception handling.
6891 * target.c: Use C++ exception handling.
6892 * symmisc.c: Use C++ exception handling.
6893 * symfile-mem.c: Use C++ exception handling.
6894 * stack.c: Use C++ exception handling.
6895 * sparc64-linux-tdep.c: Use C++ exception handling.
6896 * solib.c: Use C++ exception handling.
6897 * solib-svr4.c: Use C++ exception handling.
6898 * solib-spu.c: Use C++ exception handling.
6899 * solib-frv.c: Use C++ exception handling.
6900 * solib-dsbt.c: Use C++ exception handling.
6901 * selftest-arch.c: Use C++ exception handling.
6902 * s390-tdep.c: Use C++ exception handling.
6903 * rust-lang.c: Use C++ exception handling.
6904 * rust-exp.y: Use C++ exception handling.
6905 * rs6000-tdep.c: Use C++ exception handling.
6906 * rs6000-aix-tdep.c: Use C++ exception handling.
6907 * riscv-tdep.c: Use C++ exception handling.
6908 * remote.c: Use C++ exception handling.
6909 * remote-fileio.c: Use C++ exception handling.
6910 * record-full.c: Use C++ exception handling.
6911 * record-btrace.c: Use C++ exception handling.
6912 * python/python.c: Use C++ exception handling.
6913 * python/py-value.c: Use C++ exception handling.
6914 * python/py-utils.c: Use C++ exception handling.
6915 * python/py-unwind.c: Use C++ exception handling.
6916 * python/py-type.c: Use C++ exception handling.
6917 * python/py-symbol.c: Use C++ exception handling.
6918 * python/py-record.c: Use C++ exception handling.
6919 * python/py-record-btrace.c: Use C++ exception handling.
6920 * python/py-progspace.c: Use C++ exception handling.
6921 * python/py-prettyprint.c: Use C++ exception handling.
6922 * python/py-param.c: Use C++ exception handling.
6923 * python/py-objfile.c: Use C++ exception handling.
6924 * python/py-linetable.c: Use C++ exception handling.
6925 * python/py-lazy-string.c: Use C++ exception handling.
6926 * python/py-infthread.c: Use C++ exception handling.
6927 * python/py-inferior.c: Use C++ exception handling.
6928 * python/py-gdb-readline.c: Use C++ exception handling.
6929 * python/py-framefilter.c: Use C++ exception handling.
6930 * python/py-frame.c: Use C++ exception handling.
6931 * python/py-finishbreakpoint.c: Use C++ exception handling.
6932 * python/py-cmd.c: Use C++ exception handling.
6933 * python/py-breakpoint.c: Use C++ exception handling.
6934 * python/py-arch.c: Use C++ exception handling.
6935 * printcmd.c: Use C++ exception handling.
6936 * ppc-linux-tdep.c: Use C++ exception handling.
6937 * parse.c: Use C++ exception handling.
6938 * p-valprint.c: Use C++ exception handling.
6939 * objc-lang.c: Use C++ exception handling.
6940 * mi/mi-main.c: Use C++ exception handling.
6941 * mi/mi-interp.c: Use C++ exception handling.
6942 * mi/mi-cmd-stack.c: Use C++ exception handling.
6943 * mi/mi-cmd-break.c: Use C++ exception handling.
6944 * main.c: Use C++ exception handling.
6945 * linux-thread-db.c: Use C++ exception handling.
6946 * linux-tdep.c: Use C++ exception handling.
6947 * linux-nat.c: Use C++ exception handling.
6948 * linux-fork.c: Use C++ exception handling.
6949 * linespec.c: Use C++ exception handling.
6950 * language.c: Use C++ exception handling.
6951 * jit.c: Use C++ exception handling.
6952 * infrun.c: Use C++ exception handling.
6953 * infcmd.c: Use C++ exception handling.
6954 * infcall.c: Use C++ exception handling.
6955 * inf-loop.c: Use C++ exception handling.
6956 * i386-tdep.c: Use C++ exception handling.
6957 * i386-linux-tdep.c: Use C++ exception handling.
6958 * guile/scm-value.c: Use C++ exception handling.
6959 * guile/scm-type.c: Use C++ exception handling.
6960 * guile/scm-symtab.c: Use C++ exception handling.
6961 * guile/scm-symbol.c: Use C++ exception handling.
6962 * guile/scm-pretty-print.c: Use C++ exception handling.
6963 * guile/scm-ports.c: Use C++ exception handling.
6964 * guile/scm-param.c: Use C++ exception handling.
6965 * guile/scm-math.c: Use C++ exception handling.
6966 * guile/scm-lazy-string.c: Use C++ exception handling.
6967 * guile/scm-frame.c: Use C++ exception handling.
6968 * guile/scm-disasm.c: Use C++ exception handling.
6969 * guile/scm-cmd.c: Use C++ exception handling.
6970 * guile/scm-breakpoint.c: Use C++ exception handling.
6971 * guile/scm-block.c: Use C++ exception handling.
6972 * guile/guile-internal.h: Use C++ exception handling.
6973 * gnu-v3-abi.c: Use C++ exception handling.
6974 * gdbtypes.c: Use C++ exception handling.
6975 * frame.c: Use C++ exception handling.
6976 * frame-unwind.c: Use C++ exception handling.
6977 * fbsd-tdep.c: Use C++ exception handling.
6978 * f-valprint.c: Use C++ exception handling.
6979 * exec.c: Use C++ exception handling.
6980 * event-top.c: Use C++ exception handling.
6981 * event-loop.c: Use C++ exception handling.
6982 * eval.c: Use C++ exception handling.
6983 * dwarf2read.c: Use C++ exception handling.
6984 * dwarf2loc.c: Use C++ exception handling.
6985 * dwarf2-frame.c: Use C++ exception handling.
6986 * dwarf2-frame-tailcall.c: Use C++ exception handling.
6987 * dwarf-index-write.c: Use C++ exception handling.
6988 * dwarf-index-cache.c: Use C++ exception handling.
6989 * dtrace-probe.c: Use C++ exception handling.
6990 * disasm-selftests.c: Use C++ exception handling.
6991 * darwin-nat.c: Use C++ exception handling.
6992 * cp-valprint.c: Use C++ exception handling.
6993 * cp-support.c: Use C++ exception handling.
6994 * cp-abi.c: Use C++ exception handling.
6995 * corelow.c: Use C++ exception handling.
6996 * completer.c: Use C++ exception handling.
6997 * compile/compile-object-run.c: Use C++ exception handling.
6998 * compile/compile-object-load.c: Use C++ exception handling.
6999 * compile/compile-cplus-symbols.c: Use C++ exception handling.
7000 * compile/compile-c-symbols.c: Use C++ exception handling.
7001 * common/selftest.c: Use C++ exception handling.
7002 * common/new-op.c: Use C++ exception handling.
7003 * cli/cli-script.c: Use C++ exception handling.
7004 * cli/cli-interp.c: Use C++ exception handling.
7005 * cli/cli-cmds.c: Use C++ exception handling.
7006 * c-varobj.c: Use C++ exception handling.
7007 * btrace.c: Use C++ exception handling.
7008 * breakpoint.c: Use C++ exception handling.
7009 * break-catch-throw.c: Use C++ exception handling.
7010 * arch-utils.c: Use C++ exception handling.
7011 * amd64-tdep.c: Use C++ exception handling.
7012 * ada-valprint.c: Use C++ exception handling.
7013 * ada-typeprint.c: Use C++ exception handling.
7014 * ada-lang.c: Use C++ exception handling.
7015 * aarch64-tdep.c: Use C++ exception handling.
7016
3d6e9d23
TT
70172019-04-08 Tom Tromey <tom@tromey.com>
7018
7019 * xml-support.c (gdb_xml_parser::parse): Update.
7020 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7021 * value.c (show_convenience): Update.
7022 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7023 (test_parse_flags_qcs): Update.
7024 * thread.c (thr_try_catch_cmd): Update.
7025 * target.c (target_translate_tls_address): Update.
7026 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7027 (info_frame_command_core, frame_apply_command_count): Update.
7028 * rust-exp.y (rust_lex_exception_test): Update.
7029 * riscv-tdep.c (riscv_print_one_register_info): Update.
7030 * remote.c (remote_target::enable_btrace): Update.
7031 * record-btrace.c (record_btrace_enable_warn): Update.
7032 * python/py-utils.c (gdbpy_convert_exception): Update.
7033 * printcmd.c (do_one_display, print_variable_and_value): Update.
7034 * mi/mi-main.c (mi_print_exception): Update.
7035 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7036 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7037 * linux-nat.c (linux_nat_target::attach): Update.
7038 * linux-fork.c (class scoped_switch_fork_info): Update.
7039 * infrun.c (displaced_step_prepare): Update.
7040 * infcall.c (call_function_by_hand_dummy): Update.
7041 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7042 * gnu-v3-abi.c (print_one_vtable): Update.
7043 * frame.c (get_prev_frame_always): Update.
7044 * f-valprint.c (info_common_command_for_block): Update.
7045 * exec.c (try_open_exec_file): Update.
7046 * exceptions.c (print_exception, exception_print)
7047 (exception_fprintf, exception_print_same): Update.
7048 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7049 * dwarf-index-cache.c (index_cache::store)
7050 (index_cache::lookup_gdb_index): Update.
7051 * darwin-nat.c (maybe_cache_shell): Update.
7052 * cp-valprint.c (cp_print_value_fields): Update.
7053 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7054 (gcc_cplus_symbol_address): Update.
7055 * compile/compile-c-symbols.c (gcc_convert_symbol)
7056 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7057 * common/selftest.c: Update.
7058 * common/common-exceptions.h (struct gdb_exception) <message>: Now
7059 a std::string.
7060 (exception_try_scope_entry, exception_try_scope_exit): Don't
7061 declare.
7062 (struct exception_try_scope): Remove.
7063 (TRY): Don't use exception_try_scope.
7064 (struct gdb_exception): Add constructor, operator=.
7065 <what>: New method.
7066 (struct gdb_exception_RETURN_MASK_ALL)
7067 (struct gdb_exception_RETURN_MASK_ERROR)
7068 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7069 (struct gdb_quit_bad_alloc): Update.
7070 * common/common-exceptions.c (exception_none): Change
7071 initializer.
7072 (struct catcher) <state, exception>: Initialize inline.
7073 <prev>: Remove member.
7074 (current_catcher): Remove.
7075 (catchers): New global.
7076 (exceptions_state_mc_init): Simplify.
7077 (catcher_pop): Remove.
7078 (exceptions_state_mc, exceptions_state_mc_catch): Update.
7079 (try_scope_depth, exception_try_scope_entry)
7080 (exception_try_scope_exit): Remove.
7081 (throw_exception_sjlj): Update.
7082 (exception_messages, exception_messages_size): Remove.
7083 (throw_it): Simplify.
7084 (gdb_exception_sliced_copy): Remove.
7085 (throw_exception_cxx): Update.
7086 * cli/cli-script.c (script_from_file): Update.
7087 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7088 Update.
7089 * ada-valprint.c (ada_val_print): Update.
7090 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7091 (create_excep_cond_exprs): Update.
7092
c5c10118
TT
70932019-04-08 Tom Tromey <tom@tromey.com>
7094
7095 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7096 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7097 (TRY, CATCH, END_CATCH): Remove some definitions.
7098 * common/common-exceptions.c: Don't use GDB_XCPT.
7099 (catcher_list_size): Remove.
7100 (throw_exception, throw_it): Simplify.
7101
4de283e4
TT
71022019-04-05 Tom Tromey <tom@tromey.com>
7103
7104 Revert the header-sorting patch.
7105 * ft32-tdep.c: Revert.
7106 * frv-tdep.c: Revert.
7107 * frv-linux-tdep.c: Revert.
7108 * frame.c: Revert.
7109 * frame-unwind.c: Revert.
7110 * frame-base.c: Revert.
7111 * fork-child.c: Revert.
7112 * findvar.c: Revert.
7113 * findcmd.c: Revert.
7114 * filesystem.c: Revert.
7115 * filename-seen-cache.h: Revert.
7116 * filename-seen-cache.c: Revert.
7117 * fbsd-tdep.c: Revert.
7118 * fbsd-nat.h: Revert.
7119 * fbsd-nat.c: Revert.
7120 * f-valprint.c: Revert.
7121 * f-typeprint.c: Revert.
7122 * f-lang.c: Revert.
7123 * extension.h: Revert.
7124 * extension.c: Revert.
7125 * extension-priv.h: Revert.
7126 * expprint.c: Revert.
7127 * exec.h: Revert.
7128 * exec.c: Revert.
7129 * exceptions.c: Revert.
7130 * event-top.c: Revert.
7131 * event-loop.c: Revert.
7132 * eval.c: Revert.
7133 * elfread.c: Revert.
7134 * dwarf2read.h: Revert.
7135 * dwarf2read.c: Revert.
7136 * dwarf2loc.c: Revert.
7137 * dwarf2expr.h: Revert.
7138 * dwarf2expr.c: Revert.
7139 * dwarf2-frame.c: Revert.
7140 * dwarf2-frame-tailcall.c: Revert.
7141 * dwarf-index-write.h: Revert.
7142 * dwarf-index-write.c: Revert.
7143 * dwarf-index-common.c: Revert.
7144 * dwarf-index-cache.h: Revert.
7145 * dwarf-index-cache.c: Revert.
7146 * dummy-frame.c: Revert.
7147 * dtrace-probe.c: Revert.
7148 * disasm.h: Revert.
7149 * disasm.c: Revert.
7150 * disasm-selftests.c: Revert.
7151 * dictionary.c: Revert.
7152 * dicos-tdep.c: Revert.
7153 * demangle.c: Revert.
7154 * dcache.h: Revert.
7155 * dcache.c: Revert.
7156 * darwin-nat.h: Revert.
7157 * darwin-nat.c: Revert.
7158 * darwin-nat-info.c: Revert.
7159 * d-valprint.c: Revert.
7160 * d-namespace.c: Revert.
7161 * d-lang.c: Revert.
7162 * ctf.c: Revert.
7163 * csky-tdep.c: Revert.
7164 * csky-linux-tdep.c: Revert.
7165 * cris-tdep.c: Revert.
7166 * cris-linux-tdep.c: Revert.
7167 * cp-valprint.c: Revert.
7168 * cp-support.c: Revert.
7169 * cp-namespace.c: Revert.
7170 * cp-abi.c: Revert.
7171 * corelow.c: Revert.
7172 * corefile.c: Revert.
7173 * continuations.c: Revert.
7174 * completer.h: Revert.
7175 * completer.c: Revert.
7176 * complaints.c: Revert.
7177 * coffread.c: Revert.
7178 * coff-pe-read.c: Revert.
7179 * cli-out.h: Revert.
7180 * cli-out.c: Revert.
7181 * charset.c: Revert.
7182 * c-varobj.c: Revert.
7183 * c-valprint.c: Revert.
7184 * c-typeprint.c: Revert.
7185 * c-lang.c: Revert.
7186 * buildsym.c: Revert.
7187 * buildsym-legacy.c: Revert.
7188 * build-id.h: Revert.
7189 * build-id.c: Revert.
7190 * btrace.c: Revert.
7191 * bsd-uthread.c: Revert.
7192 * breakpoint.h: Revert.
7193 * breakpoint.c: Revert.
7194 * break-catch-throw.c: Revert.
7195 * break-catch-syscall.c: Revert.
7196 * break-catch-sig.c: Revert.
7197 * blockframe.c: Revert.
7198 * block.c: Revert.
7199 * bfin-tdep.c: Revert.
7200 * bfin-linux-tdep.c: Revert.
7201 * bfd-target.c: Revert.
7202 * bcache.c: Revert.
7203 * ax-general.c: Revert.
7204 * ax-gdb.h: Revert.
7205 * ax-gdb.c: Revert.
7206 * avr-tdep.c: Revert.
7207 * auxv.c: Revert.
7208 * auto-load.c: Revert.
7209 * arm-wince-tdep.c: Revert.
7210 * arm-tdep.c: Revert.
7211 * arm-symbian-tdep.c: Revert.
7212 * arm-pikeos-tdep.c: Revert.
7213 * arm-obsd-tdep.c: Revert.
7214 * arm-nbsd-tdep.c: Revert.
7215 * arm-nbsd-nat.c: Revert.
7216 * arm-linux-tdep.c: Revert.
7217 * arm-linux-nat.c: Revert.
7218 * arm-fbsd-tdep.c: Revert.
7219 * arm-fbsd-nat.c: Revert.
7220 * arm-bsd-tdep.c: Revert.
7221 * arch-utils.c: Revert.
7222 * arc-tdep.c: Revert.
7223 * arc-newlib-tdep.c: Revert.
7224 * annotate.h: Revert.
7225 * annotate.c: Revert.
7226 * amd64-windows-tdep.c: Revert.
7227 * amd64-windows-nat.c: Revert.
7228 * amd64-tdep.c: Revert.
7229 * amd64-sol2-tdep.c: Revert.
7230 * amd64-obsd-tdep.c: Revert.
7231 * amd64-obsd-nat.c: Revert.
7232 * amd64-nbsd-tdep.c: Revert.
7233 * amd64-nbsd-nat.c: Revert.
7234 * amd64-nat.c: Revert.
7235 * amd64-linux-tdep.c: Revert.
7236 * amd64-linux-nat.c: Revert.
7237 * amd64-fbsd-tdep.c: Revert.
7238 * amd64-fbsd-nat.c: Revert.
7239 * amd64-dicos-tdep.c: Revert.
7240 * amd64-darwin-tdep.c: Revert.
7241 * amd64-bsd-nat.c: Revert.
7242 * alpha-tdep.c: Revert.
7243 * alpha-obsd-tdep.c: Revert.
7244 * alpha-nbsd-tdep.c: Revert.
7245 * alpha-mdebug-tdep.c: Revert.
7246 * alpha-linux-tdep.c: Revert.
7247 * alpha-linux-nat.c: Revert.
7248 * alpha-bsd-tdep.c: Revert.
7249 * alpha-bsd-nat.c: Revert.
7250 * aix-thread.c: Revert.
7251 * agent.c: Revert.
7252 * addrmap.c: Revert.
7253 * ada-varobj.c: Revert.
7254 * ada-valprint.c: Revert.
7255 * ada-typeprint.c: Revert.
7256 * ada-tasks.c: Revert.
7257 * ada-lang.c: Revert.
7258 * aarch64-tdep.c: Revert.
7259 * aarch64-ravenscar-thread.c: Revert.
7260 * aarch64-newlib-tdep.c: Revert.
7261 * aarch64-linux-tdep.c: Revert.
7262 * aarch64-linux-nat.c: Revert.
7263 * aarch64-fbsd-tdep.c: Revert.
7264 * aarch64-fbsd-nat.c: Revert.
7265 * aarch32-linux-nat.c: Revert.
7266
d55e5aa6
TT
72672019-04-05 Tom Tromey <tom@tromey.com>
7268
7269 * ft32-tdep.c: Sort headers.
7270 * frv-tdep.c: Sort headers.
7271 * frv-linux-tdep.c: Sort headers.
7272 * frame.c: Sort headers.
7273 * frame-unwind.c: Sort headers.
7274 * frame-base.c: Sort headers.
7275 * fork-child.c: Sort headers.
7276 * findvar.c: Sort headers.
7277 * findcmd.c: Sort headers.
7278 * filesystem.c: Sort headers.
7279 * filename-seen-cache.h: Sort headers.
7280 * filename-seen-cache.c: Sort headers.
7281 * fbsd-tdep.c: Sort headers.
7282 * fbsd-nat.h: Sort headers.
7283 * fbsd-nat.c: Sort headers.
7284 * f-valprint.c: Sort headers.
7285 * f-typeprint.c: Sort headers.
7286 * f-lang.c: Sort headers.
7287 * extension.h: Sort headers.
7288 * extension.c: Sort headers.
7289 * extension-priv.h: Sort headers.
7290 * expprint.c: Sort headers.
7291 * exec.h: Sort headers.
7292 * exec.c: Sort headers.
7293 * exceptions.c: Sort headers.
7294 * event-top.c: Sort headers.
7295 * event-loop.c: Sort headers.
7296 * eval.c: Sort headers.
7297 * elfread.c: Sort headers.
7298 * dwarf2read.h: Sort headers.
7299 * dwarf2read.c: Sort headers.
7300 * dwarf2loc.c: Sort headers.
7301 * dwarf2expr.h: Sort headers.
7302 * dwarf2expr.c: Sort headers.
7303 * dwarf2-frame.c: Sort headers.
7304 * dwarf2-frame-tailcall.c: Sort headers.
7305 * dwarf-index-write.h: Sort headers.
7306 * dwarf-index-write.c: Sort headers.
7307 * dwarf-index-common.c: Sort headers.
7308 * dwarf-index-cache.h: Sort headers.
7309 * dwarf-index-cache.c: Sort headers.
7310 * dummy-frame.c: Sort headers.
7311 * dtrace-probe.c: Sort headers.
7312 * disasm.h: Sort headers.
7313 * disasm.c: Sort headers.
7314 * disasm-selftests.c: Sort headers.
7315 * dictionary.c: Sort headers.
7316 * dicos-tdep.c: Sort headers.
7317 * demangle.c: Sort headers.
7318 * dcache.h: Sort headers.
7319 * dcache.c: Sort headers.
7320 * darwin-nat.h: Sort headers.
7321 * darwin-nat.c: Sort headers.
7322 * darwin-nat-info.c: Sort headers.
7323 * d-valprint.c: Sort headers.
7324 * d-namespace.c: Sort headers.
7325 * d-lang.c: Sort headers.
7326 * ctf.c: Sort headers.
7327 * csky-tdep.c: Sort headers.
7328 * csky-linux-tdep.c: Sort headers.
7329 * cris-tdep.c: Sort headers.
7330 * cris-linux-tdep.c: Sort headers.
7331 * cp-valprint.c: Sort headers.
7332 * cp-support.c: Sort headers.
7333 * cp-namespace.c: Sort headers.
7334 * cp-abi.c: Sort headers.
7335 * corelow.c: Sort headers.
7336 * corefile.c: Sort headers.
7337 * continuations.c: Sort headers.
7338 * completer.h: Sort headers.
7339 * completer.c: Sort headers.
7340 * complaints.c: Sort headers.
7341 * coffread.c: Sort headers.
7342 * coff-pe-read.c: Sort headers.
7343 * cli-out.h: Sort headers.
7344 * cli-out.c: Sort headers.
7345 * charset.c: Sort headers.
7346 * c-varobj.c: Sort headers.
7347 * c-valprint.c: Sort headers.
7348 * c-typeprint.c: Sort headers.
7349 * c-lang.c: Sort headers.
7350 * buildsym.c: Sort headers.
7351 * buildsym-legacy.c: Sort headers.
7352 * build-id.h: Sort headers.
7353 * build-id.c: Sort headers.
7354 * btrace.c: Sort headers.
7355 * bsd-uthread.c: Sort headers.
7356 * breakpoint.h: Sort headers.
7357 * breakpoint.c: Sort headers.
7358 * break-catch-throw.c: Sort headers.
7359 * break-catch-syscall.c: Sort headers.
7360 * break-catch-sig.c: Sort headers.
7361 * blockframe.c: Sort headers.
7362 * block.c: Sort headers.
7363 * bfin-tdep.c: Sort headers.
7364 * bfin-linux-tdep.c: Sort headers.
7365 * bfd-target.c: Sort headers.
7366 * bcache.c: Sort headers.
7367 * ax-general.c: Sort headers.
7368 * ax-gdb.h: Sort headers.
7369 * ax-gdb.c: Sort headers.
7370 * avr-tdep.c: Sort headers.
7371 * auxv.c: Sort headers.
7372 * auto-load.c: Sort headers.
7373 * arm-wince-tdep.c: Sort headers.
7374 * arm-tdep.c: Sort headers.
7375 * arm-symbian-tdep.c: Sort headers.
7376 * arm-pikeos-tdep.c: Sort headers.
7377 * arm-obsd-tdep.c: Sort headers.
7378 * arm-nbsd-tdep.c: Sort headers.
7379 * arm-nbsd-nat.c: Sort headers.
7380 * arm-linux-tdep.c: Sort headers.
7381 * arm-linux-nat.c: Sort headers.
7382 * arm-fbsd-tdep.c: Sort headers.
7383 * arm-fbsd-nat.c: Sort headers.
7384 * arm-bsd-tdep.c: Sort headers.
7385 * arch-utils.c: Sort headers.
7386 * arc-tdep.c: Sort headers.
7387 * arc-newlib-tdep.c: Sort headers.
7388 * annotate.h: Sort headers.
7389 * annotate.c: Sort headers.
7390 * amd64-windows-tdep.c: Sort headers.
7391 * amd64-windows-nat.c: Sort headers.
7392 * amd64-tdep.c: Sort headers.
7393 * amd64-sol2-tdep.c: Sort headers.
7394 * amd64-obsd-tdep.c: Sort headers.
7395 * amd64-obsd-nat.c: Sort headers.
7396 * amd64-nbsd-tdep.c: Sort headers.
7397 * amd64-nbsd-nat.c: Sort headers.
7398 * amd64-nat.c: Sort headers.
7399 * amd64-linux-tdep.c: Sort headers.
7400 * amd64-linux-nat.c: Sort headers.
7401 * amd64-fbsd-tdep.c: Sort headers.
7402 * amd64-fbsd-nat.c: Sort headers.
7403 * amd64-dicos-tdep.c: Sort headers.
7404 * amd64-darwin-tdep.c: Sort headers.
7405 * amd64-bsd-nat.c: Sort headers.
7406 * alpha-tdep.c: Sort headers.
7407 * alpha-obsd-tdep.c: Sort headers.
7408 * alpha-nbsd-tdep.c: Sort headers.
7409 * alpha-mdebug-tdep.c: Sort headers.
7410 * alpha-linux-tdep.c: Sort headers.
7411 * alpha-linux-nat.c: Sort headers.
7412 * alpha-bsd-tdep.c: Sort headers.
7413 * alpha-bsd-nat.c: Sort headers.
7414 * aix-thread.c: Sort headers.
7415 * agent.c: Sort headers.
7416 * addrmap.c: Sort headers.
7417 * ada-varobj.c: Sort headers.
7418 * ada-valprint.c: Sort headers.
7419 * ada-typeprint.c: Sort headers.
7420 * ada-tasks.c: Sort headers.
7421 * ada-lang.c: Sort headers.
7422 * aarch64-tdep.c: Sort headers.
7423 * aarch64-ravenscar-thread.c: Sort headers.
7424 * aarch64-newlib-tdep.c: Sort headers.
7425 * aarch64-linux-tdep.c: Sort headers.
7426 * aarch64-linux-nat.c: Sort headers.
7427 * aarch64-fbsd-tdep.c: Sort headers.
7428 * aarch64-fbsd-nat.c: Sort headers.
7429 * aarch32-linux-nat.c: Sort headers.
7430
699bd4cf
TT
74312019-04-04 Tom Tromey <tom@tromey.com>
7432
7433 * varobj.c (varobj_create): Update.
7434 * rust-exp.y (struct rust_parser) <update_innermost_block,
7435 lookup_symbol>: New methods.
7436 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7437 Rename.
7438 (rust_parser::rust_lookup_type)
7439 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7440 * printcmd.c (display_command, do_one_display): Update.
7441 * parser-defs.h (struct parser_state) <parser_state>: Add
7442 "tracker" parameter.
7443 (block_tracker): New member.
7444 (class innermost_block_tracker) <innermost_block_tracker>: Add
7445 "types" parameter.
7446 <reset>: Remove method.
7447 (innermost_block): Don't declare.
7448 (null_post_parser): Update.
7449 * parse.c (innermost_block): Remove global.
7450 (write_dollar_variable): Update.
7451 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7452 Remove "tracker_types" parameter.
7453 (parse_expression): Add "tracker" parameter.
7454 (parse_expression_for_completion): Update.
7455 (null_post_parser): Add "tracker" parameter.
7456 * p-exp.y: Update rules.
7457 * m2-exp.y: Update rules.
7458 * language.h (struct language_defn) <la_post_parser>: Add
7459 "tracker" parameter.
7460 * go-exp.y: Update rules.
7461 * f-exp.y: Update rules.
7462 * expression.h (parse_expression, parse_exp_1): Add "tracker"
7463 parameter.
7464 * d-exp.y: Update rules.
7465 * c-exp.y: Update rules.
7466 * breakpoint.c (set_breakpoint_condition): Create an
7467 innermost_block_tracker.
7468 (watch_command_1): Likewise.
7469 * ada-lang.c (resolve): Add "tracker" parameter.
7470 (resolve_subexp): Likewise.
7471 * ada-exp.y (write_var_from_sym): Update.
7472
dac43e32
TT
74732019-04-04 Tom Tromey <tom@tromey.com>
7474
7475 * type-stack.h: New file.
7476 * type-stack.c: New file.
7477 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7478 type-stack.h.
7479 (insert_into_type_stack, insert_type, push_type, push_type_int)
7480 (insert_type_address_space, pop_type, pop_type_int)
7481 (pop_typelist, pop_type_stack, append_type_stack)
7482 (push_type_stack, get_type_stack, push_typelist)
7483 (follow_type_instance_flags, follow_types): Don't declare.
7484 * parse.c (type_stack): Remove global.
7485 (parse_exp_in_context): Update.
7486 (insert_into_type_stack, insert_type, push_type, push_type_int)
7487 (insert_type_address_space, pop_type, pop_type_int)
7488 (pop_typelist, pop_type_stack, append_type_stack)
7489 (push_type_stack, get_type_stack, push_typelist)
7490 (follow_type_instance_flags, follow_types): Remove (moved to
7491 type-stack.c).
7492 * f-exp.y (type_stack): New global.
7493 Update rules.
7494 (push_kind_type, f_parse): Update.
7495 * d-exp.y (type_stack): New global.
7496 Update rules.
7497 (d_parse): Update.
7498 * c-exp.y (struct c_parse_state) <type_stack>: New member.
7499 Update rules.
7500 * Makefile.in (COMMON_SFILES): Add type-stack.c.
7501 (HFILES_NO_SRCDIR): Add type-stack.h.
7502
2a612529
TT
75032019-04-04 Tom Tromey <tom@tromey.com>
7504
7505 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
7506 (rust_parser::convert_ast_to_expression, rust_parse)
7507 (rust_lex_test_completion, rust_lex_tests): Update.
7508 * parser-defs.h (struct expr_completion_state): New.
7509 (struct parser_state) <parser_state>: Add completion parameter.
7510 <mark_struct_expression, mark_completion_tag>: New methods.
7511 <parse_completion, m_completion_state>: New members.
7512 (prefixify_expression, null_post_parser): Update.
7513 (mark_struct_expression, mark_completion_tag): Don't declare.
7514 * parse.c (parse_completion, expout_last_struct)
7515 (expout_tag_completion_type, expout_completion_name): Remove
7516 globals.
7517 (parser_state::mark_struct_expression)
7518 (parser_state::mark_completion_tag): Now methods.
7519 (prefixify_expression): Add last_struct parameter.
7520 (prefixify_subexp): Likewise.
7521 (parse_exp_1): Update.
7522 (parse_exp_in_context): Add cstate parameter. Update.
7523 (parse_expression_for_completion): Create an
7524 expr_completion_state.
7525 (null_post_parser): Add "completion" parameter.
7526 * p-exp.y: Update rules.
7527 (yylex): Update.
7528 * language.h (struct language_defn) <la_post_parser>: Add
7529 "completing" parameter.
7530 * go-exp.y: Update rules.
7531 (lex_one_token): Update.
7532 * expression.h (parse_completion): Don't declare.
7533 * d-exp.y: Update rules.
7534 (lex_one_token): Update rules.
7535 * c-exp.y: Update rules.
7536 (lex_one_token): Update.
7537 * ada-lang.c (resolve): Add "parse_completion" parameter.
7538 (resolve_subexp): Likewise.
7539 (ada_resolve_function): Likewise.
7540
43476f0b
TT
75412019-04-04 Tom Tromey <tom@tromey.com>
7542
7543 * parser-defs.h (struct parser_state) <start_arglist,
7544 end_arglist>: New methods.
7545 <arglist_len, m_funcall_chain>: New members.
7546 (arglist_len, start_arglist, end_arglist): Don't declare.
7547 * parse.c (arglist_len, funcall_chain): Remove global.
7548 (start_arglist, end_arglist): Remove functions.
7549 (parse_exp_in_context): Update.
7550 * p-exp.y: Update rules.
7551 * m2-exp.y: Update rules.
7552 * go-exp.y: Update rules.
7553 * f-exp.y: Update rules.
7554 * d-exp.y: Update rules.
7555 * c-exp.y: Update rules.
7556
5776fca3
TT
75572019-04-04 Tom Tromey <tom@tromey.com>
7558
7559 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
7560 lex_operator, push_back>: New methods.
7561 Update all rules.
7562 (rust_parser::lex_hex, lex_escape): Rename and update.
7563 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
7564 (rust_parser::lex_operator): Rename and update.
7565 (rust_parser::lex_number, rustyylex, rustyyerror)
7566 (rust_lex_test_init, rust_lex_test_sequence)
7567 (rust_lex_test_push_back, rust_lex_tests): Update.
7568 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
7569 parameter.
7570 <lexptr, prev_lexptr>: New members.
7571 (lexptr, prev_lexptr): Don't declare.
7572 * parse.c (lexptr, prev_lexptr): Remove globals.
7573 (parse_exp_in_context): Update.
7574 * p-exp.y (yylex, yyerror): Update.
7575 * m2-exp.y (parse_number, yylex, yyerror): Update.
7576 * go-exp.y (lex_one_token, yyerror): Update.
7577 * f-exp.y (match_string_literal, yylex, yyerror): Update.
7578 * d-exp.y (lex_one_token, yyerror): Update.
7579 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
7580 (lex_one_token, yyerror): Update.
7581 * ada-lex.l (YY_INPUT): Update.
7582 (rewind_to_char): Update.
7583 * ada-exp.y (yyerror): Update.
7584
8621b685
TT
75852019-04-04 Tom Tromey <tom@tromey.com>
7586
7587 * rust-exp.y (rustyylex, rust_lex_tests): Update.
7588 * parser-defs.h (struct parser_state) <parser_state>: Add new
7589 parameter.
7590 <comma_terminates>: New member.
7591 (comma_terminates): Don't declare global.
7592 * parse.c (comma_terminates): Remove global.
7593 (parse_exp_in_context): Update.
7594 * p-exp.y (yylex): Update.
7595 * m2-exp.y (yylex): Update.
7596 * go-exp.y (lex_one_token): Update.
7597 * f-exp.y (yylex): Update.
7598 * d-exp.y (lex_one_token): Update.
7599 * c-exp.y (lex_one_token): Update.
7600 * ada-lex.l: Update.
7601
28aaf3fd
TT
76022019-04-04 Tom Tromey <tom@tromey.com>
7603
7604 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
7605 (rustyylex, rust_lex_test_init, rust_lex_test_one)
7606 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
7607 * parser-defs.h (paren_depth): Don't declare.
7608 * parse.c (paren_depth): Remove global.
7609 (parse_exp_in_context): Update.
7610 * p-exp.y (paren_depth): New global.
7611 (pascal_parse): Initialize it.
7612 * m2-exp.y (paren_depth): New global.
7613 (m2_parse): Initialize it.
7614 * go-exp.y (paren_depth): New global.
7615 (go_parse): Initialize it.
7616 * f-exp.y (paren_depth): New global.
7617 (f_parse): Initialize it.
7618 * d-exp.y (paren_depth): New global.
7619 (d_parse): Initialize it.
7620 * c-exp.y (paren_depth): New global.
7621 (c_parse): Initialize it.
7622 * ada-lex.l (paren_depth): New global.
7623 (lexer_init): Initialize it.
7624
1e58a4a4
TT
76252019-04-04 Tom Tromey <tom@tromey.com>
7626
7627 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
7628 (rust_parser::convert_ast_to_type)
7629 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7630 * parser-defs.h (struct parser_state) <parser_state>: Add
7631 parameters. Initialize new members.
7632 <expression_context_block, expression_context_pc>: New members.
7633 * parse.c (expression_context_block, expression_context_pc):
7634 Remove globals.
7635 (parse_exp_in_context): Update.
7636 * p-exp.y: Update all rules.
7637 (yylex): Update.
7638 * m2-exp.y: Update all rules.
7639 (yylex): Update.
7640 * go-exp.y (yylex): Update.
7641 * f-exp.y (yylex): Update.
7642 * d-exp.y: Update all rules.
7643 (yylex): Update.
7644 * c-exp.y: Update all rules.
7645 (lex_one_token, classify_name, yylex, c_parse): Update.
7646 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
7647
37eedb39
TT
76482019-04-04 Tom Tromey <tom@tromey.com>
7649
7650 * gdbarch.h, gdbarch.c: Rebuild.
7651 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
7652 * stap-probe.h:
7653 (struct stap_parse_info): Replace "parser_state" with
7654 "expr_builder".
7655 * parser-defs.h (struct expr_builder): Rename from "parser_state".
7656 (parser_state): New class.
7657 * parse.c (expr_builder): Rename.
7658 (expr_builder::release): Rename.
7659 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
7660 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
7661 (write_exp_elt_longcst, write_exp_elt_floatcst)
7662 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
7663 (write_exp_string_vector, write_exp_bitstring)
7664 (write_exp_msymbol, mark_struct_expression)
7665 (write_dollar_variable)
7666 (insert_type_address_space, increase_expout_size): Replace
7667 "parser_state" with "expr_builder".
7668 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
7669 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
7670 "parser_state" with "expr_builder".
7671
73923d7e
TT
76722019-04-04 Tom Tromey <tom@tromey.com>
7673
7674 * rust-exp.y: Replace "parse_language" with method call.
7675 * p-exp.y:
7676 (yylex): Replace "parse_language" with method call.
7677 * m2-exp.y:
7678 (yylex): Replace "parse_language" with method call.
7679 * go-exp.y (classify_name): Replace "parse_language" with method
7680 call.
7681 * f-exp.y (yylex): Replace "parse_language" with method call.
7682 * d-exp.y (lex_one_token): Replace "parse_language" with method
7683 call.
7684 * c-exp.y:
7685 (lex_one_token, classify_name, yylex): Replace "parse_language"
7686 with method call.
7687 * ada-exp.y (find_primitive_type, type_char)
7688 (type_system_address): Replace "parse_language" with method call.
7689
fa9f5be6
TT
76902019-04-04 Tom Tromey <tom@tromey.com>
7691
7692 * rust-exp.y: Replace "parse_gdbarch" with method call.
7693 * parse.c (write_dollar_variable, insert_type_address_space):
7694 Replace "parse_gdbarch" with method call.
7695 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
7696 call.
7697 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
7698 call.
7699 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
7700 "parse_gdbarch" with method call.
7701 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
7702 with method call.
7703 * f-exp.y (parse_type, parse_f_type, yylex): Replace
7704 "parse_gdbarch" with method call.
7705 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
7706 "parse_gdbarch" with method call.
7707 * c-exp.y (parse_type, parse_number, classify_name): Replace
7708 "parse_gdbarch" with method call.
7709 * ada-lex.l: Replace "parse_gdbarch" with method call.
7710 * ada-exp.y (parse_type, find_primitive_type, type_char)
7711 (type_system_address): Replace "parse_gdbarch" with method call.
7712
1201a264
TT
77132019-04-04 Tom Tromey <tom@tromey.com>
7714
7715 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
7716 * stap-probe.c (stap_parse_argument): Update.
7717 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
7718 initial_size parameter.
7719 * rust-exp.y (rust_lex_tests): Update.
7720 * parse.c (parser_state): Update.
7721 (parse_exp_in_context): Update.
7722 * parser-defs.h (struct parser_state) <parser_state>: Remove
7723 "initial_size" parameter.
7724
e3980ce2
TT
77252019-04-04 Tom Tromey <tom@tromey.com>
7726
7727 * parser-defs.h (increase_expout_size): Don't declare.
7728 * parse.c (increase_expout_size): Now static.
7729
e9f8e3f1
TS
77302019-04-04 Thomas Schwinge <thomas@codesourcery.com>
7731
7732 * gnu-nat.c (gnu_nat_target::wait): Fix
7733 target_waitstatus_to_string call.
7734
d7df6549
AB
77352019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7736
7737 * eval.c (evaluate_subexp_standard): Handle internal functions
7738 during Fortran function call handling.
7739
8bdc1658
AB
77402019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
7741
7742 * NEWS: Mention new internal functions.
7743 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
7744 (read_base_type): Use dwarf2_init_complex_target_type.
7745 * value.c (creal_internal_fn): New function.
7746 (cimag_internal_fn): New function.
7747 (_initialize_values): Register new internal functions.
7748
c29705b7
PW
77492019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7750
7751 * infrun.c (stop_all_threads): If debug_infrun, always
7752 trace the wait status after wait_one, using
7753 target_waitstatus_to_string and target_pid_to_str.
7754 (handle_inferior_event): Replace various trace of
7755 wait status kind by a single trace.
7756 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
7757 wait status kind image by target_waitstatus_to_string.
7758 * target/waitstatus.c (target_waitstatus_to_string): Fix
7759 obsolete comment.
7760
05caa1d2
TT
77612019-04-01 Tom Tromey <tromey@adacore.com>
7762
7763 PR symtab/23331:
7764 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
7765
9d1447e0
SDJ
77662019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
7767 Pedro Alves <palves@redhat.com>
7768
7769 * top.c (quit_force): Call 'finalize_values'.
7770 * value.c (finalize_values): New function.
7771 * value.h (finalize_values): Declare.
7772
7734102d
EZ
77732019-03-30 Eli Zaretskii <eliz@gnu.org>
7774
7775 * NEWS: Announce $_gdb_major and $_gdb_minor.
7776
7777 * top.c (init_gdb_version_vars): New function.
7778 (gdb_init): Call init_gdb_version_vars.
7779
188e1fa9
TT
77802019-03-29 Tom Tromey <tromey@adacore.com>
7781
7782 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
7783 help text. Remove dead code.
7784
2880242d
KS
77852019-03-29 Keith Seitz <keiths@redhat.com>
7786
7787 From Siddhesh Poyarekar:
7788 * f-lang.h (f77_get_upperbound): Return LONGEST.
7789 (f77_get_lowerbound): Likewise.
7790 * f-typeprint.c (f_type_print_varspec_suffix): Expand
7791 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
7792 print them.
7793 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
7794 plongest to format print it.
7795 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
7796 (f77_get_upperbound): Likewise.
7797 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
7798 LOWER_BOUND to LONGEST.
7799 (f77_create_arrayprint_offset_tbl): Likewise.
7800
cc1defb1
KS
78012019-03-29 Keith Seitz <keiths@redhat.com>
7802
7803 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
7804 %s/pulongest for TYPE_LENGTH instead of %d in format
7805 strings.
7806 * ada-typerint.c (ada_print_type): Likewise.
7807 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
7808 * compile/compile-c-support.c (generate_register_struct): Likewise.
7809 * gdbtypes.c (recursive_dump_type): Likewise.
7810 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
7811 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
7812 instead of %d in format strings.
7813 * riscv-tdep.c (riscv_type_alignment): Cast second argument
7814 to std::min to ULONGEST.
7815 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
7816 instead of %d in format strings.
7817 * tracepoint.c (info_scope_command): Likewise.
7818 * typeprint.c (print_offset_data::update)
7819 (print_offset_data::finish): Likewise.
7820 * xtensa-tdep.c (xtensa_store_return_value)
7821 (xtensa_push_dummy_call): Likewise.
7822
e432ccf1
JT
78232019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
7824
7825 * windows-nat.c (display_selector): Fixed format specifications
7826 for 64-bit Cygwin.
7827
65d2b333
PW
78282019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7829
7830 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
7831
f489207e
SL
78322019-03-28 Sandra Loosemore <sandra@codesourcery.com>
7833
7834 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
7835 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
7836 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
7837 (nios2_linux_init_abi): Install it.
7838
bffa1015
AH
78392019-03-28 Alan Hayward <alan.hayward@arm.com>
7840
7841 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
7842
fc96163a
AH
78432019-03-28 Alan Hayward <alan.hayward@arm.com>
7844
7845 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
7846
20dc7e9b
PW
78472019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7848 Tom Tromey <tromey@adacore.com>
7849
7850 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
7851
7f5331a8
JB
78522019-03-26 Joel Brobecker <brobecker@adacore.com>
7853
7854 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
7855 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
7856 method to compute the bounds of range types. Also print "[evaluated]"
7857 if the bounds' values come from a dynamic evaluation.
7858
18c77628
AB
78592019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
7860
7861 * cp-valprint.c (cp_print_value_fields): Don't print trailing
7862 whitespace when pretty printing is on.
7863
53c973f2
AH
78642019-03-26 Alan Hayward <alan.hayward@arm.com>
7865
e79be6e5 7866 * ppc-linux-nat.c: Add include.
53c973f2 7867
d851aa71
AH
78682019-03-26 Alan Hayward <alan.hayward@arm.com>
7869
e79be6e5 7870 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 7871
2fe7bab7
AH
78722019-03-26 Alan Hayward <alan.hayward@arm.com>
7873
e79be6e5 7874 * arm-linux-nat.c: Add include.
2fe7bab7 7875
068ef30e
SM
78762019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
7877
7878 * source-cache.c (source_cache::get_source_lines): Re-read
7879 fullname after calling open_source_file.
7880
81a24d04
JB
78812019-03-25 John Baldwin <jhb@FreeBSD.org>
7882
7883 * NEWS: Mention TLS support for FreeBSD.
7884
79e7ae11
TT
78852019-03-25 Tom Tromey <tromey@adacore.com>
7886
7887 * minsyms.c (BUNCH_SIZE): Update comment.
7888 (~minimal_symbol_reader): Remove old comment.
7889 (compact_minimal_symbols): Update comment.
7890 (minimal_symbol_reader::install): Remove old comment. Update
7891 other comments.
7892
d45963c2
AH
78932019-03-25 Alan Hayward <alan.hayward@arm.com>
7894
7895 * s390-linux-nat.c: Add include.
7896
0f83012e
AH
78972019-03-25 Alan Hayward <alan.hayward@arm.com>
7898
7899 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
7900 Call linux_get_hwcap.
7901 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
7902 Likewise.
7903 (aarch64_linux_get_hwcap): Remove function.
7904 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
7905 declaration.
7906 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
7907 linux_get_hwcap.
7908 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
7909 * linux-tdep.c (linux_get_hwcap): Add function.
7910 (linux_get_hwcap2): Likewise.
7911 * linux-tdep.h (linux_get_hwcap): Add declaration.
7912 (linux_get_hwcap2): Likewise.
7913 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
7914 (ppc_linux_get_hwcap2): Likewise.
7915 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
7916 linux_get_hwcap.
7917 (ppc_linux_nat_target::insert_watchpoint): Likewise.
7918 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
7919 (ppc_linux_nat_target::read_description): Likewise.
7920 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
7921 * s390-linux-nat.c: Likewise.
7922 * s390-linux-tdep.c (s390_core_read_description): Likewise.
7923
6640a367
TT
79242019-03-24 Tom Tromey <tom@tromey.com>
7925
7926 * ada-lang.c (standard_lookup): Simplify initialization.
7927 (ada_lookup_symbol_nonlocal): Simplify return.
7928 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
7929 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
7930 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
7931 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
7932 initialization.
7933 * solib.c (solib_global_lookup): Simplify.
7934 * symtab.c (null_block_symbol): Remove.
7935 (symbol_cache_lookup): Simplify returns.
7936 (lookup_language_this): Simplify returns.
7937 (lookup_symbol_aux): Simplify return.
7938 (lookup_local_symbol): Simplify returns.
7939 (lookup_global_symbol_from_objfile): Simplify return.
7940 (lookup_symbol_in_objfile_symtabs)
7941 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
7942 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
7943 (lookup_static_symbol, lookup_global_symbol): Simplify return.
7944 * cp-namespace.c (cp_lookup_bare_symbol)
7945 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
7946 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
7947 (cp_lookup_nested_symbol): Don't use null_block_symbol.
7948 (cp_lookup_symbol_via_imports): Simplify initialization.
7949 (find_symbol_in_baseclass): Likewise.
7950 * symtab.h (null_block_symbol): Remove.
7951 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
7952 (d_lookup_nested_symbol, d_lookup_symbol_imports)
7953 (d_lookup_symbol_module): Likewise.
7954 (find_symbol_in_baseclass): Simplify initialization.
7955
a930ebcd
TT
79562019-03-24 Tom Tromey <tom@tromey.com>
7957
7958 * expression.h: Don't include symtab.h.
7959 (struct block): Forward declare.
7960
582942f4
TT
79612019-03-24 Tom Tromey <tom@tromey.com>
7962
7963 * c-exp.y (typebase): Remove casts.
7964 * gdbtypes.c (lookup_unsigned_typename, )
7965 (lookup_signed_typename): Remove cast.
7966 * eval.c (parse_to_comma_and_eval): Remove cast.
7967 * parse.c (write_dollar_variable): Remove cast.
7968 * block.h (struct block) <superblock>: Now const.
7969 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
7970 * psymtab.c (psym_map_matching_symbols): Make "block" const.
7971 (map_block): Make "block" const.
7972 * symfile.h (struct quick_symbol_functions)
7973 <map_matching_symbols>: Constify block argument to "callback".
7974 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
7975 const.
7976 (find_pc_sect_compunit_symtab): Make "b" const.
7977 (find_symbol_at_address): Likewise.
7978 (search_symbols): Likewise.
7979 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
7980 (dw2_debug_names_lookup_symbol): Likewise.
7981 (dw2_map_matching_symbols): Update.
7982 * p-valprint.c (pascal_val_print): Remove "block".
7983 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
7984 (aux_add_nonlocal_symbols): Make "block" const.
7985 (resolve_subexp): Remove cast.
7986 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
7987 const.
7988 (iterate_over_file_blocks): Likewise.
7989 * f-exp.y (%union) <bval>: Remove.
7990 * coffread.c (patch_opaque_types): Make "b" const.
7991 * spu-tdep.c (spu_catch_start): Make "block" const.
7992 * c-valprint.c (print_unpacked_pointer): Remove "block".
7993 * symmisc.c (dump_symtab_1): Make "b" const.
7994 (block_depth): Make "block" const.
7995 * d-exp.y (%union) <bval>: Remove.
7996 * cp-support.h (cp_lookup_rtti_type): Update.
7997 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
7998 * psymtab.c (psym_lookup_symbol): Make "block" const.
7999 (maintenance_check_psymtabs): Make "b" const.
8000 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8001 (enumerate_locals, enumerate_args): Update.
8002 * python/py-symtab.c (stpy_global_block): Make "block" const.
8003 (stpy_static_block): Likewise.
8004 * inline-frame.c (block_starting_point_at): Make "new_block"
8005 const.
8006 * block.c (find_block_in_blockvector): Make return type const.
8007 (blockvector_for_pc_sect): Make "b" const.
8008 (find_block_in_blockvector): Make "b" const.
8009
7ad417dd
TT
80102019-03-23 Tom Tromey <tom@tromey.com>
8011
8012 * varobj.c (varobj_create): Update.
8013 * symfile.c (clear_symtab_users): Don't reset innermost_block.
8014 * printcmd.c (display_command, do_one_display): Don't reset
8015 innermost_block.
8016 * parser-defs.h (enum innermost_block_tracker_type): Move to
8017 expression.h.
8018 (innermost_block): Update comment.
8019 * parse.c (parse_exp_1): Add tracker_types parameter.
8020 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
8021 tracker_types parameter. Reset innermost_block.
8022 (parse_exp_in_context): Remove.
8023 (parse_expression_for_completion): Update.
8024 * objfiles.c (~objfile): Don't reset expression_context_block or
8025 innermost_block.
8026 * expression.h (enum innermost_block_tracker_type): Move from
8027 parser-defs.h.
8028 (parse_exp_1): Add tracker_types parameter.
8029 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8030 reset innermost_block.
8031
b366c208
TT
80322019-03-23 Tom Tromey <tom@tromey.com>
8033
8034 * objfiles.h: Include bcache.h.
8035
9bb9b2f9
TT
80362019-03-23 Tom Tromey <tom@tromey.com>
8037
8038 * linespec.c (get_current_search_block): Use
8039 scoped_restore_current_language.
8040 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8041
59c28372
AH
80422019-03-22 Alan Hayward <alan.hayward@arm.com>
8043 Jiong Wang <jiong.wang@arm.com>
8044
8045 * aarch64-linux-tdep.c
8046 (aarch64_linux_iterate_over_regset_sections): Check for pauth
8047 section.
8048 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8049
17e116a7
AH
80502019-03-22 Alan Hayward <alan.hayward@arm.com>
8051 Jiong Wang <jiong.wang@arm.com>
8052
8053 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8054 instructions.
8055 (aarch64_analyze_prologue_test): Add PACIASP test.
8056 (aarch64_prologue_prev_register): Unmask PC value.
8057
11e1b75f
AH
80582019-03-22 Alan Hayward <alan.hayward@arm.com>
8059 Jiong Wang <jiong.wang@arm.com>
8060
8061 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8062 (aarch64_dwarf2_prev_register): Unmask PC value.
8063 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8064 (aarch64_execute_dwarf_cfa_vendor_op): Check for
8065 DW_CFA_AARCH64_negate_ra_state.
8066 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8067
34dcc7cf
AH
80682019-03-22 Alan Hayward <alan.hayward@arm.com>
8069 Jiong Wang <jiong.wang@arm.com>
8070
8071 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8072 registers.
8073 (aarch64_pseudo_register_name): Likewise.
8074 (aarch64_pseudo_register_type): Likewise.
8075 (aarch64_pseudo_register_reggroup_p): Likewise.
8076 (aarch64_gdbarch_init): Add pauth registers.
8077 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8078 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8079 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8080 (struct gdbarch_tdep): Add regnum for ra_state.
8081
1ef53e6b
AH
80822019-03-22 Alan Hayward <alan.hayward@arm.com>
8083 Jiong Wang <jiong.wang@arm.com>
8084
8085 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8086
76bed0fd
AH
80872019-03-22 Alan Hayward <alan.hayward@arm.com>
8088 Jiong Wang <jiong.wang@arm.com>
8089
8090 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8091 function.
8092 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8093 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8094 (aarch64_gdbarch_init): Add puth registers.
8095 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8096 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8097 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8098
ee4fbcfa
AH
80992019-03-22 Alan Hayward <alan.hayward@arm.com>
8100 Jiong Wang <jiong.wang@arm.com>
8101
8102 * aarch64-linux-nat.c
8103 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8104 * aarch64-linux-tdep.c
8105 (aarch64_linux_core_read_description): Likewise.
8106 (aarch64_linux_get_hwcap): New function.
8107 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8108 (aarch64_linux_get_hwcap): New declaration.
8109
6dc0ebde
AH
81102019-03-22 Alan Hayward <alan.hayward@arm.com>
8111 Jiong Wang <jiong.wang@arm.com>
8112
8113 * aarch64-linux-nat.c
8114 (aarch64_linux_nat_target::read_description): Add pauth param.
8115 * aarch64-linux-tdep.c
8116 (aarch64_linux_core_read_description): Likewise.
8117 * aarch64-tdep.c (struct target_desc): Add in pauth.
8118 (aarch64_read_description): Add pauth param.
8119 (aarch64_gdbarch_init): Likewise.
8120 * aarch64-tdep.h (aarch64_read_description): Likewise.
8121 * arch/aarch64.c (aarch64_create_target_description): Likewise.
8122 * arch/aarch64.h (aarch64_create_target_description): Likewise.
8123 * features/Makefile: Add new files.
8124 * features/aarch64-pauth.c: New file.
8125 * features/aarch64-pauth.xml: New file.
8126
595915c1
TT
81272019-03-20 Tom Tromey <tromey@adacore.com>
8128
8129 * infrun.c (handle_inferior_event): Rename from
8130 handle_inferior_event_1. Create a scoped_value_mark.
8131 (handle_inferior_event): Remove.
8132
4c7d57e7
TT
81332019-03-19 Tom Tromey <tromey@adacore.com>
8134
8135 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8136 * infrun.h (print_stop_event): Add "displays" parameter.
8137 * infrun.c (print_stop_event): Add "displays" parameter.
8138
cb246234
PA
81392019-03-19 Pedro Alves <palves@redhat.com>
8140
8141 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8142 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
8143 to -1. Fix TABs vs spaces.
8144 (tui_ui_out::tui_ui_out): Don't initialize fields here.
8145 * tui/tui-out.h (tui_ui_out) Add intro comments.
8146 <m_line, m_start_of_line>: In-class initialize, and add describing
8147 comment.
8148
3a0e45b2
AH
81492019-03-18 Alan Hayward <alan.hayward@arm.com>
8150
8151 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8152 variable names.
8153 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8154
5371b850
PA
81552019-03-18 Pedro Alves <palves@redhat.com>
8156 Eli Zaretskii <eliz@gnu.org>
8157
8158 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8159 m_line and m_start_of_line.
8160
b17c4cd0
EZ
81612019-03-18 Eli Zaretskii <eliz@gnu.org>
8162
8163 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8164 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8165 it returns a newline. This fixes a regression in TU mode, whereby
8166 the next line is output on the same screen line as the user input.
8167
4bd56d18
TT
81682019-03-18 Tom Tromey <tromey@adacore.com>
8169
8170 * minsyms.c (minimal_symbol_reader::install): Remove call to
8171 obstack_blank.
8172
55c10aca
PA
81732019-03-18 Pedro Alves <palves@redhat.com>
8174
8175 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8176 New globals.
8177 (apply_style): New, factored out from ...
8178 (apply_ansi_escape): ... this. Handle reverse video mode.
8179 (tui_set_reverse_mode): New function.
8180 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8181 * tui/tui-winsource.c (tui_show_source_line): Use
8182 tui_set_reverse_mode instead of setting A_STANDOUT.
8183 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8184 New setter methods.
8185
647bb750
HD
81862019-03-18 Hannes Domani <ssbssa@yahoo.de>
8187
8188 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8189 Handle tabs.
8190
bff8c71f
TT
81912019-03-18 Tom Tromey <tromey@adacore.com>
8192
8193 * ada-lang.c (empty_array): Add "high" parameter.
8194 (ada_evaluate_subexp): Update.
8195
58785d98
ST
81962019-03-17 Sergei Trofimovich <siarheit@google.com>
8197
8198 * unittests/string_view-selftests.c: Define
8199 _initialize_string_view_selftests unconditionally.
8200
d4cbef22
ВМ
82012019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8202
8203 PR gdb/24350
8204 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8205
fce4c071
ВМ
82062019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
8207
8208 PR gdb/24351
8209 * windows-nat.c (display_selector): Fix format specifiers.
8210
f7f0a123
EZ
82112019-03-17 Eli Zaretskii <eliz@gnu.org>
8212
8213 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8214 tui_refill_source_window instead of tui_refresh_win, to update the
8215 current execution line. This fixes redisplay of the current line
8216 when stepping through the code with "next" or "step".
8217
ab42892f
EZ
82182019-03-16 Eli Zaretskii <eliz@gnu.org>
8219
8220 * source-cache.c (source_cache::get_source_lines): Call
8221 find_source_lines to initialize s->nlines. This fixes vertical
8222 scrolling of TUI source window when the DOWN arrow is pressed.
8223
8d8c087f
PW
82242019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8225
8226 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8227 linux-thread-db.c (_initialize_thread_db): Likewise.
8228
798e1c30
EZ
82292019-03-16 Eli Zaretskii <eliz@gnu.org>
8230
8231 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8232 wclrtoeol in tui_show_source_line". This reverts changes made in
8233 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8234
eefba3da
TT
82352019-03-15 Tom Tromey <tom@tromey.com>
8236
8237 * symtab.h (struct minimal_symbol): Derive from
8238 general_symbol_info.
8239 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8240 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8241 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8242 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8243 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8244 (MSYMBOL_SEARCH_NAME): Update.
8245 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8246 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8247 * minsyms.c (minimal_symbol_reader::record_full): Update.
8248
0de2420c
TT
82492019-03-15 Tom Tromey <tom@tromey.com>
8250
8251 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8252
042d75e4
TT
82532019-03-15 Tom Tromey <tom@tromey.com>
8254
8255 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8256 unique_xmalloc_ptr.
8257 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8258 Update.
8259 * minsyms.c (lookup_minimal_symbol_by_pc_section)
8260 (build_minimal_symbol_hash_tables)
8261 (minimal_symbol_reader::install): Update.
8262
db92718b
TT
82632019-03-15 Tom Tromey <tom@tromey.com>
8264
8265 * symtab.c (create_demangled_names_hash): Update.
8266 (symbol_set_names): Update.
8267 * objfiles.h (struct objfile_per_bfd_storage)
8268 <demangled_names_hash>: Now an htab_up.
8269 * objfiles.c (objfile_per_bfd_storage): Simplify.
8270
d6797f46
TT
82712019-03-15 Tom Tromey <tom@tromey.com>
8272
8273 * objfiles.h (struct objfile_per_bfd_storage): Declare
8274 destructor.
8275 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8276 New.
8277 (get_objfile_bfd_data): Use new. Don't initialize
8278 language_of_main.
8279 (free_objfile_per_bfd_storage): Remove.
8280 (objfile_bfd_data_free, objfile::~objfile): Use delete.
8281
741d7538
TT
82822019-03-15 Tom Tromey <tom@tromey.com>
8283
8284 * symfile.c (reread_symbols): Update.
8285 * objfiles.c (objfile::objfile): Update.
8286 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8287 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8288 comment.
8289 (minimal_symbol_reader::install): Update.
8290 (terminate_minimal_symbol_table): Remove.
8291 * jit.c (jit_object_close_impl): Update.
8292
788c80d1
TT
82932019-03-15 Tom Tromey <tom@tromey.com>
8294
8295 * minsyms.c (minimal_symbol_reader::record_full): Remove some
8296 initializations.
8297
1b7a07cb
TT
82982019-03-15 Tom Tromey <tom@tromey.com>
8299
8300 * objfiles.h (struct objfile_per_bfd_storage)
8301 <demangled_hash_languages>: Now a bitset.
8302 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8303 (lookup_minimal_symbol): Update.
8304
3db066bc
TT
83052019-03-15 Tom Tromey <tom@tromey.com>
8306
8307 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8308 Don't return the symbol.
8309 * coffread.c (record_minimal_symbol): Use record_full.
8310
3fff2c37
EZ
83112019-03-14 Eli Zaretskii <eliz@gnu.org>
8312
8313 The MS-Windows port of ncurses fails to switch to a color pair if
8314 one or both of the colors are the implicit default colors. This
8315 change records the default colors when TUI is initialized, and
8316 then specifies them explicitly when a color pair uses the default
8317 colors. This allows color styling in TUI mode on MS-Windows.
8318
8319 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
8320 ncurses_norm_attr.
8321 (tui_initialize_io) [__MINGW32__]: Record the default terminal
8322 colors in ncurses_norm_attr.
8323 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8324 "none", replace it with the default color recorded in
8325 ncurses_norm_attr.
8326
3b336828
TT
83272019-03-14 Tom Tromey <tromey@adacore.com>
8328
8329 * source-cache.h (class source_cache) <get_source_lines>: Return
8330 std::string.
8331 * source-cache.c (source_cache::extract_lines): Handle case where
8332 first_pos==npos. Return std::string.
8333 (source_cache::get_source_lines): Update.
8334
d085f989
TT
83352019-03-14 Tom Tromey <tromey@adacore.com>
8336
8337 * NEWS: Add item for "style sources" commands.
8338 * source-cache.c (source_cache::get_source_lines): Check
8339 source_styling.
8340 * cli/cli-style.c (source_styling): New global.
8341 (_initialize_cli_style): Add "style sources" commands.
8342 (show_style_sources): New function.
8343 * cli/cli-style.h (source_styling): Declare.
8344
6f11e682
TT
83452019-03-14 Pedro Alves <palves@redhat.com>
8346 Tom Tromey <tromey@adacore.com>
8347
8348 * tui/tui-winsource.h (tui_refill_source_window): Declare.
8349 * tui/tui-winsource.c (tui_refill_source_window): New function,
8350 from...
8351 (tui_horizontal_source_scroll): ... here. Move some logic.
8352 * cli/cli-style.c (set_style_enabled): Notify new observable.
8353 * tui/tui-hooks.c (tui_redisplay_source): New function.
8354 (tui_attach_detach_observers): Attach or detach
8355 tui_redisplay_source.
8356 * observable.h (source_styling_changed): New observable.
8357 * observable.c: Define source_styling_changed observable.
8358
a068643d
TT
83592019-03-13 Tom Tromey <tromey@adacore.com>
8360
8361 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8362 (i386_gnu_nat_target::store_registers): Update.
8363 * target-debug.h (target_debug_print_std_string): New macro.
8364 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8365 * windows-tdep.c (display_one_tib): Update.
8366 * tui/tui-stack.c (tui_make_status_line): Update.
8367 * top.c (print_inferior_quit_action): Update.
8368 * thread.c (thr_try_catch_cmd): Update.
8369 (add_thread_with_info): Update.
8370 (thread_target_id_str): Update.
8371 (thr_try_catch_cmd): Update.
8372 (thread_command): Update.
8373 (thread_find_command): Update.
8374 * record-btrace.c (record_btrace_target::info_record)
8375 (record_btrace_resume_thread, record_btrace_target::resume)
8376 (record_btrace_cancel_resume, record_btrace_step_thread)
8377 (record_btrace_target::wait, record_btrace_target::wait)
8378 (record_btrace_target::wait, record_btrace_target::stop): Update.
8379 * progspace.c (print_program_space): Update.
8380 * process-stratum-target.c
8381 (process_stratum_target::thread_address_space): Update.
8382 * linux-fork.c (linux_fork_mourn_inferior)
8383 (detach_checkpoint_command, info_checkpoints_command)
8384 (linux_fork_context): Update.
8385 (linux_fork_detach): Update.
8386 (class scoped_switch_fork_info): Update.
8387 (delete_checkpoint_command): Update.
8388 * infrun.c (follow_fork_inferior): Update.
8389 (follow_fork_inferior): Update.
8390 (proceed_after_vfork_done): Update.
8391 (handle_vfork_child_exec_or_exit): Update.
8392 (follow_exec): Update.
8393 (displaced_step_prepare_throw): Update.
8394 (displaced_step_restore): Update.
8395 (start_step_over): Update.
8396 (resume_1): Update.
8397 (clear_proceed_status_thread): Update.
8398 (proceed): Update.
8399 (print_target_wait_results): Update.
8400 (do_target_wait): Update.
8401 (context_switch): Update.
8402 (stop_all_threads): Update.
8403 (restart_threads): Update.
8404 (finish_step_over): Update.
8405 (handle_signal_stop): Update.
8406 (switch_back_to_stepped_thread): Update.
8407 (keep_going_pass_signal): Update.
8408 (print_exited_reason): Update.
8409 (normal_stop): Update.
8410 * inferior.c (inferior_pid_to_str): Change return type.
8411 (print_selected_inferior): Update.
8412 (add_inferior): Update.
8413 (detach_inferior): Update.
8414 * dummy-frame.c (fprint_dummy_frames): Update.
8415 * dcache.c (dcache_info_1): Update.
8416 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8417 (btrace_fetch, btrace_clear): Update.
8418 * linux-tdep.c (linux_core_pid_to_str): Change return type.
8419 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8420 type.
8421 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8422 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8423 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8424 * gdbarch.c, gdbarch.h: Rebuild.
8425 * gdbarch.sh (core_pid_to_str): Change return type.
8426 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8427 return type.
8428 (windows_nat_target::pid_to_str): Change return type.
8429 (windows_delete_thread): Update.
8430 (windows_nat_target::attach): Update.
8431 (windows_nat_target::files_info): Update.
8432 * target-delegates.c: Rebuild.
8433 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8434 return type.
8435 (sol_thread_target::pid_to_str): Change return type.
8436 * remote.c (class remote_target) <pid_to_str>: Change return
8437 type.
8438 (remote_target::pid_to_str): Change return type.
8439 (extended_remote_target::attach, remote_target::remote_stop_ns)
8440 (remote_target::remote_notif_remove_queued_reply)
8441 (remote_target::push_stop_reply, remote_target::disable_btrace):
8442 Update.
8443 (extended_remote_target::attach): Update.
8444 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8445 type.
8446 (gdbsim_target::pid_to_str): Change return type.
8447 * ravenscar-thread.c (struct ravenscar_thread_target)
8448 <pid_to_str>: Change return type.
8449 (ravenscar_thread_target::pid_to_str): Change return type.
8450 * procfs.c (class procfs_target) <pid_to_str>: Change return
8451 type.
8452 (procfs_target::pid_to_str): Change return type.
8453 (procfs_target::attach): Update.
8454 (procfs_target::detach): Update.
8455 (procfs_target::fetch_registers): Update.
8456 (procfs_target::store_registers): Update.
8457 (procfs_target::wait): Update.
8458 (procfs_target::files_info): Update.
8459 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8460 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8461 return type.
8462 (nto_procfs_target::pid_to_str): Change return type.
8463 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8464 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8465 return type.
8466 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8467 (exit_lwp): Update.
8468 (attach_proc_task_lwp_callback, get_detach_signal)
8469 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8470 (linux_nat_target::resume, wait_lwp, stop_callback)
8471 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8472 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8473 (linux_nat_wait_1, resume_stopped_resumed_lwps)
8474 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8475 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8476 type.
8477 (inf_ptrace_target::attach): Update.
8478 (inf_ptrace_target::files_info): Update.
8479 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
8480 type.
8481 (go32_nat_target::pid_to_str): Change return type.
8482 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
8483 (gnu_nat_target::wait): Update.
8484 (gnu_nat_target::wait): Update.
8485 (gnu_nat_target::resume): Update.
8486 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
8487 (fbsd_nat_target::wait): Update.
8488 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
8489 type.
8490 (darwin_nat_target::attach): Update.
8491 * corelow.c (class core_target) <pid_to_str>: Change return type.
8492 (core_target::pid_to_str): Change return type.
8493 * target.c (normal_pid_to_str): Change return type.
8494 (default_pid_to_str): Likewise.
8495 (target_pid_to_str): Change return type.
8496 (target_translate_tls_address): Update.
8497 (target_announce_detach): Update.
8498 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
8499 return type.
8500 (bsd_uthread_target::pid_to_str): Change return type.
8501 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
8502 type.
8503 (bsd_kvm_target::pid_to_str): Change return type.
8504 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
8505 return type.
8506 (aix_thread_target::pid_to_str): Change return type.
8507 * target.h (struct target_ops) <pid_to_str>: Change return type.
8508 (target_pid_to_str, normal_pid_to_str): Likewise.
8509 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
8510 type.
8511 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
8512 type.
8513 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
8514 return type.
8515 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
8516 type.
8517 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
8518 type.
8519 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
8520 return type.
8521
b4be1b06
SM
85222019-03-13 Simon Marchi <simon.marchi@ericsson.com>
8523
8524 * NEWS: Mention that the new default MI version is 3. Mention
8525 changes to the output of commands and events that deal with
8526 multi-location breakpoints.
8527 * breakpoint.c: Include "mi/mi-out.h".
8528 (print_one_breakpoint): Change output syntax if using MI version
8529 >= 3.
8530 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
8531 New.
8532 (mi_multi_location_breakpoint_output_fixed): New.
8533 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
8534 (mi_cmd_fix_multi_location_breakpoint_output): New.
8535 (mi_multi_location_breakpoint_output_fixed): New.
8536 * mi/mi-cmds.c (mi_cmds): Register command
8537 -fix-multi-location-breakpoint-output.
8538 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
8539 interpreter "mi".
8540
8e5e5494
SM
85412019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
8542
8543 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
8544 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
8545 instantiate mi_ui_out based on interpreter name.
8546 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
8547 * mi/mi-main.c (mi_load_progress): Likewise.
8548
197df35e
JB
85492019-03-12 John Baldwin <jhb@FreeBSD.org>
8550
8551 * NEWS: Combine separate "New targets" sections for 8.3.
8552
8399425f
JB
85532019-03-12 John Baldwin <jhb@FreeBSD.org>
8554
8555 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
8556 (ppcfbsd_init_abi): Install gdbarch
8557 "fetch_tls_load_module_address" and "get_thread_local_address"
8558 methods.
8559
b0f87ed0
JB
85602019-03-12 John Baldwin <jhb@FreeBSD.org>
8561
8562 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
8563 (riscv_fbsd_init_abi): Install gdbarch
8564 "fetch_tls_load_module_address" and "get_thread_local_address"
8565 methods.
8566
ce25aa57
JB
85672019-03-12 John Baldwin <jhb@FreeBSD.org>
8568
8569 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
8570 (i386fbsd_init_abi): Install gdbarch
8571 "fetch_tls_load_module_address" and "get_thread_local_address"
8572 methods.
8573
f5424cfa
JB
85742019-03-12 John Baldwin <jhb@FreeBSD.org>
8575
8576 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
8577 (amd64fbsd_init_abi): Install gdbarch
8578 "fetch_tls_load_module_address" and "get_thread_local_address"
8579 methods.
8580
945f3901
JB
85812019-03-12 John Baldwin <jhb@FreeBSD.org>
8582
8583 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
8584 (struct fbsd_pspace_data): New type.
8585 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
8586 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
8587 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
8588 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
8589 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
8590
ef0bd204
JB
85912019-03-12 John Baldwin <jhb@FreeBSD.org>
8592
8593 * gdbtypes.c (lookup_struct_elt): New function.
8594 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
8595 * gdbtypes.h (struct struct_elt): New type.
8596 (lookup_struct_elt): New prototype.
8597
36c53a02
JB
85982019-03-12 John Baldwin <jhb@FreeBSD.org>
8599
8600 * gdbtypes.c (lookup_struct_elt_type): Update comment and
8601 remove disabled code block.
8602
6e056c81
JB
86032019-03-12 John Baldwin <jhb@FreeBSD.org>
8604
8605 * gdbarch.sh (get_thread_local_address): New method.
8606 * gdbarch.h, gdbarch.c: Regenerate.
8607 * target.c (target_translate_tls_address): Use
8608 gdbarch_get_thread_local_address if present instead of
8609 target::get_thread_local_address.
8610
cd250a18
JB
86112019-03-12 John Baldwin <jhb@FreeBSD.org>
8612
8613 * target.h (target::get_thread_local_address): Update comment.
8614
df22c1e5
JB
86152019-03-12 John Baldwin <jhb@FreeBSD.org>
8616
8617 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
8618 objfile->separate_debug_objfile_backlink if not NULL.
8619
dd6876c9
JB
86202019-03-12 John Baldwin <jhb@FreeBSD.org>
8621
8622 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
8623 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
8624 (amd64bsd_store_inferior_registers): Likewise.
8625 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8626 Enable segment base registers.
8627 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
8628 PT_GETFSBASE and PT_GETGSBASE.
8629 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
8630 PT_SETGSBASE.
8631 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
8632 segment base registers.
8633 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8634
1163a4b7
JB
86352019-03-12 John Baldwin <jhb@FreeBSD.org>
8636
8637 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
8638 Update calls to i386_target_description to add 'segments'
8639 parameter.
8640 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
8641 add segment base registers.
8642 * arch/i386.c (i386_create_target_description): Add 'segments'
8643 parameter to enable segment base registers.
8644 * arch/i386.h (i386_create_target_description): Likewise.
8645 * features/i386/32bit-segments.xml: New file.
8646 * features/i386/32bit-segments.c: Generate.
8647 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
8648 call to i386_target_description to add 'segments' parameter.
8649 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
8650 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
8651 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
8652 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
8653 if feature is present.
8654 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
8655 Add 'segments' parameter to call to i386_target_description.
8656 (i386_target_description): Add 'segments' parameter to enable
8657 segment base registers.
8658 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
8659 to call to i386_target_description.
8660 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
8661 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
8662 Define I386_NUM_REGS.
8663 (i386_target_description): Add 'segments' parameter to enable
8664 segment base registers.
8665
3a350822
EZ
86662019-03-12 Eli Zaretskii <eliz@gnu.org>
8667
8668 PR/24325
8669 * source-cache.c: #undef open and close, to avoid unresolved
8670 externals during linking.
8671
ffdd69cf
TT
86722019-03-12 Tom Tromey <tromey@adacore.com>
8673
8674 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
8675 const. Add initializers.
8676 (_initialize_remote): Don't initialize ptid globals.
8677
ec148c57
PA
86782019-03-12 Pedro Alves <palves@redhat.com>
8679
8680 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
8681
32764270
PA
86822019-03-12 Pedro Alves <palves@redhat.com>
8683
8684 * cp-name-parser.y (main): Remove unused 'len' variable.
8685
17547186
TT
86862019-03-12 Tom Tromey <tromey@adacore.com>
8687
8688 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
8689 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
8690
d3a70e03
TT
86912019-03-12 Tom Tromey <tromey@adacore.com>
8692
8693 * linux-nat.c (iterate_over_lwps): Update.
8694 (stop_callback): Remove parameter.
8695 (stop_wait_callback, detach_callback, resume_set_callback)
8696 (select_singlestep_lwp_callback, set_ignore_sigint)
8697 (status_callback, resumed_callback, resume_clear_callback)
8698 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
8699 data parameter.
8700 (linux_nat_target::detach, linux_nat_target::resume)
8701 (linux_stop_and_wait_all_lwps, select_event_lwp)
8702 (linux_nat_filter_event, linux_nat_wait_1)
8703 (linux_nat_target::kill, linux_nat_target::stop)
8704 (linux_nat_target::stop): Update.
8705 (linux_nat_resume_callback): Change type.
8706 (resume_stopped_resumed_lwps, count_events_callback)
8707 (select_event_lwp_callback): Likewise.
8708 (linux_stop_lwp, linux_nat_stop_lwp): Update.
8709 * arm-linux-nat.c (struct update_registers_data): Remove.
8710 (update_registers_callback): Change type.
8711 (arm_linux_insert_hw_breakpoint1): Update.
8712 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
8713 parameter.
8714 (x86_linux_dr_set_addr): Update.
8715 (x86_linux_dr_set_control): Update.
8716 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
8717 (iterate_over_lwps): Use gdb::function_view.
8718 * nat/aarch64-linux-hw-point.c (struct
8719 aarch64_dr_update_callback_param): Remove.
8720 (debug_reg_change_callback): Change type.
8721 (aarch64_notify_debug_reg_change): Update.
8722 * s390-linux-nat.c (s390_refresh_per_info): Update.
8723
82cb27ff
TT
87242019-03-11 Tom Tromey <tromey@adacore.com>
8725
8726 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
8727 redundant assignment to "this_cu".
8728
568c0683
SM
87292019-03-08 Simon Marchi <simon.marchi@efficios.com>
8730
8731 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
8732
f09ce22d
SM
87332019-03-08 Simon Marchi <simon.marchi@efficios.com>
8734
8735 * gdbtypes.c (rank_one_type_parm_set): New function extracted
8736 from...
8737 (rank_one_type): ... this.
8738
595f96a9
SM
87392019-03-08 Simon Marchi <simon.marchi@efficios.com>
8740
8741 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
8742 from...
8743 (rank_one_type): ... this.
8744
2598a94b
SM
87452019-03-08 Simon Marchi <simon.marchi@efficios.com>
8746
8747 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
8748 from...
8749 (rank_one_type): ... this.
8750
7f17b20d
SM
87512019-03-08 Simon Marchi <simon.marchi@efficios.com>
8752
8753 * gdbtypes.c (rank_one_type_parm_float): New function extracted
8754 from...
8755 (rank_one_type): ... this.
8756
2c509035
SM
87572019-03-08 Simon Marchi <simon.marchi@efficios.com>
8758
8759 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
8760 from...
8761 (rank_one_type): ... this.
8762
0dd322dc
SM
87632019-03-08 Simon Marchi <simon.marchi@efficios.com>
8764
8765 * gdbtypes.c (rank_one_type_parm_range): New function extracted
8766 from...
8767 (rank_one_type): ... this.
8768
41ea4728
SM
87692019-03-08 Simon Marchi <simon.marchi@efficios.com>
8770
8771 * gdbtypes.c (rank_one_type_parm_char): New function extracted
8772 from...
8773 (rank_one_type): ... this.
8774
793cd1d2
SM
87752019-03-08 Simon Marchi <simon.marchi@efficios.com>
8776
8777 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
8778 from...
8779 (rank_one_type): ... this.
8780
34910087
SM
87812019-03-08 Simon Marchi <simon.marchi@efficios.com>
8782
8783 * gdbtypes.c (rank_one_type_parm_int): New function extracted
8784 from...
8785 (rank_one_type): ... this.
8786
f1f832d6
SM
87872019-03-08 Simon Marchi <simon.marchi@efficios.com>
8788
8789 * gdbtypes.c (rank_one_type_parm_func): New function extracted
8790 from...
8791 (rank_one_type): ... this.
8792
b9f4512f
SM
87932019-03-08 Simon Marchi <simon.marchi@efficios.com>
8794
8795 * gdbtypes.c (rank_one_type_parm_array): New function extracted
8796 from...
8797 (rank_one_type): ... this.
8798
9293fc63
SM
87992019-03-08 Simon Marchi <simon.marchi@efficios.com>
8800
8801 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
8802 from...
8803 (rank_one_type): ... this.
8804
e3abbe7e
PW
88052019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8806
8807 * inferior.c (initialize_inferiors): Ensure 'help set/show print
8808 inferior-events' shows the example events.
8809
e4adb939
EZ
88102019-03-08 Eli Zaretskii <eliz@gnu.org>
8811
8812 Support styling on native MS-Windows console
8813
8814 PR/24315
8815 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
8816 on MS-Windows if $TERM is not defined.
8817
8818 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
8819
8820 * posix-hdep.c (gdb_console_fputs):
8821 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
8822 functions.
8823 * ui-file.h (gdb_console_fputs): Add prototype.
8824
8825 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
8826 back to fputs only if the former returns zero.
8827
25629dfd
TT
88282019-03-07 Tom Tromey <tom@tromey.com>
8829
8830 * symmisc.c (print_symbol_bcache_statistics): Update.
8831 (print_objfile_statistics): Update.
8832 * symfile.c (allocate_symtab): Update.
8833 * stabsread.c: Don't include bcache.h.
8834 * psymtab.h (struct psymbol_bcache): Don't declare.
8835 (class psymtab_storage) <psymbol_cache>: Now a bcache.
8836 (psymbol_bcache_init, psymbol_bcache_free)
8837 (psymbol_bcache_get_bcache): Don't declare.
8838 * psymtab.c (struct psymbol_bcache): Remove.
8839 (psymtab_storage::psymtab_storage): Update.
8840 (psymtab_storage::~psymtab_storage): Update.
8841 (psymbol_bcache_init, psymbol_bcache_free)
8842 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
8843 (add_psymbol_to_bcache): Update.
8844 (allocate_psymtab): Update.
8845 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
8846 macro_cache>: No longer pointers.
8847 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
8848 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
8849 * macrotab.c (macro_bcache): Update.
8850 * macroexp.c: Don't include bcache.h.
8851 * gdbtypes.c (check_types_worklist): Update.
8852 (types_deeply_equal): Remove TRY/CATCH. Update.
8853 * elfread.c (elf_symtab_read): Update.
8854 * dwarf2read.c: Don't include bcache.h.
8855 * buildsym.c (buildsym_compunit::get_macro_table): Update.
8856 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
8857 (print_bcache_statistics, bcache_memory_used): Don't declare.
8858 (struct bcache): Move from bcache.c. Add constructor, destructor,
8859 methods. Rename all data members.
8860 * bcache.c (struct bcache): Move to bcache.h.
8861 (bcache::expand_hash_table): Rename from expand_hash_table.
8862 (bcache): Remove.
8863 (bcache::insert): Rename from bcache_full.
8864 (bcache::compare): Rename from bcache_compare.
8865 (bcache_xmalloc): Remove.
8866 (bcache::~bcache): Rename from bcache_xfree.
8867 (bcache::print_statistics): Rename from print_bcache_statistics.
8868 (bcache::memory_used): Rename from bcache_memory_used.
8869
fe726667
PA
88702019-03-07 Pedro Alves <palves@redhat.com>
8871
8872 * infrun.c (normal_stop): Also check for
8873 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
8874
7584bb30
AB
88752019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
8876
8877 * f-lang.c (value_from_host_double): Moved to...
8878 * value.c (value_from_host_double): ...here.
8879 * value.h (value_from_host_double): Declare.
8880 * guile/scm-math.c (vlscm_convert_typed_number): Use
8881 value_from_host_double.
8882 (vlscm_convert_number): Likewise.
8883 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
8884 * python/py-value.c (convert_value_from_python): Likewise.
8885
a7b1986e
TT
88862019-03-06 Tom Tromey <tom@tromey.com>
8887
8888 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
8889
0ccf4211
TT
88902019-03-06 Tom Tromey <tom@tromey.com>
8891
8892 * utils.h (free_current_contents): Don't declare.
8893 * utils.c (free_current_contents): Remove.
8894
fe7b42e5
TT
88952019-03-06 Tom Tromey <tom@tromey.com>
8896
8897 * top.c (quit_force): Update.
8898 * main.c (captured_command_loop): Update.
8899 * common/new-op.c (operator new): Update.
8900 * common/common-exceptions.c (struct catcher)
8901 <save_cleanup_chain>: Remove member.
8902 (exceptions_state_mc_init): Update.
8903 (exception_try_scope_entry): Return nullptr.
8904 (exception_try_scope_exit, exception_rethrow)
8905 (throw_exception_sjlj, throw_exception_cxx): Update.
8906 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
8907 (all_cleanups, do_cleanups, discard_cleanups)
8908 (discard_final_cleanups, save_cleanups, save_final_cleanups)
8909 (restore_cleanups, restore_final_cleanups): Don't declare.
8910 (do_final_cleanups): Remove parameter.
8911 * common/cleanups.c (cleanup_chain, make_cleanup)
8912 (make_cleanup_dtor, all_cleanups, do_cleanups)
8913 (discard_my_cleanups, discard_cleanups)
8914 (discard_final_cleanups, save_my_cleanups, save_cleanups)
8915 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
8916 (null_cleanup): Remove.
8917 (do_final_cleanups): Remove parameter.
8918
c6321f19
TT
89192019-03-06 Tom Tromey <tom@tromey.com>
8920
8921 * remote.c (remote_target::remote_parse_stop_reply): Use
8922 unique_xmalloc_ptr.
8923
61b30099
TT
89242019-03-06 Tom Tromey <tom@tromey.com>
8925
8926 * stabsread.c (struct stabs_field_info): Rename from field_info.
8927 <list, fnlist>: Add initializers.
8928 <obstack>: New member.
8929 (read_member_functions, read_struct_fields, read_baseclasses):
8930 Allocate on obstack. Don't use cleanups.
8931 (read_one_struct_field, read_member_functions, read_struct_fields)
8932 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
8933 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
8934 (read_struct_type): Update.
8935
6cceac94
TT
89362019-03-06 Tom Tromey <tom@tromey.com>
8937
8938 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
8939 * common/filestuff.h (make_cleanup_close): Don't declare.
8940 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
8941 Remove.
8942
72412762
TT
89432019-03-06 Tom Tromey <tom@tromey.com>
8944
8945 * solib-aix.c: Use make_scope_exit.
8946
2b6ff1c0
TT
89472019-03-06 Tom Tromey <tom@tromey.com>
8948
8949 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
8950 Use make_scope_exit.
8951
d01c5877
TT
89522019-03-06 Tom Tromey <tom@tromey.com>
8953
8954 * solib-svr4.c (disable_probes_interface): Remove parameter.
8955 (svr4_handle_solib_event): Use make_scope_exit.
8956
32603266
TT
89572019-03-06 Tom Tromey <tom@tromey.com>
8958
8959 * remote.c (struct stop_reply_deleter): Remove.
8960 (stop_reply_up): Update.
8961 (struct stop_reply): Derive from notif_event. Don't typedef.
8962 <regcache>: Now a std::vector.
8963 (stop_reply_xfree): Remove.
8964 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
8965 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
8966 (remote_target::discard_pending_stop_replies): Use delete.
8967 (remote_target::remote_parse_stop_reply): Update.
8968 (remote_target::process_stop_reply): Update.
8969 * remote-notif.h (struct notif_event): Add virtual destructor.
8970 Remove "dtr" member.
8971 (struct notif_client) <alloc_event>: Return a unique_ptr.
8972 (notif_event_xfree): Don't declare.
8973 (notif_event_up): New typedef.
8974 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
8975 (notif_event_xfree, do_notif_event_xfree): Remove.
8976 (remote_notif_state_xfree): Update.
8977
9799571e
TT
89782019-03-06 Tom Tromey <tom@tromey.com>
8979
8980 * infrun.c (displaced_step_clear_cleanup): Now a
8981 forward_scope_exit type.
8982 (displaced_step_prepare_throw): Update.
8983 (displaced_step_fixup): Update.
8984
09e3c4ca
TT
89852019-03-06 Tom Tromey <tom@tromey.com>
8986
8987 * inferior.h (class inferior): Update comment.
8988 * gdbthread.h (class thread_info): Update comment.
8989
e2a03548
TT
89902019-03-06 Joel Brobecker <brobecker@adacore.com>
8991 Tom Tromey <tom@tromey.com>
8992
8993 * stabsread.h (struct stab_section_list): Remove.
8994 (coffstab_build_psymtabs): Update.
8995 * dbxread.c (symbuf_sections): Now a std::vector.
8996 (sect_idx): New global.
8997 (fill_symbuf): Update.
8998 (coffstab_build_psymtabs): Change type of stabsects parameter.
8999 Update.
9000 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9001 std::vector.
9002 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9003 (coff_locate_sections): Update.
9004 (coff_symfile_read): Remove cleanups. Update.
9005 (init_stringtab): Add storage parameter.
9006 (free_stringtab, free_stringtab_cleanup): Remove.
9007 (init_lineno): Add storage parameter.
9008 (free_linetab, free_linetab_cleanup): Remove.
9009
b7e60d85
PA
90102019-03-06 Pedro Alves <palves@redhat.com>
9011
9012 * linux-fork.c (fork_info::clobber_regs): Delete.
9013 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9014 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
9015 comment. Adjust.
9016 (scoped_switch_fork_info::scoped_switch_fork_info)
9017 (checkpoint_command, linux_fork_context): Adjust
9018 fork_save_infrun_state calls.
9019
e52c971f
PA
90202019-03-06 Pedro Alves <palves@redhat.com>
9021
9022 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9023 (inf_has_multiple_threads): Return 'bool' and rewrite using
9024 inferior_info::threads().
9025
06974e6c
PA
90262019-03-06 Pedro Alves <palves@redhat.com>
9027
9028 * linux-fork.c: Include <list>.
9029 (fork_list): Now a std::list instance.
9030 (fork_info): Add ctor, dtor, and in-class initialize all fields.
9031 (forks_exist_p, find_last_fork): Adjust.
9032 (new_fork): Delete.
9033 (one_fork_p): New.
9034 (add_fork): Adjust.
9035 (free_fork): Delete, folded into fork_info::~fork_info().
9036 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9037 Adjust.
9038 (init_fork_list): Delete.
9039 (linux_fork_killall, linux_fork_mourn_inferior)
9040 (linux_fork_detach, info_checkpoints_command): Adjust.
9041 (_initialize_linux_fork): No longer call init_fork_list.
9042
72f31aea
PA
90432019-03-06 Pedro Alves <palves@redhat.com>
9044
9045 * linux-fork.c (new_fork): New, split out of ...
9046 (add_fork): ... this. Return void. Move "first fork" special
9047 case from here, to ...
9048 (checkpoint_command): ... here.
9049 * linux-linux.h (add_fork): Return void.
9050
efbecbc1
AB
90512019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9052
9053 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9054
0841c79a
AB
90552019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9056 Chris January <chris.january@arm.com>
9057 David Lecomber <david.lecomber@arm.com>
9058
9059 * f-exp.y: New token, UNOP_INTRINSIC.
9060 (exp): New pattern using UNOP_INTRINSIC token.
9061 (f77_keywords): Add 'abs' keyword.
9062 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9063 (value_from_host_double): New function.
9064 (evaluate_subexp_f): Support UNOP_ABS.
9065
4a270568
AB
90662019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9067
9068 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9069 types.
9070
067630bd
AB
90712019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9072
9073 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9074 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9075 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9076
3be47f7a
AB
90772019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9078
9079 * f-exp.y (convert_to_kind_type): Handle more type kinds.
9080
4d00f5d8
AB
90812019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9082 Chris January <chris.january@arm.com>
9083
9084 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9085 * f-exp.y: Define 'KIND' token.
9086 (exp): New pattern for KIND expressions.
9087 (ptype): Handle types with a kind extension.
9088 (direct_abs_decl): Extend to spot kind extensions.
9089 (f77_keywords): Add 'kind' to the list.
9090 (push_kind_type): New function.
9091 (convert_to_kind_type): New function.
9092 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9093 * parse.c (operator_length_standard): Likewise.
9094 * parser-defs.h (enum type_pieces): Add tp_kind.
9095 * std-operator.def: Add UNOP_KIND.
9096
e454224f
AB
90972019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9098
9099 * f-exp.y (f_parse): Set yydebug.
9100
9dad4a58
AB
91012019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9102
9103 * f-lang.c (evaluate_subexp_f): New function.
9104 (exp_descriptor_f): New global.
9105 (f_language_defn): Use exp_descriptor_f instead of
9106 exp_descriptor_standard.
9107
c8f91604
AB
91082019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9109
9110 * f-exp.y (struct token): Add comments.
9111 (dot_ops): Remove uppercase versions and the end marker.
9112 (f77_keywords): Likewise.
9113 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9114 entries in the dot_ops array are case insensitive, and use
9115 strncasecmp to compare strings. Also some whitespace cleanup in
9116 this area. Similar for the f77_keywords array, except entries in
9117 this list might be case sensitive.
9118
dd9f2c76
AB
91192019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
9120
9121 * f-exp.y (struct f77_boolean_val): Add comments.
9122 (boolean_values): Remove uppercase versions, and end marker.
9123 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9124 and use strncasecmp to achieve case insensitivity. Additionally,
9125 perform whitespace cleanup around this code.
9126
67a3048c
TT
91272019-03-06 Tom Tromey <tromey@adacore.com>
9128
9129 * remote-sim.c (gdbsim_target_open): Use result of
9130 gdb_argv::release.
9131
aa3cfbda
RB
91322019-03-06 Richard Bunt <richard.bunt@arm.com>
9133 Dirk Schubert <dirk.schubert@arm.com>
9134 Chris January <chris.january@arm.com>
9135
9136 * eval.c (evaluate_subexp_standard): Call Fortran argument
9137 wrapping logic.
9138 * f-lang.c (struct value): A value which can be passed into a
9139 Fortran function call.
9140 (fortran_argument_convert): Wrap Fortran arguments in a pointer
9141 where appropriate.
9142 (struct type): Value ready for a Fortran function call.
9143 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9144 is needed.
9145 * f-lang.h (fortran_argument_convert): Declaration.
9146 (fortran_preserve_arg_pointer): Declaration.
9147 * infcall.c (value_arg_coerce): Call Fortran argument logic.
9148
ea38e5df
TT
91492019-03-05 Tom Tromey <tromey@adacore.com>
9150
9151 * python/py-prettyprint.c (print_string_repr): Remove #if.
9152 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9153
06b5b831
TT
91542019-03-05 Tom Tromey <tromey@adacore.com>
9155
9156 * target.c (the_dummy_target): Move later. Change type to
9157 "dummy_target".
9158 (initialize_targets): Don't initialize the_dummy_target.
9159
edbd9e45
TT
91602019-03-05 Tom Tromey <tromey@adacore.com>
9161
9162 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9163 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9164
c119e040
TT
91652019-03-05 Tom Tromey <tromey@adacore.com>
9166
9167 * windows-nat.c (windows_nat_target::attach)
9168 (windows_nat_target::detach): Don't call gdb_flush.
9169 * valprint.c (generic_val_print, val_print, val_print_string):
9170 Don't call gdb_flush.
9171 * utils.c (defaulted_query): Don't call gdb_flush.
9172 * typeprint.c (print_type_scalar): Don't call gdb_flush.
9173 * target.c (target_announce_detach): Don't call gdb_flush.
9174 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9175 * remote.c (extended_remote_target::attach): Don't call
9176 gdb_flush.
9177 * procfs.c (procfs_target::detach): Don't call gdb_flush.
9178 * printcmd.c (do_examine): Don't call gdb_flush.
9179 (info_display_command): Don't call gdb_flush.
9180 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9181 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9182 * memattr.c (info_mem_command): Don't call gdb_flush.
9183 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9184 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9185 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9186 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9187 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9188 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9189 (gnu_nat_target::detach): Don't call gdb_flush.
9190 * f-valprint.c (f_val_print): Don't call gdb_flush.
9191 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9192 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9193 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9194 gdb_flush.
9195 * c-valprint.c (c_val_print): Don't call gdb_flush.
9196 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9197
895dafa6
TT
91982019-03-05 Tom Tromey <tromey@adacore.com>
9199
9200 * varobj.c (update_dynamic_varobj_children): Update.
9201 (install_default_visualizer): Use reset, not release.
9202 * value.c (set_internalvar): Update.
9203 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9204 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9205 ATTRIBUTE_UNUSED_RESULT.
9206
88a774b9
TT
92072019-03-05 Tom Tromey <tromey@adacore.com>
9208
9209 * remote.c (class scoped_remote_fd) <release>: Add
9210 ATTRIBUTE_UNUSED_RESULT.
9211
4e4a8b93
TT
92122019-03-05 Tom Tromey <tromey@adacore.com>
9213
9214 * macroexp.c (struct macro_buffer) <release>: Add
9215 ATTRIBUTE_UNUSED_RESULT.
9216
083eef1f
TT
92172019-03-05 Tom Tromey <tromey@adacore.com>
9218
9219 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9220 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9221 ATTRIBUTE_UNUSED_RESULT.
9222
3cabd438
TT
92232019-03-05 Tom Tromey <tromey@adacore.com>
9224
9225 * common/scoped_fd.h (class scoped_fd) <release>: Add
9226 ATTRIBUTE_UNUSED_RESULT.
9227
41e3300a
TT
92282019-03-05 Tom Tromey <tromey@adacore.com>
9229
9230 * parser-defs.h (struct parser_state) <release>: Add
9231 ATTRIBUTE_UNUSED_RESULT.
9232
18cb7c9f
TT
92332019-03-05 Tom Tromey <tromey@adacore.com>
9234
9235 * utils.h (class gdb_argv) <release>: Add
9236 ATTRIBUTE_UNUSED_RESULT.
9237 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9238
41fa577f
EZ
92392019-03-02 Eli Zaretskii <eliz@gnu.org>
9240
a6a4b2c6
EZ
9241 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9242 for-loop range, to avoid compiler warnings.
9243
9244 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9245 avoid compiler warnings about unused variables.
9246
742a7df5
EZ
9247 * NEWS: Mention end of support for native debugging on MS-Windows
9248 before XP.
9249
41fa577f
EZ
9250 PR gdb/24292
9251 * common/netstuff.c:
9252 * gdbserver/gdbreplay.c
9253 * gdbserver/remote-utils.c:
9254 * ser-tcp.c:
9255 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9256 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
9257 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9258 'getaddrinfo' and 'freeaddrinfo' were not available before
9259 Windows XP, and mingw.org's MinGW headers by default define
9260 _WIN32_WINNT to 0x500.
9261
827f438f
GB
92622019-03-01 Gary Benson <gbenson@redhat.com>
9263
9264 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9265
92137da0
RO
92662019-02-28 Brian Vandenberg <phantall@gmail.com>
9267 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
9268
9269 PR gdb/8527
9270 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9271 set_sigint_trap, clear_sigint_trap.
9272
799efbe8
PW
92732019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9274
9275 * target.c (target_detach): Clear the regcache and the
9276 frame cache.
9277
8ed25214
PA
92782019-02-27 Pedro Alves <palves@redhat.com>
9279
9280 * utils.c (set_screen_size): When we cap the height/width sizes,
9281 tweak the corresponding command variable to show "unlimited":
9282
23031e31
SJ
92832019-02-27 Saagar Jha <saagar@saagarjha.com>
9284 Pedro Alves <palves@redhat.com>
9285
9286 * utils.c (set_screen_size): Reduce "infinite" rows and columns
9287 before calling rl_set_screen_size.
9288
6c28e44a
TT
92892019-02-27 Tom Tromey <tromey@adacore.com>
9290
9291 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9292 define.
9293 * python/py-value.c: Remove Python 2.4 workaround.
9294 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9295 workaround.
9296 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9297 Python 2.4 workaround.
9298 * python/python-internal.h: Remove Python 2.4 comment.
9299 (Py_ssize_t): Don't define.
9300 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9301 (gdb_Py_DECREF): Remove Python 2.4 workaround.
9302 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9303 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9304 * python/python.c (do_start_initialization): Remove Python 2.4
9305 workaround.
9306 * python/py-prettyprint.c (class dummy_python_frame): Remove.
9307 (print_children): Remove Python 2.4 workaround.
9308 * python/py-inferior.c (buffer_procs): Remove Python 2.4
9309 workaround.
9310 (CHARBUFFERPROC_NAME): Remove.
9311 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9312 Python 2.4 workaround.
9313
2c3fc25d 93142019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 9315
2c3fc25d
KB
9316 * NEWS: Note minimum Python version.
9317
6ca62222
KB
93182019-02-27 Kevin Buettner <kevinb@redhat.com>
9319
9320 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9321 code from these functions. Remove corresponding ifdefs. Use
9322 Py_buffer_up instead of explicit calls to PyBuffer_Release.
9323 Remove gotos and target of gotos.
9324 (infpy_search_memory): Likewise.
9325
f4bc7d2c
AB
93262019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9327
9328 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9329 (hppa_gdbarch_init): Don't register deleted functions with
9330 gdbarch.
9331
9734a586
AB
93322019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9333
9334 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9335 (h8300_unwind_sp): Delete.
9336 (h8300_dummy_id): Delete.
9337 (h8300_gdbarch_init): Don't register deleted functions with
9338 gdbarch.
9339
68b867f3
AB
93402019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9341
9342 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9343 (ft32_unwind_pc): Delete.
9344 (ft32_unwind_sp): Delete.
9345 (ft32_gdbarch_init): Don't register deleted functions with
9346 gdbarch.
9347
2fbe7ad0
AB
93482019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9349
9350 * gdb/frv-tdep.c (frv_dummy_id): Delete.
9351 (frv_unwind_pc): Delete.
9352 (frv_unwind_sp): Delete.
9353 (frv_gdbarch_init): Don't register deleted functions with
9354 gdbarch.
9355
76055cbe
AB
93562019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9357
9358 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9359 (riscv_unwind_pc): Delete.
9360 (riscv_unwind_sp): Delete.
9361 (riscv_gdbarch_init): Don't register deleted functions with
9362 gdbarch.
9363
4133e5a1
AB
93642019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9365
9366 * gdb/csky-tdep.c (csky_dummy_id): Delete.
9367 (csky_unwind_pc): Delete.
9368 (csky_unwind_sp): Delete.
9369 (csky_gdbarch_init): Don't register deleted functions with
9370 gdbarch.
9371
8010f576
AB
93722019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9373
9374 * gdb/cris-tdep.c (cris_dummy_id): Delete.
9375 (cris_unwind_pc): Delete.
9376 (cris_unwind_sp): Delete.
9377 (cris_gdbarch_init): Don't register deleted functions with
9378 gdbarch.
9379
b56bf084
AB
93802019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9381
9382 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9383 (bfin_unwind_pc): Delete.
9384 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9385
a19a650f
AB
93862019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9387
9388 * gdb/arm-tdep.c (arm_dummy_id): Delete.
9389 (arm_unwind_pc): Delete.
9390 (arm_unwind_sp): Delete.
9391 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9392
f8278c3c
AB
93932019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9394
9395 * gdb/arc-tdep.c (arc_dummy_id): Delete.
9396 (arc_unwind_pc): Delete.
9397 (arc_unwind_sp): Delete.
9398 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9399
480e46cf
AB
94002019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9401
9402 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9403 (alpha_unwind_pc): Delete.
9404 (alpha_gdbarch_init): Don't register deleted functions with
9405 gdbarch.
9406
7a995095
AB
94072019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9408
9409 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9410 (aarch64_unwind_pc): Delete.
9411 (aarch64_unwind_sp): Delete.
9412 (aarch64_gdbarch_init): Don't register deleted functions with
9413 gdbarch.
9414
bf9a735e
AB
94152019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9416
9417 * gdbtypes.c (type_align): Don't consider static members when
9418 computing structure alignment.
9419
5561fc30
AB
94202019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
9421
9422 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9423 return 0 for other types.
9424 * arch-utils.c (default_type_align): Always return 0.
9425 * gdbarch.h: Regenerate.
9426 * gdbarch.sh (type_align): Extend comment.
9427 * gdbtypes.c (type_align): Add additional comments, always call
9428 gdbarch_type_align before applying the default rules.
9429 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9430 generic code will then apply a suitable default.
9431 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9432 types, return 0 for other types.
9433
9335e75a
JB
94342019-02-27 Joel Brobecker <brobecker@adacore.com>
9435
9436 * NEWS: Create a new section for the next release branch.
9437 Rename the section of the current branch, now that it has
9438 been cut.
9439
3d34d8de
JB
94402019-02-27 Joel Brobecker <brobecker@adacore.com>
9441
9442 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9443 * version.in: Bump version to 8.3.50.DATE-git.
9444
143420fb
SM
94452019-02-26 Simon Marchi <simon.marchi@efficios.com>
9446
9447 * aix-thread.c (ptid_cmp): Remove unused variable.
9448 (get_signaled_thread): Likewise.
9449 (store_regs_user_thread): Likewise.
9450 (store_regs_kernel_thread): Likewise.
9451 (fetch_regs_kernel_thread): Remove shadowed variable.
9452
172fb711
AB
94532019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
9454
9455 * features/riscv/32bit-cpu.xml: Add register numbers.
9456 * features/riscv/32bit-fpu.c: Regenerate.
9457 * features/riscv/32bit-fpu.xml: Add register numbers.
9458 * features/riscv/64bit-cpu.xml: Add register numbers.
9459 * features/riscv/64bit-fpu.c: Regenerate.
9460 * features/riscv/64bit-fpu.xml: Add register numbers.
9461
26c89782
KB
94622019-02-26 Kevin Buettner <kevinb@redhat.com>
9463
af54ade9 9464 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB
9465 * python/py-value.c (convert_buffer_and_type_to_value): New
9466 function.
9467 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9468 Add support for handling an optional second argument. Call
9469 convert_buffer_and_type_to_value as appropriate.
26c89782
KB
9470 * python/python-internal.h (Py_buffer_deleter): New struct.
9471 (Py_buffer_up): New typedef.
9472
0f58c9e8
JB
94732019-02-25 John Baldwin <jhb@FreeBSD.org>
9474
9475 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9476 instead of releasing ownership.
9477
0a0f4c01
JR
94782019-02-25 Jordan Rupprecht <rupprecht@google.com>
9479
9480 * dwarf2read.c (open_and_init_dwp_file): Call
9481 elf_numsections instead of bfd_count_sections to initialize
9482 dwp_file->num_sections.
9483
cd5a152c
TT
94842019-02-25 Tom Tromey <tromey@adacore.com>
9485
9486 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
9487
8a6a8513
SDJ
94882019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
9489
9490 * gcore.in: Add '--readnever' option when invoking GDB.
9491
04dcda9c
SM
94922019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9493
9494 * MAINTAINERS: Update my email address.
9495
07bc701d
SM
94962019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
9497
9498 * build-id.c (build_id_to_debug_bfd_1): New function.
9499 (build_id_to_debug_bfd): Look for separate debug file in
9500 sysroot.
9501
c6f4a5d0
AB
95022019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
9503
9504 * gdbarch.sh: Update the copyright year range that is placed into
9505 generated files.
9506
9600246d
KS
95072019-02-22 Keith Seitz <keiths@redhat.com>
9508
9509 PR symtab/23853
9510 * linespec.c (create_sals_line_offset): Search for the default
9511 symtab's filename instead of its fullname.
9512
7557a514
AH
95132019-02-21 Alan Hayward <alan.hayward@arm.com>
9514
9515 * NEWS: Update style defaults.
9516
ee2bcb0c
AH
95172019-02-21 Alan Hayward <alan.hayward@arm.com>
9518
9519 * main.c (captured_main_1): Disable styling in batch mode.
9520
0c95f9ed
TT
95212019-02-20 Tom Tromey <tom@tromey.com>
9522
9523 * symtab.c (symtab_symbol_info): Fix typos.
9524
c763b894
TT
95252019-02-20 Tom Tromey <tromey@adacore.com>
9526
9527 * findcmd.c (_initialize_mem_search): Use upper case for
9528 metasyntactic variables.
9529
0ef8a082
AH
95302019-02-20 Alan Hayward <alan.hayward@arm.com>
9531
9532 * aarch64-tdep.c (aarch64_add_reggroups): New function.
9533 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
9534
6caa91b6
SM
95352019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
9536
9537 * top.h (source_file_name): Change to std::string.
9538 * top.c (source_file_name): Likewise.
9539 (command_line_input): Adjust.
9540 * cli/cli-script.c (script_from_file): Adjust.
9541
98814c6c
TT
95422019-02-19 Tom Tromey <tromey@adacore.com>
9543
9544 * ravenscar-thread.c
9545 (ravenscar_thread_target::update_thread_list): Don't call
9546 ada_build_task_list.
9547 * ada-lang.h (ada_build_task_list): Don't declare.
9548 * ada-tasks.c (struct ada_tasks_inferior_data)
9549 <task_list_valid_p>: Now bool.
9550 (read_known_tasks, ada_task_list_changed)
9551 (ada_tasks_invalidate_inferior_data): Update.
9552 (read_known_tasks_array): Return bool.
9553 (read_known_tasks_list): Likewise.
9554 (read_known_tasks): Return void.
9555 (ada_build_task_list): Now static.
9556
70cd633e
AB
95572019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
9558
9559 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
9560 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
9561
040b3e95
PW
95622019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9563
9564 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
9565 variant for ada_tasks_pspace_data_handle and
9566 ada_tasks_inferior_data_handle.
9567 (ada_tasks_pspace_data_cleanup): New function.
9568 (ada_tasks_inferior_data_cleanup): New function.
9569
9409233b
TT
95702019-02-17 Tom Tromey <tom@tromey.com>
9571
9572 * macrotab.h (macro_source_fullname): Return a std::string.
9573 * macrotab.c (macro_include, check_for_redefinition)
9574 (macro_undef, macro_lookup_definition, foreach_macro)
9575 (foreach_macro_in_scope): Update.
9576 (macro_source_fullname): Return a std::string.
9577 * macrocmd.c (show_pp_source_pos): Update.
9578
6506371f
TT
95792019-02-17 Tom Tromey <tom@tromey.com>
9580
9581 * macrocmd.c (show_pp_source_pos): Style the file names.
9582
0c820d67
TT
95832019-02-17 Tom Tromey <tom@tromey.com>
9584
9585 PR tui/24197:
9586 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
9587
a0087920
TT
95882019-02-17 Tom Tromey <tom@tromey.com>
9589
9590 * ada-lang.c (user_select_syms): Use filtered printing.
9591 * utils.c (wrap_style): New global.
9592 (desired_style): Remove.
9593 (emit_style_escape): Add stream parameter.
9594 (set_output_style, reset_terminal_style, prompt_for_continue):
9595 Update.
9596 (flush_wrap_buffer): Only flush gdb_stdout.
9597 (wrap_here): Set wrap_style.
9598 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
9599 treat escape sequences as a character. Change when wrap buffer is
9600 flushed.
9601 (fputs_styled): Do not set the output style when the default is
9602 requested.
9603 * ui-style.h (struct ui_file_style) <is_default>: New method.
9604 * source.c (print_source_lines_base): Emit escape sequences in one
9605 piece.
9606
75ba10dc
JB
96072019-02-17 Joel Brobecker <brobecker@adacore.com>
9608
9609 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
9610 integers and enumeration types.
9611
a2cd4f14
JB
96122019-02-17 Joel Brobecker <brobecker@adacore.com>
9613
9614 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
9615 instead of lookup_symbol_in_language
9616 (do_exact_match): New function.
9617 (ada_get_symbol_name_matcher): Return do_exact_match when
9618 doing a verbatim match.
9619
485b851b
TT
96202019-02-15 Tom Tromey <tromey@adacore.com>
9621
9622 * ravenscar-thread.c (ravenscar_thread_target::resume)
9623 (ravenscar_thread_target::wait): Special case wildcard requests.
9624
0b790b1e
TT
96252019-02-15 Tom Tromey <tromey@adacore.com>
9626
9627 * ravenscar-thread.c (base_ptid): Remove.
9628 (struct ravenscar_thread_target) <close>: New method.
9629 <m_base_ptid>: New member.
9630 <update_inferior_ptid, active_task, task_is_currently_active,
9631 runtime_initialized>: Declare methods.
9632 <ravenscar_thread_target>: Add constructor.
9633 (ravenscar_thread_target::task_is_currently_active)
9634 (ravenscar_thread_target::update_inferior_ptid)
9635 (ravenscar_runtime_initialized): Rename. Now methods.
9636 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
9637 (ravenscar_thread_target::update_thread_list): Update.
9638 (ravenscar_thread_target::active_task): Now method.
9639 (ravenscar_thread_target::store_registers)
9640 (ravenscar_thread_target::prepare_to_store)
9641 (ravenscar_thread_target::prepare_to_store)
9642 (ravenscar_thread_target::mourn_inferior): Update.
9643 (ravenscar_inferior_created): Use "new" to create target.
9644 (ravenscar_thread_target::get_ada_task_ptid): Update.
9645 (_initialize_ravenscar): Don't initialize base_ptid.
9646 (ravenscar_ops): Remove global.
9647
dea57a62
TT
96482019-02-15 Tom Tromey <tromey@adacore.com>
9649
9650 * target.h (push_target): Declare new overload.
9651 * target.c (push_target): New overload, taking an rvalue reference.
9652 * remote.c (remote_target::open_1): Use push_target overload.
9653 * corelow.c (core_target_open): Use push_target overload.
9654
989f3c58
TT
96552019-02-15 Tom Tromey <tromey@adacore.com>
9656
9657 * ravenscar-thread.c (is_ravenscar_task)
9658 (ravenscar_task_is_currently_active): Return bool.
9659 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
9660 (_initialize_ravenscar): Remove "(void)".
9661 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
9662 Return bool.
9663
6cbcc006
TT
96642019-02-15 Tom Tromey <tromey@adacore.com>
9665
9666 * ravenscar-thread.c (ravenscar_runtime_initializer)
9667 (has_ravenscar_runtime, get_running_thread_id)
9668 (ravenscar_thread_target::resume): Fix indentation.
9669
7657f14d
TT
96702019-02-15 Tom Tromey <tromey@adacore.com>
9671
9672 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
9673 from ravenscar_arch_ops.
9674 (sparc_ravenscar_ops::fetch_registers)
9675 (sparc_ravenscar_ops::store_registers): Now methods.
9676 (sparc_ravenscar_prepare_to_store): Remove.
9677 (sparc_ravenscar_ops): Redefine.
9678 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
9679 methods and destructor. Remove members.
9680 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
9681 (ravenscar_thread_target::store_registers)
9682 (ravenscar_thread_target::prepare_to_store): Update.
9683 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
9684 Remove.
9685 (struct ppc_ravenscar_powerpc_ops): Derive from
9686 ravenscar_arch_ops.
9687 (ppc_ravenscar_powerpc_ops::fetch_registers)
9688 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
9689 (ppc_ravenscar_powerpc_ops): Redefine.
9690 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
9691 (ppc_ravenscar_e500_ops::fetch_registers)
9692 (ppc_ravenscar_e500_ops::store_registers): Now methods.
9693 (ppc_ravenscar_e500_ops): Redefine.
9694 * aarch64-ravenscar-thread.c
9695 (aarch64_ravenscar_generic_prepare_to_store): Remove.
9696 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
9697 (aarch64_ravenscar_fetch_registers)
9698 (aarch64_ravenscar_store_registers): Now methods.
9699 (aarch64_ravenscar_ops): Redefine.
9700
5b6ea500
TT
97012019-02-15 Tom Tromey <tromey@adacore.com>
9702
9703 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
9704 (ravenscar_thread_target::stopped_by_hw_breakpoint)
9705 (ravenscar_thread_target::stopped_by_watchpoint)
9706 (ravenscar_thread_target::stopped_data_address)
9707 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
9708
e397fd39
TT
97092019-02-15 Tom Tromey <tromey@adacore.com>
9710
9711 * ravenscar-thread.c: Fix some typos.
9712
cc12f4a8
TT
97132019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9714 Tom Tromey <tromey@adacore.com>
9715
9716 * ada-lang.c (ada_exception_sal): Change addr_string to a
9717 std::string.
9718 (create_ada_exception_catchpoint): Update.
9719
5f486660
TT
97202019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9721 Tom Tromey <tromey@adacore.com>
9722
9723 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
9724 (bp_location_ops): Remove.
9725 (base_breakpoint_allocate_location): Update.
9726 (free_bp_location): Update.
9727 * ada-lang.c (class ada_catchpoint_location)
9728 <ada_catchpoint_location>: Remove ops parameter.
9729 (ada_catchpoint_location_dtor): Remove.
9730 (ada_catchpoint_location_ops): Remove.
9731 (allocate_location_exception): Update.
9732 * breakpoint.h (struct bp_location_ops): Remove.
9733 (class bp_location) <bp_location>: Remove bp_location_ops
9734 parameter.
9735 <~bp_location>: Add destructor.
9736 <ops>: Remove.
9737
b671c7fb
TS
97382019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9739 Pedro Alves <palves@redhat.com>
9740
9741 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
9742 'PATH_MAX'.
9743
8071c5ce
DM
97442019-02-14 David Michael <fedora.dm0@gmail.com>
9745 Samuel Thibault <samuel.thibault@gnu.org>
9746 Thomas Schwinge <thomas@codesourcery.com>
9747
9748 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
9749 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
9750
b1041ae0
TS
97512019-02-14 Thomas Schwinge <thomas@codesourcery.com>
9752
924514e1
TS
9753 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
9754 (check_empty): Use "const char *".
9755
c29ee8d4
TS
9756 * gnu-nat.c (gnu_nat_target::detach): Instead of
9757 'detach_inferior (pid)' call
9758 'detach_inferior (find_inferior_pid (pid))'.
9759
6c6ef69f
TS
9760 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
9761 'nat/fork-inferior.o'.
9762 * gnu-nat.c: #include "nat/fork-inferior.h".
9763
2d0a338c
TS
9764 * gnu-nat.c (gnu_nat_target::detach): Instead of
9765 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
9766 * gnu-nat.h: #include "inf-child.h".
9767 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
9768 'i386_gnu_nat_target::fetch_registers'.
9769 (gnu_store_registers): Rename/move to
9770 'i386_gnu_nat_target::store_registers'.
9771
cabb5f06
TS
9772 * config/i386/nm-i386gnu.h: Don't "#include" any files.
9773 * gnu-nat.h (mach_thread_info): New function.
9774 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
9775
b1041ae0
TS
9776 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
9777
2988d01e
KF
97782019-02-14 Frederic Konrad <konrad@adacore.com>
9779
9780 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
9781
c559d709
JB
97822019-02-14 Joel Brobecker <brobecker@adacore.com>
9783
9784 * windows-nat.c (windows_add_thread): Add new parameter
9785 "main_thread_p" with default value set to false. Update
9786 function documentation as well as all callers.
9787 (windows_delete_thread): Likewise.
9788 (fake_create_process): Update call to windows_add_thread.
9789 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
9790 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
9791 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
9792 call to windows_delete_thread.
9793
007024cc
SM
97942019-02-13 Simon Marchi <simon.marchi@ericsson.com>
9795
9796 * MAINTAINERS: Add Andrew Burgess as global maintainer.
9797
f62318e9
JB
97982019-02-12 John Baldwin <jhb@FreeBSD.org>
9799
9800 * symfile.c (find_separate_debug_file): Use canonical path of
9801 sysroot with child_path instead of gdb_sysroot if it is valid.
9802
cd4b7848
JB
98032019-02-12 John Baldwin <jhb@FreeBSD.org>
9804
9805 * symfile.c (find_separate_debug_file): Use child_path to
9806 determine if an object file is under a sysroot.
9807
efac4bfe
JB
98082019-02-12 John Baldwin <jhb@FreeBSD.org>
9809
9810 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
9811 unittests/child-path-selftests.c.
9812 * common/pathstuff.c (child_path): New function.
9813 * common/pathstuff.h (child_path): New prototype.
9814 * unittests/child-path-selftests.c: New file.
9815
402d2bfe
JB
98162019-02-12 John Baldwin <jhb@FreeBSD.org>
9817
9818 * symfile.c (find_separate_debug_file): Look for separate debug
9819 files in debug directories under the sysroot.
9820
1ed9f74e
PW
98212019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9822
9823 * symtab.h (struct minimal_symbol data_p): New const method.
9824 (struct minimal_symbol text_p): Likewise.
9825 * symtab.c (output_source_filename): Use file name style
9826 to print file name.
9827 (print_symbol_info): Likewise.
9828 (print_msymbol_info): Use address style to print addresses.
9829 Use function name style to print executable text symbols.
9830 (expand_symtab_containing_pc): Use data_p.
9831 (find_pc_sect_compunit_symtab): Likewise.
9832
2636d81d
PW
98332019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9834
9835 * breakpoint.c (describe_other_breakpoints): Use address style
9836 to print addresses.
9837 (say_where): Likewise.
9838
ac8c53cc
PW
98392019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9840
9841 * ada-typeprint.c (print_func_type): Print function name
9842 style to print function name.
9843 * c-typeprint.c (c_print_type_1): Likewise.
9844
ea638c43
AH
98452019-02-11 Alan Hayward <alan.hayward@arm.com>
9846
9847 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
9848 for execve.
9849
ab759ca8
PW
98502019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9851
9852 * c-exp.y (direct_abs_decl): Use emplace_back to record the
9853 type_stack.
9854
aff29d1c
JB
98552019-02-10 Joel Brobecker <brobecker@adacore.com>
9856
9857 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
9858 TYPE_CODE_REF types.
9859
617126bc
JW
98602019-02-08 Jim Wilson <jimw@sifive.com>
9861
9862 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
9863 (riscv_linux_fregset): New.
9864 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
9865
46e3ed7f
TT
98662019-02-07 Tom Tromey <tom@tromey.com>
9867
9868 * thread.c (thread_cancel_execution_command): Update.
9869 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
9870 methods.
9871 (struct thread_fsm_ops): Remove.
9872 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
9873 (thread_fsm_should_stop, thread_fsm_return_value)
9874 (thread_fsm_set_finished, thread_fsm_finished_p)
9875 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
9876 Don't declare.
9877 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
9878 * infrun.c (clear_proceed_status_thread)
9879 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
9880 (print_stop_event): Update.
9881 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
9882 Add constructor.
9883 (step_command_fsm_ops): Remove.
9884 (new_step_command_fsm): Remove.
9885 (step_1): Update.
9886 (step_command_fsm::should_stop): Rename from
9887 step_command_fsm_should_stop.
9888 (step_command_fsm::clean_up): Rename from
9889 step_command_fsm_clean_up.
9890 (step_command_fsm::do_async_reply_reason): Rename from
9891 step_command_fsm_async_reply_reason.
9892 (struct until_next_fsm): Inherit from thread_fsm. Add
9893 constructor.
9894 (until_next_fsm_ops): Remove.
9895 (new_until_next_fsm): Remove.
9896 (until_next_fsm::should_stop): Rename from
9897 until_next_fsm_should_stop.
9898 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
9899 (until_next_fsm::do_async_reply_reason): Rename from
9900 until_next_fsm_async_reply_reason.
9901 (struct finish_command_fsm): Inherit from thread_fsm. Add
9902 constructor. Change type of breakpoint.
9903 (finish_command_fsm_ops): Remove.
9904 (new_finish_command_fsm): Remove.
9905 (finish_command_fsm::should_stop): Rename from
9906 finish_command_fsm_should_stop.
9907 (finish_command_fsm::clean_up): Rename from
9908 finish_command_fsm_clean_up.
9909 (finish_command_fsm::return_value): Rename from
9910 finish_command_fsm_return_value.
9911 (finish_command_fsm::do_async_reply_reason): Rename from
9912 finish_command_fsm_async_reply_reason.
9913 (finish_command): Update.
9914 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
9915 Add constructor.
9916 (call_thread_fsm_ops): Remove.
9917 (call_thread_fsm::call_thread_fsm): Rename from
9918 new_call_thread_fsm.
9919 (call_thread_fsm::should_stop): Rename from
9920 call_thread_fsm_should_stop.
9921 (call_thread_fsm::should_notify_stop): Rename from
9922 call_thread_fsm_should_notify_stop.
9923 (run_inferior_call, call_function_by_hand_dummy): Update.
9924 * cli/cli-interp.c (should_print_stop_to_console): Update.
9925 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
9926 Add constructor. Change type of location_breakpoint,
9927 caller_breakpoint.
9928 (until_break_fsm_ops): Remove.
9929 (new_until_break_fsm): Remove.
9930 (until_break_fsm::should_stop): Rename from
9931 until_break_fsm_should_stop.
9932 (until_break_fsm::clean_up): Rename from
9933 until_break_fsm_clean_up.
9934 (until_break_fsm::do_async_reply_reason): Rename from
9935 until_break_fsm_async_reply_reason.
9936 (until_break_command): Update.
9937 * thread-fsm.c: Remove.
9938 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
9939
1a5c2598
TT
99402019-02-07 Tom Tromey <tom@tromey.com>
9941
9942 * yy-remap.h: Add include guard.
9943 * xtensa-tdep.h: Add include guard.
9944 * xcoffread.h: Rename include guard.
9945 * varobj-iter.h: Add include guard.
9946 * tui/tui.h: Rename include guard.
9947 * tui/tui-winsource.h: Rename include guard.
9948 * tui/tui-wingeneral.h: Rename include guard.
9949 * tui/tui-windata.h: Rename include guard.
9950 * tui/tui-win.h: Rename include guard.
9951 * tui/tui-stack.h: Rename include guard.
9952 * tui/tui-source.h: Rename include guard.
9953 * tui/tui-regs.h: Rename include guard.
9954 * tui/tui-out.h: Rename include guard.
9955 * tui/tui-layout.h: Rename include guard.
9956 * tui/tui-io.h: Rename include guard.
9957 * tui/tui-hooks.h: Rename include guard.
9958 * tui/tui-file.h: Rename include guard.
9959 * tui/tui-disasm.h: Rename include guard.
9960 * tui/tui-data.h: Rename include guard.
9961 * tui/tui-command.h: Rename include guard.
9962 * tic6x-tdep.h: Add include guard.
9963 * target/waitstatus.h: Rename include guard.
9964 * target/wait.h: Rename include guard.
9965 * target/target.h: Rename include guard.
9966 * target/resume.h: Rename include guard.
9967 * target-float.h: Rename include guard.
9968 * stabsread.h: Add include guard.
9969 * rs6000-tdep.h: Add include guard.
9970 * riscv-fbsd-tdep.h: Add include guard.
9971 * regformats/regdef.h: Rename include guard.
9972 * record.h: Rename include guard.
9973 * python/python.h: Rename include guard.
9974 * python/python-internal.h: Rename include guard.
9975 * python/py-stopevent.h: Rename include guard.
9976 * python/py-ref.h: Rename include guard.
9977 * python/py-record.h: Rename include guard.
9978 * python/py-record-full.h: Rename include guard.
9979 * python/py-record-btrace.h: Rename include guard.
9980 * python/py-instruction.h: Rename include guard.
9981 * python/py-events.h: Rename include guard.
9982 * python/py-event.h: Rename include guard.
9983 * procfs.h: Add include guard.
9984 * proc-utils.h: Add include guard.
9985 * p-lang.h: Add include guard.
9986 * or1k-tdep.h: Rename include guard.
9987 * observable.h: Rename include guard.
9988 * nto-tdep.h: Rename include guard.
9989 * nat/x86-linux.h: Rename include guard.
9990 * nat/x86-linux-dregs.h: Rename include guard.
9991 * nat/x86-gcc-cpuid.h: Add include guard.
9992 * nat/x86-dregs.h: Rename include guard.
9993 * nat/x86-cpuid.h: Rename include guard.
9994 * nat/ppc-linux.h: Rename include guard.
9995 * nat/mips-linux-watch.h: Rename include guard.
9996 * nat/linux-waitpid.h: Rename include guard.
9997 * nat/linux-ptrace.h: Rename include guard.
9998 * nat/linux-procfs.h: Rename include guard.
9999 * nat/linux-osdata.h: Rename include guard.
10000 * nat/linux-nat.h: Rename include guard.
10001 * nat/linux-namespaces.h: Rename include guard.
10002 * nat/linux-btrace.h: Rename include guard.
10003 * nat/glibc_thread_db.h: Rename include guard.
10004 * nat/gdb_thread_db.h: Rename include guard.
10005 * nat/gdb_ptrace.h: Rename include guard.
10006 * nat/fork-inferior.h: Rename include guard.
10007 * nat/amd64-linux-siginfo.h: Rename include guard.
10008 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10009 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10010 * nat/aarch64-linux.h: Rename include guard.
10011 * nat/aarch64-linux-hw-point.h: Rename include guard.
10012 * mn10300-tdep.h: Add include guard.
10013 * mips-linux-tdep.h: Add include guard.
10014 * mi/mi-parse.h: Rename include guard.
10015 * mi/mi-out.h: Rename include guard.
10016 * mi/mi-main.h: Rename include guard.
10017 * mi/mi-interp.h: Rename include guard.
10018 * mi/mi-getopt.h: Rename include guard.
10019 * mi/mi-console.h: Rename include guard.
10020 * mi/mi-common.h: Rename include guard.
10021 * mi/mi-cmds.h: Rename include guard.
10022 * mi/mi-cmd-break.h: Rename include guard.
10023 * m2-lang.h: Add include guard.
10024 * location.h: Rename include guard.
10025 * linux-record.h: Rename include guard.
10026 * linux-nat.h: Add include guard.
10027 * linux-fork.h: Add include guard.
10028 * i386-darwin-tdep.h: Rename include guard.
10029 * hppa-linux-offsets.h: Add include guard.
10030 * guile/guile.h: Rename include guard.
10031 * guile/guile-internal.h: Rename include guard.
10032 * gnu-nat.h: Rename include guard.
10033 * gdb-stabs.h: Rename include guard.
10034 * frv-tdep.h: Add include guard.
10035 * f-lang.h: Add include guard.
10036 * event-loop.h: Add include guard.
10037 * darwin-nat.h: Rename include guard.
10038 * cp-abi.h: Rename include guard.
10039 * config/sparc/nm-sol2.h: Rename include guard.
10040 * config/nm-nto.h: Rename include guard.
10041 * config/nm-linux.h: Add include guard.
10042 * config/i386/nm-i386gnu.h: Rename include guard.
10043 * config/djgpp/nl_types.h: Rename include guard.
10044 * config/djgpp/langinfo.h: Rename include guard.
10045 * compile/gcc-cp-plugin.h: Add include guard.
10046 * compile/gcc-c-plugin.h: Add include guard.
10047 * compile/compile.h: Rename include guard.
10048 * compile/compile-object-run.h: Rename include guard.
10049 * compile/compile-object-load.h: Rename include guard.
10050 * compile/compile-internal.h: Rename include guard.
10051 * compile/compile-cplus.h: Rename include guard.
10052 * compile/compile-c.h: Rename include guard.
10053 * common/xml-utils.h: Rename include guard.
10054 * common/x86-xstate.h: Rename include guard.
10055 * common/version.h: Rename include guard.
10056 * common/vec.h: Rename include guard.
10057 * common/tdesc.h: Rename include guard.
10058 * common/selftest.h: Rename include guard.
10059 * common/scoped_restore.h: Rename include guard.
10060 * common/scoped_mmap.h: Rename include guard.
10061 * common/scoped_fd.h: Rename include guard.
10062 * common/safe-iterator.h: Rename include guard.
10063 * common/run-time-clock.h: Rename include guard.
10064 * common/refcounted-object.h: Rename include guard.
10065 * common/queue.h: Rename include guard.
10066 * common/ptid.h: Rename include guard.
10067 * common/print-utils.h: Rename include guard.
10068 * common/preprocessor.h: Rename include guard.
10069 * common/pathstuff.h: Rename include guard.
10070 * common/observable.h: Rename include guard.
10071 * common/netstuff.h: Rename include guard.
10072 * common/job-control.h: Rename include guard.
10073 * common/host-defs.h: Rename include guard.
10074 * common/gdb_wait.h: Rename include guard.
10075 * common/gdb_vecs.h: Rename include guard.
10076 * common/gdb_unlinker.h: Rename include guard.
10077 * common/gdb_unique_ptr.h: Rename include guard.
10078 * common/gdb_tilde_expand.h: Rename include guard.
10079 * common/gdb_sys_time.h: Rename include guard.
10080 * common/gdb_string_view.h: Rename include guard.
10081 * common/gdb_splay_tree.h: Rename include guard.
10082 * common/gdb_setjmp.h: Rename include guard.
10083 * common/gdb_ref_ptr.h: Rename include guard.
10084 * common/gdb_optional.h: Rename include guard.
10085 * common/gdb_locale.h: Rename include guard.
10086 * common/gdb_assert.h: Rename include guard.
10087 * common/filtered-iterator.h: Rename include guard.
10088 * common/filestuff.h: Rename include guard.
10089 * common/fileio.h: Rename include guard.
10090 * common/environ.h: Rename include guard.
10091 * common/common-utils.h: Rename include guard.
10092 * common/common-types.h: Rename include guard.
10093 * common/common-regcache.h: Rename include guard.
10094 * common/common-inferior.h: Rename include guard.
10095 * common/common-gdbthread.h: Rename include guard.
10096 * common/common-exceptions.h: Rename include guard.
10097 * common/common-defs.h: Rename include guard.
10098 * common/common-debug.h: Rename include guard.
10099 * common/cleanups.h: Rename include guard.
10100 * common/buffer.h: Rename include guard.
10101 * common/btrace-common.h: Rename include guard.
10102 * common/break-common.h: Rename include guard.
10103 * cli/cli-utils.h: Rename include guard.
10104 * cli/cli-style.h: Rename include guard.
10105 * cli/cli-setshow.h: Rename include guard.
10106 * cli/cli-script.h: Rename include guard.
10107 * cli/cli-interp.h: Rename include guard.
10108 * cli/cli-decode.h: Rename include guard.
10109 * cli/cli-cmds.h: Rename include guard.
10110 * charset-list.h: Add include guard.
10111 * buildsym-legacy.h: Rename include guard.
10112 * bfin-tdep.h: Add include guard.
10113 * ax.h: Rename include guard.
10114 * arm-linux-tdep.h: Add include guard.
10115 * arm-fbsd-tdep.h: Add include guard.
10116 * arch/xtensa.h: Rename include guard.
10117 * arch/tic6x.h: Add include guard.
10118 * arch/i386.h: Add include guard.
10119 * arch/arm.h: Rename include guard.
10120 * arch/arm-linux.h: Rename include guard.
10121 * arch/arm-get-next-pcs.h: Rename include guard.
10122 * arch/amd64.h: Add include guard.
10123 * arch/aarch64-insn.h: Rename include guard.
10124 * arch-utils.h: Rename include guard.
10125 * annotate.h: Add include guard.
10126 * amd64-darwin-tdep.h: Rename include guard.
10127 * aarch64-linux-tdep.h: Add include guard.
10128 * aarch64-fbsd-tdep.h: Add include guard.
10129 * aarch32-linux-nat.h: Add include guard.
10130
ab9268d2
PW
101312019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10132
10133 * macrotab.c (macro_define_internal): New function that
10134 factorizes macro_define_object_internal and macro_define_function
10135 code.
10136 (macro_define_object_internal): Use macro_define_internal.
10137 (macro_define_function): Likewise.
10138
bb0da2b4
PW
101392019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10140
10141 * macrocmd.c (extract_identifier): Return
10142 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10143 callers.
10144
424eb552
JB
101452019-02-06 John Baldwin <jhb@FreeBSD.org>
10146
10147 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10148
1688cb29
TT
101492019-02-05 Tom Tromey <tom@tromey.com>
10150
10151 * target.c (target_stack::unpush): Move assertion earlier.
10152
b5eba2d8
TT
101532019-01-30 Tom Tromey <tom@tromey.com>
10154
10155 PR python/23615:
10156 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10157 (gdbpy_parse_and_eval): Likewise.
10158 * python/python-internal.h (gdbpy_allow_threads): New class.
10159
7054e2ff
JB
101602019-01-28 John Baldwin <jhb@FreeBSD.org>
10161
10162 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10163 (aarch64_fbsd_fpregmap): Move earlier.
10164 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10165 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10166 instead of individual calls to trad_frame_set_reg_addr.
10167 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10168 earlier.
10169 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10170 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10171 instead of individual calls to trad_frame_set_reg_addr.
10172
36c25ffa
AH
101732019-01-28 Alan Hayward <alan.hayward@arm.com>
10174
10175 * CONTRIBUTE: Replace contribution list with wiki link.
10176
a0707f3c
TT
101772019-01-25 Tom Tromey <tom@tromey.com>
10178
10179 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10180
0747795c
TT
101812019-01-25 Tom Tromey <tom@tromey.com>
10182
10183 * xtensa-linux-nat.c: Fix common/ includes.
10184 * xml-support.h: Fix common/ includes.
10185 * xml-support.c: Fix common/ includes.
10186 * x86-linux-nat.c: Fix common/ includes.
10187 * windows-nat.c: Fix common/ includes.
10188 * varobj.h: Fix common/ includes.
10189 * varobj.c: Fix common/ includes.
10190 * value.c: Fix common/ includes.
10191 * valops.c: Fix common/ includes.
10192 * utils.c: Fix common/ includes.
10193 * unittests/xml-utils-selftests.c: Fix common/ includes.
10194 * unittests/utils-selftests.c: Fix common/ includes.
10195 * unittests/unpack-selftests.c: Fix common/ includes.
10196 * unittests/tracepoint-selftests.c: Fix common/ includes.
10197 * unittests/style-selftests.c: Fix common/ includes.
10198 * unittests/string_view-selftests.c: Fix common/ includes.
10199 * unittests/scoped_restore-selftests.c: Fix common/ includes.
10200 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10201 * unittests/scoped_fd-selftests.c: Fix common/ includes.
10202 * unittests/rsp-low-selftests.c: Fix common/ includes.
10203 * unittests/parse-connection-spec-selftests.c: Fix common/
10204 includes.
10205 * unittests/optional-selftests.c: Fix common/ includes.
10206 * unittests/offset-type-selftests.c: Fix common/ includes.
10207 * unittests/observable-selftests.c: Fix common/ includes.
10208 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10209 * unittests/memrange-selftests.c: Fix common/ includes.
10210 * unittests/memory-map-selftests.c: Fix common/ includes.
10211 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10212 * unittests/function-view-selftests.c: Fix common/ includes.
10213 * unittests/environ-selftests.c: Fix common/ includes.
10214 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10215 * unittests/common-utils-selftests.c: Fix common/ includes.
10216 * unittests/cli-utils-selftests.c: Fix common/ includes.
10217 * unittests/array-view-selftests.c: Fix common/ includes.
10218 * ui-file.c: Fix common/ includes.
10219 * tui/tui-io.c: Fix common/ includes.
10220 * tracepoint.h: Fix common/ includes.
10221 * tracepoint.c: Fix common/ includes.
10222 * tracefile-tfile.c: Fix common/ includes.
10223 * top.h: Fix common/ includes.
10224 * top.c: Fix common/ includes.
10225 * thread.c: Fix common/ includes.
10226 * target/waitstatus.h: Fix common/ includes.
10227 * target/waitstatus.c: Fix common/ includes.
10228 * target.h: Fix common/ includes.
10229 * target.c: Fix common/ includes.
10230 * target-memory.c: Fix common/ includes.
10231 * target-descriptions.c: Fix common/ includes.
10232 * symtab.h: Fix common/ includes.
10233 * symfile.c: Fix common/ includes.
10234 * stap-probe.c: Fix common/ includes.
10235 * spu-linux-nat.c: Fix common/ includes.
10236 * sparc-nat.c: Fix common/ includes.
10237 * source.c: Fix common/ includes.
10238 * solib.c: Fix common/ includes.
10239 * solib-target.c: Fix common/ includes.
10240 * ser-unix.c: Fix common/ includes.
10241 * ser-tcp.c: Fix common/ includes.
10242 * ser-pipe.c: Fix common/ includes.
10243 * ser-base.c: Fix common/ includes.
10244 * selftest-arch.c: Fix common/ includes.
10245 * s12z-tdep.c: Fix common/ includes.
10246 * rust-exp.y: Fix common/ includes.
10247 * rs6000-aix-tdep.c: Fix common/ includes.
10248 * riscv-tdep.c: Fix common/ includes.
10249 * remote.c: Fix common/ includes.
10250 * remote-notif.h: Fix common/ includes.
10251 * remote-fileio.h: Fix common/ includes.
10252 * remote-fileio.c: Fix common/ includes.
10253 * regcache.h: Fix common/ includes.
10254 * regcache.c: Fix common/ includes.
10255 * record-btrace.c: Fix common/ includes.
10256 * python/python.c: Fix common/ includes.
10257 * python/py-type.c: Fix common/ includes.
10258 * python/py-inferior.c: Fix common/ includes.
10259 * progspace.h: Fix common/ includes.
10260 * producer.c: Fix common/ includes.
10261 * procfs.c: Fix common/ includes.
10262 * proc-api.c: Fix common/ includes.
10263 * printcmd.c: Fix common/ includes.
10264 * ppc-linux-nat.c: Fix common/ includes.
10265 * parser-defs.h: Fix common/ includes.
10266 * osdata.c: Fix common/ includes.
10267 * obsd-nat.c: Fix common/ includes.
10268 * nat/x86-linux.c: Fix common/ includes.
10269 * nat/x86-linux-dregs.c: Fix common/ includes.
10270 * nat/x86-dregs.h: Fix common/ includes.
10271 * nat/x86-dregs.c: Fix common/ includes.
10272 * nat/ppc-linux.c: Fix common/ includes.
10273 * nat/mips-linux-watch.h: Fix common/ includes.
10274 * nat/mips-linux-watch.c: Fix common/ includes.
10275 * nat/linux-waitpid.c: Fix common/ includes.
10276 * nat/linux-ptrace.h: Fix common/ includes.
10277 * nat/linux-ptrace.c: Fix common/ includes.
10278 * nat/linux-procfs.c: Fix common/ includes.
10279 * nat/linux-personality.c: Fix common/ includes.
10280 * nat/linux-osdata.c: Fix common/ includes.
10281 * nat/linux-namespaces.c: Fix common/ includes.
10282 * nat/linux-btrace.h: Fix common/ includes.
10283 * nat/linux-btrace.c: Fix common/ includes.
10284 * nat/fork-inferior.c: Fix common/ includes.
10285 * nat/amd64-linux-siginfo.c: Fix common/ includes.
10286 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10287 * nat/aarch64-linux.c: Fix common/ includes.
10288 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10289 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10290 * namespace.h: Fix common/ includes.
10291 * mips-linux-tdep.c: Fix common/ includes.
10292 * minsyms.c: Fix common/ includes.
10293 * mi/mi-parse.h: Fix common/ includes.
10294 * mi/mi-main.c: Fix common/ includes.
10295 * mi/mi-cmd-env.c: Fix common/ includes.
10296 * memrange.h: Fix common/ includes.
10297 * memattr.c: Fix common/ includes.
10298 * maint.h: Fix common/ includes.
10299 * maint.c: Fix common/ includes.
10300 * main.c: Fix common/ includes.
10301 * machoread.c: Fix common/ includes.
10302 * location.c: Fix common/ includes.
10303 * linux-thread-db.c: Fix common/ includes.
10304 * linux-nat.c: Fix common/ includes.
10305 * linux-fork.c: Fix common/ includes.
10306 * inline-frame.c: Fix common/ includes.
10307 * infrun.c: Fix common/ includes.
10308 * inflow.c: Fix common/ includes.
10309 * inferior.h: Fix common/ includes.
10310 * inferior.c: Fix common/ includes.
10311 * infcmd.c: Fix common/ includes.
10312 * inf-ptrace.c: Fix common/ includes.
10313 * inf-child.c: Fix common/ includes.
10314 * ia64-linux-nat.c: Fix common/ includes.
10315 * i387-tdep.c: Fix common/ includes.
10316 * i386-tdep.c: Fix common/ includes.
10317 * i386-linux-tdep.c: Fix common/ includes.
10318 * i386-linux-nat.c: Fix common/ includes.
10319 * i386-go32-tdep.c: Fix common/ includes.
10320 * i386-fbsd-tdep.c: Fix common/ includes.
10321 * i386-fbsd-nat.c: Fix common/ includes.
10322 * guile/scm-type.c: Fix common/ includes.
10323 * guile/guile.c: Fix common/ includes.
10324 * go32-nat.c: Fix common/ includes.
10325 * gnu-nat.c: Fix common/ includes.
10326 * gdbthread.h: Fix common/ includes.
10327 * gdbarch-selftests.c: Fix common/ includes.
10328 * gdb_usleep.c: Fix common/ includes.
10329 * gdb_select.h: Fix common/ includes.
10330 * gdb_bfd.c: Fix common/ includes.
10331 * gcore.c: Fix common/ includes.
10332 * fork-child.c: Fix common/ includes.
10333 * findvar.c: Fix common/ includes.
10334 * fbsd-nat.c: Fix common/ includes.
10335 * event-top.c: Fix common/ includes.
10336 * event-loop.c: Fix common/ includes.
10337 * dwarf2read.c: Fix common/ includes.
10338 * dwarf2loc.c: Fix common/ includes.
10339 * dwarf2-frame.c: Fix common/ includes.
10340 * dwarf-index-cache.c: Fix common/ includes.
10341 * dtrace-probe.c: Fix common/ includes.
10342 * disasm-selftests.c: Fix common/ includes.
10343 * defs.h: Fix common/ includes.
10344 * csky-tdep.c: Fix common/ includes.
10345 * cp-valprint.c: Fix common/ includes.
10346 * cp-support.h: Fix common/ includes.
10347 * cp-support.c: Fix common/ includes.
10348 * corelow.c: Fix common/ includes.
10349 * completer.h: Fix common/ includes.
10350 * completer.c: Fix common/ includes.
10351 * compile/compile.c: Fix common/ includes.
10352 * compile/compile-loc2c.c: Fix common/ includes.
10353 * compile/compile-cplus-types.c: Fix common/ includes.
10354 * compile/compile-cplus-symbols.c: Fix common/ includes.
10355 * command.h: Fix common/ includes.
10356 * cli/cli-dump.c: Fix common/ includes.
10357 * cli/cli-cmds.c: Fix common/ includes.
10358 * charset.c: Fix common/ includes.
10359 * build-id.c: Fix common/ includes.
10360 * btrace.h: Fix common/ includes.
10361 * btrace.c: Fix common/ includes.
10362 * breakpoint.h: Fix common/ includes.
10363 * breakpoint.c: Fix common/ includes.
10364 * ax.h:
10365 (enum agent_op): Fix common/ includes.
10366 * ax-general.c (struct aop_map): Fix common/ includes.
10367 * ax-gdb.c: Fix common/ includes.
10368 * auxv.c: Fix common/ includes.
10369 * auto-load.c: Fix common/ includes.
10370 * arm-tdep.c: Fix common/ includes.
10371 * arch/riscv.c: Fix common/ includes.
10372 * arch/ppc-linux-common.c: Fix common/ includes.
10373 * arch/i386.c: Fix common/ includes.
10374 * arch/arm.c: Fix common/ includes.
10375 * arch/arm-linux.c: Fix common/ includes.
10376 * arch/arm-get-next-pcs.c: Fix common/ includes.
10377 * arch/amd64.c: Fix common/ includes.
10378 * arch/aarch64.c: Fix common/ includes.
10379 * arch/aarch64-insn.c: Fix common/ includes.
10380 * arch-utils.c: Fix common/ includes.
10381 * amd64-windows-tdep.c: Fix common/ includes.
10382 * amd64-tdep.c: Fix common/ includes.
10383 * amd64-sol2-tdep.c: Fix common/ includes.
10384 * amd64-obsd-tdep.c: Fix common/ includes.
10385 * amd64-nbsd-tdep.c: Fix common/ includes.
10386 * amd64-linux-tdep.c: Fix common/ includes.
10387 * amd64-linux-nat.c: Fix common/ includes.
10388 * amd64-fbsd-tdep.c: Fix common/ includes.
10389 * amd64-fbsd-nat.c: Fix common/ includes.
10390 * amd64-dicos-tdep.c: Fix common/ includes.
10391 * amd64-darwin-tdep.c: Fix common/ includes.
10392 * agent.c: Fix common/ includes.
10393 * ada-lang.h: Fix common/ includes.
10394 * ada-lang.c: Fix common/ includes.
10395 * aarch64-tdep.c: Fix common/ includes.
10396
2f5c153e
TT
103972019-01-25 Tom Tromey <tom@tromey.com>
10398
10399 * common/create-version.sh: Use common/version.h.
10400
adc6a863
PA
104012019-01-24 Pedro Alves <palves@redhat.com>
10402
10403 * infrun.c (signal_stop, signal_print, signal_program)
10404 (signal_catch, signal_pass): Now arrays instead of pointers.
10405 (update_signals_program_target, do_target_resume)
10406 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10407 * linux-nat.c (linux_nat_target::pass_signals)
10408 (linux_nat_target::create_inferior, linux_nat_target::attach):
10409 Adjust.
10410 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10411 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10412 * procfs.c (procfs_target::pass_signals): Adjust.
10413 * record-full.c (record_full_target::resume): Adjust.
10414 * remote.c (remote_target::pass_signals)
10415 (remote_target::program_signals): Adjust.
10416 * target-debug.h (target_debug_print_signals): Now takes a
10417 gdb::array_view as parameter. Adjust.
10418 * target.h (target_ops) <pass_signals, program_signals>: Replace
10419 pointer and length parameters with gdb::array_view.
10420 (target_pass_signals, target_program_signals): Likewise.
10421 * target-delegates.c: Regenerate.
10422
3046d67a
PA
104232019-01-24 Pedro Alves <palves@redhat.com>
10424
10425 * common/forward-scope-exit.h
10426 (forward_scope_exit::forward_scope_exit): Pass arguments to
10427 m_bind_function directly, instead of creating a std::bind and
10428 copying that.
10429
353229bf
AH
104302019-01-24 Alan Hayward <alan.hayward@arm.com>
10431
10432 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10433 for static members.
10434 (pass_in_v_vfp_candidate): Likewise.
10435
311dc83a
TT
104362019-01-23 Tom Tromey <tom@tromey.com>
10437 Pedro Alves <palves@redhat.com>
10438
10439 * regcache.c (class regcache_invalidator): Remove.
10440 (regcache::raw_write): Use make_scope_exit.
10441
296bd123
TT
104422019-01-23 Tom Tromey <tom@tromey.com>
10443
10444 * ui-out.h (class ui_out_emit_type): Update comment.
10445
979a0d13
TT
104462019-01-23 Tom Tromey <tom@tromey.com>
10447
10448 * infrun.c (fetch_inferior_event): Update comment.
10449
d238133d
TT
104502019-01-23 Tom Tromey <tom@tromey.com>
10451 Pedro Alves <palves@redhat.com>
10452
10453 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10454 parameter.
10455 (fetch_inferior_event): Use SCOPE_EXIT.
10456
10457
9885e6bb
TT
104582019-01-23 Tom Tromey <tom@tromey.com>
10459 Pedro Alves <palves@redhat.com>
10460
10461 * infrun.c (disable_thread_events): Delete.
10462 (stop_all_threads): Use SCOPE_EXIT.
10463
286526c1
TT
104642019-01-23 Tom Tromey <tom@tromey.com>
10465 Pedro Alves <palves@redhat.com>
10466
10467 * symfile.c: Include forward-scope-exit.h.
10468 (clear_symtab_users_cleanup): Replace forward declaration with
10469 a FORWARD_SCOPE_EXIT.
10470 (syms_from_objfile_1): Use the forward_scope_exit and
10471 gdb::optional instead of cleanup_function.
10472 (reread_symbols): Use the forward_scope_exit instead of
10473 cleanup_function.
10474 (clear_symtab_users_cleanup): Remove function.
10475
1db93f14
TT
104762019-01-23 Tom Tromey <tom@tromey.com>
10477 Pedro Alves <palves@redhat.com>
10478
10479 * linux-nat.c: Include scope-exit.h.
10480 (cleanup_target_stop): Remove.
10481 (linux_nat_target::static_tracepoint_markers_by_strid): Use
10482 SCOPE_EXIT.
10483
2cc83d1e
TT
104842019-01-23 Tom Tromey <tom@tromey.com>
10485 Pedro Alves <palves@redhat.com>
10486
10487 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
10488 (call_function_by_hand_dummy): Use SCOPE_EXIT.
10489
694c6bf5
TT
104902019-01-23 Tom Tromey <tom@tromey.com>
10491 Andrew Burgess <andrew.burgess@embecosm.com>
10492 Pedro Alves <palves@redhat.com>
10493
10494 * infrun.c (fetch_inferior_event): Use scope_exit.
10495 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
10496 * top.c (execute_command): Use scope_exit.
10497 * breakpoint.c (bpstat_do_actions): Use scope_exit.
10498 * utils.c (do_bpstat_clear_actions_cleanup)
10499 (make_bpstat_clear_actions_cleanup): Remove.
10500
4c41382a
TT
105012019-01-23 Tom Tromey <tom@tromey.com>
10502 Pedro Alves <palves@redhat.com>
10503
10504 * infrun.c: Include "common/scope-exit.h"
10505 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
10506 (wait_for_inferior): Use SCOPE_EXIT.
10507 (fetch_inferior_event): Use scope_exit.
10508
89f8fb50
TT
105092019-01-23 Tom Tromey <tom@tromey.com>
10510 Pedro Alves <palves@redhat.com>
10511
10512 * breakpoint.c (create_breakpoint): Remove cleanup.
10513
5419bdae
TT
105142019-01-23 Tom Tromey <tom@tromey.com>
10515 Andrew Burgess <andrew.burgess@embecosm.com>
10516 Pedro Alves <palves@redhat.com>
10517
e587ef42
PA
105182019-01-23 Pedro Alves <palves@redhat.com>
10519
10520 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
10521
77f0e74c
PA
105222019-01-23 Pedro Alves <palves@redhat.com>
10523 Andrew Burgess <andrew.burgess@embecosm.com>
10524
10525 * gdbthread.h: Include "common/forward-scope-exit.h".
10526 (scoped_finish_thread_state): Redefine custom class in terms of
10527 forward_scope_exit.
10528
5b9b3e53
PA
105292019-01-23 Pedro Alves <palves@redhat.com>
10530 Andrew Burgess <andrew.burgess@embecosm.com>
10531
10532 * common/forward-scope-exit.h: New file.
10533
54b65c9b
PA
105342019-01-23 Pedro Alves <palves@redhat.com>
10535 Andrew Burgess <andrew.burgess@embecosm.com>
10536 Tom Tromey <tom@tromey.com>
10537
10538 * common/scope-exit.h: New file.
10539
cf08fb29
PA
105402019-01-23 Pedro Alves <palves@redhat.com>
10541
10542 * common/preprocessor.h (ESC): Rename to ...
10543 (ESC_PARENS): ... this.
10544 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
10545 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
10546
ae73e2e2
TT
105472019-01-23 Tom Tromey <tom@tromey.com>
10548
10549 * language.h (class scoped_switch_to_sym_language_if_auto):
10550 Initialize m_lang in both cases.
10551
6594e122
AH
105522019-01-23 Alan Hayward <alan.hayward@arm.com>
10553
10554 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
10555 with XCNEW.
10556
a7c9855d
TT
105572019-01-22 Tom Tromey <tom@tromey.com>
10558
10559 * corelow.c: Do not include sys/file.h.
10560
93cc1d53
TT
105612019-01-22 Tom Tromey <tom@tromey.com>
10562
10563 * tui/tui-wingeneral.h: Include gdb_curses.h.
10564
38561778
TT
105652019-01-22 Tom Tromey <tom@tromey.com>
10566
10567 * source-cache.h (class source_cache) <get_source_lines,
10568 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
10569
37b3ab5b
TT
105702019-01-22 Tom Tromey <tom@tromey.com>
10571
10572 * remote-fileio.h (struct remote_target): Declare.
10573
3fabc016
TT
105742019-01-22 Tom Tromey <tom@tromey.com>
10575
10576 * python/py-arch.c: Do not include py-ref.h.
10577 * python/py-bpevent.c: Do not include py-ref.h.
10578 * python/py-cmd.c: Do not include py-ref.h.
10579 * python/py-continueevent.c: Do not include py-ref.h.
10580 * python/py-event.h: Do not include py-ref.h.
10581 * python/py-evtregistry.c: Do not include py-ref.h.
10582 * python/py-finishbreakpoint.c: Do not include py-ref.h.
10583 * python/py-frame.c: Do not include py-ref.h.
10584 * python/py-framefilter.c: Do not include py-ref.h.
10585 * python/py-function.c: Do not include py-ref.h.
10586 * python/py-infevents.c: Do not include py-ref.h.
10587 * python/py-linetable.c: Do not include py-ref.h.
10588 * python/py-objfile.c: Do not include py-ref.h.
10589 * python/py-param.c: Do not include py-ref.h.
10590 * python/py-prettyprint.c: Do not include py-ref.h.
10591 * python/py-progspace.c: Do not include py-ref.h.
10592 * python/py-symbol.c: Do not include py-ref.h.
10593 * python/py-symtab.c: Do not include py-ref.h.
10594 * python/py-type.c: Do not include py-ref.h.
10595 * python/py-unwind.c: Do not include py-ref.h.
10596 * python/py-utils.c: Do not include py-ref.h.
10597 * python/py-value.c: Do not include py-ref.h.
10598 * python/py-varobj.c: Do not include py-ref.h.
10599 * python/py-xmethods.c: Do not include py-ref.h.
10600 * python/python.c: Do not include py-ref.h.
10601 * varobj.c: Do not include py-ref.h.
10602
6b4d7774
TT
106032019-01-22 Tom Tromey <tom@tromey.com>
10604
10605 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
10606 keyword for bcache.
10607
7af7e9b5
TT
106082019-01-22 Tom Tromey <tom@tromey.com>
10609
10610 * compile/compile-cplus-types.c: Remove a comment by #include.
10611
951d1049
TT
106122019-01-22 Tom Tromey <tom@tromey.com>
10613
10614 * compile/gcc-c-plugin.h: Include compile-internal.h.
10615
d65d5705
TT
106162019-01-22 Tom Tromey <tom@tromey.com>
10617
10618 * stabsread.c (EXTERN): Do not define.
10619 (symnum, next_symbol_text_func, processing_gcc_compilation)
10620 (within_function, global_sym_chain, global_stabs)
10621 (previous_stab_code, this_object_header_files)
10622 (n_this_object_header_files)
10623 (n_allocated_this_object_header_files): Define.
10624 * stabsread.h (EXTERN): Never define. Use "extern".
10625
b6fb1ee5
PW
106262019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10627
10628 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
10629 history_value.
10630
be6d4f74
TT
106312019-01-21 Tom Tromey <tom@tromey.com>
10632
10633 * ui-out.c: Fix includes.
10634 * tui/tui-source.c: Fix includes.
10635 * target.c: Fix includes.
10636 * remote.c: Fix includes.
10637 * regcache.c: Fix includes.
10638 * python/py-block.c: Fix includes.
10639 * printcmd.c: Fix includes.
10640 * or1k-tdep.c: Fix includes.
10641 * mi/mi-main.c: Fix includes.
10642 * m32r-tdep.c: Fix includes.
10643 * csky-tdep.c: Fix includes.
10644 * compile/compile-cplus-types.c: Fix includes.
10645 * cli/cli-interp.c: Fix includes.
10646
73021deb
AH
106472019-01-21 Alan Hayward <alan.hayward@arm.com>
10648
10649 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10650 for padding.
10651
7932255d
TT
106522019-01-16 Tom Tromey <tom@tromey.com>
10653
10654 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
10655 earlier.
10656 (struct objfile) <msymbols_range>: Move from top level.
10657 <msymbols>: New method.
10658 (class objfile_msymbols): Remove.
10659 * symtab.c (default_collect_symbol_completion_matches_break_on):
10660 Update.
10661 * symmisc.c (dump_msymbols): Update.
10662 * stabsread.c (scan_file_globals): Update.
10663 * objc-lang.c (info_selectors_command, info_classes_command)
10664 (find_methods): Update.
10665 * minsyms.c (find_solib_trampoline_target): Update.
10666 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
10667 * coffread.c (coff_symfile_read): Update.
10668 * ada-lang.c (ada_lookup_simple_minsym)
10669 (ada_collect_symbol_completion_matches): Update.
10670
604b1bfb
TT
106712019-01-16 Tom Tromey <tom@tromey.com>
10672
10673 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
10674 type. Remove no-argument constructor.
10675 <iterator::operator++>: Simplify.
10676 <begin>: Update.
10677 <end>: Use minimal_symbol_count.
10678
f252c6d5
TT
106792019-01-16 Tom Tromey <tom@tromey.com>
10680
10681 * objfiles.h (struct objfile) <psymtabs>: New method.
10682 (class objfile_psymtabs): Remove.
10683 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
10684 typedef.
10685 <range>: New method.
10686 (require_partial_symbols): Change return type.
10687 * psymtab.c (require_partial_symbols)
10688 (psym_expand_symtabs_matching): Update.
10689 * mdebugread.c (parse_partial_symbols): Update.
10690 * dbxread.c (dbx_end_psymtab): Update.
10691
b669c953
TT
106922019-01-15 Tom Tromey <tom@tromey.com>
10693
10694 * symtab.c (lookup_objfile_from_block)
10695 (lookup_symbol_in_objfile_symtabs)
10696 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
10697 (find_line_symtab, info_sources_command)
10698 (default_collect_symbol_completion_matches_break_on)
10699 (make_source_files_completion_list): Update.
10700 * symmisc.c (print_objfile_statistics, dump_objfile)
10701 (maintenance_print_symbols, maintenance_info_symtabs)
10702 (maintenance_check_symtabs, maintenance_info_line_tables):
10703 Update.
10704 * source.c (select_source_symtab)
10705 (forget_cached_source_info_for_objfile): Update.
10706 * objfiles.h (class objfile_compunits): Remove.
10707 (struct objfile) <compunits_range>: New typedef.
10708 (compunits): New method.
10709 * objfiles.c (objfile_relocate1): Update.
10710 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10711 * maint.c (count_symtabs_and_blocks): Update.
10712 * linespec.c (iterate_over_all_matching_symtabs): Update.
10713 * cp-support.c (add_symbol_overload_list_qualified): Update.
10714 * coffread.c (coff_symtab_read): Update.
10715 * ada-lang.c (add_nonlocal_symbols)
10716 (ada_collect_symbol_completion_matches)
10717 (ada_add_global_exceptions): Update.
10718
7e955d83
TT
107192019-01-15 Tom Tromey <tom@tromey.com>
10720
10721 * progspace.h (program_space) <objfiles_safe_range>: New
10722 typedef.
10723 <objfiles_safe>: New method.
10724 * objfiles.h (class all_objfiles_safe): Remove.
10725 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
10726 * jit.c (jit_inferior_exit_hook): Update.
10727
2030c079
TT
107282019-01-17 Tom Tromey <tom@tromey.com>
10729
10730 * progspace.h (program_space) <objfiles_range>: New typedef.
10731 <objfiles>: New method.
10732 <objfiles_head>: Rename from objfiles.
10733 (object_files): Update.
10734 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
10735 * guile/scm-pretty-print.c
10736 (ppscm_find_pretty_printer_from_objfiles): Update.
10737 * guile/scm-objfile.c (gdbscm_objfiles): Update.
10738 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
10739 Update.
10740 * python/py-progspace.c (pspy_get_objfiles): Update.
10741 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10742 Update.
10743 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10744 (objfpy_lookup_objfile_by_build_id): Update.
10745 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
10746 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10747 Update.
10748 * symtab.c (iterate_over_symtabs, matching_obj_sections)
10749 (expand_symtab_containing_pc, lookup_objfile_from_block)
10750 (lookup_static_symbol, basic_lookup_transparent_type)
10751 (find_pc_sect_compunit_symtab, find_symbol_at_address)
10752 (find_line_symtab, info_sources_command)
10753 (default_collect_symbol_completion_matches_break_on)
10754 (make_source_files_completion_list, find_main_name): Update.
10755 * symmisc.c (print_symbol_bcache_statistics)
10756 (print_objfile_statistics, maintenance_print_symbols)
10757 (maintenance_print_msymbols, maintenance_print_objfiles)
10758 (maintenance_info_symtabs, maintenance_check_symtabs)
10759 (maintenance_expand_symtabs, maintenance_info_line_tables):
10760 Update.
10761 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
10762 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
10763 (map_overlay_command, unmap_overlay_command)
10764 (simple_overlay_update, expand_symtabs_matching)
10765 (map_symbol_filenames): Update.
10766 * symfile-debug.c (set_debug_symfile): Update.
10767 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
10768 Update.
10769 * source.c (select_source_symtab, forget_cached_source_info):
10770 Update.
10771 * solib.c (solib_read_symbols): Update.
10772 * solib-spu.c (append_ocl_sos): Update.
10773 * psymtab.c (maintenance_print_psymbols)
10774 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
10775 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
10776 * printcmd.c (info_symbol_command): Update.
10777 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
10778 Update.
10779 * objfiles.h (class all_objfiles): Remove.
10780 * objfiles.c (have_partial_symbols, have_full_symbols)
10781 (have_minimal_symbols, qsort_cmp, update_section_map)
10782 (shared_objfile_contains_address_p)
10783 (default_iterate_over_objfiles_in_search_order): Update.
10784 * objc-lang.c (info_selectors_command, info_classes_command)
10785 (find_methods): Update.
10786 * minsyms.c (find_solib_trampoline_target): Update.
10787 * maint.c (maintenance_info_sections)
10788 (maintenance_translate_address, count_symtabs_and_blocks):
10789 Update.
10790 * main.c (captured_main_1): Update.
10791 * linux-thread-db.c (try_thread_db_load_from_pdir)
10792 (has_libpthread): Update.
10793 * linespec.c (iterate_over_all_matching_symtabs)
10794 (search_minsyms_for_name): Update.
10795 * jit.c (jit_find_objf_with_entry_addr): Update.
10796 * hppa-tdep.c (find_unwind_entry)
10797 (hppa_lookup_stub_minimal_symbol): Update.
10798 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
10799 Update.
10800 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10801 (elf_gnu_ifunc_resolve_by_got): Update.
10802 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
10803 * dwarf-index-write.c (save_gdb_index_command): Update.
10804 * cp-support.c (add_symbol_overload_list_qualified): Update.
10805 * breakpoint.c (create_overlay_event_breakpoint)
10806 (create_longjmp_master_breakpoint)
10807 (create_std_terminate_master_breakpoint)
10808 (create_exception_master_breakpoint): Update.
10809 * blockframe.c (find_pc_partial_function): Update.
10810 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
10811 (ada_collect_symbol_completion_matches)
10812 (ada_add_global_exceptions): Update.
10813
776489e0
TT
108142019-01-17 Tom Tromey <tom@tromey.com>
10815
10816 * solib-target.c (lm_info_target_p): Remove typedef. Don't
10817 declare VEC.
10818 (solib_target_parse_libraries): Change return type.
10819 (library_list_start_segment, library_list_start_section)
10820 (library_list_end_library, library_list_start_library); Update.
10821 (solib_target_free_library_list): Remove.
10822 (solib_target_parse_libraries): Remove cleanup. Change return
10823 type.
10824 (solib_target_current_sos): Update.
10825
6471e7d2
TT
108262019-01-17 Tom Tromey <tromey@bapiya>
10827
10828 * valprint.c: Replace "the the" with "the".
10829 * symtab.c: Replace "the the" with "the".
10830 * solib.c: Replace "the the" with "the".
10831 * solib-dsbt.c: Replace "the the" with "the".
10832 * linespec.c: Replace "the the" with "the".
10833 * dwarf2loc.h: Replace "the the" with "the".
10834 * amd64-windows-tdep.c: Replace "the the" with "the".
10835 * aarch64-tdep.c: Replace "the the" with "the".
10836
c24bdb02
KS
108372019-01-16 Keith Seitz <keiths@redhat.com>
10838
10839 PR gdb/23773
10840 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
10841 <builder>: Rename to ..
10842 <m_builder>: ... this and make private.
10843 (dwarf2_cu::get_builder): New method. Change all users of
10844 `builder' to use this method.
10845 (dwarf2_start_symtab): Move to ...
10846 (dwarf2_cu::start_symtab): ... here. Update all callers
10847 (setup_type_unit_groups): Move to ...
10848 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
10849 callers.
10850 (dwarf2_cu::reset_builder): New method.
10851 (process_full_compunit, process_full_type_unit): Use
10852 dwarf2_cu::reset_builder.
10853 (follow_die_offset): Record the ancestor CU if it is different
10854 from the followed DIE's CU.
10855 (follow_die_sig_1): Likewise.
10856
8d64371b
TT
108572019-01-15 Tom Tromey <tom@tromey.com>
10858
10859 * remote.c (class remote_state) <buf>: Now a char_vector.
10860 <buf_size>: Remove.
10861 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
10862 parameter.
10863 (remote_target::getpkt_or_notif_sane_1)
10864 (remote_target::getpkt_sane)
10865 (remote_target::getpkt_or_notif_sane): Likewise.
10866 (class remote_target) <putpkt>: New overload.
10867 (remote_target::read_frame): Change type of "buf_p". Remove
10868 sizeof_p parameter.
10869 (packet_ok): New overload.
10870 (packet_check_result): New overload.
10871 Update all uses.
10872
bb277751
TT
108732019-01-14 Tom Tromey <tom@tromey.com>
10874
10875 * remote-notif.c (handle_notification, remote_notif_ack)
10876 (remote_notif_parse): Make "buf" const.
10877 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
10878 const.
10879 (remote_notif_parse, remote_notif_ack, handle_notification):
10880 Likewise.
10881 * remote.c (remote_notif_stop_parse): Make "buf" const.
10882 (remote_target::remote_parse_stop_reply): Make "buf" const.
10883 (remote_notif_stop_ack): Make "buf" const.
10884
05be00a8
TT
108852019-01-14 Tom Tromey <tom@tromey.com>
10886
10887 * remote.c (remote_console_output): Make parameter const.
10888
491adeca
TT
108892019-01-14 Tom Tromey <tom@tromey.com>
10890
10891 * target-debug.h (target_debug_print_signals): Constify.
10892 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
10893 * procfs.c (procfs_target::pass_signals): Update.
10894 * linux-nat.c (linux_nat_target::pass_signals): Update.
10895 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
10896 * target-delegates.c: Rebuild.
10897 * remote.c (remote_target::program_signals): Update.
10898 (remote_target::pass_signals): Update.
10899 * target.c (target_pass_signals): Constify argument.
10900 (target_program_signals): Likewise.
10901 * target.h (struct target_ops) <pass_signals, program_signals>:
10902 Constify argument.
10903 (target_pass_signals, target_program_signals): Constify argument.
10904
bbd94648
TT
109052019-01-14 Tom Tromey <tom@tromey.com>
10906
10907 PR tui/28819:
10908 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
10909
6f072a10
PFC
109102019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
10911
10912 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
10913 field.
10914 * rs6000-tdep.c: Include reggroups.h.
10915 (IS_V_ALIAS_PSEUDOREG): Define.
10916 (rs6000_register_name): Return names for the "vX" aliases.
10917 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
10918 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
10919 aliases. Call default_register_reggroup_p for all other
10920 pseudo-registers.
10921 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
10922 New functions.
10923 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
10924 Handle "vX" aliases.
10925 (v_alias_pseudo_register_collect): New function.
10926 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
10927 (rs6000_gdbarch_init): Initialize "vX" aliases as
10928 pseudo-registers. Restore registration of
10929 rs6000_pseudo_register_reggroup_p with
10930 set_tdesc_pseudo_register_reggroup_p.
10931
1a782351
MF
109322019-01-13 Max Filippov <jcmvbkbc@gmail.com>
10933
10934 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
10935 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
10936 set_gdbarch_num_pseudo_regs.
10937
d73cff18
PW
109382019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10939
10940 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
10941 Remove arg prefixname, add do_set and do_show.
10942 Add member functions set_list and show_list.
10943 * cli/cli-style.c (class cli_style_option): Update accordingly.
10944 (style_set_list): Move to file scope.
10945 (style_show_list): Likewise.
10946 (set_style): Call help_list.
10947 (show_style): Call cmd_show_list.
10948 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
10949 Update to use the new macro.
10950
60a90376
JB
109512019-10-12 Joel Brobecker <brobecker@adacore.com>
10952
10953 * ada-lang.c (_initialize_ada_language): Expand the help text
10954 for the "catch exception" command.
10955
9d7c67bf
PW
109562019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10957
10958 * symtab.c (matching_obj_sections): Initialize obj,
10959 declare it closer to its usage.
10960
7cf47dc4
TT
109612019-01-10 Tom Tromey <tom@tromey.com>
10962
10963 * thread-iter.h (inf_threads_iterator): Use next_iterator.
10964 (basic_inf_threads_range): Remove.
10965 (inf_threads_range, inf_non_exited_threads_range)
10966 (safe_inf_threads_range): Use next_adapter.
10967
d3cb6808
KS
109682019-01-10 Keith Seitz <keiths@redhat.com>
10969
10970 PR gdb/23712
10971 PR symtab/23010
10972 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
10973 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
10974
63a20375
KS
109752019-01-10 Keith Seitz <keiths@redhat.com>
10976
10977 PR gdb/23712
10978 PR symtab/23010
10979 * dictionary.c (pending_to_vector): Remove.
10980 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
10981 Remove _1 suffix, replacing functions of the same name. Update
10982 all callers.
10983 (dict_create_hashed, dict_create_hashed_expandable)
10984 (dict_create_linear, dict_create_linear_expandable, dict_free)
10985 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
10986 Make functions static.
10987
b026f593
KS
109882019-01-10 Keith Seitz <keiths@redhat.com>
10989
10990 PR gdb/23712
10991 PR symtab/23010
10992 * dictionary.h (struct dictionary): Replace declaration with
10993 multidictionary.
10994 (dict_create_hashed, dict_create_hashed_expandable)
10995 (dict_create_linear, dict_create_linear_expandable)
10996 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
10997 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
10998 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
10999 taking multidictionary argument.
11000 [ALL_DICT_SYMBOLS]: Update for multidictionary.
11001 * block.h (struct block) <dict>: Change to multidictionary
11002 and rename `multidict'.
11003 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11004 symmisc.c: Update all dictionary references to multidictionary.
11005
c7748ee9
KS
110062019-01-10 Keith Seitz <keiths@redhat.com>
11007
11008 PR gdb/23712
11009 PR symtab/23010
11010 * dictionary.c: Include unordered_map.
11011 (pending_to_vector): New function.
11012 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11013 Rewrite the non-"_1" functions to take vector instead
11014 of linked list.
11015 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11016 "new" _1 versions of the same name.
11017 (multidictionary): Define.
11018 (std::hash<enum language): New definition.
11019 (collate_pending_symbols_by_language, mdict_create_hashed)
11020 (mdict_create_hashed_expandable, mdict_create_linear)
11021 (mdict_create_linear_expandable, mdict_free)
11022 (find_language_dictionary, create_new_language_dictionary)
11023 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11024 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11025 (mdict_size, mdict_empty): New functions.
11026 * dictionary.h (mdict_iterator): Define.
11027
67aa1f3c
PA
110282019-01-10 Pedro Alves <palves@redhat.com>
11029
11030 * breakpoint.c (read_uploaded_action)
11031 (create_tracepoint_from_upload): Adjust to use
11032 gdb::unique_xmalloc_ptr.
11033 * ctf.c (ctf_write_uploaded_tp):
11034 (SET_ARRAY_FIELD): Use emplace_back.
11035 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11036 * tracefile-tfile.c (tfile_write_uploaded_tp):
11037 * tracepoint.c (parse_tracepoint_definition): Adjust to use
11038 gdb::unique_xmalloc_ptr.
11039 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11040 at_string, cond_string, cmd_strings>: Replace char pointers
11041 with gdb::unique_xmalloc_ptr.
11042
2f667667
PA
110432019-01-10 Pedro Alves <palves@redhat.com>
11044
11045 * solib-target.c (library_list_start_library): Don't xstrdup name.
11046
36cb7237
PA
110472019-01-10 Pedro Alves <palves@redhat.com>
11048
11049 * mdebugread.c (parse_partial_symbols): Use
11050 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11051
da584958
AB
110522019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11053
11054 * linux-fork.c (scoped_switch_fork_info)
11055 <~scoped_switch_fork_info>: Fix incorrect variable name.
11056
1ef8573c
AB
110572019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
11058
11059 * linux-fork.c (scoped_switch_fork_info)
11060 <scoped_switch_fork_info>: Make explicit.
11061 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11062
8d7bcccb
TT
110632019-01-10 Tom Tromey <tom@tromey.com>
11064
11065 * objfiles.h (objfile::reset_psymtabs): Update.
11066 * objfiles.c (objfile::objfile): Update.
11067 * psymtab.h (psymtab_storage::obstack): Update.
11068 (psymtab_storage::m_obstack): Use gdb::optional.
11069 (class psymtab_storage): Update comment. Remove objfile
11070 parameter.
11071 * psymtab.c (psymtab_storage::psymtab_storage): Update.
11072
b596a3c7
TT
110732019-01-10 Tom Tromey <tom@tromey.com>
11074
11075 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11076 <free_psymtabs>: Now private.
11077 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11078 (allocate_psymtab): Use new method.
11079
a9342b62
TT
110802019-01-10 Tom Tromey <tom@tromey.com>
11081
11082 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11083 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11084 * mdebugread.c (parse_partial_symbols): Use
11085 allocate_dependencies.
11086 * dwarf2read.c (dwarf2_create_include_psymtab): Use
11087 allocate_dependencies.
11088 (process_psymtab_comp_unit_reader)
11089 (build_type_psymtab_dependencies): Likewise.
11090 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11091
5af70966
TT
110922019-01-10 Tom Tromey <tom@tromey.com>
11093
11094 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11095 PSYMBOL_SET_LANGUAGE.
11096 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11097
5923a04c
TT
110982019-01-10 Tom Tromey <tom@tromey.com>
11099
11100 * psymtab.h (psymtab_storage::obstack): New method.
11101 <m_obstack>: Rename from obstack; now private.
11102 * psymtab.c (psymtab_storage): Update.
11103 * dwarf2read.c (create_addrmap_from_index)
11104 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11105 Update.
11106
6d6a12bf
TT
111072019-01-10 Tom Tromey <tom@tromey.com>
11108
11109 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11110 * objfiles.h (objfile::reset_psymtabs): New method.
11111
d320c2b5
TT
111122019-01-10 Tom Tromey <tom@tromey.com>
11113
11114 * symmisc.c (print_symbol_bcache_statistics): Update.
11115 (print_objfile_statistics): Update.
11116 * symfile.c (reread_symbols): Update.
11117 * psymtab.h (class psymtab_storage): New.
11118 * psymtab.c (psymtab_storage): New constructor.
11119 (~psymtab_storage): New destructor.
11120 (require_partial_symbols): Update.
11121 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11122 (find_pc_sect_psymtab, find_pc_sect_psymbol)
11123 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11124 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11125 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11126 (start_psymtab_common, end_psymtab_common)
11127 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11128 (allocate_psymtab): Update.
11129 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11130 Update.
11131 (dump_psymtab_addrmap, maintenance_print_psymbols)
11132 (maintenance_check_psymtabs): Update.
11133 (class objfile_psymtabs): Move to objfiles.h.
11134 * psympriv.h (discard_psymtab): Now inline.
11135 (psymtab_discarder::psymtab_discarder): Update.
11136 (psymtab_discarder::~psymtab_discarder): Update.
11137 (ALL_OBJFILE_PSYMTABS): Rewrite.
11138 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11139 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11140 Remove fields.
11141 <partial_symtabs>: New field.
11142 (class objfile_psymtabs): Move from psymtab.h. Update.
11143 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11144 psymbol_cache.
11145 (objfile::~objfile): Don't destroy psymbol_cache.
11146 * mdebugread.c (parse_partial_symbols): Update.
11147 * dwarf2read.c (create_addrmap_from_index)
11148 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11149 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11150 (add_partial_subprogram, dwarf2_ranges_read): Update.
11151 * dwarf-index-write.c (write_address_map)
11152 (write_one_signatured_type, recursively_write_psymbols)
11153 (class debug_names, class debug_names, write_psymtabs_to_index):
11154 Update.
11155
1d94a5a3
TT
111562019-01-10 Tom Tromey <tom@tromey.com>
11157
11158 * symtab.h (SYMBOL_SET_NAMES): Update.
11159 (symbol_set_names): Update.
11160 (MSYMBOL_SET_NAMES): Update.
11161 * symtab.c (symbol_set_names): Change argument to be an
11162 objfile_per_bfd_storage.
11163 * psymtab.c (add_psymbol_to_bcache): Update.
11164 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11165
0f14768a
TT
111662019-01-10 Tom Tromey <tom@tromey.com>
11167
11168 * symtab.c (create_demangled_names_hash): Change argument to be an
11169 objfile_per_bfd_storage.
11170 (symbol_set_names): Update.
11171
6eee24ce
TT
111722019-01-10 Tom Tromey <tom@tromey.com>
11173
11174 * xcoffread.c (xcoff_initial_scan): Unconditionally call
11175 init_psymbol_list.
11176 * psymtab.c (init_psymbol_list): Do nothing if already called.
11177 * psympriv.h (init_psymbol_list): Add comment.
11178 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11179 init_psymbol_list.
11180 * dbxread.c (dbx_symfile_read): Unconditionally call
11181 init_psymbol_list.
11182
75aedd27
TT
111832019-01-10 Tom Tromey <tom@tromey.com>
11184
11185 * xcoffread.c (scan_xcoff_symtab): Update.
11186 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11187 "where".
11188 * mdebugread.c (parse_partial_symbols)
11189 (handle_psymbol_enumerators): Update.
11190 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11191 * dbxread.c (read_dbx_symtab): Update.
11192 * psympriv.h (psymbol_placement): New enum.
11193 (add_psymbol_to_list): Update.
11194
939652a5
TT
111952019-01-10 Tom Tromey <tom@tromey.com>
11196
11197 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11198 static_psymbols parameters.
11199 (scan_xcoff_symtab): Update.
11200 * psymtab.c (start_psymtab_common): Remove global_psymbols and
11201 static_psymbols parameters.
11202 * psympriv.h (start_psymtab_common): Update.
11203 * mdebugread.c (parse_partial_symbols): Update.
11204 * dwarf2read.c (create_partial_symtab): Update.
11205 * dbxread.c (read_dbx_symtab): Update.
11206 (start_psymtab): Remove global_psymbols and static_psymbols
11207 parameters.
11208
baa62830
TT
112092019-01-10 Tom Tromey <tom@tromey.com>
11210
11211 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11212 * psymtab.c (allocate_psymtab): Add comment.
11213 * psympriv.h (allocate_psymtab): Add comment.
11214 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11215 initializations.
11216 * dbxread.c (dbx_end_psymtab): Remove some initializations.
11217
0e8f53ba
TT
112182019-01-10 Tom Tromey <tom@tromey.com>
11219
11220 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11221 Don't declare.
11222 * mipsread.c: Include mdebugread.h.
11223 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11224 Declare.
11225 * elfread.c: Include mdebugread.h.
11226
b22a7c6a
TT
112272019-01-09 Tom Tromey <tom@tromey.com>
11228
11229 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11230 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11231 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11232 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11233 (psym_lookup_symbol, psym_find_last_source_symtab)
11234 (psym_forget_cached_source_info, psym_print_stats)
11235 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11236 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11237 (psym_map_matching_symbols, psym_expand_symtabs_matching)
11238 (psym_find_compunit_symtab_by_address)
11239 (maintenance_print_psymbols, maintenance_info_psymtabs)
11240 (maintenance_check_psymtabs): Use ranged for.
11241 * psymtab.h (class objfile_psymtabs): New.
11242 (require_partial_symbols): Return objfile_psymtabs.
11243 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11244
3b9d3ac2
TT
112452019-01-09 Tom Tromey <tom@tromey.com>
11246
11247 * symfile.c (overlay_invalidate_all, find_pc_overlay)
11248 (find_pc_mapped_section, list_overlays_command)
11249 (map_overlay_command, unmap_overlay_command)
11250 (simple_overlay_update): Use all_objfiles.
11251 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11252 * printcmd.c (info_symbol_command): Use all_objfiles.
11253 * objfiles.h (ALL_OBJSECTIONS): Remove.
11254 * maint.c (maintenance_translate_address): Use all_objfiles.
11255 * gcore.c (gcore_create_callback): Use all_objfiles.
11256 (objfile_find_memory_regions): Likewise.
11257
8b31193a
TT
112582019-01-09 Tom Tromey <tom@tromey.com>
11259
11260 * symtab.c (find_line_symtab, info_sources_command)
11261 (make_source_files_completion_list): Use objfile_compunits.
11262 * source.c (select_source_symtab): Use objfile_compunits.
11263 * objfiles.h (struct objfile): Update comment.
11264 (ALL_OBJFILES): Remove.
11265 (ALL_FILETABS): Remove.
11266 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11267 objfile_compunits.
11268
d5da8b3c
TT
112692019-01-09 Tom Tromey <tom@tromey.com>
11270
11271 * symmisc.c (print_objfile_statistics, dump_objfile)
11272 (maintenance_print_symbols): Use compunit_filetabs.
11273 * source.c (forget_cached_source_info_for_objfile): Use
11274 compunit_filetabs.
11275 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11276 (ALL_FILETABS): Use compunit_filetabs.
11277 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11278 * coffread.c (coff_symtab_read): Use compunit_filetabs.
11279
5accd1a0
TT
112802019-01-09 Tom Tromey <tom@tromey.com>
11281
11282 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11283 (compunit_filetabs): New.
11284 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11285 compunit_filetabs.
11286 (info_sources_command, make_source_files_completion_list): Remove
11287 declaration.
11288 * symmisc.c (print_objfile_statistics, dump_objfile)
11289 (maintenance_print_symbols): Remove declaration.
11290 (maintenance_info_symtabs): Use compunit_filetabs.
11291 (maintenance_info_line_tables): Likewise.
11292 * source.c (select_source_symtab): Change local variable name.
11293 (forget_cached_source_info_for_objfile): Remove declaration.
11294 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11295 * objfiles.c (objfile_relocate1): Remove declaration.
11296 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11297 declaration.
11298 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11299 * coffread.c (coff_symtab_read): Remove declaration.
11300 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11301 compunit_filetabs.
11302
d8aeb77f
TT
113032019-01-09 Tom Tromey <tom@tromey.com>
11304
11305 * symtab.c (lookup_objfile_from_block)
11306 (find_pc_sect_compunit_symtab, search_symbols)
11307 (default_collect_symbol_completion_matches_break_on): Use
11308 objfile_compunits.
11309 * objfiles.h (ALL_COMPUNITS): Remove.
11310 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11311 * cp-support.c (add_symbol_overload_list_qualified): Use
11312 objfile_compunits.
11313 * ada-lang.c (ada_collect_symbol_completion_matches)
11314 (ada_add_global_exceptions): Use objfile_compunits.
11315
592553c4
TT
113162019-01-09 Tom Tromey <tom@tromey.com>
11317
11318 * source.c (select_source_symtab)
11319 (forget_cached_source_info_for_objfile): Remove declaration.
11320 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11321 declaration.
11322 * maint.c (count_symtabs_and_blocks): Remove declaration.
11323 * cp-support.c (add_symbol_overload_list_qualified): Remove
11324 declaration.
11325 * coffread.c (coff_symtab_read): Remove declaration.
11326 * symtab.c (lookup_symbol_in_objfile_symtabs)
11327 (basic_lookup_transparent_type_1): Use objfile_compunits.
11328 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11329 (info_sources_command, search_symbols)
11330 (default_collect_symbol_completion_matches_break_on)
11331 (make_source_files_completion_list): Remove declaration.
11332 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11333 (ada_collect_symbol_completion_matches)
11334 (ada_add_global_exceptions): Remove declaration.
11335 * linespec.c (iterate_over_all_matching_symtabs): Use
11336 objfile_compunits.
11337 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11338 (class objfile_compunits): New.
11339 (ALL_COMPUNITS): Use objfile_compunits.
11340 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11341 (maintenance_check_symtabs, maintenance_info_line_tables): Use
11342 objfile_compunits.
11343 * objfiles.c (objfile_relocate1): Use objfile_compunits.
11344
5325b9bf
TT
113452019-01-09 Tom Tromey <tom@tromey.com>
11346
11347 * symtab.c (search_symbols)
11348 (default_collect_symbol_completion_matches_break_on): Use
11349 objfile_msymbols.
11350 * ada-lang.c (ada_lookup_simple_minsym)
11351 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11352 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11353 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11354 objfile_msymbols.
11355 * coffread.c (coff_symfile_read): Use objfile_msymbols.
11356 * symmisc.c (dump_msymbols): Use objfile_msymbols.
11357 * objc-lang.c (find_methods): Use objfile_msymbols.
11358 (info_selectors_command, info_classes_command): Likewise.
11359 * stabsread.c (scan_file_globals): Use objfile_msymbols.
11360 * objfiles.h (class objfile_msymbols): New.
11361 (ALL_OBJFILE_MSYMBOLS): Remove.
11362 (ALL_MSYMBOLS): Remove.
11363
cac85af2
TT
113642019-01-09 Tom Tromey <tom@tromey.com>
11365
11366 * common/next-iterator.h (next_adapter): Add Iterator template
11367 parameter.
11368 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11369 (class all_objfiles_safe): New.
11370 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11371 * objfiles.c (put_objfile_before): Update comment.
11372 (add_separate_debug_objfile): Likewise.
11373 (free_all_objfiles): Use all_objfiles_safe.
11374 (objfile_purge_solibs): Likewise.
11375
aed57c53
TT
113762019-01-09 Tom Tromey <tom@tromey.com>
11377
11378 * symtab.c (iterate_over_symtabs, matching_obj_sections)
11379 (expand_symtab_containing_pc, lookup_static_symbol)
11380 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11381 (find_symbol_at_address, find_line_symtab, find_main_name): Use
11382 all_objfiles.
11383 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11384 * breakpoint.c (create_overlay_event_breakpoint)
11385 (create_longjmp_master_breakpoint)
11386 (create_std_terminate_master_breakpoint)
11387 (create_exception_master_breakpoint): Use all_objfiles.
11388 * linux-thread-db.c (try_thread_db_load_from_pdir)
11389 (has_libpthread): Use all_objfiles.
11390 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11391 * linespec.c (iterate_over_all_matching_symtabs)
11392 (search_minsyms_for_name): Use all_objfiles.
11393 * maint.c (maintenance_info_sections): Use all_objfiles.
11394 * main.c (captured_main_1): Use all_objfiles.
11395 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11396 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11397 * guile/scm-pretty-print.c
11398 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11399 * solib-spu.c (append_ocl_sos): Use all_objfiles.
11400 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11401 (maintenance_print_msymbols): Use all_objfiles.
11402 * source.c (select_source_symtab): Use all_objfiles.
11403 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11404 * symfile.c (remove_symbol_file_command)
11405 (expand_symtabs_matching, map_symbol_filenames): Use
11406 all_objfiles.
11407 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11408 all_objfiles.
11409 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11410 * objc-lang.c (find_methods): Use all_objfiles.
11411 * objfiles.c (have_partial_symbols, have_full_symbols)
11412 (have_minimal_symbols, qsort_cmp)
11413 (default_iterate_over_objfiles_in_search_order): Use
11414 all_objfiles.
11415 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11416 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11417 (maintenance_check_psymtabs): Use all_objfiles.
11418 (ALL_PSYMTABS): Remove.
11419 * compile/compile-object-run.c (do_module_cleanup): Use
11420 all_objfiles.
11421 * blockframe.c (find_pc_partial_function): Use all_objfiles.
11422 * cp-support.c (add_symbol_overload_list_qualified): Use
11423 all_objfiles.
11424 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11425 Use all_objfiles.
11426 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11427 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11428 all_objfiles.
11429 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11430 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11431 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11432 Uses all_objfiles.
11433 * solib.c (solib_read_symbols): Use all_objfiles
11434
99d89cde
TT
114352019-01-09 Tom Tromey <tom@tromey.com>
11436
11437 * probe.c (parse_probes_in_pspace): Use all_objfiles.
11438 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11439 all_objfiles.
11440 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11441 * symmisc.c (print_symbol_bcache_statistics)
11442 (print_objfile_statistics, maintenance_print_objfiles)
11443 (maintenance_info_symtabs, maintenance_check_symtabs)
11444 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11445 all_objfiles.
11446 * source.c (forget_cached_source_info): Use all_objfiles.
11447 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11448 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11449 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11450 * objfiles.c (update_section_map): Use all_objfiles.
11451 (shared_objfile_contains_address_p): Likewise.
11452 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11453 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11454
21708325
TT
114552019-01-09 Tom Tromey <tom@tromey.com>
11456
11457 * common/next-iterator.h: New file.
11458 * objfiles.h (class all_objfiles): New.
11459 (struct objfile_iterator): New.
11460
669e09f6
PW
114612019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11462
11463 * NEWS: Move the description of the changed "frame", "select-frame",
11464 and "info frame" commands to the Changed commands section.
11465
041be526
SM
114662019-01-09 Simon Marchi <simon.marchi@ericsson.com>
11467
11468 * gdbtypes.c (check_stub_method_group): Remove handling of old
11469 mangling schemes.
11470 * linespec.c (find_methods): Likewise.
11471 * stabsread.c (read_member_functions): Likewise.
11472 * valops.c (search_struct_method): Likewise.
11473 (value_struct_elt_for_reference): Likewise.
11474 * NEWS: Mention this change.
11475
0e2a2133
AB
114762019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
11477
11478 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
11479 print_source_lines.
11480 * source.c (print_source_lines_base): Update line number check.
11481 (print_source_lines): New function.
11482 (source_lines_range::source_lines_range): New function.
11483 * source.h (class source_lines_range): New class.
11484 (print_source_lines): New declaration.
11485
1055a3b4
PW
114862019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11487
11488 * linespec.c (linespec_state_destructor): Free self->canonical_names.
11489
cfeadda5
TT
114902019-01-08 Tom Tromey <tom@tromey.com>
11491 Simon Marchi <simon.marchi@ericsson.com>
11492
11493 PR gdb/24060
11494 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
11495 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
11496 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11497 * f-exp.y (DOLLAR_VARIABLE): Likewise.
11498 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
11499 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
11500
583068ca
AB
115012019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11502
11503 * source.c (select_source_symtab): Move header comment to
11504 declaration in source.h.
11505 (forget_cached_source_info_for_objfile): Likewise.
11506 (forget_cached_source_info): Likewise.
11507 (identify_source_line): Likewise.
11508 * source.h (identify_source_line): Move declaration from symtab.h
11509 and add comment from source.c
11510 (print_source_lines): Likewise.
11511 (forget_cached_source_info_for_objfile): Likewise.
11512 (forget_cached_source_info): Likewise.
11513 (select_source_symtab): Likewise.
11514 (enum print_source_lines_flag): Move definition from symtab.h.
11515 * symtab.h (identify_source_line): Move declaration to source.h.
11516 (print_source_lines): Likewise.
11517 (forget_cached_source_info_for_objfile): Likewise.
11518 (forget_cached_source_info): Likewise.
11519 (select_source_symtab): Likewise.
11520 (enum print_source_lines_flag): Move definition to source.h.
11521 * tui/tui-hooks.c: Add 'source.h' include.
11522
ec98a4ad
AB
115232019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11524
11525 * source.c (print_source_lines_base): Handle requests to print
11526 reverse line number sequences, and guard against empty lines
11527 string.
11528
62ea19c1
AB
115292019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
11530
11531 * source.c (print_source_lines_base): Fix skip of '\r' if next
11532 character is '\n'.
11533
9d30e1fd
TT
115342019-01-06 Tom Tromey <tom@tromey.com>
11535
11536 * c-exp.y (struct c_parse_state) <macro_original_text,
11537 expansion_obstack>: New member.
11538 (macro_original_text, expansion_obstack): Remove globals.
11539 (scan_macro_expansion, scanning_macro_expansion)
11540 (finished_macro_expansion): Update.
11541 (scan_macro_cleanup): Remove.
11542 (yylex, c_parse): Update.
11543
c65bac38
TT
115442019-01-06 Tom Tromey <tom@tromey.com>
11545
11546 * c-exp.y (struct c_parse_state) <strings>: New member.
11547 (operator_stoken): Update.
11548
02e12e38
TT
115492019-01-06 Tom Tromey <tom@tromey.com>
11550
11551 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
11552 (union type_stack_elt) <typelist_val>: Now a pointer to
11553 std::vector.
11554 (type_stack_cleanup): Don't declare.
11555 (push_typelist): Update.
11556 * parse.c (pop_typelist): Return a std::vector.
11557 (push_typelist): Take a std::vector.
11558 (follow_types): Update. Do not free args.
11559 (type_stack_cleanup): Remove.
11560 * c-exp.y (struct c_parse_state): New.
11561 (cpstate): New global.
11562 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
11563 (nonempty_typelist): Update.
11564 (func_mod): Create a new vector.
11565 (c_parse): Create a c_parse_state.
11566 (check_parameter_typelist): Do not delete params.
11567 (function_method): Update. Do not delete type_list.
11568
f097f5ad
TT
115692019-01-06 Tom Tromey <tom@tromey.com>
11570
11571 PR gdb/28155:
11572 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
11573 check_typedef.
11574 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
11575 (print_return_value): Likewise.
11576
d2adf9f1
TT
115772019-01-05 Tom Tromey <tom@tromey.com>
11578
11579 * contrib/cleanup_check.py: Remove.
11580 * contrib/gcc-with-excheck: Remove.
11581 * contrib/exsummary.py: Remove.
11582 * contrib/excheck.py: Remove.
11583
2eab46b1
JB
115842019-01-05 Joel Brobecker <brobecker@adacore.com>
11585
11586 * thread.c (delete_thread_1): Add gdb_assert that THR is not
11587 NULL. Initialize tpprev to NULL instead of assigning it
11588 to NULL on the next statement.
11589 * windows-nat.c (windows_delete_thread): Remove check for
11590 main_thread_id before printing thread exit notifications.
11591 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
11592 Remove thread ID check against main_thread_id.
11593 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
11594 windows_delete_thread.
11595 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
11596
48c5e7e2
TT
115972019-01-04 Tom Tromey <tom@tromey.com>
11598
11599 * compile/compile.c (_initialize_compile): Use upper case for
11600 metasyntactic variables.
11601 * symmisc.c (_initialize_symmisc): Use upper case for
11602 metasyntactic variables.
11603 * psymtab.c (_initialize_psymtab): Use upper case for
11604 metasyntactic variables.
11605 * demangle.c (demangle_command): Use upper case for metasyntactic
11606 variables.
11607 (_initialize_demangler): Likewise.
11608 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
11609 variables.
11610
986041cd
TT
116112019-01-03 Tom Tromey <tom@tromey.com>
11612
11613 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
11614
7c711119
TT
116152019-01-03 Tom Tromey <tom@tromey.com>
11616
11617 * python/py-symtab.c (salpy_str): Update.
11618 (struct salpy_sal_object) <symtab>: Now a PyObject.
11619 (salpy_dealloc): Update.
11620 (del_objfile_sal): Use gdbpy_ref.
11621
1b20edf0
TT
116222019-01-03 Tom Tromey <tom@tromey.com>
11623
11624 * python/py-type.c (convert_field): Use new_reference. Return
11625 gdbpy_ref.
11626 (make_fielditem): Return gdbpy_ref.
11627 (typy_fields): Update.
11628 (typy_getitem): Update.
11629 (field_name): Return gdbpy_ref. Use new_reference.
11630 (typy_iterator_iternext): Update.
11631
ea41325b
TT
116322019-01-03 Tom Tromey <tom@tromey.com>
11633
11634 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
11635
2a3c71d6
TT
116362019-01-03 Tom Tromey <tom@tromey.com>
11637
11638 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
11639 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
11640 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
11641 (pspy_set_frame_filters, pspy_set_frame_unwinders)
11642 (pspy_set_type_printers): Likewise.
11643 * python/py-function.c (fnpy_init): Use gdbpy_ref.
11644 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
11645 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
11646 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
11647 (objfpy_set_type_printers): Likewise.
11648
5c329e6a
TT
116492019-01-03 Tom Tromey <tom@tromey.com>
11650
11651 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
11652 (gdbpy_print_stack): Use gdbpy_err_fetch.
11653 * python/python-internal.h (class gdbpy_err_fetch): New class.
11654 (class gdbpy_enter) <m_error_type, m_error_value,
11655 m_error_traceback>: Remove.
11656 <m_error>: New member.
11657 (gdbpy_exception_to_string): Don't declare.
11658 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
11659 * python/py-value.c (convert_value_from_python): Use
11660 gdbpy_err_fetch.
11661 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
11662 gdbpy_exception_to_string.
11663 (gdbpy_handle_exception): Use gdbpy_err_fetch.
11664 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
11665 gdbpy_err_fetch.
11666
169bb27b
AB
116672019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11668
11669 * linux-nat.c (delete_lwp_cleanup): Delete.
11670 (struct lwp_deleter): New struct.
11671 (lwp_info_up): New typedef.
11672 (linux_nat_target::follow_fork): Delete cleanup, and make use of
11673 lwp_info_up.
11674
a07c8880
AB
116752019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11676
11677 * linux-fork.c (class scoped_switch_fork_info): New class.
11678 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
11679
26089c49
AB
116802019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11681
11682 * valops.c (find_overload_match): Remove use of null_cleanup, and
11683 calls to do_cleanups.
11684
06d3e5b0
AB
116852019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11686
11687 * compile/compile-cplus-types.c
11688 (compile_cplus_instance::decl_name): Handle changes to
11689 cp_func_name.
11690 * cp-support.c (cp_func_name): Update header comment, update
11691 return type.
11692 * cp-support.h (cp_func_name): Update return type in declaration.
11693 * valops.c (find_overload_match): Move temp_func local to top
11694 level of function and change its type. Use temp_func to hold and
11695 delete temporary string obtained from cp_func_name.
11696
66644cd3
AB
116972019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
11698
11699 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
11700 gdb::char_vector, remove cleanup, and update uses of `msg`.
11701
592d8c0a
JW
117022019-01-03 Jim Wilson <jimw@sifive.com>
11703
11704 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
11705
c55d06ec
TT
117062019-01-02 Tom Tromey <tom@tromey.com>
11707
11708 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
11709 (tdesc_parse_xml): Remove cleanups.
11710 * target-descriptions.h (make_cleanup_free_target_description):
11711 Don't declare.
11712 (target_desc_deleter): New struct.
11713 (target_desc_up): New typedef.
11714 * target-descriptions.c (target_desc_deleter::operator()): Rename
11715 from free_target_description.
11716 (make_cleanup_free_target_description): Remove.
11717
3a6ae42d
TT
117182019-01-02 Tom Tromey <tom@tromey.com>
11719
11720 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
11721 constructor, destructor.
11722 (linespec_parser): Remove typedef.
11723 (~linespec_parser): Rename from linespec_parser_delete.
11724 (linespec_lex_to_end, linespec_complete_label)
11725 (linespec_complete): Update.
11726 (decode_line_full): Remove cleanups.
11727 (decode_line_1): Update.
11728
61fd3e73
TT
117292019-01-02 Tom Tromey <tom@tromey.com>
11730
11731 * python/python-internal.h (inferior_to_inferior_object): Change
11732 return type.
11733 * python/py-exitedevent.c (create_exited_event_object): Update.
11734 * python/py-inferior.c (inferior_to_inferior_object): Return
11735 gdbpy_ref.
11736 (python_new_inferior, python_inferior_deleted)
11737 (thread_to_thread_object, delete_thread_object)
11738 (build_inferior_list, gdbpy_selected_inferior): Update.
11739 * python/py-infthread.c (create_thread_object): Update. Also fail
11740 if inferior_to_inferior_object fails.
11741
d20172fc
SM
117422019-01-02 Simon Marchi <simon.marchi@ericsson.com>
11743
11744 * inferior.h (class inferior) <displaced_step_state>: New field.
11745 * infrun.h (struct displaced_step_state): Move here from
11746 infrun.c. Initialize fields, add constructor.
11747 <inf>: Remove field.
11748 <reset>: New method.
11749 * infrun.c (struct displaced_step_inferior_state): Move to
11750 infrun.h.
11751 (displaced_step_inferior_states): Remove.
11752 (get_displaced_stepping_state): Adust.
11753 (displaced_step_in_progress_any_inferior): Adjust.
11754 (displaced_step_in_progress_thread): Adjust.
11755 (displaced_step_in_progress): Adjust.
11756 (add_displaced_stepping_state): Remove.
11757 (get_displaced_step_closure_by_addr): Adjust.
11758 (remove_displaced_stepping_state): Remove.
11759 (infrun_inferior_exit): Call displaced_step_state.reset.
11760 (use_displaced_stepping): Don't check for NULL.
11761 (displaced_step_prepare_throw): Call
11762 get_displaced_stepping_state.
11763 (displaced_step_fixup): Don't check for NULL.
11764 (prepare_for_detach): Don't check for NULL.
11765
e3319240
PW
117662019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11767
11768 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
11769 in case of call that did not complete.
11770
5d36dfb9
AU
117712019-01-02 Andrey Utkin <autkin@undo.io>
11772
11773 * symfile.c (find_separate_debug_file): Fix search of debug files for
11774 remote debuggee.
11775
8833fbf0
TT
117762019-01-02 Tom Tromey <tom@tromey.com>
11777
11778 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
11779 indentation.
11780 * python/py-frame.c (frapy_older): Remove cast.
11781 (frapy_newer): Likewise.
11782 * python/py-breakpoint.c (local_setattro): Remove cast.
11783 * python/py-arch.c (archpy_name): Remove local variable.
11784 * python/py-type.c (gdbpy_lookup_type): Remove cast.
11785
4ada3dfd
JB
117862019-01-02 Joel Brobecker <brobecker@adacore.com>
11787
11788 * unittests/basic_string_view/element_access/char/empty.cc:
11789 Fix year range in copyright header.
11790
113b7b81
AB
117912019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
11792
11793 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
11794 Delete.
11795 <operator==>: Update with for removed field.
11796 <hash>: Likewise.
11797 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
11798 <isa_features>: ...this.
11799 <abi_features>: New field.
11800 (riscv_isa_flen): Update comment.
11801 (riscv_abi_xlen): New declaration.
11802 (riscv_abi_flen): New declaration.
11803 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
11804 isa_features.
11805 (riscv_abi_xlen): New function.
11806 (riscv_isa_flen): Update to get answer from isa_features.
11807 (riscv_abi_flen): New function.
11808 (riscv_has_fp_abi): Update to get answer from abi_features.
11809 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
11810 xlen and flen.
11811 (riscv_call_info) <xlen, flen>: Update comment.
11812 (riscv_call_arg_struct): Remove invalid assertions
11813 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
11814 is removed.
11815 (riscv_gdbarch_init): Gather isa features and abi features
11816 separately, ensure both match on the gdbarch when reusing an old
11817 gdbarch. Relax an error check to allow 32-bit abi float to run on
11818 a target with 64-bit float hardware.
11819
b18ca514
PW
118202019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11821
11822 * source.c (search_command_helper): Stop reverse search
11823 when line 1 has been searched.
11824
ec70d8db
PW
118252019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11826
11827 * record-full.c (record_full_base_target::close): Rewrite
11828 record_full_core_buf_list free logic.
11829
5b38f9c1
PW
118302019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11831
11832 * break-catch-syscall.c (print_one_catch_syscall): xfree
11833 the last text.
11834
66d91b39
JB
118352019-01-01 Joel Brobecker <brobecker@adacore.com>
11836
11837 * top.c (print_gdb_version): Update Copyright year in version
11838 message.
11839
42a4f53d
JB
118402019-01-01 Joel Brobecker <brobecker@adacore.com>
11841
11842 Update copyright year range in all GDB files.
11843
7e955d83 118442019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 11845
5bbd631d 11846 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 11847
5bbd631d 11848For older changes see ChangeLog-2018.
c906108c
SS
11849\f
11850Local Variables:
11851mode: change-log
11852left-margin: 8
11853fill-column: 74
11854version-control: never
57da7796 11855coding: utf-8
c906108c 11856End:
5bbd631d 11857
This page took 3.190167 seconds and 4 git commands to generate.