[deliverable/linux.git] / net / bridge / br_sysfs_if.c

/*
 *	Sysfs attributes of bridge ports
 *	Linux ethernet bridge
 *
 *	Authors:
 *	Stephen Hemminger		<shemminger@osdl.org>
 *
 *	This program is free software; you can redistribute it and/or
 *	modify it under the terms of the GNU General Public License
 *	as published by the Free Software Foundation; either version
 *	2 of the License, or (at your option) any later version.
 */

#include <linux/capability.h>
#include <linux/kernel.h>
#include <linux/netdevice.h>
#include <linux/if_bridge.h>
#include <linux/rtnetlink.h>
#include <linux/spinlock.h>

#include "br_private.h"

struct brport_attribute {
	struct attribute	attr;
	ssize_t (*show)(struct net_bridge_port *, char *);
	int (*store)(struct net_bridge_port *, unsigned long);
};

#define BRPORT_ATTR(_name, _mode, _show, _store)		\
const struct brport_attribute brport_attr_##_name = { 	        \
	.attr = {.name = __stringify(_name), 			\
		 .mode = _mode },				\
	.show	= _show,					\
	.store	= _store,					\
};

#define BRPORT_ATTR_FLAG(_name, _mask)				\
static ssize_t show_##_name(struct net_bridge_port *p, char *buf) \
{								\
	return sprintf(buf, "%d\n", !!(p->flags & _mask));	\
}								\
static int store_##_name(struct net_bridge_port *p, unsigned long v) \
{								\
	return store_flag(p, v, _mask);				\
}								\
static BRPORT_ATTR(_name, S_IRUGO | S_IWUSR,			\
		   show_##_name, store_##_name)

static int store_flag(struct net_bridge_port *p, unsigned long v,
		      unsigned long mask)
{
	unsigned long flags;

	flags = p->flags;

	if (v)
		flags |= mask;
	else
		flags &= ~mask;

	if (flags != p->flags) {
		p->flags = flags;
		br_port_flags_change(p, mask);
		br_ifinfo_notify(RTM_NEWLINK, p);
	}
	return 0;
}

static ssize_t show_path_cost(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->path_cost);
}

static BRPORT_ATTR(path_cost, S_IRUGO | S_IWUSR,
		   show_path_cost, br_stp_set_path_cost);

static ssize_t show_priority(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->priority);
}

static BRPORT_ATTR(priority, S_IRUGO | S_IWUSR,
			 show_priority, br_stp_set_port_priority);

static ssize_t show_designated_root(struct net_bridge_port *p, char *buf)
{
	return br_show_bridge_id(buf, &p->designated_root);
}
static BRPORT_ATTR(designated_root, S_IRUGO, show_designated_root, NULL);

static ssize_t show_designated_bridge(struct net_bridge_port *p, char *buf)
{
	return br_show_bridge_id(buf, &p->designated_bridge);
}
static BRPORT_ATTR(designated_bridge, S_IRUGO, show_designated_bridge, NULL);

static ssize_t show_designated_port(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->designated_port);
}
static BRPORT_ATTR(designated_port, S_IRUGO, show_designated_port, NULL);

static ssize_t show_designated_cost(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->designated_cost);
}
static BRPORT_ATTR(designated_cost, S_IRUGO, show_designated_cost, NULL);

static ssize_t show_port_id(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "0x%x\n", p->port_id);
}
static BRPORT_ATTR(port_id, S_IRUGO, show_port_id, NULL);

static ssize_t show_port_no(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "0x%x\n", p->port_no);
}

static BRPORT_ATTR(port_no, S_IRUGO, show_port_no, NULL);

static ssize_t show_change_ack(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->topology_change_ack);
}
static BRPORT_ATTR(change_ack, S_IRUGO, show_change_ack, NULL);

static ssize_t show_config_pending(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->config_pending);
}
static BRPORT_ATTR(config_pending, S_IRUGO, show_config_pending, NULL);

static ssize_t show_port_state(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->state);
}
static BRPORT_ATTR(state, S_IRUGO, show_port_state, NULL);

static ssize_t show_message_age_timer(struct net_bridge_port *p,
					    char *buf)
{
	return sprintf(buf, "%ld\n", br_timer_value(&p->message_age_timer));
}
static BRPORT_ATTR(message_age_timer, S_IRUGO, show_message_age_timer, NULL);

static ssize_t show_forward_delay_timer(struct net_bridge_port *p,
					    char *buf)
{
	return sprintf(buf, "%ld\n", br_timer_value(&p->forward_delay_timer));
}
static BRPORT_ATTR(forward_delay_timer, S_IRUGO, show_forward_delay_timer, NULL);

static ssize_t show_hold_timer(struct net_bridge_port *p,
					    char *buf)
{
	return sprintf(buf, "%ld\n", br_timer_value(&p->hold_timer));
}
static BRPORT_ATTR(hold_timer, S_IRUGO, show_hold_timer, NULL);

static int store_flush(struct net_bridge_port *p, unsigned long v)
{
	br_fdb_delete_by_port(p->br, p, 0, 0); // Don't delete local entry
	return 0;
}
static BRPORT_ATTR(flush, S_IWUSR, NULL, store_flush);

BRPORT_ATTR_FLAG(hairpin_mode, BR_HAIRPIN_MODE);
BRPORT_ATTR_FLAG(bpdu_guard, BR_BPDU_GUARD);
BRPORT_ATTR_FLAG(root_block, BR_ROOT_BLOCK);
BRPORT_ATTR_FLAG(learning, BR_LEARNING);
BRPORT_ATTR_FLAG(unicast_flood, BR_FLOOD);
BRPORT_ATTR_FLAG(proxyarp, BR_PROXYARP);
BRPORT_ATTR_FLAG(proxyarp_wifi, BR_PROXYARP_WIFI);

#ifdef CONFIG_BRIDGE_IGMP_SNOOPING
static ssize_t show_multicast_router(struct net_bridge_port *p, char *buf)
{
	return sprintf(buf, "%d\n", p->multicast_router);
}

static int store_multicast_router(struct net_bridge_port *p,
				      unsigned long v)
{
	return br_multicast_set_port_router(p, v);
}
static BRPORT_ATTR(multicast_router, S_IRUGO | S_IWUSR, show_multicast_router,
		   store_multicast_router);

BRPORT_ATTR_FLAG(multicast_fast_leave, BR_MULTICAST_FAST_LEAVE);
#endif

static const struct brport_attribute *brport_attrs[] = {
	&brport_attr_path_cost,
	&brport_attr_priority,
	&brport_attr_port_id,
	&brport_attr_port_no,
	&brport_attr_designated_root,
	&brport_attr_designated_bridge,
	&brport_attr_designated_port,
	&brport_attr_designated_cost,
	&brport_attr_state,
	&brport_attr_change_ack,
	&brport_attr_config_pending,
	&brport_attr_message_age_timer,
	&brport_attr_forward_delay_timer,
	&brport_attr_hold_timer,
	&brport_attr_flush,
	&brport_attr_hairpin_mode,
	&brport_attr_bpdu_guard,
	&brport_attr_root_block,
	&brport_attr_learning,
	&brport_attr_unicast_flood,
#ifdef CONFIG_BRIDGE_IGMP_SNOOPING
	&brport_attr_multicast_router,
	&brport_attr_multicast_fast_leave,
#endif
	&brport_attr_proxyarp,
	&brport_attr_proxyarp_wifi,
	NULL
};

#define to_brport_attr(_at) container_of(_at, struct brport_attribute, attr)
#define to_brport(obj)	container_of(obj, struct net_bridge_port, kobj)

static ssize_t brport_show(struct kobject *kobj,
			   struct attribute *attr, char *buf)
{
	struct brport_attribute *brport_attr = to_brport_attr(attr);
	struct net_bridge_port *p = to_brport(kobj);

	return brport_attr->show(p, buf);
}

static ssize_t brport_store(struct kobject *kobj,
			    struct attribute *attr,
			    const char *buf, size_t count)
{
	struct brport_attribute *brport_attr = to_brport_attr(attr);
	struct net_bridge_port *p = to_brport(kobj);
	ssize_t ret = -EINVAL;
	char *endp;
	unsigned long val;

	if (!ns_capable(dev_net(p->dev)->user_ns, CAP_NET_ADMIN))
		return -EPERM;

	val = simple_strtoul(buf, &endp, 0);
	if (endp != buf) {
		if (!rtnl_trylock())
			return restart_syscall();
		if (p->dev && p->br && brport_attr->store) {
			spin_lock_bh(&p->br->lock);
			ret = brport_attr->store(p, val);
			spin_unlock_bh(&p->br->lock);
			if (ret == 0)
				ret = count;
		}
		rtnl_unlock();
	}
	return ret;
}

const struct sysfs_ops brport_sysfs_ops = {
	.show = brport_show,
	.store = brport_store,
};

/*
 * Add sysfs entries to ethernet device added to a bridge.
 * Creates a brport subdirectory with bridge attributes.
 * Puts symlink in bridge's brif subdirectory
 */
int br_sysfs_addif(struct net_bridge_port *p)
{
	struct net_bridge *br = p->br;
	const struct brport_attribute **a;
	int err;

	err = sysfs_create_link(&p->kobj, &br->dev->dev.kobj,
				SYSFS_BRIDGE_PORT_LINK);
	if (err)
		return err;

	for (a = brport_attrs; *a; ++a) {
		err = sysfs_create_file(&p->kobj, &((*a)->attr));
		if (err)
			return err;
	}

	strlcpy(p->sysfs_name, p->dev->name, IFNAMSIZ);
	return sysfs_create_link(br->ifobj, &p->kobj, p->sysfs_name);
}

/* Rename bridge's brif symlink */
int br_sysfs_renameif(struct net_bridge_port *p)
{
	struct net_bridge *br = p->br;
	int err;

	/* If a rename fails, the rollback will cause another
	 * rename call with the existing name.
	 */
	if (!strncmp(p->sysfs_name, p->dev->name, IFNAMSIZ))
		return 0;

	err = sysfs_rename_link(br->ifobj, &p->kobj,
				p->sysfs_name, p->dev->name);
	if (err)
		netdev_notice(br->dev, "unable to rename link %s to %s",
			      p->sysfs_name, p->dev->name);
	else
		strlcpy(p->sysfs_name, p->dev->name, IFNAMSIZ);

	return err;
}
Commit	Line	Data
1da177e4 LT	1	/*
	2	* Sysfs attributes of bridge ports
	3	* Linux ethernet bridge
	4	*
	5	* Authors:
	6	* Stephen Hemminger <shemminger@osdl.org>
	7	*
	8	* This program is free software; you can redistribute it and/or
	9	* modify it under the terms of the GNU General Public License
	10	* as published by the Free Software Foundation; either version
	11	* 2 of the License, or (at your option) any later version.
	12	*/
	13
4fc268d2	14	#include <linux/capability.h>
1da177e4 LT	15	#include <linux/kernel.h>
	16	#include <linux/netdevice.h>
	17	#include <linux/if_bridge.h>
	18	#include <linux/rtnetlink.h>
	19	#include <linux/spinlock.h>
	20
	21	#include "br_private.h"
	22
	23	struct brport_attribute {
	24	struct attribute attr;
	25	ssize_t (show)(struct net_bridge_port , char *);
14f98f25	26	int (store)(struct net_bridge_port , unsigned long);
1da177e4 LT	27	};
1da177e4 LT	28
31a5b837	29	#define BRPORT_ATTR(_name, _mode, _show, _store) \
5a0d513b	30	const struct brport_attribute brport_attr_##_name = { \
1da177e4	31	.attr = {.name = __stringify(_name), \
7b595756	32	.mode = _mode }, \
1da177e4 LT	33	.show = _show, \
	34	.store = _store, \
	35	};
	36
cd753732	37	#define BRPORT_ATTR_FLAG(_name, _mask) \
	38	static ssize_t show_##_name(struct net_bridge_port p, char buf) \
	39	{ \
	40	return sprintf(buf, "%d\n", !!(p->flags & _mask)); \
	41	} \
	42	static int store_##_name(struct net_bridge_port *p, unsigned long v) \
	43	{ \
63c3a622	44	return store_flag(p, v, _mask); \
cd753732	45	} \
	46	static BRPORT_ATTR(_name, S_IRUGO \| S_IWUSR, \
	47	show_##_name, store_##_name)
	48
63c3a622 VY	49	static int store_flag(struct net_bridge_port *p, unsigned long v,
	50	unsigned long mask)
	51	{
e028e4b8 VY	52	unsigned long flags;
	53
	54	flags = p->flags;
63c3a622 VY	55
	56	if (v)
	57	flags \|= mask;
	58	else
	59	flags &= ~mask;
	60
	61	if (flags != p->flags) {
	62	p->flags = flags;
e028e4b8	63	br_port_flags_change(p, mask);
63c3a622 VY	64	br_ifinfo_notify(RTM_NEWLINK, p);
	65	}
	66	return 0;
	67	}
cd753732	68
1da177e4 LT	69	static ssize_t show_path_cost(struct net_bridge_port p, char buf)
	70	{
	71	return sprintf(buf, "%d\n", p->path_cost);
	72	}
14f98f25	73
1da177e4	74	static BRPORT_ATTR(path_cost, S_IRUGO \| S_IWUSR,
14f98f25	75	show_path_cost, br_stp_set_path_cost);
1da177e4 LT	76
	77	static ssize_t show_priority(struct net_bridge_port p, char buf)
	78	{
	79	return sprintf(buf, "%d\n", p->priority);
	80	}
14f98f25	81
1da177e4	82	static BRPORT_ATTR(priority, S_IRUGO \| S_IWUSR,
14f98f25	83	show_priority, br_stp_set_port_priority);
1da177e4 LT	84
	85	static ssize_t show_designated_root(struct net_bridge_port p, char buf)
	86	{
	87	return br_show_bridge_id(buf, &p->designated_root);
	88	}
	89	static BRPORT_ATTR(designated_root, S_IRUGO, show_designated_root, NULL);
	90
	91	static ssize_t show_designated_bridge(struct net_bridge_port p, char buf)
	92	{
	93	return br_show_bridge_id(buf, &p->designated_bridge);
	94	}
	95	static BRPORT_ATTR(designated_bridge, S_IRUGO, show_designated_bridge, NULL);
	96
	97	static ssize_t show_designated_port(struct net_bridge_port p, char buf)
	98	{
	99	return sprintf(buf, "%d\n", p->designated_port);
	100	}
	101	static BRPORT_ATTR(designated_port, S_IRUGO, show_designated_port, NULL);
	102
	103	static ssize_t show_designated_cost(struct net_bridge_port p, char buf)
	104	{
	105	return sprintf(buf, "%d\n", p->designated_cost);
	106	}
	107	static BRPORT_ATTR(designated_cost, S_IRUGO, show_designated_cost, NULL);
	108
	109	static ssize_t show_port_id(struct net_bridge_port p, char buf)
	110	{
	111	return sprintf(buf, "0x%x\n", p->port_id);
	112	}
	113	static BRPORT_ATTR(port_id, S_IRUGO, show_port_id, NULL);
	114
	115	static ssize_t show_port_no(struct net_bridge_port p, char buf)
	116	{
	117	return sprintf(buf, "0x%x\n", p->port_no);
	118	}
	119
	120	static BRPORT_ATTR(port_no, S_IRUGO, show_port_no, NULL);
	121
	122	static ssize_t show_change_ack(struct net_bridge_port p, char buf)
	123	{
	124	return sprintf(buf, "%d\n", p->topology_change_ack);
	125	}
	126	static BRPORT_ATTR(change_ack, S_IRUGO, show_change_ack, NULL);
	127
	128	static ssize_t show_config_pending(struct net_bridge_port p, char buf)
	129	{
	130	return sprintf(buf, "%d\n", p->config_pending);
	131	}
	132	static BRPORT_ATTR(config_pending, S_IRUGO, show_config_pending, NULL);
	133
	134	static ssize_t show_port_state(struct net_bridge_port p, char buf)
	135	{
	136	return sprintf(buf, "%d\n", p->state);
	137	}
	138	static BRPORT_ATTR(state, S_IRUGO, show_port_state, NULL);
	139
	140	static ssize_t show_message_age_timer(struct net_bridge_port *p,
	141	char *buf)
	142	{
	143	return sprintf(buf, "%ld\n", br_timer_value(&p->message_age_timer));
	144	}
	145	static BRPORT_ATTR(message_age_timer, S_IRUGO, show_message_age_timer, NULL);
	146
	147	static ssize_t show_forward_delay_timer(struct net_bridge_port *p,
148	char *buf)
149	{
150	return sprintf(buf, "%ld\n", br_timer_value(&p->forward_delay_timer));
151	}
152	static BRPORT_ATTR(forward_delay_timer, S_IRUGO, show_forward_delay_timer, NULL);
153
154	static ssize_t show_hold_timer(struct net_bridge_port *p,
155	char *buf)
156	{
157	return sprintf(buf, "%ld\n", br_timer_value(&p->hold_timer));
158	}
159	static BRPORT_ATTR(hold_timer, S_IRUGO, show_hold_timer, NULL);
160
14f98f25	161	static int store_flush(struct net_bridge_port *p, unsigned long v)
9cf63747	162	{
1ea2d020	163	br_fdb_delete_by_port(p->br, p, 0, 0); // Don't delete local entry
9cf63747 SH	164	return 0;
	165	}
	166	static BRPORT_ATTR(flush, S_IWUSR, NULL, store_flush);
	167
cd753732	168	BRPORT_ATTR_FLAG(hairpin_mode, BR_HAIRPIN_MODE);
a2e01a65	169	BRPORT_ATTR_FLAG(bpdu_guard, BR_BPDU_GUARD);
1007dd1a	170	BRPORT_ATTR_FLAG(root_block, BR_ROOT_BLOCK);
9ba18891	171	BRPORT_ATTR_FLAG(learning, BR_LEARNING);
867a5943	172	BRPORT_ATTR_FLAG(unicast_flood, BR_FLOOD);
95850116	173	BRPORT_ATTR_FLAG(proxyarp, BR_PROXYARP);
842a9ae0	174	BRPORT_ATTR_FLAG(proxyarp_wifi, BR_PROXYARP_WIFI);
3982d3d2	175
0909e117 HX	176	#ifdef CONFIG_BRIDGE_IGMP_SNOOPING
	177	static ssize_t show_multicast_router(struct net_bridge_port p, char buf)
	178	{
	179	return sprintf(buf, "%d\n", p->multicast_router);
	180	}
	181
14f98f25	182	static int store_multicast_router(struct net_bridge_port *p,
0909e117 HX	183	unsigned long v)
	184	{
	185	return br_multicast_set_port_router(p, v);
	186	}
	187	static BRPORT_ATTR(multicast_router, S_IRUGO \| S_IWUSR, show_multicast_router,
	188	store_multicast_router);
50426b59	189
c2d3babf	190	BRPORT_ATTR_FLAG(multicast_fast_leave, BR_MULTICAST_FAST_LEAVE);
0909e117 HX	191	#endif
0909e117 HX	192
5a0d513b	193	static const struct brport_attribute *brport_attrs[] = {
1da177e4 LT	194	&brport_attr_path_cost,
	195	&brport_attr_priority,
	196	&brport_attr_port_id,
	197	&brport_attr_port_no,
	198	&brport_attr_designated_root,
	199	&brport_attr_designated_bridge,
	200	&brport_attr_designated_port,
	201	&brport_attr_designated_cost,
	202	&brport_attr_state,
	203	&brport_attr_change_ack,
	204	&brport_attr_config_pending,
	205	&brport_attr_message_age_timer,
	206	&brport_attr_forward_delay_timer,
	207	&brport_attr_hold_timer,
9cf63747	208	&brport_attr_flush,
3982d3d2	209	&brport_attr_hairpin_mode,
a2e01a65	210	&brport_attr_bpdu_guard,
1007dd1a	211	&brport_attr_root_block,
9ba18891	212	&brport_attr_learning,
867a5943	213	&brport_attr_unicast_flood,
0909e117 HX	214	#ifdef CONFIG_BRIDGE_IGMP_SNOOPING
0909e117 HX	215	&brport_attr_multicast_router,
50426b59	216	&brport_attr_multicast_fast_leave,
0909e117	217	#endif
95850116	218	&brport_attr_proxyarp,
842a9ae0	219	&brport_attr_proxyarp_wifi,
1da177e4 LT	220	NULL
	221	};
	222
	223	#define to_brport_attr(_at) container_of(_at, struct brport_attribute, attr)
	224	#define to_brport(obj) container_of(obj, struct net_bridge_port, kobj)
	225
56b148eb	226	static ssize_t brport_show(struct kobject *kobj,
56b148eb	227	struct attribute attr, char buf)
1da177e4	228	{
56b148eb	229	struct brport_attribute *brport_attr = to_brport_attr(attr);
56b148eb	230	struct net_bridge_port *p = to_brport(kobj);
1da177e4 LT	231
	232	return brport_attr->show(p, buf);
	233	}
	234
56b148eb	235	static ssize_t brport_store(struct kobject *kobj,
	236	struct attribute *attr,
	237	const char *buf, size_t count)
1da177e4	238	{
56b148eb	239	struct brport_attribute *brport_attr = to_brport_attr(attr);
56b148eb	240	struct net_bridge_port *p = to_brport(kobj);
1da177e4 LT	241	ssize_t ret = -EINVAL;
	242	char *endp;
	243	unsigned long val;
	244
cb990503	245	if (!ns_capable(dev_net(p->dev)->user_ns, CAP_NET_ADMIN))
1da177e4 LT	246	return -EPERM;
	247
	248	val = simple_strtoul(buf, &endp, 0);
	249	if (endp != buf) {
af38f298 EB	250	if (!rtnl_trylock())
af38f298 EB	251	return restart_syscall();
1da177e4 LT	252	if (p->dev && p->br && brport_attr->store) {
	253	spin_lock_bh(&p->br->lock);
	254	ret = brport_attr->store(p, val);
	255	spin_unlock_bh(&p->br->lock);
	256	if (ret == 0)
	257	ret = count;
	258	}
	259	rtnl_unlock();
	260	}
	261	return ret;
	262	}
	263
52cf25d0	264	const struct sysfs_ops brport_sysfs_ops = {
1da177e4 LT	265	.show = brport_show,
	266	.store = brport_store,
	267	};
	268
1da177e4 LT	269	/*
	270	* Add sysfs entries to ethernet device added to a bridge.
	271	* Creates a brport subdirectory with bridge attributes.
e0f43752	272	* Puts symlink in bridge's brif subdirectory
1da177e4 LT	273	*/
	274	int br_sysfs_addif(struct net_bridge_port *p)
	275	{
	276	struct net_bridge *br = p->br;
5a0d513b	277	const struct brport_attribute **a;
1da177e4 LT	278	int err;
1da177e4 LT	279
43cb76d9	280	err = sysfs_create_link(&p->kobj, &br->dev->dev.kobj,
1da177e4 LT	281	SYSFS_BRIDGE_PORT_LINK);
1da177e4 LT	282	if (err)
e0f43752	283	return err;
1da177e4 LT	284
	285	for (a = brport_attrs; *a; ++a) {
	286	err = sysfs_create_file(&p->kobj, &((*a)->attr));
	287	if (err)
e0f43752	288	return err;
1da177e4 LT	289	}
1da177e4 LT	290
e0f43752 SA	291	strlcpy(p->sysfs_name, p->dev->name, IFNAMSIZ);
	292	return sysfs_create_link(br->ifobj, &p->kobj, p->sysfs_name);
	293	}
	294
	295	/* Rename bridge's brif symlink */
	296	int br_sysfs_renameif(struct net_bridge_port *p)
	297	{
	298	struct net_bridge *br = p->br;
	299	int err;
	300
	301	/* If a rename fails, the rollback will cause another
	302	* rename call with the existing name.
	303	*/
	304	if (!strncmp(p->sysfs_name, p->dev->name, IFNAMSIZ))
	305	return 0;
	306
	307	err = sysfs_rename_link(br->ifobj, &p->kobj,
	308	p->sysfs_name, p->dev->name);
	309	if (err)
	310	netdev_notice(br->dev, "unable to rename link %s to %s",
	311	p->sysfs_name, p->dev->name);
	312	else
	313	strlcpy(p->sysfs_name, p->dev->name, IFNAMSIZ);
	314
1da177e4 LT	315	return err;
1da177e4 LT	316	}