don't crash when provided empty symbol table
[deliverable/binutils-gdb.git] / standards.texi
CommitLineData
b42b3782
RP
1\input texinfo @c -*-texinfo-*-
2@c %**start of header
3@setfilename standards.text
4@settitle GNU Coding Standards
5@c %**end of header
6
7@setchapternewpage off
8
9@ifinfo
10Copyright (C) 1992 Free Software Foundation
11Permission is granted to make and distribute verbatim copies of
12this manual provided the copyright notice and this permission notice
13are preserved on all copies.
14
15@ignore
16Permission is granted to process this file through TeX and print the
17results, provided the printed document carries copying permission
18notice identical to this one except for the removal of this paragraph
19(this paragraph not being relevant to the printed manual).
20@end ignore
21
22Permission is granted to copy and distribute modified versions of this
23manual under the conditions for verbatim copying, provided that the entire
24resulting derived work is distributed under the terms of a permission
25notice identical to this one.
26
27Permission is granted to copy and distribute translations of this manual
28into another language, under the above conditions for modified versions,
29except that this permission notice may be stated in a translation approved
30by the Free Software Foundation.
31@end ifinfo
32
33@titlepage
34@sp 10
35@titlefont{GNU Coding Standards}
36@author{Richard Stallman}
9dec5417 37@author{last updated 16 May 1992}
b42b3782
RP
38@c Note date also appears below.
39@page
40
41@vskip 0pt plus 1filll
42Copyright @copyright{} 1992 Free Software Foundation
43
44Permission is granted to make and distribute verbatim copies of
45this manual provided the copyright notice and this permission notice
46are preserved on all copies.
47
48Permission is granted to copy and distribute modified versions of this
49manual under the conditions for verbatim copying, provided that the entire
50resulting derived work is distributed under the terms of a permission
51notice identical to this one.
52
53Permission is granted to copy and distribute translations of this manual
54into another language, under the above conditions for modified versions,
55except that this permission notice may be stated in a translation approved
56by Free Software Foundation.
57@end titlepage
58
59@ifinfo
60@node Top, Reading Non-Free Code, (dir), (dir)
61@top Version
62
9dec5417 63Last updated 16 May 1992.
b42b3782
RP
64@c Note date also appears above.
65@end ifinfo
66
67@menu
68* Reading Non-Free Code:: Referring to Proprietary Programs
69* Contributions:: Accepting Contributions
70* Change Logs:: Recording Changes
71* Compatibility:: Compatibility with Other Implementations
72* Makefiles:: Makefile Conventions
73* Configuration:: How Configuration Should Work
74* Source Language:: Using Languages Other Than C
75* Formatting:: Formatting Your Source Code
76* Comments:: Commenting Your Work
77* Syntactic Conventions:: Clean Use of C Constructs
78* Names:: Naming Variables and Functions
79* Using Extensions:: Using Non-standard Features
80* Semantics:: Program Behaviour for All Programs
81* Errors:: Formatting Error Messages
82* Libraries:: Library Behaviour
83* Portability:: Portability As It Applies to GNU
84* User Interfaces:: Standards for Command Line Interfaces
85* Documentation:: Documenting Programs
86* Releases:: Making Releases
87@end menu
88
89@node Reading Non-Free Code
90@chapter Referring to Proprietary Programs
91
92Don't in any circumstances refer to Unix source code for or during
93your work on GNU! (Or to any other proprietary programs.)
94
95If you have a vague recollection of the internals of a Unix program,
96this does not absolutely mean you can't write an imitation of it, but
97do try to organize the imitation internally along different lines,
98because this is likely to make the details of the Unix version
99irrelevant and dissimilar to your results.
100
101For example, Unix utilities were generally optimized to minimize
102memory use; if you go for speed instead, your program will be very
103different. You could keep the entire input file in core and scan it
104there instead of using stdio. Use a smarter algorithm discovered more
105recently than the Unix program. Eliminate use of temporary files. Do
106it in one pass instead of two (we did this in the assembler).
107
108Or, on the contrary, emphasize simplicity instead of speed. For some
109applications, the speed of today's computers makes simpler algorithms
110adequate.
111
112Or go for generality. For example, Unix programs often have static
113tables or fixed-size strings, which make for arbitrary limits; use
114dynamic allocation instead. Make sure your program handles NULs and
115other funny characters in the input files. Add a programming language
116for extensibility and write part of the program in that language.
117
118Or turn some parts of the program into independently usable libraries.
119Or use a simple garbage collector instead of tracking precisely when
120to free memory, or use a new GNU facility such as obstacks.
121
122
123@node Contributions
124@chapter Accepting Contributions
125
126If someone else sends you a piece of code to add to the program you are
127working on, we need legal papers to use it---the same sort of legal
128papers we will need to get from you. @emph{Each} significant
129contributor to a program must sign some sort of legal papers in order
130for us to have clear title to the program. The main author alone is not
131enough.
132
133So, before adding in any contributions from other people, tell us
134so we can arrange to get the papers. Then wait until we tell you
135that we have received the signed papers, before you actually use the
136contribution.
137
138This applies both before you release the program and afterward. If
139you receive diffs to fix a bug, and they make significant change, we
140need legal papers for it.
141
142You don't need papers for changes of a few lines here or there, since
143they are not significant for copyright purposes. Also, you don't need
144papers if all you get from the suggestion is some ideas, not actual code
145which you use. For example, if you write a different solution to the
146problem, you don't need to get papers.
147
148I know this is frustrating; it's frustrating for us as well. But if
149you don't wait, you are going out on a limb---for example, what if the
150contributor's employer won't sign a disclaimer? You might have to take
151that code out again!
152
153The very worst thing is if you forget to tell us about the other
154contributor. We could be very embarrassed in court some day as a
155result.
156
157@node Change Logs
158@chapter Change Logs
159
160Keep a change log for each directory, describing the changes made to
161source files in that directory. The purpose of this is so that people
162investigating bugs in the future will know about the changes that
163might have introduced the bug. Often a new bug can be found by
164looking at what was recently changed. More importantly, change logs
165can help eliminate conceptual inconsistencies between different parts
166of a program; they can give you a history of how the conflicting
167concepts arose.
168
169Use the Emacs command @kbd{M-x add-change} to start a new entry in the
170change log. An entry should have an asterisk, the name of the changed
171file, and then in parentheses the name of the changed functions,
172variables or whatever, followed by a colon. Then describe the changes
173you made to that function or variable.
174
175Separate unrelated entries with blank lines. When two entries
176represent parts of the same change, so that they work together, then
177don't put blank lines between them. Then you can omit the file name
178and the asterisk when successive entries are in the same file.
179
180Here are some examples:
181
182@example
183* register.el (insert-register): Return nil.
184(jump-to-register): Likewise.
185
186* sort.el (sort-subr): Return nil.
187
188* tex-mode.el (tex-bibtex-file, tex-file, tex-region):
189Restart the tex shell if process is gone or stopped.
190(tex-shell-running): New function.
191
192* expr.c (store_one_arg): Round size up for move_block_to_reg.
193(expand_call): Round up when emitting USE insns.
194* stmt.c (assign_parms): Round size up for move_block_from_reg.
195@end example
196
197There's no need to describe here the full purpose of the changes or how
198they work together. It is better to put this explanation in comments in
199the code. That's why just ``New function'' is enough; there is a
200comment with the function in the source to explain what it does.
201
202However, sometimes it is useful to write one line to describe the
203overall purpose of a large batch of changes.
204
205When you change the calling sequence of a function in a simple
206fashion, and you change all the callers of the function, there is no
207need to make individual entries for all the callers. Just write in
208the entry for the function being called, ``All callers changed.''
209
210When you change just comments or doc strings, it is enough to write an
211entry for the file, without mentioning the functions. Write just,
212``Doc fix.'' There's no need to keep a change log for documentation
213files. This is because documentation is not susceptible to bugs that
214are hard to fix. Documentation does not consist of parts that must
215interact in a precisely engineered fashion; to correct an error, you
216need not know the history of the erroneous passage.
217
218
219@node Compatibility
220@chapter Compatibility with Other Implementations
221
222With certain exceptions, utility programs and libraries for GNU should
223be upward compatible with those in Berkeley Unix, and upward compatible
224with @sc{ANSI} C if @sc{ANSI} C specifies their behavior, and upward
225compatible with @sc{POSIX} if @sc{POSIX} specifies their behavior.
226
227When these standards conflict, it is useful to offer compatibility
228modes for each of them.
229
230@sc{ANSI} C and @sc{POSIX} prohibit many kinds of extensions. Feel
231free to make the extensions anyway, and include a @samp{--ansi} or
232@samp{--compatible} option to turn them off. However, if the extension
233has a significant chance of breaking any real programs or scripts,
234then it is not really upward compatible. Try to redesign its
235interface.
236
237When a feature is used only by users (not by programs or command
238files), and it is done poorly in Unix, feel free to replace it
239completely with something totally different and better. (For example,
240vi is replaced with Emacs.) But it is nice to offer a compatible
241feature as well. (There is a free vi clone, so we offer it.)
242
243Additional useful features not in Berkeley Unix are welcome.
244Additional programs with no counterpart in Unix may be useful,
245but our first priority is usually to duplicate what Unix already
246has.
247
248
249@node Makefiles
250@chapter Makefile Conventions
251
252This chapter describes conventions for writing Makefiles.
253
254@menu
255* Makefile Basics::
256* Standard Targets::
257* Command Variables::
258* Directory Variables::
259@end menu
260
261@node Makefile Basics
262@section General Conventions for Makefiles
263
264Every Makefile should contain this line:
265
266@example
267SHELL = /bin/sh
268@end example
269
270@noindent
271to avoid trouble on systems where the @code{SHELL} variable might be
272inherited from the environment.
273
274Don't assume that @file{.} is in the path for command execution. When
275you need to run programs that are files in the current directory, always
276use @file{./} to make sure the proper file is run regardless of the
277current path.
278
279@node Standard Targets
280@section Standard Targets for Users
281
282All GNU programs should have the following targets in their Makefiles:
283
284@table @samp
285@item all
286Compile the entire program.
287
288@item install
289Compile the program and copy the executables, libraries, and so on to
290the file names where they should reside for actual use. If there is a
291simple test to verify that a program is properly installed then run that
292test.
293
9dec5417
DZ
294Use @samp{-} before any command for installing a man page, so that
295@code{make} will ignore any errors. This is in case there are systems
296that don't have the Unix man page documentation system installed.
297
b42b3782
RP
298@item clean
299Delete all files from the current directory that are normally created by
300building the program. Don't delete the files that record the
301configuration. Also preserve files that could be made by building, but
302normally aren't because the distribution comes with them.
303
9dec5417
DZ
304Delete @file{.dvi} files here if they are not part of the distribution.
305
b42b3782
RP
306@item distclean
307Delete all files from the current directory that are created by
85e44e95
RP
308configuring or building the program. If you have unpacked the source
309and built the program without creating any other files, @samp{make
310distclean} should leave only the files that were in the distribution.
b42b3782
RP
311
312@item mostlyclean
313Like @samp{clean}, but may refrain from deleting a few files that people
314normally don't want to recompile. For example, the @samp{mostlyclean}
315target for GCC does not delete @file{libgcc.a}, because recompiling it
316is rarely necessary and takes a lot of time.
317
318@item realclean
319Delete everything from the current directory that can be reconstructed
320with this Makefile. This typically includes everything deleted by
321distclean, plus more: C source files produced by Bison, tags tables,
322info files, and so on.
323
324@item TAGS
325Update a tags table for this program.
326
327@item dist
328Create a distribution tar file for this program. The tar file should be
329set up so that the file names in the tar file start with a subdirectory
330name which is the name of the package it is a distribution for. This
331name can include the version number.
332
333For example, the distribution tar file of GCC version 1.40 unpacks into
334a subdirectory named @file{gcc-1.40}.
335
336The easiest way to do this is to create a subdirectory appropriately
337named, use @code{ln} or @code{cp} to install the proper files in it, and
338then @code{tar} that subdirectory.
339
340The @code{dist} target should explicitly depend on all non-source files
341that are in the distribution, to make sure they are up to date in the
342distribution. @xref{Releases}.
343
344@item check
345Perform self-tests (if any). The user must build the program before
346running the tests, but need not install the program; you should write
347the self-tests so that they work when the program is built but not
348installed.
349@end table
350
351@node Command Variables
352@section Variables for Specifying Commands
353
354Makefiles should provide variables for overriding certain commands, options,
355and so on.
356
357In particular, you should run most utility programs via variables.
358Thus, if you use Bison, have a variable named @code{BISON} whose default
359value is set with @samp{BISON = bison}, and refer to it with
360@code{$(BISON)} whenever you need to use Bison.
361
362Each program-name variable should come with an options variable that is
363used to supply options to the program. Append @samp{FLAGS} to the
364program-name variable name to get the options variable name---for
365example, @code{BISONFLAGS}. (The name @code{CFLAGS} is an exception to
366this rule, but we keep it because it is standard.)
367
368File-management utilities such as @code{ln}, @code{rm}, @code{mv}, and
369so on need not be referred to through variables in this way, since users
370don't need to replace them with other programs.
371
372Every Makefile should define the variable @code{INSTALL}, which is the
373basic command for installing a file into the system.
374
375Every Makefile should also define variables @code{INSTALL_PROGRAM} and
376@code{INSTALL_DATA}. (The default for each of these should be
377@code{$(INSTALL)}.) Then it should use those variables as the commands
378for actual installation, for executables and nonexecutables
379respectively. Use these variables as follows:
380
381@example
382$(INSTALL_PROGRAM) foo $@{bindir@}/foo
383$(INSTALL_DATA) libfoo.a $@{libdir@}/libfoo.a
384@end example
385
386@noindent
387(Always use a file name, not a directory name, as the second argument.
388Use a separate command for each file to be installed.)
389
390@node Directory Variables
391@section Variables for Installation Directories
392
393Installation directories should always be named by variables, so it is
394easy to install in a nonstandard place. The standard names for these
395variables are:
396
397@table @samp
a60ff512
RP
398@item prefix
399A prefix used in constructing the default values of the variables listed
400below. The default value of @code{prefix} should be @file{/usr/local}
401(at least for now).
402
403@item exec_prefix
404A prefix used in constructing the default values of the some of the
405variables listed below. The default value of @code{exec_prefix} should
406be @code{$(prefix)}.
407
408Generally, @code{$(exec_prefix)} is used for directories that contain
409machine-specific files (such as executables and subroutine libraries),
410while @code{$(prefix)} is used directly for other directories.
411
b42b3782
RP
412@item bindir
413The directory for installing executable programs that users can run.
a60ff512
RP
414This should normally be @file{/usr/local/bin}, but it should be written
415as @file{$(exec_prefix)/bin}.
416
417@item libdir
418The directory for installing executable files to be run by the program
419rather than by users. Object files and libraries of object code should
420also go in this directory. The idea is that this directory is used for
421files that pertain to a specific machine architecture, but need not be
422in the path for commands. The value of @code{libdir} should normally be
423@file{/usr/local/lib}, but it should be written as
424@file{$(exec_prefix)/lib}.
b42b3782
RP
425
426@item datadir
427The directory for installing read-only data files which the programs
428refer to while they run. This directory is used for files which are
429independent of the type of machine being used. This should normally be
a60ff512
RP
430@file{/usr/local/lib}, but it should be written as
431@file{$(prefix)/lib}.
b42b3782
RP
432
433@item statedir
434The directory for installing data files which the programs modify while
435they run. These files should be independent of the type of machine
436being used, and it should be possible to share them among machines at a
437network installation. This should normally be @file{/usr/local/lib},
a60ff512 438but it should be written as @file{$(prefix)/lib}.
b42b3782
RP
439
440@item includedir
441The directory for installing @samp{#include} header files to be included
442by user programs. This should normally be @file{/usr/local/include},
a60ff512 443but it should be written as @file{$(prefix)/include}.
b42b3782
RP
444
445Most compilers other than GCC do not look for header files in
446@file{/usr/local/include}. So installing the header files this way is
447only useful with GCC. Sometimes this is not a problem because some
448libraries are only really intended to work with GCC. But some libraries
449are intended to work with other compilers. They should install their
450header files in two places, one specified by includedir and one
451specified by oldincludedir
452
453@item oldincludedir
454The directory for installing @samp{#include} header files for use with
455compilers other than GCC. This should normally be @file{/usr/include}.
456
457The Makefile commands should check whether the value of
458@code{oldincludedir} is empty. If it is, they should not try to use
459it; they should cancel the second installation of the header files.
460
461@item mandir
462The directory for installing the man pages (if any) for this package.
463It should include the suffix for the proper section of the
464manual---usually @samp{1} for a utility.
465
466@item man1dir
467The directory for installing section 1 man pages.
468@item man2dir
469The directory for installing section 2 man pages.
470@item @dots{}
471Use these names instead of @samp{mandir} if the package needs to install man
472pages in more than one section of the manual.
473
474@strong{Don't make the primary documentation for any GNU software be a
475man page. Write a manual in Texinfo instead. Man pages are just for
476the sake of people running GNU software on Unix, which is a secondary
477application only.}
478
479@item manext
480The file name extension for the installed man page. This should contain
481a period followed by the appropriate digit.
482
483@item infodir
484The directory for installing the info files for this package. By
a60ff512
RP
485default, it should be @file{/usr/local/info}, but it should be written
486as @file{$(prefix)/info}.
b42b3782
RP
487
488@item srcdir
489The directory for the sources being compiled. The value of this
490variable is normally inserted by the @code{configure} shell script.
b42b3782
RP
491@end table
492
493For example:
494
495@example
496# Common prefix for installation directories.
497# NOTE: This directory must exist when you start installation.
498prefix = /usr/local
a60ff512 499exec_prefix = $(prefix)
b42b3782 500# Directory in which to put the executable for the command `gcc'
a60ff512 501bindir = $(exec_prefix)/bin
b42b3782 502# Directory in which to put the directories used by the compiler.
a60ff512
RP
503libdir = $(exec_prefix)/lib
504# Directory in which to put the Info files.
505infodir = $(prefix)/info
b42b3782
RP
506@end example
507
b42b3782
RP
508@node Configuration
509@chapter How Configuration Should Work
510
511Each GNU distribution should come with a shell script named
512@code{configure}. This script is given arguments which describe the
513kind of machine and system you want to compile the program for.
514
515The @code{configure} script must record the configuration options so
516that they affect compilation.
517
518One way to do this is to make a link from a standard name such as
519@file{config.h} to the proper configuration file for the chosen system.
520If you use this technique, the distribution should @emph{not} contain a
521file named @file{config.h}. This is so that people won't be able to
522build the program without configuring it first.
523
524Another thing that @code{configure} can do is to edit the Makefile. If
525you do this, the distribution should @emph{not} contain a file named
526@file{Makefile}. Instead, include a file @file{Makefile.in} which
527contains the input used for editing. Once again, this is so that people
528won't be able to build the program without configuring it first.
529
530If @code{configure} does write the @file{Makefile}, then @file{Makefile}
531should have a target named @file{Makefile} which causes @code{configure}
532to be rerun, setting up the same configuration that was set up last
533time. The files that @code{configure} reads should be listed as
534dependencies of @file{Makefile}.
535
536All the files which are output from the @code{configure} script should
537have comments at the beginning explaining that they were generated
538automatically using @code{configure}. This is so that users won't think
539of trying to edit them by hand.
540
541The @code{configure} script should write a file named @file{config.status}
542which describes which configuration options were specified when the
543program was last configured. This file should be a shell script which,
544if run, will recreate the same configuration.
545
546The @code{configure} script should accept an option of the form
547@samp{--srcdir=@var{dirname}} to specify the directory where sources are found
548(if it is not the current directory). This makes it possible to build
549the program in a separate directory, so that the actual source directory
550is not modified.
551
552If the user does not specify @samp{--srcdir}, then @code{configure} should
553check both @file{.} and @file{..} to see if it can find the sources. If
554it finds the sources in one of these places, it should use them from
555there. Otherwise, it should report that it cannot find the sources, and
556should exit with nonzero status.
557
558Usually the easy way to support @samp{--srcdir} is by editing a
559definition of @code{VPATH} into the Makefile. Some rules may need to
560refer explicitly to the specified source directory. To make this
561possible, @code{configure} can add to the Makefile a variable named
562@code{srcdir} whose value is precisely the specified directory.
563
564The @code{configure} script should also take an argument which specifies the
565type of system to build the program for. This argument should look like
566this:
567
568@example
569@var{cpu}-@var{company}-@var{system}
570@end example
571
572For example, a Sun 3 might be @samp{m68k-sun-sunos4.1}.
573
574The @code{configure} script needs to be able to decode all plausible
575alternatives for how to describe a machine. Thus, @samp{sun3-sunos4.1}
85e44e95 576would be a valid alias. So would @samp{sun3-bsd4.2}, since SunOS is
b42b3782
RP
577basically @sc{BSD} and no other @sc{BSD} system is used on a Sun. For many
578programs, @samp{vax-dec-ultrix} would be an alias for
579@samp{vax-dec-bsd}, simply because the differences between Ultrix and
580@sc{BSD} are rarely noticeable, but a few programs might need to distinguish
581them.
582
583There is a shell script called @file{config.sub} that you can use
584as a subroutine to validate system types and canonicalize aliases.
585
586Other options are permitted to specify in more detail the software
587or hardware are present on the machine:
588
589@table @samp
590@item --with-@var{package}
591The package @var{package} will be installed, so configure this package
592to work with @var{package}.
593
594Possible values of @var{package} include @samp{x}, @samp{gnu-as} (or
595@samp{gas}), @samp{gnu-ld}, @samp{gnu-libc}, and @samp{gdb}.
596
597@item --nfp
598The target machine has no floating point processor.
599
600@item --gas
601The target machine assembler is GAS, the GNU assembler.
602This is obsolete; use @samp{--with-gnu-as} instead.
603
604@item --x
605The target machine has the X Window system installed.
606This is obsolete; use @samp{--with-x} instead.
607@end table
608
609All @code{configure} scripts should accept all of these ``detail''
610options, whether or not they make any difference to the particular
611package at hand. In particular, they should accept any option that
612starts with @samp{--with-}. This is so users will be able to configure
613an entire GNU source tree at once with a single set of options.
614
615Packages that perform part of compilation may support cross-compilation.
616In such a case, the host and target machines for the program may be
617different. The @code{configure} script should normally treat the
618specified type of system as both the host and the target, thus producing
619a program which works for the same type of machine that it runs on.
620
621The way to build a cross-compiler, cross-assembler, or what have you, is
622to specify the option @samp{--host=@var{hosttype}} when running
623@code{configure}. This specifies the host system without changing the
624type of target system. The syntax for @var{hosttype} is the same as
625described above.
626
627Programs for which cross-operation is not meaningful need not accept the
628@samp{--host} option, because configuring an entire operating system for
629cross-operation is not a meaningful thing.
630
631Some programs have ways of configuring themselves automatically. If
632your program is set up to do this, your @code{configure} script can simply
633ignore most of its arguments.
634
635
636@node Source Language
637@chapter Using Languages Other Than C
638
639Using a language other than C is like using a non-standard feature: it
640will cause trouble for users. Even if GCC supports the other language,
641users may find it inconvenient to have to install the compiler for that
642other language in order to build your program. So please write in C.
643
644There are three exceptions for this rule:
645
646@itemize @bullet
647@item
648It is okay to use a special language if the same program contains an
649interpreter for that language.
650
651Thus, it is not a problem that GNU Emacs contains code written in Emacs
652Lisp, because it comes with a Lisp interpreter.
653
654@item
655It is okay to use another language in a tool specifically intended for
656use with that language.
657
658This is okay because the only people who want to build the tool will be
659those who have installed the other language anyway.
660
661@item
662If an application is not of extremely widespread interest, then perhaps
663it's not important if the application is inconvenient to install.
664@end itemize
665
666@node Formatting
667@chapter Formatting Your Source Code
668
669It is important to put the open-brace that starts the body of a C
670function in column zero, and avoid putting any other open-brace or
671open-parenthesis or open-bracket in column zero. Several tools look
672for open-braces in column zero to find the beginnings of C functions.
673These tools will not work on code not formatted that way.
674
675It is also important for function definitions to start the name of the
676function in column zero. This helps people to search for function
677definitions, and may also help certain tools recognize them. Thus,
678the proper format is this:
679
680@example
681static char *
682concat (s1, s2) /* Name starts in column zero here */
683 char *s1, *s2;
684@{ /* Open brace in column zero here */
685 @dots{}
686@}
687@end example
688
689@noindent
690or, if you want to use @sc{ANSI} C, format the definition like this:
691
692@example
693static char *
694concat (char *s1, char *s2)
695@{
696 @dots{}
697@}
698@end example
699
700In @sc{ANSI} C, if the arguments don't fit nicely on one line,
701split it like this:
702
703@example
704int
705lots_of_args (int an_integer, long a_long, short a_short,
706 double a_double, float a_float)
707@dots{}
708@end example
709
710For the body of the function, we prefer code formatted like this:
711
712@example
713if (x < foo (y, z))
714 haha = bar[4] + 5;
715else
716 @{
717 while (z)
718 @{
719 haha += foo (z, z);
720 z--;
721 @}
722 return ++x + bar ();
723 @}
724@end example
725
726We find it easier to read a program when it has spaces before the
727open-parentheses and after the commas. Especially after the commas.
728
729When you split an expression into multiple lines, split it
730before an operator, not after one. Here is the right way:
731
732@example
733if (foo_this_is_long && bar > win (x, y, z)
734 && remaining_condition)
735@end example
736
737Try to avoid having two operators of different precedence at the same
738level of indentation. For example, don't write this:
739
740@example
741mode = (inmode[j] == VOIDmode
742 || GET_MODE_SIZE (outmode[j]) > GET_MODE_SIZE (inmode[j])
743 ? outmode[j] : inmode[j]);
744@end example
745
746Instead, use extra parentheses so that the indentation shows the nesting:
747
748@example
749mode = ((inmode[j] == VOIDmode
750 || (GET_MODE_SIZE (outmode[j]) > GET_MODE_SIZE (inmode[j])))
751 ? outmode[j] : inmode[j]);
752@end example
753
754Insert extra parentheses so that Emacs will indent the code properly.
755For example, the following indentation looks nice if you do it by hand,
756but Emacs would mess it up:
757
758@example
759v = rup->ru_utime.tv_sec*1000 + rup->ru_utime.tv_usec/1000
760 + rup->ru_stime.tv_sec*1000 + rup->ru_stime.tv_usec/1000;
761@end example
762
763But adding a set of parentheses solves the problem:
764
765@example
766v = (rup->ru_utime.tv_sec*1000 + rup->ru_utime.tv_usec/1000
767 + rup->ru_stime.tv_sec*1000 + rup->ru_stime.tv_usec/1000);
768@end example
769
770Format do-while statements like this:
771
772@example
773do
774 @{
775 a = foo (a);
776 @}
777while (a > 0);
778@end example
779
780Please use formfeed characters (control-L) to divide the program into
781pages at logical places (but not within a function). It does not matter
782just how long the pages are, since they do not have to fit on a printed
783page. The formfeeds should appear alone on lines by themselves.
784
785
786@node Comments
787@chapter Commenting Your Work
788
789Every program should start with a comment saying briefly what it is for.
790Example: @samp{fmt - filter for simple filling of text}.
791
792Please put a comment on each function saying what the function does,
793what sorts of arguments it gets, and what the possible values of
794arguments mean and are used for. It is not necessary to duplicate in
795words the meaning of the C argument declarations, if a C type is being
796used in its customary fashion. If there is anything nonstandard about
797its use (such as an argument of type @code{char *} which is really the
798address of the second character of a string, not the first), or any
799possible values that would not work the way one would expect (such as,
800that strings containing newlines are not guaranteed to work), be sure
801to say so.
802
803Also explain the significance of the return value, if there is one.
804
805Please put two spaces after the end of a sentence in your comments, so
806that the Emacs sentence commands will work. Also, please write
807complete sentences and capitalize the first word. If a lower-case
808identifer comes at the beginning of a sentence, don't capitalize it!
809Changing the spelling makes it a different identifier. If you don't
810like starting a sentence with a lower case letter, write the sentence
811differently (e.g. ``The identifier lower-case is @dots{}'').
812
813The comment on a function is much clearer if you use the argument
814names to speak about the argument values. The variable name itself
815should be lower case, but write it in upper case when you are speaking
816about the value rather than the variable itself. Thus, ``the inode
817number @var{node_num}'' rather than ``an inode''.
818
819There is usually no purpose in restating the name of the function in
820the comment before it, because the reader can see that for himself.
821There might be an exception when the comment is so long that the function
822itself would be off the bottom of the screen.
823
824There should be a comment on each static variable as well, like this:
825
826@example
827/* Nonzero means truncate lines in the display;
828 zero means continue them. */
829
830int truncate_lines;
831@end example
832
833Every @samp{#endif} should have a comment, except in the case of short
834conditionals (just a few lines) that are not nested. The comment should
835state the condition of the conditional that is ending, @emph{including
836its sense}. @samp{#else} should have a comment describing the condition
837@emph{and sense} of the code that follows. For example:
838
839@example
840#ifdef foo
841 @dots{}
842#else /* not foo */
843 @dots{}
844#endif /* not foo */
845@end example
846
847@noindent
848but, by contrast, write the comments this way for a @samp{#ifndef}:
849
850@example
851#ifndef foo
852 @dots{}
853#else /* foo */
854 @dots{}
855#endif /* foo */
856@end example
857
858
859@node Syntactic Conventions
860@chapter Clean Use of C Constructs
861
862Please explicitly declare all arguments to functions.
863Don't omit them just because they are ints.
864
865Declarations of external functions and functions to appear later
866in the source file should all go in one place near the beginning of
867the file (somewhere before the first function definition in the file),
868or else should go in a header file. Don't put extern declarations
869inside functions.
870
871Don't declare multiple variables in one declaration that spans lines.
872Start a new declaration on each line, instead. For example, instead
873of this:
874
875@example
876int foo,
877 bar;
878@end example
879
880@noindent
881write either this:
882
883@example
884int foo, bar;
885@end example
886
887@noindent
888or this:
889
890@example
891int foo;
892int bar;
893@end example
894
895@noindent
896(If they are global variables, each should have a comment preceding it
897anyway.)
898
899When you have an if-else statement nested in another if statement,
900always put braces around the if-else. Thus, never write like this:
901
902@example
903if (foo)
904 if (bar)
905 win ();
906 else
907 lose ();
908@end example
909
910@noindent
911always like this:
912
913@example
914if (foo)
915 @{
916 if (bar)
917 win ();
918 else
919 lose ();
920 @}
921@end example
922
923If you have an if statement nested inside of an else statement,
924either write @code{else if} on one line, like this,
925
926@example
927if (foo)
928 @dots{}
929else if (bar)
930 @dots{}
931@end example
932
933@noindent
934with its then-part indented like the preceding then-part, or write the
935nested if within braces like this:
936
937@example
938if (foo)
939 @dots{}
940else
941 @{
942 if (bar)
943 @dots{}
944 @}
945@end example
946
947Don't declare both a structure tag and variables or typedefs in the
948same declaration. Instead, declare the structure tag separately
949and then use it to declare the variables or typedefs.
950
951Try to avoid assignments inside if-conditions. For example, don't
952write this:
953
954@example
955if ((foo = (char *) malloc (sizeof *foo)) == 0)
956 fatal ("virtual memory exhausted");
957@end example
958
959@noindent
960instead, write this:
961
962@example
963foo = (char *) malloc (sizeof *foo);
964if (foo == 0)
965 fatal ("virtual memory exhausted");
966@end example
967
968Don't make the program ugly to placate lint. Please don't insert any
969casts to void. Zero without a cast is perfectly fine as a null
970pointer constant.
971
972
973@node Names
974@chapter Naming Variables and Functions
975
976Please use underscores to separate words in a name, so that the Emacs
977word commands can be useful within them. Stick to lower case; reserve
978upper case for macros and enum constants, and for name-prefixes that
979follow a uniform convention.
980
981For example, you should use names like @code{ignore_space_change_flag};
982don't use names like @code{iCantReadThis}.
983
984Variables that indicate whether command-line options have been
985specified should be named after the meaning of the option, not after
986the option-letter. A comment should state both the exact meaning of
987the option and its letter. For example,
988
989@example
990/* Ignore changes in horizontal whitespace (-b). */
991int ignore_space_change_flag;
992@end example
993
994When you want to define names with constant integer values, use
995@code{enum} rather than @samp{#define}. GDB knows about enumeration
996constants.
997
998Use file names of 14 characters or less, to avoid creating gratuitous
999problems on System V.
1000
1001
1002@node Using Extensions
1003@chapter Using Non-standard Features
1004
1005Many GNU facilities that already exist support a number of convenient
1006extensions over the comparable Unix facilities. Whether to use these
1007extensions in implementing your program is a difficult question.
1008
1009On the one hand, using the extensions can make a cleaner program.
1010On the other hand, people will not be able to build the program
1011unless the other GNU tools are available. This might cause the
1012program to work on fewer kinds of machines.
1013
1014With some extensions, it might be easy to provide both alternatives.
1015For example, you can define functions with a ``keyword'' @code{INLINE}
1016and define that as a macro to expand into either @code{inline} or
1017nothing, depending on the compiler.
1018
1019In general, perhaps it is best not to use the extensions if you can
1020straightforwardly do without them, but to use the extensions if they
1021are a big improvement.
1022
1023An exception to this rule are the large, established programs (such as
1024Emacs) which run on a great variety of systems. Such programs would
1025be broken by use of GNU extensions.
1026
1027Another exception is for programs that are used as part of
1028compilation: anything that must be compiled with other compilers in
1029order to bootstrap the GNU compilation facilities. If these require
1030the GNU compiler, then no one can compile them without having them
1031installed already. That would be no good.
1032
1033Since most computer systems do not yet implement @sc{ANSI} C, using the
1034@sc{ANSI} C features is effectively using a GNU extension, so the
1035same considerations apply. (Except for @sc{ANSI} features that we
1036discourage, such as trigraphs---don't ever use them.)
1037
1038@node Semantics
1039@chapter Program Behaviour for All Programs
1040
1041Avoid arbitrary limits on the length or number of @emph{any} data
1042structure, including filenames, lines, files, and symbols, by allocating
1043all data structures dynamically. In most Unix utilities, ``long lines
1044are silently truncated''. This is not acceptable in a GNU utility.
1045
1046Utilities reading files should not drop NUL characters, or any other
1047nonprinting characters @emph{including those with codes above 0177}. The
1048only sensible exceptions would be utilities specifically intended for
1049interface to certain types of printers that can't handle those characters.
1050
1051Check every system call for an error return, unless you know you wish to
1052ignore errors. Include the system error text (from @code{perror} or
1053equivalent) in @emph{every} error message resulting from a failing
1054system call, as well as the name of the file if any and the name of the
1055utility. Just ``cannot open foo.c'' or ``stat failed'' is not
1056sufficient.
1057
1058Check every call to @code{malloc} or @code{realloc} to see if it
1059returned zero. Check @code{realloc} even if you are making the block
1060smaller; in a system that rounds block sizes to a power of 2,
1061@code{realloc} may get a different block if you ask for less space.
1062
1063In Unix, @code{realloc} can destroy the storage block if it returns
1064zero. GNU @code{realloc} does not have this bug: if it fails, the
1065original block is unchanged. Feel free to assume the bug is fixed. If
1066you wish to run your program on Unix, and wish to avoid lossage in this
1067case, you can use the GNU @code{malloc}.
1068
1069You must expect @code{free} to alter the contents of the block that was
1070freed. Anything you want to fetch from the block, you must fetch before
1071calling @code{free}.
1072
1073Use @code{getopt_long} to decode arguments, unless the argument syntax
1074makes this unreasonable.
1075
1076When static storage is to be written in during program execution, use
1077explicit C code to initialize it. Reserve C initialized declarations
1078for data that will not be changed.
1079
1080Try to avoid low-level interfaces to obscure Unix data structures (such
1081as file directories, utmp, or the layout of kernel memory), since these
1082are less likely to work compatibly. If you need to find all the files
85e44e95
RP
1083in a directory, use @code{readdir} or some other high-level interface.
1084These will be supported compatibly by GNU.
b42b3782 1085
85e44e95
RP
1086By default, the GNU system will provide the signal handling functions of
1087@sc{BSD} and of @sc{POSIX}. So GNU software should be written to use
1088these.
b42b3782
RP
1089
1090In error checks that detect ``impossible'' conditions, just abort.
1091There is usually no point in printing any message. These checks
1092indicate the existence of bugs. Whoever wants to fix the bugs will have
1093to read the source code and run a debugger. So explain the problem with
1094comments in the source. The relevant data will be in variables, which
1095are easy to examine with the debugger, so there is no point moving them
1096elsewhere.
1097
1098
1099@node Errors
1100@chapter Formatting Error Messages
1101
1102Error messages from compilers should look like this:
1103
1104@example
1105@var{source-file-name}:@var{lineno}: @var{message}
1106@end example
1107
1108Error messages from other noninteractive programs should look like this:
1109
1110@example
1111@var{program}:@var{source-file-name}:@var{lineno}: @var{message}
1112@end example
1113
1114@noindent
1115when there is an appropriate source file, or like this:
1116
1117@example
1118@var{program}: @var{message}
1119@end example
1120
1121@noindent
1122when there is no relevant source file.
1123
1124In an interactive program (one that is reading commands from a
1125terminal), it is better not to include the program name in an error
1126message. The place to indicate which program is running is in the
1127prompt or with the screen layout. (When the same program runs with
1128input from a source other than a terminal, it is not interactive and
1129would do best to print error messages using the noninteractive style.)
1130
1131The string @var{message} should not begin with a capital letter when
1132it follows a program name and/or filename. Also, it should not end
1133with a period.
1134
1135Error messages from interactive programs, and other messages such as
1136usage messages, should start with a capital letter. But they should not
1137end with a period.
1138
1139
1140@node Libraries
1141@chapter Library Behaviour
1142
1143Try to make library functions reentrant. If they need to do dynamic
1144storage allocation, at least try to avoid any nonreentrancy aside from
1145that of @code{malloc} itself.
1146
1147Here are certain name conventions for libraries, to avoid name
1148conflicts.
1149
1150Choose a name prefix for the library, more than two characters long.
1151All external function and variable names should start with this
1152prefix. In addition, there should only be one of these in any given
1153library member. This usually means putting each one in a separate
1154source file.
1155
1156An exception can be made when two external symbols are always used
1157together, so that no reasonable program could use one without the
1158other; then they can both go in the same file.
1159
1160External symbols that are not documented entry points for the user
1161should have names beginning with @samp{_}. They should also contain
1162the chosen name prefix for the library, to prevent collisions with
1163other libraries. These can go in the same files with user entry
1164points if you like.
1165
1166Static functions and variables can be used as you like and need not
1167fit any naming convention.
1168
1169
1170@node Portability
1171@chapter Portability As It Applies to GNU
1172
1173Much of what is called ``portability'' in the Unix world refers to
1174porting to different Unix versions. This is not relevant to GNU
1175software, because its purpose is to run on top of one and only
1176one kernel, the GNU kernel, compiled with one and only one C
1177compiler, the GNU C compiler. The amount and kinds of variation
1178among GNU systems on different cpu's will be like the variation
1179among Berkeley 4.3 systems on different cpu's.
1180
1181It is difficult to be sure exactly what facilities the GNU kernel
1182will provide, since it isn't finished yet. Therefore, assume you can
1183use anything in 4.3; just avoid using the format of semi-internal data
1184bases (e.g., directories) when there is a higher-level alternative
1185(readdir).
1186
1187You can freely assume any reasonably standard facilities in the C
1188language, libraries or kernel, because we will find it necessary to
1189support these facilities in the full GNU system, whether or not we
1190have already done so. The fact that there may exist kernels or C
1191compilers that lack these facilities is irrelevant as long as the GNU
1192kernel and C compiler support them.
1193
1194It remains necessary to worry about differences among cpu types, such
1195as the difference in byte ordering and alignment restrictions. It's
1196unlikely that 16-bit machines will ever be supported by GNU, so there
1197is no point in spending any time to consider the possibility that an
1198int will be less than 32 bits.
1199
1200You can assume that all pointers have the same format, regardless
1201of the type they point to, and that this is really an integer.
1202There are some weird machines where this isn't true, but they aren't
1203important; don't waste time catering to them. Besides, eventually
1204we will put function prototypes into all GNU programs, and that will
1205probably make your program work even on weird machines.
1206
1207Since some important machines (including the 68000) are big-endian,
1208it is important not to assume that the address of an int object
1209is also the address of its least-significant byte. Thus, don't
1210make the following mistake:
1211
1212@example
1213int c;
1214@dots{}
1215while ((c = getchar()) != EOF)
1216 write(file_descriptor, &c, 1);
1217@end example
1218
1219You can assume that it is reasonable to use a meg of memory. Don't
1220strain to reduce memory usage unless it can get to that level. If
1221your program creates complicated data structures, just make them in
1222core and give a fatal error if malloc returns zero.
1223
1224If a program works by lines and could be applied to arbitrary
1225user-supplied input files, it should keep only a line in memory, because
1226this is not very hard and users will want to be able to operate on input
1227files that are bigger than will fit in core all at once.
1228
1229
1230@node User Interfaces
1231@chapter Standards for Command Line Interfaces
1232
1233Please don't make the behavior of a utility depend on the name used
1234to invoke it. It is useful sometimes to make a link to a utility
1235with a different name, and that should not change what it does.
1236
1237Instead, use a run time option or a compilation switch or both
1238to select among the alternate behaviors.
1239
1240It is a good idea to follow the @sc{POSIX} guidelines for the
1241command-line options of a program. The easiest way to do this is to use
1242@code{getopt} to parse them. Note that the GNU version of @code{getopt}
1243will normally permit options anywhere among the arguments unless the
1244special argument @samp{--} is used. This is not what @sc{POSIX}
1245specifies; it is a GNU extension.
1246
1247Please define long-named options that are equivalent to the
1248single-letter Unix-style options. We hope to make GNU more user
1249friendly this way. This is easy to do with the GNU function
1250@code{getopt_long}.
1251
1252It is usually a good idea for file names given as ordinary arguments
1253to be input files only; any output files would be specified using
1254options (preferably @samp{-o}). Even if you allow an output file name
1255as an ordinary argument for compatibility, try to provide a suitable
1256option as well. This will lead to more consistency among GNU
1257utilities, so that there are fewer idiosyncracies for users to
1258remember.
1259
1260Programs should support an option @samp{--version} which prints the
1261program's version number, and an option @samp{--help} which prints
1262option usage information.
1263
1264
1265@node Documentation
1266@chapter Documenting Programs
1267
1268Please use Texinfo for documenting GNU programs. See the Texinfo
1269manual, either the hardcopy or the version in the GNU Emacs Info
1270sub-system (@kbd{C-h i}).
1271
1272See existing GNU texinfo files (e.g. those under the @file{man/}
1273directory in the GNU Emacs Distribution) for examples.
1274
1275The title page of the manual should state the version of the program
1276which the manual applies to. The Top node of the manual should also
1277contain this information. If the manual is changing more frequently
1278than or independent of the program, also state a version number for
1279the manual in both of these places.
1280
1281The manual should document all command-line arguments and all
1282commands. It should give examples of their use. But don't organize
1283the manual as a list of features. Instead, organize it by the
1284concepts a user will have before reaching that point in the manual.
1285Address the goals that a user will have in mind, and explain how to
1286accomplish them.
1287
1288
1289@node Releases
1290@chapter Making Releases
1291
1292Package the distribution of Foo version 69.96 in a tar file named
1293@file{foo-69.96.tar}. It should unpack into a subdirectory named
1294@file{foo-69.96}.
1295
1296Building and installing the program should never modify any of the files
1297contained in the distribution. This means that all the files that form
1298part of the program in any way must be classified into @dfn{source
1299files} and @dfn{non-source files}. Source files are written by humans
1300and never changed automatically; non-source files are produced from
1301source files by programs under the control of the Makefile.
1302
1303Naturally, all the source files must be in the distribution. It is okay
1304to include non-source files in the distribution, provided they are
1305up-to-date and machine-independent, so that building the distribution
1306normally will never modify them. We commonly included non-source files
1307produced by Bison, Lex, @TeX{}, and Makeinfo; this helps avoid
1308unnecessary dependencies between our distributions, so that users can
1309install whichever packages they want to install.
1310
1311Non-source files that might actually be modified by building and
1312installing the program should @strong{never} be included in the
1313distribution. So if you do distribute non-source files, always make
1314sure they are up to date when you make a new distribution.
1315
1316Make sure that no file name in the distribution is no more than 14
1317characters long. Nowadays, there are systems that adhere to a foolish
1318interpretation of the POSIX standard which holds that they should refuse
1319to open a longer name, rather than truncating as they did in the past.
1320
1321Try to make sure that all the file names will be unique on MS-DOG. A
1322name on MS-DOG consists of up to 8 characters, optionally followed by a
1323period and up to three characters. MS-DOG will truncate extra
1324characters both before and after the period. Thus,
1325@file{foobarhacker.c} and @file{foobarhacker.o} are not ambiguous; they
1326are truncated to @file{foobarhac.c} and @file{foobarhac.o}, which are
1327distinct.
1328
1329Include in your distribution a copy of the @file{texinfo.tex} you used
1330to test print any @file{*.texinfo} files.
1331
a60ff512
RP
1332Likewise, if your program uses small GNU software packages like regex,
1333getopt, obstack, or termcap, include them in the distribution file.
1334Leaving them out would make the distribution file a little smaller at
1335the expense of possible inconvenience to a user who doesn't know what
1336other files to get.
b42b3782 1337@bye
This page took 0.072133 seconds and 4 git commands to generate.