projects / deliverable / binutils-gdb.git / blame_incremental
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (non-incremental) | history | HEAD
Re-apply the current layout when resizing
[deliverable/binutils-gdb.git] / gdb / ChangeLog
... / ...
CommitLineData
12019-12-11 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-win.c (tui_resize_all): Remove code, call
4 tui_apply_current_layout.
5
62019-12-11 Tom Tromey <tom@tromey.com>
7
8 * tui/tui-layout.h (tui_apply_current_layout): Declare.
9 * tui/tui-layout.c (standard_layouts, applied_layout): New
10 globals.
11 (tui_apply_current_layout): New function.
12 (show_layout): Set applied_layout. Call
13 tui_apply_current_layout.
14 (show_source_command, show_disasm_command)
15 (show_source_disasm_command, show_data)
16 (show_source_or_disasm_and_command): Remove.
17 (initialize_layouts): New function.
18 (_initialize_tui_layout): Call initialize_layouts.
19
202019-12-11 Tom Tromey <tom@tromey.com>
21
22 * tui/tui-layout.h (class tui_layout_base)
23 (class tui_layout_window, class tui_layout_split): New.
24 * tui/tui-layout.c (tui_get_window_by_name)
25 (tui_layout_window::clone, tui_layout_window::apply)
26 (tui_layout_window::get_sizes, tui_layout_window::add_split)
27 (tui_layout_split::add_window, tui_layout_split::clone)
28 (tui_layout_split::get_sizes)
29 (tui_layout_split::set_weights_from_heights)
30 (tui_layout_split::adjust_size, tui_layout_split::apply): New
31 functions.
32 (tui_layout_split::add_split, tui_layout_split::add_split)
33 (tui_layout_split::set_weights_from_heights)
34 (tui_layout_split::set_weights_from_heights): New functions.
35
362019-12-11 Tom Tromey <tom@tromey.com>
37
38 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
39 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
40 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
41 * tui/tui-data.h (struct tui_point): Remove.
42 (struct tui_gen_win_info) <origin>: Remove.
43 <x, y>: New fields.
44 * tui/tui-command.c (tui_cmd_window::resize): Update.
45
462019-12-11 Tom Tromey <tom@tromey.com>
47
48 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
49 Implement.
50 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
51 Implement.
52 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
53 method.
54 (struct tui_win_info) <min_height>: Implement.
55
562019-12-11 Tom Tromey <tom@tromey.com>
57
58 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
59 (struct tui_win_info) <can_box>: Update.
60
612019-12-11 Tom Tromey <tom@tromey.com>
62
63 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
64 method.
65 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
66 method.
67 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
68 method.
69 (struct tui_win_info) <max_height>: Now override.
70
712019-12-11 Joel Brobecker <brobecker@adacore.com>
72
73 * NEWS: Create a new section for the next release branch.
74 Rename the section of the current branch, now that it has
75 been cut.
76
772019-12-11 Joel Brobecker <brobecker@adacore.com>
78
79 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
80 * version.in: Bump version to 10.0.50.DATE-git.
81
822019-12-11 Tom Tromey <tromey@adacore.com>
83
84 PR build/25268:
85 * gdbsupport/thread-pool.c (set_thread_name): New function.
86 (thread_pool::set_thread_count): Don't call pthread_setname_np.
87 (thread_pool::thread_function): Call set_thread_name.
88
892019-12-11 Tom Tromey <tromey@adacore.com>
90
91 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
92 bfd_get_signed_8.
93
942019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
95
96 * NEWS: Document -raw-values option and the related setting commands.
97 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
98 only set it on when /r is given.
99 * valprint.c (value_print_option_defs): New element raw-values.
100 * Makefile.in: Add the new file.
101
1022019-12-10 Christian Biesinger <cbiesinger@google.com>
103
104 * gdbsupport/safe-strerror.c: Supress the unused function warning
105 for select_strerror_r.
106
1072019-12-10 Christian Biesinger <cbiesinger@google.com>
108
109 * config.in: Regenerate.
110 * configure: Regenerate.
111 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
112 safe_strerror instead of strerror.
113 * gdbsupport/common.m4: Don't check for strerror.
114 * gdbsupport/safe-strerror.c: Support both the glibc version
115 of strerror_r and the XSI version.
116
1172019-12-10 Tom Tromey <tromey@adacore.com>
118
119 * ada-typeprint.c (print_choices): Use a single "?".
120 (print_variant_part): Print "?" if the discriminant name
121 is not known.
122
1232019-12-10 George Barrett <bob@bob131.so>
124
125 Fix scripted probe breakpoints.
126 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
127 declaration forward.
128 (breakpoint_ops_for_event_location_type)
129 (breakpoint_ops_for_event_location): Add function definitions.
130 (break_command_1, trace_command): Use
131 breakpoint_ops_for_event_location.
132 * breakpoint.h (breakpoint_ops_for_event_location): Add function
133 declarations.
134 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
135 breakpoint_ops_for_event_location.
136 * python/py-breakpoint.c (bppy_init): Use
137 breakpoint_ops_for_event_location.
138
1392019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
140
141 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
142 when ranking an lvalue argument for an rvalue parameter.
143
1442019-12-08 Wataru Ashihara <wataash@wataash.com>
145
146 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
147 template argument for scoped_restore_tmpl from bool to int.
148
1492019-12-07 Keith Seitz <keiths@redhat.com>
150
151 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
152 (build_id_to_debug_bfd): Make static, rewriting to use
153 build_id_to_bfd_suffix.
154 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
155 adding `suffix' parameter. Append SUFFIX to file names
156 when searching for matching files.
157 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
158 (build_id_to_exec_bfd): Likewise.
159 * build-id.h (build_id_to_debug_bfd): Clarify that function
160 searches for BFD of debug info file.
161 (build_id_to_exec_bfd): Declare.
162 * corelow.c: Include build-id.h.
163 (locate_exec_from_corefile_build_id): New function.
164 (core_target_open): If no executable BFD is found,
165 search for a core file BFD using build-id.
166
1672019-12-06 Christian Biesinger <cbiesinger@google.com>
168
169 * bcache.c: Put in namespace gdb.
170 * bcache.h: Likewise.
171 * gdbtypes.c (check_types_worklist): Update.
172 (types_deeply_equal): Update.
173 * macrotab.c (struct macro_table) <bcache>: Update.
174 (new_macro_table): Update.
175 * macrotab.h (struct bcache): Put this forward declaration
176 inside namespace gdb.
177 (new_macro_table): Update.
178 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
179 Update.
180 <macro_cache>: Update.
181 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
182
1832019-12-06 Tom de Vries <tdevries@suse.de>
184
185 PR symtab/24971
186 * block.c (best_symbol, better_symbol): New function.
187 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
188 decl.
189
1902019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
191
192 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
193 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
194 for ranking see-through reference cases.
195
1962019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
197 * stack.c (faas_command): Check a command is provided.
198 * thread.c (taas_command, tfaas_command): Likewise.
199
2002019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
201 * inferior.c (prune_inferiors): Only call delete_inferior,
202 Do not modify the inferior list.
203
2042019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
205
206 * c-exp.y: Update calls to lookup_typename,
207 lookup_signed_typename and lookup_unsigned_typename.
208 * c-lang.c (evaluate_subexp_c): Likewise.
209 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
210 Likewise.
211 * eval.c (binop_promote): Likewise.
212 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
213 (lookup_unsigned_typename): Likewise.
214 (lookup_signed_typename): Likewise.
215 * gdbtypes.h (lookup_unsigned_typename): Likewise.
216 (lookup_signed_typename): Likewise.
217 (lookup_typename): Likewise.
218 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
219 lookup_typename, lookup_signed_typename,
220 lookup_unsigned_typename.
221 * m2-exp.y: Likewise.
222 * printcmd.c (printf_wide_c_string): Likewise.
223 (ui_printf): Likewise.
224 * python/py-type.c (typy_lookup_typename): Likewise.
225 * python/py-xmethods.c (python_xmethod_worker::invoke):
226 Likewise.
227 * rust-exp.y: Likewise.
228
2292019-12-04 Christian Biesinger <cbiesinger@google.com>
230
231 * configure.nat (obsd64): Add missing files x86-nat.o and
232 nat/x86-dregs.o.
233
2342019-12-04 Tom Tromey <tom@tromey.com>
235
236 * valprint.c (val_print_string): Use metadata_style.
237 * go-valprint.c (print_go_string): Use metadata style.
238 * p-valprint.c (pascal_object_print_static_field): Use metadata
239 style.
240 * cp-valprint.c (cp_print_static_field): Use metadata style.
241
2422019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
243 Chris January <chris.january@arm.com>
244
245 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
246 tokens.
247 (typebase): New patterns for complex, single/double precision, and
248 single/double complex.
249 (f77_keywords): Change token for complex keyword, and add single,
250 double, and precision keywords.
251
2522019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
253
254 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
255 "info io_registers".
256
2572019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
258
259 * regcache.c (cooked_read_test): Initialize thread list of
260 mock_inferior.
261
2622019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
263
264 * aarch64-linux-tdep.c: Remove includes.
265
2662019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
267
268 * aarch64-tdep.c: Remove includes.
269
2702019-12-04 Simon Marchi <simon.marchi@efficios.com>
271
272 * filtered-iterator.h (filtered_iterator) <operator==,
273 operator!=>: Compare wrapped iterators, not wrapped pointers.
274 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
275 unittests/filtered_iterator-selftests.c.
276 * unittests/filtered_iterator-selftests.c: New file.
277
2782019-12-04 Tom Tromey <tromey@adacore.com>
279
280 * gdbtypes.c (create_range_type): Inherit endianity
281 from base type.
282
2832019-12-04 Tom Tromey <tromey@adacore.com>
284
285 * ada-lang.c (decode_constrained_packed_array)
286 (ada_value_assign, value_assign_to_component): Update.
287 * dwarf2loc.c (rw_pieced_value, access_memory)
288 (dwarf2_compile_expr_to_ax): Update.
289 * dwarf2read.c (dwarf2_add_field): Update.
290 * eval.c (evaluate_subexp_standard): Update.
291 * gdbarch.c, gdbarch.h: Rebuild.
292 * gdbarch.sh (bits_big_endian): Remove.
293 * gdbtypes.h (union field_location): Update comment.
294 * target-descriptions.c (make_gdb_type): Update.
295 * valarith.c (value_bit_index): Update.
296 * value.c (struct value) <bitpos>: Update comment.
297 (unpack_bits_as_long, modify_field): Update.
298 * value.h (value_bitpos): Update comment.
299
3002019-12-04 Tom Tromey <tromey@adacore.com>
301
302 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
303 endian-ness.
304
3052019-12-04 Tom Tromey <tromey@adacore.com>
306
307 * dwarf2read.c (dwarf2_init_float_type)
308 (dwarf2_init_complex_target_type): Add byte_order parameter.
309 (read_base_type): Compute byte order earlier.
310 * gdbtypes.c (init_float_type): Add byte_order parameter.
311 * gdbtypes.h (init_float_type): Add byte_order parameter.
312
3132019-12-04 Tom Tromey <tromey@adacore.com>
314
315 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
316
3172019-12-04 Tom Tromey <tromey@adacore.com>
318
319 * dwarf2read.c (process_structure_scope): Initialize
320 "discr_offset".
321
3222019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
323
324 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
325 add it into the search spec.
326 (parse_max_results_option): New function.
327 (mi_info_functions_or_variables): Parse -max-results flag and pass
328 it to mi_symbol_info.
329 (mi_cmd_symbol_info_modules): Likewise.
330 (mi_cmd_symbol_info_types): Likewise.
331 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
332 return type to bool, change result container into a set, and don't
333 add new results if we have enough already.
334 (global_symbol_searcher::add_matching_msymbols): Change return
335 type to bool, and don't add new results if we have enough already.
336 (sort_search_symbols_remove_dups): Delete.
337 (global_symbol_searcher::search): Early exit from search loop when
338 we have enough results. Use a std::set to collect the results
339 from calling add_matching_symbols.
340 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
341 member function.
342 (global_symbol_searcher) <m_max_search_results>: New member
343 variable.
344 (global_symbol_searcher) <add_matching_symbols>: Update header
345 comment and change return type to bool.
346 (global_symbol_searcher) <add_matching_msymbols>: Update header
347 comment and change return type to bool.
348
3492019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
350
351 * symtab.c (symbol_search::compare_search_syms): Update header
352 comment.
353 (global_symbol_searcher::is_suitable_msymbol): New function.
354 (global_symbol_searcher::expand_symtabs): New function.
355 (global_symbol_searcher::add_matching_symbols): New function.
356 (global_symbol_searcher::add_matching_msymbols): New function.
357 (global_symbol_searcher::search): Move most of the content
358 into the new functions above, and call them as needed.
359 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
360 function.
361 (global_symbol_searcher) <add_matching_symbols>: New member
362 function.
363 (global_symbol_searcher) <add_matching_msymbols>: New member
364 function.
365 (global_symbol_searcher) <is_suitable_msymbol>: New member
366 function.
367
3682019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
369
370 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
371 -symbol-info-module-variables entries.
372 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
373 (mi_cmd_symbol_info_module_variables): Declare.
374 * mi/mi-symbol-cmds.c
375 (module_symbol_search_iterator): New typedef.
376 (output_module_symbols_in_single_module_and_file): New function.
377 (output_module_symbols_in_single_module): New function.
378 (mi_info_module_functions_or_variables): New function.
379 (mi_cmd_symbol_info_module_functions): New function.
380 (mi_cmd_symbol_info_module_variables): New function.
381 * NEWS: Mention new MI command.
382
3832019-12-03 Christian Biesinger <cbiesinger@google.com>
384
385 * bcache.c (hash): Remove.
386 (hash_continue): Remove.
387 * bcache.h (hash): Remove.
388 (hash_continue): Remove.
389 (struct bcache) <ctor>: Update.
390 * psymtab.c (psymbol_hash): Update.
391 * stabsread.c (hashname): Update.
392 * utils.h (fast_hash): Add an argument for a start value,
393 defaulting to zero.
394
3952019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
396 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
397 (destroy_block_symbol_cache): New function.
398 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
399 (resize_symbol_cache): Likewise.
400
4012019-12-02 Tom Tromey <tom@tromey.com>
402
403 * unittests/tui-selftests.c (run_tests): Make conditional.
404 (_initialize_tui_selftest): Make conditional.
405
4062019-12-02 Christian Biesinger <cbiesinger@google.com>
407
408 * aix-thread.c (debug_aix_thread): Change type to bool.
409
4102019-12-02 Luis Machado <luis.machado@linaro.org>
411
412 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
413
4142019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
415
416 * dwarf2read.c (read_tag_string_type): Read the fields required to
417 make a dynamic string, and possibly create a dynamic range for the
418 string.
419 (attr_to_dynamic_prop): Setup is_reference based on the type of
420 attribute being processed.
421 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
422 (resolve_dynamic_array): Rename to...
423 (resolve_dynamic_array_or_string): ...this, update header comment,
424 and accept TYPE_CODE_STRING.
425 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
426
4272019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
428
429 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
430 of its implementation from...
431 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
432 the new function.
433
4342019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
435
436 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
437 create a range with stride where appropriate.
438 * f-valprint.c: Include 'gdbarch.h'.
439 (f77_print_array_1): Take the stride into account when walking the
440 array. Also convert the stride into addressable units.
441 * gdbtypes.c (create_range_type): Initialise the stride to
442 constant zero.
443 (create_range_type_with_stride): New function, initialise the
444 range as normal, and then setup the stride.
445 (has_static_range): Include the stride here. Also change the
446 return type to bool.
447 (create_array_type_with_stride): Consider the range stride if the
448 array isn't given its own stride.
449 (resolve_dynamic_range): Resolve the stride if needed.
450 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
451 (struct range_bounds) <flag_is_byte_stride>: New member variable.
452 (TYPE_BIT_STRIDE): Define.
453 (TYPE_ARRAY_BIT_STRIDE): Define.
454 (create_range_type_with_stride): Declare.
455 * valarith.c (value_subscripted_rvalue): Take range stride into
456 account when walking the array.
457
4582019-12-01 Tom Tromey <tom@tromey.com>
459
460 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
461 specially.
462
4632019-12-01 Tom Tromey <tom@tromey.com>
464
465 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
466 \0.
467 * unittests/tui-selftests.c: New file.
468 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
469
4702019-12-01 Tom Tromey <tom@tromey.com>
471
472 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
473
4742019-12-01 Tom Tromey <tom@tromey.com>
475
476 * NEWS: Document new settings.
477 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
478 * tui/tui-win.c (_initialize_tui_win): Add border style
479 observers.
480 * tui/tui-io.h (tui_apply_style): Declare.
481 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
482 longer static.
483 (apply_ansi_escape, tui_set_reverse_mode): Update.
484 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
485 Add "skip_intensity" parameter.
486 <changed>: New member.
487 <do_set_value>: Declare.
488 (tui_border_style, tui_active_border_style): Declare.
489 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
490 globals.
491 (cli_style_option): Initialize "changed".
492 (cli_style_option::do_set_value): New function.
493 (cli_style_option::add_setshow_commands): Add "skip_intensity"
494 parameter. Update.
495 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
496 (_initialize_cli_style): Update. Create TUI border style
497 commands.
498
4992019-12-01 Tom Tromey <tom@tromey.com>
500
501 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
502 parameter.
503 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
504 parameter.
505 * tui/tui-win.h (compact_source): Declare.
506 * tui/tui-win.c (compact_source): New global.
507 (tui_set_compact_source, tui_show_compact_source): New functions.
508 (_initialize_tui_win): Add "compact-source" setting.
509 * tui/tui-source.c (tui_source_window::set_contents): Handle
510 compact_source setting.
511 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
512 * NEWS: Document new setting.
513
5142019-11-30 Tom Tromey <tom@tromey.com>
515
516 * dwarf2read.c (dwarf2_add_field): Include field offset when
517 computing variant part length.
518
5192019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
520 * NEWS: Mention define-prefix. Tell that command names can now
521 contain a . character.
522
5232019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
524
525 * command.h (valid_cmd_char_p): Declare.
526 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
527 the check of valid command char.
528 (find_command_name_length, valid_user_defined_cmd_name_p): Use
529 valid_cmd_char_p.
530 * cli/cli-script.c (validate_comname): Likewise.
531 * completer.c (gdb_completer_command_word_break_characters):
532 Do not remove . from the word break char, update comments.
533 (complete_line_internal_1): Use valid_cmd_char_p.
534 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
535 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
536
5372019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
538
539 * cli/cli-script.c (do_define_command): Ensure a redefined
540 prefix command is kept as a prefix command.
541 (define_prefix_command): New function.
542 (show_user_1): Report user defined prefixes.
543 (_initialize_cli_script): Create the new 'define-prefix' command.
544 Add completers for 'define' and 'document'.
545 * top.c (execute_command): If command is a user-defined prefix only
546 command, report the list of commands for this prefix command.
547
5482019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
549
550 * valops.c (find_oload_champ): Improve debug output.
551
5522019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
553
554 * valops.c (find_oload_champ): Print part of debug messages
555 before the badness vector is std::move'd.
556
5572019-11-28 Tom Tromey <tom@tromey.com>
558
559 * value.c (creal_internal_fn): Fix comment.
560
5612019-11-28 Tom Tromey <tom@tromey.com>
562
563 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
564 flag_bound_evaluated>: Now unsigned.
565
5662019-11-28 Tom Tromey <tom@tromey.com>
567
568 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
569 declare.
570
5712019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
572
573 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
574 debug output.
575 * jit.c (jit_unregister_code): Add debug print to match
576 `jit_register_code`.
577
5782019-11-27 Christian Biesinger <cbiesinger@google.com>
579
580 * NEWS: Mention the new multithreaded symbol loading.
581
5822019-11-27 Christian Biesinger <cbiesinger@google.com>
583
584 * maint.c (n_worker_threads): Default to 0.
585 (worker_threads_disabled): New function.
586 * maint.h (worker_threads_disabled): New function.
587 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
588 here if worker_threads_disabled () is true.
589 (minimal_symbol_reader::install): Skip all threading if
590 worker_threads_disabled () is true.
591
5922019-11-27 Christian Biesinger <cbiesinger@google.com>
593
594 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
595 hash code if possible.
596 (add_minsym_to_demangled_hash_table): Likewise.
597 (minimal_symbol_reader::install): Compute the hash codes for msymbol
598 on the background thread.
599 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
600 Add these fields.
601
6022019-11-27 Christian Biesinger <cbiesinger@google.com>
603
604 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
605 of the mangled name on the background thread.
606 * symtab.c (symbol_set_names): Allow passing in the hash of the
607 linkage_name.
608 * symtab.h (symbol_set_names): Likewise.
609
6102019-11-27 Kevin Buettner <kevinb@redhat.com>
611
612 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
613 physnames are computed for inherited DIEs.
614
6152019-11-27 Tom Tromey <tromey@adacore.com>
616
617 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
618 backslashes.
619 * cp-support.c: Remove unnecessary backslashes.
620
6212019-11-27 Christian Biesinger <cbiesinger@google.com>
622
623 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
624 with sym->set_linkage_name.
625 * coffread.c (coff_read_enum_type): Likewise.
626 * mdebugread.c (parse_symbol): Likewise.
627 * stabsread.c (patch_block_stabs): Likewise.
628 (define_symbol): Likewise.
629 (read_enum_type): Likewise.
630 (common_block_end): Likewise.
631 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
632 function.
633 (SYMBOL_SET_LINKAGE_NAME): Remove.
634 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
635 with sym->set_linkage_name.
636
6372019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
638
639 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
640 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
641 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
642 * NEWS: Mention new MI command.
643
6442019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
645
646 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
647 '-symbol-info-types', and '-symbol-info-variables'.
648 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
649 (mi_cmd_symbol_info_types): Declare.
650 (mi_cmd_symbol_info_variables): Declare.
651 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
652 (output_debug_symbol): New function.
653 (output_nondebug_symbol): New function.
654 (mi_symbol_info): New function.
655 (mi_info_functions_or_variables): New function.
656 (mi_cmd_symbol_info_functions): New function.
657 (mi_cmd_symbol_info_types): New function.
658 (mi_cmd_symbol_info_variables): New function.
659 * NEWS: Mention new commands.
660
6612019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
662
663 * symtab.c (symbol_to_info_string): New function, most content
664 moved from print_symbol_info, but updated to return a std::string.
665 (print_symbol_info): Update to use symbol_to_info_string and print
666 returned string.
667 * symtab.h (symbol_to_info_string): Declare new function.
668
6692019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
670
671 * python/python.c (gdbpy_rbreak): Convert to using
672 global_symbol_searcher.
673 * symtab.c (file_matches): Convert return type to bool, change
674 file list to std::vector, update header comment.
675 (search_symbols): Rename to...
676 (global_symbol_searcher::search): ...this and update now its
677 a member function of global_symbol_searcher. Take account of the
678 changes to file_matches.
679 (symtab_symbol_info): Convert to using global_symbol_searcher.
680 (rbreak_command): Likewise.
681 (search_module_symbols): Likewise.
682 * symtab.h (enum symbol_search): Update comment.
683 (search_symbols): Remove declaration.
684 (class global_symbol_searcher): New class.
685
6862019-11-26 Tom Tromey <tromey@adacore.com>
687
688 * cp-support.c (_initialize_cp_support): Conditionally initialize
689 gdb_demangle_attempt_core_dump.
690
6912019-11-26 Tom Tromey <tom@tromey.com>
692
693 * python/py-function.c (fnpy_init): Update.
694 * value.h (add_internal_function): Adjust declaration.
695 * value.c (function_destroyer): Remove.
696 (do_add_internal_function): Don't set destroyer or copy name.
697 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
698 Set name_allocated.
699 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
700 (cmdpy_init): Set name_allocated.
701 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
702 member.
703 (~cmd_list_element): Free "name" if needed.
704
7052019-11-26 Tom Tromey <tom@tromey.com>
706
707 * value.h (add_internal_function): Add new overload. Move
708 documentation from value.h.
709 * value.c (do_add_internal_function): New function.
710 (add_internal_function): Use it. Add new overload.
711 (function_destroyer): Don't free doc.
712 * python/py-function.c (fnpy_init): Update.
713
7142019-11-26 Tom Tromey <tom@tromey.com>
715
716 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
717 (cmdpy_init): Set "doc_allocated".
718
7192019-11-26 Tom Tromey <tom@tromey.com>
720
721 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
722 name of worker thread.
723 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
724 pthread_setname_np.
725 * configure, config.in: Rebuild.
726
7272019-11-26 Tom Tromey <tom@tromey.com>
728
729 * python/python.c (class gdbpy_gil): New.
730 (struct gdbpy_event): Add constructor, destructor, operator().
731 (gdbpy_post_event): Use run_on_main_thread.
732 (gdbpy_initialize_events): Remove.
733 (do_start_initialization): Update.
734
7352019-11-26 Tom Tromey <tom@tromey.com>
736
737 * NEWS: Add entry.
738 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
739 commands. Call update_thread_pool_size.
740 (update_thread_pool_size, maintenance_set_worker_threads): New
741 functions.
742 (n_worker_threads): New global.
743
7442019-11-26 Christian Biesinger <cbiesinger@google.com>
745 Tom Tromey <tom@tromey.com>
746
747 * minsyms.c (minimal_symbol_reader::install): Use
748 parallel_for_each.
749 * gdbsupport/parallel-for.h: New file.
750 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
751
7522019-11-26 Christian Biesinger <cbiesinger@google.com>
753 Tom Tromey <tom@tromey.com>
754
755 * gdbsupport/thread-pool.h: New file.
756 * gdbsupport/thread-pool.c: New file.
757 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
758 (HFILES_NO_SRCDIR): Add thread-pool.h.
759
7602019-11-26 Tom Tromey <tom@tromey.com>
761
762 * event-top.h (thread_local_segv_handler): Declare.
763 * event-top.c (thread_local_segv_handler): New global.
764 (install_handle_sigsegv, handle_sigsegv): New functions.
765 (async_init_signals): Install SIGSEGV handler.
766 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
767 thread-local.
768 (report_failed_demangle): New function.
769 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
770 handler-setting code, instead use segv_handler. Run warning code
771 on main thread.
772
7732019-11-26 Tom Tromey <tom@tromey.com>
774
775 * run-on-main-thread.c: New file.
776 * run-on-main-thread.h: New file.
777 * unittests/main-thread-selftests.c: New file.
778 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
779 main-thread-selftests.c.
780 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
781 (COMMON_SFILES): Add run-on-main-thread.c.
782
7832019-11-26 Tom Tromey <tom@tromey.com>
784
785 * main.c (setup_alternate_signal_stack): Remove.
786 (captured_main_1): Use gdb::alternate_signal_stack.
787 * gdbsupport/alt-stack.h: New file.
788
7892019-11-26 Tom Tromey <tom@tromey.com>
790
791 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
792 Remove comment.
793 (save_original_signals_state, restore_original_signals_state): Use
794 gdb_sigmask.
795 * linux-nat.c (block_child_signals, restore_child_signals_mask)
796 (_initialize_linux_nat): Use gdb_sigmask.
797 * guile/guile.c (_initialize_guile): Use block_signals.
798 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
799 * gdbsupport/gdb-sigmask.h: New file.
800 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
801 * cp-support.c (gdb_demangle): Use gdb_sigmask.
802 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
803 pthread_sigmask.
804 * configure, config.in: Rebuild.
805 * gdbsupport/block-signals.h: New file.
806
8072019-11-26 Tom Tromey <tom@tromey.com>
808
809 * acinclude.m4: Include ax_pthread.m4.
810 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
811 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
812 (CLIBS): Use PTHREAD_LIBS.
813 (aclocal_m4_deps): Add ax_pthread.m4.
814 * config.in, configure: Rebuild.
815 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
816
8172019-11-26 Tom Tromey <tom@tromey.com>
818
819 * symtab.h (struct minimal_symbol) <name_set>: New member.
820 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
821 Don't call symbol_set_names.
822 (minimal_symbol_reader::install): Call symbol_set_names.
823
8242019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
825
826 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
827 restore_active_ext_lang, as GIL is needed for (indirectly)
828 called PyOS_InterruptOccurred.
829
8302019-11-26 Simon Marchi <simon.marchi@efficios.com>
831
832 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
833 definition.
834
8352019-11-26 Simon Marchi <simon.marchi@efficios.com>
836
837 * remote-sim.c (simulator_command): Make static, remove
838 declaration.
839
8402019-11-26 Simon Marchi <simon.marchi@efficios.com>
841
842 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
843 static.
844 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
845 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
846 (main): Likewise.
847 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
848 (main): Likewise.
849 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
850 (main): Likewise.
851 * unittests/basic_string_view/element_access/char/1.cc (test01):
852 Likewise.
853 (main): Likewise.
854 * unittests/basic_string_view/element_access/char/empty.cc (main):
855 Likewise.
856 * unittests/basic_string_view/element_access/char/front_back.cc
857 (test01): Likewise.
858 (main): Likewise.
859 * unittests/basic_string_view/inserters/char/2.cc (test05):
860 Likewise.
861 (main): Likewise.
862 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
863 (test01): Likewise.
864 (main): Likewise.
865 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
866 (test01): Likewise.
867 (main): Likewise.
868 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
869 Likewise.
870 * unittests/basic_string_view/operations/compare/char/1.cc
871 (test01): Likewise.
872 (main): Likewise.
873 * unittests/basic_string_view/operations/compare/char/13650.cc
874 (test01): Likewise.
875 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
876 Likewise.
877 (main): Likewise.
878 * unittests/basic_string_view/operations/data/char/1.cc (test01):
879 Likewise.
880 (main): Likewise.
881 * unittests/basic_string_view/operations/find/char/1.cc (test01):
882 Likewise.
883 (main): Likewise.
884 * unittests/basic_string_view/operations/find/char/2.cc (test02):
885 Likewise.
886 (main): Likewise.
887 * unittests/basic_string_view/operations/find/char/3.cc (test03):
888 Likewise.
889 (main): Likewise.
890 * unittests/basic_string_view/operations/find/char/4.cc (main):
891 Likewise.
892 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
893 Likewise.
894 (main): Likewise.
895 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
896 Likewise.
897 (main): Likewise.
898 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
899 Likewise.
900 (main): Likewise.
901 * unittests/basic_string_view/operations/substr/char/1.cc
902 (test01): Likewise.
903 (main): Likewise.
904 * unittests/basic_string_view/operators/char/2.cc (main):
905 Likewise.
906 * unittests/optional/assignment/1.cc (test): Likewise.
907 * unittests/optional/assignment/2.cc (test): Likewise.
908 * unittests/optional/assignment/3.cc (test): Likewise.
909 * unittests/optional/assignment/4.cc (test): Likewise.
910 * unittests/optional/assignment/5.cc (test): Likewise.
911 * unittests/optional/assignment/6.cc (test): Likewise.
912 * unittests/optional/assignment/7.cc (test): Likewise.
913 * unittests/optional/cons/copy.cc (test): Likewise.
914 * unittests/optional/cons/default.cc (test): Likewise.
915 * unittests/optional/cons/move.cc (test): Likewise.
916 * unittests/optional/cons/value.cc (test): Likewise.
917 * unittests/optional/in_place.cc (test): Likewise.
918 * unittests/optional/observers/1.cc (test): Likewise.
919 * unittests/optional/observers/2.cc (test): Likewise.
920
9212019-11-26 Simon Marchi <simon.marchi@efficios.com>
922
923 * tui-win.h (tui_set_var_cmd): Remove.
924 * tui-win.c (tui_set_var_cmd): Make static.
925
9262019-11-26 Simon Marchi <simon.marchi@efficios.com>
927
928 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
929 rbreak_command_wrapper): Remove.
930 * symtab.c (rbreak_command_wrapper): Remove.
931
9322019-11-26 Simon Marchi <simon.marchi@efficios.com>
933
934 * inferior.h (info_terminal_command): Remove declaration.
935 * inflow.c (info_terminal_command): Make static.
936
9372019-11-26 Simon Marchi <simon.marchi@efficios.com>
938
939 * inferior.c (exit_inferior_silent): Remove.
940
9412019-11-26 Simon Marchi <simon.marchi@efficios.com>
942
943 * dictionary.c (dict_empty, mdict_empty): Remove.
944 * dictionary.c (mdict_empty): Remove.
945
9462019-11-26 Simon Marchi <simon.marchi@efficios.com>
947
948 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
949 (arc_insn_get_memory_offset): Likewise.
950 (arc_insn_dump): Likewise.
951 * cp-support.c (test_cp_symbol_name_matches): Likewise.
952 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
953 * dictionary.c (dict_iterator_next): Likewise.
954 (dict_iter_match_first): Likewise.
955 (dict_iter_match_next): Likewise.
956 * f-lang.c (evaluate_subexp_f): Likewise.
957 * hppa-tdep.c (hppa_read_pc): Likewise.
958 * i386-tdep.c (i386_floatformat_for_type): Likewise.
959 * parse.c (write_exp_elt_msym): Likewise.
960 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
961 * remote.c (remote_packet_size): Likewise.
962 (remote_notif_stop_parse): Likewise.
963 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
964 * s12z-tdep.c (s12z_disassemble_info): Likewise.
965 * source.c (prepare_path_for_appending): Likewise.
966 * sparc64-linux-tdep.c
967 (sparc64_linux_handle_segmentation_fault); Likewise.
968 * stack.c (frame_selection_by_function_completer): Likewise.
969
9702019-11-26 Simon Marchi <simon.marchi@efficios.com>
971
972 * completer.c (set_gdb_completion_word_break_characters):
973 Remove.
974
9752019-11-26 Simon Marchi <simon.marchi@efficios.com>
976
977 * dwarf-index-write.c: Include dwarf-index-write.h.
978 * mi/mi-interp.c: Include mi/mi-interp.h.
979
9802019-11-26 Simon Marchi <simon.marchi@efficios.com>
981
982 * aarch32-tdep.c: Include aarch32-tdep.h.
983 * aarch32-tdep.h: Forward-declare struct target_desc.
984
9852019-11-26 Christian Biesinger <cbiesinger@google.com>
986
987 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
988 strerror.
989 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
990 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
991
9922019-11-25 Tom de Vries <tdevries@suse.de>
993
994 * contrib/words.sh: Add -c option.
995
9962019-11-25 Christian Biesinger <cbiesinger@google.com>
997
998 * solib.c (solib_find_1): Change int to bool.
999 (exec_file_find): Change int to bool.
1000 (solib_find): Change int to bool.
1001 (solib_read_symbols): Change int to bool.
1002 (solib_used): Change int to bool.
1003 (solib_add): Change int to bool.
1004 (info_sharedlibrary_command): Change int to bool.
1005 (solib_contains_address_p): Change int to bool.
1006 (solib_keep_data_in_core): Change int to bool.
1007 (in_solib_dynsym_resolve_code): Change int to bool.
1008 (reload_shared_libraries_1): Change int to bool.
1009 (gdb_sysroot_changed): Change int to bool.
1010 * solib.h (solib_read_symbols): Change int to bool.
1011 (solib_contains_address_p): Change int to bool.
1012 (solib_keep_data_in_core): Change int to bool.
1013 (in_solib_dynsym_resolve_code): Change int to bool.
1014 (libpthread_name_p): Change int to bool.
1015
10162019-11-25 Luis Machado <luis.machado@linaro.org>
1017
1018 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1019 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1020 (remote_packet_max_chars): New static global.
1021 (show_remote_packet_max_chars): New function.
1022 (remote_target::putpkt_binary): Adjust to use new
1023 remote_packet_max_chars option.
1024 (remote_target::getpkt_or_notif_sane_1): Likewise.
1025 (_initialize_remote): Register new remote-packet-max-chars option.
1026
10272019-11-24 Simon Marchi <simon.marchi@efficios.com>
1028
1029 * m68k-linux-nat.c: Include gdbarch.h.
1030
10312019-11-24 Tom Tromey <tom@tromey.com>
1032
1033 * symfile.c (read_symbols): Update.
1034 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1035 bool.
1036 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1037 (psym_lookup_symbol, psym_find_last_source_symtab)
1038 (psym_forget_cached_source_info, psym_print_stats)
1039 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1040 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1041 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1042 (psym_find_compunit_symtab_by_address)
1043 (maintenance_print_psymbols, maintenance_info_psymtabs)
1044 (maintenance_check_psymtabs): Update.
1045 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1046 bool.
1047
10482019-11-22 Tom Tromey <tom@tromey.com>
1049
1050 * observable.h: Update comments.
1051
10522019-11-22 Tom Tromey <tromey@adacore.com>
1053
1054 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1055 (print_ada_task_info): Don't try to fetch thread id if task is not
1056 alive.
1057
10582019-11-22 Christian Biesinger <cbiesinger@google.com>
1059
1060 * ada-exp.y: Update.
1061 * ada-lang.c (sort_choices): Update.
1062 (ada_print_symbol_signature): Update.
1063 (resolve_subexp): Update.
1064 (ada_parse_renaming): Update.
1065 (ada_read_renaming_var_value): Update.
1066 (lesseq_defined_than): Update.
1067 (remove_extra_symbols): Update.
1068 (remove_irrelevant_renamings): Update.
1069 (ada_add_block_symbols): Update.
1070 (ada_collect_symbol_completion_matches): Update.
1071 (ada_is_renaming_symbol): Update.
1072 (aggregate_assign_from_choices): Update.
1073 (ada_evaluate_subexp): Update.
1074 (ada_has_this_exception_support): Update.
1075 (ada_is_non_standard_exception_sym): Update.
1076 (ada_add_exceptions_from_frame): Update.
1077 (ada_add_global_exceptions): Update.
1078 (ada_print_subexp): Update.
1079 * ax-gdb.c (gen_var_ref): Update.
1080 (gen_maybe_namespace_elt): Update.
1081 (gen_expr_for_cast): Update.
1082 (gen_expr): Update.
1083 * block.h: Update.
1084 * blockframe.c (find_pc_partial_function): Update.
1085 * breakpoint.c (print_breakpoint_location): Update.
1086 (update_static_tracepoint): Update.
1087 * btrace.c (ftrace_print_function_name): Update.
1088 (ftrace_function_switched): Update.
1089 * buildsym.c (find_symbol_in_list): Update.
1090 * c-exp.y: Update.
1091 * c-typeprint.c (c_print_typedef): Update.
1092 (c_type_print_template_args): Update.
1093 * cli/cli-cmds.c (edit_command): Update.
1094 (list_command): Update.
1095 (print_sal_location): Update.
1096 * coffread.c (patch_opaque_types): Update.
1097 (process_coff_symbol): Update.
1098 (coff_read_enum_type): Update.
1099 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1100 (convert_one_symbol): Update.
1101 (hash_symname): Update.
1102 (eq_symname): Update.
1103 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1104 * compile/compile-cplus-types.c (debug_print_scope): Update.
1105 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1106 * compile/compile-object-load.c (get_out_value_type): Update.
1107 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1108 (search_symbol_list): Update.
1109 (cp_lookup_symbol_imports_or_template): Update.
1110 * cp-support.c (overload_list_add_symbol): Update.
1111 * ctfread.c (psymtab_to_symtab): Update.
1112 * dbxread.c (cp_set_block_scope): Update.
1113 * dictionary.c (iter_match_first_hashed): Update.
1114 (iter_match_next_hashed): Update.
1115 (insert_symbol_hashed): Update.
1116 (iter_match_next_linear): Update.
1117 * dictionary.h: Update.
1118 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1119 (locexpr_describe_location_piece): Update.
1120 (locexpr_describe_location_1): Update.
1121 (locexpr_generate_c_location): Update.
1122 (loclist_describe_location): Update.
1123 (loclist_generate_c_location): Update.
1124 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1125 (read_func_scope): Update.
1126 (process_enumeration_scope): Update.
1127 (new_symbol): Update.
1128 (dwarf2_const_value): Update.
1129 (dwarf2_symbol_mark_computed): Update.
1130 * eval.c (evaluate_funcall): Update.
1131 (evaluate_subexp_standard): Update.
1132 * expprint.c (print_subexp_standard): Update.
1133 (dump_subexp_body_standard): Update.
1134 * f-valprint.c (info_common_command_for_block): Update.
1135 * findvar.c (get_hosting_frame): Update.
1136 (default_read_var_value): Update.
1137 * go-lang.c (go_symbol_package_name): Update.
1138 * guile/scm-block.c (bkscm_print_block_smob): Update.
1139 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1140 (gdbscm_symbol_name): Update.
1141 (gdbscm_symbol_linkage_name): Update.
1142 (gdbscm_symbol_print_name): Update.
1143 * infcall.c (get_function_name): Update.
1144 * infcmd.c (jump_command): Update.
1145 (finish_command): Update.
1146 * infrun.c (insert_exception_resume_breakpoint): Update.
1147 * linespec.c (canonicalize_linespec): Update.
1148 (create_sals_line_offset): Update.
1149 (convert_linespec_to_sals): Update.
1150 (complete_label): Update.
1151 (find_label_symbols_in_block): Update.
1152 * m2-typeprint.c (m2_print_typedef): Update.
1153 * mdebugread.c (mdebug_reg_to_regnum): Update.
1154 (parse_symbol): Update.
1155 (mylookup_symbol): Update.
1156 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1157 (list_args_or_locals): Update.
1158 * objc-lang.c (compare_selectors): Update.
1159 (info_selectors_command): Update.
1160 (compare_classes): Update.
1161 (info_classes_command): Update.
1162 (find_imps): Update.
1163 * p-typeprint.c (pascal_print_typedef): Update.
1164 * printcmd.c (build_address_symbolic): Update.
1165 (info_address_command): Update.
1166 (print_variable_and_value): Update.
1167 * python/py-framefilter.c (extract_sym): Update.
1168 (py_print_single_arg): Update.
1169 * python/py-symbol.c (sympy_str): Update.
1170 (sympy_get_name): Update.
1171 (sympy_get_linkage_name): Update.
1172 * python/python.c (gdbpy_rbreak): Update.
1173 * record-btrace.c (btrace_get_bfun_name): Update.
1174 (btrace_call_history): Update.
1175 * rust-lang.c (rust_print_typedef): Update.
1176 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1177 * stabsread.c (stab_reg_to_regnum): Update.
1178 (define_symbol): Update.
1179 (read_enum_type): Update.
1180 (common_block_end): Update.
1181 (cleanup_undefined_types_1): Update.
1182 (scan_file_globals): Update.
1183 * stack.c (print_frame_arg): Update.
1184 (print_frame_args): Update.
1185 (find_frame_funname): Update.
1186 (info_frame_command_core): Update.
1187 (iterate_over_block_locals): Update.
1188 (print_block_frame_labels): Update.
1189 (do_print_variable_and_value): Update.
1190 (iterate_over_block_arg_vars): Update.
1191 (return_command): Update.
1192 * symmisc.c (dump_symtab_1): Update.
1193 (print_symbol): Update.
1194 * symtab.c (eq_symbol_entry): Update.
1195 (symbol_cache_dump): Update.
1196 (lookup_language_this): Update.
1197 (find_pc_sect_line): Update.
1198 (skip_prologue_sal): Update.
1199 (symbol_search::compare_search_syms): Update.
1200 (treg_matches_sym_type_name): Update.
1201 (search_symbols): Update.
1202 (print_symbol_info): Update.
1203 (rbreak_command): Update.
1204 (completion_list_add_symbol): Update.
1205 (find_gnu_ifunc): Update.
1206 (get_symbol_address): Update.
1207 (search_module_symbols): Update.
1208 (info_module_subcommand): Update.
1209 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1210 (SYMBOL_LINKAGE_NAME): Remove.
1211 (SYMBOL_DEMANGLED_NAME): Remove.
1212 (SYMBOL_PRINT_NAME): Remove.
1213 (SYMBOL_SEARCH_NAME): Remove.
1214 * tracepoint.c (set_traceframe_context): Update.
1215 (validate_actionline): Update.
1216 (collection_list::collect_symbol): Update.
1217 (encode_actions_1): Update.
1218 (info_scope_command): Update.
1219 (print_one_static_tracepoint_marker): Update.
1220 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1221 * valops.c (address_of_variable): Update.
1222 (find_overload_match): Update.
1223 (find_oload_champ): Update.
1224
12252019-11-22 Christian Biesinger <cbiesinger@google.com>
1226
1227 * ada-lang.c (ada_lookup_simple_minsym): Update.
1228 (ada_collect_symbol_completion_matches): Update.
1229 * ada-tasks.c (read_atcb): Update.
1230 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1231 (amd64_windows_skip_trampoline_code): Update.
1232 * arm-tdep.c (skip_prologue_function): Update.
1233 (arm_skip_stack_protector): Update.
1234 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1235 (arm_wince_skip_main_prologue): Update.
1236 * ax-gdb.c (gen_expr): Update.
1237 * block.c (call_site_for_pc): Update.
1238 * blockframe.c (find_pc_partial_function): Update.
1239 * breakpoint.c (set_breakpoint_location_function): Update.
1240 * btrace.c (ftrace_print_function_name): Update.
1241 (ftrace_function_switched): Update.
1242 * c-valprint.c (print_unpacked_pointer): Update.
1243 * coffread.c (coff_symfile_read): Update.
1244 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1245 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1246 * dwarf-index-write.c (write_psymbols): Update.
1247 * dwarf2loc.c (call_site_to_target_addr): Update.
1248 (func_verify_no_selftailcall): Update.
1249 (tailcall_dump): Update.
1250 (call_site_find_chain_1): Update.
1251 (dwarf_expr_reg_to_entry_parameter): Update.
1252 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1253 * eval.c (evaluate_funcall): Update.
1254 (evaluate_subexp_standard): Update.
1255 (evaluate_subexp_for_sizeof): Update.
1256 * expprint.c (print_subexp_standard): Update.
1257 (dump_subexp_body_standard): Update.
1258 * frame.c (get_prev_frame_always_1): Update.
1259 * frv-tdep.c (frv_skip_main_prologue): Update.
1260 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1261 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1262 (gnuv3_get_typename_from_type_info): Update.
1263 (gnuv3_skip_trampoline): Update.
1264 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1265 * i386-tdep.c (i386_skip_main_prologue): Update.
1266 (i386_pe_skip_trampoline_code): Update.
1267 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1268 * infcall.c (get_function_name): Update.
1269 * linespec.c (minsym_found): Update.
1270 * linux-fork.c (info_checkpoints_command): Update.
1271 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1272 (m32c_m16c_pointer_to_address): Update.
1273 * maint.c (maintenance_translate_address): Update.
1274 * minsyms.c (add_minsym_to_hash_table): Update.
1275 (add_minsym_to_demangled_hash_table): Update.
1276 (lookup_minimal_symbol_mangled): Update.
1277 (lookup_minimal_symbol_demangled): Update.
1278 (lookup_minimal_symbol_linkage): Update.
1279 (lookup_minimal_symbol_text): Update.
1280 (lookup_minimal_symbol_by_pc_name): Update.
1281 (minimal_symbol_is_less_than): Update.
1282 (compact_minimal_symbols): Update.
1283 (build_minimal_symbol_hash_tables): Update.
1284 (find_solib_trampoline_target): Update.
1285 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1286 (mips_skip_pic_trampoline_code): Update.
1287 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1288 * objc-lang.c (info_selectors_command): Update.
1289 (info_classes_command): Update.
1290 (find_methods): Update.
1291 (find_imps): Update.
1292 * p-valprint.c (pascal_val_print): Update.
1293 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1294 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1295 * printcmd.c (build_address_symbolic): Update.
1296 (info_symbol_command): Update.
1297 * psymtab.c (psymbol_name_matches): Update.
1298 (match_partial_symbol): Update.
1299 (lookup_partial_symbol): Update.
1300 (print_partial_symbols): Update.
1301 (sort_pst_symbols): Update.
1302 (maintenance_check_psymtabs): Update.
1303 * python/py-framefilter.c (py_print_frame): Update.
1304 * python/python.c (gdbpy_rbreak): Update.
1305 * record-btrace.c (btrace_get_bfun_name): Update.
1306 (btrace_call_history): Update.
1307 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1308 (rs6000_skip_trampoline_code): Update.
1309 * sol-thread.c (info_cb): Update.
1310 * stabsread.c (scan_file_globals): Update.
1311 * stack.c (find_frame_funname): Update.
1312 (info_frame_command_core): Update.
1313 * symmisc.c (dump_msymbols): Update.
1314 * symtab.c (symbol_natural_name): Rename to..,
1315 (general_symbol_info::natural_name): ...this.
1316 (symbol_demangled_name): Rename to...
1317 (general_symbol_info::demangled_name): ...this.
1318 (symbol_search_name): Rename to...
1319 (general_symbol_info::search_name): ...this.
1320 (symbol_matches_search_name): Update.
1321 (find_pc_sect_line): Update.
1322 (skip_prologue_sal): Update.
1323 (search_symbols): Update.
1324 (print_msymbol_info): Update.
1325 (rbreak_command): Update.
1326 (completion_list_add_msymbol): Update.
1327 (completion_list_objc_symbol): Update.
1328 (get_msymbol_address): Update.
1329 * symtab.h (struct general_symbol_info): Add member functions
1330 natural_name (), linkage_name (), print_name (), demangled_name (),
1331 and search_name ().
1332 (SYMBOL_NATURAL_NAME): Update.
1333 (symbol_natural_name): Move to a member function on general_symbol_info.
1334 (SYMBOL_DEMANGLED_NAME): Update.
1335 (symbol_demangled_name): Move to a member function on
1336 general_symbol_info.
1337 (SYMBOL_SEARCH_NAME): Update.
1338 (symbol_search_name): Move to a member function on general_symbol_info.
1339 (MSYMBOL_NATURAL_NAME): Remove.
1340 (MSYMBOL_LINKAGE_NAME): Remove.
1341 (MSYMBOL_PRINT_NAME): Remove.
1342 (MSYMBOL_DEMANGLED_NAME): Remove.
1343 (MSYMBOL_SEARCH_NAME): Remove.
1344 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1345
13462019-11-22 Christian Biesinger <cbiesinger@google.com>
1347
1348 * symtab.c (create_demangled_names_hash): Use per_bfd->
1349 minimal_symbol_count for computing the initial size, if greater
1350 than our default size.
1351
13522019-11-22 Tom de Vries <tdevries@suse.de>
1353
1354 * contrib/words.sh: Improve words extraction.
1355
13562019-11-22 Tom de Vries <tdevries@suse.de>
1357
1358 * contrib/words.sh: Combine sed invocations.
1359
13602019-11-21 Christian Biesinger <cbiesinger@google.com>
1361
1362 * Makefile.in: Update.
1363 * demangle.c: Rename to...
1364 * gdb-demangle.c: ..this.
1365 (is_cplus_marker): Change return type to bool.
1366 (_initialize_demangler): Rename to...
1367 (_initialize_gdb_demangle): ...this.
1368 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1369 * symtab.h (demangle): Remove declaration; instead include
1370 gdb-demangle.h.
1371
13722019-11-21 Tom Tromey <tromey@adacore.com>
1373
1374 * gdbsupport/format.c (format_pieces): Parse %I64d.
1375 * unittests/format_pieces-selftests.c (test_windows_formats): New
1376 function.
1377 (run_tests): Call it.
1378
13792019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1380
1381 Byte reverse display of variables with DW_END_big, DW_END_little
1382 (DW_AT_endianity) dwarf attributes if different than the native
1383 byte order.
1384 * ada-lang.c (ada_value_binop):
1385 Use type_byte_order instead of gdbarch_byte_order.
1386 * ada-valprint.c (printstr):
1387 (ada_val_print_string):
1388 * ada-lang.c (value_pointer):
1389 (ada_value_binop):
1390 Use type_byte_order instead of gdbarch_byte_order.
1391 * c-lang.c (c_get_string):
1392 Use type_byte_order instead of gdbarch_byte_order.
1393 * c-valprint.c (c_val_print_array):
1394 Use type_byte_order instead of gdbarch_byte_order.
1395 * cp-valprint.c (cp_print_class_member):
1396 Use type_byte_order instead of gdbarch_byte_order.
1397 * dwarf2loc.c (rw_pieced_value):
1398 Use type_byte_order instead of gdbarch_byte_order.
1399 * dwarf2read.c (read_base_type): Handle DW_END_big,
1400 DW_END_little
1401 * f-lang.c (f_get_encoding):
1402 Use type_byte_order instead of gdbarch_byte_order.
1403 * findvar.c (default_read_var_value):
1404 Use type_byte_order instead of gdbarch_byte_order.
1405 * gdbtypes.c (check_types_equal):
1406 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1407 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1408 and TYPE_ENDIANITY_LITTLE if set.
1409 (type_byte_order): new function.
1410 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1411 (struct main_type) <flag_endianity_not_default>:
1412 New field.
1413 (type_byte_order): New function.
1414 * infcmd.c (default_print_one_register_info):
1415 Use type_byte_order instead of gdbarch_byte_order.
1416 * p-lang.c (pascal_printstr):
1417 Use type_byte_order instead of gdbarch_byte_order.
1418 * p-valprint.c (pascal_val_print):
1419 Use type_byte_order instead of gdbarch_byte_order.
1420 * printcmd.c (print_scalar_formatted):
1421 Use type_byte_order instead of gdbarch_byte_order.
1422 * solib-darwin.c (darwin_current_sos):
1423 Use type_byte_order instead of gdbarch_byte_order.
1424 * solib-svr4.c (solib_svr4_r_ldsomap):
1425 Use type_byte_order instead of gdbarch_byte_order.
1426 * stap-probe.c (stap_modify_semaphore):
1427 Use type_byte_order instead of gdbarch_byte_order.
1428 * target-float.c (target_float_same_format_p):
1429 Use type_byte_order instead of gdbarch_byte_order.
1430 * valarith.c (scalar_binop):
1431 (value_bit_index):
1432 Use type_byte_order instead of gdbarch_byte_order.
1433 * valops.c (value_cast):
1434 Use type_byte_order instead of gdbarch_byte_order.
1435 * valprint.c (generic_emit_char):
1436 (generic_printstr):
1437 (val_print_string):
1438 Use type_byte_order instead of gdbarch_byte_order.
1439 * value.c (unpack_long):
1440 (unpack_bits_as_long):
1441 (unpack_value_bitfield):
1442 (modify_field):
1443 (pack_long):
1444 (pack_unsigned_long):
1445 Use type_byte_order instead of gdbarch_byte_order.
1446 * findvar.c (unsigned_pointer_to_address):
1447 (signed_pointer_to_address):
1448 (unsigned_address_to_pointer):
1449 (address_to_signed_pointer):
1450 (default_read_var_value):
1451 (default_value_from_register):
1452 Use type_byte_order instead of gdbarch_byte_order.
1453 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1454 Use type_byte_order instead of gdbarch_byte_order.
1455 * riscv-tdep.c (riscv_print_one_register_info):
1456 Use type_byte_order instead of gdbarch_byte_order.
1457
14582019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1459
1460 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1461 (current_ui_gdb_stdin_ptr): Likewise.
1462 (current_ui_gdb_stderr_ptr): Likewise.
1463 (current_ui_gdb_stdlog_ptr): Likewise.
1464 (current_ui_current_uiout_ptr): Likewise.
1465 (gen_ret_current_ui_field_ptr): Remove.
1466
14672019-11-21 Tom de Vries <tdevries@suse.de>
1468
1469 PR gdb/24956
1470 * cli/cli-script.c (execute_control_command): Only switch to
1471 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1472
14732019-11-19 Tom Tromey <tom@tromey.com>
1474
1475 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1476 Now static. Change type of "name".
1477 (tui_set_win_height_command): Don't copy "arg".
1478 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1479 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1480
14812019-11-19 Ali Tamur <tamur@google.com>
1482
1483 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1484 "if (attr != nullptr)".
1485 (dwarf2_find_base_address): Likewise.
1486 (dwarf2_build_include_psymtabs): Likewise.
1487 (read_cutu_die_from_dwo): Likewise.
1488 (read_func_scope): Likewise.
1489 (read_call_site_scope): Likewise.
1490 (dwarf2_get_pc_bounds): Likewise.
1491 (dwarf2_record_block_ranges): Likewise.
1492 (dwarf2_add_field): Likewise.
1493 (dwarf2_add_member_fn): Likewise.
1494 (read_structure_type): Likewise.
1495 (read_enumeration_type): Likewise.
1496 (read_array_type): Likewise.
1497 (read_array_order): Likewise.
1498 (read_set_type): Likewise.
1499 (read_common_block): Likewise.
1500 (read_tag_reference_type): Likewise.
1501 (read_tag_string_type): Likewise.
1502 (read_subroutine_type): Likewise.
1503 (read_base_type): Likewise.
1504 (read_subrange_type): Likewise.
1505 (new_symbol): Likewise.
1506 (prepare_one_comp_unit): Likewise.
1507
15082019-11-19 Tom Tromey <tromey@adacore.com>
1509
1510 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1511 result in error when DebugActiveProcess fails.
1512
15132019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1514 Pedro Alves <palves@redhat.com>
1515
1516 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1517 * target.c (target_stack::push): Call 'unpush' if there's a
1518 target on top of the stack.
1519
15202019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1521
1522 * python/py-block.c (blpy_dealloc): Call tp_free.
1523 (blpy_block_syms_dealloc): Likewise.
1524 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1525 * python/py-inferior.c (infpy_dealloc): Likewise.
1526 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1527 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1528 * python/py-symbol.c (sympy_dealloc): Likewise.
1529 * python/py-symtab.c (stpy_dealloc): Likewise.
1530 * python/py-type.c (typy_iterator_dealloc): Likewise.
1531
15322019-11-18 Christian Biesinger <cbiesinger@google.com>
1533
1534 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1535 constructor instead of using a class initializer.
1536
15372019-11-15 Christian Biesinger <cbiesinger@google.com>
1538
1539 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1540 * configure: Regenerate.
1541 * configure.ac: Don't source common.host.
1542 * gdbsupport/common.host: Remove.
1543 * gdbsupport/mingw-strerror.c: Remove.
1544 * gdbsupport/posix-strerror.c: Rename to...
1545 * gdbsupport/safe-strerror.c: ...this.
1546
15472019-11-15 Christian Biesinger <cbiesinger@google.com>
1548
1549 * maint.c (scoped_command_stats::print_time): Use localtime_r
1550 instead of localtime (provided through gnulib if necessary).
1551 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1552 of ctime.
1553
15542019-11-15 Christian Biesinger <cbiesinger@google.com>
1555
1556 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1557 avoid compile errors.
1558
15592019-11-15 Christian Biesinger <cbiesinger@google.com>
1560
1561 * config.in: Regenerate.
1562 * configure: Regenerate.
1563 * gdbsupport/common.m4: No longer check for strerror_r.
1564 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1565 POSIX version of strerror_r, now that gnulib provides it if
1566 necessary.
1567
15682019-11-14 Christian Biesinger <cbiesinger@google.com>
1569
1570 * README (`configure' options): Update.
1571
15722019-11-14 Tom Tromey <tromey@adacore.com>
1573
1574 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1575 expected type for the RHS if the LHS is a convenience variable.
1576
15772019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1578
1579 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1580 Provide explicit default and copy constructor.
1581
15822019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1583
1584 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1585 only call Py_INCREF (newbp) in the bppy_pending_object case.
1586
15872019-11-13 Tom Tromey <tromey@adacore.com>
1588
1589 PR build/25182:
1590 * psympriv.h (partial_symbol): Remove static assert.
1591 * symtab.h (general_symbol_info, symbol): Remove static assert.
1592
15932019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1594
1595 * gdbsupport/format.c (format_pieces::format_pieces): Support
1596 printf 'z' size modifier.
1597 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1598 * printcmd.c (ui_printf): Handle size_t_arg.
1599 * ui-out.c (ui_out::vmessage): Likewise.
1600 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1601 function.
1602 (run_tests): Call test_format_int_sizes.
1603
16042019-11-12 Christian Biesinger <cbiesinger@google.com>
1605
1606 * ada-exp.y (write_ambiguous_var): Update.
1607 * buildsym.c (add_symbol_to_list): Update.
1608 * dwarf2read.c (read_variable): Update.
1609 (new_symbol): Update.
1610 * jit.c (finalize_symtab): Update.
1611 * language.c (language_alloc_type_symbol): Update.
1612 * symtab.c (fixup_symbol_section): Update.
1613 (initialize_objfile_symbol_1): Move code to...
1614 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1615 (allocate_symbol): Update.
1616 (allocate_template_symbol): Update.
1617 (get_symbol_address): Update.
1618 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1619 of having as a field, and add a constructor.
1620 (SYMBOL_VALUE): Update.
1621 (SYMBOL_VALUE_ADDRESS): Update.
1622 (SET_SYMBOL_VALUE_ADDRESS): Update.
1623 (SYMBOL_VALUE_BYTES): Update.
1624 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1625 (SYMBOL_BLOCK_VALUE): Update.
1626 (SYMBOL_VALUE_CHAIN): Update.
1627 (SYMBOL_LANGUAGE): Update.
1628 (SYMBOL_SECTION): Update.
1629 (SYMBOL_OBJ_SECTION): Update.
1630 (SYMBOL_SET_LANGUAGE): Update.
1631 (SYMBOL_SET_LINKAGE_NAME): Update.
1632 (SYMBOL_SET_NAMES): Update.
1633 (SYMBOL_NATURAL_NAME): Update.
1634 (SYMBOL_LINKAGE_NAME): Update.
1635 (SYMBOL_DEMANGLED_NAME): Update.
1636 (SYMBOL_SEARCH_NAME): Update.
1637 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1638 (struct symbol): Update.
1639 (struct template_symbol): Update.
1640 (struct rust_vtable_symbol): Update.
1641 * xcoffread.c (SYMBOL_DUP): Update.
1642
16432019-11-12 Tom Tromey <tom@tromey.com>
1644
1645 * tui/tui-layout.c (show_layout): Set current_layout.
1646 (show_source_disasm_command, show_data)
1647 (show_source_or_disasm_and_command): Don't set current_layout.
1648
16492019-11-12 Tom Tromey <tom@tromey.com>
1650
1651 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1652
16532019-11-12 Tom Tromey <tom@tromey.com>
1654
1655 * tui/tui-win.c (resize_message): New global.
1656 (show_tui_resize_message): New function.
1657 (tui_async_resize_screen): Print message if requested.
1658 (_initialize_tui_win): Add tui-resize-message setting.
1659 * NEWS: Add entry for new commands.
1660
16612019-11-11 Tom Tromey <tom@tromey.com>
1662
1663 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1664 functions.
1665
16662019-11-11 Christian Biesinger <cbiesinger@google.com>
1667
1668 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1669
16702019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1671
1672 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1673 function.
1674 * python/python-internal.h (gdbpy_lookup_static_symbols):
1675 Declare new function.
1676 * python/python.c (python_GdbMethods): Add
1677 gdb.lookup_static_symbols method.
1678 * NEWS: Mention gdb.lookup_static_symbols.
1679
16802019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1681
1682 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1683 static block of current object file first. Also fix typo in
1684 header comment.
1685
16862019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1687
1688 * stack.c (set_last_displayed_sal): Delete.
1689 (last_displayed_sal_valid): Delete.
1690 (last_displayed_pspace): Delete.
1691 (last_displayed_addr): Delete.
1692 (last_displayed_symtab): Delete.
1693 (last_displayed_line): Delete.
1694 (class last_displayed_symtab_info_type): New.
1695 (last_displayed_symtab_info): New static global variable.
1696 (print_frame_info): Call methods on last_displayed_symtab_info.
1697 (clear_last_displayed_sal): Update header comment, and make use of
1698 last_displayed_symtab_info.
1699 (last_displayed_sal_is_valid): Likewise.
1700 (get_last_displayed_pspace): Likewise.
1701 (get_last_displayed_addr): Likewise.
1702 (get_last_displayed_symtab): Likewise.
1703 (get_last_displayed_line): Likewise.
1704 (get_last_displayed_sal): Likewise.
1705 * stack.h (clear_last_displayed_sal): Update header comment.
1706 (last_displayed_sal_is_valid): Likewise.
1707 (get_last_displayed_pspace): Likewise.
1708 (get_last_displayed_addr): Likewise.
1709 (get_last_displayed_symtab): Likewise.
1710 (get_last_displayed_line): Likewise.
1711 (get_last_displayed_sal): Likewise.
1712
17132019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1714
1715 * stack.c (frame_show_address): Convert return type to bool.
1716 * stack.h (frame_show_address): Likewise, and update header
1717 comment.
1718
17192019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1720
1721 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1722 * unittests/vec-utils-selftests.c: New file.
1723 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1724
17252019-11-10 Tom Tromey <tom@tromey.com>
1726
1727 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1728 (tui_highlight_win): Likewise.
1729 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1730 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1731 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1732 Don't set can_highlight.
1733
17342019-11-10 Tom Tromey <tom@tromey.com>
1735
1736 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1737 Remove unused declaration.
1738
17392019-11-08 Tom Tromey <tromey@adacore.com>
1740
1741 * top.c (read_command_file): Update.
1742 (command_line_input): Make return type const.
1743 * python/py-gdb-readline.c: Update.
1744 * linespec.c (decode_line_2): Update.
1745 * defs.h (command_line_input): Make return type const.
1746 * cli/cli-script.c (read_next_line): Make return type const.
1747 * ada-lang.c (get_selections): Update.
1748
17492019-11-06 Christian Biesinger <cbiesinger@google.com>
1750
1751 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1752 * mi/mi-main.c (output_cores): Likewise.
1753 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1754 (linux_xfer_osdata_modules): Likewise.
1755 * remote.c (register_remote_support_xml): Likewise.
1756 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1757 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1758
17592019-11-06 Tom Tromey <tom@tromey.com>
1760
1761 * tui/tui-interp.c: Don't include readline.h.
1762 * tui/tui-hooks.c: Don't include readline.h.
1763 * symmisc.c: Include tilde.h, not readline.h.
1764 * symfile.c: Include tilde.h, not readline.h.
1765 * source.c: Include tilde.h, not readline.h.
1766 * solib.c: Include tilde.h, not readline.h.
1767 * psymtab.c: Include tilde.h, not readline.h.
1768 * exec.c: Include tilde.h, not readline.h.
1769 * corelow.c: Include tilde.h, not readline.h.
1770 * cli/cli-dump.c: Include tilde.h, not readline.h.
1771 * cli/cli-cmds.c: Don't include readline.h.
1772
17732019-11-05 Tom Tromey <tom@tromey.com>
1774
1775 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1776 (tui_disassemble): Set addr_size.
1777 (tui_disasm_window::set_contents): Use addr_size.
1778
17792019-11-05 Tom Tromey <tom@tromey.com>
1780
1781 * rust-lang.c (rust_language_defn): Update.
1782 * python/py-value.c (valpy_string): Call c_get_string.
1783 * p-lang.c (pascal_language_defn): Update.
1784 * opencl-lang.c (opencl_language_defn): Update.
1785 * objc-lang.c (objc_language_defn): Update.
1786 * m2-lang.c (m2_language_defn): Update.
1787 * language.c (unknown_language_defn, auto_language_defn): Update.
1788 (default_get_string): Remove.
1789 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1790 * go-lang.c (go_language_defn): Update.
1791 * f-lang.c (f_language_defn): Update.
1792 * d-lang.c (d_language_defn): Update.
1793 * c-lang.c (c_language_defn, cplus_language_defn)
1794 (asm_language_defn, minimal_language_defn): Update.
1795 * ada-lang.c (ada_language_defn): Update.
1796 * language.h (struct language_defn) <la_get_string>: Remove.
1797 (LA_GET_STRING): Remove.
1798 (default_get_string): Don't declare.
1799
18002019-11-05 Tom Tromey <tom@tromey.com>
1801
1802 * tui/tui-source.h (struct tui_source_window): Inline
1803 constructor. Remove destructor.
1804 <style_changed, m_observable>: Move to superclass.
1805 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1806 (struct tui_source_window_base): Move private members to end.
1807 <style_changed, m_observable>: Move from tui_source_window.
1808 * tui/tui-winsource.c (tui_copy_source_line): Move from
1809 tui-source.c. Rename from copy_source_line. Add special handling
1810 for negative line number.
1811 (tui_source_window_base::style_changed): Move from
1812 tui_source_window.
1813 (tui_source_window_base): Register observer.
1814 (~tui_source_window_base): New.
1815 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1816 rename.
1817 (tui_source_window::set_contents): Use tui_copy_source_line.
1818 (tui_source_window::tui_source_window): Move to tui-source.h.
1819 (tui_source_window::~tui_source_window): Remove.
1820 (tui_source_window::style_changed): Move to superclass.
1821 * tui/tui-disasm.c (tui_disassemble): Create string file with
1822 styling, when possible. Add "addr_size" parameter.
1823 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1824 Don't compute maximum size.
1825 (len_without_escapes): New function
1826
18272019-11-05 Tom Tromey <tom@tromey.com>
1828
1829 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1830 std::string.
1831 * tui/tui-winsource.c (tui_show_source_line): Update.
1832 * tui/tui-source.c (tui_source_window::set_contents): Update.
1833 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1834
18352019-11-05 Christian Biesinger <cbiesinger@google.com>
1836
1837 * symtab.h (gdb_static_assert): Put && operator at the beginning
1838 of the line instead of the end.
1839
18402019-11-04 Christian Biesinger <cbiesinger@google.com>
1841
1842 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1843 and sizeof (symbol).
1844 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1845
18462019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1847
1848 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1849 * configure.host: Mark *-*-solaris2.10* obsolete.
1850 * configure.tgt: Mark Solaris < 11 obsolete.
1851 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1852 Update target triplet.
1853
18542019-11-01 Tom Tromey <tromey@adacore.com>
1855
1856 * utils.c (print_sys_errmsg): Simplify.
1857
18582019-11-01 Tom Tromey <tromey@adacore.com>
1859
1860 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1861
18622019-11-01 Christian Biesinger <cbiesinger@google.com>
1863
1864 * configure: Regenerate.
1865 * configure.ac: Remove check for strerror_r.
1866 * gdbsupport/common.m4: Check for strerror_r.
1867
18682019-11-01 Luis Machado <luis.machado@linaro.org>
1869
1870 PR gdb/25124
1871
1872 * arm-tdep.c (arm_per_objfile): Rename to ...
1873 (arm_per_bfd): ... this.
1874 (arm_objfile_data_key): Rename to ...
1875 (arm_bfd_data_key): ... this.
1876 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1877 data.
1878 (arm_record_special_symbol): Likewise.
1879
18802019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1881
1882 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1883 end.
1884 * c-typeprint.c (c_print_typedef): Likewise.
1885 * f-typeprint.c (f_print_typedef): Likewise.
1886 * m2-typeprint.c (m2_print_typedef): Likewise.
1887 * p-typeprint.c (pascal_print_typedef): Likewise.
1888 * rust-lang.c (rust_print_typedef): Likewise.
1889 * symtab.c (print_symbol_info): Print a newline after calling
1890 typedef_print.
1891
18922019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1893
1894 * symtab.c (info_module_cmdlist): New variable.
1895 (info_module_command): New function.
1896 (search_module_symbols): New function.
1897 (info_module_subcommand): New function.
1898 (struct info_modules_var_func_options): New struct.
1899 (info_modules_var_func_options_defs): New variable.
1900 (make_info_modules_var_func_options_def_group): New function.
1901 (info_module_functions_command): New function.
1902 (info_module_variables_command): New function.
1903 (info_module_var_func_command_completer): New function.
1904 (_initialize_symtab): Register new 'info module functions' and
1905 'info module variables' commands.
1906 * symtab.h (typedef symbol_search_in_module): New typedef.
1907 (search_module_symbols): Declare new function.
1908 * NEWS: Mention new commands.
1909
19102019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1911
1912 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1913 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1914 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1915 MODULES_DOMAIN.
1916 (scan_partial_symbols): Only create partial module symbols for non
1917 declarations.
1918 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1919 and MODULES_DOMAIN.
1920 * symtab.c (search_domain_name): Likewise.
1921 (search_symbols): Likewise.
1922 (print_symbol_info): Likewise.
1923 (symtab_symbol_info): Likewise.
1924 (info_modules_command): New function.
1925 (_initialize_symtab): Register 'info modules' command.
1926 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1927 * NEWS: Mention new 'info modules' command.
1928
19292019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1930
1931 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1932 and $_gdb_maint_setting_str.
1933
19342019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1935
1936 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1937 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1938 (str_value_from_setting, gdb_setting_str_internal_fn)
1939 (gdb_maint_setting_str_internal_fn): New functions.
1940 (_initialize_cli_cmds): Define the new convenience functions.
1941 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1942 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1943
19442019-10-31 Christian Biesinger <cbiesinger@google.com>
1945
1946 * agent.c (set_can_use_agent): When the setting is turned on,
1947 look up agent symbols if we don't have them yet.
1948 (agent_new_objfile): Don't look up agent symbols when the agent
1949 setting is off.
1950
19512019-10-31 Christian Biesinger <cbiesinger@google.com>
1952
1953 * config.in: Regenerate.
1954
19552019-10-31 Christian Biesinger <cbiesinger@google.com>
1956
1957 * configure: Regenerate.
1958 * configure.ac: Check for strerror_r.
1959 * gdbsupport/common-utils.h (safe_strerror): Change return value
1960 to const char * and document that this function is now threadsafe.
1961 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1962 thread_local and call strerror_r, if available.
1963 * utils.c (perror_string): Update.
1964 (print_sys_errmsg): Update.
1965
19662019-10-31 Luis Machado <luis.machado@linaro.org>
1967
1968 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1969 objfile_key.
1970 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1971 objfile to fetch per-bfd data.
1972 (arm_find_exidx_entry): Likewise.
1973
19742019-10-31 Christian Biesinger <cbiesinger@google.com>
1975
1976 * gdbsupport/agent.c (debug_agent): Change type to bool.
1977 (use_agent): Likewise.
1978 (all_agent_symbols_look_up): Likewise.
1979 (agent_loaded_p): Change return value to bool.
1980 (agent_look_up_symbols): Update.
1981 (agent_capability_check): Change return value to bool.
1982 * gdbsupport/agent.h (agent_loaded_p): Likewise.
1983 (debug_agent): Change type to bool.
1984 (use_agent): Likewise.
1985 (agent_capability_check): Change return value to bool.
1986
19872019-10-30 Christian Biesinger <cbiesinger@google.com>
1988
1989 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1990 (build_minimal_symbol_hash_tables): Code to clear the table moved
1991 to clear_minimal_symbol_hash_tables.
1992 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1993 when needed.
1994
19952019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1996
1997 * infcmd.c: Remove includes.
1998 * infrun.c: Remove includes.
1999
20002019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2001
2002 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2003 (grow_vect): Remove declaration.
2004 (ada_type_of_array): Remove declaration.
2005 (ada_update_initial_language): Remove declaration.
2006 (ada_fold_name): Remove declaration.
2007 (ada_fill_in_ada_prototype): Remove declaration.
2008 (user_select_syms): Remove declaration.
2009 (get_selections): Remove declaration.
2010 (ada_tag_type): Remove declaration.
2011 (ada_value_tag): Remove declaration.
2012 (ada_is_others_clause): Remove declaration.
2013 (ada_in_variant): Remove declaration.
2014 (ada_value_struct_elt): Remove declaration.
2015 (ada_attribute_name): Remove declaration.
2016 (ada_system_address_type): Remove declaration.
2017 * ada-lang.c (ada_watch_location_expression): Make static.
2018 (GROW_VECT): Move here from ada-lang.h.
2019 (grow_vect): Make static.
2020 (ada_update_initial_language): Make static.
2021 (ada_fold_name): Make static.
2022 (ada_type_of_array): Make static.
2023 (encoded_ordered_before): Move up.
2024 (sort_choices): Move up.
2025 (print_signatures): Move up.
2026 (ada_print_symbol_signature): Move up.
2027 (get_selections): Move up and make static.
2028 (user_select_syms): Move up and make static.
2029 (ada_value_struct_elt): Move up and make static.
2030 (ada_tag_type): Make static.
2031 (ada_value_tag): Make static.
2032 (ada_is_others_clause): Make static.
2033 (ada_in_variant): Make static.
2034 (ada_attribute_name): Make static.
2035
20362019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2037
2038 * ada-lang.c: Remove includes.
2039 * ada-typeprint.c: Remove includes.
2040 * ada-valprint.c: Remove includes.
2041
20422019-10-29 Simon Marchi <simon.marchi@efficios.com>
2043
2044 * addrmap.c: Add static assertions of type size, moved from
2045 _initialize_addrmap.
2046 (_initialize_addrmap): Remove.
2047
20482019-10-29 Christian Biesinger <cbiesinger@google.com>
2049
2050 * coffread.c (record_minimal_symbol): Update.
2051 (process_coff_symbol): Update.
2052 * dbxread.c (read_dbx_symtab): Update.
2053 * dwarf2read.c (add_partial_symbol): Update.
2054 (fixup_go_packaging): Update.
2055 (load_partial_dies): Update.
2056 (new_symbol): Update.
2057 * elfread.c (record_minimal_symbol): Change signature to use
2058 gdb::string_view instead of name+len.
2059 (elf_symtab_read): Update.
2060 (elf_rel_plt_read): Update.
2061 * mdebugread.c (parse_partial_symbols): Update.
2062 (handle_psymbol_enumerators): Update.
2063 (new_symbol): Update.
2064 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2065 to use gdb::string_view instead of name+len.
2066 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2067 * psympriv.h (add_psymbol_to_list): Likewise.
2068 * psymtab.c (add_psymbol_to_bcache): Likewise.
2069 (add_psymbol_to_list): Likewise.
2070 * stabsread.c (define_symbol): Update.
2071 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2072 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2073 (symbol_set_names): Likewise.
2074 * xcoffread.c (scan_xcoff_symtab): Update.
2075
20762019-10-29 Christian Biesinger <cbiesinger@google.com>
2077
2078 * symtab.h (symbol_set_names): Document that copy_name must be
2079 set to true for non-nullterminated strings.
2080 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2081 linkage_name if the entry was not found and we need to demangle.
2082
20832019-10-29 Christian Biesinger <cbiesinger@google.com>
2084
2085 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2086 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2087 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2088 * gdbsupport/gdb_binary_search.h: New file.
2089
20902019-10-29 Christian Biesinger <cbiesinger@google.com>
2091
2092 * NEWS: Mention new --with-system-gdbinit-dir option.
2093 * config.in: Regenerate.
2094 * configure: Regenerate.
2095 * configure.ac: Add new option --with-system-gdbinit-dir.
2096 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2097 for a ".gdb" suffix.
2098 * main.c (get_init_files): Change system_gdbinit argument to
2099 a vector and return the files in SYSTEM_GDBINIT_DIR in
2100 addition to SYSTEM_GDBINIT.
2101 (captured_main_1): Update.
2102 (print_gdb_help): Update.
2103 * top.c (print_gdb_configuration): Also print the value of
2104 SYSTEM_GDBINIT_DIR.
2105
21062019-10-28 Christian Biesinger <cbiesinger@google.com>
2107
2108 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2109 that takes gdb::string_view arguments.
2110
21112019-10-26 Tom de Vries <tdevries@suse.de>
2112
2113 * aarch64-linux-tdep.c: Fix typos in comments.
2114 * aarch64-tdep.c: Same.
2115 * ada-lang.c: Same.
2116 * amd64-nat.c: Same.
2117 * arc-tdep.c: Same.
2118 * arch/aarch64-insn.c: Same.
2119 * block.c: Same.
2120 * breakpoint.h: Same.
2121 * btrace.h: Same.
2122 * c-varobj.c: Same.
2123 * cli/cli-decode.c: Same.
2124 * cli/cli-script.c: Same.
2125 * cli/cli-utils.h: Same.
2126 * coff-pe-read.c: Same.
2127 * coffread.c: Same.
2128 * compile/compile-cplus-symbols.c: Same.
2129 * compile/compile-object-run.c: Same.
2130 * completer.c: Same.
2131 * corelow.c: Same.
2132 * cp-support.c: Same.
2133 * demangle.c: Same.
2134 * dwarf-index-write.c: Same.
2135 * dwarf2-frame.c: Same.
2136 * dwarf2-frame.h: Same.
2137 * eval.c: Same.
2138 * frame-base.h: Same.
2139 * frame.h: Same.
2140 * gdbcmd.h: Same.
2141 * gdbtypes.h: Same.
2142 * gnu-nat.c: Same.
2143 * guile/scm-objfile.c: Same.
2144 * i386-tdep.c: Same.
2145 * i386-tdep.h: Same.
2146 * infcall.c: Same.
2147 * infcall.h: Same.
2148 * linux-nat.c: Same.
2149 * m68k-tdep.c: Same.
2150 * macroexp.c: Same.
2151 * memattr.c: Same.
2152 * mi/mi-cmd-disas.c: Same.
2153 * mi/mi-getopt.h: Same.
2154 * mi/mi-main.c: Same.
2155 * minsyms.c: Same.
2156 * nat/aarch64-sve-linux-sigcontext.h: Same.
2157 * objfiles.h: Same.
2158 * ppc-linux-nat.c: Same.
2159 * ppc-linux-tdep.c: Same.
2160 * ppc-tdep.h: Same.
2161 * progspace.h: Same.
2162 * prologue-value.h: Same.
2163 * python/py-evtregistry.c: Same.
2164 * python/py-instruction.h: Same.
2165 * record-btrace.c: Same.
2166 * record-full.c: Same.
2167 * remote.c: Same.
2168 * rs6000-tdep.c: Same.
2169 * ser-tcp.c: Same.
2170 * sol-thread.c: Same.
2171 * sparc-sol2-tdep.c: Same.
2172 * sparc64-tdep.c: Same.
2173 * stabsread.c: Same.
2174 * symfile.c: Same.
2175 * symtab.h: Same.
2176 * target.c: Same.
2177 * tracepoint.c: Same.
2178 * tui/tui-data.h: Same.
2179 * tui/tui-io.c: Same.
2180 * tui/tui-win.c: Same.
2181 * tui/tui.c: Same.
2182 * unittests/rsp-low-selftests.c: Same.
2183 * user-regs.h: Same.
2184 * utils.c: Same.
2185 * utils.h: Same.
2186 * valarith.c: Same.
2187 * valops.c: Same.
2188 * valprint.c: Same.
2189 * valprint.h: Same.
2190 * value.c: Same.
2191 * value.h: Same.
2192 * varobj.c: Same.
2193 * x86-nat.h: Same.
2194 * xtensa-tdep.c: Same.
2195
21962019-10-25 Ali Tamur <tamur@google.com>
2197
2198 * charset.c (find_charset_names): Reflect API change.
2199
22002019-10-25 Christian Biesinger <cbiesinger@google.com>
2201
2202 * symtab.c (struct demangled_name_entry): Change demangled name
2203 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2204 part of the struct anymore.
2205 (symbol_set_names): No longer obstack allocate + copy the demangled
2206 name, just store the allocated name from bfd.
2207
22082019-10-25 Tom Tromey <tromey@adacore.com>
2209
2210 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2211 (bsearch_cie_cmp, add_cie): Remove.
2212 (find_cie): Reimplement.
2213 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2214 (dwarf2_build_frame_info): Update.
2215
22162019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2217
2218 PR gdb/25126
2219 * symfile.c (reread_symbols): Call forget_cached_source_info to
2220 clear the stale source cache.
2221
22222019-10-24 Christian Biesinger <cbiesinger@google.com>
2223
2224 * configure: Regenerate.
2225 * configure.ac: Remove code that sets python_has_threads.
2226
22272019-10-24 Christian Biesinger <cbiesinger@google.com>
2228
2229 * config.in: Regenerate.
2230 * configure: Regenerate.
2231 * configure.ac: Remove the code that uses sed to get the python
2232 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2233
22342019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2235
2236 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2237 error paths.
2238
22392019-10-23 Tom Tromey <tom@tromey.com>
2240
2241 * arc-tdep.c: Remove ".." from include.
2242 * frv-tdep.c: Remove ".." from include.
2243 * lm32-tdep.c: Remove ".." from include.
2244 * microblaze-tdep.c: Remove ".." from include.
2245 * or1k-tdep.h: Remove ".." from include.
2246 * s12z-tdep.c: Remove ".." from include.
2247 * Makefile.in (OPCODES_CFLAGS): Add comment.
2248 (TOP_CFLAGS): New variable.
2249 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2250
22512019-10-23 Tom Tromey <tom@tromey.com>
2252
2253 * Makefile.in (READLINE_DIR): Update.
2254
22552019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2256
2257 * infcall.c (call_function_by_hand_dummy): Fix the function
2258 comment. And extract out a code section into...
2259 (reserve_stack_space): ...this new function.
2260
22612019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2262
2263 * infcall.c (value_arg_coerce): Remove an unused parameter.
2264 (call_function_by_hand_dummy): Update the call to
2265 'value_arg_coerce'.
2266
22672019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2268
2269 * infcall.c (call_function_by_hand_dummy): Refactor.
2270
22712019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2272
2273 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2274
22752019-10-23 Tom Tromey <tom@tromey.com>
2276
2277 * configure: Rebuild.
2278 * configure.ac: Don't check for sigprocmask.
2279 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2280
22812019-10-23 Tom Tromey <tom@tromey.com>
2282
2283 * configure: Rebuild.
2284 * acinclude.m4: Use m4_include, not sinclude.
2285
22862019-10-23 Tom de Vries <tdevries@suse.de>
2287
2288 PR breakpoints/24687
2289 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2290
22912019-10-22 Christian Biesinger <cbiesinger@google.com>
2292
2293 * symtab.c (struct demangled_name_entry) <language>: Change from
2294 bitfield to regular variable.
2295
22962019-10-22 Christian Biesinger <cbiesinger@google.com>
2297
2298 * symtab.c (struct demangled_name_entry): Add a constructor.
2299 (free_demangled_name_entry): New function to call the destructor
2300 for demangled_name_entry.
2301 (create_demangled_names_hash): Pass free_demangled_name_entry to
2302 htab_create_alloc.
2303 (symbol_set_names): Call placement new for demangled_name_entry.
2304 * utils.c: No longer include xxhash.h here, now that fast_hash
2305 is inlined in the header.
2306 * utils.h: Instead, include it here.
2307
23082019-10-22 Christian Biesinger <cbiesinger@google.com>
2309
2310 * Makefile.in: Link with libxxhash.
2311 * config.in: Regenerate.
2312 * configure: Regenerate.
2313 * configure.ac: Search for libxxhash.
2314 * utils.c (fast_hash): Use xxhash if present.
2315
23162019-10-22 Christian Biesinger <cbiesinger@google.com>
2317
2318 * utils.h (fast_hash): New function.
2319 * symtab.c (hash_demangled_name_entry): Call new function
2320 fast_hash.
2321
23222019-10-22 Christian Biesinger <cbiesinger@google.com>
2323
2324 * symtab.c (struct demangled_name_entry): Change type of mangled
2325 to gdb::string_view. Also adds a constructor that takes the
2326 mangled name.
2327 (hash_demangled_name_entry): Update.
2328 (eq_demangled_name_entry): Update.
2329 (free_demangled_name_entry): New function to call the destructor
2330 now that this is not a POD anymore.
2331 (create_demangled_names_hash): Pass free_demangled_name_entry to
2332 htab_create_alloc.
2333 (symbol_set_names): Update.
2334
23352019-10-21 Ali Tamur <tamu@google.com>
2336
2337 * dwarf2read.c (dir_index): Change type.
2338 (file_name_index): Likewise.
2339 (line_header::include_dir_at): Change comment and implementation on
2340 whether it is DWARF 5.
2341 (line_header::is_valid_file_index): New function.
2342 (line_header::file_name_at): Change comment and implementation on
2343 whether it is DWARF 5.
2344 (line_header::file_names): Change to private field renamed as
2345 m_file_names and introduce a new accessor method.
2346 (line_header::file_names_size): New method.
2347 (line_header::include_dirs): Change to private field and rename as
2348 m_include_dirs.
2349 (dw2_get_file_names_reader): Define local var at a smaller scope and
2350 reflect API change.
2351 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2352 (process_structure_scope): Likewise.
2353 (line_header::add_include_dir): Change message and reflect renaming.
2354 (line_header::add_file_name): Likewise.
2355 (read_formatted_entries): Handle DW_FORM_data16.
2356 (dwarf_decode_line_header): Fix line header length calculation.
2357 (psymtab_include_file_name): Change comment and API.
2358 (lnp_state_machine::m_file): Update comment and reflect type change.
2359 (lnp_state_machine::record_line): Reflect type change.
2360 (dwarf_decode_lines): Reflect API change.
2361 (file_file_name): Likewise.
2362 (file_full_name): Likewise.
2363
23642019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2365
2366 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2367
23682019-10-21 Tom Tromey <tom@tromey.com>
2369
2370 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2371
23722019-10-21 Tom Tromey <tom@tromey.com>
2373
2374 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2375 NM_H. Use AC_CONFIG_LINKS.
2376 * configure: Rebuild.
2377 * Makefile.in (NM_H): New variable.
2378 (generated_files): Add NM_H. Remove gcore.
2379 (nm.h, stamp-nmh): New targets.
2380
23812019-10-20 Tom Tromey <tom@tromey.com>
2382
2383 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2384 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2385 obsolete comment.
2386 (put_objfile_before): Now static.
2387
23882019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2389
2390 * gdbsupport/common-utils.h (startswith): Change return type to
2391 bool.
2392
23932019-10-19 Christian Biesinger <cbiesinger@google.com>
2394
2395 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2396 * breakpoint.c (bp_locations_compare): Rename to...
2397 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2398 (update_global_location_list): Use std::sort instead of qsort.
2399 * buildsym.c (compare_line_numbers): Rename to...
2400 (lte_is_less_than): ...this, and change to std::sort semantics.
2401 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2402 instead of qsort.
2403 * disasm.c (compare_lines): Rename to...
2404 (line_is_less_than): ...this, and change to std::sort semantics.
2405 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2406 of qsort.
2407 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2408 (fde_is_less_than): ...this, and change to std::sort semantics.
2409 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2410 * mdebugread.c (compare_blocks):
2411 (block_is_less_than): ...this, and change to std::sort semantics.
2412 (sort_blocks): Call std::sort instead of qsort.
2413 * objfiles.c (qsort_cmp): Rename to...
2414 (sort_cmp): ...this, and change to std::sort semantics.
2415 (update_section_map): Call std::sort instead of qsort.
2416 * remote.c (compare_pnums): Remove.
2417 (map_regcache_remote_table): Call std::sort instead of qsort.
2418 * utils.c (compare_positive_ints): Remove.
2419 * utils.h (compare_positive_ints): Remove.
2420 * xcoffread.c (compare_lte): Remove.
2421 (arrange_linetable): Call std::sort instead of qsort.
2422
24232019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2424
2425 * symfile.c (init_entry_point_info): Fix typo.
2426 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2427
24282019-10-18 Tom de Vries <tdevries@suse.de>
2429
2430 * aarch64-tdep.c: Fix typos in comments.
2431 * ada-lang.c: Same.
2432 * ada-tasks.c: Same.
2433 * alpha-tdep.c: Same.
2434 * alpha-tdep.h: Same.
2435 * amd64-nat.c: Same.
2436 * amd64-windows-tdep.c: Same.
2437 * arc-tdep.c: Same.
2438 * arc-tdep.h: Same.
2439 * arch-utils.c: Same.
2440 * arm-nbsd-tdep.c: Same.
2441 * arm-tdep.c: Same.
2442 * ax-gdb.c: Same.
2443 * blockframe.c: Same.
2444 * btrace.c: Same.
2445 * c-varobj.c: Same.
2446 * coff-pe-read.c: Same.
2447 * coffread.c: Same.
2448 * cris-tdep.c: Same.
2449 * darwin-nat.c: Same.
2450 * dbxread.c: Same.
2451 * dcache.c: Same.
2452 * disasm.c: Same.
2453 * dtrace-probe.c: Same.
2454 * dwarf-index-write.c: Same.
2455 * dwarf2-frame-tailcall.c: Same.
2456 * dwarf2-frame.c: Same.
2457 * dwarf2read.c: Same.
2458 * eval.c: Same.
2459 * exceptions.c: Same.
2460 * fbsd-tdep.c: Same.
2461 * findvar.c: Same.
2462 * frame.c: Same.
2463 * frv-tdep.c: Same.
2464 * gnu-v3-abi.c: Same.
2465 * go32-nat.c: Same.
2466 * h8300-tdep.c: Same.
2467 * hppa-tdep.c: Same.
2468 * i386-linux-tdep.c: Same.
2469 * i386-tdep.c: Same.
2470 * ia64-libunwind-tdep.c: Same.
2471 * ia64-tdep.c: Same.
2472 * infcmd.c: Same.
2473 * infrun.c: Same.
2474 * linespec.c: Same.
2475 * linux-nat.c: Same.
2476 * linux-thread-db.c: Same.
2477 * machoread.c: Same.
2478 * mdebugread.c: Same.
2479 * mep-tdep.c: Same.
2480 * mn10300-tdep.c: Same.
2481 * namespace.c: Same.
2482 * objfiles.c: Same.
2483 * opencl-lang.c: Same.
2484 * or1k-tdep.c: Same.
2485 * osabi.c: Same.
2486 * ppc-linux-nat.c: Same.
2487 * ppc-linux-tdep.c: Same.
2488 * ppc-sysv-tdep.c: Same.
2489 * printcmd.c: Same.
2490 * procfs.c: Same.
2491 * record-btrace.c: Same.
2492 * record-full.c: Same.
2493 * remote-fileio.c: Same.
2494 * remote.c: Same.
2495 * rs6000-tdep.c: Same.
2496 * s12z-tdep.c: Same.
2497 * score-tdep.c: Same.
2498 * ser-base.c: Same.
2499 * ser-go32.c: Same.
2500 * skip.c: Same.
2501 * sol-thread.c: Same.
2502 * solib-svr4.c: Same.
2503 * solib.c: Same.
2504 * source.c: Same.
2505 * sparc-nat.c: Same.
2506 * sparc-sol2-tdep.c: Same.
2507 * sparc-tdep.c: Same.
2508 * sparc64-tdep.c: Same.
2509 * stabsread.c: Same.
2510 * stack.c: Same.
2511 * symfile.c: Same.
2512 * symtab.c: Same.
2513 * target-descriptions.c: Same.
2514 * target-float.c: Same.
2515 * thread.c: Same.
2516 * utils.c: Same.
2517 * valops.c: Same.
2518 * valprint.c: Same.
2519 * value.c: Same.
2520 * varobj.c: Same.
2521 * windows-nat.c: Same.
2522 * xcoffread.c: Same.
2523 * xstormy16-tdep.c: Same.
2524 * xtensa-tdep.c: Same.
2525
25262019-10-17 Tom Tromey <tromey@adacore.com>
2527
2528 * configure: Rebuild.
2529 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2530 in AC_CONFIG_FILES invocation.
2531 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2532 new-style config.status invocation.
2533
25342019-10-17 Tom de Vries <tdevries@suse.de>
2535
2536 * arm-nbsd-nat.c: Fix typos in comments.
2537 * arm-tdep.c: Same.
2538 * darwin-nat-info.c: Same.
2539 * dwarf2read.c: Same.
2540 * elfread.c: Same.
2541 * event-top.c: Same.
2542 * findvar.c: Same.
2543 * gdbtypes.c: Same.
2544 * hppa-tdep.c: Same.
2545 * i386-tdep.c: Same.
2546 * jit.c: Same.
2547 * main.c: Same.
2548 * mdebugread.c: Same.
2549 * moxie-tdep.c: Same.
2550 * nto-procfs.c: Same.
2551 * osabi.c: Same.
2552 * ppc-linux-tdep.c: Same.
2553 * remote.c: Same.
2554 * riscv-tdep.c: Same.
2555 * s390-tdep.c: Same.
2556 * sh-tdep.c: Same.
2557 * sparc-linux-tdep.c: Same.
2558 * sparc-nat.c: Same.
2559 * stack.c: Same.
2560 * target-descriptions.c: Same.
2561 * top.c: Same.
2562 * varobj.c: Same.
2563
25642019-10-16 Tom Tromey <tom@tromey.com>
2565
2566 * objfiles.h (struct objfile) <original_name>: Now const.
2567
25682019-10-16 Christian Biesinger <cbiesinger@google.com>
2569
2570 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2571 pass on to sigsetjmp's second argument.
2572 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2573
25742019-10-16 Keith Seitz <keiths@redhat.com>
2575
2576 PR gdb/23567
2577 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2578 sections whose size is greater than the file size.
2579
25802019-10-16 Jim Wilson <jimw@sifive.com>
2581
2582 * riscv-tdep.c (riscv_gcc_target_options): New.
2583 (riscv_gnu_triplet_regexp): New.
2584 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2585 set_gdbarch_gnu_triplet_regexp.
2586
25872019-10-16 Christian Biesinger <cbiesinger@google.com>
2588
2589 * Makefile.in: Add xml-builtin.h.
2590 * features/feature_to_c.sh: Add an include for xml-builtin.h
2591 to ensure that the compiler checks that the types match.
2592 * xml-builtin.h: New file.
2593 * xml-support.c (fetch_xml_builtin): Add missing const.
2594 * xml-support.h: Remove declaration of xml_builtins.
2595
25962019-10-16 Tom de Vries <tdevries@suse.de>
2597
2598 PR tdep/25096
2599 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2600 (amd64_classify_aggregate): ... here.
2601 (amd64_classify_aggregate_field): Handled fiels of nested structs
2602 recursively.
2603
26042019-10-16 Tom de Vries <tdevries@suse.de>
2605
2606 PR tdep/24104
2607 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2608 that handles 'theclass'.
2609
26102019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2611
2612 * linespec.c (decode_digits_ordinary): Update comment.
2613 * make-target-delegates: No longer need to handle VEC case.
2614 * memrange.c (normalize_mem_ranges): Update comment.
2615 * namespace.c (add_using_directive): Update comment.
2616 * objc-lang.c (uniquify_strings): Update comment.
2617 * ppc-linux-nat.c (struct thread_points): Update comment.
2618 * probe.h (find_probes_in_objfile): Update comment.
2619 * target.h (enum flash_preserve_mode): Update comment.
2620 * varobj.c (varobj_restrict_range): Update comment.
2621 * varobj.h (varobj_list_children): Update comment.
2622
26232019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2624
2625 * Makefile.in: Remove references to vec.h and vec.c.
2626 * aarch64-tdep.c: No longer include vec.h.
2627 * ada-lang.c: Likewise.
2628 * ada-lang.h: Likewise.
2629 * arm-tdep.c: Likewise.
2630 * ax.h: Likewise.
2631 * breakpoint.h: Likewise.
2632 * charset.c: Likewise.
2633 * cp-support.h: Likewise.
2634 * dtrace-probe.c: Likewise.
2635 * dwarf2read.c: Likewise.
2636 * extension.h: Likewise.
2637 * gdb_bfd.c: Likewise.
2638 * gdbsupport/gdb_vecs.h: Likewise.
2639 * gdbsupport/vec.c: Remove.
2640 * gdbsupport/vec.h: Remove.
2641 * gdbthread.h: Likewise.
2642 * guile/scm-type.c: Likewise.
2643 * inline-frame.c: Likewise.
2644 * machoread.c: Likewise.
2645 * memattr.c: Likewise.
2646 * memrange.h: Likewise.
2647 * namespace.h: Likewise.
2648 * nat/linux-btrace.h: Likewise.
2649 * osdata.c: Likewise.
2650 * parser-defs.h: Likewise.
2651 * progspace.h: Likewise.
2652 * python/py-type.c: Likewise.
2653 * record-btrace.c: Likewise.
2654 * rust-exp.y: Likewise.
2655 * solib-target.c: Likewise.
2656 * stap-probe.c: Likewise.
2657 * target-descriptions.c: Likewise.
2658 * target-memory.c: Likewise.
2659 * target.h: Likewise.
2660 * varobj.c: Likewise.
2661 * varobj.h: Likewise.
2662 * xml-support.h: Likewise.
2663
26642019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2665
2666 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2667 Update for new std::vector based implementation.
2668 (process_psymtab_comp_unit_reader): Likewise.
2669 (scan_partial_symbols): Likewise.
2670 (recursively_compute_inclusions): Likewise.
2671 (compute_compunit_symtab_includes): Likewise.
2672 (process_imported_unit_die): Likewise.
2673 (queue_and_load_dwo_tu): Likewise.
2674 (follow_die_sig_1): Likewise.
2675 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2676 (typedef dwarf2_per_cu_ptr): Remove.
2677 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2678 function.
2679 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2680 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2681 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2682 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2683 std::vector.
2684
26852019-10-15 Tom Tromey <tromey@adacore.com>
2686
2687 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2688 TID.
2689
26902019-10-15 Tom Tromey <tromey@adacore.com>
2691
2692 * windows-nat.c (windows_nat_target::fetch_registers)
2693 (windows_nat_target::store_registers): Rename "pid" to "tid".
2694
26952019-10-15 Tom Tromey <tromey@adacore.com>
2696
2697 * gdbarch.h, gdbarch.c: Rebuild.
2698 * gdbarch.sh (gcc_target_options): Change return type to
2699 std::string.
2700 * compile/compile.c (get_args): Update.
2701 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2702 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2703 std::string.
2704 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2705 std::string.
2706 * arch-utils.c (default_gcc_target_options): Return std::string.
2707 * arch-utils.h (default_gcc_target_options): Return std::string.
2708 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2709
27102019-10-15 Christian Biesinger <cbiesinger@google.com>
2711
2712 * breakpoint.c (breakpoint_chain): Make static.
2713 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2714 of accessing breakpoint_chain.
2715
27162019-10-15 Christian Biesinger <cbiesinger@google.com>
2717
2718 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2719 to a gdb::function_view and return value to bool.
2720 * breakpoint.h (iterate_over_breakpoints): Likewise.
2721 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2722 (pop_dummy_frame): Update.
2723 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2724 (gdbscm_breakpoints): Update.
2725 * python/py-breakpoint.c (build_bp_list): Update.
2726 (gdbpy_breakpoints): Update.
2727 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2728 Update.
2729 (bpfinishpy_handle_stop): Update.
2730 (bpfinishpy_handle_exit): Update.
2731 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2732 (svr4_update_solib_event_breakpoints): Update.
2733
27342019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2735
2736 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2737 when unwrapping single-field structs.
2738
27392019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2740
2741 * dwarf2read.c: Remove includes.
2742
27432019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2744
2745 * ui-out.c (ui_out::call_do_message): Silence
2746 -Wformat-nonliteral warning.
2747
27482019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2749
2750 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2751 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2752 include: readline/tilde.h.
2753
27542019-10-12 Christian Biesinger <cbiesinger@google.com>
2755
2756 * remote.c (remote_target::get_trace_status): Remove declaration of
2757 trace_regblock_size.
2758
27592019-10-12 Christian Biesinger <cbiesinger@google.com>
2760
2761 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2762 (show_user): Remove declaration of cmdlist.
2763 * cli/cli-cmds.h (max_user_call_depth): Declare.
2764 * cli/cli-script.c (execute_user_command): Remove declaration
2765 of max_user_call_depth.
2766
27672019-10-11 Jim Wilson <jimw@sifive.com>
2768
2769 * gdbsupport/print-utils.h (pulongest): Fix comment.
2770 (plongest): Likewise.
2771 (phex): Add missing comment, mention leading zeros.
2772 (phex_nz): Add mention of no leading zeros to comment.
2773
2774 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2775 plongest instead of unsigned long long cast.
2776
27772019-10-10 Christian Biesinger <cbiesinger@google.com>
2778
2779 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2780 for external_editor_command and gdbtk_test.
2781
27822019-10-10 Christian Biesinger <cbiesinger@google.com>
2783
2784 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2785 * varobj.c (varobjdebug): Move comment to...
2786 * varobj.h (varobjdebug): ...here, and declare.
2787
27882019-10-09 Tom Tromey <tom@tromey.com>
2789
2790 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2791 erase_data_content.
2792
27932019-10-09 Tom Tromey <tom@tromey.com>
2794
2795 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2796 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2797 * tui/tui-command.c (tui_cmd_window::resize)
2798 (tui_refresh_cmd_win): Update.
2799 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2800 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2801 * tui/tui-data.c (~tui_gen_win_info): Remove.
2802 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2803 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2804 (tui_redisplay_readline, tui_mld_flush)
2805 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2806 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2807 (tui_data_window::erase_data_content)
2808 (tui_data_item_window::rerender)
2809 (tui_data_item_window::refresh_window): Update.
2810 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2811 (box_win, tui_gen_win_info::make_window)
2812 (tui_gen_win_info::make_visible): Update.
2813 (tui_delete_win): Remove.
2814 * tui/tui-winsource.c
2815 (tui_source_window_base::do_erase_source_content): Update.
2816 (tui_show_source_line, tui_source_window_base::update_tab_width)
2817 (tui_source_window_base::update_exec_info): Update.
2818 * tui/tui-data.h (struct curses_deleter): New.
2819 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2820 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2821
28222019-10-09 Tom Tromey <tom@tromey.com>
2823
2824 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2825
28262019-10-09 Tom Tromey <tom@tromey.com>
2827
2828 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2829 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2830
28312019-10-09 Tom Tromey <tom@tromey.com>
2832
2833 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2834 window height directly.
2835 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2836 declare.
2837 * tui/tui-layout.c (tui_default_win_height): Remove.
2838 (tui_default_win_viewport_height): Remove.
2839
28402019-10-09 Tom Tromey <tom@tromey.com>
2841
2842 * tui/tui.h: Remove comments.
2843
28442019-10-09 Tom de Vries <tdevries@suse.de>
2845
2846 * python/lib/gdb/printer/bound_registers.py: Use
2847 '^builtin_type_bound128' as regexp argument for
2848 add_builtin_pretty_printer.
2849
28502019-10-09 Christian Biesinger <cbiesinger@google.com>
2851
2852 * guile/guile.c (guile_extension_script_ops): Remove forward
2853 declaration and mark as static.
2854 (guile_script_ops): Likewise.
2855 (extension_language_guile): Move further down in the file so
2856 it can reference the definitions for guile_{extension_,}script_ops.
2857
28582019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2859
2860 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2861 except SORTL, DFLTCC, and KDSA.
2862
28632019-10-08 Tom Tromey <tromey@adacore.com>
2864
2865 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2866 (struct safe_symbol_file_add_args): Remove.
2867
28682019-10-08 Tom Tromey <tromey@adacore.com>
2869
2870 * windows-nat.c: Don't include buildsym-legacy.h.
2871
28722019-10-08 Tom Tromey <tromey@adacore.com>
2873
2874 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2875
28762019-10-08 Christian Biesinger <cbiesinger@google.com>
2877
2878 * gdbtypes.c (overload_debug): Move comment to header.
2879 * gdbtypes.h (overload_debug): Declare.
2880 * valops.c: Remove declaration of overload_debug, instead
2881 include gdbtypes.h.
2882
28832019-10-08 Christian Biesinger <cbiesinger@google.com>
2884
2885 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2886 through _().
2887 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2888 move comment...
2889 * language.h (lang_frame_mismatch_warn): ... here. Also add
2890 declaration.
2891 * top.c (lang_frame_mismatch_warn): Remove declaration.
2892 (check_frame_language_change): Pass lang_frame_mismatch_warn
2893 through _().
2894
28952019-10-07 Christian Biesinger <cbiesinger@google.com>
2896
2897 * c-lang.h (vtbl_ptr_name): Declare.
2898 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2899 it from the header.
2900 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2901
29022019-10-07 Christian Biesinger <cbiesinger@google.com>
2903
2904 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2905 gdb_static_assert.
2906
29072019-10-07 Weimin Pan <weimin.pan@oracle.com>
2908
2909 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2910 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2911 * ctfread.c: New file.
2912 * ctfread.h: New file.
2913 * elfread.c: Include ctfread.h.
2914 (struct elfinfo text_p): New member ctfsect.
2915 (elf_locate_sections): Mark CTF section.
2916 (elf_symfile_read): Call elfctf_build_psymtabs.
2917 * Makefile.in (LIBCTF): Add.
2918 (CLIBS): Use it.
2919 (CDEPS): Likewise.
2920 (DIST): Add ctfread.c.
2921
29222019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2923
2924 * ctfread.c (struct nextfield): Renamed to ...
2925 (struct ctf_nextfield): ... this.
2926 (struct field_info): Renamed to ...
2927 (strut ctf_field_info): ... this.
2928 (attach_fields_to_type): Update for renamed structures.
2929 (ctf_add_member_cb): Likewise.
2930 (ctf_add_enum_member_cb): Likewise.
2931 (process_struct_members): Likewise.
2932 (process_enum_type): Likewise.
2933
29342019-10-07 Weimin Pan <weimin.pan@oracle.com>
2935
2936 * tracectf.h: Rename, was ctf.h.
2937 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2938 * tracefile.c: Likewise.
2939 * tracepoint.c: Remove unused include ctf.h.
2940 * mi/mi-main.c: Likewise.
2941 * Makefile.in Replace ctf.c with tracectf.c.
2942
29432019-10-06 Joel Brobecker <brobecker@adacore.com>
2944
2945 * version.in: Change version number to "9.0.50.DATE-git".
2946
29472019-10-03 Tom Tromey <tom@tromey.com>
2948
2949 PR rust/24976:
2950 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2951
29522019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2953
2954 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2955 cp_search_name_hash.
2956 * NEWS: Add entry about nested function support.
2957
29582019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
2959 Andrew Burgess <andrew.burgess@embecosm.com>
2960
2961 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2962 for nested static variables when searchin VAR_DOMAIN.
2963 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2964 global scope, update comment.
2965 (add_partial_subprogram): Call add_partial_subprogram recursively
2966 for nested subroutines when processinng Fortran.
2967 (load_partial_dies): Process the child entities of a subprogram
2968 when processing Fortran.
2969 (partial_die_parent_scope): Handle building scope
2970 for Fortran nested functions.
2971 (process_die): Record that nested functions have a scope.
2972 (new_symbol): Always record Fortran subprograms on the global
2973 symbol list.
2974 (determine_prefix): How to build the prefix for Fortran
2975 subprograms.
2976
29772019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2978
2979 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2980 have just sent the thread a SIGSTOP and are waiting for it to
2981 arrive.
2982
29832019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2984
2985 * btrace.c (btrace_add_pc): Remove whitespace before the template
2986 parameter in 'std::vector <...>'.
2987 (parse_xml_btrace_block): Likewise.
2988 (btrace_maint_decode_pt): Likewise.
2989 (btrace_maint_update_packets): Likewise.
2990 (btrace_maint_print_packets): Likewise.
2991 * btrace.h (struct btrace_maint_info): Likewise.
2992 * dwarf2read.c (struct type_unit_group): Likewise.
2993 (build_type_psymtabs_reader): Likewise.
2994 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2995 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2996 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2997
29982019-10-03 Tom de Vries <tdevries@suse.de>
2999
3000 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3001 the first line of the help text for set/show style metadata.
3002
30032019-10-02 Tom Tromey <tromey@adacore.com>
3004
3005 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3006 * gdbsupport/common-inferior.c: New file.
3007 * infcmd.c (startup_with_shell): Don't define.
3008 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3009 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3010 * inferior.h (startup_with_shell): Don't declare.
3011
30122019-10-02 Christian Biesinger <cbiesinger@google.com>
3013
3014 * gdbsupport/gdb_assert.h: Include errors.h.
3015 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3016
30172019-10-02 Tom Tromey <tromey@adacore.com>
3018
3019 * NEWS: Add $_ada_exception entry.
3020 * ada-lang.c (struct ada_catchpoint): Add constructor.
3021 <m_kind>: New member.
3022 (allocate_location_exception, re_set_exception): Remove
3023 "ex" parameter.
3024 (should_stop_exception): Compute $_ada_exception.
3025 (check_status_exception, print_it_exception)
3026 (print_one_exception, print_mention_exception): Remove
3027 "ex" parameter.
3028 (allocate_location_catch_exception, re_set_catch_exception)
3029 (check_status_exception, print_it_catch_exception)
3030 (print_one_catch_exception, print_mention_catch_exception)
3031 (print_recreate_catch_exception)
3032 (allocate_location_catch_exception_unhandled)
3033 (re_set_catch_exception_unhandled)
3034 (check_status_exception, print_it_catch_exception_unhandled)
3035 (print_one_catch_exception_unhandled)
3036 (print_mention_catch_exception_unhandled)
3037 (print_recreate_catch_exception_unhandled)
3038 (allocate_location_catch_assert, re_set_catch_assert)
3039 (check_status_assert, print_it_catch_assert)
3040 (print_one_catch_assert, print_mention_catch_assert)
3041 (print_recreate_catch_assert)
3042 (allocate_location_catch_handlers, re_set_catch_handlers)
3043 (check_status_handlers, print_it_catch_handlers)
3044 (print_one_catch_handlers, print_mention_catch_handlers)
3045 (print_recreate_catch_handlers): Remove.
3046 (create_ada_exception_catchpoint): Update.
3047 (initialize_ada_catchpoint_ops): Update.
3048
30492019-10-02 Tom Tromey <tromey@adacore.com>
3050
3051 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3052 (create_excep_cond_exprs): Simplify exception string computation.
3053 (ada_exception_catchpoint_cond_string): Likewise.
3054
30552019-10-02 Tom Tromey <tromey@adacore.com>
3056
3057 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3058 * ada-lang.c (lesseq_defined_than): Handle
3059 LOC_STATIC.
3060 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3061 parameter.
3062 (dwarf2_has_info): Likewise.
3063 (new_symbol): Set maybe_copied on symbol when
3064 appropriate.
3065 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3066 parameter.
3067 <can_copy>: New member.
3068 * elfread.c (record_minimal_symbol): Set maybe_copied
3069 on symbol when appropriate.
3070 (elf_symfile_read): Update call to dwarf2_has_info.
3071 * minsyms.c (lookup_minimal_symbol_linkage): New
3072 function.
3073 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3074 * symtab.c (get_symbol_address, get_msymbol_address):
3075 New functions.
3076 * symtab.h (get_symbol_address, get_msymbol_address):
3077 Declare.
3078 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3079 maybe_copied.
3080 (struct symbol, struct minimal_symbol) <maybe_copied>:
3081 New member.
3082
30832019-10-02 Tom Tromey <tromey@adacore.com>
3084
3085 * source.c (struct current_source_location): New.
3086 (current_source_key): New global.
3087 (current_source_symtab, current_source_line)
3088 (current_source_pspace): Remove.
3089 (get_source_location): New function.
3090 (get_current_source_symtab_and_line)
3091 (set_default_source_symtab_and_line)
3092 (set_current_source_symtab_and_line)
3093 (clear_current_source_symtab_and_line, select_source_symtab)
3094 (info_source_command, print_source_lines_base)
3095 (info_line_command, search_command_helper, _initialize_source):
3096 Update.
3097
30982019-10-02 Tom Tromey <tromey@adacore.com>
3099
3100 * source.c (select_source_symtab): Don't call
3101 decode_line_with_current_source.
3102
31032019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3104
3105 * symtab.c (lookup_global_symbol): Search global block.
3106
31072019-10-02 Tom Tromey <tromey@adacore.com>
3108
3109 * coffread.c (process_coff_symbol): Update.
3110 * dwarf2read.c (var_decode_location, new_symbol): Update.
3111 * mdebugread.c (parse_symbol): Update.
3112 * objfiles.c (relocate_one_symbol): Update.
3113 * stabsread.c (define_symbol, fix_common_block)
3114 (scan_file_globals): Update.
3115 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3116 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3117 * xcoffread.c (process_xcoff_symbol): Update.
3118
31192019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3120
3121 * MAINTAINERS: Update my email address.
3122
31232019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3124
3125 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3126 std::vector.
3127 (build_type_psymtabs_reader): Update for std::vector.
3128 (build_type_psymtab_dependencies): Likewise.
3129 * dwarf2read.h: Remove use of DEF_VEC_P.
3130 (typedef sig_type_ptr): Delete.
3131
31322019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3133
3134 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3135 to std::vector.
3136 (btrace_maint_decode_pt): Likewise, and move allocation of the
3137 vector outside of the loop.
3138 (btrace_maint_update_packets): Update to handle change from VEC to
3139 std::vector.
3140 (btrace_maint_print_packets): Likewise.
3141 (maint_info_btrace_cmd): Likewise.
3142 * btrace.h: Remove use of DEF_VEC_O.
3143 (typedef btrace_pt_packet_s): Delete.
3144 (struct btrace_maint_info) <packets>: Change fromm VEC to
3145 std::vector.
3146 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3147
31482019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3149
3150 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3151 make accesses into the vector constant references.
3152 (btrace_add_pc): Update for std::vector.
3153 (btrace_stitch_bts): Likewise.
3154 (parse_xml_btrace_block): Likewise.
3155 (btrace_maint_update_packets): Likewise.
3156 (btrace_maint_print_packets): Likewise.
3157 (maint_info_btrace_cmd): Likewise.
3158 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3159 std::vector.
3160 (btrace_data::empty): Likewise.
3161 (btrace_data_append): Likewise.
3162 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3163 (typedef btrace_block_s): Delete.
3164 (struct btrace_block): Add constructor.
3165 (struct btrace_data_bts) <blocks>: Change to std::vector.
3166 * nat/linux-btrace.c (perf_event_read_bts): Update for
3167 std::vector.
3168 (linux_read_bts): Likewise.
3169
31702019-10-01 Tom Tromey <tom@tromey.com>
3171
3172 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3173
31742019-10-01 Tom Tromey <tom@tromey.com>
3175
3176 * stack.c (print_frame, info_frame_command_core): Use
3177 styled_string.
3178 * linux-thread-db.c (try_thread_db_load_1)
3179 (try_thread_db_load_from_pdir_1): Use styled_string.
3180 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3181 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3182 (maybe_print_unsupported_script_warning)
3183 (maybe_print_script_not_found_warning): Use styled_string.
3184 * ada-lang.c (user_select_syms): Use styled_string.
3185
31862019-10-01 Tom Tromey <tom@tromey.com>
3187
3188 * p-lang.c (pascal_printstr): Use metadata style.
3189 * value.c (show_convenience): Use metadata style.
3190 * valprint.c (valprint_check_validity, val_print_optimized_out)
3191 (val_print_not_saved, val_print_unavailable)
3192 (val_print_invalid_address, generic_val_print, val_print)
3193 (value_check_printable, val_print_array_elements): Use metadata
3194 style.
3195 * ui-out.h (class ui_out) <field_fmt>: New overload.
3196 <do_field_fmt>: Add style parameter.
3197 * ui-out.c (ui_out::field_fmt): New overload.
3198 * typeprint.c (type_print_unknown_return_type)
3199 (val_print_not_allocated, val_print_not_associated): Use metadata
3200 style.
3201 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3202 parameter.
3203 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3204 * tracepoint.c (tvariables_info_1): Use metadata style.
3205 * stack.c (print_frame_arg, print_frame_info, print_frame)
3206 (info_frame_command_core): Use metadata style.
3207 * skip.c (info_skip_command): Use metadata style.
3208 * rust-lang.c (rust_print_enum): Use metadata style.
3209 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3210 metadata style.
3211 * python/py-framefilter.c (py_print_single_arg): Use metadata
3212 style.
3213 * printcmd.c (do_one_display, print_variable_and_value): Use
3214 metadata style.
3215 * p-valprint.c (pascal_val_print)
3216 (pascal_object_print_value_fields): Use metadata style.
3217 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3218 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3219 parameter.
3220 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3221 * m2-valprint.c (m2_print_long_set): Use metadata style.
3222 * m2-typeprint.c (m2_print_type): Use metadata style.
3223 * infcmd.c (print_return_value_1): Use metadata style.
3224 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3225 * f-valprint.c (info_common_command_for_block): Use metadata
3226 style.
3227 * f-typeprint.c (f_type_print_base): Use metadata style.
3228 * expprint.c (print_subexp_standard): Use metadata style.
3229 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3230 * cli/cli-style.h (class cli_style_option): Add constructor.
3231 (metadata_style): Declare.
3232 * cli/cli-style.c (metadata_style): New global.
3233 (_initialize_cli_style): Register metadata style.
3234 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3235 parameter.
3236 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3237 * c-typeprint.c (c_type_print_base_struct_union)
3238 (c_type_print_base_1): Use metadata style.
3239 * breakpoint.c (watchpoint_value_print)
3240 (print_one_breakpoint_location): Use metadata style.
3241 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3242 style.
3243 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3244 style.
3245 * ada-valprint.c (val_print_packed_array_elements, printstr)
3246 (print_field_values, ada_val_print_ref, ada_val_print): Use
3247 metadata style.
3248 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3249 style.
3250 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3251 style.
3252 * ada-lang.c (user_select_syms): Use metadata style.
3253
32542019-10-01 Tom Tromey <tom@tromey.com>
3255
3256 * cli/cli-cmds.c (pwd_command): Style output.
3257
32582019-10-01 Pedro Alves <palves@redhat.com>
3259 Tom Tromey <tom@tromey.com>
3260
3261 * symtab.c (print_symbol_info): Use %ps.
3262 (print_msymbol_info): Use %ps.
3263 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3264 * printcmd.c (print_variable_and_value): Use %ps.
3265 * macrocmd.c (show_pp_source_pos): Use %ps.
3266 * infrun.c (print_exited_reason): Use ui_out::message.
3267 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3268 (describe_other_breakpoints): Use ui_out::message and new
3269 formats.
3270 (say_where): Use new formats.
3271 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3272 and new formats.
3273
32742019-10-01 Pedro Alves <palves@redhat.com>
3275 Tom Tromey <tom@tromey.com>
3276
3277 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3278 (test_gdb_formats): New function.
3279 (run_tests): Call it.
3280 (test_format_specifier): Update.
3281 * utils.h (fputs_filtered): Update comment.
3282 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3283 (fputs_styled_unfiltered): Declare.
3284 * utils.c (fputs_styled_unfiltered): New function.
3285 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3286 (vfprintf_filtered): Update.
3287 (vfprintf_unfiltered, vprintf_filtered): Update.
3288 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3289 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3290 disallow_ui_out_field>: New constants.
3291 (enum class field_kind): New.
3292 (struct base_field_s, struct signed_field_s): New.
3293 (signed_field): New function.
3294 (struct string_field_s): New.
3295 (string_field): New function.
3296 (struct styled_string_s): New.
3297 (styled_string): New function.
3298 (class ui_out) <message>: Add comment.
3299 <vmessage, call_do_message>: New methods.
3300 <do_message>: Add style parameter.
3301 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3302 methods.
3303 (ui_out::message): Rewrite.
3304 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3305 parameter.
3306 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3307 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3308 gdb_extensions parameter.
3309 (class format_piece): Add parameter to constructor.
3310 (n_int_args): New field.
3311 * gdbsupport/format.c (format_pieces::format_pieces): Add
3312 gdb_extensions parameter. Handle '*'.
3313 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3314 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3315 vfprintf_styled_no_gdbfmt.
3316 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3317 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3318 unfiltered output.
3319 * ui-style.h (struct ui_file_style) <ptr>: New method.
3320
33212019-10-01 Tom Tromey <tom@tromey.com>
3322
3323 * unittests/format_pieces-selftests.c: Update. Add final format.
3324 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3325 empty literal pieces.
3326
33272019-10-01 Tom Tromey <tom@tromey.com>
3328
3329 * ui-out.h (enum class ui_out_style_kind): Remove.
3330 (class ui_out) <field_string, field_stsream, do_field_string>:
3331 Change type of "style".
3332 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3333 (ui_out::field_string): Update.
3334 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3335 of "style".
3336 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3337 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3338 * stack.c (print_frame_arg, print_frame_info, print_frame):
3339 Update.
3340 * source.c (print_source_lines_base): Update.
3341 * solib.c (info_sharedlibrary_command): Update.
3342 * skip.c (info_skip_command): Update.
3343 * record-btrace.c (btrace_call_history_src_line)
3344 (btrace_call_history): Update.
3345 * python/py-framefilter.c (py_print_frame): Update.
3346 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3347 "style".
3348 * mi/mi-out.c (mi_ui_out::do_table_header)
3349 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3350 (mi_ui_out::do_field_string): Update.
3351 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3352 Update.
3353 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3354 "style".
3355 * cli-out.c (cli_ui_out::do_table_header)
3356 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3357 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3358 (cli_ui_out::do_field_fmt): Update.
3359 * breakpoint.c (print_breakpoint_location): Update.
3360 (update_static_tracepoint): Update.
3361
33622019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3363
3364 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3365 conversion of gdb_datadir.
3366 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3367 remove not needed c_str ().
3368
33692019-09-30 Ali Tamur <tamur@google.com>
3370
3371 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3372 (dwarf2_string_attr): Likewise.
3373
33742019-09-30 Ali Tamur <tamur@google.com>
3375
3376 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3377 (process_full_type_unit): Likewise.
3378 (dump_die_shallow): Likewise.
3379 (cu_debug_loc_section): Likewise.
3380
33812019-09-28 Christian Biesinger <cbiesinger@google.com>
3382
3383 * minsyms.c (compare_minimal_symbols): Rename to...
3384 (minimal_symbol_is_less_than): ...this, and adjust to STL
3385 conventions (return bool, take arguments as references)
3386 (minimal_symbol_reader::install): Call std::sort instead
3387 of qsort.
3388
33892019-09-29 Christian Biesinger <cbiesinger@google.com>
3390
3391 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3392 hash and why.
3393 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3394 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3395
33962019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3397
3398 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3399 * psympriv.h (add_psymbol_to_list): Move comment here and update
3400 it.
3401
34022019-09-29 Tom de Vries <tdevries@suse.de>
3403
3404 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3405 Use $tmpdir/$(basename "$output_file").dwz instead of
3406 "${output_file}.dwz".
3407
34082019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3409
3410 PR gdb/25045
3411 * hppa-linux-nat.c: Include gdbarch.h.
3412
34132019-09-26 Christian Biesinger <cbiesinger@google.com>
3414
3415 * blockframe.c (find_pc_partial_function): Change return type to bool.
3416 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3417 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3418 (stub_gnu_ifunc_resolve_name): Likewise.
3419 * symtab.c (compare_filenames_for_search): Likewise.
3420 (compare_glob_filenames_for_search): Likewise.
3421 (matching_obj_sections): Likewise.
3422 (symbol_matches_domain): Likewise.
3423 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3424 (find_line_pc): Change return type to bool.
3425 (find_line_pc_range): Likewise.
3426 (producer_is_realview): Likewise.
3427 * symtab.h (symbol_matches_domain): Likewise.
3428 (find_pc_partial_function): Likewise.
3429 (find_pc_line_pc_range): Likewise.
3430 (in_gnu_ifunc_stub): Likewise.
3431 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3432 (find_line_pc): Likewise.
3433 (find_line_pc_range): Likewise.
3434 (matching_obj_sections): Likewise.
3435 (find_line_symtab): Change out parameter to bool.
3436 (producer_is_realview): Change return type to bool.
3437 (compare_filenames_for_search): Likewise.
3438 (compare_glob_filenames_for_search): Likewise.
3439
34402019-09-26 Tom Tromey <tom@tromey.com>
3441
3442 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3443 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3444 * gdb_usleep.h: Remove.
3445 * gdb_usleep.c: Remove.
3446 * utils.c: Don't include gdb_usleep.h.
3447
34482019-09-26 Tom Tromey <tromey@adacore.com>
3449
3450 * python/py-type.c (type_to_type_object): Call check_typedef
3451 for stub types.
3452
34532019-09-26 Tom Tromey <tom@tromey.com>
3454
3455 * utils.h (initialize_utils): Don't declare.
3456 * top.c (gdb_init): Don't call initialize_utils.
3457 * utils.c (initialize_utils): Remove. Move contents...
3458 (_initialize_utils): ... here.
3459
34602019-09-25 Tom Tromey <tom@tromey.com>
3461
3462 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3463 * utils.h (make_hex_string): Don't declare.
3464 * utils.c (make_hex_string): Remove.
3465
34662019-09-24 Tom de Vries <tdevries@suse.de>
3467
3468 PR gdb/23815
3469 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3470 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3471
34722019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3473
3474 * NEWS: Mention new simulator port for PRU.
3475
34762019-09-23 Christian Biesinger <cbiesinger@google.com>
3477
3478 * ada-exp.y (write_object_remaining): Update.
3479 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3480 and eliminate the static buffer.
3481 (ada_decode_symbol): Update.
3482 (ada_la_decode): Update.
3483 (ada_sniff_from_mangled_name): Update.
3484 (is_valid_name_for_wild_match): Update.
3485 (ada_lookup_name_info::matches): Update and simplify.
3486 (name_matches_regex): Update.
3487 (ada_add_global_exceptions): Update.
3488 * ada-lang.h (ada_decode): Update signature.
3489 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3490 * dwarf-index-write.c (debug_names::insert): Update.
3491
34922019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3493
3494 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3495 formatting.
3496
34972019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3498
3499 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3500 Change "nonzero" to "true" in documentation.
3501
35022019-09-20 Christian Biesinger <cbiesinger@google.com>
3503
3504 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3505 (_initialize_darwin_solib): Don't set
3506 darwin_so_ops.lookup_lib_global_symbol.
3507 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3508 set_gdbarch_iterate_over_objfiles_in_search_order.
3509 (elf_lookup_lib_symbol): Rename to...
3510 (svr4_iterate_over_objfiles_in_search_order): this, and update
3511 to iterate semantics.
3512 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3513 * solib.c (solib_global_lookup): Remove.
3514 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3515 (solib_global_lookup): Remove.
3516 * symtab.c (lookup_global_or_static_symbol): Remove call to
3517 solib_global_lookup.
3518
35192019-09-20 Joel Brobecker <brobecker@adacore.com>
3520
3521 * NEWS: Move entries about default MI version now being
3522 version 3, and about the GDB/MI fix for multi-location
3523 breakpoints to the "since GDB 8.3" section.
3524
35252019-09-20 Joel Brobecker <brobecker@adacore.com>
3526
3527 GDB 8.3.1 released.
3528
35292019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3530
3531 * NEWS: Mention that Cell/B.E. debugging support was removed.
3532 * MAINTAINERS: Remove spu target.
3533
3534 * config/djgpp/fnchange.lst: Remove entries for removed files.
3535
3536 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3537 spu-multiarch.o, and spu-tdep.o.
3538 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3539 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3540 spu-multiarch.c, and spu-tdep.c.
3541 * spu-linux-nat.c: Remove file.
3542 * spu-multiarch.c: Remove file.
3543 * spu-tdep.c: Remove file.
3544 * spu-tdep.h: Remove file.
3545 * solib-spu.c: Remove file.
3546 * solib-spu.h: Remove file.
3547
3548 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3549 * configure.nat (spu-linux): Remove.
3550 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3551 solib-multiarch.o from gdb_target_obs.
3552 (spu*-*-*): Remove.
3553
3554 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3555 feature flag.
3556 (ppc_linux_no_features): Update.
3557 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3558 Cell/B.E. support.
3559 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3560 (tdesc_powerpc_cell64l): Likewise.
3561 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3562 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3563 Cell/B.E. support.
3564 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3565 Do not include "features/rs6000/powerpc-cell32l.c" or
3566 "features/rs6000/powerpc-cell64l.c".
3567 (ppc_linux_spu_section): Remove.
3568 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3569 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3570 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3571 (ppc_linux_spe_context_lookup): Remove.
3572 (ppc_linux_spe_context_inferior_created): Remove.
3573 (ppc_linux_spe_context_solib_loaded): Remove.
3574 (ppc_linux_spe_context_solib_unloaded): Remove.
3575 (ppc_linux_spe_context): Remove.
3576 (struct ppu2spu_cache): Remove.
3577 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3578 (struct ppu2spu_data): Remove.
3579 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3580 ppu2spu_unwind): Remove.
3581 (ppc_linux_init_abi): Remove Cell/B.E. support.
3582 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3583
3584 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3585 (rs6000/powerpc-cell64l-expedite): Likewise
3586 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3587 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3588 rs6000/powerpc-cell64l.xml.
3589 * features/rs6000/powerpc-cell32l.xml: Remove.
3590 * features/rs6000/powerpc-cell64l.xml: Likewise.
3591 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3592 * features/rs6000/powerpc-cell64l.c: Likewise.
3593 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3594 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3595 * regformats/reg-spu.dat: Remove.
3596
3597 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3598 * corelow.c (struct spuid_list): Remove.
3599 (add_to_spuid_list): Remove.
3600 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3601 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3602 (remote_protocol_features): Remove associated entries.
3603 (_initialize_remote): No longer initialize them.
3604 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3605 * linux-nat.c (SPUFS_MAGIC): Remove.
3606 (linux_proc_xfer_spu): Remove.
3607 (spu_enumerate_spu_ids): Remove.
3608 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3609 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3610 (linux_make_corefile_notes): No longer call it.
3611
3612 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3613 (cooked_write_test): Likewise.
3614
36152019-09-20 Tom Tromey <tom@tromey.com>
3616
3617 * NEWS: Mention case-sensitivity of TUI commands.
3618 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3619 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3620 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3621
36222019-09-20 Tom Tromey <tom@tromey.com>
3623
3624 * tui/tui-source.c (tui_source_window::set_contents): Use
3625 make_unique_xstrdup.
3626 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3627 make_unique_xstrdup.
3628
36292019-09-20 Tom Tromey <tom@tromey.com>
3630
3631 * tui/tui-data.c: Remove separator comments.
3632 * tui/tui-layout.c: Remove separator comments.
3633 * tui/tui-win.c: Remove separator comments.
3634 * tui/tui-wingeneral.c: Remove separator comments.
3635
36362019-09-20 Tom Tromey <tom@tromey.com>
3637
3638 * tui/tui.h (strcat_to_buf): Don't declare.
3639 * tui/tui.c (strcat_to_buf): Remove.
3640
36412019-09-20 Tom Tromey <tom@tromey.com>
3642
3643 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3644 from "fullname".
3645 * tui/tui-source.c (tui_source_window::set_contents)
3646 (tui_source_window::location_matches_p)
3647 (tui_source_window::maybe_update): Update.
3648
36492019-09-20 Tom Tromey <tom@tromey.com>
3650
3651 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3652 Update.
3653 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3654 prefix.
3655 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3656 (tui_data_window::line_from_reg_element_no)
3657 (tui_data_window::first_reg_element_no_inline)
3658 (tui_data_window::show_registers)
3659 (tui_data_window::show_register_group)
3660 (tui_data_window::display_registers_from)
3661 (tui_data_window::display_registers_from_line)
3662 (tui_data_window::first_data_item_displayed)
3663 (tui_data_window::delete_data_content_windows)
3664 (tui_data_window::erase_data_content)
3665 (tui_data_window::do_scroll_vertical)
3666 (tui_data_window::refresh_window)
3667 (tui_data_window::check_register_values): Update.
3668
36692019-09-20 Tom Tromey <tom@tromey.com>
3670
3671 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3672 (struct tui_locator_window) <full_name, proc_name>: Now
3673 std::string.
3674 * tui/tui-stack.c (tui_locator_window::make_status_line)
3675 (tui_locator_window::set_locator_fullname)
3676 (tui_locator_window::set_locator_info): Update.
3677 * tui/tui-source.c (tui_source_window::set_contents)
3678 (tui_source_window::showing_source_p): Update.
3679
36802019-09-20 Tom Tromey <tom@tromey.com>
3681
3682 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3683 Don't call tui_locator_win_info_ptr.
3684
36852019-09-20 Tom Tromey <tom@tromey.com>
3686
3687 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3688
36892019-09-20 Tom Tromey <tom@tromey.com>
3690
3691 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3692 height for locator.
3693 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3694 * tui/tui-layout.c (show_source_disasm_command, show_data)
3695 (show_source_or_disasm_and_command): Use 1 as height for locator.
3696
36972019-09-20 Tom Tromey <tom@tromey.com>
3698
3699 * tui/tui.c (tui_enable): Update.
3700 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3701 Update.
3702 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3703 Update.
3704 * tui/tui-data.c (win_resized): Now bool.
3705 (tui_win_resized): Return bool.
3706 (tui_set_win_resized_to): Accept a bool.
3707
37082019-09-20 Tom Tromey <tom@tromey.com>
3709
3710 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3711 Change type of "refresh_values_only".
3712 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3713 type of "refresh_values_only".
3714
37152019-09-20 Tom Tromey <tom@tromey.com>
3716
3717 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3718 std::string.
3719 (tui_disassemble): Add "pos" parameter.
3720 (tui_disasm_window::set_contents): Simplify.
3721
37222019-09-20 Tom Tromey <tom@tromey.com>
3723
3724 * tui/tui-winsource.h (struct tui_source_window_base)
3725 <show_source_content>: Now private.
3726 * tui/tui-winsource.c
3727 (tui_source_window_base::show_source_content): Don't handle empty
3728 content case.
3729
37302019-09-20 Tom Tromey <tom@tromey.com>
3731
3732 * tui/tui-layout.c (show_source_disasm_command)
3733 (show_source_or_disasm_and_command): Don't call
3734 show_source_content.
3735
37362019-09-20 Tom Tromey <tom@tromey.com>
3737
3738 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3739 Declare.
3740 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3741 from tui_make_status_line.
3742 (tui_locator_window::rerender): Update.
3743
37442019-09-20 Tom Tromey <tom@tromey.com>
3745
3746 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3747 (tui_locator_window::rerender): Update.
3748
37492019-09-20 Tom Tromey <tom@tromey.com>
3750
3751 * tui/tui-winsource.h (struct tui_source_window_base)
3752 <~tui_source_window_base>: Don't declare.
3753 <fullname>: Remove.
3754 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3755 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3756 member.
3757 * tui/tui-source.c (tui_source_window::set_contents): Update.
3758 (tui_source_window::location_matches_p)
3759 (tui_source_window::maybe_update): Update.
3760
37612019-09-20 Tom Tromey <tom@tromey.com>
3762
3763 * tui/tui-winsource.h (~tui_source_element): Remove.
3764 (tui_source_element): Update.
3765 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3766 * tui/tui-winsource.c (tui_show_source_line): Update.
3767 * tui/tui-source.c (tui_source_window::set_contents): Update.
3768 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3769
37702019-09-20 Tom Tromey <tom@tromey.com>
3771
3772 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3773 declare.
3774 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3775 tui_clear_source_windows_detail.
3776 * tui/tui-winsource.h (struct tui_source_window_base)
3777 <clear_detail>: Don't declare.
3778 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3779 Remove.
3780 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3781
37822019-09-20 Tom Tromey <tromey@adacore.com>
3783
3784 PR ada/24919:
3785 * block.c (contained_in): Fix final return value.
3786
37872019-09-20 Alan Modra <amodra@gmail.com>
3788
3789 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3790 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3791 (read_indirect_string_from_dwz): Use bfd accessor.
3792 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3793 * machoread.c (macho_symfile_read_all_oso): Likewise.
3794 * solib.c (solib_bfd_open): Likewise.
3795
37962019-09-19 Christian Biesinger <cbiesinger@google.com>
3797
3798 * eval.c: Move declaration of overload_resolution to...
3799 * value.h: ...here.
3800
38012019-09-19 Christian Biesinger <cbiesinger@google.com>
3802
3803 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3804 * arm-linux-tdep.c: Likewise.
3805 * arm-nbsd-nat.c: Likewise.
3806 * arm-tdep.h: Declare arm_apcs_32.
3807 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3808
38092019-09-19 Christian Biesinger <cbiesinger@google.com>
3810
3811 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3812 * dwarf2read.h: Declare dwarf_always_disassemble.
3813
38142019-09-19 Tom de Vries <tdevries@suse.de>
3815
3816 PR gdb/25009
3817 * source-cache.c (source_cache::ensure): Catch exception thrown during
3818 construction of the highlighter.
3819
38202019-09-18 Alan Modra <amodra@gmail.com>
3821
3822 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3823 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3824 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3825 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3826 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3827 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3828 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3829 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3830 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3831 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3832 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3833 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3834 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3835 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3836 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3837 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3838 * mi/mi-interp.c: Update throughout for bfd section macro and
3839 function changes.
3840 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3841 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3842
38432019-09-18 Tom Tromey <tom@tromey.com>
3844
3845 * NEWS: Add entry.
3846 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3847 call rl_initialize.
3848 (tui_enable): Do not call rl_initialize.
3849
38502019-09-18 Christian Groessler <chris@groessler.org>
3851
3852 * alpha-linux-nat.c: Include gdbarch.h.
3853
38542019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3855
3856 * ui-file.c: Include cli/cli-style.h.
3857 (term_cli_styling): Remove cli_styling declaration.
3858
38592019-09-18 Alan Modra <amodra@gmail.com>
3860
3861 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3862 to bfd_asymbol_section.
3863
38642019-09-18 Alan Modra <amodra@gmail.com>
3865
3866 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3867 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3868 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3869
38702019-09-18 Alan Modra <amodra@gmail.com>
3871
3872 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3873 * spu-linux-nat.c (spu_bfd_open): Likewise.
3874
38752019-09-18 Christian Biesinger <cbiesinger@google.com>
3876
3877 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3878 to bool to match definition in dwarf2read.c.
3879
38802019-09-17 Christian Biesinger <cbiesinger@google.com>
3881
3882 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3883 (print_signatures): Likewise.
3884 (trust_pad_over_xvs): Likewise.
3885 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3886 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3887 * arm-linux-nat.c (arm_apcs_32): Likewise.
3888 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3889 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3890 * arm-tdep.c (arm_debug): Likewise.
3891 (arm_apcs_32): Likewise.
3892 * auto-load.c (debug_auto_load): Likewise.
3893 (auto_load_gdb_scripts): Likewise.
3894 (global_auto_load): Likewise.
3895 (auto_load_local_gdbinit): Likewise.
3896 (auto_load_local_gdbinit_loaded): Likewise.
3897 * auto-load.h (global_auto_load): Likewise.
3898 (auto_load_local_gdbinit): Likewise.
3899 (auto_load_local_gdbinit_loaded): Likewise.
3900 * breakpoint.c (disconnected_dprintf): Likewise.
3901 (breakpoint_proceeded): Likewise.
3902 (automatic_hardware_breakpoints): Likewise.
3903 (always_inserted_mode): Likewise.
3904 (target_exact_watchpoints): Likewise.
3905 (_initialize_breakpoint): Update.
3906 * breakpoint.h (target_exact_watchpoints): Change to bool.
3907 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3908 * cli/cli-cmds.c (trace_commands): Likewise.
3909 * cli/cli-cmds.h (trace_commands): Likewise.
3910 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3911 to bool*.
3912 * cli/cli-logging.c (logging_overwrite): Change to bool.
3913 (logging_redirect): Likewise.
3914 (debug_redirect): Likewise.
3915 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3916 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3917 to bool.
3918 <boolean_option_def>: Update.
3919 (struct flag_option_def): Change default type of Context to bool
3920 from int.
3921 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3922 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3923 (get_setshow_command_value_string): Likewise.
3924 * cli/cli-style.c (cli_styling): Change to bool.
3925 (source_styling): Likewise.
3926 * cli/cli-style.h (source_styling): Likewise.
3927 (cli_styling): Likewise.
3928 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3929 to bool.
3930 * command.h (var_types): Update comment.
3931 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3932 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3933 bool.
3934 (debug_compile_cplus_scopes): Likewise.
3935 * compile/compile-internal.h (compile_debug): Likewise.
3936 * compile/compile.c (compile_debug): Likewise.
3937 (struct compile_options) <raw>: Likewise.
3938 * cp-support.c (catch_demangler_crashes): Likewise.
3939 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3940 (usr_cmd_cris_dwarf2_cfi): Likewise.
3941 * csky-tdep.c (csky_debug): Likewise.
3942 * darwin-nat.c (enable_mach_exceptions): Likewise.
3943 * dcache.c (dcache_enabled_p): Likewise.
3944 * defs.h (info_verbose): Likewise.
3945 * demangle.c (demangle): Likewise.
3946 (asm_demangle): Likewise.
3947 * dwarf-index-cache.c (debug_index_cache): Likewise.
3948 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3949 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3950 * dwarf2read.c (check_physname): Likewise.
3951 (use_deprecated_index_sections): Likewise.
3952 (dwarf_always_disassemble): Likewise.
3953 * eval.c (overload_resolution): Likewise.
3954 * event-top.c (set_editing_cmd_var): Likewise.
3955 (exec_done_display_p): Likewise.
3956 * event-top.h (set_editing_cmd_var): Likewise.
3957 (exec_done_display_p): Likewise.
3958 * exec.c (write_files): Likewise.
3959 * fbsd-nat.c (debug_fbsd_lwp): Likewise
3960 (debug_fbsd_nat): Likewise.
3961 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3962 Likewise.
3963 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3964 <backtrace_past_entry> Likewise.
3965 * gdb-demangle.h (demangle): Likewise.
3966 (asm_demangle): Likewise.
3967 * gdb_bfd.c (bfd_sharing): Likewise.
3968 * gdbcore.h (write_files): Likewise.
3969 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3970 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3971 * gdbthread.h (print_thread_events): Likewise.
3972 * gdbtypes.c (opaque_type_resolution): Likewise.
3973 (strict_type_checking): Likewise.
3974 * gnu-nat.c (gnu_debug_flag): Likewise.
3975 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3976 * guile/scm-param.c (pascm_variable): Add boolval.
3977 (add_setshow_generic): Update.
3978 (pascm_param_value): Update.
3979 (pascm_set_param_value_x): Update.
3980 * hppa-tdep.c (hppa_debug): Change to bool..
3981 * infcall.c (may_call_functions_p): Likewise.
3982 (coerce_float_to_double_p): Likewise.
3983 (unwind_on_signal_p): Likewise.
3984 (unwind_on_terminating_exception_p): Likewise.
3985 * infcmd.c (startup_with_shell): Likewise.
3986 * inferior.c (print_inferior_events): Likewise.
3987 * inferior.h (startup_with_shell): Likewise.
3988 (print_inferior_events): Likewise.
3989 * infrun.c (step_stop_if_no_debug): Likewise.
3990 (detach_fork): Likewise.
3991 (debug_displaced): Likewise.
3992 (disable_randomization): Likewise.
3993 (non_stop): Likewise.
3994 (non_stop_1): Likewise.
3995 (observer_mode): Likewise.
3996 (observer_mode_1): Likewise.
3997 (set_observer_mode): Update.
3998 (sched_multi): Change to bool.
3999 * infrun.h (debug_displaced): Likewise.
4000 (sched_multi): Likewise.
4001 (step_stop_if_no_debug): Likewise.
4002 (non_stop): Likewise.
4003 (disable_randomization): Likewise.
4004 * linux-tdep.c (use_coredump_filter): Likewise.
4005 (dump_excluded_mappings): Likewise.
4006 * linux-thread-db.c (auto_load_thread_db): Likewise.
4007 (check_thread_db_on_load): Likewise.
4008 * main.c (captured_main_1): Update.
4009 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4010 xx2_opt, boolean_opt>: Change to bool.
4011 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4012 * maint.c (maintenance_profile_p): Likewise.
4013 (per_command_time): Likewise.
4014 (per_command_space): Likewise.
4015 (per_command_symtab): Likewise.
4016 * memattr.c (inaccessible_by_default): Likewise.
4017 * mi/mi-main.c (mi_async): Likewise.
4018 (mi_async_1): Likewise.
4019 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4020 * nat/fork-inferior.h (startup_with_shell): Likewise.
4021 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4022 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4023 * nios2-tdep.c (nios2_debug): Likewise.
4024 * or1k-tdep.c (or1k_debug): Likewise.
4025 * parse.c (parser_debug): Likewise.
4026 * parser-defs.h (parser_debug): Likewise.
4027 * printcmd.c (print_symbol_filename): Likewise.
4028 * proc-api.c (procfs_trace): Likewise.
4029 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4030 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4031 (set_parameter_value): Update.
4032 (add_setshow_generic): Update.
4033 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4034 to bool*.
4035 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4036 int*.
4037 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4038 * record-btrace.c (record_btrace_target::store_registers): Update.
4039 * record-full.c (record_full_memory_query): Change to bool.
4040 (record_full_stop_at_limit): Likewise.
4041 * record-full.h (record_full_memory_query): Likewise.
4042 * remote-notif.c (notif_debug): Likewise.
4043 * remote-notif.h (notif_debug): Likewise.
4044 * remote.c (use_range_stepping): Likewise.
4045 (interrupt_on_connect): Likewise.
4046 (remote_break): Likewise.
4047 * ser-tcp.c (tcp_auto_retry): Likewise.
4048 * ser-unix.c (serial_hwflow): Likewise.
4049 * skip.c (debug_skip): Likewise.
4050 * solib-aix.c (solib_aix_debug): Likewise.
4051 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4052 (spu_auto_flush_cache_p): Likewise.
4053 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4054 Likewise.
4055 (struct info_print_options) <quiet>: Likewise.
4056 * symfile-debug.c (debug_symfile): Likewise.
4057 * symfile.c (auto_solib_add): Likewise.
4058 (separate_debug_file_debug): Likewise.
4059 * symfile.h (auto_solib_add): Likewise.
4060 (separate_debug_file_debug): Likewise.
4061 * symtab.c (basenames_may_differ): Likewise.
4062 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4063 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4064 (struct info_types_options) <quiet>: Likewise.
4065 * symtab.h (demangle): Likewise.
4066 (basenames_may_differ): Likewise.
4067 * target-dcache.c (stack_cache_enabled_1): Likewise.
4068 (code_cache_enabled_1): Likewise.
4069 * target.c (trust_readonly): Likewise.
4070 (may_write_registers): Likewise.
4071 (may_write_memory): Likewise.
4072 (may_insert_breakpoints): Likewise.
4073 (may_insert_tracepoints): Likewise.
4074 (may_insert_fast_tracepoints): Likewise.
4075 (may_stop): Likewise.
4076 (auto_connect_native_target): Likewise.
4077 (target_stop_and_wait): Update.
4078 (target_async_permitted): Change to bool.
4079 (target_async_permitted_1): Likewise.
4080 (may_write_registers_1): Likewise.
4081 (may_write_memory_1): Likewise.
4082 (may_insert_breakpoints_1): Likewise.
4083 (may_insert_tracepoints_1): Likewise.
4084 (may_insert_fast_tracepoints_1): Likewise.
4085 (may_stop_1): Likewise.
4086 * target.h (target_async_permitted): Likewise.
4087 (may_write_registers): Likewise.
4088 (may_write_memory): Likewise.
4089 (may_insert_breakpoints): Likewise.
4090 (may_insert_tracepoints): Likewise.
4091 (may_insert_fast_tracepoints): Likewise.
4092 (may_stop): Likewise.
4093 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4094 (make_thread_apply_all_options_def_group): Change argument from int*
4095 to bool*.
4096 (thread_apply_all_command): Update.
4097 (print_thread_events): Change to bool.
4098 * top.c (confirm): Likewise.
4099 (command_editing_p): Likewise.
4100 (history_expansion_p): Likewise.
4101 (write_history_p): Likewise.
4102 (info_verbose): Likewise.
4103 * top.h (confirm): Likewise.
4104 (history_expansion_p): Likewise.
4105 * tracepoint.c (disconnected_tracing): Likewise.
4106 (circular_trace_buffer): Likewise.
4107 * typeprint.c (print_methods): Likewise.
4108 (print_typedefs): Likewise.
4109 * utils.c (debug_timestamp): Likewise.
4110 (sevenbit_strings): Likewise.
4111 (pagination_enabled): Likewise.
4112 * utils.h (sevenbit_strings): Likewise.
4113 (pagination_enabled): Likewise.
4114 * valops.c (overload_resolution): Likewise.
4115 * valprint.h (struct value_print_options) <prettyformat_arrays,
4116 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4117 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4118 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4119 Likewise.
4120 * windows-nat.c (new_console): Likewise.
4121 (cygwin_exceptions): Likewise.
4122 (new_group): Likewise.
4123 (debug_exec): Likewise.
4124 (debug_events): Likewise.
4125 (debug_memory): Likewise.
4126 (debug_exceptions): Likewise.
4127 (useshell): Likewise.
4128 * windows-tdep.c (maint_display_all_tib): Likewise.
4129 * xml-support.c (debug_xml): Likewise.
4130
41312019-09-17 Mike Gulick <mgulick@mathworks.com>
4132
4133 * source.c (prepare_path_for_appending): New function.
4134 (openp): Make use of new function.
4135 (find_and_open_source): Search for the compilation directory and
4136 source file as a relative path beneath the directory search path.
4137
41382019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4139
4140 * source-cache.c (source_cache::get_line_charpos): Catch
4141 exceptions and return false, this matches the behaviour documented
4142 in the header file.
4143
41442019-09-17 Joel Brobecker <brobecker@adacore.com>
4145
4146 * ada-tasks.c (info_task): Remove quoting of the task's name.
4147
41482019-09-16 Christian Biesinger <cbiesinger@google.com>
4149
4150 * symfile.c (auto_solib_add): Replace comment with a reference
4151 to the header file.
4152
41532019-09-14 Christian Biesinger <cbiesinger@google.com>
4154
4155 * NEWS: Mention that gdb can now be compiled with Python 3
4156 on Windows.
4157
41582019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4159
4160 * maint.c (maint_print_section_data::maint_print_section_data):
4161 Force use of 'float log10 (float)' by casting the argument to
4162 float.
4163
41642019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4165
4166 * maint.c: Add 'cmath' include.
4167 (struct maint_print_section_data): New structure.
4168 (print_section_index): New function.
4169 (print_bfd_section_info): Add header comment, small whitespace
4170 cleanup, and update to call new print_section_index function.
4171 (print_objfile_section_info): Likewise.
4172 (maint_obj_section_from_bfd_section): New function.
4173 (print_bfd_section_info_maybe_relocated): New function.
4174 (maintenance_info_sections): Add header comment, always use
4175 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4176
41772019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4178
4179 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4180 inner scope, add check that the objfile has psymtabs before
4181 checking psymtabs_addrmap.
4182 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4183
41842019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4185
4186 * NEWS: Announce that Ada task names are now shown at more places,
4187 and between quotes (except in info task output).
4188 * gdb/ada-tasks.c (task_to_str): New function.
4189 (display_current_task_id): Call task_to_str.
4190 (task_command_1): Likewise.
4191 (print_ada_task_info): In non-mi mode, Properly align headers and data
4192 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4193
41942019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4195
4196 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4197 prstatus.pr_lwp.pr_info instead of making it up.
4198
41992019-09-11 Christian Biesinger <cbiesinger@google.com>
4200
4201 * auto-load.c (auto_load_expand_dir_vars): Update.
4202 * defs.h (gdb_datadir): Change to std::string.
4203 (python_libdir): Likewise.
4204 (relocate_gdb_directory): Change return type to std::string.
4205 * guile/guile.c (gdbscm_data_directory): Update.
4206 (initialize_scheme_side): Update.
4207 * jit.c (jit_reader_dir): Change to std::string.
4208 (jit_reader_load_command): Update.
4209 * main.c (gdb_datadir): Change to std::string.
4210 (python_libdir): Likewise.
4211 (set_gdb_data_directory): Update.
4212 (relocate_path): Change to return std::string.
4213 (relocate_gdb_directory): Change to return std::string.
4214 (relocate_gdbinit_path_maybe_in_datadir): Update.
4215 (captured_main_1): Update.
4216 * python/python.c (do_start_initialization): Update.
4217 * top.c (show_gdb_datadir): Update.
4218 * xml-syscall.c (xml_init_syscalls_info): Update.
4219 (init_syscalls_info): Update.
4220
42212019-09-11 Christian Biesinger <cbiesinger@google.com>
4222
4223 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4224 out of get_init_files.
4225 (get_init_files): Update.
4226
42272019-09-11 Christian Biesinger <cbiesinger@google.com>
4228
4229 * main.c (get_init_files): Change to use std::string.
4230 (captured_main_1): Update.
4231 (print_gdb_help): Update.
4232
42332019-09-11 Ali Tamur <tamur@google.com>
4234
4235 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4236 implementation.
4237
42382019-09-11 Christian Biesinger <cbiesinger@google.com>
4239
4240 * dbxread.c (read_dbx_symtab): Update.
4241 * dwarf2read.c (load_partial_dies): Update.
4242 * mdebugread.c (parse_partial_symbols): Update.
4243 (handle_psymbol_enumerators): Update.
4244 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4245 * psymtab.c (add_psymbol_to_bcache): Likewise.
4246 (add_psymbol_to_list): Likewise.
4247 * symtab.c (symbol_set_names): Likewise.
4248 * symtab.h (symbol_set_names): Likewise.
4249 * xcoffread.c (scan_xcoff_symtab): Update.
4250
42512019-09-11 Tom Tromey <tom@tromey.com>
4252
4253 * symfile-mem.c (symbol_file_add_from_memory): Use
4254 bfd_set_filename.
4255 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4256 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4257
42582019-09-10 Tom Tromey <tromey@adacore.com>
4259
4260 * dwarf-index-write.c (write_psymbols): Extend error message.
4261 (debug_names::insert): Add Ada code.
4262 (debug_names::write_psymbols): Remove Ada check.
4263 (debug_names) <m_string_obstack>: New member.
4264 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4265 (gdb_index_symbol_name_matcher::matches): Remove.
4266 (mapped_index_base::find_name_components_bounds): Add "lang"
4267 parameter.
4268 (mapped_index_base::build_name_components): Also split names
4269 according to Ada syntax.
4270 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4271 type of "match_callback".
4272 (check_match, check_find_bounds_finds)
4273 (dw2_expand_symtabs_matching): Update.
4274 (dw2_debug_names_iterator): Add new constructor.
4275 (dw2_debug_names_map_matching_symbols): New function.
4276 (dw2_debug_names_expand_symtabs_matching): Update.
4277 (dwarf2_debug_names_functions): Use
4278 dw2_debug_names_map_matching_symbols.
4279
42802019-09-10 Tom Tromey <tromey@adacore.com>
4281
4282 * dwarf2read.c (dw2_get_file_names_reader): Add the
4283 CU's file name to the results.
4284
42852019-09-10 Tom Tromey <tromey@adacore.com>
4286
4287 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4288 map_matching_symbols. Update.
4289 * dwarf2read.c (dw2_map_matching_symbols): Update.
4290 * psymtab.c (match_partial_symbol): Change type; update.
4291 (psym_map_matching_symbols): Likewise.
4292 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4293 type; update.
4294 * symfile.h (struct quick_symbol_functions)
4295 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4296 Remove "match".
4297
42982019-09-10 Tom Tromey <tromey@adacore.com>
4299
4300 * psymtab.c (map_block): Remove.
4301 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4302 * symtab.c (iterate_over_symbols_terminated): New function.
4303 * symtab.c (iterate_over_symbols_terminated): Declare.
4304
43052019-09-10 Tom Tromey <tromey@adacore.com>
4306
4307 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4308 * language.h (struct language_defn) <la_iterate_over_symbols>:
4309 Return bool.
4310 * symtab.c (iterate_over_symbols): Return bool.
4311 * symtab.h (iterate_over_symbols): Return bool.
4312
43132019-09-10 Tom Tromey <tromey@adacore.com>
4314
4315 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4316 (add_nonlocal_symbols): Update.
4317 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4318 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4319 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4320 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4321 Change type of "callback". Remove "data".
4322
4323
43242019-09-09 Ali Tamur <tamur@google.com>
4325
4326 * dwarf2read.c (comp_unit_head): Update comment.
4327 (dwarf2_dwo_name): New function declaration.
4328 (dwarf_unit_type_name): New function declaration.
4329 (read_comp_unit_head): Add support for new compilation units,
4330 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4331 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4332 (currently named as "signature") in their header. Also clarify error
4333 messages.
4334 (lookup_dwo_id): New function. Returns the dwo id of the given
4335 compile unit.
4336 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4337 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4338 functions.
4339 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4340 (dwarf2_dwo_name): Get the dwo name if present.
4341 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4342 purposes.
4343
43442019-09-09 Tom Tromey <tom@tromey.com>
4345
4346 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4347
43482019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4349
4350 * python/python.c (do_start_initialization): Make progname_copy static,
4351 to avoid a leak report.
4352
43532019-09-08 Tom Tromey <tom@tromey.com>
4354
4355 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4356
43572019-09-07 Simon Marchi <simon.marchi@efficios.com>
4358
4359 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4360 Change type to gdb::optional<block_enum>.
4361 (dw2_symtab_iter_init): Change block_index parameter type
4362 to gdb::optional<block_enum>.
4363 (dw2_lookup_symbol): Change block_index parameter
4364 type to block_enum.c
4365 (dw2_debug_names_lookup_symbol): Likewise.
4366 * psymtab.c (psym_lookup_symbol): Likewise.
4367 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4368 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4369 Likewise.
4370
43712019-09-06 Christian Biesinger <cbiesinger@google.com>
4372
4373 * defs.h (relocate_gdb_directory): Change int to bool in
4374 signature and rename flag to relocatable.
4375 * main.c (relocate_path): Likewise.
4376 (relocate_gdb_directory): Likewise.
4377
43782019-09-06 Alan Modra <amodra@gmail.com>
4379
4380 * coffread.c (coff_symfile_read): Constify filename variable.
4381 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4382 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4383 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4384 * solib.c (reload_shared_libraries_1): Likewise.
4385 * symfile.c (reread_symbols): Likewise.
4386 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4387 * solib-darwin.c (darwin_bfd_open): Likewise.
4388 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4389
43902019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4391
4392 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4393 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4394
43952019-09-03 Tom Tromey <tromey@adacore.com>
4396
4397 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4398 types.
4399 (has_negatives): Unbias a range type bound.
4400 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4401 * gdbtypes.c (operator==): Handle new field.
4402 (create_range_type): Add "bias" parameter.
4403 (create_static_range_type, resolve_dynamic_range): Update.
4404 * gdbtypes.h (struct range_bounds) <bias>: New member.
4405 (create_range_type): Add bias parameter.
4406 * printcmd.c (print_scalar_formatted): Unbias range types.
4407 * value.c (unpack_long): Unbias range types.
4408 (pack_long): Bias range types.
4409
44102019-09-02 Alan Hayward <alan.hayward@arm.com>
4411
4412 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4413 probe arguments.
4414
44152019-09-02 Alan Hayward <alan.hayward@arm.com>
4416
4417 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4418 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4419 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4420 (compile_probe_arg): Likewise.
4421 * probe.h (get_argument_count): Likewise.
4422 * solib-svr4.c (solib_event_probe_action): Likewise.
4423 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4424
44252019-09-02 Alan Hayward <alan.hayward@arm.com>
4426
4427 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4428 code to here...
4429 (svr4_create_solib_event_breakpoints): ...from here.
4430
44312019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4432
4433 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4434 suffix from warning message.
4435
44362019-08-30 Tom Tromey <tom@tromey.com>
4437
4438 * tui/tui-winsource.h (struct tui_source_window_base)
4439 <refresh_all>: Don't declare.
4440 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4441 Remove.
4442 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4443 tui_show_locator_content.
4444 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4445 declare.
4446 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4447 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4448 declare.
4449
44502019-08-30 Tom Tromey <tom@tromey.com>
4451
4452 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4453
44542019-08-30 Tom Tromey <tom@tromey.com>
4455
4456 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4457 Remove unnecessary forward declarations.
4458
44592019-08-30 Tom Tromey <tom@tromey.com>
4460
4461 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4462 rerender.
4463 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4464 tui_show_locator_content.
4465
44662019-08-30 Tom Tromey <tom@tromey.com>
4467
4468 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4469 (tui_locator_window::rerender): Rewrite using body of previous
4470 tui_show_locator_content.
4471
44722019-08-30 Tom Tromey <tom@tromey.com>
4473
4474 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4475 set_locator_fullname>: New methods.
4476 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4477 Rename from tui_set_locator_fullname.
4478 (tui_locator_window::set_locator_info): Rename from
4479 tui_set_locator_info. Return bool.
4480 (tui_update_locator_fullname, tui_show_frame_info): Update.
4481
44822019-08-30 Tom Tromey <tom@tromey.com>
4483
4484 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4485
44862019-08-30 Tom Tromey <tom@tromey.com>
4487
4488 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4489 call touchwin.
4490
44912019-08-30 Tom Tromey <tom@tromey.com>
4492
4493 * tui/tui-wingeneral.c (box_win): Assume win_info and
4494 win_info->handle cannot be NULL.
4495
44962019-08-30 Tom Tromey <tom@tromey.com>
4497
4498 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4499 refresh_window>: Declare.
4500 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4501 resize.
4502 (tui_data_item_window::rerender): Rename from
4503 tui_display_register.
4504 (tui_data_item_window::refresh_window): New method.
4505 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4506 no-op.
4507
45082019-08-30 Tom Tromey <tom@tromey.com>
4509
4510 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4511 regs_column_count, current_group>: Move later. Now private.
4512 <get_current_group>: New method.
4513 * tui/tui-regs.c (tui_reg_command): Update.
4514 * tui/tui-layout.c (tui_set_layout): Update.
4515
45162019-08-30 Tom Tromey <tom@tromey.com>
4517
4518 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4519 (tui_data_window::rerender): Don't call
4520 check_and_display_highlight_if_needed.
4521 (tui_data_window::refresh_all): Remove call to
4522 erase_data_content.
4523
45242019-08-30 Tom Tromey <tom@tromey.com>
4525
4526 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4527 (tui_data_window::display_registers_from)
4528 (tui_data_window::display_reg_element_at_line)
4529 (tui_data_window::display_registers_from_line): Remove checks of
4530 "empty".
4531
45322019-08-30 Tom Tromey <tom@tromey.com>
4533
4534 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4535 Don't declare.
4536 * tui/tui-regs.c (tui_data_window::show_registers): Call
4537 rerender.
4538 (tui_data_window::rerender): Rename from display_all_data.
4539 (tui_data_window::rerender): Remove old implementation.
4540
45412019-08-30 Tom Tromey <tom@tromey.com>
4542
4543 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4544 text.
4545 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4546
45472019-08-29 Bernhard Wodok <barto@gmx.net>
4548 Sergio Durigan Junior <sergiodj@redhat.com>
4549
4550 PR win32/24284
4551 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4552
45532019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4554
4555 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4556 when searching for types.
4557
45582019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4559
4560 * f-lang.c (f_language_defn): Use f_print_typedef.
4561 * f-lang.h (f_print_typedef): Declare.
4562 * f-typeprint.c (f_print_typedef): Define.
4563
45642019-08-27 Christian Biesinger <cbiesinger@google.com>
4565
4566 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4567
45682019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4569
4570 * cli/cli-utils.c (info_print_options_defs): Delete.
4571 (make_info_print_options_def_group): Delete.
4572 (extract_info_print_options): Delete.
4573 (info_print_command_completer): Delete.
4574 (info_print_args_help): Add extra parameter, and optionally
4575 include text about -n flag.
4576 * cli/cli-utils.h (struct info_print_options): Delete.
4577 (extract_info_print_options): Delete declaration.
4578 (info_print_command_completer): Delete declaration.
4579 (info_print_args_help): Add extra parameter, extend header
4580 comment.
4581 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4582 search_symbols.
4583 * stack.c (struct info_print_options): New type.
4584 (info_print_options_defs): New file scoped variable.
4585 (make_info_print_options_def_group): New static function.
4586 (info_print_command_completer): New static function.
4587 (info_locals_command): Update to use new local functions.
4588 (info_args_command): Likewise.
4589 (_initialize_stack): Add extra parameter to calls to
4590 info_print_args_help.
4591 * symtab.c (search_symbols): Add extra parameter, use this to
4592 possibly excluse non-debug symbols.
4593 (symtab_symbol_info): Add extra parameter, which is passed on to
4594 search_symbols.
4595 (struct info_print_options): New type.
4596 (info_print_options_defs): New file scoped variable.
4597 (make_info_print_options_def_group): New static function.
4598 (info_print_command_completer): New static function.
4599 (info_variables_command): Update to use local functions, and pass
4600 extra parameter through to symtab_symbol_info.
4601 (info_functions_command): Likewise.
4602 (info_types_command): Pass additional argument through to
4603 symtab_symbol_info.
4604 (rbreak_command): Pass extra argument to search_symbols.
4605 (_initialize_symtab): Add extra arguments for calls to
4606 info_print_args_help, and update help text for 'info variables',
4607 'whereis', and 'info functions' commands.
4608 * symtab.h (search_symbols): Add extra argument to declaration.
4609 * NEWS: Mention new flags.
4610
46112019-08-26 Christian Biesinger <cbiesinger@google.com>
4612
4613 * symtab.c (lookup_static_symbol): Call the new function (and move
4614 it down to be next to lookup_global_symbol).
4615 (struct global_sym_lookup_data): Add block_enum member and rename to...
4616 (struct global_or_static_sym_lookup_data): ...this.
4617 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4618 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4619 (lookup_symbol_global_or_static_iterator_cb): ...this.
4620 (lookup_global_or_static_symbol): New function.
4621 (lookup_global_symbol): Call new function.
4622
46232019-08-26 Tom de Vries <tdevries@suse.de>
4624
4625 PR c++/24852
4626 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4627 when pc_probe.prob == NULL.
4628
46292019-08-25 Simon Marchi <simon.marchi@efficios.com>
4630
4631 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4632 variable symbol_linkage to symbol_linkage_.
4633
46342019-08-25 Simon Marchi <simon.marchi@efficios.com>
4635
4636 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4637 represent whether the symbol is static, dynamic, or we don't
4638 know.
4639
46402019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4641
4642 * gdb/rx-tdep.c (rx_register_names): New.
4643 (rx_register_name): Delete.
4644 (rx_psw_type): Delete.
4645 (rx_fpsw_type): Delete.
4646 (rx_register_type): Delete.
4647 (rx_gdbarch_init): Convert target-descriptions.
4648 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4649 * gdb/features/Makefile: Add rx.xml.
4650 * gdb/features/rx.xml: New.
4651 * gdb/features/rx.c: Generated.
4652 * gdb/NEWS: Mention target description support.
4653
46542019-08-22 Christian Biesinger <cbiesinger@google.com>
4655
4656 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4657 *slot_ptr.
4658
46592019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4660
4661 * configure.ac: Don't check for 'dlfcn.h' (moved to
4662 gdbsupport/common.m4).
4663 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4664 'gdbsupport/'.
4665 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4666 * compile/compile-c-support.c: Include
4667 'gdbsupport/gdb-dlfcn.h'.
4668 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4669 * gdb-dlfcn.c: Move to...
4670 * gdbsupport/gdb-dlfcn.c: ... here.
4671 * gdb-dlfcn.h: Move to...
4672 * gdbsupport/gdb-dlfcn.h: ... here.
4673
46742019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4675
4676 * nios2-tdep.c (struct reg_value): Improve comments. Make
4677 the offset field signed.
4678
46792019-08-22 Christian Biesinger <cbiesinger@google.com>
4680
4681 * python/lib/gdb/__init__.py (_execute_file): New function.
4682 * python/python.c (python_run_simple_file): Call gdb._execute_file
4683 on Windows.
4684
46852019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4686
4687 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4688 all uses as this was never set to anything but a zero value.
4689
46902019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4691
4692 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4693
46942019-08-21 Christian Biesinger <cbiesinger@google.com>
4695
4696 * tui/tui-data.h (tui_gen_win_info): Add an =default
4697 move constructor, required by some GCC versions.
4698
46992019-08-21 Jinke Fan <fanjinke51@yeah.net>
4700
4701 * go32-nat.c (go32_sysinfo): Add hygon_p.
4702
47032019-08-20 Tom Tromey <tom@tromey.com>
4704
4705 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4706 line_from_reg_element_no, first_reg_element_no_inline,
4707 display_all_data, delete_data_content_windows,
4708 erase_data_content>: Now private.
4709
47102019-08-20 Tom Tromey <tom@tromey.com>
4711
4712 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4713 (tui_unhighlight_win, tui_highlight_win)
4714 (tui_win_info::make_window): Update.
4715 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4716
47172019-08-20 Tom Tromey <tom@tromey.com>
4718
4719 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4720 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4721 (MAX_PID_WIDTH): Move to tui-stack.c.
4722 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4723 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4724 (MAX_PID_WIDTH): Move from tui-data.h.
4725
47262019-08-20 Tom Tromey <tom@tromey.com>
4727
4728 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4729 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4730 (box_win): Update.
4731 (tui_gen_win_info::make_window): Rename from tui_make_window.
4732 (tui_win_info::make_window): New method.
4733 (tui_gen_win_info::make_visible): Update.
4734 * tui/tui-source.c (tui_source_window::set_contents): Update.
4735 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4736 (tui_data_window::display_registers_from): Update.
4737 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4738 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4739 Declare.
4740 <can_box>: Remove.
4741 <title>: Remove.
4742 (struct tui_win_info) <make_window>: Declare.
4743 <can_box>: Now virtual.
4744 <title>: New member.
4745 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4746 * tui/tui-command.c (tui_cmd_window::resize): Update.
4747
47482019-08-20 Tom Tromey <tom@tromey.com>
4749
4750 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4751 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4752 (tui_data_window::check_register_values): Update.
4753
47542019-08-20 Tom Tromey <tom@tromey.com>
4755
4756 * tui/tui-regs.h (struct tui_data_window): Use
4757 DISABLE_COPY_AND_ASSIGN.
4758 <regs_content>: Change type, removing unique_ptr.
4759 <tui_data_window>: Add move constructor.
4760 * tui/tui-regs.c (tui_data_window::show_registers)
4761 (tui_data_window::show_register_group)
4762 (tui_data_window::display_registers_from)
4763 (tui_data_window::display_registers_from)
4764 (tui_data_window::first_data_item_displayed)
4765 (tui_data_window::delete_data_content_windows)
4766 (tui_data_window::rerender, tui_data_window::refresh_window)
4767 (tui_data_window::check_register_values): Update.
4768
47692019-08-20 Tom Tromey <tom@tromey.com>
4770
4771 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4772 show_register_group>: Declare.
4773 (tui_show_register_group): Don't declare.
4774 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4775 tui_show_registers.
4776 (tui_data_window::show_register_group): Rename from
4777 tui_show_register_group.
4778 (tui_data_window::check_register_values, tui_reg_command):
4779 Update.
4780 * tui/tui-layout.c (tui_set_layout): Update.
4781
47822019-08-20 Tom Tromey <tom@tromey.com>
4783
4784 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4785 Declare.
4786 (tui_check_register_values): Don't declare.
4787 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4788 from tui_check_register_values.
4789 * tui/tui-hooks.c (tui_register_changed): Update.
4790
47912019-08-20 Tom Tromey <tom@tromey.com>
4792
4793 * tui/tui-regs.c (tui_reg_layout): Move later.
4794 (tui_show_registers): Don't enable TUI mode or change layout.
4795
47962019-08-20 Tom Tromey <tom@tromey.com>
4797
4798 * tui/tui-regs.h (struct tui_data_item_window)
4799 <~tui_data_item_window>: Remove.
4800 <content>: Now a unique_xmalloc_ptr.
4801 * tui/tui-regs.c (tui_register_format): Return a
4802 unique_xmalloc_ptr.
4803 (tui_get_register): Update.
4804 (~tui_data_item_window): Remove.
4805 (tui_data_window::display_registers_from, tui_display_register):
4806 Update.
4807 * tui/tui-io.h (tui_expand_tabs): Update.
4808 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4809 Remove "col" parameter.
4810
48112019-08-20 Tom Tromey <tom@tromey.com>
4812
4813 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4814 field.
4815 * tui/tui-regs.c (~tui_data_item_window): Update.
4816
48172019-08-20 Tom Tromey <tom@tromey.com>
4818
4819 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4820 earlier.
4821
48222019-08-20 Tom Tromey <tom@tromey.com>
4823
4824 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4825
48262019-08-20 Tom Tromey <tom@tromey.com>
4827
4828 * tui/tui-source.h (struct tui_source_window): Update.
4829 * tui/tui-regs.c (tui_show_registers): Update.
4830 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4831 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4832 (NO_REGS_STRING): Remove defines.
4833
48342019-08-20 Conrad Meyer <cem@FreeBSD.org>
4835
4836 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4837 unnecessary thread walk if remote doesn't support the packet.
4838
48392019-08-19 Tom Tromey <tromey@adacore.com>
4840
4841 * python/py-value.c (value_has_field): Fix indentation.
4842
48432019-08-19 Tom Tromey <tromey@adacore.com>
4844
4845 * printcmd.c (do_one_display, info_display_command): Update.
4846 * block.h (contained_in): Return bool. Add allow_nested
4847 parameter.
4848 * block.c (contained_in): Return bool. Add allow_nested
4849 parameter.
4850
48512019-08-19 Tom Tromey <tom@tromey.com>
4852
4853 * configure: Rebuild.
4854 * configure.ac: Disallow the combination of -static-libstdc++ and
4855 source highlight.
4856 * source-cache.c (get_language_name): Handle rust.
4857 (source_cache::get_source_lines): Ignore highlighting exceptions.
4858
48592019-08-16 Tom Tromey <tom@tromey.com>
4860
4861 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4862 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4863 (struct tui_source_window_base) <make_visible, refresh_window,
4864 resize>: Remove methods.
4865 <execution_info>: Remove field.
4866 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4867 (tui_show_source_line, tui_source_window_base)
4868 (~tui_source_window_base): Update.
4869 (tui_source_window_base::resize)
4870 (tui_source_window_base::make_visible)
4871 (tui_source_window_base::refresh_window): Remove.
4872 (tui_source_window_base::update_exec_info): Update.
4873 * tui/tui-source.c (tui_source_window::set_contents): Update.
4874 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4875
48762019-08-16 Tom Tromey <tom@tromey.com>
4877
4878 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4879 deprecated_query_hook.
4880
48812019-08-16 Tom Tromey <tom@tromey.com>
4882
4883 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4884 (tui_update_source_windows_with_line): Update.
4885 * tui/tui-source.h (struct tui_source_window)
4886 <show_symtab_source>: Declare.
4887 (tui_show_symtab_source): Don't declare.
4888 * tui/tui-source.c (tui_show_symtab_source): Rename from
4889 tui_show_symtab_source.
4890
48912019-08-16 Tom Tromey <tom@tromey.com>
4892
4893 * tui/tui-winsource.h (struct tui_source_window_base)
4894 <set_contents>: Declare.
4895 * tui/tui-winsource.c
4896 (tui_source_window_base::update_source_window_as_is): Update.
4897 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4898 Declare.
4899 (tui_set_source_content): Don't declare.
4900 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4901 tui_set_source_content.
4902 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4903 Declare.
4904 (tui_set_disassem_content): Don't declare.
4905 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4906 tui_set_disassem_content.
4907
49082019-08-16 Tom Tromey <tom@tromey.com>
4909
4910 * tui/tui-winsource.h (struct tui_source_window_base)
4911 <update_breakpoint_info>: Declare.
4912 (tui_update_breakpoint_info): Don't declare.
4913 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4914 (tui_update_all_breakpoint_info): Update.
4915 (tui_source_window_base::update_breakpoint_info): Rename from
4916 tui_update_breakpoint_info.
4917 (tui_source_window_base::update_exec_info): Update.
4918
49192019-08-16 Tom Tromey <tom@tromey.com>
4920
4921 * tui/tui-winsource.h (struct tui_source_window_base)
4922 <update_source_window>: Declare.
4923 (tui_update_source_window): Don't declare.
4924 * tui/tui-winsource.c
4925 (tui_source_window_base::update_source_window): Rename from
4926 tui_update_source_window.
4927 (tui_source_window_base::rerender): Update.
4928 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4929 * tui/tui-disasm.c (tui_show_disassem)
4930 (tui_show_disassem_and_update_source)
4931 (tui_disasm_window::maybe_update): Update.
4932
49332019-08-16 Tom Tromey <tom@tromey.com>
4934
4935 * tui/tui-winsource.h (struct tui_source_window_base)
4936 <update_source_window_as_is>: Declare.
4937 (tui_update_source_window_as_is): Don't declare.
4938 * tui/tui-winsource.c (tui_update_source_window): Update
4939 (tui_source_window_base::update_source_window_as_is): Rename from
4940 tui_update_source_window_as_is.
4941 (tui_source_window_base::refill): Update.
4942 * tui/tui-source.c (tui_show_symtab_source): Update.
4943 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4944 Update.
4945
49462019-08-16 Tom Tromey <tom@tromey.com>
4947
4948 * tui/tui-winsource.h (tui_update_source_window)
4949 (tui_update_source_window_as_is): Remove "noerror" parameter.
4950 * tui/tui-winsource.c (tui_update_source_window)
4951 (tui_update_source_window_as_is): Remove "noerror" parameter.
4952 (tui_update_source_windows_with_addr)
4953 (tui_update_source_windows_with_line)
4954 (tui_source_window_base::rerender)
4955 (tui_source_window_base::refill): Update.
4956 * tui/tui-source.h (tui_set_source_content)
4957 (tui_show_symtab_source): Remove "noerror" parameter.
4958 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4959 parameter.
4960 (tui_show_symtab_source): Likewise.
4961 (tui_source_window::maybe_update): Update.
4962 * tui/tui-disasm.c (tui_show_disassem)
4963 (tui_show_disassem_and_update_source)
4964 (tui_disasm_window::do_scroll_vertical)
4965 (tui_disasm_window::maybe_update): Update.
4966
49672019-08-16 Tom Tromey <tom@tromey.com>
4968
4969 * tui/tui.c (tui_is_window_visible): Update.
4970 * tui/tui-wingeneral.c (tui_make_window)
4971 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4972 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4973 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4974 (tui_set_win_height_command, parse_scrolling_args): Update.
4975 * tui/tui-source.c (tui_source_window::style_changed): Update.
4976 * tui/tui-regs.c (tui_show_registers)
4977 (tui_data_window::first_data_item_displayed)
4978 (tui_data_window::delete_data_content_windows)
4979 (tui_check_register_values, tui_reg_command): Update.
4980 * tui/tui-disasm.c (tui_show_disassem): Update.
4981 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4982 method.
4983 <is_visible>: Remove field.
4984 * tui/tui-data.c (tui_next_win, tui_prev_win)
4985 (tui_delete_invisible_windows): Update.
4986
49872019-08-16 Tom Tromey <tom@tromey.com>
4988
4989 * tui/tui-winsource.h (struct tui_source_window_base)
4990 <m_has_locator>: Remove.
4991 * tui/tui-layout.c (show_source_disasm_command, show_data)
4992 (show_source_or_disasm_and_command): Update.
4993
49942019-08-16 Alan Hayward <alan.hayward@arm.com>
4995
4996 * NEWS (Other MI changes): New subsection.
4997 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4998 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4999 * arch-utils.c (default_get_pc_address_flags): New function.
5000 * arch-utils.h (default_get_pc_address_flags): New declaration.
5001 * gdbarch.sh: Add get_pc_address_flags.
5002 * gdbarch.c: Regenerate.
5003 * gdbarch.h: Likewise.
5004 * stack.c (print_pc): New function.
5005 (print_frame_info) (print_frame): Call print_pc.
5006
50072019-08-16 Tom de Vries <tdevries@suse.de>
5008
5009 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5010 print_objfile_section_info.
5011
50122019-08-15 Tom Tromey <tom@tromey.com>
5013
5014 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5015 calling update_cmdwin_start_line.
5016 * tui/tui-winsource.h (struct tui_source_window_base)
5017 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5018 <rerender>: Declare.
5019 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5020 Call rerender.
5021 (tui_source_window_base::set_new_height): Remove.
5022 (tui_source_window_base::rerender): Rename from
5023 do_make_visible_with_new_height.
5024 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5025 resize method.
5026 (tui_win_info::make_invisible_and_set_new_height)
5027 (tui_win_info::make_visible_with_new_height): Remove.
5028 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5029 Declare.
5030 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5031 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5032 do_make_visible_with_new_height>: Don't declare.
5033 <rerender>: Declare.
5034 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5035 set_new_height.
5036 (tui_data_window::do_make_visible_with_new_height): Remove.
5037 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5038 call tui_show_locator_content.
5039 (tui_gen_win_info::resize): Call rerender.
5040 (show_source_or_disasm_and_command): Don't call
5041 tui_show_locator_content.
5042 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5043 method.
5044 (struct tui_win_info) <rerender>: Declare.
5045 <set_new_height, make_invisible_and_set_new_height,
5046 make_visible_with_new_height>: Don't declare.
5047 * tui/tui-data.c (tui_win_list::rerender): New method.
5048 * tui/tui-command.h (struct tui_cmd_window)
5049 <do_make_visible_with_new_height>: Don't declare.
5050 * tui/tui-command.c
5051 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5052
50532019-08-15 Tom Tromey <tromey@adacore.com>
5054
5055 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5056 * ada-lang.c (ada_enum_name): Likewise.
5057
50582019-08-15 Christian Biesinger <cbiesinger@google.com>
5059
5060 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5061 leading underscore.
5062 (GdbOutputErrorFile): Likewise.
5063 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5064 accordingly.
5065 (execute_unwinders): Rename to have a leading underscore.
5066 (auto_load_packages): Likewise.
5067 (global scope): Adjust call to auto_load_packages accordingly.
5068 (GdbSetPythonDirectory): Likewise.
5069 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5070 instead of execute_unwinders.
5071
50722019-08-15 Tom Tromey <tom@tromey.com>
5073
5074 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5075 (show_data): Don't change window visibility.
5076 (tui_gen_win_info::resize): Remove special case for command
5077 window. Use wresize, when available.
5078 (show_source_or_disasm_and_command): Don't change window
5079 visibility.
5080 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5081 <make_visible>: New method.
5082 * tui/tui-command.c (tui_cmd_window::resize): New method.
5083
50842019-08-15 Tom Tromey <tom@tromey.com>
5085
5086 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5087 (struct tui_source_windows): New.
5088 * tui/tui-winsource.c (tui_display_main): Update.
5089 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5090 (new_height_ok, parse_scrolling_args): Update.
5091 * tui/tui-layout.c (show_layout, show_data): Update.
5092 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5093 (tui_add_to_source_windows): Don't declare.
5094 * tui/tui-data.c (source_windows, tui_source_windows)
5095 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5096
50972019-08-15 Tom Tromey <tom@tromey.com>
5098
5099 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5100 Rename from reset.
5101 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5102 * tui/tui-layout.c (show_source_disasm_command, show_data):
5103 Update.
5104 (tui_gen_win_info::resize): Rename.
5105 (show_source_or_disasm_and_command): Update.
5106 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5107 reset.
5108
51092019-08-15 Tom Tromey <tom@tromey.com>
5110
5111 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5112 * tui/tui-interp.c (tui_interp::init): Don't call
5113 tui_initialize_static_data.
5114 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5115
51162019-08-15 Tom Tromey <tom@tromey.com>
5117
5118 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5119 examine tui_win_list.
5120
51212019-08-15 Tom Tromey <tom@tromey.com>
5122
5123 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5124 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5125 tui_clear_source_content.
5126 (tui_clear_source_content): Remove.
5127 (tui_source_window_base::do_erase_source_content): Hoist call to
5128 content.clear().
5129 * tui/tui-stack.c (tui_show_frame_info): Don't call
5130 tui_clear_source_content.
5131
51322019-08-15 Tom Tromey <tom@tromey.com>
5133
5134 * tui/tui-winsource.h (struct tui_source_window_base)
5135 <do_erase_source_content>: New method.
5136 <erase_source_content>: New method.
5137 (tui_erase_source_content): Don't declare.
5138 * tui/tui-winsource.c (tui_clear_source_content): Update.
5139 (tui_source_window_base::do_erase_source_content): Rename from
5140 tui_erase_source_content.
5141 (tui_source_window_base::show_source_content): Update.
5142 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5143 * tui/tui-source.h (struct tui_source_window)
5144 <erase_source_content>: New method.
5145 * tui/tui-disasm.h (struct tui_disasm_window)
5146 <erase_source_content>: New method.
5147
51482019-08-15 Tom Tromey <tom@tromey.com>
5149
5150 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5151 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5152 constructor.
5153 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5154 * tui/tui-source.c (tui_set_source_content): Update.
5155 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5156
51572019-08-15 Tom Tromey <tom@tromey.com>
5158
5159 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5160 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5161 tui-source.c.
5162 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5163 Declare.
5164 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5165 method.
5166 (tui_source_window::maybe_update): Update.
5167
51682019-08-15 Tom Tromey <tom@tromey.com>
5169
5170 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5171 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5172 tui-disasm.c.
5173 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5174 Declare.
5175 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5176 method.
5177 (tui_disasm_window::maybe_update): Update.
5178
51792019-08-15 Tom Tromey <tom@tromey.com>
5180
5181 * tui/tui-winsource.h (struct tui_source_window_base)
5182 <maybe_update>: Declare.
5183 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5184 method.
5185 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5186 Declare.
5187 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5188 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5189 Declare.
5190 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5191
51922019-08-15 Tom Tromey <tom@tromey.com>
5193
5194 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5195
51962019-08-15 Tom Tromey <tom@tromey.com>
5197
5198 * tui/tui-wingeneral.c: Include tui-stack.h.
5199 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5200 (struct tui_locator_window): Move from tui-data.h.
5201 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5202 (tui_initialize_static_data): Move from tui-data.c.
5203 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5204 (struct tui_locator_window): Move to tui-stack.c.
5205 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5206 (tui_initialize_static_data): Move to tui-stack.c.
5207
52082019-08-15 Tom Tromey <tom@tromey.com>
5209
5210 * tui/tui-layout.c (show_source_disasm_command)
5211 (show_source_or_disasm_and_command): Use make_visible method, not
5212 tui_make_window.
5213 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5214 Remove.
5215
52162019-08-15 Tom Tromey <tom@tromey.com>
5217
5218 * tui/tui-wingeneral.h (tui_make_window): Update.
5219 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5220 parameter.
5221 (tui_gen_win_info::make_visible): Update.
5222 * tui/tui-regs.c (tui_data_window::display_registers_from):
5223 Update.
5224 * tui/tui-layout.c (show_source_disasm_command)
5225 (show_source_or_disasm_and_command): Update.
5226 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5227 (enum tui_box): Remove.
5228 (struct tui_win_info) <can_box>: New method.
5229 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5230 method.
5231
52322019-08-15 Tom de Vries <tdevries@suse.de>
5233
5234 * linux-nat-trad.c: Include gdbarch.h.
5235
52362019-08-14 Alan Hayward <alan.hayward@arm.com>
5237
5238 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5239 register sizes.
5240
52412019-08-14 Tom Tromey <tromey@adacore.com>
5242
5243 * darwin-nat.c: Include gdbarch.h.
5244 * darwin-nat-info.c: Include gdbarch.h.
5245
52462019-08-13 Tom Tromey <tom@tromey.com>
5247
5248 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5249 Remove.
5250 * tui/tui-data.c (tui_initialize_static_data): Update.
5251
52522019-08-13 Tom Tromey <tom@tromey.com>
5253
5254 * tui/tui-winsource.h (struct tui_exec_info_window)
5255 <~tui_exec_info_window, maybe_allocate_content, get_content,
5256 m_content>: Remove.
5257 (struct tui_source_window_base) <set_exec_info_content,
5258 show_exec_info_content>: Don't declare.
5259 * tui/tui-winsource.c
5260 (tui_exec_info_window::maybe_allocate_content): Remove.
5261 (tui_source_window_base::update_exec_info): Rename from
5262 set_exec_info_content.
5263 (tui_source_window_base::show_exec_info_content)
5264 (tui_source_window_base::update_exec_info): Remove.
5265
52662019-08-13 Tom Tromey <tom@tromey.com>
5267
5268 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5269 declare.
5270 * tui/tui-winsource.c (tui_update_source_window_as_is)
5271 (tui_update_source_windows_with_addr, tui_erase_source_content):
5272 Update.
5273 (tui_clear_exec_info_content): Remove.
5274
52752019-08-13 Tom Tromey <tom@tromey.com>
5276
5277 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5278 declare.
5279 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5280 call tui_erase_exec_info_content.
5281 (tui_clear_exec_info_content): Rename from
5282 tui_erase_exec_info_content.
5283 (tui_clear_exec_info_content): Delete.
5284
52852019-08-13 Tom Tromey <tom@tromey.com>
5286
5287 * tui/tui-winsource.h (struct tui_source_window_base)
5288 <show_exec_info_content>: Declare.
5289 (tui_show_exec_info_content): Don't declare.
5290 * tui/tui-winsource.c
5291 (tui_source_window_base::show_exec_info_content): Rename from
5292 tui_show_exec_info_content.
5293 (tui_source_window_base::update_exec_info): Update.
5294
52952019-08-13 Tom Tromey <tom@tromey.com>
5296
5297 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5298 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5299 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5300 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5301 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5302 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5303 ... here.
5304
53052019-08-13 Tom Tromey <tom@tromey.com>
5306
5307 * tui/tui-winsource.h (struct tui_source_window_base)
5308 <update_exec_info>: Declare.
5309 (tui_update_exec_info): Don't declare.
5310 * tui/tui-winsource.c (tui_update_source_window_as_is)
5311 (tui_source_window_base::refresh_all)
5312 (tui_update_all_breakpoint_info): Update.
5313 (tui_source_window_base::update_exec_info): Rename from
5314 tui_update_exec_info.
5315 * tui/tui-stack.c (tui_show_frame_info): Update.
5316
53172019-08-13 Tom Tromey <tom@tromey.com>
5318
5319 * tui/tui-winsource.h (struct tui_source_window_base)
5320 <set_exec_info_content>: Declare.
5321 (tui_set_exec_info_content): Don't declare.
5322 * tui/tui-winsource.c
5323 (tui_source_window_base::set_exec_info_content): Rename from
5324 tui_set_exec_info_content.
5325 (tui_update_exec_info): Update.
5326
53272019-08-13 Tom Tromey <tom@tromey.com>
5328
5329 * tui/tui-winsource.h (struct tui_source_window_base)
5330 <show_source_content>: Declare.
5331 (tui_show_source_content): Don't declare.
5332 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5333 (tui_source_window_base::show_source_content): Rename from
5334 tui_show_source_content.
5335 (tui_source_window_base::refresh_all): Update.
5336 * tui/tui-layout.c (show_source_disasm_command)
5337 (show_source_or_disasm_and_command): Update.
5338
53392019-08-13 Tom Tromey <tom@tromey.com>
5340
5341 * tui/tui-winsource.c (tui_erase_source_content)
5342 (tui_show_source_content, tui_source_window_base::refresh_all):
5343 Update.
5344 * tui/tui-wingeneral.h
5345 (tui_check_and_display_highlight_if_needed): Don't declare.
5346 * tui/tui-wingeneral.c
5347 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5348 check_and_display_highlight_if_needed.
5349 * tui/tui-win.c (tui_rehighlight_all)
5350 (tui_win_info::make_visible_with_new_height): Update.
5351 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5352 (tui_data_window::erase_data_content)
5353 (tui_data_window::display_all_data): Update.
5354 * tui/tui-data.h (struct tui_win_info)
5355 <check_and_display_highlight_if_needed>: Declare.
5356
53572019-08-13 Tom Tromey <tom@tromey.com>
5358
5359 * tui/tui-win.c (tui_resize_all): Call
5360 tui_delete_invisible_windows.
5361 * tui/tui-layout.c (show_layout): Call
5362 tui_delete_invisible_windows.
5363 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5364 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5365
53662019-08-13 Tom Tromey <tom@tromey.com>
5367
5368 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5369 tui_add_win_to_layout.
5370
53712019-08-13 Tom Tromey <tom@tromey.com>
5372
5373 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5374 * tui/tui-layout.c (tui_default_win_height): Now static.
5375
53762019-08-13 Tom Tromey <tom@tromey.com>
5377
5378 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5379 single switch.
5380 (show_source_disasm_command, show_source_or_disasm_and_command):
5381 Don't check current layout.
5382
53832019-08-13 Tom Tromey <tom@tromey.com>
5384
5385 * tui/tui-wingeneral.c (make_all_visible): Remove.
5386 (tui_make_all_invisible): Simplify.
5387 * tui/tui-layout.c (tui_make_all_invisible): Move from
5388 tui-wingeneral.c; simplify.
5389 (show_layout): Hoist call to tui_make_all_invisible.
5390 (show_data): Don't call tui_make_all_invisible.
5391
53922019-08-13 Tom Tromey <tom@tromey.com>
5393
5394 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5395 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5396
53972019-08-13 Tom Tromey <tom@tromey.com>
5398
5399 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5400 tui-data.c.
5401 (show_source_disasm_command, show_data)
5402 (show_source_or_disasm_and_command): Don't use
5403 tui_set_current_layout_to.
5404 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5405 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5406 tui-layout.c.
5407 (tui_set_current_layout_to): Remove.
5408
54092019-08-13 Tom Tromey <tom@tromey.com>
5410
5411 * tui/tui-layout.c (tui_set_layout): Update.
5412 * tui/tui-data.h (struct tui_layout_def): Remove.
5413 (tui_layout_def): Don't declare.
5414 * tui/tui-data.c (layout_def): Remove.
5415 (tui_layout_def): Remove.
5416
54172019-08-13 Tom Tromey <tom@tromey.com>
5418
5419 * tui/tui-winsource.h (struct tui_source_window_base)
5420 <clear_detail>: No longer "override".
5421 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5422 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5423 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5424 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5425 Remove.
5426 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5427
54282019-08-13 Tom Tromey <tromey@adacore.com>
5429
5430 * tracepoint.c: Don't include readline.h or history.h.
5431
54322019-08-12 Tom Tromey <tom@tromey.com>
5433
5434 * configure: Rebuild.
5435 * configure.ac: Check for readline 7.
5436 * NEWS: Mention readline 7 requirement.
5437 * README: Update.
5438
54392019-08-12 Tom Tromey <tom@tromey.com>
5440
5441 * mingw-hdep.c (gdb_select): Remove readline hack.
5442
54432019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5444
5445 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5446 when the function fails.
5447
54482019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5449
5450 * s390-tdep.c (s390_type_align): New function.
5451 (s390_gdbarch_init): Set it as type_align gdbarch method.
5452
54532019-08-09 Tom de Vries <tdevries@suse.de>
5454
5455 PR gdb/24591
5456 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5457 pc_low with relocation offset.
5458
54592019-08-07 Tom Tromey <tromey@adacore.com>
5460
5461 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5462 (print_frame_args): Update.
5463 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5464 Update.
5465 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5466 * frame.h (struct frame_arg): Add initializers.
5467 <error>: Now a unique_xmalloc_ptr.
5468
54692019-08-07 Alan Hayward <alan.hayward@arm.com>
5470
5471 * NEWS: Expand the Pointer Authentication entry.
5472 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5473 (aarch64_frame_unmask_lr): ... to this.
5474 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5475 Call aarch64_frame_unmask_lr.
5476 * frame.c (struct frame_info): Add "masked" variable.
5477 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5478 (fprint_frame): Check for masked pc.
5479 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5480 declarations.
5481 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5482 * stack.c (print_frame): Check for masked pc.
5483
54842019-08-06 Tom Tromey <tom@tromey.com>
5485
5486 * stabsread.c (patch_block_stabs, read_one_struct_field)
5487 (read_enum_type): Use obstack_strndup.
5488 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5489 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5490 * dwarf2read.c (guess_full_die_structure_name)
5491 (anonymous_struct_prefix): Use obstack_strndup.
5492 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5493 * c-exp.y (yylex): Use obstack_strndup.
5494 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5495 (write_var_or_type): Use obstack_strndup.
5496
54972019-08-06 Tom Tromey <tom@tromey.com>
5498
5499 * symfile.c (reread_symbols): Use obstack_strdup.
5500 * stabsread.c (read_type): Use obstack_strdup.
5501 * gdb_obstack.h (obstack_strdup): New overload.
5502 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5503 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5504 (dwarf2_canonicalize_name): Use obstack_strdup.
5505 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5506 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5507 Use obstack_strdup.
5508
55092019-08-06 Tom Tromey <tom@tromey.com>
5510
5511 * gdb_obstack.h (obstack_strdup): Define.
5512 * gdb_obstack.c (obstack_strdup): Don't define.
5513
55142019-08-06 Tom Tromey <tom@tromey.com>
5515
5516 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5517 obstack_strdup.
5518 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5519 obstack_strdup.
5520 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5521 * stabsread.c (common_block_start): Use obstack_strdup.
5522 * objfiles.c (set_objfile_main_name, objfile): Use
5523 obstack_strdup.
5524 * namespace.c (add_using_directive): Use obstack_strdup.
5525 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5526 * jit.c (finalize_symtab): Use obstack_strdup.
5527 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5528 (guess_partial_die_structure_name, partial_die_info::fixup)
5529 (dwarf2_name): Use obstack_strdup.
5530 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5531 obstack_strdup.
5532 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5533 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5534 obstack_strdup.
5535 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5536
55372019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5538
5539 * unittests/help-doc-selftests.c: New file.
5540 * Makefile.in: Add the new file.
5541
55422019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5543
5544 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5545 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5546 the full first line, except when FOR_VALUE_PREFIX. In this case,
5547 the trailing '.' is not output, and the first character is uppercased.
5548 (print_help_for_command): Update call to print_doc_line.
5549 (print_doc_of_command): Likewise.
5550 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5551 * cli/cli-option.c (append_indented_doc): Do not append newline.
5552 (build_help_option): Append newline after first appended_indented_doc
5553 only if a second call is done.
5554 (build_help): Append 2 new lines before each option, except the first
5555 one.
5556 * compile/compile.c (_initialize_compile): Add new lines after
5557 %OPTIONS%, when not at the end of the help.
5558 Change help doc or code
5559 producing the help doc to respect the invariants.
5560 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5561 Also removed the new line after 'Options:', as all other commands
5562 do not put an empty line between 'Options:' and the first option.
5563 * printcmd.c (_initialize_printcmd): Likewise.
5564 * stack.c (_initialize_stack): Likewise.
5565 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5566 incorrectly telling COMMAND is optional.
5567 * ada-lang.c (_initialize_ada_language): Change help doc or code
5568 producing the help doc to respect the invariants.
5569 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5570 * breakpoint.c (_initialize_breakpoint): Likewise.
5571 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5572 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5573 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5574 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5575 _initialize_cli_style): Likewise.
5576 * corelow.c (core_target_info): Likewise.
5577 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5578 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5579 * filesystem.c (_initialize_filesystem): Likewise.
5580 * frame.c (_initialize_frame): Likewise.
5581 * gnu-nat.c (add_task_commands): Likewise.
5582 * infcall.c (_initialize_infcall): Likewise.
5583 * infcmd.c (_initialize_infcmd): Likewise.
5584 * interps.c (_initialize_interpreter): Likewise.
5585 * language.c (_initialize_language): Likewise.
5586 * linux-fork.c (_initialize_linux_fork): Likewise.
5587 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5588 * maint.c (_initialize_maint_cmds): Likewise.
5589 * memattr.c (_initialize_mem): Likewise.
5590 * printcmd.c (_initialize_printcmd): Likewise.
5591 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5592 _RegEx): Likewise.
5593 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5594 * record-btrace.c (_initialize_record_btrace): Likewise.
5595 * record-full.c (_initialize_record_full): Likewise.
5596 * record.c (_initialize_record): Likewise.
5597 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5598 * regcache.c (_initialize_regcache): Likewise.
5599 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5600 _initialize_remote): Likewise.
5601 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5602 * serial.c (_initialize_serial): Likewise.
5603 * skip.c (_initialize_step_skip): Likewise.
5604 * source.c (_initialize_source): Likewise.
5605 * stack.c (_initialize_stack): Likewise.
5606 * symfile.c (_initialize_symfile): Likewise.
5607 * symtab.c (_initialize_symtab): Likewise.
5608 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5609 * top.c (init_main): Likewise.
5610 * tracefile-tfile.c (tfile_target_info): Likewise.
5611 * tracepoint.c (_initialize_tracepoint): Likewise.
5612 * tui/tui-win.c (_initialize_tui_win): Likewise.
5613 * utils.c (add_internal_problem_command): Likewise.
5614 * valprint.c (value_print_option_defs): Likewise.
5615
56162019-08-06 Frank Ch. Eigler <fche@redhat.com>
5617
5618 PR build/24886
5619 * configure.ac: Drop enable-libmcheck support.
5620 * configure, config.in: Rebuild.
5621 * libmcheck.m4: Remove.
5622 * acinclude.m4: Don't include it.
5623 * Makefile.in: Don't distribute it.
5624 * top.c (print_gdb_configuration): Don't mention it.
5625
56262019-08-06 Tom Tromey <tom@tromey.com>
5627
5628 * utils.c (set_output_style): Sometimes pass stream to
5629 emit_style_escape.
5630 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5631 * record-btrace.c (btrace_insn_history): Update.
5632 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5633 method.
5634 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5635 Update initializers.
5636 <m_uiout>: New field.
5637 <m_di>: Move lower.
5638 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5639 Remove "uiout" parameter.
5640 (dump_insns): Update.
5641 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5642 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5643
56442019-08-06 Christian Biesinger <cbiesinger@google.com>
5645
5646 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5647 (error_in_psymtab_expansion): Likewise.
5648 (lookup_symbol_via_quick_fns): Likewise.
5649 (basic_lookup_transparent_type_quick): Likewise.
5650 (basic_lookup_transparent_type_1): Likewise.
5651
56522019-08-06 Tom Tromey <tromey@adacore.com>
5653
5654 * source.c (last_source_error): Now bool.
5655 (print_source_lines_base): Make "noprint" bool. Only open
5656 source file when last_source_visited changes.
5657
56582019-08-06 Tom Tromey <tromey@adacore.com>
5659
5660 * annotate.c (annotate_source_line): Use g_source_cache.
5661 * source-cache.c (source_cache::get_plain_source_lines): Change
5662 parameters. Populate m_offset_cache.
5663 (source_cache::ensure): New method.
5664 (source_cache::get_line_charpos): New method.
5665 (extract_lines): Move lower. Change parameters.
5666 (source_cache::get_source_lines): Move lower.
5667 * source-cache.h (class source_cache): Update comment.
5668 <get_line_charpos>: New method.
5669 <get_source_lines>: Update comment.
5670 <clear>: Clear m_offset_cache.
5671 <get_plain_source_lines>: Change parameters.
5672 <ensure>: New method
5673 <m_offset_cache>: New member.
5674 * source.c (forget_cached_source_info_for_objfile): Update.
5675 (info_source_command): Use g_source_cache.
5676 (find_source_lines, open_source_file_with_line_charpos): Remove.
5677 (print_source_lines_base, search_command_helper): Use g_source_cache.
5678 * source.h (open_source_file_with_line_charpos): Don't declare.
5679 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5680 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5681 Use g_source_cache.
5682
56832019-08-06 Tom Tromey <tromey@adacore.com>
5684
5685 * source-cache.c (source_cache::get_plain_source_lines):
5686 Remove "first_line" and "last_line" parameters.
5687 (source_cache::get_source_lines): Cache plain text.
5688 * source-cache.h (class source_cache)
5689 <get_plain_source_lines>: Update.
5690
56912019-08-06 Tom Tromey <tromey@adacore.com>
5692
5693 * source-cache.c (extract_lines): No longer a method.
5694 Changed type of parameter. Include final newline.
5695 (selftests::extract_lines_test): New function.
5696 (_initialize_source_cache): Likewise.
5697 * source-cache.h (class source_cache)
5698 <extract_lines>: Don't declare.
5699
57002019-08-06 Tom Tromey <tromey@adacore.com>
5701
5702 * breakpoint.c (init_breakpoint_sal): Update.
5703 (breakpoint): Update.
5704 * breakpoint.h (struct breakpoint) <filter>: Now a
5705 unique_xmalloc_ptr.
5706
57072019-08-05 Christian Biesinger <cbiesinger@google.com>
5708
5709 * NEWS: Mention dictionary access on blocks.
5710 * python/py-block.c (blpy_getitem): New function.
5711 (block_object_as_mapping): New struct.
5712 (block_object_type): Use new struct for tp_as_mapping field.
5713
57142019-08-05 Christian Biesinger <cbiesinger@google.com>
5715
5716 * objfiles.h (objfile): Add a comment describing partial symbols.
5717
57182019-08-05 Tom Tromey <tromey@adacore.com>
5719
5720 * compile/compile.c (_initialize_compile): Use _(), not N_().
5721 * thread.c (_initialize_thread): Use _(), not N_().
5722 * stack.c (_initialize_stack): Use _(), not N_().
5723 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5724
57252019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5726
5727 * dwarf2read.c (struct dw2_symtab_iterator):
5728 <want_specific_block>: Remove.
5729 <block_index>: Change type to gdb::optional.
5730 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5731 change type of BLOCK_INDEX parameter to gdb::optional.
5732 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5733 (dw2_lookup_symbol): Don't pass argument for
5734 WANT_SPECIFIC_BLOCK.
5735 (dw2_expand_symtabs_for_function): Don't pass argument for
5736 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5737 (class dw2_debug_names_iterator)
5738 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5739 parameter, change BLOCK_INDEX type to gdb::optional.
5740 <m_want_specific_block>: Remove.
5741 <m_block_index>: Change type to gdb::optional.
5742 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5743 gdb::optional. Re-write in function of gdb::optional.
5744 (dw2_debug_names_lookup_symbol): Don't pass argument for
5745 WANT_SPECIFIC_BLOCK.
5746 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5747 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5748 BLOCK_INDEX.
5749
57502019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5751
5752 * NEWS: Mention changes to "info sources" command.
5753
57542019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5755
5756 * symtab.c (filename_partial_match_opts): New struct type.
5757 (struct output_source_filename_data): New members
5758 regexp, c_regexp, partial_match.
5759 (output_source_filename): Use new members to decide to print file.
5760 (info_sources_option_defs): New variable.
5761 (make_info_sources_options_def_group, print_info_sources_header,
5762 info_sources_command_completer):
5763 New functions.
5764 (info_sources_command): Read new optional arguments.
5765 (_initialize_symtab): Update info sources help.
5766
57672019-08-02 Alexandre Oliva <oliva@adacore.com>
5768
5769 * ada-lang.c (exception_support_info_v0): Renamed from...
5770 (default_exception_support_info): ... this. Create new
5771 definition for v1.
5772 (ada_has_this_exception_support): Look up catch_handlers_sym.
5773 (ada_exception_support_info_sniffer): Try v0 after default.
5774
57752019-08-01 Tom Tromey <tromey@adacore.com>
5776
5777 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5778 gdbarch.h.
5779
57802019-08-01 Christian Biesinger <cbiesinger@google.com>
5781
5782 * s12z-tdep.c: Fix include path for s12z-opc.h.
5783
57842019-08-01 Alan Hayward <alan.hayward@arm.com>
5785
5786 * NEWS: Require GNU make 3.82.
5787
57882019-07-16 Tom Tromey <tom@tromey.com>
5789
5790 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5791 declare.
5792
57932019-07-30 Tom Tromey <tromey@adacore.com>
5794
5795 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5796
57972019-07-30 Kevin Buettner <kevinb@redhat.com>
5798
5799 * printcmd.c (print_address_symbolic): Print negative offsets.
5800 (build_address_symbolic): Force signed arithmetic when computing
5801 offset.
5802
58032019-07-30 Christian Biesinger <cbiesinger@google.com>
5804
5805 PR/24474: Add a function to lookup static variables.
5806 * NEWS: Mention this new function.
5807 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5808 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5809 * python/python.c (python_GdbMethods): Add new function.
5810
58112019-07-29 Christian Biesinger <cbiesinger@google.com>
5812
5813 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5814 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5815 (objfpy_lookup_static_symbol): New function.
5816 (objfile_object_methods): Add new functions.
5817
58182019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5819
5820 * NEWS: Mention 'set|show print frame-info'. Mention new
5821 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5822 backtrace argument. Mention that python frame filtering code
5823 is now consistent with what 'backtrace' command prints.
5824
58252019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5826
5827 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5828 comments.
5829 (print_frame_info_auto, print_frame_info_source_line,
5830 print_frame_info_location, print_frame_info_source_and_location,
5831 print_frame_info_location_and_address, print_frame_info_short_location):
5832 New declarations.
5833 (struct frame_print_options): New member print_frame_info.
5834 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5835 * stack.h (get_user_print_what_frame_info): New declaration.
5836 (frame_show_address): New declaration.
5837 * stack.c (print_frame_arguments_choices): New value 'presence'.
5838 (print_frame_info_auto, print_frame_info_source_line,
5839 print_frame_info_location, print_frame_info_source_and_location,
5840 print_frame_info_location_and_address, print_frame_info_short_location,
5841 print_frame_info_choices, print_frame_info_print_what): New definitions.
5842 (print_frame_args): Only print dots for args if print frame-arguments
5843 is 'presence'.
5844 (frame_print_option_defs): New element for "frame-info".
5845 (get_user_print_what_frame_info): New function.
5846 (frame_show_address): Make non static. Move comment to stack.h.
5847 (print_frame_info_to_print_what): New function.
5848 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5849 to decide what to print.
5850 (backtrace_command_1): Handle the new print_frame_arguments_presence
5851 value.
5852 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5853 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5854 (py_print_frame): In non-mi mode, use LOCATION as default for
5855 print_what, similarly to frame information printed directly by
5856 backtrace command. Handle frame-info user option in non MI mode.
5857
58582019-07-27 Kevin Buettner <kevinb@redhat.com>
5859
5860 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5861 Add case for debugging 32-bit target on 64-bit host. Revise
5862 comment.
5863
58642019-07-27 Kevin Buettner <kevinb@redhat.com>
5865
5866 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5867 instead of find_function_entry_range_from_pc.
5868
58692019-07-27 Kevin Buettner <kevinb@redhat.com>
5870
5871 * stack.c (find_frame_funname): Remove code which preferred
5872 minsym over symtab sym in "certain pathological cases".
5873
5874 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5875 parameter. Change type of "do_demangle" to bool.
5876 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5877 Pass suitable "prefer_sym_over_minsym" flag to
5878 build_address_symbolic(). Don't output "+" for negative offsets.
5879 * printcmd.c (print_address_symbolic): Update invocation of
5880 build_address_symbolic to include a "prefer_sym_over_minsym"
5881 flag.
5882 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5883 Restrict cases in which use of minimal symbol is preferred to that
5884 of a found symbol. Update comments.
5885
5886 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5887 for entry pc when entry pc is out of range for that FDE.
5888
58892019-07-26 Brian Callahan <bcallah@openbsd.org>
5890
5891 PR gdb/24839:
5892 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5893 type.
5894
58952019-07-25 Christian Biesinger <cbiesinger@google.com>
5896
5897 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5898 this function's Python signature.
5899
5900
59012019-07-24 Christian Biesinger <cbiesinger@google.com>
5902
5903 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5904 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5905 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5906 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5907 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5908
5909
59102019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5911
5912 * h8300-tdep.c (h8300_register_name_common): New.
5913 h8300_register_name): Use h8300_register_name_common.
5914 (h8300s_register_name): Likewise.
5915 (h8300sx_register_name): Likewise.
5916 (h8300h_register_nam): New.
5917 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5918
5919
59202019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5921
5922 * arm-tdep.c (arm_skip_cmse_entry): New function.
5923 (arm_is_sgstubs_section): New function.
5924 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5925
59262019-07-22 Tom Tromey <tom@tromey.com>
5927
5928 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5929 Don't self-assign.
5930
59312019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5932
5933 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5934 type_print.
5935
59362019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5937
5938 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5939 so that GDB doesn't match any msymbols when searching in the
5940 TYPES_DOMAIN.
5941 (print_symbol_info): Print using typedef_print or type_print based
5942 on the type of the symbol. Add updated FIXME comment moved from...
5943 (_initialize_symtab): ... move and update FIXME comment to above.
5944
59452019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5946
5947 * NEWS: Mention adding -q option to "info types".
5948 * symtab.c (struct info_types_options): New struct.
5949 (info_types_options_defs): New variable.
5950 (make_info_types_options_def_group): New function.
5951 (info_types_command): Use gdb::option framework to parse options.
5952 (info_types_command_completer): New function.
5953 (_initialize_symtab): Extend the help text on "info types" and
5954 register command completer.
5955
59562019-07-21 Christian Biesinger <cbiesinger@google.com>
5957
5958 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5959 (lookup_symbol_in_objfile): Change int to block_enum and add a
5960 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5961
59622019-07-20 Christian Biesinger <cbiesinger@google.com>
5963
5964 * MAINTAINERS (Write After Approval): Add self.
5965
59662019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
5967
5968 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5969 instruction to the dummy code region.
5970
59712019-07-19 Tom Tromey <tromey@adacore.com>
5972
5973 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5974 (ARGSUSED, PARAMS, __func__): Remove rules.
5975
59762019-07-19 Alan Hayward <alan.hayward@arm.com>
5977
5978 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5979 * features/arm/arm-with-iwmmxt.c: Remove.
5980 * features/arm/arm-with-iwmmxt.xml: Remove.
5981 * features/arm/arm-with-m-fpa-layout.c: Remove.
5982 * features/arm/arm-with-m-fpa-layout.xml: Remove.
5983 * features/arm/arm-with-m-vfp-d16.c: Remove.
5984 * features/arm/arm-with-m-vfp-d16.xml: Remove.
5985 * features/arm/arm-with-m.c: Remove.
5986 * features/arm/arm-with-m.xml: Remove.
5987 * features/arm/arm-with-neon.c: Remove.
5988 * features/arm/arm-with-neon.xml: Remove.
5989 * features/arm/arm-with-vfpv2.c: Remove.
5990 * features/arm/arm-with-vfpv2.xml: Remove.
5991 * features/arm/arm-with-vfpv3.c: Remove.
5992 * features/arm/arm-with-vfpv3.xml: Remove.
5993
59942019-07-19 Alan Hayward <alan.hayward@arm.com>
5995
5996 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5997
59982019-07-19 Alan Hayward <alan.hayward@arm.com>
5999
6000 * arch/aarch32.c (aarch32_create_target_description): Create
6001 target descriptions using features.
6002 * arch/arm.c (arm_create_target_description)
6003 (arm_create_mprofile_target_description): Likewise.
6004 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6005
60062019-07-19 Alan Hayward <alan.hayward@arm.com>
6007
6008 * Makefile.in: Add new files.
6009 * aarch32-tdep.c: New file.
6010 * aarch32-tdep.h: New file.
6011 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6012 Call aarch32_read_description.
6013 * arch/aarch32.c: New file.
6014 * arch/aarch32.h: New file.
6015 * arch/arm.c (arm_create_target_description)
6016 (arm_create_mprofile_target_description): New function.
6017 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6018 (arm_create_target_description)
6019 (arm_create_mprofile_target_description): New declaration.
6020 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6021 read_description functions.
6022 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6023 Likewise.
6024 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6025 * arm-tdep.c (tdesc_arm_list): New variable.
6026 (arm_register_g_packet_guesses): Call create description functions.
6027 (arm_read_description) (arm_read_mprofile_description): New
6028 function.
6029 * arm-tdep.h (arm_read_description)
6030 (arm_read_mprofile_description): Add declaration.
6031 * configure.tgt: Add new files.
6032
60332019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6034
6035 * top.c (new_ui_command): Open specified terminal just once.
6036
60372019-07-18 Tom Tromey <tromey@adacore.com>
6038
6039 * symtab.c (main_name): Constify return type.
6040 * symfile.c (set_initial_language): Update.
6041 * symtab.h (main_name): Constify return type.
6042
60432019-07-17 Tom Tromey <tom@tromey.com>
6044
6045 * tui/tui-winsource.c (tui_update_source_window)
6046 (tui_update_source_window_as_is)
6047 (tui_update_source_windows_with_line): Remove return.
6048 * tui/tui-disasm.c (tui_show_disassem)
6049 (tui_show_disassem_and_update_source): Remove return.
6050 * tui/tui.c (tui_reset): Remove return.
6051 * tui/tui-wingeneral.c
6052 (tui_check_and_display_highlight_if_needed): Remove return.
6053
60542019-07-17 Tom Tromey <tom@tromey.com>
6055
6056 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6057
60582019-07-17 Tom Tromey <tom@tromey.com>
6059
6060 * tui/tui-winsource.h (struct tui_exec_info_window)
6061 (struct tui_source_window_base): Move from tui-data.h.
6062 * tui/tui-winsource.c: Move many method definitions from
6063 elsewhere. Remove "structuring" comments.
6064 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6065 (tui_source_window_base::refresh_window): Move to
6066 tui-winsource.c.
6067 * tui/tui-win.c (tui_source_window_base::refresh_all)
6068 (tui_source_window_base::update_tab_width)
6069 (tui_source_window_base::set_new_height)
6070 (tui_source_window_base::do_make_visible_with_new_height): Move to
6071 tui-winsource.c.
6072 * tui/tui-source.h: Update.
6073 * tui/tui-source.c (tui_source_window_base::reset): Move to
6074 tui-winsource.c.
6075 * tui/tui-disasm.h: Update.
6076 * tui/tui-data.h (struct tui_exec_info_window): Move to
6077 tui-winsource.h.
6078 (struct tui_source_window_base): Likewise.
6079 * tui/tui-data.c (tui_source_window_base::clear_detail)
6080 (tui_source_window_base, ~tui_source_window_base): Move to
6081 tui-winsource.c.
6082
60832019-07-17 Tom Tromey <tom@tromey.com>
6084
6085 * tui/tui-win.c (tui_resize_all)
6086 (tui_source_window_base::update_tab_width)
6087 (tui_adjust_win_heights): Update.
6088 (tui_win_info::make_invisible_and_set_new_height): Rename from
6089 make_invisible_and_set_new_height.
6090 * tui/tui-data.h (struct tui_win_info)
6091 <make_invisible_and_set_new_height>: New method.
6092
60932019-07-17 Tom Tromey <tom@tromey.com>
6094
6095 * tui/tui.c: Update.
6096 * tui/tui-source.h (struct tui_source_window): Move from
6097 tui-data.h.
6098 * tui/tui-layout.c: Update.
6099 * tui/tui-disasm.c: Update.
6100 * tui/tui-data.h (struct tui_source_window): Move to
6101 tui-source.h.
6102
61032019-07-17 Tom Tromey <tom@tromey.com>
6104
6105 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6106 tui-data.h.
6107 * tui/tui-data.h (struct tui_disasm_window): Move to
6108 tui-disasm.h.
6109
61102019-07-17 Tom Tromey <tom@tromey.com>
6111
6112 * tui/tui-regs.h (struct tui_data_item_window): Move from
6113 tui-data.h.
6114 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6115 * tui/tui-data.h (struct tui_data_item_window): Move to
6116 tui-regs.h.
6117 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6118
61192019-07-17 Tom Tromey <tom@tromey.com>
6120
6121 * tui/tui.c: Update.
6122 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6123 (tui_cmd_window::max_height): Move to tui-command.c.
6124 * tui/tui-layout.c: Update.
6125 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6126 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6127 tui-command.c.
6128 * tui/tui-command.h (struct tui_cmd_window): Move from
6129 tui-data.h.
6130 * tui/tui-command.c: Remove "structuring" comments.
6131 (tui_cmd_window::clear_detail)
6132 (tui_cmd_window::do_make_visible_with_new_height)
6133 (tui_cmd_window::max_height): Move from elsewhere.
6134
61352019-07-17 Tom Tromey <tom@tromey.com>
6136
6137 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6138 Now static.
6139 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6140 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6141
61422019-07-17 Tom Tromey <tom@tromey.com>
6143
6144 * tui/tui.c: Update.
6145 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6146 tui-regs.c.
6147 * tui/tui-windata.h: Remove file.
6148 * tui/tui-windata.c: Remove file.
6149 * tui/tui-win.c (tui_data_window::set_new_height)
6150 (tui_data_window::do_make_visible_with_new_height): Move to
6151 tui-regs.c.
6152 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6153 * tui/tui-regs.c: Remove "structuring" comments.
6154 (tui_data_window::first_data_item_displayed)
6155 (tui_data_window::delete_data_content_windows)
6156 (tui_data_window::erase_data_content)
6157 (tui_data_window::display_all_data)
6158 (tui_data_window::refresh_all)
6159 (tui_data_window::do_scroll_vertical)
6160 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6161 (tui_data_window::do_make_visible_with_new_height)
6162 (tui_data_window::refresh_window): Move from elsewhere.
6163 (_initialize_tui_regs): Move to end of file.
6164 * tui/tui-layout.c: Update.
6165 * tui/tui-hooks.c: Update.
6166 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6167 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6168 tui-regs.c.
6169 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6170
61712019-07-17 Tom Tromey <tom@tromey.com>
6172
6173 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6174 seen.
6175
61762019-07-17 Tom Tromey <tom@tromey.com>
6177
6178 * tui/tui-win.c (tui_source_window_base::set_new_height)
6179 (tui_source_window_base::do_make_visible_with_new_height): Use
6180 m_has_locator field directly.
6181 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6182 method.
6183 (struct tui_source_window_base) <has_locator>: Likewise.
6184
61852019-07-17 Tom Tromey <tom@tromey.com>
6186
6187 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6188 Don't declare.
6189 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6190 Remove.
6191 * tui/tui-win.c (tui_source_window_base::set_new_height)
6192 (tui_source_window_base::set_new_height)
6193 (make_invisible_and_set_new_height)
6194 (tui_source_window_base::do_make_visible_with_new_height)
6195 (tui_source_window_base::do_make_visible_with_new_height):
6196 Update.
6197 * tui/tui-layout.c (show_source_disasm_command, show_data)
6198 (show_source_or_disasm_and_command): Update.
6199 * tui/tui-layout.c (show_layout): Update.
6200
62012019-07-17 Tom Tromey <tom@tromey.com>
6202
6203 * tui/tui-layout.c (make_data_window): Remove.
6204 (show_data): Unify creation and re-initialization cases.
6205
62062019-07-17 Tom Tromey <tom@tromey.com>
6207
6208 * tui/tui-layout.c (make_source_window, make_disasm_window):
6209 Remove.
6210 (show_data): Unify creation and re-initialization cases.
6211
62122019-07-17 Tom Tromey <tom@tromey.com>
6213
6214 * tui/tui-layout.c (make_command_window): Remove.
6215 (show_source_disasm_command, show_source_or_disasm_and_command):
6216 Unify creation and re-initialization cases.
6217
62182019-07-17 Tom Tromey <tom@tromey.com>
6219
6220 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6221 creation and re-initialization cases.
6222
62232019-07-17 Tom Tromey <tom@tromey.com>
6224
6225 * tui/tui-regs.c (tui_get_register): Return void.
6226
62272019-07-17 Tom Tromey <tom@tromey.com>
6228
6229 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6230 Simplify.
6231
62322019-07-17 Tom Tromey <tom@tromey.com>
6233
6234 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6235 resetting.
6236
62372019-07-17 Tom Tromey <tom@tromey.com>
6238
6239 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6240 * tui/tui-regs.c (tui_reg_layout): New function.
6241 (tui_show_registers, tui_reg_command): Use it.
6242 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6243 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6244 parameters.
6245 (tui_layout_command): Remove.
6246
62472019-07-17 Tom Tromey <tom@tromey.com>
6248
6249 * tui/tui-layout.h (tui/tui-layout): Return void.
6250 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6251
62522019-07-17 Tom Tromey <tom@tromey.com>
6253
6254 * tui/tui-layout.c (show_source_disasm_command, show_data):
6255 Update.
6256 (reset_locator): Remove.
6257 (show_source_or_disasm_and_command): Update.
6258
62592019-07-17 Tom Tromey <tom@tromey.com>
6260
6261 * tui/tui-source.c (tui_source_window_base::reset): Remove
6262 win_type parameter.
6263 * tui/tui-layout.c (make_command_window, make_source_window)
6264 (make_disasm_window, make_data_window)
6265 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6266 (reset_locator, show_source_or_disasm_and_command): Update.
6267 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6268 win_type parameter.
6269 (struct tui_source_window_base) <reset>: Likewise.
6270
62712019-07-17 Tom Tromey <tom@tromey.com>
6272
6273 * tui/tui-layout.c (show_source_disasm_command): Use
6274 reset_locator.
6275 (reset_locator): New function.
6276 (init_and_make_win): Remove.
6277 (show_source_or_disasm_and_command): Use reset_locator.
6278
62792019-07-17 Tom Tromey <tom@tromey.com>
6280
6281 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6282 condition.
6283 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6284 Remove condition.
6285 * tui/tui-source.c (tui_source_window_base::reset): New method.
6286 * tui/tui-layout.c (make_command_window): Don't call
6287 init_and_make_win.
6288 (make_source_window, make_disasm_window): Don't call
6289 make_source_or_disasm_window.
6290 (make_data_window): Don't call init_and_make_win. Change calling
6291 convention.
6292 (show_source_disasm_command, show_data): Simplify.
6293 (make_source_or_disasm_window): Remove.
6294 (show_source_or_disasm_and_command): Simplify.
6295 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6296 (struct tui_source_window_base) <reset>: Likewise.
6297 <execution_info>: Remove initializer.
6298 * tui/tui-data.c (tui_source_window_base): Initialize
6299 execution_info.
6300
63012019-07-17 Tom Tromey <tom@tromey.com>
6302
6303 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6304 variable.
6305
63062019-07-17 Tom Tromey <tom@tromey.com>
6307
6308 * tui/tui.c (tui_rl_other_window): Update.
6309 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6310 superclass method first. Always iterate over regs_content.
6311 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6312 method.
6313 * tui/tui-win.c (tui_set_focus_command): Update.
6314
63152019-07-17 Tom Tromey <tom@tromey.com>
6316
6317 * tui/tui-win.c (tui_set_focus_command): Rename from
6318 tui_set_focus. Call tui_enable.
6319 (tui_set_focus_command): Remove.
6320
63212019-07-17 Tom Tromey <tom@tromey.com>
6322
6323 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6324 refresh_window.
6325 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6326 touchwin.
6327 (tui_data_window::refresh_window): Call refresh_window on data
6328 items. Always call superclass refresh_window.
6329 (tui_win_info::refresh): Remove.
6330 (tui_source_window_base::refresh_window): Update.
6331 (tui_refresh_all): Update.
6332 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6333 refresh_window.
6334 (show_source_or_disasm_and_command): Likewise.
6335 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6336 (struct tui_source_window_base) <refresh>: Likewise.
6337
63382019-07-17 Tom Tromey <tom@tromey.com>
6339
6340 * tui/tui-winsource.c (tui_clear_source_content)
6341 (tui_show_source_content): Update.
6342 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6343 whether content is empty.
6344 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6345 Remove.
6346
63472019-07-17 Tom Tromey <tom@tromey.com>
6348
6349 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6350 window's contents.
6351 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6352 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6353
63542019-07-17 Tom Tromey <tom@tromey.com>
6355
6356 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6357 (struct tui_data_item_window): Update.
6358
63592019-07-17 Tom Tromey <tom@tromey.com>
6360
6361 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6362 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6363 defines.
6364
63652019-07-17 Tom Tromey <tom@tromey.com>
6366
6367 * tui/tui-winsource.h (tui_erase_source_content)
6368 (tui_clear_source_content): Remove "display_prompt" parameter.
6369 * tui/tui-winsource.c (tui_update_source_window_as_is)
6370 (tui_update_source_windows_with_addr): Update.
6371 (tui_clear_source_content): Remove "display_prompt" parameter.
6372 (tui_erase_source_content): Likewise. Simplify.
6373 (tui_show_source_content): Update.
6374 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6375 * tui/tui-stack.c (tui_show_frame_info): Update.
6376 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6377 Remove defines.
6378
63792019-07-17 Tom Tromey <tom@tromey.com>
6380
6381 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6382 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6383 parameter.
6384 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6385 parameter.
6386
63872019-07-17 Tom Tromey <tom@tromey.com>
6388
6389 * tui/tui-winsource.c (tui_clear_source_content)
6390 (tui_show_source_content, tui_show_exec_info_content)
6391 (tui_clear_exec_info_content): Update.
6392 * tui/tui-stack.c (tui_show_locator_content): Update.
6393 (tui_show_frame_info): Update.
6394 * tui/tui-source.h (tui_source_window): Don't declare.
6395 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6396 from tui_source_is_displayed.
6397 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6398 Remove field.
6399 (struct tui_source_window_base) <content_in_use>: New field. Now
6400 bool.
6401 (struct tui_source_window) <showing_source_p>: New method.
6402 (TUI_SRC_WIN): Change cast.
6403 * tui/tui-data.c (tui_initialize_static_data): Update.
6404
64052019-07-17 Tom Tromey <tom@tromey.com>
6406
6407 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6408 location_matches_p.
6409 * tui/tui-source.c (tui_source_window::location_matches_p): New
6410 method.
6411 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6412 method.
6413 * tui/tui-data.h (struct tui_source_window_base)
6414 <location_matches_p>: New method.
6415 (struct tui_source_window, struct tui_disasm_window)
6416 <location_matches_p>: Likewise.
6417
64182019-07-17 Tom Tromey <tom@tromey.com>
6419
6420 * tui/tui-win.c (tui_set_win_height_command): Rename from
6421 tui_set_win_height.
6422 (tui_set_win_height_command): Remove.
6423
64242019-07-17 Tom Tromey <tom@tromey.com>
6425
6426 * tui/tui-source.c (tui_source_window): New constructor. Add
6427 observer.
6428 (~tui_source_window): New destructor.
6429 (tui_source_window::style_changed): New method.
6430 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6431 (tui_attach_detach_observers): Update.
6432 * tui/tui-data.h (struct tui_source_window): Make constructor not
6433 inline. Add destructor.
6434 (struct tui_source_window) <style_changed>: New method.
6435 <m_observable>: New member.
6436
64372019-07-17 Tom Tromey <tom@tromey.com>
6438
6439 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6440 * tui/tui-win.c (tui_resize_all): Fix typo.
6441
64422019-07-17 Tom Tromey <tom@tromey.com>
6443
6444 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6445 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6446 (tui_refresh_all): Remove "list" parameter. Use foreach.
6447 * tui/tui-win.c (window_name_completer): Use foreach.
6448 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6449 (update_tab_width): Likewise.
6450 * tui/tui-layout.c (show_layout): Update.
6451 * tui/tui-data.h (class tui_window_iterator): New.
6452 (struct all_tui_windows): New.
6453 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6454
64552019-07-17 Tom Tromey <tom@tromey.com>
6456
6457 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6458 parameter. Don't reference globals.
6459 (tui_reg_command): Update.
6460
64612019-07-17 Tom Tromey <tom@tromey.com>
6462
6463 * tui/tui-regs.c (tui_show_registers): Simplify.
6464
64652019-07-17 Tom Tromey <tom@tromey.com>
6466
6467 * tui/tui-regs.c (tui_show_registers): Update.
6468 (tui_show_register_group): Add win_info parameter.
6469
64702019-07-17 Tom Tromey <tom@tromey.com>
6471
6472 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6473 Rename from tui_display_reg_element_at_line.
6474 (tui_data_window::display_registers_from_line): Update.
6475 * tui/tui-data.h (struct tui_data_window)
6476 <display_reg_element_at_line>: New method.
6477
64782019-07-17 Tom Tromey <tom@tromey.com>
6479
6480 * tui/tui-regs.h (tui_display_registers_from)
6481 (tui_display_registers_from_line): Don't declare.
6482 * tui/tui-windata.c (tui_data_window::display_all_data)
6483 (tui_data_window::refresh_all)
6484 (tui_data_window::do_scroll_vertical): Update.
6485 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6486 from tui_display_registers_from.
6487 (tui_display_reg_element_at_line): Update.
6488 (tui_data_window::display_registers_from_line): Rename from
6489 tui_display_registers_from_line.
6490 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6491 display_registers_from_line>: New methods.
6492
64932019-07-17 Tom Tromey <tom@tromey.com>
6494
6495 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6496 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6497 from tui_erase_data_content.
6498 (tui_data_window::display_all_data)
6499 (tui_data_window::refresh_all)
6500 (tui_data_window::do_scroll_vertical): Update.
6501 * tui/tui-regs.c (tui_show_registers): Update.
6502 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6503 New method.
6504
65052019-07-17 Tom Tromey <tom@tromey.com>
6506
6507 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6508 declare.
6509 * tui/tui-windata.c
6510 (tui_data_window::delete_data_content_windows): Rename from
6511 tui_delete_data_content_windows.
6512 (tui_data_window::display_all_data)
6513 (tui_data_window::do_scroll_vertical): Update.
6514 * tui/tui-data.h (struct tui_data_window)
6515 <delete_data_content_windows>: New method.
6516
65172019-07-17 Tom Tromey <tom@tromey.com>
6518
6519 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6520 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6521
65222019-07-17 Tom Tromey <tom@tromey.com>
6523
6524 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6525 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6526 from tui_display_all_data.
6527 * tui/tui-win.c
6528 (tui_data_window::do_make_visible_with_new_height): Update.
6529 * tui/tui-regs.c (tui_show_registers): Update.
6530 * tui/tui-layout.c (tui_set_layout): Update.
6531 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6532 method.
6533
65342019-07-17 Tom Tromey <tom@tromey.com>
6535
6536 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6537 * tui/tui-windata.c (tui_display_data_from): Remove.
6538 (tui_data_window::refresh_all): Update.
6539
65402019-07-17 Tom Tromey <tom@tromey.com>
6541
6542 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6543 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6544 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6545 tui_display_registers_from_line.
6546 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6547 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6548 "force_display" parameter.
6549
65502019-07-17 Tom Tromey <tom@tromey.com>
6551
6552 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6553 declare.
6554 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6555 Rename from tui_first_reg_element_no_inline.
6556 (tui_display_reg_element_at_line)
6557 (tui_display_registers_from_line): Update.
6558 * tui/tui-data.h (struct tui_data_window)
6559 <first_reg_element_no_inline>: New method.
6560
65612019-07-17 Tom Tromey <tom@tromey.com>
6562
6563 * tui/tui-windata.c (tui_display_data_from)
6564 (tui_data_window::do_scroll_vertical): Update.
6565 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6566 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6567 Rename from tui_line_from_reg_element_no.
6568 (tui_display_registers_from_line): Update.
6569 * tui/tui-data.h (struct tui_data_window)
6570 <line_from_reg_element_no>: New method.
6571
65722019-07-17 Tom Tromey <tom@tromey.com>
6573
6574 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6575 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6576 tui_last_regs_line_no.
6577 (tui_display_reg_element_at_line)
6578 (tui_display_registers_from_line): Update.
6579 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6580 method.
6581
65822019-07-17 Tom Tromey <tom@tromey.com>
6583
6584 PR tui/24722:
6585 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6586 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6587 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6588 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6589 (tui_update_breakpoint_info): Likewise.
6590 * tui/tui-hooks.c (tui_event_create_breakpoint)
6591 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6592 Update.
6593
65942019-07-17 Tom Tromey <tom@tromey.com>
6595
6596 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6597
65982019-07-17 Tom Tromey <tom@tromey.com>
6599
6600 * tui/tui-winsource.c (tui_update_source_window_as_is)
6601 (tui_update_source_windows_with_addr): Update.
6602 * tui/tui-source.h (tui_set_source_content)
6603 (tui_show_symtab_source): Add "win_info" parameter.
6604 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6605 parameter.
6606 (tui_show_symtab_source): Likewise.
6607
66082019-07-17 Tom Tromey <tom@tromey.com>
6609
6610 * tui/tui-wingeneral.c
6611 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6612
66132019-07-17 Tom Tromey <tom@tromey.com>
6614
6615 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6616 (struct tui_cmd_window) <can_scroll>: New method.
6617 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6618 method.
6619
66202019-07-17 Tom Tromey <tromey@adacore.com>
6621
6622 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6623 do_field_signed>: Rename. Change type of "value".
6624 * ui-out.c (ui_out::field_signed): Rename from field_int.
6625 Change type of "value".
6626 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6627 type of "value".
6628 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6629 do_field_int. Change type of "value".
6630 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6631 do_field_int. Change type of "value".
6632 * tracepoint.c (trace_status_mi, tfind_1)
6633 (print_one_static_tracepoint_marker): Update.
6634 * thread.c (print_thread_info_1, print_selected_thread_frame):
6635 Update.
6636 * stack.c (print_frame, print_frame_info): Update.
6637 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6638 Update.
6639 * source.c (print_source_lines_base): Update.
6640 * skip.c (info_skip_command): Update.
6641 * record-btrace.c (btrace_ui_out_decode_error)
6642 (btrace_call_history_src_line): Update.
6643 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6644 Update.
6645 * progspace.c (print_program_space): Update.
6646 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6647 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6648 do_field_int. Change type of "value".
6649 * mi/mi-out.c (mi_ui_out::do_table_begin)
6650 (mi_ui_out::do_table_header): Update.
6651 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6652 type of "value".
6653 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6654 (mi_cmd_data_list_changed_registers, output_register)
6655 (mi_cmd_data_read_memory, mi_load_progress)
6656 (mi_cmd_trace_frame_collected): Update.
6657 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6658 Update.
6659 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6660 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6661 (mi_cmd_var_list_children, varobj_update_one): Update.
6662 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6663 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6664 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6665 * inferior.c (print_inferior): Update.
6666 * gdb_bfd.c (print_one_bfd): Update.
6667 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6668 Update.
6669 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6670 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6671 do_field_int. Change type of "value".
6672 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6673 do_field_int. Change type of "value".
6674 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6675 (print_one_breakpoint_location, print_it_catch_fork)
6676 (print_one_catch_fork, print_it_catch_vfork)
6677 (print_one_catch_vfork, print_it_catch_solib)
6678 (print_it_catch_exec, print_it_ranged_breakpoint)
6679 (print_mention_watchpoint, print_mention_masked_watchpoint)
6680 (bkpt_print_it, update_static_tracepoint): Update.
6681 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6682 * break-catch-syscall.c (print_it_catch_syscall): Update.
6683 * ada-tasks.c (print_ada_task_info): Update.
6684 * ada-lang.c (print_it_exception, print_mention_exception):
6685 Update.
6686
66872019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6688
6689 PR breakpoints/24541
6690 * gdbarch.c: Regenerate.
6691 * gdbarch.h: Regenerate.
6692 * gdbarch.sh: Adjust return type and parameter types for
6693 'stap_adjust_register'.
6694 (i386_stap_adjust_register): Adjust signature and return new
6695 register name.
6696 * stap-probe.c (stap_parse_register_operand): Adjust use of
6697 'gdbarch_stap_adjust_register'.
6698
66992019-07-17 Tom Tromey <tromey@adacore.com>
6700
6701 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6702 declare VEC.
6703 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6704 std::vector.
6705 (struct s390_process_info): Add initializers.
6706 (s390_add_process): Use new.
6707 (s390_linux_nat_target::low_forget_process): Use delete.
6708 (s390_linux_nat_target::low_new_fork)
6709 (s390_linux_nat_target::stopped_by_watchpoint)
6710 (s390_linux_nat_target::low_prepare_to_resume)
6711 (s390_linux_nat_target::insert_watchpoint)
6712 (s390_linux_nat_target::insert_hw_breakpoint)
6713 (s390_linux_nat_target::remove_watchpoint)
6714 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6715
67162019-07-16 John Baldwin <jhb@FreeBSD.org>
6717
6718 * aarch64-fbsd-nat.c: Include regcache.h.
6719 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6720 argument.
6721 (aarch64_fbsd_nat_target::fetch_registers)
6722 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6723 variable.
6724 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6725
67262019-07-16 John Baldwin <jhb@FreeBSD.org>
6727
6728 * fbsd-nat.c: Include gdbarch.h.
6729
67302019-07-15 Tom Tromey <tromey@adacore.com>
6731
6732 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6733
67342019-07-15 Tom Tromey <tromey@adacore.com>
6735
6736 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6737 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6738 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6739 * cli-out.c (cli_ui_out::do_field_int): New method.
6740 * ui-out.c (ui_out::field_unsigned): New method.
6741 * symfile.c (generic_load): Use field_unsigned.
6742 (print_transfer_performance): Likewise.
6743 * record-btrace.c (ui_out_field_uint): Remove.
6744 (btrace_call_history_insn_range, btrace_call_history): Use
6745 field_unsigned.
6746 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6747 field_unsigned.
6748 * ui-out.h (class ui_out) <field_unsigned>: New method.
6749 <do_field_unsigned>: Likewise.
6750
67512019-07-15 Tom Tromey <tromey@adacore.com>
6752
6753 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6754 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6755 * target.c (flash_erase_command): Use field_string.
6756 * infrun.c (print_signal_received_reason): Use field_string.
6757 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6758 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6759 field_string.
6760 * ada-tasks.c (print_ada_task_info): Use field_string.
6761
67622019-07-15 Tom Tromey <tromey@adacore.com>
6763
6764 * target.c (flash_erase_command): Use field_core_addr.
6765 * symfile.c (generic_load): Use field_core_addr.
6766 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6767 Use field_core_addr.
6768 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6769 field_core_addr.
6770
67712019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6772
6773 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6774 value if its desired type is smaller than a CORE_ADDR and signed.
6775
67762019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6777
6778 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6779 of changes to field names, and use new is_reference field to
6780 decide if a property is a reference or not.
6781 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6782 field.
6783 (struct dwarf2_property_baton): Update header comment, rename
6784 'referenced_type' to 'property_type' and update comments.
6785 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6786 default property type, store in property baton, update to take
6787 accound of renamed field.
6788 (read_func_scope): Update call to attr_to_dynamic_prop.
6789 (read_array_type): Likewise.
6790 (dwarf2_per_cu_addr_sized_int_type): New function.
6791 (read_subrange_index_type): Move type finding code to
6792 dwarf2_per_cu_addr_sized_int_type.
6793 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6794 (dwarf2_per_cu_addr_type): New function.
6795 (set_die_type): Update calls to attr_to_dynamic_prop.
6796
67972019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6798
6799 * dwarf2read.c (read_subrange_index_type): New function.
6800 (read_subrange_type): Move code into new function and call it.
6801 * gdbtypes.c (create_range_type): Add some asserts.
6802
68032019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6804
6805 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6806 update return statements.
6807 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6808 declaration, and update comment to match.
6809 * gdbtypes.c (resolve_dynamic_array): Update call to
6810 dwarf2_evaluate_property to match new return type.
6811
68122019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6813
6814 * valarith.c (value_subscripted_rvalue): Change lowerbound
6815 parameter type from int to LONGEST.
6816 * value.h (value_subscripted_rvalue): Likewise in declaration.
6817
68182019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6819
6820 * cli/cli-utils.c (info_print_command_completer): New function.
6821 * cli/cli-utils.h: Add 'completer.h' include, and forward
6822 declaration for 'struct cmd_list_element'.
6823 (info_print_command_completer): Declare.
6824 * stack.c (_initialize_stack): Add completer for 'info locals' and
6825 'info args'.
6826 * symtab.c (_initialize_symtab): Add completer for 'info
6827 variables' and 'info functions'.
6828 * NEWS: Mention completion for additional info commands.
6829
68302019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6831
6832 * cli/cli-utils.c (extract_info_print_args): Delete.
6833 (extract_arg_maybe_quoted): Delete.
6834 (info_print_options_defs): New variable.
6835 (make_info_print_options_def_group): New function.
6836 (extract_info_print_options): Define new function.
6837 * cli/cli-utils.h (extract_info_print_args): Delete.
6838 (struct info_print_options): New structure.
6839 (extract_info_print_options): Declare new function.
6840 * stack.c (info_locals_command): Update to use new
6841 extract_info_print_options, also add a header comment.
6842 (info_args_command): Likewise.
6843 * symtab.c (info_variables_command): Likewise.
6844 (info_functions_command): Likewise.
6845
68462019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6847
6848 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6849 to extract string arguments.
6850 * common/common-utils.c (extract_string_maybe_quoted): New function.
6851 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6852
68532019-07-11 Tom Tromey <tromey@adacore.com>
6854
6855 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6856 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6857 * top.h (gdbinit): Don't declare.
6858 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6859 into...
6860 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6861 * top.c (gdb_init): Don't call init_cli_cmds.
6862 (gdbinit): Remove.
6863 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6864
68652019-07-11 Tom Tromey <tromey@adacore.com>
6866
6867 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6868 after it has been moved.
6869
68702019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6871
6872 * valops.c (value_must_coerce_to_target): Change return type to
6873 bool.
6874 * value.h (value_must_coerce_to_target): Likewise.
6875
68762019-07-10 Simon Marchi <simon.marchi@efficios.com>
6877
6878 * breakpoint.c (is_hardware_watchpoint): Remove
6879 forward-declaration.
6880 (is_masked_watchpoint): Change return type to bool.
6881 (is_tracepoint): Likewise.
6882 (is_breakpoint): Likewise.
6883 (is_hardware_watchpoint): Likewise.
6884 (is_watchpoint): Likewise.
6885 (is_no_memory_software_watchpoint): Likewise.
6886 (is_catchpoint): Likewise.
6887 (breakpoint_1): Make FILTER parameter's return type bool.
6888 is_masked_watchpoint): Change return type to bool.
6889 (save_breakpoints): Make FILTER parameter's return type bool.
6890 * breakpoint.h (is_breakpoint): Change return type to bool.
6891 (is_watchpoint): Likewise.
6892 (is_catchpoint): Likewise.
6893 (is_tracepoint): Likewise.
6894
68952019-07-10 Tom Tromey <tom@tromey.com>
6896
6897 * defs.h: Don't include gdbarch.h.
6898 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6899 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6900 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6901 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6902 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6903 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6904 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6905 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6906 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6907 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6908 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6909 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6910 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6911 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6912 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6913 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6914 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6915 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6916 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6917 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6918 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6919 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6920 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6921 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6922 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6923 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6924 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6925
69262019-07-10 Tom Tromey <tromey@adacore.com>
6927
6928 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6929 * breakpoint.c (init_ada_exception_breakpoint): Register as
6930 bp_catchpoint.
6931 (print_one_breakpoint_location, print_one_breakpoint): Use
6932 is_ada_exception_catchpoint.
6933 * ada-lang.c (class ada_catchpoint_location): Pass
6934 bp_loc_software_breakpoint to bp_location constructor.
6935 (is_ada_exception_catchpoint): New function.
6936
69372019-07-10 Tom Tromey <tromey@adacore.com>
6938
6939 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6940 VEC.
6941 (struct arm_exidx_entry): New method operator<.
6942 (struct arm_exidx_data) <section_maps>: Change type.
6943 (arm_exidx_data_free): Remove.
6944 (arm_exidx_data_key): Change type. Move lower.
6945 (arm_exidx_new_objfile): Update.
6946 (arm_compare_exidx_entries): Remove.
6947 (arm_find_exidx_entry, _initialize_arm_tdep)
6948
69492019-07-10 Tom Tromey <tromey@adacore.com>
6950
6951 * solib-spu.c (ocl_program_data_key): Change type.
6952 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6953 Update.
6954
69552019-07-10 Tom Tromey <tromey@adacore.com>
6956
6957 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
6958 (struct solib_aix_inferior_data) <library_list>: Change type.
6959 (solib_aix_inferior_data_handle): Change type.
6960 (get_solib_aix_inferior_data): Update.
6961 (solib_aix_free_library_list): Remove.
6962 (library_list_start_library): Update.
6963 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6964 return type.
6965 (solib_aix_get_library_list)
6966 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6967 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6968
69692019-07-10 Tom Tromey <tromey@adacore.com>
6970
6971 * solib-dsbt.c (struct dsbt_info): Add initializers.
6972 (solib_dsbt_pspace_data): Change type.
6973 (dsbt_pspace_data_cleanup): Remove.
6974 (get_dsbt_info, _initialize_dsbt_solib): Update.
6975
69762019-07-10 Tom Tromey <tromey@adacore.com>
6977
6978 * spu-tdep.c (spu_overlay_data): Change type.
6979 (spu_get_overlay_table, spu_overlay_new_objfile)
6980 (_initialize_spu_tdep): Update.
6981
69822019-07-10 Tom Tromey <tromey@adacore.com>
6983
6984 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6985 destructor.
6986 (dbx_objfile_data_key): Change type and declare later.
6987 (DBX_SYMFILE_INFO): Rewrite.
6988 * dbxread.c (dbx_objfile_data_key): Change type.
6989 (dbx_symfile_init): Update.
6990 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
6991 (coffstab_build_psymtabs, elfstab_build_psymtabs)
6992 (stabsect_build_psymtabs, _initialize_dbxread): Update.
6993
69942019-07-10 Tom Tromey <tromey@adacore.com>
6995
6996 * jit.c (jit_program_space_key): Change type. Move lower.
6997 (get_jit_program_space_data): Update.
6998 (jit_program_space_data_cleanup): Remove.
6999 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7000 Update.
7001 (struct jit_program_space_data): Add initializers.
7002
70032019-07-10 Tom Tromey <tromey@adacore.com>
7004
7005 * solib-darwin.c (struct darwin_info): Add initializers.
7006 (solib_darwin_pspace_data): Change type.
7007 (darwin_pspace_data_cleanup): Remove.
7008 (get_darwin_info, _initialize_darwin_solib): Update.
7009
70102019-07-10 Tom Tromey <tromey@adacore.com>
7011
7012 * remote-sim.c (struct sim_inferior_data): Add initializers,
7013 constructor, and destructor.
7014 (sim_inferior_data_key): Change type. Move lower.
7015 (check_for_duplicate_sim_descriptor): Update.
7016 (get_sim_inferior_data): Use new. Update.
7017 (~sim_inferior_data_cleanup): Rename from
7018 sim_inferior_data_cleanup. Simplify.
7019 (gdbsim_close_inferior, simulator_command)
7020 (sim_command_completer, _initialize_remote_sim): Update.
7021 (next_pid, INITIAL_PID): Move earlier.
7022
70232019-07-10 Tom Tromey <tromey@adacore.com>
7024
7025 * python/python-internal.h (create_thread_object): Return
7026 gdbpy_ref.
7027 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7028 * python/py-inferior.c (struct threadlist_entry): Add
7029 constructor.
7030 <thread_obj>: Now a gdbpy_ref.
7031 (thread_to_thread_object): Update.
7032 (add_thread_object): Use new.
7033 (delete_thread_object): Use delete.
7034 (infpy_threads): Update.
7035 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7036 GIL.
7037
70382019-07-10 Tom Tromey <tromey@adacore.com>
7039
7040 * valops.c (value_cast): Specialize error message for Ada.
7041
70422019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7043
7044 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7045
70462019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7047
7048 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7049 bpstat_should_step): Return bool, adjust comments.
7050 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7051 bpstat_should_step): Likewise.
7052
70532019-07-10 Alan Hayward <alan.hayward@arm.com>
7054
7055 * features/Makefile: Use feature target descriptions for Arm.
7056 * features/arm/arm-core.c: Generate new file.
7057 * features/arm/arm-fpa.c: Likewise.
7058 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7059 * features/arm/arm-m-profile.c: Likewise.
7060 * features/arm/arm-vfpv2.c: Likewise.
7061 * features/arm/arm-vfpv3.c: Likewise.
7062 * features/arm/xscale-iwmmxt.c: Likewise.
7063 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7064
70652019-07-10 Alan Hayward <alan.hayward@arm.com>
7066
7067 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7068 ptrace earlier.
7069
70702019-07-10 Alan Hayward <alan.hayward@arm.com>
7071
7072 * features/aarch64-pauth.c: Regenerate.
7073
70742019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7075
7076 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7077 bool.
7078 (bpstat_what): Use false instead of 0.
7079
70802019-07-09 Pedro Alves <palves@redhat.com>
7081
7082 * break-catch-throw.c (is_exception_catchpoint): New.
7083 * breakpoint.c (print_one_breakpoint_location): New parameter
7084 'raw_loc'. Handle it. Use
7085 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7086 looking at the breakpoint's type.
7087 (print_one_breakpoint): If handling "maint info breakpoints", also
7088 print locations of exception catchpoints.
7089 * breakpoint.h (is_exception_catchpoint): Declare.
7090
70912019-07-09 Pedro Alves <palves@redhat.com>
7092
7093 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7094 "addr" field.
7095 (allocate_location_exception_catchpoint): New.
7096 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7097 (initialize_throw_catchpoint_ops): Install
7098 allocate_location_exception_catchpoint as allocate_location
7099 method.
7100 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7101 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7102 bp_loc_other.
7103 (breakpoint_address_is_meaningful): Delete.
7104 (bl_address_is_meaningful): New.
7105 (breakpoint_locations_match): Adjust comment.
7106 (bp_location_from_bp_type): New, factored out of...
7107 (bp_location::bp_location(breakpoint *)): ... this.
7108 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7109 factored out of...
7110 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7111 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7112 breakpoint_address_is_meaningful.
7113 (bp_locations_compare): Adjust comment.
7114 (update_global_location_list): Use bl_address_is_meaningful
7115 instead of breakpoint_address_is_meaningful.
7116 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7117 explicit.
7118 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7119 * python/py-breakpoint.c (bppy_get_location): No longer check
7120 whether location is null.
7121
71222019-07-09 Pedro Alves <palves@redhat.com>
7123
7124 PR c++/15468
7125 * breakpoint.c (print_one_breakpoint_location): Remove
7126 single-location assert.
7127
71282019-07-09 Tom Tromey <tom@tromey.com>
7129
7130 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7131 * configure: Rebuild.
7132 * configure.ac: Change common to gdbsupport.
7133 * gdbsupport: Rename from common.
7134 * acinclude.m4: Change common to gdbsupport.
7135 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7136 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7137 gdbsupport.
7138 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7139 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7140 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7141 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7142 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7143 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7144 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7145 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7146 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7147 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7148 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7149 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7150 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7151 coff-pe-read.c, command.h, compile/compile-c-support.c,
7152 compile/compile-c.h, compile/compile-cplus-symbols.c,
7153 compile/compile-cplus-types.c, compile/compile-cplus.h,
7154 compile/compile-loc2c.c, compile/compile.c, completer.c,
7155 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7156 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7157 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7158 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7159 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7160 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7161 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7162 features/aarch64-core.c, features/aarch64-fpu.c,
7163 features/aarch64-pauth.c, features/aarch64-sve.c,
7164 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7165 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7166 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7167 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7168 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7169 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7170 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7171 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7172 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7173 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7174 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7175 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7176 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7177 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7178 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7179 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7180 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7181 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7182 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7183 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7184 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7185 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7186 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7187 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7188 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7189 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7190 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7191 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7192 minsyms.c, mips-linux-tdep.c, namespace.h,
7193 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7194 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7195 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7196 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7197 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7198 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7199 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7200 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7201 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7202 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7203 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7204 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7205 procfs.c, producer.c, progspace.h, psymtab.h,
7206 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7207 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7208 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7209 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7210 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7211 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7212 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7213 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7214 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7215 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7216 target-memory.c, target.c, target.h, target/waitstatus.c,
7217 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7218 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7219 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7220 unittests/array-view-selftests.c,
7221 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7222 unittests/common-utils-selftests.c,
7223 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7224 unittests/format_pieces-selftests.c,
7225 unittests/function-view-selftests.c,
7226 unittests/lookup_name_info-selftests.c,
7227 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7228 unittests/mkdir-recursive-selftests.c,
7229 unittests/observable-selftests.c,
7230 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7231 unittests/parse-connection-spec-selftests.c,
7232 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7233 unittests/scoped_fd-selftests.c,
7234 unittests/scoped_mmap-selftests.c,
7235 unittests/scoped_restore-selftests.c,
7236 unittests/string_view-selftests.c, unittests/style-selftests.c,
7237 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7238 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7239 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7240 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7241 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7242 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7243
72442019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7245
7246 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7247 bool value.
7248 (decode_digits_ordinary): Set explicit_line field in sal.
7249 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7250 symtab_and_line that was set on an explicit line number in
7251 assembler code. Do always update the recorded symtab and line if
7252 we do skip the prologue.
7253
72542019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7255
7256 * breakpoint.c (set_breakpoint_location_function): Remove
7257 explicit_loc parameter.
7258 (momentary_breakpoint_from_master): Update call to
7259 set_breakpoint_location_function.
7260 (add_location_to_breakpoint): Likewise.
7261
72622019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7263
7264 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7265 required features based on default bfd type when no specific bfd
7266 is present.
7267
72682019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7269
7270 * NEWS: Mention that GDB printf and eval commands can now print
7271 C-style and Ada-style convenience var strings without
7272 calling the inferior.
7273 * printcmd.c (printf_c_string): Locally print GDB internal var
7274 instead of transiting via the inferior.
7275 (printf_wide_c_string): Likewise.
7276
72772019-07-04 Alan Hayward <alan.hayward@arm.com>
7278
7279 PR breakpoints/25011
7280 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7281
72822019-07-04 Tom Tromey <tom@tromey.com>
7283
7284 PR tui/24724:
7285 * tui/tui-winsource.c (tui_clear_source_content): Update.
7286 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7287 (tui_update_breakpoint_info): Update.
7288 (tui_set_exec_info_content): Update.
7289 * tui/tui-source.c (tui_set_source_content_nil): Update.
7290 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7291 has_break.
7292 * tui/tui-data.h (enum tui_bp_flag): New.
7293 (tui_bp_flags): New enum flags type.
7294 (struct tui_source_element) <break_mode>: Change type. Rename
7295 from has_break.
7296 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7297 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7298 constants.
7299 * tui/tui-winsource.h: Fix comment.
7300
73012019-07-04 Alan Hayward <alan.hayward@arm.com>
7302
7303 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7304 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7305 (store_fpregs_to_thread)
7306 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7307 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7308 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7309 (IWMMXT_REGS_SIZE): Add define.
7310 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7311 (fetch_vfp_regs, store_vfp_regs)
7312 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7313 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7314
73152019-07-04 Alan Hayward <alan.hayward@arm.com>
7316
7317 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7318 defines.
7319 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7320 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7321 (ARM_INT_REGISTER_SIZE): ...to this.
7322 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7323 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7324 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7325 (arm_linux_collect_gregset, supply_nwfpe_register)
7326 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7327 defines.
7328 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7329 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7330 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7331 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7332 (arm_return_in_memory, arm_store_return_value)
7333 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7334 (arm_record_ld_st_multiple): Likewise.
7335 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7336 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7337
73382019-07-04 Alan Hayward <alan.hayward@arm.com>
7339
7340 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7341 AARCH64_DISPLACED_MODIFIED_INSNS.
7342 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7343 (aarch64_displaced_step_copy_insn): Likewise.
7344 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7345 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7346 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7347 ARM_DISPLACED_MODIFIED_INSNS.
7348 * arm-tdep.c (arm_gdbarch_init): Likewise.
7349 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7350 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7351 (struct arm_displaced_step_closure): Use
7352 ARM_DISPLACED_MODIFIED_INSNS.
7353
73542019-07-04 Alan Hayward <alan.hayward@arm.com>
7355
7356 * features/Makefile: Remove unused xml files.
7357 * features/aarch64.xml: Remove.
7358 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7359 * features/i386/amd64-avx-avx512.xml: Remove.
7360 * features/i386/amd64-avx-linux.xml: Remove.
7361 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7362 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7363 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7364 * features/i386/amd64-avx-mpx.xml: Remove.
7365 * features/i386/amd64-avx.xml: Remove.
7366 * features/i386/amd64-linux.xml: Remove.
7367 * features/i386/amd64-mpx-linux.xml: Remove.
7368 * features/i386/amd64-mpx.xml: Remove.
7369 * features/i386/amd64.xml: Remove.
7370 * features/i386/i386-avx-avx512-linux.xml: Remove.
7371 * features/i386/i386-avx-avx512.xml: Remove.
7372 * features/i386/i386-avx-linux.xml: Remove.
7373 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7374 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7375 * features/i386/i386-avx-mpx-linux.xml: Remove.
7376 * features/i386/i386-avx-mpx.xml: Remove.
7377 * features/i386/i386-avx.xml: Remove.
7378 * features/i386/i386-linux.xml: Remove.
7379 * features/i386/i386-mmx-linux.xml: Remove.
7380 * features/i386/i386-mmx.xml: Remove.
7381 * features/i386/i386-mpx-linux.xml: Remove.
7382 * features/i386/i386-mpx.xml: Remove.
7383 * features/i386/i386.xml: Remove.
7384 * features/i386/x32-avx-avx512-linux.xml: Remove.
7385 * features/i386/x32-avx-linux.xml: Remove.
7386 * features/i386/x32-linux.xml: Remove.
7387
73882019-07-04 Alan Hayward <alan.hayward@arm.com>
7389
7390 * regformats/aarch64.dat: Remove.
7391 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7392 * regformats/i386/amd64-avx-linux.dat: Remove.
7393 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7394 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7395 * regformats/i386/amd64-linux.dat: Remove.
7396 * regformats/i386/amd64-mpx-linux.dat: Remove.
7397 * regformats/i386/amd64.dat: Remove.
7398 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7399 * regformats/i386/i386-avx-linux.dat: Remove.
7400 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7401 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7402 * regformats/i386/i386-linux.dat: Remove.
7403 * regformats/i386/i386-mmx-linux.dat: Remove.
7404 * regformats/i386/i386-mpx-linux.dat: Remove.
7405 * regformats/i386/i386.dat: Remove.
7406 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7407 * regformats/i386/x32-avx-linux.dat: Remove.
7408 * regformats/i386/x32-linux.dat: Remove.
7409
74102019-07-04 Alan Hayward <alan.hayward@arm.com>
7411
7412 * aarch64-tdep.c: Remove xml self tests.
7413 * amd64-linux-tdep.c: Likewise.
7414 * amd64-tdep.c: Likewise.
7415 * i386-linux-tdep.c: Likewise.
7416 * i386-tdep.c: Likewise.
7417
74182019-07-03 Pedro Alves <palves@redhat.com>
7419
7420 PR cli/24732
7421 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7422 (pipe_cmd_option_defs): New.
7423 (make_pipe_cmd_options_def_group): New.
7424 (pipe_command): Use gdb::option::process_options.
7425 (pipe_command_completer): New function.
7426 (_initialize_cli_cmds): Install completer for "pipe" command.
7427
74282019-07-03 Pedro Alves <palves@redhat.com>
7429
7430 * cli/cli-option.c (union option_value) <string>: New field.
7431 (struct option_def_and_value): Add ctor, move ctor, dtor and
7432 use DISABLE_COPY_AND_ASSIGN.
7433 (option_def_and_value::clear_value): New.
7434 (parse_option, save_option_value_in_ctx, get_val_type_str)
7435 (add_setshow_cmds_for_options): Handle var_string.
7436 * cli-option.h (union option_def::var_address) <string>: New
7437 field.
7438 (struct string_option_def): New.
7439 * maint-test-options.c (struct test_options_opts): Add default
7440 ctor and use DISABLE_COPY_AND_ASSIGN.
7441 <string_opt>: New field.
7442 (test_options_opts::~test_options_opts): New.
7443 (test_options_opts::dump): Also dump "-string".
7444 (test_options_option_defs): Install "string.
7445
74462019-07-03 Pedro Alves <palves@redhat.com>
7447
7448 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7449 option_value with a null enumeration.
7450 (complete_options): Save the option values in the context.
7451 (save_option_value_in_ctx): New, factored out from ...
7452 (process_options): ... here.
7453 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7454 of the function.
7455 * maint-test-options.c (test_options_opts::dump): New, factored
7456 out from ...
7457 (maintenance_test_options_command_mode): ... here.
7458 (maintenance_test_options_command_completion_result): Delete.
7459 (maintenance_test_options_command_completion_text): Update
7460 comment.
7461 (maintenance_show_test_options_completion_result): Change
7462 prototype. Just print
7463 maintenance_test_options_command_completion_text.
7464 (save_completion_result): New.
7465 (maintenance_test_options_completer_mode): Pass options context to
7466 complete_options, and then save a dump.
7467 (_initialize_maint_test_options): Use add_cmd to install "maint
7468 show test-options-completion-result".
7469
74702019-07-03 Pedro Alves <palves@redhat.com>
7471
7472 * NEWS (New commands): Mention "with" and "maint with".
7473 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7474 (with_command, with_command_completer): New.
7475 (pipe_command): Adjust to new repeat_previous
7476 interface.
7477 (_initialize_cli_cmds): Install the "with" command and its "w"
7478 alias.
7479 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7480 declarations.
7481 * cli/cli-setshow.c (parse_cli_var_uinteger)
7482 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7483 argument strings for all var_types.
7484 (get_setshow_command_value_string): New, factored out from ...
7485 (do_show_command): ... this.
7486 * cli/cli-setshow.h: Include <string>.
7487 (get_setshow_command_value_string): Declare.
7488 * command.h (repeat_previous): Now returns const char *. Adjust
7489 comment.
7490 * maint.c: Include "cli/cli-cmds.h".
7491 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7492 (_initialize_maint_cmds): Register the "maintenance with" command.
7493 * top.c (repeat_previous): Move bits from pipe_command here:
7494 Return the saved command line, if any; error out if there's no
7495 command to relaunch.
7496
74972019-07-03 Pedro Alves <palves@redhat.com>
7498
7499 * NEWS (New commands): Mention "maint set/show test-settings"
7500 instead of "maint test-settings".
7501 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7502 (maintenance_test_settings_set_list): Rename to ...
7503 (maintenance_set_test_settings_list): ... this.
7504 (maintenance_test_settings_show_list): Rename to ...
7505 (maintenance_show_test_settings_list): ... this.
7506 (maintenance_test_settings_cmd): Delete.
7507 (maintenance_test_settings_set_cmd): ...
7508 (maintenance_set_test_settings_cmd): ... this.
7509 (maintenance_test_settings_show_cmd): ...
7510 (maintenance_show_test_settings_cmd): ... this.
7511 (maintenance_test_settings_show_value_cmd):
7512 (maintenance_show_test_settings_value_cmd): ... this.
7513 (_initialize_maint_test_settings): No longer install the "maint
7514 test-settings" prefix command. Rename "maint test-settings set"
7515 to "maint set test-settings", and "maint test-settings show" to
7516 "maint show test-settings". Adjust all subcommands.
7517
75182019-07-03 Pedro Alves <palves@redhat.com>
7519
7520 * maint-test-settings.c: Fix file's intro comment. Replace all
7521 references to "test-options" with references to "test-settings",
7522 in comments.
7523
75242019-07-03 Pedro Alves <palves@redhat.com>
7525
7526 * maint-test-settings.c (maintenance_test_settings_xxx)
7527 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7528 New.
7529 (maintenance_test_settings_enums): Use them.
7530 (maintenance_test_settings_enum): Default to
7531 maintenance_test_settings_xxx.
7532 (_initialize_maint_test_settings): Initialize
7533 MAINTENANCE_TEST_SETTINGS_FILENAME.
7534
75352019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7536
7537 * breakpoint.h (remove_breakpoints_inf): Change return type to
7538 void, move function documentation here.
7539 * breakpoint.c (remove_breakpoints_inf): Change return type to
7540 void, move function documentation to header.
7541
75422019-07-02 Pedro Alves <palves@redhat.com>
7543
7544 * NEWS (Completion improvements): Mention "info threads".
7545 * thread.c (struct info_threads_opts, info_threads_option_defs)
7546 (make_info_threads_options_def_group): New.
7547 (info_threads_command): Use gdb::option::process_options.
7548 (info_threads_command_completer): New.
7549 (_initialize_thread): Use gdb::option::build_help to build the
7550 help text for "info threads".
7551
75522019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7553
7554 * defs.h (generic_load): Move from here...
7555 * symfile.h (generic_load): ... to here. Rename name parameter
7556 to args.
7557 * symfile.c (generic_load): Add comment.
7558
75592019-07-01 Tom Tromey <tromey@adacore.com>
7560
7561 * dwarf2read.c
7562 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7563 declaration of without_params. Fix formatting.
7564
75652019-07-01 Tom Tromey <tromey@adacore.com>
7566
7567 * ada-exp.y (find_primitive_type): Update.
7568 * ada-lang.h (ada_lookup_symbol): Update.
7569 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7570 parameter.
7571 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7572
75732019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7574
7575 PR breakpoints/24541
7576 * gdbarch.c: Regenerate.
7577 * gdbarch.h: Regenerate.
7578 * gdbarch.sh: Add 'stap_adjust_register'.
7579 * i386-tdep.c: Include '<unordered_set>'.
7580 (i386_stap_adjust_register): New function.
7581 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7582 * stap-probe.c (stap_parse_register_operand): Call
7583 'gdbarch_stap_adjust_register'.
7584
75852019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7586
7587 PR python/24742
7588 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7589 * python/python.c (do_start_initialization): Use 'xmalloc'
7590 instead of 'PyMem_Malloc'.
7591
75922019-06-28 Tom Tromey <tromey@adacore.com>
7593
7594 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7595 for Ada.
7596
75972019-06-27 Tom Tromey <tromey@adacore.com>
7598
7599 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7600 objfile_key.
7601 (arm_find_mapping_symbol, arm_record_special_symbol)
7602 (_initialize_arm_tdep): Update.
7603 (arm_objfile_data_free): Remove.
7604
76052019-06-27 Tom Tromey <tromey@adacore.com>
7606
7607 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7608 to cp_print_static_field.
7609
76102019-06-26 Tom Tromey <tromey@adacore.com>
7611
7612 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7613 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7614 declare.
7615
76162019-06-26 Alan Hayward <alan.hayward@arm.com>
7617
7618 * features/aarch64-core.c (create_feature_aarch64_core):
7619 Regenerate.
7620 * features/aarch64-core.xml: Add cpsr flags.
7621
76222019-06-26 Alan Hayward <alan.hayward@arm.com>
7623
7624 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7625 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7626
76272019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7628
7629 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7630 field.
7631 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7632 use.
7633 (arm_record_special_symbol): Don't insert new symbol in sorted
7634 position, push it at the end.
7635
76362019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7637
7638 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7639 (arm_mapping_symbol_s): Remove.
7640 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7641 (arm_mapping_symbol_vec): New typedef.
7642 (struct arm_per_objfile): Add constructor.
7643 <section_maps>: Change type to
7644 std::unique_ptr<arm_mapping_symbol_vec[]>.
7645 (arm_compare_mapping_symbols): Remove.
7646 (arm_find_mapping_symbol): Adjust to section_maps type change.
7647 (arm_objfile_data_free): Call delete on arm_per_objfile.
7648 (arm_record_special_symbol): Adjust to section_maps type change.
7649 Allocate arm_per_objfile with new.
7650
76512019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7652
7653 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7654 with the command prefix.
7655
76562019-06-25 Tom Tromey <tom@tromey.com>
7657
7658 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7659 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7660
76612019-06-25 Tom Tromey <tom@tromey.com>
7662
7663 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7664 type.
7665 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7666 protected.
7667
76682019-06-25 Tom Tromey <tom@tromey.com>
7669
7670 * tui/tui-winsource.c
7671 (tui_source_window_base::set_is_exec_point_at): Add check against
7672 LOA_ADDRESS.
7673
76742019-06-25 Tom Tromey <tom@tromey.com>
7675
7676 * tui/tui-source.c (tui_set_source_content): Don't check before
7677 xfree.
7678 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7679
76802019-06-25 Tom Tromey <tom@tromey.com>
7681
7682 * tui/tui-winsource.h (tui_update_source_window_as_is)
7683 (tui_alloc_source_buffer, tui_line_is_displayed)
7684 (tui_addr_is_displayed): Change type of win_info.
7685 * tui/tui-winsource.c (tui_update_source_window_as_is)
7686 (tui_clear_source_content, tui_show_source_line)
7687 (tui_show_source_content, tui_source_window_base::refill)
7688 (tui_source_window_base::set_is_exec_point_at)
7689 (tui_source_window_base::set_is_exec_point_at)
7690 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7691 (tui_alloc_source_buffer, tui_line_is_displayed)
7692 (tui_addr_is_displayed): Change type of win_info. Update.
7693 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7694 (tui_source_window_base::do_make_visible_with_new_height):
7695 Update.
7696 * tui/tui-source.c (tui_set_source_content)
7697 (tui_set_source_content_nil)
7698 (tui_source_window::do_scroll_vertical): Update.
7699 * tui/tui-layout.c (show_layout): Update.
7700 * tui/tui-disasm.c (tui_set_disassem_content)
7701 (tui_disasm_window::do_scroll_vertical): Update.
7702 * tui/tui-data.h (tui_win_content): Remove.
7703 (struct tui_gen_win_info) <content, content_size>: Remove.
7704 (struct tui_source_element): Add initializers and destructor.
7705 (union tui_which_element, struct tui_win_element): Remove.
7706 (struct tui_source_window_base) <content>: New field.
7707 (struct tui_data_window): Remove destructor.
7708 (tui_alloc_content, tui_free_win_content)
7709 (tui_free_all_source_wins_content): Don't declare.
7710 * tui/tui-data.c (tui_initialize_static_data): Update.
7711 (init_content_element, tui_alloc_content): Remove.
7712 (~tui_gen_win_info): Update.
7713 (~tui_data_window, tui_free_all_source_wins_content)
7714 (tui_free_win_content, free_content, free_content_elements):
7715 Remove.
7716
77172019-06-25 Tom Tromey <tom@tromey.com>
7718
7719 * tui/tui-winsource.h (tui_clear_source_content)
7720 (tui_erase_source_content, tui_show_source_content): Change type
7721 of win_info.
7722 * tui/tui-winsource.c (tui_clear_source_content)
7723 (tui_erase_source_content, tui_show_source_content): Change type
7724 of win_info.
7725 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7726 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7727 win_info.
7728 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7729 win_info.
7730 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7731
77322019-06-25 Tom Tromey <tom@tromey.com>
7733
7734 * tui/tui-winsource.c (tui_clear_source_content)
7735 (tui_source_window_base::set_is_exec_point_at): Update.
7736 * tui/tui-source.c (tui_set_source_content_nil): Update.
7737 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7738 a bool.
7739 * tui/tui-data.c (init_content_element): Update.
7740
77412019-06-25 Tom Tromey <tom@tromey.com>
7742
7743 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7744 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7745 * tui/tui-layout.c (init_and_make_win): Update.
7746 * tui/tui.h (enum tui_win_type): Update.
7747 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7748 tui_win_is_auxillary.
7749 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7750 tui_win_is_auxillary.
7751
77522019-06-25 Tom Tromey <tom@tromey.com>
7753
7754 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7755 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7756 (tui_delete_data_content_windows, tui_display_all_data)
7757 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7758 Update.
7759 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7760 * tui/tui-regs.c (tui_last_regs_line_no)
7761 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7762 (tui_show_registers): Update.
7763 (tui_show_register_group): Return void. Update.
7764 (tui_display_registers_from, tui_display_reg_element_at_line)
7765 (tui_display_registers_from_line, tui_check_register_values):
7766 Update.
7767 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7768 member.
7769 (struct tui_data_window) <regs_content>: Now a std::vector.
7770 <regs_content_count>: Remove.
7771 (tui_add_content_elements, tui_free_data_content): Don't declare.
7772 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7773 (init_content_element): Remove DATA_WIN case. Add assert.
7774 (tui_add_content_elements): Remove.
7775 (tui_data_window): Update.
7776 (tui_free_data_content): Remove.
7777 (free_content_elements): Remove DATA_WIN case.
7778
77792019-06-25 Tom Tromey <tom@tromey.com>
7780
7781 * tui/tui-data.c (tui_data_item_window): Update.
7782 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7783 * tui/tui-windata.c (tui_display_all_data)
7784 (tui_display_data_from_line): Update.
7785 (tui_check_data_values): Remove.
7786 * tui/tui-regs.c (tui_show_register_group)
7787 (tui_display_reg_element_at_line): Update.
7788 * tui/tui-hooks.c (tui_register_changed)
7789 (tui_refresh_frame_and_register_information): Call
7790 tui_check_register_values.
7791 * tui/tui-data.h (struct tui_data_window) <data_content,
7792 data_content_count, data_type>: Remove.
7793 (enum tui_data_type): Remove.
7794
7795 * tui/tui-data.c (tui_data_window::clear_detail)
7796 (~tui_data_window): Update.
7797
77982019-06-25 Tom Tromey <tom@tromey.com>
7799
7800 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7801 declare.
7802 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7803 Rename from tui_first_data_item_displayed. Update.
7804 (tui_data_window::refresh_all)
7805 (tui_data_window::do_scroll_vertical): Update.
7806 * tui/tui-data.h (struct tui_data_window)
7807 <first_data_item_displayed>: Declare new method.
7808
78092019-06-25 Tom Tromey <tom@tromey.com>
7810
7811 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7812 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7813 contents...
7814 (tui_initialize_static_data): ...here.
7815
78162019-06-25 Tom Tromey <tom@tromey.com>
7817
7818 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7819 (tui_display_registers_from, tui_check_register_values): Update.
7820 (tui_display_register): Remove win_info parameter; update.
7821 (tui_get_register): Change type of parameters.
7822 * tui/tui-data.h (struct tui_data_element): Remove.
7823 (union tui_which_element) <data>: Remove.
7824 <data_window>: Change type.
7825 (struct tui_data_item_window): New.
7826 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7827 case. Add assert.
7828 (~tui_data_item_window): New destructor.
7829 (free_content_elements): Remove DATA_ITEM_WIN case.
7830
78312019-06-25 Tom Tromey <tom@tromey.com>
7832
7833 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7834 Remove.
7835
78362019-06-25 Tom Tromey <tom@tromey.com>
7837
7838 * tui/tui-data.h (struct tui_command_element): Remove.
7839 (union tui_which_element) <command>: Remove.
7840 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7841 assert.
7842 (free_content_elements): Remove CMD_WIN case.
7843
78442019-06-25 Tom Tromey <tom@tromey.com>
7845
7846 * tui/tui-layout.c (tui_set_layout): Update.
7847 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7848 * tui/tui-data.c (layout_def): Update.
7849
78502019-06-25 Tom Tromey <tom@tromey.com>
7851
7852 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7853 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7854 (tui_source_window_base::set_new_height): Update.
7855 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7856 Update.
7857 (tui_set_locator_fullname, tui_set_locator_info)
7858 (tui_show_frame_info): Update.
7859 * tui/tui-source.c (tui_set_source_content)
7860 (tui_source_is_displayed): Update.
7861 * tui/tui-layout.c (show_source_disasm_command, show_data)
7862 (show_source_or_disasm_and_command): Update.
7863 * tui/tui-disasm.c (tui_set_disassem_content)
7864 (tui_get_begin_asm_address): Update.
7865 * tui/tui-data.h (struct tui_locator_element): Remove.
7866 (union tui_which_element) <locator>: Remove.
7867 (struct tui_locator_window): New.
7868 (tui_locator_win_info_ptr): Change return type.
7869 * tui/tui-data.c (_locator): Change type.
7870 (tui_locator_win_info_ptr): Change return type.
7871 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7872 (tui_alloc_content): Add assert.
7873
78742019-06-25 Tom Tromey <tom@tromey.com>
7875
7876 * tui/tui-winsource.c
7877 (tui_exec_info_window::maybe_allocate_content): New method.
7878 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7879 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7880 (make_source_or_disasm_window): Add cast.
7881 * tui/tui-data.h (union tui_which_element) <simple_string>:
7882 Remove.
7883 (struct tui_source_info): New.
7884 (struct tui_source_window_base) <execution_info>: Change type.
7885 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7886 case, and add assert.
7887 (tui_alloc_content): Add assert.
7888
78892019-06-25 Tom Tromey <tom@tromey.com>
7890
7891 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7892 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7893 * tui/tui-data.c (tui_alloc_win_info): Remove.
7894
78952019-06-25 Tom Tromey <tom@tromey.com>
7896
7897 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7898 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7899 can_highlight.
7900
79012019-06-25 Tom Tromey <tom@tromey.com>
7902
7903 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7904 make_visible_with_new_height method.
7905 (tui_win_info::make_visible_with_new_height): New method.
7906 (tui_source_window_base::do_make_visible_with_new_height)
7907 (tui_data_window::do_make_visible_with_new_height)
7908 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7909 (make_visible_with_new_height): Remove.
7910 (tui_resize_all, tui_adjust_win_heights): Use
7911 make_visible_with_new_height method.
7912 * tui/tui-data.h (struct tui_win_info)
7913 <do_make_visible_with_new_height, make_visible_with_new_height>:
7914 New methods.
7915 (struct tui_source_window_base, struct tui_data_window)
7916 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7917 methods.
7918
79192019-06-25 Tom Tromey <tom@tromey.com>
7920
7921 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7922 method.
7923 (update_tab_width): Call update_tab_width method.
7924 * tui/tui-data.h (struct tui_win_info)
7925 (struct tui_source_window_base) <update_tab_width>: New methods.
7926
79272019-06-25 Tom Tromey <tom@tromey.com>
7928
7929 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7930 parameter.
7931 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7932 parameter.
7933 (tui_gen_win_info::make_visible): Update.
7934 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7935 parameter.
7936 * tui/tui-data.h (enum tui_box): New enum.
7937 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7938
79392019-06-25 Tom Tromey <tom@tromey.com>
7940
7941 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7942 init_and_make_win for EXEC_INFO_WIN.
7943 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7944 longer inline.
7945 (struct tui_win_info) <~tui_win_info>: Inline.
7946 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7947 Don't declare.
7948 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7949 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7950 Remove.
7951 (tui_initialize_static_data): Update.
7952 (~tui_gen_win_info): Handle more cleanup here.
7953 (~tui_source_window_base): Delete "execution_info".
7954 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7955
79562019-06-25 Tom Tromey <tom@tromey.com>
7957
7958 * tui/tui-layout.c (make_command_window): Don't set
7959 can_highlight.
7960 (show_source_disasm_command): Call the reset method.
7961 (show_data): Don't set can_highlight. Call the reset method.
7962 (tui_gen_win_info::reset): Rename from init_gen_win_info
7963 (init_and_make_win): Simplify. Return tui_gen_win_info.
7964 (show_source_or_disasm_and_command): Call the reset method.
7965 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7966 (struct tui_cmd_window): Set can_highlight.
7967
79682019-06-25 Tom Tromey <tom@tromey.com>
7969
7970 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7971 from make_visible.
7972 (tui_make_visible, tui_make_invisible): Rewrite.
7973 (tui_win_info::make_visible): Remove.
7974 (tui_source_window_base::make_visible): Update.
7975 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7976 method. Moved from...
7977 (struct tui_win_info) <make_visible>: ...here.
7978
79792019-06-25 Tom Tromey <tom@tromey.com>
7980
7981 * tui/tui-winsource.c
7982 (tui_source_window_base::do_scroll_horizontal): Remove direction
7983 parameter.
7984 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7985 direction parameter.
7986 * tui/tui-win.c (tui_win_info::forward_scroll)
7987 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7988 (tui_win_info::right_scroll): Update.
7989 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7990 direction parameter.
7991 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7992 direction parameter.
7993 * tui/tui-data.h (enum tui_scroll_direction): Remove.
7994 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7995 Remove direction parameter.
7996 (struct tui_source_window_base, struct tui_source_window)
7997 (struct tui_disasm_window, struct tui_data_window)
7998 (struct tui_cmd_window): Update.
7999
80002019-06-25 Tom Tromey <tom@tromey.com>
8001
8002 * tui/tui-winsource.h (tui_set_exec_info_content)
8003 (tui_show_exec_info_content, tui_erase_exec_info_content)
8004 (tui_clear_exec_info_content, tui_update_exec_info): Change
8005 argument to tui_source_window_base.
8006 * tui/tui-winsource.c (tui_set_exec_info_content)
8007 (tui_show_exec_info_content, tui_erase_exec_info_content)
8008 (tui_clear_exec_info_content, tui_update_exec_info): Change
8009 argument to tui_source_window_base.
8010
80112019-06-25 Tom Tromey <tom@tromey.com>
8012
8013 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8014 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8015
80162019-06-25 Tom Tromey <tom@tromey.com>
8017
8018 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8019 check.
8020
80212019-06-25 Tom Tromey <tom@tromey.com>
8022
8023 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8024 type to void.
8025 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8026 type to void.
8027 * tui/tui-source.c (tui_set_source_content): Update.
8028 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8029
80302019-06-25 Tom Tromey <tom@tromey.com>
8031
8032 * tui/tui-win.c (window_name_completer, tui_set_focus)
8033 (tui_all_windows_info): Use name method.
8034 * tui/tui-data.h (struct tui_gen_win_info)
8035 (struct tui_source_window, struct tui_disasm_window)
8036 (struct tui_data_window, struct tui_cmd_window) <name>: New
8037 method.
8038 (tui_win_name): Don't declare.
8039 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8040 (tui_win_name): Remove.
8041
80422019-06-25 Tom Tromey <tom@tromey.com>
8043
8044 * tui/tui-winsource.h (tui_update_source_window)
8045 (tui_update_source_window_as_is): Change parameter type.
8046 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8047 to be a tui_source_window_base.
8048 (tui_update_source_window_as_is): Likewise.
8049 * tui/tui-win.c (make_visible_with_new_height): Update.
8050
80512019-06-25 Tom Tromey <tom@tromey.com>
8052
8053 * tui/tui-winsource.c (tui_erase_source_content)
8054 (tui_show_source_content, tui_show_exec_info_content)
8055 (tui_erase_exec_info_content): Use refresh_window method.
8056 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8057 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8058 from tui_refresh_win.
8059 (tui_data_window::refresh_window): New method.
8060 (tui_win_info::refresh, tui_source_window_base::refresh)
8061 (tui_refresh_all): Use refresh_window method.
8062 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8063 method.
8064 * tui/tui-regs.c (tui_display_register): Call refresh_window
8065 method.
8066 * tui/tui-layout.c (show_source_disasm_command)
8067 (show_source_or_disasm_and_command): Call refresh_window method.
8068 * tui/tui-data.h (struct tui_gen_win_info)
8069 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8070 New method.
8071
80722019-06-25 Tom Tromey <tom@tromey.com>
8073
8074 * tui/tui.c (tui_rl_other_window, tui_enable)
8075 (tui_is_window_visible, tui_get_command_dimension): Update.
8076 * tui/tui-winsource.c (tui_update_source_window_as_is)
8077 (tui_clear_source_content, tui_erase_source_content)
8078 (tui_show_source_line, tui_source_window_base::refill)
8079 (tui_source_window_base::do_scroll_horizontal)
8080 (tui_source_window_base::set_is_exec_point_at)
8081 (tui_update_breakpoint_info, tui_set_exec_info_content)
8082 (tui_alloc_source_buffer, tui_line_is_displayed)
8083 (tui_addr_is_displayed): Update.
8084 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8085 (tui_check_and_display_highlight_if_needed)
8086 (tui_win_info::make_visible, tui_win_info::refresh)
8087 (tui_refresh_all): Update.
8088 * tui/tui-windata.c (tui_first_data_item_displayed)
8089 (tui_delete_data_content_windows, tui_erase_data_content)
8090 (tui_display_all_data, tui_data_window::refresh_all)
8091 (tui_check_data_values): Update.
8092 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8093 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8094 (tui_win_info::backward_scroll, tui_refresh_all_win)
8095 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8096 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8097 (tui_source_window_base::set_new_height)
8098 (tui_data_window::set_new_height)
8099 (make_invisible_and_set_new_height)
8100 (make_visible_with_new_height, new_height_ok)
8101 (parse_scrolling_args): Update.
8102 * tui/tui-stack.c (tui_show_frame_info): Update.
8103 * tui/tui-source.c (tui_set_source_content)
8104 (tui_set_source_content_nil, tui_source_is_displayed)
8105 (tui_source_window::do_scroll_vertical): Update.
8106 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8107 (tui_display_registers_from, tui_display_reg_element_at_line)
8108 (tui_check_register_values, tui_reg_command): Update.
8109 * tui/tui-layout.c (tui_default_win_height)
8110 (show_source_disasm_command, show_data, init_and_make_win)
8111 (show_source_or_disasm_and_command): Update.
8112 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8113 (tui_redisplay_readline, tui_mld_flush)
8114 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8115 (tui_getc): Update.
8116 * tui/tui-disasm.c (tui_set_disassem_content)
8117 (tui_disasm_window::do_scroll_vertical): Update.
8118 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8119 Now virtual.
8120 (struct tui_win_info): Derive from tui_gen_win_info.
8121 <~tui_win_info>: Mark as override.
8122 <generic>: Remove member.
8123 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8124 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8125 (~tui_data_window, ~tui_win_info)
8126 (tui_free_all_source_wins_content): Update.
8127 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8128
81292019-06-25 Tom Tromey <tom@tromey.com>
8130
8131 * tui/tui-layout.c (init_and_make_win): Use new.
8132 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8133 destructor, initializers.
8134 (tui_alloc_generic_win_info): Don't declare.
8135 * tui/tui-data.c (_locator): Add argument to constructor.
8136 (source_win, disasm_win): New globals.
8137 (exec_info): Remove.
8138 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8139 Update.
8140 (tui_alloc_generic_win_info): Remove.
8141 (init_content_element): Use new.
8142 (tui_win_info::tui_win_info): Update.
8143 (free_content_elements) <case DATA_WIN>: Use delete.
8144
81452019-06-25 Tom Tromey <tom@tromey.com>
8146
8147 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8148 * tui/tui-windata.c (tui_first_data_item_displayed)
8149 (tui_delete_data_content_windows): Update.
8150 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8151 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8152 (tui_display_registers_from, tui_check_register_values): Update.
8153 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8154 pointer.
8155 * tui/tui-data.c (init_content_element): Update. Allocate the new
8156 window.
8157 (tui_free_data_content): Update.
8158 (free_content_elements) <case DATA_WIN>: Free the window.
8159
81602019-06-25 Tom Tromey <tom@tromey.com>
8161
8162 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8163 Update.
8164 * tui/tui-layout.c (make_command_window)
8165 (show_source_disasm_command, show_data, init_and_make_win)
8166 (show_source_or_disasm_and_command): Update.
8167 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8168 method.
8169 <can_highight, is_highlighted>: Now bool.
8170 (tui_set_win_highlight): Don't declare.
8171 * tui/tui-data.c (tui_set_win_highlight): Remove.
8172
81732019-06-25 Tom Tromey <tom@tromey.com>
8174
8175 * tui/tui-wingeneral.c (make_visible): Remove check of window
8176 type.
8177
81782019-06-25 Tom Tromey <tom@tromey.com>
8179
8180 * tui/tui-win.c (tui_win_info::max_height)
8181 (tui_cmd_window::max_height): New methods.
8182 (new_height_ok): Call max_height.
8183 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8184 <max_height>: New method.
8185
81862019-06-25 Tom Tromey <tom@tromey.com>
8187
8188 * tui/tui-win.c (tui_source_window_base::set_new_height)
8189 (tui_data_window::set_new_height): New methods.
8190 (make_invisible_and_set_new_height): Call set_new_height method.
8191 * tui/tui-data.h (struct tui_win_info)
8192 (struct tui_source_window_base, struct tui_data_window)
8193 <set_new_height>: New method.
8194
81952019-06-25 Tom Tromey <tom@tromey.com>
8196
8197 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8198 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8199 tui_refresh_data_win.
8200 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8201 method.
8202 (tui_refresh_all_win): Call the refresh_all method.
8203 (tui_set_focus): Likewise.
8204 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8205 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8206 Likewise.
8207
82082019-06-25 Tom Tromey <tom@tromey.com>
8209
8210 * tui/tui-winsource.h (tui_refill_source_window)
8211 (tui_set_is_exec_point_at): Don't declare.
8212 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8213 (tui_source_window_base::refill): Rename from
8214 tui_refill_source_window.
8215 (tui_source_window_base::do_scroll_horizontal): Update.
8216 (tui_source_window_base::set_is_exec_point_at): Rename from
8217 tui_set_is_exec_point_at.
8218 (tui_update_all_breakpoint_info): Update.
8219 * tui/tui-stack.c (tui_show_frame_info): Update.
8220 * tui/tui-layout.c (show_data): Add cast.
8221 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8222 * tui/tui-data.h (struct tui_source_window_base) <refill,
8223 set_is_exec_point_at>: New methods.
8224 (tui_source_windows, tui_add_to_source_windows): Update types.
8225 (tui_add_to_source_windows): Remove redundant declaration.
8226 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8227 (tui_source_windows): Change return type.
8228 (tui_clear_source_windows_detail): Update.
8229 (tui_add_to_source_windows): Change type of parameter.
8230 (tui_free_all_source_wins_content): Update.
8231
82322019-06-25 Tom Tromey <tom@tromey.com>
8233
8234 * tui/tui-wingeneral.c (tui_win_info::refresh)
8235 (tui_source_window_base::refresh): New methods.
8236 (tui_refresh_all): Call the refresh method.
8237 * tui/tui-data.h (struct tui_win_info)
8238 (struct tui_source_window_base) <refresh>: New method.
8239
82402019-06-25 Tom Tromey <tom@tromey.com>
8241
8242 * tui/tui.h (tui_is_window_visible): Return bool.
8243 * tui/tui.c (tui_is_window_visible): Return bool.
8244 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8245 (tui_make_visible, tui_make_invisible)
8246 (tui_win_info::make_visible)
8247 (tui_source_window_base::make_visible, make_all_visible)
8248 (tui_make_all_visible, tui_make_all_invisible): Update.
8249 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8250 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8251 bool.
8252 (struct tui_win_info, struct tui_source_window_base)
8253 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8254 * tui/tui-data.c (tui_init_generic_part): Update.
8255
82562019-06-25 Tom Tromey <tom@tromey.com>
8257
8258 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8259 (tui_source_window_base::make_visible): New methods.
8260 (make_all_visible): Make method call.
8261 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8262 (struct tui_source_window_base, struct tui_cmd_window): Override
8263 make_visible.
8264 (tui_win_is_source_type): Don't declare.
8265 * tui/tui-data.c (tui_win_is_source_type): Remove.
8266
82672019-06-25 Tom Tromey <tom@tromey.com>
8268
8269 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8270 NULL check.
8271
82722019-06-25 Tom Tromey <tom@tromey.com>
8273
8274 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8275 Inline constructor. Add initializers for members.
8276 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8277 constructors; now inline in class.
8278
82792019-06-25 Tom Tromey <tom@tromey.com>
8280
8281 * tui/tui-regs.c (tui_show_registers): Update.
8282 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8283 bool.
8284 * tui/tui-data.c (tui_data_window::clear_detail)
8285 (tui_data_window): Update.
8286
82872019-06-25 Tom Tromey <tom@tromey.com>
8288
8289 * tui/tui-windata.c (tui_display_all_data)
8290 (tui_display_data_from_line, tui_display_data_from)
8291 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8292 Update.
8293 * tui/tui-regs.c (tui_last_regs_line_no)
8294 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8295 (tui_show_registers, tui_show_register_group)
8296 (tui_display_registers_from, tui_display_reg_element_at_line)
8297 (tui_display_registers_from_line, tui_check_register_values)
8298 (tui_reg_next, tui_reg_prev): Update.
8299 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8300 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8301 tui_data_window.
8302 (struct tui_win_info) <detail>: Remove. Add new fields from
8303 tui_data_info.
8304 (TUI_DATA_WIN): Add cast.
8305 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8306 (~tui_data_window): Simplify.
8307
83082019-06-25 Tom Tromey <tom@tromey.com>
8309
8310 * tui/tui-layout.c (show_source_disasm_command)
8311 (show_source_or_disasm_and_command): Update.
8312 * tui/tui-io.c (update_cmdwin_start_line)
8313 (tui_redisplay_readline): Update.
8314 * tui/tui-data.h (struct tui_command_info): Remove.
8315 (struct tui_win_info) <detail>: Remove command_info member.
8316 (struct tui_data_window) <start_line>: New member, from
8317 tui_command_info.
8318 (TUI_CMD_WIN): Add casts.
8319
83202019-06-25 Tom Tromey <tom@tromey.com>
8321
8322 * tui/tui-winsource.c (tui_update_source_window)
8323 (tui_refill_source_window)
8324 (tui_source_window_base::do_scroll_horizontal)
8325 (tui_update_breakpoint_info, tui_set_exec_info_content)
8326 (tui_show_exec_info_content, tui_erase_exec_info_content)
8327 (tui_clear_exec_info_content): Update.
8328 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8329 Update.
8330 * tui/tui-win.c (make_invisible_and_set_new_height)
8331 (make_visible_with_new_height): Update.
8332 * tui/tui-source.c (tui_set_source_content)
8333 (tui_show_symtab_source): Update.
8334 * tui/tui-layout.c (extract_display_start_addr)
8335 (show_source_disasm_command, show_data)
8336 (make_source_or_disasm_window)
8337 (show_source_or_disasm_and_command): Update.
8338 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8339 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8340 "gdbarch".
8341 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8342 to tui_source_window_base.
8343 (struct tui_win_info) <detail>: Remove source_info member.
8344 (struct tui_source_window_base) <has_locator>: Inline.
8345 Move contents from tui_source_info; rename has_locator member to
8346 m_has_locator.
8347 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8348 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8349 header file.
8350 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8351 Simplify.
8352 (tui_free_all_source_wins_content): Cast to
8353 tui_source_window_base.
8354
83552019-06-25 Tom Tromey <tom@tromey.com>
8356
8357 * tui/tui-win.c (make_invisible_and_set_new_height)
8358 (make_visible_with_new_height): Call has_locator method.
8359 * tui/tui-layout.c (show_source_disasm_command, show_data)
8360 (show_source_or_disasm_and_command): Update for bool change.
8361 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8362 (tui_win_info) <has_locator>: New method.
8363 (struct tui_source_window_base) <has_locator>: New method.
8364 (tui_win_has_locator): Don't declare.
8365 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8366 from tui_win_has_locator.
8367 (tui_source_window_base): Use false, not FALSE.
8368
83692019-06-25 Tom Tromey <tom@tromey.com>
8370
8371 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8372 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8373 clear_detail method directly.
8374 (tui_clear_win_detail): Remove.
8375
83762019-06-25 Tom Tromey <tom@tromey.com>
8377
8378 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8379 "this", not TUI_DISASM_WIN.
8380
83812019-06-25 Tom Tromey <tom@tromey.com>
8382
8383 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8384 declare.
8385 * tui/tui-winsource.c
8386 (tui_source_window_base::do_scroll_horizontal): Rename from
8387 tui_horizontal_source_scroll.
8388 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8389 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8390 from tui_vertical_data_scroll.
8391 * tui/tui-win.h (tui_scroll): Don't declare.
8392 * tui/tui-win.c (tui_win_info::forward_scroll)
8393 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8394 (tui_win_info::right_scroll): Rename and update.
8395 (tui_scroll_forward_command, tui_scroll_backward_command)
8396 (tui_scroll_left_command, tui_scroll_right_command): Update.
8397 (tui_scroll): Remove.
8398 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8399 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8400 from tui_vertical_source_scroll.
8401 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8402 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8403 from tui_vertical_disassem_scroll.
8404 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8405 do_scroll_horizontal>: New methods.
8406 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8407 Likewise.
8408 (struct tui_source_window_base): Add do_scroll_horizontal.
8409 (struct tui_source_window, struct tui_disasm_window): Add
8410 do_scroll_vertical.
8411 (struct tui_data_window, struct tui_cmd_window): Add
8412 do_scroll_horizontal and do_scroll_vertical.
8413 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8414
84152019-06-25 Tom Tromey <tom@tromey.com>
8416
8417 * tui/tui-data.h (struct tui_source_window_base): New struct.
8418 (struct tui_source_window): Derive from tui_source_window_base.
8419 (struct tui_disasm_window): New struct.
8420 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8421 from tui_source_window::clear_detail.
8422 (tui_source_window_base): Rename from tui_source_window.
8423 (~tui_source_window_base): Rename from ~tui_source_window.
8424 (tui_alloc_win_info): Create a tui_disasm_window.
8425
84262019-06-25 Tom Tromey <tom@tromey.com>
8427
8428 * tui/tui-data.h (struct tui_source_window)
8429 (struct tui_data_window): Declare destructors.
8430 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8431 destructors.
8432 (tui_win_info): Simplify.
8433
84342019-06-25 Tom Tromey <tom@tromey.com>
8435
8436 * tui/tui-winsource.c (tui_display_main)
8437 (tui_update_source_windows_with_addr)
8438 (tui_update_all_breakpoint_info): Update.
8439 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8440 (new_height_ok, parse_scrolling_args): Update.
8441 * tui/tui-stack.c (tui_show_frame_info): Update.
8442 * tui/tui-data.h (struct tui_list): Remove.
8443 (tui_source_windows): Return a reference to a std::vector.
8444 * tui/tui-data.c (source_windows): Now a std::vector.
8445 (tui_source_windows): Change return type.
8446 (tui_clear_source_windows): Rewrite.
8447 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8448 (tui_free_all_source_wins_content): Rewrite.
8449
84502019-06-25 Tom Tromey <tom@tromey.com>
8451
8452 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8453 (struct tui_data_window, struct tui_cmd_window): Declare
8454 clear_detail method.
8455 * tui/tui-data.c (tui_source_window::clear_detail)
8456 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8457 methods.
8458 (tui_clear_win_detail): Simplify.
8459
84602019-06-25 Tom Tromey <tom@tromey.com>
8461
8462 * tui/tui-layout.c (make_source_window, make_disasm_window)
8463 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8464 Return the new window.
8465 (show_source_disasm_command, show_data)
8466 (show_source_or_disasm_and_command): Update.
8467
84682019-06-25 Tom Tromey <tom@tromey.com>
8469
8470 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8471 parameter. Return the new window.
8472 (show_source_disasm_command): Update and remove NULL check.
8473 (show_source_or_disasm_and_command): Update.
8474
84752019-06-25 Tom Tromey <tom@tromey.com>
8476
8477 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8478
84792019-06-25 Tom Tromey <tom@tromey.com>
8480
8481 * tui/tui-data.h (struct tui_win_info): Make constructor
8482 protected. Make destructor virtual. Add initializers.
8483 (tui_source_window, tui_data_window, tui_cmd_window): New
8484 classes.
8485 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8486 constructor. Add "type" parameter.
8487 (tui_source_window, tui_data_window, tui_cmd_window): New
8488 constructors.
8489 (tui_alloc_win_info): Instantiate the appropriate subclass.
8490
84912019-06-25 Tom Tromey <tom@tromey.com>
8492
8493 * tui/tui-win.c (tui_resize_all): Use delete.
8494 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8495 destructor.
8496 (tui_free_window): Don't declare.
8497 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8498 Update.
8499
85002019-06-25 Tom Tromey <tom@tromey.com>
8501
8502 * tui/tui-data.h (struct tui_win_info): Add constructor.
8503 * tui/tui-data.c (tui_alloc_win_info): Use new.
8504 (tui_free_window): Use delete.
8505
85062019-06-22 Tom Tromey <tom@tromey.com>
8507
8508 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8509 declare.
8510 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8511
85122019-06-22 Tom Tromey <tom@tromey.com>
8513
8514 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8515 declare.
8516 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8517
85182019-06-22 Tom de Vries <tdevries@suse.de>
8519
8520 * dwarf2read.c (create_addrmap_from_aranges)
8521 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8522 instead of '%zu'.
8523
85242019-06-21 Simon Marchi <simon.marchi@efficios.com>
8525
8526 * dwarf2read.h (dwarf2_section_info_def): Remove.
8527 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8528 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8529 std::vector<dwarf2_section_info>.
8530 (struct dwo_file) <~dwo_file>: Remove.
8531 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8532 types field.
8533 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8534 (dwarf2_read_debug_names): Likewise.
8535 (create_debug_types_hash_table): Change parameter type to
8536 array_view, adjust code accordingly.
8537 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8538 (partial_die_info::fixup): Likewise.
8539 (determine_prefix): Likewise.
8540 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8541
85422019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8543
8544 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8545 gdb_bfd_ref_ptr.
8546 <~dwo_file>: Remove call to gdb_bfd_unref.
8547 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8548 gdb_bfd_ref_ptr::get.
8549
85502019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8551
8552 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8553 type to htab_up.
8554 * dwarf2read.c (struct dwo_file): Initialize fields.
8555 <~dwo_file>: New.
8556 (free_dwo_file): Remove, move content to ~dwo_file.
8557 (struct dwo_file_deleter): Remove.
8558 (dwo_file_up>: Remove custom deleter.
8559 (free_dwo_files): Remove.
8560 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8561 dwo_files.
8562 (process_skeletonless_type_units): Call unique_ptr::get.
8563 (allocate_dwo_file_hash_table): Add deleter to created hash
8564 table. Change return type to htab_up.
8565 (lookup_dwo_file_slot): Don't memset dwo_file, call
8566 unique_ptr::get.
8567 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8568 (create_dwo_unit_in_dwp_v2): Likewise.
8569 (open_and_init_dwo_file): Likewise.
8570 (free_dwo_file_from_slot): Remove.
8571
85722019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8573
8574 * dwarf2read.h (struct dwarf2_section_info) <readin,
8575 is_virtual>: Change type to bool.
8576 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8577 true instead of 1.
8578
85792019-06-19 Tom Tromey <tom@tromey.com>
8580
8581 * tui/tui-data.h (tui_init_content_element): Don't declare.
8582
85832019-06-19 Tom Tromey <tom@tromey.com>
8584
8585 * tui/tui-data.h (tui_init_win_info): Don't declare.
8586
85872019-06-19 Tom de Vries <tdevries@suse.de>
8588
8589 * dwarf2read.h (abstract_to_concrete): Change type to
8590 std::unordered_map<sect_offset, std::vector<sect_offset>,
8591 gdb::hash_enum<sect_offset>>.
8592
85932019-06-19 Tom Tromey <tromey@adacore.com>
8594
8595 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8596 EVAL_AVOID_SIDE_EFFECTS specially.
8597
85982019-06-19 Tom Tromey <tromey@adacore.com>
8599
8600 * source-cache.c (highlighter): New global.
8601 (source_cache::get_source_lines): Create a highlighter on demand.
8602
86032019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8604
8605 * defs.h (deprecated_interactive_hook): Delete declaration.
8606 * interps.c (clear_interpreter_hooks): Remove use of
8607 deprecated_interactive_hook.
8608 * top.c (deprecated_interactive_hook): Delete definition.
8609 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8610
86112019-06-18 Tom de Vries <tdevries@suse.de>
8612
8613 PR gdb/24515
8614 * dwarf2read.h (abstract_to_concrete): Change type from
8615 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8616 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8617 * dwarf2read.c (read_variable): Update.
8618 (dwarf2_fetch_die_loc_sect_off): Update.
8619
86202019-06-17 Tom de Vries <tdevries@suse.de>
8621
8622 PR gdb/24617
8623 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8624 accessing parent[parent_len - 1].
8625
86262019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8627
8628 PR gdb/24364
8629 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8630 call dtrace_process_dof with NULL dof.
8631
86322019-06-16 Tom de Vries <tdevries@suse.de>
8633
8634 PR gdb/24445
8635 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8636
86372019-06-16 Tom Tromey <tom@tromey.com>
8638
8639 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8640 (make_all_visible): Use address of member.
8641
86422019-06-16 Tom Tromey <tom@tromey.com>
8643
8644 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8645 (tui_free_window, free_content, free_content_elements): Remove
8646 unnecessary cast.
8647 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8648 cast.
8649 * tui/tui-regs.c (tui_show_register_group)
8650 (tui_display_registers_from, tui_display_reg_element_at_line):
8651 Remove unnecessary cast.
8652
86532019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8654
8655 * linux-nat.c (normal_mask): Delete.
8656 (_initialize_linux_nat): Don't initialise normal_mask.
8657
86582019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8659
8660 PR gdb/24445
8661 * dwarf-index-write.h (write_psymtabs_to_index): Add
8662 dwz_basename parameter.
8663 * dwarf-index-write.c (write_gdbindex): Move file writing to
8664 write_gdbindex_1. Change return type void.
8665 (assert_file_size): Move up, remove filename parameter.
8666 (write_gdbindex_1): New function.
8667 (write_debug_names): Change return type to void, call
8668 assert_file_size.
8669 (struct index_wip_file): New struct.
8670 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8671 file logic to index_wip_file. Write index for dwz file if
8672 needed.
8673 (save_gdb_index_command): Pass basename of dwz file, if present.
8674 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8675 build-id of dwz file, if present.
8676 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8677 (dwarf2_get_dwz_file): Likewise.
8678 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8679 (dwarf2_get_dwz_file): Likewise.
8680
86812019-06-16 Tom Tromey <tom@tromey.com>
8682
8683 * coffread.c (process_coff_symbol): Use xstrdup.
8684 * value.c (create_internalvar): Use xstrdup.
8685
86862019-06-16 Tom Tromey <tom@tromey.com>
8687
8688 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8689 * breakpoint.c (stopin_command, stopat_command)
8690 (until_break_command, decode_location_default): Remove unnecessary
8691 cast.
8692 * utils.c (subset_compare): Remove unnecessary cast.
8693 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8694 cast.
8695 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8696 cast.
8697 * infcmd.c (path_command): Remove unnecessary cast.
8698 * coffread.c (decode_type): Remove unnecessary cast.
8699 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8700 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8701 * tui/tui-stack.c (tui_show_locator_content)
8702 (tui_show_frame_info): Remove unnecessary cast.
8703 * tui/tui-win.c (tui_scroll_forward_command)
8704 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8705 (parse_scrolling_args): Remove unnecessary cast.
8706 * tui/tui-data.c (init_win_info, tui_del_window)
8707 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8708 (free_content_elements): Remove unnecessary cast.
8709 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8710 unnecessary cast.
8711 * tui/tui-source.c (tui_set_source_content)
8712 (tui_vertical_source_scroll): Remove unnecessary cast.
8713 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8714 cast.
8715 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8716 * tui/tui-regs.c (tui_display_registers_from)
8717 (tui_display_register): Remove unnecessary cast.
8718 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8719 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8720 (make_visible): Remove unnecessary cast.
8721 * tui/tui-winsource.c (tui_erase_source_content)
8722 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8723 unnecessary cast.
8724 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8725 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8726 * stabsread.c (read_type, read_array_type, read_range_type):
8727 Remove unnecessary cast.
8728 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8729 (parse_symbol, parse_type, upgrade_type, parse_external)
8730 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8731 unnecessary cast.
8732 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8733
87342019-06-16 Tom Tromey <tom@tromey.com>
8735
8736 * tui/tui-data.c (tui_alloc_generic_win_info)
8737 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8738 checks.
8739
87402019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8741 Andrew Burgess <andrew.burgess@embecosm.com>
8742
8743 * f-typeprint.c (f_print_type): Don't return early for not
8744 associated or not allocated types.
8745 (f_type_print_varspec_suffix): Add print_rank parameter and print
8746 ranks of array types in case they dangling.
8747 (f_type_print_base): Add print_rank parameter.
8748
87492019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8750
8751 * NEWS: Mention new MI commands.
8752 * break-catch-throw.c (enum exception_event_kind): Move to
8753 breakpoint.h.
8754 (print_mention_exception_catchpoint): Output text as a single
8755 message.
8756 (catch_exception_command_1): Rename to...
8757 (catch_exception_event): ...this, make non-static, update header
8758 command, and change some parameter types.
8759 (catch_catch_command): Update for changes to
8760 catch_exception_command_1.
8761 (catch_throw_command): Likewise.
8762 (catch_rethrow_command): Likewise.
8763 * breakpoint.c (enum exception_event_kind): Delete.
8764 * breakpoint.h (enum exception_event_kind): Moved here from
8765 break-catch-throw.c.
8766 (catch_exception_event): Declare.
8767 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8768 (mi_cmd_catch_throw): New function.
8769 (mi_cmd_catch_rethrow): New function.
8770 (mi_cmd_catch_catch): New function.
8771 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8772 'catch-catch' entries.
8773 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8774 (mi_cmd_catch_rethrow): Declare.
8775 (mi_cmd_catch_catch): Declare.
8776
87772019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8778
8779 * annotate.c (annotate_source_line): Change return type to void,
8780 update implementation to match.
8781 * annotate.h (annotate_source_line): Change return type to void,
8782 update header comment.
8783 * stack.c (print_frame_info): Don't change what frame information
8784 is printed based on whether annotations are on or not.
8785
87862019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8787
8788 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8789 (annotate_source): Make static.
8790 (annotate_source_line): Moved from source.c and renamed from
8791 identify_source_line. Update the return type.
8792 * annotate.h (annotate_source): Delete declaration.
8793 (annotate_source_line): Declaration moved from source.h, and
8794 renamed from identify_source_line. Return type updated.
8795 * source.c (identify_source_line): Moved to annotate.c and renamed
8796 to annotate_source_line.
8797 (info_line_command): Remove check of annotation_level.
8798 * source.h (identify_source_line): Move declaration to annotate.h
8799 and rename to annotate_source_line.
8800 * stack.c: Add 'annotate.h' include.
8801 (print_frame_info): Remove check of annotation_level before
8802 calling annotate_source_line.
8803
88042019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8805
8806 * source-cache.c (source_cache::get_plain_source_lines): Use
8807 open_source_file_with_line_charpos instead of just
8808 open_source_file, remove call to find_source_lines.
8809 (source_cache::get_source_lines): Likewise.
8810 * source.c (find_source_lines): Make static.
8811 (get_filename_and_charpos): Renamed into...
8812 (open_source_file_with_line_charpos): ..this along with changes to
8813 return a scoped_fd, and some other minor clean ups.
8814 (identify_source_line): Use open_source_file_with_line_charpos.
8815 (search_command_helper): Use open_source_file_with_line_charpos
8816 instead of just open_source_file, remove call to
8817 find_source_lines.
8818 * source.h (open_source_file_with_line_charpos): Declare new
8819 function.
8820 (find_source_lines): Delete declaration.
8821
88222019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8823
8824 * source.c (get_filename_and_charpos): Remove fullname
8825 parameter.
8826 (identify_source_line): Update call to get_filename_and_charpos.
8827
88282019-06-14 Tom Tromey <tromey@adacore.com>
8829
8830 PR gdb/24502:
8831 * ui-style.h (skip_ansi_escape): Update comment.
8832 * ui-file.h (class no_terminal_escape_file): New class.
8833 * ui-file.c (no_terminal_escape_file::write)
8834 (no_terminal_escape_file::puts): New methods.
8835 * cli/cli-logging.c (handle_redirections): Use
8836 no_terminal_escape_file.
8837
88382019-06-14 Tom Tromey <tromey@adacore.com>
8839
8840 * NEWS: Move convenience variable news above Python news.
8841
88422019-06-14 Tom Tromey <tom@tromey.com>
8843
8844 * gnulib: Move directory to top-level.
8845 * configure.ac: Don't configure gnulib.
8846 * configure: Rebuild.
8847 * common/common-defs.h: Use new path to gnulib.
8848 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8849 (GNULIB_H): Remove.
8850 (INCGNU): Look in new gnulib location.
8851 (HFILES_NO_SRCDIR): Remove gnulib files.
8852 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8853 (generated_files): Remove GNULIB_H.
8854 ($(LIBGNU), all-lib): Remove targets.
8855 (distclean): Don't mention GNULIB_BUILDDIR.
8856 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8857
88582019-06-14 Tom Tromey <tromey@adacore.com>
8859
8860 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8861 Warn if symbol file does not provide any symbols.
8862
88632019-06-14 Tom Tromey <tromey@adacore.com>
8864
8865 * source.c (find_and_open_source): Respect basenames_may_differ.
8866
88672019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8868
8869 * annotate.c (annotate_breakpoints_invalid): Make use of
8870 scoped_restore_terminal_state.
8871 (annotate_frames_invalid): Likewise.
8872
88732019-06-14 Tom Tromey <tromey@adacore.com>
8874
8875 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8876 allow assignment to an internalvar.
8877
88782019-06-14 Tom Tromey <tromey@adacore.com>
8879
8880 * ada-lex.l: Allow "_" in attribute names.
8881
88822019-06-14 Tom Tromey <tromey@adacore.com>
8883
8884 PR gdb/24653:
8885 * regcache.c (registers_changed): Don't call alloca.
8886 * top.c (execute_command): Don't call alloca.
8887
88882019-06-13 Pedro Alves <palves@redhat.com>
8889
8890 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8891 'expression'. When parsing an expression, error out if there's
8892 junk after "unlimited".
8893 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8894 (do_set_command): Adjust calls to is_unlimited_literal.
8895
88962019-06-13 Pedro Alves <palves@redhat.com>
8897
8898 * compile/compile.c (make_compile_options_def_group): Add braces
8899 around array_view initializer.
8900 * thread.c (make_thread_apply_all_options_def_group)
8901 (make_thread_apply_all_options_def_group): Likewise.
8902
89032019-06-13 Pedro Alves <palves@redhat.com>
8904
8905 * NEWS (New commands): Mention "maint test-options
8906 require-delimiter", "maint test-options unknown-is-error", "maint
8907 test-options unknown-is-operand" and "maint show
8908 test-options-completion-result".
8909 (New command options, command completion): New section.
8910 (Completion improvements): New section.
8911 Mention that you can abbreviate "unlimited".
8912
89132019-06-13 Pedro Alves <palves@redhat.com>
8914
8915 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8916 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8917 * unittests/cli-utils-selftests.c (test_parse_flags)
8918 (test_parse_flags_qcs): Delete.
8919 (test_cli_utils): Don't call deleted functions.
8920
89212019-06-13 Pedro Alves <palves@redhat.com>
8922
8923 * thread.c: Include "cli/cli-option.h".
8924 (tp_array_compar_ascending): Global.
8925 (tp_array_compar): Delete function.
8926 (tp_array_compar_ascending, tp_array_compar_descending): New
8927 functions.
8928 (ascending_option_def, qcs_flag_option_def)
8929 (thr_qcs_flags_option_defs)
8930 (make_thread_apply_all_options_def_group)
8931 (make_thread_apply_options_def_group): New.
8932 (thread_apply_all_command): Use gdb::option::process_options.
8933 (thread_apply_command_completer)
8934 (thread_apply_all_command_completer): New.
8935 (thread_apply_command): Use gdb::option::process_options.
8936 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8937 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8938 to generate help text of "thread apply". Adjust "taas"'s help.
8939 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8940 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8941
89422019-06-13 Pedro Alves <palves@redhat.com>
8943
8944 * thread.c (thread_apply_command): Check for invalid TID with
8945 isdigit instead of !isalpha.
8946
89472019-06-13 Pedro Alves <palves@redhat.com>
8948
8949 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8950 (validate_flags_qcs): New.
8951 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8952 (validate_flags_qcs): Declare.
8953 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8954 (make_frame_apply_options_def_group): New.
8955 (frame_apply_command_count): Process options with
8956 gdb::option::process_options.
8957 (frame_apply_completer): New.
8958 (frame_apply_level_completer, frame_apply_all_completer)
8959 (frame_apply_completer): New.
8960 (_initialize_stack): Update help of "frame apply", "frame apply
8961 level", "frame apply all" and "faas" to mention supported options
8962 and install command completers.
8963 * stack.h (frame_apply_all_completer): Declare.
8964 * thread.c: Include "stack.h".
8965 (tfaas_command): Add "--".
8966 (_initialize_thread): Update help "tfaas" to mention supported
8967 options and install command completer.
8968
89692019-06-13 Pedro Alves <palves@redhat.com>
8970
8971 * completer.c (complete_nested_command_line): New.
8972 (gdb_completion_word_break_characters_throw): Add assertion.
8973 * completer.h (complete_nested_command_line): Declare.
8974
89752019-06-13 Pedro Alves <palves@redhat.com>
8976
8977 * stack.c (parse_backtrace_qualifiers): New.
8978 (backtrace_command): Use it.
8979 (backtrace_command_completer): Complete on qualifiers.
8980
89812019-06-13 Pedro Alves <palves@redhat.com>
8982
8983 * frame.c: Include "cli/cli-option.h.
8984 (user_set_backtrace_options): New.
8985 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8986 Delete.
8987 (get_prev_frame): Adjust.
8988 (boolean_option_def, uinteger_option_def)
8989 (set_backtrace_option_defs): New.
8990 (_initialize_frame): Adjust and use
8991 gdb::option::add_setshow_cmds_for_options to install "set
8992 backtrace past-main" and "set backtrace past-entry".
8993 * frame.h: Include "cli/cli-option.h".
8994 (struct frame_print_options): Forward declare.
8995 (print_frame_arguments_all, print_frame_arguments_scalars)
8996 (print_frame_arguments_none): Declare.
8997 (print_entry_values): Delete declaration.
8998 (struct frame_print_options, user_frame_print_options): New.
8999 (struct set_backtrace_options): New.
9000 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9001 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9002 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9003 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9004 (list_args_or_locals): Add frame_print_options parameter.
9005 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9006 * python/py-framefilter.c (enumerate_args): Pass down
9007 USER_FRAME_PRINT_OPTIONS.
9008 * stack.c: Include "cli/cli-option.h".
9009 (print_frame_arguments_all, print_frame_arguments_scalars)
9010 (print_frame_arguments_none): Declare.
9011 (print_raw_frame_arguments, print_entry_values): Delete.
9012 (user_frame_print_options): New.
9013 (boolean_option_def, enum_option_def, frame_print_option_defs):
9014 New.
9015 (struct backtrace_cmd_options): New.
9016 (bt_flag_option_def): New.
9017 (backtrace_command_option_defs): New.
9018 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9019 (print_frame_arg, read_frame_arg, print_frame_args)
9020 (print_frame_info, print_frame): Add frame_print_options parameter
9021 and use it.
9022 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9023 (backtrace_command_1): Add frame_print_options and
9024 backtrace_cmd_options parameters and use them.
9025 (make_backtrace_options_def_group): New.
9026 (backtrace_command): Process command options with
9027 gdb::option::process_options.
9028 (backtrace_command_completer): New.
9029 (_initialize_stack): Extend "backtrace"'s help to mention
9030 supported options. Install completer for "backtrace".
9031 Install some settings commands with add_setshow_cmds_for_options.
9032
90332019-06-13 Pedro Alves <palves@redhat.com>
9034
9035 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9036 and that "set/show print raw frame-arguments" are now deprecated.
9037
9038 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9039 command.
9040 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9041 * stack.c (_initialize_stack): Install "set/show print
9042 raw-frame-arguments", and deprecate "set/show print raw
9043 frame-arguments".
9044 * valprint.c (_initialize_valprint): Deprecate "set/show print
9045 raw".
9046
90472019-06-13 Pedro Alves <palves@redhat.com>
9048
9049 * compile/compile.c (struct compile_options): New.
9050 (compile_flag_option_def, compile_command_option_defs)
9051 (make_compile_options_def_group): New.
9052 (compile_file_command): Handle options with
9053 gdb::option::process_options.
9054 (compile_file_command_completer): New function.
9055 (compile_code_command): Handle options with
9056 gdb::option::process_options.
9057 (compile_code_command_completer): New function.
9058 (_initialize_compiler): Install completers for "compile code" and
9059 "compile file". Mention available options in "compile code" and
9060 "compile code"'s help.
9061 * completer.c (advance_to_completion_word): New, factored out from
9062 ...
9063 (advance_to_expression_complete_word_point): ... this.
9064 (advance_to_filename_complete_word_point): New.
9065 * completer.h (advance_to_filename_complete_word_point): New
9066 declaration.
9067
90682019-06-13 Pedro Alves <palves@redhat.com>
9069
9070 * compile/compile.c: Include "cli/cli-option.h".
9071 (compile_print_value): Scope data pointer is now a
9072 value_print_options pointer; adjust.
9073 (compile_print_command): Process options. Scope data pointer is
9074 now a value_print_options pointer; adjust.
9075 (_initialize_compile): Update "compile print"'s help to include
9076 supported options. Install a completer for "compile print".
9077 * cp-valprint.c (show_vtblprint, show_objectprint)
9078 (show_static_field_print): Delete.
9079 (_initialize_cp_valprint): Don't install "set print
9080 static-members", "set print vtbl", "set print object" here.
9081 * printcmd.c: Include "cli/cli-option.h" and
9082 "common/gdb_optional.h".
9083 (print_command_parse_format): Rework to fill in a
9084 value_print_options instead of a format_data.
9085 (print_value): Change parameter type from format_data pointer to
9086 value_print_options reference. Adjust.
9087 (print_command_1): Process options. Adjust to pass down a
9088 value_print_options.
9089 (print_command_completer): New.
9090 (_initialize_printcmd): Install print_command_completer as
9091 handle_brkchars completer for the "print" command. Update
9092 "print"'s help to include supported options.
9093 * valprint.c: Include "cli/cli-option.h".
9094 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9095 here from cp-valprint.c.
9096 (boolean_option_def, uinteger_option_def)
9097 (value_print_option_defs, make_value_print_options_def_group):
9098 New. Use gdb::option::add_setshow_cmds_for_options to install
9099 "set print elements", "set print null-stop", "set print repeats",
9100 "set print pretty", "set print union", "set print array", "set
9101 print address", "set print symbol", "set print array-indexes".
9102 * valprint.h: Include <string> and "cli/cli-option.h".
9103 (make_value_print_options_def_group): Declare.
9104 (print_value): Change parameter type from format_data pointer to
9105 value_print_options reference.
9106 (print_command_completer): Declare.
9107
91082019-06-13 Pedro Alves <palves@redhat.com>
9109
9110 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9111 (COMMON_SFILES): Add maint-test-settings.c.
9112 * cli/cli-decode.c (boolean_enums): New global, factored out from
9113 ...
9114 (add_setshow_boolean_cmd): ... here.
9115 * cli/cli-decode.h (boolean_enums): Declare.
9116 * cli/cli-option.c: New file.
9117 * cli/cli-option.h: New file.
9118 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9119 factored out from ...
9120 (parse_cli_boolean_value(const char *)): ... this.
9121 (is_unlimited_literal): Change parameter type to pointer to
9122 pointer. Adjust and advance ARG pointer.
9123 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9124 (parse_cli_var_enum): New, factored out from ...
9125 (do_set_command): ... this. Adjust.
9126 * cli/cli-setshow.h (parse_cli_boolean_value)
9127 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9128 (parse_cli_var_enum): Declare.
9129 * cli/cli-utils.c: Include "cli/cli-option.h".
9130 (get_ulongest): New.
9131 * cli/cli-utils.h (get_ulongest): Declare.
9132 (check_for_argument): New overloads.
9133 * maint-test-options.c: New file.
9134
91352019-06-13 Pedro Alves <palves@redhat.com>
9136
9137 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9138 parse a range if "-" is at the end of the string.
9139
91402019-06-13 Pedro Alves <palves@redhat.com>
9141
9142 * cli/cli-setshow.c (parse_auto_binary_operation)
9143 (parse_cli_boolean_value): Don't allow "o".
9144
91452019-06-13 Pedro Alves <palves@redhat.com>
9146
9147 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9148 * NEWS: Mention maint test-settings KIND.
9149 * maint-test-settings.c: New file.
9150
91512019-06-13 Pedro Alves <palves@redhat.com>
9152
9153 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9154 completer.
9155 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9156 "set" completers.
9157
91582019-06-13 Pedro Alves <palves@redhat.com>
9159
9160 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9161 after item.
9162
91632019-06-13 Pedro Alves <palves@redhat.com>
9164
9165 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9166
91672019-06-13 Pedro Alves <palves@redhat.com>
9168
9169 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9170 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9171 call.
9172 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9173 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9174 calls.
9175 (check_for_argument): Skip spaces after argument.
9176
91772019-06-13 Pedro Alves <palves@redhat.com>
9178
9179 * thread.c (thread_apply_command): Adjust TID parsing.
9180 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9181 detected before end of string.
9182 (tid_is_in_list): Error out if LIST is invalid.
9183
91842019-06-13 Pedro Alves <palves@redhat.com>
9185
9186 * completer.c (complete_line_internal_1): Rewind completion word
9187 point.
9188 (completion_tracker::advance_custom_word_point_by): Change
9189 parameter type to int.
9190 * completer.h (completion_tracker::advance_custom_word_point_by):
9191 Likewise.
9192
91932019-06-13 Pedro Alves <palves@redhat.com>
9194
9195 * completer.c (advance_to_completion_word): Handle delimiters.
9196
91972019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9198
9199 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9200
92012019-06-11 Tom Tromey <tom@tromey.com>
9202
9203 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9204 (xmalloc_failed): Move to alloc.c.
9205 * alloc.c: New file.
9206 * Makefile.in (COMMON_SFILES): Add alloc.c.
9207
92082019-06-11 Tom Tromey <tom@tromey.com>
9209
9210 * nat/linux-waitpid.c: Don't include server.h.
9211 (linux_debug): Remove.
9212 (my_waitpid): Update.
9213
92142019-06-11 Tom Tromey <tromey@adacore.com>
9215
9216 * infcall.c (_initialize_infcall): Remove trailing newline from
9217 help.
9218 * user-regs.c (_initialize_user_regs): Remove trailing newline
9219 from help.
9220 * typeprint.c (_initialize_typeprint): Remove trailing newline
9221 from help.
9222 * reverse.c (_initialize_reverse): Remove trailing newlines from
9223 help.
9224 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9225 from help.
9226 * language.c (add_set_language_command): Remove trailing newline
9227 from help.
9228 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9229 help.
9230 * disasm.c (_initialize_disasm): Remove trailing newline from
9231 help.
9232 * top.c (init_main): Remove trailing newline from help.
9233 * interps.c (_initialize_interpreter): Remove trailing newline
9234 from help.
9235 * btrace.c (_initialize_btrace): Remove trailing newlines from
9236 help.
9237 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9238 from help.
9239 * python/python.c (_initialize_python): Remove trailing newline
9240 from help.
9241 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9242 help.
9243 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9244 from help. Reformat some text.
9245 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9246 from help.
9247 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9248 newline from help.
9249
92502019-06-11 Tom Tromey <tromey@adacore.com>
9251
9252 * darwin-nat.c (darwin_decode_exception_message)
9253 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9254
92552019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9256
9257 * valops.c (value_slice): Check for not allocated or not
9258 associated values.
9259
92602019-06-10 Tom de Vries <tdevries@suse.de>
9261
9262 PR gdb/24618
9263 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9264 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9265 invalid.
9266
92672019-06-10 Tom de Vries <tdevries@suse.de>
9268
9269 PR gdb/24611
9270 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9271 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9272
92732019-06-10 Tom de Vries <tdevries@suse.de>
9274
9275 PR symtab/24545
9276 * symtab.c (struct demangled_name_entry): Add language field.
9277 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9278 static minimal symbol". Set and use language field.
9279
92802019-06-10 Tom Tromey <tromey@adacore.com>
9281
9282 * ada-lang.c (_initialize_ada_language): Update help text.
9283
92842019-06-10 Tom Tromey <tromey@adacore.com>
9285
9286 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9287 with a newline.
9288 * guile/guile.c (handle_boot_error): Don't end warning with a
9289 newline.
9290 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9291 warning with a newline.
9292 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9293 newline.
9294 (s12z_frame_cache): Likewise.
9295 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9296 a newline.
9297 * solib-svr4.c (disable_probes_interface): Don't end warning with
9298 a newline.
9299 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9300 newline.
9301 * python/python.c (do_finish_initialization): Don't end warning
9302 with a newline.
9303
93042019-06-10 Tom Tromey <tom@tromey.com>
9305
9306 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9307 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9308 gdbpy_enter.
9309
93102019-06-10 Tom Tromey <tromey@adacore.com>
9311
9312 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9313 data.
9314 (elf_new_init): Don't call stabsread_new_init.
9315 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9316 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9317 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9318
93192019-06-10 Tom de Vries <tdevries@suse.de>
9320
9321 PR symtab/16264
9322 PR symtab/24517
9323 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9324
93252019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9326
9327 * source.c (find_and_open_source): Also rewrite relative file
9328 names.
9329
93302019-04-26 Amos Bird <amosbird@gmail.com>
9331
9332 * annotate.c (annotate_thread_exited): Add "thread-exited"
9333 annotation.
9334
93352019-06-06 Tom Tromey <tromey@adacore.com>
9336
9337 * maint.h (class scoped_command_stats): Use
9338 DISABLE_COPY_AND_ASSIGN.
9339 <print_time>: New method.
9340 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9341 print_time.
9342 (scoped_command_stats::print_time): New method.
9343
93442019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9345
9346 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9347 instructions of lengths 6 or 8 bytes.
9348
93492019-06-04 Pedro Alves <palves@redhat.com>
9350
9351 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9352
9353 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9354 * breakpoint.c (condition_completer): Likewise.
9355 * cli/cli-dump.c (scan_expression): Likewise.
9356 * common/filestuff.c (mkdir_recursive): Likewise.
9357 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9358 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9359 (gdb_abspath): Likewise.
9360 * compile/compile-cplus-types.c
9361 (compile_cplus_instance::decl_name): Likewise.
9362 * completer.c (complete_explicit_location):
9363 (signal_completer, reg_or_group_completer_1): Likewise.
9364 * cp-support.c (cp_remove_params_if_any): Likewise.
9365 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9366 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9367 * infcmd.c (strip_bg_char): Likewise.
9368 * linespec.c (copy_token_string): Likewise.
9369 * mi/mi-main.c (output_cores): Likewise.
9370 * psymtab.c (psymtab_search_name):
9371 * symfile.c (test_set_ext_lang_command): Likewise.
9372 * target.c (target_fileio_read_stralloc): Likewise.
9373 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9374 * value.c (complete_internalvar): Likewise.
9375
93762019-06-04 Christian Biesinger <cbiesinger@google.com>
9377
9378 Add objfile property to gdb.Type.
9379 * NEWS: Mention Python API addition.
9380 * python/py-type.c (typy_get_objfile): New method.
9381
93822019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9383
9384 * NEWS: Mention the new set|show style [title|highlight].
9385 Mention changes to "show style", "help" and "apropos".
9386
93872019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9388
9389 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9390 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9391 instead of print_help_for_command.
9392 (print_doc_of_command): New function.
9393 (help_list): Add 'apropos -v word' suggestion.
9394 (print_help_for_command): Style the command name using title style.
9395 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9396 (_initialize_cli_cmds): Describe -v in apropos_command help.
9397
93982019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9399
9400 * cli/cli-style.h (cli_style_option): Add name in constructor,
9401 add m_name class member, add constructor with intensity,
9402 add name class function.
9403 (cli_style_option::add_setshow_commands): Remove name argument.
9404 (highlight_style, title_style): New styles.
9405 * cli/cli-style.c (do_show): New function that shows a style
9406 characteristic styling the style name with itself.
9407 (set_style_name): New function.
9408 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9409 Update all callers according to the changes in cli/cli-style.h.
9410 * utils.h (fputs_highlighted): New function.
9411 * utils.c (fputs_highlighted): Likewise.
9412
94132019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9414
9415 * NEWS: Mention new pipe command and new convenience variables.
9416
94172019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9418
9419 * cli/cli-cmds.c (pipe_command): New function.
9420 (_initialize_cli_cmds): Call add_com for pipe_command.
9421 Define | as an alias for pipe.
9422 (exit_status_set_internal_vars): New function.
9423 (shell_escape): Call exit_status_set_internal_vars.
9424 cli/cli-decode.c (find_command_name_length): Recognize | as
9425 a single character command.
9426
94272019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9428
9429 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9430 top.c (execute_command_to_ui_file): New function, mostly a copy
9431 of execute_command_to_string.
9432 (execute_command_to_string): Implement by calling
9433 execute_command_to_ui_file.
9434
94352019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9436
9437 * top.h (saved_command_line): Remove declaration.
9438 * top.c (previous_saved_command_line, previous_repeat_arguments):
9439 New variables.
9440 (saved_command_line): Make static, define together with other
9441 'repeat variables'.
9442 (dont_repeat): Clear repeat_arguments.
9443 (repeat_previous, get_saved_command_line, save_command_line):
9444 New functions.
9445 (gdb_init): Initialize saved_command_line
9446 and previous_saved_command_line.
9447 * main.c (captured_main_1): Remove saved_command_line initialization.
9448 * event-top.c (handle_line_of_input): Update to use
9449 the new 'repeat' related functions instead of direct access to
9450 saved_command_line.
9451 * command.h (repeat_previous, get_saved_command_line,
9452 save_command_line): New declarations.
9453 (dont_repeat): Add comment.
9454
94552019-05-30 Tom Tromey <tromey@adacore.com>
9456
9457 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9458 Fix comment.
9459 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9460
94612019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9462
9463 PR cli/24587
9464 * completer.c (complete): Initialize variable word.
9465
94662019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9467
9468 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9469 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9470 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9471 'body' is NULL to the outter 'if', protecting the '!is_define'
9472 situation as well.
9473
94742019-05-29 Tom Tromey <tromey@adacore.com>
9475
9476 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9477 (dwarf_unknown): New function.
9478 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9479 (dwarf_type_encoding_name): Use dwarf_unknown.
9480
94812019-05-29 Tom Tromey <tromey@adacore.com>
9482
9483 PR c++/20020:
9484 * cp-valprint.c (cp_print_value_fields): Call
9485 cp_print_static_field inside "try".
9486
94872019-05-29 Tom Tromey <tromey@adacore.com>
9488
9489 * inflow.c (struct terminal_info): Add default operator=.
9490 * configure: Rebuild.
9491 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9492 -Wdeprecated-copy-dtor, -Wredundant-move.
9493
94942019-05-29 Tom Tromey <tromey@adacore.com>
9495
9496 * NEWS: Add entry.
9497 * infcmd.c (print_return_value_1): Handle finish_print
9498 option.
9499 (show_print_finish): New function.
9500 (_initialize_infcmd): Add "set/show print finish" commands.
9501 * valprint.c (user_print_options): Initialize new member.
9502 * valprint.h (struct value_print_options) <finish_print>: New
9503 member.
9504
95052019-05-28 Tom Tromey <tromey@adacore.com>
9506
9507 * ada-lang.c (ada_remove_Xbn_suffix)
9508 (find_old_style_renaming_symbol)
9509 (parse_old_style_renaming): Remove.
9510 (ada_find_renaming_symbol): Don't call
9511 find_old_style_renaming_symbol.
9512 (ada_is_renaming_symbol): Rename from
9513 ada_find_renaming_symbol. Remove "block" parameter. Return
9514 bool. Now static.
9515 (ada_read_var_value): Update and simplify.
9516 * ada-exp.y (write_var_or_type): Remove old code.
9517
95182019-05-28 Alan Hayward <alan.hayward@arm.com>
9519
9520 PR gdb/25010
9521 * event-top.c: Remove include comment.
9522 * inflow.c (class scoped_ignore_sigttou): Move from here...
9523 * inflow.h (class scoped_ignore_sigttou): ...to here.
9524 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9525 * top.c: Remove include comment.
9526
95272019-05-27 Tom Tromey <tom@tromey.com>
9528
9529 * NEWS: Fix typo.
9530
95312019-05-22 Tom Tromey <tromey@adacore.com>
9532
9533 * target.c (target_follow_exec): Constify parameter.
9534 * target-delegates.c: Rebuild.
9535 * remote.c (remote_target::follow_exec): Constify parameter.
9536 * infrun.c (follow_exec): Constify parameter.
9537 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9538 (target_follow_exec): Likewise.
9539
95402019-05-22 Alan Hayward <alan.hayward@arm.com>
9541
9542 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9543 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9544
95452019-05-22 Alan Hayward <alan.hayward@arm.com>
9546
9547 * NEWS: Add debugredirect and testsuite sections.
9548
95492019-05-22 Simon Cook <simon.cook@embecosm.com>
9550
9551 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9552 target descriptions using exclusively floating point register name
9553 aliases.
9554
95552019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9556
9557 PR gdb/18644:
9558 * f-lang.c (build_fortran_types): Handle the case where
9559 gdbarch_floatformat_for_type returns a nullptr.
9560
95612019-05-21 Tom de Vries <tdevries@suse.de>
9562
9563 PR cli/24587
9564 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9565
95662019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9567
9568 PR gdb/18644:
9569 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9570 16-byte floats.
9571 * i386-tdep.c (i386_floatformat_for_type): Use
9572 floatformats_ia64_quad for the 16-byte floating point component
9573 within a fortran 32-byte complex number.
9574
95752019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9576
9577 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9578 delete default constructor.
9579 (find_partial_die): Update to return const struct.
9580 (partial_die_parent_scope): Move variable declaration into scope
9581 of its use and change its type to auto.
9582 (guess_partial_die_structure_name): Likewise.
9583 (partial_die_info::fixup): Likewise.
9584
95852019-05-17 Tom Tromey <tromey@adacore.com>
9586
9587 * source.c (find_and_open_source): Remove cast.
9588
95892019-05-17 Tom Tromey <tromey@adacore.com>
9590
9591 * annotate.c (annotate_source): Make "filename" const.
9592 * annotate.h (annotate_source): Use const.
9593
95942019-05-17 Alan Hayward <alan.hayward@arm.com>
9595
9596 * disasm.c (set_disassembler_options): Send errors to stderr.
9597
95982019-05-17 Alan Hayward <alan.hayward@arm.com>
9599
9600 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9601 (cli_interp_base::set_logging): Check debug_redirect.
9602 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9603 * cli/cli-logging.c (debug_redirect): Add static variable.
9604 (pop_output_files): Add default param.
9605 (handle_redirections): Print debug setting.
9606 (show_logging_command): Likewise.
9607 (_initialize_cli_logging): Add debugredirect command.
9608 * interps.c (current_interp_set_logging): Add debug_redirect
9609 parameter.
9610 * interps.h (set_logging): Add debug_redirect parameter.
9611 (current_interp_set_logging): Likewise.
9612 * mi/mi-common.h: Likewise.
9613 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9614
96152019-05-17 Alan Hayward <alan.hayward@arm.com>
9616 Tom Tromey <tromey@adacore.com>
9617
9618 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9619 directly.
9620 * cli/cli-interp.h (make_logging_output): Remove declaration.
9621 * cli/cli-logging.c (make_logging_output): Remove function.
9622 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9623 directly.
9624 * ui-file.c (tee_file::tee_file): Remove bools.
9625 (tee_file::~tee_file): Remove deletes.
9626 * ui-file.h (tee_file): Remove bools.
9627
96282019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9629
9630 * mi/mi-cmds.h (mi_cmd_complete): New function.
9631 * mi/mi-main.c (mi_cmd_complete): Likewise.
9632 * mi/mi-cmds.c: Define new MI command -complete.
9633 * NEWS: Mention new -complete command.
9634
96352019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9636
9637 * completer.h (complete): New function.
9638 * completer.c (complete): Likewise.
9639 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9640 function defined in completer.h.
9641
96422019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9643
9644 * MAINTAINERS (Write After Approval): Add myself.
9645
96462019-05-17 Tom de Vries <tdevries@suse.de>
9647
9648 PR gdb/24094
9649 * dwarf2read.c (struct cu_partial_die_info): New struct.
9650 (find_partial_die): Return cu_partial_die_info.
9651 (partial_die_parent_scope, guess_partial_die_structure_name)
9652 (partial_die_info::fixup): Handle new return type of find_partial_die.
9653
96542019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9655
9656 PR breakpoints/24541
9657 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9658 "std::string", simplifying the algorithm.
9659
96602019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9661
9662 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9663 (stap_static_probe_ops::get_probes): Likewise.
9664
96652019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9666
9667 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9668 '-')" and "else if".
9669 (stap_parse_single_operand): Join checks for
9670 "gdbarch_stap_parse_special_token_p" and
9671 "gdbarch_stap_parse_special_token" in the same "if" statement.
9672 Invert check when verifying for operation on register
9673 displacement.
9674
96752019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9676
9677 * stap-probe.c (stap_get_opcode): Update comment.
9678 (stap_get_expected_argument_type): Likewise.
9679 (handle_stap_probe): Likewise.
9680
96812019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9682
9683 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9684 return type to 'bool'. Adjust comment. Use 'bool' when
9685 appropriate.
9686 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9687 * stap-probe.c (stap_parse_argument_1): Likewise.
9688 (stap_is_operator): Likewise.
9689 (stap_is_generic_prefix): Likewise.
9690 (stap_is_register_prefix): Likewise.
9691 (stap_is_register_indirection_prefix): Likewise.
9692 (stap_is_integer_prefix): Likewise.
9693 (stap_generic_check_suffix): Likewise.
9694 (stap_check_integer_suffix): Likewise.
9695 (stap_check_register_suffix): Likewise.
9696 (stap_check_register_indirection_suffix): Likewise.
9697 (stap_parse_register_operand): Likewise.
9698 (stap_parse_single_operand): Likewise.
9699 (stap_parse_argument_1): Likewise.
9700 (stap_probe::get_argument_count): Likewise.
9701 (stap_is_operator): Likewise.
9702
97032019-05-16 Tom Tromey <tromey@adacore.com>
9704
9705 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9706 keyword to foreach.
9707
97082019-05-15 Simon Marchi <simon.marchi@efficios.com>
9709
9710 * linux-thread-db.c (try_thread_db_load_1): Change return type
9711 to bool.
9712 (try_thread_db_load): Likewise.
9713 (try_thread_db_load_from_pdir_1): Likewise.
9714 (try_thread_db_load_from_pdir): Likewise.
9715 (try_thread_db_load_from_sdir): Likewise.
9716 (try_thread_db_load_from_dir): Likewise.
9717 (thread_db_load_search): Likewise.
9718 (has_libpthread): Likewise.
9719 (thread_db_load): Likewise.
9720
97212019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9722
9723 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9724 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9725 NULL, and complain/return if that's the case.
9726
97272019-05-15 John Darrington <john@darrington.wattle.id.au>
9728
9729 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9730 (advance, posn, abstract_read_memory): New functions.
9731 [struct mem_read_abstraction]: New struct.
9732 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9733
97342019-05-14 Tom Tromey <tromey@adacore.com>
9735
9736 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9737 value is not lval_memory.
9738
97392019-05-14 Tom Tromey <tromey@adacore.com>
9740
9741 * solib.c (info_sharedlibrary_command): Style the file name.
9742
97432019-05-14 Alan Hayward <alan.hayward@arm.com>
9744
9745 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9746 (aarch64_vnv_type): Likewise.
9747 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9748 * common/tdesc.c: Likewise.
9749 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9750 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9751 * features/aarch64-fpu.xml: Add ieee half view.
9752 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9753 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9754 * gdbtypes.h (struct builtin_type): Likewise.
9755 (struct objfile_type): Likewise.
9756
97572019-05-12 Paul Naert <paul.naert@polymtl.ca>
9758
9759 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9760 typo.
9761 * location.h (string_to_event_location): Likewise.
9762
97632019-05-11 Joel Brobecker <brobecker@adacore.com>
9764
9765 GDB 8.3 released.
9766
97672019-05-10 Simon Marchi <simon.marchi@efficios.com>
9768
9769 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9770 New variable declaration.
9771 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9772 New variable.
9773 (print_one_breakpoint): Use ui_out::test_flags and new global
9774 variable to compute use_fixed_output.
9775 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9776 Remove.
9777 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9778 (mi_multi_location_breakpoint_output_fixed): Remove.
9779 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9780 new variable.
9781 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9782 fix_multi_location_breakpoint_output flag if version >= 3.
9783 * ui-out.h (enum ui_out_flag)
9784 <fix_multi_location_breakpoint_output>: New enumerator.
9785
97862019-05-10 Simon Marchi <simon.marchi@efficios.com>
9787
9788 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9789
97902019-05-10 Tom Tromey <tromey@adacore.com>
9791
9792 * ada-lang.c (catch_ada_completer): New function.
9793 (_initialize_ada_language): Use it.
9794
97952019-05-10 Tom Tromey <tromey@adacore.com>
9796
9797 * thread.c (print_thread_info): Make "requested_threads" const.
9798 * gdbthread.h (print_thread_info): Make "requested_threads"
9799 const.
9800 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9801 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9802
98032019-05-08 Tom Tromey <tom@tromey.com>
9804
9805 * gdbtypes.c (objfile_type_data): Change type.
9806 (objfile_type, _initialize_gdbtypes): Update.
9807
98082019-05-08 Tom Tromey <tom@tromey.com>
9809
9810 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9811 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9812 (_initialize_dwarf2_frame): Update.
9813
98142019-05-08 Tom Tromey <tom@tromey.com>
9815
9816 * objc-lang.c (objc_objfile_data): Change type.
9817 (find_methods): Update.
9818 (_initialize_objc_lang): Remove.
9819
98202019-05-08 Tom Tromey <tom@tromey.com>
9821
9822 * stabsread.c (rs6000_builtin_type_data): Change type.
9823 (rs6000_builtin_type, _initialize_stabsread): Update.
9824
98252019-05-08 Tom Tromey <tom@tromey.com>
9826
9827 * mips-tdep.c (mips_pdr_data): Remove.
9828 (_initialize_mips_tdep): Update.
9829
98302019-05-08 Tom Tromey <tom@tromey.com>
9831
9832 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9833 (hppa_init_objfile_priv_data, read_unwind_info)
9834 (find_unwind_entry, _initialize_hppa_tdep): Update.
9835
98362019-05-08 Tom Tromey <tom@tromey.com>
9837
9838 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9839 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9840 on obstack.
9841 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9842
98432019-05-08 Tom Tromey <tom@tromey.com>
9844
9845 * mdebugread.c (basic_type_data): Change type.
9846 (basic_type, _initialize_mdebugread): Update.
9847
98482019-05-08 Tom Tromey <tom@tromey.com>
9849
9850 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9851
98522019-05-08 Tom Tromey <tom@tromey.com>
9853
9854 * nto-tdep.c (nto_inferior_data_reg): Change type.
9855 (nto_inferior_data): Update.
9856 (nto_inferior_data_cleanup, nto_new_inferior_data)
9857 (_initialize_nto_tdep): Remove.
9858 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9859
98602019-05-08 Tom Tromey <tom@tromey.com>
9861
9862 * ada-lang.c (struct ada_inferior_data): Add initializers.
9863 (ada_inferior_data): Change type.
9864 (ada_inferior_data_cleanup): Remove.
9865 (get_ada_inferior_data, ada_inferior_exit)
9866 (struct ada_pspace_data): Add initializers, destructor.
9867 (ada_pspace_data_handle): Change type.
9868 (get_ada_pspace_data): Update.
9869 (ada_pspace_data_cleanup): Remove.
9870
98712019-05-08 Tom Tromey <tom@tromey.com>
9872
9873 * coffread.c (struct coff_symfile_info): Add initializers.
9874 (coff_objfile_data_key): Move lower. Change type.
9875 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9876 Update.
9877 (coff_free_info): Remove.
9878
98792019-05-08 Tom Tromey <tom@tromey.com>
9880
9881 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9882 (fbsd_pspace_data_handle): Move lower. Change type.
9883 (get_fbsd_pspace_data): Update.
9884 (fbsd_pspace_data_cleanup): Remove.
9885 (_initialize_fbsd_tdep): Update.
9886
98872019-05-08 Tom Tromey <tom@tromey.com>
9888
9889 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9890 (get_ada_tasks_pspace_data): Update.
9891 (ada_tasks_pspace_data_cleanup): Remove.
9892 (_initialize_tasks): Update.
9893 (ada_tasks_inferior_data_handle): Change type.
9894 (get_ada_tasks_inferior_data): Update.
9895 (ada_tasks_inferior_data_cleanup): Remove.
9896 (struct ada_tasks_pspace_data): Add initializers.
9897
98982019-05-08 Tom Tromey <tom@tromey.com>
9899
9900 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9901 * symfile-debug.c (debug_sym_get_probes): Change type.
9902 * stap-probe.c (handle_stap_probe):
9903 (stap_static_probe_ops::get_probes): Change type.
9904 * probe.h (class static_probe_ops) <get_probes>: Change type.
9905 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9906 (parse_probes_in_pspace): Update.
9907 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9908 Update.
9909 (any_static_probe_ops::get_probes): Change type.
9910 * elfread.c (elfread_data): New typedef.
9911 (probe_key): Change type.
9912 (elf_get_probes): Likewise. Update.
9913 (probe_key_free): Remove.
9914 (_initialize_elfread): Update.
9915 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9916 Change type.
9917 (dtrace_process_dof_probe, dtrace_process_dof)
9918 (dtrace_static_probe_ops::get_probe): Change type.
9919
99202019-05-08 Tom Tromey <tom@tromey.com>
9921
9922 * xcoffread.c (struct xcoff_symfile_info): Rename from
9923 coff_symfile_info. Add initializers.
9924 (xcoff_objfile_data_key): Move lower. Change type.
9925 (XCOFF_DATA): Rewrite.
9926 (xcoff_free_info): Remove.
9927 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9928 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9929 (xcoff_initial_scan): Update.
9930
99312019-05-08 Tom Tromey <tom@tromey.com>
9932
9933 * solib-svr4.c (struct svr4_info): Add initializers and
9934 destructor.
9935 <probes_table>: Now an htab_up.
9936 (solib_svr4_pspace_data): Change type.
9937 (free_probes_table): Simplify.
9938 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9939 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9940 (probes_table_remove_objfile_probes, register_solib_event_probe)
9941 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9942 (_initialize_svr4_solib): Update.
9943
99442019-05-08 Tom Tromey <tom@tromey.com>
9945
9946 * remote.c (remote_pspace_data): Change type.
9947 (remote_pspace_data_cleanup): Remove.
9948 (get_remote_exec_file, set_pspace_remote_exec_file)
9949 (_initialize_remote): Update.
9950
99512019-05-08 Tom Tromey <tom@tromey.com>
9952
9953 * breakpoint.c (breakpoint_objfile_key): Change type.
9954 (get_breakpoint_objfile_data): Update.
9955 (free_breakpoint_objfile_data): Remove.
9956 (_initialize_breakpoint): Update.
9957
99582019-05-08 Tom Tromey <tom@tromey.com>
9959
9960 * linux-tdep.c (struct linux_info): Add initializers.
9961 (linux_inferior_data): Move. Change type.
9962 (invalidate_linux_cache_inf): Update.
9963 (linux_inferior_data_cleanup): Remove.
9964 (get_linux_inferior_data, _initialize_linux_tdep): Update.
9965
99662019-05-08 Tom Tromey <tom@tromey.com>
9967
9968 * auxv.c (auxv_inferior_data): Move. Change type.
9969 (auxv_inferior_data_cleanup): Remove.
9970 (invalidate_auxv_cache_inf): Rewrite.
9971 (get_auxv_inferior_data, _initialize_auxv): Update.
9972
99732019-05-08 Tom Tromey <tom@tromey.com>
9974
9975 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9976 (symfile_debug_objfile_data_key): Change type.
9977 (symfile_debug_installed, debug_qf_has_symbols)
9978 (debug_qf_find_last_source_symtab)
9979 (debug_qf_forget_cached_source_info)
9980 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9981 (debug_qf_print_stats, debug_qf_dump)
9982 (debug_qf_expand_symtabs_for_function)
9983 (debug_qf_expand_all_symtabs)
9984 (debug_qf_expand_symtabs_with_fullname)
9985 (debug_qf_map_matching_symbols)
9986 (debug_qf_expand_symtabs_matching)
9987 (debug_qf_find_pc_sect_compunit_symtab)
9988 (debug_qf_map_symbol_filenames)
9989 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9990 (debug_sym_new_init, debug_sym_init, debug_sym_read)
9991 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9992 (debug_sym_read_linetable, debug_sym_relocate): Update.
9993 (symfile_debug_free_objfile): Remove.
9994 (install_symfile_debug_logging, _initialize_symfile_debug):
9995 Update.
9996
99972019-05-08 Tom Tromey <tom@tromey.com>
9998
9999 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10000 allocate_on_obstack.
10001 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10002 (get_dwarf2_per_objfile): Update.
10003 (set_dwarf2_per_objfile): Remove.
10004 (dwarf2_has_info, dwarf2_get_section_info): Update.
10005 (dwarf2_free_objfile): Remove.
10006 (_initialize_dwarf2_read): Update.
10007
100082019-05-08 Tom Tromey <tom@tromey.com>
10009
10010 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10011 initializers.
10012 <unsupported_script_warning_printed,
10013 script_not_found_warning_printed>: Now bool.
10014 (auto_load_pspace_data): Change type.
10015 (~auto_load_pspace_info): Rename from
10016 auto_load_pspace_data_cleanup.
10017 (get_auto_load_pspace_data, init_loaded_scripts_info)
10018 (clear_section_scripts, maybe_print_unsupported_script_warning)
10019 (maybe_print_script_not_found_warning, _initialize_auto_load):
10020 Update.
10021
100222019-05-08 Tom Tromey <tom@tromey.com>
10023
10024 * objfiles.c (objfile_pspace_info): Add destructor and
10025 initializers.
10026 (objfiles_pspace_data): Change type.
10027 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10028 (get_objfile_pspace_data): Update.
10029 (objfiles_bfd_data): Change type.
10030 (get_objfile_bfd_data): Update.
10031 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10032
100332019-05-08 Tom Tromey <tom@tromey.com>
10034
10035 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10036 Change type.
10037 (get_catch_syscall_inferior_data): Update.
10038 (catch_syscall_inferior_data_cleanup): Remove.
10039 (_initialize_break_catch_syscall): Update.
10040
100412019-05-08 Tom Tromey <tom@tromey.com>
10042
10043 * inflow.c (struct terminal_info): Add destructor and
10044 initializers.
10045 (inflow_inferior_data): Change type.
10046 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10047 (get_inflow_inferior_data, inflow_inferior_exit)
10048 (swap_terminal_info, _initialize_inflow): Update.
10049
100502019-05-08 Tom Tromey <tom@tromey.com>
10051
10052 * target-dcache.c (target_dcache_cleanup): Remove.
10053 (target_dcache_aspace_key): Change type.
10054 (target_dcache_init_p, target_dcache_invalidate)
10055 (target_dcache_get, target_dcache_get_or_init)
10056 (_initialize_target_dcache): Update.
10057 * dcache.h (struct dcache_deleter): New.
10058
100592019-05-08 Tom Tromey <tom@tromey.com>
10060
10061 * symtab.c (struct symbol_cache): Add destructor and
10062 initializers.
10063 (symbol_cache_key): Move. Change type.
10064 (make_symbol_cache, free_symbol_cache): Remove.
10065 (get_symbol_cache): Update.
10066 (symbol_cache_cleanup): Remove.
10067 (ALL_PSPACES, symbol_cache_flush)
10068 (maintenance_print_symbol_cache)
10069 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10070 Update.
10071
100722019-05-08 Tom Tromey <tom@tromey.com>
10073
10074 * symtab.c (struct main_info): Add destructor and initializers.
10075 (main_progspace_key): Move. Change type.
10076 (get_main_info): Update.
10077 (main_info_cleanup): Remove.
10078 (_initialize_symtab): Update.
10079
100802019-05-08 Tom Tromey <tom@tromey.com>
10081
10082 * registry.h (DECLARE_REGISTRY): Define the _key class.
10083
100842019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10085
10086 * NEWS: Merge two 'New commands' sections.
10087
100882019-05-08 Joel Brobecker <brobecker@adacore.com>
10089
10090 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10091 parameter and use Ada language definition instead.
10092 (ada_val_print_ptr): Remove unused language parameter.
10093 (ada_val_print_num): Remove language parameter and use Ada language
10094 definition instead.
10095 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10096 parameter.
10097 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10098 parameter and use Ada language definition instead.
10099 (ada_val_print_1): Update all ada_val_print_xxx calls.
10100 Remove language parameter.
10101 (ada_val_print): Update ada_val_print_1 call.
10102
101032019-05-08 Tom Tromey <tromey@adacore.com>
10104
10105 * remote.c (remote_hw_watchpoint_limit)
10106 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10107 Now static.
10108
101092019-05-08 Tom Tromey <tromey@adacore.com>
10110
10111 * maint.c (_initialize_maint_cmds): Move initialization code to
10112 remote.c.
10113 (watchdog, show_watchdog): Move to remote.c.
10114 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10115 "watchdog" static.
10116 (_initialize_remote): Move initialization code from maint.c.
10117 * defs.h (watchdog): Don't declare.
10118
101192019-05-08 Tom Tromey <tromey@adacore.com>
10120
10121 * tui/tui-interp.c: Include main.h.
10122 * interps.c: Include main.h.
10123 * main.h (interpreter_p): Declare.
10124 * defs.h (interpreter_p): Don't declare.
10125
101262019-05-08 Tom Tromey <tromey@adacore.com>
10127
10128 * dwarf2loc.c: Include dwarf2read.h.
10129 * defs.h (read_unsigned_leb128): Don't declare.
10130 * dwarf2read.h (read_unsigned_leb128): Declare.
10131
101322019-05-08 Tom Tromey <tromey@adacore.com>
10133
10134 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10135 method.
10136
101372019-05-08 Tom Tromey <tromey@adacore.com>
10138
10139 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10140 when no wrap column is set.
10141
101422019-05-08 Tom Tromey <tromey@adacore.com>
10143
10144 * c-lang.c (c_get_string): Handle non-C-style arrays.
10145
101462019-05-08 Tom Tromey <tromey@adacore.com>
10147
10148 * typeprint.c (print_offset_data::update): Print the bit offset,
10149 not the number of bits remaining.
10150
101512019-05-08 Tom Tromey <tromey@adacore.com>
10152
10153 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10154 padding at end of comment.
10155
101562019-05-08 Tom Tromey <tromey@adacore.com>
10157
10158 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10159 Compare main types.
10160
101612019-05-06 Tom Tromey <tom@tromey.com>
10162
10163 * common/scoped_mmap.c: Include common-defs.h.
10164 * common/scoped_mmap.h: Don't include config.h.
10165
101662019-05-04 Tom Tromey <tom@tromey.com>
10167
10168 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10169 (struct aarch64_call_info): Add initializers.
10170 <si>: Now a std::vector.
10171 (pass_on_stack, aarch64_push_dummy_call): Update.
10172
101732019-05-04 Simon Marchi <simon.marchi@efficios.com>
10174 Tom Tromey <tom@tromey.com>
10175
10176 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10177 (ppc_threads): Now a std::vector. Now static.
10178 (hwdebug_find_thread_points_by_tid)
10179 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10180 Update.
10181
101822019-05-04 Tom Tromey <tom@tromey.com>
10183
10184 * arc-tdep.c (arc_tdesc_init): Return bool.
10185
101862019-05-04 Tom Tromey <tom@tromey.com>
10187
10188 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10189 Use gdb_assert_not_reached.
10190
101912019-05-04 Tom Tromey <tom@tromey.com>
10192
10193 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10194 "false".
10195
101962019-05-04 Tom Tromey <tom@tromey.com>
10197
10198 * arc-tdep.c (arc_tdesc_init): Use bool.
10199
102002019-05-04 Tom Tromey <tom@tromey.com>
10201
10202 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10203
102042019-05-04 Tom Tromey <tom@tromey.com>
10205
10206 * cli/cli-cmds.c (valid_command_p): Return bool.
10207
102082019-05-04 Tom Tromey <tom@tromey.com>
10209
10210 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10211 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10212
102132019-05-04 Raul Tambre <raul@tambre.ee>
10214
10215 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10216 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10217 operator for comparison.
10218
102192019-05-04 Tom Tromey <tom@tromey.com>
10220
10221 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10222 (lookup_partial_symbol, print_partial_symbols)
10223 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10224 (psymbol_compare): Update.
10225 (add_psymbol_to_bcache): Clear the entire psymbol.
10226 (maintenance_check_psymtabs): Update.
10227 * psympriv.h (struct partial_symbol): Don't derive from
10228 general_symbol_info.
10229 <obj_section, unrelocated_address, address,
10230 set_unrelocated_address>: Update.
10231 <ginfo>: New member.
10232 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10233 (debug_names::write_psymbols): Update.
10234
102352019-05-04 Tom de Vries <tdevries@suse.de>
10236
10237 * contrib/cc-with-tweaks.sh: Support -n arg.
10238
102392019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10240
10241 * corelow.c (core_target::detach): Ensure frame cache and
10242 register caches are cleared.
10243 inferior.c (exit_inferior_1): Likewise.
10244
102452019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10246 Tom Tromey <tom@tromey.com>
10247
10248 * dictionary.c (collate_pending_symbols_by_language): Remove
10249 "struct" from foreach.
10250 * symtab.c (lookup_global_symbol_from_objfile)
10251 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10252 foreach.
10253 * ser-tcp.c (net_open): Remove "struct" from foreach.
10254 * objfiles.c (objfile_relocate, objfile_rebase)
10255 (objfile_has_symbols): Remove "struct" from foreach.
10256 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10257 from foreach.
10258 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10259 foreach.
10260 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10261 "struct" from foreach.
10262 * ada-lang.c (create_excep_cond_exprs)
10263 (ada_exception_catchpoint_cond_string): Remove "struct" from
10264 foreach.
10265
102662019-05-03 Tom Tromey <tromey@adacore.com>
10267
10268 * ada-exp.y (convert_char_literal): Check suffix of each
10269 enumerator.
10270
102712019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10272
10273 PR ada/21406:
10274 * ada-exp.y (yywrap): Don't define.
10275 * ada-lex.l (%option): Add noyywrap
10276 (yywrap): Remove.
10277
102782019-05-03 Eli Zaretskii <eliz@gnu.org>
10279
10280 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10281 _WIN32_WINNT to the XP level, unless already defined to a higher
10282 level.
10283
10284 * unittests/parse-connection-spec-selftests.c:
10285 * ser-tcp.c:
10286 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10287 override.
10288
10289 * symfile.c (find_separate_debug_file): Remove colon from the
10290 drive spec of DOS/Windows file names of the target, so that the
10291 file name produced from DEBUGDIR and the target's directory will
10292 be valid on DOS/Windows systems.
10293
102942019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10295
10296 * rust-lang.c (val_print_struct): Handle printing structures
10297 containing strings.
10298
102992019-05-02 Tom Tromey <tromey@adacore.com>
10300
10301 * valarith.c (_initialize_valarith): Remove.
10302
103032019-05-01 Tom Tromey <tromey@adacore.com>
10304
10305 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10306 bitfields.
10307
103082019-05-01 Tom Tromey <tromey@adacore.com>
10309
10310 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10311 for big-endian copies.
10312
103132019-04-30 Ali Tamur <tamur@google.com>
10314 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10315 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10316 (read_3_bytes): New function.
10317
103182019-04-30 Joel Brobecker <brobecker@adacore.com>
10319
10320 * windows-nat.c (main_thread_id): Delete.
10321 (handle_output_debug_string): Replace main_thread_id by
10322 current_event.dwThreadId.
10323 (fake_create_process): Likewise.
10324 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10325 Do not set main_thread_id.
10326 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10327 current_event.dwThreadId.
10328 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10329
103302019-04-30 Joel Brobecker <brobecker@adacore.com>
10331
10332 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10333 Use current_event.dwThreadId instead of main_thread_id.
10334
103352019-04-30 Tom Tromey <tromey@adacore.com>
10336
10337 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10338 (create_excep_cond_exprs): Iterate over program spaces.
10339 (ada_exception_catchpoint_cond_string): Examine all minimal
10340 symbols for exception types.
10341
103422019-04-30 Tom Tromey <tromey@adacore.com>
10343
10344 PR c++/24470:
10345 * dwarf2read.c (process_structure_scope): Handle case where type
10346 has template parameters but no symbol was created.
10347
103482019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10349 Chris January <chris.january@arm.com>
10350
10351 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10352 qualifier.
10353 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10354
103552019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10356
10357 * f-typeprint.c (f_print_type): Update rules for printing
10358 whitespace.
10359 (f_type_print_varspec_suffix): Likewise.
10360
103612019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10362 Chris January <chris.january@arm.com>
10363
10364 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10365 function arguments.
10366
103672019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10368
10369 * f-lang.c (build_fortran_types): Change name of void type to
10370 lower case.
10371 * f-typeprint.c (f_type_print_base): Print the name of the void
10372 type, rather than a fixed string.
10373 * f-valprint.c (f_decorations): Use lower case void string.
10374
103752019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10376 Chris January <chris.january@arm.com>
10377
10378 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10379 types for Fortran.
10380
103812019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10382 Chris January <chris.january@arm.com>
10383 David Lecomber <david.lecomber@arm.com>
10384
10385 * f-exp.y (BINOP_INTRINSIC): New token.
10386 (exp): New parser rule handling BINOP_INTRINSIC.
10387 (f77_keywords): Add new builtin procedures.
10388 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10389 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10390 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10391 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10392 (print_unop_subexp_f): New function.
10393 (print_binop_subexp_f): New function.
10394 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10395 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10396 (dump_subexp_body_f): Likewise.
10397 (operator_check_f): Likewise.
10398 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10399 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10400
104012019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10402
10403 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10404 UNOP_KIND.
10405 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10406 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10407 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10408 (operator_length_f): New fuction.
10409 (print_subexp_f): New function.
10410 (op_name_f): New function.
10411 (dump_subexp_body_f): New function.
10412 (operator_check_f): New function.
10413 (exp_descriptor_f): Replace standard expression handling functions
10414 with new functions.
10415 * gdb/fortran-operator.def: New file.
10416 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10417 * gdb/std-operator.def: Remove UNOP_KIND.
10418
104192019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10420
10421 * std-operator.def: Remove unbalanced, stray double quote
10422 character.
10423
104242019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10425 Chris January <chris.january@arm.com>
10426 Daniel Everett <daniel.everett@arm.com>
10427 Nick Forrington <nick.forrington@arm.com>
10428 Richard Bunt <richard.bunt@arm.com>
10429
10430 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10431 of depth when printing anonymous structs or unions.
10432 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10433 Don't print either the top-level value, or the children if the
10434 max-depth is exceeded.
10435 (ppscm_print_children): When printing the key of a map, allow one
10436 extra level of depth.
10437 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10438 print either the top-level value, or the children if the max-depth
10439 is exceeded.
10440 (print_children): When printing the key of a map, allow one extra
10441 level of depth.
10442 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10443 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10444 (user_print_options): Initialise max_depth field.
10445 (val_print_scalar_or_string_type_p): New function.
10446 (val_print): Check to see if the max depth has been reached.
10447 (val_print_check_max_depth): Define new function.
10448 (show_print_max_depth): New function.
10449 (_initialize_valprint): Add 'print max-depth' option.
10450 * valprint.h (struct value_print_options) <max_depth>: New field.
10451 (val_print_check_max_depth): Declare new function.
10452 * NEWS: Document new feature.
10453
104542019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10455
10456 * ada-lang.c (ada_language_defn): Initialise new field.
10457 * c-lang.c (c_is_string_type_p): New function.
10458 (c_language_defn): Initialise new field.
10459 (cplus_language_defn): Initialise new field.
10460 (asm_language_defn): Initialise new field.
10461 (minimal_language_defn): Initialise new field.
10462 * c-lang.h (c_is_string_type_p): Declare new function.
10463 * d-lang.c (d_language_defn): Initialise new field.
10464 * f-lang.c (f_is_string_type_p): New function.
10465 (f_language_defn): Initialise new field.
10466 * go-lang.c (go_is_string_type_p): New function.
10467 (go_language_defn): Initialise new field.
10468 * language.c (default_is_string_type_p): New function.
10469 (unknown_language_defn): Initialise new field.
10470 (auto_language_defn): Initialise new field.
10471 * language.h (struct language_defn) <la_is_string_type_p>: New
10472 member variable.
10473 (default_is_string_type_p): Declare new function.
10474 * m2-lang.c (m2_language_defn): Initialise new field.
10475 * objc-lang.c (objc_language_defn): Initialise new field.
10476 * opencl-lang.c (opencl_language_defn): Initialise new field.
10477 * p-lang.c (pascal_is_string_type_p): New function.
10478 (pascal_language_defn): Initialise new field.
10479 * rust-lang.c (rust_is_string_type_p): New function.
10480 (rust_language_defn): Initialise new field.
10481
104822019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10483
10484 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10485 New field.
10486 * ada-lang.c (ada_language_defn): Initialise new field.
10487 * c-lang.c (c_language_defn): Likewise.
10488 (cplus_language_defn): Likewise.
10489 (asm_language_defn): Likewise.
10490 (minimal_language_defn): Likewise.
10491 * d-lang.c (d_language_defn): Likewise.
10492 * f-lang.c (f_language_defn): Likewise.
10493 * go-lang.c (go_language_defn): Likewise.
10494 * language.c (unknown_language_defn): Likewise.
10495 (auto_language_defn): Likewise.
10496 * m2-lang.c (m2_language_defn): Likewise.
10497 * objc-lang.c (objc_language_defn): Likewise.
10498 * opencl-lang.c (opencl_language_defn): Likewise.
10499 * p-lang.c (pascal_language_defn): Likewise.
10500 * rust-lang.c (rust_language_defn): Likewise.
10501
105022019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10503
10504 * ada-lang.c (ada_is_character_type): Change return type to bool.
10505 (ada_is_string_type): Likewise.
10506 * ada-lang.h (ada_is_character_type): Update declaration
10507 (ada_is_string_type): Likewise.
10508
105092019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10510
10511 Support style in 'frame|thread apply'
10512
10513 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10514 * record.c (record_start, record_stop): Update callers of
10515 execute_command_to_string with false.
10516 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10517 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10518 methods.
10519 (class string_file): New constructor with term_out parameter.
10520 Override methods term_out and can_emit_style_escape. New member
10521 term_out.
10522 (class stdio_file): Override can_emit_style_escape.
10523 (class tee_file): Override term_out and can_emit_style_escape.
10524 * utils.h (can_emit_style_escape): Remove.
10525 * utils.c (can_emit_style_escape): Likewise.
10526 Update all callers of can_emit_style_escape (SOMESTREAM) to
10527 SOMESTREAM->can_emit_style_escape.
10528 * source-cache.c (source_cache::get_source_lines): Likewise.
10529 * stack.c (frame_apply_command_count): Call execute_command_to_string
10530 passing the term_out characteristic of the current gdb_stdout.
10531 * thread.c (thr_try_catch_cmd): Likewise.
10532 * top.c (execute_command_to_string): pass term_out parameter
10533 to construct the string_file for the command output.
10534 * ui-file.c (term_cli_styling): New function (most code moved
10535 from utils.c can_emit_style_escape).
10536 (string_file::string_file, string_file::can_emit_style_escape,
10537 stdio_file::can_emit_style_escape, tee_file::term_out,
10538 tee_file::can_emit_style_escape): New functions.
10539
105402019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10541
10542 * NEWS: Mention the new set|show may-call-functions.
10543 * infcall.c (may_call_functions_p): New variable.
10544 (show_may_call_functions_p): New function.
10545 (call_function_by_hand_dummy): Throws an error if not
10546 may-call-functions.
10547 (_initialize_infcall): Call add_setshow_boolean_cmd for
10548 may-call-functions.
10549
105502019-04-25 Keith Seitz <keiths@redhat.com>
10551
10552 PR c++/24367
10553 * cp-support.c (inspect_type): Don't attempt substitutions
10554 of symbol with the same name.
10555
105562019-04-25 Tom Tromey <tromey@adacore.com>
10557
10558 PR gdb/24475:
10559 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10560 static.
10561
105622019-04-25 Tom Tromey <tromey@adacore.com>
10563
10564 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10565 rvalue reference.
10566 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10567 (gdb_xml_parser::parse): Use std::move.
10568 * python/python-internal.h (gdbpy_convert_exception): Take a const
10569 reference.
10570 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10571 std::move.
10572 * python/py-utils.c (gdbpy_convert_exception): Take a const
10573 reference.
10574 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10575 Use std::move.
10576 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10577 Use std::move.
10578 * mi/mi-main.c (mi_print_exception): Take a const reference.
10579 * main.c (handle_command_errors): Take a const reference.
10580 * linespec.c (parse_linespec): Use std::move.
10581 * infcall.c (run_inferior_call): Use std::move.
10582 (call_function_by_hand_dummy): Use std::move.
10583 * exec.c (try_open_exec_file): Use std::move.
10584 * exceptions.h (exception_print, exception_fprintf)
10585 (exception_print_same): Update.
10586 * exceptions.c (print_exception, exception_print)
10587 (exception_fprintf, exception_print_same): Change parameters to
10588 const reference.
10589 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10590 * common/new-op.c: Use std::move.
10591 * common/common-exceptions.h (struct gdb_exception): Add move
10592 constructor.
10593 (struct gdb_exception_error, struct gdb_exception_quit, struct
10594 gdb_quit_bad_alloc): Change constructor to move constructor.
10595 (throw_exception): Change parameter to rvalue reference.
10596 * common/common-exceptions.c (throw_exception): Take rvalue
10597 reference.
10598 * cli/cli-interp.c (safe_execute_command): Use std::move.
10599 * breakpoint.c (insert_bp_location, location_to_sals): Use
10600 std::move.
10601
106022019-04-25 Tom Tromey <tromey@adacore.com>
10603
10604 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10605 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10606 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10607 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10608 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10609 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10610 guile/scm-value.c: Use unpack.
10611 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10612 gdbscm_gdb_exception.
10613 (gdbscm_throw_gdb_exception): Likewise.
10614 (struct gdbscm_gdb_exception): New.
10615 (unpack): New function.
10616 (gdbscm_wrap): Use unpack.
10617
106182019-04-25 Tom Tromey <tromey@adacore.com>
10619
10620 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10621 (gdb_rl_callback_handler): Use std::move.
10622 * common/common-exceptions.h (struct gdb_exception): Add move
10623 assignment operator.
10624 (throw_exception_sjlj): Change "exception" to const reference.
10625 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10626 (throw_exception_sjlj): Change "exception" to const reference.
10627
106282019-04-25 Tom Tromey <tromey@adacore.com>
10629
10630 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10631 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10632 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10633 Update.
10634 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10635 Update.
10636 * mi/mi-interp.c (mi_interp::exec): Update.
10637 * linespec.c (parse_linespec): Update.
10638 * infcall.c (run_inferior_call): Update.
10639 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10640 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10641 (gdbscm_lookup_global_symbol): Update.
10642 * guile/scm-param.c (gdbscm_parameter_value): Update.
10643 * guile/scm-frame.c (gdbscm_frame_read_register)
10644 (gdbscm_frame_read_var): Update.
10645 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10646 * exec.c (try_open_exec_file): Update.
10647 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10648 (gdb_rl_callback_handler): Update.
10649 * common/common-exceptions.h (exception_none): Don't declare.
10650 * common/common-exceptions.c (exception_none): Don't define.
10651 (struct catcher) <exception>: Update.
10652 * cli/cli-interp.c (safe_execute_command): Update.
10653 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10654
106552019-04-25 Ali Tamur <tamur@google.com>
10656
10657 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10658 (read_attribute_value): Likewise.
10659 (dwarf2_read_addr_index): Update comment.
10660 (read_str_index): Add DW_FORM_strx.
10661 (dwarf2_string_attr): Likewise.
10662 (dwarf2_const_value_attr): Likewise.
10663 (dump_die_shallow): Likewise.
10664 (dwarf2_fetch_constant_bytes): Likewise.
10665 (skip_form_bytes): Likewise.
10666 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10667
106682019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10669
10670 PR corefiles/11608
10671 PR corefiles/18187
10672 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10673 OFFSET. Verify if current mapping contains an ELF header.
10674 (linux_find_memory_regions_full): Adjust call to
10675 dump_mapping_p.
10676
106772019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10678 Kang Li <kanglictf@gmail.com>
10679
10680 PR gdb/21600
10681
10682 * dwarf2-frame.c (read_initial_length): Be consistent about using
10683 unsigned representation of length.
10684 (decode_frame_entry_1): Likewise. Check for wraparound of
10685 end pointer as well as buffer overflow.
10686
106872019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10688
10689 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10690 "vq".
10691
106922019-04-24 Tom Tromey <tromey@adacore.com>
10693
10694 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10695
106962019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10697
10698 * s12z-tdep.c (s12z_unwind_pc): Delete.
10699 (s12z_unwind_sp): Delete.
10700 (s12z_gdbarch_init): Don't register deleted functions with
10701 gdbarch.
10702
107032019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10704
10705 * rl78-tdep.c (rl78_unwind_sp): Delete.
10706 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10707
107082019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10709
10710 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10711 (xstormy16_unwind_pc): Delete.
10712 (xstormy16_dummy_id): Delete.
10713 (xstormy16_gdbarch_init): Don't register deleted functions with
10714 gdbarch.
10715
107162019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10717
10718 * vax-tdep.c (vax_unwind_pc): Delete.
10719 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10720
107212019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10722
10723 * v850-tdep.c (v850_unwind_sp): Delete.
10724 (v850_unwind_pc): Delete.
10725 (v850_dummy_id): Delete.
10726 (v850_gdbarch_init): Don't register deleted functions with
10727 gdbarch.
10728
107292019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10730
10731 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10732 (tilegx_unwind_pc): Delete.
10733 (tilegx_unwind_dummy_id): Delete.
10734 (tilegx_gdbarch_init): Don't register deleted functions with
10735 gdbarch.
10736
107372019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10738
10739 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10740 (tic6x_dummy_id): Delete.
10741 (tic6x_gdbarch_init): Don't register deleted functions with
10742 gdbarch.
10743
107442019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10745
10746 * sparc-tdep.c (sparc_unwind_pc): Delete.
10747 (sparc32_gdbarch_init): Don't register deleted function with
10748 gdbarch.
10749
107502019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10751
10752 * sh-tdep.c (sh_unwind_sp): Delete.
10753 (sh_unwind_pc): Delete.
10754 (sh_dummy_id): Delete.
10755 (sh_gdbarch_init): Don't register deleted functions with
10756 gdbarch.
10757
107582019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10759
10760 * score-tdep.c (score_unwind_sp): Delete.
10761 (score_unwind_pc): Delete.
10762 (score_dummy_id): Delete.
10763 (score_gdbarch_init): Don't register deleted functions with
10764 gdbarch.
10765
107662019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10767
10768 * rx-tdep.c (rx_unwind_pc): Delete.
10769 (rx_unwind_sp): Delete.
10770 (rx_dummy_id): Delete.
10771 (rx_gdbarch_init): Don't register deleted functions with
10772 gdbarch. Update comment.
10773
107742019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10775
10776 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10777 (rs6000_dummy_id): Delete.
10778 (rs6000_gdbarch_init): Don't register deleted functions with
10779 gdbarch.
10780
107812019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10782
10783 * or1k-tdep.c (or1k_dummy_id): Delete.
10784 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10785
107862019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10787
10788 * nios2-tdep.c (nios2_dummy_id): Delete.
10789 (nios2_unwind_sp): Delete.
10790 (nios2_gdbarch_init): Don't register deleted functions with
10791 gdbarch.
10792
107932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10794
10795 * nds32-tdep.c (nds32_dummy_id): Delete.
10796 (nds32_unwind_pc): Delete.
10797 (nds32_unwind_sp): Delete.
10798 (nds32_gdbarch_init): Don't register deleted functions with
10799 gdbarch.
10800
108012019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10802
10803 * msp430-tdep.c (msp430_unwind_pc): Delete.
10804 (msp430_unwind_sp): Delete.
10805 (msp430_dummy_id): Delete.
10806 (msp430_gdbarch_init): Don't register deleted functions with
10807 gdbarch.
10808
108092019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10810
10811 * moxie-tdep.c (moxie_unwind_sp): Delete.
10812 (moxie_unwind_pc): Delete.
10813 (moxie_dummy_id): Delete.
10814 (moxie_gdbarch_init): Don't register deleted functions with
10815 gdbarch.
10816
108172019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10818
10819 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10820 (mn10300_unwind_pc): Delete.
10821 (mn10300_unwind_sp): Delete.
10822 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10823 mn10300_unwind_sp.
10824 (mn10300_frame_unwind_init): Don't register deleted functions with
10825 gdbarch.
10826
108272019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10828
10829 * mep-tdep.c (mep_unwind_pc): Delete.
10830 (mep_unwind_sp): Delete.
10831 (mep_dummy_id): Delete.
10832 (mep_gdbarch_init): Don't register deleted functions with
10833 gdbarch.
10834
108352019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10836
10837 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10838 (m68hc11_unwind_sp): Delete.
10839 (m68hc11_gdbarch_init): Don't register deleted functions with
10840 gdbarch.
10841
108422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10843
10844 * m32r-tdep.c (m32r_unwind_sp): Delete.
10845 (m32r_unwind_pc): Delete.
10846 (m32r_dummy_id): Delete.
10847 (m32r_gdbarch_init): Don't register deleted functions with
10848 gdbarch.
10849
108502019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10851
10852 * m32c-tdep.c (m32c_unwind_pc): Delete.
10853 (m32c_unwind_sp): Delete.
10854 (m32c_dummy_id): Delete.
10855 (m32c_gdbarch_init): Don't register deleted functions with
10856 gdbarch.
10857
108582019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10859
10860 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10861 (lm32_unwind_pc): Delete.
10862 (lm32_dummy_id): Delete.
10863 (lm32_gdbarch_init): Don't register deleted functions with
10864 gdbarch.
10865
108662019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10867
10868 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10869 (iq2000_unwind_pc): Delete.
10870 (iq2000_dummy_id): Delete.
10871 (iq2000_gdbarch_init): Don't register deleted functions with
10872 gdbarch.
10873
108742019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10875
10876 * nds32-tdep.c (nds32_type_align): Delete.
10877 (nds32_push_dummy_call): Use type_align instead.
10878
108792019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10880
10881 * arm-tdep.c (arm_type_align): Only handle vector override case.
10882 (arm_push_dummy_call): Use type_align.
10883 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10884
108852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10886
10887 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10888 case.
10889 (pass_on_stack): Use type_align.
10890 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10891 function.
10892
108932019-04-23 Tom Tromey <tromey@adacore.com>
10894
10895 * dwarf2read.c (line_header::file_name_at): Remove unused
10896 overload.
10897
108982019-04-23 Tom de Vries <tdevries@suse.de>
10899
10900 PR gdb/24438
10901 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10902 invocation.
10903
10904
109052019-03-27 Ali Tamur <tamur@google.com>
10906
10907 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10908 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10909 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10910 (dwarf_expr_context::get_addr_index): Likewise
10911 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10912 (symbol_needs_eval_context::get_addr_index): Likewise
10913 (disassemble_dwarf_expression): Add DW_OP_addrx
10914 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10915 (read_cutu_die_from_dwo): Update comment
10916 (skip_one_die): Add DW_FORM_addrx
10917 (read_attribute_value): Likewise
10918 (var_decode_location): Add DW_OP_addrx
10919 (dwarf2_const_value_attr): Add DW_FORM_addrx
10920 (dump_die_shallow): Likewise
10921 (dwarf2_fetch_constant_bytes): Likewise
10922 (decode_locdesc): Add DW_OP_addrx
10923 (skip_form_bytes): Add DW_FORM_addrx
10924
109252019-04-22 Ali Tamur <tamur@google.com>
10926
10927 * MAINTAINERS (Write After Approval): Add self.
10928
109292019-04-22 Simon Marchi <simon.marchi@efficios.com>
10930
10931 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10932 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10933 (open_symbol_file_object): Likewise.
10934 (svr4_default_sos): Add info parameter.
10935 (svr4_read_so_list): Likewise.
10936 (svr4_current_sos_direct): Adjust functions calls to pass down
10937 info.
10938 (svr4_current_sos_1): Add info parameter.
10939 (svr4_current_sos): Call get_svr4_info, pass info down to
10940 svr4_current_sos_1.
10941 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10942 get_svr4_info.
10943 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10944 get_svr4_info.
10945 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10946 to get_svr4_info.
10947 (probes_table_remove_objfile_probes): Likewise.
10948 (register_solib_event_probe): Add info parameter.
10949 (solist_update_incremental): Pass info parameter down to
10950 svr4_read_so_list.
10951 (disable_probes_interface): Add info parameter.
10952 (svr4_handle_solib_event): Pass current_program_space to
10953 get_svr4_info. Adjust disable_probes_interface cleanup.
10954 (svr4_create_probe_breakpoints): Add info parameter, pass it
10955 down to register_solib_event_probe.
10956 (svr4_create_solib_event_breakpoints): Add info parameter,
10957 pass it down to svr4_create_probe_breakpoints.
10958 (enable_break): Pass info down to
10959 svr4_create_solib_event_breakpoints.
10960 (svr4_solib_create_inferior_hook): Pass current_program_space to
10961 get_svr4_info.
10962 (svr4_clear_solib): Likewise.
10963
109642019-04-22 Pedro Alves <palves@redhat.com>
10965
10966 * solib-svr4.c (svr4_free_objfile_observer): New.
10967 (probe_and_action::objfile): New field.
10968 (probes_table_htab_remove_objfile_probes)
10969 (probes_table_remove_objfile_probes): New functions.
10970 (register_solib_event_probe): Add 'objfile' parameter. Store it
10971 in the new probe_and_action. Don't store the probe in 'lookup'.
10972 (svr4_create_probe_breakpoints): Pass objfile to
10973 register_solib_event_probe.
10974 (_initialize_svr4_solib): Register a free_objfile observer.
10975
109762019-04-19 Tom Tromey <tom@tromey.com>
10977
10978 * common/queue.h: Remove.
10979
109802019-04-19 Tom Tromey <tom@tromey.com>
10981
10982 * event-loop.c: Don't include "common/queue.h".
10983
109842019-04-19 Tom Tromey <tom@tromey.com>
10985
10986 * remote.c (remote_target): Use delete.
10987 * remote-notif.h: Include <list>, not "common/queue.h".
10988 (notif_client_p): Remove typedef.
10989 (remote_notif_state): Add constructor, destructor, initializer.
10990 <notif_queue>: Now a std::list.
10991 (remote_notif_state_xfree): Don't declare.
10992 * remote-notif.c (remote_notif_process, handle_notification)
10993 (remote_notif_state_allocate): Update.
10994 (~remote_notif_state): Rename from remote_notif_state_xfree.
10995
109962019-04-19 Tom Tromey <tom@tromey.com>
10997
10998 * symfile.c (reread_symbols): Update.
10999 * objfiles.c (objfile_register_static_link)
11000 (objfile_lookup_static_link): Update
11001 (~objfile) Don't delete static_links.
11002 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11003
110042019-04-19 Tom Tromey <tom@tromey.com>
11005
11006 * type-stack.h (struct type_stack) <insert>: Constify string.
11007 * type-stack.c (type_stack::insert): Constify string.
11008 * gdbtypes.h (lookup_template_type): Update.
11009 (address_space_name_to_int): Update.
11010 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11011 const.
11012 (lookup_template_type): Make name const.
11013 * c-exp.y: Update rules.
11014 (lex_one_token, classify_name, classify_inner_name)
11015 (c_print_token): Update.
11016 * p-exp.y: Update rules.
11017 (yylex): Update.
11018 * f-exp.y: Update rules.
11019 (yylex): Update.
11020 * d-exp.y: Update rules.
11021 (lex_one_token, classify_name, classify_inner_name): Update.
11022 * parse.c (write_dollar_variable, copy_name): Return std::string.
11023 * parser-defs.h (copy_name): Change return type.
11024 * m2-exp.y: Update rules.
11025 (yylex): Update.
11026 * go-exp.y (lex_one_token): Update.
11027 Update rules.
11028 (classify_unsafe_function, classify_packaged_name)
11029 (classify_name, yylex): Update.
11030
110312019-04-19 Sergei Trofimovich <siarheit@google.com>
11032
11033 * configure.ac: add --enable-source-highlight switch.
11034 * configure: Regenerate.
11035 * top.c (print_gdb_version): plumb --enable-source-highlight
11036 status to "show configuration".
11037
110382019-04-19 Tom Tromey <tromey@adacore.com>
11039
11040 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11041 Check ADA_TYPE_P.
11042 (empty_record, ada_template_to_fixed_record_type_1)
11043 (template_to_static_fixed_type)
11044 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11045 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11046 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11047 macros.
11048
110492019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11050
11051 PR symtab/24423:
11052 * source.c (print_source_lines_base): Advance "iter" when a
11053 control character is seen.
11054
110552019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11056
11057 * inferior.h (struct infcall_suspend_state_deleter):
11058 Catch exception in destructor to avoid crash.
11059
110602019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11061
11062 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11063 close to the add_com "shell".
11064
110652019-04-18 Tom Tromey <tromey@adacore.com>
11066
11067 * process-stratum-target.h (class process_stratum_target)
11068 <stratum>: Add "final".
11069
110702019-04-17 Tom Tromey <tromey@adacore.com>
11071
11072 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11073 against nullptr before use.
11074
110752019-04-17 Alan Hayward <alan.hayward@arm.com>
11076
11077 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11078
110792019-04-17 Jim Wilson <jimw@sifive.com>
11080 Andrew Burgess <andrew.burgess@embecosm.com>
11081
11082 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11083 code read might fail, assume 4-byte breakpoint in that case.
11084
110852019-04-15 Leszek Swirski <leszeks@google.com>
11086
11087 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11088 rather than a hand-rolled POD check when checking for forced MEMORY
11089 classification.
11090
110912019-04-15 Alan Hayward <alan.hayward@arm.com>
11092
11093 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11094 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11095 function.
11096 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11097 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11098 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11099 declaration.
11100
111012019-04-15 Alan Hayward <alan.hayward@arm.com>
11102
11103 * aarch64-linux-nat.c
11104 (aarch64_linux_nat_target::thread_architecture): Add override.
11105 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11106 each VQ.
11107
111082019-04-15 Alan Hayward <alan.hayward@arm.com>
11109
11110 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11111
111122019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11113
11114 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11115 target types of size 96-bits, add some additional comments, and
11116 check that the builtin type we found was the correct size.
11117
111182019-04-12 Eli Zaretskii <eliz@gnu.org>
11119
11120 * utils.c (prompt_for_continue): Don't restore the styling at the
11121 end, as applied_style has the wrong value. This fixes styling in
11122 long lists of file names that are interrupted by the "Continue?"
11123 prompt.
11124
111252019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11126
11127 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11128 * c-lang.c (c_language_defn): Likewise.
11129 (cplus_language_defn): Likewise.
11130 (asm_language_defn): Likewise.
11131 (minimal_language_defn): Likewise.
11132 * d-lang.c (d_language_defn): Likewise.
11133 * f-lang.c (f_language_defn): Likewise.
11134 * go-lang.c (go_language_defn): Likewise.
11135 * language.c (unknown_language_defn): Likewise.
11136 (auto_language_defn): Likewise.
11137 * language.h (struct language_defn): Remove la_magic field.
11138 (LANG_MAGIC): Delete.
11139 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11140 * objc-lang.c (objc_language_defn): Likewise.
11141 * opencl-lang.c (opencl_language_defn): Likewise.
11142 * p-lang.c (pascal_language_defn): Likewise.
11143 * rust-lang.c (rust_language_defn): Likewise.
11144
111452019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11146
11147 * riscv-tdep.c (riscv_type_align): New function.
11148 (riscv_type_alignment): Delete.
11149 (riscv_arg_location): Use 'type_align'.
11150 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11151
111522019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11153
11154 * gdbtypes.c (type_align): A struct with no non-static fields also
11155 has alignment of 1.
11156
111572019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11158
11159 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11160 component to 0.
11161 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11162 member.
11163 (riscv_struct_info::analyse): New implementation using new
11164 analyse_inner member function.
11165 (riscv_struct_info::field_offset): New member function.
11166 (riscv_struct_info::m_offsets): New member variable.
11167 (riscv_struct_info::analyse_inner): New private member function,
11168 takes the old implementation of riscv_struct_info::analyse but
11169 extended to track field offsets.
11170 (riscv_call_arg_struct): Update the struct folding special cases
11171 to handle cases where empty C++ structs, which are non-zero
11172 length, are found.
11173 (riscv_arg_location): Initialise the length of each location, a
11174 non-zero length now indicates the location is in use.
11175 (riscv_push_dummy_call): Allow for the first location having a
11176 non-zero offset when setting up arguments.
11177 (riscv_return_value): Likewise, but for return values.
11178
111792019-04-11 Tom Tromey <tromey@adacore.com>
11180
11181 * utils.c (internal_vproblem): Make "msg" const.
11182
111832019-04-11 Alan Hayward <alan.hayward@arm.com>
11184
11185 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11186 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11187 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11188 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11189
111902019-04-10 Kevin Buettner <kevinb@redhat.com>
11191
11192 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11193 function.
11194 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11195 of amd64_collect_native_gregset.
11196 (amd64_linux_nat_target::store_registers): Likewise.
11197
111982019-04-10 Tom Tromey <tom@tromey.com>
11199
11200 * symtab.c (lookup_global_symbol_from_objfile)
11201 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11202 * objfiles.h (class separate_debug_iterator): New.
11203 (class separate_debug_range): New.
11204 (struct objfile) <separate_debug_objfiles>: New method.
11205 (objfile_separate_debug_iterate): Don't declare.
11206 * objfiles.c (separate_debug_iterator::operator++): Rename from
11207 objfile_separate_debug_iterate.
11208 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11209 iterator.
11210 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11211 iterator.
11212
112132019-04-10 Tom Tromey <tom@tromey.com>
11214
11215 * symfile.c (reread_symbols): Remove old comment.
11216 * objfiles.c (free_all_objfiles): Fix a typo.
11217
112182019-04-10 Tom Tromey <tom@tromey.com>
11219
11220 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11221 * minsyms.c (lookup_minimal_symbol): Use foreach.
11222 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11223 (lookup_minimal_symbol_solib_trampoline): Likewise.
11224 * symfile.c (reread_symbols): Use foreach.
11225
112262019-04-09 Ivan Begert <ivanbegert@gmail.com>
11227 Tom Tromey <tromey@adacore.com>
11228
11229 PR rust/24414:
11230 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11231 (rust_lex_int_test): Change "value" to be LONGEST.
11232 (rust_lex_tests): Add test for long integer literal.
11233
112342019-04-09 Tom Tromey <tromey@adacore.com>
11235
11236 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11237 to bool.
11238 (extended_remote_target::attach): Update.
11239 (remote_target::remote_notice_new_inferior): Update.
11240 (remote_target::add_current_inferior_and_thread): Update.
11241 * inferior.c (exit_inferior_1): Use "false".
11242 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11243
112442019-04-09 Simon Marchi <simon.marchi@efficios.com>
11245
11246 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11247 the "start" command.
11248
112492019-04-08 Kevin Buettner <kevinb@redhat.com>
11250
11251 * python/py-inferior.c (infpy_thread_from_thread_handle):
11252 Adjust comments to reflect renaming of thread_from_thread_handle
11253 to thread_from_handle. Adjust keywords. Fix type error message.
11254 (inferior_object_methods): Add thread_from_handle. Retain
11255 thread_from_thread_handle, but mark it as deprecated.
11256
112572019-04-08 Kevin Buettner <kevinb@redhat.com>
11258
11259 * gdbthread.h (find_thread_by_handle): Revise declaration.
11260 * thread.c (find_thread_by_handle): Likewise. Adjust
11261 implementation too.
11262 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11263 support for buffer objects as handles.
11264
112652019-04-08 Kevin Buettner <kevinb@redhat.com>
11266
11267 * python/py-infthread.c (thpy_thread_handle): New function.
11268 (thread_object_methods): Register thpy_thread_handle.
11269
112702019-04-08 Kevin Buettner <kevinb@redhat.com>
11271
11272 * gdbthread.h (thread_to_thread_handle): Declare.
11273 * thread.c (gdbtypes.h): Include.
11274 (thread_to_thread_handle): New function.
11275
11276 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11277 (target_thread_info_to_thread_handle): Declare.
11278 * target.c (target_thread_info_to_thread_handle): New function.
11279 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11280 * target-delegates.c: Regenerate.
11281
11282 * linux-thread-db.c (class thread_db_target): Add method
11283 thread_info_to_thread_handle.
11284 (thread_db_target::thread_info_to_thread_handle): Define.
11285 * remote.c (class remote_target): Add new method
11286 thread_info_to_thread_handle.
11287 (remote_target::thread_info_to_thread_handle): Define.
11288
112892019-04-08 Pedro Alves <palves@redhat.com>
11290
11291 * common/common-exceptions.c (throw_exception): Don't create
11292 named object to throw; throw directly.
11293 (throw_it): Likewise. Don't initialize gdb_exception::message
11294 here, with new; pass FMT and AP to the ctor instead.
11295 * common/common-exceptions.h: Include <string>.
11296 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11297 const char *, va_list)): New ctor. Use std::make_shared.
11298 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11299 errors)): Delete.
11300 (gdb_exception_error::gdb_exception_error(enum errors, const char
11301 *, va_list)): New.
11302 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11303 Add assertion.
11304 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11305 errors)): Delete.
11306 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11307 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11308 Add assertion.
11309
113102019-04-08 Tom Tromey <tom@tromey.com>
11311
11312 * valops.c (value_rtti_indirect_type): Replace throw_exception
11313 with throw.
11314 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11315 with throw.
11316 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11317 throw.
11318 * target.c (target_translate_tls_address): Replace throw_exception
11319 with throw.
11320 * stack.c (frame_apply_command_count): Replace throw_exception
11321 with throw.
11322 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11323 throw.
11324 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11325 with throw.
11326 * rs6000-tdep.c (rs6000_frame_cache)
11327 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11328 * remote.c: Replace throw_exception with throw.
11329 * record-full.c (record_full_message, record_full_wait_1)
11330 (record_full_restore): Replace throw_exception with throw.
11331 * record-btrace.c:
11332 (get_thread_current_frame_id, record_btrace_start_replaying)
11333 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11334 (cmd_record_btrace_start): Replace throw_exception with throw.
11335 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11336 throw.
11337 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11338 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11339 * linespec.c:
11340 (find_linespec_symbols): Replace throw_exception with throw.
11341 * infrun.c (displaced_step_prepare, resume): Replace
11342 throw_exception with throw.
11343 * infcmd.c (post_create_inferior): Replace throw_exception with
11344 throw.
11345 * inf-loop.c (inferior_event_handler): Replace throw_exception
11346 with throw.
11347 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11348 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11349 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11350 (get_prev_frame_always, get_frame_pc_if_available)
11351 (get_frame_address_in_block_if_available, get_frame_language):
11352 Replace throw_exception with throw.
11353 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11354 throw_exception with throw.
11355 * eval.c (fetch_subexp_value, evaluate_var_value)
11356 (evaluate_funcall, evaluate_subexp_standard): Replace
11357 throw_exception with throw.
11358 * dwarf2loc.c (call_site_find_chain)
11359 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11360 Replace throw_exception with throw.
11361 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11362 with throw.
11363 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11364 throw.
11365 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11366 * completer.c (complete_line_internal): Replace throw_exception
11367 with throw.
11368 * compile/compile-object-run.c (compile_object_run): Replace
11369 throw_exception with throw.
11370 * cli/cli-script.c (process_next_line): Replace throw_exception
11371 with throw.
11372 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11373 (btrace_enable, btrace_maint_update_pt_packets): Replace
11374 throw_exception with throw.
11375 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11376 throw_exception with throw.
11377 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11378 throw_exception with throw.
11379 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11380 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11381 * aarch64-tdep.c (aarch64_make_prologue_cache)
11382 (aarch64_make_stub_cache): Replace throw_exception with throw.
11383
113842019-04-08 Tom Tromey <tom@tromey.com>
11385
11386 * common/common-exceptions.c (throw_exception): Rename from
11387 throw_exception_cxx. Remove old copy. Make argument const.
11388 (throw_it): Create and throw exception objects directly.
11389 * common/common-exceptions.h (throw_exception): Make argument
11390 const.
11391 (struct gdb_exception_error): Add constructor.
11392 (struct gdb_exception_quit): Add constructor.
11393
113942019-04-08 Tom Tromey <tom@tromey.com>
11395
11396 * common/common-exceptions.h (exception_rethrow): Don't declare.
11397 (TRY_SJLJ): Update comment.
11398 (TRY, CATCH, END_CATCH): Remove.
11399 * common/common-exceptions.c (exception_rethrow): Remove.
11400
114012019-04-08 Tom Tromey <tom@tromey.com>
11402
11403 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11404 Remove.
11405 (gdb_exception_error): Rename from
11406 gdb_exception_RETURN_MASK_ERROR.
11407 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11408 (gdb_quit_bad_alloc): Update.
11409 * aarch64-tdep.c: Update.
11410 * ada-lang.c: Update.
11411 * ada-typeprint.c: Update.
11412 * ada-valprint.c: Update.
11413 * amd64-tdep.c: Update.
11414 * arch-utils.c: Update.
11415 * break-catch-throw.c: Update.
11416 * breakpoint.c: Update.
11417 * btrace.c: Update.
11418 * c-varobj.c: Update.
11419 * cli/cli-cmds.c: Update.
11420 * cli/cli-interp.c: Update.
11421 * cli/cli-script.c: Update.
11422 * common/common-exceptions.c: Update.
11423 * common/new-op.c: Update.
11424 * common/selftest.c: Update.
11425 * compile/compile-c-symbols.c: Update.
11426 * compile/compile-cplus-symbols.c: Update.
11427 * compile/compile-object-load.c: Update.
11428 * compile/compile-object-run.c: Update.
11429 * completer.c: Update.
11430 * corelow.c: Update.
11431 * cp-abi.c: Update.
11432 * cp-support.c: Update.
11433 * cp-valprint.c: Update.
11434 * darwin-nat.c: Update.
11435 * disasm-selftests.c: Update.
11436 * dtrace-probe.c: Update.
11437 * dwarf-index-cache.c: Update.
11438 * dwarf-index-write.c: Update.
11439 * dwarf2-frame-tailcall.c: Update.
11440 * dwarf2-frame.c: Update.
11441 * dwarf2loc.c: Update.
11442 * dwarf2read.c: Update.
11443 * eval.c: Update.
11444 * event-loop.c: Update.
11445 * event-top.c: Update.
11446 * exec.c: Update.
11447 * f-valprint.c: Update.
11448 * fbsd-tdep.c: Update.
11449 * frame-unwind.c: Update.
11450 * frame.c: Update.
11451 * gdbtypes.c: Update.
11452 * gnu-v3-abi.c: Update.
11453 * guile/guile-internal.h: Update.
11454 * guile/scm-block.c: Update.
11455 * guile/scm-breakpoint.c: Update.
11456 * guile/scm-cmd.c: Update.
11457 * guile/scm-disasm.c: Update.
11458 * guile/scm-frame.c: Update.
11459 * guile/scm-lazy-string.c: Update.
11460 * guile/scm-math.c: Update.
11461 * guile/scm-param.c: Update.
11462 * guile/scm-ports.c: Update.
11463 * guile/scm-pretty-print.c: Update.
11464 * guile/scm-symbol.c: Update.
11465 * guile/scm-symtab.c: Update.
11466 * guile/scm-type.c: Update.
11467 * guile/scm-value.c: Update.
11468 * i386-linux-tdep.c: Update.
11469 * i386-tdep.c: Update.
11470 * inf-loop.c: Update.
11471 * infcall.c: Update.
11472 * infcmd.c: Update.
11473 * infrun.c: Update.
11474 * jit.c: Update.
11475 * language.c: Update.
11476 * linespec.c: Update.
11477 * linux-fork.c: Update.
11478 * linux-nat.c: Update.
11479 * linux-tdep.c: Update.
11480 * linux-thread-db.c: Update.
11481 * main.c: Update.
11482 * mi/mi-cmd-break.c: Update.
11483 * mi/mi-cmd-stack.c: Update.
11484 * mi/mi-interp.c: Update.
11485 * mi/mi-main.c: Update.
11486 * objc-lang.c: Update.
11487 * p-valprint.c: Update.
11488 * parse.c: Update.
11489 * ppc-linux-tdep.c: Update.
11490 * printcmd.c: Update.
11491 * python/py-arch.c: Update.
11492 * python/py-breakpoint.c: Update.
11493 * python/py-cmd.c: Update.
11494 * python/py-finishbreakpoint.c: Update.
11495 * python/py-frame.c: Update.
11496 * python/py-framefilter.c: Update.
11497 * python/py-gdb-readline.c: Update.
11498 * python/py-inferior.c: Update.
11499 * python/py-infthread.c: Update.
11500 * python/py-lazy-string.c: Update.
11501 * python/py-linetable.c: Update.
11502 * python/py-objfile.c: Update.
11503 * python/py-param.c: Update.
11504 * python/py-prettyprint.c: Update.
11505 * python/py-progspace.c: Update.
11506 * python/py-record-btrace.c: Update.
11507 * python/py-record.c: Update.
11508 * python/py-symbol.c: Update.
11509 * python/py-type.c: Update.
11510 * python/py-unwind.c: Update.
11511 * python/py-utils.c: Update.
11512 * python/py-value.c: Update.
11513 * python/python.c: Update.
11514 * record-btrace.c: Update.
11515 * record-full.c: Update.
11516 * remote-fileio.c: Update.
11517 * remote.c: Update.
11518 * riscv-tdep.c: Update.
11519 * rs6000-aix-tdep.c: Update.
11520 * rs6000-tdep.c: Update.
11521 * rust-exp.y: Update.
11522 * rust-lang.c: Update.
11523 * s390-tdep.c: Update.
11524 * selftest-arch.c: Update.
11525 * solib-dsbt.c: Update.
11526 * solib-frv.c: Update.
11527 * solib-spu.c: Update.
11528 * solib-svr4.c: Update.
11529 * solib.c: Update.
11530 * sparc64-linux-tdep.c: Update.
11531 * stack.c: Update.
11532 * symfile-mem.c: Update.
11533 * symmisc.c: Update.
11534 * target.c: Update.
11535 * thread.c: Update.
11536 * top.c: Update.
11537 * tracefile-tfile.c: Update.
11538 * tui/tui.c: Update.
11539 * typeprint.c: Update.
11540 * unittests/cli-utils-selftests.c: Update.
11541 * unittests/parse-connection-spec-selftests.c: Update.
11542 * valops.c: Update.
11543 * valprint.c: Update.
11544 * value.c: Update.
11545 * varobj.c: Update.
11546 * windows-nat.c: Update.
11547 * x86-linux-nat.c: Update.
11548 * xml-support.c: Update.
11549
115502019-04-08 Tom Tromey <tom@tromey.com>
11551
11552 * xml-support.c: Use C++ exception handling.
11553 * x86-linux-nat.c: Use C++ exception handling.
11554 * windows-nat.c: Use C++ exception handling.
11555 * varobj.c: Use C++ exception handling.
11556 * value.c: Use C++ exception handling.
11557 * valprint.c: Use C++ exception handling.
11558 * valops.c: Use C++ exception handling.
11559 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11560 handling.
11561 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11562 * typeprint.c: Use C++ exception handling.
11563 * tui/tui.c: Use C++ exception handling.
11564 * tracefile-tfile.c: Use C++ exception handling.
11565 * top.c: Use C++ exception handling.
11566 * thread.c: Use C++ exception handling.
11567 * target.c: Use C++ exception handling.
11568 * symmisc.c: Use C++ exception handling.
11569 * symfile-mem.c: Use C++ exception handling.
11570 * stack.c: Use C++ exception handling.
11571 * sparc64-linux-tdep.c: Use C++ exception handling.
11572 * solib.c: Use C++ exception handling.
11573 * solib-svr4.c: Use C++ exception handling.
11574 * solib-spu.c: Use C++ exception handling.
11575 * solib-frv.c: Use C++ exception handling.
11576 * solib-dsbt.c: Use C++ exception handling.
11577 * selftest-arch.c: Use C++ exception handling.
11578 * s390-tdep.c: Use C++ exception handling.
11579 * rust-lang.c: Use C++ exception handling.
11580 * rust-exp.y: Use C++ exception handling.
11581 * rs6000-tdep.c: Use C++ exception handling.
11582 * rs6000-aix-tdep.c: Use C++ exception handling.
11583 * riscv-tdep.c: Use C++ exception handling.
11584 * remote.c: Use C++ exception handling.
11585 * remote-fileio.c: Use C++ exception handling.
11586 * record-full.c: Use C++ exception handling.
11587 * record-btrace.c: Use C++ exception handling.
11588 * python/python.c: Use C++ exception handling.
11589 * python/py-value.c: Use C++ exception handling.
11590 * python/py-utils.c: Use C++ exception handling.
11591 * python/py-unwind.c: Use C++ exception handling.
11592 * python/py-type.c: Use C++ exception handling.
11593 * python/py-symbol.c: Use C++ exception handling.
11594 * python/py-record.c: Use C++ exception handling.
11595 * python/py-record-btrace.c: Use C++ exception handling.
11596 * python/py-progspace.c: Use C++ exception handling.
11597 * python/py-prettyprint.c: Use C++ exception handling.
11598 * python/py-param.c: Use C++ exception handling.
11599 * python/py-objfile.c: Use C++ exception handling.
11600 * python/py-linetable.c: Use C++ exception handling.
11601 * python/py-lazy-string.c: Use C++ exception handling.
11602 * python/py-infthread.c: Use C++ exception handling.
11603 * python/py-inferior.c: Use C++ exception handling.
11604 * python/py-gdb-readline.c: Use C++ exception handling.
11605 * python/py-framefilter.c: Use C++ exception handling.
11606 * python/py-frame.c: Use C++ exception handling.
11607 * python/py-finishbreakpoint.c: Use C++ exception handling.
11608 * python/py-cmd.c: Use C++ exception handling.
11609 * python/py-breakpoint.c: Use C++ exception handling.
11610 * python/py-arch.c: Use C++ exception handling.
11611 * printcmd.c: Use C++ exception handling.
11612 * ppc-linux-tdep.c: Use C++ exception handling.
11613 * parse.c: Use C++ exception handling.
11614 * p-valprint.c: Use C++ exception handling.
11615 * objc-lang.c: Use C++ exception handling.
11616 * mi/mi-main.c: Use C++ exception handling.
11617 * mi/mi-interp.c: Use C++ exception handling.
11618 * mi/mi-cmd-stack.c: Use C++ exception handling.
11619 * mi/mi-cmd-break.c: Use C++ exception handling.
11620 * main.c: Use C++ exception handling.
11621 * linux-thread-db.c: Use C++ exception handling.
11622 * linux-tdep.c: Use C++ exception handling.
11623 * linux-nat.c: Use C++ exception handling.
11624 * linux-fork.c: Use C++ exception handling.
11625 * linespec.c: Use C++ exception handling.
11626 * language.c: Use C++ exception handling.
11627 * jit.c: Use C++ exception handling.
11628 * infrun.c: Use C++ exception handling.
11629 * infcmd.c: Use C++ exception handling.
11630 * infcall.c: Use C++ exception handling.
11631 * inf-loop.c: Use C++ exception handling.
11632 * i386-tdep.c: Use C++ exception handling.
11633 * i386-linux-tdep.c: Use C++ exception handling.
11634 * guile/scm-value.c: Use C++ exception handling.
11635 * guile/scm-type.c: Use C++ exception handling.
11636 * guile/scm-symtab.c: Use C++ exception handling.
11637 * guile/scm-symbol.c: Use C++ exception handling.
11638 * guile/scm-pretty-print.c: Use C++ exception handling.
11639 * guile/scm-ports.c: Use C++ exception handling.
11640 * guile/scm-param.c: Use C++ exception handling.
11641 * guile/scm-math.c: Use C++ exception handling.
11642 * guile/scm-lazy-string.c: Use C++ exception handling.
11643 * guile/scm-frame.c: Use C++ exception handling.
11644 * guile/scm-disasm.c: Use C++ exception handling.
11645 * guile/scm-cmd.c: Use C++ exception handling.
11646 * guile/scm-breakpoint.c: Use C++ exception handling.
11647 * guile/scm-block.c: Use C++ exception handling.
11648 * guile/guile-internal.h: Use C++ exception handling.
11649 * gnu-v3-abi.c: Use C++ exception handling.
11650 * gdbtypes.c: Use C++ exception handling.
11651 * frame.c: Use C++ exception handling.
11652 * frame-unwind.c: Use C++ exception handling.
11653 * fbsd-tdep.c: Use C++ exception handling.
11654 * f-valprint.c: Use C++ exception handling.
11655 * exec.c: Use C++ exception handling.
11656 * event-top.c: Use C++ exception handling.
11657 * event-loop.c: Use C++ exception handling.
11658 * eval.c: Use C++ exception handling.
11659 * dwarf2read.c: Use C++ exception handling.
11660 * dwarf2loc.c: Use C++ exception handling.
11661 * dwarf2-frame.c: Use C++ exception handling.
11662 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11663 * dwarf-index-write.c: Use C++ exception handling.
11664 * dwarf-index-cache.c: Use C++ exception handling.
11665 * dtrace-probe.c: Use C++ exception handling.
11666 * disasm-selftests.c: Use C++ exception handling.
11667 * darwin-nat.c: Use C++ exception handling.
11668 * cp-valprint.c: Use C++ exception handling.
11669 * cp-support.c: Use C++ exception handling.
11670 * cp-abi.c: Use C++ exception handling.
11671 * corelow.c: Use C++ exception handling.
11672 * completer.c: Use C++ exception handling.
11673 * compile/compile-object-run.c: Use C++ exception handling.
11674 * compile/compile-object-load.c: Use C++ exception handling.
11675 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11676 * compile/compile-c-symbols.c: Use C++ exception handling.
11677 * common/selftest.c: Use C++ exception handling.
11678 * common/new-op.c: Use C++ exception handling.
11679 * cli/cli-script.c: Use C++ exception handling.
11680 * cli/cli-interp.c: Use C++ exception handling.
11681 * cli/cli-cmds.c: Use C++ exception handling.
11682 * c-varobj.c: Use C++ exception handling.
11683 * btrace.c: Use C++ exception handling.
11684 * breakpoint.c: Use C++ exception handling.
11685 * break-catch-throw.c: Use C++ exception handling.
11686 * arch-utils.c: Use C++ exception handling.
11687 * amd64-tdep.c: Use C++ exception handling.
11688 * ada-valprint.c: Use C++ exception handling.
11689 * ada-typeprint.c: Use C++ exception handling.
11690 * ada-lang.c: Use C++ exception handling.
11691 * aarch64-tdep.c: Use C++ exception handling.
11692
116932019-04-08 Tom Tromey <tom@tromey.com>
11694
11695 * xml-support.c (gdb_xml_parser::parse): Update.
11696 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11697 * value.c (show_convenience): Update.
11698 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11699 (test_parse_flags_qcs): Update.
11700 * thread.c (thr_try_catch_cmd): Update.
11701 * target.c (target_translate_tls_address): Update.
11702 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11703 (info_frame_command_core, frame_apply_command_count): Update.
11704 * rust-exp.y (rust_lex_exception_test): Update.
11705 * riscv-tdep.c (riscv_print_one_register_info): Update.
11706 * remote.c (remote_target::enable_btrace): Update.
11707 * record-btrace.c (record_btrace_enable_warn): Update.
11708 * python/py-utils.c (gdbpy_convert_exception): Update.
11709 * printcmd.c (do_one_display, print_variable_and_value): Update.
11710 * mi/mi-main.c (mi_print_exception): Update.
11711 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11712 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11713 * linux-nat.c (linux_nat_target::attach): Update.
11714 * linux-fork.c (class scoped_switch_fork_info): Update.
11715 * infrun.c (displaced_step_prepare): Update.
11716 * infcall.c (call_function_by_hand_dummy): Update.
11717 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11718 * gnu-v3-abi.c (print_one_vtable): Update.
11719 * frame.c (get_prev_frame_always): Update.
11720 * f-valprint.c (info_common_command_for_block): Update.
11721 * exec.c (try_open_exec_file): Update.
11722 * exceptions.c (print_exception, exception_print)
11723 (exception_fprintf, exception_print_same): Update.
11724 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11725 * dwarf-index-cache.c (index_cache::store)
11726 (index_cache::lookup_gdb_index): Update.
11727 * darwin-nat.c (maybe_cache_shell): Update.
11728 * cp-valprint.c (cp_print_value_fields): Update.
11729 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11730 (gcc_cplus_symbol_address): Update.
11731 * compile/compile-c-symbols.c (gcc_convert_symbol)
11732 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11733 * common/selftest.c: Update.
11734 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11735 a std::string.
11736 (exception_try_scope_entry, exception_try_scope_exit): Don't
11737 declare.
11738 (struct exception_try_scope): Remove.
11739 (TRY): Don't use exception_try_scope.
11740 (struct gdb_exception): Add constructor, operator=.
11741 <what>: New method.
11742 (struct gdb_exception_RETURN_MASK_ALL)
11743 (struct gdb_exception_RETURN_MASK_ERROR)
11744 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11745 (struct gdb_quit_bad_alloc): Update.
11746 * common/common-exceptions.c (exception_none): Change
11747 initializer.
11748 (struct catcher) <state, exception>: Initialize inline.
11749 <prev>: Remove member.
11750 (current_catcher): Remove.
11751 (catchers): New global.
11752 (exceptions_state_mc_init): Simplify.
11753 (catcher_pop): Remove.
11754 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11755 (try_scope_depth, exception_try_scope_entry)
11756 (exception_try_scope_exit): Remove.
11757 (throw_exception_sjlj): Update.
11758 (exception_messages, exception_messages_size): Remove.
11759 (throw_it): Simplify.
11760 (gdb_exception_sliced_copy): Remove.
11761 (throw_exception_cxx): Update.
11762 * cli/cli-script.c (script_from_file): Update.
11763 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11764 Update.
11765 * ada-valprint.c (ada_val_print): Update.
11766 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11767 (create_excep_cond_exprs): Update.
11768
117692019-04-08 Tom Tromey <tom@tromey.com>
11770
11771 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11772 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11773 (TRY, CATCH, END_CATCH): Remove some definitions.
11774 * common/common-exceptions.c: Don't use GDB_XCPT.
11775 (catcher_list_size): Remove.
11776 (throw_exception, throw_it): Simplify.
11777
117782019-04-05 Tom Tromey <tom@tromey.com>
11779
11780 Revert the header-sorting patch.
11781 * ft32-tdep.c: Revert.
11782 * frv-tdep.c: Revert.
11783 * frv-linux-tdep.c: Revert.
11784 * frame.c: Revert.
11785 * frame-unwind.c: Revert.
11786 * frame-base.c: Revert.
11787 * fork-child.c: Revert.
11788 * findvar.c: Revert.
11789 * findcmd.c: Revert.
11790 * filesystem.c: Revert.
11791 * filename-seen-cache.h: Revert.
11792 * filename-seen-cache.c: Revert.
11793 * fbsd-tdep.c: Revert.
11794 * fbsd-nat.h: Revert.
11795 * fbsd-nat.c: Revert.
11796 * f-valprint.c: Revert.
11797 * f-typeprint.c: Revert.
11798 * f-lang.c: Revert.
11799 * extension.h: Revert.
11800 * extension.c: Revert.
11801 * extension-priv.h: Revert.
11802 * expprint.c: Revert.
11803 * exec.h: Revert.
11804 * exec.c: Revert.
11805 * exceptions.c: Revert.
11806 * event-top.c: Revert.
11807 * event-loop.c: Revert.
11808 * eval.c: Revert.
11809 * elfread.c: Revert.
11810 * dwarf2read.h: Revert.
11811 * dwarf2read.c: Revert.
11812 * dwarf2loc.c: Revert.
11813 * dwarf2expr.h: Revert.
11814 * dwarf2expr.c: Revert.
11815 * dwarf2-frame.c: Revert.
11816 * dwarf2-frame-tailcall.c: Revert.
11817 * dwarf-index-write.h: Revert.
11818 * dwarf-index-write.c: Revert.
11819 * dwarf-index-common.c: Revert.
11820 * dwarf-index-cache.h: Revert.
11821 * dwarf-index-cache.c: Revert.
11822 * dummy-frame.c: Revert.
11823 * dtrace-probe.c: Revert.
11824 * disasm.h: Revert.
11825 * disasm.c: Revert.
11826 * disasm-selftests.c: Revert.
11827 * dictionary.c: Revert.
11828 * dicos-tdep.c: Revert.
11829 * demangle.c: Revert.
11830 * dcache.h: Revert.
11831 * dcache.c: Revert.
11832 * darwin-nat.h: Revert.
11833 * darwin-nat.c: Revert.
11834 * darwin-nat-info.c: Revert.
11835 * d-valprint.c: Revert.
11836 * d-namespace.c: Revert.
11837 * d-lang.c: Revert.
11838 * ctf.c: Revert.
11839 * csky-tdep.c: Revert.
11840 * csky-linux-tdep.c: Revert.
11841 * cris-tdep.c: Revert.
11842 * cris-linux-tdep.c: Revert.
11843 * cp-valprint.c: Revert.
11844 * cp-support.c: Revert.
11845 * cp-namespace.c: Revert.
11846 * cp-abi.c: Revert.
11847 * corelow.c: Revert.
11848 * corefile.c: Revert.
11849 * continuations.c: Revert.
11850 * completer.h: Revert.
11851 * completer.c: Revert.
11852 * complaints.c: Revert.
11853 * coffread.c: Revert.
11854 * coff-pe-read.c: Revert.
11855 * cli-out.h: Revert.
11856 * cli-out.c: Revert.
11857 * charset.c: Revert.
11858 * c-varobj.c: Revert.
11859 * c-valprint.c: Revert.
11860 * c-typeprint.c: Revert.
11861 * c-lang.c: Revert.
11862 * buildsym.c: Revert.
11863 * buildsym-legacy.c: Revert.
11864 * build-id.h: Revert.
11865 * build-id.c: Revert.
11866 * btrace.c: Revert.
11867 * bsd-uthread.c: Revert.
11868 * breakpoint.h: Revert.
11869 * breakpoint.c: Revert.
11870 * break-catch-throw.c: Revert.
11871 * break-catch-syscall.c: Revert.
11872 * break-catch-sig.c: Revert.
11873 * blockframe.c: Revert.
11874 * block.c: Revert.
11875 * bfin-tdep.c: Revert.
11876 * bfin-linux-tdep.c: Revert.
11877 * bfd-target.c: Revert.
11878 * bcache.c: Revert.
11879 * ax-general.c: Revert.
11880 * ax-gdb.h: Revert.
11881 * ax-gdb.c: Revert.
11882 * avr-tdep.c: Revert.
11883 * auxv.c: Revert.
11884 * auto-load.c: Revert.
11885 * arm-wince-tdep.c: Revert.
11886 * arm-tdep.c: Revert.
11887 * arm-symbian-tdep.c: Revert.
11888 * arm-pikeos-tdep.c: Revert.
11889 * arm-obsd-tdep.c: Revert.
11890 * arm-nbsd-tdep.c: Revert.
11891 * arm-nbsd-nat.c: Revert.
11892 * arm-linux-tdep.c: Revert.
11893 * arm-linux-nat.c: Revert.
11894 * arm-fbsd-tdep.c: Revert.
11895 * arm-fbsd-nat.c: Revert.
11896 * arm-bsd-tdep.c: Revert.
11897 * arch-utils.c: Revert.
11898 * arc-tdep.c: Revert.
11899 * arc-newlib-tdep.c: Revert.
11900 * annotate.h: Revert.
11901 * annotate.c: Revert.
11902 * amd64-windows-tdep.c: Revert.
11903 * amd64-windows-nat.c: Revert.
11904 * amd64-tdep.c: Revert.
11905 * amd64-sol2-tdep.c: Revert.
11906 * amd64-obsd-tdep.c: Revert.
11907 * amd64-obsd-nat.c: Revert.
11908 * amd64-nbsd-tdep.c: Revert.
11909 * amd64-nbsd-nat.c: Revert.
11910 * amd64-nat.c: Revert.
11911 * amd64-linux-tdep.c: Revert.
11912 * amd64-linux-nat.c: Revert.
11913 * amd64-fbsd-tdep.c: Revert.
11914 * amd64-fbsd-nat.c: Revert.
11915 * amd64-dicos-tdep.c: Revert.
11916 * amd64-darwin-tdep.c: Revert.
11917 * amd64-bsd-nat.c: Revert.
11918 * alpha-tdep.c: Revert.
11919 * alpha-obsd-tdep.c: Revert.
11920 * alpha-nbsd-tdep.c: Revert.
11921 * alpha-mdebug-tdep.c: Revert.
11922 * alpha-linux-tdep.c: Revert.
11923 * alpha-linux-nat.c: Revert.
11924 * alpha-bsd-tdep.c: Revert.
11925 * alpha-bsd-nat.c: Revert.
11926 * aix-thread.c: Revert.
11927 * agent.c: Revert.
11928 * addrmap.c: Revert.
11929 * ada-varobj.c: Revert.
11930 * ada-valprint.c: Revert.
11931 * ada-typeprint.c: Revert.
11932 * ada-tasks.c: Revert.
11933 * ada-lang.c: Revert.
11934 * aarch64-tdep.c: Revert.
11935 * aarch64-ravenscar-thread.c: Revert.
11936 * aarch64-newlib-tdep.c: Revert.
11937 * aarch64-linux-tdep.c: Revert.
11938 * aarch64-linux-nat.c: Revert.
11939 * aarch64-fbsd-tdep.c: Revert.
11940 * aarch64-fbsd-nat.c: Revert.
11941 * aarch32-linux-nat.c: Revert.
11942
119432019-04-05 Tom Tromey <tom@tromey.com>
11944
11945 * ft32-tdep.c: Sort headers.
11946 * frv-tdep.c: Sort headers.
11947 * frv-linux-tdep.c: Sort headers.
11948 * frame.c: Sort headers.
11949 * frame-unwind.c: Sort headers.
11950 * frame-base.c: Sort headers.
11951 * fork-child.c: Sort headers.
11952 * findvar.c: Sort headers.
11953 * findcmd.c: Sort headers.
11954 * filesystem.c: Sort headers.
11955 * filename-seen-cache.h: Sort headers.
11956 * filename-seen-cache.c: Sort headers.
11957 * fbsd-tdep.c: Sort headers.
11958 * fbsd-nat.h: Sort headers.
11959 * fbsd-nat.c: Sort headers.
11960 * f-valprint.c: Sort headers.
11961 * f-typeprint.c: Sort headers.
11962 * f-lang.c: Sort headers.
11963 * extension.h: Sort headers.
11964 * extension.c: Sort headers.
11965 * extension-priv.h: Sort headers.
11966 * expprint.c: Sort headers.
11967 * exec.h: Sort headers.
11968 * exec.c: Sort headers.
11969 * exceptions.c: Sort headers.
11970 * event-top.c: Sort headers.
11971 * event-loop.c: Sort headers.
11972 * eval.c: Sort headers.
11973 * elfread.c: Sort headers.
11974 * dwarf2read.h: Sort headers.
11975 * dwarf2read.c: Sort headers.
11976 * dwarf2loc.c: Sort headers.
11977 * dwarf2expr.h: Sort headers.
11978 * dwarf2expr.c: Sort headers.
11979 * dwarf2-frame.c: Sort headers.
11980 * dwarf2-frame-tailcall.c: Sort headers.
11981 * dwarf-index-write.h: Sort headers.
11982 * dwarf-index-write.c: Sort headers.
11983 * dwarf-index-common.c: Sort headers.
11984 * dwarf-index-cache.h: Sort headers.
11985 * dwarf-index-cache.c: Sort headers.
11986 * dummy-frame.c: Sort headers.
11987 * dtrace-probe.c: Sort headers.
11988 * disasm.h: Sort headers.
11989 * disasm.c: Sort headers.
11990 * disasm-selftests.c: Sort headers.
11991 * dictionary.c: Sort headers.
11992 * dicos-tdep.c: Sort headers.
11993 * demangle.c: Sort headers.
11994 * dcache.h: Sort headers.
11995 * dcache.c: Sort headers.
11996 * darwin-nat.h: Sort headers.
11997 * darwin-nat.c: Sort headers.
11998 * darwin-nat-info.c: Sort headers.
11999 * d-valprint.c: Sort headers.
12000 * d-namespace.c: Sort headers.
12001 * d-lang.c: Sort headers.
12002 * ctf.c: Sort headers.
12003 * csky-tdep.c: Sort headers.
12004 * csky-linux-tdep.c: Sort headers.
12005 * cris-tdep.c: Sort headers.
12006 * cris-linux-tdep.c: Sort headers.
12007 * cp-valprint.c: Sort headers.
12008 * cp-support.c: Sort headers.
12009 * cp-namespace.c: Sort headers.
12010 * cp-abi.c: Sort headers.
12011 * corelow.c: Sort headers.
12012 * corefile.c: Sort headers.
12013 * continuations.c: Sort headers.
12014 * completer.h: Sort headers.
12015 * completer.c: Sort headers.
12016 * complaints.c: Sort headers.
12017 * coffread.c: Sort headers.
12018 * coff-pe-read.c: Sort headers.
12019 * cli-out.h: Sort headers.
12020 * cli-out.c: Sort headers.
12021 * charset.c: Sort headers.
12022 * c-varobj.c: Sort headers.
12023 * c-valprint.c: Sort headers.
12024 * c-typeprint.c: Sort headers.
12025 * c-lang.c: Sort headers.
12026 * buildsym.c: Sort headers.
12027 * buildsym-legacy.c: Sort headers.
12028 * build-id.h: Sort headers.
12029 * build-id.c: Sort headers.
12030 * btrace.c: Sort headers.
12031 * bsd-uthread.c: Sort headers.
12032 * breakpoint.h: Sort headers.
12033 * breakpoint.c: Sort headers.
12034 * break-catch-throw.c: Sort headers.
12035 * break-catch-syscall.c: Sort headers.
12036 * break-catch-sig.c: Sort headers.
12037 * blockframe.c: Sort headers.
12038 * block.c: Sort headers.
12039 * bfin-tdep.c: Sort headers.
12040 * bfin-linux-tdep.c: Sort headers.
12041 * bfd-target.c: Sort headers.
12042 * bcache.c: Sort headers.
12043 * ax-general.c: Sort headers.
12044 * ax-gdb.h: Sort headers.
12045 * ax-gdb.c: Sort headers.
12046 * avr-tdep.c: Sort headers.
12047 * auxv.c: Sort headers.
12048 * auto-load.c: Sort headers.
12049 * arm-wince-tdep.c: Sort headers.
12050 * arm-tdep.c: Sort headers.
12051 * arm-symbian-tdep.c: Sort headers.
12052 * arm-pikeos-tdep.c: Sort headers.
12053 * arm-obsd-tdep.c: Sort headers.
12054 * arm-nbsd-tdep.c: Sort headers.
12055 * arm-nbsd-nat.c: Sort headers.
12056 * arm-linux-tdep.c: Sort headers.
12057 * arm-linux-nat.c: Sort headers.
12058 * arm-fbsd-tdep.c: Sort headers.
12059 * arm-fbsd-nat.c: Sort headers.
12060 * arm-bsd-tdep.c: Sort headers.
12061 * arch-utils.c: Sort headers.
12062 * arc-tdep.c: Sort headers.
12063 * arc-newlib-tdep.c: Sort headers.
12064 * annotate.h: Sort headers.
12065 * annotate.c: Sort headers.
12066 * amd64-windows-tdep.c: Sort headers.
12067 * amd64-windows-nat.c: Sort headers.
12068 * amd64-tdep.c: Sort headers.
12069 * amd64-sol2-tdep.c: Sort headers.
12070 * amd64-obsd-tdep.c: Sort headers.
12071 * amd64-obsd-nat.c: Sort headers.
12072 * amd64-nbsd-tdep.c: Sort headers.
12073 * amd64-nbsd-nat.c: Sort headers.
12074 * amd64-nat.c: Sort headers.
12075 * amd64-linux-tdep.c: Sort headers.
12076 * amd64-linux-nat.c: Sort headers.
12077 * amd64-fbsd-tdep.c: Sort headers.
12078 * amd64-fbsd-nat.c: Sort headers.
12079 * amd64-dicos-tdep.c: Sort headers.
12080 * amd64-darwin-tdep.c: Sort headers.
12081 * amd64-bsd-nat.c: Sort headers.
12082 * alpha-tdep.c: Sort headers.
12083 * alpha-obsd-tdep.c: Sort headers.
12084 * alpha-nbsd-tdep.c: Sort headers.
12085 * alpha-mdebug-tdep.c: Sort headers.
12086 * alpha-linux-tdep.c: Sort headers.
12087 * alpha-linux-nat.c: Sort headers.
12088 * alpha-bsd-tdep.c: Sort headers.
12089 * alpha-bsd-nat.c: Sort headers.
12090 * aix-thread.c: Sort headers.
12091 * agent.c: Sort headers.
12092 * addrmap.c: Sort headers.
12093 * ada-varobj.c: Sort headers.
12094 * ada-valprint.c: Sort headers.
12095 * ada-typeprint.c: Sort headers.
12096 * ada-tasks.c: Sort headers.
12097 * ada-lang.c: Sort headers.
12098 * aarch64-tdep.c: Sort headers.
12099 * aarch64-ravenscar-thread.c: Sort headers.
12100 * aarch64-newlib-tdep.c: Sort headers.
12101 * aarch64-linux-tdep.c: Sort headers.
12102 * aarch64-linux-nat.c: Sort headers.
12103 * aarch64-fbsd-tdep.c: Sort headers.
12104 * aarch64-fbsd-nat.c: Sort headers.
12105 * aarch32-linux-nat.c: Sort headers.
12106
121072019-04-04 Tom Tromey <tom@tromey.com>
12108
12109 * varobj.c (varobj_create): Update.
12110 * rust-exp.y (struct rust_parser) <update_innermost_block,
12111 lookup_symbol>: New methods.
12112 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12113 Rename.
12114 (rust_parser::rust_lookup_type)
12115 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12116 * printcmd.c (display_command, do_one_display): Update.
12117 * parser-defs.h (struct parser_state) <parser_state>: Add
12118 "tracker" parameter.
12119 (block_tracker): New member.
12120 (class innermost_block_tracker) <innermost_block_tracker>: Add
12121 "types" parameter.
12122 <reset>: Remove method.
12123 (innermost_block): Don't declare.
12124 (null_post_parser): Update.
12125 * parse.c (innermost_block): Remove global.
12126 (write_dollar_variable): Update.
12127 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12128 Remove "tracker_types" parameter.
12129 (parse_expression): Add "tracker" parameter.
12130 (parse_expression_for_completion): Update.
12131 (null_post_parser): Add "tracker" parameter.
12132 * p-exp.y: Update rules.
12133 * m2-exp.y: Update rules.
12134 * language.h (struct language_defn) <la_post_parser>: Add
12135 "tracker" parameter.
12136 * go-exp.y: Update rules.
12137 * f-exp.y: Update rules.
12138 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12139 parameter.
12140 * d-exp.y: Update rules.
12141 * c-exp.y: Update rules.
12142 * breakpoint.c (set_breakpoint_condition): Create an
12143 innermost_block_tracker.
12144 (watch_command_1): Likewise.
12145 * ada-lang.c (resolve): Add "tracker" parameter.
12146 (resolve_subexp): Likewise.
12147 * ada-exp.y (write_var_from_sym): Update.
12148
121492019-04-04 Tom Tromey <tom@tromey.com>
12150
12151 * type-stack.h: New file.
12152 * type-stack.c: New file.
12153 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12154 type-stack.h.
12155 (insert_into_type_stack, insert_type, push_type, push_type_int)
12156 (insert_type_address_space, pop_type, pop_type_int)
12157 (pop_typelist, pop_type_stack, append_type_stack)
12158 (push_type_stack, get_type_stack, push_typelist)
12159 (follow_type_instance_flags, follow_types): Don't declare.
12160 * parse.c (type_stack): Remove global.
12161 (parse_exp_in_context): Update.
12162 (insert_into_type_stack, insert_type, push_type, push_type_int)
12163 (insert_type_address_space, pop_type, pop_type_int)
12164 (pop_typelist, pop_type_stack, append_type_stack)
12165 (push_type_stack, get_type_stack, push_typelist)
12166 (follow_type_instance_flags, follow_types): Remove (moved to
12167 type-stack.c).
12168 * f-exp.y (type_stack): New global.
12169 Update rules.
12170 (push_kind_type, f_parse): Update.
12171 * d-exp.y (type_stack): New global.
12172 Update rules.
12173 (d_parse): Update.
12174 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12175 Update rules.
12176 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12177 (HFILES_NO_SRCDIR): Add type-stack.h.
12178
121792019-04-04 Tom Tromey <tom@tromey.com>
12180
12181 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12182 (rust_parser::convert_ast_to_expression, rust_parse)
12183 (rust_lex_test_completion, rust_lex_tests): Update.
12184 * parser-defs.h (struct expr_completion_state): New.
12185 (struct parser_state) <parser_state>: Add completion parameter.
12186 <mark_struct_expression, mark_completion_tag>: New methods.
12187 <parse_completion, m_completion_state>: New members.
12188 (prefixify_expression, null_post_parser): Update.
12189 (mark_struct_expression, mark_completion_tag): Don't declare.
12190 * parse.c (parse_completion, expout_last_struct)
12191 (expout_tag_completion_type, expout_completion_name): Remove
12192 globals.
12193 (parser_state::mark_struct_expression)
12194 (parser_state::mark_completion_tag): Now methods.
12195 (prefixify_expression): Add last_struct parameter.
12196 (prefixify_subexp): Likewise.
12197 (parse_exp_1): Update.
12198 (parse_exp_in_context): Add cstate parameter. Update.
12199 (parse_expression_for_completion): Create an
12200 expr_completion_state.
12201 (null_post_parser): Add "completion" parameter.
12202 * p-exp.y: Update rules.
12203 (yylex): Update.
12204 * language.h (struct language_defn) <la_post_parser>: Add
12205 "completing" parameter.
12206 * go-exp.y: Update rules.
12207 (lex_one_token): Update.
12208 * expression.h (parse_completion): Don't declare.
12209 * d-exp.y: Update rules.
12210 (lex_one_token): Update rules.
12211 * c-exp.y: Update rules.
12212 (lex_one_token): Update.
12213 * ada-lang.c (resolve): Add "parse_completion" parameter.
12214 (resolve_subexp): Likewise.
12215 (ada_resolve_function): Likewise.
12216
122172019-04-04 Tom Tromey <tom@tromey.com>
12218
12219 * parser-defs.h (struct parser_state) <start_arglist,
12220 end_arglist>: New methods.
12221 <arglist_len, m_funcall_chain>: New members.
12222 (arglist_len, start_arglist, end_arglist): Don't declare.
12223 * parse.c (arglist_len, funcall_chain): Remove global.
12224 (start_arglist, end_arglist): Remove functions.
12225 (parse_exp_in_context): Update.
12226 * p-exp.y: Update rules.
12227 * m2-exp.y: Update rules.
12228 * go-exp.y: Update rules.
12229 * f-exp.y: Update rules.
12230 * d-exp.y: Update rules.
12231 * c-exp.y: Update rules.
12232
122332019-04-04 Tom Tromey <tom@tromey.com>
12234
12235 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12236 lex_operator, push_back>: New methods.
12237 Update all rules.
12238 (rust_parser::lex_hex, lex_escape): Rename and update.
12239 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12240 (rust_parser::lex_operator): Rename and update.
12241 (rust_parser::lex_number, rustyylex, rustyyerror)
12242 (rust_lex_test_init, rust_lex_test_sequence)
12243 (rust_lex_test_push_back, rust_lex_tests): Update.
12244 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12245 parameter.
12246 <lexptr, prev_lexptr>: New members.
12247 (lexptr, prev_lexptr): Don't declare.
12248 * parse.c (lexptr, prev_lexptr): Remove globals.
12249 (parse_exp_in_context): Update.
12250 * p-exp.y (yylex, yyerror): Update.
12251 * m2-exp.y (parse_number, yylex, yyerror): Update.
12252 * go-exp.y (lex_one_token, yyerror): Update.
12253 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12254 * d-exp.y (lex_one_token, yyerror): Update.
12255 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12256 (lex_one_token, yyerror): Update.
12257 * ada-lex.l (YY_INPUT): Update.
12258 (rewind_to_char): Update.
12259 * ada-exp.y (yyerror): Update.
12260
122612019-04-04 Tom Tromey <tom@tromey.com>
12262
12263 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12264 * parser-defs.h (struct parser_state) <parser_state>: Add new
12265 parameter.
12266 <comma_terminates>: New member.
12267 (comma_terminates): Don't declare global.
12268 * parse.c (comma_terminates): Remove global.
12269 (parse_exp_in_context): Update.
12270 * p-exp.y (yylex): Update.
12271 * m2-exp.y (yylex): Update.
12272 * go-exp.y (lex_one_token): Update.
12273 * f-exp.y (yylex): Update.
12274 * d-exp.y (lex_one_token): Update.
12275 * c-exp.y (lex_one_token): Update.
12276 * ada-lex.l: Update.
12277
122782019-04-04 Tom Tromey <tom@tromey.com>
12279
12280 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12281 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12282 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12283 * parser-defs.h (paren_depth): Don't declare.
12284 * parse.c (paren_depth): Remove global.
12285 (parse_exp_in_context): Update.
12286 * p-exp.y (paren_depth): New global.
12287 (pascal_parse): Initialize it.
12288 * m2-exp.y (paren_depth): New global.
12289 (m2_parse): Initialize it.
12290 * go-exp.y (paren_depth): New global.
12291 (go_parse): Initialize it.
12292 * f-exp.y (paren_depth): New global.
12293 (f_parse): Initialize it.
12294 * d-exp.y (paren_depth): New global.
12295 (d_parse): Initialize it.
12296 * c-exp.y (paren_depth): New global.
12297 (c_parse): Initialize it.
12298 * ada-lex.l (paren_depth): New global.
12299 (lexer_init): Initialize it.
12300
123012019-04-04 Tom Tromey <tom@tromey.com>
12302
12303 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12304 (rust_parser::convert_ast_to_type)
12305 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12306 * parser-defs.h (struct parser_state) <parser_state>: Add
12307 parameters. Initialize new members.
12308 <expression_context_block, expression_context_pc>: New members.
12309 * parse.c (expression_context_block, expression_context_pc):
12310 Remove globals.
12311 (parse_exp_in_context): Update.
12312 * p-exp.y: Update all rules.
12313 (yylex): Update.
12314 * m2-exp.y: Update all rules.
12315 (yylex): Update.
12316 * go-exp.y (yylex): Update.
12317 * f-exp.y (yylex): Update.
12318 * d-exp.y: Update all rules.
12319 (yylex): Update.
12320 * c-exp.y: Update all rules.
12321 (lex_one_token, classify_name, yylex, c_parse): Update.
12322 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12323
123242019-04-04 Tom Tromey <tom@tromey.com>
12325
12326 * gdbarch.h, gdbarch.c: Rebuild.
12327 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12328 * stap-probe.h:
12329 (struct stap_parse_info): Replace "parser_state" with
12330 "expr_builder".
12331 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12332 (parser_state): New class.
12333 * parse.c (expr_builder): Rename.
12334 (expr_builder::release): Rename.
12335 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12336 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12337 (write_exp_elt_longcst, write_exp_elt_floatcst)
12338 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12339 (write_exp_string_vector, write_exp_bitstring)
12340 (write_exp_msymbol, mark_struct_expression)
12341 (write_dollar_variable)
12342 (insert_type_address_space, increase_expout_size): Replace
12343 "parser_state" with "expr_builder".
12344 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12345 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12346 "parser_state" with "expr_builder".
12347
123482019-04-04 Tom Tromey <tom@tromey.com>
12349
12350 * rust-exp.y: Replace "parse_language" with method call.
12351 * p-exp.y:
12352 (yylex): Replace "parse_language" with method call.
12353 * m2-exp.y:
12354 (yylex): Replace "parse_language" with method call.
12355 * go-exp.y (classify_name): Replace "parse_language" with method
12356 call.
12357 * f-exp.y (yylex): Replace "parse_language" with method call.
12358 * d-exp.y (lex_one_token): Replace "parse_language" with method
12359 call.
12360 * c-exp.y:
12361 (lex_one_token, classify_name, yylex): Replace "parse_language"
12362 with method call.
12363 * ada-exp.y (find_primitive_type, type_char)
12364 (type_system_address): Replace "parse_language" with method call.
12365
123662019-04-04 Tom Tromey <tom@tromey.com>
12367
12368 * rust-exp.y: Replace "parse_gdbarch" with method call.
12369 * parse.c (write_dollar_variable, insert_type_address_space):
12370 Replace "parse_gdbarch" with method call.
12371 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12372 call.
12373 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12374 call.
12375 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12376 "parse_gdbarch" with method call.
12377 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12378 with method call.
12379 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12380 "parse_gdbarch" with method call.
12381 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12382 "parse_gdbarch" with method call.
12383 * c-exp.y (parse_type, parse_number, classify_name): Replace
12384 "parse_gdbarch" with method call.
12385 * ada-lex.l: Replace "parse_gdbarch" with method call.
12386 * ada-exp.y (parse_type, find_primitive_type, type_char)
12387 (type_system_address): Replace "parse_gdbarch" with method call.
12388
123892019-04-04 Tom Tromey <tom@tromey.com>
12390
12391 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12392 * stap-probe.c (stap_parse_argument): Update.
12393 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12394 initial_size parameter.
12395 * rust-exp.y (rust_lex_tests): Update.
12396 * parse.c (parser_state): Update.
12397 (parse_exp_in_context): Update.
12398 * parser-defs.h (struct parser_state) <parser_state>: Remove
12399 "initial_size" parameter.
12400
124012019-04-04 Tom Tromey <tom@tromey.com>
12402
12403 * parser-defs.h (increase_expout_size): Don't declare.
12404 * parse.c (increase_expout_size): Now static.
12405
124062019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12407
12408 * gnu-nat.c (gnu_nat_target::wait): Fix
12409 target_waitstatus_to_string call.
12410
124112019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12412
12413 * eval.c (evaluate_subexp_standard): Handle internal functions
12414 during Fortran function call handling.
12415
124162019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12417
12418 * NEWS: Mention new internal functions.
12419 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12420 (read_base_type): Use dwarf2_init_complex_target_type.
12421 * value.c (creal_internal_fn): New function.
12422 (cimag_internal_fn): New function.
12423 (_initialize_values): Register new internal functions.
12424
124252019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12426
12427 * infrun.c (stop_all_threads): If debug_infrun, always
12428 trace the wait status after wait_one, using
12429 target_waitstatus_to_string and target_pid_to_str.
12430 (handle_inferior_event): Replace various trace of
12431 wait status kind by a single trace.
12432 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12433 wait status kind image by target_waitstatus_to_string.
12434 * target/waitstatus.c (target_waitstatus_to_string): Fix
12435 obsolete comment.
12436
124372019-04-01 Tom Tromey <tromey@adacore.com>
12438
12439 PR symtab/23331:
12440 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12441
124422019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12443 Pedro Alves <palves@redhat.com>
12444
12445 * top.c (quit_force): Call 'finalize_values'.
12446 * value.c (finalize_values): New function.
12447 * value.h (finalize_values): Declare.
12448
124492019-03-30 Eli Zaretskii <eliz@gnu.org>
12450
12451 * NEWS: Announce $_gdb_major and $_gdb_minor.
12452
12453 * top.c (init_gdb_version_vars): New function.
12454 (gdb_init): Call init_gdb_version_vars.
12455
124562019-03-29 Tom Tromey <tromey@adacore.com>
12457
12458 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12459 help text. Remove dead code.
12460
124612019-03-29 Keith Seitz <keiths@redhat.com>
12462
12463 From Siddhesh Poyarekar:
12464 * f-lang.h (f77_get_upperbound): Return LONGEST.
12465 (f77_get_lowerbound): Likewise.
12466 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12467 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12468 print them.
12469 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12470 plongest to format print it.
12471 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12472 (f77_get_upperbound): Likewise.
12473 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12474 LOWER_BOUND to LONGEST.
12475 (f77_create_arrayprint_offset_tbl): Likewise.
12476
124772019-03-29 Keith Seitz <keiths@redhat.com>
12478
12479 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12480 %s/pulongest for TYPE_LENGTH instead of %d in format
12481 strings.
12482 * ada-typerint.c (ada_print_type): Likewise.
12483 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12484 * compile/compile-c-support.c (generate_register_struct): Likewise.
12485 * gdbtypes.c (recursive_dump_type): Likewise.
12486 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12487 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12488 instead of %d in format strings.
12489 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12490 to std::min to ULONGEST.
12491 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12492 instead of %d in format strings.
12493 * tracepoint.c (info_scope_command): Likewise.
12494 * typeprint.c (print_offset_data::update)
12495 (print_offset_data::finish): Likewise.
12496 * xtensa-tdep.c (xtensa_store_return_value)
12497 (xtensa_push_dummy_call): Likewise.
12498
124992019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12500
12501 * windows-nat.c (display_selector): Fixed format specifications
12502 for 64-bit Cygwin.
12503
125042019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12505
12506 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12507
125082019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12509
12510 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12511 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12512 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12513 (nios2_linux_init_abi): Install it.
12514
125152019-03-28 Alan Hayward <alan.hayward@arm.com>
12516
12517 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12518
125192019-03-28 Alan Hayward <alan.hayward@arm.com>
12520
12521 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12522
125232019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12524 Tom Tromey <tromey@adacore.com>
12525
12526 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12527
125282019-03-26 Joel Brobecker <brobecker@adacore.com>
12529
12530 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12531 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12532 method to compute the bounds of range types. Also print "[evaluated]"
12533 if the bounds' values come from a dynamic evaluation.
12534
125352019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12536
12537 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12538 whitespace when pretty printing is on.
12539
125402019-03-26 Alan Hayward <alan.hayward@arm.com>
12541
12542 * ppc-linux-nat.c: Add include.
12543
125442019-03-26 Alan Hayward <alan.hayward@arm.com>
12545
12546 * NEWS: Mention AArch64 Pointer Authentication.
12547
125482019-03-26 Alan Hayward <alan.hayward@arm.com>
12549
12550 * arm-linux-nat.c: Add include.
12551
125522019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12553
12554 * source-cache.c (source_cache::get_source_lines): Re-read
12555 fullname after calling open_source_file.
12556
125572019-03-25 John Baldwin <jhb@FreeBSD.org>
12558
12559 * NEWS: Mention TLS support for FreeBSD.
12560
125612019-03-25 Tom Tromey <tromey@adacore.com>
12562
12563 * minsyms.c (BUNCH_SIZE): Update comment.
12564 (~minimal_symbol_reader): Remove old comment.
12565 (compact_minimal_symbols): Update comment.
12566 (minimal_symbol_reader::install): Remove old comment. Update
12567 other comments.
12568
125692019-03-25 Alan Hayward <alan.hayward@arm.com>
12570
12571 * s390-linux-nat.c: Add include.
12572
125732019-03-25 Alan Hayward <alan.hayward@arm.com>
12574
12575 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12576 Call linux_get_hwcap.
12577 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12578 Likewise.
12579 (aarch64_linux_get_hwcap): Remove function.
12580 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12581 declaration.
12582 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12583 linux_get_hwcap.
12584 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12585 * linux-tdep.c (linux_get_hwcap): Add function.
12586 (linux_get_hwcap2): Likewise.
12587 * linux-tdep.h (linux_get_hwcap): Add declaration.
12588 (linux_get_hwcap2): Likewise.
12589 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12590 (ppc_linux_get_hwcap2): Likewise.
12591 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12592 linux_get_hwcap.
12593 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12594 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12595 (ppc_linux_nat_target::read_description): Likewise.
12596 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12597 * s390-linux-nat.c: Likewise.
12598 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12599
126002019-03-24 Tom Tromey <tom@tromey.com>
12601
12602 * ada-lang.c (standard_lookup): Simplify initialization.
12603 (ada_lookup_symbol_nonlocal): Simplify return.
12604 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12605 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12606 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12607 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12608 initialization.
12609 * solib.c (solib_global_lookup): Simplify.
12610 * symtab.c (null_block_symbol): Remove.
12611 (symbol_cache_lookup): Simplify returns.
12612 (lookup_language_this): Simplify returns.
12613 (lookup_symbol_aux): Simplify return.
12614 (lookup_local_symbol): Simplify returns.
12615 (lookup_global_symbol_from_objfile): Simplify return.
12616 (lookup_symbol_in_objfile_symtabs)
12617 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12618 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12619 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12620 * cp-namespace.c (cp_lookup_bare_symbol)
12621 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12622 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12623 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12624 (cp_lookup_symbol_via_imports): Simplify initialization.
12625 (find_symbol_in_baseclass): Likewise.
12626 * symtab.h (null_block_symbol): Remove.
12627 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12628 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12629 (d_lookup_symbol_module): Likewise.
12630 (find_symbol_in_baseclass): Simplify initialization.
12631
126322019-03-24 Tom Tromey <tom@tromey.com>
12633
12634 * expression.h: Don't include symtab.h.
12635 (struct block): Forward declare.
12636
126372019-03-24 Tom Tromey <tom@tromey.com>
12638
12639 * c-exp.y (typebase): Remove casts.
12640 * gdbtypes.c (lookup_unsigned_typename, )
12641 (lookup_signed_typename): Remove cast.
12642 * eval.c (parse_to_comma_and_eval): Remove cast.
12643 * parse.c (write_dollar_variable): Remove cast.
12644 * block.h (struct block) <superblock>: Now const.
12645 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12646 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12647 (map_block): Make "block" const.
12648 * symfile.h (struct quick_symbol_functions)
12649 <map_matching_symbols>: Constify block argument to "callback".
12650 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12651 const.
12652 (find_pc_sect_compunit_symtab): Make "b" const.
12653 (find_symbol_at_address): Likewise.
12654 (search_symbols): Likewise.
12655 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12656 (dw2_debug_names_lookup_symbol): Likewise.
12657 (dw2_map_matching_symbols): Update.
12658 * p-valprint.c (pascal_val_print): Remove "block".
12659 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12660 (aux_add_nonlocal_symbols): Make "block" const.
12661 (resolve_subexp): Remove cast.
12662 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12663 const.
12664 (iterate_over_file_blocks): Likewise.
12665 * f-exp.y (%union) <bval>: Remove.
12666 * coffread.c (patch_opaque_types): Make "b" const.
12667 * spu-tdep.c (spu_catch_start): Make "block" const.
12668 * c-valprint.c (print_unpacked_pointer): Remove "block".
12669 * symmisc.c (dump_symtab_1): Make "b" const.
12670 (block_depth): Make "block" const.
12671 * d-exp.y (%union) <bval>: Remove.
12672 * cp-support.h (cp_lookup_rtti_type): Update.
12673 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12674 * psymtab.c (psym_lookup_symbol): Make "block" const.
12675 (maintenance_check_psymtabs): Make "b" const.
12676 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12677 (enumerate_locals, enumerate_args): Update.
12678 * python/py-symtab.c (stpy_global_block): Make "block" const.
12679 (stpy_static_block): Likewise.
12680 * inline-frame.c (block_starting_point_at): Make "new_block"
12681 const.
12682 * block.c (find_block_in_blockvector): Make return type const.
12683 (blockvector_for_pc_sect): Make "b" const.
12684 (find_block_in_blockvector): Make "b" const.
12685
126862019-03-23 Tom Tromey <tom@tromey.com>
12687
12688 * varobj.c (varobj_create): Update.
12689 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12690 * printcmd.c (display_command, do_one_display): Don't reset
12691 innermost_block.
12692 * parser-defs.h (enum innermost_block_tracker_type): Move to
12693 expression.h.
12694 (innermost_block): Update comment.
12695 * parse.c (parse_exp_1): Add tracker_types parameter.
12696 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12697 tracker_types parameter. Reset innermost_block.
12698 (parse_exp_in_context): Remove.
12699 (parse_expression_for_completion): Update.
12700 * objfiles.c (~objfile): Don't reset expression_context_block or
12701 innermost_block.
12702 * expression.h (enum innermost_block_tracker_type): Move from
12703 parser-defs.h.
12704 (parse_exp_1): Add tracker_types parameter.
12705 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12706 reset innermost_block.
12707
127082019-03-23 Tom Tromey <tom@tromey.com>
12709
12710 * objfiles.h: Include bcache.h.
12711
127122019-03-23 Tom Tromey <tom@tromey.com>
12713
12714 * linespec.c (get_current_search_block): Use
12715 scoped_restore_current_language.
12716 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12717
127182019-03-22 Alan Hayward <alan.hayward@arm.com>
12719 Jiong Wang <jiong.wang@arm.com>
12720
12721 * aarch64-linux-tdep.c
12722 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12723 section.
12724 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12725
127262019-03-22 Alan Hayward <alan.hayward@arm.com>
12727 Jiong Wang <jiong.wang@arm.com>
12728
12729 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12730 instructions.
12731 (aarch64_analyze_prologue_test): Add PACIASP test.
12732 (aarch64_prologue_prev_register): Unmask PC value.
12733
127342019-03-22 Alan Hayward <alan.hayward@arm.com>
12735 Jiong Wang <jiong.wang@arm.com>
12736
12737 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12738 (aarch64_dwarf2_prev_register): Unmask PC value.
12739 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12740 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12741 DW_CFA_AARCH64_negate_ra_state.
12742 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12743
127442019-03-22 Alan Hayward <alan.hayward@arm.com>
12745 Jiong Wang <jiong.wang@arm.com>
12746
12747 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12748 registers.
12749 (aarch64_pseudo_register_name): Likewise.
12750 (aarch64_pseudo_register_type): Likewise.
12751 (aarch64_pseudo_register_reggroup_p): Likewise.
12752 (aarch64_gdbarch_init): Add pauth registers.
12753 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12754 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12755 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12756 (struct gdbarch_tdep): Add regnum for ra_state.
12757
127582019-03-22 Alan Hayward <alan.hayward@arm.com>
12759 Jiong Wang <jiong.wang@arm.com>
12760
12761 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12762
127632019-03-22 Alan Hayward <alan.hayward@arm.com>
12764 Jiong Wang <jiong.wang@arm.com>
12765
12766 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12767 function.
12768 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12769 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12770 (aarch64_gdbarch_init): Add puth registers.
12771 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12772 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12773 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12774
127752019-03-22 Alan Hayward <alan.hayward@arm.com>
12776 Jiong Wang <jiong.wang@arm.com>
12777
12778 * aarch64-linux-nat.c
12779 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12780 * aarch64-linux-tdep.c
12781 (aarch64_linux_core_read_description): Likewise.
12782 (aarch64_linux_get_hwcap): New function.
12783 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12784 (aarch64_linux_get_hwcap): New declaration.
12785
127862019-03-22 Alan Hayward <alan.hayward@arm.com>
12787 Jiong Wang <jiong.wang@arm.com>
12788
12789 * aarch64-linux-nat.c
12790 (aarch64_linux_nat_target::read_description): Add pauth param.
12791 * aarch64-linux-tdep.c
12792 (aarch64_linux_core_read_description): Likewise.
12793 * aarch64-tdep.c (struct target_desc): Add in pauth.
12794 (aarch64_read_description): Add pauth param.
12795 (aarch64_gdbarch_init): Likewise.
12796 * aarch64-tdep.h (aarch64_read_description): Likewise.
12797 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12798 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12799 * features/Makefile: Add new files.
12800 * features/aarch64-pauth.c: New file.
12801 * features/aarch64-pauth.xml: New file.
12802
128032019-03-20 Tom Tromey <tromey@adacore.com>
12804
12805 * infrun.c (handle_inferior_event): Rename from
12806 handle_inferior_event_1. Create a scoped_value_mark.
12807 (handle_inferior_event): Remove.
12808
128092019-03-19 Tom Tromey <tromey@adacore.com>
12810
12811 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12812 * infrun.h (print_stop_event): Add "displays" parameter.
12813 * infrun.c (print_stop_event): Add "displays" parameter.
12814
128152019-03-19 Pedro Alves <palves@redhat.com>
12816
12817 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12818 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12819 to -1. Fix TABs vs spaces.
12820 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12821 * tui/tui-out.h (tui_ui_out) Add intro comments.
12822 <m_line, m_start_of_line>: In-class initialize, and add describing
12823 comment.
12824
128252019-03-18 Alan Hayward <alan.hayward@arm.com>
12826
12827 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12828 variable names.
12829 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12830
128312019-03-18 Pedro Alves <palves@redhat.com>
12832 Eli Zaretskii <eliz@gnu.org>
12833
12834 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12835 m_line and m_start_of_line.
12836
128372019-03-18 Eli Zaretskii <eliz@gnu.org>
12838
12839 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12840 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12841 it returns a newline. This fixes a regression in TU mode, whereby
12842 the next line is output on the same screen line as the user input.
12843
128442019-03-18 Tom Tromey <tromey@adacore.com>
12845
12846 * minsyms.c (minimal_symbol_reader::install): Remove call to
12847 obstack_blank.
12848
128492019-03-18 Pedro Alves <palves@redhat.com>
12850
12851 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12852 New globals.
12853 (apply_style): New, factored out from ...
12854 (apply_ansi_escape): ... this. Handle reverse video mode.
12855 (tui_set_reverse_mode): New function.
12856 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12857 * tui/tui-winsource.c (tui_show_source_line): Use
12858 tui_set_reverse_mode instead of setting A_STANDOUT.
12859 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12860 New setter methods.
12861
128622019-03-18 Hannes Domani <ssbssa@yahoo.de>
12863
12864 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12865 Handle tabs.
12866
128672019-03-18 Tom Tromey <tromey@adacore.com>
12868
12869 * ada-lang.c (empty_array): Add "high" parameter.
12870 (ada_evaluate_subexp): Update.
12871
128722019-03-17 Sergei Trofimovich <siarheit@google.com>
12873
12874 * unittests/string_view-selftests.c: Define
12875 _initialize_string_view_selftests unconditionally.
12876
128772019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12878
12879 PR gdb/24350
12880 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12881
128822019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12883
12884 PR gdb/24351
12885 * windows-nat.c (display_selector): Fix format specifiers.
12886
128872019-03-17 Eli Zaretskii <eliz@gnu.org>
12888
12889 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12890 tui_refill_source_window instead of tui_refresh_win, to update the
12891 current execution line. This fixes redisplay of the current line
12892 when stepping through the code with "next" or "step".
12893
128942019-03-16 Eli Zaretskii <eliz@gnu.org>
12895
12896 * source-cache.c (source_cache::get_source_lines): Call
12897 find_source_lines to initialize s->nlines. This fixes vertical
12898 scrolling of TUI source window when the DOWN arrow is pressed.
12899
129002019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12901
12902 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12903 linux-thread-db.c (_initialize_thread_db): Likewise.
12904
129052019-03-16 Eli Zaretskii <eliz@gnu.org>
12906
12907 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12908 wclrtoeol in tui_show_source_line". This reverts changes made in
12909 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12910
129112019-03-15 Tom Tromey <tom@tromey.com>
12912
12913 * symtab.h (struct minimal_symbol): Derive from
12914 general_symbol_info.
12915 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12916 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12917 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12918 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12919 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12920 (MSYMBOL_SEARCH_NAME): Update.
12921 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12922 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12923 * minsyms.c (minimal_symbol_reader::record_full): Update.
12924
129252019-03-15 Tom Tromey <tom@tromey.com>
12926
12927 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12928
129292019-03-15 Tom Tromey <tom@tromey.com>
12930
12931 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12932 unique_xmalloc_ptr.
12933 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12934 Update.
12935 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12936 (build_minimal_symbol_hash_tables)
12937 (minimal_symbol_reader::install): Update.
12938
129392019-03-15 Tom Tromey <tom@tromey.com>
12940
12941 * symtab.c (create_demangled_names_hash): Update.
12942 (symbol_set_names): Update.
12943 * objfiles.h (struct objfile_per_bfd_storage)
12944 <demangled_names_hash>: Now an htab_up.
12945 * objfiles.c (objfile_per_bfd_storage): Simplify.
12946
129472019-03-15 Tom Tromey <tom@tromey.com>
12948
12949 * objfiles.h (struct objfile_per_bfd_storage): Declare
12950 destructor.
12951 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12952 New.
12953 (get_objfile_bfd_data): Use new. Don't initialize
12954 language_of_main.
12955 (free_objfile_per_bfd_storage): Remove.
12956 (objfile_bfd_data_free, objfile::~objfile): Use delete.
12957
129582019-03-15 Tom Tromey <tom@tromey.com>
12959
12960 * symfile.c (reread_symbols): Update.
12961 * objfiles.c (objfile::objfile): Update.
12962 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12963 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12964 comment.
12965 (minimal_symbol_reader::install): Update.
12966 (terminate_minimal_symbol_table): Remove.
12967 * jit.c (jit_object_close_impl): Update.
12968
129692019-03-15 Tom Tromey <tom@tromey.com>
12970
12971 * minsyms.c (minimal_symbol_reader::record_full): Remove some
12972 initializations.
12973
129742019-03-15 Tom Tromey <tom@tromey.com>
12975
12976 * objfiles.h (struct objfile_per_bfd_storage)
12977 <demangled_hash_languages>: Now a bitset.
12978 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12979 (lookup_minimal_symbol): Update.
12980
129812019-03-15 Tom Tromey <tom@tromey.com>
12982
12983 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12984 Don't return the symbol.
12985 * coffread.c (record_minimal_symbol): Use record_full.
12986
129872019-03-14 Eli Zaretskii <eliz@gnu.org>
12988
12989 The MS-Windows port of ncurses fails to switch to a color pair if
12990 one or both of the colors are the implicit default colors. This
12991 change records the default colors when TUI is initialized, and
12992 then specifies them explicitly when a color pair uses the default
12993 colors. This allows color styling in TUI mode on MS-Windows.
12994
12995 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
12996 ncurses_norm_attr.
12997 (tui_initialize_io) [__MINGW32__]: Record the default terminal
12998 colors in ncurses_norm_attr.
12999 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13000 "none", replace it with the default color recorded in
13001 ncurses_norm_attr.
13002
130032019-03-14 Tom Tromey <tromey@adacore.com>
13004
13005 * source-cache.h (class source_cache) <get_source_lines>: Return
13006 std::string.
13007 * source-cache.c (source_cache::extract_lines): Handle case where
13008 first_pos==npos. Return std::string.
13009 (source_cache::get_source_lines): Update.
13010
130112019-03-14 Tom Tromey <tromey@adacore.com>
13012
13013 * NEWS: Add item for "style sources" commands.
13014 * source-cache.c (source_cache::get_source_lines): Check
13015 source_styling.
13016 * cli/cli-style.c (source_styling): New global.
13017 (_initialize_cli_style): Add "style sources" commands.
13018 (show_style_sources): New function.
13019 * cli/cli-style.h (source_styling): Declare.
13020
130212019-03-14 Pedro Alves <palves@redhat.com>
13022 Tom Tromey <tromey@adacore.com>
13023
13024 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13025 * tui/tui-winsource.c (tui_refill_source_window): New function,
13026 from...
13027 (tui_horizontal_source_scroll): ... here. Move some logic.
13028 * cli/cli-style.c (set_style_enabled): Notify new observable.
13029 * tui/tui-hooks.c (tui_redisplay_source): New function.
13030 (tui_attach_detach_observers): Attach or detach
13031 tui_redisplay_source.
13032 * observable.h (source_styling_changed): New observable.
13033 * observable.c: Define source_styling_changed observable.
13034
130352019-03-13 Tom Tromey <tromey@adacore.com>
13036
13037 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13038 (i386_gnu_nat_target::store_registers): Update.
13039 * target-debug.h (target_debug_print_std_string): New macro.
13040 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13041 * windows-tdep.c (display_one_tib): Update.
13042 * tui/tui-stack.c (tui_make_status_line): Update.
13043 * top.c (print_inferior_quit_action): Update.
13044 * thread.c (thr_try_catch_cmd): Update.
13045 (add_thread_with_info): Update.
13046 (thread_target_id_str): Update.
13047 (thr_try_catch_cmd): Update.
13048 (thread_command): Update.
13049 (thread_find_command): Update.
13050 * record-btrace.c (record_btrace_target::info_record)
13051 (record_btrace_resume_thread, record_btrace_target::resume)
13052 (record_btrace_cancel_resume, record_btrace_step_thread)
13053 (record_btrace_target::wait, record_btrace_target::wait)
13054 (record_btrace_target::wait, record_btrace_target::stop): Update.
13055 * progspace.c (print_program_space): Update.
13056 * process-stratum-target.c
13057 (process_stratum_target::thread_address_space): Update.
13058 * linux-fork.c (linux_fork_mourn_inferior)
13059 (detach_checkpoint_command, info_checkpoints_command)
13060 (linux_fork_context): Update.
13061 (linux_fork_detach): Update.
13062 (class scoped_switch_fork_info): Update.
13063 (delete_checkpoint_command): Update.
13064 * infrun.c (follow_fork_inferior): Update.
13065 (follow_fork_inferior): Update.
13066 (proceed_after_vfork_done): Update.
13067 (handle_vfork_child_exec_or_exit): Update.
13068 (follow_exec): Update.
13069 (displaced_step_prepare_throw): Update.
13070 (displaced_step_restore): Update.
13071 (start_step_over): Update.
13072 (resume_1): Update.
13073 (clear_proceed_status_thread): Update.
13074 (proceed): Update.
13075 (print_target_wait_results): Update.
13076 (do_target_wait): Update.
13077 (context_switch): Update.
13078 (stop_all_threads): Update.
13079 (restart_threads): Update.
13080 (finish_step_over): Update.
13081 (handle_signal_stop): Update.
13082 (switch_back_to_stepped_thread): Update.
13083 (keep_going_pass_signal): Update.
13084 (print_exited_reason): Update.
13085 (normal_stop): Update.
13086 * inferior.c (inferior_pid_to_str): Change return type.
13087 (print_selected_inferior): Update.
13088 (add_inferior): Update.
13089 (detach_inferior): Update.
13090 * dummy-frame.c (fprint_dummy_frames): Update.
13091 * dcache.c (dcache_info_1): Update.
13092 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13093 (btrace_fetch, btrace_clear): Update.
13094 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13095 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13096 type.
13097 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13098 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13099 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13100 * gdbarch.c, gdbarch.h: Rebuild.
13101 * gdbarch.sh (core_pid_to_str): Change return type.
13102 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13103 return type.
13104 (windows_nat_target::pid_to_str): Change return type.
13105 (windows_delete_thread): Update.
13106 (windows_nat_target::attach): Update.
13107 (windows_nat_target::files_info): Update.
13108 * target-delegates.c: Rebuild.
13109 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13110 return type.
13111 (sol_thread_target::pid_to_str): Change return type.
13112 * remote.c (class remote_target) <pid_to_str>: Change return
13113 type.
13114 (remote_target::pid_to_str): Change return type.
13115 (extended_remote_target::attach, remote_target::remote_stop_ns)
13116 (remote_target::remote_notif_remove_queued_reply)
13117 (remote_target::push_stop_reply, remote_target::disable_btrace):
13118 Update.
13119 (extended_remote_target::attach): Update.
13120 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13121 type.
13122 (gdbsim_target::pid_to_str): Change return type.
13123 * ravenscar-thread.c (struct ravenscar_thread_target)
13124 <pid_to_str>: Change return type.
13125 (ravenscar_thread_target::pid_to_str): Change return type.
13126 * procfs.c (class procfs_target) <pid_to_str>: Change return
13127 type.
13128 (procfs_target::pid_to_str): Change return type.
13129 (procfs_target::attach): Update.
13130 (procfs_target::detach): Update.
13131 (procfs_target::fetch_registers): Update.
13132 (procfs_target::store_registers): Update.
13133 (procfs_target::wait): Update.
13134 (procfs_target::files_info): Update.
13135 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13136 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13137 return type.
13138 (nto_procfs_target::pid_to_str): Change return type.
13139 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13140 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13141 return type.
13142 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13143 (exit_lwp): Update.
13144 (attach_proc_task_lwp_callback, get_detach_signal)
13145 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13146 (linux_nat_target::resume, wait_lwp, stop_callback)
13147 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13148 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13149 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13150 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13151 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13152 type.
13153 (inf_ptrace_target::attach): Update.
13154 (inf_ptrace_target::files_info): Update.
13155 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13156 type.
13157 (go32_nat_target::pid_to_str): Change return type.
13158 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13159 (gnu_nat_target::wait): Update.
13160 (gnu_nat_target::wait): Update.
13161 (gnu_nat_target::resume): Update.
13162 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13163 (fbsd_nat_target::wait): Update.
13164 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13165 type.
13166 (darwin_nat_target::attach): Update.
13167 * corelow.c (class core_target) <pid_to_str>: Change return type.
13168 (core_target::pid_to_str): Change return type.
13169 * target.c (normal_pid_to_str): Change return type.
13170 (default_pid_to_str): Likewise.
13171 (target_pid_to_str): Change return type.
13172 (target_translate_tls_address): Update.
13173 (target_announce_detach): Update.
13174 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13175 return type.
13176 (bsd_uthread_target::pid_to_str): Change return type.
13177 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13178 type.
13179 (bsd_kvm_target::pid_to_str): Change return type.
13180 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13181 return type.
13182 (aix_thread_target::pid_to_str): Change return type.
13183 * target.h (struct target_ops) <pid_to_str>: Change return type.
13184 (target_pid_to_str, normal_pid_to_str): Likewise.
13185 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13186 type.
13187 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13188 type.
13189 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13190 return type.
13191 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13192 type.
13193 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13194 type.
13195 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13196 return type.
13197
131982019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13199
13200 * NEWS: Mention that the new default MI version is 3. Mention
13201 changes to the output of commands and events that deal with
13202 multi-location breakpoints.
13203 * breakpoint.c: Include "mi/mi-out.h".
13204 (print_one_breakpoint): Change output syntax if using MI version
13205 >= 3.
13206 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13207 New.
13208 (mi_multi_location_breakpoint_output_fixed): New.
13209 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13210 (mi_cmd_fix_multi_location_breakpoint_output): New.
13211 (mi_multi_location_breakpoint_output_fixed): New.
13212 * mi/mi-cmds.c (mi_cmds): Register command
13213 -fix-multi-location-breakpoint-output.
13214 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13215 interpreter "mi".
13216
132172019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13218
13219 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13220 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13221 instantiate mi_ui_out based on interpreter name.
13222 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13223 * mi/mi-main.c (mi_load_progress): Likewise.
13224
132252019-03-12 John Baldwin <jhb@FreeBSD.org>
13226
13227 * NEWS: Combine separate "New targets" sections for 8.3.
13228
132292019-03-12 John Baldwin <jhb@FreeBSD.org>
13230
13231 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13232 (ppcfbsd_init_abi): Install gdbarch
13233 "fetch_tls_load_module_address" and "get_thread_local_address"
13234 methods.
13235
132362019-03-12 John Baldwin <jhb@FreeBSD.org>
13237
13238 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13239 (riscv_fbsd_init_abi): Install gdbarch
13240 "fetch_tls_load_module_address" and "get_thread_local_address"
13241 methods.
13242
132432019-03-12 John Baldwin <jhb@FreeBSD.org>
13244
13245 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13246 (i386fbsd_init_abi): Install gdbarch
13247 "fetch_tls_load_module_address" and "get_thread_local_address"
13248 methods.
13249
132502019-03-12 John Baldwin <jhb@FreeBSD.org>
13251
13252 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13253 (amd64fbsd_init_abi): Install gdbarch
13254 "fetch_tls_load_module_address" and "get_thread_local_address"
13255 methods.
13256
132572019-03-12 John Baldwin <jhb@FreeBSD.org>
13258
13259 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13260 (struct fbsd_pspace_data): New type.
13261 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13262 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13263 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13264 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13265 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13266
132672019-03-12 John Baldwin <jhb@FreeBSD.org>
13268
13269 * gdbtypes.c (lookup_struct_elt): New function.
13270 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13271 * gdbtypes.h (struct struct_elt): New type.
13272 (lookup_struct_elt): New prototype.
13273
132742019-03-12 John Baldwin <jhb@FreeBSD.org>
13275
13276 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13277 remove disabled code block.
13278
132792019-03-12 John Baldwin <jhb@FreeBSD.org>
13280
13281 * gdbarch.sh (get_thread_local_address): New method.
13282 * gdbarch.h, gdbarch.c: Regenerate.
13283 * target.c (target_translate_tls_address): Use
13284 gdbarch_get_thread_local_address if present instead of
13285 target::get_thread_local_address.
13286
132872019-03-12 John Baldwin <jhb@FreeBSD.org>
13288
13289 * target.h (target::get_thread_local_address): Update comment.
13290
132912019-03-12 John Baldwin <jhb@FreeBSD.org>
13292
13293 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13294 objfile->separate_debug_objfile_backlink if not NULL.
13295
132962019-03-12 John Baldwin <jhb@FreeBSD.org>
13297
13298 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13299 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13300 (amd64bsd_store_inferior_registers): Likewise.
13301 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13302 Enable segment base registers.
13303 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13304 PT_GETFSBASE and PT_GETGSBASE.
13305 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13306 PT_SETGSBASE.
13307 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13308 segment base registers.
13309 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13310
133112019-03-12 John Baldwin <jhb@FreeBSD.org>
13312
13313 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13314 Update calls to i386_target_description to add 'segments'
13315 parameter.
13316 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13317 add segment base registers.
13318 * arch/i386.c (i386_create_target_description): Add 'segments'
13319 parameter to enable segment base registers.
13320 * arch/i386.h (i386_create_target_description): Likewise.
13321 * features/i386/32bit-segments.xml: New file.
13322 * features/i386/32bit-segments.c: Generate.
13323 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13324 call to i386_target_description to add 'segments' parameter.
13325 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13326 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13327 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13328 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13329 if feature is present.
13330 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13331 Add 'segments' parameter to call to i386_target_description.
13332 (i386_target_description): Add 'segments' parameter to enable
13333 segment base registers.
13334 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13335 to call to i386_target_description.
13336 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13337 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13338 Define I386_NUM_REGS.
13339 (i386_target_description): Add 'segments' parameter to enable
13340 segment base registers.
13341
133422019-03-12 Eli Zaretskii <eliz@gnu.org>
13343
13344 PR/24325
13345 * source-cache.c: #undef open and close, to avoid unresolved
13346 externals during linking.
13347
133482019-03-12 Tom Tromey <tromey@adacore.com>
13349
13350 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13351 const. Add initializers.
13352 (_initialize_remote): Don't initialize ptid globals.
13353
133542019-03-12 Pedro Alves <palves@redhat.com>
13355
13356 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13357
133582019-03-12 Pedro Alves <palves@redhat.com>
13359
13360 * cp-name-parser.y (main): Remove unused 'len' variable.
13361
133622019-03-12 Tom Tromey <tromey@adacore.com>
13363
13364 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13365 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13366
133672019-03-12 Tom Tromey <tromey@adacore.com>
13368
13369 * linux-nat.c (iterate_over_lwps): Update.
13370 (stop_callback): Remove parameter.
13371 (stop_wait_callback, detach_callback, resume_set_callback)
13372 (select_singlestep_lwp_callback, set_ignore_sigint)
13373 (status_callback, resumed_callback, resume_clear_callback)
13374 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13375 data parameter.
13376 (linux_nat_target::detach, linux_nat_target::resume)
13377 (linux_stop_and_wait_all_lwps, select_event_lwp)
13378 (linux_nat_filter_event, linux_nat_wait_1)
13379 (linux_nat_target::kill, linux_nat_target::stop)
13380 (linux_nat_target::stop): Update.
13381 (linux_nat_resume_callback): Change type.
13382 (resume_stopped_resumed_lwps, count_events_callback)
13383 (select_event_lwp_callback): Likewise.
13384 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13385 * arm-linux-nat.c (struct update_registers_data): Remove.
13386 (update_registers_callback): Change type.
13387 (arm_linux_insert_hw_breakpoint1): Update.
13388 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13389 parameter.
13390 (x86_linux_dr_set_addr): Update.
13391 (x86_linux_dr_set_control): Update.
13392 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13393 (iterate_over_lwps): Use gdb::function_view.
13394 * nat/aarch64-linux-hw-point.c (struct
13395 aarch64_dr_update_callback_param): Remove.
13396 (debug_reg_change_callback): Change type.
13397 (aarch64_notify_debug_reg_change): Update.
13398 * s390-linux-nat.c (s390_refresh_per_info): Update.
13399
134002019-03-11 Tom Tromey <tromey@adacore.com>
13401
13402 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13403 redundant assignment to "this_cu".
13404
134052019-03-08 Simon Marchi <simon.marchi@efficios.com>
13406
13407 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13408
134092019-03-08 Simon Marchi <simon.marchi@efficios.com>
13410
13411 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13412 from...
13413 (rank_one_type): ... this.
13414
134152019-03-08 Simon Marchi <simon.marchi@efficios.com>
13416
13417 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13418 from...
13419 (rank_one_type): ... this.
13420
134212019-03-08 Simon Marchi <simon.marchi@efficios.com>
13422
13423 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13424 from...
13425 (rank_one_type): ... this.
13426
134272019-03-08 Simon Marchi <simon.marchi@efficios.com>
13428
13429 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13430 from...
13431 (rank_one_type): ... this.
13432
134332019-03-08 Simon Marchi <simon.marchi@efficios.com>
13434
13435 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13436 from...
13437 (rank_one_type): ... this.
13438
134392019-03-08 Simon Marchi <simon.marchi@efficios.com>
13440
13441 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13442 from...
13443 (rank_one_type): ... this.
13444
134452019-03-08 Simon Marchi <simon.marchi@efficios.com>
13446
13447 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13448 from...
13449 (rank_one_type): ... this.
13450
134512019-03-08 Simon Marchi <simon.marchi@efficios.com>
13452
13453 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13454 from...
13455 (rank_one_type): ... this.
13456
134572019-03-08 Simon Marchi <simon.marchi@efficios.com>
13458
13459 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13460 from...
13461 (rank_one_type): ... this.
13462
134632019-03-08 Simon Marchi <simon.marchi@efficios.com>
13464
13465 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13466 from...
13467 (rank_one_type): ... this.
13468
134692019-03-08 Simon Marchi <simon.marchi@efficios.com>
13470
13471 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13472 from...
13473 (rank_one_type): ... this.
13474
134752019-03-08 Simon Marchi <simon.marchi@efficios.com>
13476
13477 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13478 from...
13479 (rank_one_type): ... this.
13480
134812019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13482
13483 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13484 inferior-events' shows the example events.
13485
134862019-03-08 Eli Zaretskii <eliz@gnu.org>
13487
13488 Support styling on native MS-Windows console
13489
13490 PR/24315
13491 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13492 on MS-Windows if $TERM is not defined.
13493
13494 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13495
13496 * posix-hdep.c (gdb_console_fputs):
13497 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13498 functions.
13499 * ui-file.h (gdb_console_fputs): Add prototype.
13500
13501 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13502 back to fputs only if the former returns zero.
13503
135042019-03-07 Tom Tromey <tom@tromey.com>
13505
13506 * symmisc.c (print_symbol_bcache_statistics): Update.
13507 (print_objfile_statistics): Update.
13508 * symfile.c (allocate_symtab): Update.
13509 * stabsread.c: Don't include bcache.h.
13510 * psymtab.h (struct psymbol_bcache): Don't declare.
13511 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13512 (psymbol_bcache_init, psymbol_bcache_free)
13513 (psymbol_bcache_get_bcache): Don't declare.
13514 * psymtab.c (struct psymbol_bcache): Remove.
13515 (psymtab_storage::psymtab_storage): Update.
13516 (psymtab_storage::~psymtab_storage): Update.
13517 (psymbol_bcache_init, psymbol_bcache_free)
13518 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13519 (add_psymbol_to_bcache): Update.
13520 (allocate_psymtab): Update.
13521 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13522 macro_cache>: No longer pointers.
13523 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13524 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13525 * macrotab.c (macro_bcache): Update.
13526 * macroexp.c: Don't include bcache.h.
13527 * gdbtypes.c (check_types_worklist): Update.
13528 (types_deeply_equal): Remove TRY/CATCH. Update.
13529 * elfread.c (elf_symtab_read): Update.
13530 * dwarf2read.c: Don't include bcache.h.
13531 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13532 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13533 (print_bcache_statistics, bcache_memory_used): Don't declare.
13534 (struct bcache): Move from bcache.c. Add constructor, destructor,
13535 methods. Rename all data members.
13536 * bcache.c (struct bcache): Move to bcache.h.
13537 (bcache::expand_hash_table): Rename from expand_hash_table.
13538 (bcache): Remove.
13539 (bcache::insert): Rename from bcache_full.
13540 (bcache::compare): Rename from bcache_compare.
13541 (bcache_xmalloc): Remove.
13542 (bcache::~bcache): Rename from bcache_xfree.
13543 (bcache::print_statistics): Rename from print_bcache_statistics.
13544 (bcache::memory_used): Rename from bcache_memory_used.
13545
135462019-03-07 Pedro Alves <palves@redhat.com>
13547
13548 * infrun.c (normal_stop): Also check for
13549 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13550
135512019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13552
13553 * f-lang.c (value_from_host_double): Moved to...
13554 * value.c (value_from_host_double): ...here.
13555 * value.h (value_from_host_double): Declare.
13556 * guile/scm-math.c (vlscm_convert_typed_number): Use
13557 value_from_host_double.
13558 (vlscm_convert_number): Likewise.
13559 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13560 * python/py-value.c (convert_value_from_python): Likewise.
13561
135622019-03-06 Tom Tromey <tom@tromey.com>
13563
13564 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13565
135662019-03-06 Tom Tromey <tom@tromey.com>
13567
13568 * utils.h (free_current_contents): Don't declare.
13569 * utils.c (free_current_contents): Remove.
13570
135712019-03-06 Tom Tromey <tom@tromey.com>
13572
13573 * top.c (quit_force): Update.
13574 * main.c (captured_command_loop): Update.
13575 * common/new-op.c (operator new): Update.
13576 * common/common-exceptions.c (struct catcher)
13577 <save_cleanup_chain>: Remove member.
13578 (exceptions_state_mc_init): Update.
13579 (exception_try_scope_entry): Return nullptr.
13580 (exception_try_scope_exit, exception_rethrow)
13581 (throw_exception_sjlj, throw_exception_cxx): Update.
13582 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13583 (all_cleanups, do_cleanups, discard_cleanups)
13584 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13585 (restore_cleanups, restore_final_cleanups): Don't declare.
13586 (do_final_cleanups): Remove parameter.
13587 * common/cleanups.c (cleanup_chain, make_cleanup)
13588 (make_cleanup_dtor, all_cleanups, do_cleanups)
13589 (discard_my_cleanups, discard_cleanups)
13590 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13591 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13592 (null_cleanup): Remove.
13593 (do_final_cleanups): Remove parameter.
13594
135952019-03-06 Tom Tromey <tom@tromey.com>
13596
13597 * remote.c (remote_target::remote_parse_stop_reply): Use
13598 unique_xmalloc_ptr.
13599
136002019-03-06 Tom Tromey <tom@tromey.com>
13601
13602 * stabsread.c (struct stabs_field_info): Rename from field_info.
13603 <list, fnlist>: Add initializers.
13604 <obstack>: New member.
13605 (read_member_functions, read_struct_fields, read_baseclasses):
13606 Allocate on obstack. Don't use cleanups.
13607 (read_one_struct_field, read_member_functions, read_struct_fields)
13608 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13609 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13610 (read_struct_type): Update.
13611
136122019-03-06 Tom Tromey <tom@tromey.com>
13613
13614 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13615 * common/filestuff.h (make_cleanup_close): Don't declare.
13616 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13617 Remove.
13618
136192019-03-06 Tom Tromey <tom@tromey.com>
13620
13621 * solib-aix.c: Use make_scope_exit.
13622
136232019-03-06 Tom Tromey <tom@tromey.com>
13624
13625 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13626 Use make_scope_exit.
13627
136282019-03-06 Tom Tromey <tom@tromey.com>
13629
13630 * solib-svr4.c (disable_probes_interface): Remove parameter.
13631 (svr4_handle_solib_event): Use make_scope_exit.
13632
136332019-03-06 Tom Tromey <tom@tromey.com>
13634
13635 * remote.c (struct stop_reply_deleter): Remove.
13636 (stop_reply_up): Update.
13637 (struct stop_reply): Derive from notif_event. Don't typedef.
13638 <regcache>: Now a std::vector.
13639 (stop_reply_xfree): Remove.
13640 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13641 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13642 (remote_target::discard_pending_stop_replies): Use delete.
13643 (remote_target::remote_parse_stop_reply): Update.
13644 (remote_target::process_stop_reply): Update.
13645 * remote-notif.h (struct notif_event): Add virtual destructor.
13646 Remove "dtr" member.
13647 (struct notif_client) <alloc_event>: Return a unique_ptr.
13648 (notif_event_xfree): Don't declare.
13649 (notif_event_up): New typedef.
13650 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13651 (notif_event_xfree, do_notif_event_xfree): Remove.
13652 (remote_notif_state_xfree): Update.
13653
136542019-03-06 Tom Tromey <tom@tromey.com>
13655
13656 * infrun.c (displaced_step_clear_cleanup): Now a
13657 forward_scope_exit type.
13658 (displaced_step_prepare_throw): Update.
13659 (displaced_step_fixup): Update.
13660
136612019-03-06 Tom Tromey <tom@tromey.com>
13662
13663 * inferior.h (class inferior): Update comment.
13664 * gdbthread.h (class thread_info): Update comment.
13665
136662019-03-06 Joel Brobecker <brobecker@adacore.com>
13667 Tom Tromey <tom@tromey.com>
13668
13669 * stabsread.h (struct stab_section_list): Remove.
13670 (coffstab_build_psymtabs): Update.
13671 * dbxread.c (symbuf_sections): Now a std::vector.
13672 (sect_idx): New global.
13673 (fill_symbuf): Update.
13674 (coffstab_build_psymtabs): Change type of stabsects parameter.
13675 Update.
13676 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13677 std::vector.
13678 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13679 (coff_locate_sections): Update.
13680 (coff_symfile_read): Remove cleanups. Update.
13681 (init_stringtab): Add storage parameter.
13682 (free_stringtab, free_stringtab_cleanup): Remove.
13683 (init_lineno): Add storage parameter.
13684 (free_linetab, free_linetab_cleanup): Remove.
13685
136862019-03-06 Pedro Alves <palves@redhat.com>
13687
13688 * linux-fork.c (fork_info::clobber_regs): Delete.
13689 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13690 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13691 comment. Adjust.
13692 (scoped_switch_fork_info::scoped_switch_fork_info)
13693 (checkpoint_command, linux_fork_context): Adjust
13694 fork_save_infrun_state calls.
13695
136962019-03-06 Pedro Alves <palves@redhat.com>
13697
13698 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13699 (inf_has_multiple_threads): Return 'bool' and rewrite using
13700 inferior_info::threads().
13701
137022019-03-06 Pedro Alves <palves@redhat.com>
13703
13704 * linux-fork.c: Include <list>.
13705 (fork_list): Now a std::list instance.
13706 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13707 (forks_exist_p, find_last_fork): Adjust.
13708 (new_fork): Delete.
13709 (one_fork_p): New.
13710 (add_fork): Adjust.
13711 (free_fork): Delete, folded into fork_info::~fork_info().
13712 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13713 Adjust.
13714 (init_fork_list): Delete.
13715 (linux_fork_killall, linux_fork_mourn_inferior)
13716 (linux_fork_detach, info_checkpoints_command): Adjust.
13717 (_initialize_linux_fork): No longer call init_fork_list.
13718
137192019-03-06 Pedro Alves <palves@redhat.com>
13720
13721 * linux-fork.c (new_fork): New, split out of ...
13722 (add_fork): ... this. Return void. Move "first fork" special
13723 case from here, to ...
13724 (checkpoint_command): ... here.
13725 * linux-linux.h (add_fork): Return void.
13726
137272019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13728
13729 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13730
137312019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13732 Chris January <chris.january@arm.com>
13733 David Lecomber <david.lecomber@arm.com>
13734
13735 * f-exp.y: New token, UNOP_INTRINSIC.
13736 (exp): New pattern using UNOP_INTRINSIC token.
13737 (f77_keywords): Add 'abs' keyword.
13738 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13739 (value_from_host_double): New function.
13740 (evaluate_subexp_f): Support UNOP_ABS.
13741
137422019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13743
13744 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13745 types.
13746
137472019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13748
13749 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13750 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13751 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13752
137532019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13754
13755 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13756
137572019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13758 Chris January <chris.january@arm.com>
13759
13760 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13761 * f-exp.y: Define 'KIND' token.
13762 (exp): New pattern for KIND expressions.
13763 (ptype): Handle types with a kind extension.
13764 (direct_abs_decl): Extend to spot kind extensions.
13765 (f77_keywords): Add 'kind' to the list.
13766 (push_kind_type): New function.
13767 (convert_to_kind_type): New function.
13768 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13769 * parse.c (operator_length_standard): Likewise.
13770 * parser-defs.h (enum type_pieces): Add tp_kind.
13771 * std-operator.def: Add UNOP_KIND.
13772
137732019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13774
13775 * f-exp.y (f_parse): Set yydebug.
13776
137772019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13778
13779 * f-lang.c (evaluate_subexp_f): New function.
13780 (exp_descriptor_f): New global.
13781 (f_language_defn): Use exp_descriptor_f instead of
13782 exp_descriptor_standard.
13783
137842019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13785
13786 * f-exp.y (struct token): Add comments.
13787 (dot_ops): Remove uppercase versions and the end marker.
13788 (f77_keywords): Likewise.
13789 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13790 entries in the dot_ops array are case insensitive, and use
13791 strncasecmp to compare strings. Also some whitespace cleanup in
13792 this area. Similar for the f77_keywords array, except entries in
13793 this list might be case sensitive.
13794
137952019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13796
13797 * f-exp.y (struct f77_boolean_val): Add comments.
13798 (boolean_values): Remove uppercase versions, and end marker.
13799 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13800 and use strncasecmp to achieve case insensitivity. Additionally,
13801 perform whitespace cleanup around this code.
13802
138032019-03-06 Tom Tromey <tromey@adacore.com>
13804
13805 * remote-sim.c (gdbsim_target_open): Use result of
13806 gdb_argv::release.
13807
138082019-03-06 Richard Bunt <richard.bunt@arm.com>
13809 Dirk Schubert <dirk.schubert@arm.com>
13810 Chris January <chris.january@arm.com>
13811
13812 * eval.c (evaluate_subexp_standard): Call Fortran argument
13813 wrapping logic.
13814 * f-lang.c (struct value): A value which can be passed into a
13815 Fortran function call.
13816 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13817 where appropriate.
13818 (struct type): Value ready for a Fortran function call.
13819 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13820 is needed.
13821 * f-lang.h (fortran_argument_convert): Declaration.
13822 (fortran_preserve_arg_pointer): Declaration.
13823 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13824
138252019-03-05 Tom Tromey <tromey@adacore.com>
13826
13827 * python/py-prettyprint.c (print_string_repr): Remove #if.
13828 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13829
138302019-03-05 Tom Tromey <tromey@adacore.com>
13831
13832 * target.c (the_dummy_target): Move later. Change type to
13833 "dummy_target".
13834 (initialize_targets): Don't initialize the_dummy_target.
13835
138362019-03-05 Tom Tromey <tromey@adacore.com>
13837
13838 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13839 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13840
138412019-03-05 Tom Tromey <tromey@adacore.com>
13842
13843 * windows-nat.c (windows_nat_target::attach)
13844 (windows_nat_target::detach): Don't call gdb_flush.
13845 * valprint.c (generic_val_print, val_print, val_print_string):
13846 Don't call gdb_flush.
13847 * utils.c (defaulted_query): Don't call gdb_flush.
13848 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13849 * target.c (target_announce_detach): Don't call gdb_flush.
13850 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13851 * remote.c (extended_remote_target::attach): Don't call
13852 gdb_flush.
13853 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13854 * printcmd.c (do_examine): Don't call gdb_flush.
13855 (info_display_command): Don't call gdb_flush.
13856 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13857 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13858 * memattr.c (info_mem_command): Don't call gdb_flush.
13859 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13860 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13861 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13862 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13863 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13864 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13865 (gnu_nat_target::detach): Don't call gdb_flush.
13866 * f-valprint.c (f_val_print): Don't call gdb_flush.
13867 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13868 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13869 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13870 gdb_flush.
13871 * c-valprint.c (c_val_print): Don't call gdb_flush.
13872 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13873
138742019-03-05 Tom Tromey <tromey@adacore.com>
13875
13876 * varobj.c (update_dynamic_varobj_children): Update.
13877 (install_default_visualizer): Use reset, not release.
13878 * value.c (set_internalvar): Update.
13879 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13880 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13881 ATTRIBUTE_UNUSED_RESULT.
13882
138832019-03-05 Tom Tromey <tromey@adacore.com>
13884
13885 * remote.c (class scoped_remote_fd) <release>: Add
13886 ATTRIBUTE_UNUSED_RESULT.
13887
138882019-03-05 Tom Tromey <tromey@adacore.com>
13889
13890 * macroexp.c (struct macro_buffer) <release>: Add
13891 ATTRIBUTE_UNUSED_RESULT.
13892
138932019-03-05 Tom Tromey <tromey@adacore.com>
13894
13895 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13896 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13897 ATTRIBUTE_UNUSED_RESULT.
13898
138992019-03-05 Tom Tromey <tromey@adacore.com>
13900
13901 * common/scoped_fd.h (class scoped_fd) <release>: Add
13902 ATTRIBUTE_UNUSED_RESULT.
13903
139042019-03-05 Tom Tromey <tromey@adacore.com>
13905
13906 * parser-defs.h (struct parser_state) <release>: Add
13907 ATTRIBUTE_UNUSED_RESULT.
13908
139092019-03-05 Tom Tromey <tromey@adacore.com>
13910
13911 * utils.h (class gdb_argv) <release>: Add
13912 ATTRIBUTE_UNUSED_RESULT.
13913 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13914
139152019-03-02 Eli Zaretskii <eliz@gnu.org>
13916
13917 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13918 for-loop range, to avoid compiler warnings.
13919
13920 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13921 avoid compiler warnings about unused variables.
13922
13923 * NEWS: Mention end of support for native debugging on MS-Windows
13924 before XP.
13925
13926 PR gdb/24292
13927 * common/netstuff.c:
13928 * gdbserver/gdbreplay.c
13929 * gdbserver/remote-utils.c:
13930 * ser-tcp.c:
13931 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13932 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13933 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13934 'getaddrinfo' and 'freeaddrinfo' were not available before
13935 Windows XP, and mingw.org's MinGW headers by default define
13936 _WIN32_WINNT to 0x500.
13937
139382019-03-01 Gary Benson <gbenson@redhat.com>
13939
13940 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13941
139422019-02-28 Brian Vandenberg <phantall@gmail.com>
13943 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13944
13945 PR gdb/8527
13946 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13947 set_sigint_trap, clear_sigint_trap.
13948
139492019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13950
13951 * target.c (target_detach): Clear the regcache and the
13952 frame cache.
13953
139542019-02-27 Pedro Alves <palves@redhat.com>
13955
13956 * utils.c (set_screen_size): When we cap the height/width sizes,
13957 tweak the corresponding command variable to show "unlimited":
13958
139592019-02-27 Saagar Jha <saagar@saagarjha.com>
13960 Pedro Alves <palves@redhat.com>
13961
13962 * utils.c (set_screen_size): Reduce "infinite" rows and columns
13963 before calling rl_set_screen_size.
13964
139652019-02-27 Tom Tromey <tromey@adacore.com>
13966
13967 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13968 define.
13969 * python/py-value.c: Remove Python 2.4 workaround.
13970 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13971 workaround.
13972 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13973 Python 2.4 workaround.
13974 * python/python-internal.h: Remove Python 2.4 comment.
13975 (Py_ssize_t): Don't define.
13976 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13977 (gdb_Py_DECREF): Remove Python 2.4 workaround.
13978 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13979 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13980 * python/python.c (do_start_initialization): Remove Python 2.4
13981 workaround.
13982 * python/py-prettyprint.c (class dummy_python_frame): Remove.
13983 (print_children): Remove Python 2.4 workaround.
13984 * python/py-inferior.c (buffer_procs): Remove Python 2.4
13985 workaround.
13986 (CHARBUFFERPROC_NAME): Remove.
13987 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13988 Python 2.4 workaround.
13989
139902019-02-27 Kevin Buettner <kevinb@redhat.com>
13991
13992 * NEWS: Note minimum Python version.
13993
139942019-02-27 Kevin Buettner <kevinb@redhat.com>
13995
13996 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13997 code from these functions. Remove corresponding ifdefs. Use
13998 Py_buffer_up instead of explicit calls to PyBuffer_Release.
13999 Remove gotos and target of gotos.
14000 (infpy_search_memory): Likewise.
14001
140022019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14003
14004 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14005 (hppa_gdbarch_init): Don't register deleted functions with
14006 gdbarch.
14007
140082019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14009
14010 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14011 (h8300_unwind_sp): Delete.
14012 (h8300_dummy_id): Delete.
14013 (h8300_gdbarch_init): Don't register deleted functions with
14014 gdbarch.
14015
140162019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14017
14018 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14019 (ft32_unwind_pc): Delete.
14020 (ft32_unwind_sp): Delete.
14021 (ft32_gdbarch_init): Don't register deleted functions with
14022 gdbarch.
14023
140242019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14025
14026 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14027 (frv_unwind_pc): Delete.
14028 (frv_unwind_sp): Delete.
14029 (frv_gdbarch_init): Don't register deleted functions with
14030 gdbarch.
14031
140322019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14033
14034 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14035 (riscv_unwind_pc): Delete.
14036 (riscv_unwind_sp): Delete.
14037 (riscv_gdbarch_init): Don't register deleted functions with
14038 gdbarch.
14039
140402019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14041
14042 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14043 (csky_unwind_pc): Delete.
14044 (csky_unwind_sp): Delete.
14045 (csky_gdbarch_init): Don't register deleted functions with
14046 gdbarch.
14047
140482019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14049
14050 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14051 (cris_unwind_pc): Delete.
14052 (cris_unwind_sp): Delete.
14053 (cris_gdbarch_init): Don't register deleted functions with
14054 gdbarch.
14055
140562019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14057
14058 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14059 (bfin_unwind_pc): Delete.
14060 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14061
140622019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14063
14064 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14065 (arm_unwind_pc): Delete.
14066 (arm_unwind_sp): Delete.
14067 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14068
140692019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14070
14071 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14072 (arc_unwind_pc): Delete.
14073 (arc_unwind_sp): Delete.
14074 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14075
140762019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14077
14078 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14079 (alpha_unwind_pc): Delete.
14080 (alpha_gdbarch_init): Don't register deleted functions with
14081 gdbarch.
14082
140832019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14084
14085 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14086 (aarch64_unwind_pc): Delete.
14087 (aarch64_unwind_sp): Delete.
14088 (aarch64_gdbarch_init): Don't register deleted functions with
14089 gdbarch.
14090
140912019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14092
14093 * gdbtypes.c (type_align): Don't consider static members when
14094 computing structure alignment.
14095
140962019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14097
14098 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14099 return 0 for other types.
14100 * arch-utils.c (default_type_align): Always return 0.
14101 * gdbarch.h: Regenerate.
14102 * gdbarch.sh (type_align): Extend comment.
14103 * gdbtypes.c (type_align): Add additional comments, always call
14104 gdbarch_type_align before applying the default rules.
14105 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14106 generic code will then apply a suitable default.
14107 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14108 types, return 0 for other types.
14109
141102019-02-27 Joel Brobecker <brobecker@adacore.com>
14111
14112 * NEWS: Create a new section for the next release branch.
14113 Rename the section of the current branch, now that it has
14114 been cut.
14115
141162019-02-27 Joel Brobecker <brobecker@adacore.com>
14117
14118 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14119 * version.in: Bump version to 8.3.50.DATE-git.
14120
141212019-02-26 Simon Marchi <simon.marchi@efficios.com>
14122
14123 * aix-thread.c (ptid_cmp): Remove unused variable.
14124 (get_signaled_thread): Likewise.
14125 (store_regs_user_thread): Likewise.
14126 (store_regs_kernel_thread): Likewise.
14127 (fetch_regs_kernel_thread): Remove shadowed variable.
14128
141292019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14130
14131 * features/riscv/32bit-cpu.xml: Add register numbers.
14132 * features/riscv/32bit-fpu.c: Regenerate.
14133 * features/riscv/32bit-fpu.xml: Add register numbers.
14134 * features/riscv/64bit-cpu.xml: Add register numbers.
14135 * features/riscv/64bit-fpu.c: Regenerate.
14136 * features/riscv/64bit-fpu.xml: Add register numbers.
14137
141382019-02-26 Kevin Buettner <kevinb@redhat.com>
14139
14140 * NEWS: Mention two argument form of gdb.Value constructor.
14141 * python/py-value.c (convert_buffer_and_type_to_value): New
14142 function.
14143 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14144 Add support for handling an optional second argument. Call
14145 convert_buffer_and_type_to_value as appropriate.
14146 * python/python-internal.h (Py_buffer_deleter): New struct.
14147 (Py_buffer_up): New typedef.
14148
141492019-02-25 John Baldwin <jhb@FreeBSD.org>
14150
14151 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14152 instead of releasing ownership.
14153
141542019-02-25 Jordan Rupprecht <rupprecht@google.com>
14155
14156 * dwarf2read.c (open_and_init_dwp_file): Call
14157 elf_numsections instead of bfd_count_sections to initialize
14158 dwp_file->num_sections.
14159
141602019-02-25 Tom Tromey <tromey@adacore.com>
14161
14162 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14163
141642019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14165
14166 * gcore.in: Add '--readnever' option when invoking GDB.
14167
141682019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14169
14170 * MAINTAINERS: Update my email address.
14171
141722019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14173
14174 * build-id.c (build_id_to_debug_bfd_1): New function.
14175 (build_id_to_debug_bfd): Look for separate debug file in
14176 sysroot.
14177
141782019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14179
14180 * gdbarch.sh: Update the copyright year range that is placed into
14181 generated files.
14182
141832019-02-22 Keith Seitz <keiths@redhat.com>
14184
14185 PR symtab/23853
14186 * linespec.c (create_sals_line_offset): Search for the default
14187 symtab's filename instead of its fullname.
14188
141892019-02-21 Alan Hayward <alan.hayward@arm.com>
14190
14191 * NEWS: Update style defaults.
14192
141932019-02-21 Alan Hayward <alan.hayward@arm.com>
14194
14195 * main.c (captured_main_1): Disable styling in batch mode.
14196
141972019-02-20 Tom Tromey <tom@tromey.com>
14198
14199 * symtab.c (symtab_symbol_info): Fix typos.
14200
142012019-02-20 Tom Tromey <tromey@adacore.com>
14202
14203 * findcmd.c (_initialize_mem_search): Use upper case for
14204 metasyntactic variables.
14205
142062019-02-20 Alan Hayward <alan.hayward@arm.com>
14207
14208 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14209 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14210
142112019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14212
14213 * top.h (source_file_name): Change to std::string.
14214 * top.c (source_file_name): Likewise.
14215 (command_line_input): Adjust.
14216 * cli/cli-script.c (script_from_file): Adjust.
14217
142182019-02-19 Tom Tromey <tromey@adacore.com>
14219
14220 * ravenscar-thread.c
14221 (ravenscar_thread_target::update_thread_list): Don't call
14222 ada_build_task_list.
14223 * ada-lang.h (ada_build_task_list): Don't declare.
14224 * ada-tasks.c (struct ada_tasks_inferior_data)
14225 <task_list_valid_p>: Now bool.
14226 (read_known_tasks, ada_task_list_changed)
14227 (ada_tasks_invalidate_inferior_data): Update.
14228 (read_known_tasks_array): Return bool.
14229 (read_known_tasks_list): Likewise.
14230 (read_known_tasks): Return void.
14231 (ada_build_task_list): Now static.
14232
142332019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14234
14235 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14236 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14237
142382019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14239
14240 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14241 variant for ada_tasks_pspace_data_handle and
14242 ada_tasks_inferior_data_handle.
14243 (ada_tasks_pspace_data_cleanup): New function.
14244 (ada_tasks_inferior_data_cleanup): New function.
14245
142462019-02-17 Tom Tromey <tom@tromey.com>
14247
14248 * macrotab.h (macro_source_fullname): Return a std::string.
14249 * macrotab.c (macro_include, check_for_redefinition)
14250 (macro_undef, macro_lookup_definition, foreach_macro)
14251 (foreach_macro_in_scope): Update.
14252 (macro_source_fullname): Return a std::string.
14253 * macrocmd.c (show_pp_source_pos): Update.
14254
142552019-02-17 Tom Tromey <tom@tromey.com>
14256
14257 * macrocmd.c (show_pp_source_pos): Style the file names.
14258
142592019-02-17 Tom Tromey <tom@tromey.com>
14260
14261 PR tui/24197:
14262 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14263
142642019-02-17 Tom Tromey <tom@tromey.com>
14265
14266 * ada-lang.c (user_select_syms): Use filtered printing.
14267 * utils.c (wrap_style): New global.
14268 (desired_style): Remove.
14269 (emit_style_escape): Add stream parameter.
14270 (set_output_style, reset_terminal_style, prompt_for_continue):
14271 Update.
14272 (flush_wrap_buffer): Only flush gdb_stdout.
14273 (wrap_here): Set wrap_style.
14274 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14275 treat escape sequences as a character. Change when wrap buffer is
14276 flushed.
14277 (fputs_styled): Do not set the output style when the default is
14278 requested.
14279 * ui-style.h (struct ui_file_style) <is_default>: New method.
14280 * source.c (print_source_lines_base): Emit escape sequences in one
14281 piece.
14282
142832019-02-17 Joel Brobecker <brobecker@adacore.com>
14284
14285 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14286 integers and enumeration types.
14287
142882019-02-17 Joel Brobecker <brobecker@adacore.com>
14289
14290 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14291 instead of lookup_symbol_in_language
14292 (do_exact_match): New function.
14293 (ada_get_symbol_name_matcher): Return do_exact_match when
14294 doing a verbatim match.
14295
142962019-02-15 Tom Tromey <tromey@adacore.com>
14297
14298 * ravenscar-thread.c (ravenscar_thread_target::resume)
14299 (ravenscar_thread_target::wait): Special case wildcard requests.
14300
143012019-02-15 Tom Tromey <tromey@adacore.com>
14302
14303 * ravenscar-thread.c (base_ptid): Remove.
14304 (struct ravenscar_thread_target) <close>: New method.
14305 <m_base_ptid>: New member.
14306 <update_inferior_ptid, active_task, task_is_currently_active,
14307 runtime_initialized>: Declare methods.
14308 <ravenscar_thread_target>: Add constructor.
14309 (ravenscar_thread_target::task_is_currently_active)
14310 (ravenscar_thread_target::update_inferior_ptid)
14311 (ravenscar_runtime_initialized): Rename. Now methods.
14312 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14313 (ravenscar_thread_target::update_thread_list): Update.
14314 (ravenscar_thread_target::active_task): Now method.
14315 (ravenscar_thread_target::store_registers)
14316 (ravenscar_thread_target::prepare_to_store)
14317 (ravenscar_thread_target::prepare_to_store)
14318 (ravenscar_thread_target::mourn_inferior): Update.
14319 (ravenscar_inferior_created): Use "new" to create target.
14320 (ravenscar_thread_target::get_ada_task_ptid): Update.
14321 (_initialize_ravenscar): Don't initialize base_ptid.
14322 (ravenscar_ops): Remove global.
14323
143242019-02-15 Tom Tromey <tromey@adacore.com>
14325
14326 * target.h (push_target): Declare new overload.
14327 * target.c (push_target): New overload, taking an rvalue reference.
14328 * remote.c (remote_target::open_1): Use push_target overload.
14329 * corelow.c (core_target_open): Use push_target overload.
14330
143312019-02-15 Tom Tromey <tromey@adacore.com>
14332
14333 * ravenscar-thread.c (is_ravenscar_task)
14334 (ravenscar_task_is_currently_active): Return bool.
14335 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14336 (_initialize_ravenscar): Remove "(void)".
14337 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14338 Return bool.
14339
143402019-02-15 Tom Tromey <tromey@adacore.com>
14341
14342 * ravenscar-thread.c (ravenscar_runtime_initializer)
14343 (has_ravenscar_runtime, get_running_thread_id)
14344 (ravenscar_thread_target::resume): Fix indentation.
14345
143462019-02-15 Tom Tromey <tromey@adacore.com>
14347
14348 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14349 from ravenscar_arch_ops.
14350 (sparc_ravenscar_ops::fetch_registers)
14351 (sparc_ravenscar_ops::store_registers): Now methods.
14352 (sparc_ravenscar_prepare_to_store): Remove.
14353 (sparc_ravenscar_ops): Redefine.
14354 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14355 methods and destructor. Remove members.
14356 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14357 (ravenscar_thread_target::store_registers)
14358 (ravenscar_thread_target::prepare_to_store): Update.
14359 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14360 Remove.
14361 (struct ppc_ravenscar_powerpc_ops): Derive from
14362 ravenscar_arch_ops.
14363 (ppc_ravenscar_powerpc_ops::fetch_registers)
14364 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14365 (ppc_ravenscar_powerpc_ops): Redefine.
14366 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14367 (ppc_ravenscar_e500_ops::fetch_registers)
14368 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14369 (ppc_ravenscar_e500_ops): Redefine.
14370 * aarch64-ravenscar-thread.c
14371 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14372 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14373 (aarch64_ravenscar_fetch_registers)
14374 (aarch64_ravenscar_store_registers): Now methods.
14375 (aarch64_ravenscar_ops): Redefine.
14376
143772019-02-15 Tom Tromey <tromey@adacore.com>
14378
14379 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14380 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14381 (ravenscar_thread_target::stopped_by_watchpoint)
14382 (ravenscar_thread_target::stopped_data_address)
14383 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14384
143852019-02-15 Tom Tromey <tromey@adacore.com>
14386
14387 * ravenscar-thread.c: Fix some typos.
14388
143892019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14390 Tom Tromey <tromey@adacore.com>
14391
14392 * ada-lang.c (ada_exception_sal): Change addr_string to a
14393 std::string.
14394 (create_ada_exception_catchpoint): Update.
14395
143962019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14397 Tom Tromey <tromey@adacore.com>
14398
14399 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14400 (bp_location_ops): Remove.
14401 (base_breakpoint_allocate_location): Update.
14402 (free_bp_location): Update.
14403 * ada-lang.c (class ada_catchpoint_location)
14404 <ada_catchpoint_location>: Remove ops parameter.
14405 (ada_catchpoint_location_dtor): Remove.
14406 (ada_catchpoint_location_ops): Remove.
14407 (allocate_location_exception): Update.
14408 * breakpoint.h (struct bp_location_ops): Remove.
14409 (class bp_location) <bp_location>: Remove bp_location_ops
14410 parameter.
14411 <~bp_location>: Add destructor.
14412 <ops>: Remove.
14413
144142019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14415 Pedro Alves <palves@redhat.com>
14416
14417 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14418 'PATH_MAX'.
14419
144202019-02-14 David Michael <fedora.dm0@gmail.com>
14421 Samuel Thibault <samuel.thibault@gnu.org>
14422 Thomas Schwinge <thomas@codesourcery.com>
14423
14424 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14425 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14426
144272019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14428
14429 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14430 (check_empty): Use "const char *".
14431
14432 * gnu-nat.c (gnu_nat_target::detach): Instead of
14433 'detach_inferior (pid)' call
14434 'detach_inferior (find_inferior_pid (pid))'.
14435
14436 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14437 'nat/fork-inferior.o'.
14438 * gnu-nat.c: #include "nat/fork-inferior.h".
14439
14440 * gnu-nat.c (gnu_nat_target::detach): Instead of
14441 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14442 * gnu-nat.h: #include "inf-child.h".
14443 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14444 'i386_gnu_nat_target::fetch_registers'.
14445 (gnu_store_registers): Rename/move to
14446 'i386_gnu_nat_target::store_registers'.
14447
14448 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14449 * gnu-nat.h (mach_thread_info): New function.
14450 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14451
14452 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14453
144542019-02-14 Frederic Konrad <konrad@adacore.com>
14455
14456 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14457
144582019-02-14 Joel Brobecker <brobecker@adacore.com>
14459
14460 * windows-nat.c (windows_add_thread): Add new parameter
14461 "main_thread_p" with default value set to false. Update
14462 function documentation as well as all callers.
14463 (windows_delete_thread): Likewise.
14464 (fake_create_process): Update call to windows_add_thread.
14465 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14466 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14467 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14468 call to windows_delete_thread.
14469
144702019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14471
14472 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14473
144742019-02-12 John Baldwin <jhb@FreeBSD.org>
14475
14476 * symfile.c (find_separate_debug_file): Use canonical path of
14477 sysroot with child_path instead of gdb_sysroot if it is valid.
14478
144792019-02-12 John Baldwin <jhb@FreeBSD.org>
14480
14481 * symfile.c (find_separate_debug_file): Use child_path to
14482 determine if an object file is under a sysroot.
14483
144842019-02-12 John Baldwin <jhb@FreeBSD.org>
14485
14486 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14487 unittests/child-path-selftests.c.
14488 * common/pathstuff.c (child_path): New function.
14489 * common/pathstuff.h (child_path): New prototype.
14490 * unittests/child-path-selftests.c: New file.
14491
144922019-02-12 John Baldwin <jhb@FreeBSD.org>
14493
14494 * symfile.c (find_separate_debug_file): Look for separate debug
14495 files in debug directories under the sysroot.
14496
144972019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14498
14499 * symtab.h (struct minimal_symbol data_p): New const method.
14500 (struct minimal_symbol text_p): Likewise.
14501 * symtab.c (output_source_filename): Use file name style
14502 to print file name.
14503 (print_symbol_info): Likewise.
14504 (print_msymbol_info): Use address style to print addresses.
14505 Use function name style to print executable text symbols.
14506 (expand_symtab_containing_pc): Use data_p.
14507 (find_pc_sect_compunit_symtab): Likewise.
14508
145092019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14510
14511 * breakpoint.c (describe_other_breakpoints): Use address style
14512 to print addresses.
14513 (say_where): Likewise.
14514
145152019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14516
14517 * ada-typeprint.c (print_func_type): Print function name
14518 style to print function name.
14519 * c-typeprint.c (c_print_type_1): Likewise.
14520
145212019-02-11 Alan Hayward <alan.hayward@arm.com>
14522
14523 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14524 for execve.
14525
145262019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14527
14528 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14529 type_stack.
14530
145312019-02-10 Joel Brobecker <brobecker@adacore.com>
14532
14533 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14534 TYPE_CODE_REF types.
14535
145362019-02-08 Jim Wilson <jimw@sifive.com>
14537
14538 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14539 (riscv_linux_fregset): New.
14540 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14541
145422019-02-07 Tom Tromey <tom@tromey.com>
14543
14544 * thread.c (thread_cancel_execution_command): Update.
14545 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14546 methods.
14547 (struct thread_fsm_ops): Remove.
14548 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14549 (thread_fsm_should_stop, thread_fsm_return_value)
14550 (thread_fsm_set_finished, thread_fsm_finished_p)
14551 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14552 Don't declare.
14553 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14554 * infrun.c (clear_proceed_status_thread)
14555 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14556 (print_stop_event): Update.
14557 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14558 Add constructor.
14559 (step_command_fsm_ops): Remove.
14560 (new_step_command_fsm): Remove.
14561 (step_1): Update.
14562 (step_command_fsm::should_stop): Rename from
14563 step_command_fsm_should_stop.
14564 (step_command_fsm::clean_up): Rename from
14565 step_command_fsm_clean_up.
14566 (step_command_fsm::do_async_reply_reason): Rename from
14567 step_command_fsm_async_reply_reason.
14568 (struct until_next_fsm): Inherit from thread_fsm. Add
14569 constructor.
14570 (until_next_fsm_ops): Remove.
14571 (new_until_next_fsm): Remove.
14572 (until_next_fsm::should_stop): Rename from
14573 until_next_fsm_should_stop.
14574 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14575 (until_next_fsm::do_async_reply_reason): Rename from
14576 until_next_fsm_async_reply_reason.
14577 (struct finish_command_fsm): Inherit from thread_fsm. Add
14578 constructor. Change type of breakpoint.
14579 (finish_command_fsm_ops): Remove.
14580 (new_finish_command_fsm): Remove.
14581 (finish_command_fsm::should_stop): Rename from
14582 finish_command_fsm_should_stop.
14583 (finish_command_fsm::clean_up): Rename from
14584 finish_command_fsm_clean_up.
14585 (finish_command_fsm::return_value): Rename from
14586 finish_command_fsm_return_value.
14587 (finish_command_fsm::do_async_reply_reason): Rename from
14588 finish_command_fsm_async_reply_reason.
14589 (finish_command): Update.
14590 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14591 Add constructor.
14592 (call_thread_fsm_ops): Remove.
14593 (call_thread_fsm::call_thread_fsm): Rename from
14594 new_call_thread_fsm.
14595 (call_thread_fsm::should_stop): Rename from
14596 call_thread_fsm_should_stop.
14597 (call_thread_fsm::should_notify_stop): Rename from
14598 call_thread_fsm_should_notify_stop.
14599 (run_inferior_call, call_function_by_hand_dummy): Update.
14600 * cli/cli-interp.c (should_print_stop_to_console): Update.
14601 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14602 Add constructor. Change type of location_breakpoint,
14603 caller_breakpoint.
14604 (until_break_fsm_ops): Remove.
14605 (new_until_break_fsm): Remove.
14606 (until_break_fsm::should_stop): Rename from
14607 until_break_fsm_should_stop.
14608 (until_break_fsm::clean_up): Rename from
14609 until_break_fsm_clean_up.
14610 (until_break_fsm::do_async_reply_reason): Rename from
14611 until_break_fsm_async_reply_reason.
14612 (until_break_command): Update.
14613 * thread-fsm.c: Remove.
14614 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14615
146162019-02-07 Tom Tromey <tom@tromey.com>
14617
14618 * yy-remap.h: Add include guard.
14619 * xtensa-tdep.h: Add include guard.
14620 * xcoffread.h: Rename include guard.
14621 * varobj-iter.h: Add include guard.
14622 * tui/tui.h: Rename include guard.
14623 * tui/tui-winsource.h: Rename include guard.
14624 * tui/tui-wingeneral.h: Rename include guard.
14625 * tui/tui-windata.h: Rename include guard.
14626 * tui/tui-win.h: Rename include guard.
14627 * tui/tui-stack.h: Rename include guard.
14628 * tui/tui-source.h: Rename include guard.
14629 * tui/tui-regs.h: Rename include guard.
14630 * tui/tui-out.h: Rename include guard.
14631 * tui/tui-layout.h: Rename include guard.
14632 * tui/tui-io.h: Rename include guard.
14633 * tui/tui-hooks.h: Rename include guard.
14634 * tui/tui-file.h: Rename include guard.
14635 * tui/tui-disasm.h: Rename include guard.
14636 * tui/tui-data.h: Rename include guard.
14637 * tui/tui-command.h: Rename include guard.
14638 * tic6x-tdep.h: Add include guard.
14639 * target/waitstatus.h: Rename include guard.
14640 * target/wait.h: Rename include guard.
14641 * target/target.h: Rename include guard.
14642 * target/resume.h: Rename include guard.
14643 * target-float.h: Rename include guard.
14644 * stabsread.h: Add include guard.
14645 * rs6000-tdep.h: Add include guard.
14646 * riscv-fbsd-tdep.h: Add include guard.
14647 * regformats/regdef.h: Rename include guard.
14648 * record.h: Rename include guard.
14649 * python/python.h: Rename include guard.
14650 * python/python-internal.h: Rename include guard.
14651 * python/py-stopevent.h: Rename include guard.
14652 * python/py-ref.h: Rename include guard.
14653 * python/py-record.h: Rename include guard.
14654 * python/py-record-full.h: Rename include guard.
14655 * python/py-record-btrace.h: Rename include guard.
14656 * python/py-instruction.h: Rename include guard.
14657 * python/py-events.h: Rename include guard.
14658 * python/py-event.h: Rename include guard.
14659 * procfs.h: Add include guard.
14660 * proc-utils.h: Add include guard.
14661 * p-lang.h: Add include guard.
14662 * or1k-tdep.h: Rename include guard.
14663 * observable.h: Rename include guard.
14664 * nto-tdep.h: Rename include guard.
14665 * nat/x86-linux.h: Rename include guard.
14666 * nat/x86-linux-dregs.h: Rename include guard.
14667 * nat/x86-gcc-cpuid.h: Add include guard.
14668 * nat/x86-dregs.h: Rename include guard.
14669 * nat/x86-cpuid.h: Rename include guard.
14670 * nat/ppc-linux.h: Rename include guard.
14671 * nat/mips-linux-watch.h: Rename include guard.
14672 * nat/linux-waitpid.h: Rename include guard.
14673 * nat/linux-ptrace.h: Rename include guard.
14674 * nat/linux-procfs.h: Rename include guard.
14675 * nat/linux-osdata.h: Rename include guard.
14676 * nat/linux-nat.h: Rename include guard.
14677 * nat/linux-namespaces.h: Rename include guard.
14678 * nat/linux-btrace.h: Rename include guard.
14679 * nat/glibc_thread_db.h: Rename include guard.
14680 * nat/gdb_thread_db.h: Rename include guard.
14681 * nat/gdb_ptrace.h: Rename include guard.
14682 * nat/fork-inferior.h: Rename include guard.
14683 * nat/amd64-linux-siginfo.h: Rename include guard.
14684 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14685 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14686 * nat/aarch64-linux.h: Rename include guard.
14687 * nat/aarch64-linux-hw-point.h: Rename include guard.
14688 * mn10300-tdep.h: Add include guard.
14689 * mips-linux-tdep.h: Add include guard.
14690 * mi/mi-parse.h: Rename include guard.
14691 * mi/mi-out.h: Rename include guard.
14692 * mi/mi-main.h: Rename include guard.
14693 * mi/mi-interp.h: Rename include guard.
14694 * mi/mi-getopt.h: Rename include guard.
14695 * mi/mi-console.h: Rename include guard.
14696 * mi/mi-common.h: Rename include guard.
14697 * mi/mi-cmds.h: Rename include guard.
14698 * mi/mi-cmd-break.h: Rename include guard.
14699 * m2-lang.h: Add include guard.
14700 * location.h: Rename include guard.
14701 * linux-record.h: Rename include guard.
14702 * linux-nat.h: Add include guard.
14703 * linux-fork.h: Add include guard.
14704 * i386-darwin-tdep.h: Rename include guard.
14705 * hppa-linux-offsets.h: Add include guard.
14706 * guile/guile.h: Rename include guard.
14707 * guile/guile-internal.h: Rename include guard.
14708 * gnu-nat.h: Rename include guard.
14709 * gdb-stabs.h: Rename include guard.
14710 * frv-tdep.h: Add include guard.
14711 * f-lang.h: Add include guard.
14712 * event-loop.h: Add include guard.
14713 * darwin-nat.h: Rename include guard.
14714 * cp-abi.h: Rename include guard.
14715 * config/sparc/nm-sol2.h: Rename include guard.
14716 * config/nm-nto.h: Rename include guard.
14717 * config/nm-linux.h: Add include guard.
14718 * config/i386/nm-i386gnu.h: Rename include guard.
14719 * config/djgpp/nl_types.h: Rename include guard.
14720 * config/djgpp/langinfo.h: Rename include guard.
14721 * compile/gcc-cp-plugin.h: Add include guard.
14722 * compile/gcc-c-plugin.h: Add include guard.
14723 * compile/compile.h: Rename include guard.
14724 * compile/compile-object-run.h: Rename include guard.
14725 * compile/compile-object-load.h: Rename include guard.
14726 * compile/compile-internal.h: Rename include guard.
14727 * compile/compile-cplus.h: Rename include guard.
14728 * compile/compile-c.h: Rename include guard.
14729 * common/xml-utils.h: Rename include guard.
14730 * common/x86-xstate.h: Rename include guard.
14731 * common/version.h: Rename include guard.
14732 * common/vec.h: Rename include guard.
14733 * common/tdesc.h: Rename include guard.
14734 * common/selftest.h: Rename include guard.
14735 * common/scoped_restore.h: Rename include guard.
14736 * common/scoped_mmap.h: Rename include guard.
14737 * common/scoped_fd.h: Rename include guard.
14738 * common/safe-iterator.h: Rename include guard.
14739 * common/run-time-clock.h: Rename include guard.
14740 * common/refcounted-object.h: Rename include guard.
14741 * common/queue.h: Rename include guard.
14742 * common/ptid.h: Rename include guard.
14743 * common/print-utils.h: Rename include guard.
14744 * common/preprocessor.h: Rename include guard.
14745 * common/pathstuff.h: Rename include guard.
14746 * common/observable.h: Rename include guard.
14747 * common/netstuff.h: Rename include guard.
14748 * common/job-control.h: Rename include guard.
14749 * common/host-defs.h: Rename include guard.
14750 * common/gdb_wait.h: Rename include guard.
14751 * common/gdb_vecs.h: Rename include guard.
14752 * common/gdb_unlinker.h: Rename include guard.
14753 * common/gdb_unique_ptr.h: Rename include guard.
14754 * common/gdb_tilde_expand.h: Rename include guard.
14755 * common/gdb_sys_time.h: Rename include guard.
14756 * common/gdb_string_view.h: Rename include guard.
14757 * common/gdb_splay_tree.h: Rename include guard.
14758 * common/gdb_setjmp.h: Rename include guard.
14759 * common/gdb_ref_ptr.h: Rename include guard.
14760 * common/gdb_optional.h: Rename include guard.
14761 * common/gdb_locale.h: Rename include guard.
14762 * common/gdb_assert.h: Rename include guard.
14763 * common/filtered-iterator.h: Rename include guard.
14764 * common/filestuff.h: Rename include guard.
14765 * common/fileio.h: Rename include guard.
14766 * common/environ.h: Rename include guard.
14767 * common/common-utils.h: Rename include guard.
14768 * common/common-types.h: Rename include guard.
14769 * common/common-regcache.h: Rename include guard.
14770 * common/common-inferior.h: Rename include guard.
14771 * common/common-gdbthread.h: Rename include guard.
14772 * common/common-exceptions.h: Rename include guard.
14773 * common/common-defs.h: Rename include guard.
14774 * common/common-debug.h: Rename include guard.
14775 * common/cleanups.h: Rename include guard.
14776 * common/buffer.h: Rename include guard.
14777 * common/btrace-common.h: Rename include guard.
14778 * common/break-common.h: Rename include guard.
14779 * cli/cli-utils.h: Rename include guard.
14780 * cli/cli-style.h: Rename include guard.
14781 * cli/cli-setshow.h: Rename include guard.
14782 * cli/cli-script.h: Rename include guard.
14783 * cli/cli-interp.h: Rename include guard.
14784 * cli/cli-decode.h: Rename include guard.
14785 * cli/cli-cmds.h: Rename include guard.
14786 * charset-list.h: Add include guard.
14787 * buildsym-legacy.h: Rename include guard.
14788 * bfin-tdep.h: Add include guard.
14789 * ax.h: Rename include guard.
14790 * arm-linux-tdep.h: Add include guard.
14791 * arm-fbsd-tdep.h: Add include guard.
14792 * arch/xtensa.h: Rename include guard.
14793 * arch/tic6x.h: Add include guard.
14794 * arch/i386.h: Add include guard.
14795 * arch/arm.h: Rename include guard.
14796 * arch/arm-linux.h: Rename include guard.
14797 * arch/arm-get-next-pcs.h: Rename include guard.
14798 * arch/amd64.h: Add include guard.
14799 * arch/aarch64-insn.h: Rename include guard.
14800 * arch-utils.h: Rename include guard.
14801 * annotate.h: Add include guard.
14802 * amd64-darwin-tdep.h: Rename include guard.
14803 * aarch64-linux-tdep.h: Add include guard.
14804 * aarch64-fbsd-tdep.h: Add include guard.
14805 * aarch32-linux-nat.h: Add include guard.
14806
148072019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14808
14809 * macrotab.c (macro_define_internal): New function that
14810 factorizes macro_define_object_internal and macro_define_function
14811 code.
14812 (macro_define_object_internal): Use macro_define_internal.
14813 (macro_define_function): Likewise.
14814
148152019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14816
14817 * macrocmd.c (extract_identifier): Return
14818 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14819 callers.
14820
148212019-02-06 John Baldwin <jhb@FreeBSD.org>
14822
14823 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14824
148252019-02-05 Tom Tromey <tom@tromey.com>
14826
14827 * target.c (target_stack::unpush): Move assertion earlier.
14828
148292019-01-30 Tom Tromey <tom@tromey.com>
14830
14831 PR python/23615:
14832 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14833 (gdbpy_parse_and_eval): Likewise.
14834 * python/python-internal.h (gdbpy_allow_threads): New class.
14835
148362019-01-28 John Baldwin <jhb@FreeBSD.org>
14837
14838 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14839 (aarch64_fbsd_fpregmap): Move earlier.
14840 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14841 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14842 instead of individual calls to trad_frame_set_reg_addr.
14843 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14844 earlier.
14845 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14846 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14847 instead of individual calls to trad_frame_set_reg_addr.
14848
148492019-01-28 Alan Hayward <alan.hayward@arm.com>
14850
14851 * CONTRIBUTE: Replace contribution list with wiki link.
14852
148532019-01-25 Tom Tromey <tom@tromey.com>
14854
14855 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14856
148572019-01-25 Tom Tromey <tom@tromey.com>
14858
14859 * xtensa-linux-nat.c: Fix common/ includes.
14860 * xml-support.h: Fix common/ includes.
14861 * xml-support.c: Fix common/ includes.
14862 * x86-linux-nat.c: Fix common/ includes.
14863 * windows-nat.c: Fix common/ includes.
14864 * varobj.h: Fix common/ includes.
14865 * varobj.c: Fix common/ includes.
14866 * value.c: Fix common/ includes.
14867 * valops.c: Fix common/ includes.
14868 * utils.c: Fix common/ includes.
14869 * unittests/xml-utils-selftests.c: Fix common/ includes.
14870 * unittests/utils-selftests.c: Fix common/ includes.
14871 * unittests/unpack-selftests.c: Fix common/ includes.
14872 * unittests/tracepoint-selftests.c: Fix common/ includes.
14873 * unittests/style-selftests.c: Fix common/ includes.
14874 * unittests/string_view-selftests.c: Fix common/ includes.
14875 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14876 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14877 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14878 * unittests/rsp-low-selftests.c: Fix common/ includes.
14879 * unittests/parse-connection-spec-selftests.c: Fix common/
14880 includes.
14881 * unittests/optional-selftests.c: Fix common/ includes.
14882 * unittests/offset-type-selftests.c: Fix common/ includes.
14883 * unittests/observable-selftests.c: Fix common/ includes.
14884 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14885 * unittests/memrange-selftests.c: Fix common/ includes.
14886 * unittests/memory-map-selftests.c: Fix common/ includes.
14887 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14888 * unittests/function-view-selftests.c: Fix common/ includes.
14889 * unittests/environ-selftests.c: Fix common/ includes.
14890 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14891 * unittests/common-utils-selftests.c: Fix common/ includes.
14892 * unittests/cli-utils-selftests.c: Fix common/ includes.
14893 * unittests/array-view-selftests.c: Fix common/ includes.
14894 * ui-file.c: Fix common/ includes.
14895 * tui/tui-io.c: Fix common/ includes.
14896 * tracepoint.h: Fix common/ includes.
14897 * tracepoint.c: Fix common/ includes.
14898 * tracefile-tfile.c: Fix common/ includes.
14899 * top.h: Fix common/ includes.
14900 * top.c: Fix common/ includes.
14901 * thread.c: Fix common/ includes.
14902 * target/waitstatus.h: Fix common/ includes.
14903 * target/waitstatus.c: Fix common/ includes.
14904 * target.h: Fix common/ includes.
14905 * target.c: Fix common/ includes.
14906 * target-memory.c: Fix common/ includes.
14907 * target-descriptions.c: Fix common/ includes.
14908 * symtab.h: Fix common/ includes.
14909 * symfile.c: Fix common/ includes.
14910 * stap-probe.c: Fix common/ includes.
14911 * spu-linux-nat.c: Fix common/ includes.
14912 * sparc-nat.c: Fix common/ includes.
14913 * source.c: Fix common/ includes.
14914 * solib.c: Fix common/ includes.
14915 * solib-target.c: Fix common/ includes.
14916 * ser-unix.c: Fix common/ includes.
14917 * ser-tcp.c: Fix common/ includes.
14918 * ser-pipe.c: Fix common/ includes.
14919 * ser-base.c: Fix common/ includes.
14920 * selftest-arch.c: Fix common/ includes.
14921 * s12z-tdep.c: Fix common/ includes.
14922 * rust-exp.y: Fix common/ includes.
14923 * rs6000-aix-tdep.c: Fix common/ includes.
14924 * riscv-tdep.c: Fix common/ includes.
14925 * remote.c: Fix common/ includes.
14926 * remote-notif.h: Fix common/ includes.
14927 * remote-fileio.h: Fix common/ includes.
14928 * remote-fileio.c: Fix common/ includes.
14929 * regcache.h: Fix common/ includes.
14930 * regcache.c: Fix common/ includes.
14931 * record-btrace.c: Fix common/ includes.
14932 * python/python.c: Fix common/ includes.
14933 * python/py-type.c: Fix common/ includes.
14934 * python/py-inferior.c: Fix common/ includes.
14935 * progspace.h: Fix common/ includes.
14936 * producer.c: Fix common/ includes.
14937 * procfs.c: Fix common/ includes.
14938 * proc-api.c: Fix common/ includes.
14939 * printcmd.c: Fix common/ includes.
14940 * ppc-linux-nat.c: Fix common/ includes.
14941 * parser-defs.h: Fix common/ includes.
14942 * osdata.c: Fix common/ includes.
14943 * obsd-nat.c: Fix common/ includes.
14944 * nat/x86-linux.c: Fix common/ includes.
14945 * nat/x86-linux-dregs.c: Fix common/ includes.
14946 * nat/x86-dregs.h: Fix common/ includes.
14947 * nat/x86-dregs.c: Fix common/ includes.
14948 * nat/ppc-linux.c: Fix common/ includes.
14949 * nat/mips-linux-watch.h: Fix common/ includes.
14950 * nat/mips-linux-watch.c: Fix common/ includes.
14951 * nat/linux-waitpid.c: Fix common/ includes.
14952 * nat/linux-ptrace.h: Fix common/ includes.
14953 * nat/linux-ptrace.c: Fix common/ includes.
14954 * nat/linux-procfs.c: Fix common/ includes.
14955 * nat/linux-personality.c: Fix common/ includes.
14956 * nat/linux-osdata.c: Fix common/ includes.
14957 * nat/linux-namespaces.c: Fix common/ includes.
14958 * nat/linux-btrace.h: Fix common/ includes.
14959 * nat/linux-btrace.c: Fix common/ includes.
14960 * nat/fork-inferior.c: Fix common/ includes.
14961 * nat/amd64-linux-siginfo.c: Fix common/ includes.
14962 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14963 * nat/aarch64-linux.c: Fix common/ includes.
14964 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14965 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14966 * namespace.h: Fix common/ includes.
14967 * mips-linux-tdep.c: Fix common/ includes.
14968 * minsyms.c: Fix common/ includes.
14969 * mi/mi-parse.h: Fix common/ includes.
14970 * mi/mi-main.c: Fix common/ includes.
14971 * mi/mi-cmd-env.c: Fix common/ includes.
14972 * memrange.h: Fix common/ includes.
14973 * memattr.c: Fix common/ includes.
14974 * maint.h: Fix common/ includes.
14975 * maint.c: Fix common/ includes.
14976 * main.c: Fix common/ includes.
14977 * machoread.c: Fix common/ includes.
14978 * location.c: Fix common/ includes.
14979 * linux-thread-db.c: Fix common/ includes.
14980 * linux-nat.c: Fix common/ includes.
14981 * linux-fork.c: Fix common/ includes.
14982 * inline-frame.c: Fix common/ includes.
14983 * infrun.c: Fix common/ includes.
14984 * inflow.c: Fix common/ includes.
14985 * inferior.h: Fix common/ includes.
14986 * inferior.c: Fix common/ includes.
14987 * infcmd.c: Fix common/ includes.
14988 * inf-ptrace.c: Fix common/ includes.
14989 * inf-child.c: Fix common/ includes.
14990 * ia64-linux-nat.c: Fix common/ includes.
14991 * i387-tdep.c: Fix common/ includes.
14992 * i386-tdep.c: Fix common/ includes.
14993 * i386-linux-tdep.c: Fix common/ includes.
14994 * i386-linux-nat.c: Fix common/ includes.
14995 * i386-go32-tdep.c: Fix common/ includes.
14996 * i386-fbsd-tdep.c: Fix common/ includes.
14997 * i386-fbsd-nat.c: Fix common/ includes.
14998 * guile/scm-type.c: Fix common/ includes.
14999 * guile/guile.c: Fix common/ includes.
15000 * go32-nat.c: Fix common/ includes.
15001 * gnu-nat.c: Fix common/ includes.
15002 * gdbthread.h: Fix common/ includes.
15003 * gdbarch-selftests.c: Fix common/ includes.
15004 * gdb_usleep.c: Fix common/ includes.
15005 * gdb_select.h: Fix common/ includes.
15006 * gdb_bfd.c: Fix common/ includes.
15007 * gcore.c: Fix common/ includes.
15008 * fork-child.c: Fix common/ includes.
15009 * findvar.c: Fix common/ includes.
15010 * fbsd-nat.c: Fix common/ includes.
15011 * event-top.c: Fix common/ includes.
15012 * event-loop.c: Fix common/ includes.
15013 * dwarf2read.c: Fix common/ includes.
15014 * dwarf2loc.c: Fix common/ includes.
15015 * dwarf2-frame.c: Fix common/ includes.
15016 * dwarf-index-cache.c: Fix common/ includes.
15017 * dtrace-probe.c: Fix common/ includes.
15018 * disasm-selftests.c: Fix common/ includes.
15019 * defs.h: Fix common/ includes.
15020 * csky-tdep.c: Fix common/ includes.
15021 * cp-valprint.c: Fix common/ includes.
15022 * cp-support.h: Fix common/ includes.
15023 * cp-support.c: Fix common/ includes.
15024 * corelow.c: Fix common/ includes.
15025 * completer.h: Fix common/ includes.
15026 * completer.c: Fix common/ includes.
15027 * compile/compile.c: Fix common/ includes.
15028 * compile/compile-loc2c.c: Fix common/ includes.
15029 * compile/compile-cplus-types.c: Fix common/ includes.
15030 * compile/compile-cplus-symbols.c: Fix common/ includes.
15031 * command.h: Fix common/ includes.
15032 * cli/cli-dump.c: Fix common/ includes.
15033 * cli/cli-cmds.c: Fix common/ includes.
15034 * charset.c: Fix common/ includes.
15035 * build-id.c: Fix common/ includes.
15036 * btrace.h: Fix common/ includes.
15037 * btrace.c: Fix common/ includes.
15038 * breakpoint.h: Fix common/ includes.
15039 * breakpoint.c: Fix common/ includes.
15040 * ax.h:
15041 (enum agent_op): Fix common/ includes.
15042 * ax-general.c (struct aop_map): Fix common/ includes.
15043 * ax-gdb.c: Fix common/ includes.
15044 * auxv.c: Fix common/ includes.
15045 * auto-load.c: Fix common/ includes.
15046 * arm-tdep.c: Fix common/ includes.
15047 * arch/riscv.c: Fix common/ includes.
15048 * arch/ppc-linux-common.c: Fix common/ includes.
15049 * arch/i386.c: Fix common/ includes.
15050 * arch/arm.c: Fix common/ includes.
15051 * arch/arm-linux.c: Fix common/ includes.
15052 * arch/arm-get-next-pcs.c: Fix common/ includes.
15053 * arch/amd64.c: Fix common/ includes.
15054 * arch/aarch64.c: Fix common/ includes.
15055 * arch/aarch64-insn.c: Fix common/ includes.
15056 * arch-utils.c: Fix common/ includes.
15057 * amd64-windows-tdep.c: Fix common/ includes.
15058 * amd64-tdep.c: Fix common/ includes.
15059 * amd64-sol2-tdep.c: Fix common/ includes.
15060 * amd64-obsd-tdep.c: Fix common/ includes.
15061 * amd64-nbsd-tdep.c: Fix common/ includes.
15062 * amd64-linux-tdep.c: Fix common/ includes.
15063 * amd64-linux-nat.c: Fix common/ includes.
15064 * amd64-fbsd-tdep.c: Fix common/ includes.
15065 * amd64-fbsd-nat.c: Fix common/ includes.
15066 * amd64-dicos-tdep.c: Fix common/ includes.
15067 * amd64-darwin-tdep.c: Fix common/ includes.
15068 * agent.c: Fix common/ includes.
15069 * ada-lang.h: Fix common/ includes.
15070 * ada-lang.c: Fix common/ includes.
15071 * aarch64-tdep.c: Fix common/ includes.
15072
150732019-01-25 Tom Tromey <tom@tromey.com>
15074
15075 * common/create-version.sh: Use common/version.h.
15076
150772019-01-24 Pedro Alves <palves@redhat.com>
15078
15079 * infrun.c (signal_stop, signal_print, signal_program)
15080 (signal_catch, signal_pass): Now arrays instead of pointers.
15081 (update_signals_program_target, do_target_resume)
15082 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15083 * linux-nat.c (linux_nat_target::pass_signals)
15084 (linux_nat_target::create_inferior, linux_nat_target::attach):
15085 Adjust.
15086 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15087 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15088 * procfs.c (procfs_target::pass_signals): Adjust.
15089 * record-full.c (record_full_target::resume): Adjust.
15090 * remote.c (remote_target::pass_signals)
15091 (remote_target::program_signals): Adjust.
15092 * target-debug.h (target_debug_print_signals): Now takes a
15093 gdb::array_view as parameter. Adjust.
15094 * target.h (target_ops) <pass_signals, program_signals>: Replace
15095 pointer and length parameters with gdb::array_view.
15096 (target_pass_signals, target_program_signals): Likewise.
15097 * target-delegates.c: Regenerate.
15098
150992019-01-24 Pedro Alves <palves@redhat.com>
15100
15101 * common/forward-scope-exit.h
15102 (forward_scope_exit::forward_scope_exit): Pass arguments to
15103 m_bind_function directly, instead of creating a std::bind and
15104 copying that.
15105
151062019-01-24 Alan Hayward <alan.hayward@arm.com>
15107
15108 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15109 for static members.
15110 (pass_in_v_vfp_candidate): Likewise.
15111
151122019-01-23 Tom Tromey <tom@tromey.com>
15113 Pedro Alves <palves@redhat.com>
15114
15115 * regcache.c (class regcache_invalidator): Remove.
15116 (regcache::raw_write): Use make_scope_exit.
15117
151182019-01-23 Tom Tromey <tom@tromey.com>
15119
15120 * ui-out.h (class ui_out_emit_type): Update comment.
15121
151222019-01-23 Tom Tromey <tom@tromey.com>
15123
15124 * infrun.c (fetch_inferior_event): Update comment.
15125
151262019-01-23 Tom Tromey <tom@tromey.com>
15127 Pedro Alves <palves@redhat.com>
15128
15129 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15130 parameter.
15131 (fetch_inferior_event): Use SCOPE_EXIT.
15132
15133
151342019-01-23 Tom Tromey <tom@tromey.com>
15135 Pedro Alves <palves@redhat.com>
15136
15137 * infrun.c (disable_thread_events): Delete.
15138 (stop_all_threads): Use SCOPE_EXIT.
15139
151402019-01-23 Tom Tromey <tom@tromey.com>
15141 Pedro Alves <palves@redhat.com>
15142
15143 * symfile.c: Include forward-scope-exit.h.
15144 (clear_symtab_users_cleanup): Replace forward declaration with
15145 a FORWARD_SCOPE_EXIT.
15146 (syms_from_objfile_1): Use the forward_scope_exit and
15147 gdb::optional instead of cleanup_function.
15148 (reread_symbols): Use the forward_scope_exit instead of
15149 cleanup_function.
15150 (clear_symtab_users_cleanup): Remove function.
15151
151522019-01-23 Tom Tromey <tom@tromey.com>
15153 Pedro Alves <palves@redhat.com>
15154
15155 * linux-nat.c: Include scope-exit.h.
15156 (cleanup_target_stop): Remove.
15157 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15158 SCOPE_EXIT.
15159
151602019-01-23 Tom Tromey <tom@tromey.com>
15161 Pedro Alves <palves@redhat.com>
15162
15163 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15164 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15165
151662019-01-23 Tom Tromey <tom@tromey.com>
15167 Andrew Burgess <andrew.burgess@embecosm.com>
15168 Pedro Alves <palves@redhat.com>
15169
15170 * infrun.c (fetch_inferior_event): Use scope_exit.
15171 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15172 * top.c (execute_command): Use scope_exit.
15173 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15174 * utils.c (do_bpstat_clear_actions_cleanup)
15175 (make_bpstat_clear_actions_cleanup): Remove.
15176
151772019-01-23 Tom Tromey <tom@tromey.com>
15178 Pedro Alves <palves@redhat.com>
15179
15180 * infrun.c: Include "common/scope-exit.h"
15181 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15182 (wait_for_inferior): Use SCOPE_EXIT.
15183 (fetch_inferior_event): Use scope_exit.
15184
151852019-01-23 Tom Tromey <tom@tromey.com>
15186 Pedro Alves <palves@redhat.com>
15187
15188 * breakpoint.c (create_breakpoint): Remove cleanup.
15189
151902019-01-23 Tom Tromey <tom@tromey.com>
15191 Andrew Burgess <andrew.burgess@embecosm.com>
15192 Pedro Alves <palves@redhat.com>
15193
151942019-01-23 Pedro Alves <palves@redhat.com>
15195
15196 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15197
151982019-01-23 Pedro Alves <palves@redhat.com>
15199 Andrew Burgess <andrew.burgess@embecosm.com>
15200
15201 * gdbthread.h: Include "common/forward-scope-exit.h".
15202 (scoped_finish_thread_state): Redefine custom class in terms of
15203 forward_scope_exit.
15204
152052019-01-23 Pedro Alves <palves@redhat.com>
15206 Andrew Burgess <andrew.burgess@embecosm.com>
15207
15208 * common/forward-scope-exit.h: New file.
15209
152102019-01-23 Pedro Alves <palves@redhat.com>
15211 Andrew Burgess <andrew.burgess@embecosm.com>
15212 Tom Tromey <tom@tromey.com>
15213
15214 * common/scope-exit.h: New file.
15215
152162019-01-23 Pedro Alves <palves@redhat.com>
15217
15218 * common/preprocessor.h (ESC): Rename to ...
15219 (ESC_PARENS): ... this.
15220 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15221 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15222
152232019-01-23 Tom Tromey <tom@tromey.com>
15224
15225 * language.h (class scoped_switch_to_sym_language_if_auto):
15226 Initialize m_lang in both cases.
15227
152282019-01-23 Alan Hayward <alan.hayward@arm.com>
15229
15230 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15231 with XCNEW.
15232
152332019-01-22 Tom Tromey <tom@tromey.com>
15234
15235 * corelow.c: Do not include sys/file.h.
15236
152372019-01-22 Tom Tromey <tom@tromey.com>
15238
15239 * tui/tui-wingeneral.h: Include gdb_curses.h.
15240
152412019-01-22 Tom Tromey <tom@tromey.com>
15242
15243 * source-cache.h (class source_cache) <get_source_lines,
15244 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15245
152462019-01-22 Tom Tromey <tom@tromey.com>
15247
15248 * remote-fileio.h (struct remote_target): Declare.
15249
152502019-01-22 Tom Tromey <tom@tromey.com>
15251
15252 * python/py-arch.c: Do not include py-ref.h.
15253 * python/py-bpevent.c: Do not include py-ref.h.
15254 * python/py-cmd.c: Do not include py-ref.h.
15255 * python/py-continueevent.c: Do not include py-ref.h.
15256 * python/py-event.h: Do not include py-ref.h.
15257 * python/py-evtregistry.c: Do not include py-ref.h.
15258 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15259 * python/py-frame.c: Do not include py-ref.h.
15260 * python/py-framefilter.c: Do not include py-ref.h.
15261 * python/py-function.c: Do not include py-ref.h.
15262 * python/py-infevents.c: Do not include py-ref.h.
15263 * python/py-linetable.c: Do not include py-ref.h.
15264 * python/py-objfile.c: Do not include py-ref.h.
15265 * python/py-param.c: Do not include py-ref.h.
15266 * python/py-prettyprint.c: Do not include py-ref.h.
15267 * python/py-progspace.c: Do not include py-ref.h.
15268 * python/py-symbol.c: Do not include py-ref.h.
15269 * python/py-symtab.c: Do not include py-ref.h.
15270 * python/py-type.c: Do not include py-ref.h.
15271 * python/py-unwind.c: Do not include py-ref.h.
15272 * python/py-utils.c: Do not include py-ref.h.
15273 * python/py-value.c: Do not include py-ref.h.
15274 * python/py-varobj.c: Do not include py-ref.h.
15275 * python/py-xmethods.c: Do not include py-ref.h.
15276 * python/python.c: Do not include py-ref.h.
15277 * varobj.c: Do not include py-ref.h.
15278
152792019-01-22 Tom Tromey <tom@tromey.com>
15280
15281 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15282 keyword for bcache.
15283
152842019-01-22 Tom Tromey <tom@tromey.com>
15285
15286 * compile/compile-cplus-types.c: Remove a comment by #include.
15287
152882019-01-22 Tom Tromey <tom@tromey.com>
15289
15290 * compile/gcc-c-plugin.h: Include compile-internal.h.
15291
152922019-01-22 Tom Tromey <tom@tromey.com>
15293
15294 * stabsread.c (EXTERN): Do not define.
15295 (symnum, next_symbol_text_func, processing_gcc_compilation)
15296 (within_function, global_sym_chain, global_stabs)
15297 (previous_stab_code, this_object_header_files)
15298 (n_this_object_header_files)
15299 (n_allocated_this_object_header_files): Define.
15300 * stabsread.h (EXTERN): Never define. Use "extern".
15301
153022019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15303
15304 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15305 history_value.
15306
153072019-01-21 Tom Tromey <tom@tromey.com>
15308
15309 * ui-out.c: Fix includes.
15310 * tui/tui-source.c: Fix includes.
15311 * target.c: Fix includes.
15312 * remote.c: Fix includes.
15313 * regcache.c: Fix includes.
15314 * python/py-block.c: Fix includes.
15315 * printcmd.c: Fix includes.
15316 * or1k-tdep.c: Fix includes.
15317 * mi/mi-main.c: Fix includes.
15318 * m32r-tdep.c: Fix includes.
15319 * csky-tdep.c: Fix includes.
15320 * compile/compile-cplus-types.c: Fix includes.
15321 * cli/cli-interp.c: Fix includes.
15322
153232019-01-21 Alan Hayward <alan.hayward@arm.com>
15324
15325 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15326 for padding.
15327
153282019-01-16 Tom Tromey <tom@tromey.com>
15329
15330 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15331 earlier.
15332 (struct objfile) <msymbols_range>: Move from top level.
15333 <msymbols>: New method.
15334 (class objfile_msymbols): Remove.
15335 * symtab.c (default_collect_symbol_completion_matches_break_on):
15336 Update.
15337 * symmisc.c (dump_msymbols): Update.
15338 * stabsread.c (scan_file_globals): Update.
15339 * objc-lang.c (info_selectors_command, info_classes_command)
15340 (find_methods): Update.
15341 * minsyms.c (find_solib_trampoline_target): Update.
15342 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15343 * coffread.c (coff_symfile_read): Update.
15344 * ada-lang.c (ada_lookup_simple_minsym)
15345 (ada_collect_symbol_completion_matches): Update.
15346
153472019-01-16 Tom Tromey <tom@tromey.com>
15348
15349 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15350 type. Remove no-argument constructor.
15351 <iterator::operator++>: Simplify.
15352 <begin>: Update.
15353 <end>: Use minimal_symbol_count.
15354
153552019-01-16 Tom Tromey <tom@tromey.com>
15356
15357 * objfiles.h (struct objfile) <psymtabs>: New method.
15358 (class objfile_psymtabs): Remove.
15359 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15360 typedef.
15361 <range>: New method.
15362 (require_partial_symbols): Change return type.
15363 * psymtab.c (require_partial_symbols)
15364 (psym_expand_symtabs_matching): Update.
15365 * mdebugread.c (parse_partial_symbols): Update.
15366 * dbxread.c (dbx_end_psymtab): Update.
15367
153682019-01-15 Tom Tromey <tom@tromey.com>
15369
15370 * symtab.c (lookup_objfile_from_block)
15371 (lookup_symbol_in_objfile_symtabs)
15372 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15373 (find_line_symtab, info_sources_command)
15374 (default_collect_symbol_completion_matches_break_on)
15375 (make_source_files_completion_list): Update.
15376 * symmisc.c (print_objfile_statistics, dump_objfile)
15377 (maintenance_print_symbols, maintenance_info_symtabs)
15378 (maintenance_check_symtabs, maintenance_info_line_tables):
15379 Update.
15380 * source.c (select_source_symtab)
15381 (forget_cached_source_info_for_objfile): Update.
15382 * objfiles.h (class objfile_compunits): Remove.
15383 (struct objfile) <compunits_range>: New typedef.
15384 (compunits): New method.
15385 * objfiles.c (objfile_relocate1): Update.
15386 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15387 * maint.c (count_symtabs_and_blocks): Update.
15388 * linespec.c (iterate_over_all_matching_symtabs): Update.
15389 * cp-support.c (add_symbol_overload_list_qualified): Update.
15390 * coffread.c (coff_symtab_read): Update.
15391 * ada-lang.c (add_nonlocal_symbols)
15392 (ada_collect_symbol_completion_matches)
15393 (ada_add_global_exceptions): Update.
15394
153952019-01-15 Tom Tromey <tom@tromey.com>
15396
15397 * progspace.h (program_space) <objfiles_safe_range>: New
15398 typedef.
15399 <objfiles_safe>: New method.
15400 * objfiles.h (class all_objfiles_safe): Remove.
15401 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15402 * jit.c (jit_inferior_exit_hook): Update.
15403
154042019-01-17 Tom Tromey <tom@tromey.com>
15405
15406 * progspace.h (program_space) <objfiles_range>: New typedef.
15407 <objfiles>: New method.
15408 <objfiles_head>: Rename from objfiles.
15409 (object_files): Update.
15410 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15411 * guile/scm-pretty-print.c
15412 (ppscm_find_pretty_printer_from_objfiles): Update.
15413 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15414 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15415 Update.
15416 * python/py-progspace.c (pspy_get_objfiles): Update.
15417 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15418 Update.
15419 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15420 (objfpy_lookup_objfile_by_build_id): Update.
15421 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15422 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15423 Update.
15424 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15425 (expand_symtab_containing_pc, lookup_objfile_from_block)
15426 (lookup_static_symbol, basic_lookup_transparent_type)
15427 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15428 (find_line_symtab, info_sources_command)
15429 (default_collect_symbol_completion_matches_break_on)
15430 (make_source_files_completion_list, find_main_name): Update.
15431 * symmisc.c (print_symbol_bcache_statistics)
15432 (print_objfile_statistics, maintenance_print_symbols)
15433 (maintenance_print_msymbols, maintenance_print_objfiles)
15434 (maintenance_info_symtabs, maintenance_check_symtabs)
15435 (maintenance_expand_symtabs, maintenance_info_line_tables):
15436 Update.
15437 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15438 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15439 (map_overlay_command, unmap_overlay_command)
15440 (simple_overlay_update, expand_symtabs_matching)
15441 (map_symbol_filenames): Update.
15442 * symfile-debug.c (set_debug_symfile): Update.
15443 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15444 Update.
15445 * source.c (select_source_symtab, forget_cached_source_info):
15446 Update.
15447 * solib.c (solib_read_symbols): Update.
15448 * solib-spu.c (append_ocl_sos): Update.
15449 * psymtab.c (maintenance_print_psymbols)
15450 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15451 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15452 * printcmd.c (info_symbol_command): Update.
15453 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15454 Update.
15455 * objfiles.h (class all_objfiles): Remove.
15456 * objfiles.c (have_partial_symbols, have_full_symbols)
15457 (have_minimal_symbols, qsort_cmp, update_section_map)
15458 (shared_objfile_contains_address_p)
15459 (default_iterate_over_objfiles_in_search_order): Update.
15460 * objc-lang.c (info_selectors_command, info_classes_command)
15461 (find_methods): Update.
15462 * minsyms.c (find_solib_trampoline_target): Update.
15463 * maint.c (maintenance_info_sections)
15464 (maintenance_translate_address, count_symtabs_and_blocks):
15465 Update.
15466 * main.c (captured_main_1): Update.
15467 * linux-thread-db.c (try_thread_db_load_from_pdir)
15468 (has_libpthread): Update.
15469 * linespec.c (iterate_over_all_matching_symtabs)
15470 (search_minsyms_for_name): Update.
15471 * jit.c (jit_find_objf_with_entry_addr): Update.
15472 * hppa-tdep.c (find_unwind_entry)
15473 (hppa_lookup_stub_minimal_symbol): Update.
15474 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15475 Update.
15476 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15477 (elf_gnu_ifunc_resolve_by_got): Update.
15478 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15479 * dwarf-index-write.c (save_gdb_index_command): Update.
15480 * cp-support.c (add_symbol_overload_list_qualified): Update.
15481 * breakpoint.c (create_overlay_event_breakpoint)
15482 (create_longjmp_master_breakpoint)
15483 (create_std_terminate_master_breakpoint)
15484 (create_exception_master_breakpoint): Update.
15485 * blockframe.c (find_pc_partial_function): Update.
15486 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15487 (ada_collect_symbol_completion_matches)
15488 (ada_add_global_exceptions): Update.
15489
154902019-01-17 Tom Tromey <tom@tromey.com>
15491
15492 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15493 declare VEC.
15494 (solib_target_parse_libraries): Change return type.
15495 (library_list_start_segment, library_list_start_section)
15496 (library_list_end_library, library_list_start_library); Update.
15497 (solib_target_free_library_list): Remove.
15498 (solib_target_parse_libraries): Remove cleanup. Change return
15499 type.
15500 (solib_target_current_sos): Update.
15501
155022019-01-17 Tom Tromey <tromey@bapiya>
15503
15504 * valprint.c: Replace "the the" with "the".
15505 * symtab.c: Replace "the the" with "the".
15506 * solib.c: Replace "the the" with "the".
15507 * solib-dsbt.c: Replace "the the" with "the".
15508 * linespec.c: Replace "the the" with "the".
15509 * dwarf2loc.h: Replace "the the" with "the".
15510 * amd64-windows-tdep.c: Replace "the the" with "the".
15511 * aarch64-tdep.c: Replace "the the" with "the".
15512
155132019-01-16 Keith Seitz <keiths@redhat.com>
15514
15515 PR gdb/23773
15516 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15517 <builder>: Rename to ..
15518 <m_builder>: ... this and make private.
15519 (dwarf2_cu::get_builder): New method. Change all users of
15520 `builder' to use this method.
15521 (dwarf2_start_symtab): Move to ...
15522 (dwarf2_cu::start_symtab): ... here. Update all callers
15523 (setup_type_unit_groups): Move to ...
15524 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15525 callers.
15526 (dwarf2_cu::reset_builder): New method.
15527 (process_full_compunit, process_full_type_unit): Use
15528 dwarf2_cu::reset_builder.
15529 (follow_die_offset): Record the ancestor CU if it is different
15530 from the followed DIE's CU.
15531 (follow_die_sig_1): Likewise.
15532
155332019-01-15 Tom Tromey <tom@tromey.com>
15534
15535 * remote.c (class remote_state) <buf>: Now a char_vector.
15536 <buf_size>: Remove.
15537 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15538 parameter.
15539 (remote_target::getpkt_or_notif_sane_1)
15540 (remote_target::getpkt_sane)
15541 (remote_target::getpkt_or_notif_sane): Likewise.
15542 (class remote_target) <putpkt>: New overload.
15543 (remote_target::read_frame): Change type of "buf_p". Remove
15544 sizeof_p parameter.
15545 (packet_ok): New overload.
15546 (packet_check_result): New overload.
15547 Update all uses.
15548
155492019-01-14 Tom Tromey <tom@tromey.com>
15550
15551 * remote-notif.c (handle_notification, remote_notif_ack)
15552 (remote_notif_parse): Make "buf" const.
15553 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15554 const.
15555 (remote_notif_parse, remote_notif_ack, handle_notification):
15556 Likewise.
15557 * remote.c (remote_notif_stop_parse): Make "buf" const.
15558 (remote_target::remote_parse_stop_reply): Make "buf" const.
15559 (remote_notif_stop_ack): Make "buf" const.
15560
155612019-01-14 Tom Tromey <tom@tromey.com>
15562
15563 * remote.c (remote_console_output): Make parameter const.
15564
155652019-01-14 Tom Tromey <tom@tromey.com>
15566
15567 * target-debug.h (target_debug_print_signals): Constify.
15568 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15569 * procfs.c (procfs_target::pass_signals): Update.
15570 * linux-nat.c (linux_nat_target::pass_signals): Update.
15571 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15572 * target-delegates.c: Rebuild.
15573 * remote.c (remote_target::program_signals): Update.
15574 (remote_target::pass_signals): Update.
15575 * target.c (target_pass_signals): Constify argument.
15576 (target_program_signals): Likewise.
15577 * target.h (struct target_ops) <pass_signals, program_signals>:
15578 Constify argument.
15579 (target_pass_signals, target_program_signals): Constify argument.
15580
155812019-01-14 Tom Tromey <tom@tromey.com>
15582
15583 PR tui/28819:
15584 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15585
155862019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15587
15588 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15589 field.
15590 * rs6000-tdep.c: Include reggroups.h.
15591 (IS_V_ALIAS_PSEUDOREG): Define.
15592 (rs6000_register_name): Return names for the "vX" aliases.
15593 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15594 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15595 aliases. Call default_register_reggroup_p for all other
15596 pseudo-registers.
15597 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15598 New functions.
15599 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15600 Handle "vX" aliases.
15601 (v_alias_pseudo_register_collect): New function.
15602 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15603 (rs6000_gdbarch_init): Initialize "vX" aliases as
15604 pseudo-registers. Restore registration of
15605 rs6000_pseudo_register_reggroup_p with
15606 set_tdesc_pseudo_register_reggroup_p.
15607
156082019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15609
15610 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15611 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15612 set_gdbarch_num_pseudo_regs.
15613
156142019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15615
15616 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15617 Remove arg prefixname, add do_set and do_show.
15618 Add member functions set_list and show_list.
15619 * cli/cli-style.c (class cli_style_option): Update accordingly.
15620 (style_set_list): Move to file scope.
15621 (style_show_list): Likewise.
15622 (set_style): Call help_list.
15623 (show_style): Call cmd_show_list.
15624 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15625 Update to use the new macro.
15626
156272019-10-12 Joel Brobecker <brobecker@adacore.com>
15628
15629 * ada-lang.c (_initialize_ada_language): Expand the help text
15630 for the "catch exception" command.
15631
156322019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15633
15634 * symtab.c (matching_obj_sections): Initialize obj,
15635 declare it closer to its usage.
15636
156372019-01-10 Tom Tromey <tom@tromey.com>
15638
15639 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15640 (basic_inf_threads_range): Remove.
15641 (inf_threads_range, inf_non_exited_threads_range)
15642 (safe_inf_threads_range): Use next_adapter.
15643
156442019-01-10 Keith Seitz <keiths@redhat.com>
15645
15646 PR gdb/23712
15647 PR symtab/23010
15648 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15649 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15650
156512019-01-10 Keith Seitz <keiths@redhat.com>
15652
15653 PR gdb/23712
15654 PR symtab/23010
15655 * dictionary.c (pending_to_vector): Remove.
15656 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15657 Remove _1 suffix, replacing functions of the same name. Update
15658 all callers.
15659 (dict_create_hashed, dict_create_hashed_expandable)
15660 (dict_create_linear, dict_create_linear_expandable, dict_free)
15661 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15662 Make functions static.
15663
156642019-01-10 Keith Seitz <keiths@redhat.com>
15665
15666 PR gdb/23712
15667 PR symtab/23010
15668 * dictionary.h (struct dictionary): Replace declaration with
15669 multidictionary.
15670 (dict_create_hashed, dict_create_hashed_expandable)
15671 (dict_create_linear, dict_create_linear_expandable)
15672 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15673 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15674 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15675 taking multidictionary argument.
15676 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15677 * block.h (struct block) <dict>: Change to multidictionary
15678 and rename `multidict'.
15679 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15680 symmisc.c: Update all dictionary references to multidictionary.
15681
156822019-01-10 Keith Seitz <keiths@redhat.com>
15683
15684 PR gdb/23712
15685 PR symtab/23010
15686 * dictionary.c: Include unordered_map.
15687 (pending_to_vector): New function.
15688 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15689 Rewrite the non-"_1" functions to take vector instead
15690 of linked list.
15691 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15692 "new" _1 versions of the same name.
15693 (multidictionary): Define.
15694 (std::hash<enum language): New definition.
15695 (collate_pending_symbols_by_language, mdict_create_hashed)
15696 (mdict_create_hashed_expandable, mdict_create_linear)
15697 (mdict_create_linear_expandable, mdict_free)
15698 (find_language_dictionary, create_new_language_dictionary)
15699 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15700 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15701 (mdict_size, mdict_empty): New functions.
15702 * dictionary.h (mdict_iterator): Define.
15703
157042019-01-10 Pedro Alves <palves@redhat.com>
15705
15706 * breakpoint.c (read_uploaded_action)
15707 (create_tracepoint_from_upload): Adjust to use
15708 gdb::unique_xmalloc_ptr.
15709 * ctf.c (ctf_write_uploaded_tp):
15710 (SET_ARRAY_FIELD): Use emplace_back.
15711 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15712 * tracefile-tfile.c (tfile_write_uploaded_tp):
15713 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15714 gdb::unique_xmalloc_ptr.
15715 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15716 at_string, cond_string, cmd_strings>: Replace char pointers
15717 with gdb::unique_xmalloc_ptr.
15718
157192019-01-10 Pedro Alves <palves@redhat.com>
15720
15721 * solib-target.c (library_list_start_library): Don't xstrdup name.
15722
157232019-01-10 Pedro Alves <palves@redhat.com>
15724
15725 * mdebugread.c (parse_partial_symbols): Use
15726 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15727
157282019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15729
15730 * linux-fork.c (scoped_switch_fork_info)
15731 <~scoped_switch_fork_info>: Fix incorrect variable name.
15732
157332019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15734
15735 * linux-fork.c (scoped_switch_fork_info)
15736 <scoped_switch_fork_info>: Make explicit.
15737 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15738
157392019-01-10 Tom Tromey <tom@tromey.com>
15740
15741 * objfiles.h (objfile::reset_psymtabs): Update.
15742 * objfiles.c (objfile::objfile): Update.
15743 * psymtab.h (psymtab_storage::obstack): Update.
15744 (psymtab_storage::m_obstack): Use gdb::optional.
15745 (class psymtab_storage): Update comment. Remove objfile
15746 parameter.
15747 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15748
157492019-01-10 Tom Tromey <tom@tromey.com>
15750
15751 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15752 <free_psymtabs>: Now private.
15753 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15754 (allocate_psymtab): Use new method.
15755
157562019-01-10 Tom Tromey <tom@tromey.com>
15757
15758 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15759 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15760 * mdebugread.c (parse_partial_symbols): Use
15761 allocate_dependencies.
15762 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15763 allocate_dependencies.
15764 (process_psymtab_comp_unit_reader)
15765 (build_type_psymtab_dependencies): Likewise.
15766 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15767
157682019-01-10 Tom Tromey <tom@tromey.com>
15769
15770 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15771 PSYMBOL_SET_LANGUAGE.
15772 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15773
157742019-01-10 Tom Tromey <tom@tromey.com>
15775
15776 * psymtab.h (psymtab_storage::obstack): New method.
15777 <m_obstack>: Rename from obstack; now private.
15778 * psymtab.c (psymtab_storage): Update.
15779 * dwarf2read.c (create_addrmap_from_index)
15780 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15781 Update.
15782
157832019-01-10 Tom Tromey <tom@tromey.com>
15784
15785 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15786 * objfiles.h (objfile::reset_psymtabs): New method.
15787
157882019-01-10 Tom Tromey <tom@tromey.com>
15789
15790 * symmisc.c (print_symbol_bcache_statistics): Update.
15791 (print_objfile_statistics): Update.
15792 * symfile.c (reread_symbols): Update.
15793 * psymtab.h (class psymtab_storage): New.
15794 * psymtab.c (psymtab_storage): New constructor.
15795 (~psymtab_storage): New destructor.
15796 (require_partial_symbols): Update.
15797 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15798 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15799 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15800 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15801 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15802 (start_psymtab_common, end_psymtab_common)
15803 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15804 (allocate_psymtab): Update.
15805 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15806 Update.
15807 (dump_psymtab_addrmap, maintenance_print_psymbols)
15808 (maintenance_check_psymtabs): Update.
15809 (class objfile_psymtabs): Move to objfiles.h.
15810 * psympriv.h (discard_psymtab): Now inline.
15811 (psymtab_discarder::psymtab_discarder): Update.
15812 (psymtab_discarder::~psymtab_discarder): Update.
15813 (ALL_OBJFILE_PSYMTABS): Rewrite.
15814 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15815 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15816 Remove fields.
15817 <partial_symtabs>: New field.
15818 (class objfile_psymtabs): Move from psymtab.h. Update.
15819 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15820 psymbol_cache.
15821 (objfile::~objfile): Don't destroy psymbol_cache.
15822 * mdebugread.c (parse_partial_symbols): Update.
15823 * dwarf2read.c (create_addrmap_from_index)
15824 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15825 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15826 (add_partial_subprogram, dwarf2_ranges_read): Update.
15827 * dwarf-index-write.c (write_address_map)
15828 (write_one_signatured_type, recursively_write_psymbols)
15829 (class debug_names, class debug_names, write_psymtabs_to_index):
15830 Update.
15831
158322019-01-10 Tom Tromey <tom@tromey.com>
15833
15834 * symtab.h (SYMBOL_SET_NAMES): Update.
15835 (symbol_set_names): Update.
15836 (MSYMBOL_SET_NAMES): Update.
15837 * symtab.c (symbol_set_names): Change argument to be an
15838 objfile_per_bfd_storage.
15839 * psymtab.c (add_psymbol_to_bcache): Update.
15840 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15841
158422019-01-10 Tom Tromey <tom@tromey.com>
15843
15844 * symtab.c (create_demangled_names_hash): Change argument to be an
15845 objfile_per_bfd_storage.
15846 (symbol_set_names): Update.
15847
158482019-01-10 Tom Tromey <tom@tromey.com>
15849
15850 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15851 init_psymbol_list.
15852 * psymtab.c (init_psymbol_list): Do nothing if already called.
15853 * psympriv.h (init_psymbol_list): Add comment.
15854 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15855 init_psymbol_list.
15856 * dbxread.c (dbx_symfile_read): Unconditionally call
15857 init_psymbol_list.
15858
158592019-01-10 Tom Tromey <tom@tromey.com>
15860
15861 * xcoffread.c (scan_xcoff_symtab): Update.
15862 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15863 "where".
15864 * mdebugread.c (parse_partial_symbols)
15865 (handle_psymbol_enumerators): Update.
15866 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15867 * dbxread.c (read_dbx_symtab): Update.
15868 * psympriv.h (psymbol_placement): New enum.
15869 (add_psymbol_to_list): Update.
15870
158712019-01-10 Tom Tromey <tom@tromey.com>
15872
15873 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15874 static_psymbols parameters.
15875 (scan_xcoff_symtab): Update.
15876 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15877 static_psymbols parameters.
15878 * psympriv.h (start_psymtab_common): Update.
15879 * mdebugread.c (parse_partial_symbols): Update.
15880 * dwarf2read.c (create_partial_symtab): Update.
15881 * dbxread.c (read_dbx_symtab): Update.
15882 (start_psymtab): Remove global_psymbols and static_psymbols
15883 parameters.
15884
158852019-01-10 Tom Tromey <tom@tromey.com>
15886
15887 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15888 * psymtab.c (allocate_psymtab): Add comment.
15889 * psympriv.h (allocate_psymtab): Add comment.
15890 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15891 initializations.
15892 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15893
158942019-01-10 Tom Tromey <tom@tromey.com>
15895
15896 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15897 Don't declare.
15898 * mipsread.c: Include mdebugread.h.
15899 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15900 Declare.
15901 * elfread.c: Include mdebugread.h.
15902
159032019-01-09 Tom Tromey <tom@tromey.com>
15904
15905 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15906 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15907 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15908 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15909 (psym_lookup_symbol, psym_find_last_source_symtab)
15910 (psym_forget_cached_source_info, psym_print_stats)
15911 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15912 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15913 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15914 (psym_find_compunit_symtab_by_address)
15915 (maintenance_print_psymbols, maintenance_info_psymtabs)
15916 (maintenance_check_psymtabs): Use ranged for.
15917 * psymtab.h (class objfile_psymtabs): New.
15918 (require_partial_symbols): Return objfile_psymtabs.
15919 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15920
159212019-01-09 Tom Tromey <tom@tromey.com>
15922
15923 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15924 (find_pc_mapped_section, list_overlays_command)
15925 (map_overlay_command, unmap_overlay_command)
15926 (simple_overlay_update): Use all_objfiles.
15927 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15928 * printcmd.c (info_symbol_command): Use all_objfiles.
15929 * objfiles.h (ALL_OBJSECTIONS): Remove.
15930 * maint.c (maintenance_translate_address): Use all_objfiles.
15931 * gcore.c (gcore_create_callback): Use all_objfiles.
15932 (objfile_find_memory_regions): Likewise.
15933
159342019-01-09 Tom Tromey <tom@tromey.com>
15935
15936 * symtab.c (find_line_symtab, info_sources_command)
15937 (make_source_files_completion_list): Use objfile_compunits.
15938 * source.c (select_source_symtab): Use objfile_compunits.
15939 * objfiles.h (struct objfile): Update comment.
15940 (ALL_OBJFILES): Remove.
15941 (ALL_FILETABS): Remove.
15942 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15943 objfile_compunits.
15944
159452019-01-09 Tom Tromey <tom@tromey.com>
15946
15947 * symmisc.c (print_objfile_statistics, dump_objfile)
15948 (maintenance_print_symbols): Use compunit_filetabs.
15949 * source.c (forget_cached_source_info_for_objfile): Use
15950 compunit_filetabs.
15951 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15952 (ALL_FILETABS): Use compunit_filetabs.
15953 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15954 * coffread.c (coff_symtab_read): Use compunit_filetabs.
15955
159562019-01-09 Tom Tromey <tom@tromey.com>
15957
15958 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15959 (compunit_filetabs): New.
15960 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15961 compunit_filetabs.
15962 (info_sources_command, make_source_files_completion_list): Remove
15963 declaration.
15964 * symmisc.c (print_objfile_statistics, dump_objfile)
15965 (maintenance_print_symbols): Remove declaration.
15966 (maintenance_info_symtabs): Use compunit_filetabs.
15967 (maintenance_info_line_tables): Likewise.
15968 * source.c (select_source_symtab): Change local variable name.
15969 (forget_cached_source_info_for_objfile): Remove declaration.
15970 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15971 * objfiles.c (objfile_relocate1): Remove declaration.
15972 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15973 declaration.
15974 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15975 * coffread.c (coff_symtab_read): Remove declaration.
15976 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15977 compunit_filetabs.
15978
159792019-01-09 Tom Tromey <tom@tromey.com>
15980
15981 * symtab.c (lookup_objfile_from_block)
15982 (find_pc_sect_compunit_symtab, search_symbols)
15983 (default_collect_symbol_completion_matches_break_on): Use
15984 objfile_compunits.
15985 * objfiles.h (ALL_COMPUNITS): Remove.
15986 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15987 * cp-support.c (add_symbol_overload_list_qualified): Use
15988 objfile_compunits.
15989 * ada-lang.c (ada_collect_symbol_completion_matches)
15990 (ada_add_global_exceptions): Use objfile_compunits.
15991
159922019-01-09 Tom Tromey <tom@tromey.com>
15993
15994 * source.c (select_source_symtab)
15995 (forget_cached_source_info_for_objfile): Remove declaration.
15996 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15997 declaration.
15998 * maint.c (count_symtabs_and_blocks): Remove declaration.
15999 * cp-support.c (add_symbol_overload_list_qualified): Remove
16000 declaration.
16001 * coffread.c (coff_symtab_read): Remove declaration.
16002 * symtab.c (lookup_symbol_in_objfile_symtabs)
16003 (basic_lookup_transparent_type_1): Use objfile_compunits.
16004 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16005 (info_sources_command, search_symbols)
16006 (default_collect_symbol_completion_matches_break_on)
16007 (make_source_files_completion_list): Remove declaration.
16008 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16009 (ada_collect_symbol_completion_matches)
16010 (ada_add_global_exceptions): Remove declaration.
16011 * linespec.c (iterate_over_all_matching_symtabs): Use
16012 objfile_compunits.
16013 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16014 (class objfile_compunits): New.
16015 (ALL_COMPUNITS): Use objfile_compunits.
16016 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16017 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16018 objfile_compunits.
16019 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16020
160212019-01-09 Tom Tromey <tom@tromey.com>
16022
16023 * symtab.c (search_symbols)
16024 (default_collect_symbol_completion_matches_break_on): Use
16025 objfile_msymbols.
16026 * ada-lang.c (ada_lookup_simple_minsym)
16027 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16028 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16029 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16030 objfile_msymbols.
16031 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16032 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16033 * objc-lang.c (find_methods): Use objfile_msymbols.
16034 (info_selectors_command, info_classes_command): Likewise.
16035 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16036 * objfiles.h (class objfile_msymbols): New.
16037 (ALL_OBJFILE_MSYMBOLS): Remove.
16038 (ALL_MSYMBOLS): Remove.
16039
160402019-01-09 Tom Tromey <tom@tromey.com>
16041
16042 * common/next-iterator.h (next_adapter): Add Iterator template
16043 parameter.
16044 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16045 (class all_objfiles_safe): New.
16046 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16047 * objfiles.c (put_objfile_before): Update comment.
16048 (add_separate_debug_objfile): Likewise.
16049 (free_all_objfiles): Use all_objfiles_safe.
16050 (objfile_purge_solibs): Likewise.
16051
160522019-01-09 Tom Tromey <tom@tromey.com>
16053
16054 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16055 (expand_symtab_containing_pc, lookup_static_symbol)
16056 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16057 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16058 all_objfiles.
16059 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16060 * breakpoint.c (create_overlay_event_breakpoint)
16061 (create_longjmp_master_breakpoint)
16062 (create_std_terminate_master_breakpoint)
16063 (create_exception_master_breakpoint): Use all_objfiles.
16064 * linux-thread-db.c (try_thread_db_load_from_pdir)
16065 (has_libpthread): Use all_objfiles.
16066 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16067 * linespec.c (iterate_over_all_matching_symtabs)
16068 (search_minsyms_for_name): Use all_objfiles.
16069 * maint.c (maintenance_info_sections): Use all_objfiles.
16070 * main.c (captured_main_1): Use all_objfiles.
16071 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16072 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16073 * guile/scm-pretty-print.c
16074 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16075 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16076 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16077 (maintenance_print_msymbols): Use all_objfiles.
16078 * source.c (select_source_symtab): Use all_objfiles.
16079 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16080 * symfile.c (remove_symbol_file_command)
16081 (expand_symtabs_matching, map_symbol_filenames): Use
16082 all_objfiles.
16083 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16084 all_objfiles.
16085 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16086 * objc-lang.c (find_methods): Use all_objfiles.
16087 * objfiles.c (have_partial_symbols, have_full_symbols)
16088 (have_minimal_symbols, qsort_cmp)
16089 (default_iterate_over_objfiles_in_search_order): Use
16090 all_objfiles.
16091 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16092 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16093 (maintenance_check_psymtabs): Use all_objfiles.
16094 (ALL_PSYMTABS): Remove.
16095 * compile/compile-object-run.c (do_module_cleanup): Use
16096 all_objfiles.
16097 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16098 * cp-support.c (add_symbol_overload_list_qualified): Use
16099 all_objfiles.
16100 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16101 Use all_objfiles.
16102 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16103 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16104 all_objfiles.
16105 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16106 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16107 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16108 Uses all_objfiles.
16109 * solib.c (solib_read_symbols): Use all_objfiles
16110
161112019-01-09 Tom Tromey <tom@tromey.com>
16112
16113 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16114 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16115 all_objfiles.
16116 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16117 * symmisc.c (print_symbol_bcache_statistics)
16118 (print_objfile_statistics, maintenance_print_objfiles)
16119 (maintenance_info_symtabs, maintenance_check_symtabs)
16120 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16121 all_objfiles.
16122 * source.c (forget_cached_source_info): Use all_objfiles.
16123 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16124 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16125 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16126 * objfiles.c (update_section_map): Use all_objfiles.
16127 (shared_objfile_contains_address_p): Likewise.
16128 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16129 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16130
161312019-01-09 Tom Tromey <tom@tromey.com>
16132
16133 * common/next-iterator.h: New file.
16134 * objfiles.h (class all_objfiles): New.
16135 (struct objfile_iterator): New.
16136
161372019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16138
16139 * NEWS: Move the description of the changed "frame", "select-frame",
16140 and "info frame" commands to the Changed commands section.
16141
161422019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16143
16144 * gdbtypes.c (check_stub_method_group): Remove handling of old
16145 mangling schemes.
16146 * linespec.c (find_methods): Likewise.
16147 * stabsread.c (read_member_functions): Likewise.
16148 * valops.c (search_struct_method): Likewise.
16149 (value_struct_elt_for_reference): Likewise.
16150 * NEWS: Mention this change.
16151
161522019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16153
16154 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16155 print_source_lines.
16156 * source.c (print_source_lines_base): Update line number check.
16157 (print_source_lines): New function.
16158 (source_lines_range::source_lines_range): New function.
16159 * source.h (class source_lines_range): New class.
16160 (print_source_lines): New declaration.
16161
161622019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16163
16164 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16165
161662019-01-08 Tom Tromey <tom@tromey.com>
16167 Simon Marchi <simon.marchi@ericsson.com>
16168
16169 PR gdb/24060
16170 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16171 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16172 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16173 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16174 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16175 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16176
161772019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16178
16179 * source.c (select_source_symtab): Move header comment to
16180 declaration in source.h.
16181 (forget_cached_source_info_for_objfile): Likewise.
16182 (forget_cached_source_info): Likewise.
16183 (identify_source_line): Likewise.
16184 * source.h (identify_source_line): Move declaration from symtab.h
16185 and add comment from source.c
16186 (print_source_lines): Likewise.
16187 (forget_cached_source_info_for_objfile): Likewise.
16188 (forget_cached_source_info): Likewise.
16189 (select_source_symtab): Likewise.
16190 (enum print_source_lines_flag): Move definition from symtab.h.
16191 * symtab.h (identify_source_line): Move declaration to source.h.
16192 (print_source_lines): Likewise.
16193 (forget_cached_source_info_for_objfile): Likewise.
16194 (forget_cached_source_info): Likewise.
16195 (select_source_symtab): Likewise.
16196 (enum print_source_lines_flag): Move definition to source.h.
16197 * tui/tui-hooks.c: Add 'source.h' include.
16198
161992019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16200
16201 * source.c (print_source_lines_base): Handle requests to print
16202 reverse line number sequences, and guard against empty lines
16203 string.
16204
162052019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16206
16207 * source.c (print_source_lines_base): Fix skip of '\r' if next
16208 character is '\n'.
16209
162102019-01-06 Tom Tromey <tom@tromey.com>
16211
16212 * c-exp.y (struct c_parse_state) <macro_original_text,
16213 expansion_obstack>: New member.
16214 (macro_original_text, expansion_obstack): Remove globals.
16215 (scan_macro_expansion, scanning_macro_expansion)
16216 (finished_macro_expansion): Update.
16217 (scan_macro_cleanup): Remove.
16218 (yylex, c_parse): Update.
16219
162202019-01-06 Tom Tromey <tom@tromey.com>
16221
16222 * c-exp.y (struct c_parse_state) <strings>: New member.
16223 (operator_stoken): Update.
16224
162252019-01-06 Tom Tromey <tom@tromey.com>
16226
16227 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16228 (union type_stack_elt) <typelist_val>: Now a pointer to
16229 std::vector.
16230 (type_stack_cleanup): Don't declare.
16231 (push_typelist): Update.
16232 * parse.c (pop_typelist): Return a std::vector.
16233 (push_typelist): Take a std::vector.
16234 (follow_types): Update. Do not free args.
16235 (type_stack_cleanup): Remove.
16236 * c-exp.y (struct c_parse_state): New.
16237 (cpstate): New global.
16238 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16239 (nonempty_typelist): Update.
16240 (func_mod): Create a new vector.
16241 (c_parse): Create a c_parse_state.
16242 (check_parameter_typelist): Do not delete params.
16243 (function_method): Update. Do not delete type_list.
16244
162452019-01-06 Tom Tromey <tom@tromey.com>
16246
16247 PR gdb/28155:
16248 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16249 check_typedef.
16250 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16251 (print_return_value): Likewise.
16252
162532019-01-05 Tom Tromey <tom@tromey.com>
16254
16255 * contrib/cleanup_check.py: Remove.
16256 * contrib/gcc-with-excheck: Remove.
16257 * contrib/exsummary.py: Remove.
16258 * contrib/excheck.py: Remove.
16259
162602019-01-05 Joel Brobecker <brobecker@adacore.com>
16261
16262 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16263 NULL. Initialize tpprev to NULL instead of assigning it
16264 to NULL on the next statement.
16265 * windows-nat.c (windows_delete_thread): Remove check for
16266 main_thread_id before printing thread exit notifications.
16267 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16268 Remove thread ID check against main_thread_id.
16269 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16270 windows_delete_thread.
16271 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16272
162732019-01-04 Tom Tromey <tom@tromey.com>
16274
16275 * compile/compile.c (_initialize_compile): Use upper case for
16276 metasyntactic variables.
16277 * symmisc.c (_initialize_symmisc): Use upper case for
16278 metasyntactic variables.
16279 * psymtab.c (_initialize_psymtab): Use upper case for
16280 metasyntactic variables.
16281 * demangle.c (demangle_command): Use upper case for metasyntactic
16282 variables.
16283 (_initialize_demangler): Likewise.
16284 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16285 variables.
16286
162872019-01-03 Tom Tromey <tom@tromey.com>
16288
16289 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16290
162912019-01-03 Tom Tromey <tom@tromey.com>
16292
16293 * python/py-symtab.c (salpy_str): Update.
16294 (struct salpy_sal_object) <symtab>: Now a PyObject.
16295 (salpy_dealloc): Update.
16296 (del_objfile_sal): Use gdbpy_ref.
16297
162982019-01-03 Tom Tromey <tom@tromey.com>
16299
16300 * python/py-type.c (convert_field): Use new_reference. Return
16301 gdbpy_ref.
16302 (make_fielditem): Return gdbpy_ref.
16303 (typy_fields): Update.
16304 (typy_getitem): Update.
16305 (field_name): Return gdbpy_ref. Use new_reference.
16306 (typy_iterator_iternext): Update.
16307
163082019-01-03 Tom Tromey <tom@tromey.com>
16309
16310 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16311
163122019-01-03 Tom Tromey <tom@tromey.com>
16313
16314 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16315 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16316 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16317 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16318 (pspy_set_type_printers): Likewise.
16319 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16320 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16321 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16322 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16323 (objfpy_set_type_printers): Likewise.
16324
163252019-01-03 Tom Tromey <tom@tromey.com>
16326
16327 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16328 (gdbpy_print_stack): Use gdbpy_err_fetch.
16329 * python/python-internal.h (class gdbpy_err_fetch): New class.
16330 (class gdbpy_enter) <m_error_type, m_error_value,
16331 m_error_traceback>: Remove.
16332 <m_error>: New member.
16333 (gdbpy_exception_to_string): Don't declare.
16334 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16335 * python/py-value.c (convert_value_from_python): Use
16336 gdbpy_err_fetch.
16337 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16338 gdbpy_exception_to_string.
16339 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16340 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16341 gdbpy_err_fetch.
16342
163432019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16344
16345 * linux-nat.c (delete_lwp_cleanup): Delete.
16346 (struct lwp_deleter): New struct.
16347 (lwp_info_up): New typedef.
16348 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16349 lwp_info_up.
16350
163512019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16352
16353 * linux-fork.c (class scoped_switch_fork_info): New class.
16354 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16355
163562019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16357
16358 * valops.c (find_overload_match): Remove use of null_cleanup, and
16359 calls to do_cleanups.
16360
163612019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16362
16363 * compile/compile-cplus-types.c
16364 (compile_cplus_instance::decl_name): Handle changes to
16365 cp_func_name.
16366 * cp-support.c (cp_func_name): Update header comment, update
16367 return type.
16368 * cp-support.h (cp_func_name): Update return type in declaration.
16369 * valops.c (find_overload_match): Move temp_func local to top
16370 level of function and change its type. Use temp_func to hold and
16371 delete temporary string obtained from cp_func_name.
16372
163732019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16374
16375 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16376 gdb::char_vector, remove cleanup, and update uses of `msg`.
16377
163782019-01-03 Jim Wilson <jimw@sifive.com>
16379
16380 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16381
163822019-01-02 Tom Tromey <tom@tromey.com>
16383
16384 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16385 (tdesc_parse_xml): Remove cleanups.
16386 * target-descriptions.h (make_cleanup_free_target_description):
16387 Don't declare.
16388 (target_desc_deleter): New struct.
16389 (target_desc_up): New typedef.
16390 * target-descriptions.c (target_desc_deleter::operator()): Rename
16391 from free_target_description.
16392 (make_cleanup_free_target_description): Remove.
16393
163942019-01-02 Tom Tromey <tom@tromey.com>
16395
16396 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16397 constructor, destructor.
16398 (linespec_parser): Remove typedef.
16399 (~linespec_parser): Rename from linespec_parser_delete.
16400 (linespec_lex_to_end, linespec_complete_label)
16401 (linespec_complete): Update.
16402 (decode_line_full): Remove cleanups.
16403 (decode_line_1): Update.
16404
164052019-01-02 Tom Tromey <tom@tromey.com>
16406
16407 * python/python-internal.h (inferior_to_inferior_object): Change
16408 return type.
16409 * python/py-exitedevent.c (create_exited_event_object): Update.
16410 * python/py-inferior.c (inferior_to_inferior_object): Return
16411 gdbpy_ref.
16412 (python_new_inferior, python_inferior_deleted)
16413 (thread_to_thread_object, delete_thread_object)
16414 (build_inferior_list, gdbpy_selected_inferior): Update.
16415 * python/py-infthread.c (create_thread_object): Update. Also fail
16416 if inferior_to_inferior_object fails.
16417
164182019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16419
16420 * inferior.h (class inferior) <displaced_step_state>: New field.
16421 * infrun.h (struct displaced_step_state): Move here from
16422 infrun.c. Initialize fields, add constructor.
16423 <inf>: Remove field.
16424 <reset>: New method.
16425 * infrun.c (struct displaced_step_inferior_state): Move to
16426 infrun.h.
16427 (displaced_step_inferior_states): Remove.
16428 (get_displaced_stepping_state): Adust.
16429 (displaced_step_in_progress_any_inferior): Adjust.
16430 (displaced_step_in_progress_thread): Adjust.
16431 (displaced_step_in_progress): Adjust.
16432 (add_displaced_stepping_state): Remove.
16433 (get_displaced_step_closure_by_addr): Adjust.
16434 (remove_displaced_stepping_state): Remove.
16435 (infrun_inferior_exit): Call displaced_step_state.reset.
16436 (use_displaced_stepping): Don't check for NULL.
16437 (displaced_step_prepare_throw): Call
16438 get_displaced_stepping_state.
16439 (displaced_step_fixup): Don't check for NULL.
16440 (prepare_for_detach): Don't check for NULL.
16441
164422019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16443
16444 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16445 in case of call that did not complete.
16446
164472019-01-02 Andrey Utkin <autkin@undo.io>
16448
16449 * symfile.c (find_separate_debug_file): Fix search of debug files for
16450 remote debuggee.
16451
164522019-01-02 Tom Tromey <tom@tromey.com>
16453
16454 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16455 indentation.
16456 * python/py-frame.c (frapy_older): Remove cast.
16457 (frapy_newer): Likewise.
16458 * python/py-breakpoint.c (local_setattro): Remove cast.
16459 * python/py-arch.c (archpy_name): Remove local variable.
16460 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16461
164622019-01-02 Joel Brobecker <brobecker@adacore.com>
16463
16464 * unittests/basic_string_view/element_access/char/empty.cc:
16465 Fix year range in copyright header.
16466
164672019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16468
16469 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16470 Delete.
16471 <operator==>: Update with for removed field.
16472 <hash>: Likewise.
16473 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16474 <isa_features>: ...this.
16475 <abi_features>: New field.
16476 (riscv_isa_flen): Update comment.
16477 (riscv_abi_xlen): New declaration.
16478 (riscv_abi_flen): New declaration.
16479 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16480 isa_features.
16481 (riscv_abi_xlen): New function.
16482 (riscv_isa_flen): Update to get answer from isa_features.
16483 (riscv_abi_flen): New function.
16484 (riscv_has_fp_abi): Update to get answer from abi_features.
16485 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16486 xlen and flen.
16487 (riscv_call_info) <xlen, flen>: Update comment.
16488 (riscv_call_arg_struct): Remove invalid assertions
16489 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16490 is removed.
16491 (riscv_gdbarch_init): Gather isa features and abi features
16492 separately, ensure both match on the gdbarch when reusing an old
16493 gdbarch. Relax an error check to allow 32-bit abi float to run on
16494 a target with 64-bit float hardware.
16495
164962019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16497
16498 * source.c (search_command_helper): Stop reverse search
16499 when line 1 has been searched.
16500
165012019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16502
16503 * record-full.c (record_full_base_target::close): Rewrite
16504 record_full_core_buf_list free logic.
16505
165062019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16507
16508 * break-catch-syscall.c (print_one_catch_syscall): xfree
16509 the last text.
16510
165112019-01-01 Joel Brobecker <brobecker@adacore.com>
16512
16513 * top.c (print_gdb_version): Update Copyright year in version
16514 message.
16515
165162019-01-01 Joel Brobecker <brobecker@adacore.com>
16517
16518 Update copyright year range in all GDB files.
16519
165202019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16521
16522 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16523
16524For older changes see ChangeLog-2018.
16525\f
16526Local Variables:
16527mode: change-log
16528left-margin: 8
16529fill-column: 74
16530version-control: never
16531coding: utf-8
16532End:
16533
GDB Binutils - Deliverables
This page took 0.083516 seconds and 4 git commands to generate.