bfd/ChangeLog

   1 Thu May 30 15:30:10 1991  Steve Chamberlain  (steve at cygint.cygnus.com)
   2
   3         *../include/i386coff.h : fixed typo in type field with size
   4
   5         * i386coff.c icoff.c m88k-bcs.c ecoff.c ../include/bfd.h : Added
   6         support in the jump table for the swapping routines exported to
   7         gdb. Now gdb works with the 386.
   8
   9 Tue May 28 17:21:43 1991  John Gilmore  (gnu at cygint.cygnus.com)
  10
  11         * Merge in changes from gdb-3.95 release.
  12         Makefile.in:  Allow hmake and tmake files to add OFILES.
  13         aoutf1.h:
  14         bfd.c:  support specific targets as well as searching.  When
  15         searching, take default target in preference to others.
  16         bfd.doc:  typos
  17         ieee.c, oasys.c:  Avoid using the "tdata" macros left of assignment.
  18         liba.out.h:  Don't hard-code file offsets; use N_ macros for them.
  19         libbfd.h:  Support specific targets as well as searching.
  20         opncls.c:  Support specific targets as well as searching.
  21         targets.c:  Search is short-circuited if default target matches.
  22         liboasys.c, libieee.c:  Undo bothner changes that make macros
  23         work to the left of assignment, but which depend on the
  24         representations of different pointer types being the same.
  25
  26 Fri May 24 18:56:52 1991  Steve Chamberlain  (steve at cygint.cygnus.com)
  27
  28         * i386coff.c: created.
  29         * coffcode.h: added support for 386.
  30         * Makefile.in: added support for 386.
  31         * ../include/i386coff.h: created
  32
  33 Wed May 22 07:26:38 1991  Steve Chamberlain  (steve at cygint.cygnus.com)
  34
  35         * libbfd.c: Changed #ifdef __GNUC__ to #ifdef HOST_64_BIT, Added
  36         DEFUNS
  37
  38
  39 Tue May 21 08:58:58 1991  Steve Chamberlain  (steve at cygint.cygnus.com)
  40         (bothner)
  41         * opncls.c: Changed obstack_chunk_alloc use xmalloc
  42
  43 Mon May 20 17:12:17 1991  Steve Chamberlain  (steve at cygint.cygnus.com)
  44
  45         * everything: Removed sysdep.h from bfd.h and put back into files
  46         from which it was split out. Now 64 bit version is built with a
  47         -DHOST_64_BIT="long long" on the compile line.
  48
  49
  50 Fri May 17 19:35:26 1991  Steve Chamberlain  (steve at cygint.cygnus.com)
  51
  52         Changed all the [get|put][name] routines to use  [get|put]_[size
  53         in bytes].
  54
  55         Put in support for 64 bit work. Now two versions of bfd may be
  56         generated, according to the state of TARGET_64_BIT, one which is
  57         32 bit only, and one which is 64/32 bits.
  58         Created new back end 'demo64' to test 64 bit functionality.
  59
  60         Renamed some files to work on DOS.
  61
  62         * archive.c: lint * bfd.c: prototypes and lint. * ecoff.c: added
  63         64bit transfer  * icoff.c: added 64bit transfer * ieee.c: name
  64         chage, 64 bit transfer. * liba.out.h: Split out common code from
  65         sunos and newsos into liba.out. Name changes and prototype mods. *
  66         libbfd.c: lint and prototypes, extra 64bit swaps. * libbfd.h:
  67         prototypes for new functions. * libcoff.h: lint * libieee.h: make
  68         work on DOS * liboasys.h: make work on DOS * m88k-bcs.c: Name
  69         change and 64bit stuff.* newsos3.c: common code removed, new jump
  70         table. * oasys.c: Name change * opncls.c: Portability fixes *
  71         srec.c: Name changes * sunos.c: Removed comon code. * targets.c:
  72         Added demo * aout32, aout64.c include  aoutx.h * bout.c: used to
  73         be called b.out.c * coffcode.h: used to be called coff-code.h, now
  74         64bit ized. * demo64.c: 64 bit a.out back end
  75
  76
  77
  78
  79
  80 Thu May 16 16:02:07 1991  Steve Chamberlain  (steve at cygint.cygnus.com)
  81         from bothner
  82         * libieee.h: Make ieee_data and ieee_ar_data macros usable
  83         on LHS of assignment, even when using old compilers.
  84         * liboasys.h: Ditto for oasys_data and oasys_ar_data.
  85         * m68kcoff.c: Add enum-to-int casts to accomodate old compilers.
  86         * newsos3.c: Fix definitions of SEGMENT_SIZE and TEXT_START_ADDR.
  87         * opncls.c: Define S_IXUSR, S_IXGRP, S_IXOTH if undefined.
  88         * targets.c: Add declaration of newsos3_vec.
  89
  90
  91 Mon May 13 10:03:29 1991  Steve Chamberlain  (steve at cygint.cygnus.com)
  92
  93         * aout.c: fixxed some of the problems with filepos calculation.
  94         (swap_ext_reloc): fixed problem with creation of relocs.
  95         (aout_set_section_contents): fixed filepos problem
  96
  97         * coff-code.h: (swap_filehdr_in, swap_filehdr_out) add.
  98         (swap_filehdr) delete. Changed all the usage of bfd_h_put_x.
  99         (swap_aouthdr_in, swap_aouthdr_out) add. (swap_aouthdr) delete.
 100         (coff_real_object_p) cleaned up, added MIPS. (coff_object_p)
 101         cleaned up. (coff_write_object_contents) cleaned up.
 102
 103         * ecoff.c: Totally different. Now supports ecoff fully.
 104
 105         * icoff.c: fixed problems in relocation callout.
 106
 107         * libcoff.h: (struct icofdata) removed hdr structure from tdata.
 108
 109         * m68kcoff.c: updated target vector.
 110
 111         * sunos.c: (choose_reloc_size) added: (sunos4_callback) calls
 112         choose_reloc_size. (sunos4_write_object_contents) now calls
 113         choose_reloc_size so outputs relocs correctly, also calculates the
 114         size of the sections correctly.
 115
 116
 117
 118 Fri May 10 16:58:53 1991  John Gilmore  (gnu at cygint.cygnus.com)
 119
 120         Merge Per Bothner's changes to modularize BFD a.out a bit.
 121
 122         * libbfd.h, libbfd.c (bfd_generic_get_section_contents):  Add.
 123         * ieee.c:  Cast enums to int before comparing them, for brain-
 124         dead compilers.
 125         * coff-code.h:  Remove coff_get_section_contents, and use the
 126         generic one instead.
 127
 128         * aout.c:  Derive new module from sunos.c, containing generic
 129         support code for all kinds of a.out files.
 130
 131         * sunos.c: Remove all code that goes in aout.c.  Split out
 132         machine dependent followup in sunos4_object_p into
 133         sunos4_callback.  Use JUMP_TABLE(aout) for the transver vector,
 134         and redefine only the names we CHANGE, not all the names.  Drop
 135         the little-endian vector, and rename the vector as sunos4 rather
 136         than generic.
 137
 138         * b.out.c:  Use aout.c routines for most of the work.  Slight
 139         changes for the new regime.  Remove close_and_cleanup and
 140         get_section_contents in favor of generics.  New transfer vector
 141         regime.
 142
 143         * newsos.c:  New support for Sony NEWS, another a.out format.
 144
 145         * ecoff.c:  Remove close_and_cleanup.  New tvec regime.
 146         * icoff.c, m88k-bcs.c:  Add write_contents to tvec.
 147         * ieee.c, oasys.c:  Remove close_and_cleanup, add write_contents
 148         to tvec.
 149         * opncls.c (bfd_close):  Call format-dependent write_contents
 150         routine, if writing, before calling target-dependent
 151         close_and_cleanup routine (which is now always generic, I think).
 152         * srec.c:  Use bfd_alloc instead of malloc.  Remove
 153         close_and_cleanup and move code from it to
 154         srec_write_object_contents.  Add write_contents to tvec.
 155         * targets.c:  Remove a.out little vector, replace a.out big
 156         vector with SunOS vector.  FIXME:  Need Vax support again now.
 157
 158         * libbfd.h:  Add write_contents format-dependent-vector to the
 159         bfd_target vector.  Supply a generic close_and_cleanup routine.
 160         * liba.out.h:  Handle the new aout.c split.  Add prototypes for
 161         all routines defined in aout.c.  Rename "sunos" things to "aout"
 162         things.  Add a few fields where needed for various formats.
 163         * Makefile.in:  Add aout.c and newsos.c.
 164
 165         * archive.c, ieee.c, oasys.c:  Lint.
 166
 167 Fri May 10 12:34:48 1991  Steve Chamberlain  (steve at cygint.cygnus.com)
 168
 169         * ../include/bfd.h
 170         changed forward declaration struct stat; to reduce warnings. Changed
 171         comment on bfd_h_<x>_x.
 172
 173         * ../include/m68kcoff.h, ../include/intel-coff.h,
 174         ../include/m88k-bcs.h
 175         Now there are two incarnations of relocs, linenos and syments. One for
 176         internal digestion, and one full of char arrays for I/O. The original
 177         names have gone to detect errors.
 178
 179         * Makefile.in, m68kcoff.c, targets.c
 180         Test new structure code with a 68k coff implementaion
 181
 182         * coff-code.h, icoff.c, coffswap.c, libcoff.h
 183         Fixed all the places where there were problems with the size and
 184         alignments of structures on disk and structures in memory. #ifed out
 185         all the code in coffswap.c, since it should be done using the target
 186         swap routines now.
 187
 188 Thu May  9 11:00:45 1991  Steve Chamberlain  (steve at cygint.cygnus.com)
 189
 190         * ieee.c (do_one, ieee_slurp_section_data): now supports the load
 191         multiple reloc command.
 192
 193         * sunos.c (sunos4_set_section_contents): Made it so that sections
 194         are always padded to their alignment size.
 195
 196 Sat May  4 15:49:43 1991  John Gilmore  (gnu at cygint.cygnus.com)
 197
 198         * archive.c, bfd.c, coff-code.h, opncls.c, sunos.c, trad-core.c:
 199         Clean up types and such (saber C problems).
 200         * ecoff.c:  Clean up types and such.  Remove routines that are
 201         not used.  Fix up reading and swapping of shorts from files.
 202
 203    Notes on bfd-0.5.2-patch1a, from Per Bothner:
 204
 205         * a.out.vax.c: Remove two bogus "static" from prototypes.
 206
 207         * ecoff.c: Got rid of lots of non-working junk (that had
 208         been copied directly from coff-code.h).
 209         Updated to be consistent with updates to icoff.c and coff-code.h.
 210
 211         * libbfd.h: Added definitions for S_IXUSR, S_IXGRP, and S_IXOTH
 212         if they're missing (as they are in (BDS-4.3-based) NewsOS-3).
 213
 214         * sunos.c (n_txtoff): (Re-)Add support for sony. This is a kludge,
 215         but until the target_vector is automatically generated,
 216         it's as good as any. Note that the text offset is the only
 217         difference between NewsOS and SunOs (including magic numbers).
 218         (Most of the sunos_* routines should to renamed bsd_*
 219         and move to a bsd.c file. Then (and when the target_vector
 220         is automatically generated) it might make sense to create
 221         a separate Sony target.)
 222
 223         * sysdep.h: Don't declare fread and fwrite. Causes trouble
 224         on some systems, and doesn't help on others.
 225         Similarly, only define X_OK if not already defined.
 226
 227         * trad-core.c: Don't include sys/stat.h - at least
 228         on NewsOS 3, it has already been included.
 229
 230 Tue Mar  5 01:47:57 1991  John Gilmore  (gnu at cygint.cygnus.com)
 231
 232         * coff-code.h (bfd_coff_swap_sym, bfd_coff_swap_aux,
 233         bfd_coff_swap_lineno):  Export the routines that byte-swap COFF
 234         symbol tables if necessary when reading them in, so gdb can use
 235         them.  Add "bfd_coff_" to the names so they won't conflict with
 236         names in calling programs.  FIXME-soon:  if coff-code.h is
 237         included in two BFD modules, this will cause duplicate
 238         definitions; the routines should be exported to a separate,
 239         common, module (probably along with a mess of other ones).
 240
 241 Sat Mar  2 12:11:26 1991  John Gilmore  (gnu at cygint.cygnus.com)
 242
 243         Improve modtime support.
 244
 245         * bfd.h:  Add boolean mtime_set, and declare bfd_get_mtime.
 246         Remove #define for bfd_get_mtime.  Remove gratuitous comment.
 247         * bfd.c (bfd_get_mtime):  New fn, caches mtime, gets if not cached.
 248         BUG:  archive members still do not get correct mod times.
 249
 250         Improve floating point support for core files.
 251
 252         * sunos.c (struct core):  Change void *fpa_dummy to double fp_stuff.
 253         (sunos4_core_file_p):  Create a second registers section in the
 254         core file, called ".reg2", for the float registers.
 255
 256 Thu Feb 14 15:49:06 1991  Gumby Vinayak Wallace  (gumby at cygint.cygnus.com)
 257
 258         * many changes to improve archive handling; found a logic flaw in
 259           bfd_check_format which only just happened to work by cooncidence.
 260
 261 Thu Feb 14 07:53:16 1991  Steve Chamberlain  (steve at cygint.cygnus.com)
 262
 263         * bfd.c (bfd_perform_relocation): fixed to use output_offsets
 264         correctly.
 265
 266         * bfd.h: changed type of udata in asymbol to void *, like it
 267         should be. Added bfd_reloc_dangerous enum member.
 268
 269         * coff-code.h: Fixed it so that internally generated symbols get
 270         their values relocated correctly in all cases. Removed calls to
 271         xmalloc.
 272
 273         * icoff.c: Not understanding the destination symbol of a reloc is
 274         not a failure any more, just 'dangerous'. This allows linking of
 275         b.out and coff images.
 276
 277         * sunos.c: Cleaned up the way that ZMAGIC section sizes are
 278         calculated.
 279
 280
 281 Tue Feb 12 13:25:46 1991  Steve Chamberlain  (steve at cygint.cygnus.com)
 282
 283         * sunos.c (translate_to_native_sym_flags): fixed
 284         sym_pointer->n_value so that symbols on the way out get their
 285         section relative values calculated correctly.
 286
 287         * coff-code.h (mangle_symbols): fixed problem where tags were not
 288         being relocated for structs, enums, unions. Also various lints.
 289
 290 Mon Feb 11 19:52:26 1991  Gumby Vinayak Wallace  (gumby at cygint.cygnus.com)
 291
 292         * archive.c (get_elt_at_filepos): system_call_error returned
 293           incorrectly.
 294
 295 Sun Feb 10 23:18:40 1991  Gumby Vinayak Wallace  (gumby at cygint.cygnus.com)
 296
 297         * Resolve the use of no_error and system_call_error.
 298           The bfd library itself now will never set bfd_error to
 299           no_error.
 300
 301           The code still needs to be combed to make sure all the error
 302           codes are correct.  I suspect they are not always set correctly.
 303
 304         * The names of all the messages have _ prepended because the sun
 305           bundled compiler can't distinguish from a macro which takes an
 306           argument and the same identifier in a non-macro context.
 307
 308         * The reason for the above being that entry points which used to
 309           be trampoline functions are now just macros which expand to a
 310           direct call through the bfd's xfer vector.
 311
 312         * (../include/intel-coff.h) F_AR32WR: fix this constant.  Why
 313           must gas have its own version of everything (the gas version
 314           had the correct value)
 315
 316 Tue Feb  5 11:46:53 1991  Steve Chamberlain  (steve at cygint.cygnus.com)
 317
 318         * b.out.c: Added patches supplied by chrisb@mipon2.intel.com to
 319         properly support i960 architecture and output correct reloc stuff.
 320
 321         * bfd.h: added prototype for bfd_printable_arch_mach, added
 322         BFD_FAIL
 323
 324         * coff-code.h: Applied patches from chrisb to support i960
 325         architecture, zero relocs and swap them correcly and conditionally
 326         compiled the timestamp.
 327
 328         * sunos.c: Made the default section alignment 2^3 so that doubles
 329         are done properly. Fixed the same reloc bug that was in b.out.c
 330
 331         * sysdep.h: Now compiles on a Posix box
 332
 333 Wed Jan 30 21:36:26 1991  John Gilmore  (gnu at cygint.cygnus.com)
 334
 335         * icoff.c:  Fix comment on big-endian version.
 336         * coff-code.h:  Make HAS_RELOC really work (it's backwards from
 337         F_RELFLG).  Set F_AR32WR in output files if little endian
 338         architecture.
 339
 340 Tue Jan 29 20:56:10 PST 1991 steve@cygnus.com
 341
 342         * archures.c fixed =/== typo
 343
 344         * sunos.c added architecture stuff for output. Fixed
 345         bug where files where vma(data) != size(text)
 346         were processed wrong.
 347
 348         * coff-code.h added a lint cast
 349
 350         * (../include/a.out.sun4.h) fixed it so zmagic
 351         worked
 352
 353 Mon Jan 28 19:15:29 PST 1991 steve@cygnus.com
 354
 355         * archive.c removed loads of includes, and fixed bug where string
 356         table didn't have a null at the end.
 357
 358         * bfd.c fixed includes, added symbols argument to
 359         canonicalize_reloc entry point.
 360
 361         * libbfd.c fixed includes and added some lint patches.
 362
 363         * targets.c added both sorts of intel coff.
 364
 365         * b.out.c fixed included, changed was the canonical
 366         relocs were done.
 367
 368         * icoff.c added support for callj and big and little
 369         enidian tables.
 370
 371         * opncls.c added chmod+xing for files with EXEC_P set.
 372
 373         * sunos.c fixed includes. Changed default section
 374         alignement to words. Fixed relocation stuff to work with
 375         new scheme
 376
 377         * bfd.h various new types added, prototype for new
 378         reloc calls, changed bfd->iostream to a void *
 379         to including files don't need stdio.h.
 380
 381         * libcoff.h added conversion table to tie relocs to
 382         canonical symbols
 383
 384         * sysdep.h created
 385
 386         * coff-code.h fixed includes. Added code to support
 387         big and little endian formats. Various lints. Better
 388         processing of symbols. Changed reloc stuff to new
 389         order
 390
 391         * libbfd.h fixed includes
 392
 393
 394 Mon Jan 21 11:53:51 PST 1991 steve@cygnus.com
 395
 396         * bfd.h changed name of alignment entry in sec_struct to
 397         alignment_power, because of conflicting uses within bfd.
 398         Now it should be obvious that it's a 2**n alignment
 399         specifier. Removed start_pad, end_alignment, block, minsize,
 400         output_file_alignment, subsection_alignment and original_vma fields.
 401         Added align_power() macro. Fixed bfd_section_alignment
 402         acessor macros. Added bfd_symbol_same_target macro.
 403
 404         * b.out.c (b_out_write_object_contents) fixed to use
 405         new alignment member. Fixed (callj_callback) to use section
 406         relative symbols properly.
 407
 408         * sunos.c (sunos4_object_p) fixed to use new alignment_power.
 409         Fixed (translate_from_native_sym_flags) to correctly make
 410         symbols section relative.
 411
 412         * bfd.c (bfd_errmsg) fixed various enum cast problems.
 413         (bfd_make_section) took out initialization of obsolete members.
 414         (bfd_print_symbol_vandf) added
 415
 416         * opncls.c (bfd_create) created.
 417
 418         * coff-code.h (coff_new_section_hook) took away refs
 419         to obsolete members. (make_a_section_from_file) added
 420         conversion between alignment types. (coff_symbol_from)
 421         added. (coff_count_linenumbers) only counts linenumbers
 422         if symbol is of coff-type. (coff_mangle_symbols) only
 423         heavily mangles symbols if symbol is coff-type.
 424         (coff_write_symbols) various lints. (coff_write_object_contents)
 425         various lints and modification for alignment conversion.
 426         (coff_slurp_relocs) fixed for use with new asection shape.
 427
 428 Sat Jan 19 16:10:42 PST 1991 steve@cygnus.com
 429
 430         * archive.c lots of lint
 431
 432         * b.out.c added callj relocation support, upgrated reloc howto.
 433         Fixed so that asymbol and reloc records are output
 434         correctly.
 435
 436         * bfd.c lots of lint, support for new bfd entry point
 437         bfd_print_symbol.
 438
 439         * bfd.h changed definition of asymbol to contain pointer to
 440         owning bfd, removed target dependencies.
 441
 442         * cache.c took out print statements, put in BFD_ASSERT calls.
 443
 444         * coff-code.h various lints, corrected linenumber output
 445         functionality. Added support for new style asymbols and
 446         bfd_print_symbol. Fixed so that asymbol and
 447         reloc records are handled correctly. Added timestamp.
 448
 449         * icoff.c Added support for new howto shape.
 450
 451         * liba.out.h Added support for new asymbol shape
 452
 453         * libbfd.c various lints
 454
 455         * libbfd.h various lints
 456
 457         * libcoff.h added support for new asymbol shape.
 458
 459         * sunos.c  various lints. Added support for new asymbol shape
 460         and bfd_print_symbol.
 461
 462 Wed Jan 16 21:38:09 PST 1991 steve@cygnus.com
 463
 464         * b.out.c removed prototype of sunos4_ennativate_symtab, lots of
 465         pointer lint. Added support for callj relocation. Fixed bug where
 466         the last 32 bytes of the text section were overwritten by data. Fixed bug
 467         where archives of b.out didn't work due bfd_slurp_extended_name_table
 468         returning false.
 469
 470         * sunos.c added support for n_other field. Braced the howto table so
 471         that it won't be affected by any lengthing of the howto struct typedef.
 472         Various lints
 473
 474         * bfd.h added support for n_other field, added special_function
 475         reloc type, modified bfd_perform_relocation prototype. Added bfd_h_get_x
 476         macros.
 477
 478         * bfd.c upgraded bfd_perform_relocation, various lints.
 479
 480 Wed Jan 16 01:55:53 1991  John Gilmore  (gnu at rtl)
 481
 482         * ChangeLog:  Started ChangeLog for BFD.
 483         * ToDo:  Create file for suggestions.
 484
 485         * Makefile:  Support easy loading into Saber C.
 486         Add dependencies for icoff.o and bcs88kcoff.o.
 487         Rename coff.c to coff-code.h.  Change callers.
 488
 489         * bfd.c (bfd_check_format):  Allow the check_format routines
 490         to return the desired target vector, rather than just a Boolean.
 491         bfd.h (bfd_check_format):  Change function pointer return type.
 492         archive.c (bfd_generic_archive_p):  change callee.
 493         b.out.c (b_out_little_object_p, b_out_big_object_p,
 494         b_out_real_object_p):  change callee.
 495         libbfd.c (_bfd_dummy_target):  Dummy routine replacing bfd_false
 496         in check_format transfer vectors that need a filler.
 497         libbfd.h (bfd_generic_archive_p, _bfd_dummy_target):  Fix decls.
 498         bcs88kcoff.c:  change callee.
 499         coff-code.h (coff_real_object_p, coff_big_object_p):  change callee.
 500         icoff.c:  change callee.
 501         sunos.c (sunos4_object_p, sunos4_core_file_p):  change callee.
 502
 503         * libbfd.c (zalloc):  It should actually zero the storage!
 504         This was commented out for some reason.
 505
 506         * libbfd.h:  Add malloc, xmalloc, memcpy, and fatal decls.
 507         This is so callers can avoid <stdlib.h> which doesn't exist
 508         on older systems.
 509
 510         * bfd.c (map_over_sections):  Add debugging code, since I
 511         noticed the section count for sunos core files was bad, but only
 512         GDB had detected the problem.
 513         (bfd_set_section_lineno_size, bfd_set_section_linenos,
 514         bfd_get_section_linenos):  Remove obsolete functions.
 515         (bfd_apply_relocations):  Use longs, not ints, for the math.
 516
 517         * bfd.h:  Declare enum boolean and struct bfd_target as well
 518         as typedefs for them.  Remove obsolete
 519         bfd_get_section_lineno_size.
 520
 521         * cache.c:  Make the "fdopen" support work.  Keep better track
 522         of how many files are open.  Centralize the opening of files
 523         and be sure bfd_open[rw] actually try to open the file.  Evade
 524         linked list initialization problems.
 525
 526         * b.out.c, coff-code.h, opncls.c, sunos.c:  lint.
 527
 528         * coff-code.h (coff_slurp_symbol_table):  Null-terminate symtab names.
 529
 530         * cplus-dem.c:  Delete file, since it is not part of BFD.
 531
 532         * opncls.c (bfd_openr):  Eliminate misplaced #if 0 code.
 533         (bfd_openr, bfd_openw):  Actually open the file, give error now.
 534
 535         * sunos.c (sunos4_core_file_p):  Set section count.
 536         (sunos4_set_section_linenos, stab_names, fprint_name):  Eliminiate
 537         obsolete definitions.
 538         (_write_symbol_table):  Initialize <idx> counter.
 539         (foop):  Eliminate debugging code.
 540
 541
 542
 543