bfd/ChangeLog

   1 2020-04-01  Tamar Christina  <tamar.christina@arm.com>
   2
   3         * elf32-arm.c (elf32_thumb2_plt_entry): Fix PC-rel offset.
   4
   5 2020-04-01  Hans-Peter Nilsson  <hp@bitrange.com>
   6
   7         * mmo.c (mmo_scan): Create .text section only when needed, not
   8         from the start.
   9
  10 2020-03-31  Alan Modra  <amodra@gmail.com>
  11
  12         * coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Correct bfd_bread
  13         return value check.
  14
  15 2020-03-31  Alan Modra  <amodra@gmail.com>
  16
  17         * vms-alpha.c (image_write): Check bounds for sections without
  18         contents too.  Error on non-zero write to section without
  19         contents.
  20         (_bfd_vms_slurp_etir): Check return of image_write* functions.
  21
  22 2020-03-31  Alan Modra  <amodra@gmail.com>
  23
  24         * tekhex.c (pass_over): Check is_eof before reading buffer.
  25
  26 2020-03-30  Nick Clifton  <nickc@redhat.com>
  27
  28         PR binutils/pr25662
  29         * libcoff-in.h (struct pe_tdata): Rename the insert_timestamp
  30         field to timestamp and make it an integer.
  31         * libcoff.h: Regenerate.
  32         * peXXigen.c (_bfd_XXi_only_swap_filehdr_out): Test the timestamp
  33         field in the pe_data structure rather than the insert_timestamp
  34         field.
  35
  36 2020-03-30  Alan Modra  <amodra@gmail.com>
  37
  38         PR 25745
  39         * elf64-ppc.c (ppc64_elf_build_stubs): Use asprintf to form
  40         statistics message.
  41
  42 2020-03-26  Nick Clifton  <nickc@redhat.com>
  43
  44         * cofflink.c (bfd_coff_get_internal_extra_pe_aouthdr): Delete.
  45         * libbfd-in.h (bfd_coff_get_internal_extra_pe_aouthdr): Remove
  46         prototype.
  47         * libbfd.h: Regenerate.
  48
  49 2020-03-26  Alan Modra  <amodra@gmail.com>
  50
  51         * i386msdos.c (msdos_object_p): Catch -1 return from bfd_bread.
  52
  53 2020-03-26  Alan Modra  <amodra@gmail.com>
  54
  55         * vms-alpha.c (dst_define_location): Limit size of dst_ptr_offsets
  56         array.
  57         (_bfd_vms_slurp_object_records): Rename "err" to "ok".
  58
  59 2020-03-25  Nick Clifton  <nickc@redhat.com>
  60
  61         * cofflink.c (bfd_coff_get_internal_extra_pe_aouthdr): New
  62         function.
  63         * libbfd-in.h (bfd_coff_get_internal_extra_pe_aouthdr): Prototype.
  64         * libbfd.h: Regenerate.
  65
  66 2020-03-25  Shahab Vahedi  <shahab@synopsys.com>
  67
  68         * elf32-arc.c (PRINT_DEBUG_RELOC_INFO_BEFORE): Use the
  69         correct field name in the output string.
  70
  71 2020-03-25  Alan Modra  <amodra@gmail.com>
  72
  73         PR 25662
  74         * elf.c (assign_file_positions_for_load_sections): Adjust offset
  75         for SHT_NOBITS section if first in segment.
  76
  77 2020-03-24  H.J. Lu  <hongjiu.lu@intel.com>
  78
  79         PR binutils/25708
  80         * elf-bfd.h (_bfd_elf_get_symbol_version_name): Renamed to ...
  81         (_bfd_elf_get_symbol_version_string): This.
  82         * elf.c (_bfd_elf_get_symbol_version_name): Renamed to ...
  83         (_bfd_elf_get_symbol_version_string): This.
  84         (bfd_elf_print_symbol): Pass TRUE to
  85         _bfd_elf_get_symbol_version_string.
  86         * libbfd-in.h (_bfd_nosymbols_get_symbol_version_string): Add a
  87         bfd_boolean argument.
  88         * syms.c (_bfd_nosymbols_get_symbol_version_string): Likewise.
  89         * targets.c  (_bfd_get_symbol_version_string): Likewise.
  90         (bfd_get_symbol_version_string): Likewise.
  91         * bfd-in2.h: Regenerated.
  92
  93 2020-03-24  Nick Clifton  <nickc@redhat.com>
  94             Jaydeep Chauhan  <jaydeepchauhan1494@gmail.com>
  95
  96         PR 25713
  97         * bfdio.c (_bfd_real_fopen): Add code to handle long filenames on
  98         Win32 systems.
  99
 100 2020-03-24  Nick Clifton  <nickc@redhat.com>
 101
 102         PR 25681
 103         * elf.c (_bfd_elf_map_sections_to_segments): When looking for a
 104         segment to use for PT_GNU_RELRO, ignore empty sections in a
 105         segment's current list.
 106
 107 2020-03-24  H.J. Lu  <hongjiu.lu@intel.com>
 108
 109         PR binutils/25717
 110         * elf-bfd.h (elf_obj_tdata): Change num_group to unsigned int.
 111
 112 2020-03-24  H.J. Lu  <hongjiu.lu@intel.com>
 113
 114         PR binutils/25708
 115         * elf-bfd.h (_bfd_elf_get_symbol_version_name): New.
 116         * elf.c (_bfd_elf_get_symbol_version_name): New function.  Based
 117         on the previous _bfd_elf_get_symbol_version_string.
 118         (_bfd_elf_get_symbol_version_string): Use it.
 119
 120 2020-03-24  Alan Modra  <amodra@gmail.com>
 121
 122         * archive.c (_bfd_generic_read_ar_hdr_mag): Sanity check extended
 123         name size.  Use bfd_malloc rather than bfd_zmalloc, clearing just
 124         struct areltdata.
 125
 126 2020-03-23  Sebastian Huber  <sebastian.huber@embedded-brains.de>
 127
 128         * elflink.c (_bfd_elf_tls_setup): Mention .tdata in comment.
 129
 130 2020-03-23  Alan Modra  <amodra@gmail.com>
 131
 132         * ecoff.c (_bfd_ecoff_slurp_armap): Sanity check parsed_size and
 133         symbol count.  Allocate an extra byte to ensure name strings
 134         are terminated.  Sanity check name offsets.  Release memory on
 135         error return.
 136
 137 2020-03-23  Alan Modra  <amodra@gmail.com>
 138
 139         * i386msdos.c (msdos_object_p): Don't access e_lfanew when that
 140         field hasn't been read.  Remove unnecessary casts.
 141
 142 2020-03-22  Alan Modra  <amodra@gmail.com>
 143
 144         * coff64-rs6000.c (xcoff64_slurp_armap): Ensure size is large
 145         enough to read number of symbols.
 146
 147 2020-03-20  H.J. Lu  <hongjiu.lu@intel.com>
 148
 149         * configure.ac (HAVE_EXECUTABLE_SUFFIX): Removed.
 150         (EXECUTABLE_SUFFIX): Likewise.
 151         * config.in: Regenerated.
 152         * configure: Likewise.
 153         * plugin.c (bfd_plugin_close_and_cleanup): Defined as
 154         _bfd_generic_close_and_cleanup.
 155         (plugin_list_entry): Remove resolution_file, resolution_option,
 156         real_bfd, real_nsyms, real_syms, lto_nsyms, lto_syms, gcc,
 157         lto_wrapper, gcc_env and initialized,
 158         (need_lto_wrapper_p): Removed.
 159         (get_lto_wrapper): Likewise.
 160         (setup_lto_wrapper_env): Likewise.
 161         (register_all_symbols_read): Likewise.
 162         (egister_cleanup): Likewise.
 163         (get_symbols): Likewise.
 164         (add_input_file): Likewise.
 165         (bfd_plugin_set_program_name): Remove need_lto_wrapper.
 166         (add_symbols): Updated.
 167         (try_claim): Likewise.
 168         (try_load_plugin): Likewise.
 169         (bfd_plugin_canonicalize_symtab): Likewise.
 170         * plugin.h (bfd_plugin_set_program_name): Remove int argument.
 171         (plugin_data_struct): Remove real_bfd, real_nsyms and real_syms.
 172
 173 2020-03-19  H.J. Lu  <hongjiu.lu@intel.com>
 174
 175         PR binutils/25640
 176         * plugin.c (plugin_list_entry): Add has_symbol_type.
 177         (add_symbols_v2): New function.
 178         (bfd_plugin_open_input): Don't invoke LTO wrapper if LTO plugin
 179         provides symbol type.
 180         (try_load_plugin): Add LDPT_ADD_SYMBOLS_V2.
 181         (bfd_plugin_canonicalize_symtab): Use LTO plugin symbol type if
 182         available.
 183
 184 2020-03-20  Alan Modra  <amodra@gmail.com>
 185
 186         * coff-rs6000.c (_bfd_xcoff_slurp_armap): Ensure size is large
 187         enough to read number of symbols.
 188
 189 2020-03-20  Alan Modra  <amodra@gmail.com>
 190
 191         * elf.c (_bfd_elf_setup_sections): Don't test known non-NULL
 192         backend functions for NULL before calling.
 193         (copy_special_section_fields, _bfd_elf_copy_private_bfd_data),
 194         (bfd_section_from_shdr, assign_section_numbers): Likewise.
 195         * elfcode.h (elf_write_relocs, elf_slurp_reloc_table): Likewise.
 196         * elfnn-ia64.c (ignore_errors): New function.
 197         (elf_backend_link_order_error_handler): Redefine as ignore_errors.
 198
 199 2020-03-19  Nick Clifton  <nickc@redhat.com>
 200
 201         PR 25676
 202         * dwarf2.c (struct varinfo): Add unit_offset field to record the
 203         location of the varinfo in the unit's debug info data.  Change the
 204         type of the stack field to a boolean.
 205         (lookup_var_by_offset): New function.  Returns the varinfo
 206         structure for the variable described at the given offset in the
 207         unit's debug info.
 208         (scan_unit_for_symbols): Add support for variables which have the
 209         DW_AT_specification attribute.
 210
 211 2020-03-19  Nick Clifton  <nickc@redhat.com>
 212
 213         PR 25699
 214         * elf.c (bfd_elf_set_group_contents): Replace assertion with an
 215         error return.
 216
 217 2020-03-19  Sebastian Huber  <sebastian.huber@embedded-brains.de>
 218
 219         * elfxx-riscv.c (riscv_parse_subset): Don't use C99.
 220
 221 2020-03-18  Nick Clifton  <nickc@redhat.com>
 222
 223         PR 25673
 224         * elf.c (_bfd_elf_write_secondary_reloc_section): Fix illegal
 225         memory access when processing a corrupt secondary reloc section.
 226
 227 2020-03-18  Christophe Lyon  <christophe.lyon@linaro.org>
 228
 229         * elf32-arm.c (arm_build_one_stub): Emit a fatal error message
 230         instead of calling abort.
 231         * elf32-csky.c (csky_build_one_stub): Likewise.
 232         * elf32-hppa.c (hppa_build_one_stub): Likewise.
 233         * elf32-m68hc11.c (m68hc11_elf_build_one_stub): Likewise.
 234         * elf32-m68hc12.c (m68hc12_elf_build_one_stub): Likewise.
 235         * elf32-metag.c (metag_build_one_stub): Likewise.
 236         * elf32-nios2.c (nios2_build_one_stub): Likewise.
 237         * elf64-ppc.c (ppc_build_one_stub): Likewise.
 238         (ppc_size_one_stub): Likewise.
 239         * elfnn-aarch64.c (aarch64_build_one_stub): Likewise.
 240
 241 2020-03-17  Nick Clifton  <nickc@redhat.com>
 242
 243         PR 25688
 244         * elf.c (_bfd_elf_copy_special_section_fields): Replace assertions
 245         with error messages.
 246
 247 2020-03-17  Nick Clifton  <nickc@redhat.com>
 248
 249         PR 25687
 250         * elf.c (_bfd_elf_slurp_secondary_reloc_section): Remove redundant
 251         free.  Add free on another failure path.
 252
 253 2020-03-16  Alan Modra  <amodra@gmail.com>
 254
 255         PR 25675
 256         * elf.c (elf_sort_segments): Don't call bfd_octets_per_byte unless
 257         we have a non-zero section count.  Do lma comparison in octets.
 258
 259 2020-03-16  Alan Modra  <amodra@gmail.com>
 260
 261         * vms-alpha.c (dst_restore_location): Validate index into
 262         dst_ptr_offsets array before accessing.  Return status.
 263         (dst_retrieve_location): Similarly, making "loc" parameter a
 264         pointer to return value.
 265         (_bfd_vms_slurp_etir): Update calls to above functions.
 266
 267 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 268
 269         * configure.ac: Include netbsd-core.lo for all NetBSD arm and mips
 270         targets.
 271         * configure: Regenerated.
 272
 273 2020-03-14  Alan Modra  <amodra@gmail.com>
 274
 275         * section.c (BFD_FAKE_SECTIONS): Formatting.
 276         * bfd-in2.h: Regenerate.
 277
 278 2020-03-13  Kamil Rytarowski  <n54@gmx.com>
 279
 280         * elf.c (elfcore_grok_netbsd_note): Add support for
 281         NT_NETBSDCORE_LWPSTATUS notes.
 282
 283 2020-03-13  Christophe Lyon  <christophe.lyon@linaro.org>
 284
 285         * bfd-in2.h: Regenerate.
 286         * section.c (asection): Add already_assigned field.
 287         (BFD_FAKE_SECTION): Add default initializer for it.
 288         * ecoff.c (bfd_debug_section): Initialize already_assigned field.
 289         * elf32-arm.c (arm_build_one_stub): Add support for
 290         non_contiguous_regions.
 291         * elf32-csky.c (csky_build_one_stub): Likewise.
 292         * elf32-hppa.c (hppa_build_one_stub): Likewise.
 293         * elf32-m68hc11.c (m68hc11_elf_build_one_stub): Likewise.
 294         * elf32-m68hc12.c (m68hc12_elf_build_one_stub): Likewise.
 295         * elf32-metag.c (metag_build_one_stub): Likewise.
 296         * elf32-nios2.c (nios2_build_one_stub): Likewise.
 297         * elf64-ppc.c (ppc_build_one_stub): Likewise.
 298         (ppc_size_one_stub): Likewise.
 299         * elfnn-aarch64.c (aarch64_build_one_stub): Likewise.
 300         * elflink.c (elf_link_input_bfd): Likewise.
 301
 302 2020-03-13  H.J. Lu  <hongjiu.lu@intel.com>
 303
 304         PR ld/24920
 305         * elf-linker-x86.h (elf_linker_x86_params): Add
 306         static_before_all_inputs and has_dynamic_linker.
 307         * elfxx-x86.c (_bfd_x86_elf_link_setup_gnu_properties): Report
 308         dynamic input objects if -static is passed at command-line
 309         before all input files without --dynamic-linker unless
 310         --no-dynamic-linker is used.
 311
 312 2020-03-13  Kamil Rytarowski  <n54@gmx.com>
 313
 314         * elf.c (elfcore_grok_netbsd_note): Add support for aarch64.
 315
 316 2020-03-13  Christian Eggers  <ceggers@gmx.de>
 317
 318         * bfd.c (bfd_record_phdr): New local "opb".  Fix assignment of
 319         "p_paddr" from "at".
 320         * elfcode.h (bfd_from_remote_memory): Add units to several
 321         parameters.  New local "opb".  Fix usage of p_align.  Fix
 322         calculation of "localbase" from "ehdr_vma" and "p_vaddr".  Fix
 323         call of target_read_memory.
 324         * elflink.c (elf_fixup_link_order): Fix scope of "s" local.  Fix
 325         calculation of "offset" and "output_offset".
 326         (bfd_elf_final_link): New local "opb".  Fix calculation of "size"
 327         from "offset" and fix calculation of "end" from "vma+size".  Fix
 328         comparison between "sh_addr" and "vma"/"output_offset".
 329         (bfd_elf_discard_info): Fix calculation of "eh_alignment".
 330         * elf-bfd.h (struct elf_link_hash_table): Add unit to tls_size
 331         member.
 332         * elf.c (_bfd_elf_map_sections_to_segments): Add unit (bytes/
 333         octets) to "wrap_to2 and "phdr_size" locals.  Fix calculation of
 334         "wrap_to" value.  Add unit (bytes) to phdr_lma variable.  Fix
 335         assignment of p_paddr from phdr_lma.  Fix comparison between
 336         "lma+size" and "next->lma".
 337         (elf_sort_segments): Fix assignment from p_paddr to lma.
 338         (assign_file_positions_for_load_sections): Add unit (bytes) to
 339         local "align".  Fix calculation of local "off_adjust".  Fix
 340         calculation of local "filehdr_vaddr".
 341         (assign_file_positions_for_non_load_sections): New local "opb".
 342         Fix calculation of "end" from "p_size". Fix comparison between
 343         "vma+SECTION_SIZE" and "start".  Fix calculation of "p_memsz"
 344         from "end" and "p_vaddr".
 345         (rewrite_elf_program_header): Fix comparison between p_vaddr and
 346         vma.  Fix assignment to p_paddr from lma.  Fix comparison between
 347         p_paddr and lma.  Fix assignment to p_paddr from lma.
 348         * merge.c (sec_merge_emit): New local "opb". Convert
 349         "alignment_power" to octets.
 350         (_bfd_add_merge_section): New locals "alignment_power" and
 351         "opb".  Fix comparison between "alignment_power" and
 352         "sizeof(align)".
 353         (_bfd_merge_sections): New local "opb".  Divide size by opb
 354         before checking align mask.
 355
 356 2020-03-13  Christian Eggers  <ceggers@gmx.de>
 357
 358         * elf.c (_bfd_elf_make_section_from_shdr): Introduce new temp
 359         opb.  Divide Elf_Internal_Shdr::sh_addr by opb when setting
 360         section LMA/VMA.
 361         (_bfd_elf_make_section_from_phdr): Similarly.
 362         (elf_fake_sections): Fix calculation of
 363         Elf_Internal_shdr::sh_addr from section VMA.
 364         (_bfd_elf_map_sections_to_segments): Fix mixup between octets
 365         and bytes.
 366         (assign_file_positions_for_load_sections): Fix calculations of
 367         Elf_Internal_shdr::p_vaddr and p_paddr from section LMA/VMA.  Fix
 368         comparison between program header address and section LMA.
 369         (assign_file_positions_for_non_load_sections): Likewise.
 370         (rewrite_elf_program_header): Likewise.  Introduce new temp opb.
 371         (IS_CONTAINED_BY_VMA): Add parameter opb.
 372         (IS_CONTAINED_BY_LMA,IS_SECTION_IN_INPUT_SEGMENT,
 373         INCLUDE_SECTION_IN_SEGMENT): Likewise.
 374         (copy_elf_program_header): Update call to ELF_SECTION_IN_SEGMENT.
 375         Fix calculations of p_addr_valid and p_vaddr_offset.
 376         * elflink.c (elf_link_add_object_symbols): Multiply section VMA
 377         with octets per byte when comparing against p_vaddr.
 378
 379 2020-03-11  Alan Modra  <amodra@gmail.com>
 380
 381         * som.c (setup_sections): Sanity check subspace.name.
 382
 383 2020-03-11  Alan Modra  <amodra@gmail.com>
 384
 385         * elf64-ppc.c (ppc64_elf_inline_plt): Do increment rel in for loop.
 386
 387 2020-03-10  Alan Modra  <amodra@gmail.com>
 388
 389         PR 25648
 390         * ihex.c (ihex_write_object_contents): Don't assume ordering of
 391         addresses here.
 392
 393 2020-03-09  Alan Modra  <amodra@gmail.com>
 394
 395         * wasm-module.c (wasm_scan): Sanity check file name length
 396         before allocating memory.  Move common section setup code.  Do
 397         without bfd_tell to calculate section size.
 398
 399 2020-03-06  Nick Clifton  <nickc@redhat.com>
 400
 401         * elf.c (_bfd_elf_set_section_contents): Replace call to abort
 402         with error messages and failure return values.
 403
 404 2020-03-05  Max Filippov  <jcmvbkbc@gmail.com>
 405
 406         * elf32-xtensa.c (shrink_dynamic_reloc_sections): Shrink dynamic
 407         relocation sections for any removed reference to a dynamic symbol.
 408
 409 2020-03-05  Nick Clifton  <nickc@redhat.com>
 410
 411         * elf-bfd.h (struct elf_backend_data): Add new fields:
 412         init_secondary_reloc_section, slurp_secondary_reloc_section,
 413         write_secondary_reloc_section.
 414         (_bfd_elf_init_secondary_reloc_section): Prototype.
 415         (_bfd_elf_slurp_secondary_reloc_section): Prototype.
 416         (_bfd_elf_write_secondary_reloc_section): Prototype.
 417         * elf.c ( bfd_section_from_shdr): Invoke the new
 418         init_secondary_reloc_section backend function, if defined, when a
 419         second reloc section is encountered.
 420         (swap_out_syms): Invoke the new symbol_section_index function, if
 421         defined, when computing the section index of an OS/PROC specific
 422         symbol.
 423         (_bfd_elf_init_secondary_reloc_section): New function.
 424         (_bfd_elf_slurp_secondary_reloc_section): New function.
 425         (_bfd_elf_write_secondary_reloc_section): New function.
 426         (_bfd_elf_copy_special_section_fields): New function.
 427         * elfcode.h (elf_write_relocs): Invoke the new
 428         write_secondary_relocs function, if defined, in order to emit
 429         secondary relocs.
 430         (elf_slurp_reloc_table): Invoke the new slurp_secondary_relocs
 431         function, if defined, in order to read in secondary relocs.
 432         * elfxx-target.h (elf_backend_copy_special_section_fields):
 433         Provide a non-NULL default definition.
 434         (elf_backend_init_secondary_reloc_section): Likewise.
 435         (elf_backend_slurp_secondary_reloc_section): Likewise.
 436         (elf_backend_write_secondary_reloc_section): Likewise.
 437         (struct elf_backend_data elfNN_bed): Add initialisers for the new
 438         fields.
 439         * configure.ac (score_elf32_[bl]e_vec): Add elf64.lo
 440         * configure: Regenerate.
 441
 442 2020-03-05  Alan Modra  <amodra@gmail.com>
 443
 444         * archive64.c (_bfd_archive_64_bit_slurp_armap): Check parsed_size
 445         against file size before allocating memory.  Use bfd_alloc rather
 446         than bfd_zalloc for carsym/strings memory.
 447
 448 2020-03-04  Alan Modra  <amodra@gmail.com>
 449
 450         * elf.c (elf_fake_sections): Ensure sh_addralign is such that
 451         sh_addr mod sh_addalign is zero.
 452
 453 2020-03-04  Alan Modra  <amodra@gmail.com>
 454
 455         * format.c (bfd_check_format_matches): Call cleanup on error exit.
 456
 457 2020-03-03  Alan Modra  <amodra@gmail.com>
 458
 459         * format.c (struct bfd_preserve): Add cleanup field.
 460         (bfd_preserve_save): Add cleanup param and save.
 461         (bfd_preserve_restore): Return cleanup.
 462         (bfd_preserve_finish): Call the cleanup for the discarded match.
 463         (bfd_check_format_matches): Pass cleanup to bfd_preserve_save,
 464         and clear when preserving a match.  Restore cleanup too when
 465         restoring that match.
 466
 467 2020-03-02  Alan Modra  <amodra@gmail.com>
 468
 469         * cisco-core.c (cisco_core_file_p): Return bfd_cleanup.
 470         * hpux-core.c (hpux_core_core_file_p): Update prototype.
 471         * sco5-core.c (sco5_core_file_p): Return bfd_cleanup.
 472         (core_sco5_vec): Correct initialisers.
 473
 474 2020-03-02  Alan Modra  <amodra@gmail.com>
 475
 476         * aix386-core.c (aix386_core_file_p): Return bfd_cleanup.
 477         * aix5ppc-core.c (xcoff64_core_p): Likewise.
 478         * cisco-core.c (cisco_core_file_validate): Likewise.
 479         * hppabsd-core.c (hppabsd_core_core_file_p): Likewise.
 480         * hpux-core.c (hpux_core_core_file_p): Likewise.
 481         * irix-core.c (irix_core_core_file_p): Likewise.
 482         * lynx-core.c (lynx_core_file_p): Likewise.
 483         * netbsd-core.c (netbsd_core_file_p): Likewise.
 484         * osf-core.c (osf_core_core_file_p): Likewise.
 485         * ptrace-core.c (ptrace_unix_core_file_p): Likewise.
 486         * sco5-core.c (sco5_core_file_p): Likewise.
 487
 488 2020-03-02  H.J. Lu  <hongjiu.lu@intel.com>
 489
 490         * trad-core.c (trad_unix_core_file_p): Return bfd_cleanup.
 491
 492 2020-03-02  Alan Modra  <amodra@gmail.com>
 493
 494         * targets.c (bfd_cleanup): New typedef.
 495         (struct bfd <_bfd_check_format>): Return a bfd_cleanup.
 496         * libbfd-in.h (_bfd_no_cleanup): Define.
 497         * format.c (bfd_reinit): Add cleanup parameter, call it.
 498         (bfd_check_format_matches): Set cleanup from _bfd_check_format
 499         call and pass to bfd_reinit.  Delete temp, use abfd->xvec instead.
 500         * aout-target.h (callback, object_p): Return bfd_cleanup.
 501         * aout-tic30.c (tic30_aout_callback, tic30_aout_object_p): Likewise.
 502         * archive.c (bfd_generic_archive_p): Likewise.
 503         * binary.c (binary_object_p): Likewise.
 504         * coff-alpha.c (alpha_ecoff_object_p): Likewise.
 505         * coff-ia64.c (ia64coff_object_p): Likewise.
 506         * coff-rs6000.c (_bfd_xcoff_archive_p, rs6000coff_core_p): Likewise.
 507         * coff-sh.c (coff_small_object_p): Likewise.
 508         * coff-stgo32.c (go32_check_format): Likewise.
 509         * coff64-rs6000.c (xcoff64_archive_p, rs6000coff_core_p),
 510         (xcoff64_core_p): Likewise.
 511         * coffgen.c (coff_real_object_p, coff_object_p): Likewise.
 512         * elf-bfd.h (bfd_elf32_object_p, bfd_elf32_core_file_p),
 513         (bfd_elf64_object_p, bfd_elf64_core_file_p): Likewise.
 514         * elfcode.h (elf_object_p): Likewise.
 515         * elfcore.h (elf_core_file_p): Likewise.
 516         * i386msdos.c (msdos_object_p): Likewise.
 517         * ihex.c (ihex_object_p): Likewise.
 518         * libaout.h (some_aout_object_p): Likewise.
 519         * libbfd-in.h (bfd_generic_archive_p, _bfd_dummy_target),
 520         (_bfd_vms_lib_alpha_archive_p, _bfd_vms_lib_ia64_archive_p): Likewise.
 521         * libbfd.c (_bfd_dummy_target): Likewise.
 522         * libcoff-in.h (coff_object_p): Likewise.
 523         * mach-o-aarch64.c (bfd_mach_o_arm64_object_p),
 524         (bfd_mach_o_arm64_core_p): Likewise.
 525         * mach-o-arm.c (bfd_mach_o_arm_object_p),
 526         (bfd_mach_o_arm_core_p): Likewise.
 527         * mach-o-i386.c (bfd_mach_o_i386_object_p),
 528         (bfd_mach_o_i386_core_p): Likewise.
 529         * mach-o-x86-64.c (bfd_mach_o_x86_64_object_p),
 530         (bfd_mach_o_x86_64_core_p): Likewise.
 531         * mach-o.c (bfd_mach_o_header_p, bfd_mach_o_gen_object_p),
 532         (bfd_mach_o_gen_core_p, bfd_mach_o_fat_archive_p): Likewise.
 533         * mach-o.h (bfd_mach_o_object_p, bfd_mach_o_core_p),
 534         (bfd_mach_o_fat_archive_p, bfd_mach_o_header_p): Likewise.
 535         * mmo.c (mmo_object_p): Likewise.
 536         * pef.c (bfd_pef_object_p, bfd_pef_xlib_object_p): Likewise.
 537         * peicode.h (coff_real_object_p, pe_ILF_object_p),
 538         (pe_bfd_object_p): Likewise.
 539         * plugin.c (ld_plugin_object_p, bfd_plugin_object_p): Likewise.
 540         * ppcboot.c (ppcboot_object_p): Likewise.
 541         * rs6000-core.c (rs6000coff_core_p): Likewise.
 542         * som.c (som_object_setup, som_object_p): Likewise.
 543         * srec.c (srec_object_p, symbolsrec_object_p): Likewise.
 544         * tekhex.c (tekhex_object_p): Likewise.
 545         * vms-alpha.c (alpha_vms_object_p): Likewise.
 546         * vms-lib.c (_bfd_vms_lib_archive_p, _bfd_vms_lib_alpha_archive_p),
 547         (_bfd_vms_lib_ia64_archive_p, _bfd_vms_lib_txt_archive_p): Likewise.
 548         * wasm-module.c (wasm_object_p): Likewise.
 549         * xsym.c (bfd_sym_object_p): Likewise.
 550         * xsym.h (bfd_sym_object_p): Likewise.
 551         * aoutx.h (some_aout_object_p): Likewise, and callback parameter
 552         return type.
 553         * pdp11.c (some_aout_object_p): Likewise.
 554         * plugin.c (register_ld_plugin_object_p): Update object_p
 555         parameter type.
 556         * plugin.h (register_ld_plugin_object_p): Likewise.
 557         * bfd-in2.h: Regenerate.
 558         * libbfd.h: Regenerate.
 559         * libcoff.h: Regenerate.
 560
 561 2020-03-02  Alan Modra  <amodra@gmail.com>
 562
 563         * coff-alpha.c (alpha_ecoff_le_vec): Add SEC_SMALL_DATA to
 564         applicable section flags.
 565         * coff-mips.c (mips_ecoff_le_vec, mips_ecoff_be_vec): Likewise.
 566         (mips_ecoff_bele_vec): Likewise.
 567         * coffcode.h (sec_to_styp_flags): Set SEC_SMALL_DATA for .sdata
 568         and .sbss sections.
 569         * ecoff.c (_bfd_ecoff_new_section_hook): Likewise.
 570         (_bfd_ecoff_styp_to_sec_flags): Likewise.
 571
 572 2020-03-02  Alan Modra  <amodra@gmail.com>
 573
 574         * elf32-m32r.c (m32r_elf_section_flags): New function.
 575         (elf_backend_section_flags): Define.
 576         * elf32-nds32.c (nds32_elf_section_flags): New function.
 577         (elf_backend_section_flags): Define.
 578         * elf32-ppc.c (ppc_elf_section_from_shdr): Set SEC_SMALL_DATA for
 579         .sbss and .sdata sections.
 580         * elf32-v850.c (v850_elf_section_from_shdr): Set SEC_SMALL_DATA
 581         for SHF_V850_GPREL sections.
 582         * elf64-alpha.c (elf64_alpha_section_from_shdr): Delete outdated
 583         FIXME.
 584         * elf64-hppa.c (elf64_hppa_section_from_shdr): Set SEC_SMALL_DATA
 585         for SHF_PARISC_SHORT sections.
 586         * elf64-ppc.c (ppc64_elf_section_flags): New function.
 587         (elf_backend_section_flags): Define.
 588         * elfxx-mips.c (_bfd_mips_elf_section_from_shdr): Set SEC_SMALL_DATA
 589         for SHF_MIPS_GPREL sections.  Delete FIXME.
 590
 591 2020-03-02  Alan Modra  <amodra@gmail.com>
 592
 593         * elf-bfd.h (elf_backend_section_flags): Remove flagword* param.
 594         * elf.c (_bfd_elf_make_section_from_shdr): Set section flags before
 595         calling elf_backend_section_flags with adjusted params.  Use
 596         newsect->flags past that point.
 597         (_bfd_elf_new_section_hook): Always set sh_type and sh_flags for
 598         special sections.
 599         (_bfd_elf_init_private_section_data): Allow normal sh_type sections
 600         to have their type overridden, and all sh_flags but processor and
 601         os specific.
 602         * elf32-arm.c (elf32_arm_section_flags): Adjust for changed params.
 603         * elf32-mep.c (mep_elf_section_flags): Likewise.
 604         * elf32-nios2.c (nios2_elf32_section_flags): Likewise.
 605         * elf64-alpha.c (elf64_alpha_section_flags): Likewise.
 606         * elf64-ia64-vms.c (elf64_ia64_section_flags): Likewise.
 607         * elfnn-ia64.c (elfNN_ia64_section_flags): Likewise.
 608         * elfnn-aarch64.c (elfNN_aarch64_size_stubs): Exclude the linker
 609         stub BFD and non-aarch64 input files when scanning for stubs.
 610
 611 2020-03-02  Alan Modra  <amodra@gmail.com>
 612
 613         * coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Provide an upper
 614         limit to decompressed element size.
 615
 616 2020-03-02  Alan Modra  <amodra@gmail.com>
 617
 618         * vms-lib.c (vms_traverse_index): Add recur_count param and
 619         update calls.  Fail on excessive recursion.
 620
 621 2020-03-02  Alan Modra  <amodra@gmail.com>
 622
 623         * vms-alpha.c (vms_get_remaining_object_record): Use
 624         bfd_realloc_or_free rather than bfd_realloc.
 625         (add_symbol_entry, vector_grow1, alpha_vms_slurp_relocs): Likewise.
 626         (dst_define_location, parse_module): Likewise, and check realloc
 627         return status before using memory.  Return status from function
 628         adjusting all callers.
 629
 630 2020-02-28  Alan Modra  <amodra@gmail.com>
 631
 632         * vms-lib.c (_bfd_vms_lib_archive_p): Free memory on error paths.
 633
 634 2020-02-28  Alan Modra  <amodra@gmail.com>
 635
 636         * vms-alpha.c (alpha_vms_object_p): Use _bfd_malloc_and_read.
 637         Remove duplicate undersize check.
 638
 639 2020-02-27  Alan Modra  <amodra@gmail.com>
 640
 641         PR 24511
 642         * mmo.c (mmo_scan): Set SEC_DATA for .data.
 643
 644 2020-02-27  Alan Modra  <amodra@gmail.com>
 645
 646         PR 24511
 647         * syms.c (stt): Trim off all but 'e', 'i' and 'p' entries.
 648         (coff_section_type): Adjust comment.
 649         (decode_section_type): Likewise.  Call coff_section_type before
 650         decode_section_type.
 651         (bfd_decode_symclass): Use 'c' for common sections other than
 652         the standard one.
 653
 654 2020-02-27  Alan Modra  <amodra@gmail.com>
 655
 656         * coff-rs6000.c (_bfd_xcoff_read_ar_hdr): Put all data in one
 657         malloc'd block.
 658
 659 2020-02-27  Alan Modra  <amodra@gmail.com>
 660
 661         * bfd.c (bfd_stat_arch_elt): Use vector of containing archive,
 662         if file is an archive element.
 663         * bfd-in2.h: Regenerate.
 664
 665 2020-02-26  Alan Modra  <amodra@gmail.com>
 666
 667         * archive.c (do_slurp_bsd_armap): Increase minimum parsed_size, and
 668         bfd_set_error on failing test.  Don't bother changing bfd_error on
 669         file read error.  Check symdef_count is multiple of BSD_SYMDEF_SIZE.
 670         Check sym name is within string buffer.  Use size_t for some vars.
 671         (do_slurp_coff_armap): Use size_t for some variables, fix size of
 672         int_buf.  Don't change bfd_error on file read error.  Use
 673         _bfd_mul_overflow when calculating carsym buffer size.  Reorder
 674         calculations to catch overflows before they occur.  malloc and
 675         free raw armap rather than using bfd_alloc.  Read raw armap before
 676         allocating carsym+strings buffer.
 677         (_bfd_slurp_extended_name_table): Localize variables.  Check
 678         name size against file size.
 679
 680 2020-02-26  Alan Modra  <amodra@gmail.com>
 681
 682         * vms-lib.c (vms_lib_read_index): Release correct buffer.
 683
 684 2020-02-26  Alan Modra  <amodra@gmail.com>
 685
 686         * elf32-rx.c (rx_elf_relocate_section): Use bfd_malloc rather than
 687         malloc.  Check for NULL return from bfd_malloc.
 688         (rx_table_find, rx_table_map): Likewise.
 689         (rx_set_section_contents): Check bfd_alloc return.
 690         (rx_dump_symtab): Don't alloc internal_syms or external_syms.
 691
 692 2020-02-26  Alan Modra  <amodra@gmail.com>
 693
 694         * aoutx.h: Indent labels correctly.  Format error strings.
 695         * archive.c: Likewise.
 696         * archive64.c: Likewise.
 697         * coff-arm.c: Likewise.
 698         * coff-rs6000.c: Likewise.
 699         * coff-stgo32.c: Likewise.
 700         * cpu-arm.c: Likewise.
 701         * dwarf2.c: Likewise.
 702         * elf-ifunc.c: Likewise.
 703         * elf-properties.c: Likewise.
 704         * elf-s390-common.c: Likewise.
 705         * elf-strtab.c: Likewise.
 706         * elf.c: Likewise.
 707         * elf32-arm.c: Likewise.
 708         * elf32-bfin.c: Likewise.
 709         * elf32-cr16.c: Likewise.
 710         * elf32-csky.c: Likewise.
 711         * elf32-i386.c: Likewise.
 712         * elf32-m68k.c: Likewise.
 713         * elf32-msp430.c: Likewise.
 714         * elf32-nds32.c: Likewise.
 715         * elf32-nios2.c: Likewise.
 716         * elf32-pru.c: Likewise.
 717         * elf32-xtensa.c: Likewise.
 718         * elf64-ia64-vms.c: Likewise.
 719         * elf64-x86-64.c: Likewise.
 720         * elfcode.h: Likewise.
 721         * elfcore.h: Likewise.
 722         * elflink.c: Likewise.
 723         * elfnn-aarch64.c: Likewise.
 724         * elfnn-ia64.c: Likewise.
 725         * elfnn-riscv.c: Likewise.
 726         * elfxx-mips.c: Likewise.
 727         * elfxx-sparc.c: Likewise.
 728         * elfxx-x86.c: Likewise.
 729         * i386lynx.c: Likewise.
 730         * merge.c: Likewise.
 731         * pdp11.c: Likewise.
 732         * plugin.c: Likewise.
 733         * reloc.c: Likewise.
 734
 735 2020-02-26  Alan Modra  <amodra@gmail.com>
 736
 737         PR 25593
 738         * elf-bfd.h (struct elf_link_hash_table): Rename "loaded" to
 739         "dyn_loaded".
 740         (bfd_elf_add_dt_needed_tag): Declare.
 741         * elf-strtab.c (_bfd_elf_strtab_restore): Handle NULL buf.
 742         * elflink.c (bfd_elf_add_dt_needed_tag): Make global and rename
 743         from elf_add_dt_needed_tag.  Remove soname and doit param.
 744         (elf_link_add_object_symbols): Don't use elf_add_dt_needed_tag
 745         to see whether as-needed lib is already loaded, use dyn_loaded
 746         list instead.  When saving and restoring around as-needed lib
 747         handle possibility that dynstr has not been initialised.  Don't
 748         add DT_NEEDED tags here.  Limit dyn_loaded list to dynamic libs.
 749         Mark libs loaded via DT_NEEDED entries of other libs with
 750         DYN_NO_NEEDED if they should not be mentioned in DT_NEEDED of
 751         the output.
 752         (elf_link_check_versioned_symbol): Remove now unneccesary
 753         DYNAMIC check when traversing dyn_loaded list.
 754
 755 2020-02-26  Alan Modra  <amodra@gmail.com>
 756
 757         * bfdio.c (bfd_get_file_size): Ignore bogus archive element sizes.
 758
 759 2020-02-25  H.J. Lu  <hongjiu.lu@intel.com>
 760
 761         PR binutils/25584
 762         * plugin.c (need_lto_wrapper_p): New.
 763         (bfd_plugin_set_program_name): Add an int argument to set
 764         need_lto_wrapper_p.
 765         (get_lto_wrapper): Return FALSE if need_lto_wrapper_p isn't
 766         set.
 767         * plugin.h (bfd_plugin_set_program_name): Add an int argument.
 768
 769 2020-02-24  Alan Modra  <amodra@gmail.com>
 770
 771         * vms-lib.c (_bfd_vms_lib_archive_p): Correct overflow checks.
 772
 773 2020-02-24  Alan Modra  <amodra@gmail.com>
 774
 775         * vms-lib.c (struct carsym_mem): Add limit.
 776         (vms_add_index): Heed limit.
 777         (vms_traverse_index): Catch buffer overflows.  Remove outdated fixme.
 778         (vms_lib_read_index): Set up limit.  Catch 32-bit overflow.
 779         Always return actual number read.
 780         (_bfd_vms_lib_archive_p): Catch buffer overflows.  Replace
 781         assertion with error exit.
 782
 783 2020-02-22  Alan Modra  <amodra@gmail.com>
 784
 785         PR 25585
 786         * elf.c (assign_file_positions_for_load_sections): Continue linking
 787         on "PHDR segment not covered by LOAD segment" errors.
 788
 789 2020-02-21  Alan Modra  <amodra@gmail.com>
 790
 791         * mach-o.c (bfd_mach_o_canonicalize_relocs): Fix ineffective
 792         overflow check.
 793         (bfd_mach_o_canonicalize_reloc): Likewise.
 794         (bfd_mach_o_canonicalize_dynamic_reloc): Likewise.  Sanity check
 795         counts and offsets against file size.
 796         (bfd_mach_o_build_dysymtab): Fix ineffective overflow check.
 797         (bfd_mach_o_mangle_sections): Remove unnecessary overflow check.
 798         (bfd_mach_o_read_symtab_symbols): Sanity check count and offset
 799         against file size.  Delete symbol table error message.
 800         (bfd_mach_o_read_dysymtab): Sanity check counts and offsets
 801         against file size.
 802         (bfd_mach_o_read_symtab): Likewise.
 803         (bfd_mach_o_read_command): Pass file size.
 804         (bfd_mach_o_scan): Sanity check command count against file size.
 805
 806 2020-02-21  Alan Modra  <amodra@gmail.com>
 807
 808         PR 25569
 809         * aoutx.h (adjust_o_magic, adjust_z_magic, adjust_n_magic): Use
 810         "text", "data" and "bss" section pointer vars.  Don't update
 811         section size, just exec header sizes.
 812         (adjust_sizes_and_vmas): Don't update text section size.  Set
 813         initial exec header a_text.  Print exec headers sizes.
 814         * pdp11.c (adjust_o_magic, adjust_z_magic, adjust_n_magic),
 815         (adjust_sizes_and_vmas): Similarly.  Formatting.
 816         (final_link): Correct final file extension.
 817
 818 2020-02-20  Nick Clifton  <nickc@redhat.com>
 819
 820         * elf-bfd.h (struct elf_backend_data): Add symbol_section_index
 821         callback.
 822         * elfxx-target.h (elf_backend_symbol_section_index): Provide
 823         default definition.
 824         (elfNN_bed): Initialise the symbol_section_index field.
 825         * elf.c (swap_out_syms): Call symbol_section_index, if defined, on
 826         OS and PROC specific section indicies.  Warn if converting other
 827         reserved incidies to SHN_ABS.
 828
 829 2020-02-19  Sergey Belyashov  <sergey.belyashov@gmail.com>
 830
 831         PR 25537
 832         * cpu-z80.c: Add machine type compatibility checking.
 833
 834 2020-02-19  H.J. Lu  <hongjiu.lu@intel.com>
 835
 836         PR binutils/25355
 837         * plugin.c (plugin_list_entry): Remove handle.
 838         (try_load_plugin): Call dlclose before return.
 839
 840 2020-02-19  Alan Modra  <amodra@gmail.com>
 841
 842         * libbfd-in.h (_bfd_constant_p): Define.
 843         (_bfd_alloc_and_read, _bfd_malloc_and_read): Check read size against
 844         file size before allocating memory.
 845         * coffgen.c (_bfd_coff_get_external_symbols): Remove file size check.
 846         * elf.c (bfd_elf_get_str_section): Likewise.
 847         (_bfd_elf_slurp_version_tables): Likewise.
 848         * libbfd.h: Regenerate.
 849
 850 2020-02-19  Alan Modra  <amodra@gmail.com>
 851
 852         * libbfd-in.h (_bfd_alloc_and_read, _bfd_malloc_and_read): New.
 853         * aoutx.h (aout_get_external_symbols): Replace calls to
 854         bfd_[m]alloc and bfd_bread with call to _bfd_[m]alloc_and_read.
 855         (slurp_reloc_table): Likewise.
 856         * archive.c (do_slurp_bsd_armap): Likewise.
 857         (do_slurp_coff_armap): Likewise.
 858         * archive64.c (_bfd_archive_64_bit_slurp_armap): Likewise.
 859         * coff-rs6000.c (_bfd_xcoff_slurp_armap): Likewise.
 860         * coff64-rs6000.c (xcoff64_slurp_armap): Likewise.
 861         * coffcode.h (coff_set_arch_mach_hook, buy_and_read): Likewise.
 862         * coffgen.c (coff_real_object_p, coff_object_p, build_debug_section),
 863         (_bfd_coff_get_external_symbols): Likewise.
 864         * ecoff.c (ecoff_slurp_symbolic_header),
 865         (_bfd_ecoff_slurp_symbolic_info, ecoff_slurp_reloc_table),
 866         (_bfd_ecoff_slurp_armap, ecoff_link_add_object_symbols, READ),
 867         (ecoff_indirect_link_order): Likewise.
 868         * elf.c (bfd_elf_get_str_section, setup_group, elf_read_notes),
 869         (_bfd_elf_slurp_version_tables): Likewise.
 870         * elf32-m32c.c (m32c_elf_relax_section): Likewise.
 871         * elf32-rl78.c (rl78_elf_relax_section): Likewise.
 872         * elf32-rx.c (elf32_rx_relax_section): Likewise.
 873         * elf64-alpha.c (READ): Likewise.
 874         * elf64-mips.c (mips_elf64_slurp_one_reloc_table): Likewise.
 875         * elf64-sparc.c (elf64_sparc_slurp_one_reloc_table): Likewise.
 876         * elfcode.h (elf_slurp_symbol_table),
 877         (elf_slurp_reloc_table_from_section): Likewise.
 878         * elflink.c (elf_link_add_object_symbols),
 879         (elf_link_check_versioned_symbol): Likewise.
 880         * elfxx-mips.c (READ): Likewise.
 881         * i386lynx.c (slurp_reloc_table): Likewise.
 882         * lynx-core.c (lynx_core_file_p): Likewise.
 883         * mach-o.c (bfd_mach_o_canonicalize_relocs),
 884         (bfd_mach_o_read_symtab_strtab, bfd_mach_o_alloc_and_read),
 885         (bfd_mach_o_read_prebound_dylib, bfd_mach_o_read_dyld_content
 886         * pdp11.c (aout_get_external_symbols, slurp_reloc_table
 887         * pef.c (bfd_pef_print_loader_section, bfd_pef_scan_start_address),
 888         (bfd_pef_parse_symbols): Likewise.
 889         * peicode.h (pe_ILF_object_p, pe_bfd_object_p
 890         * som.c (setup_sections, som_slurp_string_table),
 891         (som_slurp_reloc_table, som_bfd_count_ar_symbols),
 892         (som_bfd_fill_in_ar_symbols): Likewise.
 893         * vms-alpha.c (module_find_nearest_line, evax_bfd_print_dst),
 894         (evax_bfd_print_image): Likewise.
 895         * vms-lib.c (_bfd_vms_lib_archive_p): Likewise.
 896         * wasm-module.c (wasm_scan): Likewise.
 897         * xcofflink.c (xcoff_link_add_symbols): Likewise.
 898         * xsym.c (bfd_sym_read_name_table),
 899         (bfd_sym_print_type_information_table_entry): Likewise.
 900         * libbfd.h: Regenerate.
 901
 902 2020-02-19  Alan Modra  <amodra@gmail.com>
 903
 904         * aoutx.h (slurp_reloc_table): Allocate reloc_cache after
 905         reading external relocs.
 906         * ecoff.c (ecoff_slurp_reloc_table): Likewise.
 907         * archive.c (_bfd_write_archive_contents): Don't twiddle bfd_error
 908         after bfd_bread.
 909         * archive64.c (_bfd_archive_64_bit_slurp_armap): Remove unnecessary
 910         bfd_release.
 911         * elf32-m32c.c (m32c_offset_for_reloc): Make shndx_buf a bfd_byte*.
 912         (m32c_elf_relax_section): Likewise.
 913         * elf32-rl78.c (rl78_offset_for_reloc): Likewise.
 914         (rl78_elf_relax_section): Likewise.
 915         * elf32-rx.c (rx_offset_for_reloc): Likewise.
 916         (elf32_rx_relax_section): Likewise.
 917         * mach-o.c (bfd_mach_o_alloc_and_read): Move earlier with better
 918         parameter types and use..
 919         (bfd_mach_o_read_dylinker, bfd_mach_o_read_dylib),
 920         (bfd_mach_o_read_fvmlib, bfd_mach_o_read_str): ..in these functions.
 921         * peicode.h (pe_bfd_object_p): Don't zero the part of opthdr
 922         being read from file, just the extra.
 923         * som.c (som_slurp_symbol_table): Allocate internal symbol buffer
 924         after reading external syms.  Free on failure.
 925
 926 2020-02-19  Alan Modra  <amodra@gmail.com>
 927
 928         * coffcode.h (buy_and_read, coff_slurp_line_table),
 929         (coff_slurp_symbol_table, coff_slurp_reloc_table): Replace
 930         bfd_[z][m]alloc2 calls with _bfd_mul_overflow followed by the
 931         corresponding bfd_alloc call.  Adjust variables to suit.
 932         * coffgen.c (_bfd_coff_get_external_symbols): Likewise.
 933         * ecoff.c (_bfd_ecoff_slurp_symbolic_info),
 934         (_bfd_ecoff_slurp_symbol_table, READ): Likewise.
 935         * elf.c (bfd_elf_get_elf_syms, setup_group, bfd_section_from_shdr),
 936         (swap_out_syms, _bfd_elf_slurp_version_tables): Likewise.
 937         * elf32-m32c.c (m32c_elf_relax_section): Likewise.
 938         * elf32-rl78.c (rl78_elf_relax_section): Likewise.
 939         * elf32-rx.c (elf32_rx_relax_section): Likewise.
 940         * elf64-alpha.c (READ): Likewise.
 941         * elfcode.h (elf_object_p, elf_write_relocs, elf_write_shdrs_and_ehdr),
 942         (elf_slurp_symbol_table, elf_slurp_reloc_table),
 943         (bfd_from_remote_memory): Likewise.
 944         * elfcore.h (core_find_build_id): Likewise.
 945         * elfxx-mips.c (READ): Likewise.
 946         * mach-o.c (bfd_mach_o_mangle_sections),
 947         (bfd_mach_o_read_symtab_symbols, bfd_mach_o_read_thread),
 948         (bfd_mach_o_read_dysymtab, bfd_mach_o_flatten_sections),
 949         (bfd_mach_o_scan, bfd_mach_o_fat_archive_p): Likewise.
 950         * som.c (setup_sections, som_prep_for_fixups)
 951         (som_build_and_write_symbol_table, som_slurp_symbol_table),
 952         (som_slurp_reloc_table, som_bfd_count_ar_symbols),
 953         (som_bfd_fill_in_ar_symbols, som_slurp_armap),
 954         (som_bfd_ar_write_symbol_stuff): Likewise.
 955         * vms-alpha.c (vector_grow1): Likewise.
 956         * vms-lib.c (vms_add_index): Likewise.
 957         * wasm-module.c (wasm_scan_name_function_section): Likewise.
 958         * libbfd.c (bfd_malloc2, bfd_realloc2, bfd_zmalloc2): Delete.
 959         * opncls.c (bfd_alloc2, bfd_zalloc2): Delete.
 960         * libbfd-in.h (bfd_malloc2, bfd_realloc2, bfd_zmalloc2),
 961         (bfd_alloc2, bfd_zalloc2): Delete.
 962         (_bfd_mul_overflow): Define.
 963         * libbfd.h: Regenerate.
 964
 965 2020-02-19  Alan Modra  <amodra@gmail.com>
 966
 967         * elf.c (bfd_section_from_shdr): Use bfd_zalloc rather than
 968         bfd_zalloc2.
 969         (assign_section_numbers): Likewise.
 970         (elf_map_symbols): Likewise, and bfd_alloc rather than bfd_alloc2.
 971         (_bfd_elf_map_sections_to_segments): Use bfd_malloc rather than
 972         bfd_malloc2, size_t amt, and unsigned tls_count.
 973         (rewrite_elf_program_header): Use bfd_malloc and size_t amt.
 974         * elflink.c (elf_create_symbuf): Use bfd_malloc.
 975         (elf_output_implib): Use bfd_alloc.
 976
 977 2020-02-19  Alan Modra  <amodra@gmail.com>
 978
 979         * bfd.c (struct bfd): Move format and direction to other
 980         bitfields.  Add "size".
 981         * bfdio.c (bfd_get_size): Cache size when not writing file.
 982         * opncls.c (bfd_get_debug_link_info_1): Allow for bfd_get_size
 983         returning zero, ie. unknown.
 984         (bfd_get_alt_debug_link_info): Likewise.
 985         * bfd-in2.h: Regenerate.
 986
 987 2020-02-19  Alan Modra  <amodra@gmail.com>
 988
 989         * coffgen.c (_bfd_coff_get_external_symbols): Don't call
 990         bfd_get_file_size twice.
 991         (_bfd_coff_read_string_table): Allow for bfd_get_file_size
 992         zero, ie. unknown, return.
 993         * elf-attrs.c (_bfd_elf_parse_attributes): Likewise.
 994         * elfcode.h (elf_swap_shdr_in): Likewise.
 995         (elf_object_p): Don't call bfd_get_file_size twice and correct
 996         file size check.
 997
 998 2020-02-19  Alan Modra  <amodra@gmail.com>
 999
1000         * mach-o.c (bfd_mach_o_flatten_sections): Return a bfd_boolean,
1001         FALSE if memory alloc fails.  Adjust calls.
1002         * som.c (som_prep_for_fixups): Likewise.
1003         * vms-alpha.c (alpha_vms_add_fixup_lp, alpha_vms_add_fixup_ca),
1004         (alpha_vms_add_fixup_qr, alpha_vms_add_fixup_lr),
1005         (alpha_vms_add_lw_reloc, alpha_vms_add_qw_reloc): Likewise.
1006         * som.c (som_build_and_write_symbol_table): Return via error_return
1007         on seek failure.
1008         * vms-alpha.c (VEC_APPEND): Adjust for vector_grow1 changes.
1009         (VEC_APPEND_EL): Delete.
1010         (vector_grow1): Return pointer to element.  Catch overflow.
1011         Return NULL on memory allocation failure.
1012         (alpha_vms_add_fixup_lp): Replace VEC_APPEND_EL with VEC_APPEND.
1013         (alpha_vms_add_fixup_ca): Likewise.
1014         (alpha_vms_link_add_object_symbols): Check VEC_APPEND result
1015         before using.
1016         * elf.c (bfd_section_from_shdr): Check bfd_zalloc2 result.
1017
1018 2020-02-19  Alan Modra  <amodra@gmail.com>
1019
1020         * aix386-core.c (aix386_core_file_p): Use size_t for "amt".
1021         * aout-target.h (object_p): Likewise.
1022         * aout-tic30.c (tic30_aout_object_p): Likewise.
1023         * aoutx.h (some_aout_object_p, mkobject, make_empty_symbol),
1024         (emit_stringtab, write_syms, link_hash_table_create),
1025         (aout_link_write_other_symbol): Likewise.
1026         * archive.c (_bfd_generic_mkarchive, bfd_generic_archive_p),
1027         (bfd_ar_hdr_from_filesystem, _bfd_write_archive_contents),
1028         (_bfd_compute_and_write_armap): Likewise.
1029         * archures.c (bfd_arch_list): Likewise.
1030         * bfd.c (bfd_record_phdr): Likewise.
1031         * binary.c (binary_canonicalize_symtab): Likewise.
1032         * cisco-core.c (cisco_core_file_validate): Likewise.
1033         * coff-arm.c (coff_arm_link_hash_table_create, find_thumb_glue),
1034         (find_arm_glue, record_arm_to_thumb_glue),
1035         (record_thumb_to_arm_glue): Likewise.
1036         * coff-ppc.c (ppc_coff_link_hash_table_create, record_toc),
1037         (ppc_allocate_toc_section): Likewise.
1038         * coff-rs6000.c (_bfd_xcoff_mkobject, _bfd_xcoff_archive_p): Likewise.
1039         * coff-sh.c (sh_relax_section): Likewise.
1040         * coff64-rs6000.c (xcoff64_archive_p): Likewise.
1041         * coffcode.h (handle_COMDAT, coff_new_section_hook),
1042         (coff_set_alignment_hook, coff_mkobject),
1043         (coff_compute_section_file_positions): Likewise.
1044         * coffgen.c (coff_make_empty_symbol, coff_bfd_make_debug_symbol),
1045         (coff_find_nearest_line_with_names),
1046         ( bfd_coff_set_symbol_class): Likewise.
1047         * cofflink.c (_bfd_coff_link_hash_table_create),
1048         (_bfd_coff_link_input_bfd): Likewise.
1049         * dwarf1.c (alloc_dwarf1_unit, alloc_dwarf1_func): Likewise.
1050         * dwarf2.c (read_abbrevs, read_attribute_value, add_line_info),
1051         (build_line_info_table, sort_line_sequences),
1052         (line_info_add_include_dir, line_info_add_file_name),
1053         (decode_line_info, scan_unit_for_symbols, parse_comp_unit),
1054         (place_sections, _bfd_dwarf2_slurp_debug_info): Likewise.
1055         * ecoff.c (_bfd_ecoff_mkobject, _bfd_ecoff_make_empty_symbol),
1056         (_bfd_ecoff_find_nearest_line),
1057         (_bfd_ecoff_bfd_link_hash_table_create): Likewise.
1058         * ecofflink.c (bfd_ecoff_debug_init): Likewise.
1059         * elf-hppa.h (_bfd_elf_hppa_gen_reloc_type): Likewise.
1060         * elf-m10300.c (mn10300_elf_relax_section),
1061         (elf32_mn10300_link_hash_table_create): Likewise.
1062         * elf-strtab.c (_bfd_elf_strtab_init): Likewise.
1063         * elf.c (make_mapping, copy_elf_program_header): Likewise.
1064         * elf32-arm.c (elf32_arm_link_hash_table_create),
1065         (elf32_arm_setup_section_lists, elf32_arm_check_relocs),
1066         (elf32_arm_new_section_hook): Likewise.
1067         * elf32-avr.c (elf_avr_new_section_hook),
1068         (elf32_avr_link_hash_table_create, get_local_syms),
1069         (elf32_avr_setup_section_lists): Likewise.
1070         * elf32-bfin.c (bfinfdpic_elf_link_hash_table_create),
1071         (bfin_link_hash_table_create): Likewise.
1072         * elf32-cr16.c (elf32_cr16_link_hash_table_create): Likewise.
1073         * elf32-cris.c (elf_cris_link_hash_table_create): Likewise.
1074         * elf32-csky.c (csky_elf_link_hash_table_create),
1075         (csky_elf_check_relocs, elf32_csky_setup_section_lists): Likewise.
1076         * elf32-frv.c (frvfdpic_elf_link_hash_table_create): Likewise.
1077         * elf32-hppa.c (elf32_hppa_link_hash_table_create),
1078         (elf32_hppa_setup_section_lists, get_local_syms): Likewise.
1079         * elf32-i386.c (elf_i386_check_relocs): Likewise.
1080         * elf32-lm32.c (lm32_elf_link_hash_table_create): Likewise.
1081         * elf32-m32r.c (m32r_elf_link_hash_table_create),
1082         (m32r_elf_check_relocs): Likewise.
1083         * elf32-m68hc1x.c (m68hc11_elf_hash_table_create),
1084         (elf32_m68hc11_setup_section_lists),
1085         (elf32_m68hc11_size_stubs): Likewise.
1086         * elf32-m68k.c (elf_m68k_link_hash_table_create): Likewise.
1087         * elf32-metag.c (elf_metag_link_hash_table_create),
1088         (elf_metag_setup_section_lists): Likewise.
1089         * elf32-microblaze.c (microblaze_elf_link_hash_table_create),
1090         (microblaze_elf_check_relocs): Likewise.
1091         * elf32-nds32.c (nds32_elf_link_hash_table_create),
1092         (nds32_elf_check_relocs): Likewise.
1093         * elf32-nios2.c (nios2_elf32_setup_section_lists),
1094         (get_local_syms, nios2_elf32_check_relocs),
1095         (nios2_elf32_link_hash_table_create): Likewise.
1096         * elf32-or1k.c (or1k_elf_link_hash_table_create),
1097         (or1k_elf_check_relocs): Likewise.
1098         * elf32-ppc.c (ppc_elf_modify_segment_map, update_plt_info): Likewise.
1099         * elf32-pru.c (pru_elf32_link_hash_table_create): Likewise.
1100         * elf32-s390.c (elf_s390_link_hash_table_create),
1101         (elf_s390_check_relocs): Likewise.
1102         * elf32-score.c (score_elf_create_got_section),
1103         (s3_elf32_score_new_section_hook),
1104         (elf32_score_link_hash_table_create): Likewise.
1105         * elf32-score7.c (score_elf_create_got_section),
1106         (s7_elf32_score_new_section_hook): Likewise.
1107         * elf32-sh.c (sh_elf_link_hash_table_create),
1108         (sh_elf_check_relocs): Likewise.
1109         * elf32-tic6x.c (elf32_tic6x_link_hash_table_create),
1110         (elf32_tic6x_new_section_hook, elf32_tic6x_check_relocs): Likewise.
1111         * elf32-tilepro.c (tilepro_elf_link_hash_table_create),
1112         (tilepro_elf_check_relocs): Likewise.
1113         * elf32-v850.c (remember_hi16s_reloc): Likewise.
1114         * elf32-vax.c (elf_vax_link_hash_table_create): Likewise.
1115         * elf32-xtensa.c (elf_xtensa_link_hash_table_create),
1116         (elf_xtensa_new_section_hook): Likewise.
1117         * elf64-alpha.c (elf64_alpha_bfd_link_hash_table_create),
1118         (get_got_entry, elf64_alpha_check_relocs): Likewise.
1119         * elf64-hppa.c (elf64_hppa_hash_table_create): Likewise.
1120         * elf64-ia64-vms.c (elf64_ia64_object_p): Likewise.
1121         * elf64-mmix.c (mmix_elf_new_section_hook): Likewise.
1122         * elf64-ppc.c (ppc64_elf_new_section_hook),
1123         (ppc64_elf_link_hash_table_create, update_local_sym_info),
1124         (update_plt_info, ppc64_elf_check_relocs): Likewise.
1125         * elf64-s390.c (elf_s390_link_hash_table_create),
1126         (elf_s390_check_relocs): Likewise.
1127         * elf64-x86-64.c (elf_x86_64_check_relocs): Likewise.
1128         * elflink.c (bfd_elf_link_record_local_dynamic_symbol),
1129         (_bfd_elf_link_find_version_dependencies, elf_link_add_object_symbols),
1130         (elf_link_add_archive_symbols, compute_bucket_count),
1131         (bfd_elf_size_dynsym_hash_dynstr, _bfd_elf_link_hash_table_create),
1132         (bfd_elf_get_bfd_needed_list, elf_link_swap_symbols_out),
1133         (bfd_elf_final_link): Likewise.
1134         * elfnn-aarch64.c (elfNN_aarch64_link_hash_table_create),
1135         (elfNN_aarch64_setup_section_lists, elfNN_aarch64_check_relocs),
1136         (elfNN_aarch64_new_section_hook): Likewise.
1137         * elfnn-ia64.c (elfNN_ia64_object_p): Likewise.
1138         * elfnn-riscv.c (riscv_elf_link_hash_table_create),
1139         (riscv_elf_check_relocs): Likewise.
1140         * elfxx-mips.c (_bfd_mips_elf_new_section_hook),
1141         (_bfd_mips_elf_add_symbol_hook, _bfd_mips_elf_check_relocs),
1142         (_bfd_mips_elf_modify_segment_map, _bfd_mips_elf_set_section_contents),
1143         (_bfd_mips_elf_link_hash_table_create): Likewise.
1144         * elfxx-sparc.c (_bfd_sparc_elf_link_hash_table_create),
1145         (_bfd_sparc_elf_check_relocs),
1146         (_bfd_sparc_elf_new_section_hook): Likewise.
1147         * elfxx-tilegx.c (tilegx_elf_link_hash_table_create),
1148         (tilegx_elf_check_relocs): Likewise.
1149         * elfxx-x86.c (_bfd_x86_elf_link_hash_table_create): Likewise.
1150         * format.c (bfd_check_format_matches): Likewise.
1151         * hash.c (_bfd_stringtab_init): Likewise.
1152         * ihex.c (ihex_scan): Likewise.
1153         * irix-core.c (irix_core_core_file_p): Likewise.
1154         * linker.c (bfd_wrapped_link_hash_lookup),
1155         (_bfd_generic_link_hash_table_create),
1156         (_bfd_generic_reloc_link_order): Likewise.
1157         * lynx-core.c (lynx_core_file_p): Likewise.
1158         * netbsd-core.c (netbsd_core_file_p): Likewise.
1159         * osf-core.c (osf_core_core_file_p): Likewise.
1160         * pdp11.c (some_aout_object_p, mkobject, make_empty_symbol),
1161         (link_hash_table_create, aout_link_write_other_symbol): Likewise.
1162         * peXXigen.c (_bfd_XX_bfd_copy_private_section_data): Likewise.
1163         * peicode.h (pe_mkobject): Likewise.
1164         * ppcboot.c (ppcboot_mkobject, ppcboot_canonicalize_symtab): Likewise.
1165         * ptrace-core.c (ptrace_unix_core_file_p): Likewise.
1166         * sco5-core.c (read_uarea): Likewise.
1167         * som.c (hppa_som_gen_reloc_type, som_object_p, som_prep_headers),
1168         (som_write_fixups, som_write_space_strings, som_write_symbol_strings),
1169         (som_finish_writing, som_canonicalize_symtab, som_new_section_hook),
1170         (som_bfd_copy_private_section_data, bfd_som_set_section_attributes),
1171         (bfd_som_attach_aux_hdr, som_write_armap): Likewise.
1172         * srec.c (srec_scan): Likewise.
1173         * syms.c (_bfd_generic_make_empty_symbol): Likewise.
1174         * targets.c (bfd_target_list): Likewise.
1175         * tekhex.c (first_phase, tekhex_sizeof_headers): Likewise.
1176         * trad-core.c (trad_unix_core_file_p): Likewise.
1177         * vms-alpha.c (vms_initialize, alpha_vms_bfd_link_hash_table_create),
1178         (vms_new_section_hook): Likewise.
1179         * wasm-module.c (wasm_make_empty_symbol): Likewise.
1180         * xcofflink.c (xcoff_get_section_contents),
1181         (_bfd_xcoff_bfd_link_hash_table_create, xcoff_set_import_path),
1182         (xcoff_find_function, bfd_xcoff_link_record_set, xcoff_build_ldsym),
1183         (bfd_xcoff_size_dynamic_sections, xcoff_link_input_bfd): Likewise.
1184
1185 2020-02-19  Alan Modra  <amodra@gmail.com>
1186
1187         * elfxx-riscv.c (riscv_multi_letter_ext_valid_p): Don't use C99.
1188
1189 2020-02-13  H.J. Lu  <hongjiu.lu@intel.com>
1190
1191         * plugin.c (try_load_plugin): Make plugin_list_iter an argument
1192         and use it if it isn't NULL.  Remove has_plugin_p argument.  Add
1193         a build_list_p argument.  Don't search plugin_list.  Short circuit
1194         when building the plugin list.
1195         (has_plugin): Renamed to has_plugin_list.
1196         (bfd_plugin_set_plugin): Don't set has_plugin.
1197         (bfd_plugin_specified_p): Check plugin_list instead.
1198         (build_plugin_list): New function.
1199         (load_plugin): Call build_plugin_list and use plugin_list.
1200
1201 2020-02-11  H.J. Lu  <hongjiu.lu@intel.com>
1202
1203         PR binutils/25355
1204         * plugin.c (try_claim): Always clean up for LTO wrapper.
1205         (try_load_plugin): Treat each object as independent.  Create a
1206         copy for plugin name.
1207
1208 2020-02-11  Nick Clifton  <nickc@redhat.com>
1209
1210         * elf32-msp430.c (msp430_final_link_relocate): Always use longs
1211         for addresses in print statements.
1212         (msp430_elf_relax_delete_bytes): Likewise.
1213         (msp430_elf_relax_add_words): Likewise.
1214         (msp430_elf_relax_section): Likewise.
1215
1216 2020-02-11  H.J. Lu  <hongjiu.lu@intel.com>
1217
1218         * plugin.c (add_symbols): Clear plugin_data memory.
1219
1220 2020-02-10  H.J. Lu  <hongjiu.lu@intel.com>
1221
1222         PR binutils/25355
1223         * configure.ac (HAVE_EXECUTABLE_SUFFIX): New AC_DEFINE.
1224         (EXECUTABLE_SUFFIX): Likewise.
1225         * config.in: Regenerated.
1226         * configure: Likewise.
1227         * plugin.c (bfd_plugin_close_and_cleanup): Removed.
1228         (plugin_list_entry): Add all_symbols_read, cleanup_handler,
1229         gcc, lto_wrapper, resolution_file, resolution_option, gcc_env,
1230         real_bfd, real_nsyms, real_syms, lto_nsyms and lto_syms.
1231         (get_lto_wrapper): New.
1232         (setup_lto_wrapper_env): Likewise.
1233         (current_plugin): Likewise.
1234         (register_all_symbols_read): Likewise.
1235         (register_cleanup): Likewise.
1236         (get_symbols): Likewise.
1237         (add_input_file): Likewise.
1238         (bfd_plugin_close_and_cleanup): Likewise.
1239         (claim_file): Removed.
1240         (register_claim_file): Set current_plugin->claim_file.
1241         (add_symbols): Make a copy of LTO symbols.  Set lto_nsyms and
1242         lto_syms in current_plugin.
1243         (try_claim): Use current_plugin->claim_file.  Call LTO plugin
1244         all_symbols_read handler.  Copy real symbols to plugin_data.
1245         Call LTO plugin cleanup handler.  Clean up for LTO wrapper.
1246         (try_load_plugin): Don't reuse the previous plugin for LTO
1247         wrapper.  Set up GCC LTO wrapper if possible.  Don't set
1248         plugin_list_iter->claim_file.
1249         (bfd_plugin_canonicalize_symtab): Use real LTO symbols if
1250         possible.
1251         * plugin.h (plugin_data_struct): Add real_bfd, real_nsyms and
1252         real_syms.
1253
1254 2020-02-10  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
1255
1256         * elf32-msp430.c (msp430_elf_relax_section): Before relaxing a branch,
1257         check if previous instruction matches a conditional jump inserted
1258         earlier. Invert conditional jump and delete branch in this case.
1259
1260 2020-02-10  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
1261
1262         * elf32-msp430.c (msp430_elf_relax_add_two_words): Rename to
1263         msp430_elf_relax_add_words. Support insertion of either one or two
1264         words.
1265         (msp430_elf_relax_section): Catch opcode of 0x3c00 when relocation
1266         needs to be grown. Handle insertion of branch instruction to replace
1267         jump.
1268
1269 2020-02-10  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
1270
1271         * elf32-msp430.c (msp430_final_link_relocate): Add printf statements for
1272         debugging relocations.
1273         (msp430_elf_relax_delete_bytes): Likewise.
1274         (msp430_elf_relax_add_two_words): Likewise.
1275         (msp430_elf_relax_section): Likewise.
1276
1277 2020-02-10  Alan Modra  <amodra@gmail.com>
1278
1279         * archures.c: Wrap overlong z80 comments.
1280         * bfd-in2.h: Regenerate.
1281
1282 2020-02-07  Sergey Belyashov  <sergey.belyashov@gmail.com>
1283
1284         PR 25469
1285         * archures.c: Add GBZ80 and Z80N machine values.
1286         * reloc.c: Add BFD_RELOC_Z80_16_BE.
1287         * coff-z80.c: Add support for new reloc.
1288         * coffcode.h: Add support for new machine values.
1289         * cpu-z80.c: Add support for new machine names.
1290         * elf32-z80.c: Add support for new reloc.
1291         * bfd-in2.h: Regenerate.
1292         * libbfd.h: Regenerate.
1293
1294 2020-02-07  Nick Clifton  <nickc@redhat.com>
1295
1296         PR 23932
1297         * elf.c (rewrite_elf_program_header): Do not complain if no
1298         sections are mapped to a segment.
1299
1300 2020-02-06  H.J. Lu  <hongjiu.lu@intel.com>
1301
1302         PR ld/25490
1303         * elflink.c (_bfd_elf_gc_mark_extra_sections): Issue an error
1304         for garbage collection on __patchable_function_entries section
1305         without linked-to section.
1306
1307 2020-02-06  H.J. Lu  <hongjiu.lu@intel.com>
1308
1309         PR gas/25381
1310         * bfd-in2.h: Regenerated.
1311         * elflink.c (_bfd_elf_gc_mark_extra_sections): Call mark_hook
1312         on section if gc_mark of any of its linked-to sections is set
1313         and don't set gc_mark again.
1314         * section.c (asection): Add linked_to_symbol_name to map_head
1315         union.
1316
1317 2020-02-06  Maciej W. Rozycki  <macro@wdc.com>
1318
1319         * elf32-v850.c (v850_elf_relax_section): Fix the index used for
1320         reporting an unrecognized instruction with R_V850_LONGJUMP.
1321
1322 2020-02-05  Alan Modra  <amodra@gmail.com>
1323
1324         * elf64-ppc.c (ppc_stub_plt_branch): Match comment with reality.
1325
1326 2020-02-04  Alan Modra  <amodra@gmail.com>
1327
1328         * elf32-ppc.c (ppc_elf_relocate_section): After applying
1329         R_PPC_VLE_ADDR20, goto copy_reloc.
1330
1331 2020-02-02  H.J. Lu  <hongjiu.lu@intel.com>
1332
1333         * bfd-in2.h: Regenerated.
1334         * section.c (SEC_ASSEMBLER_SECTION_ID): Fix a typo in comments.
1335
1336 2020-02-02  H.J. Lu  <hongjiu.lu@intel.com>
1337
1338         PR gas/25380
1339         * bfd-in2.h: Regenerated.
1340         * ecoff.c (bfd_debug_section): Add section_id.
1341         * section.c (bfd_section): Add section_id.
1342         (SEC_ASSEMBLER_SECTION_ID): New.
1343         (BFD_FAKE_SECTION): Add section_id.
1344
1345 2020-02-01  Nick Clifton  <nickc@redhat.com>
1346
1347         * config.bfd: Move the c30-aout and tic30-aout targets onto the
1348         obsolete list.
1349
1350 2020-01-31  Sandra Loosemore  <sandra@codesourcery.com>
1351
1352         * elf-eh-frame.c (_bfd_elf_write_section_eh_frame): DW_EH_PE_datarel
1353         encodings are relative to the GOT on nios2, too.
1354
1355 2020-01-31  Alan Modra  <amodra@gmail.com>
1356
1357         * Makefile.am (elf32-target.h, elf64-target.h): Don't use a temp
1358         file.  Use $< and $@ in rules.
1359         (elf32-aarch64.c, elf64-aarch64.c): Likewise.
1360         (elf32-ia64.c, elf64-ia64.c): Likewise.
1361         (elf32-riscv.c, elf64-riscv.c): Likewise.
1362         (peigen.c, pepigen.c, pex64igen.c): Likewise.
1363         (elf32-aarch64.c, elf64-aarch64.c): Don't emit $srcdir on #line.
1364         (elf32-riscv.c, elf64-riscv.c): Likewise, and use $(SED).
1365         (elf32-ia64.c, elf64-ia64.c): Do emit #line.
1366         (peigen.c, pepigen.c, pex64igen.c): Likewise.
1367         * Makefile.in: Regenerate.
1368
1369 2020-01-31  Alan Modra  <amodra@gmail.com>
1370
1371         PR 4110
1372         * elf.c (setup_group): Don't clear entire section contents,
1373         just the padding after group flags.  Release alloc'd memory
1374         after a seek or read failure.
1375
1376 2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>
1377
1378         * peXXigen.c (pe_is_repro): New function.
1379         (_bfd_XX_print_private_bfd_data_common): Note timestamp is
1380         actually a build hash if PE_IMAGE_DEBUG_TYPE_REPRO is present.
1381
1382 2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>
1383
1384         * peXXigen.c (debug_type_names): Add names for new debug data type
1385         values.
1386
1387 2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>
1388
1389         * peXXigen.c (pe_print_debugdata): Fix the iteration variable for
1390         inner loop.  Fix a memory leak.
1391
1392 2020-01-30  Alan Modra  <amodra@gmail.com>
1393
1394         * coffgen.c (coff_real_object_p): Don't clear obj_coff_keep_syms
1395         or obj_coff_keep_strings here.
1396         (coff_get_normalized_symtab): Free external syms directly.
1397         * xcofflink.c (xcoff_link_input_bfd): Restore obj_coff_keep_syms
1398         on error exit path.
1399
1400 2020-01-27  Jim Wilson  <jimw@sifive.com>
1401
1402         * cpu-riscv.c (riscv_scan): New.
1403         (N): Change bfd_default_scan to riscv_scan.
1404
1405 2020-01-27  Andreas Schwab  <schwab@suse.de>
1406
1407         * Makefile.am (ALL_MACHINES): Remove cpu-plugin.lo.
1408         (ALL_MACHINES_CFILES): Remove cpu-plugin.c.
1409         * Makefile.in: Regenerate.
1410         * cpu-plugin.c: Remove.
1411         * archures.c (enum bfd_architecture): Remove bfd_arch_plugin.
1412         (bfd_plugin_arch): Remove declaration.
1413         * bfd-in2.h: Regenerate.
1414         * po/SRC-POTFILES.in: Regenerate.
1415
1416 2020-01-27  H.J. Lu  <hongjiu.lu@intel.com>
1417             Alan Modra  <amodra@gmail.com>
1418
1419         PR ld/25458
1420         * elflink.c (_bfd_elf_gc_mark_rsec): Mark all weak aliases.
1421
1422 2020-01-24  Jim Wilson  <jimw@sifive.com>
1423
1424         * elfxx-riscv.c (riscv_get_prefix_class): Format s case like others.
1425         (riscv_parse_prefixed_ext): Fix s extension comment and reword to
1426         avoid over long line.
1427
1428 2020-01-24  Nick Clifton  <nickc@redhat.com>
1429
1430         PR 25447
1431         * coffgen.c (_bfd_coff_close_and_cleanup): Do not clear the keep
1432         syms and keep strings flags as these may have been set in order to
1433         prevent a bogus call to free.
1434
1435 2020-01-23  Nick Clifton  <nickc@redhat.com>
1436
1437         * po/fr.po: Updated French translation.
1438
1439 2020-01-23  Alan Modra  <amodra@gmail.com>
1440
1441         PR 25444
1442         * elf.c (assign_file_positions_for_load_sections): Avoid divide
1443         by zero when p_align is zero.
1444
1445 2020-01-22  Maxim Blinov  <maxim.blinov@embecosm.com>
1446
1447         * bfd/elfnn-riscv.c (riscv_skip_prefix): New.
1448         (riscv_prefix_cmp): Likewise.
1449         (riscv_non_std_ext_p): Deleted.
1450         (riscv_std_sv_ext_p): Likewise.
1451         (riscv_non_std_sv_ext_p): Likewise.
1452         (riscv_merge_non_std_and_sv_ext): Rename to...
1453         (riscv_merge_multi_letter_ext): and modified to use riscv_prefix_cmp.
1454         (riscv_merge_arch_attr_info): Replace 3 calls to
1455         riscv_merge_non_std_and_sv_ext with single call to
1456         riscv_merge_multi_letter_ext.
1457         * bfd/elfxx-riscv.c (riscv_parse_std_ext): Break if we
1458         encounter a 'z' prefix.
1459         (riscv_get_prefix_class): New function, return prefix class based
1460         on first few characters of input string.
1461         (riscv_parse_config): New structure to factor out minor differences
1462         in extension class parsing behaviour.
1463         (riscv_parse_sv_or_non_std_ext): Rename to...
1464         (riscv_parse_prefixed_ext): and parameterise with
1465         riscv_parse_config.
1466         (riscv_std_z_ext_strtab, riscv_std_s_ext_strtab): New.
1467         (riscv_multi_letter_ext_valid_p): New.
1468         (riscv_ext_x_valid_p, riscv_ext_z_valid_p, riscv_ext_s_valid_p): New.
1469         (riscv_parse_subset): Delegate all non-single-letter parsing work
1470         to riscv_parse_prefixed_ext.
1471         * bfd/elfxx-riscv.h (riscv_isa_ext_class): New type.
1472         (riscv_get_prefix_class): Declare.
1473
1474 2020-01-22  Alan Modra  <amodra@gmail.com>
1475
1476         * elf64-ppc.c (struct ppc_link_hash_table): Add tga_group.
1477         (ppc64_elf_archive_symbol_lookup): Extract __tls_get_addr_opt for
1478         __tls_get_addr_desc.
1479         (ppc64_elf_size_stubs): Add section for linker generated
1480         __tls_get_addr_desc wrapper function.  Loop at least once if
1481         generating this function.
1482         (emit_tga_desc, emit_tga_desc_eh_frame): New functions.
1483         (ppc64_elf_build_stubs): Generate __tls_get_addr_desc.
1484
1485 2020-01-22  Alan Modra  <amodra@gmail.com>
1486
1487         * elf64-ppc.h (struct ppc64_elf_params): Add no_tls_get_addr_regsave.
1488         * elf64-ppc.c (struct ppc_link_hash_table): Add tga_desc and
1489         tga_desc_fd.
1490         (is_tls_get_addr): Match tga_desc and tga_desc_df too.
1491         (STDU_R1_0R1, ADDI_R1_R1): Define.
1492         (tls_get_addr_prologue, tls_get_addr_epilogue): New functions.
1493         (ppc64_elf_tls_setup): Set up tga_desc and tga_desc_fd.  Indirect
1494         tga_desc_fd to opt_fd, and tga_desc to opt.  Set
1495         no_tls_get_addr_regsave.
1496         (branch_reloc_hash_match): Add hash3 and hash4.
1497         (ppc64_elf_tls_optimize): Handle tga_desc_fd and tga_desc too.
1498         (ppc64_elf_size_dynamic_sections): Likewise.
1499         (ppc64_elf_relocate_section): Likewise.
1500         (plt_stub_size, build_plt_stub): Likewise.  Size regsave
1501         __tls_get_addr stub.
1502         (build_tls_get_addr_stub): Build regsave __tls_get_addr stub and
1503         eh_frame.
1504         (ppc_size_one_stub): Handle tga_desc_fd and tga_desc too.  Size
1505         eh_frame for regsave __tls_get_addr.
1506
1507 2020-01-22  Alan Modra  <amodra@gmail.com>
1508
1509         * elf64-ppc.c (ppc64_elf_size_stubs): Correct condition under
1510         which __tls_get_addr calls will be eliminated.
1511
1512 2020-01-20  Nick Clifton  <nickc@redhat.com>
1513
1514         * po/pt.po: Updates Portuguese translation.
1515         * po/ru.po: Updated Russian translation.
1516         * po/uk.po: Updated Ukranian translation.
1517
1518 2020-01-20  H.J. Lu  <hongjiu.lu@intel.com>
1519
1520         PR ld/25416
1521         * elf64-x86-64.c (elf_x86_64_check_tls_transition): Support
1522         "rex leal x@tlsdesc(%rip), %reg" and "call *x@tlsdesc(%eax)" in
1523         X32 mode.
1524         (elf_x86_64_relocate_section): In x32 mode, for GDesc -> LE
1525         transition, relax "rex leal x@tlsdesc(%rip), %reg" to
1526         "rex movl $x@tpoff, %reg", for GDesc -> IE transition, relax
1527         "rex leal x@tlsdesc(%rip), %reg" to
1528         "rex movl x@gottpoff(%rip), %eax".  For both transitions, relax
1529         "call *(%eax)" to "nopl (%rax)".
1530
1531 2020-01-20  Alan Modra  <amodra@gmail.com>
1532
1533         * elf64-ppc.c (LD_R11_0R3, CMPDI_R11_0, STD_R11_0R1, LD_R11_0R1),
1534         (MTLR_R11): Don't define.
1535         (LD_R0_0R3, CMPDI_R0_0): Define.
1536         (build_tls_get_addr_stub): Don't use r11 in stub.
1537
1538 2020-01-20  Alan Modra  <amodra@gmail.com>
1539
1540         * elf64-ppc.c (ppc_elf_hash_entry): New function, use throughout file.
1541         (defined_sym_val, is_tls_get_addr): Likewise.
1542
1543 2020-01-18  Nick Clifton  <nickc@redhat.com>
1544
1545         * version.m4 (BFD_VERSION): Set to 2.34.50.
1546         * configure: Regenerate.
1547         * po/bfd.pot: Regenerate.
1548
1549 2020-01-18  Nick Clifton  <nickc@redhat.com>
1550
1551         Binutils 2.34 branch created.
1552
1553 2020-01-17  Christian Biesinger  <cbiesinger@google.com>
1554
1555         * coff-arm.c: Fix spelling error (seperate).
1556         * elfxx-riscv.c (riscv_parse_sv_or_non_std_ext): Fix spelling
1557         error (seperate).
1558         * sysdep.h (strnlen): Fix spelling error (seperate).
1559
1560 2020-01-15  Lars Brinkhoff  <lars@nocrew.org>
1561
1562         PR 20694
1563         * pdp11.c (TARGET_PAGE_SIZE): Set to 8192.
1564
1565 2020-01-15  Alan Modra  <amodra@gmail.com>
1566
1567         PR 25384
1568         * elf64-ppc.c (ELIMINATE_COPY_RELOCS): Update comment.
1569         (ppc64_elf_adjust_dynamic_symbol): Don't allow .dynbss copies
1570         of function symbols unless dot symbols are present.  Do warn
1571         whenever one is created, regardles of whether a PLT entry is
1572         also emitted for the function symbol.
1573
1574 2020-01-14  Alan Modra  <amodra@gmail.com>
1575
1576         * som.c (som_bfd_count_ar_symbols): Error when file position
1577         of symbols on chains is not strictly increasing.
1578
1579 2020-01-14  Alan Modra  <amodra@gmail.com>
1580
1581         * vms.h (VMS_DEBUG): Define as 0.
1582         * vms-alpha.c (image_write): Move debug output after bounds check.
1583         Tidy bounds check.
1584         (_bfd_vms_slurp_eihd): Warning fix.
1585         (_bfd_vms_slurp_etir): Init variables to avoid bogus warnings.
1586
1587 2020-01-13  Alan Modra  <amodra@gmail.com>
1588
1589         * vms-alpha.c (_bfd_vms_slurp_egsd): Ensure minimum size even
1590         for "ignored" records.
1591
1592 2020-01-13  Alan Modra  <amodra@gmail.com>
1593
1594         * wasm-module.c (wasm_scan_name_function_section): Formatting.
1595         Delete asect name check.  Move asect NULL check to wasm_object_p.
1596         Correct bounds check of sizes against end.  Replace uses of
1597         bfd_zalloc with bfd_alloc, zeroing only necessary bytes.  Use
1598         just one bfd_release.
1599         (wasm_scan): Don't use malloc/strdup for section names,
1600         bfd_alloc instead.  Simplify code prefixing section name.
1601         Formatting.  Don't attempt to free memory here..
1602         (wasm_object_p): ..do so here.
1603
1604 2020-01-10  Szabolcs Nagy  <szabolcs.nagy@arm.com>
1605
1606         PR ld/22269
1607         * elf32-arm.c (elf32_arm_final_link_relocate): Use
1608         UNDEFWEAK_NO_DYNAMIC_RELOC.
1609         (allocate_dynrelocs_for_symbol): Likewise.
1610
1611 2020-01-10  Tamar Christina  <tamar.christina@arm.com>
1612
1613         PR 25210
1614         * elfnn-aarch64.c (_bfd_aarch64_create_stub_section): Remove elfclass.
1615
1616 2020-01-10  Alan Modra  <amodra@gmail.com>
1617
1618         * coff-alpha.c (alpha_ecoff_object_p): Calculate size in bfd_size_type.
1619
1620 2020-01-09  Nick Clifton  <nickc@redhat.com>
1621
1622         PR 25221
1623         * bfd.c (bfd_convert_section_contents): Check for a compress
1624         header size that is larger than the actual section size.
1625
1626 2020-01-08  Alan Modra  <amodra@gmail.com>
1627
1628         PR 25351
1629         * elflink.c (bfd_elf_final_link): Call _bfd_fix_excluded_sec_syms
1630         after removing sections.
1631
1632 2020-01-06  Jim Wilson  <jimw@sifive.com>
1633
1634         PR 25205
1635         * elfnn-riscv.c (riscv_elf_relocate_section) <R_RISCV_CALL>: Add
1636         check for !bfd_link_pic (info).
1637         <R_RISCV_CALL_PLT>: Move next to R_RISCV_CALL.
1638         <R_RISCV_JAL>: Add comment.
1639         (_bfd_riscv_relax_section): For plt.offset check, add check for
1640         bfd_link_pic (info).  Add comment.
1641
1642 2020-01-06  Alan Modra  <amodra@gmail.com>
1643
1644         * format.c (bfd_check_format_matches): Ignore bfd_error on target
1645         match failures.  Don't init to bfd_error_wrong_format before
1646         calling _bfd_check_format.
1647
1648 2020-01-06  Alan Modra  <amodra@gmail.com>
1649
1650         * vms-alpha.c (_bfd_vms_push, _bfd_vms_pop): Return pass/fail
1651         status rather than exiting on stack overflow or underflow.
1652         (_bfd_vms_slurp_etir): Adjust to suit.
1653
1654 2020-01-06  Alan Modra  <amodra@gmail.com>
1655
1656         * som.c (som_bfd_fill_in_ar_symbols): Bounds check som_dict index.
1657
1658 2020-01-06  Alan Modra  <amodra@gmail.com>
1659
1660         * mach-o.c (bfd_mach_o_read_dylinker): Don't read past end of
1661         command.  Check name offset is within command.
1662         (bfd_mach_o_read_dylib, bfd_mach_o_read_prebound_dylib),
1663         (bfd_mach_o_read_prebind_cksum, bfd_mach_o_read_twolevel_hints),
1664         (bfd_mach_o_read_fvmlib, bfd_mach_o_read_dysymtab),
1665         (bfd_mach_o_read_symtab, bfd_mach_o_read_uuid),
1666         (bfd_mach_o_read_linkedit, bfd_mach_o_read_str),
1667         (bfd_mach_o_read_dyld_info, bfd_mach_o_read_version_min),
1668         (bfd_mach_o_read_encryption_info, bfd_mach_o_read_source_version),
1669         (bfd_mach_o_read_encryption_info_64, bfd_mach_o_read_main),
1670         (bfd_mach_o_read_note, bfd_mach_o_read_build_version),
1671         (bfd_mach_o_read_segment): Similarly.
1672         (bfd_mach_o_read_thread): Properly bound check thread struct.
1673         Don't repeat checks on second loop.
1674         (bfd_mach_o_read_command): Fail on invalid command length.
1675
1676 2020-01-04  Alan Modra  <amodra@gmail.com>
1677
1678         * format.c (bfd_check_format_matches): Add preserve_match.
1679         Save initial bfd state in "preserve", matched bfd state in
1680         "preserve_match".  Save just the first match.  Release
1681         bfd_alloc memory.  Restore and finish preserved state as
1682         appropriate on all function exit paths.
1683
1684 2020-01-04  Alan Modra  <amodra@gmail.com>
1685
1686         * mmo.c (mmo_mkobject): Allocate tdata with bfd_zalloc.
1687
1688 2020-01-04  Alan Modra  <amodra@gmail.com>
1689
1690         * coffgen.c (coff_real_object_p): Free malloc'd memory on target
1691         match too.
1692
1693 2020-01-03  Nick Clifton  <nickc@redhat.com>
1694
1695         PR 25307
1696         (bfd_pef_parse_function_stubs): Correct the test that ensures that
1697         there is enough data remaining in the code buffer before
1698         attempting to read a function stub.
1699
1700 2020-01-03  Nick Clifton  <nickc@redhat.com>
1701
1702         PR 25308
1703         * elf-properties.c (_bfd_elf_convert_gnu_properties): Check the
1704         return value from bfd_malloc.
1705         * elf32-arm.c (bfd_elf32_arm_vfp11_fix_veneer_locations): Likewise.
1706         (bfd_elf32_arm_stm32l4xx_fix_veneer_locations): Likewise.
1707         (elf32_arm_filter_cmse_symbols): Likewise.
1708         (elf32_arm_write_section): Likewise.
1709         * mach-o.c (bfd_mach_o_core_fetch_environment): Likewise.
1710         (bfd_mach_o_follow_dsym): Likewise.
1711         * pef.c (bfd_pef_print_loader_section): Likewise.
1712         (bfd_pef_scan_start_address): Likewise.
1713         (bfd_pef_parse_function_stubs): Likewise.
1714         (bfd_pef_parse_symbols): Likewise.
1715
1716 2020-01-03  Sergei Trofimovich  <siarheit@google.com>
1717
1718         * elfnn-ia64.c (elfNN_ia64_merge_private_bfd_data): don't fail
1719         on binary inputs ld/PR25316.
1720         (is_ia64_elf): new helper to filter on ia64 objects.
1721
1722 2020-01-03  Jan Beulich  <jbeulich@suse.com>
1723
1724         * mach-o.c (cpusubtype, bfd_mach_o_header_p): Insert underscore
1725         in parameter names.
1726         (bfd_mach_o_scan): Insert underscore in two variable names.
1727
1728 2020-01-02  Sergey Belyashov  <sergey.belyashov@gmail.com>
1729
1730         * Makefile.am: Add z80-elf target support.
1731         * configure.ac: Likewise.
1732         * targets.c: Likewise.
1733         * Makefile.in: Regenerate.
1734         * configure: Regenerate.
1735         * config.bfd: Add z80-elf target support and new arches: ez80 and
1736         z180.
1737         * elf32-z80.c: New file.
1738         * archures.c: Add new z80 architectures: eZ80 and Z180.
1739         * coffcode.h: Likewise.
1740         * cpu-z80.c: Likewise.
1741         * coff-z80.c: Add new relocations for Z80 target and local label
1742         check.
1743         * reloc.c: Add new relocs.
1744         * bfd-in2.h: Regenerate.
1745         * libbfd.h: Regenerate.
1746
1747 2020-01-02  Tamar Christina  <tamar.christina@arm.com>
1748
1749         PR 25210
1750         PR 24753
1751         * elfnn-aarch64.c (_bfd_aarch64_create_stub_section): Set ELF class.
1752
1753 2020-01-01  Alan Modra  <amodra@gmail.com>
1754
1755         Update year range in copyright notice of all files.
1756
1757 For older changes see ChangeLog-2019
1758 \f
1759 Copyright (C) 2020 Free Software Foundation, Inc.
1760
1761 Copying and distribution of this file, with or without modification,
1762 are permitted in any medium without royalty provided the copyright
1763 notice and this notice are preserved.
1764
1765 Local Variables:
1766 mode: change-log
1767 left-margin: 8
1768 fill-column: 74
1769 version-control: never
1770 End: