bfd/ChangeLog

   1 2020-04-01  H.J. Lu  <hongjiu.lu@intel.com>
   2
   3         PR ld/25749
   4         PR ld/25754
   5         * elf32-i386.c (elf_i386_convert_load_reloc): Convert load
   6         relocation to R_386_32 for relocation against non-preemptible
   7         absolute symbol.
   8         (elf_i386_check_relocs): Call _bfd_elf_x86_valid_reloc_p.  Don't
   9         allocate dynamic relocation for non-preemptible absolute symbol.
  10         (elf_i386_relocate_section): Pass sec to
  11         GENERATE_DYNAMIC_RELOCATION_P.
  12         * elf64-x86-64.c (R_X86_64_converted_reloc_bit): Moved.
  13         (elf_x86_64_convert_load_reloc): Covert load relocation to
  14         R_X86_64_32S or R_X86_64_32 for relocation against non-preemptible
  15         absolute symbol.  Don't convert to R_X86_64_32S nor R_X86_64_32
  16         for non-preemptible absolute symbol if they overflow.
  17         (elf_x86_64_check_relocs): Call _bfd_elf_x86_valid_reloc_p.  Set
  18         tls_type for GOT slot to GOT_ABS for non-preemptible absolute
  19         symbol.  Don't allocate dynamic relocation for non-preemptible
  20         absolute symbol.
  21         (elf_x86_64_relocate_section): Don't generate relative relocation
  22         for GOTPCREL relocations aganst local absolute symbol.  Pass sec
  23         to GENERATE_DYNAMIC_RELOCATION_P.
  24         * elfxx-x86.c (elf_x86_allocate_dynrelocs): No dynamic relocation
  25         against non-preemptible absolute symbol.
  26         (_bfd_elf_x86_valid_reloc_p): New function.
  27         (_bfd_x86_elf_size_dynamic_sections): No dynamic relocation for
  28         GOT_ABS GOT slot.
  29         * elfxx-x86.h (GENERATE_DYNAMIC_RELOCATION_P): Add an SEC
  30         argument.  Don't generate dynamic relocation against
  31         non-preemptible absolute symbol.
  32         (ABS_SYMBOL_P): New.
  33         (GENERATE_RELATIVE_RELOC_P): Don't generate relative relocation
  34         against non-preemptible absolute symbol.
  35         (GOT_ABS): New.
  36         (R_X86_64_converted_reloc_bit): New.  Moved from elf64-x86-64.c.
  37         (_bfd_elf_x86_valid_reloc_p): New.
  38
  39 2020-04-01  Tamar Christina  <tamar.christina@arm.com>
  40
  41         PR ld/16017
  42         * elf32-arm.c (elf32_arm_populate_plt_entry): Set LSB of the PLT0
  43         address in the GOT if in thumb only mode.
  44
  45 2020-04-01  Tamar Christina  <tamar.christina@arm.com>
  46
  47         * elf32-arm.c (elf32_thumb2_plt_entry): Fix PC-rel offset.
  48
  49 2020-04-01  Hans-Peter Nilsson  <hp@bitrange.com>
  50
  51         * mmo.c (mmo_scan): Create .text section only when needed, not
  52         from the start.
  53
  54 2020-03-31  Alan Modra  <amodra@gmail.com>
  55
  56         * coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Correct bfd_bread
  57         return value check.
  58
  59 2020-03-31  Alan Modra  <amodra@gmail.com>
  60
  61         * vms-alpha.c (image_write): Check bounds for sections without
  62         contents too.  Error on non-zero write to section without
  63         contents.
  64         (_bfd_vms_slurp_etir): Check return of image_write* functions.
  65
  66 2020-03-31  Alan Modra  <amodra@gmail.com>
  67
  68         * tekhex.c (pass_over): Check is_eof before reading buffer.
  69
  70 2020-03-30  Nick Clifton  <nickc@redhat.com>
  71
  72         PR binutils/pr25662
  73         * libcoff-in.h (struct pe_tdata): Rename the insert_timestamp
  74         field to timestamp and make it an integer.
  75         * libcoff.h: Regenerate.
  76         * peXXigen.c (_bfd_XXi_only_swap_filehdr_out): Test the timestamp
  77         field in the pe_data structure rather than the insert_timestamp
  78         field.
  79
  80 2020-03-30  Alan Modra  <amodra@gmail.com>
  81
  82         PR 25745
  83         * elf64-ppc.c (ppc64_elf_build_stubs): Use asprintf to form
  84         statistics message.
  85
  86 2020-03-26  Nick Clifton  <nickc@redhat.com>
  87
  88         * cofflink.c (bfd_coff_get_internal_extra_pe_aouthdr): Delete.
  89         * libbfd-in.h (bfd_coff_get_internal_extra_pe_aouthdr): Remove
  90         prototype.
  91         * libbfd.h: Regenerate.
  92
  93 2020-03-26  Alan Modra  <amodra@gmail.com>
  94
  95         * i386msdos.c (msdos_object_p): Catch -1 return from bfd_bread.
  96
  97 2020-03-26  Alan Modra  <amodra@gmail.com>
  98
  99         * vms-alpha.c (dst_define_location): Limit size of dst_ptr_offsets
 100         array.
 101         (_bfd_vms_slurp_object_records): Rename "err" to "ok".
 102
 103 2020-03-25  Nick Clifton  <nickc@redhat.com>
 104
 105         * cofflink.c (bfd_coff_get_internal_extra_pe_aouthdr): New
 106         function.
 107         * libbfd-in.h (bfd_coff_get_internal_extra_pe_aouthdr): Prototype.
 108         * libbfd.h: Regenerate.
 109
 110 2020-03-25  Shahab Vahedi  <shahab@synopsys.com>
 111
 112         * elf32-arc.c (PRINT_DEBUG_RELOC_INFO_BEFORE): Use the
 113         correct field name in the output string.
 114
 115 2020-03-25  Alan Modra  <amodra@gmail.com>
 116
 117         PR 25662
 118         * elf.c (assign_file_positions_for_load_sections): Adjust offset
 119         for SHT_NOBITS section if first in segment.
 120
 121 2020-03-24  H.J. Lu  <hongjiu.lu@intel.com>
 122
 123         PR binutils/25708
 124         * elf-bfd.h (_bfd_elf_get_symbol_version_name): Renamed to ...
 125         (_bfd_elf_get_symbol_version_string): This.
 126         * elf.c (_bfd_elf_get_symbol_version_name): Renamed to ...
 127         (_bfd_elf_get_symbol_version_string): This.
 128         (bfd_elf_print_symbol): Pass TRUE to
 129         _bfd_elf_get_symbol_version_string.
 130         * libbfd-in.h (_bfd_nosymbols_get_symbol_version_string): Add a
 131         bfd_boolean argument.
 132         * syms.c (_bfd_nosymbols_get_symbol_version_string): Likewise.
 133         * targets.c  (_bfd_get_symbol_version_string): Likewise.
 134         (bfd_get_symbol_version_string): Likewise.
 135         * bfd-in2.h: Regenerated.
 136
 137 2020-03-24  Nick Clifton  <nickc@redhat.com>
 138             Jaydeep Chauhan  <jaydeepchauhan1494@gmail.com>
 139
 140         PR 25713
 141         * bfdio.c (_bfd_real_fopen): Add code to handle long filenames on
 142         Win32 systems.
 143
 144 2020-03-24  Nick Clifton  <nickc@redhat.com>
 145
 146         PR 25681
 147         * elf.c (_bfd_elf_map_sections_to_segments): When looking for a
 148         segment to use for PT_GNU_RELRO, ignore empty sections in a
 149         segment's current list.
 150
 151 2020-03-24  H.J. Lu  <hongjiu.lu@intel.com>
 152
 153         PR binutils/25717
 154         * elf-bfd.h (elf_obj_tdata): Change num_group to unsigned int.
 155
 156 2020-03-24  H.J. Lu  <hongjiu.lu@intel.com>
 157
 158         PR binutils/25708
 159         * elf-bfd.h (_bfd_elf_get_symbol_version_name): New.
 160         * elf.c (_bfd_elf_get_symbol_version_name): New function.  Based
 161         on the previous _bfd_elf_get_symbol_version_string.
 162         (_bfd_elf_get_symbol_version_string): Use it.
 163
 164 2020-03-24  Alan Modra  <amodra@gmail.com>
 165
 166         * archive.c (_bfd_generic_read_ar_hdr_mag): Sanity check extended
 167         name size.  Use bfd_malloc rather than bfd_zmalloc, clearing just
 168         struct areltdata.
 169
 170 2020-03-23  Sebastian Huber  <sebastian.huber@embedded-brains.de>
 171
 172         * elflink.c (_bfd_elf_tls_setup): Mention .tdata in comment.
 173
 174 2020-03-23  Alan Modra  <amodra@gmail.com>
 175
 176         * ecoff.c (_bfd_ecoff_slurp_armap): Sanity check parsed_size and
 177         symbol count.  Allocate an extra byte to ensure name strings
 178         are terminated.  Sanity check name offsets.  Release memory on
 179         error return.
 180
 181 2020-03-23  Alan Modra  <amodra@gmail.com>
 182
 183         * i386msdos.c (msdos_object_p): Don't access e_lfanew when that
 184         field hasn't been read.  Remove unnecessary casts.
 185
 186 2020-03-22  Alan Modra  <amodra@gmail.com>
 187
 188         * coff64-rs6000.c (xcoff64_slurp_armap): Ensure size is large
 189         enough to read number of symbols.
 190
 191 2020-03-20  H.J. Lu  <hongjiu.lu@intel.com>
 192
 193         * configure.ac (HAVE_EXECUTABLE_SUFFIX): Removed.
 194         (EXECUTABLE_SUFFIX): Likewise.
 195         * config.in: Regenerated.
 196         * configure: Likewise.
 197         * plugin.c (bfd_plugin_close_and_cleanup): Defined as
 198         _bfd_generic_close_and_cleanup.
 199         (plugin_list_entry): Remove resolution_file, resolution_option,
 200         real_bfd, real_nsyms, real_syms, lto_nsyms, lto_syms, gcc,
 201         lto_wrapper, gcc_env and initialized,
 202         (need_lto_wrapper_p): Removed.
 203         (get_lto_wrapper): Likewise.
 204         (setup_lto_wrapper_env): Likewise.
 205         (register_all_symbols_read): Likewise.
 206         (egister_cleanup): Likewise.
 207         (get_symbols): Likewise.
 208         (add_input_file): Likewise.
 209         (bfd_plugin_set_program_name): Remove need_lto_wrapper.
 210         (add_symbols): Updated.
 211         (try_claim): Likewise.
 212         (try_load_plugin): Likewise.
 213         (bfd_plugin_canonicalize_symtab): Likewise.
 214         * plugin.h (bfd_plugin_set_program_name): Remove int argument.
 215         (plugin_data_struct): Remove real_bfd, real_nsyms and real_syms.
 216
 217 2020-03-19  H.J. Lu  <hongjiu.lu@intel.com>
 218
 219         PR binutils/25640
 220         * plugin.c (plugin_list_entry): Add has_symbol_type.
 221         (add_symbols_v2): New function.
 222         (bfd_plugin_open_input): Don't invoke LTO wrapper if LTO plugin
 223         provides symbol type.
 224         (try_load_plugin): Add LDPT_ADD_SYMBOLS_V2.
 225         (bfd_plugin_canonicalize_symtab): Use LTO plugin symbol type if
 226         available.
 227
 228 2020-03-20  Alan Modra  <amodra@gmail.com>
 229
 230         * coff-rs6000.c (_bfd_xcoff_slurp_armap): Ensure size is large
 231         enough to read number of symbols.
 232
 233 2020-03-20  Alan Modra  <amodra@gmail.com>
 234
 235         * elf.c (_bfd_elf_setup_sections): Don't test known non-NULL
 236         backend functions for NULL before calling.
 237         (copy_special_section_fields, _bfd_elf_copy_private_bfd_data),
 238         (bfd_section_from_shdr, assign_section_numbers): Likewise.
 239         * elfcode.h (elf_write_relocs, elf_slurp_reloc_table): Likewise.
 240         * elfnn-ia64.c (ignore_errors): New function.
 241         (elf_backend_link_order_error_handler): Redefine as ignore_errors.
 242
 243 2020-03-19  Nick Clifton  <nickc@redhat.com>
 244
 245         PR 25676
 246         * dwarf2.c (struct varinfo): Add unit_offset field to record the
 247         location of the varinfo in the unit's debug info data.  Change the
 248         type of the stack field to a boolean.
 249         (lookup_var_by_offset): New function.  Returns the varinfo
 250         structure for the variable described at the given offset in the
 251         unit's debug info.
 252         (scan_unit_for_symbols): Add support for variables which have the
 253         DW_AT_specification attribute.
 254
 255 2020-03-19  Nick Clifton  <nickc@redhat.com>
 256
 257         PR 25699
 258         * elf.c (bfd_elf_set_group_contents): Replace assertion with an
 259         error return.
 260
 261 2020-03-19  Sebastian Huber  <sebastian.huber@embedded-brains.de>
 262
 263         * elfxx-riscv.c (riscv_parse_subset): Don't use C99.
 264
 265 2020-03-18  Nick Clifton  <nickc@redhat.com>
 266
 267         PR 25673
 268         * elf.c (_bfd_elf_write_secondary_reloc_section): Fix illegal
 269         memory access when processing a corrupt secondary reloc section.
 270
 271 2020-03-18  Christophe Lyon  <christophe.lyon@linaro.org>
 272
 273         * elf32-arm.c (arm_build_one_stub): Emit a fatal error message
 274         instead of calling abort.
 275         * elf32-csky.c (csky_build_one_stub): Likewise.
 276         * elf32-hppa.c (hppa_build_one_stub): Likewise.
 277         * elf32-m68hc11.c (m68hc11_elf_build_one_stub): Likewise.
 278         * elf32-m68hc12.c (m68hc12_elf_build_one_stub): Likewise.
 279         * elf32-metag.c (metag_build_one_stub): Likewise.
 280         * elf32-nios2.c (nios2_build_one_stub): Likewise.
 281         * elf64-ppc.c (ppc_build_one_stub): Likewise.
 282         (ppc_size_one_stub): Likewise.
 283         * elfnn-aarch64.c (aarch64_build_one_stub): Likewise.
 284
 285 2020-03-17  Nick Clifton  <nickc@redhat.com>
 286
 287         PR 25688
 288         * elf.c (_bfd_elf_copy_special_section_fields): Replace assertions
 289         with error messages.
 290
 291 2020-03-17  Nick Clifton  <nickc@redhat.com>
 292
 293         PR 25687
 294         * elf.c (_bfd_elf_slurp_secondary_reloc_section): Remove redundant
 295         free.  Add free on another failure path.
 296
 297 2020-03-16  Alan Modra  <amodra@gmail.com>
 298
 299         PR 25675
 300         * elf.c (elf_sort_segments): Don't call bfd_octets_per_byte unless
 301         we have a non-zero section count.  Do lma comparison in octets.
 302
 303 2020-03-16  Alan Modra  <amodra@gmail.com>
 304
 305         * vms-alpha.c (dst_restore_location): Validate index into
 306         dst_ptr_offsets array before accessing.  Return status.
 307         (dst_retrieve_location): Similarly, making "loc" parameter a
 308         pointer to return value.
 309         (_bfd_vms_slurp_etir): Update calls to above functions.
 310
 311 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
 312
 313         * configure.ac: Include netbsd-core.lo for all NetBSD arm and mips
 314         targets.
 315         * configure: Regenerated.
 316
 317 2020-03-14  Alan Modra  <amodra@gmail.com>
 318
 319         * section.c (BFD_FAKE_SECTIONS): Formatting.
 320         * bfd-in2.h: Regenerate.
 321
 322 2020-03-13  Kamil Rytarowski  <n54@gmx.com>
 323
 324         * elf.c (elfcore_grok_netbsd_note): Add support for
 325         NT_NETBSDCORE_LWPSTATUS notes.
 326
 327 2020-03-13  Christophe Lyon  <christophe.lyon@linaro.org>
 328
 329         * bfd-in2.h: Regenerate.
 330         * section.c (asection): Add already_assigned field.
 331         (BFD_FAKE_SECTION): Add default initializer for it.
 332         * ecoff.c (bfd_debug_section): Initialize already_assigned field.
 333         * elf32-arm.c (arm_build_one_stub): Add support for
 334         non_contiguous_regions.
 335         * elf32-csky.c (csky_build_one_stub): Likewise.
 336         * elf32-hppa.c (hppa_build_one_stub): Likewise.
 337         * elf32-m68hc11.c (m68hc11_elf_build_one_stub): Likewise.
 338         * elf32-m68hc12.c (m68hc12_elf_build_one_stub): Likewise.
 339         * elf32-metag.c (metag_build_one_stub): Likewise.
 340         * elf32-nios2.c (nios2_build_one_stub): Likewise.
 341         * elf64-ppc.c (ppc_build_one_stub): Likewise.
 342         (ppc_size_one_stub): Likewise.
 343         * elfnn-aarch64.c (aarch64_build_one_stub): Likewise.
 344         * elflink.c (elf_link_input_bfd): Likewise.
 345
 346 2020-03-13  H.J. Lu  <hongjiu.lu@intel.com>
 347
 348         PR ld/24920
 349         * elf-linker-x86.h (elf_linker_x86_params): Add
 350         static_before_all_inputs and has_dynamic_linker.
 351         * elfxx-x86.c (_bfd_x86_elf_link_setup_gnu_properties): Report
 352         dynamic input objects if -static is passed at command-line
 353         before all input files without --dynamic-linker unless
 354         --no-dynamic-linker is used.
 355
 356 2020-03-13  Kamil Rytarowski  <n54@gmx.com>
 357
 358         * elf.c (elfcore_grok_netbsd_note): Add support for aarch64.
 359
 360 2020-03-13  Christian Eggers  <ceggers@gmx.de>
 361
 362         * bfd.c (bfd_record_phdr): New local "opb".  Fix assignment of
 363         "p_paddr" from "at".
 364         * elfcode.h (bfd_from_remote_memory): Add units to several
 365         parameters.  New local "opb".  Fix usage of p_align.  Fix
 366         calculation of "localbase" from "ehdr_vma" and "p_vaddr".  Fix
 367         call of target_read_memory.
 368         * elflink.c (elf_fixup_link_order): Fix scope of "s" local.  Fix
 369         calculation of "offset" and "output_offset".
 370         (bfd_elf_final_link): New local "opb".  Fix calculation of "size"
 371         from "offset" and fix calculation of "end" from "vma+size".  Fix
 372         comparison between "sh_addr" and "vma"/"output_offset".
 373         (bfd_elf_discard_info): Fix calculation of "eh_alignment".
 374         * elf-bfd.h (struct elf_link_hash_table): Add unit to tls_size
 375         member.
 376         * elf.c (_bfd_elf_map_sections_to_segments): Add unit (bytes/
 377         octets) to "wrap_to2 and "phdr_size" locals.  Fix calculation of
 378         "wrap_to" value.  Add unit (bytes) to phdr_lma variable.  Fix
 379         assignment of p_paddr from phdr_lma.  Fix comparison between
 380         "lma+size" and "next->lma".
 381         (elf_sort_segments): Fix assignment from p_paddr to lma.
 382         (assign_file_positions_for_load_sections): Add unit (bytes) to
 383         local "align".  Fix calculation of local "off_adjust".  Fix
 384         calculation of local "filehdr_vaddr".
 385         (assign_file_positions_for_non_load_sections): New local "opb".
 386         Fix calculation of "end" from "p_size". Fix comparison between
 387         "vma+SECTION_SIZE" and "start".  Fix calculation of "p_memsz"
 388         from "end" and "p_vaddr".
 389         (rewrite_elf_program_header): Fix comparison between p_vaddr and
 390         vma.  Fix assignment to p_paddr from lma.  Fix comparison between
 391         p_paddr and lma.  Fix assignment to p_paddr from lma.
 392         * merge.c (sec_merge_emit): New local "opb". Convert
 393         "alignment_power" to octets.
 394         (_bfd_add_merge_section): New locals "alignment_power" and
 395         "opb".  Fix comparison between "alignment_power" and
 396         "sizeof(align)".
 397         (_bfd_merge_sections): New local "opb".  Divide size by opb
 398         before checking align mask.
 399
 400 2020-03-13  Christian Eggers  <ceggers@gmx.de>
 401
 402         * elf.c (_bfd_elf_make_section_from_shdr): Introduce new temp
 403         opb.  Divide Elf_Internal_Shdr::sh_addr by opb when setting
 404         section LMA/VMA.
 405         (_bfd_elf_make_section_from_phdr): Similarly.
 406         (elf_fake_sections): Fix calculation of
 407         Elf_Internal_shdr::sh_addr from section VMA.
 408         (_bfd_elf_map_sections_to_segments): Fix mixup between octets
 409         and bytes.
 410         (assign_file_positions_for_load_sections): Fix calculations of
 411         Elf_Internal_shdr::p_vaddr and p_paddr from section LMA/VMA.  Fix
 412         comparison between program header address and section LMA.
 413         (assign_file_positions_for_non_load_sections): Likewise.
 414         (rewrite_elf_program_header): Likewise.  Introduce new temp opb.
 415         (IS_CONTAINED_BY_VMA): Add parameter opb.
 416         (IS_CONTAINED_BY_LMA,IS_SECTION_IN_INPUT_SEGMENT,
 417         INCLUDE_SECTION_IN_SEGMENT): Likewise.
 418         (copy_elf_program_header): Update call to ELF_SECTION_IN_SEGMENT.
 419         Fix calculations of p_addr_valid and p_vaddr_offset.
 420         * elflink.c (elf_link_add_object_symbols): Multiply section VMA
 421         with octets per byte when comparing against p_vaddr.
 422
 423 2020-03-11  Alan Modra  <amodra@gmail.com>
 424
 425         * som.c (setup_sections): Sanity check subspace.name.
 426
 427 2020-03-11  Alan Modra  <amodra@gmail.com>
 428
 429         * elf64-ppc.c (ppc64_elf_inline_plt): Do increment rel in for loop.
 430
 431 2020-03-10  Alan Modra  <amodra@gmail.com>
 432
 433         PR 25648
 434         * ihex.c (ihex_write_object_contents): Don't assume ordering of
 435         addresses here.
 436
 437 2020-03-09  Alan Modra  <amodra@gmail.com>
 438
 439         * wasm-module.c (wasm_scan): Sanity check file name length
 440         before allocating memory.  Move common section setup code.  Do
 441         without bfd_tell to calculate section size.
 442
 443 2020-03-06  Nick Clifton  <nickc@redhat.com>
 444
 445         * elf.c (_bfd_elf_set_section_contents): Replace call to abort
 446         with error messages and failure return values.
 447
 448 2020-03-05  Max Filippov  <jcmvbkbc@gmail.com>
 449
 450         * elf32-xtensa.c (shrink_dynamic_reloc_sections): Shrink dynamic
 451         relocation sections for any removed reference to a dynamic symbol.
 452
 453 2020-03-05  Nick Clifton  <nickc@redhat.com>
 454
 455         * elf-bfd.h (struct elf_backend_data): Add new fields:
 456         init_secondary_reloc_section, slurp_secondary_reloc_section,
 457         write_secondary_reloc_section.
 458         (_bfd_elf_init_secondary_reloc_section): Prototype.
 459         (_bfd_elf_slurp_secondary_reloc_section): Prototype.
 460         (_bfd_elf_write_secondary_reloc_section): Prototype.
 461         * elf.c ( bfd_section_from_shdr): Invoke the new
 462         init_secondary_reloc_section backend function, if defined, when a
 463         second reloc section is encountered.
 464         (swap_out_syms): Invoke the new symbol_section_index function, if
 465         defined, when computing the section index of an OS/PROC specific
 466         symbol.
 467         (_bfd_elf_init_secondary_reloc_section): New function.
 468         (_bfd_elf_slurp_secondary_reloc_section): New function.
 469         (_bfd_elf_write_secondary_reloc_section): New function.
 470         (_bfd_elf_copy_special_section_fields): New function.
 471         * elfcode.h (elf_write_relocs): Invoke the new
 472         write_secondary_relocs function, if defined, in order to emit
 473         secondary relocs.
 474         (elf_slurp_reloc_table): Invoke the new slurp_secondary_relocs
 475         function, if defined, in order to read in secondary relocs.
 476         * elfxx-target.h (elf_backend_copy_special_section_fields):
 477         Provide a non-NULL default definition.
 478         (elf_backend_init_secondary_reloc_section): Likewise.
 479         (elf_backend_slurp_secondary_reloc_section): Likewise.
 480         (elf_backend_write_secondary_reloc_section): Likewise.
 481         (struct elf_backend_data elfNN_bed): Add initialisers for the new
 482         fields.
 483         * configure.ac (score_elf32_[bl]e_vec): Add elf64.lo
 484         * configure: Regenerate.
 485
 486 2020-03-05  Alan Modra  <amodra@gmail.com>
 487
 488         * archive64.c (_bfd_archive_64_bit_slurp_armap): Check parsed_size
 489         against file size before allocating memory.  Use bfd_alloc rather
 490         than bfd_zalloc for carsym/strings memory.
 491
 492 2020-03-04  Alan Modra  <amodra@gmail.com>
 493
 494         * elf.c (elf_fake_sections): Ensure sh_addralign is such that
 495         sh_addr mod sh_addalign is zero.
 496
 497 2020-03-04  Alan Modra  <amodra@gmail.com>
 498
 499         * format.c (bfd_check_format_matches): Call cleanup on error exit.
 500
 501 2020-03-03  Alan Modra  <amodra@gmail.com>
 502
 503         * format.c (struct bfd_preserve): Add cleanup field.
 504         (bfd_preserve_save): Add cleanup param and save.
 505         (bfd_preserve_restore): Return cleanup.
 506         (bfd_preserve_finish): Call the cleanup for the discarded match.
 507         (bfd_check_format_matches): Pass cleanup to bfd_preserve_save,
 508         and clear when preserving a match.  Restore cleanup too when
 509         restoring that match.
 510
 511 2020-03-02  Alan Modra  <amodra@gmail.com>
 512
 513         * cisco-core.c (cisco_core_file_p): Return bfd_cleanup.
 514         * hpux-core.c (hpux_core_core_file_p): Update prototype.
 515         * sco5-core.c (sco5_core_file_p): Return bfd_cleanup.
 516         (core_sco5_vec): Correct initialisers.
 517
 518 2020-03-02  Alan Modra  <amodra@gmail.com>
 519
 520         * aix386-core.c (aix386_core_file_p): Return bfd_cleanup.
 521         * aix5ppc-core.c (xcoff64_core_p): Likewise.
 522         * cisco-core.c (cisco_core_file_validate): Likewise.
 523         * hppabsd-core.c (hppabsd_core_core_file_p): Likewise.
 524         * hpux-core.c (hpux_core_core_file_p): Likewise.
 525         * irix-core.c (irix_core_core_file_p): Likewise.
 526         * lynx-core.c (lynx_core_file_p): Likewise.
 527         * netbsd-core.c (netbsd_core_file_p): Likewise.
 528         * osf-core.c (osf_core_core_file_p): Likewise.
 529         * ptrace-core.c (ptrace_unix_core_file_p): Likewise.
 530         * sco5-core.c (sco5_core_file_p): Likewise.
 531
 532 2020-03-02  H.J. Lu  <hongjiu.lu@intel.com>
 533
 534         * trad-core.c (trad_unix_core_file_p): Return bfd_cleanup.
 535
 536 2020-03-02  Alan Modra  <amodra@gmail.com>
 537
 538         * targets.c (bfd_cleanup): New typedef.
 539         (struct bfd <_bfd_check_format>): Return a bfd_cleanup.
 540         * libbfd-in.h (_bfd_no_cleanup): Define.
 541         * format.c (bfd_reinit): Add cleanup parameter, call it.
 542         (bfd_check_format_matches): Set cleanup from _bfd_check_format
 543         call and pass to bfd_reinit.  Delete temp, use abfd->xvec instead.
 544         * aout-target.h (callback, object_p): Return bfd_cleanup.
 545         * aout-tic30.c (tic30_aout_callback, tic30_aout_object_p): Likewise.
 546         * archive.c (bfd_generic_archive_p): Likewise.
 547         * binary.c (binary_object_p): Likewise.
 548         * coff-alpha.c (alpha_ecoff_object_p): Likewise.
 549         * coff-ia64.c (ia64coff_object_p): Likewise.
 550         * coff-rs6000.c (_bfd_xcoff_archive_p, rs6000coff_core_p): Likewise.
 551         * coff-sh.c (coff_small_object_p): Likewise.
 552         * coff-stgo32.c (go32_check_format): Likewise.
 553         * coff64-rs6000.c (xcoff64_archive_p, rs6000coff_core_p),
 554         (xcoff64_core_p): Likewise.
 555         * coffgen.c (coff_real_object_p, coff_object_p): Likewise.
 556         * elf-bfd.h (bfd_elf32_object_p, bfd_elf32_core_file_p),
 557         (bfd_elf64_object_p, bfd_elf64_core_file_p): Likewise.
 558         * elfcode.h (elf_object_p): Likewise.
 559         * elfcore.h (elf_core_file_p): Likewise.
 560         * i386msdos.c (msdos_object_p): Likewise.
 561         * ihex.c (ihex_object_p): Likewise.
 562         * libaout.h (some_aout_object_p): Likewise.
 563         * libbfd-in.h (bfd_generic_archive_p, _bfd_dummy_target),
 564         (_bfd_vms_lib_alpha_archive_p, _bfd_vms_lib_ia64_archive_p): Likewise.
 565         * libbfd.c (_bfd_dummy_target): Likewise.
 566         * libcoff-in.h (coff_object_p): Likewise.
 567         * mach-o-aarch64.c (bfd_mach_o_arm64_object_p),
 568         (bfd_mach_o_arm64_core_p): Likewise.
 569         * mach-o-arm.c (bfd_mach_o_arm_object_p),
 570         (bfd_mach_o_arm_core_p): Likewise.
 571         * mach-o-i386.c (bfd_mach_o_i386_object_p),
 572         (bfd_mach_o_i386_core_p): Likewise.
 573         * mach-o-x86-64.c (bfd_mach_o_x86_64_object_p),
 574         (bfd_mach_o_x86_64_core_p): Likewise.
 575         * mach-o.c (bfd_mach_o_header_p, bfd_mach_o_gen_object_p),
 576         (bfd_mach_o_gen_core_p, bfd_mach_o_fat_archive_p): Likewise.
 577         * mach-o.h (bfd_mach_o_object_p, bfd_mach_o_core_p),
 578         (bfd_mach_o_fat_archive_p, bfd_mach_o_header_p): Likewise.
 579         * mmo.c (mmo_object_p): Likewise.
 580         * pef.c (bfd_pef_object_p, bfd_pef_xlib_object_p): Likewise.
 581         * peicode.h (coff_real_object_p, pe_ILF_object_p),
 582         (pe_bfd_object_p): Likewise.
 583         * plugin.c (ld_plugin_object_p, bfd_plugin_object_p): Likewise.
 584         * ppcboot.c (ppcboot_object_p): Likewise.
 585         * rs6000-core.c (rs6000coff_core_p): Likewise.
 586         * som.c (som_object_setup, som_object_p): Likewise.
 587         * srec.c (srec_object_p, symbolsrec_object_p): Likewise.
 588         * tekhex.c (tekhex_object_p): Likewise.
 589         * vms-alpha.c (alpha_vms_object_p): Likewise.
 590         * vms-lib.c (_bfd_vms_lib_archive_p, _bfd_vms_lib_alpha_archive_p),
 591         (_bfd_vms_lib_ia64_archive_p, _bfd_vms_lib_txt_archive_p): Likewise.
 592         * wasm-module.c (wasm_object_p): Likewise.
 593         * xsym.c (bfd_sym_object_p): Likewise.
 594         * xsym.h (bfd_sym_object_p): Likewise.
 595         * aoutx.h (some_aout_object_p): Likewise, and callback parameter
 596         return type.
 597         * pdp11.c (some_aout_object_p): Likewise.
 598         * plugin.c (register_ld_plugin_object_p): Update object_p
 599         parameter type.
 600         * plugin.h (register_ld_plugin_object_p): Likewise.
 601         * bfd-in2.h: Regenerate.
 602         * libbfd.h: Regenerate.
 603         * libcoff.h: Regenerate.
 604
 605 2020-03-02  Alan Modra  <amodra@gmail.com>
 606
 607         * coff-alpha.c (alpha_ecoff_le_vec): Add SEC_SMALL_DATA to
 608         applicable section flags.
 609         * coff-mips.c (mips_ecoff_le_vec, mips_ecoff_be_vec): Likewise.
 610         (mips_ecoff_bele_vec): Likewise.
 611         * coffcode.h (sec_to_styp_flags): Set SEC_SMALL_DATA for .sdata
 612         and .sbss sections.
 613         * ecoff.c (_bfd_ecoff_new_section_hook): Likewise.
 614         (_bfd_ecoff_styp_to_sec_flags): Likewise.
 615
 616 2020-03-02  Alan Modra  <amodra@gmail.com>
 617
 618         * elf32-m32r.c (m32r_elf_section_flags): New function.
 619         (elf_backend_section_flags): Define.
 620         * elf32-nds32.c (nds32_elf_section_flags): New function.
 621         (elf_backend_section_flags): Define.
 622         * elf32-ppc.c (ppc_elf_section_from_shdr): Set SEC_SMALL_DATA for
 623         .sbss and .sdata sections.
 624         * elf32-v850.c (v850_elf_section_from_shdr): Set SEC_SMALL_DATA
 625         for SHF_V850_GPREL sections.
 626         * elf64-alpha.c (elf64_alpha_section_from_shdr): Delete outdated
 627         FIXME.
 628         * elf64-hppa.c (elf64_hppa_section_from_shdr): Set SEC_SMALL_DATA
 629         for SHF_PARISC_SHORT sections.
 630         * elf64-ppc.c (ppc64_elf_section_flags): New function.
 631         (elf_backend_section_flags): Define.
 632         * elfxx-mips.c (_bfd_mips_elf_section_from_shdr): Set SEC_SMALL_DATA
 633         for SHF_MIPS_GPREL sections.  Delete FIXME.
 634
 635 2020-03-02  Alan Modra  <amodra@gmail.com>
 636
 637         * elf-bfd.h (elf_backend_section_flags): Remove flagword* param.
 638         * elf.c (_bfd_elf_make_section_from_shdr): Set section flags before
 639         calling elf_backend_section_flags with adjusted params.  Use
 640         newsect->flags past that point.
 641         (_bfd_elf_new_section_hook): Always set sh_type and sh_flags for
 642         special sections.
 643         (_bfd_elf_init_private_section_data): Allow normal sh_type sections
 644         to have their type overridden, and all sh_flags but processor and
 645         os specific.
 646         * elf32-arm.c (elf32_arm_section_flags): Adjust for changed params.
 647         * elf32-mep.c (mep_elf_section_flags): Likewise.
 648         * elf32-nios2.c (nios2_elf32_section_flags): Likewise.
 649         * elf64-alpha.c (elf64_alpha_section_flags): Likewise.
 650         * elf64-ia64-vms.c (elf64_ia64_section_flags): Likewise.
 651         * elfnn-ia64.c (elfNN_ia64_section_flags): Likewise.
 652         * elfnn-aarch64.c (elfNN_aarch64_size_stubs): Exclude the linker
 653         stub BFD and non-aarch64 input files when scanning for stubs.
 654
 655 2020-03-02  Alan Modra  <amodra@gmail.com>
 656
 657         * coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Provide an upper
 658         limit to decompressed element size.
 659
 660 2020-03-02  Alan Modra  <amodra@gmail.com>
 661
 662         * vms-lib.c (vms_traverse_index): Add recur_count param and
 663         update calls.  Fail on excessive recursion.
 664
 665 2020-03-02  Alan Modra  <amodra@gmail.com>
 666
 667         * vms-alpha.c (vms_get_remaining_object_record): Use
 668         bfd_realloc_or_free rather than bfd_realloc.
 669         (add_symbol_entry, vector_grow1, alpha_vms_slurp_relocs): Likewise.
 670         (dst_define_location, parse_module): Likewise, and check realloc
 671         return status before using memory.  Return status from function
 672         adjusting all callers.
 673
 674 2020-02-28  Alan Modra  <amodra@gmail.com>
 675
 676         * vms-lib.c (_bfd_vms_lib_archive_p): Free memory on error paths.
 677
 678 2020-02-28  Alan Modra  <amodra@gmail.com>
 679
 680         * vms-alpha.c (alpha_vms_object_p): Use _bfd_malloc_and_read.
 681         Remove duplicate undersize check.
 682
 683 2020-02-27  Alan Modra  <amodra@gmail.com>
 684
 685         PR 24511
 686         * mmo.c (mmo_scan): Set SEC_DATA for .data.
 687
 688 2020-02-27  Alan Modra  <amodra@gmail.com>
 689
 690         PR 24511
 691         * syms.c (stt): Trim off all but 'e', 'i' and 'p' entries.
 692         (coff_section_type): Adjust comment.
 693         (decode_section_type): Likewise.  Call coff_section_type before
 694         decode_section_type.
 695         (bfd_decode_symclass): Use 'c' for common sections other than
 696         the standard one.
 697
 698 2020-02-27  Alan Modra  <amodra@gmail.com>
 699
 700         * coff-rs6000.c (_bfd_xcoff_read_ar_hdr): Put all data in one
 701         malloc'd block.
 702
 703 2020-02-27  Alan Modra  <amodra@gmail.com>
 704
 705         * bfd.c (bfd_stat_arch_elt): Use vector of containing archive,
 706         if file is an archive element.
 707         * bfd-in2.h: Regenerate.
 708
 709 2020-02-26  Alan Modra  <amodra@gmail.com>
 710
 711         * archive.c (do_slurp_bsd_armap): Increase minimum parsed_size, and
 712         bfd_set_error on failing test.  Don't bother changing bfd_error on
 713         file read error.  Check symdef_count is multiple of BSD_SYMDEF_SIZE.
 714         Check sym name is within string buffer.  Use size_t for some vars.
 715         (do_slurp_coff_armap): Use size_t for some variables, fix size of
 716         int_buf.  Don't change bfd_error on file read error.  Use
 717         _bfd_mul_overflow when calculating carsym buffer size.  Reorder
 718         calculations to catch overflows before they occur.  malloc and
 719         free raw armap rather than using bfd_alloc.  Read raw armap before
 720         allocating carsym+strings buffer.
 721         (_bfd_slurp_extended_name_table): Localize variables.  Check
 722         name size against file size.
 723
 724 2020-02-26  Alan Modra  <amodra@gmail.com>
 725
 726         * vms-lib.c (vms_lib_read_index): Release correct buffer.
 727
 728 2020-02-26  Alan Modra  <amodra@gmail.com>
 729
 730         * elf32-rx.c (rx_elf_relocate_section): Use bfd_malloc rather than
 731         malloc.  Check for NULL return from bfd_malloc.
 732         (rx_table_find, rx_table_map): Likewise.
 733         (rx_set_section_contents): Check bfd_alloc return.
 734         (rx_dump_symtab): Don't alloc internal_syms or external_syms.
 735
 736 2020-02-26  Alan Modra  <amodra@gmail.com>
 737
 738         * aoutx.h: Indent labels correctly.  Format error strings.
 739         * archive.c: Likewise.
 740         * archive64.c: Likewise.
 741         * coff-arm.c: Likewise.
 742         * coff-rs6000.c: Likewise.
 743         * coff-stgo32.c: Likewise.
 744         * cpu-arm.c: Likewise.
 745         * dwarf2.c: Likewise.
 746         * elf-ifunc.c: Likewise.
 747         * elf-properties.c: Likewise.
 748         * elf-s390-common.c: Likewise.
 749         * elf-strtab.c: Likewise.
 750         * elf.c: Likewise.
 751         * elf32-arm.c: Likewise.
 752         * elf32-bfin.c: Likewise.
 753         * elf32-cr16.c: Likewise.
 754         * elf32-csky.c: Likewise.
 755         * elf32-i386.c: Likewise.
 756         * elf32-m68k.c: Likewise.
 757         * elf32-msp430.c: Likewise.
 758         * elf32-nds32.c: Likewise.
 759         * elf32-nios2.c: Likewise.
 760         * elf32-pru.c: Likewise.
 761         * elf32-xtensa.c: Likewise.
 762         * elf64-ia64-vms.c: Likewise.
 763         * elf64-x86-64.c: Likewise.
 764         * elfcode.h: Likewise.
 765         * elfcore.h: Likewise.
 766         * elflink.c: Likewise.
 767         * elfnn-aarch64.c: Likewise.
 768         * elfnn-ia64.c: Likewise.
 769         * elfnn-riscv.c: Likewise.
 770         * elfxx-mips.c: Likewise.
 771         * elfxx-sparc.c: Likewise.
 772         * elfxx-x86.c: Likewise.
 773         * i386lynx.c: Likewise.
 774         * merge.c: Likewise.
 775         * pdp11.c: Likewise.
 776         * plugin.c: Likewise.
 777         * reloc.c: Likewise.
 778
 779 2020-02-26  Alan Modra  <amodra@gmail.com>
 780
 781         PR 25593
 782         * elf-bfd.h (struct elf_link_hash_table): Rename "loaded" to
 783         "dyn_loaded".
 784         (bfd_elf_add_dt_needed_tag): Declare.
 785         * elf-strtab.c (_bfd_elf_strtab_restore): Handle NULL buf.
 786         * elflink.c (bfd_elf_add_dt_needed_tag): Make global and rename
 787         from elf_add_dt_needed_tag.  Remove soname and doit param.
 788         (elf_link_add_object_symbols): Don't use elf_add_dt_needed_tag
 789         to see whether as-needed lib is already loaded, use dyn_loaded
 790         list instead.  When saving and restoring around as-needed lib
 791         handle possibility that dynstr has not been initialised.  Don't
 792         add DT_NEEDED tags here.  Limit dyn_loaded list to dynamic libs.
 793         Mark libs loaded via DT_NEEDED entries of other libs with
 794         DYN_NO_NEEDED if they should not be mentioned in DT_NEEDED of
 795         the output.
 796         (elf_link_check_versioned_symbol): Remove now unneccesary
 797         DYNAMIC check when traversing dyn_loaded list.
 798
 799 2020-02-26  Alan Modra  <amodra@gmail.com>
 800
 801         * bfdio.c (bfd_get_file_size): Ignore bogus archive element sizes.
 802
 803 2020-02-25  H.J. Lu  <hongjiu.lu@intel.com>
 804
 805         PR binutils/25584
 806         * plugin.c (need_lto_wrapper_p): New.
 807         (bfd_plugin_set_program_name): Add an int argument to set
 808         need_lto_wrapper_p.
 809         (get_lto_wrapper): Return FALSE if need_lto_wrapper_p isn't
 810         set.
 811         * plugin.h (bfd_plugin_set_program_name): Add an int argument.
 812
 813 2020-02-24  Alan Modra  <amodra@gmail.com>
 814
 815         * vms-lib.c (_bfd_vms_lib_archive_p): Correct overflow checks.
 816
 817 2020-02-24  Alan Modra  <amodra@gmail.com>
 818
 819         * vms-lib.c (struct carsym_mem): Add limit.
 820         (vms_add_index): Heed limit.
 821         (vms_traverse_index): Catch buffer overflows.  Remove outdated fixme.
 822         (vms_lib_read_index): Set up limit.  Catch 32-bit overflow.
 823         Always return actual number read.
 824         (_bfd_vms_lib_archive_p): Catch buffer overflows.  Replace
 825         assertion with error exit.
 826
 827 2020-02-22  Alan Modra  <amodra@gmail.com>
 828
 829         PR 25585
 830         * elf.c (assign_file_positions_for_load_sections): Continue linking
 831         on "PHDR segment not covered by LOAD segment" errors.
 832
 833 2020-02-21  Alan Modra  <amodra@gmail.com>
 834
 835         * mach-o.c (bfd_mach_o_canonicalize_relocs): Fix ineffective
 836         overflow check.
 837         (bfd_mach_o_canonicalize_reloc): Likewise.
 838         (bfd_mach_o_canonicalize_dynamic_reloc): Likewise.  Sanity check
 839         counts and offsets against file size.
 840         (bfd_mach_o_build_dysymtab): Fix ineffective overflow check.
 841         (bfd_mach_o_mangle_sections): Remove unnecessary overflow check.
 842         (bfd_mach_o_read_symtab_symbols): Sanity check count and offset
 843         against file size.  Delete symbol table error message.
 844         (bfd_mach_o_read_dysymtab): Sanity check counts and offsets
 845         against file size.
 846         (bfd_mach_o_read_symtab): Likewise.
 847         (bfd_mach_o_read_command): Pass file size.
 848         (bfd_mach_o_scan): Sanity check command count against file size.
 849
 850 2020-02-21  Alan Modra  <amodra@gmail.com>
 851
 852         PR 25569
 853         * aoutx.h (adjust_o_magic, adjust_z_magic, adjust_n_magic): Use
 854         "text", "data" and "bss" section pointer vars.  Don't update
 855         section size, just exec header sizes.
 856         (adjust_sizes_and_vmas): Don't update text section size.  Set
 857         initial exec header a_text.  Print exec headers sizes.
 858         * pdp11.c (adjust_o_magic, adjust_z_magic, adjust_n_magic),
 859         (adjust_sizes_and_vmas): Similarly.  Formatting.
 860         (final_link): Correct final file extension.
 861
 862 2020-02-20  Nick Clifton  <nickc@redhat.com>
 863
 864         * elf-bfd.h (struct elf_backend_data): Add symbol_section_index
 865         callback.
 866         * elfxx-target.h (elf_backend_symbol_section_index): Provide
 867         default definition.
 868         (elfNN_bed): Initialise the symbol_section_index field.
 869         * elf.c (swap_out_syms): Call symbol_section_index, if defined, on
 870         OS and PROC specific section indicies.  Warn if converting other
 871         reserved incidies to SHN_ABS.
 872
 873 2020-02-19  Sergey Belyashov  <sergey.belyashov@gmail.com>
 874
 875         PR 25537
 876         * cpu-z80.c: Add machine type compatibility checking.
 877
 878 2020-02-19  H.J. Lu  <hongjiu.lu@intel.com>
 879
 880         PR binutils/25355
 881         * plugin.c (plugin_list_entry): Remove handle.
 882         (try_load_plugin): Call dlclose before return.
 883
 884 2020-02-19  Alan Modra  <amodra@gmail.com>
 885
 886         * libbfd-in.h (_bfd_constant_p): Define.
 887         (_bfd_alloc_and_read, _bfd_malloc_and_read): Check read size against
 888         file size before allocating memory.
 889         * coffgen.c (_bfd_coff_get_external_symbols): Remove file size check.
 890         * elf.c (bfd_elf_get_str_section): Likewise.
 891         (_bfd_elf_slurp_version_tables): Likewise.
 892         * libbfd.h: Regenerate.
 893
 894 2020-02-19  Alan Modra  <amodra@gmail.com>
 895
 896         * libbfd-in.h (_bfd_alloc_and_read, _bfd_malloc_and_read): New.
 897         * aoutx.h (aout_get_external_symbols): Replace calls to
 898         bfd_[m]alloc and bfd_bread with call to _bfd_[m]alloc_and_read.
 899         (slurp_reloc_table): Likewise.
 900         * archive.c (do_slurp_bsd_armap): Likewise.
 901         (do_slurp_coff_armap): Likewise.
 902         * archive64.c (_bfd_archive_64_bit_slurp_armap): Likewise.
 903         * coff-rs6000.c (_bfd_xcoff_slurp_armap): Likewise.
 904         * coff64-rs6000.c (xcoff64_slurp_armap): Likewise.
 905         * coffcode.h (coff_set_arch_mach_hook, buy_and_read): Likewise.
 906         * coffgen.c (coff_real_object_p, coff_object_p, build_debug_section),
 907         (_bfd_coff_get_external_symbols): Likewise.
 908         * ecoff.c (ecoff_slurp_symbolic_header),
 909         (_bfd_ecoff_slurp_symbolic_info, ecoff_slurp_reloc_table),
 910         (_bfd_ecoff_slurp_armap, ecoff_link_add_object_symbols, READ),
 911         (ecoff_indirect_link_order): Likewise.
 912         * elf.c (bfd_elf_get_str_section, setup_group, elf_read_notes),
 913         (_bfd_elf_slurp_version_tables): Likewise.
 914         * elf32-m32c.c (m32c_elf_relax_section): Likewise.
 915         * elf32-rl78.c (rl78_elf_relax_section): Likewise.
 916         * elf32-rx.c (elf32_rx_relax_section): Likewise.
 917         * elf64-alpha.c (READ): Likewise.
 918         * elf64-mips.c (mips_elf64_slurp_one_reloc_table): Likewise.
 919         * elf64-sparc.c (elf64_sparc_slurp_one_reloc_table): Likewise.
 920         * elfcode.h (elf_slurp_symbol_table),
 921         (elf_slurp_reloc_table_from_section): Likewise.
 922         * elflink.c (elf_link_add_object_symbols),
 923         (elf_link_check_versioned_symbol): Likewise.
 924         * elfxx-mips.c (READ): Likewise.
 925         * i386lynx.c (slurp_reloc_table): Likewise.
 926         * lynx-core.c (lynx_core_file_p): Likewise.
 927         * mach-o.c (bfd_mach_o_canonicalize_relocs),
 928         (bfd_mach_o_read_symtab_strtab, bfd_mach_o_alloc_and_read),
 929         (bfd_mach_o_read_prebound_dylib, bfd_mach_o_read_dyld_content
 930         * pdp11.c (aout_get_external_symbols, slurp_reloc_table
 931         * pef.c (bfd_pef_print_loader_section, bfd_pef_scan_start_address),
 932         (bfd_pef_parse_symbols): Likewise.
 933         * peicode.h (pe_ILF_object_p, pe_bfd_object_p
 934         * som.c (setup_sections, som_slurp_string_table),
 935         (som_slurp_reloc_table, som_bfd_count_ar_symbols),
 936         (som_bfd_fill_in_ar_symbols): Likewise.
 937         * vms-alpha.c (module_find_nearest_line, evax_bfd_print_dst),
 938         (evax_bfd_print_image): Likewise.
 939         * vms-lib.c (_bfd_vms_lib_archive_p): Likewise.
 940         * wasm-module.c (wasm_scan): Likewise.
 941         * xcofflink.c (xcoff_link_add_symbols): Likewise.
 942         * xsym.c (bfd_sym_read_name_table),
 943         (bfd_sym_print_type_information_table_entry): Likewise.
 944         * libbfd.h: Regenerate.
 945
 946 2020-02-19  Alan Modra  <amodra@gmail.com>
 947
 948         * aoutx.h (slurp_reloc_table): Allocate reloc_cache after
 949         reading external relocs.
 950         * ecoff.c (ecoff_slurp_reloc_table): Likewise.
 951         * archive.c (_bfd_write_archive_contents): Don't twiddle bfd_error
 952         after bfd_bread.
 953         * archive64.c (_bfd_archive_64_bit_slurp_armap): Remove unnecessary
 954         bfd_release.
 955         * elf32-m32c.c (m32c_offset_for_reloc): Make shndx_buf a bfd_byte*.
 956         (m32c_elf_relax_section): Likewise.
 957         * elf32-rl78.c (rl78_offset_for_reloc): Likewise.
 958         (rl78_elf_relax_section): Likewise.
 959         * elf32-rx.c (rx_offset_for_reloc): Likewise.
 960         (elf32_rx_relax_section): Likewise.
 961         * mach-o.c (bfd_mach_o_alloc_and_read): Move earlier with better
 962         parameter types and use..
 963         (bfd_mach_o_read_dylinker, bfd_mach_o_read_dylib),
 964         (bfd_mach_o_read_fvmlib, bfd_mach_o_read_str): ..in these functions.
 965         * peicode.h (pe_bfd_object_p): Don't zero the part of opthdr
 966         being read from file, just the extra.
 967         * som.c (som_slurp_symbol_table): Allocate internal symbol buffer
 968         after reading external syms.  Free on failure.
 969
 970 2020-02-19  Alan Modra  <amodra@gmail.com>
 971
 972         * coffcode.h (buy_and_read, coff_slurp_line_table),
 973         (coff_slurp_symbol_table, coff_slurp_reloc_table): Replace
 974         bfd_[z][m]alloc2 calls with _bfd_mul_overflow followed by the
 975         corresponding bfd_alloc call.  Adjust variables to suit.
 976         * coffgen.c (_bfd_coff_get_external_symbols): Likewise.
 977         * ecoff.c (_bfd_ecoff_slurp_symbolic_info),
 978         (_bfd_ecoff_slurp_symbol_table, READ): Likewise.
 979         * elf.c (bfd_elf_get_elf_syms, setup_group, bfd_section_from_shdr),
 980         (swap_out_syms, _bfd_elf_slurp_version_tables): Likewise.
 981         * elf32-m32c.c (m32c_elf_relax_section): Likewise.
 982         * elf32-rl78.c (rl78_elf_relax_section): Likewise.
 983         * elf32-rx.c (elf32_rx_relax_section): Likewise.
 984         * elf64-alpha.c (READ): Likewise.
 985         * elfcode.h (elf_object_p, elf_write_relocs, elf_write_shdrs_and_ehdr),
 986         (elf_slurp_symbol_table, elf_slurp_reloc_table),
 987         (bfd_from_remote_memory): Likewise.
 988         * elfcore.h (core_find_build_id): Likewise.
 989         * elfxx-mips.c (READ): Likewise.
 990         * mach-o.c (bfd_mach_o_mangle_sections),
 991         (bfd_mach_o_read_symtab_symbols, bfd_mach_o_read_thread),
 992         (bfd_mach_o_read_dysymtab, bfd_mach_o_flatten_sections),
 993         (bfd_mach_o_scan, bfd_mach_o_fat_archive_p): Likewise.
 994         * som.c (setup_sections, som_prep_for_fixups)
 995         (som_build_and_write_symbol_table, som_slurp_symbol_table),
 996         (som_slurp_reloc_table, som_bfd_count_ar_symbols),
 997         (som_bfd_fill_in_ar_symbols, som_slurp_armap),
 998         (som_bfd_ar_write_symbol_stuff): Likewise.
 999         * vms-alpha.c (vector_grow1): Likewise.
1000         * vms-lib.c (vms_add_index): Likewise.
1001         * wasm-module.c (wasm_scan_name_function_section): Likewise.
1002         * libbfd.c (bfd_malloc2, bfd_realloc2, bfd_zmalloc2): Delete.
1003         * opncls.c (bfd_alloc2, bfd_zalloc2): Delete.
1004         * libbfd-in.h (bfd_malloc2, bfd_realloc2, bfd_zmalloc2),
1005         (bfd_alloc2, bfd_zalloc2): Delete.
1006         (_bfd_mul_overflow): Define.
1007         * libbfd.h: Regenerate.
1008
1009 2020-02-19  Alan Modra  <amodra@gmail.com>
1010
1011         * elf.c (bfd_section_from_shdr): Use bfd_zalloc rather than
1012         bfd_zalloc2.
1013         (assign_section_numbers): Likewise.
1014         (elf_map_symbols): Likewise, and bfd_alloc rather than bfd_alloc2.
1015         (_bfd_elf_map_sections_to_segments): Use bfd_malloc rather than
1016         bfd_malloc2, size_t amt, and unsigned tls_count.
1017         (rewrite_elf_program_header): Use bfd_malloc and size_t amt.
1018         * elflink.c (elf_create_symbuf): Use bfd_malloc.
1019         (elf_output_implib): Use bfd_alloc.
1020
1021 2020-02-19  Alan Modra  <amodra@gmail.com>
1022
1023         * bfd.c (struct bfd): Move format and direction to other
1024         bitfields.  Add "size".
1025         * bfdio.c (bfd_get_size): Cache size when not writing file.
1026         * opncls.c (bfd_get_debug_link_info_1): Allow for bfd_get_size
1027         returning zero, ie. unknown.
1028         (bfd_get_alt_debug_link_info): Likewise.
1029         * bfd-in2.h: Regenerate.
1030
1031 2020-02-19  Alan Modra  <amodra@gmail.com>
1032
1033         * coffgen.c (_bfd_coff_get_external_symbols): Don't call
1034         bfd_get_file_size twice.
1035         (_bfd_coff_read_string_table): Allow for bfd_get_file_size
1036         zero, ie. unknown, return.
1037         * elf-attrs.c (_bfd_elf_parse_attributes): Likewise.
1038         * elfcode.h (elf_swap_shdr_in): Likewise.
1039         (elf_object_p): Don't call bfd_get_file_size twice and correct
1040         file size check.
1041
1042 2020-02-19  Alan Modra  <amodra@gmail.com>
1043
1044         * mach-o.c (bfd_mach_o_flatten_sections): Return a bfd_boolean,
1045         FALSE if memory alloc fails.  Adjust calls.
1046         * som.c (som_prep_for_fixups): Likewise.
1047         * vms-alpha.c (alpha_vms_add_fixup_lp, alpha_vms_add_fixup_ca),
1048         (alpha_vms_add_fixup_qr, alpha_vms_add_fixup_lr),
1049         (alpha_vms_add_lw_reloc, alpha_vms_add_qw_reloc): Likewise.
1050         * som.c (som_build_and_write_symbol_table): Return via error_return
1051         on seek failure.
1052         * vms-alpha.c (VEC_APPEND): Adjust for vector_grow1 changes.
1053         (VEC_APPEND_EL): Delete.
1054         (vector_grow1): Return pointer to element.  Catch overflow.
1055         Return NULL on memory allocation failure.
1056         (alpha_vms_add_fixup_lp): Replace VEC_APPEND_EL with VEC_APPEND.
1057         (alpha_vms_add_fixup_ca): Likewise.
1058         (alpha_vms_link_add_object_symbols): Check VEC_APPEND result
1059         before using.
1060         * elf.c (bfd_section_from_shdr): Check bfd_zalloc2 result.
1061
1062 2020-02-19  Alan Modra  <amodra@gmail.com>
1063
1064         * aix386-core.c (aix386_core_file_p): Use size_t for "amt".
1065         * aout-target.h (object_p): Likewise.
1066         * aout-tic30.c (tic30_aout_object_p): Likewise.
1067         * aoutx.h (some_aout_object_p, mkobject, make_empty_symbol),
1068         (emit_stringtab, write_syms, link_hash_table_create),
1069         (aout_link_write_other_symbol): Likewise.
1070         * archive.c (_bfd_generic_mkarchive, bfd_generic_archive_p),
1071         (bfd_ar_hdr_from_filesystem, _bfd_write_archive_contents),
1072         (_bfd_compute_and_write_armap): Likewise.
1073         * archures.c (bfd_arch_list): Likewise.
1074         * bfd.c (bfd_record_phdr): Likewise.
1075         * binary.c (binary_canonicalize_symtab): Likewise.
1076         * cisco-core.c (cisco_core_file_validate): Likewise.
1077         * coff-arm.c (coff_arm_link_hash_table_create, find_thumb_glue),
1078         (find_arm_glue, record_arm_to_thumb_glue),
1079         (record_thumb_to_arm_glue): Likewise.
1080         * coff-ppc.c (ppc_coff_link_hash_table_create, record_toc),
1081         (ppc_allocate_toc_section): Likewise.
1082         * coff-rs6000.c (_bfd_xcoff_mkobject, _bfd_xcoff_archive_p): Likewise.
1083         * coff-sh.c (sh_relax_section): Likewise.
1084         * coff64-rs6000.c (xcoff64_archive_p): Likewise.
1085         * coffcode.h (handle_COMDAT, coff_new_section_hook),
1086         (coff_set_alignment_hook, coff_mkobject),
1087         (coff_compute_section_file_positions): Likewise.
1088         * coffgen.c (coff_make_empty_symbol, coff_bfd_make_debug_symbol),
1089         (coff_find_nearest_line_with_names),
1090         ( bfd_coff_set_symbol_class): Likewise.
1091         * cofflink.c (_bfd_coff_link_hash_table_create),
1092         (_bfd_coff_link_input_bfd): Likewise.
1093         * dwarf1.c (alloc_dwarf1_unit, alloc_dwarf1_func): Likewise.
1094         * dwarf2.c (read_abbrevs, read_attribute_value, add_line_info),
1095         (build_line_info_table, sort_line_sequences),
1096         (line_info_add_include_dir, line_info_add_file_name),
1097         (decode_line_info, scan_unit_for_symbols, parse_comp_unit),
1098         (place_sections, _bfd_dwarf2_slurp_debug_info): Likewise.
1099         * ecoff.c (_bfd_ecoff_mkobject, _bfd_ecoff_make_empty_symbol),
1100         (_bfd_ecoff_find_nearest_line),
1101         (_bfd_ecoff_bfd_link_hash_table_create): Likewise.
1102         * ecofflink.c (bfd_ecoff_debug_init): Likewise.
1103         * elf-hppa.h (_bfd_elf_hppa_gen_reloc_type): Likewise.
1104         * elf-m10300.c (mn10300_elf_relax_section),
1105         (elf32_mn10300_link_hash_table_create): Likewise.
1106         * elf-strtab.c (_bfd_elf_strtab_init): Likewise.
1107         * elf.c (make_mapping, copy_elf_program_header): Likewise.
1108         * elf32-arm.c (elf32_arm_link_hash_table_create),
1109         (elf32_arm_setup_section_lists, elf32_arm_check_relocs),
1110         (elf32_arm_new_section_hook): Likewise.
1111         * elf32-avr.c (elf_avr_new_section_hook),
1112         (elf32_avr_link_hash_table_create, get_local_syms),
1113         (elf32_avr_setup_section_lists): Likewise.
1114         * elf32-bfin.c (bfinfdpic_elf_link_hash_table_create),
1115         (bfin_link_hash_table_create): Likewise.
1116         * elf32-cr16.c (elf32_cr16_link_hash_table_create): Likewise.
1117         * elf32-cris.c (elf_cris_link_hash_table_create): Likewise.
1118         * elf32-csky.c (csky_elf_link_hash_table_create),
1119         (csky_elf_check_relocs, elf32_csky_setup_section_lists): Likewise.
1120         * elf32-frv.c (frvfdpic_elf_link_hash_table_create): Likewise.
1121         * elf32-hppa.c (elf32_hppa_link_hash_table_create),
1122         (elf32_hppa_setup_section_lists, get_local_syms): Likewise.
1123         * elf32-i386.c (elf_i386_check_relocs): Likewise.
1124         * elf32-lm32.c (lm32_elf_link_hash_table_create): Likewise.
1125         * elf32-m32r.c (m32r_elf_link_hash_table_create),
1126         (m32r_elf_check_relocs): Likewise.
1127         * elf32-m68hc1x.c (m68hc11_elf_hash_table_create),
1128         (elf32_m68hc11_setup_section_lists),
1129         (elf32_m68hc11_size_stubs): Likewise.
1130         * elf32-m68k.c (elf_m68k_link_hash_table_create): Likewise.
1131         * elf32-metag.c (elf_metag_link_hash_table_create),
1132         (elf_metag_setup_section_lists): Likewise.
1133         * elf32-microblaze.c (microblaze_elf_link_hash_table_create),
1134         (microblaze_elf_check_relocs): Likewise.
1135         * elf32-nds32.c (nds32_elf_link_hash_table_create),
1136         (nds32_elf_check_relocs): Likewise.
1137         * elf32-nios2.c (nios2_elf32_setup_section_lists),
1138         (get_local_syms, nios2_elf32_check_relocs),
1139         (nios2_elf32_link_hash_table_create): Likewise.
1140         * elf32-or1k.c (or1k_elf_link_hash_table_create),
1141         (or1k_elf_check_relocs): Likewise.
1142         * elf32-ppc.c (ppc_elf_modify_segment_map, update_plt_info): Likewise.
1143         * elf32-pru.c (pru_elf32_link_hash_table_create): Likewise.
1144         * elf32-s390.c (elf_s390_link_hash_table_create),
1145         (elf_s390_check_relocs): Likewise.
1146         * elf32-score.c (score_elf_create_got_section),
1147         (s3_elf32_score_new_section_hook),
1148         (elf32_score_link_hash_table_create): Likewise.
1149         * elf32-score7.c (score_elf_create_got_section),
1150         (s7_elf32_score_new_section_hook): Likewise.
1151         * elf32-sh.c (sh_elf_link_hash_table_create),
1152         (sh_elf_check_relocs): Likewise.
1153         * elf32-tic6x.c (elf32_tic6x_link_hash_table_create),
1154         (elf32_tic6x_new_section_hook, elf32_tic6x_check_relocs): Likewise.
1155         * elf32-tilepro.c (tilepro_elf_link_hash_table_create),
1156         (tilepro_elf_check_relocs): Likewise.
1157         * elf32-v850.c (remember_hi16s_reloc): Likewise.
1158         * elf32-vax.c (elf_vax_link_hash_table_create): Likewise.
1159         * elf32-xtensa.c (elf_xtensa_link_hash_table_create),
1160         (elf_xtensa_new_section_hook): Likewise.
1161         * elf64-alpha.c (elf64_alpha_bfd_link_hash_table_create),
1162         (get_got_entry, elf64_alpha_check_relocs): Likewise.
1163         * elf64-hppa.c (elf64_hppa_hash_table_create): Likewise.
1164         * elf64-ia64-vms.c (elf64_ia64_object_p): Likewise.
1165         * elf64-mmix.c (mmix_elf_new_section_hook): Likewise.
1166         * elf64-ppc.c (ppc64_elf_new_section_hook),
1167         (ppc64_elf_link_hash_table_create, update_local_sym_info),
1168         (update_plt_info, ppc64_elf_check_relocs): Likewise.
1169         * elf64-s390.c (elf_s390_link_hash_table_create),
1170         (elf_s390_check_relocs): Likewise.
1171         * elf64-x86-64.c (elf_x86_64_check_relocs): Likewise.
1172         * elflink.c (bfd_elf_link_record_local_dynamic_symbol),
1173         (_bfd_elf_link_find_version_dependencies, elf_link_add_object_symbols),
1174         (elf_link_add_archive_symbols, compute_bucket_count),
1175         (bfd_elf_size_dynsym_hash_dynstr, _bfd_elf_link_hash_table_create),
1176         (bfd_elf_get_bfd_needed_list, elf_link_swap_symbols_out),
1177         (bfd_elf_final_link): Likewise.
1178         * elfnn-aarch64.c (elfNN_aarch64_link_hash_table_create),
1179         (elfNN_aarch64_setup_section_lists, elfNN_aarch64_check_relocs),
1180         (elfNN_aarch64_new_section_hook): Likewise.
1181         * elfnn-ia64.c (elfNN_ia64_object_p): Likewise.
1182         * elfnn-riscv.c (riscv_elf_link_hash_table_create),
1183         (riscv_elf_check_relocs): Likewise.
1184         * elfxx-mips.c (_bfd_mips_elf_new_section_hook),
1185         (_bfd_mips_elf_add_symbol_hook, _bfd_mips_elf_check_relocs),
1186         (_bfd_mips_elf_modify_segment_map, _bfd_mips_elf_set_section_contents),
1187         (_bfd_mips_elf_link_hash_table_create): Likewise.
1188         * elfxx-sparc.c (_bfd_sparc_elf_link_hash_table_create),
1189         (_bfd_sparc_elf_check_relocs),
1190         (_bfd_sparc_elf_new_section_hook): Likewise.
1191         * elfxx-tilegx.c (tilegx_elf_link_hash_table_create),
1192         (tilegx_elf_check_relocs): Likewise.
1193         * elfxx-x86.c (_bfd_x86_elf_link_hash_table_create): Likewise.
1194         * format.c (bfd_check_format_matches): Likewise.
1195         * hash.c (_bfd_stringtab_init): Likewise.
1196         * ihex.c (ihex_scan): Likewise.
1197         * irix-core.c (irix_core_core_file_p): Likewise.
1198         * linker.c (bfd_wrapped_link_hash_lookup),
1199         (_bfd_generic_link_hash_table_create),
1200         (_bfd_generic_reloc_link_order): Likewise.
1201         * lynx-core.c (lynx_core_file_p): Likewise.
1202         * netbsd-core.c (netbsd_core_file_p): Likewise.
1203         * osf-core.c (osf_core_core_file_p): Likewise.
1204         * pdp11.c (some_aout_object_p, mkobject, make_empty_symbol),
1205         (link_hash_table_create, aout_link_write_other_symbol): Likewise.
1206         * peXXigen.c (_bfd_XX_bfd_copy_private_section_data): Likewise.
1207         * peicode.h (pe_mkobject): Likewise.
1208         * ppcboot.c (ppcboot_mkobject, ppcboot_canonicalize_symtab): Likewise.
1209         * ptrace-core.c (ptrace_unix_core_file_p): Likewise.
1210         * sco5-core.c (read_uarea): Likewise.
1211         * som.c (hppa_som_gen_reloc_type, som_object_p, som_prep_headers),
1212         (som_write_fixups, som_write_space_strings, som_write_symbol_strings),
1213         (som_finish_writing, som_canonicalize_symtab, som_new_section_hook),
1214         (som_bfd_copy_private_section_data, bfd_som_set_section_attributes),
1215         (bfd_som_attach_aux_hdr, som_write_armap): Likewise.
1216         * srec.c (srec_scan): Likewise.
1217         * syms.c (_bfd_generic_make_empty_symbol): Likewise.
1218         * targets.c (bfd_target_list): Likewise.
1219         * tekhex.c (first_phase, tekhex_sizeof_headers): Likewise.
1220         * trad-core.c (trad_unix_core_file_p): Likewise.
1221         * vms-alpha.c (vms_initialize, alpha_vms_bfd_link_hash_table_create),
1222         (vms_new_section_hook): Likewise.
1223         * wasm-module.c (wasm_make_empty_symbol): Likewise.
1224         * xcofflink.c (xcoff_get_section_contents),
1225         (_bfd_xcoff_bfd_link_hash_table_create, xcoff_set_import_path),
1226         (xcoff_find_function, bfd_xcoff_link_record_set, xcoff_build_ldsym),
1227         (bfd_xcoff_size_dynamic_sections, xcoff_link_input_bfd): Likewise.
1228
1229 2020-02-19  Alan Modra  <amodra@gmail.com>
1230
1231         * elfxx-riscv.c (riscv_multi_letter_ext_valid_p): Don't use C99.
1232
1233 2020-02-13  H.J. Lu  <hongjiu.lu@intel.com>
1234
1235         * plugin.c (try_load_plugin): Make plugin_list_iter an argument
1236         and use it if it isn't NULL.  Remove has_plugin_p argument.  Add
1237         a build_list_p argument.  Don't search plugin_list.  Short circuit
1238         when building the plugin list.
1239         (has_plugin): Renamed to has_plugin_list.
1240         (bfd_plugin_set_plugin): Don't set has_plugin.
1241         (bfd_plugin_specified_p): Check plugin_list instead.
1242         (build_plugin_list): New function.
1243         (load_plugin): Call build_plugin_list and use plugin_list.
1244
1245 2020-02-11  H.J. Lu  <hongjiu.lu@intel.com>
1246
1247         PR binutils/25355
1248         * plugin.c (try_claim): Always clean up for LTO wrapper.
1249         (try_load_plugin): Treat each object as independent.  Create a
1250         copy for plugin name.
1251
1252 2020-02-11  Nick Clifton  <nickc@redhat.com>
1253
1254         * elf32-msp430.c (msp430_final_link_relocate): Always use longs
1255         for addresses in print statements.
1256         (msp430_elf_relax_delete_bytes): Likewise.
1257         (msp430_elf_relax_add_words): Likewise.
1258         (msp430_elf_relax_section): Likewise.
1259
1260 2020-02-11  H.J. Lu  <hongjiu.lu@intel.com>
1261
1262         * plugin.c (add_symbols): Clear plugin_data memory.
1263
1264 2020-02-10  H.J. Lu  <hongjiu.lu@intel.com>
1265
1266         PR binutils/25355
1267         * configure.ac (HAVE_EXECUTABLE_SUFFIX): New AC_DEFINE.
1268         (EXECUTABLE_SUFFIX): Likewise.
1269         * config.in: Regenerated.
1270         * configure: Likewise.
1271         * plugin.c (bfd_plugin_close_and_cleanup): Removed.
1272         (plugin_list_entry): Add all_symbols_read, cleanup_handler,
1273         gcc, lto_wrapper, resolution_file, resolution_option, gcc_env,
1274         real_bfd, real_nsyms, real_syms, lto_nsyms and lto_syms.
1275         (get_lto_wrapper): New.
1276         (setup_lto_wrapper_env): Likewise.
1277         (current_plugin): Likewise.
1278         (register_all_symbols_read): Likewise.
1279         (register_cleanup): Likewise.
1280         (get_symbols): Likewise.
1281         (add_input_file): Likewise.
1282         (bfd_plugin_close_and_cleanup): Likewise.
1283         (claim_file): Removed.
1284         (register_claim_file): Set current_plugin->claim_file.
1285         (add_symbols): Make a copy of LTO symbols.  Set lto_nsyms and
1286         lto_syms in current_plugin.
1287         (try_claim): Use current_plugin->claim_file.  Call LTO plugin
1288         all_symbols_read handler.  Copy real symbols to plugin_data.
1289         Call LTO plugin cleanup handler.  Clean up for LTO wrapper.
1290         (try_load_plugin): Don't reuse the previous plugin for LTO
1291         wrapper.  Set up GCC LTO wrapper if possible.  Don't set
1292         plugin_list_iter->claim_file.
1293         (bfd_plugin_canonicalize_symtab): Use real LTO symbols if
1294         possible.
1295         * plugin.h (plugin_data_struct): Add real_bfd, real_nsyms and
1296         real_syms.
1297
1298 2020-02-10  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
1299
1300         * elf32-msp430.c (msp430_elf_relax_section): Before relaxing a branch,
1301         check if previous instruction matches a conditional jump inserted
1302         earlier. Invert conditional jump and delete branch in this case.
1303
1304 2020-02-10  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
1305
1306         * elf32-msp430.c (msp430_elf_relax_add_two_words): Rename to
1307         msp430_elf_relax_add_words. Support insertion of either one or two
1308         words.
1309         (msp430_elf_relax_section): Catch opcode of 0x3c00 when relocation
1310         needs to be grown. Handle insertion of branch instruction to replace
1311         jump.
1312
1313 2020-02-10  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
1314
1315         * elf32-msp430.c (msp430_final_link_relocate): Add printf statements for
1316         debugging relocations.
1317         (msp430_elf_relax_delete_bytes): Likewise.
1318         (msp430_elf_relax_add_two_words): Likewise.
1319         (msp430_elf_relax_section): Likewise.
1320
1321 2020-02-10  Alan Modra  <amodra@gmail.com>
1322
1323         * archures.c: Wrap overlong z80 comments.
1324         * bfd-in2.h: Regenerate.
1325
1326 2020-02-07  Sergey Belyashov  <sergey.belyashov@gmail.com>
1327
1328         PR 25469
1329         * archures.c: Add GBZ80 and Z80N machine values.
1330         * reloc.c: Add BFD_RELOC_Z80_16_BE.
1331         * coff-z80.c: Add support for new reloc.
1332         * coffcode.h: Add support for new machine values.
1333         * cpu-z80.c: Add support for new machine names.
1334         * elf32-z80.c: Add support for new reloc.
1335         * bfd-in2.h: Regenerate.
1336         * libbfd.h: Regenerate.
1337
1338 2020-02-07  Nick Clifton  <nickc@redhat.com>
1339
1340         PR 23932
1341         * elf.c (rewrite_elf_program_header): Do not complain if no
1342         sections are mapped to a segment.
1343
1344 2020-02-06  H.J. Lu  <hongjiu.lu@intel.com>
1345
1346         PR ld/25490
1347         * elflink.c (_bfd_elf_gc_mark_extra_sections): Issue an error
1348         for garbage collection on __patchable_function_entries section
1349         without linked-to section.
1350
1351 2020-02-06  H.J. Lu  <hongjiu.lu@intel.com>
1352
1353         PR gas/25381
1354         * bfd-in2.h: Regenerated.
1355         * elflink.c (_bfd_elf_gc_mark_extra_sections): Call mark_hook
1356         on section if gc_mark of any of its linked-to sections is set
1357         and don't set gc_mark again.
1358         * section.c (asection): Add linked_to_symbol_name to map_head
1359         union.
1360
1361 2020-02-06  Maciej W. Rozycki  <macro@wdc.com>
1362
1363         * elf32-v850.c (v850_elf_relax_section): Fix the index used for
1364         reporting an unrecognized instruction with R_V850_LONGJUMP.
1365
1366 2020-02-05  Alan Modra  <amodra@gmail.com>
1367
1368         * elf64-ppc.c (ppc_stub_plt_branch): Match comment with reality.
1369
1370 2020-02-04  Alan Modra  <amodra@gmail.com>
1371
1372         * elf32-ppc.c (ppc_elf_relocate_section): After applying
1373         R_PPC_VLE_ADDR20, goto copy_reloc.
1374
1375 2020-02-02  H.J. Lu  <hongjiu.lu@intel.com>
1376
1377         * bfd-in2.h: Regenerated.
1378         * section.c (SEC_ASSEMBLER_SECTION_ID): Fix a typo in comments.
1379
1380 2020-02-02  H.J. Lu  <hongjiu.lu@intel.com>
1381
1382         PR gas/25380
1383         * bfd-in2.h: Regenerated.
1384         * ecoff.c (bfd_debug_section): Add section_id.
1385         * section.c (bfd_section): Add section_id.
1386         (SEC_ASSEMBLER_SECTION_ID): New.
1387         (BFD_FAKE_SECTION): Add section_id.
1388
1389 2020-02-01  Nick Clifton  <nickc@redhat.com>
1390
1391         * config.bfd: Move the c30-aout and tic30-aout targets onto the
1392         obsolete list.
1393
1394 2020-01-31  Sandra Loosemore  <sandra@codesourcery.com>
1395
1396         * elf-eh-frame.c (_bfd_elf_write_section_eh_frame): DW_EH_PE_datarel
1397         encodings are relative to the GOT on nios2, too.
1398
1399 2020-01-31  Alan Modra  <amodra@gmail.com>
1400
1401         * Makefile.am (elf32-target.h, elf64-target.h): Don't use a temp
1402         file.  Use $< and $@ in rules.
1403         (elf32-aarch64.c, elf64-aarch64.c): Likewise.
1404         (elf32-ia64.c, elf64-ia64.c): Likewise.
1405         (elf32-riscv.c, elf64-riscv.c): Likewise.
1406         (peigen.c, pepigen.c, pex64igen.c): Likewise.
1407         (elf32-aarch64.c, elf64-aarch64.c): Don't emit $srcdir on #line.
1408         (elf32-riscv.c, elf64-riscv.c): Likewise, and use $(SED).
1409         (elf32-ia64.c, elf64-ia64.c): Do emit #line.
1410         (peigen.c, pepigen.c, pex64igen.c): Likewise.
1411         * Makefile.in: Regenerate.
1412
1413 2020-01-31  Alan Modra  <amodra@gmail.com>
1414
1415         PR 4110
1416         * elf.c (setup_group): Don't clear entire section contents,
1417         just the padding after group flags.  Release alloc'd memory
1418         after a seek or read failure.
1419
1420 2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>
1421
1422         * peXXigen.c (pe_is_repro): New function.
1423         (_bfd_XX_print_private_bfd_data_common): Note timestamp is
1424         actually a build hash if PE_IMAGE_DEBUG_TYPE_REPRO is present.
1425
1426 2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>
1427
1428         * peXXigen.c (debug_type_names): Add names for new debug data type
1429         values.
1430
1431 2020-01-16  Jon Turney  <jon.turney@dronecode.org.uk>
1432
1433         * peXXigen.c (pe_print_debugdata): Fix the iteration variable for
1434         inner loop.  Fix a memory leak.
1435
1436 2020-01-30  Alan Modra  <amodra@gmail.com>
1437
1438         * coffgen.c (coff_real_object_p): Don't clear obj_coff_keep_syms
1439         or obj_coff_keep_strings here.
1440         (coff_get_normalized_symtab): Free external syms directly.
1441         * xcofflink.c (xcoff_link_input_bfd): Restore obj_coff_keep_syms
1442         on error exit path.
1443
1444 2020-01-27  Jim Wilson  <jimw@sifive.com>
1445
1446         * cpu-riscv.c (riscv_scan): New.
1447         (N): Change bfd_default_scan to riscv_scan.
1448
1449 2020-01-27  Andreas Schwab  <schwab@suse.de>
1450
1451         * Makefile.am (ALL_MACHINES): Remove cpu-plugin.lo.
1452         (ALL_MACHINES_CFILES): Remove cpu-plugin.c.
1453         * Makefile.in: Regenerate.
1454         * cpu-plugin.c: Remove.
1455         * archures.c (enum bfd_architecture): Remove bfd_arch_plugin.
1456         (bfd_plugin_arch): Remove declaration.
1457         * bfd-in2.h: Regenerate.
1458         * po/SRC-POTFILES.in: Regenerate.
1459
1460 2020-01-27  H.J. Lu  <hongjiu.lu@intel.com>
1461             Alan Modra  <amodra@gmail.com>
1462
1463         PR ld/25458
1464         * elflink.c (_bfd_elf_gc_mark_rsec): Mark all weak aliases.
1465
1466 2020-01-24  Jim Wilson  <jimw@sifive.com>
1467
1468         * elfxx-riscv.c (riscv_get_prefix_class): Format s case like others.
1469         (riscv_parse_prefixed_ext): Fix s extension comment and reword to
1470         avoid over long line.
1471
1472 2020-01-24  Nick Clifton  <nickc@redhat.com>
1473
1474         PR 25447
1475         * coffgen.c (_bfd_coff_close_and_cleanup): Do not clear the keep
1476         syms and keep strings flags as these may have been set in order to
1477         prevent a bogus call to free.
1478
1479 2020-01-23  Nick Clifton  <nickc@redhat.com>
1480
1481         * po/fr.po: Updated French translation.
1482
1483 2020-01-23  Alan Modra  <amodra@gmail.com>
1484
1485         PR 25444
1486         * elf.c (assign_file_positions_for_load_sections): Avoid divide
1487         by zero when p_align is zero.
1488
1489 2020-01-22  Maxim Blinov  <maxim.blinov@embecosm.com>
1490
1491         * bfd/elfnn-riscv.c (riscv_skip_prefix): New.
1492         (riscv_prefix_cmp): Likewise.
1493         (riscv_non_std_ext_p): Deleted.
1494         (riscv_std_sv_ext_p): Likewise.
1495         (riscv_non_std_sv_ext_p): Likewise.
1496         (riscv_merge_non_std_and_sv_ext): Rename to...
1497         (riscv_merge_multi_letter_ext): and modified to use riscv_prefix_cmp.
1498         (riscv_merge_arch_attr_info): Replace 3 calls to
1499         riscv_merge_non_std_and_sv_ext with single call to
1500         riscv_merge_multi_letter_ext.
1501         * bfd/elfxx-riscv.c (riscv_parse_std_ext): Break if we
1502         encounter a 'z' prefix.
1503         (riscv_get_prefix_class): New function, return prefix class based
1504         on first few characters of input string.
1505         (riscv_parse_config): New structure to factor out minor differences
1506         in extension class parsing behaviour.
1507         (riscv_parse_sv_or_non_std_ext): Rename to...
1508         (riscv_parse_prefixed_ext): and parameterise with
1509         riscv_parse_config.
1510         (riscv_std_z_ext_strtab, riscv_std_s_ext_strtab): New.
1511         (riscv_multi_letter_ext_valid_p): New.
1512         (riscv_ext_x_valid_p, riscv_ext_z_valid_p, riscv_ext_s_valid_p): New.
1513         (riscv_parse_subset): Delegate all non-single-letter parsing work
1514         to riscv_parse_prefixed_ext.
1515         * bfd/elfxx-riscv.h (riscv_isa_ext_class): New type.
1516         (riscv_get_prefix_class): Declare.
1517
1518 2020-01-22  Alan Modra  <amodra@gmail.com>
1519
1520         * elf64-ppc.c (struct ppc_link_hash_table): Add tga_group.
1521         (ppc64_elf_archive_symbol_lookup): Extract __tls_get_addr_opt for
1522         __tls_get_addr_desc.
1523         (ppc64_elf_size_stubs): Add section for linker generated
1524         __tls_get_addr_desc wrapper function.  Loop at least once if
1525         generating this function.
1526         (emit_tga_desc, emit_tga_desc_eh_frame): New functions.
1527         (ppc64_elf_build_stubs): Generate __tls_get_addr_desc.
1528
1529 2020-01-22  Alan Modra  <amodra@gmail.com>
1530
1531         * elf64-ppc.h (struct ppc64_elf_params): Add no_tls_get_addr_regsave.
1532         * elf64-ppc.c (struct ppc_link_hash_table): Add tga_desc and
1533         tga_desc_fd.
1534         (is_tls_get_addr): Match tga_desc and tga_desc_df too.
1535         (STDU_R1_0R1, ADDI_R1_R1): Define.
1536         (tls_get_addr_prologue, tls_get_addr_epilogue): New functions.
1537         (ppc64_elf_tls_setup): Set up tga_desc and tga_desc_fd.  Indirect
1538         tga_desc_fd to opt_fd, and tga_desc to opt.  Set
1539         no_tls_get_addr_regsave.
1540         (branch_reloc_hash_match): Add hash3 and hash4.
1541         (ppc64_elf_tls_optimize): Handle tga_desc_fd and tga_desc too.
1542         (ppc64_elf_size_dynamic_sections): Likewise.
1543         (ppc64_elf_relocate_section): Likewise.
1544         (plt_stub_size, build_plt_stub): Likewise.  Size regsave
1545         __tls_get_addr stub.
1546         (build_tls_get_addr_stub): Build regsave __tls_get_addr stub and
1547         eh_frame.
1548         (ppc_size_one_stub): Handle tga_desc_fd and tga_desc too.  Size
1549         eh_frame for regsave __tls_get_addr.
1550
1551 2020-01-22  Alan Modra  <amodra@gmail.com>
1552
1553         * elf64-ppc.c (ppc64_elf_size_stubs): Correct condition under
1554         which __tls_get_addr calls will be eliminated.
1555
1556 2020-01-20  Nick Clifton  <nickc@redhat.com>
1557
1558         * po/pt.po: Updates Portuguese translation.
1559         * po/ru.po: Updated Russian translation.
1560         * po/uk.po: Updated Ukranian translation.
1561
1562 2020-01-20  H.J. Lu  <hongjiu.lu@intel.com>
1563
1564         PR ld/25416
1565         * elf64-x86-64.c (elf_x86_64_check_tls_transition): Support
1566         "rex leal x@tlsdesc(%rip), %reg" and "call *x@tlsdesc(%eax)" in
1567         X32 mode.
1568         (elf_x86_64_relocate_section): In x32 mode, for GDesc -> LE
1569         transition, relax "rex leal x@tlsdesc(%rip), %reg" to
1570         "rex movl $x@tpoff, %reg", for GDesc -> IE transition, relax
1571         "rex leal x@tlsdesc(%rip), %reg" to
1572         "rex movl x@gottpoff(%rip), %eax".  For both transitions, relax
1573         "call *(%eax)" to "nopl (%rax)".
1574
1575 2020-01-20  Alan Modra  <amodra@gmail.com>
1576
1577         * elf64-ppc.c (LD_R11_0R3, CMPDI_R11_0, STD_R11_0R1, LD_R11_0R1),
1578         (MTLR_R11): Don't define.
1579         (LD_R0_0R3, CMPDI_R0_0): Define.
1580         (build_tls_get_addr_stub): Don't use r11 in stub.
1581
1582 2020-01-20  Alan Modra  <amodra@gmail.com>
1583
1584         * elf64-ppc.c (ppc_elf_hash_entry): New function, use throughout file.
1585         (defined_sym_val, is_tls_get_addr): Likewise.
1586
1587 2020-01-18  Nick Clifton  <nickc@redhat.com>
1588
1589         * version.m4 (BFD_VERSION): Set to 2.34.50.
1590         * configure: Regenerate.
1591         * po/bfd.pot: Regenerate.
1592
1593 2020-01-18  Nick Clifton  <nickc@redhat.com>
1594
1595         Binutils 2.34 branch created.
1596
1597 2020-01-17  Christian Biesinger  <cbiesinger@google.com>
1598
1599         * coff-arm.c: Fix spelling error (seperate).
1600         * elfxx-riscv.c (riscv_parse_sv_or_non_std_ext): Fix spelling
1601         error (seperate).
1602         * sysdep.h (strnlen): Fix spelling error (seperate).
1603
1604 2020-01-15  Lars Brinkhoff  <lars@nocrew.org>
1605
1606         PR 20694
1607         * pdp11.c (TARGET_PAGE_SIZE): Set to 8192.
1608
1609 2020-01-15  Alan Modra  <amodra@gmail.com>
1610
1611         PR 25384
1612         * elf64-ppc.c (ELIMINATE_COPY_RELOCS): Update comment.
1613         (ppc64_elf_adjust_dynamic_symbol): Don't allow .dynbss copies
1614         of function symbols unless dot symbols are present.  Do warn
1615         whenever one is created, regardles of whether a PLT entry is
1616         also emitted for the function symbol.
1617
1618 2020-01-14  Alan Modra  <amodra@gmail.com>
1619
1620         * som.c (som_bfd_count_ar_symbols): Error when file position
1621         of symbols on chains is not strictly increasing.
1622
1623 2020-01-14  Alan Modra  <amodra@gmail.com>
1624
1625         * vms.h (VMS_DEBUG): Define as 0.
1626         * vms-alpha.c (image_write): Move debug output after bounds check.
1627         Tidy bounds check.
1628         (_bfd_vms_slurp_eihd): Warning fix.
1629         (_bfd_vms_slurp_etir): Init variables to avoid bogus warnings.
1630
1631 2020-01-13  Alan Modra  <amodra@gmail.com>
1632
1633         * vms-alpha.c (_bfd_vms_slurp_egsd): Ensure minimum size even
1634         for "ignored" records.
1635
1636 2020-01-13  Alan Modra  <amodra@gmail.com>
1637
1638         * wasm-module.c (wasm_scan_name_function_section): Formatting.
1639         Delete asect name check.  Move asect NULL check to wasm_object_p.
1640         Correct bounds check of sizes against end.  Replace uses of
1641         bfd_zalloc with bfd_alloc, zeroing only necessary bytes.  Use
1642         just one bfd_release.
1643         (wasm_scan): Don't use malloc/strdup for section names,
1644         bfd_alloc instead.  Simplify code prefixing section name.
1645         Formatting.  Don't attempt to free memory here..
1646         (wasm_object_p): ..do so here.
1647
1648 2020-01-10  Szabolcs Nagy  <szabolcs.nagy@arm.com>
1649
1650         PR ld/22269
1651         * elf32-arm.c (elf32_arm_final_link_relocate): Use
1652         UNDEFWEAK_NO_DYNAMIC_RELOC.
1653         (allocate_dynrelocs_for_symbol): Likewise.
1654
1655 2020-01-10  Tamar Christina  <tamar.christina@arm.com>
1656
1657         PR 25210
1658         * elfnn-aarch64.c (_bfd_aarch64_create_stub_section): Remove elfclass.
1659
1660 2020-01-10  Alan Modra  <amodra@gmail.com>
1661
1662         * coff-alpha.c (alpha_ecoff_object_p): Calculate size in bfd_size_type.
1663
1664 2020-01-09  Nick Clifton  <nickc@redhat.com>
1665
1666         PR 25221
1667         * bfd.c (bfd_convert_section_contents): Check for a compress
1668         header size that is larger than the actual section size.
1669
1670 2020-01-08  Alan Modra  <amodra@gmail.com>
1671
1672         PR 25351
1673         * elflink.c (bfd_elf_final_link): Call _bfd_fix_excluded_sec_syms
1674         after removing sections.
1675
1676 2020-01-06  Jim Wilson  <jimw@sifive.com>
1677
1678         PR 25205
1679         * elfnn-riscv.c (riscv_elf_relocate_section) <R_RISCV_CALL>: Add
1680         check for !bfd_link_pic (info).
1681         <R_RISCV_CALL_PLT>: Move next to R_RISCV_CALL.
1682         <R_RISCV_JAL>: Add comment.
1683         (_bfd_riscv_relax_section): For plt.offset check, add check for
1684         bfd_link_pic (info).  Add comment.
1685
1686 2020-01-06  Alan Modra  <amodra@gmail.com>
1687
1688         * format.c (bfd_check_format_matches): Ignore bfd_error on target
1689         match failures.  Don't init to bfd_error_wrong_format before
1690         calling _bfd_check_format.
1691
1692 2020-01-06  Alan Modra  <amodra@gmail.com>
1693
1694         * vms-alpha.c (_bfd_vms_push, _bfd_vms_pop): Return pass/fail
1695         status rather than exiting on stack overflow or underflow.
1696         (_bfd_vms_slurp_etir): Adjust to suit.
1697
1698 2020-01-06  Alan Modra  <amodra@gmail.com>
1699
1700         * som.c (som_bfd_fill_in_ar_symbols): Bounds check som_dict index.
1701
1702 2020-01-06  Alan Modra  <amodra@gmail.com>
1703
1704         * mach-o.c (bfd_mach_o_read_dylinker): Don't read past end of
1705         command.  Check name offset is within command.
1706         (bfd_mach_o_read_dylib, bfd_mach_o_read_prebound_dylib),
1707         (bfd_mach_o_read_prebind_cksum, bfd_mach_o_read_twolevel_hints),
1708         (bfd_mach_o_read_fvmlib, bfd_mach_o_read_dysymtab),
1709         (bfd_mach_o_read_symtab, bfd_mach_o_read_uuid),
1710         (bfd_mach_o_read_linkedit, bfd_mach_o_read_str),
1711         (bfd_mach_o_read_dyld_info, bfd_mach_o_read_version_min),
1712         (bfd_mach_o_read_encryption_info, bfd_mach_o_read_source_version),
1713         (bfd_mach_o_read_encryption_info_64, bfd_mach_o_read_main),
1714         (bfd_mach_o_read_note, bfd_mach_o_read_build_version),
1715         (bfd_mach_o_read_segment): Similarly.
1716         (bfd_mach_o_read_thread): Properly bound check thread struct.
1717         Don't repeat checks on second loop.
1718         (bfd_mach_o_read_command): Fail on invalid command length.
1719
1720 2020-01-04  Alan Modra  <amodra@gmail.com>
1721
1722         * format.c (bfd_check_format_matches): Add preserve_match.
1723         Save initial bfd state in "preserve", matched bfd state in
1724         "preserve_match".  Save just the first match.  Release
1725         bfd_alloc memory.  Restore and finish preserved state as
1726         appropriate on all function exit paths.
1727
1728 2020-01-04  Alan Modra  <amodra@gmail.com>
1729
1730         * mmo.c (mmo_mkobject): Allocate tdata with bfd_zalloc.
1731
1732 2020-01-04  Alan Modra  <amodra@gmail.com>
1733
1734         * coffgen.c (coff_real_object_p): Free malloc'd memory on target
1735         match too.
1736
1737 2020-01-03  Nick Clifton  <nickc@redhat.com>
1738
1739         PR 25307
1740         (bfd_pef_parse_function_stubs): Correct the test that ensures that
1741         there is enough data remaining in the code buffer before
1742         attempting to read a function stub.
1743
1744 2020-01-03  Nick Clifton  <nickc@redhat.com>
1745
1746         PR 25308
1747         * elf-properties.c (_bfd_elf_convert_gnu_properties): Check the
1748         return value from bfd_malloc.
1749         * elf32-arm.c (bfd_elf32_arm_vfp11_fix_veneer_locations): Likewise.
1750         (bfd_elf32_arm_stm32l4xx_fix_veneer_locations): Likewise.
1751         (elf32_arm_filter_cmse_symbols): Likewise.
1752         (elf32_arm_write_section): Likewise.
1753         * mach-o.c (bfd_mach_o_core_fetch_environment): Likewise.
1754         (bfd_mach_o_follow_dsym): Likewise.
1755         * pef.c (bfd_pef_print_loader_section): Likewise.
1756         (bfd_pef_scan_start_address): Likewise.
1757         (bfd_pef_parse_function_stubs): Likewise.
1758         (bfd_pef_parse_symbols): Likewise.
1759
1760 2020-01-03  Sergei Trofimovich  <siarheit@google.com>
1761
1762         * elfnn-ia64.c (elfNN_ia64_merge_private_bfd_data): don't fail
1763         on binary inputs ld/PR25316.
1764         (is_ia64_elf): new helper to filter on ia64 objects.
1765
1766 2020-01-03  Jan Beulich  <jbeulich@suse.com>
1767
1768         * mach-o.c (cpusubtype, bfd_mach_o_header_p): Insert underscore
1769         in parameter names.
1770         (bfd_mach_o_scan): Insert underscore in two variable names.
1771
1772 2020-01-02  Sergey Belyashov  <sergey.belyashov@gmail.com>
1773
1774         * Makefile.am: Add z80-elf target support.
1775         * configure.ac: Likewise.
1776         * targets.c: Likewise.
1777         * Makefile.in: Regenerate.
1778         * configure: Regenerate.
1779         * config.bfd: Add z80-elf target support and new arches: ez80 and
1780         z180.
1781         * elf32-z80.c: New file.
1782         * archures.c: Add new z80 architectures: eZ80 and Z180.
1783         * coffcode.h: Likewise.
1784         * cpu-z80.c: Likewise.
1785         * coff-z80.c: Add new relocations for Z80 target and local label
1786         check.
1787         * reloc.c: Add new relocs.
1788         * bfd-in2.h: Regenerate.
1789         * libbfd.h: Regenerate.
1790
1791 2020-01-02  Tamar Christina  <tamar.christina@arm.com>
1792
1793         PR 25210
1794         PR 24753
1795         * elfnn-aarch64.c (_bfd_aarch64_create_stub_section): Set ELF class.
1796
1797 2020-01-01  Alan Modra  <amodra@gmail.com>
1798
1799         Update year range in copyright notice of all files.
1800
1801 For older changes see ChangeLog-2019
1802 \f
1803 Copyright (C) 2020 Free Software Foundation, Inc.
1804
1805 Copying and distribution of this file, with or without modification,
1806 are permitted in any medium without royalty provided the copyright
1807 notice and this notice are preserved.
1808
1809 Local Variables:
1810 mode: change-log
1811 left-margin: 8
1812 fill-column: 74
1813 version-control: never
1814 End: