bfd/ChangeLog

   1 2019-03-30  Andrew Waterman  <andrew@sifive.com>
   2
   3         * elfnn-riscv.c (_bfd_riscv_relax_call): Only check ARCH_SIZE for
   4         rd == X_RA case.
   5
   6 2019-03-29  Max Filippov  <jcmvbkbc@gmail.com>
   7
   8         * elf32-xtensa.c (shrink_dynamic_reloc_sections): Add
   9         info->export_dynamic to the conditional.
  10
  11 2019-03-28  Alan Modra  <amodra@gmail.com>
  12
  13         PR 24392
  14         * configure.ac: Invoke AC_CHECK_SIZEOF(int).
  15         * configure: Regenerate.
  16         * coffgen.c (coff_get_reloc_upper_bound): Replace gcc diagnostic
  17         workaround with SIZEOF_LONG vs. SIZEOF_INT check.
  18         * elf.c (_bfd_elf_get_reloc_upper_bound): Likewise.
  19         * elf64-sparc.c (elf64_sparc_get_reloc_upper_bound): Likewise.
  20         * mach-o.c (bfd_mach_o_get_reloc_upper_bound): Likewise.
  21
  22 2019-03-21  Jim Wilson  <jimw@sifive.com>
  23
  24         PR 24365
  25         * elfnn-riscv.c (riscv_elf_relocate_section): For STT_SECTION check,
  26         verify sym non-NULL before using.  Add identical check using h.
  27
  28 2019-03-21  Sudakshina Das  <sudi.das@arm.com>
  29
  30         * elf-bfd.h (struct elf_backend_data): Add argument to
  31         merge_gnu_properties.
  32         * elf-properties.c (elf_merge_gnu_properties): Add argument to
  33         itself and while calling bed->merge_gnu_properties.
  34         (elf_merge_gnu_property_list): Update the calls for
  35         elf_merge_gnu_properties.
  36         * elfnn-aarch64.c (elfNN_aarch64_merge_gnu_properties): Update handling
  37         of --force-bti warning and add argument.
  38         * elfxx-aarch64.c (_bfd_aarch64_elf_link_setup_gnu_properties): Add
  39         warning.
  40         * elfxx-x86.c (_bfd_x86_elf_merge_gnu_properties): Add argument.
  41         * elfxx-x86.h (_bfd_x86_elf_merge_gnu_properties): Likewise in
  42         declaration.
  43
  44 2019-03-20  Sudakshina Das  <sudi.das@arm.com>
  45
  46         * elfxx-aarch64.c (_bfd_aarch64_elf_link_fixup_gnu_properties): Define.
  47         * elfxx-aarch64.h (_bfd_aarch64_elf_link_fixup_gnu_properties): Declare.
  48         (elf_backend_fixup_gnu_properties): Define for AArch64.
  49
  50 2019-03-18  Alan Modra  <amodra@gmail.com>
  51
  52         PR 24355
  53         * elf32-ppc.c (ppc_finish_symbols): Don't call write_glink_stub
  54         for local iplt syms with ent->plt.offset == -1.  Remove ineffective
  55         attempt at writing glink stubs only once.
  56
  57 2019-03-16  Alan Modra  <amodra@gmail.com>
  58
  59         PR 24337
  60         * elf.c (_bfd_elf_rela_local_sym): Revert last change.
  61         (_bfd_elf_rel_local_sym): Likewise.
  62         * elflink.c (elf_link_input_bfd): Use bfd_und_section for
  63         section of symbols with unrecognized shndx.
  64
  65 2019-03-15  H.J. Lu  <hongjiu.lu@intel.com>
  66
  67         PR ld/24267
  68         * coffgen.c (_bfd_coff_section_already_linked): Skip discarded
  69         section.
  70         * cofflink.c (coff_link_add_symbols): Check for symbols defined
  71         in discarded section.
  72
  73 2019-03-15  Alan Modra  <amodra@gmail.com>
  74
  75         PR 24339
  76         * elflink.c (elf_link_add_object_symbols): Bail out on a local
  77         symbol after globals if elf_bad_symtab is not set.
  78
  79 2019-03-15  Alan Modra  <amodra@gmail.com>
  80
  81         PR 24337
  82         * elf.c (_bfd_elf_rela_local_sym): Don't segfault on NULL sec.
  83         (_bfd_elf_rel_local_sym): Likewise.
  84
  85 2019-03-15  Alan Modra  <amodra@gmail.com>
  86
  87         PR 24336
  88         * elflink.c (elf_link_read_relocs_from_section): Handle fuzzed
  89         object files with sh_size not a multiple of sh_entsize.
  90
  91 2019-03-15  H.J. Lu  <hongjiu.lu@intel.com>
  92
  93         PR ld/24338
  94         * elf64-x86-64.c (elf_x86_64_relocate_section): Check for corrupt
  95         input with bad relocation.
  96
  97 22019-03-15  H.J. Lu  <hongjiu.lu@intel.com>
  98
  99         * elf64-x86-64.c (elf_x86_64_relocate_section): Re-indent.
 100
 101 2019-03-14  Nick Clifton  <nickc@redhat.com>
 102
 103         PR 24334
 104         * dwarf2.c (struct dwarf2_debug): Add sec_vma_count field.
 105         (save_section_vma): Initialise field to the number of entries in
 106         the sec_vma table.
 107         (section_vma_same): Check that the number of entries in the
 108         sec_vma table matches the number of sections in the bfd.
 109
 110 2019-03-14  Nick Clifton  <nickc@redhat.com>
 111
 112         PR 24333
 113         * elflink.c (_bfd_elf_add_default_symbol): Add a check for a NULL
 114         section owner pointer when adding the default symbol.
 115
 116 2019-03-14  Nick Clifton  <nickc@redhat.com>
 117
 118         PR 24332
 119         * elflink.c (elf_link_add_object_symbols): Add new local variable
 120         extversym_end.  Initialise it to point to the end of the version
 121         symbol table, if present.  Check it when initialising and updating
 122         the ever pointer.
 123
 124 2019-03-13  Sudakshina Das  <sudi.das@arm.com>
 125
 126         * elfnn-aarch64.c (PLT_PAC_ENTRY_SIZE, PLT_PAC_SMALL_ENTRY_SIZE): New.
 127         (PLT_BTI_PAC_ENTRY_SIZE, PLT_BTI_PAC_SMALL_ENTRY_SIZE): New.
 128         (setup_plt_values): Account for PAC or PAC and BTI enabled PLTs.
 129         (elfNN_aarch64_size_dynamic_sections): Add checks for PLT_BTI_PAC
 130         and PLT_PAC_PLT.
 131         (elfNN_aarch64_finish_dynamic_sections): Account for PLT_BTI_PAC.
 132         (get_plt_type): Add case for DT_AARCH64_PAC_PLT.
 133         (elfNN_aarch64_plt_sym_val): Add cases for PLT_BTI_PAC and PLT_PAC.
 134
 135 2019-03-13  Sudakshina Das  <sudi.das@arm.com>
 136             Szabolcs Nagy  <szabolcs.nagy@arm.com>
 137
 138         * bfd-in.h (aarch64_plt_type, aarch64_enable_bti_type): New.
 139         (aarch64_bti_pac_info): New.
 140         (bfd_elf64_aarch64_set_options): Add aarch64_bti_pac_info argument.
 141         (bfd_elf32_aarch64_set_options): Likewise.
 142         * bfd-in2.h: Regenerate
 143         * elfnn-aarch64.c (PLT_BTI_ENTRY_SIZE): New.
 144         (PLT_BTI_SMALL_ENTRY_SIZE, PLT_BTI_TLSDESC_ENTRY_SIZE): New.
 145         (elfNN_aarch64_small_plt0_bti_entry): New.
 146         (elfNN_aarch64_small_plt_bti_entry): New.
 147         (elfNN_aarch64_tlsdesc_small_plt_bti_entry): New.
 148         (elf_aarch64_obj_tdata): Add no_bti_warn and plt_type fields.
 149         (elf_aarch64_link_hash_table): Add plt0_entry, plt_entry and
 150         tlsdesc_plt_entry_size fields.
 151         (elfNN_aarch64_link_hash_table_create): Initialise the new fields.
 152         (setup_plt_values): New helper function.
 153         (bfd_elfNN_aarch64_set_options): Use new bp_info to set plt sizes and
 154         bti enable type.
 155         (elfNN_aarch64_allocate_dynrelocs): Use new size members instead of
 156         fixed macros.
 157         (elfNN_aarch64_size_dynamic_sections): Likewise and add checks.
 158         (elfNN_aarch64_create_small_pltn_entry): Use new generic pointers
 159         to plt stubs instead of fixed ones and update filling them according
 160         to the need for bti.
 161         (elfNN_aarch64_init_small_plt0_entry): Likewise.
 162         (elfNN_aarch64_finish_dynamic_sections): Likewise.
 163         (get_plt_type, elfNN_aarch64_get_synthetic_symtab): New.
 164         (elfNN_aarch64_plt_sym_val): Update size accordingly.
 165         (elfNN_aarch64_link_setup_gnu_properties): Set up plts if BTI GNU NOTE
 166         is set.
 167         (bfd_elfNN_get_synthetic_symtab): Define.
 168         (elfNN_aarch64_merge_gnu_properties): Give out warning with --force-bti
 169         and mising BTI NOTE SECTION.
 170
 171
 172 2019-03-13  Sudakshina Das  <sudi.das@arm.com>
 173
 174         * elf-properties.c (_bfd_elf_link_setup_gnu_properties): Exclude
 175         linker created inputs from merge.
 176         * elfnn-aarch64.c (struct elf_aarch64_obj_tdata): Add field for
 177         GNU_PROPERTY_AARCH64_FEATURE_1_AND properties.
 178         (elfNN_aarch64_link_setup_gnu_properties): New.
 179         (elfNN_aarch64_merge_gnu_properties): New.
 180         (elf_backend_setup_gnu_properties): Define for AArch64.
 181         (elf_backend_merge_gnu_properties): Likewise.
 182         * elfxx-aarch64.c (_bfd_aarch64_elf_link_setup_gnu_properties): Define.
 183         (_bfd_aarch64_elf_parse_gnu_properties): Define.
 184         (_bfd_aarch64_elf_merge_gnu_properties): Define.
 185         * elfxx-aarch64.h (_bfd_aarch64_elf_link_setup_gnu_properties): Declare.
 186         (_bfd_aarch64_elf_parse_gnu_properties): Declare.
 187         (_bfd_aarch64_elf_merge_gnu_properties): Declare.
 188         (elf_backend_parse_gnu_properties): Define for AArch64.
 189
 190 2019-03-13  H.J. Lu  <hongjiu.lu@intel.com>
 191
 192         PR ld/24322
 193         * elfxx-x86.c (_bfd_x86_elf_merge_gnu_properties): Properly
 194         merge GNU_PROPERTY_X86_FEATURE_1_[IBT|SHSTK].
 195
 196 2019-03-12  Alan Modra  <amodra@gmail.com>
 197
 198         * coffcode.h (buy_and_read): Delete unnecessary forward decl.  Add
 199         nmemb parameter.  Use bfd_alloc2.
 200         (coff_slurp_line_table): Use bfd_alloc2.  Update buy_and_read calls.
 201         Delete assertion.
 202         (coff_slurp_symbol_table): Use bfd_alloc2 and bfd_zalloc2.
 203         (coff_slurp_reloc_table): Use bfd_alloc2.  Update buy_and_read calls.
 204         * coffgen.c (coff_get_reloc_upper_bound): Ensure size calculation
 205         doesn't overflow.
 206         * elf.c (bfd_section_from_shdr): Use bfd_zalloc2.  Style fix.
 207         (assign_section_numbers): Style fix.
 208         (swap_out_syms): Use bfd_malloc2.
 209         (_bfd_elf_get_reloc_upper_bound): Ensure size calculation doesn't
 210         overflow.
 211         (_bfd_elf_make_empty_symbol): Style fix.
 212         (elfobj_grok_stapsdt_note_1): Formatting.
 213         * elfcode.h (elf_object_p): Use bfd_alloc2.
 214         (elf_write_relocs, elf_write_shdrs_and_ehdr): Likewise.
 215         (elf_slurp_symbol_table): Use bfd_zalloc2.
 216         (elf_slurp_reloc_table): Use bfd_alloc2.
 217         (_bfd_elf_bfd_from_remote_memory): Use bfd_malloc2.
 218         * elf64-sparc (elf64_sparc_get_reloc_upper_bound): Ensure
 219         size calculation doesn't overflow.
 220         (elf64_sparc_get_dynamic_reloc_upper_bound): Likewise.
 221         * mach-o.c (bfd_mach_o_get_reloc_upper_bound): Likewise.
 222         * pdp11.c (get_reloc_upper_bound): Copy aoutx.h version.
 223
 224 2019-03-08  Alan Modra  <amodra@gmail.com>
 225
 226         PR 24311
 227         * merge.c (merge_strings): Return secinfo.  Don't pad section
 228         to alignment here.
 229         (_bfd_merge_sections): Pad section to alignment here, if input
 230         sections contributing to merged output all pad to alignment.
 231         Formatting.
 232
 233 2019-03-06  Nick Clifton  <nickc@redhat.com>
 234
 235         * dwarf2.c (_bfd_dwarf2_find_symbol_bias): Check for a NULL symbol
 236         table pointer.
 237         * coffgen.c (coff_find_nearest_line_with_names): Do not call
 238         _bfd_dwarf2_find_symbol_bias if there is no symbol table available.
 239
 240 2019-03-01  Andreas Krebbel  <krebbel@linux.ibm.com>
 241
 242         This reverts commit 5a12586d44fa8d5dfc74cbca4f2f36a273a16335.
 243         2019-01-14  Maamoun Tarsha  <maamountk@hotmail.com>
 244
 245         PR 20113
 246         * elf32-s390.c (allocate_dynrelocs): Update comment.
 247
 248 2019-02-28  Tamar Christina  <tamar.christina@arm.com>
 249
 250         * elf-eh-frame.c (_bfd_elf_write_section_eh_frame): Correct CIE parse.
 251
 252 2019-02-28  Nick Clifton  <nickc@redhat.com>
 253
 254         PR 24273
 255         * elf.c (bfd_elf_string_from_elf_section): Check for a string
 256         section that is not NUL terminated.
 257
 258 2019-02-27  H.J. Lu  <hongjiu.lu@intel.com>
 259
 260         PR ld/24276
 261         * elf64-x86-64.c (elf_x86_64_check_relocs): Skip symbol defined
 262         by linker when checking copy reloc on protected symbol.
 263
 264 2019-02-24  Alan Modra  <amodra@gmail.com>
 265
 266         PR 24144
 267         * pdp11.c (set_section_contents): Revert 2015-02-24 change.
 268
 269 2019-02-20  Eric Tsai  <erictsai@cadence.com>
 270
 271         * elf32-xtensa.c (is_resolvable_asm_expansion): Scan output
 272         sections between the call site and call destination and adjust
 273         call distance by the largest alignment.
 274
 275 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 276
 277         * elf-bfd.h (elfcore_write_aarch_pauth): Add declaration.
 278         * elf.c (elfcore_grok_aarch_pauth): New function.
 279         (elfcore_grok_note): Check for NT_ARM_PAC_MASK.
 280         (elfcore_write_aarch_pauth): New function.
 281         (elfcore_write_register_note): Check for AArch64 pauth section.
 282
 283 2019-02-20  Alan Modra  <amodra@gmail.com>
 284
 285         PR 24225
 286         * elf32-nios2.c (nios2_elf32_relocate_section): Check asprintf
 287         return value.
 288
 289 2019-02-20  Michael Roitzsch  <reactorcontrol@icloud.com>
 290
 291         * configure.ac (SHARED_LIBADD): Add -liberty -lintl for all
 292         Darwin hosts, not just or1k.
 293         * configure: Regenerate.
 294
 295 2019-02-20  Alan Modra  <amodra@gmail.com>
 296
 297         PR 24236
 298         * archive64.c (_bfd_archive_64_bit_slurp_armap): Move code adding
 299         sentinel NUL to string buffer nearer to loop where it is used.
 300         Don't go past sentinel when scanning strings, and don't write
 301         NUL again.
 302         * archive.c (do_slurp_coff_armap): Simplify string handling to
 303         archive64.c style.
 304
 305 2019-02-19  Alan Modra  <amodra@gmail.com>
 306
 307         PR 24235
 308         * pei-x86_64.c (pex64_bfd_print_pdata_section): Correct checks
 309         attempting to prevent read past end of section.
 310
 311 2019-02-18  Alan Modra  <amodra@gmail.com>
 312
 313         PR 24225
 314         * elf32-nios2.c (nios2_elf32_relocate_section): Use asprintf and
 315         PRIx64 to generate warning messages.  Print local sym names too.
 316
 317 2019-02-09  Vineet Gupta  <vgupta@synopsys.com>
 318
 319         * elf32-arc (INIT_SYM_STRING): Delete.
 320         (FINI_SYM_STRING): Likewise.
 321         (init_str): Likewise.
 322         (fini_str): Likewise.
 323
 324 2019-02-08  Alan Modra  <amodra@gmail.com>
 325
 326         * elf32-ppc.c (ppc_elf_relocate_section): Add %X to "unsupported
 327         for bss-plt" warning to make it an error.
 328
 329 2019-02-07  Eric Botcazou  <ebotcazou@adacore.com>
 330
 331         PR ld/18841
 332         * elf32-sparc.c (elf32_sparc_reloc_type_class): Return
 333         reloc_class_ifunc for ifunc symbols.
 334         * elf64-sparc.c (elf64_sparc_reloc_type_class): Likewise.
 335
 336 2019-02-07  Eric Botcazou  <ebotcazou@adacore.com>
 337
 338         * elf32-visium.c (visium_elf_howto_parity_reloc): Minor tweak.
 339         <R_VISIUM_PC16>: Use explicit range test to detect an overflow.
 340
 341 2019-02-07  Nick Clifton  <nickc@redhat.com>
 342
 343         * config.bfd: Move the powerpc-lynxos and powerpc-windiss targets
 344         into the definitely obsolete list.
 345
 346 2019-02-05  H.J. Lu  <hongjiu.lu@intel.com>
 347
 348         PR ld/24151
 349         * elf64-x86-64.c (elf_x86_64_need_pic): Check
 350         SYMBOL_DEFINED_NON_SHARED_P instead of def_regular.
 351         (elf_x86_64_relocate_section): Move PIC check for PC-relative
 352         relocations to ...
 353         (elf_x86_64_check_relocs): Here.
 354         (elf_x86_64_finish_dynamic_symbol): Use SYMBOL_DEFINED_NON_SHARED_P
 355         to check if a symbol is defined in a non-shared object.
 356         * elfxx-x86.h (SYMBOL_DEFINED_NON_SHARED_P): New.
 357
 358 2019-01-21  Sergio Durigan Junior  <sergiodj@redhat.com>
 359
 360         * elf32-arm.c (elf32_arm_final_link_relocate): Use 'llabs' instead
 361         of 'labs' (and fix GCC warning).
 362
 363 2019-01-25  Nick Clifton  <nickc@redhat.com>
 364
 365         * po/ru.po: Updated Russian translation.
 366
 367 2019-01-23  Nick Clifton  <nickc@redhat.com>
 368
 369         * po/fr.po: Updated French translation.
 370
 371 2019-01-21  Nick Clifton  <nickc@redhat.com>
 372
 373         * po/pt.po: Updated Portuguese translation.
 374         * po/uk.po: Updated Ukranian translation.
 375
 376 2019-01-21  Yuri Chornoivan  <yurchor@ukr.net>
 377
 378         PR 24108
 379         * elf32-nds32.c (nds32_relocate_section): Add space between words
 380         in error message.
 381         * elfnn-riscv.c (riscv_version_mismatch): Fix spelling mistake in
 382         error message.
 383         (riscv_i_or_e_p): Likewise.
 384         (riscv_merge_arch_attr_info): Likewise.
 385
 386 2019-01-19  Nick Clifton  <nickc@redhat.com>
 387
 388         * version.m4: Reset to 2.32.51
 389         * configure: Regenerate.
 390         * po/bfd.pot: Regenerate.
 391
 392 2018-06-24  Nick Clifton  <nickc@redhat.com>
 393
 394         2.32 branch created.
 395
 396 2019-01-16  Kito Cheng  <kito@andestech.com>
 397
 398         * elf-attrs.c (vendor_obj_attr_size): Return 0 if size is 0 even
 399         for OBJ_ATTR_PROC.
 400
 401 2019-01-16  Kito Cheng  <kito@andestech.com>
 402             Nelson Chu  <nelson@andestech.com>
 403
 404         * elfnn-riscv.c (in_subsets): New.
 405         (out_subsets): Likewise.
 406         (merged_subsets): Likewise.
 407         (riscv_std_ext_p): Likewise.
 408         (riscv_non_std_ext_p): Likewise.
 409         (riscv_std_sv_ext_p): Likewise.
 410         (riscv_non_std_sv_ext_p): Likewise.
 411         (riscv_version_mismatch): Likewise.
 412         (riscv_i_or_e_p): Likewise.
 413         (riscv_merge_std_ext): Likewise.
 414         (riscv_merge_non_std_and_sv_ext): Likewise.
 415         (riscv_merge_arch_attr_info): Likewise.
 416         (riscv_merge_attributes): Likewise.
 417         (_bfd_riscv_elf_merge_private_bfd_data): Merge attribute.
 418
 419         * elfnn-riscv.c (riscv_elf_obj_attrs_arg_type): New.
 420         (elf_backend_obj_attrs_vendor): Define.
 421         (elf_backend_obj_attrs_section_type): Likewise.
 422         (elf_backend_obj_attrs_section): Likewise.
 423         (elf_backend_obj_attrs_arg_type): Define as
 424         riscv_elf_obj_attrs_arg_type.
 425         * elfxx-riscv.c (riscv_estimate_digit): New.
 426         (riscv_estimate_arch_strlen1): Likewise.
 427         (riscv_estimate_arch_strlen): Likewise.
 428         (riscv_arch_str1): Likewise.
 429         (riscv_arch_str): Likewise.
 430         * elfxx-riscv.h (riscv_arch_str): Declare.
 431
 432 2019-01-14  John Darrington <john@darrington.wattle.id.au>
 433
 434         * bfd-in2.h [BFD_RELOC_S12Z_OPR]: New reloc.
 435         * libbfd.h: regen.
 436         * elf32-s12z.c (eld_s12z_howto_table): R_S12Z_OPR takes non zero
 437         source field.  (md_apply_fix): Apply final fix
 438         to BFD_RELOC_S12Z_OPR.
 439         * reloc.c[BFD_RELOC_S12Z_OPR]: New reloc.
 440
 441 2019-01-14  Maamoun Tarsha  <maamountk@hotmail.com>
 442
 443         PR 20113
 444         * elf32-s390.c (allocate_dynrelocs): Update comment.
 445
 446 2019-01-09  Andrew Paprocki  <andrew@ishiboo.com>
 447
 448         * warning.m4: Adjust egrep pattern for non-GNU compilers.
 449         * configure: Regenerate.
 450
 451 2019-01-08  Alan Modra  <amodra@gmail.com>
 452
 453         PR 23699
 454         PR 24065
 455         * ihex.c (ihex_write_object_contents): Properly check 32-bit
 456         address range.
 457
 458 2019-01-05  Yoshinori Sato <ysato@users.sourceforge.jp>
 459
 460         * bfd/archures.c: Add bfd_mach_rx_v2 and bfd_mach_rx_v3.
 461         * bfd/bfd-in2.h: Regenerate.
 462         * bfd/cpu-rx.c (arch_info_struct): Add RXv2 and RXv3 entry.
 463         * bfd/elf32-rx.c (elf32_rx_machine): Add RXv2 and RXv3 support.
 464
 465 2019-01-04  Lifang Xia  <lifang_xia@c-sky.com>
 466
 467         * config.bfd (csky-*-elf* | csky-*-linux*): Modify the csky
 468         default target, little endian target is more suitable.
 469
 470 2019-01-04  Alan Modra  <amodra@gmail.com>
 471
 472         PR 24061
 473         PR 21786
 474         * coff-rs6000.c (GET_VALUE_IN_FIELD): Add base parameter and
 475         adjust all callers.
 476         (EQ_VALUE_IN_FIELD): Likewise.
 477         * coff64-rs6000.c (GET_VALUE_IN_FIELD): Likewise.
 478
 479 2019-01-01  Alan Modra  <amodra@gmail.com>
 480
 481         Update year range in copyright notice of all files.
 482
 483 For older changes see ChangeLog-2018
 484 \f
 485 Copyright (C) 2019 Free Software Foundation, Inc.
 486
 487 Copying and distribution of this file, with or without modification,
 488 are permitted in any medium without royalty provided the copyright
 489 notice and this notice are preserved.
 490
 491 Local Variables:
 492 mode: change-log
 493 left-margin: 8
 494 fill-column: 74
 495 version-control: never
 496 End: