drivers/gpu/drm/i915/intel_lvds.c

   1 /*
   2  * Copyright © 2006-2007 Intel Corporation
   3  * Copyright (c) 2006 Dave Airlie <airlied@linux.ie>
   4  *
   5  * Permission is hereby granted, free of charge, to any person obtaining a
   6  * copy of this software and associated documentation files (the "Software"),
   7  * to deal in the Software without restriction, including without limitation
   8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   9  * and/or sell copies of the Software, and to permit persons to whom the
  10  * Software is furnished to do so, subject to the following conditions:
  11  *
  12  * The above copyright notice and this permission notice (including the next
  13  * paragraph) shall be included in all copies or substantial portions of the
  14  * Software.
  15  *
  16  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  17  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  18  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  19  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  20  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  21  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  22  * DEALINGS IN THE SOFTWARE.
  23  *
  24  * Authors:
  25  *      Eric Anholt <eric@anholt.net>
  26  *      Dave Airlie <airlied@linux.ie>
  27  *      Jesse Barnes <jesse.barnes@intel.com>
  28  */
  29
  30 #include <acpi/button.h>
  31 #include <linux/dmi.h>
  32 #include <linux/i2c.h>
  33 #include <linux/slab.h>
  34 #include <linux/vga_switcheroo.h>
  35 #include <drm/drmP.h>
  36 #include <drm/drm_atomic_helper.h>
  37 #include <drm/drm_crtc.h>
  38 #include <drm/drm_edid.h>
  39 #include "intel_drv.h"
  40 #include <drm/i915_drm.h>
  41 #include "i915_drv.h"
  42 #include <linux/acpi.h>
  43
  44 /* Private structure for the integrated LVDS support */
  45 struct intel_lvds_connector {
  46         struct intel_connector base;
  47
  48         struct notifier_block lid_notifier;
  49 };
  50
  51 struct intel_lvds_encoder {
  52         struct intel_encoder base;
  53
  54         bool is_dual_link;
  55         i915_reg_t reg;
  56         u32 a3_power;
  57
  58         struct intel_lvds_connector *attached_connector;
  59 };
  60
  61 static struct intel_lvds_encoder *to_lvds_encoder(struct drm_encoder *encoder)
  62 {
  63         return container_of(encoder, struct intel_lvds_encoder, base.base);
  64 }
  65
  66 static struct intel_lvds_connector *to_lvds_connector(struct drm_connector *connector)
  67 {
  68         return container_of(connector, struct intel_lvds_connector, base.base);
  69 }
  70
  71 static bool intel_lvds_get_hw_state(struct intel_encoder *encoder,
  72                                     enum pipe *pipe)
  73 {
  74         struct drm_device *dev = encoder->base.dev;
  75         struct drm_i915_private *dev_priv = dev->dev_private;
  76         struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
  77         enum intel_display_power_domain power_domain;
  78         u32 tmp;
  79         bool ret;
  80
  81         power_domain = intel_display_port_power_domain(encoder);
  82         if (!intel_display_power_get_if_enabled(dev_priv, power_domain))
  83                 return false;
  84
  85         ret = false;
  86
  87         tmp = I915_READ(lvds_encoder->reg);
  88
  89         if (!(tmp & LVDS_PORT_EN))
  90                 goto out;
  91
  92         if (HAS_PCH_CPT(dev))
  93                 *pipe = PORT_TO_PIPE_CPT(tmp);
  94         else
  95                 *pipe = PORT_TO_PIPE(tmp);
  96
  97         ret = true;
  98
  99 out:
 100         intel_display_power_put(dev_priv, power_domain);
 101
 102         return ret;
 103 }
 104
 105 static void intel_lvds_get_config(struct intel_encoder *encoder,
 106                                   struct intel_crtc_state *pipe_config)
 107 {
 108         struct drm_device *dev = encoder->base.dev;
 109         struct drm_i915_private *dev_priv = dev->dev_private;
 110         struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
 111         u32 tmp, flags = 0;
 112
 113         tmp = I915_READ(lvds_encoder->reg);
 114         if (tmp & LVDS_HSYNC_POLARITY)
 115                 flags |= DRM_MODE_FLAG_NHSYNC;
 116         else
 117                 flags |= DRM_MODE_FLAG_PHSYNC;
 118         if (tmp & LVDS_VSYNC_POLARITY)
 119                 flags |= DRM_MODE_FLAG_NVSYNC;
 120         else
 121                 flags |= DRM_MODE_FLAG_PVSYNC;
 122
 123         pipe_config->base.adjusted_mode.flags |= flags;
 124
 125         if (INTEL_INFO(dev)->gen < 5)
 126                 pipe_config->gmch_pfit.lvds_border_bits =
 127                         tmp & LVDS_BORDER_ENABLE;
 128
 129         /* gen2/3 store dither state in pfit control, needs to match */
 130         if (INTEL_INFO(dev)->gen < 4) {
 131                 tmp = I915_READ(PFIT_CONTROL);
 132
 133                 pipe_config->gmch_pfit.control |= tmp & PANEL_8TO6_DITHER_ENABLE;
 134         }
 135
 136         pipe_config->base.adjusted_mode.crtc_clock = pipe_config->port_clock;
 137 }
 138
 139 static void intel_pre_enable_lvds(struct intel_encoder *encoder)
 140 {
 141         struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
 142         struct drm_device *dev = encoder->base.dev;
 143         struct drm_i915_private *dev_priv = dev->dev_private;
 144         struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
 145         const struct drm_display_mode *adjusted_mode = &crtc->config->base.adjusted_mode;
 146         int pipe = crtc->pipe;
 147         u32 temp;
 148
 149         if (HAS_PCH_SPLIT(dev)) {
 150                 assert_fdi_rx_pll_disabled(dev_priv, pipe);
 151                 assert_shared_dpll_disabled(dev_priv,
 152                                             crtc->config->shared_dpll);
 153         } else {
 154                 assert_pll_disabled(dev_priv, pipe);
 155         }
 156
 157         temp = I915_READ(lvds_encoder->reg);
 158         temp |= LVDS_PORT_EN | LVDS_A0A2_CLKA_POWER_UP;
 159
 160         if (HAS_PCH_CPT(dev)) {
 161                 temp &= ~PORT_TRANS_SEL_MASK;
 162                 temp |= PORT_TRANS_SEL_CPT(pipe);
 163         } else {
 164                 if (pipe == 1) {
 165                         temp |= LVDS_PIPEB_SELECT;
 166                 } else {
 167                         temp &= ~LVDS_PIPEB_SELECT;
 168                 }
 169         }
 170
 171         /* set the corresponsding LVDS_BORDER bit */
 172         temp &= ~LVDS_BORDER_ENABLE;
 173         temp |= crtc->config->gmch_pfit.lvds_border_bits;
 174         /* Set the B0-B3 data pairs corresponding to whether we're going to
 175          * set the DPLLs for dual-channel mode or not.
 176          */
 177         if (lvds_encoder->is_dual_link)
 178                 temp |= LVDS_B0B3_POWER_UP | LVDS_CLKB_POWER_UP;
 179         else
 180                 temp &= ~(LVDS_B0B3_POWER_UP | LVDS_CLKB_POWER_UP);
 181
 182         /* It would be nice to set 24 vs 18-bit mode (LVDS_A3_POWER_UP)
 183          * appropriately here, but we need to look more thoroughly into how
 184          * panels behave in the two modes. For now, let's just maintain the
 185          * value we got from the BIOS.
 186          */
 187          temp &= ~LVDS_A3_POWER_MASK;
 188          temp |= lvds_encoder->a3_power;
 189
 190         /* Set the dithering flag on LVDS as needed, note that there is no
 191          * special lvds dither control bit on pch-split platforms, dithering is
 192          * only controlled through the PIPECONF reg. */
 193         if (INTEL_INFO(dev)->gen == 4) {
 194                 /* Bspec wording suggests that LVDS port dithering only exists
 195                  * for 18bpp panels. */
 196                 if (crtc->config->dither && crtc->config->pipe_bpp == 18)
 197                         temp |= LVDS_ENABLE_DITHER;
 198                 else
 199                         temp &= ~LVDS_ENABLE_DITHER;
 200         }
 201         temp &= ~(LVDS_HSYNC_POLARITY | LVDS_VSYNC_POLARITY);
 202         if (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC)
 203                 temp |= LVDS_HSYNC_POLARITY;
 204         if (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC)
 205                 temp |= LVDS_VSYNC_POLARITY;
 206
 207         I915_WRITE(lvds_encoder->reg, temp);
 208 }
 209
 210 /**
 211  * Sets the power state for the panel.
 212  */
 213 static void intel_enable_lvds(struct intel_encoder *encoder)
 214 {
 215         struct drm_device *dev = encoder->base.dev;
 216         struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
 217         struct intel_connector *intel_connector =
 218                 &lvds_encoder->attached_connector->base;
 219         struct drm_i915_private *dev_priv = dev->dev_private;
 220         i915_reg_t ctl_reg, stat_reg;
 221
 222         if (HAS_PCH_SPLIT(dev)) {
 223                 ctl_reg = PCH_PP_CONTROL;
 224                 stat_reg = PCH_PP_STATUS;
 225         } else {
 226                 ctl_reg = PP_CONTROL;
 227                 stat_reg = PP_STATUS;
 228         }
 229
 230         I915_WRITE(lvds_encoder->reg, I915_READ(lvds_encoder->reg) | LVDS_PORT_EN);
 231
 232         I915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON);
 233         POSTING_READ(lvds_encoder->reg);
 234         if (wait_for((I915_READ(stat_reg) & PP_ON) != 0, 1000))
 235                 DRM_ERROR("timed out waiting for panel to power on\n");
 236
 237         intel_panel_enable_backlight(intel_connector);
 238 }
 239
 240 static void intel_disable_lvds(struct intel_encoder *encoder)
 241 {
 242         struct drm_device *dev = encoder->base.dev;
 243         struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
 244         struct drm_i915_private *dev_priv = dev->dev_private;
 245         i915_reg_t ctl_reg, stat_reg;
 246
 247         if (HAS_PCH_SPLIT(dev)) {
 248                 ctl_reg = PCH_PP_CONTROL;
 249                 stat_reg = PCH_PP_STATUS;
 250         } else {
 251                 ctl_reg = PP_CONTROL;
 252                 stat_reg = PP_STATUS;
 253         }
 254
 255         I915_WRITE(ctl_reg, I915_READ(ctl_reg) & ~POWER_TARGET_ON);
 256         if (wait_for((I915_READ(stat_reg) & PP_ON) == 0, 1000))
 257                 DRM_ERROR("timed out waiting for panel to power off\n");
 258
 259         I915_WRITE(lvds_encoder->reg, I915_READ(lvds_encoder->reg) & ~LVDS_PORT_EN);
 260         POSTING_READ(lvds_encoder->reg);
 261 }
 262
 263 static void gmch_disable_lvds(struct intel_encoder *encoder)
 264 {
 265         struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
 266         struct intel_connector *intel_connector =
 267                 &lvds_encoder->attached_connector->base;
 268
 269         intel_panel_disable_backlight(intel_connector);
 270
 271         intel_disable_lvds(encoder);
 272 }
 273
 274 static void pch_disable_lvds(struct intel_encoder *encoder)
 275 {
 276         struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
 277         struct intel_connector *intel_connector =
 278                 &lvds_encoder->attached_connector->base;
 279
 280         intel_panel_disable_backlight(intel_connector);
 281 }
 282
 283 static void pch_post_disable_lvds(struct intel_encoder *encoder)
 284 {
 285         intel_disable_lvds(encoder);
 286 }
 287
 288 static enum drm_mode_status
 289 intel_lvds_mode_valid(struct drm_connector *connector,
 290                       struct drm_display_mode *mode)
 291 {
 292         struct intel_connector *intel_connector = to_intel_connector(connector);
 293         struct drm_display_mode *fixed_mode = intel_connector->panel.fixed_mode;
 294         int max_pixclk = to_i915(connector->dev)->max_dotclk_freq;
 295
 296         if (mode->hdisplay > fixed_mode->hdisplay)
 297                 return MODE_PANEL;
 298         if (mode->vdisplay > fixed_mode->vdisplay)
 299                 return MODE_PANEL;
 300         if (fixed_mode->clock > max_pixclk)
 301                 return MODE_CLOCK_HIGH;
 302
 303         return MODE_OK;
 304 }
 305
 306 static bool intel_lvds_compute_config(struct intel_encoder *intel_encoder,
 307                                       struct intel_crtc_state *pipe_config)
 308 {
 309         struct drm_device *dev = intel_encoder->base.dev;
 310         struct intel_lvds_encoder *lvds_encoder =
 311                 to_lvds_encoder(&intel_encoder->base);
 312         struct intel_connector *intel_connector =
 313                 &lvds_encoder->attached_connector->base;
 314         struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
 315         struct intel_crtc *intel_crtc = to_intel_crtc(pipe_config->base.crtc);
 316         unsigned int lvds_bpp;
 317
 318         /* Should never happen!! */
 319         if (INTEL_INFO(dev)->gen < 4 && intel_crtc->pipe == 0) {
 320                 DRM_ERROR("Can't support LVDS on pipe A\n");
 321                 return false;
 322         }
 323
 324         if (lvds_encoder->a3_power == LVDS_A3_POWER_UP)
 325                 lvds_bpp = 8*3;
 326         else
 327                 lvds_bpp = 6*3;
 328
 329         if (lvds_bpp != pipe_config->pipe_bpp && !pipe_config->bw_constrained) {
 330                 DRM_DEBUG_KMS("forcing display bpp (was %d) to LVDS (%d)\n",
 331                               pipe_config->pipe_bpp, lvds_bpp);
 332                 pipe_config->pipe_bpp = lvds_bpp;
 333         }
 334
 335         /*
 336          * We have timings from the BIOS for the panel, put them in
 337          * to the adjusted mode.  The CRTC will be set up for this mode,
 338          * with the panel scaling set up to source from the H/VDisplay
 339          * of the original mode.
 340          */
 341         intel_fixed_panel_mode(intel_connector->panel.fixed_mode,
 342                                adjusted_mode);
 343
 344         if (HAS_PCH_SPLIT(dev)) {
 345                 pipe_config->has_pch_encoder = true;
 346
 347                 intel_pch_panel_fitting(intel_crtc, pipe_config,
 348                                         intel_connector->panel.fitting_mode);
 349         } else {
 350                 intel_gmch_panel_fitting(intel_crtc, pipe_config,
 351                                          intel_connector->panel.fitting_mode);
 352
 353         }
 354
 355         /*
 356          * XXX: It would be nice to support lower refresh rates on the
 357          * panels to reduce power consumption, and perhaps match the
 358          * user's requested refresh rate.
 359          */
 360
 361         return true;
 362 }
 363
 364 /**
 365  * Detect the LVDS connection.
 366  *
 367  * Since LVDS doesn't have hotlug, we use the lid as a proxy.  Open means
 368  * connected and closed means disconnected.  We also send hotplug events as
 369  * needed, using lid status notification from the input layer.
 370  */
 371 static enum drm_connector_status
 372 intel_lvds_detect(struct drm_connector *connector, bool force)
 373 {
 374         struct drm_device *dev = connector->dev;
 375         enum drm_connector_status status;
 376
 377         DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
 378                       connector->base.id, connector->name);
 379
 380         status = intel_panel_detect(dev);
 381         if (status != connector_status_unknown)
 382                 return status;
 383
 384         return connector_status_connected;
 385 }
 386
 387 /**
 388  * Return the list of DDC modes if available, or the BIOS fixed mode otherwise.
 389  */
 390 static int intel_lvds_get_modes(struct drm_connector *connector)
 391 {
 392         struct intel_lvds_connector *lvds_connector = to_lvds_connector(connector);
 393         struct drm_device *dev = connector->dev;
 394         struct drm_display_mode *mode;
 395
 396         /* use cached edid if we have one */
 397         if (!IS_ERR_OR_NULL(lvds_connector->base.edid))
 398                 return drm_add_edid_modes(connector, lvds_connector->base.edid);
 399
 400         mode = drm_mode_duplicate(dev, lvds_connector->base.panel.fixed_mode);
 401         if (mode == NULL)
 402                 return 0;
 403
 404         drm_mode_probed_add(connector, mode);
 405         return 1;
 406 }
 407
 408 static int intel_no_modeset_on_lid_dmi_callback(const struct dmi_system_id *id)
 409 {
 410         DRM_INFO("Skipping forced modeset for %s\n", id->ident);
 411         return 1;
 412 }
 413
 414 /* The GPU hangs up on these systems if modeset is performed on LID open */
 415 static const struct dmi_system_id intel_no_modeset_on_lid[] = {
 416         {
 417                 .callback = intel_no_modeset_on_lid_dmi_callback,
 418                 .ident = "Toshiba Tecra A11",
 419                 .matches = {
 420                         DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
 421                         DMI_MATCH(DMI_PRODUCT_NAME, "TECRA A11"),
 422                 },
 423         },
 424
 425         { }     /* terminating entry */
 426 };
 427
 428 /*
 429  * Lid events. Note the use of 'modeset':
 430  *  - we set it to MODESET_ON_LID_OPEN on lid close,
 431  *    and set it to MODESET_DONE on open
 432  *  - we use it as a "only once" bit (ie we ignore
 433  *    duplicate events where it was already properly set)
 434  *  - the suspend/resume paths will set it to
 435  *    MODESET_SUSPENDED and ignore the lid open event,
 436  *    because they restore the mode ("lid open").
 437  */
 438 static int intel_lid_notify(struct notifier_block *nb, unsigned long val,
 439                             void *unused)
 440 {
 441         struct intel_lvds_connector *lvds_connector =
 442                 container_of(nb, struct intel_lvds_connector, lid_notifier);
 443         struct drm_connector *connector = &lvds_connector->base.base;
 444         struct drm_device *dev = connector->dev;
 445         struct drm_i915_private *dev_priv = dev->dev_private;
 446
 447         if (dev->switch_power_state != DRM_SWITCH_POWER_ON)
 448                 return NOTIFY_OK;
 449
 450         mutex_lock(&dev_priv->modeset_restore_lock);
 451         if (dev_priv->modeset_restore == MODESET_SUSPENDED)
 452                 goto exit;
 453         /*
 454          * check and update the status of LVDS connector after receiving
 455          * the LID nofication event.
 456          */
 457         connector->status = connector->funcs->detect(connector, false);
 458
 459         /* Don't force modeset on machines where it causes a GPU lockup */
 460         if (dmi_check_system(intel_no_modeset_on_lid))
 461                 goto exit;
 462         if (!acpi_lid_open()) {
 463                 /* do modeset on next lid open event */
 464                 dev_priv->modeset_restore = MODESET_ON_LID_OPEN;
 465                 goto exit;
 466         }
 467
 468         if (dev_priv->modeset_restore == MODESET_DONE)
 469                 goto exit;
 470
 471         /*
 472          * Some old platform's BIOS love to wreak havoc while the lid is closed.
 473          * We try to detect this here and undo any damage. The split for PCH
 474          * platforms is rather conservative and a bit arbitrary expect that on
 475          * those platforms VGA disabling requires actual legacy VGA I/O access,
 476          * and as part of the cleanup in the hw state restore we also redisable
 477          * the vga plane.
 478          */
 479         if (!HAS_PCH_SPLIT(dev))
 480                 intel_display_resume(dev);
 481
 482         dev_priv->modeset_restore = MODESET_DONE;
 483
 484 exit:
 485         mutex_unlock(&dev_priv->modeset_restore_lock);
 486         return NOTIFY_OK;
 487 }
 488
 489 /**
 490  * intel_lvds_destroy - unregister and free LVDS structures
 491  * @connector: connector to free
 492  *
 493  * Unregister the DDC bus for this connector then free the driver private
 494  * structure.
 495  */
 496 static void intel_lvds_destroy(struct drm_connector *connector)
 497 {
 498         struct intel_lvds_connector *lvds_connector =
 499                 to_lvds_connector(connector);
 500
 501         if (lvds_connector->lid_notifier.notifier_call)
 502                 acpi_lid_notifier_unregister(&lvds_connector->lid_notifier);
 503
 504         if (!IS_ERR_OR_NULL(lvds_connector->base.edid))
 505                 kfree(lvds_connector->base.edid);
 506
 507         intel_panel_fini(&lvds_connector->base.panel);
 508
 509         drm_connector_cleanup(connector);
 510         kfree(connector);
 511 }
 512
 513 static int intel_lvds_set_property(struct drm_connector *connector,
 514                                    struct drm_property *property,
 515                                    uint64_t value)
 516 {
 517         struct intel_connector *intel_connector = to_intel_connector(connector);
 518         struct drm_device *dev = connector->dev;
 519
 520         if (property == dev->mode_config.scaling_mode_property) {
 521                 struct drm_crtc *crtc;
 522
 523                 if (value == DRM_MODE_SCALE_NONE) {
 524                         DRM_DEBUG_KMS("no scaling not supported\n");
 525                         return -EINVAL;
 526                 }
 527
 528                 if (intel_connector->panel.fitting_mode == value) {
 529                         /* the LVDS scaling property is not changed */
 530                         return 0;
 531                 }
 532                 intel_connector->panel.fitting_mode = value;
 533
 534                 crtc = intel_attached_encoder(connector)->base.crtc;
 535                 if (crtc && crtc->state->enable) {
 536                         /*
 537                          * If the CRTC is enabled, the display will be changed
 538                          * according to the new panel fitting mode.
 539                          */
 540                         intel_crtc_restore_mode(crtc);
 541                 }
 542         }
 543
 544         return 0;
 545 }
 546
 547 static const struct drm_connector_helper_funcs intel_lvds_connector_helper_funcs = {
 548         .get_modes = intel_lvds_get_modes,
 549         .mode_valid = intel_lvds_mode_valid,
 550         .best_encoder = intel_best_encoder,
 551 };
 552
 553 static const struct drm_connector_funcs intel_lvds_connector_funcs = {
 554         .dpms = drm_atomic_helper_connector_dpms,
 555         .detect = intel_lvds_detect,
 556         .fill_modes = drm_helper_probe_single_connector_modes,
 557         .set_property = intel_lvds_set_property,
 558         .atomic_get_property = intel_connector_atomic_get_property,
 559         .destroy = intel_lvds_destroy,
 560         .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
 561         .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
 562 };
 563
 564 static const struct drm_encoder_funcs intel_lvds_enc_funcs = {
 565         .destroy = intel_encoder_destroy,
 566 };
 567
 568 static int intel_no_lvds_dmi_callback(const struct dmi_system_id *id)
 569 {
 570         DRM_INFO("Skipping LVDS initialization for %s\n", id->ident);
 571         return 1;
 572 }
 573
 574 /* These systems claim to have LVDS, but really don't */
 575 static const struct dmi_system_id intel_no_lvds[] = {
 576         {
 577                 .callback = intel_no_lvds_dmi_callback,
 578                 .ident = "Apple Mac Mini (Core series)",
 579                 .matches = {
 580                         DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
 581                         DMI_MATCH(DMI_PRODUCT_NAME, "Macmini1,1"),
 582                 },
 583         },
 584         {
 585                 .callback = intel_no_lvds_dmi_callback,
 586                 .ident = "Apple Mac Mini (Core 2 series)",
 587                 .matches = {
 588                         DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
 589                         DMI_MATCH(DMI_PRODUCT_NAME, "Macmini2,1"),
 590                 },
 591         },
 592         {
 593                 .callback = intel_no_lvds_dmi_callback,
 594                 .ident = "MSI IM-945GSE-A",
 595                 .matches = {
 596                         DMI_MATCH(DMI_SYS_VENDOR, "MSI"),
 597                         DMI_MATCH(DMI_PRODUCT_NAME, "A9830IMS"),
 598                 },
 599         },
 600         {
 601                 .callback = intel_no_lvds_dmi_callback,
 602                 .ident = "Dell Studio Hybrid",
 603                 .matches = {
 604                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
 605                         DMI_MATCH(DMI_PRODUCT_NAME, "Studio Hybrid 140g"),
 606                 },
 607         },
 608         {
 609                 .callback = intel_no_lvds_dmi_callback,
 610                 .ident = "Dell OptiPlex FX170",
 611                 .matches = {
 612                         DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
 613                         DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex FX170"),
 614                 },
 615         },
 616         {
 617                 .callback = intel_no_lvds_dmi_callback,
 618                 .ident = "AOpen Mini PC",
 619                 .matches = {
 620                         DMI_MATCH(DMI_SYS_VENDOR, "AOpen"),
 621                         DMI_MATCH(DMI_PRODUCT_NAME, "i965GMx-IF"),
 622                 },
 623         },
 624         {
 625                 .callback = intel_no_lvds_dmi_callback,
 626                 .ident = "AOpen Mini PC MP915",
 627                 .matches = {
 628                         DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
 629                         DMI_MATCH(DMI_BOARD_NAME, "i915GMx-F"),
 630                 },
 631         },
 632         {
 633                 .callback = intel_no_lvds_dmi_callback,
 634                 .ident = "AOpen i915GMm-HFS",
 635                 .matches = {
 636                         DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
 637                         DMI_MATCH(DMI_BOARD_NAME, "i915GMm-HFS"),
 638                 },
 639         },
 640         {
 641                 .callback = intel_no_lvds_dmi_callback,
 642                 .ident = "AOpen i45GMx-I",
 643                 .matches = {
 644                         DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
 645                         DMI_MATCH(DMI_BOARD_NAME, "i45GMx-I"),
 646                 },
 647         },
 648         {
 649                 .callback = intel_no_lvds_dmi_callback,
 650                 .ident = "Aopen i945GTt-VFA",
 651                 .matches = {
 652                         DMI_MATCH(DMI_PRODUCT_VERSION, "AO00001JW"),
 653                 },
 654         },
 655         {
 656                 .callback = intel_no_lvds_dmi_callback,
 657                 .ident = "Clientron U800",
 658                 .matches = {
 659                         DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
 660                         DMI_MATCH(DMI_PRODUCT_NAME, "U800"),
 661                 },
 662         },
 663         {
 664                 .callback = intel_no_lvds_dmi_callback,
 665                 .ident = "Clientron E830",
 666                 .matches = {
 667                         DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
 668                         DMI_MATCH(DMI_PRODUCT_NAME, "E830"),
 669                 },
 670         },
 671         {
 672                 .callback = intel_no_lvds_dmi_callback,
 673                 .ident = "Asus EeeBox PC EB1007",
 674                 .matches = {
 675                         DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer INC."),
 676                         DMI_MATCH(DMI_PRODUCT_NAME, "EB1007"),
 677                 },
 678         },
 679         {
 680                 .callback = intel_no_lvds_dmi_callback,
 681                 .ident = "Asus AT5NM10T-I",
 682                 .matches = {
 683                         DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
 684                         DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"),
 685                 },
 686         },
 687         {
 688                 .callback = intel_no_lvds_dmi_callback,
 689                 .ident = "Hewlett-Packard HP t5740",
 690                 .matches = {
 691                         DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
 692                         DMI_MATCH(DMI_PRODUCT_NAME, " t5740"),
 693                 },
 694         },
 695         {
 696                 .callback = intel_no_lvds_dmi_callback,
 697                 .ident = "Hewlett-Packard t5745",
 698                 .matches = {
 699                         DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
 700                         DMI_MATCH(DMI_PRODUCT_NAME, "hp t5745"),
 701                 },
 702         },
 703         {
 704                 .callback = intel_no_lvds_dmi_callback,
 705                 .ident = "Hewlett-Packard st5747",
 706                 .matches = {
 707                         DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
 708                         DMI_MATCH(DMI_PRODUCT_NAME, "hp st5747"),
 709                 },
 710         },
 711         {
 712                 .callback = intel_no_lvds_dmi_callback,
 713                 .ident = "MSI Wind Box DC500",
 714                 .matches = {
 715                         DMI_MATCH(DMI_BOARD_VENDOR, "MICRO-STAR INTERNATIONAL CO., LTD"),
 716                         DMI_MATCH(DMI_BOARD_NAME, "MS-7469"),
 717                 },
 718         },
 719         {
 720                 .callback = intel_no_lvds_dmi_callback,
 721                 .ident = "Gigabyte GA-D525TUD",
 722                 .matches = {
 723                         DMI_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
 724                         DMI_MATCH(DMI_BOARD_NAME, "D525TUD"),
 725                 },
 726         },
 727         {
 728                 .callback = intel_no_lvds_dmi_callback,
 729                 .ident = "Supermicro X7SPA-H",
 730                 .matches = {
 731                         DMI_MATCH(DMI_SYS_VENDOR, "Supermicro"),
 732                         DMI_MATCH(DMI_PRODUCT_NAME, "X7SPA-H"),
 733                 },
 734         },
 735         {
 736                 .callback = intel_no_lvds_dmi_callback,
 737                 .ident = "Fujitsu Esprimo Q900",
 738                 .matches = {
 739                         DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
 740                         DMI_MATCH(DMI_PRODUCT_NAME, "ESPRIMO Q900"),
 741                 },
 742         },
 743         {
 744                 .callback = intel_no_lvds_dmi_callback,
 745                 .ident = "Intel D410PT",
 746                 .matches = {
 747                         DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
 748                         DMI_MATCH(DMI_BOARD_NAME, "D410PT"),
 749                 },
 750         },
 751         {
 752                 .callback = intel_no_lvds_dmi_callback,
 753                 .ident = "Intel D425KT",
 754                 .matches = {
 755                         DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
 756                         DMI_EXACT_MATCH(DMI_BOARD_NAME, "D425KT"),
 757                 },
 758         },
 759         {
 760                 .callback = intel_no_lvds_dmi_callback,
 761                 .ident = "Intel D510MO",
 762                 .matches = {
 763                         DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
 764                         DMI_EXACT_MATCH(DMI_BOARD_NAME, "D510MO"),
 765                 },
 766         },
 767         {
 768                 .callback = intel_no_lvds_dmi_callback,
 769                 .ident = "Intel D525MW",
 770                 .matches = {
 771                         DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
 772                         DMI_EXACT_MATCH(DMI_BOARD_NAME, "D525MW"),
 773                 },
 774         },
 775
 776         { }     /* terminating entry */
 777 };
 778
 779 static int intel_dual_link_lvds_callback(const struct dmi_system_id *id)
 780 {
 781         DRM_INFO("Forcing lvds to dual link mode on %s\n", id->ident);
 782         return 1;
 783 }
 784
 785 static const struct dmi_system_id intel_dual_link_lvds[] = {
 786         {
 787                 .callback = intel_dual_link_lvds_callback,
 788                 .ident = "Apple MacBook Pro 15\" (2010)",
 789                 .matches = {
 790                         DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
 791                         DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro6,2"),
 792                 },
 793         },
 794         {
 795                 .callback = intel_dual_link_lvds_callback,
 796                 .ident = "Apple MacBook Pro 15\" (2011)",
 797                 .matches = {
 798                         DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
 799                         DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro8,2"),
 800                 },
 801         },
 802         {
 803                 .callback = intel_dual_link_lvds_callback,
 804                 .ident = "Apple MacBook Pro 15\" (2012)",
 805                 .matches = {
 806                         DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
 807                         DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro9,1"),
 808                 },
 809         },
 810         { }     /* terminating entry */
 811 };
 812
 813 bool intel_is_dual_link_lvds(struct drm_device *dev)
 814 {
 815         struct intel_encoder *encoder;
 816         struct intel_lvds_encoder *lvds_encoder;
 817
 818         for_each_intel_encoder(dev, encoder) {
 819                 if (encoder->type == INTEL_OUTPUT_LVDS) {
 820                         lvds_encoder = to_lvds_encoder(&encoder->base);
 821
 822                         return lvds_encoder->is_dual_link;
 823                 }
 824         }
 825
 826         return false;
 827 }
 828
 829 static bool compute_is_dual_link_lvds(struct intel_lvds_encoder *lvds_encoder)
 830 {
 831         struct drm_device *dev = lvds_encoder->base.base.dev;
 832         unsigned int val;
 833         struct drm_i915_private *dev_priv = dev->dev_private;
 834
 835         /* use the module option value if specified */
 836         if (i915.lvds_channel_mode > 0)
 837                 return i915.lvds_channel_mode == 2;
 838
 839         /* single channel LVDS is limited to 112 MHz */
 840         if (lvds_encoder->attached_connector->base.panel.fixed_mode->clock
 841             > 112999)
 842                 return true;
 843
 844         if (dmi_check_system(intel_dual_link_lvds))
 845                 return true;
 846
 847         /* BIOS should set the proper LVDS register value at boot, but
 848          * in reality, it doesn't set the value when the lid is closed;
 849          * we need to check "the value to be set" in VBT when LVDS
 850          * register is uninitialized.
 851          */
 852         val = I915_READ(lvds_encoder->reg);
 853         if (!(val & ~(LVDS_PIPE_MASK | LVDS_DETECTED)))
 854                 val = dev_priv->vbt.bios_lvds_val;
 855
 856         return (val & LVDS_CLKB_POWER_MASK) == LVDS_CLKB_POWER_UP;
 857 }
 858
 859 static bool intel_lvds_supported(struct drm_device *dev)
 860 {
 861         /* With the introduction of the PCH we gained a dedicated
 862          * LVDS presence pin, use it. */
 863         if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev))
 864                 return true;
 865
 866         /* Otherwise LVDS was only attached to mobile products,
 867          * except for the inglorious 830gm */
 868         if (INTEL_INFO(dev)->gen <= 4 && IS_MOBILE(dev) && !IS_I830(dev))
 869                 return true;
 870
 871         return false;
 872 }
 873
 874 /**
 875  * intel_lvds_init - setup LVDS connectors on this device
 876  * @dev: drm device
 877  *
 878  * Create the connector, register the LVDS DDC bus, and try to figure out what
 879  * modes we can display on the LVDS panel (if present).
 880  */
 881 void intel_lvds_init(struct drm_device *dev)
 882 {
 883         struct drm_i915_private *dev_priv = dev->dev_private;
 884         struct intel_lvds_encoder *lvds_encoder;
 885         struct intel_encoder *intel_encoder;
 886         struct intel_lvds_connector *lvds_connector;
 887         struct intel_connector *intel_connector;
 888         struct drm_connector *connector;
 889         struct drm_encoder *encoder;
 890         struct drm_display_mode *scan; /* *modes, *bios_mode; */
 891         struct drm_display_mode *fixed_mode = NULL;
 892         struct drm_display_mode *downclock_mode = NULL;
 893         struct edid *edid;
 894         struct drm_crtc *crtc;
 895         i915_reg_t lvds_reg;
 896         u32 lvds;
 897         int pipe;
 898         u8 pin;
 899
 900         /*
 901          * Unlock registers and just leave them unlocked. Do this before
 902          * checking quirk lists to avoid bogus WARNINGs.
 903          */
 904         if (HAS_PCH_SPLIT(dev)) {
 905                 I915_WRITE(PCH_PP_CONTROL,
 906                            I915_READ(PCH_PP_CONTROL) | PANEL_UNLOCK_REGS);
 907         } else if (INTEL_INFO(dev_priv)->gen < 5) {
 908                 I915_WRITE(PP_CONTROL,
 909                            I915_READ(PP_CONTROL) | PANEL_UNLOCK_REGS);
 910         }
 911         if (!intel_lvds_supported(dev))
 912                 return;
 913
 914         /* Skip init on machines we know falsely report LVDS */
 915         if (dmi_check_system(intel_no_lvds))
 916                 return;
 917
 918         if (HAS_PCH_SPLIT(dev))
 919                 lvds_reg = PCH_LVDS;
 920         else
 921                 lvds_reg = LVDS;
 922
 923         lvds = I915_READ(lvds_reg);
 924
 925         if (HAS_PCH_SPLIT(dev)) {
 926                 if ((lvds & LVDS_DETECTED) == 0)
 927                         return;
 928                 if (dev_priv->vbt.edp.support) {
 929                         DRM_DEBUG_KMS("disable LVDS for eDP support\n");
 930                         return;
 931                 }
 932         }
 933
 934         pin = GMBUS_PIN_PANEL;
 935         if (!intel_bios_is_lvds_present(dev_priv, &pin)) {
 936                 if ((lvds & LVDS_PORT_EN) == 0) {
 937                         DRM_DEBUG_KMS("LVDS is not present in VBT\n");
 938                         return;
 939                 }
 940                 DRM_DEBUG_KMS("LVDS is not present in VBT, but enabled anyway\n");
 941         }
 942
 943          /* Set the Panel Power On/Off timings if uninitialized. */
 944         if (INTEL_INFO(dev_priv)->gen < 5 &&
 945             I915_READ(PP_ON_DELAYS) == 0 && I915_READ(PP_OFF_DELAYS) == 0) {
 946                 /* Set T2 to 40ms and T5 to 200ms */
 947                 I915_WRITE(PP_ON_DELAYS, 0x019007d0);
 948
 949                 /* Set T3 to 35ms and Tx to 200ms */
 950                 I915_WRITE(PP_OFF_DELAYS, 0x015e07d0);
 951
 952                 DRM_DEBUG_KMS("Panel power timings uninitialized, setting defaults\n");
 953         }
 954
 955         lvds_encoder = kzalloc(sizeof(*lvds_encoder), GFP_KERNEL);
 956         if (!lvds_encoder)
 957                 return;
 958
 959         lvds_connector = kzalloc(sizeof(*lvds_connector), GFP_KERNEL);
 960         if (!lvds_connector) {
 961                 kfree(lvds_encoder);
 962                 return;
 963         }
 964
 965         if (intel_connector_init(&lvds_connector->base) < 0) {
 966                 kfree(lvds_connector);
 967                 kfree(lvds_encoder);
 968                 return;
 969         }
 970
 971         lvds_encoder->attached_connector = lvds_connector;
 972
 973         intel_encoder = &lvds_encoder->base;
 974         encoder = &intel_encoder->base;
 975         intel_connector = &lvds_connector->base;
 976         connector = &intel_connector->base;
 977         drm_connector_init(dev, &intel_connector->base, &intel_lvds_connector_funcs,
 978                            DRM_MODE_CONNECTOR_LVDS);
 979
 980         drm_encoder_init(dev, &intel_encoder->base, &intel_lvds_enc_funcs,
 981                          DRM_MODE_ENCODER_LVDS, NULL);
 982
 983         intel_encoder->enable = intel_enable_lvds;
 984         intel_encoder->pre_enable = intel_pre_enable_lvds;
 985         intel_encoder->compute_config = intel_lvds_compute_config;
 986         if (HAS_PCH_SPLIT(dev_priv)) {
 987                 intel_encoder->disable = pch_disable_lvds;
 988                 intel_encoder->post_disable = pch_post_disable_lvds;
 989         } else {
 990                 intel_encoder->disable = gmch_disable_lvds;
 991         }
 992         intel_encoder->get_hw_state = intel_lvds_get_hw_state;
 993         intel_encoder->get_config = intel_lvds_get_config;
 994         intel_connector->get_hw_state = intel_connector_get_hw_state;
 995         intel_connector->unregister = intel_connector_unregister;
 996
 997         intel_connector_attach_encoder(intel_connector, intel_encoder);
 998         intel_encoder->type = INTEL_OUTPUT_LVDS;
 999
1000         intel_encoder->cloneable = 0;
1001         if (HAS_PCH_SPLIT(dev))
1002                 intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
1003         else if (IS_GEN4(dev))
1004                 intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
1005         else
1006                 intel_encoder->crtc_mask = (1 << 1);
1007
1008         drm_connector_helper_add(connector, &intel_lvds_connector_helper_funcs);
1009         connector->display_info.subpixel_order = SubPixelHorizontalRGB;
1010         connector->interlace_allowed = false;
1011         connector->doublescan_allowed = false;
1012
1013         lvds_encoder->reg = lvds_reg;
1014
1015         /* create the scaling mode property */
1016         drm_mode_create_scaling_mode_property(dev);
1017         drm_object_attach_property(&connector->base,
1018                                       dev->mode_config.scaling_mode_property,
1019                                       DRM_MODE_SCALE_ASPECT);
1020         intel_connector->panel.fitting_mode = DRM_MODE_SCALE_ASPECT;
1021         /*
1022          * LVDS discovery:
1023          * 1) check for EDID on DDC
1024          * 2) check for VBT data
1025          * 3) check to see if LVDS is already on
1026          *    if none of the above, no panel
1027          * 4) make sure lid is open
1028          *    if closed, act like it's not there for now
1029          */
1030
1031         /*
1032          * Attempt to get the fixed panel mode from DDC.  Assume that the
1033          * preferred mode is the right one.
1034          */
1035         mutex_lock(&dev->mode_config.mutex);
1036         if (vga_switcheroo_handler_flags() & VGA_SWITCHEROO_CAN_SWITCH_DDC)
1037                 edid = drm_get_edid_switcheroo(connector,
1038                                     intel_gmbus_get_adapter(dev_priv, pin));
1039         else
1040                 edid = drm_get_edid(connector,
1041                                     intel_gmbus_get_adapter(dev_priv, pin));
1042         if (edid) {
1043                 if (drm_add_edid_modes(connector, edid)) {
1044                         drm_mode_connector_update_edid_property(connector,
1045                                                                 edid);
1046                 } else {
1047                         kfree(edid);
1048                         edid = ERR_PTR(-EINVAL);
1049                 }
1050         } else {
1051                 edid = ERR_PTR(-ENOENT);
1052         }
1053         lvds_connector->base.edid = edid;
1054
1055         if (IS_ERR_OR_NULL(edid)) {
1056                 /* Didn't get an EDID, so
1057                  * Set wide sync ranges so we get all modes
1058                  * handed to valid_mode for checking
1059                  */
1060                 connector->display_info.min_vfreq = 0;
1061                 connector->display_info.max_vfreq = 200;
1062                 connector->display_info.min_hfreq = 0;
1063                 connector->display_info.max_hfreq = 200;
1064         }
1065
1066         list_for_each_entry(scan, &connector->probed_modes, head) {
1067                 if (scan->type & DRM_MODE_TYPE_PREFERRED) {
1068                         DRM_DEBUG_KMS("using preferred mode from EDID: ");
1069                         drm_mode_debug_printmodeline(scan);
1070
1071                         fixed_mode = drm_mode_duplicate(dev, scan);
1072                         if (fixed_mode)
1073                                 goto out;
1074                 }
1075         }
1076
1077         /* Failed to get EDID, what about VBT? */
1078         if (dev_priv->vbt.lfp_lvds_vbt_mode) {
1079                 DRM_DEBUG_KMS("using mode from VBT: ");
1080                 drm_mode_debug_printmodeline(dev_priv->vbt.lfp_lvds_vbt_mode);
1081
1082                 fixed_mode = drm_mode_duplicate(dev, dev_priv->vbt.lfp_lvds_vbt_mode);
1083                 if (fixed_mode) {
1084                         fixed_mode->type |= DRM_MODE_TYPE_PREFERRED;
1085                         connector->display_info.width_mm = fixed_mode->width_mm;
1086                         connector->display_info.height_mm = fixed_mode->height_mm;
1087                         goto out;
1088                 }
1089         }
1090
1091         /*
1092          * If we didn't get EDID, try checking if the panel is already turned
1093          * on.  If so, assume that whatever is currently programmed is the
1094          * correct mode.
1095          */
1096
1097         /* Ironlake: FIXME if still fail, not try pipe mode now */
1098         if (HAS_PCH_SPLIT(dev))
1099                 goto failed;
1100
1101         pipe = (lvds & LVDS_PIPEB_SELECT) ? 1 : 0;
1102         crtc = intel_get_crtc_for_pipe(dev, pipe);
1103
1104         if (crtc && (lvds & LVDS_PORT_EN)) {
1105                 fixed_mode = intel_crtc_mode_get(dev, crtc);
1106                 if (fixed_mode) {
1107                         DRM_DEBUG_KMS("using current (BIOS) mode: ");
1108                         drm_mode_debug_printmodeline(fixed_mode);
1109                         fixed_mode->type |= DRM_MODE_TYPE_PREFERRED;
1110                         goto out;
1111                 }
1112         }
1113
1114         /* If we still don't have a mode after all that, give up. */
1115         if (!fixed_mode)
1116                 goto failed;
1117
1118 out:
1119         mutex_unlock(&dev->mode_config.mutex);
1120
1121         intel_panel_init(&intel_connector->panel, fixed_mode, downclock_mode);
1122
1123         lvds_encoder->is_dual_link = compute_is_dual_link_lvds(lvds_encoder);
1124         DRM_DEBUG_KMS("detected %s-link lvds configuration\n",
1125                       lvds_encoder->is_dual_link ? "dual" : "single");
1126
1127         lvds_encoder->a3_power = lvds & LVDS_A3_POWER_MASK;
1128
1129         lvds_connector->lid_notifier.notifier_call = intel_lid_notify;
1130         if (acpi_lid_notifier_register(&lvds_connector->lid_notifier)) {
1131                 DRM_DEBUG_KMS("lid notifier registration failed\n");
1132                 lvds_connector->lid_notifier.notifier_call = NULL;
1133         }
1134         drm_connector_register(connector);
1135
1136         intel_panel_setup_backlight(connector, INVALID_PIPE);
1137
1138         return;
1139
1140 failed:
1141         mutex_unlock(&dev->mode_config.mutex);
1142
1143         DRM_DEBUG_KMS("No LVDS modes found, disabling.\n");
1144         drm_connector_cleanup(connector);
1145         drm_encoder_cleanup(encoder);
1146         kfree(lvds_encoder);
1147         kfree(lvds_connector);
1148         return;
1149 }