gdb/ChangeLog

   1 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
   2
   3         PR/24474: Add a function to lookup static variables.
   4         * NEWS: Mention this new function.
   5         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
   6         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
   7         * python/python.c (python_GdbMethods): Add new function.
   8
   9 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
  10
  11         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
  12         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
  13         (objfpy_lookup_static_symbol): New function.
  14         (objfile_object_methods): Add new functions.
  15
  16 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  17
  18         * NEWS: Mention 'set|show print frame-info'.  Mention new
  19         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
  20         backtrace argument.  Mention that python frame filtering code
  21         is now consistent with what 'backtrace' command prints.
  22
  23 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  24
  25         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
  26         comments.
  27         (print_frame_info_auto, print_frame_info_source_line,
  28         print_frame_info_location, print_frame_info_source_and_location,
  29         print_frame_info_location_and_address, print_frame_info_short_location):
  30         New declarations.
  31         (struct frame_print_options): New member print_frame_info.
  32         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
  33         * stack.h (get_user_print_what_frame_info): New declaration.
  34         (frame_show_address): New declaration.
  35         * stack.c (print_frame_arguments_choices): New value 'presence'.
  36         (print_frame_info_auto, print_frame_info_source_line,
  37         print_frame_info_location, print_frame_info_source_and_location,
  38         print_frame_info_location_and_address, print_frame_info_short_location,
  39         print_frame_info_choices, print_frame_info_print_what): New definitions.
  40         (print_frame_args): Only print dots for args if print frame-arguments
  41         is 'presence'.
  42         (frame_print_option_defs): New element for "frame-info".
  43         (get_user_print_what_frame_info): New function.
  44         (frame_show_address): Make non static.  Move comment to stack.h.
  45         (print_frame_info_to_print_what): New function.
  46         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
  47         to decide what to print.
  48         (backtrace_command_1): Handle the new print_frame_arguments_presence
  49         value.
  50         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
  51         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
  52         (py_print_frame): In non-mi mode, use LOCATION as default for
  53         print_what, similarly to frame information printed directly by
  54         backtrace command. Handle frame-info user option in non MI mode.
  55
  56 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  57
  58         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
  59         Add case for debugging 32-bit target on 64-bit host.  Revise
  60         comment.
  61
  62 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  63
  64         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
  65         instead of find_function_entry_range_from_pc.
  66
  67 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  68
  69         * stack.c (find_frame_funname): Remove code which preferred
  70         minsym over symtab sym in "certain pathological cases".
  71
  72         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
  73         parameter.  Change type of "do_demangle" to bool.
  74         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  75         Pass suitable "prefer_sym_over_minsym" flag to
  76         build_address_symbolic().  Don't output "+" for negative offsets.
  77         * printcmd.c (print_address_symbolic): Update invocation of
  78         build_address_symbolic to include a "prefer_sym_over_minsym"
  79         flag.
  80         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
  81         Restrict cases in which use of minimal symbol is preferred to that
  82         of a found symbol.  Update comments.
  83
  84         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
  85         for entry pc when entry pc is out of range for that FDE.
  86
  87         * printcmd.c (print_address_symbolic): Print negative offsets.
  88         (build_address_symbolic): Force signed arithmetic when computing
  89         offset.
  90
  91 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
  92
  93         PR gdb/24839:
  94         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
  95         type.
  96
  97 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
  98
  99         * python/py-objfile.c (add_separate_debug_file): Fix comment about
 100         this function's Python signature.
 101
 102
 103 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
 104
 105         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
 106         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 107         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
 108         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
 109         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
 110
 111
 112 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
 113
 114         * h8300-tdep.c (h8300_register_name_common): New.
 115         h8300_register_name): Use h8300_register_name_common.
 116         (h8300s_register_name): Likewise.
 117         (h8300sx_register_name): Likewise.
 118         (h8300h_register_nam): New.
 119         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 120
 121
 122 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 123
 124         * arm-tdep.c (arm_skip_cmse_entry): New function.
 125         (arm_is_sgstubs_section): New function.
 126         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 127
 128 2019-07-22  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 131         Don't self-assign.
 132
 133 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 134
 135         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 136         type_print.
 137
 138 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 139
 140         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 141         so that GDB doesn't match any msymbols when searching in the
 142         TYPES_DOMAIN.
 143         (print_symbol_info): Print using typedef_print or type_print based
 144         on the type of the symbol.  Add updated FIXME comment moved from...
 145         (_initialize_symtab): ... move and update FIXME comment to above.
 146
 147 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 148
 149         * NEWS: Mention adding -q option to "info types".
 150         * symtab.c (struct info_types_options): New struct.
 151         (info_types_options_defs): New variable.
 152         (make_info_types_options_def_group): New function.
 153         (info_types_command): Use gdb::option framework to parse options.
 154         (info_types_command_completer): New function.
 155         (_initialize_symtab): Extend the help text on "info types" and
 156         register command completer.
 157
 158 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 159
 160         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 161         (lookup_symbol_in_objfile): Change int to block_enum and add a
 162         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 163
 164 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 165
 166         * MAINTAINERS (Write After Approval): Add self.
 167
 168 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 169
 170         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 171         instruction to the dummy code region.
 172
 173 2019-07-19  Tom Tromey  <tromey@adacore.com>
 174
 175         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 176         (ARGSUSED, PARAMS, __func__): Remove rules.
 177
 178 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 179
 180         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 181         * features/arm/arm-with-iwmmxt.c: Remove.
 182         * features/arm/arm-with-iwmmxt.xml: Remove.
 183         * features/arm/arm-with-m-fpa-layout.c: Remove.
 184         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 185         * features/arm/arm-with-m-vfp-d16.c: Remove.
 186         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 187         * features/arm/arm-with-m.c: Remove.
 188         * features/arm/arm-with-m.xml: Remove.
 189         * features/arm/arm-with-neon.c: Remove.
 190         * features/arm/arm-with-neon.xml: Remove.
 191         * features/arm/arm-with-vfpv2.c: Remove.
 192         * features/arm/arm-with-vfpv2.xml: Remove.
 193         * features/arm/arm-with-vfpv3.c: Remove.
 194         * features/arm/arm-with-vfpv3.xml: Remove.
 195
 196 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 197
 198         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 199
 200 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 201
 202         * arch/aarch32.c (aarch32_create_target_description): Create
 203         target descriptions using features.
 204         * arch/arm.c (arm_create_target_description)
 205         (arm_create_mprofile_target_description): Likewise.
 206         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 207
 208 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 209
 210         * Makefile.in: Add new files.
 211         * aarch32-tdep.c: New file.
 212         * aarch32-tdep.h: New file.
 213         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 214         Call aarch32_read_description.
 215         * arch/aarch32.c: New file.
 216         * arch/aarch32.h: New file.
 217         * arch/arm.c (arm_create_target_description)
 218         (arm_create_mprofile_target_description): New function.
 219         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 220         (arm_create_target_description)
 221         (arm_create_mprofile_target_description): New declaration.
 222         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 223         read_description functions.
 224         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 225         Likewise.
 226         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 227         * arm-tdep.c (tdesc_arm_list): New variable.
 228         (arm_register_g_packet_guesses): Call create description functions.
 229         (arm_read_description) (arm_read_mprofile_description): New
 230         function.
 231         * arm-tdep.h (arm_read_description)
 232         (arm_read_mprofile_description): Add declaration.
 233         * configure.tgt: Add new files.
 234
 235 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 236
 237         * top.c (new_ui_command): Open specified terminal just once.
 238
 239 2019-07-18  Tom Tromey  <tromey@adacore.com>
 240
 241         * symtab.c (main_name): Constify return type.
 242         * symfile.c (set_initial_language): Update.
 243         * symtab.h (main_name): Constify return type.
 244
 245 2019-07-17  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-winsource.c (tui_update_source_window)
 248         (tui_update_source_window_as_is)
 249         (tui_update_source_windows_with_line): Remove return.
 250         * tui/tui-disasm.c (tui_show_disassem)
 251         (tui_show_disassem_and_update_source): Remove return.
 252         * tui/tui.c (tui_reset): Remove return.
 253         * tui/tui-wingeneral.c
 254         (tui_check_and_display_highlight_if_needed): Remove return.
 255
 256 2019-07-17  Tom Tromey  <tom@tromey.com>
 257
 258         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 259
 260 2019-07-17  Tom Tromey  <tom@tromey.com>
 261
 262         * tui/tui-winsource.h (struct tui_exec_info_window)
 263         (struct tui_source_window_base): Move from tui-data.h.
 264         * tui/tui-winsource.c: Move many method definitions from
 265         elsewhere.  Remove "structuring" comments.
 266         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 267         (tui_source_window_base::refresh_window): Move to
 268         tui-winsource.c.
 269         * tui/tui-win.c (tui_source_window_base::refresh_all)
 270         (tui_source_window_base::update_tab_width)
 271         (tui_source_window_base::set_new_height)
 272         (tui_source_window_base::do_make_visible_with_new_height): Move to
 273         tui-winsource.c.
 274         * tui/tui-source.h: Update.
 275         * tui/tui-source.c (tui_source_window_base::reset): Move to
 276         tui-winsource.c.
 277         * tui/tui-disasm.h: Update.
 278         * tui/tui-data.h (struct tui_exec_info_window): Move to
 279         tui-winsource.h.
 280         (struct tui_source_window_base): Likewise.
 281         * tui/tui-data.c (tui_source_window_base::clear_detail)
 282         (tui_source_window_base, ~tui_source_window_base): Move to
 283         tui-winsource.c.
 284
 285 2019-07-17  Tom Tromey  <tom@tromey.com>
 286
 287         * tui/tui-win.c (tui_resize_all)
 288         (tui_source_window_base::update_tab_width)
 289         (tui_adjust_win_heights): Update.
 290         (tui_win_info::make_invisible_and_set_new_height): Rename from
 291         make_invisible_and_set_new_height.
 292         * tui/tui-data.h (struct tui_win_info)
 293         <make_invisible_and_set_new_height>: New method.
 294
 295 2019-07-17  Tom Tromey  <tom@tromey.com>
 296
 297         * tui/tui.c: Update.
 298         * tui/tui-source.h (struct tui_source_window): Move from
 299         tui-data.h.
 300         * tui/tui-layout.c: Update.
 301         * tui/tui-disasm.c: Update.
 302         * tui/tui-data.h (struct tui_source_window): Move to
 303         tui-source.h.
 304
 305 2019-07-17  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 308         tui-data.h.
 309         * tui/tui-data.h (struct tui_disasm_window): Move to
 310         tui-disasm.h.
 311
 312 2019-07-17  Tom Tromey  <tom@tromey.com>
 313
 314         * tui/tui-regs.h (struct tui_data_item_window): Move from
 315         tui-data.h.
 316         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 317         * tui/tui-data.h (struct tui_data_item_window): Move to
 318         tui-regs.h.
 319         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 320
 321 2019-07-17  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui.c: Update.
 324         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 325         (tui_cmd_window::max_height): Move to tui-command.c.
 326         * tui/tui-layout.c: Update.
 327         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 328         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 329         tui-command.c.
 330         * tui/tui-command.h (struct tui_cmd_window): Move from
 331         tui-data.h.
 332         * tui/tui-command.c: Remove "structuring" comments.
 333         (tui_cmd_window::clear_detail)
 334         (tui_cmd_window::do_make_visible_with_new_height)
 335         (tui_cmd_window::max_height): Move from elsewhere.
 336
 337 2019-07-17  Tom Tromey  <tom@tromey.com>
 338
 339         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 340         Now static.
 341         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 342         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 343
 344 2019-07-17  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui.c: Update.
 347         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 348         tui-regs.c.
 349         * tui/tui-windata.h: Remove file.
 350         * tui/tui-windata.c: Remove file.
 351         * tui/tui-win.c (tui_data_window::set_new_height)
 352         (tui_data_window::do_make_visible_with_new_height): Move to
 353         tui-regs.c.
 354         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 355         * tui/tui-regs.c: Remove "structuring" comments.
 356         (tui_data_window::first_data_item_displayed)
 357         (tui_data_window::delete_data_content_windows)
 358         (tui_data_window::erase_data_content)
 359         (tui_data_window::display_all_data)
 360         (tui_data_window::refresh_all)
 361         (tui_data_window::do_scroll_vertical)
 362         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 363         (tui_data_window::do_make_visible_with_new_height)
 364         (tui_data_window::refresh_window): Move from elsewhere.
 365         (_initialize_tui_regs): Move to end of file.
 366         * tui/tui-layout.c: Update.
 367         * tui/tui-hooks.c: Update.
 368         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 369         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 370         tui-regs.c.
 371         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 372
 373 2019-07-17  Tom Tromey  <tom@tromey.com>
 374
 375         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 376         seen.
 377
 378 2019-07-17  Tom Tromey  <tom@tromey.com>
 379
 380         * tui/tui-win.c (tui_source_window_base::set_new_height)
 381         (tui_source_window_base::do_make_visible_with_new_height): Use
 382         m_has_locator field directly.
 383         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 384         method.
 385         (struct tui_source_window_base) <has_locator>: Likewise.
 386
 387 2019-07-17  Tom Tromey  <tom@tromey.com>
 388
 389         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 390         Don't declare.
 391         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 392         Remove.
 393         * tui/tui-win.c (tui_source_window_base::set_new_height)
 394         (tui_source_window_base::set_new_height)
 395         (make_invisible_and_set_new_height)
 396         (tui_source_window_base::do_make_visible_with_new_height)
 397         (tui_source_window_base::do_make_visible_with_new_height):
 398         Update.
 399         * tui/tui-layout.c (show_source_disasm_command, show_data)
 400         (show_source_or_disasm_and_command): Update.
 401         * tui/tui-layout.c (show_layout): Update.
 402
 403 2019-07-17  Tom Tromey  <tom@tromey.com>
 404
 405         * tui/tui-layout.c (make_data_window): Remove.
 406         (show_data): Unify creation and re-initialization cases.
 407
 408 2019-07-17  Tom Tromey  <tom@tromey.com>
 409
 410         * tui/tui-layout.c (make_source_window, make_disasm_window):
 411         Remove.
 412         (show_data): Unify creation and re-initialization cases.
 413
 414 2019-07-17  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui-layout.c (make_command_window): Remove.
 417         (show_source_disasm_command, show_source_or_disasm_and_command):
 418         Unify creation and re-initialization cases.
 419
 420 2019-07-17  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 423         creation and re-initialization cases.
 424
 425 2019-07-17  Tom Tromey  <tom@tromey.com>
 426
 427         * tui/tui-regs.c (tui_get_register): Return void.
 428
 429 2019-07-17  Tom Tromey  <tom@tromey.com>
 430
 431         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 432         Simplify.
 433
 434 2019-07-17  Tom Tromey  <tom@tromey.com>
 435
 436         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 437         resetting.
 438
 439 2019-07-17  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 442         * tui/tui-regs.c (tui_reg_layout): New function.
 443         (tui_show_registers, tui_reg_command): Use it.
 444         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 445         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 446         parameters.
 447         (tui_layout_command): Remove.
 448
 449 2019-07-17  Tom Tromey  <tom@tromey.com>
 450
 451         * tui/tui-layout.h (tui/tui-layout): Return void.
 452         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 453
 454 2019-07-17  Tom Tromey  <tom@tromey.com>
 455
 456         * tui/tui-layout.c (show_source_disasm_command, show_data):
 457         Update.
 458         (reset_locator): Remove.
 459         (show_source_or_disasm_and_command): Update.
 460
 461 2019-07-17  Tom Tromey  <tom@tromey.com>
 462
 463         * tui/tui-source.c (tui_source_window_base::reset): Remove
 464         win_type parameter.
 465         * tui/tui-layout.c (make_command_window, make_source_window)
 466         (make_disasm_window, make_data_window)
 467         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 468         (reset_locator, show_source_or_disasm_and_command): Update.
 469         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 470         win_type parameter.
 471         (struct tui_source_window_base) <reset>: Likewise.
 472
 473 2019-07-17  Tom Tromey  <tom@tromey.com>
 474
 475         * tui/tui-layout.c (show_source_disasm_command): Use
 476         reset_locator.
 477         (reset_locator): New function.
 478         (init_and_make_win): Remove.
 479         (show_source_or_disasm_and_command): Use reset_locator.
 480
 481 2019-07-17  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 484         condition.
 485         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 486         Remove condition.
 487         * tui/tui-source.c (tui_source_window_base::reset): New method.
 488         * tui/tui-layout.c (make_command_window): Don't call
 489         init_and_make_win.
 490         (make_source_window, make_disasm_window): Don't call
 491         make_source_or_disasm_window.
 492         (make_data_window): Don't call init_and_make_win.  Change calling
 493         convention.
 494         (show_source_disasm_command, show_data): Simplify.
 495         (make_source_or_disasm_window): Remove.
 496         (show_source_or_disasm_and_command): Simplify.
 497         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 498         (struct tui_source_window_base) <reset>: Likewise.
 499         <execution_info>: Remove initializer.
 500         * tui/tui-data.c (tui_source_window_base): Initialize
 501         execution_info.
 502
 503 2019-07-17  Tom Tromey  <tom@tromey.com>
 504
 505         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 506         variable.
 507
 508 2019-07-17  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui.c (tui_rl_other_window): Update.
 511         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 512         superclass method first.  Always iterate over regs_content.
 513         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 514         method.
 515         * tui/tui-win.c (tui_set_focus_command): Update.
 516
 517 2019-07-17  Tom Tromey  <tom@tromey.com>
 518
 519         * tui/tui-win.c (tui_set_focus_command): Rename from
 520         tui_set_focus.  Call tui_enable.
 521         (tui_set_focus_command): Remove.
 522
 523 2019-07-17  Tom Tromey  <tom@tromey.com>
 524
 525         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 526         refresh_window.
 527         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 528         touchwin.
 529         (tui_data_window::refresh_window): Call refresh_window on data
 530         items.  Always call superclass refresh_window.
 531         (tui_win_info::refresh): Remove.
 532         (tui_source_window_base::refresh_window): Update.
 533         (tui_refresh_all): Update.
 534         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 535         refresh_window.
 536         (show_source_or_disasm_and_command): Likewise.
 537         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 538         (struct tui_source_window_base) <refresh>: Likewise.
 539
 540 2019-07-17  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui-winsource.c (tui_clear_source_content)
 543         (tui_show_source_content): Update.
 544         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 545         whether content is empty.
 546         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 547         Remove.
 548
 549 2019-07-17  Tom Tromey  <tom@tromey.com>
 550
 551         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 552         window's contents.
 553         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 554         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 555
 556 2019-07-17  Tom Tromey  <tom@tromey.com>
 557
 558         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 559         (struct tui_data_item_window): Update.
 560
 561 2019-07-17  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 564         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 565         defines.
 566
 567 2019-07-17  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-winsource.h (tui_erase_source_content)
 570         (tui_clear_source_content): Remove "display_prompt" parameter.
 571         * tui/tui-winsource.c (tui_update_source_window_as_is)
 572         (tui_update_source_windows_with_addr): Update.
 573         (tui_clear_source_content): Remove "display_prompt" parameter.
 574         (tui_erase_source_content): Likewise.  Simplify.
 575         (tui_show_source_content): Update.
 576         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 577         * tui/tui-stack.c (tui_show_frame_info): Update.
 578         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 579         Remove defines.
 580
 581 2019-07-17  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 584         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 585         parameter.
 586         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 587         parameter.
 588
 589 2019-07-17  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-winsource.c (tui_clear_source_content)
 592         (tui_show_source_content, tui_show_exec_info_content)
 593         (tui_clear_exec_info_content): Update.
 594         * tui/tui-stack.c (tui_show_locator_content): Update.
 595         (tui_show_frame_info): Update.
 596         * tui/tui-source.h (tui_source_window): Don't declare.
 597         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 598         from tui_source_is_displayed.
 599         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 600         Remove field.
 601         (struct tui_source_window_base) <content_in_use>: New field.  Now
 602         bool.
 603         (struct tui_source_window) <showing_source_p>: New method.
 604         (TUI_SRC_WIN): Change cast.
 605         * tui/tui-data.c (tui_initialize_static_data): Update.
 606
 607 2019-07-17  Tom Tromey  <tom@tromey.com>
 608
 609         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 610         location_matches_p.
 611         * tui/tui-source.c (tui_source_window::location_matches_p): New
 612         method.
 613         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 614         method.
 615         * tui/tui-data.h (struct tui_source_window_base)
 616         <location_matches_p>: New method.
 617         (struct tui_source_window, struct tui_disasm_window)
 618         <location_matches_p>: Likewise.
 619
 620 2019-07-17  Tom Tromey  <tom@tromey.com>
 621
 622         * tui/tui-win.c (tui_set_win_height_command): Rename from
 623         tui_set_win_height.
 624         (tui_set_win_height_command): Remove.
 625
 626 2019-07-17  Tom Tromey  <tom@tromey.com>
 627
 628         * tui/tui-source.c (tui_source_window): New constructor.  Add
 629         observer.
 630         (~tui_source_window): New destructor.
 631         (tui_source_window::style_changed): New method.
 632         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 633         (tui_attach_detach_observers): Update.
 634         * tui/tui-data.h (struct tui_source_window): Make constructor not
 635         inline.  Add destructor.
 636         (struct tui_source_window) <style_changed>: New method.
 637         <m_observable>: New member.
 638
 639 2019-07-17  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 642         * tui/tui-win.c (tui_resize_all): Fix typo.
 643
 644 2019-07-17  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 647         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 648         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 649         * tui/tui-win.c (window_name_completer): Use foreach.
 650         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 651         (update_tab_width): Likewise.
 652         * tui/tui-layout.c (show_layout): Update.
 653         * tui/tui-data.h (class tui_window_iterator): New.
 654         (struct all_tui_windows): New.
 655         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 656
 657 2019-07-17  Tom Tromey  <tom@tromey.com>
 658
 659         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 660         parameter.  Don't reference globals.
 661         (tui_reg_command): Update.
 662
 663 2019-07-17  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-regs.c (tui_show_registers): Simplify.
 666
 667 2019-07-17  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-regs.c (tui_show_registers): Update.
 670         (tui_show_register_group): Add win_info parameter.
 671
 672 2019-07-17  Tom Tromey  <tom@tromey.com>
 673
 674         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 675         Rename from tui_display_reg_element_at_line.
 676         (tui_data_window::display_registers_from_line): Update.
 677         * tui/tui-data.h (struct tui_data_window)
 678         <display_reg_element_at_line>: New method.
 679
 680 2019-07-17  Tom Tromey  <tom@tromey.com>
 681
 682         * tui/tui-regs.h (tui_display_registers_from)
 683         (tui_display_registers_from_line): Don't declare.
 684         * tui/tui-windata.c (tui_data_window::display_all_data)
 685         (tui_data_window::refresh_all)
 686         (tui_data_window::do_scroll_vertical): Update.
 687         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 688         from tui_display_registers_from.
 689         (tui_display_reg_element_at_line): Update.
 690         (tui_data_window::display_registers_from_line): Rename from
 691         tui_display_registers_from_line.
 692         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 693         display_registers_from_line>: New methods.
 694
 695 2019-07-17  Tom Tromey  <tom@tromey.com>
 696
 697         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 698         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 699         from tui_erase_data_content.
 700         (tui_data_window::display_all_data)
 701         (tui_data_window::refresh_all)
 702         (tui_data_window::do_scroll_vertical): Update.
 703         * tui/tui-regs.c (tui_show_registers): Update.
 704         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 705         New method.
 706
 707 2019-07-17  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 710         declare.
 711         * tui/tui-windata.c
 712         (tui_data_window::delete_data_content_windows): Rename from
 713         tui_delete_data_content_windows.
 714         (tui_data_window::display_all_data)
 715         (tui_data_window::do_scroll_vertical): Update.
 716         * tui/tui-data.h (struct tui_data_window)
 717         <delete_data_content_windows>: New method.
 718
 719 2019-07-17  Tom Tromey  <tom@tromey.com>
 720
 721         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 722         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 723
 724 2019-07-17  Tom Tromey  <tom@tromey.com>
 725
 726         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 727         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 728         from tui_display_all_data.
 729         * tui/tui-win.c
 730         (tui_data_window::do_make_visible_with_new_height): Update.
 731         * tui/tui-regs.c (tui_show_registers): Update.
 732         * tui/tui-layout.c (tui_set_layout): Update.
 733         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 734         method.
 735
 736 2019-07-17  Tom Tromey  <tom@tromey.com>
 737
 738         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 739         * tui/tui-windata.c (tui_display_data_from): Remove.
 740         (tui_data_window::refresh_all): Update.
 741
 742 2019-07-17  Tom Tromey  <tom@tromey.com>
 743
 744         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 745         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 746         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 747         tui_display_registers_from_line.
 748         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 749         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 750         "force_display" parameter.
 751
 752 2019-07-17  Tom Tromey  <tom@tromey.com>
 753
 754         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 755         declare.
 756         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 757         Rename from tui_first_reg_element_no_inline.
 758         (tui_display_reg_element_at_line)
 759         (tui_display_registers_from_line): Update.
 760         * tui/tui-data.h (struct tui_data_window)
 761         <first_reg_element_no_inline>: New method.
 762
 763 2019-07-17  Tom Tromey  <tom@tromey.com>
 764
 765         * tui/tui-windata.c (tui_display_data_from)
 766         (tui_data_window::do_scroll_vertical): Update.
 767         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 768         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 769         Rename from tui_line_from_reg_element_no.
 770         (tui_display_registers_from_line): Update.
 771         * tui/tui-data.h (struct tui_data_window)
 772         <line_from_reg_element_no>: New method.
 773
 774 2019-07-17  Tom Tromey  <tom@tromey.com>
 775
 776         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 777         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 778         tui_last_regs_line_no.
 779         (tui_display_reg_element_at_line)
 780         (tui_display_registers_from_line): Update.
 781         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 782         method.
 783
 784 2019-07-17  Tom Tromey  <tom@tromey.com>
 785
 786         PR tui/24722:
 787         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 788         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 789         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 790         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 791         (tui_update_breakpoint_info): Likewise.
 792         * tui/tui-hooks.c (tui_event_create_breakpoint)
 793         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 794         Update.
 795
 796 2019-07-17  Tom Tromey  <tom@tromey.com>
 797
 798         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 799
 800 2019-07-17  Tom Tromey  <tom@tromey.com>
 801
 802         * tui/tui-winsource.c (tui_update_source_window_as_is)
 803         (tui_update_source_windows_with_addr): Update.
 804         * tui/tui-source.h (tui_set_source_content)
 805         (tui_show_symtab_source): Add "win_info" parameter.
 806         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 807         parameter.
 808         (tui_show_symtab_source): Likewise.
 809
 810 2019-07-17  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui-wingeneral.c
 813         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 814
 815 2019-07-17  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 818         (struct tui_cmd_window) <can_scroll>: New method.
 819         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 820         method.
 821
 822 2019-07-17  Tom Tromey  <tromey@adacore.com>
 823
 824         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 825         do_field_signed>: Rename.  Change type of "value".
 826         * ui-out.c (ui_out::field_signed): Rename from field_int.
 827         Change type of "value".
 828         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 829         type of "value".
 830         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 831         do_field_int.  Change type of "value".
 832         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 833         do_field_int.  Change type of "value".
 834         * tracepoint.c (trace_status_mi, tfind_1)
 835         (print_one_static_tracepoint_marker): Update.
 836         * thread.c (print_thread_info_1, print_selected_thread_frame):
 837         Update.
 838         * stack.c (print_frame, print_frame_info): Update.
 839         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 840         Update.
 841         * source.c (print_source_lines_base): Update.
 842         * skip.c (info_skip_command): Update.
 843         * record-btrace.c (btrace_ui_out_decode_error)
 844         (btrace_call_history_src_line): Update.
 845         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 846         Update.
 847         * progspace.c (print_program_space): Update.
 848         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 849         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 850         do_field_int.  Change type of "value".
 851         * mi/mi-out.c (mi_ui_out::do_table_begin)
 852         (mi_ui_out::do_table_header): Update.
 853         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 854         type of "value".
 855         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 856         (mi_cmd_data_list_changed_registers, output_register)
 857         (mi_cmd_data_read_memory, mi_load_progress)
 858         (mi_cmd_trace_frame_collected): Update.
 859         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 860         Update.
 861         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 862         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 863         (mi_cmd_var_list_children, varobj_update_one): Update.
 864         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 865         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 866         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 867         * inferior.c (print_inferior): Update.
 868         * gdb_bfd.c (print_one_bfd): Update.
 869         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 870         Update.
 871         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 872         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 873         do_field_int.  Change type of "value".
 874         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 875         do_field_int.  Change type of "value".
 876         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 877         (print_one_breakpoint_location, print_it_catch_fork)
 878         (print_one_catch_fork, print_it_catch_vfork)
 879         (print_one_catch_vfork, print_it_catch_solib)
 880         (print_it_catch_exec, print_it_ranged_breakpoint)
 881         (print_mention_watchpoint, print_mention_masked_watchpoint)
 882         (bkpt_print_it, update_static_tracepoint): Update.
 883         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 884         * break-catch-syscall.c (print_it_catch_syscall): Update.
 885         * ada-tasks.c (print_ada_task_info): Update.
 886         * ada-lang.c (print_it_exception, print_mention_exception):
 887         Update.
 888
 889 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 890
 891         PR breakpoints/24541
 892         * gdbarch.c: Regenerate.
 893         * gdbarch.h: Regenerate.
 894         * gdbarch.sh: Adjust return type and parameter types for
 895         'stap_adjust_register'.
 896         (i386_stap_adjust_register): Adjust signature and return new
 897         register name.
 898         * stap-probe.c (stap_parse_register_operand): Adjust use of
 899         'gdbarch_stap_adjust_register'.
 900
 901 2019-07-17  Tom Tromey  <tromey@adacore.com>
 902
 903         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 904         declare VEC.
 905         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 906         std::vector.
 907         (struct s390_process_info): Add initializers.
 908         (s390_add_process): Use new.
 909         (s390_linux_nat_target::low_forget_process): Use delete.
 910         (s390_linux_nat_target::low_new_fork)
 911         (s390_linux_nat_target::stopped_by_watchpoint)
 912         (s390_linux_nat_target::low_prepare_to_resume)
 913         (s390_linux_nat_target::insert_watchpoint)
 914         (s390_linux_nat_target::insert_hw_breakpoint)
 915         (s390_linux_nat_target::remove_watchpoint)
 916         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 917
 918 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 919
 920         * aarch64-fbsd-nat.c: Include regcache.h.
 921         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 922         argument.
 923         (aarch64_fbsd_nat_target::fetch_registers)
 924         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 925         variable.
 926         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 927
 928 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 929
 930         * fbsd-nat.c: Include gdbarch.h.
 931
 932 2019-07-15  Tom Tromey  <tromey@adacore.com>
 933
 934         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 935
 936 2019-07-15  Tom Tromey  <tromey@adacore.com>
 937
 938         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 939         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 940         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 941         * cli-out.c (cli_ui_out::do_field_int): New method.
 942         * ui-out.c (ui_out::field_unsigned): New method.
 943         * symfile.c (generic_load): Use field_unsigned.
 944         (print_transfer_performance): Likewise.
 945         * record-btrace.c (ui_out_field_uint): Remove.
 946         (btrace_call_history_insn_range, btrace_call_history): Use
 947         field_unsigned.
 948         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 949         field_unsigned.
 950         * ui-out.h (class ui_out) <field_unsigned>: New method.
 951         <do_field_unsigned>: Likewise.
 952
 953 2019-07-15  Tom Tromey  <tromey@adacore.com>
 954
 955         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 956         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 957         * target.c (flash_erase_command): Use field_string.
 958         * infrun.c (print_signal_received_reason): Use field_string.
 959         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 960         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 961         field_string.
 962         * ada-tasks.c (print_ada_task_info): Use field_string.
 963
 964 2019-07-15  Tom Tromey  <tromey@adacore.com>
 965
 966         * target.c (flash_erase_command): Use field_core_addr.
 967         * symfile.c (generic_load): Use field_core_addr.
 968         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 969         Use field_core_addr.
 970         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 971         field_core_addr.
 972
 973 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 974
 975         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 976         value if its desired type is smaller than a CORE_ADDR and signed.
 977
 978 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 979
 980         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 981         of changes to field names, and use new is_reference field to
 982         decide if a property is a reference or not.
 983         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 984         field.
 985         (struct dwarf2_property_baton): Update header comment, rename
 986         'referenced_type' to 'property_type' and update comments.
 987         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 988         default property type, store in property baton, update to take
 989         accound of renamed field.
 990         (read_func_scope): Update call to attr_to_dynamic_prop.
 991         (read_array_type): Likewise.
 992         (dwarf2_per_cu_addr_sized_int_type): New function.
 993         (read_subrange_index_type): Move type finding code to
 994         dwarf2_per_cu_addr_sized_int_type.
 995         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 996         (dwarf2_per_cu_addr_type): New function.
 997         (set_die_type): Update calls to attr_to_dynamic_prop.
 998
 999 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1000
1001         * dwarf2read.c (read_subrange_index_type): New function.
1002         (read_subrange_type): Move code into new function and call it.
1003         * gdbtypes.c (create_range_type): Add some asserts.
1004
1005 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1006
1007         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
1008         update return statements.
1009         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
1010         declaration, and update comment to match.
1011         * gdbtypes.c (resolve_dynamic_array): Update call to
1012         dwarf2_evaluate_property to match new return type.
1013
1014 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1015
1016         * valarith.c (value_subscripted_rvalue): Change lowerbound
1017         parameter type from int to LONGEST.
1018         * value.h (value_subscripted_rvalue): Likewise in declaration.
1019
1020 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1021
1022         * cli/cli-utils.c (info_print_command_completer): New function.
1023         * cli/cli-utils.h: Add 'completer.h' include, and forward
1024         declaration for 'struct cmd_list_element'.
1025         (info_print_command_completer): Declare.
1026         * stack.c (_initialize_stack): Add completer for 'info locals' and
1027         'info args'.
1028         * symtab.c (_initialize_symtab): Add completer for 'info
1029         variables' and 'info functions'.
1030         * NEWS: Mention completion for additional info commands.
1031
1032 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1033
1034         * cli/cli-utils.c (extract_info_print_args): Delete.
1035         (extract_arg_maybe_quoted): Delete.
1036         (info_print_options_defs): New variable.
1037         (make_info_print_options_def_group): New function.
1038         (extract_info_print_options): Define new function.
1039         * cli/cli-utils.h (extract_info_print_args): Delete.
1040         (struct info_print_options): New structure.
1041         (extract_info_print_options): Declare new function.
1042         * stack.c (info_locals_command): Update to use new
1043         extract_info_print_options, also add a header comment.
1044         (info_args_command): Likewise.
1045         * symtab.c (info_variables_command): Likewise.
1046         (info_functions_command): Likewise.
1047
1048 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1049
1050         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1051         to extract string arguments.
1052         * common/common-utils.c (extract_string_maybe_quoted): New function.
1053         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1054
1055 2019-07-11  Tom Tromey  <tromey@adacore.com>
1056
1057         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1058         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1059         * top.h (gdbinit): Don't declare.
1060         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1061         into...
1062         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1063         * top.c (gdb_init): Don't call init_cli_cmds.
1064         (gdbinit): Remove.
1065         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1066
1067 2019-07-11  Tom Tromey  <tromey@adacore.com>
1068
1069         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1070         after it has been moved.
1071
1072 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1073
1074         * valops.c (value_must_coerce_to_target): Change return type to
1075         bool.
1076         * value.h (value_must_coerce_to_target): Likewise.
1077
1078 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1079
1080         * breakpoint.c (is_hardware_watchpoint): Remove
1081         forward-declaration.
1082         (is_masked_watchpoint): Change return type to bool.
1083         (is_tracepoint): Likewise.
1084         (is_breakpoint): Likewise.
1085         (is_hardware_watchpoint): Likewise.
1086         (is_watchpoint): Likewise.
1087         (is_no_memory_software_watchpoint): Likewise.
1088         (is_catchpoint): Likewise.
1089         (breakpoint_1): Make FILTER parameter's return type bool.
1090         is_masked_watchpoint): Change return type to bool.
1091         (save_breakpoints): Make FILTER parameter's return type bool.
1092         * breakpoint.h (is_breakpoint): Change return type to bool.
1093         (is_watchpoint): Likewise.
1094         (is_catchpoint): Likewise.
1095         (is_tracepoint): Likewise.
1096
1097 2019-07-10  Tom Tromey  <tom@tromey.com>
1098
1099         * defs.h: Don't include gdbarch.h.
1100         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1101         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1102         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1103         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1104         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1105         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1106         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1107         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1108         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1109         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1110         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1111         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1112         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1113         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1114         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1115         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1116         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1117         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1118         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1119         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1120         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1121         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1122         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1123         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1124         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1125         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1126         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1127
1128 2019-07-10  Tom Tromey  <tromey@adacore.com>
1129
1130         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1131         * breakpoint.c (init_ada_exception_breakpoint): Register as
1132         bp_catchpoint.
1133         (print_one_breakpoint_location, print_one_breakpoint): Use
1134         is_ada_exception_catchpoint.
1135         * ada-lang.c (class ada_catchpoint_location): Pass
1136         bp_loc_software_breakpoint to bp_location constructor.
1137         (is_ada_exception_catchpoint): New function.
1138
1139 2019-07-10  Tom Tromey  <tromey@adacore.com>
1140
1141         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1142         VEC.
1143         (struct arm_exidx_entry): New method operator<.
1144         (struct arm_exidx_data) <section_maps>: Change type.
1145         (arm_exidx_data_free): Remove.
1146         (arm_exidx_data_key): Change type.  Move lower.
1147         (arm_exidx_new_objfile): Update.
1148         (arm_compare_exidx_entries): Remove.
1149         (arm_find_exidx_entry, _initialize_arm_tdep)
1150
1151 2019-07-10  Tom Tromey  <tromey@adacore.com>
1152
1153         * solib-spu.c (ocl_program_data_key): Change type.
1154         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1155         Update.
1156
1157 2019-07-10  Tom Tromey  <tromey@adacore.com>
1158
1159         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1160         (struct solib_aix_inferior_data) <library_list>: Change type.
1161         (solib_aix_inferior_data_handle): Change type.
1162         (get_solib_aix_inferior_data): Update.
1163         (solib_aix_free_library_list): Remove.
1164         (library_list_start_library): Update.
1165         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1166         return type.
1167         (solib_aix_get_library_list)
1168         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1169         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1170
1171 2019-07-10  Tom Tromey  <tromey@adacore.com>
1172
1173         * solib-dsbt.c (struct dsbt_info): Add initializers.
1174         (solib_dsbt_pspace_data): Change type.
1175         (dsbt_pspace_data_cleanup): Remove.
1176         (get_dsbt_info, _initialize_dsbt_solib): Update.
1177
1178 2019-07-10  Tom Tromey  <tromey@adacore.com>
1179
1180         * spu-tdep.c (spu_overlay_data): Change type.
1181         (spu_get_overlay_table, spu_overlay_new_objfile)
1182         (_initialize_spu_tdep): Update.
1183
1184 2019-07-10  Tom Tromey  <tromey@adacore.com>
1185
1186         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1187         destructor.
1188         (dbx_objfile_data_key): Change type and declare later.
1189         (DBX_SYMFILE_INFO): Rewrite.
1190         * dbxread.c (dbx_objfile_data_key): Change type.
1191         (dbx_symfile_init): Update.
1192         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1193         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1194         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1195
1196 2019-07-10  Tom Tromey  <tromey@adacore.com>
1197
1198         * jit.c (jit_program_space_key): Change type.  Move lower.
1199         (get_jit_program_space_data): Update.
1200         (jit_program_space_data_cleanup): Remove.
1201         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1202         Update.
1203         (struct jit_program_space_data): Add initializers.
1204
1205 2019-07-10  Tom Tromey  <tromey@adacore.com>
1206
1207         * solib-darwin.c (struct darwin_info): Add initializers.
1208         (solib_darwin_pspace_data): Change type.
1209         (darwin_pspace_data_cleanup): Remove.
1210         (get_darwin_info, _initialize_darwin_solib): Update.
1211
1212 2019-07-10  Tom Tromey  <tromey@adacore.com>
1213
1214         * remote-sim.c (struct sim_inferior_data): Add initializers,
1215         constructor, and destructor.
1216         (sim_inferior_data_key): Change type.  Move lower.
1217         (check_for_duplicate_sim_descriptor): Update.
1218         (get_sim_inferior_data): Use new.  Update.
1219         (~sim_inferior_data_cleanup): Rename from
1220         sim_inferior_data_cleanup.  Simplify.
1221         (gdbsim_close_inferior, simulator_command)
1222         (sim_command_completer, _initialize_remote_sim): Update.
1223         (next_pid, INITIAL_PID): Move earlier.
1224
1225 2019-07-10  Tom Tromey  <tromey@adacore.com>
1226
1227         * python/python-internal.h (create_thread_object): Return
1228         gdbpy_ref.
1229         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1230         * python/py-inferior.c (struct threadlist_entry): Add
1231         constructor.
1232         <thread_obj>: Now a gdbpy_ref.
1233         (thread_to_thread_object): Update.
1234         (add_thread_object): Use new.
1235         (delete_thread_object): Use delete.
1236         (infpy_threads): Update.
1237         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1238         GIL.
1239
1240 2019-07-10  Tom Tromey  <tromey@adacore.com>
1241
1242         * valops.c (value_cast): Specialize error message for Ada.
1243
1244 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1245
1246         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1247
1248 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1249
1250         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1251         bpstat_should_step): Return bool, adjust comments.
1252         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1253         bpstat_should_step): Likewise.
1254
1255 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1256
1257         * features/Makefile: Use feature target descriptions for Arm.
1258         * features/arm/arm-core.c: Generate new file.
1259         * features/arm/arm-fpa.c: Likewise.
1260         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1261         * features/arm/arm-m-profile.c: Likewise.
1262         * features/arm/arm-vfpv2.c: Likewise.
1263         * features/arm/arm-vfpv3.c: Likewise.
1264         * features/arm/xscale-iwmmxt.c: Likewise.
1265         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1266
1267 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1268
1269         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1270         ptrace earlier.
1271
1272 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1273
1274         * features/aarch64-pauth.c: Regenerate.
1275
1276 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1277
1278         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1279         bool.
1280         (bpstat_what): Use false instead of 0.
1281
1282 2019-07-09  Pedro Alves  <palves@redhat.com>
1283
1284         * break-catch-throw.c (is_exception_catchpoint): New.
1285         * breakpoint.c (print_one_breakpoint_location): New parameter
1286         'raw_loc'.  Handle it.  Use
1287         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1288         looking at the breakpoint's type.
1289         (print_one_breakpoint): If handling "maint info breakpoints", also
1290         print locations of exception catchpoints.
1291         * breakpoint.h (is_exception_catchpoint): Declare.
1292
1293 2019-07-09  Pedro Alves  <palves@redhat.com>
1294
1295         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1296         "addr" field.
1297         (allocate_location_exception_catchpoint): New.
1298         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1299         (initialize_throw_catchpoint_ops): Install
1300         allocate_location_exception_catchpoint as allocate_location
1301         method.
1302         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1303         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1304         bp_loc_other.
1305         (breakpoint_address_is_meaningful): Delete.
1306         (bl_address_is_meaningful): New.
1307         (breakpoint_locations_match): Adjust comment.
1308         (bp_location_from_bp_type): New, factored out of...
1309         (bp_location::bp_location(breakpoint *)): ... this.
1310         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1311         factored out of...
1312         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1313         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1314         breakpoint_address_is_meaningful.
1315         (bp_locations_compare): Adjust comment.
1316         (update_global_location_list): Use bl_address_is_meaningful
1317         instead of breakpoint_address_is_meaningful.
1318         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1319         explicit.
1320         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1321         * python/py-breakpoint.c (bppy_get_location): No longer check
1322         whether location is null.
1323
1324 2019-07-09  Pedro Alves  <palves@redhat.com>
1325
1326         PR c++/15468
1327         * breakpoint.c (print_one_breakpoint_location): Remove
1328         single-location assert.
1329
1330 2019-07-09  Tom Tromey  <tom@tromey.com>
1331
1332         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1333         * configure: Rebuild.
1334         * configure.ac: Change common to gdbsupport.
1335         * gdbsupport: Rename from common.
1336         * acinclude.m4: Change common to gdbsupport.
1337         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1338         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1339         gdbsupport.
1340         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1341         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1342         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1343         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1344         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1345         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1346         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1347         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1348         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1349         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1350         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1351         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1352         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1353         coff-pe-read.c, command.h, compile/compile-c-support.c,
1354         compile/compile-c.h, compile/compile-cplus-symbols.c,
1355         compile/compile-cplus-types.c, compile/compile-cplus.h,
1356         compile/compile-loc2c.c, compile/compile.c, completer.c,
1357         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1358         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1359         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1360         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1361         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1362         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1363         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1364         features/aarch64-core.c, features/aarch64-fpu.c,
1365         features/aarch64-pauth.c, features/aarch64-sve.c,
1366         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1367         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1368         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1369         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1370         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1371         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1372         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1373         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1374         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1375         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1376         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1377         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1378         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1379         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1380         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1381         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1382         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1383         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1384         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1385         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1386         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1387         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1388         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1389         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1390         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1391         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1392         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1393         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1394         minsyms.c, mips-linux-tdep.c, namespace.h,
1395         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1396         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1397         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1398         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1399         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1400         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1401         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1402         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1403         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1404         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1405         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1406         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1407         procfs.c, producer.c, progspace.h, psymtab.h,
1408         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1409         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1410         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1411         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1412         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1413         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1414         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1415         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1416         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1417         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1418         target-memory.c, target.c, target.h, target/waitstatus.c,
1419         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1420         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1421         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1422         unittests/array-view-selftests.c,
1423         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1424         unittests/common-utils-selftests.c,
1425         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1426         unittests/format_pieces-selftests.c,
1427         unittests/function-view-selftests.c,
1428         unittests/lookup_name_info-selftests.c,
1429         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1430         unittests/mkdir-recursive-selftests.c,
1431         unittests/observable-selftests.c,
1432         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1433         unittests/parse-connection-spec-selftests.c,
1434         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1435         unittests/scoped_fd-selftests.c,
1436         unittests/scoped_mmap-selftests.c,
1437         unittests/scoped_restore-selftests.c,
1438         unittests/string_view-selftests.c, unittests/style-selftests.c,
1439         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1440         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1441         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1442         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1443         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1444         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1445
1446 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1447
1448         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1449         bool value.
1450         (decode_digits_ordinary): Set explicit_line field in sal.
1451         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1452         symtab_and_line that was set on an explicit line number in
1453         assembler code.  Do always update the recorded symtab and line if
1454         we do skip the prologue.
1455
1456 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1457
1458         * breakpoint.c (set_breakpoint_location_function): Remove
1459         explicit_loc parameter.
1460         (momentary_breakpoint_from_master): Update call to
1461         set_breakpoint_location_function.
1462         (add_location_to_breakpoint): Likewise.
1463
1464 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1465
1466         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1467         required features based on default bfd type when no specific bfd
1468         is present.
1469
1470 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1471
1472         * NEWS: Mention that GDB printf and eval commands can now print
1473         C-style and Ada-style convenience var strings without
1474         calling the inferior.
1475         * printcmd.c (printf_c_string): Locally print GDB internal var
1476         instead of transiting via the inferior.
1477         (printf_wide_c_string): Likewise.
1478
1479 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1480
1481         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1482
1483 2019-07-04  Tom Tromey  <tom@tromey.com>
1484
1485         PR tui/24724:
1486         * tui/tui-winsource.c (tui_clear_source_content): Update.
1487         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1488         (tui_update_breakpoint_info): Update.
1489         (tui_set_exec_info_content): Update.
1490         * tui/tui-source.c (tui_set_source_content_nil): Update.
1491         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1492         has_break.
1493         * tui/tui-data.h (enum tui_bp_flag): New.
1494         (tui_bp_flags): New enum flags type.
1495         (struct tui_source_element) <break_mode>: Change type.  Rename
1496         from has_break.
1497         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1498         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1499         constants.
1500         * tui/tui-winsource.h: Fix comment.
1501
1502 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1503
1504         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1505         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1506         (store_fpregs_to_thread)
1507         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1508         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1509         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1510         (IWMMXT_REGS_SIZE): Add define.
1511         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1512         (fetch_vfp_regs, store_vfp_regs)
1513         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1514         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1515
1516 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1517
1518         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1519         defines.
1520         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1521         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1522         (ARM_INT_REGISTER_SIZE): ...to this.
1523         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1524         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1525         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1526         (arm_linux_collect_gregset, supply_nwfpe_register)
1527         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1528         defines.
1529         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1530         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1531         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1532         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1533         (arm_return_in_memory, arm_store_return_value)
1534         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1535         (arm_record_ld_st_multiple): Likewise.
1536         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1537         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1538
1539 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1540
1541         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1542         AARCH64_DISPLACED_MODIFIED_INSNS.
1543         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1544         (aarch64_displaced_step_copy_insn): Likewise.
1545         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1546         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1547         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1548         ARM_DISPLACED_MODIFIED_INSNS.
1549         * arm-tdep.c (arm_gdbarch_init): Likewise.
1550         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1551         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1552         (struct arm_displaced_step_closure): Use
1553         ARM_DISPLACED_MODIFIED_INSNS.
1554
1555 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1556
1557         * features/Makefile: Remove unused xml files.
1558         * features/aarch64.xml: Remove.
1559         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1560         * features/i386/amd64-avx-avx512.xml: Remove.
1561         * features/i386/amd64-avx-linux.xml: Remove.
1562         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1563         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1564         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1565         * features/i386/amd64-avx-mpx.xml: Remove.
1566         * features/i386/amd64-avx.xml: Remove.
1567         * features/i386/amd64-linux.xml: Remove.
1568         * features/i386/amd64-mpx-linux.xml: Remove.
1569         * features/i386/amd64-mpx.xml: Remove.
1570         * features/i386/amd64.xml: Remove.
1571         * features/i386/i386-avx-avx512-linux.xml: Remove.
1572         * features/i386/i386-avx-avx512.xml: Remove.
1573         * features/i386/i386-avx-linux.xml: Remove.
1574         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1575         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1576         * features/i386/i386-avx-mpx-linux.xml: Remove.
1577         * features/i386/i386-avx-mpx.xml: Remove.
1578         * features/i386/i386-avx.xml: Remove.
1579         * features/i386/i386-linux.xml: Remove.
1580         * features/i386/i386-mmx-linux.xml: Remove.
1581         * features/i386/i386-mmx.xml: Remove.
1582         * features/i386/i386-mpx-linux.xml: Remove.
1583         * features/i386/i386-mpx.xml: Remove.
1584         * features/i386/i386.xml: Remove.
1585         * features/i386/x32-avx-avx512-linux.xml: Remove.
1586         * features/i386/x32-avx-linux.xml: Remove.
1587         * features/i386/x32-linux.xml: Remove.
1588
1589 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1590
1591         * regformats/aarch64.dat: Remove.
1592         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1593         * regformats/i386/amd64-avx-linux.dat: Remove.
1594         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1595         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1596         * regformats/i386/amd64-linux.dat: Remove.
1597         * regformats/i386/amd64-mpx-linux.dat: Remove.
1598         * regformats/i386/amd64.dat: Remove.
1599         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1600         * regformats/i386/i386-avx-linux.dat: Remove.
1601         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1602         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1603         * regformats/i386/i386-linux.dat: Remove.
1604         * regformats/i386/i386-mmx-linux.dat: Remove.
1605         * regformats/i386/i386-mpx-linux.dat: Remove.
1606         * regformats/i386/i386.dat: Remove.
1607         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1608         * regformats/i386/x32-avx-linux.dat: Remove.
1609         * regformats/i386/x32-linux.dat: Remove.
1610
1611 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1612
1613         * aarch64-tdep.c: Remove xml self tests.
1614         * amd64-linux-tdep.c: Likewise.
1615         * amd64-tdep.c: Likewise.
1616         * i386-linux-tdep.c: Likewise.
1617         * i386-tdep.c: Likewise.
1618
1619 2019-07-03  Pedro Alves  <palves@redhat.com>
1620
1621         PR cli/24732
1622         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1623         (pipe_cmd_option_defs): New.
1624         (make_pipe_cmd_options_def_group): New.
1625         (pipe_command): Use gdb::option::process_options.
1626         (pipe_command_completer): New function.
1627         (_initialize_cli_cmds): Install completer for "pipe" command.
1628
1629 2019-07-03  Pedro Alves  <palves@redhat.com>
1630
1631         * cli/cli-option.c (union option_value) <string>: New field.
1632         (struct option_def_and_value): Add ctor, move ctor, dtor and
1633         use DISABLE_COPY_AND_ASSIGN.
1634         (option_def_and_value::clear_value): New.
1635         (parse_option, save_option_value_in_ctx, get_val_type_str)
1636         (add_setshow_cmds_for_options): Handle var_string.
1637         * cli-option.h (union option_def::var_address) <string>: New
1638         field.
1639         (struct string_option_def): New.
1640         * maint-test-options.c (struct test_options_opts): Add default
1641         ctor and use DISABLE_COPY_AND_ASSIGN.
1642         <string_opt>: New field.
1643         (test_options_opts::~test_options_opts): New.
1644         (test_options_opts::dump): Also dump "-string".
1645         (test_options_option_defs): Install "string.
1646
1647 2019-07-03  Pedro Alves  <palves@redhat.com>
1648
1649         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1650         option_value with a null enumeration.
1651         (complete_options): Save the option values in the context.
1652         (save_option_value_in_ctx): New, factored out from ...
1653         (process_options): ... here.
1654         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1655         of the function.
1656         * maint-test-options.c (test_options_opts::dump): New, factored
1657         out from ...
1658         (maintenance_test_options_command_mode): ... here.
1659         (maintenance_test_options_command_completion_result): Delete.
1660         (maintenance_test_options_command_completion_text): Update
1661         comment.
1662         (maintenance_show_test_options_completion_result): Change
1663         prototype.  Just print
1664         maintenance_test_options_command_completion_text.
1665         (save_completion_result): New.
1666         (maintenance_test_options_completer_mode): Pass options context to
1667         complete_options, and then save a dump.
1668         (_initialize_maint_test_options): Use add_cmd to install "maint
1669         show test-options-completion-result".
1670
1671 2019-07-03  Pedro Alves  <palves@redhat.com>
1672
1673         * NEWS (New commands): Mention "with" and "maint with".
1674         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1675         (with_command, with_command_completer): New.
1676         (pipe_command): Adjust to new repeat_previous
1677         interface.
1678         (_initialize_cli_cmds): Install the "with" command and its "w"
1679         alias.
1680         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1681         declarations.
1682         * cli/cli-setshow.c (parse_cli_var_uinteger)
1683         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1684         argument strings for all var_types.
1685         (get_setshow_command_value_string): New, factored out from ...
1686         (do_show_command): ... this.
1687         * cli/cli-setshow.h: Include <string>.
1688         (get_setshow_command_value_string): Declare.
1689         * command.h (repeat_previous): Now returns const char *.  Adjust
1690         comment.
1691         * maint.c: Include "cli/cli-cmds.h".
1692         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1693         (_initialize_maint_cmds): Register the "maintenance with" command.
1694         * top.c (repeat_previous): Move bits from pipe_command here:
1695         Return the saved command line, if any; error out if there's no
1696         command to relaunch.
1697
1698 2019-07-03  Pedro Alves  <palves@redhat.com>
1699
1700         * NEWS (New commands): Mention "maint set/show test-settings"
1701         instead of "maint test-settings".
1702         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1703         (maintenance_test_settings_set_list): Rename to ...
1704         (maintenance_set_test_settings_list): ... this.
1705         (maintenance_test_settings_show_list): Rename to  ...
1706         (maintenance_show_test_settings_list): ... this.
1707         (maintenance_test_settings_cmd): Delete.
1708         (maintenance_test_settings_set_cmd): ...
1709         (maintenance_set_test_settings_cmd): ... this.
1710         (maintenance_test_settings_show_cmd): ...
1711         (maintenance_show_test_settings_cmd): ... this.
1712         (maintenance_test_settings_show_value_cmd):
1713         (maintenance_show_test_settings_value_cmd): ... this.
1714         (_initialize_maint_test_settings): No longer install the "maint
1715         test-settings" prefix command.  Rename "maint test-settings set"
1716         to "maint set test-settings", and "maint test-settings show" to
1717         "maint show test-settings".  Adjust all subcommands.
1718
1719 2019-07-03  Pedro Alves  <palves@redhat.com>
1720
1721         * maint-test-settings.c: Fix file's intro comment.  Replace all
1722         references to "test-options" with references to "test-settings",
1723         in comments.
1724
1725 2019-07-03  Pedro Alves  <palves@redhat.com>
1726
1727         * maint-test-settings.c (maintenance_test_settings_xxx)
1728         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1729         New.
1730         (maintenance_test_settings_enums): Use them.
1731         (maintenance_test_settings_enum): Default to
1732         maintenance_test_settings_xxx.
1733         (_initialize_maint_test_settings): Initialize
1734         MAINTENANCE_TEST_SETTINGS_FILENAME.
1735
1736 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1737
1738         * breakpoint.h (remove_breakpoints_inf): Change return type to
1739         void, move function documentation here.
1740         * breakpoint.c (remove_breakpoints_inf): Change return type to
1741         void, move function documentation to header.
1742
1743 2019-07-02  Pedro Alves  <palves@redhat.com>
1744
1745         * NEWS (Completion improvements): Mention "info threads".
1746         * thread.c (struct info_threads_opts, info_threads_option_defs)
1747         (make_info_threads_options_def_group): New.
1748         (info_threads_command): Use gdb::option::process_options.
1749         (info_threads_command_completer): New.
1750         (_initialize_thread): Use gdb::option::build_help to build the
1751         help text for "info threads".
1752
1753 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1754
1755         * defs.h (generic_load): Move from here...
1756         * symfile.h (generic_load): ... to here.  Rename name parameter
1757         to args.
1758         * symfile.c (generic_load): Add comment.
1759
1760 2019-07-01  Tom Tromey  <tromey@adacore.com>
1761
1762         * dwarf2read.c
1763         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1764         declaration of without_params.  Fix formatting.
1765
1766 2019-07-01  Tom Tromey  <tromey@adacore.com>
1767
1768         * ada-exp.y (find_primitive_type): Update.
1769         * ada-lang.h (ada_lookup_symbol): Update.
1770         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1771         parameter.
1772         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1773
1774 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1775
1776         PR breakpoints/24541
1777         * gdbarch.c: Regenerate.
1778         * gdbarch.h: Regenerate.
1779         * gdbarch.sh: Add 'stap_adjust_register'.
1780         * i386-tdep.c: Include '<unordered_set>'.
1781         (i386_stap_adjust_register): New function.
1782         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1783         * stap-probe.c (stap_parse_register_operand): Call
1784         'gdbarch_stap_adjust_register'.
1785
1786 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1787
1788         PR python/24742
1789         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1790         * python/python.c (do_start_initialization): Use 'xmalloc'
1791         instead of 'PyMem_Malloc'.
1792
1793 2019-06-28  Tom Tromey  <tromey@adacore.com>
1794
1795         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1796         for Ada.
1797
1798 2019-06-27  Tom Tromey  <tromey@adacore.com>
1799
1800         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1801         objfile_key.
1802         (arm_find_mapping_symbol, arm_record_special_symbol)
1803         (_initialize_arm_tdep): Update.
1804         (arm_objfile_data_free): Remove.
1805
1806 2019-06-27  Tom Tromey  <tromey@adacore.com>
1807
1808         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1809         to cp_print_static_field.
1810
1811 2019-06-26  Tom Tromey  <tromey@adacore.com>
1812
1813         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1814         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1815         declare.
1816
1817 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1818
1819         * features/aarch64-core.c (create_feature_aarch64_core):
1820         Regenerate.
1821         * features/aarch64-core.xml: Add cpsr flags.
1822
1823 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1824
1825         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1826         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1827
1828 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1829
1830         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1831         field.
1832         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1833         use.
1834         (arm_record_special_symbol): Don't insert new symbol in sorted
1835         position, push it at the end.
1836
1837 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1838
1839         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1840         (arm_mapping_symbol_s): Remove.
1841         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1842         (arm_mapping_symbol_vec): New typedef.
1843         (struct arm_per_objfile): Add constructor.
1844         <section_maps>: Change type to
1845         std::unique_ptr<arm_mapping_symbol_vec[]>.
1846         (arm_compare_mapping_symbols): Remove.
1847         (arm_find_mapping_symbol): Adjust to section_maps type change.
1848         (arm_objfile_data_free): Call delete on arm_per_objfile.
1849         (arm_record_special_symbol): Adjust to section_maps type change.
1850         Allocate arm_per_objfile with new.
1851
1852 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1853
1854         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1855         with the command prefix.
1856
1857 2019-06-25  Tom Tromey  <tom@tromey.com>
1858
1859         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1860         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1861
1862 2019-06-25  Tom Tromey  <tom@tromey.com>
1863
1864         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1865         type.
1866         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1867         protected.
1868
1869 2019-06-25  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-winsource.c
1872         (tui_source_window_base::set_is_exec_point_at): Add check against
1873         LOA_ADDRESS.
1874
1875 2019-06-25  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui-source.c (tui_set_source_content): Don't check before
1878         xfree.
1879         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1880
1881 2019-06-25  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-winsource.h (tui_update_source_window_as_is)
1884         (tui_alloc_source_buffer, tui_line_is_displayed)
1885         (tui_addr_is_displayed): Change type of win_info.
1886         * tui/tui-winsource.c (tui_update_source_window_as_is)
1887         (tui_clear_source_content, tui_show_source_line)
1888         (tui_show_source_content, tui_source_window_base::refill)
1889         (tui_source_window_base::set_is_exec_point_at)
1890         (tui_source_window_base::set_is_exec_point_at)
1891         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1892         (tui_alloc_source_buffer, tui_line_is_displayed)
1893         (tui_addr_is_displayed): Change type of win_info.  Update.
1894         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1895         (tui_source_window_base::do_make_visible_with_new_height):
1896         Update.
1897         * tui/tui-source.c (tui_set_source_content)
1898         (tui_set_source_content_nil)
1899         (tui_source_window::do_scroll_vertical): Update.
1900         * tui/tui-layout.c (show_layout): Update.
1901         * tui/tui-disasm.c (tui_set_disassem_content)
1902         (tui_disasm_window::do_scroll_vertical): Update.
1903         * tui/tui-data.h (tui_win_content): Remove.
1904         (struct tui_gen_win_info) <content, content_size>: Remove.
1905         (struct tui_source_element): Add initializers and destructor.
1906         (union tui_which_element, struct tui_win_element): Remove.
1907         (struct tui_source_window_base) <content>: New field.
1908         (struct tui_data_window): Remove destructor.
1909         (tui_alloc_content, tui_free_win_content)
1910         (tui_free_all_source_wins_content): Don't declare.
1911         * tui/tui-data.c (tui_initialize_static_data): Update.
1912         (init_content_element, tui_alloc_content): Remove.
1913         (~tui_gen_win_info): Update.
1914         (~tui_data_window, tui_free_all_source_wins_content)
1915         (tui_free_win_content, free_content, free_content_elements):
1916         Remove.
1917
1918 2019-06-25  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui-winsource.h (tui_clear_source_content)
1921         (tui_erase_source_content, tui_show_source_content): Change type
1922         of win_info.
1923         * tui/tui-winsource.c (tui_clear_source_content)
1924         (tui_erase_source_content, tui_show_source_content): Change type
1925         of win_info.
1926         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1927         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1928         win_info.
1929         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1930         win_info.
1931         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1932
1933 2019-06-25  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-winsource.c (tui_clear_source_content)
1936         (tui_source_window_base::set_is_exec_point_at): Update.
1937         * tui/tui-source.c (tui_set_source_content_nil): Update.
1938         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1939         a bool.
1940         * tui/tui-data.c (init_content_element): Update.
1941
1942 2019-06-25  Tom Tromey  <tom@tromey.com>
1943
1944         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1945         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1946         * tui/tui-layout.c (init_and_make_win): Update.
1947         * tui/tui.h (enum tui_win_type): Update.
1948         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1949         tui_win_is_auxillary.
1950         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1951         tui_win_is_auxillary.
1952
1953 2019-06-25  Tom Tromey  <tom@tromey.com>
1954
1955         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1956         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1957         (tui_delete_data_content_windows, tui_display_all_data)
1958         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1959         Update.
1960         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1961         * tui/tui-regs.c (tui_last_regs_line_no)
1962         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1963         (tui_show_registers): Update.
1964         (tui_show_register_group): Return void.  Update.
1965         (tui_display_registers_from, tui_display_reg_element_at_line)
1966         (tui_display_registers_from_line, tui_check_register_values):
1967         Update.
1968         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1969         member.
1970         (struct tui_data_window) <regs_content>: Now a std::vector.
1971         <regs_content_count>: Remove.
1972         (tui_add_content_elements, tui_free_data_content): Don't declare.
1973         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1974         (init_content_element): Remove DATA_WIN case.  Add assert.
1975         (tui_add_content_elements): Remove.
1976         (tui_data_window): Update.
1977         (tui_free_data_content): Remove.
1978         (free_content_elements): Remove DATA_WIN case.
1979
1980 2019-06-25  Tom Tromey  <tom@tromey.com>
1981
1982         * tui/tui-data.c (tui_data_item_window): Update.
1983         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1984         * tui/tui-windata.c (tui_display_all_data)
1985         (tui_display_data_from_line): Update.
1986         (tui_check_data_values): Remove.
1987         * tui/tui-regs.c (tui_show_register_group)
1988         (tui_display_reg_element_at_line): Update.
1989         * tui/tui-hooks.c (tui_register_changed)
1990         (tui_refresh_frame_and_register_information): Call
1991         tui_check_register_values.
1992         * tui/tui-data.h (struct tui_data_window) <data_content,
1993         data_content_count, data_type>: Remove.
1994         (enum tui_data_type): Remove.
1995
1996         * tui/tui-data.c (tui_data_window::clear_detail)
1997         (~tui_data_window): Update.
1998
1999 2019-06-25  Tom Tromey  <tom@tromey.com>
2000
2001         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
2002         declare.
2003         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
2004         Rename from tui_first_data_item_displayed.  Update.
2005         (tui_data_window::refresh_all)
2006         (tui_data_window::do_scroll_vertical): Update.
2007         * tui/tui-data.h (struct tui_data_window)
2008         <first_data_item_displayed>: Declare new method.
2009
2010 2019-06-25  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-data.h (tui_init_generic_part): Don't declare.
2013         * tui/tui-data.c (tui_init_generic_part): Remove, moving
2014         contents...
2015         (tui_initialize_static_data): ...here.
2016
2017 2019-06-25  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2020         (tui_display_registers_from, tui_check_register_values): Update.
2021         (tui_display_register): Remove win_info parameter; update.
2022         (tui_get_register): Change type of parameters.
2023         * tui/tui-data.h (struct tui_data_element): Remove.
2024         (union tui_which_element) <data>: Remove.
2025         <data_window>: Change type.
2026         (struct tui_data_item_window): New.
2027         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2028         case.  Add assert.
2029         (~tui_data_item_window): New destructor.
2030         (free_content_elements): Remove DATA_ITEM_WIN case.
2031
2032 2019-06-25  Tom Tromey  <tom@tromey.com>
2033
2034         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2035         Remove.
2036
2037 2019-06-25  Tom Tromey  <tom@tromey.com>
2038
2039         * tui/tui-data.h (struct tui_command_element): Remove.
2040         (union tui_which_element) <command>: Remove.
2041         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2042         assert.
2043         (free_content_elements): Remove CMD_WIN case.
2044
2045 2019-06-25  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-layout.c (tui_set_layout): Update.
2048         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2049         * tui/tui-data.c (layout_def): Update.
2050
2051 2019-06-25  Tom Tromey  <tom@tromey.com>
2052
2053         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2054         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2055         (tui_source_window_base::set_new_height): Update.
2056         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2057         Update.
2058         (tui_set_locator_fullname, tui_set_locator_info)
2059         (tui_show_frame_info): Update.
2060         * tui/tui-source.c (tui_set_source_content)
2061         (tui_source_is_displayed): Update.
2062         * tui/tui-layout.c (show_source_disasm_command, show_data)
2063         (show_source_or_disasm_and_command): Update.
2064         * tui/tui-disasm.c (tui_set_disassem_content)
2065         (tui_get_begin_asm_address): Update.
2066         * tui/tui-data.h (struct tui_locator_element): Remove.
2067         (union tui_which_element) <locator>: Remove.
2068         (struct tui_locator_window): New.
2069         (tui_locator_win_info_ptr): Change return type.
2070         * tui/tui-data.c (_locator): Change type.
2071         (tui_locator_win_info_ptr): Change return type.
2072         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2073         (tui_alloc_content): Add assert.
2074
2075 2019-06-25  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-winsource.c
2078         (tui_exec_info_window::maybe_allocate_content): New method.
2079         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2080         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2081         (make_source_or_disasm_window): Add cast.
2082         * tui/tui-data.h (union tui_which_element) <simple_string>:
2083         Remove.
2084         (struct tui_source_info): New.
2085         (struct tui_source_window_base) <execution_info>: Change type.
2086         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2087         case, and add assert.
2088         (tui_alloc_content): Add assert.
2089
2090 2019-06-25  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2093         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2094         * tui/tui-data.c (tui_alloc_win_info): Remove.
2095
2096 2019-06-25  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2099         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2100         can_highlight.
2101
2102 2019-06-25  Tom Tromey  <tom@tromey.com>
2103
2104         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2105         make_visible_with_new_height method.
2106         (tui_win_info::make_visible_with_new_height): New method.
2107         (tui_source_window_base::do_make_visible_with_new_height)
2108         (tui_data_window::do_make_visible_with_new_height)
2109         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2110         (make_visible_with_new_height): Remove.
2111         (tui_resize_all, tui_adjust_win_heights): Use
2112         make_visible_with_new_height method.
2113         * tui/tui-data.h (struct tui_win_info)
2114         <do_make_visible_with_new_height, make_visible_with_new_height>:
2115         New methods.
2116         (struct tui_source_window_base, struct tui_data_window)
2117         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2118         methods.
2119
2120 2019-06-25  Tom Tromey  <tom@tromey.com>
2121
2122         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2123         method.
2124         (update_tab_width): Call update_tab_width method.
2125         * tui/tui-data.h (struct tui_win_info)
2126         (struct tui_source_window_base) <update_tab_width>: New methods.
2127
2128 2019-06-25  Tom Tromey  <tom@tromey.com>
2129
2130         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2131         parameter.
2132         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2133         parameter.
2134         (tui_gen_win_info::make_visible): Update.
2135         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2136         parameter.
2137         * tui/tui-data.h (enum tui_box): New enum.
2138         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2139
2140 2019-06-25  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2143         init_and_make_win for EXEC_INFO_WIN.
2144         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2145         longer inline.
2146         (struct tui_win_info) <~tui_win_info>: Inline.
2147         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2148         Don't declare.
2149         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2150         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2151         Remove.
2152         (tui_initialize_static_data): Update.
2153         (~tui_gen_win_info): Handle more cleanup here.
2154         (~tui_source_window_base): Delete "execution_info".
2155         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2156
2157 2019-06-25  Tom Tromey  <tom@tromey.com>
2158
2159         * tui/tui-layout.c (make_command_window): Don't set
2160         can_highlight.
2161         (show_source_disasm_command): Call the reset method.
2162         (show_data): Don't set can_highlight.  Call the reset method.
2163         (tui_gen_win_info::reset): Rename from init_gen_win_info
2164         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2165         (show_source_or_disasm_and_command): Call the reset method.
2166         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2167         (struct tui_cmd_window): Set can_highlight.
2168
2169 2019-06-25  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2172         from make_visible.
2173         (tui_make_visible, tui_make_invisible): Rewrite.
2174         (tui_win_info::make_visible): Remove.
2175         (tui_source_window_base::make_visible): Update.
2176         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2177         method.  Moved from...
2178         (struct tui_win_info) <make_visible>: ...here.
2179
2180 2019-06-25  Tom Tromey  <tom@tromey.com>
2181
2182         * tui/tui-winsource.c
2183         (tui_source_window_base::do_scroll_horizontal): Remove direction
2184         parameter.
2185         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2186         direction parameter.
2187         * tui/tui-win.c (tui_win_info::forward_scroll)
2188         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2189         (tui_win_info::right_scroll): Update.
2190         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2191         direction parameter.
2192         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2193         direction parameter.
2194         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2195         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2196         Remove direction parameter.
2197         (struct tui_source_window_base, struct tui_source_window)
2198         (struct tui_disasm_window, struct tui_data_window)
2199         (struct tui_cmd_window): Update.
2200
2201 2019-06-25  Tom Tromey  <tom@tromey.com>
2202
2203         * tui/tui-winsource.h (tui_set_exec_info_content)
2204         (tui_show_exec_info_content, tui_erase_exec_info_content)
2205         (tui_clear_exec_info_content, tui_update_exec_info): Change
2206         argument to tui_source_window_base.
2207         * tui/tui-winsource.c (tui_set_exec_info_content)
2208         (tui_show_exec_info_content, tui_erase_exec_info_content)
2209         (tui_clear_exec_info_content, tui_update_exec_info): Change
2210         argument to tui_source_window_base.
2211
2212 2019-06-25  Tom Tromey  <tom@tromey.com>
2213
2214         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2215         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2216
2217 2019-06-25  Tom Tromey  <tom@tromey.com>
2218
2219         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2220         check.
2221
2222 2019-06-25  Tom Tromey  <tom@tromey.com>
2223
2224         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2225         type to void.
2226         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2227         type to void.
2228         * tui/tui-source.c (tui_set_source_content): Update.
2229         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2230
2231 2019-06-25  Tom Tromey  <tom@tromey.com>
2232
2233         * tui/tui-win.c (window_name_completer, tui_set_focus)
2234         (tui_all_windows_info): Use name method.
2235         * tui/tui-data.h (struct tui_gen_win_info)
2236         (struct tui_source_window, struct tui_disasm_window)
2237         (struct tui_data_window, struct tui_cmd_window) <name>: New
2238         method.
2239         (tui_win_name): Don't declare.
2240         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2241         (tui_win_name): Remove.
2242
2243 2019-06-25  Tom Tromey  <tom@tromey.com>
2244
2245         * tui/tui-winsource.h (tui_update_source_window)
2246         (tui_update_source_window_as_is): Change parameter type.
2247         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2248         to be a tui_source_window_base.
2249         (tui_update_source_window_as_is): Likewise.
2250         * tui/tui-win.c (make_visible_with_new_height): Update.
2251
2252 2019-06-25  Tom Tromey  <tom@tromey.com>
2253
2254         * tui/tui-winsource.c (tui_erase_source_content)
2255         (tui_show_source_content, tui_show_exec_info_content)
2256         (tui_erase_exec_info_content): Use refresh_window method.
2257         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2258         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2259         from tui_refresh_win.
2260         (tui_data_window::refresh_window): New method.
2261         (tui_win_info::refresh, tui_source_window_base::refresh)
2262         (tui_refresh_all): Use refresh_window method.
2263         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2264         method.
2265         * tui/tui-regs.c (tui_display_register): Call refresh_window
2266         method.
2267         * tui/tui-layout.c (show_source_disasm_command)
2268         (show_source_or_disasm_and_command): Call refresh_window method.
2269         * tui/tui-data.h (struct tui_gen_win_info)
2270         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2271         New method.
2272
2273 2019-06-25  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui.c (tui_rl_other_window, tui_enable)
2276         (tui_is_window_visible, tui_get_command_dimension): Update.
2277         * tui/tui-winsource.c (tui_update_source_window_as_is)
2278         (tui_clear_source_content, tui_erase_source_content)
2279         (tui_show_source_line, tui_source_window_base::refill)
2280         (tui_source_window_base::do_scroll_horizontal)
2281         (tui_source_window_base::set_is_exec_point_at)
2282         (tui_update_breakpoint_info, tui_set_exec_info_content)
2283         (tui_alloc_source_buffer, tui_line_is_displayed)
2284         (tui_addr_is_displayed): Update.
2285         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2286         (tui_check_and_display_highlight_if_needed)
2287         (tui_win_info::make_visible, tui_win_info::refresh)
2288         (tui_refresh_all): Update.
2289         * tui/tui-windata.c (tui_first_data_item_displayed)
2290         (tui_delete_data_content_windows, tui_erase_data_content)
2291         (tui_display_all_data, tui_data_window::refresh_all)
2292         (tui_check_data_values): Update.
2293         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2294         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2295         (tui_win_info::backward_scroll, tui_refresh_all_win)
2296         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2297         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2298         (tui_source_window_base::set_new_height)
2299         (tui_data_window::set_new_height)
2300         (make_invisible_and_set_new_height)
2301         (make_visible_with_new_height, new_height_ok)
2302         (parse_scrolling_args): Update.
2303         * tui/tui-stack.c (tui_show_frame_info): Update.
2304         * tui/tui-source.c (tui_set_source_content)
2305         (tui_set_source_content_nil, tui_source_is_displayed)
2306         (tui_source_window::do_scroll_vertical): Update.
2307         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2308         (tui_display_registers_from, tui_display_reg_element_at_line)
2309         (tui_check_register_values, tui_reg_command): Update.
2310         * tui/tui-layout.c (tui_default_win_height)
2311         (show_source_disasm_command, show_data, init_and_make_win)
2312         (show_source_or_disasm_and_command): Update.
2313         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2314         (tui_redisplay_readline, tui_mld_flush)
2315         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2316         (tui_getc): Update.
2317         * tui/tui-disasm.c (tui_set_disassem_content)
2318         (tui_disasm_window::do_scroll_vertical): Update.
2319         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2320         Now virtual.
2321         (struct tui_win_info): Derive from tui_gen_win_info.
2322         <~tui_win_info>: Mark as override.
2323         <generic>: Remove member.
2324         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2325         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2326         (~tui_data_window, ~tui_win_info)
2327         (tui_free_all_source_wins_content): Update.
2328         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2329
2330 2019-06-25  Tom Tromey  <tom@tromey.com>
2331
2332         * tui/tui-layout.c (init_and_make_win): Use new.
2333         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2334         destructor, initializers.
2335         (tui_alloc_generic_win_info): Don't declare.
2336         * tui/tui-data.c (_locator): Add argument to constructor.
2337         (source_win, disasm_win): New globals.
2338         (exec_info): Remove.
2339         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2340         Update.
2341         (tui_alloc_generic_win_info): Remove.
2342         (init_content_element): Use new.
2343         (tui_win_info::tui_win_info): Update.
2344         (free_content_elements) <case DATA_WIN>: Use delete.
2345
2346 2019-06-25  Tom Tromey  <tom@tromey.com>
2347
2348         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2349         * tui/tui-windata.c (tui_first_data_item_displayed)
2350         (tui_delete_data_content_windows): Update.
2351         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2352         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2353         (tui_display_registers_from, tui_check_register_values): Update.
2354         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2355         pointer.
2356         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2357         window.
2358         (tui_free_data_content): Update.
2359         (free_content_elements) <case DATA_WIN>: Free the window.
2360
2361 2019-06-25  Tom Tromey  <tom@tromey.com>
2362
2363         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2364         Update.
2365         * tui/tui-layout.c (make_command_window)
2366         (show_source_disasm_command, show_data, init_and_make_win)
2367         (show_source_or_disasm_and_command): Update.
2368         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2369         method.
2370         <can_highight, is_highlighted>: Now bool.
2371         (tui_set_win_highlight): Don't declare.
2372         * tui/tui-data.c (tui_set_win_highlight): Remove.
2373
2374 2019-06-25  Tom Tromey  <tom@tromey.com>
2375
2376         * tui/tui-wingeneral.c (make_visible): Remove check of window
2377         type.
2378
2379 2019-06-25  Tom Tromey  <tom@tromey.com>
2380
2381         * tui/tui-win.c (tui_win_info::max_height)
2382         (tui_cmd_window::max_height): New methods.
2383         (new_height_ok): Call max_height.
2384         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2385         <max_height>: New method.
2386
2387 2019-06-25  Tom Tromey  <tom@tromey.com>
2388
2389         * tui/tui-win.c (tui_source_window_base::set_new_height)
2390         (tui_data_window::set_new_height): New methods.
2391         (make_invisible_and_set_new_height): Call set_new_height method.
2392         * tui/tui-data.h (struct tui_win_info)
2393         (struct tui_source_window_base, struct tui_data_window)
2394         <set_new_height>: New method.
2395
2396 2019-06-25  Tom Tromey  <tom@tromey.com>
2397
2398         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2399         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2400         tui_refresh_data_win.
2401         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2402         method.
2403         (tui_refresh_all_win): Call the refresh_all method.
2404         (tui_set_focus): Likewise.
2405         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2406         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2407         Likewise.
2408
2409 2019-06-25  Tom Tromey  <tom@tromey.com>
2410
2411         * tui/tui-winsource.h (tui_refill_source_window)
2412         (tui_set_is_exec_point_at): Don't declare.
2413         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2414         (tui_source_window_base::refill): Rename from
2415         tui_refill_source_window.
2416         (tui_source_window_base::do_scroll_horizontal): Update.
2417         (tui_source_window_base::set_is_exec_point_at): Rename from
2418         tui_set_is_exec_point_at.
2419         (tui_update_all_breakpoint_info): Update.
2420         * tui/tui-stack.c (tui_show_frame_info): Update.
2421         * tui/tui-layout.c (show_data): Add cast.
2422         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2423         * tui/tui-data.h (struct tui_source_window_base) <refill,
2424         set_is_exec_point_at>: New methods.
2425         (tui_source_windows, tui_add_to_source_windows): Update types.
2426         (tui_add_to_source_windows): Remove redundant declaration.
2427         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2428         (tui_source_windows): Change return type.
2429         (tui_clear_source_windows_detail): Update.
2430         (tui_add_to_source_windows): Change type of parameter.
2431         (tui_free_all_source_wins_content): Update.
2432
2433 2019-06-25  Tom Tromey  <tom@tromey.com>
2434
2435         * tui/tui-wingeneral.c (tui_win_info::refresh)
2436         (tui_source_window_base::refresh): New methods.
2437         (tui_refresh_all): Call the refresh method.
2438         * tui/tui-data.h (struct tui_win_info)
2439         (struct tui_source_window_base) <refresh>: New method.
2440
2441 2019-06-25  Tom Tromey  <tom@tromey.com>
2442
2443         * tui/tui.h (tui_is_window_visible): Return bool.
2444         * tui/tui.c (tui_is_window_visible): Return bool.
2445         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2446         (tui_make_visible, tui_make_invisible)
2447         (tui_win_info::make_visible)
2448         (tui_source_window_base::make_visible, make_all_visible)
2449         (tui_make_all_visible, tui_make_all_invisible): Update.
2450         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2451         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2452         bool.
2453         (struct tui_win_info, struct tui_source_window_base)
2454         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2455         * tui/tui-data.c (tui_init_generic_part): Update.
2456
2457 2019-06-25  Tom Tromey  <tom@tromey.com>
2458
2459         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2460         (tui_source_window_base::make_visible): New methods.
2461         (make_all_visible): Make method call.
2462         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2463         (struct tui_source_window_base, struct tui_cmd_window): Override
2464         make_visible.
2465         (tui_win_is_source_type): Don't declare.
2466         * tui/tui-data.c (tui_win_is_source_type): Remove.
2467
2468 2019-06-25  Tom Tromey  <tom@tromey.com>
2469
2470         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2471         NULL check.
2472
2473 2019-06-25  Tom Tromey  <tom@tromey.com>
2474
2475         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2476         Inline constructor.  Add initializers for members.
2477         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2478         constructors; now inline in class.
2479
2480 2019-06-25  Tom Tromey  <tom@tromey.com>
2481
2482         * tui/tui-regs.c (tui_show_registers): Update.
2483         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2484         bool.
2485         * tui/tui-data.c (tui_data_window::clear_detail)
2486         (tui_data_window): Update.
2487
2488 2019-06-25  Tom Tromey  <tom@tromey.com>
2489
2490         * tui/tui-windata.c (tui_display_all_data)
2491         (tui_display_data_from_line, tui_display_data_from)
2492         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2493         Update.
2494         * tui/tui-regs.c (tui_last_regs_line_no)
2495         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2496         (tui_show_registers, tui_show_register_group)
2497         (tui_display_registers_from, tui_display_reg_element_at_line)
2498         (tui_display_registers_from_line, tui_check_register_values)
2499         (tui_reg_next, tui_reg_prev): Update.
2500         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2501         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2502         tui_data_window.
2503         (struct tui_win_info) <detail>: Remove.  Add new fields from
2504         tui_data_info.
2505         (TUI_DATA_WIN): Add cast.
2506         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2507         (~tui_data_window): Simplify.
2508
2509 2019-06-25  Tom Tromey  <tom@tromey.com>
2510
2511         * tui/tui-layout.c (show_source_disasm_command)
2512         (show_source_or_disasm_and_command): Update.
2513         * tui/tui-io.c (update_cmdwin_start_line)
2514         (tui_redisplay_readline): Update.
2515         * tui/tui-data.h (struct tui_command_info): Remove.
2516         (struct tui_win_info) <detail>: Remove command_info member.
2517         (struct tui_data_window) <start_line>: New member, from
2518         tui_command_info.
2519         (TUI_CMD_WIN): Add casts.
2520
2521 2019-06-25  Tom Tromey  <tom@tromey.com>
2522
2523         * tui/tui-winsource.c (tui_update_source_window)
2524         (tui_refill_source_window)
2525         (tui_source_window_base::do_scroll_horizontal)
2526         (tui_update_breakpoint_info, tui_set_exec_info_content)
2527         (tui_show_exec_info_content, tui_erase_exec_info_content)
2528         (tui_clear_exec_info_content): Update.
2529         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2530         Update.
2531         * tui/tui-win.c (make_invisible_and_set_new_height)
2532         (make_visible_with_new_height): Update.
2533         * tui/tui-source.c (tui_set_source_content)
2534         (tui_show_symtab_source): Update.
2535         * tui/tui-layout.c (extract_display_start_addr)
2536         (show_source_disasm_command, show_data)
2537         (make_source_or_disasm_window)
2538         (show_source_or_disasm_and_command): Update.
2539         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2540         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2541         "gdbarch".
2542         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2543         to tui_source_window_base.
2544         (struct tui_win_info) <detail>: Remove source_info member.
2545         (struct tui_source_window_base) <has_locator>: Inline.
2546         Move contents from tui_source_info; rename has_locator member to
2547         m_has_locator.
2548         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2549         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2550         header file.
2551         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2552         Simplify.
2553         (tui_free_all_source_wins_content): Cast to
2554         tui_source_window_base.
2555
2556 2019-06-25  Tom Tromey  <tom@tromey.com>
2557
2558         * tui/tui-win.c (make_invisible_and_set_new_height)
2559         (make_visible_with_new_height): Call has_locator method.
2560         * tui/tui-layout.c (show_source_disasm_command, show_data)
2561         (show_source_or_disasm_and_command): Update for bool change.
2562         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2563         (tui_win_info) <has_locator>: New method.
2564         (struct tui_source_window_base) <has_locator>: New method.
2565         (tui_win_has_locator): Don't declare.
2566         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2567         from tui_win_has_locator.
2568         (tui_source_window_base): Use false, not FALSE.
2569
2570 2019-06-25  Tom Tromey  <tom@tromey.com>
2571
2572         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2573         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2574         clear_detail method directly.
2575         (tui_clear_win_detail): Remove.
2576
2577 2019-06-25  Tom Tromey  <tom@tromey.com>
2578
2579         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2580         "this", not TUI_DISASM_WIN.
2581
2582 2019-06-25  Tom Tromey  <tom@tromey.com>
2583
2584         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2585         declare.
2586         * tui/tui-winsource.c
2587         (tui_source_window_base::do_scroll_horizontal): Rename from
2588         tui_horizontal_source_scroll.
2589         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2590         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2591         from tui_vertical_data_scroll.
2592         * tui/tui-win.h (tui_scroll): Don't declare.
2593         * tui/tui-win.c (tui_win_info::forward_scroll)
2594         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2595         (tui_win_info::right_scroll): Rename and update.
2596         (tui_scroll_forward_command, tui_scroll_backward_command)
2597         (tui_scroll_left_command, tui_scroll_right_command): Update.
2598         (tui_scroll): Remove.
2599         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2600         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2601         from tui_vertical_source_scroll.
2602         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2603         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2604         from tui_vertical_disassem_scroll.
2605         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2606         do_scroll_horizontal>: New methods.
2607         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2608         Likewise.
2609         (struct tui_source_window_base): Add do_scroll_horizontal.
2610         (struct tui_source_window, struct tui_disasm_window): Add
2611         do_scroll_vertical.
2612         (struct tui_data_window, struct tui_cmd_window): Add
2613         do_scroll_horizontal and do_scroll_vertical.
2614         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2615
2616 2019-06-25  Tom Tromey  <tom@tromey.com>
2617
2618         * tui/tui-data.h (struct tui_source_window_base): New struct.
2619         (struct tui_source_window): Derive from tui_source_window_base.
2620         (struct tui_disasm_window): New struct.
2621         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2622         from tui_source_window::clear_detail.
2623         (tui_source_window_base): Rename from tui_source_window.
2624         (~tui_source_window_base): Rename from ~tui_source_window.
2625         (tui_alloc_win_info): Create a tui_disasm_window.
2626
2627 2019-06-25  Tom Tromey  <tom@tromey.com>
2628
2629         * tui/tui-data.h (struct tui_source_window)
2630         (struct tui_data_window): Declare destructors.
2631         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2632         destructors.
2633         (tui_win_info): Simplify.
2634
2635 2019-06-25  Tom Tromey  <tom@tromey.com>
2636
2637         * tui/tui-winsource.c (tui_display_main)
2638         (tui_update_source_windows_with_addr)
2639         (tui_update_all_breakpoint_info): Update.
2640         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2641         (new_height_ok, parse_scrolling_args): Update.
2642         * tui/tui-stack.c (tui_show_frame_info): Update.
2643         * tui/tui-data.h (struct tui_list): Remove.
2644         (tui_source_windows): Return a reference to a std::vector.
2645         * tui/tui-data.c (source_windows): Now a std::vector.
2646         (tui_source_windows): Change return type.
2647         (tui_clear_source_windows): Rewrite.
2648         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2649         (tui_free_all_source_wins_content): Rewrite.
2650
2651 2019-06-25  Tom Tromey  <tom@tromey.com>
2652
2653         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2654         (struct tui_data_window, struct tui_cmd_window): Declare
2655         clear_detail method.
2656         * tui/tui-data.c (tui_source_window::clear_detail)
2657         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2658         methods.
2659         (tui_clear_win_detail): Simplify.
2660
2661 2019-06-25  Tom Tromey  <tom@tromey.com>
2662
2663         * tui/tui-layout.c (make_source_window, make_disasm_window)
2664         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2665         Return the new window.
2666         (show_source_disasm_command, show_data)
2667         (show_source_or_disasm_and_command): Update.
2668
2669 2019-06-25  Tom Tromey  <tom@tromey.com>
2670
2671         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2672         parameter.  Return the new window.
2673         (show_source_disasm_command): Update and remove NULL check.
2674         (show_source_or_disasm_and_command): Update.
2675
2676 2019-06-25  Tom Tromey  <tom@tromey.com>
2677
2678         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2679
2680 2019-06-25  Tom Tromey  <tom@tromey.com>
2681
2682         * tui/tui-data.h (struct tui_win_info): Make constructor
2683         protected.  Make destructor virtual.  Add initializers.
2684         (tui_source_window, tui_data_window, tui_cmd_window): New
2685         classes.
2686         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2687         constructor.  Add "type" parameter.
2688         (tui_source_window, tui_data_window, tui_cmd_window): New
2689         constructors.
2690         (tui_alloc_win_info): Instantiate the appropriate subclass.
2691
2692 2019-06-25  Tom Tromey  <tom@tromey.com>
2693
2694         * tui/tui-win.c (tui_resize_all): Use delete.
2695         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2696         destructor.
2697         (tui_free_window): Don't declare.
2698         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2699         Update.
2700
2701 2019-06-25  Tom Tromey  <tom@tromey.com>
2702
2703         * tui/tui-data.h (struct tui_win_info): Add constructor.
2704         * tui/tui-data.c (tui_alloc_win_info): Use new.
2705         (tui_free_window): Use delete.
2706
2707 2019-06-22  Tom Tromey  <tom@tromey.com>
2708
2709         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2710         declare.
2711         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2712
2713 2019-06-22  Tom Tromey  <tom@tromey.com>
2714
2715         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2716         declare.
2717         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2718
2719 2019-06-22  Tom de Vries  <tdevries@suse.de>
2720
2721         * dwarf2read.c (create_addrmap_from_aranges)
2722         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2723         instead of '%zu'.
2724
2725 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2726
2727         * dwarf2read.h (dwarf2_section_info_def): Remove.
2728         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2729         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2730         std::vector<dwarf2_section_info>.
2731         (struct dwo_file) <~dwo_file>: Remove.
2732         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2733         types field.
2734         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2735         (dwarf2_read_debug_names): Likewise.
2736         (create_debug_types_hash_table): Change parameter type to
2737         array_view, adjust code accordingly.
2738         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2739         (partial_die_info::fixup): Likewise.
2740         (determine_prefix): Likewise.
2741         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2742
2743 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2744
2745         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2746         gdb_bfd_ref_ptr.
2747         <~dwo_file>: Remove call to gdb_bfd_unref.
2748         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2749         gdb_bfd_ref_ptr::get.
2750
2751 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2752
2753         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2754         type to htab_up.
2755         * dwarf2read.c (struct dwo_file): Initialize fields.
2756         <~dwo_file>: New.
2757         (free_dwo_file): Remove, move content to ~dwo_file.
2758         (struct dwo_file_deleter): Remove.
2759         (dwo_file_up>: Remove custom deleter.
2760         (free_dwo_files): Remove.
2761         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2762         dwo_files.
2763         (process_skeletonless_type_units): Call unique_ptr::get.
2764         (allocate_dwo_file_hash_table): Add deleter to created hash
2765         table.  Change return type to htab_up.
2766         (lookup_dwo_file_slot): Don't memset dwo_file, call
2767         unique_ptr::get.
2768         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2769         (create_dwo_unit_in_dwp_v2): Likewise.
2770         (open_and_init_dwo_file): Likewise.
2771         (free_dwo_file_from_slot): Remove.
2772
2773 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2774
2775         * dwarf2read.h (struct dwarf2_section_info) <readin,
2776         is_virtual>: Change type to bool.
2777         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2778         true instead of 1.
2779
2780 2019-06-19  Tom Tromey  <tom@tromey.com>
2781
2782         * tui/tui-data.h (tui_init_content_element): Don't declare.
2783
2784 2019-06-19  Tom Tromey  <tom@tromey.com>
2785
2786         * tui/tui-data.h (tui_init_win_info): Don't declare.
2787
2788 2019-06-19  Tom de Vries  <tdevries@suse.de>
2789
2790         * dwarf2read.h (abstract_to_concrete): Change type to
2791         std::unordered_map<sect_offset, std::vector<sect_offset>,
2792         gdb::hash_enum<sect_offset>>.
2793
2794 2019-06-19  Tom Tromey  <tromey@adacore.com>
2795
2796         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2797         EVAL_AVOID_SIDE_EFFECTS specially.
2798
2799 2019-06-19  Tom Tromey  <tromey@adacore.com>
2800
2801         * source-cache.c (highlighter): New global.
2802         (source_cache::get_source_lines): Create a highlighter on demand.
2803
2804 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2805
2806         * defs.h (deprecated_interactive_hook): Delete declaration.
2807         * interps.c (clear_interpreter_hooks): Remove use of
2808         deprecated_interactive_hook.
2809         * top.c (deprecated_interactive_hook): Delete definition.
2810         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2811
2812 2019-06-18  Tom de Vries  <tdevries@suse.de>
2813
2814         PR gdb/24515
2815         * dwarf2read.h (abstract_to_concrete): Change type from
2816         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2817         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2818         * dwarf2read.c (read_variable): Update.
2819         (dwarf2_fetch_die_loc_sect_off): Update.
2820
2821 2019-06-17  Tom de Vries  <tdevries@suse.de>
2822
2823         PR gdb/24617
2824         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2825         accessing parent[parent_len - 1].
2826
2827 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2828
2829         PR gdb/24364
2830         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2831         call dtrace_process_dof with NULL dof.
2832
2833 2019-06-16  Tom de Vries  <tdevries@suse.de>
2834
2835         PR gdb/24445
2836         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2837
2838 2019-06-16  Tom Tromey  <tom@tromey.com>
2839
2840         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2841         (make_all_visible): Use address of member.
2842
2843 2019-06-16  Tom Tromey  <tom@tromey.com>
2844
2845         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2846         (tui_free_window, free_content, free_content_elements): Remove
2847         unnecessary cast.
2848         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2849         cast.
2850         * tui/tui-regs.c (tui_show_register_group)
2851         (tui_display_registers_from, tui_display_reg_element_at_line):
2852         Remove unnecessary cast.
2853
2854 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2855
2856         * linux-nat.c (normal_mask): Delete.
2857         (_initialize_linux_nat): Don't initialise normal_mask.
2858
2859 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2860
2861         PR gdb/24445
2862         * dwarf-index-write.h (write_psymtabs_to_index): Add
2863         dwz_basename parameter.
2864         * dwarf-index-write.c (write_gdbindex): Move file writing to
2865         write_gdbindex_1.  Change return type void.
2866         (assert_file_size): Move up, remove filename parameter.
2867         (write_gdbindex_1): New function.
2868         (write_debug_names): Change return type to void, call
2869         assert_file_size.
2870         (struct index_wip_file): New struct.
2871         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2872         file logic to index_wip_file.  Write index for dwz file if
2873         needed.
2874         (save_gdb_index_command): Pass basename of dwz file, if present.
2875         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2876         build-id of dwz file, if present.
2877         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2878         (dwarf2_get_dwz_file): Likewise.
2879         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2880         (dwarf2_get_dwz_file): Likewise.
2881
2882 2019-06-16  Tom Tromey  <tom@tromey.com>
2883
2884         * coffread.c (process_coff_symbol): Use xstrdup.
2885         * value.c (create_internalvar): Use xstrdup.
2886
2887 2019-06-16  Tom Tromey  <tom@tromey.com>
2888
2889         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2890         * breakpoint.c (stopin_command, stopat_command)
2891         (until_break_command, decode_location_default): Remove unnecessary
2892         cast.
2893         * utils.c (subset_compare): Remove unnecessary cast.
2894         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2895         cast.
2896         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2897         cast.
2898         * infcmd.c (path_command): Remove unnecessary cast.
2899         * coffread.c (decode_type): Remove unnecessary cast.
2900         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2901         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2902         * tui/tui-stack.c (tui_show_locator_content)
2903         (tui_show_frame_info): Remove unnecessary cast.
2904         * tui/tui-win.c (tui_scroll_forward_command)
2905         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2906         (parse_scrolling_args): Remove unnecessary cast.
2907         * tui/tui-data.c (init_win_info, tui_del_window)
2908         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2909         (free_content_elements): Remove unnecessary cast.
2910         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2911         unnecessary cast.
2912         * tui/tui-source.c (tui_set_source_content)
2913         (tui_vertical_source_scroll): Remove unnecessary cast.
2914         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2915         cast.
2916         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2917         * tui/tui-regs.c (tui_display_registers_from)
2918         (tui_display_register): Remove unnecessary cast.
2919         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2920         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2921         (make_visible): Remove unnecessary cast.
2922         * tui/tui-winsource.c (tui_erase_source_content)
2923         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2924         unnecessary cast.
2925         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2926         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2927         * stabsread.c (read_type, read_array_type, read_range_type):
2928         Remove unnecessary cast.
2929         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2930         (parse_symbol, parse_type, upgrade_type, parse_external)
2931         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2932         unnecessary cast.
2933         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2934
2935 2019-06-16  Tom Tromey  <tom@tromey.com>
2936
2937         * tui/tui-data.c (tui_alloc_generic_win_info)
2938         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2939         checks.
2940
2941 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2942             Andrew Burgess  <andrew.burgess@embecosm.com>
2943
2944         * f-typeprint.c (f_print_type): Don't return early for not
2945         associated or not allocated types.
2946         (f_type_print_varspec_suffix): Add print_rank parameter and print
2947         ranks of array types in case they dangling.
2948         (f_type_print_base): Add print_rank parameter.
2949
2950 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2951
2952         * NEWS: Mention new MI commands.
2953         * break-catch-throw.c (enum exception_event_kind): Move to
2954         breakpoint.h.
2955         (print_mention_exception_catchpoint): Output text as a single
2956         message.
2957         (catch_exception_command_1): Rename to...
2958         (catch_exception_event): ...this, make non-static, update header
2959         command, and change some parameter types.
2960         (catch_catch_command): Update for changes to
2961         catch_exception_command_1.
2962         (catch_throw_command): Likewise.
2963         (catch_rethrow_command): Likewise.
2964         * breakpoint.c (enum exception_event_kind): Delete.
2965         * breakpoint.h (enum exception_event_kind): Moved here from
2966         break-catch-throw.c.
2967         (catch_exception_event): Declare.
2968         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2969         (mi_cmd_catch_throw): New function.
2970         (mi_cmd_catch_rethrow): New function.
2971         (mi_cmd_catch_catch): New function.
2972         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2973         'catch-catch' entries.
2974         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2975         (mi_cmd_catch_rethrow): Declare.
2976         (mi_cmd_catch_catch): Declare.
2977
2978 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2979
2980         * annotate.c (annotate_source_line): Change return type to void,
2981         update implementation to match.
2982         * annotate.h (annotate_source_line): Change return type to void,
2983         update header comment.
2984         * stack.c (print_frame_info): Don't change what frame information
2985         is printed based on whether annotations are on or not.
2986
2987 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2988
2989         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2990         (annotate_source): Make static.
2991         (annotate_source_line): Moved from source.c and renamed from
2992         identify_source_line.  Update the return type.
2993         * annotate.h (annotate_source): Delete declaration.
2994         (annotate_source_line): Declaration moved from source.h, and
2995         renamed from identify_source_line.  Return type updated.
2996         * source.c (identify_source_line): Moved to annotate.c and renamed
2997         to annotate_source_line.
2998         (info_line_command): Remove check of annotation_level.
2999         * source.h (identify_source_line): Move declaration to annotate.h
3000         and rename to annotate_source_line.
3001         * stack.c: Add 'annotate.h' include.
3002         (print_frame_info): Remove check of annotation_level before
3003         calling annotate_source_line.
3004
3005 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3006
3007         * source-cache.c (source_cache::get_plain_source_lines): Use
3008         open_source_file_with_line_charpos instead of just
3009         open_source_file, remove call to find_source_lines.
3010         (source_cache::get_source_lines): Likewise.
3011         * source.c (find_source_lines): Make static.
3012         (get_filename_and_charpos): Renamed into...
3013         (open_source_file_with_line_charpos): ..this along with changes to
3014         return a scoped_fd, and some other minor clean ups.
3015         (identify_source_line): Use open_source_file_with_line_charpos.
3016         (search_command_helper): Use open_source_file_with_line_charpos
3017         instead of just open_source_file, remove call to
3018         find_source_lines.
3019         * source.h (open_source_file_with_line_charpos): Declare new
3020         function.
3021         (find_source_lines): Delete declaration.
3022
3023 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3024
3025         * source.c (get_filename_and_charpos): Remove fullname
3026         parameter.
3027         (identify_source_line): Update call to get_filename_and_charpos.
3028
3029 2019-06-14  Tom Tromey  <tromey@adacore.com>
3030
3031         PR gdb/24502:
3032         * ui-style.h (skip_ansi_escape): Update comment.
3033         * ui-file.h (class no_terminal_escape_file): New class.
3034         * ui-file.c (no_terminal_escape_file::write)
3035         (no_terminal_escape_file::puts): New methods.
3036         * cli/cli-logging.c (handle_redirections): Use
3037         no_terminal_escape_file.
3038
3039 2019-06-14  Tom Tromey  <tromey@adacore.com>
3040
3041         * NEWS: Move convenience variable news above Python news.
3042
3043 2019-06-14  Tom Tromey  <tom@tromey.com>
3044
3045         * gnulib: Move directory to top-level.
3046         * configure.ac: Don't configure gnulib.
3047         * configure: Rebuild.
3048         * common/common-defs.h: Use new path to gnulib.
3049         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3050         (GNULIB_H): Remove.
3051         (INCGNU): Look in new gnulib location.
3052         (HFILES_NO_SRCDIR): Remove gnulib files.
3053         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3054         (generated_files): Remove GNULIB_H.
3055         ($(LIBGNU), all-lib): Remove targets.
3056         (distclean): Don't mention GNULIB_BUILDDIR.
3057         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3058
3059 2019-06-14  Tom Tromey  <tromey@adacore.com>
3060
3061         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3062         Warn if symbol file does not provide any symbols.
3063
3064 2019-06-14  Tom Tromey  <tromey@adacore.com>
3065
3066         * source.c (find_and_open_source): Respect basenames_may_differ.
3067
3068 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3069
3070         * annotate.c (annotate_breakpoints_invalid): Make use of
3071         scoped_restore_terminal_state.
3072         (annotate_frames_invalid): Likewise.
3073
3074 2019-06-14  Tom Tromey  <tromey@adacore.com>
3075
3076         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3077         allow assignment to an internalvar.
3078
3079 2019-06-14  Tom Tromey  <tromey@adacore.com>
3080
3081         * ada-lex.l: Allow "_" in attribute names.
3082
3083 2019-06-14  Tom Tromey  <tromey@adacore.com>
3084
3085         PR gdb/24653:
3086         * regcache.c (registers_changed): Don't call alloca.
3087         * top.c (execute_command): Don't call alloca.
3088
3089 2019-06-13  Pedro Alves  <palves@redhat.com>
3090
3091         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3092         'expression'.  When parsing an expression, error out if there's
3093         junk after "unlimited".
3094         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3095         (do_set_command): Adjust calls to is_unlimited_literal.
3096
3097 2019-06-13  Pedro Alves  <palves@redhat.com>
3098
3099         * compile/compile.c (make_compile_options_def_group): Add braces
3100         around array_view initializer.
3101         * thread.c (make_thread_apply_all_options_def_group)
3102         (make_thread_apply_all_options_def_group): Likewise.
3103
3104 2019-06-13  Pedro Alves  <palves@redhat.com>
3105
3106         * NEWS (New commands): Mention "maint test-options
3107         require-delimiter", "maint test-options unknown-is-error", "maint
3108         test-options unknown-is-operand" and "maint show
3109         test-options-completion-result".
3110         (New command options, command completion): New section.
3111         (Completion improvements): New section.
3112         Mention that you can abbreviate "unlimited".
3113
3114 2019-06-13  Pedro Alves  <palves@redhat.com>
3115
3116         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3117         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3118         * unittests/cli-utils-selftests.c (test_parse_flags)
3119         (test_parse_flags_qcs): Delete.
3120         (test_cli_utils): Don't call deleted functions.
3121
3122 2019-06-13  Pedro Alves  <palves@redhat.com>
3123
3124         * thread.c: Include "cli/cli-option.h".
3125         (tp_array_compar_ascending): Global.
3126         (tp_array_compar): Delete function.
3127         (tp_array_compar_ascending, tp_array_compar_descending): New
3128         functions.
3129         (ascending_option_def, qcs_flag_option_def)
3130         (thr_qcs_flags_option_defs)
3131         (make_thread_apply_all_options_def_group)
3132         (make_thread_apply_options_def_group): New.
3133         (thread_apply_all_command): Use gdb::option::process_options.
3134         (thread_apply_command_completer)
3135         (thread_apply_all_command_completer): New.
3136         (thread_apply_command): Use gdb::option::process_options.
3137         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3138         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3139         to generate help text of "thread apply".  Adjust "taas"'s help.
3140         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3141         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3142
3143 2019-06-13  Pedro Alves  <palves@redhat.com>
3144
3145         * thread.c (thread_apply_command): Check for invalid TID with
3146         isdigit instead of !isalpha.
3147
3148 2019-06-13  Pedro Alves  <palves@redhat.com>
3149
3150         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3151         (validate_flags_qcs): New.
3152         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3153         (validate_flags_qcs): Declare.
3154         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3155         (make_frame_apply_options_def_group): New.
3156         (frame_apply_command_count): Process options with
3157         gdb::option::process_options.
3158         (frame_apply_completer): New.
3159         (frame_apply_level_completer, frame_apply_all_completer)
3160         (frame_apply_completer): New.
3161         (_initialize_stack): Update help of "frame apply", "frame apply
3162         level", "frame apply all" and "faas" to mention supported options
3163         and install command completers.
3164         * stack.h (frame_apply_all_completer): Declare.
3165         * thread.c: Include "stack.h".
3166         (tfaas_command): Add "--".
3167         (_initialize_thread): Update help "tfaas" to mention supported
3168         options and install command completer.
3169
3170 2019-06-13  Pedro Alves  <palves@redhat.com>
3171
3172         * completer.c (complete_nested_command_line): New.
3173         (gdb_completion_word_break_characters_throw): Add assertion.
3174         * completer.h (complete_nested_command_line): Declare.
3175
3176 2019-06-13  Pedro Alves  <palves@redhat.com>
3177
3178         * stack.c (parse_backtrace_qualifiers): New.
3179         (backtrace_command): Use it.
3180         (backtrace_command_completer): Complete on qualifiers.
3181
3182 2019-06-13  Pedro Alves  <palves@redhat.com>
3183
3184         * frame.c: Include "cli/cli-option.h.
3185         (user_set_backtrace_options): New.
3186         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3187         Delete.
3188         (get_prev_frame): Adjust.
3189         (boolean_option_def, uinteger_option_def)
3190         (set_backtrace_option_defs): New.
3191         (_initialize_frame): Adjust and use
3192         gdb::option::add_setshow_cmds_for_options to install "set
3193         backtrace past-main" and "set backtrace past-entry".
3194         * frame.h: Include "cli/cli-option.h".
3195         (struct frame_print_options): Forward declare.
3196         (print_frame_arguments_all, print_frame_arguments_scalars)
3197         (print_frame_arguments_none): Declare.
3198         (print_entry_values): Delete declaration.
3199         (struct frame_print_options, user_frame_print_options): New.
3200         (struct set_backtrace_options): New.
3201         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3202         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3203         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3204         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3205         (list_args_or_locals): Add frame_print_options parameter.
3206         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3207         * python/py-framefilter.c (enumerate_args): Pass down
3208         USER_FRAME_PRINT_OPTIONS.
3209         * stack.c: Include "cli/cli-option.h".
3210         (print_frame_arguments_all, print_frame_arguments_scalars)
3211         (print_frame_arguments_none): Declare.
3212         (print_raw_frame_arguments, print_entry_values): Delete.
3213         (user_frame_print_options): New.
3214         (boolean_option_def, enum_option_def, frame_print_option_defs):
3215         New.
3216         (struct backtrace_cmd_options): New.
3217         (bt_flag_option_def): New.
3218         (backtrace_command_option_defs): New.
3219         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3220         (print_frame_arg, read_frame_arg, print_frame_args)
3221         (print_frame_info, print_frame): Add frame_print_options parameter
3222         and use it.
3223         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3224         (backtrace_command_1): Add frame_print_options and
3225         backtrace_cmd_options parameters and use them.
3226         (make_backtrace_options_def_group): New.
3227         (backtrace_command): Process command options with
3228         gdb::option::process_options.
3229         (backtrace_command_completer): New.
3230         (_initialize_stack): Extend "backtrace"'s help to mention
3231         supported options.  Install completer for "backtrace".
3232         Install some settings commands with add_setshow_cmds_for_options.
3233
3234 2019-06-13  Pedro Alves  <palves@redhat.com>
3235
3236         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3237         and that "set/show print raw frame-arguments" are now deprecated.
3238
3239         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3240         command.
3241         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3242         * stack.c (_initialize_stack): Install "set/show print
3243         raw-frame-arguments", and deprecate "set/show print raw
3244         frame-arguments".
3245         * valprint.c (_initialize_valprint): Deprecate "set/show print
3246         raw".
3247
3248 2019-06-13  Pedro Alves  <palves@redhat.com>
3249
3250         * compile/compile.c (struct compile_options): New.
3251         (compile_flag_option_def, compile_command_option_defs)
3252         (make_compile_options_def_group): New.
3253         (compile_file_command): Handle options with
3254         gdb::option::process_options.
3255         (compile_file_command_completer): New function.
3256         (compile_code_command): Handle options with
3257         gdb::option::process_options.
3258         (compile_code_command_completer): New function.
3259         (_initialize_compiler): Install completers for "compile code" and
3260         "compile file".  Mention available options in "compile code" and
3261         "compile code"'s help.
3262         * completer.c (advance_to_completion_word): New, factored out from
3263         ...
3264         (advance_to_expression_complete_word_point): ... this.
3265         (advance_to_filename_complete_word_point): New.
3266         * completer.h (advance_to_filename_complete_word_point): New
3267         declaration.
3268
3269 2019-06-13  Pedro Alves  <palves@redhat.com>
3270
3271         * compile/compile.c: Include "cli/cli-option.h".
3272         (compile_print_value): Scope data pointer is now a
3273         value_print_options pointer; adjust.
3274         (compile_print_command): Process options.  Scope data pointer is
3275         now a value_print_options pointer; adjust.
3276         (_initialize_compile): Update "compile print"'s help to include
3277         supported options.  Install a completer for "compile print".
3278         * cp-valprint.c (show_vtblprint, show_objectprint)
3279         (show_static_field_print): Delete.
3280         (_initialize_cp_valprint): Don't install "set print
3281         static-members", "set print vtbl", "set print object" here.
3282         * printcmd.c: Include "cli/cli-option.h" and
3283         "common/gdb_optional.h".
3284         (print_command_parse_format): Rework to fill in a
3285         value_print_options instead of a format_data.
3286         (print_value): Change parameter type from format_data pointer to
3287         value_print_options reference.  Adjust.
3288         (print_command_1): Process options.  Adjust to pass down a
3289         value_print_options.
3290         (print_command_completer): New.
3291         (_initialize_printcmd): Install print_command_completer as
3292         handle_brkchars completer for the "print" command.  Update
3293         "print"'s help to include supported options.
3294         * valprint.c: Include "cli/cli-option.h".
3295         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3296         here from cp-valprint.c.
3297         (boolean_option_def, uinteger_option_def)
3298         (value_print_option_defs, make_value_print_options_def_group):
3299         New.  Use gdb::option::add_setshow_cmds_for_options to install
3300         "set print elements", "set print null-stop", "set print repeats",
3301         "set print pretty", "set print union", "set print array", "set
3302         print address", "set print symbol", "set print array-indexes".
3303         * valprint.h: Include <string> and "cli/cli-option.h".
3304         (make_value_print_options_def_group): Declare.
3305         (print_value): Change parameter type from format_data pointer to
3306         value_print_options reference.
3307         (print_command_completer): Declare.
3308
3309 2019-06-13  Pedro Alves  <palves@redhat.com>
3310
3311         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3312         (COMMON_SFILES): Add maint-test-settings.c.
3313         * cli/cli-decode.c (boolean_enums): New global, factored out from
3314         ...
3315         (add_setshow_boolean_cmd): ... here.
3316         * cli/cli-decode.h (boolean_enums): Declare.
3317         * cli/cli-option.c: New file.
3318         * cli/cli-option.h: New file.
3319         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3320         factored out from ...
3321         (parse_cli_boolean_value(const char *)): ... this.
3322         (is_unlimited_literal): Change parameter type to pointer to
3323         pointer.  Adjust and advance ARG pointer.
3324         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3325         (parse_cli_var_enum): New, factored out from ...
3326         (do_set_command): ... this.  Adjust.
3327         * cli/cli-setshow.h (parse_cli_boolean_value)
3328         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3329         (parse_cli_var_enum): Declare.
3330         * cli/cli-utils.c: Include "cli/cli-option.h".
3331         (get_ulongest): New.
3332         * cli/cli-utils.h (get_ulongest): Declare.
3333         (check_for_argument): New overloads.
3334         * maint-test-options.c: New file.
3335
3336 2019-06-13  Pedro Alves  <palves@redhat.com>
3337
3338         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3339         parse a range if "-" is at the end of the string.
3340
3341 2019-06-13  Pedro Alves  <palves@redhat.com>
3342
3343         * cli/cli-setshow.c (parse_auto_binary_operation)
3344         (parse_cli_boolean_value): Don't allow "o".
3345
3346 2019-06-13  Pedro Alves  <palves@redhat.com>
3347
3348         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3349         * NEWS: Mention maint test-settings KIND.
3350         * maint-test-settings.c: New file.
3351
3352 2019-06-13  Pedro Alves  <palves@redhat.com>
3353
3354         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3355         completer.
3356         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3357         "set" completers.
3358
3359 2019-06-13  Pedro Alves  <palves@redhat.com>
3360
3361         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3362         after item.
3363
3364 2019-06-13  Pedro Alves  <palves@redhat.com>
3365
3366         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3367
3368 2019-06-13  Pedro Alves <palves@redhat.com>
3369
3370         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3371         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3372         call.
3373         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3374         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3375         calls.
3376         (check_for_argument): Skip spaces after argument.
3377
3378 2019-06-13  Pedro Alves  <palves@redhat.com>
3379
3380         * thread.c (thread_apply_command): Adjust TID parsing.
3381         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3382         detected before end of string.
3383         (tid_is_in_list): Error out if LIST is invalid.
3384
3385 2019-06-13  Pedro Alves  <palves@redhat.com>
3386
3387         * completer.c (complete_line_internal_1): Rewind completion word
3388         point.
3389         (completion_tracker::advance_custom_word_point_by): Change
3390         parameter type to int.
3391         * completer.h (completion_tracker::advance_custom_word_point_by):
3392         Likewise.
3393
3394 2019-06-13  Pedro Alves  <palves@redhat.com>
3395
3396         * completer.c (advance_to_completion_word): Handle delimiters.
3397
3398 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3399
3400         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3401
3402 2019-06-11  Tom Tromey  <tom@tromey.com>
3403
3404         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3405         (xmalloc_failed): Move to alloc.c.
3406         * alloc.c: New file.
3407         * Makefile.in (COMMON_SFILES): Add alloc.c.
3408
3409 2019-06-11  Tom Tromey  <tom@tromey.com>
3410
3411         * nat/linux-waitpid.c: Don't include server.h.
3412         (linux_debug): Remove.
3413         (my_waitpid): Update.
3414
3415 2019-06-11  Tom Tromey  <tromey@adacore.com>
3416
3417         * infcall.c (_initialize_infcall): Remove trailing newline from
3418         help.
3419         * user-regs.c (_initialize_user_regs): Remove trailing newline
3420         from help.
3421         * typeprint.c (_initialize_typeprint): Remove trailing newline
3422         from help.
3423         * reverse.c (_initialize_reverse): Remove trailing newlines from
3424         help.
3425         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3426         from help.
3427         * language.c (add_set_language_command): Remove trailing newline
3428         from help.
3429         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3430         help.
3431         * disasm.c (_initialize_disasm): Remove trailing newline from
3432         help.
3433         * top.c (init_main): Remove trailing newline from help.
3434         * interps.c (_initialize_interpreter): Remove trailing newline
3435         from help.
3436         * btrace.c (_initialize_btrace): Remove trailing newlines from
3437         help.
3438         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3439         from help.
3440         * python/python.c (_initialize_python): Remove trailing newline
3441         from help.
3442         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3443         help.
3444         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3445         from help.  Reformat some text.
3446         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3447         from help.
3448         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3449         newline from help.
3450
3451 2019-06-11  Tom Tromey  <tromey@adacore.com>
3452
3453         * darwin-nat.c (darwin_decode_exception_message)
3454         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3455
3456 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3457
3458         * valops.c (value_slice): Check for not allocated or not
3459         associated values.
3460
3461 2019-06-10  Tom de Vries  <tdevries@suse.de>
3462
3463         PR gdb/24618
3464         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3465         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3466         invalid.
3467
3468 2019-06-10  Tom de Vries  <tdevries@suse.de>
3469
3470         PR gdb/24611
3471         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3472         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3473
3474 2019-06-10  Tom de Vries  <tdevries@suse.de>
3475
3476         PR symtab/24545
3477         * symtab.c (struct demangled_name_entry): Add language field.
3478         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3479         static minimal symbol".  Set and use language field.
3480
3481 2019-06-10  Tom Tromey  <tromey@adacore.com>
3482
3483         * ada-lang.c (_initialize_ada_language): Update help text.
3484
3485 2019-06-10  Tom Tromey  <tromey@adacore.com>
3486
3487         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3488         with a newline.
3489         * guile/guile.c (handle_boot_error): Don't end warning with a
3490         newline.
3491         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3492         warning with a newline.
3493         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3494         newline.
3495         (s12z_frame_cache): Likewise.
3496         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3497         a newline.
3498         * solib-svr4.c (disable_probes_interface): Don't end warning with
3499         a newline.
3500         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3501         newline.
3502         * python/python.c (do_finish_initialization): Don't end warning
3503         with a newline.
3504
3505 2019-06-10  Tom Tromey  <tom@tromey.com>
3506
3507         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3508         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3509         gdbpy_enter.
3510
3511 2019-06-10  Tom Tromey  <tromey@adacore.com>
3512
3513         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3514         data.
3515         (elf_new_init): Don't call stabsread_new_init.
3516         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3517         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3518         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3519
3520 2019-06-10  Tom de Vries  <tdevries@suse.de>
3521
3522         PR symtab/16264
3523         PR symtab/24517
3524         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3525
3526 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3527
3528         * source.c (find_and_open_source): Also rewrite relative file
3529         names.
3530
3531 2019-04-26  Amos Bird  <amosbird@gmail.com>
3532
3533         * annotate.c (annotate_thread_exited): Add "thread-exited"
3534         annotation.
3535
3536 2019-06-06  Tom Tromey  <tromey@adacore.com>
3537
3538         * maint.h (class scoped_command_stats): Use
3539         DISABLE_COPY_AND_ASSIGN.
3540         <print_time>: New method.
3541         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3542         print_time.
3543         (scoped_command_stats::print_time): New method.
3544
3545 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3546
3547         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3548         instructions of lengths 6 or 8 bytes.
3549
3550 2019-06-04  Pedro Alves  <palves@redhat.com>
3551
3552         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3553
3554         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3555         * breakpoint.c (condition_completer): Likewise.
3556         * cli/cli-dump.c (scan_expression): Likewise.
3557         * common/filestuff.c (mkdir_recursive): Likewise.
3558         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3559         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3560         (gdb_abspath): Likewise.
3561         * compile/compile-cplus-types.c
3562         (compile_cplus_instance::decl_name): Likewise.
3563         * completer.c (complete_explicit_location):
3564         (signal_completer, reg_or_group_completer_1): Likewise.
3565         * cp-support.c (cp_remove_params_if_any): Likewise.
3566         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3567         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3568         * infcmd.c (strip_bg_char): Likewise.
3569         * linespec.c (copy_token_string): Likewise.
3570         * mi/mi-main.c (output_cores): Likewise.
3571         * psymtab.c (psymtab_search_name):
3572         * symfile.c (test_set_ext_lang_command): Likewise.
3573         * target.c (target_fileio_read_stralloc): Likewise.
3574         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3575         * value.c (complete_internalvar): Likewise.
3576
3577 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3578
3579         Add objfile property to gdb.Type.
3580         * NEWS: Mention Python API addition.
3581         * python/py-type.c (typy_get_objfile): New method.
3582
3583 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3584
3585         * NEWS: Mention the new set|show style [title|highlight].
3586         Mention changes to "show style", "help" and "apropos".
3587
3588 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3589
3590         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3591         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3592         instead of print_help_for_command.
3593         (print_doc_of_command): New function.
3594         (help_list): Add 'apropos -v word' suggestion.
3595         (print_help_for_command): Style the command name using title style.
3596         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3597         (_initialize_cli_cmds): Describe -v in apropos_command help.
3598
3599 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3600
3601         * cli/cli-style.h (cli_style_option): Add name in constructor,
3602         add m_name class member, add constructor with intensity,
3603         add name class function.
3604         (cli_style_option::add_setshow_commands): Remove name argument.
3605         (highlight_style, title_style): New styles.
3606         * cli/cli-style.c (do_show): New function that shows a style
3607         characteristic styling the style name with itself.
3608         (set_style_name): New function.
3609         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3610         Update all callers according to the changes in cli/cli-style.h.
3611         * utils.h (fputs_highlighted): New function.
3612         * utils.c (fputs_highlighted): Likewise.
3613
3614 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3615
3616         * NEWS: Mention new pipe command and new convenience variables.
3617
3618 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3619
3620         * cli/cli-cmds.c (pipe_command): New function.
3621         (_initialize_cli_cmds): Call add_com for pipe_command.
3622         Define | as an alias for pipe.
3623         (exit_status_set_internal_vars): New function.
3624         (shell_escape): Call exit_status_set_internal_vars.
3625         cli/cli-decode.c (find_command_name_length): Recognize | as
3626         a single character command.
3627
3628 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3629
3630         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3631         top.c (execute_command_to_ui_file): New function, mostly a copy
3632         of execute_command_to_string.
3633         (execute_command_to_string): Implement by calling
3634         execute_command_to_ui_file.
3635
3636 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3637
3638         * top.h (saved_command_line): Remove declaration.
3639         * top.c (previous_saved_command_line, previous_repeat_arguments):
3640         New variables.
3641         (saved_command_line): Make static, define together with other
3642         'repeat variables'.
3643         (dont_repeat): Clear repeat_arguments.
3644         (repeat_previous, get_saved_command_line, save_command_line):
3645         New functions.
3646         (gdb_init): Initialize saved_command_line
3647         and previous_saved_command_line.
3648         * main.c (captured_main_1): Remove saved_command_line initialization.
3649         * event-top.c (handle_line_of_input): Update to use
3650         the new 'repeat' related functions instead of direct access to
3651         saved_command_line.
3652         * command.h (repeat_previous, get_saved_command_line,
3653         save_command_line): New declarations.
3654         (dont_repeat): Add comment.
3655
3656 2019-05-30  Tom Tromey  <tromey@adacore.com>
3657
3658         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3659         Fix comment.
3660         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3661
3662 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3663
3664         PR cli/24587
3665         * completer.c (complete): Initialize variable word.
3666
3667 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3668
3669         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3670         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3671         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3672         'body' is NULL to the outter 'if', protecting the '!is_define'
3673         situation as well.
3674
3675 2019-05-29  Tom Tromey  <tromey@adacore.com>
3676
3677         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3678         (dwarf_unknown): New function.
3679         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3680         (dwarf_type_encoding_name): Use dwarf_unknown.
3681
3682 2019-05-29  Tom Tromey  <tromey@adacore.com>
3683
3684         PR c++/20020:
3685         * cp-valprint.c (cp_print_value_fields): Call
3686         cp_print_static_field inside "try".
3687
3688 2019-05-29  Tom Tromey  <tromey@adacore.com>
3689
3690         * inflow.c (struct terminal_info): Add default operator=.
3691         * configure: Rebuild.
3692         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3693         -Wdeprecated-copy-dtor, -Wredundant-move.
3694
3695 2019-05-29  Tom Tromey  <tromey@adacore.com>
3696
3697         * NEWS: Add entry.
3698         * infcmd.c (print_return_value_1): Handle finish_print
3699         option.
3700         (show_print_finish): New function.
3701         (_initialize_infcmd): Add "set/show print finish" commands.
3702         * valprint.c (user_print_options): Initialize new member.
3703         * valprint.h (struct value_print_options) <finish_print>: New
3704         member.
3705
3706 2019-05-28  Tom Tromey  <tromey@adacore.com>
3707
3708         * ada-lang.c (ada_remove_Xbn_suffix)
3709         (find_old_style_renaming_symbol)
3710         (parse_old_style_renaming): Remove.
3711         (ada_find_renaming_symbol): Don't call
3712         find_old_style_renaming_symbol.
3713         (ada_is_renaming_symbol): Rename from
3714         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3715         bool.  Now static.
3716         (ada_read_var_value): Update and simplify.
3717         * ada-exp.y (write_var_or_type): Remove old code.
3718
3719 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3720
3721         * event-top.c: Remove include comment.
3722         * inflow.c (class scoped_ignore_sigttou): Move from here...
3723         * inflow.h (class scoped_ignore_sigttou): ...to here.
3724         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3725         * top.c:  Remove include comment.
3726
3727 2019-05-27  Tom Tromey  <tom@tromey.com>
3728
3729         * NEWS: Fix typo.
3730
3731 2019-05-22  Tom Tromey  <tromey@adacore.com>
3732
3733         * target.c (target_follow_exec): Constify parameter.
3734         * target-delegates.c: Rebuild.
3735         * remote.c (remote_target::follow_exec): Constify parameter.
3736         * infrun.c (follow_exec): Constify parameter.
3737         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3738         (target_follow_exec): Likewise.
3739
3740 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3741
3742         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3743         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3744
3745 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3746
3747         * NEWS: Add debugredirect and testsuite sections.
3748
3749 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3750
3751         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3752         target descriptions using exclusively floating point register name
3753         aliases.
3754
3755 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3756
3757         PR gdb/18644:
3758         * f-lang.c (build_fortran_types): Handle the case where
3759         gdbarch_floatformat_for_type returns a nullptr.
3760
3761 2019-05-21  Tom de Vries  <tdevries@suse.de>
3762
3763         PR cli/24587
3764         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3765
3766 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3767
3768         PR gdb/18644:
3769         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3770         16-byte floats.
3771         * i386-tdep.c (i386_floatformat_for_type): Use
3772         floatformats_ia64_quad for the 16-byte floating point component
3773         within a fortran 32-byte complex number.
3774
3775 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3776
3777         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3778         delete default constructor.
3779         (find_partial_die): Update to return const struct.
3780         (partial_die_parent_scope): Move variable declaration into scope
3781         of its use and change its type to auto.
3782         (guess_partial_die_structure_name): Likewise.
3783         (partial_die_info::fixup): Likewise.
3784
3785 2019-05-17  Tom Tromey  <tromey@adacore.com>
3786
3787         * source.c (find_and_open_source): Remove cast.
3788
3789 2019-05-17  Tom Tromey  <tromey@adacore.com>
3790
3791         * annotate.c (annotate_source): Make "filename" const.
3792         * annotate.h (annotate_source): Use const.
3793
3794 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3795
3796         * disasm.c (set_disassembler_options): Send errors to stderr.
3797
3798 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3799
3800         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3801         (cli_interp_base::set_logging): Check debug_redirect.
3802         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3803         * cli/cli-logging.c (debug_redirect): Add static variable.
3804         (pop_output_files): Add default param.
3805         (handle_redirections): Print debug setting.
3806         (show_logging_command): Likewise.
3807         (_initialize_cli_logging): Add debugredirect command.
3808         * interps.c (current_interp_set_logging): Add debug_redirect
3809         parameter.
3810         * interps.h (set_logging): Add debug_redirect parameter.
3811         (current_interp_set_logging): Likewise.
3812         * mi/mi-common.h: Likewise.
3813         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3814
3815 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3816             Tom Tromey  <tromey@adacore.com>
3817
3818         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3819         directly.
3820         * cli/cli-interp.h (make_logging_output): Remove declaration.
3821         * cli/cli-logging.c (make_logging_output): Remove function.
3822         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3823         directly.
3824         * ui-file.c (tee_file::tee_file): Remove bools.
3825         (tee_file::~tee_file): Remove deletes.
3826         * ui-file.h (tee_file): Remove bools.
3827
3828 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3829
3830         * mi/mi-cmds.h (mi_cmd_complete): New function.
3831         * mi/mi-main.c (mi_cmd_complete): Likewise.
3832         * mi/mi-cmds.c: Define new MI command -complete.
3833         * NEWS: Mention new -complete command.
3834
3835 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3836
3837         * completer.h (complete): New function.
3838         * completer.c (complete): Likewise.
3839         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3840         function defined in completer.h.
3841
3842 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3843
3844         * MAINTAINERS (Write After Approval): Add myself.
3845
3846 2019-05-17  Tom de Vries  <tdevries@suse.de>
3847
3848         PR gdb/24094
3849         * dwarf2read.c (struct cu_partial_die_info): New struct.
3850         (find_partial_die): Return cu_partial_die_info.
3851         (partial_die_parent_scope, guess_partial_die_structure_name)
3852         (partial_die_info::fixup): Handle new return type of find_partial_die.
3853
3854 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3855
3856         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3857         "std::string", simplifying the algorithm.
3858
3859 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3860
3861         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3862         (stap_static_probe_ops::get_probes): Likewise.
3863
3864 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3865
3866         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3867         '-')" and "else if".
3868         (stap_parse_single_operand): Join checks for
3869         "gdbarch_stap_parse_special_token_p" and
3870         "gdbarch_stap_parse_special_token" in the same "if" statement.
3871         Invert check when verifying for operation on register
3872         displacement.
3873
3874 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3875
3876         * stap-probe.c (stap_get_opcode): Update comment.
3877         (stap_get_expected_argument_type): Likewise.
3878         (handle_stap_probe): Likewise.
3879
3880 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3881
3882         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3883         return type to 'bool'.  Adjust comment.  Use 'bool' when
3884         appropriate.
3885         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3886         * stap-probe.c (stap_parse_argument_1): Likewise.
3887         (stap_is_operator): Likewise.
3888         (stap_is_generic_prefix): Likewise.
3889         (stap_is_register_prefix): Likewise.
3890         (stap_is_register_indirection_prefix): Likewise.
3891         (stap_is_integer_prefix): Likewise.
3892         (stap_generic_check_suffix): Likewise.
3893         (stap_check_integer_suffix): Likewise.
3894         (stap_check_register_suffix): Likewise.
3895         (stap_check_register_indirection_suffix): Likewise.
3896         (stap_parse_register_operand): Likewise.
3897         (stap_parse_single_operand): Likewise.
3898         (stap_parse_argument_1): Likewise.
3899         (stap_probe::get_argument_count): Likewise.
3900         (stap_is_operator): Likewise.
3901
3902 2019-05-16  Tom Tromey  <tromey@adacore.com>
3903
3904         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3905         keyword to foreach.
3906
3907 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3908
3909         * linux-thread-db.c (try_thread_db_load_1): Change return type
3910         to bool.
3911         (try_thread_db_load): Likewise.
3912         (try_thread_db_load_from_pdir_1): Likewise.
3913         (try_thread_db_load_from_pdir): Likewise.
3914         (try_thread_db_load_from_sdir): Likewise.
3915         (try_thread_db_load_from_dir): Likewise.
3916         (thread_db_load_search): Likewise.
3917         (has_libpthread): Likewise.
3918         (thread_db_load): Likewise.
3919
3920 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3921
3922         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3923         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3924         NULL, and complain/return if that's the case.
3925
3926 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3927
3928         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3929         (advance, posn, abstract_read_memory): New functions.
3930         [struct mem_read_abstraction]: New struct.
3931         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3932
3933 2019-05-14  Tom Tromey  <tromey@adacore.com>
3934
3935         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3936         value is not lval_memory.
3937
3938 2019-05-14  Tom Tromey  <tromey@adacore.com>
3939
3940         * solib.c (info_sharedlibrary_command): Style the file name.
3941
3942 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3943
3944         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3945         (aarch64_vnv_type): Likewise.
3946         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3947         * common/tdesc.c: Likewise.
3948         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3949         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3950         * features/aarch64-fpu.xml: Add ieee half view.
3951         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3952         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3953         * gdbtypes.h (struct builtin_type): Likewise.
3954         (struct objfile_type): Likewise.
3955
3956 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3957
3958         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3959         typo.
3960         * location.h (string_to_event_location): Likewise.
3961
3962 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3963
3964         GDB 8.3 released.
3965
3966 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3967
3968         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3969         New variable declaration.
3970         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3971         New variable.
3972         (print_one_breakpoint): Use ui_out::test_flags and new global
3973         variable to compute use_fixed_output.
3974         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3975         Remove.
3976         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3977         (mi_multi_location_breakpoint_output_fixed): Remove.
3978         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3979         new variable.
3980         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3981         fix_multi_location_breakpoint_output flag if version >= 3.
3982         * ui-out.h (enum ui_out_flag)
3983         <fix_multi_location_breakpoint_output>: New enumerator.
3984
3985 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3986
3987         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3988
3989 2019-05-10  Tom Tromey  <tromey@adacore.com>
3990
3991         * ada-lang.c (catch_ada_completer): New function.
3992         (_initialize_ada_language): Use it.
3993
3994 2019-05-10  Tom Tromey  <tromey@adacore.com>
3995
3996         * thread.c (print_thread_info): Make "requested_threads" const.
3997         * gdbthread.h (print_thread_info): Make "requested_threads"
3998         const.
3999         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
4000         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
4001
4002 2019-05-08  Tom Tromey  <tom@tromey.com>
4003
4004         * gdbtypes.c (objfile_type_data): Change type.
4005         (objfile_type, _initialize_gdbtypes): Update.
4006
4007 2019-05-08  Tom Tromey  <tom@tromey.com>
4008
4009         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
4010         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
4011         (_initialize_dwarf2_frame): Update.
4012
4013 2019-05-08  Tom Tromey  <tom@tromey.com>
4014
4015         * objc-lang.c (objc_objfile_data): Change type.
4016         (find_methods): Update.
4017         (_initialize_objc_lang): Remove.
4018
4019 2019-05-08  Tom Tromey  <tom@tromey.com>
4020
4021         * stabsread.c (rs6000_builtin_type_data): Change type.
4022         (rs6000_builtin_type, _initialize_stabsread): Update.
4023
4024 2019-05-08  Tom Tromey  <tom@tromey.com>
4025
4026         * mips-tdep.c (mips_pdr_data): Remove.
4027         (_initialize_mips_tdep): Update.
4028
4029 2019-05-08  Tom Tromey  <tom@tromey.com>
4030
4031         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4032         (hppa_init_objfile_priv_data, read_unwind_info)
4033         (find_unwind_entry, _initialize_hppa_tdep): Update.
4034
4035 2019-05-08  Tom Tromey  <tom@tromey.com>
4036
4037         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4038         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4039         on obstack.
4040         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4041
4042 2019-05-08  Tom Tromey  <tom@tromey.com>
4043
4044         * mdebugread.c (basic_type_data): Change type.
4045         (basic_type, _initialize_mdebugread): Update.
4046
4047 2019-05-08  Tom Tromey  <tom@tromey.com>
4048
4049         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4050
4051 2019-05-08  Tom Tromey  <tom@tromey.com>
4052
4053         * nto-tdep.c (nto_inferior_data_reg): Change type.
4054         (nto_inferior_data): Update.
4055         (nto_inferior_data_cleanup, nto_new_inferior_data)
4056         (_initialize_nto_tdep): Remove.
4057         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4058
4059 2019-05-08  Tom Tromey  <tom@tromey.com>
4060
4061         * ada-lang.c (struct ada_inferior_data): Add initializers.
4062         (ada_inferior_data): Change type.
4063         (ada_inferior_data_cleanup): Remove.
4064         (get_ada_inferior_data, ada_inferior_exit)
4065         (struct ada_pspace_data): Add initializers, destructor.
4066         (ada_pspace_data_handle): Change type.
4067         (get_ada_pspace_data): Update.
4068         (ada_pspace_data_cleanup): Remove.
4069
4070 2019-05-08  Tom Tromey  <tom@tromey.com>
4071
4072         * coffread.c (struct coff_symfile_info): Add initializers.
4073         (coff_objfile_data_key): Move lower.  Change type.
4074         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4075         Update.
4076         (coff_free_info): Remove.
4077
4078 2019-05-08  Tom Tromey  <tom@tromey.com>
4079
4080         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4081         (fbsd_pspace_data_handle): Move lower.  Change type.
4082         (get_fbsd_pspace_data): Update.
4083         (fbsd_pspace_data_cleanup): Remove.
4084         (_initialize_fbsd_tdep): Update.
4085
4086 2019-05-08  Tom Tromey  <tom@tromey.com>
4087
4088         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4089         (get_ada_tasks_pspace_data): Update.
4090         (ada_tasks_pspace_data_cleanup): Remove.
4091         (_initialize_tasks): Update.
4092         (ada_tasks_inferior_data_handle): Change type.
4093         (get_ada_tasks_inferior_data): Update.
4094         (ada_tasks_inferior_data_cleanup): Remove.
4095         (struct ada_tasks_pspace_data): Add initializers.
4096
4097 2019-05-08  Tom Tromey  <tom@tromey.com>
4098
4099         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4100         * symfile-debug.c (debug_sym_get_probes): Change type.
4101         * stap-probe.c (handle_stap_probe):
4102         (stap_static_probe_ops::get_probes): Change type.
4103         * probe.h (class static_probe_ops) <get_probes>: Change type.
4104         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4105         (parse_probes_in_pspace): Update.
4106         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4107         Update.
4108         (any_static_probe_ops::get_probes): Change type.
4109         * elfread.c (elfread_data): New typedef.
4110         (probe_key): Change type.
4111         (elf_get_probes): Likewise.  Update.
4112         (probe_key_free): Remove.
4113         (_initialize_elfread): Update.
4114         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4115         Change type.
4116         (dtrace_process_dof_probe, dtrace_process_dof)
4117         (dtrace_static_probe_ops::get_probe): Change type.
4118
4119 2019-05-08  Tom Tromey  <tom@tromey.com>
4120
4121         * xcoffread.c (struct xcoff_symfile_info): Rename from
4122         coff_symfile_info.  Add initializers.
4123         (xcoff_objfile_data_key): Move lower.  Change type.
4124         (XCOFF_DATA): Rewrite.
4125         (xcoff_free_info): Remove.
4126         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4127         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4128         (xcoff_initial_scan): Update.
4129
4130 2019-05-08  Tom Tromey  <tom@tromey.com>
4131
4132         * solib-svr4.c (struct svr4_info): Add initializers and
4133         destructor.
4134         <probes_table>: Now an htab_up.
4135         (solib_svr4_pspace_data): Change type.
4136         (free_probes_table): Simplify.
4137         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4138         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4139         (probes_table_remove_objfile_probes, register_solib_event_probe)
4140         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4141         (_initialize_svr4_solib): Update.
4142
4143 2019-05-08  Tom Tromey  <tom@tromey.com>
4144
4145         * remote.c (remote_pspace_data): Change type.
4146         (remote_pspace_data_cleanup): Remove.
4147         (get_remote_exec_file, set_pspace_remote_exec_file)
4148         (_initialize_remote): Update.
4149
4150 2019-05-08  Tom Tromey  <tom@tromey.com>
4151
4152         * breakpoint.c (breakpoint_objfile_key): Change type.
4153         (get_breakpoint_objfile_data): Update.
4154         (free_breakpoint_objfile_data): Remove.
4155         (_initialize_breakpoint): Update.
4156
4157 2019-05-08  Tom Tromey  <tom@tromey.com>
4158
4159         * linux-tdep.c (struct linux_info): Add initializers.
4160         (linux_inferior_data): Move.  Change type.
4161         (invalidate_linux_cache_inf): Update.
4162         (linux_inferior_data_cleanup): Remove.
4163         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4164
4165 2019-05-08  Tom Tromey  <tom@tromey.com>
4166
4167         * auxv.c (auxv_inferior_data): Move.  Change type.
4168         (auxv_inferior_data_cleanup): Remove.
4169         (invalidate_auxv_cache_inf): Rewrite.
4170         (get_auxv_inferior_data, _initialize_auxv): Update.
4171
4172 2019-05-08  Tom Tromey  <tom@tromey.com>
4173
4174         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4175         (symfile_debug_objfile_data_key): Change type.
4176         (symfile_debug_installed, debug_qf_has_symbols)
4177         (debug_qf_find_last_source_symtab)
4178         (debug_qf_forget_cached_source_info)
4179         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4180         (debug_qf_print_stats, debug_qf_dump)
4181         (debug_qf_expand_symtabs_for_function)
4182         (debug_qf_expand_all_symtabs)
4183         (debug_qf_expand_symtabs_with_fullname)
4184         (debug_qf_map_matching_symbols)
4185         (debug_qf_expand_symtabs_matching)
4186         (debug_qf_find_pc_sect_compunit_symtab)
4187         (debug_qf_map_symbol_filenames)
4188         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4189         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4190         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4191         (debug_sym_read_linetable, debug_sym_relocate): Update.
4192         (symfile_debug_free_objfile): Remove.
4193         (install_symfile_debug_logging, _initialize_symfile_debug):
4194         Update.
4195
4196 2019-05-08  Tom Tromey  <tom@tromey.com>
4197
4198         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4199         allocate_on_obstack.
4200         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4201         (get_dwarf2_per_objfile): Update.
4202         (set_dwarf2_per_objfile): Remove.
4203         (dwarf2_has_info, dwarf2_get_section_info): Update.
4204         (dwarf2_free_objfile): Remove.
4205         (_initialize_dwarf2_read): Update.
4206
4207 2019-05-08  Tom Tromey  <tom@tromey.com>
4208
4209         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4210         initializers.
4211         <unsupported_script_warning_printed,
4212         script_not_found_warning_printed>: Now bool.
4213         (auto_load_pspace_data): Change type.
4214         (~auto_load_pspace_info): Rename from
4215         auto_load_pspace_data_cleanup.
4216         (get_auto_load_pspace_data, init_loaded_scripts_info)
4217         (clear_section_scripts, maybe_print_unsupported_script_warning)
4218         (maybe_print_script_not_found_warning, _initialize_auto_load):
4219         Update.
4220
4221 2019-05-08  Tom Tromey  <tom@tromey.com>
4222
4223         * objfiles.c (objfile_pspace_info): Add destructor and
4224         initializers.
4225         (objfiles_pspace_data): Change type.
4226         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4227         (get_objfile_pspace_data): Update.
4228         (objfiles_bfd_data): Change type.
4229         (get_objfile_bfd_data): Update.
4230         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4231
4232 2019-05-08  Tom Tromey  <tom@tromey.com>
4233
4234         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4235         Change type.
4236         (get_catch_syscall_inferior_data): Update.
4237         (catch_syscall_inferior_data_cleanup): Remove.
4238         (_initialize_break_catch_syscall): Update.
4239
4240 2019-05-08  Tom Tromey  <tom@tromey.com>
4241
4242         * inflow.c (struct terminal_info): Add destructor and
4243         initializers.
4244         (inflow_inferior_data): Change type.
4245         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4246         (get_inflow_inferior_data, inflow_inferior_exit)
4247         (swap_terminal_info, _initialize_inflow): Update.
4248
4249 2019-05-08  Tom Tromey  <tom@tromey.com>
4250
4251         * target-dcache.c (target_dcache_cleanup): Remove.
4252         (target_dcache_aspace_key): Change type.
4253         (target_dcache_init_p, target_dcache_invalidate)
4254         (target_dcache_get, target_dcache_get_or_init)
4255         (_initialize_target_dcache): Update.
4256         * dcache.h (struct dcache_deleter): New.
4257
4258 2019-05-08  Tom Tromey  <tom@tromey.com>
4259
4260         * symtab.c (struct symbol_cache): Add destructor and
4261         initializers.
4262         (symbol_cache_key): Move.  Change type.
4263         (make_symbol_cache, free_symbol_cache): Remove.
4264         (get_symbol_cache): Update.
4265         (symbol_cache_cleanup): Remove.
4266         (ALL_PSPACES, symbol_cache_flush)
4267         (maintenance_print_symbol_cache)
4268         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4269         Update.
4270
4271 2019-05-08  Tom Tromey  <tom@tromey.com>
4272
4273         * symtab.c (struct main_info): Add destructor and initializers.
4274         (main_progspace_key): Move.  Change type.
4275         (get_main_info): Update.
4276         (main_info_cleanup): Remove.
4277         (_initialize_symtab): Update.
4278
4279 2019-05-08  Tom Tromey  <tom@tromey.com>
4280
4281         * registry.h (DECLARE_REGISTRY): Define the _key class.
4282
4283 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4284
4285         * NEWS: Merge two 'New commands' sections.
4286
4287 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4288
4289         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4290         parameter and use Ada language definition instead.
4291         (ada_val_print_ptr): Remove unused language parameter.
4292         (ada_val_print_num): Remove language parameter and use Ada language
4293         definition instead.
4294         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4295         parameter.
4296         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4297         parameter and use Ada language definition instead.
4298         (ada_val_print_1): Update all ada_val_print_xxx calls.
4299         Remove language parameter.
4300         (ada_val_print): Update ada_val_print_1 call.
4301
4302 2019-05-08  Tom Tromey  <tromey@adacore.com>
4303
4304         * remote.c (remote_hw_watchpoint_limit)
4305         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4306         Now static.
4307
4308 2019-05-08  Tom Tromey  <tromey@adacore.com>
4309
4310         * maint.c (_initialize_maint_cmds): Move initialization code to
4311         remote.c.
4312         (watchdog, show_watchdog): Move to remote.c.
4313         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4314         "watchdog" static.
4315         (_initialize_remote): Move initialization code from maint.c.
4316         * defs.h (watchdog): Don't declare.
4317
4318 2019-05-08  Tom Tromey  <tromey@adacore.com>
4319
4320         * tui/tui-interp.c: Include main.h.
4321         * interps.c: Include main.h.
4322         * main.h (interpreter_p): Declare.
4323         * defs.h (interpreter_p): Don't declare.
4324
4325 2019-05-08  Tom Tromey  <tromey@adacore.com>
4326
4327         * dwarf2loc.c: Include dwarf2read.h.
4328         * defs.h (read_unsigned_leb128): Don't declare.
4329         * dwarf2read.h (read_unsigned_leb128): Declare.
4330
4331 2019-05-08  Tom Tromey  <tromey@adacore.com>
4332
4333         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4334         method.
4335
4336 2019-05-08  Tom Tromey  <tromey@adacore.com>
4337
4338         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4339         when no wrap column is set.
4340
4341 2019-05-08  Tom Tromey  <tromey@adacore.com>
4342
4343         * c-lang.c (c_get_string): Handle non-C-style arrays.
4344
4345 2019-05-08  Tom Tromey  <tromey@adacore.com>
4346
4347         * typeprint.c (print_offset_data::update): Print the bit offset,
4348         not the number of bits remaining.
4349
4350 2019-05-08  Tom Tromey  <tromey@adacore.com>
4351
4352         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4353         padding at end of comment.
4354
4355 2019-05-08  Tom Tromey  <tromey@adacore.com>
4356
4357         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4358         Compare main types.
4359
4360 2019-05-06  Tom Tromey  <tom@tromey.com>
4361
4362         * common/scoped_mmap.c: Include common-defs.h.
4363         * common/scoped_mmap.h: Don't include config.h.
4364
4365 2019-05-04  Tom Tromey  <tom@tromey.com>
4366
4367         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4368         (struct aarch64_call_info): Add initializers.
4369         <si>: Now a std::vector.
4370         (pass_on_stack, aarch64_push_dummy_call): Update.
4371
4372 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4373             Tom Tromey  <tom@tromey.com>
4374
4375         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4376         (ppc_threads): Now a std::vector.  Now static.
4377         (hwdebug_find_thread_points_by_tid)
4378         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4379         Update.
4380
4381 2019-05-04  Tom Tromey  <tom@tromey.com>
4382
4383         * arc-tdep.c (arc_tdesc_init): Return bool.
4384
4385 2019-05-04  Tom Tromey  <tom@tromey.com>
4386
4387         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4388         Use gdb_assert_not_reached.
4389
4390 2019-05-04  Tom Tromey  <tom@tromey.com>
4391
4392         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4393         "false".
4394
4395 2019-05-04  Tom Tromey  <tom@tromey.com>
4396
4397         * arc-tdep.c (arc_tdesc_init): Use bool.
4398
4399 2019-05-04  Tom Tromey  <tom@tromey.com>
4400
4401         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4402
4403 2019-05-04  Tom Tromey  <tom@tromey.com>
4404
4405         * cli/cli-cmds.c (valid_command_p): Return bool.
4406
4407 2019-05-04  Tom Tromey  <tom@tromey.com>
4408
4409         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4410         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4411
4412 2019-05-04  Raul Tambre  <raul@tambre.ee>
4413
4414         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4415         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4416         operator for comparison.
4417
4418 2019-05-04  Tom Tromey  <tom@tromey.com>
4419
4420         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4421         (lookup_partial_symbol, print_partial_symbols)
4422         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4423         (psymbol_compare): Update.
4424         (add_psymbol_to_bcache): Clear the entire psymbol.
4425         (maintenance_check_psymtabs): Update.
4426         * psympriv.h (struct partial_symbol): Don't derive from
4427         general_symbol_info.
4428         <obj_section, unrelocated_address, address,
4429         set_unrelocated_address>: Update.
4430         <ginfo>: New member.
4431         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4432         (debug_names::write_psymbols): Update.
4433
4434 2019-05-04  Tom de Vries  <tdevries@suse.de>
4435
4436         * contrib/cc-with-tweaks.sh: Support -n arg.
4437
4438 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4439
4440         * corelow.c (core_target::detach): Ensure frame cache and
4441         register caches are cleared.
4442         inferior.c (exit_inferior_1): Likewise.
4443
4444 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4445             Tom Tromey  <tom@tromey.com>
4446
4447         * dictionary.c (collate_pending_symbols_by_language): Remove
4448         "struct" from foreach.
4449         * symtab.c (lookup_global_symbol_from_objfile)
4450         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4451         foreach.
4452         * ser-tcp.c (net_open): Remove "struct" from foreach.
4453         * objfiles.c (objfile_relocate, objfile_rebase)
4454         (objfile_has_symbols): Remove "struct" from foreach.
4455         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4456         from foreach.
4457         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4458         foreach.
4459         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4460         "struct" from foreach.
4461         * ada-lang.c (create_excep_cond_exprs)
4462         (ada_exception_catchpoint_cond_string): Remove "struct" from
4463         foreach.
4464
4465 2019-05-03  Tom Tromey  <tromey@adacore.com>
4466
4467         * ada-exp.y (convert_char_literal): Check suffix of each
4468         enumerator.
4469
4470 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4471
4472         PR ada/21406:
4473         * ada-exp.y (yywrap): Don't define.
4474         * ada-lex.l (%option): Add noyywrap
4475         (yywrap): Remove.
4476
4477 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4478
4479         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4480         _WIN32_WINNT to the XP level, unless already defined to a higher
4481         level.
4482
4483         * unittests/parse-connection-spec-selftests.c:
4484         * ser-tcp.c:
4485         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4486         override.
4487
4488         * symfile.c (find_separate_debug_file): Remove colon from the
4489         drive spec of DOS/Windows file names of the target, so that the
4490         file name produced from DEBUGDIR and the target's directory will
4491         be valid on DOS/Windows systems.
4492
4493 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4494
4495         * rust-lang.c (val_print_struct): Handle printing structures
4496         containing strings.
4497
4498 2019-05-02  Tom Tromey  <tromey@adacore.com>
4499
4500         * valarith.c (_initialize_valarith): Remove.
4501
4502 2019-05-01  Tom Tromey  <tromey@adacore.com>
4503
4504         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4505         bitfields.
4506
4507 2019-05-01  Tom Tromey  <tromey@adacore.com>
4508
4509         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4510         for big-endian copies.
4511
4512 2019-04-30  Ali Tamur  <tamur@google.com>
4513         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4514         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4515         (read_3_bytes): New function.
4516
4517 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4518
4519         * windows-nat.c (main_thread_id): Delete.
4520         (handle_output_debug_string): Replace main_thread_id by
4521         current_event.dwThreadId.
4522         (fake_create_process): Likewise.
4523         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4524         Do not set main_thread_id.
4525         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4526         current_event.dwThreadId.
4527         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4528
4529 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4530
4531         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4532         Use current_event.dwThreadId instead of main_thread_id.
4533
4534 2019-04-30  Tom Tromey  <tromey@adacore.com>
4535
4536         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4537         (create_excep_cond_exprs): Iterate over program spaces.
4538         (ada_exception_catchpoint_cond_string): Examine all minimal
4539         symbols for exception types.
4540
4541 2019-04-30  Tom Tromey  <tromey@adacore.com>
4542
4543         PR c++/24470:
4544         * dwarf2read.c (process_structure_scope): Handle case where type
4545         has template parameters but no symbol was created.
4546
4547 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4548             Chris January  <chris.january@arm.com>
4549
4550         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4551         qualifier.
4552         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4553
4554 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4555
4556         * f-typeprint.c (f_print_type): Update rules for printing
4557         whitespace.
4558         (f_type_print_varspec_suffix): Likewise.
4559
4560 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4561             Chris January  <chris.january@arm.com>
4562
4563         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4564         function arguments.
4565
4566 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4567
4568         * f-lang.c (build_fortran_types): Change name of void type to
4569         lower case.
4570         * f-typeprint.c (f_type_print_base): Print the name of the void
4571         type, rather than a fixed string.
4572         * f-valprint.c (f_decorations): Use lower case void string.
4573
4574 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4575             Chris January  <chris.january@arm.com>
4576
4577         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4578         types for Fortran.
4579
4580 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4581             Chris January  <chris.january@arm.com>
4582             David Lecomber  <david.lecomber@arm.com>
4583
4584         * f-exp.y (BINOP_INTRINSIC): New token.
4585         (exp): New parser rule handling BINOP_INTRINSIC.
4586         (f77_keywords): Add new builtin procedures.
4587         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4588         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4589         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4590         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4591         (print_unop_subexp_f): New function.
4592         (print_binop_subexp_f): New function.
4593         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4594         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4595         (dump_subexp_body_f): Likewise.
4596         (operator_check_f): Likewise.
4597         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4598         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4599
4600 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4601
4602         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4603         UNOP_KIND.
4604         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4605         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4606         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4607         (operator_length_f): New fuction.
4608         (print_subexp_f): New function.
4609         (op_name_f): New function.
4610         (dump_subexp_body_f): New function.
4611         (operator_check_f): New function.
4612         (exp_descriptor_f): Replace standard expression handling functions
4613         with new functions.
4614         * gdb/fortran-operator.def: New file.
4615         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4616         * gdb/std-operator.def: Remove UNOP_KIND.
4617
4618 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4619
4620         * std-operator.def: Remove unbalanced, stray double quote
4621         character.
4622
4623 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4624             Chris January  <chris.january@arm.com>
4625             Daniel Everett  <daniel.everett@arm.com>
4626             Nick Forrington  <nick.forrington@arm.com>
4627             Richard Bunt  <richard.bunt@arm.com>
4628
4629         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4630         of depth when printing anonymous structs or unions.
4631         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4632         Don't print either the top-level value, or the children if the
4633         max-depth is exceeded.
4634         (ppscm_print_children): When printing the key of a map, allow one
4635         extra level of depth.
4636         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4637         print either the top-level value, or the children if the max-depth
4638         is exceeded.
4639         (print_children): When printing the key of a map, allow one extra
4640         level of depth.
4641         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4642         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4643         (user_print_options): Initialise max_depth field.
4644         (val_print_scalar_or_string_type_p): New function.
4645         (val_print): Check to see if the max depth has been reached.
4646         (val_print_check_max_depth): Define new function.
4647         (show_print_max_depth): New function.
4648         (_initialize_valprint): Add 'print max-depth' option.
4649         * valprint.h (struct value_print_options) <max_depth>: New field.
4650         (val_print_check_max_depth): Declare new function.
4651         * NEWS: Document new feature.
4652
4653 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4654
4655         * ada-lang.c (ada_language_defn): Initialise new field.
4656         * c-lang.c (c_is_string_type_p): New function.
4657         (c_language_defn): Initialise new field.
4658         (cplus_language_defn): Initialise new field.
4659         (asm_language_defn): Initialise new field.
4660         (minimal_language_defn): Initialise new field.
4661         * c-lang.h (c_is_string_type_p): Declare new function.
4662         * d-lang.c (d_language_defn): Initialise new field.
4663         * f-lang.c (f_is_string_type_p): New function.
4664         (f_language_defn): Initialise new field.
4665         * go-lang.c (go_is_string_type_p): New function.
4666         (go_language_defn): Initialise new field.
4667         * language.c (default_is_string_type_p): New function.
4668         (unknown_language_defn): Initialise new field.
4669         (auto_language_defn): Initialise new field.
4670         * language.h (struct language_defn) <la_is_string_type_p>: New
4671         member variable.
4672         (default_is_string_type_p): Declare new function.
4673         * m2-lang.c (m2_language_defn): Initialise new field.
4674         * objc-lang.c (objc_language_defn): Initialise new field.
4675         * opencl-lang.c (opencl_language_defn): Initialise new field.
4676         * p-lang.c (pascal_is_string_type_p): New function.
4677         (pascal_language_defn): Initialise new field.
4678         * rust-lang.c (rust_is_string_type_p): New function.
4679         (rust_language_defn): Initialise new field.
4680
4681 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4682
4683         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4684         New field.
4685         * ada-lang.c (ada_language_defn): Initialise new field.
4686         * c-lang.c (c_language_defn): Likewise.
4687         (cplus_language_defn): Likewise.
4688         (asm_language_defn): Likewise.
4689         (minimal_language_defn): Likewise.
4690         * d-lang.c (d_language_defn): Likewise.
4691         * f-lang.c (f_language_defn): Likewise.
4692         * go-lang.c (go_language_defn): Likewise.
4693         * language.c (unknown_language_defn): Likewise.
4694         (auto_language_defn): Likewise.
4695         * m2-lang.c (m2_language_defn): Likewise.
4696         * objc-lang.c (objc_language_defn): Likewise.
4697         * opencl-lang.c (opencl_language_defn): Likewise.
4698         * p-lang.c (pascal_language_defn): Likewise.
4699         * rust-lang.c (rust_language_defn): Likewise.
4700
4701 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4702
4703         * ada-lang.c (ada_is_character_type): Change return type to bool.
4704         (ada_is_string_type): Likewise.
4705         * ada-lang.h (ada_is_character_type): Update declaration
4706         (ada_is_string_type): Likewise.
4707
4708 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4709
4710         Support style in 'frame|thread apply'
4711
4712         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4713         * record.c (record_start, record_stop): Update callers of
4714         execute_command_to_string with false.
4715         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4716         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4717         methods.
4718         (class string_file): New constructor with term_out parameter.
4719         Override methods term_out and can_emit_style_escape.  New member
4720         term_out.
4721         (class stdio_file): Override can_emit_style_escape.
4722         (class tee_file): Override term_out and can_emit_style_escape.
4723         * utils.h (can_emit_style_escape): Remove.
4724         * utils.c (can_emit_style_escape): Likewise.
4725         Update all callers of can_emit_style_escape (SOMESTREAM) to
4726         SOMESTREAM->can_emit_style_escape.
4727         * source-cache.c (source_cache::get_source_lines): Likewise.
4728         * stack.c (frame_apply_command_count): Call execute_command_to_string
4729         passing the term_out characteristic of the current gdb_stdout.
4730         * thread.c (thr_try_catch_cmd): Likewise.
4731         * top.c (execute_command_to_string): pass term_out parameter
4732         to construct the string_file for the command output.
4733         * ui-file.c (term_cli_styling): New function (most code moved
4734         from utils.c can_emit_style_escape).
4735         (string_file::string_file, string_file::can_emit_style_escape,
4736         stdio_file::can_emit_style_escape, tee_file::term_out,
4737         tee_file::can_emit_style_escape): New functions.
4738
4739 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4740
4741         * NEWS: Mention the new set|show may-call-functions.
4742         * infcall.c (may_call_functions_p): New variable.
4743         (show_may_call_functions_p): New function.
4744         (call_function_by_hand_dummy): Throws an error if not
4745         may-call-functions.
4746         (_initialize_infcall): Call add_setshow_boolean_cmd for
4747         may-call-functions.
4748
4749 2019-04-25  Keith Seitz  <keiths@redhat.com>
4750
4751         PR c++/24367
4752         * cp-support.c (inspect_type): Don't attempt substitutions
4753         of symbol with the same name.
4754
4755 2019-04-25  Tom Tromey  <tromey@adacore.com>
4756
4757         PR gdb/24475:
4758         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4759         static.
4760
4761 2019-04-25  Tom Tromey  <tromey@adacore.com>
4762
4763         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4764         rvalue reference.
4765         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4766         (gdb_xml_parser::parse): Use std::move.
4767         * python/python-internal.h (gdbpy_convert_exception): Take a const
4768         reference.
4769         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4770         std::move.
4771         * python/py-utils.c (gdbpy_convert_exception): Take a const
4772         reference.
4773         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4774         Use std::move.
4775         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4776         Use std::move.
4777         * mi/mi-main.c (mi_print_exception): Take a const reference.
4778         * main.c (handle_command_errors): Take a const reference.
4779         * linespec.c (parse_linespec): Use std::move.
4780         * infcall.c (run_inferior_call): Use std::move.
4781         (call_function_by_hand_dummy): Use std::move.
4782         * exec.c (try_open_exec_file): Use std::move.
4783         * exceptions.h (exception_print, exception_fprintf)
4784         (exception_print_same): Update.
4785         * exceptions.c (print_exception, exception_print)
4786         (exception_fprintf, exception_print_same): Change parameters to
4787         const reference.
4788         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4789         * common/new-op.c: Use std::move.
4790         * common/common-exceptions.h (struct gdb_exception): Add move
4791         constructor.
4792         (struct gdb_exception_error, struct gdb_exception_quit, struct
4793         gdb_quit_bad_alloc): Change constructor to move constructor.
4794         (throw_exception): Change parameter to rvalue reference.
4795         * common/common-exceptions.c (throw_exception): Take rvalue
4796         reference.
4797         * cli/cli-interp.c (safe_execute_command): Use std::move.
4798         * breakpoint.c (insert_bp_location, location_to_sals): Use
4799         std::move.
4800
4801 2019-04-25  Tom Tromey  <tromey@adacore.com>
4802
4803         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4804         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4805         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4806         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4807         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4808         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4809         guile/scm-value.c: Use unpack.
4810         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4811         gdbscm_gdb_exception.
4812         (gdbscm_throw_gdb_exception): Likewise.
4813         (struct gdbscm_gdb_exception): New.
4814         (unpack): New function.
4815         (gdbscm_wrap): Use unpack.
4816
4817 2019-04-25  Tom Tromey  <tromey@adacore.com>
4818
4819         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4820         (gdb_rl_callback_handler): Use std::move.
4821         * common/common-exceptions.h (struct gdb_exception): Add move
4822         assignment operator.
4823         (throw_exception_sjlj): Change "exception" to const reference.
4824         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4825         (throw_exception_sjlj): Change "exception" to const reference.
4826
4827 2019-04-25  Tom Tromey  <tromey@adacore.com>
4828
4829         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4830         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4831         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4832         Update.
4833         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4834         Update.
4835         * mi/mi-interp.c (mi_interp::exec): Update.
4836         * linespec.c (parse_linespec): Update.
4837         * infcall.c (run_inferior_call): Update.
4838         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4839         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4840         (gdbscm_lookup_global_symbol): Update.
4841         * guile/scm-param.c (gdbscm_parameter_value): Update.
4842         * guile/scm-frame.c (gdbscm_frame_read_register)
4843         (gdbscm_frame_read_var): Update.
4844         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4845         * exec.c (try_open_exec_file): Update.
4846         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4847         (gdb_rl_callback_handler): Update.
4848         * common/common-exceptions.h (exception_none): Don't declare.
4849         * common/common-exceptions.c (exception_none): Don't define.
4850         (struct catcher) <exception>: Update.
4851         * cli/cli-interp.c (safe_execute_command): Update.
4852         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4853
4854 2019-04-25  Ali Tamur  <tamur@google.com>
4855
4856         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4857         (read_attribute_value): Likewise.
4858         (dwarf2_read_addr_index): Update comment.
4859         (read_str_index): Add DW_FORM_strx.
4860         (dwarf2_string_attr): Likewise.
4861         (dwarf2_const_value_attr): Likewise.
4862         (dump_die_shallow): Likewise.
4863         (dwarf2_fetch_constant_bytes): Likewise.
4864         (skip_form_bytes): Likewise.
4865         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4866
4867 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4868
4869         PR corefiles/11608
4870         PR corefiles/18187
4871         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4872         OFFSET.  Verify if current mapping contains an ELF header.
4873         (linux_find_memory_regions_full): Adjust call to
4874         dump_mapping_p.
4875
4876 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4877             Kang Li <kanglictf@gmail.com>
4878
4879         PR gdb/21600
4880
4881         * dwarf2-frame.c (read_initial_length): Be consistent about using
4882         unsigned representation of length.
4883         (decode_frame_entry_1): Likewise.  Check for wraparound of
4884         end pointer as well as buffer overflow.
4885
4886 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4887
4888         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4889         "vq".
4890
4891 2019-04-24  Tom Tromey  <tromey@adacore.com>
4892
4893         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4894
4895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4896
4897         * s12z-tdep.c (s12z_unwind_pc): Delete.
4898         (s12z_unwind_sp): Delete.
4899         (s12z_gdbarch_init): Don't register deleted functions with
4900         gdbarch.
4901
4902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4903
4904         * rl78-tdep.c (rl78_unwind_sp): Delete.
4905         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4906
4907 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4908
4909         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4910         (xstormy16_unwind_pc): Delete.
4911         (xstormy16_dummy_id): Delete.
4912         (xstormy16_gdbarch_init): Don't register deleted functions with
4913         gdbarch.
4914
4915 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4916
4917         * vax-tdep.c (vax_unwind_pc): Delete.
4918         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4919
4920 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4921
4922         * v850-tdep.c (v850_unwind_sp): Delete.
4923         (v850_unwind_pc): Delete.
4924         (v850_dummy_id): Delete.
4925         (v850_gdbarch_init): Don't register deleted functions with
4926         gdbarch.
4927
4928 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4929
4930         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4931         (tilegx_unwind_pc): Delete.
4932         (tilegx_unwind_dummy_id): Delete.
4933         (tilegx_gdbarch_init): Don't register deleted functions with
4934         gdbarch.
4935
4936 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4937
4938         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4939         (tic6x_dummy_id): Delete.
4940         (tic6x_gdbarch_init): Don't register deleted functions with
4941         gdbarch.
4942
4943 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4944
4945         * sparc-tdep.c (sparc_unwind_pc): Delete.
4946         (sparc32_gdbarch_init): Don't register deleted function with
4947         gdbarch.
4948
4949 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4950
4951         * sh-tdep.c (sh_unwind_sp): Delete.
4952         (sh_unwind_pc): Delete.
4953         (sh_dummy_id): Delete.
4954         (sh_gdbarch_init): Don't register deleted functions with
4955         gdbarch.
4956
4957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4958
4959         * score-tdep.c (score_unwind_sp): Delete.
4960         (score_unwind_pc): Delete.
4961         (score_dummy_id): Delete.
4962         (score_gdbarch_init): Don't register deleted functions with
4963         gdbarch.
4964
4965 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4966
4967         * rx-tdep.c (rx_unwind_pc): Delete.
4968         (rx_unwind_sp): Delete.
4969         (rx_dummy_id): Delete.
4970         (rx_gdbarch_init): Don't register deleted functions with
4971         gdbarch.  Update comment.
4972
4973 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4974
4975         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4976         (rs6000_dummy_id): Delete.
4977         (rs6000_gdbarch_init): Don't register deleted functions with
4978         gdbarch.
4979
4980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4981
4982         * or1k-tdep.c (or1k_dummy_id): Delete.
4983         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4984
4985 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4986
4987         * nios2-tdep.c (nios2_dummy_id): Delete.
4988         (nios2_unwind_sp): Delete.
4989         (nios2_gdbarch_init): Don't register deleted functions with
4990         gdbarch.
4991
4992 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4993
4994         * nds32-tdep.c (nds32_dummy_id): Delete.
4995         (nds32_unwind_pc): Delete.
4996         (nds32_unwind_sp): Delete.
4997         (nds32_gdbarch_init): Don't register deleted functions with
4998         gdbarch.
4999
5000 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5001
5002         * msp430-tdep.c (msp430_unwind_pc): Delete.
5003         (msp430_unwind_sp): Delete.
5004         (msp430_dummy_id): Delete.
5005         (msp430_gdbarch_init): Don't register deleted functions with
5006         gdbarch.
5007
5008 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5009
5010         * moxie-tdep.c (moxie_unwind_sp): Delete.
5011         (moxie_unwind_pc): Delete.
5012         (moxie_dummy_id): Delete.
5013         (moxie_gdbarch_init): Don't register deleted functions with
5014         gdbarch.
5015
5016 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5017
5018         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5019         (mn10300_unwind_pc): Delete.
5020         (mn10300_unwind_sp): Delete.
5021         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5022         mn10300_unwind_sp.
5023         (mn10300_frame_unwind_init): Don't register deleted functions with
5024         gdbarch.
5025
5026 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5027
5028         * mep-tdep.c (mep_unwind_pc): Delete.
5029         (mep_unwind_sp): Delete.
5030         (mep_dummy_id): Delete.
5031         (mep_gdbarch_init): Don't register deleted functions with
5032         gdbarch.
5033
5034 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5035
5036         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5037         (m68hc11_unwind_sp): Delete.
5038         (m68hc11_gdbarch_init): Don't register deleted functions with
5039         gdbarch.
5040
5041 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5042
5043         * m32r-tdep.c (m32r_unwind_sp): Delete.
5044         (m32r_unwind_pc): Delete.
5045         (m32r_dummy_id): Delete.
5046         (m32r_gdbarch_init): Don't register deleted functions with
5047         gdbarch.
5048
5049 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5050
5051         * m32c-tdep.c (m32c_unwind_pc): Delete.
5052         (m32c_unwind_sp): Delete.
5053         (m32c_dummy_id): Delete.
5054         (m32c_gdbarch_init): Don't register deleted functions with
5055         gdbarch.
5056
5057 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5058
5059         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5060         (lm32_unwind_pc): Delete.
5061         (lm32_dummy_id): Delete.
5062         (lm32_gdbarch_init): Don't register deleted functions with
5063         gdbarch.
5064
5065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5066
5067         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5068         (iq2000_unwind_pc): Delete.
5069         (iq2000_dummy_id): Delete.
5070         (iq2000_gdbarch_init): Don't register deleted functions with
5071         gdbarch.
5072
5073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5074
5075         * nds32-tdep.c (nds32_type_align): Delete.
5076         (nds32_push_dummy_call): Use type_align instead.
5077
5078 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5079
5080         * arm-tdep.c (arm_type_align): Only handle vector override case.
5081         (arm_push_dummy_call): Use type_align.
5082         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5083
5084 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5085
5086         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5087         case.
5088         (pass_on_stack): Use type_align.
5089         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5090         function.
5091
5092 2019-04-23  Tom Tromey  <tromey@adacore.com>
5093
5094         * dwarf2read.c (line_header::file_name_at): Remove unused
5095         overload.
5096
5097 2019-04-23  Tom de Vries  <tdevries@suse.de>
5098
5099         PR gdb/24438
5100         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5101         invocation.
5102
5103
5104 2019-03-27  Ali Tamur  <tamur@google.com>
5105
5106         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5107         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5108         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5109         (dwarf_expr_context::get_addr_index): Likewise
5110         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5111         (symbol_needs_eval_context::get_addr_index): Likewise
5112         (disassemble_dwarf_expression): Add DW_OP_addrx
5113         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5114         (read_cutu_die_from_dwo): Update comment
5115         (skip_one_die): Add DW_FORM_addrx
5116         (read_attribute_value): Likewise
5117         (var_decode_location): Add DW_OP_addrx
5118         (dwarf2_const_value_attr): Add DW_FORM_addrx
5119         (dump_die_shallow): Likewise
5120         (dwarf2_fetch_constant_bytes): Likewise
5121         (decode_locdesc): Add DW_OP_addrx
5122         (skip_form_bytes): Add DW_FORM_addrx
5123
5124 2019-04-22  Ali Tamur  <tamur@google.com>
5125
5126         * MAINTAINERS (Write After Approval): Add self.
5127
5128 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5129
5130         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5131         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5132         (open_symbol_file_object): Likewise.
5133         (svr4_default_sos): Add info parameter.
5134         (svr4_read_so_list): Likewise.
5135         (svr4_current_sos_direct): Adjust functions calls to pass down
5136         info.
5137         (svr4_current_sos_1): Add info parameter.
5138         (svr4_current_sos): Call get_svr4_info, pass info down to
5139         svr4_current_sos_1.
5140         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5141         get_svr4_info.
5142         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5143         get_svr4_info.
5144         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5145         to get_svr4_info.
5146         (probes_table_remove_objfile_probes): Likewise.
5147         (register_solib_event_probe): Add info parameter.
5148         (solist_update_incremental): Pass info parameter down to
5149         svr4_read_so_list.
5150         (disable_probes_interface): Add info parameter.
5151         (svr4_handle_solib_event): Pass current_program_space to
5152         get_svr4_info.  Adjust disable_probes_interface cleanup.
5153         (svr4_create_probe_breakpoints): Add info parameter, pass it
5154         down to register_solib_event_probe.
5155         (svr4_create_solib_event_breakpoints): Add info parameter,
5156         pass it down to svr4_create_probe_breakpoints.
5157         (enable_break): Pass info down to
5158         svr4_create_solib_event_breakpoints.
5159         (svr4_solib_create_inferior_hook): Pass current_program_space to
5160         get_svr4_info.
5161         (svr4_clear_solib): Likewise.
5162
5163 2019-04-22  Pedro Alves  <palves@redhat.com>
5164
5165         * solib-svr4.c (svr4_free_objfile_observer): New.
5166         (probe_and_action::objfile): New field.
5167         (probes_table_htab_remove_objfile_probes)
5168         (probes_table_remove_objfile_probes): New functions.
5169         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5170         in the new probe_and_action.  Don't store the probe in 'lookup'.
5171         (svr4_create_probe_breakpoints): Pass objfile to
5172         register_solib_event_probe.
5173         (_initialize_svr4_solib): Register a free_objfile observer.
5174
5175 2019-04-19  Tom Tromey  <tom@tromey.com>
5176
5177         * common/queue.h: Remove.
5178
5179 2019-04-19  Tom Tromey  <tom@tromey.com>
5180
5181         * event-loop.c: Don't include "common/queue.h".
5182
5183 2019-04-19  Tom Tromey  <tom@tromey.com>
5184
5185         * remote.c (remote_target): Use delete.
5186         * remote-notif.h: Include <list>, not "common/queue.h".
5187         (notif_client_p): Remove typedef.
5188         (remote_notif_state): Add constructor, destructor, initializer.
5189         <notif_queue>: Now a std::list.
5190         (remote_notif_state_xfree): Don't declare.
5191         * remote-notif.c (remote_notif_process, handle_notification)
5192         (remote_notif_state_allocate): Update.
5193         (~remote_notif_state): Rename from remote_notif_state_xfree.
5194
5195 2019-04-19  Tom Tromey  <tom@tromey.com>
5196
5197         * symfile.c (reread_symbols): Update.
5198         * objfiles.c (objfile_register_static_link)
5199         (objfile_lookup_static_link): Update
5200         (~objfile) Don't delete static_links.
5201         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5202
5203 2019-04-19  Tom Tromey  <tom@tromey.com>
5204
5205         * type-stack.h (struct type_stack) <insert>: Constify string.
5206         * type-stack.c (type_stack::insert): Constify string.
5207         * gdbtypes.h (lookup_template_type): Update.
5208         (address_space_name_to_int): Update.
5209         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5210         const.
5211         (lookup_template_type): Make name const.
5212         * c-exp.y: Update rules.
5213         (lex_one_token, classify_name, classify_inner_name)
5214         (c_print_token): Update.
5215         * p-exp.y: Update rules.
5216         (yylex): Update.
5217         * f-exp.y: Update rules.
5218         (yylex): Update.
5219         * d-exp.y: Update rules.
5220         (lex_one_token, classify_name, classify_inner_name): Update.
5221         * parse.c (write_dollar_variable, copy_name): Return std::string.
5222         * parser-defs.h (copy_name): Change return type.
5223         * m2-exp.y: Update rules.
5224         (yylex): Update.
5225         * go-exp.y (lex_one_token): Update.
5226         Update rules.
5227         (classify_unsafe_function, classify_packaged_name)
5228         (classify_name, yylex): Update.
5229
5230 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5231
5232         * configure.ac: add --enable-source-highlight switch.
5233         * configure: Regenerate.
5234         * top.c (print_gdb_version): plumb --enable-source-highlight
5235         status to "show configuration".
5236
5237 2019-04-19  Tom Tromey  <tromey@adacore.com>
5238
5239         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5240         Check ADA_TYPE_P.
5241         (empty_record, ada_template_to_fixed_record_type_1)
5242         (template_to_static_fixed_type)
5243         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5244         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5245         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5246         macros.
5247
5248 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5249
5250         PR symtab/24423:
5251         * source.c (print_source_lines_base): Advance "iter" when a
5252         control character is seen.
5253
5254 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5255
5256         * inferior.h (struct infcall_suspend_state_deleter):
5257         Catch exception in destructor to avoid crash.
5258
5259 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5260
5261         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5262         close to the add_com "shell".
5263
5264 2019-04-18  Tom Tromey  <tromey@adacore.com>
5265
5266         * process-stratum-target.h (class process_stratum_target)
5267         <stratum>: Add "final".
5268
5269 2019-04-17  Tom Tromey  <tromey@adacore.com>
5270
5271         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5272         against nullptr before use.
5273
5274 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5275
5276         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5277
5278 2019-04-17  Jim Wilson  <jimw@sifive.com>
5279             Andrew Burgess  <andrew.burgess@embecosm.com>
5280
5281         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5282         code read might fail, assume 4-byte breakpoint in that case.
5283
5284 2019-04-15  Leszek Swirski  <leszeks@google.com>
5285
5286         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5287         rather than a hand-rolled POD check when checking for forced MEMORY
5288         classification.
5289
5290 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5291
5292         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5293         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5294         function.
5295         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5296         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5297         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5298         declaration.
5299
5300 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5301
5302         * aarch64-linux-nat.c
5303         (aarch64_linux_nat_target::thread_architecture): Add override.
5304         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5305         each VQ.
5306
5307 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5308
5309         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5310
5311 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5312
5313         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5314         target types of size 96-bits, add some additional comments, and
5315         check that the builtin type we found was the correct size.
5316
5317 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5318
5319         * utils.c (prompt_for_continue): Don't restore the styling at the
5320         end, as applied_style has the wrong value.  This fixes styling in
5321         long lists of file names that are interrupted by the "Continue?"
5322         prompt.
5323
5324 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5325
5326         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5327         * c-lang.c (c_language_defn): Likewise.
5328         (cplus_language_defn): Likewise.
5329         (asm_language_defn): Likewise.
5330         (minimal_language_defn): Likewise.
5331         * d-lang.c (d_language_defn): Likewise.
5332         * f-lang.c (f_language_defn): Likewise.
5333         * go-lang.c (go_language_defn): Likewise.
5334         * language.c (unknown_language_defn): Likewise.
5335         (auto_language_defn): Likewise.
5336         * language.h (struct language_defn): Remove la_magic field.
5337         (LANG_MAGIC): Delete.
5338         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5339         * objc-lang.c (objc_language_defn): Likewise.
5340         * opencl-lang.c (opencl_language_defn): Likewise.
5341         * p-lang.c (pascal_language_defn): Likewise.
5342         * rust-lang.c (rust_language_defn): Likewise.
5343
5344 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5345
5346         * riscv-tdep.c (riscv_type_align): New function.
5347         (riscv_type_alignment): Delete.
5348         (riscv_arg_location): Use 'type_align'.
5349         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5350
5351 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5352
5353         * gdbtypes.c (type_align): A struct with no non-static fields also
5354         has alignment of 1.
5355
5356 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5357
5358         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5359         component to 0.
5360         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5361         member.
5362         (riscv_struct_info::analyse): New implementation using new
5363         analyse_inner member function.
5364         (riscv_struct_info::field_offset): New member function.
5365         (riscv_struct_info::m_offsets): New member variable.
5366         (riscv_struct_info::analyse_inner): New private member function,
5367         takes the old implementation of riscv_struct_info::analyse but
5368         extended to track field offsets.
5369         (riscv_call_arg_struct): Update the struct folding special cases
5370         to handle cases where empty C++ structs, which are non-zero
5371         length, are found.
5372         (riscv_arg_location): Initialise the length of each location, a
5373         non-zero length now indicates the location is in use.
5374         (riscv_push_dummy_call): Allow for the first location having a
5375         non-zero offset when setting up arguments.
5376         (riscv_return_value): Likewise, but for return values.
5377
5378 2019-04-11  Tom Tromey  <tromey@adacore.com>
5379
5380         * utils.c (internal_vproblem): Make "msg" const.
5381
5382 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5383
5384         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5385         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5386         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5387         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5388
5389 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5390
5391         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5392         function.
5393         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5394         of amd64_collect_native_gregset.
5395         (amd64_linux_nat_target::store_registers): Likewise.
5396
5397 2019-04-10  Tom Tromey  <tom@tromey.com>
5398
5399         * symtab.c (lookup_global_symbol_from_objfile)
5400         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5401         * objfiles.h (class separate_debug_iterator): New.
5402         (class separate_debug_range): New.
5403         (struct objfile) <separate_debug_objfiles>: New method.
5404         (objfile_separate_debug_iterate): Don't declare.
5405         * objfiles.c (separate_debug_iterator::operator++): Rename from
5406         objfile_separate_debug_iterate.
5407         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5408         iterator.
5409         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5410         iterator.
5411
5412 2019-04-10  Tom Tromey  <tom@tromey.com>
5413
5414         * symfile.c (reread_symbols): Remove old comment.
5415         * objfiles.c (free_all_objfiles): Fix a typo.
5416
5417 2019-04-10  Tom Tromey  <tom@tromey.com>
5418
5419         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5420         * minsyms.c (lookup_minimal_symbol): Use foreach.
5421         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5422         (lookup_minimal_symbol_solib_trampoline): Likewise.
5423         * symfile.c (reread_symbols): Use foreach.
5424
5425 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5426             Tom Tromey  <tromey@adacore.com>
5427
5428         PR rust/24414:
5429         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5430         (rust_lex_int_test): Change "value" to be LONGEST.
5431         (rust_lex_tests): Add test for long integer literal.
5432
5433 2019-04-09  Tom Tromey  <tromey@adacore.com>
5434
5435         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5436         to bool.
5437         (extended_remote_target::attach): Update.
5438         (remote_target::remote_notice_new_inferior): Update.
5439         (remote_target::add_current_inferior_and_thread): Update.
5440         * inferior.c (exit_inferior_1): Use "false".
5441         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5442
5443 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5444
5445         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5446         the "start" command.
5447
5448 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5449
5450         * python/py-inferior.c (infpy_thread_from_thread_handle):
5451         Adjust comments to reflect renaming of thread_from_thread_handle
5452         to thread_from_handle.  Adjust keywords.  Fix type error message.
5453         (inferior_object_methods): Add thread_from_handle.  Retain
5454         thread_from_thread_handle, but mark it as deprecated.
5455
5456 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5457
5458         * gdbthread.h (find_thread_by_handle): Revise declaration.
5459         * thread.c (find_thread_by_handle): Likewise.  Adjust
5460         implementation too.
5461         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5462         support for buffer objects as handles.
5463
5464 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5465
5466         * python/py-infthread.c (thpy_thread_handle): New function.
5467         (thread_object_methods): Register thpy_thread_handle.
5468
5469 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5470
5471         * gdbthread.h (thread_to_thread_handle): Declare.
5472         * thread.c (gdbtypes.h): Include.
5473         (thread_to_thread_handle): New function.
5474
5475         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5476         (target_thread_info_to_thread_handle): Declare.
5477         * target.c (target_thread_info_to_thread_handle): New function.
5478         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5479         * target-delegates.c: Regenerate.
5480
5481         * linux-thread-db.c (class thread_db_target): Add method
5482         thread_info_to_thread_handle.
5483         (thread_db_target::thread_info_to_thread_handle): Define.
5484         * remote.c (class remote_target): Add new method
5485         thread_info_to_thread_handle.
5486         (remote_target::thread_info_to_thread_handle): Define.
5487
5488 2019-04-08  Pedro Alves  <palves@redhat.com>
5489
5490         * common/common-exceptions.c (throw_exception): Don't create
5491         named object to throw; throw directly.
5492         (throw_it): Likewise.  Don't initialize gdb_exception::message
5493         here, with new; pass FMT and AP to the ctor instead.
5494         * common/common-exceptions.h: Include <string>.
5495         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5496         const char *, va_list)): New ctor.  Use std::make_shared.
5497         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5498         errors)): Delete.
5499         (gdb_exception_error::gdb_exception_error(enum errors, const char
5500         *, va_list)): New.
5501         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5502         Add assertion.
5503         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5504         errors)): Delete.
5505         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5506         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5507         Add assertion.
5508
5509 2019-04-08  Tom Tromey  <tom@tromey.com>
5510
5511         * valops.c (value_rtti_indirect_type): Replace throw_exception
5512         with throw.
5513         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5514         with throw.
5515         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5516         throw.
5517         * target.c (target_translate_tls_address): Replace throw_exception
5518         with throw.
5519         * stack.c (frame_apply_command_count): Replace throw_exception
5520         with throw.
5521         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5522         throw.
5523         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5524         with throw.
5525         * rs6000-tdep.c (rs6000_frame_cache)
5526         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5527         * remote.c: Replace throw_exception with throw.
5528         * record-full.c (record_full_message, record_full_wait_1)
5529         (record_full_restore): Replace throw_exception with throw.
5530         * record-btrace.c:
5531         (get_thread_current_frame_id, record_btrace_start_replaying)
5532         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5533         (cmd_record_btrace_start): Replace throw_exception with throw.
5534         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5535         throw.
5536         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5537         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5538         * linespec.c:
5539         (find_linespec_symbols): Replace throw_exception with throw.
5540         * infrun.c (displaced_step_prepare, resume): Replace
5541         throw_exception with throw.
5542         * infcmd.c (post_create_inferior): Replace throw_exception with
5543         throw.
5544         * inf-loop.c (inferior_event_handler): Replace throw_exception
5545         with throw.
5546         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5547         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5548         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5549         (get_prev_frame_always, get_frame_pc_if_available)
5550         (get_frame_address_in_block_if_available, get_frame_language):
5551         Replace throw_exception with throw.
5552         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5553         throw_exception with throw.
5554         * eval.c (fetch_subexp_value, evaluate_var_value)
5555         (evaluate_funcall, evaluate_subexp_standard): Replace
5556         throw_exception with throw.
5557         * dwarf2loc.c (call_site_find_chain)
5558         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5559         Replace throw_exception with throw.
5560         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5561         with throw.
5562         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5563         throw.
5564         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5565         * completer.c (complete_line_internal): Replace throw_exception
5566         with throw.
5567         * compile/compile-object-run.c (compile_object_run): Replace
5568         throw_exception with throw.
5569         * cli/cli-script.c (process_next_line): Replace throw_exception
5570         with throw.
5571         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5572         (btrace_enable, btrace_maint_update_pt_packets): Replace
5573         throw_exception with throw.
5574         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5575         throw_exception with throw.
5576         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5577         throw_exception with throw.
5578         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5579         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5580         * aarch64-tdep.c (aarch64_make_prologue_cache)
5581         (aarch64_make_stub_cache): Replace throw_exception with throw.
5582
5583 2019-04-08  Tom Tromey  <tom@tromey.com>
5584
5585         * common/common-exceptions.c (throw_exception): Rename from
5586         throw_exception_cxx.  Remove old copy.  Make argument const.
5587         (throw_it): Create and throw exception objects directly.
5588         * common/common-exceptions.h (throw_exception): Make argument
5589         const.
5590         (struct gdb_exception_error): Add constructor.
5591         (struct gdb_exception_quit): Add constructor.
5592
5593 2019-04-08  Tom Tromey  <tom@tromey.com>
5594
5595         * common/common-exceptions.h (exception_rethrow): Don't declare.
5596         (TRY_SJLJ): Update comment.
5597         (TRY, CATCH, END_CATCH): Remove.
5598         * common/common-exceptions.c (exception_rethrow): Remove.
5599
5600 2019-04-08  Tom Tromey  <tom@tromey.com>
5601
5602         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5603         Remove.
5604         (gdb_exception_error): Rename from
5605         gdb_exception_RETURN_MASK_ERROR.
5606         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5607         (gdb_quit_bad_alloc): Update.
5608         * aarch64-tdep.c: Update.
5609         * ada-lang.c: Update.
5610         * ada-typeprint.c: Update.
5611         * ada-valprint.c: Update.
5612         * amd64-tdep.c: Update.
5613         * arch-utils.c: Update.
5614         * break-catch-throw.c: Update.
5615         * breakpoint.c: Update.
5616         * btrace.c: Update.
5617         * c-varobj.c: Update.
5618         * cli/cli-cmds.c: Update.
5619         * cli/cli-interp.c: Update.
5620         * cli/cli-script.c: Update.
5621         * common/common-exceptions.c: Update.
5622         * common/new-op.c: Update.
5623         * common/selftest.c: Update.
5624         * compile/compile-c-symbols.c: Update.
5625         * compile/compile-cplus-symbols.c: Update.
5626         * compile/compile-object-load.c: Update.
5627         * compile/compile-object-run.c: Update.
5628         * completer.c: Update.
5629         * corelow.c: Update.
5630         * cp-abi.c: Update.
5631         * cp-support.c: Update.
5632         * cp-valprint.c: Update.
5633         * darwin-nat.c: Update.
5634         * disasm-selftests.c: Update.
5635         * dtrace-probe.c: Update.
5636         * dwarf-index-cache.c: Update.
5637         * dwarf-index-write.c: Update.
5638         * dwarf2-frame-tailcall.c: Update.
5639         * dwarf2-frame.c: Update.
5640         * dwarf2loc.c: Update.
5641         * dwarf2read.c: Update.
5642         * eval.c: Update.
5643         * event-loop.c: Update.
5644         * event-top.c: Update.
5645         * exec.c: Update.
5646         * f-valprint.c: Update.
5647         * fbsd-tdep.c: Update.
5648         * frame-unwind.c: Update.
5649         * frame.c: Update.
5650         * gdbtypes.c: Update.
5651         * gnu-v3-abi.c: Update.
5652         * guile/guile-internal.h: Update.
5653         * guile/scm-block.c: Update.
5654         * guile/scm-breakpoint.c: Update.
5655         * guile/scm-cmd.c: Update.
5656         * guile/scm-disasm.c: Update.
5657         * guile/scm-frame.c: Update.
5658         * guile/scm-lazy-string.c: Update.
5659         * guile/scm-math.c: Update.
5660         * guile/scm-param.c: Update.
5661         * guile/scm-ports.c: Update.
5662         * guile/scm-pretty-print.c: Update.
5663         * guile/scm-symbol.c: Update.
5664         * guile/scm-symtab.c: Update.
5665         * guile/scm-type.c: Update.
5666         * guile/scm-value.c: Update.
5667         * i386-linux-tdep.c: Update.
5668         * i386-tdep.c: Update.
5669         * inf-loop.c: Update.
5670         * infcall.c: Update.
5671         * infcmd.c: Update.
5672         * infrun.c: Update.
5673         * jit.c: Update.
5674         * language.c: Update.
5675         * linespec.c: Update.
5676         * linux-fork.c: Update.
5677         * linux-nat.c: Update.
5678         * linux-tdep.c: Update.
5679         * linux-thread-db.c: Update.
5680         * main.c: Update.
5681         * mi/mi-cmd-break.c: Update.
5682         * mi/mi-cmd-stack.c: Update.
5683         * mi/mi-interp.c: Update.
5684         * mi/mi-main.c: Update.
5685         * objc-lang.c: Update.
5686         * p-valprint.c: Update.
5687         * parse.c: Update.
5688         * ppc-linux-tdep.c: Update.
5689         * printcmd.c: Update.
5690         * python/py-arch.c: Update.
5691         * python/py-breakpoint.c: Update.
5692         * python/py-cmd.c: Update.
5693         * python/py-finishbreakpoint.c: Update.
5694         * python/py-frame.c: Update.
5695         * python/py-framefilter.c: Update.
5696         * python/py-gdb-readline.c: Update.
5697         * python/py-inferior.c: Update.
5698         * python/py-infthread.c: Update.
5699         * python/py-lazy-string.c: Update.
5700         * python/py-linetable.c: Update.
5701         * python/py-objfile.c: Update.
5702         * python/py-param.c: Update.
5703         * python/py-prettyprint.c: Update.
5704         * python/py-progspace.c: Update.
5705         * python/py-record-btrace.c: Update.
5706         * python/py-record.c: Update.
5707         * python/py-symbol.c: Update.
5708         * python/py-type.c: Update.
5709         * python/py-unwind.c: Update.
5710         * python/py-utils.c: Update.
5711         * python/py-value.c: Update.
5712         * python/python.c: Update.
5713         * record-btrace.c: Update.
5714         * record-full.c: Update.
5715         * remote-fileio.c: Update.
5716         * remote.c: Update.
5717         * riscv-tdep.c: Update.
5718         * rs6000-aix-tdep.c: Update.
5719         * rs6000-tdep.c: Update.
5720         * rust-exp.y: Update.
5721         * rust-lang.c: Update.
5722         * s390-tdep.c: Update.
5723         * selftest-arch.c: Update.
5724         * solib-dsbt.c: Update.
5725         * solib-frv.c: Update.
5726         * solib-spu.c: Update.
5727         * solib-svr4.c: Update.
5728         * solib.c: Update.
5729         * sparc64-linux-tdep.c: Update.
5730         * stack.c: Update.
5731         * symfile-mem.c: Update.
5732         * symmisc.c: Update.
5733         * target.c: Update.
5734         * thread.c: Update.
5735         * top.c: Update.
5736         * tracefile-tfile.c: Update.
5737         * tui/tui.c: Update.
5738         * typeprint.c: Update.
5739         * unittests/cli-utils-selftests.c: Update.
5740         * unittests/parse-connection-spec-selftests.c: Update.
5741         * valops.c: Update.
5742         * valprint.c: Update.
5743         * value.c: Update.
5744         * varobj.c: Update.
5745         * windows-nat.c: Update.
5746         * x86-linux-nat.c: Update.
5747         * xml-support.c: Update.
5748
5749 2019-04-08  Tom Tromey  <tom@tromey.com>
5750
5751         * xml-support.c: Use C++ exception handling.
5752         * x86-linux-nat.c: Use C++ exception handling.
5753         * windows-nat.c: Use C++ exception handling.
5754         * varobj.c: Use C++ exception handling.
5755         * value.c: Use C++ exception handling.
5756         * valprint.c: Use C++ exception handling.
5757         * valops.c: Use C++ exception handling.
5758         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5759         handling.
5760         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5761         * typeprint.c: Use C++ exception handling.
5762         * tui/tui.c: Use C++ exception handling.
5763         * tracefile-tfile.c: Use C++ exception handling.
5764         * top.c: Use C++ exception handling.
5765         * thread.c: Use C++ exception handling.
5766         * target.c: Use C++ exception handling.
5767         * symmisc.c: Use C++ exception handling.
5768         * symfile-mem.c: Use C++ exception handling.
5769         * stack.c: Use C++ exception handling.
5770         * sparc64-linux-tdep.c: Use C++ exception handling.
5771         * solib.c: Use C++ exception handling.
5772         * solib-svr4.c: Use C++ exception handling.
5773         * solib-spu.c: Use C++ exception handling.
5774         * solib-frv.c: Use C++ exception handling.
5775         * solib-dsbt.c: Use C++ exception handling.
5776         * selftest-arch.c: Use C++ exception handling.
5777         * s390-tdep.c: Use C++ exception handling.
5778         * rust-lang.c: Use C++ exception handling.
5779         * rust-exp.y: Use C++ exception handling.
5780         * rs6000-tdep.c: Use C++ exception handling.
5781         * rs6000-aix-tdep.c: Use C++ exception handling.
5782         * riscv-tdep.c: Use C++ exception handling.
5783         * remote.c: Use C++ exception handling.
5784         * remote-fileio.c: Use C++ exception handling.
5785         * record-full.c: Use C++ exception handling.
5786         * record-btrace.c: Use C++ exception handling.
5787         * python/python.c: Use C++ exception handling.
5788         * python/py-value.c: Use C++ exception handling.
5789         * python/py-utils.c: Use C++ exception handling.
5790         * python/py-unwind.c: Use C++ exception handling.
5791         * python/py-type.c: Use C++ exception handling.
5792         * python/py-symbol.c: Use C++ exception handling.
5793         * python/py-record.c: Use C++ exception handling.
5794         * python/py-record-btrace.c: Use C++ exception handling.
5795         * python/py-progspace.c: Use C++ exception handling.
5796         * python/py-prettyprint.c: Use C++ exception handling.
5797         * python/py-param.c: Use C++ exception handling.
5798         * python/py-objfile.c: Use C++ exception handling.
5799         * python/py-linetable.c: Use C++ exception handling.
5800         * python/py-lazy-string.c: Use C++ exception handling.
5801         * python/py-infthread.c: Use C++ exception handling.
5802         * python/py-inferior.c: Use C++ exception handling.
5803         * python/py-gdb-readline.c: Use C++ exception handling.
5804         * python/py-framefilter.c: Use C++ exception handling.
5805         * python/py-frame.c: Use C++ exception handling.
5806         * python/py-finishbreakpoint.c: Use C++ exception handling.
5807         * python/py-cmd.c: Use C++ exception handling.
5808         * python/py-breakpoint.c: Use C++ exception handling.
5809         * python/py-arch.c: Use C++ exception handling.
5810         * printcmd.c: Use C++ exception handling.
5811         * ppc-linux-tdep.c: Use C++ exception handling.
5812         * parse.c: Use C++ exception handling.
5813         * p-valprint.c: Use C++ exception handling.
5814         * objc-lang.c: Use C++ exception handling.
5815         * mi/mi-main.c: Use C++ exception handling.
5816         * mi/mi-interp.c: Use C++ exception handling.
5817         * mi/mi-cmd-stack.c: Use C++ exception handling.
5818         * mi/mi-cmd-break.c: Use C++ exception handling.
5819         * main.c: Use C++ exception handling.
5820         * linux-thread-db.c: Use C++ exception handling.
5821         * linux-tdep.c: Use C++ exception handling.
5822         * linux-nat.c: Use C++ exception handling.
5823         * linux-fork.c: Use C++ exception handling.
5824         * linespec.c: Use C++ exception handling.
5825         * language.c: Use C++ exception handling.
5826         * jit.c: Use C++ exception handling.
5827         * infrun.c: Use C++ exception handling.
5828         * infcmd.c: Use C++ exception handling.
5829         * infcall.c: Use C++ exception handling.
5830         * inf-loop.c: Use C++ exception handling.
5831         * i386-tdep.c: Use C++ exception handling.
5832         * i386-linux-tdep.c: Use C++ exception handling.
5833         * guile/scm-value.c: Use C++ exception handling.
5834         * guile/scm-type.c: Use C++ exception handling.
5835         * guile/scm-symtab.c: Use C++ exception handling.
5836         * guile/scm-symbol.c: Use C++ exception handling.
5837         * guile/scm-pretty-print.c: Use C++ exception handling.
5838         * guile/scm-ports.c: Use C++ exception handling.
5839         * guile/scm-param.c: Use C++ exception handling.
5840         * guile/scm-math.c: Use C++ exception handling.
5841         * guile/scm-lazy-string.c: Use C++ exception handling.
5842         * guile/scm-frame.c: Use C++ exception handling.
5843         * guile/scm-disasm.c: Use C++ exception handling.
5844         * guile/scm-cmd.c: Use C++ exception handling.
5845         * guile/scm-breakpoint.c: Use C++ exception handling.
5846         * guile/scm-block.c: Use C++ exception handling.
5847         * guile/guile-internal.h: Use C++ exception handling.
5848         * gnu-v3-abi.c: Use C++ exception handling.
5849         * gdbtypes.c: Use C++ exception handling.
5850         * frame.c: Use C++ exception handling.
5851         * frame-unwind.c: Use C++ exception handling.
5852         * fbsd-tdep.c: Use C++ exception handling.
5853         * f-valprint.c: Use C++ exception handling.
5854         * exec.c: Use C++ exception handling.
5855         * event-top.c: Use C++ exception handling.
5856         * event-loop.c: Use C++ exception handling.
5857         * eval.c: Use C++ exception handling.
5858         * dwarf2read.c: Use C++ exception handling.
5859         * dwarf2loc.c: Use C++ exception handling.
5860         * dwarf2-frame.c: Use C++ exception handling.
5861         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5862         * dwarf-index-write.c: Use C++ exception handling.
5863         * dwarf-index-cache.c: Use C++ exception handling.
5864         * dtrace-probe.c: Use C++ exception handling.
5865         * disasm-selftests.c: Use C++ exception handling.
5866         * darwin-nat.c: Use C++ exception handling.
5867         * cp-valprint.c: Use C++ exception handling.
5868         * cp-support.c: Use C++ exception handling.
5869         * cp-abi.c: Use C++ exception handling.
5870         * corelow.c: Use C++ exception handling.
5871         * completer.c: Use C++ exception handling.
5872         * compile/compile-object-run.c: Use C++ exception handling.
5873         * compile/compile-object-load.c: Use C++ exception handling.
5874         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5875         * compile/compile-c-symbols.c: Use C++ exception handling.
5876         * common/selftest.c: Use C++ exception handling.
5877         * common/new-op.c: Use C++ exception handling.
5878         * cli/cli-script.c: Use C++ exception handling.
5879         * cli/cli-interp.c: Use C++ exception handling.
5880         * cli/cli-cmds.c: Use C++ exception handling.
5881         * c-varobj.c: Use C++ exception handling.
5882         * btrace.c: Use C++ exception handling.
5883         * breakpoint.c: Use C++ exception handling.
5884         * break-catch-throw.c: Use C++ exception handling.
5885         * arch-utils.c: Use C++ exception handling.
5886         * amd64-tdep.c: Use C++ exception handling.
5887         * ada-valprint.c: Use C++ exception handling.
5888         * ada-typeprint.c: Use C++ exception handling.
5889         * ada-lang.c: Use C++ exception handling.
5890         * aarch64-tdep.c: Use C++ exception handling.
5891
5892 2019-04-08  Tom Tromey  <tom@tromey.com>
5893
5894         * xml-support.c (gdb_xml_parser::parse): Update.
5895         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5896         * value.c (show_convenience): Update.
5897         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5898         (test_parse_flags_qcs): Update.
5899         * thread.c (thr_try_catch_cmd): Update.
5900         * target.c (target_translate_tls_address): Update.
5901         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5902         (info_frame_command_core, frame_apply_command_count): Update.
5903         * rust-exp.y (rust_lex_exception_test): Update.
5904         * riscv-tdep.c (riscv_print_one_register_info): Update.
5905         * remote.c (remote_target::enable_btrace): Update.
5906         * record-btrace.c (record_btrace_enable_warn): Update.
5907         * python/py-utils.c (gdbpy_convert_exception): Update.
5908         * printcmd.c (do_one_display, print_variable_and_value): Update.
5909         * mi/mi-main.c (mi_print_exception): Update.
5910         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5911         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5912         * linux-nat.c (linux_nat_target::attach): Update.
5913         * linux-fork.c (class scoped_switch_fork_info): Update.
5914         * infrun.c (displaced_step_prepare): Update.
5915         * infcall.c (call_function_by_hand_dummy): Update.
5916         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5917         * gnu-v3-abi.c (print_one_vtable): Update.
5918         * frame.c (get_prev_frame_always): Update.
5919         * f-valprint.c (info_common_command_for_block): Update.
5920         * exec.c (try_open_exec_file): Update.
5921         * exceptions.c (print_exception, exception_print)
5922         (exception_fprintf, exception_print_same): Update.
5923         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5924         * dwarf-index-cache.c (index_cache::store)
5925         (index_cache::lookup_gdb_index): Update.
5926         * darwin-nat.c (maybe_cache_shell): Update.
5927         * cp-valprint.c (cp_print_value_fields): Update.
5928         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5929         (gcc_cplus_symbol_address): Update.
5930         * compile/compile-c-symbols.c (gcc_convert_symbol)
5931         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5932         * common/selftest.c: Update.
5933         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5934         a std::string.
5935         (exception_try_scope_entry, exception_try_scope_exit): Don't
5936         declare.
5937         (struct exception_try_scope): Remove.
5938         (TRY): Don't use exception_try_scope.
5939         (struct gdb_exception): Add constructor, operator=.
5940         <what>: New method.
5941         (struct gdb_exception_RETURN_MASK_ALL)
5942         (struct gdb_exception_RETURN_MASK_ERROR)
5943         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5944         (struct gdb_quit_bad_alloc): Update.
5945         * common/common-exceptions.c (exception_none): Change
5946         initializer.
5947         (struct catcher) <state, exception>: Initialize inline.
5948         <prev>: Remove member.
5949         (current_catcher): Remove.
5950         (catchers): New global.
5951         (exceptions_state_mc_init): Simplify.
5952         (catcher_pop): Remove.
5953         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5954         (try_scope_depth, exception_try_scope_entry)
5955         (exception_try_scope_exit): Remove.
5956         (throw_exception_sjlj): Update.
5957         (exception_messages, exception_messages_size): Remove.
5958         (throw_it): Simplify.
5959         (gdb_exception_sliced_copy): Remove.
5960         (throw_exception_cxx): Update.
5961         * cli/cli-script.c (script_from_file): Update.
5962         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5963         Update.
5964         * ada-valprint.c (ada_val_print): Update.
5965         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5966         (create_excep_cond_exprs): Update.
5967
5968 2019-04-08  Tom Tromey  <tom@tromey.com>
5969
5970         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5971         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5972         (TRY, CATCH, END_CATCH): Remove some definitions.
5973         * common/common-exceptions.c: Don't use GDB_XCPT.
5974         (catcher_list_size): Remove.
5975         (throw_exception, throw_it): Simplify.
5976
5977 2019-04-05  Tom Tromey  <tom@tromey.com>
5978
5979         Revert the header-sorting patch.
5980         * ft32-tdep.c: Revert.
5981         * frv-tdep.c: Revert.
5982         * frv-linux-tdep.c: Revert.
5983         * frame.c: Revert.
5984         * frame-unwind.c: Revert.
5985         * frame-base.c: Revert.
5986         * fork-child.c: Revert.
5987         * findvar.c: Revert.
5988         * findcmd.c: Revert.
5989         * filesystem.c: Revert.
5990         * filename-seen-cache.h: Revert.
5991         * filename-seen-cache.c: Revert.
5992         * fbsd-tdep.c: Revert.
5993         * fbsd-nat.h: Revert.
5994         * fbsd-nat.c: Revert.
5995         * f-valprint.c: Revert.
5996         * f-typeprint.c: Revert.
5997         * f-lang.c: Revert.
5998         * extension.h: Revert.
5999         * extension.c: Revert.
6000         * extension-priv.h: Revert.
6001         * expprint.c: Revert.
6002         * exec.h: Revert.
6003         * exec.c: Revert.
6004         * exceptions.c: Revert.
6005         * event-top.c: Revert.
6006         * event-loop.c: Revert.
6007         * eval.c: Revert.
6008         * elfread.c: Revert.
6009         * dwarf2read.h: Revert.
6010         * dwarf2read.c: Revert.
6011         * dwarf2loc.c: Revert.
6012         * dwarf2expr.h: Revert.
6013         * dwarf2expr.c: Revert.
6014         * dwarf2-frame.c: Revert.
6015         * dwarf2-frame-tailcall.c: Revert.
6016         * dwarf-index-write.h: Revert.
6017         * dwarf-index-write.c: Revert.
6018         * dwarf-index-common.c: Revert.
6019         * dwarf-index-cache.h: Revert.
6020         * dwarf-index-cache.c: Revert.
6021         * dummy-frame.c: Revert.
6022         * dtrace-probe.c: Revert.
6023         * disasm.h: Revert.
6024         * disasm.c: Revert.
6025         * disasm-selftests.c: Revert.
6026         * dictionary.c: Revert.
6027         * dicos-tdep.c: Revert.
6028         * demangle.c: Revert.
6029         * dcache.h: Revert.
6030         * dcache.c: Revert.
6031         * darwin-nat.h: Revert.
6032         * darwin-nat.c: Revert.
6033         * darwin-nat-info.c: Revert.
6034         * d-valprint.c: Revert.
6035         * d-namespace.c: Revert.
6036         * d-lang.c: Revert.
6037         * ctf.c: Revert.
6038         * csky-tdep.c: Revert.
6039         * csky-linux-tdep.c: Revert.
6040         * cris-tdep.c: Revert.
6041         * cris-linux-tdep.c: Revert.
6042         * cp-valprint.c: Revert.
6043         * cp-support.c: Revert.
6044         * cp-namespace.c: Revert.
6045         * cp-abi.c: Revert.
6046         * corelow.c: Revert.
6047         * corefile.c: Revert.
6048         * continuations.c: Revert.
6049         * completer.h: Revert.
6050         * completer.c: Revert.
6051         * complaints.c: Revert.
6052         * coffread.c: Revert.
6053         * coff-pe-read.c: Revert.
6054         * cli-out.h: Revert.
6055         * cli-out.c: Revert.
6056         * charset.c: Revert.
6057         * c-varobj.c: Revert.
6058         * c-valprint.c: Revert.
6059         * c-typeprint.c: Revert.
6060         * c-lang.c: Revert.
6061         * buildsym.c: Revert.
6062         * buildsym-legacy.c: Revert.
6063         * build-id.h: Revert.
6064         * build-id.c: Revert.
6065         * btrace.c: Revert.
6066         * bsd-uthread.c: Revert.
6067         * breakpoint.h: Revert.
6068         * breakpoint.c: Revert.
6069         * break-catch-throw.c: Revert.
6070         * break-catch-syscall.c: Revert.
6071         * break-catch-sig.c: Revert.
6072         * blockframe.c: Revert.
6073         * block.c: Revert.
6074         * bfin-tdep.c: Revert.
6075         * bfin-linux-tdep.c: Revert.
6076         * bfd-target.c: Revert.
6077         * bcache.c: Revert.
6078         * ax-general.c: Revert.
6079         * ax-gdb.h: Revert.
6080         * ax-gdb.c: Revert.
6081         * avr-tdep.c: Revert.
6082         * auxv.c: Revert.
6083         * auto-load.c: Revert.
6084         * arm-wince-tdep.c: Revert.
6085         * arm-tdep.c: Revert.
6086         * arm-symbian-tdep.c: Revert.
6087         * arm-pikeos-tdep.c: Revert.
6088         * arm-obsd-tdep.c: Revert.
6089         * arm-nbsd-tdep.c: Revert.
6090         * arm-nbsd-nat.c: Revert.
6091         * arm-linux-tdep.c: Revert.
6092         * arm-linux-nat.c: Revert.
6093         * arm-fbsd-tdep.c: Revert.
6094         * arm-fbsd-nat.c: Revert.
6095         * arm-bsd-tdep.c: Revert.
6096         * arch-utils.c: Revert.
6097         * arc-tdep.c: Revert.
6098         * arc-newlib-tdep.c: Revert.
6099         * annotate.h: Revert.
6100         * annotate.c: Revert.
6101         * amd64-windows-tdep.c: Revert.
6102         * amd64-windows-nat.c: Revert.
6103         * amd64-tdep.c: Revert.
6104         * amd64-sol2-tdep.c: Revert.
6105         * amd64-obsd-tdep.c: Revert.
6106         * amd64-obsd-nat.c: Revert.
6107         * amd64-nbsd-tdep.c: Revert.
6108         * amd64-nbsd-nat.c: Revert.
6109         * amd64-nat.c: Revert.
6110         * amd64-linux-tdep.c: Revert.
6111         * amd64-linux-nat.c: Revert.
6112         * amd64-fbsd-tdep.c: Revert.
6113         * amd64-fbsd-nat.c: Revert.
6114         * amd64-dicos-tdep.c: Revert.
6115         * amd64-darwin-tdep.c: Revert.
6116         * amd64-bsd-nat.c: Revert.
6117         * alpha-tdep.c: Revert.
6118         * alpha-obsd-tdep.c: Revert.
6119         * alpha-nbsd-tdep.c: Revert.
6120         * alpha-mdebug-tdep.c: Revert.
6121         * alpha-linux-tdep.c: Revert.
6122         * alpha-linux-nat.c: Revert.
6123         * alpha-bsd-tdep.c: Revert.
6124         * alpha-bsd-nat.c: Revert.
6125         * aix-thread.c: Revert.
6126         * agent.c: Revert.
6127         * addrmap.c: Revert.
6128         * ada-varobj.c: Revert.
6129         * ada-valprint.c: Revert.
6130         * ada-typeprint.c: Revert.
6131         * ada-tasks.c: Revert.
6132         * ada-lang.c: Revert.
6133         * aarch64-tdep.c: Revert.
6134         * aarch64-ravenscar-thread.c: Revert.
6135         * aarch64-newlib-tdep.c: Revert.
6136         * aarch64-linux-tdep.c: Revert.
6137         * aarch64-linux-nat.c: Revert.
6138         * aarch64-fbsd-tdep.c: Revert.
6139         * aarch64-fbsd-nat.c: Revert.
6140         * aarch32-linux-nat.c: Revert.
6141
6142 2019-04-05  Tom Tromey  <tom@tromey.com>
6143
6144         * ft32-tdep.c: Sort headers.
6145         * frv-tdep.c: Sort headers.
6146         * frv-linux-tdep.c: Sort headers.
6147         * frame.c: Sort headers.
6148         * frame-unwind.c: Sort headers.
6149         * frame-base.c: Sort headers.
6150         * fork-child.c: Sort headers.
6151         * findvar.c: Sort headers.
6152         * findcmd.c: Sort headers.
6153         * filesystem.c: Sort headers.
6154         * filename-seen-cache.h: Sort headers.
6155         * filename-seen-cache.c: Sort headers.
6156         * fbsd-tdep.c: Sort headers.
6157         * fbsd-nat.h: Sort headers.
6158         * fbsd-nat.c: Sort headers.
6159         * f-valprint.c: Sort headers.
6160         * f-typeprint.c: Sort headers.
6161         * f-lang.c: Sort headers.
6162         * extension.h: Sort headers.
6163         * extension.c: Sort headers.
6164         * extension-priv.h: Sort headers.
6165         * expprint.c: Sort headers.
6166         * exec.h: Sort headers.
6167         * exec.c: Sort headers.
6168         * exceptions.c: Sort headers.
6169         * event-top.c: Sort headers.
6170         * event-loop.c: Sort headers.
6171         * eval.c: Sort headers.
6172         * elfread.c: Sort headers.
6173         * dwarf2read.h: Sort headers.
6174         * dwarf2read.c: Sort headers.
6175         * dwarf2loc.c: Sort headers.
6176         * dwarf2expr.h: Sort headers.
6177         * dwarf2expr.c: Sort headers.
6178         * dwarf2-frame.c: Sort headers.
6179         * dwarf2-frame-tailcall.c: Sort headers.
6180         * dwarf-index-write.h: Sort headers.
6181         * dwarf-index-write.c: Sort headers.
6182         * dwarf-index-common.c: Sort headers.
6183         * dwarf-index-cache.h: Sort headers.
6184         * dwarf-index-cache.c: Sort headers.
6185         * dummy-frame.c: Sort headers.
6186         * dtrace-probe.c: Sort headers.
6187         * disasm.h: Sort headers.
6188         * disasm.c: Sort headers.
6189         * disasm-selftests.c: Sort headers.
6190         * dictionary.c: Sort headers.
6191         * dicos-tdep.c: Sort headers.
6192         * demangle.c: Sort headers.
6193         * dcache.h: Sort headers.
6194         * dcache.c: Sort headers.
6195         * darwin-nat.h: Sort headers.
6196         * darwin-nat.c: Sort headers.
6197         * darwin-nat-info.c: Sort headers.
6198         * d-valprint.c: Sort headers.
6199         * d-namespace.c: Sort headers.
6200         * d-lang.c: Sort headers.
6201         * ctf.c: Sort headers.
6202         * csky-tdep.c: Sort headers.
6203         * csky-linux-tdep.c: Sort headers.
6204         * cris-tdep.c: Sort headers.
6205         * cris-linux-tdep.c: Sort headers.
6206         * cp-valprint.c: Sort headers.
6207         * cp-support.c: Sort headers.
6208         * cp-namespace.c: Sort headers.
6209         * cp-abi.c: Sort headers.
6210         * corelow.c: Sort headers.
6211         * corefile.c: Sort headers.
6212         * continuations.c: Sort headers.
6213         * completer.h: Sort headers.
6214         * completer.c: Sort headers.
6215         * complaints.c: Sort headers.
6216         * coffread.c: Sort headers.
6217         * coff-pe-read.c: Sort headers.
6218         * cli-out.h: Sort headers.
6219         * cli-out.c: Sort headers.
6220         * charset.c: Sort headers.
6221         * c-varobj.c: Sort headers.
6222         * c-valprint.c: Sort headers.
6223         * c-typeprint.c: Sort headers.
6224         * c-lang.c: Sort headers.
6225         * buildsym.c: Sort headers.
6226         * buildsym-legacy.c: Sort headers.
6227         * build-id.h: Sort headers.
6228         * build-id.c: Sort headers.
6229         * btrace.c: Sort headers.
6230         * bsd-uthread.c: Sort headers.
6231         * breakpoint.h: Sort headers.
6232         * breakpoint.c: Sort headers.
6233         * break-catch-throw.c: Sort headers.
6234         * break-catch-syscall.c: Sort headers.
6235         * break-catch-sig.c: Sort headers.
6236         * blockframe.c: Sort headers.
6237         * block.c: Sort headers.
6238         * bfin-tdep.c: Sort headers.
6239         * bfin-linux-tdep.c: Sort headers.
6240         * bfd-target.c: Sort headers.
6241         * bcache.c: Sort headers.
6242         * ax-general.c: Sort headers.
6243         * ax-gdb.h: Sort headers.
6244         * ax-gdb.c: Sort headers.
6245         * avr-tdep.c: Sort headers.
6246         * auxv.c: Sort headers.
6247         * auto-load.c: Sort headers.
6248         * arm-wince-tdep.c: Sort headers.
6249         * arm-tdep.c: Sort headers.
6250         * arm-symbian-tdep.c: Sort headers.
6251         * arm-pikeos-tdep.c: Sort headers.
6252         * arm-obsd-tdep.c: Sort headers.
6253         * arm-nbsd-tdep.c: Sort headers.
6254         * arm-nbsd-nat.c: Sort headers.
6255         * arm-linux-tdep.c: Sort headers.
6256         * arm-linux-nat.c: Sort headers.
6257         * arm-fbsd-tdep.c: Sort headers.
6258         * arm-fbsd-nat.c: Sort headers.
6259         * arm-bsd-tdep.c: Sort headers.
6260         * arch-utils.c: Sort headers.
6261         * arc-tdep.c: Sort headers.
6262         * arc-newlib-tdep.c: Sort headers.
6263         * annotate.h: Sort headers.
6264         * annotate.c: Sort headers.
6265         * amd64-windows-tdep.c: Sort headers.
6266         * amd64-windows-nat.c: Sort headers.
6267         * amd64-tdep.c: Sort headers.
6268         * amd64-sol2-tdep.c: Sort headers.
6269         * amd64-obsd-tdep.c: Sort headers.
6270         * amd64-obsd-nat.c: Sort headers.
6271         * amd64-nbsd-tdep.c: Sort headers.
6272         * amd64-nbsd-nat.c: Sort headers.
6273         * amd64-nat.c: Sort headers.
6274         * amd64-linux-tdep.c: Sort headers.
6275         * amd64-linux-nat.c: Sort headers.
6276         * amd64-fbsd-tdep.c: Sort headers.
6277         * amd64-fbsd-nat.c: Sort headers.
6278         * amd64-dicos-tdep.c: Sort headers.
6279         * amd64-darwin-tdep.c: Sort headers.
6280         * amd64-bsd-nat.c: Sort headers.
6281         * alpha-tdep.c: Sort headers.
6282         * alpha-obsd-tdep.c: Sort headers.
6283         * alpha-nbsd-tdep.c: Sort headers.
6284         * alpha-mdebug-tdep.c: Sort headers.
6285         * alpha-linux-tdep.c: Sort headers.
6286         * alpha-linux-nat.c: Sort headers.
6287         * alpha-bsd-tdep.c: Sort headers.
6288         * alpha-bsd-nat.c: Sort headers.
6289         * aix-thread.c: Sort headers.
6290         * agent.c: Sort headers.
6291         * addrmap.c: Sort headers.
6292         * ada-varobj.c: Sort headers.
6293         * ada-valprint.c: Sort headers.
6294         * ada-typeprint.c: Sort headers.
6295         * ada-tasks.c: Sort headers.
6296         * ada-lang.c: Sort headers.
6297         * aarch64-tdep.c: Sort headers.
6298         * aarch64-ravenscar-thread.c: Sort headers.
6299         * aarch64-newlib-tdep.c: Sort headers.
6300         * aarch64-linux-tdep.c: Sort headers.
6301         * aarch64-linux-nat.c: Sort headers.
6302         * aarch64-fbsd-tdep.c: Sort headers.
6303         * aarch64-fbsd-nat.c: Sort headers.
6304         * aarch32-linux-nat.c: Sort headers.
6305
6306 2019-04-04  Tom Tromey  <tom@tromey.com>
6307
6308         * varobj.c (varobj_create): Update.
6309         * rust-exp.y (struct rust_parser) <update_innermost_block,
6310         lookup_symbol>: New methods.
6311         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6312         Rename.
6313         (rust_parser::rust_lookup_type)
6314         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6315         * printcmd.c (display_command, do_one_display): Update.
6316         * parser-defs.h (struct parser_state) <parser_state>: Add
6317         "tracker" parameter.
6318         (block_tracker): New member.
6319         (class innermost_block_tracker) <innermost_block_tracker>: Add
6320         "types" parameter.
6321         <reset>: Remove method.
6322         (innermost_block): Don't declare.
6323         (null_post_parser): Update.
6324         * parse.c (innermost_block): Remove global.
6325         (write_dollar_variable): Update.
6326         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6327         Remove "tracker_types" parameter.
6328         (parse_expression): Add "tracker" parameter.
6329         (parse_expression_for_completion): Update.
6330         (null_post_parser): Add "tracker" parameter.
6331         * p-exp.y: Update rules.
6332         * m2-exp.y: Update rules.
6333         * language.h (struct language_defn) <la_post_parser>: Add
6334         "tracker" parameter.
6335         * go-exp.y: Update rules.
6336         * f-exp.y: Update rules.
6337         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6338         parameter.
6339         * d-exp.y: Update rules.
6340         * c-exp.y: Update rules.
6341         * breakpoint.c (set_breakpoint_condition): Create an
6342         innermost_block_tracker.
6343         (watch_command_1): Likewise.
6344         * ada-lang.c (resolve): Add "tracker" parameter.
6345         (resolve_subexp): Likewise.
6346         * ada-exp.y (write_var_from_sym): Update.
6347
6348 2019-04-04  Tom Tromey  <tom@tromey.com>
6349
6350         * type-stack.h: New file.
6351         * type-stack.c: New file.
6352         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6353         type-stack.h.
6354         (insert_into_type_stack, insert_type, push_type, push_type_int)
6355         (insert_type_address_space, pop_type, pop_type_int)
6356         (pop_typelist, pop_type_stack, append_type_stack)
6357         (push_type_stack, get_type_stack, push_typelist)
6358         (follow_type_instance_flags, follow_types): Don't declare.
6359         * parse.c (type_stack): Remove global.
6360         (parse_exp_in_context): Update.
6361         (insert_into_type_stack, insert_type, push_type, push_type_int)
6362         (insert_type_address_space, pop_type, pop_type_int)
6363         (pop_typelist, pop_type_stack, append_type_stack)
6364         (push_type_stack, get_type_stack, push_typelist)
6365         (follow_type_instance_flags, follow_types): Remove (moved to
6366         type-stack.c).
6367         * f-exp.y (type_stack): New global.
6368         Update rules.
6369         (push_kind_type, f_parse): Update.
6370         * d-exp.y (type_stack): New global.
6371         Update rules.
6372         (d_parse): Update.
6373         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6374         Update rules.
6375         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6376         (HFILES_NO_SRCDIR): Add type-stack.h.
6377
6378 2019-04-04  Tom Tromey  <tom@tromey.com>
6379
6380         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6381         (rust_parser::convert_ast_to_expression, rust_parse)
6382         (rust_lex_test_completion, rust_lex_tests): Update.
6383         * parser-defs.h (struct expr_completion_state): New.
6384         (struct parser_state) <parser_state>: Add completion parameter.
6385         <mark_struct_expression, mark_completion_tag>: New methods.
6386         <parse_completion, m_completion_state>: New members.
6387         (prefixify_expression, null_post_parser): Update.
6388         (mark_struct_expression, mark_completion_tag): Don't declare.
6389         * parse.c (parse_completion, expout_last_struct)
6390         (expout_tag_completion_type, expout_completion_name): Remove
6391         globals.
6392         (parser_state::mark_struct_expression)
6393         (parser_state::mark_completion_tag): Now methods.
6394         (prefixify_expression): Add last_struct parameter.
6395         (prefixify_subexp): Likewise.
6396         (parse_exp_1): Update.
6397         (parse_exp_in_context): Add cstate parameter.  Update.
6398         (parse_expression_for_completion): Create an
6399         expr_completion_state.
6400         (null_post_parser): Add "completion" parameter.
6401         * p-exp.y: Update rules.
6402         (yylex): Update.
6403         * language.h (struct language_defn) <la_post_parser>: Add
6404         "completing" parameter.
6405         * go-exp.y: Update rules.
6406         (lex_one_token): Update.
6407         * expression.h (parse_completion): Don't declare.
6408         * d-exp.y: Update rules.
6409         (lex_one_token): Update rules.
6410         * c-exp.y: Update rules.
6411         (lex_one_token): Update.
6412         * ada-lang.c (resolve): Add "parse_completion" parameter.
6413         (resolve_subexp): Likewise.
6414         (ada_resolve_function): Likewise.
6415
6416 2019-04-04  Tom Tromey  <tom@tromey.com>
6417
6418         * parser-defs.h (struct parser_state) <start_arglist,
6419         end_arglist>: New methods.
6420         <arglist_len, m_funcall_chain>: New members.
6421         (arglist_len, start_arglist, end_arglist): Don't declare.
6422         * parse.c (arglist_len, funcall_chain): Remove global.
6423         (start_arglist, end_arglist): Remove functions.
6424         (parse_exp_in_context): Update.
6425         * p-exp.y: Update rules.
6426         * m2-exp.y: Update rules.
6427         * go-exp.y: Update rules.
6428         * f-exp.y: Update rules.
6429         * d-exp.y: Update rules.
6430         * c-exp.y: Update rules.
6431
6432 2019-04-04  Tom Tromey  <tom@tromey.com>
6433
6434         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6435         lex_operator, push_back>: New methods.
6436         Update all rules.
6437         (rust_parser::lex_hex, lex_escape): Rename and update.
6438         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6439         (rust_parser::lex_operator): Rename and update.
6440         (rust_parser::lex_number, rustyylex, rustyyerror)
6441         (rust_lex_test_init, rust_lex_test_sequence)
6442         (rust_lex_test_push_back, rust_lex_tests): Update.
6443         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6444         parameter.
6445         <lexptr, prev_lexptr>: New members.
6446         (lexptr, prev_lexptr): Don't declare.
6447         * parse.c (lexptr, prev_lexptr): Remove globals.
6448         (parse_exp_in_context): Update.
6449         * p-exp.y (yylex, yyerror): Update.
6450         * m2-exp.y (parse_number, yylex, yyerror): Update.
6451         * go-exp.y (lex_one_token, yyerror): Update.
6452         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6453         * d-exp.y (lex_one_token, yyerror): Update.
6454         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6455         (lex_one_token, yyerror): Update.
6456         * ada-lex.l (YY_INPUT): Update.
6457         (rewind_to_char): Update.
6458         * ada-exp.y (yyerror): Update.
6459
6460 2019-04-04  Tom Tromey  <tom@tromey.com>
6461
6462         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6463         * parser-defs.h (struct parser_state) <parser_state>: Add new
6464         parameter.
6465         <comma_terminates>: New member.
6466         (comma_terminates): Don't declare global.
6467         * parse.c (comma_terminates): Remove global.
6468         (parse_exp_in_context): Update.
6469         * p-exp.y (yylex): Update.
6470         * m2-exp.y (yylex): Update.
6471         * go-exp.y (lex_one_token): Update.
6472         * f-exp.y (yylex): Update.
6473         * d-exp.y (lex_one_token): Update.
6474         * c-exp.y (lex_one_token): Update.
6475         * ada-lex.l: Update.
6476
6477 2019-04-04  Tom Tromey  <tom@tromey.com>
6478
6479         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6480         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6481         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6482         * parser-defs.h (paren_depth): Don't declare.
6483         * parse.c (paren_depth): Remove global.
6484         (parse_exp_in_context): Update.
6485         * p-exp.y (paren_depth): New global.
6486         (pascal_parse): Initialize it.
6487         * m2-exp.y (paren_depth): New global.
6488         (m2_parse): Initialize it.
6489         * go-exp.y (paren_depth): New global.
6490         (go_parse): Initialize it.
6491         * f-exp.y (paren_depth): New global.
6492         (f_parse): Initialize it.
6493         * d-exp.y (paren_depth): New global.
6494         (d_parse): Initialize it.
6495         * c-exp.y (paren_depth): New global.
6496         (c_parse): Initialize it.
6497         * ada-lex.l (paren_depth): New global.
6498         (lexer_init): Initialize it.
6499
6500 2019-04-04  Tom Tromey  <tom@tromey.com>
6501
6502         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6503         (rust_parser::convert_ast_to_type)
6504         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6505         * parser-defs.h (struct parser_state) <parser_state>: Add
6506         parameters.  Initialize new members.
6507         <expression_context_block, expression_context_pc>: New members.
6508         * parse.c (expression_context_block, expression_context_pc):
6509         Remove globals.
6510         (parse_exp_in_context): Update.
6511         * p-exp.y: Update all rules.
6512         (yylex): Update.
6513         * m2-exp.y: Update all rules.
6514         (yylex): Update.
6515         * go-exp.y (yylex): Update.
6516         * f-exp.y (yylex): Update.
6517         * d-exp.y: Update all rules.
6518         (yylex): Update.
6519         * c-exp.y: Update all rules.
6520         (lex_one_token, classify_name, yylex, c_parse): Update.
6521         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6522
6523 2019-04-04  Tom Tromey  <tom@tromey.com>
6524
6525         * gdbarch.h, gdbarch.c: Rebuild.
6526         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6527         * stap-probe.h:
6528         (struct stap_parse_info): Replace "parser_state" with
6529         "expr_builder".
6530         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6531         (parser_state): New class.
6532         * parse.c (expr_builder): Rename.
6533         (expr_builder::release): Rename.
6534         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6535         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6536         (write_exp_elt_longcst, write_exp_elt_floatcst)
6537         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6538         (write_exp_string_vector, write_exp_bitstring)
6539         (write_exp_msymbol, mark_struct_expression)
6540         (write_dollar_variable)
6541         (insert_type_address_space, increase_expout_size): Replace
6542         "parser_state" with "expr_builder".
6543         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6544         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6545         "parser_state" with "expr_builder".
6546
6547 2019-04-04  Tom Tromey  <tom@tromey.com>
6548
6549         * rust-exp.y: Replace "parse_language" with method call.
6550         * p-exp.y:
6551         (yylex): Replace "parse_language" with method call.
6552         * m2-exp.y:
6553         (yylex): Replace "parse_language" with method call.
6554         * go-exp.y (classify_name): Replace "parse_language" with method
6555         call.
6556         * f-exp.y (yylex): Replace "parse_language" with method call.
6557         * d-exp.y (lex_one_token): Replace "parse_language" with method
6558         call.
6559         * c-exp.y:
6560         (lex_one_token, classify_name, yylex): Replace "parse_language"
6561         with method call.
6562         * ada-exp.y (find_primitive_type, type_char)
6563         (type_system_address): Replace "parse_language" with method call.
6564
6565 2019-04-04  Tom Tromey  <tom@tromey.com>
6566
6567         * rust-exp.y: Replace "parse_gdbarch" with method call.
6568         * parse.c (write_dollar_variable, insert_type_address_space):
6569         Replace "parse_gdbarch" with method call.
6570         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6571         call.
6572         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6573         call.
6574         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6575         "parse_gdbarch" with method call.
6576         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6577         with method call.
6578         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6579         "parse_gdbarch" with method call.
6580         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6581         "parse_gdbarch" with method call.
6582         * c-exp.y (parse_type, parse_number, classify_name): Replace
6583         "parse_gdbarch" with method call.
6584         * ada-lex.l: Replace "parse_gdbarch" with method call.
6585         * ada-exp.y (parse_type, find_primitive_type, type_char)
6586         (type_system_address): Replace "parse_gdbarch" with method call.
6587
6588 2019-04-04  Tom Tromey  <tom@tromey.com>
6589
6590         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6591         * stap-probe.c (stap_parse_argument): Update.
6592         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6593         initial_size parameter.
6594         * rust-exp.y (rust_lex_tests): Update.
6595         * parse.c (parser_state): Update.
6596         (parse_exp_in_context): Update.
6597         * parser-defs.h (struct parser_state) <parser_state>: Remove
6598         "initial_size" parameter.
6599
6600 2019-04-04  Tom Tromey  <tom@tromey.com>
6601
6602         * parser-defs.h (increase_expout_size): Don't declare.
6603         * parse.c (increase_expout_size): Now static.
6604
6605 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6606
6607         * gnu-nat.c (gnu_nat_target::wait): Fix
6608         target_waitstatus_to_string call.
6609
6610 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6611
6612         * eval.c (evaluate_subexp_standard): Handle internal functions
6613         during Fortran function call handling.
6614
6615 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6616
6617         * NEWS: Mention new internal functions.
6618         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6619         (read_base_type): Use dwarf2_init_complex_target_type.
6620         * value.c (creal_internal_fn): New function.
6621         (cimag_internal_fn): New function.
6622         (_initialize_values): Register new internal functions.
6623
6624 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6625
6626         * infrun.c (stop_all_threads): If debug_infrun, always
6627         trace the wait status after wait_one, using
6628         target_waitstatus_to_string and target_pid_to_str.
6629         (handle_inferior_event): Replace various trace of
6630         wait status kind by a single trace.
6631         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6632         wait status kind image by target_waitstatus_to_string.
6633         * target/waitstatus.c (target_waitstatus_to_string): Fix
6634         obsolete comment.
6635
6636 2019-04-01  Tom Tromey  <tromey@adacore.com>
6637
6638         PR symtab/23331:
6639         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6640
6641 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6642             Pedro Alves  <palves@redhat.com>
6643
6644         * top.c (quit_force): Call 'finalize_values'.
6645         * value.c (finalize_values): New function.
6646         * value.h (finalize_values): Declare.
6647
6648 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6649
6650         * NEWS: Announce $_gdb_major and $_gdb_minor.
6651
6652         * top.c (init_gdb_version_vars): New function.
6653         (gdb_init): Call init_gdb_version_vars.
6654
6655 2019-03-29  Tom Tromey  <tromey@adacore.com>
6656
6657         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6658         help text.  Remove dead code.
6659
6660 2019-03-29  Keith Seitz  <keiths@redhat.com>
6661
6662         From Siddhesh Poyarekar:
6663         * f-lang.h (f77_get_upperbound): Return LONGEST.
6664         (f77_get_lowerbound): Likewise.
6665         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6666         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6667         print them.
6668         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6669         plongest to format print it.
6670         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6671         (f77_get_upperbound): Likewise.
6672         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6673         LOWER_BOUND to LONGEST.
6674         (f77_create_arrayprint_offset_tbl): Likewise.
6675
6676 2019-03-29  Keith Seitz  <keiths@redhat.com>
6677
6678         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6679         %s/pulongest for TYPE_LENGTH instead of %d in format
6680         strings.
6681         * ada-typerint.c (ada_print_type): Likewise.
6682         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6683         * compile/compile-c-support.c (generate_register_struct): Likewise.
6684         * gdbtypes.c (recursive_dump_type): Likewise.
6685         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6686         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6687         instead of %d in format strings.
6688         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6689         to std::min to ULONGEST.
6690         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6691         instead of %d in format strings.
6692         * tracepoint.c (info_scope_command): Likewise.
6693         * typeprint.c (print_offset_data::update)
6694         (print_offset_data::finish): Likewise.
6695         * xtensa-tdep.c (xtensa_store_return_value)
6696         (xtensa_push_dummy_call): Likewise.
6697
6698 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6699
6700         * windows-nat.c (display_selector): Fixed format specifications
6701         for 64-bit Cygwin.
6702
6703 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6704
6705         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6706
6707 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6708
6709         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6710         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6711         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6712         (nios2_linux_init_abi): Install it.
6713
6714 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6715
6716         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6717
6718 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6719
6720         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6721
6722 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6723             Tom Tromey  <tromey@adacore.com>
6724
6725         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6726
6727 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6728
6729         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6730         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6731         method to compute the bounds of range types. Also print "[evaluated]"
6732         if the bounds' values come from a dynamic evaluation.
6733
6734 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6735
6736         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6737         whitespace when pretty printing is on.
6738
6739 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6740
6741         * ppc-linux-nat.c: Add include.
6742
6743 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6744
6745         * NEWS: Mention AArch64 Pointer Authentication.
6746
6747 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6748
6749         * arm-linux-nat.c: Add include.
6750
6751 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6752
6753         * source-cache.c (source_cache::get_source_lines): Re-read
6754         fullname after calling open_source_file.
6755
6756 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6757
6758         * NEWS: Mention TLS support for FreeBSD.
6759
6760 2019-03-25  Tom Tromey  <tromey@adacore.com>
6761
6762         * minsyms.c (BUNCH_SIZE): Update comment.
6763         (~minimal_symbol_reader): Remove old comment.
6764         (compact_minimal_symbols): Update comment.
6765         (minimal_symbol_reader::install): Remove old comment.  Update
6766         other comments.
6767
6768 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6769
6770         * s390-linux-nat.c: Add include.
6771
6772 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6773
6774         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6775         Call linux_get_hwcap.
6776         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6777         Likewise.
6778         (aarch64_linux_get_hwcap): Remove function.
6779         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6780         declaration.
6781         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6782         linux_get_hwcap.
6783         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6784         * linux-tdep.c (linux_get_hwcap): Add function.
6785         (linux_get_hwcap2): Likewise.
6786         * linux-tdep.h (linux_get_hwcap): Add declaration.
6787         (linux_get_hwcap2): Likewise.
6788         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6789         (ppc_linux_get_hwcap2): Likewise.
6790         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6791         linux_get_hwcap.
6792         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6793         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6794         (ppc_linux_nat_target::read_description): Likewise.
6795         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6796         * s390-linux-nat.c: Likewise.
6797         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6798
6799 2019-03-24  Tom Tromey  <tom@tromey.com>
6800
6801         * ada-lang.c (standard_lookup): Simplify initialization.
6802         (ada_lookup_symbol_nonlocal): Simplify return.
6803         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6804         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6805         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6806         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6807         initialization.
6808         * solib.c (solib_global_lookup): Simplify.
6809         * symtab.c (null_block_symbol): Remove.
6810         (symbol_cache_lookup): Simplify returns.
6811         (lookup_language_this): Simplify returns.
6812         (lookup_symbol_aux): Simplify return.
6813         (lookup_local_symbol): Simplify returns.
6814         (lookup_global_symbol_from_objfile): Simplify return.
6815         (lookup_symbol_in_objfile_symtabs)
6816         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6817         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6818         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6819         * cp-namespace.c (cp_lookup_bare_symbol)
6820         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6821         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6822         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6823         (cp_lookup_symbol_via_imports): Simplify initialization.
6824         (find_symbol_in_baseclass): Likewise.
6825         * symtab.h (null_block_symbol): Remove.
6826         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6827         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6828         (d_lookup_symbol_module): Likewise.
6829         (find_symbol_in_baseclass): Simplify initialization.
6830
6831 2019-03-24  Tom Tromey  <tom@tromey.com>
6832
6833         * expression.h: Don't include symtab.h.
6834         (struct block): Forward declare.
6835
6836 2019-03-24  Tom Tromey  <tom@tromey.com>
6837
6838         * c-exp.y (typebase): Remove casts.
6839         * gdbtypes.c (lookup_unsigned_typename, )
6840         (lookup_signed_typename): Remove cast.
6841         * eval.c (parse_to_comma_and_eval): Remove cast.
6842         * parse.c (write_dollar_variable): Remove cast.
6843         * block.h (struct block) <superblock>: Now const.
6844         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6845         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6846         (map_block): Make "block" const.
6847         * symfile.h (struct quick_symbol_functions)
6848         <map_matching_symbols>: Constify block argument to "callback".
6849         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6850         const.
6851         (find_pc_sect_compunit_symtab): Make "b" const.
6852         (find_symbol_at_address): Likewise.
6853         (search_symbols): Likewise.
6854         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6855         (dw2_debug_names_lookup_symbol): Likewise.
6856         (dw2_map_matching_symbols): Update.
6857         * p-valprint.c (pascal_val_print): Remove "block".
6858         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6859         (aux_add_nonlocal_symbols): Make "block" const.
6860         (resolve_subexp): Remove cast.
6861         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6862         const.
6863         (iterate_over_file_blocks): Likewise.
6864         * f-exp.y (%union) <bval>: Remove.
6865         * coffread.c (patch_opaque_types): Make "b" const.
6866         * spu-tdep.c (spu_catch_start): Make "block" const.
6867         * c-valprint.c (print_unpacked_pointer): Remove "block".
6868         * symmisc.c (dump_symtab_1): Make "b" const.
6869         (block_depth): Make "block" const.
6870         * d-exp.y (%union) <bval>: Remove.
6871         * cp-support.h (cp_lookup_rtti_type): Update.
6872         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6873         * psymtab.c (psym_lookup_symbol): Make "block" const.
6874         (maintenance_check_psymtabs): Make "b" const.
6875         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6876         (enumerate_locals, enumerate_args): Update.
6877         * python/py-symtab.c (stpy_global_block): Make "block" const.
6878         (stpy_static_block): Likewise.
6879         * inline-frame.c (block_starting_point_at): Make "new_block"
6880         const.
6881         * block.c (find_block_in_blockvector): Make return type const.
6882         (blockvector_for_pc_sect): Make "b" const.
6883         (find_block_in_blockvector): Make "b" const.
6884
6885 2019-03-23  Tom Tromey  <tom@tromey.com>
6886
6887         * varobj.c (varobj_create): Update.
6888         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6889         * printcmd.c (display_command, do_one_display): Don't reset
6890         innermost_block.
6891         * parser-defs.h (enum innermost_block_tracker_type): Move to
6892         expression.h.
6893         (innermost_block): Update comment.
6894         * parse.c (parse_exp_1): Add tracker_types parameter.
6895         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6896         tracker_types parameter.  Reset innermost_block.
6897         (parse_exp_in_context): Remove.
6898         (parse_expression_for_completion): Update.
6899         * objfiles.c (~objfile): Don't reset expression_context_block or
6900         innermost_block.
6901         * expression.h (enum innermost_block_tracker_type): Move from
6902         parser-defs.h.
6903         (parse_exp_1): Add tracker_types parameter.
6904         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6905         reset innermost_block.
6906
6907 2019-03-23  Tom Tromey  <tom@tromey.com>
6908
6909         * objfiles.h: Include bcache.h.
6910
6911 2019-03-23  Tom Tromey  <tom@tromey.com>
6912
6913         * linespec.c (get_current_search_block): Use
6914         scoped_restore_current_language.
6915         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6916
6917 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6918             Jiong Wang  <jiong.wang@arm.com>
6919
6920         * aarch64-linux-tdep.c
6921         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6922         section.
6923         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6924
6925 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6926             Jiong Wang  <jiong.wang@arm.com>
6927
6928         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6929         instructions.
6930         (aarch64_analyze_prologue_test): Add PACIASP test.
6931         (aarch64_prologue_prev_register): Unmask PC value.
6932
6933 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6934             Jiong Wang  <jiong.wang@arm.com>
6935
6936         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6937         (aarch64_dwarf2_prev_register): Unmask PC value.
6938         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6939         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6940         DW_CFA_AARCH64_negate_ra_state.
6941         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6942
6943 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6944             Jiong Wang  <jiong.wang@arm.com>
6945
6946         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6947         registers.
6948         (aarch64_pseudo_register_name): Likewise.
6949         (aarch64_pseudo_register_type): Likewise.
6950         (aarch64_pseudo_register_reggroup_p): Likewise.
6951         (aarch64_gdbarch_init): Add pauth registers.
6952         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6953         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6954         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6955         (struct gdbarch_tdep): Add regnum for ra_state.
6956
6957 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6958             Jiong Wang  <jiong.wang@arm.com>
6959
6960         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6961
6962 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6963             Jiong Wang  <jiong.wang@arm.com>
6964
6965         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6966         function.
6967         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6968         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6969         (aarch64_gdbarch_init): Add puth registers.
6970         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6971         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6972         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6973
6974 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6975             Jiong Wang  <jiong.wang@arm.com>
6976
6977         * aarch64-linux-nat.c
6978         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6979         * aarch64-linux-tdep.c
6980         (aarch64_linux_core_read_description): Likewise.
6981         (aarch64_linux_get_hwcap): New function.
6982         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6983         (aarch64_linux_get_hwcap): New declaration.
6984
6985 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6986             Jiong Wang  <jiong.wang@arm.com>
6987
6988         * aarch64-linux-nat.c
6989         (aarch64_linux_nat_target::read_description): Add pauth param.
6990         * aarch64-linux-tdep.c
6991         (aarch64_linux_core_read_description): Likewise.
6992         * aarch64-tdep.c (struct target_desc): Add in pauth.
6993         (aarch64_read_description): Add pauth param.
6994         (aarch64_gdbarch_init): Likewise.
6995         * aarch64-tdep.h (aarch64_read_description): Likewise.
6996         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6997         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6998         * features/Makefile: Add new files.
6999         * features/aarch64-pauth.c: New file.
7000         * features/aarch64-pauth.xml: New file.
7001
7002 2019-03-20  Tom Tromey  <tromey@adacore.com>
7003
7004         * infrun.c (handle_inferior_event): Rename from
7005         handle_inferior_event_1.  Create a scoped_value_mark.
7006         (handle_inferior_event): Remove.
7007
7008 2019-03-19  Tom Tromey  <tromey@adacore.com>
7009
7010         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
7011         * infrun.h (print_stop_event): Add "displays" parameter.
7012         * infrun.c (print_stop_event): Add "displays" parameter.
7013
7014 2019-03-19  Pedro Alves  <palves@redhat.com>
7015
7016         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7017         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7018         to -1.  Fix TABs vs spaces.
7019         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7020         * tui/tui-out.h (tui_ui_out) Add intro comments.
7021         <m_line, m_start_of_line>: In-class initialize, and add describing
7022         comment.
7023
7024 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7025
7026         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7027         variable names.
7028         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7029
7030 2019-03-18  Pedro Alves  <palves@redhat.com>
7031             Eli Zaretskii <eliz@gnu.org>
7032
7033         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7034         m_line and m_start_of_line.
7035
7036 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7037
7038         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7039         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7040         it returns a newline.  This fixes a regression in TU mode, whereby
7041         the next line is output on the same screen line as the user input.
7042
7043 2019-03-18  Tom Tromey  <tromey@adacore.com>
7044
7045         * minsyms.c (minimal_symbol_reader::install): Remove call to
7046         obstack_blank.
7047
7048 2019-03-18  Pedro Alves  <palves@redhat.com>
7049
7050         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7051         New globals.
7052         (apply_style): New, factored out from ...
7053         (apply_ansi_escape): ... this.  Handle reverse video mode.
7054         (tui_set_reverse_mode): New function.
7055         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7056         * tui/tui-winsource.c (tui_show_source_line): Use
7057         tui_set_reverse_mode instead of setting A_STANDOUT.
7058         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7059         New setter methods.
7060
7061 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7062
7063         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7064         Handle tabs.
7065
7066 2019-03-18  Tom Tromey  <tromey@adacore.com>
7067
7068         * ada-lang.c (empty_array): Add "high" parameter.
7069         (ada_evaluate_subexp): Update.
7070
7071 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7072
7073         * unittests/string_view-selftests.c: Define
7074         _initialize_string_view_selftests unconditionally.
7075
7076 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7077
7078         PR gdb/24350
7079         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7080
7081 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7082
7083         PR gdb/24351
7084         * windows-nat.c (display_selector): Fix format specifiers.
7085
7086 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7087
7088         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7089         tui_refill_source_window instead of tui_refresh_win, to update the
7090         current execution line.  This fixes redisplay of the current line
7091         when stepping through the code with "next" or "step".
7092
7093 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7094
7095         * source-cache.c (source_cache::get_source_lines): Call
7096         find_source_lines to initialize s->nlines.  This fixes vertical
7097         scrolling of TUI source window when the DOWN arrow is pressed.
7098
7099 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7100
7101         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7102         linux-thread-db.c (_initialize_thread_db): Likewise.
7103
7104 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7105
7106         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7107         wclrtoeol in tui_show_source_line".  This reverts changes made in
7108         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7109
7110 2019-03-15  Tom Tromey  <tom@tromey.com>
7111
7112         * symtab.h (struct minimal_symbol): Derive from
7113         general_symbol_info.
7114         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7115         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7116         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7117         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7118         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7119         (MSYMBOL_SEARCH_NAME): Update.
7120         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7121         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7122         * minsyms.c (minimal_symbol_reader::record_full): Update.
7123
7124 2019-03-15  Tom Tromey  <tom@tromey.com>
7125
7126         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7127
7128 2019-03-15  Tom Tromey  <tom@tromey.com>
7129
7130         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7131         unique_xmalloc_ptr.
7132         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7133         Update.
7134         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7135         (build_minimal_symbol_hash_tables)
7136         (minimal_symbol_reader::install): Update.
7137
7138 2019-03-15  Tom Tromey  <tom@tromey.com>
7139
7140         * symtab.c (create_demangled_names_hash): Update.
7141         (symbol_set_names): Update.
7142         * objfiles.h (struct objfile_per_bfd_storage)
7143         <demangled_names_hash>: Now an htab_up.
7144         * objfiles.c (objfile_per_bfd_storage): Simplify.
7145
7146 2019-03-15  Tom Tromey  <tom@tromey.com>
7147
7148         * objfiles.h (struct objfile_per_bfd_storage): Declare
7149         destructor.
7150         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7151         New.
7152         (get_objfile_bfd_data): Use new.  Don't initialize
7153         language_of_main.
7154         (free_objfile_per_bfd_storage): Remove.
7155         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7156
7157 2019-03-15  Tom Tromey  <tom@tromey.com>
7158
7159         * symfile.c (reread_symbols): Update.
7160         * objfiles.c (objfile::objfile): Update.
7161         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7162         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7163         comment.
7164         (minimal_symbol_reader::install): Update.
7165         (terminate_minimal_symbol_table): Remove.
7166         * jit.c (jit_object_close_impl): Update.
7167
7168 2019-03-15  Tom Tromey  <tom@tromey.com>
7169
7170         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7171         initializations.
7172
7173 2019-03-15  Tom Tromey  <tom@tromey.com>
7174
7175         * objfiles.h (struct objfile_per_bfd_storage)
7176         <demangled_hash_languages>: Now a bitset.
7177         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7178         (lookup_minimal_symbol): Update.
7179
7180 2019-03-15  Tom Tromey  <tom@tromey.com>
7181
7182         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7183         Don't return the symbol.
7184         * coffread.c (record_minimal_symbol): Use record_full.
7185
7186 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7187
7188         The MS-Windows port of ncurses fails to switch to a color pair if
7189         one or both of the colors are the implicit default colors.  This
7190         change records the default colors when TUI is initialized, and
7191         then specifies them explicitly when a color pair uses the default
7192         colors.  This allows color styling in TUI mode on MS-Windows.
7193
7194         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7195         ncurses_norm_attr.
7196         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7197         colors in ncurses_norm_attr.
7198         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7199         "none", replace it with the default color recorded in
7200         ncurses_norm_attr.
7201
7202 2019-03-14  Tom Tromey  <tromey@adacore.com>
7203
7204         * source-cache.h (class source_cache) <get_source_lines>: Return
7205         std::string.
7206         * source-cache.c (source_cache::extract_lines): Handle case where
7207         first_pos==npos.  Return std::string.
7208         (source_cache::get_source_lines): Update.
7209
7210 2019-03-14  Tom Tromey  <tromey@adacore.com>
7211
7212         * NEWS: Add item for "style sources" commands.
7213         * source-cache.c (source_cache::get_source_lines): Check
7214         source_styling.
7215         * cli/cli-style.c (source_styling): New global.
7216         (_initialize_cli_style): Add "style sources" commands.
7217         (show_style_sources): New function.
7218         * cli/cli-style.h (source_styling): Declare.
7219
7220 2019-03-14  Pedro Alves  <palves@redhat.com>
7221             Tom Tromey  <tromey@adacore.com>
7222
7223         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7224         * tui/tui-winsource.c (tui_refill_source_window): New function,
7225         from...
7226         (tui_horizontal_source_scroll): ... here.  Move some logic.
7227         * cli/cli-style.c (set_style_enabled): Notify new observable.
7228         * tui/tui-hooks.c (tui_redisplay_source): New function.
7229         (tui_attach_detach_observers): Attach or detach
7230         tui_redisplay_source.
7231         * observable.h (source_styling_changed): New observable.
7232         * observable.c: Define source_styling_changed observable.
7233
7234 2019-03-13  Tom Tromey  <tromey@adacore.com>
7235
7236         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7237         (i386_gnu_nat_target::store_registers): Update.
7238         * target-debug.h (target_debug_print_std_string): New macro.
7239         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7240         * windows-tdep.c (display_one_tib): Update.
7241         * tui/tui-stack.c (tui_make_status_line): Update.
7242         * top.c (print_inferior_quit_action): Update.
7243         * thread.c (thr_try_catch_cmd): Update.
7244         (add_thread_with_info): Update.
7245         (thread_target_id_str): Update.
7246         (thr_try_catch_cmd): Update.
7247         (thread_command): Update.
7248         (thread_find_command): Update.
7249         * record-btrace.c (record_btrace_target::info_record)
7250         (record_btrace_resume_thread, record_btrace_target::resume)
7251         (record_btrace_cancel_resume, record_btrace_step_thread)
7252         (record_btrace_target::wait, record_btrace_target::wait)
7253         (record_btrace_target::wait, record_btrace_target::stop): Update.
7254         * progspace.c (print_program_space): Update.
7255         * process-stratum-target.c
7256         (process_stratum_target::thread_address_space): Update.
7257         * linux-fork.c (linux_fork_mourn_inferior)
7258         (detach_checkpoint_command, info_checkpoints_command)
7259         (linux_fork_context): Update.
7260         (linux_fork_detach): Update.
7261         (class scoped_switch_fork_info): Update.
7262         (delete_checkpoint_command): Update.
7263         * infrun.c (follow_fork_inferior): Update.
7264         (follow_fork_inferior): Update.
7265         (proceed_after_vfork_done): Update.
7266         (handle_vfork_child_exec_or_exit): Update.
7267         (follow_exec): Update.
7268         (displaced_step_prepare_throw): Update.
7269         (displaced_step_restore): Update.
7270         (start_step_over): Update.
7271         (resume_1): Update.
7272         (clear_proceed_status_thread): Update.
7273         (proceed): Update.
7274         (print_target_wait_results): Update.
7275         (do_target_wait): Update.
7276         (context_switch): Update.
7277         (stop_all_threads): Update.
7278         (restart_threads): Update.
7279         (finish_step_over): Update.
7280         (handle_signal_stop): Update.
7281         (switch_back_to_stepped_thread): Update.
7282         (keep_going_pass_signal): Update.
7283         (print_exited_reason): Update.
7284         (normal_stop): Update.
7285         * inferior.c (inferior_pid_to_str): Change return type.
7286         (print_selected_inferior): Update.
7287         (add_inferior): Update.
7288         (detach_inferior): Update.
7289         * dummy-frame.c (fprint_dummy_frames): Update.
7290         * dcache.c (dcache_info_1): Update.
7291         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7292         (btrace_fetch, btrace_clear): Update.
7293         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7294         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7295         type.
7296         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7297         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7298         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7299         * gdbarch.c, gdbarch.h: Rebuild.
7300         * gdbarch.sh (core_pid_to_str): Change return type.
7301         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7302         return type.
7303         (windows_nat_target::pid_to_str): Change return type.
7304         (windows_delete_thread): Update.
7305         (windows_nat_target::attach): Update.
7306         (windows_nat_target::files_info): Update.
7307         * target-delegates.c: Rebuild.
7308         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7309         return type.
7310         (sol_thread_target::pid_to_str): Change return type.
7311         * remote.c (class remote_target) <pid_to_str>: Change return
7312         type.
7313         (remote_target::pid_to_str): Change return type.
7314         (extended_remote_target::attach, remote_target::remote_stop_ns)
7315         (remote_target::remote_notif_remove_queued_reply)
7316         (remote_target::push_stop_reply, remote_target::disable_btrace):
7317         Update.
7318         (extended_remote_target::attach): Update.
7319         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7320         type.
7321         (gdbsim_target::pid_to_str): Change return type.
7322         * ravenscar-thread.c (struct ravenscar_thread_target)
7323         <pid_to_str>: Change return type.
7324         (ravenscar_thread_target::pid_to_str): Change return type.
7325         * procfs.c (class procfs_target) <pid_to_str>: Change return
7326         type.
7327         (procfs_target::pid_to_str): Change return type.
7328         (procfs_target::attach): Update.
7329         (procfs_target::detach): Update.
7330         (procfs_target::fetch_registers): Update.
7331         (procfs_target::store_registers): Update.
7332         (procfs_target::wait): Update.
7333         (procfs_target::files_info): Update.
7334         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7335         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7336         return type.
7337         (nto_procfs_target::pid_to_str): Change return type.
7338         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7339         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7340         return type.
7341         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7342         (exit_lwp): Update.
7343         (attach_proc_task_lwp_callback, get_detach_signal)
7344         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7345         (linux_nat_target::resume, wait_lwp, stop_callback)
7346         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7347         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7348         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7349         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7350         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7351         type.
7352         (inf_ptrace_target::attach): Update.
7353         (inf_ptrace_target::files_info): Update.
7354         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7355         type.
7356         (go32_nat_target::pid_to_str): Change return type.
7357         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7358         (gnu_nat_target::wait): Update.
7359         (gnu_nat_target::wait): Update.
7360         (gnu_nat_target::resume): Update.
7361         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7362         (fbsd_nat_target::wait): Update.
7363         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7364         type.
7365         (darwin_nat_target::attach): Update.
7366         * corelow.c (class core_target) <pid_to_str>: Change return type.
7367         (core_target::pid_to_str): Change return type.
7368         * target.c (normal_pid_to_str): Change return type.
7369         (default_pid_to_str): Likewise.
7370         (target_pid_to_str): Change return type.
7371         (target_translate_tls_address): Update.
7372         (target_announce_detach): Update.
7373         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7374         return type.
7375         (bsd_uthread_target::pid_to_str): Change return type.
7376         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7377         type.
7378         (bsd_kvm_target::pid_to_str): Change return type.
7379         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7380         return type.
7381         (aix_thread_target::pid_to_str): Change return type.
7382         * target.h (struct target_ops) <pid_to_str>: Change return type.
7383         (target_pid_to_str, normal_pid_to_str): Likewise.
7384         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7385         type.
7386         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7387         type.
7388         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7389         return type.
7390         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7391         type.
7392         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7393         type.
7394         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7395         return type.
7396
7397 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7398
7399         * NEWS: Mention that the new default MI version is 3.  Mention
7400         changes to the output of commands and events that deal with
7401         multi-location breakpoints.
7402         * breakpoint.c: Include "mi/mi-out.h".
7403         (print_one_breakpoint): Change output syntax if using MI version
7404         >= 3.
7405         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7406         New.
7407         (mi_multi_location_breakpoint_output_fixed): New.
7408         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7409         (mi_cmd_fix_multi_location_breakpoint_output): New.
7410         (mi_multi_location_breakpoint_output_fixed): New.
7411         * mi/mi-cmds.c (mi_cmds): Register command
7412         -fix-multi-location-breakpoint-output.
7413         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7414         interpreter "mi".
7415
7416 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7417
7418         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7419         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7420         instantiate mi_ui_out based on interpreter name.
7421         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7422         * mi/mi-main.c (mi_load_progress): Likewise.
7423
7424 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7425
7426         * NEWS: Combine separate "New targets" sections for 8.3.
7427
7428 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7429
7430         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7431         (ppcfbsd_init_abi): Install gdbarch
7432         "fetch_tls_load_module_address" and "get_thread_local_address"
7433         methods.
7434
7435 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7436
7437         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7438         (riscv_fbsd_init_abi): Install gdbarch
7439         "fetch_tls_load_module_address" and "get_thread_local_address"
7440         methods.
7441
7442 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7443
7444         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7445         (i386fbsd_init_abi): Install gdbarch
7446         "fetch_tls_load_module_address" and "get_thread_local_address"
7447         methods.
7448
7449 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7450
7451         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7452         (amd64fbsd_init_abi): Install gdbarch
7453         "fetch_tls_load_module_address" and "get_thread_local_address"
7454         methods.
7455
7456 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7457
7458         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7459         (struct fbsd_pspace_data): New type.
7460         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7461         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7462         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7463         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7464         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7465
7466 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7467
7468         * gdbtypes.c (lookup_struct_elt): New function.
7469         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7470         * gdbtypes.h (struct struct_elt): New type.
7471         (lookup_struct_elt): New prototype.
7472
7473 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7474
7475         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7476         remove disabled code block.
7477
7478 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7479
7480         * gdbarch.sh (get_thread_local_address): New method.
7481         * gdbarch.h, gdbarch.c: Regenerate.
7482         * target.c (target_translate_tls_address): Use
7483         gdbarch_get_thread_local_address if present instead of
7484         target::get_thread_local_address.
7485
7486 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7487
7488         * target.h (target::get_thread_local_address): Update comment.
7489
7490 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7491
7492         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7493         objfile->separate_debug_objfile_backlink if not NULL.
7494
7495 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7496
7497         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7498         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7499         (amd64bsd_store_inferior_registers): Likewise.
7500         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7501         Enable segment base registers.
7502         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7503         PT_GETFSBASE and PT_GETGSBASE.
7504         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7505         PT_SETGSBASE.
7506         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7507         segment base registers.
7508         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7509
7510 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7511
7512         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7513         Update calls to i386_target_description to add 'segments'
7514         parameter.
7515         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7516         add segment base registers.
7517         * arch/i386.c (i386_create_target_description): Add 'segments'
7518         parameter to enable segment base registers.
7519         * arch/i386.h (i386_create_target_description): Likewise.
7520         * features/i386/32bit-segments.xml: New file.
7521         * features/i386/32bit-segments.c: Generate.
7522         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7523         call to i386_target_description to add 'segments' parameter.
7524         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7525         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7526         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7527         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7528         if feature is present.
7529         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7530         Add 'segments' parameter to call to i386_target_description.
7531         (i386_target_description): Add 'segments' parameter to enable
7532         segment base registers.
7533         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7534         to call to i386_target_description.
7535         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7536         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7537         Define I386_NUM_REGS.
7538         (i386_target_description): Add 'segments' parameter to enable
7539         segment base registers.
7540
7541 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7542
7543         PR/24325
7544         * source-cache.c: #undef open and close, to avoid unresolved
7545         externals during linking.
7546
7547 2019-03-12  Tom Tromey  <tromey@adacore.com>
7548
7549         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7550         const.  Add initializers.
7551         (_initialize_remote): Don't initialize ptid globals.
7552
7553 2019-03-12  Pedro Alves  <palves@redhat.com>
7554
7555         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7556
7557 2019-03-12  Pedro Alves  <palves@redhat.com>
7558
7559         * cp-name-parser.y (main): Remove unused 'len' variable.
7560
7561 2019-03-12  Tom Tromey  <tromey@adacore.com>
7562
7563         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7564         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7565
7566 2019-03-12  Tom Tromey  <tromey@adacore.com>
7567
7568         * linux-nat.c (iterate_over_lwps): Update.
7569         (stop_callback): Remove parameter.
7570         (stop_wait_callback, detach_callback, resume_set_callback)
7571         (select_singlestep_lwp_callback, set_ignore_sigint)
7572         (status_callback, resumed_callback, resume_clear_callback)
7573         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7574         data parameter.
7575         (linux_nat_target::detach, linux_nat_target::resume)
7576         (linux_stop_and_wait_all_lwps, select_event_lwp)
7577         (linux_nat_filter_event, linux_nat_wait_1)
7578         (linux_nat_target::kill, linux_nat_target::stop)
7579         (linux_nat_target::stop): Update.
7580         (linux_nat_resume_callback): Change type.
7581         (resume_stopped_resumed_lwps, count_events_callback)
7582         (select_event_lwp_callback): Likewise.
7583         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7584         * arm-linux-nat.c (struct update_registers_data): Remove.
7585         (update_registers_callback): Change type.
7586         (arm_linux_insert_hw_breakpoint1): Update.
7587         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7588         parameter.
7589         (x86_linux_dr_set_addr): Update.
7590         (x86_linux_dr_set_control): Update.
7591         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7592         (iterate_over_lwps): Use gdb::function_view.
7593         * nat/aarch64-linux-hw-point.c (struct
7594         aarch64_dr_update_callback_param): Remove.
7595         (debug_reg_change_callback): Change type.
7596         (aarch64_notify_debug_reg_change): Update.
7597         * s390-linux-nat.c (s390_refresh_per_info): Update.
7598
7599 2019-03-11  Tom Tromey  <tromey@adacore.com>
7600
7601         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7602         redundant assignment to "this_cu".
7603
7604 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7605
7606         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7607
7608 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7609
7610         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7611         from...
7612         (rank_one_type): ... this.
7613
7614 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7615
7616         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7617         from...
7618         (rank_one_type): ... this.
7619
7620 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7621
7622         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7623         from...
7624         (rank_one_type): ... this.
7625
7626 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7627
7628         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7629         from...
7630         (rank_one_type): ... this.
7631
7632 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7633
7634         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7635         from...
7636         (rank_one_type): ... this.
7637
7638 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7639
7640         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7641         from...
7642         (rank_one_type): ... this.
7643
7644 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7645
7646         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7647         from...
7648         (rank_one_type): ... this.
7649
7650 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7651
7652         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7653         from...
7654         (rank_one_type): ... this.
7655
7656 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7657
7658         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7659         from...
7660         (rank_one_type): ... this.
7661
7662 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7663
7664         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7665         from...
7666         (rank_one_type): ... this.
7667
7668 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7669
7670         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7671         from...
7672         (rank_one_type): ... this.
7673
7674 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7675
7676         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7677         from...
7678         (rank_one_type): ... this.
7679
7680 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7681
7682         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7683         inferior-events' shows the example events.
7684
7685 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7686
7687         Support styling on native MS-Windows console
7688
7689         PR/24315
7690         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7691         on MS-Windows if $TERM is not defined.
7692
7693         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7694
7695         * posix-hdep.c (gdb_console_fputs):
7696         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7697         functions.
7698         * ui-file.h (gdb_console_fputs): Add prototype.
7699
7700         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7701         back to fputs only if the former returns zero.
7702
7703 2019-03-07  Tom Tromey  <tom@tromey.com>
7704
7705         * symmisc.c (print_symbol_bcache_statistics): Update.
7706         (print_objfile_statistics): Update.
7707         * symfile.c (allocate_symtab): Update.
7708         * stabsread.c: Don't include bcache.h.
7709         * psymtab.h (struct psymbol_bcache): Don't declare.
7710         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7711         (psymbol_bcache_init, psymbol_bcache_free)
7712         (psymbol_bcache_get_bcache): Don't declare.
7713         * psymtab.c (struct psymbol_bcache): Remove.
7714         (psymtab_storage::psymtab_storage): Update.
7715         (psymtab_storage::~psymtab_storage): Update.
7716         (psymbol_bcache_init, psymbol_bcache_free)
7717         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7718         (add_psymbol_to_bcache): Update.
7719         (allocate_psymtab): Update.
7720         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7721         macro_cache>: No longer pointers.
7722         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7723         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7724         * macrotab.c (macro_bcache): Update.
7725         * macroexp.c: Don't include bcache.h.
7726         * gdbtypes.c (check_types_worklist): Update.
7727         (types_deeply_equal): Remove TRY/CATCH.  Update.
7728         * elfread.c (elf_symtab_read): Update.
7729         * dwarf2read.c: Don't include bcache.h.
7730         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7731         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7732         (print_bcache_statistics, bcache_memory_used): Don't declare.
7733         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7734         methods.  Rename all data members.
7735         * bcache.c (struct bcache): Move to bcache.h.
7736         (bcache::expand_hash_table): Rename from expand_hash_table.
7737         (bcache): Remove.
7738         (bcache::insert): Rename from bcache_full.
7739         (bcache::compare): Rename from bcache_compare.
7740         (bcache_xmalloc): Remove.
7741         (bcache::~bcache): Rename from bcache_xfree.
7742         (bcache::print_statistics): Rename from print_bcache_statistics.
7743         (bcache::memory_used): Rename from bcache_memory_used.
7744
7745 2019-03-07  Pedro Alves  <palves@redhat.com>
7746
7747         * infrun.c (normal_stop): Also check for
7748         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7749
7750 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7751
7752         * f-lang.c (value_from_host_double): Moved to...
7753         * value.c (value_from_host_double): ...here.
7754         * value.h (value_from_host_double): Declare.
7755         * guile/scm-math.c (vlscm_convert_typed_number): Use
7756         value_from_host_double.
7757         (vlscm_convert_number): Likewise.
7758         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7759         * python/py-value.c (convert_value_from_python): Likewise.
7760
7761 2019-03-06  Tom Tromey  <tom@tromey.com>
7762
7763         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7764
7765 2019-03-06  Tom Tromey  <tom@tromey.com>
7766
7767         * utils.h (free_current_contents): Don't declare.
7768         * utils.c (free_current_contents): Remove.
7769
7770 2019-03-06  Tom Tromey  <tom@tromey.com>
7771
7772         * top.c (quit_force): Update.
7773         * main.c (captured_command_loop): Update.
7774         * common/new-op.c (operator new): Update.
7775         * common/common-exceptions.c (struct catcher)
7776         <save_cleanup_chain>: Remove member.
7777         (exceptions_state_mc_init): Update.
7778         (exception_try_scope_entry): Return nullptr.
7779         (exception_try_scope_exit, exception_rethrow)
7780         (throw_exception_sjlj, throw_exception_cxx): Update.
7781         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7782         (all_cleanups, do_cleanups, discard_cleanups)
7783         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7784         (restore_cleanups, restore_final_cleanups): Don't declare.
7785         (do_final_cleanups): Remove parameter.
7786         * common/cleanups.c (cleanup_chain, make_cleanup)
7787         (make_cleanup_dtor, all_cleanups, do_cleanups)
7788         (discard_my_cleanups, discard_cleanups)
7789         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7790         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7791         (null_cleanup): Remove.
7792         (do_final_cleanups): Remove parameter.
7793
7794 2019-03-06  Tom Tromey  <tom@tromey.com>
7795
7796         * remote.c (remote_target::remote_parse_stop_reply): Use
7797         unique_xmalloc_ptr.
7798
7799 2019-03-06  Tom Tromey  <tom@tromey.com>
7800
7801         * stabsread.c (struct stabs_field_info): Rename from field_info.
7802         <list, fnlist>: Add initializers.
7803         <obstack>: New member.
7804         (read_member_functions, read_struct_fields, read_baseclasses):
7805         Allocate on obstack.  Don't use cleanups.
7806         (read_one_struct_field, read_member_functions, read_struct_fields)
7807         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7808         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7809         (read_struct_type): Update.
7810
7811 2019-03-06  Tom Tromey  <tom@tromey.com>
7812
7813         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7814         * common/filestuff.h (make_cleanup_close): Don't declare.
7815         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7816         Remove.
7817
7818 2019-03-06  Tom Tromey  <tom@tromey.com>
7819
7820         * solib-aix.c: Use make_scope_exit.
7821
7822 2019-03-06  Tom Tromey  <tom@tromey.com>
7823
7824         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7825         Use make_scope_exit.
7826
7827 2019-03-06  Tom Tromey  <tom@tromey.com>
7828
7829         * solib-svr4.c (disable_probes_interface): Remove parameter.
7830         (svr4_handle_solib_event): Use make_scope_exit.
7831
7832 2019-03-06  Tom Tromey  <tom@tromey.com>
7833
7834         * remote.c (struct stop_reply_deleter): Remove.
7835         (stop_reply_up): Update.
7836         (struct stop_reply): Derive from notif_event.  Don't typedef.
7837         <regcache>: Now a std::vector.
7838         (stop_reply_xfree): Remove.
7839         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7840         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7841         (remote_target::discard_pending_stop_replies): Use delete.
7842         (remote_target::remote_parse_stop_reply): Update.
7843         (remote_target::process_stop_reply): Update.
7844         * remote-notif.h (struct notif_event): Add virtual destructor.
7845         Remove "dtr" member.
7846         (struct notif_client) <alloc_event>: Return a unique_ptr.
7847         (notif_event_xfree): Don't declare.
7848         (notif_event_up): New typedef.
7849         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7850         (notif_event_xfree, do_notif_event_xfree): Remove.
7851         (remote_notif_state_xfree): Update.
7852
7853 2019-03-06  Tom Tromey  <tom@tromey.com>
7854
7855         * infrun.c (displaced_step_clear_cleanup): Now a
7856         forward_scope_exit type.
7857         (displaced_step_prepare_throw): Update.
7858         (displaced_step_fixup): Update.
7859
7860 2019-03-06  Tom Tromey  <tom@tromey.com>
7861
7862         * inferior.h (class inferior): Update comment.
7863         * gdbthread.h (class thread_info): Update comment.
7864
7865 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7866             Tom Tromey  <tom@tromey.com>
7867
7868         * stabsread.h (struct stab_section_list): Remove.
7869         (coffstab_build_psymtabs): Update.
7870         * dbxread.c (symbuf_sections): Now a std::vector.
7871         (sect_idx): New global.
7872         (fill_symbuf): Update.
7873         (coffstab_build_psymtabs): Change type of stabsects parameter.
7874         Update.
7875         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7876         std::vector.
7877         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7878         (coff_locate_sections): Update.
7879         (coff_symfile_read): Remove cleanups.  Update.
7880         (init_stringtab): Add storage parameter.
7881         (free_stringtab, free_stringtab_cleanup): Remove.
7882         (init_lineno): Add storage parameter.
7883         (free_linetab, free_linetab_cleanup): Remove.
7884
7885 2019-03-06  Pedro Alves  <palves@redhat.com>
7886
7887         * linux-fork.c (fork_info::clobber_regs): Delete.
7888         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7889         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7890         comment.  Adjust.
7891         (scoped_switch_fork_info::scoped_switch_fork_info)
7892         (checkpoint_command, linux_fork_context): Adjust
7893         fork_save_infrun_state calls.
7894
7895 2019-03-06  Pedro Alves  <palves@redhat.com>
7896
7897         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7898         (inf_has_multiple_threads): Return 'bool' and rewrite using
7899         inferior_info::threads().
7900
7901 2019-03-06  Pedro Alves  <palves@redhat.com>
7902
7903         * linux-fork.c: Include <list>.
7904         (fork_list): Now a std::list instance.
7905         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7906         (forks_exist_p, find_last_fork): Adjust.
7907         (new_fork): Delete.
7908         (one_fork_p): New.
7909         (add_fork): Adjust.
7910         (free_fork): Delete, folded into fork_info::~fork_info().
7911         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7912         Adjust.
7913         (init_fork_list): Delete.
7914         (linux_fork_killall, linux_fork_mourn_inferior)
7915         (linux_fork_detach, info_checkpoints_command): Adjust.
7916         (_initialize_linux_fork): No longer call init_fork_list.
7917
7918 2019-03-06  Pedro Alves  <palves@redhat.com>
7919
7920         * linux-fork.c (new_fork): New, split out of ...
7921         (add_fork): ... this.  Return void.  Move "first fork" special
7922         case from here, to ...
7923         (checkpoint_command): ... here.
7924         * linux-linux.h (add_fork): Return void.
7925
7926 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7927
7928         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7929
7930 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7931             Chris January  <chris.january@arm.com>
7932             David Lecomber  <david.lecomber@arm.com>
7933
7934         * f-exp.y: New token, UNOP_INTRINSIC.
7935         (exp): New pattern using UNOP_INTRINSIC token.
7936         (f77_keywords): Add 'abs' keyword.
7937         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7938         (value_from_host_double): New function.
7939         (evaluate_subexp_f): Support UNOP_ABS.
7940
7941 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7942
7943         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7944         types.
7945
7946 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7947
7948         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7949         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7950         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7951
7952 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7953
7954         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7955
7956 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7957             Chris January  <chris.january@arm.com>
7958
7959         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7960         * f-exp.y: Define 'KIND' token.
7961         (exp): New pattern for KIND expressions.
7962         (ptype): Handle types with a kind extension.
7963         (direct_abs_decl): Extend to spot kind extensions.
7964         (f77_keywords): Add 'kind' to the list.
7965         (push_kind_type): New function.
7966         (convert_to_kind_type): New function.
7967         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7968         * parse.c (operator_length_standard): Likewise.
7969         * parser-defs.h (enum type_pieces): Add tp_kind.
7970         * std-operator.def: Add UNOP_KIND.
7971
7972 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7973
7974         * f-exp.y (f_parse): Set yydebug.
7975
7976 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7977
7978         * f-lang.c (evaluate_subexp_f): New function.
7979         (exp_descriptor_f): New global.
7980         (f_language_defn): Use exp_descriptor_f instead of
7981         exp_descriptor_standard.
7982
7983 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7984
7985         * f-exp.y (struct token): Add comments.
7986         (dot_ops): Remove uppercase versions and the end marker.
7987         (f77_keywords): Likewise.
7988         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7989         entries in the dot_ops array are case insensitive, and use
7990         strncasecmp to compare strings.  Also some whitespace cleanup in
7991         this area.  Similar for the f77_keywords array, except entries in
7992         this list might be case sensitive.
7993
7994 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7995
7996         * f-exp.y (struct f77_boolean_val): Add comments.
7997         (boolean_values): Remove uppercase versions, and end marker.
7998         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7999         and use strncasecmp to achieve case insensitivity.  Additionally,
8000         perform whitespace cleanup around this code.
8001
8002 2019-03-06  Tom Tromey  <tromey@adacore.com>
8003
8004         * remote-sim.c (gdbsim_target_open): Use result of
8005         gdb_argv::release.
8006
8007 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
8008         Dirk Schubert  <dirk.schubert@arm.com>
8009         Chris January  <chris.january@arm.com>
8010
8011         * eval.c (evaluate_subexp_standard): Call Fortran argument
8012         wrapping logic.
8013         * f-lang.c (struct value): A value which can be passed into a
8014         Fortran function call.
8015         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8016         where appropriate.
8017         (struct type): Value ready for a Fortran function call.
8018         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8019         is needed.
8020         * f-lang.h (fortran_argument_convert): Declaration.
8021         (fortran_preserve_arg_pointer): Declaration.
8022         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8023
8024 2019-03-05  Tom Tromey  <tromey@adacore.com>
8025
8026         * python/py-prettyprint.c (print_string_repr): Remove #if.
8027         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8028
8029 2019-03-05  Tom Tromey  <tromey@adacore.com>
8030
8031         * target.c (the_dummy_target): Move later.  Change type to
8032         "dummy_target".
8033         (initialize_targets): Don't initialize the_dummy_target.
8034
8035 2019-03-05  Tom Tromey  <tromey@adacore.com>
8036
8037         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8038         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8039
8040 2019-03-05  Tom Tromey  <tromey@adacore.com>
8041
8042         * windows-nat.c (windows_nat_target::attach)
8043         (windows_nat_target::detach): Don't call gdb_flush.
8044         * valprint.c (generic_val_print, val_print, val_print_string):
8045         Don't call gdb_flush.
8046         * utils.c (defaulted_query): Don't call gdb_flush.
8047         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8048         * target.c (target_announce_detach): Don't call gdb_flush.
8049         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8050         * remote.c (extended_remote_target::attach): Don't call
8051         gdb_flush.
8052         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8053         * printcmd.c (do_examine): Don't call gdb_flush.
8054         (info_display_command): Don't call gdb_flush.
8055         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8056         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8057         * memattr.c (info_mem_command): Don't call gdb_flush.
8058         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8059         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8060         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8061         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8062         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8063         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8064         (gnu_nat_target::detach): Don't call gdb_flush.
8065         * f-valprint.c (f_val_print): Don't call gdb_flush.
8066         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8067         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8068         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8069         gdb_flush.
8070         * c-valprint.c (c_val_print): Don't call gdb_flush.
8071         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8072
8073 2019-03-05  Tom Tromey  <tromey@adacore.com>
8074
8075         * varobj.c (update_dynamic_varobj_children): Update.
8076         (install_default_visualizer): Use reset, not release.
8077         * value.c (set_internalvar): Update.
8078         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8079         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8080         ATTRIBUTE_UNUSED_RESULT.
8081
8082 2019-03-05  Tom Tromey  <tromey@adacore.com>
8083
8084         * remote.c (class scoped_remote_fd) <release>: Add
8085         ATTRIBUTE_UNUSED_RESULT.
8086
8087 2019-03-05  Tom Tromey  <tromey@adacore.com>
8088
8089         * macroexp.c (struct macro_buffer) <release>: Add
8090         ATTRIBUTE_UNUSED_RESULT.
8091
8092 2019-03-05  Tom Tromey  <tromey@adacore.com>
8093
8094         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8095         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8096         ATTRIBUTE_UNUSED_RESULT.
8097
8098 2019-03-05  Tom Tromey  <tromey@adacore.com>
8099
8100         * common/scoped_fd.h (class scoped_fd) <release>: Add
8101         ATTRIBUTE_UNUSED_RESULT.
8102
8103 2019-03-05  Tom Tromey  <tromey@adacore.com>
8104
8105         * parser-defs.h (struct parser_state) <release>: Add
8106         ATTRIBUTE_UNUSED_RESULT.
8107
8108 2019-03-05  Tom Tromey  <tromey@adacore.com>
8109
8110         * utils.h (class gdb_argv) <release>: Add
8111         ATTRIBUTE_UNUSED_RESULT.
8112         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8113
8114 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8115
8116         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8117         for-loop range, to avoid compiler warnings.
8118
8119         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8120         avoid compiler warnings about unused variables.
8121
8122         * NEWS: Mention end of support for native debugging on MS-Windows
8123         before XP.
8124
8125         PR gdb/24292
8126         * common/netstuff.c:
8127         * gdbserver/gdbreplay.c
8128         * gdbserver/remote-utils.c:
8129         * ser-tcp.c:
8130         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8131         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8132         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8133         'getaddrinfo' and 'freeaddrinfo' were not available before
8134         Windows XP, and mingw.org's MinGW headers by default define
8135         _WIN32_WINNT to 0x500.
8136
8137 2019-03-01  Gary Benson <gbenson@redhat.com>
8138
8139         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8140
8141 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8142             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8143
8144         PR gdb/8527
8145         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8146         set_sigint_trap, clear_sigint_trap.
8147
8148 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8149
8150         * target.c (target_detach): Clear the regcache and the
8151         frame cache.
8152
8153 2019-02-27  Pedro Alves  <palves@redhat.com>
8154
8155         * utils.c (set_screen_size): When we cap the height/width sizes,
8156         tweak the corresponding command variable to show "unlimited":
8157
8158 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8159             Pedro Alves  <palves@redhat.com>
8160
8161         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8162         before calling rl_set_screen_size.
8163
8164 2019-02-27  Tom Tromey  <tromey@adacore.com>
8165
8166         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8167         define.
8168         * python/py-value.c: Remove Python 2.4 workaround.
8169         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8170         workaround.
8171         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8172         Python 2.4 workaround.
8173         * python/python-internal.h: Remove Python 2.4 comment.
8174         (Py_ssize_t): Don't define.
8175         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8176         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8177         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8178         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8179         * python/python.c (do_start_initialization): Remove Python 2.4
8180         workaround.
8181         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8182         (print_children): Remove Python 2.4 workaround.
8183         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8184         workaround.
8185         (CHARBUFFERPROC_NAME): Remove.
8186         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8187         Python 2.4 workaround.
8188
8189 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8190
8191         * NEWS: Note minimum Python version.
8192
8193 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8194
8195         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8196         code from these functions.  Remove corresponding ifdefs.  Use
8197         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8198         Remove gotos and target of gotos.
8199         (infpy_search_memory): Likewise.
8200
8201 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8202
8203         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8204         (hppa_gdbarch_init): Don't register deleted functions with
8205         gdbarch.
8206
8207 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8208
8209         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8210         (h8300_unwind_sp): Delete.
8211         (h8300_dummy_id): Delete.
8212         (h8300_gdbarch_init): Don't register deleted functions with
8213         gdbarch.
8214
8215 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8216
8217         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8218         (ft32_unwind_pc): Delete.
8219         (ft32_unwind_sp): Delete.
8220         (ft32_gdbarch_init): Don't register deleted functions with
8221         gdbarch.
8222
8223 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8224
8225         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8226         (frv_unwind_pc): Delete.
8227         (frv_unwind_sp): Delete.
8228         (frv_gdbarch_init): Don't register deleted functions with
8229         gdbarch.
8230
8231 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8232
8233         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8234         (riscv_unwind_pc): Delete.
8235         (riscv_unwind_sp): Delete.
8236         (riscv_gdbarch_init): Don't register deleted functions with
8237         gdbarch.
8238
8239 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8240
8241         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8242         (csky_unwind_pc): Delete.
8243         (csky_unwind_sp): Delete.
8244         (csky_gdbarch_init): Don't register deleted functions with
8245         gdbarch.
8246
8247 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8248
8249         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8250         (cris_unwind_pc): Delete.
8251         (cris_unwind_sp): Delete.
8252         (cris_gdbarch_init): Don't register deleted functions with
8253         gdbarch.
8254
8255 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8256
8257         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8258         (bfin_unwind_pc): Delete.
8259         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8260
8261 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8262
8263         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8264         (arm_unwind_pc): Delete.
8265         (arm_unwind_sp): Delete.
8266         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8267
8268 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8269
8270         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8271         (arc_unwind_pc): Delete.
8272         (arc_unwind_sp): Delete.
8273         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8274
8275 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8276
8277         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8278         (alpha_unwind_pc): Delete.
8279         (alpha_gdbarch_init): Don't register deleted functions with
8280         gdbarch.
8281
8282 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8283
8284         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8285         (aarch64_unwind_pc): Delete.
8286         (aarch64_unwind_sp): Delete.
8287         (aarch64_gdbarch_init): Don't register deleted functions with
8288         gdbarch.
8289
8290 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8291
8292         * gdbtypes.c (type_align): Don't consider static members when
8293         computing structure alignment.
8294
8295 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8296
8297         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8298         return 0 for other types.
8299         * arch-utils.c (default_type_align): Always return 0.
8300         * gdbarch.h: Regenerate.
8301         * gdbarch.sh (type_align): Extend comment.
8302         * gdbtypes.c (type_align): Add additional comments, always call
8303         gdbarch_type_align before applying the default rules.
8304         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8305         generic code will then apply a suitable default.
8306         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8307         types, return 0 for other types.
8308
8309 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8310
8311         * NEWS: Create a new section for the next release branch.
8312         Rename the section of the current branch, now that it has
8313         been cut.
8314
8315 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8316
8317         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8318         * version.in: Bump version to 8.3.50.DATE-git.
8319
8320 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8321
8322         * aix-thread.c (ptid_cmp): Remove unused variable.
8323         (get_signaled_thread): Likewise.
8324         (store_regs_user_thread): Likewise.
8325         (store_regs_kernel_thread): Likewise.
8326         (fetch_regs_kernel_thread): Remove shadowed variable.
8327
8328 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8329
8330         * features/riscv/32bit-cpu.xml: Add register numbers.
8331         * features/riscv/32bit-fpu.c: Regenerate.
8332         * features/riscv/32bit-fpu.xml: Add register numbers.
8333         * features/riscv/64bit-cpu.xml: Add register numbers.
8334         * features/riscv/64bit-fpu.c: Regenerate.
8335         * features/riscv/64bit-fpu.xml: Add register numbers.
8336
8337 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8338
8339         * NEWS: Mention two argument form of gdb.Value constructor.
8340         * python/py-value.c (convert_buffer_and_type_to_value): New
8341         function.
8342         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8343         Add support for handling an optional second argument.  Call
8344         convert_buffer_and_type_to_value as appropriate.
8345         * python/python-internal.h (Py_buffer_deleter): New struct.
8346         (Py_buffer_up): New typedef.
8347
8348 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8349
8350         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8351         instead of releasing ownership.
8352
8353 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8354
8355         * dwarf2read.c (open_and_init_dwp_file): Call
8356         elf_numsections instead of bfd_count_sections to initialize
8357         dwp_file->num_sections.
8358
8359 2019-02-25  Tom Tromey  <tromey@adacore.com>
8360
8361         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8362
8363 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8364
8365         * gcore.in: Add '--readnever' option when invoking GDB.
8366
8367 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8368
8369         * MAINTAINERS: Update my email address.
8370
8371 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8372
8373         * build-id.c (build_id_to_debug_bfd_1): New function.
8374         (build_id_to_debug_bfd): Look for separate debug file in
8375         sysroot.
8376
8377 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8378
8379         * gdbarch.sh: Update the copyright year range that is placed into
8380         generated files.
8381
8382 2019-02-22  Keith Seitz  <keiths@redhat.com>
8383
8384         PR symtab/23853
8385         * linespec.c (create_sals_line_offset): Search for the default
8386         symtab's filename instead of its fullname.
8387
8388 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8389
8390         * NEWS: Update style defaults.
8391
8392 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8393
8394         * main.c (captured_main_1): Disable styling in batch mode.
8395
8396 2019-02-20  Tom Tromey  <tom@tromey.com>
8397
8398         * symtab.c (symtab_symbol_info): Fix typos.
8399
8400 2019-02-20  Tom Tromey  <tromey@adacore.com>
8401
8402         * findcmd.c (_initialize_mem_search): Use upper case for
8403         metasyntactic variables.
8404
8405 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8406
8407         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8408         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8409
8410 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8411
8412         * top.h (source_file_name): Change to std::string.
8413         * top.c (source_file_name): Likewise.
8414         (command_line_input): Adjust.
8415         * cli/cli-script.c (script_from_file): Adjust.
8416
8417 2019-02-19  Tom Tromey  <tromey@adacore.com>
8418
8419         * ravenscar-thread.c
8420         (ravenscar_thread_target::update_thread_list): Don't call
8421         ada_build_task_list.
8422         * ada-lang.h (ada_build_task_list): Don't declare.
8423         * ada-tasks.c (struct ada_tasks_inferior_data)
8424         <task_list_valid_p>: Now bool.
8425         (read_known_tasks, ada_task_list_changed)
8426         (ada_tasks_invalidate_inferior_data): Update.
8427         (read_known_tasks_array): Return bool.
8428         (read_known_tasks_list): Likewise.
8429         (read_known_tasks): Return void.
8430         (ada_build_task_list): Now static.
8431
8432 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8433
8434         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8435         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8436
8437 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8438
8439         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8440         variant for ada_tasks_pspace_data_handle and
8441         ada_tasks_inferior_data_handle.
8442         (ada_tasks_pspace_data_cleanup): New function.
8443         (ada_tasks_inferior_data_cleanup): New function.
8444
8445 2019-02-17  Tom Tromey  <tom@tromey.com>
8446
8447         * macrotab.h (macro_source_fullname): Return a std::string.
8448         * macrotab.c (macro_include, check_for_redefinition)
8449         (macro_undef, macro_lookup_definition, foreach_macro)
8450         (foreach_macro_in_scope): Update.
8451         (macro_source_fullname): Return a std::string.
8452         * macrocmd.c (show_pp_source_pos): Update.
8453
8454 2019-02-17  Tom Tromey  <tom@tromey.com>
8455
8456         * macrocmd.c (show_pp_source_pos): Style the file names.
8457
8458 2019-02-17  Tom Tromey  <tom@tromey.com>
8459
8460         PR tui/24197:
8461         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8462
8463 2019-02-17  Tom Tromey  <tom@tromey.com>
8464
8465         * ada-lang.c (user_select_syms): Use filtered printing.
8466         * utils.c (wrap_style): New global.
8467         (desired_style): Remove.
8468         (emit_style_escape): Add stream parameter.
8469         (set_output_style, reset_terminal_style, prompt_for_continue):
8470         Update.
8471         (flush_wrap_buffer): Only flush gdb_stdout.
8472         (wrap_here): Set wrap_style.
8473         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8474         treat escape sequences as a character.  Change when wrap buffer is
8475         flushed.
8476         (fputs_styled): Do not set the output style when the default is
8477         requested.
8478         * ui-style.h (struct ui_file_style) <is_default>: New method.
8479         * source.c (print_source_lines_base): Emit escape sequences in one
8480         piece.
8481
8482 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8483
8484         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8485         integers and enumeration types.
8486
8487 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8488
8489         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8490         instead of lookup_symbol_in_language
8491         (do_exact_match): New function.
8492         (ada_get_symbol_name_matcher): Return do_exact_match when
8493         doing a verbatim match.
8494
8495 2019-02-15  Tom Tromey  <tromey@adacore.com>
8496
8497         * ravenscar-thread.c (ravenscar_thread_target::resume)
8498         (ravenscar_thread_target::wait): Special case wildcard requests.
8499
8500 2019-02-15  Tom Tromey  <tromey@adacore.com>
8501
8502         * ravenscar-thread.c (base_ptid): Remove.
8503         (struct ravenscar_thread_target) <close>: New method.
8504         <m_base_ptid>: New member.
8505         <update_inferior_ptid, active_task, task_is_currently_active,
8506         runtime_initialized>: Declare methods.
8507         <ravenscar_thread_target>: Add constructor.
8508         (ravenscar_thread_target::task_is_currently_active)
8509         (ravenscar_thread_target::update_inferior_ptid)
8510         (ravenscar_runtime_initialized): Rename.  Now methods.
8511         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8512         (ravenscar_thread_target::update_thread_list): Update.
8513         (ravenscar_thread_target::active_task): Now method.
8514         (ravenscar_thread_target::store_registers)
8515         (ravenscar_thread_target::prepare_to_store)
8516         (ravenscar_thread_target::prepare_to_store)
8517         (ravenscar_thread_target::mourn_inferior): Update.
8518         (ravenscar_inferior_created): Use "new" to create target.
8519         (ravenscar_thread_target::get_ada_task_ptid): Update.
8520         (_initialize_ravenscar): Don't initialize base_ptid.
8521         (ravenscar_ops): Remove global.
8522
8523 2019-02-15  Tom Tromey  <tromey@adacore.com>
8524
8525         * target.h (push_target): Declare new overload.
8526         * target.c (push_target): New overload, taking an rvalue reference.
8527         * remote.c (remote_target::open_1): Use push_target overload.
8528         * corelow.c (core_target_open): Use push_target overload.
8529
8530 2019-02-15  Tom Tromey  <tromey@adacore.com>
8531
8532         * ravenscar-thread.c (is_ravenscar_task)
8533         (ravenscar_task_is_currently_active): Return bool.
8534         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8535         (_initialize_ravenscar): Remove "(void)".
8536         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8537         Return bool.
8538
8539 2019-02-15  Tom Tromey  <tromey@adacore.com>
8540
8541         * ravenscar-thread.c (ravenscar_runtime_initializer)
8542         (has_ravenscar_runtime, get_running_thread_id)
8543         (ravenscar_thread_target::resume): Fix indentation.
8544
8545 2019-02-15  Tom Tromey  <tromey@adacore.com>
8546
8547         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8548         from ravenscar_arch_ops.
8549         (sparc_ravenscar_ops::fetch_registers)
8550         (sparc_ravenscar_ops::store_registers): Now methods.
8551         (sparc_ravenscar_prepare_to_store): Remove.
8552         (sparc_ravenscar_ops): Redefine.
8553         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8554         methods and destructor.  Remove members.
8555         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8556         (ravenscar_thread_target::store_registers)
8557         (ravenscar_thread_target::prepare_to_store): Update.
8558         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8559         Remove.
8560         (struct ppc_ravenscar_powerpc_ops): Derive from
8561         ravenscar_arch_ops.
8562         (ppc_ravenscar_powerpc_ops::fetch_registers)
8563         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8564         (ppc_ravenscar_powerpc_ops): Redefine.
8565         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8566         (ppc_ravenscar_e500_ops::fetch_registers)
8567         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8568         (ppc_ravenscar_e500_ops): Redefine.
8569         * aarch64-ravenscar-thread.c
8570         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8571         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8572         (aarch64_ravenscar_fetch_registers)
8573         (aarch64_ravenscar_store_registers): Now methods.
8574         (aarch64_ravenscar_ops): Redefine.
8575
8576 2019-02-15  Tom Tromey  <tromey@adacore.com>
8577
8578         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8579         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8580         (ravenscar_thread_target::stopped_by_watchpoint)
8581         (ravenscar_thread_target::stopped_data_address)
8582         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8583
8584 2019-02-15  Tom Tromey  <tromey@adacore.com>
8585
8586         * ravenscar-thread.c: Fix some typos.
8587
8588 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8589             Tom Tromey  <tromey@adacore.com>
8590
8591         * ada-lang.c (ada_exception_sal): Change addr_string to a
8592         std::string.
8593         (create_ada_exception_catchpoint): Update.
8594
8595 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8596             Tom Tromey  <tromey@adacore.com>
8597
8598         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8599         (bp_location_ops): Remove.
8600         (base_breakpoint_allocate_location): Update.
8601         (free_bp_location): Update.
8602         * ada-lang.c (class ada_catchpoint_location)
8603         <ada_catchpoint_location>: Remove ops parameter.
8604         (ada_catchpoint_location_dtor): Remove.
8605         (ada_catchpoint_location_ops): Remove.
8606         (allocate_location_exception): Update.
8607         * breakpoint.h (struct bp_location_ops): Remove.
8608         (class bp_location) <bp_location>: Remove bp_location_ops
8609         parameter.
8610         <~bp_location>: Add destructor.
8611         <ops>: Remove.
8612
8613 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8614             Pedro Alves  <palves@redhat.com>
8615
8616         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8617         'PATH_MAX'.
8618
8619 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8620             Samuel Thibault  <samuel.thibault@gnu.org>
8621             Thomas Schwinge  <thomas@codesourcery.com>
8622
8623         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8624         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8625
8626 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8627
8628         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8629         (check_empty): Use "const char *".
8630
8631         * gnu-nat.c (gnu_nat_target::detach): Instead of
8632         'detach_inferior (pid)' call
8633         'detach_inferior (find_inferior_pid (pid))'.
8634
8635         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8636         'nat/fork-inferior.o'.
8637         * gnu-nat.c: #include "nat/fork-inferior.h".
8638
8639         * gnu-nat.c (gnu_nat_target::detach): Instead of
8640         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8641         * gnu-nat.h: #include "inf-child.h".
8642         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8643         'i386_gnu_nat_target::fetch_registers'.
8644         (gnu_store_registers): Rename/move to
8645         'i386_gnu_nat_target::store_registers'.
8646
8647         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8648         * gnu-nat.h (mach_thread_info): New function.
8649         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8650
8651         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8652
8653 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8654
8655         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8656
8657 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8658
8659         * windows-nat.c (windows_add_thread): Add new parameter
8660         "main_thread_p" with default value set to false.  Update
8661         function documentation as well as all callers.
8662         (windows_delete_thread): Likewise.
8663         (fake_create_process): Update call to windows_add_thread.
8664         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8665         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8666         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8667         call to windows_delete_thread.
8668
8669 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8670
8671         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8672
8673 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8674
8675         * symfile.c (find_separate_debug_file): Use canonical path of
8676         sysroot with child_path instead of gdb_sysroot if it is valid.
8677
8678 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8679
8680         * symfile.c (find_separate_debug_file): Use child_path to
8681         determine if an object file is under a sysroot.
8682
8683 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8684
8685         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8686         unittests/child-path-selftests.c.
8687         * common/pathstuff.c (child_path): New function.
8688         * common/pathstuff.h (child_path): New prototype.
8689         * unittests/child-path-selftests.c: New file.
8690
8691 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8692
8693         * symfile.c (find_separate_debug_file): Look for separate debug
8694         files in debug directories under the sysroot.
8695
8696 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8697
8698         * symtab.h (struct minimal_symbol data_p): New const method.
8699         (struct minimal_symbol text_p): Likewise.
8700         * symtab.c (output_source_filename): Use file name style
8701         to print file name.
8702         (print_symbol_info): Likewise.
8703         (print_msymbol_info): Use address style to print addresses.
8704         Use function name style to print executable text symbols.
8705         (expand_symtab_containing_pc): Use data_p.
8706         (find_pc_sect_compunit_symtab): Likewise.
8707
8708 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8709
8710         * breakpoint.c (describe_other_breakpoints): Use address style
8711         to print addresses.
8712         (say_where): Likewise.
8713
8714 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8715
8716         * ada-typeprint.c (print_func_type): Print function name
8717         style to print function name.
8718         * c-typeprint.c (c_print_type_1): Likewise.
8719
8720 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8721
8722         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8723         for execve.
8724
8725 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8726
8727         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8728         type_stack.
8729
8730 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8731
8732         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8733         TYPE_CODE_REF types.
8734
8735 2019-02-08  Jim Wilson  <jimw@sifive.com>
8736
8737         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8738         (riscv_linux_fregset): New.
8739         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8740
8741 2019-02-07  Tom Tromey  <tom@tromey.com>
8742
8743         * thread.c (thread_cancel_execution_command): Update.
8744         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8745         methods.
8746         (struct thread_fsm_ops): Remove.
8747         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8748         (thread_fsm_should_stop, thread_fsm_return_value)
8749         (thread_fsm_set_finished, thread_fsm_finished_p)
8750         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8751         Don't declare.
8752         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8753         * infrun.c (clear_proceed_status_thread)
8754         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8755         (print_stop_event): Update.
8756         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8757         Add constructor.
8758         (step_command_fsm_ops): Remove.
8759         (new_step_command_fsm): Remove.
8760         (step_1): Update.
8761         (step_command_fsm::should_stop): Rename from
8762         step_command_fsm_should_stop.
8763         (step_command_fsm::clean_up): Rename from
8764         step_command_fsm_clean_up.
8765         (step_command_fsm::do_async_reply_reason): Rename from
8766         step_command_fsm_async_reply_reason.
8767         (struct until_next_fsm): Inherit from thread_fsm.  Add
8768         constructor.
8769         (until_next_fsm_ops): Remove.
8770         (new_until_next_fsm): Remove.
8771         (until_next_fsm::should_stop): Rename from
8772         until_next_fsm_should_stop.
8773         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8774         (until_next_fsm::do_async_reply_reason): Rename from
8775         until_next_fsm_async_reply_reason.
8776         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8777         constructor.  Change type of breakpoint.
8778         (finish_command_fsm_ops): Remove.
8779         (new_finish_command_fsm): Remove.
8780         (finish_command_fsm::should_stop): Rename from
8781         finish_command_fsm_should_stop.
8782         (finish_command_fsm::clean_up): Rename from
8783         finish_command_fsm_clean_up.
8784         (finish_command_fsm::return_value): Rename from
8785         finish_command_fsm_return_value.
8786         (finish_command_fsm::do_async_reply_reason): Rename from
8787         finish_command_fsm_async_reply_reason.
8788         (finish_command): Update.
8789         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8790         Add constructor.
8791         (call_thread_fsm_ops): Remove.
8792         (call_thread_fsm::call_thread_fsm): Rename from
8793         new_call_thread_fsm.
8794         (call_thread_fsm::should_stop): Rename from
8795         call_thread_fsm_should_stop.
8796         (call_thread_fsm::should_notify_stop): Rename from
8797         call_thread_fsm_should_notify_stop.
8798         (run_inferior_call, call_function_by_hand_dummy): Update.
8799         * cli/cli-interp.c (should_print_stop_to_console): Update.
8800         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8801         Add constructor.  Change type of location_breakpoint,
8802         caller_breakpoint.
8803         (until_break_fsm_ops): Remove.
8804         (new_until_break_fsm): Remove.
8805         (until_break_fsm::should_stop): Rename from
8806         until_break_fsm_should_stop.
8807         (until_break_fsm::clean_up): Rename from
8808         until_break_fsm_clean_up.
8809         (until_break_fsm::do_async_reply_reason): Rename from
8810         until_break_fsm_async_reply_reason.
8811         (until_break_command): Update.
8812         * thread-fsm.c: Remove.
8813         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8814
8815 2019-02-07  Tom Tromey  <tom@tromey.com>
8816
8817         * yy-remap.h: Add include guard.
8818         * xtensa-tdep.h: Add include guard.
8819         * xcoffread.h: Rename include guard.
8820         * varobj-iter.h: Add include guard.
8821         * tui/tui.h: Rename include guard.
8822         * tui/tui-winsource.h: Rename include guard.
8823         * tui/tui-wingeneral.h: Rename include guard.
8824         * tui/tui-windata.h: Rename include guard.
8825         * tui/tui-win.h: Rename include guard.
8826         * tui/tui-stack.h: Rename include guard.
8827         * tui/tui-source.h: Rename include guard.
8828         * tui/tui-regs.h: Rename include guard.
8829         * tui/tui-out.h: Rename include guard.
8830         * tui/tui-layout.h: Rename include guard.
8831         * tui/tui-io.h: Rename include guard.
8832         * tui/tui-hooks.h: Rename include guard.
8833         * tui/tui-file.h: Rename include guard.
8834         * tui/tui-disasm.h: Rename include guard.
8835         * tui/tui-data.h: Rename include guard.
8836         * tui/tui-command.h: Rename include guard.
8837         * tic6x-tdep.h: Add include guard.
8838         * target/waitstatus.h: Rename include guard.
8839         * target/wait.h: Rename include guard.
8840         * target/target.h: Rename include guard.
8841         * target/resume.h: Rename include guard.
8842         * target-float.h: Rename include guard.
8843         * stabsread.h: Add include guard.
8844         * rs6000-tdep.h: Add include guard.
8845         * riscv-fbsd-tdep.h: Add include guard.
8846         * regformats/regdef.h: Rename include guard.
8847         * record.h: Rename include guard.
8848         * python/python.h: Rename include guard.
8849         * python/python-internal.h: Rename include guard.
8850         * python/py-stopevent.h: Rename include guard.
8851         * python/py-ref.h: Rename include guard.
8852         * python/py-record.h: Rename include guard.
8853         * python/py-record-full.h: Rename include guard.
8854         * python/py-record-btrace.h: Rename include guard.
8855         * python/py-instruction.h: Rename include guard.
8856         * python/py-events.h: Rename include guard.
8857         * python/py-event.h: Rename include guard.
8858         * procfs.h: Add include guard.
8859         * proc-utils.h: Add include guard.
8860         * p-lang.h: Add include guard.
8861         * or1k-tdep.h: Rename include guard.
8862         * observable.h: Rename include guard.
8863         * nto-tdep.h: Rename include guard.
8864         * nat/x86-linux.h: Rename include guard.
8865         * nat/x86-linux-dregs.h: Rename include guard.
8866         * nat/x86-gcc-cpuid.h: Add include guard.
8867         * nat/x86-dregs.h: Rename include guard.
8868         * nat/x86-cpuid.h: Rename include guard.
8869         * nat/ppc-linux.h: Rename include guard.
8870         * nat/mips-linux-watch.h: Rename include guard.
8871         * nat/linux-waitpid.h: Rename include guard.
8872         * nat/linux-ptrace.h: Rename include guard.
8873         * nat/linux-procfs.h: Rename include guard.
8874         * nat/linux-osdata.h: Rename include guard.
8875         * nat/linux-nat.h: Rename include guard.
8876         * nat/linux-namespaces.h: Rename include guard.
8877         * nat/linux-btrace.h: Rename include guard.
8878         * nat/glibc_thread_db.h: Rename include guard.
8879         * nat/gdb_thread_db.h: Rename include guard.
8880         * nat/gdb_ptrace.h: Rename include guard.
8881         * nat/fork-inferior.h: Rename include guard.
8882         * nat/amd64-linux-siginfo.h: Rename include guard.
8883         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8884         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8885         * nat/aarch64-linux.h: Rename include guard.
8886         * nat/aarch64-linux-hw-point.h: Rename include guard.
8887         * mn10300-tdep.h: Add include guard.
8888         * mips-linux-tdep.h: Add include guard.
8889         * mi/mi-parse.h: Rename include guard.
8890         * mi/mi-out.h: Rename include guard.
8891         * mi/mi-main.h: Rename include guard.
8892         * mi/mi-interp.h: Rename include guard.
8893         * mi/mi-getopt.h: Rename include guard.
8894         * mi/mi-console.h: Rename include guard.
8895         * mi/mi-common.h: Rename include guard.
8896         * mi/mi-cmds.h: Rename include guard.
8897         * mi/mi-cmd-break.h: Rename include guard.
8898         * m2-lang.h: Add include guard.
8899         * location.h: Rename include guard.
8900         * linux-record.h: Rename include guard.
8901         * linux-nat.h: Add include guard.
8902         * linux-fork.h: Add include guard.
8903         * i386-darwin-tdep.h: Rename include guard.
8904         * hppa-linux-offsets.h: Add include guard.
8905         * guile/guile.h: Rename include guard.
8906         * guile/guile-internal.h: Rename include guard.
8907         * gnu-nat.h: Rename include guard.
8908         * gdb-stabs.h: Rename include guard.
8909         * frv-tdep.h: Add include guard.
8910         * f-lang.h: Add include guard.
8911         * event-loop.h: Add include guard.
8912         * darwin-nat.h: Rename include guard.
8913         * cp-abi.h: Rename include guard.
8914         * config/sparc/nm-sol2.h: Rename include guard.
8915         * config/nm-nto.h: Rename include guard.
8916         * config/nm-linux.h: Add include guard.
8917         * config/i386/nm-i386gnu.h: Rename include guard.
8918         * config/djgpp/nl_types.h: Rename include guard.
8919         * config/djgpp/langinfo.h: Rename include guard.
8920         * compile/gcc-cp-plugin.h: Add include guard.
8921         * compile/gcc-c-plugin.h: Add include guard.
8922         * compile/compile.h: Rename include guard.
8923         * compile/compile-object-run.h: Rename include guard.
8924         * compile/compile-object-load.h: Rename include guard.
8925         * compile/compile-internal.h: Rename include guard.
8926         * compile/compile-cplus.h: Rename include guard.
8927         * compile/compile-c.h: Rename include guard.
8928         * common/xml-utils.h: Rename include guard.
8929         * common/x86-xstate.h: Rename include guard.
8930         * common/version.h: Rename include guard.
8931         * common/vec.h: Rename include guard.
8932         * common/tdesc.h: Rename include guard.
8933         * common/selftest.h: Rename include guard.
8934         * common/scoped_restore.h: Rename include guard.
8935         * common/scoped_mmap.h: Rename include guard.
8936         * common/scoped_fd.h: Rename include guard.
8937         * common/safe-iterator.h: Rename include guard.
8938         * common/run-time-clock.h: Rename include guard.
8939         * common/refcounted-object.h: Rename include guard.
8940         * common/queue.h: Rename include guard.
8941         * common/ptid.h: Rename include guard.
8942         * common/print-utils.h: Rename include guard.
8943         * common/preprocessor.h: Rename include guard.
8944         * common/pathstuff.h: Rename include guard.
8945         * common/observable.h: Rename include guard.
8946         * common/netstuff.h: Rename include guard.
8947         * common/job-control.h: Rename include guard.
8948         * common/host-defs.h: Rename include guard.
8949         * common/gdb_wait.h: Rename include guard.
8950         * common/gdb_vecs.h: Rename include guard.
8951         * common/gdb_unlinker.h: Rename include guard.
8952         * common/gdb_unique_ptr.h: Rename include guard.
8953         * common/gdb_tilde_expand.h: Rename include guard.
8954         * common/gdb_sys_time.h: Rename include guard.
8955         * common/gdb_string_view.h: Rename include guard.
8956         * common/gdb_splay_tree.h: Rename include guard.
8957         * common/gdb_setjmp.h: Rename include guard.
8958         * common/gdb_ref_ptr.h: Rename include guard.
8959         * common/gdb_optional.h: Rename include guard.
8960         * common/gdb_locale.h: Rename include guard.
8961         * common/gdb_assert.h: Rename include guard.
8962         * common/filtered-iterator.h: Rename include guard.
8963         * common/filestuff.h: Rename include guard.
8964         * common/fileio.h: Rename include guard.
8965         * common/environ.h: Rename include guard.
8966         * common/common-utils.h: Rename include guard.
8967         * common/common-types.h: Rename include guard.
8968         * common/common-regcache.h: Rename include guard.
8969         * common/common-inferior.h: Rename include guard.
8970         * common/common-gdbthread.h: Rename include guard.
8971         * common/common-exceptions.h: Rename include guard.
8972         * common/common-defs.h: Rename include guard.
8973         * common/common-debug.h: Rename include guard.
8974         * common/cleanups.h: Rename include guard.
8975         * common/buffer.h: Rename include guard.
8976         * common/btrace-common.h: Rename include guard.
8977         * common/break-common.h: Rename include guard.
8978         * cli/cli-utils.h: Rename include guard.
8979         * cli/cli-style.h: Rename include guard.
8980         * cli/cli-setshow.h: Rename include guard.
8981         * cli/cli-script.h: Rename include guard.
8982         * cli/cli-interp.h: Rename include guard.
8983         * cli/cli-decode.h: Rename include guard.
8984         * cli/cli-cmds.h: Rename include guard.
8985         * charset-list.h: Add include guard.
8986         * buildsym-legacy.h: Rename include guard.
8987         * bfin-tdep.h: Add include guard.
8988         * ax.h: Rename include guard.
8989         * arm-linux-tdep.h: Add include guard.
8990         * arm-fbsd-tdep.h: Add include guard.
8991         * arch/xtensa.h: Rename include guard.
8992         * arch/tic6x.h: Add include guard.
8993         * arch/i386.h: Add include guard.
8994         * arch/arm.h: Rename include guard.
8995         * arch/arm-linux.h: Rename include guard.
8996         * arch/arm-get-next-pcs.h: Rename include guard.
8997         * arch/amd64.h: Add include guard.
8998         * arch/aarch64-insn.h: Rename include guard.
8999         * arch-utils.h: Rename include guard.
9000         * annotate.h: Add include guard.
9001         * amd64-darwin-tdep.h: Rename include guard.
9002         * aarch64-linux-tdep.h: Add include guard.
9003         * aarch64-fbsd-tdep.h: Add include guard.
9004         * aarch32-linux-nat.h: Add include guard.
9005
9006 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9007
9008         * macrotab.c (macro_define_internal): New function that
9009         factorizes macro_define_object_internal and macro_define_function
9010         code.
9011         (macro_define_object_internal): Use macro_define_internal.
9012         (macro_define_function): Likewise.
9013
9014 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9015
9016         * macrocmd.c (extract_identifier): Return
9017         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9018         callers.
9019
9020 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9021
9022         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9023
9024 2019-02-05  Tom Tromey  <tom@tromey.com>
9025
9026         * target.c (target_stack::unpush): Move assertion earlier.
9027
9028 2019-01-30  Tom Tromey  <tom@tromey.com>
9029
9030         PR python/23615:
9031         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9032         (gdbpy_parse_and_eval): Likewise.
9033         * python/python-internal.h (gdbpy_allow_threads): New class.
9034
9035 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9036
9037         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9038         (aarch64_fbsd_fpregmap): Move earlier.
9039         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9040         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9041         instead of individual calls to trad_frame_set_reg_addr.
9042         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9043         earlier.
9044         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9045         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9046         instead of individual calls to trad_frame_set_reg_addr.
9047
9048 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9049
9050         * CONTRIBUTE: Replace contribution list with wiki link.
9051
9052 2019-01-25  Tom Tromey  <tom@tromey.com>
9053
9054         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9055
9056 2019-01-25  Tom Tromey  <tom@tromey.com>
9057
9058         * xtensa-linux-nat.c: Fix common/ includes.
9059         * xml-support.h: Fix common/ includes.
9060         * xml-support.c: Fix common/ includes.
9061         * x86-linux-nat.c: Fix common/ includes.
9062         * windows-nat.c: Fix common/ includes.
9063         * varobj.h: Fix common/ includes.
9064         * varobj.c: Fix common/ includes.
9065         * value.c: Fix common/ includes.
9066         * valops.c: Fix common/ includes.
9067         * utils.c: Fix common/ includes.
9068         * unittests/xml-utils-selftests.c: Fix common/ includes.
9069         * unittests/utils-selftests.c: Fix common/ includes.
9070         * unittests/unpack-selftests.c: Fix common/ includes.
9071         * unittests/tracepoint-selftests.c: Fix common/ includes.
9072         * unittests/style-selftests.c: Fix common/ includes.
9073         * unittests/string_view-selftests.c: Fix common/ includes.
9074         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9075         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9076         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9077         * unittests/rsp-low-selftests.c: Fix common/ includes.
9078         * unittests/parse-connection-spec-selftests.c: Fix common/
9079         includes.
9080         * unittests/optional-selftests.c: Fix common/ includes.
9081         * unittests/offset-type-selftests.c: Fix common/ includes.
9082         * unittests/observable-selftests.c: Fix common/ includes.
9083         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9084         * unittests/memrange-selftests.c: Fix common/ includes.
9085         * unittests/memory-map-selftests.c: Fix common/ includes.
9086         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9087         * unittests/function-view-selftests.c: Fix common/ includes.
9088         * unittests/environ-selftests.c: Fix common/ includes.
9089         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9090         * unittests/common-utils-selftests.c: Fix common/ includes.
9091         * unittests/cli-utils-selftests.c: Fix common/ includes.
9092         * unittests/array-view-selftests.c: Fix common/ includes.
9093         * ui-file.c: Fix common/ includes.
9094         * tui/tui-io.c: Fix common/ includes.
9095         * tracepoint.h: Fix common/ includes.
9096         * tracepoint.c: Fix common/ includes.
9097         * tracefile-tfile.c: Fix common/ includes.
9098         * top.h: Fix common/ includes.
9099         * top.c: Fix common/ includes.
9100         * thread.c: Fix common/ includes.
9101         * target/waitstatus.h: Fix common/ includes.
9102         * target/waitstatus.c: Fix common/ includes.
9103         * target.h: Fix common/ includes.
9104         * target.c: Fix common/ includes.
9105         * target-memory.c: Fix common/ includes.
9106         * target-descriptions.c: Fix common/ includes.
9107         * symtab.h: Fix common/ includes.
9108         * symfile.c: Fix common/ includes.
9109         * stap-probe.c: Fix common/ includes.
9110         * spu-linux-nat.c: Fix common/ includes.
9111         * sparc-nat.c: Fix common/ includes.
9112         * source.c: Fix common/ includes.
9113         * solib.c: Fix common/ includes.
9114         * solib-target.c: Fix common/ includes.
9115         * ser-unix.c: Fix common/ includes.
9116         * ser-tcp.c: Fix common/ includes.
9117         * ser-pipe.c: Fix common/ includes.
9118         * ser-base.c: Fix common/ includes.
9119         * selftest-arch.c: Fix common/ includes.
9120         * s12z-tdep.c: Fix common/ includes.
9121         * rust-exp.y: Fix common/ includes.
9122         * rs6000-aix-tdep.c: Fix common/ includes.
9123         * riscv-tdep.c: Fix common/ includes.
9124         * remote.c: Fix common/ includes.
9125         * remote-notif.h: Fix common/ includes.
9126         * remote-fileio.h: Fix common/ includes.
9127         * remote-fileio.c: Fix common/ includes.
9128         * regcache.h: Fix common/ includes.
9129         * regcache.c: Fix common/ includes.
9130         * record-btrace.c: Fix common/ includes.
9131         * python/python.c: Fix common/ includes.
9132         * python/py-type.c: Fix common/ includes.
9133         * python/py-inferior.c: Fix common/ includes.
9134         * progspace.h: Fix common/ includes.
9135         * producer.c: Fix common/ includes.
9136         * procfs.c: Fix common/ includes.
9137         * proc-api.c: Fix common/ includes.
9138         * printcmd.c: Fix common/ includes.
9139         * ppc-linux-nat.c: Fix common/ includes.
9140         * parser-defs.h: Fix common/ includes.
9141         * osdata.c: Fix common/ includes.
9142         * obsd-nat.c: Fix common/ includes.
9143         * nat/x86-linux.c: Fix common/ includes.
9144         * nat/x86-linux-dregs.c: Fix common/ includes.
9145         * nat/x86-dregs.h: Fix common/ includes.
9146         * nat/x86-dregs.c: Fix common/ includes.
9147         * nat/ppc-linux.c: Fix common/ includes.
9148         * nat/mips-linux-watch.h: Fix common/ includes.
9149         * nat/mips-linux-watch.c: Fix common/ includes.
9150         * nat/linux-waitpid.c: Fix common/ includes.
9151         * nat/linux-ptrace.h: Fix common/ includes.
9152         * nat/linux-ptrace.c: Fix common/ includes.
9153         * nat/linux-procfs.c: Fix common/ includes.
9154         * nat/linux-personality.c: Fix common/ includes.
9155         * nat/linux-osdata.c: Fix common/ includes.
9156         * nat/linux-namespaces.c: Fix common/ includes.
9157         * nat/linux-btrace.h: Fix common/ includes.
9158         * nat/linux-btrace.c: Fix common/ includes.
9159         * nat/fork-inferior.c: Fix common/ includes.
9160         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9161         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9162         * nat/aarch64-linux.c: Fix common/ includes.
9163         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9164         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9165         * namespace.h: Fix common/ includes.
9166         * mips-linux-tdep.c: Fix common/ includes.
9167         * minsyms.c: Fix common/ includes.
9168         * mi/mi-parse.h: Fix common/ includes.
9169         * mi/mi-main.c: Fix common/ includes.
9170         * mi/mi-cmd-env.c: Fix common/ includes.
9171         * memrange.h: Fix common/ includes.
9172         * memattr.c: Fix common/ includes.
9173         * maint.h: Fix common/ includes.
9174         * maint.c: Fix common/ includes.
9175         * main.c: Fix common/ includes.
9176         * machoread.c: Fix common/ includes.
9177         * location.c: Fix common/ includes.
9178         * linux-thread-db.c: Fix common/ includes.
9179         * linux-nat.c: Fix common/ includes.
9180         * linux-fork.c: Fix common/ includes.
9181         * inline-frame.c: Fix common/ includes.
9182         * infrun.c: Fix common/ includes.
9183         * inflow.c: Fix common/ includes.
9184         * inferior.h: Fix common/ includes.
9185         * inferior.c: Fix common/ includes.
9186         * infcmd.c: Fix common/ includes.
9187         * inf-ptrace.c: Fix common/ includes.
9188         * inf-child.c: Fix common/ includes.
9189         * ia64-linux-nat.c: Fix common/ includes.
9190         * i387-tdep.c: Fix common/ includes.
9191         * i386-tdep.c: Fix common/ includes.
9192         * i386-linux-tdep.c: Fix common/ includes.
9193         * i386-linux-nat.c: Fix common/ includes.
9194         * i386-go32-tdep.c: Fix common/ includes.
9195         * i386-fbsd-tdep.c: Fix common/ includes.
9196         * i386-fbsd-nat.c: Fix common/ includes.
9197         * guile/scm-type.c: Fix common/ includes.
9198         * guile/guile.c: Fix common/ includes.
9199         * go32-nat.c: Fix common/ includes.
9200         * gnu-nat.c: Fix common/ includes.
9201         * gdbthread.h: Fix common/ includes.
9202         * gdbarch-selftests.c: Fix common/ includes.
9203         * gdb_usleep.c: Fix common/ includes.
9204         * gdb_select.h: Fix common/ includes.
9205         * gdb_bfd.c: Fix common/ includes.
9206         * gcore.c: Fix common/ includes.
9207         * fork-child.c: Fix common/ includes.
9208         * findvar.c: Fix common/ includes.
9209         * fbsd-nat.c: Fix common/ includes.
9210         * event-top.c: Fix common/ includes.
9211         * event-loop.c: Fix common/ includes.
9212         * dwarf2read.c: Fix common/ includes.
9213         * dwarf2loc.c: Fix common/ includes.
9214         * dwarf2-frame.c: Fix common/ includes.
9215         * dwarf-index-cache.c: Fix common/ includes.
9216         * dtrace-probe.c: Fix common/ includes.
9217         * disasm-selftests.c: Fix common/ includes.
9218         * defs.h: Fix common/ includes.
9219         * csky-tdep.c: Fix common/ includes.
9220         * cp-valprint.c: Fix common/ includes.
9221         * cp-support.h: Fix common/ includes.
9222         * cp-support.c: Fix common/ includes.
9223         * corelow.c: Fix common/ includes.
9224         * completer.h: Fix common/ includes.
9225         * completer.c: Fix common/ includes.
9226         * compile/compile.c: Fix common/ includes.
9227         * compile/compile-loc2c.c: Fix common/ includes.
9228         * compile/compile-cplus-types.c: Fix common/ includes.
9229         * compile/compile-cplus-symbols.c: Fix common/ includes.
9230         * command.h: Fix common/ includes.
9231         * cli/cli-dump.c: Fix common/ includes.
9232         * cli/cli-cmds.c: Fix common/ includes.
9233         * charset.c: Fix common/ includes.
9234         * build-id.c: Fix common/ includes.
9235         * btrace.h: Fix common/ includes.
9236         * btrace.c: Fix common/ includes.
9237         * breakpoint.h: Fix common/ includes.
9238         * breakpoint.c: Fix common/ includes.
9239         * ax.h:
9240         (enum agent_op): Fix common/ includes.
9241         * ax-general.c (struct aop_map): Fix common/ includes.
9242         * ax-gdb.c: Fix common/ includes.
9243         * auxv.c: Fix common/ includes.
9244         * auto-load.c: Fix common/ includes.
9245         * arm-tdep.c: Fix common/ includes.
9246         * arch/riscv.c: Fix common/ includes.
9247         * arch/ppc-linux-common.c: Fix common/ includes.
9248         * arch/i386.c: Fix common/ includes.
9249         * arch/arm.c: Fix common/ includes.
9250         * arch/arm-linux.c: Fix common/ includes.
9251         * arch/arm-get-next-pcs.c: Fix common/ includes.
9252         * arch/amd64.c: Fix common/ includes.
9253         * arch/aarch64.c: Fix common/ includes.
9254         * arch/aarch64-insn.c: Fix common/ includes.
9255         * arch-utils.c: Fix common/ includes.
9256         * amd64-windows-tdep.c: Fix common/ includes.
9257         * amd64-tdep.c: Fix common/ includes.
9258         * amd64-sol2-tdep.c: Fix common/ includes.
9259         * amd64-obsd-tdep.c: Fix common/ includes.
9260         * amd64-nbsd-tdep.c: Fix common/ includes.
9261         * amd64-linux-tdep.c: Fix common/ includes.
9262         * amd64-linux-nat.c: Fix common/ includes.
9263         * amd64-fbsd-tdep.c: Fix common/ includes.
9264         * amd64-fbsd-nat.c: Fix common/ includes.
9265         * amd64-dicos-tdep.c: Fix common/ includes.
9266         * amd64-darwin-tdep.c: Fix common/ includes.
9267         * agent.c: Fix common/ includes.
9268         * ada-lang.h: Fix common/ includes.
9269         * ada-lang.c: Fix common/ includes.
9270         * aarch64-tdep.c: Fix common/ includes.
9271
9272 2019-01-25  Tom Tromey  <tom@tromey.com>
9273
9274         * common/create-version.sh: Use common/version.h.
9275
9276 2019-01-24  Pedro Alves  <palves@redhat.com>
9277
9278         * infrun.c (signal_stop, signal_print, signal_program)
9279         (signal_catch, signal_pass): Now arrays instead of pointers.
9280         (update_signals_program_target, do_target_resume)
9281         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9282         * linux-nat.c (linux_nat_target::pass_signals)
9283         (linux_nat_target::create_inferior, linux_nat_target::attach):
9284         Adjust.
9285         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9286         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9287         * procfs.c (procfs_target::pass_signals): Adjust.
9288         * record-full.c (record_full_target::resume): Adjust.
9289         * remote.c (remote_target::pass_signals)
9290         (remote_target::program_signals): Adjust.
9291         * target-debug.h (target_debug_print_signals): Now takes a
9292         gdb::array_view as parameter.  Adjust.
9293         * target.h (target_ops) <pass_signals, program_signals>: Replace
9294         pointer and length parameters with gdb::array_view.
9295         (target_pass_signals, target_program_signals): Likewise.
9296         * target-delegates.c: Regenerate.
9297
9298 2019-01-24  Pedro Alves  <palves@redhat.com>
9299
9300         * common/forward-scope-exit.h
9301         (forward_scope_exit::forward_scope_exit): Pass arguments to
9302         m_bind_function directly, instead of creating a std::bind and
9303         copying that.
9304
9305 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9306
9307         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9308         for static members.
9309         (pass_in_v_vfp_candidate): Likewise.
9310
9311 2019-01-23  Tom Tromey  <tom@tromey.com>
9312             Pedro Alves  <palves@redhat.com>
9313
9314         * regcache.c (class regcache_invalidator): Remove.
9315         (regcache::raw_write): Use make_scope_exit.
9316
9317 2019-01-23  Tom Tromey  <tom@tromey.com>
9318
9319         * ui-out.h (class ui_out_emit_type): Update comment.
9320
9321 2019-01-23  Tom Tromey  <tom@tromey.com>
9322
9323         * infrun.c (fetch_inferior_event): Update comment.
9324
9325 2019-01-23  Tom Tromey  <tom@tromey.com>
9326             Pedro Alves  <palves@redhat.com>
9327
9328         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9329         parameter.
9330         (fetch_inferior_event): Use SCOPE_EXIT.
9331
9332
9333 2019-01-23  Tom Tromey  <tom@tromey.com>
9334             Pedro Alves  <palves@redhat.com>
9335
9336         * infrun.c (disable_thread_events): Delete.
9337         (stop_all_threads): Use SCOPE_EXIT.
9338
9339 2019-01-23  Tom Tromey  <tom@tromey.com>
9340             Pedro Alves  <palves@redhat.com>
9341
9342         * symfile.c: Include forward-scope-exit.h.
9343         (clear_symtab_users_cleanup): Replace forward declaration with
9344         a FORWARD_SCOPE_EXIT.
9345         (syms_from_objfile_1): Use the forward_scope_exit and
9346         gdb::optional instead of cleanup_function.
9347         (reread_symbols): Use the forward_scope_exit instead of
9348         cleanup_function.
9349         (clear_symtab_users_cleanup): Remove function.
9350
9351 2019-01-23  Tom Tromey  <tom@tromey.com>
9352             Pedro Alves  <palves@redhat.com>
9353
9354         * linux-nat.c: Include scope-exit.h.
9355         (cleanup_target_stop): Remove.
9356         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9357         SCOPE_EXIT.
9358
9359 2019-01-23  Tom Tromey  <tom@tromey.com>
9360             Pedro Alves  <palves@redhat.com>
9361
9362         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9363         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9364
9365 2019-01-23  Tom Tromey  <tom@tromey.com>
9366             Andrew Burgess  <andrew.burgess@embecosm.com>
9367             Pedro Alves  <palves@redhat.com>
9368
9369         * infrun.c (fetch_inferior_event): Use scope_exit.
9370         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9371         * top.c (execute_command): Use scope_exit.
9372         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9373         * utils.c (do_bpstat_clear_actions_cleanup)
9374         (make_bpstat_clear_actions_cleanup): Remove.
9375
9376 2019-01-23  Tom Tromey  <tom@tromey.com>
9377             Pedro Alves  <palves@redhat.com>
9378
9379         * infrun.c: Include "common/scope-exit.h"
9380         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9381         (wait_for_inferior): Use SCOPE_EXIT.
9382         (fetch_inferior_event): Use scope_exit.
9383
9384 2019-01-23  Tom Tromey  <tom@tromey.com>
9385             Pedro Alves  <palves@redhat.com>
9386
9387         * breakpoint.c (create_breakpoint): Remove cleanup.
9388
9389 2019-01-23  Tom Tromey  <tom@tromey.com>
9390             Andrew Burgess  <andrew.burgess@embecosm.com>
9391             Pedro Alves  <palves@redhat.com>
9392
9393 2019-01-23  Pedro Alves  <palves@redhat.com>
9394
9395         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9396
9397 2019-01-23  Pedro Alves  <palves@redhat.com>
9398             Andrew Burgess  <andrew.burgess@embecosm.com>
9399
9400         * gdbthread.h: Include "common/forward-scope-exit.h".
9401         (scoped_finish_thread_state): Redefine custom class in terms of
9402         forward_scope_exit.
9403
9404 2019-01-23  Pedro Alves  <palves@redhat.com>
9405             Andrew Burgess  <andrew.burgess@embecosm.com>
9406
9407         * common/forward-scope-exit.h: New file.
9408
9409 2019-01-23  Pedro Alves  <palves@redhat.com>
9410             Andrew Burgess  <andrew.burgess@embecosm.com>
9411             Tom Tromey  <tom@tromey.com>
9412
9413         * common/scope-exit.h: New file.
9414
9415 2019-01-23  Pedro Alves  <palves@redhat.com>
9416
9417         * common/preprocessor.h (ESC): Rename to ...
9418         (ESC_PARENS): ... this.
9419         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9420         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9421
9422 2019-01-23  Tom Tromey  <tom@tromey.com>
9423
9424         * language.h (class scoped_switch_to_sym_language_if_auto):
9425         Initialize m_lang in both cases.
9426
9427 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9428
9429         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9430         with XCNEW.
9431
9432 2019-01-22  Tom Tromey  <tom@tromey.com>
9433
9434         * corelow.c: Do not include sys/file.h.
9435
9436 2019-01-22  Tom Tromey  <tom@tromey.com>
9437
9438         * tui/tui-wingeneral.h: Include gdb_curses.h.
9439
9440 2019-01-22  Tom Tromey  <tom@tromey.com>
9441
9442         * source-cache.h (class source_cache) <get_source_lines,
9443         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9444
9445 2019-01-22  Tom Tromey  <tom@tromey.com>
9446
9447         * remote-fileio.h (struct remote_target): Declare.
9448
9449 2019-01-22  Tom Tromey  <tom@tromey.com>
9450
9451         * python/py-arch.c: Do not include py-ref.h.
9452         * python/py-bpevent.c: Do not include py-ref.h.
9453         * python/py-cmd.c: Do not include py-ref.h.
9454         * python/py-continueevent.c: Do not include py-ref.h.
9455         * python/py-event.h: Do not include py-ref.h.
9456         * python/py-evtregistry.c: Do not include py-ref.h.
9457         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9458         * python/py-frame.c: Do not include py-ref.h.
9459         * python/py-framefilter.c: Do not include py-ref.h.
9460         * python/py-function.c: Do not include py-ref.h.
9461         * python/py-infevents.c: Do not include py-ref.h.
9462         * python/py-linetable.c: Do not include py-ref.h.
9463         * python/py-objfile.c: Do not include py-ref.h.
9464         * python/py-param.c: Do not include py-ref.h.
9465         * python/py-prettyprint.c: Do not include py-ref.h.
9466         * python/py-progspace.c: Do not include py-ref.h.
9467         * python/py-symbol.c: Do not include py-ref.h.
9468         * python/py-symtab.c: Do not include py-ref.h.
9469         * python/py-type.c: Do not include py-ref.h.
9470         * python/py-unwind.c: Do not include py-ref.h.
9471         * python/py-utils.c: Do not include py-ref.h.
9472         * python/py-value.c: Do not include py-ref.h.
9473         * python/py-varobj.c: Do not include py-ref.h.
9474         * python/py-xmethods.c: Do not include py-ref.h.
9475         * python/python.c: Do not include py-ref.h.
9476         * varobj.c: Do not include py-ref.h.
9477
9478 2019-01-22  Tom Tromey  <tom@tromey.com>
9479
9480         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9481         keyword for bcache.
9482
9483 2019-01-22  Tom Tromey  <tom@tromey.com>
9484
9485         * compile/compile-cplus-types.c: Remove a comment by #include.
9486
9487 2019-01-22  Tom Tromey  <tom@tromey.com>
9488
9489         * compile/gcc-c-plugin.h: Include compile-internal.h.
9490
9491 2019-01-22  Tom Tromey  <tom@tromey.com>
9492
9493         * stabsread.c (EXTERN): Do not define.
9494         (symnum, next_symbol_text_func, processing_gcc_compilation)
9495         (within_function, global_sym_chain, global_stabs)
9496         (previous_stab_code, this_object_header_files)
9497         (n_this_object_header_files)
9498         (n_allocated_this_object_header_files): Define.
9499         * stabsread.h (EXTERN): Never define.  Use "extern".
9500
9501 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9502
9503         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9504         history_value.
9505
9506 2019-01-21  Tom Tromey  <tom@tromey.com>
9507
9508         * ui-out.c: Fix includes.
9509         * tui/tui-source.c: Fix includes.
9510         * target.c: Fix includes.
9511         * remote.c: Fix includes.
9512         * regcache.c: Fix includes.
9513         * python/py-block.c: Fix includes.
9514         * printcmd.c: Fix includes.
9515         * or1k-tdep.c: Fix includes.
9516         * mi/mi-main.c: Fix includes.
9517         * m32r-tdep.c: Fix includes.
9518         * csky-tdep.c: Fix includes.
9519         * compile/compile-cplus-types.c: Fix includes.
9520         * cli/cli-interp.c: Fix includes.
9521
9522 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9523
9524         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9525         for padding.
9526
9527 2019-01-16  Tom Tromey  <tom@tromey.com>
9528
9529         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9530         earlier.
9531         (struct objfile) <msymbols_range>: Move from top level.
9532         <msymbols>: New method.
9533         (class objfile_msymbols): Remove.
9534         * symtab.c (default_collect_symbol_completion_matches_break_on):
9535         Update.
9536         * symmisc.c (dump_msymbols): Update.
9537         * stabsread.c (scan_file_globals): Update.
9538         * objc-lang.c (info_selectors_command, info_classes_command)
9539         (find_methods): Update.
9540         * minsyms.c (find_solib_trampoline_target): Update.
9541         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9542         * coffread.c (coff_symfile_read): Update.
9543         * ada-lang.c (ada_lookup_simple_minsym)
9544         (ada_collect_symbol_completion_matches): Update.
9545
9546 2019-01-16  Tom Tromey  <tom@tromey.com>
9547
9548         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9549         type.  Remove no-argument constructor.
9550         <iterator::operator++>: Simplify.
9551         <begin>: Update.
9552         <end>: Use minimal_symbol_count.
9553
9554 2019-01-16  Tom Tromey  <tom@tromey.com>
9555
9556         * objfiles.h (struct objfile) <psymtabs>: New method.
9557         (class objfile_psymtabs): Remove.
9558         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9559         typedef.
9560         <range>: New method.
9561         (require_partial_symbols): Change return type.
9562         * psymtab.c (require_partial_symbols)
9563         (psym_expand_symtabs_matching): Update.
9564         * mdebugread.c (parse_partial_symbols): Update.
9565         * dbxread.c (dbx_end_psymtab): Update.
9566
9567 2019-01-15  Tom Tromey  <tom@tromey.com>
9568
9569         * symtab.c (lookup_objfile_from_block)
9570         (lookup_symbol_in_objfile_symtabs)
9571         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9572         (find_line_symtab, info_sources_command)
9573         (default_collect_symbol_completion_matches_break_on)
9574         (make_source_files_completion_list): Update.
9575         * symmisc.c (print_objfile_statistics, dump_objfile)
9576         (maintenance_print_symbols, maintenance_info_symtabs)
9577         (maintenance_check_symtabs, maintenance_info_line_tables):
9578         Update.
9579         * source.c (select_source_symtab)
9580         (forget_cached_source_info_for_objfile): Update.
9581         * objfiles.h (class objfile_compunits): Remove.
9582         (struct objfile) <compunits_range>: New typedef.
9583         (compunits): New method.
9584         * objfiles.c (objfile_relocate1): Update.
9585         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9586         * maint.c (count_symtabs_and_blocks): Update.
9587         * linespec.c (iterate_over_all_matching_symtabs): Update.
9588         * cp-support.c (add_symbol_overload_list_qualified): Update.
9589         * coffread.c (coff_symtab_read): Update.
9590         * ada-lang.c (add_nonlocal_symbols)
9591         (ada_collect_symbol_completion_matches)
9592         (ada_add_global_exceptions): Update.
9593
9594 2019-01-15  Tom Tromey  <tom@tromey.com>
9595
9596         * progspace.h (program_space) <objfiles_safe_range>: New
9597         typedef.
9598         <objfiles_safe>: New method.
9599         * objfiles.h (class all_objfiles_safe): Remove.
9600         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9601         * jit.c (jit_inferior_exit_hook): Update.
9602
9603 2019-01-17  Tom Tromey  <tom@tromey.com>
9604
9605         * progspace.h (program_space) <objfiles_range>: New typedef.
9606         <objfiles>: New method.
9607         <objfiles_head>: Rename from objfiles.
9608         (object_files): Update.
9609         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9610         * guile/scm-pretty-print.c
9611         (ppscm_find_pretty_printer_from_objfiles): Update.
9612         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9613         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9614         Update.
9615         * python/py-progspace.c (pspy_get_objfiles): Update.
9616         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9617         Update.
9618         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9619         (objfpy_lookup_objfile_by_build_id): Update.
9620         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9621         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9622         Update.
9623         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9624         (expand_symtab_containing_pc, lookup_objfile_from_block)
9625         (lookup_static_symbol, basic_lookup_transparent_type)
9626         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9627         (find_line_symtab, info_sources_command)
9628         (default_collect_symbol_completion_matches_break_on)
9629         (make_source_files_completion_list, find_main_name): Update.
9630         * symmisc.c (print_symbol_bcache_statistics)
9631         (print_objfile_statistics, maintenance_print_symbols)
9632         (maintenance_print_msymbols, maintenance_print_objfiles)
9633         (maintenance_info_symtabs, maintenance_check_symtabs)
9634         (maintenance_expand_symtabs, maintenance_info_line_tables):
9635         Update.
9636         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9637         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9638         (map_overlay_command, unmap_overlay_command)
9639         (simple_overlay_update, expand_symtabs_matching)
9640         (map_symbol_filenames): Update.
9641         * symfile-debug.c (set_debug_symfile): Update.
9642         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9643         Update.
9644         * source.c (select_source_symtab, forget_cached_source_info):
9645         Update.
9646         * solib.c (solib_read_symbols): Update.
9647         * solib-spu.c (append_ocl_sos): Update.
9648         * psymtab.c (maintenance_print_psymbols)
9649         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9650         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9651         * printcmd.c (info_symbol_command): Update.
9652         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9653         Update.
9654         * objfiles.h (class all_objfiles): Remove.
9655         * objfiles.c (have_partial_symbols, have_full_symbols)
9656         (have_minimal_symbols, qsort_cmp, update_section_map)
9657         (shared_objfile_contains_address_p)
9658         (default_iterate_over_objfiles_in_search_order): Update.
9659         * objc-lang.c (info_selectors_command, info_classes_command)
9660         (find_methods): Update.
9661         * minsyms.c (find_solib_trampoline_target): Update.
9662         * maint.c (maintenance_info_sections)
9663         (maintenance_translate_address, count_symtabs_and_blocks):
9664         Update.
9665         * main.c (captured_main_1): Update.
9666         * linux-thread-db.c (try_thread_db_load_from_pdir)
9667         (has_libpthread): Update.
9668         * linespec.c (iterate_over_all_matching_symtabs)
9669         (search_minsyms_for_name): Update.
9670         * jit.c (jit_find_objf_with_entry_addr): Update.
9671         * hppa-tdep.c (find_unwind_entry)
9672         (hppa_lookup_stub_minimal_symbol): Update.
9673         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9674         Update.
9675         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9676         (elf_gnu_ifunc_resolve_by_got): Update.
9677         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9678         * dwarf-index-write.c (save_gdb_index_command): Update.
9679         * cp-support.c (add_symbol_overload_list_qualified): Update.
9680         * breakpoint.c (create_overlay_event_breakpoint)
9681         (create_longjmp_master_breakpoint)
9682         (create_std_terminate_master_breakpoint)
9683         (create_exception_master_breakpoint): Update.
9684         * blockframe.c (find_pc_partial_function): Update.
9685         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9686         (ada_collect_symbol_completion_matches)
9687         (ada_add_global_exceptions): Update.
9688
9689 2019-01-17  Tom Tromey  <tom@tromey.com>
9690
9691         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9692         declare VEC.
9693         (solib_target_parse_libraries): Change return type.
9694         (library_list_start_segment, library_list_start_section)
9695         (library_list_end_library, library_list_start_library); Update.
9696         (solib_target_free_library_list): Remove.
9697         (solib_target_parse_libraries): Remove cleanup.  Change return
9698         type.
9699         (solib_target_current_sos): Update.
9700
9701 2019-01-17  Tom Tromey  <tromey@bapiya>
9702
9703         * valprint.c: Replace "the the" with "the".
9704         * symtab.c: Replace "the the" with "the".
9705         * solib.c: Replace "the the" with "the".
9706         * solib-dsbt.c: Replace "the the" with "the".
9707         * linespec.c: Replace "the the" with "the".
9708         * dwarf2loc.h: Replace "the the" with "the".
9709         * amd64-windows-tdep.c: Replace "the the" with "the".
9710         * aarch64-tdep.c: Replace "the the" with "the".
9711
9712 2019-01-16  Keith Seitz  <keiths@redhat.com>
9713
9714         PR gdb/23773
9715         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9716         <builder>: Rename to ..
9717         <m_builder>: ... this and make private.
9718         (dwarf2_cu::get_builder): New method.  Change all users of
9719         `builder' to use this method.
9720         (dwarf2_start_symtab): Move to ...
9721         (dwarf2_cu::start_symtab): ... here.  Update all callers
9722         (setup_type_unit_groups): Move to ...
9723         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9724         callers.
9725         (dwarf2_cu::reset_builder): New method.
9726         (process_full_compunit, process_full_type_unit): Use
9727         dwarf2_cu::reset_builder.
9728         (follow_die_offset): Record the ancestor CU if it is different
9729         from the followed DIE's CU.
9730         (follow_die_sig_1): Likewise.
9731
9732 2019-01-15  Tom Tromey  <tom@tromey.com>
9733
9734         * remote.c (class remote_state) <buf>: Now a char_vector.
9735         <buf_size>: Remove.
9736         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9737         parameter.
9738         (remote_target::getpkt_or_notif_sane_1)
9739         (remote_target::getpkt_sane)
9740         (remote_target::getpkt_or_notif_sane): Likewise.
9741         (class remote_target) <putpkt>: New overload.
9742         (remote_target::read_frame): Change type of "buf_p".  Remove
9743         sizeof_p parameter.
9744         (packet_ok): New overload.
9745         (packet_check_result): New overload.
9746         Update all uses.
9747
9748 2019-01-14  Tom Tromey  <tom@tromey.com>
9749
9750         * remote-notif.c (handle_notification, remote_notif_ack)
9751         (remote_notif_parse): Make "buf" const.
9752         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9753         const.
9754         (remote_notif_parse, remote_notif_ack, handle_notification):
9755         Likewise.
9756         * remote.c (remote_notif_stop_parse): Make "buf" const.
9757         (remote_target::remote_parse_stop_reply): Make "buf" const.
9758         (remote_notif_stop_ack): Make "buf" const.
9759
9760 2019-01-14  Tom Tromey  <tom@tromey.com>
9761
9762         * remote.c (remote_console_output): Make parameter const.
9763
9764 2019-01-14  Tom Tromey  <tom@tromey.com>
9765
9766         * target-debug.h (target_debug_print_signals): Constify.
9767         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9768         * procfs.c (procfs_target::pass_signals): Update.
9769         * linux-nat.c (linux_nat_target::pass_signals): Update.
9770         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9771         * target-delegates.c: Rebuild.
9772         * remote.c (remote_target::program_signals): Update.
9773         (remote_target::pass_signals): Update.
9774         * target.c (target_pass_signals): Constify argument.
9775         (target_program_signals): Likewise.
9776         * target.h (struct target_ops) <pass_signals, program_signals>:
9777         Constify argument.
9778         (target_pass_signals, target_program_signals): Constify argument.
9779
9780 2019-01-14  Tom Tromey  <tom@tromey.com>
9781
9782         PR tui/28819:
9783         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9784
9785 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9786
9787         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9788         field.
9789         * rs6000-tdep.c: Include reggroups.h.
9790         (IS_V_ALIAS_PSEUDOREG): Define.
9791         (rs6000_register_name): Return names for the "vX" aliases.
9792         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9793         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9794         aliases.  Call default_register_reggroup_p for all other
9795         pseudo-registers.
9796         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9797         New functions.
9798         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9799         Handle "vX" aliases.
9800         (v_alias_pseudo_register_collect): New function.
9801         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9802         (rs6000_gdbarch_init): Initialize "vX" aliases as
9803         pseudo-registers.  Restore registration of
9804         rs6000_pseudo_register_reggroup_p with
9805         set_tdesc_pseudo_register_reggroup_p.
9806
9807 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9808
9809         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9810         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9811         set_gdbarch_num_pseudo_regs.
9812
9813 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9814
9815         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9816         Remove arg prefixname, add do_set and do_show.
9817         Add member functions set_list and show_list.
9818         * cli/cli-style.c (class cli_style_option): Update accordingly.
9819         (style_set_list): Move to file scope.
9820         (style_show_list): Likewise.
9821         (set_style): Call help_list.
9822         (show_style): Call cmd_show_list.
9823         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9824         Update to use the new macro.
9825
9826 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9827
9828         * ada-lang.c (_initialize_ada_language): Expand the help text
9829         for the "catch exception" command.
9830
9831 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9832
9833         * symtab.c (matching_obj_sections): Initialize obj,
9834         declare it closer to its usage.
9835
9836 2019-01-10  Tom Tromey  <tom@tromey.com>
9837
9838         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9839         (basic_inf_threads_range): Remove.
9840         (inf_threads_range, inf_non_exited_threads_range)
9841         (safe_inf_threads_range): Use next_adapter.
9842
9843 2019-01-10  Keith Seitz  <keiths@redhat.com>
9844
9845         PR gdb/23712
9846         PR symtab/23010
9847         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9848         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9849
9850 2019-01-10  Keith Seitz  <keiths@redhat.com>
9851
9852         PR gdb/23712
9853         PR symtab/23010
9854         * dictionary.c (pending_to_vector): Remove.
9855         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9856         Remove _1 suffix, replacing functions of the same name.  Update
9857         all callers.
9858         (dict_create_hashed, dict_create_hashed_expandable)
9859         (dict_create_linear, dict_create_linear_expandable, dict_free)
9860         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9861         Make functions static.
9862
9863 2019-01-10  Keith Seitz  <keiths@redhat.com>
9864
9865         PR gdb/23712
9866         PR symtab/23010
9867         * dictionary.h (struct dictionary): Replace declaration with
9868         multidictionary.
9869         (dict_create_hashed, dict_create_hashed_expandable)
9870         (dict_create_linear, dict_create_linear_expandable)
9871         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9872         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9873         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9874         taking multidictionary argument.
9875         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9876         * block.h (struct block) <dict>: Change to multidictionary
9877         and rename `multidict'.
9878         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9879         symmisc.c: Update all dictionary references to multidictionary.
9880
9881 2019-01-10  Keith Seitz  <keiths@redhat.com>
9882
9883         PR gdb/23712
9884         PR symtab/23010
9885         * dictionary.c: Include unordered_map.
9886         (pending_to_vector): New function.
9887         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9888         Rewrite the non-"_1" functions to take vector instead
9889         of linked list.
9890         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9891         "new" _1 versions of the same name.
9892         (multidictionary): Define.
9893         (std::hash<enum language): New definition.
9894         (collate_pending_symbols_by_language, mdict_create_hashed)
9895         (mdict_create_hashed_expandable, mdict_create_linear)
9896         (mdict_create_linear_expandable, mdict_free)
9897         (find_language_dictionary, create_new_language_dictionary)
9898         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9899         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9900         (mdict_size, mdict_empty): New functions.
9901         * dictionary.h (mdict_iterator): Define.
9902
9903 2019-01-10  Pedro Alves  <palves@redhat.com>
9904
9905         * breakpoint.c (read_uploaded_action)
9906         (create_tracepoint_from_upload): Adjust to use
9907         gdb::unique_xmalloc_ptr.
9908         * ctf.c (ctf_write_uploaded_tp):
9909         (SET_ARRAY_FIELD): Use emplace_back.
9910         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9911         * tracefile-tfile.c (tfile_write_uploaded_tp):
9912         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9913         gdb::unique_xmalloc_ptr.
9914         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9915         at_string, cond_string, cmd_strings>: Replace char pointers
9916         with gdb::unique_xmalloc_ptr.
9917
9918 2019-01-10  Pedro Alves  <palves@redhat.com>
9919
9920         * solib-target.c (library_list_start_library): Don't xstrdup name.
9921
9922 2019-01-10  Pedro Alves  <palves@redhat.com>
9923
9924         * mdebugread.c (parse_partial_symbols): Use
9925         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9926
9927 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9928
9929         * linux-fork.c (scoped_switch_fork_info)
9930         <~scoped_switch_fork_info>: Fix incorrect variable name.
9931
9932 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9933
9934         * linux-fork.c (scoped_switch_fork_info)
9935         <scoped_switch_fork_info>: Make explicit.
9936         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9937
9938 2019-01-10  Tom Tromey  <tom@tromey.com>
9939
9940         * objfiles.h (objfile::reset_psymtabs): Update.
9941         * objfiles.c (objfile::objfile): Update.
9942         * psymtab.h (psymtab_storage::obstack): Update.
9943         (psymtab_storage::m_obstack): Use gdb::optional.
9944         (class psymtab_storage): Update comment.  Remove objfile
9945         parameter.
9946         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9947
9948 2019-01-10  Tom Tromey  <tom@tromey.com>
9949
9950         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9951         <free_psymtabs>: Now private.
9952         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9953         (allocate_psymtab): Use new method.
9954
9955 2019-01-10  Tom Tromey  <tom@tromey.com>
9956
9957         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9958         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9959         * mdebugread.c (parse_partial_symbols): Use
9960         allocate_dependencies.
9961         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9962         allocate_dependencies.
9963         (process_psymtab_comp_unit_reader)
9964         (build_type_psymtab_dependencies): Likewise.
9965         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9966
9967 2019-01-10  Tom Tromey  <tom@tromey.com>
9968
9969         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9970         PSYMBOL_SET_LANGUAGE.
9971         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9972
9973 2019-01-10  Tom Tromey  <tom@tromey.com>
9974
9975         * psymtab.h (psymtab_storage::obstack): New method.
9976         <m_obstack>: Rename from obstack; now private.
9977         * psymtab.c (psymtab_storage): Update.
9978         * dwarf2read.c (create_addrmap_from_index)
9979         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9980         Update.
9981
9982 2019-01-10  Tom Tromey  <tom@tromey.com>
9983
9984         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9985         * objfiles.h (objfile::reset_psymtabs): New method.
9986
9987 2019-01-10  Tom Tromey  <tom@tromey.com>
9988
9989         * symmisc.c (print_symbol_bcache_statistics): Update.
9990         (print_objfile_statistics): Update.
9991         * symfile.c (reread_symbols): Update.
9992         * psymtab.h (class psymtab_storage): New.
9993         * psymtab.c (psymtab_storage): New constructor.
9994         (~psymtab_storage): New destructor.
9995         (require_partial_symbols): Update.
9996         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9997         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9998         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9999         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
10000         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
10001         (start_psymtab_common, end_psymtab_common)
10002         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
10003         (allocate_psymtab): Update.
10004         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
10005         Update.
10006         (dump_psymtab_addrmap, maintenance_print_psymbols)
10007         (maintenance_check_psymtabs): Update.
10008         (class objfile_psymtabs): Move to objfiles.h.
10009         * psympriv.h (discard_psymtab): Now inline.
10010         (psymtab_discarder::psymtab_discarder): Update.
10011         (psymtab_discarder::~psymtab_discarder): Update.
10012         (ALL_OBJFILE_PSYMTABS): Rewrite.
10013         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
10014         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10015         Remove fields.
10016         <partial_symtabs>: New field.
10017         (class objfile_psymtabs): Move from psymtab.h.  Update.
10018         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10019         psymbol_cache.
10020         (objfile::~objfile): Don't destroy psymbol_cache.
10021         * mdebugread.c (parse_partial_symbols): Update.
10022         * dwarf2read.c (create_addrmap_from_index)
10023         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10024         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10025         (add_partial_subprogram, dwarf2_ranges_read): Update.
10026         * dwarf-index-write.c (write_address_map)
10027         (write_one_signatured_type, recursively_write_psymbols)
10028         (class debug_names, class debug_names, write_psymtabs_to_index):
10029         Update.
10030
10031 2019-01-10  Tom Tromey  <tom@tromey.com>
10032
10033         * symtab.h (SYMBOL_SET_NAMES): Update.
10034         (symbol_set_names): Update.
10035         (MSYMBOL_SET_NAMES): Update.
10036         * symtab.c (symbol_set_names): Change argument to be an
10037         objfile_per_bfd_storage.
10038         * psymtab.c (add_psymbol_to_bcache): Update.
10039         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10040
10041 2019-01-10  Tom Tromey  <tom@tromey.com>
10042
10043         * symtab.c (create_demangled_names_hash): Change argument to be an
10044         objfile_per_bfd_storage.
10045         (symbol_set_names): Update.
10046
10047 2019-01-10  Tom Tromey  <tom@tromey.com>
10048
10049         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10050         init_psymbol_list.
10051         * psymtab.c (init_psymbol_list): Do nothing if already called.
10052         * psympriv.h (init_psymbol_list): Add comment.
10053         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10054         init_psymbol_list.
10055         * dbxread.c (dbx_symfile_read): Unconditionally call
10056         init_psymbol_list.
10057
10058 2019-01-10  Tom Tromey  <tom@tromey.com>
10059
10060         * xcoffread.c (scan_xcoff_symtab): Update.
10061         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10062         "where".
10063         * mdebugread.c (parse_partial_symbols)
10064         (handle_psymbol_enumerators): Update.
10065         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10066         * dbxread.c (read_dbx_symtab): Update.
10067         * psympriv.h (psymbol_placement): New enum.
10068         (add_psymbol_to_list): Update.
10069
10070 2019-01-10  Tom Tromey  <tom@tromey.com>
10071
10072         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10073         static_psymbols parameters.
10074         (scan_xcoff_symtab): Update.
10075         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10076         static_psymbols parameters.
10077         * psympriv.h (start_psymtab_common): Update.
10078         * mdebugread.c (parse_partial_symbols): Update.
10079         * dwarf2read.c (create_partial_symtab): Update.
10080         * dbxread.c (read_dbx_symtab): Update.
10081         (start_psymtab): Remove global_psymbols and static_psymbols
10082         parameters.
10083
10084 2019-01-10  Tom Tromey  <tom@tromey.com>
10085
10086         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10087         * psymtab.c (allocate_psymtab): Add comment.
10088         * psympriv.h (allocate_psymtab): Add comment.
10089         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10090         initializations.
10091         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10092
10093 2019-01-10  Tom Tromey  <tom@tromey.com>
10094
10095         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10096         Don't declare.
10097         * mipsread.c: Include mdebugread.h.
10098         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10099         Declare.
10100         * elfread.c: Include mdebugread.h.
10101
10102 2019-01-09  Tom Tromey  <tom@tromey.com>
10103
10104         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10105         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10106         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10107         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10108         (psym_lookup_symbol, psym_find_last_source_symtab)
10109         (psym_forget_cached_source_info, psym_print_stats)
10110         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10111         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10112         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10113         (psym_find_compunit_symtab_by_address)
10114         (maintenance_print_psymbols, maintenance_info_psymtabs)
10115         (maintenance_check_psymtabs): Use ranged for.
10116         * psymtab.h (class objfile_psymtabs): New.
10117         (require_partial_symbols): Return objfile_psymtabs.
10118         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10119
10120 2019-01-09  Tom Tromey  <tom@tromey.com>
10121
10122         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10123         (find_pc_mapped_section, list_overlays_command)
10124         (map_overlay_command, unmap_overlay_command)
10125         (simple_overlay_update): Use all_objfiles.
10126         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10127         * printcmd.c (info_symbol_command): Use all_objfiles.
10128         * objfiles.h (ALL_OBJSECTIONS): Remove.
10129         * maint.c (maintenance_translate_address): Use all_objfiles.
10130         * gcore.c (gcore_create_callback): Use all_objfiles.
10131         (objfile_find_memory_regions): Likewise.
10132
10133 2019-01-09  Tom Tromey  <tom@tromey.com>
10134
10135         * symtab.c (find_line_symtab, info_sources_command)
10136         (make_source_files_completion_list): Use objfile_compunits.
10137         * source.c (select_source_symtab): Use objfile_compunits.
10138         * objfiles.h (struct objfile): Update comment.
10139         (ALL_OBJFILES): Remove.
10140         (ALL_FILETABS): Remove.
10141         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10142         objfile_compunits.
10143
10144 2019-01-09  Tom Tromey  <tom@tromey.com>
10145
10146         * symmisc.c (print_objfile_statistics, dump_objfile)
10147         (maintenance_print_symbols): Use compunit_filetabs.
10148         * source.c (forget_cached_source_info_for_objfile): Use
10149         compunit_filetabs.
10150         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10151         (ALL_FILETABS): Use compunit_filetabs.
10152         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10153         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10154
10155 2019-01-09  Tom Tromey  <tom@tromey.com>
10156
10157         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10158         (compunit_filetabs): New.
10159         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10160         compunit_filetabs.
10161         (info_sources_command, make_source_files_completion_list): Remove
10162         declaration.
10163         * symmisc.c (print_objfile_statistics, dump_objfile)
10164         (maintenance_print_symbols): Remove declaration.
10165         (maintenance_info_symtabs): Use compunit_filetabs.
10166         (maintenance_info_line_tables): Likewise.
10167         * source.c (select_source_symtab): Change local variable name.
10168         (forget_cached_source_info_for_objfile): Remove declaration.
10169         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10170         * objfiles.c (objfile_relocate1): Remove declaration.
10171         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10172         declaration.
10173         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10174         * coffread.c (coff_symtab_read): Remove declaration.
10175         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10176         compunit_filetabs.
10177
10178 2019-01-09  Tom Tromey  <tom@tromey.com>
10179
10180         * symtab.c (lookup_objfile_from_block)
10181         (find_pc_sect_compunit_symtab, search_symbols)
10182         (default_collect_symbol_completion_matches_break_on): Use
10183         objfile_compunits.
10184         * objfiles.h (ALL_COMPUNITS): Remove.
10185         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10186         * cp-support.c (add_symbol_overload_list_qualified): Use
10187         objfile_compunits.
10188         * ada-lang.c (ada_collect_symbol_completion_matches)
10189         (ada_add_global_exceptions): Use objfile_compunits.
10190
10191 2019-01-09  Tom Tromey  <tom@tromey.com>
10192
10193         * source.c (select_source_symtab)
10194         (forget_cached_source_info_for_objfile): Remove declaration.
10195         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10196         declaration.
10197         * maint.c (count_symtabs_and_blocks): Remove declaration.
10198         * cp-support.c (add_symbol_overload_list_qualified): Remove
10199         declaration.
10200         * coffread.c (coff_symtab_read): Remove declaration.
10201         * symtab.c (lookup_symbol_in_objfile_symtabs)
10202         (basic_lookup_transparent_type_1): Use objfile_compunits.
10203         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10204         (info_sources_command, search_symbols)
10205         (default_collect_symbol_completion_matches_break_on)
10206         (make_source_files_completion_list): Remove declaration.
10207         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10208         (ada_collect_symbol_completion_matches)
10209         (ada_add_global_exceptions): Remove declaration.
10210         * linespec.c (iterate_over_all_matching_symtabs): Use
10211         objfile_compunits.
10212         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10213         (class objfile_compunits): New.
10214         (ALL_COMPUNITS): Use objfile_compunits.
10215         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10216         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10217         objfile_compunits.
10218         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10219
10220 2019-01-09  Tom Tromey  <tom@tromey.com>
10221
10222         * symtab.c (search_symbols)
10223         (default_collect_symbol_completion_matches_break_on): Use
10224         objfile_msymbols.
10225         * ada-lang.c (ada_lookup_simple_minsym)
10226         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10227         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10228         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10229         objfile_msymbols.
10230         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10231         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10232         * objc-lang.c (find_methods): Use objfile_msymbols.
10233         (info_selectors_command, info_classes_command): Likewise.
10234         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10235         * objfiles.h (class objfile_msymbols): New.
10236         (ALL_OBJFILE_MSYMBOLS): Remove.
10237         (ALL_MSYMBOLS): Remove.
10238
10239 2019-01-09  Tom Tromey  <tom@tromey.com>
10240
10241         * common/next-iterator.h (next_adapter): Add Iterator template
10242         parameter.
10243         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10244         (class all_objfiles_safe): New.
10245         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10246         * objfiles.c (put_objfile_before): Update comment.
10247         (add_separate_debug_objfile): Likewise.
10248         (free_all_objfiles): Use all_objfiles_safe.
10249         (objfile_purge_solibs): Likewise.
10250
10251 2019-01-09  Tom Tromey  <tom@tromey.com>
10252
10253         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10254         (expand_symtab_containing_pc, lookup_static_symbol)
10255         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10256         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10257         all_objfiles.
10258         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10259         * breakpoint.c (create_overlay_event_breakpoint)
10260         (create_longjmp_master_breakpoint)
10261         (create_std_terminate_master_breakpoint)
10262         (create_exception_master_breakpoint): Use all_objfiles.
10263         * linux-thread-db.c (try_thread_db_load_from_pdir)
10264         (has_libpthread): Use all_objfiles.
10265         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10266         * linespec.c (iterate_over_all_matching_symtabs)
10267         (search_minsyms_for_name): Use all_objfiles.
10268         * maint.c (maintenance_info_sections): Use all_objfiles.
10269         * main.c (captured_main_1): Use all_objfiles.
10270         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10271         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10272         * guile/scm-pretty-print.c
10273         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10274         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10275         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10276         (maintenance_print_msymbols): Use all_objfiles.
10277         * source.c (select_source_symtab): Use all_objfiles.
10278         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10279         * symfile.c (remove_symbol_file_command)
10280         (expand_symtabs_matching, map_symbol_filenames): Use
10281         all_objfiles.
10282         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10283         all_objfiles.
10284         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10285         * objc-lang.c (find_methods): Use all_objfiles.
10286         * objfiles.c (have_partial_symbols, have_full_symbols)
10287         (have_minimal_symbols, qsort_cmp)
10288         (default_iterate_over_objfiles_in_search_order): Use
10289         all_objfiles.
10290         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10291         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10292         (maintenance_check_psymtabs): Use all_objfiles.
10293         (ALL_PSYMTABS): Remove.
10294         * compile/compile-object-run.c (do_module_cleanup): Use
10295         all_objfiles.
10296         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10297         * cp-support.c (add_symbol_overload_list_qualified): Use
10298         all_objfiles.
10299         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10300         Use all_objfiles.
10301         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10302         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10303         all_objfiles.
10304         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10305         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10306         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10307         Uses all_objfiles.
10308         * solib.c (solib_read_symbols): Use all_objfiles
10309
10310 2019-01-09  Tom Tromey  <tom@tromey.com>
10311
10312         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10313         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10314         all_objfiles.
10315         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10316         * symmisc.c (print_symbol_bcache_statistics)
10317         (print_objfile_statistics, maintenance_print_objfiles)
10318         (maintenance_info_symtabs, maintenance_check_symtabs)
10319         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10320         all_objfiles.
10321         * source.c (forget_cached_source_info): Use all_objfiles.
10322         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10323         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10324         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10325         * objfiles.c (update_section_map): Use all_objfiles.
10326         (shared_objfile_contains_address_p): Likewise.
10327         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10328         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10329
10330 2019-01-09  Tom Tromey  <tom@tromey.com>
10331
10332         * common/next-iterator.h: New file.
10333         * objfiles.h (class all_objfiles): New.
10334         (struct objfile_iterator): New.
10335
10336 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10337
10338         * NEWS: Move the description of the changed "frame", "select-frame",
10339          and "info frame" commands to the Changed commands section.
10340
10341 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10342
10343         * gdbtypes.c (check_stub_method_group): Remove handling of old
10344         mangling schemes.
10345         * linespec.c (find_methods): Likewise.
10346         * stabsread.c (read_member_functions): Likewise.
10347         * valops.c (search_struct_method): Likewise.
10348         (value_struct_elt_for_reference): Likewise.
10349         * NEWS: Mention this change.
10350
10351 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10352
10353         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10354         print_source_lines.
10355         * source.c (print_source_lines_base): Update line number check.
10356         (print_source_lines): New function.
10357         (source_lines_range::source_lines_range): New function.
10358         * source.h (class source_lines_range): New class.
10359         (print_source_lines): New declaration.
10360
10361 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10362
10363         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10364
10365 2019-01-08  Tom Tromey  <tom@tromey.com>
10366             Simon Marchi  <simon.marchi@ericsson.com>
10367
10368         PR gdb/24060
10369         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10370         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10371         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10372         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10373         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10374         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10375
10376 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10377
10378         * source.c (select_source_symtab): Move header comment to
10379         declaration in source.h.
10380         (forget_cached_source_info_for_objfile): Likewise.
10381         (forget_cached_source_info): Likewise.
10382         (identify_source_line): Likewise.
10383         * source.h (identify_source_line): Move declaration from symtab.h
10384         and add comment from source.c
10385         (print_source_lines): Likewise.
10386         (forget_cached_source_info_for_objfile): Likewise.
10387         (forget_cached_source_info): Likewise.
10388         (select_source_symtab): Likewise.
10389         (enum print_source_lines_flag): Move definition from symtab.h.
10390         * symtab.h (identify_source_line): Move declaration to source.h.
10391         (print_source_lines): Likewise.
10392         (forget_cached_source_info_for_objfile): Likewise.
10393         (forget_cached_source_info): Likewise.
10394         (select_source_symtab): Likewise.
10395         (enum print_source_lines_flag): Move definition to source.h.
10396         * tui/tui-hooks.c: Add 'source.h' include.
10397
10398 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10399
10400         * source.c (print_source_lines_base): Handle requests to print
10401         reverse line number sequences, and guard against empty lines
10402         string.
10403
10404 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10405
10406         * source.c (print_source_lines_base): Fix skip of '\r' if next
10407         character is '\n'.
10408
10409 2019-01-06  Tom Tromey  <tom@tromey.com>
10410
10411         * c-exp.y (struct c_parse_state) <macro_original_text,
10412         expansion_obstack>: New member.
10413         (macro_original_text, expansion_obstack): Remove globals.
10414         (scan_macro_expansion, scanning_macro_expansion)
10415         (finished_macro_expansion): Update.
10416         (scan_macro_cleanup): Remove.
10417         (yylex, c_parse): Update.
10418
10419 2019-01-06  Tom Tromey  <tom@tromey.com>
10420
10421         * c-exp.y (struct c_parse_state) <strings>: New member.
10422         (operator_stoken): Update.
10423
10424 2019-01-06  Tom Tromey  <tom@tromey.com>
10425
10426         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10427         (union type_stack_elt) <typelist_val>: Now a pointer to
10428         std::vector.
10429         (type_stack_cleanup): Don't declare.
10430         (push_typelist): Update.
10431         * parse.c (pop_typelist): Return a std::vector.
10432         (push_typelist): Take a std::vector.
10433         (follow_types): Update.  Do not free args.
10434         (type_stack_cleanup): Remove.
10435         * c-exp.y (struct c_parse_state): New.
10436         (cpstate): New global.
10437         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10438         (nonempty_typelist): Update.
10439         (func_mod): Create a new vector.
10440         (c_parse): Create a c_parse_state.
10441         (check_parameter_typelist): Do not delete params.
10442         (function_method): Update.  Do not delete type_list.
10443
10444 2019-01-06  Tom Tromey  <tom@tromey.com>
10445
10446         PR gdb/28155:
10447         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10448         check_typedef.
10449         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10450         (print_return_value): Likewise.
10451
10452 2019-01-05  Tom Tromey  <tom@tromey.com>
10453
10454         * contrib/cleanup_check.py: Remove.
10455         * contrib/gcc-with-excheck: Remove.
10456         * contrib/exsummary.py: Remove.
10457         * contrib/excheck.py: Remove.
10458
10459 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10460
10461         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10462         NULL. Initialize tpprev to NULL instead of assigning it
10463         to NULL on the next statement.
10464         * windows-nat.c (windows_delete_thread): Remove check for
10465         main_thread_id before printing thread exit notifications.
10466         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10467         Remove thread ID check against main_thread_id.
10468         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10469         windows_delete_thread.
10470         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10471
10472 2019-01-04  Tom Tromey  <tom@tromey.com>
10473
10474         * compile/compile.c (_initialize_compile): Use upper case for
10475         metasyntactic variables.
10476         * symmisc.c (_initialize_symmisc): Use upper case for
10477         metasyntactic variables.
10478         * psymtab.c (_initialize_psymtab): Use upper case for
10479         metasyntactic variables.
10480         * demangle.c (demangle_command): Use upper case for metasyntactic
10481         variables.
10482         (_initialize_demangler): Likewise.
10483         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10484         variables.
10485
10486 2019-01-03  Tom Tromey  <tom@tromey.com>
10487
10488         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10489
10490 2019-01-03  Tom Tromey  <tom@tromey.com>
10491
10492         * python/py-symtab.c (salpy_str): Update.
10493         (struct salpy_sal_object) <symtab>: Now a PyObject.
10494         (salpy_dealloc): Update.
10495         (del_objfile_sal): Use gdbpy_ref.
10496
10497 2019-01-03  Tom Tromey  <tom@tromey.com>
10498
10499         * python/py-type.c (convert_field): Use new_reference.  Return
10500         gdbpy_ref.
10501         (make_fielditem): Return gdbpy_ref.
10502         (typy_fields): Update.
10503         (typy_getitem): Update.
10504         (field_name): Return gdbpy_ref.  Use new_reference.
10505         (typy_iterator_iternext): Update.
10506
10507 2019-01-03  Tom Tromey  <tom@tromey.com>
10508
10509         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10510
10511 2019-01-03  Tom Tromey  <tom@tromey.com>
10512
10513         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10514         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10515         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10516         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10517         (pspy_set_type_printers): Likewise.
10518         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10519         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10520         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10521         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10522         (objfpy_set_type_printers): Likewise.
10523
10524 2019-01-03  Tom Tromey  <tom@tromey.com>
10525
10526         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10527         (gdbpy_print_stack): Use gdbpy_err_fetch.
10528         * python/python-internal.h (class gdbpy_err_fetch): New class.
10529         (class gdbpy_enter) <m_error_type, m_error_value,
10530         m_error_traceback>: Remove.
10531         <m_error>: New member.
10532         (gdbpy_exception_to_string): Don't declare.
10533         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10534         * python/py-value.c (convert_value_from_python): Use
10535         gdbpy_err_fetch.
10536         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10537         gdbpy_exception_to_string.
10538         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10539         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10540         gdbpy_err_fetch.
10541
10542 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10543
10544         * linux-nat.c (delete_lwp_cleanup): Delete.
10545         (struct lwp_deleter): New struct.
10546         (lwp_info_up): New typedef.
10547         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10548         lwp_info_up.
10549
10550 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10551
10552         * linux-fork.c (class scoped_switch_fork_info): New class.
10553         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10554
10555 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10556
10557         * valops.c (find_overload_match): Remove use of null_cleanup, and
10558         calls to do_cleanups.
10559
10560 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10561
10562         * compile/compile-cplus-types.c
10563         (compile_cplus_instance::decl_name): Handle changes to
10564         cp_func_name.
10565         * cp-support.c (cp_func_name): Update header comment, update
10566         return type.
10567         * cp-support.h (cp_func_name): Update return type in declaration.
10568         * valops.c (find_overload_match): Move temp_func local to top
10569         level of function and change its type.  Use temp_func to hold and
10570         delete temporary string obtained from cp_func_name.
10571
10572 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10573
10574         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10575         gdb::char_vector, remove cleanup, and update uses of `msg`.
10576
10577 2019-01-03  Jim Wilson  <jimw@sifive.com>
10578
10579         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10580
10581 2019-01-02  Tom Tromey  <tom@tromey.com>
10582
10583         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10584         (tdesc_parse_xml): Remove cleanups.
10585         * target-descriptions.h (make_cleanup_free_target_description):
10586         Don't declare.
10587         (target_desc_deleter): New struct.
10588         (target_desc_up): New typedef.
10589         * target-descriptions.c (target_desc_deleter::operator()): Rename
10590         from free_target_description.
10591         (make_cleanup_free_target_description): Remove.
10592
10593 2019-01-02  Tom Tromey  <tom@tromey.com>
10594
10595         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10596         constructor, destructor.
10597         (linespec_parser): Remove typedef.
10598         (~linespec_parser): Rename from linespec_parser_delete.
10599         (linespec_lex_to_end, linespec_complete_label)
10600         (linespec_complete): Update.
10601         (decode_line_full): Remove cleanups.
10602         (decode_line_1): Update.
10603
10604 2019-01-02  Tom Tromey  <tom@tromey.com>
10605
10606         * python/python-internal.h (inferior_to_inferior_object): Change
10607         return type.
10608         * python/py-exitedevent.c (create_exited_event_object): Update.
10609         * python/py-inferior.c (inferior_to_inferior_object): Return
10610         gdbpy_ref.
10611         (python_new_inferior, python_inferior_deleted)
10612         (thread_to_thread_object, delete_thread_object)
10613         (build_inferior_list, gdbpy_selected_inferior): Update.
10614         * python/py-infthread.c (create_thread_object): Update.  Also fail
10615         if inferior_to_inferior_object fails.
10616
10617 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10618
10619         * inferior.h (class inferior) <displaced_step_state>: New field.
10620         * infrun.h (struct displaced_step_state): Move here from
10621         infrun.c.  Initialize fields, add constructor.
10622         <inf>: Remove field.
10623         <reset>: New method.
10624         * infrun.c (struct displaced_step_inferior_state): Move to
10625         infrun.h.
10626         (displaced_step_inferior_states): Remove.
10627         (get_displaced_stepping_state): Adust.
10628         (displaced_step_in_progress_any_inferior): Adjust.
10629         (displaced_step_in_progress_thread): Adjust.
10630         (displaced_step_in_progress): Adjust.
10631         (add_displaced_stepping_state): Remove.
10632         (get_displaced_step_closure_by_addr): Adjust.
10633         (remove_displaced_stepping_state): Remove.
10634         (infrun_inferior_exit): Call displaced_step_state.reset.
10635         (use_displaced_stepping): Don't check for NULL.
10636         (displaced_step_prepare_throw): Call
10637         get_displaced_stepping_state.
10638         (displaced_step_fixup): Don't check for NULL.
10639         (prepare_for_detach): Don't check for NULL.
10640
10641 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10642
10643         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10644          in case of call that did not complete.
10645
10646 2019-01-02  Andrey Utkin  <autkin@undo.io>
10647
10648         * symfile.c (find_separate_debug_file): Fix search of debug files for
10649         remote debuggee.
10650
10651 2019-01-02  Tom Tromey  <tom@tromey.com>
10652
10653         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10654         indentation.
10655         * python/py-frame.c (frapy_older): Remove cast.
10656         (frapy_newer): Likewise.
10657         * python/py-breakpoint.c (local_setattro): Remove cast.
10658         * python/py-arch.c (archpy_name): Remove local variable.
10659         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10660
10661 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10662
10663         * unittests/basic_string_view/element_access/char/empty.cc:
10664         Fix year range in copyright header.
10665
10666 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10667
10668         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10669         Delete.
10670         <operator==>: Update with for removed field.
10671         <hash>: Likewise.
10672         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10673         <isa_features>: ...this.
10674         <abi_features>: New field.
10675         (riscv_isa_flen): Update comment.
10676         (riscv_abi_xlen): New declaration.
10677         (riscv_abi_flen): New declaration.
10678         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10679         isa_features.
10680         (riscv_abi_xlen): New function.
10681         (riscv_isa_flen): Update to get answer from isa_features.
10682         (riscv_abi_flen): New function.
10683         (riscv_has_fp_abi): Update to get answer from abi_features.
10684         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10685         xlen and flen.
10686         (riscv_call_info) <xlen, flen>: Update comment.
10687         (riscv_call_arg_struct): Remove invalid assertions
10688         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10689         is removed.
10690         (riscv_gdbarch_init): Gather isa features and abi features
10691         separately, ensure both match on the gdbarch when reusing an old
10692         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10693         a target with 64-bit float hardware.
10694
10695 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10696
10697         * source.c (search_command_helper): Stop reverse search
10698         when line 1 has been searched.
10699
10700 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10701
10702         * record-full.c (record_full_base_target::close): Rewrite
10703         record_full_core_buf_list free logic.
10704
10705 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10706
10707         * break-catch-syscall.c (print_one_catch_syscall): xfree
10708         the last text.
10709
10710 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10711
10712         * top.c (print_gdb_version): Update Copyright year in version
10713         message.
10714
10715 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10716
10717         Update copyright year range in all GDB files.
10718
10719 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10720
10721         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10722
10723 For older changes see ChangeLog-2018.
10724 \f
10725 Local Variables:
10726 mode: change-log
10727 left-margin: 8
10728 fill-column: 74
10729 version-control: never
10730 coding: utf-8
10731 End:
10732