gdb/ChangeLog

   1 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * loc.h (dwarf2_get_die_type): Move to...
   4         * read.h (dwarf2_get_die_type): ... here.
   5         * read.c (dwarf2_get_die_type): Move doc to header.
   6
   7 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
   8
   9         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
  10         'gnulib/Makefile.in' to the list.
  11
  12 2020-02-24  Tom Tromey  <tom@tromey.com>
  13
  14         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
  15         Remove.
  16         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
  17         XOBNEWVEC.
  18
  19 2020-02-24  Tom Tromey  <tom@tromey.com>
  20
  21         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
  22         New method.
  23         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
  24         (dw2_do_instantiate_symtab, dw2_get_file_names)
  25         (build_type_psymtab_dependencies, load_full_type_unit): Update.
  26
  27 2020-02-24  Tom Tromey  <tom@tromey.com>
  28
  29         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
  30         make_scoped_restore.
  31         (dwarf2_psymtab::read_symtab): Don't clear
  32         reading_partial_symbols.
  33
  34 2020-02-24  Tom de Vries  <tdevries@suse.de>
  35
  36         PR gdb/25592
  37         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
  38
  39 2020-02-24  Tom de Vries  <tdevries@suse.de>
  40
  41         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
  42         commands layout next/prev/regs.
  43
  44 2020-02-22  Tom Tromey  <tom@tromey.com>
  45
  46         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
  47         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
  48
  49 2020-02-22  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
  52
  53 2020-02-22  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-win.c (_initialize_tui_win): Add usage text.
  56         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
  57         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
  58         * tui/tui.c (_initialize_tui): Add usage text.
  59
  60 2020-02-22  Tom Tromey  <tom@tromey.com>
  61
  62         * tui/tui-win.c (tui_set_focus_command)
  63         (tui_set_win_height_command): Use error_no_arg.
  64         (_initialize_tui_win): Update help text.
  65         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
  66
  67 2020-02-22  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
  70         * tui/tui-disasm.h (struct tui_disasm_window)
  71         <display_start_addr>: Declare.
  72         * tui/tui-source.h (struct tui_source_window)
  73         <display_start_addr>: Declare.
  74         * tui/tui-winsource.h (struct tui_source_window_base)
  75         <show_source_line, display_start_addr>: New methods.
  76         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
  77         Rename and move to protected section.
  78         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
  79         (tui_source_window_base::do_erase_source_content): Update.
  80         (tui_source_window_base::show_source_line): Now a method.
  81         (tui_source_window_base::show_source_content)
  82         (tui_source_window_base::tui_source_window_base)
  83         (tui_source_window_base::rerender)
  84         (tui_source_window_base::refill)
  85         (tui_source_window_base::do_scroll_horizontal)
  86         (tui_source_window_base::set_is_exec_point_at)
  87         (tui_source_window_base::update_breakpoint_info)
  88         (tui_source_window_base::update_exec_info): Update.
  89         * tui/tui-source.c (tui_source_window::set_contents)
  90         (tui_source_window::showing_source_p)
  91         (tui_source_window::do_scroll_vertical)
  92         (tui_source_window::location_matches_p)
  93         (tui_source_window::line_is_displayed): Update.
  94         (tui_source_window::display_start_addr): New method.
  95         * tui/tui-disasm.c (tui_disasm_window::set_contents)
  96         (tui_disasm_window::do_scroll_vertical)
  97         (tui_disasm_window::location_matches_p): Update.
  98         (tui_disasm_window::display_start_addr): New method.
  99
 100 2020-02-22  Tom Tromey  <tom@tromey.com>
 101
 102         * NEWS: Add entry for gdb.register_window_type.
 103         * tui/tui-layout.h (window_factory): New typedef.
 104         (tui_register_window): Declare.
 105         * tui/tui-layout.c (saved_tui_windows): New global.
 106         (tui_apply_current_layout): Use it.
 107         (tui_register_window): New function.
 108         * python/python.c (do_start_initialization): Call
 109         gdbpy_initialize_tui.
 110         (python_GdbMethods): Add "register_window_type" function.
 111         * python/python-internal.h (gdbpy_register_tui_window)
 112         (gdbpy_initialize_tui): Declare.
 113         * python/py-tui.c: New file.
 114         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
 115
 116 2020-02-22  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
 119
 120 2020-02-22  Tom Tromey  <tom@tromey.com>
 121
 122         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
 123         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
 124         * tui/tui-data.c (tui_set_win_with_focus): Remove.
 125         (tui_set_win_focus_to): Move from tui-win.c.
 126
 127 2020-02-22  Tom Tromey  <tom@tromey.com>
 128
 129         * tui/tui-layout.c (make_standard_window, get_locator_window): New
 130         functions.
 131         (known_window_types): New global.
 132         (tui_get_window_by_name): Reimplement.
 133         (initialize_known_windows): New function.
 134         (validate_window_name): Rewrite.
 135         (_initialize_tui_layout): Call initialize_known_windows.
 136
 137 2020-02-22  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
 140         Remove constants.
 141         * tui/tui-winsource.h (struct tui_source_window_base)
 142         <tui_source_window_base>: Remove parameter.
 143         * tui/tui-winsource.c
 144         (tui_source_window_base::tui_source_window_base): Remove
 145         parameter.
 146         (tui_source_window_base::refill): Update.
 147         * tui/tui-stack.h (struct tui_locator_window)
 148         <tui_locator_window>: Update.
 149         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
 150         Default the constructor.
 151         * tui/tui-regs.h (struct tui_data_item_window)
 152         <tui_data_item_window>: Default the constructor.
 153         (struct tui_data_window) <tui_data_window>: Likewise.
 154         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
 155         Default the constructor.
 156         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
 157         Default the constructor.
 158         <type>: Remove.
 159         (struct tui_win_info) <tui_win_info>: Default the constructor.
 160         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
 161         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
 162         Default the constructor.
 163
 164 2020-02-22  Tom Tromey  <tom@tromey.com>
 165
 166         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
 167         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
 168         * tui/tui-win.c (tui_resize_all): Don't call
 169         tui_delete_invisible_windows.
 170         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
 171         done.
 172         (tui_set_layout): Update.
 173         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
 174         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
 175         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
 176
 177 2020-02-22  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
 180         correctly.
 181
 182 2020-02-22  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
 185
 186 2020-02-22  Tom Tromey  <tom@tromey.com>
 187
 188         * tui/tui-winsource.h (struct tui_source_window_iterator)
 189         <inner_iterator>: New etytypedef.
 190         <tui_source_window_iterator>: Take "end" parameter.
 191         <tui_source_window_iterator>: Take iterator.
 192         <operator*, advance>: Update.
 193         <m_iter>: Change type.
 194         <m_end>: New field.
 195         (struct tui_source_windows) <begin, end>: Update.
 196         * tui/tui-layout.c (tui_windows): New global.
 197         (tui_apply_current_layout): Clear tui_windows.
 198         (tui_layout_window::apply): Update tui_windows.
 199         * tui/tui-data.h (tui_windows): Declare.
 200         (all_tui_windows): Now inline function.
 201         (class tui_window_iterator, struct all_tui_windows): Remove.
 202
 203 2020-02-22  Tom Tromey  <tom@tromey.com>
 204
 205         PR tui/17850:
 206         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
 207         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
 208         "height" argument.
 209         (class tui_layout_window) <get_sizes>: Likewise.
 210         (class tui_layout_split) <tui_layout_split>: Add "vertical"
 211         argument.
 212         <get_sizes>: Add "height" argument.
 213         <m_vertical>: New field.
 214         * tui/tui-layout.c (tui_layout_split::clone): Update.
 215         (tui_layout_split::get_sizes): Add "height" argument.
 216         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
 217         (tui_new_layout_command): Parse "-horizontal".
 218         (_initialize_tui_layout): Update help string.
 219         (tui_layout_split::specification): Add "-horizontal" when needed.
 220         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
 221         argument.
 222         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
 223         New methods.
 224
 225 2020-02-22  Tom Tromey  <tom@tromey.com>
 226
 227         * tui/tui-layout.h (enum tui_adjust_result): New.
 228         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
 229         (class tui_layout_window) <adjust_size>: Return
 230         tui_adjust_result.  Rewrite.
 231         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
 232         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
 233
 234 2020-02-22  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
 237         parameter and return types.
 238         (class tui_layout_base) <specification>: Add "depth".
 239         (class tui_layout_window) <specification>: Add "depth".
 240         (class tui_layout_split) <specification>: Add "depth".
 241         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
 242         and return types.
 243         (tui_new_layout_command): Parse sub-layouts.
 244         (_initialize_tui_layout): Update help string.
 245         (tui_layout_window::specification): Add "depth".
 246         (add_layout_command): Update.
 247
 248 2020-02-22  Tom Tromey  <tom@tromey.com>
 249
 250         * NEWS: Add "tui new-layout" item.
 251         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
 252         Add new-layout command to help text.
 253         (validate_window_name): New function.
 254         (tui_new_layout_command): New function.
 255         (_initialize_tui_layout): Register "new-layout".
 256         (tui_layout_window::specification): New method.
 257         (tui_layout_window::specification): New method.
 258         * tui/tui-layout.h (class tui_layout_base) <specification>: New
 259         method.
 260         (class tui_layout_window) <specification>: New method.
 261         (class tui_layout_split) <specification>: New method.
 262
 263 2020-02-22  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
 266         * tui/tui-win.c (window_name_completer): Update comment.
 267         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
 268         Declare method.
 269         (class tui_layout_window) <replace_window>: Likewise.
 270         (class tui_layout_split) <replace_window>: Likewise.
 271         (tui_set_layout): Don't declare.
 272         (tui_set_initial_layout): Declare function.
 273         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
 274         (asm_regs_layout): New globals.
 275         (tui_current_layout, show_layout): Remove.
 276         (tui_set_layout, tui_add_win_to_layout): Rewrite.
 277         (find_layout, tui_apply_layout): New function.
 278         (layout_completer): Remove.
 279         (tui_next_layout): Reimplement.
 280         (tui_next_layout_command): New function.
 281         (tui_set_initial_layout, tui_prev_layout_command): New functions.
 282         (tui_regs_layout): Reimplement.
 283         (tui_regs_layout_command): New function.
 284         (extract_display_start_addr): Rewrite.
 285         (next_layout, prev_layout): Remove.
 286         (tui_layout_window::replace_window): New method.
 287         (tui_layout_split::replace_window): New method.
 288         (destroy_layout): New function.
 289         (layout_list): New global.
 290         (add_layout_command): New function.
 291         (initialize_layouts): Update.
 292         (tui_layout_command): New function.
 293         (_initialize_tui_layout): Install "layout" commands.
 294         * tui/tui-data.h (enum tui_layout_type): Remove.
 295         (tui_current_layout): Don't declare.
 296
 297 2020-02-22  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui-regs.c (tui_reg_layout): Remove.
 300         (tui_reg_command): Use tui_regs_layout.
 301         * tui/tui-layout.h (tui_reg_command): Declare.
 302         * tui/tui-layout.c (tui_reg_command): New function.
 303
 304 2020-02-22  Tom Tromey  <tom@tromey.com>
 305
 306         * tui/tui.c (tui_rl_delete_other_windows): Call
 307         tui_remove_some_windows.
 308         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
 309         Declare method.
 310         (class tui_layout_window) <remove_windows>: New method.
 311         (class tui_layout_split) <remove_windows>: Declare.
 312         (tui_remove_some_windows): Declare.
 313         * tui/tui-layout.c (tui_remove_some_windows): New function.
 314         (tui_layout_split::remove_windows): New method.
 315
 316 2020-02-22  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
 319         * tui/tui-layout.h (tui_next_layout): Declare.
 320         * tui/tui-layout.c (tui_next_layout): New function.
 321
 322 2020-02-22  Tom Tromey  <tom@tromey.com>
 323
 324         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
 325         correct coordinates.
 326
 327 2020-02-22  Tom Tromey  <tom@tromey.com>
 328
 329         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
 330         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
 331         DATA_WIN case.
 332
 333 2020-02-22  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
 336         TUI_DISASM_WIN, not tui_win_list.
 337
 338 2020-02-22  Tom Tromey  <tom@tromey.com>
 339
 340         * valprint.c (generic_val_print_enum_1)
 341         (val_print_type_code_flags): Style member names.
 342         * rust-lang.c (val_print_struct, rust_print_enum)
 343         (rust_print_struct_def, rust_internal_print_type): Style member
 344         names.
 345         * p-valprint.c (pascal_object_print_value_fields): Style member
 346         names.  Only call fprintf_symbol_filtered for static members.
 347         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
 348         * f-valprint.c (f_val_print): Style member names.
 349         * f-typeprint.c (f_type_print_base): Style member names.
 350         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
 351         call fprintf_symbol_filtered for static members.
 352         (cp_print_class_member): Style member names.
 353         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
 354         member names.
 355         * ada-valprint.c (ada_print_scalar): Style enum names.
 356         (ada_val_print_enum): Likewise.
 357         * ada-typeprint.c (print_enum_type): Style enum names.
 358
 359 2020-02-21  Tom Tromey  <tom@tromey.com>
 360
 361         * psympriv.h (struct partial_symtab): Update comment.
 362
 363 2020-02-21  Tom Tromey  <tromey@adacore.com>
 364
 365         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
 366         type is CORE_ADDR.
 367
 368 2020-02-21  Tom de Vries  <tdevries@suse.de>
 369
 370         PR gdb/25534
 371         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
 372         if dependencies[i]->user != NULL.
 373
 374 2020-02-21  Ali Tamur  <tamur@google.com>
 375
 376         * dwarf2/read.c (dwarf2_name): Add null check.
 377
 378 2020-02-20  Tom Tromey  <tom@tromey.com>
 379
 380         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
 381         ">=", in binary search.
 382         (dwarf2_find_containing_comp_unit): New overload.
 383         (run_test): New self-test.
 384         (_initialize_dwarf2_read): Register new test.
 385
 386 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
 387
 388         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
 389         * riscv-tdep.h: Likewise.
 390         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
 391         rv32-only CSR.
 392         * features/riscv/64bit-csr.xml: Regenerated.
 393
 394 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
 395             Tom Tromey  <tom@tromey.com>
 396
 397         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
 398         of 'fputc_unfiltered'.
 399         (putchar_unfiltered): Call 'fputc_unfiltered'.
 400         (fputc_unfiltered): Call 'fputs_unfiltered'.
 401
 402 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
 403
 404         * config.in: Regenerate.
 405         * configure: Regenerate.
 406         * configure.ac: Add --with-python-libdir option.
 407         * main.c: Use WITH_PYTHON_LIBDIR.
 408
 409 2020-02-19  Tom Tromey  <tom@tromey.com>
 410
 411         * symtab.c (general_symbol_info::compute_and_set_names): Use
 412         obstack_strndup.  Simplify call to symbol_set_demangled_name.
 413
 414 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
 415
 416         * dwarf2/read.c (allocate_signatured_type_table,
 417         allocate_dwo_unit_table, allocate_type_unit_groups_table,
 418         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
 419         Remove objfile parameter, update all callers.
 420
 421 2020-02-19  Doug Evans  <dje@google.com>
 422
 423         PR rust/25535
 424         * rust-lang.c (rust_print_enum): Apply embedded_offset to
 425         rust_enum_variant calculation.
 426
 427 2020-02-19  Tom Tromey  <tromey@adacore.com>
 428
 429         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
 430
 431 2020-02-19  Tom Tromey  <tromey@adacore.com>
 432
 433         * ada-lang.c (cache_symbol): Use obstack_strdup.
 434
 435 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 436
 437         * configure: Regenerate.
 438
 439 2020-02-19  Tom Tromey  <tromey@adacore.com>
 440
 441         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
 442         NULL check.
 443
 444 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
 445
 446         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
 447
 448 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 449
 450         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
 451         if GDBSERVER is not defined.
 452         (riscv_tdesc_cache): Likewise, also store const target_desc.
 453         (STATIC_IN_GDB): Define.
 454         (riscv_create_target_description): Update declaration with
 455         STATIC_IN_GDB.
 456         (riscv_lookup_target_description): New function, only define if
 457         GDBSERVER is not defined.
 458         * arch/riscv.h (riscv_create_target_description): Declare only
 459         when GDBSERVER is defined.
 460         (riscv_lookup_target_description): New declaration when GDBSERVER
 461         is not defined.
 462         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
 463         (riscv_linux_read_features): ...this, and return
 464         riscv_gdbarch_features instead of target_desc.
 465         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
 466         (riscv_linux_read_description): Rename to...
 467         (riscv_linux_read_features): ...this.
 468         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
 469         Update to use riscv_gdbarch_features and
 470         riscv_lookup_target_description.
 471         * riscv-tdep.c (riscv_find_default_target_description): Use
 472         riscv_lookup_target_description instead of
 473         riscv_create_target_description.
 474
 475 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 476
 477         * valprint.c (generic_val_print_enum_1): When printing a flag
 478         enum with value 0 and there is no enumerator with value 0, print
 479         just "0" instead of "(unknown: 0x0)".
 480
 481 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 482
 483         * valprint.c (generic_val_print_enum_1): Print unknown part of
 484         flag enum in hex.
 485
 486 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 487
 488         * dwarf2/read.c (update_enumeration_type_from_children): Allow
 489         flag enums to contain duplicate enumerators.
 490         * valprint.c (generic_val_print_enum_1): Update comment.
 491
 492 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 493
 494         * dwarf2/read.c: Include "count-one-bits.h".
 495         (update_enumeration_type_from_children): If an enumerator has
 496         multiple bits set, don't treat the enumeration as a "flag enum".
 497         * valprint.c (generic_val_print_enum_1): Assert that enumerators
 498         of flag enums have 0 or 1 bit set.
 499
 500 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 501
 502         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
 503         conversion.
 504         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
 505         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
 506         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
 507         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
 508         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
 509
 510 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
 511
 512         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
 513
 514 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
 515
 516         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
 517         displaced_step_closure_up.
 518         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
 519         (struct displaced_step_closure_up):
 520         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
 521         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
 522         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
 523         Likewise.
 524         * gdbarch.sh (displaced_step_copy_insn): Likewise.
 525         * gdbarch.c, gdbarch.h: Re-generate.
 526         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
 527         displaced_step_closure_up.
 528         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
 529         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
 530         * infrun.h (displaced_step_closure_up): New type alias.
 531         (struct displaced_step_inferior_state) <step_closure>: Change
 532         type to displaced_step_closure_up.
 533         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
 534         displaced_step_closure_up.
 535         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
 536
 537 2020-02-14  Tom Tromey  <tom@tromey.com>
 538
 539         * minidebug.c (gnu_debug_key): New global.
 540         (find_separate_debug_file_in_section): Use it.
 541
 542 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
 543
 544         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
 545         std::unique_ptr.
 546         * gdbarch.c: Re-generate.
 547         * gdbarch.h: Re-generate.
 548         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
 549         change.
 550         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
 551         type to std::unique_ptr.
 552         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
 553         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
 554         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
 555         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
 556         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
 557         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
 558         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
 559         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
 560         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
 561
 562 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
 563
 564         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
 565         std::unique_ptr.
 566         (displaced_step_clear): Rename to...
 567         (displaced_step_reset): ... this.  Just call displaced->reset ().
 568         (displaced_step_clear_cleanup): Rename to...
 569         (displaced_step_reset_cleanup): ... this.
 570         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
 571         (displaced_step_fixup): Likewise.
 572         (resume_1): Likewise.
 573         (handle_inferior_event): Restore child's memory before calling
 574         displaced_step_fixup on the parent.
 575         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
 576         to std::unique_ptr.
 577         <step_closure>: Change type to std::unique_ptr.
 578
 579 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
 580
 581         * arm-tdep.c: Include count-one-bits.h.
 582         (cleanup_block_store_pc): Use count_one_bits.
 583         (cleanup_block_load_pc): Use count_one_bits.
 584         (arm_copy_block_xfer): Use count_one_bits.
 585         (thumb2_copy_block_xfer): Use count_one_bits.
 586         (thumb_copy_pop_pc_16bit): Use count_one_bits.
 587         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
 588         (thumb_get_next_pcs_raw): Use count_one_bits.
 589         (arm_get_next_pcs_raw): Use count_one_bits_l.
 590         * arch/arm.c (bitcount): Remove.
 591         * arch/arm.h (bitcount): Remove.
 592
 593 2020-02-14  Tom Tromey  <tromey@adacore.com>
 594
 595         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
 596         Update.
 597         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
 598         * dwarf2/loc.c (call_site_find_chain_1): Return
 599         unique_xmalloc_ptr.
 600         (call_site_find_chain): Likewise.
 601
 602 2020-02-14  Richard Biener  <rguenther@suse.de>
 603
 604         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
 605         on expression with division operators.
 606
 607 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 608
 609         * MAINTAINERS (Write After Approval): Adding myself.
 610
 611 2020-02-12  Tom Tromey  <tom@tromey.com>
 612
 613         * event-loop.c (event_data, gdb_event, event_handler_func):
 614         Remove.
 615
 616 2020-02-12  Tom Tromey  <tom@tromey.com>
 617
 618         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
 619         (dwarf2_frame_objfile_data): Add comment.
 620         (find_comp_unit, set_comp_unit): New functions.
 621         (dwarf2_frame_find_fde): Use find_comp_unit.
 622         (dwarf2_build_frame_info): Use set_comp_unit.
 623
 624 2020-02-12  Tom Tromey  <tom@tromey.com>
 625
 626         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
 627         (comp_unit): Don't initialize objfile.
 628         (execute_cfa_program): Add text_offset parameter.
 629         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
 630         (dwarf2_frame_cache): Update.
 631         (dwarf2_build_frame_info): Don't set "objfile" member.
 632
 633 2020-02-12  Tom Tromey  <tom@tromey.com>
 634
 635         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
 636         (decode_frame_entry): Likewise.
 637         (dwarf2_build_frame_info): Update.
 638
 639 2020-02-12  Tom Tromey  <tom@tromey.com>
 640
 641         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
 642         (decode_frame_entry_1): Use the comp_unit obstack.
 643
 644 2020-02-12  Tom Tromey  <tom@tromey.com>
 645
 646         * dwarf2/frame.c (struct comp_unit): Add initializers and
 647         constructor.
 648         (dwarf2_frame_objfile_data): Store a comp_unit.
 649         (dwarf2_frame_find_fde): Update.
 650         (dwarf2_build_frame_info): Use "new".
 651
 652 2020-02-12  Tom Tromey  <tom@tromey.com>
 653
 654         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
 655         (dwarf2_fde_table): Typedef for std::vector.
 656         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
 657         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
 658         (decode_frame_entry): Update.
 659         (dwarf2_build_frame_info): Use "new".
 660
 661 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
 662
 663         * arm-tdep.c (arm_gdbarch_init): Update.
 664         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
 665         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
 666         have_neon, is_m>: Change to bool.
 667
 668 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
 669
 670         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
 671
 672 2020-02-12  Tom Tromey  <tom@tromey.com>
 673
 674         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
 675
 676 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
 677
 678         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
 679         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
 680
 681 2020-02-11  Tom Tromey  <tom@tromey.com>
 682
 683         * psymtab.h: Update comment.
 684
 685 2020-02-11  Tom Tromey  <tom@tromey.com>
 686
 687         * gdb_obstack.h (struct auto_obstack): Use
 688         DISABLE_COPY_AND_ASSIGN.
 689
 690 2020-02-11  Tom Tromey  <tom@tromey.com>
 691
 692         * dwarf2/frame.h (struct objfile): Don't forward declare.
 693
 694 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
 695
 696         * cris-tdep.c (cris_supply_gregset): Change signature to match
 697         what struct regset expects.
 698         (cris_regset): New struct.
 699         (fetch_core_registers): Remove.
 700         (cris_iterate_over_regset_sections): New function.
 701         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
 702         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
 703
 704 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
 705
 706         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
 707         registers.
 708
 709 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
 710
 711         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
 712
 713 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
 714
 715         * configure: Re-generate.
 716
 717 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
 718
 719         * configure: Re-generate.
 720
 721 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
 722
 723         * acinclude: Update warning.m4 path.
 724         * warning.m4: Move to gdbsupport.
 725
 726 2020-02-11  Tom Tromey  <tromey@adacore.com>
 727
 728         * remote.c (remote_console_output): Update.
 729         * printcmd.c (printf_command): Update.
 730         * event-loop.c (gdb_wait_for_event): Update.
 731         * linux-nat.c (sigchld_handler): Update.
 732         * remote-sim.c (gdb_os_write_stdout): Update.
 733         (gdb_os_flush_stdout): Update.
 734         (gdb_os_flush_stderr): Update.
 735         (gdb_os_write_stderr): Update.
 736         * exceptions.c (print_exception): Update.
 737         * remote-fileio.c (remote_fileio_func_read): Update.
 738         (remote_fileio_func_write): Update.
 739         * tui/tui.c (tui_enable): Update.
 740         * tui/tui-interp.c (tui_interp::init): Update.
 741         * utils.c (init_page_info): Update.
 742         (putchar_unfiltered, fputc_unfiltered): Update.
 743         (gdb_flush): Update.
 744         (emit_style_escape): Update.
 745         (flush_wrap_buffer, fputs_maybe_filtered): Update.
 746         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
 747         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
 748         (stderr_file::write): Update.
 749         (stderr_file::puts): Update.
 750         * ui-file.h (ui_file_isatty, ui_file_write)
 751         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
 752         (ui_file_puts): Don't declare.
 753
 754 2020-02-10  Tom de Vries  <tdevries@suse.de>
 755
 756         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
 757         sentinel to char *.
 758
 759 2020-02-09  Tom de Vries  <tdevries@suse.de>
 760
 761         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
 762         filename if it matches "<artificial>".
 763
 764 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
 765
 766         * windows-tdep.c (struct enum_value_name): New struct.
 767         (create_enum): New function.
 768         (windows_get_siginfo_type): Create and use enum types.
 769
 770 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
 771
 772         * NEWS: Mention $_siginfo support for Windows.
 773         * windows-nat.c (handle_exception): Set siginfo_er.
 774         (windows_nat_target::mourn_inferior): Reset siginfo_er.
 775         (windows_xfer_siginfo): New function.
 776         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
 777         * windows-tdep.c (struct windows_gdbarch_data): New struct.
 778         (init_windows_gdbarch_data): New function.
 779         (get_windows_gdbarch_data): New function.
 780         (windows_get_siginfo_type): New function.
 781         (windows_init_abi): Register windows_get_siginfo_type.
 782         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
 783
 784 2020-02-08  Tom Tromey  <tom@tromey.com>
 785
 786         * dwarf2/read.c (class cutu_reader) <cutu_reader,
 787         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
 788         <keep>: Declare method.
 789         <m_keep>: Remove member.
 790         <~cutu_reader>: Remove.
 791         (cutu_reader::init_tu_and_read_dwo_dies): Update.
 792         (cutu_reader::cutu_reader): Update.
 793         (cutu_reader::keep): Rename from ~cutu_reader.
 794         (process_psymtab_comp_unit, build_type_psymtabs_1)
 795         (process_skeletonless_type_unit, load_partial_comp_unit)
 796         (load_full_comp_unit, dwarf2_read_addr_index)
 797         (read_signatured_type): Update.
 798
 799 2020-02-08  Tom Tromey  <tom@tromey.com>
 800
 801         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
 802         "want_partial_unit" parameter.
 803         (process_psymtab_comp_unit): Change want_partial_unit to bool.
 804         Inline check for DW_TAG_partial_unit.
 805         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
 806
 807 2020-02-08  Tom Tromey  <tom@tromey.com>
 808
 809         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
 810         read.c.
 811         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
 812         read.c.
 813
 814 2020-02-08  Tom Tromey  <tom@tromey.com>
 815
 816         * dwarf2/read.c (read_address): Move to comp-unit.c.
 817         (dwarf2_rnglists_process, dwarf2_ranges_process)
 818         (read_attribute_value, dwarf_decode_lines_1)
 819         (var_decode_location, decode_locdesc): Update.
 820         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
 821         read.c.  Remove "cu" parameter.
 822         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
 823         method.
 824
 825 2020-02-08  Tom Tromey  <tom@tromey.com>
 826
 827         * dwarf2/read.c (read_attribute_value, read_indirect_string)
 828         (read_indirect_line_string): Update.
 829         * dwarf2/comp-unit.c (read_offset): Remove.
 830         (read_comp_unit_head): Update.
 831         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
 832         method.
 833         (read_offset): Don't declare.
 834
 835 2020-02-08  Tom Tromey  <tom@tromey.com>
 836
 837         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
 838         * dwarf2/read.c (struct comp_unit_head): Move to
 839         dwarf2/comp-unit.h.
 840         (enum class rcuh_kind): Move to comp-unit.h.
 841         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
 842         (read_comp_unit_head, error_check_comp_unit_head)
 843         (read_and_check_comp_unit_head): Move to comp-unit.c.
 844         (read_offset, dwarf_unit_type_name): Likewise.
 845         (create_debug_type_hash_table, read_cutu_die_from_dwo)
 846         (cutu_reader::cutu_reader, read_call_site_scope)
 847         (find_partial_die, follow_die_offset): Update.
 848         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
 849
 850 2020-02-08  Tom Tromey  <tom@tromey.com>
 851
 852         * dwarf2/read.c (read_offset_1): Move to leb.c.
 853         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
 854         (dwarf_decode_macro_bytes): Update.
 855         * dwarf2/leb.c (read_offset): Rename; move from read.c.
 856         * dwarf2/leb.h (read_offset): Declare.
 857
 858 2020-02-08  Tom Tromey  <tom@tromey.com>
 859
 860         * dwarf2/read.c (dwarf2_section_size): Remove.
 861         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
 862         Update.
 863         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
 864
 865 2020-02-08  Tom Tromey  <tom@tromey.com>
 866
 867         * dwarf2/read.c (read_initial_length): Move to leb.c.
 868         * dwarf2/leb.h (read_initial_length): Declare.
 869         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
 870         handle_nonstd parameter.
 871         * dwarf2/frame.c (read_initial_length): Remove.
 872         (decode_frame_entry_1): Update.
 873
 874 2020-02-08  Tom Tromey  <tom@tromey.com>
 875
 876         * dwarf2/loc.c (dwarf2_find_location_expression)
 877         (dwarf_evaluate_loc_desc::get_tls_address)
 878         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
 879         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
 880         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
 881         (dwarf2_compile_property_to_c)
 882         (dwarf2_loc_desc_get_symbol_read_needs)
 883         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
 884         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
 885         (loclist_describe_location, loclist_tracepoint_var_ref)
 886         (loclist_generate_c_location): Update.
 887         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
 888         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
 889         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
 890         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
 891         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
 892         (dwarf2_per_cu_data::addr_size)
 893         (dwarf2_per_cu_data::ref_addr_size)
 894         (dwarf2_per_cu_data::text_offset)
 895         (dwarf2_per_cu_data::addr_type): Now methods.
 896         (per_cu_header_read_in): Make per_cu "const".
 897         (dwarf2_version): Remove.
 898         (dwarf2_per_cu_data::int_type): Now a method.
 899         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
 900         (set_die_type, read_array_type, read_subrange_index_type)
 901         (read_tag_string_type, read_subrange_type): Update.
 902         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
 903         offset_size, ref_addr_size, text_offset, addr_type, version,
 904         objfile, int_type, addr_sized_int_type>: Declare methods.
 905
 906 2020-02-08  Tom Tromey  <tom@tromey.com>
 907
 908         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
 909         Move earlier.
 910
 911 2020-02-08  Tom Tromey  <tom@tromey.com>
 912
 913         * dwarf2/read.h (dwarf_line_debug): Declare.
 914         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
 915         * dwarf2/read.c: Move line_header code to new files.
 916         (dwarf_line_debug): No longer static.
 917         * dwarf2/line-header.c: New file.
 918         * dwarf2/line-header.h: New file.
 919
 920 2020-02-08  Tom Tromey  <tom@tromey.com>
 921
 922         * dwarf2/read.c (struct line_header) <file_full_name,
 923         file_file_name>: Return unique_xmalloc_ptr.
 924         (line_header::file_file_name): Update.
 925         (line_header::file_full_name): Update.
 926         (dw2_get_file_names_reader): Update.
 927         (macro_start_file): Update.
 928
 929 2020-02-08  Tom Tromey  <tom@tromey.com>
 930
 931         * dwarf2/read.c (struct line_header) <file_full_name,
 932         file_file_name>: Declare methods.
 933         (dw2_get_file_names_reader): Update.
 934         (file_file_name): Now a method.
 935         (file_full_name): Likewise.
 936         (macro_start_file): Update.
 937
 938 2020-02-08  Tom Tromey  <tom@tromey.com>
 939
 940         * dwarf2/read.c (dwarf_always_disassemble)
 941         (show_dwarf_always_disassemble): Move to loc.c.
 942         (_initialize_dwarf2_read): Move "always-disassemble" registration
 943         to loc.c.
 944         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
 945         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
 946         static.
 947         (show_dwarf_always_disassemble): Move from read.c.
 948         (_initialize_dwarf2loc): Move always-disassemble from read.c.
 949
 950 2020-02-08  Tom Tromey  <tom@tromey.com>
 951
 952         * dwarf2/read.c (~dwarf2_per_objfile): Update.
 953         (create_quick_file_names_table): Return htab_up.
 954         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
 955         Update.
 956         * dwarf2/read.h (struct dwarf2_per_objfile)
 957         <quick_file_names_table>: Now htab_up.
 958
 959 2020-02-08  Tom Tromey  <tom@tromey.com>
 960
 961         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
 962
 963 2020-02-08  Tom Tromey  <tom@tromey.com>
 964
 965         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
 966         Rewrite.
 967         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
 968         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
 969         (abbrev_table::abbrev_table): No longer inline.
 970         (ABBREV_HASH_SIZE): Remove.
 971         (abbrev_table::m_abbrevs): Now an htab_up.
 972
 973 2020-02-08  Tom Tromey  <tom@tromey.com>
 974
 975         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
 976         (cutu_reader): Update.
 977         (build_type_psymtabs_1): Update.
 978         * dwarf2/abbrev.c (abbrev_table::read): Rename.
 979         (abbrev_table::alloc_abbrev): Update.
 980         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
 981         (abbrev_table::read): New static method, renamed from
 982         abbrev_table_read_table.
 983         (abbrev_table::alloc_abbrev)
 984         (abbrev_table::add_abbrev): Now private.
 985         (abbrev_table::abbrev_table): Now private.
 986         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
 987
 988 2020-02-08  Tom Tromey  <tom@tromey.com>
 989
 990         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
 991         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
 992         htab_up.
 993
 994 2020-02-08  Tom Tromey  <tom@tromey.com>
 995
 996         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
 997         htab_up.
 998         (lookup_dwo_unit_in_dwp): Update.
 999         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
1000         on obstack.
1001
1002 2020-02-08  Tom Tromey  <tom@tromey.com>
1003
1004         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
1005         obstack.
1006
1007 2020-02-08  Tom Tromey  <tom@tromey.com>
1008
1009         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
1010         line_header_hash.
1011         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
1012         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
1013         Change type to htab_up.
1014
1015 2020-02-08  Tom Tromey  <tom@tromey.com>
1016
1017         * dwarf2/read.c (allocate_type_unit_groups_table): Return
1018         htab_up.  Don't allocate on obstack.
1019         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
1020         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
1021         Change type to htab_up.
1022
1023 2020-02-08  Tom Tromey  <tom@tromey.com>
1024
1025         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
1026         Change type to htab_up.
1027         * dwarf2/read.c (create_signatured_type_table_from_index)
1028         (create_signatured_type_table_from_debug_names)
1029         (create_all_type_units, add_type_unit)
1030         (lookup_dwo_signatured_type, lookup_signatured_type)
1031         (process_skeletonless_type_unit): Update.
1032         (create_debug_type_hash_table, create_debug_types_hash_table):
1033         Change type of types_htab.
1034         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
1035         htab_up.  Don't allocate on obstack.
1036         (create_cus_hash_table): Change type of cus_htab parameter.
1037         (struct dwo_file) <cus, tus>: Now htab_up.
1038         (lookup_dwo_signatured_type, lookup_dwo_cutu)
1039         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
1040         (queue_and_load_all_dwo_tus): Update.
1041         * dwarf2/index-write.c (write_gdbindex): Update.
1042         (write_debug_names): Update.
1043
1044 2020-02-08  Tom Tromey  <tom@tromey.com>
1045
1046         * dwarf2/read.h (struct dwarf2_queue_item): Move from
1047         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
1048         destructor.
1049         (struct dwarf2_per_objfile) <queue>: New member.
1050         * dwarf2/read.c (struct dwarf2_queue_item): Move to
1051         dwarf2/read.h.
1052         (dwarf2_queue, dwarf2_queue_tail): Remove.
1053         (class dwarf2_queue_guard): Add parameter to constructor.  Use
1054         DISABLE_COPY_AND_ASSIGN.
1055         <m_per_objfile>: New member.
1056         <~dwarf2_queue_guard>: Rewrite.
1057         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
1058         Update.
1059         (~dwarf2_queue_item): New.
1060
1061 2020-02-08  Tom Tromey  <tom@tromey.com>
1062
1063         * dwarf2/read.c (struct die_info) <has_children>: New member.
1064         (dw2_get_file_names_reader): Remove has_children.
1065         (dw2_get_file_names): Update.
1066         (read_cutu_die_from_dwo): Remove has_children.
1067         (cutu_reader::init_tu_and_read_dwo_dies)
1068         (cutu_reader::cutu_reader): Update.
1069         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
1070         Remove has_children.
1071         (build_type_psymtabs_1, process_skeletonless_type_unit)
1072         (load_partial_comp_unit, load_full_comp_unit): Update.
1073         (create_dwo_cu_reader): Remove has_children.
1074         (create_cus_hash_table, read_die_and_children): Update.
1075         (read_full_die_1,read_full_die): Remove has_children.
1076         (read_signatured_type): Update.
1077         (class cutu_reader) <has_children>: Remove.
1078
1079 2020-02-08  Tom Tromey  <tom@tromey.com>
1080
1081         * dwarf2/expr.c: Rename from dwarf2expr.c.
1082         * dwarf2/expr.h: Rename from dwarf2expr.h.
1083         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
1084         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
1085         * dwarf2/frame.c: Rename from dwarf2-frame.c.
1086         * dwarf2/frame.h: Rename from dwarf2-frame.h.
1087         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
1088         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
1089         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
1090         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
1091         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
1092         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
1093         * dwarf2/loc.c: Rename from dwarf2loc.c.
1094         * dwarf2/loc.h: Rename from dwarf2loc.h.
1095         * dwarf2/read.c: Rename from dwarf2read.c.
1096         * dwarf2/read.h: Rename from dwarf2read.h.
1097         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
1098         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
1099         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
1100         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
1101         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
1102         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
1103         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
1104         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
1105         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
1106         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
1107         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
1108         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
1109         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
1110         Update.
1111         * Makefile.in (COMMON_SFILES): Update.
1112         (HFILES_NO_SRCDIR): Update.
1113
1114 2020-02-08  Tom Tromey  <tom@tromey.com>
1115
1116         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
1117         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
1118
1119 2020-02-08  Tom Tromey  <tom@tromey.com>
1120
1121         * dwarf2read.h (struct die_info): Don't declare.
1122
1123 2020-02-08  Tom Tromey  <tom@tromey.com>
1124
1125         * dwarf2read.h (die_info_ptr): Remove typedef.
1126
1127 2020-02-08  Tom Tromey  <tom@tromey.com>
1128
1129         * dwarf2read.c (read_call_site_scope)
1130         (handle_data_member_location, dwarf2_add_member_fn)
1131         (mark_common_block_symbol_computed, read_common_block)
1132         (attr_to_dynamic_prop, partial_die_info::read)
1133         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
1134         (dwarf2_symbol_mark_computed, set_die_type): Update.
1135         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
1136         method.
1137         (attr_form_is_block): Don't declare.
1138         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
1139
1140 2020-02-08  Tom Tromey  <tom@tromey.com>
1141
1142         * dwarf2read.c (dwarf2_find_base_address, )
1143         (read_call_site_scope, rust_containing_type)
1144         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
1145         (handle_data_member_location, dwarf2_add_member_fn)
1146         (get_alignment, read_structure_type, process_structure_scope)
1147         (mark_common_block_symbol_computed, read_common_block)
1148         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
1149         (partial_die_info::read, read_attribute_value, new_symbol)
1150         (lookup_die_type, dwarf2_get_ref_die_offset)
1151         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
1152         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
1153         (dwarf2_symbol_mark_computed): Update.
1154         * dwarf2/attribute.h (struct attribute) <value_as_address,
1155         form_is_section_offset, form_is_constant, form_is_ref>: Declare
1156         methods.
1157         (value_as_address, attr_form_is_section_offset)
1158         (attr_form_is_constant, attr_form_is_ref): Don't declare.
1159         * dwarf2/attribute.c (attribute::value_as_address)
1160         (attribute::form_is_section_offset, attribute::form_is_constant)
1161         (attribute::form_is_ref): Now methods.
1162
1163 2020-02-08  Tom Tromey  <tom@tromey.com>
1164
1165         * dwarf2read.c (struct attribute, DW_STRING)
1166         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
1167         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
1168         (attr_form_is_block, attr_form_is_section_offset)
1169         (attr_form_is_constant, attr_form_is_ref): Move.
1170         * dwarf2/attribute.h: New file.
1171         * dwarf2/attribute.c: New file, from dwarf2read.c.
1172         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
1173
1174 2020-02-08  Tom Tromey  <tom@tromey.com>
1175
1176         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
1177         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
1178         Move.
1179         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
1180         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
1181         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
1182         abbrev.c.
1183         * dwarf2/abbrev.h: New file.
1184         * dwarf2/abbrev.c: New file, from dwarf2read.c.
1185         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
1186
1187 2020-02-08  Tom Tromey  <tom@tromey.com>
1188
1189         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
1190         (dwarf2_section_size, dwarf2_get_section_info)
1191         (create_signatured_type_table_from_debug_names)
1192         (create_addrmap_from_aranges, read_debug_names_from_section)
1193         (get_gdb_index_contents_from_section, read_comp_unit_head)
1194         (error_check_comp_unit_head, read_abbrev_offset)
1195         (create_debug_type_hash_table, init_cu_die_reader)
1196         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
1197         (read_comp_units_from_section, create_cus_hash_table)
1198         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
1199         (create_dwp_v2_section, dwarf2_rnglists_process)
1200         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
1201         (abbrev_table_read_table, read_indirect_string_at_offset_from)
1202         (read_indirect_string_from_dwz, read_addr_index_1)
1203         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
1204         (dwarf_decode_macro_bytes, dwarf_decode_macros)
1205         (fill_in_loclist_baton): Update.
1206         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
1207         get_containing_section, get_bfd_owner, get_bfd_section,
1208         get_file_name, get_id, get_flags, empty, read>: Declare methods.
1209         (dwarf2_read_section, get_section_name, get_section_file_name)
1210         (get_containing_section, get_section_bfd_owner)
1211         (get_section_bfd_section, get_section_name, get_section_file_name)
1212         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
1213         declare.
1214         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
1215         (dwarf2_section_info::get_bfd_owner)
1216         (dwarf2_section_info::get_bfd_section)
1217         (dwarf2_section_info::get_name)
1218         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
1219         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
1220         (dwarf2_section_info::read): Now methods.
1221         * dwarf-index-write.c (class debug_names): Update.
1222
1223 2020-02-08  Tom Tromey  <tom@tromey.com>
1224
1225         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
1226         Move to dwarf2/section.h.
1227         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
1228         (get_section_bfd_section, get_section_name)
1229         (get_section_file_name, get_section_id, get_section_flags)
1230         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
1231         dwarf2/section.c.
1232         * dwarf2/section.h: New file.
1233         * dwarf2/section.c: New file, from dwarf2read.c.
1234         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
1235
1236 2020-02-08  Tom Tromey  <tom@tromey.com>
1237
1238         * dwarf2read.h (read_unsigned_leb128): Don't declare.
1239         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
1240         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
1241         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
1242         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
1243         * dwarf2/leb.h: New file, from dwarf2read.c.
1244         * dwarf2/leb.c: New file, from dwarf2read.c.
1245         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
1246         Remove.
1247         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
1248         (COMMON_SFILES): Add dwarf2/leb.c.
1249
1250 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
1251
1252         GDB 9.1 released.
1253
1254 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
1255
1256         PR gdb/25190:
1257         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
1258         * gdb/remote.c (remote_console_output): Update.
1259         * gdb/ui-file.c (fputs_unfiltered): Rename to...
1260         (ui_file_puts): ...this.
1261         * gdb/ui-file.h (ui_file_puts): Add declaration.
1262         * gdb/utils.c (emit_style_escape): Update.
1263         (flush_wrap_buffer): Update.
1264         (fputs_maybe_filtered): Update.
1265         (fputs_unfiltered): Add function.
1266
1267 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
1268
1269         * gdb/event-loop.c (gdb_wait_for_event): Update.
1270         * gdb/printcmd.c (printf_command): Update.
1271         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
1272         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
1273         (gdb_os_flush_stderr): Update.
1274         * gdb/remote.c (remote_console_output): Update.
1275         * gdb/ui-file.c (gdb_flush): Rename to...
1276         (ui_file_flush): ...this.
1277         (stderr_file::write): Update.
1278         (stderr_file::puts): Update.
1279         * gdb/ui-file.h (gdb_flush): Rename to...
1280         (ui_file_flush): ...this.
1281         * gdb/utils.c (gdb_flush): Add function.
1282         * gdb/utils.h (gdb_flush): Add declaration.
1283
1284 2020-02-07  Tom Tromey  <tromey@adacore.com>
1285
1286         PR breakpoints/24915:
1287         * source.c (find_and_open_source): Do not check basenames_may_differ.
1288
1289 2020-02-07  Tom Tromey  <tom@tromey.com>
1290
1291         * README: Update gdbserver documentation.
1292         * gdbserver: Move to top level.
1293         * configure.tgt (build_gdbserver): Remove.
1294         * configure.ac: Remove --enable-gdbserver.
1295         * configure: Rebuild.
1296         * Makefile.in (distclean): Don't mention gdbserver.
1297
1298 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
1299
1300         * source-cache.c (source_cache::ensure): Surround
1301         get_plain_source_lines with a try/catch.
1302         (source_cache::get_line_charpos): Get rid of try/catch
1303         and only check for the return value of "ensure".
1304         * tui/tui-source.c (tui_source_window::set_contents):
1305         Simplify "nlines" calculation.
1306
1307 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
1308
1309         * MAINTAINERS (Write After Approval): Add myself.
1310
1311 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
1312
1313         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
1314         function call.
1315
1316 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
1317
1318         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
1319
1320 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
1321
1322         * nat/riscv-linux-tdesc.h: New file.
1323         * nat/riscv-linux-tdesc.c: New file, taking code from...
1324         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
1325         ... here.
1326         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
1327         NATDEPFILES.
1328
1329 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
1332         we don't set the fake simulator ptid to the null_ptid.
1333
1334 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
1335
1336         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
1337         * gdbthread.h (class thread_info) <resumed>: Likewise.
1338         * infrun.c (resume_1): Likewise.
1339         (proceed): Likewise.
1340         (infrun_thread_stop_requested): Likewise.
1341         (stop_all_threads): Likewise.
1342         (handle_inferior_event): Likewise.
1343         (restart_threads): Likewise.
1344         (finish_step_over): Likewise.
1345         (keep_going_stepped_thread): Likewise.
1346         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
1347         (linux_handle_extended_wait): Likewise.
1348         * record-btrace.c (get_thread_current_frame_id): Likewise.
1349         * record-full.c (record_full_wait_1): Likewise.
1350         * remote.c (remote_target::process_initial_stop_replies): Likewise.
1351         * target.c (target_resume): Likewise.
1352         * thread.c (set_running_thread): Likewise.
1353
1354 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
1355
1356         * f-valprint.c (f77_print_array_1): Changed datatype of index
1357         variable to LONGEST from int to enable it to contain bound
1358         values correctly.
1359
1360 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
1361
1362         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
1363         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
1364         offsets according to FLEN determined.
1365         (riscv_linux_nat_target::read_description): Determine FLEN
1366         dynamically.
1367         (riscv_linux_nat_target::fetch_registers): Size regset buffer
1368         according to FLEN determined.
1369         (riscv_linux_nat_target::store_registers): Likewise.
1370
1371 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
1372
1373         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
1374         when reg->group is empty and reggroup is not.
1375
1376 2020-01-31  Tom Tromey  <tromey@adacore.com>
1377
1378         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
1379         Call beneath target's mourn_inferior after unpushing.
1380
1381 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1382
1383         PR tui/9765
1384         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
1385         have enough lines to fill the screen, still return the lowest
1386         address we found.
1387
1388 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1389
1390         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
1391         '-', '<', and '>' commands.
1392
1393 2020-01-29  Pedro Alves  <palves@redhat.com>
1394             Sergio Durigan Junior  <sergiodj@redhat.com>
1395
1396         * infcmd.c (construct_inferior_arguments): Assert that
1397         'argc' is greater than 0.
1398
1399 2020-01-29  Luis Machado  <luis.machado@linaro.org>
1400
1401         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
1402         (BRK_INSN_MASK): Define to 0xd4200000.
1403         (aarch64_program_breakpoint_here_p): New function.
1404         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
1405         * arch-utils.c (default_program_breakpoint_here_p): Moved from
1406         breakpoint.c.
1407         * arch-utils.h (default_program_breakpoint_here_p): Moved from
1408         breakpoint.h
1409         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
1410         call gdbarch_program_breakpoint_here_p.
1411         (program_breakpoint_here): Moved to arch-utils.c, renamed to
1412         default_program_breakpoint_here_p, changed return type to bool and
1413         simplified.
1414         * breakpoint.h (program_breakpoint_here): Moved prototype to
1415         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
1416         return type to bool.
1417         * gdbarch.c: Regenerate.
1418         * gdbarch.h: Regenerate.
1419         * gdbarch.sh (program_breakpoint_here_p): New method.
1420         * infrun.c (handle_signal_stop): Call
1421         gdbarch_program_breakpoint_here_p.
1422
1423 2020-01-26  Tom Tromey  <tom@tromey.com>
1424
1425         * ctfread.c (struct ctf_fp_info): Reindent.
1426         (_initialize_ctfread): Remove.
1427
1428 2020-01-26  Tom Tromey  <tom@tromey.com>
1429
1430         * psymtab.c (partial_map_expand_apply)
1431         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
1432         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
1433         (psym_print_stats, psym_expand_symtabs_for_function)
1434         (psym_map_symbol_filenames, psym_map_matching_symbols)
1435         (psym_expand_symtabs_matching)
1436         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
1437         (maintenance_check_psymtabs): Use new methods.
1438         * psympriv.h (struct partial_symtab) <readin_p,
1439         get_compunit_symtab>: New methods.
1440         <readin, compunit_symtab>: Remove members.
1441         (struct standard_psymtab): New.
1442         (struct legacy_psymtab): Derive from standard_psymtab.
1443         * dwarf2read.h (struct dwarf2_psymtab): Derive from
1444         standard_psymtab.
1445         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
1446
1447 2020-01-26  Tom Tromey  <tom@tromey.com>
1448
1449         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
1450         read_dependencies.  Add assert.
1451         * psymtab.c (partial_symtab::read_dependencies): New method.
1452         * psympriv.h (struct partial_symtab) <read_dependencies>: New
1453         method.
1454         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
1455         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
1456         read_dependencies.
1457         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
1458         Add assert.
1459
1460 2020-01-26  Tom Tromey  <tom@tromey.com>
1461
1462         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
1463         Call expand_psymtab.
1464         (xcoff_read_symtab): Call expand_psymtab.
1465         (xcoff_start_psymtab, xcoff_end_psymtab): Set
1466         legacy_expand_psymtab.
1467         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
1468         method.
1469         (struct legacy_psymtab) <expand_psymtab>: Implement.
1470         <legacy_expand_psymtab>: New member.
1471         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
1472         (parse_partial_symbols): Set legacy_expand_psymtab.
1473         (psymtab_to_symtab_1): Change argument order.  Call
1474         expand_psymtab.
1475         (new_psymtab): Set legacy_expand_psymtab.
1476         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
1477         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
1478         expand_psymtab.
1479         (dwarf2_psymtab::expand_psymtab): Rename from
1480         psymtab_to_symtab_1.  Call expand_psymtab.
1481         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
1482         (dbx_end_psymtab): Likewise.
1483         (dbx_psymtab_to_symtab_1): Change argument order. Call
1484         expand_psymtab.
1485         (dbx_read_symtab): Call expand_psymtab.
1486         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
1487         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
1488         (ctf_psymtab::read_symtab): Call expand_psymtab.
1489
1490 2020-01-26  Tom Tromey  <tom@tromey.com>
1491
1492         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
1493         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
1494         messages.
1495         * mdebugread.c (mdebug_read_symtab): Remove prints.
1496         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
1497         assert.
1498         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
1499
1500 2020-01-26  Tom Tromey  <tom@tromey.com>
1501
1502         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
1503         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
1504         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
1505         legacy_symtab.
1506         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
1507         * psymtab.c (psymtab_to_symtab): Call method.
1508         (dump_psymtab): Update.
1509         * psympriv.h (struct partial_symtab): Add virtual destructor.
1510         <read_symtab>: New method.
1511         (struct legacy_symtab): New.
1512         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
1513         (struct pst_map) <pst>: Now a legacy_psymtab.
1514         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
1515         (new_psymtab): Use legacy_psymtab.
1516         * dwarf2read.h (struct dwarf2_psymtab): New.
1517         (struct dwarf2_per_cu_data) <psymtab>: Use it.
1518         * dwarf2read.c (dwarf2_create_include_psymtab)
1519         (dwarf2_build_include_psymtabs, create_type_unit_group)
1520         (create_partial_symtab, process_psymtab_comp_unit_reader)
1521         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
1522         (set_partial_user): Use dwarf2_psymtab.
1523         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
1524         (psymtab_to_symtab_1, process_full_comp_unit)
1525         (process_full_type_unit, dwarf2_ranges_read)
1526         (dwarf2_get_pc_bounds, psymtab_include_file_name)
1527         (dwarf_decode_lines): Use dwarf2_psymtab.
1528         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
1529         (add_address_entry_worker, write_one_signatured_type)
1530         (recursively_count_psymbols, recursively_write_psymbols)
1531         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
1532         (write_debug_names): Likewise.
1533         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
1534         <pst>: Now a legacy_psymtab.
1535         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
1536         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
1537         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
1538         * ctfread.c (struct ctf_psymtab): New.
1539         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
1540         ctf_psymtab.
1541         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
1542         (create_partial_symtab): Return a ctf_psymtab.
1543         (scan_partial_symbols): Update.
1544
1545 2020-01-26  Tom Tromey  <tom@tromey.com>
1546
1547         * xcoffread.c (xcoff_start_psymtab): Use new.
1548         * psymtab.c (partial_symtab::partial_symtab): New constructor,
1549         renamed from start_psymtab_common.
1550         * psympriv.h (struct partial_symtab): Add new constructor.
1551         (start_psymtab_common): Don't declare.
1552         * mdebugread.c (parse_partial_symbols): Use new.
1553         * dwarf2read.c (create_partial_symtab): Use new.
1554         * dbxread.c (start_psymtab): Use new.
1555         * ctfread.c (create_partial_symtab): Use new.
1556
1557 2020-01-26  Tom Tromey  <tom@tromey.com>
1558
1559         * xcoffread.c (xcoff_end_psymtab): Use new.
1560         * psymtab.c (start_psymtab_common): Use new.
1561         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
1562         Update.
1563         * psympriv.h (struct partial_symtab): Add parameters to
1564         constructor.  Don't inline.
1565         (allocate_psymtab): Don't declare.
1566         * mdebugread.c (new_psymtab): Use new.
1567         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
1568         * dbxread.c (dbx_end_psymtab): Use new.
1569
1570 2020-01-26  Tom Tromey  <tom@tromey.com>
1571
1572         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
1573         allocate_psymtab.  Update documentation.
1574         * psymtab.c (psymtab_storage::install_psymtab): Rename from
1575         allocate_psymtab.  Do not use new.
1576         (allocate_psymtab): Use new.  Update.
1577
1578 2020-01-26  Tom Tromey  <tom@tromey.com>
1579
1580         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
1581         * psymtab.c (psym_print_stats): Update.
1582         * psympriv.h (struct partial_symtab) <readin,
1583         psymtabs_addrmap_supported, anonymous>: Now bool.
1584         * mdebugread.c (psymtab_to_symtab_1): Update.
1585         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
1586         (build_type_psymtabs_reader, psymtab_to_symtab_1)
1587         (process_full_comp_unit, process_full_type_unit): Update.
1588         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
1589         * ctfread.c (psymtab_to_symtab): Update.
1590
1591 2020-01-26  Tom Tromey  <tom@tromey.com>
1592
1593         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
1594         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
1595         * psymtab.c (psymtab_storage): Delete psymtabs.
1596         (psymtab_storage::allocate_psymtab): Use new.
1597         (psymtab_storage::discard_psymtab): Use delete.
1598         * psympriv.h (struct partial_symtab): Add constructor and
1599         initializers.
1600
1601 2020-01-26  Tom Tromey  <tom@tromey.com>
1602
1603         * machoread.c: Do not include psympriv.h.
1604
1605 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1606
1607         * NEWS: Mention the new option and the set/show commands.
1608
1609 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1610
1611         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
1612         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
1613         (validate_exec_file): New variables, enums, functions.
1614         (exec_file_locate_attach, print_section_info): Style the filenames.
1615         (_initialize_exec): Install show_exec_file_mismatch_command and
1616          set_exec_file_mismatch_command.
1617         * gdbcore.h (validate_exec_file): Declare.
1618         * infcmd.c (attach_command): Call validate_exec_file.
1619         * remote.c ( remote_target::remote_add_inferior): Likewise.
1620
1621 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1622
1623         * frame.c (find_frame_sal): Move call to get_next_frame into more
1624         inner scope.
1625         * inline-frame.c (inilne_state) <inline_state>: Update argument
1626         types.
1627         (inilne_state) <skipped_symbol>: Rename to...
1628         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
1629         (skip_inline_frames): Build vector of skipped symbols and use this
1630         to reate the inline_state.
1631         (inline_skipped_symbol): Add a comment and some assertions, fetch
1632         skipped symbol from the list.
1633
1634 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1635
1636         * buildsym.c (lte_is_less_than): Delete.
1637         (buildsym_compunit::end_symtab_with_blockvector): Create local
1638         lambda function to sort line table entries, and use
1639         std::stable_sort instead of std::sort.
1640         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
1641         markers when looking for a previous line.
1642
1643 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1644
1645         * dwarf2read.c (lnp_state_machine::record_line): Include
1646         end_sequence parameter in debug print out.  Record the line if we
1647         are at an end_sequence marker even if it's not the start of a
1648         statement.
1649         * symmisc.c (maintenance_print_one_line_table): Print end of
1650         sequence markers with 'END' not '0'.
1651
1652 2020-01-24  Pedro Alves  <palves@redhat.com>
1653
1654         PR gdb/25410
1655         * thread.c (scoped_restore_current_thread::restore): Use
1656         switch_to_inferior_no_thread.
1657         * exec.c: Include "progspace-and-thread.h".
1658         (add_target_sections, remove_target_sections):
1659         scoped_restore_current_pspace_and_thread instead of
1660         scoped_restore_current_thread.
1661         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
1662         and aspace to the inferior before calling clone_program_space.
1663         Remove stale comment.
1664
1665 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
1666
1667         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
1668         (arm_netbsd_nat_target::fetch_registers): ...this.
1669         (arm_nbsd_nat_target::store_registers): Rename to...
1670         (arm_netbsd_nat_target::store_registers): ...this.
1671
1672 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
1673
1674         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
1675         register_t.
1676
1677 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
1678
1679         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
1680         Update comment.
1681         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
1682         Likewise.
1683         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
1684         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
1685         the correct replacement (iterate_over_regset_sections).
1686         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
1687         Update comment.
1688
1689 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
1690
1691         PR gdb/23718
1692         * gdb/python/python.c (execute_gdb_command): Call
1693         async_enable_stdin in catch block.
1694
1695 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1696
1697         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
1698         SWITCH_THRU_ALL_UIS.
1699
1700 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1701
1702         PR tui/9765
1703         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
1704         comment, add extra parameter, and update to store previous symbol
1705         when appropriate.
1706         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
1707         add extra parameter.
1708         * tui/tui-disasm.c (tui_disassemble): Update header comment,
1709         remove unneeded parameter, add try/catch around gdb_print_insn,
1710         rewrite to add items to asm_lines vector.
1711         (tui_find_backward_disassembly_start_address): New function.
1712         (tui_find_disassembly_address): Updated throughout.
1713         (tui_disasm_window::set_contents): Update for changes to
1714         tui_disassemble.
1715         (tui_disasm_window::do_scroll_vertical): No need to adjust the
1716         number of lines to scroll.
1717
1718 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
1719
1720         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
1721         (SECT_OFF_DATA): Likewise.
1722         (SECT_OFF_RODATA): Likewise.
1723         (SECT_OFF_TEXT): Likewise.
1724         (SECT_OFF_BSS): Likewise.
1725         (struct objfile) <text_section_offset, data_section_offset>: New
1726         methods.
1727         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
1728         objfile::text_section_offset.
1729         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
1730         * coffread.c (coff_symtab_read): Likewise.
1731         (enter_linenos): Likewise.
1732         (process_coff_symbol): Likewise.
1733         * ctfread.c (get_objfile_text_range): Likewise.
1734         * dtrace-probe.c (dtrace_probe::get_relocated_address):
1735         Use objfile::data_section_offset.
1736         * dwarf2-frame.c (execute_cfa_program): Use
1737         objfile::text_section_offset.
1738         (dwarf2_frame_find_fde): Likewise.
1739         * dwarf2read.c (create_addrmap_from_index): Likewise.
1740         (create_addrmap_from_aranges): Likewise.
1741         (dw2_find_pc_sect_compunit_symtab): Likewise.
1742         (process_psymtab_comp_unit_reader): Likewise.
1743         (add_partial_symbol): Likewise.
1744         (add_partial_subprogram): Likewise.
1745         (process_full_comp_unit): Likewise.
1746         (read_file_scope): Likewise.
1747         (read_func_scope): Likewise.
1748         (read_lexical_block_scope): Likewise.
1749         (read_call_site_scope): Likewise.
1750         (dwarf2_rnglists_process): Likewise.
1751         (dwarf2_ranges_process): Likewise.
1752         (dwarf2_ranges_read): Likewise.
1753         (dwarf_decode_lines_1): Likewise.
1754         (new_symbol): Likewise.
1755         (dwarf2_fetch_die_loc_sect_off): Likewise.
1756         (dwarf2_per_cu_text_offset): Likewise.
1757         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
1758         * hppa-tdep.c (read_unwind_info): Likewise.
1759         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
1760         * psympriv.h (struct partial_symtab): Likewise.
1761         * psymtab.c (find_pc_sect_psymtab): Likewise.
1762         * solib-svr4.c (enable_break): Likewise.
1763         * stap-probe.c (relocate_address): Use
1764         objfile::data_section_offset.
1765         * xcoffread.c (enter_line_range): Use
1766         objfile::text_section_offset.
1767         (read_xcoff_symtab): Likewise.
1768
1769 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
1770
1771         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
1772         declaration to narrower scopes.
1773
1774 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
1775
1776         * darwin-nat.h (struct darwin_exception_msg, enum
1777         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
1778         Move up.
1779         (class darwin_nat_target) <wait_1, check_new_threads,
1780         decode_exception_message, decode_message, stop_inferior,
1781         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
1782         * darwin-nat.c (darwin_check_new_threads): Rename to...
1783         (darwin_nat_target::check_new_threads): ... this.
1784         (darwin_suspend_inferior_it): Remove.
1785         (darwin_decode_exception_message): Rename to...
1786         (darwin_nat_target::decode_exception_message): ... this.
1787         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
1788         (darwin_decode_message): Rename to...
1789         (darwin_nat_target::decode_message): ... this.
1790         (cancel_breakpoint): Rename to...
1791         (darwin_nat_target::cancel_breakpoint): ... this.
1792         (darwin_wait): Rename to...
1793         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
1794         instead of iterate_over_inferiors.
1795         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
1796         (darwin_stop_inferior): Rename to...
1797         (darwin_nat_target::stop_inferior): ... this.
1798         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
1799         (darwin_init_thread_list): Rename to...
1800         (darwin_nat_target::init_thread_list): ... this.
1801         (darwin_ptrace_him): Rename to...
1802         (darwin_nat_target::ptrace_him): ... this.
1803         (darwin_nat_target::create_inferior): Pass lambda function to
1804         fork_inferior.
1805         (darwin_nat_target::detach): Call stop_inferior instead of
1806         darwin_stop_inferior.
1807         * fork-inferior.h (fork_inferior): Change init_trace_fun
1808         parameter to gdb::function_view.
1809         * fork-inferior.c (fork_inferior): Likewise.
1810
1811 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
1812
1813         * i386-cygwin-tdep.c (core_process_module_section): Update.
1814         * windows-nat.c (struct lm_info_windows): Add text_offset.
1815         (windows_xfer_shared_libraries): Update.
1816         * windows-tdep.c (windows_xfer_shared_library):
1817         Add text_offset_cached argument.
1818         * windows-tdep.h (windows_xfer_shared_library): Update.
1819
1820 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
1821
1822         * gdbarch.sh: Add declaration for _initialize_gdbarch.
1823
1824 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
1825
1826         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
1827         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
1828         replace with range-based for.
1829         (gdbsim_interrupt_inferior): Remove.
1830         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
1831         with a range-based for.  Inline code from
1832         gdbsim_interrupt_inferior.
1833
1834 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
1835
1836         * infrun.c (proceed): Fix indentation.
1837
1838 2020-01-21  Tom Tromey  <tromey@adacore.com>
1839
1840         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
1841         * python/python.c (python_extension_ops): Update.
1842         (gdbpy_colorize): New function.
1843         * python/lib/gdb/__init__.py (colorize): New function.
1844         * extension.h (ext_lang_colorize): Declare.
1845         * extension.c (ext_lang_colorize): New function.
1846         * extension-priv.h (struct extension_language_ops) <colorize>: New
1847         member.
1848         * cli/cli-style.c (_initialize_cli_style): Update help text.
1849
1850 2020-01-21  Luis Machado  <luis.machado@linaro.org>
1851
1852         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
1853         <cond>: Change type to bool.
1854         (aarch64_displaced_step_b_cond): Update cond to use bool type.
1855         (aarch64_displaced_step_cb): Likewise.
1856         (aarch64_displaced_step_tb): Likewise.
1857
1858 2020-01-21  Luis Machado  <luis.machado@linaro.org>
1859
1860         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
1861         output.
1862
1863 2020-01-21  Luis Machado  <luis.machado@linaro.org>
1864
1865         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
1866         <pc_adjust>: Adjust the documentation.
1867         (aarch64_displaced_step_fixup): Check if PC really moved before
1868         adjusting it.
1869
1870 2020-01-19  Tom Tromey  <tom@tromey.com>
1871
1872         * disasm.c (~gdb_disassembler): New destructor.
1873         (gdb_buffered_insn_length): Call disassemble_free_target.
1874         * disasm.h (class gdb_disassembler): Declare destructor.  Use
1875         DISABLE_COPY_AND_ASSIGN.
1876
1877 2020-01-19  Tom Tromey  <tom@tromey.com>
1878
1879         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
1880         (die_reader_func_ftype): Remove.
1881         (cutu_reader): New class.
1882         (dw2_get_file_names_reader): Remove "data" parameter.
1883         (dw2_get_file_names): Use cutu_reader.
1884         (create_debug_type_hash_table): Update.
1885         (read_cutu_die_from_dwo): Update comment.
1886         (lookup_dwo_unit): Add dwo_name parameter.
1887         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
1888         die_reader_func_ftype and data parameters.
1889         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
1890         Remove die_reader_func_ftype and data parameters.
1891         (~cutu_reader): New; from init_cutu_and_read_dies.
1892         (cutu_reader::cutu_reader): Rename from
1893         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
1894         and data parameters.
1895         (init_cutu_and_read_dies_simple): Remove.
1896         (struct process_psymtab_comp_unit_data): Remove.
1897         (process_psymtab_comp_unit_reader): Remove data parameter; add
1898         want_partial_unit and pretend_language parameters.
1899         (process_psymtab_comp_unit): Use cutu_reader.
1900         (build_type_psymtabs_reader): Remove data parameter.
1901         (build_type_psymtabs_1): Use cutu_reader.
1902         (process_skeletonless_type_unit): Likewise.
1903         (load_partial_comp_unit_reader): Remove.
1904         (load_partial_comp_unit): Use cutu_reader.
1905         (load_full_comp_unit_reader): Remove.
1906         (load_full_comp_unit): Use cutu_reader.
1907         (struct create_dwo_cu_data): Remove.
1908         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
1909         dwo_unit parameters.
1910         (create_cus_hash_table): Use cutu_reader.
1911         (struct dwarf2_read_addr_index_data): Remove.
1912         (dwarf2_read_addr_index_reader): Remove.
1913         (dwarf2_read_addr_index): Use cutu_reader.
1914         (read_signatured_type_reader): Remove.
1915         (read_signatured_type): Use cutu_reader.
1916
1917 2020-01-19  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
1920         * tui/tui-wingeneral.h (class tui_suppress_output): New.
1921         (tui_wrefresh): Declare.
1922         * tui/tui-wingeneral.c (suppress_output): New global.
1923         (tui_suppress_output, ~tui_suppress_output): New constructor and
1924         destructor.
1925         (tui_wrefresh): New function.
1926         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
1927         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
1928         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
1929         method.
1930         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
1931         tui_wrefresh.
1932         (tui_data_window::no_refresh): New method.
1933         (tui_data_item_window::refresh_window): Call tui_wrefresh.
1934         (tui_reg_command): Use tui_suppress_output
1935         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
1936         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
1937         method.
1938         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
1939
1940 2020-01-19  Tom Tromey  <tom@tromey.com>
1941
1942         * tui/tui-winsource.c (tui_update_source_windows_with_line):
1943         Handle case where symtab is null.
1944
1945 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
1946
1947         * linux-fork.c (one_fork_p): Simplify.
1948
1949 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
1950
1951         * top.c (struct qt_args): Remove.
1952         (kill_or_detach): Change return type to void, replace `void *`
1953         parameter with a proper one.
1954         (print_inferior_quit_action):  Likewise.
1955         (quit_confirm): Use range-based for loop to iterate over inferiors.
1956         (quit_force): Likewise.
1957
1958 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
1959
1960         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
1961         `void *` parameter with proper parameters.
1962         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
1963         (print_one_inferior): Change return type to void, replace `void *`
1964         parameter with proper parameters.
1965         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
1966         inferiors.
1967         (get_other_inferior): Remove.
1968         (mi_cmd_remove_inferior): Use range-based loop to iterate over
1969         inferiors.
1970
1971 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
1972
1973         * mi/mi-interp.c (report_initial_inferior): Remove.
1974         (mi_interp::init): Use range-based for to iterate over inferiors.
1975
1976 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
1977
1978         * python/py-inferior.c (build_inferior_list): Remove.
1979         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
1980
1981 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
1982
1983         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
1984         (btrace_stitch_trace): Likewise.
1985         * charset.c (intermediate_encoding): Likewise (vaild).
1986         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
1987         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
1988         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
1989
1990 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
1991
1992         * windows-tdep.c (windows_get_tlb_type):
1993         Add rtl_user_process_parameters type.
1994
1995 2020-01-16  Pedro Alves  <palves@redhat.com>
1996             Norbert Lange  <nolange79@gmail.com>
1997
1998         PR build/24805
1999         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
2000         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
2001         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
2002         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
2003         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
2004         (ps_plog): Redeclare exported functions with default visibility.
2005
2006 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
2007
2008         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
2009         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
2010
2011 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
2012
2013         * infcmd.c (post_create_inferior): Use get_thread_regcache
2014         instead of get_current_regcache.
2015
2016 2020-01-14  Tom Tromey  <tom@tromey.com>
2017
2018         PR symtab/12535:
2019         * python/python.c (gdbpy_decode_line): Treat empty string the same
2020         as no argument.
2021
2022 2020-01-14  Tom Tromey  <tom@tromey.com>
2023
2024         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
2025
2026 2020-01-14  Tom Tromey  <tom@tromey.com>
2027
2028         * nat/linux-btrace.c: Don't include <config.h>.
2029         * nat/linux-ptrace.c: Don't include <config.h>.
2030         * nat/x86-linux-dregs.c: Don't include <config.h>.
2031
2032 2020-01-14  Tom Tromey  <tom@tromey.com>
2033
2034         * configure: Rebuild.
2035         * configure.ac: Move many checks to ../gdbsupport/common.m4.
2036
2037 2020-01-14  Tom Tromey  <tom@tromey.com>
2038
2039         * nat/x86-linux-dregs.c: Include configh.h.
2040         * nat/linux-ptrace.c: Include configh.h.
2041         * nat/linux-btrace.c: Include configh.h.
2042         * defs.h: Include config.h, bfd.h.
2043         * configure.ac: Don't source common.host.
2044         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
2045         * configure: Rebuild.
2046         * acinclude.m4: Update path.
2047         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
2048         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
2049         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
2050         (CLIBS): Add LIBSUPPORT.
2051         (CDEPS): Likewise.
2052         (COMMON_SFILES): Remove gdbsupport files.
2053         (HFILES_NO_SRCDIR): Likewise.
2054         (stamp-version): Update path to create-version.sh.
2055         (ALLDEPFILES): Remove gdbsupport files.
2056
2057 2020-01-14  Tom Tromey  <tom@tromey.com>
2058
2059         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
2060         USE_WIN32API when needed.
2061         * configure.ac (USE_WIN32API): Don't define.
2062         (WIN32LIBS): Use WIN32APILIBS.
2063         * configure: Rebuild.
2064
2065 2020-01-14  Tom Tromey  <tom@tromey.com>
2066
2067         * configure: Rebuild.
2068         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
2069
2070 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2071
2072         * skip.c (skip_function_command): Make skip w/o arguments use the
2073         name of the inlined function if pc is inside any inlined function.
2074
2075 2020-01-14  Luis Machado  <luis.machado@linaro.org>
2076
2077         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
2078         * infrun.c (resume_1): Likewise.
2079         (handle_inferior_event): Remove stale comment.
2080         * linux-nat.c (linux_nat_target::resume): Update comments.
2081         (save_stop_reason): Likewise.
2082         (linux_nat_filter_event): Likewise.
2083         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
2084
2085 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2086
2087         * elfread.c (record_minimal_symbol): Set section index to 0 for
2088         non-allocatable sections.
2089
2090
2091 2020-01-13  Ali Tamur <tamur@google.com>
2092
2093         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
2094         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
2095         to gdb::optional.  Update comments.
2096         (dwo_file): Update comments.
2097         (read_attribute): Update API to take an additional out parameter,
2098         need_reprocess.  This is used to mark attributes that need other
2099         attributes (e.g. str_offsets_base) for correct computation which may not
2100         have been read yet.
2101         (read_attribute_reprocess): New function declaration.
2102         (read_addr_index): Likewise.
2103         (read_dwo_str_index): Likewise.
2104         (read_stub_str_index): Likewise.
2105         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
2106         (lookup_addr_base): New function definition.
2107         (lookup_ranges_base): Likewise.
2108         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
2109         lookup_ranges_base.
2110         (init_cutu_and_read_dies): Update comments.
2111         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
2112         unit.  This is used to inherit parent's str_offsets_base and addr_base.
2113         Update comments.
2114         (init_cutu_and_read_dies_simple): Reflect API changes.
2115         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
2116         (create_cus_hash_table): Change API to take parent compile unit.
2117         Reflect API changes.
2118         (open_and_init_dwo_file): Reflect API changes.
2119         (dwarf2_get_pc_bounds): Update comments.
2120         (dwarf2_record_block_ranges): Likewise.
2121         (read_full_die_1): Change implementation to reprocess attributes that
2122         need str_offsets_base and addr_base.
2123         (partial_die_info::read): Likewise.
2124         (read_attribute_reprocess): New function definition.
2125         (read_attribute_value): Change API to take an additional out parameter,
2126         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
2127         when a non-dwo compile unit has index based attributes.
2128         (read_attribute): Reflect API changes.
2129         (read_addr_index_1): Reflect API changes.  Update comments.
2130         (dwarf2_read_addr_index_data): Reflect API changes.
2131         (dwarf2_read_addr_index): Likewise.
2132         (read_str_index): Change API and implementation.  This becomes a helper
2133         to be used by the new string index related methods.  Update error
2134         message and comments.
2135         (read_dwo_str_index): New function definition.
2136         (read_stub_str_index): Likewise.
2137         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
2138         * symfile.h (dwarf2_debug_sections): Likewise.
2139         * xcoffread.c (dwarf2_debug_sections): Likewise.
2140
2141 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2142
2143         * gdbcore.h (struct core_fns) <core_read_registers>: Change
2144         core_reg_sect type to gdb_byte *.
2145         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
2146         * cris-tdep.c (fetch_core_registers): Likewise.
2147         * corelow.c (core_target::get_core_register_section): Change
2148         type of `contents` to gdb::byte_vector.
2149
2150 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2151
2152         * tui/tui-wingeneral.c (box_win): Position the title in the center
2153         of the border.
2154
2155 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
2156
2157         * corelow.c (core_target::get_core_register_section): Use
2158           std::vector instead of alloca.
2159
2160 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2161
2162         * warning.m4: Add -Wmissing-declarations to build_warnings.
2163         * configure: Re-generate.
2164
2165 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2166
2167         * python/python.c (init__gdb_module): Add declaration.
2168
2169 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
2170
2171         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
2172         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
2173         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
2174         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
2175         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
2176         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
2177         * ada-exp.y (_initialize_ada_exp): Add declaration.
2178         * ada-lang.c (_initialize_ada_language): Add declaration.
2179         * ada-tasks.c (_initialize_tasks): Add declaration.
2180         * agent.c (_initialize_agent): Add declaration.
2181         * aix-thread.c (_initialize_aix_thread): Add declaration.
2182         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
2183         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
2184         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
2185         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
2186         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
2187         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
2188         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
2189         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
2190         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
2191         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
2192         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
2193         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
2194         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
2195         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
2196         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
2197         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
2198         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
2199         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
2200         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
2201         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
2202         * annotate.c (_initialize_annotate): Add declaration.
2203         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
2204         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
2205         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
2206         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
2207         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
2208         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
2209         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
2210         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
2211         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
2212         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
2213         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
2214         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
2215         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
2216         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
2217         * auto-load.c (_initialize_auto_load): Add declaration.
2218         * auxv.c (_initialize_auxv): Add declaration.
2219         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
2220         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
2221         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
2222         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
2223         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
2224         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
2225         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
2226         * breakpoint.c (_initialize_breakpoint): Add declaration.
2227         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
2228         * btrace.c (_initialize_btrace): Add declaration.
2229         * charset.c (_initialize_charset): Add declaration.
2230         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
2231         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
2232         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
2233         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
2234         * cli/cli-script.c (_initialize_cli_script): Add declaration.
2235         * cli/cli-style.c (_initialize_cli_style): Add declaration.
2236         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
2237         * coffread.c (_initialize_coffread): Add declaration.
2238         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
2239         * compile/compile.c (_initialize_compile): Add declaration.
2240         * complaints.c (_initialize_complaints): Add declaration.
2241         * completer.c (_initialize_completer): Add declaration.
2242         * copying.c (_initialize_copying): Add declaration.
2243         * corefile.c (_initialize_core): Add declaration.
2244         * corelow.c (_initialize_corelow): Add declaration.
2245         * cp-abi.c (_initialize_cp_abi): Add declaration.
2246         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
2247         * cp-support.c (_initialize_cp_support): Add declaration.
2248         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
2249         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
2250         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
2251         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
2252         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
2253         * ctfread.c (_initialize_ctfread): Add declaration.
2254         * d-lang.c (_initialize_d_language): Add declaration.
2255         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
2256         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
2257         * dbxread.c (_initialize_dbxread): Add declaration.
2258         * dcache.c (_initialize_dcache): Add declaration.
2259         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
2260         * disasm.c (_initialize_disasm): Add declaration.
2261         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
2262         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
2263         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
2264         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
2265         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
2266         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
2267         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
2268         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
2269         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
2270         * elfread.c (_initialize_elfread): Add declaration.
2271         * exec.c (_initialize_exec): Add declaration.
2272         * extension.c (_initialize_extension): Add declaration.
2273         * f-lang.c (_initialize_f_language): Add declaration.
2274         * f-valprint.c (_initialize_f_valprint): Add declaration.
2275         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
2276         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
2277         * filesystem.c (_initialize_filesystem): Add declaration.
2278         * findcmd.c (_initialize_mem_search): Add declaration.
2279         * findvar.c (_initialize_findvar): Add declaration.
2280         * fork-child.c (_initialize_fork_child): Add declaration.
2281         * frame-base.c (_initialize_frame_base): Add declaration.
2282         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
2283         * frame.c (_initialize_frame): Add declaration.
2284         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
2285         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
2286         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
2287         * gcore.c (_initialize_gcore): Add declaration.
2288         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
2289         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
2290         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
2291         * gdbarch.c (_initialize_gdbarch): Add declaration.
2292         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
2293         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
2294         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
2295         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
2296         * go-lang.c (_initialize_go_language): Add declaration.
2297         * go32-nat.c (_initialize_go32_nat): Add declaration.
2298         * guile/guile.c (_initialize_guile): Add declaration.
2299         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
2300         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
2301         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
2302         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
2303         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
2304         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
2305         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
2306         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
2307         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
2308         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
2309         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
2310         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
2311         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
2312         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
2313         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
2314         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
2315         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
2316         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
2317         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
2318         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
2319         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
2320         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
2321         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
2322         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
2323         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
2324         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
2325         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
2326         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
2327         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
2328         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
2329         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
2330         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
2331         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
2332         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
2333         * infcall.c (_initialize_infcall): Add declaration.
2334         * infcmd.c (_initialize_infcmd): Add declaration.
2335         * inflow.c (_initialize_inflow): Add declaration.
2336         * infrun.c (_initialize_infrun): Add declaration.
2337         * interps.c (_initialize_interpreter): Add declaration.
2338         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
2339         * jit.c (_initialize_jit): Add declaration.
2340         * language.c (_initialize_language): Add declaration.
2341         * linux-fork.c (_initialize_linux_fork): Add declaration.
2342         * linux-nat.c (_initialize_linux_nat): Add declaration.
2343         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
2344         * linux-thread-db.c (_initialize_thread_db): Add declaration.
2345         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
2346         * m2-lang.c (_initialize_m2_language): Add declaration.
2347         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
2348         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
2349         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
2350         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
2351         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
2352         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
2353         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
2354         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
2355         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
2356         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
2357         * machoread.c (_initialize_machoread): Add declaration.
2358         * macrocmd.c (_initialize_macrocmd): Add declaration.
2359         * macroscope.c (_initialize_macroscope): Add declaration.
2360         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
2361         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
2362         * maint.c (_initialize_maint_cmds): Add declaration.
2363         * mdebugread.c (_initialize_mdebugread): Add declaration.
2364         * memattr.c (_initialize_mem): Add declaration.
2365         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
2366         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
2367         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
2368         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
2369         * mi/mi-main.c (_initialize_mi_main): Add declaration.
2370         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
2371         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
2372         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
2373         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
2374         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
2375         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
2376         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
2377         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
2378         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
2379         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
2380         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
2381         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
2382         * mipsread.c (_initialize_mipsread): Add declaration.
2383         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
2384         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
2385         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
2386         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
2387         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
2388         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
2389         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
2390         * nto-procfs.c (_initialize_procfs): Add declaration.
2391         * objc-lang.c (_initialize_objc_language): Add declaration.
2392         * observable.c (_initialize_observer): Add declaration.
2393         * opencl-lang.c (_initialize_opencl_language): Add declaration.
2394         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
2395         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
2396         * osabi.c (_initialize_gdb_osabi): Add declaration.
2397         * osdata.c (_initialize_osdata): Add declaration.
2398         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
2399         * parse.c (_initialize_parse): Add declaration.
2400         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
2401         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
2402         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
2403         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
2404         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
2405         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
2406         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
2407         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
2408         * printcmd.c (_initialize_printcmd): Add declaration.
2409         * probe.c (_initialize_probe): Add declaration.
2410         * proc-api.c (_initialize_proc_api): Add declaration.
2411         * proc-events.c (_initialize_proc_events): Add declaration.
2412         * proc-service.c (_initialize_proc_service): Add declaration.
2413         * procfs.c (_initialize_procfs): Add declaration.
2414         * producer.c (_initialize_producer): Add declaration.
2415         * psymtab.c (_initialize_psymtab): Add declaration.
2416         * python/python.c (_initialize_python): Add declaration.
2417         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
2418         * record-btrace.c (_initialize_record_btrace): Add declaration.
2419         * record-full.c (_initialize_record_full): Add declaration.
2420         * record.c (_initialize_record): Add declaration.
2421         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
2422         * regcache.c (_initialize_regcache): Add declaration.
2423         * reggroups.c (_initialize_reggroup): Add declaration.
2424         * remote-notif.c (_initialize_notif): Add declaration.
2425         * remote-sim.c (_initialize_remote_sim): Add declaration.
2426         * remote.c (_initialize_remote): Add declaration.
2427         * reverse.c (_initialize_reverse): Add declaration.
2428         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
2429         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
2430         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
2431         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
2432         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
2433         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
2434         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
2435         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
2436         Add declaration.
2437         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
2438         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
2439         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
2440         * rust-exp.y (_initialize_rust_exp): Add declaration.
2441         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
2442         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
2443         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
2444         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
2445         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
2446         * score-tdep.c (_initialize_score_tdep): Add declaration.
2447         * ser-go32.c (_initialize_ser_dos): Add declaration.
2448         * ser-mingw.c (_initialize_ser_windows): Add declaration.
2449         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
2450         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
2451         * ser-uds.c (_initialize_ser_socket): Add declaration.
2452         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
2453         * serial.c (_initialize_serial): Add declaration.
2454         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
2455         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
2456         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
2457         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
2458         * skip.c (_initialize_step_skip): Add declaration.
2459         * sol-thread.c (_initialize_sol_thread): Add declaration.
2460         * solib-aix.c (_initialize_solib_aix): Add declaration.
2461         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
2462         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
2463         * solib-frv.c (_initialize_frv_solib): Add declaration.
2464         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
2465         * solib-target.c (_initialize_solib_target): Add declaration.
2466         * solib.c (_initialize_solib): Add declaration.
2467         * source-cache.c (_initialize_source_cache): Add declaration.
2468         * source.c (_initialize_source): Add declaration.
2469         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
2470         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
2471         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
2472         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
2473         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
2474         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
2475         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
2476         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
2477         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
2478         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
2479         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
2480         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
2481         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
2482         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
2483         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
2484         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
2485         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
2486         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
2487         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
2488         * stabsread.c (_initialize_stabsread): Add declaration.
2489         * stack.c (_initialize_stack): Add declaration.
2490         * stap-probe.c (_initialize_stap_probe): Add declaration.
2491         * std-regs.c (_initialize_frame_reg): Add declaration.
2492         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
2493         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
2494         * symfile.c (_initialize_symfile): Add declaration.
2495         * symmisc.c (_initialize_symmisc): Add declaration.
2496         * symtab.c (_initialize_symtab): Add declaration.
2497         * target.c (_initialize_target): Add declaration.
2498         * target-connection.c (_initialize_target_connection): Add
2499         declaration.
2500         * target-dcache.c (_initialize_target_dcache): Add declaration.
2501         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
2502         * thread.c (_initialize_thread): Add declaration.
2503         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
2504         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
2505         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
2506         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
2507         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
2508         * tracectf.c (_initialize_ctf): Add declaration.
2509         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
2510         * tracefile.c (_initialize_tracefile): Add declaration.
2511         * tracepoint.c (_initialize_tracepoint): Add declaration.
2512         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
2513         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
2514         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
2515         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
2516         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
2517         * tui/tui-win.c (_initialize_tui_win): Add declaration.
2518         * tui/tui.c (_initialize_tui): Add declaration.
2519         * typeprint.c (_initialize_typeprint): Add declaration.
2520         * ui-style.c (_initialize_ui_style): Add declaration.
2521         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
2522         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
2523         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
2524         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
2525         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
2526         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
2527         * unittests/filtered_iterator-selftests.c
2528         (_initialize_filtered_iterator_selftests): Add declaration.
2529         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
2530         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
2531         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
2532         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
2533         * unittests/main-thread-selftests.c
2534         (_initialize_main_thread_selftests): Add declaration.
2535         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
2536         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
2537         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
2538         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
2539         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
2540         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
2541         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
2542         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
2543         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
2544         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
2545         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
2546         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
2547         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
2548         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
2549         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
2550         declaration.
2551         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
2552         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
2553         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
2554         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
2555         * user-regs.c (_initialize_user_regs): Add declaration.
2556         * utils.c (_initialize_utils): Add declaration.
2557         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
2558         * valops.c (_initialize_valops): Add declaration.
2559         * valprint.c (_initialize_valprint): Add declaration.
2560         * value.c (_initialize_values): Add declaration.
2561         * varobj.c (_initialize_varobj): Add declaration.
2562         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
2563         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
2564         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
2565         * windows-nat.c (_initialize_windows_nat): Add declaration.
2566         (_initialize_check_for_gdb_ini): Add declaration.
2567         (_initialize_loadable): Add declaration.
2568         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
2569         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
2570         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
2571         * xcoffread.c (_initialize_xcoffread): Add declaration.
2572         * xml-support.c (_initialize_xml_support): Add declaration.
2573         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
2574         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
2575         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
2576         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
2577
2578 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
2579
2580         * regformats/regdat.sh: Generate declaration for init function.
2581
2582 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
2583
2584         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
2585         up.
2586         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
2587         close_one_inferior>: New methods.
2588         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
2589         pass down target to find_inferior_pid.
2590         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
2591         Pass down target to find_inferior_ptid.
2592         (gdbsim_target::create_inferior): Pass down target to
2593         add_thread_silent.
2594         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
2595         target down to find_inferior_ptid and switch_to_thread.
2596         (gdbsim_target::close): Update to call close_one_inferior.
2597         (struct resume_data): Remove.
2598         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
2599         directly, rather than through a void pointer.
2600         (gdbsim_target::resume): Update to call resume_one_inferior.
2601
2602 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
2603
2604         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
2605
2606 2020-01-12  Pedro Alves  <palves@redhat.com>
2607
2608         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
2609         directly for the current inferior instead of
2610         discard_all_inferiors.
2611         (discard_all_inferiors): Delete.
2612
2613 2020-01-11  Tom Tromey  <tom@tromey.com>
2614
2615         * tui/tui-wingeneral.c (box_win): Check cli_styling.
2616         * tui/tui-winsource.c (tui_source_window_base::refill): Use
2617         deprecated_safe_get_selected_frame.
2618
2619 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2620
2621         * inferior.c (print_inferior): Switch inferior before printing it.
2622
2623 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
2624             Pedro Alves  <palves@redhat.com>
2625
2626         * progspace-and-thread.c (switch_to_program_space_and_thread):
2627         Assert there's an inferior for PSPACE.  Use
2628         switch_to_inferior_no_thread to switch the inferior too.
2629         * progspace.c (program_space::~program_space): Call
2630         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
2631         (program_space::free_all_objfiles): Don't call clear_symtab_users
2632         here.
2633         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
2634
2635 2020-01-10  Pedro Alves  <palves@redhat.com>
2636
2637         * NEWS: Mention multi-target debugging, "info connections", and
2638         "add-inferior -no-connection".
2639
2640 2020-01-10  Pedro Alves  <palves@redhat.com>
2641
2642         * infrun.c: Include "target-connection.h".
2643         (check_multi_target_resumption): New.
2644         (proceed): Call it.
2645         * target-connection.c (make_target_connection_string): Make
2646         extern.
2647         * target-connection.h (make_target_connection_string): Declare.
2648
2649 2020-01-10  Pedro Alves  <palves@redhat.com>
2650
2651         * Makefile.in (COMMON_SFILES): Add target-connection.c.
2652         * inferior.c (uiout_field_connection): New function.
2653         (print_inferior): Add new "connection-id" column.
2654         (add_inferior_command): Show connection number/string of added
2655         inferior.
2656         * process-stratum-target.h
2657         (process_stratum_target::connection_string): New virtual method.
2658         (process_stratum_target::connection_number): New field.
2659         * remote.c (remote_target::connection_string): New override.
2660         * target-connection.c: New file.
2661         * target-connection.h: New file.
2662         * target.c (decref_target): Remove process_stratum targets from
2663         the connection list.
2664         (target_stack::push): Add process_stratum targets to the
2665         connection list.
2666
2667 2020-01-10  Pedro Alves  <palves@redhat.com>
2668
2669         Revert:
2670         2016-04-12  Pedro Alves  <palves@redhat.com>
2671         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
2672         Remove references to name.
2673         * serial.h (struct serial) <name>: Delete.
2674
2675 2020-01-10  Pedro Alves  <palves@redhat.com>
2676
2677         * gdbarch-selftests.c (register_to_value_test): Remove "target
2678         already pushed" check.
2679
2680 2020-01-10  Pedro Alves  <palves@redhat.com>
2681             John Baldwin  <jhb@FreeBSD.org>
2682
2683         * aarch64-linux-nat.c
2684         (aarch64_linux_nat_target::thread_architecture): Adjust.
2685         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
2686         (task_command_1): Likewise.
2687         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
2688         (aix_thread_target::wait, aix_thread_target::fetch_registers)
2689         (aix_thread_target::store_registers)
2690         (aix_thread_target::thread_alive): Adjust.
2691         * amd64-fbsd-tdep.c: Include "inferior.h".
2692         (amd64fbsd_get_thread_local_address): Pass down target.
2693         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
2694         thread's gdbarch instead of target_gdbarch.
2695         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
2696         get_last_target_status.
2697         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
2698         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
2699         inferiors.
2700         (update_inserted_breakpoint_locations): Skip if inferiors with no
2701         execution.
2702         (update_global_location_list): When handling moribund locations,
2703         find representative inferior for location's pspace, and use thread
2704         count of its process_stratum target.
2705         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
2706         * bsd-uthread.c (bsd_uthread_target::wait): Use
2707         as_process_stratum_target and adjust thread_change_ptid and
2708         add_thread calls.
2709         (bsd_uthread_target::update_thread_list): Use
2710         as_process_stratum_target and adjust find_thread_ptid,
2711         thread_change_ptid and add_thread calls.
2712         * btrace.c (maint_btrace_packet_history_cmd): Adjust
2713         find_thread_ptid call.
2714         * corelow.c (add_to_thread_list): Adjust add_thread call.
2715         (core_target_open): Adjust add_thread_silent and thread_count
2716         calls.
2717         (core_target::pid_to_str): Adjust find_inferior_ptid call.
2718         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
2719         * event-top.c (async_disconnect): Pop targets from all inferiors.
2720         * exec.c (add_target_sections): Push exec target on all inferiors
2721         sharing the program space.
2722         (remove_target_sections): Remove the exec target from all
2723         inferiors sharing the program space.
2724         (exec_on_vfork): New.
2725         * exec.h (exec_on_vfork): Declare.
2726         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
2727         Pass it down.
2728         (fbsd_nat_target::update_thread_list): Adjust.
2729         (fbsd_nat_target::resume): Adjust.
2730         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
2731         down.
2732         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
2733         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
2734         get_thread_arch_regcache call.
2735         * fork-child.c (gdb_startup_inferior): Pass target down to
2736         startup_inferior and set_executing.
2737         * gdbthread.h (struct process_stratum_target): Forward declare.
2738         (add_thread, add_thread_silent, add_thread_with_info)
2739         (in_thread_list): Add process_stratum_target parameter.
2740         (find_thread_ptid(inferior*, ptid_t)): New overload.
2741         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
2742         parameter.
2743         (all_threads()): Delete overload.
2744         (all_threads, all_non_exited_threads): Add process_stratum_target
2745         parameter.
2746         (all_threads_safe): Use brace initialization.
2747         (thread_count): Add process_stratum_target parameter.
2748         (set_resumed, set_running, set_stop_requested, set_executing)
2749         (threads_are_executing, finish_thread_state): Add
2750         process_stratum_target parameter.
2751         (switch_to_thread): Use is_current_thread.
2752         * i386-fbsd-tdep.c: Include "inferior.h".
2753         (i386fbsd_get_thread_local_address): Pass down target.
2754         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
2755         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
2756         have_inferiors check.
2757         * inf-ptrace.c (inf_ptrace_target::create_inferior)
2758         (inf_ptrace_target::attach): Adjust.
2759         * infcall.c (run_inferior_call): Adjust.
2760         * infcmd.c (run_command_1): Pass target to
2761         scoped_finish_thread_state.
2762         (proceed_thread_callback): Skip inferiors with no execution.
2763         (continue_command): Rename 'all_threads' local to avoid hiding
2764         'all_threads' function.  Adjust get_last_target_status call.
2765         (prepare_one_step): Adjust set_running call.
2766         (signal_command): Use user_visible_resume_target.  Compare thread
2767         pointers instead of inferior_ptid.
2768         (info_program_command): Adjust to pass down target.
2769         (attach_command): Mark target's 'thread_executing' flag.
2770         (stop_current_target_threads_ns): New, factored out from ...
2771         (interrupt_target_1): ... this.  Switch inferior before making
2772         target calls.
2773         * inferior-iter.h
2774         (struct all_inferiors_iterator, struct all_inferiors_range)
2775         (struct all_inferiors_safe_range)
2776         (struct all_non_exited_inferiors_range): Filter on
2777         process_stratum_target too.  Remove explicit.
2778         * inferior.c (inferior::inferior): Push dummy target on target
2779         stack.
2780         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
2781         Add process_stratum_target parameter, and pass it down.
2782         (have_live_inferiors): Adjust.
2783         (switch_to_inferior_and_push_target): New.
2784         (add_inferior_command, clone_inferior_command): Handle
2785         "-no-connection" parameter.  Use
2786         switch_to_inferior_and_push_target.
2787         (_initialize_inferior): Mention "-no-connection" option in
2788         the help of "add-inferior" and "clone-inferior" commands.
2789         * inferior.h: Include "process-stratum-target.h".
2790         (interrupt_target_1): Use bool.
2791         (struct inferior) <push_target, unpush_target, target_is_pushed,
2792         find_target_beneath, top_target, process_target, target_at,
2793         m_stack>: New.
2794         (discard_all_inferiors): Delete.
2795         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
2796         (all_inferiors, all_non_exited_inferiors): Add
2797         process_stratum_target parameter.
2798         * infrun.c: Include "gdb_select.h" and <unordered_map>.
2799         (target_last_proc_target): New global.
2800         (follow_fork_inferior): Push target on new inferior.  Pass target
2801         to add_thread_silent.  Call exec_on_vfork.  Handle target's
2802         reference count.
2803         (follow_fork): Adjust get_last_target_status call.  Also consider
2804         target.
2805         (follow_exec): Push target on new inferior.
2806         (struct execution_control_state) <target>: New field.
2807         (user_visible_resume_target): New.
2808         (do_target_resume): Call target_async.
2809         (resume_1): Set target's threads_executing flag.  Consider resume
2810         target.
2811         (commit_resume_all_targets): New.
2812         (proceed): Also consider resume target.  Skip threads of inferiors
2813         with no execution.  Commit resumtion in all targets.
2814         (start_remote): Pass current inferior to wait_for_inferior.
2815         (infrun_thread_stop_requested): Consider target as well.  Pass
2816         thread_info pointer to clear_inline_frame_state instead of ptid.
2817         (infrun_thread_thread_exit): Consider target as well.
2818         (random_pending_event_thread): New inferior parameter.  Use it.
2819         (do_target_wait): Rename to ...
2820         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
2821         down.
2822         (threads_are_resumed_pending_p, do_target_wait): New.
2823         (prepare_for_detach): Adjust calls.
2824         (wait_for_inferior): New inferior parameter.  Handle it.  Use
2825         do_target_wait_1 instead of do_target_wait.
2826         (fetch_inferior_event): Adjust.  Switch to representative
2827         inferior.  Pass target down.
2828         (set_last_target_status): Add process_stratum_target parameter.
2829         Save target in global.
2830         (get_last_target_status): Add process_stratum_target parameter and
2831         handle it.
2832         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
2833         (context_switch): Check inferior_ptid == null_ptid before calling
2834         inferior_thread().
2835         (get_inferior_stop_soon): Pass down target.
2836         (wait_one): Rename to ...
2837         (poll_one_curr_target): ... this.
2838         (struct wait_one_event): New.
2839         (wait_one): New.
2840         (stop_all_threads): Adjust.
2841         (handle_no_resumed, handle_inferior_event): Adjust to consider the
2842         event's target.
2843         (switch_back_to_stepped_thread): Also consider target.
2844         (print_stop_event): Update.
2845         (normal_stop): Update.  Also consider the resume target.
2846         * infrun.h (wait_for_inferior): Remove declaration.
2847         (user_visible_resume_target): New declaration.
2848         (get_last_target_status, set_last_target_status): New
2849         process_stratum_target parameter.
2850         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
2851         process_stratum_target parameter, and use it.
2852         (clear_inline_frame_state (thread_info*)): New.
2853         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
2854         process_stratum_target parameter.
2855         (clear_inline_frame_state (thread_info*)): Declare.
2856         * linux-fork.c (delete_checkpoint_command): Pass target down to
2857         find_thread_ptid.
2858         (checkpoint_command): Adjust.
2859         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
2860         instead of just tweaking inferior_ptid.
2861         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
2862         (exit_lwp): Pass target down to find_thread_ptid.
2863         (attach_proc_task_lwp_callback): Pass target down to
2864         add_thread/set_running/set_executing.
2865         (linux_nat_target::attach): Pass target down to
2866         thread_change_ptid.
2867         (get_detach_signal): Pass target down to find_thread_ptid.
2868         Consider last target status's target.
2869         (linux_resume_one_lwp_throw, resume_lwp)
2870         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
2871         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
2872         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
2873         (linux_nat_target::async_wait_fd): New.
2874         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
2875         target down.
2876         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
2877         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
2878         * linux-thread-db.c (struct thread_db_info::process_target): New
2879         field.
2880         (add_thread_db_info): Save target.
2881         (get_thread_db_info): New process_stratum_target parameter.  Also
2882         match target.
2883         (delete_thread_db_info): New process_stratum_target parameter.
2884         Also match target.
2885         (thread_from_lwp): Adjust to pass down target.
2886         (thread_db_notice_clone): Pass down target.
2887         (check_thread_db_callback): Pass down target.
2888         (try_thread_db_load_1): Always push the thread_db target.
2889         (try_thread_db_load, record_thread): Pass target down.
2890         (thread_db_target::detach): Pass target down.  Always unpush the
2891         thread_db target.
2892         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
2893         target down.  Always unpush the thread_db target.
2894         (find_new_threads_callback, thread_db_find_new_threads_2)
2895         (thread_db_target::update_thread_list): Pass target down.
2896         (thread_db_target::pid_to_str): Pass current inferior down.
2897         (thread_db_target::get_thread_local_address): Pass target down.
2898         (thread_db_target::resume, maintenance_check_libthread_db): Pass
2899         target down.
2900         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
2901         * procfs.c (procfs_target::procfs_init_inferior): Declare.
2902         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
2903         (procfs_init_inferior): Rename to ...
2904         (procfs_target::procfs_init_inferior): ... this and adjust.
2905         (procfs_target::create_inferior, procfs_notice_thread)
2906         (procfs_do_thread_registers): Adjust.
2907         * ppc-fbsd-tdep.c: Include "inferior.h".
2908         (ppcfbsd_get_thread_local_address): Pass down target.
2909         * proc-service.c (ps_xfer_memory): Switch current inferior and
2910         program space as well.
2911         (get_ps_regcache): Pass target down.
2912         * process-stratum-target.c
2913         (process_stratum_target::thread_address_space)
2914         (process_stratum_target::thread_architecture): Pass target down.
2915         * process-stratum-target.h
2916         (process_stratum_target::threads_executing): New field.
2917         (as_process_stratum_target): New.
2918         * ravenscar-thread.c
2919         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
2920         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
2921         down.
2922         * record-btrace.c (record_btrace_target::info_record): Adjust.
2923         (record_btrace_target::record_method)
2924         (record_btrace_target::record_is_replaying)
2925         (record_btrace_target::fetch_registers)
2926         (get_thread_current_frame_id, record_btrace_target::resume)
2927         (record_btrace_target::wait, record_btrace_target::stop): Pass
2928         target down.
2929         * record-full.c (record_full_wait_1): Switch to event thread.
2930         Pass target down.
2931         * regcache.c (regcache::regcache)
2932         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
2933         process_stratum_target parameter and handle it.
2934         (current_thread_target): New global.
2935         (get_thread_regcache): Add process_stratum_target parameter and
2936         handle it.  Switch inferior before calling target method.
2937         (get_thread_regcache): Pass target down.
2938         (get_thread_regcache_for_ptid): Pass target down.
2939         (registers_changed_ptid): Add process_stratum_target parameter and
2940         handle it.
2941         (registers_changed_thread, registers_changed): Pass target down.
2942         (test_get_thread_arch_aspace_regcache): New.
2943         (current_regcache_test): Define a couple local test_target_ops
2944         instances and use them for testing.
2945         (readwrite_regcache): Pass process_stratum_target parameter.
2946         (cooked_read_test, cooked_write_test): Pass mock_target down.
2947         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
2948         (get_thread_arch_aspace_regcache): Add process_stratum_target
2949         parameter.
2950         (regcache::target): New method.
2951         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
2952         (regcache::registers_changed_ptid): Add process_stratum_target
2953         parameter.
2954         (regcache::m_target): New field.
2955         (registers_changed_ptid): Add process_stratum_target parameter.
2956         * remote.c (remote_state::supports_vCont_probed): New field.
2957         (remote_target::async_wait_fd): New method.
2958         (remote_unpush_and_throw): Add remote_target parameter.
2959         (get_current_remote_target): Adjust.
2960         (remote_target::remote_add_inferior): Push target.
2961         (remote_target::remote_add_thread)
2962         (remote_target::remote_notice_new_inferior)
2963         (get_remote_thread_info): Pass target down.
2964         (remote_target::update_thread_list): Skip threads of inferiors
2965         bound to other targets.  (remote_target::close): Don't discard
2966         inferiors.  (remote_target::add_current_inferior_and_thread)
2967         (remote_target::process_initial_stop_replies)
2968         (remote_target::start_remote)
2969         (remote_target::remote_serial_quit_handler): Pass down target.
2970         (remote_target::remote_unpush_target): New remote_target
2971         parameter.  Unpush the target from all inferiors.
2972         (remote_target::remote_unpush_and_throw): New remote_target
2973         parameter.  Pass it down.
2974         (remote_target::open_1): Check whether the current inferior has
2975         execution instead of checking whether any inferior is live.  Pass
2976         target down.
2977         (remote_target::remote_detach_1): Pass down target.  Use
2978         remote_unpush_target.
2979         (extended_remote_target::attach): Pass down target.
2980         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
2981         (remote_target::append_resumption): Pass down target.
2982         (remote_target::append_pending_thread_resumptions)
2983         (remote_target::remote_resume_with_hc, remote_target::resume)
2984         (remote_target::commit_resume): Pass down target.
2985         (remote_target::remote_stop_ns): Check supports_vCont_probed.
2986         (remote_target::interrupt_query)
2987         (remote_target::remove_new_fork_children)
2988         (remote_target::check_pending_events_prevent_wildcard_vcont)
2989         (remote_target::remote_parse_stop_reply)
2990         (remote_target::process_stop_reply): Pass down target.
2991         (first_remote_resumed_thread): New remote_target parameter.  Pass
2992         it down.
2993         (remote_target::wait_as): Pass down target.
2994         (unpush_and_perror): New remote_target parameter.  Pass it down.
2995         (remote_target::readchar, remote_target::remote_serial_write)
2996         (remote_target::getpkt_or_notif_sane_1)
2997         (remote_target::kill_new_fork_children, remote_target::kill): Pass
2998         down target.
2999         (remote_target::mourn_inferior): Pass down target.  Use
3000         remote_unpush_target.
3001         (remote_target::core_of_thread)
3002         (remote_target::remote_btrace_maybe_reopen): Pass down target.
3003         (remote_target::pid_to_exec_file)
3004         (remote_target::thread_handle_to_thread_info): Pass down target.
3005         (remote_target::async_wait_fd): New.
3006         * riscv-fbsd-tdep.c: Include "inferior.h".
3007         (riscv_fbsd_get_thread_local_address): Pass down target.
3008         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
3009         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
3010         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
3011         Adjust.
3012         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
3013         * solib-svr4.c (enable_break): Pass down target.
3014         * spu-multiarch.c (parse_spufs_run): Pass down target.
3015         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
3016         * target-delegates.c: Regenerate.
3017         * target.c (g_target_stack): Delete.
3018         (current_top_target): Return the current inferior's top target.
3019         (target_has_execution_1): Refer to the passed-in inferior's top
3020         target.
3021         (target_supports_terminal_ours): Check whether the initial
3022         inferior was already created.
3023         (decref_target): New.
3024         (target_stack::push): Incref/decref the target.
3025         (push_target, push_target, unpush_target): Adjust.
3026         (target_stack::unpush): Defref target.
3027         (target_is_pushed): Return bool.  Adjust to refer to the current
3028         inferior's target stack.
3029         (dispose_inferior): Delete, and inline parts ...
3030         (target_preopen): ... here.  Only dispose of the current inferior.
3031         (target_detach): Hold strong target reference while detaching.
3032         Pass target down.
3033         (target_thread_name): Add assertion.
3034         (target_resume): Pass down target.
3035         (target_ops::beneath, find_target_at): Adjust to refer to the
3036         current inferior's target stack.
3037         (get_dummy_target): New.
3038         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
3039         has a thread running.
3040         (initialize_targets): Rename to ...
3041         (_initialize_target): ... this.
3042         * target.h: Include "gdbsupport/refcounted-object.h".
3043         (struct target_ops): Inherit refcounted_object.
3044         (target_ops::shortname, target_ops::longname): Make const.
3045         (target_ops::async_wait_fd): New method.
3046         (decref_target): Declare.
3047         (struct target_ops_ref_policy): New.
3048         (target_ops_ref): New typedef.
3049         (get_dummy_target): Declare function.
3050         (target_is_pushed): Return bool.
3051         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
3052         (all_matching_threads_iterator::all_matching_threads_iterator):
3053         Handle filter target.
3054         * thread-iter.h (struct all_matching_threads_iterator, struct
3055         all_matching_threads_range, class all_non_exited_threads_range):
3056         Filter by target too.  Remove explicit.
3057         * thread.c (threads_executing): Delete.
3058         (inferior_thread): Pass down current inferior.
3059         (clear_thread_inferior_resources): Pass down thread pointer
3060         instead of ptid_t.
3061         (add_thread_silent, add_thread_with_info, add_thread): Add
3062         process_stratum_target parameter.  Use it for thread and inferior
3063         searches.
3064         (is_current_thread): New.
3065         (thread_info::deletable): Use it.
3066         (find_thread_ptid, thread_count, in_thread_list)
3067         (thread_change_ptid, set_resumed, set_running): New
3068         process_stratum_target parameter.  Pass it down.
3069         (set_executing): New process_stratum_target parameter.  Pass it
3070         down.  Adjust reference to 'threads_executing'.
3071         (threads_are_executing): New process_stratum_target parameter.
3072         Adjust reference to 'threads_executing'.
3073         (set_stop_requested, finish_thread_state): New
3074         process_stratum_target parameter.  Pass it down.
3075         (switch_to_thread): Also match inferior.
3076         (switch_to_thread): New process_stratum_target parameter.  Pass it
3077         down.
3078         (update_threads_executing): Reimplement.
3079         * top.c (quit_force): Pop targets from all inferior.
3080         (gdb_init): Don't call initialize_targets.
3081         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
3082         Declare.
3083         (windows_add_thread, windows_delete_thread): Adjust.
3084         (get_windows_debug_event): Rename to ...
3085         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
3086         * tracefile-tfile.c (tfile_target_open): Pass down target.
3087         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
3088         Forward declare.
3089         (switch_to_thread): Add process_stratum_target parameter.
3090         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
3091         parameter.  Use it.
3092         (mi_on_resume): Pass target down.
3093         * nat/fork-inferior.c (startup_inferior): Add
3094         process_stratum_target parameter.  Pass it down.
3095         * nat/fork-inferior.h (startup_inferior): Add
3096         process_stratum_target parameter.
3097         * python/py-threadevent.c (py_get_event_thread): Pass target down.
3098
3099 2020-01-10  Pedro Alves  <palves@redhat.com>
3100
3101         * remote.c (remote_target::start_remote): Don't set inferior_ptid
3102         directly.  Instead find the first thread in the thread list and
3103         use switch_to_thread.
3104
3105 2020-01-10  Pedro Alves  <palves@redhat.com>
3106
3107         * remote.c (remote_target::remote_add_inferior): Don't bind a
3108         process to the current inferior if the current inferior is already
3109         bound to a process.
3110
3111 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3112             Pedro Alves  <palves@redhat.com>
3113
3114         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
3115         If no process is specified, return null_ptid instead of
3116         inferior_ptid.
3117         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
3118         TARGET_WAITKIND_SIGNALLED with no pid.
3119
3120 2020-01-10  Pedro Alves  <palves@redhat.com>
3121
3122         * remote.c (first_remote_resumed_thread): New.
3123         (remote_target::wait_as): Use it as default event_ptid instead of
3124         inferior_ptid.
3125
3126 2020-01-10  Pedro Alves  <palves@redhat.com>
3127
3128         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
3129
3130 2020-01-10  Pedro Alves  <palves@redhat.com>
3131
3132         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
3133         not -1.
3134
3135 2020-01-10  Pedro Alves  <palves@redhat.com>
3136
3137         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
3138         ptid to get_last_target_status.
3139         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
3140         ptid to get_last_target_status.
3141         * infcmd.c (continue_command): Don't pass a target_waitstatus to
3142         get_last_target_status.
3143         (info_program_command): Don't pass a target_waitstatus to
3144         get_last_target_status.
3145         * infrun.c (init_wait_for_inferior): Use
3146         nullify_last_target_wait_ptid.
3147         (get_last_target_status): Handle nullptr arguments.
3148         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
3149         (print_stop_event): Don't pass a ptid to get_last_target_status.
3150         (normal_stop): Don't pass a ptid to get_last_target_status.
3151         * infrun.h (get_last_target_status, set_last_target_status): Move
3152         comments here and update.
3153         (nullify_last_target_wait_ptid): Declare.
3154         * linux-fork.c (fork_load_infrun_state): Remove local extern
3155         declaration of nullify_last_target_wait_ptid.
3156         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
3157         to get_last_target_status.
3158
3159 2020-01-10  Pedro Alves  <palves@redhat.com>
3160
3161         * gdbthread.h (scoped_restore_current_thread)
3162         <dont_restore, restore, m_dont_restore>: Declare.
3163         * thread.c (thread_alive): Add assertion.  Return bool.
3164         (switch_to_thread_if_alive): New.
3165         (prune_threads): Switch inferior/thread.
3166         (print_thread_info_1): Switch thread before calling target methods.
3167         (scoped_restore_current_thread::restore): New, factored out from
3168         ...
3169         (scoped_restore_current_thread::~scoped_restore_current_thread):
3170         ... this.
3171         (scoped_restore_current_thread::scoped_restore_current_thread):
3172         Add assertion.
3173         (thread_apply_all_command, thread_select): Use
3174         switch_to_thread_if_alive.
3175         * infrun.c (proceed, restart_threads, handle_signal_stop)
3176         (switch_back_to_stepped_thread): Switch current thread before
3177         calling target methods.
3178
3179 2020-01-10  Pedro Alves <palves@redhat.com>
3180
3181         * inferior.c (switch_to_inferior_no_thread): New function,
3182         factored out from ...
3183         (inferior_command): ... here.
3184         * inferior.h (switch_to_inferior_no_thread): Declare.
3185         * mi/mi-main.c (run_one_inferior): Use
3186         switch_to_inferior_no_thread.
3187
3188 2020-01-10  Pedro Alves  <palves@redhat.com>
3189
3190         * infcmd.c (kill_command): Remove dead code.
3191
3192 2020-01-10  Pedro Alves  <palves@redhat.com>
3193
3194         * remote.c (remote_target::mourn_inferior): No longer check
3195         whether the target is running.
3196
3197 2020-01-10  Pedro Alves  <palves@redhat.com>
3198
3199         * corelow.c (core_target::has_execution): Change parameter type to
3200         inferior pointer.
3201         * inferior.c (number_of_live_inferiors): Use
3202         inferior::has_execution instead of target_has_execution_1.
3203         * inferior.h (inferior::has_execution): New.
3204         * linux-thread-db.c (thread_db_target::update_thread_list): Use
3205         inferior::has_execution instead of target_has_execution_1.
3206         * process-stratum-target.c
3207         (process_stratum_target::has_execution): Change parameter type to
3208         inferior pointer.  Check the inferior's PID instead of
3209         inferior_ptid.
3210         * process-stratum-target.h
3211         (process_stratum_target::has_execution): Change parameter type to
3212         inferior pointer.
3213         * record-full.c (record_full_core_target::has_execution): Change
3214         parameter type to inferior pointer.
3215         * target.c (target_has_execution_1): Change parameter type to
3216         inferior pointer.
3217         (target_has_execution_current): Adjust.
3218         * target.h (target_ops::has_execution): Change parameter type to
3219         inferior pointer.
3220         (target_has_execution_1): Change parameter type to inferior
3221         pointer.  Change return type to bool.
3222         * tracefile.h (tracefile_target::has_execution): Change parameter
3223         type to inferior pointer.
3224
3225 2020-01-10  Pedro Alves  <palves@redhat.com>
3226
3227         * exceptions.c (print_flush): Remove current_top_target() check.
3228
3229 2020-01-10  Pedro Alves  <palves@redhat.com>
3230
3231         * remote.c (show_remote_exec_file): Show the current inferior's
3232         exec-file instead of the command variable's value.
3233
3234 2020-01-10  Pedro Alves  <palves@redhat.com>
3235
3236         * record-full.c (record_full_resume_ptid): New global.
3237         (record_full_target::resume): Set it.
3238         (record_full_wait_1): Use record_full_resume_ptid instead of
3239         inferior_ptid.
3240
3241 2020-01-10  Pedro Alves  <palves@redhat.com>
3242
3243         * gdbthread.h (scoped_restore_current_thread)
3244         <dont_restore, restore, m_dont_restore>: Declare.
3245         * thread.c (thread_alive): Add assertion.  Return bool.
3246         (switch_to_thread_if_alive): New.
3247         (prune_threads): Switch inferior/thread.
3248         (print_thread_info_1): Switch thread before calling target methods.
3249         (scoped_restore_current_thread::restore): New, factored out from
3250         ...
3251         (scoped_restore_current_thread::~scoped_restore_current_thread):
3252         ... this.
3253         (scoped_restore_current_thread::scoped_restore_current_thread):
3254         Add assertion.
3255         (thread_apply_all_command, thread_select): Use
3256         switch_to_thread_if_alive.
3257
3258 2020-01-10  George Barrett  <bob@bob131.so>
3259
3260         * stap-probe.c (stap_modify_semaphore): Don't check for null
3261         semaphores.
3262         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
3263         for null semaphores.
3264
3265 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3266
3267         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
3268         all source windows, and maintain horizontal scroll status while
3269         doing so.
3270
3271 2020-01-09  Tom Tromey  <tom@tromey.com>
3272
3273         PR tui/18932:
3274         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
3275         update_source_window, not print_source_lines.
3276
3277 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3278
3279         * tui/tui.c (tui_enable): Register tui hooks after calling
3280         tui_display_main.
3281
3282 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
3283
3284         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
3285
3286 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
3287
3288         * thread.c (print_thread_info_1): Fix indentation.
3289
3290 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
3291
3292         * symtab.c (general_symbol_info::compute_and_set_names): Move the
3293         unique_xmalloc_ptr outside the if to always free the demangled name.
3294
3295 2020-01-08  Tom Tromey  <tromey@adacore.com>
3296
3297         * xcoffread.c (enter_line_range, read_xcoff_symtab)
3298         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
3299         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
3300         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
3301         Remove.
3302         (section_offsets): New typedef.
3303         * symtab.c (fixup_section, get_msymbol_address): Update.
3304         * symmisc.c (dump_msymbols): Update.
3305         * symfile.h (relative_addr_info_to_section_offsets)
3306         (symfile_map_offsets_to_segments): Update.
3307         * symfile.c (build_section_addr_info_from_objfile)
3308         (init_objfile_sect_indices): Update.
3309         (struct place_section_arg): Change type of "offsets".
3310         (place_section): Update.
3311         (relative_addr_info_to_section_offsets): Change type of
3312         "section_offsets".  Remove "num_sections" parameter.
3313         (default_symfile_offsets, syms_from_objfile_1)
3314         (set_objfile_default_section_offset): Update.
3315         (reread_symbols): No need to preserve section offsets by hand.
3316         (symfile_map_offsets_to_segments): Change type of "offsets".
3317         * stap-probe.c (relocate_address): Update.
3318         * stabsread.h (process_one_symbol): Update.
3319         * solib-target.c (struct lm_info_target) <offsets>: Change type.
3320         (solib_target_relocate_section_addresses): Update.
3321         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
3322         Update.
3323         * solib-frv.c (frv_relocate_main_executable): Update.
3324         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
3325         * solib-aix.c (solib_aix_get_section_offsets): Change return
3326         type.
3327         (solib_aix_solib_create_inferior_hook): Update.
3328         * remote.c (remote_target::get_offsets): Update.
3329         * psymtab.c (find_pc_sect_psymtab): Update.
3330         * psympriv.h (struct partial_symbol) <address, text_low,
3331         text_high>: Update.
3332         * objfiles.h (obj_section_offset): Update.
3333         (struct objfile) <section_offsets>: Change type.
3334         <num_sections>: Remove.
3335         (objfile_relocate): Update.
3336         * objfiles.c (entry_point_address_query): Update
3337         (relocate_one_symbol): Change type of "section_offsets".
3338         (objfile_relocate1, objfile_relocate1): Change type of
3339         "new_offsets".
3340         (objfile_rebase1): Update.
3341         * mipsread.c (mipscoff_symfile_read): Update.
3342         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
3343         parameter.
3344         * mdebugread.c (parse_symbol): Change type of "section_offsets".
3345         (parse_external, psymtab_to_symtab_1): Update.
3346         * machoread.c (macho_symfile_offsets): Update.
3347         * ia64-tdep.c (ia64_find_unwind_table): Update.
3348         * hppa-tdep.c (read_unwind_info): Update.
3349         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
3350         * dwarf2read.c (create_addrmap_from_index)
3351         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
3352         (process_psymtab_comp_unit_reader, add_partial_symbol)
3353         (add_partial_subprogram, process_full_comp_unit)
3354         (read_file_scope, read_func_scope, read_lexical_block_scope)
3355         (read_call_site_scope, dwarf2_rnglists_process)
3356         (dwarf2_ranges_process, dwarf2_ranges_read)
3357         (dwarf_decode_lines_1, var_decode_location, new_symbol)
3358         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
3359         Update.
3360         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
3361         Update.
3362         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
3363         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
3364         (process_one_symbol): Change type of "section_offsets".
3365         * ctfread.c (get_objfile_text_range): Update.
3366         * coffread.c (coff_symtab_read, enter_linenos)
3367         (process_coff_symbol): Update.
3368         * coff-pe-read.c (add_pe_forwarded_sym): Update.
3369         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
3370
3371 2020-01-08  Tom Tromey  <tromey@adacore.com>
3372
3373         * dwarf2read.c (parse_macro_definition): Use std::string.
3374         (parse_macro_definition): Likewise.
3375
3376 2020-01-08  Tom Tromey  <tromey@adacore.com>
3377
3378         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
3379         (ATTR_ALLOC_CHUNK): Remove.
3380
3381 2020-01-08  Tom Tromey  <tromey@adacore.com>
3382
3383         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
3384
3385 2020-01-08  Tom Tromey  <tromey@adacore.com>
3386
3387         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
3388         (dwarf2_compute_name, open_dwo_file): Likewise.
3389         (process_enumeration_scope): Use std::vector.
3390         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
3391         (partial_die_info::fixup, dwarf2_start_subfile)
3392         (guess_full_die_structure_name, dwarf2_name): Likewise.
3393         (determine_prefix): Update.
3394         (guess_full_die_structure_name): Make return type const.
3395         (partial_die_full_name): Return unique_xmalloc_ptr.
3396         (DW_FIELD_ALLOC_CHUNK): Remove.
3397
3398 2020-01-07  Tom Tromey  <tromey@adacore.com>
3399
3400         PR build/24937:
3401         * stap-probe.c (class stap_static_probe_ops): Add constructor.
3402
3403 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
3404
3405         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
3406
3407 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3408
3409         * stack.c (print_frame_info): Move disassemble_next_line code
3410         inside source_print block.
3411
3412 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3413
3414         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
3415         gdb/signals.h, as we are now using native signal symbols.
3416
3417 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
3418
3419         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
3420         overflow by an early check of content vs threshold.
3421         * tui/tui-source.c (tui_source_window::line_is_displayed):
3422         Likewise.
3423
3424 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3425
3426         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
3427
3428 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
3429
3430         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
3431         export table if no section contains it's RVA.
3432
3433 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3434
3435         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
3436
3437 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
3438
3439         * source.c (print_source_lines_base): Set last_line_listed.
3440
3441 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
3442
3443         * tui/tui-disasm.c: Remove trailing spaces.
3444
3445 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
3446             Pedro Alves  <palves@redhat.com>
3447
3448         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
3449         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
3450         (windows_gdb_signal_to_target): New function, uses the above
3451         enumeration to convert GDB internal signal codes to equivalent
3452         Windows codes.
3453         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
3454         * windows-nat.c: Include "gdb_wait.h".
3455         (get_windows_debug_event): Extract the fatal exception from the
3456         exit status and convert to the equivalent Posix signal number.
3457         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
3458         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
3459         * gdbsupport/gdb_wait.c: New file, implements
3460         windows_status_to_termsig.
3461         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
3462         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
3463
3464 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3465
3466         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
3467         show_layout.
3468
3469 2020-01-05  Luis Machado  <luis.machado@linaro.org>
3470
3471         * aarch64-linux-nat.c
3472         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
3473         and bfd_mach_aarch64.
3474
3475 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3476
3477         * ui-file.c (stdio_file::can_emit_style_escape)
3478         (tee_file::can_emit_style_escape): Ensure style is used also on
3479         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
3480         to gdb_stdout.
3481         * main.c (set_gdb_data_directory): Use file style to output the
3482         warning that the given pathname is not a directory.
3483         * top.c (show_history_filename, gdb_safe_append_history)
3484         (show_gdb_datadir): Use file style.
3485
3486 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
3487
3488         * solib-target.c (struct lm_info_target):
3489         Change offsets to be a unique_xmalloc_ptr.
3490         (solib_target_relocate_section_addresses): Update.
3491
3492 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
3493
3494         * windows-nat.c (windows_clear_solib): Free so_list linked list.
3495
3496 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3497
3498         * MAINTAINERS (Write After Approval): Add myself.
3499
3500 2020-01-02  Luis Machado  <luis.machado@linaro.org>
3501
3502         * proc-service.c (get_ps_regcache): Remove reference to obsolete
3503         Cell BE architecture.
3504         * target.h (struct target_ops) <thread_architecture>: Likewise.
3505
3506 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
3507
3508         * Makefile.in: Use INSTALL_PROGRAM_ENV.
3509
3510 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
3511
3512         * MAINTAINERS (Write After Approval): Add myself.
3513
3514 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3515
3516         * gdbarch.sh: Update copyright year range of generated files.
3517
3518 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3519
3520         Update copyright year range in all GDB files.
3521
3522 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3523
3524         * copyright.py: Convert to Python 3.
3525
3526 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3527
3528         * copyright.py: Adapt after move of gnulib directory from gdb
3529         directory to toplevel directory.
3530
3531 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3532
3533         * copyright.py (main): Exit if run from the wrong directory.
3534
3535 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3536
3537         * top.c (print_gdb_version): Change copyright year to 2020.
3538
3539 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3540
3541         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
3542
3543 For older changes see ChangeLog-2019.
3544 \f
3545 Local Variables:
3546 mode: change-log
3547 left-margin: 8
3548 fill-column: 74
3549 version-control: never
3550 coding: utf-8
3551 End: