gdb/ChangeLog

   1 2019-10-23  Tom Tromey  <tom@tromey.com>
   2
   3         * configure: Rebuild.
   4         * acinclude.m4: Use m4_include, not sinclude.
   5
   6 2019-10-23  Tom de Vries  <tdevries@suse.de>
   7
   8         PR breakpoints/24687
   9         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
  10
  11 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  12
  13         * symtab.c (struct demangled_name_entry) <language>: Change from
  14         bitfield to regular variable.
  15
  16 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  17
  18         * symtab.c (struct demangled_name_entry): Add a constructor.
  19         (free_demangled_name_entry): New function to call the destructor
  20         for demangled_name_entry.
  21         (create_demangled_names_hash): Pass free_demangled_name_entry to
  22         htab_create_alloc.
  23         (symbol_set_names): Call placement new for demangled_name_entry.
  24         * utils.c: No longer include xxhash.h here, now that fast_hash
  25         is inlined in the header.
  26         * utils.h: Instead, include it here.
  27
  28 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  29
  30         * Makefile.in: Link with libxxhash.
  31         * config.in: Regenerate.
  32         * configure: Regenerate.
  33         * configure.ac: Search for libxxhash.
  34         * utils.c (fast_hash): Use xxhash if present.
  35
  36 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  37
  38         * utils.h (fast_hash): New function.
  39         * symtab.c (hash_demangled_name_entry): Call new function
  40         fast_hash.
  41
  42 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  43
  44         * symtab.c (struct demangled_name_entry): Change type of mangled
  45         to gdb::string_view. Also adds a constructor that takes the
  46         mangled name.
  47         (hash_demangled_name_entry): Update.
  48         (eq_demangled_name_entry): Update.
  49         (free_demangled_name_entry): New function to call the destructor
  50         now that this is not a POD anymore.
  51         (create_demangled_names_hash): Pass free_demangled_name_entry to
  52         htab_create_alloc.
  53         (symbol_set_names): Update.
  54
  55 2019-10-21  Ali Tamur  <tamu@google.com>
  56
  57         * dwarf2read.c (dir_index): Change type.
  58         (file_name_index): Likewise.
  59         (line_header::include_dir_at): Change comment and implementation on
  60         whether it is DWARF 5.
  61         (line_header::is_valid_file_index): New function.
  62         (line_header::file_name_at): Change comment and implementation on
  63         whether it is DWARF 5.
  64         (line_header::file_names): Change to private field renamed as
  65         m_file_names and introduce a new accessor method.
  66         (line_header::file_names_size): New method.
  67         (line_header::include_dirs): Change to private field and rename as
  68         m_include_dirs.
  69         (dw2_get_file_names_reader): Define local var at a smaller scope and
  70         reflect API change.
  71         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
  72         (process_structure_scope): Likewise.
  73         (line_header::add_include_dir): Change message and reflect renaming.
  74         (line_header::add_file_name): Likewise.
  75         (read_formatted_entries): Handle DW_FORM_data16.
  76         (dwarf_decode_line_header): Fix line header length calculation.
  77         (psymtab_include_file_name): Change comment and API.
  78         (lnp_state_machine::m_file): Update comment and reflect type change.
  79         (lnp_state_machine::record_line): Reflect type change.
  80         (dwarf_decode_lines): Reflect API change.
  81         (file_file_name): Likewise.
  82         (file_full_name): Likewise.
  83
  84 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
  85
  86         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
  87
  88 2019-10-21  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
  91
  92 2019-10-21  Tom Tromey  <tom@tromey.com>
  93
  94         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
  95         NM_H.   Use AC_CONFIG_LINKS.
  96         * configure: Rebuild.
  97         * Makefile.in (NM_H): New variable.
  98         (generated_files): Add NM_H.  Remove gcore.
  99         (nm.h, stamp-nmh): New targets.
 100
 101 2019-10-20  Tom Tromey  <tom@tromey.com>
 102
 103         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 104         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 105         obsolete comment.
 106         (put_objfile_before): Now static.
 107
 108 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 109
 110         * gdbsupport/common-utils.h (startswith): Change return type to
 111         bool.
 112
 113 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 114
 115         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 116         * breakpoint.c (bp_locations_compare): Rename to...
 117         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 118         (update_global_location_list): Use std::sort instead of qsort.
 119         * buildsym.c (compare_line_numbers): Rename to...
 120         (lte_is_less_than): ...this, and change to std::sort semantics.
 121         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 122         instead of qsort.
 123         * disasm.c (compare_lines): Rename to...
 124         (line_is_less_than): ...this, and change to std::sort semantics.
 125         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 126         of qsort.
 127         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 128         (fde_is_less_than): ...this, and change to std::sort semantics.
 129         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 130         * mdebugread.c (compare_blocks):
 131         (block_is_less_than): ...this, and change to std::sort semantics.
 132         (sort_blocks): Call std::sort instead of qsort.
 133         * objfiles.c (qsort_cmp): Rename to...
 134         (sort_cmp): ...this, and change to std::sort semantics.
 135         (update_section_map): Call std::sort instead of qsort.
 136         * remote.c (compare_pnums): Remove.
 137         (map_regcache_remote_table): Call std::sort instead of qsort.
 138         * utils.c (compare_positive_ints): Remove.
 139         * utils.h (compare_positive_ints): Remove.
 140         * xcoffread.c (compare_lte): Remove.
 141         (arrange_linetable): Call std::sort instead of qsort.
 142
 143 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 144
 145         * symfile.c (init_entry_point_info): Fix typo.
 146         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 147
 148 2019-10-18  Tom de Vries  <tdevries@suse.de>
 149
 150         * aarch64-tdep.c: Fix typos in comments.
 151         * ada-lang.c: Same.
 152         * ada-tasks.c: Same.
 153         * alpha-tdep.c: Same.
 154         * alpha-tdep.h: Same.
 155         * amd64-nat.c: Same.
 156         * amd64-windows-tdep.c: Same.
 157         * arc-tdep.c: Same.
 158         * arc-tdep.h: Same.
 159         * arch-utils.c: Same.
 160         * arm-nbsd-tdep.c: Same.
 161         * arm-tdep.c: Same.
 162         * ax-gdb.c: Same.
 163         * blockframe.c: Same.
 164         * btrace.c: Same.
 165         * c-varobj.c: Same.
 166         * coff-pe-read.c: Same.
 167         * coffread.c: Same.
 168         * cris-tdep.c: Same.
 169         * darwin-nat.c: Same.
 170         * dbxread.c: Same.
 171         * dcache.c: Same.
 172         * disasm.c: Same.
 173         * dtrace-probe.c: Same.
 174         * dwarf-index-write.c: Same.
 175         * dwarf2-frame-tailcall.c: Same.
 176         * dwarf2-frame.c: Same.
 177         * dwarf2read.c: Same.
 178         * eval.c: Same.
 179         * exceptions.c: Same.
 180         * fbsd-tdep.c: Same.
 181         * findvar.c: Same.
 182         * frame.c: Same.
 183         * frv-tdep.c: Same.
 184         * gnu-v3-abi.c: Same.
 185         * go32-nat.c: Same.
 186         * h8300-tdep.c: Same.
 187         * hppa-tdep.c: Same.
 188         * i386-linux-tdep.c: Same.
 189         * i386-tdep.c: Same.
 190         * ia64-libunwind-tdep.c: Same.
 191         * ia64-tdep.c: Same.
 192         * infcmd.c: Same.
 193         * infrun.c: Same.
 194         * linespec.c: Same.
 195         * linux-nat.c: Same.
 196         * linux-thread-db.c: Same.
 197         * machoread.c: Same.
 198         * mdebugread.c: Same.
 199         * mep-tdep.c: Same.
 200         * mn10300-tdep.c: Same.
 201         * namespace.c: Same.
 202         * objfiles.c: Same.
 203         * opencl-lang.c: Same.
 204         * or1k-tdep.c: Same.
 205         * osabi.c: Same.
 206         * ppc-linux-nat.c: Same.
 207         * ppc-linux-tdep.c: Same.
 208         * ppc-sysv-tdep.c: Same.
 209         * printcmd.c: Same.
 210         * procfs.c: Same.
 211         * record-btrace.c: Same.
 212         * record-full.c: Same.
 213         * remote-fileio.c: Same.
 214         * remote.c: Same.
 215         * rs6000-tdep.c: Same.
 216         * s12z-tdep.c: Same.
 217         * score-tdep.c: Same.
 218         * ser-base.c: Same.
 219         * ser-go32.c: Same.
 220         * skip.c: Same.
 221         * sol-thread.c: Same.
 222         * solib-svr4.c: Same.
 223         * solib.c: Same.
 224         * source.c: Same.
 225         * sparc-nat.c: Same.
 226         * sparc-sol2-tdep.c: Same.
 227         * sparc-tdep.c: Same.
 228         * sparc64-tdep.c: Same.
 229         * stabsread.c: Same.
 230         * stack.c: Same.
 231         * symfile.c: Same.
 232         * symtab.c: Same.
 233         * target-descriptions.c: Same.
 234         * target-float.c: Same.
 235         * thread.c: Same.
 236         * utils.c: Same.
 237         * valops.c: Same.
 238         * valprint.c: Same.
 239         * value.c: Same.
 240         * varobj.c: Same.
 241         * windows-nat.c: Same.
 242         * xcoffread.c: Same.
 243         * xstormy16-tdep.c: Same.
 244         * xtensa-tdep.c: Same.
 245
 246 2019-10-17  Tom Tromey  <tromey@adacore.com>
 247
 248         * configure: Rebuild.
 249         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 250         in AC_CONFIG_FILES invocation.
 251         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 252         new-style config.status invocation.
 253
 254 2019-10-17  Tom de Vries  <tdevries@suse.de>
 255
 256         * arm-nbsd-nat.c: Fix typos in comments.
 257         * arm-tdep.c: Same.
 258         * darwin-nat-info.c: Same.
 259         * dwarf2read.c: Same.
 260         * elfread.c: Same.
 261         * event-top.c: Same.
 262         * findvar.c: Same.
 263         * gdbtypes.c: Same.
 264         * hppa-tdep.c: Same.
 265         * i386-tdep.c: Same.
 266         * jit.c: Same.
 267         * main.c: Same.
 268         * mdebugread.c: Same.
 269         * moxie-tdep.c: Same.
 270         * nto-procfs.c: Same.
 271         * osabi.c: Same.
 272         * ppc-linux-tdep.c: Same.
 273         * remote.c: Same.
 274         * riscv-tdep.c: Same.
 275         * s390-tdep.c: Same.
 276         * sh-tdep.c: Same.
 277         * sparc-linux-tdep.c: Same.
 278         * sparc-nat.c: Same.
 279         * stack.c: Same.
 280         * target-descriptions.c: Same.
 281         * top.c: Same.
 282         * varobj.c: Same.
 283
 284 2019-10-16  Tom Tromey  <tom@tromey.com>
 285
 286         * objfiles.h (struct objfile) <original_name>: Now const.
 287
 288 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 289
 290         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 291         pass on to sigsetjmp's second argument.
 292         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 293
 294 2019-10-16  Keith Seitz  <keiths@redhat.com>
 295
 296         PR gdb/23567
 297         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 298         sections whose size is greater than the file size.
 299
 300 2019-10-16  Jim Wilson  <jimw@sifive.com>
 301
 302         * riscv-tdep.c (riscv_gcc_target_options): New.
 303         (riscv_gnu_triplet_regexp): New.
 304         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 305         set_gdbarch_gnu_triplet_regexp.
 306
 307 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 308
 309         * Makefile.in: Add xml-builtin.h.
 310         * features/feature_to_c.sh: Add an include for xml-builtin.h
 311         to ensure that the compiler checks that the types match.
 312         * xml-builtin.h: New file.
 313         * xml-support.c (fetch_xml_builtin): Add missing const.
 314         * xml-support.h: Remove declaration of xml_builtins.
 315
 316 2019-10-16  Tom de Vries  <tdevries@suse.de>
 317
 318         PR tdep/25096
 319         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 320         (amd64_classify_aggregate): ... here.
 321         (amd64_classify_aggregate_field): Handled fiels of nested structs
 322         recursively.
 323
 324 2019-10-16  Tom de Vries  <tdevries@suse.de>
 325
 326         PR tdep/24104
 327         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 328         that handles 'theclass'.
 329
 330 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 331
 332         * linespec.c (decode_digits_ordinary): Update comment.
 333         * make-target-delegates: No longer need to handle VEC case.
 334         * memrange.c (normalize_mem_ranges): Update comment.
 335         * namespace.c (add_using_directive): Update comment.
 336         * objc-lang.c (uniquify_strings): Update comment.
 337         * ppc-linux-nat.c (struct thread_points): Update comment.
 338         * probe.h (find_probes_in_objfile): Update comment.
 339         * target.h (enum flash_preserve_mode): Update comment.
 340         * varobj.c (varobj_restrict_range): Update comment.
 341         * varobj.h (varobj_list_children): Update comment.
 342
 343 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 344
 345         * Makefile.in: Remove references to vec.h and vec.c.
 346         * aarch64-tdep.c: No longer include vec.h.
 347         * ada-lang.c: Likewise.
 348         * ada-lang.h: Likewise.
 349         * arm-tdep.c: Likewise.
 350         * ax.h: Likewise.
 351         * breakpoint.h: Likewise.
 352         * charset.c: Likewise.
 353         * cp-support.h: Likewise.
 354         * dtrace-probe.c: Likewise.
 355         * dwarf2read.c: Likewise.
 356         * extension.h: Likewise.
 357         * gdb_bfd.c: Likewise.
 358         * gdbsupport/gdb_vecs.h: Likewise.
 359         * gdbsupport/vec.c: Remove.
 360         * gdbsupport/vec.h: Remove.
 361         * gdbthread.h: Likewise.
 362         * guile/scm-type.c: Likewise.
 363         * inline-frame.c: Likewise.
 364         * machoread.c: Likewise.
 365         * memattr.c: Likewise.
 366         * memrange.h: Likewise.
 367         * namespace.h: Likewise.
 368         * nat/linux-btrace.h: Likewise.
 369         * osdata.c: Likewise.
 370         * parser-defs.h: Likewise.
 371         * progspace.h: Likewise.
 372         * python/py-type.c: Likewise.
 373         * record-btrace.c: Likewise.
 374         * rust-exp.y: Likewise.
 375         * solib-target.c: Likewise.
 376         * stap-probe.c: Likewise.
 377         * target-descriptions.c: Likewise.
 378         * target-memory.c: Likewise.
 379         * target.h: Likewise.
 380         * varobj.c: Likewise.
 381         * varobj.h: Likewise.
 382         * xml-support.h: Likewise.
 383
 384 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 385
 386         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 387         Update for new std::vector based implementation.
 388         (process_psymtab_comp_unit_reader): Likewise.
 389         (scan_partial_symbols): Likewise.
 390         (recursively_compute_inclusions): Likewise.
 391         (compute_compunit_symtab_includes): Likewise.
 392         (process_imported_unit_die): Likewise.
 393         (queue_and_load_dwo_tu): Likewise.
 394         (follow_die_sig_1): Likewise.
 395         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 396         (typedef dwarf2_per_cu_ptr): Remove.
 397         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 398         function.
 399         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 400         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 401         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 402         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 403         std::vector.
 404
 405 2019-10-15  Tom Tromey  <tromey@adacore.com>
 406
 407         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 408         TID.
 409
 410 2019-10-15  Tom Tromey  <tromey@adacore.com>
 411
 412         * windows-nat.c (windows_nat_target::fetch_registers)
 413         (windows_nat_target::store_registers): Rename "pid" to "tid".
 414
 415 2019-10-15  Tom Tromey  <tromey@adacore.com>
 416
 417         * gdbarch.h, gdbarch.c: Rebuild.
 418         * gdbarch.sh (gcc_target_options): Change return type to
 419         std::string.
 420         * compile/compile.c (get_args): Update.
 421         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 422         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 423         std::string.
 424         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 425         std::string.
 426         * arch-utils.c (default_gcc_target_options): Return std::string.
 427         * arch-utils.h (default_gcc_target_options): Return std::string.
 428         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 429
 430 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 431
 432         * breakpoint.c (breakpoint_chain): Make static.
 433         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 434         of accessing breakpoint_chain.
 435
 436 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 437
 438         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 439         to a gdb::function_view and return value to bool.
 440         * breakpoint.h (iterate_over_breakpoints): Likewise.
 441         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 442         (pop_dummy_frame): Update.
 443         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 444         (gdbscm_breakpoints): Update.
 445         * python/py-breakpoint.c (build_bp_list): Update.
 446         (gdbpy_breakpoints): Update.
 447         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 448         Update.
 449         (bpfinishpy_handle_stop): Update.
 450         (bpfinishpy_handle_exit): Update.
 451         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 452         (svr4_update_solib_event_breakpoints): Update.
 453
 454 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 455
 456         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 457         when unwrapping single-field structs.
 458
 459 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 460
 461         * dwarf2read.c: Remove includes.
 462
 463 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 464
 465         * ui-out.c (ui_out::call_do_message): Silence
 466         -Wformat-nonliteral warning.
 467
 468 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 469
 470         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 471         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 472         include: readline/tilde.h.
 473
 474 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 475
 476         * remote.c (remote_target::get_trace_status): Remove declaration of
 477         trace_regblock_size.
 478
 479 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 480
 481         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 482         (show_user): Remove declaration of cmdlist.
 483         * cli/cli-cmds.h (max_user_call_depth): Declare.
 484         * cli/cli-script.c (execute_user_command): Remove declaration
 485         of max_user_call_depth.
 486
 487 2019-10-11  Jim Wilson  <jimw@sifive.com>
 488
 489         * gdbsupport/print-utils.h (pulongest): Fix comment.
 490         (plongest): Likewise.
 491         (phex): Add missing comment, mention leading zeros.
 492         (phex_nz): Add mention of no leading zeros to comment.
 493
 494         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 495         plongest instead of unsigned long long cast.
 496
 497 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 498
 499         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 500         for external_editor_command and gdbtk_test.
 501
 502 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 503
 504         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 505         * varobj.c (varobjdebug): Move comment to...
 506         * varobj.h (varobjdebug): ...here, and declare.
 507
 508 2019-10-09  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 511         erase_data_content.
 512
 513 2019-10-09  Tom Tromey  <tom@tromey.com>
 514
 515         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 516         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 517         * tui/tui-command.c (tui_cmd_window::resize)
 518         (tui_refresh_cmd_win): Update.
 519         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 520         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 521         * tui/tui-data.c (~tui_gen_win_info): Remove.
 522         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 523         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 524         (tui_redisplay_readline, tui_mld_flush)
 525         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 526         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 527         (tui_data_window::erase_data_content)
 528         (tui_data_item_window::rerender)
 529         (tui_data_item_window::refresh_window): Update.
 530         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 531         (box_win, tui_gen_win_info::make_window)
 532         (tui_gen_win_info::make_visible): Update.
 533         (tui_delete_win): Remove.
 534         * tui/tui-winsource.c
 535         (tui_source_window_base::do_erase_source_content): Update.
 536         (tui_show_source_line, tui_source_window_base::update_tab_width)
 537         (tui_source_window_base::update_exec_info): Update.
 538         * tui/tui-data.h (struct curses_deleter): New.
 539         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 540         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 541
 542 2019-10-09  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 545
 546 2019-10-09  Tom Tromey  <tom@tromey.com>
 547
 548         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 549         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 550
 551 2019-10-09  Tom Tromey  <tom@tromey.com>
 552
 553         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 554         window height directly.
 555         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 556         declare.
 557         * tui/tui-layout.c (tui_default_win_height): Remove.
 558         (tui_default_win_viewport_height): Remove.
 559
 560 2019-10-09  Tom Tromey  <tom@tromey.com>
 561
 562         * tui/tui.h: Remove comments.
 563
 564 2019-10-09  Tom de Vries  <tdevries@suse.de>
 565
 566         * python/lib/gdb/printer/bound_registers.py: Use
 567         '^builtin_type_bound128' as regexp argument for
 568         add_builtin_pretty_printer.
 569
 570 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 571
 572         * guile/guile.c (guile_extension_script_ops): Remove forward
 573         declaration and mark as static.
 574         (guile_script_ops): Likewise.
 575         (extension_language_guile): Move further down in the file so
 576         it can reference the definitions for guile_{extension_,}script_ops.
 577
 578 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 579
 580         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 581         except SORTL, DFLTCC, and KDSA.
 582
 583 2019-10-08  Tom Tromey  <tromey@adacore.com>
 584
 585         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 586         (struct safe_symbol_file_add_args): Remove.
 587
 588 2019-10-08  Tom Tromey  <tromey@adacore.com>
 589
 590         * windows-nat.c: Don't include buildsym-legacy.h.
 591
 592 2019-10-08  Tom Tromey  <tromey@adacore.com>
 593
 594         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 595
 596 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 597
 598         * gdbtypes.c (overload_debug): Move comment to header.
 599         * gdbtypes.h (overload_debug): Declare.
 600         * valops.c: Remove declaration of overload_debug, instead
 601         include gdbtypes.h.
 602
 603 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 604
 605         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 606         through _().
 607         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 608         move comment...
 609         * language.h (lang_frame_mismatch_warn): ... here. Also add
 610         declaration.
 611         * top.c (lang_frame_mismatch_warn): Remove declaration.
 612         (check_frame_language_change): Pass lang_frame_mismatch_warn
 613         through _().
 614
 615 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 616
 617         * c-lang.h (vtbl_ptr_name): Declare.
 618         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 619         it from the header.
 620         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 621
 622 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 623
 624         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 625         gdb_static_assert.
 626
 627 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 628
 629         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 630         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 631         * ctfread.c: New file.
 632         * ctfread.h: New file.
 633         * elfread.c: Include ctfread.h.
 634         (struct elfinfo text_p): New member ctfsect.
 635         (elf_locate_sections): Mark CTF section.
 636         (elf_symfile_read): Call elfctf_build_psymtabs.
 637         * Makefile.in (LIBCTF): Add.
 638         (CLIBS): Use it.
 639         (CDEPS): Likewise.
 640         (DIST): Add ctfread.c.
 641
 642 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 643
 644         * ctfread.c (struct nextfield): Renamed to ...
 645         (struct ctf_nextfield): ... this.
 646         (struct field_info): Renamed to ...
 647         (strut ctf_field_info): ... this.
 648         (attach_fields_to_type): Update for renamed structures.
 649         (ctf_add_member_cb): Likewise.
 650         (ctf_add_enum_member_cb): Likewise.
 651         (process_struct_members): Likewise.
 652         (process_enum_type): Likewise.
 653
 654 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 655
 656         * tracectf.h: Rename, was ctf.h.
 657         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 658         * tracefile.c: Likewise.
 659         * tracepoint.c: Remove unused include ctf.h.
 660         * mi/mi-main.c: Likewise.
 661         * Makefile.in Replace ctf.c with tracectf.c.
 662
 663 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 664
 665         * version.in: Change version number to "9.0.50.DATE-git".
 666
 667 2019-10-03  Tom Tromey  <tom@tromey.com>
 668
 669         PR rust/24976:
 670         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 671
 672 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 673
 674         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 675         cp_search_name_hash.
 676         * NEWS: Add entry about nested function support.
 677
 678 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 679             Andrew Burgess  <andrew.burgess@embecosm.com>
 680
 681         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 682         for nested static variables when searchin VAR_DOMAIN.
 683         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 684         global scope, update comment.
 685         (add_partial_subprogram): Call add_partial_subprogram recursively
 686         for nested subroutines when processinng Fortran.
 687         (load_partial_dies): Process the child entities of a subprogram
 688         when processing Fortran.
 689         (partial_die_parent_scope): Handle building scope
 690         for Fortran nested functions.
 691         (process_die): Record that nested functions have a scope.
 692         (new_symbol): Always record Fortran subprograms on the global
 693         symbol list.
 694         (determine_prefix): How to build the prefix for Fortran
 695         subprograms.
 696
 697 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 698
 699         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 700         have just sent the thread a SIGSTOP and are waiting for it to
 701         arrive.
 702
 703 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 704
 705         * btrace.c (btrace_add_pc): Remove whitespace before the template
 706         parameter in 'std::vector <...>'.
 707         (parse_xml_btrace_block): Likewise.
 708         (btrace_maint_decode_pt): Likewise.
 709         (btrace_maint_update_packets): Likewise.
 710         (btrace_maint_print_packets): Likewise.
 711         * btrace.h (struct btrace_maint_info): Likewise.
 712         * dwarf2read.c (struct type_unit_group): Likewise.
 713         (build_type_psymtabs_reader): Likewise.
 714         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 715         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 716         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 717
 718 2019-10-03  Tom de Vries  <tdevries@suse.de>
 719
 720         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 721         the first line of the help text for set/show style metadata.
 722
 723 2019-10-02  Tom Tromey  <tromey@adacore.com>
 724
 725         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 726         * gdbsupport/common-inferior.c: New file.
 727         * infcmd.c (startup_with_shell): Don't define.
 728         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 729         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 730         * inferior.h (startup_with_shell): Don't declare.
 731
 732 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 733
 734         * gdbsupport/gdb_assert.h: Include errors.h.
 735         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 736
 737 2019-10-02  Tom Tromey  <tromey@adacore.com>
 738
 739         * NEWS: Add $_ada_exception entry.
 740         * ada-lang.c (struct ada_catchpoint): Add constructor.
 741         <m_kind>: New member.
 742         (allocate_location_exception, re_set_exception): Remove
 743         "ex" parameter.
 744         (should_stop_exception): Compute $_ada_exception.
 745         (check_status_exception, print_it_exception)
 746         (print_one_exception, print_mention_exception): Remove
 747         "ex" parameter.
 748         (allocate_location_catch_exception, re_set_catch_exception)
 749         (check_status_exception, print_it_catch_exception)
 750         (print_one_catch_exception, print_mention_catch_exception)
 751         (print_recreate_catch_exception)
 752         (allocate_location_catch_exception_unhandled)
 753         (re_set_catch_exception_unhandled)
 754         (check_status_exception, print_it_catch_exception_unhandled)
 755         (print_one_catch_exception_unhandled)
 756         (print_mention_catch_exception_unhandled)
 757         (print_recreate_catch_exception_unhandled)
 758         (allocate_location_catch_assert, re_set_catch_assert)
 759         (check_status_assert, print_it_catch_assert)
 760         (print_one_catch_assert, print_mention_catch_assert)
 761         (print_recreate_catch_assert)
 762         (allocate_location_catch_handlers, re_set_catch_handlers)
 763         (check_status_handlers, print_it_catch_handlers)
 764         (print_one_catch_handlers, print_mention_catch_handlers)
 765         (print_recreate_catch_handlers): Remove.
 766         (create_ada_exception_catchpoint): Update.
 767         (initialize_ada_catchpoint_ops): Update.
 768
 769 2019-10-02  Tom Tromey  <tromey@adacore.com>
 770
 771         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 772         (create_excep_cond_exprs): Simplify exception string computation.
 773         (ada_exception_catchpoint_cond_string): Likewise.
 774
 775 2019-10-02  Tom Tromey  <tromey@adacore.com>
 776
 777         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 778         * ada-lang.c (lesseq_defined_than): Handle
 779         LOC_STATIC.
 780         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 781         parameter.
 782         (dwarf2_has_info): Likewise.
 783         (new_symbol): Set maybe_copied on symbol when
 784         appropriate.
 785         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 786         parameter.
 787         <can_copy>: New member.
 788         * elfread.c (record_minimal_symbol): Set maybe_copied
 789         on symbol when appropriate.
 790         (elf_symfile_read): Update call to dwarf2_has_info.
 791         * minsyms.c (lookup_minimal_symbol_linkage): New
 792         function.
 793         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 794         * symtab.c (get_symbol_address, get_msymbol_address):
 795         New functions.
 796         * symtab.h (get_symbol_address, get_msymbol_address):
 797         Declare.
 798         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 799         maybe_copied.
 800         (struct symbol, struct minimal_symbol) <maybe_copied>:
 801         New member.
 802
 803 2019-10-02  Tom Tromey  <tromey@adacore.com>
 804
 805         * source.c (struct current_source_location): New.
 806         (current_source_key): New global.
 807         (current_source_symtab, current_source_line)
 808         (current_source_pspace): Remove.
 809         (get_source_location): New function.
 810         (get_current_source_symtab_and_line)
 811         (set_default_source_symtab_and_line)
 812         (set_current_source_symtab_and_line)
 813         (clear_current_source_symtab_and_line, select_source_symtab)
 814         (info_source_command, print_source_lines_base)
 815         (info_line_command, search_command_helper, _initialize_source):
 816         Update.
 817
 818 2019-10-02  Tom Tromey  <tromey@adacore.com>
 819
 820         * source.c (select_source_symtab): Don't call
 821         decode_line_with_current_source.
 822
 823 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 824
 825         * symtab.c (lookup_global_symbol): Search global block.
 826
 827 2019-10-02  Tom Tromey  <tromey@adacore.com>
 828
 829         * coffread.c (process_coff_symbol): Update.
 830         * dwarf2read.c (var_decode_location, new_symbol): Update.
 831         * mdebugread.c (parse_symbol): Update.
 832         * objfiles.c (relocate_one_symbol): Update.
 833         * stabsread.c (define_symbol, fix_common_block)
 834         (scan_file_globals): Update.
 835         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 836         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 837         * xcoffread.c (process_xcoff_symbol): Update.
 838
 839 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 840
 841         * MAINTAINERS: Update my email address.
 842
 843 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 844
 845         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 846         std::vector.
 847         (build_type_psymtabs_reader): Update for std::vector.
 848         (build_type_psymtab_dependencies): Likewise.
 849         * dwarf2read.h: Remove use of DEF_VEC_P.
 850         (typedef sig_type_ptr): Delete.
 851
 852 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 853
 854         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 855         to std::vector.
 856         (btrace_maint_decode_pt): Likewise, and move allocation of the
 857         vector outside of the loop.
 858         (btrace_maint_update_packets): Update to handle change from VEC to
 859         std::vector.
 860         (btrace_maint_print_packets): Likewise.
 861         (maint_info_btrace_cmd): Likewise.
 862         * btrace.h: Remove use of DEF_VEC_O.
 863         (typedef btrace_pt_packet_s): Delete.
 864         (struct btrace_maint_info) <packets>: Change fromm VEC to
 865         std::vector.
 866         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 867
 868 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 869
 870         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 871         make accesses into the vector constant references.
 872         (btrace_add_pc): Update for std::vector.
 873         (btrace_stitch_bts): Likewise.
 874         (parse_xml_btrace_block): Likewise.
 875         (btrace_maint_update_packets): Likewise.
 876         (btrace_maint_print_packets): Likewise.
 877         (maint_info_btrace_cmd): Likewise.
 878         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 879         std::vector.
 880         (btrace_data::empty): Likewise.
 881         (btrace_data_append): Likewise.
 882         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 883         (typedef btrace_block_s): Delete.
 884         (struct btrace_block): Add constructor.
 885         (struct btrace_data_bts) <blocks>: Change to std::vector.
 886         * nat/linux-btrace.c (perf_event_read_bts): Update for
 887         std::vector.
 888         (linux_read_bts): Likewise.
 889
 890 2019-10-01  Tom Tromey  <tom@tromey.com>
 891
 892         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 893
 894 2019-10-01  Tom Tromey  <tom@tromey.com>
 895
 896         * stack.c (print_frame, info_frame_command_core): Use
 897         styled_string.
 898         * linux-thread-db.c (try_thread_db_load_1)
 899         (try_thread_db_load_from_pdir_1): Use styled_string.
 900         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 901         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 902         (maybe_print_unsupported_script_warning)
 903         (maybe_print_script_not_found_warning): Use styled_string.
 904         * ada-lang.c (user_select_syms): Use styled_string.
 905
 906 2019-10-01  Tom Tromey  <tom@tromey.com>
 907
 908         * p-lang.c (pascal_printstr): Use metadata style.
 909         * value.c (show_convenience): Use metadata style.
 910         * valprint.c (valprint_check_validity, val_print_optimized_out)
 911         (val_print_not_saved, val_print_unavailable)
 912         (val_print_invalid_address, generic_val_print, val_print)
 913         (value_check_printable, val_print_array_elements): Use metadata
 914         style.
 915         * ui-out.h (class ui_out) <field_fmt>: New overload.
 916         <do_field_fmt>: Add style parameter.
 917         * ui-out.c (ui_out::field_fmt): New overload.
 918         * typeprint.c (type_print_unknown_return_type)
 919         (val_print_not_allocated, val_print_not_associated): Use metadata
 920         style.
 921         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 922         parameter.
 923         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 924         * tracepoint.c (tvariables_info_1): Use metadata style.
 925         * stack.c (print_frame_arg, print_frame_info, print_frame)
 926         (info_frame_command_core): Use metadata style.
 927         * skip.c (info_skip_command): Use metadata style.
 928         * rust-lang.c (rust_print_enum): Use metadata style.
 929         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 930         metadata style.
 931         * python/py-framefilter.c (py_print_single_arg): Use metadata
 932         style.
 933         * printcmd.c (do_one_display, print_variable_and_value): Use
 934         metadata style.
 935         * p-valprint.c (pascal_val_print)
 936         (pascal_object_print_value_fields): Use metadata style.
 937         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 938         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 939         parameter.
 940         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 941         * m2-valprint.c (m2_print_long_set): Use metadata style.
 942         * m2-typeprint.c (m2_print_type): Use metadata style.
 943         * infcmd.c (print_return_value_1): Use metadata style.
 944         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 945         * f-valprint.c (info_common_command_for_block): Use metadata
 946         style.
 947         * f-typeprint.c (f_type_print_base): Use metadata style.
 948         * expprint.c (print_subexp_standard): Use metadata style.
 949         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 950         * cli/cli-style.h (class cli_style_option): Add constructor.
 951         (metadata_style): Declare.
 952         * cli/cli-style.c (metadata_style): New global.
 953         (_initialize_cli_style): Register metadata style.
 954         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 955         parameter.
 956         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 957         * c-typeprint.c (c_type_print_base_struct_union)
 958         (c_type_print_base_1): Use metadata style.
 959         * breakpoint.c (watchpoint_value_print)
 960         (print_one_breakpoint_location): Use metadata style.
 961         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 962         style.
 963         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 964         style.
 965         * ada-valprint.c (val_print_packed_array_elements, printstr)
 966         (print_field_values, ada_val_print_ref, ada_val_print): Use
 967         metadata style.
 968         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 969         style.
 970         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 971         style.
 972         * ada-lang.c (user_select_syms): Use metadata style.
 973
 974 2019-10-01  Tom Tromey  <tom@tromey.com>
 975
 976         * cli/cli-cmds.c (pwd_command): Style output.
 977
 978 2019-10-01  Pedro Alves  <palves@redhat.com>
 979             Tom Tromey  <tom@tromey.com>
 980
 981         * symtab.c (print_symbol_info): Use %ps.
 982         (print_msymbol_info): Use %ps.
 983         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 984         * printcmd.c (print_variable_and_value): Use %ps.
 985         * macrocmd.c (show_pp_source_pos): Use %ps.
 986         * infrun.c (print_exited_reason): Use ui_out::message.
 987         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 988         (describe_other_breakpoints): Use ui_out::message and new
 989         formats.
 990         (say_where): Use new formats.
 991         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 992         and new formats.
 993
 994 2019-10-01  Pedro Alves  <palves@redhat.com>
 995             Tom Tromey  <tom@tromey.com>
 996
 997         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 998         (test_gdb_formats): New function.
 999         (run_tests): Call it.
1000         (test_format_specifier): Update.
1001         * utils.h (fputs_filtered): Update comment.
1002         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1003         (fputs_styled_unfiltered): Declare.
1004         * utils.c (fputs_styled_unfiltered): New function.
1005         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1006         (vfprintf_filtered): Update.
1007         (vfprintf_unfiltered, vprintf_filtered): Update.
1008         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1009         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1010         disallow_ui_out_field>: New constants.
1011         (enum class field_kind): New.
1012         (struct base_field_s, struct signed_field_s): New.
1013         (signed_field): New function.
1014         (struct string_field_s): New.
1015         (string_field): New function.
1016         (struct styled_string_s): New.
1017         (styled_string): New function.
1018         (class ui_out) <message>: Add comment.
1019         <vmessage, call_do_message>: New methods.
1020         <do_message>: Add style parameter.
1021         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1022         methods.
1023         (ui_out::message): Rewrite.
1024         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1025         parameter.
1026         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1027         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1028         gdb_extensions parameter.
1029         (class format_piece): Add parameter to constructor.
1030         (n_int_args): New field.
1031         * gdbsupport/format.c (format_pieces::format_pieces): Add
1032         gdb_extensions parameter.  Handle '*'.
1033         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1034         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1035         vfprintf_styled_no_gdbfmt.
1036         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1037         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1038         unfiltered output.
1039         * ui-style.h (struct ui_file_style) <ptr>: New method.
1040
1041 2019-10-01  Tom Tromey  <tom@tromey.com>
1042
1043         * unittests/format_pieces-selftests.c: Update.  Add final format.
1044         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1045         empty literal pieces.
1046
1047 2019-10-01  Tom Tromey  <tom@tromey.com>
1048
1049         * ui-out.h (enum class ui_out_style_kind): Remove.
1050         (class ui_out) <field_string, field_stsream, do_field_string>:
1051         Change type of "style".
1052         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1053         (ui_out::field_string): Update.
1054         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1055         of "style".
1056         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1057         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1058         * stack.c (print_frame_arg, print_frame_info, print_frame):
1059         Update.
1060         * source.c (print_source_lines_base): Update.
1061         * solib.c (info_sharedlibrary_command): Update.
1062         * skip.c (info_skip_command): Update.
1063         * record-btrace.c (btrace_call_history_src_line)
1064         (btrace_call_history): Update.
1065         * python/py-framefilter.c (py_print_frame): Update.
1066         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1067         "style".
1068         * mi/mi-out.c (mi_ui_out::do_table_header)
1069         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1070         (mi_ui_out::do_field_string): Update.
1071         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1072         Update.
1073         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1074         "style".
1075         * cli-out.c (cli_ui_out::do_table_header)
1076         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1077         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1078         (cli_ui_out::do_field_fmt): Update.
1079         * breakpoint.c (print_breakpoint_location): Update.
1080         (update_static_tracepoint): Update.
1081
1082 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1083
1084         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1085         conversion of gdb_datadir.
1086         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1087         remove not needed c_str ().
1088
1089 2019-09-30  Ali Tamur <tamur@google.com>
1090
1091         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1092         (dwarf2_string_attr): Likewise.
1093
1094 2019-09-30  Ali Tamur <tamur@google.com>
1095
1096         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1097         (process_full_type_unit): Likewise.
1098         (dump_die_shallow): Likewise.
1099         (cu_debug_loc_section): Likewise.
1100
1101 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1102
1103         * minsyms.c (compare_minimal_symbols): Rename to...
1104         (minimal_symbol_is_less_than): ...this, and adjust to STL
1105         conventions (return bool, take arguments as references)
1106         (minimal_symbol_reader::install): Call std::sort instead
1107         of qsort.
1108
1109 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1110
1111         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1112         hash and why.
1113         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1114         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1115
1116 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1117
1118         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1119         * psympriv.h (add_psymbol_to_list): Move comment here and update
1120         it.
1121
1122 2019-09-29  Tom de Vries  <tdevries@suse.de>
1123
1124         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1125         Use $tmpdir/$(basename "$output_file").dwz instead of
1126         "${output_file}.dwz".
1127
1128 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1129
1130         PR gdb/25045
1131         * hppa-linux-nat.c: Include gdbarch.h.
1132
1133 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1134
1135         * blockframe.c (find_pc_partial_function): Change return type to bool.
1136         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1137         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1138         (stub_gnu_ifunc_resolve_name): Likewise.
1139         * symtab.c (compare_filenames_for_search): Likewise.
1140         (compare_glob_filenames_for_search): Likewise.
1141         (matching_obj_sections): Likewise.
1142         (symbol_matches_domain): Likewise.
1143         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1144         (find_line_pc): Change return type to bool.
1145         (find_line_pc_range): Likewise.
1146         (producer_is_realview): Likewise.
1147         * symtab.h (symbol_matches_domain): Likewise.
1148         (find_pc_partial_function): Likewise.
1149         (find_pc_line_pc_range): Likewise.
1150         (in_gnu_ifunc_stub): Likewise.
1151         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1152         (find_line_pc): Likewise.
1153         (find_line_pc_range): Likewise.
1154         (matching_obj_sections): Likewise.
1155         (find_line_symtab): Change out parameter to bool.
1156         (producer_is_realview): Change return type to bool.
1157         (compare_filenames_for_search): Likewise.
1158         (compare_glob_filenames_for_search): Likewise.
1159
1160 2019-09-26  Tom Tromey  <tom@tromey.com>
1161
1162         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1163         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1164         * gdb_usleep.h: Remove.
1165         * gdb_usleep.c: Remove.
1166         * utils.c: Don't include gdb_usleep.h.
1167
1168 2019-09-26  Tom Tromey  <tromey@adacore.com>
1169
1170         * python/py-type.c (type_to_type_object): Call check_typedef
1171         for stub types.
1172
1173 2019-09-26  Tom Tromey  <tom@tromey.com>
1174
1175         * utils.h (initialize_utils): Don't declare.
1176         * top.c (gdb_init): Don't call initialize_utils.
1177         * utils.c (initialize_utils): Remove.  Move contents...
1178         (_initialize_utils): ... here.
1179
1180 2019-09-25  Tom Tromey  <tom@tromey.com>
1181
1182         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1183         * utils.h (make_hex_string): Don't declare.
1184         * utils.c (make_hex_string): Remove.
1185
1186 2019-09-24  Tom de Vries  <tdevries@suse.de>
1187
1188         PR gdb/23815
1189         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1190         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1191
1192 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1193
1194         * NEWS: Mention new simulator port for PRU.
1195
1196 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1197
1198         * ada-exp.y (write_object_remaining): Update.
1199         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1200         and eliminate the static buffer.
1201         (ada_decode_symbol): Update.
1202         (ada_la_decode): Update.
1203         (ada_sniff_from_mangled_name): Update.
1204         (is_valid_name_for_wild_match): Update.
1205         (ada_lookup_name_info::matches): Update and simplify.
1206         (name_matches_regex): Update.
1207         (ada_add_global_exceptions): Update.
1208         * ada-lang.h (ada_decode): Update signature.
1209         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1210         * dwarf-index-write.c (debug_names::insert): Update.
1211
1212 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1213
1214         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1215         formatting.
1216
1217 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1218
1219         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1220         Change "nonzero" to "true" in documentation.
1221
1222 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1223
1224         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1225         (_initialize_darwin_solib): Don't set
1226         darwin_so_ops.lookup_lib_global_symbol.
1227         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1228         set_gdbarch_iterate_over_objfiles_in_search_order.
1229         (elf_lookup_lib_symbol): Rename to...
1230         (svr4_iterate_over_objfiles_in_search_order): this, and update
1231         to iterate semantics.
1232         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1233         * solib.c (solib_global_lookup): Remove.
1234         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1235         (solib_global_lookup): Remove.
1236         * symtab.c (lookup_global_or_static_symbol): Remove call to
1237         solib_global_lookup.
1238
1239 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1240
1241         * NEWS: Move entries about default MI version now being
1242         version 3, and about the GDB/MI fix for multi-location
1243         breakpoints to the "since GDB 8.3" section.
1244
1245 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1246
1247         GDB 8.3.1 released.
1248
1249 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1250
1251         * NEWS: Mention that Cell/B.E. debugging support was removed.
1252         * MAINTAINERS: Remove spu target.
1253
1254         * config/djgpp/fnchange.lst: Remove entries for removed files.
1255
1256         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1257         spu-multiarch.o, and spu-tdep.o.
1258         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1259         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1260         spu-multiarch.c, and spu-tdep.c.
1261         * spu-linux-nat.c: Remove file.
1262         * spu-multiarch.c: Remove file.
1263         * spu-tdep.c: Remove file.
1264         * spu-tdep.h: Remove file.
1265         * solib-spu.c: Remove file.
1266         * solib-spu.h: Remove file.
1267
1268         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1269         * configure.nat (spu-linux): Remove.
1270         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1271         solib-multiarch.o from gdb_target_obs.
1272         (spu*-*-*): Remove.
1273
1274         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1275         feature flag.
1276         (ppc_linux_no_features): Update.
1277         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1278         Cell/B.E. support.
1279         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1280         (tdesc_powerpc_cell64l): Likewise.
1281         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1282         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1283         Cell/B.E. support.
1284         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1285         Do not include "features/rs6000/powerpc-cell32l.c" or
1286         "features/rs6000/powerpc-cell64l.c".
1287         (ppc_linux_spu_section): Remove.
1288         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1289         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1290         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1291         (ppc_linux_spe_context_lookup): Remove.
1292         (ppc_linux_spe_context_inferior_created): Remove.
1293         (ppc_linux_spe_context_solib_loaded): Remove.
1294         (ppc_linux_spe_context_solib_unloaded): Remove.
1295         (ppc_linux_spe_context): Remove.
1296         (struct ppu2spu_cache): Remove.
1297         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1298         (struct ppu2spu_data): Remove.
1299         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1300         ppu2spu_unwind): Remove.
1301         (ppc_linux_init_abi): Remove Cell/B.E. support.
1302         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1303
1304         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1305         (rs6000/powerpc-cell64l-expedite): Likewise
1306         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1307         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1308         rs6000/powerpc-cell64l.xml.
1309         * features/rs6000/powerpc-cell32l.xml: Remove.
1310         * features/rs6000/powerpc-cell64l.xml: Likewise.
1311         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1312         * features/rs6000/powerpc-cell64l.c: Likewise.
1313         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1314         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1315         * regformats/reg-spu.dat: Remove.
1316
1317         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1318         * corelow.c (struct spuid_list): Remove.
1319         (add_to_spuid_list): Remove.
1320         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1321         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1322         (remote_protocol_features): Remove associated entries.
1323         (_initialize_remote): No longer initialize them.
1324         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1325         * linux-nat.c (SPUFS_MAGIC): Remove.
1326         (linux_proc_xfer_spu): Remove.
1327         (spu_enumerate_spu_ids): Remove.
1328         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1329         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1330         (linux_make_corefile_notes): No longer call it.
1331
1332         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1333         (cooked_write_test): Likewise.
1334
1335 2019-09-20  Tom Tromey  <tom@tromey.com>
1336
1337         * NEWS: Mention case-sensitivity of TUI commands.
1338         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1339         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1340         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1341
1342 2019-09-20  Tom Tromey  <tom@tromey.com>
1343
1344         * tui/tui-source.c (tui_source_window::set_contents): Use
1345         make_unique_xstrdup.
1346         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1347         make_unique_xstrdup.
1348
1349 2019-09-20  Tom Tromey  <tom@tromey.com>
1350
1351         * tui/tui-data.c: Remove separator comments.
1352         * tui/tui-layout.c: Remove separator comments.
1353         * tui/tui-win.c: Remove separator comments.
1354         * tui/tui-wingeneral.c: Remove separator comments.
1355
1356 2019-09-20  Tom Tromey  <tom@tromey.com>
1357
1358         * tui/tui.h (strcat_to_buf): Don't declare.
1359         * tui/tui.c (strcat_to_buf): Remove.
1360
1361 2019-09-20  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1364         from "fullname".
1365         * tui/tui-source.c (tui_source_window::set_contents)
1366         (tui_source_window::location_matches_p)
1367         (tui_source_window::maybe_update): Update.
1368
1369 2019-09-20  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1372         Update.
1373         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1374         prefix.
1375         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1376         (tui_data_window::line_from_reg_element_no)
1377         (tui_data_window::first_reg_element_no_inline)
1378         (tui_data_window::show_registers)
1379         (tui_data_window::show_register_group)
1380         (tui_data_window::display_registers_from)
1381         (tui_data_window::display_registers_from_line)
1382         (tui_data_window::first_data_item_displayed)
1383         (tui_data_window::delete_data_content_windows)
1384         (tui_data_window::erase_data_content)
1385         (tui_data_window::do_scroll_vertical)
1386         (tui_data_window::refresh_window)
1387         (tui_data_window::check_register_values): Update.
1388
1389 2019-09-20  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1392         (struct tui_locator_window) <full_name, proc_name>: Now
1393         std::string.
1394         * tui/tui-stack.c (tui_locator_window::make_status_line)
1395         (tui_locator_window::set_locator_fullname)
1396         (tui_locator_window::set_locator_info): Update.
1397         * tui/tui-source.c (tui_source_window::set_contents)
1398         (tui_source_window::showing_source_p): Update.
1399
1400 2019-09-20  Tom Tromey  <tom@tromey.com>
1401
1402         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1403         Don't call tui_locator_win_info_ptr.
1404
1405 2019-09-20  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1408
1409 2019-09-20  Tom Tromey  <tom@tromey.com>
1410
1411         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1412         height for locator.
1413         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1414         * tui/tui-layout.c (show_source_disasm_command, show_data)
1415         (show_source_or_disasm_and_command): Use 1 as height for locator.
1416
1417 2019-09-20  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui.c (tui_enable): Update.
1420         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1421         Update.
1422         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1423         Update.
1424         * tui/tui-data.c (win_resized): Now bool.
1425         (tui_win_resized): Return bool.
1426         (tui_set_win_resized_to): Accept a bool.
1427
1428 2019-09-20  Tom Tromey  <tom@tromey.com>
1429
1430         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1431         Change type of "refresh_values_only".
1432         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1433         type of "refresh_values_only".
1434
1435 2019-09-20  Tom Tromey  <tom@tromey.com>
1436
1437         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1438         std::string.
1439         (tui_disassemble): Add "pos" parameter.
1440         (tui_disasm_window::set_contents): Simplify.
1441
1442 2019-09-20  Tom Tromey  <tom@tromey.com>
1443
1444         * tui/tui-winsource.h (struct tui_source_window_base)
1445         <show_source_content>: Now private.
1446         * tui/tui-winsource.c
1447         (tui_source_window_base::show_source_content): Don't handle empty
1448         content case.
1449
1450 2019-09-20  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-layout.c (show_source_disasm_command)
1453         (show_source_or_disasm_and_command): Don't call
1454         show_source_content.
1455
1456 2019-09-20  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1459         Declare.
1460         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1461         from tui_make_status_line.
1462         (tui_locator_window::rerender): Update.
1463
1464 2019-09-20  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1467         (tui_locator_window::rerender): Update.
1468
1469 2019-09-20  Tom Tromey  <tom@tromey.com>
1470
1471         * tui/tui-winsource.h (struct tui_source_window_base)
1472         <~tui_source_window_base>: Don't declare.
1473         <fullname>: Remove.
1474         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1475         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1476         member.
1477         * tui/tui-source.c (tui_source_window::set_contents): Update.
1478         (tui_source_window::location_matches_p)
1479         (tui_source_window::maybe_update): Update.
1480
1481 2019-09-20  Tom Tromey  <tom@tromey.com>
1482
1483         * tui/tui-winsource.h (~tui_source_element): Remove.
1484         (tui_source_element): Update.
1485         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1486         * tui/tui-winsource.c (tui_show_source_line): Update.
1487         * tui/tui-source.c (tui_source_window::set_contents): Update.
1488         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1489
1490 2019-09-20  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1493         declare.
1494         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1495         tui_clear_source_windows_detail.
1496         * tui/tui-winsource.h (struct tui_source_window_base)
1497         <clear_detail>: Don't declare.
1498         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1499         Remove.
1500         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1501
1502 2019-09-20  Tom Tromey  <tromey@adacore.com>
1503
1504         PR ada/24919:
1505         * block.c (contained_in): Fix final return value.
1506
1507 2019-09-20  Alan Modra  <amodra@gmail.com>
1508
1509         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1510         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1511         (read_indirect_string_from_dwz): Use bfd accessor.
1512         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1513         * machoread.c (macho_symfile_read_all_oso): Likewise.
1514         * solib.c (solib_bfd_open): Likewise.
1515
1516 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1517
1518         * eval.c: Move declaration of overload_resolution to...
1519         * value.h: ...here.
1520
1521 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1522
1523         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1524         * arm-linux-tdep.c: Likewise.
1525         * arm-nbsd-nat.c: Likewise.
1526         * arm-tdep.h: Declare arm_apcs_32.
1527         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1528
1529 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1530
1531         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1532         * dwarf2read.h: Declare dwarf_always_disassemble.
1533
1534 2019-09-19  Tom de Vries  <tdevries@suse.de>
1535
1536         PR gdb/25009
1537         * source-cache.c (source_cache::ensure): Catch exception thrown during
1538         construction of the highlighter.
1539
1540 2019-09-18  Alan Modra  <amodra@gmail.com>
1541
1542         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1543         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1544         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1545         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1546         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1547         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1548         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1549         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1550         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1551         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1552         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1553         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1554         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1555         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1556         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1557         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1558         * mi/mi-interp.c: Update throughout for bfd section macro and
1559         function changes.
1560         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1561         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1562
1563 2019-09-18  Tom Tromey  <tom@tromey.com>
1564
1565         * NEWS: Add entry.
1566         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1567         call rl_initialize.
1568         (tui_enable): Do not call rl_initialize.
1569
1570 2019-09-18  Christian Groessler  <chris@groessler.org>
1571
1572         * alpha-linux-nat.c: Include gdbarch.h.
1573
1574 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1575
1576         * ui-file.c: Include cli/cli-style.h.
1577         (term_cli_styling): Remove cli_styling declaration.
1578
1579 2019-09-18  Alan Modra  <amodra@gmail.com>
1580
1581         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1582         to bfd_asymbol_section.
1583
1584 2019-09-18  Alan Modra  <amodra@gmail.com>
1585
1586         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1587         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1588         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1589
1590 2019-09-18  Alan Modra  <amodra@gmail.com>
1591
1592         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1593         * spu-linux-nat.c (spu_bfd_open): Likewise.
1594
1595 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1596
1597         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1598         to bool to match definition in dwarf2read.c.
1599
1600 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1601
1602         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1603         (print_signatures): Likewise.
1604         (trust_pad_over_xvs): Likewise.
1605         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1606         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1607         * arm-linux-nat.c (arm_apcs_32): Likewise.
1608         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1609         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1610         * arm-tdep.c (arm_debug): Likewise.
1611         (arm_apcs_32): Likewise.
1612         * auto-load.c (debug_auto_load): Likewise.
1613         (auto_load_gdb_scripts): Likewise.
1614         (global_auto_load): Likewise.
1615         (auto_load_local_gdbinit): Likewise.
1616         (auto_load_local_gdbinit_loaded): Likewise.
1617         * auto-load.h (global_auto_load): Likewise.
1618         (auto_load_local_gdbinit): Likewise.
1619         (auto_load_local_gdbinit_loaded): Likewise.
1620         * breakpoint.c (disconnected_dprintf): Likewise.
1621         (breakpoint_proceeded): Likewise.
1622         (automatic_hardware_breakpoints): Likewise.
1623         (always_inserted_mode): Likewise.
1624         (target_exact_watchpoints): Likewise.
1625         (_initialize_breakpoint): Update.
1626         * breakpoint.h (target_exact_watchpoints): Change to bool.
1627         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1628         * cli/cli-cmds.c (trace_commands): Likewise.
1629         * cli/cli-cmds.h (trace_commands): Likewise.
1630         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1631         to bool*.
1632         * cli/cli-logging.c (logging_overwrite): Change to bool.
1633         (logging_redirect): Likewise.
1634         (debug_redirect): Likewise.
1635         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1636         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1637         to bool.
1638         <boolean_option_def>: Update.
1639         (struct flag_option_def): Change default type of Context to bool
1640         from int.
1641         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1642         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1643         (get_setshow_command_value_string): Likewise.
1644         * cli/cli-style.c (cli_styling): Change to bool.
1645         (source_styling): Likewise.
1646         * cli/cli-style.h (source_styling): Likewise.
1647         (cli_styling): Likewise.
1648         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1649         to bool.
1650         * command.h (var_types): Update comment.
1651         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1652         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1653         bool.
1654         (debug_compile_cplus_scopes): Likewise.
1655         * compile/compile-internal.h (compile_debug): Likewise.
1656         * compile/compile.c (compile_debug): Likewise.
1657         (struct compile_options) <raw>: Likewise.
1658         * cp-support.c (catch_demangler_crashes): Likewise.
1659         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1660         (usr_cmd_cris_dwarf2_cfi): Likewise.
1661         * csky-tdep.c (csky_debug): Likewise.
1662         * darwin-nat.c (enable_mach_exceptions): Likewise.
1663         * dcache.c (dcache_enabled_p): Likewise.
1664         * defs.h (info_verbose): Likewise.
1665         * demangle.c (demangle): Likewise.
1666         (asm_demangle): Likewise.
1667         * dwarf-index-cache.c (debug_index_cache): Likewise.
1668         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1669         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1670         * dwarf2read.c (check_physname): Likewise.
1671         (use_deprecated_index_sections): Likewise.
1672         (dwarf_always_disassemble): Likewise.
1673         * eval.c (overload_resolution): Likewise.
1674         * event-top.c (set_editing_cmd_var): Likewise.
1675         (exec_done_display_p): Likewise.
1676         * event-top.h (set_editing_cmd_var): Likewise.
1677         (exec_done_display_p): Likewise.
1678         * exec.c (write_files): Likewise.
1679         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1680         (debug_fbsd_nat): Likewise.
1681         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1682         Likewise.
1683         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1684         <backtrace_past_entry> Likewise.
1685         * gdb-demangle.h (demangle): Likewise.
1686         (asm_demangle): Likewise.
1687         * gdb_bfd.c (bfd_sharing): Likewise.
1688         * gdbcore.h (write_files): Likewise.
1689         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1690         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1691         * gdbthread.h (print_thread_events): Likewise.
1692         * gdbtypes.c (opaque_type_resolution): Likewise.
1693         (strict_type_checking): Likewise.
1694         * gnu-nat.c (gnu_debug_flag): Likewise.
1695         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1696         * guile/scm-param.c (pascm_variable): Add boolval.
1697         (add_setshow_generic): Update.
1698         (pascm_param_value): Update.
1699         (pascm_set_param_value_x): Update.
1700         * hppa-tdep.c (hppa_debug): Change to bool..
1701         * infcall.c (may_call_functions_p): Likewise.
1702         (coerce_float_to_double_p): Likewise.
1703         (unwind_on_signal_p): Likewise.
1704         (unwind_on_terminating_exception_p): Likewise.
1705         * infcmd.c (startup_with_shell): Likewise.
1706         * inferior.c (print_inferior_events): Likewise.
1707         * inferior.h (startup_with_shell): Likewise.
1708         (print_inferior_events): Likewise.
1709         * infrun.c (step_stop_if_no_debug): Likewise.
1710         (detach_fork): Likewise.
1711         (debug_displaced): Likewise.
1712         (disable_randomization): Likewise.
1713         (non_stop): Likewise.
1714         (non_stop_1): Likewise.
1715         (observer_mode): Likewise.
1716         (observer_mode_1): Likewise.
1717         (set_observer_mode): Update.
1718         (sched_multi): Change to bool.
1719         * infrun.h (debug_displaced): Likewise.
1720         (sched_multi): Likewise.
1721         (step_stop_if_no_debug): Likewise.
1722         (non_stop): Likewise.
1723         (disable_randomization): Likewise.
1724         * linux-tdep.c (use_coredump_filter): Likewise.
1725         (dump_excluded_mappings): Likewise.
1726         * linux-thread-db.c (auto_load_thread_db): Likewise.
1727         (check_thread_db_on_load): Likewise.
1728         * main.c (captured_main_1): Update.
1729         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1730         xx2_opt, boolean_opt>: Change to bool.
1731         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1732         * maint.c (maintenance_profile_p): Likewise.
1733         (per_command_time): Likewise.
1734         (per_command_space): Likewise.
1735         (per_command_symtab): Likewise.
1736         * memattr.c (inaccessible_by_default): Likewise.
1737         * mi/mi-main.c (mi_async): Likewise.
1738         (mi_async_1): Likewise.
1739         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1740         * nat/fork-inferior.h (startup_with_shell): Likewise.
1741         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1742         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1743         * nios2-tdep.c (nios2_debug): Likewise.
1744         * or1k-tdep.c (or1k_debug): Likewise.
1745         * parse.c (parser_debug): Likewise.
1746         * parser-defs.h (parser_debug): Likewise.
1747         * printcmd.c (print_symbol_filename): Likewise.
1748         * proc-api.c (procfs_trace): Likewise.
1749         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1750         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1751         (set_parameter_value): Update.
1752         (add_setshow_generic): Update.
1753         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1754         to bool*.
1755         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1756         int*.
1757         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1758         * record-btrace.c (record_btrace_target::store_registers): Update.
1759         * record-full.c (record_full_memory_query): Change to bool.
1760         (record_full_stop_at_limit): Likewise.
1761         * record-full.h (record_full_memory_query): Likewise.
1762         * remote-notif.c (notif_debug): Likewise.
1763         * remote-notif.h (notif_debug): Likewise.
1764         * remote.c (use_range_stepping): Likewise.
1765         (interrupt_on_connect): Likewise.
1766         (remote_break): Likewise.
1767         * ser-tcp.c (tcp_auto_retry): Likewise.
1768         * ser-unix.c (serial_hwflow): Likewise.
1769         * skip.c (debug_skip): Likewise.
1770         * solib-aix.c (solib_aix_debug): Likewise.
1771         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1772         (spu_auto_flush_cache_p): Likewise.
1773         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1774         Likewise.
1775         (struct info_print_options) <quiet>: Likewise.
1776         * symfile-debug.c (debug_symfile): Likewise.
1777         * symfile.c (auto_solib_add): Likewise.
1778         (separate_debug_file_debug): Likewise.
1779         * symfile.h (auto_solib_add): Likewise.
1780         (separate_debug_file_debug): Likewise.
1781         * symtab.c (basenames_may_differ): Likewise.
1782         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1783         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1784         (struct info_types_options) <quiet>: Likewise.
1785         * symtab.h (demangle): Likewise.
1786         (basenames_may_differ): Likewise.
1787         * target-dcache.c (stack_cache_enabled_1): Likewise.
1788         (code_cache_enabled_1): Likewise.
1789         * target.c (trust_readonly): Likewise.
1790         (may_write_registers): Likewise.
1791         (may_write_memory): Likewise.
1792         (may_insert_breakpoints): Likewise.
1793         (may_insert_tracepoints): Likewise.
1794         (may_insert_fast_tracepoints): Likewise.
1795         (may_stop): Likewise.
1796         (auto_connect_native_target): Likewise.
1797         (target_stop_and_wait): Update.
1798         (target_async_permitted): Change to bool.
1799         (target_async_permitted_1): Likewise.
1800         (may_write_registers_1): Likewise.
1801         (may_write_memory_1): Likewise.
1802         (may_insert_breakpoints_1): Likewise.
1803         (may_insert_tracepoints_1): Likewise.
1804         (may_insert_fast_tracepoints_1): Likewise.
1805         (may_stop_1): Likewise.
1806         * target.h (target_async_permitted): Likewise.
1807         (may_write_registers): Likewise.
1808         (may_write_memory): Likewise.
1809         (may_insert_breakpoints): Likewise.
1810         (may_insert_tracepoints): Likewise.
1811         (may_insert_fast_tracepoints): Likewise.
1812         (may_stop): Likewise.
1813         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1814         (make_thread_apply_all_options_def_group): Change argument from int*
1815         to bool*.
1816         (thread_apply_all_command): Update.
1817         (print_thread_events): Change to bool.
1818         * top.c (confirm): Likewise.
1819         (command_editing_p): Likewise.
1820         (history_expansion_p): Likewise.
1821         (write_history_p): Likewise.
1822         (info_verbose): Likewise.
1823         * top.h (confirm): Likewise.
1824         (history_expansion_p): Likewise.
1825         * tracepoint.c (disconnected_tracing): Likewise.
1826         (circular_trace_buffer): Likewise.
1827         * typeprint.c (print_methods): Likewise.
1828         (print_typedefs): Likewise.
1829         * utils.c (debug_timestamp): Likewise.
1830         (sevenbit_strings): Likewise.
1831         (pagination_enabled): Likewise.
1832         * utils.h (sevenbit_strings): Likewise.
1833         (pagination_enabled): Likewise.
1834         * valops.c (overload_resolution): Likewise.
1835         * valprint.h (struct value_print_options) <prettyformat_arrays,
1836         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1837         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1838         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1839         Likewise.
1840         * windows-nat.c (new_console): Likewise.
1841         (cygwin_exceptions): Likewise.
1842         (new_group): Likewise.
1843         (debug_exec): Likewise.
1844         (debug_events): Likewise.
1845         (debug_memory): Likewise.
1846         (debug_exceptions): Likewise.
1847         (useshell): Likewise.
1848         * windows-tdep.c (maint_display_all_tib): Likewise.
1849         * xml-support.c (debug_xml): Likewise.
1850
1851 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1852
1853         * source.c (prepare_path_for_appending): New function.
1854         (openp): Make use of new function.
1855         (find_and_open_source): Search for the compilation directory and
1856         source file as a relative path beneath the directory search path.
1857
1858 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1859
1860         * source-cache.c (source_cache::get_line_charpos): Catch
1861         exceptions and return false, this matches the behaviour documented
1862         in the header file.
1863
1864 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1865
1866         * ada-tasks.c (info_task): Remove quoting of the task's name.
1867
1868 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1869
1870         * symfile.c (auto_solib_add): Replace comment with a reference
1871         to the header file.
1872
1873 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1874
1875         * NEWS: Mention that gdb can now be compiled with Python 3
1876         on Windows.
1877
1878 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1879
1880         * maint.c (maint_print_section_data::maint_print_section_data):
1881         Force use of 'float log10 (float)' by casting the argument to
1882         float.
1883
1884 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1885
1886         * maint.c: Add 'cmath' include.
1887         (struct maint_print_section_data): New structure.
1888         (print_section_index): New function.
1889         (print_bfd_section_info): Add header comment, small whitespace
1890         cleanup, and update to call new print_section_index function.
1891         (print_objfile_section_info): Likewise.
1892         (maint_obj_section_from_bfd_section): New function.
1893         (print_bfd_section_info_maybe_relocated): New function.
1894         (maintenance_info_sections): Add header comment, always use
1895         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1896
1897 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1898
1899         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1900         inner scope, add check that the objfile has psymtabs before
1901         checking psymtabs_addrmap.
1902         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1903
1904 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1905
1906         * NEWS: Announce that Ada task names are now shown at more places,
1907         and between quotes (except in info task output).
1908         * gdb/ada-tasks.c (task_to_str): New function.
1909         (display_current_task_id): Call task_to_str.
1910         (task_command_1): Likewise.
1911         (print_ada_task_info): In non-mi mode, Properly align headers and data
1912         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1913
1914 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1915
1916         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1917         prstatus.pr_lwp.pr_info instead of making it up.
1918
1919 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1920
1921         * auto-load.c (auto_load_expand_dir_vars): Update.
1922         * defs.h (gdb_datadir): Change to std::string.
1923         (python_libdir): Likewise.
1924         (relocate_gdb_directory): Change return type to std::string.
1925         * guile/guile.c (gdbscm_data_directory): Update.
1926         (initialize_scheme_side): Update.
1927         * jit.c (jit_reader_dir): Change to std::string.
1928         (jit_reader_load_command): Update.
1929         * main.c (gdb_datadir): Change to std::string.
1930         (python_libdir): Likewise.
1931         (set_gdb_data_directory): Update.
1932         (relocate_path): Change to return std::string.
1933         (relocate_gdb_directory): Change to return std::string.
1934         (relocate_gdbinit_path_maybe_in_datadir): Update.
1935         (captured_main_1): Update.
1936         * python/python.c (do_start_initialization): Update.
1937         * top.c (show_gdb_datadir): Update.
1938         * xml-syscall.c (xml_init_syscalls_info): Update.
1939         (init_syscalls_info): Update.
1940
1941 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1942
1943         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1944         out of get_init_files.
1945         (get_init_files): Update.
1946
1947 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1948
1949         * main.c (get_init_files): Change to use std::string.
1950         (captured_main_1): Update.
1951         (print_gdb_help): Update.
1952
1953 2019-09-11  Ali Tamur  <tamur@google.com>
1954
1955         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1956         implementation.
1957
1958 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1959
1960         * dbxread.c (read_dbx_symtab): Update.
1961         * dwarf2read.c (load_partial_dies): Update.
1962         * mdebugread.c (parse_partial_symbols): Update.
1963         (handle_psymbol_enumerators): Update.
1964         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1965         * psymtab.c (add_psymbol_to_bcache): Likewise.
1966         (add_psymbol_to_list): Likewise.
1967         * symtab.c (symbol_set_names): Likewise.
1968         * symtab.h (symbol_set_names): Likewise.
1969         * xcoffread.c (scan_xcoff_symtab): Update.
1970
1971 2019-09-11  Tom Tromey  <tom@tromey.com>
1972
1973         * symfile-mem.c (symbol_file_add_from_memory): Use
1974         bfd_set_filename.
1975         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1976         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1977
1978 2019-09-10  Tom Tromey  <tromey@adacore.com>
1979
1980         * dwarf-index-write.c (write_psymbols): Extend error message.
1981         (debug_names::insert): Add Ada code.
1982         (debug_names::write_psymbols): Remove Ada check.
1983         (debug_names) <m_string_obstack>: New member.
1984         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1985         (gdb_index_symbol_name_matcher::matches): Remove.
1986         (mapped_index_base::find_name_components_bounds): Add "lang"
1987         parameter.
1988         (mapped_index_base::build_name_components): Also split names
1989         according to Ada syntax.
1990         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1991         type of "match_callback".
1992         (check_match, check_find_bounds_finds)
1993         (dw2_expand_symtabs_matching): Update.
1994         (dw2_debug_names_iterator): Add new constructor.
1995         (dw2_debug_names_map_matching_symbols): New function.
1996         (dw2_debug_names_expand_symtabs_matching): Update.
1997         (dwarf2_debug_names_functions): Use
1998         dw2_debug_names_map_matching_symbols.
1999
2000 2019-09-10  Tom Tromey  <tromey@adacore.com>
2001
2002         * dwarf2read.c (dw2_get_file_names_reader): Add the
2003         CU's file name to the results.
2004
2005 2019-09-10  Tom Tromey  <tromey@adacore.com>
2006
2007         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2008         map_matching_symbols.  Update.
2009         * dwarf2read.c (dw2_map_matching_symbols): Update.
2010         * psymtab.c (match_partial_symbol): Change type; update.
2011         (psym_map_matching_symbols): Likewise.
2012         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2013         type; update.
2014         * symfile.h (struct quick_symbol_functions)
2015         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2016         Remove "match".
2017
2018 2019-09-10  Tom Tromey  <tromey@adacore.com>
2019
2020         * psymtab.c (map_block): Remove.
2021         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2022         * symtab.c (iterate_over_symbols_terminated): New function.
2023         * symtab.c (iterate_over_symbols_terminated): Declare.
2024
2025 2019-09-10  Tom Tromey  <tromey@adacore.com>
2026
2027         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2028         * language.h (struct language_defn) <la_iterate_over_symbols>:
2029         Return bool.
2030         * symtab.c (iterate_over_symbols): Return bool.
2031         * symtab.h (iterate_over_symbols): Return bool.
2032
2033 2019-09-10  Tom Tromey  <tromey@adacore.com>
2034
2035         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2036         (add_nonlocal_symbols): Update.
2037         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2038         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2039         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2040         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2041         Change type of "callback".  Remove "data".
2042
2043
2044 2019-09-09  Ali Tamur  <tamur@google.com>
2045
2046         * dwarf2read.c (comp_unit_head): Update comment.
2047         (dwarf2_dwo_name): New function declaration.
2048         (dwarf_unit_type_name): New function declaration.
2049         (read_comp_unit_head): Add support for new compilation units,
2050         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2051         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2052         (currently named as "signature") in their header. Also clarify error
2053         messages.
2054         (lookup_dwo_id): New function. Returns the dwo id of the given
2055         compile unit.
2056         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2057         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2058         functions.
2059         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2060         (dwarf2_dwo_name): Get the dwo name if present.
2061         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2062         purposes.
2063
2064 2019-09-09  Tom Tromey  <tom@tromey.com>
2065
2066         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2067
2068 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2069
2070         * python/python.c (do_start_initialization): Make progname_copy static,
2071         to avoid a leak report.
2072
2073 2019-09-08  Tom Tromey  <tom@tromey.com>
2074
2075         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2076
2077 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2078
2079         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2080         Change type to gdb::optional<block_enum>.
2081         (dw2_symtab_iter_init): Change block_index parameter type
2082         to gdb::optional<block_enum>.
2083         (dw2_lookup_symbol): Change block_index parameter
2084         type to block_enum.c
2085         (dw2_debug_names_lookup_symbol): Likewise.
2086         * psymtab.c (psym_lookup_symbol): Likewise.
2087         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2088         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2089         Likewise.
2090
2091 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2092
2093         * defs.h (relocate_gdb_directory): Change int to bool in
2094         signature and rename flag to relocatable.
2095         * main.c (relocate_path): Likewise.
2096         (relocate_gdb_directory): Likewise.
2097
2098 2019-09-06  Alan Modra  <amodra@gmail.com>
2099
2100         * coffread.c (coff_symfile_read): Constify filename variable.
2101         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2102         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2103         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2104         * solib.c (reload_shared_libraries_1): Likewise.
2105         * symfile.c (reread_symbols): Likewise.
2106         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2107         * solib-darwin.c (darwin_bfd_open): Likewise.
2108         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2109
2110 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2111
2112         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2113         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2114
2115 2019-09-03  Tom Tromey  <tromey@adacore.com>
2116
2117         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2118         types.
2119         (has_negatives): Unbias a range type bound.
2120         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2121         * gdbtypes.c (operator==): Handle new field.
2122         (create_range_type): Add "bias" parameter.
2123         (create_static_range_type, resolve_dynamic_range): Update.
2124         * gdbtypes.h (struct range_bounds) <bias>: New member.
2125         (create_range_type): Add bias parameter.
2126         * printcmd.c (print_scalar_formatted): Unbias range types.
2127         * value.c (unpack_long): Unbias range types.
2128         (pack_long): Bias range types.
2129
2130 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2131
2132         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2133         probe arguments.
2134
2135 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2136
2137         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2138         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2139         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2140         (compile_probe_arg): Likewise.
2141         * probe.h (get_argument_count): Likewise.
2142         * solib-svr4.c (solib_event_probe_action): Likewise.
2143         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2144
2145 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2146
2147         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2148         code to here...
2149         (svr4_create_solib_event_breakpoints): ...from here.
2150
2151 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2152
2153         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2154         suffix from warning message.
2155
2156 2019-08-30  Tom Tromey  <tom@tromey.com>
2157
2158         * tui/tui-winsource.h (struct tui_source_window_base)
2159         <refresh_all>: Don't declare.
2160         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2161         Remove.
2162         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2163         tui_show_locator_content.
2164         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2165         declare.
2166         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2167         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2168         declare.
2169
2170 2019-08-30  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2173
2174 2019-08-30  Tom Tromey  <tom@tromey.com>
2175
2176         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2177         Remove unnecessary forward declarations.
2178
2179 2019-08-30  Tom Tromey  <tom@tromey.com>
2180
2181         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2182         rerender.
2183         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2184         tui_show_locator_content.
2185
2186 2019-08-30  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2189         (tui_locator_window::rerender): Rewrite using body of previous
2190         tui_show_locator_content.
2191
2192 2019-08-30  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2195         set_locator_fullname>: New methods.
2196         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2197         Rename from tui_set_locator_fullname.
2198         (tui_locator_window::set_locator_info): Rename from
2199         tui_set_locator_info.  Return bool.
2200         (tui_update_locator_fullname, tui_show_frame_info): Update.
2201
2202 2019-08-30  Tom Tromey  <tom@tromey.com>
2203
2204         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2205
2206 2019-08-30  Tom Tromey  <tom@tromey.com>
2207
2208         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2209         call touchwin.
2210
2211 2019-08-30  Tom Tromey  <tom@tromey.com>
2212
2213         * tui/tui-wingeneral.c (box_win): Assume win_info and
2214         win_info->handle cannot be NULL.
2215
2216 2019-08-30  Tom Tromey  <tom@tromey.com>
2217
2218         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2219         refresh_window>: Declare.
2220         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2221         resize.
2222         (tui_data_item_window::rerender): Rename from
2223         tui_display_register.
2224         (tui_data_item_window::refresh_window): New method.
2225         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2226         no-op.
2227
2228 2019-08-30  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2231         regs_column_count, current_group>: Move later.  Now private.
2232         <get_current_group>: New method.
2233         * tui/tui-regs.c (tui_reg_command): Update.
2234         * tui/tui-layout.c (tui_set_layout): Update.
2235
2236 2019-08-30  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2239         (tui_data_window::rerender): Don't call
2240         check_and_display_highlight_if_needed.
2241         (tui_data_window::refresh_all): Remove call to
2242         erase_data_content.
2243
2244 2019-08-30  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2247         (tui_data_window::display_registers_from)
2248         (tui_data_window::display_reg_element_at_line)
2249         (tui_data_window::display_registers_from_line): Remove checks of
2250         "empty".
2251
2252 2019-08-30  Tom Tromey  <tom@tromey.com>
2253
2254         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2255         Don't declare.
2256         * tui/tui-regs.c (tui_data_window::show_registers): Call
2257         rerender.
2258         (tui_data_window::rerender): Rename from display_all_data.
2259         (tui_data_window::rerender): Remove old implementation.
2260
2261 2019-08-30  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2264         text.
2265         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2266
2267 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2268             Sergio Durigan Junior  <sergiodj@redhat.com>
2269
2270         PR win32/24284
2271         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2272
2273 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2274
2275         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2276         when searching for types.
2277
2278 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2279
2280         * f-lang.c (f_language_defn): Use f_print_typedef.
2281         * f-lang.h (f_print_typedef): Declare.
2282         * f-typeprint.c (f_print_typedef): Define.
2283
2284 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2285
2286         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2287
2288 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2289
2290         * cli/cli-utils.c (info_print_options_defs): Delete.
2291         (make_info_print_options_def_group): Delete.
2292         (extract_info_print_options): Delete.
2293         (info_print_command_completer): Delete.
2294         (info_print_args_help): Add extra parameter, and optionally
2295         include text about -n flag.
2296         * cli/cli-utils.h (struct info_print_options): Delete.
2297         (extract_info_print_options): Delete declaration.
2298         (info_print_command_completer): Delete declaration.
2299         (info_print_args_help): Add extra parameter, extend header
2300         comment.
2301         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2302         search_symbols.
2303         * stack.c (struct info_print_options): New type.
2304         (info_print_options_defs): New file scoped variable.
2305         (make_info_print_options_def_group): New static function.
2306         (info_print_command_completer): New static function.
2307         (info_locals_command): Update to use new local functions.
2308         (info_args_command): Likewise.
2309         (_initialize_stack): Add extra parameter to calls to
2310         info_print_args_help.
2311         * symtab.c (search_symbols): Add extra parameter, use this to
2312         possibly excluse non-debug symbols.
2313         (symtab_symbol_info): Add extra parameter, which is passed on to
2314         search_symbols.
2315         (struct info_print_options): New type.
2316         (info_print_options_defs): New file scoped variable.
2317         (make_info_print_options_def_group): New static function.
2318         (info_print_command_completer): New static function.
2319         (info_variables_command): Update to use local functions, and pass
2320         extra parameter through to symtab_symbol_info.
2321         (info_functions_command): Likewise.
2322         (info_types_command): Pass additional argument through to
2323         symtab_symbol_info.
2324         (rbreak_command): Pass extra argument to search_symbols.
2325         (_initialize_symtab): Add extra arguments for calls to
2326         info_print_args_help, and update help text for 'info variables',
2327         'whereis', and 'info functions' commands.
2328         * symtab.h (search_symbols): Add extra argument to declaration.
2329         * NEWS: Mention new flags.
2330
2331 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2332
2333         * symtab.c (lookup_static_symbol): Call the new function (and move
2334         it down to be next to lookup_global_symbol).
2335         (struct global_sym_lookup_data): Add block_enum member and rename to...
2336         (struct global_or_static_sym_lookup_data): ...this.
2337         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2338         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2339         (lookup_symbol_global_or_static_iterator_cb): ...this.
2340         (lookup_global_or_static_symbol): New function.
2341         (lookup_global_symbol): Call new function.
2342
2343 2019-08-26  Tom de Vries  <tdevries@suse.de>
2344
2345         PR c++/24852
2346         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2347         when pc_probe.prob == NULL.
2348
2349 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2350
2351         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2352         variable symbol_linkage to symbol_linkage_.
2353
2354 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2355
2356         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2357         represent whether the symbol is static, dynamic, or we don't
2358         know.
2359
2360 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2361
2362         * gdb/rx-tdep.c (rx_register_names): New.
2363         (rx_register_name): Delete.
2364         (rx_psw_type): Delete.
2365         (rx_fpsw_type): Delete.
2366         (rx_register_type): Delete.
2367         (rx_gdbarch_init): Convert target-descriptions.
2368         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2369         * gdb/features/Makefile: Add rx.xml.
2370         * gdb/features/rx.xml: New.
2371         * gdb/features/rx.c: Generated.
2372         * gdb/NEWS: Mention target description support.
2373
2374 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2375
2376         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2377         *slot_ptr.
2378
2379 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2380
2381         * configure.ac: Don't check for 'dlfcn.h' (moved to
2382         gdbsupport/common.m4).
2383         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2384         'gdbsupport/'.
2385         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2386         * compile/compile-c-support.c: Include
2387         'gdbsupport/gdb-dlfcn.h'.
2388         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2389         * gdb-dlfcn.c: Move to...
2390         * gdbsupport/gdb-dlfcn.c: ... here.
2391         * gdb-dlfcn.h: Move to...
2392         * gdbsupport/gdb-dlfcn.h: ... here.
2393
2394 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2395
2396         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2397         the offset field signed.
2398
2399 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2400
2401         * python/lib/gdb/__init__.py (_execute_file): New function.
2402         * python/python.c (python_run_simple_file): Call gdb._execute_file
2403         on Windows.
2404
2405 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2406
2407         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2408         all uses as this was never set to anything but a zero value.
2409
2410 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2411
2412         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2413
2414 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2415
2416         * tui/tui-data.h (tui_gen_win_info): Add an =default
2417         move constructor, required by some GCC versions.
2418
2419 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2420
2421         * go32-nat.c (go32_sysinfo): Add hygon_p.
2422
2423 2019-08-20  Tom Tromey  <tom@tromey.com>
2424
2425         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2426         line_from_reg_element_no, first_reg_element_no_inline,
2427         display_all_data, delete_data_content_windows,
2428         erase_data_content>: Now private.
2429
2430 2019-08-20  Tom Tromey  <tom@tromey.com>
2431
2432         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2433         (tui_unhighlight_win, tui_highlight_win)
2434         (tui_win_info::make_window): Update.
2435         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2436
2437 2019-08-20  Tom Tromey  <tom@tromey.com>
2438
2439         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2440         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2441         (MAX_PID_WIDTH): Move to tui-stack.c.
2442         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2443         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2444         (MAX_PID_WIDTH): Move from tui-data.h.
2445
2446 2019-08-20  Tom Tromey  <tom@tromey.com>
2447
2448         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2449         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2450         (box_win): Update.
2451         (tui_gen_win_info::make_window): Rename from tui_make_window.
2452         (tui_win_info::make_window): New method.
2453         (tui_gen_win_info::make_visible): Update.
2454         * tui/tui-source.c (tui_source_window::set_contents): Update.
2455         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2456         (tui_data_window::display_registers_from): Update.
2457         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2458         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2459         Declare.
2460         <can_box>: Remove.
2461         <title>: Remove.
2462         (struct tui_win_info) <make_window>: Declare.
2463         <can_box>: Now virtual.
2464         <title>: New member.
2465         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2466         * tui/tui-command.c (tui_cmd_window::resize): Update.
2467
2468 2019-08-20  Tom Tromey  <tom@tromey.com>
2469
2470         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2471         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2472         (tui_data_window::check_register_values): Update.
2473
2474 2019-08-20  Tom Tromey  <tom@tromey.com>
2475
2476         * tui/tui-regs.h (struct tui_data_window): Use
2477         DISABLE_COPY_AND_ASSIGN.
2478         <regs_content>: Change type, removing unique_ptr.
2479         <tui_data_window>: Add move constructor.
2480         * tui/tui-regs.c (tui_data_window::show_registers)
2481         (tui_data_window::show_register_group)
2482         (tui_data_window::display_registers_from)
2483         (tui_data_window::display_registers_from)
2484         (tui_data_window::first_data_item_displayed)
2485         (tui_data_window::delete_data_content_windows)
2486         (tui_data_window::rerender, tui_data_window::refresh_window)
2487         (tui_data_window::check_register_values): Update.
2488
2489 2019-08-20  Tom Tromey  <tom@tromey.com>
2490
2491         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2492         show_register_group>: Declare.
2493         (tui_show_register_group): Don't declare.
2494         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2495         tui_show_registers.
2496         (tui_data_window::show_register_group): Rename from
2497         tui_show_register_group.
2498         (tui_data_window::check_register_values, tui_reg_command):
2499         Update.
2500         * tui/tui-layout.c (tui_set_layout): Update.
2501
2502 2019-08-20  Tom Tromey  <tom@tromey.com>
2503
2504         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2505         Declare.
2506         (tui_check_register_values): Don't declare.
2507         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2508         from tui_check_register_values.
2509         * tui/tui-hooks.c (tui_register_changed): Update.
2510
2511 2019-08-20  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-regs.c (tui_reg_layout): Move later.
2514         (tui_show_registers): Don't enable TUI mode or change layout.
2515
2516 2019-08-20  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-regs.h (struct tui_data_item_window)
2519         <~tui_data_item_window>: Remove.
2520         <content>: Now a unique_xmalloc_ptr.
2521         * tui/tui-regs.c (tui_register_format): Return a
2522         unique_xmalloc_ptr.
2523         (tui_get_register): Update.
2524         (~tui_data_item_window): Remove.
2525         (tui_data_window::display_registers_from, tui_display_register):
2526         Update.
2527         * tui/tui-io.h (tui_expand_tabs): Update.
2528         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2529         Remove "col" parameter.
2530
2531 2019-08-20  Tom Tromey  <tom@tromey.com>
2532
2533         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2534         field.
2535         * tui/tui-regs.c (~tui_data_item_window): Update.
2536
2537 2019-08-20  Tom Tromey  <tom@tromey.com>
2538
2539         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2540         earlier.
2541
2542 2019-08-20  Tom Tromey  <tom@tromey.com>
2543
2544         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2545
2546 2019-08-20  Tom Tromey  <tom@tromey.com>
2547
2548         * tui/tui-source.h (struct tui_source_window): Update.
2549         * tui/tui-regs.c (tui_show_registers): Update.
2550         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2551         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2552         (NO_REGS_STRING): Remove defines.
2553
2554 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2555
2556         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2557         unnecessary thread walk if remote doesn't support the packet.
2558
2559 2019-08-19  Tom Tromey  <tromey@adacore.com>
2560
2561         * python/py-value.c (value_has_field): Fix indentation.
2562
2563 2019-08-19  Tom Tromey  <tromey@adacore.com>
2564
2565         * printcmd.c (do_one_display, info_display_command): Update.
2566         * block.h (contained_in): Return bool.  Add allow_nested
2567         parameter.
2568         * block.c (contained_in): Return bool.  Add allow_nested
2569         parameter.
2570
2571 2019-08-19  Tom Tromey  <tom@tromey.com>
2572
2573         * configure: Rebuild.
2574         * configure.ac: Disallow the combination of -static-libstdc++ and
2575         source highlight.
2576         * source-cache.c (get_language_name): Handle rust.
2577         (source_cache::get_source_lines): Ignore highlighting exceptions.
2578
2579 2019-08-16  Tom Tromey  <tom@tromey.com>
2580
2581         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2582         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2583         (struct tui_source_window_base) <make_visible, refresh_window,
2584         resize>: Remove methods.
2585         <execution_info>: Remove field.
2586         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2587         (tui_show_source_line, tui_source_window_base)
2588         (~tui_source_window_base): Update.
2589         (tui_source_window_base::resize)
2590         (tui_source_window_base::make_visible)
2591         (tui_source_window_base::refresh_window): Remove.
2592         (tui_source_window_base::update_exec_info): Update.
2593         * tui/tui-source.c (tui_source_window::set_contents): Update.
2594         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2595
2596 2019-08-16  Tom Tromey  <tom@tromey.com>
2597
2598         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2599         deprecated_query_hook.
2600
2601 2019-08-16  Tom Tromey  <tom@tromey.com>
2602
2603         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2604         (tui_update_source_windows_with_line): Update.
2605         * tui/tui-source.h (struct tui_source_window)
2606         <show_symtab_source>: Declare.
2607         (tui_show_symtab_source): Don't declare.
2608         * tui/tui-source.c (tui_show_symtab_source): Rename from
2609         tui_show_symtab_source.
2610
2611 2019-08-16  Tom Tromey  <tom@tromey.com>
2612
2613         * tui/tui-winsource.h (struct tui_source_window_base)
2614         <set_contents>: Declare.
2615         * tui/tui-winsource.c
2616         (tui_source_window_base::update_source_window_as_is): Update.
2617         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2618         Declare.
2619         (tui_set_source_content): Don't declare.
2620         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2621         tui_set_source_content.
2622         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2623         Declare.
2624         (tui_set_disassem_content): Don't declare.
2625         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2626         tui_set_disassem_content.
2627
2628 2019-08-16  Tom Tromey  <tom@tromey.com>
2629
2630         * tui/tui-winsource.h (struct tui_source_window_base)
2631         <update_breakpoint_info>: Declare.
2632         (tui_update_breakpoint_info): Don't declare.
2633         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2634         (tui_update_all_breakpoint_info): Update.
2635         (tui_source_window_base::update_breakpoint_info): Rename from
2636         tui_update_breakpoint_info.
2637         (tui_source_window_base::update_exec_info): Update.
2638
2639 2019-08-16  Tom Tromey  <tom@tromey.com>
2640
2641         * tui/tui-winsource.h (struct tui_source_window_base)
2642         <update_source_window>: Declare.
2643         (tui_update_source_window): Don't declare.
2644         * tui/tui-winsource.c
2645         (tui_source_window_base::update_source_window): Rename from
2646         tui_update_source_window.
2647         (tui_source_window_base::rerender): Update.
2648         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2649         * tui/tui-disasm.c (tui_show_disassem)
2650         (tui_show_disassem_and_update_source)
2651         (tui_disasm_window::maybe_update): Update.
2652
2653 2019-08-16  Tom Tromey  <tom@tromey.com>
2654
2655         * tui/tui-winsource.h (struct tui_source_window_base)
2656         <update_source_window_as_is>: Declare.
2657         (tui_update_source_window_as_is): Don't declare.
2658         * tui/tui-winsource.c (tui_update_source_window): Update
2659         (tui_source_window_base::update_source_window_as_is): Rename from
2660         tui_update_source_window_as_is.
2661         (tui_source_window_base::refill): Update.
2662         * tui/tui-source.c (tui_show_symtab_source): Update.
2663         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2664         Update.
2665
2666 2019-08-16  Tom Tromey  <tom@tromey.com>
2667
2668         * tui/tui-winsource.h (tui_update_source_window)
2669         (tui_update_source_window_as_is): Remove "noerror" parameter.
2670         * tui/tui-winsource.c (tui_update_source_window)
2671         (tui_update_source_window_as_is): Remove "noerror" parameter.
2672         (tui_update_source_windows_with_addr)
2673         (tui_update_source_windows_with_line)
2674         (tui_source_window_base::rerender)
2675         (tui_source_window_base::refill): Update.
2676         * tui/tui-source.h (tui_set_source_content)
2677         (tui_show_symtab_source): Remove "noerror" parameter.
2678         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2679         parameter.
2680         (tui_show_symtab_source): Likewise.
2681         (tui_source_window::maybe_update): Update.
2682         * tui/tui-disasm.c (tui_show_disassem)
2683         (tui_show_disassem_and_update_source)
2684         (tui_disasm_window::do_scroll_vertical)
2685         (tui_disasm_window::maybe_update): Update.
2686
2687 2019-08-16  Tom Tromey  <tom@tromey.com>
2688
2689         * tui/tui.c (tui_is_window_visible): Update.
2690         * tui/tui-wingeneral.c (tui_make_window)
2691         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2692         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2693         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2694         (tui_set_win_height_command, parse_scrolling_args): Update.
2695         * tui/tui-source.c (tui_source_window::style_changed): Update.
2696         * tui/tui-regs.c (tui_show_registers)
2697         (tui_data_window::first_data_item_displayed)
2698         (tui_data_window::delete_data_content_windows)
2699         (tui_check_register_values, tui_reg_command): Update.
2700         * tui/tui-disasm.c (tui_show_disassem): Update.
2701         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2702         method.
2703         <is_visible>: Remove field.
2704         * tui/tui-data.c (tui_next_win, tui_prev_win)
2705         (tui_delete_invisible_windows): Update.
2706
2707 2019-08-16  Tom Tromey  <tom@tromey.com>
2708
2709         * tui/tui-winsource.h (struct tui_source_window_base)
2710         <m_has_locator>: Remove.
2711         * tui/tui-layout.c (show_source_disasm_command, show_data)
2712         (show_source_or_disasm_and_command): Update.
2713
2714 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2715
2716         * NEWS (Other MI changes): New subsection.
2717         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2718         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2719         * arch-utils.c (default_get_pc_address_flags): New function.
2720         * arch-utils.h (default_get_pc_address_flags): New declaration.
2721         * gdbarch.sh: Add get_pc_address_flags.
2722         * gdbarch.c: Regenerate.
2723         * gdbarch.h: Likewise.
2724         * stack.c (print_pc): New function.
2725         (print_frame_info) (print_frame): Call print_pc.
2726
2727 2019-08-16  Tom de Vries  <tdevries@suse.de>
2728
2729         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2730         print_objfile_section_info.
2731
2732 2019-08-15  Tom Tromey  <tom@tromey.com>
2733
2734         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2735         calling update_cmdwin_start_line.
2736         * tui/tui-winsource.h (struct tui_source_window_base)
2737         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2738         <rerender>: Declare.
2739         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2740         Call rerender.
2741         (tui_source_window_base::set_new_height): Remove.
2742         (tui_source_window_base::rerender): Rename from
2743         do_make_visible_with_new_height.
2744         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2745         resize method.
2746         (tui_win_info::make_invisible_and_set_new_height)
2747         (tui_win_info::make_visible_with_new_height): Remove.
2748         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2749         Declare.
2750         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2751         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2752         do_make_visible_with_new_height>: Don't declare.
2753         <rerender>: Declare.
2754         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2755         set_new_height.
2756         (tui_data_window::do_make_visible_with_new_height): Remove.
2757         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2758         call tui_show_locator_content.
2759         (tui_gen_win_info::resize): Call rerender.
2760         (show_source_or_disasm_and_command): Don't call
2761         tui_show_locator_content.
2762         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2763         method.
2764         (struct tui_win_info) <rerender>: Declare.
2765         <set_new_height, make_invisible_and_set_new_height,
2766         make_visible_with_new_height>: Don't declare.
2767         * tui/tui-data.c (tui_win_list::rerender): New method.
2768         * tui/tui-command.h (struct tui_cmd_window)
2769         <do_make_visible_with_new_height>: Don't declare.
2770         * tui/tui-command.c
2771         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2772
2773 2019-08-15  Tom Tromey  <tromey@adacore.com>
2774
2775         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2776         * ada-lang.c (ada_enum_name): Likewise.
2777
2778 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2779
2780         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2781         leading underscore.
2782         (GdbOutputErrorFile): Likewise.
2783         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2784         accordingly.
2785         (execute_unwinders): Rename to have a leading underscore.
2786         (auto_load_packages): Likewise.
2787         (global scope): Adjust call to auto_load_packages accordingly.
2788         (GdbSetPythonDirectory): Likewise.
2789         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2790         instead of execute_unwinders.
2791
2792 2019-08-15  Tom Tromey  <tom@tromey.com>
2793
2794         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2795         (show_data): Don't change window visibility.
2796         (tui_gen_win_info::resize): Remove special case for command
2797         window.  Use wresize, when available.
2798         (show_source_or_disasm_and_command): Don't change window
2799         visibility.
2800         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2801         <make_visible>: New method.
2802         * tui/tui-command.c (tui_cmd_window::resize): New method.
2803
2804 2019-08-15  Tom Tromey  <tom@tromey.com>
2805
2806         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2807         (struct tui_source_windows): New.
2808         * tui/tui-winsource.c (tui_display_main): Update.
2809         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2810         (new_height_ok, parse_scrolling_args): Update.
2811         * tui/tui-layout.c (show_layout, show_data): Update.
2812         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2813         (tui_add_to_source_windows): Don't declare.
2814         * tui/tui-data.c (source_windows, tui_source_windows)
2815         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2816
2817 2019-08-15  Tom Tromey  <tom@tromey.com>
2818
2819         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2820         Rename from reset.
2821         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2822         * tui/tui-layout.c (show_source_disasm_command, show_data):
2823         Update.
2824         (tui_gen_win_info::resize): Rename.
2825         (show_source_or_disasm_and_command): Update.
2826         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2827         reset.
2828
2829 2019-08-15  Tom Tromey  <tom@tromey.com>
2830
2831         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2832         * tui/tui-interp.c (tui_interp::init): Don't call
2833         tui_initialize_static_data.
2834         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2835
2836 2019-08-15  Tom Tromey  <tom@tromey.com>
2837
2838         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2839         examine tui_win_list.
2840
2841 2019-08-15  Tom Tromey  <tom@tromey.com>
2842
2843         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2844         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2845         tui_clear_source_content.
2846         (tui_clear_source_content): Remove.
2847         (tui_source_window_base::do_erase_source_content): Hoist call to
2848         content.clear().
2849         * tui/tui-stack.c (tui_show_frame_info): Don't call
2850         tui_clear_source_content.
2851
2852 2019-08-15  Tom Tromey  <tom@tromey.com>
2853
2854         * tui/tui-winsource.h (struct tui_source_window_base)
2855         <do_erase_source_content>: New method.
2856         <erase_source_content>: New method.
2857         (tui_erase_source_content): Don't declare.
2858         * tui/tui-winsource.c (tui_clear_source_content): Update.
2859         (tui_source_window_base::do_erase_source_content): Rename from
2860         tui_erase_source_content.
2861         (tui_source_window_base::show_source_content): Update.
2862         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2863         * tui/tui-source.h (struct tui_source_window)
2864         <erase_source_content>: New method.
2865         * tui/tui-disasm.h (struct tui_disasm_window)
2866         <erase_source_content>: New method.
2867
2868 2019-08-15  Tom Tromey  <tom@tromey.com>
2869
2870         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2871         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2872         constructor.
2873         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2874         * tui/tui-source.c (tui_set_source_content): Update.
2875         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2876
2877 2019-08-15  Tom Tromey  <tom@tromey.com>
2878
2879         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2880         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2881         tui-source.c.
2882         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2883         Declare.
2884         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2885         method.
2886         (tui_source_window::maybe_update): Update.
2887
2888 2019-08-15  Tom Tromey  <tom@tromey.com>
2889
2890         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2891         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2892         tui-disasm.c.
2893         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2894         Declare.
2895         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2896         method.
2897         (tui_disasm_window::maybe_update): Update.
2898
2899 2019-08-15  Tom Tromey  <tom@tromey.com>
2900
2901         * tui/tui-winsource.h (struct tui_source_window_base)
2902         <maybe_update>: Declare.
2903         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2904         method.
2905         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2906         Declare.
2907         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2908         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2909         Declare.
2910         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2911
2912 2019-08-15  Tom Tromey  <tom@tromey.com>
2913
2914         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2915
2916 2019-08-15  Tom Tromey  <tom@tromey.com>
2917
2918         * tui/tui-wingeneral.c: Include tui-stack.h.
2919         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2920         (struct tui_locator_window): Move from tui-data.h.
2921         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2922         (tui_initialize_static_data): Move from tui-data.c.
2923         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2924         (struct tui_locator_window): Move to tui-stack.c.
2925         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2926         (tui_initialize_static_data): Move to tui-stack.c.
2927
2928 2019-08-15  Tom Tromey  <tom@tromey.com>
2929
2930         * tui/tui-layout.c (show_source_disasm_command)
2931         (show_source_or_disasm_and_command): Use make_visible method, not
2932         tui_make_window.
2933         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2934         Remove.
2935
2936 2019-08-15  Tom Tromey  <tom@tromey.com>
2937
2938         * tui/tui-wingeneral.h (tui_make_window): Update.
2939         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2940         parameter.
2941         (tui_gen_win_info::make_visible): Update.
2942         * tui/tui-regs.c (tui_data_window::display_registers_from):
2943         Update.
2944         * tui/tui-layout.c (show_source_disasm_command)
2945         (show_source_or_disasm_and_command): Update.
2946         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2947         (enum tui_box): Remove.
2948         (struct tui_win_info) <can_box>: New method.
2949         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2950         method.
2951
2952 2019-08-15  Tom de Vries  <tdevries@suse.de>
2953
2954         * linux-nat-trad.c: Include gdbarch.h.
2955
2956 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2957
2958         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2959         register sizes.
2960
2961 2019-08-14  Tom Tromey  <tromey@adacore.com>
2962
2963         * darwin-nat.c: Include gdbarch.h.
2964         * darwin-nat-info.c: Include gdbarch.h.
2965
2966 2019-08-13  Tom Tromey  <tom@tromey.com>
2967
2968         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2969         Remove.
2970         * tui/tui-data.c (tui_initialize_static_data): Update.
2971
2972 2019-08-13  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui-winsource.h (struct tui_exec_info_window)
2975         <~tui_exec_info_window, maybe_allocate_content, get_content,
2976         m_content>: Remove.
2977         (struct tui_source_window_base) <set_exec_info_content,
2978         show_exec_info_content>: Don't declare.
2979         * tui/tui-winsource.c
2980         (tui_exec_info_window::maybe_allocate_content): Remove.
2981         (tui_source_window_base::update_exec_info): Rename from
2982         set_exec_info_content.
2983         (tui_source_window_base::show_exec_info_content)
2984         (tui_source_window_base::update_exec_info): Remove.
2985
2986 2019-08-13  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2989         declare.
2990         * tui/tui-winsource.c (tui_update_source_window_as_is)
2991         (tui_update_source_windows_with_addr, tui_erase_source_content):
2992         Update.
2993         (tui_clear_exec_info_content): Remove.
2994
2995 2019-08-13  Tom Tromey  <tom@tromey.com>
2996
2997         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2998         declare.
2999         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3000         call tui_erase_exec_info_content.
3001         (tui_clear_exec_info_content): Rename from
3002         tui_erase_exec_info_content.
3003         (tui_clear_exec_info_content): Delete.
3004
3005 2019-08-13  Tom Tromey  <tom@tromey.com>
3006
3007         * tui/tui-winsource.h (struct tui_source_window_base)
3008         <show_exec_info_content>: Declare.
3009         (tui_show_exec_info_content): Don't declare.
3010         * tui/tui-winsource.c
3011         (tui_source_window_base::show_exec_info_content): Rename from
3012         tui_show_exec_info_content.
3013         (tui_source_window_base::update_exec_info): Update.
3014
3015 2019-08-13  Tom Tromey  <tom@tromey.com>
3016
3017         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3018         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3019         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3020         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3021         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3022         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3023         ... here.
3024
3025 2019-08-13  Tom Tromey  <tom@tromey.com>
3026
3027         * tui/tui-winsource.h (struct tui_source_window_base)
3028         <update_exec_info>: Declare.
3029         (tui_update_exec_info): Don't declare.
3030         * tui/tui-winsource.c (tui_update_source_window_as_is)
3031         (tui_source_window_base::refresh_all)
3032         (tui_update_all_breakpoint_info): Update.
3033         (tui_source_window_base::update_exec_info): Rename from
3034         tui_update_exec_info.
3035         * tui/tui-stack.c (tui_show_frame_info): Update.
3036
3037 2019-08-13  Tom Tromey  <tom@tromey.com>
3038
3039         * tui/tui-winsource.h (struct tui_source_window_base)
3040         <set_exec_info_content>: Declare.
3041         (tui_set_exec_info_content): Don't declare.
3042         * tui/tui-winsource.c
3043         (tui_source_window_base::set_exec_info_content): Rename from
3044         tui_set_exec_info_content.
3045         (tui_update_exec_info): Update.
3046
3047 2019-08-13  Tom Tromey  <tom@tromey.com>
3048
3049         * tui/tui-winsource.h (struct tui_source_window_base)
3050         <show_source_content>: Declare.
3051         (tui_show_source_content): Don't declare.
3052         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3053         (tui_source_window_base::show_source_content): Rename from
3054         tui_show_source_content.
3055         (tui_source_window_base::refresh_all): Update.
3056         * tui/tui-layout.c (show_source_disasm_command)
3057         (show_source_or_disasm_and_command): Update.
3058
3059 2019-08-13  Tom Tromey  <tom@tromey.com>
3060
3061         * tui/tui-winsource.c (tui_erase_source_content)
3062         (tui_show_source_content, tui_source_window_base::refresh_all):
3063         Update.
3064         * tui/tui-wingeneral.h
3065         (tui_check_and_display_highlight_if_needed): Don't declare.
3066         * tui/tui-wingeneral.c
3067         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3068         check_and_display_highlight_if_needed.
3069         * tui/tui-win.c (tui_rehighlight_all)
3070         (tui_win_info::make_visible_with_new_height): Update.
3071         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3072         (tui_data_window::erase_data_content)
3073         (tui_data_window::display_all_data): Update.
3074         * tui/tui-data.h (struct tui_win_info)
3075         <check_and_display_highlight_if_needed>: Declare.
3076
3077 2019-08-13  Tom Tromey  <tom@tromey.com>
3078
3079         * tui/tui-win.c (tui_resize_all): Call
3080         tui_delete_invisible_windows.
3081         * tui/tui-layout.c (show_layout): Call
3082         tui_delete_invisible_windows.
3083         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3084         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3085
3086 2019-08-13  Tom Tromey  <tom@tromey.com>
3087
3088         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3089         tui_add_win_to_layout.
3090
3091 2019-08-13  Tom Tromey  <tom@tromey.com>
3092
3093         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3094         * tui/tui-layout.c (tui_default_win_height): Now static.
3095
3096 2019-08-13  Tom Tromey  <tom@tromey.com>
3097
3098         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3099         single switch.
3100         (show_source_disasm_command, show_source_or_disasm_and_command):
3101         Don't check current layout.
3102
3103 2019-08-13  Tom Tromey  <tom@tromey.com>
3104
3105         * tui/tui-wingeneral.c (make_all_visible): Remove.
3106         (tui_make_all_invisible): Simplify.
3107         * tui/tui-layout.c (tui_make_all_invisible): Move from
3108         tui-wingeneral.c; simplify.
3109         (show_layout): Hoist call to tui_make_all_invisible.
3110         (show_data): Don't call tui_make_all_invisible.
3111
3112 2019-08-13  Tom Tromey  <tom@tromey.com>
3113
3114         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3115         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3116
3117 2019-08-13  Tom Tromey  <tom@tromey.com>
3118
3119         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3120         tui-data.c.
3121         (show_source_disasm_command, show_data)
3122         (show_source_or_disasm_and_command): Don't use
3123         tui_set_current_layout_to.
3124         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3125         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3126         tui-layout.c.
3127         (tui_set_current_layout_to): Remove.
3128
3129 2019-08-13  Tom Tromey  <tom@tromey.com>
3130
3131         * tui/tui-layout.c (tui_set_layout): Update.
3132         * tui/tui-data.h (struct tui_layout_def): Remove.
3133         (tui_layout_def): Don't declare.
3134         * tui/tui-data.c (layout_def): Remove.
3135         (tui_layout_def): Remove.
3136
3137 2019-08-13  Tom Tromey  <tom@tromey.com>
3138
3139         * tui/tui-winsource.h (struct tui_source_window_base)
3140         <clear_detail>: No longer "override".
3141         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3142         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3143         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3144         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3145         Remove.
3146         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3147
3148 2019-08-13  Tom Tromey  <tromey@adacore.com>
3149
3150         * tracepoint.c: Don't include readline.h or history.h.
3151
3152 2019-08-12  Tom Tromey  <tom@tromey.com>
3153
3154         * configure: Rebuild.
3155         * configure.ac: Check for readline 7.
3156         * NEWS: Mention readline 7 requirement.
3157         * README: Update.
3158
3159 2019-08-12  Tom Tromey  <tom@tromey.com>
3160
3161         * mingw-hdep.c (gdb_select): Remove readline hack.
3162
3163 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3164
3165         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3166         when the function fails.
3167
3168 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3169
3170         * s390-tdep.c (s390_type_align): New function.
3171         (s390_gdbarch_init): Set it as type_align gdbarch method.
3172
3173 2019-08-09  Tom de Vries  <tdevries@suse.de>
3174
3175         PR gdb/24591
3176         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3177         pc_low with relocation offset.
3178
3179 2019-08-07  Tom Tromey  <tromey@adacore.com>
3180
3181         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3182         (print_frame_args): Update.
3183         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3184         Update.
3185         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3186         * frame.h (struct frame_arg): Add initializers.
3187         <error>: Now a unique_xmalloc_ptr.
3188
3189 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3190
3191         * NEWS: Expand the Pointer Authentication entry.
3192         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3193         (aarch64_frame_unmask_lr): ... to this.
3194         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3195         Call aarch64_frame_unmask_lr.
3196         * frame.c (struct frame_info): Add "masked" variable.
3197         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3198         (fprint_frame): Check for masked pc.
3199         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3200         declarations.
3201         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3202         * stack.c (print_frame): Check for masked pc.
3203
3204 2019-08-06  Tom Tromey  <tom@tromey.com>
3205
3206         * stabsread.c (patch_block_stabs, read_one_struct_field)
3207         (read_enum_type): Use obstack_strndup.
3208         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3209         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3210         * dwarf2read.c (guess_full_die_structure_name)
3211         (anonymous_struct_prefix): Use obstack_strndup.
3212         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3213         * c-exp.y (yylex): Use obstack_strndup.
3214         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3215         (write_var_or_type): Use obstack_strndup.
3216
3217 2019-08-06  Tom Tromey  <tom@tromey.com>
3218
3219         * symfile.c (reread_symbols): Use obstack_strdup.
3220         * stabsread.c (read_type): Use obstack_strdup.
3221         * gdb_obstack.h (obstack_strdup): New overload.
3222         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3223         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3224         (dwarf2_canonicalize_name): Use obstack_strdup.
3225         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3226         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3227         Use obstack_strdup.
3228
3229 2019-08-06  Tom Tromey  <tom@tromey.com>
3230
3231         * gdb_obstack.h (obstack_strdup): Define.
3232         * gdb_obstack.c (obstack_strdup): Don't define.
3233
3234 2019-08-06  Tom Tromey  <tom@tromey.com>
3235
3236         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3237         obstack_strdup.
3238         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3239         obstack_strdup.
3240         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3241         * stabsread.c (common_block_start): Use obstack_strdup.
3242         * objfiles.c (set_objfile_main_name, objfile): Use
3243         obstack_strdup.
3244         * namespace.c (add_using_directive): Use obstack_strdup.
3245         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3246         * jit.c (finalize_symtab): Use obstack_strdup.
3247         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3248         (guess_partial_die_structure_name, partial_die_info::fixup)
3249         (dwarf2_name): Use obstack_strdup.
3250         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3251         obstack_strdup.
3252         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3253         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3254         obstack_strdup.
3255         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3256
3257 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3258
3259         * unittests/help-doc-selftests.c: New file.
3260         * Makefile.in: Add the new file.
3261
3262 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3263
3264         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3265         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3266         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3267         the trailing '.' is not output, and the first character is uppercased.
3268         (print_help_for_command): Update call to print_doc_line.
3269         (print_doc_of_command): Likewise.
3270         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3271         * cli/cli-option.c (append_indented_doc): Do not append newline.
3272         (build_help_option): Append newline after first appended_indented_doc
3273         only if a second call is done.
3274         (build_help): Append 2 new lines before each option, except the first
3275         one.
3276         * compile/compile.c (_initialize_compile): Add new lines after
3277         %OPTIONS%, when not at the end of the help.
3278         Change help doc or code
3279         producing the help doc to respect the invariants.
3280         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3281         Also removed the new line after 'Options:', as all other commands
3282         do not put an empty line between 'Options:' and the first option.
3283         * printcmd.c (_initialize_printcmd): Likewise.
3284         * stack.c (_initialize_stack): Likewise.
3285         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3286         incorrectly telling COMMAND is optional.
3287         * ada-lang.c (_initialize_ada_language): Change help doc or code
3288         producing the help doc to respect the invariants.
3289         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3290         * breakpoint.c (_initialize_breakpoint): Likewise.
3291         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3292         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3293         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3294         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3295         _initialize_cli_style): Likewise.
3296         * corelow.c (core_target_info): Likewise.
3297         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3298         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3299         * filesystem.c (_initialize_filesystem): Likewise.
3300         * frame.c (_initialize_frame): Likewise.
3301         * gnu-nat.c (add_task_commands): Likewise.
3302         * infcall.c (_initialize_infcall): Likewise.
3303         * infcmd.c (_initialize_infcmd): Likewise.
3304         * interps.c (_initialize_interpreter): Likewise.
3305         * language.c (_initialize_language): Likewise.
3306         * linux-fork.c (_initialize_linux_fork): Likewise.
3307         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3308         * maint.c (_initialize_maint_cmds): Likewise.
3309         * memattr.c (_initialize_mem): Likewise.
3310         * printcmd.c (_initialize_printcmd): Likewise.
3311         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3312         _RegEx): Likewise.
3313         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3314         * record-btrace.c (_initialize_record_btrace): Likewise.
3315         * record-full.c (_initialize_record_full): Likewise.
3316         * record.c (_initialize_record): Likewise.
3317         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3318         * regcache.c (_initialize_regcache): Likewise.
3319         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3320         _initialize_remote): Likewise.
3321         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3322         * serial.c (_initialize_serial): Likewise.
3323         * skip.c (_initialize_step_skip): Likewise.
3324         * source.c (_initialize_source): Likewise.
3325         * stack.c (_initialize_stack): Likewise.
3326         * symfile.c (_initialize_symfile): Likewise.
3327         * symtab.c (_initialize_symtab): Likewise.
3328         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3329         * top.c (init_main): Likewise.
3330         * tracefile-tfile.c (tfile_target_info): Likewise.
3331         * tracepoint.c (_initialize_tracepoint): Likewise.
3332         * tui/tui-win.c (_initialize_tui_win): Likewise.
3333         * utils.c (add_internal_problem_command): Likewise.
3334         * valprint.c (value_print_option_defs): Likewise.
3335
3336 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3337
3338         PR build/24886
3339         * configure.ac: Drop enable-libmcheck support.
3340         * configure, config.in: Rebuild.
3341         * libmcheck.m4: Remove.
3342         * acinclude.m4: Don't include it.
3343         * Makefile.in: Don't distribute it.
3344         * top.c (print_gdb_configuration): Don't mention it.
3345
3346 2019-08-06  Tom Tromey  <tom@tromey.com>
3347
3348         * utils.c (set_output_style): Sometimes pass stream to
3349         emit_style_escape.
3350         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3351         * record-btrace.c (btrace_insn_history): Update.
3352         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3353         method.
3354         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3355         Update initializers.
3356         <m_uiout>: New field.
3357         <m_di>: Move lower.
3358         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3359         Remove "uiout" parameter.
3360         (dump_insns): Update.
3361         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3362         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3363
3364 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3365
3366         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3367         (error_in_psymtab_expansion): Likewise.
3368         (lookup_symbol_via_quick_fns): Likewise.
3369         (basic_lookup_transparent_type_quick): Likewise.
3370         (basic_lookup_transparent_type_1): Likewise.
3371
3372 2019-08-06  Tom Tromey  <tromey@adacore.com>
3373
3374         * source.c (last_source_error): Now bool.
3375         (print_source_lines_base): Make "noprint" bool.  Only open
3376         source file when last_source_visited changes.
3377
3378 2019-08-06  Tom Tromey  <tromey@adacore.com>
3379
3380         * annotate.c (annotate_source_line): Use g_source_cache.
3381         * source-cache.c (source_cache::get_plain_source_lines): Change
3382         parameters.  Populate m_offset_cache.
3383         (source_cache::ensure): New method.
3384         (source_cache::get_line_charpos): New method.
3385         (extract_lines): Move lower.  Change parameters.
3386         (source_cache::get_source_lines): Move lower.
3387         * source-cache.h (class source_cache): Update comment.
3388         <get_line_charpos>: New method.
3389         <get_source_lines>: Update comment.
3390         <clear>: Clear m_offset_cache.
3391         <get_plain_source_lines>: Change parameters.
3392         <ensure>: New method
3393         <m_offset_cache>: New member.
3394         * source.c (forget_cached_source_info_for_objfile): Update.
3395         (info_source_command): Use g_source_cache.
3396         (find_source_lines, open_source_file_with_line_charpos): Remove.
3397         (print_source_lines_base, search_command_helper): Use g_source_cache.
3398         * source.h (open_source_file_with_line_charpos): Don't declare.
3399         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3400         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3401         Use g_source_cache.
3402
3403 2019-08-06  Tom Tromey  <tromey@adacore.com>
3404
3405         * source-cache.c (source_cache::get_plain_source_lines):
3406         Remove "first_line" and "last_line" parameters.
3407         (source_cache::get_source_lines): Cache plain text.
3408         * source-cache.h (class source_cache)
3409         <get_plain_source_lines>: Update.
3410
3411 2019-08-06  Tom Tromey  <tromey@adacore.com>
3412
3413         * source-cache.c (extract_lines): No longer a method.
3414         Changed type of parameter.  Include final newline.
3415         (selftests::extract_lines_test): New function.
3416         (_initialize_source_cache): Likewise.
3417         * source-cache.h (class source_cache)
3418         <extract_lines>: Don't declare.
3419
3420 2019-08-06  Tom Tromey  <tromey@adacore.com>
3421
3422         * breakpoint.c (init_breakpoint_sal): Update.
3423         (breakpoint): Update.
3424         * breakpoint.h (struct breakpoint) <filter>: Now a
3425         unique_xmalloc_ptr.
3426
3427 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3428
3429         * NEWS: Mention dictionary access on blocks.
3430         * python/py-block.c (blpy_getitem): New function.
3431         (block_object_as_mapping): New struct.
3432         (block_object_type): Use new struct for tp_as_mapping field.
3433
3434 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3435
3436         * objfiles.h (objfile): Add a comment describing partial symbols.
3437
3438 2019-08-05  Tom Tromey  <tromey@adacore.com>
3439
3440         * compile/compile.c (_initialize_compile): Use _(), not N_().
3441         * thread.c (_initialize_thread): Use _(), not N_().
3442         * stack.c (_initialize_stack): Use _(), not N_().
3443         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3444
3445 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3446
3447         * dwarf2read.c (struct dw2_symtab_iterator):
3448         <want_specific_block>: Remove.
3449         <block_index>: Change type to gdb::optional.
3450         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3451         change type of BLOCK_INDEX parameter to gdb::optional.
3452         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3453         (dw2_lookup_symbol): Don't pass argument for
3454         WANT_SPECIFIC_BLOCK.
3455         (dw2_expand_symtabs_for_function): Don't pass argument for
3456         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3457         (class dw2_debug_names_iterator)
3458         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3459         parameter, change BLOCK_INDEX type to gdb::optional.
3460         <m_want_specific_block>: Remove.
3461         <m_block_index>: Change type to gdb::optional.
3462         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3463         gdb::optional.  Re-write in function of gdb::optional.
3464         (dw2_debug_names_lookup_symbol): Don't pass argument for
3465         WANT_SPECIFIC_BLOCK.
3466         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3467         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3468         BLOCK_INDEX.
3469
3470 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3471
3472         * NEWS: Mention changes to "info sources" command.
3473
3474 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3475
3476         * symtab.c (filename_partial_match_opts): New struct type.
3477         (struct output_source_filename_data): New members
3478         regexp, c_regexp, partial_match.
3479         (output_source_filename): Use new members to decide to print file.
3480         (info_sources_option_defs): New variable.
3481         (make_info_sources_options_def_group, print_info_sources_header,
3482         info_sources_command_completer):
3483         New functions.
3484         (info_sources_command): Read new optional arguments.
3485         (_initialize_symtab): Update info sources help.
3486
3487 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3488
3489         * ada-lang.c (exception_support_info_v0): Renamed from...
3490         (default_exception_support_info): ... this.  Create new
3491         definition for v1.
3492         (ada_has_this_exception_support): Look up catch_handlers_sym.
3493         (ada_exception_support_info_sniffer): Try v0 after default.
3494
3495 2019-08-01  Tom Tromey  <tromey@adacore.com>
3496
3497         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3498         gdbarch.h.
3499
3500 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3501
3502         * s12z-tdep.c: Fix include path for s12z-opc.h.
3503
3504 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3505
3506         * NEWS: Require GNU make 3.82.
3507
3508 2019-07-16  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3511         declare.
3512
3513 2019-07-30  Tom Tromey  <tromey@adacore.com>
3514
3515         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3516
3517 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3518
3519         * printcmd.c (print_address_symbolic): Print negative offsets.
3520         (build_address_symbolic): Force signed arithmetic when computing
3521         offset.
3522
3523 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3524
3525         PR/24474: Add a function to lookup static variables.
3526         * NEWS: Mention this new function.
3527         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3528         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3529         * python/python.c (python_GdbMethods): Add new function.
3530
3531 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3532
3533         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3534         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3535         (objfpy_lookup_static_symbol): New function.
3536         (objfile_object_methods): Add new functions.
3537
3538 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3539
3540         * NEWS: Mention 'set|show print frame-info'.  Mention new
3541         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3542         backtrace argument.  Mention that python frame filtering code
3543         is now consistent with what 'backtrace' command prints.
3544
3545 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3546
3547         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3548         comments.
3549         (print_frame_info_auto, print_frame_info_source_line,
3550         print_frame_info_location, print_frame_info_source_and_location,
3551         print_frame_info_location_and_address, print_frame_info_short_location):
3552         New declarations.
3553         (struct frame_print_options): New member print_frame_info.
3554         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3555         * stack.h (get_user_print_what_frame_info): New declaration.
3556         (frame_show_address): New declaration.
3557         * stack.c (print_frame_arguments_choices): New value 'presence'.
3558         (print_frame_info_auto, print_frame_info_source_line,
3559         print_frame_info_location, print_frame_info_source_and_location,
3560         print_frame_info_location_and_address, print_frame_info_short_location,
3561         print_frame_info_choices, print_frame_info_print_what): New definitions.
3562         (print_frame_args): Only print dots for args if print frame-arguments
3563         is 'presence'.
3564         (frame_print_option_defs): New element for "frame-info".
3565         (get_user_print_what_frame_info): New function.
3566         (frame_show_address): Make non static.  Move comment to stack.h.
3567         (print_frame_info_to_print_what): New function.
3568         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3569         to decide what to print.
3570         (backtrace_command_1): Handle the new print_frame_arguments_presence
3571         value.
3572         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3573         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3574         (py_print_frame): In non-mi mode, use LOCATION as default for
3575         print_what, similarly to frame information printed directly by
3576         backtrace command. Handle frame-info user option in non MI mode.
3577
3578 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3579
3580         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3581         Add case for debugging 32-bit target on 64-bit host.  Revise
3582         comment.
3583
3584 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3585
3586         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3587         instead of find_function_entry_range_from_pc.
3588
3589 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3590
3591         * stack.c (find_frame_funname): Remove code which preferred
3592         minsym over symtab sym in "certain pathological cases".
3593
3594         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3595         parameter.  Change type of "do_demangle" to bool.
3596         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3597         Pass suitable "prefer_sym_over_minsym" flag to
3598         build_address_symbolic().  Don't output "+" for negative offsets.
3599         * printcmd.c (print_address_symbolic): Update invocation of
3600         build_address_symbolic to include a "prefer_sym_over_minsym"
3601         flag.
3602         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3603         Restrict cases in which use of minimal symbol is preferred to that
3604         of a found symbol.  Update comments.
3605
3606         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3607         for entry pc when entry pc is out of range for that FDE.
3608
3609 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3610
3611         PR gdb/24839:
3612         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3613         type.
3614
3615 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3616
3617         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3618         this function's Python signature.
3619
3620
3621 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3622
3623         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3624         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3625         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3626         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3627         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3628
3629
3630 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3631
3632         * h8300-tdep.c (h8300_register_name_common): New.
3633         h8300_register_name): Use h8300_register_name_common.
3634         (h8300s_register_name): Likewise.
3635         (h8300sx_register_name): Likewise.
3636         (h8300h_register_nam): New.
3637         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3638
3639
3640 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3641
3642         * arm-tdep.c (arm_skip_cmse_entry): New function.
3643         (arm_is_sgstubs_section): New function.
3644         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3645
3646 2019-07-22  Tom Tromey  <tom@tromey.com>
3647
3648         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3649         Don't self-assign.
3650
3651 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3652
3653         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3654         type_print.
3655
3656 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3657
3658         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3659         so that GDB doesn't match any msymbols when searching in the
3660         TYPES_DOMAIN.
3661         (print_symbol_info): Print using typedef_print or type_print based
3662         on the type of the symbol.  Add updated FIXME comment moved from...
3663         (_initialize_symtab): ... move and update FIXME comment to above.
3664
3665 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3666
3667         * NEWS: Mention adding -q option to "info types".
3668         * symtab.c (struct info_types_options): New struct.
3669         (info_types_options_defs): New variable.
3670         (make_info_types_options_def_group): New function.
3671         (info_types_command): Use gdb::option framework to parse options.
3672         (info_types_command_completer): New function.
3673         (_initialize_symtab): Extend the help text on "info types" and
3674         register command completer.
3675
3676 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3677
3678         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3679         (lookup_symbol_in_objfile): Change int to block_enum and add a
3680         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3681
3682 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3683
3684         * MAINTAINERS (Write After Approval): Add self.
3685
3686 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3687
3688         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3689         instruction to the dummy code region.
3690
3691 2019-07-19  Tom Tromey  <tromey@adacore.com>
3692
3693         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3694         (ARGSUSED, PARAMS, __func__): Remove rules.
3695
3696 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3697
3698         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3699         * features/arm/arm-with-iwmmxt.c: Remove.
3700         * features/arm/arm-with-iwmmxt.xml: Remove.
3701         * features/arm/arm-with-m-fpa-layout.c: Remove.
3702         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3703         * features/arm/arm-with-m-vfp-d16.c: Remove.
3704         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3705         * features/arm/arm-with-m.c: Remove.
3706         * features/arm/arm-with-m.xml: Remove.
3707         * features/arm/arm-with-neon.c: Remove.
3708         * features/arm/arm-with-neon.xml: Remove.
3709         * features/arm/arm-with-vfpv2.c: Remove.
3710         * features/arm/arm-with-vfpv2.xml: Remove.
3711         * features/arm/arm-with-vfpv3.c: Remove.
3712         * features/arm/arm-with-vfpv3.xml: Remove.
3713
3714 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3715
3716         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3717
3718 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3719
3720         * arch/aarch32.c (aarch32_create_target_description): Create
3721         target descriptions using features.
3722         * arch/arm.c (arm_create_target_description)
3723         (arm_create_mprofile_target_description): Likewise.
3724         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3725
3726 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3727
3728         * Makefile.in: Add new files.
3729         * aarch32-tdep.c: New file.
3730         * aarch32-tdep.h: New file.
3731         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3732         Call aarch32_read_description.
3733         * arch/aarch32.c: New file.
3734         * arch/aarch32.h: New file.
3735         * arch/arm.c (arm_create_target_description)
3736         (arm_create_mprofile_target_description): New function.
3737         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3738         (arm_create_target_description)
3739         (arm_create_mprofile_target_description): New declaration.
3740         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3741         read_description functions.
3742         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3743         Likewise.
3744         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3745         * arm-tdep.c (tdesc_arm_list): New variable.
3746         (arm_register_g_packet_guesses): Call create description functions.
3747         (arm_read_description) (arm_read_mprofile_description): New
3748         function.
3749         * arm-tdep.h (arm_read_description)
3750         (arm_read_mprofile_description): Add declaration.
3751         * configure.tgt: Add new files.
3752
3753 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3754
3755         * top.c (new_ui_command): Open specified terminal just once.
3756
3757 2019-07-18  Tom Tromey  <tromey@adacore.com>
3758
3759         * symtab.c (main_name): Constify return type.
3760         * symfile.c (set_initial_language): Update.
3761         * symtab.h (main_name): Constify return type.
3762
3763 2019-07-17  Tom Tromey  <tom@tromey.com>
3764
3765         * tui/tui-winsource.c (tui_update_source_window)
3766         (tui_update_source_window_as_is)
3767         (tui_update_source_windows_with_line): Remove return.
3768         * tui/tui-disasm.c (tui_show_disassem)
3769         (tui_show_disassem_and_update_source): Remove return.
3770         * tui/tui.c (tui_reset): Remove return.
3771         * tui/tui-wingeneral.c
3772         (tui_check_and_display_highlight_if_needed): Remove return.
3773
3774 2019-07-17  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3777
3778 2019-07-17  Tom Tromey  <tom@tromey.com>
3779
3780         * tui/tui-winsource.h (struct tui_exec_info_window)
3781         (struct tui_source_window_base): Move from tui-data.h.
3782         * tui/tui-winsource.c: Move many method definitions from
3783         elsewhere.  Remove "structuring" comments.
3784         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3785         (tui_source_window_base::refresh_window): Move to
3786         tui-winsource.c.
3787         * tui/tui-win.c (tui_source_window_base::refresh_all)
3788         (tui_source_window_base::update_tab_width)
3789         (tui_source_window_base::set_new_height)
3790         (tui_source_window_base::do_make_visible_with_new_height): Move to
3791         tui-winsource.c.
3792         * tui/tui-source.h: Update.
3793         * tui/tui-source.c (tui_source_window_base::reset): Move to
3794         tui-winsource.c.
3795         * tui/tui-disasm.h: Update.
3796         * tui/tui-data.h (struct tui_exec_info_window): Move to
3797         tui-winsource.h.
3798         (struct tui_source_window_base): Likewise.
3799         * tui/tui-data.c (tui_source_window_base::clear_detail)
3800         (tui_source_window_base, ~tui_source_window_base): Move to
3801         tui-winsource.c.
3802
3803 2019-07-17  Tom Tromey  <tom@tromey.com>
3804
3805         * tui/tui-win.c (tui_resize_all)
3806         (tui_source_window_base::update_tab_width)
3807         (tui_adjust_win_heights): Update.
3808         (tui_win_info::make_invisible_and_set_new_height): Rename from
3809         make_invisible_and_set_new_height.
3810         * tui/tui-data.h (struct tui_win_info)
3811         <make_invisible_and_set_new_height>: New method.
3812
3813 2019-07-17  Tom Tromey  <tom@tromey.com>
3814
3815         * tui/tui.c: Update.
3816         * tui/tui-source.h (struct tui_source_window): Move from
3817         tui-data.h.
3818         * tui/tui-layout.c: Update.
3819         * tui/tui-disasm.c: Update.
3820         * tui/tui-data.h (struct tui_source_window): Move to
3821         tui-source.h.
3822
3823 2019-07-17  Tom Tromey  <tom@tromey.com>
3824
3825         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3826         tui-data.h.
3827         * tui/tui-data.h (struct tui_disasm_window): Move to
3828         tui-disasm.h.
3829
3830 2019-07-17  Tom Tromey  <tom@tromey.com>
3831
3832         * tui/tui-regs.h (struct tui_data_item_window): Move from
3833         tui-data.h.
3834         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3835         * tui/tui-data.h (struct tui_data_item_window): Move to
3836         tui-regs.h.
3837         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3838
3839 2019-07-17  Tom Tromey  <tom@tromey.com>
3840
3841         * tui/tui.c: Update.
3842         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3843         (tui_cmd_window::max_height): Move to tui-command.c.
3844         * tui/tui-layout.c: Update.
3845         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3846         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3847         tui-command.c.
3848         * tui/tui-command.h (struct tui_cmd_window): Move from
3849         tui-data.h.
3850         * tui/tui-command.c: Remove "structuring" comments.
3851         (tui_cmd_window::clear_detail)
3852         (tui_cmd_window::do_make_visible_with_new_height)
3853         (tui_cmd_window::max_height): Move from elsewhere.
3854
3855 2019-07-17  Tom Tromey  <tom@tromey.com>
3856
3857         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3858         Now static.
3859         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3860         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3861
3862 2019-07-17  Tom Tromey  <tom@tromey.com>
3863
3864         * tui/tui.c: Update.
3865         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3866         tui-regs.c.
3867         * tui/tui-windata.h: Remove file.
3868         * tui/tui-windata.c: Remove file.
3869         * tui/tui-win.c (tui_data_window::set_new_height)
3870         (tui_data_window::do_make_visible_with_new_height): Move to
3871         tui-regs.c.
3872         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3873         * tui/tui-regs.c: Remove "structuring" comments.
3874         (tui_data_window::first_data_item_displayed)
3875         (tui_data_window::delete_data_content_windows)
3876         (tui_data_window::erase_data_content)
3877         (tui_data_window::display_all_data)
3878         (tui_data_window::refresh_all)
3879         (tui_data_window::do_scroll_vertical)
3880         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3881         (tui_data_window::do_make_visible_with_new_height)
3882         (tui_data_window::refresh_window): Move from elsewhere.
3883         (_initialize_tui_regs): Move to end of file.
3884         * tui/tui-layout.c: Update.
3885         * tui/tui-hooks.c: Update.
3886         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3887         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3888         tui-regs.c.
3889         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3890
3891 2019-07-17  Tom Tromey  <tom@tromey.com>
3892
3893         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3894         seen.
3895
3896 2019-07-17  Tom Tromey  <tom@tromey.com>
3897
3898         * tui/tui-win.c (tui_source_window_base::set_new_height)
3899         (tui_source_window_base::do_make_visible_with_new_height): Use
3900         m_has_locator field directly.
3901         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3902         method.
3903         (struct tui_source_window_base) <has_locator>: Likewise.
3904
3905 2019-07-17  Tom Tromey  <tom@tromey.com>
3906
3907         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3908         Don't declare.
3909         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3910         Remove.
3911         * tui/tui-win.c (tui_source_window_base::set_new_height)
3912         (tui_source_window_base::set_new_height)
3913         (make_invisible_and_set_new_height)
3914         (tui_source_window_base::do_make_visible_with_new_height)
3915         (tui_source_window_base::do_make_visible_with_new_height):
3916         Update.
3917         * tui/tui-layout.c (show_source_disasm_command, show_data)
3918         (show_source_or_disasm_and_command): Update.
3919         * tui/tui-layout.c (show_layout): Update.
3920
3921 2019-07-17  Tom Tromey  <tom@tromey.com>
3922
3923         * tui/tui-layout.c (make_data_window): Remove.
3924         (show_data): Unify creation and re-initialization cases.
3925
3926 2019-07-17  Tom Tromey  <tom@tromey.com>
3927
3928         * tui/tui-layout.c (make_source_window, make_disasm_window):
3929         Remove.
3930         (show_data): Unify creation and re-initialization cases.
3931
3932 2019-07-17  Tom Tromey  <tom@tromey.com>
3933
3934         * tui/tui-layout.c (make_command_window): Remove.
3935         (show_source_disasm_command, show_source_or_disasm_and_command):
3936         Unify creation and re-initialization cases.
3937
3938 2019-07-17  Tom Tromey  <tom@tromey.com>
3939
3940         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3941         creation and re-initialization cases.
3942
3943 2019-07-17  Tom Tromey  <tom@tromey.com>
3944
3945         * tui/tui-regs.c (tui_get_register): Return void.
3946
3947 2019-07-17  Tom Tromey  <tom@tromey.com>
3948
3949         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3950         Simplify.
3951
3952 2019-07-17  Tom Tromey  <tom@tromey.com>
3953
3954         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3955         resetting.
3956
3957 2019-07-17  Tom Tromey  <tom@tromey.com>
3958
3959         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3960         * tui/tui-regs.c (tui_reg_layout): New function.
3961         (tui_show_registers, tui_reg_command): Use it.
3962         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3963         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3964         parameters.
3965         (tui_layout_command): Remove.
3966
3967 2019-07-17  Tom Tromey  <tom@tromey.com>
3968
3969         * tui/tui-layout.h (tui/tui-layout): Return void.
3970         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3971
3972 2019-07-17  Tom Tromey  <tom@tromey.com>
3973
3974         * tui/tui-layout.c (show_source_disasm_command, show_data):
3975         Update.
3976         (reset_locator): Remove.
3977         (show_source_or_disasm_and_command): Update.
3978
3979 2019-07-17  Tom Tromey  <tom@tromey.com>
3980
3981         * tui/tui-source.c (tui_source_window_base::reset): Remove
3982         win_type parameter.
3983         * tui/tui-layout.c (make_command_window, make_source_window)
3984         (make_disasm_window, make_data_window)
3985         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3986         (reset_locator, show_source_or_disasm_and_command): Update.
3987         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3988         win_type parameter.
3989         (struct tui_source_window_base) <reset>: Likewise.
3990
3991 2019-07-17  Tom Tromey  <tom@tromey.com>
3992
3993         * tui/tui-layout.c (show_source_disasm_command): Use
3994         reset_locator.
3995         (reset_locator): New function.
3996         (init_and_make_win): Remove.
3997         (show_source_or_disasm_and_command): Use reset_locator.
3998
3999 2019-07-17  Tom Tromey  <tom@tromey.com>
4000
4001         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4002         condition.
4003         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4004         Remove condition.
4005         * tui/tui-source.c (tui_source_window_base::reset): New method.
4006         * tui/tui-layout.c (make_command_window): Don't call
4007         init_and_make_win.
4008         (make_source_window, make_disasm_window): Don't call
4009         make_source_or_disasm_window.
4010         (make_data_window): Don't call init_and_make_win.  Change calling
4011         convention.
4012         (show_source_disasm_command, show_data): Simplify.
4013         (make_source_or_disasm_window): Remove.
4014         (show_source_or_disasm_and_command): Simplify.
4015         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4016         (struct tui_source_window_base) <reset>: Likewise.
4017         <execution_info>: Remove initializer.
4018         * tui/tui-data.c (tui_source_window_base): Initialize
4019         execution_info.
4020
4021 2019-07-17  Tom Tromey  <tom@tromey.com>
4022
4023         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4024         variable.
4025
4026 2019-07-17  Tom Tromey  <tom@tromey.com>
4027
4028         * tui/tui.c (tui_rl_other_window): Update.
4029         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4030         superclass method first.  Always iterate over regs_content.
4031         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4032         method.
4033         * tui/tui-win.c (tui_set_focus_command): Update.
4034
4035 2019-07-17  Tom Tromey  <tom@tromey.com>
4036
4037         * tui/tui-win.c (tui_set_focus_command): Rename from
4038         tui_set_focus.  Call tui_enable.
4039         (tui_set_focus_command): Remove.
4040
4041 2019-07-17  Tom Tromey  <tom@tromey.com>
4042
4043         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4044         refresh_window.
4045         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4046         touchwin.
4047         (tui_data_window::refresh_window): Call refresh_window on data
4048         items.  Always call superclass refresh_window.
4049         (tui_win_info::refresh): Remove.
4050         (tui_source_window_base::refresh_window): Update.
4051         (tui_refresh_all): Update.
4052         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4053         refresh_window.
4054         (show_source_or_disasm_and_command): Likewise.
4055         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4056         (struct tui_source_window_base) <refresh>: Likewise.
4057
4058 2019-07-17  Tom Tromey  <tom@tromey.com>
4059
4060         * tui/tui-winsource.c (tui_clear_source_content)
4061         (tui_show_source_content): Update.
4062         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4063         whether content is empty.
4064         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4065         Remove.
4066
4067 2019-07-17  Tom Tromey  <tom@tromey.com>
4068
4069         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4070         window's contents.
4071         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4072         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4073
4074 2019-07-17  Tom Tromey  <tom@tromey.com>
4075
4076         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4077         (struct tui_data_item_window): Update.
4078
4079 2019-07-17  Tom Tromey  <tom@tromey.com>
4080
4081         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4082         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4083         defines.
4084
4085 2019-07-17  Tom Tromey  <tom@tromey.com>
4086
4087         * tui/tui-winsource.h (tui_erase_source_content)
4088         (tui_clear_source_content): Remove "display_prompt" parameter.
4089         * tui/tui-winsource.c (tui_update_source_window_as_is)
4090         (tui_update_source_windows_with_addr): Update.
4091         (tui_clear_source_content): Remove "display_prompt" parameter.
4092         (tui_erase_source_content): Likewise.  Simplify.
4093         (tui_show_source_content): Update.
4094         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4095         * tui/tui-stack.c (tui_show_frame_info): Update.
4096         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4097         Remove defines.
4098
4099 2019-07-17  Tom Tromey  <tom@tromey.com>
4100
4101         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4102         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4103         parameter.
4104         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4105         parameter.
4106
4107 2019-07-17  Tom Tromey  <tom@tromey.com>
4108
4109         * tui/tui-winsource.c (tui_clear_source_content)
4110         (tui_show_source_content, tui_show_exec_info_content)
4111         (tui_clear_exec_info_content): Update.
4112         * tui/tui-stack.c (tui_show_locator_content): Update.
4113         (tui_show_frame_info): Update.
4114         * tui/tui-source.h (tui_source_window): Don't declare.
4115         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4116         from tui_source_is_displayed.
4117         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4118         Remove field.
4119         (struct tui_source_window_base) <content_in_use>: New field.  Now
4120         bool.
4121         (struct tui_source_window) <showing_source_p>: New method.
4122         (TUI_SRC_WIN): Change cast.
4123         * tui/tui-data.c (tui_initialize_static_data): Update.
4124
4125 2019-07-17  Tom Tromey  <tom@tromey.com>
4126
4127         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4128         location_matches_p.
4129         * tui/tui-source.c (tui_source_window::location_matches_p): New
4130         method.
4131         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4132         method.
4133         * tui/tui-data.h (struct tui_source_window_base)
4134         <location_matches_p>: New method.
4135         (struct tui_source_window, struct tui_disasm_window)
4136         <location_matches_p>: Likewise.
4137
4138 2019-07-17  Tom Tromey  <tom@tromey.com>
4139
4140         * tui/tui-win.c (tui_set_win_height_command): Rename from
4141         tui_set_win_height.
4142         (tui_set_win_height_command): Remove.
4143
4144 2019-07-17  Tom Tromey  <tom@tromey.com>
4145
4146         * tui/tui-source.c (tui_source_window): New constructor.  Add
4147         observer.
4148         (~tui_source_window): New destructor.
4149         (tui_source_window::style_changed): New method.
4150         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4151         (tui_attach_detach_observers): Update.
4152         * tui/tui-data.h (struct tui_source_window): Make constructor not
4153         inline.  Add destructor.
4154         (struct tui_source_window) <style_changed>: New method.
4155         <m_observable>: New member.
4156
4157 2019-07-17  Tom Tromey  <tom@tromey.com>
4158
4159         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4160         * tui/tui-win.c (tui_resize_all): Fix typo.
4161
4162 2019-07-17  Tom Tromey  <tom@tromey.com>
4163
4164         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4165         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4166         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4167         * tui/tui-win.c (window_name_completer): Use foreach.
4168         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4169         (update_tab_width): Likewise.
4170         * tui/tui-layout.c (show_layout): Update.
4171         * tui/tui-data.h (class tui_window_iterator): New.
4172         (struct all_tui_windows): New.
4173         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4174
4175 2019-07-17  Tom Tromey  <tom@tromey.com>
4176
4177         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4178         parameter.  Don't reference globals.
4179         (tui_reg_command): Update.
4180
4181 2019-07-17  Tom Tromey  <tom@tromey.com>
4182
4183         * tui/tui-regs.c (tui_show_registers): Simplify.
4184
4185 2019-07-17  Tom Tromey  <tom@tromey.com>
4186
4187         * tui/tui-regs.c (tui_show_registers): Update.
4188         (tui_show_register_group): Add win_info parameter.
4189
4190 2019-07-17  Tom Tromey  <tom@tromey.com>
4191
4192         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4193         Rename from tui_display_reg_element_at_line.
4194         (tui_data_window::display_registers_from_line): Update.
4195         * tui/tui-data.h (struct tui_data_window)
4196         <display_reg_element_at_line>: New method.
4197
4198 2019-07-17  Tom Tromey  <tom@tromey.com>
4199
4200         * tui/tui-regs.h (tui_display_registers_from)
4201         (tui_display_registers_from_line): Don't declare.
4202         * tui/tui-windata.c (tui_data_window::display_all_data)
4203         (tui_data_window::refresh_all)
4204         (tui_data_window::do_scroll_vertical): Update.
4205         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4206         from tui_display_registers_from.
4207         (tui_display_reg_element_at_line): Update.
4208         (tui_data_window::display_registers_from_line): Rename from
4209         tui_display_registers_from_line.
4210         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4211         display_registers_from_line>: New methods.
4212
4213 2019-07-17  Tom Tromey  <tom@tromey.com>
4214
4215         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4216         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4217         from tui_erase_data_content.
4218         (tui_data_window::display_all_data)
4219         (tui_data_window::refresh_all)
4220         (tui_data_window::do_scroll_vertical): Update.
4221         * tui/tui-regs.c (tui_show_registers): Update.
4222         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4223         New method.
4224
4225 2019-07-17  Tom Tromey  <tom@tromey.com>
4226
4227         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4228         declare.
4229         * tui/tui-windata.c
4230         (tui_data_window::delete_data_content_windows): Rename from
4231         tui_delete_data_content_windows.
4232         (tui_data_window::display_all_data)
4233         (tui_data_window::do_scroll_vertical): Update.
4234         * tui/tui-data.h (struct tui_data_window)
4235         <delete_data_content_windows>: New method.
4236
4237 2019-07-17  Tom Tromey  <tom@tromey.com>
4238
4239         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4240         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4241
4242 2019-07-17  Tom Tromey  <tom@tromey.com>
4243
4244         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4245         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4246         from tui_display_all_data.
4247         * tui/tui-win.c
4248         (tui_data_window::do_make_visible_with_new_height): Update.
4249         * tui/tui-regs.c (tui_show_registers): Update.
4250         * tui/tui-layout.c (tui_set_layout): Update.
4251         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4252         method.
4253
4254 2019-07-17  Tom Tromey  <tom@tromey.com>
4255
4256         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4257         * tui/tui-windata.c (tui_display_data_from): Remove.
4258         (tui_data_window::refresh_all): Update.
4259
4260 2019-07-17  Tom Tromey  <tom@tromey.com>
4261
4262         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4263         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4264         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4265         tui_display_registers_from_line.
4266         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4267         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4268         "force_display" parameter.
4269
4270 2019-07-17  Tom Tromey  <tom@tromey.com>
4271
4272         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4273         declare.
4274         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4275         Rename from tui_first_reg_element_no_inline.
4276         (tui_display_reg_element_at_line)
4277         (tui_display_registers_from_line): Update.
4278         * tui/tui-data.h (struct tui_data_window)
4279         <first_reg_element_no_inline>: New method.
4280
4281 2019-07-17  Tom Tromey  <tom@tromey.com>
4282
4283         * tui/tui-windata.c (tui_display_data_from)
4284         (tui_data_window::do_scroll_vertical): Update.
4285         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4286         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4287         Rename from tui_line_from_reg_element_no.
4288         (tui_display_registers_from_line): Update.
4289         * tui/tui-data.h (struct tui_data_window)
4290         <line_from_reg_element_no>: New method.
4291
4292 2019-07-17  Tom Tromey  <tom@tromey.com>
4293
4294         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4295         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4296         tui_last_regs_line_no.
4297         (tui_display_reg_element_at_line)
4298         (tui_display_registers_from_line): Update.
4299         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4300         method.
4301
4302 2019-07-17  Tom Tromey  <tom@tromey.com>
4303
4304         PR tui/24722:
4305         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4306         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4307         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4308         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4309         (tui_update_breakpoint_info): Likewise.
4310         * tui/tui-hooks.c (tui_event_create_breakpoint)
4311         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4312         Update.
4313
4314 2019-07-17  Tom Tromey  <tom@tromey.com>
4315
4316         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4317
4318 2019-07-17  Tom Tromey  <tom@tromey.com>
4319
4320         * tui/tui-winsource.c (tui_update_source_window_as_is)
4321         (tui_update_source_windows_with_addr): Update.
4322         * tui/tui-source.h (tui_set_source_content)
4323         (tui_show_symtab_source): Add "win_info" parameter.
4324         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4325         parameter.
4326         (tui_show_symtab_source): Likewise.
4327
4328 2019-07-17  Tom Tromey  <tom@tromey.com>
4329
4330         * tui/tui-wingeneral.c
4331         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4332
4333 2019-07-17  Tom Tromey  <tom@tromey.com>
4334
4335         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4336         (struct tui_cmd_window) <can_scroll>: New method.
4337         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4338         method.
4339
4340 2019-07-17  Tom Tromey  <tromey@adacore.com>
4341
4342         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4343         do_field_signed>: Rename.  Change type of "value".
4344         * ui-out.c (ui_out::field_signed): Rename from field_int.
4345         Change type of "value".
4346         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4347         type of "value".
4348         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4349         do_field_int.  Change type of "value".
4350         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4351         do_field_int.  Change type of "value".
4352         * tracepoint.c (trace_status_mi, tfind_1)
4353         (print_one_static_tracepoint_marker): Update.
4354         * thread.c (print_thread_info_1, print_selected_thread_frame):
4355         Update.
4356         * stack.c (print_frame, print_frame_info): Update.
4357         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4358         Update.
4359         * source.c (print_source_lines_base): Update.
4360         * skip.c (info_skip_command): Update.
4361         * record-btrace.c (btrace_ui_out_decode_error)
4362         (btrace_call_history_src_line): Update.
4363         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4364         Update.
4365         * progspace.c (print_program_space): Update.
4366         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4367         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4368         do_field_int.  Change type of "value".
4369         * mi/mi-out.c (mi_ui_out::do_table_begin)
4370         (mi_ui_out::do_table_header): Update.
4371         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4372         type of "value".
4373         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4374         (mi_cmd_data_list_changed_registers, output_register)
4375         (mi_cmd_data_read_memory, mi_load_progress)
4376         (mi_cmd_trace_frame_collected): Update.
4377         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4378         Update.
4379         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4380         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4381         (mi_cmd_var_list_children, varobj_update_one): Update.
4382         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4383         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4384         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4385         * inferior.c (print_inferior): Update.
4386         * gdb_bfd.c (print_one_bfd): Update.
4387         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4388         Update.
4389         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4390         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4391         do_field_int.  Change type of "value".
4392         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4393         do_field_int.  Change type of "value".
4394         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4395         (print_one_breakpoint_location, print_it_catch_fork)
4396         (print_one_catch_fork, print_it_catch_vfork)
4397         (print_one_catch_vfork, print_it_catch_solib)
4398         (print_it_catch_exec, print_it_ranged_breakpoint)
4399         (print_mention_watchpoint, print_mention_masked_watchpoint)
4400         (bkpt_print_it, update_static_tracepoint): Update.
4401         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4402         * break-catch-syscall.c (print_it_catch_syscall): Update.
4403         * ada-tasks.c (print_ada_task_info): Update.
4404         * ada-lang.c (print_it_exception, print_mention_exception):
4405         Update.
4406
4407 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4408
4409         PR breakpoints/24541
4410         * gdbarch.c: Regenerate.
4411         * gdbarch.h: Regenerate.
4412         * gdbarch.sh: Adjust return type and parameter types for
4413         'stap_adjust_register'.
4414         (i386_stap_adjust_register): Adjust signature and return new
4415         register name.
4416         * stap-probe.c (stap_parse_register_operand): Adjust use of
4417         'gdbarch_stap_adjust_register'.
4418
4419 2019-07-17  Tom Tromey  <tromey@adacore.com>
4420
4421         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4422         declare VEC.
4423         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4424         std::vector.
4425         (struct s390_process_info): Add initializers.
4426         (s390_add_process): Use new.
4427         (s390_linux_nat_target::low_forget_process): Use delete.
4428         (s390_linux_nat_target::low_new_fork)
4429         (s390_linux_nat_target::stopped_by_watchpoint)
4430         (s390_linux_nat_target::low_prepare_to_resume)
4431         (s390_linux_nat_target::insert_watchpoint)
4432         (s390_linux_nat_target::insert_hw_breakpoint)
4433         (s390_linux_nat_target::remove_watchpoint)
4434         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4435
4436 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4437
4438         * aarch64-fbsd-nat.c: Include regcache.h.
4439         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4440         argument.
4441         (aarch64_fbsd_nat_target::fetch_registers)
4442         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4443         variable.
4444         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4445
4446 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4447
4448         * fbsd-nat.c: Include gdbarch.h.
4449
4450 2019-07-15  Tom Tromey  <tromey@adacore.com>
4451
4452         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4453
4454 2019-07-15  Tom Tromey  <tromey@adacore.com>
4455
4456         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4457         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4458         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4459         * cli-out.c (cli_ui_out::do_field_int): New method.
4460         * ui-out.c (ui_out::field_unsigned): New method.
4461         * symfile.c (generic_load): Use field_unsigned.
4462         (print_transfer_performance): Likewise.
4463         * record-btrace.c (ui_out_field_uint): Remove.
4464         (btrace_call_history_insn_range, btrace_call_history): Use
4465         field_unsigned.
4466         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4467         field_unsigned.
4468         * ui-out.h (class ui_out) <field_unsigned>: New method.
4469         <do_field_unsigned>: Likewise.
4470
4471 2019-07-15  Tom Tromey  <tromey@adacore.com>
4472
4473         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4474         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4475         * target.c (flash_erase_command): Use field_string.
4476         * infrun.c (print_signal_received_reason): Use field_string.
4477         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4478         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4479         field_string.
4480         * ada-tasks.c (print_ada_task_info): Use field_string.
4481
4482 2019-07-15  Tom Tromey  <tromey@adacore.com>
4483
4484         * target.c (flash_erase_command): Use field_core_addr.
4485         * symfile.c (generic_load): Use field_core_addr.
4486         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4487         Use field_core_addr.
4488         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4489         field_core_addr.
4490
4491 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4492
4493         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4494         value if its desired type is smaller than a CORE_ADDR and signed.
4495
4496 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4497
4498         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4499         of changes to field names, and use new is_reference field to
4500         decide if a property is a reference or not.
4501         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4502         field.
4503         (struct dwarf2_property_baton): Update header comment, rename
4504         'referenced_type' to 'property_type' and update comments.
4505         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4506         default property type, store in property baton, update to take
4507         accound of renamed field.
4508         (read_func_scope): Update call to attr_to_dynamic_prop.
4509         (read_array_type): Likewise.
4510         (dwarf2_per_cu_addr_sized_int_type): New function.
4511         (read_subrange_index_type): Move type finding code to
4512         dwarf2_per_cu_addr_sized_int_type.
4513         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4514         (dwarf2_per_cu_addr_type): New function.
4515         (set_die_type): Update calls to attr_to_dynamic_prop.
4516
4517 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4518
4519         * dwarf2read.c (read_subrange_index_type): New function.
4520         (read_subrange_type): Move code into new function and call it.
4521         * gdbtypes.c (create_range_type): Add some asserts.
4522
4523 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4524
4525         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4526         update return statements.
4527         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4528         declaration, and update comment to match.
4529         * gdbtypes.c (resolve_dynamic_array): Update call to
4530         dwarf2_evaluate_property to match new return type.
4531
4532 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4533
4534         * valarith.c (value_subscripted_rvalue): Change lowerbound
4535         parameter type from int to LONGEST.
4536         * value.h (value_subscripted_rvalue): Likewise in declaration.
4537
4538 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4539
4540         * cli/cli-utils.c (info_print_command_completer): New function.
4541         * cli/cli-utils.h: Add 'completer.h' include, and forward
4542         declaration for 'struct cmd_list_element'.
4543         (info_print_command_completer): Declare.
4544         * stack.c (_initialize_stack): Add completer for 'info locals' and
4545         'info args'.
4546         * symtab.c (_initialize_symtab): Add completer for 'info
4547         variables' and 'info functions'.
4548         * NEWS: Mention completion for additional info commands.
4549
4550 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4551
4552         * cli/cli-utils.c (extract_info_print_args): Delete.
4553         (extract_arg_maybe_quoted): Delete.
4554         (info_print_options_defs): New variable.
4555         (make_info_print_options_def_group): New function.
4556         (extract_info_print_options): Define new function.
4557         * cli/cli-utils.h (extract_info_print_args): Delete.
4558         (struct info_print_options): New structure.
4559         (extract_info_print_options): Declare new function.
4560         * stack.c (info_locals_command): Update to use new
4561         extract_info_print_options, also add a header comment.
4562         (info_args_command): Likewise.
4563         * symtab.c (info_variables_command): Likewise.
4564         (info_functions_command): Likewise.
4565
4566 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4567
4568         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4569         to extract string arguments.
4570         * common/common-utils.c (extract_string_maybe_quoted): New function.
4571         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4572
4573 2019-07-11  Tom Tromey  <tromey@adacore.com>
4574
4575         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4576         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4577         * top.h (gdbinit): Don't declare.
4578         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4579         into...
4580         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4581         * top.c (gdb_init): Don't call init_cli_cmds.
4582         (gdbinit): Remove.
4583         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4584
4585 2019-07-11  Tom Tromey  <tromey@adacore.com>
4586
4587         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4588         after it has been moved.
4589
4590 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4591
4592         * valops.c (value_must_coerce_to_target): Change return type to
4593         bool.
4594         * value.h (value_must_coerce_to_target): Likewise.
4595
4596 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4597
4598         * breakpoint.c (is_hardware_watchpoint): Remove
4599         forward-declaration.
4600         (is_masked_watchpoint): Change return type to bool.
4601         (is_tracepoint): Likewise.
4602         (is_breakpoint): Likewise.
4603         (is_hardware_watchpoint): Likewise.
4604         (is_watchpoint): Likewise.
4605         (is_no_memory_software_watchpoint): Likewise.
4606         (is_catchpoint): Likewise.
4607         (breakpoint_1): Make FILTER parameter's return type bool.
4608         is_masked_watchpoint): Change return type to bool.
4609         (save_breakpoints): Make FILTER parameter's return type bool.
4610         * breakpoint.h (is_breakpoint): Change return type to bool.
4611         (is_watchpoint): Likewise.
4612         (is_catchpoint): Likewise.
4613         (is_tracepoint): Likewise.
4614
4615 2019-07-10  Tom Tromey  <tom@tromey.com>
4616
4617         * defs.h: Don't include gdbarch.h.
4618         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4619         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4620         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4621         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4622         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4623         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4624         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4625         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4626         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4627         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4628         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4629         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4630         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4631         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4632         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4633         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4634         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4635         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4636         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4637         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4638         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4639         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4640         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4641         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4642         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4643         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4644         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4645
4646 2019-07-10  Tom Tromey  <tromey@adacore.com>
4647
4648         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4649         * breakpoint.c (init_ada_exception_breakpoint): Register as
4650         bp_catchpoint.
4651         (print_one_breakpoint_location, print_one_breakpoint): Use
4652         is_ada_exception_catchpoint.
4653         * ada-lang.c (class ada_catchpoint_location): Pass
4654         bp_loc_software_breakpoint to bp_location constructor.
4655         (is_ada_exception_catchpoint): New function.
4656
4657 2019-07-10  Tom Tromey  <tromey@adacore.com>
4658
4659         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4660         VEC.
4661         (struct arm_exidx_entry): New method operator<.
4662         (struct arm_exidx_data) <section_maps>: Change type.
4663         (arm_exidx_data_free): Remove.
4664         (arm_exidx_data_key): Change type.  Move lower.
4665         (arm_exidx_new_objfile): Update.
4666         (arm_compare_exidx_entries): Remove.
4667         (arm_find_exidx_entry, _initialize_arm_tdep)
4668
4669 2019-07-10  Tom Tromey  <tromey@adacore.com>
4670
4671         * solib-spu.c (ocl_program_data_key): Change type.
4672         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4673         Update.
4674
4675 2019-07-10  Tom Tromey  <tromey@adacore.com>
4676
4677         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4678         (struct solib_aix_inferior_data) <library_list>: Change type.
4679         (solib_aix_inferior_data_handle): Change type.
4680         (get_solib_aix_inferior_data): Update.
4681         (solib_aix_free_library_list): Remove.
4682         (library_list_start_library): Update.
4683         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4684         return type.
4685         (solib_aix_get_library_list)
4686         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4687         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4688
4689 2019-07-10  Tom Tromey  <tromey@adacore.com>
4690
4691         * solib-dsbt.c (struct dsbt_info): Add initializers.
4692         (solib_dsbt_pspace_data): Change type.
4693         (dsbt_pspace_data_cleanup): Remove.
4694         (get_dsbt_info, _initialize_dsbt_solib): Update.
4695
4696 2019-07-10  Tom Tromey  <tromey@adacore.com>
4697
4698         * spu-tdep.c (spu_overlay_data): Change type.
4699         (spu_get_overlay_table, spu_overlay_new_objfile)
4700         (_initialize_spu_tdep): Update.
4701
4702 2019-07-10  Tom Tromey  <tromey@adacore.com>
4703
4704         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4705         destructor.
4706         (dbx_objfile_data_key): Change type and declare later.
4707         (DBX_SYMFILE_INFO): Rewrite.
4708         * dbxread.c (dbx_objfile_data_key): Change type.
4709         (dbx_symfile_init): Update.
4710         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4711         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4712         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4713
4714 2019-07-10  Tom Tromey  <tromey@adacore.com>
4715
4716         * jit.c (jit_program_space_key): Change type.  Move lower.
4717         (get_jit_program_space_data): Update.
4718         (jit_program_space_data_cleanup): Remove.
4719         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4720         Update.
4721         (struct jit_program_space_data): Add initializers.
4722
4723 2019-07-10  Tom Tromey  <tromey@adacore.com>
4724
4725         * solib-darwin.c (struct darwin_info): Add initializers.
4726         (solib_darwin_pspace_data): Change type.
4727         (darwin_pspace_data_cleanup): Remove.
4728         (get_darwin_info, _initialize_darwin_solib): Update.
4729
4730 2019-07-10  Tom Tromey  <tromey@adacore.com>
4731
4732         * remote-sim.c (struct sim_inferior_data): Add initializers,
4733         constructor, and destructor.
4734         (sim_inferior_data_key): Change type.  Move lower.
4735         (check_for_duplicate_sim_descriptor): Update.
4736         (get_sim_inferior_data): Use new.  Update.
4737         (~sim_inferior_data_cleanup): Rename from
4738         sim_inferior_data_cleanup.  Simplify.
4739         (gdbsim_close_inferior, simulator_command)
4740         (sim_command_completer, _initialize_remote_sim): Update.
4741         (next_pid, INITIAL_PID): Move earlier.
4742
4743 2019-07-10  Tom Tromey  <tromey@adacore.com>
4744
4745         * python/python-internal.h (create_thread_object): Return
4746         gdbpy_ref.
4747         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4748         * python/py-inferior.c (struct threadlist_entry): Add
4749         constructor.
4750         <thread_obj>: Now a gdbpy_ref.
4751         (thread_to_thread_object): Update.
4752         (add_thread_object): Use new.
4753         (delete_thread_object): Use delete.
4754         (infpy_threads): Update.
4755         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4756         GIL.
4757
4758 2019-07-10  Tom Tromey  <tromey@adacore.com>
4759
4760         * valops.c (value_cast): Specialize error message for Ada.
4761
4762 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4763
4764         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4765
4766 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4767
4768         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4769         bpstat_should_step): Return bool, adjust comments.
4770         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4771         bpstat_should_step): Likewise.
4772
4773 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4774
4775         * features/Makefile: Use feature target descriptions for Arm.
4776         * features/arm/arm-core.c: Generate new file.
4777         * features/arm/arm-fpa.c: Likewise.
4778         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4779         * features/arm/arm-m-profile.c: Likewise.
4780         * features/arm/arm-vfpv2.c: Likewise.
4781         * features/arm/arm-vfpv3.c: Likewise.
4782         * features/arm/xscale-iwmmxt.c: Likewise.
4783         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4784
4785 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4786
4787         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4788         ptrace earlier.
4789
4790 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4791
4792         * features/aarch64-pauth.c: Regenerate.
4793
4794 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4795
4796         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4797         bool.
4798         (bpstat_what): Use false instead of 0.
4799
4800 2019-07-09  Pedro Alves  <palves@redhat.com>
4801
4802         * break-catch-throw.c (is_exception_catchpoint): New.
4803         * breakpoint.c (print_one_breakpoint_location): New parameter
4804         'raw_loc'.  Handle it.  Use
4805         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4806         looking at the breakpoint's type.
4807         (print_one_breakpoint): If handling "maint info breakpoints", also
4808         print locations of exception catchpoints.
4809         * breakpoint.h (is_exception_catchpoint): Declare.
4810
4811 2019-07-09  Pedro Alves  <palves@redhat.com>
4812
4813         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4814         "addr" field.
4815         (allocate_location_exception_catchpoint): New.
4816         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4817         (initialize_throw_catchpoint_ops): Install
4818         allocate_location_exception_catchpoint as allocate_location
4819         method.
4820         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4821         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4822         bp_loc_other.
4823         (breakpoint_address_is_meaningful): Delete.
4824         (bl_address_is_meaningful): New.
4825         (breakpoint_locations_match): Adjust comment.
4826         (bp_location_from_bp_type): New, factored out of...
4827         (bp_location::bp_location(breakpoint *)): ... this.
4828         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4829         factored out of...
4830         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4831         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4832         breakpoint_address_is_meaningful.
4833         (bp_locations_compare): Adjust comment.
4834         (update_global_location_list): Use bl_address_is_meaningful
4835         instead of breakpoint_address_is_meaningful.
4836         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4837         explicit.
4838         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4839         * python/py-breakpoint.c (bppy_get_location): No longer check
4840         whether location is null.
4841
4842 2019-07-09  Pedro Alves  <palves@redhat.com>
4843
4844         PR c++/15468
4845         * breakpoint.c (print_one_breakpoint_location): Remove
4846         single-location assert.
4847
4848 2019-07-09  Tom Tromey  <tom@tromey.com>
4849
4850         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4851         * configure: Rebuild.
4852         * configure.ac: Change common to gdbsupport.
4853         * gdbsupport: Rename from common.
4854         * acinclude.m4: Change common to gdbsupport.
4855         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4856         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4857         gdbsupport.
4858         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4859         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4860         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4861         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4862         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4863         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4864         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4865         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4866         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4867         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4868         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4869         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4870         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4871         coff-pe-read.c, command.h, compile/compile-c-support.c,
4872         compile/compile-c.h, compile/compile-cplus-symbols.c,
4873         compile/compile-cplus-types.c, compile/compile-cplus.h,
4874         compile/compile-loc2c.c, compile/compile.c, completer.c,
4875         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4876         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4877         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4878         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4879         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4880         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4881         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4882         features/aarch64-core.c, features/aarch64-fpu.c,
4883         features/aarch64-pauth.c, features/aarch64-sve.c,
4884         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4885         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4886         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4887         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4888         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4889         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4890         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4891         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4892         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4893         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4894         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4895         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4896         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4897         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4898         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4899         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4900         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4901         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4902         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4903         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4904         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4905         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4906         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4907         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4908         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4909         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4910         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4911         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4912         minsyms.c, mips-linux-tdep.c, namespace.h,
4913         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4914         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4915         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4916         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4917         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4918         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4919         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4920         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4921         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4922         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4923         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4924         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4925         procfs.c, producer.c, progspace.h, psymtab.h,
4926         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4927         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4928         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4929         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4930         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4931         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4932         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4933         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4934         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4935         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4936         target-memory.c, target.c, target.h, target/waitstatus.c,
4937         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4938         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4939         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4940         unittests/array-view-selftests.c,
4941         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4942         unittests/common-utils-selftests.c,
4943         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4944         unittests/format_pieces-selftests.c,
4945         unittests/function-view-selftests.c,
4946         unittests/lookup_name_info-selftests.c,
4947         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4948         unittests/mkdir-recursive-selftests.c,
4949         unittests/observable-selftests.c,
4950         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4951         unittests/parse-connection-spec-selftests.c,
4952         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4953         unittests/scoped_fd-selftests.c,
4954         unittests/scoped_mmap-selftests.c,
4955         unittests/scoped_restore-selftests.c,
4956         unittests/string_view-selftests.c, unittests/style-selftests.c,
4957         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4958         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4959         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4960         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4961         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4962         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4963
4964 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4965
4966         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4967         bool value.
4968         (decode_digits_ordinary): Set explicit_line field in sal.
4969         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4970         symtab_and_line that was set on an explicit line number in
4971         assembler code.  Do always update the recorded symtab and line if
4972         we do skip the prologue.
4973
4974 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4975
4976         * breakpoint.c (set_breakpoint_location_function): Remove
4977         explicit_loc parameter.
4978         (momentary_breakpoint_from_master): Update call to
4979         set_breakpoint_location_function.
4980         (add_location_to_breakpoint): Likewise.
4981
4982 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4983
4984         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4985         required features based on default bfd type when no specific bfd
4986         is present.
4987
4988 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4989
4990         * NEWS: Mention that GDB printf and eval commands can now print
4991         C-style and Ada-style convenience var strings without
4992         calling the inferior.
4993         * printcmd.c (printf_c_string): Locally print GDB internal var
4994         instead of transiting via the inferior.
4995         (printf_wide_c_string): Likewise.
4996
4997 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4998
4999         PR breakpoints/25011
5000         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5001
5002 2019-07-04  Tom Tromey  <tom@tromey.com>
5003
5004         PR tui/24724:
5005         * tui/tui-winsource.c (tui_clear_source_content): Update.
5006         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5007         (tui_update_breakpoint_info): Update.
5008         (tui_set_exec_info_content): Update.
5009         * tui/tui-source.c (tui_set_source_content_nil): Update.
5010         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5011         has_break.
5012         * tui/tui-data.h (enum tui_bp_flag): New.
5013         (tui_bp_flags): New enum flags type.
5014         (struct tui_source_element) <break_mode>: Change type.  Rename
5015         from has_break.
5016         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5017         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5018         constants.
5019         * tui/tui-winsource.h: Fix comment.
5020
5021 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5022
5023         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5024         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5025         (store_fpregs_to_thread)
5026         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5027         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5028         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5029         (IWMMXT_REGS_SIZE): Add define.
5030         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5031         (fetch_vfp_regs, store_vfp_regs)
5032         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5033         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5034
5035 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5036
5037         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5038         defines.
5039         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5040         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5041         (ARM_INT_REGISTER_SIZE): ...to this.
5042         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5043         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5044         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5045         (arm_linux_collect_gregset, supply_nwfpe_register)
5046         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5047         defines.
5048         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5049         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5050         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5051         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5052         (arm_return_in_memory, arm_store_return_value)
5053         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5054         (arm_record_ld_st_multiple): Likewise.
5055         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5056         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5057
5058 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5059
5060         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5061         AARCH64_DISPLACED_MODIFIED_INSNS.
5062         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5063         (aarch64_displaced_step_copy_insn): Likewise.
5064         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5065         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5066         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5067         ARM_DISPLACED_MODIFIED_INSNS.
5068         * arm-tdep.c (arm_gdbarch_init): Likewise.
5069         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5070         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5071         (struct arm_displaced_step_closure): Use
5072         ARM_DISPLACED_MODIFIED_INSNS.
5073
5074 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5075
5076         * features/Makefile: Remove unused xml files.
5077         * features/aarch64.xml: Remove.
5078         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5079         * features/i386/amd64-avx-avx512.xml: Remove.
5080         * features/i386/amd64-avx-linux.xml: Remove.
5081         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5082         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5083         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5084         * features/i386/amd64-avx-mpx.xml: Remove.
5085         * features/i386/amd64-avx.xml: Remove.
5086         * features/i386/amd64-linux.xml: Remove.
5087         * features/i386/amd64-mpx-linux.xml: Remove.
5088         * features/i386/amd64-mpx.xml: Remove.
5089         * features/i386/amd64.xml: Remove.
5090         * features/i386/i386-avx-avx512-linux.xml: Remove.
5091         * features/i386/i386-avx-avx512.xml: Remove.
5092         * features/i386/i386-avx-linux.xml: Remove.
5093         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5094         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5095         * features/i386/i386-avx-mpx-linux.xml: Remove.
5096         * features/i386/i386-avx-mpx.xml: Remove.
5097         * features/i386/i386-avx.xml: Remove.
5098         * features/i386/i386-linux.xml: Remove.
5099         * features/i386/i386-mmx-linux.xml: Remove.
5100         * features/i386/i386-mmx.xml: Remove.
5101         * features/i386/i386-mpx-linux.xml: Remove.
5102         * features/i386/i386-mpx.xml: Remove.
5103         * features/i386/i386.xml: Remove.
5104         * features/i386/x32-avx-avx512-linux.xml: Remove.
5105         * features/i386/x32-avx-linux.xml: Remove.
5106         * features/i386/x32-linux.xml: Remove.
5107
5108 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5109
5110         * regformats/aarch64.dat: Remove.
5111         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5112         * regformats/i386/amd64-avx-linux.dat: Remove.
5113         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5114         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5115         * regformats/i386/amd64-linux.dat: Remove.
5116         * regformats/i386/amd64-mpx-linux.dat: Remove.
5117         * regformats/i386/amd64.dat: Remove.
5118         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5119         * regformats/i386/i386-avx-linux.dat: Remove.
5120         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5121         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5122         * regformats/i386/i386-linux.dat: Remove.
5123         * regformats/i386/i386-mmx-linux.dat: Remove.
5124         * regformats/i386/i386-mpx-linux.dat: Remove.
5125         * regformats/i386/i386.dat: Remove.
5126         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5127         * regformats/i386/x32-avx-linux.dat: Remove.
5128         * regformats/i386/x32-linux.dat: Remove.
5129
5130 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5131
5132         * aarch64-tdep.c: Remove xml self tests.
5133         * amd64-linux-tdep.c: Likewise.
5134         * amd64-tdep.c: Likewise.
5135         * i386-linux-tdep.c: Likewise.
5136         * i386-tdep.c: Likewise.
5137
5138 2019-07-03  Pedro Alves  <palves@redhat.com>
5139
5140         PR cli/24732
5141         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5142         (pipe_cmd_option_defs): New.
5143         (make_pipe_cmd_options_def_group): New.
5144         (pipe_command): Use gdb::option::process_options.
5145         (pipe_command_completer): New function.
5146         (_initialize_cli_cmds): Install completer for "pipe" command.
5147
5148 2019-07-03  Pedro Alves  <palves@redhat.com>
5149
5150         * cli/cli-option.c (union option_value) <string>: New field.
5151         (struct option_def_and_value): Add ctor, move ctor, dtor and
5152         use DISABLE_COPY_AND_ASSIGN.
5153         (option_def_and_value::clear_value): New.
5154         (parse_option, save_option_value_in_ctx, get_val_type_str)
5155         (add_setshow_cmds_for_options): Handle var_string.
5156         * cli-option.h (union option_def::var_address) <string>: New
5157         field.
5158         (struct string_option_def): New.
5159         * maint-test-options.c (struct test_options_opts): Add default
5160         ctor and use DISABLE_COPY_AND_ASSIGN.
5161         <string_opt>: New field.
5162         (test_options_opts::~test_options_opts): New.
5163         (test_options_opts::dump): Also dump "-string".
5164         (test_options_option_defs): Install "string.
5165
5166 2019-07-03  Pedro Alves  <palves@redhat.com>
5167
5168         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5169         option_value with a null enumeration.
5170         (complete_options): Save the option values in the context.
5171         (save_option_value_in_ctx): New, factored out from ...
5172         (process_options): ... here.
5173         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5174         of the function.
5175         * maint-test-options.c (test_options_opts::dump): New, factored
5176         out from ...
5177         (maintenance_test_options_command_mode): ... here.
5178         (maintenance_test_options_command_completion_result): Delete.
5179         (maintenance_test_options_command_completion_text): Update
5180         comment.
5181         (maintenance_show_test_options_completion_result): Change
5182         prototype.  Just print
5183         maintenance_test_options_command_completion_text.
5184         (save_completion_result): New.
5185         (maintenance_test_options_completer_mode): Pass options context to
5186         complete_options, and then save a dump.
5187         (_initialize_maint_test_options): Use add_cmd to install "maint
5188         show test-options-completion-result".
5189
5190 2019-07-03  Pedro Alves  <palves@redhat.com>
5191
5192         * NEWS (New commands): Mention "with" and "maint with".
5193         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5194         (with_command, with_command_completer): New.
5195         (pipe_command): Adjust to new repeat_previous
5196         interface.
5197         (_initialize_cli_cmds): Install the "with" command and its "w"
5198         alias.
5199         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5200         declarations.
5201         * cli/cli-setshow.c (parse_cli_var_uinteger)
5202         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5203         argument strings for all var_types.
5204         (get_setshow_command_value_string): New, factored out from ...
5205         (do_show_command): ... this.
5206         * cli/cli-setshow.h: Include <string>.
5207         (get_setshow_command_value_string): Declare.
5208         * command.h (repeat_previous): Now returns const char *.  Adjust
5209         comment.
5210         * maint.c: Include "cli/cli-cmds.h".
5211         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5212         (_initialize_maint_cmds): Register the "maintenance with" command.
5213         * top.c (repeat_previous): Move bits from pipe_command here:
5214         Return the saved command line, if any; error out if there's no
5215         command to relaunch.
5216
5217 2019-07-03  Pedro Alves  <palves@redhat.com>
5218
5219         * NEWS (New commands): Mention "maint set/show test-settings"
5220         instead of "maint test-settings".
5221         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5222         (maintenance_test_settings_set_list): Rename to ...
5223         (maintenance_set_test_settings_list): ... this.
5224         (maintenance_test_settings_show_list): Rename to  ...
5225         (maintenance_show_test_settings_list): ... this.
5226         (maintenance_test_settings_cmd): Delete.
5227         (maintenance_test_settings_set_cmd): ...
5228         (maintenance_set_test_settings_cmd): ... this.
5229         (maintenance_test_settings_show_cmd): ...
5230         (maintenance_show_test_settings_cmd): ... this.
5231         (maintenance_test_settings_show_value_cmd):
5232         (maintenance_show_test_settings_value_cmd): ... this.
5233         (_initialize_maint_test_settings): No longer install the "maint
5234         test-settings" prefix command.  Rename "maint test-settings set"
5235         to "maint set test-settings", and "maint test-settings show" to
5236         "maint show test-settings".  Adjust all subcommands.
5237
5238 2019-07-03  Pedro Alves  <palves@redhat.com>
5239
5240         * maint-test-settings.c: Fix file's intro comment.  Replace all
5241         references to "test-options" with references to "test-settings",
5242         in comments.
5243
5244 2019-07-03  Pedro Alves  <palves@redhat.com>
5245
5246         * maint-test-settings.c (maintenance_test_settings_xxx)
5247         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5248         New.
5249         (maintenance_test_settings_enums): Use them.
5250         (maintenance_test_settings_enum): Default to
5251         maintenance_test_settings_xxx.
5252         (_initialize_maint_test_settings): Initialize
5253         MAINTENANCE_TEST_SETTINGS_FILENAME.
5254
5255 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5256
5257         * breakpoint.h (remove_breakpoints_inf): Change return type to
5258         void, move function documentation here.
5259         * breakpoint.c (remove_breakpoints_inf): Change return type to
5260         void, move function documentation to header.
5261
5262 2019-07-02  Pedro Alves  <palves@redhat.com>
5263
5264         * NEWS (Completion improvements): Mention "info threads".
5265         * thread.c (struct info_threads_opts, info_threads_option_defs)
5266         (make_info_threads_options_def_group): New.
5267         (info_threads_command): Use gdb::option::process_options.
5268         (info_threads_command_completer): New.
5269         (_initialize_thread): Use gdb::option::build_help to build the
5270         help text for "info threads".
5271
5272 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5273
5274         * defs.h (generic_load): Move from here...
5275         * symfile.h (generic_load): ... to here.  Rename name parameter
5276         to args.
5277         * symfile.c (generic_load): Add comment.
5278
5279 2019-07-01  Tom Tromey  <tromey@adacore.com>
5280
5281         * dwarf2read.c
5282         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5283         declaration of without_params.  Fix formatting.
5284
5285 2019-07-01  Tom Tromey  <tromey@adacore.com>
5286
5287         * ada-exp.y (find_primitive_type): Update.
5288         * ada-lang.h (ada_lookup_symbol): Update.
5289         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5290         parameter.
5291         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5292
5293 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5294
5295         PR breakpoints/24541
5296         * gdbarch.c: Regenerate.
5297         * gdbarch.h: Regenerate.
5298         * gdbarch.sh: Add 'stap_adjust_register'.
5299         * i386-tdep.c: Include '<unordered_set>'.
5300         (i386_stap_adjust_register): New function.
5301         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5302         * stap-probe.c (stap_parse_register_operand): Call
5303         'gdbarch_stap_adjust_register'.
5304
5305 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5306
5307         PR python/24742
5308         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5309         * python/python.c (do_start_initialization): Use 'xmalloc'
5310         instead of 'PyMem_Malloc'.
5311
5312 2019-06-28  Tom Tromey  <tromey@adacore.com>
5313
5314         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5315         for Ada.
5316
5317 2019-06-27  Tom Tromey  <tromey@adacore.com>
5318
5319         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5320         objfile_key.
5321         (arm_find_mapping_symbol, arm_record_special_symbol)
5322         (_initialize_arm_tdep): Update.
5323         (arm_objfile_data_free): Remove.
5324
5325 2019-06-27  Tom Tromey  <tromey@adacore.com>
5326
5327         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5328         to cp_print_static_field.
5329
5330 2019-06-26  Tom Tromey  <tromey@adacore.com>
5331
5332         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5333         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5334         declare.
5335
5336 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5337
5338         * features/aarch64-core.c (create_feature_aarch64_core):
5339         Regenerate.
5340         * features/aarch64-core.xml: Add cpsr flags.
5341
5342 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5343
5344         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5345         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5346
5347 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5348
5349         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5350         field.
5351         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5352         use.
5353         (arm_record_special_symbol): Don't insert new symbol in sorted
5354         position, push it at the end.
5355
5356 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5357
5358         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5359         (arm_mapping_symbol_s): Remove.
5360         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5361         (arm_mapping_symbol_vec): New typedef.
5362         (struct arm_per_objfile): Add constructor.
5363         <section_maps>: Change type to
5364         std::unique_ptr<arm_mapping_symbol_vec[]>.
5365         (arm_compare_mapping_symbols): Remove.
5366         (arm_find_mapping_symbol): Adjust to section_maps type change.
5367         (arm_objfile_data_free): Call delete on arm_per_objfile.
5368         (arm_record_special_symbol): Adjust to section_maps type change.
5369         Allocate arm_per_objfile with new.
5370
5371 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5372
5373         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5374         with the command prefix.
5375
5376 2019-06-25  Tom Tromey  <tom@tromey.com>
5377
5378         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5379         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5380
5381 2019-06-25  Tom Tromey  <tom@tromey.com>
5382
5383         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5384         type.
5385         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5386         protected.
5387
5388 2019-06-25  Tom Tromey  <tom@tromey.com>
5389
5390         * tui/tui-winsource.c
5391         (tui_source_window_base::set_is_exec_point_at): Add check against
5392         LOA_ADDRESS.
5393
5394 2019-06-25  Tom Tromey  <tom@tromey.com>
5395
5396         * tui/tui-source.c (tui_set_source_content): Don't check before
5397         xfree.
5398         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5399
5400 2019-06-25  Tom Tromey  <tom@tromey.com>
5401
5402         * tui/tui-winsource.h (tui_update_source_window_as_is)
5403         (tui_alloc_source_buffer, tui_line_is_displayed)
5404         (tui_addr_is_displayed): Change type of win_info.
5405         * tui/tui-winsource.c (tui_update_source_window_as_is)
5406         (tui_clear_source_content, tui_show_source_line)
5407         (tui_show_source_content, tui_source_window_base::refill)
5408         (tui_source_window_base::set_is_exec_point_at)
5409         (tui_source_window_base::set_is_exec_point_at)
5410         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5411         (tui_alloc_source_buffer, tui_line_is_displayed)
5412         (tui_addr_is_displayed): Change type of win_info.  Update.
5413         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5414         (tui_source_window_base::do_make_visible_with_new_height):
5415         Update.
5416         * tui/tui-source.c (tui_set_source_content)
5417         (tui_set_source_content_nil)
5418         (tui_source_window::do_scroll_vertical): Update.
5419         * tui/tui-layout.c (show_layout): Update.
5420         * tui/tui-disasm.c (tui_set_disassem_content)
5421         (tui_disasm_window::do_scroll_vertical): Update.
5422         * tui/tui-data.h (tui_win_content): Remove.
5423         (struct tui_gen_win_info) <content, content_size>: Remove.
5424         (struct tui_source_element): Add initializers and destructor.
5425         (union tui_which_element, struct tui_win_element): Remove.
5426         (struct tui_source_window_base) <content>: New field.
5427         (struct tui_data_window): Remove destructor.
5428         (tui_alloc_content, tui_free_win_content)
5429         (tui_free_all_source_wins_content): Don't declare.
5430         * tui/tui-data.c (tui_initialize_static_data): Update.
5431         (init_content_element, tui_alloc_content): Remove.
5432         (~tui_gen_win_info): Update.
5433         (~tui_data_window, tui_free_all_source_wins_content)
5434         (tui_free_win_content, free_content, free_content_elements):
5435         Remove.
5436
5437 2019-06-25  Tom Tromey  <tom@tromey.com>
5438
5439         * tui/tui-winsource.h (tui_clear_source_content)
5440         (tui_erase_source_content, tui_show_source_content): Change type
5441         of win_info.
5442         * tui/tui-winsource.c (tui_clear_source_content)
5443         (tui_erase_source_content, tui_show_source_content): Change type
5444         of win_info.
5445         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5446         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5447         win_info.
5448         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5449         win_info.
5450         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5451
5452 2019-06-25  Tom Tromey  <tom@tromey.com>
5453
5454         * tui/tui-winsource.c (tui_clear_source_content)
5455         (tui_source_window_base::set_is_exec_point_at): Update.
5456         * tui/tui-source.c (tui_set_source_content_nil): Update.
5457         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5458         a bool.
5459         * tui/tui-data.c (init_content_element): Update.
5460
5461 2019-06-25  Tom Tromey  <tom@tromey.com>
5462
5463         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5464         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5465         * tui/tui-layout.c (init_and_make_win): Update.
5466         * tui/tui.h (enum tui_win_type): Update.
5467         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5468         tui_win_is_auxillary.
5469         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5470         tui_win_is_auxillary.
5471
5472 2019-06-25  Tom Tromey  <tom@tromey.com>
5473
5474         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5475         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5476         (tui_delete_data_content_windows, tui_display_all_data)
5477         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5478         Update.
5479         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5480         * tui/tui-regs.c (tui_last_regs_line_no)
5481         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5482         (tui_show_registers): Update.
5483         (tui_show_register_group): Return void.  Update.
5484         (tui_display_registers_from, tui_display_reg_element_at_line)
5485         (tui_display_registers_from_line, tui_check_register_values):
5486         Update.
5487         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5488         member.
5489         (struct tui_data_window) <regs_content>: Now a std::vector.
5490         <regs_content_count>: Remove.
5491         (tui_add_content_elements, tui_free_data_content): Don't declare.
5492         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5493         (init_content_element): Remove DATA_WIN case.  Add assert.
5494         (tui_add_content_elements): Remove.
5495         (tui_data_window): Update.
5496         (tui_free_data_content): Remove.
5497         (free_content_elements): Remove DATA_WIN case.
5498
5499 2019-06-25  Tom Tromey  <tom@tromey.com>
5500
5501         * tui/tui-data.c (tui_data_item_window): Update.
5502         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5503         * tui/tui-windata.c (tui_display_all_data)
5504         (tui_display_data_from_line): Update.
5505         (tui_check_data_values): Remove.
5506         * tui/tui-regs.c (tui_show_register_group)
5507         (tui_display_reg_element_at_line): Update.
5508         * tui/tui-hooks.c (tui_register_changed)
5509         (tui_refresh_frame_and_register_information): Call
5510         tui_check_register_values.
5511         * tui/tui-data.h (struct tui_data_window) <data_content,
5512         data_content_count, data_type>: Remove.
5513         (enum tui_data_type): Remove.
5514
5515         * tui/tui-data.c (tui_data_window::clear_detail)
5516         (~tui_data_window): Update.
5517
5518 2019-06-25  Tom Tromey  <tom@tromey.com>
5519
5520         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5521         declare.
5522         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5523         Rename from tui_first_data_item_displayed.  Update.
5524         (tui_data_window::refresh_all)
5525         (tui_data_window::do_scroll_vertical): Update.
5526         * tui/tui-data.h (struct tui_data_window)
5527         <first_data_item_displayed>: Declare new method.
5528
5529 2019-06-25  Tom Tromey  <tom@tromey.com>
5530
5531         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5532         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5533         contents...
5534         (tui_initialize_static_data): ...here.
5535
5536 2019-06-25  Tom Tromey  <tom@tromey.com>
5537
5538         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5539         (tui_display_registers_from, tui_check_register_values): Update.
5540         (tui_display_register): Remove win_info parameter; update.
5541         (tui_get_register): Change type of parameters.
5542         * tui/tui-data.h (struct tui_data_element): Remove.
5543         (union tui_which_element) <data>: Remove.
5544         <data_window>: Change type.
5545         (struct tui_data_item_window): New.
5546         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5547         case.  Add assert.
5548         (~tui_data_item_window): New destructor.
5549         (free_content_elements): Remove DATA_ITEM_WIN case.
5550
5551 2019-06-25  Tom Tromey  <tom@tromey.com>
5552
5553         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5554         Remove.
5555
5556 2019-06-25  Tom Tromey  <tom@tromey.com>
5557
5558         * tui/tui-data.h (struct tui_command_element): Remove.
5559         (union tui_which_element) <command>: Remove.
5560         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5561         assert.
5562         (free_content_elements): Remove CMD_WIN case.
5563
5564 2019-06-25  Tom Tromey  <tom@tromey.com>
5565
5566         * tui/tui-layout.c (tui_set_layout): Update.
5567         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5568         * tui/tui-data.c (layout_def): Update.
5569
5570 2019-06-25  Tom Tromey  <tom@tromey.com>
5571
5572         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5573         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5574         (tui_source_window_base::set_new_height): Update.
5575         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5576         Update.
5577         (tui_set_locator_fullname, tui_set_locator_info)
5578         (tui_show_frame_info): Update.
5579         * tui/tui-source.c (tui_set_source_content)
5580         (tui_source_is_displayed): Update.
5581         * tui/tui-layout.c (show_source_disasm_command, show_data)
5582         (show_source_or_disasm_and_command): Update.
5583         * tui/tui-disasm.c (tui_set_disassem_content)
5584         (tui_get_begin_asm_address): Update.
5585         * tui/tui-data.h (struct tui_locator_element): Remove.
5586         (union tui_which_element) <locator>: Remove.
5587         (struct tui_locator_window): New.
5588         (tui_locator_win_info_ptr): Change return type.
5589         * tui/tui-data.c (_locator): Change type.
5590         (tui_locator_win_info_ptr): Change return type.
5591         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5592         (tui_alloc_content): Add assert.
5593
5594 2019-06-25  Tom Tromey  <tom@tromey.com>
5595
5596         * tui/tui-winsource.c
5597         (tui_exec_info_window::maybe_allocate_content): New method.
5598         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5599         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5600         (make_source_or_disasm_window): Add cast.
5601         * tui/tui-data.h (union tui_which_element) <simple_string>:
5602         Remove.
5603         (struct tui_source_info): New.
5604         (struct tui_source_window_base) <execution_info>: Change type.
5605         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5606         case, and add assert.
5607         (tui_alloc_content): Add assert.
5608
5609 2019-06-25  Tom Tromey  <tom@tromey.com>
5610
5611         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5612         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5613         * tui/tui-data.c (tui_alloc_win_info): Remove.
5614
5615 2019-06-25  Tom Tromey  <tom@tromey.com>
5616
5617         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5618         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5619         can_highlight.
5620
5621 2019-06-25  Tom Tromey  <tom@tromey.com>
5622
5623         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5624         make_visible_with_new_height method.
5625         (tui_win_info::make_visible_with_new_height): New method.
5626         (tui_source_window_base::do_make_visible_with_new_height)
5627         (tui_data_window::do_make_visible_with_new_height)
5628         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5629         (make_visible_with_new_height): Remove.
5630         (tui_resize_all, tui_adjust_win_heights): Use
5631         make_visible_with_new_height method.
5632         * tui/tui-data.h (struct tui_win_info)
5633         <do_make_visible_with_new_height, make_visible_with_new_height>:
5634         New methods.
5635         (struct tui_source_window_base, struct tui_data_window)
5636         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5637         methods.
5638
5639 2019-06-25  Tom Tromey  <tom@tromey.com>
5640
5641         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5642         method.
5643         (update_tab_width): Call update_tab_width method.
5644         * tui/tui-data.h (struct tui_win_info)
5645         (struct tui_source_window_base) <update_tab_width>: New methods.
5646
5647 2019-06-25  Tom Tromey  <tom@tromey.com>
5648
5649         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5650         parameter.
5651         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5652         parameter.
5653         (tui_gen_win_info::make_visible): Update.
5654         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5655         parameter.
5656         * tui/tui-data.h (enum tui_box): New enum.
5657         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5658
5659 2019-06-25  Tom Tromey  <tom@tromey.com>
5660
5661         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5662         init_and_make_win for EXEC_INFO_WIN.
5663         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5664         longer inline.
5665         (struct tui_win_info) <~tui_win_info>: Inline.
5666         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5667         Don't declare.
5668         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5669         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5670         Remove.
5671         (tui_initialize_static_data): Update.
5672         (~tui_gen_win_info): Handle more cleanup here.
5673         (~tui_source_window_base): Delete "execution_info".
5674         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5675
5676 2019-06-25  Tom Tromey  <tom@tromey.com>
5677
5678         * tui/tui-layout.c (make_command_window): Don't set
5679         can_highlight.
5680         (show_source_disasm_command): Call the reset method.
5681         (show_data): Don't set can_highlight.  Call the reset method.
5682         (tui_gen_win_info::reset): Rename from init_gen_win_info
5683         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5684         (show_source_or_disasm_and_command): Call the reset method.
5685         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5686         (struct tui_cmd_window): Set can_highlight.
5687
5688 2019-06-25  Tom Tromey  <tom@tromey.com>
5689
5690         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5691         from make_visible.
5692         (tui_make_visible, tui_make_invisible): Rewrite.
5693         (tui_win_info::make_visible): Remove.
5694         (tui_source_window_base::make_visible): Update.
5695         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5696         method.  Moved from...
5697         (struct tui_win_info) <make_visible>: ...here.
5698
5699 2019-06-25  Tom Tromey  <tom@tromey.com>
5700
5701         * tui/tui-winsource.c
5702         (tui_source_window_base::do_scroll_horizontal): Remove direction
5703         parameter.
5704         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5705         direction parameter.
5706         * tui/tui-win.c (tui_win_info::forward_scroll)
5707         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5708         (tui_win_info::right_scroll): Update.
5709         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5710         direction parameter.
5711         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5712         direction parameter.
5713         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5714         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5715         Remove direction parameter.
5716         (struct tui_source_window_base, struct tui_source_window)
5717         (struct tui_disasm_window, struct tui_data_window)
5718         (struct tui_cmd_window): Update.
5719
5720 2019-06-25  Tom Tromey  <tom@tromey.com>
5721
5722         * tui/tui-winsource.h (tui_set_exec_info_content)
5723         (tui_show_exec_info_content, tui_erase_exec_info_content)
5724         (tui_clear_exec_info_content, tui_update_exec_info): Change
5725         argument to tui_source_window_base.
5726         * tui/tui-winsource.c (tui_set_exec_info_content)
5727         (tui_show_exec_info_content, tui_erase_exec_info_content)
5728         (tui_clear_exec_info_content, tui_update_exec_info): Change
5729         argument to tui_source_window_base.
5730
5731 2019-06-25  Tom Tromey  <tom@tromey.com>
5732
5733         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5734         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5735
5736 2019-06-25  Tom Tromey  <tom@tromey.com>
5737
5738         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5739         check.
5740
5741 2019-06-25  Tom Tromey  <tom@tromey.com>
5742
5743         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5744         type to void.
5745         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5746         type to void.
5747         * tui/tui-source.c (tui_set_source_content): Update.
5748         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5749
5750 2019-06-25  Tom Tromey  <tom@tromey.com>
5751
5752         * tui/tui-win.c (window_name_completer, tui_set_focus)
5753         (tui_all_windows_info): Use name method.
5754         * tui/tui-data.h (struct tui_gen_win_info)
5755         (struct tui_source_window, struct tui_disasm_window)
5756         (struct tui_data_window, struct tui_cmd_window) <name>: New
5757         method.
5758         (tui_win_name): Don't declare.
5759         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5760         (tui_win_name): Remove.
5761
5762 2019-06-25  Tom Tromey  <tom@tromey.com>
5763
5764         * tui/tui-winsource.h (tui_update_source_window)
5765         (tui_update_source_window_as_is): Change parameter type.
5766         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5767         to be a tui_source_window_base.
5768         (tui_update_source_window_as_is): Likewise.
5769         * tui/tui-win.c (make_visible_with_new_height): Update.
5770
5771 2019-06-25  Tom Tromey  <tom@tromey.com>
5772
5773         * tui/tui-winsource.c (tui_erase_source_content)
5774         (tui_show_source_content, tui_show_exec_info_content)
5775         (tui_erase_exec_info_content): Use refresh_window method.
5776         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5777         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5778         from tui_refresh_win.
5779         (tui_data_window::refresh_window): New method.
5780         (tui_win_info::refresh, tui_source_window_base::refresh)
5781         (tui_refresh_all): Use refresh_window method.
5782         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5783         method.
5784         * tui/tui-regs.c (tui_display_register): Call refresh_window
5785         method.
5786         * tui/tui-layout.c (show_source_disasm_command)
5787         (show_source_or_disasm_and_command): Call refresh_window method.
5788         * tui/tui-data.h (struct tui_gen_win_info)
5789         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5790         New method.
5791
5792 2019-06-25  Tom Tromey  <tom@tromey.com>
5793
5794         * tui/tui.c (tui_rl_other_window, tui_enable)
5795         (tui_is_window_visible, tui_get_command_dimension): Update.
5796         * tui/tui-winsource.c (tui_update_source_window_as_is)
5797         (tui_clear_source_content, tui_erase_source_content)
5798         (tui_show_source_line, tui_source_window_base::refill)
5799         (tui_source_window_base::do_scroll_horizontal)
5800         (tui_source_window_base::set_is_exec_point_at)
5801         (tui_update_breakpoint_info, tui_set_exec_info_content)
5802         (tui_alloc_source_buffer, tui_line_is_displayed)
5803         (tui_addr_is_displayed): Update.
5804         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5805         (tui_check_and_display_highlight_if_needed)
5806         (tui_win_info::make_visible, tui_win_info::refresh)
5807         (tui_refresh_all): Update.
5808         * tui/tui-windata.c (tui_first_data_item_displayed)
5809         (tui_delete_data_content_windows, tui_erase_data_content)
5810         (tui_display_all_data, tui_data_window::refresh_all)
5811         (tui_check_data_values): Update.
5812         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5813         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5814         (tui_win_info::backward_scroll, tui_refresh_all_win)
5815         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5816         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5817         (tui_source_window_base::set_new_height)
5818         (tui_data_window::set_new_height)
5819         (make_invisible_and_set_new_height)
5820         (make_visible_with_new_height, new_height_ok)
5821         (parse_scrolling_args): Update.
5822         * tui/tui-stack.c (tui_show_frame_info): Update.
5823         * tui/tui-source.c (tui_set_source_content)
5824         (tui_set_source_content_nil, tui_source_is_displayed)
5825         (tui_source_window::do_scroll_vertical): Update.
5826         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5827         (tui_display_registers_from, tui_display_reg_element_at_line)
5828         (tui_check_register_values, tui_reg_command): Update.
5829         * tui/tui-layout.c (tui_default_win_height)
5830         (show_source_disasm_command, show_data, init_and_make_win)
5831         (show_source_or_disasm_and_command): Update.
5832         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5833         (tui_redisplay_readline, tui_mld_flush)
5834         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5835         (tui_getc): Update.
5836         * tui/tui-disasm.c (tui_set_disassem_content)
5837         (tui_disasm_window::do_scroll_vertical): Update.
5838         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5839         Now virtual.
5840         (struct tui_win_info): Derive from tui_gen_win_info.
5841         <~tui_win_info>: Mark as override.
5842         <generic>: Remove member.
5843         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5844         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5845         (~tui_data_window, ~tui_win_info)
5846         (tui_free_all_source_wins_content): Update.
5847         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5848
5849 2019-06-25  Tom Tromey  <tom@tromey.com>
5850
5851         * tui/tui-layout.c (init_and_make_win): Use new.
5852         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5853         destructor, initializers.
5854         (tui_alloc_generic_win_info): Don't declare.
5855         * tui/tui-data.c (_locator): Add argument to constructor.
5856         (source_win, disasm_win): New globals.
5857         (exec_info): Remove.
5858         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5859         Update.
5860         (tui_alloc_generic_win_info): Remove.
5861         (init_content_element): Use new.
5862         (tui_win_info::tui_win_info): Update.
5863         (free_content_elements) <case DATA_WIN>: Use delete.
5864
5865 2019-06-25  Tom Tromey  <tom@tromey.com>
5866
5867         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5868         * tui/tui-windata.c (tui_first_data_item_displayed)
5869         (tui_delete_data_content_windows): Update.
5870         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5871         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5872         (tui_display_registers_from, tui_check_register_values): Update.
5873         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5874         pointer.
5875         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5876         window.
5877         (tui_free_data_content): Update.
5878         (free_content_elements) <case DATA_WIN>: Free the window.
5879
5880 2019-06-25  Tom Tromey  <tom@tromey.com>
5881
5882         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5883         Update.
5884         * tui/tui-layout.c (make_command_window)
5885         (show_source_disasm_command, show_data, init_and_make_win)
5886         (show_source_or_disasm_and_command): Update.
5887         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5888         method.
5889         <can_highight, is_highlighted>: Now bool.
5890         (tui_set_win_highlight): Don't declare.
5891         * tui/tui-data.c (tui_set_win_highlight): Remove.
5892
5893 2019-06-25  Tom Tromey  <tom@tromey.com>
5894
5895         * tui/tui-wingeneral.c (make_visible): Remove check of window
5896         type.
5897
5898 2019-06-25  Tom Tromey  <tom@tromey.com>
5899
5900         * tui/tui-win.c (tui_win_info::max_height)
5901         (tui_cmd_window::max_height): New methods.
5902         (new_height_ok): Call max_height.
5903         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5904         <max_height>: New method.
5905
5906 2019-06-25  Tom Tromey  <tom@tromey.com>
5907
5908         * tui/tui-win.c (tui_source_window_base::set_new_height)
5909         (tui_data_window::set_new_height): New methods.
5910         (make_invisible_and_set_new_height): Call set_new_height method.
5911         * tui/tui-data.h (struct tui_win_info)
5912         (struct tui_source_window_base, struct tui_data_window)
5913         <set_new_height>: New method.
5914
5915 2019-06-25  Tom Tromey  <tom@tromey.com>
5916
5917         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5918         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5919         tui_refresh_data_win.
5920         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5921         method.
5922         (tui_refresh_all_win): Call the refresh_all method.
5923         (tui_set_focus): Likewise.
5924         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5925         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5926         Likewise.
5927
5928 2019-06-25  Tom Tromey  <tom@tromey.com>
5929
5930         * tui/tui-winsource.h (tui_refill_source_window)
5931         (tui_set_is_exec_point_at): Don't declare.
5932         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5933         (tui_source_window_base::refill): Rename from
5934         tui_refill_source_window.
5935         (tui_source_window_base::do_scroll_horizontal): Update.
5936         (tui_source_window_base::set_is_exec_point_at): Rename from
5937         tui_set_is_exec_point_at.
5938         (tui_update_all_breakpoint_info): Update.
5939         * tui/tui-stack.c (tui_show_frame_info): Update.
5940         * tui/tui-layout.c (show_data): Add cast.
5941         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5942         * tui/tui-data.h (struct tui_source_window_base) <refill,
5943         set_is_exec_point_at>: New methods.
5944         (tui_source_windows, tui_add_to_source_windows): Update types.
5945         (tui_add_to_source_windows): Remove redundant declaration.
5946         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5947         (tui_source_windows): Change return type.
5948         (tui_clear_source_windows_detail): Update.
5949         (tui_add_to_source_windows): Change type of parameter.
5950         (tui_free_all_source_wins_content): Update.
5951
5952 2019-06-25  Tom Tromey  <tom@tromey.com>
5953
5954         * tui/tui-wingeneral.c (tui_win_info::refresh)
5955         (tui_source_window_base::refresh): New methods.
5956         (tui_refresh_all): Call the refresh method.
5957         * tui/tui-data.h (struct tui_win_info)
5958         (struct tui_source_window_base) <refresh>: New method.
5959
5960 2019-06-25  Tom Tromey  <tom@tromey.com>
5961
5962         * tui/tui.h (tui_is_window_visible): Return bool.
5963         * tui/tui.c (tui_is_window_visible): Return bool.
5964         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5965         (tui_make_visible, tui_make_invisible)
5966         (tui_win_info::make_visible)
5967         (tui_source_window_base::make_visible, make_all_visible)
5968         (tui_make_all_visible, tui_make_all_invisible): Update.
5969         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5970         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5971         bool.
5972         (struct tui_win_info, struct tui_source_window_base)
5973         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5974         * tui/tui-data.c (tui_init_generic_part): Update.
5975
5976 2019-06-25  Tom Tromey  <tom@tromey.com>
5977
5978         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5979         (tui_source_window_base::make_visible): New methods.
5980         (make_all_visible): Make method call.
5981         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5982         (struct tui_source_window_base, struct tui_cmd_window): Override
5983         make_visible.
5984         (tui_win_is_source_type): Don't declare.
5985         * tui/tui-data.c (tui_win_is_source_type): Remove.
5986
5987 2019-06-25  Tom Tromey  <tom@tromey.com>
5988
5989         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5990         NULL check.
5991
5992 2019-06-25  Tom Tromey  <tom@tromey.com>
5993
5994         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5995         Inline constructor.  Add initializers for members.
5996         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5997         constructors; now inline in class.
5998
5999 2019-06-25  Tom Tromey  <tom@tromey.com>
6000
6001         * tui/tui-regs.c (tui_show_registers): Update.
6002         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6003         bool.
6004         * tui/tui-data.c (tui_data_window::clear_detail)
6005         (tui_data_window): Update.
6006
6007 2019-06-25  Tom Tromey  <tom@tromey.com>
6008
6009         * tui/tui-windata.c (tui_display_all_data)
6010         (tui_display_data_from_line, tui_display_data_from)
6011         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6012         Update.
6013         * tui/tui-regs.c (tui_last_regs_line_no)
6014         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6015         (tui_show_registers, tui_show_register_group)
6016         (tui_display_registers_from, tui_display_reg_element_at_line)
6017         (tui_display_registers_from_line, tui_check_register_values)
6018         (tui_reg_next, tui_reg_prev): Update.
6019         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6020         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6021         tui_data_window.
6022         (struct tui_win_info) <detail>: Remove.  Add new fields from
6023         tui_data_info.
6024         (TUI_DATA_WIN): Add cast.
6025         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6026         (~tui_data_window): Simplify.
6027
6028 2019-06-25  Tom Tromey  <tom@tromey.com>
6029
6030         * tui/tui-layout.c (show_source_disasm_command)
6031         (show_source_or_disasm_and_command): Update.
6032         * tui/tui-io.c (update_cmdwin_start_line)
6033         (tui_redisplay_readline): Update.
6034         * tui/tui-data.h (struct tui_command_info): Remove.
6035         (struct tui_win_info) <detail>: Remove command_info member.
6036         (struct tui_data_window) <start_line>: New member, from
6037         tui_command_info.
6038         (TUI_CMD_WIN): Add casts.
6039
6040 2019-06-25  Tom Tromey  <tom@tromey.com>
6041
6042         * tui/tui-winsource.c (tui_update_source_window)
6043         (tui_refill_source_window)
6044         (tui_source_window_base::do_scroll_horizontal)
6045         (tui_update_breakpoint_info, tui_set_exec_info_content)
6046         (tui_show_exec_info_content, tui_erase_exec_info_content)
6047         (tui_clear_exec_info_content): Update.
6048         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6049         Update.
6050         * tui/tui-win.c (make_invisible_and_set_new_height)
6051         (make_visible_with_new_height): Update.
6052         * tui/tui-source.c (tui_set_source_content)
6053         (tui_show_symtab_source): Update.
6054         * tui/tui-layout.c (extract_display_start_addr)
6055         (show_source_disasm_command, show_data)
6056         (make_source_or_disasm_window)
6057         (show_source_or_disasm_and_command): Update.
6058         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6059         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6060         "gdbarch".
6061         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6062         to tui_source_window_base.
6063         (struct tui_win_info) <detail>: Remove source_info member.
6064         (struct tui_source_window_base) <has_locator>: Inline.
6065         Move contents from tui_source_info; rename has_locator member to
6066         m_has_locator.
6067         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6068         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6069         header file.
6070         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6071         Simplify.
6072         (tui_free_all_source_wins_content): Cast to
6073         tui_source_window_base.
6074
6075 2019-06-25  Tom Tromey  <tom@tromey.com>
6076
6077         * tui/tui-win.c (make_invisible_and_set_new_height)
6078         (make_visible_with_new_height): Call has_locator method.
6079         * tui/tui-layout.c (show_source_disasm_command, show_data)
6080         (show_source_or_disasm_and_command): Update for bool change.
6081         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6082         (tui_win_info) <has_locator>: New method.
6083         (struct tui_source_window_base) <has_locator>: New method.
6084         (tui_win_has_locator): Don't declare.
6085         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6086         from tui_win_has_locator.
6087         (tui_source_window_base): Use false, not FALSE.
6088
6089 2019-06-25  Tom Tromey  <tom@tromey.com>
6090
6091         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6092         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6093         clear_detail method directly.
6094         (tui_clear_win_detail): Remove.
6095
6096 2019-06-25  Tom Tromey  <tom@tromey.com>
6097
6098         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6099         "this", not TUI_DISASM_WIN.
6100
6101 2019-06-25  Tom Tromey  <tom@tromey.com>
6102
6103         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6104         declare.
6105         * tui/tui-winsource.c
6106         (tui_source_window_base::do_scroll_horizontal): Rename from
6107         tui_horizontal_source_scroll.
6108         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6109         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6110         from tui_vertical_data_scroll.
6111         * tui/tui-win.h (tui_scroll): Don't declare.
6112         * tui/tui-win.c (tui_win_info::forward_scroll)
6113         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6114         (tui_win_info::right_scroll): Rename and update.
6115         (tui_scroll_forward_command, tui_scroll_backward_command)
6116         (tui_scroll_left_command, tui_scroll_right_command): Update.
6117         (tui_scroll): Remove.
6118         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6119         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6120         from tui_vertical_source_scroll.
6121         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6122         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6123         from tui_vertical_disassem_scroll.
6124         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6125         do_scroll_horizontal>: New methods.
6126         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6127         Likewise.
6128         (struct tui_source_window_base): Add do_scroll_horizontal.
6129         (struct tui_source_window, struct tui_disasm_window): Add
6130         do_scroll_vertical.
6131         (struct tui_data_window, struct tui_cmd_window): Add
6132         do_scroll_horizontal and do_scroll_vertical.
6133         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6134
6135 2019-06-25  Tom Tromey  <tom@tromey.com>
6136
6137         * tui/tui-data.h (struct tui_source_window_base): New struct.
6138         (struct tui_source_window): Derive from tui_source_window_base.
6139         (struct tui_disasm_window): New struct.
6140         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6141         from tui_source_window::clear_detail.
6142         (tui_source_window_base): Rename from tui_source_window.
6143         (~tui_source_window_base): Rename from ~tui_source_window.
6144         (tui_alloc_win_info): Create a tui_disasm_window.
6145
6146 2019-06-25  Tom Tromey  <tom@tromey.com>
6147
6148         * tui/tui-data.h (struct tui_source_window)
6149         (struct tui_data_window): Declare destructors.
6150         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6151         destructors.
6152         (tui_win_info): Simplify.
6153
6154 2019-06-25  Tom Tromey  <tom@tromey.com>
6155
6156         * tui/tui-winsource.c (tui_display_main)
6157         (tui_update_source_windows_with_addr)
6158         (tui_update_all_breakpoint_info): Update.
6159         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6160         (new_height_ok, parse_scrolling_args): Update.
6161         * tui/tui-stack.c (tui_show_frame_info): Update.
6162         * tui/tui-data.h (struct tui_list): Remove.
6163         (tui_source_windows): Return a reference to a std::vector.
6164         * tui/tui-data.c (source_windows): Now a std::vector.
6165         (tui_source_windows): Change return type.
6166         (tui_clear_source_windows): Rewrite.
6167         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6168         (tui_free_all_source_wins_content): Rewrite.
6169
6170 2019-06-25  Tom Tromey  <tom@tromey.com>
6171
6172         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6173         (struct tui_data_window, struct tui_cmd_window): Declare
6174         clear_detail method.
6175         * tui/tui-data.c (tui_source_window::clear_detail)
6176         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6177         methods.
6178         (tui_clear_win_detail): Simplify.
6179
6180 2019-06-25  Tom Tromey  <tom@tromey.com>
6181
6182         * tui/tui-layout.c (make_source_window, make_disasm_window)
6183         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6184         Return the new window.
6185         (show_source_disasm_command, show_data)
6186         (show_source_or_disasm_and_command): Update.
6187
6188 2019-06-25  Tom Tromey  <tom@tromey.com>
6189
6190         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6191         parameter.  Return the new window.
6192         (show_source_disasm_command): Update and remove NULL check.
6193         (show_source_or_disasm_and_command): Update.
6194
6195 2019-06-25  Tom Tromey  <tom@tromey.com>
6196
6197         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6198
6199 2019-06-25  Tom Tromey  <tom@tromey.com>
6200
6201         * tui/tui-data.h (struct tui_win_info): Make constructor
6202         protected.  Make destructor virtual.  Add initializers.
6203         (tui_source_window, tui_data_window, tui_cmd_window): New
6204         classes.
6205         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6206         constructor.  Add "type" parameter.
6207         (tui_source_window, tui_data_window, tui_cmd_window): New
6208         constructors.
6209         (tui_alloc_win_info): Instantiate the appropriate subclass.
6210
6211 2019-06-25  Tom Tromey  <tom@tromey.com>
6212
6213         * tui/tui-win.c (tui_resize_all): Use delete.
6214         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6215         destructor.
6216         (tui_free_window): Don't declare.
6217         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6218         Update.
6219
6220 2019-06-25  Tom Tromey  <tom@tromey.com>
6221
6222         * tui/tui-data.h (struct tui_win_info): Add constructor.
6223         * tui/tui-data.c (tui_alloc_win_info): Use new.
6224         (tui_free_window): Use delete.
6225
6226 2019-06-22  Tom Tromey  <tom@tromey.com>
6227
6228         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6229         declare.
6230         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6231
6232 2019-06-22  Tom Tromey  <tom@tromey.com>
6233
6234         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6235         declare.
6236         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6237
6238 2019-06-22  Tom de Vries  <tdevries@suse.de>
6239
6240         * dwarf2read.c (create_addrmap_from_aranges)
6241         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6242         instead of '%zu'.
6243
6244 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6245
6246         * dwarf2read.h (dwarf2_section_info_def): Remove.
6247         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6248         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6249         std::vector<dwarf2_section_info>.
6250         (struct dwo_file) <~dwo_file>: Remove.
6251         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6252         types field.
6253         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6254         (dwarf2_read_debug_names): Likewise.
6255         (create_debug_types_hash_table): Change parameter type to
6256         array_view, adjust code accordingly.
6257         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6258         (partial_die_info::fixup): Likewise.
6259         (determine_prefix): Likewise.
6260         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6261
6262 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6263
6264         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6265         gdb_bfd_ref_ptr.
6266         <~dwo_file>: Remove call to gdb_bfd_unref.
6267         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6268         gdb_bfd_ref_ptr::get.
6269
6270 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6271
6272         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6273         type to htab_up.
6274         * dwarf2read.c (struct dwo_file): Initialize fields.
6275         <~dwo_file>: New.
6276         (free_dwo_file): Remove, move content to ~dwo_file.
6277         (struct dwo_file_deleter): Remove.
6278         (dwo_file_up>: Remove custom deleter.
6279         (free_dwo_files): Remove.
6280         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6281         dwo_files.
6282         (process_skeletonless_type_units): Call unique_ptr::get.
6283         (allocate_dwo_file_hash_table): Add deleter to created hash
6284         table.  Change return type to htab_up.
6285         (lookup_dwo_file_slot): Don't memset dwo_file, call
6286         unique_ptr::get.
6287         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6288         (create_dwo_unit_in_dwp_v2): Likewise.
6289         (open_and_init_dwo_file): Likewise.
6290         (free_dwo_file_from_slot): Remove.
6291
6292 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6293
6294         * dwarf2read.h (struct dwarf2_section_info) <readin,
6295         is_virtual>: Change type to bool.
6296         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6297         true instead of 1.
6298
6299 2019-06-19  Tom Tromey  <tom@tromey.com>
6300
6301         * tui/tui-data.h (tui_init_content_element): Don't declare.
6302
6303 2019-06-19  Tom Tromey  <tom@tromey.com>
6304
6305         * tui/tui-data.h (tui_init_win_info): Don't declare.
6306
6307 2019-06-19  Tom de Vries  <tdevries@suse.de>
6308
6309         * dwarf2read.h (abstract_to_concrete): Change type to
6310         std::unordered_map<sect_offset, std::vector<sect_offset>,
6311         gdb::hash_enum<sect_offset>>.
6312
6313 2019-06-19  Tom Tromey  <tromey@adacore.com>
6314
6315         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6316         EVAL_AVOID_SIDE_EFFECTS specially.
6317
6318 2019-06-19  Tom Tromey  <tromey@adacore.com>
6319
6320         * source-cache.c (highlighter): New global.
6321         (source_cache::get_source_lines): Create a highlighter on demand.
6322
6323 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6324
6325         * defs.h (deprecated_interactive_hook): Delete declaration.
6326         * interps.c (clear_interpreter_hooks): Remove use of
6327         deprecated_interactive_hook.
6328         * top.c (deprecated_interactive_hook): Delete definition.
6329         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6330
6331 2019-06-18  Tom de Vries  <tdevries@suse.de>
6332
6333         PR gdb/24515
6334         * dwarf2read.h (abstract_to_concrete): Change type from
6335         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6336         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6337         * dwarf2read.c (read_variable): Update.
6338         (dwarf2_fetch_die_loc_sect_off): Update.
6339
6340 2019-06-17  Tom de Vries  <tdevries@suse.de>
6341
6342         PR gdb/24617
6343         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6344         accessing parent[parent_len - 1].
6345
6346 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6347
6348         PR gdb/24364
6349         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6350         call dtrace_process_dof with NULL dof.
6351
6352 2019-06-16  Tom de Vries  <tdevries@suse.de>
6353
6354         PR gdb/24445
6355         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6356
6357 2019-06-16  Tom Tromey  <tom@tromey.com>
6358
6359         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6360         (make_all_visible): Use address of member.
6361
6362 2019-06-16  Tom Tromey  <tom@tromey.com>
6363
6364         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6365         (tui_free_window, free_content, free_content_elements): Remove
6366         unnecessary cast.
6367         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6368         cast.
6369         * tui/tui-regs.c (tui_show_register_group)
6370         (tui_display_registers_from, tui_display_reg_element_at_line):
6371         Remove unnecessary cast.
6372
6373 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6374
6375         * linux-nat.c (normal_mask): Delete.
6376         (_initialize_linux_nat): Don't initialise normal_mask.
6377
6378 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6379
6380         PR gdb/24445
6381         * dwarf-index-write.h (write_psymtabs_to_index): Add
6382         dwz_basename parameter.
6383         * dwarf-index-write.c (write_gdbindex): Move file writing to
6384         write_gdbindex_1.  Change return type void.
6385         (assert_file_size): Move up, remove filename parameter.
6386         (write_gdbindex_1): New function.
6387         (write_debug_names): Change return type to void, call
6388         assert_file_size.
6389         (struct index_wip_file): New struct.
6390         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6391         file logic to index_wip_file.  Write index for dwz file if
6392         needed.
6393         (save_gdb_index_command): Pass basename of dwz file, if present.
6394         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6395         build-id of dwz file, if present.
6396         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6397         (dwarf2_get_dwz_file): Likewise.
6398         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6399         (dwarf2_get_dwz_file): Likewise.
6400
6401 2019-06-16  Tom Tromey  <tom@tromey.com>
6402
6403         * coffread.c (process_coff_symbol): Use xstrdup.
6404         * value.c (create_internalvar): Use xstrdup.
6405
6406 2019-06-16  Tom Tromey  <tom@tromey.com>
6407
6408         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6409         * breakpoint.c (stopin_command, stopat_command)
6410         (until_break_command, decode_location_default): Remove unnecessary
6411         cast.
6412         * utils.c (subset_compare): Remove unnecessary cast.
6413         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6414         cast.
6415         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6416         cast.
6417         * infcmd.c (path_command): Remove unnecessary cast.
6418         * coffread.c (decode_type): Remove unnecessary cast.
6419         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6420         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6421         * tui/tui-stack.c (tui_show_locator_content)
6422         (tui_show_frame_info): Remove unnecessary cast.
6423         * tui/tui-win.c (tui_scroll_forward_command)
6424         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6425         (parse_scrolling_args): Remove unnecessary cast.
6426         * tui/tui-data.c (init_win_info, tui_del_window)
6427         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6428         (free_content_elements): Remove unnecessary cast.
6429         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6430         unnecessary cast.
6431         * tui/tui-source.c (tui_set_source_content)
6432         (tui_vertical_source_scroll): Remove unnecessary cast.
6433         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6434         cast.
6435         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6436         * tui/tui-regs.c (tui_display_registers_from)
6437         (tui_display_register): Remove unnecessary cast.
6438         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6439         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6440         (make_visible): Remove unnecessary cast.
6441         * tui/tui-winsource.c (tui_erase_source_content)
6442         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6443         unnecessary cast.
6444         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6445         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6446         * stabsread.c (read_type, read_array_type, read_range_type):
6447         Remove unnecessary cast.
6448         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6449         (parse_symbol, parse_type, upgrade_type, parse_external)
6450         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6451         unnecessary cast.
6452         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6453
6454 2019-06-16  Tom Tromey  <tom@tromey.com>
6455
6456         * tui/tui-data.c (tui_alloc_generic_win_info)
6457         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6458         checks.
6459
6460 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6461             Andrew Burgess  <andrew.burgess@embecosm.com>
6462
6463         * f-typeprint.c (f_print_type): Don't return early for not
6464         associated or not allocated types.
6465         (f_type_print_varspec_suffix): Add print_rank parameter and print
6466         ranks of array types in case they dangling.
6467         (f_type_print_base): Add print_rank parameter.
6468
6469 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6470
6471         * NEWS: Mention new MI commands.
6472         * break-catch-throw.c (enum exception_event_kind): Move to
6473         breakpoint.h.
6474         (print_mention_exception_catchpoint): Output text as a single
6475         message.
6476         (catch_exception_command_1): Rename to...
6477         (catch_exception_event): ...this, make non-static, update header
6478         command, and change some parameter types.
6479         (catch_catch_command): Update for changes to
6480         catch_exception_command_1.
6481         (catch_throw_command): Likewise.
6482         (catch_rethrow_command): Likewise.
6483         * breakpoint.c (enum exception_event_kind): Delete.
6484         * breakpoint.h (enum exception_event_kind): Moved here from
6485         break-catch-throw.c.
6486         (catch_exception_event): Declare.
6487         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6488         (mi_cmd_catch_throw): New function.
6489         (mi_cmd_catch_rethrow): New function.
6490         (mi_cmd_catch_catch): New function.
6491         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6492         'catch-catch' entries.
6493         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6494         (mi_cmd_catch_rethrow): Declare.
6495         (mi_cmd_catch_catch): Declare.
6496
6497 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6498
6499         * annotate.c (annotate_source_line): Change return type to void,
6500         update implementation to match.
6501         * annotate.h (annotate_source_line): Change return type to void,
6502         update header comment.
6503         * stack.c (print_frame_info): Don't change what frame information
6504         is printed based on whether annotations are on or not.
6505
6506 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6507
6508         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6509         (annotate_source): Make static.
6510         (annotate_source_line): Moved from source.c and renamed from
6511         identify_source_line.  Update the return type.
6512         * annotate.h (annotate_source): Delete declaration.
6513         (annotate_source_line): Declaration moved from source.h, and
6514         renamed from identify_source_line.  Return type updated.
6515         * source.c (identify_source_line): Moved to annotate.c and renamed
6516         to annotate_source_line.
6517         (info_line_command): Remove check of annotation_level.
6518         * source.h (identify_source_line): Move declaration to annotate.h
6519         and rename to annotate_source_line.
6520         * stack.c: Add 'annotate.h' include.
6521         (print_frame_info): Remove check of annotation_level before
6522         calling annotate_source_line.
6523
6524 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6525
6526         * source-cache.c (source_cache::get_plain_source_lines): Use
6527         open_source_file_with_line_charpos instead of just
6528         open_source_file, remove call to find_source_lines.
6529         (source_cache::get_source_lines): Likewise.
6530         * source.c (find_source_lines): Make static.
6531         (get_filename_and_charpos): Renamed into...
6532         (open_source_file_with_line_charpos): ..this along with changes to
6533         return a scoped_fd, and some other minor clean ups.
6534         (identify_source_line): Use open_source_file_with_line_charpos.
6535         (search_command_helper): Use open_source_file_with_line_charpos
6536         instead of just open_source_file, remove call to
6537         find_source_lines.
6538         * source.h (open_source_file_with_line_charpos): Declare new
6539         function.
6540         (find_source_lines): Delete declaration.
6541
6542 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6543
6544         * source.c (get_filename_and_charpos): Remove fullname
6545         parameter.
6546         (identify_source_line): Update call to get_filename_and_charpos.
6547
6548 2019-06-14  Tom Tromey  <tromey@adacore.com>
6549
6550         PR gdb/24502:
6551         * ui-style.h (skip_ansi_escape): Update comment.
6552         * ui-file.h (class no_terminal_escape_file): New class.
6553         * ui-file.c (no_terminal_escape_file::write)
6554         (no_terminal_escape_file::puts): New methods.
6555         * cli/cli-logging.c (handle_redirections): Use
6556         no_terminal_escape_file.
6557
6558 2019-06-14  Tom Tromey  <tromey@adacore.com>
6559
6560         * NEWS: Move convenience variable news above Python news.
6561
6562 2019-06-14  Tom Tromey  <tom@tromey.com>
6563
6564         * gnulib: Move directory to top-level.
6565         * configure.ac: Don't configure gnulib.
6566         * configure: Rebuild.
6567         * common/common-defs.h: Use new path to gnulib.
6568         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6569         (GNULIB_H): Remove.
6570         (INCGNU): Look in new gnulib location.
6571         (HFILES_NO_SRCDIR): Remove gnulib files.
6572         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6573         (generated_files): Remove GNULIB_H.
6574         ($(LIBGNU), all-lib): Remove targets.
6575         (distclean): Don't mention GNULIB_BUILDDIR.
6576         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6577
6578 2019-06-14  Tom Tromey  <tromey@adacore.com>
6579
6580         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6581         Warn if symbol file does not provide any symbols.
6582
6583 2019-06-14  Tom Tromey  <tromey@adacore.com>
6584
6585         * source.c (find_and_open_source): Respect basenames_may_differ.
6586
6587 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6588
6589         * annotate.c (annotate_breakpoints_invalid): Make use of
6590         scoped_restore_terminal_state.
6591         (annotate_frames_invalid): Likewise.
6592
6593 2019-06-14  Tom Tromey  <tromey@adacore.com>
6594
6595         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6596         allow assignment to an internalvar.
6597
6598 2019-06-14  Tom Tromey  <tromey@adacore.com>
6599
6600         * ada-lex.l: Allow "_" in attribute names.
6601
6602 2019-06-14  Tom Tromey  <tromey@adacore.com>
6603
6604         PR gdb/24653:
6605         * regcache.c (registers_changed): Don't call alloca.
6606         * top.c (execute_command): Don't call alloca.
6607
6608 2019-06-13  Pedro Alves  <palves@redhat.com>
6609
6610         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6611         'expression'.  When parsing an expression, error out if there's
6612         junk after "unlimited".
6613         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6614         (do_set_command): Adjust calls to is_unlimited_literal.
6615
6616 2019-06-13  Pedro Alves  <palves@redhat.com>
6617
6618         * compile/compile.c (make_compile_options_def_group): Add braces
6619         around array_view initializer.
6620         * thread.c (make_thread_apply_all_options_def_group)
6621         (make_thread_apply_all_options_def_group): Likewise.
6622
6623 2019-06-13  Pedro Alves  <palves@redhat.com>
6624
6625         * NEWS (New commands): Mention "maint test-options
6626         require-delimiter", "maint test-options unknown-is-error", "maint
6627         test-options unknown-is-operand" and "maint show
6628         test-options-completion-result".
6629         (New command options, command completion): New section.
6630         (Completion improvements): New section.
6631         Mention that you can abbreviate "unlimited".
6632
6633 2019-06-13  Pedro Alves  <palves@redhat.com>
6634
6635         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6636         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6637         * unittests/cli-utils-selftests.c (test_parse_flags)
6638         (test_parse_flags_qcs): Delete.
6639         (test_cli_utils): Don't call deleted functions.
6640
6641 2019-06-13  Pedro Alves  <palves@redhat.com>
6642
6643         * thread.c: Include "cli/cli-option.h".
6644         (tp_array_compar_ascending): Global.
6645         (tp_array_compar): Delete function.
6646         (tp_array_compar_ascending, tp_array_compar_descending): New
6647         functions.
6648         (ascending_option_def, qcs_flag_option_def)
6649         (thr_qcs_flags_option_defs)
6650         (make_thread_apply_all_options_def_group)
6651         (make_thread_apply_options_def_group): New.
6652         (thread_apply_all_command): Use gdb::option::process_options.
6653         (thread_apply_command_completer)
6654         (thread_apply_all_command_completer): New.
6655         (thread_apply_command): Use gdb::option::process_options.
6656         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6657         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6658         to generate help text of "thread apply".  Adjust "taas"'s help.
6659         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6660         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6661
6662 2019-06-13  Pedro Alves  <palves@redhat.com>
6663
6664         * thread.c (thread_apply_command): Check for invalid TID with
6665         isdigit instead of !isalpha.
6666
6667 2019-06-13  Pedro Alves  <palves@redhat.com>
6668
6669         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6670         (validate_flags_qcs): New.
6671         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6672         (validate_flags_qcs): Declare.
6673         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6674         (make_frame_apply_options_def_group): New.
6675         (frame_apply_command_count): Process options with
6676         gdb::option::process_options.
6677         (frame_apply_completer): New.
6678         (frame_apply_level_completer, frame_apply_all_completer)
6679         (frame_apply_completer): New.
6680         (_initialize_stack): Update help of "frame apply", "frame apply
6681         level", "frame apply all" and "faas" to mention supported options
6682         and install command completers.
6683         * stack.h (frame_apply_all_completer): Declare.
6684         * thread.c: Include "stack.h".
6685         (tfaas_command): Add "--".
6686         (_initialize_thread): Update help "tfaas" to mention supported
6687         options and install command completer.
6688
6689 2019-06-13  Pedro Alves  <palves@redhat.com>
6690
6691         * completer.c (complete_nested_command_line): New.
6692         (gdb_completion_word_break_characters_throw): Add assertion.
6693         * completer.h (complete_nested_command_line): Declare.
6694
6695 2019-06-13  Pedro Alves  <palves@redhat.com>
6696
6697         * stack.c (parse_backtrace_qualifiers): New.
6698         (backtrace_command): Use it.
6699         (backtrace_command_completer): Complete on qualifiers.
6700
6701 2019-06-13  Pedro Alves  <palves@redhat.com>
6702
6703         * frame.c: Include "cli/cli-option.h.
6704         (user_set_backtrace_options): New.
6705         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6706         Delete.
6707         (get_prev_frame): Adjust.
6708         (boolean_option_def, uinteger_option_def)
6709         (set_backtrace_option_defs): New.
6710         (_initialize_frame): Adjust and use
6711         gdb::option::add_setshow_cmds_for_options to install "set
6712         backtrace past-main" and "set backtrace past-entry".
6713         * frame.h: Include "cli/cli-option.h".
6714         (struct frame_print_options): Forward declare.
6715         (print_frame_arguments_all, print_frame_arguments_scalars)
6716         (print_frame_arguments_none): Declare.
6717         (print_entry_values): Delete declaration.
6718         (struct frame_print_options, user_frame_print_options): New.
6719         (struct set_backtrace_options): New.
6720         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6721         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6722         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6723         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6724         (list_args_or_locals): Add frame_print_options parameter.
6725         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6726         * python/py-framefilter.c (enumerate_args): Pass down
6727         USER_FRAME_PRINT_OPTIONS.
6728         * stack.c: Include "cli/cli-option.h".
6729         (print_frame_arguments_all, print_frame_arguments_scalars)
6730         (print_frame_arguments_none): Declare.
6731         (print_raw_frame_arguments, print_entry_values): Delete.
6732         (user_frame_print_options): New.
6733         (boolean_option_def, enum_option_def, frame_print_option_defs):
6734         New.
6735         (struct backtrace_cmd_options): New.
6736         (bt_flag_option_def): New.
6737         (backtrace_command_option_defs): New.
6738         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6739         (print_frame_arg, read_frame_arg, print_frame_args)
6740         (print_frame_info, print_frame): Add frame_print_options parameter
6741         and use it.
6742         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6743         (backtrace_command_1): Add frame_print_options and
6744         backtrace_cmd_options parameters and use them.
6745         (make_backtrace_options_def_group): New.
6746         (backtrace_command): Process command options with
6747         gdb::option::process_options.
6748         (backtrace_command_completer): New.
6749         (_initialize_stack): Extend "backtrace"'s help to mention
6750         supported options.  Install completer for "backtrace".
6751         Install some settings commands with add_setshow_cmds_for_options.
6752
6753 2019-06-13  Pedro Alves  <palves@redhat.com>
6754
6755         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6756         and that "set/show print raw frame-arguments" are now deprecated.
6757
6758         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6759         command.
6760         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6761         * stack.c (_initialize_stack): Install "set/show print
6762         raw-frame-arguments", and deprecate "set/show print raw
6763         frame-arguments".
6764         * valprint.c (_initialize_valprint): Deprecate "set/show print
6765         raw".
6766
6767 2019-06-13  Pedro Alves  <palves@redhat.com>
6768
6769         * compile/compile.c (struct compile_options): New.
6770         (compile_flag_option_def, compile_command_option_defs)
6771         (make_compile_options_def_group): New.
6772         (compile_file_command): Handle options with
6773         gdb::option::process_options.
6774         (compile_file_command_completer): New function.
6775         (compile_code_command): Handle options with
6776         gdb::option::process_options.
6777         (compile_code_command_completer): New function.
6778         (_initialize_compiler): Install completers for "compile code" and
6779         "compile file".  Mention available options in "compile code" and
6780         "compile code"'s help.
6781         * completer.c (advance_to_completion_word): New, factored out from
6782         ...
6783         (advance_to_expression_complete_word_point): ... this.
6784         (advance_to_filename_complete_word_point): New.
6785         * completer.h (advance_to_filename_complete_word_point): New
6786         declaration.
6787
6788 2019-06-13  Pedro Alves  <palves@redhat.com>
6789
6790         * compile/compile.c: Include "cli/cli-option.h".
6791         (compile_print_value): Scope data pointer is now a
6792         value_print_options pointer; adjust.
6793         (compile_print_command): Process options.  Scope data pointer is
6794         now a value_print_options pointer; adjust.
6795         (_initialize_compile): Update "compile print"'s help to include
6796         supported options.  Install a completer for "compile print".
6797         * cp-valprint.c (show_vtblprint, show_objectprint)
6798         (show_static_field_print): Delete.
6799         (_initialize_cp_valprint): Don't install "set print
6800         static-members", "set print vtbl", "set print object" here.
6801         * printcmd.c: Include "cli/cli-option.h" and
6802         "common/gdb_optional.h".
6803         (print_command_parse_format): Rework to fill in a
6804         value_print_options instead of a format_data.
6805         (print_value): Change parameter type from format_data pointer to
6806         value_print_options reference.  Adjust.
6807         (print_command_1): Process options.  Adjust to pass down a
6808         value_print_options.
6809         (print_command_completer): New.
6810         (_initialize_printcmd): Install print_command_completer as
6811         handle_brkchars completer for the "print" command.  Update
6812         "print"'s help to include supported options.
6813         * valprint.c: Include "cli/cli-option.h".
6814         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6815         here from cp-valprint.c.
6816         (boolean_option_def, uinteger_option_def)
6817         (value_print_option_defs, make_value_print_options_def_group):
6818         New.  Use gdb::option::add_setshow_cmds_for_options to install
6819         "set print elements", "set print null-stop", "set print repeats",
6820         "set print pretty", "set print union", "set print array", "set
6821         print address", "set print symbol", "set print array-indexes".
6822         * valprint.h: Include <string> and "cli/cli-option.h".
6823         (make_value_print_options_def_group): Declare.
6824         (print_value): Change parameter type from format_data pointer to
6825         value_print_options reference.
6826         (print_command_completer): Declare.
6827
6828 2019-06-13  Pedro Alves  <palves@redhat.com>
6829
6830         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6831         (COMMON_SFILES): Add maint-test-settings.c.
6832         * cli/cli-decode.c (boolean_enums): New global, factored out from
6833         ...
6834         (add_setshow_boolean_cmd): ... here.
6835         * cli/cli-decode.h (boolean_enums): Declare.
6836         * cli/cli-option.c: New file.
6837         * cli/cli-option.h: New file.
6838         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6839         factored out from ...
6840         (parse_cli_boolean_value(const char *)): ... this.
6841         (is_unlimited_literal): Change parameter type to pointer to
6842         pointer.  Adjust and advance ARG pointer.
6843         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6844         (parse_cli_var_enum): New, factored out from ...
6845         (do_set_command): ... this.  Adjust.
6846         * cli/cli-setshow.h (parse_cli_boolean_value)
6847         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6848         (parse_cli_var_enum): Declare.
6849         * cli/cli-utils.c: Include "cli/cli-option.h".
6850         (get_ulongest): New.
6851         * cli/cli-utils.h (get_ulongest): Declare.
6852         (check_for_argument): New overloads.
6853         * maint-test-options.c: New file.
6854
6855 2019-06-13  Pedro Alves  <palves@redhat.com>
6856
6857         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6858         parse a range if "-" is at the end of the string.
6859
6860 2019-06-13  Pedro Alves  <palves@redhat.com>
6861
6862         * cli/cli-setshow.c (parse_auto_binary_operation)
6863         (parse_cli_boolean_value): Don't allow "o".
6864
6865 2019-06-13  Pedro Alves  <palves@redhat.com>
6866
6867         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6868         * NEWS: Mention maint test-settings KIND.
6869         * maint-test-settings.c: New file.
6870
6871 2019-06-13  Pedro Alves  <palves@redhat.com>
6872
6873         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6874         completer.
6875         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6876         "set" completers.
6877
6878 2019-06-13  Pedro Alves  <palves@redhat.com>
6879
6880         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6881         after item.
6882
6883 2019-06-13  Pedro Alves  <palves@redhat.com>
6884
6885         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6886
6887 2019-06-13  Pedro Alves <palves@redhat.com>
6888
6889         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6890         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6891         call.
6892         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6893         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6894         calls.
6895         (check_for_argument): Skip spaces after argument.
6896
6897 2019-06-13  Pedro Alves  <palves@redhat.com>
6898
6899         * thread.c (thread_apply_command): Adjust TID parsing.
6900         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6901         detected before end of string.
6902         (tid_is_in_list): Error out if LIST is invalid.
6903
6904 2019-06-13  Pedro Alves  <palves@redhat.com>
6905
6906         * completer.c (complete_line_internal_1): Rewind completion word
6907         point.
6908         (completion_tracker::advance_custom_word_point_by): Change
6909         parameter type to int.
6910         * completer.h (completion_tracker::advance_custom_word_point_by):
6911         Likewise.
6912
6913 2019-06-13  Pedro Alves  <palves@redhat.com>
6914
6915         * completer.c (advance_to_completion_word): Handle delimiters.
6916
6917 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6918
6919         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6920
6921 2019-06-11  Tom Tromey  <tom@tromey.com>
6922
6923         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6924         (xmalloc_failed): Move to alloc.c.
6925         * alloc.c: New file.
6926         * Makefile.in (COMMON_SFILES): Add alloc.c.
6927
6928 2019-06-11  Tom Tromey  <tom@tromey.com>
6929
6930         * nat/linux-waitpid.c: Don't include server.h.
6931         (linux_debug): Remove.
6932         (my_waitpid): Update.
6933
6934 2019-06-11  Tom Tromey  <tromey@adacore.com>
6935
6936         * infcall.c (_initialize_infcall): Remove trailing newline from
6937         help.
6938         * user-regs.c (_initialize_user_regs): Remove trailing newline
6939         from help.
6940         * typeprint.c (_initialize_typeprint): Remove trailing newline
6941         from help.
6942         * reverse.c (_initialize_reverse): Remove trailing newlines from
6943         help.
6944         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6945         from help.
6946         * language.c (add_set_language_command): Remove trailing newline
6947         from help.
6948         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6949         help.
6950         * disasm.c (_initialize_disasm): Remove trailing newline from
6951         help.
6952         * top.c (init_main): Remove trailing newline from help.
6953         * interps.c (_initialize_interpreter): Remove trailing newline
6954         from help.
6955         * btrace.c (_initialize_btrace): Remove trailing newlines from
6956         help.
6957         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6958         from help.
6959         * python/python.c (_initialize_python): Remove trailing newline
6960         from help.
6961         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6962         help.
6963         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6964         from help.  Reformat some text.
6965         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6966         from help.
6967         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6968         newline from help.
6969
6970 2019-06-11  Tom Tromey  <tromey@adacore.com>
6971
6972         * darwin-nat.c (darwin_decode_exception_message)
6973         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6974
6975 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6976
6977         * valops.c (value_slice): Check for not allocated or not
6978         associated values.
6979
6980 2019-06-10  Tom de Vries  <tdevries@suse.de>
6981
6982         PR gdb/24618
6983         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6984         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6985         invalid.
6986
6987 2019-06-10  Tom de Vries  <tdevries@suse.de>
6988
6989         PR gdb/24611
6990         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6991         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6992
6993 2019-06-10  Tom de Vries  <tdevries@suse.de>
6994
6995         PR symtab/24545
6996         * symtab.c (struct demangled_name_entry): Add language field.
6997         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6998         static minimal symbol".  Set and use language field.
6999
7000 2019-06-10  Tom Tromey  <tromey@adacore.com>
7001
7002         * ada-lang.c (_initialize_ada_language): Update help text.
7003
7004 2019-06-10  Tom Tromey  <tromey@adacore.com>
7005
7006         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7007         with a newline.
7008         * guile/guile.c (handle_boot_error): Don't end warning with a
7009         newline.
7010         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7011         warning with a newline.
7012         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7013         newline.
7014         (s12z_frame_cache): Likewise.
7015         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7016         a newline.
7017         * solib-svr4.c (disable_probes_interface): Don't end warning with
7018         a newline.
7019         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7020         newline.
7021         * python/python.c (do_finish_initialization): Don't end warning
7022         with a newline.
7023
7024 2019-06-10  Tom Tromey  <tom@tromey.com>
7025
7026         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7027         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7028         gdbpy_enter.
7029
7030 2019-06-10  Tom Tromey  <tromey@adacore.com>
7031
7032         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7033         data.
7034         (elf_new_init): Don't call stabsread_new_init.
7035         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7036         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7037         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7038
7039 2019-06-10  Tom de Vries  <tdevries@suse.de>
7040
7041         PR symtab/16264
7042         PR symtab/24517
7043         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7044
7045 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7046
7047         * source.c (find_and_open_source): Also rewrite relative file
7048         names.
7049
7050 2019-04-26  Amos Bird  <amosbird@gmail.com>
7051
7052         * annotate.c (annotate_thread_exited): Add "thread-exited"
7053         annotation.
7054
7055 2019-06-06  Tom Tromey  <tromey@adacore.com>
7056
7057         * maint.h (class scoped_command_stats): Use
7058         DISABLE_COPY_AND_ASSIGN.
7059         <print_time>: New method.
7060         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7061         print_time.
7062         (scoped_command_stats::print_time): New method.
7063
7064 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7065
7066         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7067         instructions of lengths 6 or 8 bytes.
7068
7069 2019-06-04  Pedro Alves  <palves@redhat.com>
7070
7071         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7072
7073         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7074         * breakpoint.c (condition_completer): Likewise.
7075         * cli/cli-dump.c (scan_expression): Likewise.
7076         * common/filestuff.c (mkdir_recursive): Likewise.
7077         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7078         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7079         (gdb_abspath): Likewise.
7080         * compile/compile-cplus-types.c
7081         (compile_cplus_instance::decl_name): Likewise.
7082         * completer.c (complete_explicit_location):
7083         (signal_completer, reg_or_group_completer_1): Likewise.
7084         * cp-support.c (cp_remove_params_if_any): Likewise.
7085         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7086         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7087         * infcmd.c (strip_bg_char): Likewise.
7088         * linespec.c (copy_token_string): Likewise.
7089         * mi/mi-main.c (output_cores): Likewise.
7090         * psymtab.c (psymtab_search_name):
7091         * symfile.c (test_set_ext_lang_command): Likewise.
7092         * target.c (target_fileio_read_stralloc): Likewise.
7093         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7094         * value.c (complete_internalvar): Likewise.
7095
7096 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7097
7098         Add objfile property to gdb.Type.
7099         * NEWS: Mention Python API addition.
7100         * python/py-type.c (typy_get_objfile): New method.
7101
7102 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7103
7104         * NEWS: Mention the new set|show style [title|highlight].
7105         Mention changes to "show style", "help" and "apropos".
7106
7107 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7108
7109         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7110         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7111         instead of print_help_for_command.
7112         (print_doc_of_command): New function.
7113         (help_list): Add 'apropos -v word' suggestion.
7114         (print_help_for_command): Style the command name using title style.
7115         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7116         (_initialize_cli_cmds): Describe -v in apropos_command help.
7117
7118 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7119
7120         * cli/cli-style.h (cli_style_option): Add name in constructor,
7121         add m_name class member, add constructor with intensity,
7122         add name class function.
7123         (cli_style_option::add_setshow_commands): Remove name argument.
7124         (highlight_style, title_style): New styles.
7125         * cli/cli-style.c (do_show): New function that shows a style
7126         characteristic styling the style name with itself.
7127         (set_style_name): New function.
7128         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7129         Update all callers according to the changes in cli/cli-style.h.
7130         * utils.h (fputs_highlighted): New function.
7131         * utils.c (fputs_highlighted): Likewise.
7132
7133 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7134
7135         * NEWS: Mention new pipe command and new convenience variables.
7136
7137 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7138
7139         * cli/cli-cmds.c (pipe_command): New function.
7140         (_initialize_cli_cmds): Call add_com for pipe_command.
7141         Define | as an alias for pipe.
7142         (exit_status_set_internal_vars): New function.
7143         (shell_escape): Call exit_status_set_internal_vars.
7144         cli/cli-decode.c (find_command_name_length): Recognize | as
7145         a single character command.
7146
7147 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7148
7149         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7150         top.c (execute_command_to_ui_file): New function, mostly a copy
7151         of execute_command_to_string.
7152         (execute_command_to_string): Implement by calling
7153         execute_command_to_ui_file.
7154
7155 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7156
7157         * top.h (saved_command_line): Remove declaration.
7158         * top.c (previous_saved_command_line, previous_repeat_arguments):
7159         New variables.
7160         (saved_command_line): Make static, define together with other
7161         'repeat variables'.
7162         (dont_repeat): Clear repeat_arguments.
7163         (repeat_previous, get_saved_command_line, save_command_line):
7164         New functions.
7165         (gdb_init): Initialize saved_command_line
7166         and previous_saved_command_line.
7167         * main.c (captured_main_1): Remove saved_command_line initialization.
7168         * event-top.c (handle_line_of_input): Update to use
7169         the new 'repeat' related functions instead of direct access to
7170         saved_command_line.
7171         * command.h (repeat_previous, get_saved_command_line,
7172         save_command_line): New declarations.
7173         (dont_repeat): Add comment.
7174
7175 2019-05-30  Tom Tromey  <tromey@adacore.com>
7176
7177         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7178         Fix comment.
7179         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7180
7181 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7182
7183         PR cli/24587
7184         * completer.c (complete): Initialize variable word.
7185
7186 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7187
7188         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7189         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7190         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7191         'body' is NULL to the outter 'if', protecting the '!is_define'
7192         situation as well.
7193
7194 2019-05-29  Tom Tromey  <tromey@adacore.com>
7195
7196         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7197         (dwarf_unknown): New function.
7198         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7199         (dwarf_type_encoding_name): Use dwarf_unknown.
7200
7201 2019-05-29  Tom Tromey  <tromey@adacore.com>
7202
7203         PR c++/20020:
7204         * cp-valprint.c (cp_print_value_fields): Call
7205         cp_print_static_field inside "try".
7206
7207 2019-05-29  Tom Tromey  <tromey@adacore.com>
7208
7209         * inflow.c (struct terminal_info): Add default operator=.
7210         * configure: Rebuild.
7211         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7212         -Wdeprecated-copy-dtor, -Wredundant-move.
7213
7214 2019-05-29  Tom Tromey  <tromey@adacore.com>
7215
7216         * NEWS: Add entry.
7217         * infcmd.c (print_return_value_1): Handle finish_print
7218         option.
7219         (show_print_finish): New function.
7220         (_initialize_infcmd): Add "set/show print finish" commands.
7221         * valprint.c (user_print_options): Initialize new member.
7222         * valprint.h (struct value_print_options) <finish_print>: New
7223         member.
7224
7225 2019-05-28  Tom Tromey  <tromey@adacore.com>
7226
7227         * ada-lang.c (ada_remove_Xbn_suffix)
7228         (find_old_style_renaming_symbol)
7229         (parse_old_style_renaming): Remove.
7230         (ada_find_renaming_symbol): Don't call
7231         find_old_style_renaming_symbol.
7232         (ada_is_renaming_symbol): Rename from
7233         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7234         bool.  Now static.
7235         (ada_read_var_value): Update and simplify.
7236         * ada-exp.y (write_var_or_type): Remove old code.
7237
7238 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7239
7240         PR gdb/25010
7241         * event-top.c: Remove include comment.
7242         * inflow.c (class scoped_ignore_sigttou): Move from here...
7243         * inflow.h (class scoped_ignore_sigttou): ...to here.
7244         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7245         * top.c:  Remove include comment.
7246
7247 2019-05-27  Tom Tromey  <tom@tromey.com>
7248
7249         * NEWS: Fix typo.
7250
7251 2019-05-22  Tom Tromey  <tromey@adacore.com>
7252
7253         * target.c (target_follow_exec): Constify parameter.
7254         * target-delegates.c: Rebuild.
7255         * remote.c (remote_target::follow_exec): Constify parameter.
7256         * infrun.c (follow_exec): Constify parameter.
7257         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7258         (target_follow_exec): Likewise.
7259
7260 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7261
7262         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7263         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7264
7265 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7266
7267         * NEWS: Add debugredirect and testsuite sections.
7268
7269 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7270
7271         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7272         target descriptions using exclusively floating point register name
7273         aliases.
7274
7275 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7276
7277         PR gdb/18644:
7278         * f-lang.c (build_fortran_types): Handle the case where
7279         gdbarch_floatformat_for_type returns a nullptr.
7280
7281 2019-05-21  Tom de Vries  <tdevries@suse.de>
7282
7283         PR cli/24587
7284         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7285
7286 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7287
7288         PR gdb/18644:
7289         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7290         16-byte floats.
7291         * i386-tdep.c (i386_floatformat_for_type): Use
7292         floatformats_ia64_quad for the 16-byte floating point component
7293         within a fortran 32-byte complex number.
7294
7295 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7296
7297         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7298         delete default constructor.
7299         (find_partial_die): Update to return const struct.
7300         (partial_die_parent_scope): Move variable declaration into scope
7301         of its use and change its type to auto.
7302         (guess_partial_die_structure_name): Likewise.
7303         (partial_die_info::fixup): Likewise.
7304
7305 2019-05-17  Tom Tromey  <tromey@adacore.com>
7306
7307         * source.c (find_and_open_source): Remove cast.
7308
7309 2019-05-17  Tom Tromey  <tromey@adacore.com>
7310
7311         * annotate.c (annotate_source): Make "filename" const.
7312         * annotate.h (annotate_source): Use const.
7313
7314 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7315
7316         * disasm.c (set_disassembler_options): Send errors to stderr.
7317
7318 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7319
7320         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7321         (cli_interp_base::set_logging): Check debug_redirect.
7322         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7323         * cli/cli-logging.c (debug_redirect): Add static variable.
7324         (pop_output_files): Add default param.
7325         (handle_redirections): Print debug setting.
7326         (show_logging_command): Likewise.
7327         (_initialize_cli_logging): Add debugredirect command.
7328         * interps.c (current_interp_set_logging): Add debug_redirect
7329         parameter.
7330         * interps.h (set_logging): Add debug_redirect parameter.
7331         (current_interp_set_logging): Likewise.
7332         * mi/mi-common.h: Likewise.
7333         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7334
7335 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7336             Tom Tromey  <tromey@adacore.com>
7337
7338         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7339         directly.
7340         * cli/cli-interp.h (make_logging_output): Remove declaration.
7341         * cli/cli-logging.c (make_logging_output): Remove function.
7342         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7343         directly.
7344         * ui-file.c (tee_file::tee_file): Remove bools.
7345         (tee_file::~tee_file): Remove deletes.
7346         * ui-file.h (tee_file): Remove bools.
7347
7348 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7349
7350         * mi/mi-cmds.h (mi_cmd_complete): New function.
7351         * mi/mi-main.c (mi_cmd_complete): Likewise.
7352         * mi/mi-cmds.c: Define new MI command -complete.
7353         * NEWS: Mention new -complete command.
7354
7355 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7356
7357         * completer.h (complete): New function.
7358         * completer.c (complete): Likewise.
7359         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7360         function defined in completer.h.
7361
7362 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7363
7364         * MAINTAINERS (Write After Approval): Add myself.
7365
7366 2019-05-17  Tom de Vries  <tdevries@suse.de>
7367
7368         PR gdb/24094
7369         * dwarf2read.c (struct cu_partial_die_info): New struct.
7370         (find_partial_die): Return cu_partial_die_info.
7371         (partial_die_parent_scope, guess_partial_die_structure_name)
7372         (partial_die_info::fixup): Handle new return type of find_partial_die.
7373
7374 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7375
7376         PR breakpoints/24541
7377         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7378         "std::string", simplifying the algorithm.
7379
7380 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7381
7382         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7383         (stap_static_probe_ops::get_probes): Likewise.
7384
7385 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7386
7387         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7388         '-')" and "else if".
7389         (stap_parse_single_operand): Join checks for
7390         "gdbarch_stap_parse_special_token_p" and
7391         "gdbarch_stap_parse_special_token" in the same "if" statement.
7392         Invert check when verifying for operation on register
7393         displacement.
7394
7395 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7396
7397         * stap-probe.c (stap_get_opcode): Update comment.
7398         (stap_get_expected_argument_type): Likewise.
7399         (handle_stap_probe): Likewise.
7400
7401 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7402
7403         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7404         return type to 'bool'.  Adjust comment.  Use 'bool' when
7405         appropriate.
7406         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7407         * stap-probe.c (stap_parse_argument_1): Likewise.
7408         (stap_is_operator): Likewise.
7409         (stap_is_generic_prefix): Likewise.
7410         (stap_is_register_prefix): Likewise.
7411         (stap_is_register_indirection_prefix): Likewise.
7412         (stap_is_integer_prefix): Likewise.
7413         (stap_generic_check_suffix): Likewise.
7414         (stap_check_integer_suffix): Likewise.
7415         (stap_check_register_suffix): Likewise.
7416         (stap_check_register_indirection_suffix): Likewise.
7417         (stap_parse_register_operand): Likewise.
7418         (stap_parse_single_operand): Likewise.
7419         (stap_parse_argument_1): Likewise.
7420         (stap_probe::get_argument_count): Likewise.
7421         (stap_is_operator): Likewise.
7422
7423 2019-05-16  Tom Tromey  <tromey@adacore.com>
7424
7425         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7426         keyword to foreach.
7427
7428 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7429
7430         * linux-thread-db.c (try_thread_db_load_1): Change return type
7431         to bool.
7432         (try_thread_db_load): Likewise.
7433         (try_thread_db_load_from_pdir_1): Likewise.
7434         (try_thread_db_load_from_pdir): Likewise.
7435         (try_thread_db_load_from_sdir): Likewise.
7436         (try_thread_db_load_from_dir): Likewise.
7437         (thread_db_load_search): Likewise.
7438         (has_libpthread): Likewise.
7439         (thread_db_load): Likewise.
7440
7441 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7442
7443         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7444         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7445         NULL, and complain/return if that's the case.
7446
7447 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7448
7449         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7450         (advance, posn, abstract_read_memory): New functions.
7451         [struct mem_read_abstraction]: New struct.
7452         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7453
7454 2019-05-14  Tom Tromey  <tromey@adacore.com>
7455
7456         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7457         value is not lval_memory.
7458
7459 2019-05-14  Tom Tromey  <tromey@adacore.com>
7460
7461         * solib.c (info_sharedlibrary_command): Style the file name.
7462
7463 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7464
7465         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7466         (aarch64_vnv_type): Likewise.
7467         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7468         * common/tdesc.c: Likewise.
7469         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7470         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7471         * features/aarch64-fpu.xml: Add ieee half view.
7472         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7473         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7474         * gdbtypes.h (struct builtin_type): Likewise.
7475         (struct objfile_type): Likewise.
7476
7477 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7478
7479         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7480         typo.
7481         * location.h (string_to_event_location): Likewise.
7482
7483 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7484
7485         GDB 8.3 released.
7486
7487 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7488
7489         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7490         New variable declaration.
7491         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7492         New variable.
7493         (print_one_breakpoint): Use ui_out::test_flags and new global
7494         variable to compute use_fixed_output.
7495         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7496         Remove.
7497         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7498         (mi_multi_location_breakpoint_output_fixed): Remove.
7499         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7500         new variable.
7501         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7502         fix_multi_location_breakpoint_output flag if version >= 3.
7503         * ui-out.h (enum ui_out_flag)
7504         <fix_multi_location_breakpoint_output>: New enumerator.
7505
7506 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7507
7508         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7509
7510 2019-05-10  Tom Tromey  <tromey@adacore.com>
7511
7512         * ada-lang.c (catch_ada_completer): New function.
7513         (_initialize_ada_language): Use it.
7514
7515 2019-05-10  Tom Tromey  <tromey@adacore.com>
7516
7517         * thread.c (print_thread_info): Make "requested_threads" const.
7518         * gdbthread.h (print_thread_info): Make "requested_threads"
7519         const.
7520         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7521         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7522
7523 2019-05-08  Tom Tromey  <tom@tromey.com>
7524
7525         * gdbtypes.c (objfile_type_data): Change type.
7526         (objfile_type, _initialize_gdbtypes): Update.
7527
7528 2019-05-08  Tom Tromey  <tom@tromey.com>
7529
7530         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7531         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7532         (_initialize_dwarf2_frame): Update.
7533
7534 2019-05-08  Tom Tromey  <tom@tromey.com>
7535
7536         * objc-lang.c (objc_objfile_data): Change type.
7537         (find_methods): Update.
7538         (_initialize_objc_lang): Remove.
7539
7540 2019-05-08  Tom Tromey  <tom@tromey.com>
7541
7542         * stabsread.c (rs6000_builtin_type_data): Change type.
7543         (rs6000_builtin_type, _initialize_stabsread): Update.
7544
7545 2019-05-08  Tom Tromey  <tom@tromey.com>
7546
7547         * mips-tdep.c (mips_pdr_data): Remove.
7548         (_initialize_mips_tdep): Update.
7549
7550 2019-05-08  Tom Tromey  <tom@tromey.com>
7551
7552         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7553         (hppa_init_objfile_priv_data, read_unwind_info)
7554         (find_unwind_entry, _initialize_hppa_tdep): Update.
7555
7556 2019-05-08  Tom Tromey  <tom@tromey.com>
7557
7558         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7559         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7560         on obstack.
7561         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7562
7563 2019-05-08  Tom Tromey  <tom@tromey.com>
7564
7565         * mdebugread.c (basic_type_data): Change type.
7566         (basic_type, _initialize_mdebugread): Update.
7567
7568 2019-05-08  Tom Tromey  <tom@tromey.com>
7569
7570         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7571
7572 2019-05-08  Tom Tromey  <tom@tromey.com>
7573
7574         * nto-tdep.c (nto_inferior_data_reg): Change type.
7575         (nto_inferior_data): Update.
7576         (nto_inferior_data_cleanup, nto_new_inferior_data)
7577         (_initialize_nto_tdep): Remove.
7578         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7579
7580 2019-05-08  Tom Tromey  <tom@tromey.com>
7581
7582         * ada-lang.c (struct ada_inferior_data): Add initializers.
7583         (ada_inferior_data): Change type.
7584         (ada_inferior_data_cleanup): Remove.
7585         (get_ada_inferior_data, ada_inferior_exit)
7586         (struct ada_pspace_data): Add initializers, destructor.
7587         (ada_pspace_data_handle): Change type.
7588         (get_ada_pspace_data): Update.
7589         (ada_pspace_data_cleanup): Remove.
7590
7591 2019-05-08  Tom Tromey  <tom@tromey.com>
7592
7593         * coffread.c (struct coff_symfile_info): Add initializers.
7594         (coff_objfile_data_key): Move lower.  Change type.
7595         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7596         Update.
7597         (coff_free_info): Remove.
7598
7599 2019-05-08  Tom Tromey  <tom@tromey.com>
7600
7601         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7602         (fbsd_pspace_data_handle): Move lower.  Change type.
7603         (get_fbsd_pspace_data): Update.
7604         (fbsd_pspace_data_cleanup): Remove.
7605         (_initialize_fbsd_tdep): Update.
7606
7607 2019-05-08  Tom Tromey  <tom@tromey.com>
7608
7609         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7610         (get_ada_tasks_pspace_data): Update.
7611         (ada_tasks_pspace_data_cleanup): Remove.
7612         (_initialize_tasks): Update.
7613         (ada_tasks_inferior_data_handle): Change type.
7614         (get_ada_tasks_inferior_data): Update.
7615         (ada_tasks_inferior_data_cleanup): Remove.
7616         (struct ada_tasks_pspace_data): Add initializers.
7617
7618 2019-05-08  Tom Tromey  <tom@tromey.com>
7619
7620         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7621         * symfile-debug.c (debug_sym_get_probes): Change type.
7622         * stap-probe.c (handle_stap_probe):
7623         (stap_static_probe_ops::get_probes): Change type.
7624         * probe.h (class static_probe_ops) <get_probes>: Change type.
7625         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7626         (parse_probes_in_pspace): Update.
7627         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7628         Update.
7629         (any_static_probe_ops::get_probes): Change type.
7630         * elfread.c (elfread_data): New typedef.
7631         (probe_key): Change type.
7632         (elf_get_probes): Likewise.  Update.
7633         (probe_key_free): Remove.
7634         (_initialize_elfread): Update.
7635         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7636         Change type.
7637         (dtrace_process_dof_probe, dtrace_process_dof)
7638         (dtrace_static_probe_ops::get_probe): Change type.
7639
7640 2019-05-08  Tom Tromey  <tom@tromey.com>
7641
7642         * xcoffread.c (struct xcoff_symfile_info): Rename from
7643         coff_symfile_info.  Add initializers.
7644         (xcoff_objfile_data_key): Move lower.  Change type.
7645         (XCOFF_DATA): Rewrite.
7646         (xcoff_free_info): Remove.
7647         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7648         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7649         (xcoff_initial_scan): Update.
7650
7651 2019-05-08  Tom Tromey  <tom@tromey.com>
7652
7653         * solib-svr4.c (struct svr4_info): Add initializers and
7654         destructor.
7655         <probes_table>: Now an htab_up.
7656         (solib_svr4_pspace_data): Change type.
7657         (free_probes_table): Simplify.
7658         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7659         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7660         (probes_table_remove_objfile_probes, register_solib_event_probe)
7661         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7662         (_initialize_svr4_solib): Update.
7663
7664 2019-05-08  Tom Tromey  <tom@tromey.com>
7665
7666         * remote.c (remote_pspace_data): Change type.
7667         (remote_pspace_data_cleanup): Remove.
7668         (get_remote_exec_file, set_pspace_remote_exec_file)
7669         (_initialize_remote): Update.
7670
7671 2019-05-08  Tom Tromey  <tom@tromey.com>
7672
7673         * breakpoint.c (breakpoint_objfile_key): Change type.
7674         (get_breakpoint_objfile_data): Update.
7675         (free_breakpoint_objfile_data): Remove.
7676         (_initialize_breakpoint): Update.
7677
7678 2019-05-08  Tom Tromey  <tom@tromey.com>
7679
7680         * linux-tdep.c (struct linux_info): Add initializers.
7681         (linux_inferior_data): Move.  Change type.
7682         (invalidate_linux_cache_inf): Update.
7683         (linux_inferior_data_cleanup): Remove.
7684         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7685
7686 2019-05-08  Tom Tromey  <tom@tromey.com>
7687
7688         * auxv.c (auxv_inferior_data): Move.  Change type.
7689         (auxv_inferior_data_cleanup): Remove.
7690         (invalidate_auxv_cache_inf): Rewrite.
7691         (get_auxv_inferior_data, _initialize_auxv): Update.
7692
7693 2019-05-08  Tom Tromey  <tom@tromey.com>
7694
7695         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7696         (symfile_debug_objfile_data_key): Change type.
7697         (symfile_debug_installed, debug_qf_has_symbols)
7698         (debug_qf_find_last_source_symtab)
7699         (debug_qf_forget_cached_source_info)
7700         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7701         (debug_qf_print_stats, debug_qf_dump)
7702         (debug_qf_expand_symtabs_for_function)
7703         (debug_qf_expand_all_symtabs)
7704         (debug_qf_expand_symtabs_with_fullname)
7705         (debug_qf_map_matching_symbols)
7706         (debug_qf_expand_symtabs_matching)
7707         (debug_qf_find_pc_sect_compunit_symtab)
7708         (debug_qf_map_symbol_filenames)
7709         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7710         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7711         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7712         (debug_sym_read_linetable, debug_sym_relocate): Update.
7713         (symfile_debug_free_objfile): Remove.
7714         (install_symfile_debug_logging, _initialize_symfile_debug):
7715         Update.
7716
7717 2019-05-08  Tom Tromey  <tom@tromey.com>
7718
7719         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7720         allocate_on_obstack.
7721         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7722         (get_dwarf2_per_objfile): Update.
7723         (set_dwarf2_per_objfile): Remove.
7724         (dwarf2_has_info, dwarf2_get_section_info): Update.
7725         (dwarf2_free_objfile): Remove.
7726         (_initialize_dwarf2_read): Update.
7727
7728 2019-05-08  Tom Tromey  <tom@tromey.com>
7729
7730         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7731         initializers.
7732         <unsupported_script_warning_printed,
7733         script_not_found_warning_printed>: Now bool.
7734         (auto_load_pspace_data): Change type.
7735         (~auto_load_pspace_info): Rename from
7736         auto_load_pspace_data_cleanup.
7737         (get_auto_load_pspace_data, init_loaded_scripts_info)
7738         (clear_section_scripts, maybe_print_unsupported_script_warning)
7739         (maybe_print_script_not_found_warning, _initialize_auto_load):
7740         Update.
7741
7742 2019-05-08  Tom Tromey  <tom@tromey.com>
7743
7744         * objfiles.c (objfile_pspace_info): Add destructor and
7745         initializers.
7746         (objfiles_pspace_data): Change type.
7747         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7748         (get_objfile_pspace_data): Update.
7749         (objfiles_bfd_data): Change type.
7750         (get_objfile_bfd_data): Update.
7751         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7752
7753 2019-05-08  Tom Tromey  <tom@tromey.com>
7754
7755         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7756         Change type.
7757         (get_catch_syscall_inferior_data): Update.
7758         (catch_syscall_inferior_data_cleanup): Remove.
7759         (_initialize_break_catch_syscall): Update.
7760
7761 2019-05-08  Tom Tromey  <tom@tromey.com>
7762
7763         * inflow.c (struct terminal_info): Add destructor and
7764         initializers.
7765         (inflow_inferior_data): Change type.
7766         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7767         (get_inflow_inferior_data, inflow_inferior_exit)
7768         (swap_terminal_info, _initialize_inflow): Update.
7769
7770 2019-05-08  Tom Tromey  <tom@tromey.com>
7771
7772         * target-dcache.c (target_dcache_cleanup): Remove.
7773         (target_dcache_aspace_key): Change type.
7774         (target_dcache_init_p, target_dcache_invalidate)
7775         (target_dcache_get, target_dcache_get_or_init)
7776         (_initialize_target_dcache): Update.
7777         * dcache.h (struct dcache_deleter): New.
7778
7779 2019-05-08  Tom Tromey  <tom@tromey.com>
7780
7781         * symtab.c (struct symbol_cache): Add destructor and
7782         initializers.
7783         (symbol_cache_key): Move.  Change type.
7784         (make_symbol_cache, free_symbol_cache): Remove.
7785         (get_symbol_cache): Update.
7786         (symbol_cache_cleanup): Remove.
7787         (ALL_PSPACES, symbol_cache_flush)
7788         (maintenance_print_symbol_cache)
7789         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7790         Update.
7791
7792 2019-05-08  Tom Tromey  <tom@tromey.com>
7793
7794         * symtab.c (struct main_info): Add destructor and initializers.
7795         (main_progspace_key): Move.  Change type.
7796         (get_main_info): Update.
7797         (main_info_cleanup): Remove.
7798         (_initialize_symtab): Update.
7799
7800 2019-05-08  Tom Tromey  <tom@tromey.com>
7801
7802         * registry.h (DECLARE_REGISTRY): Define the _key class.
7803
7804 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7805
7806         * NEWS: Merge two 'New commands' sections.
7807
7808 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7809
7810         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7811         parameter and use Ada language definition instead.
7812         (ada_val_print_ptr): Remove unused language parameter.
7813         (ada_val_print_num): Remove language parameter and use Ada language
7814         definition instead.
7815         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7816         parameter.
7817         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7818         parameter and use Ada language definition instead.
7819         (ada_val_print_1): Update all ada_val_print_xxx calls.
7820         Remove language parameter.
7821         (ada_val_print): Update ada_val_print_1 call.
7822
7823 2019-05-08  Tom Tromey  <tromey@adacore.com>
7824
7825         * remote.c (remote_hw_watchpoint_limit)
7826         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7827         Now static.
7828
7829 2019-05-08  Tom Tromey  <tromey@adacore.com>
7830
7831         * maint.c (_initialize_maint_cmds): Move initialization code to
7832         remote.c.
7833         (watchdog, show_watchdog): Move to remote.c.
7834         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7835         "watchdog" static.
7836         (_initialize_remote): Move initialization code from maint.c.
7837         * defs.h (watchdog): Don't declare.
7838
7839 2019-05-08  Tom Tromey  <tromey@adacore.com>
7840
7841         * tui/tui-interp.c: Include main.h.
7842         * interps.c: Include main.h.
7843         * main.h (interpreter_p): Declare.
7844         * defs.h (interpreter_p): Don't declare.
7845
7846 2019-05-08  Tom Tromey  <tromey@adacore.com>
7847
7848         * dwarf2loc.c: Include dwarf2read.h.
7849         * defs.h (read_unsigned_leb128): Don't declare.
7850         * dwarf2read.h (read_unsigned_leb128): Declare.
7851
7852 2019-05-08  Tom Tromey  <tromey@adacore.com>
7853
7854         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7855         method.
7856
7857 2019-05-08  Tom Tromey  <tromey@adacore.com>
7858
7859         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7860         when no wrap column is set.
7861
7862 2019-05-08  Tom Tromey  <tromey@adacore.com>
7863
7864         * c-lang.c (c_get_string): Handle non-C-style arrays.
7865
7866 2019-05-08  Tom Tromey  <tromey@adacore.com>
7867
7868         * typeprint.c (print_offset_data::update): Print the bit offset,
7869         not the number of bits remaining.
7870
7871 2019-05-08  Tom Tromey  <tromey@adacore.com>
7872
7873         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7874         padding at end of comment.
7875
7876 2019-05-08  Tom Tromey  <tromey@adacore.com>
7877
7878         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7879         Compare main types.
7880
7881 2019-05-06  Tom Tromey  <tom@tromey.com>
7882
7883         * common/scoped_mmap.c: Include common-defs.h.
7884         * common/scoped_mmap.h: Don't include config.h.
7885
7886 2019-05-04  Tom Tromey  <tom@tromey.com>
7887
7888         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7889         (struct aarch64_call_info): Add initializers.
7890         <si>: Now a std::vector.
7891         (pass_on_stack, aarch64_push_dummy_call): Update.
7892
7893 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7894             Tom Tromey  <tom@tromey.com>
7895
7896         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7897         (ppc_threads): Now a std::vector.  Now static.
7898         (hwdebug_find_thread_points_by_tid)
7899         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7900         Update.
7901
7902 2019-05-04  Tom Tromey  <tom@tromey.com>
7903
7904         * arc-tdep.c (arc_tdesc_init): Return bool.
7905
7906 2019-05-04  Tom Tromey  <tom@tromey.com>
7907
7908         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7909         Use gdb_assert_not_reached.
7910
7911 2019-05-04  Tom Tromey  <tom@tromey.com>
7912
7913         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7914         "false".
7915
7916 2019-05-04  Tom Tromey  <tom@tromey.com>
7917
7918         * arc-tdep.c (arc_tdesc_init): Use bool.
7919
7920 2019-05-04  Tom Tromey  <tom@tromey.com>
7921
7922         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7923
7924 2019-05-04  Tom Tromey  <tom@tromey.com>
7925
7926         * cli/cli-cmds.c (valid_command_p): Return bool.
7927
7928 2019-05-04  Tom Tromey  <tom@tromey.com>
7929
7930         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7931         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7932
7933 2019-05-04  Raul Tambre  <raul@tambre.ee>
7934
7935         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7936         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7937         operator for comparison.
7938
7939 2019-05-04  Tom Tromey  <tom@tromey.com>
7940
7941         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7942         (lookup_partial_symbol, print_partial_symbols)
7943         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7944         (psymbol_compare): Update.
7945         (add_psymbol_to_bcache): Clear the entire psymbol.
7946         (maintenance_check_psymtabs): Update.
7947         * psympriv.h (struct partial_symbol): Don't derive from
7948         general_symbol_info.
7949         <obj_section, unrelocated_address, address,
7950         set_unrelocated_address>: Update.
7951         <ginfo>: New member.
7952         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7953         (debug_names::write_psymbols): Update.
7954
7955 2019-05-04  Tom de Vries  <tdevries@suse.de>
7956
7957         * contrib/cc-with-tweaks.sh: Support -n arg.
7958
7959 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7960
7961         * corelow.c (core_target::detach): Ensure frame cache and
7962         register caches are cleared.
7963         inferior.c (exit_inferior_1): Likewise.
7964
7965 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7966             Tom Tromey  <tom@tromey.com>
7967
7968         * dictionary.c (collate_pending_symbols_by_language): Remove
7969         "struct" from foreach.
7970         * symtab.c (lookup_global_symbol_from_objfile)
7971         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7972         foreach.
7973         * ser-tcp.c (net_open): Remove "struct" from foreach.
7974         * objfiles.c (objfile_relocate, objfile_rebase)
7975         (objfile_has_symbols): Remove "struct" from foreach.
7976         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7977         from foreach.
7978         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7979         foreach.
7980         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7981         "struct" from foreach.
7982         * ada-lang.c (create_excep_cond_exprs)
7983         (ada_exception_catchpoint_cond_string): Remove "struct" from
7984         foreach.
7985
7986 2019-05-03  Tom Tromey  <tromey@adacore.com>
7987
7988         * ada-exp.y (convert_char_literal): Check suffix of each
7989         enumerator.
7990
7991 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7992
7993         PR ada/21406:
7994         * ada-exp.y (yywrap): Don't define.
7995         * ada-lex.l (%option): Add noyywrap
7996         (yywrap): Remove.
7997
7998 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7999
8000         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8001         _WIN32_WINNT to the XP level, unless already defined to a higher
8002         level.
8003
8004         * unittests/parse-connection-spec-selftests.c:
8005         * ser-tcp.c:
8006         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8007         override.
8008
8009         * symfile.c (find_separate_debug_file): Remove colon from the
8010         drive spec of DOS/Windows file names of the target, so that the
8011         file name produced from DEBUGDIR and the target's directory will
8012         be valid on DOS/Windows systems.
8013
8014 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8015
8016         * rust-lang.c (val_print_struct): Handle printing structures
8017         containing strings.
8018
8019 2019-05-02  Tom Tromey  <tromey@adacore.com>
8020
8021         * valarith.c (_initialize_valarith): Remove.
8022
8023 2019-05-01  Tom Tromey  <tromey@adacore.com>
8024
8025         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8026         bitfields.
8027
8028 2019-05-01  Tom Tromey  <tromey@adacore.com>
8029
8030         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8031         for big-endian copies.
8032
8033 2019-04-30  Ali Tamur  <tamur@google.com>
8034         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8035         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8036         (read_3_bytes): New function.
8037
8038 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8039
8040         * windows-nat.c (main_thread_id): Delete.
8041         (handle_output_debug_string): Replace main_thread_id by
8042         current_event.dwThreadId.
8043         (fake_create_process): Likewise.
8044         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8045         Do not set main_thread_id.
8046         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8047         current_event.dwThreadId.
8048         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8049
8050 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8051
8052         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8053         Use current_event.dwThreadId instead of main_thread_id.
8054
8055 2019-04-30  Tom Tromey  <tromey@adacore.com>
8056
8057         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8058         (create_excep_cond_exprs): Iterate over program spaces.
8059         (ada_exception_catchpoint_cond_string): Examine all minimal
8060         symbols for exception types.
8061
8062 2019-04-30  Tom Tromey  <tromey@adacore.com>
8063
8064         PR c++/24470:
8065         * dwarf2read.c (process_structure_scope): Handle case where type
8066         has template parameters but no symbol was created.
8067
8068 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8069             Chris January  <chris.january@arm.com>
8070
8071         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8072         qualifier.
8073         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8074
8075 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8076
8077         * f-typeprint.c (f_print_type): Update rules for printing
8078         whitespace.
8079         (f_type_print_varspec_suffix): Likewise.
8080
8081 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8082             Chris January  <chris.january@arm.com>
8083
8084         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8085         function arguments.
8086
8087 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8088
8089         * f-lang.c (build_fortran_types): Change name of void type to
8090         lower case.
8091         * f-typeprint.c (f_type_print_base): Print the name of the void
8092         type, rather than a fixed string.
8093         * f-valprint.c (f_decorations): Use lower case void string.
8094
8095 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8096             Chris January  <chris.january@arm.com>
8097
8098         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8099         types for Fortran.
8100
8101 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8102             Chris January  <chris.january@arm.com>
8103             David Lecomber  <david.lecomber@arm.com>
8104
8105         * f-exp.y (BINOP_INTRINSIC): New token.
8106         (exp): New parser rule handling BINOP_INTRINSIC.
8107         (f77_keywords): Add new builtin procedures.
8108         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8109         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8110         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8111         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8112         (print_unop_subexp_f): New function.
8113         (print_binop_subexp_f): New function.
8114         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8115         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8116         (dump_subexp_body_f): Likewise.
8117         (operator_check_f): Likewise.
8118         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8119         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8120
8121 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8122
8123         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8124         UNOP_KIND.
8125         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8126         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8127         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8128         (operator_length_f): New fuction.
8129         (print_subexp_f): New function.
8130         (op_name_f): New function.
8131         (dump_subexp_body_f): New function.
8132         (operator_check_f): New function.
8133         (exp_descriptor_f): Replace standard expression handling functions
8134         with new functions.
8135         * gdb/fortran-operator.def: New file.
8136         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8137         * gdb/std-operator.def: Remove UNOP_KIND.
8138
8139 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8140
8141         * std-operator.def: Remove unbalanced, stray double quote
8142         character.
8143
8144 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8145             Chris January  <chris.january@arm.com>
8146             Daniel Everett  <daniel.everett@arm.com>
8147             Nick Forrington  <nick.forrington@arm.com>
8148             Richard Bunt  <richard.bunt@arm.com>
8149
8150         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8151         of depth when printing anonymous structs or unions.
8152         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8153         Don't print either the top-level value, or the children if the
8154         max-depth is exceeded.
8155         (ppscm_print_children): When printing the key of a map, allow one
8156         extra level of depth.
8157         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8158         print either the top-level value, or the children if the max-depth
8159         is exceeded.
8160         (print_children): When printing the key of a map, allow one extra
8161         level of depth.
8162         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8163         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8164         (user_print_options): Initialise max_depth field.
8165         (val_print_scalar_or_string_type_p): New function.
8166         (val_print): Check to see if the max depth has been reached.
8167         (val_print_check_max_depth): Define new function.
8168         (show_print_max_depth): New function.
8169         (_initialize_valprint): Add 'print max-depth' option.
8170         * valprint.h (struct value_print_options) <max_depth>: New field.
8171         (val_print_check_max_depth): Declare new function.
8172         * NEWS: Document new feature.
8173
8174 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8175
8176         * ada-lang.c (ada_language_defn): Initialise new field.
8177         * c-lang.c (c_is_string_type_p): New function.
8178         (c_language_defn): Initialise new field.
8179         (cplus_language_defn): Initialise new field.
8180         (asm_language_defn): Initialise new field.
8181         (minimal_language_defn): Initialise new field.
8182         * c-lang.h (c_is_string_type_p): Declare new function.
8183         * d-lang.c (d_language_defn): Initialise new field.
8184         * f-lang.c (f_is_string_type_p): New function.
8185         (f_language_defn): Initialise new field.
8186         * go-lang.c (go_is_string_type_p): New function.
8187         (go_language_defn): Initialise new field.
8188         * language.c (default_is_string_type_p): New function.
8189         (unknown_language_defn): Initialise new field.
8190         (auto_language_defn): Initialise new field.
8191         * language.h (struct language_defn) <la_is_string_type_p>: New
8192         member variable.
8193         (default_is_string_type_p): Declare new function.
8194         * m2-lang.c (m2_language_defn): Initialise new field.
8195         * objc-lang.c (objc_language_defn): Initialise new field.
8196         * opencl-lang.c (opencl_language_defn): Initialise new field.
8197         * p-lang.c (pascal_is_string_type_p): New function.
8198         (pascal_language_defn): Initialise new field.
8199         * rust-lang.c (rust_is_string_type_p): New function.
8200         (rust_language_defn): Initialise new field.
8201
8202 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8203
8204         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8205         New field.
8206         * ada-lang.c (ada_language_defn): Initialise new field.
8207         * c-lang.c (c_language_defn): Likewise.
8208         (cplus_language_defn): Likewise.
8209         (asm_language_defn): Likewise.
8210         (minimal_language_defn): Likewise.
8211         * d-lang.c (d_language_defn): Likewise.
8212         * f-lang.c (f_language_defn): Likewise.
8213         * go-lang.c (go_language_defn): Likewise.
8214         * language.c (unknown_language_defn): Likewise.
8215         (auto_language_defn): Likewise.
8216         * m2-lang.c (m2_language_defn): Likewise.
8217         * objc-lang.c (objc_language_defn): Likewise.
8218         * opencl-lang.c (opencl_language_defn): Likewise.
8219         * p-lang.c (pascal_language_defn): Likewise.
8220         * rust-lang.c (rust_language_defn): Likewise.
8221
8222 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8223
8224         * ada-lang.c (ada_is_character_type): Change return type to bool.
8225         (ada_is_string_type): Likewise.
8226         * ada-lang.h (ada_is_character_type): Update declaration
8227         (ada_is_string_type): Likewise.
8228
8229 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8230
8231         Support style in 'frame|thread apply'
8232
8233         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8234         * record.c (record_start, record_stop): Update callers of
8235         execute_command_to_string with false.
8236         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8237         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8238         methods.
8239         (class string_file): New constructor with term_out parameter.
8240         Override methods term_out and can_emit_style_escape.  New member
8241         term_out.
8242         (class stdio_file): Override can_emit_style_escape.
8243         (class tee_file): Override term_out and can_emit_style_escape.
8244         * utils.h (can_emit_style_escape): Remove.
8245         * utils.c (can_emit_style_escape): Likewise.
8246         Update all callers of can_emit_style_escape (SOMESTREAM) to
8247         SOMESTREAM->can_emit_style_escape.
8248         * source-cache.c (source_cache::get_source_lines): Likewise.
8249         * stack.c (frame_apply_command_count): Call execute_command_to_string
8250         passing the term_out characteristic of the current gdb_stdout.
8251         * thread.c (thr_try_catch_cmd): Likewise.
8252         * top.c (execute_command_to_string): pass term_out parameter
8253         to construct the string_file for the command output.
8254         * ui-file.c (term_cli_styling): New function (most code moved
8255         from utils.c can_emit_style_escape).
8256         (string_file::string_file, string_file::can_emit_style_escape,
8257         stdio_file::can_emit_style_escape, tee_file::term_out,
8258         tee_file::can_emit_style_escape): New functions.
8259
8260 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8261
8262         * NEWS: Mention the new set|show may-call-functions.
8263         * infcall.c (may_call_functions_p): New variable.
8264         (show_may_call_functions_p): New function.
8265         (call_function_by_hand_dummy): Throws an error if not
8266         may-call-functions.
8267         (_initialize_infcall): Call add_setshow_boolean_cmd for
8268         may-call-functions.
8269
8270 2019-04-25  Keith Seitz  <keiths@redhat.com>
8271
8272         PR c++/24367
8273         * cp-support.c (inspect_type): Don't attempt substitutions
8274         of symbol with the same name.
8275
8276 2019-04-25  Tom Tromey  <tromey@adacore.com>
8277
8278         PR gdb/24475:
8279         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8280         static.
8281
8282 2019-04-25  Tom Tromey  <tromey@adacore.com>
8283
8284         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8285         rvalue reference.
8286         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8287         (gdb_xml_parser::parse): Use std::move.
8288         * python/python-internal.h (gdbpy_convert_exception): Take a const
8289         reference.
8290         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8291         std::move.
8292         * python/py-utils.c (gdbpy_convert_exception): Take a const
8293         reference.
8294         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8295         Use std::move.
8296         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8297         Use std::move.
8298         * mi/mi-main.c (mi_print_exception): Take a const reference.
8299         * main.c (handle_command_errors): Take a const reference.
8300         * linespec.c (parse_linespec): Use std::move.
8301         * infcall.c (run_inferior_call): Use std::move.
8302         (call_function_by_hand_dummy): Use std::move.
8303         * exec.c (try_open_exec_file): Use std::move.
8304         * exceptions.h (exception_print, exception_fprintf)
8305         (exception_print_same): Update.
8306         * exceptions.c (print_exception, exception_print)
8307         (exception_fprintf, exception_print_same): Change parameters to
8308         const reference.
8309         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8310         * common/new-op.c: Use std::move.
8311         * common/common-exceptions.h (struct gdb_exception): Add move
8312         constructor.
8313         (struct gdb_exception_error, struct gdb_exception_quit, struct
8314         gdb_quit_bad_alloc): Change constructor to move constructor.
8315         (throw_exception): Change parameter to rvalue reference.
8316         * common/common-exceptions.c (throw_exception): Take rvalue
8317         reference.
8318         * cli/cli-interp.c (safe_execute_command): Use std::move.
8319         * breakpoint.c (insert_bp_location, location_to_sals): Use
8320         std::move.
8321
8322 2019-04-25  Tom Tromey  <tromey@adacore.com>
8323
8324         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8325         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8326         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8327         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8328         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8329         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8330         guile/scm-value.c: Use unpack.
8331         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8332         gdbscm_gdb_exception.
8333         (gdbscm_throw_gdb_exception): Likewise.
8334         (struct gdbscm_gdb_exception): New.
8335         (unpack): New function.
8336         (gdbscm_wrap): Use unpack.
8337
8338 2019-04-25  Tom Tromey  <tromey@adacore.com>
8339
8340         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8341         (gdb_rl_callback_handler): Use std::move.
8342         * common/common-exceptions.h (struct gdb_exception): Add move
8343         assignment operator.
8344         (throw_exception_sjlj): Change "exception" to const reference.
8345         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8346         (throw_exception_sjlj): Change "exception" to const reference.
8347
8348 2019-04-25  Tom Tromey  <tromey@adacore.com>
8349
8350         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8351         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8352         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8353         Update.
8354         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8355         Update.
8356         * mi/mi-interp.c (mi_interp::exec): Update.
8357         * linespec.c (parse_linespec): Update.
8358         * infcall.c (run_inferior_call): Update.
8359         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8360         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8361         (gdbscm_lookup_global_symbol): Update.
8362         * guile/scm-param.c (gdbscm_parameter_value): Update.
8363         * guile/scm-frame.c (gdbscm_frame_read_register)
8364         (gdbscm_frame_read_var): Update.
8365         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8366         * exec.c (try_open_exec_file): Update.
8367         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8368         (gdb_rl_callback_handler): Update.
8369         * common/common-exceptions.h (exception_none): Don't declare.
8370         * common/common-exceptions.c (exception_none): Don't define.
8371         (struct catcher) <exception>: Update.
8372         * cli/cli-interp.c (safe_execute_command): Update.
8373         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8374
8375 2019-04-25  Ali Tamur  <tamur@google.com>
8376
8377         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8378         (read_attribute_value): Likewise.
8379         (dwarf2_read_addr_index): Update comment.
8380         (read_str_index): Add DW_FORM_strx.
8381         (dwarf2_string_attr): Likewise.
8382         (dwarf2_const_value_attr): Likewise.
8383         (dump_die_shallow): Likewise.
8384         (dwarf2_fetch_constant_bytes): Likewise.
8385         (skip_form_bytes): Likewise.
8386         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8387
8388 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8389
8390         PR corefiles/11608
8391         PR corefiles/18187
8392         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8393         OFFSET.  Verify if current mapping contains an ELF header.
8394         (linux_find_memory_regions_full): Adjust call to
8395         dump_mapping_p.
8396
8397 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8398             Kang Li <kanglictf@gmail.com>
8399
8400         PR gdb/21600
8401
8402         * dwarf2-frame.c (read_initial_length): Be consistent about using
8403         unsigned representation of length.
8404         (decode_frame_entry_1): Likewise.  Check for wraparound of
8405         end pointer as well as buffer overflow.
8406
8407 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8408
8409         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8410         "vq".
8411
8412 2019-04-24  Tom Tromey  <tromey@adacore.com>
8413
8414         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8415
8416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8417
8418         * s12z-tdep.c (s12z_unwind_pc): Delete.
8419         (s12z_unwind_sp): Delete.
8420         (s12z_gdbarch_init): Don't register deleted functions with
8421         gdbarch.
8422
8423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8424
8425         * rl78-tdep.c (rl78_unwind_sp): Delete.
8426         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8427
8428 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8429
8430         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8431         (xstormy16_unwind_pc): Delete.
8432         (xstormy16_dummy_id): Delete.
8433         (xstormy16_gdbarch_init): Don't register deleted functions with
8434         gdbarch.
8435
8436 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8437
8438         * vax-tdep.c (vax_unwind_pc): Delete.
8439         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8440
8441 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8442
8443         * v850-tdep.c (v850_unwind_sp): Delete.
8444         (v850_unwind_pc): Delete.
8445         (v850_dummy_id): Delete.
8446         (v850_gdbarch_init): Don't register deleted functions with
8447         gdbarch.
8448
8449 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8450
8451         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8452         (tilegx_unwind_pc): Delete.
8453         (tilegx_unwind_dummy_id): Delete.
8454         (tilegx_gdbarch_init): Don't register deleted functions with
8455         gdbarch.
8456
8457 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8458
8459         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8460         (tic6x_dummy_id): Delete.
8461         (tic6x_gdbarch_init): Don't register deleted functions with
8462         gdbarch.
8463
8464 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8465
8466         * sparc-tdep.c (sparc_unwind_pc): Delete.
8467         (sparc32_gdbarch_init): Don't register deleted function with
8468         gdbarch.
8469
8470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8471
8472         * sh-tdep.c (sh_unwind_sp): Delete.
8473         (sh_unwind_pc): Delete.
8474         (sh_dummy_id): Delete.
8475         (sh_gdbarch_init): Don't register deleted functions with
8476         gdbarch.
8477
8478 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8479
8480         * score-tdep.c (score_unwind_sp): Delete.
8481         (score_unwind_pc): Delete.
8482         (score_dummy_id): Delete.
8483         (score_gdbarch_init): Don't register deleted functions with
8484         gdbarch.
8485
8486 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8487
8488         * rx-tdep.c (rx_unwind_pc): Delete.
8489         (rx_unwind_sp): Delete.
8490         (rx_dummy_id): Delete.
8491         (rx_gdbarch_init): Don't register deleted functions with
8492         gdbarch.  Update comment.
8493
8494 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8495
8496         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8497         (rs6000_dummy_id): Delete.
8498         (rs6000_gdbarch_init): Don't register deleted functions with
8499         gdbarch.
8500
8501 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8502
8503         * or1k-tdep.c (or1k_dummy_id): Delete.
8504         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8505
8506 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8507
8508         * nios2-tdep.c (nios2_dummy_id): Delete.
8509         (nios2_unwind_sp): Delete.
8510         (nios2_gdbarch_init): Don't register deleted functions with
8511         gdbarch.
8512
8513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8514
8515         * nds32-tdep.c (nds32_dummy_id): Delete.
8516         (nds32_unwind_pc): Delete.
8517         (nds32_unwind_sp): Delete.
8518         (nds32_gdbarch_init): Don't register deleted functions with
8519         gdbarch.
8520
8521 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8522
8523         * msp430-tdep.c (msp430_unwind_pc): Delete.
8524         (msp430_unwind_sp): Delete.
8525         (msp430_dummy_id): Delete.
8526         (msp430_gdbarch_init): Don't register deleted functions with
8527         gdbarch.
8528
8529 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8530
8531         * moxie-tdep.c (moxie_unwind_sp): Delete.
8532         (moxie_unwind_pc): Delete.
8533         (moxie_dummy_id): Delete.
8534         (moxie_gdbarch_init): Don't register deleted functions with
8535         gdbarch.
8536
8537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8538
8539         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8540         (mn10300_unwind_pc): Delete.
8541         (mn10300_unwind_sp): Delete.
8542         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8543         mn10300_unwind_sp.
8544         (mn10300_frame_unwind_init): Don't register deleted functions with
8545         gdbarch.
8546
8547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8548
8549         * mep-tdep.c (mep_unwind_pc): Delete.
8550         (mep_unwind_sp): Delete.
8551         (mep_dummy_id): Delete.
8552         (mep_gdbarch_init): Don't register deleted functions with
8553         gdbarch.
8554
8555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8556
8557         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8558         (m68hc11_unwind_sp): Delete.
8559         (m68hc11_gdbarch_init): Don't register deleted functions with
8560         gdbarch.
8561
8562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8563
8564         * m32r-tdep.c (m32r_unwind_sp): Delete.
8565         (m32r_unwind_pc): Delete.
8566         (m32r_dummy_id): Delete.
8567         (m32r_gdbarch_init): Don't register deleted functions with
8568         gdbarch.
8569
8570 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8571
8572         * m32c-tdep.c (m32c_unwind_pc): Delete.
8573         (m32c_unwind_sp): Delete.
8574         (m32c_dummy_id): Delete.
8575         (m32c_gdbarch_init): Don't register deleted functions with
8576         gdbarch.
8577
8578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8579
8580         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8581         (lm32_unwind_pc): Delete.
8582         (lm32_dummy_id): Delete.
8583         (lm32_gdbarch_init): Don't register deleted functions with
8584         gdbarch.
8585
8586 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8587
8588         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8589         (iq2000_unwind_pc): Delete.
8590         (iq2000_dummy_id): Delete.
8591         (iq2000_gdbarch_init): Don't register deleted functions with
8592         gdbarch.
8593
8594 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8595
8596         * nds32-tdep.c (nds32_type_align): Delete.
8597         (nds32_push_dummy_call): Use type_align instead.
8598
8599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8600
8601         * arm-tdep.c (arm_type_align): Only handle vector override case.
8602         (arm_push_dummy_call): Use type_align.
8603         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8604
8605 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8606
8607         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8608         case.
8609         (pass_on_stack): Use type_align.
8610         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8611         function.
8612
8613 2019-04-23  Tom Tromey  <tromey@adacore.com>
8614
8615         * dwarf2read.c (line_header::file_name_at): Remove unused
8616         overload.
8617
8618 2019-04-23  Tom de Vries  <tdevries@suse.de>
8619
8620         PR gdb/24438
8621         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8622         invocation.
8623
8624
8625 2019-03-27  Ali Tamur  <tamur@google.com>
8626
8627         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8628         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8629         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8630         (dwarf_expr_context::get_addr_index): Likewise
8631         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8632         (symbol_needs_eval_context::get_addr_index): Likewise
8633         (disassemble_dwarf_expression): Add DW_OP_addrx
8634         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8635         (read_cutu_die_from_dwo): Update comment
8636         (skip_one_die): Add DW_FORM_addrx
8637         (read_attribute_value): Likewise
8638         (var_decode_location): Add DW_OP_addrx
8639         (dwarf2_const_value_attr): Add DW_FORM_addrx
8640         (dump_die_shallow): Likewise
8641         (dwarf2_fetch_constant_bytes): Likewise
8642         (decode_locdesc): Add DW_OP_addrx
8643         (skip_form_bytes): Add DW_FORM_addrx
8644
8645 2019-04-22  Ali Tamur  <tamur@google.com>
8646
8647         * MAINTAINERS (Write After Approval): Add self.
8648
8649 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8650
8651         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8652         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8653         (open_symbol_file_object): Likewise.
8654         (svr4_default_sos): Add info parameter.
8655         (svr4_read_so_list): Likewise.
8656         (svr4_current_sos_direct): Adjust functions calls to pass down
8657         info.
8658         (svr4_current_sos_1): Add info parameter.
8659         (svr4_current_sos): Call get_svr4_info, pass info down to
8660         svr4_current_sos_1.
8661         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8662         get_svr4_info.
8663         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8664         get_svr4_info.
8665         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8666         to get_svr4_info.
8667         (probes_table_remove_objfile_probes): Likewise.
8668         (register_solib_event_probe): Add info parameter.
8669         (solist_update_incremental): Pass info parameter down to
8670         svr4_read_so_list.
8671         (disable_probes_interface): Add info parameter.
8672         (svr4_handle_solib_event): Pass current_program_space to
8673         get_svr4_info.  Adjust disable_probes_interface cleanup.
8674         (svr4_create_probe_breakpoints): Add info parameter, pass it
8675         down to register_solib_event_probe.
8676         (svr4_create_solib_event_breakpoints): Add info parameter,
8677         pass it down to svr4_create_probe_breakpoints.
8678         (enable_break): Pass info down to
8679         svr4_create_solib_event_breakpoints.
8680         (svr4_solib_create_inferior_hook): Pass current_program_space to
8681         get_svr4_info.
8682         (svr4_clear_solib): Likewise.
8683
8684 2019-04-22  Pedro Alves  <palves@redhat.com>
8685
8686         * solib-svr4.c (svr4_free_objfile_observer): New.
8687         (probe_and_action::objfile): New field.
8688         (probes_table_htab_remove_objfile_probes)
8689         (probes_table_remove_objfile_probes): New functions.
8690         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8691         in the new probe_and_action.  Don't store the probe in 'lookup'.
8692         (svr4_create_probe_breakpoints): Pass objfile to
8693         register_solib_event_probe.
8694         (_initialize_svr4_solib): Register a free_objfile observer.
8695
8696 2019-04-19  Tom Tromey  <tom@tromey.com>
8697
8698         * common/queue.h: Remove.
8699
8700 2019-04-19  Tom Tromey  <tom@tromey.com>
8701
8702         * event-loop.c: Don't include "common/queue.h".
8703
8704 2019-04-19  Tom Tromey  <tom@tromey.com>
8705
8706         * remote.c (remote_target): Use delete.
8707         * remote-notif.h: Include <list>, not "common/queue.h".
8708         (notif_client_p): Remove typedef.
8709         (remote_notif_state): Add constructor, destructor, initializer.
8710         <notif_queue>: Now a std::list.
8711         (remote_notif_state_xfree): Don't declare.
8712         * remote-notif.c (remote_notif_process, handle_notification)
8713         (remote_notif_state_allocate): Update.
8714         (~remote_notif_state): Rename from remote_notif_state_xfree.
8715
8716 2019-04-19  Tom Tromey  <tom@tromey.com>
8717
8718         * symfile.c (reread_symbols): Update.
8719         * objfiles.c (objfile_register_static_link)
8720         (objfile_lookup_static_link): Update
8721         (~objfile) Don't delete static_links.
8722         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8723
8724 2019-04-19  Tom Tromey  <tom@tromey.com>
8725
8726         * type-stack.h (struct type_stack) <insert>: Constify string.
8727         * type-stack.c (type_stack::insert): Constify string.
8728         * gdbtypes.h (lookup_template_type): Update.
8729         (address_space_name_to_int): Update.
8730         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8731         const.
8732         (lookup_template_type): Make name const.
8733         * c-exp.y: Update rules.
8734         (lex_one_token, classify_name, classify_inner_name)
8735         (c_print_token): Update.
8736         * p-exp.y: Update rules.
8737         (yylex): Update.
8738         * f-exp.y: Update rules.
8739         (yylex): Update.
8740         * d-exp.y: Update rules.
8741         (lex_one_token, classify_name, classify_inner_name): Update.
8742         * parse.c (write_dollar_variable, copy_name): Return std::string.
8743         * parser-defs.h (copy_name): Change return type.
8744         * m2-exp.y: Update rules.
8745         (yylex): Update.
8746         * go-exp.y (lex_one_token): Update.
8747         Update rules.
8748         (classify_unsafe_function, classify_packaged_name)
8749         (classify_name, yylex): Update.
8750
8751 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8752
8753         * configure.ac: add --enable-source-highlight switch.
8754         * configure: Regenerate.
8755         * top.c (print_gdb_version): plumb --enable-source-highlight
8756         status to "show configuration".
8757
8758 2019-04-19  Tom Tromey  <tromey@adacore.com>
8759
8760         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8761         Check ADA_TYPE_P.
8762         (empty_record, ada_template_to_fixed_record_type_1)
8763         (template_to_static_fixed_type)
8764         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8765         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8766         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8767         macros.
8768
8769 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8770
8771         PR symtab/24423:
8772         * source.c (print_source_lines_base): Advance "iter" when a
8773         control character is seen.
8774
8775 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8776
8777         * inferior.h (struct infcall_suspend_state_deleter):
8778         Catch exception in destructor to avoid crash.
8779
8780 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8781
8782         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8783         close to the add_com "shell".
8784
8785 2019-04-18  Tom Tromey  <tromey@adacore.com>
8786
8787         * process-stratum-target.h (class process_stratum_target)
8788         <stratum>: Add "final".
8789
8790 2019-04-17  Tom Tromey  <tromey@adacore.com>
8791
8792         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8793         against nullptr before use.
8794
8795 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8796
8797         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8798
8799 2019-04-17  Jim Wilson  <jimw@sifive.com>
8800             Andrew Burgess  <andrew.burgess@embecosm.com>
8801
8802         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8803         code read might fail, assume 4-byte breakpoint in that case.
8804
8805 2019-04-15  Leszek Swirski  <leszeks@google.com>
8806
8807         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8808         rather than a hand-rolled POD check when checking for forced MEMORY
8809         classification.
8810
8811 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8812
8813         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8814         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8815         function.
8816         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8817         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8818         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8819         declaration.
8820
8821 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8822
8823         * aarch64-linux-nat.c
8824         (aarch64_linux_nat_target::thread_architecture): Add override.
8825         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8826         each VQ.
8827
8828 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8829
8830         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8831
8832 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8833
8834         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8835         target types of size 96-bits, add some additional comments, and
8836         check that the builtin type we found was the correct size.
8837
8838 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8839
8840         * utils.c (prompt_for_continue): Don't restore the styling at the
8841         end, as applied_style has the wrong value.  This fixes styling in
8842         long lists of file names that are interrupted by the "Continue?"
8843         prompt.
8844
8845 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8846
8847         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8848         * c-lang.c (c_language_defn): Likewise.
8849         (cplus_language_defn): Likewise.
8850         (asm_language_defn): Likewise.
8851         (minimal_language_defn): Likewise.
8852         * d-lang.c (d_language_defn): Likewise.
8853         * f-lang.c (f_language_defn): Likewise.
8854         * go-lang.c (go_language_defn): Likewise.
8855         * language.c (unknown_language_defn): Likewise.
8856         (auto_language_defn): Likewise.
8857         * language.h (struct language_defn): Remove la_magic field.
8858         (LANG_MAGIC): Delete.
8859         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8860         * objc-lang.c (objc_language_defn): Likewise.
8861         * opencl-lang.c (opencl_language_defn): Likewise.
8862         * p-lang.c (pascal_language_defn): Likewise.
8863         * rust-lang.c (rust_language_defn): Likewise.
8864
8865 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8866
8867         * riscv-tdep.c (riscv_type_align): New function.
8868         (riscv_type_alignment): Delete.
8869         (riscv_arg_location): Use 'type_align'.
8870         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8871
8872 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8873
8874         * gdbtypes.c (type_align): A struct with no non-static fields also
8875         has alignment of 1.
8876
8877 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8878
8879         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8880         component to 0.
8881         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8882         member.
8883         (riscv_struct_info::analyse): New implementation using new
8884         analyse_inner member function.
8885         (riscv_struct_info::field_offset): New member function.
8886         (riscv_struct_info::m_offsets): New member variable.
8887         (riscv_struct_info::analyse_inner): New private member function,
8888         takes the old implementation of riscv_struct_info::analyse but
8889         extended to track field offsets.
8890         (riscv_call_arg_struct): Update the struct folding special cases
8891         to handle cases where empty C++ structs, which are non-zero
8892         length, are found.
8893         (riscv_arg_location): Initialise the length of each location, a
8894         non-zero length now indicates the location is in use.
8895         (riscv_push_dummy_call): Allow for the first location having a
8896         non-zero offset when setting up arguments.
8897         (riscv_return_value): Likewise, but for return values.
8898
8899 2019-04-11  Tom Tromey  <tromey@adacore.com>
8900
8901         * utils.c (internal_vproblem): Make "msg" const.
8902
8903 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8904
8905         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8906         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8907         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8908         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8909
8910 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8911
8912         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8913         function.
8914         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8915         of amd64_collect_native_gregset.
8916         (amd64_linux_nat_target::store_registers): Likewise.
8917
8918 2019-04-10  Tom Tromey  <tom@tromey.com>
8919
8920         * symtab.c (lookup_global_symbol_from_objfile)
8921         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8922         * objfiles.h (class separate_debug_iterator): New.
8923         (class separate_debug_range): New.
8924         (struct objfile) <separate_debug_objfiles>: New method.
8925         (objfile_separate_debug_iterate): Don't declare.
8926         * objfiles.c (separate_debug_iterator::operator++): Rename from
8927         objfile_separate_debug_iterate.
8928         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8929         iterator.
8930         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8931         iterator.
8932
8933 2019-04-10  Tom Tromey  <tom@tromey.com>
8934
8935         * symfile.c (reread_symbols): Remove old comment.
8936         * objfiles.c (free_all_objfiles): Fix a typo.
8937
8938 2019-04-10  Tom Tromey  <tom@tromey.com>
8939
8940         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8941         * minsyms.c (lookup_minimal_symbol): Use foreach.
8942         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8943         (lookup_minimal_symbol_solib_trampoline): Likewise.
8944         * symfile.c (reread_symbols): Use foreach.
8945
8946 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8947             Tom Tromey  <tromey@adacore.com>
8948
8949         PR rust/24414:
8950         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8951         (rust_lex_int_test): Change "value" to be LONGEST.
8952         (rust_lex_tests): Add test for long integer literal.
8953
8954 2019-04-09  Tom Tromey  <tromey@adacore.com>
8955
8956         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8957         to bool.
8958         (extended_remote_target::attach): Update.
8959         (remote_target::remote_notice_new_inferior): Update.
8960         (remote_target::add_current_inferior_and_thread): Update.
8961         * inferior.c (exit_inferior_1): Use "false".
8962         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8963
8964 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8965
8966         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8967         the "start" command.
8968
8969 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8970
8971         * python/py-inferior.c (infpy_thread_from_thread_handle):
8972         Adjust comments to reflect renaming of thread_from_thread_handle
8973         to thread_from_handle.  Adjust keywords.  Fix type error message.
8974         (inferior_object_methods): Add thread_from_handle.  Retain
8975         thread_from_thread_handle, but mark it as deprecated.
8976
8977 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8978
8979         * gdbthread.h (find_thread_by_handle): Revise declaration.
8980         * thread.c (find_thread_by_handle): Likewise.  Adjust
8981         implementation too.
8982         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8983         support for buffer objects as handles.
8984
8985 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8986
8987         * python/py-infthread.c (thpy_thread_handle): New function.
8988         (thread_object_methods): Register thpy_thread_handle.
8989
8990 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8991
8992         * gdbthread.h (thread_to_thread_handle): Declare.
8993         * thread.c (gdbtypes.h): Include.
8994         (thread_to_thread_handle): New function.
8995
8996         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8997         (target_thread_info_to_thread_handle): Declare.
8998         * target.c (target_thread_info_to_thread_handle): New function.
8999         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9000         * target-delegates.c: Regenerate.
9001
9002         * linux-thread-db.c (class thread_db_target): Add method
9003         thread_info_to_thread_handle.
9004         (thread_db_target::thread_info_to_thread_handle): Define.
9005         * remote.c (class remote_target): Add new method
9006         thread_info_to_thread_handle.
9007         (remote_target::thread_info_to_thread_handle): Define.
9008
9009 2019-04-08  Pedro Alves  <palves@redhat.com>
9010
9011         * common/common-exceptions.c (throw_exception): Don't create
9012         named object to throw; throw directly.
9013         (throw_it): Likewise.  Don't initialize gdb_exception::message
9014         here, with new; pass FMT and AP to the ctor instead.
9015         * common/common-exceptions.h: Include <string>.
9016         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9017         const char *, va_list)): New ctor.  Use std::make_shared.
9018         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9019         errors)): Delete.
9020         (gdb_exception_error::gdb_exception_error(enum errors, const char
9021         *, va_list)): New.
9022         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9023         Add assertion.
9024         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9025         errors)): Delete.
9026         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9027         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9028         Add assertion.
9029
9030 2019-04-08  Tom Tromey  <tom@tromey.com>
9031
9032         * valops.c (value_rtti_indirect_type): Replace throw_exception
9033         with throw.
9034         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9035         with throw.
9036         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9037         throw.
9038         * target.c (target_translate_tls_address): Replace throw_exception
9039         with throw.
9040         * stack.c (frame_apply_command_count): Replace throw_exception
9041         with throw.
9042         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9043         throw.
9044         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9045         with throw.
9046         * rs6000-tdep.c (rs6000_frame_cache)
9047         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9048         * remote.c: Replace throw_exception with throw.
9049         * record-full.c (record_full_message, record_full_wait_1)
9050         (record_full_restore): Replace throw_exception with throw.
9051         * record-btrace.c:
9052         (get_thread_current_frame_id, record_btrace_start_replaying)
9053         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9054         (cmd_record_btrace_start): Replace throw_exception with throw.
9055         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9056         throw.
9057         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9058         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9059         * linespec.c:
9060         (find_linespec_symbols): Replace throw_exception with throw.
9061         * infrun.c (displaced_step_prepare, resume): Replace
9062         throw_exception with throw.
9063         * infcmd.c (post_create_inferior): Replace throw_exception with
9064         throw.
9065         * inf-loop.c (inferior_event_handler): Replace throw_exception
9066         with throw.
9067         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9068         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9069         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9070         (get_prev_frame_always, get_frame_pc_if_available)
9071         (get_frame_address_in_block_if_available, get_frame_language):
9072         Replace throw_exception with throw.
9073         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9074         throw_exception with throw.
9075         * eval.c (fetch_subexp_value, evaluate_var_value)
9076         (evaluate_funcall, evaluate_subexp_standard): Replace
9077         throw_exception with throw.
9078         * dwarf2loc.c (call_site_find_chain)
9079         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9080         Replace throw_exception with throw.
9081         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9082         with throw.
9083         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9084         throw.
9085         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9086         * completer.c (complete_line_internal): Replace throw_exception
9087         with throw.
9088         * compile/compile-object-run.c (compile_object_run): Replace
9089         throw_exception with throw.
9090         * cli/cli-script.c (process_next_line): Replace throw_exception
9091         with throw.
9092         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9093         (btrace_enable, btrace_maint_update_pt_packets): Replace
9094         throw_exception with throw.
9095         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9096         throw_exception with throw.
9097         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9098         throw_exception with throw.
9099         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9100         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9101         * aarch64-tdep.c (aarch64_make_prologue_cache)
9102         (aarch64_make_stub_cache): Replace throw_exception with throw.
9103
9104 2019-04-08  Tom Tromey  <tom@tromey.com>
9105
9106         * common/common-exceptions.c (throw_exception): Rename from
9107         throw_exception_cxx.  Remove old copy.  Make argument const.
9108         (throw_it): Create and throw exception objects directly.
9109         * common/common-exceptions.h (throw_exception): Make argument
9110         const.
9111         (struct gdb_exception_error): Add constructor.
9112         (struct gdb_exception_quit): Add constructor.
9113
9114 2019-04-08  Tom Tromey  <tom@tromey.com>
9115
9116         * common/common-exceptions.h (exception_rethrow): Don't declare.
9117         (TRY_SJLJ): Update comment.
9118         (TRY, CATCH, END_CATCH): Remove.
9119         * common/common-exceptions.c (exception_rethrow): Remove.
9120
9121 2019-04-08  Tom Tromey  <tom@tromey.com>
9122
9123         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9124         Remove.
9125         (gdb_exception_error): Rename from
9126         gdb_exception_RETURN_MASK_ERROR.
9127         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9128         (gdb_quit_bad_alloc): Update.
9129         * aarch64-tdep.c: Update.
9130         * ada-lang.c: Update.
9131         * ada-typeprint.c: Update.
9132         * ada-valprint.c: Update.
9133         * amd64-tdep.c: Update.
9134         * arch-utils.c: Update.
9135         * break-catch-throw.c: Update.
9136         * breakpoint.c: Update.
9137         * btrace.c: Update.
9138         * c-varobj.c: Update.
9139         * cli/cli-cmds.c: Update.
9140         * cli/cli-interp.c: Update.
9141         * cli/cli-script.c: Update.
9142         * common/common-exceptions.c: Update.
9143         * common/new-op.c: Update.
9144         * common/selftest.c: Update.
9145         * compile/compile-c-symbols.c: Update.
9146         * compile/compile-cplus-symbols.c: Update.
9147         * compile/compile-object-load.c: Update.
9148         * compile/compile-object-run.c: Update.
9149         * completer.c: Update.
9150         * corelow.c: Update.
9151         * cp-abi.c: Update.
9152         * cp-support.c: Update.
9153         * cp-valprint.c: Update.
9154         * darwin-nat.c: Update.
9155         * disasm-selftests.c: Update.
9156         * dtrace-probe.c: Update.
9157         * dwarf-index-cache.c: Update.
9158         * dwarf-index-write.c: Update.
9159         * dwarf2-frame-tailcall.c: Update.
9160         * dwarf2-frame.c: Update.
9161         * dwarf2loc.c: Update.
9162         * dwarf2read.c: Update.
9163         * eval.c: Update.
9164         * event-loop.c: Update.
9165         * event-top.c: Update.
9166         * exec.c: Update.
9167         * f-valprint.c: Update.
9168         * fbsd-tdep.c: Update.
9169         * frame-unwind.c: Update.
9170         * frame.c: Update.
9171         * gdbtypes.c: Update.
9172         * gnu-v3-abi.c: Update.
9173         * guile/guile-internal.h: Update.
9174         * guile/scm-block.c: Update.
9175         * guile/scm-breakpoint.c: Update.
9176         * guile/scm-cmd.c: Update.
9177         * guile/scm-disasm.c: Update.
9178         * guile/scm-frame.c: Update.
9179         * guile/scm-lazy-string.c: Update.
9180         * guile/scm-math.c: Update.
9181         * guile/scm-param.c: Update.
9182         * guile/scm-ports.c: Update.
9183         * guile/scm-pretty-print.c: Update.
9184         * guile/scm-symbol.c: Update.
9185         * guile/scm-symtab.c: Update.
9186         * guile/scm-type.c: Update.
9187         * guile/scm-value.c: Update.
9188         * i386-linux-tdep.c: Update.
9189         * i386-tdep.c: Update.
9190         * inf-loop.c: Update.
9191         * infcall.c: Update.
9192         * infcmd.c: Update.
9193         * infrun.c: Update.
9194         * jit.c: Update.
9195         * language.c: Update.
9196         * linespec.c: Update.
9197         * linux-fork.c: Update.
9198         * linux-nat.c: Update.
9199         * linux-tdep.c: Update.
9200         * linux-thread-db.c: Update.
9201         * main.c: Update.
9202         * mi/mi-cmd-break.c: Update.
9203         * mi/mi-cmd-stack.c: Update.
9204         * mi/mi-interp.c: Update.
9205         * mi/mi-main.c: Update.
9206         * objc-lang.c: Update.
9207         * p-valprint.c: Update.
9208         * parse.c: Update.
9209         * ppc-linux-tdep.c: Update.
9210         * printcmd.c: Update.
9211         * python/py-arch.c: Update.
9212         * python/py-breakpoint.c: Update.
9213         * python/py-cmd.c: Update.
9214         * python/py-finishbreakpoint.c: Update.
9215         * python/py-frame.c: Update.
9216         * python/py-framefilter.c: Update.
9217         * python/py-gdb-readline.c: Update.
9218         * python/py-inferior.c: Update.
9219         * python/py-infthread.c: Update.
9220         * python/py-lazy-string.c: Update.
9221         * python/py-linetable.c: Update.
9222         * python/py-objfile.c: Update.
9223         * python/py-param.c: Update.
9224         * python/py-prettyprint.c: Update.
9225         * python/py-progspace.c: Update.
9226         * python/py-record-btrace.c: Update.
9227         * python/py-record.c: Update.
9228         * python/py-symbol.c: Update.
9229         * python/py-type.c: Update.
9230         * python/py-unwind.c: Update.
9231         * python/py-utils.c: Update.
9232         * python/py-value.c: Update.
9233         * python/python.c: Update.
9234         * record-btrace.c: Update.
9235         * record-full.c: Update.
9236         * remote-fileio.c: Update.
9237         * remote.c: Update.
9238         * riscv-tdep.c: Update.
9239         * rs6000-aix-tdep.c: Update.
9240         * rs6000-tdep.c: Update.
9241         * rust-exp.y: Update.
9242         * rust-lang.c: Update.
9243         * s390-tdep.c: Update.
9244         * selftest-arch.c: Update.
9245         * solib-dsbt.c: Update.
9246         * solib-frv.c: Update.
9247         * solib-spu.c: Update.
9248         * solib-svr4.c: Update.
9249         * solib.c: Update.
9250         * sparc64-linux-tdep.c: Update.
9251         * stack.c: Update.
9252         * symfile-mem.c: Update.
9253         * symmisc.c: Update.
9254         * target.c: Update.
9255         * thread.c: Update.
9256         * top.c: Update.
9257         * tracefile-tfile.c: Update.
9258         * tui/tui.c: Update.
9259         * typeprint.c: Update.
9260         * unittests/cli-utils-selftests.c: Update.
9261         * unittests/parse-connection-spec-selftests.c: Update.
9262         * valops.c: Update.
9263         * valprint.c: Update.
9264         * value.c: Update.
9265         * varobj.c: Update.
9266         * windows-nat.c: Update.
9267         * x86-linux-nat.c: Update.
9268         * xml-support.c: Update.
9269
9270 2019-04-08  Tom Tromey  <tom@tromey.com>
9271
9272         * xml-support.c: Use C++ exception handling.
9273         * x86-linux-nat.c: Use C++ exception handling.
9274         * windows-nat.c: Use C++ exception handling.
9275         * varobj.c: Use C++ exception handling.
9276         * value.c: Use C++ exception handling.
9277         * valprint.c: Use C++ exception handling.
9278         * valops.c: Use C++ exception handling.
9279         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9280         handling.
9281         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9282         * typeprint.c: Use C++ exception handling.
9283         * tui/tui.c: Use C++ exception handling.
9284         * tracefile-tfile.c: Use C++ exception handling.
9285         * top.c: Use C++ exception handling.
9286         * thread.c: Use C++ exception handling.
9287         * target.c: Use C++ exception handling.
9288         * symmisc.c: Use C++ exception handling.
9289         * symfile-mem.c: Use C++ exception handling.
9290         * stack.c: Use C++ exception handling.
9291         * sparc64-linux-tdep.c: Use C++ exception handling.
9292         * solib.c: Use C++ exception handling.
9293         * solib-svr4.c: Use C++ exception handling.
9294         * solib-spu.c: Use C++ exception handling.
9295         * solib-frv.c: Use C++ exception handling.
9296         * solib-dsbt.c: Use C++ exception handling.
9297         * selftest-arch.c: Use C++ exception handling.
9298         * s390-tdep.c: Use C++ exception handling.
9299         * rust-lang.c: Use C++ exception handling.
9300         * rust-exp.y: Use C++ exception handling.
9301         * rs6000-tdep.c: Use C++ exception handling.
9302         * rs6000-aix-tdep.c: Use C++ exception handling.
9303         * riscv-tdep.c: Use C++ exception handling.
9304         * remote.c: Use C++ exception handling.
9305         * remote-fileio.c: Use C++ exception handling.
9306         * record-full.c: Use C++ exception handling.
9307         * record-btrace.c: Use C++ exception handling.
9308         * python/python.c: Use C++ exception handling.
9309         * python/py-value.c: Use C++ exception handling.
9310         * python/py-utils.c: Use C++ exception handling.
9311         * python/py-unwind.c: Use C++ exception handling.
9312         * python/py-type.c: Use C++ exception handling.
9313         * python/py-symbol.c: Use C++ exception handling.
9314         * python/py-record.c: Use C++ exception handling.
9315         * python/py-record-btrace.c: Use C++ exception handling.
9316         * python/py-progspace.c: Use C++ exception handling.
9317         * python/py-prettyprint.c: Use C++ exception handling.
9318         * python/py-param.c: Use C++ exception handling.
9319         * python/py-objfile.c: Use C++ exception handling.
9320         * python/py-linetable.c: Use C++ exception handling.
9321         * python/py-lazy-string.c: Use C++ exception handling.
9322         * python/py-infthread.c: Use C++ exception handling.
9323         * python/py-inferior.c: Use C++ exception handling.
9324         * python/py-gdb-readline.c: Use C++ exception handling.
9325         * python/py-framefilter.c: Use C++ exception handling.
9326         * python/py-frame.c: Use C++ exception handling.
9327         * python/py-finishbreakpoint.c: Use C++ exception handling.
9328         * python/py-cmd.c: Use C++ exception handling.
9329         * python/py-breakpoint.c: Use C++ exception handling.
9330         * python/py-arch.c: Use C++ exception handling.
9331         * printcmd.c: Use C++ exception handling.
9332         * ppc-linux-tdep.c: Use C++ exception handling.
9333         * parse.c: Use C++ exception handling.
9334         * p-valprint.c: Use C++ exception handling.
9335         * objc-lang.c: Use C++ exception handling.
9336         * mi/mi-main.c: Use C++ exception handling.
9337         * mi/mi-interp.c: Use C++ exception handling.
9338         * mi/mi-cmd-stack.c: Use C++ exception handling.
9339         * mi/mi-cmd-break.c: Use C++ exception handling.
9340         * main.c: Use C++ exception handling.
9341         * linux-thread-db.c: Use C++ exception handling.
9342         * linux-tdep.c: Use C++ exception handling.
9343         * linux-nat.c: Use C++ exception handling.
9344         * linux-fork.c: Use C++ exception handling.
9345         * linespec.c: Use C++ exception handling.
9346         * language.c: Use C++ exception handling.
9347         * jit.c: Use C++ exception handling.
9348         * infrun.c: Use C++ exception handling.
9349         * infcmd.c: Use C++ exception handling.
9350         * infcall.c: Use C++ exception handling.
9351         * inf-loop.c: Use C++ exception handling.
9352         * i386-tdep.c: Use C++ exception handling.
9353         * i386-linux-tdep.c: Use C++ exception handling.
9354         * guile/scm-value.c: Use C++ exception handling.
9355         * guile/scm-type.c: Use C++ exception handling.
9356         * guile/scm-symtab.c: Use C++ exception handling.
9357         * guile/scm-symbol.c: Use C++ exception handling.
9358         * guile/scm-pretty-print.c: Use C++ exception handling.
9359         * guile/scm-ports.c: Use C++ exception handling.
9360         * guile/scm-param.c: Use C++ exception handling.
9361         * guile/scm-math.c: Use C++ exception handling.
9362         * guile/scm-lazy-string.c: Use C++ exception handling.
9363         * guile/scm-frame.c: Use C++ exception handling.
9364         * guile/scm-disasm.c: Use C++ exception handling.
9365         * guile/scm-cmd.c: Use C++ exception handling.
9366         * guile/scm-breakpoint.c: Use C++ exception handling.
9367         * guile/scm-block.c: Use C++ exception handling.
9368         * guile/guile-internal.h: Use C++ exception handling.
9369         * gnu-v3-abi.c: Use C++ exception handling.
9370         * gdbtypes.c: Use C++ exception handling.
9371         * frame.c: Use C++ exception handling.
9372         * frame-unwind.c: Use C++ exception handling.
9373         * fbsd-tdep.c: Use C++ exception handling.
9374         * f-valprint.c: Use C++ exception handling.
9375         * exec.c: Use C++ exception handling.
9376         * event-top.c: Use C++ exception handling.
9377         * event-loop.c: Use C++ exception handling.
9378         * eval.c: Use C++ exception handling.
9379         * dwarf2read.c: Use C++ exception handling.
9380         * dwarf2loc.c: Use C++ exception handling.
9381         * dwarf2-frame.c: Use C++ exception handling.
9382         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9383         * dwarf-index-write.c: Use C++ exception handling.
9384         * dwarf-index-cache.c: Use C++ exception handling.
9385         * dtrace-probe.c: Use C++ exception handling.
9386         * disasm-selftests.c: Use C++ exception handling.
9387         * darwin-nat.c: Use C++ exception handling.
9388         * cp-valprint.c: Use C++ exception handling.
9389         * cp-support.c: Use C++ exception handling.
9390         * cp-abi.c: Use C++ exception handling.
9391         * corelow.c: Use C++ exception handling.
9392         * completer.c: Use C++ exception handling.
9393         * compile/compile-object-run.c: Use C++ exception handling.
9394         * compile/compile-object-load.c: Use C++ exception handling.
9395         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9396         * compile/compile-c-symbols.c: Use C++ exception handling.
9397         * common/selftest.c: Use C++ exception handling.
9398         * common/new-op.c: Use C++ exception handling.
9399         * cli/cli-script.c: Use C++ exception handling.
9400         * cli/cli-interp.c: Use C++ exception handling.
9401         * cli/cli-cmds.c: Use C++ exception handling.
9402         * c-varobj.c: Use C++ exception handling.
9403         * btrace.c: Use C++ exception handling.
9404         * breakpoint.c: Use C++ exception handling.
9405         * break-catch-throw.c: Use C++ exception handling.
9406         * arch-utils.c: Use C++ exception handling.
9407         * amd64-tdep.c: Use C++ exception handling.
9408         * ada-valprint.c: Use C++ exception handling.
9409         * ada-typeprint.c: Use C++ exception handling.
9410         * ada-lang.c: Use C++ exception handling.
9411         * aarch64-tdep.c: Use C++ exception handling.
9412
9413 2019-04-08  Tom Tromey  <tom@tromey.com>
9414
9415         * xml-support.c (gdb_xml_parser::parse): Update.
9416         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9417         * value.c (show_convenience): Update.
9418         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9419         (test_parse_flags_qcs): Update.
9420         * thread.c (thr_try_catch_cmd): Update.
9421         * target.c (target_translate_tls_address): Update.
9422         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9423         (info_frame_command_core, frame_apply_command_count): Update.
9424         * rust-exp.y (rust_lex_exception_test): Update.
9425         * riscv-tdep.c (riscv_print_one_register_info): Update.
9426         * remote.c (remote_target::enable_btrace): Update.
9427         * record-btrace.c (record_btrace_enable_warn): Update.
9428         * python/py-utils.c (gdbpy_convert_exception): Update.
9429         * printcmd.c (do_one_display, print_variable_and_value): Update.
9430         * mi/mi-main.c (mi_print_exception): Update.
9431         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9432         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9433         * linux-nat.c (linux_nat_target::attach): Update.
9434         * linux-fork.c (class scoped_switch_fork_info): Update.
9435         * infrun.c (displaced_step_prepare): Update.
9436         * infcall.c (call_function_by_hand_dummy): Update.
9437         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9438         * gnu-v3-abi.c (print_one_vtable): Update.
9439         * frame.c (get_prev_frame_always): Update.
9440         * f-valprint.c (info_common_command_for_block): Update.
9441         * exec.c (try_open_exec_file): Update.
9442         * exceptions.c (print_exception, exception_print)
9443         (exception_fprintf, exception_print_same): Update.
9444         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9445         * dwarf-index-cache.c (index_cache::store)
9446         (index_cache::lookup_gdb_index): Update.
9447         * darwin-nat.c (maybe_cache_shell): Update.
9448         * cp-valprint.c (cp_print_value_fields): Update.
9449         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9450         (gcc_cplus_symbol_address): Update.
9451         * compile/compile-c-symbols.c (gcc_convert_symbol)
9452         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9453         * common/selftest.c: Update.
9454         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9455         a std::string.
9456         (exception_try_scope_entry, exception_try_scope_exit): Don't
9457         declare.
9458         (struct exception_try_scope): Remove.
9459         (TRY): Don't use exception_try_scope.
9460         (struct gdb_exception): Add constructor, operator=.
9461         <what>: New method.
9462         (struct gdb_exception_RETURN_MASK_ALL)
9463         (struct gdb_exception_RETURN_MASK_ERROR)
9464         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9465         (struct gdb_quit_bad_alloc): Update.
9466         * common/common-exceptions.c (exception_none): Change
9467         initializer.
9468         (struct catcher) <state, exception>: Initialize inline.
9469         <prev>: Remove member.
9470         (current_catcher): Remove.
9471         (catchers): New global.
9472         (exceptions_state_mc_init): Simplify.
9473         (catcher_pop): Remove.
9474         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9475         (try_scope_depth, exception_try_scope_entry)
9476         (exception_try_scope_exit): Remove.
9477         (throw_exception_sjlj): Update.
9478         (exception_messages, exception_messages_size): Remove.
9479         (throw_it): Simplify.
9480         (gdb_exception_sliced_copy): Remove.
9481         (throw_exception_cxx): Update.
9482         * cli/cli-script.c (script_from_file): Update.
9483         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9484         Update.
9485         * ada-valprint.c (ada_val_print): Update.
9486         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9487         (create_excep_cond_exprs): Update.
9488
9489 2019-04-08  Tom Tromey  <tom@tromey.com>
9490
9491         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9492         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9493         (TRY, CATCH, END_CATCH): Remove some definitions.
9494         * common/common-exceptions.c: Don't use GDB_XCPT.
9495         (catcher_list_size): Remove.
9496         (throw_exception, throw_it): Simplify.
9497
9498 2019-04-05  Tom Tromey  <tom@tromey.com>
9499
9500         Revert the header-sorting patch.
9501         * ft32-tdep.c: Revert.
9502         * frv-tdep.c: Revert.
9503         * frv-linux-tdep.c: Revert.
9504         * frame.c: Revert.
9505         * frame-unwind.c: Revert.
9506         * frame-base.c: Revert.
9507         * fork-child.c: Revert.
9508         * findvar.c: Revert.
9509         * findcmd.c: Revert.
9510         * filesystem.c: Revert.
9511         * filename-seen-cache.h: Revert.
9512         * filename-seen-cache.c: Revert.
9513         * fbsd-tdep.c: Revert.
9514         * fbsd-nat.h: Revert.
9515         * fbsd-nat.c: Revert.
9516         * f-valprint.c: Revert.
9517         * f-typeprint.c: Revert.
9518         * f-lang.c: Revert.
9519         * extension.h: Revert.
9520         * extension.c: Revert.
9521         * extension-priv.h: Revert.
9522         * expprint.c: Revert.
9523         * exec.h: Revert.
9524         * exec.c: Revert.
9525         * exceptions.c: Revert.
9526         * event-top.c: Revert.
9527         * event-loop.c: Revert.
9528         * eval.c: Revert.
9529         * elfread.c: Revert.
9530         * dwarf2read.h: Revert.
9531         * dwarf2read.c: Revert.
9532         * dwarf2loc.c: Revert.
9533         * dwarf2expr.h: Revert.
9534         * dwarf2expr.c: Revert.
9535         * dwarf2-frame.c: Revert.
9536         * dwarf2-frame-tailcall.c: Revert.
9537         * dwarf-index-write.h: Revert.
9538         * dwarf-index-write.c: Revert.
9539         * dwarf-index-common.c: Revert.
9540         * dwarf-index-cache.h: Revert.
9541         * dwarf-index-cache.c: Revert.
9542         * dummy-frame.c: Revert.
9543         * dtrace-probe.c: Revert.
9544         * disasm.h: Revert.
9545         * disasm.c: Revert.
9546         * disasm-selftests.c: Revert.
9547         * dictionary.c: Revert.
9548         * dicos-tdep.c: Revert.
9549         * demangle.c: Revert.
9550         * dcache.h: Revert.
9551         * dcache.c: Revert.
9552         * darwin-nat.h: Revert.
9553         * darwin-nat.c: Revert.
9554         * darwin-nat-info.c: Revert.
9555         * d-valprint.c: Revert.
9556         * d-namespace.c: Revert.
9557         * d-lang.c: Revert.
9558         * ctf.c: Revert.
9559         * csky-tdep.c: Revert.
9560         * csky-linux-tdep.c: Revert.
9561         * cris-tdep.c: Revert.
9562         * cris-linux-tdep.c: Revert.
9563         * cp-valprint.c: Revert.
9564         * cp-support.c: Revert.
9565         * cp-namespace.c: Revert.
9566         * cp-abi.c: Revert.
9567         * corelow.c: Revert.
9568         * corefile.c: Revert.
9569         * continuations.c: Revert.
9570         * completer.h: Revert.
9571         * completer.c: Revert.
9572         * complaints.c: Revert.
9573         * coffread.c: Revert.
9574         * coff-pe-read.c: Revert.
9575         * cli-out.h: Revert.
9576         * cli-out.c: Revert.
9577         * charset.c: Revert.
9578         * c-varobj.c: Revert.
9579         * c-valprint.c: Revert.
9580         * c-typeprint.c: Revert.
9581         * c-lang.c: Revert.
9582         * buildsym.c: Revert.
9583         * buildsym-legacy.c: Revert.
9584         * build-id.h: Revert.
9585         * build-id.c: Revert.
9586         * btrace.c: Revert.
9587         * bsd-uthread.c: Revert.
9588         * breakpoint.h: Revert.
9589         * breakpoint.c: Revert.
9590         * break-catch-throw.c: Revert.
9591         * break-catch-syscall.c: Revert.
9592         * break-catch-sig.c: Revert.
9593         * blockframe.c: Revert.
9594         * block.c: Revert.
9595         * bfin-tdep.c: Revert.
9596         * bfin-linux-tdep.c: Revert.
9597         * bfd-target.c: Revert.
9598         * bcache.c: Revert.
9599         * ax-general.c: Revert.
9600         * ax-gdb.h: Revert.
9601         * ax-gdb.c: Revert.
9602         * avr-tdep.c: Revert.
9603         * auxv.c: Revert.
9604         * auto-load.c: Revert.
9605         * arm-wince-tdep.c: Revert.
9606         * arm-tdep.c: Revert.
9607         * arm-symbian-tdep.c: Revert.
9608         * arm-pikeos-tdep.c: Revert.
9609         * arm-obsd-tdep.c: Revert.
9610         * arm-nbsd-tdep.c: Revert.
9611         * arm-nbsd-nat.c: Revert.
9612         * arm-linux-tdep.c: Revert.
9613         * arm-linux-nat.c: Revert.
9614         * arm-fbsd-tdep.c: Revert.
9615         * arm-fbsd-nat.c: Revert.
9616         * arm-bsd-tdep.c: Revert.
9617         * arch-utils.c: Revert.
9618         * arc-tdep.c: Revert.
9619         * arc-newlib-tdep.c: Revert.
9620         * annotate.h: Revert.
9621         * annotate.c: Revert.
9622         * amd64-windows-tdep.c: Revert.
9623         * amd64-windows-nat.c: Revert.
9624         * amd64-tdep.c: Revert.
9625         * amd64-sol2-tdep.c: Revert.
9626         * amd64-obsd-tdep.c: Revert.
9627         * amd64-obsd-nat.c: Revert.
9628         * amd64-nbsd-tdep.c: Revert.
9629         * amd64-nbsd-nat.c: Revert.
9630         * amd64-nat.c: Revert.
9631         * amd64-linux-tdep.c: Revert.
9632         * amd64-linux-nat.c: Revert.
9633         * amd64-fbsd-tdep.c: Revert.
9634         * amd64-fbsd-nat.c: Revert.
9635         * amd64-dicos-tdep.c: Revert.
9636         * amd64-darwin-tdep.c: Revert.
9637         * amd64-bsd-nat.c: Revert.
9638         * alpha-tdep.c: Revert.
9639         * alpha-obsd-tdep.c: Revert.
9640         * alpha-nbsd-tdep.c: Revert.
9641         * alpha-mdebug-tdep.c: Revert.
9642         * alpha-linux-tdep.c: Revert.
9643         * alpha-linux-nat.c: Revert.
9644         * alpha-bsd-tdep.c: Revert.
9645         * alpha-bsd-nat.c: Revert.
9646         * aix-thread.c: Revert.
9647         * agent.c: Revert.
9648         * addrmap.c: Revert.
9649         * ada-varobj.c: Revert.
9650         * ada-valprint.c: Revert.
9651         * ada-typeprint.c: Revert.
9652         * ada-tasks.c: Revert.
9653         * ada-lang.c: Revert.
9654         * aarch64-tdep.c: Revert.
9655         * aarch64-ravenscar-thread.c: Revert.
9656         * aarch64-newlib-tdep.c: Revert.
9657         * aarch64-linux-tdep.c: Revert.
9658         * aarch64-linux-nat.c: Revert.
9659         * aarch64-fbsd-tdep.c: Revert.
9660         * aarch64-fbsd-nat.c: Revert.
9661         * aarch32-linux-nat.c: Revert.
9662
9663 2019-04-05  Tom Tromey  <tom@tromey.com>
9664
9665         * ft32-tdep.c: Sort headers.
9666         * frv-tdep.c: Sort headers.
9667         * frv-linux-tdep.c: Sort headers.
9668         * frame.c: Sort headers.
9669         * frame-unwind.c: Sort headers.
9670         * frame-base.c: Sort headers.
9671         * fork-child.c: Sort headers.
9672         * findvar.c: Sort headers.
9673         * findcmd.c: Sort headers.
9674         * filesystem.c: Sort headers.
9675         * filename-seen-cache.h: Sort headers.
9676         * filename-seen-cache.c: Sort headers.
9677         * fbsd-tdep.c: Sort headers.
9678         * fbsd-nat.h: Sort headers.
9679         * fbsd-nat.c: Sort headers.
9680         * f-valprint.c: Sort headers.
9681         * f-typeprint.c: Sort headers.
9682         * f-lang.c: Sort headers.
9683         * extension.h: Sort headers.
9684         * extension.c: Sort headers.
9685         * extension-priv.h: Sort headers.
9686         * expprint.c: Sort headers.
9687         * exec.h: Sort headers.
9688         * exec.c: Sort headers.
9689         * exceptions.c: Sort headers.
9690         * event-top.c: Sort headers.
9691         * event-loop.c: Sort headers.
9692         * eval.c: Sort headers.
9693         * elfread.c: Sort headers.
9694         * dwarf2read.h: Sort headers.
9695         * dwarf2read.c: Sort headers.
9696         * dwarf2loc.c: Sort headers.
9697         * dwarf2expr.h: Sort headers.
9698         * dwarf2expr.c: Sort headers.
9699         * dwarf2-frame.c: Sort headers.
9700         * dwarf2-frame-tailcall.c: Sort headers.
9701         * dwarf-index-write.h: Sort headers.
9702         * dwarf-index-write.c: Sort headers.
9703         * dwarf-index-common.c: Sort headers.
9704         * dwarf-index-cache.h: Sort headers.
9705         * dwarf-index-cache.c: Sort headers.
9706         * dummy-frame.c: Sort headers.
9707         * dtrace-probe.c: Sort headers.
9708         * disasm.h: Sort headers.
9709         * disasm.c: Sort headers.
9710         * disasm-selftests.c: Sort headers.
9711         * dictionary.c: Sort headers.
9712         * dicos-tdep.c: Sort headers.
9713         * demangle.c: Sort headers.
9714         * dcache.h: Sort headers.
9715         * dcache.c: Sort headers.
9716         * darwin-nat.h: Sort headers.
9717         * darwin-nat.c: Sort headers.
9718         * darwin-nat-info.c: Sort headers.
9719         * d-valprint.c: Sort headers.
9720         * d-namespace.c: Sort headers.
9721         * d-lang.c: Sort headers.
9722         * ctf.c: Sort headers.
9723         * csky-tdep.c: Sort headers.
9724         * csky-linux-tdep.c: Sort headers.
9725         * cris-tdep.c: Sort headers.
9726         * cris-linux-tdep.c: Sort headers.
9727         * cp-valprint.c: Sort headers.
9728         * cp-support.c: Sort headers.
9729         * cp-namespace.c: Sort headers.
9730         * cp-abi.c: Sort headers.
9731         * corelow.c: Sort headers.
9732         * corefile.c: Sort headers.
9733         * continuations.c: Sort headers.
9734         * completer.h: Sort headers.
9735         * completer.c: Sort headers.
9736         * complaints.c: Sort headers.
9737         * coffread.c: Sort headers.
9738         * coff-pe-read.c: Sort headers.
9739         * cli-out.h: Sort headers.
9740         * cli-out.c: Sort headers.
9741         * charset.c: Sort headers.
9742         * c-varobj.c: Sort headers.
9743         * c-valprint.c: Sort headers.
9744         * c-typeprint.c: Sort headers.
9745         * c-lang.c: Sort headers.
9746         * buildsym.c: Sort headers.
9747         * buildsym-legacy.c: Sort headers.
9748         * build-id.h: Sort headers.
9749         * build-id.c: Sort headers.
9750         * btrace.c: Sort headers.
9751         * bsd-uthread.c: Sort headers.
9752         * breakpoint.h: Sort headers.
9753         * breakpoint.c: Sort headers.
9754         * break-catch-throw.c: Sort headers.
9755         * break-catch-syscall.c: Sort headers.
9756         * break-catch-sig.c: Sort headers.
9757         * blockframe.c: Sort headers.
9758         * block.c: Sort headers.
9759         * bfin-tdep.c: Sort headers.
9760         * bfin-linux-tdep.c: Sort headers.
9761         * bfd-target.c: Sort headers.
9762         * bcache.c: Sort headers.
9763         * ax-general.c: Sort headers.
9764         * ax-gdb.h: Sort headers.
9765         * ax-gdb.c: Sort headers.
9766         * avr-tdep.c: Sort headers.
9767         * auxv.c: Sort headers.
9768         * auto-load.c: Sort headers.
9769         * arm-wince-tdep.c: Sort headers.
9770         * arm-tdep.c: Sort headers.
9771         * arm-symbian-tdep.c: Sort headers.
9772         * arm-pikeos-tdep.c: Sort headers.
9773         * arm-obsd-tdep.c: Sort headers.
9774         * arm-nbsd-tdep.c: Sort headers.
9775         * arm-nbsd-nat.c: Sort headers.
9776         * arm-linux-tdep.c: Sort headers.
9777         * arm-linux-nat.c: Sort headers.
9778         * arm-fbsd-tdep.c: Sort headers.
9779         * arm-fbsd-nat.c: Sort headers.
9780         * arm-bsd-tdep.c: Sort headers.
9781         * arch-utils.c: Sort headers.
9782         * arc-tdep.c: Sort headers.
9783         * arc-newlib-tdep.c: Sort headers.
9784         * annotate.h: Sort headers.
9785         * annotate.c: Sort headers.
9786         * amd64-windows-tdep.c: Sort headers.
9787         * amd64-windows-nat.c: Sort headers.
9788         * amd64-tdep.c: Sort headers.
9789         * amd64-sol2-tdep.c: Sort headers.
9790         * amd64-obsd-tdep.c: Sort headers.
9791         * amd64-obsd-nat.c: Sort headers.
9792         * amd64-nbsd-tdep.c: Sort headers.
9793         * amd64-nbsd-nat.c: Sort headers.
9794         * amd64-nat.c: Sort headers.
9795         * amd64-linux-tdep.c: Sort headers.
9796         * amd64-linux-nat.c: Sort headers.
9797         * amd64-fbsd-tdep.c: Sort headers.
9798         * amd64-fbsd-nat.c: Sort headers.
9799         * amd64-dicos-tdep.c: Sort headers.
9800         * amd64-darwin-tdep.c: Sort headers.
9801         * amd64-bsd-nat.c: Sort headers.
9802         * alpha-tdep.c: Sort headers.
9803         * alpha-obsd-tdep.c: Sort headers.
9804         * alpha-nbsd-tdep.c: Sort headers.
9805         * alpha-mdebug-tdep.c: Sort headers.
9806         * alpha-linux-tdep.c: Sort headers.
9807         * alpha-linux-nat.c: Sort headers.
9808         * alpha-bsd-tdep.c: Sort headers.
9809         * alpha-bsd-nat.c: Sort headers.
9810         * aix-thread.c: Sort headers.
9811         * agent.c: Sort headers.
9812         * addrmap.c: Sort headers.
9813         * ada-varobj.c: Sort headers.
9814         * ada-valprint.c: Sort headers.
9815         * ada-typeprint.c: Sort headers.
9816         * ada-tasks.c: Sort headers.
9817         * ada-lang.c: Sort headers.
9818         * aarch64-tdep.c: Sort headers.
9819         * aarch64-ravenscar-thread.c: Sort headers.
9820         * aarch64-newlib-tdep.c: Sort headers.
9821         * aarch64-linux-tdep.c: Sort headers.
9822         * aarch64-linux-nat.c: Sort headers.
9823         * aarch64-fbsd-tdep.c: Sort headers.
9824         * aarch64-fbsd-nat.c: Sort headers.
9825         * aarch32-linux-nat.c: Sort headers.
9826
9827 2019-04-04  Tom Tromey  <tom@tromey.com>
9828
9829         * varobj.c (varobj_create): Update.
9830         * rust-exp.y (struct rust_parser) <update_innermost_block,
9831         lookup_symbol>: New methods.
9832         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9833         Rename.
9834         (rust_parser::rust_lookup_type)
9835         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9836         * printcmd.c (display_command, do_one_display): Update.
9837         * parser-defs.h (struct parser_state) <parser_state>: Add
9838         "tracker" parameter.
9839         (block_tracker): New member.
9840         (class innermost_block_tracker) <innermost_block_tracker>: Add
9841         "types" parameter.
9842         <reset>: Remove method.
9843         (innermost_block): Don't declare.
9844         (null_post_parser): Update.
9845         * parse.c (innermost_block): Remove global.
9846         (write_dollar_variable): Update.
9847         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9848         Remove "tracker_types" parameter.
9849         (parse_expression): Add "tracker" parameter.
9850         (parse_expression_for_completion): Update.
9851         (null_post_parser): Add "tracker" parameter.
9852         * p-exp.y: Update rules.
9853         * m2-exp.y: Update rules.
9854         * language.h (struct language_defn) <la_post_parser>: Add
9855         "tracker" parameter.
9856         * go-exp.y: Update rules.
9857         * f-exp.y: Update rules.
9858         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9859         parameter.
9860         * d-exp.y: Update rules.
9861         * c-exp.y: Update rules.
9862         * breakpoint.c (set_breakpoint_condition): Create an
9863         innermost_block_tracker.
9864         (watch_command_1): Likewise.
9865         * ada-lang.c (resolve): Add "tracker" parameter.
9866         (resolve_subexp): Likewise.
9867         * ada-exp.y (write_var_from_sym): Update.
9868
9869 2019-04-04  Tom Tromey  <tom@tromey.com>
9870
9871         * type-stack.h: New file.
9872         * type-stack.c: New file.
9873         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9874         type-stack.h.
9875         (insert_into_type_stack, insert_type, push_type, push_type_int)
9876         (insert_type_address_space, pop_type, pop_type_int)
9877         (pop_typelist, pop_type_stack, append_type_stack)
9878         (push_type_stack, get_type_stack, push_typelist)
9879         (follow_type_instance_flags, follow_types): Don't declare.
9880         * parse.c (type_stack): Remove global.
9881         (parse_exp_in_context): Update.
9882         (insert_into_type_stack, insert_type, push_type, push_type_int)
9883         (insert_type_address_space, pop_type, pop_type_int)
9884         (pop_typelist, pop_type_stack, append_type_stack)
9885         (push_type_stack, get_type_stack, push_typelist)
9886         (follow_type_instance_flags, follow_types): Remove (moved to
9887         type-stack.c).
9888         * f-exp.y (type_stack): New global.
9889         Update rules.
9890         (push_kind_type, f_parse): Update.
9891         * d-exp.y (type_stack): New global.
9892         Update rules.
9893         (d_parse): Update.
9894         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9895         Update rules.
9896         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9897         (HFILES_NO_SRCDIR): Add type-stack.h.
9898
9899 2019-04-04  Tom Tromey  <tom@tromey.com>
9900
9901         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9902         (rust_parser::convert_ast_to_expression, rust_parse)
9903         (rust_lex_test_completion, rust_lex_tests): Update.
9904         * parser-defs.h (struct expr_completion_state): New.
9905         (struct parser_state) <parser_state>: Add completion parameter.
9906         <mark_struct_expression, mark_completion_tag>: New methods.
9907         <parse_completion, m_completion_state>: New members.
9908         (prefixify_expression, null_post_parser): Update.
9909         (mark_struct_expression, mark_completion_tag): Don't declare.
9910         * parse.c (parse_completion, expout_last_struct)
9911         (expout_tag_completion_type, expout_completion_name): Remove
9912         globals.
9913         (parser_state::mark_struct_expression)
9914         (parser_state::mark_completion_tag): Now methods.
9915         (prefixify_expression): Add last_struct parameter.
9916         (prefixify_subexp): Likewise.
9917         (parse_exp_1): Update.
9918         (parse_exp_in_context): Add cstate parameter.  Update.
9919         (parse_expression_for_completion): Create an
9920         expr_completion_state.
9921         (null_post_parser): Add "completion" parameter.
9922         * p-exp.y: Update rules.
9923         (yylex): Update.
9924         * language.h (struct language_defn) <la_post_parser>: Add
9925         "completing" parameter.
9926         * go-exp.y: Update rules.
9927         (lex_one_token): Update.
9928         * expression.h (parse_completion): Don't declare.
9929         * d-exp.y: Update rules.
9930         (lex_one_token): Update rules.
9931         * c-exp.y: Update rules.
9932         (lex_one_token): Update.
9933         * ada-lang.c (resolve): Add "parse_completion" parameter.
9934         (resolve_subexp): Likewise.
9935         (ada_resolve_function): Likewise.
9936
9937 2019-04-04  Tom Tromey  <tom@tromey.com>
9938
9939         * parser-defs.h (struct parser_state) <start_arglist,
9940         end_arglist>: New methods.
9941         <arglist_len, m_funcall_chain>: New members.
9942         (arglist_len, start_arglist, end_arglist): Don't declare.
9943         * parse.c (arglist_len, funcall_chain): Remove global.
9944         (start_arglist, end_arglist): Remove functions.
9945         (parse_exp_in_context): Update.
9946         * p-exp.y: Update rules.
9947         * m2-exp.y: Update rules.
9948         * go-exp.y: Update rules.
9949         * f-exp.y: Update rules.
9950         * d-exp.y: Update rules.
9951         * c-exp.y: Update rules.
9952
9953 2019-04-04  Tom Tromey  <tom@tromey.com>
9954
9955         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9956         lex_operator, push_back>: New methods.
9957         Update all rules.
9958         (rust_parser::lex_hex, lex_escape): Rename and update.
9959         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9960         (rust_parser::lex_operator): Rename and update.
9961         (rust_parser::lex_number, rustyylex, rustyyerror)
9962         (rust_lex_test_init, rust_lex_test_sequence)
9963         (rust_lex_test_push_back, rust_lex_tests): Update.
9964         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9965         parameter.
9966         <lexptr, prev_lexptr>: New members.
9967         (lexptr, prev_lexptr): Don't declare.
9968         * parse.c (lexptr, prev_lexptr): Remove globals.
9969         (parse_exp_in_context): Update.
9970         * p-exp.y (yylex, yyerror): Update.
9971         * m2-exp.y (parse_number, yylex, yyerror): Update.
9972         * go-exp.y (lex_one_token, yyerror): Update.
9973         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9974         * d-exp.y (lex_one_token, yyerror): Update.
9975         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9976         (lex_one_token, yyerror): Update.
9977         * ada-lex.l (YY_INPUT): Update.
9978         (rewind_to_char): Update.
9979         * ada-exp.y (yyerror): Update.
9980
9981 2019-04-04  Tom Tromey  <tom@tromey.com>
9982
9983         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9984         * parser-defs.h (struct parser_state) <parser_state>: Add new
9985         parameter.
9986         <comma_terminates>: New member.
9987         (comma_terminates): Don't declare global.
9988         * parse.c (comma_terminates): Remove global.
9989         (parse_exp_in_context): Update.
9990         * p-exp.y (yylex): Update.
9991         * m2-exp.y (yylex): Update.
9992         * go-exp.y (lex_one_token): Update.
9993         * f-exp.y (yylex): Update.
9994         * d-exp.y (lex_one_token): Update.
9995         * c-exp.y (lex_one_token): Update.
9996         * ada-lex.l: Update.
9997
9998 2019-04-04  Tom Tromey  <tom@tromey.com>
9999
10000         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10001         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10002         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10003         * parser-defs.h (paren_depth): Don't declare.
10004         * parse.c (paren_depth): Remove global.
10005         (parse_exp_in_context): Update.
10006         * p-exp.y (paren_depth): New global.
10007         (pascal_parse): Initialize it.
10008         * m2-exp.y (paren_depth): New global.
10009         (m2_parse): Initialize it.
10010         * go-exp.y (paren_depth): New global.
10011         (go_parse): Initialize it.
10012         * f-exp.y (paren_depth): New global.
10013         (f_parse): Initialize it.
10014         * d-exp.y (paren_depth): New global.
10015         (d_parse): Initialize it.
10016         * c-exp.y (paren_depth): New global.
10017         (c_parse): Initialize it.
10018         * ada-lex.l (paren_depth): New global.
10019         (lexer_init): Initialize it.
10020
10021 2019-04-04  Tom Tromey  <tom@tromey.com>
10022
10023         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10024         (rust_parser::convert_ast_to_type)
10025         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10026         * parser-defs.h (struct parser_state) <parser_state>: Add
10027         parameters.  Initialize new members.
10028         <expression_context_block, expression_context_pc>: New members.
10029         * parse.c (expression_context_block, expression_context_pc):
10030         Remove globals.
10031         (parse_exp_in_context): Update.
10032         * p-exp.y: Update all rules.
10033         (yylex): Update.
10034         * m2-exp.y: Update all rules.
10035         (yylex): Update.
10036         * go-exp.y (yylex): Update.
10037         * f-exp.y (yylex): Update.
10038         * d-exp.y: Update all rules.
10039         (yylex): Update.
10040         * c-exp.y: Update all rules.
10041         (lex_one_token, classify_name, yylex, c_parse): Update.
10042         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10043
10044 2019-04-04  Tom Tromey  <tom@tromey.com>
10045
10046         * gdbarch.h, gdbarch.c: Rebuild.
10047         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10048         * stap-probe.h:
10049         (struct stap_parse_info): Replace "parser_state" with
10050         "expr_builder".
10051         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10052         (parser_state): New class.
10053         * parse.c (expr_builder): Rename.
10054         (expr_builder::release): Rename.
10055         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10056         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10057         (write_exp_elt_longcst, write_exp_elt_floatcst)
10058         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10059         (write_exp_string_vector, write_exp_bitstring)
10060         (write_exp_msymbol, mark_struct_expression)
10061         (write_dollar_variable)
10062         (insert_type_address_space, increase_expout_size): Replace
10063         "parser_state" with "expr_builder".
10064         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10065         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10066         "parser_state" with "expr_builder".
10067
10068 2019-04-04  Tom Tromey  <tom@tromey.com>
10069
10070         * rust-exp.y: Replace "parse_language" with method call.
10071         * p-exp.y:
10072         (yylex): Replace "parse_language" with method call.
10073         * m2-exp.y:
10074         (yylex): Replace "parse_language" with method call.
10075         * go-exp.y (classify_name): Replace "parse_language" with method
10076         call.
10077         * f-exp.y (yylex): Replace "parse_language" with method call.
10078         * d-exp.y (lex_one_token): Replace "parse_language" with method
10079         call.
10080         * c-exp.y:
10081         (lex_one_token, classify_name, yylex): Replace "parse_language"
10082         with method call.
10083         * ada-exp.y (find_primitive_type, type_char)
10084         (type_system_address): Replace "parse_language" with method call.
10085
10086 2019-04-04  Tom Tromey  <tom@tromey.com>
10087
10088         * rust-exp.y: Replace "parse_gdbarch" with method call.
10089         * parse.c (write_dollar_variable, insert_type_address_space):
10090         Replace "parse_gdbarch" with method call.
10091         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10092         call.
10093         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10094         call.
10095         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10096         "parse_gdbarch" with method call.
10097         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10098         with method call.
10099         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10100         "parse_gdbarch" with method call.
10101         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10102         "parse_gdbarch" with method call.
10103         * c-exp.y (parse_type, parse_number, classify_name): Replace
10104         "parse_gdbarch" with method call.
10105         * ada-lex.l: Replace "parse_gdbarch" with method call.
10106         * ada-exp.y (parse_type, find_primitive_type, type_char)
10107         (type_system_address): Replace "parse_gdbarch" with method call.
10108
10109 2019-04-04  Tom Tromey  <tom@tromey.com>
10110
10111         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10112         * stap-probe.c (stap_parse_argument): Update.
10113         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10114         initial_size parameter.
10115         * rust-exp.y (rust_lex_tests): Update.
10116         * parse.c (parser_state): Update.
10117         (parse_exp_in_context): Update.
10118         * parser-defs.h (struct parser_state) <parser_state>: Remove
10119         "initial_size" parameter.
10120
10121 2019-04-04  Tom Tromey  <tom@tromey.com>
10122
10123         * parser-defs.h (increase_expout_size): Don't declare.
10124         * parse.c (increase_expout_size): Now static.
10125
10126 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10127
10128         * gnu-nat.c (gnu_nat_target::wait): Fix
10129         target_waitstatus_to_string call.
10130
10131 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10132
10133         * eval.c (evaluate_subexp_standard): Handle internal functions
10134         during Fortran function call handling.
10135
10136 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10137
10138         * NEWS: Mention new internal functions.
10139         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10140         (read_base_type): Use dwarf2_init_complex_target_type.
10141         * value.c (creal_internal_fn): New function.
10142         (cimag_internal_fn): New function.
10143         (_initialize_values): Register new internal functions.
10144
10145 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10146
10147         * infrun.c (stop_all_threads): If debug_infrun, always
10148         trace the wait status after wait_one, using
10149         target_waitstatus_to_string and target_pid_to_str.
10150         (handle_inferior_event): Replace various trace of
10151         wait status kind by a single trace.
10152         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10153         wait status kind image by target_waitstatus_to_string.
10154         * target/waitstatus.c (target_waitstatus_to_string): Fix
10155         obsolete comment.
10156
10157 2019-04-01  Tom Tromey  <tromey@adacore.com>
10158
10159         PR symtab/23331:
10160         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10161
10162 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10163             Pedro Alves  <palves@redhat.com>
10164
10165         * top.c (quit_force): Call 'finalize_values'.
10166         * value.c (finalize_values): New function.
10167         * value.h (finalize_values): Declare.
10168
10169 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10170
10171         * NEWS: Announce $_gdb_major and $_gdb_minor.
10172
10173         * top.c (init_gdb_version_vars): New function.
10174         (gdb_init): Call init_gdb_version_vars.
10175
10176 2019-03-29  Tom Tromey  <tromey@adacore.com>
10177
10178         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10179         help text.  Remove dead code.
10180
10181 2019-03-29  Keith Seitz  <keiths@redhat.com>
10182
10183         From Siddhesh Poyarekar:
10184         * f-lang.h (f77_get_upperbound): Return LONGEST.
10185         (f77_get_lowerbound): Likewise.
10186         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10187         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10188         print them.
10189         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10190         plongest to format print it.
10191         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10192         (f77_get_upperbound): Likewise.
10193         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10194         LOWER_BOUND to LONGEST.
10195         (f77_create_arrayprint_offset_tbl): Likewise.
10196
10197 2019-03-29  Keith Seitz  <keiths@redhat.com>
10198
10199         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10200         %s/pulongest for TYPE_LENGTH instead of %d in format
10201         strings.
10202         * ada-typerint.c (ada_print_type): Likewise.
10203         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10204         * compile/compile-c-support.c (generate_register_struct): Likewise.
10205         * gdbtypes.c (recursive_dump_type): Likewise.
10206         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10207         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10208         instead of %d in format strings.
10209         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10210         to std::min to ULONGEST.
10211         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10212         instead of %d in format strings.
10213         * tracepoint.c (info_scope_command): Likewise.
10214         * typeprint.c (print_offset_data::update)
10215         (print_offset_data::finish): Likewise.
10216         * xtensa-tdep.c (xtensa_store_return_value)
10217         (xtensa_push_dummy_call): Likewise.
10218
10219 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10220
10221         * windows-nat.c (display_selector): Fixed format specifications
10222         for 64-bit Cygwin.
10223
10224 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10225
10226         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10227
10228 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10229
10230         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10231         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10232         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10233         (nios2_linux_init_abi): Install it.
10234
10235 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10236
10237         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10238
10239 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10240
10241         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10242
10243 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10244             Tom Tromey  <tromey@adacore.com>
10245
10246         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10247
10248 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10249
10250         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10251         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10252         method to compute the bounds of range types. Also print "[evaluated]"
10253         if the bounds' values come from a dynamic evaluation.
10254
10255 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10256
10257         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10258         whitespace when pretty printing is on.
10259
10260 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10261
10262         * ppc-linux-nat.c: Add include.
10263
10264 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10265
10266         * NEWS: Mention AArch64 Pointer Authentication.
10267
10268 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10269
10270         * arm-linux-nat.c: Add include.
10271
10272 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10273
10274         * source-cache.c (source_cache::get_source_lines): Re-read
10275         fullname after calling open_source_file.
10276
10277 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10278
10279         * NEWS: Mention TLS support for FreeBSD.
10280
10281 2019-03-25  Tom Tromey  <tromey@adacore.com>
10282
10283         * minsyms.c (BUNCH_SIZE): Update comment.
10284         (~minimal_symbol_reader): Remove old comment.
10285         (compact_minimal_symbols): Update comment.
10286         (minimal_symbol_reader::install): Remove old comment.  Update
10287         other comments.
10288
10289 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10290
10291         * s390-linux-nat.c: Add include.
10292
10293 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10294
10295         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10296         Call linux_get_hwcap.
10297         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10298         Likewise.
10299         (aarch64_linux_get_hwcap): Remove function.
10300         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10301         declaration.
10302         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10303         linux_get_hwcap.
10304         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10305         * linux-tdep.c (linux_get_hwcap): Add function.
10306         (linux_get_hwcap2): Likewise.
10307         * linux-tdep.h (linux_get_hwcap): Add declaration.
10308         (linux_get_hwcap2): Likewise.
10309         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10310         (ppc_linux_get_hwcap2): Likewise.
10311         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10312         linux_get_hwcap.
10313         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10314         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10315         (ppc_linux_nat_target::read_description): Likewise.
10316         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10317         * s390-linux-nat.c: Likewise.
10318         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10319
10320 2019-03-24  Tom Tromey  <tom@tromey.com>
10321
10322         * ada-lang.c (standard_lookup): Simplify initialization.
10323         (ada_lookup_symbol_nonlocal): Simplify return.
10324         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10325         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10326         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10327         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10328         initialization.
10329         * solib.c (solib_global_lookup): Simplify.
10330         * symtab.c (null_block_symbol): Remove.
10331         (symbol_cache_lookup): Simplify returns.
10332         (lookup_language_this): Simplify returns.
10333         (lookup_symbol_aux): Simplify return.
10334         (lookup_local_symbol): Simplify returns.
10335         (lookup_global_symbol_from_objfile): Simplify return.
10336         (lookup_symbol_in_objfile_symtabs)
10337         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10338         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10339         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10340         * cp-namespace.c (cp_lookup_bare_symbol)
10341         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10342         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10343         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10344         (cp_lookup_symbol_via_imports): Simplify initialization.
10345         (find_symbol_in_baseclass): Likewise.
10346         * symtab.h (null_block_symbol): Remove.
10347         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10348         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10349         (d_lookup_symbol_module): Likewise.
10350         (find_symbol_in_baseclass): Simplify initialization.
10351
10352 2019-03-24  Tom Tromey  <tom@tromey.com>
10353
10354         * expression.h: Don't include symtab.h.
10355         (struct block): Forward declare.
10356
10357 2019-03-24  Tom Tromey  <tom@tromey.com>
10358
10359         * c-exp.y (typebase): Remove casts.
10360         * gdbtypes.c (lookup_unsigned_typename, )
10361         (lookup_signed_typename): Remove cast.
10362         * eval.c (parse_to_comma_and_eval): Remove cast.
10363         * parse.c (write_dollar_variable): Remove cast.
10364         * block.h (struct block) <superblock>: Now const.
10365         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10366         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10367         (map_block): Make "block" const.
10368         * symfile.h (struct quick_symbol_functions)
10369         <map_matching_symbols>: Constify block argument to "callback".
10370         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10371         const.
10372         (find_pc_sect_compunit_symtab): Make "b" const.
10373         (find_symbol_at_address): Likewise.
10374         (search_symbols): Likewise.
10375         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10376         (dw2_debug_names_lookup_symbol): Likewise.
10377         (dw2_map_matching_symbols): Update.
10378         * p-valprint.c (pascal_val_print): Remove "block".
10379         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10380         (aux_add_nonlocal_symbols): Make "block" const.
10381         (resolve_subexp): Remove cast.
10382         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10383         const.
10384         (iterate_over_file_blocks): Likewise.
10385         * f-exp.y (%union) <bval>: Remove.
10386         * coffread.c (patch_opaque_types): Make "b" const.
10387         * spu-tdep.c (spu_catch_start): Make "block" const.
10388         * c-valprint.c (print_unpacked_pointer): Remove "block".
10389         * symmisc.c (dump_symtab_1): Make "b" const.
10390         (block_depth): Make "block" const.
10391         * d-exp.y (%union) <bval>: Remove.
10392         * cp-support.h (cp_lookup_rtti_type): Update.
10393         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10394         * psymtab.c (psym_lookup_symbol): Make "block" const.
10395         (maintenance_check_psymtabs): Make "b" const.
10396         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10397         (enumerate_locals, enumerate_args): Update.
10398         * python/py-symtab.c (stpy_global_block): Make "block" const.
10399         (stpy_static_block): Likewise.
10400         * inline-frame.c (block_starting_point_at): Make "new_block"
10401         const.
10402         * block.c (find_block_in_blockvector): Make return type const.
10403         (blockvector_for_pc_sect): Make "b" const.
10404         (find_block_in_blockvector): Make "b" const.
10405
10406 2019-03-23  Tom Tromey  <tom@tromey.com>
10407
10408         * varobj.c (varobj_create): Update.
10409         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10410         * printcmd.c (display_command, do_one_display): Don't reset
10411         innermost_block.
10412         * parser-defs.h (enum innermost_block_tracker_type): Move to
10413         expression.h.
10414         (innermost_block): Update comment.
10415         * parse.c (parse_exp_1): Add tracker_types parameter.
10416         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10417         tracker_types parameter.  Reset innermost_block.
10418         (parse_exp_in_context): Remove.
10419         (parse_expression_for_completion): Update.
10420         * objfiles.c (~objfile): Don't reset expression_context_block or
10421         innermost_block.
10422         * expression.h (enum innermost_block_tracker_type): Move from
10423         parser-defs.h.
10424         (parse_exp_1): Add tracker_types parameter.
10425         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10426         reset innermost_block.
10427
10428 2019-03-23  Tom Tromey  <tom@tromey.com>
10429
10430         * objfiles.h: Include bcache.h.
10431
10432 2019-03-23  Tom Tromey  <tom@tromey.com>
10433
10434         * linespec.c (get_current_search_block): Use
10435         scoped_restore_current_language.
10436         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10437
10438 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10439             Jiong Wang  <jiong.wang@arm.com>
10440
10441         * aarch64-linux-tdep.c
10442         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10443         section.
10444         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10445
10446 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10447             Jiong Wang  <jiong.wang@arm.com>
10448
10449         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10450         instructions.
10451         (aarch64_analyze_prologue_test): Add PACIASP test.
10452         (aarch64_prologue_prev_register): Unmask PC value.
10453
10454 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10455             Jiong Wang  <jiong.wang@arm.com>
10456
10457         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10458         (aarch64_dwarf2_prev_register): Unmask PC value.
10459         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10460         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10461         DW_CFA_AARCH64_negate_ra_state.
10462         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10463
10464 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10465             Jiong Wang  <jiong.wang@arm.com>
10466
10467         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10468         registers.
10469         (aarch64_pseudo_register_name): Likewise.
10470         (aarch64_pseudo_register_type): Likewise.
10471         (aarch64_pseudo_register_reggroup_p): Likewise.
10472         (aarch64_gdbarch_init): Add pauth registers.
10473         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10474         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10475         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10476         (struct gdbarch_tdep): Add regnum for ra_state.
10477
10478 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10479             Jiong Wang  <jiong.wang@arm.com>
10480
10481         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10482
10483 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10484             Jiong Wang  <jiong.wang@arm.com>
10485
10486         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10487         function.
10488         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10489         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10490         (aarch64_gdbarch_init): Add puth registers.
10491         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10492         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10493         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10494
10495 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10496             Jiong Wang  <jiong.wang@arm.com>
10497
10498         * aarch64-linux-nat.c
10499         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10500         * aarch64-linux-tdep.c
10501         (aarch64_linux_core_read_description): Likewise.
10502         (aarch64_linux_get_hwcap): New function.
10503         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10504         (aarch64_linux_get_hwcap): New declaration.
10505
10506 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10507             Jiong Wang  <jiong.wang@arm.com>
10508
10509         * aarch64-linux-nat.c
10510         (aarch64_linux_nat_target::read_description): Add pauth param.
10511         * aarch64-linux-tdep.c
10512         (aarch64_linux_core_read_description): Likewise.
10513         * aarch64-tdep.c (struct target_desc): Add in pauth.
10514         (aarch64_read_description): Add pauth param.
10515         (aarch64_gdbarch_init): Likewise.
10516         * aarch64-tdep.h (aarch64_read_description): Likewise.
10517         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10518         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10519         * features/Makefile: Add new files.
10520         * features/aarch64-pauth.c: New file.
10521         * features/aarch64-pauth.xml: New file.
10522
10523 2019-03-20  Tom Tromey  <tromey@adacore.com>
10524
10525         * infrun.c (handle_inferior_event): Rename from
10526         handle_inferior_event_1.  Create a scoped_value_mark.
10527         (handle_inferior_event): Remove.
10528
10529 2019-03-19  Tom Tromey  <tromey@adacore.com>
10530
10531         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10532         * infrun.h (print_stop_event): Add "displays" parameter.
10533         * infrun.c (print_stop_event): Add "displays" parameter.
10534
10535 2019-03-19  Pedro Alves  <palves@redhat.com>
10536
10537         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10538         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10539         to -1.  Fix TABs vs spaces.
10540         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10541         * tui/tui-out.h (tui_ui_out) Add intro comments.
10542         <m_line, m_start_of_line>: In-class initialize, and add describing
10543         comment.
10544
10545 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10546
10547         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10548         variable names.
10549         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10550
10551 2019-03-18  Pedro Alves  <palves@redhat.com>
10552             Eli Zaretskii <eliz@gnu.org>
10553
10554         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10555         m_line and m_start_of_line.
10556
10557 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10558
10559         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10560         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10561         it returns a newline.  This fixes a regression in TU mode, whereby
10562         the next line is output on the same screen line as the user input.
10563
10564 2019-03-18  Tom Tromey  <tromey@adacore.com>
10565
10566         * minsyms.c (minimal_symbol_reader::install): Remove call to
10567         obstack_blank.
10568
10569 2019-03-18  Pedro Alves  <palves@redhat.com>
10570
10571         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10572         New globals.
10573         (apply_style): New, factored out from ...
10574         (apply_ansi_escape): ... this.  Handle reverse video mode.
10575         (tui_set_reverse_mode): New function.
10576         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10577         * tui/tui-winsource.c (tui_show_source_line): Use
10578         tui_set_reverse_mode instead of setting A_STANDOUT.
10579         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10580         New setter methods.
10581
10582 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10583
10584         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10585         Handle tabs.
10586
10587 2019-03-18  Tom Tromey  <tromey@adacore.com>
10588
10589         * ada-lang.c (empty_array): Add "high" parameter.
10590         (ada_evaluate_subexp): Update.
10591
10592 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10593
10594         * unittests/string_view-selftests.c: Define
10595         _initialize_string_view_selftests unconditionally.
10596
10597 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10598
10599         PR gdb/24350
10600         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10601
10602 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10603
10604         PR gdb/24351
10605         * windows-nat.c (display_selector): Fix format specifiers.
10606
10607 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10608
10609         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10610         tui_refill_source_window instead of tui_refresh_win, to update the
10611         current execution line.  This fixes redisplay of the current line
10612         when stepping through the code with "next" or "step".
10613
10614 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10615
10616         * source-cache.c (source_cache::get_source_lines): Call
10617         find_source_lines to initialize s->nlines.  This fixes vertical
10618         scrolling of TUI source window when the DOWN arrow is pressed.
10619
10620 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10621
10622         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10623         linux-thread-db.c (_initialize_thread_db): Likewise.
10624
10625 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10626
10627         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10628         wclrtoeol in tui_show_source_line".  This reverts changes made in
10629         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10630
10631 2019-03-15  Tom Tromey  <tom@tromey.com>
10632
10633         * symtab.h (struct minimal_symbol): Derive from
10634         general_symbol_info.
10635         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10636         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10637         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10638         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10639         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10640         (MSYMBOL_SEARCH_NAME): Update.
10641         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10642         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10643         * minsyms.c (minimal_symbol_reader::record_full): Update.
10644
10645 2019-03-15  Tom Tromey  <tom@tromey.com>
10646
10647         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10648
10649 2019-03-15  Tom Tromey  <tom@tromey.com>
10650
10651         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10652         unique_xmalloc_ptr.
10653         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10654         Update.
10655         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10656         (build_minimal_symbol_hash_tables)
10657         (minimal_symbol_reader::install): Update.
10658
10659 2019-03-15  Tom Tromey  <tom@tromey.com>
10660
10661         * symtab.c (create_demangled_names_hash): Update.
10662         (symbol_set_names): Update.
10663         * objfiles.h (struct objfile_per_bfd_storage)
10664         <demangled_names_hash>: Now an htab_up.
10665         * objfiles.c (objfile_per_bfd_storage): Simplify.
10666
10667 2019-03-15  Tom Tromey  <tom@tromey.com>
10668
10669         * objfiles.h (struct objfile_per_bfd_storage): Declare
10670         destructor.
10671         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10672         New.
10673         (get_objfile_bfd_data): Use new.  Don't initialize
10674         language_of_main.
10675         (free_objfile_per_bfd_storage): Remove.
10676         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10677
10678 2019-03-15  Tom Tromey  <tom@tromey.com>
10679
10680         * symfile.c (reread_symbols): Update.
10681         * objfiles.c (objfile::objfile): Update.
10682         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10683         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10684         comment.
10685         (minimal_symbol_reader::install): Update.
10686         (terminate_minimal_symbol_table): Remove.
10687         * jit.c (jit_object_close_impl): Update.
10688
10689 2019-03-15  Tom Tromey  <tom@tromey.com>
10690
10691         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10692         initializations.
10693
10694 2019-03-15  Tom Tromey  <tom@tromey.com>
10695
10696         * objfiles.h (struct objfile_per_bfd_storage)
10697         <demangled_hash_languages>: Now a bitset.
10698         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10699         (lookup_minimal_symbol): Update.
10700
10701 2019-03-15  Tom Tromey  <tom@tromey.com>
10702
10703         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10704         Don't return the symbol.
10705         * coffread.c (record_minimal_symbol): Use record_full.
10706
10707 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10708
10709         The MS-Windows port of ncurses fails to switch to a color pair if
10710         one or both of the colors are the implicit default colors.  This
10711         change records the default colors when TUI is initialized, and
10712         then specifies them explicitly when a color pair uses the default
10713         colors.  This allows color styling in TUI mode on MS-Windows.
10714
10715         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10716         ncurses_norm_attr.
10717         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10718         colors in ncurses_norm_attr.
10719         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10720         "none", replace it with the default color recorded in
10721         ncurses_norm_attr.
10722
10723 2019-03-14  Tom Tromey  <tromey@adacore.com>
10724
10725         * source-cache.h (class source_cache) <get_source_lines>: Return
10726         std::string.
10727         * source-cache.c (source_cache::extract_lines): Handle case where
10728         first_pos==npos.  Return std::string.
10729         (source_cache::get_source_lines): Update.
10730
10731 2019-03-14  Tom Tromey  <tromey@adacore.com>
10732
10733         * NEWS: Add item for "style sources" commands.
10734         * source-cache.c (source_cache::get_source_lines): Check
10735         source_styling.
10736         * cli/cli-style.c (source_styling): New global.
10737         (_initialize_cli_style): Add "style sources" commands.
10738         (show_style_sources): New function.
10739         * cli/cli-style.h (source_styling): Declare.
10740
10741 2019-03-14  Pedro Alves  <palves@redhat.com>
10742             Tom Tromey  <tromey@adacore.com>
10743
10744         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10745         * tui/tui-winsource.c (tui_refill_source_window): New function,
10746         from...
10747         (tui_horizontal_source_scroll): ... here.  Move some logic.
10748         * cli/cli-style.c (set_style_enabled): Notify new observable.
10749         * tui/tui-hooks.c (tui_redisplay_source): New function.
10750         (tui_attach_detach_observers): Attach or detach
10751         tui_redisplay_source.
10752         * observable.h (source_styling_changed): New observable.
10753         * observable.c: Define source_styling_changed observable.
10754
10755 2019-03-13  Tom Tromey  <tromey@adacore.com>
10756
10757         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10758         (i386_gnu_nat_target::store_registers): Update.
10759         * target-debug.h (target_debug_print_std_string): New macro.
10760         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10761         * windows-tdep.c (display_one_tib): Update.
10762         * tui/tui-stack.c (tui_make_status_line): Update.
10763         * top.c (print_inferior_quit_action): Update.
10764         * thread.c (thr_try_catch_cmd): Update.
10765         (add_thread_with_info): Update.
10766         (thread_target_id_str): Update.
10767         (thr_try_catch_cmd): Update.
10768         (thread_command): Update.
10769         (thread_find_command): Update.
10770         * record-btrace.c (record_btrace_target::info_record)
10771         (record_btrace_resume_thread, record_btrace_target::resume)
10772         (record_btrace_cancel_resume, record_btrace_step_thread)
10773         (record_btrace_target::wait, record_btrace_target::wait)
10774         (record_btrace_target::wait, record_btrace_target::stop): Update.
10775         * progspace.c (print_program_space): Update.
10776         * process-stratum-target.c
10777         (process_stratum_target::thread_address_space): Update.
10778         * linux-fork.c (linux_fork_mourn_inferior)
10779         (detach_checkpoint_command, info_checkpoints_command)
10780         (linux_fork_context): Update.
10781         (linux_fork_detach): Update.
10782         (class scoped_switch_fork_info): Update.
10783         (delete_checkpoint_command): Update.
10784         * infrun.c (follow_fork_inferior): Update.
10785         (follow_fork_inferior): Update.
10786         (proceed_after_vfork_done): Update.
10787         (handle_vfork_child_exec_or_exit): Update.
10788         (follow_exec): Update.
10789         (displaced_step_prepare_throw): Update.
10790         (displaced_step_restore): Update.
10791         (start_step_over): Update.
10792         (resume_1): Update.
10793         (clear_proceed_status_thread): Update.
10794         (proceed): Update.
10795         (print_target_wait_results): Update.
10796         (do_target_wait): Update.
10797         (context_switch): Update.
10798         (stop_all_threads): Update.
10799         (restart_threads): Update.
10800         (finish_step_over): Update.
10801         (handle_signal_stop): Update.
10802         (switch_back_to_stepped_thread): Update.
10803         (keep_going_pass_signal): Update.
10804         (print_exited_reason): Update.
10805         (normal_stop): Update.
10806         * inferior.c (inferior_pid_to_str): Change return type.
10807         (print_selected_inferior): Update.
10808         (add_inferior): Update.
10809         (detach_inferior): Update.
10810         * dummy-frame.c (fprint_dummy_frames): Update.
10811         * dcache.c (dcache_info_1): Update.
10812         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10813         (btrace_fetch, btrace_clear): Update.
10814         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10815         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10816         type.
10817         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10818         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10819         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10820         * gdbarch.c, gdbarch.h: Rebuild.
10821         * gdbarch.sh (core_pid_to_str): Change return type.
10822         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10823         return type.
10824         (windows_nat_target::pid_to_str): Change return type.
10825         (windows_delete_thread): Update.
10826         (windows_nat_target::attach): Update.
10827         (windows_nat_target::files_info): Update.
10828         * target-delegates.c: Rebuild.
10829         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10830         return type.
10831         (sol_thread_target::pid_to_str): Change return type.
10832         * remote.c (class remote_target) <pid_to_str>: Change return
10833         type.
10834         (remote_target::pid_to_str): Change return type.
10835         (extended_remote_target::attach, remote_target::remote_stop_ns)
10836         (remote_target::remote_notif_remove_queued_reply)
10837         (remote_target::push_stop_reply, remote_target::disable_btrace):
10838         Update.
10839         (extended_remote_target::attach): Update.
10840         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10841         type.
10842         (gdbsim_target::pid_to_str): Change return type.
10843         * ravenscar-thread.c (struct ravenscar_thread_target)
10844         <pid_to_str>: Change return type.
10845         (ravenscar_thread_target::pid_to_str): Change return type.
10846         * procfs.c (class procfs_target) <pid_to_str>: Change return
10847         type.
10848         (procfs_target::pid_to_str): Change return type.
10849         (procfs_target::attach): Update.
10850         (procfs_target::detach): Update.
10851         (procfs_target::fetch_registers): Update.
10852         (procfs_target::store_registers): Update.
10853         (procfs_target::wait): Update.
10854         (procfs_target::files_info): Update.
10855         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10856         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10857         return type.
10858         (nto_procfs_target::pid_to_str): Change return type.
10859         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10860         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10861         return type.
10862         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10863         (exit_lwp): Update.
10864         (attach_proc_task_lwp_callback, get_detach_signal)
10865         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10866         (linux_nat_target::resume, wait_lwp, stop_callback)
10867         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10868         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10869         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10870         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10871         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10872         type.
10873         (inf_ptrace_target::attach): Update.
10874         (inf_ptrace_target::files_info): Update.
10875         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10876         type.
10877         (go32_nat_target::pid_to_str): Change return type.
10878         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10879         (gnu_nat_target::wait): Update.
10880         (gnu_nat_target::wait): Update.
10881         (gnu_nat_target::resume): Update.
10882         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10883         (fbsd_nat_target::wait): Update.
10884         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10885         type.
10886         (darwin_nat_target::attach): Update.
10887         * corelow.c (class core_target) <pid_to_str>: Change return type.
10888         (core_target::pid_to_str): Change return type.
10889         * target.c (normal_pid_to_str): Change return type.
10890         (default_pid_to_str): Likewise.
10891         (target_pid_to_str): Change return type.
10892         (target_translate_tls_address): Update.
10893         (target_announce_detach): Update.
10894         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10895         return type.
10896         (bsd_uthread_target::pid_to_str): Change return type.
10897         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10898         type.
10899         (bsd_kvm_target::pid_to_str): Change return type.
10900         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10901         return type.
10902         (aix_thread_target::pid_to_str): Change return type.
10903         * target.h (struct target_ops) <pid_to_str>: Change return type.
10904         (target_pid_to_str, normal_pid_to_str): Likewise.
10905         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10906         type.
10907         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10908         type.
10909         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10910         return type.
10911         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10912         type.
10913         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10914         type.
10915         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10916         return type.
10917
10918 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10919
10920         * NEWS: Mention that the new default MI version is 3.  Mention
10921         changes to the output of commands and events that deal with
10922         multi-location breakpoints.
10923         * breakpoint.c: Include "mi/mi-out.h".
10924         (print_one_breakpoint): Change output syntax if using MI version
10925         >= 3.
10926         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10927         New.
10928         (mi_multi_location_breakpoint_output_fixed): New.
10929         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10930         (mi_cmd_fix_multi_location_breakpoint_output): New.
10931         (mi_multi_location_breakpoint_output_fixed): New.
10932         * mi/mi-cmds.c (mi_cmds): Register command
10933         -fix-multi-location-breakpoint-output.
10934         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10935         interpreter "mi".
10936
10937 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10938
10939         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10940         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10941         instantiate mi_ui_out based on interpreter name.
10942         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10943         * mi/mi-main.c (mi_load_progress): Likewise.
10944
10945 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10946
10947         * NEWS: Combine separate "New targets" sections for 8.3.
10948
10949 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10950
10951         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10952         (ppcfbsd_init_abi): Install gdbarch
10953         "fetch_tls_load_module_address" and "get_thread_local_address"
10954         methods.
10955
10956 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10957
10958         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10959         (riscv_fbsd_init_abi): Install gdbarch
10960         "fetch_tls_load_module_address" and "get_thread_local_address"
10961         methods.
10962
10963 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10964
10965         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10966         (i386fbsd_init_abi): Install gdbarch
10967         "fetch_tls_load_module_address" and "get_thread_local_address"
10968         methods.
10969
10970 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10971
10972         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10973         (amd64fbsd_init_abi): Install gdbarch
10974         "fetch_tls_load_module_address" and "get_thread_local_address"
10975         methods.
10976
10977 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10978
10979         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10980         (struct fbsd_pspace_data): New type.
10981         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10982         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10983         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10984         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10985         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10986
10987 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10988
10989         * gdbtypes.c (lookup_struct_elt): New function.
10990         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10991         * gdbtypes.h (struct struct_elt): New type.
10992         (lookup_struct_elt): New prototype.
10993
10994 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10995
10996         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10997         remove disabled code block.
10998
10999 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11000
11001         * gdbarch.sh (get_thread_local_address): New method.
11002         * gdbarch.h, gdbarch.c: Regenerate.
11003         * target.c (target_translate_tls_address): Use
11004         gdbarch_get_thread_local_address if present instead of
11005         target::get_thread_local_address.
11006
11007 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11008
11009         * target.h (target::get_thread_local_address): Update comment.
11010
11011 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11012
11013         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11014         objfile->separate_debug_objfile_backlink if not NULL.
11015
11016 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11017
11018         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11019         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11020         (amd64bsd_store_inferior_registers): Likewise.
11021         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11022         Enable segment base registers.
11023         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11024         PT_GETFSBASE and PT_GETGSBASE.
11025         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11026         PT_SETGSBASE.
11027         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11028         segment base registers.
11029         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11030
11031 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11032
11033         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11034         Update calls to i386_target_description to add 'segments'
11035         parameter.
11036         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11037         add segment base registers.
11038         * arch/i386.c (i386_create_target_description): Add 'segments'
11039         parameter to enable segment base registers.
11040         * arch/i386.h (i386_create_target_description): Likewise.
11041         * features/i386/32bit-segments.xml: New file.
11042         * features/i386/32bit-segments.c: Generate.
11043         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11044         call to i386_target_description to add 'segments' parameter.
11045         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11046         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11047         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11048         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11049         if feature is present.
11050         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11051         Add 'segments' parameter to call to i386_target_description.
11052         (i386_target_description): Add 'segments' parameter to enable
11053         segment base registers.
11054         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11055         to call to i386_target_description.
11056         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11057         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11058         Define I386_NUM_REGS.
11059         (i386_target_description): Add 'segments' parameter to enable
11060         segment base registers.
11061
11062 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11063
11064         PR/24325
11065         * source-cache.c: #undef open and close, to avoid unresolved
11066         externals during linking.
11067
11068 2019-03-12  Tom Tromey  <tromey@adacore.com>
11069
11070         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11071         const.  Add initializers.
11072         (_initialize_remote): Don't initialize ptid globals.
11073
11074 2019-03-12  Pedro Alves  <palves@redhat.com>
11075
11076         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11077
11078 2019-03-12  Pedro Alves  <palves@redhat.com>
11079
11080         * cp-name-parser.y (main): Remove unused 'len' variable.
11081
11082 2019-03-12  Tom Tromey  <tromey@adacore.com>
11083
11084         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11085         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11086
11087 2019-03-12  Tom Tromey  <tromey@adacore.com>
11088
11089         * linux-nat.c (iterate_over_lwps): Update.
11090         (stop_callback): Remove parameter.
11091         (stop_wait_callback, detach_callback, resume_set_callback)
11092         (select_singlestep_lwp_callback, set_ignore_sigint)
11093         (status_callback, resumed_callback, resume_clear_callback)
11094         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11095         data parameter.
11096         (linux_nat_target::detach, linux_nat_target::resume)
11097         (linux_stop_and_wait_all_lwps, select_event_lwp)
11098         (linux_nat_filter_event, linux_nat_wait_1)
11099         (linux_nat_target::kill, linux_nat_target::stop)
11100         (linux_nat_target::stop): Update.
11101         (linux_nat_resume_callback): Change type.
11102         (resume_stopped_resumed_lwps, count_events_callback)
11103         (select_event_lwp_callback): Likewise.
11104         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11105         * arm-linux-nat.c (struct update_registers_data): Remove.
11106         (update_registers_callback): Change type.
11107         (arm_linux_insert_hw_breakpoint1): Update.
11108         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11109         parameter.
11110         (x86_linux_dr_set_addr): Update.
11111         (x86_linux_dr_set_control): Update.
11112         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11113         (iterate_over_lwps): Use gdb::function_view.
11114         * nat/aarch64-linux-hw-point.c (struct
11115         aarch64_dr_update_callback_param): Remove.
11116         (debug_reg_change_callback): Change type.
11117         (aarch64_notify_debug_reg_change): Update.
11118         * s390-linux-nat.c (s390_refresh_per_info): Update.
11119
11120 2019-03-11  Tom Tromey  <tromey@adacore.com>
11121
11122         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11123         redundant assignment to "this_cu".
11124
11125 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11126
11127         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11128
11129 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11130
11131         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11132         from...
11133         (rank_one_type): ... this.
11134
11135 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11136
11137         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11138         from...
11139         (rank_one_type): ... this.
11140
11141 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11142
11143         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11144         from...
11145         (rank_one_type): ... this.
11146
11147 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11148
11149         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11150         from...
11151         (rank_one_type): ... this.
11152
11153 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11154
11155         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11156         from...
11157         (rank_one_type): ... this.
11158
11159 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11160
11161         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11162         from...
11163         (rank_one_type): ... this.
11164
11165 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11166
11167         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11168         from...
11169         (rank_one_type): ... this.
11170
11171 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11172
11173         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11174         from...
11175         (rank_one_type): ... this.
11176
11177 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11178
11179         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11180         from...
11181         (rank_one_type): ... this.
11182
11183 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11184
11185         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11186         from...
11187         (rank_one_type): ... this.
11188
11189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11190
11191         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11192         from...
11193         (rank_one_type): ... this.
11194
11195 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11196
11197         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11198         from...
11199         (rank_one_type): ... this.
11200
11201 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11202
11203         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11204         inferior-events' shows the example events.
11205
11206 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11207
11208         Support styling on native MS-Windows console
11209
11210         PR/24315
11211         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11212         on MS-Windows if $TERM is not defined.
11213
11214         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11215
11216         * posix-hdep.c (gdb_console_fputs):
11217         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11218         functions.
11219         * ui-file.h (gdb_console_fputs): Add prototype.
11220
11221         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11222         back to fputs only if the former returns zero.
11223
11224 2019-03-07  Tom Tromey  <tom@tromey.com>
11225
11226         * symmisc.c (print_symbol_bcache_statistics): Update.
11227         (print_objfile_statistics): Update.
11228         * symfile.c (allocate_symtab): Update.
11229         * stabsread.c: Don't include bcache.h.
11230         * psymtab.h (struct psymbol_bcache): Don't declare.
11231         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11232         (psymbol_bcache_init, psymbol_bcache_free)
11233         (psymbol_bcache_get_bcache): Don't declare.
11234         * psymtab.c (struct psymbol_bcache): Remove.
11235         (psymtab_storage::psymtab_storage): Update.
11236         (psymtab_storage::~psymtab_storage): Update.
11237         (psymbol_bcache_init, psymbol_bcache_free)
11238         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11239         (add_psymbol_to_bcache): Update.
11240         (allocate_psymtab): Update.
11241         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11242         macro_cache>: No longer pointers.
11243         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11244         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11245         * macrotab.c (macro_bcache): Update.
11246         * macroexp.c: Don't include bcache.h.
11247         * gdbtypes.c (check_types_worklist): Update.
11248         (types_deeply_equal): Remove TRY/CATCH.  Update.
11249         * elfread.c (elf_symtab_read): Update.
11250         * dwarf2read.c: Don't include bcache.h.
11251         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11252         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11253         (print_bcache_statistics, bcache_memory_used): Don't declare.
11254         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11255         methods.  Rename all data members.
11256         * bcache.c (struct bcache): Move to bcache.h.
11257         (bcache::expand_hash_table): Rename from expand_hash_table.
11258         (bcache): Remove.
11259         (bcache::insert): Rename from bcache_full.
11260         (bcache::compare): Rename from bcache_compare.
11261         (bcache_xmalloc): Remove.
11262         (bcache::~bcache): Rename from bcache_xfree.
11263         (bcache::print_statistics): Rename from print_bcache_statistics.
11264         (bcache::memory_used): Rename from bcache_memory_used.
11265
11266 2019-03-07  Pedro Alves  <palves@redhat.com>
11267
11268         * infrun.c (normal_stop): Also check for
11269         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11270
11271 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11272
11273         * f-lang.c (value_from_host_double): Moved to...
11274         * value.c (value_from_host_double): ...here.
11275         * value.h (value_from_host_double): Declare.
11276         * guile/scm-math.c (vlscm_convert_typed_number): Use
11277         value_from_host_double.
11278         (vlscm_convert_number): Likewise.
11279         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11280         * python/py-value.c (convert_value_from_python): Likewise.
11281
11282 2019-03-06  Tom Tromey  <tom@tromey.com>
11283
11284         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11285
11286 2019-03-06  Tom Tromey  <tom@tromey.com>
11287
11288         * utils.h (free_current_contents): Don't declare.
11289         * utils.c (free_current_contents): Remove.
11290
11291 2019-03-06  Tom Tromey  <tom@tromey.com>
11292
11293         * top.c (quit_force): Update.
11294         * main.c (captured_command_loop): Update.
11295         * common/new-op.c (operator new): Update.
11296         * common/common-exceptions.c (struct catcher)
11297         <save_cleanup_chain>: Remove member.
11298         (exceptions_state_mc_init): Update.
11299         (exception_try_scope_entry): Return nullptr.
11300         (exception_try_scope_exit, exception_rethrow)
11301         (throw_exception_sjlj, throw_exception_cxx): Update.
11302         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11303         (all_cleanups, do_cleanups, discard_cleanups)
11304         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11305         (restore_cleanups, restore_final_cleanups): Don't declare.
11306         (do_final_cleanups): Remove parameter.
11307         * common/cleanups.c (cleanup_chain, make_cleanup)
11308         (make_cleanup_dtor, all_cleanups, do_cleanups)
11309         (discard_my_cleanups, discard_cleanups)
11310         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11311         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11312         (null_cleanup): Remove.
11313         (do_final_cleanups): Remove parameter.
11314
11315 2019-03-06  Tom Tromey  <tom@tromey.com>
11316
11317         * remote.c (remote_target::remote_parse_stop_reply): Use
11318         unique_xmalloc_ptr.
11319
11320 2019-03-06  Tom Tromey  <tom@tromey.com>
11321
11322         * stabsread.c (struct stabs_field_info): Rename from field_info.
11323         <list, fnlist>: Add initializers.
11324         <obstack>: New member.
11325         (read_member_functions, read_struct_fields, read_baseclasses):
11326         Allocate on obstack.  Don't use cleanups.
11327         (read_one_struct_field, read_member_functions, read_struct_fields)
11328         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11329         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11330         (read_struct_type): Update.
11331
11332 2019-03-06  Tom Tromey  <tom@tromey.com>
11333
11334         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11335         * common/filestuff.h (make_cleanup_close): Don't declare.
11336         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11337         Remove.
11338
11339 2019-03-06  Tom Tromey  <tom@tromey.com>
11340
11341         * solib-aix.c: Use make_scope_exit.
11342
11343 2019-03-06  Tom Tromey  <tom@tromey.com>
11344
11345         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11346         Use make_scope_exit.
11347
11348 2019-03-06  Tom Tromey  <tom@tromey.com>
11349
11350         * solib-svr4.c (disable_probes_interface): Remove parameter.
11351         (svr4_handle_solib_event): Use make_scope_exit.
11352
11353 2019-03-06  Tom Tromey  <tom@tromey.com>
11354
11355         * remote.c (struct stop_reply_deleter): Remove.
11356         (stop_reply_up): Update.
11357         (struct stop_reply): Derive from notif_event.  Don't typedef.
11358         <regcache>: Now a std::vector.
11359         (stop_reply_xfree): Remove.
11360         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11361         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11362         (remote_target::discard_pending_stop_replies): Use delete.
11363         (remote_target::remote_parse_stop_reply): Update.
11364         (remote_target::process_stop_reply): Update.
11365         * remote-notif.h (struct notif_event): Add virtual destructor.
11366         Remove "dtr" member.
11367         (struct notif_client) <alloc_event>: Return a unique_ptr.
11368         (notif_event_xfree): Don't declare.
11369         (notif_event_up): New typedef.
11370         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11371         (notif_event_xfree, do_notif_event_xfree): Remove.
11372         (remote_notif_state_xfree): Update.
11373
11374 2019-03-06  Tom Tromey  <tom@tromey.com>
11375
11376         * infrun.c (displaced_step_clear_cleanup): Now a
11377         forward_scope_exit type.
11378         (displaced_step_prepare_throw): Update.
11379         (displaced_step_fixup): Update.
11380
11381 2019-03-06  Tom Tromey  <tom@tromey.com>
11382
11383         * inferior.h (class inferior): Update comment.
11384         * gdbthread.h (class thread_info): Update comment.
11385
11386 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11387             Tom Tromey  <tom@tromey.com>
11388
11389         * stabsread.h (struct stab_section_list): Remove.
11390         (coffstab_build_psymtabs): Update.
11391         * dbxread.c (symbuf_sections): Now a std::vector.
11392         (sect_idx): New global.
11393         (fill_symbuf): Update.
11394         (coffstab_build_psymtabs): Change type of stabsects parameter.
11395         Update.
11396         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11397         std::vector.
11398         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11399         (coff_locate_sections): Update.
11400         (coff_symfile_read): Remove cleanups.  Update.
11401         (init_stringtab): Add storage parameter.
11402         (free_stringtab, free_stringtab_cleanup): Remove.
11403         (init_lineno): Add storage parameter.
11404         (free_linetab, free_linetab_cleanup): Remove.
11405
11406 2019-03-06  Pedro Alves  <palves@redhat.com>
11407
11408         * linux-fork.c (fork_info::clobber_regs): Delete.
11409         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11410         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11411         comment.  Adjust.
11412         (scoped_switch_fork_info::scoped_switch_fork_info)
11413         (checkpoint_command, linux_fork_context): Adjust
11414         fork_save_infrun_state calls.
11415
11416 2019-03-06  Pedro Alves  <palves@redhat.com>
11417
11418         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11419         (inf_has_multiple_threads): Return 'bool' and rewrite using
11420         inferior_info::threads().
11421
11422 2019-03-06  Pedro Alves  <palves@redhat.com>
11423
11424         * linux-fork.c: Include <list>.
11425         (fork_list): Now a std::list instance.
11426         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11427         (forks_exist_p, find_last_fork): Adjust.
11428         (new_fork): Delete.
11429         (one_fork_p): New.
11430         (add_fork): Adjust.
11431         (free_fork): Delete, folded into fork_info::~fork_info().
11432         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11433         Adjust.
11434         (init_fork_list): Delete.
11435         (linux_fork_killall, linux_fork_mourn_inferior)
11436         (linux_fork_detach, info_checkpoints_command): Adjust.
11437         (_initialize_linux_fork): No longer call init_fork_list.
11438
11439 2019-03-06  Pedro Alves  <palves@redhat.com>
11440
11441         * linux-fork.c (new_fork): New, split out of ...
11442         (add_fork): ... this.  Return void.  Move "first fork" special
11443         case from here, to ...
11444         (checkpoint_command): ... here.
11445         * linux-linux.h (add_fork): Return void.
11446
11447 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11448
11449         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11450
11451 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11452             Chris January  <chris.january@arm.com>
11453             David Lecomber  <david.lecomber@arm.com>
11454
11455         * f-exp.y: New token, UNOP_INTRINSIC.
11456         (exp): New pattern using UNOP_INTRINSIC token.
11457         (f77_keywords): Add 'abs' keyword.
11458         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11459         (value_from_host_double): New function.
11460         (evaluate_subexp_f): Support UNOP_ABS.
11461
11462 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11463
11464         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11465         types.
11466
11467 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11468
11469         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11470         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11471         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11472
11473 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11474
11475         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11476
11477 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11478             Chris January  <chris.january@arm.com>
11479
11480         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11481         * f-exp.y: Define 'KIND' token.
11482         (exp): New pattern for KIND expressions.
11483         (ptype): Handle types with a kind extension.
11484         (direct_abs_decl): Extend to spot kind extensions.
11485         (f77_keywords): Add 'kind' to the list.
11486         (push_kind_type): New function.
11487         (convert_to_kind_type): New function.
11488         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11489         * parse.c (operator_length_standard): Likewise.
11490         * parser-defs.h (enum type_pieces): Add tp_kind.
11491         * std-operator.def: Add UNOP_KIND.
11492
11493 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11494
11495         * f-exp.y (f_parse): Set yydebug.
11496
11497 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11498
11499         * f-lang.c (evaluate_subexp_f): New function.
11500         (exp_descriptor_f): New global.
11501         (f_language_defn): Use exp_descriptor_f instead of
11502         exp_descriptor_standard.
11503
11504 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11505
11506         * f-exp.y (struct token): Add comments.
11507         (dot_ops): Remove uppercase versions and the end marker.
11508         (f77_keywords): Likewise.
11509         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11510         entries in the dot_ops array are case insensitive, and use
11511         strncasecmp to compare strings.  Also some whitespace cleanup in
11512         this area.  Similar for the f77_keywords array, except entries in
11513         this list might be case sensitive.
11514
11515 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11516
11517         * f-exp.y (struct f77_boolean_val): Add comments.
11518         (boolean_values): Remove uppercase versions, and end marker.
11519         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11520         and use strncasecmp to achieve case insensitivity.  Additionally,
11521         perform whitespace cleanup around this code.
11522
11523 2019-03-06  Tom Tromey  <tromey@adacore.com>
11524
11525         * remote-sim.c (gdbsim_target_open): Use result of
11526         gdb_argv::release.
11527
11528 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11529         Dirk Schubert  <dirk.schubert@arm.com>
11530         Chris January  <chris.january@arm.com>
11531
11532         * eval.c (evaluate_subexp_standard): Call Fortran argument
11533         wrapping logic.
11534         * f-lang.c (struct value): A value which can be passed into a
11535         Fortran function call.
11536         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11537         where appropriate.
11538         (struct type): Value ready for a Fortran function call.
11539         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11540         is needed.
11541         * f-lang.h (fortran_argument_convert): Declaration.
11542         (fortran_preserve_arg_pointer): Declaration.
11543         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11544
11545 2019-03-05  Tom Tromey  <tromey@adacore.com>
11546
11547         * python/py-prettyprint.c (print_string_repr): Remove #if.
11548         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11549
11550 2019-03-05  Tom Tromey  <tromey@adacore.com>
11551
11552         * target.c (the_dummy_target): Move later.  Change type to
11553         "dummy_target".
11554         (initialize_targets): Don't initialize the_dummy_target.
11555
11556 2019-03-05  Tom Tromey  <tromey@adacore.com>
11557
11558         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11559         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11560
11561 2019-03-05  Tom Tromey  <tromey@adacore.com>
11562
11563         * windows-nat.c (windows_nat_target::attach)
11564         (windows_nat_target::detach): Don't call gdb_flush.
11565         * valprint.c (generic_val_print, val_print, val_print_string):
11566         Don't call gdb_flush.
11567         * utils.c (defaulted_query): Don't call gdb_flush.
11568         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11569         * target.c (target_announce_detach): Don't call gdb_flush.
11570         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11571         * remote.c (extended_remote_target::attach): Don't call
11572         gdb_flush.
11573         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11574         * printcmd.c (do_examine): Don't call gdb_flush.
11575         (info_display_command): Don't call gdb_flush.
11576         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11577         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11578         * memattr.c (info_mem_command): Don't call gdb_flush.
11579         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11580         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11581         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11582         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11583         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11584         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11585         (gnu_nat_target::detach): Don't call gdb_flush.
11586         * f-valprint.c (f_val_print): Don't call gdb_flush.
11587         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11588         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11589         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11590         gdb_flush.
11591         * c-valprint.c (c_val_print): Don't call gdb_flush.
11592         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11593
11594 2019-03-05  Tom Tromey  <tromey@adacore.com>
11595
11596         * varobj.c (update_dynamic_varobj_children): Update.
11597         (install_default_visualizer): Use reset, not release.
11598         * value.c (set_internalvar): Update.
11599         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11600         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11601         ATTRIBUTE_UNUSED_RESULT.
11602
11603 2019-03-05  Tom Tromey  <tromey@adacore.com>
11604
11605         * remote.c (class scoped_remote_fd) <release>: Add
11606         ATTRIBUTE_UNUSED_RESULT.
11607
11608 2019-03-05  Tom Tromey  <tromey@adacore.com>
11609
11610         * macroexp.c (struct macro_buffer) <release>: Add
11611         ATTRIBUTE_UNUSED_RESULT.
11612
11613 2019-03-05  Tom Tromey  <tromey@adacore.com>
11614
11615         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11616         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11617         ATTRIBUTE_UNUSED_RESULT.
11618
11619 2019-03-05  Tom Tromey  <tromey@adacore.com>
11620
11621         * common/scoped_fd.h (class scoped_fd) <release>: Add
11622         ATTRIBUTE_UNUSED_RESULT.
11623
11624 2019-03-05  Tom Tromey  <tromey@adacore.com>
11625
11626         * parser-defs.h (struct parser_state) <release>: Add
11627         ATTRIBUTE_UNUSED_RESULT.
11628
11629 2019-03-05  Tom Tromey  <tromey@adacore.com>
11630
11631         * utils.h (class gdb_argv) <release>: Add
11632         ATTRIBUTE_UNUSED_RESULT.
11633         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11634
11635 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11636
11637         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11638         for-loop range, to avoid compiler warnings.
11639
11640         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11641         avoid compiler warnings about unused variables.
11642
11643         * NEWS: Mention end of support for native debugging on MS-Windows
11644         before XP.
11645
11646         PR gdb/24292
11647         * common/netstuff.c:
11648         * gdbserver/gdbreplay.c
11649         * gdbserver/remote-utils.c:
11650         * ser-tcp.c:
11651         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11652         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11653         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11654         'getaddrinfo' and 'freeaddrinfo' were not available before
11655         Windows XP, and mingw.org's MinGW headers by default define
11656         _WIN32_WINNT to 0x500.
11657
11658 2019-03-01  Gary Benson <gbenson@redhat.com>
11659
11660         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11661
11662 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11663             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11664
11665         PR gdb/8527
11666         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11667         set_sigint_trap, clear_sigint_trap.
11668
11669 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11670
11671         * target.c (target_detach): Clear the regcache and the
11672         frame cache.
11673
11674 2019-02-27  Pedro Alves  <palves@redhat.com>
11675
11676         * utils.c (set_screen_size): When we cap the height/width sizes,
11677         tweak the corresponding command variable to show "unlimited":
11678
11679 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11680             Pedro Alves  <palves@redhat.com>
11681
11682         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11683         before calling rl_set_screen_size.
11684
11685 2019-02-27  Tom Tromey  <tromey@adacore.com>
11686
11687         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11688         define.
11689         * python/py-value.c: Remove Python 2.4 workaround.
11690         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11691         workaround.
11692         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11693         Python 2.4 workaround.
11694         * python/python-internal.h: Remove Python 2.4 comment.
11695         (Py_ssize_t): Don't define.
11696         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11697         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11698         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11699         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11700         * python/python.c (do_start_initialization): Remove Python 2.4
11701         workaround.
11702         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11703         (print_children): Remove Python 2.4 workaround.
11704         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11705         workaround.
11706         (CHARBUFFERPROC_NAME): Remove.
11707         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11708         Python 2.4 workaround.
11709
11710 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11711
11712         * NEWS: Note minimum Python version.
11713
11714 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11715
11716         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11717         code from these functions.  Remove corresponding ifdefs.  Use
11718         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11719         Remove gotos and target of gotos.
11720         (infpy_search_memory): Likewise.
11721
11722 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11723
11724         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11725         (hppa_gdbarch_init): Don't register deleted functions with
11726         gdbarch.
11727
11728 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11729
11730         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11731         (h8300_unwind_sp): Delete.
11732         (h8300_dummy_id): Delete.
11733         (h8300_gdbarch_init): Don't register deleted functions with
11734         gdbarch.
11735
11736 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11737
11738         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11739         (ft32_unwind_pc): Delete.
11740         (ft32_unwind_sp): Delete.
11741         (ft32_gdbarch_init): Don't register deleted functions with
11742         gdbarch.
11743
11744 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11745
11746         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11747         (frv_unwind_pc): Delete.
11748         (frv_unwind_sp): Delete.
11749         (frv_gdbarch_init): Don't register deleted functions with
11750         gdbarch.
11751
11752 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11753
11754         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11755         (riscv_unwind_pc): Delete.
11756         (riscv_unwind_sp): Delete.
11757         (riscv_gdbarch_init): Don't register deleted functions with
11758         gdbarch.
11759
11760 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11761
11762         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11763         (csky_unwind_pc): Delete.
11764         (csky_unwind_sp): Delete.
11765         (csky_gdbarch_init): Don't register deleted functions with
11766         gdbarch.
11767
11768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11769
11770         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11771         (cris_unwind_pc): Delete.
11772         (cris_unwind_sp): Delete.
11773         (cris_gdbarch_init): Don't register deleted functions with
11774         gdbarch.
11775
11776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11777
11778         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11779         (bfin_unwind_pc): Delete.
11780         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11781
11782 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11783
11784         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11785         (arm_unwind_pc): Delete.
11786         (arm_unwind_sp): Delete.
11787         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11788
11789 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11790
11791         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11792         (arc_unwind_pc): Delete.
11793         (arc_unwind_sp): Delete.
11794         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11795
11796 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11797
11798         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11799         (alpha_unwind_pc): Delete.
11800         (alpha_gdbarch_init): Don't register deleted functions with
11801         gdbarch.
11802
11803 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11804
11805         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11806         (aarch64_unwind_pc): Delete.
11807         (aarch64_unwind_sp): Delete.
11808         (aarch64_gdbarch_init): Don't register deleted functions with
11809         gdbarch.
11810
11811 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11812
11813         * gdbtypes.c (type_align): Don't consider static members when
11814         computing structure alignment.
11815
11816 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11817
11818         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11819         return 0 for other types.
11820         * arch-utils.c (default_type_align): Always return 0.
11821         * gdbarch.h: Regenerate.
11822         * gdbarch.sh (type_align): Extend comment.
11823         * gdbtypes.c (type_align): Add additional comments, always call
11824         gdbarch_type_align before applying the default rules.
11825         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11826         generic code will then apply a suitable default.
11827         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11828         types, return 0 for other types.
11829
11830 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11831
11832         * NEWS: Create a new section for the next release branch.
11833         Rename the section of the current branch, now that it has
11834         been cut.
11835
11836 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11837
11838         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11839         * version.in: Bump version to 8.3.50.DATE-git.
11840
11841 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11842
11843         * aix-thread.c (ptid_cmp): Remove unused variable.
11844         (get_signaled_thread): Likewise.
11845         (store_regs_user_thread): Likewise.
11846         (store_regs_kernel_thread): Likewise.
11847         (fetch_regs_kernel_thread): Remove shadowed variable.
11848
11849 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11850
11851         * features/riscv/32bit-cpu.xml: Add register numbers.
11852         * features/riscv/32bit-fpu.c: Regenerate.
11853         * features/riscv/32bit-fpu.xml: Add register numbers.
11854         * features/riscv/64bit-cpu.xml: Add register numbers.
11855         * features/riscv/64bit-fpu.c: Regenerate.
11856         * features/riscv/64bit-fpu.xml: Add register numbers.
11857
11858 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11859
11860         * NEWS: Mention two argument form of gdb.Value constructor.
11861         * python/py-value.c (convert_buffer_and_type_to_value): New
11862         function.
11863         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11864         Add support for handling an optional second argument.  Call
11865         convert_buffer_and_type_to_value as appropriate.
11866         * python/python-internal.h (Py_buffer_deleter): New struct.
11867         (Py_buffer_up): New typedef.
11868
11869 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11870
11871         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11872         instead of releasing ownership.
11873
11874 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11875
11876         * dwarf2read.c (open_and_init_dwp_file): Call
11877         elf_numsections instead of bfd_count_sections to initialize
11878         dwp_file->num_sections.
11879
11880 2019-02-25  Tom Tromey  <tromey@adacore.com>
11881
11882         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11883
11884 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11885
11886         * gcore.in: Add '--readnever' option when invoking GDB.
11887
11888 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11889
11890         * MAINTAINERS: Update my email address.
11891
11892 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11893
11894         * build-id.c (build_id_to_debug_bfd_1): New function.
11895         (build_id_to_debug_bfd): Look for separate debug file in
11896         sysroot.
11897
11898 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11899
11900         * gdbarch.sh: Update the copyright year range that is placed into
11901         generated files.
11902
11903 2019-02-22  Keith Seitz  <keiths@redhat.com>
11904
11905         PR symtab/23853
11906         * linespec.c (create_sals_line_offset): Search for the default
11907         symtab's filename instead of its fullname.
11908
11909 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11910
11911         * NEWS: Update style defaults.
11912
11913 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11914
11915         * main.c (captured_main_1): Disable styling in batch mode.
11916
11917 2019-02-20  Tom Tromey  <tom@tromey.com>
11918
11919         * symtab.c (symtab_symbol_info): Fix typos.
11920
11921 2019-02-20  Tom Tromey  <tromey@adacore.com>
11922
11923         * findcmd.c (_initialize_mem_search): Use upper case for
11924         metasyntactic variables.
11925
11926 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11927
11928         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11929         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11930
11931 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11932
11933         * top.h (source_file_name): Change to std::string.
11934         * top.c (source_file_name): Likewise.
11935         (command_line_input): Adjust.
11936         * cli/cli-script.c (script_from_file): Adjust.
11937
11938 2019-02-19  Tom Tromey  <tromey@adacore.com>
11939
11940         * ravenscar-thread.c
11941         (ravenscar_thread_target::update_thread_list): Don't call
11942         ada_build_task_list.
11943         * ada-lang.h (ada_build_task_list): Don't declare.
11944         * ada-tasks.c (struct ada_tasks_inferior_data)
11945         <task_list_valid_p>: Now bool.
11946         (read_known_tasks, ada_task_list_changed)
11947         (ada_tasks_invalidate_inferior_data): Update.
11948         (read_known_tasks_array): Return bool.
11949         (read_known_tasks_list): Likewise.
11950         (read_known_tasks): Return void.
11951         (ada_build_task_list): Now static.
11952
11953 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11954
11955         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11956         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11957
11958 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11959
11960         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11961         variant for ada_tasks_pspace_data_handle and
11962         ada_tasks_inferior_data_handle.
11963         (ada_tasks_pspace_data_cleanup): New function.
11964         (ada_tasks_inferior_data_cleanup): New function.
11965
11966 2019-02-17  Tom Tromey  <tom@tromey.com>
11967
11968         * macrotab.h (macro_source_fullname): Return a std::string.
11969         * macrotab.c (macro_include, check_for_redefinition)
11970         (macro_undef, macro_lookup_definition, foreach_macro)
11971         (foreach_macro_in_scope): Update.
11972         (macro_source_fullname): Return a std::string.
11973         * macrocmd.c (show_pp_source_pos): Update.
11974
11975 2019-02-17  Tom Tromey  <tom@tromey.com>
11976
11977         * macrocmd.c (show_pp_source_pos): Style the file names.
11978
11979 2019-02-17  Tom Tromey  <tom@tromey.com>
11980
11981         PR tui/24197:
11982         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11983
11984 2019-02-17  Tom Tromey  <tom@tromey.com>
11985
11986         * ada-lang.c (user_select_syms): Use filtered printing.
11987         * utils.c (wrap_style): New global.
11988         (desired_style): Remove.
11989         (emit_style_escape): Add stream parameter.
11990         (set_output_style, reset_terminal_style, prompt_for_continue):
11991         Update.
11992         (flush_wrap_buffer): Only flush gdb_stdout.
11993         (wrap_here): Set wrap_style.
11994         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11995         treat escape sequences as a character.  Change when wrap buffer is
11996         flushed.
11997         (fputs_styled): Do not set the output style when the default is
11998         requested.
11999         * ui-style.h (struct ui_file_style) <is_default>: New method.
12000         * source.c (print_source_lines_base): Emit escape sequences in one
12001         piece.
12002
12003 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12004
12005         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12006         integers and enumeration types.
12007
12008 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12009
12010         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12011         instead of lookup_symbol_in_language
12012         (do_exact_match): New function.
12013         (ada_get_symbol_name_matcher): Return do_exact_match when
12014         doing a verbatim match.
12015
12016 2019-02-15  Tom Tromey  <tromey@adacore.com>
12017
12018         * ravenscar-thread.c (ravenscar_thread_target::resume)
12019         (ravenscar_thread_target::wait): Special case wildcard requests.
12020
12021 2019-02-15  Tom Tromey  <tromey@adacore.com>
12022
12023         * ravenscar-thread.c (base_ptid): Remove.
12024         (struct ravenscar_thread_target) <close>: New method.
12025         <m_base_ptid>: New member.
12026         <update_inferior_ptid, active_task, task_is_currently_active,
12027         runtime_initialized>: Declare methods.
12028         <ravenscar_thread_target>: Add constructor.
12029         (ravenscar_thread_target::task_is_currently_active)
12030         (ravenscar_thread_target::update_inferior_ptid)
12031         (ravenscar_runtime_initialized): Rename.  Now methods.
12032         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12033         (ravenscar_thread_target::update_thread_list): Update.
12034         (ravenscar_thread_target::active_task): Now method.
12035         (ravenscar_thread_target::store_registers)
12036         (ravenscar_thread_target::prepare_to_store)
12037         (ravenscar_thread_target::prepare_to_store)
12038         (ravenscar_thread_target::mourn_inferior): Update.
12039         (ravenscar_inferior_created): Use "new" to create target.
12040         (ravenscar_thread_target::get_ada_task_ptid): Update.
12041         (_initialize_ravenscar): Don't initialize base_ptid.
12042         (ravenscar_ops): Remove global.
12043
12044 2019-02-15  Tom Tromey  <tromey@adacore.com>
12045
12046         * target.h (push_target): Declare new overload.
12047         * target.c (push_target): New overload, taking an rvalue reference.
12048         * remote.c (remote_target::open_1): Use push_target overload.
12049         * corelow.c (core_target_open): Use push_target overload.
12050
12051 2019-02-15  Tom Tromey  <tromey@adacore.com>
12052
12053         * ravenscar-thread.c (is_ravenscar_task)
12054         (ravenscar_task_is_currently_active): Return bool.
12055         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12056         (_initialize_ravenscar): Remove "(void)".
12057         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12058         Return bool.
12059
12060 2019-02-15  Tom Tromey  <tromey@adacore.com>
12061
12062         * ravenscar-thread.c (ravenscar_runtime_initializer)
12063         (has_ravenscar_runtime, get_running_thread_id)
12064         (ravenscar_thread_target::resume): Fix indentation.
12065
12066 2019-02-15  Tom Tromey  <tromey@adacore.com>
12067
12068         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12069         from ravenscar_arch_ops.
12070         (sparc_ravenscar_ops::fetch_registers)
12071         (sparc_ravenscar_ops::store_registers): Now methods.
12072         (sparc_ravenscar_prepare_to_store): Remove.
12073         (sparc_ravenscar_ops): Redefine.
12074         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12075         methods and destructor.  Remove members.
12076         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12077         (ravenscar_thread_target::store_registers)
12078         (ravenscar_thread_target::prepare_to_store): Update.
12079         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12080         Remove.
12081         (struct ppc_ravenscar_powerpc_ops): Derive from
12082         ravenscar_arch_ops.
12083         (ppc_ravenscar_powerpc_ops::fetch_registers)
12084         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12085         (ppc_ravenscar_powerpc_ops): Redefine.
12086         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12087         (ppc_ravenscar_e500_ops::fetch_registers)
12088         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12089         (ppc_ravenscar_e500_ops): Redefine.
12090         * aarch64-ravenscar-thread.c
12091         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12092         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12093         (aarch64_ravenscar_fetch_registers)
12094         (aarch64_ravenscar_store_registers): Now methods.
12095         (aarch64_ravenscar_ops): Redefine.
12096
12097 2019-02-15  Tom Tromey  <tromey@adacore.com>
12098
12099         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12100         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12101         (ravenscar_thread_target::stopped_by_watchpoint)
12102         (ravenscar_thread_target::stopped_data_address)
12103         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12104
12105 2019-02-15  Tom Tromey  <tromey@adacore.com>
12106
12107         * ravenscar-thread.c: Fix some typos.
12108
12109 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12110             Tom Tromey  <tromey@adacore.com>
12111
12112         * ada-lang.c (ada_exception_sal): Change addr_string to a
12113         std::string.
12114         (create_ada_exception_catchpoint): Update.
12115
12116 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12117             Tom Tromey  <tromey@adacore.com>
12118
12119         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12120         (bp_location_ops): Remove.
12121         (base_breakpoint_allocate_location): Update.
12122         (free_bp_location): Update.
12123         * ada-lang.c (class ada_catchpoint_location)
12124         <ada_catchpoint_location>: Remove ops parameter.
12125         (ada_catchpoint_location_dtor): Remove.
12126         (ada_catchpoint_location_ops): Remove.
12127         (allocate_location_exception): Update.
12128         * breakpoint.h (struct bp_location_ops): Remove.
12129         (class bp_location) <bp_location>: Remove bp_location_ops
12130         parameter.
12131         <~bp_location>: Add destructor.
12132         <ops>: Remove.
12133
12134 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12135             Pedro Alves  <palves@redhat.com>
12136
12137         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12138         'PATH_MAX'.
12139
12140 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12141             Samuel Thibault  <samuel.thibault@gnu.org>
12142             Thomas Schwinge  <thomas@codesourcery.com>
12143
12144         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12145         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12146
12147 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12148
12149         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12150         (check_empty): Use "const char *".
12151
12152         * gnu-nat.c (gnu_nat_target::detach): Instead of
12153         'detach_inferior (pid)' call
12154         'detach_inferior (find_inferior_pid (pid))'.
12155
12156         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12157         'nat/fork-inferior.o'.
12158         * gnu-nat.c: #include "nat/fork-inferior.h".
12159
12160         * gnu-nat.c (gnu_nat_target::detach): Instead of
12161         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12162         * gnu-nat.h: #include "inf-child.h".
12163         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12164         'i386_gnu_nat_target::fetch_registers'.
12165         (gnu_store_registers): Rename/move to
12166         'i386_gnu_nat_target::store_registers'.
12167
12168         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12169         * gnu-nat.h (mach_thread_info): New function.
12170         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12171
12172         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12173
12174 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12175
12176         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12177
12178 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12179
12180         * windows-nat.c (windows_add_thread): Add new parameter
12181         "main_thread_p" with default value set to false.  Update
12182         function documentation as well as all callers.
12183         (windows_delete_thread): Likewise.
12184         (fake_create_process): Update call to windows_add_thread.
12185         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12186         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12187         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12188         call to windows_delete_thread.
12189
12190 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12191
12192         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12193
12194 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12195
12196         * symfile.c (find_separate_debug_file): Use canonical path of
12197         sysroot with child_path instead of gdb_sysroot if it is valid.
12198
12199 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12200
12201         * symfile.c (find_separate_debug_file): Use child_path to
12202         determine if an object file is under a sysroot.
12203
12204 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12205
12206         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12207         unittests/child-path-selftests.c.
12208         * common/pathstuff.c (child_path): New function.
12209         * common/pathstuff.h (child_path): New prototype.
12210         * unittests/child-path-selftests.c: New file.
12211
12212 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12213
12214         * symfile.c (find_separate_debug_file): Look for separate debug
12215         files in debug directories under the sysroot.
12216
12217 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12218
12219         * symtab.h (struct minimal_symbol data_p): New const method.
12220         (struct minimal_symbol text_p): Likewise.
12221         * symtab.c (output_source_filename): Use file name style
12222         to print file name.
12223         (print_symbol_info): Likewise.
12224         (print_msymbol_info): Use address style to print addresses.
12225         Use function name style to print executable text symbols.
12226         (expand_symtab_containing_pc): Use data_p.
12227         (find_pc_sect_compunit_symtab): Likewise.
12228
12229 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12230
12231         * breakpoint.c (describe_other_breakpoints): Use address style
12232         to print addresses.
12233         (say_where): Likewise.
12234
12235 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12236
12237         * ada-typeprint.c (print_func_type): Print function name
12238         style to print function name.
12239         * c-typeprint.c (c_print_type_1): Likewise.
12240
12241 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12242
12243         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12244         for execve.
12245
12246 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12247
12248         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12249         type_stack.
12250
12251 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12252
12253         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12254         TYPE_CODE_REF types.
12255
12256 2019-02-08  Jim Wilson  <jimw@sifive.com>
12257
12258         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12259         (riscv_linux_fregset): New.
12260         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12261
12262 2019-02-07  Tom Tromey  <tom@tromey.com>
12263
12264         * thread.c (thread_cancel_execution_command): Update.
12265         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12266         methods.
12267         (struct thread_fsm_ops): Remove.
12268         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12269         (thread_fsm_should_stop, thread_fsm_return_value)
12270         (thread_fsm_set_finished, thread_fsm_finished_p)
12271         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12272         Don't declare.
12273         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12274         * infrun.c (clear_proceed_status_thread)
12275         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12276         (print_stop_event): Update.
12277         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12278         Add constructor.
12279         (step_command_fsm_ops): Remove.
12280         (new_step_command_fsm): Remove.
12281         (step_1): Update.
12282         (step_command_fsm::should_stop): Rename from
12283         step_command_fsm_should_stop.
12284         (step_command_fsm::clean_up): Rename from
12285         step_command_fsm_clean_up.
12286         (step_command_fsm::do_async_reply_reason): Rename from
12287         step_command_fsm_async_reply_reason.
12288         (struct until_next_fsm): Inherit from thread_fsm.  Add
12289         constructor.
12290         (until_next_fsm_ops): Remove.
12291         (new_until_next_fsm): Remove.
12292         (until_next_fsm::should_stop): Rename from
12293         until_next_fsm_should_stop.
12294         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12295         (until_next_fsm::do_async_reply_reason): Rename from
12296         until_next_fsm_async_reply_reason.
12297         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12298         constructor.  Change type of breakpoint.
12299         (finish_command_fsm_ops): Remove.
12300         (new_finish_command_fsm): Remove.
12301         (finish_command_fsm::should_stop): Rename from
12302         finish_command_fsm_should_stop.
12303         (finish_command_fsm::clean_up): Rename from
12304         finish_command_fsm_clean_up.
12305         (finish_command_fsm::return_value): Rename from
12306         finish_command_fsm_return_value.
12307         (finish_command_fsm::do_async_reply_reason): Rename from
12308         finish_command_fsm_async_reply_reason.
12309         (finish_command): Update.
12310         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12311         Add constructor.
12312         (call_thread_fsm_ops): Remove.
12313         (call_thread_fsm::call_thread_fsm): Rename from
12314         new_call_thread_fsm.
12315         (call_thread_fsm::should_stop): Rename from
12316         call_thread_fsm_should_stop.
12317         (call_thread_fsm::should_notify_stop): Rename from
12318         call_thread_fsm_should_notify_stop.
12319         (run_inferior_call, call_function_by_hand_dummy): Update.
12320         * cli/cli-interp.c (should_print_stop_to_console): Update.
12321         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12322         Add constructor.  Change type of location_breakpoint,
12323         caller_breakpoint.
12324         (until_break_fsm_ops): Remove.
12325         (new_until_break_fsm): Remove.
12326         (until_break_fsm::should_stop): Rename from
12327         until_break_fsm_should_stop.
12328         (until_break_fsm::clean_up): Rename from
12329         until_break_fsm_clean_up.
12330         (until_break_fsm::do_async_reply_reason): Rename from
12331         until_break_fsm_async_reply_reason.
12332         (until_break_command): Update.
12333         * thread-fsm.c: Remove.
12334         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12335
12336 2019-02-07  Tom Tromey  <tom@tromey.com>
12337
12338         * yy-remap.h: Add include guard.
12339         * xtensa-tdep.h: Add include guard.
12340         * xcoffread.h: Rename include guard.
12341         * varobj-iter.h: Add include guard.
12342         * tui/tui.h: Rename include guard.
12343         * tui/tui-winsource.h: Rename include guard.
12344         * tui/tui-wingeneral.h: Rename include guard.
12345         * tui/tui-windata.h: Rename include guard.
12346         * tui/tui-win.h: Rename include guard.
12347         * tui/tui-stack.h: Rename include guard.
12348         * tui/tui-source.h: Rename include guard.
12349         * tui/tui-regs.h: Rename include guard.
12350         * tui/tui-out.h: Rename include guard.
12351         * tui/tui-layout.h: Rename include guard.
12352         * tui/tui-io.h: Rename include guard.
12353         * tui/tui-hooks.h: Rename include guard.
12354         * tui/tui-file.h: Rename include guard.
12355         * tui/tui-disasm.h: Rename include guard.
12356         * tui/tui-data.h: Rename include guard.
12357         * tui/tui-command.h: Rename include guard.
12358         * tic6x-tdep.h: Add include guard.
12359         * target/waitstatus.h: Rename include guard.
12360         * target/wait.h: Rename include guard.
12361         * target/target.h: Rename include guard.
12362         * target/resume.h: Rename include guard.
12363         * target-float.h: Rename include guard.
12364         * stabsread.h: Add include guard.
12365         * rs6000-tdep.h: Add include guard.
12366         * riscv-fbsd-tdep.h: Add include guard.
12367         * regformats/regdef.h: Rename include guard.
12368         * record.h: Rename include guard.
12369         * python/python.h: Rename include guard.
12370         * python/python-internal.h: Rename include guard.
12371         * python/py-stopevent.h: Rename include guard.
12372         * python/py-ref.h: Rename include guard.
12373         * python/py-record.h: Rename include guard.
12374         * python/py-record-full.h: Rename include guard.
12375         * python/py-record-btrace.h: Rename include guard.
12376         * python/py-instruction.h: Rename include guard.
12377         * python/py-events.h: Rename include guard.
12378         * python/py-event.h: Rename include guard.
12379         * procfs.h: Add include guard.
12380         * proc-utils.h: Add include guard.
12381         * p-lang.h: Add include guard.
12382         * or1k-tdep.h: Rename include guard.
12383         * observable.h: Rename include guard.
12384         * nto-tdep.h: Rename include guard.
12385         * nat/x86-linux.h: Rename include guard.
12386         * nat/x86-linux-dregs.h: Rename include guard.
12387         * nat/x86-gcc-cpuid.h: Add include guard.
12388         * nat/x86-dregs.h: Rename include guard.
12389         * nat/x86-cpuid.h: Rename include guard.
12390         * nat/ppc-linux.h: Rename include guard.
12391         * nat/mips-linux-watch.h: Rename include guard.
12392         * nat/linux-waitpid.h: Rename include guard.
12393         * nat/linux-ptrace.h: Rename include guard.
12394         * nat/linux-procfs.h: Rename include guard.
12395         * nat/linux-osdata.h: Rename include guard.
12396         * nat/linux-nat.h: Rename include guard.
12397         * nat/linux-namespaces.h: Rename include guard.
12398         * nat/linux-btrace.h: Rename include guard.
12399         * nat/glibc_thread_db.h: Rename include guard.
12400         * nat/gdb_thread_db.h: Rename include guard.
12401         * nat/gdb_ptrace.h: Rename include guard.
12402         * nat/fork-inferior.h: Rename include guard.
12403         * nat/amd64-linux-siginfo.h: Rename include guard.
12404         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12405         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12406         * nat/aarch64-linux.h: Rename include guard.
12407         * nat/aarch64-linux-hw-point.h: Rename include guard.
12408         * mn10300-tdep.h: Add include guard.
12409         * mips-linux-tdep.h: Add include guard.
12410         * mi/mi-parse.h: Rename include guard.
12411         * mi/mi-out.h: Rename include guard.
12412         * mi/mi-main.h: Rename include guard.
12413         * mi/mi-interp.h: Rename include guard.
12414         * mi/mi-getopt.h: Rename include guard.
12415         * mi/mi-console.h: Rename include guard.
12416         * mi/mi-common.h: Rename include guard.
12417         * mi/mi-cmds.h: Rename include guard.
12418         * mi/mi-cmd-break.h: Rename include guard.
12419         * m2-lang.h: Add include guard.
12420         * location.h: Rename include guard.
12421         * linux-record.h: Rename include guard.
12422         * linux-nat.h: Add include guard.
12423         * linux-fork.h: Add include guard.
12424         * i386-darwin-tdep.h: Rename include guard.
12425         * hppa-linux-offsets.h: Add include guard.
12426         * guile/guile.h: Rename include guard.
12427         * guile/guile-internal.h: Rename include guard.
12428         * gnu-nat.h: Rename include guard.
12429         * gdb-stabs.h: Rename include guard.
12430         * frv-tdep.h: Add include guard.
12431         * f-lang.h: Add include guard.
12432         * event-loop.h: Add include guard.
12433         * darwin-nat.h: Rename include guard.
12434         * cp-abi.h: Rename include guard.
12435         * config/sparc/nm-sol2.h: Rename include guard.
12436         * config/nm-nto.h: Rename include guard.
12437         * config/nm-linux.h: Add include guard.
12438         * config/i386/nm-i386gnu.h: Rename include guard.
12439         * config/djgpp/nl_types.h: Rename include guard.
12440         * config/djgpp/langinfo.h: Rename include guard.
12441         * compile/gcc-cp-plugin.h: Add include guard.
12442         * compile/gcc-c-plugin.h: Add include guard.
12443         * compile/compile.h: Rename include guard.
12444         * compile/compile-object-run.h: Rename include guard.
12445         * compile/compile-object-load.h: Rename include guard.
12446         * compile/compile-internal.h: Rename include guard.
12447         * compile/compile-cplus.h: Rename include guard.
12448         * compile/compile-c.h: Rename include guard.
12449         * common/xml-utils.h: Rename include guard.
12450         * common/x86-xstate.h: Rename include guard.
12451         * common/version.h: Rename include guard.
12452         * common/vec.h: Rename include guard.
12453         * common/tdesc.h: Rename include guard.
12454         * common/selftest.h: Rename include guard.
12455         * common/scoped_restore.h: Rename include guard.
12456         * common/scoped_mmap.h: Rename include guard.
12457         * common/scoped_fd.h: Rename include guard.
12458         * common/safe-iterator.h: Rename include guard.
12459         * common/run-time-clock.h: Rename include guard.
12460         * common/refcounted-object.h: Rename include guard.
12461         * common/queue.h: Rename include guard.
12462         * common/ptid.h: Rename include guard.
12463         * common/print-utils.h: Rename include guard.
12464         * common/preprocessor.h: Rename include guard.
12465         * common/pathstuff.h: Rename include guard.
12466         * common/observable.h: Rename include guard.
12467         * common/netstuff.h: Rename include guard.
12468         * common/job-control.h: Rename include guard.
12469         * common/host-defs.h: Rename include guard.
12470         * common/gdb_wait.h: Rename include guard.
12471         * common/gdb_vecs.h: Rename include guard.
12472         * common/gdb_unlinker.h: Rename include guard.
12473         * common/gdb_unique_ptr.h: Rename include guard.
12474         * common/gdb_tilde_expand.h: Rename include guard.
12475         * common/gdb_sys_time.h: Rename include guard.
12476         * common/gdb_string_view.h: Rename include guard.
12477         * common/gdb_splay_tree.h: Rename include guard.
12478         * common/gdb_setjmp.h: Rename include guard.
12479         * common/gdb_ref_ptr.h: Rename include guard.
12480         * common/gdb_optional.h: Rename include guard.
12481         * common/gdb_locale.h: Rename include guard.
12482         * common/gdb_assert.h: Rename include guard.
12483         * common/filtered-iterator.h: Rename include guard.
12484         * common/filestuff.h: Rename include guard.
12485         * common/fileio.h: Rename include guard.
12486         * common/environ.h: Rename include guard.
12487         * common/common-utils.h: Rename include guard.
12488         * common/common-types.h: Rename include guard.
12489         * common/common-regcache.h: Rename include guard.
12490         * common/common-inferior.h: Rename include guard.
12491         * common/common-gdbthread.h: Rename include guard.
12492         * common/common-exceptions.h: Rename include guard.
12493         * common/common-defs.h: Rename include guard.
12494         * common/common-debug.h: Rename include guard.
12495         * common/cleanups.h: Rename include guard.
12496         * common/buffer.h: Rename include guard.
12497         * common/btrace-common.h: Rename include guard.
12498         * common/break-common.h: Rename include guard.
12499         * cli/cli-utils.h: Rename include guard.
12500         * cli/cli-style.h: Rename include guard.
12501         * cli/cli-setshow.h: Rename include guard.
12502         * cli/cli-script.h: Rename include guard.
12503         * cli/cli-interp.h: Rename include guard.
12504         * cli/cli-decode.h: Rename include guard.
12505         * cli/cli-cmds.h: Rename include guard.
12506         * charset-list.h: Add include guard.
12507         * buildsym-legacy.h: Rename include guard.
12508         * bfin-tdep.h: Add include guard.
12509         * ax.h: Rename include guard.
12510         * arm-linux-tdep.h: Add include guard.
12511         * arm-fbsd-tdep.h: Add include guard.
12512         * arch/xtensa.h: Rename include guard.
12513         * arch/tic6x.h: Add include guard.
12514         * arch/i386.h: Add include guard.
12515         * arch/arm.h: Rename include guard.
12516         * arch/arm-linux.h: Rename include guard.
12517         * arch/arm-get-next-pcs.h: Rename include guard.
12518         * arch/amd64.h: Add include guard.
12519         * arch/aarch64-insn.h: Rename include guard.
12520         * arch-utils.h: Rename include guard.
12521         * annotate.h: Add include guard.
12522         * amd64-darwin-tdep.h: Rename include guard.
12523         * aarch64-linux-tdep.h: Add include guard.
12524         * aarch64-fbsd-tdep.h: Add include guard.
12525         * aarch32-linux-nat.h: Add include guard.
12526
12527 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12528
12529         * macrotab.c (macro_define_internal): New function that
12530         factorizes macro_define_object_internal and macro_define_function
12531         code.
12532         (macro_define_object_internal): Use macro_define_internal.
12533         (macro_define_function): Likewise.
12534
12535 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12536
12537         * macrocmd.c (extract_identifier): Return
12538         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12539         callers.
12540
12541 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12542
12543         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12544
12545 2019-02-05  Tom Tromey  <tom@tromey.com>
12546
12547         * target.c (target_stack::unpush): Move assertion earlier.
12548
12549 2019-01-30  Tom Tromey  <tom@tromey.com>
12550
12551         PR python/23615:
12552         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12553         (gdbpy_parse_and_eval): Likewise.
12554         * python/python-internal.h (gdbpy_allow_threads): New class.
12555
12556 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12557
12558         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12559         (aarch64_fbsd_fpregmap): Move earlier.
12560         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12561         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12562         instead of individual calls to trad_frame_set_reg_addr.
12563         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12564         earlier.
12565         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12566         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12567         instead of individual calls to trad_frame_set_reg_addr.
12568
12569 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12570
12571         * CONTRIBUTE: Replace contribution list with wiki link.
12572
12573 2019-01-25  Tom Tromey  <tom@tromey.com>
12574
12575         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12576
12577 2019-01-25  Tom Tromey  <tom@tromey.com>
12578
12579         * xtensa-linux-nat.c: Fix common/ includes.
12580         * xml-support.h: Fix common/ includes.
12581         * xml-support.c: Fix common/ includes.
12582         * x86-linux-nat.c: Fix common/ includes.
12583         * windows-nat.c: Fix common/ includes.
12584         * varobj.h: Fix common/ includes.
12585         * varobj.c: Fix common/ includes.
12586         * value.c: Fix common/ includes.
12587         * valops.c: Fix common/ includes.
12588         * utils.c: Fix common/ includes.
12589         * unittests/xml-utils-selftests.c: Fix common/ includes.
12590         * unittests/utils-selftests.c: Fix common/ includes.
12591         * unittests/unpack-selftests.c: Fix common/ includes.
12592         * unittests/tracepoint-selftests.c: Fix common/ includes.
12593         * unittests/style-selftests.c: Fix common/ includes.
12594         * unittests/string_view-selftests.c: Fix common/ includes.
12595         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12596         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12597         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12598         * unittests/rsp-low-selftests.c: Fix common/ includes.
12599         * unittests/parse-connection-spec-selftests.c: Fix common/
12600         includes.
12601         * unittests/optional-selftests.c: Fix common/ includes.
12602         * unittests/offset-type-selftests.c: Fix common/ includes.
12603         * unittests/observable-selftests.c: Fix common/ includes.
12604         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12605         * unittests/memrange-selftests.c: Fix common/ includes.
12606         * unittests/memory-map-selftests.c: Fix common/ includes.
12607         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12608         * unittests/function-view-selftests.c: Fix common/ includes.
12609         * unittests/environ-selftests.c: Fix common/ includes.
12610         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12611         * unittests/common-utils-selftests.c: Fix common/ includes.
12612         * unittests/cli-utils-selftests.c: Fix common/ includes.
12613         * unittests/array-view-selftests.c: Fix common/ includes.
12614         * ui-file.c: Fix common/ includes.
12615         * tui/tui-io.c: Fix common/ includes.
12616         * tracepoint.h: Fix common/ includes.
12617         * tracepoint.c: Fix common/ includes.
12618         * tracefile-tfile.c: Fix common/ includes.
12619         * top.h: Fix common/ includes.
12620         * top.c: Fix common/ includes.
12621         * thread.c: Fix common/ includes.
12622         * target/waitstatus.h: Fix common/ includes.
12623         * target/waitstatus.c: Fix common/ includes.
12624         * target.h: Fix common/ includes.
12625         * target.c: Fix common/ includes.
12626         * target-memory.c: Fix common/ includes.
12627         * target-descriptions.c: Fix common/ includes.
12628         * symtab.h: Fix common/ includes.
12629         * symfile.c: Fix common/ includes.
12630         * stap-probe.c: Fix common/ includes.
12631         * spu-linux-nat.c: Fix common/ includes.
12632         * sparc-nat.c: Fix common/ includes.
12633         * source.c: Fix common/ includes.
12634         * solib.c: Fix common/ includes.
12635         * solib-target.c: Fix common/ includes.
12636         * ser-unix.c: Fix common/ includes.
12637         * ser-tcp.c: Fix common/ includes.
12638         * ser-pipe.c: Fix common/ includes.
12639         * ser-base.c: Fix common/ includes.
12640         * selftest-arch.c: Fix common/ includes.
12641         * s12z-tdep.c: Fix common/ includes.
12642         * rust-exp.y: Fix common/ includes.
12643         * rs6000-aix-tdep.c: Fix common/ includes.
12644         * riscv-tdep.c: Fix common/ includes.
12645         * remote.c: Fix common/ includes.
12646         * remote-notif.h: Fix common/ includes.
12647         * remote-fileio.h: Fix common/ includes.
12648         * remote-fileio.c: Fix common/ includes.
12649         * regcache.h: Fix common/ includes.
12650         * regcache.c: Fix common/ includes.
12651         * record-btrace.c: Fix common/ includes.
12652         * python/python.c: Fix common/ includes.
12653         * python/py-type.c: Fix common/ includes.
12654         * python/py-inferior.c: Fix common/ includes.
12655         * progspace.h: Fix common/ includes.
12656         * producer.c: Fix common/ includes.
12657         * procfs.c: Fix common/ includes.
12658         * proc-api.c: Fix common/ includes.
12659         * printcmd.c: Fix common/ includes.
12660         * ppc-linux-nat.c: Fix common/ includes.
12661         * parser-defs.h: Fix common/ includes.
12662         * osdata.c: Fix common/ includes.
12663         * obsd-nat.c: Fix common/ includes.
12664         * nat/x86-linux.c: Fix common/ includes.
12665         * nat/x86-linux-dregs.c: Fix common/ includes.
12666         * nat/x86-dregs.h: Fix common/ includes.
12667         * nat/x86-dregs.c: Fix common/ includes.
12668         * nat/ppc-linux.c: Fix common/ includes.
12669         * nat/mips-linux-watch.h: Fix common/ includes.
12670         * nat/mips-linux-watch.c: Fix common/ includes.
12671         * nat/linux-waitpid.c: Fix common/ includes.
12672         * nat/linux-ptrace.h: Fix common/ includes.
12673         * nat/linux-ptrace.c: Fix common/ includes.
12674         * nat/linux-procfs.c: Fix common/ includes.
12675         * nat/linux-personality.c: Fix common/ includes.
12676         * nat/linux-osdata.c: Fix common/ includes.
12677         * nat/linux-namespaces.c: Fix common/ includes.
12678         * nat/linux-btrace.h: Fix common/ includes.
12679         * nat/linux-btrace.c: Fix common/ includes.
12680         * nat/fork-inferior.c: Fix common/ includes.
12681         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12682         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12683         * nat/aarch64-linux.c: Fix common/ includes.
12684         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12685         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12686         * namespace.h: Fix common/ includes.
12687         * mips-linux-tdep.c: Fix common/ includes.
12688         * minsyms.c: Fix common/ includes.
12689         * mi/mi-parse.h: Fix common/ includes.
12690         * mi/mi-main.c: Fix common/ includes.
12691         * mi/mi-cmd-env.c: Fix common/ includes.
12692         * memrange.h: Fix common/ includes.
12693         * memattr.c: Fix common/ includes.
12694         * maint.h: Fix common/ includes.
12695         * maint.c: Fix common/ includes.
12696         * main.c: Fix common/ includes.
12697         * machoread.c: Fix common/ includes.
12698         * location.c: Fix common/ includes.
12699         * linux-thread-db.c: Fix common/ includes.
12700         * linux-nat.c: Fix common/ includes.
12701         * linux-fork.c: Fix common/ includes.
12702         * inline-frame.c: Fix common/ includes.
12703         * infrun.c: Fix common/ includes.
12704         * inflow.c: Fix common/ includes.
12705         * inferior.h: Fix common/ includes.
12706         * inferior.c: Fix common/ includes.
12707         * infcmd.c: Fix common/ includes.
12708         * inf-ptrace.c: Fix common/ includes.
12709         * inf-child.c: Fix common/ includes.
12710         * ia64-linux-nat.c: Fix common/ includes.
12711         * i387-tdep.c: Fix common/ includes.
12712         * i386-tdep.c: Fix common/ includes.
12713         * i386-linux-tdep.c: Fix common/ includes.
12714         * i386-linux-nat.c: Fix common/ includes.
12715         * i386-go32-tdep.c: Fix common/ includes.
12716         * i386-fbsd-tdep.c: Fix common/ includes.
12717         * i386-fbsd-nat.c: Fix common/ includes.
12718         * guile/scm-type.c: Fix common/ includes.
12719         * guile/guile.c: Fix common/ includes.
12720         * go32-nat.c: Fix common/ includes.
12721         * gnu-nat.c: Fix common/ includes.
12722         * gdbthread.h: Fix common/ includes.
12723         * gdbarch-selftests.c: Fix common/ includes.
12724         * gdb_usleep.c: Fix common/ includes.
12725         * gdb_select.h: Fix common/ includes.
12726         * gdb_bfd.c: Fix common/ includes.
12727         * gcore.c: Fix common/ includes.
12728         * fork-child.c: Fix common/ includes.
12729         * findvar.c: Fix common/ includes.
12730         * fbsd-nat.c: Fix common/ includes.
12731         * event-top.c: Fix common/ includes.
12732         * event-loop.c: Fix common/ includes.
12733         * dwarf2read.c: Fix common/ includes.
12734         * dwarf2loc.c: Fix common/ includes.
12735         * dwarf2-frame.c: Fix common/ includes.
12736         * dwarf-index-cache.c: Fix common/ includes.
12737         * dtrace-probe.c: Fix common/ includes.
12738         * disasm-selftests.c: Fix common/ includes.
12739         * defs.h: Fix common/ includes.
12740         * csky-tdep.c: Fix common/ includes.
12741         * cp-valprint.c: Fix common/ includes.
12742         * cp-support.h: Fix common/ includes.
12743         * cp-support.c: Fix common/ includes.
12744         * corelow.c: Fix common/ includes.
12745         * completer.h: Fix common/ includes.
12746         * completer.c: Fix common/ includes.
12747         * compile/compile.c: Fix common/ includes.
12748         * compile/compile-loc2c.c: Fix common/ includes.
12749         * compile/compile-cplus-types.c: Fix common/ includes.
12750         * compile/compile-cplus-symbols.c: Fix common/ includes.
12751         * command.h: Fix common/ includes.
12752         * cli/cli-dump.c: Fix common/ includes.
12753         * cli/cli-cmds.c: Fix common/ includes.
12754         * charset.c: Fix common/ includes.
12755         * build-id.c: Fix common/ includes.
12756         * btrace.h: Fix common/ includes.
12757         * btrace.c: Fix common/ includes.
12758         * breakpoint.h: Fix common/ includes.
12759         * breakpoint.c: Fix common/ includes.
12760         * ax.h:
12761         (enum agent_op): Fix common/ includes.
12762         * ax-general.c (struct aop_map): Fix common/ includes.
12763         * ax-gdb.c: Fix common/ includes.
12764         * auxv.c: Fix common/ includes.
12765         * auto-load.c: Fix common/ includes.
12766         * arm-tdep.c: Fix common/ includes.
12767         * arch/riscv.c: Fix common/ includes.
12768         * arch/ppc-linux-common.c: Fix common/ includes.
12769         * arch/i386.c: Fix common/ includes.
12770         * arch/arm.c: Fix common/ includes.
12771         * arch/arm-linux.c: Fix common/ includes.
12772         * arch/arm-get-next-pcs.c: Fix common/ includes.
12773         * arch/amd64.c: Fix common/ includes.
12774         * arch/aarch64.c: Fix common/ includes.
12775         * arch/aarch64-insn.c: Fix common/ includes.
12776         * arch-utils.c: Fix common/ includes.
12777         * amd64-windows-tdep.c: Fix common/ includes.
12778         * amd64-tdep.c: Fix common/ includes.
12779         * amd64-sol2-tdep.c: Fix common/ includes.
12780         * amd64-obsd-tdep.c: Fix common/ includes.
12781         * amd64-nbsd-tdep.c: Fix common/ includes.
12782         * amd64-linux-tdep.c: Fix common/ includes.
12783         * amd64-linux-nat.c: Fix common/ includes.
12784         * amd64-fbsd-tdep.c: Fix common/ includes.
12785         * amd64-fbsd-nat.c: Fix common/ includes.
12786         * amd64-dicos-tdep.c: Fix common/ includes.
12787         * amd64-darwin-tdep.c: Fix common/ includes.
12788         * agent.c: Fix common/ includes.
12789         * ada-lang.h: Fix common/ includes.
12790         * ada-lang.c: Fix common/ includes.
12791         * aarch64-tdep.c: Fix common/ includes.
12792
12793 2019-01-25  Tom Tromey  <tom@tromey.com>
12794
12795         * common/create-version.sh: Use common/version.h.
12796
12797 2019-01-24  Pedro Alves  <palves@redhat.com>
12798
12799         * infrun.c (signal_stop, signal_print, signal_program)
12800         (signal_catch, signal_pass): Now arrays instead of pointers.
12801         (update_signals_program_target, do_target_resume)
12802         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12803         * linux-nat.c (linux_nat_target::pass_signals)
12804         (linux_nat_target::create_inferior, linux_nat_target::attach):
12805         Adjust.
12806         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12807         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12808         * procfs.c (procfs_target::pass_signals): Adjust.
12809         * record-full.c (record_full_target::resume): Adjust.
12810         * remote.c (remote_target::pass_signals)
12811         (remote_target::program_signals): Adjust.
12812         * target-debug.h (target_debug_print_signals): Now takes a
12813         gdb::array_view as parameter.  Adjust.
12814         * target.h (target_ops) <pass_signals, program_signals>: Replace
12815         pointer and length parameters with gdb::array_view.
12816         (target_pass_signals, target_program_signals): Likewise.
12817         * target-delegates.c: Regenerate.
12818
12819 2019-01-24  Pedro Alves  <palves@redhat.com>
12820
12821         * common/forward-scope-exit.h
12822         (forward_scope_exit::forward_scope_exit): Pass arguments to
12823         m_bind_function directly, instead of creating a std::bind and
12824         copying that.
12825
12826 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12827
12828         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12829         for static members.
12830         (pass_in_v_vfp_candidate): Likewise.
12831
12832 2019-01-23  Tom Tromey  <tom@tromey.com>
12833             Pedro Alves  <palves@redhat.com>
12834
12835         * regcache.c (class regcache_invalidator): Remove.
12836         (regcache::raw_write): Use make_scope_exit.
12837
12838 2019-01-23  Tom Tromey  <tom@tromey.com>
12839
12840         * ui-out.h (class ui_out_emit_type): Update comment.
12841
12842 2019-01-23  Tom Tromey  <tom@tromey.com>
12843
12844         * infrun.c (fetch_inferior_event): Update comment.
12845
12846 2019-01-23  Tom Tromey  <tom@tromey.com>
12847             Pedro Alves  <palves@redhat.com>
12848
12849         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12850         parameter.
12851         (fetch_inferior_event): Use SCOPE_EXIT.
12852
12853
12854 2019-01-23  Tom Tromey  <tom@tromey.com>
12855             Pedro Alves  <palves@redhat.com>
12856
12857         * infrun.c (disable_thread_events): Delete.
12858         (stop_all_threads): Use SCOPE_EXIT.
12859
12860 2019-01-23  Tom Tromey  <tom@tromey.com>
12861             Pedro Alves  <palves@redhat.com>
12862
12863         * symfile.c: Include forward-scope-exit.h.
12864         (clear_symtab_users_cleanup): Replace forward declaration with
12865         a FORWARD_SCOPE_EXIT.
12866         (syms_from_objfile_1): Use the forward_scope_exit and
12867         gdb::optional instead of cleanup_function.
12868         (reread_symbols): Use the forward_scope_exit instead of
12869         cleanup_function.
12870         (clear_symtab_users_cleanup): Remove function.
12871
12872 2019-01-23  Tom Tromey  <tom@tromey.com>
12873             Pedro Alves  <palves@redhat.com>
12874
12875         * linux-nat.c: Include scope-exit.h.
12876         (cleanup_target_stop): Remove.
12877         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12878         SCOPE_EXIT.
12879
12880 2019-01-23  Tom Tromey  <tom@tromey.com>
12881             Pedro Alves  <palves@redhat.com>
12882
12883         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12884         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12885
12886 2019-01-23  Tom Tromey  <tom@tromey.com>
12887             Andrew Burgess  <andrew.burgess@embecosm.com>
12888             Pedro Alves  <palves@redhat.com>
12889
12890         * infrun.c (fetch_inferior_event): Use scope_exit.
12891         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12892         * top.c (execute_command): Use scope_exit.
12893         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12894         * utils.c (do_bpstat_clear_actions_cleanup)
12895         (make_bpstat_clear_actions_cleanup): Remove.
12896
12897 2019-01-23  Tom Tromey  <tom@tromey.com>
12898             Pedro Alves  <palves@redhat.com>
12899
12900         * infrun.c: Include "common/scope-exit.h"
12901         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12902         (wait_for_inferior): Use SCOPE_EXIT.
12903         (fetch_inferior_event): Use scope_exit.
12904
12905 2019-01-23  Tom Tromey  <tom@tromey.com>
12906             Pedro Alves  <palves@redhat.com>
12907
12908         * breakpoint.c (create_breakpoint): Remove cleanup.
12909
12910 2019-01-23  Tom Tromey  <tom@tromey.com>
12911             Andrew Burgess  <andrew.burgess@embecosm.com>
12912             Pedro Alves  <palves@redhat.com>
12913
12914 2019-01-23  Pedro Alves  <palves@redhat.com>
12915
12916         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12917
12918 2019-01-23  Pedro Alves  <palves@redhat.com>
12919             Andrew Burgess  <andrew.burgess@embecosm.com>
12920
12921         * gdbthread.h: Include "common/forward-scope-exit.h".
12922         (scoped_finish_thread_state): Redefine custom class in terms of
12923         forward_scope_exit.
12924
12925 2019-01-23  Pedro Alves  <palves@redhat.com>
12926             Andrew Burgess  <andrew.burgess@embecosm.com>
12927
12928         * common/forward-scope-exit.h: New file.
12929
12930 2019-01-23  Pedro Alves  <palves@redhat.com>
12931             Andrew Burgess  <andrew.burgess@embecosm.com>
12932             Tom Tromey  <tom@tromey.com>
12933
12934         * common/scope-exit.h: New file.
12935
12936 2019-01-23  Pedro Alves  <palves@redhat.com>
12937
12938         * common/preprocessor.h (ESC): Rename to ...
12939         (ESC_PARENS): ... this.
12940         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12941         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12942
12943 2019-01-23  Tom Tromey  <tom@tromey.com>
12944
12945         * language.h (class scoped_switch_to_sym_language_if_auto):
12946         Initialize m_lang in both cases.
12947
12948 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12949
12950         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12951         with XCNEW.
12952
12953 2019-01-22  Tom Tromey  <tom@tromey.com>
12954
12955         * corelow.c: Do not include sys/file.h.
12956
12957 2019-01-22  Tom Tromey  <tom@tromey.com>
12958
12959         * tui/tui-wingeneral.h: Include gdb_curses.h.
12960
12961 2019-01-22  Tom Tromey  <tom@tromey.com>
12962
12963         * source-cache.h (class source_cache) <get_source_lines,
12964         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12965
12966 2019-01-22  Tom Tromey  <tom@tromey.com>
12967
12968         * remote-fileio.h (struct remote_target): Declare.
12969
12970 2019-01-22  Tom Tromey  <tom@tromey.com>
12971
12972         * python/py-arch.c: Do not include py-ref.h.
12973         * python/py-bpevent.c: Do not include py-ref.h.
12974         * python/py-cmd.c: Do not include py-ref.h.
12975         * python/py-continueevent.c: Do not include py-ref.h.
12976         * python/py-event.h: Do not include py-ref.h.
12977         * python/py-evtregistry.c: Do not include py-ref.h.
12978         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12979         * python/py-frame.c: Do not include py-ref.h.
12980         * python/py-framefilter.c: Do not include py-ref.h.
12981         * python/py-function.c: Do not include py-ref.h.
12982         * python/py-infevents.c: Do not include py-ref.h.
12983         * python/py-linetable.c: Do not include py-ref.h.
12984         * python/py-objfile.c: Do not include py-ref.h.
12985         * python/py-param.c: Do not include py-ref.h.
12986         * python/py-prettyprint.c: Do not include py-ref.h.
12987         * python/py-progspace.c: Do not include py-ref.h.
12988         * python/py-symbol.c: Do not include py-ref.h.
12989         * python/py-symtab.c: Do not include py-ref.h.
12990         * python/py-type.c: Do not include py-ref.h.
12991         * python/py-unwind.c: Do not include py-ref.h.
12992         * python/py-utils.c: Do not include py-ref.h.
12993         * python/py-value.c: Do not include py-ref.h.
12994         * python/py-varobj.c: Do not include py-ref.h.
12995         * python/py-xmethods.c: Do not include py-ref.h.
12996         * python/python.c: Do not include py-ref.h.
12997         * varobj.c: Do not include py-ref.h.
12998
12999 2019-01-22  Tom Tromey  <tom@tromey.com>
13000
13001         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13002         keyword for bcache.
13003
13004 2019-01-22  Tom Tromey  <tom@tromey.com>
13005
13006         * compile/compile-cplus-types.c: Remove a comment by #include.
13007
13008 2019-01-22  Tom Tromey  <tom@tromey.com>
13009
13010         * compile/gcc-c-plugin.h: Include compile-internal.h.
13011
13012 2019-01-22  Tom Tromey  <tom@tromey.com>
13013
13014         * stabsread.c (EXTERN): Do not define.
13015         (symnum, next_symbol_text_func, processing_gcc_compilation)
13016         (within_function, global_sym_chain, global_stabs)
13017         (previous_stab_code, this_object_header_files)
13018         (n_this_object_header_files)
13019         (n_allocated_this_object_header_files): Define.
13020         * stabsread.h (EXTERN): Never define.  Use "extern".
13021
13022 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13023
13024         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13025         history_value.
13026
13027 2019-01-21  Tom Tromey  <tom@tromey.com>
13028
13029         * ui-out.c: Fix includes.
13030         * tui/tui-source.c: Fix includes.
13031         * target.c: Fix includes.
13032         * remote.c: Fix includes.
13033         * regcache.c: Fix includes.
13034         * python/py-block.c: Fix includes.
13035         * printcmd.c: Fix includes.
13036         * or1k-tdep.c: Fix includes.
13037         * mi/mi-main.c: Fix includes.
13038         * m32r-tdep.c: Fix includes.
13039         * csky-tdep.c: Fix includes.
13040         * compile/compile-cplus-types.c: Fix includes.
13041         * cli/cli-interp.c: Fix includes.
13042
13043 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13044
13045         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13046         for padding.
13047
13048 2019-01-16  Tom Tromey  <tom@tromey.com>
13049
13050         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13051         earlier.
13052         (struct objfile) <msymbols_range>: Move from top level.
13053         <msymbols>: New method.
13054         (class objfile_msymbols): Remove.
13055         * symtab.c (default_collect_symbol_completion_matches_break_on):
13056         Update.
13057         * symmisc.c (dump_msymbols): Update.
13058         * stabsread.c (scan_file_globals): Update.
13059         * objc-lang.c (info_selectors_command, info_classes_command)
13060         (find_methods): Update.
13061         * minsyms.c (find_solib_trampoline_target): Update.
13062         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13063         * coffread.c (coff_symfile_read): Update.
13064         * ada-lang.c (ada_lookup_simple_minsym)
13065         (ada_collect_symbol_completion_matches): Update.
13066
13067 2019-01-16  Tom Tromey  <tom@tromey.com>
13068
13069         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13070         type.  Remove no-argument constructor.
13071         <iterator::operator++>: Simplify.
13072         <begin>: Update.
13073         <end>: Use minimal_symbol_count.
13074
13075 2019-01-16  Tom Tromey  <tom@tromey.com>
13076
13077         * objfiles.h (struct objfile) <psymtabs>: New method.
13078         (class objfile_psymtabs): Remove.
13079         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13080         typedef.
13081         <range>: New method.
13082         (require_partial_symbols): Change return type.
13083         * psymtab.c (require_partial_symbols)
13084         (psym_expand_symtabs_matching): Update.
13085         * mdebugread.c (parse_partial_symbols): Update.
13086         * dbxread.c (dbx_end_psymtab): Update.
13087
13088 2019-01-15  Tom Tromey  <tom@tromey.com>
13089
13090         * symtab.c (lookup_objfile_from_block)
13091         (lookup_symbol_in_objfile_symtabs)
13092         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13093         (find_line_symtab, info_sources_command)
13094         (default_collect_symbol_completion_matches_break_on)
13095         (make_source_files_completion_list): Update.
13096         * symmisc.c (print_objfile_statistics, dump_objfile)
13097         (maintenance_print_symbols, maintenance_info_symtabs)
13098         (maintenance_check_symtabs, maintenance_info_line_tables):
13099         Update.
13100         * source.c (select_source_symtab)
13101         (forget_cached_source_info_for_objfile): Update.
13102         * objfiles.h (class objfile_compunits): Remove.
13103         (struct objfile) <compunits_range>: New typedef.
13104         (compunits): New method.
13105         * objfiles.c (objfile_relocate1): Update.
13106         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13107         * maint.c (count_symtabs_and_blocks): Update.
13108         * linespec.c (iterate_over_all_matching_symtabs): Update.
13109         * cp-support.c (add_symbol_overload_list_qualified): Update.
13110         * coffread.c (coff_symtab_read): Update.
13111         * ada-lang.c (add_nonlocal_symbols)
13112         (ada_collect_symbol_completion_matches)
13113         (ada_add_global_exceptions): Update.
13114
13115 2019-01-15  Tom Tromey  <tom@tromey.com>
13116
13117         * progspace.h (program_space) <objfiles_safe_range>: New
13118         typedef.
13119         <objfiles_safe>: New method.
13120         * objfiles.h (class all_objfiles_safe): Remove.
13121         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13122         * jit.c (jit_inferior_exit_hook): Update.
13123
13124 2019-01-17  Tom Tromey  <tom@tromey.com>
13125
13126         * progspace.h (program_space) <objfiles_range>: New typedef.
13127         <objfiles>: New method.
13128         <objfiles_head>: Rename from objfiles.
13129         (object_files): Update.
13130         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13131         * guile/scm-pretty-print.c
13132         (ppscm_find_pretty_printer_from_objfiles): Update.
13133         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13134         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13135         Update.
13136         * python/py-progspace.c (pspy_get_objfiles): Update.
13137         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13138         Update.
13139         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13140         (objfpy_lookup_objfile_by_build_id): Update.
13141         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13142         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13143         Update.
13144         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13145         (expand_symtab_containing_pc, lookup_objfile_from_block)
13146         (lookup_static_symbol, basic_lookup_transparent_type)
13147         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13148         (find_line_symtab, info_sources_command)
13149         (default_collect_symbol_completion_matches_break_on)
13150         (make_source_files_completion_list, find_main_name): Update.
13151         * symmisc.c (print_symbol_bcache_statistics)
13152         (print_objfile_statistics, maintenance_print_symbols)
13153         (maintenance_print_msymbols, maintenance_print_objfiles)
13154         (maintenance_info_symtabs, maintenance_check_symtabs)
13155         (maintenance_expand_symtabs, maintenance_info_line_tables):
13156         Update.
13157         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13158         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13159         (map_overlay_command, unmap_overlay_command)
13160         (simple_overlay_update, expand_symtabs_matching)
13161         (map_symbol_filenames): Update.
13162         * symfile-debug.c (set_debug_symfile): Update.
13163         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13164         Update.
13165         * source.c (select_source_symtab, forget_cached_source_info):
13166         Update.
13167         * solib.c (solib_read_symbols): Update.
13168         * solib-spu.c (append_ocl_sos): Update.
13169         * psymtab.c (maintenance_print_psymbols)
13170         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13171         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13172         * printcmd.c (info_symbol_command): Update.
13173         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13174         Update.
13175         * objfiles.h (class all_objfiles): Remove.
13176         * objfiles.c (have_partial_symbols, have_full_symbols)
13177         (have_minimal_symbols, qsort_cmp, update_section_map)
13178         (shared_objfile_contains_address_p)
13179         (default_iterate_over_objfiles_in_search_order): Update.
13180         * objc-lang.c (info_selectors_command, info_classes_command)
13181         (find_methods): Update.
13182         * minsyms.c (find_solib_trampoline_target): Update.
13183         * maint.c (maintenance_info_sections)
13184         (maintenance_translate_address, count_symtabs_and_blocks):
13185         Update.
13186         * main.c (captured_main_1): Update.
13187         * linux-thread-db.c (try_thread_db_load_from_pdir)
13188         (has_libpthread): Update.
13189         * linespec.c (iterate_over_all_matching_symtabs)
13190         (search_minsyms_for_name): Update.
13191         * jit.c (jit_find_objf_with_entry_addr): Update.
13192         * hppa-tdep.c (find_unwind_entry)
13193         (hppa_lookup_stub_minimal_symbol): Update.
13194         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13195         Update.
13196         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13197         (elf_gnu_ifunc_resolve_by_got): Update.
13198         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13199         * dwarf-index-write.c (save_gdb_index_command): Update.
13200         * cp-support.c (add_symbol_overload_list_qualified): Update.
13201         * breakpoint.c (create_overlay_event_breakpoint)
13202         (create_longjmp_master_breakpoint)
13203         (create_std_terminate_master_breakpoint)
13204         (create_exception_master_breakpoint): Update.
13205         * blockframe.c (find_pc_partial_function): Update.
13206         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13207         (ada_collect_symbol_completion_matches)
13208         (ada_add_global_exceptions): Update.
13209
13210 2019-01-17  Tom Tromey  <tom@tromey.com>
13211
13212         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13213         declare VEC.
13214         (solib_target_parse_libraries): Change return type.
13215         (library_list_start_segment, library_list_start_section)
13216         (library_list_end_library, library_list_start_library); Update.
13217         (solib_target_free_library_list): Remove.
13218         (solib_target_parse_libraries): Remove cleanup.  Change return
13219         type.
13220         (solib_target_current_sos): Update.
13221
13222 2019-01-17  Tom Tromey  <tromey@bapiya>
13223
13224         * valprint.c: Replace "the the" with "the".
13225         * symtab.c: Replace "the the" with "the".
13226         * solib.c: Replace "the the" with "the".
13227         * solib-dsbt.c: Replace "the the" with "the".
13228         * linespec.c: Replace "the the" with "the".
13229         * dwarf2loc.h: Replace "the the" with "the".
13230         * amd64-windows-tdep.c: Replace "the the" with "the".
13231         * aarch64-tdep.c: Replace "the the" with "the".
13232
13233 2019-01-16  Keith Seitz  <keiths@redhat.com>
13234
13235         PR gdb/23773
13236         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13237         <builder>: Rename to ..
13238         <m_builder>: ... this and make private.
13239         (dwarf2_cu::get_builder): New method.  Change all users of
13240         `builder' to use this method.
13241         (dwarf2_start_symtab): Move to ...
13242         (dwarf2_cu::start_symtab): ... here.  Update all callers
13243         (setup_type_unit_groups): Move to ...
13244         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13245         callers.
13246         (dwarf2_cu::reset_builder): New method.
13247         (process_full_compunit, process_full_type_unit): Use
13248         dwarf2_cu::reset_builder.
13249         (follow_die_offset): Record the ancestor CU if it is different
13250         from the followed DIE's CU.
13251         (follow_die_sig_1): Likewise.
13252
13253 2019-01-15  Tom Tromey  <tom@tromey.com>
13254
13255         * remote.c (class remote_state) <buf>: Now a char_vector.
13256         <buf_size>: Remove.
13257         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13258         parameter.
13259         (remote_target::getpkt_or_notif_sane_1)
13260         (remote_target::getpkt_sane)
13261         (remote_target::getpkt_or_notif_sane): Likewise.
13262         (class remote_target) <putpkt>: New overload.
13263         (remote_target::read_frame): Change type of "buf_p".  Remove
13264         sizeof_p parameter.
13265         (packet_ok): New overload.
13266         (packet_check_result): New overload.
13267         Update all uses.
13268
13269 2019-01-14  Tom Tromey  <tom@tromey.com>
13270
13271         * remote-notif.c (handle_notification, remote_notif_ack)
13272         (remote_notif_parse): Make "buf" const.
13273         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13274         const.
13275         (remote_notif_parse, remote_notif_ack, handle_notification):
13276         Likewise.
13277         * remote.c (remote_notif_stop_parse): Make "buf" const.
13278         (remote_target::remote_parse_stop_reply): Make "buf" const.
13279         (remote_notif_stop_ack): Make "buf" const.
13280
13281 2019-01-14  Tom Tromey  <tom@tromey.com>
13282
13283         * remote.c (remote_console_output): Make parameter const.
13284
13285 2019-01-14  Tom Tromey  <tom@tromey.com>
13286
13287         * target-debug.h (target_debug_print_signals): Constify.
13288         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13289         * procfs.c (procfs_target::pass_signals): Update.
13290         * linux-nat.c (linux_nat_target::pass_signals): Update.
13291         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13292         * target-delegates.c: Rebuild.
13293         * remote.c (remote_target::program_signals): Update.
13294         (remote_target::pass_signals): Update.
13295         * target.c (target_pass_signals): Constify argument.
13296         (target_program_signals): Likewise.
13297         * target.h (struct target_ops) <pass_signals, program_signals>:
13298         Constify argument.
13299         (target_pass_signals, target_program_signals): Constify argument.
13300
13301 2019-01-14  Tom Tromey  <tom@tromey.com>
13302
13303         PR tui/28819:
13304         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13305
13306 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13307
13308         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13309         field.
13310         * rs6000-tdep.c: Include reggroups.h.
13311         (IS_V_ALIAS_PSEUDOREG): Define.
13312         (rs6000_register_name): Return names for the "vX" aliases.
13313         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13314         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13315         aliases.  Call default_register_reggroup_p for all other
13316         pseudo-registers.
13317         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13318         New functions.
13319         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13320         Handle "vX" aliases.
13321         (v_alias_pseudo_register_collect): New function.
13322         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13323         (rs6000_gdbarch_init): Initialize "vX" aliases as
13324         pseudo-registers.  Restore registration of
13325         rs6000_pseudo_register_reggroup_p with
13326         set_tdesc_pseudo_register_reggroup_p.
13327
13328 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13329
13330         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13331         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13332         set_gdbarch_num_pseudo_regs.
13333
13334 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13335
13336         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13337         Remove arg prefixname, add do_set and do_show.
13338         Add member functions set_list and show_list.
13339         * cli/cli-style.c (class cli_style_option): Update accordingly.
13340         (style_set_list): Move to file scope.
13341         (style_show_list): Likewise.
13342         (set_style): Call help_list.
13343         (show_style): Call cmd_show_list.
13344         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13345         Update to use the new macro.
13346
13347 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13348
13349         * ada-lang.c (_initialize_ada_language): Expand the help text
13350         for the "catch exception" command.
13351
13352 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13353
13354         * symtab.c (matching_obj_sections): Initialize obj,
13355         declare it closer to its usage.
13356
13357 2019-01-10  Tom Tromey  <tom@tromey.com>
13358
13359         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13360         (basic_inf_threads_range): Remove.
13361         (inf_threads_range, inf_non_exited_threads_range)
13362         (safe_inf_threads_range): Use next_adapter.
13363
13364 2019-01-10  Keith Seitz  <keiths@redhat.com>
13365
13366         PR gdb/23712
13367         PR symtab/23010
13368         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13369         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13370
13371 2019-01-10  Keith Seitz  <keiths@redhat.com>
13372
13373         PR gdb/23712
13374         PR symtab/23010
13375         * dictionary.c (pending_to_vector): Remove.
13376         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13377         Remove _1 suffix, replacing functions of the same name.  Update
13378         all callers.
13379         (dict_create_hashed, dict_create_hashed_expandable)
13380         (dict_create_linear, dict_create_linear_expandable, dict_free)
13381         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13382         Make functions static.
13383
13384 2019-01-10  Keith Seitz  <keiths@redhat.com>
13385
13386         PR gdb/23712
13387         PR symtab/23010
13388         * dictionary.h (struct dictionary): Replace declaration with
13389         multidictionary.
13390         (dict_create_hashed, dict_create_hashed_expandable)
13391         (dict_create_linear, dict_create_linear_expandable)
13392         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13393         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13394         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13395         taking multidictionary argument.
13396         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13397         * block.h (struct block) <dict>: Change to multidictionary
13398         and rename `multidict'.
13399         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13400         symmisc.c: Update all dictionary references to multidictionary.
13401
13402 2019-01-10  Keith Seitz  <keiths@redhat.com>
13403
13404         PR gdb/23712
13405         PR symtab/23010
13406         * dictionary.c: Include unordered_map.
13407         (pending_to_vector): New function.
13408         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13409         Rewrite the non-"_1" functions to take vector instead
13410         of linked list.
13411         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13412         "new" _1 versions of the same name.
13413         (multidictionary): Define.
13414         (std::hash<enum language): New definition.
13415         (collate_pending_symbols_by_language, mdict_create_hashed)
13416         (mdict_create_hashed_expandable, mdict_create_linear)
13417         (mdict_create_linear_expandable, mdict_free)
13418         (find_language_dictionary, create_new_language_dictionary)
13419         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13420         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13421         (mdict_size, mdict_empty): New functions.
13422         * dictionary.h (mdict_iterator): Define.
13423
13424 2019-01-10  Pedro Alves  <palves@redhat.com>
13425
13426         * breakpoint.c (read_uploaded_action)
13427         (create_tracepoint_from_upload): Adjust to use
13428         gdb::unique_xmalloc_ptr.
13429         * ctf.c (ctf_write_uploaded_tp):
13430         (SET_ARRAY_FIELD): Use emplace_back.
13431         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13432         * tracefile-tfile.c (tfile_write_uploaded_tp):
13433         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13434         gdb::unique_xmalloc_ptr.
13435         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13436         at_string, cond_string, cmd_strings>: Replace char pointers
13437         with gdb::unique_xmalloc_ptr.
13438
13439 2019-01-10  Pedro Alves  <palves@redhat.com>
13440
13441         * solib-target.c (library_list_start_library): Don't xstrdup name.
13442
13443 2019-01-10  Pedro Alves  <palves@redhat.com>
13444
13445         * mdebugread.c (parse_partial_symbols): Use
13446         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13447
13448 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13449
13450         * linux-fork.c (scoped_switch_fork_info)
13451         <~scoped_switch_fork_info>: Fix incorrect variable name.
13452
13453 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13454
13455         * linux-fork.c (scoped_switch_fork_info)
13456         <scoped_switch_fork_info>: Make explicit.
13457         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13458
13459 2019-01-10  Tom Tromey  <tom@tromey.com>
13460
13461         * objfiles.h (objfile::reset_psymtabs): Update.
13462         * objfiles.c (objfile::objfile): Update.
13463         * psymtab.h (psymtab_storage::obstack): Update.
13464         (psymtab_storage::m_obstack): Use gdb::optional.
13465         (class psymtab_storage): Update comment.  Remove objfile
13466         parameter.
13467         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13468
13469 2019-01-10  Tom Tromey  <tom@tromey.com>
13470
13471         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13472         <free_psymtabs>: Now private.
13473         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13474         (allocate_psymtab): Use new method.
13475
13476 2019-01-10  Tom Tromey  <tom@tromey.com>
13477
13478         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13479         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13480         * mdebugread.c (parse_partial_symbols): Use
13481         allocate_dependencies.
13482         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13483         allocate_dependencies.
13484         (process_psymtab_comp_unit_reader)
13485         (build_type_psymtab_dependencies): Likewise.
13486         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13487
13488 2019-01-10  Tom Tromey  <tom@tromey.com>
13489
13490         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13491         PSYMBOL_SET_LANGUAGE.
13492         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13493
13494 2019-01-10  Tom Tromey  <tom@tromey.com>
13495
13496         * psymtab.h (psymtab_storage::obstack): New method.
13497         <m_obstack>: Rename from obstack; now private.
13498         * psymtab.c (psymtab_storage): Update.
13499         * dwarf2read.c (create_addrmap_from_index)
13500         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13501         Update.
13502
13503 2019-01-10  Tom Tromey  <tom@tromey.com>
13504
13505         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13506         * objfiles.h (objfile::reset_psymtabs): New method.
13507
13508 2019-01-10  Tom Tromey  <tom@tromey.com>
13509
13510         * symmisc.c (print_symbol_bcache_statistics): Update.
13511         (print_objfile_statistics): Update.
13512         * symfile.c (reread_symbols): Update.
13513         * psymtab.h (class psymtab_storage): New.
13514         * psymtab.c (psymtab_storage): New constructor.
13515         (~psymtab_storage): New destructor.
13516         (require_partial_symbols): Update.
13517         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13518         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13519         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13520         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13521         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13522         (start_psymtab_common, end_psymtab_common)
13523         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13524         (allocate_psymtab): Update.
13525         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13526         Update.
13527         (dump_psymtab_addrmap, maintenance_print_psymbols)
13528         (maintenance_check_psymtabs): Update.
13529         (class objfile_psymtabs): Move to objfiles.h.
13530         * psympriv.h (discard_psymtab): Now inline.
13531         (psymtab_discarder::psymtab_discarder): Update.
13532         (psymtab_discarder::~psymtab_discarder): Update.
13533         (ALL_OBJFILE_PSYMTABS): Rewrite.
13534         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13535         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13536         Remove fields.
13537         <partial_symtabs>: New field.
13538         (class objfile_psymtabs): Move from psymtab.h.  Update.
13539         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13540         psymbol_cache.
13541         (objfile::~objfile): Don't destroy psymbol_cache.
13542         * mdebugread.c (parse_partial_symbols): Update.
13543         * dwarf2read.c (create_addrmap_from_index)
13544         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13545         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13546         (add_partial_subprogram, dwarf2_ranges_read): Update.
13547         * dwarf-index-write.c (write_address_map)
13548         (write_one_signatured_type, recursively_write_psymbols)
13549         (class debug_names, class debug_names, write_psymtabs_to_index):
13550         Update.
13551
13552 2019-01-10  Tom Tromey  <tom@tromey.com>
13553
13554         * symtab.h (SYMBOL_SET_NAMES): Update.
13555         (symbol_set_names): Update.
13556         (MSYMBOL_SET_NAMES): Update.
13557         * symtab.c (symbol_set_names): Change argument to be an
13558         objfile_per_bfd_storage.
13559         * psymtab.c (add_psymbol_to_bcache): Update.
13560         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13561
13562 2019-01-10  Tom Tromey  <tom@tromey.com>
13563
13564         * symtab.c (create_demangled_names_hash): Change argument to be an
13565         objfile_per_bfd_storage.
13566         (symbol_set_names): Update.
13567
13568 2019-01-10  Tom Tromey  <tom@tromey.com>
13569
13570         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13571         init_psymbol_list.
13572         * psymtab.c (init_psymbol_list): Do nothing if already called.
13573         * psympriv.h (init_psymbol_list): Add comment.
13574         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13575         init_psymbol_list.
13576         * dbxread.c (dbx_symfile_read): Unconditionally call
13577         init_psymbol_list.
13578
13579 2019-01-10  Tom Tromey  <tom@tromey.com>
13580
13581         * xcoffread.c (scan_xcoff_symtab): Update.
13582         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13583         "where".
13584         * mdebugread.c (parse_partial_symbols)
13585         (handle_psymbol_enumerators): Update.
13586         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13587         * dbxread.c (read_dbx_symtab): Update.
13588         * psympriv.h (psymbol_placement): New enum.
13589         (add_psymbol_to_list): Update.
13590
13591 2019-01-10  Tom Tromey  <tom@tromey.com>
13592
13593         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13594         static_psymbols parameters.
13595         (scan_xcoff_symtab): Update.
13596         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13597         static_psymbols parameters.
13598         * psympriv.h (start_psymtab_common): Update.
13599         * mdebugread.c (parse_partial_symbols): Update.
13600         * dwarf2read.c (create_partial_symtab): Update.
13601         * dbxread.c (read_dbx_symtab): Update.
13602         (start_psymtab): Remove global_psymbols and static_psymbols
13603         parameters.
13604
13605 2019-01-10  Tom Tromey  <tom@tromey.com>
13606
13607         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13608         * psymtab.c (allocate_psymtab): Add comment.
13609         * psympriv.h (allocate_psymtab): Add comment.
13610         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13611         initializations.
13612         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13613
13614 2019-01-10  Tom Tromey  <tom@tromey.com>
13615
13616         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13617         Don't declare.
13618         * mipsread.c: Include mdebugread.h.
13619         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13620         Declare.
13621         * elfread.c: Include mdebugread.h.
13622
13623 2019-01-09  Tom Tromey  <tom@tromey.com>
13624
13625         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13626         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13627         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13628         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13629         (psym_lookup_symbol, psym_find_last_source_symtab)
13630         (psym_forget_cached_source_info, psym_print_stats)
13631         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13632         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13633         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13634         (psym_find_compunit_symtab_by_address)
13635         (maintenance_print_psymbols, maintenance_info_psymtabs)
13636         (maintenance_check_psymtabs): Use ranged for.
13637         * psymtab.h (class objfile_psymtabs): New.
13638         (require_partial_symbols): Return objfile_psymtabs.
13639         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13640
13641 2019-01-09  Tom Tromey  <tom@tromey.com>
13642
13643         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13644         (find_pc_mapped_section, list_overlays_command)
13645         (map_overlay_command, unmap_overlay_command)
13646         (simple_overlay_update): Use all_objfiles.
13647         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13648         * printcmd.c (info_symbol_command): Use all_objfiles.
13649         * objfiles.h (ALL_OBJSECTIONS): Remove.
13650         * maint.c (maintenance_translate_address): Use all_objfiles.
13651         * gcore.c (gcore_create_callback): Use all_objfiles.
13652         (objfile_find_memory_regions): Likewise.
13653
13654 2019-01-09  Tom Tromey  <tom@tromey.com>
13655
13656         * symtab.c (find_line_symtab, info_sources_command)
13657         (make_source_files_completion_list): Use objfile_compunits.
13658         * source.c (select_source_symtab): Use objfile_compunits.
13659         * objfiles.h (struct objfile): Update comment.
13660         (ALL_OBJFILES): Remove.
13661         (ALL_FILETABS): Remove.
13662         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13663         objfile_compunits.
13664
13665 2019-01-09  Tom Tromey  <tom@tromey.com>
13666
13667         * symmisc.c (print_objfile_statistics, dump_objfile)
13668         (maintenance_print_symbols): Use compunit_filetabs.
13669         * source.c (forget_cached_source_info_for_objfile): Use
13670         compunit_filetabs.
13671         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13672         (ALL_FILETABS): Use compunit_filetabs.
13673         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13674         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13675
13676 2019-01-09  Tom Tromey  <tom@tromey.com>
13677
13678         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13679         (compunit_filetabs): New.
13680         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13681         compunit_filetabs.
13682         (info_sources_command, make_source_files_completion_list): Remove
13683         declaration.
13684         * symmisc.c (print_objfile_statistics, dump_objfile)
13685         (maintenance_print_symbols): Remove declaration.
13686         (maintenance_info_symtabs): Use compunit_filetabs.
13687         (maintenance_info_line_tables): Likewise.
13688         * source.c (select_source_symtab): Change local variable name.
13689         (forget_cached_source_info_for_objfile): Remove declaration.
13690         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13691         * objfiles.c (objfile_relocate1): Remove declaration.
13692         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13693         declaration.
13694         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13695         * coffread.c (coff_symtab_read): Remove declaration.
13696         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13697         compunit_filetabs.
13698
13699 2019-01-09  Tom Tromey  <tom@tromey.com>
13700
13701         * symtab.c (lookup_objfile_from_block)
13702         (find_pc_sect_compunit_symtab, search_symbols)
13703         (default_collect_symbol_completion_matches_break_on): Use
13704         objfile_compunits.
13705         * objfiles.h (ALL_COMPUNITS): Remove.
13706         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13707         * cp-support.c (add_symbol_overload_list_qualified): Use
13708         objfile_compunits.
13709         * ada-lang.c (ada_collect_symbol_completion_matches)
13710         (ada_add_global_exceptions): Use objfile_compunits.
13711
13712 2019-01-09  Tom Tromey  <tom@tromey.com>
13713
13714         * source.c (select_source_symtab)
13715         (forget_cached_source_info_for_objfile): Remove declaration.
13716         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13717         declaration.
13718         * maint.c (count_symtabs_and_blocks): Remove declaration.
13719         * cp-support.c (add_symbol_overload_list_qualified): Remove
13720         declaration.
13721         * coffread.c (coff_symtab_read): Remove declaration.
13722         * symtab.c (lookup_symbol_in_objfile_symtabs)
13723         (basic_lookup_transparent_type_1): Use objfile_compunits.
13724         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13725         (info_sources_command, search_symbols)
13726         (default_collect_symbol_completion_matches_break_on)
13727         (make_source_files_completion_list): Remove declaration.
13728         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13729         (ada_collect_symbol_completion_matches)
13730         (ada_add_global_exceptions): Remove declaration.
13731         * linespec.c (iterate_over_all_matching_symtabs): Use
13732         objfile_compunits.
13733         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13734         (class objfile_compunits): New.
13735         (ALL_COMPUNITS): Use objfile_compunits.
13736         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13737         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13738         objfile_compunits.
13739         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13740
13741 2019-01-09  Tom Tromey  <tom@tromey.com>
13742
13743         * symtab.c (search_symbols)
13744         (default_collect_symbol_completion_matches_break_on): Use
13745         objfile_msymbols.
13746         * ada-lang.c (ada_lookup_simple_minsym)
13747         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13748         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13749         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13750         objfile_msymbols.
13751         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13752         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13753         * objc-lang.c (find_methods): Use objfile_msymbols.
13754         (info_selectors_command, info_classes_command): Likewise.
13755         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13756         * objfiles.h (class objfile_msymbols): New.
13757         (ALL_OBJFILE_MSYMBOLS): Remove.
13758         (ALL_MSYMBOLS): Remove.
13759
13760 2019-01-09  Tom Tromey  <tom@tromey.com>
13761
13762         * common/next-iterator.h (next_adapter): Add Iterator template
13763         parameter.
13764         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13765         (class all_objfiles_safe): New.
13766         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13767         * objfiles.c (put_objfile_before): Update comment.
13768         (add_separate_debug_objfile): Likewise.
13769         (free_all_objfiles): Use all_objfiles_safe.
13770         (objfile_purge_solibs): Likewise.
13771
13772 2019-01-09  Tom Tromey  <tom@tromey.com>
13773
13774         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13775         (expand_symtab_containing_pc, lookup_static_symbol)
13776         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13777         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13778         all_objfiles.
13779         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13780         * breakpoint.c (create_overlay_event_breakpoint)
13781         (create_longjmp_master_breakpoint)
13782         (create_std_terminate_master_breakpoint)
13783         (create_exception_master_breakpoint): Use all_objfiles.
13784         * linux-thread-db.c (try_thread_db_load_from_pdir)
13785         (has_libpthread): Use all_objfiles.
13786         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13787         * linespec.c (iterate_over_all_matching_symtabs)
13788         (search_minsyms_for_name): Use all_objfiles.
13789         * maint.c (maintenance_info_sections): Use all_objfiles.
13790         * main.c (captured_main_1): Use all_objfiles.
13791         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13792         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13793         * guile/scm-pretty-print.c
13794         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13795         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13796         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13797         (maintenance_print_msymbols): Use all_objfiles.
13798         * source.c (select_source_symtab): Use all_objfiles.
13799         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13800         * symfile.c (remove_symbol_file_command)
13801         (expand_symtabs_matching, map_symbol_filenames): Use
13802         all_objfiles.
13803         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13804         all_objfiles.
13805         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13806         * objc-lang.c (find_methods): Use all_objfiles.
13807         * objfiles.c (have_partial_symbols, have_full_symbols)
13808         (have_minimal_symbols, qsort_cmp)
13809         (default_iterate_over_objfiles_in_search_order): Use
13810         all_objfiles.
13811         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13812         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13813         (maintenance_check_psymtabs): Use all_objfiles.
13814         (ALL_PSYMTABS): Remove.
13815         * compile/compile-object-run.c (do_module_cleanup): Use
13816         all_objfiles.
13817         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13818         * cp-support.c (add_symbol_overload_list_qualified): Use
13819         all_objfiles.
13820         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13821         Use all_objfiles.
13822         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13823         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13824         all_objfiles.
13825         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13826         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13827         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13828         Uses all_objfiles.
13829         * solib.c (solib_read_symbols): Use all_objfiles
13830
13831 2019-01-09  Tom Tromey  <tom@tromey.com>
13832
13833         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13834         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13835         all_objfiles.
13836         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13837         * symmisc.c (print_symbol_bcache_statistics)
13838         (print_objfile_statistics, maintenance_print_objfiles)
13839         (maintenance_info_symtabs, maintenance_check_symtabs)
13840         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13841         all_objfiles.
13842         * source.c (forget_cached_source_info): Use all_objfiles.
13843         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13844         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13845         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13846         * objfiles.c (update_section_map): Use all_objfiles.
13847         (shared_objfile_contains_address_p): Likewise.
13848         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13849         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13850
13851 2019-01-09  Tom Tromey  <tom@tromey.com>
13852
13853         * common/next-iterator.h: New file.
13854         * objfiles.h (class all_objfiles): New.
13855         (struct objfile_iterator): New.
13856
13857 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13858
13859         * NEWS: Move the description of the changed "frame", "select-frame",
13860          and "info frame" commands to the Changed commands section.
13861
13862 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13863
13864         * gdbtypes.c (check_stub_method_group): Remove handling of old
13865         mangling schemes.
13866         * linespec.c (find_methods): Likewise.
13867         * stabsread.c (read_member_functions): Likewise.
13868         * valops.c (search_struct_method): Likewise.
13869         (value_struct_elt_for_reference): Likewise.
13870         * NEWS: Mention this change.
13871
13872 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13873
13874         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13875         print_source_lines.
13876         * source.c (print_source_lines_base): Update line number check.
13877         (print_source_lines): New function.
13878         (source_lines_range::source_lines_range): New function.
13879         * source.h (class source_lines_range): New class.
13880         (print_source_lines): New declaration.
13881
13882 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13883
13884         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13885
13886 2019-01-08  Tom Tromey  <tom@tromey.com>
13887             Simon Marchi  <simon.marchi@ericsson.com>
13888
13889         PR gdb/24060
13890         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13891         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13892         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13893         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13894         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13895         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13896
13897 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13898
13899         * source.c (select_source_symtab): Move header comment to
13900         declaration in source.h.
13901         (forget_cached_source_info_for_objfile): Likewise.
13902         (forget_cached_source_info): Likewise.
13903         (identify_source_line): Likewise.
13904         * source.h (identify_source_line): Move declaration from symtab.h
13905         and add comment from source.c
13906         (print_source_lines): Likewise.
13907         (forget_cached_source_info_for_objfile): Likewise.
13908         (forget_cached_source_info): Likewise.
13909         (select_source_symtab): Likewise.
13910         (enum print_source_lines_flag): Move definition from symtab.h.
13911         * symtab.h (identify_source_line): Move declaration to source.h.
13912         (print_source_lines): Likewise.
13913         (forget_cached_source_info_for_objfile): Likewise.
13914         (forget_cached_source_info): Likewise.
13915         (select_source_symtab): Likewise.
13916         (enum print_source_lines_flag): Move definition to source.h.
13917         * tui/tui-hooks.c: Add 'source.h' include.
13918
13919 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13920
13921         * source.c (print_source_lines_base): Handle requests to print
13922         reverse line number sequences, and guard against empty lines
13923         string.
13924
13925 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13926
13927         * source.c (print_source_lines_base): Fix skip of '\r' if next
13928         character is '\n'.
13929
13930 2019-01-06  Tom Tromey  <tom@tromey.com>
13931
13932         * c-exp.y (struct c_parse_state) <macro_original_text,
13933         expansion_obstack>: New member.
13934         (macro_original_text, expansion_obstack): Remove globals.
13935         (scan_macro_expansion, scanning_macro_expansion)
13936         (finished_macro_expansion): Update.
13937         (scan_macro_cleanup): Remove.
13938         (yylex, c_parse): Update.
13939
13940 2019-01-06  Tom Tromey  <tom@tromey.com>
13941
13942         * c-exp.y (struct c_parse_state) <strings>: New member.
13943         (operator_stoken): Update.
13944
13945 2019-01-06  Tom Tromey  <tom@tromey.com>
13946
13947         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13948         (union type_stack_elt) <typelist_val>: Now a pointer to
13949         std::vector.
13950         (type_stack_cleanup): Don't declare.
13951         (push_typelist): Update.
13952         * parse.c (pop_typelist): Return a std::vector.
13953         (push_typelist): Take a std::vector.
13954         (follow_types): Update.  Do not free args.
13955         (type_stack_cleanup): Remove.
13956         * c-exp.y (struct c_parse_state): New.
13957         (cpstate): New global.
13958         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13959         (nonempty_typelist): Update.
13960         (func_mod): Create a new vector.
13961         (c_parse): Create a c_parse_state.
13962         (check_parameter_typelist): Do not delete params.
13963         (function_method): Update.  Do not delete type_list.
13964
13965 2019-01-06  Tom Tromey  <tom@tromey.com>
13966
13967         PR gdb/28155:
13968         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13969         check_typedef.
13970         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13971         (print_return_value): Likewise.
13972
13973 2019-01-05  Tom Tromey  <tom@tromey.com>
13974
13975         * contrib/cleanup_check.py: Remove.
13976         * contrib/gcc-with-excheck: Remove.
13977         * contrib/exsummary.py: Remove.
13978         * contrib/excheck.py: Remove.
13979
13980 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13981
13982         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13983         NULL. Initialize tpprev to NULL instead of assigning it
13984         to NULL on the next statement.
13985         * windows-nat.c (windows_delete_thread): Remove check for
13986         main_thread_id before printing thread exit notifications.
13987         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13988         Remove thread ID check against main_thread_id.
13989         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13990         windows_delete_thread.
13991         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13992
13993 2019-01-04  Tom Tromey  <tom@tromey.com>
13994
13995         * compile/compile.c (_initialize_compile): Use upper case for
13996         metasyntactic variables.
13997         * symmisc.c (_initialize_symmisc): Use upper case for
13998         metasyntactic variables.
13999         * psymtab.c (_initialize_psymtab): Use upper case for
14000         metasyntactic variables.
14001         * demangle.c (demangle_command): Use upper case for metasyntactic
14002         variables.
14003         (_initialize_demangler): Likewise.
14004         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14005         variables.
14006
14007 2019-01-03  Tom Tromey  <tom@tromey.com>
14008
14009         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14010
14011 2019-01-03  Tom Tromey  <tom@tromey.com>
14012
14013         * python/py-symtab.c (salpy_str): Update.
14014         (struct salpy_sal_object) <symtab>: Now a PyObject.
14015         (salpy_dealloc): Update.
14016         (del_objfile_sal): Use gdbpy_ref.
14017
14018 2019-01-03  Tom Tromey  <tom@tromey.com>
14019
14020         * python/py-type.c (convert_field): Use new_reference.  Return
14021         gdbpy_ref.
14022         (make_fielditem): Return gdbpy_ref.
14023         (typy_fields): Update.
14024         (typy_getitem): Update.
14025         (field_name): Return gdbpy_ref.  Use new_reference.
14026         (typy_iterator_iternext): Update.
14027
14028 2019-01-03  Tom Tromey  <tom@tromey.com>
14029
14030         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14031
14032 2019-01-03  Tom Tromey  <tom@tromey.com>
14033
14034         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14035         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14036         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14037         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14038         (pspy_set_type_printers): Likewise.
14039         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14040         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14041         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14042         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14043         (objfpy_set_type_printers): Likewise.
14044
14045 2019-01-03  Tom Tromey  <tom@tromey.com>
14046
14047         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14048         (gdbpy_print_stack): Use gdbpy_err_fetch.
14049         * python/python-internal.h (class gdbpy_err_fetch): New class.
14050         (class gdbpy_enter) <m_error_type, m_error_value,
14051         m_error_traceback>: Remove.
14052         <m_error>: New member.
14053         (gdbpy_exception_to_string): Don't declare.
14054         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14055         * python/py-value.c (convert_value_from_python): Use
14056         gdbpy_err_fetch.
14057         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14058         gdbpy_exception_to_string.
14059         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14060         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14061         gdbpy_err_fetch.
14062
14063 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14064
14065         * linux-nat.c (delete_lwp_cleanup): Delete.
14066         (struct lwp_deleter): New struct.
14067         (lwp_info_up): New typedef.
14068         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14069         lwp_info_up.
14070
14071 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14072
14073         * linux-fork.c (class scoped_switch_fork_info): New class.
14074         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14075
14076 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14077
14078         * valops.c (find_overload_match): Remove use of null_cleanup, and
14079         calls to do_cleanups.
14080
14081 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14082
14083         * compile/compile-cplus-types.c
14084         (compile_cplus_instance::decl_name): Handle changes to
14085         cp_func_name.
14086         * cp-support.c (cp_func_name): Update header comment, update
14087         return type.
14088         * cp-support.h (cp_func_name): Update return type in declaration.
14089         * valops.c (find_overload_match): Move temp_func local to top
14090         level of function and change its type.  Use temp_func to hold and
14091         delete temporary string obtained from cp_func_name.
14092
14093 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14094
14095         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14096         gdb::char_vector, remove cleanup, and update uses of `msg`.
14097
14098 2019-01-03  Jim Wilson  <jimw@sifive.com>
14099
14100         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14101
14102 2019-01-02  Tom Tromey  <tom@tromey.com>
14103
14104         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14105         (tdesc_parse_xml): Remove cleanups.
14106         * target-descriptions.h (make_cleanup_free_target_description):
14107         Don't declare.
14108         (target_desc_deleter): New struct.
14109         (target_desc_up): New typedef.
14110         * target-descriptions.c (target_desc_deleter::operator()): Rename
14111         from free_target_description.
14112         (make_cleanup_free_target_description): Remove.
14113
14114 2019-01-02  Tom Tromey  <tom@tromey.com>
14115
14116         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14117         constructor, destructor.
14118         (linespec_parser): Remove typedef.
14119         (~linespec_parser): Rename from linespec_parser_delete.
14120         (linespec_lex_to_end, linespec_complete_label)
14121         (linespec_complete): Update.
14122         (decode_line_full): Remove cleanups.
14123         (decode_line_1): Update.
14124
14125 2019-01-02  Tom Tromey  <tom@tromey.com>
14126
14127         * python/python-internal.h (inferior_to_inferior_object): Change
14128         return type.
14129         * python/py-exitedevent.c (create_exited_event_object): Update.
14130         * python/py-inferior.c (inferior_to_inferior_object): Return
14131         gdbpy_ref.
14132         (python_new_inferior, python_inferior_deleted)
14133         (thread_to_thread_object, delete_thread_object)
14134         (build_inferior_list, gdbpy_selected_inferior): Update.
14135         * python/py-infthread.c (create_thread_object): Update.  Also fail
14136         if inferior_to_inferior_object fails.
14137
14138 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14139
14140         * inferior.h (class inferior) <displaced_step_state>: New field.
14141         * infrun.h (struct displaced_step_state): Move here from
14142         infrun.c.  Initialize fields, add constructor.
14143         <inf>: Remove field.
14144         <reset>: New method.
14145         * infrun.c (struct displaced_step_inferior_state): Move to
14146         infrun.h.
14147         (displaced_step_inferior_states): Remove.
14148         (get_displaced_stepping_state): Adust.
14149         (displaced_step_in_progress_any_inferior): Adjust.
14150         (displaced_step_in_progress_thread): Adjust.
14151         (displaced_step_in_progress): Adjust.
14152         (add_displaced_stepping_state): Remove.
14153         (get_displaced_step_closure_by_addr): Adjust.
14154         (remove_displaced_stepping_state): Remove.
14155         (infrun_inferior_exit): Call displaced_step_state.reset.
14156         (use_displaced_stepping): Don't check for NULL.
14157         (displaced_step_prepare_throw): Call
14158         get_displaced_stepping_state.
14159         (displaced_step_fixup): Don't check for NULL.
14160         (prepare_for_detach): Don't check for NULL.
14161
14162 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14163
14164         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14165          in case of call that did not complete.
14166
14167 2019-01-02  Andrey Utkin  <autkin@undo.io>
14168
14169         * symfile.c (find_separate_debug_file): Fix search of debug files for
14170         remote debuggee.
14171
14172 2019-01-02  Tom Tromey  <tom@tromey.com>
14173
14174         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14175         indentation.
14176         * python/py-frame.c (frapy_older): Remove cast.
14177         (frapy_newer): Likewise.
14178         * python/py-breakpoint.c (local_setattro): Remove cast.
14179         * python/py-arch.c (archpy_name): Remove local variable.
14180         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14181
14182 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14183
14184         * unittests/basic_string_view/element_access/char/empty.cc:
14185         Fix year range in copyright header.
14186
14187 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14188
14189         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14190         Delete.
14191         <operator==>: Update with for removed field.
14192         <hash>: Likewise.
14193         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14194         <isa_features>: ...this.
14195         <abi_features>: New field.
14196         (riscv_isa_flen): Update comment.
14197         (riscv_abi_xlen): New declaration.
14198         (riscv_abi_flen): New declaration.
14199         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14200         isa_features.
14201         (riscv_abi_xlen): New function.
14202         (riscv_isa_flen): Update to get answer from isa_features.
14203         (riscv_abi_flen): New function.
14204         (riscv_has_fp_abi): Update to get answer from abi_features.
14205         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14206         xlen and flen.
14207         (riscv_call_info) <xlen, flen>: Update comment.
14208         (riscv_call_arg_struct): Remove invalid assertions
14209         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14210         is removed.
14211         (riscv_gdbarch_init): Gather isa features and abi features
14212         separately, ensure both match on the gdbarch when reusing an old
14213         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14214         a target with 64-bit float hardware.
14215
14216 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14217
14218         * source.c (search_command_helper): Stop reverse search
14219         when line 1 has been searched.
14220
14221 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14222
14223         * record-full.c (record_full_base_target::close): Rewrite
14224         record_full_core_buf_list free logic.
14225
14226 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14227
14228         * break-catch-syscall.c (print_one_catch_syscall): xfree
14229         the last text.
14230
14231 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14232
14233         * top.c (print_gdb_version): Update Copyright year in version
14234         message.
14235
14236 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14237
14238         Update copyright year range in all GDB files.
14239
14240 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14241
14242         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14243
14244 For older changes see ChangeLog-2018.
14245 \f
14246 Local Variables:
14247 mode: change-log
14248 left-margin: 8
14249 fill-column: 74
14250 version-control: never
14251 coding: utf-8
14252 End:
14253