gdb/ChangeLog

   1 2019-09-29  Tom de Vries  <tdevries@suse.de>
   2
   3         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
   4         Use $tmpdir/$(basename "$output_file").dwz instead of
   5         "${output_file}.dwz".
   6
   7 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
   8
   9         PR gdb/25045
  10         * hppa-linux-nat.c: Include gdbarch.h.
  11
  12 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
  13
  14         * blockframe.c (find_pc_partial_function): Change return type to bool.
  15         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
  16         * minsyms.c (in_gnu_ifunc_stub): Likewise.
  17         (stub_gnu_ifunc_resolve_name): Likewise.
  18         * symtab.c (compare_filenames_for_search): Likewise.
  19         (compare_glob_filenames_for_search): Likewise.
  20         (matching_obj_sections): Likewise.
  21         (symbol_matches_domain): Likewise.
  22         (find_line_symtab): Change out param EXACT_MATCH to bool *.
  23         (find_line_pc): Change return type to bool.
  24         (find_line_pc_range): Likewise.
  25         (producer_is_realview): Likewise.
  26         * symtab.h (symbol_matches_domain): Likewise.
  27         (find_pc_partial_function): Likewise.
  28         (find_pc_line_pc_range): Likewise.
  29         (in_gnu_ifunc_stub): Likewise.
  30         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
  31         (find_line_pc): Likewise.
  32         (find_line_pc_range): Likewise.
  33         (matching_obj_sections): Likewise.
  34         (find_line_symtab): Change out parameter to bool.
  35         (producer_is_realview): Change return type to bool.
  36         (compare_filenames_for_search): Likewise.
  37         (compare_glob_filenames_for_search): Likewise.
  38
  39 2019-09-26  Tom Tromey  <tom@tromey.com>
  40
  41         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
  42         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
  43         * gdb_usleep.h: Remove.
  44         * gdb_usleep.c: Remove.
  45         * utils.c: Don't include gdb_usleep.h.
  46
  47 2019-09-26  Tom Tromey  <tromey@adacore.com>
  48
  49         * python/py-type.c (type_to_type_object): Call check_typedef
  50         for stub types.
  51
  52 2019-09-26  Tom Tromey  <tom@tromey.com>
  53
  54         * utils.h (initialize_utils): Don't declare.
  55         * top.c (gdb_init): Don't call initialize_utils.
  56         * utils.c (initialize_utils): Remove.  Move contents...
  57         (_initialize_utils): ... here.
  58
  59 2019-09-25  Tom Tromey  <tom@tromey.com>
  60
  61         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
  62         * utils.h (make_hex_string): Don't declare.
  63         * utils.c (make_hex_string): Remove.
  64
  65 2019-09-24  Tom de Vries  <tdevries@suse.de>
  66
  67         PR gdb/23815
  68         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
  69         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
  70
  71 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
  72
  73         * NEWS: Mention new simulator port for PRU.
  74
  75 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
  76
  77         * ada-exp.y (write_object_remaining): Update.
  78         * ada-lang.c (ada_decode): Return a std::string instead of a char*
  79         and eliminate the static buffer.
  80         (ada_decode_symbol): Update.
  81         (ada_la_decode): Update.
  82         (ada_sniff_from_mangled_name): Update.
  83         (is_valid_name_for_wild_match): Update.
  84         (ada_lookup_name_info::matches): Update and simplify.
  85         (name_matches_regex): Update.
  86         (ada_add_global_exceptions): Update.
  87         * ada-lang.h (ada_decode): Update signature.
  88         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
  89         * dwarf-index-write.c (debug_names::insert): Update.
  90
  91 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
  92
  93         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
  94         formatting.
  95
  96 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
  97
  98         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
  99         Change "nonzero" to "true" in documentation.
 100
 101 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 102
 103         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 104         (_initialize_darwin_solib): Don't set
 105         darwin_so_ops.lookup_lib_global_symbol.
 106         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 107         set_gdbarch_iterate_over_objfiles_in_search_order.
 108         (elf_lookup_lib_symbol): Rename to...
 109         (svr4_iterate_over_objfiles_in_search_order): this, and update
 110         to iterate semantics.
 111         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 112         * solib.c (solib_global_lookup): Remove.
 113         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 114         (solib_global_lookup): Remove.
 115         * symtab.c (lookup_global_or_static_symbol): Remove call to
 116         solib_global_lookup.
 117
 118 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 119
 120         * NEWS: Move entries about default MI version now being
 121         version 3, and about the GDB/MI fix for multi-location
 122         breakpoints to the "since GDB 8.3" section.
 123
 124 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 125
 126         GDB 8.3.1 released.
 127
 128 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 129
 130         * NEWS: Mention that Cell/B.E. debugging support was removed.
 131         * MAINTAINERS: Remove spu target.
 132
 133         * config/djgpp/fnchange.lst: Remove entries for removed files.
 134
 135         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 136         spu-multiarch.o, and spu-tdep.o.
 137         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 138         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 139         spu-multiarch.c, and spu-tdep.c.
 140         * spu-linux-nat.c: Remove file.
 141         * spu-multiarch.c: Remove file.
 142         * spu-tdep.c: Remove file.
 143         * spu-tdep.h: Remove file.
 144         * solib-spu.c: Remove file.
 145         * solib-spu.h: Remove file.
 146
 147         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 148         * configure.nat (spu-linux): Remove.
 149         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 150         solib-multiarch.o from gdb_target_obs.
 151         (spu*-*-*): Remove.
 152
 153         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 154         feature flag.
 155         (ppc_linux_no_features): Update.
 156         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 157         Cell/B.E. support.
 158         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 159         (tdesc_powerpc_cell64l): Likewise.
 160         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 161         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 162         Cell/B.E. support.
 163         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 164         Do not include "features/rs6000/powerpc-cell32l.c" or
 165         "features/rs6000/powerpc-cell64l.c".
 166         (ppc_linux_spu_section): Remove.
 167         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 168         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 169         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 170         (ppc_linux_spe_context_lookup): Remove.
 171         (ppc_linux_spe_context_inferior_created): Remove.
 172         (ppc_linux_spe_context_solib_loaded): Remove.
 173         (ppc_linux_spe_context_solib_unloaded): Remove.
 174         (ppc_linux_spe_context): Remove.
 175         (struct ppu2spu_cache): Remove.
 176         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 177         (struct ppu2spu_data): Remove.
 178         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 179         ppu2spu_unwind): Remove.
 180         (ppc_linux_init_abi): Remove Cell/B.E. support.
 181         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 182
 183         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 184         (rs6000/powerpc-cell64l-expedite): Likewise
 185         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 186         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 187         rs6000/powerpc-cell64l.xml.
 188         * features/rs6000/powerpc-cell32l.xml: Remove.
 189         * features/rs6000/powerpc-cell64l.xml: Likewise.
 190         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 191         * features/rs6000/powerpc-cell64l.c: Likewise.
 192         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 193         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 194         * regformats/reg-spu.dat: Remove.
 195
 196         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 197         * corelow.c (struct spuid_list): Remove.
 198         (add_to_spuid_list): Remove.
 199         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 200         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 201         (remote_protocol_features): Remove associated entries.
 202         (_initialize_remote): No longer initialize them.
 203         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 204         * linux-nat.c (SPUFS_MAGIC): Remove.
 205         (linux_proc_xfer_spu): Remove.
 206         (spu_enumerate_spu_ids): Remove.
 207         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 208         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 209         (linux_make_corefile_notes): No longer call it.
 210
 211         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 212         (cooked_write_test): Likewise.
 213
 214 2019-09-20  Tom Tromey  <tom@tromey.com>
 215
 216         * NEWS: Mention case-sensitivity of TUI commands.
 217         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 218         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 219         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 220
 221 2019-09-20  Tom Tromey  <tom@tromey.com>
 222
 223         * tui/tui-source.c (tui_source_window::set_contents): Use
 224         make_unique_xstrdup.
 225         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 226         make_unique_xstrdup.
 227
 228 2019-09-20  Tom Tromey  <tom@tromey.com>
 229
 230         * tui/tui-data.c: Remove separator comments.
 231         * tui/tui-layout.c: Remove separator comments.
 232         * tui/tui-win.c: Remove separator comments.
 233         * tui/tui-wingeneral.c: Remove separator comments.
 234
 235 2019-09-20  Tom Tromey  <tom@tromey.com>
 236
 237         * tui/tui.h (strcat_to_buf): Don't declare.
 238         * tui/tui.c (strcat_to_buf): Remove.
 239
 240 2019-09-20  Tom Tromey  <tom@tromey.com>
 241
 242         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 243         from "fullname".
 244         * tui/tui-source.c (tui_source_window::set_contents)
 245         (tui_source_window::location_matches_p)
 246         (tui_source_window::maybe_update): Update.
 247
 248 2019-09-20  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 251         Update.
 252         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 253         prefix.
 254         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 255         (tui_data_window::line_from_reg_element_no)
 256         (tui_data_window::first_reg_element_no_inline)
 257         (tui_data_window::show_registers)
 258         (tui_data_window::show_register_group)
 259         (tui_data_window::display_registers_from)
 260         (tui_data_window::display_registers_from_line)
 261         (tui_data_window::first_data_item_displayed)
 262         (tui_data_window::delete_data_content_windows)
 263         (tui_data_window::erase_data_content)
 264         (tui_data_window::do_scroll_vertical)
 265         (tui_data_window::refresh_window)
 266         (tui_data_window::check_register_values): Update.
 267
 268 2019-09-20  Tom Tromey  <tom@tromey.com>
 269
 270         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 271         (struct tui_locator_window) <full_name, proc_name>: Now
 272         std::string.
 273         * tui/tui-stack.c (tui_locator_window::make_status_line)
 274         (tui_locator_window::set_locator_fullname)
 275         (tui_locator_window::set_locator_info): Update.
 276         * tui/tui-source.c (tui_source_window::set_contents)
 277         (tui_source_window::showing_source_p): Update.
 278
 279 2019-09-20  Tom Tromey  <tom@tromey.com>
 280
 281         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 282         Don't call tui_locator_win_info_ptr.
 283
 284 2019-09-20  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 287
 288 2019-09-20  Tom Tromey  <tom@tromey.com>
 289
 290         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 291         height for locator.
 292         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 293         * tui/tui-layout.c (show_source_disasm_command, show_data)
 294         (show_source_or_disasm_and_command): Use 1 as height for locator.
 295
 296 2019-09-20  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui.c (tui_enable): Update.
 299         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 300         Update.
 301         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 302         Update.
 303         * tui/tui-data.c (win_resized): Now bool.
 304         (tui_win_resized): Return bool.
 305         (tui_set_win_resized_to): Accept a bool.
 306
 307 2019-09-20  Tom Tromey  <tom@tromey.com>
 308
 309         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 310         Change type of "refresh_values_only".
 311         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 312         type of "refresh_values_only".
 313
 314 2019-09-20  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 317         std::string.
 318         (tui_disassemble): Add "pos" parameter.
 319         (tui_disasm_window::set_contents): Simplify.
 320
 321 2019-09-20  Tom Tromey  <tom@tromey.com>
 322
 323         * tui/tui-winsource.h (struct tui_source_window_base)
 324         <show_source_content>: Now private.
 325         * tui/tui-winsource.c
 326         (tui_source_window_base::show_source_content): Don't handle empty
 327         content case.
 328
 329 2019-09-20  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-layout.c (show_source_disasm_command)
 332         (show_source_or_disasm_and_command): Don't call
 333         show_source_content.
 334
 335 2019-09-20  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 338         Declare.
 339         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 340         from tui_make_status_line.
 341         (tui_locator_window::rerender): Update.
 342
 343 2019-09-20  Tom Tromey  <tom@tromey.com>
 344
 345         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 346         (tui_locator_window::rerender): Update.
 347
 348 2019-09-20  Tom Tromey  <tom@tromey.com>
 349
 350         * tui/tui-winsource.h (struct tui_source_window_base)
 351         <~tui_source_window_base>: Don't declare.
 352         <fullname>: Remove.
 353         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 354         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 355         member.
 356         * tui/tui-source.c (tui_source_window::set_contents): Update.
 357         (tui_source_window::location_matches_p)
 358         (tui_source_window::maybe_update): Update.
 359
 360 2019-09-20  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-winsource.h (~tui_source_element): Remove.
 363         (tui_source_element): Update.
 364         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 365         * tui/tui-winsource.c (tui_show_source_line): Update.
 366         * tui/tui-source.c (tui_source_window::set_contents): Update.
 367         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 368
 369 2019-09-20  Tom Tromey  <tom@tromey.com>
 370
 371         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 372         declare.
 373         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 374         tui_clear_source_windows_detail.
 375         * tui/tui-winsource.h (struct tui_source_window_base)
 376         <clear_detail>: Don't declare.
 377         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 378         Remove.
 379         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 380
 381 2019-09-20  Tom Tromey  <tromey@adacore.com>
 382
 383         PR ada/24919:
 384         * block.c (contained_in): Fix final return value.
 385
 386 2019-09-20  Alan Modra  <amodra@gmail.com>
 387
 388         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 389         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 390         (read_indirect_string_from_dwz): Use bfd accessor.
 391         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 392         * machoread.c (macho_symfile_read_all_oso): Likewise.
 393         * solib.c (solib_bfd_open): Likewise.
 394
 395 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 396
 397         * eval.c: Move declaration of overload_resolution to...
 398         * value.h: ...here.
 399
 400 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 401
 402         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 403         * arm-linux-tdep.c: Likewise.
 404         * arm-nbsd-nat.c: Likewise.
 405         * arm-tdep.h: Declare arm_apcs_32.
 406         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 407
 408 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 409
 410         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 411         * dwarf2read.h: Declare dwarf_always_disassemble.
 412
 413 2019-09-19  Tom de Vries  <tdevries@suse.de>
 414
 415         PR gdb/25009
 416         * source-cache.c (source_cache::ensure): Catch exception thrown during
 417         construction of the highlighter.
 418
 419 2019-09-18  Alan Modra  <amodra@gmail.com>
 420
 421         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 422         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 423         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 424         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 425         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 426         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 427         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 428         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 429         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 430         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 431         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 432         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 433         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 434         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 435         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 436         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 437         * mi/mi-interp.c: Update throughout for bfd section macro and
 438         function changes.
 439         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 440         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 441
 442 2019-09-18  Tom Tromey  <tom@tromey.com>
 443
 444         * NEWS: Add entry.
 445         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 446         call rl_initialize.
 447         (tui_enable): Do not call rl_initialize.
 448
 449 2019-09-18  Christian Groessler  <chris@groessler.org>
 450
 451         * alpha-linux-nat.c: Include gdbarch.h.
 452
 453 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 454
 455         * ui-file.c: Include cli/cli-style.h.
 456         (term_cli_styling): Remove cli_styling declaration.
 457
 458 2019-09-18  Alan Modra  <amodra@gmail.com>
 459
 460         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 461         to bfd_asymbol_section.
 462
 463 2019-09-18  Alan Modra  <amodra@gmail.com>
 464
 465         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 466         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 467         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 468
 469 2019-09-18  Alan Modra  <amodra@gmail.com>
 470
 471         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 472         * spu-linux-nat.c (spu_bfd_open): Likewise.
 473
 474 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 475
 476         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 477         to bool to match definition in dwarf2read.c.
 478
 479 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 480
 481         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 482         (print_signatures): Likewise.
 483         (trust_pad_over_xvs): Likewise.
 484         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 485         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 486         * arm-linux-nat.c (arm_apcs_32): Likewise.
 487         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 488         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 489         * arm-tdep.c (arm_debug): Likewise.
 490         (arm_apcs_32): Likewise.
 491         * auto-load.c (debug_auto_load): Likewise.
 492         (auto_load_gdb_scripts): Likewise.
 493         (global_auto_load): Likewise.
 494         (auto_load_local_gdbinit): Likewise.
 495         (auto_load_local_gdbinit_loaded): Likewise.
 496         * auto-load.h (global_auto_load): Likewise.
 497         (auto_load_local_gdbinit): Likewise.
 498         (auto_load_local_gdbinit_loaded): Likewise.
 499         * breakpoint.c (disconnected_dprintf): Likewise.
 500         (breakpoint_proceeded): Likewise.
 501         (automatic_hardware_breakpoints): Likewise.
 502         (always_inserted_mode): Likewise.
 503         (target_exact_watchpoints): Likewise.
 504         (_initialize_breakpoint): Update.
 505         * breakpoint.h (target_exact_watchpoints): Change to bool.
 506         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 507         * cli/cli-cmds.c (trace_commands): Likewise.
 508         * cli/cli-cmds.h (trace_commands): Likewise.
 509         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 510         to bool*.
 511         * cli/cli-logging.c (logging_overwrite): Change to bool.
 512         (logging_redirect): Likewise.
 513         (debug_redirect): Likewise.
 514         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 515         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 516         to bool.
 517         <boolean_option_def>: Update.
 518         (struct flag_option_def): Change default type of Context to bool
 519         from int.
 520         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 521         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 522         (get_setshow_command_value_string): Likewise.
 523         * cli/cli-style.c (cli_styling): Change to bool.
 524         (source_styling): Likewise.
 525         * cli/cli-style.h (source_styling): Likewise.
 526         (cli_styling): Likewise.
 527         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 528         to bool.
 529         * command.h (var_types): Update comment.
 530         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 531         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 532         bool.
 533         (debug_compile_cplus_scopes): Likewise.
 534         * compile/compile-internal.h (compile_debug): Likewise.
 535         * compile/compile.c (compile_debug): Likewise.
 536         (struct compile_options) <raw>: Likewise.
 537         * cp-support.c (catch_demangler_crashes): Likewise.
 538         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 539         (usr_cmd_cris_dwarf2_cfi): Likewise.
 540         * csky-tdep.c (csky_debug): Likewise.
 541         * darwin-nat.c (enable_mach_exceptions): Likewise.
 542         * dcache.c (dcache_enabled_p): Likewise.
 543         * defs.h (info_verbose): Likewise.
 544         * demangle.c (demangle): Likewise.
 545         (asm_demangle): Likewise.
 546         * dwarf-index-cache.c (debug_index_cache): Likewise.
 547         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 548         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 549         * dwarf2read.c (check_physname): Likewise.
 550         (use_deprecated_index_sections): Likewise.
 551         (dwarf_always_disassemble): Likewise.
 552         * eval.c (overload_resolution): Likewise.
 553         * event-top.c (set_editing_cmd_var): Likewise.
 554         (exec_done_display_p): Likewise.
 555         * event-top.h (set_editing_cmd_var): Likewise.
 556         (exec_done_display_p): Likewise.
 557         * exec.c (write_files): Likewise.
 558         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 559         (debug_fbsd_nat): Likewise.
 560         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 561         Likewise.
 562         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 563         <backtrace_past_entry> Likewise.
 564         * gdb-demangle.h (demangle): Likewise.
 565         (asm_demangle): Likewise.
 566         * gdb_bfd.c (bfd_sharing): Likewise.
 567         * gdbcore.h (write_files): Likewise.
 568         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 569         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 570         * gdbthread.h (print_thread_events): Likewise.
 571         * gdbtypes.c (opaque_type_resolution): Likewise.
 572         (strict_type_checking): Likewise.
 573         * gnu-nat.c (gnu_debug_flag): Likewise.
 574         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 575         * guile/scm-param.c (pascm_variable): Add boolval.
 576         (add_setshow_generic): Update.
 577         (pascm_param_value): Update.
 578         (pascm_set_param_value_x): Update.
 579         * hppa-tdep.c (hppa_debug): Change to bool..
 580         * infcall.c (may_call_functions_p): Likewise.
 581         (coerce_float_to_double_p): Likewise.
 582         (unwind_on_signal_p): Likewise.
 583         (unwind_on_terminating_exception_p): Likewise.
 584         * infcmd.c (startup_with_shell): Likewise.
 585         * inferior.c (print_inferior_events): Likewise.
 586         * inferior.h (startup_with_shell): Likewise.
 587         (print_inferior_events): Likewise.
 588         * infrun.c (step_stop_if_no_debug): Likewise.
 589         (detach_fork): Likewise.
 590         (debug_displaced): Likewise.
 591         (disable_randomization): Likewise.
 592         (non_stop): Likewise.
 593         (non_stop_1): Likewise.
 594         (observer_mode): Likewise.
 595         (observer_mode_1): Likewise.
 596         (set_observer_mode): Update.
 597         (sched_multi): Change to bool.
 598         * infrun.h (debug_displaced): Likewise.
 599         (sched_multi): Likewise.
 600         (step_stop_if_no_debug): Likewise.
 601         (non_stop): Likewise.
 602         (disable_randomization): Likewise.
 603         * linux-tdep.c (use_coredump_filter): Likewise.
 604         (dump_excluded_mappings): Likewise.
 605         * linux-thread-db.c (auto_load_thread_db): Likewise.
 606         (check_thread_db_on_load): Likewise.
 607         * main.c (captured_main_1): Update.
 608         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 609         xx2_opt, boolean_opt>: Change to bool.
 610         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 611         * maint.c (maintenance_profile_p): Likewise.
 612         (per_command_time): Likewise.
 613         (per_command_space): Likewise.
 614         (per_command_symtab): Likewise.
 615         * memattr.c (inaccessible_by_default): Likewise.
 616         * mi/mi-main.c (mi_async): Likewise.
 617         (mi_async_1): Likewise.
 618         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 619         * nat/fork-inferior.h (startup_with_shell): Likewise.
 620         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 621         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 622         * nios2-tdep.c (nios2_debug): Likewise.
 623         * or1k-tdep.c (or1k_debug): Likewise.
 624         * parse.c (parser_debug): Likewise.
 625         * parser-defs.h (parser_debug): Likewise.
 626         * printcmd.c (print_symbol_filename): Likewise.
 627         * proc-api.c (procfs_trace): Likewise.
 628         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 629         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 630         (set_parameter_value): Update.
 631         (add_setshow_generic): Update.
 632         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 633         to bool*.
 634         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 635         int*.
 636         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 637         * record-btrace.c (record_btrace_target::store_registers): Update.
 638         * record-full.c (record_full_memory_query): Change to bool.
 639         (record_full_stop_at_limit): Likewise.
 640         * record-full.h (record_full_memory_query): Likewise.
 641         * remote-notif.c (notif_debug): Likewise.
 642         * remote-notif.h (notif_debug): Likewise.
 643         * remote.c (use_range_stepping): Likewise.
 644         (interrupt_on_connect): Likewise.
 645         (remote_break): Likewise.
 646         * ser-tcp.c (tcp_auto_retry): Likewise.
 647         * ser-unix.c (serial_hwflow): Likewise.
 648         * skip.c (debug_skip): Likewise.
 649         * solib-aix.c (solib_aix_debug): Likewise.
 650         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 651         (spu_auto_flush_cache_p): Likewise.
 652         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 653         Likewise.
 654         (struct info_print_options) <quiet>: Likewise.
 655         * symfile-debug.c (debug_symfile): Likewise.
 656         * symfile.c (auto_solib_add): Likewise.
 657         (separate_debug_file_debug): Likewise.
 658         * symfile.h (auto_solib_add): Likewise.
 659         (separate_debug_file_debug): Likewise.
 660         * symtab.c (basenames_may_differ): Likewise.
 661         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 662         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 663         (struct info_types_options) <quiet>: Likewise.
 664         * symtab.h (demangle): Likewise.
 665         (basenames_may_differ): Likewise.
 666         * target-dcache.c (stack_cache_enabled_1): Likewise.
 667         (code_cache_enabled_1): Likewise.
 668         * target.c (trust_readonly): Likewise.
 669         (may_write_registers): Likewise.
 670         (may_write_memory): Likewise.
 671         (may_insert_breakpoints): Likewise.
 672         (may_insert_tracepoints): Likewise.
 673         (may_insert_fast_tracepoints): Likewise.
 674         (may_stop): Likewise.
 675         (auto_connect_native_target): Likewise.
 676         (target_stop_and_wait): Update.
 677         (target_async_permitted): Change to bool.
 678         (target_async_permitted_1): Likewise.
 679         (may_write_registers_1): Likewise.
 680         (may_write_memory_1): Likewise.
 681         (may_insert_breakpoints_1): Likewise.
 682         (may_insert_tracepoints_1): Likewise.
 683         (may_insert_fast_tracepoints_1): Likewise.
 684         (may_stop_1): Likewise.
 685         * target.h (target_async_permitted): Likewise.
 686         (may_write_registers): Likewise.
 687         (may_write_memory): Likewise.
 688         (may_insert_breakpoints): Likewise.
 689         (may_insert_tracepoints): Likewise.
 690         (may_insert_fast_tracepoints): Likewise.
 691         (may_stop): Likewise.
 692         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 693         (make_thread_apply_all_options_def_group): Change argument from int*
 694         to bool*.
 695         (thread_apply_all_command): Update.
 696         (print_thread_events): Change to bool.
 697         * top.c (confirm): Likewise.
 698         (command_editing_p): Likewise.
 699         (history_expansion_p): Likewise.
 700         (write_history_p): Likewise.
 701         (info_verbose): Likewise.
 702         * top.h (confirm): Likewise.
 703         (history_expansion_p): Likewise.
 704         * tracepoint.c (disconnected_tracing): Likewise.
 705         (circular_trace_buffer): Likewise.
 706         * typeprint.c (print_methods): Likewise.
 707         (print_typedefs): Likewise.
 708         * utils.c (debug_timestamp): Likewise.
 709         (sevenbit_strings): Likewise.
 710         (pagination_enabled): Likewise.
 711         * utils.h (sevenbit_strings): Likewise.
 712         (pagination_enabled): Likewise.
 713         * valops.c (overload_resolution): Likewise.
 714         * valprint.h (struct value_print_options) <prettyformat_arrays,
 715         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 716         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 717         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 718         Likewise.
 719         * windows-nat.c (new_console): Likewise.
 720         (cygwin_exceptions): Likewise.
 721         (new_group): Likewise.
 722         (debug_exec): Likewise.
 723         (debug_events): Likewise.
 724         (debug_memory): Likewise.
 725         (debug_exceptions): Likewise.
 726         (useshell): Likewise.
 727         * windows-tdep.c (maint_display_all_tib): Likewise.
 728         * xml-support.c (debug_xml): Likewise.
 729
 730 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 731
 732         * source.c (prepare_path_for_appending): New function.
 733         (openp): Make use of new function.
 734         (find_and_open_source): Search for the compilation directory and
 735         source file as a relative path beneath the directory search path.
 736
 737 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 738
 739         * source-cache.c (source_cache::get_line_charpos): Catch
 740         exceptions and return false, this matches the behaviour documented
 741         in the header file.
 742
 743 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 744
 745         * ada-tasks.c (info_task): Remove quoting of the task's name.
 746
 747 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 748
 749         * symfile.c (auto_solib_add): Replace comment with a reference
 750         to the header file.
 751
 752 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 753
 754         * NEWS: Mention that gdb can now be compiled with Python 3
 755         on Windows.
 756
 757 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 758
 759         * maint.c (maint_print_section_data::maint_print_section_data):
 760         Force use of 'float log10 (float)' by casting the argument to
 761         float.
 762
 763 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 764
 765         * maint.c: Add 'cmath' include.
 766         (struct maint_print_section_data): New structure.
 767         (print_section_index): New function.
 768         (print_bfd_section_info): Add header comment, small whitespace
 769         cleanup, and update to call new print_section_index function.
 770         (print_objfile_section_info): Likewise.
 771         (maint_obj_section_from_bfd_section): New function.
 772         (print_bfd_section_info_maybe_relocated): New function.
 773         (maintenance_info_sections): Add header comment, always use
 774         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 775
 776 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 777
 778         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 779         inner scope, add check that the objfile has psymtabs before
 780         checking psymtabs_addrmap.
 781         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 782
 783 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 784
 785         * NEWS: Announce that Ada task names are now shown at more places,
 786         and between quotes (except in info task output).
 787         * gdb/ada-tasks.c (task_to_str): New function.
 788         (display_current_task_id): Call task_to_str.
 789         (task_command_1): Likewise.
 790         (print_ada_task_info): In non-mi mode, Properly align headers and data
 791         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 792
 793 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 794
 795         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 796         prstatus.pr_lwp.pr_info instead of making it up.
 797
 798 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 799
 800         * auto-load.c (auto_load_expand_dir_vars): Update.
 801         * defs.h (gdb_datadir): Change to std::string.
 802         (python_libdir): Likewise.
 803         (relocate_gdb_directory): Change return type to std::string.
 804         * guile/guile.c (gdbscm_data_directory): Update.
 805         (initialize_scheme_side): Update.
 806         * jit.c (jit_reader_dir): Change to std::string.
 807         (jit_reader_load_command): Update.
 808         * main.c (gdb_datadir): Change to std::string.
 809         (python_libdir): Likewise.
 810         (set_gdb_data_directory): Update.
 811         (relocate_path): Change to return std::string.
 812         (relocate_gdb_directory): Change to return std::string.
 813         (relocate_gdbinit_path_maybe_in_datadir): Update.
 814         (captured_main_1): Update.
 815         * python/python.c (do_start_initialization): Update.
 816         * top.c (show_gdb_datadir): Update.
 817         * xml-syscall.c (xml_init_syscalls_info): Update.
 818         (init_syscalls_info): Update.
 819
 820 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 821
 822         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 823         out of get_init_files.
 824         (get_init_files): Update.
 825
 826 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 827
 828         * main.c (get_init_files): Change to use std::string.
 829         (captured_main_1): Update.
 830         (print_gdb_help): Update.
 831
 832 2019-09-11  Ali Tamur  <tamur@google.com>
 833
 834         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 835         implementation.
 836
 837 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 838
 839         * dbxread.c (read_dbx_symtab): Update.
 840         * dwarf2read.c (load_partial_dies): Update.
 841         * mdebugread.c (parse_partial_symbols): Update.
 842         (handle_psymbol_enumerators): Update.
 843         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 844         * psymtab.c (add_psymbol_to_bcache): Likewise.
 845         (add_psymbol_to_list): Likewise.
 846         * symtab.c (symbol_set_names): Likewise.
 847         * symtab.h (symbol_set_names): Likewise.
 848         * xcoffread.c (scan_xcoff_symtab): Update.
 849
 850 2019-09-11  Tom Tromey  <tom@tromey.com>
 851
 852         * symfile-mem.c (symbol_file_add_from_memory): Use
 853         bfd_set_filename.
 854         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 855         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 856
 857 2019-09-10  Tom Tromey  <tromey@adacore.com>
 858
 859         * dwarf-index-write.c (write_psymbols): Extend error message.
 860         (debug_names::insert): Add Ada code.
 861         (debug_names::write_psymbols): Remove Ada check.
 862         (debug_names) <m_string_obstack>: New member.
 863         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 864         (gdb_index_symbol_name_matcher::matches): Remove.
 865         (mapped_index_base::find_name_components_bounds): Add "lang"
 866         parameter.
 867         (mapped_index_base::build_name_components): Also split names
 868         according to Ada syntax.
 869         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 870         type of "match_callback".
 871         (check_match, check_find_bounds_finds)
 872         (dw2_expand_symtabs_matching): Update.
 873         (dw2_debug_names_iterator): Add new constructor.
 874         (dw2_debug_names_map_matching_symbols): New function.
 875         (dw2_debug_names_expand_symtabs_matching): Update.
 876         (dwarf2_debug_names_functions): Use
 877         dw2_debug_names_map_matching_symbols.
 878
 879 2019-09-10  Tom Tromey  <tromey@adacore.com>
 880
 881         * dwarf2read.c (dw2_get_file_names_reader): Add the
 882         CU's file name to the results.
 883
 884 2019-09-10  Tom Tromey  <tromey@adacore.com>
 885
 886         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 887         map_matching_symbols.  Update.
 888         * dwarf2read.c (dw2_map_matching_symbols): Update.
 889         * psymtab.c (match_partial_symbol): Change type; update.
 890         (psym_map_matching_symbols): Likewise.
 891         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 892         type; update.
 893         * symfile.h (struct quick_symbol_functions)
 894         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 895         Remove "match".
 896
 897 2019-09-10  Tom Tromey  <tromey@adacore.com>
 898
 899         * psymtab.c (map_block): Remove.
 900         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 901         * symtab.c (iterate_over_symbols_terminated): New function.
 902         * symtab.c (iterate_over_symbols_terminated): Declare.
 903
 904 2019-09-10  Tom Tromey  <tromey@adacore.com>
 905
 906         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 907         * language.h (struct language_defn) <la_iterate_over_symbols>:
 908         Return bool.
 909         * symtab.c (iterate_over_symbols): Return bool.
 910         * symtab.h (iterate_over_symbols): Return bool.
 911
 912 2019-09-10  Tom Tromey  <tromey@adacore.com>
 913
 914         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 915         (add_nonlocal_symbols): Update.
 916         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 917         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 918         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 919         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 920         Change type of "callback".  Remove "data".
 921
 922
 923 2019-09-09  Ali Tamur  <tamur@google.com>
 924
 925         * dwarf2read.c (comp_unit_head): Update comment.
 926         (dwarf2_dwo_name): New function declaration.
 927         (dwarf_unit_type_name): New function declaration.
 928         (read_comp_unit_head): Add support for new compilation units,
 929         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 930         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 931         (currently named as "signature") in their header. Also clarify error
 932         messages.
 933         (lookup_dwo_id): New function. Returns the dwo id of the given
 934         compile unit.
 935         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 936         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 937         functions.
 938         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 939         (dwarf2_dwo_name): Get the dwo name if present.
 940         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 941         purposes.
 942
 943 2019-09-09  Tom Tromey  <tom@tromey.com>
 944
 945         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 946
 947 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 948
 949         * python/python.c (do_start_initialization): Make progname_copy static,
 950         to avoid a leak report.
 951
 952 2019-09-08  Tom Tromey  <tom@tromey.com>
 953
 954         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 955
 956 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 957
 958         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 959         Change type to gdb::optional<block_enum>.
 960         (dw2_symtab_iter_init): Change block_index parameter type
 961         to gdb::optional<block_enum>.
 962         (dw2_lookup_symbol): Change block_index parameter
 963         type to block_enum.c
 964         (dw2_debug_names_lookup_symbol): Likewise.
 965         * psymtab.c (psym_lookup_symbol): Likewise.
 966         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 967         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 968         Likewise.
 969
 970 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 971
 972         * defs.h (relocate_gdb_directory): Change int to bool in
 973         signature and rename flag to relocatable.
 974         * main.c (relocate_path): Likewise.
 975         (relocate_gdb_directory): Likewise.
 976
 977 2019-09-06  Alan Modra  <amodra@gmail.com>
 978
 979         * coffread.c (coff_symfile_read): Constify filename variable.
 980         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 981         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 982         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 983         * solib.c (reload_shared_libraries_1): Likewise.
 984         * symfile.c (reread_symbols): Likewise.
 985         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 986         * solib-darwin.c (darwin_bfd_open): Likewise.
 987         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 988
 989 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 990
 991         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 992         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 993
 994 2019-09-03  Tom Tromey  <tromey@adacore.com>
 995
 996         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 997         types.
 998         (has_negatives): Unbias a range type bound.
 999         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1000         * gdbtypes.c (operator==): Handle new field.
1001         (create_range_type): Add "bias" parameter.
1002         (create_static_range_type, resolve_dynamic_range): Update.
1003         * gdbtypes.h (struct range_bounds) <bias>: New member.
1004         (create_range_type): Add bias parameter.
1005         * printcmd.c (print_scalar_formatted): Unbias range types.
1006         * value.c (unpack_long): Unbias range types.
1007         (pack_long): Bias range types.
1008
1009 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1010
1011         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1012         probe arguments.
1013
1014 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1015
1016         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1017         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1018         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1019         (compile_probe_arg): Likewise.
1020         * probe.h (get_argument_count): Likewise.
1021         * solib-svr4.c (solib_event_probe_action): Likewise.
1022         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1023
1024 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1025
1026         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1027         code to here...
1028         (svr4_create_solib_event_breakpoints): ...from here.
1029
1030 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1031
1032         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1033         suffix from warning message.
1034
1035 2019-08-30  Tom Tromey  <tom@tromey.com>
1036
1037         * tui/tui-winsource.h (struct tui_source_window_base)
1038         <refresh_all>: Don't declare.
1039         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1040         Remove.
1041         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1042         tui_show_locator_content.
1043         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1044         declare.
1045         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1046         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1047         declare.
1048
1049 2019-08-30  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1052
1053 2019-08-30  Tom Tromey  <tom@tromey.com>
1054
1055         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1056         Remove unnecessary forward declarations.
1057
1058 2019-08-30  Tom Tromey  <tom@tromey.com>
1059
1060         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1061         rerender.
1062         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1063         tui_show_locator_content.
1064
1065 2019-08-30  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1068         (tui_locator_window::rerender): Rewrite using body of previous
1069         tui_show_locator_content.
1070
1071 2019-08-30  Tom Tromey  <tom@tromey.com>
1072
1073         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1074         set_locator_fullname>: New methods.
1075         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1076         Rename from tui_set_locator_fullname.
1077         (tui_locator_window::set_locator_info): Rename from
1078         tui_set_locator_info.  Return bool.
1079         (tui_update_locator_fullname, tui_show_frame_info): Update.
1080
1081 2019-08-30  Tom Tromey  <tom@tromey.com>
1082
1083         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1084
1085 2019-08-30  Tom Tromey  <tom@tromey.com>
1086
1087         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1088         call touchwin.
1089
1090 2019-08-30  Tom Tromey  <tom@tromey.com>
1091
1092         * tui/tui-wingeneral.c (box_win): Assume win_info and
1093         win_info->handle cannot be NULL.
1094
1095 2019-08-30  Tom Tromey  <tom@tromey.com>
1096
1097         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1098         refresh_window>: Declare.
1099         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1100         resize.
1101         (tui_data_item_window::rerender): Rename from
1102         tui_display_register.
1103         (tui_data_item_window::refresh_window): New method.
1104         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1105         no-op.
1106
1107 2019-08-30  Tom Tromey  <tom@tromey.com>
1108
1109         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1110         regs_column_count, current_group>: Move later.  Now private.
1111         <get_current_group>: New method.
1112         * tui/tui-regs.c (tui_reg_command): Update.
1113         * tui/tui-layout.c (tui_set_layout): Update.
1114
1115 2019-08-30  Tom Tromey  <tom@tromey.com>
1116
1117         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1118         (tui_data_window::rerender): Don't call
1119         check_and_display_highlight_if_needed.
1120         (tui_data_window::refresh_all): Remove call to
1121         erase_data_content.
1122
1123 2019-08-30  Tom Tromey  <tom@tromey.com>
1124
1125         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1126         (tui_data_window::display_registers_from)
1127         (tui_data_window::display_reg_element_at_line)
1128         (tui_data_window::display_registers_from_line): Remove checks of
1129         "empty".
1130
1131 2019-08-30  Tom Tromey  <tom@tromey.com>
1132
1133         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1134         Don't declare.
1135         * tui/tui-regs.c (tui_data_window::show_registers): Call
1136         rerender.
1137         (tui_data_window::rerender): Rename from display_all_data.
1138         (tui_data_window::rerender): Remove old implementation.
1139
1140 2019-08-30  Tom Tromey  <tom@tromey.com>
1141
1142         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1143         text.
1144         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1145
1146 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1147             Sergio Durigan Junior  <sergiodj@redhat.com>
1148
1149         PR win32/24284
1150         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1151
1152 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1153
1154         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1155         when searching for types.
1156
1157 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1158
1159         * f-lang.c (f_language_defn): Use f_print_typedef.
1160         * f-lang.h (f_print_typedef): Declare.
1161         * f-typeprint.c (f_print_typedef): Define.
1162
1163 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1164
1165         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1166
1167 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1168
1169         * cli/cli-utils.c (info_print_options_defs): Delete.
1170         (make_info_print_options_def_group): Delete.
1171         (extract_info_print_options): Delete.
1172         (info_print_command_completer): Delete.
1173         (info_print_args_help): Add extra parameter, and optionally
1174         include text about -n flag.
1175         * cli/cli-utils.h (struct info_print_options): Delete.
1176         (extract_info_print_options): Delete declaration.
1177         (info_print_command_completer): Delete declaration.
1178         (info_print_args_help): Add extra parameter, extend header
1179         comment.
1180         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1181         search_symbols.
1182         * stack.c (struct info_print_options): New type.
1183         (info_print_options_defs): New file scoped variable.
1184         (make_info_print_options_def_group): New static function.
1185         (info_print_command_completer): New static function.
1186         (info_locals_command): Update to use new local functions.
1187         (info_args_command): Likewise.
1188         (_initialize_stack): Add extra parameter to calls to
1189         info_print_args_help.
1190         * symtab.c (search_symbols): Add extra parameter, use this to
1191         possibly excluse non-debug symbols.
1192         (symtab_symbol_info): Add extra parameter, which is passed on to
1193         search_symbols.
1194         (struct info_print_options): New type.
1195         (info_print_options_defs): New file scoped variable.
1196         (make_info_print_options_def_group): New static function.
1197         (info_print_command_completer): New static function.
1198         (info_variables_command): Update to use local functions, and pass
1199         extra parameter through to symtab_symbol_info.
1200         (info_functions_command): Likewise.
1201         (info_types_command): Pass additional argument through to
1202         symtab_symbol_info.
1203         (rbreak_command): Pass extra argument to search_symbols.
1204         (_initialize_symtab): Add extra arguments for calls to
1205         info_print_args_help, and update help text for 'info variables',
1206         'whereis', and 'info functions' commands.
1207         * symtab.h (search_symbols): Add extra argument to declaration.
1208         * NEWS: Mention new flags.
1209
1210 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1211
1212         * symtab.c (lookup_static_symbol): Call the new function (and move
1213         it down to be next to lookup_global_symbol).
1214         (struct global_sym_lookup_data): Add block_enum member and rename to...
1215         (struct global_or_static_sym_lookup_data): ...this.
1216         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1217         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1218         (lookup_symbol_global_or_static_iterator_cb): ...this.
1219         (lookup_global_or_static_symbol): New function.
1220         (lookup_global_symbol): Call new function.
1221
1222 2019-08-26  Tom de Vries  <tdevries@suse.de>
1223
1224         PR c++/24852
1225         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1226         when pc_probe.prob == NULL.
1227
1228 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1229
1230         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1231         variable symbol_linkage to symbol_linkage_.
1232
1233 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1234
1235         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1236         represent whether the symbol is static, dynamic, or we don't
1237         know.
1238
1239 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1240
1241         * gdb/rx-tdep.c (rx_register_names): New.
1242         (rx_register_name): Delete.
1243         (rx_psw_type): Delete.
1244         (rx_fpsw_type): Delete.
1245         (rx_register_type): Delete.
1246         (rx_gdbarch_init): Convert target-descriptions.
1247         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1248         * gdb/features/Makefile: Add rx.xml.
1249         * gdb/features/rx.xml: New.
1250         * gdb/features/rx.c: Generated.
1251         * gdb/NEWS: Mention target description support.
1252
1253 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1254
1255         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1256         *slot_ptr.
1257
1258 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1259
1260         * configure.ac: Don't check for 'dlfcn.h' (moved to
1261         gdbsupport/common.m4).
1262         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1263         'gdbsupport/'.
1264         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1265         * compile/compile-c-support.c: Include
1266         'gdbsupport/gdb-dlfcn.h'.
1267         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1268         * gdb-dlfcn.c: Move to...
1269         * gdbsupport/gdb-dlfcn.c: ... here.
1270         * gdb-dlfcn.h: Move to...
1271         * gdbsupport/gdb-dlfcn.h: ... here.
1272
1273 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1274
1275         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1276         the offset field signed.
1277
1278 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1279
1280         * python/lib/gdb/__init__.py (_execute_file): New function.
1281         * python/python.c (python_run_simple_file): Call gdb._execute_file
1282         on Windows.
1283
1284 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1285
1286         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1287         all uses as this was never set to anything but a zero value.
1288
1289 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1290
1291         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1292
1293 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1294
1295         * tui/tui-data.h (tui_gen_win_info): Add an =default
1296         move constructor, required by some GCC versions.
1297
1298 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1299
1300         * go32-nat.c (go32_sysinfo): Add hygon_p.
1301
1302 2019-08-20  Tom Tromey  <tom@tromey.com>
1303
1304         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1305         line_from_reg_element_no, first_reg_element_no_inline,
1306         display_all_data, delete_data_content_windows,
1307         erase_data_content>: Now private.
1308
1309 2019-08-20  Tom Tromey  <tom@tromey.com>
1310
1311         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1312         (tui_unhighlight_win, tui_highlight_win)
1313         (tui_win_info::make_window): Update.
1314         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1315
1316 2019-08-20  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1319         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1320         (MAX_PID_WIDTH): Move to tui-stack.c.
1321         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1322         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1323         (MAX_PID_WIDTH): Move from tui-data.h.
1324
1325 2019-08-20  Tom Tromey  <tom@tromey.com>
1326
1327         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1328         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1329         (box_win): Update.
1330         (tui_gen_win_info::make_window): Rename from tui_make_window.
1331         (tui_win_info::make_window): New method.
1332         (tui_gen_win_info::make_visible): Update.
1333         * tui/tui-source.c (tui_source_window::set_contents): Update.
1334         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1335         (tui_data_window::display_registers_from): Update.
1336         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1337         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1338         Declare.
1339         <can_box>: Remove.
1340         <title>: Remove.
1341         (struct tui_win_info) <make_window>: Declare.
1342         <can_box>: Now virtual.
1343         <title>: New member.
1344         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1345         * tui/tui-command.c (tui_cmd_window::resize): Update.
1346
1347 2019-08-20  Tom Tromey  <tom@tromey.com>
1348
1349         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1350         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1351         (tui_data_window::check_register_values): Update.
1352
1353 2019-08-20  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-regs.h (struct tui_data_window): Use
1356         DISABLE_COPY_AND_ASSIGN.
1357         <regs_content>: Change type, removing unique_ptr.
1358         <tui_data_window>: Add move constructor.
1359         * tui/tui-regs.c (tui_data_window::show_registers)
1360         (tui_data_window::show_register_group)
1361         (tui_data_window::display_registers_from)
1362         (tui_data_window::display_registers_from)
1363         (tui_data_window::first_data_item_displayed)
1364         (tui_data_window::delete_data_content_windows)
1365         (tui_data_window::rerender, tui_data_window::refresh_window)
1366         (tui_data_window::check_register_values): Update.
1367
1368 2019-08-20  Tom Tromey  <tom@tromey.com>
1369
1370         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1371         show_register_group>: Declare.
1372         (tui_show_register_group): Don't declare.
1373         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1374         tui_show_registers.
1375         (tui_data_window::show_register_group): Rename from
1376         tui_show_register_group.
1377         (tui_data_window::check_register_values, tui_reg_command):
1378         Update.
1379         * tui/tui-layout.c (tui_set_layout): Update.
1380
1381 2019-08-20  Tom Tromey  <tom@tromey.com>
1382
1383         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1384         Declare.
1385         (tui_check_register_values): Don't declare.
1386         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1387         from tui_check_register_values.
1388         * tui/tui-hooks.c (tui_register_changed): Update.
1389
1390 2019-08-20  Tom Tromey  <tom@tromey.com>
1391
1392         * tui/tui-regs.c (tui_reg_layout): Move later.
1393         (tui_show_registers): Don't enable TUI mode or change layout.
1394
1395 2019-08-20  Tom Tromey  <tom@tromey.com>
1396
1397         * tui/tui-regs.h (struct tui_data_item_window)
1398         <~tui_data_item_window>: Remove.
1399         <content>: Now a unique_xmalloc_ptr.
1400         * tui/tui-regs.c (tui_register_format): Return a
1401         unique_xmalloc_ptr.
1402         (tui_get_register): Update.
1403         (~tui_data_item_window): Remove.
1404         (tui_data_window::display_registers_from, tui_display_register):
1405         Update.
1406         * tui/tui-io.h (tui_expand_tabs): Update.
1407         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1408         Remove "col" parameter.
1409
1410 2019-08-20  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1413         field.
1414         * tui/tui-regs.c (~tui_data_item_window): Update.
1415
1416 2019-08-20  Tom Tromey  <tom@tromey.com>
1417
1418         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1419         earlier.
1420
1421 2019-08-20  Tom Tromey  <tom@tromey.com>
1422
1423         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1424
1425 2019-08-20  Tom Tromey  <tom@tromey.com>
1426
1427         * tui/tui-source.h (struct tui_source_window): Update.
1428         * tui/tui-regs.c (tui_show_registers): Update.
1429         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1430         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1431         (NO_REGS_STRING): Remove defines.
1432
1433 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1434
1435         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1436         unnecessary thread walk if remote doesn't support the packet.
1437
1438 2019-08-19  Tom Tromey  <tromey@adacore.com>
1439
1440         * python/py-value.c (value_has_field): Fix indentation.
1441
1442 2019-08-19  Tom Tromey  <tromey@adacore.com>
1443
1444         * printcmd.c (do_one_display, info_display_command): Update.
1445         * block.h (contained_in): Return bool.  Add allow_nested
1446         parameter.
1447         * block.c (contained_in): Return bool.  Add allow_nested
1448         parameter.
1449
1450 2019-08-19  Tom Tromey  <tom@tromey.com>
1451
1452         * configure: Rebuild.
1453         * configure.ac: Disallow the combination of -static-libstdc++ and
1454         source highlight.
1455         * source-cache.c (get_language_name): Handle rust.
1456         (source_cache::get_source_lines): Ignore highlighting exceptions.
1457
1458 2019-08-16  Tom Tromey  <tom@tromey.com>
1459
1460         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1461         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1462         (struct tui_source_window_base) <make_visible, refresh_window,
1463         resize>: Remove methods.
1464         <execution_info>: Remove field.
1465         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1466         (tui_show_source_line, tui_source_window_base)
1467         (~tui_source_window_base): Update.
1468         (tui_source_window_base::resize)
1469         (tui_source_window_base::make_visible)
1470         (tui_source_window_base::refresh_window): Remove.
1471         (tui_source_window_base::update_exec_info): Update.
1472         * tui/tui-source.c (tui_source_window::set_contents): Update.
1473         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1474
1475 2019-08-16  Tom Tromey  <tom@tromey.com>
1476
1477         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1478         deprecated_query_hook.
1479
1480 2019-08-16  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1483         (tui_update_source_windows_with_line): Update.
1484         * tui/tui-source.h (struct tui_source_window)
1485         <show_symtab_source>: Declare.
1486         (tui_show_symtab_source): Don't declare.
1487         * tui/tui-source.c (tui_show_symtab_source): Rename from
1488         tui_show_symtab_source.
1489
1490 2019-08-16  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-winsource.h (struct tui_source_window_base)
1493         <set_contents>: Declare.
1494         * tui/tui-winsource.c
1495         (tui_source_window_base::update_source_window_as_is): Update.
1496         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1497         Declare.
1498         (tui_set_source_content): Don't declare.
1499         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1500         tui_set_source_content.
1501         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1502         Declare.
1503         (tui_set_disassem_content): Don't declare.
1504         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1505         tui_set_disassem_content.
1506
1507 2019-08-16  Tom Tromey  <tom@tromey.com>
1508
1509         * tui/tui-winsource.h (struct tui_source_window_base)
1510         <update_breakpoint_info>: Declare.
1511         (tui_update_breakpoint_info): Don't declare.
1512         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1513         (tui_update_all_breakpoint_info): Update.
1514         (tui_source_window_base::update_breakpoint_info): Rename from
1515         tui_update_breakpoint_info.
1516         (tui_source_window_base::update_exec_info): Update.
1517
1518 2019-08-16  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-winsource.h (struct tui_source_window_base)
1521         <update_source_window>: Declare.
1522         (tui_update_source_window): Don't declare.
1523         * tui/tui-winsource.c
1524         (tui_source_window_base::update_source_window): Rename from
1525         tui_update_source_window.
1526         (tui_source_window_base::rerender): Update.
1527         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1528         * tui/tui-disasm.c (tui_show_disassem)
1529         (tui_show_disassem_and_update_source)
1530         (tui_disasm_window::maybe_update): Update.
1531
1532 2019-08-16  Tom Tromey  <tom@tromey.com>
1533
1534         * tui/tui-winsource.h (struct tui_source_window_base)
1535         <update_source_window_as_is>: Declare.
1536         (tui_update_source_window_as_is): Don't declare.
1537         * tui/tui-winsource.c (tui_update_source_window): Update
1538         (tui_source_window_base::update_source_window_as_is): Rename from
1539         tui_update_source_window_as_is.
1540         (tui_source_window_base::refill): Update.
1541         * tui/tui-source.c (tui_show_symtab_source): Update.
1542         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1543         Update.
1544
1545 2019-08-16  Tom Tromey  <tom@tromey.com>
1546
1547         * tui/tui-winsource.h (tui_update_source_window)
1548         (tui_update_source_window_as_is): Remove "noerror" parameter.
1549         * tui/tui-winsource.c (tui_update_source_window)
1550         (tui_update_source_window_as_is): Remove "noerror" parameter.
1551         (tui_update_source_windows_with_addr)
1552         (tui_update_source_windows_with_line)
1553         (tui_source_window_base::rerender)
1554         (tui_source_window_base::refill): Update.
1555         * tui/tui-source.h (tui_set_source_content)
1556         (tui_show_symtab_source): Remove "noerror" parameter.
1557         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1558         parameter.
1559         (tui_show_symtab_source): Likewise.
1560         (tui_source_window::maybe_update): Update.
1561         * tui/tui-disasm.c (tui_show_disassem)
1562         (tui_show_disassem_and_update_source)
1563         (tui_disasm_window::do_scroll_vertical)
1564         (tui_disasm_window::maybe_update): Update.
1565
1566 2019-08-16  Tom Tromey  <tom@tromey.com>
1567
1568         * tui/tui.c (tui_is_window_visible): Update.
1569         * tui/tui-wingeneral.c (tui_make_window)
1570         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1571         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1572         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1573         (tui_set_win_height_command, parse_scrolling_args): Update.
1574         * tui/tui-source.c (tui_source_window::style_changed): Update.
1575         * tui/tui-regs.c (tui_show_registers)
1576         (tui_data_window::first_data_item_displayed)
1577         (tui_data_window::delete_data_content_windows)
1578         (tui_check_register_values, tui_reg_command): Update.
1579         * tui/tui-disasm.c (tui_show_disassem): Update.
1580         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1581         method.
1582         <is_visible>: Remove field.
1583         * tui/tui-data.c (tui_next_win, tui_prev_win)
1584         (tui_delete_invisible_windows): Update.
1585
1586 2019-08-16  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui-winsource.h (struct tui_source_window_base)
1589         <m_has_locator>: Remove.
1590         * tui/tui-layout.c (show_source_disasm_command, show_data)
1591         (show_source_or_disasm_and_command): Update.
1592
1593 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1594
1595         * NEWS (Other MI changes): New subsection.
1596         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1597         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1598         * arch-utils.c (default_get_pc_address_flags): New function.
1599         * arch-utils.h (default_get_pc_address_flags): New declaration.
1600         * gdbarch.sh: Add get_pc_address_flags.
1601         * gdbarch.c: Regenerate.
1602         * gdbarch.h: Likewise.
1603         * stack.c (print_pc): New function.
1604         (print_frame_info) (print_frame): Call print_pc.
1605
1606 2019-08-16  Tom de Vries  <tdevries@suse.de>
1607
1608         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1609         print_objfile_section_info.
1610
1611 2019-08-15  Tom Tromey  <tom@tromey.com>
1612
1613         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1614         calling update_cmdwin_start_line.
1615         * tui/tui-winsource.h (struct tui_source_window_base)
1616         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1617         <rerender>: Declare.
1618         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1619         Call rerender.
1620         (tui_source_window_base::set_new_height): Remove.
1621         (tui_source_window_base::rerender): Rename from
1622         do_make_visible_with_new_height.
1623         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1624         resize method.
1625         (tui_win_info::make_invisible_and_set_new_height)
1626         (tui_win_info::make_visible_with_new_height): Remove.
1627         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1628         Declare.
1629         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1630         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1631         do_make_visible_with_new_height>: Don't declare.
1632         <rerender>: Declare.
1633         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1634         set_new_height.
1635         (tui_data_window::do_make_visible_with_new_height): Remove.
1636         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1637         call tui_show_locator_content.
1638         (tui_gen_win_info::resize): Call rerender.
1639         (show_source_or_disasm_and_command): Don't call
1640         tui_show_locator_content.
1641         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1642         method.
1643         (struct tui_win_info) <rerender>: Declare.
1644         <set_new_height, make_invisible_and_set_new_height,
1645         make_visible_with_new_height>: Don't declare.
1646         * tui/tui-data.c (tui_win_list::rerender): New method.
1647         * tui/tui-command.h (struct tui_cmd_window)
1648         <do_make_visible_with_new_height>: Don't declare.
1649         * tui/tui-command.c
1650         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1651
1652 2019-08-15  Tom Tromey  <tromey@adacore.com>
1653
1654         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1655         * ada-lang.c (ada_enum_name): Likewise.
1656
1657 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1658
1659         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1660         leading underscore.
1661         (GdbOutputErrorFile): Likewise.
1662         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1663         accordingly.
1664         (execute_unwinders): Rename to have a leading underscore.
1665         (auto_load_packages): Likewise.
1666         (global scope): Adjust call to auto_load_packages accordingly.
1667         (GdbSetPythonDirectory): Likewise.
1668         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1669         instead of execute_unwinders.
1670
1671 2019-08-15  Tom Tromey  <tom@tromey.com>
1672
1673         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1674         (show_data): Don't change window visibility.
1675         (tui_gen_win_info::resize): Remove special case for command
1676         window.  Use wresize, when available.
1677         (show_source_or_disasm_and_command): Don't change window
1678         visibility.
1679         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1680         <make_visible>: New method.
1681         * tui/tui-command.c (tui_cmd_window::resize): New method.
1682
1683 2019-08-15  Tom Tromey  <tom@tromey.com>
1684
1685         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1686         (struct tui_source_windows): New.
1687         * tui/tui-winsource.c (tui_display_main): Update.
1688         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1689         (new_height_ok, parse_scrolling_args): Update.
1690         * tui/tui-layout.c (show_layout, show_data): Update.
1691         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1692         (tui_add_to_source_windows): Don't declare.
1693         * tui/tui-data.c (source_windows, tui_source_windows)
1694         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1695
1696 2019-08-15  Tom Tromey  <tom@tromey.com>
1697
1698         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1699         Rename from reset.
1700         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1701         * tui/tui-layout.c (show_source_disasm_command, show_data):
1702         Update.
1703         (tui_gen_win_info::resize): Rename.
1704         (show_source_or_disasm_and_command): Update.
1705         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1706         reset.
1707
1708 2019-08-15  Tom Tromey  <tom@tromey.com>
1709
1710         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1711         * tui/tui-interp.c (tui_interp::init): Don't call
1712         tui_initialize_static_data.
1713         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1714
1715 2019-08-15  Tom Tromey  <tom@tromey.com>
1716
1717         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1718         examine tui_win_list.
1719
1720 2019-08-15  Tom Tromey  <tom@tromey.com>
1721
1722         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1723         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1724         tui_clear_source_content.
1725         (tui_clear_source_content): Remove.
1726         (tui_source_window_base::do_erase_source_content): Hoist call to
1727         content.clear().
1728         * tui/tui-stack.c (tui_show_frame_info): Don't call
1729         tui_clear_source_content.
1730
1731 2019-08-15  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-winsource.h (struct tui_source_window_base)
1734         <do_erase_source_content>: New method.
1735         <erase_source_content>: New method.
1736         (tui_erase_source_content): Don't declare.
1737         * tui/tui-winsource.c (tui_clear_source_content): Update.
1738         (tui_source_window_base::do_erase_source_content): Rename from
1739         tui_erase_source_content.
1740         (tui_source_window_base::show_source_content): Update.
1741         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1742         * tui/tui-source.h (struct tui_source_window)
1743         <erase_source_content>: New method.
1744         * tui/tui-disasm.h (struct tui_disasm_window)
1745         <erase_source_content>: New method.
1746
1747 2019-08-15  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1750         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1751         constructor.
1752         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1753         * tui/tui-source.c (tui_set_source_content): Update.
1754         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1755
1756 2019-08-15  Tom Tromey  <tom@tromey.com>
1757
1758         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1759         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1760         tui-source.c.
1761         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1762         Declare.
1763         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1764         method.
1765         (tui_source_window::maybe_update): Update.
1766
1767 2019-08-15  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1770         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1771         tui-disasm.c.
1772         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1773         Declare.
1774         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1775         method.
1776         (tui_disasm_window::maybe_update): Update.
1777
1778 2019-08-15  Tom Tromey  <tom@tromey.com>
1779
1780         * tui/tui-winsource.h (struct tui_source_window_base)
1781         <maybe_update>: Declare.
1782         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1783         method.
1784         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1785         Declare.
1786         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1787         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1788         Declare.
1789         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1790
1791 2019-08-15  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1794
1795 2019-08-15  Tom Tromey  <tom@tromey.com>
1796
1797         * tui/tui-wingeneral.c: Include tui-stack.h.
1798         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1799         (struct tui_locator_window): Move from tui-data.h.
1800         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1801         (tui_initialize_static_data): Move from tui-data.c.
1802         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1803         (struct tui_locator_window): Move to tui-stack.c.
1804         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1805         (tui_initialize_static_data): Move to tui-stack.c.
1806
1807 2019-08-15  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-layout.c (show_source_disasm_command)
1810         (show_source_or_disasm_and_command): Use make_visible method, not
1811         tui_make_window.
1812         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1813         Remove.
1814
1815 2019-08-15  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-wingeneral.h (tui_make_window): Update.
1818         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1819         parameter.
1820         (tui_gen_win_info::make_visible): Update.
1821         * tui/tui-regs.c (tui_data_window::display_registers_from):
1822         Update.
1823         * tui/tui-layout.c (show_source_disasm_command)
1824         (show_source_or_disasm_and_command): Update.
1825         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1826         (enum tui_box): Remove.
1827         (struct tui_win_info) <can_box>: New method.
1828         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1829         method.
1830
1831 2019-08-15  Tom de Vries  <tdevries@suse.de>
1832
1833         * linux-nat-trad.c: Include gdbarch.h.
1834
1835 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1836
1837         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1838         register sizes.
1839
1840 2019-08-14  Tom Tromey  <tromey@adacore.com>
1841
1842         * darwin-nat.c: Include gdbarch.h.
1843         * darwin-nat-info.c: Include gdbarch.h.
1844
1845 2019-08-13  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1848         Remove.
1849         * tui/tui-data.c (tui_initialize_static_data): Update.
1850
1851 2019-08-13  Tom Tromey  <tom@tromey.com>
1852
1853         * tui/tui-winsource.h (struct tui_exec_info_window)
1854         <~tui_exec_info_window, maybe_allocate_content, get_content,
1855         m_content>: Remove.
1856         (struct tui_source_window_base) <set_exec_info_content,
1857         show_exec_info_content>: Don't declare.
1858         * tui/tui-winsource.c
1859         (tui_exec_info_window::maybe_allocate_content): Remove.
1860         (tui_source_window_base::update_exec_info): Rename from
1861         set_exec_info_content.
1862         (tui_source_window_base::show_exec_info_content)
1863         (tui_source_window_base::update_exec_info): Remove.
1864
1865 2019-08-13  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1868         declare.
1869         * tui/tui-winsource.c (tui_update_source_window_as_is)
1870         (tui_update_source_windows_with_addr, tui_erase_source_content):
1871         Update.
1872         (tui_clear_exec_info_content): Remove.
1873
1874 2019-08-13  Tom Tromey  <tom@tromey.com>
1875
1876         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1877         declare.
1878         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1879         call tui_erase_exec_info_content.
1880         (tui_clear_exec_info_content): Rename from
1881         tui_erase_exec_info_content.
1882         (tui_clear_exec_info_content): Delete.
1883
1884 2019-08-13  Tom Tromey  <tom@tromey.com>
1885
1886         * tui/tui-winsource.h (struct tui_source_window_base)
1887         <show_exec_info_content>: Declare.
1888         (tui_show_exec_info_content): Don't declare.
1889         * tui/tui-winsource.c
1890         (tui_source_window_base::show_exec_info_content): Rename from
1891         tui_show_exec_info_content.
1892         (tui_source_window_base::update_exec_info): Update.
1893
1894 2019-08-13  Tom Tromey  <tom@tromey.com>
1895
1896         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1897         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1898         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1899         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1900         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1901         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1902         ... here.
1903
1904 2019-08-13  Tom Tromey  <tom@tromey.com>
1905
1906         * tui/tui-winsource.h (struct tui_source_window_base)
1907         <update_exec_info>: Declare.
1908         (tui_update_exec_info): Don't declare.
1909         * tui/tui-winsource.c (tui_update_source_window_as_is)
1910         (tui_source_window_base::refresh_all)
1911         (tui_update_all_breakpoint_info): Update.
1912         (tui_source_window_base::update_exec_info): Rename from
1913         tui_update_exec_info.
1914         * tui/tui-stack.c (tui_show_frame_info): Update.
1915
1916 2019-08-13  Tom Tromey  <tom@tromey.com>
1917
1918         * tui/tui-winsource.h (struct tui_source_window_base)
1919         <set_exec_info_content>: Declare.
1920         (tui_set_exec_info_content): Don't declare.
1921         * tui/tui-winsource.c
1922         (tui_source_window_base::set_exec_info_content): Rename from
1923         tui_set_exec_info_content.
1924         (tui_update_exec_info): Update.
1925
1926 2019-08-13  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-winsource.h (struct tui_source_window_base)
1929         <show_source_content>: Declare.
1930         (tui_show_source_content): Don't declare.
1931         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1932         (tui_source_window_base::show_source_content): Rename from
1933         tui_show_source_content.
1934         (tui_source_window_base::refresh_all): Update.
1935         * tui/tui-layout.c (show_source_disasm_command)
1936         (show_source_or_disasm_and_command): Update.
1937
1938 2019-08-13  Tom Tromey  <tom@tromey.com>
1939
1940         * tui/tui-winsource.c (tui_erase_source_content)
1941         (tui_show_source_content, tui_source_window_base::refresh_all):
1942         Update.
1943         * tui/tui-wingeneral.h
1944         (tui_check_and_display_highlight_if_needed): Don't declare.
1945         * tui/tui-wingeneral.c
1946         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1947         check_and_display_highlight_if_needed.
1948         * tui/tui-win.c (tui_rehighlight_all)
1949         (tui_win_info::make_visible_with_new_height): Update.
1950         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1951         (tui_data_window::erase_data_content)
1952         (tui_data_window::display_all_data): Update.
1953         * tui/tui-data.h (struct tui_win_info)
1954         <check_and_display_highlight_if_needed>: Declare.
1955
1956 2019-08-13  Tom Tromey  <tom@tromey.com>
1957
1958         * tui/tui-win.c (tui_resize_all): Call
1959         tui_delete_invisible_windows.
1960         * tui/tui-layout.c (show_layout): Call
1961         tui_delete_invisible_windows.
1962         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1963         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1964
1965 2019-08-13  Tom Tromey  <tom@tromey.com>
1966
1967         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1968         tui_add_win_to_layout.
1969
1970 2019-08-13  Tom Tromey  <tom@tromey.com>
1971
1972         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1973         * tui/tui-layout.c (tui_default_win_height): Now static.
1974
1975 2019-08-13  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1978         single switch.
1979         (show_source_disasm_command, show_source_or_disasm_and_command):
1980         Don't check current layout.
1981
1982 2019-08-13  Tom Tromey  <tom@tromey.com>
1983
1984         * tui/tui-wingeneral.c (make_all_visible): Remove.
1985         (tui_make_all_invisible): Simplify.
1986         * tui/tui-layout.c (tui_make_all_invisible): Move from
1987         tui-wingeneral.c; simplify.
1988         (show_layout): Hoist call to tui_make_all_invisible.
1989         (show_data): Don't call tui_make_all_invisible.
1990
1991 2019-08-13  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1994         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1995
1996 2019-08-13  Tom Tromey  <tom@tromey.com>
1997
1998         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1999         tui-data.c.
2000         (show_source_disasm_command, show_data)
2001         (show_source_or_disasm_and_command): Don't use
2002         tui_set_current_layout_to.
2003         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2004         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2005         tui-layout.c.
2006         (tui_set_current_layout_to): Remove.
2007
2008 2019-08-13  Tom Tromey  <tom@tromey.com>
2009
2010         * tui/tui-layout.c (tui_set_layout): Update.
2011         * tui/tui-data.h (struct tui_layout_def): Remove.
2012         (tui_layout_def): Don't declare.
2013         * tui/tui-data.c (layout_def): Remove.
2014         (tui_layout_def): Remove.
2015
2016 2019-08-13  Tom Tromey  <tom@tromey.com>
2017
2018         * tui/tui-winsource.h (struct tui_source_window_base)
2019         <clear_detail>: No longer "override".
2020         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2021         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2022         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2023         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2024         Remove.
2025         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2026
2027 2019-08-13  Tom Tromey  <tromey@adacore.com>
2028
2029         * tracepoint.c: Don't include readline.h or history.h.
2030
2031 2019-08-12  Tom Tromey  <tom@tromey.com>
2032
2033         * configure: Rebuild.
2034         * configure.ac: Check for readline 7.
2035         * NEWS: Mention readline 7 requirement.
2036         * README: Update.
2037
2038 2019-08-12  Tom Tromey  <tom@tromey.com>
2039
2040         * mingw-hdep.c (gdb_select): Remove readline hack.
2041
2042 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2043
2044         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2045         when the function fails.
2046
2047 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2048
2049         * s390-tdep.c (s390_type_align): New function.
2050         (s390_gdbarch_init): Set it as type_align gdbarch method.
2051
2052 2019-08-09  Tom de Vries  <tdevries@suse.de>
2053
2054         PR gdb/24591
2055         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2056         pc_low with relocation offset.
2057
2058 2019-08-07  Tom Tromey  <tromey@adacore.com>
2059
2060         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2061         (print_frame_args): Update.
2062         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2063         Update.
2064         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2065         * frame.h (struct frame_arg): Add initializers.
2066         <error>: Now a unique_xmalloc_ptr.
2067
2068 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2069
2070         * NEWS: Expand the Pointer Authentication entry.
2071         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2072         (aarch64_frame_unmask_lr): ... to this.
2073         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2074         Call aarch64_frame_unmask_lr.
2075         * frame.c (struct frame_info): Add "masked" variable.
2076         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2077         (fprint_frame): Check for masked pc.
2078         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2079         declarations.
2080         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2081         * stack.c (print_frame): Check for masked pc.
2082
2083 2019-08-06  Tom Tromey  <tom@tromey.com>
2084
2085         * stabsread.c (patch_block_stabs, read_one_struct_field)
2086         (read_enum_type): Use obstack_strndup.
2087         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2088         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2089         * dwarf2read.c (guess_full_die_structure_name)
2090         (anonymous_struct_prefix): Use obstack_strndup.
2091         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2092         * c-exp.y (yylex): Use obstack_strndup.
2093         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2094         (write_var_or_type): Use obstack_strndup.
2095
2096 2019-08-06  Tom Tromey  <tom@tromey.com>
2097
2098         * symfile.c (reread_symbols): Use obstack_strdup.
2099         * stabsread.c (read_type): Use obstack_strdup.
2100         * gdb_obstack.h (obstack_strdup): New overload.
2101         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2102         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2103         (dwarf2_canonicalize_name): Use obstack_strdup.
2104         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2105         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2106         Use obstack_strdup.
2107
2108 2019-08-06  Tom Tromey  <tom@tromey.com>
2109
2110         * gdb_obstack.h (obstack_strdup): Define.
2111         * gdb_obstack.c (obstack_strdup): Don't define.
2112
2113 2019-08-06  Tom Tromey  <tom@tromey.com>
2114
2115         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2116         obstack_strdup.
2117         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2118         obstack_strdup.
2119         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2120         * stabsread.c (common_block_start): Use obstack_strdup.
2121         * objfiles.c (set_objfile_main_name, objfile): Use
2122         obstack_strdup.
2123         * namespace.c (add_using_directive): Use obstack_strdup.
2124         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2125         * jit.c (finalize_symtab): Use obstack_strdup.
2126         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2127         (guess_partial_die_structure_name, partial_die_info::fixup)
2128         (dwarf2_name): Use obstack_strdup.
2129         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2130         obstack_strdup.
2131         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2132         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2133         obstack_strdup.
2134         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2135
2136 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2137
2138         * unittests/help-doc-selftests.c: New file.
2139         * Makefile.in: Add the new file.
2140
2141 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2142
2143         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2144         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2145         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2146         the trailing '.' is not output, and the first character is uppercased.
2147         (print_help_for_command): Update call to print_doc_line.
2148         (print_doc_of_command): Likewise.
2149         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2150         * cli/cli-option.c (append_indented_doc): Do not append newline.
2151         (build_help_option): Append newline after first appended_indented_doc
2152         only if a second call is done.
2153         (build_help): Append 2 new lines before each option, except the first
2154         one.
2155         * compile/compile.c (_initialize_compile): Add new lines after
2156         %OPTIONS%, when not at the end of the help.
2157         Change help doc or code
2158         producing the help doc to respect the invariants.
2159         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2160         Also removed the new line after 'Options:', as all other commands
2161         do not put an empty line between 'Options:' and the first option.
2162         * printcmd.c (_initialize_printcmd): Likewise.
2163         * stack.c (_initialize_stack): Likewise.
2164         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2165         incorrectly telling COMMAND is optional.
2166         * ada-lang.c (_initialize_ada_language): Change help doc or code
2167         producing the help doc to respect the invariants.
2168         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2169         * breakpoint.c (_initialize_breakpoint): Likewise.
2170         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2171         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2172         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2173         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2174         _initialize_cli_style): Likewise.
2175         * corelow.c (core_target_info): Likewise.
2176         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2177         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2178         * filesystem.c (_initialize_filesystem): Likewise.
2179         * frame.c (_initialize_frame): Likewise.
2180         * gnu-nat.c (add_task_commands): Likewise.
2181         * infcall.c (_initialize_infcall): Likewise.
2182         * infcmd.c (_initialize_infcmd): Likewise.
2183         * interps.c (_initialize_interpreter): Likewise.
2184         * language.c (_initialize_language): Likewise.
2185         * linux-fork.c (_initialize_linux_fork): Likewise.
2186         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2187         * maint.c (_initialize_maint_cmds): Likewise.
2188         * memattr.c (_initialize_mem): Likewise.
2189         * printcmd.c (_initialize_printcmd): Likewise.
2190         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2191         _RegEx): Likewise.
2192         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2193         * record-btrace.c (_initialize_record_btrace): Likewise.
2194         * record-full.c (_initialize_record_full): Likewise.
2195         * record.c (_initialize_record): Likewise.
2196         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2197         * regcache.c (_initialize_regcache): Likewise.
2198         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2199         _initialize_remote): Likewise.
2200         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2201         * serial.c (_initialize_serial): Likewise.
2202         * skip.c (_initialize_step_skip): Likewise.
2203         * source.c (_initialize_source): Likewise.
2204         * stack.c (_initialize_stack): Likewise.
2205         * symfile.c (_initialize_symfile): Likewise.
2206         * symtab.c (_initialize_symtab): Likewise.
2207         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2208         * top.c (init_main): Likewise.
2209         * tracefile-tfile.c (tfile_target_info): Likewise.
2210         * tracepoint.c (_initialize_tracepoint): Likewise.
2211         * tui/tui-win.c (_initialize_tui_win): Likewise.
2212         * utils.c (add_internal_problem_command): Likewise.
2213         * valprint.c (value_print_option_defs): Likewise.
2214
2215 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2216
2217         PR build/24886
2218         * configure.ac: Drop enable-libmcheck support.
2219         * configure, config.in: Rebuild.
2220         * libmcheck.m4: Remove.
2221         * acinclude.m4: Don't include it.
2222         * Makefile.in: Don't distribute it.
2223         * top.c (print_gdb_configuration): Don't mention it.
2224
2225 2019-08-06  Tom Tromey  <tom@tromey.com>
2226
2227         * utils.c (set_output_style): Sometimes pass stream to
2228         emit_style_escape.
2229         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2230         * record-btrace.c (btrace_insn_history): Update.
2231         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2232         method.
2233         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2234         Update initializers.
2235         <m_uiout>: New field.
2236         <m_di>: Move lower.
2237         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2238         Remove "uiout" parameter.
2239         (dump_insns): Update.
2240         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2241         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2242
2243 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2244
2245         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2246         (error_in_psymtab_expansion): Likewise.
2247         (lookup_symbol_via_quick_fns): Likewise.
2248         (basic_lookup_transparent_type_quick): Likewise.
2249         (basic_lookup_transparent_type_1): Likewise.
2250
2251 2019-08-06  Tom Tromey  <tromey@adacore.com>
2252
2253         * source.c (last_source_error): Now bool.
2254         (print_source_lines_base): Make "noprint" bool.  Only open
2255         source file when last_source_visited changes.
2256
2257 2019-08-06  Tom Tromey  <tromey@adacore.com>
2258
2259         * annotate.c (annotate_source_line): Use g_source_cache.
2260         * source-cache.c (source_cache::get_plain_source_lines): Change
2261         parameters.  Populate m_offset_cache.
2262         (source_cache::ensure): New method.
2263         (source_cache::get_line_charpos): New method.
2264         (extract_lines): Move lower.  Change parameters.
2265         (source_cache::get_source_lines): Move lower.
2266         * source-cache.h (class source_cache): Update comment.
2267         <get_line_charpos>: New method.
2268         <get_source_lines>: Update comment.
2269         <clear>: Clear m_offset_cache.
2270         <get_plain_source_lines>: Change parameters.
2271         <ensure>: New method
2272         <m_offset_cache>: New member.
2273         * source.c (forget_cached_source_info_for_objfile): Update.
2274         (info_source_command): Use g_source_cache.
2275         (find_source_lines, open_source_file_with_line_charpos): Remove.
2276         (print_source_lines_base, search_command_helper): Use g_source_cache.
2277         * source.h (open_source_file_with_line_charpos): Don't declare.
2278         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2279         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2280         Use g_source_cache.
2281
2282 2019-08-06  Tom Tromey  <tromey@adacore.com>
2283
2284         * source-cache.c (source_cache::get_plain_source_lines):
2285         Remove "first_line" and "last_line" parameters.
2286         (source_cache::get_source_lines): Cache plain text.
2287         * source-cache.h (class source_cache)
2288         <get_plain_source_lines>: Update.
2289
2290 2019-08-06  Tom Tromey  <tromey@adacore.com>
2291
2292         * source-cache.c (extract_lines): No longer a method.
2293         Changed type of parameter.  Include final newline.
2294         (selftests::extract_lines_test): New function.
2295         (_initialize_source_cache): Likewise.
2296         * source-cache.h (class source_cache)
2297         <extract_lines>: Don't declare.
2298
2299 2019-08-06  Tom Tromey  <tromey@adacore.com>
2300
2301         * breakpoint.c (init_breakpoint_sal): Update.
2302         (breakpoint): Update.
2303         * breakpoint.h (struct breakpoint) <filter>: Now a
2304         unique_xmalloc_ptr.
2305
2306 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2307
2308         * NEWS: Mention dictionary access on blocks.
2309         * python/py-block.c (blpy_getitem): New function.
2310         (block_object_as_mapping): New struct.
2311         (block_object_type): Use new struct for tp_as_mapping field.
2312
2313 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2314
2315         * objfiles.h (objfile): Add a comment describing partial symbols.
2316
2317 2019-08-05  Tom Tromey  <tromey@adacore.com>
2318
2319         * compile/compile.c (_initialize_compile): Use _(), not N_().
2320         * thread.c (_initialize_thread): Use _(), not N_().
2321         * stack.c (_initialize_stack): Use _(), not N_().
2322         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2323
2324 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2325
2326         * dwarf2read.c (struct dw2_symtab_iterator):
2327         <want_specific_block>: Remove.
2328         <block_index>: Change type to gdb::optional.
2329         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2330         change type of BLOCK_INDEX parameter to gdb::optional.
2331         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2332         (dw2_lookup_symbol): Don't pass argument for
2333         WANT_SPECIFIC_BLOCK.
2334         (dw2_expand_symtabs_for_function): Don't pass argument for
2335         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2336         (class dw2_debug_names_iterator)
2337         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2338         parameter, change BLOCK_INDEX type to gdb::optional.
2339         <m_want_specific_block>: Remove.
2340         <m_block_index>: Change type to gdb::optional.
2341         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2342         gdb::optional.  Re-write in function of gdb::optional.
2343         (dw2_debug_names_lookup_symbol): Don't pass argument for
2344         WANT_SPECIFIC_BLOCK.
2345         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2346         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2347         BLOCK_INDEX.
2348
2349 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2350
2351         * NEWS: Mention changes to "info sources" command.
2352
2353 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2354
2355         * symtab.c (filename_partial_match_opts): New struct type.
2356         (struct output_source_filename_data): New members
2357         regexp, c_regexp, partial_match.
2358         (output_source_filename): Use new members to decide to print file.
2359         (info_sources_option_defs): New variable.
2360         (make_info_sources_options_def_group, print_info_sources_header,
2361         info_sources_command_completer):
2362         New functions.
2363         (info_sources_command): Read new optional arguments.
2364         (_initialize_symtab): Update info sources help.
2365
2366 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2367
2368         * ada-lang.c (exception_support_info_v0): Renamed from...
2369         (default_exception_support_info): ... this.  Create new
2370         definition for v1.
2371         (ada_has_this_exception_support): Look up catch_handlers_sym.
2372         (ada_exception_support_info_sniffer): Try v0 after default.
2373
2374 2019-08-01  Tom Tromey  <tromey@adacore.com>
2375
2376         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2377         gdbarch.h.
2378
2379 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2380
2381         * s12z-tdep.c: Fix include path for s12z-opc.h.
2382
2383 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2384
2385         * NEWS: Require GNU make 3.82.
2386
2387 2019-07-16  Tom Tromey  <tom@tromey.com>
2388
2389         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2390         declare.
2391
2392 2019-07-30  Tom Tromey  <tromey@adacore.com>
2393
2394         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2395
2396 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2397
2398         * printcmd.c (print_address_symbolic): Print negative offsets.
2399         (build_address_symbolic): Force signed arithmetic when computing
2400         offset.
2401
2402 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2403
2404         PR/24474: Add a function to lookup static variables.
2405         * NEWS: Mention this new function.
2406         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2407         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2408         * python/python.c (python_GdbMethods): Add new function.
2409
2410 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2411
2412         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2413         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2414         (objfpy_lookup_static_symbol): New function.
2415         (objfile_object_methods): Add new functions.
2416
2417 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2418
2419         * NEWS: Mention 'set|show print frame-info'.  Mention new
2420         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2421         backtrace argument.  Mention that python frame filtering code
2422         is now consistent with what 'backtrace' command prints.
2423
2424 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2425
2426         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2427         comments.
2428         (print_frame_info_auto, print_frame_info_source_line,
2429         print_frame_info_location, print_frame_info_source_and_location,
2430         print_frame_info_location_and_address, print_frame_info_short_location):
2431         New declarations.
2432         (struct frame_print_options): New member print_frame_info.
2433         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2434         * stack.h (get_user_print_what_frame_info): New declaration.
2435         (frame_show_address): New declaration.
2436         * stack.c (print_frame_arguments_choices): New value 'presence'.
2437         (print_frame_info_auto, print_frame_info_source_line,
2438         print_frame_info_location, print_frame_info_source_and_location,
2439         print_frame_info_location_and_address, print_frame_info_short_location,
2440         print_frame_info_choices, print_frame_info_print_what): New definitions.
2441         (print_frame_args): Only print dots for args if print frame-arguments
2442         is 'presence'.
2443         (frame_print_option_defs): New element for "frame-info".
2444         (get_user_print_what_frame_info): New function.
2445         (frame_show_address): Make non static.  Move comment to stack.h.
2446         (print_frame_info_to_print_what): New function.
2447         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2448         to decide what to print.
2449         (backtrace_command_1): Handle the new print_frame_arguments_presence
2450         value.
2451         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2452         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2453         (py_print_frame): In non-mi mode, use LOCATION as default for
2454         print_what, similarly to frame information printed directly by
2455         backtrace command. Handle frame-info user option in non MI mode.
2456
2457 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2458
2459         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2460         Add case for debugging 32-bit target on 64-bit host.  Revise
2461         comment.
2462
2463 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2464
2465         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2466         instead of find_function_entry_range_from_pc.
2467
2468 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2469
2470         * stack.c (find_frame_funname): Remove code which preferred
2471         minsym over symtab sym in "certain pathological cases".
2472
2473         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2474         parameter.  Change type of "do_demangle" to bool.
2475         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2476         Pass suitable "prefer_sym_over_minsym" flag to
2477         build_address_symbolic().  Don't output "+" for negative offsets.
2478         * printcmd.c (print_address_symbolic): Update invocation of
2479         build_address_symbolic to include a "prefer_sym_over_minsym"
2480         flag.
2481         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2482         Restrict cases in which use of minimal symbol is preferred to that
2483         of a found symbol.  Update comments.
2484
2485         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2486         for entry pc when entry pc is out of range for that FDE.
2487
2488 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2489
2490         PR gdb/24839:
2491         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2492         type.
2493
2494 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2495
2496         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2497         this function's Python signature.
2498
2499
2500 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2501
2502         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2503         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2504         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2505         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2506         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2507
2508
2509 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2510
2511         * h8300-tdep.c (h8300_register_name_common): New.
2512         h8300_register_name): Use h8300_register_name_common.
2513         (h8300s_register_name): Likewise.
2514         (h8300sx_register_name): Likewise.
2515         (h8300h_register_nam): New.
2516         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2517
2518
2519 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2520
2521         * arm-tdep.c (arm_skip_cmse_entry): New function.
2522         (arm_is_sgstubs_section): New function.
2523         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2524
2525 2019-07-22  Tom Tromey  <tom@tromey.com>
2526
2527         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2528         Don't self-assign.
2529
2530 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2531
2532         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2533         type_print.
2534
2535 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2536
2537         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2538         so that GDB doesn't match any msymbols when searching in the
2539         TYPES_DOMAIN.
2540         (print_symbol_info): Print using typedef_print or type_print based
2541         on the type of the symbol.  Add updated FIXME comment moved from...
2542         (_initialize_symtab): ... move and update FIXME comment to above.
2543
2544 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2545
2546         * NEWS: Mention adding -q option to "info types".
2547         * symtab.c (struct info_types_options): New struct.
2548         (info_types_options_defs): New variable.
2549         (make_info_types_options_def_group): New function.
2550         (info_types_command): Use gdb::option framework to parse options.
2551         (info_types_command_completer): New function.
2552         (_initialize_symtab): Extend the help text on "info types" and
2553         register command completer.
2554
2555 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2556
2557         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2558         (lookup_symbol_in_objfile): Change int to block_enum and add a
2559         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2560
2561 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2562
2563         * MAINTAINERS (Write After Approval): Add self.
2564
2565 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2566
2567         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2568         instruction to the dummy code region.
2569
2570 2019-07-19  Tom Tromey  <tromey@adacore.com>
2571
2572         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2573         (ARGSUSED, PARAMS, __func__): Remove rules.
2574
2575 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2576
2577         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2578         * features/arm/arm-with-iwmmxt.c: Remove.
2579         * features/arm/arm-with-iwmmxt.xml: Remove.
2580         * features/arm/arm-with-m-fpa-layout.c: Remove.
2581         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2582         * features/arm/arm-with-m-vfp-d16.c: Remove.
2583         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2584         * features/arm/arm-with-m.c: Remove.
2585         * features/arm/arm-with-m.xml: Remove.
2586         * features/arm/arm-with-neon.c: Remove.
2587         * features/arm/arm-with-neon.xml: Remove.
2588         * features/arm/arm-with-vfpv2.c: Remove.
2589         * features/arm/arm-with-vfpv2.xml: Remove.
2590         * features/arm/arm-with-vfpv3.c: Remove.
2591         * features/arm/arm-with-vfpv3.xml: Remove.
2592
2593 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2594
2595         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2596
2597 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2598
2599         * arch/aarch32.c (aarch32_create_target_description): Create
2600         target descriptions using features.
2601         * arch/arm.c (arm_create_target_description)
2602         (arm_create_mprofile_target_description): Likewise.
2603         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2604
2605 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2606
2607         * Makefile.in: Add new files.
2608         * aarch32-tdep.c: New file.
2609         * aarch32-tdep.h: New file.
2610         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2611         Call aarch32_read_description.
2612         * arch/aarch32.c: New file.
2613         * arch/aarch32.h: New file.
2614         * arch/arm.c (arm_create_target_description)
2615         (arm_create_mprofile_target_description): New function.
2616         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2617         (arm_create_target_description)
2618         (arm_create_mprofile_target_description): New declaration.
2619         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2620         read_description functions.
2621         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2622         Likewise.
2623         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2624         * arm-tdep.c (tdesc_arm_list): New variable.
2625         (arm_register_g_packet_guesses): Call create description functions.
2626         (arm_read_description) (arm_read_mprofile_description): New
2627         function.
2628         * arm-tdep.h (arm_read_description)
2629         (arm_read_mprofile_description): Add declaration.
2630         * configure.tgt: Add new files.
2631
2632 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2633
2634         * top.c (new_ui_command): Open specified terminal just once.
2635
2636 2019-07-18  Tom Tromey  <tromey@adacore.com>
2637
2638         * symtab.c (main_name): Constify return type.
2639         * symfile.c (set_initial_language): Update.
2640         * symtab.h (main_name): Constify return type.
2641
2642 2019-07-17  Tom Tromey  <tom@tromey.com>
2643
2644         * tui/tui-winsource.c (tui_update_source_window)
2645         (tui_update_source_window_as_is)
2646         (tui_update_source_windows_with_line): Remove return.
2647         * tui/tui-disasm.c (tui_show_disassem)
2648         (tui_show_disassem_and_update_source): Remove return.
2649         * tui/tui.c (tui_reset): Remove return.
2650         * tui/tui-wingeneral.c
2651         (tui_check_and_display_highlight_if_needed): Remove return.
2652
2653 2019-07-17  Tom Tromey  <tom@tromey.com>
2654
2655         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2656
2657 2019-07-17  Tom Tromey  <tom@tromey.com>
2658
2659         * tui/tui-winsource.h (struct tui_exec_info_window)
2660         (struct tui_source_window_base): Move from tui-data.h.
2661         * tui/tui-winsource.c: Move many method definitions from
2662         elsewhere.  Remove "structuring" comments.
2663         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2664         (tui_source_window_base::refresh_window): Move to
2665         tui-winsource.c.
2666         * tui/tui-win.c (tui_source_window_base::refresh_all)
2667         (tui_source_window_base::update_tab_width)
2668         (tui_source_window_base::set_new_height)
2669         (tui_source_window_base::do_make_visible_with_new_height): Move to
2670         tui-winsource.c.
2671         * tui/tui-source.h: Update.
2672         * tui/tui-source.c (tui_source_window_base::reset): Move to
2673         tui-winsource.c.
2674         * tui/tui-disasm.h: Update.
2675         * tui/tui-data.h (struct tui_exec_info_window): Move to
2676         tui-winsource.h.
2677         (struct tui_source_window_base): Likewise.
2678         * tui/tui-data.c (tui_source_window_base::clear_detail)
2679         (tui_source_window_base, ~tui_source_window_base): Move to
2680         tui-winsource.c.
2681
2682 2019-07-17  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-win.c (tui_resize_all)
2685         (tui_source_window_base::update_tab_width)
2686         (tui_adjust_win_heights): Update.
2687         (tui_win_info::make_invisible_and_set_new_height): Rename from
2688         make_invisible_and_set_new_height.
2689         * tui/tui-data.h (struct tui_win_info)
2690         <make_invisible_and_set_new_height>: New method.
2691
2692 2019-07-17  Tom Tromey  <tom@tromey.com>
2693
2694         * tui/tui.c: Update.
2695         * tui/tui-source.h (struct tui_source_window): Move from
2696         tui-data.h.
2697         * tui/tui-layout.c: Update.
2698         * tui/tui-disasm.c: Update.
2699         * tui/tui-data.h (struct tui_source_window): Move to
2700         tui-source.h.
2701
2702 2019-07-17  Tom Tromey  <tom@tromey.com>
2703
2704         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2705         tui-data.h.
2706         * tui/tui-data.h (struct tui_disasm_window): Move to
2707         tui-disasm.h.
2708
2709 2019-07-17  Tom Tromey  <tom@tromey.com>
2710
2711         * tui/tui-regs.h (struct tui_data_item_window): Move from
2712         tui-data.h.
2713         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2714         * tui/tui-data.h (struct tui_data_item_window): Move to
2715         tui-regs.h.
2716         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2717
2718 2019-07-17  Tom Tromey  <tom@tromey.com>
2719
2720         * tui/tui.c: Update.
2721         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2722         (tui_cmd_window::max_height): Move to tui-command.c.
2723         * tui/tui-layout.c: Update.
2724         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2725         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2726         tui-command.c.
2727         * tui/tui-command.h (struct tui_cmd_window): Move from
2728         tui-data.h.
2729         * tui/tui-command.c: Remove "structuring" comments.
2730         (tui_cmd_window::clear_detail)
2731         (tui_cmd_window::do_make_visible_with_new_height)
2732         (tui_cmd_window::max_height): Move from elsewhere.
2733
2734 2019-07-17  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2737         Now static.
2738         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2739         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2740
2741 2019-07-17  Tom Tromey  <tom@tromey.com>
2742
2743         * tui/tui.c: Update.
2744         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2745         tui-regs.c.
2746         * tui/tui-windata.h: Remove file.
2747         * tui/tui-windata.c: Remove file.
2748         * tui/tui-win.c (tui_data_window::set_new_height)
2749         (tui_data_window::do_make_visible_with_new_height): Move to
2750         tui-regs.c.
2751         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2752         * tui/tui-regs.c: Remove "structuring" comments.
2753         (tui_data_window::first_data_item_displayed)
2754         (tui_data_window::delete_data_content_windows)
2755         (tui_data_window::erase_data_content)
2756         (tui_data_window::display_all_data)
2757         (tui_data_window::refresh_all)
2758         (tui_data_window::do_scroll_vertical)
2759         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2760         (tui_data_window::do_make_visible_with_new_height)
2761         (tui_data_window::refresh_window): Move from elsewhere.
2762         (_initialize_tui_regs): Move to end of file.
2763         * tui/tui-layout.c: Update.
2764         * tui/tui-hooks.c: Update.
2765         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2766         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2767         tui-regs.c.
2768         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2769
2770 2019-07-17  Tom Tromey  <tom@tromey.com>
2771
2772         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2773         seen.
2774
2775 2019-07-17  Tom Tromey  <tom@tromey.com>
2776
2777         * tui/tui-win.c (tui_source_window_base::set_new_height)
2778         (tui_source_window_base::do_make_visible_with_new_height): Use
2779         m_has_locator field directly.
2780         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2781         method.
2782         (struct tui_source_window_base) <has_locator>: Likewise.
2783
2784 2019-07-17  Tom Tromey  <tom@tromey.com>
2785
2786         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2787         Don't declare.
2788         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2789         Remove.
2790         * tui/tui-win.c (tui_source_window_base::set_new_height)
2791         (tui_source_window_base::set_new_height)
2792         (make_invisible_and_set_new_height)
2793         (tui_source_window_base::do_make_visible_with_new_height)
2794         (tui_source_window_base::do_make_visible_with_new_height):
2795         Update.
2796         * tui/tui-layout.c (show_source_disasm_command, show_data)
2797         (show_source_or_disasm_and_command): Update.
2798         * tui/tui-layout.c (show_layout): Update.
2799
2800 2019-07-17  Tom Tromey  <tom@tromey.com>
2801
2802         * tui/tui-layout.c (make_data_window): Remove.
2803         (show_data): Unify creation and re-initialization cases.
2804
2805 2019-07-17  Tom Tromey  <tom@tromey.com>
2806
2807         * tui/tui-layout.c (make_source_window, make_disasm_window):
2808         Remove.
2809         (show_data): Unify creation and re-initialization cases.
2810
2811 2019-07-17  Tom Tromey  <tom@tromey.com>
2812
2813         * tui/tui-layout.c (make_command_window): Remove.
2814         (show_source_disasm_command, show_source_or_disasm_and_command):
2815         Unify creation and re-initialization cases.
2816
2817 2019-07-17  Tom Tromey  <tom@tromey.com>
2818
2819         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2820         creation and re-initialization cases.
2821
2822 2019-07-17  Tom Tromey  <tom@tromey.com>
2823
2824         * tui/tui-regs.c (tui_get_register): Return void.
2825
2826 2019-07-17  Tom Tromey  <tom@tromey.com>
2827
2828         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2829         Simplify.
2830
2831 2019-07-17  Tom Tromey  <tom@tromey.com>
2832
2833         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2834         resetting.
2835
2836 2019-07-17  Tom Tromey  <tom@tromey.com>
2837
2838         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2839         * tui/tui-regs.c (tui_reg_layout): New function.
2840         (tui_show_registers, tui_reg_command): Use it.
2841         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2842         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2843         parameters.
2844         (tui_layout_command): Remove.
2845
2846 2019-07-17  Tom Tromey  <tom@tromey.com>
2847
2848         * tui/tui-layout.h (tui/tui-layout): Return void.
2849         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2850
2851 2019-07-17  Tom Tromey  <tom@tromey.com>
2852
2853         * tui/tui-layout.c (show_source_disasm_command, show_data):
2854         Update.
2855         (reset_locator): Remove.
2856         (show_source_or_disasm_and_command): Update.
2857
2858 2019-07-17  Tom Tromey  <tom@tromey.com>
2859
2860         * tui/tui-source.c (tui_source_window_base::reset): Remove
2861         win_type parameter.
2862         * tui/tui-layout.c (make_command_window, make_source_window)
2863         (make_disasm_window, make_data_window)
2864         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2865         (reset_locator, show_source_or_disasm_and_command): Update.
2866         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2867         win_type parameter.
2868         (struct tui_source_window_base) <reset>: Likewise.
2869
2870 2019-07-17  Tom Tromey  <tom@tromey.com>
2871
2872         * tui/tui-layout.c (show_source_disasm_command): Use
2873         reset_locator.
2874         (reset_locator): New function.
2875         (init_and_make_win): Remove.
2876         (show_source_or_disasm_and_command): Use reset_locator.
2877
2878 2019-07-17  Tom Tromey  <tom@tromey.com>
2879
2880         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2881         condition.
2882         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2883         Remove condition.
2884         * tui/tui-source.c (tui_source_window_base::reset): New method.
2885         * tui/tui-layout.c (make_command_window): Don't call
2886         init_and_make_win.
2887         (make_source_window, make_disasm_window): Don't call
2888         make_source_or_disasm_window.
2889         (make_data_window): Don't call init_and_make_win.  Change calling
2890         convention.
2891         (show_source_disasm_command, show_data): Simplify.
2892         (make_source_or_disasm_window): Remove.
2893         (show_source_or_disasm_and_command): Simplify.
2894         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2895         (struct tui_source_window_base) <reset>: Likewise.
2896         <execution_info>: Remove initializer.
2897         * tui/tui-data.c (tui_source_window_base): Initialize
2898         execution_info.
2899
2900 2019-07-17  Tom Tromey  <tom@tromey.com>
2901
2902         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2903         variable.
2904
2905 2019-07-17  Tom Tromey  <tom@tromey.com>
2906
2907         * tui/tui.c (tui_rl_other_window): Update.
2908         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2909         superclass method first.  Always iterate over regs_content.
2910         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2911         method.
2912         * tui/tui-win.c (tui_set_focus_command): Update.
2913
2914 2019-07-17  Tom Tromey  <tom@tromey.com>
2915
2916         * tui/tui-win.c (tui_set_focus_command): Rename from
2917         tui_set_focus.  Call tui_enable.
2918         (tui_set_focus_command): Remove.
2919
2920 2019-07-17  Tom Tromey  <tom@tromey.com>
2921
2922         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2923         refresh_window.
2924         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2925         touchwin.
2926         (tui_data_window::refresh_window): Call refresh_window on data
2927         items.  Always call superclass refresh_window.
2928         (tui_win_info::refresh): Remove.
2929         (tui_source_window_base::refresh_window): Update.
2930         (tui_refresh_all): Update.
2931         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2932         refresh_window.
2933         (show_source_or_disasm_and_command): Likewise.
2934         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2935         (struct tui_source_window_base) <refresh>: Likewise.
2936
2937 2019-07-17  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-winsource.c (tui_clear_source_content)
2940         (tui_show_source_content): Update.
2941         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2942         whether content is empty.
2943         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2944         Remove.
2945
2946 2019-07-17  Tom Tromey  <tom@tromey.com>
2947
2948         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2949         window's contents.
2950         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2951         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2952
2953 2019-07-17  Tom Tromey  <tom@tromey.com>
2954
2955         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2956         (struct tui_data_item_window): Update.
2957
2958 2019-07-17  Tom Tromey  <tom@tromey.com>
2959
2960         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2961         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2962         defines.
2963
2964 2019-07-17  Tom Tromey  <tom@tromey.com>
2965
2966         * tui/tui-winsource.h (tui_erase_source_content)
2967         (tui_clear_source_content): Remove "display_prompt" parameter.
2968         * tui/tui-winsource.c (tui_update_source_window_as_is)
2969         (tui_update_source_windows_with_addr): Update.
2970         (tui_clear_source_content): Remove "display_prompt" parameter.
2971         (tui_erase_source_content): Likewise.  Simplify.
2972         (tui_show_source_content): Update.
2973         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2974         * tui/tui-stack.c (tui_show_frame_info): Update.
2975         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2976         Remove defines.
2977
2978 2019-07-17  Tom Tromey  <tom@tromey.com>
2979
2980         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2981         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2982         parameter.
2983         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2984         parameter.
2985
2986 2019-07-17  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui-winsource.c (tui_clear_source_content)
2989         (tui_show_source_content, tui_show_exec_info_content)
2990         (tui_clear_exec_info_content): Update.
2991         * tui/tui-stack.c (tui_show_locator_content): Update.
2992         (tui_show_frame_info): Update.
2993         * tui/tui-source.h (tui_source_window): Don't declare.
2994         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2995         from tui_source_is_displayed.
2996         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2997         Remove field.
2998         (struct tui_source_window_base) <content_in_use>: New field.  Now
2999         bool.
3000         (struct tui_source_window) <showing_source_p>: New method.
3001         (TUI_SRC_WIN): Change cast.
3002         * tui/tui-data.c (tui_initialize_static_data): Update.
3003
3004 2019-07-17  Tom Tromey  <tom@tromey.com>
3005
3006         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3007         location_matches_p.
3008         * tui/tui-source.c (tui_source_window::location_matches_p): New
3009         method.
3010         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3011         method.
3012         * tui/tui-data.h (struct tui_source_window_base)
3013         <location_matches_p>: New method.
3014         (struct tui_source_window, struct tui_disasm_window)
3015         <location_matches_p>: Likewise.
3016
3017 2019-07-17  Tom Tromey  <tom@tromey.com>
3018
3019         * tui/tui-win.c (tui_set_win_height_command): Rename from
3020         tui_set_win_height.
3021         (tui_set_win_height_command): Remove.
3022
3023 2019-07-17  Tom Tromey  <tom@tromey.com>
3024
3025         * tui/tui-source.c (tui_source_window): New constructor.  Add
3026         observer.
3027         (~tui_source_window): New destructor.
3028         (tui_source_window::style_changed): New method.
3029         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3030         (tui_attach_detach_observers): Update.
3031         * tui/tui-data.h (struct tui_source_window): Make constructor not
3032         inline.  Add destructor.
3033         (struct tui_source_window) <style_changed>: New method.
3034         <m_observable>: New member.
3035
3036 2019-07-17  Tom Tromey  <tom@tromey.com>
3037
3038         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3039         * tui/tui-win.c (tui_resize_all): Fix typo.
3040
3041 2019-07-17  Tom Tromey  <tom@tromey.com>
3042
3043         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3044         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3045         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3046         * tui/tui-win.c (window_name_completer): Use foreach.
3047         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3048         (update_tab_width): Likewise.
3049         * tui/tui-layout.c (show_layout): Update.
3050         * tui/tui-data.h (class tui_window_iterator): New.
3051         (struct all_tui_windows): New.
3052         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3053
3054 2019-07-17  Tom Tromey  <tom@tromey.com>
3055
3056         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3057         parameter.  Don't reference globals.
3058         (tui_reg_command): Update.
3059
3060 2019-07-17  Tom Tromey  <tom@tromey.com>
3061
3062         * tui/tui-regs.c (tui_show_registers): Simplify.
3063
3064 2019-07-17  Tom Tromey  <tom@tromey.com>
3065
3066         * tui/tui-regs.c (tui_show_registers): Update.
3067         (tui_show_register_group): Add win_info parameter.
3068
3069 2019-07-17  Tom Tromey  <tom@tromey.com>
3070
3071         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3072         Rename from tui_display_reg_element_at_line.
3073         (tui_data_window::display_registers_from_line): Update.
3074         * tui/tui-data.h (struct tui_data_window)
3075         <display_reg_element_at_line>: New method.
3076
3077 2019-07-17  Tom Tromey  <tom@tromey.com>
3078
3079         * tui/tui-regs.h (tui_display_registers_from)
3080         (tui_display_registers_from_line): Don't declare.
3081         * tui/tui-windata.c (tui_data_window::display_all_data)
3082         (tui_data_window::refresh_all)
3083         (tui_data_window::do_scroll_vertical): Update.
3084         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3085         from tui_display_registers_from.
3086         (tui_display_reg_element_at_line): Update.
3087         (tui_data_window::display_registers_from_line): Rename from
3088         tui_display_registers_from_line.
3089         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3090         display_registers_from_line>: New methods.
3091
3092 2019-07-17  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3095         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3096         from tui_erase_data_content.
3097         (tui_data_window::display_all_data)
3098         (tui_data_window::refresh_all)
3099         (tui_data_window::do_scroll_vertical): Update.
3100         * tui/tui-regs.c (tui_show_registers): Update.
3101         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3102         New method.
3103
3104 2019-07-17  Tom Tromey  <tom@tromey.com>
3105
3106         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3107         declare.
3108         * tui/tui-windata.c
3109         (tui_data_window::delete_data_content_windows): Rename from
3110         tui_delete_data_content_windows.
3111         (tui_data_window::display_all_data)
3112         (tui_data_window::do_scroll_vertical): Update.
3113         * tui/tui-data.h (struct tui_data_window)
3114         <delete_data_content_windows>: New method.
3115
3116 2019-07-17  Tom Tromey  <tom@tromey.com>
3117
3118         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3119         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3120
3121 2019-07-17  Tom Tromey  <tom@tromey.com>
3122
3123         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3124         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3125         from tui_display_all_data.
3126         * tui/tui-win.c
3127         (tui_data_window::do_make_visible_with_new_height): Update.
3128         * tui/tui-regs.c (tui_show_registers): Update.
3129         * tui/tui-layout.c (tui_set_layout): Update.
3130         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3131         method.
3132
3133 2019-07-17  Tom Tromey  <tom@tromey.com>
3134
3135         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3136         * tui/tui-windata.c (tui_display_data_from): Remove.
3137         (tui_data_window::refresh_all): Update.
3138
3139 2019-07-17  Tom Tromey  <tom@tromey.com>
3140
3141         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3142         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3143         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3144         tui_display_registers_from_line.
3145         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3146         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3147         "force_display" parameter.
3148
3149 2019-07-17  Tom Tromey  <tom@tromey.com>
3150
3151         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3152         declare.
3153         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3154         Rename from tui_first_reg_element_no_inline.
3155         (tui_display_reg_element_at_line)
3156         (tui_display_registers_from_line): Update.
3157         * tui/tui-data.h (struct tui_data_window)
3158         <first_reg_element_no_inline>: New method.
3159
3160 2019-07-17  Tom Tromey  <tom@tromey.com>
3161
3162         * tui/tui-windata.c (tui_display_data_from)
3163         (tui_data_window::do_scroll_vertical): Update.
3164         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3165         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3166         Rename from tui_line_from_reg_element_no.
3167         (tui_display_registers_from_line): Update.
3168         * tui/tui-data.h (struct tui_data_window)
3169         <line_from_reg_element_no>: New method.
3170
3171 2019-07-17  Tom Tromey  <tom@tromey.com>
3172
3173         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3174         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3175         tui_last_regs_line_no.
3176         (tui_display_reg_element_at_line)
3177         (tui_display_registers_from_line): Update.
3178         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3179         method.
3180
3181 2019-07-17  Tom Tromey  <tom@tromey.com>
3182
3183         PR tui/24722:
3184         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3185         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3186         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3187         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3188         (tui_update_breakpoint_info): Likewise.
3189         * tui/tui-hooks.c (tui_event_create_breakpoint)
3190         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3191         Update.
3192
3193 2019-07-17  Tom Tromey  <tom@tromey.com>
3194
3195         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3196
3197 2019-07-17  Tom Tromey  <tom@tromey.com>
3198
3199         * tui/tui-winsource.c (tui_update_source_window_as_is)
3200         (tui_update_source_windows_with_addr): Update.
3201         * tui/tui-source.h (tui_set_source_content)
3202         (tui_show_symtab_source): Add "win_info" parameter.
3203         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3204         parameter.
3205         (tui_show_symtab_source): Likewise.
3206
3207 2019-07-17  Tom Tromey  <tom@tromey.com>
3208
3209         * tui/tui-wingeneral.c
3210         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3211
3212 2019-07-17  Tom Tromey  <tom@tromey.com>
3213
3214         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3215         (struct tui_cmd_window) <can_scroll>: New method.
3216         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3217         method.
3218
3219 2019-07-17  Tom Tromey  <tromey@adacore.com>
3220
3221         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3222         do_field_signed>: Rename.  Change type of "value".
3223         * ui-out.c (ui_out::field_signed): Rename from field_int.
3224         Change type of "value".
3225         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3226         type of "value".
3227         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3228         do_field_int.  Change type of "value".
3229         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3230         do_field_int.  Change type of "value".
3231         * tracepoint.c (trace_status_mi, tfind_1)
3232         (print_one_static_tracepoint_marker): Update.
3233         * thread.c (print_thread_info_1, print_selected_thread_frame):
3234         Update.
3235         * stack.c (print_frame, print_frame_info): Update.
3236         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3237         Update.
3238         * source.c (print_source_lines_base): Update.
3239         * skip.c (info_skip_command): Update.
3240         * record-btrace.c (btrace_ui_out_decode_error)
3241         (btrace_call_history_src_line): Update.
3242         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3243         Update.
3244         * progspace.c (print_program_space): Update.
3245         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3246         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3247         do_field_int.  Change type of "value".
3248         * mi/mi-out.c (mi_ui_out::do_table_begin)
3249         (mi_ui_out::do_table_header): Update.
3250         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3251         type of "value".
3252         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3253         (mi_cmd_data_list_changed_registers, output_register)
3254         (mi_cmd_data_read_memory, mi_load_progress)
3255         (mi_cmd_trace_frame_collected): Update.
3256         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3257         Update.
3258         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3259         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3260         (mi_cmd_var_list_children, varobj_update_one): Update.
3261         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3262         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3263         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3264         * inferior.c (print_inferior): Update.
3265         * gdb_bfd.c (print_one_bfd): Update.
3266         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3267         Update.
3268         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3269         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3270         do_field_int.  Change type of "value".
3271         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3272         do_field_int.  Change type of "value".
3273         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3274         (print_one_breakpoint_location, print_it_catch_fork)
3275         (print_one_catch_fork, print_it_catch_vfork)
3276         (print_one_catch_vfork, print_it_catch_solib)
3277         (print_it_catch_exec, print_it_ranged_breakpoint)
3278         (print_mention_watchpoint, print_mention_masked_watchpoint)
3279         (bkpt_print_it, update_static_tracepoint): Update.
3280         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3281         * break-catch-syscall.c (print_it_catch_syscall): Update.
3282         * ada-tasks.c (print_ada_task_info): Update.
3283         * ada-lang.c (print_it_exception, print_mention_exception):
3284         Update.
3285
3286 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3287
3288         PR breakpoints/24541
3289         * gdbarch.c: Regenerate.
3290         * gdbarch.h: Regenerate.
3291         * gdbarch.sh: Adjust return type and parameter types for
3292         'stap_adjust_register'.
3293         (i386_stap_adjust_register): Adjust signature and return new
3294         register name.
3295         * stap-probe.c (stap_parse_register_operand): Adjust use of
3296         'gdbarch_stap_adjust_register'.
3297
3298 2019-07-17  Tom Tromey  <tromey@adacore.com>
3299
3300         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3301         declare VEC.
3302         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3303         std::vector.
3304         (struct s390_process_info): Add initializers.
3305         (s390_add_process): Use new.
3306         (s390_linux_nat_target::low_forget_process): Use delete.
3307         (s390_linux_nat_target::low_new_fork)
3308         (s390_linux_nat_target::stopped_by_watchpoint)
3309         (s390_linux_nat_target::low_prepare_to_resume)
3310         (s390_linux_nat_target::insert_watchpoint)
3311         (s390_linux_nat_target::insert_hw_breakpoint)
3312         (s390_linux_nat_target::remove_watchpoint)
3313         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3314
3315 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3316
3317         * aarch64-fbsd-nat.c: Include regcache.h.
3318         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3319         argument.
3320         (aarch64_fbsd_nat_target::fetch_registers)
3321         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3322         variable.
3323         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3324
3325 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3326
3327         * fbsd-nat.c: Include gdbarch.h.
3328
3329 2019-07-15  Tom Tromey  <tromey@adacore.com>
3330
3331         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3332
3333 2019-07-15  Tom Tromey  <tromey@adacore.com>
3334
3335         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3336         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3337         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3338         * cli-out.c (cli_ui_out::do_field_int): New method.
3339         * ui-out.c (ui_out::field_unsigned): New method.
3340         * symfile.c (generic_load): Use field_unsigned.
3341         (print_transfer_performance): Likewise.
3342         * record-btrace.c (ui_out_field_uint): Remove.
3343         (btrace_call_history_insn_range, btrace_call_history): Use
3344         field_unsigned.
3345         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3346         field_unsigned.
3347         * ui-out.h (class ui_out) <field_unsigned>: New method.
3348         <do_field_unsigned>: Likewise.
3349
3350 2019-07-15  Tom Tromey  <tromey@adacore.com>
3351
3352         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3353         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3354         * target.c (flash_erase_command): Use field_string.
3355         * infrun.c (print_signal_received_reason): Use field_string.
3356         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3357         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3358         field_string.
3359         * ada-tasks.c (print_ada_task_info): Use field_string.
3360
3361 2019-07-15  Tom Tromey  <tromey@adacore.com>
3362
3363         * target.c (flash_erase_command): Use field_core_addr.
3364         * symfile.c (generic_load): Use field_core_addr.
3365         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3366         Use field_core_addr.
3367         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3368         field_core_addr.
3369
3370 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3371
3372         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3373         value if its desired type is smaller than a CORE_ADDR and signed.
3374
3375 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3376
3377         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3378         of changes to field names, and use new is_reference field to
3379         decide if a property is a reference or not.
3380         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3381         field.
3382         (struct dwarf2_property_baton): Update header comment, rename
3383         'referenced_type' to 'property_type' and update comments.
3384         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3385         default property type, store in property baton, update to take
3386         accound of renamed field.
3387         (read_func_scope): Update call to attr_to_dynamic_prop.
3388         (read_array_type): Likewise.
3389         (dwarf2_per_cu_addr_sized_int_type): New function.
3390         (read_subrange_index_type): Move type finding code to
3391         dwarf2_per_cu_addr_sized_int_type.
3392         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3393         (dwarf2_per_cu_addr_type): New function.
3394         (set_die_type): Update calls to attr_to_dynamic_prop.
3395
3396 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3397
3398         * dwarf2read.c (read_subrange_index_type): New function.
3399         (read_subrange_type): Move code into new function and call it.
3400         * gdbtypes.c (create_range_type): Add some asserts.
3401
3402 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3403
3404         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3405         update return statements.
3406         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3407         declaration, and update comment to match.
3408         * gdbtypes.c (resolve_dynamic_array): Update call to
3409         dwarf2_evaluate_property to match new return type.
3410
3411 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3412
3413         * valarith.c (value_subscripted_rvalue): Change lowerbound
3414         parameter type from int to LONGEST.
3415         * value.h (value_subscripted_rvalue): Likewise in declaration.
3416
3417 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3418
3419         * cli/cli-utils.c (info_print_command_completer): New function.
3420         * cli/cli-utils.h: Add 'completer.h' include, and forward
3421         declaration for 'struct cmd_list_element'.
3422         (info_print_command_completer): Declare.
3423         * stack.c (_initialize_stack): Add completer for 'info locals' and
3424         'info args'.
3425         * symtab.c (_initialize_symtab): Add completer for 'info
3426         variables' and 'info functions'.
3427         * NEWS: Mention completion for additional info commands.
3428
3429 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3430
3431         * cli/cli-utils.c (extract_info_print_args): Delete.
3432         (extract_arg_maybe_quoted): Delete.
3433         (info_print_options_defs): New variable.
3434         (make_info_print_options_def_group): New function.
3435         (extract_info_print_options): Define new function.
3436         * cli/cli-utils.h (extract_info_print_args): Delete.
3437         (struct info_print_options): New structure.
3438         (extract_info_print_options): Declare new function.
3439         * stack.c (info_locals_command): Update to use new
3440         extract_info_print_options, also add a header comment.
3441         (info_args_command): Likewise.
3442         * symtab.c (info_variables_command): Likewise.
3443         (info_functions_command): Likewise.
3444
3445 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3446
3447         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3448         to extract string arguments.
3449         * common/common-utils.c (extract_string_maybe_quoted): New function.
3450         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3451
3452 2019-07-11  Tom Tromey  <tromey@adacore.com>
3453
3454         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3455         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3456         * top.h (gdbinit): Don't declare.
3457         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3458         into...
3459         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3460         * top.c (gdb_init): Don't call init_cli_cmds.
3461         (gdbinit): Remove.
3462         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3463
3464 2019-07-11  Tom Tromey  <tromey@adacore.com>
3465
3466         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3467         after it has been moved.
3468
3469 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3470
3471         * valops.c (value_must_coerce_to_target): Change return type to
3472         bool.
3473         * value.h (value_must_coerce_to_target): Likewise.
3474
3475 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3476
3477         * breakpoint.c (is_hardware_watchpoint): Remove
3478         forward-declaration.
3479         (is_masked_watchpoint): Change return type to bool.
3480         (is_tracepoint): Likewise.
3481         (is_breakpoint): Likewise.
3482         (is_hardware_watchpoint): Likewise.
3483         (is_watchpoint): Likewise.
3484         (is_no_memory_software_watchpoint): Likewise.
3485         (is_catchpoint): Likewise.
3486         (breakpoint_1): Make FILTER parameter's return type bool.
3487         is_masked_watchpoint): Change return type to bool.
3488         (save_breakpoints): Make FILTER parameter's return type bool.
3489         * breakpoint.h (is_breakpoint): Change return type to bool.
3490         (is_watchpoint): Likewise.
3491         (is_catchpoint): Likewise.
3492         (is_tracepoint): Likewise.
3493
3494 2019-07-10  Tom Tromey  <tom@tromey.com>
3495
3496         * defs.h: Don't include gdbarch.h.
3497         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3498         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3499         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3500         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3501         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3502         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3503         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3504         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3505         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3506         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3507         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3508         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3509         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3510         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3511         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3512         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3513         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3514         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3515         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3516         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3517         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3518         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3519         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3520         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3521         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3522         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3523         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3524
3525 2019-07-10  Tom Tromey  <tromey@adacore.com>
3526
3527         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3528         * breakpoint.c (init_ada_exception_breakpoint): Register as
3529         bp_catchpoint.
3530         (print_one_breakpoint_location, print_one_breakpoint): Use
3531         is_ada_exception_catchpoint.
3532         * ada-lang.c (class ada_catchpoint_location): Pass
3533         bp_loc_software_breakpoint to bp_location constructor.
3534         (is_ada_exception_catchpoint): New function.
3535
3536 2019-07-10  Tom Tromey  <tromey@adacore.com>
3537
3538         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3539         VEC.
3540         (struct arm_exidx_entry): New method operator<.
3541         (struct arm_exidx_data) <section_maps>: Change type.
3542         (arm_exidx_data_free): Remove.
3543         (arm_exidx_data_key): Change type.  Move lower.
3544         (arm_exidx_new_objfile): Update.
3545         (arm_compare_exidx_entries): Remove.
3546         (arm_find_exidx_entry, _initialize_arm_tdep)
3547
3548 2019-07-10  Tom Tromey  <tromey@adacore.com>
3549
3550         * solib-spu.c (ocl_program_data_key): Change type.
3551         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3552         Update.
3553
3554 2019-07-10  Tom Tromey  <tromey@adacore.com>
3555
3556         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3557         (struct solib_aix_inferior_data) <library_list>: Change type.
3558         (solib_aix_inferior_data_handle): Change type.
3559         (get_solib_aix_inferior_data): Update.
3560         (solib_aix_free_library_list): Remove.
3561         (library_list_start_library): Update.
3562         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3563         return type.
3564         (solib_aix_get_library_list)
3565         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3566         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3567
3568 2019-07-10  Tom Tromey  <tromey@adacore.com>
3569
3570         * solib-dsbt.c (struct dsbt_info): Add initializers.
3571         (solib_dsbt_pspace_data): Change type.
3572         (dsbt_pspace_data_cleanup): Remove.
3573         (get_dsbt_info, _initialize_dsbt_solib): Update.
3574
3575 2019-07-10  Tom Tromey  <tromey@adacore.com>
3576
3577         * spu-tdep.c (spu_overlay_data): Change type.
3578         (spu_get_overlay_table, spu_overlay_new_objfile)
3579         (_initialize_spu_tdep): Update.
3580
3581 2019-07-10  Tom Tromey  <tromey@adacore.com>
3582
3583         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3584         destructor.
3585         (dbx_objfile_data_key): Change type and declare later.
3586         (DBX_SYMFILE_INFO): Rewrite.
3587         * dbxread.c (dbx_objfile_data_key): Change type.
3588         (dbx_symfile_init): Update.
3589         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3590         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3591         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3592
3593 2019-07-10  Tom Tromey  <tromey@adacore.com>
3594
3595         * jit.c (jit_program_space_key): Change type.  Move lower.
3596         (get_jit_program_space_data): Update.
3597         (jit_program_space_data_cleanup): Remove.
3598         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3599         Update.
3600         (struct jit_program_space_data): Add initializers.
3601
3602 2019-07-10  Tom Tromey  <tromey@adacore.com>
3603
3604         * solib-darwin.c (struct darwin_info): Add initializers.
3605         (solib_darwin_pspace_data): Change type.
3606         (darwin_pspace_data_cleanup): Remove.
3607         (get_darwin_info, _initialize_darwin_solib): Update.
3608
3609 2019-07-10  Tom Tromey  <tromey@adacore.com>
3610
3611         * remote-sim.c (struct sim_inferior_data): Add initializers,
3612         constructor, and destructor.
3613         (sim_inferior_data_key): Change type.  Move lower.
3614         (check_for_duplicate_sim_descriptor): Update.
3615         (get_sim_inferior_data): Use new.  Update.
3616         (~sim_inferior_data_cleanup): Rename from
3617         sim_inferior_data_cleanup.  Simplify.
3618         (gdbsim_close_inferior, simulator_command)
3619         (sim_command_completer, _initialize_remote_sim): Update.
3620         (next_pid, INITIAL_PID): Move earlier.
3621
3622 2019-07-10  Tom Tromey  <tromey@adacore.com>
3623
3624         * python/python-internal.h (create_thread_object): Return
3625         gdbpy_ref.
3626         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3627         * python/py-inferior.c (struct threadlist_entry): Add
3628         constructor.
3629         <thread_obj>: Now a gdbpy_ref.
3630         (thread_to_thread_object): Update.
3631         (add_thread_object): Use new.
3632         (delete_thread_object): Use delete.
3633         (infpy_threads): Update.
3634         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3635         GIL.
3636
3637 2019-07-10  Tom Tromey  <tromey@adacore.com>
3638
3639         * valops.c (value_cast): Specialize error message for Ada.
3640
3641 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3642
3643         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3644
3645 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3646
3647         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3648         bpstat_should_step): Return bool, adjust comments.
3649         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3650         bpstat_should_step): Likewise.
3651
3652 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3653
3654         * features/Makefile: Use feature target descriptions for Arm.
3655         * features/arm/arm-core.c: Generate new file.
3656         * features/arm/arm-fpa.c: Likewise.
3657         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3658         * features/arm/arm-m-profile.c: Likewise.
3659         * features/arm/arm-vfpv2.c: Likewise.
3660         * features/arm/arm-vfpv3.c: Likewise.
3661         * features/arm/xscale-iwmmxt.c: Likewise.
3662         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3663
3664 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3665
3666         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3667         ptrace earlier.
3668
3669 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3670
3671         * features/aarch64-pauth.c: Regenerate.
3672
3673 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3674
3675         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3676         bool.
3677         (bpstat_what): Use false instead of 0.
3678
3679 2019-07-09  Pedro Alves  <palves@redhat.com>
3680
3681         * break-catch-throw.c (is_exception_catchpoint): New.
3682         * breakpoint.c (print_one_breakpoint_location): New parameter
3683         'raw_loc'.  Handle it.  Use
3684         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3685         looking at the breakpoint's type.
3686         (print_one_breakpoint): If handling "maint info breakpoints", also
3687         print locations of exception catchpoints.
3688         * breakpoint.h (is_exception_catchpoint): Declare.
3689
3690 2019-07-09  Pedro Alves  <palves@redhat.com>
3691
3692         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3693         "addr" field.
3694         (allocate_location_exception_catchpoint): New.
3695         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3696         (initialize_throw_catchpoint_ops): Install
3697         allocate_location_exception_catchpoint as allocate_location
3698         method.
3699         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3700         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3701         bp_loc_other.
3702         (breakpoint_address_is_meaningful): Delete.
3703         (bl_address_is_meaningful): New.
3704         (breakpoint_locations_match): Adjust comment.
3705         (bp_location_from_bp_type): New, factored out of...
3706         (bp_location::bp_location(breakpoint *)): ... this.
3707         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3708         factored out of...
3709         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3710         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3711         breakpoint_address_is_meaningful.
3712         (bp_locations_compare): Adjust comment.
3713         (update_global_location_list): Use bl_address_is_meaningful
3714         instead of breakpoint_address_is_meaningful.
3715         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3716         explicit.
3717         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3718         * python/py-breakpoint.c (bppy_get_location): No longer check
3719         whether location is null.
3720
3721 2019-07-09  Pedro Alves  <palves@redhat.com>
3722
3723         PR c++/15468
3724         * breakpoint.c (print_one_breakpoint_location): Remove
3725         single-location assert.
3726
3727 2019-07-09  Tom Tromey  <tom@tromey.com>
3728
3729         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3730         * configure: Rebuild.
3731         * configure.ac: Change common to gdbsupport.
3732         * gdbsupport: Rename from common.
3733         * acinclude.m4: Change common to gdbsupport.
3734         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3735         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3736         gdbsupport.
3737         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3738         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3739         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3740         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3741         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3742         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3743         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3744         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3745         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3746         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3747         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3748         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3749         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3750         coff-pe-read.c, command.h, compile/compile-c-support.c,
3751         compile/compile-c.h, compile/compile-cplus-symbols.c,
3752         compile/compile-cplus-types.c, compile/compile-cplus.h,
3753         compile/compile-loc2c.c, compile/compile.c, completer.c,
3754         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3755         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3756         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3757         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3758         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3759         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3760         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3761         features/aarch64-core.c, features/aarch64-fpu.c,
3762         features/aarch64-pauth.c, features/aarch64-sve.c,
3763         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3764         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3765         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3766         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3767         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3768         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3769         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3770         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3771         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3772         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3773         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3774         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3775         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3776         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3777         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3778         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3779         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3780         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3781         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3782         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3783         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3784         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3785         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3786         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3787         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3788         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3789         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3790         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3791         minsyms.c, mips-linux-tdep.c, namespace.h,
3792         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3793         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3794         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3795         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3796         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3797         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3798         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3799         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3800         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3801         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3802         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3803         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3804         procfs.c, producer.c, progspace.h, psymtab.h,
3805         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3806         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3807         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3808         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3809         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3810         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3811         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3812         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3813         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3814         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3815         target-memory.c, target.c, target.h, target/waitstatus.c,
3816         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3817         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3818         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3819         unittests/array-view-selftests.c,
3820         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3821         unittests/common-utils-selftests.c,
3822         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3823         unittests/format_pieces-selftests.c,
3824         unittests/function-view-selftests.c,
3825         unittests/lookup_name_info-selftests.c,
3826         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3827         unittests/mkdir-recursive-selftests.c,
3828         unittests/observable-selftests.c,
3829         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3830         unittests/parse-connection-spec-selftests.c,
3831         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3832         unittests/scoped_fd-selftests.c,
3833         unittests/scoped_mmap-selftests.c,
3834         unittests/scoped_restore-selftests.c,
3835         unittests/string_view-selftests.c, unittests/style-selftests.c,
3836         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3837         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3838         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3839         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3840         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3841         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3842
3843 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3844
3845         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3846         bool value.
3847         (decode_digits_ordinary): Set explicit_line field in sal.
3848         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3849         symtab_and_line that was set on an explicit line number in
3850         assembler code.  Do always update the recorded symtab and line if
3851         we do skip the prologue.
3852
3853 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3854
3855         * breakpoint.c (set_breakpoint_location_function): Remove
3856         explicit_loc parameter.
3857         (momentary_breakpoint_from_master): Update call to
3858         set_breakpoint_location_function.
3859         (add_location_to_breakpoint): Likewise.
3860
3861 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3862
3863         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3864         required features based on default bfd type when no specific bfd
3865         is present.
3866
3867 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3868
3869         * NEWS: Mention that GDB printf and eval commands can now print
3870         C-style and Ada-style convenience var strings without
3871         calling the inferior.
3872         * printcmd.c (printf_c_string): Locally print GDB internal var
3873         instead of transiting via the inferior.
3874         (printf_wide_c_string): Likewise.
3875
3876 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3877
3878         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3879
3880 2019-07-04  Tom Tromey  <tom@tromey.com>
3881
3882         PR tui/24724:
3883         * tui/tui-winsource.c (tui_clear_source_content): Update.
3884         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3885         (tui_update_breakpoint_info): Update.
3886         (tui_set_exec_info_content): Update.
3887         * tui/tui-source.c (tui_set_source_content_nil): Update.
3888         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3889         has_break.
3890         * tui/tui-data.h (enum tui_bp_flag): New.
3891         (tui_bp_flags): New enum flags type.
3892         (struct tui_source_element) <break_mode>: Change type.  Rename
3893         from has_break.
3894         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3895         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3896         constants.
3897         * tui/tui-winsource.h: Fix comment.
3898
3899 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3900
3901         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3902         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3903         (store_fpregs_to_thread)
3904         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3905         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3906         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3907         (IWMMXT_REGS_SIZE): Add define.
3908         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3909         (fetch_vfp_regs, store_vfp_regs)
3910         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3911         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3912
3913 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3914
3915         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3916         defines.
3917         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3918         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3919         (ARM_INT_REGISTER_SIZE): ...to this.
3920         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3921         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3922         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3923         (arm_linux_collect_gregset, supply_nwfpe_register)
3924         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3925         defines.
3926         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3927         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3928         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3929         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3930         (arm_return_in_memory, arm_store_return_value)
3931         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3932         (arm_record_ld_st_multiple): Likewise.
3933         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3934         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3935
3936 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3937
3938         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3939         AARCH64_DISPLACED_MODIFIED_INSNS.
3940         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3941         (aarch64_displaced_step_copy_insn): Likewise.
3942         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3943         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3944         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3945         ARM_DISPLACED_MODIFIED_INSNS.
3946         * arm-tdep.c (arm_gdbarch_init): Likewise.
3947         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3948         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3949         (struct arm_displaced_step_closure): Use
3950         ARM_DISPLACED_MODIFIED_INSNS.
3951
3952 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3953
3954         * features/Makefile: Remove unused xml files.
3955         * features/aarch64.xml: Remove.
3956         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3957         * features/i386/amd64-avx-avx512.xml: Remove.
3958         * features/i386/amd64-avx-linux.xml: Remove.
3959         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3960         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3961         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3962         * features/i386/amd64-avx-mpx.xml: Remove.
3963         * features/i386/amd64-avx.xml: Remove.
3964         * features/i386/amd64-linux.xml: Remove.
3965         * features/i386/amd64-mpx-linux.xml: Remove.
3966         * features/i386/amd64-mpx.xml: Remove.
3967         * features/i386/amd64.xml: Remove.
3968         * features/i386/i386-avx-avx512-linux.xml: Remove.
3969         * features/i386/i386-avx-avx512.xml: Remove.
3970         * features/i386/i386-avx-linux.xml: Remove.
3971         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3972         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3973         * features/i386/i386-avx-mpx-linux.xml: Remove.
3974         * features/i386/i386-avx-mpx.xml: Remove.
3975         * features/i386/i386-avx.xml: Remove.
3976         * features/i386/i386-linux.xml: Remove.
3977         * features/i386/i386-mmx-linux.xml: Remove.
3978         * features/i386/i386-mmx.xml: Remove.
3979         * features/i386/i386-mpx-linux.xml: Remove.
3980         * features/i386/i386-mpx.xml: Remove.
3981         * features/i386/i386.xml: Remove.
3982         * features/i386/x32-avx-avx512-linux.xml: Remove.
3983         * features/i386/x32-avx-linux.xml: Remove.
3984         * features/i386/x32-linux.xml: Remove.
3985
3986 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3987
3988         * regformats/aarch64.dat: Remove.
3989         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3990         * regformats/i386/amd64-avx-linux.dat: Remove.
3991         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3992         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3993         * regformats/i386/amd64-linux.dat: Remove.
3994         * regformats/i386/amd64-mpx-linux.dat: Remove.
3995         * regformats/i386/amd64.dat: Remove.
3996         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3997         * regformats/i386/i386-avx-linux.dat: Remove.
3998         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3999         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4000         * regformats/i386/i386-linux.dat: Remove.
4001         * regformats/i386/i386-mmx-linux.dat: Remove.
4002         * regformats/i386/i386-mpx-linux.dat: Remove.
4003         * regformats/i386/i386.dat: Remove.
4004         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4005         * regformats/i386/x32-avx-linux.dat: Remove.
4006         * regformats/i386/x32-linux.dat: Remove.
4007
4008 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4009
4010         * aarch64-tdep.c: Remove xml self tests.
4011         * amd64-linux-tdep.c: Likewise.
4012         * amd64-tdep.c: Likewise.
4013         * i386-linux-tdep.c: Likewise.
4014         * i386-tdep.c: Likewise.
4015
4016 2019-07-03  Pedro Alves  <palves@redhat.com>
4017
4018         PR cli/24732
4019         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4020         (pipe_cmd_option_defs): New.
4021         (make_pipe_cmd_options_def_group): New.
4022         (pipe_command): Use gdb::option::process_options.
4023         (pipe_command_completer): New function.
4024         (_initialize_cli_cmds): Install completer for "pipe" command.
4025
4026 2019-07-03  Pedro Alves  <palves@redhat.com>
4027
4028         * cli/cli-option.c (union option_value) <string>: New field.
4029         (struct option_def_and_value): Add ctor, move ctor, dtor and
4030         use DISABLE_COPY_AND_ASSIGN.
4031         (option_def_and_value::clear_value): New.
4032         (parse_option, save_option_value_in_ctx, get_val_type_str)
4033         (add_setshow_cmds_for_options): Handle var_string.
4034         * cli-option.h (union option_def::var_address) <string>: New
4035         field.
4036         (struct string_option_def): New.
4037         * maint-test-options.c (struct test_options_opts): Add default
4038         ctor and use DISABLE_COPY_AND_ASSIGN.
4039         <string_opt>: New field.
4040         (test_options_opts::~test_options_opts): New.
4041         (test_options_opts::dump): Also dump "-string".
4042         (test_options_option_defs): Install "string.
4043
4044 2019-07-03  Pedro Alves  <palves@redhat.com>
4045
4046         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4047         option_value with a null enumeration.
4048         (complete_options): Save the option values in the context.
4049         (save_option_value_in_ctx): New, factored out from ...
4050         (process_options): ... here.
4051         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4052         of the function.
4053         * maint-test-options.c (test_options_opts::dump): New, factored
4054         out from ...
4055         (maintenance_test_options_command_mode): ... here.
4056         (maintenance_test_options_command_completion_result): Delete.
4057         (maintenance_test_options_command_completion_text): Update
4058         comment.
4059         (maintenance_show_test_options_completion_result): Change
4060         prototype.  Just print
4061         maintenance_test_options_command_completion_text.
4062         (save_completion_result): New.
4063         (maintenance_test_options_completer_mode): Pass options context to
4064         complete_options, and then save a dump.
4065         (_initialize_maint_test_options): Use add_cmd to install "maint
4066         show test-options-completion-result".
4067
4068 2019-07-03  Pedro Alves  <palves@redhat.com>
4069
4070         * NEWS (New commands): Mention "with" and "maint with".
4071         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4072         (with_command, with_command_completer): New.
4073         (pipe_command): Adjust to new repeat_previous
4074         interface.
4075         (_initialize_cli_cmds): Install the "with" command and its "w"
4076         alias.
4077         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4078         declarations.
4079         * cli/cli-setshow.c (parse_cli_var_uinteger)
4080         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4081         argument strings for all var_types.
4082         (get_setshow_command_value_string): New, factored out from ...
4083         (do_show_command): ... this.
4084         * cli/cli-setshow.h: Include <string>.
4085         (get_setshow_command_value_string): Declare.
4086         * command.h (repeat_previous): Now returns const char *.  Adjust
4087         comment.
4088         * maint.c: Include "cli/cli-cmds.h".
4089         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4090         (_initialize_maint_cmds): Register the "maintenance with" command.
4091         * top.c (repeat_previous): Move bits from pipe_command here:
4092         Return the saved command line, if any; error out if there's no
4093         command to relaunch.
4094
4095 2019-07-03  Pedro Alves  <palves@redhat.com>
4096
4097         * NEWS (New commands): Mention "maint set/show test-settings"
4098         instead of "maint test-settings".
4099         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4100         (maintenance_test_settings_set_list): Rename to ...
4101         (maintenance_set_test_settings_list): ... this.
4102         (maintenance_test_settings_show_list): Rename to  ...
4103         (maintenance_show_test_settings_list): ... this.
4104         (maintenance_test_settings_cmd): Delete.
4105         (maintenance_test_settings_set_cmd): ...
4106         (maintenance_set_test_settings_cmd): ... this.
4107         (maintenance_test_settings_show_cmd): ...
4108         (maintenance_show_test_settings_cmd): ... this.
4109         (maintenance_test_settings_show_value_cmd):
4110         (maintenance_show_test_settings_value_cmd): ... this.
4111         (_initialize_maint_test_settings): No longer install the "maint
4112         test-settings" prefix command.  Rename "maint test-settings set"
4113         to "maint set test-settings", and "maint test-settings show" to
4114         "maint show test-settings".  Adjust all subcommands.
4115
4116 2019-07-03  Pedro Alves  <palves@redhat.com>
4117
4118         * maint-test-settings.c: Fix file's intro comment.  Replace all
4119         references to "test-options" with references to "test-settings",
4120         in comments.
4121
4122 2019-07-03  Pedro Alves  <palves@redhat.com>
4123
4124         * maint-test-settings.c (maintenance_test_settings_xxx)
4125         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4126         New.
4127         (maintenance_test_settings_enums): Use them.
4128         (maintenance_test_settings_enum): Default to
4129         maintenance_test_settings_xxx.
4130         (_initialize_maint_test_settings): Initialize
4131         MAINTENANCE_TEST_SETTINGS_FILENAME.
4132
4133 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4134
4135         * breakpoint.h (remove_breakpoints_inf): Change return type to
4136         void, move function documentation here.
4137         * breakpoint.c (remove_breakpoints_inf): Change return type to
4138         void, move function documentation to header.
4139
4140 2019-07-02  Pedro Alves  <palves@redhat.com>
4141
4142         * NEWS (Completion improvements): Mention "info threads".
4143         * thread.c (struct info_threads_opts, info_threads_option_defs)
4144         (make_info_threads_options_def_group): New.
4145         (info_threads_command): Use gdb::option::process_options.
4146         (info_threads_command_completer): New.
4147         (_initialize_thread): Use gdb::option::build_help to build the
4148         help text for "info threads".
4149
4150 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4151
4152         * defs.h (generic_load): Move from here...
4153         * symfile.h (generic_load): ... to here.  Rename name parameter
4154         to args.
4155         * symfile.c (generic_load): Add comment.
4156
4157 2019-07-01  Tom Tromey  <tromey@adacore.com>
4158
4159         * dwarf2read.c
4160         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4161         declaration of without_params.  Fix formatting.
4162
4163 2019-07-01  Tom Tromey  <tromey@adacore.com>
4164
4165         * ada-exp.y (find_primitive_type): Update.
4166         * ada-lang.h (ada_lookup_symbol): Update.
4167         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4168         parameter.
4169         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4170
4171 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4172
4173         PR breakpoints/24541
4174         * gdbarch.c: Regenerate.
4175         * gdbarch.h: Regenerate.
4176         * gdbarch.sh: Add 'stap_adjust_register'.
4177         * i386-tdep.c: Include '<unordered_set>'.
4178         (i386_stap_adjust_register): New function.
4179         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4180         * stap-probe.c (stap_parse_register_operand): Call
4181         'gdbarch_stap_adjust_register'.
4182
4183 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4184
4185         PR python/24742
4186         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4187         * python/python.c (do_start_initialization): Use 'xmalloc'
4188         instead of 'PyMem_Malloc'.
4189
4190 2019-06-28  Tom Tromey  <tromey@adacore.com>
4191
4192         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4193         for Ada.
4194
4195 2019-06-27  Tom Tromey  <tromey@adacore.com>
4196
4197         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4198         objfile_key.
4199         (arm_find_mapping_symbol, arm_record_special_symbol)
4200         (_initialize_arm_tdep): Update.
4201         (arm_objfile_data_free): Remove.
4202
4203 2019-06-27  Tom Tromey  <tromey@adacore.com>
4204
4205         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4206         to cp_print_static_field.
4207
4208 2019-06-26  Tom Tromey  <tromey@adacore.com>
4209
4210         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4211         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4212         declare.
4213
4214 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4215
4216         * features/aarch64-core.c (create_feature_aarch64_core):
4217         Regenerate.
4218         * features/aarch64-core.xml: Add cpsr flags.
4219
4220 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4221
4222         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4223         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4224
4225 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4226
4227         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4228         field.
4229         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4230         use.
4231         (arm_record_special_symbol): Don't insert new symbol in sorted
4232         position, push it at the end.
4233
4234 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4235
4236         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4237         (arm_mapping_symbol_s): Remove.
4238         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4239         (arm_mapping_symbol_vec): New typedef.
4240         (struct arm_per_objfile): Add constructor.
4241         <section_maps>: Change type to
4242         std::unique_ptr<arm_mapping_symbol_vec[]>.
4243         (arm_compare_mapping_symbols): Remove.
4244         (arm_find_mapping_symbol): Adjust to section_maps type change.
4245         (arm_objfile_data_free): Call delete on arm_per_objfile.
4246         (arm_record_special_symbol): Adjust to section_maps type change.
4247         Allocate arm_per_objfile with new.
4248
4249 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4250
4251         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4252         with the command prefix.
4253
4254 2019-06-25  Tom Tromey  <tom@tromey.com>
4255
4256         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4257         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4258
4259 2019-06-25  Tom Tromey  <tom@tromey.com>
4260
4261         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4262         type.
4263         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4264         protected.
4265
4266 2019-06-25  Tom Tromey  <tom@tromey.com>
4267
4268         * tui/tui-winsource.c
4269         (tui_source_window_base::set_is_exec_point_at): Add check against
4270         LOA_ADDRESS.
4271
4272 2019-06-25  Tom Tromey  <tom@tromey.com>
4273
4274         * tui/tui-source.c (tui_set_source_content): Don't check before
4275         xfree.
4276         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4277
4278 2019-06-25  Tom Tromey  <tom@tromey.com>
4279
4280         * tui/tui-winsource.h (tui_update_source_window_as_is)
4281         (tui_alloc_source_buffer, tui_line_is_displayed)
4282         (tui_addr_is_displayed): Change type of win_info.
4283         * tui/tui-winsource.c (tui_update_source_window_as_is)
4284         (tui_clear_source_content, tui_show_source_line)
4285         (tui_show_source_content, tui_source_window_base::refill)
4286         (tui_source_window_base::set_is_exec_point_at)
4287         (tui_source_window_base::set_is_exec_point_at)
4288         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4289         (tui_alloc_source_buffer, tui_line_is_displayed)
4290         (tui_addr_is_displayed): Change type of win_info.  Update.
4291         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4292         (tui_source_window_base::do_make_visible_with_new_height):
4293         Update.
4294         * tui/tui-source.c (tui_set_source_content)
4295         (tui_set_source_content_nil)
4296         (tui_source_window::do_scroll_vertical): Update.
4297         * tui/tui-layout.c (show_layout): Update.
4298         * tui/tui-disasm.c (tui_set_disassem_content)
4299         (tui_disasm_window::do_scroll_vertical): Update.
4300         * tui/tui-data.h (tui_win_content): Remove.
4301         (struct tui_gen_win_info) <content, content_size>: Remove.
4302         (struct tui_source_element): Add initializers and destructor.
4303         (union tui_which_element, struct tui_win_element): Remove.
4304         (struct tui_source_window_base) <content>: New field.
4305         (struct tui_data_window): Remove destructor.
4306         (tui_alloc_content, tui_free_win_content)
4307         (tui_free_all_source_wins_content): Don't declare.
4308         * tui/tui-data.c (tui_initialize_static_data): Update.
4309         (init_content_element, tui_alloc_content): Remove.
4310         (~tui_gen_win_info): Update.
4311         (~tui_data_window, tui_free_all_source_wins_content)
4312         (tui_free_win_content, free_content, free_content_elements):
4313         Remove.
4314
4315 2019-06-25  Tom Tromey  <tom@tromey.com>
4316
4317         * tui/tui-winsource.h (tui_clear_source_content)
4318         (tui_erase_source_content, tui_show_source_content): Change type
4319         of win_info.
4320         * tui/tui-winsource.c (tui_clear_source_content)
4321         (tui_erase_source_content, tui_show_source_content): Change type
4322         of win_info.
4323         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4324         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4325         win_info.
4326         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4327         win_info.
4328         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4329
4330 2019-06-25  Tom Tromey  <tom@tromey.com>
4331
4332         * tui/tui-winsource.c (tui_clear_source_content)
4333         (tui_source_window_base::set_is_exec_point_at): Update.
4334         * tui/tui-source.c (tui_set_source_content_nil): Update.
4335         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4336         a bool.
4337         * tui/tui-data.c (init_content_element): Update.
4338
4339 2019-06-25  Tom Tromey  <tom@tromey.com>
4340
4341         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4342         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4343         * tui/tui-layout.c (init_and_make_win): Update.
4344         * tui/tui.h (enum tui_win_type): Update.
4345         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4346         tui_win_is_auxillary.
4347         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4348         tui_win_is_auxillary.
4349
4350 2019-06-25  Tom Tromey  <tom@tromey.com>
4351
4352         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4353         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4354         (tui_delete_data_content_windows, tui_display_all_data)
4355         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4356         Update.
4357         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4358         * tui/tui-regs.c (tui_last_regs_line_no)
4359         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4360         (tui_show_registers): Update.
4361         (tui_show_register_group): Return void.  Update.
4362         (tui_display_registers_from, tui_display_reg_element_at_line)
4363         (tui_display_registers_from_line, tui_check_register_values):
4364         Update.
4365         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4366         member.
4367         (struct tui_data_window) <regs_content>: Now a std::vector.
4368         <regs_content_count>: Remove.
4369         (tui_add_content_elements, tui_free_data_content): Don't declare.
4370         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4371         (init_content_element): Remove DATA_WIN case.  Add assert.
4372         (tui_add_content_elements): Remove.
4373         (tui_data_window): Update.
4374         (tui_free_data_content): Remove.
4375         (free_content_elements): Remove DATA_WIN case.
4376
4377 2019-06-25  Tom Tromey  <tom@tromey.com>
4378
4379         * tui/tui-data.c (tui_data_item_window): Update.
4380         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4381         * tui/tui-windata.c (tui_display_all_data)
4382         (tui_display_data_from_line): Update.
4383         (tui_check_data_values): Remove.
4384         * tui/tui-regs.c (tui_show_register_group)
4385         (tui_display_reg_element_at_line): Update.
4386         * tui/tui-hooks.c (tui_register_changed)
4387         (tui_refresh_frame_and_register_information): Call
4388         tui_check_register_values.
4389         * tui/tui-data.h (struct tui_data_window) <data_content,
4390         data_content_count, data_type>: Remove.
4391         (enum tui_data_type): Remove.
4392
4393         * tui/tui-data.c (tui_data_window::clear_detail)
4394         (~tui_data_window): Update.
4395
4396 2019-06-25  Tom Tromey  <tom@tromey.com>
4397
4398         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4399         declare.
4400         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4401         Rename from tui_first_data_item_displayed.  Update.
4402         (tui_data_window::refresh_all)
4403         (tui_data_window::do_scroll_vertical): Update.
4404         * tui/tui-data.h (struct tui_data_window)
4405         <first_data_item_displayed>: Declare new method.
4406
4407 2019-06-25  Tom Tromey  <tom@tromey.com>
4408
4409         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4410         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4411         contents...
4412         (tui_initialize_static_data): ...here.
4413
4414 2019-06-25  Tom Tromey  <tom@tromey.com>
4415
4416         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4417         (tui_display_registers_from, tui_check_register_values): Update.
4418         (tui_display_register): Remove win_info parameter; update.
4419         (tui_get_register): Change type of parameters.
4420         * tui/tui-data.h (struct tui_data_element): Remove.
4421         (union tui_which_element) <data>: Remove.
4422         <data_window>: Change type.
4423         (struct tui_data_item_window): New.
4424         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4425         case.  Add assert.
4426         (~tui_data_item_window): New destructor.
4427         (free_content_elements): Remove DATA_ITEM_WIN case.
4428
4429 2019-06-25  Tom Tromey  <tom@tromey.com>
4430
4431         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4432         Remove.
4433
4434 2019-06-25  Tom Tromey  <tom@tromey.com>
4435
4436         * tui/tui-data.h (struct tui_command_element): Remove.
4437         (union tui_which_element) <command>: Remove.
4438         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4439         assert.
4440         (free_content_elements): Remove CMD_WIN case.
4441
4442 2019-06-25  Tom Tromey  <tom@tromey.com>
4443
4444         * tui/tui-layout.c (tui_set_layout): Update.
4445         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4446         * tui/tui-data.c (layout_def): Update.
4447
4448 2019-06-25  Tom Tromey  <tom@tromey.com>
4449
4450         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4451         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4452         (tui_source_window_base::set_new_height): Update.
4453         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4454         Update.
4455         (tui_set_locator_fullname, tui_set_locator_info)
4456         (tui_show_frame_info): Update.
4457         * tui/tui-source.c (tui_set_source_content)
4458         (tui_source_is_displayed): Update.
4459         * tui/tui-layout.c (show_source_disasm_command, show_data)
4460         (show_source_or_disasm_and_command): Update.
4461         * tui/tui-disasm.c (tui_set_disassem_content)
4462         (tui_get_begin_asm_address): Update.
4463         * tui/tui-data.h (struct tui_locator_element): Remove.
4464         (union tui_which_element) <locator>: Remove.
4465         (struct tui_locator_window): New.
4466         (tui_locator_win_info_ptr): Change return type.
4467         * tui/tui-data.c (_locator): Change type.
4468         (tui_locator_win_info_ptr): Change return type.
4469         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4470         (tui_alloc_content): Add assert.
4471
4472 2019-06-25  Tom Tromey  <tom@tromey.com>
4473
4474         * tui/tui-winsource.c
4475         (tui_exec_info_window::maybe_allocate_content): New method.
4476         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4477         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4478         (make_source_or_disasm_window): Add cast.
4479         * tui/tui-data.h (union tui_which_element) <simple_string>:
4480         Remove.
4481         (struct tui_source_info): New.
4482         (struct tui_source_window_base) <execution_info>: Change type.
4483         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4484         case, and add assert.
4485         (tui_alloc_content): Add assert.
4486
4487 2019-06-25  Tom Tromey  <tom@tromey.com>
4488
4489         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4490         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4491         * tui/tui-data.c (tui_alloc_win_info): Remove.
4492
4493 2019-06-25  Tom Tromey  <tom@tromey.com>
4494
4495         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4496         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4497         can_highlight.
4498
4499 2019-06-25  Tom Tromey  <tom@tromey.com>
4500
4501         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4502         make_visible_with_new_height method.
4503         (tui_win_info::make_visible_with_new_height): New method.
4504         (tui_source_window_base::do_make_visible_with_new_height)
4505         (tui_data_window::do_make_visible_with_new_height)
4506         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4507         (make_visible_with_new_height): Remove.
4508         (tui_resize_all, tui_adjust_win_heights): Use
4509         make_visible_with_new_height method.
4510         * tui/tui-data.h (struct tui_win_info)
4511         <do_make_visible_with_new_height, make_visible_with_new_height>:
4512         New methods.
4513         (struct tui_source_window_base, struct tui_data_window)
4514         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4515         methods.
4516
4517 2019-06-25  Tom Tromey  <tom@tromey.com>
4518
4519         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4520         method.
4521         (update_tab_width): Call update_tab_width method.
4522         * tui/tui-data.h (struct tui_win_info)
4523         (struct tui_source_window_base) <update_tab_width>: New methods.
4524
4525 2019-06-25  Tom Tromey  <tom@tromey.com>
4526
4527         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4528         parameter.
4529         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4530         parameter.
4531         (tui_gen_win_info::make_visible): Update.
4532         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4533         parameter.
4534         * tui/tui-data.h (enum tui_box): New enum.
4535         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4536
4537 2019-06-25  Tom Tromey  <tom@tromey.com>
4538
4539         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4540         init_and_make_win for EXEC_INFO_WIN.
4541         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4542         longer inline.
4543         (struct tui_win_info) <~tui_win_info>: Inline.
4544         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4545         Don't declare.
4546         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4547         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4548         Remove.
4549         (tui_initialize_static_data): Update.
4550         (~tui_gen_win_info): Handle more cleanup here.
4551         (~tui_source_window_base): Delete "execution_info".
4552         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4553
4554 2019-06-25  Tom Tromey  <tom@tromey.com>
4555
4556         * tui/tui-layout.c (make_command_window): Don't set
4557         can_highlight.
4558         (show_source_disasm_command): Call the reset method.
4559         (show_data): Don't set can_highlight.  Call the reset method.
4560         (tui_gen_win_info::reset): Rename from init_gen_win_info
4561         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4562         (show_source_or_disasm_and_command): Call the reset method.
4563         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4564         (struct tui_cmd_window): Set can_highlight.
4565
4566 2019-06-25  Tom Tromey  <tom@tromey.com>
4567
4568         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4569         from make_visible.
4570         (tui_make_visible, tui_make_invisible): Rewrite.
4571         (tui_win_info::make_visible): Remove.
4572         (tui_source_window_base::make_visible): Update.
4573         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4574         method.  Moved from...
4575         (struct tui_win_info) <make_visible>: ...here.
4576
4577 2019-06-25  Tom Tromey  <tom@tromey.com>
4578
4579         * tui/tui-winsource.c
4580         (tui_source_window_base::do_scroll_horizontal): Remove direction
4581         parameter.
4582         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4583         direction parameter.
4584         * tui/tui-win.c (tui_win_info::forward_scroll)
4585         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4586         (tui_win_info::right_scroll): Update.
4587         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4588         direction parameter.
4589         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4590         direction parameter.
4591         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4592         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4593         Remove direction parameter.
4594         (struct tui_source_window_base, struct tui_source_window)
4595         (struct tui_disasm_window, struct tui_data_window)
4596         (struct tui_cmd_window): Update.
4597
4598 2019-06-25  Tom Tromey  <tom@tromey.com>
4599
4600         * tui/tui-winsource.h (tui_set_exec_info_content)
4601         (tui_show_exec_info_content, tui_erase_exec_info_content)
4602         (tui_clear_exec_info_content, tui_update_exec_info): Change
4603         argument to tui_source_window_base.
4604         * tui/tui-winsource.c (tui_set_exec_info_content)
4605         (tui_show_exec_info_content, tui_erase_exec_info_content)
4606         (tui_clear_exec_info_content, tui_update_exec_info): Change
4607         argument to tui_source_window_base.
4608
4609 2019-06-25  Tom Tromey  <tom@tromey.com>
4610
4611         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4612         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4613
4614 2019-06-25  Tom Tromey  <tom@tromey.com>
4615
4616         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4617         check.
4618
4619 2019-06-25  Tom Tromey  <tom@tromey.com>
4620
4621         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4622         type to void.
4623         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4624         type to void.
4625         * tui/tui-source.c (tui_set_source_content): Update.
4626         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4627
4628 2019-06-25  Tom Tromey  <tom@tromey.com>
4629
4630         * tui/tui-win.c (window_name_completer, tui_set_focus)
4631         (tui_all_windows_info): Use name method.
4632         * tui/tui-data.h (struct tui_gen_win_info)
4633         (struct tui_source_window, struct tui_disasm_window)
4634         (struct tui_data_window, struct tui_cmd_window) <name>: New
4635         method.
4636         (tui_win_name): Don't declare.
4637         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4638         (tui_win_name): Remove.
4639
4640 2019-06-25  Tom Tromey  <tom@tromey.com>
4641
4642         * tui/tui-winsource.h (tui_update_source_window)
4643         (tui_update_source_window_as_is): Change parameter type.
4644         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4645         to be a tui_source_window_base.
4646         (tui_update_source_window_as_is): Likewise.
4647         * tui/tui-win.c (make_visible_with_new_height): Update.
4648
4649 2019-06-25  Tom Tromey  <tom@tromey.com>
4650
4651         * tui/tui-winsource.c (tui_erase_source_content)
4652         (tui_show_source_content, tui_show_exec_info_content)
4653         (tui_erase_exec_info_content): Use refresh_window method.
4654         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4655         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4656         from tui_refresh_win.
4657         (tui_data_window::refresh_window): New method.
4658         (tui_win_info::refresh, tui_source_window_base::refresh)
4659         (tui_refresh_all): Use refresh_window method.
4660         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4661         method.
4662         * tui/tui-regs.c (tui_display_register): Call refresh_window
4663         method.
4664         * tui/tui-layout.c (show_source_disasm_command)
4665         (show_source_or_disasm_and_command): Call refresh_window method.
4666         * tui/tui-data.h (struct tui_gen_win_info)
4667         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4668         New method.
4669
4670 2019-06-25  Tom Tromey  <tom@tromey.com>
4671
4672         * tui/tui.c (tui_rl_other_window, tui_enable)
4673         (tui_is_window_visible, tui_get_command_dimension): Update.
4674         * tui/tui-winsource.c (tui_update_source_window_as_is)
4675         (tui_clear_source_content, tui_erase_source_content)
4676         (tui_show_source_line, tui_source_window_base::refill)
4677         (tui_source_window_base::do_scroll_horizontal)
4678         (tui_source_window_base::set_is_exec_point_at)
4679         (tui_update_breakpoint_info, tui_set_exec_info_content)
4680         (tui_alloc_source_buffer, tui_line_is_displayed)
4681         (tui_addr_is_displayed): Update.
4682         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4683         (tui_check_and_display_highlight_if_needed)
4684         (tui_win_info::make_visible, tui_win_info::refresh)
4685         (tui_refresh_all): Update.
4686         * tui/tui-windata.c (tui_first_data_item_displayed)
4687         (tui_delete_data_content_windows, tui_erase_data_content)
4688         (tui_display_all_data, tui_data_window::refresh_all)
4689         (tui_check_data_values): Update.
4690         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4691         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4692         (tui_win_info::backward_scroll, tui_refresh_all_win)
4693         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4694         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4695         (tui_source_window_base::set_new_height)
4696         (tui_data_window::set_new_height)
4697         (make_invisible_and_set_new_height)
4698         (make_visible_with_new_height, new_height_ok)
4699         (parse_scrolling_args): Update.
4700         * tui/tui-stack.c (tui_show_frame_info): Update.
4701         * tui/tui-source.c (tui_set_source_content)
4702         (tui_set_source_content_nil, tui_source_is_displayed)
4703         (tui_source_window::do_scroll_vertical): Update.
4704         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4705         (tui_display_registers_from, tui_display_reg_element_at_line)
4706         (tui_check_register_values, tui_reg_command): Update.
4707         * tui/tui-layout.c (tui_default_win_height)
4708         (show_source_disasm_command, show_data, init_and_make_win)
4709         (show_source_or_disasm_and_command): Update.
4710         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4711         (tui_redisplay_readline, tui_mld_flush)
4712         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4713         (tui_getc): Update.
4714         * tui/tui-disasm.c (tui_set_disassem_content)
4715         (tui_disasm_window::do_scroll_vertical): Update.
4716         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4717         Now virtual.
4718         (struct tui_win_info): Derive from tui_gen_win_info.
4719         <~tui_win_info>: Mark as override.
4720         <generic>: Remove member.
4721         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4722         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4723         (~tui_data_window, ~tui_win_info)
4724         (tui_free_all_source_wins_content): Update.
4725         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4726
4727 2019-06-25  Tom Tromey  <tom@tromey.com>
4728
4729         * tui/tui-layout.c (init_and_make_win): Use new.
4730         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4731         destructor, initializers.
4732         (tui_alloc_generic_win_info): Don't declare.
4733         * tui/tui-data.c (_locator): Add argument to constructor.
4734         (source_win, disasm_win): New globals.
4735         (exec_info): Remove.
4736         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4737         Update.
4738         (tui_alloc_generic_win_info): Remove.
4739         (init_content_element): Use new.
4740         (tui_win_info::tui_win_info): Update.
4741         (free_content_elements) <case DATA_WIN>: Use delete.
4742
4743 2019-06-25  Tom Tromey  <tom@tromey.com>
4744
4745         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4746         * tui/tui-windata.c (tui_first_data_item_displayed)
4747         (tui_delete_data_content_windows): Update.
4748         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4749         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4750         (tui_display_registers_from, tui_check_register_values): Update.
4751         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4752         pointer.
4753         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4754         window.
4755         (tui_free_data_content): Update.
4756         (free_content_elements) <case DATA_WIN>: Free the window.
4757
4758 2019-06-25  Tom Tromey  <tom@tromey.com>
4759
4760         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4761         Update.
4762         * tui/tui-layout.c (make_command_window)
4763         (show_source_disasm_command, show_data, init_and_make_win)
4764         (show_source_or_disasm_and_command): Update.
4765         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4766         method.
4767         <can_highight, is_highlighted>: Now bool.
4768         (tui_set_win_highlight): Don't declare.
4769         * tui/tui-data.c (tui_set_win_highlight): Remove.
4770
4771 2019-06-25  Tom Tromey  <tom@tromey.com>
4772
4773         * tui/tui-wingeneral.c (make_visible): Remove check of window
4774         type.
4775
4776 2019-06-25  Tom Tromey  <tom@tromey.com>
4777
4778         * tui/tui-win.c (tui_win_info::max_height)
4779         (tui_cmd_window::max_height): New methods.
4780         (new_height_ok): Call max_height.
4781         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4782         <max_height>: New method.
4783
4784 2019-06-25  Tom Tromey  <tom@tromey.com>
4785
4786         * tui/tui-win.c (tui_source_window_base::set_new_height)
4787         (tui_data_window::set_new_height): New methods.
4788         (make_invisible_and_set_new_height): Call set_new_height method.
4789         * tui/tui-data.h (struct tui_win_info)
4790         (struct tui_source_window_base, struct tui_data_window)
4791         <set_new_height>: New method.
4792
4793 2019-06-25  Tom Tromey  <tom@tromey.com>
4794
4795         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4796         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4797         tui_refresh_data_win.
4798         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4799         method.
4800         (tui_refresh_all_win): Call the refresh_all method.
4801         (tui_set_focus): Likewise.
4802         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4803         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4804         Likewise.
4805
4806 2019-06-25  Tom Tromey  <tom@tromey.com>
4807
4808         * tui/tui-winsource.h (tui_refill_source_window)
4809         (tui_set_is_exec_point_at): Don't declare.
4810         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4811         (tui_source_window_base::refill): Rename from
4812         tui_refill_source_window.
4813         (tui_source_window_base::do_scroll_horizontal): Update.
4814         (tui_source_window_base::set_is_exec_point_at): Rename from
4815         tui_set_is_exec_point_at.
4816         (tui_update_all_breakpoint_info): Update.
4817         * tui/tui-stack.c (tui_show_frame_info): Update.
4818         * tui/tui-layout.c (show_data): Add cast.
4819         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4820         * tui/tui-data.h (struct tui_source_window_base) <refill,
4821         set_is_exec_point_at>: New methods.
4822         (tui_source_windows, tui_add_to_source_windows): Update types.
4823         (tui_add_to_source_windows): Remove redundant declaration.
4824         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4825         (tui_source_windows): Change return type.
4826         (tui_clear_source_windows_detail): Update.
4827         (tui_add_to_source_windows): Change type of parameter.
4828         (tui_free_all_source_wins_content): Update.
4829
4830 2019-06-25  Tom Tromey  <tom@tromey.com>
4831
4832         * tui/tui-wingeneral.c (tui_win_info::refresh)
4833         (tui_source_window_base::refresh): New methods.
4834         (tui_refresh_all): Call the refresh method.
4835         * tui/tui-data.h (struct tui_win_info)
4836         (struct tui_source_window_base) <refresh>: New method.
4837
4838 2019-06-25  Tom Tromey  <tom@tromey.com>
4839
4840         * tui/tui.h (tui_is_window_visible): Return bool.
4841         * tui/tui.c (tui_is_window_visible): Return bool.
4842         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4843         (tui_make_visible, tui_make_invisible)
4844         (tui_win_info::make_visible)
4845         (tui_source_window_base::make_visible, make_all_visible)
4846         (tui_make_all_visible, tui_make_all_invisible): Update.
4847         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4848         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4849         bool.
4850         (struct tui_win_info, struct tui_source_window_base)
4851         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4852         * tui/tui-data.c (tui_init_generic_part): Update.
4853
4854 2019-06-25  Tom Tromey  <tom@tromey.com>
4855
4856         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4857         (tui_source_window_base::make_visible): New methods.
4858         (make_all_visible): Make method call.
4859         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4860         (struct tui_source_window_base, struct tui_cmd_window): Override
4861         make_visible.
4862         (tui_win_is_source_type): Don't declare.
4863         * tui/tui-data.c (tui_win_is_source_type): Remove.
4864
4865 2019-06-25  Tom Tromey  <tom@tromey.com>
4866
4867         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4868         NULL check.
4869
4870 2019-06-25  Tom Tromey  <tom@tromey.com>
4871
4872         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4873         Inline constructor.  Add initializers for members.
4874         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4875         constructors; now inline in class.
4876
4877 2019-06-25  Tom Tromey  <tom@tromey.com>
4878
4879         * tui/tui-regs.c (tui_show_registers): Update.
4880         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4881         bool.
4882         * tui/tui-data.c (tui_data_window::clear_detail)
4883         (tui_data_window): Update.
4884
4885 2019-06-25  Tom Tromey  <tom@tromey.com>
4886
4887         * tui/tui-windata.c (tui_display_all_data)
4888         (tui_display_data_from_line, tui_display_data_from)
4889         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4890         Update.
4891         * tui/tui-regs.c (tui_last_regs_line_no)
4892         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4893         (tui_show_registers, tui_show_register_group)
4894         (tui_display_registers_from, tui_display_reg_element_at_line)
4895         (tui_display_registers_from_line, tui_check_register_values)
4896         (tui_reg_next, tui_reg_prev): Update.
4897         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4898         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4899         tui_data_window.
4900         (struct tui_win_info) <detail>: Remove.  Add new fields from
4901         tui_data_info.
4902         (TUI_DATA_WIN): Add cast.
4903         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4904         (~tui_data_window): Simplify.
4905
4906 2019-06-25  Tom Tromey  <tom@tromey.com>
4907
4908         * tui/tui-layout.c (show_source_disasm_command)
4909         (show_source_or_disasm_and_command): Update.
4910         * tui/tui-io.c (update_cmdwin_start_line)
4911         (tui_redisplay_readline): Update.
4912         * tui/tui-data.h (struct tui_command_info): Remove.
4913         (struct tui_win_info) <detail>: Remove command_info member.
4914         (struct tui_data_window) <start_line>: New member, from
4915         tui_command_info.
4916         (TUI_CMD_WIN): Add casts.
4917
4918 2019-06-25  Tom Tromey  <tom@tromey.com>
4919
4920         * tui/tui-winsource.c (tui_update_source_window)
4921         (tui_refill_source_window)
4922         (tui_source_window_base::do_scroll_horizontal)
4923         (tui_update_breakpoint_info, tui_set_exec_info_content)
4924         (tui_show_exec_info_content, tui_erase_exec_info_content)
4925         (tui_clear_exec_info_content): Update.
4926         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4927         Update.
4928         * tui/tui-win.c (make_invisible_and_set_new_height)
4929         (make_visible_with_new_height): Update.
4930         * tui/tui-source.c (tui_set_source_content)
4931         (tui_show_symtab_source): Update.
4932         * tui/tui-layout.c (extract_display_start_addr)
4933         (show_source_disasm_command, show_data)
4934         (make_source_or_disasm_window)
4935         (show_source_or_disasm_and_command): Update.
4936         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4937         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4938         "gdbarch".
4939         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4940         to tui_source_window_base.
4941         (struct tui_win_info) <detail>: Remove source_info member.
4942         (struct tui_source_window_base) <has_locator>: Inline.
4943         Move contents from tui_source_info; rename has_locator member to
4944         m_has_locator.
4945         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4946         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4947         header file.
4948         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4949         Simplify.
4950         (tui_free_all_source_wins_content): Cast to
4951         tui_source_window_base.
4952
4953 2019-06-25  Tom Tromey  <tom@tromey.com>
4954
4955         * tui/tui-win.c (make_invisible_and_set_new_height)
4956         (make_visible_with_new_height): Call has_locator method.
4957         * tui/tui-layout.c (show_source_disasm_command, show_data)
4958         (show_source_or_disasm_and_command): Update for bool change.
4959         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4960         (tui_win_info) <has_locator>: New method.
4961         (struct tui_source_window_base) <has_locator>: New method.
4962         (tui_win_has_locator): Don't declare.
4963         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4964         from tui_win_has_locator.
4965         (tui_source_window_base): Use false, not FALSE.
4966
4967 2019-06-25  Tom Tromey  <tom@tromey.com>
4968
4969         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4970         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4971         clear_detail method directly.
4972         (tui_clear_win_detail): Remove.
4973
4974 2019-06-25  Tom Tromey  <tom@tromey.com>
4975
4976         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4977         "this", not TUI_DISASM_WIN.
4978
4979 2019-06-25  Tom Tromey  <tom@tromey.com>
4980
4981         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4982         declare.
4983         * tui/tui-winsource.c
4984         (tui_source_window_base::do_scroll_horizontal): Rename from
4985         tui_horizontal_source_scroll.
4986         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4987         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4988         from tui_vertical_data_scroll.
4989         * tui/tui-win.h (tui_scroll): Don't declare.
4990         * tui/tui-win.c (tui_win_info::forward_scroll)
4991         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4992         (tui_win_info::right_scroll): Rename and update.
4993         (tui_scroll_forward_command, tui_scroll_backward_command)
4994         (tui_scroll_left_command, tui_scroll_right_command): Update.
4995         (tui_scroll): Remove.
4996         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4997         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4998         from tui_vertical_source_scroll.
4999         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5000         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5001         from tui_vertical_disassem_scroll.
5002         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5003         do_scroll_horizontal>: New methods.
5004         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5005         Likewise.
5006         (struct tui_source_window_base): Add do_scroll_horizontal.
5007         (struct tui_source_window, struct tui_disasm_window): Add
5008         do_scroll_vertical.
5009         (struct tui_data_window, struct tui_cmd_window): Add
5010         do_scroll_horizontal and do_scroll_vertical.
5011         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5012
5013 2019-06-25  Tom Tromey  <tom@tromey.com>
5014
5015         * tui/tui-data.h (struct tui_source_window_base): New struct.
5016         (struct tui_source_window): Derive from tui_source_window_base.
5017         (struct tui_disasm_window): New struct.
5018         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5019         from tui_source_window::clear_detail.
5020         (tui_source_window_base): Rename from tui_source_window.
5021         (~tui_source_window_base): Rename from ~tui_source_window.
5022         (tui_alloc_win_info): Create a tui_disasm_window.
5023
5024 2019-06-25  Tom Tromey  <tom@tromey.com>
5025
5026         * tui/tui-data.h (struct tui_source_window)
5027         (struct tui_data_window): Declare destructors.
5028         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5029         destructors.
5030         (tui_win_info): Simplify.
5031
5032 2019-06-25  Tom Tromey  <tom@tromey.com>
5033
5034         * tui/tui-winsource.c (tui_display_main)
5035         (tui_update_source_windows_with_addr)
5036         (tui_update_all_breakpoint_info): Update.
5037         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5038         (new_height_ok, parse_scrolling_args): Update.
5039         * tui/tui-stack.c (tui_show_frame_info): Update.
5040         * tui/tui-data.h (struct tui_list): Remove.
5041         (tui_source_windows): Return a reference to a std::vector.
5042         * tui/tui-data.c (source_windows): Now a std::vector.
5043         (tui_source_windows): Change return type.
5044         (tui_clear_source_windows): Rewrite.
5045         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5046         (tui_free_all_source_wins_content): Rewrite.
5047
5048 2019-06-25  Tom Tromey  <tom@tromey.com>
5049
5050         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5051         (struct tui_data_window, struct tui_cmd_window): Declare
5052         clear_detail method.
5053         * tui/tui-data.c (tui_source_window::clear_detail)
5054         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5055         methods.
5056         (tui_clear_win_detail): Simplify.
5057
5058 2019-06-25  Tom Tromey  <tom@tromey.com>
5059
5060         * tui/tui-layout.c (make_source_window, make_disasm_window)
5061         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5062         Return the new window.
5063         (show_source_disasm_command, show_data)
5064         (show_source_or_disasm_and_command): Update.
5065
5066 2019-06-25  Tom Tromey  <tom@tromey.com>
5067
5068         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5069         parameter.  Return the new window.
5070         (show_source_disasm_command): Update and remove NULL check.
5071         (show_source_or_disasm_and_command): Update.
5072
5073 2019-06-25  Tom Tromey  <tom@tromey.com>
5074
5075         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5076
5077 2019-06-25  Tom Tromey  <tom@tromey.com>
5078
5079         * tui/tui-data.h (struct tui_win_info): Make constructor
5080         protected.  Make destructor virtual.  Add initializers.
5081         (tui_source_window, tui_data_window, tui_cmd_window): New
5082         classes.
5083         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5084         constructor.  Add "type" parameter.
5085         (tui_source_window, tui_data_window, tui_cmd_window): New
5086         constructors.
5087         (tui_alloc_win_info): Instantiate the appropriate subclass.
5088
5089 2019-06-25  Tom Tromey  <tom@tromey.com>
5090
5091         * tui/tui-win.c (tui_resize_all): Use delete.
5092         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5093         destructor.
5094         (tui_free_window): Don't declare.
5095         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5096         Update.
5097
5098 2019-06-25  Tom Tromey  <tom@tromey.com>
5099
5100         * tui/tui-data.h (struct tui_win_info): Add constructor.
5101         * tui/tui-data.c (tui_alloc_win_info): Use new.
5102         (tui_free_window): Use delete.
5103
5104 2019-06-22  Tom Tromey  <tom@tromey.com>
5105
5106         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5107         declare.
5108         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5109
5110 2019-06-22  Tom Tromey  <tom@tromey.com>
5111
5112         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5113         declare.
5114         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5115
5116 2019-06-22  Tom de Vries  <tdevries@suse.de>
5117
5118         * dwarf2read.c (create_addrmap_from_aranges)
5119         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5120         instead of '%zu'.
5121
5122 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5123
5124         * dwarf2read.h (dwarf2_section_info_def): Remove.
5125         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5126         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5127         std::vector<dwarf2_section_info>.
5128         (struct dwo_file) <~dwo_file>: Remove.
5129         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5130         types field.
5131         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5132         (dwarf2_read_debug_names): Likewise.
5133         (create_debug_types_hash_table): Change parameter type to
5134         array_view, adjust code accordingly.
5135         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5136         (partial_die_info::fixup): Likewise.
5137         (determine_prefix): Likewise.
5138         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5139
5140 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5141
5142         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5143         gdb_bfd_ref_ptr.
5144         <~dwo_file>: Remove call to gdb_bfd_unref.
5145         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5146         gdb_bfd_ref_ptr::get.
5147
5148 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5149
5150         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5151         type to htab_up.
5152         * dwarf2read.c (struct dwo_file): Initialize fields.
5153         <~dwo_file>: New.
5154         (free_dwo_file): Remove, move content to ~dwo_file.
5155         (struct dwo_file_deleter): Remove.
5156         (dwo_file_up>: Remove custom deleter.
5157         (free_dwo_files): Remove.
5158         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5159         dwo_files.
5160         (process_skeletonless_type_units): Call unique_ptr::get.
5161         (allocate_dwo_file_hash_table): Add deleter to created hash
5162         table.  Change return type to htab_up.
5163         (lookup_dwo_file_slot): Don't memset dwo_file, call
5164         unique_ptr::get.
5165         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5166         (create_dwo_unit_in_dwp_v2): Likewise.
5167         (open_and_init_dwo_file): Likewise.
5168         (free_dwo_file_from_slot): Remove.
5169
5170 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5171
5172         * dwarf2read.h (struct dwarf2_section_info) <readin,
5173         is_virtual>: Change type to bool.
5174         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5175         true instead of 1.
5176
5177 2019-06-19  Tom Tromey  <tom@tromey.com>
5178
5179         * tui/tui-data.h (tui_init_content_element): Don't declare.
5180
5181 2019-06-19  Tom Tromey  <tom@tromey.com>
5182
5183         * tui/tui-data.h (tui_init_win_info): Don't declare.
5184
5185 2019-06-19  Tom de Vries  <tdevries@suse.de>
5186
5187         * dwarf2read.h (abstract_to_concrete): Change type to
5188         std::unordered_map<sect_offset, std::vector<sect_offset>,
5189         gdb::hash_enum<sect_offset>>.
5190
5191 2019-06-19  Tom Tromey  <tromey@adacore.com>
5192
5193         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5194         EVAL_AVOID_SIDE_EFFECTS specially.
5195
5196 2019-06-19  Tom Tromey  <tromey@adacore.com>
5197
5198         * source-cache.c (highlighter): New global.
5199         (source_cache::get_source_lines): Create a highlighter on demand.
5200
5201 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5202
5203         * defs.h (deprecated_interactive_hook): Delete declaration.
5204         * interps.c (clear_interpreter_hooks): Remove use of
5205         deprecated_interactive_hook.
5206         * top.c (deprecated_interactive_hook): Delete definition.
5207         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5208
5209 2019-06-18  Tom de Vries  <tdevries@suse.de>
5210
5211         PR gdb/24515
5212         * dwarf2read.h (abstract_to_concrete): Change type from
5213         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5214         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5215         * dwarf2read.c (read_variable): Update.
5216         (dwarf2_fetch_die_loc_sect_off): Update.
5217
5218 2019-06-17  Tom de Vries  <tdevries@suse.de>
5219
5220         PR gdb/24617
5221         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5222         accessing parent[parent_len - 1].
5223
5224 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5225
5226         PR gdb/24364
5227         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5228         call dtrace_process_dof with NULL dof.
5229
5230 2019-06-16  Tom de Vries  <tdevries@suse.de>
5231
5232         PR gdb/24445
5233         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5234
5235 2019-06-16  Tom Tromey  <tom@tromey.com>
5236
5237         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5238         (make_all_visible): Use address of member.
5239
5240 2019-06-16  Tom Tromey  <tom@tromey.com>
5241
5242         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5243         (tui_free_window, free_content, free_content_elements): Remove
5244         unnecessary cast.
5245         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5246         cast.
5247         * tui/tui-regs.c (tui_show_register_group)
5248         (tui_display_registers_from, tui_display_reg_element_at_line):
5249         Remove unnecessary cast.
5250
5251 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5252
5253         * linux-nat.c (normal_mask): Delete.
5254         (_initialize_linux_nat): Don't initialise normal_mask.
5255
5256 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5257
5258         PR gdb/24445
5259         * dwarf-index-write.h (write_psymtabs_to_index): Add
5260         dwz_basename parameter.
5261         * dwarf-index-write.c (write_gdbindex): Move file writing to
5262         write_gdbindex_1.  Change return type void.
5263         (assert_file_size): Move up, remove filename parameter.
5264         (write_gdbindex_1): New function.
5265         (write_debug_names): Change return type to void, call
5266         assert_file_size.
5267         (struct index_wip_file): New struct.
5268         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5269         file logic to index_wip_file.  Write index for dwz file if
5270         needed.
5271         (save_gdb_index_command): Pass basename of dwz file, if present.
5272         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5273         build-id of dwz file, if present.
5274         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5275         (dwarf2_get_dwz_file): Likewise.
5276         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5277         (dwarf2_get_dwz_file): Likewise.
5278
5279 2019-06-16  Tom Tromey  <tom@tromey.com>
5280
5281         * coffread.c (process_coff_symbol): Use xstrdup.
5282         * value.c (create_internalvar): Use xstrdup.
5283
5284 2019-06-16  Tom Tromey  <tom@tromey.com>
5285
5286         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5287         * breakpoint.c (stopin_command, stopat_command)
5288         (until_break_command, decode_location_default): Remove unnecessary
5289         cast.
5290         * utils.c (subset_compare): Remove unnecessary cast.
5291         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5292         cast.
5293         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5294         cast.
5295         * infcmd.c (path_command): Remove unnecessary cast.
5296         * coffread.c (decode_type): Remove unnecessary cast.
5297         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5298         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5299         * tui/tui-stack.c (tui_show_locator_content)
5300         (tui_show_frame_info): Remove unnecessary cast.
5301         * tui/tui-win.c (tui_scroll_forward_command)
5302         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5303         (parse_scrolling_args): Remove unnecessary cast.
5304         * tui/tui-data.c (init_win_info, tui_del_window)
5305         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5306         (free_content_elements): Remove unnecessary cast.
5307         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5308         unnecessary cast.
5309         * tui/tui-source.c (tui_set_source_content)
5310         (tui_vertical_source_scroll): Remove unnecessary cast.
5311         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5312         cast.
5313         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5314         * tui/tui-regs.c (tui_display_registers_from)
5315         (tui_display_register): Remove unnecessary cast.
5316         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5317         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5318         (make_visible): Remove unnecessary cast.
5319         * tui/tui-winsource.c (tui_erase_source_content)
5320         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5321         unnecessary cast.
5322         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5323         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5324         * stabsread.c (read_type, read_array_type, read_range_type):
5325         Remove unnecessary cast.
5326         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5327         (parse_symbol, parse_type, upgrade_type, parse_external)
5328         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5329         unnecessary cast.
5330         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5331
5332 2019-06-16  Tom Tromey  <tom@tromey.com>
5333
5334         * tui/tui-data.c (tui_alloc_generic_win_info)
5335         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5336         checks.
5337
5338 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5339             Andrew Burgess  <andrew.burgess@embecosm.com>
5340
5341         * f-typeprint.c (f_print_type): Don't return early for not
5342         associated or not allocated types.
5343         (f_type_print_varspec_suffix): Add print_rank parameter and print
5344         ranks of array types in case they dangling.
5345         (f_type_print_base): Add print_rank parameter.
5346
5347 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5348
5349         * NEWS: Mention new MI commands.
5350         * break-catch-throw.c (enum exception_event_kind): Move to
5351         breakpoint.h.
5352         (print_mention_exception_catchpoint): Output text as a single
5353         message.
5354         (catch_exception_command_1): Rename to...
5355         (catch_exception_event): ...this, make non-static, update header
5356         command, and change some parameter types.
5357         (catch_catch_command): Update for changes to
5358         catch_exception_command_1.
5359         (catch_throw_command): Likewise.
5360         (catch_rethrow_command): Likewise.
5361         * breakpoint.c (enum exception_event_kind): Delete.
5362         * breakpoint.h (enum exception_event_kind): Moved here from
5363         break-catch-throw.c.
5364         (catch_exception_event): Declare.
5365         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5366         (mi_cmd_catch_throw): New function.
5367         (mi_cmd_catch_rethrow): New function.
5368         (mi_cmd_catch_catch): New function.
5369         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5370         'catch-catch' entries.
5371         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5372         (mi_cmd_catch_rethrow): Declare.
5373         (mi_cmd_catch_catch): Declare.
5374
5375 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5376
5377         * annotate.c (annotate_source_line): Change return type to void,
5378         update implementation to match.
5379         * annotate.h (annotate_source_line): Change return type to void,
5380         update header comment.
5381         * stack.c (print_frame_info): Don't change what frame information
5382         is printed based on whether annotations are on or not.
5383
5384 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5385
5386         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5387         (annotate_source): Make static.
5388         (annotate_source_line): Moved from source.c and renamed from
5389         identify_source_line.  Update the return type.
5390         * annotate.h (annotate_source): Delete declaration.
5391         (annotate_source_line): Declaration moved from source.h, and
5392         renamed from identify_source_line.  Return type updated.
5393         * source.c (identify_source_line): Moved to annotate.c and renamed
5394         to annotate_source_line.
5395         (info_line_command): Remove check of annotation_level.
5396         * source.h (identify_source_line): Move declaration to annotate.h
5397         and rename to annotate_source_line.
5398         * stack.c: Add 'annotate.h' include.
5399         (print_frame_info): Remove check of annotation_level before
5400         calling annotate_source_line.
5401
5402 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5403
5404         * source-cache.c (source_cache::get_plain_source_lines): Use
5405         open_source_file_with_line_charpos instead of just
5406         open_source_file, remove call to find_source_lines.
5407         (source_cache::get_source_lines): Likewise.
5408         * source.c (find_source_lines): Make static.
5409         (get_filename_and_charpos): Renamed into...
5410         (open_source_file_with_line_charpos): ..this along with changes to
5411         return a scoped_fd, and some other minor clean ups.
5412         (identify_source_line): Use open_source_file_with_line_charpos.
5413         (search_command_helper): Use open_source_file_with_line_charpos
5414         instead of just open_source_file, remove call to
5415         find_source_lines.
5416         * source.h (open_source_file_with_line_charpos): Declare new
5417         function.
5418         (find_source_lines): Delete declaration.
5419
5420 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5421
5422         * source.c (get_filename_and_charpos): Remove fullname
5423         parameter.
5424         (identify_source_line): Update call to get_filename_and_charpos.
5425
5426 2019-06-14  Tom Tromey  <tromey@adacore.com>
5427
5428         PR gdb/24502:
5429         * ui-style.h (skip_ansi_escape): Update comment.
5430         * ui-file.h (class no_terminal_escape_file): New class.
5431         * ui-file.c (no_terminal_escape_file::write)
5432         (no_terminal_escape_file::puts): New methods.
5433         * cli/cli-logging.c (handle_redirections): Use
5434         no_terminal_escape_file.
5435
5436 2019-06-14  Tom Tromey  <tromey@adacore.com>
5437
5438         * NEWS: Move convenience variable news above Python news.
5439
5440 2019-06-14  Tom Tromey  <tom@tromey.com>
5441
5442         * gnulib: Move directory to top-level.
5443         * configure.ac: Don't configure gnulib.
5444         * configure: Rebuild.
5445         * common/common-defs.h: Use new path to gnulib.
5446         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5447         (GNULIB_H): Remove.
5448         (INCGNU): Look in new gnulib location.
5449         (HFILES_NO_SRCDIR): Remove gnulib files.
5450         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5451         (generated_files): Remove GNULIB_H.
5452         ($(LIBGNU), all-lib): Remove targets.
5453         (distclean): Don't mention GNULIB_BUILDDIR.
5454         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5455
5456 2019-06-14  Tom Tromey  <tromey@adacore.com>
5457
5458         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5459         Warn if symbol file does not provide any symbols.
5460
5461 2019-06-14  Tom Tromey  <tromey@adacore.com>
5462
5463         * source.c (find_and_open_source): Respect basenames_may_differ.
5464
5465 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5466
5467         * annotate.c (annotate_breakpoints_invalid): Make use of
5468         scoped_restore_terminal_state.
5469         (annotate_frames_invalid): Likewise.
5470
5471 2019-06-14  Tom Tromey  <tromey@adacore.com>
5472
5473         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5474         allow assignment to an internalvar.
5475
5476 2019-06-14  Tom Tromey  <tromey@adacore.com>
5477
5478         * ada-lex.l: Allow "_" in attribute names.
5479
5480 2019-06-14  Tom Tromey  <tromey@adacore.com>
5481
5482         PR gdb/24653:
5483         * regcache.c (registers_changed): Don't call alloca.
5484         * top.c (execute_command): Don't call alloca.
5485
5486 2019-06-13  Pedro Alves  <palves@redhat.com>
5487
5488         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5489         'expression'.  When parsing an expression, error out if there's
5490         junk after "unlimited".
5491         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5492         (do_set_command): Adjust calls to is_unlimited_literal.
5493
5494 2019-06-13  Pedro Alves  <palves@redhat.com>
5495
5496         * compile/compile.c (make_compile_options_def_group): Add braces
5497         around array_view initializer.
5498         * thread.c (make_thread_apply_all_options_def_group)
5499         (make_thread_apply_all_options_def_group): Likewise.
5500
5501 2019-06-13  Pedro Alves  <palves@redhat.com>
5502
5503         * NEWS (New commands): Mention "maint test-options
5504         require-delimiter", "maint test-options unknown-is-error", "maint
5505         test-options unknown-is-operand" and "maint show
5506         test-options-completion-result".
5507         (New command options, command completion): New section.
5508         (Completion improvements): New section.
5509         Mention that you can abbreviate "unlimited".
5510
5511 2019-06-13  Pedro Alves  <palves@redhat.com>
5512
5513         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5514         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5515         * unittests/cli-utils-selftests.c (test_parse_flags)
5516         (test_parse_flags_qcs): Delete.
5517         (test_cli_utils): Don't call deleted functions.
5518
5519 2019-06-13  Pedro Alves  <palves@redhat.com>
5520
5521         * thread.c: Include "cli/cli-option.h".
5522         (tp_array_compar_ascending): Global.
5523         (tp_array_compar): Delete function.
5524         (tp_array_compar_ascending, tp_array_compar_descending): New
5525         functions.
5526         (ascending_option_def, qcs_flag_option_def)
5527         (thr_qcs_flags_option_defs)
5528         (make_thread_apply_all_options_def_group)
5529         (make_thread_apply_options_def_group): New.
5530         (thread_apply_all_command): Use gdb::option::process_options.
5531         (thread_apply_command_completer)
5532         (thread_apply_all_command_completer): New.
5533         (thread_apply_command): Use gdb::option::process_options.
5534         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5535         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5536         to generate help text of "thread apply".  Adjust "taas"'s help.
5537         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5538         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5539
5540 2019-06-13  Pedro Alves  <palves@redhat.com>
5541
5542         * thread.c (thread_apply_command): Check for invalid TID with
5543         isdigit instead of !isalpha.
5544
5545 2019-06-13  Pedro Alves  <palves@redhat.com>
5546
5547         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5548         (validate_flags_qcs): New.
5549         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5550         (validate_flags_qcs): Declare.
5551         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5552         (make_frame_apply_options_def_group): New.
5553         (frame_apply_command_count): Process options with
5554         gdb::option::process_options.
5555         (frame_apply_completer): New.
5556         (frame_apply_level_completer, frame_apply_all_completer)
5557         (frame_apply_completer): New.
5558         (_initialize_stack): Update help of "frame apply", "frame apply
5559         level", "frame apply all" and "faas" to mention supported options
5560         and install command completers.
5561         * stack.h (frame_apply_all_completer): Declare.
5562         * thread.c: Include "stack.h".
5563         (tfaas_command): Add "--".
5564         (_initialize_thread): Update help "tfaas" to mention supported
5565         options and install command completer.
5566
5567 2019-06-13  Pedro Alves  <palves@redhat.com>
5568
5569         * completer.c (complete_nested_command_line): New.
5570         (gdb_completion_word_break_characters_throw): Add assertion.
5571         * completer.h (complete_nested_command_line): Declare.
5572
5573 2019-06-13  Pedro Alves  <palves@redhat.com>
5574
5575         * stack.c (parse_backtrace_qualifiers): New.
5576         (backtrace_command): Use it.
5577         (backtrace_command_completer): Complete on qualifiers.
5578
5579 2019-06-13  Pedro Alves  <palves@redhat.com>
5580
5581         * frame.c: Include "cli/cli-option.h.
5582         (user_set_backtrace_options): New.
5583         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5584         Delete.
5585         (get_prev_frame): Adjust.
5586         (boolean_option_def, uinteger_option_def)
5587         (set_backtrace_option_defs): New.
5588         (_initialize_frame): Adjust and use
5589         gdb::option::add_setshow_cmds_for_options to install "set
5590         backtrace past-main" and "set backtrace past-entry".
5591         * frame.h: Include "cli/cli-option.h".
5592         (struct frame_print_options): Forward declare.
5593         (print_frame_arguments_all, print_frame_arguments_scalars)
5594         (print_frame_arguments_none): Declare.
5595         (print_entry_values): Delete declaration.
5596         (struct frame_print_options, user_frame_print_options): New.
5597         (struct set_backtrace_options): New.
5598         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5599         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5600         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5601         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5602         (list_args_or_locals): Add frame_print_options parameter.
5603         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5604         * python/py-framefilter.c (enumerate_args): Pass down
5605         USER_FRAME_PRINT_OPTIONS.
5606         * stack.c: Include "cli/cli-option.h".
5607         (print_frame_arguments_all, print_frame_arguments_scalars)
5608         (print_frame_arguments_none): Declare.
5609         (print_raw_frame_arguments, print_entry_values): Delete.
5610         (user_frame_print_options): New.
5611         (boolean_option_def, enum_option_def, frame_print_option_defs):
5612         New.
5613         (struct backtrace_cmd_options): New.
5614         (bt_flag_option_def): New.
5615         (backtrace_command_option_defs): New.
5616         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5617         (print_frame_arg, read_frame_arg, print_frame_args)
5618         (print_frame_info, print_frame): Add frame_print_options parameter
5619         and use it.
5620         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5621         (backtrace_command_1): Add frame_print_options and
5622         backtrace_cmd_options parameters and use them.
5623         (make_backtrace_options_def_group): New.
5624         (backtrace_command): Process command options with
5625         gdb::option::process_options.
5626         (backtrace_command_completer): New.
5627         (_initialize_stack): Extend "backtrace"'s help to mention
5628         supported options.  Install completer for "backtrace".
5629         Install some settings commands with add_setshow_cmds_for_options.
5630
5631 2019-06-13  Pedro Alves  <palves@redhat.com>
5632
5633         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5634         and that "set/show print raw frame-arguments" are now deprecated.
5635
5636         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5637         command.
5638         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5639         * stack.c (_initialize_stack): Install "set/show print
5640         raw-frame-arguments", and deprecate "set/show print raw
5641         frame-arguments".
5642         * valprint.c (_initialize_valprint): Deprecate "set/show print
5643         raw".
5644
5645 2019-06-13  Pedro Alves  <palves@redhat.com>
5646
5647         * compile/compile.c (struct compile_options): New.
5648         (compile_flag_option_def, compile_command_option_defs)
5649         (make_compile_options_def_group): New.
5650         (compile_file_command): Handle options with
5651         gdb::option::process_options.
5652         (compile_file_command_completer): New function.
5653         (compile_code_command): Handle options with
5654         gdb::option::process_options.
5655         (compile_code_command_completer): New function.
5656         (_initialize_compiler): Install completers for "compile code" and
5657         "compile file".  Mention available options in "compile code" and
5658         "compile code"'s help.
5659         * completer.c (advance_to_completion_word): New, factored out from
5660         ...
5661         (advance_to_expression_complete_word_point): ... this.
5662         (advance_to_filename_complete_word_point): New.
5663         * completer.h (advance_to_filename_complete_word_point): New
5664         declaration.
5665
5666 2019-06-13  Pedro Alves  <palves@redhat.com>
5667
5668         * compile/compile.c: Include "cli/cli-option.h".
5669         (compile_print_value): Scope data pointer is now a
5670         value_print_options pointer; adjust.
5671         (compile_print_command): Process options.  Scope data pointer is
5672         now a value_print_options pointer; adjust.
5673         (_initialize_compile): Update "compile print"'s help to include
5674         supported options.  Install a completer for "compile print".
5675         * cp-valprint.c (show_vtblprint, show_objectprint)
5676         (show_static_field_print): Delete.
5677         (_initialize_cp_valprint): Don't install "set print
5678         static-members", "set print vtbl", "set print object" here.
5679         * printcmd.c: Include "cli/cli-option.h" and
5680         "common/gdb_optional.h".
5681         (print_command_parse_format): Rework to fill in a
5682         value_print_options instead of a format_data.
5683         (print_value): Change parameter type from format_data pointer to
5684         value_print_options reference.  Adjust.
5685         (print_command_1): Process options.  Adjust to pass down a
5686         value_print_options.
5687         (print_command_completer): New.
5688         (_initialize_printcmd): Install print_command_completer as
5689         handle_brkchars completer for the "print" command.  Update
5690         "print"'s help to include supported options.
5691         * valprint.c: Include "cli/cli-option.h".
5692         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5693         here from cp-valprint.c.
5694         (boolean_option_def, uinteger_option_def)
5695         (value_print_option_defs, make_value_print_options_def_group):
5696         New.  Use gdb::option::add_setshow_cmds_for_options to install
5697         "set print elements", "set print null-stop", "set print repeats",
5698         "set print pretty", "set print union", "set print array", "set
5699         print address", "set print symbol", "set print array-indexes".
5700         * valprint.h: Include <string> and "cli/cli-option.h".
5701         (make_value_print_options_def_group): Declare.
5702         (print_value): Change parameter type from format_data pointer to
5703         value_print_options reference.
5704         (print_command_completer): Declare.
5705
5706 2019-06-13  Pedro Alves  <palves@redhat.com>
5707
5708         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5709         (COMMON_SFILES): Add maint-test-settings.c.
5710         * cli/cli-decode.c (boolean_enums): New global, factored out from
5711         ...
5712         (add_setshow_boolean_cmd): ... here.
5713         * cli/cli-decode.h (boolean_enums): Declare.
5714         * cli/cli-option.c: New file.
5715         * cli/cli-option.h: New file.
5716         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5717         factored out from ...
5718         (parse_cli_boolean_value(const char *)): ... this.
5719         (is_unlimited_literal): Change parameter type to pointer to
5720         pointer.  Adjust and advance ARG pointer.
5721         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5722         (parse_cli_var_enum): New, factored out from ...
5723         (do_set_command): ... this.  Adjust.
5724         * cli/cli-setshow.h (parse_cli_boolean_value)
5725         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5726         (parse_cli_var_enum): Declare.
5727         * cli/cli-utils.c: Include "cli/cli-option.h".
5728         (get_ulongest): New.
5729         * cli/cli-utils.h (get_ulongest): Declare.
5730         (check_for_argument): New overloads.
5731         * maint-test-options.c: New file.
5732
5733 2019-06-13  Pedro Alves  <palves@redhat.com>
5734
5735         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5736         parse a range if "-" is at the end of the string.
5737
5738 2019-06-13  Pedro Alves  <palves@redhat.com>
5739
5740         * cli/cli-setshow.c (parse_auto_binary_operation)
5741         (parse_cli_boolean_value): Don't allow "o".
5742
5743 2019-06-13  Pedro Alves  <palves@redhat.com>
5744
5745         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5746         * NEWS: Mention maint test-settings KIND.
5747         * maint-test-settings.c: New file.
5748
5749 2019-06-13  Pedro Alves  <palves@redhat.com>
5750
5751         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5752         completer.
5753         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5754         "set" completers.
5755
5756 2019-06-13  Pedro Alves  <palves@redhat.com>
5757
5758         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5759         after item.
5760
5761 2019-06-13  Pedro Alves  <palves@redhat.com>
5762
5763         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5764
5765 2019-06-13  Pedro Alves <palves@redhat.com>
5766
5767         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5768         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5769         call.
5770         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5771         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5772         calls.
5773         (check_for_argument): Skip spaces after argument.
5774
5775 2019-06-13  Pedro Alves  <palves@redhat.com>
5776
5777         * thread.c (thread_apply_command): Adjust TID parsing.
5778         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5779         detected before end of string.
5780         (tid_is_in_list): Error out if LIST is invalid.
5781
5782 2019-06-13  Pedro Alves  <palves@redhat.com>
5783
5784         * completer.c (complete_line_internal_1): Rewind completion word
5785         point.
5786         (completion_tracker::advance_custom_word_point_by): Change
5787         parameter type to int.
5788         * completer.h (completion_tracker::advance_custom_word_point_by):
5789         Likewise.
5790
5791 2019-06-13  Pedro Alves  <palves@redhat.com>
5792
5793         * completer.c (advance_to_completion_word): Handle delimiters.
5794
5795 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5796
5797         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5798
5799 2019-06-11  Tom Tromey  <tom@tromey.com>
5800
5801         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5802         (xmalloc_failed): Move to alloc.c.
5803         * alloc.c: New file.
5804         * Makefile.in (COMMON_SFILES): Add alloc.c.
5805
5806 2019-06-11  Tom Tromey  <tom@tromey.com>
5807
5808         * nat/linux-waitpid.c: Don't include server.h.
5809         (linux_debug): Remove.
5810         (my_waitpid): Update.
5811
5812 2019-06-11  Tom Tromey  <tromey@adacore.com>
5813
5814         * infcall.c (_initialize_infcall): Remove trailing newline from
5815         help.
5816         * user-regs.c (_initialize_user_regs): Remove trailing newline
5817         from help.
5818         * typeprint.c (_initialize_typeprint): Remove trailing newline
5819         from help.
5820         * reverse.c (_initialize_reverse): Remove trailing newlines from
5821         help.
5822         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5823         from help.
5824         * language.c (add_set_language_command): Remove trailing newline
5825         from help.
5826         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5827         help.
5828         * disasm.c (_initialize_disasm): Remove trailing newline from
5829         help.
5830         * top.c (init_main): Remove trailing newline from help.
5831         * interps.c (_initialize_interpreter): Remove trailing newline
5832         from help.
5833         * btrace.c (_initialize_btrace): Remove trailing newlines from
5834         help.
5835         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5836         from help.
5837         * python/python.c (_initialize_python): Remove trailing newline
5838         from help.
5839         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5840         help.
5841         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5842         from help.  Reformat some text.
5843         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5844         from help.
5845         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5846         newline from help.
5847
5848 2019-06-11  Tom Tromey  <tromey@adacore.com>
5849
5850         * darwin-nat.c (darwin_decode_exception_message)
5851         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5852
5853 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5854
5855         * valops.c (value_slice): Check for not allocated or not
5856         associated values.
5857
5858 2019-06-10  Tom de Vries  <tdevries@suse.de>
5859
5860         PR gdb/24618
5861         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5862         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5863         invalid.
5864
5865 2019-06-10  Tom de Vries  <tdevries@suse.de>
5866
5867         PR gdb/24611
5868         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5869         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5870
5871 2019-06-10  Tom de Vries  <tdevries@suse.de>
5872
5873         PR symtab/24545
5874         * symtab.c (struct demangled_name_entry): Add language field.
5875         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5876         static minimal symbol".  Set and use language field.
5877
5878 2019-06-10  Tom Tromey  <tromey@adacore.com>
5879
5880         * ada-lang.c (_initialize_ada_language): Update help text.
5881
5882 2019-06-10  Tom Tromey  <tromey@adacore.com>
5883
5884         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5885         with a newline.
5886         * guile/guile.c (handle_boot_error): Don't end warning with a
5887         newline.
5888         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5889         warning with a newline.
5890         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5891         newline.
5892         (s12z_frame_cache): Likewise.
5893         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5894         a newline.
5895         * solib-svr4.c (disable_probes_interface): Don't end warning with
5896         a newline.
5897         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5898         newline.
5899         * python/python.c (do_finish_initialization): Don't end warning
5900         with a newline.
5901
5902 2019-06-10  Tom Tromey  <tom@tromey.com>
5903
5904         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5905         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5906         gdbpy_enter.
5907
5908 2019-06-10  Tom Tromey  <tromey@adacore.com>
5909
5910         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5911         data.
5912         (elf_new_init): Don't call stabsread_new_init.
5913         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5914         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5915         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5916
5917 2019-06-10  Tom de Vries  <tdevries@suse.de>
5918
5919         PR symtab/16264
5920         PR symtab/24517
5921         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5922
5923 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5924
5925         * source.c (find_and_open_source): Also rewrite relative file
5926         names.
5927
5928 2019-04-26  Amos Bird  <amosbird@gmail.com>
5929
5930         * annotate.c (annotate_thread_exited): Add "thread-exited"
5931         annotation.
5932
5933 2019-06-06  Tom Tromey  <tromey@adacore.com>
5934
5935         * maint.h (class scoped_command_stats): Use
5936         DISABLE_COPY_AND_ASSIGN.
5937         <print_time>: New method.
5938         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5939         print_time.
5940         (scoped_command_stats::print_time): New method.
5941
5942 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5943
5944         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5945         instructions of lengths 6 or 8 bytes.
5946
5947 2019-06-04  Pedro Alves  <palves@redhat.com>
5948
5949         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5950
5951         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5952         * breakpoint.c (condition_completer): Likewise.
5953         * cli/cli-dump.c (scan_expression): Likewise.
5954         * common/filestuff.c (mkdir_recursive): Likewise.
5955         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5956         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5957         (gdb_abspath): Likewise.
5958         * compile/compile-cplus-types.c
5959         (compile_cplus_instance::decl_name): Likewise.
5960         * completer.c (complete_explicit_location):
5961         (signal_completer, reg_or_group_completer_1): Likewise.
5962         * cp-support.c (cp_remove_params_if_any): Likewise.
5963         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5964         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5965         * infcmd.c (strip_bg_char): Likewise.
5966         * linespec.c (copy_token_string): Likewise.
5967         * mi/mi-main.c (output_cores): Likewise.
5968         * psymtab.c (psymtab_search_name):
5969         * symfile.c (test_set_ext_lang_command): Likewise.
5970         * target.c (target_fileio_read_stralloc): Likewise.
5971         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5972         * value.c (complete_internalvar): Likewise.
5973
5974 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5975
5976         Add objfile property to gdb.Type.
5977         * NEWS: Mention Python API addition.
5978         * python/py-type.c (typy_get_objfile): New method.
5979
5980 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5981
5982         * NEWS: Mention the new set|show style [title|highlight].
5983         Mention changes to "show style", "help" and "apropos".
5984
5985 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5986
5987         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5988         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5989         instead of print_help_for_command.
5990         (print_doc_of_command): New function.
5991         (help_list): Add 'apropos -v word' suggestion.
5992         (print_help_for_command): Style the command name using title style.
5993         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5994         (_initialize_cli_cmds): Describe -v in apropos_command help.
5995
5996 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5997
5998         * cli/cli-style.h (cli_style_option): Add name in constructor,
5999         add m_name class member, add constructor with intensity,
6000         add name class function.
6001         (cli_style_option::add_setshow_commands): Remove name argument.
6002         (highlight_style, title_style): New styles.
6003         * cli/cli-style.c (do_show): New function that shows a style
6004         characteristic styling the style name with itself.
6005         (set_style_name): New function.
6006         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6007         Update all callers according to the changes in cli/cli-style.h.
6008         * utils.h (fputs_highlighted): New function.
6009         * utils.c (fputs_highlighted): Likewise.
6010
6011 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6012
6013         * NEWS: Mention new pipe command and new convenience variables.
6014
6015 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6016
6017         * cli/cli-cmds.c (pipe_command): New function.
6018         (_initialize_cli_cmds): Call add_com for pipe_command.
6019         Define | as an alias for pipe.
6020         (exit_status_set_internal_vars): New function.
6021         (shell_escape): Call exit_status_set_internal_vars.
6022         cli/cli-decode.c (find_command_name_length): Recognize | as
6023         a single character command.
6024
6025 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6026
6027         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6028         top.c (execute_command_to_ui_file): New function, mostly a copy
6029         of execute_command_to_string.
6030         (execute_command_to_string): Implement by calling
6031         execute_command_to_ui_file.
6032
6033 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6034
6035         * top.h (saved_command_line): Remove declaration.
6036         * top.c (previous_saved_command_line, previous_repeat_arguments):
6037         New variables.
6038         (saved_command_line): Make static, define together with other
6039         'repeat variables'.
6040         (dont_repeat): Clear repeat_arguments.
6041         (repeat_previous, get_saved_command_line, save_command_line):
6042         New functions.
6043         (gdb_init): Initialize saved_command_line
6044         and previous_saved_command_line.
6045         * main.c (captured_main_1): Remove saved_command_line initialization.
6046         * event-top.c (handle_line_of_input): Update to use
6047         the new 'repeat' related functions instead of direct access to
6048         saved_command_line.
6049         * command.h (repeat_previous, get_saved_command_line,
6050         save_command_line): New declarations.
6051         (dont_repeat): Add comment.
6052
6053 2019-05-30  Tom Tromey  <tromey@adacore.com>
6054
6055         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6056         Fix comment.
6057         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6058
6059 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6060
6061         PR cli/24587
6062         * completer.c (complete): Initialize variable word.
6063
6064 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6065
6066         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6067         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6068         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6069         'body' is NULL to the outter 'if', protecting the '!is_define'
6070         situation as well.
6071
6072 2019-05-29  Tom Tromey  <tromey@adacore.com>
6073
6074         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6075         (dwarf_unknown): New function.
6076         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6077         (dwarf_type_encoding_name): Use dwarf_unknown.
6078
6079 2019-05-29  Tom Tromey  <tromey@adacore.com>
6080
6081         PR c++/20020:
6082         * cp-valprint.c (cp_print_value_fields): Call
6083         cp_print_static_field inside "try".
6084
6085 2019-05-29  Tom Tromey  <tromey@adacore.com>
6086
6087         * inflow.c (struct terminal_info): Add default operator=.
6088         * configure: Rebuild.
6089         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6090         -Wdeprecated-copy-dtor, -Wredundant-move.
6091
6092 2019-05-29  Tom Tromey  <tromey@adacore.com>
6093
6094         * NEWS: Add entry.
6095         * infcmd.c (print_return_value_1): Handle finish_print
6096         option.
6097         (show_print_finish): New function.
6098         (_initialize_infcmd): Add "set/show print finish" commands.
6099         * valprint.c (user_print_options): Initialize new member.
6100         * valprint.h (struct value_print_options) <finish_print>: New
6101         member.
6102
6103 2019-05-28  Tom Tromey  <tromey@adacore.com>
6104
6105         * ada-lang.c (ada_remove_Xbn_suffix)
6106         (find_old_style_renaming_symbol)
6107         (parse_old_style_renaming): Remove.
6108         (ada_find_renaming_symbol): Don't call
6109         find_old_style_renaming_symbol.
6110         (ada_is_renaming_symbol): Rename from
6111         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6112         bool.  Now static.
6113         (ada_read_var_value): Update and simplify.
6114         * ada-exp.y (write_var_or_type): Remove old code.
6115
6116 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6117
6118         * event-top.c: Remove include comment.
6119         * inflow.c (class scoped_ignore_sigttou): Move from here...
6120         * inflow.h (class scoped_ignore_sigttou): ...to here.
6121         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6122         * top.c:  Remove include comment.
6123
6124 2019-05-27  Tom Tromey  <tom@tromey.com>
6125
6126         * NEWS: Fix typo.
6127
6128 2019-05-22  Tom Tromey  <tromey@adacore.com>
6129
6130         * target.c (target_follow_exec): Constify parameter.
6131         * target-delegates.c: Rebuild.
6132         * remote.c (remote_target::follow_exec): Constify parameter.
6133         * infrun.c (follow_exec): Constify parameter.
6134         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6135         (target_follow_exec): Likewise.
6136
6137 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6138
6139         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6140         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6141
6142 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6143
6144         * NEWS: Add debugredirect and testsuite sections.
6145
6146 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6147
6148         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6149         target descriptions using exclusively floating point register name
6150         aliases.
6151
6152 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6153
6154         PR gdb/18644:
6155         * f-lang.c (build_fortran_types): Handle the case where
6156         gdbarch_floatformat_for_type returns a nullptr.
6157
6158 2019-05-21  Tom de Vries  <tdevries@suse.de>
6159
6160         PR cli/24587
6161         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6162
6163 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6164
6165         PR gdb/18644:
6166         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6167         16-byte floats.
6168         * i386-tdep.c (i386_floatformat_for_type): Use
6169         floatformats_ia64_quad for the 16-byte floating point component
6170         within a fortran 32-byte complex number.
6171
6172 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6173
6174         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6175         delete default constructor.
6176         (find_partial_die): Update to return const struct.
6177         (partial_die_parent_scope): Move variable declaration into scope
6178         of its use and change its type to auto.
6179         (guess_partial_die_structure_name): Likewise.
6180         (partial_die_info::fixup): Likewise.
6181
6182 2019-05-17  Tom Tromey  <tromey@adacore.com>
6183
6184         * source.c (find_and_open_source): Remove cast.
6185
6186 2019-05-17  Tom Tromey  <tromey@adacore.com>
6187
6188         * annotate.c (annotate_source): Make "filename" const.
6189         * annotate.h (annotate_source): Use const.
6190
6191 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6192
6193         * disasm.c (set_disassembler_options): Send errors to stderr.
6194
6195 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6196
6197         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6198         (cli_interp_base::set_logging): Check debug_redirect.
6199         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6200         * cli/cli-logging.c (debug_redirect): Add static variable.
6201         (pop_output_files): Add default param.
6202         (handle_redirections): Print debug setting.
6203         (show_logging_command): Likewise.
6204         (_initialize_cli_logging): Add debugredirect command.
6205         * interps.c (current_interp_set_logging): Add debug_redirect
6206         parameter.
6207         * interps.h (set_logging): Add debug_redirect parameter.
6208         (current_interp_set_logging): Likewise.
6209         * mi/mi-common.h: Likewise.
6210         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6211
6212 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6213             Tom Tromey  <tromey@adacore.com>
6214
6215         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6216         directly.
6217         * cli/cli-interp.h (make_logging_output): Remove declaration.
6218         * cli/cli-logging.c (make_logging_output): Remove function.
6219         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6220         directly.
6221         * ui-file.c (tee_file::tee_file): Remove bools.
6222         (tee_file::~tee_file): Remove deletes.
6223         * ui-file.h (tee_file): Remove bools.
6224
6225 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6226
6227         * mi/mi-cmds.h (mi_cmd_complete): New function.
6228         * mi/mi-main.c (mi_cmd_complete): Likewise.
6229         * mi/mi-cmds.c: Define new MI command -complete.
6230         * NEWS: Mention new -complete command.
6231
6232 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6233
6234         * completer.h (complete): New function.
6235         * completer.c (complete): Likewise.
6236         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6237         function defined in completer.h.
6238
6239 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6240
6241         * MAINTAINERS (Write After Approval): Add myself.
6242
6243 2019-05-17  Tom de Vries  <tdevries@suse.de>
6244
6245         PR gdb/24094
6246         * dwarf2read.c (struct cu_partial_die_info): New struct.
6247         (find_partial_die): Return cu_partial_die_info.
6248         (partial_die_parent_scope, guess_partial_die_structure_name)
6249         (partial_die_info::fixup): Handle new return type of find_partial_die.
6250
6251 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6252
6253         PR breakpoints/24541
6254         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6255         "std::string", simplifying the algorithm.
6256
6257 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6258
6259         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6260         (stap_static_probe_ops::get_probes): Likewise.
6261
6262 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6263
6264         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6265         '-')" and "else if".
6266         (stap_parse_single_operand): Join checks for
6267         "gdbarch_stap_parse_special_token_p" and
6268         "gdbarch_stap_parse_special_token" in the same "if" statement.
6269         Invert check when verifying for operation on register
6270         displacement.
6271
6272 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6273
6274         * stap-probe.c (stap_get_opcode): Update comment.
6275         (stap_get_expected_argument_type): Likewise.
6276         (handle_stap_probe): Likewise.
6277
6278 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6279
6280         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6281         return type to 'bool'.  Adjust comment.  Use 'bool' when
6282         appropriate.
6283         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6284         * stap-probe.c (stap_parse_argument_1): Likewise.
6285         (stap_is_operator): Likewise.
6286         (stap_is_generic_prefix): Likewise.
6287         (stap_is_register_prefix): Likewise.
6288         (stap_is_register_indirection_prefix): Likewise.
6289         (stap_is_integer_prefix): Likewise.
6290         (stap_generic_check_suffix): Likewise.
6291         (stap_check_integer_suffix): Likewise.
6292         (stap_check_register_suffix): Likewise.
6293         (stap_check_register_indirection_suffix): Likewise.
6294         (stap_parse_register_operand): Likewise.
6295         (stap_parse_single_operand): Likewise.
6296         (stap_parse_argument_1): Likewise.
6297         (stap_probe::get_argument_count): Likewise.
6298         (stap_is_operator): Likewise.
6299
6300 2019-05-16  Tom Tromey  <tromey@adacore.com>
6301
6302         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6303         keyword to foreach.
6304
6305 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6306
6307         * linux-thread-db.c (try_thread_db_load_1): Change return type
6308         to bool.
6309         (try_thread_db_load): Likewise.
6310         (try_thread_db_load_from_pdir_1): Likewise.
6311         (try_thread_db_load_from_pdir): Likewise.
6312         (try_thread_db_load_from_sdir): Likewise.
6313         (try_thread_db_load_from_dir): Likewise.
6314         (thread_db_load_search): Likewise.
6315         (has_libpthread): Likewise.
6316         (thread_db_load): Likewise.
6317
6318 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6319
6320         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6321         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6322         NULL, and complain/return if that's the case.
6323
6324 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6325
6326         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6327         (advance, posn, abstract_read_memory): New functions.
6328         [struct mem_read_abstraction]: New struct.
6329         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6330
6331 2019-05-14  Tom Tromey  <tromey@adacore.com>
6332
6333         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6334         value is not lval_memory.
6335
6336 2019-05-14  Tom Tromey  <tromey@adacore.com>
6337
6338         * solib.c (info_sharedlibrary_command): Style the file name.
6339
6340 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6341
6342         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6343         (aarch64_vnv_type): Likewise.
6344         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6345         * common/tdesc.c: Likewise.
6346         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6347         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6348         * features/aarch64-fpu.xml: Add ieee half view.
6349         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6350         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6351         * gdbtypes.h (struct builtin_type): Likewise.
6352         (struct objfile_type): Likewise.
6353
6354 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6355
6356         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6357         typo.
6358         * location.h (string_to_event_location): Likewise.
6359
6360 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6361
6362         GDB 8.3 released.
6363
6364 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6365
6366         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6367         New variable declaration.
6368         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6369         New variable.
6370         (print_one_breakpoint): Use ui_out::test_flags and new global
6371         variable to compute use_fixed_output.
6372         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6373         Remove.
6374         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6375         (mi_multi_location_breakpoint_output_fixed): Remove.
6376         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6377         new variable.
6378         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6379         fix_multi_location_breakpoint_output flag if version >= 3.
6380         * ui-out.h (enum ui_out_flag)
6381         <fix_multi_location_breakpoint_output>: New enumerator.
6382
6383 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6384
6385         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6386
6387 2019-05-10  Tom Tromey  <tromey@adacore.com>
6388
6389         * ada-lang.c (catch_ada_completer): New function.
6390         (_initialize_ada_language): Use it.
6391
6392 2019-05-10  Tom Tromey  <tromey@adacore.com>
6393
6394         * thread.c (print_thread_info): Make "requested_threads" const.
6395         * gdbthread.h (print_thread_info): Make "requested_threads"
6396         const.
6397         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6398         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6399
6400 2019-05-08  Tom Tromey  <tom@tromey.com>
6401
6402         * gdbtypes.c (objfile_type_data): Change type.
6403         (objfile_type, _initialize_gdbtypes): Update.
6404
6405 2019-05-08  Tom Tromey  <tom@tromey.com>
6406
6407         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6408         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6409         (_initialize_dwarf2_frame): Update.
6410
6411 2019-05-08  Tom Tromey  <tom@tromey.com>
6412
6413         * objc-lang.c (objc_objfile_data): Change type.
6414         (find_methods): Update.
6415         (_initialize_objc_lang): Remove.
6416
6417 2019-05-08  Tom Tromey  <tom@tromey.com>
6418
6419         * stabsread.c (rs6000_builtin_type_data): Change type.
6420         (rs6000_builtin_type, _initialize_stabsread): Update.
6421
6422 2019-05-08  Tom Tromey  <tom@tromey.com>
6423
6424         * mips-tdep.c (mips_pdr_data): Remove.
6425         (_initialize_mips_tdep): Update.
6426
6427 2019-05-08  Tom Tromey  <tom@tromey.com>
6428
6429         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6430         (hppa_init_objfile_priv_data, read_unwind_info)
6431         (find_unwind_entry, _initialize_hppa_tdep): Update.
6432
6433 2019-05-08  Tom Tromey  <tom@tromey.com>
6434
6435         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6436         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6437         on obstack.
6438         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6439
6440 2019-05-08  Tom Tromey  <tom@tromey.com>
6441
6442         * mdebugread.c (basic_type_data): Change type.
6443         (basic_type, _initialize_mdebugread): Update.
6444
6445 2019-05-08  Tom Tromey  <tom@tromey.com>
6446
6447         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6448
6449 2019-05-08  Tom Tromey  <tom@tromey.com>
6450
6451         * nto-tdep.c (nto_inferior_data_reg): Change type.
6452         (nto_inferior_data): Update.
6453         (nto_inferior_data_cleanup, nto_new_inferior_data)
6454         (_initialize_nto_tdep): Remove.
6455         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6456
6457 2019-05-08  Tom Tromey  <tom@tromey.com>
6458
6459         * ada-lang.c (struct ada_inferior_data): Add initializers.
6460         (ada_inferior_data): Change type.
6461         (ada_inferior_data_cleanup): Remove.
6462         (get_ada_inferior_data, ada_inferior_exit)
6463         (struct ada_pspace_data): Add initializers, destructor.
6464         (ada_pspace_data_handle): Change type.
6465         (get_ada_pspace_data): Update.
6466         (ada_pspace_data_cleanup): Remove.
6467
6468 2019-05-08  Tom Tromey  <tom@tromey.com>
6469
6470         * coffread.c (struct coff_symfile_info): Add initializers.
6471         (coff_objfile_data_key): Move lower.  Change type.
6472         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6473         Update.
6474         (coff_free_info): Remove.
6475
6476 2019-05-08  Tom Tromey  <tom@tromey.com>
6477
6478         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6479         (fbsd_pspace_data_handle): Move lower.  Change type.
6480         (get_fbsd_pspace_data): Update.
6481         (fbsd_pspace_data_cleanup): Remove.
6482         (_initialize_fbsd_tdep): Update.
6483
6484 2019-05-08  Tom Tromey  <tom@tromey.com>
6485
6486         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6487         (get_ada_tasks_pspace_data): Update.
6488         (ada_tasks_pspace_data_cleanup): Remove.
6489         (_initialize_tasks): Update.
6490         (ada_tasks_inferior_data_handle): Change type.
6491         (get_ada_tasks_inferior_data): Update.
6492         (ada_tasks_inferior_data_cleanup): Remove.
6493         (struct ada_tasks_pspace_data): Add initializers.
6494
6495 2019-05-08  Tom Tromey  <tom@tromey.com>
6496
6497         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6498         * symfile-debug.c (debug_sym_get_probes): Change type.
6499         * stap-probe.c (handle_stap_probe):
6500         (stap_static_probe_ops::get_probes): Change type.
6501         * probe.h (class static_probe_ops) <get_probes>: Change type.
6502         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6503         (parse_probes_in_pspace): Update.
6504         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6505         Update.
6506         (any_static_probe_ops::get_probes): Change type.
6507         * elfread.c (elfread_data): New typedef.
6508         (probe_key): Change type.
6509         (elf_get_probes): Likewise.  Update.
6510         (probe_key_free): Remove.
6511         (_initialize_elfread): Update.
6512         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6513         Change type.
6514         (dtrace_process_dof_probe, dtrace_process_dof)
6515         (dtrace_static_probe_ops::get_probe): Change type.
6516
6517 2019-05-08  Tom Tromey  <tom@tromey.com>
6518
6519         * xcoffread.c (struct xcoff_symfile_info): Rename from
6520         coff_symfile_info.  Add initializers.
6521         (xcoff_objfile_data_key): Move lower.  Change type.
6522         (XCOFF_DATA): Rewrite.
6523         (xcoff_free_info): Remove.
6524         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6525         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6526         (xcoff_initial_scan): Update.
6527
6528 2019-05-08  Tom Tromey  <tom@tromey.com>
6529
6530         * solib-svr4.c (struct svr4_info): Add initializers and
6531         destructor.
6532         <probes_table>: Now an htab_up.
6533         (solib_svr4_pspace_data): Change type.
6534         (free_probes_table): Simplify.
6535         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6536         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6537         (probes_table_remove_objfile_probes, register_solib_event_probe)
6538         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6539         (_initialize_svr4_solib): Update.
6540
6541 2019-05-08  Tom Tromey  <tom@tromey.com>
6542
6543         * remote.c (remote_pspace_data): Change type.
6544         (remote_pspace_data_cleanup): Remove.
6545         (get_remote_exec_file, set_pspace_remote_exec_file)
6546         (_initialize_remote): Update.
6547
6548 2019-05-08  Tom Tromey  <tom@tromey.com>
6549
6550         * breakpoint.c (breakpoint_objfile_key): Change type.
6551         (get_breakpoint_objfile_data): Update.
6552         (free_breakpoint_objfile_data): Remove.
6553         (_initialize_breakpoint): Update.
6554
6555 2019-05-08  Tom Tromey  <tom@tromey.com>
6556
6557         * linux-tdep.c (struct linux_info): Add initializers.
6558         (linux_inferior_data): Move.  Change type.
6559         (invalidate_linux_cache_inf): Update.
6560         (linux_inferior_data_cleanup): Remove.
6561         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6562
6563 2019-05-08  Tom Tromey  <tom@tromey.com>
6564
6565         * auxv.c (auxv_inferior_data): Move.  Change type.
6566         (auxv_inferior_data_cleanup): Remove.
6567         (invalidate_auxv_cache_inf): Rewrite.
6568         (get_auxv_inferior_data, _initialize_auxv): Update.
6569
6570 2019-05-08  Tom Tromey  <tom@tromey.com>
6571
6572         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6573         (symfile_debug_objfile_data_key): Change type.
6574         (symfile_debug_installed, debug_qf_has_symbols)
6575         (debug_qf_find_last_source_symtab)
6576         (debug_qf_forget_cached_source_info)
6577         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6578         (debug_qf_print_stats, debug_qf_dump)
6579         (debug_qf_expand_symtabs_for_function)
6580         (debug_qf_expand_all_symtabs)
6581         (debug_qf_expand_symtabs_with_fullname)
6582         (debug_qf_map_matching_symbols)
6583         (debug_qf_expand_symtabs_matching)
6584         (debug_qf_find_pc_sect_compunit_symtab)
6585         (debug_qf_map_symbol_filenames)
6586         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6587         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6588         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6589         (debug_sym_read_linetable, debug_sym_relocate): Update.
6590         (symfile_debug_free_objfile): Remove.
6591         (install_symfile_debug_logging, _initialize_symfile_debug):
6592         Update.
6593
6594 2019-05-08  Tom Tromey  <tom@tromey.com>
6595
6596         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6597         allocate_on_obstack.
6598         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6599         (get_dwarf2_per_objfile): Update.
6600         (set_dwarf2_per_objfile): Remove.
6601         (dwarf2_has_info, dwarf2_get_section_info): Update.
6602         (dwarf2_free_objfile): Remove.
6603         (_initialize_dwarf2_read): Update.
6604
6605 2019-05-08  Tom Tromey  <tom@tromey.com>
6606
6607         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6608         initializers.
6609         <unsupported_script_warning_printed,
6610         script_not_found_warning_printed>: Now bool.
6611         (auto_load_pspace_data): Change type.
6612         (~auto_load_pspace_info): Rename from
6613         auto_load_pspace_data_cleanup.
6614         (get_auto_load_pspace_data, init_loaded_scripts_info)
6615         (clear_section_scripts, maybe_print_unsupported_script_warning)
6616         (maybe_print_script_not_found_warning, _initialize_auto_load):
6617         Update.
6618
6619 2019-05-08  Tom Tromey  <tom@tromey.com>
6620
6621         * objfiles.c (objfile_pspace_info): Add destructor and
6622         initializers.
6623         (objfiles_pspace_data): Change type.
6624         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6625         (get_objfile_pspace_data): Update.
6626         (objfiles_bfd_data): Change type.
6627         (get_objfile_bfd_data): Update.
6628         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6629
6630 2019-05-08  Tom Tromey  <tom@tromey.com>
6631
6632         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6633         Change type.
6634         (get_catch_syscall_inferior_data): Update.
6635         (catch_syscall_inferior_data_cleanup): Remove.
6636         (_initialize_break_catch_syscall): Update.
6637
6638 2019-05-08  Tom Tromey  <tom@tromey.com>
6639
6640         * inflow.c (struct terminal_info): Add destructor and
6641         initializers.
6642         (inflow_inferior_data): Change type.
6643         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6644         (get_inflow_inferior_data, inflow_inferior_exit)
6645         (swap_terminal_info, _initialize_inflow): Update.
6646
6647 2019-05-08  Tom Tromey  <tom@tromey.com>
6648
6649         * target-dcache.c (target_dcache_cleanup): Remove.
6650         (target_dcache_aspace_key): Change type.
6651         (target_dcache_init_p, target_dcache_invalidate)
6652         (target_dcache_get, target_dcache_get_or_init)
6653         (_initialize_target_dcache): Update.
6654         * dcache.h (struct dcache_deleter): New.
6655
6656 2019-05-08  Tom Tromey  <tom@tromey.com>
6657
6658         * symtab.c (struct symbol_cache): Add destructor and
6659         initializers.
6660         (symbol_cache_key): Move.  Change type.
6661         (make_symbol_cache, free_symbol_cache): Remove.
6662         (get_symbol_cache): Update.
6663         (symbol_cache_cleanup): Remove.
6664         (ALL_PSPACES, symbol_cache_flush)
6665         (maintenance_print_symbol_cache)
6666         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6667         Update.
6668
6669 2019-05-08  Tom Tromey  <tom@tromey.com>
6670
6671         * symtab.c (struct main_info): Add destructor and initializers.
6672         (main_progspace_key): Move.  Change type.
6673         (get_main_info): Update.
6674         (main_info_cleanup): Remove.
6675         (_initialize_symtab): Update.
6676
6677 2019-05-08  Tom Tromey  <tom@tromey.com>
6678
6679         * registry.h (DECLARE_REGISTRY): Define the _key class.
6680
6681 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6682
6683         * NEWS: Merge two 'New commands' sections.
6684
6685 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6686
6687         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6688         parameter and use Ada language definition instead.
6689         (ada_val_print_ptr): Remove unused language parameter.
6690         (ada_val_print_num): Remove language parameter and use Ada language
6691         definition instead.
6692         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6693         parameter.
6694         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6695         parameter and use Ada language definition instead.
6696         (ada_val_print_1): Update all ada_val_print_xxx calls.
6697         Remove language parameter.
6698         (ada_val_print): Update ada_val_print_1 call.
6699
6700 2019-05-08  Tom Tromey  <tromey@adacore.com>
6701
6702         * remote.c (remote_hw_watchpoint_limit)
6703         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6704         Now static.
6705
6706 2019-05-08  Tom Tromey  <tromey@adacore.com>
6707
6708         * maint.c (_initialize_maint_cmds): Move initialization code to
6709         remote.c.
6710         (watchdog, show_watchdog): Move to remote.c.
6711         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6712         "watchdog" static.
6713         (_initialize_remote): Move initialization code from maint.c.
6714         * defs.h (watchdog): Don't declare.
6715
6716 2019-05-08  Tom Tromey  <tromey@adacore.com>
6717
6718         * tui/tui-interp.c: Include main.h.
6719         * interps.c: Include main.h.
6720         * main.h (interpreter_p): Declare.
6721         * defs.h (interpreter_p): Don't declare.
6722
6723 2019-05-08  Tom Tromey  <tromey@adacore.com>
6724
6725         * dwarf2loc.c: Include dwarf2read.h.
6726         * defs.h (read_unsigned_leb128): Don't declare.
6727         * dwarf2read.h (read_unsigned_leb128): Declare.
6728
6729 2019-05-08  Tom Tromey  <tromey@adacore.com>
6730
6731         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6732         method.
6733
6734 2019-05-08  Tom Tromey  <tromey@adacore.com>
6735
6736         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6737         when no wrap column is set.
6738
6739 2019-05-08  Tom Tromey  <tromey@adacore.com>
6740
6741         * c-lang.c (c_get_string): Handle non-C-style arrays.
6742
6743 2019-05-08  Tom Tromey  <tromey@adacore.com>
6744
6745         * typeprint.c (print_offset_data::update): Print the bit offset,
6746         not the number of bits remaining.
6747
6748 2019-05-08  Tom Tromey  <tromey@adacore.com>
6749
6750         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6751         padding at end of comment.
6752
6753 2019-05-08  Tom Tromey  <tromey@adacore.com>
6754
6755         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6756         Compare main types.
6757
6758 2019-05-06  Tom Tromey  <tom@tromey.com>
6759
6760         * common/scoped_mmap.c: Include common-defs.h.
6761         * common/scoped_mmap.h: Don't include config.h.
6762
6763 2019-05-04  Tom Tromey  <tom@tromey.com>
6764
6765         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6766         (struct aarch64_call_info): Add initializers.
6767         <si>: Now a std::vector.
6768         (pass_on_stack, aarch64_push_dummy_call): Update.
6769
6770 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6771             Tom Tromey  <tom@tromey.com>
6772
6773         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6774         (ppc_threads): Now a std::vector.  Now static.
6775         (hwdebug_find_thread_points_by_tid)
6776         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6777         Update.
6778
6779 2019-05-04  Tom Tromey  <tom@tromey.com>
6780
6781         * arc-tdep.c (arc_tdesc_init): Return bool.
6782
6783 2019-05-04  Tom Tromey  <tom@tromey.com>
6784
6785         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6786         Use gdb_assert_not_reached.
6787
6788 2019-05-04  Tom Tromey  <tom@tromey.com>
6789
6790         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6791         "false".
6792
6793 2019-05-04  Tom Tromey  <tom@tromey.com>
6794
6795         * arc-tdep.c (arc_tdesc_init): Use bool.
6796
6797 2019-05-04  Tom Tromey  <tom@tromey.com>
6798
6799         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6800
6801 2019-05-04  Tom Tromey  <tom@tromey.com>
6802
6803         * cli/cli-cmds.c (valid_command_p): Return bool.
6804
6805 2019-05-04  Tom Tromey  <tom@tromey.com>
6806
6807         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6808         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6809
6810 2019-05-04  Raul Tambre  <raul@tambre.ee>
6811
6812         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6813         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6814         operator for comparison.
6815
6816 2019-05-04  Tom Tromey  <tom@tromey.com>
6817
6818         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6819         (lookup_partial_symbol, print_partial_symbols)
6820         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6821         (psymbol_compare): Update.
6822         (add_psymbol_to_bcache): Clear the entire psymbol.
6823         (maintenance_check_psymtabs): Update.
6824         * psympriv.h (struct partial_symbol): Don't derive from
6825         general_symbol_info.
6826         <obj_section, unrelocated_address, address,
6827         set_unrelocated_address>: Update.
6828         <ginfo>: New member.
6829         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6830         (debug_names::write_psymbols): Update.
6831
6832 2019-05-04  Tom de Vries  <tdevries@suse.de>
6833
6834         * contrib/cc-with-tweaks.sh: Support -n arg.
6835
6836 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6837
6838         * corelow.c (core_target::detach): Ensure frame cache and
6839         register caches are cleared.
6840         inferior.c (exit_inferior_1): Likewise.
6841
6842 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6843             Tom Tromey  <tom@tromey.com>
6844
6845         * dictionary.c (collate_pending_symbols_by_language): Remove
6846         "struct" from foreach.
6847         * symtab.c (lookup_global_symbol_from_objfile)
6848         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6849         foreach.
6850         * ser-tcp.c (net_open): Remove "struct" from foreach.
6851         * objfiles.c (objfile_relocate, objfile_rebase)
6852         (objfile_has_symbols): Remove "struct" from foreach.
6853         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6854         from foreach.
6855         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6856         foreach.
6857         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6858         "struct" from foreach.
6859         * ada-lang.c (create_excep_cond_exprs)
6860         (ada_exception_catchpoint_cond_string): Remove "struct" from
6861         foreach.
6862
6863 2019-05-03  Tom Tromey  <tromey@adacore.com>
6864
6865         * ada-exp.y (convert_char_literal): Check suffix of each
6866         enumerator.
6867
6868 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6869
6870         PR ada/21406:
6871         * ada-exp.y (yywrap): Don't define.
6872         * ada-lex.l (%option): Add noyywrap
6873         (yywrap): Remove.
6874
6875 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6876
6877         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6878         _WIN32_WINNT to the XP level, unless already defined to a higher
6879         level.
6880
6881         * unittests/parse-connection-spec-selftests.c:
6882         * ser-tcp.c:
6883         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6884         override.
6885
6886         * symfile.c (find_separate_debug_file): Remove colon from the
6887         drive spec of DOS/Windows file names of the target, so that the
6888         file name produced from DEBUGDIR and the target's directory will
6889         be valid on DOS/Windows systems.
6890
6891 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6892
6893         * rust-lang.c (val_print_struct): Handle printing structures
6894         containing strings.
6895
6896 2019-05-02  Tom Tromey  <tromey@adacore.com>
6897
6898         * valarith.c (_initialize_valarith): Remove.
6899
6900 2019-05-01  Tom Tromey  <tromey@adacore.com>
6901
6902         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6903         bitfields.
6904
6905 2019-05-01  Tom Tromey  <tromey@adacore.com>
6906
6907         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6908         for big-endian copies.
6909
6910 2019-04-30  Ali Tamur  <tamur@google.com>
6911         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6912         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6913         (read_3_bytes): New function.
6914
6915 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6916
6917         * windows-nat.c (main_thread_id): Delete.
6918         (handle_output_debug_string): Replace main_thread_id by
6919         current_event.dwThreadId.
6920         (fake_create_process): Likewise.
6921         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6922         Do not set main_thread_id.
6923         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6924         current_event.dwThreadId.
6925         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6926
6927 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6928
6929         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6930         Use current_event.dwThreadId instead of main_thread_id.
6931
6932 2019-04-30  Tom Tromey  <tromey@adacore.com>
6933
6934         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6935         (create_excep_cond_exprs): Iterate over program spaces.
6936         (ada_exception_catchpoint_cond_string): Examine all minimal
6937         symbols for exception types.
6938
6939 2019-04-30  Tom Tromey  <tromey@adacore.com>
6940
6941         PR c++/24470:
6942         * dwarf2read.c (process_structure_scope): Handle case where type
6943         has template parameters but no symbol was created.
6944
6945 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6946             Chris January  <chris.january@arm.com>
6947
6948         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6949         qualifier.
6950         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6951
6952 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6953
6954         * f-typeprint.c (f_print_type): Update rules for printing
6955         whitespace.
6956         (f_type_print_varspec_suffix): Likewise.
6957
6958 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6959             Chris January  <chris.january@arm.com>
6960
6961         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6962         function arguments.
6963
6964 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6965
6966         * f-lang.c (build_fortran_types): Change name of void type to
6967         lower case.
6968         * f-typeprint.c (f_type_print_base): Print the name of the void
6969         type, rather than a fixed string.
6970         * f-valprint.c (f_decorations): Use lower case void string.
6971
6972 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6973             Chris January  <chris.january@arm.com>
6974
6975         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6976         types for Fortran.
6977
6978 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6979             Chris January  <chris.january@arm.com>
6980             David Lecomber  <david.lecomber@arm.com>
6981
6982         * f-exp.y (BINOP_INTRINSIC): New token.
6983         (exp): New parser rule handling BINOP_INTRINSIC.
6984         (f77_keywords): Add new builtin procedures.
6985         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6986         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6987         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6988         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6989         (print_unop_subexp_f): New function.
6990         (print_binop_subexp_f): New function.
6991         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6992         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6993         (dump_subexp_body_f): Likewise.
6994         (operator_check_f): Likewise.
6995         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6996         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6997
6998 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6999
7000         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7001         UNOP_KIND.
7002         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7003         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7004         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7005         (operator_length_f): New fuction.
7006         (print_subexp_f): New function.
7007         (op_name_f): New function.
7008         (dump_subexp_body_f): New function.
7009         (operator_check_f): New function.
7010         (exp_descriptor_f): Replace standard expression handling functions
7011         with new functions.
7012         * gdb/fortran-operator.def: New file.
7013         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7014         * gdb/std-operator.def: Remove UNOP_KIND.
7015
7016 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7017
7018         * std-operator.def: Remove unbalanced, stray double quote
7019         character.
7020
7021 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7022             Chris January  <chris.january@arm.com>
7023             Daniel Everett  <daniel.everett@arm.com>
7024             Nick Forrington  <nick.forrington@arm.com>
7025             Richard Bunt  <richard.bunt@arm.com>
7026
7027         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7028         of depth when printing anonymous structs or unions.
7029         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7030         Don't print either the top-level value, or the children if the
7031         max-depth is exceeded.
7032         (ppscm_print_children): When printing the key of a map, allow one
7033         extra level of depth.
7034         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7035         print either the top-level value, or the children if the max-depth
7036         is exceeded.
7037         (print_children): When printing the key of a map, allow one extra
7038         level of depth.
7039         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7040         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7041         (user_print_options): Initialise max_depth field.
7042         (val_print_scalar_or_string_type_p): New function.
7043         (val_print): Check to see if the max depth has been reached.
7044         (val_print_check_max_depth): Define new function.
7045         (show_print_max_depth): New function.
7046         (_initialize_valprint): Add 'print max-depth' option.
7047         * valprint.h (struct value_print_options) <max_depth>: New field.
7048         (val_print_check_max_depth): Declare new function.
7049         * NEWS: Document new feature.
7050
7051 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7052
7053         * ada-lang.c (ada_language_defn): Initialise new field.
7054         * c-lang.c (c_is_string_type_p): New function.
7055         (c_language_defn): Initialise new field.
7056         (cplus_language_defn): Initialise new field.
7057         (asm_language_defn): Initialise new field.
7058         (minimal_language_defn): Initialise new field.
7059         * c-lang.h (c_is_string_type_p): Declare new function.
7060         * d-lang.c (d_language_defn): Initialise new field.
7061         * f-lang.c (f_is_string_type_p): New function.
7062         (f_language_defn): Initialise new field.
7063         * go-lang.c (go_is_string_type_p): New function.
7064         (go_language_defn): Initialise new field.
7065         * language.c (default_is_string_type_p): New function.
7066         (unknown_language_defn): Initialise new field.
7067         (auto_language_defn): Initialise new field.
7068         * language.h (struct language_defn) <la_is_string_type_p>: New
7069         member variable.
7070         (default_is_string_type_p): Declare new function.
7071         * m2-lang.c (m2_language_defn): Initialise new field.
7072         * objc-lang.c (objc_language_defn): Initialise new field.
7073         * opencl-lang.c (opencl_language_defn): Initialise new field.
7074         * p-lang.c (pascal_is_string_type_p): New function.
7075         (pascal_language_defn): Initialise new field.
7076         * rust-lang.c (rust_is_string_type_p): New function.
7077         (rust_language_defn): Initialise new field.
7078
7079 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7080
7081         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7082         New field.
7083         * ada-lang.c (ada_language_defn): Initialise new field.
7084         * c-lang.c (c_language_defn): Likewise.
7085         (cplus_language_defn): Likewise.
7086         (asm_language_defn): Likewise.
7087         (minimal_language_defn): Likewise.
7088         * d-lang.c (d_language_defn): Likewise.
7089         * f-lang.c (f_language_defn): Likewise.
7090         * go-lang.c (go_language_defn): Likewise.
7091         * language.c (unknown_language_defn): Likewise.
7092         (auto_language_defn): Likewise.
7093         * m2-lang.c (m2_language_defn): Likewise.
7094         * objc-lang.c (objc_language_defn): Likewise.
7095         * opencl-lang.c (opencl_language_defn): Likewise.
7096         * p-lang.c (pascal_language_defn): Likewise.
7097         * rust-lang.c (rust_language_defn): Likewise.
7098
7099 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7100
7101         * ada-lang.c (ada_is_character_type): Change return type to bool.
7102         (ada_is_string_type): Likewise.
7103         * ada-lang.h (ada_is_character_type): Update declaration
7104         (ada_is_string_type): Likewise.
7105
7106 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7107
7108         Support style in 'frame|thread apply'
7109
7110         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7111         * record.c (record_start, record_stop): Update callers of
7112         execute_command_to_string with false.
7113         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7114         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7115         methods.
7116         (class string_file): New constructor with term_out parameter.
7117         Override methods term_out and can_emit_style_escape.  New member
7118         term_out.
7119         (class stdio_file): Override can_emit_style_escape.
7120         (class tee_file): Override term_out and can_emit_style_escape.
7121         * utils.h (can_emit_style_escape): Remove.
7122         * utils.c (can_emit_style_escape): Likewise.
7123         Update all callers of can_emit_style_escape (SOMESTREAM) to
7124         SOMESTREAM->can_emit_style_escape.
7125         * source-cache.c (source_cache::get_source_lines): Likewise.
7126         * stack.c (frame_apply_command_count): Call execute_command_to_string
7127         passing the term_out characteristic of the current gdb_stdout.
7128         * thread.c (thr_try_catch_cmd): Likewise.
7129         * top.c (execute_command_to_string): pass term_out parameter
7130         to construct the string_file for the command output.
7131         * ui-file.c (term_cli_styling): New function (most code moved
7132         from utils.c can_emit_style_escape).
7133         (string_file::string_file, string_file::can_emit_style_escape,
7134         stdio_file::can_emit_style_escape, tee_file::term_out,
7135         tee_file::can_emit_style_escape): New functions.
7136
7137 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7138
7139         * NEWS: Mention the new set|show may-call-functions.
7140         * infcall.c (may_call_functions_p): New variable.
7141         (show_may_call_functions_p): New function.
7142         (call_function_by_hand_dummy): Throws an error if not
7143         may-call-functions.
7144         (_initialize_infcall): Call add_setshow_boolean_cmd for
7145         may-call-functions.
7146
7147 2019-04-25  Keith Seitz  <keiths@redhat.com>
7148
7149         PR c++/24367
7150         * cp-support.c (inspect_type): Don't attempt substitutions
7151         of symbol with the same name.
7152
7153 2019-04-25  Tom Tromey  <tromey@adacore.com>
7154
7155         PR gdb/24475:
7156         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7157         static.
7158
7159 2019-04-25  Tom Tromey  <tromey@adacore.com>
7160
7161         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7162         rvalue reference.
7163         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7164         (gdb_xml_parser::parse): Use std::move.
7165         * python/python-internal.h (gdbpy_convert_exception): Take a const
7166         reference.
7167         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7168         std::move.
7169         * python/py-utils.c (gdbpy_convert_exception): Take a const
7170         reference.
7171         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7172         Use std::move.
7173         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7174         Use std::move.
7175         * mi/mi-main.c (mi_print_exception): Take a const reference.
7176         * main.c (handle_command_errors): Take a const reference.
7177         * linespec.c (parse_linespec): Use std::move.
7178         * infcall.c (run_inferior_call): Use std::move.
7179         (call_function_by_hand_dummy): Use std::move.
7180         * exec.c (try_open_exec_file): Use std::move.
7181         * exceptions.h (exception_print, exception_fprintf)
7182         (exception_print_same): Update.
7183         * exceptions.c (print_exception, exception_print)
7184         (exception_fprintf, exception_print_same): Change parameters to
7185         const reference.
7186         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7187         * common/new-op.c: Use std::move.
7188         * common/common-exceptions.h (struct gdb_exception): Add move
7189         constructor.
7190         (struct gdb_exception_error, struct gdb_exception_quit, struct
7191         gdb_quit_bad_alloc): Change constructor to move constructor.
7192         (throw_exception): Change parameter to rvalue reference.
7193         * common/common-exceptions.c (throw_exception): Take rvalue
7194         reference.
7195         * cli/cli-interp.c (safe_execute_command): Use std::move.
7196         * breakpoint.c (insert_bp_location, location_to_sals): Use
7197         std::move.
7198
7199 2019-04-25  Tom Tromey  <tromey@adacore.com>
7200
7201         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7202         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7203         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7204         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7205         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7206         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7207         guile/scm-value.c: Use unpack.
7208         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7209         gdbscm_gdb_exception.
7210         (gdbscm_throw_gdb_exception): Likewise.
7211         (struct gdbscm_gdb_exception): New.
7212         (unpack): New function.
7213         (gdbscm_wrap): Use unpack.
7214
7215 2019-04-25  Tom Tromey  <tromey@adacore.com>
7216
7217         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7218         (gdb_rl_callback_handler): Use std::move.
7219         * common/common-exceptions.h (struct gdb_exception): Add move
7220         assignment operator.
7221         (throw_exception_sjlj): Change "exception" to const reference.
7222         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7223         (throw_exception_sjlj): Change "exception" to const reference.
7224
7225 2019-04-25  Tom Tromey  <tromey@adacore.com>
7226
7227         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7228         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7229         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7230         Update.
7231         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7232         Update.
7233         * mi/mi-interp.c (mi_interp::exec): Update.
7234         * linespec.c (parse_linespec): Update.
7235         * infcall.c (run_inferior_call): Update.
7236         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7237         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7238         (gdbscm_lookup_global_symbol): Update.
7239         * guile/scm-param.c (gdbscm_parameter_value): Update.
7240         * guile/scm-frame.c (gdbscm_frame_read_register)
7241         (gdbscm_frame_read_var): Update.
7242         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7243         * exec.c (try_open_exec_file): Update.
7244         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7245         (gdb_rl_callback_handler): Update.
7246         * common/common-exceptions.h (exception_none): Don't declare.
7247         * common/common-exceptions.c (exception_none): Don't define.
7248         (struct catcher) <exception>: Update.
7249         * cli/cli-interp.c (safe_execute_command): Update.
7250         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7251
7252 2019-04-25  Ali Tamur  <tamur@google.com>
7253
7254         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7255         (read_attribute_value): Likewise.
7256         (dwarf2_read_addr_index): Update comment.
7257         (read_str_index): Add DW_FORM_strx.
7258         (dwarf2_string_attr): Likewise.
7259         (dwarf2_const_value_attr): Likewise.
7260         (dump_die_shallow): Likewise.
7261         (dwarf2_fetch_constant_bytes): Likewise.
7262         (skip_form_bytes): Likewise.
7263         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7264
7265 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7266
7267         PR corefiles/11608
7268         PR corefiles/18187
7269         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7270         OFFSET.  Verify if current mapping contains an ELF header.
7271         (linux_find_memory_regions_full): Adjust call to
7272         dump_mapping_p.
7273
7274 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7275             Kang Li <kanglictf@gmail.com>
7276
7277         PR gdb/21600
7278
7279         * dwarf2-frame.c (read_initial_length): Be consistent about using
7280         unsigned representation of length.
7281         (decode_frame_entry_1): Likewise.  Check for wraparound of
7282         end pointer as well as buffer overflow.
7283
7284 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7285
7286         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7287         "vq".
7288
7289 2019-04-24  Tom Tromey  <tromey@adacore.com>
7290
7291         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7292
7293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7294
7295         * s12z-tdep.c (s12z_unwind_pc): Delete.
7296         (s12z_unwind_sp): Delete.
7297         (s12z_gdbarch_init): Don't register deleted functions with
7298         gdbarch.
7299
7300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7301
7302         * rl78-tdep.c (rl78_unwind_sp): Delete.
7303         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7304
7305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7306
7307         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7308         (xstormy16_unwind_pc): Delete.
7309         (xstormy16_dummy_id): Delete.
7310         (xstormy16_gdbarch_init): Don't register deleted functions with
7311         gdbarch.
7312
7313 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7314
7315         * vax-tdep.c (vax_unwind_pc): Delete.
7316         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7317
7318 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7319
7320         * v850-tdep.c (v850_unwind_sp): Delete.
7321         (v850_unwind_pc): Delete.
7322         (v850_dummy_id): Delete.
7323         (v850_gdbarch_init): Don't register deleted functions with
7324         gdbarch.
7325
7326 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7327
7328         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7329         (tilegx_unwind_pc): Delete.
7330         (tilegx_unwind_dummy_id): Delete.
7331         (tilegx_gdbarch_init): Don't register deleted functions with
7332         gdbarch.
7333
7334 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7335
7336         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7337         (tic6x_dummy_id): Delete.
7338         (tic6x_gdbarch_init): Don't register deleted functions with
7339         gdbarch.
7340
7341 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7342
7343         * sparc-tdep.c (sparc_unwind_pc): Delete.
7344         (sparc32_gdbarch_init): Don't register deleted function with
7345         gdbarch.
7346
7347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7348
7349         * sh-tdep.c (sh_unwind_sp): Delete.
7350         (sh_unwind_pc): Delete.
7351         (sh_dummy_id): Delete.
7352         (sh_gdbarch_init): Don't register deleted functions with
7353         gdbarch.
7354
7355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7356
7357         * score-tdep.c (score_unwind_sp): Delete.
7358         (score_unwind_pc): Delete.
7359         (score_dummy_id): Delete.
7360         (score_gdbarch_init): Don't register deleted functions with
7361         gdbarch.
7362
7363 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7364
7365         * rx-tdep.c (rx_unwind_pc): Delete.
7366         (rx_unwind_sp): Delete.
7367         (rx_dummy_id): Delete.
7368         (rx_gdbarch_init): Don't register deleted functions with
7369         gdbarch.  Update comment.
7370
7371 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7372
7373         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7374         (rs6000_dummy_id): Delete.
7375         (rs6000_gdbarch_init): Don't register deleted functions with
7376         gdbarch.
7377
7378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7379
7380         * or1k-tdep.c (or1k_dummy_id): Delete.
7381         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7382
7383 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7384
7385         * nios2-tdep.c (nios2_dummy_id): Delete.
7386         (nios2_unwind_sp): Delete.
7387         (nios2_gdbarch_init): Don't register deleted functions with
7388         gdbarch.
7389
7390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7391
7392         * nds32-tdep.c (nds32_dummy_id): Delete.
7393         (nds32_unwind_pc): Delete.
7394         (nds32_unwind_sp): Delete.
7395         (nds32_gdbarch_init): Don't register deleted functions with
7396         gdbarch.
7397
7398 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7399
7400         * msp430-tdep.c (msp430_unwind_pc): Delete.
7401         (msp430_unwind_sp): Delete.
7402         (msp430_dummy_id): Delete.
7403         (msp430_gdbarch_init): Don't register deleted functions with
7404         gdbarch.
7405
7406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7407
7408         * moxie-tdep.c (moxie_unwind_sp): Delete.
7409         (moxie_unwind_pc): Delete.
7410         (moxie_dummy_id): Delete.
7411         (moxie_gdbarch_init): Don't register deleted functions with
7412         gdbarch.
7413
7414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7415
7416         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7417         (mn10300_unwind_pc): Delete.
7418         (mn10300_unwind_sp): Delete.
7419         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7420         mn10300_unwind_sp.
7421         (mn10300_frame_unwind_init): Don't register deleted functions with
7422         gdbarch.
7423
7424 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7425
7426         * mep-tdep.c (mep_unwind_pc): Delete.
7427         (mep_unwind_sp): Delete.
7428         (mep_dummy_id): Delete.
7429         (mep_gdbarch_init): Don't register deleted functions with
7430         gdbarch.
7431
7432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7433
7434         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7435         (m68hc11_unwind_sp): Delete.
7436         (m68hc11_gdbarch_init): Don't register deleted functions with
7437         gdbarch.
7438
7439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7440
7441         * m32r-tdep.c (m32r_unwind_sp): Delete.
7442         (m32r_unwind_pc): Delete.
7443         (m32r_dummy_id): Delete.
7444         (m32r_gdbarch_init): Don't register deleted functions with
7445         gdbarch.
7446
7447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7448
7449         * m32c-tdep.c (m32c_unwind_pc): Delete.
7450         (m32c_unwind_sp): Delete.
7451         (m32c_dummy_id): Delete.
7452         (m32c_gdbarch_init): Don't register deleted functions with
7453         gdbarch.
7454
7455 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7456
7457         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7458         (lm32_unwind_pc): Delete.
7459         (lm32_dummy_id): Delete.
7460         (lm32_gdbarch_init): Don't register deleted functions with
7461         gdbarch.
7462
7463 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7464
7465         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7466         (iq2000_unwind_pc): Delete.
7467         (iq2000_dummy_id): Delete.
7468         (iq2000_gdbarch_init): Don't register deleted functions with
7469         gdbarch.
7470
7471 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7472
7473         * nds32-tdep.c (nds32_type_align): Delete.
7474         (nds32_push_dummy_call): Use type_align instead.
7475
7476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7477
7478         * arm-tdep.c (arm_type_align): Only handle vector override case.
7479         (arm_push_dummy_call): Use type_align.
7480         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7481
7482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7483
7484         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7485         case.
7486         (pass_on_stack): Use type_align.
7487         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7488         function.
7489
7490 2019-04-23  Tom Tromey  <tromey@adacore.com>
7491
7492         * dwarf2read.c (line_header::file_name_at): Remove unused
7493         overload.
7494
7495 2019-04-23  Tom de Vries  <tdevries@suse.de>
7496
7497         PR gdb/24438
7498         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7499         invocation.
7500
7501
7502 2019-03-27  Ali Tamur  <tamur@google.com>
7503
7504         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7505         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7506         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7507         (dwarf_expr_context::get_addr_index): Likewise
7508         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7509         (symbol_needs_eval_context::get_addr_index): Likewise
7510         (disassemble_dwarf_expression): Add DW_OP_addrx
7511         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7512         (read_cutu_die_from_dwo): Update comment
7513         (skip_one_die): Add DW_FORM_addrx
7514         (read_attribute_value): Likewise
7515         (var_decode_location): Add DW_OP_addrx
7516         (dwarf2_const_value_attr): Add DW_FORM_addrx
7517         (dump_die_shallow): Likewise
7518         (dwarf2_fetch_constant_bytes): Likewise
7519         (decode_locdesc): Add DW_OP_addrx
7520         (skip_form_bytes): Add DW_FORM_addrx
7521
7522 2019-04-22  Ali Tamur  <tamur@google.com>
7523
7524         * MAINTAINERS (Write After Approval): Add self.
7525
7526 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7527
7528         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7529         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7530         (open_symbol_file_object): Likewise.
7531         (svr4_default_sos): Add info parameter.
7532         (svr4_read_so_list): Likewise.
7533         (svr4_current_sos_direct): Adjust functions calls to pass down
7534         info.
7535         (svr4_current_sos_1): Add info parameter.
7536         (svr4_current_sos): Call get_svr4_info, pass info down to
7537         svr4_current_sos_1.
7538         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7539         get_svr4_info.
7540         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7541         get_svr4_info.
7542         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7543         to get_svr4_info.
7544         (probes_table_remove_objfile_probes): Likewise.
7545         (register_solib_event_probe): Add info parameter.
7546         (solist_update_incremental): Pass info parameter down to
7547         svr4_read_so_list.
7548         (disable_probes_interface): Add info parameter.
7549         (svr4_handle_solib_event): Pass current_program_space to
7550         get_svr4_info.  Adjust disable_probes_interface cleanup.
7551         (svr4_create_probe_breakpoints): Add info parameter, pass it
7552         down to register_solib_event_probe.
7553         (svr4_create_solib_event_breakpoints): Add info parameter,
7554         pass it down to svr4_create_probe_breakpoints.
7555         (enable_break): Pass info down to
7556         svr4_create_solib_event_breakpoints.
7557         (svr4_solib_create_inferior_hook): Pass current_program_space to
7558         get_svr4_info.
7559         (svr4_clear_solib): Likewise.
7560
7561 2019-04-22  Pedro Alves  <palves@redhat.com>
7562
7563         * solib-svr4.c (svr4_free_objfile_observer): New.
7564         (probe_and_action::objfile): New field.
7565         (probes_table_htab_remove_objfile_probes)
7566         (probes_table_remove_objfile_probes): New functions.
7567         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7568         in the new probe_and_action.  Don't store the probe in 'lookup'.
7569         (svr4_create_probe_breakpoints): Pass objfile to
7570         register_solib_event_probe.
7571         (_initialize_svr4_solib): Register a free_objfile observer.
7572
7573 2019-04-19  Tom Tromey  <tom@tromey.com>
7574
7575         * common/queue.h: Remove.
7576
7577 2019-04-19  Tom Tromey  <tom@tromey.com>
7578
7579         * event-loop.c: Don't include "common/queue.h".
7580
7581 2019-04-19  Tom Tromey  <tom@tromey.com>
7582
7583         * remote.c (remote_target): Use delete.
7584         * remote-notif.h: Include <list>, not "common/queue.h".
7585         (notif_client_p): Remove typedef.
7586         (remote_notif_state): Add constructor, destructor, initializer.
7587         <notif_queue>: Now a std::list.
7588         (remote_notif_state_xfree): Don't declare.
7589         * remote-notif.c (remote_notif_process, handle_notification)
7590         (remote_notif_state_allocate): Update.
7591         (~remote_notif_state): Rename from remote_notif_state_xfree.
7592
7593 2019-04-19  Tom Tromey  <tom@tromey.com>
7594
7595         * symfile.c (reread_symbols): Update.
7596         * objfiles.c (objfile_register_static_link)
7597         (objfile_lookup_static_link): Update
7598         (~objfile) Don't delete static_links.
7599         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7600
7601 2019-04-19  Tom Tromey  <tom@tromey.com>
7602
7603         * type-stack.h (struct type_stack) <insert>: Constify string.
7604         * type-stack.c (type_stack::insert): Constify string.
7605         * gdbtypes.h (lookup_template_type): Update.
7606         (address_space_name_to_int): Update.
7607         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7608         const.
7609         (lookup_template_type): Make name const.
7610         * c-exp.y: Update rules.
7611         (lex_one_token, classify_name, classify_inner_name)
7612         (c_print_token): Update.
7613         * p-exp.y: Update rules.
7614         (yylex): Update.
7615         * f-exp.y: Update rules.
7616         (yylex): Update.
7617         * d-exp.y: Update rules.
7618         (lex_one_token, classify_name, classify_inner_name): Update.
7619         * parse.c (write_dollar_variable, copy_name): Return std::string.
7620         * parser-defs.h (copy_name): Change return type.
7621         * m2-exp.y: Update rules.
7622         (yylex): Update.
7623         * go-exp.y (lex_one_token): Update.
7624         Update rules.
7625         (classify_unsafe_function, classify_packaged_name)
7626         (classify_name, yylex): Update.
7627
7628 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7629
7630         * configure.ac: add --enable-source-highlight switch.
7631         * configure: Regenerate.
7632         * top.c (print_gdb_version): plumb --enable-source-highlight
7633         status to "show configuration".
7634
7635 2019-04-19  Tom Tromey  <tromey@adacore.com>
7636
7637         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7638         Check ADA_TYPE_P.
7639         (empty_record, ada_template_to_fixed_record_type_1)
7640         (template_to_static_fixed_type)
7641         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7642         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7643         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7644         macros.
7645
7646 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7647
7648         PR symtab/24423:
7649         * source.c (print_source_lines_base): Advance "iter" when a
7650         control character is seen.
7651
7652 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7653
7654         * inferior.h (struct infcall_suspend_state_deleter):
7655         Catch exception in destructor to avoid crash.
7656
7657 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7658
7659         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7660         close to the add_com "shell".
7661
7662 2019-04-18  Tom Tromey  <tromey@adacore.com>
7663
7664         * process-stratum-target.h (class process_stratum_target)
7665         <stratum>: Add "final".
7666
7667 2019-04-17  Tom Tromey  <tromey@adacore.com>
7668
7669         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7670         against nullptr before use.
7671
7672 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7673
7674         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7675
7676 2019-04-17  Jim Wilson  <jimw@sifive.com>
7677             Andrew Burgess  <andrew.burgess@embecosm.com>
7678
7679         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7680         code read might fail, assume 4-byte breakpoint in that case.
7681
7682 2019-04-15  Leszek Swirski  <leszeks@google.com>
7683
7684         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7685         rather than a hand-rolled POD check when checking for forced MEMORY
7686         classification.
7687
7688 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7689
7690         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7691         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7692         function.
7693         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7694         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7695         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7696         declaration.
7697
7698 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7699
7700         * aarch64-linux-nat.c
7701         (aarch64_linux_nat_target::thread_architecture): Add override.
7702         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7703         each VQ.
7704
7705 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7706
7707         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7708
7709 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7710
7711         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7712         target types of size 96-bits, add some additional comments, and
7713         check that the builtin type we found was the correct size.
7714
7715 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7716
7717         * utils.c (prompt_for_continue): Don't restore the styling at the
7718         end, as applied_style has the wrong value.  This fixes styling in
7719         long lists of file names that are interrupted by the "Continue?"
7720         prompt.
7721
7722 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7723
7724         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7725         * c-lang.c (c_language_defn): Likewise.
7726         (cplus_language_defn): Likewise.
7727         (asm_language_defn): Likewise.
7728         (minimal_language_defn): Likewise.
7729         * d-lang.c (d_language_defn): Likewise.
7730         * f-lang.c (f_language_defn): Likewise.
7731         * go-lang.c (go_language_defn): Likewise.
7732         * language.c (unknown_language_defn): Likewise.
7733         (auto_language_defn): Likewise.
7734         * language.h (struct language_defn): Remove la_magic field.
7735         (LANG_MAGIC): Delete.
7736         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7737         * objc-lang.c (objc_language_defn): Likewise.
7738         * opencl-lang.c (opencl_language_defn): Likewise.
7739         * p-lang.c (pascal_language_defn): Likewise.
7740         * rust-lang.c (rust_language_defn): Likewise.
7741
7742 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7743
7744         * riscv-tdep.c (riscv_type_align): New function.
7745         (riscv_type_alignment): Delete.
7746         (riscv_arg_location): Use 'type_align'.
7747         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7748
7749 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7750
7751         * gdbtypes.c (type_align): A struct with no non-static fields also
7752         has alignment of 1.
7753
7754 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7755
7756         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7757         component to 0.
7758         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7759         member.
7760         (riscv_struct_info::analyse): New implementation using new
7761         analyse_inner member function.
7762         (riscv_struct_info::field_offset): New member function.
7763         (riscv_struct_info::m_offsets): New member variable.
7764         (riscv_struct_info::analyse_inner): New private member function,
7765         takes the old implementation of riscv_struct_info::analyse but
7766         extended to track field offsets.
7767         (riscv_call_arg_struct): Update the struct folding special cases
7768         to handle cases where empty C++ structs, which are non-zero
7769         length, are found.
7770         (riscv_arg_location): Initialise the length of each location, a
7771         non-zero length now indicates the location is in use.
7772         (riscv_push_dummy_call): Allow for the first location having a
7773         non-zero offset when setting up arguments.
7774         (riscv_return_value): Likewise, but for return values.
7775
7776 2019-04-11  Tom Tromey  <tromey@adacore.com>
7777
7778         * utils.c (internal_vproblem): Make "msg" const.
7779
7780 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7781
7782         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7783         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7784         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7785         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7786
7787 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7788
7789         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7790         function.
7791         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7792         of amd64_collect_native_gregset.
7793         (amd64_linux_nat_target::store_registers): Likewise.
7794
7795 2019-04-10  Tom Tromey  <tom@tromey.com>
7796
7797         * symtab.c (lookup_global_symbol_from_objfile)
7798         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7799         * objfiles.h (class separate_debug_iterator): New.
7800         (class separate_debug_range): New.
7801         (struct objfile) <separate_debug_objfiles>: New method.
7802         (objfile_separate_debug_iterate): Don't declare.
7803         * objfiles.c (separate_debug_iterator::operator++): Rename from
7804         objfile_separate_debug_iterate.
7805         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7806         iterator.
7807         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7808         iterator.
7809
7810 2019-04-10  Tom Tromey  <tom@tromey.com>
7811
7812         * symfile.c (reread_symbols): Remove old comment.
7813         * objfiles.c (free_all_objfiles): Fix a typo.
7814
7815 2019-04-10  Tom Tromey  <tom@tromey.com>
7816
7817         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7818         * minsyms.c (lookup_minimal_symbol): Use foreach.
7819         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7820         (lookup_minimal_symbol_solib_trampoline): Likewise.
7821         * symfile.c (reread_symbols): Use foreach.
7822
7823 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7824             Tom Tromey  <tromey@adacore.com>
7825
7826         PR rust/24414:
7827         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7828         (rust_lex_int_test): Change "value" to be LONGEST.
7829         (rust_lex_tests): Add test for long integer literal.
7830
7831 2019-04-09  Tom Tromey  <tromey@adacore.com>
7832
7833         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7834         to bool.
7835         (extended_remote_target::attach): Update.
7836         (remote_target::remote_notice_new_inferior): Update.
7837         (remote_target::add_current_inferior_and_thread): Update.
7838         * inferior.c (exit_inferior_1): Use "false".
7839         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7840
7841 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7842
7843         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7844         the "start" command.
7845
7846 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7847
7848         * python/py-inferior.c (infpy_thread_from_thread_handle):
7849         Adjust comments to reflect renaming of thread_from_thread_handle
7850         to thread_from_handle.  Adjust keywords.  Fix type error message.
7851         (inferior_object_methods): Add thread_from_handle.  Retain
7852         thread_from_thread_handle, but mark it as deprecated.
7853
7854 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7855
7856         * gdbthread.h (find_thread_by_handle): Revise declaration.
7857         * thread.c (find_thread_by_handle): Likewise.  Adjust
7858         implementation too.
7859         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7860         support for buffer objects as handles.
7861
7862 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7863
7864         * python/py-infthread.c (thpy_thread_handle): New function.
7865         (thread_object_methods): Register thpy_thread_handle.
7866
7867 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7868
7869         * gdbthread.h (thread_to_thread_handle): Declare.
7870         * thread.c (gdbtypes.h): Include.
7871         (thread_to_thread_handle): New function.
7872
7873         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7874         (target_thread_info_to_thread_handle): Declare.
7875         * target.c (target_thread_info_to_thread_handle): New function.
7876         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7877         * target-delegates.c: Regenerate.
7878
7879         * linux-thread-db.c (class thread_db_target): Add method
7880         thread_info_to_thread_handle.
7881         (thread_db_target::thread_info_to_thread_handle): Define.
7882         * remote.c (class remote_target): Add new method
7883         thread_info_to_thread_handle.
7884         (remote_target::thread_info_to_thread_handle): Define.
7885
7886 2019-04-08  Pedro Alves  <palves@redhat.com>
7887
7888         * common/common-exceptions.c (throw_exception): Don't create
7889         named object to throw; throw directly.
7890         (throw_it): Likewise.  Don't initialize gdb_exception::message
7891         here, with new; pass FMT and AP to the ctor instead.
7892         * common/common-exceptions.h: Include <string>.
7893         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7894         const char *, va_list)): New ctor.  Use std::make_shared.
7895         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7896         errors)): Delete.
7897         (gdb_exception_error::gdb_exception_error(enum errors, const char
7898         *, va_list)): New.
7899         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7900         Add assertion.
7901         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7902         errors)): Delete.
7903         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7904         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7905         Add assertion.
7906
7907 2019-04-08  Tom Tromey  <tom@tromey.com>
7908
7909         * valops.c (value_rtti_indirect_type): Replace throw_exception
7910         with throw.
7911         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7912         with throw.
7913         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7914         throw.
7915         * target.c (target_translate_tls_address): Replace throw_exception
7916         with throw.
7917         * stack.c (frame_apply_command_count): Replace throw_exception
7918         with throw.
7919         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7920         throw.
7921         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7922         with throw.
7923         * rs6000-tdep.c (rs6000_frame_cache)
7924         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7925         * remote.c: Replace throw_exception with throw.
7926         * record-full.c (record_full_message, record_full_wait_1)
7927         (record_full_restore): Replace throw_exception with throw.
7928         * record-btrace.c:
7929         (get_thread_current_frame_id, record_btrace_start_replaying)
7930         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7931         (cmd_record_btrace_start): Replace throw_exception with throw.
7932         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7933         throw.
7934         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7935         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7936         * linespec.c:
7937         (find_linespec_symbols): Replace throw_exception with throw.
7938         * infrun.c (displaced_step_prepare, resume): Replace
7939         throw_exception with throw.
7940         * infcmd.c (post_create_inferior): Replace throw_exception with
7941         throw.
7942         * inf-loop.c (inferior_event_handler): Replace throw_exception
7943         with throw.
7944         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7945         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7946         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7947         (get_prev_frame_always, get_frame_pc_if_available)
7948         (get_frame_address_in_block_if_available, get_frame_language):
7949         Replace throw_exception with throw.
7950         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7951         throw_exception with throw.
7952         * eval.c (fetch_subexp_value, evaluate_var_value)
7953         (evaluate_funcall, evaluate_subexp_standard): Replace
7954         throw_exception with throw.
7955         * dwarf2loc.c (call_site_find_chain)
7956         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7957         Replace throw_exception with throw.
7958         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7959         with throw.
7960         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7961         throw.
7962         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7963         * completer.c (complete_line_internal): Replace throw_exception
7964         with throw.
7965         * compile/compile-object-run.c (compile_object_run): Replace
7966         throw_exception with throw.
7967         * cli/cli-script.c (process_next_line): Replace throw_exception
7968         with throw.
7969         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7970         (btrace_enable, btrace_maint_update_pt_packets): Replace
7971         throw_exception with throw.
7972         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7973         throw_exception with throw.
7974         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7975         throw_exception with throw.
7976         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7977         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7978         * aarch64-tdep.c (aarch64_make_prologue_cache)
7979         (aarch64_make_stub_cache): Replace throw_exception with throw.
7980
7981 2019-04-08  Tom Tromey  <tom@tromey.com>
7982
7983         * common/common-exceptions.c (throw_exception): Rename from
7984         throw_exception_cxx.  Remove old copy.  Make argument const.
7985         (throw_it): Create and throw exception objects directly.
7986         * common/common-exceptions.h (throw_exception): Make argument
7987         const.
7988         (struct gdb_exception_error): Add constructor.
7989         (struct gdb_exception_quit): Add constructor.
7990
7991 2019-04-08  Tom Tromey  <tom@tromey.com>
7992
7993         * common/common-exceptions.h (exception_rethrow): Don't declare.
7994         (TRY_SJLJ): Update comment.
7995         (TRY, CATCH, END_CATCH): Remove.
7996         * common/common-exceptions.c (exception_rethrow): Remove.
7997
7998 2019-04-08  Tom Tromey  <tom@tromey.com>
7999
8000         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8001         Remove.
8002         (gdb_exception_error): Rename from
8003         gdb_exception_RETURN_MASK_ERROR.
8004         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8005         (gdb_quit_bad_alloc): Update.
8006         * aarch64-tdep.c: Update.
8007         * ada-lang.c: Update.
8008         * ada-typeprint.c: Update.
8009         * ada-valprint.c: Update.
8010         * amd64-tdep.c: Update.
8011         * arch-utils.c: Update.
8012         * break-catch-throw.c: Update.
8013         * breakpoint.c: Update.
8014         * btrace.c: Update.
8015         * c-varobj.c: Update.
8016         * cli/cli-cmds.c: Update.
8017         * cli/cli-interp.c: Update.
8018         * cli/cli-script.c: Update.
8019         * common/common-exceptions.c: Update.
8020         * common/new-op.c: Update.
8021         * common/selftest.c: Update.
8022         * compile/compile-c-symbols.c: Update.
8023         * compile/compile-cplus-symbols.c: Update.
8024         * compile/compile-object-load.c: Update.
8025         * compile/compile-object-run.c: Update.
8026         * completer.c: Update.
8027         * corelow.c: Update.
8028         * cp-abi.c: Update.
8029         * cp-support.c: Update.
8030         * cp-valprint.c: Update.
8031         * darwin-nat.c: Update.
8032         * disasm-selftests.c: Update.
8033         * dtrace-probe.c: Update.
8034         * dwarf-index-cache.c: Update.
8035         * dwarf-index-write.c: Update.
8036         * dwarf2-frame-tailcall.c: Update.
8037         * dwarf2-frame.c: Update.
8038         * dwarf2loc.c: Update.
8039         * dwarf2read.c: Update.
8040         * eval.c: Update.
8041         * event-loop.c: Update.
8042         * event-top.c: Update.
8043         * exec.c: Update.
8044         * f-valprint.c: Update.
8045         * fbsd-tdep.c: Update.
8046         * frame-unwind.c: Update.
8047         * frame.c: Update.
8048         * gdbtypes.c: Update.
8049         * gnu-v3-abi.c: Update.
8050         * guile/guile-internal.h: Update.
8051         * guile/scm-block.c: Update.
8052         * guile/scm-breakpoint.c: Update.
8053         * guile/scm-cmd.c: Update.
8054         * guile/scm-disasm.c: Update.
8055         * guile/scm-frame.c: Update.
8056         * guile/scm-lazy-string.c: Update.
8057         * guile/scm-math.c: Update.
8058         * guile/scm-param.c: Update.
8059         * guile/scm-ports.c: Update.
8060         * guile/scm-pretty-print.c: Update.
8061         * guile/scm-symbol.c: Update.
8062         * guile/scm-symtab.c: Update.
8063         * guile/scm-type.c: Update.
8064         * guile/scm-value.c: Update.
8065         * i386-linux-tdep.c: Update.
8066         * i386-tdep.c: Update.
8067         * inf-loop.c: Update.
8068         * infcall.c: Update.
8069         * infcmd.c: Update.
8070         * infrun.c: Update.
8071         * jit.c: Update.
8072         * language.c: Update.
8073         * linespec.c: Update.
8074         * linux-fork.c: Update.
8075         * linux-nat.c: Update.
8076         * linux-tdep.c: Update.
8077         * linux-thread-db.c: Update.
8078         * main.c: Update.
8079         * mi/mi-cmd-break.c: Update.
8080         * mi/mi-cmd-stack.c: Update.
8081         * mi/mi-interp.c: Update.
8082         * mi/mi-main.c: Update.
8083         * objc-lang.c: Update.
8084         * p-valprint.c: Update.
8085         * parse.c: Update.
8086         * ppc-linux-tdep.c: Update.
8087         * printcmd.c: Update.
8088         * python/py-arch.c: Update.
8089         * python/py-breakpoint.c: Update.
8090         * python/py-cmd.c: Update.
8091         * python/py-finishbreakpoint.c: Update.
8092         * python/py-frame.c: Update.
8093         * python/py-framefilter.c: Update.
8094         * python/py-gdb-readline.c: Update.
8095         * python/py-inferior.c: Update.
8096         * python/py-infthread.c: Update.
8097         * python/py-lazy-string.c: Update.
8098         * python/py-linetable.c: Update.
8099         * python/py-objfile.c: Update.
8100         * python/py-param.c: Update.
8101         * python/py-prettyprint.c: Update.
8102         * python/py-progspace.c: Update.
8103         * python/py-record-btrace.c: Update.
8104         * python/py-record.c: Update.
8105         * python/py-symbol.c: Update.
8106         * python/py-type.c: Update.
8107         * python/py-unwind.c: Update.
8108         * python/py-utils.c: Update.
8109         * python/py-value.c: Update.
8110         * python/python.c: Update.
8111         * record-btrace.c: Update.
8112         * record-full.c: Update.
8113         * remote-fileio.c: Update.
8114         * remote.c: Update.
8115         * riscv-tdep.c: Update.
8116         * rs6000-aix-tdep.c: Update.
8117         * rs6000-tdep.c: Update.
8118         * rust-exp.y: Update.
8119         * rust-lang.c: Update.
8120         * s390-tdep.c: Update.
8121         * selftest-arch.c: Update.
8122         * solib-dsbt.c: Update.
8123         * solib-frv.c: Update.
8124         * solib-spu.c: Update.
8125         * solib-svr4.c: Update.
8126         * solib.c: Update.
8127         * sparc64-linux-tdep.c: Update.
8128         * stack.c: Update.
8129         * symfile-mem.c: Update.
8130         * symmisc.c: Update.
8131         * target.c: Update.
8132         * thread.c: Update.
8133         * top.c: Update.
8134         * tracefile-tfile.c: Update.
8135         * tui/tui.c: Update.
8136         * typeprint.c: Update.
8137         * unittests/cli-utils-selftests.c: Update.
8138         * unittests/parse-connection-spec-selftests.c: Update.
8139         * valops.c: Update.
8140         * valprint.c: Update.
8141         * value.c: Update.
8142         * varobj.c: Update.
8143         * windows-nat.c: Update.
8144         * x86-linux-nat.c: Update.
8145         * xml-support.c: Update.
8146
8147 2019-04-08  Tom Tromey  <tom@tromey.com>
8148
8149         * xml-support.c: Use C++ exception handling.
8150         * x86-linux-nat.c: Use C++ exception handling.
8151         * windows-nat.c: Use C++ exception handling.
8152         * varobj.c: Use C++ exception handling.
8153         * value.c: Use C++ exception handling.
8154         * valprint.c: Use C++ exception handling.
8155         * valops.c: Use C++ exception handling.
8156         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8157         handling.
8158         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8159         * typeprint.c: Use C++ exception handling.
8160         * tui/tui.c: Use C++ exception handling.
8161         * tracefile-tfile.c: Use C++ exception handling.
8162         * top.c: Use C++ exception handling.
8163         * thread.c: Use C++ exception handling.
8164         * target.c: Use C++ exception handling.
8165         * symmisc.c: Use C++ exception handling.
8166         * symfile-mem.c: Use C++ exception handling.
8167         * stack.c: Use C++ exception handling.
8168         * sparc64-linux-tdep.c: Use C++ exception handling.
8169         * solib.c: Use C++ exception handling.
8170         * solib-svr4.c: Use C++ exception handling.
8171         * solib-spu.c: Use C++ exception handling.
8172         * solib-frv.c: Use C++ exception handling.
8173         * solib-dsbt.c: Use C++ exception handling.
8174         * selftest-arch.c: Use C++ exception handling.
8175         * s390-tdep.c: Use C++ exception handling.
8176         * rust-lang.c: Use C++ exception handling.
8177         * rust-exp.y: Use C++ exception handling.
8178         * rs6000-tdep.c: Use C++ exception handling.
8179         * rs6000-aix-tdep.c: Use C++ exception handling.
8180         * riscv-tdep.c: Use C++ exception handling.
8181         * remote.c: Use C++ exception handling.
8182         * remote-fileio.c: Use C++ exception handling.
8183         * record-full.c: Use C++ exception handling.
8184         * record-btrace.c: Use C++ exception handling.
8185         * python/python.c: Use C++ exception handling.
8186         * python/py-value.c: Use C++ exception handling.
8187         * python/py-utils.c: Use C++ exception handling.
8188         * python/py-unwind.c: Use C++ exception handling.
8189         * python/py-type.c: Use C++ exception handling.
8190         * python/py-symbol.c: Use C++ exception handling.
8191         * python/py-record.c: Use C++ exception handling.
8192         * python/py-record-btrace.c: Use C++ exception handling.
8193         * python/py-progspace.c: Use C++ exception handling.
8194         * python/py-prettyprint.c: Use C++ exception handling.
8195         * python/py-param.c: Use C++ exception handling.
8196         * python/py-objfile.c: Use C++ exception handling.
8197         * python/py-linetable.c: Use C++ exception handling.
8198         * python/py-lazy-string.c: Use C++ exception handling.
8199         * python/py-infthread.c: Use C++ exception handling.
8200         * python/py-inferior.c: Use C++ exception handling.
8201         * python/py-gdb-readline.c: Use C++ exception handling.
8202         * python/py-framefilter.c: Use C++ exception handling.
8203         * python/py-frame.c: Use C++ exception handling.
8204         * python/py-finishbreakpoint.c: Use C++ exception handling.
8205         * python/py-cmd.c: Use C++ exception handling.
8206         * python/py-breakpoint.c: Use C++ exception handling.
8207         * python/py-arch.c: Use C++ exception handling.
8208         * printcmd.c: Use C++ exception handling.
8209         * ppc-linux-tdep.c: Use C++ exception handling.
8210         * parse.c: Use C++ exception handling.
8211         * p-valprint.c: Use C++ exception handling.
8212         * objc-lang.c: Use C++ exception handling.
8213         * mi/mi-main.c: Use C++ exception handling.
8214         * mi/mi-interp.c: Use C++ exception handling.
8215         * mi/mi-cmd-stack.c: Use C++ exception handling.
8216         * mi/mi-cmd-break.c: Use C++ exception handling.
8217         * main.c: Use C++ exception handling.
8218         * linux-thread-db.c: Use C++ exception handling.
8219         * linux-tdep.c: Use C++ exception handling.
8220         * linux-nat.c: Use C++ exception handling.
8221         * linux-fork.c: Use C++ exception handling.
8222         * linespec.c: Use C++ exception handling.
8223         * language.c: Use C++ exception handling.
8224         * jit.c: Use C++ exception handling.
8225         * infrun.c: Use C++ exception handling.
8226         * infcmd.c: Use C++ exception handling.
8227         * infcall.c: Use C++ exception handling.
8228         * inf-loop.c: Use C++ exception handling.
8229         * i386-tdep.c: Use C++ exception handling.
8230         * i386-linux-tdep.c: Use C++ exception handling.
8231         * guile/scm-value.c: Use C++ exception handling.
8232         * guile/scm-type.c: Use C++ exception handling.
8233         * guile/scm-symtab.c: Use C++ exception handling.
8234         * guile/scm-symbol.c: Use C++ exception handling.
8235         * guile/scm-pretty-print.c: Use C++ exception handling.
8236         * guile/scm-ports.c: Use C++ exception handling.
8237         * guile/scm-param.c: Use C++ exception handling.
8238         * guile/scm-math.c: Use C++ exception handling.
8239         * guile/scm-lazy-string.c: Use C++ exception handling.
8240         * guile/scm-frame.c: Use C++ exception handling.
8241         * guile/scm-disasm.c: Use C++ exception handling.
8242         * guile/scm-cmd.c: Use C++ exception handling.
8243         * guile/scm-breakpoint.c: Use C++ exception handling.
8244         * guile/scm-block.c: Use C++ exception handling.
8245         * guile/guile-internal.h: Use C++ exception handling.
8246         * gnu-v3-abi.c: Use C++ exception handling.
8247         * gdbtypes.c: Use C++ exception handling.
8248         * frame.c: Use C++ exception handling.
8249         * frame-unwind.c: Use C++ exception handling.
8250         * fbsd-tdep.c: Use C++ exception handling.
8251         * f-valprint.c: Use C++ exception handling.
8252         * exec.c: Use C++ exception handling.
8253         * event-top.c: Use C++ exception handling.
8254         * event-loop.c: Use C++ exception handling.
8255         * eval.c: Use C++ exception handling.
8256         * dwarf2read.c: Use C++ exception handling.
8257         * dwarf2loc.c: Use C++ exception handling.
8258         * dwarf2-frame.c: Use C++ exception handling.
8259         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8260         * dwarf-index-write.c: Use C++ exception handling.
8261         * dwarf-index-cache.c: Use C++ exception handling.
8262         * dtrace-probe.c: Use C++ exception handling.
8263         * disasm-selftests.c: Use C++ exception handling.
8264         * darwin-nat.c: Use C++ exception handling.
8265         * cp-valprint.c: Use C++ exception handling.
8266         * cp-support.c: Use C++ exception handling.
8267         * cp-abi.c: Use C++ exception handling.
8268         * corelow.c: Use C++ exception handling.
8269         * completer.c: Use C++ exception handling.
8270         * compile/compile-object-run.c: Use C++ exception handling.
8271         * compile/compile-object-load.c: Use C++ exception handling.
8272         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8273         * compile/compile-c-symbols.c: Use C++ exception handling.
8274         * common/selftest.c: Use C++ exception handling.
8275         * common/new-op.c: Use C++ exception handling.
8276         * cli/cli-script.c: Use C++ exception handling.
8277         * cli/cli-interp.c: Use C++ exception handling.
8278         * cli/cli-cmds.c: Use C++ exception handling.
8279         * c-varobj.c: Use C++ exception handling.
8280         * btrace.c: Use C++ exception handling.
8281         * breakpoint.c: Use C++ exception handling.
8282         * break-catch-throw.c: Use C++ exception handling.
8283         * arch-utils.c: Use C++ exception handling.
8284         * amd64-tdep.c: Use C++ exception handling.
8285         * ada-valprint.c: Use C++ exception handling.
8286         * ada-typeprint.c: Use C++ exception handling.
8287         * ada-lang.c: Use C++ exception handling.
8288         * aarch64-tdep.c: Use C++ exception handling.
8289
8290 2019-04-08  Tom Tromey  <tom@tromey.com>
8291
8292         * xml-support.c (gdb_xml_parser::parse): Update.
8293         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8294         * value.c (show_convenience): Update.
8295         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8296         (test_parse_flags_qcs): Update.
8297         * thread.c (thr_try_catch_cmd): Update.
8298         * target.c (target_translate_tls_address): Update.
8299         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8300         (info_frame_command_core, frame_apply_command_count): Update.
8301         * rust-exp.y (rust_lex_exception_test): Update.
8302         * riscv-tdep.c (riscv_print_one_register_info): Update.
8303         * remote.c (remote_target::enable_btrace): Update.
8304         * record-btrace.c (record_btrace_enable_warn): Update.
8305         * python/py-utils.c (gdbpy_convert_exception): Update.
8306         * printcmd.c (do_one_display, print_variable_and_value): Update.
8307         * mi/mi-main.c (mi_print_exception): Update.
8308         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8309         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8310         * linux-nat.c (linux_nat_target::attach): Update.
8311         * linux-fork.c (class scoped_switch_fork_info): Update.
8312         * infrun.c (displaced_step_prepare): Update.
8313         * infcall.c (call_function_by_hand_dummy): Update.
8314         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8315         * gnu-v3-abi.c (print_one_vtable): Update.
8316         * frame.c (get_prev_frame_always): Update.
8317         * f-valprint.c (info_common_command_for_block): Update.
8318         * exec.c (try_open_exec_file): Update.
8319         * exceptions.c (print_exception, exception_print)
8320         (exception_fprintf, exception_print_same): Update.
8321         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8322         * dwarf-index-cache.c (index_cache::store)
8323         (index_cache::lookup_gdb_index): Update.
8324         * darwin-nat.c (maybe_cache_shell): Update.
8325         * cp-valprint.c (cp_print_value_fields): Update.
8326         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8327         (gcc_cplus_symbol_address): Update.
8328         * compile/compile-c-symbols.c (gcc_convert_symbol)
8329         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8330         * common/selftest.c: Update.
8331         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8332         a std::string.
8333         (exception_try_scope_entry, exception_try_scope_exit): Don't
8334         declare.
8335         (struct exception_try_scope): Remove.
8336         (TRY): Don't use exception_try_scope.
8337         (struct gdb_exception): Add constructor, operator=.
8338         <what>: New method.
8339         (struct gdb_exception_RETURN_MASK_ALL)
8340         (struct gdb_exception_RETURN_MASK_ERROR)
8341         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8342         (struct gdb_quit_bad_alloc): Update.
8343         * common/common-exceptions.c (exception_none): Change
8344         initializer.
8345         (struct catcher) <state, exception>: Initialize inline.
8346         <prev>: Remove member.
8347         (current_catcher): Remove.
8348         (catchers): New global.
8349         (exceptions_state_mc_init): Simplify.
8350         (catcher_pop): Remove.
8351         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8352         (try_scope_depth, exception_try_scope_entry)
8353         (exception_try_scope_exit): Remove.
8354         (throw_exception_sjlj): Update.
8355         (exception_messages, exception_messages_size): Remove.
8356         (throw_it): Simplify.
8357         (gdb_exception_sliced_copy): Remove.
8358         (throw_exception_cxx): Update.
8359         * cli/cli-script.c (script_from_file): Update.
8360         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8361         Update.
8362         * ada-valprint.c (ada_val_print): Update.
8363         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8364         (create_excep_cond_exprs): Update.
8365
8366 2019-04-08  Tom Tromey  <tom@tromey.com>
8367
8368         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8369         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8370         (TRY, CATCH, END_CATCH): Remove some definitions.
8371         * common/common-exceptions.c: Don't use GDB_XCPT.
8372         (catcher_list_size): Remove.
8373         (throw_exception, throw_it): Simplify.
8374
8375 2019-04-05  Tom Tromey  <tom@tromey.com>
8376
8377         Revert the header-sorting patch.
8378         * ft32-tdep.c: Revert.
8379         * frv-tdep.c: Revert.
8380         * frv-linux-tdep.c: Revert.
8381         * frame.c: Revert.
8382         * frame-unwind.c: Revert.
8383         * frame-base.c: Revert.
8384         * fork-child.c: Revert.
8385         * findvar.c: Revert.
8386         * findcmd.c: Revert.
8387         * filesystem.c: Revert.
8388         * filename-seen-cache.h: Revert.
8389         * filename-seen-cache.c: Revert.
8390         * fbsd-tdep.c: Revert.
8391         * fbsd-nat.h: Revert.
8392         * fbsd-nat.c: Revert.
8393         * f-valprint.c: Revert.
8394         * f-typeprint.c: Revert.
8395         * f-lang.c: Revert.
8396         * extension.h: Revert.
8397         * extension.c: Revert.
8398         * extension-priv.h: Revert.
8399         * expprint.c: Revert.
8400         * exec.h: Revert.
8401         * exec.c: Revert.
8402         * exceptions.c: Revert.
8403         * event-top.c: Revert.
8404         * event-loop.c: Revert.
8405         * eval.c: Revert.
8406         * elfread.c: Revert.
8407         * dwarf2read.h: Revert.
8408         * dwarf2read.c: Revert.
8409         * dwarf2loc.c: Revert.
8410         * dwarf2expr.h: Revert.
8411         * dwarf2expr.c: Revert.
8412         * dwarf2-frame.c: Revert.
8413         * dwarf2-frame-tailcall.c: Revert.
8414         * dwarf-index-write.h: Revert.
8415         * dwarf-index-write.c: Revert.
8416         * dwarf-index-common.c: Revert.
8417         * dwarf-index-cache.h: Revert.
8418         * dwarf-index-cache.c: Revert.
8419         * dummy-frame.c: Revert.
8420         * dtrace-probe.c: Revert.
8421         * disasm.h: Revert.
8422         * disasm.c: Revert.
8423         * disasm-selftests.c: Revert.
8424         * dictionary.c: Revert.
8425         * dicos-tdep.c: Revert.
8426         * demangle.c: Revert.
8427         * dcache.h: Revert.
8428         * dcache.c: Revert.
8429         * darwin-nat.h: Revert.
8430         * darwin-nat.c: Revert.
8431         * darwin-nat-info.c: Revert.
8432         * d-valprint.c: Revert.
8433         * d-namespace.c: Revert.
8434         * d-lang.c: Revert.
8435         * ctf.c: Revert.
8436         * csky-tdep.c: Revert.
8437         * csky-linux-tdep.c: Revert.
8438         * cris-tdep.c: Revert.
8439         * cris-linux-tdep.c: Revert.
8440         * cp-valprint.c: Revert.
8441         * cp-support.c: Revert.
8442         * cp-namespace.c: Revert.
8443         * cp-abi.c: Revert.
8444         * corelow.c: Revert.
8445         * corefile.c: Revert.
8446         * continuations.c: Revert.
8447         * completer.h: Revert.
8448         * completer.c: Revert.
8449         * complaints.c: Revert.
8450         * coffread.c: Revert.
8451         * coff-pe-read.c: Revert.
8452         * cli-out.h: Revert.
8453         * cli-out.c: Revert.
8454         * charset.c: Revert.
8455         * c-varobj.c: Revert.
8456         * c-valprint.c: Revert.
8457         * c-typeprint.c: Revert.
8458         * c-lang.c: Revert.
8459         * buildsym.c: Revert.
8460         * buildsym-legacy.c: Revert.
8461         * build-id.h: Revert.
8462         * build-id.c: Revert.
8463         * btrace.c: Revert.
8464         * bsd-uthread.c: Revert.
8465         * breakpoint.h: Revert.
8466         * breakpoint.c: Revert.
8467         * break-catch-throw.c: Revert.
8468         * break-catch-syscall.c: Revert.
8469         * break-catch-sig.c: Revert.
8470         * blockframe.c: Revert.
8471         * block.c: Revert.
8472         * bfin-tdep.c: Revert.
8473         * bfin-linux-tdep.c: Revert.
8474         * bfd-target.c: Revert.
8475         * bcache.c: Revert.
8476         * ax-general.c: Revert.
8477         * ax-gdb.h: Revert.
8478         * ax-gdb.c: Revert.
8479         * avr-tdep.c: Revert.
8480         * auxv.c: Revert.
8481         * auto-load.c: Revert.
8482         * arm-wince-tdep.c: Revert.
8483         * arm-tdep.c: Revert.
8484         * arm-symbian-tdep.c: Revert.
8485         * arm-pikeos-tdep.c: Revert.
8486         * arm-obsd-tdep.c: Revert.
8487         * arm-nbsd-tdep.c: Revert.
8488         * arm-nbsd-nat.c: Revert.
8489         * arm-linux-tdep.c: Revert.
8490         * arm-linux-nat.c: Revert.
8491         * arm-fbsd-tdep.c: Revert.
8492         * arm-fbsd-nat.c: Revert.
8493         * arm-bsd-tdep.c: Revert.
8494         * arch-utils.c: Revert.
8495         * arc-tdep.c: Revert.
8496         * arc-newlib-tdep.c: Revert.
8497         * annotate.h: Revert.
8498         * annotate.c: Revert.
8499         * amd64-windows-tdep.c: Revert.
8500         * amd64-windows-nat.c: Revert.
8501         * amd64-tdep.c: Revert.
8502         * amd64-sol2-tdep.c: Revert.
8503         * amd64-obsd-tdep.c: Revert.
8504         * amd64-obsd-nat.c: Revert.
8505         * amd64-nbsd-tdep.c: Revert.
8506         * amd64-nbsd-nat.c: Revert.
8507         * amd64-nat.c: Revert.
8508         * amd64-linux-tdep.c: Revert.
8509         * amd64-linux-nat.c: Revert.
8510         * amd64-fbsd-tdep.c: Revert.
8511         * amd64-fbsd-nat.c: Revert.
8512         * amd64-dicos-tdep.c: Revert.
8513         * amd64-darwin-tdep.c: Revert.
8514         * amd64-bsd-nat.c: Revert.
8515         * alpha-tdep.c: Revert.
8516         * alpha-obsd-tdep.c: Revert.
8517         * alpha-nbsd-tdep.c: Revert.
8518         * alpha-mdebug-tdep.c: Revert.
8519         * alpha-linux-tdep.c: Revert.
8520         * alpha-linux-nat.c: Revert.
8521         * alpha-bsd-tdep.c: Revert.
8522         * alpha-bsd-nat.c: Revert.
8523         * aix-thread.c: Revert.
8524         * agent.c: Revert.
8525         * addrmap.c: Revert.
8526         * ada-varobj.c: Revert.
8527         * ada-valprint.c: Revert.
8528         * ada-typeprint.c: Revert.
8529         * ada-tasks.c: Revert.
8530         * ada-lang.c: Revert.
8531         * aarch64-tdep.c: Revert.
8532         * aarch64-ravenscar-thread.c: Revert.
8533         * aarch64-newlib-tdep.c: Revert.
8534         * aarch64-linux-tdep.c: Revert.
8535         * aarch64-linux-nat.c: Revert.
8536         * aarch64-fbsd-tdep.c: Revert.
8537         * aarch64-fbsd-nat.c: Revert.
8538         * aarch32-linux-nat.c: Revert.
8539
8540 2019-04-05  Tom Tromey  <tom@tromey.com>
8541
8542         * ft32-tdep.c: Sort headers.
8543         * frv-tdep.c: Sort headers.
8544         * frv-linux-tdep.c: Sort headers.
8545         * frame.c: Sort headers.
8546         * frame-unwind.c: Sort headers.
8547         * frame-base.c: Sort headers.
8548         * fork-child.c: Sort headers.
8549         * findvar.c: Sort headers.
8550         * findcmd.c: Sort headers.
8551         * filesystem.c: Sort headers.
8552         * filename-seen-cache.h: Sort headers.
8553         * filename-seen-cache.c: Sort headers.
8554         * fbsd-tdep.c: Sort headers.
8555         * fbsd-nat.h: Sort headers.
8556         * fbsd-nat.c: Sort headers.
8557         * f-valprint.c: Sort headers.
8558         * f-typeprint.c: Sort headers.
8559         * f-lang.c: Sort headers.
8560         * extension.h: Sort headers.
8561         * extension.c: Sort headers.
8562         * extension-priv.h: Sort headers.
8563         * expprint.c: Sort headers.
8564         * exec.h: Sort headers.
8565         * exec.c: Sort headers.
8566         * exceptions.c: Sort headers.
8567         * event-top.c: Sort headers.
8568         * event-loop.c: Sort headers.
8569         * eval.c: Sort headers.
8570         * elfread.c: Sort headers.
8571         * dwarf2read.h: Sort headers.
8572         * dwarf2read.c: Sort headers.
8573         * dwarf2loc.c: Sort headers.
8574         * dwarf2expr.h: Sort headers.
8575         * dwarf2expr.c: Sort headers.
8576         * dwarf2-frame.c: Sort headers.
8577         * dwarf2-frame-tailcall.c: Sort headers.
8578         * dwarf-index-write.h: Sort headers.
8579         * dwarf-index-write.c: Sort headers.
8580         * dwarf-index-common.c: Sort headers.
8581         * dwarf-index-cache.h: Sort headers.
8582         * dwarf-index-cache.c: Sort headers.
8583         * dummy-frame.c: Sort headers.
8584         * dtrace-probe.c: Sort headers.
8585         * disasm.h: Sort headers.
8586         * disasm.c: Sort headers.
8587         * disasm-selftests.c: Sort headers.
8588         * dictionary.c: Sort headers.
8589         * dicos-tdep.c: Sort headers.
8590         * demangle.c: Sort headers.
8591         * dcache.h: Sort headers.
8592         * dcache.c: Sort headers.
8593         * darwin-nat.h: Sort headers.
8594         * darwin-nat.c: Sort headers.
8595         * darwin-nat-info.c: Sort headers.
8596         * d-valprint.c: Sort headers.
8597         * d-namespace.c: Sort headers.
8598         * d-lang.c: Sort headers.
8599         * ctf.c: Sort headers.
8600         * csky-tdep.c: Sort headers.
8601         * csky-linux-tdep.c: Sort headers.
8602         * cris-tdep.c: Sort headers.
8603         * cris-linux-tdep.c: Sort headers.
8604         * cp-valprint.c: Sort headers.
8605         * cp-support.c: Sort headers.
8606         * cp-namespace.c: Sort headers.
8607         * cp-abi.c: Sort headers.
8608         * corelow.c: Sort headers.
8609         * corefile.c: Sort headers.
8610         * continuations.c: Sort headers.
8611         * completer.h: Sort headers.
8612         * completer.c: Sort headers.
8613         * complaints.c: Sort headers.
8614         * coffread.c: Sort headers.
8615         * coff-pe-read.c: Sort headers.
8616         * cli-out.h: Sort headers.
8617         * cli-out.c: Sort headers.
8618         * charset.c: Sort headers.
8619         * c-varobj.c: Sort headers.
8620         * c-valprint.c: Sort headers.
8621         * c-typeprint.c: Sort headers.
8622         * c-lang.c: Sort headers.
8623         * buildsym.c: Sort headers.
8624         * buildsym-legacy.c: Sort headers.
8625         * build-id.h: Sort headers.
8626         * build-id.c: Sort headers.
8627         * btrace.c: Sort headers.
8628         * bsd-uthread.c: Sort headers.
8629         * breakpoint.h: Sort headers.
8630         * breakpoint.c: Sort headers.
8631         * break-catch-throw.c: Sort headers.
8632         * break-catch-syscall.c: Sort headers.
8633         * break-catch-sig.c: Sort headers.
8634         * blockframe.c: Sort headers.
8635         * block.c: Sort headers.
8636         * bfin-tdep.c: Sort headers.
8637         * bfin-linux-tdep.c: Sort headers.
8638         * bfd-target.c: Sort headers.
8639         * bcache.c: Sort headers.
8640         * ax-general.c: Sort headers.
8641         * ax-gdb.h: Sort headers.
8642         * ax-gdb.c: Sort headers.
8643         * avr-tdep.c: Sort headers.
8644         * auxv.c: Sort headers.
8645         * auto-load.c: Sort headers.
8646         * arm-wince-tdep.c: Sort headers.
8647         * arm-tdep.c: Sort headers.
8648         * arm-symbian-tdep.c: Sort headers.
8649         * arm-pikeos-tdep.c: Sort headers.
8650         * arm-obsd-tdep.c: Sort headers.
8651         * arm-nbsd-tdep.c: Sort headers.
8652         * arm-nbsd-nat.c: Sort headers.
8653         * arm-linux-tdep.c: Sort headers.
8654         * arm-linux-nat.c: Sort headers.
8655         * arm-fbsd-tdep.c: Sort headers.
8656         * arm-fbsd-nat.c: Sort headers.
8657         * arm-bsd-tdep.c: Sort headers.
8658         * arch-utils.c: Sort headers.
8659         * arc-tdep.c: Sort headers.
8660         * arc-newlib-tdep.c: Sort headers.
8661         * annotate.h: Sort headers.
8662         * annotate.c: Sort headers.
8663         * amd64-windows-tdep.c: Sort headers.
8664         * amd64-windows-nat.c: Sort headers.
8665         * amd64-tdep.c: Sort headers.
8666         * amd64-sol2-tdep.c: Sort headers.
8667         * amd64-obsd-tdep.c: Sort headers.
8668         * amd64-obsd-nat.c: Sort headers.
8669         * amd64-nbsd-tdep.c: Sort headers.
8670         * amd64-nbsd-nat.c: Sort headers.
8671         * amd64-nat.c: Sort headers.
8672         * amd64-linux-tdep.c: Sort headers.
8673         * amd64-linux-nat.c: Sort headers.
8674         * amd64-fbsd-tdep.c: Sort headers.
8675         * amd64-fbsd-nat.c: Sort headers.
8676         * amd64-dicos-tdep.c: Sort headers.
8677         * amd64-darwin-tdep.c: Sort headers.
8678         * amd64-bsd-nat.c: Sort headers.
8679         * alpha-tdep.c: Sort headers.
8680         * alpha-obsd-tdep.c: Sort headers.
8681         * alpha-nbsd-tdep.c: Sort headers.
8682         * alpha-mdebug-tdep.c: Sort headers.
8683         * alpha-linux-tdep.c: Sort headers.
8684         * alpha-linux-nat.c: Sort headers.
8685         * alpha-bsd-tdep.c: Sort headers.
8686         * alpha-bsd-nat.c: Sort headers.
8687         * aix-thread.c: Sort headers.
8688         * agent.c: Sort headers.
8689         * addrmap.c: Sort headers.
8690         * ada-varobj.c: Sort headers.
8691         * ada-valprint.c: Sort headers.
8692         * ada-typeprint.c: Sort headers.
8693         * ada-tasks.c: Sort headers.
8694         * ada-lang.c: Sort headers.
8695         * aarch64-tdep.c: Sort headers.
8696         * aarch64-ravenscar-thread.c: Sort headers.
8697         * aarch64-newlib-tdep.c: Sort headers.
8698         * aarch64-linux-tdep.c: Sort headers.
8699         * aarch64-linux-nat.c: Sort headers.
8700         * aarch64-fbsd-tdep.c: Sort headers.
8701         * aarch64-fbsd-nat.c: Sort headers.
8702         * aarch32-linux-nat.c: Sort headers.
8703
8704 2019-04-04  Tom Tromey  <tom@tromey.com>
8705
8706         * varobj.c (varobj_create): Update.
8707         * rust-exp.y (struct rust_parser) <update_innermost_block,
8708         lookup_symbol>: New methods.
8709         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8710         Rename.
8711         (rust_parser::rust_lookup_type)
8712         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8713         * printcmd.c (display_command, do_one_display): Update.
8714         * parser-defs.h (struct parser_state) <parser_state>: Add
8715         "tracker" parameter.
8716         (block_tracker): New member.
8717         (class innermost_block_tracker) <innermost_block_tracker>: Add
8718         "types" parameter.
8719         <reset>: Remove method.
8720         (innermost_block): Don't declare.
8721         (null_post_parser): Update.
8722         * parse.c (innermost_block): Remove global.
8723         (write_dollar_variable): Update.
8724         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8725         Remove "tracker_types" parameter.
8726         (parse_expression): Add "tracker" parameter.
8727         (parse_expression_for_completion): Update.
8728         (null_post_parser): Add "tracker" parameter.
8729         * p-exp.y: Update rules.
8730         * m2-exp.y: Update rules.
8731         * language.h (struct language_defn) <la_post_parser>: Add
8732         "tracker" parameter.
8733         * go-exp.y: Update rules.
8734         * f-exp.y: Update rules.
8735         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8736         parameter.
8737         * d-exp.y: Update rules.
8738         * c-exp.y: Update rules.
8739         * breakpoint.c (set_breakpoint_condition): Create an
8740         innermost_block_tracker.
8741         (watch_command_1): Likewise.
8742         * ada-lang.c (resolve): Add "tracker" parameter.
8743         (resolve_subexp): Likewise.
8744         * ada-exp.y (write_var_from_sym): Update.
8745
8746 2019-04-04  Tom Tromey  <tom@tromey.com>
8747
8748         * type-stack.h: New file.
8749         * type-stack.c: New file.
8750         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8751         type-stack.h.
8752         (insert_into_type_stack, insert_type, push_type, push_type_int)
8753         (insert_type_address_space, pop_type, pop_type_int)
8754         (pop_typelist, pop_type_stack, append_type_stack)
8755         (push_type_stack, get_type_stack, push_typelist)
8756         (follow_type_instance_flags, follow_types): Don't declare.
8757         * parse.c (type_stack): Remove global.
8758         (parse_exp_in_context): Update.
8759         (insert_into_type_stack, insert_type, push_type, push_type_int)
8760         (insert_type_address_space, pop_type, pop_type_int)
8761         (pop_typelist, pop_type_stack, append_type_stack)
8762         (push_type_stack, get_type_stack, push_typelist)
8763         (follow_type_instance_flags, follow_types): Remove (moved to
8764         type-stack.c).
8765         * f-exp.y (type_stack): New global.
8766         Update rules.
8767         (push_kind_type, f_parse): Update.
8768         * d-exp.y (type_stack): New global.
8769         Update rules.
8770         (d_parse): Update.
8771         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8772         Update rules.
8773         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8774         (HFILES_NO_SRCDIR): Add type-stack.h.
8775
8776 2019-04-04  Tom Tromey  <tom@tromey.com>
8777
8778         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8779         (rust_parser::convert_ast_to_expression, rust_parse)
8780         (rust_lex_test_completion, rust_lex_tests): Update.
8781         * parser-defs.h (struct expr_completion_state): New.
8782         (struct parser_state) <parser_state>: Add completion parameter.
8783         <mark_struct_expression, mark_completion_tag>: New methods.
8784         <parse_completion, m_completion_state>: New members.
8785         (prefixify_expression, null_post_parser): Update.
8786         (mark_struct_expression, mark_completion_tag): Don't declare.
8787         * parse.c (parse_completion, expout_last_struct)
8788         (expout_tag_completion_type, expout_completion_name): Remove
8789         globals.
8790         (parser_state::mark_struct_expression)
8791         (parser_state::mark_completion_tag): Now methods.
8792         (prefixify_expression): Add last_struct parameter.
8793         (prefixify_subexp): Likewise.
8794         (parse_exp_1): Update.
8795         (parse_exp_in_context): Add cstate parameter.  Update.
8796         (parse_expression_for_completion): Create an
8797         expr_completion_state.
8798         (null_post_parser): Add "completion" parameter.
8799         * p-exp.y: Update rules.
8800         (yylex): Update.
8801         * language.h (struct language_defn) <la_post_parser>: Add
8802         "completing" parameter.
8803         * go-exp.y: Update rules.
8804         (lex_one_token): Update.
8805         * expression.h (parse_completion): Don't declare.
8806         * d-exp.y: Update rules.
8807         (lex_one_token): Update rules.
8808         * c-exp.y: Update rules.
8809         (lex_one_token): Update.
8810         * ada-lang.c (resolve): Add "parse_completion" parameter.
8811         (resolve_subexp): Likewise.
8812         (ada_resolve_function): Likewise.
8813
8814 2019-04-04  Tom Tromey  <tom@tromey.com>
8815
8816         * parser-defs.h (struct parser_state) <start_arglist,
8817         end_arglist>: New methods.
8818         <arglist_len, m_funcall_chain>: New members.
8819         (arglist_len, start_arglist, end_arglist): Don't declare.
8820         * parse.c (arglist_len, funcall_chain): Remove global.
8821         (start_arglist, end_arglist): Remove functions.
8822         (parse_exp_in_context): Update.
8823         * p-exp.y: Update rules.
8824         * m2-exp.y: Update rules.
8825         * go-exp.y: Update rules.
8826         * f-exp.y: Update rules.
8827         * d-exp.y: Update rules.
8828         * c-exp.y: Update rules.
8829
8830 2019-04-04  Tom Tromey  <tom@tromey.com>
8831
8832         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8833         lex_operator, push_back>: New methods.
8834         Update all rules.
8835         (rust_parser::lex_hex, lex_escape): Rename and update.
8836         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8837         (rust_parser::lex_operator): Rename and update.
8838         (rust_parser::lex_number, rustyylex, rustyyerror)
8839         (rust_lex_test_init, rust_lex_test_sequence)
8840         (rust_lex_test_push_back, rust_lex_tests): Update.
8841         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8842         parameter.
8843         <lexptr, prev_lexptr>: New members.
8844         (lexptr, prev_lexptr): Don't declare.
8845         * parse.c (lexptr, prev_lexptr): Remove globals.
8846         (parse_exp_in_context): Update.
8847         * p-exp.y (yylex, yyerror): Update.
8848         * m2-exp.y (parse_number, yylex, yyerror): Update.
8849         * go-exp.y (lex_one_token, yyerror): Update.
8850         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8851         * d-exp.y (lex_one_token, yyerror): Update.
8852         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8853         (lex_one_token, yyerror): Update.
8854         * ada-lex.l (YY_INPUT): Update.
8855         (rewind_to_char): Update.
8856         * ada-exp.y (yyerror): Update.
8857
8858 2019-04-04  Tom Tromey  <tom@tromey.com>
8859
8860         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8861         * parser-defs.h (struct parser_state) <parser_state>: Add new
8862         parameter.
8863         <comma_terminates>: New member.
8864         (comma_terminates): Don't declare global.
8865         * parse.c (comma_terminates): Remove global.
8866         (parse_exp_in_context): Update.
8867         * p-exp.y (yylex): Update.
8868         * m2-exp.y (yylex): Update.
8869         * go-exp.y (lex_one_token): Update.
8870         * f-exp.y (yylex): Update.
8871         * d-exp.y (lex_one_token): Update.
8872         * c-exp.y (lex_one_token): Update.
8873         * ada-lex.l: Update.
8874
8875 2019-04-04  Tom Tromey  <tom@tromey.com>
8876
8877         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8878         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8879         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8880         * parser-defs.h (paren_depth): Don't declare.
8881         * parse.c (paren_depth): Remove global.
8882         (parse_exp_in_context): Update.
8883         * p-exp.y (paren_depth): New global.
8884         (pascal_parse): Initialize it.
8885         * m2-exp.y (paren_depth): New global.
8886         (m2_parse): Initialize it.
8887         * go-exp.y (paren_depth): New global.
8888         (go_parse): Initialize it.
8889         * f-exp.y (paren_depth): New global.
8890         (f_parse): Initialize it.
8891         * d-exp.y (paren_depth): New global.
8892         (d_parse): Initialize it.
8893         * c-exp.y (paren_depth): New global.
8894         (c_parse): Initialize it.
8895         * ada-lex.l (paren_depth): New global.
8896         (lexer_init): Initialize it.
8897
8898 2019-04-04  Tom Tromey  <tom@tromey.com>
8899
8900         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8901         (rust_parser::convert_ast_to_type)
8902         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8903         * parser-defs.h (struct parser_state) <parser_state>: Add
8904         parameters.  Initialize new members.
8905         <expression_context_block, expression_context_pc>: New members.
8906         * parse.c (expression_context_block, expression_context_pc):
8907         Remove globals.
8908         (parse_exp_in_context): Update.
8909         * p-exp.y: Update all rules.
8910         (yylex): Update.
8911         * m2-exp.y: Update all rules.
8912         (yylex): Update.
8913         * go-exp.y (yylex): Update.
8914         * f-exp.y (yylex): Update.
8915         * d-exp.y: Update all rules.
8916         (yylex): Update.
8917         * c-exp.y: Update all rules.
8918         (lex_one_token, classify_name, yylex, c_parse): Update.
8919         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8920
8921 2019-04-04  Tom Tromey  <tom@tromey.com>
8922
8923         * gdbarch.h, gdbarch.c: Rebuild.
8924         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8925         * stap-probe.h:
8926         (struct stap_parse_info): Replace "parser_state" with
8927         "expr_builder".
8928         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8929         (parser_state): New class.
8930         * parse.c (expr_builder): Rename.
8931         (expr_builder::release): Rename.
8932         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8933         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8934         (write_exp_elt_longcst, write_exp_elt_floatcst)
8935         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8936         (write_exp_string_vector, write_exp_bitstring)
8937         (write_exp_msymbol, mark_struct_expression)
8938         (write_dollar_variable)
8939         (insert_type_address_space, increase_expout_size): Replace
8940         "parser_state" with "expr_builder".
8941         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8942         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8943         "parser_state" with "expr_builder".
8944
8945 2019-04-04  Tom Tromey  <tom@tromey.com>
8946
8947         * rust-exp.y: Replace "parse_language" with method call.
8948         * p-exp.y:
8949         (yylex): Replace "parse_language" with method call.
8950         * m2-exp.y:
8951         (yylex): Replace "parse_language" with method call.
8952         * go-exp.y (classify_name): Replace "parse_language" with method
8953         call.
8954         * f-exp.y (yylex): Replace "parse_language" with method call.
8955         * d-exp.y (lex_one_token): Replace "parse_language" with method
8956         call.
8957         * c-exp.y:
8958         (lex_one_token, classify_name, yylex): Replace "parse_language"
8959         with method call.
8960         * ada-exp.y (find_primitive_type, type_char)
8961         (type_system_address): Replace "parse_language" with method call.
8962
8963 2019-04-04  Tom Tromey  <tom@tromey.com>
8964
8965         * rust-exp.y: Replace "parse_gdbarch" with method call.
8966         * parse.c (write_dollar_variable, insert_type_address_space):
8967         Replace "parse_gdbarch" with method call.
8968         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8969         call.
8970         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8971         call.
8972         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8973         "parse_gdbarch" with method call.
8974         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8975         with method call.
8976         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8977         "parse_gdbarch" with method call.
8978         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8979         "parse_gdbarch" with method call.
8980         * c-exp.y (parse_type, parse_number, classify_name): Replace
8981         "parse_gdbarch" with method call.
8982         * ada-lex.l: Replace "parse_gdbarch" with method call.
8983         * ada-exp.y (parse_type, find_primitive_type, type_char)
8984         (type_system_address): Replace "parse_gdbarch" with method call.
8985
8986 2019-04-04  Tom Tromey  <tom@tromey.com>
8987
8988         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8989         * stap-probe.c (stap_parse_argument): Update.
8990         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8991         initial_size parameter.
8992         * rust-exp.y (rust_lex_tests): Update.
8993         * parse.c (parser_state): Update.
8994         (parse_exp_in_context): Update.
8995         * parser-defs.h (struct parser_state) <parser_state>: Remove
8996         "initial_size" parameter.
8997
8998 2019-04-04  Tom Tromey  <tom@tromey.com>
8999
9000         * parser-defs.h (increase_expout_size): Don't declare.
9001         * parse.c (increase_expout_size): Now static.
9002
9003 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9004
9005         * gnu-nat.c (gnu_nat_target::wait): Fix
9006         target_waitstatus_to_string call.
9007
9008 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9009
9010         * eval.c (evaluate_subexp_standard): Handle internal functions
9011         during Fortran function call handling.
9012
9013 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9014
9015         * NEWS: Mention new internal functions.
9016         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9017         (read_base_type): Use dwarf2_init_complex_target_type.
9018         * value.c (creal_internal_fn): New function.
9019         (cimag_internal_fn): New function.
9020         (_initialize_values): Register new internal functions.
9021
9022 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9023
9024         * infrun.c (stop_all_threads): If debug_infrun, always
9025         trace the wait status after wait_one, using
9026         target_waitstatus_to_string and target_pid_to_str.
9027         (handle_inferior_event): Replace various trace of
9028         wait status kind by a single trace.
9029         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9030         wait status kind image by target_waitstatus_to_string.
9031         * target/waitstatus.c (target_waitstatus_to_string): Fix
9032         obsolete comment.
9033
9034 2019-04-01  Tom Tromey  <tromey@adacore.com>
9035
9036         PR symtab/23331:
9037         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9038
9039 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9040             Pedro Alves  <palves@redhat.com>
9041
9042         * top.c (quit_force): Call 'finalize_values'.
9043         * value.c (finalize_values): New function.
9044         * value.h (finalize_values): Declare.
9045
9046 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9047
9048         * NEWS: Announce $_gdb_major and $_gdb_minor.
9049
9050         * top.c (init_gdb_version_vars): New function.
9051         (gdb_init): Call init_gdb_version_vars.
9052
9053 2019-03-29  Tom Tromey  <tromey@adacore.com>
9054
9055         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9056         help text.  Remove dead code.
9057
9058 2019-03-29  Keith Seitz  <keiths@redhat.com>
9059
9060         From Siddhesh Poyarekar:
9061         * f-lang.h (f77_get_upperbound): Return LONGEST.
9062         (f77_get_lowerbound): Likewise.
9063         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9064         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9065         print them.
9066         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9067         plongest to format print it.
9068         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9069         (f77_get_upperbound): Likewise.
9070         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9071         LOWER_BOUND to LONGEST.
9072         (f77_create_arrayprint_offset_tbl): Likewise.
9073
9074 2019-03-29  Keith Seitz  <keiths@redhat.com>
9075
9076         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9077         %s/pulongest for TYPE_LENGTH instead of %d in format
9078         strings.
9079         * ada-typerint.c (ada_print_type): Likewise.
9080         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9081         * compile/compile-c-support.c (generate_register_struct): Likewise.
9082         * gdbtypes.c (recursive_dump_type): Likewise.
9083         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9084         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9085         instead of %d in format strings.
9086         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9087         to std::min to ULONGEST.
9088         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9089         instead of %d in format strings.
9090         * tracepoint.c (info_scope_command): Likewise.
9091         * typeprint.c (print_offset_data::update)
9092         (print_offset_data::finish): Likewise.
9093         * xtensa-tdep.c (xtensa_store_return_value)
9094         (xtensa_push_dummy_call): Likewise.
9095
9096 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9097
9098         * windows-nat.c (display_selector): Fixed format specifications
9099         for 64-bit Cygwin.
9100
9101 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9102
9103         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9104
9105 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9106
9107         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9108         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9109         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9110         (nios2_linux_init_abi): Install it.
9111
9112 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9113
9114         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9115
9116 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9117
9118         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9119
9120 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9121             Tom Tromey  <tromey@adacore.com>
9122
9123         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9124
9125 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9126
9127         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9128         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9129         method to compute the bounds of range types. Also print "[evaluated]"
9130         if the bounds' values come from a dynamic evaluation.
9131
9132 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9133
9134         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9135         whitespace when pretty printing is on.
9136
9137 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9138
9139         * ppc-linux-nat.c: Add include.
9140
9141 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9142
9143         * NEWS: Mention AArch64 Pointer Authentication.
9144
9145 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9146
9147         * arm-linux-nat.c: Add include.
9148
9149 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9150
9151         * source-cache.c (source_cache::get_source_lines): Re-read
9152         fullname after calling open_source_file.
9153
9154 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9155
9156         * NEWS: Mention TLS support for FreeBSD.
9157
9158 2019-03-25  Tom Tromey  <tromey@adacore.com>
9159
9160         * minsyms.c (BUNCH_SIZE): Update comment.
9161         (~minimal_symbol_reader): Remove old comment.
9162         (compact_minimal_symbols): Update comment.
9163         (minimal_symbol_reader::install): Remove old comment.  Update
9164         other comments.
9165
9166 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9167
9168         * s390-linux-nat.c: Add include.
9169
9170 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9171
9172         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9173         Call linux_get_hwcap.
9174         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9175         Likewise.
9176         (aarch64_linux_get_hwcap): Remove function.
9177         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9178         declaration.
9179         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9180         linux_get_hwcap.
9181         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9182         * linux-tdep.c (linux_get_hwcap): Add function.
9183         (linux_get_hwcap2): Likewise.
9184         * linux-tdep.h (linux_get_hwcap): Add declaration.
9185         (linux_get_hwcap2): Likewise.
9186         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9187         (ppc_linux_get_hwcap2): Likewise.
9188         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9189         linux_get_hwcap.
9190         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9191         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9192         (ppc_linux_nat_target::read_description): Likewise.
9193         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9194         * s390-linux-nat.c: Likewise.
9195         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9196
9197 2019-03-24  Tom Tromey  <tom@tromey.com>
9198
9199         * ada-lang.c (standard_lookup): Simplify initialization.
9200         (ada_lookup_symbol_nonlocal): Simplify return.
9201         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9202         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9203         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9204         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9205         initialization.
9206         * solib.c (solib_global_lookup): Simplify.
9207         * symtab.c (null_block_symbol): Remove.
9208         (symbol_cache_lookup): Simplify returns.
9209         (lookup_language_this): Simplify returns.
9210         (lookup_symbol_aux): Simplify return.
9211         (lookup_local_symbol): Simplify returns.
9212         (lookup_global_symbol_from_objfile): Simplify return.
9213         (lookup_symbol_in_objfile_symtabs)
9214         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9215         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9216         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9217         * cp-namespace.c (cp_lookup_bare_symbol)
9218         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9219         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9220         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9221         (cp_lookup_symbol_via_imports): Simplify initialization.
9222         (find_symbol_in_baseclass): Likewise.
9223         * symtab.h (null_block_symbol): Remove.
9224         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9225         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9226         (d_lookup_symbol_module): Likewise.
9227         (find_symbol_in_baseclass): Simplify initialization.
9228
9229 2019-03-24  Tom Tromey  <tom@tromey.com>
9230
9231         * expression.h: Don't include symtab.h.
9232         (struct block): Forward declare.
9233
9234 2019-03-24  Tom Tromey  <tom@tromey.com>
9235
9236         * c-exp.y (typebase): Remove casts.
9237         * gdbtypes.c (lookup_unsigned_typename, )
9238         (lookup_signed_typename): Remove cast.
9239         * eval.c (parse_to_comma_and_eval): Remove cast.
9240         * parse.c (write_dollar_variable): Remove cast.
9241         * block.h (struct block) <superblock>: Now const.
9242         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9243         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9244         (map_block): Make "block" const.
9245         * symfile.h (struct quick_symbol_functions)
9246         <map_matching_symbols>: Constify block argument to "callback".
9247         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9248         const.
9249         (find_pc_sect_compunit_symtab): Make "b" const.
9250         (find_symbol_at_address): Likewise.
9251         (search_symbols): Likewise.
9252         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9253         (dw2_debug_names_lookup_symbol): Likewise.
9254         (dw2_map_matching_symbols): Update.
9255         * p-valprint.c (pascal_val_print): Remove "block".
9256         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9257         (aux_add_nonlocal_symbols): Make "block" const.
9258         (resolve_subexp): Remove cast.
9259         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9260         const.
9261         (iterate_over_file_blocks): Likewise.
9262         * f-exp.y (%union) <bval>: Remove.
9263         * coffread.c (patch_opaque_types): Make "b" const.
9264         * spu-tdep.c (spu_catch_start): Make "block" const.
9265         * c-valprint.c (print_unpacked_pointer): Remove "block".
9266         * symmisc.c (dump_symtab_1): Make "b" const.
9267         (block_depth): Make "block" const.
9268         * d-exp.y (%union) <bval>: Remove.
9269         * cp-support.h (cp_lookup_rtti_type): Update.
9270         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9271         * psymtab.c (psym_lookup_symbol): Make "block" const.
9272         (maintenance_check_psymtabs): Make "b" const.
9273         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9274         (enumerate_locals, enumerate_args): Update.
9275         * python/py-symtab.c (stpy_global_block): Make "block" const.
9276         (stpy_static_block): Likewise.
9277         * inline-frame.c (block_starting_point_at): Make "new_block"
9278         const.
9279         * block.c (find_block_in_blockvector): Make return type const.
9280         (blockvector_for_pc_sect): Make "b" const.
9281         (find_block_in_blockvector): Make "b" const.
9282
9283 2019-03-23  Tom Tromey  <tom@tromey.com>
9284
9285         * varobj.c (varobj_create): Update.
9286         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9287         * printcmd.c (display_command, do_one_display): Don't reset
9288         innermost_block.
9289         * parser-defs.h (enum innermost_block_tracker_type): Move to
9290         expression.h.
9291         (innermost_block): Update comment.
9292         * parse.c (parse_exp_1): Add tracker_types parameter.
9293         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9294         tracker_types parameter.  Reset innermost_block.
9295         (parse_exp_in_context): Remove.
9296         (parse_expression_for_completion): Update.
9297         * objfiles.c (~objfile): Don't reset expression_context_block or
9298         innermost_block.
9299         * expression.h (enum innermost_block_tracker_type): Move from
9300         parser-defs.h.
9301         (parse_exp_1): Add tracker_types parameter.
9302         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9303         reset innermost_block.
9304
9305 2019-03-23  Tom Tromey  <tom@tromey.com>
9306
9307         * objfiles.h: Include bcache.h.
9308
9309 2019-03-23  Tom Tromey  <tom@tromey.com>
9310
9311         * linespec.c (get_current_search_block): Use
9312         scoped_restore_current_language.
9313         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9314
9315 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9316             Jiong Wang  <jiong.wang@arm.com>
9317
9318         * aarch64-linux-tdep.c
9319         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9320         section.
9321         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9322
9323 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9324             Jiong Wang  <jiong.wang@arm.com>
9325
9326         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9327         instructions.
9328         (aarch64_analyze_prologue_test): Add PACIASP test.
9329         (aarch64_prologue_prev_register): Unmask PC value.
9330
9331 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9332             Jiong Wang  <jiong.wang@arm.com>
9333
9334         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9335         (aarch64_dwarf2_prev_register): Unmask PC value.
9336         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9337         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9338         DW_CFA_AARCH64_negate_ra_state.
9339         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9340
9341 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9342             Jiong Wang  <jiong.wang@arm.com>
9343
9344         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9345         registers.
9346         (aarch64_pseudo_register_name): Likewise.
9347         (aarch64_pseudo_register_type): Likewise.
9348         (aarch64_pseudo_register_reggroup_p): Likewise.
9349         (aarch64_gdbarch_init): Add pauth registers.
9350         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9351         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9352         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9353         (struct gdbarch_tdep): Add regnum for ra_state.
9354
9355 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9356             Jiong Wang  <jiong.wang@arm.com>
9357
9358         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9359
9360 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9361             Jiong Wang  <jiong.wang@arm.com>
9362
9363         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9364         function.
9365         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9366         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9367         (aarch64_gdbarch_init): Add puth registers.
9368         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9369         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9370         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9371
9372 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9373             Jiong Wang  <jiong.wang@arm.com>
9374
9375         * aarch64-linux-nat.c
9376         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9377         * aarch64-linux-tdep.c
9378         (aarch64_linux_core_read_description): Likewise.
9379         (aarch64_linux_get_hwcap): New function.
9380         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9381         (aarch64_linux_get_hwcap): New declaration.
9382
9383 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9384             Jiong Wang  <jiong.wang@arm.com>
9385
9386         * aarch64-linux-nat.c
9387         (aarch64_linux_nat_target::read_description): Add pauth param.
9388         * aarch64-linux-tdep.c
9389         (aarch64_linux_core_read_description): Likewise.
9390         * aarch64-tdep.c (struct target_desc): Add in pauth.
9391         (aarch64_read_description): Add pauth param.
9392         (aarch64_gdbarch_init): Likewise.
9393         * aarch64-tdep.h (aarch64_read_description): Likewise.
9394         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9395         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9396         * features/Makefile: Add new files.
9397         * features/aarch64-pauth.c: New file.
9398         * features/aarch64-pauth.xml: New file.
9399
9400 2019-03-20  Tom Tromey  <tromey@adacore.com>
9401
9402         * infrun.c (handle_inferior_event): Rename from
9403         handle_inferior_event_1.  Create a scoped_value_mark.
9404         (handle_inferior_event): Remove.
9405
9406 2019-03-19  Tom Tromey  <tromey@adacore.com>
9407
9408         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9409         * infrun.h (print_stop_event): Add "displays" parameter.
9410         * infrun.c (print_stop_event): Add "displays" parameter.
9411
9412 2019-03-19  Pedro Alves  <palves@redhat.com>
9413
9414         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9415         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9416         to -1.  Fix TABs vs spaces.
9417         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9418         * tui/tui-out.h (tui_ui_out) Add intro comments.
9419         <m_line, m_start_of_line>: In-class initialize, and add describing
9420         comment.
9421
9422 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9423
9424         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9425         variable names.
9426         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9427
9428 2019-03-18  Pedro Alves  <palves@redhat.com>
9429             Eli Zaretskii <eliz@gnu.org>
9430
9431         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9432         m_line and m_start_of_line.
9433
9434 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9435
9436         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9437         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9438         it returns a newline.  This fixes a regression in TU mode, whereby
9439         the next line is output on the same screen line as the user input.
9440
9441 2019-03-18  Tom Tromey  <tromey@adacore.com>
9442
9443         * minsyms.c (minimal_symbol_reader::install): Remove call to
9444         obstack_blank.
9445
9446 2019-03-18  Pedro Alves  <palves@redhat.com>
9447
9448         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9449         New globals.
9450         (apply_style): New, factored out from ...
9451         (apply_ansi_escape): ... this.  Handle reverse video mode.
9452         (tui_set_reverse_mode): New function.
9453         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9454         * tui/tui-winsource.c (tui_show_source_line): Use
9455         tui_set_reverse_mode instead of setting A_STANDOUT.
9456         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9457         New setter methods.
9458
9459 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9460
9461         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9462         Handle tabs.
9463
9464 2019-03-18  Tom Tromey  <tromey@adacore.com>
9465
9466         * ada-lang.c (empty_array): Add "high" parameter.
9467         (ada_evaluate_subexp): Update.
9468
9469 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9470
9471         * unittests/string_view-selftests.c: Define
9472         _initialize_string_view_selftests unconditionally.
9473
9474 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9475
9476         PR gdb/24350
9477         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9478
9479 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9480
9481         PR gdb/24351
9482         * windows-nat.c (display_selector): Fix format specifiers.
9483
9484 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9485
9486         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9487         tui_refill_source_window instead of tui_refresh_win, to update the
9488         current execution line.  This fixes redisplay of the current line
9489         when stepping through the code with "next" or "step".
9490
9491 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9492
9493         * source-cache.c (source_cache::get_source_lines): Call
9494         find_source_lines to initialize s->nlines.  This fixes vertical
9495         scrolling of TUI source window when the DOWN arrow is pressed.
9496
9497 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9498
9499         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9500         linux-thread-db.c (_initialize_thread_db): Likewise.
9501
9502 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9503
9504         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9505         wclrtoeol in tui_show_source_line".  This reverts changes made in
9506         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9507
9508 2019-03-15  Tom Tromey  <tom@tromey.com>
9509
9510         * symtab.h (struct minimal_symbol): Derive from
9511         general_symbol_info.
9512         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9513         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9514         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9515         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9516         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9517         (MSYMBOL_SEARCH_NAME): Update.
9518         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9519         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9520         * minsyms.c (minimal_symbol_reader::record_full): Update.
9521
9522 2019-03-15  Tom Tromey  <tom@tromey.com>
9523
9524         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9525
9526 2019-03-15  Tom Tromey  <tom@tromey.com>
9527
9528         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9529         unique_xmalloc_ptr.
9530         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9531         Update.
9532         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9533         (build_minimal_symbol_hash_tables)
9534         (minimal_symbol_reader::install): Update.
9535
9536 2019-03-15  Tom Tromey  <tom@tromey.com>
9537
9538         * symtab.c (create_demangled_names_hash): Update.
9539         (symbol_set_names): Update.
9540         * objfiles.h (struct objfile_per_bfd_storage)
9541         <demangled_names_hash>: Now an htab_up.
9542         * objfiles.c (objfile_per_bfd_storage): Simplify.
9543
9544 2019-03-15  Tom Tromey  <tom@tromey.com>
9545
9546         * objfiles.h (struct objfile_per_bfd_storage): Declare
9547         destructor.
9548         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9549         New.
9550         (get_objfile_bfd_data): Use new.  Don't initialize
9551         language_of_main.
9552         (free_objfile_per_bfd_storage): Remove.
9553         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9554
9555 2019-03-15  Tom Tromey  <tom@tromey.com>
9556
9557         * symfile.c (reread_symbols): Update.
9558         * objfiles.c (objfile::objfile): Update.
9559         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9560         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9561         comment.
9562         (minimal_symbol_reader::install): Update.
9563         (terminate_minimal_symbol_table): Remove.
9564         * jit.c (jit_object_close_impl): Update.
9565
9566 2019-03-15  Tom Tromey  <tom@tromey.com>
9567
9568         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9569         initializations.
9570
9571 2019-03-15  Tom Tromey  <tom@tromey.com>
9572
9573         * objfiles.h (struct objfile_per_bfd_storage)
9574         <demangled_hash_languages>: Now a bitset.
9575         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9576         (lookup_minimal_symbol): Update.
9577
9578 2019-03-15  Tom Tromey  <tom@tromey.com>
9579
9580         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9581         Don't return the symbol.
9582         * coffread.c (record_minimal_symbol): Use record_full.
9583
9584 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9585
9586         The MS-Windows port of ncurses fails to switch to a color pair if
9587         one or both of the colors are the implicit default colors.  This
9588         change records the default colors when TUI is initialized, and
9589         then specifies them explicitly when a color pair uses the default
9590         colors.  This allows color styling in TUI mode on MS-Windows.
9591
9592         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9593         ncurses_norm_attr.
9594         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9595         colors in ncurses_norm_attr.
9596         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9597         "none", replace it with the default color recorded in
9598         ncurses_norm_attr.
9599
9600 2019-03-14  Tom Tromey  <tromey@adacore.com>
9601
9602         * source-cache.h (class source_cache) <get_source_lines>: Return
9603         std::string.
9604         * source-cache.c (source_cache::extract_lines): Handle case where
9605         first_pos==npos.  Return std::string.
9606         (source_cache::get_source_lines): Update.
9607
9608 2019-03-14  Tom Tromey  <tromey@adacore.com>
9609
9610         * NEWS: Add item for "style sources" commands.
9611         * source-cache.c (source_cache::get_source_lines): Check
9612         source_styling.
9613         * cli/cli-style.c (source_styling): New global.
9614         (_initialize_cli_style): Add "style sources" commands.
9615         (show_style_sources): New function.
9616         * cli/cli-style.h (source_styling): Declare.
9617
9618 2019-03-14  Pedro Alves  <palves@redhat.com>
9619             Tom Tromey  <tromey@adacore.com>
9620
9621         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9622         * tui/tui-winsource.c (tui_refill_source_window): New function,
9623         from...
9624         (tui_horizontal_source_scroll): ... here.  Move some logic.
9625         * cli/cli-style.c (set_style_enabled): Notify new observable.
9626         * tui/tui-hooks.c (tui_redisplay_source): New function.
9627         (tui_attach_detach_observers): Attach or detach
9628         tui_redisplay_source.
9629         * observable.h (source_styling_changed): New observable.
9630         * observable.c: Define source_styling_changed observable.
9631
9632 2019-03-13  Tom Tromey  <tromey@adacore.com>
9633
9634         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9635         (i386_gnu_nat_target::store_registers): Update.
9636         * target-debug.h (target_debug_print_std_string): New macro.
9637         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9638         * windows-tdep.c (display_one_tib): Update.
9639         * tui/tui-stack.c (tui_make_status_line): Update.
9640         * top.c (print_inferior_quit_action): Update.
9641         * thread.c (thr_try_catch_cmd): Update.
9642         (add_thread_with_info): Update.
9643         (thread_target_id_str): Update.
9644         (thr_try_catch_cmd): Update.
9645         (thread_command): Update.
9646         (thread_find_command): Update.
9647         * record-btrace.c (record_btrace_target::info_record)
9648         (record_btrace_resume_thread, record_btrace_target::resume)
9649         (record_btrace_cancel_resume, record_btrace_step_thread)
9650         (record_btrace_target::wait, record_btrace_target::wait)
9651         (record_btrace_target::wait, record_btrace_target::stop): Update.
9652         * progspace.c (print_program_space): Update.
9653         * process-stratum-target.c
9654         (process_stratum_target::thread_address_space): Update.
9655         * linux-fork.c (linux_fork_mourn_inferior)
9656         (detach_checkpoint_command, info_checkpoints_command)
9657         (linux_fork_context): Update.
9658         (linux_fork_detach): Update.
9659         (class scoped_switch_fork_info): Update.
9660         (delete_checkpoint_command): Update.
9661         * infrun.c (follow_fork_inferior): Update.
9662         (follow_fork_inferior): Update.
9663         (proceed_after_vfork_done): Update.
9664         (handle_vfork_child_exec_or_exit): Update.
9665         (follow_exec): Update.
9666         (displaced_step_prepare_throw): Update.
9667         (displaced_step_restore): Update.
9668         (start_step_over): Update.
9669         (resume_1): Update.
9670         (clear_proceed_status_thread): Update.
9671         (proceed): Update.
9672         (print_target_wait_results): Update.
9673         (do_target_wait): Update.
9674         (context_switch): Update.
9675         (stop_all_threads): Update.
9676         (restart_threads): Update.
9677         (finish_step_over): Update.
9678         (handle_signal_stop): Update.
9679         (switch_back_to_stepped_thread): Update.
9680         (keep_going_pass_signal): Update.
9681         (print_exited_reason): Update.
9682         (normal_stop): Update.
9683         * inferior.c (inferior_pid_to_str): Change return type.
9684         (print_selected_inferior): Update.
9685         (add_inferior): Update.
9686         (detach_inferior): Update.
9687         * dummy-frame.c (fprint_dummy_frames): Update.
9688         * dcache.c (dcache_info_1): Update.
9689         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9690         (btrace_fetch, btrace_clear): Update.
9691         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9692         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9693         type.
9694         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9695         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9696         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9697         * gdbarch.c, gdbarch.h: Rebuild.
9698         * gdbarch.sh (core_pid_to_str): Change return type.
9699         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9700         return type.
9701         (windows_nat_target::pid_to_str): Change return type.
9702         (windows_delete_thread): Update.
9703         (windows_nat_target::attach): Update.
9704         (windows_nat_target::files_info): Update.
9705         * target-delegates.c: Rebuild.
9706         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9707         return type.
9708         (sol_thread_target::pid_to_str): Change return type.
9709         * remote.c (class remote_target) <pid_to_str>: Change return
9710         type.
9711         (remote_target::pid_to_str): Change return type.
9712         (extended_remote_target::attach, remote_target::remote_stop_ns)
9713         (remote_target::remote_notif_remove_queued_reply)
9714         (remote_target::push_stop_reply, remote_target::disable_btrace):
9715         Update.
9716         (extended_remote_target::attach): Update.
9717         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9718         type.
9719         (gdbsim_target::pid_to_str): Change return type.
9720         * ravenscar-thread.c (struct ravenscar_thread_target)
9721         <pid_to_str>: Change return type.
9722         (ravenscar_thread_target::pid_to_str): Change return type.
9723         * procfs.c (class procfs_target) <pid_to_str>: Change return
9724         type.
9725         (procfs_target::pid_to_str): Change return type.
9726         (procfs_target::attach): Update.
9727         (procfs_target::detach): Update.
9728         (procfs_target::fetch_registers): Update.
9729         (procfs_target::store_registers): Update.
9730         (procfs_target::wait): Update.
9731         (procfs_target::files_info): Update.
9732         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9733         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9734         return type.
9735         (nto_procfs_target::pid_to_str): Change return type.
9736         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9737         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9738         return type.
9739         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9740         (exit_lwp): Update.
9741         (attach_proc_task_lwp_callback, get_detach_signal)
9742         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9743         (linux_nat_target::resume, wait_lwp, stop_callback)
9744         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9745         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9746         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9747         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9748         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9749         type.
9750         (inf_ptrace_target::attach): Update.
9751         (inf_ptrace_target::files_info): Update.
9752         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9753         type.
9754         (go32_nat_target::pid_to_str): Change return type.
9755         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9756         (gnu_nat_target::wait): Update.
9757         (gnu_nat_target::wait): Update.
9758         (gnu_nat_target::resume): Update.
9759         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9760         (fbsd_nat_target::wait): Update.
9761         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9762         type.
9763         (darwin_nat_target::attach): Update.
9764         * corelow.c (class core_target) <pid_to_str>: Change return type.
9765         (core_target::pid_to_str): Change return type.
9766         * target.c (normal_pid_to_str): Change return type.
9767         (default_pid_to_str): Likewise.
9768         (target_pid_to_str): Change return type.
9769         (target_translate_tls_address): Update.
9770         (target_announce_detach): Update.
9771         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9772         return type.
9773         (bsd_uthread_target::pid_to_str): Change return type.
9774         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9775         type.
9776         (bsd_kvm_target::pid_to_str): Change return type.
9777         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9778         return type.
9779         (aix_thread_target::pid_to_str): Change return type.
9780         * target.h (struct target_ops) <pid_to_str>: Change return type.
9781         (target_pid_to_str, normal_pid_to_str): Likewise.
9782         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9783         type.
9784         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9785         type.
9786         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9787         return type.
9788         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9789         type.
9790         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9791         type.
9792         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9793         return type.
9794
9795 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9796
9797         * NEWS: Mention that the new default MI version is 3.  Mention
9798         changes to the output of commands and events that deal with
9799         multi-location breakpoints.
9800         * breakpoint.c: Include "mi/mi-out.h".
9801         (print_one_breakpoint): Change output syntax if using MI version
9802         >= 3.
9803         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9804         New.
9805         (mi_multi_location_breakpoint_output_fixed): New.
9806         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9807         (mi_cmd_fix_multi_location_breakpoint_output): New.
9808         (mi_multi_location_breakpoint_output_fixed): New.
9809         * mi/mi-cmds.c (mi_cmds): Register command
9810         -fix-multi-location-breakpoint-output.
9811         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9812         interpreter "mi".
9813
9814 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9815
9816         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9817         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9818         instantiate mi_ui_out based on interpreter name.
9819         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9820         * mi/mi-main.c (mi_load_progress): Likewise.
9821
9822 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9823
9824         * NEWS: Combine separate "New targets" sections for 8.3.
9825
9826 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9827
9828         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9829         (ppcfbsd_init_abi): Install gdbarch
9830         "fetch_tls_load_module_address" and "get_thread_local_address"
9831         methods.
9832
9833 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9834
9835         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9836         (riscv_fbsd_init_abi): Install gdbarch
9837         "fetch_tls_load_module_address" and "get_thread_local_address"
9838         methods.
9839
9840 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9841
9842         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9843         (i386fbsd_init_abi): Install gdbarch
9844         "fetch_tls_load_module_address" and "get_thread_local_address"
9845         methods.
9846
9847 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9848
9849         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9850         (amd64fbsd_init_abi): Install gdbarch
9851         "fetch_tls_load_module_address" and "get_thread_local_address"
9852         methods.
9853
9854 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9855
9856         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9857         (struct fbsd_pspace_data): New type.
9858         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9859         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9860         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9861         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9862         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9863
9864 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9865
9866         * gdbtypes.c (lookup_struct_elt): New function.
9867         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9868         * gdbtypes.h (struct struct_elt): New type.
9869         (lookup_struct_elt): New prototype.
9870
9871 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9872
9873         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9874         remove disabled code block.
9875
9876 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9877
9878         * gdbarch.sh (get_thread_local_address): New method.
9879         * gdbarch.h, gdbarch.c: Regenerate.
9880         * target.c (target_translate_tls_address): Use
9881         gdbarch_get_thread_local_address if present instead of
9882         target::get_thread_local_address.
9883
9884 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9885
9886         * target.h (target::get_thread_local_address): Update comment.
9887
9888 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9889
9890         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9891         objfile->separate_debug_objfile_backlink if not NULL.
9892
9893 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9894
9895         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9896         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9897         (amd64bsd_store_inferior_registers): Likewise.
9898         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9899         Enable segment base registers.
9900         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9901         PT_GETFSBASE and PT_GETGSBASE.
9902         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9903         PT_SETGSBASE.
9904         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9905         segment base registers.
9906         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9907
9908 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9909
9910         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9911         Update calls to i386_target_description to add 'segments'
9912         parameter.
9913         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9914         add segment base registers.
9915         * arch/i386.c (i386_create_target_description): Add 'segments'
9916         parameter to enable segment base registers.
9917         * arch/i386.h (i386_create_target_description): Likewise.
9918         * features/i386/32bit-segments.xml: New file.
9919         * features/i386/32bit-segments.c: Generate.
9920         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9921         call to i386_target_description to add 'segments' parameter.
9922         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9923         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9924         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9925         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9926         if feature is present.
9927         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9928         Add 'segments' parameter to call to i386_target_description.
9929         (i386_target_description): Add 'segments' parameter to enable
9930         segment base registers.
9931         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9932         to call to i386_target_description.
9933         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9934         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9935         Define I386_NUM_REGS.
9936         (i386_target_description): Add 'segments' parameter to enable
9937         segment base registers.
9938
9939 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9940
9941         PR/24325
9942         * source-cache.c: #undef open and close, to avoid unresolved
9943         externals during linking.
9944
9945 2019-03-12  Tom Tromey  <tromey@adacore.com>
9946
9947         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9948         const.  Add initializers.
9949         (_initialize_remote): Don't initialize ptid globals.
9950
9951 2019-03-12  Pedro Alves  <palves@redhat.com>
9952
9953         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9954
9955 2019-03-12  Pedro Alves  <palves@redhat.com>
9956
9957         * cp-name-parser.y (main): Remove unused 'len' variable.
9958
9959 2019-03-12  Tom Tromey  <tromey@adacore.com>
9960
9961         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9962         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9963
9964 2019-03-12  Tom Tromey  <tromey@adacore.com>
9965
9966         * linux-nat.c (iterate_over_lwps): Update.
9967         (stop_callback): Remove parameter.
9968         (stop_wait_callback, detach_callback, resume_set_callback)
9969         (select_singlestep_lwp_callback, set_ignore_sigint)
9970         (status_callback, resumed_callback, resume_clear_callback)
9971         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9972         data parameter.
9973         (linux_nat_target::detach, linux_nat_target::resume)
9974         (linux_stop_and_wait_all_lwps, select_event_lwp)
9975         (linux_nat_filter_event, linux_nat_wait_1)
9976         (linux_nat_target::kill, linux_nat_target::stop)
9977         (linux_nat_target::stop): Update.
9978         (linux_nat_resume_callback): Change type.
9979         (resume_stopped_resumed_lwps, count_events_callback)
9980         (select_event_lwp_callback): Likewise.
9981         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9982         * arm-linux-nat.c (struct update_registers_data): Remove.
9983         (update_registers_callback): Change type.
9984         (arm_linux_insert_hw_breakpoint1): Update.
9985         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9986         parameter.
9987         (x86_linux_dr_set_addr): Update.
9988         (x86_linux_dr_set_control): Update.
9989         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9990         (iterate_over_lwps): Use gdb::function_view.
9991         * nat/aarch64-linux-hw-point.c (struct
9992         aarch64_dr_update_callback_param): Remove.
9993         (debug_reg_change_callback): Change type.
9994         (aarch64_notify_debug_reg_change): Update.
9995         * s390-linux-nat.c (s390_refresh_per_info): Update.
9996
9997 2019-03-11  Tom Tromey  <tromey@adacore.com>
9998
9999         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10000         redundant assignment to "this_cu".
10001
10002 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10003
10004         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10005
10006 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10007
10008         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10009         from...
10010         (rank_one_type): ... this.
10011
10012 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10013
10014         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10015         from...
10016         (rank_one_type): ... this.
10017
10018 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10019
10020         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10021         from...
10022         (rank_one_type): ... this.
10023
10024 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10025
10026         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10027         from...
10028         (rank_one_type): ... this.
10029
10030 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10031
10032         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10033         from...
10034         (rank_one_type): ... this.
10035
10036 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10037
10038         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10039         from...
10040         (rank_one_type): ... this.
10041
10042 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10043
10044         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10045         from...
10046         (rank_one_type): ... this.
10047
10048 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10049
10050         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10051         from...
10052         (rank_one_type): ... this.
10053
10054 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10055
10056         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10057         from...
10058         (rank_one_type): ... this.
10059
10060 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10061
10062         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10063         from...
10064         (rank_one_type): ... this.
10065
10066 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10067
10068         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10069         from...
10070         (rank_one_type): ... this.
10071
10072 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10073
10074         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10075         from...
10076         (rank_one_type): ... this.
10077
10078 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10079
10080         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10081         inferior-events' shows the example events.
10082
10083 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10084
10085         Support styling on native MS-Windows console
10086
10087         PR/24315
10088         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10089         on MS-Windows if $TERM is not defined.
10090
10091         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10092
10093         * posix-hdep.c (gdb_console_fputs):
10094         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10095         functions.
10096         * ui-file.h (gdb_console_fputs): Add prototype.
10097
10098         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10099         back to fputs only if the former returns zero.
10100
10101 2019-03-07  Tom Tromey  <tom@tromey.com>
10102
10103         * symmisc.c (print_symbol_bcache_statistics): Update.
10104         (print_objfile_statistics): Update.
10105         * symfile.c (allocate_symtab): Update.
10106         * stabsread.c: Don't include bcache.h.
10107         * psymtab.h (struct psymbol_bcache): Don't declare.
10108         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10109         (psymbol_bcache_init, psymbol_bcache_free)
10110         (psymbol_bcache_get_bcache): Don't declare.
10111         * psymtab.c (struct psymbol_bcache): Remove.
10112         (psymtab_storage::psymtab_storage): Update.
10113         (psymtab_storage::~psymtab_storage): Update.
10114         (psymbol_bcache_init, psymbol_bcache_free)
10115         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10116         (add_psymbol_to_bcache): Update.
10117         (allocate_psymtab): Update.
10118         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10119         macro_cache>: No longer pointers.
10120         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10121         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10122         * macrotab.c (macro_bcache): Update.
10123         * macroexp.c: Don't include bcache.h.
10124         * gdbtypes.c (check_types_worklist): Update.
10125         (types_deeply_equal): Remove TRY/CATCH.  Update.
10126         * elfread.c (elf_symtab_read): Update.
10127         * dwarf2read.c: Don't include bcache.h.
10128         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10129         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10130         (print_bcache_statistics, bcache_memory_used): Don't declare.
10131         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10132         methods.  Rename all data members.
10133         * bcache.c (struct bcache): Move to bcache.h.
10134         (bcache::expand_hash_table): Rename from expand_hash_table.
10135         (bcache): Remove.
10136         (bcache::insert): Rename from bcache_full.
10137         (bcache::compare): Rename from bcache_compare.
10138         (bcache_xmalloc): Remove.
10139         (bcache::~bcache): Rename from bcache_xfree.
10140         (bcache::print_statistics): Rename from print_bcache_statistics.
10141         (bcache::memory_used): Rename from bcache_memory_used.
10142
10143 2019-03-07  Pedro Alves  <palves@redhat.com>
10144
10145         * infrun.c (normal_stop): Also check for
10146         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10147
10148 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10149
10150         * f-lang.c (value_from_host_double): Moved to...
10151         * value.c (value_from_host_double): ...here.
10152         * value.h (value_from_host_double): Declare.
10153         * guile/scm-math.c (vlscm_convert_typed_number): Use
10154         value_from_host_double.
10155         (vlscm_convert_number): Likewise.
10156         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10157         * python/py-value.c (convert_value_from_python): Likewise.
10158
10159 2019-03-06  Tom Tromey  <tom@tromey.com>
10160
10161         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10162
10163 2019-03-06  Tom Tromey  <tom@tromey.com>
10164
10165         * utils.h (free_current_contents): Don't declare.
10166         * utils.c (free_current_contents): Remove.
10167
10168 2019-03-06  Tom Tromey  <tom@tromey.com>
10169
10170         * top.c (quit_force): Update.
10171         * main.c (captured_command_loop): Update.
10172         * common/new-op.c (operator new): Update.
10173         * common/common-exceptions.c (struct catcher)
10174         <save_cleanup_chain>: Remove member.
10175         (exceptions_state_mc_init): Update.
10176         (exception_try_scope_entry): Return nullptr.
10177         (exception_try_scope_exit, exception_rethrow)
10178         (throw_exception_sjlj, throw_exception_cxx): Update.
10179         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10180         (all_cleanups, do_cleanups, discard_cleanups)
10181         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10182         (restore_cleanups, restore_final_cleanups): Don't declare.
10183         (do_final_cleanups): Remove parameter.
10184         * common/cleanups.c (cleanup_chain, make_cleanup)
10185         (make_cleanup_dtor, all_cleanups, do_cleanups)
10186         (discard_my_cleanups, discard_cleanups)
10187         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10188         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10189         (null_cleanup): Remove.
10190         (do_final_cleanups): Remove parameter.
10191
10192 2019-03-06  Tom Tromey  <tom@tromey.com>
10193
10194         * remote.c (remote_target::remote_parse_stop_reply): Use
10195         unique_xmalloc_ptr.
10196
10197 2019-03-06  Tom Tromey  <tom@tromey.com>
10198
10199         * stabsread.c (struct stabs_field_info): Rename from field_info.
10200         <list, fnlist>: Add initializers.
10201         <obstack>: New member.
10202         (read_member_functions, read_struct_fields, read_baseclasses):
10203         Allocate on obstack.  Don't use cleanups.
10204         (read_one_struct_field, read_member_functions, read_struct_fields)
10205         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10206         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10207         (read_struct_type): Update.
10208
10209 2019-03-06  Tom Tromey  <tom@tromey.com>
10210
10211         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10212         * common/filestuff.h (make_cleanup_close): Don't declare.
10213         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10214         Remove.
10215
10216 2019-03-06  Tom Tromey  <tom@tromey.com>
10217
10218         * solib-aix.c: Use make_scope_exit.
10219
10220 2019-03-06  Tom Tromey  <tom@tromey.com>
10221
10222         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10223         Use make_scope_exit.
10224
10225 2019-03-06  Tom Tromey  <tom@tromey.com>
10226
10227         * solib-svr4.c (disable_probes_interface): Remove parameter.
10228         (svr4_handle_solib_event): Use make_scope_exit.
10229
10230 2019-03-06  Tom Tromey  <tom@tromey.com>
10231
10232         * remote.c (struct stop_reply_deleter): Remove.
10233         (stop_reply_up): Update.
10234         (struct stop_reply): Derive from notif_event.  Don't typedef.
10235         <regcache>: Now a std::vector.
10236         (stop_reply_xfree): Remove.
10237         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10238         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10239         (remote_target::discard_pending_stop_replies): Use delete.
10240         (remote_target::remote_parse_stop_reply): Update.
10241         (remote_target::process_stop_reply): Update.
10242         * remote-notif.h (struct notif_event): Add virtual destructor.
10243         Remove "dtr" member.
10244         (struct notif_client) <alloc_event>: Return a unique_ptr.
10245         (notif_event_xfree): Don't declare.
10246         (notif_event_up): New typedef.
10247         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10248         (notif_event_xfree, do_notif_event_xfree): Remove.
10249         (remote_notif_state_xfree): Update.
10250
10251 2019-03-06  Tom Tromey  <tom@tromey.com>
10252
10253         * infrun.c (displaced_step_clear_cleanup): Now a
10254         forward_scope_exit type.
10255         (displaced_step_prepare_throw): Update.
10256         (displaced_step_fixup): Update.
10257
10258 2019-03-06  Tom Tromey  <tom@tromey.com>
10259
10260         * inferior.h (class inferior): Update comment.
10261         * gdbthread.h (class thread_info): Update comment.
10262
10263 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10264             Tom Tromey  <tom@tromey.com>
10265
10266         * stabsread.h (struct stab_section_list): Remove.
10267         (coffstab_build_psymtabs): Update.
10268         * dbxread.c (symbuf_sections): Now a std::vector.
10269         (sect_idx): New global.
10270         (fill_symbuf): Update.
10271         (coffstab_build_psymtabs): Change type of stabsects parameter.
10272         Update.
10273         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10274         std::vector.
10275         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10276         (coff_locate_sections): Update.
10277         (coff_symfile_read): Remove cleanups.  Update.
10278         (init_stringtab): Add storage parameter.
10279         (free_stringtab, free_stringtab_cleanup): Remove.
10280         (init_lineno): Add storage parameter.
10281         (free_linetab, free_linetab_cleanup): Remove.
10282
10283 2019-03-06  Pedro Alves  <palves@redhat.com>
10284
10285         * linux-fork.c (fork_info::clobber_regs): Delete.
10286         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10287         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10288         comment.  Adjust.
10289         (scoped_switch_fork_info::scoped_switch_fork_info)
10290         (checkpoint_command, linux_fork_context): Adjust
10291         fork_save_infrun_state calls.
10292
10293 2019-03-06  Pedro Alves  <palves@redhat.com>
10294
10295         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10296         (inf_has_multiple_threads): Return 'bool' and rewrite using
10297         inferior_info::threads().
10298
10299 2019-03-06  Pedro Alves  <palves@redhat.com>
10300
10301         * linux-fork.c: Include <list>.
10302         (fork_list): Now a std::list instance.
10303         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10304         (forks_exist_p, find_last_fork): Adjust.
10305         (new_fork): Delete.
10306         (one_fork_p): New.
10307         (add_fork): Adjust.
10308         (free_fork): Delete, folded into fork_info::~fork_info().
10309         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10310         Adjust.
10311         (init_fork_list): Delete.
10312         (linux_fork_killall, linux_fork_mourn_inferior)
10313         (linux_fork_detach, info_checkpoints_command): Adjust.
10314         (_initialize_linux_fork): No longer call init_fork_list.
10315
10316 2019-03-06  Pedro Alves  <palves@redhat.com>
10317
10318         * linux-fork.c (new_fork): New, split out of ...
10319         (add_fork): ... this.  Return void.  Move "first fork" special
10320         case from here, to ...
10321         (checkpoint_command): ... here.
10322         * linux-linux.h (add_fork): Return void.
10323
10324 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10325
10326         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10327
10328 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10329             Chris January  <chris.january@arm.com>
10330             David Lecomber  <david.lecomber@arm.com>
10331
10332         * f-exp.y: New token, UNOP_INTRINSIC.
10333         (exp): New pattern using UNOP_INTRINSIC token.
10334         (f77_keywords): Add 'abs' keyword.
10335         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10336         (value_from_host_double): New function.
10337         (evaluate_subexp_f): Support UNOP_ABS.
10338
10339 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10340
10341         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10342         types.
10343
10344 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10345
10346         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10347         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10348         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10349
10350 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10351
10352         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10353
10354 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10355             Chris January  <chris.january@arm.com>
10356
10357         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10358         * f-exp.y: Define 'KIND' token.
10359         (exp): New pattern for KIND expressions.
10360         (ptype): Handle types with a kind extension.
10361         (direct_abs_decl): Extend to spot kind extensions.
10362         (f77_keywords): Add 'kind' to the list.
10363         (push_kind_type): New function.
10364         (convert_to_kind_type): New function.
10365         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10366         * parse.c (operator_length_standard): Likewise.
10367         * parser-defs.h (enum type_pieces): Add tp_kind.
10368         * std-operator.def: Add UNOP_KIND.
10369
10370 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10371
10372         * f-exp.y (f_parse): Set yydebug.
10373
10374 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10375
10376         * f-lang.c (evaluate_subexp_f): New function.
10377         (exp_descriptor_f): New global.
10378         (f_language_defn): Use exp_descriptor_f instead of
10379         exp_descriptor_standard.
10380
10381 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10382
10383         * f-exp.y (struct token): Add comments.
10384         (dot_ops): Remove uppercase versions and the end marker.
10385         (f77_keywords): Likewise.
10386         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10387         entries in the dot_ops array are case insensitive, and use
10388         strncasecmp to compare strings.  Also some whitespace cleanup in
10389         this area.  Similar for the f77_keywords array, except entries in
10390         this list might be case sensitive.
10391
10392 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10393
10394         * f-exp.y (struct f77_boolean_val): Add comments.
10395         (boolean_values): Remove uppercase versions, and end marker.
10396         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10397         and use strncasecmp to achieve case insensitivity.  Additionally,
10398         perform whitespace cleanup around this code.
10399
10400 2019-03-06  Tom Tromey  <tromey@adacore.com>
10401
10402         * remote-sim.c (gdbsim_target_open): Use result of
10403         gdb_argv::release.
10404
10405 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10406         Dirk Schubert  <dirk.schubert@arm.com>
10407         Chris January  <chris.january@arm.com>
10408
10409         * eval.c (evaluate_subexp_standard): Call Fortran argument
10410         wrapping logic.
10411         * f-lang.c (struct value): A value which can be passed into a
10412         Fortran function call.
10413         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10414         where appropriate.
10415         (struct type): Value ready for a Fortran function call.
10416         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10417         is needed.
10418         * f-lang.h (fortran_argument_convert): Declaration.
10419         (fortran_preserve_arg_pointer): Declaration.
10420         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10421
10422 2019-03-05  Tom Tromey  <tromey@adacore.com>
10423
10424         * python/py-prettyprint.c (print_string_repr): Remove #if.
10425         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10426
10427 2019-03-05  Tom Tromey  <tromey@adacore.com>
10428
10429         * target.c (the_dummy_target): Move later.  Change type to
10430         "dummy_target".
10431         (initialize_targets): Don't initialize the_dummy_target.
10432
10433 2019-03-05  Tom Tromey  <tromey@adacore.com>
10434
10435         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10436         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10437
10438 2019-03-05  Tom Tromey  <tromey@adacore.com>
10439
10440         * windows-nat.c (windows_nat_target::attach)
10441         (windows_nat_target::detach): Don't call gdb_flush.
10442         * valprint.c (generic_val_print, val_print, val_print_string):
10443         Don't call gdb_flush.
10444         * utils.c (defaulted_query): Don't call gdb_flush.
10445         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10446         * target.c (target_announce_detach): Don't call gdb_flush.
10447         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10448         * remote.c (extended_remote_target::attach): Don't call
10449         gdb_flush.
10450         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10451         * printcmd.c (do_examine): Don't call gdb_flush.
10452         (info_display_command): Don't call gdb_flush.
10453         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10454         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10455         * memattr.c (info_mem_command): Don't call gdb_flush.
10456         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10457         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10458         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10459         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10460         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10461         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10462         (gnu_nat_target::detach): Don't call gdb_flush.
10463         * f-valprint.c (f_val_print): Don't call gdb_flush.
10464         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10465         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10466         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10467         gdb_flush.
10468         * c-valprint.c (c_val_print): Don't call gdb_flush.
10469         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10470
10471 2019-03-05  Tom Tromey  <tromey@adacore.com>
10472
10473         * varobj.c (update_dynamic_varobj_children): Update.
10474         (install_default_visualizer): Use reset, not release.
10475         * value.c (set_internalvar): Update.
10476         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10477         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10478         ATTRIBUTE_UNUSED_RESULT.
10479
10480 2019-03-05  Tom Tromey  <tromey@adacore.com>
10481
10482         * remote.c (class scoped_remote_fd) <release>: Add
10483         ATTRIBUTE_UNUSED_RESULT.
10484
10485 2019-03-05  Tom Tromey  <tromey@adacore.com>
10486
10487         * macroexp.c (struct macro_buffer) <release>: Add
10488         ATTRIBUTE_UNUSED_RESULT.
10489
10490 2019-03-05  Tom Tromey  <tromey@adacore.com>
10491
10492         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10493         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10494         ATTRIBUTE_UNUSED_RESULT.
10495
10496 2019-03-05  Tom Tromey  <tromey@adacore.com>
10497
10498         * common/scoped_fd.h (class scoped_fd) <release>: Add
10499         ATTRIBUTE_UNUSED_RESULT.
10500
10501 2019-03-05  Tom Tromey  <tromey@adacore.com>
10502
10503         * parser-defs.h (struct parser_state) <release>: Add
10504         ATTRIBUTE_UNUSED_RESULT.
10505
10506 2019-03-05  Tom Tromey  <tromey@adacore.com>
10507
10508         * utils.h (class gdb_argv) <release>: Add
10509         ATTRIBUTE_UNUSED_RESULT.
10510         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10511
10512 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10513
10514         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10515         for-loop range, to avoid compiler warnings.
10516
10517         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10518         avoid compiler warnings about unused variables.
10519
10520         * NEWS: Mention end of support for native debugging on MS-Windows
10521         before XP.
10522
10523         PR gdb/24292
10524         * common/netstuff.c:
10525         * gdbserver/gdbreplay.c
10526         * gdbserver/remote-utils.c:
10527         * ser-tcp.c:
10528         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10529         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10530         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10531         'getaddrinfo' and 'freeaddrinfo' were not available before
10532         Windows XP, and mingw.org's MinGW headers by default define
10533         _WIN32_WINNT to 0x500.
10534
10535 2019-03-01  Gary Benson <gbenson@redhat.com>
10536
10537         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10538
10539 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10540             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10541
10542         PR gdb/8527
10543         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10544         set_sigint_trap, clear_sigint_trap.
10545
10546 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10547
10548         * target.c (target_detach): Clear the regcache and the
10549         frame cache.
10550
10551 2019-02-27  Pedro Alves  <palves@redhat.com>
10552
10553         * utils.c (set_screen_size): When we cap the height/width sizes,
10554         tweak the corresponding command variable to show "unlimited":
10555
10556 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10557             Pedro Alves  <palves@redhat.com>
10558
10559         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10560         before calling rl_set_screen_size.
10561
10562 2019-02-27  Tom Tromey  <tromey@adacore.com>
10563
10564         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10565         define.
10566         * python/py-value.c: Remove Python 2.4 workaround.
10567         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10568         workaround.
10569         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10570         Python 2.4 workaround.
10571         * python/python-internal.h: Remove Python 2.4 comment.
10572         (Py_ssize_t): Don't define.
10573         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10574         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10575         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10576         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10577         * python/python.c (do_start_initialization): Remove Python 2.4
10578         workaround.
10579         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10580         (print_children): Remove Python 2.4 workaround.
10581         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10582         workaround.
10583         (CHARBUFFERPROC_NAME): Remove.
10584         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10585         Python 2.4 workaround.
10586
10587 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10588
10589         * NEWS: Note minimum Python version.
10590
10591 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10592
10593         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10594         code from these functions.  Remove corresponding ifdefs.  Use
10595         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10596         Remove gotos and target of gotos.
10597         (infpy_search_memory): Likewise.
10598
10599 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10600
10601         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10602         (hppa_gdbarch_init): Don't register deleted functions with
10603         gdbarch.
10604
10605 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10606
10607         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10608         (h8300_unwind_sp): Delete.
10609         (h8300_dummy_id): Delete.
10610         (h8300_gdbarch_init): Don't register deleted functions with
10611         gdbarch.
10612
10613 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10614
10615         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10616         (ft32_unwind_pc): Delete.
10617         (ft32_unwind_sp): Delete.
10618         (ft32_gdbarch_init): Don't register deleted functions with
10619         gdbarch.
10620
10621 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10622
10623         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10624         (frv_unwind_pc): Delete.
10625         (frv_unwind_sp): Delete.
10626         (frv_gdbarch_init): Don't register deleted functions with
10627         gdbarch.
10628
10629 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10630
10631         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10632         (riscv_unwind_pc): Delete.
10633         (riscv_unwind_sp): Delete.
10634         (riscv_gdbarch_init): Don't register deleted functions with
10635         gdbarch.
10636
10637 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10638
10639         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10640         (csky_unwind_pc): Delete.
10641         (csky_unwind_sp): Delete.
10642         (csky_gdbarch_init): Don't register deleted functions with
10643         gdbarch.
10644
10645 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10646
10647         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10648         (cris_unwind_pc): Delete.
10649         (cris_unwind_sp): Delete.
10650         (cris_gdbarch_init): Don't register deleted functions with
10651         gdbarch.
10652
10653 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10654
10655         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10656         (bfin_unwind_pc): Delete.
10657         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10658
10659 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10660
10661         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10662         (arm_unwind_pc): Delete.
10663         (arm_unwind_sp): Delete.
10664         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10665
10666 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10667
10668         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10669         (arc_unwind_pc): Delete.
10670         (arc_unwind_sp): Delete.
10671         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10672
10673 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10674
10675         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10676         (alpha_unwind_pc): Delete.
10677         (alpha_gdbarch_init): Don't register deleted functions with
10678         gdbarch.
10679
10680 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10681
10682         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10683         (aarch64_unwind_pc): Delete.
10684         (aarch64_unwind_sp): Delete.
10685         (aarch64_gdbarch_init): Don't register deleted functions with
10686         gdbarch.
10687
10688 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10689
10690         * gdbtypes.c (type_align): Don't consider static members when
10691         computing structure alignment.
10692
10693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10694
10695         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10696         return 0 for other types.
10697         * arch-utils.c (default_type_align): Always return 0.
10698         * gdbarch.h: Regenerate.
10699         * gdbarch.sh (type_align): Extend comment.
10700         * gdbtypes.c (type_align): Add additional comments, always call
10701         gdbarch_type_align before applying the default rules.
10702         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10703         generic code will then apply a suitable default.
10704         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10705         types, return 0 for other types.
10706
10707 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10708
10709         * NEWS: Create a new section for the next release branch.
10710         Rename the section of the current branch, now that it has
10711         been cut.
10712
10713 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10714
10715         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10716         * version.in: Bump version to 8.3.50.DATE-git.
10717
10718 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10719
10720         * aix-thread.c (ptid_cmp): Remove unused variable.
10721         (get_signaled_thread): Likewise.
10722         (store_regs_user_thread): Likewise.
10723         (store_regs_kernel_thread): Likewise.
10724         (fetch_regs_kernel_thread): Remove shadowed variable.
10725
10726 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10727
10728         * features/riscv/32bit-cpu.xml: Add register numbers.
10729         * features/riscv/32bit-fpu.c: Regenerate.
10730         * features/riscv/32bit-fpu.xml: Add register numbers.
10731         * features/riscv/64bit-cpu.xml: Add register numbers.
10732         * features/riscv/64bit-fpu.c: Regenerate.
10733         * features/riscv/64bit-fpu.xml: Add register numbers.
10734
10735 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10736
10737         * NEWS: Mention two argument form of gdb.Value constructor.
10738         * python/py-value.c (convert_buffer_and_type_to_value): New
10739         function.
10740         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10741         Add support for handling an optional second argument.  Call
10742         convert_buffer_and_type_to_value as appropriate.
10743         * python/python-internal.h (Py_buffer_deleter): New struct.
10744         (Py_buffer_up): New typedef.
10745
10746 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10747
10748         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10749         instead of releasing ownership.
10750
10751 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10752
10753         * dwarf2read.c (open_and_init_dwp_file): Call
10754         elf_numsections instead of bfd_count_sections to initialize
10755         dwp_file->num_sections.
10756
10757 2019-02-25  Tom Tromey  <tromey@adacore.com>
10758
10759         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10760
10761 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10762
10763         * gcore.in: Add '--readnever' option when invoking GDB.
10764
10765 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10766
10767         * MAINTAINERS: Update my email address.
10768
10769 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10770
10771         * build-id.c (build_id_to_debug_bfd_1): New function.
10772         (build_id_to_debug_bfd): Look for separate debug file in
10773         sysroot.
10774
10775 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10776
10777         * gdbarch.sh: Update the copyright year range that is placed into
10778         generated files.
10779
10780 2019-02-22  Keith Seitz  <keiths@redhat.com>
10781
10782         PR symtab/23853
10783         * linespec.c (create_sals_line_offset): Search for the default
10784         symtab's filename instead of its fullname.
10785
10786 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10787
10788         * NEWS: Update style defaults.
10789
10790 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10791
10792         * main.c (captured_main_1): Disable styling in batch mode.
10793
10794 2019-02-20  Tom Tromey  <tom@tromey.com>
10795
10796         * symtab.c (symtab_symbol_info): Fix typos.
10797
10798 2019-02-20  Tom Tromey  <tromey@adacore.com>
10799
10800         * findcmd.c (_initialize_mem_search): Use upper case for
10801         metasyntactic variables.
10802
10803 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10804
10805         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10806         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10807
10808 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10809
10810         * top.h (source_file_name): Change to std::string.
10811         * top.c (source_file_name): Likewise.
10812         (command_line_input): Adjust.
10813         * cli/cli-script.c (script_from_file): Adjust.
10814
10815 2019-02-19  Tom Tromey  <tromey@adacore.com>
10816
10817         * ravenscar-thread.c
10818         (ravenscar_thread_target::update_thread_list): Don't call
10819         ada_build_task_list.
10820         * ada-lang.h (ada_build_task_list): Don't declare.
10821         * ada-tasks.c (struct ada_tasks_inferior_data)
10822         <task_list_valid_p>: Now bool.
10823         (read_known_tasks, ada_task_list_changed)
10824         (ada_tasks_invalidate_inferior_data): Update.
10825         (read_known_tasks_array): Return bool.
10826         (read_known_tasks_list): Likewise.
10827         (read_known_tasks): Return void.
10828         (ada_build_task_list): Now static.
10829
10830 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10831
10832         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10833         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10834
10835 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10836
10837         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10838         variant for ada_tasks_pspace_data_handle and
10839         ada_tasks_inferior_data_handle.
10840         (ada_tasks_pspace_data_cleanup): New function.
10841         (ada_tasks_inferior_data_cleanup): New function.
10842
10843 2019-02-17  Tom Tromey  <tom@tromey.com>
10844
10845         * macrotab.h (macro_source_fullname): Return a std::string.
10846         * macrotab.c (macro_include, check_for_redefinition)
10847         (macro_undef, macro_lookup_definition, foreach_macro)
10848         (foreach_macro_in_scope): Update.
10849         (macro_source_fullname): Return a std::string.
10850         * macrocmd.c (show_pp_source_pos): Update.
10851
10852 2019-02-17  Tom Tromey  <tom@tromey.com>
10853
10854         * macrocmd.c (show_pp_source_pos): Style the file names.
10855
10856 2019-02-17  Tom Tromey  <tom@tromey.com>
10857
10858         PR tui/24197:
10859         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10860
10861 2019-02-17  Tom Tromey  <tom@tromey.com>
10862
10863         * ada-lang.c (user_select_syms): Use filtered printing.
10864         * utils.c (wrap_style): New global.
10865         (desired_style): Remove.
10866         (emit_style_escape): Add stream parameter.
10867         (set_output_style, reset_terminal_style, prompt_for_continue):
10868         Update.
10869         (flush_wrap_buffer): Only flush gdb_stdout.
10870         (wrap_here): Set wrap_style.
10871         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10872         treat escape sequences as a character.  Change when wrap buffer is
10873         flushed.
10874         (fputs_styled): Do not set the output style when the default is
10875         requested.
10876         * ui-style.h (struct ui_file_style) <is_default>: New method.
10877         * source.c (print_source_lines_base): Emit escape sequences in one
10878         piece.
10879
10880 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10881
10882         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10883         integers and enumeration types.
10884
10885 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10886
10887         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10888         instead of lookup_symbol_in_language
10889         (do_exact_match): New function.
10890         (ada_get_symbol_name_matcher): Return do_exact_match when
10891         doing a verbatim match.
10892
10893 2019-02-15  Tom Tromey  <tromey@adacore.com>
10894
10895         * ravenscar-thread.c (ravenscar_thread_target::resume)
10896         (ravenscar_thread_target::wait): Special case wildcard requests.
10897
10898 2019-02-15  Tom Tromey  <tromey@adacore.com>
10899
10900         * ravenscar-thread.c (base_ptid): Remove.
10901         (struct ravenscar_thread_target) <close>: New method.
10902         <m_base_ptid>: New member.
10903         <update_inferior_ptid, active_task, task_is_currently_active,
10904         runtime_initialized>: Declare methods.
10905         <ravenscar_thread_target>: Add constructor.
10906         (ravenscar_thread_target::task_is_currently_active)
10907         (ravenscar_thread_target::update_inferior_ptid)
10908         (ravenscar_runtime_initialized): Rename.  Now methods.
10909         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10910         (ravenscar_thread_target::update_thread_list): Update.
10911         (ravenscar_thread_target::active_task): Now method.
10912         (ravenscar_thread_target::store_registers)
10913         (ravenscar_thread_target::prepare_to_store)
10914         (ravenscar_thread_target::prepare_to_store)
10915         (ravenscar_thread_target::mourn_inferior): Update.
10916         (ravenscar_inferior_created): Use "new" to create target.
10917         (ravenscar_thread_target::get_ada_task_ptid): Update.
10918         (_initialize_ravenscar): Don't initialize base_ptid.
10919         (ravenscar_ops): Remove global.
10920
10921 2019-02-15  Tom Tromey  <tromey@adacore.com>
10922
10923         * target.h (push_target): Declare new overload.
10924         * target.c (push_target): New overload, taking an rvalue reference.
10925         * remote.c (remote_target::open_1): Use push_target overload.
10926         * corelow.c (core_target_open): Use push_target overload.
10927
10928 2019-02-15  Tom Tromey  <tromey@adacore.com>
10929
10930         * ravenscar-thread.c (is_ravenscar_task)
10931         (ravenscar_task_is_currently_active): Return bool.
10932         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10933         (_initialize_ravenscar): Remove "(void)".
10934         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10935         Return bool.
10936
10937 2019-02-15  Tom Tromey  <tromey@adacore.com>
10938
10939         * ravenscar-thread.c (ravenscar_runtime_initializer)
10940         (has_ravenscar_runtime, get_running_thread_id)
10941         (ravenscar_thread_target::resume): Fix indentation.
10942
10943 2019-02-15  Tom Tromey  <tromey@adacore.com>
10944
10945         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10946         from ravenscar_arch_ops.
10947         (sparc_ravenscar_ops::fetch_registers)
10948         (sparc_ravenscar_ops::store_registers): Now methods.
10949         (sparc_ravenscar_prepare_to_store): Remove.
10950         (sparc_ravenscar_ops): Redefine.
10951         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10952         methods and destructor.  Remove members.
10953         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10954         (ravenscar_thread_target::store_registers)
10955         (ravenscar_thread_target::prepare_to_store): Update.
10956         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10957         Remove.
10958         (struct ppc_ravenscar_powerpc_ops): Derive from
10959         ravenscar_arch_ops.
10960         (ppc_ravenscar_powerpc_ops::fetch_registers)
10961         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10962         (ppc_ravenscar_powerpc_ops): Redefine.
10963         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10964         (ppc_ravenscar_e500_ops::fetch_registers)
10965         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10966         (ppc_ravenscar_e500_ops): Redefine.
10967         * aarch64-ravenscar-thread.c
10968         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10969         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10970         (aarch64_ravenscar_fetch_registers)
10971         (aarch64_ravenscar_store_registers): Now methods.
10972         (aarch64_ravenscar_ops): Redefine.
10973
10974 2019-02-15  Tom Tromey  <tromey@adacore.com>
10975
10976         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10977         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10978         (ravenscar_thread_target::stopped_by_watchpoint)
10979         (ravenscar_thread_target::stopped_data_address)
10980         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10981
10982 2019-02-15  Tom Tromey  <tromey@adacore.com>
10983
10984         * ravenscar-thread.c: Fix some typos.
10985
10986 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10987             Tom Tromey  <tromey@adacore.com>
10988
10989         * ada-lang.c (ada_exception_sal): Change addr_string to a
10990         std::string.
10991         (create_ada_exception_catchpoint): Update.
10992
10993 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10994             Tom Tromey  <tromey@adacore.com>
10995
10996         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10997         (bp_location_ops): Remove.
10998         (base_breakpoint_allocate_location): Update.
10999         (free_bp_location): Update.
11000         * ada-lang.c (class ada_catchpoint_location)
11001         <ada_catchpoint_location>: Remove ops parameter.
11002         (ada_catchpoint_location_dtor): Remove.
11003         (ada_catchpoint_location_ops): Remove.
11004         (allocate_location_exception): Update.
11005         * breakpoint.h (struct bp_location_ops): Remove.
11006         (class bp_location) <bp_location>: Remove bp_location_ops
11007         parameter.
11008         <~bp_location>: Add destructor.
11009         <ops>: Remove.
11010
11011 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11012             Pedro Alves  <palves@redhat.com>
11013
11014         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11015         'PATH_MAX'.
11016
11017 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11018             Samuel Thibault  <samuel.thibault@gnu.org>
11019             Thomas Schwinge  <thomas@codesourcery.com>
11020
11021         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11022         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11023
11024 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11025
11026         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11027         (check_empty): Use "const char *".
11028
11029         * gnu-nat.c (gnu_nat_target::detach): Instead of
11030         'detach_inferior (pid)' call
11031         'detach_inferior (find_inferior_pid (pid))'.
11032
11033         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11034         'nat/fork-inferior.o'.
11035         * gnu-nat.c: #include "nat/fork-inferior.h".
11036
11037         * gnu-nat.c (gnu_nat_target::detach): Instead of
11038         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11039         * gnu-nat.h: #include "inf-child.h".
11040         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11041         'i386_gnu_nat_target::fetch_registers'.
11042         (gnu_store_registers): Rename/move to
11043         'i386_gnu_nat_target::store_registers'.
11044
11045         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11046         * gnu-nat.h (mach_thread_info): New function.
11047         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11048
11049         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11050
11051 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11052
11053         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11054
11055 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11056
11057         * windows-nat.c (windows_add_thread): Add new parameter
11058         "main_thread_p" with default value set to false.  Update
11059         function documentation as well as all callers.
11060         (windows_delete_thread): Likewise.
11061         (fake_create_process): Update call to windows_add_thread.
11062         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11063         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11064         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11065         call to windows_delete_thread.
11066
11067 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11068
11069         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11070
11071 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11072
11073         * symfile.c (find_separate_debug_file): Use canonical path of
11074         sysroot with child_path instead of gdb_sysroot if it is valid.
11075
11076 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11077
11078         * symfile.c (find_separate_debug_file): Use child_path to
11079         determine if an object file is under a sysroot.
11080
11081 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11082
11083         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11084         unittests/child-path-selftests.c.
11085         * common/pathstuff.c (child_path): New function.
11086         * common/pathstuff.h (child_path): New prototype.
11087         * unittests/child-path-selftests.c: New file.
11088
11089 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11090
11091         * symfile.c (find_separate_debug_file): Look for separate debug
11092         files in debug directories under the sysroot.
11093
11094 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11095
11096         * symtab.h (struct minimal_symbol data_p): New const method.
11097         (struct minimal_symbol text_p): Likewise.
11098         * symtab.c (output_source_filename): Use file name style
11099         to print file name.
11100         (print_symbol_info): Likewise.
11101         (print_msymbol_info): Use address style to print addresses.
11102         Use function name style to print executable text symbols.
11103         (expand_symtab_containing_pc): Use data_p.
11104         (find_pc_sect_compunit_symtab): Likewise.
11105
11106 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11107
11108         * breakpoint.c (describe_other_breakpoints): Use address style
11109         to print addresses.
11110         (say_where): Likewise.
11111
11112 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11113
11114         * ada-typeprint.c (print_func_type): Print function name
11115         style to print function name.
11116         * c-typeprint.c (c_print_type_1): Likewise.
11117
11118 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11119
11120         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11121         for execve.
11122
11123 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11124
11125         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11126         type_stack.
11127
11128 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11129
11130         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11131         TYPE_CODE_REF types.
11132
11133 2019-02-08  Jim Wilson  <jimw@sifive.com>
11134
11135         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11136         (riscv_linux_fregset): New.
11137         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11138
11139 2019-02-07  Tom Tromey  <tom@tromey.com>
11140
11141         * thread.c (thread_cancel_execution_command): Update.
11142         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11143         methods.
11144         (struct thread_fsm_ops): Remove.
11145         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11146         (thread_fsm_should_stop, thread_fsm_return_value)
11147         (thread_fsm_set_finished, thread_fsm_finished_p)
11148         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11149         Don't declare.
11150         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11151         * infrun.c (clear_proceed_status_thread)
11152         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11153         (print_stop_event): Update.
11154         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11155         Add constructor.
11156         (step_command_fsm_ops): Remove.
11157         (new_step_command_fsm): Remove.
11158         (step_1): Update.
11159         (step_command_fsm::should_stop): Rename from
11160         step_command_fsm_should_stop.
11161         (step_command_fsm::clean_up): Rename from
11162         step_command_fsm_clean_up.
11163         (step_command_fsm::do_async_reply_reason): Rename from
11164         step_command_fsm_async_reply_reason.
11165         (struct until_next_fsm): Inherit from thread_fsm.  Add
11166         constructor.
11167         (until_next_fsm_ops): Remove.
11168         (new_until_next_fsm): Remove.
11169         (until_next_fsm::should_stop): Rename from
11170         until_next_fsm_should_stop.
11171         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11172         (until_next_fsm::do_async_reply_reason): Rename from
11173         until_next_fsm_async_reply_reason.
11174         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11175         constructor.  Change type of breakpoint.
11176         (finish_command_fsm_ops): Remove.
11177         (new_finish_command_fsm): Remove.
11178         (finish_command_fsm::should_stop): Rename from
11179         finish_command_fsm_should_stop.
11180         (finish_command_fsm::clean_up): Rename from
11181         finish_command_fsm_clean_up.
11182         (finish_command_fsm::return_value): Rename from
11183         finish_command_fsm_return_value.
11184         (finish_command_fsm::do_async_reply_reason): Rename from
11185         finish_command_fsm_async_reply_reason.
11186         (finish_command): Update.
11187         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11188         Add constructor.
11189         (call_thread_fsm_ops): Remove.
11190         (call_thread_fsm::call_thread_fsm): Rename from
11191         new_call_thread_fsm.
11192         (call_thread_fsm::should_stop): Rename from
11193         call_thread_fsm_should_stop.
11194         (call_thread_fsm::should_notify_stop): Rename from
11195         call_thread_fsm_should_notify_stop.
11196         (run_inferior_call, call_function_by_hand_dummy): Update.
11197         * cli/cli-interp.c (should_print_stop_to_console): Update.
11198         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11199         Add constructor.  Change type of location_breakpoint,
11200         caller_breakpoint.
11201         (until_break_fsm_ops): Remove.
11202         (new_until_break_fsm): Remove.
11203         (until_break_fsm::should_stop): Rename from
11204         until_break_fsm_should_stop.
11205         (until_break_fsm::clean_up): Rename from
11206         until_break_fsm_clean_up.
11207         (until_break_fsm::do_async_reply_reason): Rename from
11208         until_break_fsm_async_reply_reason.
11209         (until_break_command): Update.
11210         * thread-fsm.c: Remove.
11211         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11212
11213 2019-02-07  Tom Tromey  <tom@tromey.com>
11214
11215         * yy-remap.h: Add include guard.
11216         * xtensa-tdep.h: Add include guard.
11217         * xcoffread.h: Rename include guard.
11218         * varobj-iter.h: Add include guard.
11219         * tui/tui.h: Rename include guard.
11220         * tui/tui-winsource.h: Rename include guard.
11221         * tui/tui-wingeneral.h: Rename include guard.
11222         * tui/tui-windata.h: Rename include guard.
11223         * tui/tui-win.h: Rename include guard.
11224         * tui/tui-stack.h: Rename include guard.
11225         * tui/tui-source.h: Rename include guard.
11226         * tui/tui-regs.h: Rename include guard.
11227         * tui/tui-out.h: Rename include guard.
11228         * tui/tui-layout.h: Rename include guard.
11229         * tui/tui-io.h: Rename include guard.
11230         * tui/tui-hooks.h: Rename include guard.
11231         * tui/tui-file.h: Rename include guard.
11232         * tui/tui-disasm.h: Rename include guard.
11233         * tui/tui-data.h: Rename include guard.
11234         * tui/tui-command.h: Rename include guard.
11235         * tic6x-tdep.h: Add include guard.
11236         * target/waitstatus.h: Rename include guard.
11237         * target/wait.h: Rename include guard.
11238         * target/target.h: Rename include guard.
11239         * target/resume.h: Rename include guard.
11240         * target-float.h: Rename include guard.
11241         * stabsread.h: Add include guard.
11242         * rs6000-tdep.h: Add include guard.
11243         * riscv-fbsd-tdep.h: Add include guard.
11244         * regformats/regdef.h: Rename include guard.
11245         * record.h: Rename include guard.
11246         * python/python.h: Rename include guard.
11247         * python/python-internal.h: Rename include guard.
11248         * python/py-stopevent.h: Rename include guard.
11249         * python/py-ref.h: Rename include guard.
11250         * python/py-record.h: Rename include guard.
11251         * python/py-record-full.h: Rename include guard.
11252         * python/py-record-btrace.h: Rename include guard.
11253         * python/py-instruction.h: Rename include guard.
11254         * python/py-events.h: Rename include guard.
11255         * python/py-event.h: Rename include guard.
11256         * procfs.h: Add include guard.
11257         * proc-utils.h: Add include guard.
11258         * p-lang.h: Add include guard.
11259         * or1k-tdep.h: Rename include guard.
11260         * observable.h: Rename include guard.
11261         * nto-tdep.h: Rename include guard.
11262         * nat/x86-linux.h: Rename include guard.
11263         * nat/x86-linux-dregs.h: Rename include guard.
11264         * nat/x86-gcc-cpuid.h: Add include guard.
11265         * nat/x86-dregs.h: Rename include guard.
11266         * nat/x86-cpuid.h: Rename include guard.
11267         * nat/ppc-linux.h: Rename include guard.
11268         * nat/mips-linux-watch.h: Rename include guard.
11269         * nat/linux-waitpid.h: Rename include guard.
11270         * nat/linux-ptrace.h: Rename include guard.
11271         * nat/linux-procfs.h: Rename include guard.
11272         * nat/linux-osdata.h: Rename include guard.
11273         * nat/linux-nat.h: Rename include guard.
11274         * nat/linux-namespaces.h: Rename include guard.
11275         * nat/linux-btrace.h: Rename include guard.
11276         * nat/glibc_thread_db.h: Rename include guard.
11277         * nat/gdb_thread_db.h: Rename include guard.
11278         * nat/gdb_ptrace.h: Rename include guard.
11279         * nat/fork-inferior.h: Rename include guard.
11280         * nat/amd64-linux-siginfo.h: Rename include guard.
11281         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11282         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11283         * nat/aarch64-linux.h: Rename include guard.
11284         * nat/aarch64-linux-hw-point.h: Rename include guard.
11285         * mn10300-tdep.h: Add include guard.
11286         * mips-linux-tdep.h: Add include guard.
11287         * mi/mi-parse.h: Rename include guard.
11288         * mi/mi-out.h: Rename include guard.
11289         * mi/mi-main.h: Rename include guard.
11290         * mi/mi-interp.h: Rename include guard.
11291         * mi/mi-getopt.h: Rename include guard.
11292         * mi/mi-console.h: Rename include guard.
11293         * mi/mi-common.h: Rename include guard.
11294         * mi/mi-cmds.h: Rename include guard.
11295         * mi/mi-cmd-break.h: Rename include guard.
11296         * m2-lang.h: Add include guard.
11297         * location.h: Rename include guard.
11298         * linux-record.h: Rename include guard.
11299         * linux-nat.h: Add include guard.
11300         * linux-fork.h: Add include guard.
11301         * i386-darwin-tdep.h: Rename include guard.
11302         * hppa-linux-offsets.h: Add include guard.
11303         * guile/guile.h: Rename include guard.
11304         * guile/guile-internal.h: Rename include guard.
11305         * gnu-nat.h: Rename include guard.
11306         * gdb-stabs.h: Rename include guard.
11307         * frv-tdep.h: Add include guard.
11308         * f-lang.h: Add include guard.
11309         * event-loop.h: Add include guard.
11310         * darwin-nat.h: Rename include guard.
11311         * cp-abi.h: Rename include guard.
11312         * config/sparc/nm-sol2.h: Rename include guard.
11313         * config/nm-nto.h: Rename include guard.
11314         * config/nm-linux.h: Add include guard.
11315         * config/i386/nm-i386gnu.h: Rename include guard.
11316         * config/djgpp/nl_types.h: Rename include guard.
11317         * config/djgpp/langinfo.h: Rename include guard.
11318         * compile/gcc-cp-plugin.h: Add include guard.
11319         * compile/gcc-c-plugin.h: Add include guard.
11320         * compile/compile.h: Rename include guard.
11321         * compile/compile-object-run.h: Rename include guard.
11322         * compile/compile-object-load.h: Rename include guard.
11323         * compile/compile-internal.h: Rename include guard.
11324         * compile/compile-cplus.h: Rename include guard.
11325         * compile/compile-c.h: Rename include guard.
11326         * common/xml-utils.h: Rename include guard.
11327         * common/x86-xstate.h: Rename include guard.
11328         * common/version.h: Rename include guard.
11329         * common/vec.h: Rename include guard.
11330         * common/tdesc.h: Rename include guard.
11331         * common/selftest.h: Rename include guard.
11332         * common/scoped_restore.h: Rename include guard.
11333         * common/scoped_mmap.h: Rename include guard.
11334         * common/scoped_fd.h: Rename include guard.
11335         * common/safe-iterator.h: Rename include guard.
11336         * common/run-time-clock.h: Rename include guard.
11337         * common/refcounted-object.h: Rename include guard.
11338         * common/queue.h: Rename include guard.
11339         * common/ptid.h: Rename include guard.
11340         * common/print-utils.h: Rename include guard.
11341         * common/preprocessor.h: Rename include guard.
11342         * common/pathstuff.h: Rename include guard.
11343         * common/observable.h: Rename include guard.
11344         * common/netstuff.h: Rename include guard.
11345         * common/job-control.h: Rename include guard.
11346         * common/host-defs.h: Rename include guard.
11347         * common/gdb_wait.h: Rename include guard.
11348         * common/gdb_vecs.h: Rename include guard.
11349         * common/gdb_unlinker.h: Rename include guard.
11350         * common/gdb_unique_ptr.h: Rename include guard.
11351         * common/gdb_tilde_expand.h: Rename include guard.
11352         * common/gdb_sys_time.h: Rename include guard.
11353         * common/gdb_string_view.h: Rename include guard.
11354         * common/gdb_splay_tree.h: Rename include guard.
11355         * common/gdb_setjmp.h: Rename include guard.
11356         * common/gdb_ref_ptr.h: Rename include guard.
11357         * common/gdb_optional.h: Rename include guard.
11358         * common/gdb_locale.h: Rename include guard.
11359         * common/gdb_assert.h: Rename include guard.
11360         * common/filtered-iterator.h: Rename include guard.
11361         * common/filestuff.h: Rename include guard.
11362         * common/fileio.h: Rename include guard.
11363         * common/environ.h: Rename include guard.
11364         * common/common-utils.h: Rename include guard.
11365         * common/common-types.h: Rename include guard.
11366         * common/common-regcache.h: Rename include guard.
11367         * common/common-inferior.h: Rename include guard.
11368         * common/common-gdbthread.h: Rename include guard.
11369         * common/common-exceptions.h: Rename include guard.
11370         * common/common-defs.h: Rename include guard.
11371         * common/common-debug.h: Rename include guard.
11372         * common/cleanups.h: Rename include guard.
11373         * common/buffer.h: Rename include guard.
11374         * common/btrace-common.h: Rename include guard.
11375         * common/break-common.h: Rename include guard.
11376         * cli/cli-utils.h: Rename include guard.
11377         * cli/cli-style.h: Rename include guard.
11378         * cli/cli-setshow.h: Rename include guard.
11379         * cli/cli-script.h: Rename include guard.
11380         * cli/cli-interp.h: Rename include guard.
11381         * cli/cli-decode.h: Rename include guard.
11382         * cli/cli-cmds.h: Rename include guard.
11383         * charset-list.h: Add include guard.
11384         * buildsym-legacy.h: Rename include guard.
11385         * bfin-tdep.h: Add include guard.
11386         * ax.h: Rename include guard.
11387         * arm-linux-tdep.h: Add include guard.
11388         * arm-fbsd-tdep.h: Add include guard.
11389         * arch/xtensa.h: Rename include guard.
11390         * arch/tic6x.h: Add include guard.
11391         * arch/i386.h: Add include guard.
11392         * arch/arm.h: Rename include guard.
11393         * arch/arm-linux.h: Rename include guard.
11394         * arch/arm-get-next-pcs.h: Rename include guard.
11395         * arch/amd64.h: Add include guard.
11396         * arch/aarch64-insn.h: Rename include guard.
11397         * arch-utils.h: Rename include guard.
11398         * annotate.h: Add include guard.
11399         * amd64-darwin-tdep.h: Rename include guard.
11400         * aarch64-linux-tdep.h: Add include guard.
11401         * aarch64-fbsd-tdep.h: Add include guard.
11402         * aarch32-linux-nat.h: Add include guard.
11403
11404 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11405
11406         * macrotab.c (macro_define_internal): New function that
11407         factorizes macro_define_object_internal and macro_define_function
11408         code.
11409         (macro_define_object_internal): Use macro_define_internal.
11410         (macro_define_function): Likewise.
11411
11412 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11413
11414         * macrocmd.c (extract_identifier): Return
11415         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11416         callers.
11417
11418 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11419
11420         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11421
11422 2019-02-05  Tom Tromey  <tom@tromey.com>
11423
11424         * target.c (target_stack::unpush): Move assertion earlier.
11425
11426 2019-01-30  Tom Tromey  <tom@tromey.com>
11427
11428         PR python/23615:
11429         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11430         (gdbpy_parse_and_eval): Likewise.
11431         * python/python-internal.h (gdbpy_allow_threads): New class.
11432
11433 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11434
11435         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11436         (aarch64_fbsd_fpregmap): Move earlier.
11437         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11438         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11439         instead of individual calls to trad_frame_set_reg_addr.
11440         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11441         earlier.
11442         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11443         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11444         instead of individual calls to trad_frame_set_reg_addr.
11445
11446 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11447
11448         * CONTRIBUTE: Replace contribution list with wiki link.
11449
11450 2019-01-25  Tom Tromey  <tom@tromey.com>
11451
11452         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11453
11454 2019-01-25  Tom Tromey  <tom@tromey.com>
11455
11456         * xtensa-linux-nat.c: Fix common/ includes.
11457         * xml-support.h: Fix common/ includes.
11458         * xml-support.c: Fix common/ includes.
11459         * x86-linux-nat.c: Fix common/ includes.
11460         * windows-nat.c: Fix common/ includes.
11461         * varobj.h: Fix common/ includes.
11462         * varobj.c: Fix common/ includes.
11463         * value.c: Fix common/ includes.
11464         * valops.c: Fix common/ includes.
11465         * utils.c: Fix common/ includes.
11466         * unittests/xml-utils-selftests.c: Fix common/ includes.
11467         * unittests/utils-selftests.c: Fix common/ includes.
11468         * unittests/unpack-selftests.c: Fix common/ includes.
11469         * unittests/tracepoint-selftests.c: Fix common/ includes.
11470         * unittests/style-selftests.c: Fix common/ includes.
11471         * unittests/string_view-selftests.c: Fix common/ includes.
11472         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11473         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11474         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11475         * unittests/rsp-low-selftests.c: Fix common/ includes.
11476         * unittests/parse-connection-spec-selftests.c: Fix common/
11477         includes.
11478         * unittests/optional-selftests.c: Fix common/ includes.
11479         * unittests/offset-type-selftests.c: Fix common/ includes.
11480         * unittests/observable-selftests.c: Fix common/ includes.
11481         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11482         * unittests/memrange-selftests.c: Fix common/ includes.
11483         * unittests/memory-map-selftests.c: Fix common/ includes.
11484         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11485         * unittests/function-view-selftests.c: Fix common/ includes.
11486         * unittests/environ-selftests.c: Fix common/ includes.
11487         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11488         * unittests/common-utils-selftests.c: Fix common/ includes.
11489         * unittests/cli-utils-selftests.c: Fix common/ includes.
11490         * unittests/array-view-selftests.c: Fix common/ includes.
11491         * ui-file.c: Fix common/ includes.
11492         * tui/tui-io.c: Fix common/ includes.
11493         * tracepoint.h: Fix common/ includes.
11494         * tracepoint.c: Fix common/ includes.
11495         * tracefile-tfile.c: Fix common/ includes.
11496         * top.h: Fix common/ includes.
11497         * top.c: Fix common/ includes.
11498         * thread.c: Fix common/ includes.
11499         * target/waitstatus.h: Fix common/ includes.
11500         * target/waitstatus.c: Fix common/ includes.
11501         * target.h: Fix common/ includes.
11502         * target.c: Fix common/ includes.
11503         * target-memory.c: Fix common/ includes.
11504         * target-descriptions.c: Fix common/ includes.
11505         * symtab.h: Fix common/ includes.
11506         * symfile.c: Fix common/ includes.
11507         * stap-probe.c: Fix common/ includes.
11508         * spu-linux-nat.c: Fix common/ includes.
11509         * sparc-nat.c: Fix common/ includes.
11510         * source.c: Fix common/ includes.
11511         * solib.c: Fix common/ includes.
11512         * solib-target.c: Fix common/ includes.
11513         * ser-unix.c: Fix common/ includes.
11514         * ser-tcp.c: Fix common/ includes.
11515         * ser-pipe.c: Fix common/ includes.
11516         * ser-base.c: Fix common/ includes.
11517         * selftest-arch.c: Fix common/ includes.
11518         * s12z-tdep.c: Fix common/ includes.
11519         * rust-exp.y: Fix common/ includes.
11520         * rs6000-aix-tdep.c: Fix common/ includes.
11521         * riscv-tdep.c: Fix common/ includes.
11522         * remote.c: Fix common/ includes.
11523         * remote-notif.h: Fix common/ includes.
11524         * remote-fileio.h: Fix common/ includes.
11525         * remote-fileio.c: Fix common/ includes.
11526         * regcache.h: Fix common/ includes.
11527         * regcache.c: Fix common/ includes.
11528         * record-btrace.c: Fix common/ includes.
11529         * python/python.c: Fix common/ includes.
11530         * python/py-type.c: Fix common/ includes.
11531         * python/py-inferior.c: Fix common/ includes.
11532         * progspace.h: Fix common/ includes.
11533         * producer.c: Fix common/ includes.
11534         * procfs.c: Fix common/ includes.
11535         * proc-api.c: Fix common/ includes.
11536         * printcmd.c: Fix common/ includes.
11537         * ppc-linux-nat.c: Fix common/ includes.
11538         * parser-defs.h: Fix common/ includes.
11539         * osdata.c: Fix common/ includes.
11540         * obsd-nat.c: Fix common/ includes.
11541         * nat/x86-linux.c: Fix common/ includes.
11542         * nat/x86-linux-dregs.c: Fix common/ includes.
11543         * nat/x86-dregs.h: Fix common/ includes.
11544         * nat/x86-dregs.c: Fix common/ includes.
11545         * nat/ppc-linux.c: Fix common/ includes.
11546         * nat/mips-linux-watch.h: Fix common/ includes.
11547         * nat/mips-linux-watch.c: Fix common/ includes.
11548         * nat/linux-waitpid.c: Fix common/ includes.
11549         * nat/linux-ptrace.h: Fix common/ includes.
11550         * nat/linux-ptrace.c: Fix common/ includes.
11551         * nat/linux-procfs.c: Fix common/ includes.
11552         * nat/linux-personality.c: Fix common/ includes.
11553         * nat/linux-osdata.c: Fix common/ includes.
11554         * nat/linux-namespaces.c: Fix common/ includes.
11555         * nat/linux-btrace.h: Fix common/ includes.
11556         * nat/linux-btrace.c: Fix common/ includes.
11557         * nat/fork-inferior.c: Fix common/ includes.
11558         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11559         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11560         * nat/aarch64-linux.c: Fix common/ includes.
11561         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11562         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11563         * namespace.h: Fix common/ includes.
11564         * mips-linux-tdep.c: Fix common/ includes.
11565         * minsyms.c: Fix common/ includes.
11566         * mi/mi-parse.h: Fix common/ includes.
11567         * mi/mi-main.c: Fix common/ includes.
11568         * mi/mi-cmd-env.c: Fix common/ includes.
11569         * memrange.h: Fix common/ includes.
11570         * memattr.c: Fix common/ includes.
11571         * maint.h: Fix common/ includes.
11572         * maint.c: Fix common/ includes.
11573         * main.c: Fix common/ includes.
11574         * machoread.c: Fix common/ includes.
11575         * location.c: Fix common/ includes.
11576         * linux-thread-db.c: Fix common/ includes.
11577         * linux-nat.c: Fix common/ includes.
11578         * linux-fork.c: Fix common/ includes.
11579         * inline-frame.c: Fix common/ includes.
11580         * infrun.c: Fix common/ includes.
11581         * inflow.c: Fix common/ includes.
11582         * inferior.h: Fix common/ includes.
11583         * inferior.c: Fix common/ includes.
11584         * infcmd.c: Fix common/ includes.
11585         * inf-ptrace.c: Fix common/ includes.
11586         * inf-child.c: Fix common/ includes.
11587         * ia64-linux-nat.c: Fix common/ includes.
11588         * i387-tdep.c: Fix common/ includes.
11589         * i386-tdep.c: Fix common/ includes.
11590         * i386-linux-tdep.c: Fix common/ includes.
11591         * i386-linux-nat.c: Fix common/ includes.
11592         * i386-go32-tdep.c: Fix common/ includes.
11593         * i386-fbsd-tdep.c: Fix common/ includes.
11594         * i386-fbsd-nat.c: Fix common/ includes.
11595         * guile/scm-type.c: Fix common/ includes.
11596         * guile/guile.c: Fix common/ includes.
11597         * go32-nat.c: Fix common/ includes.
11598         * gnu-nat.c: Fix common/ includes.
11599         * gdbthread.h: Fix common/ includes.
11600         * gdbarch-selftests.c: Fix common/ includes.
11601         * gdb_usleep.c: Fix common/ includes.
11602         * gdb_select.h: Fix common/ includes.
11603         * gdb_bfd.c: Fix common/ includes.
11604         * gcore.c: Fix common/ includes.
11605         * fork-child.c: Fix common/ includes.
11606         * findvar.c: Fix common/ includes.
11607         * fbsd-nat.c: Fix common/ includes.
11608         * event-top.c: Fix common/ includes.
11609         * event-loop.c: Fix common/ includes.
11610         * dwarf2read.c: Fix common/ includes.
11611         * dwarf2loc.c: Fix common/ includes.
11612         * dwarf2-frame.c: Fix common/ includes.
11613         * dwarf-index-cache.c: Fix common/ includes.
11614         * dtrace-probe.c: Fix common/ includes.
11615         * disasm-selftests.c: Fix common/ includes.
11616         * defs.h: Fix common/ includes.
11617         * csky-tdep.c: Fix common/ includes.
11618         * cp-valprint.c: Fix common/ includes.
11619         * cp-support.h: Fix common/ includes.
11620         * cp-support.c: Fix common/ includes.
11621         * corelow.c: Fix common/ includes.
11622         * completer.h: Fix common/ includes.
11623         * completer.c: Fix common/ includes.
11624         * compile/compile.c: Fix common/ includes.
11625         * compile/compile-loc2c.c: Fix common/ includes.
11626         * compile/compile-cplus-types.c: Fix common/ includes.
11627         * compile/compile-cplus-symbols.c: Fix common/ includes.
11628         * command.h: Fix common/ includes.
11629         * cli/cli-dump.c: Fix common/ includes.
11630         * cli/cli-cmds.c: Fix common/ includes.
11631         * charset.c: Fix common/ includes.
11632         * build-id.c: Fix common/ includes.
11633         * btrace.h: Fix common/ includes.
11634         * btrace.c: Fix common/ includes.
11635         * breakpoint.h: Fix common/ includes.
11636         * breakpoint.c: Fix common/ includes.
11637         * ax.h:
11638         (enum agent_op): Fix common/ includes.
11639         * ax-general.c (struct aop_map): Fix common/ includes.
11640         * ax-gdb.c: Fix common/ includes.
11641         * auxv.c: Fix common/ includes.
11642         * auto-load.c: Fix common/ includes.
11643         * arm-tdep.c: Fix common/ includes.
11644         * arch/riscv.c: Fix common/ includes.
11645         * arch/ppc-linux-common.c: Fix common/ includes.
11646         * arch/i386.c: Fix common/ includes.
11647         * arch/arm.c: Fix common/ includes.
11648         * arch/arm-linux.c: Fix common/ includes.
11649         * arch/arm-get-next-pcs.c: Fix common/ includes.
11650         * arch/amd64.c: Fix common/ includes.
11651         * arch/aarch64.c: Fix common/ includes.
11652         * arch/aarch64-insn.c: Fix common/ includes.
11653         * arch-utils.c: Fix common/ includes.
11654         * amd64-windows-tdep.c: Fix common/ includes.
11655         * amd64-tdep.c: Fix common/ includes.
11656         * amd64-sol2-tdep.c: Fix common/ includes.
11657         * amd64-obsd-tdep.c: Fix common/ includes.
11658         * amd64-nbsd-tdep.c: Fix common/ includes.
11659         * amd64-linux-tdep.c: Fix common/ includes.
11660         * amd64-linux-nat.c: Fix common/ includes.
11661         * amd64-fbsd-tdep.c: Fix common/ includes.
11662         * amd64-fbsd-nat.c: Fix common/ includes.
11663         * amd64-dicos-tdep.c: Fix common/ includes.
11664         * amd64-darwin-tdep.c: Fix common/ includes.
11665         * agent.c: Fix common/ includes.
11666         * ada-lang.h: Fix common/ includes.
11667         * ada-lang.c: Fix common/ includes.
11668         * aarch64-tdep.c: Fix common/ includes.
11669
11670 2019-01-25  Tom Tromey  <tom@tromey.com>
11671
11672         * common/create-version.sh: Use common/version.h.
11673
11674 2019-01-24  Pedro Alves  <palves@redhat.com>
11675
11676         * infrun.c (signal_stop, signal_print, signal_program)
11677         (signal_catch, signal_pass): Now arrays instead of pointers.
11678         (update_signals_program_target, do_target_resume)
11679         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11680         * linux-nat.c (linux_nat_target::pass_signals)
11681         (linux_nat_target::create_inferior, linux_nat_target::attach):
11682         Adjust.
11683         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11684         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11685         * procfs.c (procfs_target::pass_signals): Adjust.
11686         * record-full.c (record_full_target::resume): Adjust.
11687         * remote.c (remote_target::pass_signals)
11688         (remote_target::program_signals): Adjust.
11689         * target-debug.h (target_debug_print_signals): Now takes a
11690         gdb::array_view as parameter.  Adjust.
11691         * target.h (target_ops) <pass_signals, program_signals>: Replace
11692         pointer and length parameters with gdb::array_view.
11693         (target_pass_signals, target_program_signals): Likewise.
11694         * target-delegates.c: Regenerate.
11695
11696 2019-01-24  Pedro Alves  <palves@redhat.com>
11697
11698         * common/forward-scope-exit.h
11699         (forward_scope_exit::forward_scope_exit): Pass arguments to
11700         m_bind_function directly, instead of creating a std::bind and
11701         copying that.
11702
11703 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11704
11705         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11706         for static members.
11707         (pass_in_v_vfp_candidate): Likewise.
11708
11709 2019-01-23  Tom Tromey  <tom@tromey.com>
11710             Pedro Alves  <palves@redhat.com>
11711
11712         * regcache.c (class regcache_invalidator): Remove.
11713         (regcache::raw_write): Use make_scope_exit.
11714
11715 2019-01-23  Tom Tromey  <tom@tromey.com>
11716
11717         * ui-out.h (class ui_out_emit_type): Update comment.
11718
11719 2019-01-23  Tom Tromey  <tom@tromey.com>
11720
11721         * infrun.c (fetch_inferior_event): Update comment.
11722
11723 2019-01-23  Tom Tromey  <tom@tromey.com>
11724             Pedro Alves  <palves@redhat.com>
11725
11726         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11727         parameter.
11728         (fetch_inferior_event): Use SCOPE_EXIT.
11729
11730
11731 2019-01-23  Tom Tromey  <tom@tromey.com>
11732             Pedro Alves  <palves@redhat.com>
11733
11734         * infrun.c (disable_thread_events): Delete.
11735         (stop_all_threads): Use SCOPE_EXIT.
11736
11737 2019-01-23  Tom Tromey  <tom@tromey.com>
11738             Pedro Alves  <palves@redhat.com>
11739
11740         * symfile.c: Include forward-scope-exit.h.
11741         (clear_symtab_users_cleanup): Replace forward declaration with
11742         a FORWARD_SCOPE_EXIT.
11743         (syms_from_objfile_1): Use the forward_scope_exit and
11744         gdb::optional instead of cleanup_function.
11745         (reread_symbols): Use the forward_scope_exit instead of
11746         cleanup_function.
11747         (clear_symtab_users_cleanup): Remove function.
11748
11749 2019-01-23  Tom Tromey  <tom@tromey.com>
11750             Pedro Alves  <palves@redhat.com>
11751
11752         * linux-nat.c: Include scope-exit.h.
11753         (cleanup_target_stop): Remove.
11754         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11755         SCOPE_EXIT.
11756
11757 2019-01-23  Tom Tromey  <tom@tromey.com>
11758             Pedro Alves  <palves@redhat.com>
11759
11760         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11761         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11762
11763 2019-01-23  Tom Tromey  <tom@tromey.com>
11764             Andrew Burgess  <andrew.burgess@embecosm.com>
11765             Pedro Alves  <palves@redhat.com>
11766
11767         * infrun.c (fetch_inferior_event): Use scope_exit.
11768         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11769         * top.c (execute_command): Use scope_exit.
11770         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11771         * utils.c (do_bpstat_clear_actions_cleanup)
11772         (make_bpstat_clear_actions_cleanup): Remove.
11773
11774 2019-01-23  Tom Tromey  <tom@tromey.com>
11775             Pedro Alves  <palves@redhat.com>
11776
11777         * infrun.c: Include "common/scope-exit.h"
11778         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11779         (wait_for_inferior): Use SCOPE_EXIT.
11780         (fetch_inferior_event): Use scope_exit.
11781
11782 2019-01-23  Tom Tromey  <tom@tromey.com>
11783             Pedro Alves  <palves@redhat.com>
11784
11785         * breakpoint.c (create_breakpoint): Remove cleanup.
11786
11787 2019-01-23  Tom Tromey  <tom@tromey.com>
11788             Andrew Burgess  <andrew.burgess@embecosm.com>
11789             Pedro Alves  <palves@redhat.com>
11790
11791 2019-01-23  Pedro Alves  <palves@redhat.com>
11792
11793         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11794
11795 2019-01-23  Pedro Alves  <palves@redhat.com>
11796             Andrew Burgess  <andrew.burgess@embecosm.com>
11797
11798         * gdbthread.h: Include "common/forward-scope-exit.h".
11799         (scoped_finish_thread_state): Redefine custom class in terms of
11800         forward_scope_exit.
11801
11802 2019-01-23  Pedro Alves  <palves@redhat.com>
11803             Andrew Burgess  <andrew.burgess@embecosm.com>
11804
11805         * common/forward-scope-exit.h: New file.
11806
11807 2019-01-23  Pedro Alves  <palves@redhat.com>
11808             Andrew Burgess  <andrew.burgess@embecosm.com>
11809             Tom Tromey  <tom@tromey.com>
11810
11811         * common/scope-exit.h: New file.
11812
11813 2019-01-23  Pedro Alves  <palves@redhat.com>
11814
11815         * common/preprocessor.h (ESC): Rename to ...
11816         (ESC_PARENS): ... this.
11817         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11818         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11819
11820 2019-01-23  Tom Tromey  <tom@tromey.com>
11821
11822         * language.h (class scoped_switch_to_sym_language_if_auto):
11823         Initialize m_lang in both cases.
11824
11825 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11826
11827         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11828         with XCNEW.
11829
11830 2019-01-22  Tom Tromey  <tom@tromey.com>
11831
11832         * corelow.c: Do not include sys/file.h.
11833
11834 2019-01-22  Tom Tromey  <tom@tromey.com>
11835
11836         * tui/tui-wingeneral.h: Include gdb_curses.h.
11837
11838 2019-01-22  Tom Tromey  <tom@tromey.com>
11839
11840         * source-cache.h (class source_cache) <get_source_lines,
11841         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11842
11843 2019-01-22  Tom Tromey  <tom@tromey.com>
11844
11845         * remote-fileio.h (struct remote_target): Declare.
11846
11847 2019-01-22  Tom Tromey  <tom@tromey.com>
11848
11849         * python/py-arch.c: Do not include py-ref.h.
11850         * python/py-bpevent.c: Do not include py-ref.h.
11851         * python/py-cmd.c: Do not include py-ref.h.
11852         * python/py-continueevent.c: Do not include py-ref.h.
11853         * python/py-event.h: Do not include py-ref.h.
11854         * python/py-evtregistry.c: Do not include py-ref.h.
11855         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11856         * python/py-frame.c: Do not include py-ref.h.
11857         * python/py-framefilter.c: Do not include py-ref.h.
11858         * python/py-function.c: Do not include py-ref.h.
11859         * python/py-infevents.c: Do not include py-ref.h.
11860         * python/py-linetable.c: Do not include py-ref.h.
11861         * python/py-objfile.c: Do not include py-ref.h.
11862         * python/py-param.c: Do not include py-ref.h.
11863         * python/py-prettyprint.c: Do not include py-ref.h.
11864         * python/py-progspace.c: Do not include py-ref.h.
11865         * python/py-symbol.c: Do not include py-ref.h.
11866         * python/py-symtab.c: Do not include py-ref.h.
11867         * python/py-type.c: Do not include py-ref.h.
11868         * python/py-unwind.c: Do not include py-ref.h.
11869         * python/py-utils.c: Do not include py-ref.h.
11870         * python/py-value.c: Do not include py-ref.h.
11871         * python/py-varobj.c: Do not include py-ref.h.
11872         * python/py-xmethods.c: Do not include py-ref.h.
11873         * python/python.c: Do not include py-ref.h.
11874         * varobj.c: Do not include py-ref.h.
11875
11876 2019-01-22  Tom Tromey  <tom@tromey.com>
11877
11878         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11879         keyword for bcache.
11880
11881 2019-01-22  Tom Tromey  <tom@tromey.com>
11882
11883         * compile/compile-cplus-types.c: Remove a comment by #include.
11884
11885 2019-01-22  Tom Tromey  <tom@tromey.com>
11886
11887         * compile/gcc-c-plugin.h: Include compile-internal.h.
11888
11889 2019-01-22  Tom Tromey  <tom@tromey.com>
11890
11891         * stabsread.c (EXTERN): Do not define.
11892         (symnum, next_symbol_text_func, processing_gcc_compilation)
11893         (within_function, global_sym_chain, global_stabs)
11894         (previous_stab_code, this_object_header_files)
11895         (n_this_object_header_files)
11896         (n_allocated_this_object_header_files): Define.
11897         * stabsread.h (EXTERN): Never define.  Use "extern".
11898
11899 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11900
11901         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11902         history_value.
11903
11904 2019-01-21  Tom Tromey  <tom@tromey.com>
11905
11906         * ui-out.c: Fix includes.
11907         * tui/tui-source.c: Fix includes.
11908         * target.c: Fix includes.
11909         * remote.c: Fix includes.
11910         * regcache.c: Fix includes.
11911         * python/py-block.c: Fix includes.
11912         * printcmd.c: Fix includes.
11913         * or1k-tdep.c: Fix includes.
11914         * mi/mi-main.c: Fix includes.
11915         * m32r-tdep.c: Fix includes.
11916         * csky-tdep.c: Fix includes.
11917         * compile/compile-cplus-types.c: Fix includes.
11918         * cli/cli-interp.c: Fix includes.
11919
11920 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11921
11922         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11923         for padding.
11924
11925 2019-01-16  Tom Tromey  <tom@tromey.com>
11926
11927         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11928         earlier.
11929         (struct objfile) <msymbols_range>: Move from top level.
11930         <msymbols>: New method.
11931         (class objfile_msymbols): Remove.
11932         * symtab.c (default_collect_symbol_completion_matches_break_on):
11933         Update.
11934         * symmisc.c (dump_msymbols): Update.
11935         * stabsread.c (scan_file_globals): Update.
11936         * objc-lang.c (info_selectors_command, info_classes_command)
11937         (find_methods): Update.
11938         * minsyms.c (find_solib_trampoline_target): Update.
11939         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11940         * coffread.c (coff_symfile_read): Update.
11941         * ada-lang.c (ada_lookup_simple_minsym)
11942         (ada_collect_symbol_completion_matches): Update.
11943
11944 2019-01-16  Tom Tromey  <tom@tromey.com>
11945
11946         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11947         type.  Remove no-argument constructor.
11948         <iterator::operator++>: Simplify.
11949         <begin>: Update.
11950         <end>: Use minimal_symbol_count.
11951
11952 2019-01-16  Tom Tromey  <tom@tromey.com>
11953
11954         * objfiles.h (struct objfile) <psymtabs>: New method.
11955         (class objfile_psymtabs): Remove.
11956         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11957         typedef.
11958         <range>: New method.
11959         (require_partial_symbols): Change return type.
11960         * psymtab.c (require_partial_symbols)
11961         (psym_expand_symtabs_matching): Update.
11962         * mdebugread.c (parse_partial_symbols): Update.
11963         * dbxread.c (dbx_end_psymtab): Update.
11964
11965 2019-01-15  Tom Tromey  <tom@tromey.com>
11966
11967         * symtab.c (lookup_objfile_from_block)
11968         (lookup_symbol_in_objfile_symtabs)
11969         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11970         (find_line_symtab, info_sources_command)
11971         (default_collect_symbol_completion_matches_break_on)
11972         (make_source_files_completion_list): Update.
11973         * symmisc.c (print_objfile_statistics, dump_objfile)
11974         (maintenance_print_symbols, maintenance_info_symtabs)
11975         (maintenance_check_symtabs, maintenance_info_line_tables):
11976         Update.
11977         * source.c (select_source_symtab)
11978         (forget_cached_source_info_for_objfile): Update.
11979         * objfiles.h (class objfile_compunits): Remove.
11980         (struct objfile) <compunits_range>: New typedef.
11981         (compunits): New method.
11982         * objfiles.c (objfile_relocate1): Update.
11983         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11984         * maint.c (count_symtabs_and_blocks): Update.
11985         * linespec.c (iterate_over_all_matching_symtabs): Update.
11986         * cp-support.c (add_symbol_overload_list_qualified): Update.
11987         * coffread.c (coff_symtab_read): Update.
11988         * ada-lang.c (add_nonlocal_symbols)
11989         (ada_collect_symbol_completion_matches)
11990         (ada_add_global_exceptions): Update.
11991
11992 2019-01-15  Tom Tromey  <tom@tromey.com>
11993
11994         * progspace.h (program_space) <objfiles_safe_range>: New
11995         typedef.
11996         <objfiles_safe>: New method.
11997         * objfiles.h (class all_objfiles_safe): Remove.
11998         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11999         * jit.c (jit_inferior_exit_hook): Update.
12000
12001 2019-01-17  Tom Tromey  <tom@tromey.com>
12002
12003         * progspace.h (program_space) <objfiles_range>: New typedef.
12004         <objfiles>: New method.
12005         <objfiles_head>: Rename from objfiles.
12006         (object_files): Update.
12007         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12008         * guile/scm-pretty-print.c
12009         (ppscm_find_pretty_printer_from_objfiles): Update.
12010         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12011         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12012         Update.
12013         * python/py-progspace.c (pspy_get_objfiles): Update.
12014         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12015         Update.
12016         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12017         (objfpy_lookup_objfile_by_build_id): Update.
12018         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12019         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12020         Update.
12021         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12022         (expand_symtab_containing_pc, lookup_objfile_from_block)
12023         (lookup_static_symbol, basic_lookup_transparent_type)
12024         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12025         (find_line_symtab, info_sources_command)
12026         (default_collect_symbol_completion_matches_break_on)
12027         (make_source_files_completion_list, find_main_name): Update.
12028         * symmisc.c (print_symbol_bcache_statistics)
12029         (print_objfile_statistics, maintenance_print_symbols)
12030         (maintenance_print_msymbols, maintenance_print_objfiles)
12031         (maintenance_info_symtabs, maintenance_check_symtabs)
12032         (maintenance_expand_symtabs, maintenance_info_line_tables):
12033         Update.
12034         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12035         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12036         (map_overlay_command, unmap_overlay_command)
12037         (simple_overlay_update, expand_symtabs_matching)
12038         (map_symbol_filenames): Update.
12039         * symfile-debug.c (set_debug_symfile): Update.
12040         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12041         Update.
12042         * source.c (select_source_symtab, forget_cached_source_info):
12043         Update.
12044         * solib.c (solib_read_symbols): Update.
12045         * solib-spu.c (append_ocl_sos): Update.
12046         * psymtab.c (maintenance_print_psymbols)
12047         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12048         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12049         * printcmd.c (info_symbol_command): Update.
12050         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12051         Update.
12052         * objfiles.h (class all_objfiles): Remove.
12053         * objfiles.c (have_partial_symbols, have_full_symbols)
12054         (have_minimal_symbols, qsort_cmp, update_section_map)
12055         (shared_objfile_contains_address_p)
12056         (default_iterate_over_objfiles_in_search_order): Update.
12057         * objc-lang.c (info_selectors_command, info_classes_command)
12058         (find_methods): Update.
12059         * minsyms.c (find_solib_trampoline_target): Update.
12060         * maint.c (maintenance_info_sections)
12061         (maintenance_translate_address, count_symtabs_and_blocks):
12062         Update.
12063         * main.c (captured_main_1): Update.
12064         * linux-thread-db.c (try_thread_db_load_from_pdir)
12065         (has_libpthread): Update.
12066         * linespec.c (iterate_over_all_matching_symtabs)
12067         (search_minsyms_for_name): Update.
12068         * jit.c (jit_find_objf_with_entry_addr): Update.
12069         * hppa-tdep.c (find_unwind_entry)
12070         (hppa_lookup_stub_minimal_symbol): Update.
12071         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12072         Update.
12073         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12074         (elf_gnu_ifunc_resolve_by_got): Update.
12075         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12076         * dwarf-index-write.c (save_gdb_index_command): Update.
12077         * cp-support.c (add_symbol_overload_list_qualified): Update.
12078         * breakpoint.c (create_overlay_event_breakpoint)
12079         (create_longjmp_master_breakpoint)
12080         (create_std_terminate_master_breakpoint)
12081         (create_exception_master_breakpoint): Update.
12082         * blockframe.c (find_pc_partial_function): Update.
12083         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12084         (ada_collect_symbol_completion_matches)
12085         (ada_add_global_exceptions): Update.
12086
12087 2019-01-17  Tom Tromey  <tom@tromey.com>
12088
12089         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12090         declare VEC.
12091         (solib_target_parse_libraries): Change return type.
12092         (library_list_start_segment, library_list_start_section)
12093         (library_list_end_library, library_list_start_library); Update.
12094         (solib_target_free_library_list): Remove.
12095         (solib_target_parse_libraries): Remove cleanup.  Change return
12096         type.
12097         (solib_target_current_sos): Update.
12098
12099 2019-01-17  Tom Tromey  <tromey@bapiya>
12100
12101         * valprint.c: Replace "the the" with "the".
12102         * symtab.c: Replace "the the" with "the".
12103         * solib.c: Replace "the the" with "the".
12104         * solib-dsbt.c: Replace "the the" with "the".
12105         * linespec.c: Replace "the the" with "the".
12106         * dwarf2loc.h: Replace "the the" with "the".
12107         * amd64-windows-tdep.c: Replace "the the" with "the".
12108         * aarch64-tdep.c: Replace "the the" with "the".
12109
12110 2019-01-16  Keith Seitz  <keiths@redhat.com>
12111
12112         PR gdb/23773
12113         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12114         <builder>: Rename to ..
12115         <m_builder>: ... this and make private.
12116         (dwarf2_cu::get_builder): New method.  Change all users of
12117         `builder' to use this method.
12118         (dwarf2_start_symtab): Move to ...
12119         (dwarf2_cu::start_symtab): ... here.  Update all callers
12120         (setup_type_unit_groups): Move to ...
12121         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12122         callers.
12123         (dwarf2_cu::reset_builder): New method.
12124         (process_full_compunit, process_full_type_unit): Use
12125         dwarf2_cu::reset_builder.
12126         (follow_die_offset): Record the ancestor CU if it is different
12127         from the followed DIE's CU.
12128         (follow_die_sig_1): Likewise.
12129
12130 2019-01-15  Tom Tromey  <tom@tromey.com>
12131
12132         * remote.c (class remote_state) <buf>: Now a char_vector.
12133         <buf_size>: Remove.
12134         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12135         parameter.
12136         (remote_target::getpkt_or_notif_sane_1)
12137         (remote_target::getpkt_sane)
12138         (remote_target::getpkt_or_notif_sane): Likewise.
12139         (class remote_target) <putpkt>: New overload.
12140         (remote_target::read_frame): Change type of "buf_p".  Remove
12141         sizeof_p parameter.
12142         (packet_ok): New overload.
12143         (packet_check_result): New overload.
12144         Update all uses.
12145
12146 2019-01-14  Tom Tromey  <tom@tromey.com>
12147
12148         * remote-notif.c (handle_notification, remote_notif_ack)
12149         (remote_notif_parse): Make "buf" const.
12150         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12151         const.
12152         (remote_notif_parse, remote_notif_ack, handle_notification):
12153         Likewise.
12154         * remote.c (remote_notif_stop_parse): Make "buf" const.
12155         (remote_target::remote_parse_stop_reply): Make "buf" const.
12156         (remote_notif_stop_ack): Make "buf" const.
12157
12158 2019-01-14  Tom Tromey  <tom@tromey.com>
12159
12160         * remote.c (remote_console_output): Make parameter const.
12161
12162 2019-01-14  Tom Tromey  <tom@tromey.com>
12163
12164         * target-debug.h (target_debug_print_signals): Constify.
12165         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12166         * procfs.c (procfs_target::pass_signals): Update.
12167         * linux-nat.c (linux_nat_target::pass_signals): Update.
12168         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12169         * target-delegates.c: Rebuild.
12170         * remote.c (remote_target::program_signals): Update.
12171         (remote_target::pass_signals): Update.
12172         * target.c (target_pass_signals): Constify argument.
12173         (target_program_signals): Likewise.
12174         * target.h (struct target_ops) <pass_signals, program_signals>:
12175         Constify argument.
12176         (target_pass_signals, target_program_signals): Constify argument.
12177
12178 2019-01-14  Tom Tromey  <tom@tromey.com>
12179
12180         PR tui/28819:
12181         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12182
12183 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12184
12185         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12186         field.
12187         * rs6000-tdep.c: Include reggroups.h.
12188         (IS_V_ALIAS_PSEUDOREG): Define.
12189         (rs6000_register_name): Return names for the "vX" aliases.
12190         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12191         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12192         aliases.  Call default_register_reggroup_p for all other
12193         pseudo-registers.
12194         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12195         New functions.
12196         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12197         Handle "vX" aliases.
12198         (v_alias_pseudo_register_collect): New function.
12199         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12200         (rs6000_gdbarch_init): Initialize "vX" aliases as
12201         pseudo-registers.  Restore registration of
12202         rs6000_pseudo_register_reggroup_p with
12203         set_tdesc_pseudo_register_reggroup_p.
12204
12205 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12206
12207         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12208         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12209         set_gdbarch_num_pseudo_regs.
12210
12211 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12212
12213         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12214         Remove arg prefixname, add do_set and do_show.
12215         Add member functions set_list and show_list.
12216         * cli/cli-style.c (class cli_style_option): Update accordingly.
12217         (style_set_list): Move to file scope.
12218         (style_show_list): Likewise.
12219         (set_style): Call help_list.
12220         (show_style): Call cmd_show_list.
12221         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12222         Update to use the new macro.
12223
12224 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12225
12226         * ada-lang.c (_initialize_ada_language): Expand the help text
12227         for the "catch exception" command.
12228
12229 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12230
12231         * symtab.c (matching_obj_sections): Initialize obj,
12232         declare it closer to its usage.
12233
12234 2019-01-10  Tom Tromey  <tom@tromey.com>
12235
12236         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12237         (basic_inf_threads_range): Remove.
12238         (inf_threads_range, inf_non_exited_threads_range)
12239         (safe_inf_threads_range): Use next_adapter.
12240
12241 2019-01-10  Keith Seitz  <keiths@redhat.com>
12242
12243         PR gdb/23712
12244         PR symtab/23010
12245         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12246         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12247
12248 2019-01-10  Keith Seitz  <keiths@redhat.com>
12249
12250         PR gdb/23712
12251         PR symtab/23010
12252         * dictionary.c (pending_to_vector): Remove.
12253         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12254         Remove _1 suffix, replacing functions of the same name.  Update
12255         all callers.
12256         (dict_create_hashed, dict_create_hashed_expandable)
12257         (dict_create_linear, dict_create_linear_expandable, dict_free)
12258         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12259         Make functions static.
12260
12261 2019-01-10  Keith Seitz  <keiths@redhat.com>
12262
12263         PR gdb/23712
12264         PR symtab/23010
12265         * dictionary.h (struct dictionary): Replace declaration with
12266         multidictionary.
12267         (dict_create_hashed, dict_create_hashed_expandable)
12268         (dict_create_linear, dict_create_linear_expandable)
12269         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12270         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12271         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12272         taking multidictionary argument.
12273         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12274         * block.h (struct block) <dict>: Change to multidictionary
12275         and rename `multidict'.
12276         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12277         symmisc.c: Update all dictionary references to multidictionary.
12278
12279 2019-01-10  Keith Seitz  <keiths@redhat.com>
12280
12281         PR gdb/23712
12282         PR symtab/23010
12283         * dictionary.c: Include unordered_map.
12284         (pending_to_vector): New function.
12285         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12286         Rewrite the non-"_1" functions to take vector instead
12287         of linked list.
12288         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12289         "new" _1 versions of the same name.
12290         (multidictionary): Define.
12291         (std::hash<enum language): New definition.
12292         (collate_pending_symbols_by_language, mdict_create_hashed)
12293         (mdict_create_hashed_expandable, mdict_create_linear)
12294         (mdict_create_linear_expandable, mdict_free)
12295         (find_language_dictionary, create_new_language_dictionary)
12296         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12297         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12298         (mdict_size, mdict_empty): New functions.
12299         * dictionary.h (mdict_iterator): Define.
12300
12301 2019-01-10  Pedro Alves  <palves@redhat.com>
12302
12303         * breakpoint.c (read_uploaded_action)
12304         (create_tracepoint_from_upload): Adjust to use
12305         gdb::unique_xmalloc_ptr.
12306         * ctf.c (ctf_write_uploaded_tp):
12307         (SET_ARRAY_FIELD): Use emplace_back.
12308         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12309         * tracefile-tfile.c (tfile_write_uploaded_tp):
12310         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12311         gdb::unique_xmalloc_ptr.
12312         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12313         at_string, cond_string, cmd_strings>: Replace char pointers
12314         with gdb::unique_xmalloc_ptr.
12315
12316 2019-01-10  Pedro Alves  <palves@redhat.com>
12317
12318         * solib-target.c (library_list_start_library): Don't xstrdup name.
12319
12320 2019-01-10  Pedro Alves  <palves@redhat.com>
12321
12322         * mdebugread.c (parse_partial_symbols): Use
12323         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12324
12325 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12326
12327         * linux-fork.c (scoped_switch_fork_info)
12328         <~scoped_switch_fork_info>: Fix incorrect variable name.
12329
12330 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12331
12332         * linux-fork.c (scoped_switch_fork_info)
12333         <scoped_switch_fork_info>: Make explicit.
12334         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12335
12336 2019-01-10  Tom Tromey  <tom@tromey.com>
12337
12338         * objfiles.h (objfile::reset_psymtabs): Update.
12339         * objfiles.c (objfile::objfile): Update.
12340         * psymtab.h (psymtab_storage::obstack): Update.
12341         (psymtab_storage::m_obstack): Use gdb::optional.
12342         (class psymtab_storage): Update comment.  Remove objfile
12343         parameter.
12344         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12345
12346 2019-01-10  Tom Tromey  <tom@tromey.com>
12347
12348         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12349         <free_psymtabs>: Now private.
12350         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12351         (allocate_psymtab): Use new method.
12352
12353 2019-01-10  Tom Tromey  <tom@tromey.com>
12354
12355         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12356         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12357         * mdebugread.c (parse_partial_symbols): Use
12358         allocate_dependencies.
12359         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12360         allocate_dependencies.
12361         (process_psymtab_comp_unit_reader)
12362         (build_type_psymtab_dependencies): Likewise.
12363         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12364
12365 2019-01-10  Tom Tromey  <tom@tromey.com>
12366
12367         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12368         PSYMBOL_SET_LANGUAGE.
12369         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12370
12371 2019-01-10  Tom Tromey  <tom@tromey.com>
12372
12373         * psymtab.h (psymtab_storage::obstack): New method.
12374         <m_obstack>: Rename from obstack; now private.
12375         * psymtab.c (psymtab_storage): Update.
12376         * dwarf2read.c (create_addrmap_from_index)
12377         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12378         Update.
12379
12380 2019-01-10  Tom Tromey  <tom@tromey.com>
12381
12382         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12383         * objfiles.h (objfile::reset_psymtabs): New method.
12384
12385 2019-01-10  Tom Tromey  <tom@tromey.com>
12386
12387         * symmisc.c (print_symbol_bcache_statistics): Update.
12388         (print_objfile_statistics): Update.
12389         * symfile.c (reread_symbols): Update.
12390         * psymtab.h (class psymtab_storage): New.
12391         * psymtab.c (psymtab_storage): New constructor.
12392         (~psymtab_storage): New destructor.
12393         (require_partial_symbols): Update.
12394         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12395         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12396         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12397         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12398         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12399         (start_psymtab_common, end_psymtab_common)
12400         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12401         (allocate_psymtab): Update.
12402         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12403         Update.
12404         (dump_psymtab_addrmap, maintenance_print_psymbols)
12405         (maintenance_check_psymtabs): Update.
12406         (class objfile_psymtabs): Move to objfiles.h.
12407         * psympriv.h (discard_psymtab): Now inline.
12408         (psymtab_discarder::psymtab_discarder): Update.
12409         (psymtab_discarder::~psymtab_discarder): Update.
12410         (ALL_OBJFILE_PSYMTABS): Rewrite.
12411         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12412         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12413         Remove fields.
12414         <partial_symtabs>: New field.
12415         (class objfile_psymtabs): Move from psymtab.h.  Update.
12416         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12417         psymbol_cache.
12418         (objfile::~objfile): Don't destroy psymbol_cache.
12419         * mdebugread.c (parse_partial_symbols): Update.
12420         * dwarf2read.c (create_addrmap_from_index)
12421         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12422         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12423         (add_partial_subprogram, dwarf2_ranges_read): Update.
12424         * dwarf-index-write.c (write_address_map)
12425         (write_one_signatured_type, recursively_write_psymbols)
12426         (class debug_names, class debug_names, write_psymtabs_to_index):
12427         Update.
12428
12429 2019-01-10  Tom Tromey  <tom@tromey.com>
12430
12431         * symtab.h (SYMBOL_SET_NAMES): Update.
12432         (symbol_set_names): Update.
12433         (MSYMBOL_SET_NAMES): Update.
12434         * symtab.c (symbol_set_names): Change argument to be an
12435         objfile_per_bfd_storage.
12436         * psymtab.c (add_psymbol_to_bcache): Update.
12437         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12438
12439 2019-01-10  Tom Tromey  <tom@tromey.com>
12440
12441         * symtab.c (create_demangled_names_hash): Change argument to be an
12442         objfile_per_bfd_storage.
12443         (symbol_set_names): Update.
12444
12445 2019-01-10  Tom Tromey  <tom@tromey.com>
12446
12447         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12448         init_psymbol_list.
12449         * psymtab.c (init_psymbol_list): Do nothing if already called.
12450         * psympriv.h (init_psymbol_list): Add comment.
12451         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12452         init_psymbol_list.
12453         * dbxread.c (dbx_symfile_read): Unconditionally call
12454         init_psymbol_list.
12455
12456 2019-01-10  Tom Tromey  <tom@tromey.com>
12457
12458         * xcoffread.c (scan_xcoff_symtab): Update.
12459         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12460         "where".
12461         * mdebugread.c (parse_partial_symbols)
12462         (handle_psymbol_enumerators): Update.
12463         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12464         * dbxread.c (read_dbx_symtab): Update.
12465         * psympriv.h (psymbol_placement): New enum.
12466         (add_psymbol_to_list): Update.
12467
12468 2019-01-10  Tom Tromey  <tom@tromey.com>
12469
12470         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12471         static_psymbols parameters.
12472         (scan_xcoff_symtab): Update.
12473         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12474         static_psymbols parameters.
12475         * psympriv.h (start_psymtab_common): Update.
12476         * mdebugread.c (parse_partial_symbols): Update.
12477         * dwarf2read.c (create_partial_symtab): Update.
12478         * dbxread.c (read_dbx_symtab): Update.
12479         (start_psymtab): Remove global_psymbols and static_psymbols
12480         parameters.
12481
12482 2019-01-10  Tom Tromey  <tom@tromey.com>
12483
12484         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12485         * psymtab.c (allocate_psymtab): Add comment.
12486         * psympriv.h (allocate_psymtab): Add comment.
12487         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12488         initializations.
12489         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12490
12491 2019-01-10  Tom Tromey  <tom@tromey.com>
12492
12493         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12494         Don't declare.
12495         * mipsread.c: Include mdebugread.h.
12496         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12497         Declare.
12498         * elfread.c: Include mdebugread.h.
12499
12500 2019-01-09  Tom Tromey  <tom@tromey.com>
12501
12502         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12503         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12504         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12505         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12506         (psym_lookup_symbol, psym_find_last_source_symtab)
12507         (psym_forget_cached_source_info, psym_print_stats)
12508         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12509         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12510         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12511         (psym_find_compunit_symtab_by_address)
12512         (maintenance_print_psymbols, maintenance_info_psymtabs)
12513         (maintenance_check_psymtabs): Use ranged for.
12514         * psymtab.h (class objfile_psymtabs): New.
12515         (require_partial_symbols): Return objfile_psymtabs.
12516         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12517
12518 2019-01-09  Tom Tromey  <tom@tromey.com>
12519
12520         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12521         (find_pc_mapped_section, list_overlays_command)
12522         (map_overlay_command, unmap_overlay_command)
12523         (simple_overlay_update): Use all_objfiles.
12524         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12525         * printcmd.c (info_symbol_command): Use all_objfiles.
12526         * objfiles.h (ALL_OBJSECTIONS): Remove.
12527         * maint.c (maintenance_translate_address): Use all_objfiles.
12528         * gcore.c (gcore_create_callback): Use all_objfiles.
12529         (objfile_find_memory_regions): Likewise.
12530
12531 2019-01-09  Tom Tromey  <tom@tromey.com>
12532
12533         * symtab.c (find_line_symtab, info_sources_command)
12534         (make_source_files_completion_list): Use objfile_compunits.
12535         * source.c (select_source_symtab): Use objfile_compunits.
12536         * objfiles.h (struct objfile): Update comment.
12537         (ALL_OBJFILES): Remove.
12538         (ALL_FILETABS): Remove.
12539         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12540         objfile_compunits.
12541
12542 2019-01-09  Tom Tromey  <tom@tromey.com>
12543
12544         * symmisc.c (print_objfile_statistics, dump_objfile)
12545         (maintenance_print_symbols): Use compunit_filetabs.
12546         * source.c (forget_cached_source_info_for_objfile): Use
12547         compunit_filetabs.
12548         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12549         (ALL_FILETABS): Use compunit_filetabs.
12550         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12551         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12552
12553 2019-01-09  Tom Tromey  <tom@tromey.com>
12554
12555         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12556         (compunit_filetabs): New.
12557         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12558         compunit_filetabs.
12559         (info_sources_command, make_source_files_completion_list): Remove
12560         declaration.
12561         * symmisc.c (print_objfile_statistics, dump_objfile)
12562         (maintenance_print_symbols): Remove declaration.
12563         (maintenance_info_symtabs): Use compunit_filetabs.
12564         (maintenance_info_line_tables): Likewise.
12565         * source.c (select_source_symtab): Change local variable name.
12566         (forget_cached_source_info_for_objfile): Remove declaration.
12567         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12568         * objfiles.c (objfile_relocate1): Remove declaration.
12569         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12570         declaration.
12571         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12572         * coffread.c (coff_symtab_read): Remove declaration.
12573         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12574         compunit_filetabs.
12575
12576 2019-01-09  Tom Tromey  <tom@tromey.com>
12577
12578         * symtab.c (lookup_objfile_from_block)
12579         (find_pc_sect_compunit_symtab, search_symbols)
12580         (default_collect_symbol_completion_matches_break_on): Use
12581         objfile_compunits.
12582         * objfiles.h (ALL_COMPUNITS): Remove.
12583         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12584         * cp-support.c (add_symbol_overload_list_qualified): Use
12585         objfile_compunits.
12586         * ada-lang.c (ada_collect_symbol_completion_matches)
12587         (ada_add_global_exceptions): Use objfile_compunits.
12588
12589 2019-01-09  Tom Tromey  <tom@tromey.com>
12590
12591         * source.c (select_source_symtab)
12592         (forget_cached_source_info_for_objfile): Remove declaration.
12593         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12594         declaration.
12595         * maint.c (count_symtabs_and_blocks): Remove declaration.
12596         * cp-support.c (add_symbol_overload_list_qualified): Remove
12597         declaration.
12598         * coffread.c (coff_symtab_read): Remove declaration.
12599         * symtab.c (lookup_symbol_in_objfile_symtabs)
12600         (basic_lookup_transparent_type_1): Use objfile_compunits.
12601         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12602         (info_sources_command, search_symbols)
12603         (default_collect_symbol_completion_matches_break_on)
12604         (make_source_files_completion_list): Remove declaration.
12605         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12606         (ada_collect_symbol_completion_matches)
12607         (ada_add_global_exceptions): Remove declaration.
12608         * linespec.c (iterate_over_all_matching_symtabs): Use
12609         objfile_compunits.
12610         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12611         (class objfile_compunits): New.
12612         (ALL_COMPUNITS): Use objfile_compunits.
12613         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12614         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12615         objfile_compunits.
12616         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12617
12618 2019-01-09  Tom Tromey  <tom@tromey.com>
12619
12620         * symtab.c (search_symbols)
12621         (default_collect_symbol_completion_matches_break_on): Use
12622         objfile_msymbols.
12623         * ada-lang.c (ada_lookup_simple_minsym)
12624         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12625         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12626         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12627         objfile_msymbols.
12628         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12629         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12630         * objc-lang.c (find_methods): Use objfile_msymbols.
12631         (info_selectors_command, info_classes_command): Likewise.
12632         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12633         * objfiles.h (class objfile_msymbols): New.
12634         (ALL_OBJFILE_MSYMBOLS): Remove.
12635         (ALL_MSYMBOLS): Remove.
12636
12637 2019-01-09  Tom Tromey  <tom@tromey.com>
12638
12639         * common/next-iterator.h (next_adapter): Add Iterator template
12640         parameter.
12641         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12642         (class all_objfiles_safe): New.
12643         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12644         * objfiles.c (put_objfile_before): Update comment.
12645         (add_separate_debug_objfile): Likewise.
12646         (free_all_objfiles): Use all_objfiles_safe.
12647         (objfile_purge_solibs): Likewise.
12648
12649 2019-01-09  Tom Tromey  <tom@tromey.com>
12650
12651         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12652         (expand_symtab_containing_pc, lookup_static_symbol)
12653         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12654         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12655         all_objfiles.
12656         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12657         * breakpoint.c (create_overlay_event_breakpoint)
12658         (create_longjmp_master_breakpoint)
12659         (create_std_terminate_master_breakpoint)
12660         (create_exception_master_breakpoint): Use all_objfiles.
12661         * linux-thread-db.c (try_thread_db_load_from_pdir)
12662         (has_libpthread): Use all_objfiles.
12663         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12664         * linespec.c (iterate_over_all_matching_symtabs)
12665         (search_minsyms_for_name): Use all_objfiles.
12666         * maint.c (maintenance_info_sections): Use all_objfiles.
12667         * main.c (captured_main_1): Use all_objfiles.
12668         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12669         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12670         * guile/scm-pretty-print.c
12671         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12672         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12673         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12674         (maintenance_print_msymbols): Use all_objfiles.
12675         * source.c (select_source_symtab): Use all_objfiles.
12676         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12677         * symfile.c (remove_symbol_file_command)
12678         (expand_symtabs_matching, map_symbol_filenames): Use
12679         all_objfiles.
12680         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12681         all_objfiles.
12682         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12683         * objc-lang.c (find_methods): Use all_objfiles.
12684         * objfiles.c (have_partial_symbols, have_full_symbols)
12685         (have_minimal_symbols, qsort_cmp)
12686         (default_iterate_over_objfiles_in_search_order): Use
12687         all_objfiles.
12688         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12689         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12690         (maintenance_check_psymtabs): Use all_objfiles.
12691         (ALL_PSYMTABS): Remove.
12692         * compile/compile-object-run.c (do_module_cleanup): Use
12693         all_objfiles.
12694         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12695         * cp-support.c (add_symbol_overload_list_qualified): Use
12696         all_objfiles.
12697         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12698         Use all_objfiles.
12699         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12700         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12701         all_objfiles.
12702         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12703         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12704         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12705         Uses all_objfiles.
12706         * solib.c (solib_read_symbols): Use all_objfiles
12707
12708 2019-01-09  Tom Tromey  <tom@tromey.com>
12709
12710         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12711         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12712         all_objfiles.
12713         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12714         * symmisc.c (print_symbol_bcache_statistics)
12715         (print_objfile_statistics, maintenance_print_objfiles)
12716         (maintenance_info_symtabs, maintenance_check_symtabs)
12717         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12718         all_objfiles.
12719         * source.c (forget_cached_source_info): Use all_objfiles.
12720         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12721         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12722         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12723         * objfiles.c (update_section_map): Use all_objfiles.
12724         (shared_objfile_contains_address_p): Likewise.
12725         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12726         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12727
12728 2019-01-09  Tom Tromey  <tom@tromey.com>
12729
12730         * common/next-iterator.h: New file.
12731         * objfiles.h (class all_objfiles): New.
12732         (struct objfile_iterator): New.
12733
12734 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12735
12736         * NEWS: Move the description of the changed "frame", "select-frame",
12737          and "info frame" commands to the Changed commands section.
12738
12739 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12740
12741         * gdbtypes.c (check_stub_method_group): Remove handling of old
12742         mangling schemes.
12743         * linespec.c (find_methods): Likewise.
12744         * stabsread.c (read_member_functions): Likewise.
12745         * valops.c (search_struct_method): Likewise.
12746         (value_struct_elt_for_reference): Likewise.
12747         * NEWS: Mention this change.
12748
12749 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12750
12751         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12752         print_source_lines.
12753         * source.c (print_source_lines_base): Update line number check.
12754         (print_source_lines): New function.
12755         (source_lines_range::source_lines_range): New function.
12756         * source.h (class source_lines_range): New class.
12757         (print_source_lines): New declaration.
12758
12759 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12760
12761         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12762
12763 2019-01-08  Tom Tromey  <tom@tromey.com>
12764             Simon Marchi  <simon.marchi@ericsson.com>
12765
12766         PR gdb/24060
12767         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12768         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12769         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12770         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12771         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12772         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12773
12774 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12775
12776         * source.c (select_source_symtab): Move header comment to
12777         declaration in source.h.
12778         (forget_cached_source_info_for_objfile): Likewise.
12779         (forget_cached_source_info): Likewise.
12780         (identify_source_line): Likewise.
12781         * source.h (identify_source_line): Move declaration from symtab.h
12782         and add comment from source.c
12783         (print_source_lines): Likewise.
12784         (forget_cached_source_info_for_objfile): Likewise.
12785         (forget_cached_source_info): Likewise.
12786         (select_source_symtab): Likewise.
12787         (enum print_source_lines_flag): Move definition from symtab.h.
12788         * symtab.h (identify_source_line): Move declaration to source.h.
12789         (print_source_lines): Likewise.
12790         (forget_cached_source_info_for_objfile): Likewise.
12791         (forget_cached_source_info): Likewise.
12792         (select_source_symtab): Likewise.
12793         (enum print_source_lines_flag): Move definition to source.h.
12794         * tui/tui-hooks.c: Add 'source.h' include.
12795
12796 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12797
12798         * source.c (print_source_lines_base): Handle requests to print
12799         reverse line number sequences, and guard against empty lines
12800         string.
12801
12802 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12803
12804         * source.c (print_source_lines_base): Fix skip of '\r' if next
12805         character is '\n'.
12806
12807 2019-01-06  Tom Tromey  <tom@tromey.com>
12808
12809         * c-exp.y (struct c_parse_state) <macro_original_text,
12810         expansion_obstack>: New member.
12811         (macro_original_text, expansion_obstack): Remove globals.
12812         (scan_macro_expansion, scanning_macro_expansion)
12813         (finished_macro_expansion): Update.
12814         (scan_macro_cleanup): Remove.
12815         (yylex, c_parse): Update.
12816
12817 2019-01-06  Tom Tromey  <tom@tromey.com>
12818
12819         * c-exp.y (struct c_parse_state) <strings>: New member.
12820         (operator_stoken): Update.
12821
12822 2019-01-06  Tom Tromey  <tom@tromey.com>
12823
12824         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12825         (union type_stack_elt) <typelist_val>: Now a pointer to
12826         std::vector.
12827         (type_stack_cleanup): Don't declare.
12828         (push_typelist): Update.
12829         * parse.c (pop_typelist): Return a std::vector.
12830         (push_typelist): Take a std::vector.
12831         (follow_types): Update.  Do not free args.
12832         (type_stack_cleanup): Remove.
12833         * c-exp.y (struct c_parse_state): New.
12834         (cpstate): New global.
12835         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12836         (nonempty_typelist): Update.
12837         (func_mod): Create a new vector.
12838         (c_parse): Create a c_parse_state.
12839         (check_parameter_typelist): Do not delete params.
12840         (function_method): Update.  Do not delete type_list.
12841
12842 2019-01-06  Tom Tromey  <tom@tromey.com>
12843
12844         PR gdb/28155:
12845         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12846         check_typedef.
12847         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12848         (print_return_value): Likewise.
12849
12850 2019-01-05  Tom Tromey  <tom@tromey.com>
12851
12852         * contrib/cleanup_check.py: Remove.
12853         * contrib/gcc-with-excheck: Remove.
12854         * contrib/exsummary.py: Remove.
12855         * contrib/excheck.py: Remove.
12856
12857 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12858
12859         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12860         NULL. Initialize tpprev to NULL instead of assigning it
12861         to NULL on the next statement.
12862         * windows-nat.c (windows_delete_thread): Remove check for
12863         main_thread_id before printing thread exit notifications.
12864         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12865         Remove thread ID check against main_thread_id.
12866         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12867         windows_delete_thread.
12868         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12869
12870 2019-01-04  Tom Tromey  <tom@tromey.com>
12871
12872         * compile/compile.c (_initialize_compile): Use upper case for
12873         metasyntactic variables.
12874         * symmisc.c (_initialize_symmisc): Use upper case for
12875         metasyntactic variables.
12876         * psymtab.c (_initialize_psymtab): Use upper case for
12877         metasyntactic variables.
12878         * demangle.c (demangle_command): Use upper case for metasyntactic
12879         variables.
12880         (_initialize_demangler): Likewise.
12881         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12882         variables.
12883
12884 2019-01-03  Tom Tromey  <tom@tromey.com>
12885
12886         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12887
12888 2019-01-03  Tom Tromey  <tom@tromey.com>
12889
12890         * python/py-symtab.c (salpy_str): Update.
12891         (struct salpy_sal_object) <symtab>: Now a PyObject.
12892         (salpy_dealloc): Update.
12893         (del_objfile_sal): Use gdbpy_ref.
12894
12895 2019-01-03  Tom Tromey  <tom@tromey.com>
12896
12897         * python/py-type.c (convert_field): Use new_reference.  Return
12898         gdbpy_ref.
12899         (make_fielditem): Return gdbpy_ref.
12900         (typy_fields): Update.
12901         (typy_getitem): Update.
12902         (field_name): Return gdbpy_ref.  Use new_reference.
12903         (typy_iterator_iternext): Update.
12904
12905 2019-01-03  Tom Tromey  <tom@tromey.com>
12906
12907         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12908
12909 2019-01-03  Tom Tromey  <tom@tromey.com>
12910
12911         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12912         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12913         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12914         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12915         (pspy_set_type_printers): Likewise.
12916         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12917         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12918         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12919         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12920         (objfpy_set_type_printers): Likewise.
12921
12922 2019-01-03  Tom Tromey  <tom@tromey.com>
12923
12924         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12925         (gdbpy_print_stack): Use gdbpy_err_fetch.
12926         * python/python-internal.h (class gdbpy_err_fetch): New class.
12927         (class gdbpy_enter) <m_error_type, m_error_value,
12928         m_error_traceback>: Remove.
12929         <m_error>: New member.
12930         (gdbpy_exception_to_string): Don't declare.
12931         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12932         * python/py-value.c (convert_value_from_python): Use
12933         gdbpy_err_fetch.
12934         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12935         gdbpy_exception_to_string.
12936         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12937         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12938         gdbpy_err_fetch.
12939
12940 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12941
12942         * linux-nat.c (delete_lwp_cleanup): Delete.
12943         (struct lwp_deleter): New struct.
12944         (lwp_info_up): New typedef.
12945         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12946         lwp_info_up.
12947
12948 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12949
12950         * linux-fork.c (class scoped_switch_fork_info): New class.
12951         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12952
12953 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12954
12955         * valops.c (find_overload_match): Remove use of null_cleanup, and
12956         calls to do_cleanups.
12957
12958 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12959
12960         * compile/compile-cplus-types.c
12961         (compile_cplus_instance::decl_name): Handle changes to
12962         cp_func_name.
12963         * cp-support.c (cp_func_name): Update header comment, update
12964         return type.
12965         * cp-support.h (cp_func_name): Update return type in declaration.
12966         * valops.c (find_overload_match): Move temp_func local to top
12967         level of function and change its type.  Use temp_func to hold and
12968         delete temporary string obtained from cp_func_name.
12969
12970 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12971
12972         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12973         gdb::char_vector, remove cleanup, and update uses of `msg`.
12974
12975 2019-01-03  Jim Wilson  <jimw@sifive.com>
12976
12977         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12978
12979 2019-01-02  Tom Tromey  <tom@tromey.com>
12980
12981         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12982         (tdesc_parse_xml): Remove cleanups.
12983         * target-descriptions.h (make_cleanup_free_target_description):
12984         Don't declare.
12985         (target_desc_deleter): New struct.
12986         (target_desc_up): New typedef.
12987         * target-descriptions.c (target_desc_deleter::operator()): Rename
12988         from free_target_description.
12989         (make_cleanup_free_target_description): Remove.
12990
12991 2019-01-02  Tom Tromey  <tom@tromey.com>
12992
12993         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12994         constructor, destructor.
12995         (linespec_parser): Remove typedef.
12996         (~linespec_parser): Rename from linespec_parser_delete.
12997         (linespec_lex_to_end, linespec_complete_label)
12998         (linespec_complete): Update.
12999         (decode_line_full): Remove cleanups.
13000         (decode_line_1): Update.
13001
13002 2019-01-02  Tom Tromey  <tom@tromey.com>
13003
13004         * python/python-internal.h (inferior_to_inferior_object): Change
13005         return type.
13006         * python/py-exitedevent.c (create_exited_event_object): Update.
13007         * python/py-inferior.c (inferior_to_inferior_object): Return
13008         gdbpy_ref.
13009         (python_new_inferior, python_inferior_deleted)
13010         (thread_to_thread_object, delete_thread_object)
13011         (build_inferior_list, gdbpy_selected_inferior): Update.
13012         * python/py-infthread.c (create_thread_object): Update.  Also fail
13013         if inferior_to_inferior_object fails.
13014
13015 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13016
13017         * inferior.h (class inferior) <displaced_step_state>: New field.
13018         * infrun.h (struct displaced_step_state): Move here from
13019         infrun.c.  Initialize fields, add constructor.
13020         <inf>: Remove field.
13021         <reset>: New method.
13022         * infrun.c (struct displaced_step_inferior_state): Move to
13023         infrun.h.
13024         (displaced_step_inferior_states): Remove.
13025         (get_displaced_stepping_state): Adust.
13026         (displaced_step_in_progress_any_inferior): Adjust.
13027         (displaced_step_in_progress_thread): Adjust.
13028         (displaced_step_in_progress): Adjust.
13029         (add_displaced_stepping_state): Remove.
13030         (get_displaced_step_closure_by_addr): Adjust.
13031         (remove_displaced_stepping_state): Remove.
13032         (infrun_inferior_exit): Call displaced_step_state.reset.
13033         (use_displaced_stepping): Don't check for NULL.
13034         (displaced_step_prepare_throw): Call
13035         get_displaced_stepping_state.
13036         (displaced_step_fixup): Don't check for NULL.
13037         (prepare_for_detach): Don't check for NULL.
13038
13039 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13040
13041         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13042          in case of call that did not complete.
13043
13044 2019-01-02  Andrey Utkin  <autkin@undo.io>
13045
13046         * symfile.c (find_separate_debug_file): Fix search of debug files for
13047         remote debuggee.
13048
13049 2019-01-02  Tom Tromey  <tom@tromey.com>
13050
13051         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13052         indentation.
13053         * python/py-frame.c (frapy_older): Remove cast.
13054         (frapy_newer): Likewise.
13055         * python/py-breakpoint.c (local_setattro): Remove cast.
13056         * python/py-arch.c (archpy_name): Remove local variable.
13057         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13058
13059 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13060
13061         * unittests/basic_string_view/element_access/char/empty.cc:
13062         Fix year range in copyright header.
13063
13064 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13065
13066         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13067         Delete.
13068         <operator==>: Update with for removed field.
13069         <hash>: Likewise.
13070         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13071         <isa_features>: ...this.
13072         <abi_features>: New field.
13073         (riscv_isa_flen): Update comment.
13074         (riscv_abi_xlen): New declaration.
13075         (riscv_abi_flen): New declaration.
13076         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13077         isa_features.
13078         (riscv_abi_xlen): New function.
13079         (riscv_isa_flen): Update to get answer from isa_features.
13080         (riscv_abi_flen): New function.
13081         (riscv_has_fp_abi): Update to get answer from abi_features.
13082         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13083         xlen and flen.
13084         (riscv_call_info) <xlen, flen>: Update comment.
13085         (riscv_call_arg_struct): Remove invalid assertions
13086         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13087         is removed.
13088         (riscv_gdbarch_init): Gather isa features and abi features
13089         separately, ensure both match on the gdbarch when reusing an old
13090         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13091         a target with 64-bit float hardware.
13092
13093 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13094
13095         * source.c (search_command_helper): Stop reverse search
13096         when line 1 has been searched.
13097
13098 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13099
13100         * record-full.c (record_full_base_target::close): Rewrite
13101         record_full_core_buf_list free logic.
13102
13103 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13104
13105         * break-catch-syscall.c (print_one_catch_syscall): xfree
13106         the last text.
13107
13108 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13109
13110         * top.c (print_gdb_version): Update Copyright year in version
13111         message.
13112
13113 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13114
13115         Update copyright year range in all GDB files.
13116
13117 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13118
13119         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13120
13121 For older changes see ChangeLog-2018.
13122 \f
13123 Local Variables:
13124 mode: change-log
13125 left-margin: 8
13126 fill-column: 74
13127 version-control: never
13128 coding: utf-8
13129 End:
13130