gdb/ChangeLog

   1 2019-11-05  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
   4         std::string.
   5         * tui/tui-winsource.c (tui_show_source_line): Update.
   6         * tui/tui-source.c (tui_source_window::set_contents): Update.
   7         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
   8
   9 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
  10
  11         * symtab.h (gdb_static_assert): Put && operator at the beginning
  12         of the line instead of the end.
  13
  14 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
  15
  16         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
  17         and sizeof (symbol).
  18         * symtab.h: Add a static_assert for sizeof (partial_symbol).
  19
  20 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  21
  22         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
  23         * configure.host: Mark *-*-solaris2.10* obsolete.
  24         * configure.tgt: Mark Solaris < 11 obsolete.
  25         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
  26         Update target triplet.
  27
  28 2019-11-01  Tom Tromey  <tromey@adacore.com>
  29
  30         * utils.c (print_sys_errmsg): Simplify.
  31
  32 2019-11-01  Tom Tromey  <tromey@adacore.com>
  33
  34         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
  35
  36 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
  37
  38         * configure: Regenerate.
  39         * configure.ac: Remove check for strerror_r.
  40         * gdbsupport/common.m4: Check for strerror_r.
  41
  42 2019-11-01  Luis Machado  <luis.machado@linaro.org>
  43
  44         PR gdb/25124
  45
  46         * arm-tdep.c (arm_per_objfile): Rename to ...
  47         (arm_per_bfd): ... this.
  48         (arm_objfile_data_key): Rename to ...
  49         (arm_bfd_data_key): ... this.
  50         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
  51         data.
  52         (arm_record_special_symbol): Likewise.
  53
  54 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  55
  56         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
  57         end.
  58         * c-typeprint.c (c_print_typedef): Likewise.
  59         * f-typeprint.c (f_print_typedef): Likewise.
  60         * m2-typeprint.c (m2_print_typedef): Likewise.
  61         * p-typeprint.c (pascal_print_typedef): Likewise.
  62         * rust-lang.c (rust_print_typedef): Likewise.
  63         * symtab.c (print_symbol_info): Print a newline after calling
  64         typedef_print.
  65
  66 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  67
  68         * symtab.c (info_module_cmdlist): New variable.
  69         (info_module_command): New function.
  70         (search_module_symbols): New function.
  71         (info_module_subcommand): New function.
  72         (struct info_modules_var_func_options): New struct.
  73         (info_modules_var_func_options_defs): New variable.
  74         (make_info_modules_var_func_options_def_group): New function.
  75         (info_module_functions_command): New function.
  76         (info_module_variables_command): New function.
  77         (info_module_var_func_command_completer): New function.
  78         (_initialize_symtab): Register new 'info module functions' and
  79         'info module variables' commands.
  80         * symtab.h (typedef symbol_search_in_module): New typedef.
  81         (search_module_symbols): Declare new function.
  82         * NEWS: Mention new commands.
  83
  84 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
  85
  86         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
  87         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
  88         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
  89         MODULES_DOMAIN.
  90         (scan_partial_symbols): Only create partial module symbols for non
  91         declarations.
  92         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
  93         and MODULES_DOMAIN.
  94         * symtab.c (search_domain_name): Likewise.
  95         (search_symbols): Likewise.
  96         (print_symbol_info): Likewise.
  97         (symtab_symbol_info): Likewise.
  98         (info_modules_command): New function.
  99         (_initialize_symtab): Register 'info modules' command.
 100         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
 101         * NEWS: Mention new 'info modules' command.
 102
 103 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 104
 105         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
 106         and $_gdb_maint_setting_str.
 107
 108 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 109
 110         * cli/cli-cmds.c (setting_cmd, value_from_setting)
 111         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
 112         (str_value_from_setting, gdb_setting_str_internal_fn)
 113         (gdb_maint_setting_str_internal_fn): New functions.
 114         (_initialize_cli_cmds): Define the new convenience functions.
 115         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
 116         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
 117
 118 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 119
 120         * agent.c (set_can_use_agent): When the setting is turned on,
 121         look up agent symbols if we don't have them yet.
 122         (agent_new_objfile): Don't look up agent symbols when the agent
 123         setting is off.
 124
 125 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 126
 127         * config.in: Regenerate.
 128
 129 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 130
 131         * configure: Regenerate.
 132         * configure.ac: Check for strerror_r.
 133         * gdbsupport/common-utils.h (safe_strerror): Change return value
 134         to const char * and document that this function is now threadsafe.
 135         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
 136         thread_local and call strerror_r, if available.
 137         * utils.c (perror_string): Update.
 138         (print_sys_errmsg): Update.
 139
 140 2019-10-31  Luis Machado  <luis.machado@linaro.org>
 141
 142         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
 143         objfile_key.
 144         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
 145         objfile to fetch per-bfd data.
 146         (arm_find_exidx_entry): Likewise.
 147
 148 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
 149
 150         * gdbsupport/agent.c (debug_agent): Change type to bool.
 151         (use_agent): Likewise.
 152         (all_agent_symbols_look_up): Likewise.
 153         (agent_loaded_p): Change return value to bool.
 154         (agent_look_up_symbols): Update.
 155         (agent_capability_check): Change return value to bool.
 156         * gdbsupport/agent.h (agent_loaded_p): Likewise.
 157         (debug_agent): Change type to bool.
 158         (use_agent): Likewise.
 159         (agent_capability_check): Change return value to bool.
 160
 161 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
 162
 163         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
 164         (build_minimal_symbol_hash_tables): Code to clear the table moved
 165         to clear_minimal_symbol_hash_tables.
 166         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
 167         when needed.
 168
 169 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 170
 171         * infcmd.c: Remove includes.
 172         * infrun.c: Remove includes.
 173
 174 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 175
 176         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
 177         (grow_vect): Remove declaration.
 178         (ada_type_of_array): Remove declaration.
 179         (ada_update_initial_language): Remove declaration.
 180         (ada_fold_name): Remove declaration.
 181         (ada_fill_in_ada_prototype): Remove declaration.
 182         (user_select_syms): Remove declaration.
 183         (get_selections): Remove declaration.
 184         (ada_tag_type): Remove declaration.
 185         (ada_value_tag): Remove declaration.
 186         (ada_is_others_clause): Remove declaration.
 187         (ada_in_variant): Remove declaration.
 188         (ada_value_struct_elt): Remove declaration.
 189         (ada_attribute_name): Remove declaration.
 190         (ada_system_address_type): Remove declaration.
 191         * ada-lang.c (ada_watch_location_expression): Make static.
 192         (GROW_VECT): Move here from ada-lang.h.
 193         (grow_vect): Make static.
 194         (ada_update_initial_language): Make static.
 195         (ada_fold_name): Make static.
 196         (ada_type_of_array): Make static.
 197         (encoded_ordered_before): Move up.
 198         (sort_choices): Move up.
 199         (print_signatures): Move up.
 200         (ada_print_symbol_signature): Move up.
 201         (get_selections): Move up and make static.
 202         (user_select_syms): Move up and make static.
 203         (ada_value_struct_elt): Move up and make static.
 204         (ada_tag_type): Make static.
 205         (ada_value_tag): Make static.
 206         (ada_is_others_clause): Make static.
 207         (ada_in_variant): Make static.
 208         (ada_attribute_name): Make static.
 209
 210 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 211
 212         * ada-lang.c: Remove includes.
 213         * ada-typeprint.c: Remove includes.
 214         * ada-valprint.c: Remove includes.
 215
 216 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
 217
 218         * addrmap.c: Add static assertions of type size, moved from
 219         _initialize_addrmap.
 220         (_initialize_addrmap): Remove.
 221
 222 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 223
 224         * coffread.c (record_minimal_symbol): Update.
 225         (process_coff_symbol): Update.
 226         * dbxread.c (read_dbx_symtab): Update.
 227         * dwarf2read.c (add_partial_symbol): Update.
 228         (fixup_go_packaging): Update.
 229         (load_partial_dies): Update.
 230         (new_symbol): Update.
 231         * elfread.c (record_minimal_symbol): Change signature to use
 232         gdb::string_view instead of name+len.
 233         (elf_symtab_read): Update.
 234         (elf_rel_plt_read): Update.
 235         * mdebugread.c (parse_partial_symbols): Update.
 236         (handle_psymbol_enumerators): Update.
 237         (new_symbol): Update.
 238         * minsyms.c (minimal_symbol_reader::record_full): Change signature
 239         to use gdb::string_view instead of name+len.
 240         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
 241         * psympriv.h (add_psymbol_to_list): Likewise.
 242         * psymtab.c (add_psymbol_to_bcache): Likewise.
 243         (add_psymbol_to_list): Likewise.
 244         * stabsread.c (define_symbol): Update.
 245         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
 246         * symtab.h (SYMBOL_SET_NAMES): Likewise.
 247         (symbol_set_names): Likewise.
 248         * xcoffread.c (scan_xcoff_symtab): Update.
 249
 250 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 251
 252         * symtab.h (symbol_set_names): Document that copy_name must be
 253         set to true for non-nullterminated strings.
 254         * symtab.c (symbol_set_names): Only make a nullterminated copy of
 255         linkage_name if the entry was not found and we need to demangle.
 256
 257 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 258
 259         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
 260         * dwarf2-frame.c (bsearch_fde_cmp): Update.
 261         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
 262         * gdbsupport/gdb_binary_search.h: New file.
 263
 264 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 265
 266         * NEWS: Mention new --with-system-gdbinit-dir option.
 267         * config.in: Regenerate.
 268         * configure: Regenerate.
 269         * configure.ac: Add new option --with-system-gdbinit-dir.
 270         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
 271         for a ".gdb" suffix.
 272         * main.c (get_init_files): Change system_gdbinit argument to
 273         a vector and return the files in SYSTEM_GDBINIT_DIR in
 274         addition to SYSTEM_GDBINIT.
 275         (captured_main_1): Update.
 276         (print_gdb_help): Update.
 277         * top.c (print_gdb_configuration): Also print the value of
 278         SYSTEM_GDBINIT_DIR.
 279
 280 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
 281
 282         * gdbsupport/common-utils.h (startswith): Add an overloaded version
 283         that takes gdb::string_view arguments.
 284
 285 2019-10-26  Tom de Vries  <tdevries@suse.de>
 286
 287         * aarch64-linux-tdep.c: Fix typos in comments.
 288         * aarch64-tdep.c: Same.
 289         * ada-lang.c: Same.
 290         * amd64-nat.c: Same.
 291         * arc-tdep.c: Same.
 292         * arch/aarch64-insn.c: Same.
 293         * block.c: Same.
 294         * breakpoint.h: Same.
 295         * btrace.h: Same.
 296         * c-varobj.c: Same.
 297         * cli/cli-decode.c: Same.
 298         * cli/cli-script.c: Same.
 299         * cli/cli-utils.h: Same.
 300         * coff-pe-read.c: Same.
 301         * coffread.c: Same.
 302         * compile/compile-cplus-symbols.c: Same.
 303         * compile/compile-object-run.c: Same.
 304         * completer.c: Same.
 305         * corelow.c: Same.
 306         * cp-support.c: Same.
 307         * demangle.c: Same.
 308         * dwarf-index-write.c: Same.
 309         * dwarf2-frame.c: Same.
 310         * dwarf2-frame.h: Same.
 311         * eval.c: Same.
 312         * frame-base.h: Same.
 313         * frame.h: Same.
 314         * gdbcmd.h: Same.
 315         * gdbtypes.h: Same.
 316         * gnu-nat.c: Same.
 317         * guile/scm-objfile.c: Same.
 318         * i386-tdep.c: Same.
 319         * i386-tdep.h: Same.
 320         * infcall.c: Same.
 321         * infcall.h: Same.
 322         * linux-nat.c: Same.
 323         * m68k-tdep.c: Same.
 324         * macroexp.c: Same.
 325         * memattr.c: Same.
 326         * mi/mi-cmd-disas.c: Same.
 327         * mi/mi-getopt.h: Same.
 328         * mi/mi-main.c: Same.
 329         * minsyms.c: Same.
 330         * nat/aarch64-sve-linux-sigcontext.h: Same.
 331         * objfiles.h: Same.
 332         * ppc-linux-nat.c: Same.
 333         * ppc-linux-tdep.c: Same.
 334         * ppc-tdep.h: Same.
 335         * progspace.h: Same.
 336         * prologue-value.h: Same.
 337         * python/py-evtregistry.c: Same.
 338         * python/py-instruction.h: Same.
 339         * record-btrace.c: Same.
 340         * record-full.c: Same.
 341         * remote.c: Same.
 342         * rs6000-tdep.c: Same.
 343         * ser-tcp.c: Same.
 344         * sol-thread.c: Same.
 345         * sparc-sol2-tdep.c: Same.
 346         * sparc64-tdep.c: Same.
 347         * stabsread.c: Same.
 348         * symfile.c: Same.
 349         * symtab.h: Same.
 350         * target.c: Same.
 351         * tracepoint.c: Same.
 352         * tui/tui-data.h: Same.
 353         * tui/tui-io.c: Same.
 354         * tui/tui-win.c: Same.
 355         * tui/tui.c: Same.
 356         * unittests/rsp-low-selftests.c: Same.
 357         * user-regs.h: Same.
 358         * utils.c: Same.
 359         * utils.h: Same.
 360         * valarith.c: Same.
 361         * valops.c: Same.
 362         * valprint.c: Same.
 363         * valprint.h: Same.
 364         * value.c: Same.
 365         * value.h: Same.
 366         * varobj.c: Same.
 367         * x86-nat.h: Same.
 368         * xtensa-tdep.c: Same.
 369
 370 2019-10-25  Ali Tamur <tamur@google.com>
 371
 372         * charset.c (find_charset_names): Reflect API change.
 373
 374 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
 375
 376         * symtab.c (struct demangled_name_entry): Change demangled name
 377         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
 378         part of the struct anymore.
 379         (symbol_set_names): No longer obstack allocate + copy the demangled
 380         name, just store the allocated name from bfd.
 381
 382 2019-10-25  Tom Tromey  <tromey@adacore.com>
 383
 384         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 385         (bsearch_cie_cmp, add_cie): Remove.
 386         (find_cie): Reimplement.
 387         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 388         (dwarf2_build_frame_info): Update.
 389
 390 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 391
 392         PR gdb/25126
 393         * symfile.c (reread_symbols): Call forget_cached_source_info to
 394         clear the stale source cache.
 395
 396 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 397
 398         * configure: Regenerate.
 399         * configure.ac: Remove code that sets python_has_threads.
 400
 401 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 402
 403         * config.in: Regenerate.
 404         * configure: Regenerate.
 405         * configure.ac: Remove the code that uses sed to get the python
 406         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 407
 408 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 409
 410         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 411         error paths.
 412
 413 2019-10-23  Tom Tromey  <tom@tromey.com>
 414
 415         * arc-tdep.c: Remove ".." from include.
 416         * frv-tdep.c: Remove ".." from include.
 417         * lm32-tdep.c: Remove ".." from include.
 418         * microblaze-tdep.c: Remove ".." from include.
 419         * or1k-tdep.h: Remove ".." from include.
 420         * s12z-tdep.c: Remove ".." from include.
 421         * Makefile.in (OPCODES_CFLAGS): Add comment.
 422         (TOP_CFLAGS): New variable.
 423         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 424
 425 2019-10-23  Tom Tromey  <tom@tromey.com>
 426
 427         * Makefile.in (READLINE_DIR): Update.
 428
 429 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 430
 431         * infcall.c (call_function_by_hand_dummy): Fix the function
 432         comment.  And extract out a code section into...
 433         (reserve_stack_space): ...this new function.
 434
 435 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 436
 437         * infcall.c (value_arg_coerce): Remove an unused parameter.
 438         (call_function_by_hand_dummy): Update the call to
 439         'value_arg_coerce'.
 440
 441 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 442
 443         * infcall.c (call_function_by_hand_dummy): Refactor.
 444
 445 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 446
 447         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 448
 449 2019-10-23  Tom Tromey  <tom@tromey.com>
 450
 451         * configure: Rebuild.
 452         * configure.ac: Don't check for sigprocmask.
 453         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 454
 455 2019-10-23  Tom Tromey  <tom@tromey.com>
 456
 457         * configure: Rebuild.
 458         * acinclude.m4: Use m4_include, not sinclude.
 459
 460 2019-10-23  Tom de Vries  <tdevries@suse.de>
 461
 462         PR breakpoints/24687
 463         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 464
 465 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 466
 467         * symtab.c (struct demangled_name_entry) <language>: Change from
 468         bitfield to regular variable.
 469
 470 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 471
 472         * symtab.c (struct demangled_name_entry): Add a constructor.
 473         (free_demangled_name_entry): New function to call the destructor
 474         for demangled_name_entry.
 475         (create_demangled_names_hash): Pass free_demangled_name_entry to
 476         htab_create_alloc.
 477         (symbol_set_names): Call placement new for demangled_name_entry.
 478         * utils.c: No longer include xxhash.h here, now that fast_hash
 479         is inlined in the header.
 480         * utils.h: Instead, include it here.
 481
 482 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 483
 484         * Makefile.in: Link with libxxhash.
 485         * config.in: Regenerate.
 486         * configure: Regenerate.
 487         * configure.ac: Search for libxxhash.
 488         * utils.c (fast_hash): Use xxhash if present.
 489
 490 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 491
 492         * utils.h (fast_hash): New function.
 493         * symtab.c (hash_demangled_name_entry): Call new function
 494         fast_hash.
 495
 496 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 497
 498         * symtab.c (struct demangled_name_entry): Change type of mangled
 499         to gdb::string_view. Also adds a constructor that takes the
 500         mangled name.
 501         (hash_demangled_name_entry): Update.
 502         (eq_demangled_name_entry): Update.
 503         (free_demangled_name_entry): New function to call the destructor
 504         now that this is not a POD anymore.
 505         (create_demangled_names_hash): Pass free_demangled_name_entry to
 506         htab_create_alloc.
 507         (symbol_set_names): Update.
 508
 509 2019-10-21  Ali Tamur  <tamu@google.com>
 510
 511         * dwarf2read.c (dir_index): Change type.
 512         (file_name_index): Likewise.
 513         (line_header::include_dir_at): Change comment and implementation on
 514         whether it is DWARF 5.
 515         (line_header::is_valid_file_index): New function.
 516         (line_header::file_name_at): Change comment and implementation on
 517         whether it is DWARF 5.
 518         (line_header::file_names): Change to private field renamed as
 519         m_file_names and introduce a new accessor method.
 520         (line_header::file_names_size): New method.
 521         (line_header::include_dirs): Change to private field and rename as
 522         m_include_dirs.
 523         (dw2_get_file_names_reader): Define local var at a smaller scope and
 524         reflect API change.
 525         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 526         (process_structure_scope): Likewise.
 527         (line_header::add_include_dir): Change message and reflect renaming.
 528         (line_header::add_file_name): Likewise.
 529         (read_formatted_entries): Handle DW_FORM_data16.
 530         (dwarf_decode_line_header): Fix line header length calculation.
 531         (psymtab_include_file_name): Change comment and API.
 532         (lnp_state_machine::m_file): Update comment and reflect type change.
 533         (lnp_state_machine::record_line): Reflect type change.
 534         (dwarf_decode_lines): Reflect API change.
 535         (file_file_name): Likewise.
 536         (file_full_name): Likewise.
 537
 538 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 539
 540         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 541
 542 2019-10-21  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 545
 546 2019-10-21  Tom Tromey  <tom@tromey.com>
 547
 548         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 549         NM_H.   Use AC_CONFIG_LINKS.
 550         * configure: Rebuild.
 551         * Makefile.in (NM_H): New variable.
 552         (generated_files): Add NM_H.  Remove gcore.
 553         (nm.h, stamp-nmh): New targets.
 554
 555 2019-10-20  Tom Tromey  <tom@tromey.com>
 556
 557         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 558         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 559         obsolete comment.
 560         (put_objfile_before): Now static.
 561
 562 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 563
 564         * gdbsupport/common-utils.h (startswith): Change return type to
 565         bool.
 566
 567 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 568
 569         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 570         * breakpoint.c (bp_locations_compare): Rename to...
 571         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 572         (update_global_location_list): Use std::sort instead of qsort.
 573         * buildsym.c (compare_line_numbers): Rename to...
 574         (lte_is_less_than): ...this, and change to std::sort semantics.
 575         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 576         instead of qsort.
 577         * disasm.c (compare_lines): Rename to...
 578         (line_is_less_than): ...this, and change to std::sort semantics.
 579         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 580         of qsort.
 581         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 582         (fde_is_less_than): ...this, and change to std::sort semantics.
 583         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 584         * mdebugread.c (compare_blocks):
 585         (block_is_less_than): ...this, and change to std::sort semantics.
 586         (sort_blocks): Call std::sort instead of qsort.
 587         * objfiles.c (qsort_cmp): Rename to...
 588         (sort_cmp): ...this, and change to std::sort semantics.
 589         (update_section_map): Call std::sort instead of qsort.
 590         * remote.c (compare_pnums): Remove.
 591         (map_regcache_remote_table): Call std::sort instead of qsort.
 592         * utils.c (compare_positive_ints): Remove.
 593         * utils.h (compare_positive_ints): Remove.
 594         * xcoffread.c (compare_lte): Remove.
 595         (arrange_linetable): Call std::sort instead of qsort.
 596
 597 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 598
 599         * symfile.c (init_entry_point_info): Fix typo.
 600         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 601
 602 2019-10-18  Tom de Vries  <tdevries@suse.de>
 603
 604         * aarch64-tdep.c: Fix typos in comments.
 605         * ada-lang.c: Same.
 606         * ada-tasks.c: Same.
 607         * alpha-tdep.c: Same.
 608         * alpha-tdep.h: Same.
 609         * amd64-nat.c: Same.
 610         * amd64-windows-tdep.c: Same.
 611         * arc-tdep.c: Same.
 612         * arc-tdep.h: Same.
 613         * arch-utils.c: Same.
 614         * arm-nbsd-tdep.c: Same.
 615         * arm-tdep.c: Same.
 616         * ax-gdb.c: Same.
 617         * blockframe.c: Same.
 618         * btrace.c: Same.
 619         * c-varobj.c: Same.
 620         * coff-pe-read.c: Same.
 621         * coffread.c: Same.
 622         * cris-tdep.c: Same.
 623         * darwin-nat.c: Same.
 624         * dbxread.c: Same.
 625         * dcache.c: Same.
 626         * disasm.c: Same.
 627         * dtrace-probe.c: Same.
 628         * dwarf-index-write.c: Same.
 629         * dwarf2-frame-tailcall.c: Same.
 630         * dwarf2-frame.c: Same.
 631         * dwarf2read.c: Same.
 632         * eval.c: Same.
 633         * exceptions.c: Same.
 634         * fbsd-tdep.c: Same.
 635         * findvar.c: Same.
 636         * frame.c: Same.
 637         * frv-tdep.c: Same.
 638         * gnu-v3-abi.c: Same.
 639         * go32-nat.c: Same.
 640         * h8300-tdep.c: Same.
 641         * hppa-tdep.c: Same.
 642         * i386-linux-tdep.c: Same.
 643         * i386-tdep.c: Same.
 644         * ia64-libunwind-tdep.c: Same.
 645         * ia64-tdep.c: Same.
 646         * infcmd.c: Same.
 647         * infrun.c: Same.
 648         * linespec.c: Same.
 649         * linux-nat.c: Same.
 650         * linux-thread-db.c: Same.
 651         * machoread.c: Same.
 652         * mdebugread.c: Same.
 653         * mep-tdep.c: Same.
 654         * mn10300-tdep.c: Same.
 655         * namespace.c: Same.
 656         * objfiles.c: Same.
 657         * opencl-lang.c: Same.
 658         * or1k-tdep.c: Same.
 659         * osabi.c: Same.
 660         * ppc-linux-nat.c: Same.
 661         * ppc-linux-tdep.c: Same.
 662         * ppc-sysv-tdep.c: Same.
 663         * printcmd.c: Same.
 664         * procfs.c: Same.
 665         * record-btrace.c: Same.
 666         * record-full.c: Same.
 667         * remote-fileio.c: Same.
 668         * remote.c: Same.
 669         * rs6000-tdep.c: Same.
 670         * s12z-tdep.c: Same.
 671         * score-tdep.c: Same.
 672         * ser-base.c: Same.
 673         * ser-go32.c: Same.
 674         * skip.c: Same.
 675         * sol-thread.c: Same.
 676         * solib-svr4.c: Same.
 677         * solib.c: Same.
 678         * source.c: Same.
 679         * sparc-nat.c: Same.
 680         * sparc-sol2-tdep.c: Same.
 681         * sparc-tdep.c: Same.
 682         * sparc64-tdep.c: Same.
 683         * stabsread.c: Same.
 684         * stack.c: Same.
 685         * symfile.c: Same.
 686         * symtab.c: Same.
 687         * target-descriptions.c: Same.
 688         * target-float.c: Same.
 689         * thread.c: Same.
 690         * utils.c: Same.
 691         * valops.c: Same.
 692         * valprint.c: Same.
 693         * value.c: Same.
 694         * varobj.c: Same.
 695         * windows-nat.c: Same.
 696         * xcoffread.c: Same.
 697         * xstormy16-tdep.c: Same.
 698         * xtensa-tdep.c: Same.
 699
 700 2019-10-17  Tom Tromey  <tromey@adacore.com>
 701
 702         * configure: Rebuild.
 703         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 704         in AC_CONFIG_FILES invocation.
 705         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 706         new-style config.status invocation.
 707
 708 2019-10-17  Tom de Vries  <tdevries@suse.de>
 709
 710         * arm-nbsd-nat.c: Fix typos in comments.
 711         * arm-tdep.c: Same.
 712         * darwin-nat-info.c: Same.
 713         * dwarf2read.c: Same.
 714         * elfread.c: Same.
 715         * event-top.c: Same.
 716         * findvar.c: Same.
 717         * gdbtypes.c: Same.
 718         * hppa-tdep.c: Same.
 719         * i386-tdep.c: Same.
 720         * jit.c: Same.
 721         * main.c: Same.
 722         * mdebugread.c: Same.
 723         * moxie-tdep.c: Same.
 724         * nto-procfs.c: Same.
 725         * osabi.c: Same.
 726         * ppc-linux-tdep.c: Same.
 727         * remote.c: Same.
 728         * riscv-tdep.c: Same.
 729         * s390-tdep.c: Same.
 730         * sh-tdep.c: Same.
 731         * sparc-linux-tdep.c: Same.
 732         * sparc-nat.c: Same.
 733         * stack.c: Same.
 734         * target-descriptions.c: Same.
 735         * top.c: Same.
 736         * varobj.c: Same.
 737
 738 2019-10-16  Tom Tromey  <tom@tromey.com>
 739
 740         * objfiles.h (struct objfile) <original_name>: Now const.
 741
 742 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 743
 744         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 745         pass on to sigsetjmp's second argument.
 746         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 747
 748 2019-10-16  Keith Seitz  <keiths@redhat.com>
 749
 750         PR gdb/23567
 751         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 752         sections whose size is greater than the file size.
 753
 754 2019-10-16  Jim Wilson  <jimw@sifive.com>
 755
 756         * riscv-tdep.c (riscv_gcc_target_options): New.
 757         (riscv_gnu_triplet_regexp): New.
 758         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 759         set_gdbarch_gnu_triplet_regexp.
 760
 761 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 762
 763         * Makefile.in: Add xml-builtin.h.
 764         * features/feature_to_c.sh: Add an include for xml-builtin.h
 765         to ensure that the compiler checks that the types match.
 766         * xml-builtin.h: New file.
 767         * xml-support.c (fetch_xml_builtin): Add missing const.
 768         * xml-support.h: Remove declaration of xml_builtins.
 769
 770 2019-10-16  Tom de Vries  <tdevries@suse.de>
 771
 772         PR tdep/25096
 773         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 774         (amd64_classify_aggregate): ... here.
 775         (amd64_classify_aggregate_field): Handled fiels of nested structs
 776         recursively.
 777
 778 2019-10-16  Tom de Vries  <tdevries@suse.de>
 779
 780         PR tdep/24104
 781         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 782         that handles 'theclass'.
 783
 784 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 785
 786         * linespec.c (decode_digits_ordinary): Update comment.
 787         * make-target-delegates: No longer need to handle VEC case.
 788         * memrange.c (normalize_mem_ranges): Update comment.
 789         * namespace.c (add_using_directive): Update comment.
 790         * objc-lang.c (uniquify_strings): Update comment.
 791         * ppc-linux-nat.c (struct thread_points): Update comment.
 792         * probe.h (find_probes_in_objfile): Update comment.
 793         * target.h (enum flash_preserve_mode): Update comment.
 794         * varobj.c (varobj_restrict_range): Update comment.
 795         * varobj.h (varobj_list_children): Update comment.
 796
 797 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 798
 799         * Makefile.in: Remove references to vec.h and vec.c.
 800         * aarch64-tdep.c: No longer include vec.h.
 801         * ada-lang.c: Likewise.
 802         * ada-lang.h: Likewise.
 803         * arm-tdep.c: Likewise.
 804         * ax.h: Likewise.
 805         * breakpoint.h: Likewise.
 806         * charset.c: Likewise.
 807         * cp-support.h: Likewise.
 808         * dtrace-probe.c: Likewise.
 809         * dwarf2read.c: Likewise.
 810         * extension.h: Likewise.
 811         * gdb_bfd.c: Likewise.
 812         * gdbsupport/gdb_vecs.h: Likewise.
 813         * gdbsupport/vec.c: Remove.
 814         * gdbsupport/vec.h: Remove.
 815         * gdbthread.h: Likewise.
 816         * guile/scm-type.c: Likewise.
 817         * inline-frame.c: Likewise.
 818         * machoread.c: Likewise.
 819         * memattr.c: Likewise.
 820         * memrange.h: Likewise.
 821         * namespace.h: Likewise.
 822         * nat/linux-btrace.h: Likewise.
 823         * osdata.c: Likewise.
 824         * parser-defs.h: Likewise.
 825         * progspace.h: Likewise.
 826         * python/py-type.c: Likewise.
 827         * record-btrace.c: Likewise.
 828         * rust-exp.y: Likewise.
 829         * solib-target.c: Likewise.
 830         * stap-probe.c: Likewise.
 831         * target-descriptions.c: Likewise.
 832         * target-memory.c: Likewise.
 833         * target.h: Likewise.
 834         * varobj.c: Likewise.
 835         * varobj.h: Likewise.
 836         * xml-support.h: Likewise.
 837
 838 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 839
 840         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 841         Update for new std::vector based implementation.
 842         (process_psymtab_comp_unit_reader): Likewise.
 843         (scan_partial_symbols): Likewise.
 844         (recursively_compute_inclusions): Likewise.
 845         (compute_compunit_symtab_includes): Likewise.
 846         (process_imported_unit_die): Likewise.
 847         (queue_and_load_dwo_tu): Likewise.
 848         (follow_die_sig_1): Likewise.
 849         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 850         (typedef dwarf2_per_cu_ptr): Remove.
 851         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 852         function.
 853         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 854         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 855         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 856         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 857         std::vector.
 858
 859 2019-10-15  Tom Tromey  <tromey@adacore.com>
 860
 861         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 862         TID.
 863
 864 2019-10-15  Tom Tromey  <tromey@adacore.com>
 865
 866         * windows-nat.c (windows_nat_target::fetch_registers)
 867         (windows_nat_target::store_registers): Rename "pid" to "tid".
 868
 869 2019-10-15  Tom Tromey  <tromey@adacore.com>
 870
 871         * gdbarch.h, gdbarch.c: Rebuild.
 872         * gdbarch.sh (gcc_target_options): Change return type to
 873         std::string.
 874         * compile/compile.c (get_args): Update.
 875         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 876         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 877         std::string.
 878         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 879         std::string.
 880         * arch-utils.c (default_gcc_target_options): Return std::string.
 881         * arch-utils.h (default_gcc_target_options): Return std::string.
 882         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 883
 884 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 885
 886         * breakpoint.c (breakpoint_chain): Make static.
 887         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 888         of accessing breakpoint_chain.
 889
 890 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 891
 892         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 893         to a gdb::function_view and return value to bool.
 894         * breakpoint.h (iterate_over_breakpoints): Likewise.
 895         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 896         (pop_dummy_frame): Update.
 897         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 898         (gdbscm_breakpoints): Update.
 899         * python/py-breakpoint.c (build_bp_list): Update.
 900         (gdbpy_breakpoints): Update.
 901         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 902         Update.
 903         (bpfinishpy_handle_stop): Update.
 904         (bpfinishpy_handle_exit): Update.
 905         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 906         (svr4_update_solib_event_breakpoints): Update.
 907
 908 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 909
 910         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 911         when unwrapping single-field structs.
 912
 913 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 914
 915         * dwarf2read.c: Remove includes.
 916
 917 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 918
 919         * ui-out.c (ui_out::call_do_message): Silence
 920         -Wformat-nonliteral warning.
 921
 922 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 923
 924         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 925         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 926         include: readline/tilde.h.
 927
 928 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 929
 930         * remote.c (remote_target::get_trace_status): Remove declaration of
 931         trace_regblock_size.
 932
 933 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 934
 935         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 936         (show_user): Remove declaration of cmdlist.
 937         * cli/cli-cmds.h (max_user_call_depth): Declare.
 938         * cli/cli-script.c (execute_user_command): Remove declaration
 939         of max_user_call_depth.
 940
 941 2019-10-11  Jim Wilson  <jimw@sifive.com>
 942
 943         * gdbsupport/print-utils.h (pulongest): Fix comment.
 944         (plongest): Likewise.
 945         (phex): Add missing comment, mention leading zeros.
 946         (phex_nz): Add mention of no leading zeros to comment.
 947
 948         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 949         plongest instead of unsigned long long cast.
 950
 951 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 952
 953         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 954         for external_editor_command and gdbtk_test.
 955
 956 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 957
 958         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 959         * varobj.c (varobjdebug): Move comment to...
 960         * varobj.h (varobjdebug): ...here, and declare.
 961
 962 2019-10-09  Tom Tromey  <tom@tromey.com>
 963
 964         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 965         erase_data_content.
 966
 967 2019-10-09  Tom Tromey  <tom@tromey.com>
 968
 969         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 970         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 971         * tui/tui-command.c (tui_cmd_window::resize)
 972         (tui_refresh_cmd_win): Update.
 973         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 974         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 975         * tui/tui-data.c (~tui_gen_win_info): Remove.
 976         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 977         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 978         (tui_redisplay_readline, tui_mld_flush)
 979         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 980         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 981         (tui_data_window::erase_data_content)
 982         (tui_data_item_window::rerender)
 983         (tui_data_item_window::refresh_window): Update.
 984         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 985         (box_win, tui_gen_win_info::make_window)
 986         (tui_gen_win_info::make_visible): Update.
 987         (tui_delete_win): Remove.
 988         * tui/tui-winsource.c
 989         (tui_source_window_base::do_erase_source_content): Update.
 990         (tui_show_source_line, tui_source_window_base::update_tab_width)
 991         (tui_source_window_base::update_exec_info): Update.
 992         * tui/tui-data.h (struct curses_deleter): New.
 993         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 994         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 995
 996 2019-10-09  Tom Tromey  <tom@tromey.com>
 997
 998         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 999
1000 2019-10-09  Tom Tromey  <tom@tromey.com>
1001
1002         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1003         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1004
1005 2019-10-09  Tom Tromey  <tom@tromey.com>
1006
1007         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1008         window height directly.
1009         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1010         declare.
1011         * tui/tui-layout.c (tui_default_win_height): Remove.
1012         (tui_default_win_viewport_height): Remove.
1013
1014 2019-10-09  Tom Tromey  <tom@tromey.com>
1015
1016         * tui/tui.h: Remove comments.
1017
1018 2019-10-09  Tom de Vries  <tdevries@suse.de>
1019
1020         * python/lib/gdb/printer/bound_registers.py: Use
1021         '^builtin_type_bound128' as regexp argument for
1022         add_builtin_pretty_printer.
1023
1024 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
1025
1026         * guile/guile.c (guile_extension_script_ops): Remove forward
1027         declaration and mark as static.
1028         (guile_script_ops): Likewise.
1029         (extension_language_guile): Move further down in the file so
1030         it can reference the definitions for guile_{extension_,}script_ops.
1031
1032 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
1033
1034         * s390-tdep.c (390_process_record): Handle new arch13 instructions
1035         except SORTL, DFLTCC, and KDSA.
1036
1037 2019-10-08  Tom Tromey  <tromey@adacore.com>
1038
1039         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1040         (struct safe_symbol_file_add_args): Remove.
1041
1042 2019-10-08  Tom Tromey  <tromey@adacore.com>
1043
1044         * windows-nat.c: Don't include buildsym-legacy.h.
1045
1046 2019-10-08  Tom Tromey  <tromey@adacore.com>
1047
1048         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1049
1050 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1051
1052         * gdbtypes.c (overload_debug): Move comment to header.
1053         * gdbtypes.h (overload_debug): Declare.
1054         * valops.c: Remove declaration of overload_debug, instead
1055         include gdbtypes.h.
1056
1057 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
1058
1059         * language.c (show_language_command): Pass lang_frame_mismatch_warn
1060         through _().
1061         (lang_frame_mismatch_warn): Make const, mark with N_(), and
1062         move comment...
1063         * language.h (lang_frame_mismatch_warn): ... here. Also add
1064         declaration.
1065         * top.c (lang_frame_mismatch_warn): Remove declaration.
1066         (check_frame_language_change): Pass lang_frame_mismatch_warn
1067         through _().
1068
1069 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1070
1071         * c-lang.h (vtbl_ptr_name): Declare.
1072         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1073         it from the header.
1074         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1075
1076 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
1077
1078         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1079         gdb_static_assert.
1080
1081 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1082
1083         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1084         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1085         * ctfread.c: New file.
1086         * ctfread.h: New file.
1087         * elfread.c: Include ctfread.h.
1088         (struct elfinfo text_p): New member ctfsect.
1089         (elf_locate_sections): Mark CTF section.
1090         (elf_symfile_read): Call elfctf_build_psymtabs.
1091         * Makefile.in (LIBCTF): Add.
1092         (CLIBS): Use it.
1093         (CDEPS): Likewise.
1094         (DIST): Add ctfread.c.
1095
1096 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
1097
1098         * ctfread.c (struct nextfield): Renamed to ...
1099         (struct ctf_nextfield): ... this.
1100         (struct field_info): Renamed to ...
1101         (strut ctf_field_info): ... this.
1102         (attach_fields_to_type): Update for renamed structures.
1103         (ctf_add_member_cb): Likewise.
1104         (ctf_add_enum_member_cb): Likewise.
1105         (process_struct_members): Likewise.
1106         (process_enum_type): Likewise.
1107
1108 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
1109
1110         * tracectf.h: Rename, was ctf.h.
1111         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1112         * tracefile.c: Likewise.
1113         * tracepoint.c: Remove unused include ctf.h.
1114         * mi/mi-main.c: Likewise.
1115         * Makefile.in Replace ctf.c with tracectf.c.
1116
1117 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
1118
1119         * version.in: Change version number to "9.0.50.DATE-git".
1120
1121 2019-10-03  Tom Tromey  <tom@tromey.com>
1122
1123         PR rust/24976:
1124         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1125
1126 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1127
1128         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1129         cp_search_name_hash.
1130         * NEWS: Add entry about nested function support.
1131
1132 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
1133             Andrew Burgess  <andrew.burgess@embecosm.com>
1134
1135         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1136         for nested static variables when searchin VAR_DOMAIN.
1137         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1138         global scope, update comment.
1139         (add_partial_subprogram): Call add_partial_subprogram recursively
1140         for nested subroutines when processinng Fortran.
1141         (load_partial_dies): Process the child entities of a subprogram
1142         when processing Fortran.
1143         (partial_die_parent_scope): Handle building scope
1144         for Fortran nested functions.
1145         (process_die): Record that nested functions have a scope.
1146         (new_symbol): Always record Fortran subprograms on the global
1147         symbol list.
1148         (determine_prefix): How to build the prefix for Fortran
1149         subprograms.
1150
1151 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1152
1153         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1154         have just sent the thread a SIGSTOP and are waiting for it to
1155         arrive.
1156
1157 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1158
1159         * btrace.c (btrace_add_pc): Remove whitespace before the template
1160         parameter in 'std::vector <...>'.
1161         (parse_xml_btrace_block): Likewise.
1162         (btrace_maint_decode_pt): Likewise.
1163         (btrace_maint_update_packets): Likewise.
1164         (btrace_maint_print_packets): Likewise.
1165         * btrace.h (struct btrace_maint_info): Likewise.
1166         * dwarf2read.c (struct type_unit_group): Likewise.
1167         (build_type_psymtabs_reader): Likewise.
1168         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1169         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1170         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1171
1172 2019-10-03  Tom de Vries  <tdevries@suse.de>
1173
1174         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1175         the first line of the help text for set/show style metadata.
1176
1177 2019-10-02  Tom Tromey  <tromey@adacore.com>
1178
1179         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1180         * gdbsupport/common-inferior.c: New file.
1181         * infcmd.c (startup_with_shell): Don't define.
1182         * nat/fork-inferior.h (startup_with_shell): Don't declare.
1183         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1184         * inferior.h (startup_with_shell): Don't declare.
1185
1186 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
1187
1188         * gdbsupport/gdb_assert.h: Include errors.h.
1189         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1190
1191 2019-10-02  Tom Tromey  <tromey@adacore.com>
1192
1193         * NEWS: Add $_ada_exception entry.
1194         * ada-lang.c (struct ada_catchpoint): Add constructor.
1195         <m_kind>: New member.
1196         (allocate_location_exception, re_set_exception): Remove
1197         "ex" parameter.
1198         (should_stop_exception): Compute $_ada_exception.
1199         (check_status_exception, print_it_exception)
1200         (print_one_exception, print_mention_exception): Remove
1201         "ex" parameter.
1202         (allocate_location_catch_exception, re_set_catch_exception)
1203         (check_status_exception, print_it_catch_exception)
1204         (print_one_catch_exception, print_mention_catch_exception)
1205         (print_recreate_catch_exception)
1206         (allocate_location_catch_exception_unhandled)
1207         (re_set_catch_exception_unhandled)
1208         (check_status_exception, print_it_catch_exception_unhandled)
1209         (print_one_catch_exception_unhandled)
1210         (print_mention_catch_exception_unhandled)
1211         (print_recreate_catch_exception_unhandled)
1212         (allocate_location_catch_assert, re_set_catch_assert)
1213         (check_status_assert, print_it_catch_assert)
1214         (print_one_catch_assert, print_mention_catch_assert)
1215         (print_recreate_catch_assert)
1216         (allocate_location_catch_handlers, re_set_catch_handlers)
1217         (check_status_handlers, print_it_catch_handlers)
1218         (print_one_catch_handlers, print_mention_catch_handlers)
1219         (print_recreate_catch_handlers): Remove.
1220         (create_ada_exception_catchpoint): Update.
1221         (initialize_ada_catchpoint_ops): Update.
1222
1223 2019-10-02  Tom Tromey  <tromey@adacore.com>
1224
1225         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
1226         (create_excep_cond_exprs): Simplify exception string computation.
1227         (ada_exception_catchpoint_cond_string): Likewise.
1228
1229 2019-10-02  Tom Tromey  <tromey@adacore.com>
1230
1231         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
1232         * ada-lang.c (lesseq_defined_than): Handle
1233         LOC_STATIC.
1234         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
1235         parameter.
1236         (dwarf2_has_info): Likewise.
1237         (new_symbol): Set maybe_copied on symbol when
1238         appropriate.
1239         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
1240         parameter.
1241         <can_copy>: New member.
1242         * elfread.c (record_minimal_symbol): Set maybe_copied
1243         on symbol when appropriate.
1244         (elf_symfile_read): Update call to dwarf2_has_info.
1245         * minsyms.c (lookup_minimal_symbol_linkage): New
1246         function.
1247         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
1248         * symtab.c (get_symbol_address, get_msymbol_address):
1249         New functions.
1250         * symtab.h (get_symbol_address, get_msymbol_address):
1251         Declare.
1252         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
1253         maybe_copied.
1254         (struct symbol, struct minimal_symbol) <maybe_copied>:
1255         New member.
1256
1257 2019-10-02  Tom Tromey  <tromey@adacore.com>
1258
1259         * source.c (struct current_source_location): New.
1260         (current_source_key): New global.
1261         (current_source_symtab, current_source_line)
1262         (current_source_pspace): Remove.
1263         (get_source_location): New function.
1264         (get_current_source_symtab_and_line)
1265         (set_default_source_symtab_and_line)
1266         (set_current_source_symtab_and_line)
1267         (clear_current_source_symtab_and_line, select_source_symtab)
1268         (info_source_command, print_source_lines_base)
1269         (info_line_command, search_command_helper, _initialize_source):
1270         Update.
1271
1272 2019-10-02  Tom Tromey  <tromey@adacore.com>
1273
1274         * source.c (select_source_symtab): Don't call
1275         decode_line_with_current_source.
1276
1277 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1278
1279         * symtab.c (lookup_global_symbol): Search global block.
1280
1281 2019-10-02  Tom Tromey  <tromey@adacore.com>
1282
1283         * coffread.c (process_coff_symbol): Update.
1284         * dwarf2read.c (var_decode_location, new_symbol): Update.
1285         * mdebugread.c (parse_symbol): Update.
1286         * objfiles.c (relocate_one_symbol): Update.
1287         * stabsread.c (define_symbol, fix_common_block)
1288         (scan_file_globals): Update.
1289         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1290         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1291         * xcoffread.c (process_xcoff_symbol): Update.
1292
1293 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1294
1295         * MAINTAINERS: Update my email address.
1296
1297 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1298
1299         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1300         std::vector.
1301         (build_type_psymtabs_reader): Update for std::vector.
1302         (build_type_psymtab_dependencies): Likewise.
1303         * dwarf2read.h: Remove use of DEF_VEC_P.
1304         (typedef sig_type_ptr): Delete.
1305
1306 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1307
1308         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1309         to std::vector.
1310         (btrace_maint_decode_pt): Likewise, and move allocation of the
1311         vector outside of the loop.
1312         (btrace_maint_update_packets): Update to handle change from VEC to
1313         std::vector.
1314         (btrace_maint_print_packets): Likewise.
1315         (maint_info_btrace_cmd): Likewise.
1316         * btrace.h: Remove use of DEF_VEC_O.
1317         (typedef btrace_pt_packet_s): Delete.
1318         (struct btrace_maint_info) <packets>: Change fromm VEC to
1319         std::vector.
1320         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1321
1322 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1323
1324         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1325         make accesses into the vector constant references.
1326         (btrace_add_pc): Update for std::vector.
1327         (btrace_stitch_bts): Likewise.
1328         (parse_xml_btrace_block): Likewise.
1329         (btrace_maint_update_packets): Likewise.
1330         (btrace_maint_print_packets): Likewise.
1331         (maint_info_btrace_cmd): Likewise.
1332         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1333         std::vector.
1334         (btrace_data::empty): Likewise.
1335         (btrace_data_append): Likewise.
1336         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1337         (typedef btrace_block_s): Delete.
1338         (struct btrace_block): Add constructor.
1339         (struct btrace_data_bts) <blocks>: Change to std::vector.
1340         * nat/linux-btrace.c (perf_event_read_bts): Update for
1341         std::vector.
1342         (linux_read_bts): Likewise.
1343
1344 2019-10-01  Tom Tromey  <tom@tromey.com>
1345
1346         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1347
1348 2019-10-01  Tom Tromey  <tom@tromey.com>
1349
1350         * stack.c (print_frame, info_frame_command_core): Use
1351         styled_string.
1352         * linux-thread-db.c (try_thread_db_load_1)
1353         (try_thread_db_load_from_pdir_1): Use styled_string.
1354         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1355         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1356         (maybe_print_unsupported_script_warning)
1357         (maybe_print_script_not_found_warning): Use styled_string.
1358         * ada-lang.c (user_select_syms): Use styled_string.
1359
1360 2019-10-01  Tom Tromey  <tom@tromey.com>
1361
1362         * p-lang.c (pascal_printstr): Use metadata style.
1363         * value.c (show_convenience): Use metadata style.
1364         * valprint.c (valprint_check_validity, val_print_optimized_out)
1365         (val_print_not_saved, val_print_unavailable)
1366         (val_print_invalid_address, generic_val_print, val_print)
1367         (value_check_printable, val_print_array_elements): Use metadata
1368         style.
1369         * ui-out.h (class ui_out) <field_fmt>: New overload.
1370         <do_field_fmt>: Add style parameter.
1371         * ui-out.c (ui_out::field_fmt): New overload.
1372         * typeprint.c (type_print_unknown_return_type)
1373         (val_print_not_allocated, val_print_not_associated): Use metadata
1374         style.
1375         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1376         parameter.
1377         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1378         * tracepoint.c (tvariables_info_1): Use metadata style.
1379         * stack.c (print_frame_arg, print_frame_info, print_frame)
1380         (info_frame_command_core): Use metadata style.
1381         * skip.c (info_skip_command): Use metadata style.
1382         * rust-lang.c (rust_print_enum): Use metadata style.
1383         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1384         metadata style.
1385         * python/py-framefilter.c (py_print_single_arg): Use metadata
1386         style.
1387         * printcmd.c (do_one_display, print_variable_and_value): Use
1388         metadata style.
1389         * p-valprint.c (pascal_val_print)
1390         (pascal_object_print_value_fields): Use metadata style.
1391         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1392         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1393         parameter.
1394         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1395         * m2-valprint.c (m2_print_long_set): Use metadata style.
1396         * m2-typeprint.c (m2_print_type): Use metadata style.
1397         * infcmd.c (print_return_value_1): Use metadata style.
1398         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1399         * f-valprint.c (info_common_command_for_block): Use metadata
1400         style.
1401         * f-typeprint.c (f_type_print_base): Use metadata style.
1402         * expprint.c (print_subexp_standard): Use metadata style.
1403         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1404         * cli/cli-style.h (class cli_style_option): Add constructor.
1405         (metadata_style): Declare.
1406         * cli/cli-style.c (metadata_style): New global.
1407         (_initialize_cli_style): Register metadata style.
1408         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1409         parameter.
1410         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1411         * c-typeprint.c (c_type_print_base_struct_union)
1412         (c_type_print_base_1): Use metadata style.
1413         * breakpoint.c (watchpoint_value_print)
1414         (print_one_breakpoint_location): Use metadata style.
1415         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1416         style.
1417         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1418         style.
1419         * ada-valprint.c (val_print_packed_array_elements, printstr)
1420         (print_field_values, ada_val_print_ref, ada_val_print): Use
1421         metadata style.
1422         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1423         style.
1424         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1425         style.
1426         * ada-lang.c (user_select_syms): Use metadata style.
1427
1428 2019-10-01  Tom Tromey  <tom@tromey.com>
1429
1430         * cli/cli-cmds.c (pwd_command): Style output.
1431
1432 2019-10-01  Pedro Alves  <palves@redhat.com>
1433             Tom Tromey  <tom@tromey.com>
1434
1435         * symtab.c (print_symbol_info): Use %ps.
1436         (print_msymbol_info): Use %ps.
1437         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1438         * printcmd.c (print_variable_and_value): Use %ps.
1439         * macrocmd.c (show_pp_source_pos): Use %ps.
1440         * infrun.c (print_exited_reason): Use ui_out::message.
1441         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1442         (describe_other_breakpoints): Use ui_out::message and new
1443         formats.
1444         (say_where): Use new formats.
1445         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1446         and new formats.
1447
1448 2019-10-01  Pedro Alves  <palves@redhat.com>
1449             Tom Tromey  <tom@tromey.com>
1450
1451         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1452         (test_gdb_formats): New function.
1453         (run_tests): Call it.
1454         (test_format_specifier): Update.
1455         * utils.h (fputs_filtered): Update comment.
1456         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1457         (fputs_styled_unfiltered): Declare.
1458         * utils.c (fputs_styled_unfiltered): New function.
1459         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1460         (vfprintf_filtered): Update.
1461         (vfprintf_unfiltered, vprintf_filtered): Update.
1462         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1463         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1464         disallow_ui_out_field>: New constants.
1465         (enum class field_kind): New.
1466         (struct base_field_s, struct signed_field_s): New.
1467         (signed_field): New function.
1468         (struct string_field_s): New.
1469         (string_field): New function.
1470         (struct styled_string_s): New.
1471         (styled_string): New function.
1472         (class ui_out) <message>: Add comment.
1473         <vmessage, call_do_message>: New methods.
1474         <do_message>: Add style parameter.
1475         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1476         methods.
1477         (ui_out::message): Rewrite.
1478         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1479         parameter.
1480         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1481         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1482         gdb_extensions parameter.
1483         (class format_piece): Add parameter to constructor.
1484         (n_int_args): New field.
1485         * gdbsupport/format.c (format_pieces::format_pieces): Add
1486         gdb_extensions parameter.  Handle '*'.
1487         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1488         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1489         vfprintf_styled_no_gdbfmt.
1490         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1491         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1492         unfiltered output.
1493         * ui-style.h (struct ui_file_style) <ptr>: New method.
1494
1495 2019-10-01  Tom Tromey  <tom@tromey.com>
1496
1497         * unittests/format_pieces-selftests.c: Update.  Add final format.
1498         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1499         empty literal pieces.
1500
1501 2019-10-01  Tom Tromey  <tom@tromey.com>
1502
1503         * ui-out.h (enum class ui_out_style_kind): Remove.
1504         (class ui_out) <field_string, field_stsream, do_field_string>:
1505         Change type of "style".
1506         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1507         (ui_out::field_string): Update.
1508         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1509         of "style".
1510         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1511         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1512         * stack.c (print_frame_arg, print_frame_info, print_frame):
1513         Update.
1514         * source.c (print_source_lines_base): Update.
1515         * solib.c (info_sharedlibrary_command): Update.
1516         * skip.c (info_skip_command): Update.
1517         * record-btrace.c (btrace_call_history_src_line)
1518         (btrace_call_history): Update.
1519         * python/py-framefilter.c (py_print_frame): Update.
1520         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1521         "style".
1522         * mi/mi-out.c (mi_ui_out::do_table_header)
1523         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1524         (mi_ui_out::do_field_string): Update.
1525         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1526         Update.
1527         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1528         "style".
1529         * cli-out.c (cli_ui_out::do_table_header)
1530         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1531         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1532         (cli_ui_out::do_field_fmt): Update.
1533         * breakpoint.c (print_breakpoint_location): Update.
1534         (update_static_tracepoint): Update.
1535
1536 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1537
1538         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1539         conversion of gdb_datadir.
1540         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1541         remove not needed c_str ().
1542
1543 2019-09-30  Ali Tamur <tamur@google.com>
1544
1545         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1546         (dwarf2_string_attr): Likewise.
1547
1548 2019-09-30  Ali Tamur <tamur@google.com>
1549
1550         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1551         (process_full_type_unit): Likewise.
1552         (dump_die_shallow): Likewise.
1553         (cu_debug_loc_section): Likewise.
1554
1555 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1556
1557         * minsyms.c (compare_minimal_symbols): Rename to...
1558         (minimal_symbol_is_less_than): ...this, and adjust to STL
1559         conventions (return bool, take arguments as references)
1560         (minimal_symbol_reader::install): Call std::sort instead
1561         of qsort.
1562
1563 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1564
1565         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1566         hash and why.
1567         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1568         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1569
1570 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1571
1572         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1573         * psympriv.h (add_psymbol_to_list): Move comment here and update
1574         it.
1575
1576 2019-09-29  Tom de Vries  <tdevries@suse.de>
1577
1578         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1579         Use $tmpdir/$(basename "$output_file").dwz instead of
1580         "${output_file}.dwz".
1581
1582 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1583
1584         PR gdb/25045
1585         * hppa-linux-nat.c: Include gdbarch.h.
1586
1587 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1588
1589         * blockframe.c (find_pc_partial_function): Change return type to bool.
1590         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1591         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1592         (stub_gnu_ifunc_resolve_name): Likewise.
1593         * symtab.c (compare_filenames_for_search): Likewise.
1594         (compare_glob_filenames_for_search): Likewise.
1595         (matching_obj_sections): Likewise.
1596         (symbol_matches_domain): Likewise.
1597         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1598         (find_line_pc): Change return type to bool.
1599         (find_line_pc_range): Likewise.
1600         (producer_is_realview): Likewise.
1601         * symtab.h (symbol_matches_domain): Likewise.
1602         (find_pc_partial_function): Likewise.
1603         (find_pc_line_pc_range): Likewise.
1604         (in_gnu_ifunc_stub): Likewise.
1605         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1606         (find_line_pc): Likewise.
1607         (find_line_pc_range): Likewise.
1608         (matching_obj_sections): Likewise.
1609         (find_line_symtab): Change out parameter to bool.
1610         (producer_is_realview): Change return type to bool.
1611         (compare_filenames_for_search): Likewise.
1612         (compare_glob_filenames_for_search): Likewise.
1613
1614 2019-09-26  Tom Tromey  <tom@tromey.com>
1615
1616         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1617         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1618         * gdb_usleep.h: Remove.
1619         * gdb_usleep.c: Remove.
1620         * utils.c: Don't include gdb_usleep.h.
1621
1622 2019-09-26  Tom Tromey  <tromey@adacore.com>
1623
1624         * python/py-type.c (type_to_type_object): Call check_typedef
1625         for stub types.
1626
1627 2019-09-26  Tom Tromey  <tom@tromey.com>
1628
1629         * utils.h (initialize_utils): Don't declare.
1630         * top.c (gdb_init): Don't call initialize_utils.
1631         * utils.c (initialize_utils): Remove.  Move contents...
1632         (_initialize_utils): ... here.
1633
1634 2019-09-25  Tom Tromey  <tom@tromey.com>
1635
1636         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1637         * utils.h (make_hex_string): Don't declare.
1638         * utils.c (make_hex_string): Remove.
1639
1640 2019-09-24  Tom de Vries  <tdevries@suse.de>
1641
1642         PR gdb/23815
1643         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1644         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1645
1646 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1647
1648         * NEWS: Mention new simulator port for PRU.
1649
1650 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1651
1652         * ada-exp.y (write_object_remaining): Update.
1653         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1654         and eliminate the static buffer.
1655         (ada_decode_symbol): Update.
1656         (ada_la_decode): Update.
1657         (ada_sniff_from_mangled_name): Update.
1658         (is_valid_name_for_wild_match): Update.
1659         (ada_lookup_name_info::matches): Update and simplify.
1660         (name_matches_regex): Update.
1661         (ada_add_global_exceptions): Update.
1662         * ada-lang.h (ada_decode): Update signature.
1663         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1664         * dwarf-index-write.c (debug_names::insert): Update.
1665
1666 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1667
1668         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1669         formatting.
1670
1671 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1672
1673         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1674         Change "nonzero" to "true" in documentation.
1675
1676 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1677
1678         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1679         (_initialize_darwin_solib): Don't set
1680         darwin_so_ops.lookup_lib_global_symbol.
1681         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1682         set_gdbarch_iterate_over_objfiles_in_search_order.
1683         (elf_lookup_lib_symbol): Rename to...
1684         (svr4_iterate_over_objfiles_in_search_order): this, and update
1685         to iterate semantics.
1686         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1687         * solib.c (solib_global_lookup): Remove.
1688         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1689         (solib_global_lookup): Remove.
1690         * symtab.c (lookup_global_or_static_symbol): Remove call to
1691         solib_global_lookup.
1692
1693 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1694
1695         * NEWS: Move entries about default MI version now being
1696         version 3, and about the GDB/MI fix for multi-location
1697         breakpoints to the "since GDB 8.3" section.
1698
1699 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1700
1701         GDB 8.3.1 released.
1702
1703 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1704
1705         * NEWS: Mention that Cell/B.E. debugging support was removed.
1706         * MAINTAINERS: Remove spu target.
1707
1708         * config/djgpp/fnchange.lst: Remove entries for removed files.
1709
1710         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1711         spu-multiarch.o, and spu-tdep.o.
1712         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1713         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1714         spu-multiarch.c, and spu-tdep.c.
1715         * spu-linux-nat.c: Remove file.
1716         * spu-multiarch.c: Remove file.
1717         * spu-tdep.c: Remove file.
1718         * spu-tdep.h: Remove file.
1719         * solib-spu.c: Remove file.
1720         * solib-spu.h: Remove file.
1721
1722         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1723         * configure.nat (spu-linux): Remove.
1724         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1725         solib-multiarch.o from gdb_target_obs.
1726         (spu*-*-*): Remove.
1727
1728         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1729         feature flag.
1730         (ppc_linux_no_features): Update.
1731         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1732         Cell/B.E. support.
1733         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1734         (tdesc_powerpc_cell64l): Likewise.
1735         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1736         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1737         Cell/B.E. support.
1738         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1739         Do not include "features/rs6000/powerpc-cell32l.c" or
1740         "features/rs6000/powerpc-cell64l.c".
1741         (ppc_linux_spu_section): Remove.
1742         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1743         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1744         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1745         (ppc_linux_spe_context_lookup): Remove.
1746         (ppc_linux_spe_context_inferior_created): Remove.
1747         (ppc_linux_spe_context_solib_loaded): Remove.
1748         (ppc_linux_spe_context_solib_unloaded): Remove.
1749         (ppc_linux_spe_context): Remove.
1750         (struct ppu2spu_cache): Remove.
1751         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1752         (struct ppu2spu_data): Remove.
1753         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1754         ppu2spu_unwind): Remove.
1755         (ppc_linux_init_abi): Remove Cell/B.E. support.
1756         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1757
1758         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1759         (rs6000/powerpc-cell64l-expedite): Likewise
1760         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1761         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1762         rs6000/powerpc-cell64l.xml.
1763         * features/rs6000/powerpc-cell32l.xml: Remove.
1764         * features/rs6000/powerpc-cell64l.xml: Likewise.
1765         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1766         * features/rs6000/powerpc-cell64l.c: Likewise.
1767         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1768         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1769         * regformats/reg-spu.dat: Remove.
1770
1771         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1772         * corelow.c (struct spuid_list): Remove.
1773         (add_to_spuid_list): Remove.
1774         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1775         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1776         (remote_protocol_features): Remove associated entries.
1777         (_initialize_remote): No longer initialize them.
1778         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1779         * linux-nat.c (SPUFS_MAGIC): Remove.
1780         (linux_proc_xfer_spu): Remove.
1781         (spu_enumerate_spu_ids): Remove.
1782         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1783         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1784         (linux_make_corefile_notes): No longer call it.
1785
1786         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1787         (cooked_write_test): Likewise.
1788
1789 2019-09-20  Tom Tromey  <tom@tromey.com>
1790
1791         * NEWS: Mention case-sensitivity of TUI commands.
1792         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1793         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1794         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1795
1796 2019-09-20  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-source.c (tui_source_window::set_contents): Use
1799         make_unique_xstrdup.
1800         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1801         make_unique_xstrdup.
1802
1803 2019-09-20  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-data.c: Remove separator comments.
1806         * tui/tui-layout.c: Remove separator comments.
1807         * tui/tui-win.c: Remove separator comments.
1808         * tui/tui-wingeneral.c: Remove separator comments.
1809
1810 2019-09-20  Tom Tromey  <tom@tromey.com>
1811
1812         * tui/tui.h (strcat_to_buf): Don't declare.
1813         * tui/tui.c (strcat_to_buf): Remove.
1814
1815 2019-09-20  Tom Tromey  <tom@tromey.com>
1816
1817         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1818         from "fullname".
1819         * tui/tui-source.c (tui_source_window::set_contents)
1820         (tui_source_window::location_matches_p)
1821         (tui_source_window::maybe_update): Update.
1822
1823 2019-09-20  Tom Tromey  <tom@tromey.com>
1824
1825         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1826         Update.
1827         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1828         prefix.
1829         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1830         (tui_data_window::line_from_reg_element_no)
1831         (tui_data_window::first_reg_element_no_inline)
1832         (tui_data_window::show_registers)
1833         (tui_data_window::show_register_group)
1834         (tui_data_window::display_registers_from)
1835         (tui_data_window::display_registers_from_line)
1836         (tui_data_window::first_data_item_displayed)
1837         (tui_data_window::delete_data_content_windows)
1838         (tui_data_window::erase_data_content)
1839         (tui_data_window::do_scroll_vertical)
1840         (tui_data_window::refresh_window)
1841         (tui_data_window::check_register_values): Update.
1842
1843 2019-09-20  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1846         (struct tui_locator_window) <full_name, proc_name>: Now
1847         std::string.
1848         * tui/tui-stack.c (tui_locator_window::make_status_line)
1849         (tui_locator_window::set_locator_fullname)
1850         (tui_locator_window::set_locator_info): Update.
1851         * tui/tui-source.c (tui_source_window::set_contents)
1852         (tui_source_window::showing_source_p): Update.
1853
1854 2019-09-20  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1857         Don't call tui_locator_win_info_ptr.
1858
1859 2019-09-20  Tom Tromey  <tom@tromey.com>
1860
1861         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1862
1863 2019-09-20  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1866         height for locator.
1867         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1868         * tui/tui-layout.c (show_source_disasm_command, show_data)
1869         (show_source_or_disasm_and_command): Use 1 as height for locator.
1870
1871 2019-09-20  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui.c (tui_enable): Update.
1874         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1875         Update.
1876         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1877         Update.
1878         * tui/tui-data.c (win_resized): Now bool.
1879         (tui_win_resized): Return bool.
1880         (tui_set_win_resized_to): Accept a bool.
1881
1882 2019-09-20  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1885         Change type of "refresh_values_only".
1886         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1887         type of "refresh_values_only".
1888
1889 2019-09-20  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1892         std::string.
1893         (tui_disassemble): Add "pos" parameter.
1894         (tui_disasm_window::set_contents): Simplify.
1895
1896 2019-09-20  Tom Tromey  <tom@tromey.com>
1897
1898         * tui/tui-winsource.h (struct tui_source_window_base)
1899         <show_source_content>: Now private.
1900         * tui/tui-winsource.c
1901         (tui_source_window_base::show_source_content): Don't handle empty
1902         content case.
1903
1904 2019-09-20  Tom Tromey  <tom@tromey.com>
1905
1906         * tui/tui-layout.c (show_source_disasm_command)
1907         (show_source_or_disasm_and_command): Don't call
1908         show_source_content.
1909
1910 2019-09-20  Tom Tromey  <tom@tromey.com>
1911
1912         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1913         Declare.
1914         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1915         from tui_make_status_line.
1916         (tui_locator_window::rerender): Update.
1917
1918 2019-09-20  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1921         (tui_locator_window::rerender): Update.
1922
1923 2019-09-20  Tom Tromey  <tom@tromey.com>
1924
1925         * tui/tui-winsource.h (struct tui_source_window_base)
1926         <~tui_source_window_base>: Don't declare.
1927         <fullname>: Remove.
1928         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1929         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1930         member.
1931         * tui/tui-source.c (tui_source_window::set_contents): Update.
1932         (tui_source_window::location_matches_p)
1933         (tui_source_window::maybe_update): Update.
1934
1935 2019-09-20  Tom Tromey  <tom@tromey.com>
1936
1937         * tui/tui-winsource.h (~tui_source_element): Remove.
1938         (tui_source_element): Update.
1939         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1940         * tui/tui-winsource.c (tui_show_source_line): Update.
1941         * tui/tui-source.c (tui_source_window::set_contents): Update.
1942         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1943
1944 2019-09-20  Tom Tromey  <tom@tromey.com>
1945
1946         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1947         declare.
1948         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1949         tui_clear_source_windows_detail.
1950         * tui/tui-winsource.h (struct tui_source_window_base)
1951         <clear_detail>: Don't declare.
1952         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1953         Remove.
1954         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1955
1956 2019-09-20  Tom Tromey  <tromey@adacore.com>
1957
1958         PR ada/24919:
1959         * block.c (contained_in): Fix final return value.
1960
1961 2019-09-20  Alan Modra  <amodra@gmail.com>
1962
1963         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1964         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1965         (read_indirect_string_from_dwz): Use bfd accessor.
1966         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1967         * machoread.c (macho_symfile_read_all_oso): Likewise.
1968         * solib.c (solib_bfd_open): Likewise.
1969
1970 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1971
1972         * eval.c: Move declaration of overload_resolution to...
1973         * value.h: ...here.
1974
1975 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1976
1977         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1978         * arm-linux-tdep.c: Likewise.
1979         * arm-nbsd-nat.c: Likewise.
1980         * arm-tdep.h: Declare arm_apcs_32.
1981         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1982
1983 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1984
1985         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1986         * dwarf2read.h: Declare dwarf_always_disassemble.
1987
1988 2019-09-19  Tom de Vries  <tdevries@suse.de>
1989
1990         PR gdb/25009
1991         * source-cache.c (source_cache::ensure): Catch exception thrown during
1992         construction of the highlighter.
1993
1994 2019-09-18  Alan Modra  <amodra@gmail.com>
1995
1996         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1997         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1998         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1999         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2000         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2001         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2002         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2003         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2004         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2005         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2006         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2007         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2008         * solib-spu.c, * solib-svr4.c, * solib-target.c,
2009         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2010         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2011         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2012         * mi/mi-interp.c: Update throughout for bfd section macro and
2013         function changes.
2014         * gcore (gcore_create_callback): Use bfd_set_section_lma.
2015         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2016
2017 2019-09-18  Tom Tromey  <tom@tromey.com>
2018
2019         * NEWS: Add entry.
2020         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
2021         call rl_initialize.
2022         (tui_enable): Do not call rl_initialize.
2023
2024 2019-09-18  Christian Groessler  <chris@groessler.org>
2025
2026         * alpha-linux-nat.c: Include gdbarch.h.
2027
2028 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
2029
2030         * ui-file.c: Include cli/cli-style.h.
2031         (term_cli_styling): Remove cli_styling declaration.
2032
2033 2019-09-18  Alan Modra  <amodra@gmail.com>
2034
2035         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2036         to bfd_asymbol_section.
2037
2038 2019-09-18  Alan Modra  <amodra@gmail.com>
2039
2040         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2041         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2042         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2043
2044 2019-09-18  Alan Modra  <amodra@gmail.com>
2045
2046         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2047         * spu-linux-nat.c (spu_bfd_open): Likewise.
2048
2049 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
2050
2051         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2052         to bool to match definition in dwarf2read.c.
2053
2054 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
2055
2056         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2057         (print_signatures): Likewise.
2058         (trust_pad_over_xvs): Likewise.
2059         * arch/aarch64-insn.c (aarch64_debug): Likewise.
2060         * arch/aarch64-insn.h (aarch64_debug): Likewise.
2061         * arm-linux-nat.c (arm_apcs_32): Likewise.
2062         * arm-linux-tdep.c (arm_apcs_32): Likewise.
2063         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2064         * arm-tdep.c (arm_debug): Likewise.
2065         (arm_apcs_32): Likewise.
2066         * auto-load.c (debug_auto_load): Likewise.
2067         (auto_load_gdb_scripts): Likewise.
2068         (global_auto_load): Likewise.
2069         (auto_load_local_gdbinit): Likewise.
2070         (auto_load_local_gdbinit_loaded): Likewise.
2071         * auto-load.h (global_auto_load): Likewise.
2072         (auto_load_local_gdbinit): Likewise.
2073         (auto_load_local_gdbinit_loaded): Likewise.
2074         * breakpoint.c (disconnected_dprintf): Likewise.
2075         (breakpoint_proceeded): Likewise.
2076         (automatic_hardware_breakpoints): Likewise.
2077         (always_inserted_mode): Likewise.
2078         (target_exact_watchpoints): Likewise.
2079         (_initialize_breakpoint): Update.
2080         * breakpoint.h (target_exact_watchpoints): Change to bool.
2081         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2082         * cli/cli-cmds.c (trace_commands): Likewise.
2083         * cli/cli-cmds.h (trace_commands): Likewise.
2084         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2085         to bool*.
2086         * cli/cli-logging.c (logging_overwrite): Change to bool.
2087         (logging_redirect): Likewise.
2088         (debug_redirect): Likewise.
2089         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2090         (struct boolean_option_def) <get_var_address_cb_>: Change return type
2091         to bool.
2092         <boolean_option_def>: Update.
2093         (struct flag_option_def): Change default type of Context to bool
2094         from int.
2095         <flag_option_def>: Change return type of var_address_cb_ to bool*.
2096         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2097         (get_setshow_command_value_string): Likewise.
2098         * cli/cli-style.c (cli_styling): Change to bool.
2099         (source_styling): Likewise.
2100         * cli/cli-style.h (source_styling): Likewise.
2101         (cli_styling): Likewise.
2102         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2103         to bool.
2104         * command.h (var_types): Update comment.
2105         (add_setshow_boolean_cmd): Change int* var argument to bool*.
2106         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2107         bool.
2108         (debug_compile_cplus_scopes): Likewise.
2109         * compile/compile-internal.h (compile_debug): Likewise.
2110         * compile/compile.c (compile_debug): Likewise.
2111         (struct compile_options) <raw>: Likewise.
2112         * cp-support.c (catch_demangler_crashes): Likewise.
2113         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2114         (usr_cmd_cris_dwarf2_cfi): Likewise.
2115         * csky-tdep.c (csky_debug): Likewise.
2116         * darwin-nat.c (enable_mach_exceptions): Likewise.
2117         * dcache.c (dcache_enabled_p): Likewise.
2118         * defs.h (info_verbose): Likewise.
2119         * demangle.c (demangle): Likewise.
2120         (asm_demangle): Likewise.
2121         * dwarf-index-cache.c (debug_index_cache): Likewise.
2122         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2123         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2124         * dwarf2read.c (check_physname): Likewise.
2125         (use_deprecated_index_sections): Likewise.
2126         (dwarf_always_disassemble): Likewise.
2127         * eval.c (overload_resolution): Likewise.
2128         * event-top.c (set_editing_cmd_var): Likewise.
2129         (exec_done_display_p): Likewise.
2130         * event-top.h (set_editing_cmd_var): Likewise.
2131         (exec_done_display_p): Likewise.
2132         * exec.c (write_files): Likewise.
2133         * fbsd-nat.c (debug_fbsd_lwp): Likewise
2134         (debug_fbsd_nat): Likewise.
2135         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2136         Likewise.
2137         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2138         <backtrace_past_entry> Likewise.
2139         * gdb-demangle.h (demangle): Likewise.
2140         (asm_demangle): Likewise.
2141         * gdb_bfd.c (bfd_sharing): Likewise.
2142         * gdbcore.h (write_files): Likewise.
2143         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2144         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2145         * gdbthread.h (print_thread_events): Likewise.
2146         * gdbtypes.c (opaque_type_resolution): Likewise.
2147         (strict_type_checking): Likewise.
2148         * gnu-nat.c (gnu_debug_flag): Likewise.
2149         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2150         * guile/scm-param.c (pascm_variable): Add boolval.
2151         (add_setshow_generic): Update.
2152         (pascm_param_value): Update.
2153         (pascm_set_param_value_x): Update.
2154         * hppa-tdep.c (hppa_debug): Change to bool..
2155         * infcall.c (may_call_functions_p): Likewise.
2156         (coerce_float_to_double_p): Likewise.
2157         (unwind_on_signal_p): Likewise.
2158         (unwind_on_terminating_exception_p): Likewise.
2159         * infcmd.c (startup_with_shell): Likewise.
2160         * inferior.c (print_inferior_events): Likewise.
2161         * inferior.h (startup_with_shell): Likewise.
2162         (print_inferior_events): Likewise.
2163         * infrun.c (step_stop_if_no_debug): Likewise.
2164         (detach_fork): Likewise.
2165         (debug_displaced): Likewise.
2166         (disable_randomization): Likewise.
2167         (non_stop): Likewise.
2168         (non_stop_1): Likewise.
2169         (observer_mode): Likewise.
2170         (observer_mode_1): Likewise.
2171         (set_observer_mode): Update.
2172         (sched_multi): Change to bool.
2173         * infrun.h (debug_displaced): Likewise.
2174         (sched_multi): Likewise.
2175         (step_stop_if_no_debug): Likewise.
2176         (non_stop): Likewise.
2177         (disable_randomization): Likewise.
2178         * linux-tdep.c (use_coredump_filter): Likewise.
2179         (dump_excluded_mappings): Likewise.
2180         * linux-thread-db.c (auto_load_thread_db): Likewise.
2181         (check_thread_db_on_load): Likewise.
2182         * main.c (captured_main_1): Update.
2183         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2184         xx2_opt, boolean_opt>: Change to bool.
2185         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2186         * maint.c (maintenance_profile_p): Likewise.
2187         (per_command_time): Likewise.
2188         (per_command_space): Likewise.
2189         (per_command_symtab): Likewise.
2190         * memattr.c (inaccessible_by_default): Likewise.
2191         * mi/mi-main.c (mi_async): Likewise.
2192         (mi_async_1): Likewise.
2193         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2194         * nat/fork-inferior.h (startup_with_shell): Likewise.
2195         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2196         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2197         * nios2-tdep.c (nios2_debug): Likewise.
2198         * or1k-tdep.c (or1k_debug): Likewise.
2199         * parse.c (parser_debug): Likewise.
2200         * parser-defs.h (parser_debug): Likewise.
2201         * printcmd.c (print_symbol_filename): Likewise.
2202         * proc-api.c (procfs_trace): Likewise.
2203         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2204         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2205         (set_parameter_value): Update.
2206         (add_setshow_generic): Update.
2207         * python/py-value.c (copy_py_bool_obj): Change argument from int*
2208         to bool*.
2209         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2210         int*.
2211         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2212         * record-btrace.c (record_btrace_target::store_registers): Update.
2213         * record-full.c (record_full_memory_query): Change to bool.
2214         (record_full_stop_at_limit): Likewise.
2215         * record-full.h (record_full_memory_query): Likewise.
2216         * remote-notif.c (notif_debug): Likewise.
2217         * remote-notif.h (notif_debug): Likewise.
2218         * remote.c (use_range_stepping): Likewise.
2219         (interrupt_on_connect): Likewise.
2220         (remote_break): Likewise.
2221         * ser-tcp.c (tcp_auto_retry): Likewise.
2222         * ser-unix.c (serial_hwflow): Likewise.
2223         * skip.c (debug_skip): Likewise.
2224         * solib-aix.c (solib_aix_debug): Likewise.
2225         * spu-tdep.c (spu_stop_on_load_p): Likewise.
2226         (spu_auto_flush_cache_p): Likewise.
2227         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
2228         Likewise.
2229         (struct info_print_options) <quiet>: Likewise.
2230         * symfile-debug.c (debug_symfile): Likewise.
2231         * symfile.c (auto_solib_add): Likewise.
2232         (separate_debug_file_debug): Likewise.
2233         * symfile.h (auto_solib_add): Likewise.
2234         (separate_debug_file_debug): Likewise.
2235         * symtab.c (basenames_may_differ): Likewise.
2236         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
2237         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
2238         (struct info_types_options) <quiet>: Likewise.
2239         * symtab.h (demangle): Likewise.
2240         (basenames_may_differ): Likewise.
2241         * target-dcache.c (stack_cache_enabled_1): Likewise.
2242         (code_cache_enabled_1): Likewise.
2243         * target.c (trust_readonly): Likewise.
2244         (may_write_registers): Likewise.
2245         (may_write_memory): Likewise.
2246         (may_insert_breakpoints): Likewise.
2247         (may_insert_tracepoints): Likewise.
2248         (may_insert_fast_tracepoints): Likewise.
2249         (may_stop): Likewise.
2250         (auto_connect_native_target): Likewise.
2251         (target_stop_and_wait): Update.
2252         (target_async_permitted): Change to bool.
2253         (target_async_permitted_1): Likewise.
2254         (may_write_registers_1): Likewise.
2255         (may_write_memory_1): Likewise.
2256         (may_insert_breakpoints_1): Likewise.
2257         (may_insert_tracepoints_1): Likewise.
2258         (may_insert_fast_tracepoints_1): Likewise.
2259         (may_stop_1): Likewise.
2260         * target.h (target_async_permitted): Likewise.
2261         (may_write_registers): Likewise.
2262         (may_write_memory): Likewise.
2263         (may_insert_breakpoints): Likewise.
2264         (may_insert_tracepoints): Likewise.
2265         (may_insert_fast_tracepoints): Likewise.
2266         (may_stop): Likewise.
2267         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
2268         (make_thread_apply_all_options_def_group): Change argument from int*
2269         to bool*.
2270         (thread_apply_all_command): Update.
2271         (print_thread_events): Change to bool.
2272         * top.c (confirm): Likewise.
2273         (command_editing_p): Likewise.
2274         (history_expansion_p): Likewise.
2275         (write_history_p): Likewise.
2276         (info_verbose): Likewise.
2277         * top.h (confirm): Likewise.
2278         (history_expansion_p): Likewise.
2279         * tracepoint.c (disconnected_tracing): Likewise.
2280         (circular_trace_buffer): Likewise.
2281         * typeprint.c (print_methods): Likewise.
2282         (print_typedefs): Likewise.
2283         * utils.c (debug_timestamp): Likewise.
2284         (sevenbit_strings): Likewise.
2285         (pagination_enabled): Likewise.
2286         * utils.h (sevenbit_strings): Likewise.
2287         (pagination_enabled): Likewise.
2288         * valops.c (overload_resolution): Likewise.
2289         * valprint.h (struct value_print_options) <prettyformat_arrays,
2290         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2291         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2292         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2293         Likewise.
2294         * windows-nat.c (new_console): Likewise.
2295         (cygwin_exceptions): Likewise.
2296         (new_group): Likewise.
2297         (debug_exec): Likewise.
2298         (debug_events): Likewise.
2299         (debug_memory): Likewise.
2300         (debug_exceptions): Likewise.
2301         (useshell): Likewise.
2302         * windows-tdep.c (maint_display_all_tib): Likewise.
2303         * xml-support.c (debug_xml): Likewise.
2304
2305 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2306
2307         * source.c (prepare_path_for_appending): New function.
2308         (openp): Make use of new function.
2309         (find_and_open_source): Search for the compilation directory and
2310         source file as a relative path beneath the directory search path.
2311
2312 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2313
2314         * source-cache.c (source_cache::get_line_charpos): Catch
2315         exceptions and return false, this matches the behaviour documented
2316         in the header file.
2317
2318 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2319
2320         * ada-tasks.c (info_task): Remove quoting of the task's name.
2321
2322 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2323
2324         * symfile.c (auto_solib_add): Replace comment with a reference
2325         to the header file.
2326
2327 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2328
2329         * NEWS: Mention that gdb can now be compiled with Python 3
2330         on Windows.
2331
2332 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2333
2334         * maint.c (maint_print_section_data::maint_print_section_data):
2335         Force use of 'float log10 (float)' by casting the argument to
2336         float.
2337
2338 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2339
2340         * maint.c: Add 'cmath' include.
2341         (struct maint_print_section_data): New structure.
2342         (print_section_index): New function.
2343         (print_bfd_section_info): Add header comment, small whitespace
2344         cleanup, and update to call new print_section_index function.
2345         (print_objfile_section_info): Likewise.
2346         (maint_obj_section_from_bfd_section): New function.
2347         (print_bfd_section_info_maybe_relocated): New function.
2348         (maintenance_info_sections): Add header comment, always use
2349         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2350
2351 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2352
2353         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2354         inner scope, add check that the objfile has psymtabs before
2355         checking psymtabs_addrmap.
2356         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2357
2358 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2359
2360         * NEWS: Announce that Ada task names are now shown at more places,
2361         and between quotes (except in info task output).
2362         * gdb/ada-tasks.c (task_to_str): New function.
2363         (display_current_task_id): Call task_to_str.
2364         (task_command_1): Likewise.
2365         (print_ada_task_info): In non-mi mode, Properly align headers and data
2366         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2367
2368 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2369
2370         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2371         prstatus.pr_lwp.pr_info instead of making it up.
2372
2373 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2374
2375         * auto-load.c (auto_load_expand_dir_vars): Update.
2376         * defs.h (gdb_datadir): Change to std::string.
2377         (python_libdir): Likewise.
2378         (relocate_gdb_directory): Change return type to std::string.
2379         * guile/guile.c (gdbscm_data_directory): Update.
2380         (initialize_scheme_side): Update.
2381         * jit.c (jit_reader_dir): Change to std::string.
2382         (jit_reader_load_command): Update.
2383         * main.c (gdb_datadir): Change to std::string.
2384         (python_libdir): Likewise.
2385         (set_gdb_data_directory): Update.
2386         (relocate_path): Change to return std::string.
2387         (relocate_gdb_directory): Change to return std::string.
2388         (relocate_gdbinit_path_maybe_in_datadir): Update.
2389         (captured_main_1): Update.
2390         * python/python.c (do_start_initialization): Update.
2391         * top.c (show_gdb_datadir): Update.
2392         * xml-syscall.c (xml_init_syscalls_info): Update.
2393         (init_syscalls_info): Update.
2394
2395 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2396
2397         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2398         out of get_init_files.
2399         (get_init_files): Update.
2400
2401 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2402
2403         * main.c (get_init_files): Change to use std::string.
2404         (captured_main_1): Update.
2405         (print_gdb_help): Update.
2406
2407 2019-09-11  Ali Tamur  <tamur@google.com>
2408
2409         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2410         implementation.
2411
2412 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2413
2414         * dbxread.c (read_dbx_symtab): Update.
2415         * dwarf2read.c (load_partial_dies): Update.
2416         * mdebugread.c (parse_partial_symbols): Update.
2417         (handle_psymbol_enumerators): Update.
2418         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2419         * psymtab.c (add_psymbol_to_bcache): Likewise.
2420         (add_psymbol_to_list): Likewise.
2421         * symtab.c (symbol_set_names): Likewise.
2422         * symtab.h (symbol_set_names): Likewise.
2423         * xcoffread.c (scan_xcoff_symtab): Update.
2424
2425 2019-09-11  Tom Tromey  <tom@tromey.com>
2426
2427         * symfile-mem.c (symbol_file_add_from_memory): Use
2428         bfd_set_filename.
2429         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2430         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2431
2432 2019-09-10  Tom Tromey  <tromey@adacore.com>
2433
2434         * dwarf-index-write.c (write_psymbols): Extend error message.
2435         (debug_names::insert): Add Ada code.
2436         (debug_names::write_psymbols): Remove Ada check.
2437         (debug_names) <m_string_obstack>: New member.
2438         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2439         (gdb_index_symbol_name_matcher::matches): Remove.
2440         (mapped_index_base::find_name_components_bounds): Add "lang"
2441         parameter.
2442         (mapped_index_base::build_name_components): Also split names
2443         according to Ada syntax.
2444         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2445         type of "match_callback".
2446         (check_match, check_find_bounds_finds)
2447         (dw2_expand_symtabs_matching): Update.
2448         (dw2_debug_names_iterator): Add new constructor.
2449         (dw2_debug_names_map_matching_symbols): New function.
2450         (dw2_debug_names_expand_symtabs_matching): Update.
2451         (dwarf2_debug_names_functions): Use
2452         dw2_debug_names_map_matching_symbols.
2453
2454 2019-09-10  Tom Tromey  <tromey@adacore.com>
2455
2456         * dwarf2read.c (dw2_get_file_names_reader): Add the
2457         CU's file name to the results.
2458
2459 2019-09-10  Tom Tromey  <tromey@adacore.com>
2460
2461         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2462         map_matching_symbols.  Update.
2463         * dwarf2read.c (dw2_map_matching_symbols): Update.
2464         * psymtab.c (match_partial_symbol): Change type; update.
2465         (psym_map_matching_symbols): Likewise.
2466         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2467         type; update.
2468         * symfile.h (struct quick_symbol_functions)
2469         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2470         Remove "match".
2471
2472 2019-09-10  Tom Tromey  <tromey@adacore.com>
2473
2474         * psymtab.c (map_block): Remove.
2475         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2476         * symtab.c (iterate_over_symbols_terminated): New function.
2477         * symtab.c (iterate_over_symbols_terminated): Declare.
2478
2479 2019-09-10  Tom Tromey  <tromey@adacore.com>
2480
2481         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2482         * language.h (struct language_defn) <la_iterate_over_symbols>:
2483         Return bool.
2484         * symtab.c (iterate_over_symbols): Return bool.
2485         * symtab.h (iterate_over_symbols): Return bool.
2486
2487 2019-09-10  Tom Tromey  <tromey@adacore.com>
2488
2489         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2490         (add_nonlocal_symbols): Update.
2491         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2492         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2493         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2494         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2495         Change type of "callback".  Remove "data".
2496
2497
2498 2019-09-09  Ali Tamur  <tamur@google.com>
2499
2500         * dwarf2read.c (comp_unit_head): Update comment.
2501         (dwarf2_dwo_name): New function declaration.
2502         (dwarf_unit_type_name): New function declaration.
2503         (read_comp_unit_head): Add support for new compilation units,
2504         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2505         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2506         (currently named as "signature") in their header. Also clarify error
2507         messages.
2508         (lookup_dwo_id): New function. Returns the dwo id of the given
2509         compile unit.
2510         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2511         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2512         functions.
2513         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2514         (dwarf2_dwo_name): Get the dwo name if present.
2515         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2516         purposes.
2517
2518 2019-09-09  Tom Tromey  <tom@tromey.com>
2519
2520         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2521
2522 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2523
2524         * python/python.c (do_start_initialization): Make progname_copy static,
2525         to avoid a leak report.
2526
2527 2019-09-08  Tom Tromey  <tom@tromey.com>
2528
2529         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2530
2531 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2532
2533         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2534         Change type to gdb::optional<block_enum>.
2535         (dw2_symtab_iter_init): Change block_index parameter type
2536         to gdb::optional<block_enum>.
2537         (dw2_lookup_symbol): Change block_index parameter
2538         type to block_enum.c
2539         (dw2_debug_names_lookup_symbol): Likewise.
2540         * psymtab.c (psym_lookup_symbol): Likewise.
2541         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2542         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2543         Likewise.
2544
2545 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2546
2547         * defs.h (relocate_gdb_directory): Change int to bool in
2548         signature and rename flag to relocatable.
2549         * main.c (relocate_path): Likewise.
2550         (relocate_gdb_directory): Likewise.
2551
2552 2019-09-06  Alan Modra  <amodra@gmail.com>
2553
2554         * coffread.c (coff_symfile_read): Constify filename variable.
2555         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2556         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2557         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2558         * solib.c (reload_shared_libraries_1): Likewise.
2559         * symfile.c (reread_symbols): Likewise.
2560         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2561         * solib-darwin.c (darwin_bfd_open): Likewise.
2562         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2563
2564 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2565
2566         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2567         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2568
2569 2019-09-03  Tom Tromey  <tromey@adacore.com>
2570
2571         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2572         types.
2573         (has_negatives): Unbias a range type bound.
2574         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2575         * gdbtypes.c (operator==): Handle new field.
2576         (create_range_type): Add "bias" parameter.
2577         (create_static_range_type, resolve_dynamic_range): Update.
2578         * gdbtypes.h (struct range_bounds) <bias>: New member.
2579         (create_range_type): Add bias parameter.
2580         * printcmd.c (print_scalar_formatted): Unbias range types.
2581         * value.c (unpack_long): Unbias range types.
2582         (pack_long): Bias range types.
2583
2584 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2585
2586         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2587         probe arguments.
2588
2589 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2590
2591         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2592         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2593         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2594         (compile_probe_arg): Likewise.
2595         * probe.h (get_argument_count): Likewise.
2596         * solib-svr4.c (solib_event_probe_action): Likewise.
2597         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2598
2599 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2600
2601         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2602         code to here...
2603         (svr4_create_solib_event_breakpoints): ...from here.
2604
2605 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2606
2607         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2608         suffix from warning message.
2609
2610 2019-08-30  Tom Tromey  <tom@tromey.com>
2611
2612         * tui/tui-winsource.h (struct tui_source_window_base)
2613         <refresh_all>: Don't declare.
2614         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2615         Remove.
2616         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2617         tui_show_locator_content.
2618         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2619         declare.
2620         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2621         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2622         declare.
2623
2624 2019-08-30  Tom Tromey  <tom@tromey.com>
2625
2626         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2627
2628 2019-08-30  Tom Tromey  <tom@tromey.com>
2629
2630         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2631         Remove unnecessary forward declarations.
2632
2633 2019-08-30  Tom Tromey  <tom@tromey.com>
2634
2635         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2636         rerender.
2637         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2638         tui_show_locator_content.
2639
2640 2019-08-30  Tom Tromey  <tom@tromey.com>
2641
2642         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2643         (tui_locator_window::rerender): Rewrite using body of previous
2644         tui_show_locator_content.
2645
2646 2019-08-30  Tom Tromey  <tom@tromey.com>
2647
2648         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2649         set_locator_fullname>: New methods.
2650         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2651         Rename from tui_set_locator_fullname.
2652         (tui_locator_window::set_locator_info): Rename from
2653         tui_set_locator_info.  Return bool.
2654         (tui_update_locator_fullname, tui_show_frame_info): Update.
2655
2656 2019-08-30  Tom Tromey  <tom@tromey.com>
2657
2658         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2659
2660 2019-08-30  Tom Tromey  <tom@tromey.com>
2661
2662         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2663         call touchwin.
2664
2665 2019-08-30  Tom Tromey  <tom@tromey.com>
2666
2667         * tui/tui-wingeneral.c (box_win): Assume win_info and
2668         win_info->handle cannot be NULL.
2669
2670 2019-08-30  Tom Tromey  <tom@tromey.com>
2671
2672         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2673         refresh_window>: Declare.
2674         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2675         resize.
2676         (tui_data_item_window::rerender): Rename from
2677         tui_display_register.
2678         (tui_data_item_window::refresh_window): New method.
2679         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2680         no-op.
2681
2682 2019-08-30  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2685         regs_column_count, current_group>: Move later.  Now private.
2686         <get_current_group>: New method.
2687         * tui/tui-regs.c (tui_reg_command): Update.
2688         * tui/tui-layout.c (tui_set_layout): Update.
2689
2690 2019-08-30  Tom Tromey  <tom@tromey.com>
2691
2692         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2693         (tui_data_window::rerender): Don't call
2694         check_and_display_highlight_if_needed.
2695         (tui_data_window::refresh_all): Remove call to
2696         erase_data_content.
2697
2698 2019-08-30  Tom Tromey  <tom@tromey.com>
2699
2700         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2701         (tui_data_window::display_registers_from)
2702         (tui_data_window::display_reg_element_at_line)
2703         (tui_data_window::display_registers_from_line): Remove checks of
2704         "empty".
2705
2706 2019-08-30  Tom Tromey  <tom@tromey.com>
2707
2708         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2709         Don't declare.
2710         * tui/tui-regs.c (tui_data_window::show_registers): Call
2711         rerender.
2712         (tui_data_window::rerender): Rename from display_all_data.
2713         (tui_data_window::rerender): Remove old implementation.
2714
2715 2019-08-30  Tom Tromey  <tom@tromey.com>
2716
2717         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2718         text.
2719         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2720
2721 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2722             Sergio Durigan Junior  <sergiodj@redhat.com>
2723
2724         PR win32/24284
2725         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2726
2727 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2728
2729         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2730         when searching for types.
2731
2732 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2733
2734         * f-lang.c (f_language_defn): Use f_print_typedef.
2735         * f-lang.h (f_print_typedef): Declare.
2736         * f-typeprint.c (f_print_typedef): Define.
2737
2738 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2739
2740         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2741
2742 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2743
2744         * cli/cli-utils.c (info_print_options_defs): Delete.
2745         (make_info_print_options_def_group): Delete.
2746         (extract_info_print_options): Delete.
2747         (info_print_command_completer): Delete.
2748         (info_print_args_help): Add extra parameter, and optionally
2749         include text about -n flag.
2750         * cli/cli-utils.h (struct info_print_options): Delete.
2751         (extract_info_print_options): Delete declaration.
2752         (info_print_command_completer): Delete declaration.
2753         (info_print_args_help): Add extra parameter, extend header
2754         comment.
2755         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2756         search_symbols.
2757         * stack.c (struct info_print_options): New type.
2758         (info_print_options_defs): New file scoped variable.
2759         (make_info_print_options_def_group): New static function.
2760         (info_print_command_completer): New static function.
2761         (info_locals_command): Update to use new local functions.
2762         (info_args_command): Likewise.
2763         (_initialize_stack): Add extra parameter to calls to
2764         info_print_args_help.
2765         * symtab.c (search_symbols): Add extra parameter, use this to
2766         possibly excluse non-debug symbols.
2767         (symtab_symbol_info): Add extra parameter, which is passed on to
2768         search_symbols.
2769         (struct info_print_options): New type.
2770         (info_print_options_defs): New file scoped variable.
2771         (make_info_print_options_def_group): New static function.
2772         (info_print_command_completer): New static function.
2773         (info_variables_command): Update to use local functions, and pass
2774         extra parameter through to symtab_symbol_info.
2775         (info_functions_command): Likewise.
2776         (info_types_command): Pass additional argument through to
2777         symtab_symbol_info.
2778         (rbreak_command): Pass extra argument to search_symbols.
2779         (_initialize_symtab): Add extra arguments for calls to
2780         info_print_args_help, and update help text for 'info variables',
2781         'whereis', and 'info functions' commands.
2782         * symtab.h (search_symbols): Add extra argument to declaration.
2783         * NEWS: Mention new flags.
2784
2785 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2786
2787         * symtab.c (lookup_static_symbol): Call the new function (and move
2788         it down to be next to lookup_global_symbol).
2789         (struct global_sym_lookup_data): Add block_enum member and rename to...
2790         (struct global_or_static_sym_lookup_data): ...this.
2791         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2792         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2793         (lookup_symbol_global_or_static_iterator_cb): ...this.
2794         (lookup_global_or_static_symbol): New function.
2795         (lookup_global_symbol): Call new function.
2796
2797 2019-08-26  Tom de Vries  <tdevries@suse.de>
2798
2799         PR c++/24852
2800         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2801         when pc_probe.prob == NULL.
2802
2803 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2804
2805         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2806         variable symbol_linkage to symbol_linkage_.
2807
2808 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2809
2810         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2811         represent whether the symbol is static, dynamic, or we don't
2812         know.
2813
2814 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2815
2816         * gdb/rx-tdep.c (rx_register_names): New.
2817         (rx_register_name): Delete.
2818         (rx_psw_type): Delete.
2819         (rx_fpsw_type): Delete.
2820         (rx_register_type): Delete.
2821         (rx_gdbarch_init): Convert target-descriptions.
2822         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2823         * gdb/features/Makefile: Add rx.xml.
2824         * gdb/features/rx.xml: New.
2825         * gdb/features/rx.c: Generated.
2826         * gdb/NEWS: Mention target description support.
2827
2828 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2829
2830         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2831         *slot_ptr.
2832
2833 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2834
2835         * configure.ac: Don't check for 'dlfcn.h' (moved to
2836         gdbsupport/common.m4).
2837         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2838         'gdbsupport/'.
2839         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2840         * compile/compile-c-support.c: Include
2841         'gdbsupport/gdb-dlfcn.h'.
2842         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2843         * gdb-dlfcn.c: Move to...
2844         * gdbsupport/gdb-dlfcn.c: ... here.
2845         * gdb-dlfcn.h: Move to...
2846         * gdbsupport/gdb-dlfcn.h: ... here.
2847
2848 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2849
2850         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2851         the offset field signed.
2852
2853 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2854
2855         * python/lib/gdb/__init__.py (_execute_file): New function.
2856         * python/python.c (python_run_simple_file): Call gdb._execute_file
2857         on Windows.
2858
2859 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2860
2861         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2862         all uses as this was never set to anything but a zero value.
2863
2864 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2865
2866         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2867
2868 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2869
2870         * tui/tui-data.h (tui_gen_win_info): Add an =default
2871         move constructor, required by some GCC versions.
2872
2873 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2874
2875         * go32-nat.c (go32_sysinfo): Add hygon_p.
2876
2877 2019-08-20  Tom Tromey  <tom@tromey.com>
2878
2879         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2880         line_from_reg_element_no, first_reg_element_no_inline,
2881         display_all_data, delete_data_content_windows,
2882         erase_data_content>: Now private.
2883
2884 2019-08-20  Tom Tromey  <tom@tromey.com>
2885
2886         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2887         (tui_unhighlight_win, tui_highlight_win)
2888         (tui_win_info::make_window): Update.
2889         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2890
2891 2019-08-20  Tom Tromey  <tom@tromey.com>
2892
2893         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2894         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2895         (MAX_PID_WIDTH): Move to tui-stack.c.
2896         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2897         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2898         (MAX_PID_WIDTH): Move from tui-data.h.
2899
2900 2019-08-20  Tom Tromey  <tom@tromey.com>
2901
2902         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2903         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2904         (box_win): Update.
2905         (tui_gen_win_info::make_window): Rename from tui_make_window.
2906         (tui_win_info::make_window): New method.
2907         (tui_gen_win_info::make_visible): Update.
2908         * tui/tui-source.c (tui_source_window::set_contents): Update.
2909         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2910         (tui_data_window::display_registers_from): Update.
2911         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2912         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2913         Declare.
2914         <can_box>: Remove.
2915         <title>: Remove.
2916         (struct tui_win_info) <make_window>: Declare.
2917         <can_box>: Now virtual.
2918         <title>: New member.
2919         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2920         * tui/tui-command.c (tui_cmd_window::resize): Update.
2921
2922 2019-08-20  Tom Tromey  <tom@tromey.com>
2923
2924         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2925         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2926         (tui_data_window::check_register_values): Update.
2927
2928 2019-08-20  Tom Tromey  <tom@tromey.com>
2929
2930         * tui/tui-regs.h (struct tui_data_window): Use
2931         DISABLE_COPY_AND_ASSIGN.
2932         <regs_content>: Change type, removing unique_ptr.
2933         <tui_data_window>: Add move constructor.
2934         * tui/tui-regs.c (tui_data_window::show_registers)
2935         (tui_data_window::show_register_group)
2936         (tui_data_window::display_registers_from)
2937         (tui_data_window::display_registers_from)
2938         (tui_data_window::first_data_item_displayed)
2939         (tui_data_window::delete_data_content_windows)
2940         (tui_data_window::rerender, tui_data_window::refresh_window)
2941         (tui_data_window::check_register_values): Update.
2942
2943 2019-08-20  Tom Tromey  <tom@tromey.com>
2944
2945         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2946         show_register_group>: Declare.
2947         (tui_show_register_group): Don't declare.
2948         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2949         tui_show_registers.
2950         (tui_data_window::show_register_group): Rename from
2951         tui_show_register_group.
2952         (tui_data_window::check_register_values, tui_reg_command):
2953         Update.
2954         * tui/tui-layout.c (tui_set_layout): Update.
2955
2956 2019-08-20  Tom Tromey  <tom@tromey.com>
2957
2958         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2959         Declare.
2960         (tui_check_register_values): Don't declare.
2961         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2962         from tui_check_register_values.
2963         * tui/tui-hooks.c (tui_register_changed): Update.
2964
2965 2019-08-20  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-regs.c (tui_reg_layout): Move later.
2968         (tui_show_registers): Don't enable TUI mode or change layout.
2969
2970 2019-08-20  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-regs.h (struct tui_data_item_window)
2973         <~tui_data_item_window>: Remove.
2974         <content>: Now a unique_xmalloc_ptr.
2975         * tui/tui-regs.c (tui_register_format): Return a
2976         unique_xmalloc_ptr.
2977         (tui_get_register): Update.
2978         (~tui_data_item_window): Remove.
2979         (tui_data_window::display_registers_from, tui_display_register):
2980         Update.
2981         * tui/tui-io.h (tui_expand_tabs): Update.
2982         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2983         Remove "col" parameter.
2984
2985 2019-08-20  Tom Tromey  <tom@tromey.com>
2986
2987         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2988         field.
2989         * tui/tui-regs.c (~tui_data_item_window): Update.
2990
2991 2019-08-20  Tom Tromey  <tom@tromey.com>
2992
2993         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2994         earlier.
2995
2996 2019-08-20  Tom Tromey  <tom@tromey.com>
2997
2998         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2999
3000 2019-08-20  Tom Tromey  <tom@tromey.com>
3001
3002         * tui/tui-source.h (struct tui_source_window): Update.
3003         * tui/tui-regs.c (tui_show_registers): Update.
3004         * tui/tui-disasm.h (struct tui_disasm_window): Update.
3005         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3006         (NO_REGS_STRING): Remove defines.
3007
3008 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
3009
3010         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3011         unnecessary thread walk if remote doesn't support the packet.
3012
3013 2019-08-19  Tom Tromey  <tromey@adacore.com>
3014
3015         * python/py-value.c (value_has_field): Fix indentation.
3016
3017 2019-08-19  Tom Tromey  <tromey@adacore.com>
3018
3019         * printcmd.c (do_one_display, info_display_command): Update.
3020         * block.h (contained_in): Return bool.  Add allow_nested
3021         parameter.
3022         * block.c (contained_in): Return bool.  Add allow_nested
3023         parameter.
3024
3025 2019-08-19  Tom Tromey  <tom@tromey.com>
3026
3027         * configure: Rebuild.
3028         * configure.ac: Disallow the combination of -static-libstdc++ and
3029         source highlight.
3030         * source-cache.c (get_language_name): Handle rust.
3031         (source_cache::get_source_lines): Ignore highlighting exceptions.
3032
3033 2019-08-16  Tom Tromey  <tom@tromey.com>
3034
3035         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3036         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3037         (struct tui_source_window_base) <make_visible, refresh_window,
3038         resize>: Remove methods.
3039         <execution_info>: Remove field.
3040         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3041         (tui_show_source_line, tui_source_window_base)
3042         (~tui_source_window_base): Update.
3043         (tui_source_window_base::resize)
3044         (tui_source_window_base::make_visible)
3045         (tui_source_window_base::refresh_window): Remove.
3046         (tui_source_window_base::update_exec_info): Update.
3047         * tui/tui-source.c (tui_source_window::set_contents): Update.
3048         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3049
3050 2019-08-16  Tom Tromey  <tom@tromey.com>
3051
3052         * tui/tui-hooks.c (tui_remove_hooks): Don't set
3053         deprecated_query_hook.
3054
3055 2019-08-16  Tom Tromey  <tom@tromey.com>
3056
3057         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3058         (tui_update_source_windows_with_line): Update.
3059         * tui/tui-source.h (struct tui_source_window)
3060         <show_symtab_source>: Declare.
3061         (tui_show_symtab_source): Don't declare.
3062         * tui/tui-source.c (tui_show_symtab_source): Rename from
3063         tui_show_symtab_source.
3064
3065 2019-08-16  Tom Tromey  <tom@tromey.com>
3066
3067         * tui/tui-winsource.h (struct tui_source_window_base)
3068         <set_contents>: Declare.
3069         * tui/tui-winsource.c
3070         (tui_source_window_base::update_source_window_as_is): Update.
3071         * tui/tui-source.h (struct tui_source_window) <set_contents>:
3072         Declare.
3073         (tui_set_source_content): Don't declare.
3074         * tui/tui-source.c (tui_source_window::set_contents): Rename from
3075         tui_set_source_content.
3076         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3077         Declare.
3078         (tui_set_disassem_content): Don't declare.
3079         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3080         tui_set_disassem_content.
3081
3082 2019-08-16  Tom Tromey  <tom@tromey.com>
3083
3084         * tui/tui-winsource.h (struct tui_source_window_base)
3085         <update_breakpoint_info>: Declare.
3086         (tui_update_breakpoint_info): Don't declare.
3087         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3088         (tui_update_all_breakpoint_info): Update.
3089         (tui_source_window_base::update_breakpoint_info): Rename from
3090         tui_update_breakpoint_info.
3091         (tui_source_window_base::update_exec_info): Update.
3092
3093 2019-08-16  Tom Tromey  <tom@tromey.com>
3094
3095         * tui/tui-winsource.h (struct tui_source_window_base)
3096         <update_source_window>: Declare.
3097         (tui_update_source_window): Don't declare.
3098         * tui/tui-winsource.c
3099         (tui_source_window_base::update_source_window): Rename from
3100         tui_update_source_window.
3101         (tui_source_window_base::rerender): Update.
3102         * tui/tui-source.c (tui_source_window::maybe_update): Update.
3103         * tui/tui-disasm.c (tui_show_disassem)
3104         (tui_show_disassem_and_update_source)
3105         (tui_disasm_window::maybe_update): Update.
3106
3107 2019-08-16  Tom Tromey  <tom@tromey.com>
3108
3109         * tui/tui-winsource.h (struct tui_source_window_base)
3110         <update_source_window_as_is>: Declare.
3111         (tui_update_source_window_as_is): Don't declare.
3112         * tui/tui-winsource.c (tui_update_source_window): Update
3113         (tui_source_window_base::update_source_window_as_is): Rename from
3114         tui_update_source_window_as_is.
3115         (tui_source_window_base::refill): Update.
3116         * tui/tui-source.c (tui_show_symtab_source): Update.
3117         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3118         Update.
3119
3120 2019-08-16  Tom Tromey  <tom@tromey.com>
3121
3122         * tui/tui-winsource.h (tui_update_source_window)
3123         (tui_update_source_window_as_is): Remove "noerror" parameter.
3124         * tui/tui-winsource.c (tui_update_source_window)
3125         (tui_update_source_window_as_is): Remove "noerror" parameter.
3126         (tui_update_source_windows_with_addr)
3127         (tui_update_source_windows_with_line)
3128         (tui_source_window_base::rerender)
3129         (tui_source_window_base::refill): Update.
3130         * tui/tui-source.h (tui_set_source_content)
3131         (tui_show_symtab_source): Remove "noerror" parameter.
3132         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3133         parameter.
3134         (tui_show_symtab_source): Likewise.
3135         (tui_source_window::maybe_update): Update.
3136         * tui/tui-disasm.c (tui_show_disassem)
3137         (tui_show_disassem_and_update_source)
3138         (tui_disasm_window::do_scroll_vertical)
3139         (tui_disasm_window::maybe_update): Update.
3140
3141 2019-08-16  Tom Tromey  <tom@tromey.com>
3142
3143         * tui/tui.c (tui_is_window_visible): Update.
3144         * tui/tui-wingeneral.c (tui_make_window)
3145         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3146         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3147         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3148         (tui_set_win_height_command, parse_scrolling_args): Update.
3149         * tui/tui-source.c (tui_source_window::style_changed): Update.
3150         * tui/tui-regs.c (tui_show_registers)
3151         (tui_data_window::first_data_item_displayed)
3152         (tui_data_window::delete_data_content_windows)
3153         (tui_check_register_values, tui_reg_command): Update.
3154         * tui/tui-disasm.c (tui_show_disassem): Update.
3155         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3156         method.
3157         <is_visible>: Remove field.
3158         * tui/tui-data.c (tui_next_win, tui_prev_win)
3159         (tui_delete_invisible_windows): Update.
3160
3161 2019-08-16  Tom Tromey  <tom@tromey.com>
3162
3163         * tui/tui-winsource.h (struct tui_source_window_base)
3164         <m_has_locator>: Remove.
3165         * tui/tui-layout.c (show_source_disasm_command, show_data)
3166         (show_source_or_disasm_and_command): Update.
3167
3168 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
3169
3170         * NEWS (Other MI changes): New subsection.
3171         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3172         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3173         * arch-utils.c (default_get_pc_address_flags): New function.
3174         * arch-utils.h (default_get_pc_address_flags): New declaration.
3175         * gdbarch.sh: Add get_pc_address_flags.
3176         * gdbarch.c: Regenerate.
3177         * gdbarch.h: Likewise.
3178         * stack.c (print_pc): New function.
3179         (print_frame_info) (print_frame): Call print_pc.
3180
3181 2019-08-16  Tom de Vries  <tdevries@suse.de>
3182
3183         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3184         print_objfile_section_info.
3185
3186 2019-08-15  Tom Tromey  <tom@tromey.com>
3187
3188         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3189         calling update_cmdwin_start_line.
3190         * tui/tui-winsource.h (struct tui_source_window_base)
3191         <do_make_visible_with_new_height, set_new_height>: Don't declare.
3192         <rerender>: Declare.
3193         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3194         Call rerender.
3195         (tui_source_window_base::set_new_height): Remove.
3196         (tui_source_window_base::rerender): Rename from
3197         do_make_visible_with_new_height.
3198         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3199         resize method.
3200         (tui_win_info::make_invisible_and_set_new_height)
3201         (tui_win_info::make_visible_with_new_height): Remove.
3202         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3203         Declare.
3204         * tui/tui-stack.c (tui_locator_window::rerender): New method.
3205         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3206         do_make_visible_with_new_height>: Don't declare.
3207         <rerender>: Declare.
3208         * tui/tui-regs.c (tui_data_window::rerender): Rename from
3209         set_new_height.
3210         (tui_data_window::do_make_visible_with_new_height): Remove.
3211         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3212         call tui_show_locator_content.
3213         (tui_gen_win_info::resize): Call rerender.
3214         (show_source_or_disasm_and_command): Don't call
3215         tui_show_locator_content.
3216         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3217         method.
3218         (struct tui_win_info) <rerender>: Declare.
3219         <set_new_height, make_invisible_and_set_new_height,
3220         make_visible_with_new_height>: Don't declare.
3221         * tui/tui-data.c (tui_win_list::rerender): New method.
3222         * tui/tui-command.h (struct tui_cmd_window)
3223         <do_make_visible_with_new_height>: Don't declare.
3224         * tui/tui-command.c
3225         (tui_cmd_window::do_make_visible_with_new_height): Remove.
3226
3227 2019-08-15  Tom Tromey  <tromey@adacore.com>
3228
3229         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
3230         * ada-lang.c (ada_enum_name): Likewise.
3231
3232 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
3233
3234         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
3235         leading underscore.
3236         (GdbOutputErrorFile): Likewise.
3237         (global scope): Adjust constructor calls to GdbOutput{,Error}File
3238         accordingly.
3239         (execute_unwinders): Rename to have a leading underscore.
3240         (auto_load_packages): Likewise.
3241         (global scope): Adjust call to auto_load_packages accordingly.
3242         (GdbSetPythonDirectory): Likewise.
3243         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
3244         instead of execute_unwinders.
3245
3246 2019-08-15  Tom Tromey  <tom@tromey.com>
3247
3248         * tui/tui-layout.c (show_layout, show_source_disasm_command)
3249         (show_data): Don't change window visibility.
3250         (tui_gen_win_info::resize): Remove special case for command
3251         window.  Use wresize, when available.
3252         (show_source_or_disasm_and_command): Don't change window
3253         visibility.
3254         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
3255         <make_visible>: New method.
3256         * tui/tui-command.c (tui_cmd_window::resize): New method.
3257
3258 2019-08-15  Tom Tromey  <tom@tromey.com>
3259
3260         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
3261         (struct tui_source_windows): New.
3262         * tui/tui-winsource.c (tui_display_main): Update.
3263         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3264         (new_height_ok, parse_scrolling_args): Update.
3265         * tui/tui-layout.c (show_layout, show_data): Update.
3266         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
3267         (tui_add_to_source_windows): Don't declare.
3268         * tui/tui-data.c (source_windows, tui_source_windows)
3269         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
3270
3271 2019-08-15  Tom Tromey  <tom@tromey.com>
3272
3273         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
3274         Rename from reset.
3275         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
3276         * tui/tui-layout.c (show_source_disasm_command, show_data):
3277         Update.
3278         (tui_gen_win_info::resize): Rename.
3279         (show_source_or_disasm_and_command): Update.
3280         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
3281         reset.
3282
3283 2019-08-15  Tom Tromey  <tom@tromey.com>
3284
3285         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3286         * tui/tui-interp.c (tui_interp::init): Don't call
3287         tui_initialize_static_data.
3288         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3289
3290 2019-08-15  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3293         examine tui_win_list.
3294
3295 2019-08-15  Tom Tromey  <tom@tromey.com>
3296
3297         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3298         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3299         tui_clear_source_content.
3300         (tui_clear_source_content): Remove.
3301         (tui_source_window_base::do_erase_source_content): Hoist call to
3302         content.clear().
3303         * tui/tui-stack.c (tui_show_frame_info): Don't call
3304         tui_clear_source_content.
3305
3306 2019-08-15  Tom Tromey  <tom@tromey.com>
3307
3308         * tui/tui-winsource.h (struct tui_source_window_base)
3309         <do_erase_source_content>: New method.
3310         <erase_source_content>: New method.
3311         (tui_erase_source_content): Don't declare.
3312         * tui/tui-winsource.c (tui_clear_source_content): Update.
3313         (tui_source_window_base::do_erase_source_content): Rename from
3314         tui_erase_source_content.
3315         (tui_source_window_base::show_source_content): Update.
3316         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3317         * tui/tui-source.h (struct tui_source_window)
3318         <erase_source_content>: New method.
3319         * tui/tui-disasm.h (struct tui_disasm_window)
3320         <erase_source_content>: New method.
3321
3322 2019-08-15  Tom Tromey  <tom@tromey.com>
3323
3324         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3325         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3326         constructor.
3327         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3328         * tui/tui-source.c (tui_set_source_content): Update.
3329         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3330
3331 2019-08-15  Tom Tromey  <tom@tromey.com>
3332
3333         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3334         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3335         tui-source.c.
3336         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3337         Declare.
3338         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3339         method.
3340         (tui_source_window::maybe_update): Update.
3341
3342 2019-08-15  Tom Tromey  <tom@tromey.com>
3343
3344         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3345         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3346         tui-disasm.c.
3347         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3348         Declare.
3349         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3350         method.
3351         (tui_disasm_window::maybe_update): Update.
3352
3353 2019-08-15  Tom Tromey  <tom@tromey.com>
3354
3355         * tui/tui-winsource.h (struct tui_source_window_base)
3356         <maybe_update>: Declare.
3357         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3358         method.
3359         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3360         Declare.
3361         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3362         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3363         Declare.
3364         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3365
3366 2019-08-15  Tom Tromey  <tom@tromey.com>
3367
3368         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3369
3370 2019-08-15  Tom Tromey  <tom@tromey.com>
3371
3372         * tui/tui-wingeneral.c: Include tui-stack.h.
3373         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3374         (struct tui_locator_window): Move from tui-data.h.
3375         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3376         (tui_initialize_static_data): Move from tui-data.c.
3377         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3378         (struct tui_locator_window): Move to tui-stack.c.
3379         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3380         (tui_initialize_static_data): Move to tui-stack.c.
3381
3382 2019-08-15  Tom Tromey  <tom@tromey.com>
3383
3384         * tui/tui-layout.c (show_source_disasm_command)
3385         (show_source_or_disasm_and_command): Use make_visible method, not
3386         tui_make_window.
3387         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3388         Remove.
3389
3390 2019-08-15  Tom Tromey  <tom@tromey.com>
3391
3392         * tui/tui-wingeneral.h (tui_make_window): Update.
3393         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3394         parameter.
3395         (tui_gen_win_info::make_visible): Update.
3396         * tui/tui-regs.c (tui_data_window::display_registers_from):
3397         Update.
3398         * tui/tui-layout.c (show_source_disasm_command)
3399         (show_source_or_disasm_and_command): Update.
3400         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3401         (enum tui_box): Remove.
3402         (struct tui_win_info) <can_box>: New method.
3403         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3404         method.
3405
3406 2019-08-15  Tom de Vries  <tdevries@suse.de>
3407
3408         * linux-nat-trad.c: Include gdbarch.h.
3409
3410 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3411
3412         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3413         register sizes.
3414
3415 2019-08-14  Tom Tromey  <tromey@adacore.com>
3416
3417         * darwin-nat.c: Include gdbarch.h.
3418         * darwin-nat-info.c: Include gdbarch.h.
3419
3420 2019-08-13  Tom Tromey  <tom@tromey.com>
3421
3422         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3423         Remove.
3424         * tui/tui-data.c (tui_initialize_static_data): Update.
3425
3426 2019-08-13  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-winsource.h (struct tui_exec_info_window)
3429         <~tui_exec_info_window, maybe_allocate_content, get_content,
3430         m_content>: Remove.
3431         (struct tui_source_window_base) <set_exec_info_content,
3432         show_exec_info_content>: Don't declare.
3433         * tui/tui-winsource.c
3434         (tui_exec_info_window::maybe_allocate_content): Remove.
3435         (tui_source_window_base::update_exec_info): Rename from
3436         set_exec_info_content.
3437         (tui_source_window_base::show_exec_info_content)
3438         (tui_source_window_base::update_exec_info): Remove.
3439
3440 2019-08-13  Tom Tromey  <tom@tromey.com>
3441
3442         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3443         declare.
3444         * tui/tui-winsource.c (tui_update_source_window_as_is)
3445         (tui_update_source_windows_with_addr, tui_erase_source_content):
3446         Update.
3447         (tui_clear_exec_info_content): Remove.
3448
3449 2019-08-13  Tom Tromey  <tom@tromey.com>
3450
3451         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3452         declare.
3453         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3454         call tui_erase_exec_info_content.
3455         (tui_clear_exec_info_content): Rename from
3456         tui_erase_exec_info_content.
3457         (tui_clear_exec_info_content): Delete.
3458
3459 2019-08-13  Tom Tromey  <tom@tromey.com>
3460
3461         * tui/tui-winsource.h (struct tui_source_window_base)
3462         <show_exec_info_content>: Declare.
3463         (tui_show_exec_info_content): Don't declare.
3464         * tui/tui-winsource.c
3465         (tui_source_window_base::show_exec_info_content): Rename from
3466         tui_show_exec_info_content.
3467         (tui_source_window_base::update_exec_info): Update.
3468
3469 2019-08-13  Tom Tromey  <tom@tromey.com>
3470
3471         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3472         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3473         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3474         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3475         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3476         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3477         ... here.
3478
3479 2019-08-13  Tom Tromey  <tom@tromey.com>
3480
3481         * tui/tui-winsource.h (struct tui_source_window_base)
3482         <update_exec_info>: Declare.
3483         (tui_update_exec_info): Don't declare.
3484         * tui/tui-winsource.c (tui_update_source_window_as_is)
3485         (tui_source_window_base::refresh_all)
3486         (tui_update_all_breakpoint_info): Update.
3487         (tui_source_window_base::update_exec_info): Rename from
3488         tui_update_exec_info.
3489         * tui/tui-stack.c (tui_show_frame_info): Update.
3490
3491 2019-08-13  Tom Tromey  <tom@tromey.com>
3492
3493         * tui/tui-winsource.h (struct tui_source_window_base)
3494         <set_exec_info_content>: Declare.
3495         (tui_set_exec_info_content): Don't declare.
3496         * tui/tui-winsource.c
3497         (tui_source_window_base::set_exec_info_content): Rename from
3498         tui_set_exec_info_content.
3499         (tui_update_exec_info): Update.
3500
3501 2019-08-13  Tom Tromey  <tom@tromey.com>
3502
3503         * tui/tui-winsource.h (struct tui_source_window_base)
3504         <show_source_content>: Declare.
3505         (tui_show_source_content): Don't declare.
3506         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3507         (tui_source_window_base::show_source_content): Rename from
3508         tui_show_source_content.
3509         (tui_source_window_base::refresh_all): Update.
3510         * tui/tui-layout.c (show_source_disasm_command)
3511         (show_source_or_disasm_and_command): Update.
3512
3513 2019-08-13  Tom Tromey  <tom@tromey.com>
3514
3515         * tui/tui-winsource.c (tui_erase_source_content)
3516         (tui_show_source_content, tui_source_window_base::refresh_all):
3517         Update.
3518         * tui/tui-wingeneral.h
3519         (tui_check_and_display_highlight_if_needed): Don't declare.
3520         * tui/tui-wingeneral.c
3521         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3522         check_and_display_highlight_if_needed.
3523         * tui/tui-win.c (tui_rehighlight_all)
3524         (tui_win_info::make_visible_with_new_height): Update.
3525         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3526         (tui_data_window::erase_data_content)
3527         (tui_data_window::display_all_data): Update.
3528         * tui/tui-data.h (struct tui_win_info)
3529         <check_and_display_highlight_if_needed>: Declare.
3530
3531 2019-08-13  Tom Tromey  <tom@tromey.com>
3532
3533         * tui/tui-win.c (tui_resize_all): Call
3534         tui_delete_invisible_windows.
3535         * tui/tui-layout.c (show_layout): Call
3536         tui_delete_invisible_windows.
3537         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3538         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3539
3540 2019-08-13  Tom Tromey  <tom@tromey.com>
3541
3542         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3543         tui_add_win_to_layout.
3544
3545 2019-08-13  Tom Tromey  <tom@tromey.com>
3546
3547         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3548         * tui/tui-layout.c (tui_default_win_height): Now static.
3549
3550 2019-08-13  Tom Tromey  <tom@tromey.com>
3551
3552         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3553         single switch.
3554         (show_source_disasm_command, show_source_or_disasm_and_command):
3555         Don't check current layout.
3556
3557 2019-08-13  Tom Tromey  <tom@tromey.com>
3558
3559         * tui/tui-wingeneral.c (make_all_visible): Remove.
3560         (tui_make_all_invisible): Simplify.
3561         * tui/tui-layout.c (tui_make_all_invisible): Move from
3562         tui-wingeneral.c; simplify.
3563         (show_layout): Hoist call to tui_make_all_invisible.
3564         (show_data): Don't call tui_make_all_invisible.
3565
3566 2019-08-13  Tom Tromey  <tom@tromey.com>
3567
3568         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3569         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3570
3571 2019-08-13  Tom Tromey  <tom@tromey.com>
3572
3573         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3574         tui-data.c.
3575         (show_source_disasm_command, show_data)
3576         (show_source_or_disasm_and_command): Don't use
3577         tui_set_current_layout_to.
3578         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3579         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3580         tui-layout.c.
3581         (tui_set_current_layout_to): Remove.
3582
3583 2019-08-13  Tom Tromey  <tom@tromey.com>
3584
3585         * tui/tui-layout.c (tui_set_layout): Update.
3586         * tui/tui-data.h (struct tui_layout_def): Remove.
3587         (tui_layout_def): Don't declare.
3588         * tui/tui-data.c (layout_def): Remove.
3589         (tui_layout_def): Remove.
3590
3591 2019-08-13  Tom Tromey  <tom@tromey.com>
3592
3593         * tui/tui-winsource.h (struct tui_source_window_base)
3594         <clear_detail>: No longer "override".
3595         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3596         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3597         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3598         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3599         Remove.
3600         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3601
3602 2019-08-13  Tom Tromey  <tromey@adacore.com>
3603
3604         * tracepoint.c: Don't include readline.h or history.h.
3605
3606 2019-08-12  Tom Tromey  <tom@tromey.com>
3607
3608         * configure: Rebuild.
3609         * configure.ac: Check for readline 7.
3610         * NEWS: Mention readline 7 requirement.
3611         * README: Update.
3612
3613 2019-08-12  Tom Tromey  <tom@tromey.com>
3614
3615         * mingw-hdep.c (gdb_select): Remove readline hack.
3616
3617 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3618
3619         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3620         when the function fails.
3621
3622 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3623
3624         * s390-tdep.c (s390_type_align): New function.
3625         (s390_gdbarch_init): Set it as type_align gdbarch method.
3626
3627 2019-08-09  Tom de Vries  <tdevries@suse.de>
3628
3629         PR gdb/24591
3630         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3631         pc_low with relocation offset.
3632
3633 2019-08-07  Tom Tromey  <tromey@adacore.com>
3634
3635         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3636         (print_frame_args): Update.
3637         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3638         Update.
3639         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3640         * frame.h (struct frame_arg): Add initializers.
3641         <error>: Now a unique_xmalloc_ptr.
3642
3643 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3644
3645         * NEWS: Expand the Pointer Authentication entry.
3646         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3647         (aarch64_frame_unmask_lr): ... to this.
3648         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3649         Call aarch64_frame_unmask_lr.
3650         * frame.c (struct frame_info): Add "masked" variable.
3651         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3652         (fprint_frame): Check for masked pc.
3653         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3654         declarations.
3655         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3656         * stack.c (print_frame): Check for masked pc.
3657
3658 2019-08-06  Tom Tromey  <tom@tromey.com>
3659
3660         * stabsread.c (patch_block_stabs, read_one_struct_field)
3661         (read_enum_type): Use obstack_strndup.
3662         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3663         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3664         * dwarf2read.c (guess_full_die_structure_name)
3665         (anonymous_struct_prefix): Use obstack_strndup.
3666         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3667         * c-exp.y (yylex): Use obstack_strndup.
3668         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3669         (write_var_or_type): Use obstack_strndup.
3670
3671 2019-08-06  Tom Tromey  <tom@tromey.com>
3672
3673         * symfile.c (reread_symbols): Use obstack_strdup.
3674         * stabsread.c (read_type): Use obstack_strdup.
3675         * gdb_obstack.h (obstack_strdup): New overload.
3676         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3677         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3678         (dwarf2_canonicalize_name): Use obstack_strdup.
3679         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3680         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3681         Use obstack_strdup.
3682
3683 2019-08-06  Tom Tromey  <tom@tromey.com>
3684
3685         * gdb_obstack.h (obstack_strdup): Define.
3686         * gdb_obstack.c (obstack_strdup): Don't define.
3687
3688 2019-08-06  Tom Tromey  <tom@tromey.com>
3689
3690         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3691         obstack_strdup.
3692         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3693         obstack_strdup.
3694         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3695         * stabsread.c (common_block_start): Use obstack_strdup.
3696         * objfiles.c (set_objfile_main_name, objfile): Use
3697         obstack_strdup.
3698         * namespace.c (add_using_directive): Use obstack_strdup.
3699         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3700         * jit.c (finalize_symtab): Use obstack_strdup.
3701         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3702         (guess_partial_die_structure_name, partial_die_info::fixup)
3703         (dwarf2_name): Use obstack_strdup.
3704         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3705         obstack_strdup.
3706         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3707         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3708         obstack_strdup.
3709         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3710
3711 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3712
3713         * unittests/help-doc-selftests.c: New file.
3714         * Makefile.in: Add the new file.
3715
3716 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3717
3718         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3719         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3720         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3721         the trailing '.' is not output, and the first character is uppercased.
3722         (print_help_for_command): Update call to print_doc_line.
3723         (print_doc_of_command): Likewise.
3724         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3725         * cli/cli-option.c (append_indented_doc): Do not append newline.
3726         (build_help_option): Append newline after first appended_indented_doc
3727         only if a second call is done.
3728         (build_help): Append 2 new lines before each option, except the first
3729         one.
3730         * compile/compile.c (_initialize_compile): Add new lines after
3731         %OPTIONS%, when not at the end of the help.
3732         Change help doc or code
3733         producing the help doc to respect the invariants.
3734         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3735         Also removed the new line after 'Options:', as all other commands
3736         do not put an empty line between 'Options:' and the first option.
3737         * printcmd.c (_initialize_printcmd): Likewise.
3738         * stack.c (_initialize_stack): Likewise.
3739         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3740         incorrectly telling COMMAND is optional.
3741         * ada-lang.c (_initialize_ada_language): Change help doc or code
3742         producing the help doc to respect the invariants.
3743         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3744         * breakpoint.c (_initialize_breakpoint): Likewise.
3745         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3746         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3747         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3748         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3749         _initialize_cli_style): Likewise.
3750         * corelow.c (core_target_info): Likewise.
3751         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3752         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3753         * filesystem.c (_initialize_filesystem): Likewise.
3754         * frame.c (_initialize_frame): Likewise.
3755         * gnu-nat.c (add_task_commands): Likewise.
3756         * infcall.c (_initialize_infcall): Likewise.
3757         * infcmd.c (_initialize_infcmd): Likewise.
3758         * interps.c (_initialize_interpreter): Likewise.
3759         * language.c (_initialize_language): Likewise.
3760         * linux-fork.c (_initialize_linux_fork): Likewise.
3761         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3762         * maint.c (_initialize_maint_cmds): Likewise.
3763         * memattr.c (_initialize_mem): Likewise.
3764         * printcmd.c (_initialize_printcmd): Likewise.
3765         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3766         _RegEx): Likewise.
3767         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3768         * record-btrace.c (_initialize_record_btrace): Likewise.
3769         * record-full.c (_initialize_record_full): Likewise.
3770         * record.c (_initialize_record): Likewise.
3771         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3772         * regcache.c (_initialize_regcache): Likewise.
3773         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3774         _initialize_remote): Likewise.
3775         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3776         * serial.c (_initialize_serial): Likewise.
3777         * skip.c (_initialize_step_skip): Likewise.
3778         * source.c (_initialize_source): Likewise.
3779         * stack.c (_initialize_stack): Likewise.
3780         * symfile.c (_initialize_symfile): Likewise.
3781         * symtab.c (_initialize_symtab): Likewise.
3782         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3783         * top.c (init_main): Likewise.
3784         * tracefile-tfile.c (tfile_target_info): Likewise.
3785         * tracepoint.c (_initialize_tracepoint): Likewise.
3786         * tui/tui-win.c (_initialize_tui_win): Likewise.
3787         * utils.c (add_internal_problem_command): Likewise.
3788         * valprint.c (value_print_option_defs): Likewise.
3789
3790 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3791
3792         PR build/24886
3793         * configure.ac: Drop enable-libmcheck support.
3794         * configure, config.in: Rebuild.
3795         * libmcheck.m4: Remove.
3796         * acinclude.m4: Don't include it.
3797         * Makefile.in: Don't distribute it.
3798         * top.c (print_gdb_configuration): Don't mention it.
3799
3800 2019-08-06  Tom Tromey  <tom@tromey.com>
3801
3802         * utils.c (set_output_style): Sometimes pass stream to
3803         emit_style_escape.
3804         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3805         * record-btrace.c (btrace_insn_history): Update.
3806         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3807         method.
3808         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3809         Update initializers.
3810         <m_uiout>: New field.
3811         <m_di>: Move lower.
3812         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3813         Remove "uiout" parameter.
3814         (dump_insns): Update.
3815         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3816         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3817
3818 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3819
3820         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3821         (error_in_psymtab_expansion): Likewise.
3822         (lookup_symbol_via_quick_fns): Likewise.
3823         (basic_lookup_transparent_type_quick): Likewise.
3824         (basic_lookup_transparent_type_1): Likewise.
3825
3826 2019-08-06  Tom Tromey  <tromey@adacore.com>
3827
3828         * source.c (last_source_error): Now bool.
3829         (print_source_lines_base): Make "noprint" bool.  Only open
3830         source file when last_source_visited changes.
3831
3832 2019-08-06  Tom Tromey  <tromey@adacore.com>
3833
3834         * annotate.c (annotate_source_line): Use g_source_cache.
3835         * source-cache.c (source_cache::get_plain_source_lines): Change
3836         parameters.  Populate m_offset_cache.
3837         (source_cache::ensure): New method.
3838         (source_cache::get_line_charpos): New method.
3839         (extract_lines): Move lower.  Change parameters.
3840         (source_cache::get_source_lines): Move lower.
3841         * source-cache.h (class source_cache): Update comment.
3842         <get_line_charpos>: New method.
3843         <get_source_lines>: Update comment.
3844         <clear>: Clear m_offset_cache.
3845         <get_plain_source_lines>: Change parameters.
3846         <ensure>: New method
3847         <m_offset_cache>: New member.
3848         * source.c (forget_cached_source_info_for_objfile): Update.
3849         (info_source_command): Use g_source_cache.
3850         (find_source_lines, open_source_file_with_line_charpos): Remove.
3851         (print_source_lines_base, search_command_helper): Use g_source_cache.
3852         * source.h (open_source_file_with_line_charpos): Don't declare.
3853         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3854         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3855         Use g_source_cache.
3856
3857 2019-08-06  Tom Tromey  <tromey@adacore.com>
3858
3859         * source-cache.c (source_cache::get_plain_source_lines):
3860         Remove "first_line" and "last_line" parameters.
3861         (source_cache::get_source_lines): Cache plain text.
3862         * source-cache.h (class source_cache)
3863         <get_plain_source_lines>: Update.
3864
3865 2019-08-06  Tom Tromey  <tromey@adacore.com>
3866
3867         * source-cache.c (extract_lines): No longer a method.
3868         Changed type of parameter.  Include final newline.
3869         (selftests::extract_lines_test): New function.
3870         (_initialize_source_cache): Likewise.
3871         * source-cache.h (class source_cache)
3872         <extract_lines>: Don't declare.
3873
3874 2019-08-06  Tom Tromey  <tromey@adacore.com>
3875
3876         * breakpoint.c (init_breakpoint_sal): Update.
3877         (breakpoint): Update.
3878         * breakpoint.h (struct breakpoint) <filter>: Now a
3879         unique_xmalloc_ptr.
3880
3881 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3882
3883         * NEWS: Mention dictionary access on blocks.
3884         * python/py-block.c (blpy_getitem): New function.
3885         (block_object_as_mapping): New struct.
3886         (block_object_type): Use new struct for tp_as_mapping field.
3887
3888 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3889
3890         * objfiles.h (objfile): Add a comment describing partial symbols.
3891
3892 2019-08-05  Tom Tromey  <tromey@adacore.com>
3893
3894         * compile/compile.c (_initialize_compile): Use _(), not N_().
3895         * thread.c (_initialize_thread): Use _(), not N_().
3896         * stack.c (_initialize_stack): Use _(), not N_().
3897         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3898
3899 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3900
3901         * dwarf2read.c (struct dw2_symtab_iterator):
3902         <want_specific_block>: Remove.
3903         <block_index>: Change type to gdb::optional.
3904         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3905         change type of BLOCK_INDEX parameter to gdb::optional.
3906         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3907         (dw2_lookup_symbol): Don't pass argument for
3908         WANT_SPECIFIC_BLOCK.
3909         (dw2_expand_symtabs_for_function): Don't pass argument for
3910         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3911         (class dw2_debug_names_iterator)
3912         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3913         parameter, change BLOCK_INDEX type to gdb::optional.
3914         <m_want_specific_block>: Remove.
3915         <m_block_index>: Change type to gdb::optional.
3916         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3917         gdb::optional.  Re-write in function of gdb::optional.
3918         (dw2_debug_names_lookup_symbol): Don't pass argument for
3919         WANT_SPECIFIC_BLOCK.
3920         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3921         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3922         BLOCK_INDEX.
3923
3924 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3925
3926         * NEWS: Mention changes to "info sources" command.
3927
3928 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3929
3930         * symtab.c (filename_partial_match_opts): New struct type.
3931         (struct output_source_filename_data): New members
3932         regexp, c_regexp, partial_match.
3933         (output_source_filename): Use new members to decide to print file.
3934         (info_sources_option_defs): New variable.
3935         (make_info_sources_options_def_group, print_info_sources_header,
3936         info_sources_command_completer):
3937         New functions.
3938         (info_sources_command): Read new optional arguments.
3939         (_initialize_symtab): Update info sources help.
3940
3941 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3942
3943         * ada-lang.c (exception_support_info_v0): Renamed from...
3944         (default_exception_support_info): ... this.  Create new
3945         definition for v1.
3946         (ada_has_this_exception_support): Look up catch_handlers_sym.
3947         (ada_exception_support_info_sniffer): Try v0 after default.
3948
3949 2019-08-01  Tom Tromey  <tromey@adacore.com>
3950
3951         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3952         gdbarch.h.
3953
3954 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3955
3956         * s12z-tdep.c: Fix include path for s12z-opc.h.
3957
3958 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3959
3960         * NEWS: Require GNU make 3.82.
3961
3962 2019-07-16  Tom Tromey  <tom@tromey.com>
3963
3964         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3965         declare.
3966
3967 2019-07-30  Tom Tromey  <tromey@adacore.com>
3968
3969         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3970
3971 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3972
3973         * printcmd.c (print_address_symbolic): Print negative offsets.
3974         (build_address_symbolic): Force signed arithmetic when computing
3975         offset.
3976
3977 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3978
3979         PR/24474: Add a function to lookup static variables.
3980         * NEWS: Mention this new function.
3981         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3982         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3983         * python/python.c (python_GdbMethods): Add new function.
3984
3985 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3986
3987         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3988         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3989         (objfpy_lookup_static_symbol): New function.
3990         (objfile_object_methods): Add new functions.
3991
3992 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3993
3994         * NEWS: Mention 'set|show print frame-info'.  Mention new
3995         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3996         backtrace argument.  Mention that python frame filtering code
3997         is now consistent with what 'backtrace' command prints.
3998
3999 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4000
4001         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4002         comments.
4003         (print_frame_info_auto, print_frame_info_source_line,
4004         print_frame_info_location, print_frame_info_source_and_location,
4005         print_frame_info_location_and_address, print_frame_info_short_location):
4006         New declarations.
4007         (struct frame_print_options): New member print_frame_info.
4008         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4009         * stack.h (get_user_print_what_frame_info): New declaration.
4010         (frame_show_address): New declaration.
4011         * stack.c (print_frame_arguments_choices): New value 'presence'.
4012         (print_frame_info_auto, print_frame_info_source_line,
4013         print_frame_info_location, print_frame_info_source_and_location,
4014         print_frame_info_location_and_address, print_frame_info_short_location,
4015         print_frame_info_choices, print_frame_info_print_what): New definitions.
4016         (print_frame_args): Only print dots for args if print frame-arguments
4017         is 'presence'.
4018         (frame_print_option_defs): New element for "frame-info".
4019         (get_user_print_what_frame_info): New function.
4020         (frame_show_address): Make non static.  Move comment to stack.h.
4021         (print_frame_info_to_print_what): New function.
4022         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
4023         to decide what to print.
4024         (backtrace_command_1): Handle the new print_frame_arguments_presence
4025         value.
4026         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4027         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4028         (py_print_frame): In non-mi mode, use LOCATION as default for
4029         print_what, similarly to frame information printed directly by
4030         backtrace command. Handle frame-info user option in non MI mode.
4031
4032 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4033
4034         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4035         Add case for debugging 32-bit target on 64-bit host.  Revise
4036         comment.
4037
4038 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4039
4040         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4041         instead of find_function_entry_range_from_pc.
4042
4043 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
4044
4045         * stack.c (find_frame_funname): Remove code which preferred
4046         minsym over symtab sym in "certain pathological cases".
4047
4048         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4049         parameter.  Change type of "do_demangle" to bool.
4050         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4051         Pass suitable "prefer_sym_over_minsym" flag to
4052         build_address_symbolic().  Don't output "+" for negative offsets.
4053         * printcmd.c (print_address_symbolic): Update invocation of
4054         build_address_symbolic to include a "prefer_sym_over_minsym"
4055         flag.
4056         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4057         Restrict cases in which use of minimal symbol is preferred to that
4058         of a found symbol.  Update comments.
4059
4060         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4061         for entry pc when entry pc is out of range for that FDE.
4062
4063 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
4064
4065         PR gdb/24839:
4066         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4067         type.
4068
4069 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
4070
4071         * python/py-objfile.c (add_separate_debug_file): Fix comment about
4072         this function's Python signature.
4073
4074
4075 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
4076
4077         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4078         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4079         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4080         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4081         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4082
4083
4084 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
4085
4086         * h8300-tdep.c (h8300_register_name_common): New.
4087         h8300_register_name): Use h8300_register_name_common.
4088         (h8300s_register_name): Likewise.
4089         (h8300sx_register_name): Likewise.
4090         (h8300h_register_nam): New.
4091         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4092
4093
4094 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
4095
4096         * arm-tdep.c (arm_skip_cmse_entry): New function.
4097         (arm_is_sgstubs_section): New function.
4098         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4099
4100 2019-07-22  Tom Tromey  <tom@tromey.com>
4101
4102         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4103         Don't self-assign.
4104
4105 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4106
4107         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4108         type_print.
4109
4110 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4111
4112         * symtab.c (search_symbols): Adjust msymbol matching type arrays
4113         so that GDB doesn't match any msymbols when searching in the
4114         TYPES_DOMAIN.
4115         (print_symbol_info): Print using typedef_print or type_print based
4116         on the type of the symbol.  Add updated FIXME comment moved from...
4117         (_initialize_symtab): ... move and update FIXME comment to above.
4118
4119 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4120
4121         * NEWS: Mention adding -q option to "info types".
4122         * symtab.c (struct info_types_options): New struct.
4123         (info_types_options_defs): New variable.
4124         (make_info_types_options_def_group): New function.
4125         (info_types_command): Use gdb::option framework to parse options.
4126         (info_types_command_completer): New function.
4127         (_initialize_symtab): Extend the help text on "info types" and
4128         register command completer.
4129
4130 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
4131
4132         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4133         (lookup_symbol_in_objfile): Change int to block_enum and add a
4134         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4135
4136 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
4137
4138         * MAINTAINERS (Write After Approval): Add self.
4139
4140 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4141
4142         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4143         instruction to the dummy code region.
4144
4145 2019-07-19  Tom Tromey  <tromey@adacore.com>
4146
4147         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4148         (ARGSUSED, PARAMS, __func__): Remove rules.
4149
4150 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4151
4152         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4153         * features/arm/arm-with-iwmmxt.c: Remove.
4154         * features/arm/arm-with-iwmmxt.xml: Remove.
4155         * features/arm/arm-with-m-fpa-layout.c: Remove.
4156         * features/arm/arm-with-m-fpa-layout.xml: Remove.
4157         * features/arm/arm-with-m-vfp-d16.c: Remove.
4158         * features/arm/arm-with-m-vfp-d16.xml: Remove.
4159         * features/arm/arm-with-m.c: Remove.
4160         * features/arm/arm-with-m.xml: Remove.
4161         * features/arm/arm-with-neon.c: Remove.
4162         * features/arm/arm-with-neon.xml: Remove.
4163         * features/arm/arm-with-vfpv2.c: Remove.
4164         * features/arm/arm-with-vfpv2.xml: Remove.
4165         * features/arm/arm-with-vfpv3.c: Remove.
4166         * features/arm/arm-with-vfpv3.xml: Remove.
4167
4168 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4169
4170         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4171
4172 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4173
4174         * arch/aarch32.c (aarch32_create_target_description): Create
4175         target descriptions using features.
4176         * arch/arm.c (arm_create_target_description)
4177         (arm_create_mprofile_target_description): Likewise.
4178         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4179
4180 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
4181
4182         * Makefile.in: Add new files.
4183         * aarch32-tdep.c: New file.
4184         * aarch32-tdep.h: New file.
4185         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4186         Call aarch32_read_description.
4187         * arch/aarch32.c: New file.
4188         * arch/aarch32.h: New file.
4189         * arch/arm.c (arm_create_target_description)
4190         (arm_create_mprofile_target_description): New function.
4191         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4192         (arm_create_target_description)
4193         (arm_create_mprofile_target_description): New declaration.
4194         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4195         read_description functions.
4196         * arm-linux-nat.c (arm_linux_nat_target::read_description):
4197         Likewise.
4198         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4199         * arm-tdep.c (tdesc_arm_list): New variable.
4200         (arm_register_g_packet_guesses): Call create description functions.
4201         (arm_read_description) (arm_read_mprofile_description): New
4202         function.
4203         * arm-tdep.h (arm_read_description)
4204         (arm_read_mprofile_description): Add declaration.
4205         * configure.tgt: Add new files.
4206
4207 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
4208
4209         * top.c (new_ui_command): Open specified terminal just once.
4210
4211 2019-07-18  Tom Tromey  <tromey@adacore.com>
4212
4213         * symtab.c (main_name): Constify return type.
4214         * symfile.c (set_initial_language): Update.
4215         * symtab.h (main_name): Constify return type.
4216
4217 2019-07-17  Tom Tromey  <tom@tromey.com>
4218
4219         * tui/tui-winsource.c (tui_update_source_window)
4220         (tui_update_source_window_as_is)
4221         (tui_update_source_windows_with_line): Remove return.
4222         * tui/tui-disasm.c (tui_show_disassem)
4223         (tui_show_disassem_and_update_source): Remove return.
4224         * tui/tui.c (tui_reset): Remove return.
4225         * tui/tui-wingeneral.c
4226         (tui_check_and_display_highlight_if_needed): Remove return.
4227
4228 2019-07-17  Tom Tromey  <tom@tromey.com>
4229
4230         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
4231
4232 2019-07-17  Tom Tromey  <tom@tromey.com>
4233
4234         * tui/tui-winsource.h (struct tui_exec_info_window)
4235         (struct tui_source_window_base): Move from tui-data.h.
4236         * tui/tui-winsource.c: Move many method definitions from
4237         elsewhere.  Remove "structuring" comments.
4238         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
4239         (tui_source_window_base::refresh_window): Move to
4240         tui-winsource.c.
4241         * tui/tui-win.c (tui_source_window_base::refresh_all)
4242         (tui_source_window_base::update_tab_width)
4243         (tui_source_window_base::set_new_height)
4244         (tui_source_window_base::do_make_visible_with_new_height): Move to
4245         tui-winsource.c.
4246         * tui/tui-source.h: Update.
4247         * tui/tui-source.c (tui_source_window_base::reset): Move to
4248         tui-winsource.c.
4249         * tui/tui-disasm.h: Update.
4250         * tui/tui-data.h (struct tui_exec_info_window): Move to
4251         tui-winsource.h.
4252         (struct tui_source_window_base): Likewise.
4253         * tui/tui-data.c (tui_source_window_base::clear_detail)
4254         (tui_source_window_base, ~tui_source_window_base): Move to
4255         tui-winsource.c.
4256
4257 2019-07-17  Tom Tromey  <tom@tromey.com>
4258
4259         * tui/tui-win.c (tui_resize_all)
4260         (tui_source_window_base::update_tab_width)
4261         (tui_adjust_win_heights): Update.
4262         (tui_win_info::make_invisible_and_set_new_height): Rename from
4263         make_invisible_and_set_new_height.
4264         * tui/tui-data.h (struct tui_win_info)
4265         <make_invisible_and_set_new_height>: New method.
4266
4267 2019-07-17  Tom Tromey  <tom@tromey.com>
4268
4269         * tui/tui.c: Update.
4270         * tui/tui-source.h (struct tui_source_window): Move from
4271         tui-data.h.
4272         * tui/tui-layout.c: Update.
4273         * tui/tui-disasm.c: Update.
4274         * tui/tui-data.h (struct tui_source_window): Move to
4275         tui-source.h.
4276
4277 2019-07-17  Tom Tromey  <tom@tromey.com>
4278
4279         * tui/tui-disasm.h (struct tui_disasm_window): Move from
4280         tui-data.h.
4281         * tui/tui-data.h (struct tui_disasm_window): Move to
4282         tui-disasm.h.
4283
4284 2019-07-17  Tom Tromey  <tom@tromey.com>
4285
4286         * tui/tui-regs.h (struct tui_data_item_window): Move from
4287         tui-data.h.
4288         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4289         * tui/tui-data.h (struct tui_data_item_window): Move to
4290         tui-regs.h.
4291         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4292
4293 2019-07-17  Tom Tromey  <tom@tromey.com>
4294
4295         * tui/tui.c: Update.
4296         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4297         (tui_cmd_window::max_height): Move to tui-command.c.
4298         * tui/tui-layout.c: Update.
4299         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4300         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4301         tui-command.c.
4302         * tui/tui-command.h (struct tui_cmd_window): Move from
4303         tui-data.h.
4304         * tui/tui-command.c: Remove "structuring" comments.
4305         (tui_cmd_window::clear_detail)
4306         (tui_cmd_window::do_make_visible_with_new_height)
4307         (tui_cmd_window::max_height): Move from elsewhere.
4308
4309 2019-07-17  Tom Tromey  <tom@tromey.com>
4310
4311         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4312         Now static.
4313         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4314         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4315
4316 2019-07-17  Tom Tromey  <tom@tromey.com>
4317
4318         * tui/tui.c: Update.
4319         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4320         tui-regs.c.
4321         * tui/tui-windata.h: Remove file.
4322         * tui/tui-windata.c: Remove file.
4323         * tui/tui-win.c (tui_data_window::set_new_height)
4324         (tui_data_window::do_make_visible_with_new_height): Move to
4325         tui-regs.c.
4326         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4327         * tui/tui-regs.c: Remove "structuring" comments.
4328         (tui_data_window::first_data_item_displayed)
4329         (tui_data_window::delete_data_content_windows)
4330         (tui_data_window::erase_data_content)
4331         (tui_data_window::display_all_data)
4332         (tui_data_window::refresh_all)
4333         (tui_data_window::do_scroll_vertical)
4334         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4335         (tui_data_window::do_make_visible_with_new_height)
4336         (tui_data_window::refresh_window): Move from elsewhere.
4337         (_initialize_tui_regs): Move to end of file.
4338         * tui/tui-layout.c: Update.
4339         * tui/tui-hooks.c: Update.
4340         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4341         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4342         tui-regs.c.
4343         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4344
4345 2019-07-17  Tom Tromey  <tom@tromey.com>
4346
4347         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4348         seen.
4349
4350 2019-07-17  Tom Tromey  <tom@tromey.com>
4351
4352         * tui/tui-win.c (tui_source_window_base::set_new_height)
4353         (tui_source_window_base::do_make_visible_with_new_height): Use
4354         m_has_locator field directly.
4355         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4356         method.
4357         (struct tui_source_window_base) <has_locator>: Likewise.
4358
4359 2019-07-17  Tom Tromey  <tom@tromey.com>
4360
4361         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4362         Don't declare.
4363         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4364         Remove.
4365         * tui/tui-win.c (tui_source_window_base::set_new_height)
4366         (tui_source_window_base::set_new_height)
4367         (make_invisible_and_set_new_height)
4368         (tui_source_window_base::do_make_visible_with_new_height)
4369         (tui_source_window_base::do_make_visible_with_new_height):
4370         Update.
4371         * tui/tui-layout.c (show_source_disasm_command, show_data)
4372         (show_source_or_disasm_and_command): Update.
4373         * tui/tui-layout.c (show_layout): Update.
4374
4375 2019-07-17  Tom Tromey  <tom@tromey.com>
4376
4377         * tui/tui-layout.c (make_data_window): Remove.
4378         (show_data): Unify creation and re-initialization cases.
4379
4380 2019-07-17  Tom Tromey  <tom@tromey.com>
4381
4382         * tui/tui-layout.c (make_source_window, make_disasm_window):
4383         Remove.
4384         (show_data): Unify creation and re-initialization cases.
4385
4386 2019-07-17  Tom Tromey  <tom@tromey.com>
4387
4388         * tui/tui-layout.c (make_command_window): Remove.
4389         (show_source_disasm_command, show_source_or_disasm_and_command):
4390         Unify creation and re-initialization cases.
4391
4392 2019-07-17  Tom Tromey  <tom@tromey.com>
4393
4394         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4395         creation and re-initialization cases.
4396
4397 2019-07-17  Tom Tromey  <tom@tromey.com>
4398
4399         * tui/tui-regs.c (tui_get_register): Return void.
4400
4401 2019-07-17  Tom Tromey  <tom@tromey.com>
4402
4403         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4404         Simplify.
4405
4406 2019-07-17  Tom Tromey  <tom@tromey.com>
4407
4408         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4409         resetting.
4410
4411 2019-07-17  Tom Tromey  <tom@tromey.com>
4412
4413         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4414         * tui/tui-regs.c (tui_reg_layout): New function.
4415         (tui_show_registers, tui_reg_command): Use it.
4416         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4417         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4418         parameters.
4419         (tui_layout_command): Remove.
4420
4421 2019-07-17  Tom Tromey  <tom@tromey.com>
4422
4423         * tui/tui-layout.h (tui/tui-layout): Return void.
4424         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4425
4426 2019-07-17  Tom Tromey  <tom@tromey.com>
4427
4428         * tui/tui-layout.c (show_source_disasm_command, show_data):
4429         Update.
4430         (reset_locator): Remove.
4431         (show_source_or_disasm_and_command): Update.
4432
4433 2019-07-17  Tom Tromey  <tom@tromey.com>
4434
4435         * tui/tui-source.c (tui_source_window_base::reset): Remove
4436         win_type parameter.
4437         * tui/tui-layout.c (make_command_window, make_source_window)
4438         (make_disasm_window, make_data_window)
4439         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4440         (reset_locator, show_source_or_disasm_and_command): Update.
4441         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4442         win_type parameter.
4443         (struct tui_source_window_base) <reset>: Likewise.
4444
4445 2019-07-17  Tom Tromey  <tom@tromey.com>
4446
4447         * tui/tui-layout.c (show_source_disasm_command): Use
4448         reset_locator.
4449         (reset_locator): New function.
4450         (init_and_make_win): Remove.
4451         (show_source_or_disasm_and_command): Use reset_locator.
4452
4453 2019-07-17  Tom Tromey  <tom@tromey.com>
4454
4455         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4456         condition.
4457         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4458         Remove condition.
4459         * tui/tui-source.c (tui_source_window_base::reset): New method.
4460         * tui/tui-layout.c (make_command_window): Don't call
4461         init_and_make_win.
4462         (make_source_window, make_disasm_window): Don't call
4463         make_source_or_disasm_window.
4464         (make_data_window): Don't call init_and_make_win.  Change calling
4465         convention.
4466         (show_source_disasm_command, show_data): Simplify.
4467         (make_source_or_disasm_window): Remove.
4468         (show_source_or_disasm_and_command): Simplify.
4469         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4470         (struct tui_source_window_base) <reset>: Likewise.
4471         <execution_info>: Remove initializer.
4472         * tui/tui-data.c (tui_source_window_base): Initialize
4473         execution_info.
4474
4475 2019-07-17  Tom Tromey  <tom@tromey.com>
4476
4477         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4478         variable.
4479
4480 2019-07-17  Tom Tromey  <tom@tromey.com>
4481
4482         * tui/tui.c (tui_rl_other_window): Update.
4483         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4484         superclass method first.  Always iterate over regs_content.
4485         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4486         method.
4487         * tui/tui-win.c (tui_set_focus_command): Update.
4488
4489 2019-07-17  Tom Tromey  <tom@tromey.com>
4490
4491         * tui/tui-win.c (tui_set_focus_command): Rename from
4492         tui_set_focus.  Call tui_enable.
4493         (tui_set_focus_command): Remove.
4494
4495 2019-07-17  Tom Tromey  <tom@tromey.com>
4496
4497         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4498         refresh_window.
4499         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4500         touchwin.
4501         (tui_data_window::refresh_window): Call refresh_window on data
4502         items.  Always call superclass refresh_window.
4503         (tui_win_info::refresh): Remove.
4504         (tui_source_window_base::refresh_window): Update.
4505         (tui_refresh_all): Update.
4506         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4507         refresh_window.
4508         (show_source_or_disasm_and_command): Likewise.
4509         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4510         (struct tui_source_window_base) <refresh>: Likewise.
4511
4512 2019-07-17  Tom Tromey  <tom@tromey.com>
4513
4514         * tui/tui-winsource.c (tui_clear_source_content)
4515         (tui_show_source_content): Update.
4516         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4517         whether content is empty.
4518         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4519         Remove.
4520
4521 2019-07-17  Tom Tromey  <tom@tromey.com>
4522
4523         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4524         window's contents.
4525         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4526         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4527
4528 2019-07-17  Tom Tromey  <tom@tromey.com>
4529
4530         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4531         (struct tui_data_item_window): Update.
4532
4533 2019-07-17  Tom Tromey  <tom@tromey.com>
4534
4535         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4536         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4537         defines.
4538
4539 2019-07-17  Tom Tromey  <tom@tromey.com>
4540
4541         * tui/tui-winsource.h (tui_erase_source_content)
4542         (tui_clear_source_content): Remove "display_prompt" parameter.
4543         * tui/tui-winsource.c (tui_update_source_window_as_is)
4544         (tui_update_source_windows_with_addr): Update.
4545         (tui_clear_source_content): Remove "display_prompt" parameter.
4546         (tui_erase_source_content): Likewise.  Simplify.
4547         (tui_show_source_content): Update.
4548         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4549         * tui/tui-stack.c (tui_show_frame_info): Update.
4550         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4551         Remove defines.
4552
4553 2019-07-17  Tom Tromey  <tom@tromey.com>
4554
4555         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4556         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4557         parameter.
4558         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4559         parameter.
4560
4561 2019-07-17  Tom Tromey  <tom@tromey.com>
4562
4563         * tui/tui-winsource.c (tui_clear_source_content)
4564         (tui_show_source_content, tui_show_exec_info_content)
4565         (tui_clear_exec_info_content): Update.
4566         * tui/tui-stack.c (tui_show_locator_content): Update.
4567         (tui_show_frame_info): Update.
4568         * tui/tui-source.h (tui_source_window): Don't declare.
4569         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4570         from tui_source_is_displayed.
4571         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4572         Remove field.
4573         (struct tui_source_window_base) <content_in_use>: New field.  Now
4574         bool.
4575         (struct tui_source_window) <showing_source_p>: New method.
4576         (TUI_SRC_WIN): Change cast.
4577         * tui/tui-data.c (tui_initialize_static_data): Update.
4578
4579 2019-07-17  Tom Tromey  <tom@tromey.com>
4580
4581         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4582         location_matches_p.
4583         * tui/tui-source.c (tui_source_window::location_matches_p): New
4584         method.
4585         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4586         method.
4587         * tui/tui-data.h (struct tui_source_window_base)
4588         <location_matches_p>: New method.
4589         (struct tui_source_window, struct tui_disasm_window)
4590         <location_matches_p>: Likewise.
4591
4592 2019-07-17  Tom Tromey  <tom@tromey.com>
4593
4594         * tui/tui-win.c (tui_set_win_height_command): Rename from
4595         tui_set_win_height.
4596         (tui_set_win_height_command): Remove.
4597
4598 2019-07-17  Tom Tromey  <tom@tromey.com>
4599
4600         * tui/tui-source.c (tui_source_window): New constructor.  Add
4601         observer.
4602         (~tui_source_window): New destructor.
4603         (tui_source_window::style_changed): New method.
4604         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4605         (tui_attach_detach_observers): Update.
4606         * tui/tui-data.h (struct tui_source_window): Make constructor not
4607         inline.  Add destructor.
4608         (struct tui_source_window) <style_changed>: New method.
4609         <m_observable>: New member.
4610
4611 2019-07-17  Tom Tromey  <tom@tromey.com>
4612
4613         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4614         * tui/tui-win.c (tui_resize_all): Fix typo.
4615
4616 2019-07-17  Tom Tromey  <tom@tromey.com>
4617
4618         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4619         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4620         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4621         * tui/tui-win.c (window_name_completer): Use foreach.
4622         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4623         (update_tab_width): Likewise.
4624         * tui/tui-layout.c (show_layout): Update.
4625         * tui/tui-data.h (class tui_window_iterator): New.
4626         (struct all_tui_windows): New.
4627         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4628
4629 2019-07-17  Tom Tromey  <tom@tromey.com>
4630
4631         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4632         parameter.  Don't reference globals.
4633         (tui_reg_command): Update.
4634
4635 2019-07-17  Tom Tromey  <tom@tromey.com>
4636
4637         * tui/tui-regs.c (tui_show_registers): Simplify.
4638
4639 2019-07-17  Tom Tromey  <tom@tromey.com>
4640
4641         * tui/tui-regs.c (tui_show_registers): Update.
4642         (tui_show_register_group): Add win_info parameter.
4643
4644 2019-07-17  Tom Tromey  <tom@tromey.com>
4645
4646         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4647         Rename from tui_display_reg_element_at_line.
4648         (tui_data_window::display_registers_from_line): Update.
4649         * tui/tui-data.h (struct tui_data_window)
4650         <display_reg_element_at_line>: New method.
4651
4652 2019-07-17  Tom Tromey  <tom@tromey.com>
4653
4654         * tui/tui-regs.h (tui_display_registers_from)
4655         (tui_display_registers_from_line): Don't declare.
4656         * tui/tui-windata.c (tui_data_window::display_all_data)
4657         (tui_data_window::refresh_all)
4658         (tui_data_window::do_scroll_vertical): Update.
4659         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4660         from tui_display_registers_from.
4661         (tui_display_reg_element_at_line): Update.
4662         (tui_data_window::display_registers_from_line): Rename from
4663         tui_display_registers_from_line.
4664         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4665         display_registers_from_line>: New methods.
4666
4667 2019-07-17  Tom Tromey  <tom@tromey.com>
4668
4669         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4670         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4671         from tui_erase_data_content.
4672         (tui_data_window::display_all_data)
4673         (tui_data_window::refresh_all)
4674         (tui_data_window::do_scroll_vertical): Update.
4675         * tui/tui-regs.c (tui_show_registers): Update.
4676         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4677         New method.
4678
4679 2019-07-17  Tom Tromey  <tom@tromey.com>
4680
4681         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4682         declare.
4683         * tui/tui-windata.c
4684         (tui_data_window::delete_data_content_windows): Rename from
4685         tui_delete_data_content_windows.
4686         (tui_data_window::display_all_data)
4687         (tui_data_window::do_scroll_vertical): Update.
4688         * tui/tui-data.h (struct tui_data_window)
4689         <delete_data_content_windows>: New method.
4690
4691 2019-07-17  Tom Tromey  <tom@tromey.com>
4692
4693         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4694         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4695
4696 2019-07-17  Tom Tromey  <tom@tromey.com>
4697
4698         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4699         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4700         from tui_display_all_data.
4701         * tui/tui-win.c
4702         (tui_data_window::do_make_visible_with_new_height): Update.
4703         * tui/tui-regs.c (tui_show_registers): Update.
4704         * tui/tui-layout.c (tui_set_layout): Update.
4705         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4706         method.
4707
4708 2019-07-17  Tom Tromey  <tom@tromey.com>
4709
4710         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4711         * tui/tui-windata.c (tui_display_data_from): Remove.
4712         (tui_data_window::refresh_all): Update.
4713
4714 2019-07-17  Tom Tromey  <tom@tromey.com>
4715
4716         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4717         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4718         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4719         tui_display_registers_from_line.
4720         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4721         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4722         "force_display" parameter.
4723
4724 2019-07-17  Tom Tromey  <tom@tromey.com>
4725
4726         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4727         declare.
4728         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4729         Rename from tui_first_reg_element_no_inline.
4730         (tui_display_reg_element_at_line)
4731         (tui_display_registers_from_line): Update.
4732         * tui/tui-data.h (struct tui_data_window)
4733         <first_reg_element_no_inline>: New method.
4734
4735 2019-07-17  Tom Tromey  <tom@tromey.com>
4736
4737         * tui/tui-windata.c (tui_display_data_from)
4738         (tui_data_window::do_scroll_vertical): Update.
4739         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4740         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4741         Rename from tui_line_from_reg_element_no.
4742         (tui_display_registers_from_line): Update.
4743         * tui/tui-data.h (struct tui_data_window)
4744         <line_from_reg_element_no>: New method.
4745
4746 2019-07-17  Tom Tromey  <tom@tromey.com>
4747
4748         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4749         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4750         tui_last_regs_line_no.
4751         (tui_display_reg_element_at_line)
4752         (tui_display_registers_from_line): Update.
4753         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4754         method.
4755
4756 2019-07-17  Tom Tromey  <tom@tromey.com>
4757
4758         PR tui/24722:
4759         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4760         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4761         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4762         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4763         (tui_update_breakpoint_info): Likewise.
4764         * tui/tui-hooks.c (tui_event_create_breakpoint)
4765         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4766         Update.
4767
4768 2019-07-17  Tom Tromey  <tom@tromey.com>
4769
4770         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4771
4772 2019-07-17  Tom Tromey  <tom@tromey.com>
4773
4774         * tui/tui-winsource.c (tui_update_source_window_as_is)
4775         (tui_update_source_windows_with_addr): Update.
4776         * tui/tui-source.h (tui_set_source_content)
4777         (tui_show_symtab_source): Add "win_info" parameter.
4778         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4779         parameter.
4780         (tui_show_symtab_source): Likewise.
4781
4782 2019-07-17  Tom Tromey  <tom@tromey.com>
4783
4784         * tui/tui-wingeneral.c
4785         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4786
4787 2019-07-17  Tom Tromey  <tom@tromey.com>
4788
4789         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4790         (struct tui_cmd_window) <can_scroll>: New method.
4791         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4792         method.
4793
4794 2019-07-17  Tom Tromey  <tromey@adacore.com>
4795
4796         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4797         do_field_signed>: Rename.  Change type of "value".
4798         * ui-out.c (ui_out::field_signed): Rename from field_int.
4799         Change type of "value".
4800         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4801         type of "value".
4802         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4803         do_field_int.  Change type of "value".
4804         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4805         do_field_int.  Change type of "value".
4806         * tracepoint.c (trace_status_mi, tfind_1)
4807         (print_one_static_tracepoint_marker): Update.
4808         * thread.c (print_thread_info_1, print_selected_thread_frame):
4809         Update.
4810         * stack.c (print_frame, print_frame_info): Update.
4811         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4812         Update.
4813         * source.c (print_source_lines_base): Update.
4814         * skip.c (info_skip_command): Update.
4815         * record-btrace.c (btrace_ui_out_decode_error)
4816         (btrace_call_history_src_line): Update.
4817         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4818         Update.
4819         * progspace.c (print_program_space): Update.
4820         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4821         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4822         do_field_int.  Change type of "value".
4823         * mi/mi-out.c (mi_ui_out::do_table_begin)
4824         (mi_ui_out::do_table_header): Update.
4825         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4826         type of "value".
4827         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4828         (mi_cmd_data_list_changed_registers, output_register)
4829         (mi_cmd_data_read_memory, mi_load_progress)
4830         (mi_cmd_trace_frame_collected): Update.
4831         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4832         Update.
4833         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4834         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4835         (mi_cmd_var_list_children, varobj_update_one): Update.
4836         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4837         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4838         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4839         * inferior.c (print_inferior): Update.
4840         * gdb_bfd.c (print_one_bfd): Update.
4841         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4842         Update.
4843         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4844         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4845         do_field_int.  Change type of "value".
4846         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4847         do_field_int.  Change type of "value".
4848         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4849         (print_one_breakpoint_location, print_it_catch_fork)
4850         (print_one_catch_fork, print_it_catch_vfork)
4851         (print_one_catch_vfork, print_it_catch_solib)
4852         (print_it_catch_exec, print_it_ranged_breakpoint)
4853         (print_mention_watchpoint, print_mention_masked_watchpoint)
4854         (bkpt_print_it, update_static_tracepoint): Update.
4855         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4856         * break-catch-syscall.c (print_it_catch_syscall): Update.
4857         * ada-tasks.c (print_ada_task_info): Update.
4858         * ada-lang.c (print_it_exception, print_mention_exception):
4859         Update.
4860
4861 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4862
4863         PR breakpoints/24541
4864         * gdbarch.c: Regenerate.
4865         * gdbarch.h: Regenerate.
4866         * gdbarch.sh: Adjust return type and parameter types for
4867         'stap_adjust_register'.
4868         (i386_stap_adjust_register): Adjust signature and return new
4869         register name.
4870         * stap-probe.c (stap_parse_register_operand): Adjust use of
4871         'gdbarch_stap_adjust_register'.
4872
4873 2019-07-17  Tom Tromey  <tromey@adacore.com>
4874
4875         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4876         declare VEC.
4877         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4878         std::vector.
4879         (struct s390_process_info): Add initializers.
4880         (s390_add_process): Use new.
4881         (s390_linux_nat_target::low_forget_process): Use delete.
4882         (s390_linux_nat_target::low_new_fork)
4883         (s390_linux_nat_target::stopped_by_watchpoint)
4884         (s390_linux_nat_target::low_prepare_to_resume)
4885         (s390_linux_nat_target::insert_watchpoint)
4886         (s390_linux_nat_target::insert_hw_breakpoint)
4887         (s390_linux_nat_target::remove_watchpoint)
4888         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4889
4890 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4891
4892         * aarch64-fbsd-nat.c: Include regcache.h.
4893         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4894         argument.
4895         (aarch64_fbsd_nat_target::fetch_registers)
4896         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4897         variable.
4898         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4899
4900 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4901
4902         * fbsd-nat.c: Include gdbarch.h.
4903
4904 2019-07-15  Tom Tromey  <tromey@adacore.com>
4905
4906         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4907
4908 2019-07-15  Tom Tromey  <tromey@adacore.com>
4909
4910         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4911         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4912         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4913         * cli-out.c (cli_ui_out::do_field_int): New method.
4914         * ui-out.c (ui_out::field_unsigned): New method.
4915         * symfile.c (generic_load): Use field_unsigned.
4916         (print_transfer_performance): Likewise.
4917         * record-btrace.c (ui_out_field_uint): Remove.
4918         (btrace_call_history_insn_range, btrace_call_history): Use
4919         field_unsigned.
4920         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4921         field_unsigned.
4922         * ui-out.h (class ui_out) <field_unsigned>: New method.
4923         <do_field_unsigned>: Likewise.
4924
4925 2019-07-15  Tom Tromey  <tromey@adacore.com>
4926
4927         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4928         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4929         * target.c (flash_erase_command): Use field_string.
4930         * infrun.c (print_signal_received_reason): Use field_string.
4931         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4932         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4933         field_string.
4934         * ada-tasks.c (print_ada_task_info): Use field_string.
4935
4936 2019-07-15  Tom Tromey  <tromey@adacore.com>
4937
4938         * target.c (flash_erase_command): Use field_core_addr.
4939         * symfile.c (generic_load): Use field_core_addr.
4940         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4941         Use field_core_addr.
4942         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4943         field_core_addr.
4944
4945 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4946
4947         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4948         value if its desired type is smaller than a CORE_ADDR and signed.
4949
4950 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4951
4952         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4953         of changes to field names, and use new is_reference field to
4954         decide if a property is a reference or not.
4955         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4956         field.
4957         (struct dwarf2_property_baton): Update header comment, rename
4958         'referenced_type' to 'property_type' and update comments.
4959         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4960         default property type, store in property baton, update to take
4961         accound of renamed field.
4962         (read_func_scope): Update call to attr_to_dynamic_prop.
4963         (read_array_type): Likewise.
4964         (dwarf2_per_cu_addr_sized_int_type): New function.
4965         (read_subrange_index_type): Move type finding code to
4966         dwarf2_per_cu_addr_sized_int_type.
4967         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4968         (dwarf2_per_cu_addr_type): New function.
4969         (set_die_type): Update calls to attr_to_dynamic_prop.
4970
4971 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4972
4973         * dwarf2read.c (read_subrange_index_type): New function.
4974         (read_subrange_type): Move code into new function and call it.
4975         * gdbtypes.c (create_range_type): Add some asserts.
4976
4977 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4978
4979         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4980         update return statements.
4981         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4982         declaration, and update comment to match.
4983         * gdbtypes.c (resolve_dynamic_array): Update call to
4984         dwarf2_evaluate_property to match new return type.
4985
4986 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4987
4988         * valarith.c (value_subscripted_rvalue): Change lowerbound
4989         parameter type from int to LONGEST.
4990         * value.h (value_subscripted_rvalue): Likewise in declaration.
4991
4992 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4993
4994         * cli/cli-utils.c (info_print_command_completer): New function.
4995         * cli/cli-utils.h: Add 'completer.h' include, and forward
4996         declaration for 'struct cmd_list_element'.
4997         (info_print_command_completer): Declare.
4998         * stack.c (_initialize_stack): Add completer for 'info locals' and
4999         'info args'.
5000         * symtab.c (_initialize_symtab): Add completer for 'info
5001         variables' and 'info functions'.
5002         * NEWS: Mention completion for additional info commands.
5003
5004 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5005
5006         * cli/cli-utils.c (extract_info_print_args): Delete.
5007         (extract_arg_maybe_quoted): Delete.
5008         (info_print_options_defs): New variable.
5009         (make_info_print_options_def_group): New function.
5010         (extract_info_print_options): Define new function.
5011         * cli/cli-utils.h (extract_info_print_args): Delete.
5012         (struct info_print_options): New structure.
5013         (extract_info_print_options): Declare new function.
5014         * stack.c (info_locals_command): Update to use new
5015         extract_info_print_options, also add a header comment.
5016         (info_args_command): Likewise.
5017         * symtab.c (info_variables_command): Likewise.
5018         (info_functions_command): Likewise.
5019
5020 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5021
5022         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5023         to extract string arguments.
5024         * common/common-utils.c (extract_string_maybe_quoted): New function.
5025         * common/common-utils.h (extract_string_maybe_quoted): Declare.
5026
5027 2019-07-11  Tom Tromey  <tromey@adacore.com>
5028
5029         * main.c (get_init_files): Use GDBINIT, not gdbinit.
5030         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5031         * top.h (gdbinit): Don't declare.
5032         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5033         into...
5034         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
5035         * top.c (gdb_init): Don't call init_cli_cmds.
5036         (gdbinit): Remove.
5037         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5038
5039 2019-07-11  Tom Tromey  <tromey@adacore.com>
5040
5041         * python/py-inferior.c (add_thread_object): Don't use thread_obj
5042         after it has been moved.
5043
5044 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5045
5046         * valops.c (value_must_coerce_to_target): Change return type to
5047         bool.
5048         * value.h (value_must_coerce_to_target): Likewise.
5049
5050 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
5051
5052         * breakpoint.c (is_hardware_watchpoint): Remove
5053         forward-declaration.
5054         (is_masked_watchpoint): Change return type to bool.
5055         (is_tracepoint): Likewise.
5056         (is_breakpoint): Likewise.
5057         (is_hardware_watchpoint): Likewise.
5058         (is_watchpoint): Likewise.
5059         (is_no_memory_software_watchpoint): Likewise.
5060         (is_catchpoint): Likewise.
5061         (breakpoint_1): Make FILTER parameter's return type bool.
5062         is_masked_watchpoint): Change return type to bool.
5063         (save_breakpoints): Make FILTER parameter's return type bool.
5064         * breakpoint.h (is_breakpoint): Change return type to bool.
5065         (is_watchpoint): Likewise.
5066         (is_catchpoint): Likewise.
5067         (is_tracepoint): Likewise.
5068
5069 2019-07-10  Tom Tromey  <tom@tromey.com>
5070
5071         * defs.h: Don't include gdbarch.h.
5072         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5073         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5074         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5075         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5076         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5077         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5078         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5079         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5080         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5081         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5082         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5083         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5084         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5085         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5086         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5087         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5088         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5089         record-btrace.c, record.h, regcache-dump.c, regcache.h,
5090         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5091         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5092         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5093         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5094         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5095         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5096         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5097         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5098         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5099
5100 2019-07-10  Tom Tromey  <tromey@adacore.com>
5101
5102         * ada-lang.h (is_ada_exception_catchpoint): Declare.
5103         * breakpoint.c (init_ada_exception_breakpoint): Register as
5104         bp_catchpoint.
5105         (print_one_breakpoint_location, print_one_breakpoint): Use
5106         is_ada_exception_catchpoint.
5107         * ada-lang.c (class ada_catchpoint_location): Pass
5108         bp_loc_software_breakpoint to bp_location constructor.
5109         (is_ada_exception_catchpoint): New function.
5110
5111 2019-07-10  Tom Tromey  <tromey@adacore.com>
5112
5113         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
5114         VEC.
5115         (struct arm_exidx_entry): New method operator<.
5116         (struct arm_exidx_data) <section_maps>: Change type.
5117         (arm_exidx_data_free): Remove.
5118         (arm_exidx_data_key): Change type.  Move lower.
5119         (arm_exidx_new_objfile): Update.
5120         (arm_compare_exidx_entries): Remove.
5121         (arm_find_exidx_entry, _initialize_arm_tdep)
5122
5123 2019-07-10  Tom Tromey  <tromey@adacore.com>
5124
5125         * solib-spu.c (ocl_program_data_key): Change type.
5126         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5127         Update.
5128
5129 2019-07-10  Tom Tromey  <tromey@adacore.com>
5130
5131         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
5132         (struct solib_aix_inferior_data) <library_list>: Change type.
5133         (solib_aix_inferior_data_handle): Change type.
5134         (get_solib_aix_inferior_data): Update.
5135         (solib_aix_free_library_list): Remove.
5136         (library_list_start_library): Update.
5137         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5138         return type.
5139         (solib_aix_get_library_list)
5140         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5141         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5142
5143 2019-07-10  Tom Tromey  <tromey@adacore.com>
5144
5145         * solib-dsbt.c (struct dsbt_info): Add initializers.
5146         (solib_dsbt_pspace_data): Change type.
5147         (dsbt_pspace_data_cleanup): Remove.
5148         (get_dsbt_info, _initialize_dsbt_solib): Update.
5149
5150 2019-07-10  Tom Tromey  <tromey@adacore.com>
5151
5152         * spu-tdep.c (spu_overlay_data): Change type.
5153         (spu_get_overlay_table, spu_overlay_new_objfile)
5154         (_initialize_spu_tdep): Update.
5155
5156 2019-07-10  Tom Tromey  <tromey@adacore.com>
5157
5158         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5159         destructor.
5160         (dbx_objfile_data_key): Change type and declare later.
5161         (DBX_SYMFILE_INFO): Rewrite.
5162         * dbxread.c (dbx_objfile_data_key): Change type.
5163         (dbx_symfile_init): Update.
5164         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
5165         (coffstab_build_psymtabs, elfstab_build_psymtabs)
5166         (stabsect_build_psymtabs, _initialize_dbxread): Update.
5167
5168 2019-07-10  Tom Tromey  <tromey@adacore.com>
5169
5170         * jit.c (jit_program_space_key): Change type.  Move lower.
5171         (get_jit_program_space_data): Update.
5172         (jit_program_space_data_cleanup): Remove.
5173         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5174         Update.
5175         (struct jit_program_space_data): Add initializers.
5176
5177 2019-07-10  Tom Tromey  <tromey@adacore.com>
5178
5179         * solib-darwin.c (struct darwin_info): Add initializers.
5180         (solib_darwin_pspace_data): Change type.
5181         (darwin_pspace_data_cleanup): Remove.
5182         (get_darwin_info, _initialize_darwin_solib): Update.
5183
5184 2019-07-10  Tom Tromey  <tromey@adacore.com>
5185
5186         * remote-sim.c (struct sim_inferior_data): Add initializers,
5187         constructor, and destructor.
5188         (sim_inferior_data_key): Change type.  Move lower.
5189         (check_for_duplicate_sim_descriptor): Update.
5190         (get_sim_inferior_data): Use new.  Update.
5191         (~sim_inferior_data_cleanup): Rename from
5192         sim_inferior_data_cleanup.  Simplify.
5193         (gdbsim_close_inferior, simulator_command)
5194         (sim_command_completer, _initialize_remote_sim): Update.
5195         (next_pid, INITIAL_PID): Move earlier.
5196
5197 2019-07-10  Tom Tromey  <tromey@adacore.com>
5198
5199         * python/python-internal.h (create_thread_object): Return
5200         gdbpy_ref.
5201         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5202         * python/py-inferior.c (struct threadlist_entry): Add
5203         constructor.
5204         <thread_obj>: Now a gdbpy_ref.
5205         (thread_to_thread_object): Update.
5206         (add_thread_object): Use new.
5207         (delete_thread_object): Use delete.
5208         (infpy_threads): Update.
5209         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
5210         GIL.
5211
5212 2019-07-10  Tom Tromey  <tromey@adacore.com>
5213
5214         * valops.c (value_cast): Specialize error message for Ada.
5215
5216 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5217
5218         * breakpoint.c (breakpoint_1): Update doc and parameter names.
5219
5220 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
5221
5222         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5223         bpstat_should_step): Return bool, adjust comments.
5224         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
5225         bpstat_should_step): Likewise.
5226
5227 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5228
5229         * features/Makefile: Use feature target descriptions for Arm.
5230         * features/arm/arm-core.c: Generate new file.
5231         * features/arm/arm-fpa.c: Likewise.
5232         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
5233         * features/arm/arm-m-profile.c: Likewise.
5234         * features/arm/arm-vfpv2.c: Likewise.
5235         * features/arm/arm-vfpv3.c: Likewise.
5236         * features/arm/xscale-iwmmxt.c: Likewise.
5237         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
5238
5239 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5240
5241         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
5242         ptrace earlier.
5243
5244 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
5245
5246         * features/aarch64-pauth.c: Regenerate.
5247
5248 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
5249
5250         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
5251         bool.
5252         (bpstat_what): Use false instead of 0.
5253
5254 2019-07-09  Pedro Alves  <palves@redhat.com>
5255
5256         * break-catch-throw.c (is_exception_catchpoint): New.
5257         * breakpoint.c (print_one_breakpoint_location): New parameter
5258         'raw_loc'.  Handle it.  Use
5259         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
5260         looking at the breakpoint's type.
5261         (print_one_breakpoint): If handling "maint info breakpoints", also
5262         print locations of exception catchpoints.
5263         * breakpoint.h (is_exception_catchpoint): Declare.
5264
5265 2019-07-09  Pedro Alves  <palves@redhat.com>
5266
5267         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
5268         "addr" field.
5269         (allocate_location_exception_catchpoint): New.
5270         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
5271         (initialize_throw_catchpoint_ops): Install
5272         allocate_location_exception_catchpoint as allocate_location
5273         method.
5274         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
5275         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
5276         bp_loc_other.
5277         (breakpoint_address_is_meaningful): Delete.
5278         (bl_address_is_meaningful): New.
5279         (breakpoint_locations_match): Adjust comment.
5280         (bp_location_from_bp_type): New, factored out of...
5281         (bp_location::bp_location(breakpoint *)): ... this.
5282         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
5283         factored out of...
5284         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5285         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5286         breakpoint_address_is_meaningful.
5287         (bp_locations_compare): Adjust comment.
5288         (update_global_location_list): Use bl_address_is_meaningful
5289         instead of breakpoint_address_is_meaningful.
5290         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5291         explicit.
5292         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5293         * python/py-breakpoint.c (bppy_get_location): No longer check
5294         whether location is null.
5295
5296 2019-07-09  Pedro Alves  <palves@redhat.com>
5297
5298         PR c++/15468
5299         * breakpoint.c (print_one_breakpoint_location): Remove
5300         single-location assert.
5301
5302 2019-07-09  Tom Tromey  <tom@tromey.com>
5303
5304         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5305         * configure: Rebuild.
5306         * configure.ac: Change common to gdbsupport.
5307         * gdbsupport: Rename from common.
5308         * acinclude.m4: Change common to gdbsupport.
5309         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5310         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5311         gdbsupport.
5312         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5313         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5314         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5315         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5316         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5317         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5318         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5319         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5320         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5321         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5322         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5323         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5324         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5325         coff-pe-read.c, command.h, compile/compile-c-support.c,
5326         compile/compile-c.h, compile/compile-cplus-symbols.c,
5327         compile/compile-cplus-types.c, compile/compile-cplus.h,
5328         compile/compile-loc2c.c, compile/compile.c, completer.c,
5329         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5330         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5331         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5332         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5333         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5334         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5335         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5336         features/aarch64-core.c, features/aarch64-fpu.c,
5337         features/aarch64-pauth.c, features/aarch64-sve.c,
5338         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5339         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5340         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5341         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5342         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5343         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5344         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5345         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5346         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5347         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5348         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5349         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5350         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5351         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5352         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5353         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5354         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5355         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5356         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5357         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5358         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5359         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5360         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5361         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5362         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5363         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5364         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5365         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5366         minsyms.c, mips-linux-tdep.c, namespace.h,
5367         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5368         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5369         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5370         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5371         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5372         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5373         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5374         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5375         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5376         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5377         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5378         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5379         procfs.c, producer.c, progspace.h, psymtab.h,
5380         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5381         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5382         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5383         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5384         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5385         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5386         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5387         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5388         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5389         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5390         target-memory.c, target.c, target.h, target/waitstatus.c,
5391         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5392         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5393         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5394         unittests/array-view-selftests.c,
5395         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5396         unittests/common-utils-selftests.c,
5397         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5398         unittests/format_pieces-selftests.c,
5399         unittests/function-view-selftests.c,
5400         unittests/lookup_name_info-selftests.c,
5401         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5402         unittests/mkdir-recursive-selftests.c,
5403         unittests/observable-selftests.c,
5404         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5405         unittests/parse-connection-spec-selftests.c,
5406         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5407         unittests/scoped_fd-selftests.c,
5408         unittests/scoped_mmap-selftests.c,
5409         unittests/scoped_restore-selftests.c,
5410         unittests/string_view-selftests.c, unittests/style-selftests.c,
5411         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5412         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5413         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5414         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5415         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5416         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5417
5418 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5419
5420         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5421         bool value.
5422         (decode_digits_ordinary): Set explicit_line field in sal.
5423         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5424         symtab_and_line that was set on an explicit line number in
5425         assembler code.  Do always update the recorded symtab and line if
5426         we do skip the prologue.
5427
5428 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5429
5430         * breakpoint.c (set_breakpoint_location_function): Remove
5431         explicit_loc parameter.
5432         (momentary_breakpoint_from_master): Update call to
5433         set_breakpoint_location_function.
5434         (add_location_to_breakpoint): Likewise.
5435
5436 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5437
5438         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5439         required features based on default bfd type when no specific bfd
5440         is present.
5441
5442 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5443
5444         * NEWS: Mention that GDB printf and eval commands can now print
5445         C-style and Ada-style convenience var strings without
5446         calling the inferior.
5447         * printcmd.c (printf_c_string): Locally print GDB internal var
5448         instead of transiting via the inferior.
5449         (printf_wide_c_string): Likewise.
5450
5451 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5452
5453         PR breakpoints/25011
5454         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5455
5456 2019-07-04  Tom Tromey  <tom@tromey.com>
5457
5458         PR tui/24724:
5459         * tui/tui-winsource.c (tui_clear_source_content): Update.
5460         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5461         (tui_update_breakpoint_info): Update.
5462         (tui_set_exec_info_content): Update.
5463         * tui/tui-source.c (tui_set_source_content_nil): Update.
5464         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5465         has_break.
5466         * tui/tui-data.h (enum tui_bp_flag): New.
5467         (tui_bp_flags): New enum flags type.
5468         (struct tui_source_element) <break_mode>: Change type.  Rename
5469         from has_break.
5470         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5471         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5472         constants.
5473         * tui/tui-winsource.h: Fix comment.
5474
5475 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5476
5477         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5478         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5479         (store_fpregs_to_thread)
5480         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5481         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5482         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5483         (IWMMXT_REGS_SIZE): Add define.
5484         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5485         (fetch_vfp_regs, store_vfp_regs)
5486         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5487         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5488
5489 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5490
5491         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5492         defines.
5493         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5494         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5495         (ARM_INT_REGISTER_SIZE): ...to this.
5496         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5497         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5498         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5499         (arm_linux_collect_gregset, supply_nwfpe_register)
5500         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5501         defines.
5502         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5503         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5504         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5505         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5506         (arm_return_in_memory, arm_store_return_value)
5507         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5508         (arm_record_ld_st_multiple): Likewise.
5509         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5510         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5511
5512 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5513
5514         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5515         AARCH64_DISPLACED_MODIFIED_INSNS.
5516         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5517         (aarch64_displaced_step_copy_insn): Likewise.
5518         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5519         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5520         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5521         ARM_DISPLACED_MODIFIED_INSNS.
5522         * arm-tdep.c (arm_gdbarch_init): Likewise.
5523         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5524         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5525         (struct arm_displaced_step_closure): Use
5526         ARM_DISPLACED_MODIFIED_INSNS.
5527
5528 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5529
5530         * features/Makefile: Remove unused xml files.
5531         * features/aarch64.xml: Remove.
5532         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5533         * features/i386/amd64-avx-avx512.xml: Remove.
5534         * features/i386/amd64-avx-linux.xml: Remove.
5535         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5536         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5537         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5538         * features/i386/amd64-avx-mpx.xml: Remove.
5539         * features/i386/amd64-avx.xml: Remove.
5540         * features/i386/amd64-linux.xml: Remove.
5541         * features/i386/amd64-mpx-linux.xml: Remove.
5542         * features/i386/amd64-mpx.xml: Remove.
5543         * features/i386/amd64.xml: Remove.
5544         * features/i386/i386-avx-avx512-linux.xml: Remove.
5545         * features/i386/i386-avx-avx512.xml: Remove.
5546         * features/i386/i386-avx-linux.xml: Remove.
5547         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5548         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5549         * features/i386/i386-avx-mpx-linux.xml: Remove.
5550         * features/i386/i386-avx-mpx.xml: Remove.
5551         * features/i386/i386-avx.xml: Remove.
5552         * features/i386/i386-linux.xml: Remove.
5553         * features/i386/i386-mmx-linux.xml: Remove.
5554         * features/i386/i386-mmx.xml: Remove.
5555         * features/i386/i386-mpx-linux.xml: Remove.
5556         * features/i386/i386-mpx.xml: Remove.
5557         * features/i386/i386.xml: Remove.
5558         * features/i386/x32-avx-avx512-linux.xml: Remove.
5559         * features/i386/x32-avx-linux.xml: Remove.
5560         * features/i386/x32-linux.xml: Remove.
5561
5562 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5563
5564         * regformats/aarch64.dat: Remove.
5565         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5566         * regformats/i386/amd64-avx-linux.dat: Remove.
5567         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5568         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5569         * regformats/i386/amd64-linux.dat: Remove.
5570         * regformats/i386/amd64-mpx-linux.dat: Remove.
5571         * regformats/i386/amd64.dat: Remove.
5572         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5573         * regformats/i386/i386-avx-linux.dat: Remove.
5574         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5575         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5576         * regformats/i386/i386-linux.dat: Remove.
5577         * regformats/i386/i386-mmx-linux.dat: Remove.
5578         * regformats/i386/i386-mpx-linux.dat: Remove.
5579         * regformats/i386/i386.dat: Remove.
5580         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5581         * regformats/i386/x32-avx-linux.dat: Remove.
5582         * regformats/i386/x32-linux.dat: Remove.
5583
5584 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5585
5586         * aarch64-tdep.c: Remove xml self tests.
5587         * amd64-linux-tdep.c: Likewise.
5588         * amd64-tdep.c: Likewise.
5589         * i386-linux-tdep.c: Likewise.
5590         * i386-tdep.c: Likewise.
5591
5592 2019-07-03  Pedro Alves  <palves@redhat.com>
5593
5594         PR cli/24732
5595         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5596         (pipe_cmd_option_defs): New.
5597         (make_pipe_cmd_options_def_group): New.
5598         (pipe_command): Use gdb::option::process_options.
5599         (pipe_command_completer): New function.
5600         (_initialize_cli_cmds): Install completer for "pipe" command.
5601
5602 2019-07-03  Pedro Alves  <palves@redhat.com>
5603
5604         * cli/cli-option.c (union option_value) <string>: New field.
5605         (struct option_def_and_value): Add ctor, move ctor, dtor and
5606         use DISABLE_COPY_AND_ASSIGN.
5607         (option_def_and_value::clear_value): New.
5608         (parse_option, save_option_value_in_ctx, get_val_type_str)
5609         (add_setshow_cmds_for_options): Handle var_string.
5610         * cli-option.h (union option_def::var_address) <string>: New
5611         field.
5612         (struct string_option_def): New.
5613         * maint-test-options.c (struct test_options_opts): Add default
5614         ctor and use DISABLE_COPY_AND_ASSIGN.
5615         <string_opt>: New field.
5616         (test_options_opts::~test_options_opts): New.
5617         (test_options_opts::dump): Also dump "-string".
5618         (test_options_option_defs): Install "string.
5619
5620 2019-07-03  Pedro Alves  <palves@redhat.com>
5621
5622         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5623         option_value with a null enumeration.
5624         (complete_options): Save the option values in the context.
5625         (save_option_value_in_ctx): New, factored out from ...
5626         (process_options): ... here.
5627         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5628         of the function.
5629         * maint-test-options.c (test_options_opts::dump): New, factored
5630         out from ...
5631         (maintenance_test_options_command_mode): ... here.
5632         (maintenance_test_options_command_completion_result): Delete.
5633         (maintenance_test_options_command_completion_text): Update
5634         comment.
5635         (maintenance_show_test_options_completion_result): Change
5636         prototype.  Just print
5637         maintenance_test_options_command_completion_text.
5638         (save_completion_result): New.
5639         (maintenance_test_options_completer_mode): Pass options context to
5640         complete_options, and then save a dump.
5641         (_initialize_maint_test_options): Use add_cmd to install "maint
5642         show test-options-completion-result".
5643
5644 2019-07-03  Pedro Alves  <palves@redhat.com>
5645
5646         * NEWS (New commands): Mention "with" and "maint with".
5647         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5648         (with_command, with_command_completer): New.
5649         (pipe_command): Adjust to new repeat_previous
5650         interface.
5651         (_initialize_cli_cmds): Install the "with" command and its "w"
5652         alias.
5653         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5654         declarations.
5655         * cli/cli-setshow.c (parse_cli_var_uinteger)
5656         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5657         argument strings for all var_types.
5658         (get_setshow_command_value_string): New, factored out from ...
5659         (do_show_command): ... this.
5660         * cli/cli-setshow.h: Include <string>.
5661         (get_setshow_command_value_string): Declare.
5662         * command.h (repeat_previous): Now returns const char *.  Adjust
5663         comment.
5664         * maint.c: Include "cli/cli-cmds.h".
5665         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5666         (_initialize_maint_cmds): Register the "maintenance with" command.
5667         * top.c (repeat_previous): Move bits from pipe_command here:
5668         Return the saved command line, if any; error out if there's no
5669         command to relaunch.
5670
5671 2019-07-03  Pedro Alves  <palves@redhat.com>
5672
5673         * NEWS (New commands): Mention "maint set/show test-settings"
5674         instead of "maint test-settings".
5675         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5676         (maintenance_test_settings_set_list): Rename to ...
5677         (maintenance_set_test_settings_list): ... this.
5678         (maintenance_test_settings_show_list): Rename to  ...
5679         (maintenance_show_test_settings_list): ... this.
5680         (maintenance_test_settings_cmd): Delete.
5681         (maintenance_test_settings_set_cmd): ...
5682         (maintenance_set_test_settings_cmd): ... this.
5683         (maintenance_test_settings_show_cmd): ...
5684         (maintenance_show_test_settings_cmd): ... this.
5685         (maintenance_test_settings_show_value_cmd):
5686         (maintenance_show_test_settings_value_cmd): ... this.
5687         (_initialize_maint_test_settings): No longer install the "maint
5688         test-settings" prefix command.  Rename "maint test-settings set"
5689         to "maint set test-settings", and "maint test-settings show" to
5690         "maint show test-settings".  Adjust all subcommands.
5691
5692 2019-07-03  Pedro Alves  <palves@redhat.com>
5693
5694         * maint-test-settings.c: Fix file's intro comment.  Replace all
5695         references to "test-options" with references to "test-settings",
5696         in comments.
5697
5698 2019-07-03  Pedro Alves  <palves@redhat.com>
5699
5700         * maint-test-settings.c (maintenance_test_settings_xxx)
5701         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5702         New.
5703         (maintenance_test_settings_enums): Use them.
5704         (maintenance_test_settings_enum): Default to
5705         maintenance_test_settings_xxx.
5706         (_initialize_maint_test_settings): Initialize
5707         MAINTENANCE_TEST_SETTINGS_FILENAME.
5708
5709 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5710
5711         * breakpoint.h (remove_breakpoints_inf): Change return type to
5712         void, move function documentation here.
5713         * breakpoint.c (remove_breakpoints_inf): Change return type to
5714         void, move function documentation to header.
5715
5716 2019-07-02  Pedro Alves  <palves@redhat.com>
5717
5718         * NEWS (Completion improvements): Mention "info threads".
5719         * thread.c (struct info_threads_opts, info_threads_option_defs)
5720         (make_info_threads_options_def_group): New.
5721         (info_threads_command): Use gdb::option::process_options.
5722         (info_threads_command_completer): New.
5723         (_initialize_thread): Use gdb::option::build_help to build the
5724         help text for "info threads".
5725
5726 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5727
5728         * defs.h (generic_load): Move from here...
5729         * symfile.h (generic_load): ... to here.  Rename name parameter
5730         to args.
5731         * symfile.c (generic_load): Add comment.
5732
5733 2019-07-01  Tom Tromey  <tromey@adacore.com>
5734
5735         * dwarf2read.c
5736         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5737         declaration of without_params.  Fix formatting.
5738
5739 2019-07-01  Tom Tromey  <tromey@adacore.com>
5740
5741         * ada-exp.y (find_primitive_type): Update.
5742         * ada-lang.h (ada_lookup_symbol): Update.
5743         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5744         parameter.
5745         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5746
5747 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5748
5749         PR breakpoints/24541
5750         * gdbarch.c: Regenerate.
5751         * gdbarch.h: Regenerate.
5752         * gdbarch.sh: Add 'stap_adjust_register'.
5753         * i386-tdep.c: Include '<unordered_set>'.
5754         (i386_stap_adjust_register): New function.
5755         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5756         * stap-probe.c (stap_parse_register_operand): Call
5757         'gdbarch_stap_adjust_register'.
5758
5759 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5760
5761         PR python/24742
5762         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5763         * python/python.c (do_start_initialization): Use 'xmalloc'
5764         instead of 'PyMem_Malloc'.
5765
5766 2019-06-28  Tom Tromey  <tromey@adacore.com>
5767
5768         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5769         for Ada.
5770
5771 2019-06-27  Tom Tromey  <tromey@adacore.com>
5772
5773         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5774         objfile_key.
5775         (arm_find_mapping_symbol, arm_record_special_symbol)
5776         (_initialize_arm_tdep): Update.
5777         (arm_objfile_data_free): Remove.
5778
5779 2019-06-27  Tom Tromey  <tromey@adacore.com>
5780
5781         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5782         to cp_print_static_field.
5783
5784 2019-06-26  Tom Tromey  <tromey@adacore.com>
5785
5786         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5787         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5788         declare.
5789
5790 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5791
5792         * features/aarch64-core.c (create_feature_aarch64_core):
5793         Regenerate.
5794         * features/aarch64-core.xml: Add cpsr flags.
5795
5796 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5797
5798         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5799         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5800
5801 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5802
5803         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5804         field.
5805         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5806         use.
5807         (arm_record_special_symbol): Don't insert new symbol in sorted
5808         position, push it at the end.
5809
5810 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5811
5812         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5813         (arm_mapping_symbol_s): Remove.
5814         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5815         (arm_mapping_symbol_vec): New typedef.
5816         (struct arm_per_objfile): Add constructor.
5817         <section_maps>: Change type to
5818         std::unique_ptr<arm_mapping_symbol_vec[]>.
5819         (arm_compare_mapping_symbols): Remove.
5820         (arm_find_mapping_symbol): Adjust to section_maps type change.
5821         (arm_objfile_data_free): Call delete on arm_per_objfile.
5822         (arm_record_special_symbol): Adjust to section_maps type change.
5823         Allocate arm_per_objfile with new.
5824
5825 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5826
5827         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5828         with the command prefix.
5829
5830 2019-06-25  Tom Tromey  <tom@tromey.com>
5831
5832         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5833         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5834
5835 2019-06-25  Tom Tromey  <tom@tromey.com>
5836
5837         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5838         type.
5839         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5840         protected.
5841
5842 2019-06-25  Tom Tromey  <tom@tromey.com>
5843
5844         * tui/tui-winsource.c
5845         (tui_source_window_base::set_is_exec_point_at): Add check against
5846         LOA_ADDRESS.
5847
5848 2019-06-25  Tom Tromey  <tom@tromey.com>
5849
5850         * tui/tui-source.c (tui_set_source_content): Don't check before
5851         xfree.
5852         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5853
5854 2019-06-25  Tom Tromey  <tom@tromey.com>
5855
5856         * tui/tui-winsource.h (tui_update_source_window_as_is)
5857         (tui_alloc_source_buffer, tui_line_is_displayed)
5858         (tui_addr_is_displayed): Change type of win_info.
5859         * tui/tui-winsource.c (tui_update_source_window_as_is)
5860         (tui_clear_source_content, tui_show_source_line)
5861         (tui_show_source_content, tui_source_window_base::refill)
5862         (tui_source_window_base::set_is_exec_point_at)
5863         (tui_source_window_base::set_is_exec_point_at)
5864         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5865         (tui_alloc_source_buffer, tui_line_is_displayed)
5866         (tui_addr_is_displayed): Change type of win_info.  Update.
5867         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5868         (tui_source_window_base::do_make_visible_with_new_height):
5869         Update.
5870         * tui/tui-source.c (tui_set_source_content)
5871         (tui_set_source_content_nil)
5872         (tui_source_window::do_scroll_vertical): Update.
5873         * tui/tui-layout.c (show_layout): Update.
5874         * tui/tui-disasm.c (tui_set_disassem_content)
5875         (tui_disasm_window::do_scroll_vertical): Update.
5876         * tui/tui-data.h (tui_win_content): Remove.
5877         (struct tui_gen_win_info) <content, content_size>: Remove.
5878         (struct tui_source_element): Add initializers and destructor.
5879         (union tui_which_element, struct tui_win_element): Remove.
5880         (struct tui_source_window_base) <content>: New field.
5881         (struct tui_data_window): Remove destructor.
5882         (tui_alloc_content, tui_free_win_content)
5883         (tui_free_all_source_wins_content): Don't declare.
5884         * tui/tui-data.c (tui_initialize_static_data): Update.
5885         (init_content_element, tui_alloc_content): Remove.
5886         (~tui_gen_win_info): Update.
5887         (~tui_data_window, tui_free_all_source_wins_content)
5888         (tui_free_win_content, free_content, free_content_elements):
5889         Remove.
5890
5891 2019-06-25  Tom Tromey  <tom@tromey.com>
5892
5893         * tui/tui-winsource.h (tui_clear_source_content)
5894         (tui_erase_source_content, tui_show_source_content): Change type
5895         of win_info.
5896         * tui/tui-winsource.c (tui_clear_source_content)
5897         (tui_erase_source_content, tui_show_source_content): Change type
5898         of win_info.
5899         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5900         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5901         win_info.
5902         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5903         win_info.
5904         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5905
5906 2019-06-25  Tom Tromey  <tom@tromey.com>
5907
5908         * tui/tui-winsource.c (tui_clear_source_content)
5909         (tui_source_window_base::set_is_exec_point_at): Update.
5910         * tui/tui-source.c (tui_set_source_content_nil): Update.
5911         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5912         a bool.
5913         * tui/tui-data.c (init_content_element): Update.
5914
5915 2019-06-25  Tom Tromey  <tom@tromey.com>
5916
5917         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5918         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5919         * tui/tui-layout.c (init_and_make_win): Update.
5920         * tui/tui.h (enum tui_win_type): Update.
5921         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5922         tui_win_is_auxillary.
5923         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5924         tui_win_is_auxillary.
5925
5926 2019-06-25  Tom Tromey  <tom@tromey.com>
5927
5928         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5929         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5930         (tui_delete_data_content_windows, tui_display_all_data)
5931         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5932         Update.
5933         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5934         * tui/tui-regs.c (tui_last_regs_line_no)
5935         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5936         (tui_show_registers): Update.
5937         (tui_show_register_group): Return void.  Update.
5938         (tui_display_registers_from, tui_display_reg_element_at_line)
5939         (tui_display_registers_from_line, tui_check_register_values):
5940         Update.
5941         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5942         member.
5943         (struct tui_data_window) <regs_content>: Now a std::vector.
5944         <regs_content_count>: Remove.
5945         (tui_add_content_elements, tui_free_data_content): Don't declare.
5946         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5947         (init_content_element): Remove DATA_WIN case.  Add assert.
5948         (tui_add_content_elements): Remove.
5949         (tui_data_window): Update.
5950         (tui_free_data_content): Remove.
5951         (free_content_elements): Remove DATA_WIN case.
5952
5953 2019-06-25  Tom Tromey  <tom@tromey.com>
5954
5955         * tui/tui-data.c (tui_data_item_window): Update.
5956         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5957         * tui/tui-windata.c (tui_display_all_data)
5958         (tui_display_data_from_line): Update.
5959         (tui_check_data_values): Remove.
5960         * tui/tui-regs.c (tui_show_register_group)
5961         (tui_display_reg_element_at_line): Update.
5962         * tui/tui-hooks.c (tui_register_changed)
5963         (tui_refresh_frame_and_register_information): Call
5964         tui_check_register_values.
5965         * tui/tui-data.h (struct tui_data_window) <data_content,
5966         data_content_count, data_type>: Remove.
5967         (enum tui_data_type): Remove.
5968
5969         * tui/tui-data.c (tui_data_window::clear_detail)
5970         (~tui_data_window): Update.
5971
5972 2019-06-25  Tom Tromey  <tom@tromey.com>
5973
5974         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5975         declare.
5976         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5977         Rename from tui_first_data_item_displayed.  Update.
5978         (tui_data_window::refresh_all)
5979         (tui_data_window::do_scroll_vertical): Update.
5980         * tui/tui-data.h (struct tui_data_window)
5981         <first_data_item_displayed>: Declare new method.
5982
5983 2019-06-25  Tom Tromey  <tom@tromey.com>
5984
5985         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5986         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5987         contents...
5988         (tui_initialize_static_data): ...here.
5989
5990 2019-06-25  Tom Tromey  <tom@tromey.com>
5991
5992         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5993         (tui_display_registers_from, tui_check_register_values): Update.
5994         (tui_display_register): Remove win_info parameter; update.
5995         (tui_get_register): Change type of parameters.
5996         * tui/tui-data.h (struct tui_data_element): Remove.
5997         (union tui_which_element) <data>: Remove.
5998         <data_window>: Change type.
5999         (struct tui_data_item_window): New.
6000         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6001         case.  Add assert.
6002         (~tui_data_item_window): New destructor.
6003         (free_content_elements): Remove DATA_ITEM_WIN case.
6004
6005 2019-06-25  Tom Tromey  <tom@tromey.com>
6006
6007         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6008         Remove.
6009
6010 2019-06-25  Tom Tromey  <tom@tromey.com>
6011
6012         * tui/tui-data.h (struct tui_command_element): Remove.
6013         (union tui_which_element) <command>: Remove.
6014         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
6015         assert.
6016         (free_content_elements): Remove CMD_WIN case.
6017
6018 2019-06-25  Tom Tromey  <tom@tromey.com>
6019
6020         * tui/tui-layout.c (tui_set_layout): Update.
6021         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6022         * tui/tui-data.c (layout_def): Update.
6023
6024 2019-06-25  Tom Tromey  <tom@tromey.com>
6025
6026         * tui/tui-wingeneral.c (tui_refresh_all): Update.
6027         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6028         (tui_source_window_base::set_new_height): Update.
6029         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6030         Update.
6031         (tui_set_locator_fullname, tui_set_locator_info)
6032         (tui_show_frame_info): Update.
6033         * tui/tui-source.c (tui_set_source_content)
6034         (tui_source_is_displayed): Update.
6035         * tui/tui-layout.c (show_source_disasm_command, show_data)
6036         (show_source_or_disasm_and_command): Update.
6037         * tui/tui-disasm.c (tui_set_disassem_content)
6038         (tui_get_begin_asm_address): Update.
6039         * tui/tui-data.h (struct tui_locator_element): Remove.
6040         (union tui_which_element) <locator>: Remove.
6041         (struct tui_locator_window): New.
6042         (tui_locator_win_info_ptr): Change return type.
6043         * tui/tui-data.c (_locator): Change type.
6044         (tui_locator_win_info_ptr): Change return type.
6045         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
6046         (tui_alloc_content): Add assert.
6047
6048 2019-06-25  Tom Tromey  <tom@tromey.com>
6049
6050         * tui/tui-winsource.c
6051         (tui_exec_info_window::maybe_allocate_content): New method.
6052         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6053         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6054         (make_source_or_disasm_window): Add cast.
6055         * tui/tui-data.h (union tui_which_element) <simple_string>:
6056         Remove.
6057         (struct tui_source_info): New.
6058         (struct tui_source_window_base) <execution_info>: Change type.
6059         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6060         case, and add assert.
6061         (tui_alloc_content): Add assert.
6062
6063 2019-06-25  Tom Tromey  <tom@tromey.com>
6064
6065         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6066         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6067         * tui/tui-data.c (tui_alloc_win_info): Remove.
6068
6069 2019-06-25  Tom Tromey  <tom@tromey.com>
6070
6071         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6072         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6073         can_highlight.
6074
6075 2019-06-25  Tom Tromey  <tom@tromey.com>
6076
6077         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6078         make_visible_with_new_height method.
6079         (tui_win_info::make_visible_with_new_height): New method.
6080         (tui_source_window_base::do_make_visible_with_new_height)
6081         (tui_data_window::do_make_visible_with_new_height)
6082         (tui_cmd_window::do_make_visible_with_new_height): New methods.
6083         (make_visible_with_new_height): Remove.
6084         (tui_resize_all, tui_adjust_win_heights): Use
6085         make_visible_with_new_height method.
6086         * tui/tui-data.h (struct tui_win_info)
6087         <do_make_visible_with_new_height, make_visible_with_new_height>:
6088         New methods.
6089         (struct tui_source_window_base, struct tui_data_window)
6090         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6091         methods.
6092
6093 2019-06-25  Tom Tromey  <tom@tromey.com>
6094
6095         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6096         method.
6097         (update_tab_width): Call update_tab_width method.
6098         * tui/tui-data.h (struct tui_win_info)
6099         (struct tui_source_window_base) <update_tab_width>: New methods.
6100
6101 2019-06-25  Tom Tromey  <tom@tromey.com>
6102
6103         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6104         parameter.
6105         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6106         parameter.
6107         (tui_gen_win_info::make_visible): Update.
6108         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6109         parameter.
6110         * tui/tui-data.h (enum tui_box): New enum.
6111         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6112
6113 2019-06-25  Tom Tromey  <tom@tromey.com>
6114
6115         * tui/tui-layout.c (make_source_or_disasm_window): Always use
6116         init_and_make_win for EXEC_INFO_WIN.
6117         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6118         longer inline.
6119         (struct tui_win_info) <~tui_win_info>: Inline.
6120         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6121         Don't declare.
6122         * tui/tui-data.c (source_win, disasm_win): Remove globals.
6123         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6124         Remove.
6125         (tui_initialize_static_data): Update.
6126         (~tui_gen_win_info): Handle more cleanup here.
6127         (~tui_source_window_base): Delete "execution_info".
6128         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6129
6130 2019-06-25  Tom Tromey  <tom@tromey.com>
6131
6132         * tui/tui-layout.c (make_command_window): Don't set
6133         can_highlight.
6134         (show_source_disasm_command): Call the reset method.
6135         (show_data): Don't set can_highlight.  Call the reset method.
6136         (tui_gen_win_info::reset): Rename from init_gen_win_info
6137         (init_and_make_win): Simplify.  Return tui_gen_win_info.
6138         (show_source_or_disasm_and_command): Call the reset method.
6139         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6140         (struct tui_cmd_window): Set can_highlight.
6141
6142 2019-06-25  Tom Tromey  <tom@tromey.com>
6143
6144         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6145         from make_visible.
6146         (tui_make_visible, tui_make_invisible): Rewrite.
6147         (tui_win_info::make_visible): Remove.
6148         (tui_source_window_base::make_visible): Update.
6149         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6150         method.  Moved from...
6151         (struct tui_win_info) <make_visible>: ...here.
6152
6153 2019-06-25  Tom Tromey  <tom@tromey.com>
6154
6155         * tui/tui-winsource.c
6156         (tui_source_window_base::do_scroll_horizontal): Remove direction
6157         parameter.
6158         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6159         direction parameter.
6160         * tui/tui-win.c (tui_win_info::forward_scroll)
6161         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6162         (tui_win_info::right_scroll): Update.
6163         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6164         direction parameter.
6165         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6166         direction parameter.
6167         * tui/tui-data.h (enum tui_scroll_direction): Remove.
6168         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6169         Remove direction parameter.
6170         (struct tui_source_window_base, struct tui_source_window)
6171         (struct tui_disasm_window, struct tui_data_window)
6172         (struct tui_cmd_window): Update.
6173
6174 2019-06-25  Tom Tromey  <tom@tromey.com>
6175
6176         * tui/tui-winsource.h (tui_set_exec_info_content)
6177         (tui_show_exec_info_content, tui_erase_exec_info_content)
6178         (tui_clear_exec_info_content, tui_update_exec_info): Change
6179         argument to tui_source_window_base.
6180         * tui/tui-winsource.c (tui_set_exec_info_content)
6181         (tui_show_exec_info_content, tui_erase_exec_info_content)
6182         (tui_clear_exec_info_content, tui_update_exec_info): Change
6183         argument to tui_source_window_base.
6184
6185 2019-06-25  Tom Tromey  <tom@tromey.com>
6186
6187         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6188         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6189
6190 2019-06-25  Tom Tromey  <tom@tromey.com>
6191
6192         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6193         check.
6194
6195 2019-06-25  Tom Tromey  <tom@tromey.com>
6196
6197         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6198         type to void.
6199         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6200         type to void.
6201         * tui/tui-source.c (tui_set_source_content): Update.
6202         * tui/tui-disasm.c (tui_set_disassem_content): Update.
6203
6204 2019-06-25  Tom Tromey  <tom@tromey.com>
6205
6206         * tui/tui-win.c (window_name_completer, tui_set_focus)
6207         (tui_all_windows_info): Use name method.
6208         * tui/tui-data.h (struct tui_gen_win_info)
6209         (struct tui_source_window, struct tui_disasm_window)
6210         (struct tui_data_window, struct tui_cmd_window) <name>: New
6211         method.
6212         (tui_win_name): Don't declare.
6213         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6214         (tui_win_name): Remove.
6215
6216 2019-06-25  Tom Tromey  <tom@tromey.com>
6217
6218         * tui/tui-winsource.h (tui_update_source_window)
6219         (tui_update_source_window_as_is): Change parameter type.
6220         * tui/tui-winsource.c (tui_update_source_window): Change win_info
6221         to be a tui_source_window_base.
6222         (tui_update_source_window_as_is): Likewise.
6223         * tui/tui-win.c (make_visible_with_new_height): Update.
6224
6225 2019-06-25  Tom Tromey  <tom@tromey.com>
6226
6227         * tui/tui-winsource.c (tui_erase_source_content)
6228         (tui_show_source_content, tui_show_exec_info_content)
6229         (tui_erase_exec_info_content): Use refresh_window method.
6230         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
6231         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
6232         from tui_refresh_win.
6233         (tui_data_window::refresh_window): New method.
6234         (tui_win_info::refresh, tui_source_window_base::refresh)
6235         (tui_refresh_all): Use refresh_window method.
6236         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
6237         method.
6238         * tui/tui-regs.c (tui_display_register): Call refresh_window
6239         method.
6240         * tui/tui-layout.c (show_source_disasm_command)
6241         (show_source_or_disasm_and_command): Call refresh_window method.
6242         * tui/tui-data.h (struct tui_gen_win_info)
6243         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
6244         New method.
6245
6246 2019-06-25  Tom Tromey  <tom@tromey.com>
6247
6248         * tui/tui.c (tui_rl_other_window, tui_enable)
6249         (tui_is_window_visible, tui_get_command_dimension): Update.
6250         * tui/tui-winsource.c (tui_update_source_window_as_is)
6251         (tui_clear_source_content, tui_erase_source_content)
6252         (tui_show_source_line, tui_source_window_base::refill)
6253         (tui_source_window_base::do_scroll_horizontal)
6254         (tui_source_window_base::set_is_exec_point_at)
6255         (tui_update_breakpoint_info, tui_set_exec_info_content)
6256         (tui_alloc_source_buffer, tui_line_is_displayed)
6257         (tui_addr_is_displayed): Update.
6258         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6259         (tui_check_and_display_highlight_if_needed)
6260         (tui_win_info::make_visible, tui_win_info::refresh)
6261         (tui_refresh_all): Update.
6262         * tui/tui-windata.c (tui_first_data_item_displayed)
6263         (tui_delete_data_content_windows, tui_erase_data_content)
6264         (tui_display_all_data, tui_data_window::refresh_all)
6265         (tui_check_data_values): Update.
6266         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
6267         (tui_set_win_focus_to, tui_win_info::forward_scroll)
6268         (tui_win_info::backward_scroll, tui_refresh_all_win)
6269         (tui_resize_all, tui_set_focus, tui_all_windows_info)
6270         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
6271         (tui_source_window_base::set_new_height)
6272         (tui_data_window::set_new_height)
6273         (make_invisible_and_set_new_height)
6274         (make_visible_with_new_height, new_height_ok)
6275         (parse_scrolling_args): Update.
6276         * tui/tui-stack.c (tui_show_frame_info): Update.
6277         * tui/tui-source.c (tui_set_source_content)
6278         (tui_set_source_content_nil, tui_source_is_displayed)
6279         (tui_source_window::do_scroll_vertical): Update.
6280         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6281         (tui_display_registers_from, tui_display_reg_element_at_line)
6282         (tui_check_register_values, tui_reg_command): Update.
6283         * tui/tui-layout.c (tui_default_win_height)
6284         (show_source_disasm_command, show_data, init_and_make_win)
6285         (show_source_or_disasm_and_command): Update.
6286         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6287         (tui_redisplay_readline, tui_mld_flush)
6288         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6289         (tui_getc): Update.
6290         * tui/tui-disasm.c (tui_set_disassem_content)
6291         (tui_disasm_window::do_scroll_vertical): Update.
6292         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6293         Now virtual.
6294         (struct tui_win_info): Derive from tui_gen_win_info.
6295         <~tui_win_info>: Mark as override.
6296         <generic>: Remove member.
6297         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6298         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6299         (~tui_data_window, ~tui_win_info)
6300         (tui_free_all_source_wins_content): Update.
6301         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6302
6303 2019-06-25  Tom Tromey  <tom@tromey.com>
6304
6305         * tui/tui-layout.c (init_and_make_win): Use new.
6306         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6307         destructor, initializers.
6308         (tui_alloc_generic_win_info): Don't declare.
6309         * tui/tui-data.c (_locator): Add argument to constructor.
6310         (source_win, disasm_win): New globals.
6311         (exec_info): Remove.
6312         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6313         Update.
6314         (tui_alloc_generic_win_info): Remove.
6315         (init_content_element): Use new.
6316         (tui_win_info::tui_win_info): Update.
6317         (free_content_elements) <case DATA_WIN>: Use delete.
6318
6319 2019-06-25  Tom Tromey  <tom@tromey.com>
6320
6321         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6322         * tui/tui-windata.c (tui_first_data_item_displayed)
6323         (tui_delete_data_content_windows): Update.
6324         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6325         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6326         (tui_display_registers_from, tui_check_register_values): Update.
6327         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6328         pointer.
6329         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6330         window.
6331         (tui_free_data_content): Update.
6332         (free_content_elements) <case DATA_WIN>: Free the window.
6333
6334 2019-06-25  Tom Tromey  <tom@tromey.com>
6335
6336         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6337         Update.
6338         * tui/tui-layout.c (make_command_window)
6339         (show_source_disasm_command, show_data, init_and_make_win)
6340         (show_source_or_disasm_and_command): Update.
6341         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6342         method.
6343         <can_highight, is_highlighted>: Now bool.
6344         (tui_set_win_highlight): Don't declare.
6345         * tui/tui-data.c (tui_set_win_highlight): Remove.
6346
6347 2019-06-25  Tom Tromey  <tom@tromey.com>
6348
6349         * tui/tui-wingeneral.c (make_visible): Remove check of window
6350         type.
6351
6352 2019-06-25  Tom Tromey  <tom@tromey.com>
6353
6354         * tui/tui-win.c (tui_win_info::max_height)
6355         (tui_cmd_window::max_height): New methods.
6356         (new_height_ok): Call max_height.
6357         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6358         <max_height>: New method.
6359
6360 2019-06-25  Tom Tromey  <tom@tromey.com>
6361
6362         * tui/tui-win.c (tui_source_window_base::set_new_height)
6363         (tui_data_window::set_new_height): New methods.
6364         (make_invisible_and_set_new_height): Call set_new_height method.
6365         * tui/tui-data.h (struct tui_win_info)
6366         (struct tui_source_window_base, struct tui_data_window)
6367         <set_new_height>: New method.
6368
6369 2019-06-25  Tom Tromey  <tom@tromey.com>
6370
6371         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6372         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6373         tui_refresh_data_win.
6374         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6375         method.
6376         (tui_refresh_all_win): Call the refresh_all method.
6377         (tui_set_focus): Likewise.
6378         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6379         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6380         Likewise.
6381
6382 2019-06-25  Tom Tromey  <tom@tromey.com>
6383
6384         * tui/tui-winsource.h (tui_refill_source_window)
6385         (tui_set_is_exec_point_at): Don't declare.
6386         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6387         (tui_source_window_base::refill): Rename from
6388         tui_refill_source_window.
6389         (tui_source_window_base::do_scroll_horizontal): Update.
6390         (tui_source_window_base::set_is_exec_point_at): Rename from
6391         tui_set_is_exec_point_at.
6392         (tui_update_all_breakpoint_info): Update.
6393         * tui/tui-stack.c (tui_show_frame_info): Update.
6394         * tui/tui-layout.c (show_data): Add cast.
6395         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6396         * tui/tui-data.h (struct tui_source_window_base) <refill,
6397         set_is_exec_point_at>: New methods.
6398         (tui_source_windows, tui_add_to_source_windows): Update types.
6399         (tui_add_to_source_windows): Remove redundant declaration.
6400         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6401         (tui_source_windows): Change return type.
6402         (tui_clear_source_windows_detail): Update.
6403         (tui_add_to_source_windows): Change type of parameter.
6404         (tui_free_all_source_wins_content): Update.
6405
6406 2019-06-25  Tom Tromey  <tom@tromey.com>
6407
6408         * tui/tui-wingeneral.c (tui_win_info::refresh)
6409         (tui_source_window_base::refresh): New methods.
6410         (tui_refresh_all): Call the refresh method.
6411         * tui/tui-data.h (struct tui_win_info)
6412         (struct tui_source_window_base) <refresh>: New method.
6413
6414 2019-06-25  Tom Tromey  <tom@tromey.com>
6415
6416         * tui/tui.h (tui_is_window_visible): Return bool.
6417         * tui/tui.c (tui_is_window_visible): Return bool.
6418         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6419         (tui_make_visible, tui_make_invisible)
6420         (tui_win_info::make_visible)
6421         (tui_source_window_base::make_visible, make_all_visible)
6422         (tui_make_all_visible, tui_make_all_invisible): Update.
6423         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6424         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6425         bool.
6426         (struct tui_win_info, struct tui_source_window_base)
6427         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6428         * tui/tui-data.c (tui_init_generic_part): Update.
6429
6430 2019-06-25  Tom Tromey  <tom@tromey.com>
6431
6432         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6433         (tui_source_window_base::make_visible): New methods.
6434         (make_all_visible): Make method call.
6435         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6436         (struct tui_source_window_base, struct tui_cmd_window): Override
6437         make_visible.
6438         (tui_win_is_source_type): Don't declare.
6439         * tui/tui-data.c (tui_win_is_source_type): Remove.
6440
6441 2019-06-25  Tom Tromey  <tom@tromey.com>
6442
6443         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6444         NULL check.
6445
6446 2019-06-25  Tom Tromey  <tom@tromey.com>
6447
6448         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6449         Inline constructor.  Add initializers for members.
6450         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6451         constructors; now inline in class.
6452
6453 2019-06-25  Tom Tromey  <tom@tromey.com>
6454
6455         * tui/tui-regs.c (tui_show_registers): Update.
6456         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6457         bool.
6458         * tui/tui-data.c (tui_data_window::clear_detail)
6459         (tui_data_window): Update.
6460
6461 2019-06-25  Tom Tromey  <tom@tromey.com>
6462
6463         * tui/tui-windata.c (tui_display_all_data)
6464         (tui_display_data_from_line, tui_display_data_from)
6465         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6466         Update.
6467         * tui/tui-regs.c (tui_last_regs_line_no)
6468         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6469         (tui_show_registers, tui_show_register_group)
6470         (tui_display_registers_from, tui_display_reg_element_at_line)
6471         (tui_display_registers_from_line, tui_check_register_values)
6472         (tui_reg_next, tui_reg_prev): Update.
6473         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6474         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6475         tui_data_window.
6476         (struct tui_win_info) <detail>: Remove.  Add new fields from
6477         tui_data_info.
6478         (TUI_DATA_WIN): Add cast.
6479         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6480         (~tui_data_window): Simplify.
6481
6482 2019-06-25  Tom Tromey  <tom@tromey.com>
6483
6484         * tui/tui-layout.c (show_source_disasm_command)
6485         (show_source_or_disasm_and_command): Update.
6486         * tui/tui-io.c (update_cmdwin_start_line)
6487         (tui_redisplay_readline): Update.
6488         * tui/tui-data.h (struct tui_command_info): Remove.
6489         (struct tui_win_info) <detail>: Remove command_info member.
6490         (struct tui_data_window) <start_line>: New member, from
6491         tui_command_info.
6492         (TUI_CMD_WIN): Add casts.
6493
6494 2019-06-25  Tom Tromey  <tom@tromey.com>
6495
6496         * tui/tui-winsource.c (tui_update_source_window)
6497         (tui_refill_source_window)
6498         (tui_source_window_base::do_scroll_horizontal)
6499         (tui_update_breakpoint_info, tui_set_exec_info_content)
6500         (tui_show_exec_info_content, tui_erase_exec_info_content)
6501         (tui_clear_exec_info_content): Update.
6502         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6503         Update.
6504         * tui/tui-win.c (make_invisible_and_set_new_height)
6505         (make_visible_with_new_height): Update.
6506         * tui/tui-source.c (tui_set_source_content)
6507         (tui_show_symtab_source): Update.
6508         * tui/tui-layout.c (extract_display_start_addr)
6509         (show_source_disasm_command, show_data)
6510         (make_source_or_disasm_window)
6511         (show_source_or_disasm_and_command): Update.
6512         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6513         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6514         "gdbarch".
6515         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6516         to tui_source_window_base.
6517         (struct tui_win_info) <detail>: Remove source_info member.
6518         (struct tui_source_window_base) <has_locator>: Inline.
6519         Move contents from tui_source_info; rename has_locator member to
6520         m_has_locator.
6521         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6522         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6523         header file.
6524         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6525         Simplify.
6526         (tui_free_all_source_wins_content): Cast to
6527         tui_source_window_base.
6528
6529 2019-06-25  Tom Tromey  <tom@tromey.com>
6530
6531         * tui/tui-win.c (make_invisible_and_set_new_height)
6532         (make_visible_with_new_height): Call has_locator method.
6533         * tui/tui-layout.c (show_source_disasm_command, show_data)
6534         (show_source_or_disasm_and_command): Update for bool change.
6535         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6536         (tui_win_info) <has_locator>: New method.
6537         (struct tui_source_window_base) <has_locator>: New method.
6538         (tui_win_has_locator): Don't declare.
6539         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6540         from tui_win_has_locator.
6541         (tui_source_window_base): Use false, not FALSE.
6542
6543 2019-06-25  Tom Tromey  <tom@tromey.com>
6544
6545         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6546         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6547         clear_detail method directly.
6548         (tui_clear_win_detail): Remove.
6549
6550 2019-06-25  Tom Tromey  <tom@tromey.com>
6551
6552         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6553         "this", not TUI_DISASM_WIN.
6554
6555 2019-06-25  Tom Tromey  <tom@tromey.com>
6556
6557         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6558         declare.
6559         * tui/tui-winsource.c
6560         (tui_source_window_base::do_scroll_horizontal): Rename from
6561         tui_horizontal_source_scroll.
6562         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6563         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6564         from tui_vertical_data_scroll.
6565         * tui/tui-win.h (tui_scroll): Don't declare.
6566         * tui/tui-win.c (tui_win_info::forward_scroll)
6567         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6568         (tui_win_info::right_scroll): Rename and update.
6569         (tui_scroll_forward_command, tui_scroll_backward_command)
6570         (tui_scroll_left_command, tui_scroll_right_command): Update.
6571         (tui_scroll): Remove.
6572         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6573         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6574         from tui_vertical_source_scroll.
6575         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6576         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6577         from tui_vertical_disassem_scroll.
6578         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6579         do_scroll_horizontal>: New methods.
6580         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6581         Likewise.
6582         (struct tui_source_window_base): Add do_scroll_horizontal.
6583         (struct tui_source_window, struct tui_disasm_window): Add
6584         do_scroll_vertical.
6585         (struct tui_data_window, struct tui_cmd_window): Add
6586         do_scroll_horizontal and do_scroll_vertical.
6587         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6588
6589 2019-06-25  Tom Tromey  <tom@tromey.com>
6590
6591         * tui/tui-data.h (struct tui_source_window_base): New struct.
6592         (struct tui_source_window): Derive from tui_source_window_base.
6593         (struct tui_disasm_window): New struct.
6594         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6595         from tui_source_window::clear_detail.
6596         (tui_source_window_base): Rename from tui_source_window.
6597         (~tui_source_window_base): Rename from ~tui_source_window.
6598         (tui_alloc_win_info): Create a tui_disasm_window.
6599
6600 2019-06-25  Tom Tromey  <tom@tromey.com>
6601
6602         * tui/tui-data.h (struct tui_source_window)
6603         (struct tui_data_window): Declare destructors.
6604         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6605         destructors.
6606         (tui_win_info): Simplify.
6607
6608 2019-06-25  Tom Tromey  <tom@tromey.com>
6609
6610         * tui/tui-winsource.c (tui_display_main)
6611         (tui_update_source_windows_with_addr)
6612         (tui_update_all_breakpoint_info): Update.
6613         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6614         (new_height_ok, parse_scrolling_args): Update.
6615         * tui/tui-stack.c (tui_show_frame_info): Update.
6616         * tui/tui-data.h (struct tui_list): Remove.
6617         (tui_source_windows): Return a reference to a std::vector.
6618         * tui/tui-data.c (source_windows): Now a std::vector.
6619         (tui_source_windows): Change return type.
6620         (tui_clear_source_windows): Rewrite.
6621         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6622         (tui_free_all_source_wins_content): Rewrite.
6623
6624 2019-06-25  Tom Tromey  <tom@tromey.com>
6625
6626         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6627         (struct tui_data_window, struct tui_cmd_window): Declare
6628         clear_detail method.
6629         * tui/tui-data.c (tui_source_window::clear_detail)
6630         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6631         methods.
6632         (tui_clear_win_detail): Simplify.
6633
6634 2019-06-25  Tom Tromey  <tom@tromey.com>
6635
6636         * tui/tui-layout.c (make_source_window, make_disasm_window)
6637         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6638         Return the new window.
6639         (show_source_disasm_command, show_data)
6640         (show_source_or_disasm_and_command): Update.
6641
6642 2019-06-25  Tom Tromey  <tom@tromey.com>
6643
6644         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6645         parameter.  Return the new window.
6646         (show_source_disasm_command): Update and remove NULL check.
6647         (show_source_or_disasm_and_command): Update.
6648
6649 2019-06-25  Tom Tromey  <tom@tromey.com>
6650
6651         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6652
6653 2019-06-25  Tom Tromey  <tom@tromey.com>
6654
6655         * tui/tui-data.h (struct tui_win_info): Make constructor
6656         protected.  Make destructor virtual.  Add initializers.
6657         (tui_source_window, tui_data_window, tui_cmd_window): New
6658         classes.
6659         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6660         constructor.  Add "type" parameter.
6661         (tui_source_window, tui_data_window, tui_cmd_window): New
6662         constructors.
6663         (tui_alloc_win_info): Instantiate the appropriate subclass.
6664
6665 2019-06-25  Tom Tromey  <tom@tromey.com>
6666
6667         * tui/tui-win.c (tui_resize_all): Use delete.
6668         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6669         destructor.
6670         (tui_free_window): Don't declare.
6671         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6672         Update.
6673
6674 2019-06-25  Tom Tromey  <tom@tromey.com>
6675
6676         * tui/tui-data.h (struct tui_win_info): Add constructor.
6677         * tui/tui-data.c (tui_alloc_win_info): Use new.
6678         (tui_free_window): Use delete.
6679
6680 2019-06-22  Tom Tromey  <tom@tromey.com>
6681
6682         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6683         declare.
6684         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6685
6686 2019-06-22  Tom Tromey  <tom@tromey.com>
6687
6688         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6689         declare.
6690         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6691
6692 2019-06-22  Tom de Vries  <tdevries@suse.de>
6693
6694         * dwarf2read.c (create_addrmap_from_aranges)
6695         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6696         instead of '%zu'.
6697
6698 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6699
6700         * dwarf2read.h (dwarf2_section_info_def): Remove.
6701         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6702         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6703         std::vector<dwarf2_section_info>.
6704         (struct dwo_file) <~dwo_file>: Remove.
6705         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6706         types field.
6707         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6708         (dwarf2_read_debug_names): Likewise.
6709         (create_debug_types_hash_table): Change parameter type to
6710         array_view, adjust code accordingly.
6711         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6712         (partial_die_info::fixup): Likewise.
6713         (determine_prefix): Likewise.
6714         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6715
6716 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6717
6718         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6719         gdb_bfd_ref_ptr.
6720         <~dwo_file>: Remove call to gdb_bfd_unref.
6721         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6722         gdb_bfd_ref_ptr::get.
6723
6724 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6725
6726         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6727         type to htab_up.
6728         * dwarf2read.c (struct dwo_file): Initialize fields.
6729         <~dwo_file>: New.
6730         (free_dwo_file): Remove, move content to ~dwo_file.
6731         (struct dwo_file_deleter): Remove.
6732         (dwo_file_up>: Remove custom deleter.
6733         (free_dwo_files): Remove.
6734         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6735         dwo_files.
6736         (process_skeletonless_type_units): Call unique_ptr::get.
6737         (allocate_dwo_file_hash_table): Add deleter to created hash
6738         table.  Change return type to htab_up.
6739         (lookup_dwo_file_slot): Don't memset dwo_file, call
6740         unique_ptr::get.
6741         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6742         (create_dwo_unit_in_dwp_v2): Likewise.
6743         (open_and_init_dwo_file): Likewise.
6744         (free_dwo_file_from_slot): Remove.
6745
6746 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6747
6748         * dwarf2read.h (struct dwarf2_section_info) <readin,
6749         is_virtual>: Change type to bool.
6750         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6751         true instead of 1.
6752
6753 2019-06-19  Tom Tromey  <tom@tromey.com>
6754
6755         * tui/tui-data.h (tui_init_content_element): Don't declare.
6756
6757 2019-06-19  Tom Tromey  <tom@tromey.com>
6758
6759         * tui/tui-data.h (tui_init_win_info): Don't declare.
6760
6761 2019-06-19  Tom de Vries  <tdevries@suse.de>
6762
6763         * dwarf2read.h (abstract_to_concrete): Change type to
6764         std::unordered_map<sect_offset, std::vector<sect_offset>,
6765         gdb::hash_enum<sect_offset>>.
6766
6767 2019-06-19  Tom Tromey  <tromey@adacore.com>
6768
6769         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6770         EVAL_AVOID_SIDE_EFFECTS specially.
6771
6772 2019-06-19  Tom Tromey  <tromey@adacore.com>
6773
6774         * source-cache.c (highlighter): New global.
6775         (source_cache::get_source_lines): Create a highlighter on demand.
6776
6777 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6778
6779         * defs.h (deprecated_interactive_hook): Delete declaration.
6780         * interps.c (clear_interpreter_hooks): Remove use of
6781         deprecated_interactive_hook.
6782         * top.c (deprecated_interactive_hook): Delete definition.
6783         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6784
6785 2019-06-18  Tom de Vries  <tdevries@suse.de>
6786
6787         PR gdb/24515
6788         * dwarf2read.h (abstract_to_concrete): Change type from
6789         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6790         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6791         * dwarf2read.c (read_variable): Update.
6792         (dwarf2_fetch_die_loc_sect_off): Update.
6793
6794 2019-06-17  Tom de Vries  <tdevries@suse.de>
6795
6796         PR gdb/24617
6797         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6798         accessing parent[parent_len - 1].
6799
6800 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6801
6802         PR gdb/24364
6803         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6804         call dtrace_process_dof with NULL dof.
6805
6806 2019-06-16  Tom de Vries  <tdevries@suse.de>
6807
6808         PR gdb/24445
6809         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6810
6811 2019-06-16  Tom Tromey  <tom@tromey.com>
6812
6813         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6814         (make_all_visible): Use address of member.
6815
6816 2019-06-16  Tom Tromey  <tom@tromey.com>
6817
6818         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6819         (tui_free_window, free_content, free_content_elements): Remove
6820         unnecessary cast.
6821         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6822         cast.
6823         * tui/tui-regs.c (tui_show_register_group)
6824         (tui_display_registers_from, tui_display_reg_element_at_line):
6825         Remove unnecessary cast.
6826
6827 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6828
6829         * linux-nat.c (normal_mask): Delete.
6830         (_initialize_linux_nat): Don't initialise normal_mask.
6831
6832 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6833
6834         PR gdb/24445
6835         * dwarf-index-write.h (write_psymtabs_to_index): Add
6836         dwz_basename parameter.
6837         * dwarf-index-write.c (write_gdbindex): Move file writing to
6838         write_gdbindex_1.  Change return type void.
6839         (assert_file_size): Move up, remove filename parameter.
6840         (write_gdbindex_1): New function.
6841         (write_debug_names): Change return type to void, call
6842         assert_file_size.
6843         (struct index_wip_file): New struct.
6844         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6845         file logic to index_wip_file.  Write index for dwz file if
6846         needed.
6847         (save_gdb_index_command): Pass basename of dwz file, if present.
6848         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6849         build-id of dwz file, if present.
6850         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6851         (dwarf2_get_dwz_file): Likewise.
6852         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6853         (dwarf2_get_dwz_file): Likewise.
6854
6855 2019-06-16  Tom Tromey  <tom@tromey.com>
6856
6857         * coffread.c (process_coff_symbol): Use xstrdup.
6858         * value.c (create_internalvar): Use xstrdup.
6859
6860 2019-06-16  Tom Tromey  <tom@tromey.com>
6861
6862         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6863         * breakpoint.c (stopin_command, stopat_command)
6864         (until_break_command, decode_location_default): Remove unnecessary
6865         cast.
6866         * utils.c (subset_compare): Remove unnecessary cast.
6867         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6868         cast.
6869         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6870         cast.
6871         * infcmd.c (path_command): Remove unnecessary cast.
6872         * coffread.c (decode_type): Remove unnecessary cast.
6873         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6874         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6875         * tui/tui-stack.c (tui_show_locator_content)
6876         (tui_show_frame_info): Remove unnecessary cast.
6877         * tui/tui-win.c (tui_scroll_forward_command)
6878         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6879         (parse_scrolling_args): Remove unnecessary cast.
6880         * tui/tui-data.c (init_win_info, tui_del_window)
6881         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6882         (free_content_elements): Remove unnecessary cast.
6883         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6884         unnecessary cast.
6885         * tui/tui-source.c (tui_set_source_content)
6886         (tui_vertical_source_scroll): Remove unnecessary cast.
6887         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6888         cast.
6889         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6890         * tui/tui-regs.c (tui_display_registers_from)
6891         (tui_display_register): Remove unnecessary cast.
6892         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6893         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6894         (make_visible): Remove unnecessary cast.
6895         * tui/tui-winsource.c (tui_erase_source_content)
6896         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6897         unnecessary cast.
6898         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6899         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6900         * stabsread.c (read_type, read_array_type, read_range_type):
6901         Remove unnecessary cast.
6902         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6903         (parse_symbol, parse_type, upgrade_type, parse_external)
6904         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6905         unnecessary cast.
6906         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6907
6908 2019-06-16  Tom Tromey  <tom@tromey.com>
6909
6910         * tui/tui-data.c (tui_alloc_generic_win_info)
6911         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6912         checks.
6913
6914 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6915             Andrew Burgess  <andrew.burgess@embecosm.com>
6916
6917         * f-typeprint.c (f_print_type): Don't return early for not
6918         associated or not allocated types.
6919         (f_type_print_varspec_suffix): Add print_rank parameter and print
6920         ranks of array types in case they dangling.
6921         (f_type_print_base): Add print_rank parameter.
6922
6923 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6924
6925         * NEWS: Mention new MI commands.
6926         * break-catch-throw.c (enum exception_event_kind): Move to
6927         breakpoint.h.
6928         (print_mention_exception_catchpoint): Output text as a single
6929         message.
6930         (catch_exception_command_1): Rename to...
6931         (catch_exception_event): ...this, make non-static, update header
6932         command, and change some parameter types.
6933         (catch_catch_command): Update for changes to
6934         catch_exception_command_1.
6935         (catch_throw_command): Likewise.
6936         (catch_rethrow_command): Likewise.
6937         * breakpoint.c (enum exception_event_kind): Delete.
6938         * breakpoint.h (enum exception_event_kind): Moved here from
6939         break-catch-throw.c.
6940         (catch_exception_event): Declare.
6941         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6942         (mi_cmd_catch_throw): New function.
6943         (mi_cmd_catch_rethrow): New function.
6944         (mi_cmd_catch_catch): New function.
6945         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6946         'catch-catch' entries.
6947         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6948         (mi_cmd_catch_rethrow): Declare.
6949         (mi_cmd_catch_catch): Declare.
6950
6951 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6952
6953         * annotate.c (annotate_source_line): Change return type to void,
6954         update implementation to match.
6955         * annotate.h (annotate_source_line): Change return type to void,
6956         update header comment.
6957         * stack.c (print_frame_info): Don't change what frame information
6958         is printed based on whether annotations are on or not.
6959
6960 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6961
6962         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6963         (annotate_source): Make static.
6964         (annotate_source_line): Moved from source.c and renamed from
6965         identify_source_line.  Update the return type.
6966         * annotate.h (annotate_source): Delete declaration.
6967         (annotate_source_line): Declaration moved from source.h, and
6968         renamed from identify_source_line.  Return type updated.
6969         * source.c (identify_source_line): Moved to annotate.c and renamed
6970         to annotate_source_line.
6971         (info_line_command): Remove check of annotation_level.
6972         * source.h (identify_source_line): Move declaration to annotate.h
6973         and rename to annotate_source_line.
6974         * stack.c: Add 'annotate.h' include.
6975         (print_frame_info): Remove check of annotation_level before
6976         calling annotate_source_line.
6977
6978 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6979
6980         * source-cache.c (source_cache::get_plain_source_lines): Use
6981         open_source_file_with_line_charpos instead of just
6982         open_source_file, remove call to find_source_lines.
6983         (source_cache::get_source_lines): Likewise.
6984         * source.c (find_source_lines): Make static.
6985         (get_filename_and_charpos): Renamed into...
6986         (open_source_file_with_line_charpos): ..this along with changes to
6987         return a scoped_fd, and some other minor clean ups.
6988         (identify_source_line): Use open_source_file_with_line_charpos.
6989         (search_command_helper): Use open_source_file_with_line_charpos
6990         instead of just open_source_file, remove call to
6991         find_source_lines.
6992         * source.h (open_source_file_with_line_charpos): Declare new
6993         function.
6994         (find_source_lines): Delete declaration.
6995
6996 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6997
6998         * source.c (get_filename_and_charpos): Remove fullname
6999         parameter.
7000         (identify_source_line): Update call to get_filename_and_charpos.
7001
7002 2019-06-14  Tom Tromey  <tromey@adacore.com>
7003
7004         PR gdb/24502:
7005         * ui-style.h (skip_ansi_escape): Update comment.
7006         * ui-file.h (class no_terminal_escape_file): New class.
7007         * ui-file.c (no_terminal_escape_file::write)
7008         (no_terminal_escape_file::puts): New methods.
7009         * cli/cli-logging.c (handle_redirections): Use
7010         no_terminal_escape_file.
7011
7012 2019-06-14  Tom Tromey  <tromey@adacore.com>
7013
7014         * NEWS: Move convenience variable news above Python news.
7015
7016 2019-06-14  Tom Tromey  <tom@tromey.com>
7017
7018         * gnulib: Move directory to top-level.
7019         * configure.ac: Don't configure gnulib.
7020         * configure: Rebuild.
7021         * common/common-defs.h: Use new path to gnulib.
7022         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7023         (GNULIB_H): Remove.
7024         (INCGNU): Look in new gnulib location.
7025         (HFILES_NO_SRCDIR): Remove gnulib files.
7026         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7027         (generated_files): Remove GNULIB_H.
7028         ($(LIBGNU), all-lib): Remove targets.
7029         (distclean): Don't mention GNULIB_BUILDDIR.
7030         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7031
7032 2019-06-14  Tom Tromey  <tromey@adacore.com>
7033
7034         * symfile.c (add_symbol_file_command): Remove obsolete comment.
7035         Warn if symbol file does not provide any symbols.
7036
7037 2019-06-14  Tom Tromey  <tromey@adacore.com>
7038
7039         * source.c (find_and_open_source): Respect basenames_may_differ.
7040
7041 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
7042
7043         * annotate.c (annotate_breakpoints_invalid): Make use of
7044         scoped_restore_terminal_state.
7045         (annotate_frames_invalid): Likewise.
7046
7047 2019-06-14  Tom Tromey  <tromey@adacore.com>
7048
7049         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7050         allow assignment to an internalvar.
7051
7052 2019-06-14  Tom Tromey  <tromey@adacore.com>
7053
7054         * ada-lex.l: Allow "_" in attribute names.
7055
7056 2019-06-14  Tom Tromey  <tromey@adacore.com>
7057
7058         PR gdb/24653:
7059         * regcache.c (registers_changed): Don't call alloca.
7060         * top.c (execute_command): Don't call alloca.
7061
7062 2019-06-13  Pedro Alves  <palves@redhat.com>
7063
7064         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7065         'expression'.  When parsing an expression, error out if there's
7066         junk after "unlimited".
7067         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7068         (do_set_command): Adjust calls to is_unlimited_literal.
7069
7070 2019-06-13  Pedro Alves  <palves@redhat.com>
7071
7072         * compile/compile.c (make_compile_options_def_group): Add braces
7073         around array_view initializer.
7074         * thread.c (make_thread_apply_all_options_def_group)
7075         (make_thread_apply_all_options_def_group): Likewise.
7076
7077 2019-06-13  Pedro Alves  <palves@redhat.com>
7078
7079         * NEWS (New commands): Mention "maint test-options
7080         require-delimiter", "maint test-options unknown-is-error", "maint
7081         test-options unknown-is-operand" and "maint show
7082         test-options-completion-result".
7083         (New command options, command completion): New section.
7084         (Completion improvements): New section.
7085         Mention that you can abbreviate "unlimited".
7086
7087 2019-06-13  Pedro Alves  <palves@redhat.com>
7088
7089         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7090         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7091         * unittests/cli-utils-selftests.c (test_parse_flags)
7092         (test_parse_flags_qcs): Delete.
7093         (test_cli_utils): Don't call deleted functions.
7094
7095 2019-06-13  Pedro Alves  <palves@redhat.com>
7096
7097         * thread.c: Include "cli/cli-option.h".
7098         (tp_array_compar_ascending): Global.
7099         (tp_array_compar): Delete function.
7100         (tp_array_compar_ascending, tp_array_compar_descending): New
7101         functions.
7102         (ascending_option_def, qcs_flag_option_def)
7103         (thr_qcs_flags_option_defs)
7104         (make_thread_apply_all_options_def_group)
7105         (make_thread_apply_options_def_group): New.
7106         (thread_apply_all_command): Use gdb::option::process_options.
7107         (thread_apply_command_completer)
7108         (thread_apply_all_command_completer): New.
7109         (thread_apply_command): Use gdb::option::process_options.
7110         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7111         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
7112         to generate help text of "thread apply".  Adjust "taas"'s help.
7113         * tid-parse.c (tid_range_parser::in_thread_range): New method.
7114         * tid-parse.h (tid_range_parser::in_thread_range): New method.
7115
7116 2019-06-13  Pedro Alves  <palves@redhat.com>
7117
7118         * thread.c (thread_apply_command): Check for invalid TID with
7119         isdigit instead of !isalpha.
7120
7121 2019-06-13  Pedro Alves  <palves@redhat.com>
7122
7123         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7124         (validate_flags_qcs): New.
7125         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7126         (validate_flags_qcs): Declare.
7127         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7128         (make_frame_apply_options_def_group): New.
7129         (frame_apply_command_count): Process options with
7130         gdb::option::process_options.
7131         (frame_apply_completer): New.
7132         (frame_apply_level_completer, frame_apply_all_completer)
7133         (frame_apply_completer): New.
7134         (_initialize_stack): Update help of "frame apply", "frame apply
7135         level", "frame apply all" and "faas" to mention supported options
7136         and install command completers.
7137         * stack.h (frame_apply_all_completer): Declare.
7138         * thread.c: Include "stack.h".
7139         (tfaas_command): Add "--".
7140         (_initialize_thread): Update help "tfaas" to mention supported
7141         options and install command completer.
7142
7143 2019-06-13  Pedro Alves  <palves@redhat.com>
7144
7145         * completer.c (complete_nested_command_line): New.
7146         (gdb_completion_word_break_characters_throw): Add assertion.
7147         * completer.h (complete_nested_command_line): Declare.
7148
7149 2019-06-13  Pedro Alves  <palves@redhat.com>
7150
7151         * stack.c (parse_backtrace_qualifiers): New.
7152         (backtrace_command): Use it.
7153         (backtrace_command_completer): Complete on qualifiers.
7154
7155 2019-06-13  Pedro Alves  <palves@redhat.com>
7156
7157         * frame.c: Include "cli/cli-option.h.
7158         (user_set_backtrace_options): New.
7159         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7160         Delete.
7161         (get_prev_frame): Adjust.
7162         (boolean_option_def, uinteger_option_def)
7163         (set_backtrace_option_defs): New.
7164         (_initialize_frame): Adjust and use
7165         gdb::option::add_setshow_cmds_for_options to install "set
7166         backtrace past-main" and "set backtrace past-entry".
7167         * frame.h: Include "cli/cli-option.h".
7168         (struct frame_print_options): Forward declare.
7169         (print_frame_arguments_all, print_frame_arguments_scalars)
7170         (print_frame_arguments_none): Declare.
7171         (print_entry_values): Delete declaration.
7172         (struct frame_print_options, user_frame_print_options): New.
7173         (struct set_backtrace_options): New.
7174         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7175         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7176         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7177         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7178         (list_args_or_locals): Add frame_print_options parameter.
7179         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7180         * python/py-framefilter.c (enumerate_args): Pass down
7181         USER_FRAME_PRINT_OPTIONS.
7182         * stack.c: Include "cli/cli-option.h".
7183         (print_frame_arguments_all, print_frame_arguments_scalars)
7184         (print_frame_arguments_none): Declare.
7185         (print_raw_frame_arguments, print_entry_values): Delete.
7186         (user_frame_print_options): New.
7187         (boolean_option_def, enum_option_def, frame_print_option_defs):
7188         New.
7189         (struct backtrace_cmd_options): New.
7190         (bt_flag_option_def): New.
7191         (backtrace_command_option_defs): New.
7192         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7193         (print_frame_arg, read_frame_arg, print_frame_args)
7194         (print_frame_info, print_frame): Add frame_print_options parameter
7195         and use it.
7196         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7197         (backtrace_command_1): Add frame_print_options and
7198         backtrace_cmd_options parameters and use them.
7199         (make_backtrace_options_def_group): New.
7200         (backtrace_command): Process command options with
7201         gdb::option::process_options.
7202         (backtrace_command_completer): New.
7203         (_initialize_stack): Extend "backtrace"'s help to mention
7204         supported options.  Install completer for "backtrace".
7205         Install some settings commands with add_setshow_cmds_for_options.
7206
7207 2019-06-13  Pedro Alves  <palves@redhat.com>
7208
7209         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7210         and that "set/show print raw frame-arguments" are now deprecated.
7211
7212         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7213         command.
7214         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7215         * stack.c (_initialize_stack): Install "set/show print
7216         raw-frame-arguments", and deprecate "set/show print raw
7217         frame-arguments".
7218         * valprint.c (_initialize_valprint): Deprecate "set/show print
7219         raw".
7220
7221 2019-06-13  Pedro Alves  <palves@redhat.com>
7222
7223         * compile/compile.c (struct compile_options): New.
7224         (compile_flag_option_def, compile_command_option_defs)
7225         (make_compile_options_def_group): New.
7226         (compile_file_command): Handle options with
7227         gdb::option::process_options.
7228         (compile_file_command_completer): New function.
7229         (compile_code_command): Handle options with
7230         gdb::option::process_options.
7231         (compile_code_command_completer): New function.
7232         (_initialize_compiler): Install completers for "compile code" and
7233         "compile file".  Mention available options in "compile code" and
7234         "compile code"'s help.
7235         * completer.c (advance_to_completion_word): New, factored out from
7236         ...
7237         (advance_to_expression_complete_word_point): ... this.
7238         (advance_to_filename_complete_word_point): New.
7239         * completer.h (advance_to_filename_complete_word_point): New
7240         declaration.
7241
7242 2019-06-13  Pedro Alves  <palves@redhat.com>
7243
7244         * compile/compile.c: Include "cli/cli-option.h".
7245         (compile_print_value): Scope data pointer is now a
7246         value_print_options pointer; adjust.
7247         (compile_print_command): Process options.  Scope data pointer is
7248         now a value_print_options pointer; adjust.
7249         (_initialize_compile): Update "compile print"'s help to include
7250         supported options.  Install a completer for "compile print".
7251         * cp-valprint.c (show_vtblprint, show_objectprint)
7252         (show_static_field_print): Delete.
7253         (_initialize_cp_valprint): Don't install "set print
7254         static-members", "set print vtbl", "set print object" here.
7255         * printcmd.c: Include "cli/cli-option.h" and
7256         "common/gdb_optional.h".
7257         (print_command_parse_format): Rework to fill in a
7258         value_print_options instead of a format_data.
7259         (print_value): Change parameter type from format_data pointer to
7260         value_print_options reference.  Adjust.
7261         (print_command_1): Process options.  Adjust to pass down a
7262         value_print_options.
7263         (print_command_completer): New.
7264         (_initialize_printcmd): Install print_command_completer as
7265         handle_brkchars completer for the "print" command.  Update
7266         "print"'s help to include supported options.
7267         * valprint.c: Include "cli/cli-option.h".
7268         (show_vtblprint, show_objectprint, show_static_field_print): Moved
7269         here from cp-valprint.c.
7270         (boolean_option_def, uinteger_option_def)
7271         (value_print_option_defs, make_value_print_options_def_group):
7272         New.  Use gdb::option::add_setshow_cmds_for_options to install
7273         "set print elements", "set print null-stop", "set print repeats",
7274         "set print pretty", "set print union", "set print array", "set
7275         print address", "set print symbol", "set print array-indexes".
7276         * valprint.h: Include <string> and "cli/cli-option.h".
7277         (make_value_print_options_def_group): Declare.
7278         (print_value): Change parameter type from format_data pointer to
7279         value_print_options reference.
7280         (print_command_completer): Declare.
7281
7282 2019-06-13  Pedro Alves  <palves@redhat.com>
7283
7284         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7285         (COMMON_SFILES): Add maint-test-settings.c.
7286         * cli/cli-decode.c (boolean_enums): New global, factored out from
7287         ...
7288         (add_setshow_boolean_cmd): ... here.
7289         * cli/cli-decode.h (boolean_enums): Declare.
7290         * cli/cli-option.c: New file.
7291         * cli/cli-option.h: New file.
7292         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7293         factored out from ...
7294         (parse_cli_boolean_value(const char *)): ... this.
7295         (is_unlimited_literal): Change parameter type to pointer to
7296         pointer.  Adjust and advance ARG pointer.
7297         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7298         (parse_cli_var_enum): New, factored out from ...
7299         (do_set_command): ... this.  Adjust.
7300         * cli/cli-setshow.h (parse_cli_boolean_value)
7301         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7302         (parse_cli_var_enum): Declare.
7303         * cli/cli-utils.c: Include "cli/cli-option.h".
7304         (get_ulongest): New.
7305         * cli/cli-utils.h (get_ulongest): Declare.
7306         (check_for_argument): New overloads.
7307         * maint-test-options.c: New file.
7308
7309 2019-06-13  Pedro Alves  <palves@redhat.com>
7310
7311         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7312         parse a range if "-" is at the end of the string.
7313
7314 2019-06-13  Pedro Alves  <palves@redhat.com>
7315
7316         * cli/cli-setshow.c (parse_auto_binary_operation)
7317         (parse_cli_boolean_value): Don't allow "o".
7318
7319 2019-06-13  Pedro Alves  <palves@redhat.com>
7320
7321         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7322         * NEWS: Mention maint test-settings KIND.
7323         * maint-test-settings.c: New file.
7324
7325 2019-06-13  Pedro Alves  <palves@redhat.com>
7326
7327         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7328         completer.
7329         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7330         "set" completers.
7331
7332 2019-06-13  Pedro Alves  <palves@redhat.com>
7333
7334         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7335         after item.
7336
7337 2019-06-13  Pedro Alves  <palves@redhat.com>
7338
7339         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7340
7341 2019-06-13  Pedro Alves <palves@redhat.com>
7342
7343         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7344         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7345         call.
7346         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7347         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7348         calls.
7349         (check_for_argument): Skip spaces after argument.
7350
7351 2019-06-13  Pedro Alves  <palves@redhat.com>
7352
7353         * thread.c (thread_apply_command): Adjust TID parsing.
7354         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7355         detected before end of string.
7356         (tid_is_in_list): Error out if LIST is invalid.
7357
7358 2019-06-13  Pedro Alves  <palves@redhat.com>
7359
7360         * completer.c (complete_line_internal_1): Rewind completion word
7361         point.
7362         (completion_tracker::advance_custom_word_point_by): Change
7363         parameter type to int.
7364         * completer.h (completion_tracker::advance_custom_word_point_by):
7365         Likewise.
7366
7367 2019-06-13  Pedro Alves  <palves@redhat.com>
7368
7369         * completer.c (advance_to_completion_word): Handle delimiters.
7370
7371 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7372
7373         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7374
7375 2019-06-11  Tom Tromey  <tom@tromey.com>
7376
7377         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7378         (xmalloc_failed): Move to alloc.c.
7379         * alloc.c: New file.
7380         * Makefile.in (COMMON_SFILES): Add alloc.c.
7381
7382 2019-06-11  Tom Tromey  <tom@tromey.com>
7383
7384         * nat/linux-waitpid.c: Don't include server.h.
7385         (linux_debug): Remove.
7386         (my_waitpid): Update.
7387
7388 2019-06-11  Tom Tromey  <tromey@adacore.com>
7389
7390         * infcall.c (_initialize_infcall): Remove trailing newline from
7391         help.
7392         * user-regs.c (_initialize_user_regs): Remove trailing newline
7393         from help.
7394         * typeprint.c (_initialize_typeprint): Remove trailing newline
7395         from help.
7396         * reverse.c (_initialize_reverse): Remove trailing newlines from
7397         help.
7398         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7399         from help.
7400         * language.c (add_set_language_command): Remove trailing newline
7401         from help.
7402         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7403         help.
7404         * disasm.c (_initialize_disasm): Remove trailing newline from
7405         help.
7406         * top.c (init_main): Remove trailing newline from help.
7407         * interps.c (_initialize_interpreter): Remove trailing newline
7408         from help.
7409         * btrace.c (_initialize_btrace): Remove trailing newlines from
7410         help.
7411         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7412         from help.
7413         * python/python.c (_initialize_python): Remove trailing newline
7414         from help.
7415         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7416         help.
7417         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7418         from help.  Reformat some text.
7419         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7420         from help.
7421         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7422         newline from help.
7423
7424 2019-06-11  Tom Tromey  <tromey@adacore.com>
7425
7426         * darwin-nat.c (darwin_decode_exception_message)
7427         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7428
7429 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7430
7431         * valops.c (value_slice): Check for not allocated or not
7432         associated values.
7433
7434 2019-06-10  Tom de Vries  <tdevries@suse.de>
7435
7436         PR gdb/24618
7437         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7438         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7439         invalid.
7440
7441 2019-06-10  Tom de Vries  <tdevries@suse.de>
7442
7443         PR gdb/24611
7444         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7445         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7446
7447 2019-06-10  Tom de Vries  <tdevries@suse.de>
7448
7449         PR symtab/24545
7450         * symtab.c (struct demangled_name_entry): Add language field.
7451         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7452         static minimal symbol".  Set and use language field.
7453
7454 2019-06-10  Tom Tromey  <tromey@adacore.com>
7455
7456         * ada-lang.c (_initialize_ada_language): Update help text.
7457
7458 2019-06-10  Tom Tromey  <tromey@adacore.com>
7459
7460         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7461         with a newline.
7462         * guile/guile.c (handle_boot_error): Don't end warning with a
7463         newline.
7464         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7465         warning with a newline.
7466         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7467         newline.
7468         (s12z_frame_cache): Likewise.
7469         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7470         a newline.
7471         * solib-svr4.c (disable_probes_interface): Don't end warning with
7472         a newline.
7473         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7474         newline.
7475         * python/python.c (do_finish_initialization): Don't end warning
7476         with a newline.
7477
7478 2019-06-10  Tom Tromey  <tom@tromey.com>
7479
7480         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7481         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7482         gdbpy_enter.
7483
7484 2019-06-10  Tom Tromey  <tromey@adacore.com>
7485
7486         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7487         data.
7488         (elf_new_init): Don't call stabsread_new_init.
7489         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7490         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7491         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7492
7493 2019-06-10  Tom de Vries  <tdevries@suse.de>
7494
7495         PR symtab/16264
7496         PR symtab/24517
7497         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7498
7499 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7500
7501         * source.c (find_and_open_source): Also rewrite relative file
7502         names.
7503
7504 2019-04-26  Amos Bird  <amosbird@gmail.com>
7505
7506         * annotate.c (annotate_thread_exited): Add "thread-exited"
7507         annotation.
7508
7509 2019-06-06  Tom Tromey  <tromey@adacore.com>
7510
7511         * maint.h (class scoped_command_stats): Use
7512         DISABLE_COPY_AND_ASSIGN.
7513         <print_time>: New method.
7514         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7515         print_time.
7516         (scoped_command_stats::print_time): New method.
7517
7518 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7519
7520         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7521         instructions of lengths 6 or 8 bytes.
7522
7523 2019-06-04  Pedro Alves  <palves@redhat.com>
7524
7525         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7526
7527         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7528         * breakpoint.c (condition_completer): Likewise.
7529         * cli/cli-dump.c (scan_expression): Likewise.
7530         * common/filestuff.c (mkdir_recursive): Likewise.
7531         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7532         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7533         (gdb_abspath): Likewise.
7534         * compile/compile-cplus-types.c
7535         (compile_cplus_instance::decl_name): Likewise.
7536         * completer.c (complete_explicit_location):
7537         (signal_completer, reg_or_group_completer_1): Likewise.
7538         * cp-support.c (cp_remove_params_if_any): Likewise.
7539         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7540         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7541         * infcmd.c (strip_bg_char): Likewise.
7542         * linespec.c (copy_token_string): Likewise.
7543         * mi/mi-main.c (output_cores): Likewise.
7544         * psymtab.c (psymtab_search_name):
7545         * symfile.c (test_set_ext_lang_command): Likewise.
7546         * target.c (target_fileio_read_stralloc): Likewise.
7547         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7548         * value.c (complete_internalvar): Likewise.
7549
7550 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7551
7552         Add objfile property to gdb.Type.
7553         * NEWS: Mention Python API addition.
7554         * python/py-type.c (typy_get_objfile): New method.
7555
7556 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7557
7558         * NEWS: Mention the new set|show style [title|highlight].
7559         Mention changes to "show style", "help" and "apropos".
7560
7561 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7562
7563         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7564         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7565         instead of print_help_for_command.
7566         (print_doc_of_command): New function.
7567         (help_list): Add 'apropos -v word' suggestion.
7568         (print_help_for_command): Style the command name using title style.
7569         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7570         (_initialize_cli_cmds): Describe -v in apropos_command help.
7571
7572 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7573
7574         * cli/cli-style.h (cli_style_option): Add name in constructor,
7575         add m_name class member, add constructor with intensity,
7576         add name class function.
7577         (cli_style_option::add_setshow_commands): Remove name argument.
7578         (highlight_style, title_style): New styles.
7579         * cli/cli-style.c (do_show): New function that shows a style
7580         characteristic styling the style name with itself.
7581         (set_style_name): New function.
7582         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7583         Update all callers according to the changes in cli/cli-style.h.
7584         * utils.h (fputs_highlighted): New function.
7585         * utils.c (fputs_highlighted): Likewise.
7586
7587 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7588
7589         * NEWS: Mention new pipe command and new convenience variables.
7590
7591 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7592
7593         * cli/cli-cmds.c (pipe_command): New function.
7594         (_initialize_cli_cmds): Call add_com for pipe_command.
7595         Define | as an alias for pipe.
7596         (exit_status_set_internal_vars): New function.
7597         (shell_escape): Call exit_status_set_internal_vars.
7598         cli/cli-decode.c (find_command_name_length): Recognize | as
7599         a single character command.
7600
7601 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7602
7603         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7604         top.c (execute_command_to_ui_file): New function, mostly a copy
7605         of execute_command_to_string.
7606         (execute_command_to_string): Implement by calling
7607         execute_command_to_ui_file.
7608
7609 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7610
7611         * top.h (saved_command_line): Remove declaration.
7612         * top.c (previous_saved_command_line, previous_repeat_arguments):
7613         New variables.
7614         (saved_command_line): Make static, define together with other
7615         'repeat variables'.
7616         (dont_repeat): Clear repeat_arguments.
7617         (repeat_previous, get_saved_command_line, save_command_line):
7618         New functions.
7619         (gdb_init): Initialize saved_command_line
7620         and previous_saved_command_line.
7621         * main.c (captured_main_1): Remove saved_command_line initialization.
7622         * event-top.c (handle_line_of_input): Update to use
7623         the new 'repeat' related functions instead of direct access to
7624         saved_command_line.
7625         * command.h (repeat_previous, get_saved_command_line,
7626         save_command_line): New declarations.
7627         (dont_repeat): Add comment.
7628
7629 2019-05-30  Tom Tromey  <tromey@adacore.com>
7630
7631         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7632         Fix comment.
7633         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7634
7635 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7636
7637         PR cli/24587
7638         * completer.c (complete): Initialize variable word.
7639
7640 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7641
7642         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7643         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7644         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7645         'body' is NULL to the outter 'if', protecting the '!is_define'
7646         situation as well.
7647
7648 2019-05-29  Tom Tromey  <tromey@adacore.com>
7649
7650         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7651         (dwarf_unknown): New function.
7652         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7653         (dwarf_type_encoding_name): Use dwarf_unknown.
7654
7655 2019-05-29  Tom Tromey  <tromey@adacore.com>
7656
7657         PR c++/20020:
7658         * cp-valprint.c (cp_print_value_fields): Call
7659         cp_print_static_field inside "try".
7660
7661 2019-05-29  Tom Tromey  <tromey@adacore.com>
7662
7663         * inflow.c (struct terminal_info): Add default operator=.
7664         * configure: Rebuild.
7665         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7666         -Wdeprecated-copy-dtor, -Wredundant-move.
7667
7668 2019-05-29  Tom Tromey  <tromey@adacore.com>
7669
7670         * NEWS: Add entry.
7671         * infcmd.c (print_return_value_1): Handle finish_print
7672         option.
7673         (show_print_finish): New function.
7674         (_initialize_infcmd): Add "set/show print finish" commands.
7675         * valprint.c (user_print_options): Initialize new member.
7676         * valprint.h (struct value_print_options) <finish_print>: New
7677         member.
7678
7679 2019-05-28  Tom Tromey  <tromey@adacore.com>
7680
7681         * ada-lang.c (ada_remove_Xbn_suffix)
7682         (find_old_style_renaming_symbol)
7683         (parse_old_style_renaming): Remove.
7684         (ada_find_renaming_symbol): Don't call
7685         find_old_style_renaming_symbol.
7686         (ada_is_renaming_symbol): Rename from
7687         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7688         bool.  Now static.
7689         (ada_read_var_value): Update and simplify.
7690         * ada-exp.y (write_var_or_type): Remove old code.
7691
7692 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7693
7694         PR gdb/25010
7695         * event-top.c: Remove include comment.
7696         * inflow.c (class scoped_ignore_sigttou): Move from here...
7697         * inflow.h (class scoped_ignore_sigttou): ...to here.
7698         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7699         * top.c:  Remove include comment.
7700
7701 2019-05-27  Tom Tromey  <tom@tromey.com>
7702
7703         * NEWS: Fix typo.
7704
7705 2019-05-22  Tom Tromey  <tromey@adacore.com>
7706
7707         * target.c (target_follow_exec): Constify parameter.
7708         * target-delegates.c: Rebuild.
7709         * remote.c (remote_target::follow_exec): Constify parameter.
7710         * infrun.c (follow_exec): Constify parameter.
7711         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7712         (target_follow_exec): Likewise.
7713
7714 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7715
7716         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7717         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7718
7719 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7720
7721         * NEWS: Add debugredirect and testsuite sections.
7722
7723 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7724
7725         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7726         target descriptions using exclusively floating point register name
7727         aliases.
7728
7729 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7730
7731         PR gdb/18644:
7732         * f-lang.c (build_fortran_types): Handle the case where
7733         gdbarch_floatformat_for_type returns a nullptr.
7734
7735 2019-05-21  Tom de Vries  <tdevries@suse.de>
7736
7737         PR cli/24587
7738         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7739
7740 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7741
7742         PR gdb/18644:
7743         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7744         16-byte floats.
7745         * i386-tdep.c (i386_floatformat_for_type): Use
7746         floatformats_ia64_quad for the 16-byte floating point component
7747         within a fortran 32-byte complex number.
7748
7749 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7750
7751         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7752         delete default constructor.
7753         (find_partial_die): Update to return const struct.
7754         (partial_die_parent_scope): Move variable declaration into scope
7755         of its use and change its type to auto.
7756         (guess_partial_die_structure_name): Likewise.
7757         (partial_die_info::fixup): Likewise.
7758
7759 2019-05-17  Tom Tromey  <tromey@adacore.com>
7760
7761         * source.c (find_and_open_source): Remove cast.
7762
7763 2019-05-17  Tom Tromey  <tromey@adacore.com>
7764
7765         * annotate.c (annotate_source): Make "filename" const.
7766         * annotate.h (annotate_source): Use const.
7767
7768 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7769
7770         * disasm.c (set_disassembler_options): Send errors to stderr.
7771
7772 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7773
7774         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7775         (cli_interp_base::set_logging): Check debug_redirect.
7776         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7777         * cli/cli-logging.c (debug_redirect): Add static variable.
7778         (pop_output_files): Add default param.
7779         (handle_redirections): Print debug setting.
7780         (show_logging_command): Likewise.
7781         (_initialize_cli_logging): Add debugredirect command.
7782         * interps.c (current_interp_set_logging): Add debug_redirect
7783         parameter.
7784         * interps.h (set_logging): Add debug_redirect parameter.
7785         (current_interp_set_logging): Likewise.
7786         * mi/mi-common.h: Likewise.
7787         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7788
7789 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7790             Tom Tromey  <tromey@adacore.com>
7791
7792         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7793         directly.
7794         * cli/cli-interp.h (make_logging_output): Remove declaration.
7795         * cli/cli-logging.c (make_logging_output): Remove function.
7796         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7797         directly.
7798         * ui-file.c (tee_file::tee_file): Remove bools.
7799         (tee_file::~tee_file): Remove deletes.
7800         * ui-file.h (tee_file): Remove bools.
7801
7802 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7803
7804         * mi/mi-cmds.h (mi_cmd_complete): New function.
7805         * mi/mi-main.c (mi_cmd_complete): Likewise.
7806         * mi/mi-cmds.c: Define new MI command -complete.
7807         * NEWS: Mention new -complete command.
7808
7809 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7810
7811         * completer.h (complete): New function.
7812         * completer.c (complete): Likewise.
7813         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7814         function defined in completer.h.
7815
7816 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7817
7818         * MAINTAINERS (Write After Approval): Add myself.
7819
7820 2019-05-17  Tom de Vries  <tdevries@suse.de>
7821
7822         PR gdb/24094
7823         * dwarf2read.c (struct cu_partial_die_info): New struct.
7824         (find_partial_die): Return cu_partial_die_info.
7825         (partial_die_parent_scope, guess_partial_die_structure_name)
7826         (partial_die_info::fixup): Handle new return type of find_partial_die.
7827
7828 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7829
7830         PR breakpoints/24541
7831         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7832         "std::string", simplifying the algorithm.
7833
7834 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7835
7836         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7837         (stap_static_probe_ops::get_probes): Likewise.
7838
7839 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7840
7841         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7842         '-')" and "else if".
7843         (stap_parse_single_operand): Join checks for
7844         "gdbarch_stap_parse_special_token_p" and
7845         "gdbarch_stap_parse_special_token" in the same "if" statement.
7846         Invert check when verifying for operation on register
7847         displacement.
7848
7849 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7850
7851         * stap-probe.c (stap_get_opcode): Update comment.
7852         (stap_get_expected_argument_type): Likewise.
7853         (handle_stap_probe): Likewise.
7854
7855 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7856
7857         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7858         return type to 'bool'.  Adjust comment.  Use 'bool' when
7859         appropriate.
7860         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7861         * stap-probe.c (stap_parse_argument_1): Likewise.
7862         (stap_is_operator): Likewise.
7863         (stap_is_generic_prefix): Likewise.
7864         (stap_is_register_prefix): Likewise.
7865         (stap_is_register_indirection_prefix): Likewise.
7866         (stap_is_integer_prefix): Likewise.
7867         (stap_generic_check_suffix): Likewise.
7868         (stap_check_integer_suffix): Likewise.
7869         (stap_check_register_suffix): Likewise.
7870         (stap_check_register_indirection_suffix): Likewise.
7871         (stap_parse_register_operand): Likewise.
7872         (stap_parse_single_operand): Likewise.
7873         (stap_parse_argument_1): Likewise.
7874         (stap_probe::get_argument_count): Likewise.
7875         (stap_is_operator): Likewise.
7876
7877 2019-05-16  Tom Tromey  <tromey@adacore.com>
7878
7879         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7880         keyword to foreach.
7881
7882 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7883
7884         * linux-thread-db.c (try_thread_db_load_1): Change return type
7885         to bool.
7886         (try_thread_db_load): Likewise.
7887         (try_thread_db_load_from_pdir_1): Likewise.
7888         (try_thread_db_load_from_pdir): Likewise.
7889         (try_thread_db_load_from_sdir): Likewise.
7890         (try_thread_db_load_from_dir): Likewise.
7891         (thread_db_load_search): Likewise.
7892         (has_libpthread): Likewise.
7893         (thread_db_load): Likewise.
7894
7895 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7896
7897         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7898         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7899         NULL, and complain/return if that's the case.
7900
7901 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7902
7903         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7904         (advance, posn, abstract_read_memory): New functions.
7905         [struct mem_read_abstraction]: New struct.
7906         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7907
7908 2019-05-14  Tom Tromey  <tromey@adacore.com>
7909
7910         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7911         value is not lval_memory.
7912
7913 2019-05-14  Tom Tromey  <tromey@adacore.com>
7914
7915         * solib.c (info_sharedlibrary_command): Style the file name.
7916
7917 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7918
7919         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7920         (aarch64_vnv_type): Likewise.
7921         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7922         * common/tdesc.c: Likewise.
7923         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7924         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7925         * features/aarch64-fpu.xml: Add ieee half view.
7926         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7927         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7928         * gdbtypes.h (struct builtin_type): Likewise.
7929         (struct objfile_type): Likewise.
7930
7931 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7932
7933         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7934         typo.
7935         * location.h (string_to_event_location): Likewise.
7936
7937 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7938
7939         GDB 8.3 released.
7940
7941 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7942
7943         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7944         New variable declaration.
7945         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7946         New variable.
7947         (print_one_breakpoint): Use ui_out::test_flags and new global
7948         variable to compute use_fixed_output.
7949         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7950         Remove.
7951         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7952         (mi_multi_location_breakpoint_output_fixed): Remove.
7953         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7954         new variable.
7955         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7956         fix_multi_location_breakpoint_output flag if version >= 3.
7957         * ui-out.h (enum ui_out_flag)
7958         <fix_multi_location_breakpoint_output>: New enumerator.
7959
7960 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7961
7962         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7963
7964 2019-05-10  Tom Tromey  <tromey@adacore.com>
7965
7966         * ada-lang.c (catch_ada_completer): New function.
7967         (_initialize_ada_language): Use it.
7968
7969 2019-05-10  Tom Tromey  <tromey@adacore.com>
7970
7971         * thread.c (print_thread_info): Make "requested_threads" const.
7972         * gdbthread.h (print_thread_info): Make "requested_threads"
7973         const.
7974         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7975         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7976
7977 2019-05-08  Tom Tromey  <tom@tromey.com>
7978
7979         * gdbtypes.c (objfile_type_data): Change type.
7980         (objfile_type, _initialize_gdbtypes): Update.
7981
7982 2019-05-08  Tom Tromey  <tom@tromey.com>
7983
7984         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7985         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7986         (_initialize_dwarf2_frame): Update.
7987
7988 2019-05-08  Tom Tromey  <tom@tromey.com>
7989
7990         * objc-lang.c (objc_objfile_data): Change type.
7991         (find_methods): Update.
7992         (_initialize_objc_lang): Remove.
7993
7994 2019-05-08  Tom Tromey  <tom@tromey.com>
7995
7996         * stabsread.c (rs6000_builtin_type_data): Change type.
7997         (rs6000_builtin_type, _initialize_stabsread): Update.
7998
7999 2019-05-08  Tom Tromey  <tom@tromey.com>
8000
8001         * mips-tdep.c (mips_pdr_data): Remove.
8002         (_initialize_mips_tdep): Update.
8003
8004 2019-05-08  Tom Tromey  <tom@tromey.com>
8005
8006         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8007         (hppa_init_objfile_priv_data, read_unwind_info)
8008         (find_unwind_entry, _initialize_hppa_tdep): Update.
8009
8010 2019-05-08  Tom Tromey  <tom@tromey.com>
8011
8012         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8013         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
8014         on obstack.
8015         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8016
8017 2019-05-08  Tom Tromey  <tom@tromey.com>
8018
8019         * mdebugread.c (basic_type_data): Change type.
8020         (basic_type, _initialize_mdebugread): Update.
8021
8022 2019-05-08  Tom Tromey  <tom@tromey.com>
8023
8024         * common/gdb_unique_ptr.h (struct noop_deleter): New.
8025
8026 2019-05-08  Tom Tromey  <tom@tromey.com>
8027
8028         * nto-tdep.c (nto_inferior_data_reg): Change type.
8029         (nto_inferior_data): Update.
8030         (nto_inferior_data_cleanup, nto_new_inferior_data)
8031         (_initialize_nto_tdep): Remove.
8032         * nto-tdep.h (struct nto_inferior_data): Add initializers.
8033
8034 2019-05-08  Tom Tromey  <tom@tromey.com>
8035
8036         * ada-lang.c (struct ada_inferior_data): Add initializers.
8037         (ada_inferior_data): Change type.
8038         (ada_inferior_data_cleanup): Remove.
8039         (get_ada_inferior_data, ada_inferior_exit)
8040         (struct ada_pspace_data): Add initializers, destructor.
8041         (ada_pspace_data_handle): Change type.
8042         (get_ada_pspace_data): Update.
8043         (ada_pspace_data_cleanup): Remove.
8044
8045 2019-05-08  Tom Tromey  <tom@tromey.com>
8046
8047         * coffread.c (struct coff_symfile_info): Add initializers.
8048         (coff_objfile_data_key): Move lower.  Change type.
8049         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8050         Update.
8051         (coff_free_info): Remove.
8052
8053 2019-05-08  Tom Tromey  <tom@tromey.com>
8054
8055         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8056         (fbsd_pspace_data_handle): Move lower.  Change type.
8057         (get_fbsd_pspace_data): Update.
8058         (fbsd_pspace_data_cleanup): Remove.
8059         (_initialize_fbsd_tdep): Update.
8060
8061 2019-05-08  Tom Tromey  <tom@tromey.com>
8062
8063         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8064         (get_ada_tasks_pspace_data): Update.
8065         (ada_tasks_pspace_data_cleanup): Remove.
8066         (_initialize_tasks): Update.
8067         (ada_tasks_inferior_data_handle): Change type.
8068         (get_ada_tasks_inferior_data): Update.
8069         (ada_tasks_inferior_data_cleanup): Remove.
8070         (struct ada_tasks_pspace_data): Add initializers.
8071
8072 2019-05-08  Tom Tromey  <tom@tromey.com>
8073
8074         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8075         * symfile-debug.c (debug_sym_get_probes): Change type.
8076         * stap-probe.c (handle_stap_probe):
8077         (stap_static_probe_ops::get_probes): Change type.
8078         * probe.h (class static_probe_ops) <get_probes>: Change type.
8079         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8080         (parse_probes_in_pspace): Update.
8081         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8082         Update.
8083         (any_static_probe_ops::get_probes): Change type.
8084         * elfread.c (elfread_data): New typedef.
8085         (probe_key): Change type.
8086         (elf_get_probes): Likewise.  Update.
8087         (probe_key_free): Remove.
8088         (_initialize_elfread): Update.
8089         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8090         Change type.
8091         (dtrace_process_dof_probe, dtrace_process_dof)
8092         (dtrace_static_probe_ops::get_probe): Change type.
8093
8094 2019-05-08  Tom Tromey  <tom@tromey.com>
8095
8096         * xcoffread.c (struct xcoff_symfile_info): Rename from
8097         coff_symfile_info.  Add initializers.
8098         (xcoff_objfile_data_key): Move lower.  Change type.
8099         (XCOFF_DATA): Rewrite.
8100         (xcoff_free_info): Remove.
8101         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8102         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8103         (xcoff_initial_scan): Update.
8104
8105 2019-05-08  Tom Tromey  <tom@tromey.com>
8106
8107         * solib-svr4.c (struct svr4_info): Add initializers and
8108         destructor.
8109         <probes_table>: Now an htab_up.
8110         (solib_svr4_pspace_data): Change type.
8111         (free_probes_table): Simplify.
8112         (~svr4_info): Rename from svr4_pspace_data_cleanup.
8113         (get_svr4_info, probes_table_htab_remove_objfile_probes)
8114         (probes_table_remove_objfile_probes, register_solib_event_probe)
8115         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8116         (_initialize_svr4_solib): Update.
8117
8118 2019-05-08  Tom Tromey  <tom@tromey.com>
8119
8120         * remote.c (remote_pspace_data): Change type.
8121         (remote_pspace_data_cleanup): Remove.
8122         (get_remote_exec_file, set_pspace_remote_exec_file)
8123         (_initialize_remote): Update.
8124
8125 2019-05-08  Tom Tromey  <tom@tromey.com>
8126
8127         * breakpoint.c (breakpoint_objfile_key): Change type.
8128         (get_breakpoint_objfile_data): Update.
8129         (free_breakpoint_objfile_data): Remove.
8130         (_initialize_breakpoint): Update.
8131
8132 2019-05-08  Tom Tromey  <tom@tromey.com>
8133
8134         * linux-tdep.c (struct linux_info): Add initializers.
8135         (linux_inferior_data): Move.  Change type.
8136         (invalidate_linux_cache_inf): Update.
8137         (linux_inferior_data_cleanup): Remove.
8138         (get_linux_inferior_data, _initialize_linux_tdep): Update.
8139
8140 2019-05-08  Tom Tromey  <tom@tromey.com>
8141
8142         * auxv.c (auxv_inferior_data): Move.  Change type.
8143         (auxv_inferior_data_cleanup): Remove.
8144         (invalidate_auxv_cache_inf): Rewrite.
8145         (get_auxv_inferior_data, _initialize_auxv): Update.
8146
8147 2019-05-08  Tom Tromey  <tom@tromey.com>
8148
8149         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8150         (symfile_debug_objfile_data_key): Change type.
8151         (symfile_debug_installed, debug_qf_has_symbols)
8152         (debug_qf_find_last_source_symtab)
8153         (debug_qf_forget_cached_source_info)
8154         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8155         (debug_qf_print_stats, debug_qf_dump)
8156         (debug_qf_expand_symtabs_for_function)
8157         (debug_qf_expand_all_symtabs)
8158         (debug_qf_expand_symtabs_with_fullname)
8159         (debug_qf_map_matching_symbols)
8160         (debug_qf_expand_symtabs_matching)
8161         (debug_qf_find_pc_sect_compunit_symtab)
8162         (debug_qf_map_symbol_filenames)
8163         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8164         (debug_sym_new_init, debug_sym_init, debug_sym_read)
8165         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8166         (debug_sym_read_linetable, debug_sym_relocate): Update.
8167         (symfile_debug_free_objfile): Remove.
8168         (install_symfile_debug_logging, _initialize_symfile_debug):
8169         Update.
8170
8171 2019-05-08  Tom Tromey  <tom@tromey.com>
8172
8173         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8174         allocate_on_obstack.
8175         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8176         (get_dwarf2_per_objfile): Update.
8177         (set_dwarf2_per_objfile): Remove.
8178         (dwarf2_has_info, dwarf2_get_section_info): Update.
8179         (dwarf2_free_objfile): Remove.
8180         (_initialize_dwarf2_read): Update.
8181
8182 2019-05-08  Tom Tromey  <tom@tromey.com>
8183
8184         * auto-load.c (struct auto_load_pspace_info): Add destructor and
8185         initializers.
8186         <unsupported_script_warning_printed,
8187         script_not_found_warning_printed>: Now bool.
8188         (auto_load_pspace_data): Change type.
8189         (~auto_load_pspace_info): Rename from
8190         auto_load_pspace_data_cleanup.
8191         (get_auto_load_pspace_data, init_loaded_scripts_info)
8192         (clear_section_scripts, maybe_print_unsupported_script_warning)
8193         (maybe_print_script_not_found_warning, _initialize_auto_load):
8194         Update.
8195
8196 2019-05-08  Tom Tromey  <tom@tromey.com>
8197
8198         * objfiles.c (objfile_pspace_info): Add destructor and
8199         initializers.
8200         (objfiles_pspace_data): Change type.
8201         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8202         (get_objfile_pspace_data): Update.
8203         (objfiles_bfd_data): Change type.
8204         (get_objfile_bfd_data): Update.
8205         (objfile_bfd_data_free, _initialize_objfiles): Remove.
8206
8207 2019-05-08  Tom Tromey  <tom@tromey.com>
8208
8209         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8210         Change type.
8211         (get_catch_syscall_inferior_data): Update.
8212         (catch_syscall_inferior_data_cleanup): Remove.
8213         (_initialize_break_catch_syscall): Update.
8214
8215 2019-05-08  Tom Tromey  <tom@tromey.com>
8216
8217         * inflow.c (struct terminal_info): Add destructor and
8218         initializers.
8219         (inflow_inferior_data): Change type.
8220         (~terminal_info): Rename from inflow_inferior_data_cleanup.
8221         (get_inflow_inferior_data, inflow_inferior_exit)
8222         (swap_terminal_info, _initialize_inflow): Update.
8223
8224 2019-05-08  Tom Tromey  <tom@tromey.com>
8225
8226         * target-dcache.c (target_dcache_cleanup): Remove.
8227         (target_dcache_aspace_key): Change type.
8228         (target_dcache_init_p, target_dcache_invalidate)
8229         (target_dcache_get, target_dcache_get_or_init)
8230         (_initialize_target_dcache): Update.
8231         * dcache.h (struct dcache_deleter): New.
8232
8233 2019-05-08  Tom Tromey  <tom@tromey.com>
8234
8235         * symtab.c (struct symbol_cache): Add destructor and
8236         initializers.
8237         (symbol_cache_key): Move.  Change type.
8238         (make_symbol_cache, free_symbol_cache): Remove.
8239         (get_symbol_cache): Update.
8240         (symbol_cache_cleanup): Remove.
8241         (ALL_PSPACES, symbol_cache_flush)
8242         (maintenance_print_symbol_cache)
8243         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
8244         Update.
8245
8246 2019-05-08  Tom Tromey  <tom@tromey.com>
8247
8248         * symtab.c (struct main_info): Add destructor and initializers.
8249         (main_progspace_key): Move.  Change type.
8250         (get_main_info): Update.
8251         (main_info_cleanup): Remove.
8252         (_initialize_symtab): Update.
8253
8254 2019-05-08  Tom Tromey  <tom@tromey.com>
8255
8256         * registry.h (DECLARE_REGISTRY): Define the _key class.
8257
8258 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8259
8260         * NEWS: Merge two 'New commands' sections.
8261
8262 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
8263
8264         * ada-valprint.c (ada_val_print_gnat_array): Remove language
8265         parameter and use Ada language definition instead.
8266         (ada_val_print_ptr): Remove unused language parameter.
8267         (ada_val_print_num): Remove language parameter and use Ada language
8268         definition instead.
8269         (ada_val_print_enum, ada_val_print_flt): Remove unused language
8270         parameter.
8271         (ada_val_print_struct_union, ada_val_print_ref): Remove language
8272         parameter and use Ada language definition instead.
8273         (ada_val_print_1): Update all ada_val_print_xxx calls.
8274         Remove language parameter.
8275         (ada_val_print): Update ada_val_print_1 call.
8276
8277 2019-05-08  Tom Tromey  <tromey@adacore.com>
8278
8279         * remote.c (remote_hw_watchpoint_limit)
8280         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
8281         Now static.
8282
8283 2019-05-08  Tom Tromey  <tromey@adacore.com>
8284
8285         * maint.c (_initialize_maint_cmds): Move initialization code to
8286         remote.c.
8287         (watchdog, show_watchdog): Move to remote.c.
8288         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8289         "watchdog" static.
8290         (_initialize_remote): Move initialization code from maint.c.
8291         * defs.h (watchdog): Don't declare.
8292
8293 2019-05-08  Tom Tromey  <tromey@adacore.com>
8294
8295         * tui/tui-interp.c: Include main.h.
8296         * interps.c: Include main.h.
8297         * main.h (interpreter_p): Declare.
8298         * defs.h (interpreter_p): Don't declare.
8299
8300 2019-05-08  Tom Tromey  <tromey@adacore.com>
8301
8302         * dwarf2loc.c: Include dwarf2read.h.
8303         * defs.h (read_unsigned_leb128): Don't declare.
8304         * dwarf2read.h (read_unsigned_leb128): Declare.
8305
8306 2019-05-08  Tom Tromey  <tromey@adacore.com>
8307
8308         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8309         method.
8310
8311 2019-05-08  Tom Tromey  <tromey@adacore.com>
8312
8313         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8314         when no wrap column is set.
8315
8316 2019-05-08  Tom Tromey  <tromey@adacore.com>
8317
8318         * c-lang.c (c_get_string): Handle non-C-style arrays.
8319
8320 2019-05-08  Tom Tromey  <tromey@adacore.com>
8321
8322         * typeprint.c (print_offset_data::update): Print the bit offset,
8323         not the number of bits remaining.
8324
8325 2019-05-08  Tom Tromey  <tromey@adacore.com>
8326
8327         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8328         padding at end of comment.
8329
8330 2019-05-08  Tom Tromey  <tromey@adacore.com>
8331
8332         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8333         Compare main types.
8334
8335 2019-05-06  Tom Tromey  <tom@tromey.com>
8336
8337         * common/scoped_mmap.c: Include common-defs.h.
8338         * common/scoped_mmap.h: Don't include config.h.
8339
8340 2019-05-04  Tom Tromey  <tom@tromey.com>
8341
8342         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8343         (struct aarch64_call_info): Add initializers.
8344         <si>: Now a std::vector.
8345         (pass_on_stack, aarch64_push_dummy_call): Update.
8346
8347 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8348             Tom Tromey  <tom@tromey.com>
8349
8350         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8351         (ppc_threads): Now a std::vector.  Now static.
8352         (hwdebug_find_thread_points_by_tid)
8353         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8354         Update.
8355
8356 2019-05-04  Tom Tromey  <tom@tromey.com>
8357
8358         * arc-tdep.c (arc_tdesc_init): Return bool.
8359
8360 2019-05-04  Tom Tromey  <tom@tromey.com>
8361
8362         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8363         Use gdb_assert_not_reached.
8364
8365 2019-05-04  Tom Tromey  <tom@tromey.com>
8366
8367         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8368         "false".
8369
8370 2019-05-04  Tom Tromey  <tom@tromey.com>
8371
8372         * arc-tdep.c (arc_tdesc_init): Use bool.
8373
8374 2019-05-04  Tom Tromey  <tom@tromey.com>
8375
8376         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8377
8378 2019-05-04  Tom Tromey  <tom@tromey.com>
8379
8380         * cli/cli-cmds.c (valid_command_p): Return bool.
8381
8382 2019-05-04  Tom Tromey  <tom@tromey.com>
8383
8384         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8385         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8386
8387 2019-05-04  Raul Tambre  <raul@tambre.ee>
8388
8389         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8390         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8391         operator for comparison.
8392
8393 2019-05-04  Tom Tromey  <tom@tromey.com>
8394
8395         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8396         (lookup_partial_symbol, print_partial_symbols)
8397         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8398         (psymbol_compare): Update.
8399         (add_psymbol_to_bcache): Clear the entire psymbol.
8400         (maintenance_check_psymtabs): Update.
8401         * psympriv.h (struct partial_symbol): Don't derive from
8402         general_symbol_info.
8403         <obj_section, unrelocated_address, address,
8404         set_unrelocated_address>: Update.
8405         <ginfo>: New member.
8406         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8407         (debug_names::write_psymbols): Update.
8408
8409 2019-05-04  Tom de Vries  <tdevries@suse.de>
8410
8411         * contrib/cc-with-tweaks.sh: Support -n arg.
8412
8413 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8414
8415         * corelow.c (core_target::detach): Ensure frame cache and
8416         register caches are cleared.
8417         inferior.c (exit_inferior_1): Likewise.
8418
8419 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8420             Tom Tromey  <tom@tromey.com>
8421
8422         * dictionary.c (collate_pending_symbols_by_language): Remove
8423         "struct" from foreach.
8424         * symtab.c (lookup_global_symbol_from_objfile)
8425         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8426         foreach.
8427         * ser-tcp.c (net_open): Remove "struct" from foreach.
8428         * objfiles.c (objfile_relocate, objfile_rebase)
8429         (objfile_has_symbols): Remove "struct" from foreach.
8430         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8431         from foreach.
8432         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8433         foreach.
8434         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8435         "struct" from foreach.
8436         * ada-lang.c (create_excep_cond_exprs)
8437         (ada_exception_catchpoint_cond_string): Remove "struct" from
8438         foreach.
8439
8440 2019-05-03  Tom Tromey  <tromey@adacore.com>
8441
8442         * ada-exp.y (convert_char_literal): Check suffix of each
8443         enumerator.
8444
8445 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8446
8447         PR ada/21406:
8448         * ada-exp.y (yywrap): Don't define.
8449         * ada-lex.l (%option): Add noyywrap
8450         (yywrap): Remove.
8451
8452 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8453
8454         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8455         _WIN32_WINNT to the XP level, unless already defined to a higher
8456         level.
8457
8458         * unittests/parse-connection-spec-selftests.c:
8459         * ser-tcp.c:
8460         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8461         override.
8462
8463         * symfile.c (find_separate_debug_file): Remove colon from the
8464         drive spec of DOS/Windows file names of the target, so that the
8465         file name produced from DEBUGDIR and the target's directory will
8466         be valid on DOS/Windows systems.
8467
8468 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8469
8470         * rust-lang.c (val_print_struct): Handle printing structures
8471         containing strings.
8472
8473 2019-05-02  Tom Tromey  <tromey@adacore.com>
8474
8475         * valarith.c (_initialize_valarith): Remove.
8476
8477 2019-05-01  Tom Tromey  <tromey@adacore.com>
8478
8479         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8480         bitfields.
8481
8482 2019-05-01  Tom Tromey  <tromey@adacore.com>
8483
8484         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8485         for big-endian copies.
8486
8487 2019-04-30  Ali Tamur  <tamur@google.com>
8488         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8489         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8490         (read_3_bytes): New function.
8491
8492 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8493
8494         * windows-nat.c (main_thread_id): Delete.
8495         (handle_output_debug_string): Replace main_thread_id by
8496         current_event.dwThreadId.
8497         (fake_create_process): Likewise.
8498         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8499         Do not set main_thread_id.
8500         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8501         current_event.dwThreadId.
8502         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8503
8504 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8505
8506         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8507         Use current_event.dwThreadId instead of main_thread_id.
8508
8509 2019-04-30  Tom Tromey  <tromey@adacore.com>
8510
8511         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8512         (create_excep_cond_exprs): Iterate over program spaces.
8513         (ada_exception_catchpoint_cond_string): Examine all minimal
8514         symbols for exception types.
8515
8516 2019-04-30  Tom Tromey  <tromey@adacore.com>
8517
8518         PR c++/24470:
8519         * dwarf2read.c (process_structure_scope): Handle case where type
8520         has template parameters but no symbol was created.
8521
8522 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8523             Chris January  <chris.january@arm.com>
8524
8525         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8526         qualifier.
8527         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8528
8529 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8530
8531         * f-typeprint.c (f_print_type): Update rules for printing
8532         whitespace.
8533         (f_type_print_varspec_suffix): Likewise.
8534
8535 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8536             Chris January  <chris.january@arm.com>
8537
8538         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8539         function arguments.
8540
8541 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8542
8543         * f-lang.c (build_fortran_types): Change name of void type to
8544         lower case.
8545         * f-typeprint.c (f_type_print_base): Print the name of the void
8546         type, rather than a fixed string.
8547         * f-valprint.c (f_decorations): Use lower case void string.
8548
8549 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8550             Chris January  <chris.january@arm.com>
8551
8552         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8553         types for Fortran.
8554
8555 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8556             Chris January  <chris.january@arm.com>
8557             David Lecomber  <david.lecomber@arm.com>
8558
8559         * f-exp.y (BINOP_INTRINSIC): New token.
8560         (exp): New parser rule handling BINOP_INTRINSIC.
8561         (f77_keywords): Add new builtin procedures.
8562         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8563         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8564         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8565         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8566         (print_unop_subexp_f): New function.
8567         (print_binop_subexp_f): New function.
8568         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8569         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8570         (dump_subexp_body_f): Likewise.
8571         (operator_check_f): Likewise.
8572         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8573         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8574
8575 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8576
8577         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8578         UNOP_KIND.
8579         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8580         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8581         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8582         (operator_length_f): New fuction.
8583         (print_subexp_f): New function.
8584         (op_name_f): New function.
8585         (dump_subexp_body_f): New function.
8586         (operator_check_f): New function.
8587         (exp_descriptor_f): Replace standard expression handling functions
8588         with new functions.
8589         * gdb/fortran-operator.def: New file.
8590         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8591         * gdb/std-operator.def: Remove UNOP_KIND.
8592
8593 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8594
8595         * std-operator.def: Remove unbalanced, stray double quote
8596         character.
8597
8598 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8599             Chris January  <chris.january@arm.com>
8600             Daniel Everett  <daniel.everett@arm.com>
8601             Nick Forrington  <nick.forrington@arm.com>
8602             Richard Bunt  <richard.bunt@arm.com>
8603
8604         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8605         of depth when printing anonymous structs or unions.
8606         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8607         Don't print either the top-level value, or the children if the
8608         max-depth is exceeded.
8609         (ppscm_print_children): When printing the key of a map, allow one
8610         extra level of depth.
8611         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8612         print either the top-level value, or the children if the max-depth
8613         is exceeded.
8614         (print_children): When printing the key of a map, allow one extra
8615         level of depth.
8616         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8617         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8618         (user_print_options): Initialise max_depth field.
8619         (val_print_scalar_or_string_type_p): New function.
8620         (val_print): Check to see if the max depth has been reached.
8621         (val_print_check_max_depth): Define new function.
8622         (show_print_max_depth): New function.
8623         (_initialize_valprint): Add 'print max-depth' option.
8624         * valprint.h (struct value_print_options) <max_depth>: New field.
8625         (val_print_check_max_depth): Declare new function.
8626         * NEWS: Document new feature.
8627
8628 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8629
8630         * ada-lang.c (ada_language_defn): Initialise new field.
8631         * c-lang.c (c_is_string_type_p): New function.
8632         (c_language_defn): Initialise new field.
8633         (cplus_language_defn): Initialise new field.
8634         (asm_language_defn): Initialise new field.
8635         (minimal_language_defn): Initialise new field.
8636         * c-lang.h (c_is_string_type_p): Declare new function.
8637         * d-lang.c (d_language_defn): Initialise new field.
8638         * f-lang.c (f_is_string_type_p): New function.
8639         (f_language_defn): Initialise new field.
8640         * go-lang.c (go_is_string_type_p): New function.
8641         (go_language_defn): Initialise new field.
8642         * language.c (default_is_string_type_p): New function.
8643         (unknown_language_defn): Initialise new field.
8644         (auto_language_defn): Initialise new field.
8645         * language.h (struct language_defn) <la_is_string_type_p>: New
8646         member variable.
8647         (default_is_string_type_p): Declare new function.
8648         * m2-lang.c (m2_language_defn): Initialise new field.
8649         * objc-lang.c (objc_language_defn): Initialise new field.
8650         * opencl-lang.c (opencl_language_defn): Initialise new field.
8651         * p-lang.c (pascal_is_string_type_p): New function.
8652         (pascal_language_defn): Initialise new field.
8653         * rust-lang.c (rust_is_string_type_p): New function.
8654         (rust_language_defn): Initialise new field.
8655
8656 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8657
8658         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8659         New field.
8660         * ada-lang.c (ada_language_defn): Initialise new field.
8661         * c-lang.c (c_language_defn): Likewise.
8662         (cplus_language_defn): Likewise.
8663         (asm_language_defn): Likewise.
8664         (minimal_language_defn): Likewise.
8665         * d-lang.c (d_language_defn): Likewise.
8666         * f-lang.c (f_language_defn): Likewise.
8667         * go-lang.c (go_language_defn): Likewise.
8668         * language.c (unknown_language_defn): Likewise.
8669         (auto_language_defn): Likewise.
8670         * m2-lang.c (m2_language_defn): Likewise.
8671         * objc-lang.c (objc_language_defn): Likewise.
8672         * opencl-lang.c (opencl_language_defn): Likewise.
8673         * p-lang.c (pascal_language_defn): Likewise.
8674         * rust-lang.c (rust_language_defn): Likewise.
8675
8676 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8677
8678         * ada-lang.c (ada_is_character_type): Change return type to bool.
8679         (ada_is_string_type): Likewise.
8680         * ada-lang.h (ada_is_character_type): Update declaration
8681         (ada_is_string_type): Likewise.
8682
8683 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8684
8685         Support style in 'frame|thread apply'
8686
8687         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8688         * record.c (record_start, record_stop): Update callers of
8689         execute_command_to_string with false.
8690         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8691         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8692         methods.
8693         (class string_file): New constructor with term_out parameter.
8694         Override methods term_out and can_emit_style_escape.  New member
8695         term_out.
8696         (class stdio_file): Override can_emit_style_escape.
8697         (class tee_file): Override term_out and can_emit_style_escape.
8698         * utils.h (can_emit_style_escape): Remove.
8699         * utils.c (can_emit_style_escape): Likewise.
8700         Update all callers of can_emit_style_escape (SOMESTREAM) to
8701         SOMESTREAM->can_emit_style_escape.
8702         * source-cache.c (source_cache::get_source_lines): Likewise.
8703         * stack.c (frame_apply_command_count): Call execute_command_to_string
8704         passing the term_out characteristic of the current gdb_stdout.
8705         * thread.c (thr_try_catch_cmd): Likewise.
8706         * top.c (execute_command_to_string): pass term_out parameter
8707         to construct the string_file for the command output.
8708         * ui-file.c (term_cli_styling): New function (most code moved
8709         from utils.c can_emit_style_escape).
8710         (string_file::string_file, string_file::can_emit_style_escape,
8711         stdio_file::can_emit_style_escape, tee_file::term_out,
8712         tee_file::can_emit_style_escape): New functions.
8713
8714 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8715
8716         * NEWS: Mention the new set|show may-call-functions.
8717         * infcall.c (may_call_functions_p): New variable.
8718         (show_may_call_functions_p): New function.
8719         (call_function_by_hand_dummy): Throws an error if not
8720         may-call-functions.
8721         (_initialize_infcall): Call add_setshow_boolean_cmd for
8722         may-call-functions.
8723
8724 2019-04-25  Keith Seitz  <keiths@redhat.com>
8725
8726         PR c++/24367
8727         * cp-support.c (inspect_type): Don't attempt substitutions
8728         of symbol with the same name.
8729
8730 2019-04-25  Tom Tromey  <tromey@adacore.com>
8731
8732         PR gdb/24475:
8733         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8734         static.
8735
8736 2019-04-25  Tom Tromey  <tromey@adacore.com>
8737
8738         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8739         rvalue reference.
8740         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8741         (gdb_xml_parser::parse): Use std::move.
8742         * python/python-internal.h (gdbpy_convert_exception): Take a const
8743         reference.
8744         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8745         std::move.
8746         * python/py-utils.c (gdbpy_convert_exception): Take a const
8747         reference.
8748         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8749         Use std::move.
8750         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8751         Use std::move.
8752         * mi/mi-main.c (mi_print_exception): Take a const reference.
8753         * main.c (handle_command_errors): Take a const reference.
8754         * linespec.c (parse_linespec): Use std::move.
8755         * infcall.c (run_inferior_call): Use std::move.
8756         (call_function_by_hand_dummy): Use std::move.
8757         * exec.c (try_open_exec_file): Use std::move.
8758         * exceptions.h (exception_print, exception_fprintf)
8759         (exception_print_same): Update.
8760         * exceptions.c (print_exception, exception_print)
8761         (exception_fprintf, exception_print_same): Change parameters to
8762         const reference.
8763         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8764         * common/new-op.c: Use std::move.
8765         * common/common-exceptions.h (struct gdb_exception): Add move
8766         constructor.
8767         (struct gdb_exception_error, struct gdb_exception_quit, struct
8768         gdb_quit_bad_alloc): Change constructor to move constructor.
8769         (throw_exception): Change parameter to rvalue reference.
8770         * common/common-exceptions.c (throw_exception): Take rvalue
8771         reference.
8772         * cli/cli-interp.c (safe_execute_command): Use std::move.
8773         * breakpoint.c (insert_bp_location, location_to_sals): Use
8774         std::move.
8775
8776 2019-04-25  Tom Tromey  <tromey@adacore.com>
8777
8778         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8779         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8780         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8781         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8782         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8783         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8784         guile/scm-value.c: Use unpack.
8785         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8786         gdbscm_gdb_exception.
8787         (gdbscm_throw_gdb_exception): Likewise.
8788         (struct gdbscm_gdb_exception): New.
8789         (unpack): New function.
8790         (gdbscm_wrap): Use unpack.
8791
8792 2019-04-25  Tom Tromey  <tromey@adacore.com>
8793
8794         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8795         (gdb_rl_callback_handler): Use std::move.
8796         * common/common-exceptions.h (struct gdb_exception): Add move
8797         assignment operator.
8798         (throw_exception_sjlj): Change "exception" to const reference.
8799         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8800         (throw_exception_sjlj): Change "exception" to const reference.
8801
8802 2019-04-25  Tom Tromey  <tromey@adacore.com>
8803
8804         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8805         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8806         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8807         Update.
8808         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8809         Update.
8810         * mi/mi-interp.c (mi_interp::exec): Update.
8811         * linespec.c (parse_linespec): Update.
8812         * infcall.c (run_inferior_call): Update.
8813         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8814         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8815         (gdbscm_lookup_global_symbol): Update.
8816         * guile/scm-param.c (gdbscm_parameter_value): Update.
8817         * guile/scm-frame.c (gdbscm_frame_read_register)
8818         (gdbscm_frame_read_var): Update.
8819         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8820         * exec.c (try_open_exec_file): Update.
8821         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8822         (gdb_rl_callback_handler): Update.
8823         * common/common-exceptions.h (exception_none): Don't declare.
8824         * common/common-exceptions.c (exception_none): Don't define.
8825         (struct catcher) <exception>: Update.
8826         * cli/cli-interp.c (safe_execute_command): Update.
8827         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8828
8829 2019-04-25  Ali Tamur  <tamur@google.com>
8830
8831         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8832         (read_attribute_value): Likewise.
8833         (dwarf2_read_addr_index): Update comment.
8834         (read_str_index): Add DW_FORM_strx.
8835         (dwarf2_string_attr): Likewise.
8836         (dwarf2_const_value_attr): Likewise.
8837         (dump_die_shallow): Likewise.
8838         (dwarf2_fetch_constant_bytes): Likewise.
8839         (skip_form_bytes): Likewise.
8840         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8841
8842 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8843
8844         PR corefiles/11608
8845         PR corefiles/18187
8846         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8847         OFFSET.  Verify if current mapping contains an ELF header.
8848         (linux_find_memory_regions_full): Adjust call to
8849         dump_mapping_p.
8850
8851 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8852             Kang Li <kanglictf@gmail.com>
8853
8854         PR gdb/21600
8855
8856         * dwarf2-frame.c (read_initial_length): Be consistent about using
8857         unsigned representation of length.
8858         (decode_frame_entry_1): Likewise.  Check for wraparound of
8859         end pointer as well as buffer overflow.
8860
8861 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8862
8863         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8864         "vq".
8865
8866 2019-04-24  Tom Tromey  <tromey@adacore.com>
8867
8868         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8869
8870 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8871
8872         * s12z-tdep.c (s12z_unwind_pc): Delete.
8873         (s12z_unwind_sp): Delete.
8874         (s12z_gdbarch_init): Don't register deleted functions with
8875         gdbarch.
8876
8877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8878
8879         * rl78-tdep.c (rl78_unwind_sp): Delete.
8880         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8881
8882 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8883
8884         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8885         (xstormy16_unwind_pc): Delete.
8886         (xstormy16_dummy_id): Delete.
8887         (xstormy16_gdbarch_init): Don't register deleted functions with
8888         gdbarch.
8889
8890 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8891
8892         * vax-tdep.c (vax_unwind_pc): Delete.
8893         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8894
8895 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8896
8897         * v850-tdep.c (v850_unwind_sp): Delete.
8898         (v850_unwind_pc): Delete.
8899         (v850_dummy_id): Delete.
8900         (v850_gdbarch_init): Don't register deleted functions with
8901         gdbarch.
8902
8903 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8904
8905         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8906         (tilegx_unwind_pc): Delete.
8907         (tilegx_unwind_dummy_id): Delete.
8908         (tilegx_gdbarch_init): Don't register deleted functions with
8909         gdbarch.
8910
8911 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8912
8913         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8914         (tic6x_dummy_id): Delete.
8915         (tic6x_gdbarch_init): Don't register deleted functions with
8916         gdbarch.
8917
8918 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8919
8920         * sparc-tdep.c (sparc_unwind_pc): Delete.
8921         (sparc32_gdbarch_init): Don't register deleted function with
8922         gdbarch.
8923
8924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8925
8926         * sh-tdep.c (sh_unwind_sp): Delete.
8927         (sh_unwind_pc): Delete.
8928         (sh_dummy_id): Delete.
8929         (sh_gdbarch_init): Don't register deleted functions with
8930         gdbarch.
8931
8932 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8933
8934         * score-tdep.c (score_unwind_sp): Delete.
8935         (score_unwind_pc): Delete.
8936         (score_dummy_id): Delete.
8937         (score_gdbarch_init): Don't register deleted functions with
8938         gdbarch.
8939
8940 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8941
8942         * rx-tdep.c (rx_unwind_pc): Delete.
8943         (rx_unwind_sp): Delete.
8944         (rx_dummy_id): Delete.
8945         (rx_gdbarch_init): Don't register deleted functions with
8946         gdbarch.  Update comment.
8947
8948 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8949
8950         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8951         (rs6000_dummy_id): Delete.
8952         (rs6000_gdbarch_init): Don't register deleted functions with
8953         gdbarch.
8954
8955 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8956
8957         * or1k-tdep.c (or1k_dummy_id): Delete.
8958         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8959
8960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8961
8962         * nios2-tdep.c (nios2_dummy_id): Delete.
8963         (nios2_unwind_sp): Delete.
8964         (nios2_gdbarch_init): Don't register deleted functions with
8965         gdbarch.
8966
8967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8968
8969         * nds32-tdep.c (nds32_dummy_id): Delete.
8970         (nds32_unwind_pc): Delete.
8971         (nds32_unwind_sp): Delete.
8972         (nds32_gdbarch_init): Don't register deleted functions with
8973         gdbarch.
8974
8975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8976
8977         * msp430-tdep.c (msp430_unwind_pc): Delete.
8978         (msp430_unwind_sp): Delete.
8979         (msp430_dummy_id): Delete.
8980         (msp430_gdbarch_init): Don't register deleted functions with
8981         gdbarch.
8982
8983 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8984
8985         * moxie-tdep.c (moxie_unwind_sp): Delete.
8986         (moxie_unwind_pc): Delete.
8987         (moxie_dummy_id): Delete.
8988         (moxie_gdbarch_init): Don't register deleted functions with
8989         gdbarch.
8990
8991 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8992
8993         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8994         (mn10300_unwind_pc): Delete.
8995         (mn10300_unwind_sp): Delete.
8996         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8997         mn10300_unwind_sp.
8998         (mn10300_frame_unwind_init): Don't register deleted functions with
8999         gdbarch.
9000
9001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9002
9003         * mep-tdep.c (mep_unwind_pc): Delete.
9004         (mep_unwind_sp): Delete.
9005         (mep_dummy_id): Delete.
9006         (mep_gdbarch_init): Don't register deleted functions with
9007         gdbarch.
9008
9009 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9010
9011         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9012         (m68hc11_unwind_sp): Delete.
9013         (m68hc11_gdbarch_init): Don't register deleted functions with
9014         gdbarch.
9015
9016 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9017
9018         * m32r-tdep.c (m32r_unwind_sp): Delete.
9019         (m32r_unwind_pc): Delete.
9020         (m32r_dummy_id): Delete.
9021         (m32r_gdbarch_init): Don't register deleted functions with
9022         gdbarch.
9023
9024 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9025
9026         * m32c-tdep.c (m32c_unwind_pc): Delete.
9027         (m32c_unwind_sp): Delete.
9028         (m32c_dummy_id): Delete.
9029         (m32c_gdbarch_init): Don't register deleted functions with
9030         gdbarch.
9031
9032 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9033
9034         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9035         (lm32_unwind_pc): Delete.
9036         (lm32_dummy_id): Delete.
9037         (lm32_gdbarch_init): Don't register deleted functions with
9038         gdbarch.
9039
9040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9041
9042         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9043         (iq2000_unwind_pc): Delete.
9044         (iq2000_dummy_id): Delete.
9045         (iq2000_gdbarch_init): Don't register deleted functions with
9046         gdbarch.
9047
9048 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9049
9050         * nds32-tdep.c (nds32_type_align): Delete.
9051         (nds32_push_dummy_call): Use type_align instead.
9052
9053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9054
9055         * arm-tdep.c (arm_type_align): Only handle vector override case.
9056         (arm_push_dummy_call): Use type_align.
9057         (arm_gdbarch_init): Register arm_type_align gdbarch function.
9058
9059 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
9060
9061         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9062         case.
9063         (pass_on_stack): Use type_align.
9064         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9065         function.
9066
9067 2019-04-23  Tom Tromey  <tromey@adacore.com>
9068
9069         * dwarf2read.c (line_header::file_name_at): Remove unused
9070         overload.
9071
9072 2019-04-23  Tom de Vries  <tdevries@suse.de>
9073
9074         PR gdb/24438
9075         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9076         invocation.
9077
9078
9079 2019-03-27  Ali Tamur  <tamur@google.com>
9080
9081         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9082         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9083         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9084         (dwarf_expr_context::get_addr_index): Likewise
9085         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9086         (symbol_needs_eval_context::get_addr_index): Likewise
9087         (disassemble_dwarf_expression): Add DW_OP_addrx
9088         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9089         (read_cutu_die_from_dwo): Update comment
9090         (skip_one_die): Add DW_FORM_addrx
9091         (read_attribute_value): Likewise
9092         (var_decode_location): Add DW_OP_addrx
9093         (dwarf2_const_value_attr): Add DW_FORM_addrx
9094         (dump_die_shallow): Likewise
9095         (dwarf2_fetch_constant_bytes): Likewise
9096         (decode_locdesc): Add DW_OP_addrx
9097         (skip_form_bytes): Add DW_FORM_addrx
9098
9099 2019-04-22  Ali Tamur  <tamur@google.com>
9100
9101         * MAINTAINERS (Write After Approval): Add self.
9102
9103 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
9104
9105         * solib-svr4.c (get_svr4_info): Add pspace parameter.
9106         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9107         (open_symbol_file_object): Likewise.
9108         (svr4_default_sos): Add info parameter.
9109         (svr4_read_so_list): Likewise.
9110         (svr4_current_sos_direct): Adjust functions calls to pass down
9111         info.
9112         (svr4_current_sos_1): Add info parameter.
9113         (svr4_current_sos): Call get_svr4_info, pass info down to
9114         svr4_current_sos_1.
9115         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9116         get_svr4_info.
9117         (svr4_in_dynsym_resolve_code): Pass current_program_space to
9118         get_svr4_info.
9119         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9120         to get_svr4_info.
9121         (probes_table_remove_objfile_probes): Likewise.
9122         (register_solib_event_probe): Add info parameter.
9123         (solist_update_incremental): Pass info parameter down to
9124         svr4_read_so_list.
9125         (disable_probes_interface): Add info parameter.
9126         (svr4_handle_solib_event): Pass current_program_space to
9127         get_svr4_info.  Adjust disable_probes_interface cleanup.
9128         (svr4_create_probe_breakpoints): Add info parameter, pass it
9129         down to register_solib_event_probe.
9130         (svr4_create_solib_event_breakpoints): Add info parameter,
9131         pass it down to svr4_create_probe_breakpoints.
9132         (enable_break): Pass info down to
9133         svr4_create_solib_event_breakpoints.
9134         (svr4_solib_create_inferior_hook): Pass current_program_space to
9135         get_svr4_info.
9136         (svr4_clear_solib): Likewise.
9137
9138 2019-04-22  Pedro Alves  <palves@redhat.com>
9139
9140         * solib-svr4.c (svr4_free_objfile_observer): New.
9141         (probe_and_action::objfile): New field.
9142         (probes_table_htab_remove_objfile_probes)
9143         (probes_table_remove_objfile_probes): New functions.
9144         (register_solib_event_probe): Add 'objfile' parameter.  Store it
9145         in the new probe_and_action.  Don't store the probe in 'lookup'.
9146         (svr4_create_probe_breakpoints): Pass objfile to
9147         register_solib_event_probe.
9148         (_initialize_svr4_solib): Register a free_objfile observer.
9149
9150 2019-04-19  Tom Tromey  <tom@tromey.com>
9151
9152         * common/queue.h: Remove.
9153
9154 2019-04-19  Tom Tromey  <tom@tromey.com>
9155
9156         * event-loop.c: Don't include "common/queue.h".
9157
9158 2019-04-19  Tom Tromey  <tom@tromey.com>
9159
9160         * remote.c (remote_target): Use delete.
9161         * remote-notif.h: Include <list>, not "common/queue.h".
9162         (notif_client_p): Remove typedef.
9163         (remote_notif_state): Add constructor, destructor, initializer.
9164         <notif_queue>: Now a std::list.
9165         (remote_notif_state_xfree): Don't declare.
9166         * remote-notif.c (remote_notif_process, handle_notification)
9167         (remote_notif_state_allocate): Update.
9168         (~remote_notif_state): Rename from remote_notif_state_xfree.
9169
9170 2019-04-19  Tom Tromey  <tom@tromey.com>
9171
9172         * symfile.c (reread_symbols): Update.
9173         * objfiles.c (objfile_register_static_link)
9174         (objfile_lookup_static_link): Update
9175         (~objfile) Don't delete static_links.
9176         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9177
9178 2019-04-19  Tom Tromey  <tom@tromey.com>
9179
9180         * type-stack.h (struct type_stack) <insert>: Constify string.
9181         * type-stack.c (type_stack::insert): Constify string.
9182         * gdbtypes.h (lookup_template_type): Update.
9183         (address_space_name_to_int): Update.
9184         * gdbtypes.c (address_space_name_to_int): Make space_identifier
9185         const.
9186         (lookup_template_type): Make name const.
9187         * c-exp.y: Update rules.
9188         (lex_one_token, classify_name, classify_inner_name)
9189         (c_print_token): Update.
9190         * p-exp.y: Update rules.
9191         (yylex): Update.
9192         * f-exp.y: Update rules.
9193         (yylex): Update.
9194         * d-exp.y: Update rules.
9195         (lex_one_token, classify_name, classify_inner_name): Update.
9196         * parse.c (write_dollar_variable, copy_name): Return std::string.
9197         * parser-defs.h (copy_name): Change return type.
9198         * m2-exp.y: Update rules.
9199         (yylex): Update.
9200         * go-exp.y (lex_one_token): Update.
9201         Update rules.
9202         (classify_unsafe_function, classify_packaged_name)
9203         (classify_name, yylex): Update.
9204
9205 2019-04-19  Sergei Trofimovich <siarheit@google.com>
9206
9207         * configure.ac: add --enable-source-highlight switch.
9208         * configure: Regenerate.
9209         * top.c (print_gdb_version): plumb --enable-source-highlight
9210         status to "show configuration".
9211
9212 2019-04-19  Tom Tromey  <tromey@adacore.com>
9213
9214         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9215         Check ADA_TYPE_P.
9216         (empty_record, ada_template_to_fixed_record_type_1)
9217         (template_to_static_fixed_type)
9218         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9219         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9220         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9221         macros.
9222
9223 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
9224
9225         PR symtab/24423:
9226         * source.c (print_source_lines_base): Advance "iter" when a
9227         control character is seen.
9228
9229 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9230
9231         * inferior.h (struct infcall_suspend_state_deleter):
9232         Catch exception in destructor to avoid crash.
9233
9234 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9235
9236         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
9237         close to the add_com "shell".
9238
9239 2019-04-18  Tom Tromey  <tromey@adacore.com>
9240
9241         * process-stratum-target.h (class process_stratum_target)
9242         <stratum>: Add "final".
9243
9244 2019-04-17  Tom Tromey  <tromey@adacore.com>
9245
9246         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
9247         against nullptr before use.
9248
9249 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
9250
9251         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
9252
9253 2019-04-17  Jim Wilson  <jimw@sifive.com>
9254             Andrew Burgess  <andrew.burgess@embecosm.com>
9255
9256         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
9257         code read might fail, assume 4-byte breakpoint in that case.
9258
9259 2019-04-15  Leszek Swirski  <leszeks@google.com>
9260
9261         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
9262         rather than a hand-rolled POD check when checking for forced MEMORY
9263         classification.
9264
9265 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9266
9267         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
9268         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
9269         function.
9270         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
9271         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
9272         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
9273         declaration.
9274
9275 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9276
9277         * aarch64-linux-nat.c
9278         (aarch64_linux_nat_target::thread_architecture): Add override.
9279         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
9280         each VQ.
9281
9282 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
9283
9284         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9285
9286 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9287
9288         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9289         target types of size 96-bits, add some additional comments, and
9290         check that the builtin type we found was the correct size.
9291
9292 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9293
9294         * utils.c (prompt_for_continue): Don't restore the styling at the
9295         end, as applied_style has the wrong value.  This fixes styling in
9296         long lists of file names that are interrupted by the "Continue?"
9297         prompt.
9298
9299 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9300
9301         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9302         * c-lang.c (c_language_defn): Likewise.
9303         (cplus_language_defn): Likewise.
9304         (asm_language_defn): Likewise.
9305         (minimal_language_defn): Likewise.
9306         * d-lang.c (d_language_defn): Likewise.
9307         * f-lang.c (f_language_defn): Likewise.
9308         * go-lang.c (go_language_defn): Likewise.
9309         * language.c (unknown_language_defn): Likewise.
9310         (auto_language_defn): Likewise.
9311         * language.h (struct language_defn): Remove la_magic field.
9312         (LANG_MAGIC): Delete.
9313         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9314         * objc-lang.c (objc_language_defn): Likewise.
9315         * opencl-lang.c (opencl_language_defn): Likewise.
9316         * p-lang.c (pascal_language_defn): Likewise.
9317         * rust-lang.c (rust_language_defn): Likewise.
9318
9319 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9320
9321         * riscv-tdep.c (riscv_type_align): New function.
9322         (riscv_type_alignment): Delete.
9323         (riscv_arg_location): Use 'type_align'.
9324         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9325
9326 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9327
9328         * gdbtypes.c (type_align): A struct with no non-static fields also
9329         has alignment of 1.
9330
9331 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9332
9333         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9334         component to 0.
9335         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9336         member.
9337         (riscv_struct_info::analyse): New implementation using new
9338         analyse_inner member function.
9339         (riscv_struct_info::field_offset): New member function.
9340         (riscv_struct_info::m_offsets): New member variable.
9341         (riscv_struct_info::analyse_inner): New private member function,
9342         takes the old implementation of riscv_struct_info::analyse but
9343         extended to track field offsets.
9344         (riscv_call_arg_struct): Update the struct folding special cases
9345         to handle cases where empty C++ structs, which are non-zero
9346         length, are found.
9347         (riscv_arg_location): Initialise the length of each location, a
9348         non-zero length now indicates the location is in use.
9349         (riscv_push_dummy_call): Allow for the first location having a
9350         non-zero offset when setting up arguments.
9351         (riscv_return_value): Likewise, but for return values.
9352
9353 2019-04-11  Tom Tromey  <tromey@adacore.com>
9354
9355         * utils.c (internal_vproblem): Make "msg" const.
9356
9357 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9358
9359         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9360         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9361         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9362         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9363
9364 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9365
9366         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9367         function.
9368         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9369         of amd64_collect_native_gregset.
9370         (amd64_linux_nat_target::store_registers): Likewise.
9371
9372 2019-04-10  Tom Tromey  <tom@tromey.com>
9373
9374         * symtab.c (lookup_global_symbol_from_objfile)
9375         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9376         * objfiles.h (class separate_debug_iterator): New.
9377         (class separate_debug_range): New.
9378         (struct objfile) <separate_debug_objfiles>: New method.
9379         (objfile_separate_debug_iterate): Don't declare.
9380         * objfiles.c (separate_debug_iterator::operator++): Rename from
9381         objfile_separate_debug_iterate.
9382         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9383         iterator.
9384         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9385         iterator.
9386
9387 2019-04-10  Tom Tromey  <tom@tromey.com>
9388
9389         * symfile.c (reread_symbols): Remove old comment.
9390         * objfiles.c (free_all_objfiles): Fix a typo.
9391
9392 2019-04-10  Tom Tromey  <tom@tromey.com>
9393
9394         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9395         * minsyms.c (lookup_minimal_symbol): Use foreach.
9396         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9397         (lookup_minimal_symbol_solib_trampoline): Likewise.
9398         * symfile.c (reread_symbols): Use foreach.
9399
9400 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9401             Tom Tromey  <tromey@adacore.com>
9402
9403         PR rust/24414:
9404         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9405         (rust_lex_int_test): Change "value" to be LONGEST.
9406         (rust_lex_tests): Add test for long integer literal.
9407
9408 2019-04-09  Tom Tromey  <tromey@adacore.com>
9409
9410         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9411         to bool.
9412         (extended_remote_target::attach): Update.
9413         (remote_target::remote_notice_new_inferior): Update.
9414         (remote_target::add_current_inferior_and_thread): Update.
9415         * inferior.c (exit_inferior_1): Use "false".
9416         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9417
9418 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9419
9420         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9421         the "start" command.
9422
9423 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9424
9425         * python/py-inferior.c (infpy_thread_from_thread_handle):
9426         Adjust comments to reflect renaming of thread_from_thread_handle
9427         to thread_from_handle.  Adjust keywords.  Fix type error message.
9428         (inferior_object_methods): Add thread_from_handle.  Retain
9429         thread_from_thread_handle, but mark it as deprecated.
9430
9431 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9432
9433         * gdbthread.h (find_thread_by_handle): Revise declaration.
9434         * thread.c (find_thread_by_handle): Likewise.  Adjust
9435         implementation too.
9436         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9437         support for buffer objects as handles.
9438
9439 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9440
9441         * python/py-infthread.c (thpy_thread_handle): New function.
9442         (thread_object_methods): Register thpy_thread_handle.
9443
9444 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9445
9446         * gdbthread.h (thread_to_thread_handle): Declare.
9447         * thread.c (gdbtypes.h): Include.
9448         (thread_to_thread_handle): New function.
9449
9450         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9451         (target_thread_info_to_thread_handle): Declare.
9452         * target.c (target_thread_info_to_thread_handle): New function.
9453         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9454         * target-delegates.c: Regenerate.
9455
9456         * linux-thread-db.c (class thread_db_target): Add method
9457         thread_info_to_thread_handle.
9458         (thread_db_target::thread_info_to_thread_handle): Define.
9459         * remote.c (class remote_target): Add new method
9460         thread_info_to_thread_handle.
9461         (remote_target::thread_info_to_thread_handle): Define.
9462
9463 2019-04-08  Pedro Alves  <palves@redhat.com>
9464
9465         * common/common-exceptions.c (throw_exception): Don't create
9466         named object to throw; throw directly.
9467         (throw_it): Likewise.  Don't initialize gdb_exception::message
9468         here, with new; pass FMT and AP to the ctor instead.
9469         * common/common-exceptions.h: Include <string>.
9470         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9471         const char *, va_list)): New ctor.  Use std::make_shared.
9472         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9473         errors)): Delete.
9474         (gdb_exception_error::gdb_exception_error(enum errors, const char
9475         *, va_list)): New.
9476         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9477         Add assertion.
9478         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9479         errors)): Delete.
9480         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9481         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9482         Add assertion.
9483
9484 2019-04-08  Tom Tromey  <tom@tromey.com>
9485
9486         * valops.c (value_rtti_indirect_type): Replace throw_exception
9487         with throw.
9488         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9489         with throw.
9490         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9491         throw.
9492         * target.c (target_translate_tls_address): Replace throw_exception
9493         with throw.
9494         * stack.c (frame_apply_command_count): Replace throw_exception
9495         with throw.
9496         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9497         throw.
9498         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9499         with throw.
9500         * rs6000-tdep.c (rs6000_frame_cache)
9501         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9502         * remote.c: Replace throw_exception with throw.
9503         * record-full.c (record_full_message, record_full_wait_1)
9504         (record_full_restore): Replace throw_exception with throw.
9505         * record-btrace.c:
9506         (get_thread_current_frame_id, record_btrace_start_replaying)
9507         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9508         (cmd_record_btrace_start): Replace throw_exception with throw.
9509         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9510         throw.
9511         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9512         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9513         * linespec.c:
9514         (find_linespec_symbols): Replace throw_exception with throw.
9515         * infrun.c (displaced_step_prepare, resume): Replace
9516         throw_exception with throw.
9517         * infcmd.c (post_create_inferior): Replace throw_exception with
9518         throw.
9519         * inf-loop.c (inferior_event_handler): Replace throw_exception
9520         with throw.
9521         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9522         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9523         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9524         (get_prev_frame_always, get_frame_pc_if_available)
9525         (get_frame_address_in_block_if_available, get_frame_language):
9526         Replace throw_exception with throw.
9527         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9528         throw_exception with throw.
9529         * eval.c (fetch_subexp_value, evaluate_var_value)
9530         (evaluate_funcall, evaluate_subexp_standard): Replace
9531         throw_exception with throw.
9532         * dwarf2loc.c (call_site_find_chain)
9533         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9534         Replace throw_exception with throw.
9535         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9536         with throw.
9537         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9538         throw.
9539         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9540         * completer.c (complete_line_internal): Replace throw_exception
9541         with throw.
9542         * compile/compile-object-run.c (compile_object_run): Replace
9543         throw_exception with throw.
9544         * cli/cli-script.c (process_next_line): Replace throw_exception
9545         with throw.
9546         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9547         (btrace_enable, btrace_maint_update_pt_packets): Replace
9548         throw_exception with throw.
9549         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9550         throw_exception with throw.
9551         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9552         throw_exception with throw.
9553         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9554         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9555         * aarch64-tdep.c (aarch64_make_prologue_cache)
9556         (aarch64_make_stub_cache): Replace throw_exception with throw.
9557
9558 2019-04-08  Tom Tromey  <tom@tromey.com>
9559
9560         * common/common-exceptions.c (throw_exception): Rename from
9561         throw_exception_cxx.  Remove old copy.  Make argument const.
9562         (throw_it): Create and throw exception objects directly.
9563         * common/common-exceptions.h (throw_exception): Make argument
9564         const.
9565         (struct gdb_exception_error): Add constructor.
9566         (struct gdb_exception_quit): Add constructor.
9567
9568 2019-04-08  Tom Tromey  <tom@tromey.com>
9569
9570         * common/common-exceptions.h (exception_rethrow): Don't declare.
9571         (TRY_SJLJ): Update comment.
9572         (TRY, CATCH, END_CATCH): Remove.
9573         * common/common-exceptions.c (exception_rethrow): Remove.
9574
9575 2019-04-08  Tom Tromey  <tom@tromey.com>
9576
9577         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9578         Remove.
9579         (gdb_exception_error): Rename from
9580         gdb_exception_RETURN_MASK_ERROR.
9581         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9582         (gdb_quit_bad_alloc): Update.
9583         * aarch64-tdep.c: Update.
9584         * ada-lang.c: Update.
9585         * ada-typeprint.c: Update.
9586         * ada-valprint.c: Update.
9587         * amd64-tdep.c: Update.
9588         * arch-utils.c: Update.
9589         * break-catch-throw.c: Update.
9590         * breakpoint.c: Update.
9591         * btrace.c: Update.
9592         * c-varobj.c: Update.
9593         * cli/cli-cmds.c: Update.
9594         * cli/cli-interp.c: Update.
9595         * cli/cli-script.c: Update.
9596         * common/common-exceptions.c: Update.
9597         * common/new-op.c: Update.
9598         * common/selftest.c: Update.
9599         * compile/compile-c-symbols.c: Update.
9600         * compile/compile-cplus-symbols.c: Update.
9601         * compile/compile-object-load.c: Update.
9602         * compile/compile-object-run.c: Update.
9603         * completer.c: Update.
9604         * corelow.c: Update.
9605         * cp-abi.c: Update.
9606         * cp-support.c: Update.
9607         * cp-valprint.c: Update.
9608         * darwin-nat.c: Update.
9609         * disasm-selftests.c: Update.
9610         * dtrace-probe.c: Update.
9611         * dwarf-index-cache.c: Update.
9612         * dwarf-index-write.c: Update.
9613         * dwarf2-frame-tailcall.c: Update.
9614         * dwarf2-frame.c: Update.
9615         * dwarf2loc.c: Update.
9616         * dwarf2read.c: Update.
9617         * eval.c: Update.
9618         * event-loop.c: Update.
9619         * event-top.c: Update.
9620         * exec.c: Update.
9621         * f-valprint.c: Update.
9622         * fbsd-tdep.c: Update.
9623         * frame-unwind.c: Update.
9624         * frame.c: Update.
9625         * gdbtypes.c: Update.
9626         * gnu-v3-abi.c: Update.
9627         * guile/guile-internal.h: Update.
9628         * guile/scm-block.c: Update.
9629         * guile/scm-breakpoint.c: Update.
9630         * guile/scm-cmd.c: Update.
9631         * guile/scm-disasm.c: Update.
9632         * guile/scm-frame.c: Update.
9633         * guile/scm-lazy-string.c: Update.
9634         * guile/scm-math.c: Update.
9635         * guile/scm-param.c: Update.
9636         * guile/scm-ports.c: Update.
9637         * guile/scm-pretty-print.c: Update.
9638         * guile/scm-symbol.c: Update.
9639         * guile/scm-symtab.c: Update.
9640         * guile/scm-type.c: Update.
9641         * guile/scm-value.c: Update.
9642         * i386-linux-tdep.c: Update.
9643         * i386-tdep.c: Update.
9644         * inf-loop.c: Update.
9645         * infcall.c: Update.
9646         * infcmd.c: Update.
9647         * infrun.c: Update.
9648         * jit.c: Update.
9649         * language.c: Update.
9650         * linespec.c: Update.
9651         * linux-fork.c: Update.
9652         * linux-nat.c: Update.
9653         * linux-tdep.c: Update.
9654         * linux-thread-db.c: Update.
9655         * main.c: Update.
9656         * mi/mi-cmd-break.c: Update.
9657         * mi/mi-cmd-stack.c: Update.
9658         * mi/mi-interp.c: Update.
9659         * mi/mi-main.c: Update.
9660         * objc-lang.c: Update.
9661         * p-valprint.c: Update.
9662         * parse.c: Update.
9663         * ppc-linux-tdep.c: Update.
9664         * printcmd.c: Update.
9665         * python/py-arch.c: Update.
9666         * python/py-breakpoint.c: Update.
9667         * python/py-cmd.c: Update.
9668         * python/py-finishbreakpoint.c: Update.
9669         * python/py-frame.c: Update.
9670         * python/py-framefilter.c: Update.
9671         * python/py-gdb-readline.c: Update.
9672         * python/py-inferior.c: Update.
9673         * python/py-infthread.c: Update.
9674         * python/py-lazy-string.c: Update.
9675         * python/py-linetable.c: Update.
9676         * python/py-objfile.c: Update.
9677         * python/py-param.c: Update.
9678         * python/py-prettyprint.c: Update.
9679         * python/py-progspace.c: Update.
9680         * python/py-record-btrace.c: Update.
9681         * python/py-record.c: Update.
9682         * python/py-symbol.c: Update.
9683         * python/py-type.c: Update.
9684         * python/py-unwind.c: Update.
9685         * python/py-utils.c: Update.
9686         * python/py-value.c: Update.
9687         * python/python.c: Update.
9688         * record-btrace.c: Update.
9689         * record-full.c: Update.
9690         * remote-fileio.c: Update.
9691         * remote.c: Update.
9692         * riscv-tdep.c: Update.
9693         * rs6000-aix-tdep.c: Update.
9694         * rs6000-tdep.c: Update.
9695         * rust-exp.y: Update.
9696         * rust-lang.c: Update.
9697         * s390-tdep.c: Update.
9698         * selftest-arch.c: Update.
9699         * solib-dsbt.c: Update.
9700         * solib-frv.c: Update.
9701         * solib-spu.c: Update.
9702         * solib-svr4.c: Update.
9703         * solib.c: Update.
9704         * sparc64-linux-tdep.c: Update.
9705         * stack.c: Update.
9706         * symfile-mem.c: Update.
9707         * symmisc.c: Update.
9708         * target.c: Update.
9709         * thread.c: Update.
9710         * top.c: Update.
9711         * tracefile-tfile.c: Update.
9712         * tui/tui.c: Update.
9713         * typeprint.c: Update.
9714         * unittests/cli-utils-selftests.c: Update.
9715         * unittests/parse-connection-spec-selftests.c: Update.
9716         * valops.c: Update.
9717         * valprint.c: Update.
9718         * value.c: Update.
9719         * varobj.c: Update.
9720         * windows-nat.c: Update.
9721         * x86-linux-nat.c: Update.
9722         * xml-support.c: Update.
9723
9724 2019-04-08  Tom Tromey  <tom@tromey.com>
9725
9726         * xml-support.c: Use C++ exception handling.
9727         * x86-linux-nat.c: Use C++ exception handling.
9728         * windows-nat.c: Use C++ exception handling.
9729         * varobj.c: Use C++ exception handling.
9730         * value.c: Use C++ exception handling.
9731         * valprint.c: Use C++ exception handling.
9732         * valops.c: Use C++ exception handling.
9733         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9734         handling.
9735         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9736         * typeprint.c: Use C++ exception handling.
9737         * tui/tui.c: Use C++ exception handling.
9738         * tracefile-tfile.c: Use C++ exception handling.
9739         * top.c: Use C++ exception handling.
9740         * thread.c: Use C++ exception handling.
9741         * target.c: Use C++ exception handling.
9742         * symmisc.c: Use C++ exception handling.
9743         * symfile-mem.c: Use C++ exception handling.
9744         * stack.c: Use C++ exception handling.
9745         * sparc64-linux-tdep.c: Use C++ exception handling.
9746         * solib.c: Use C++ exception handling.
9747         * solib-svr4.c: Use C++ exception handling.
9748         * solib-spu.c: Use C++ exception handling.
9749         * solib-frv.c: Use C++ exception handling.
9750         * solib-dsbt.c: Use C++ exception handling.
9751         * selftest-arch.c: Use C++ exception handling.
9752         * s390-tdep.c: Use C++ exception handling.
9753         * rust-lang.c: Use C++ exception handling.
9754         * rust-exp.y: Use C++ exception handling.
9755         * rs6000-tdep.c: Use C++ exception handling.
9756         * rs6000-aix-tdep.c: Use C++ exception handling.
9757         * riscv-tdep.c: Use C++ exception handling.
9758         * remote.c: Use C++ exception handling.
9759         * remote-fileio.c: Use C++ exception handling.
9760         * record-full.c: Use C++ exception handling.
9761         * record-btrace.c: Use C++ exception handling.
9762         * python/python.c: Use C++ exception handling.
9763         * python/py-value.c: Use C++ exception handling.
9764         * python/py-utils.c: Use C++ exception handling.
9765         * python/py-unwind.c: Use C++ exception handling.
9766         * python/py-type.c: Use C++ exception handling.
9767         * python/py-symbol.c: Use C++ exception handling.
9768         * python/py-record.c: Use C++ exception handling.
9769         * python/py-record-btrace.c: Use C++ exception handling.
9770         * python/py-progspace.c: Use C++ exception handling.
9771         * python/py-prettyprint.c: Use C++ exception handling.
9772         * python/py-param.c: Use C++ exception handling.
9773         * python/py-objfile.c: Use C++ exception handling.
9774         * python/py-linetable.c: Use C++ exception handling.
9775         * python/py-lazy-string.c: Use C++ exception handling.
9776         * python/py-infthread.c: Use C++ exception handling.
9777         * python/py-inferior.c: Use C++ exception handling.
9778         * python/py-gdb-readline.c: Use C++ exception handling.
9779         * python/py-framefilter.c: Use C++ exception handling.
9780         * python/py-frame.c: Use C++ exception handling.
9781         * python/py-finishbreakpoint.c: Use C++ exception handling.
9782         * python/py-cmd.c: Use C++ exception handling.
9783         * python/py-breakpoint.c: Use C++ exception handling.
9784         * python/py-arch.c: Use C++ exception handling.
9785         * printcmd.c: Use C++ exception handling.
9786         * ppc-linux-tdep.c: Use C++ exception handling.
9787         * parse.c: Use C++ exception handling.
9788         * p-valprint.c: Use C++ exception handling.
9789         * objc-lang.c: Use C++ exception handling.
9790         * mi/mi-main.c: Use C++ exception handling.
9791         * mi/mi-interp.c: Use C++ exception handling.
9792         * mi/mi-cmd-stack.c: Use C++ exception handling.
9793         * mi/mi-cmd-break.c: Use C++ exception handling.
9794         * main.c: Use C++ exception handling.
9795         * linux-thread-db.c: Use C++ exception handling.
9796         * linux-tdep.c: Use C++ exception handling.
9797         * linux-nat.c: Use C++ exception handling.
9798         * linux-fork.c: Use C++ exception handling.
9799         * linespec.c: Use C++ exception handling.
9800         * language.c: Use C++ exception handling.
9801         * jit.c: Use C++ exception handling.
9802         * infrun.c: Use C++ exception handling.
9803         * infcmd.c: Use C++ exception handling.
9804         * infcall.c: Use C++ exception handling.
9805         * inf-loop.c: Use C++ exception handling.
9806         * i386-tdep.c: Use C++ exception handling.
9807         * i386-linux-tdep.c: Use C++ exception handling.
9808         * guile/scm-value.c: Use C++ exception handling.
9809         * guile/scm-type.c: Use C++ exception handling.
9810         * guile/scm-symtab.c: Use C++ exception handling.
9811         * guile/scm-symbol.c: Use C++ exception handling.
9812         * guile/scm-pretty-print.c: Use C++ exception handling.
9813         * guile/scm-ports.c: Use C++ exception handling.
9814         * guile/scm-param.c: Use C++ exception handling.
9815         * guile/scm-math.c: Use C++ exception handling.
9816         * guile/scm-lazy-string.c: Use C++ exception handling.
9817         * guile/scm-frame.c: Use C++ exception handling.
9818         * guile/scm-disasm.c: Use C++ exception handling.
9819         * guile/scm-cmd.c: Use C++ exception handling.
9820         * guile/scm-breakpoint.c: Use C++ exception handling.
9821         * guile/scm-block.c: Use C++ exception handling.
9822         * guile/guile-internal.h: Use C++ exception handling.
9823         * gnu-v3-abi.c: Use C++ exception handling.
9824         * gdbtypes.c: Use C++ exception handling.
9825         * frame.c: Use C++ exception handling.
9826         * frame-unwind.c: Use C++ exception handling.
9827         * fbsd-tdep.c: Use C++ exception handling.
9828         * f-valprint.c: Use C++ exception handling.
9829         * exec.c: Use C++ exception handling.
9830         * event-top.c: Use C++ exception handling.
9831         * event-loop.c: Use C++ exception handling.
9832         * eval.c: Use C++ exception handling.
9833         * dwarf2read.c: Use C++ exception handling.
9834         * dwarf2loc.c: Use C++ exception handling.
9835         * dwarf2-frame.c: Use C++ exception handling.
9836         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9837         * dwarf-index-write.c: Use C++ exception handling.
9838         * dwarf-index-cache.c: Use C++ exception handling.
9839         * dtrace-probe.c: Use C++ exception handling.
9840         * disasm-selftests.c: Use C++ exception handling.
9841         * darwin-nat.c: Use C++ exception handling.
9842         * cp-valprint.c: Use C++ exception handling.
9843         * cp-support.c: Use C++ exception handling.
9844         * cp-abi.c: Use C++ exception handling.
9845         * corelow.c: Use C++ exception handling.
9846         * completer.c: Use C++ exception handling.
9847         * compile/compile-object-run.c: Use C++ exception handling.
9848         * compile/compile-object-load.c: Use C++ exception handling.
9849         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9850         * compile/compile-c-symbols.c: Use C++ exception handling.
9851         * common/selftest.c: Use C++ exception handling.
9852         * common/new-op.c: Use C++ exception handling.
9853         * cli/cli-script.c: Use C++ exception handling.
9854         * cli/cli-interp.c: Use C++ exception handling.
9855         * cli/cli-cmds.c: Use C++ exception handling.
9856         * c-varobj.c: Use C++ exception handling.
9857         * btrace.c: Use C++ exception handling.
9858         * breakpoint.c: Use C++ exception handling.
9859         * break-catch-throw.c: Use C++ exception handling.
9860         * arch-utils.c: Use C++ exception handling.
9861         * amd64-tdep.c: Use C++ exception handling.
9862         * ada-valprint.c: Use C++ exception handling.
9863         * ada-typeprint.c: Use C++ exception handling.
9864         * ada-lang.c: Use C++ exception handling.
9865         * aarch64-tdep.c: Use C++ exception handling.
9866
9867 2019-04-08  Tom Tromey  <tom@tromey.com>
9868
9869         * xml-support.c (gdb_xml_parser::parse): Update.
9870         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9871         * value.c (show_convenience): Update.
9872         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9873         (test_parse_flags_qcs): Update.
9874         * thread.c (thr_try_catch_cmd): Update.
9875         * target.c (target_translate_tls_address): Update.
9876         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9877         (info_frame_command_core, frame_apply_command_count): Update.
9878         * rust-exp.y (rust_lex_exception_test): Update.
9879         * riscv-tdep.c (riscv_print_one_register_info): Update.
9880         * remote.c (remote_target::enable_btrace): Update.
9881         * record-btrace.c (record_btrace_enable_warn): Update.
9882         * python/py-utils.c (gdbpy_convert_exception): Update.
9883         * printcmd.c (do_one_display, print_variable_and_value): Update.
9884         * mi/mi-main.c (mi_print_exception): Update.
9885         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9886         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9887         * linux-nat.c (linux_nat_target::attach): Update.
9888         * linux-fork.c (class scoped_switch_fork_info): Update.
9889         * infrun.c (displaced_step_prepare): Update.
9890         * infcall.c (call_function_by_hand_dummy): Update.
9891         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9892         * gnu-v3-abi.c (print_one_vtable): Update.
9893         * frame.c (get_prev_frame_always): Update.
9894         * f-valprint.c (info_common_command_for_block): Update.
9895         * exec.c (try_open_exec_file): Update.
9896         * exceptions.c (print_exception, exception_print)
9897         (exception_fprintf, exception_print_same): Update.
9898         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9899         * dwarf-index-cache.c (index_cache::store)
9900         (index_cache::lookup_gdb_index): Update.
9901         * darwin-nat.c (maybe_cache_shell): Update.
9902         * cp-valprint.c (cp_print_value_fields): Update.
9903         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9904         (gcc_cplus_symbol_address): Update.
9905         * compile/compile-c-symbols.c (gcc_convert_symbol)
9906         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9907         * common/selftest.c: Update.
9908         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9909         a std::string.
9910         (exception_try_scope_entry, exception_try_scope_exit): Don't
9911         declare.
9912         (struct exception_try_scope): Remove.
9913         (TRY): Don't use exception_try_scope.
9914         (struct gdb_exception): Add constructor, operator=.
9915         <what>: New method.
9916         (struct gdb_exception_RETURN_MASK_ALL)
9917         (struct gdb_exception_RETURN_MASK_ERROR)
9918         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9919         (struct gdb_quit_bad_alloc): Update.
9920         * common/common-exceptions.c (exception_none): Change
9921         initializer.
9922         (struct catcher) <state, exception>: Initialize inline.
9923         <prev>: Remove member.
9924         (current_catcher): Remove.
9925         (catchers): New global.
9926         (exceptions_state_mc_init): Simplify.
9927         (catcher_pop): Remove.
9928         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9929         (try_scope_depth, exception_try_scope_entry)
9930         (exception_try_scope_exit): Remove.
9931         (throw_exception_sjlj): Update.
9932         (exception_messages, exception_messages_size): Remove.
9933         (throw_it): Simplify.
9934         (gdb_exception_sliced_copy): Remove.
9935         (throw_exception_cxx): Update.
9936         * cli/cli-script.c (script_from_file): Update.
9937         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9938         Update.
9939         * ada-valprint.c (ada_val_print): Update.
9940         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9941         (create_excep_cond_exprs): Update.
9942
9943 2019-04-08  Tom Tromey  <tom@tromey.com>
9944
9945         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9946         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9947         (TRY, CATCH, END_CATCH): Remove some definitions.
9948         * common/common-exceptions.c: Don't use GDB_XCPT.
9949         (catcher_list_size): Remove.
9950         (throw_exception, throw_it): Simplify.
9951
9952 2019-04-05  Tom Tromey  <tom@tromey.com>
9953
9954         Revert the header-sorting patch.
9955         * ft32-tdep.c: Revert.
9956         * frv-tdep.c: Revert.
9957         * frv-linux-tdep.c: Revert.
9958         * frame.c: Revert.
9959         * frame-unwind.c: Revert.
9960         * frame-base.c: Revert.
9961         * fork-child.c: Revert.
9962         * findvar.c: Revert.
9963         * findcmd.c: Revert.
9964         * filesystem.c: Revert.
9965         * filename-seen-cache.h: Revert.
9966         * filename-seen-cache.c: Revert.
9967         * fbsd-tdep.c: Revert.
9968         * fbsd-nat.h: Revert.
9969         * fbsd-nat.c: Revert.
9970         * f-valprint.c: Revert.
9971         * f-typeprint.c: Revert.
9972         * f-lang.c: Revert.
9973         * extension.h: Revert.
9974         * extension.c: Revert.
9975         * extension-priv.h: Revert.
9976         * expprint.c: Revert.
9977         * exec.h: Revert.
9978         * exec.c: Revert.
9979         * exceptions.c: Revert.
9980         * event-top.c: Revert.
9981         * event-loop.c: Revert.
9982         * eval.c: Revert.
9983         * elfread.c: Revert.
9984         * dwarf2read.h: Revert.
9985         * dwarf2read.c: Revert.
9986         * dwarf2loc.c: Revert.
9987         * dwarf2expr.h: Revert.
9988         * dwarf2expr.c: Revert.
9989         * dwarf2-frame.c: Revert.
9990         * dwarf2-frame-tailcall.c: Revert.
9991         * dwarf-index-write.h: Revert.
9992         * dwarf-index-write.c: Revert.
9993         * dwarf-index-common.c: Revert.
9994         * dwarf-index-cache.h: Revert.
9995         * dwarf-index-cache.c: Revert.
9996         * dummy-frame.c: Revert.
9997         * dtrace-probe.c: Revert.
9998         * disasm.h: Revert.
9999         * disasm.c: Revert.
10000         * disasm-selftests.c: Revert.
10001         * dictionary.c: Revert.
10002         * dicos-tdep.c: Revert.
10003         * demangle.c: Revert.
10004         * dcache.h: Revert.
10005         * dcache.c: Revert.
10006         * darwin-nat.h: Revert.
10007         * darwin-nat.c: Revert.
10008         * darwin-nat-info.c: Revert.
10009         * d-valprint.c: Revert.
10010         * d-namespace.c: Revert.
10011         * d-lang.c: Revert.
10012         * ctf.c: Revert.
10013         * csky-tdep.c: Revert.
10014         * csky-linux-tdep.c: Revert.
10015         * cris-tdep.c: Revert.
10016         * cris-linux-tdep.c: Revert.
10017         * cp-valprint.c: Revert.
10018         * cp-support.c: Revert.
10019         * cp-namespace.c: Revert.
10020         * cp-abi.c: Revert.
10021         * corelow.c: Revert.
10022         * corefile.c: Revert.
10023         * continuations.c: Revert.
10024         * completer.h: Revert.
10025         * completer.c: Revert.
10026         * complaints.c: Revert.
10027         * coffread.c: Revert.
10028         * coff-pe-read.c: Revert.
10029         * cli-out.h: Revert.
10030         * cli-out.c: Revert.
10031         * charset.c: Revert.
10032         * c-varobj.c: Revert.
10033         * c-valprint.c: Revert.
10034         * c-typeprint.c: Revert.
10035         * c-lang.c: Revert.
10036         * buildsym.c: Revert.
10037         * buildsym-legacy.c: Revert.
10038         * build-id.h: Revert.
10039         * build-id.c: Revert.
10040         * btrace.c: Revert.
10041         * bsd-uthread.c: Revert.
10042         * breakpoint.h: Revert.
10043         * breakpoint.c: Revert.
10044         * break-catch-throw.c: Revert.
10045         * break-catch-syscall.c: Revert.
10046         * break-catch-sig.c: Revert.
10047         * blockframe.c: Revert.
10048         * block.c: Revert.
10049         * bfin-tdep.c: Revert.
10050         * bfin-linux-tdep.c: Revert.
10051         * bfd-target.c: Revert.
10052         * bcache.c: Revert.
10053         * ax-general.c: Revert.
10054         * ax-gdb.h: Revert.
10055         * ax-gdb.c: Revert.
10056         * avr-tdep.c: Revert.
10057         * auxv.c: Revert.
10058         * auto-load.c: Revert.
10059         * arm-wince-tdep.c: Revert.
10060         * arm-tdep.c: Revert.
10061         * arm-symbian-tdep.c: Revert.
10062         * arm-pikeos-tdep.c: Revert.
10063         * arm-obsd-tdep.c: Revert.
10064         * arm-nbsd-tdep.c: Revert.
10065         * arm-nbsd-nat.c: Revert.
10066         * arm-linux-tdep.c: Revert.
10067         * arm-linux-nat.c: Revert.
10068         * arm-fbsd-tdep.c: Revert.
10069         * arm-fbsd-nat.c: Revert.
10070         * arm-bsd-tdep.c: Revert.
10071         * arch-utils.c: Revert.
10072         * arc-tdep.c: Revert.
10073         * arc-newlib-tdep.c: Revert.
10074         * annotate.h: Revert.
10075         * annotate.c: Revert.
10076         * amd64-windows-tdep.c: Revert.
10077         * amd64-windows-nat.c: Revert.
10078         * amd64-tdep.c: Revert.
10079         * amd64-sol2-tdep.c: Revert.
10080         * amd64-obsd-tdep.c: Revert.
10081         * amd64-obsd-nat.c: Revert.
10082         * amd64-nbsd-tdep.c: Revert.
10083         * amd64-nbsd-nat.c: Revert.
10084         * amd64-nat.c: Revert.
10085         * amd64-linux-tdep.c: Revert.
10086         * amd64-linux-nat.c: Revert.
10087         * amd64-fbsd-tdep.c: Revert.
10088         * amd64-fbsd-nat.c: Revert.
10089         * amd64-dicos-tdep.c: Revert.
10090         * amd64-darwin-tdep.c: Revert.
10091         * amd64-bsd-nat.c: Revert.
10092         * alpha-tdep.c: Revert.
10093         * alpha-obsd-tdep.c: Revert.
10094         * alpha-nbsd-tdep.c: Revert.
10095         * alpha-mdebug-tdep.c: Revert.
10096         * alpha-linux-tdep.c: Revert.
10097         * alpha-linux-nat.c: Revert.
10098         * alpha-bsd-tdep.c: Revert.
10099         * alpha-bsd-nat.c: Revert.
10100         * aix-thread.c: Revert.
10101         * agent.c: Revert.
10102         * addrmap.c: Revert.
10103         * ada-varobj.c: Revert.
10104         * ada-valprint.c: Revert.
10105         * ada-typeprint.c: Revert.
10106         * ada-tasks.c: Revert.
10107         * ada-lang.c: Revert.
10108         * aarch64-tdep.c: Revert.
10109         * aarch64-ravenscar-thread.c: Revert.
10110         * aarch64-newlib-tdep.c: Revert.
10111         * aarch64-linux-tdep.c: Revert.
10112         * aarch64-linux-nat.c: Revert.
10113         * aarch64-fbsd-tdep.c: Revert.
10114         * aarch64-fbsd-nat.c: Revert.
10115         * aarch32-linux-nat.c: Revert.
10116
10117 2019-04-05  Tom Tromey  <tom@tromey.com>
10118
10119         * ft32-tdep.c: Sort headers.
10120         * frv-tdep.c: Sort headers.
10121         * frv-linux-tdep.c: Sort headers.
10122         * frame.c: Sort headers.
10123         * frame-unwind.c: Sort headers.
10124         * frame-base.c: Sort headers.
10125         * fork-child.c: Sort headers.
10126         * findvar.c: Sort headers.
10127         * findcmd.c: Sort headers.
10128         * filesystem.c: Sort headers.
10129         * filename-seen-cache.h: Sort headers.
10130         * filename-seen-cache.c: Sort headers.
10131         * fbsd-tdep.c: Sort headers.
10132         * fbsd-nat.h: Sort headers.
10133         * fbsd-nat.c: Sort headers.
10134         * f-valprint.c: Sort headers.
10135         * f-typeprint.c: Sort headers.
10136         * f-lang.c: Sort headers.
10137         * extension.h: Sort headers.
10138         * extension.c: Sort headers.
10139         * extension-priv.h: Sort headers.
10140         * expprint.c: Sort headers.
10141         * exec.h: Sort headers.
10142         * exec.c: Sort headers.
10143         * exceptions.c: Sort headers.
10144         * event-top.c: Sort headers.
10145         * event-loop.c: Sort headers.
10146         * eval.c: Sort headers.
10147         * elfread.c: Sort headers.
10148         * dwarf2read.h: Sort headers.
10149         * dwarf2read.c: Sort headers.
10150         * dwarf2loc.c: Sort headers.
10151         * dwarf2expr.h: Sort headers.
10152         * dwarf2expr.c: Sort headers.
10153         * dwarf2-frame.c: Sort headers.
10154         * dwarf2-frame-tailcall.c: Sort headers.
10155         * dwarf-index-write.h: Sort headers.
10156         * dwarf-index-write.c: Sort headers.
10157         * dwarf-index-common.c: Sort headers.
10158         * dwarf-index-cache.h: Sort headers.
10159         * dwarf-index-cache.c: Sort headers.
10160         * dummy-frame.c: Sort headers.
10161         * dtrace-probe.c: Sort headers.
10162         * disasm.h: Sort headers.
10163         * disasm.c: Sort headers.
10164         * disasm-selftests.c: Sort headers.
10165         * dictionary.c: Sort headers.
10166         * dicos-tdep.c: Sort headers.
10167         * demangle.c: Sort headers.
10168         * dcache.h: Sort headers.
10169         * dcache.c: Sort headers.
10170         * darwin-nat.h: Sort headers.
10171         * darwin-nat.c: Sort headers.
10172         * darwin-nat-info.c: Sort headers.
10173         * d-valprint.c: Sort headers.
10174         * d-namespace.c: Sort headers.
10175         * d-lang.c: Sort headers.
10176         * ctf.c: Sort headers.
10177         * csky-tdep.c: Sort headers.
10178         * csky-linux-tdep.c: Sort headers.
10179         * cris-tdep.c: Sort headers.
10180         * cris-linux-tdep.c: Sort headers.
10181         * cp-valprint.c: Sort headers.
10182         * cp-support.c: Sort headers.
10183         * cp-namespace.c: Sort headers.
10184         * cp-abi.c: Sort headers.
10185         * corelow.c: Sort headers.
10186         * corefile.c: Sort headers.
10187         * continuations.c: Sort headers.
10188         * completer.h: Sort headers.
10189         * completer.c: Sort headers.
10190         * complaints.c: Sort headers.
10191         * coffread.c: Sort headers.
10192         * coff-pe-read.c: Sort headers.
10193         * cli-out.h: Sort headers.
10194         * cli-out.c: Sort headers.
10195         * charset.c: Sort headers.
10196         * c-varobj.c: Sort headers.
10197         * c-valprint.c: Sort headers.
10198         * c-typeprint.c: Sort headers.
10199         * c-lang.c: Sort headers.
10200         * buildsym.c: Sort headers.
10201         * buildsym-legacy.c: Sort headers.
10202         * build-id.h: Sort headers.
10203         * build-id.c: Sort headers.
10204         * btrace.c: Sort headers.
10205         * bsd-uthread.c: Sort headers.
10206         * breakpoint.h: Sort headers.
10207         * breakpoint.c: Sort headers.
10208         * break-catch-throw.c: Sort headers.
10209         * break-catch-syscall.c: Sort headers.
10210         * break-catch-sig.c: Sort headers.
10211         * blockframe.c: Sort headers.
10212         * block.c: Sort headers.
10213         * bfin-tdep.c: Sort headers.
10214         * bfin-linux-tdep.c: Sort headers.
10215         * bfd-target.c: Sort headers.
10216         * bcache.c: Sort headers.
10217         * ax-general.c: Sort headers.
10218         * ax-gdb.h: Sort headers.
10219         * ax-gdb.c: Sort headers.
10220         * avr-tdep.c: Sort headers.
10221         * auxv.c: Sort headers.
10222         * auto-load.c: Sort headers.
10223         * arm-wince-tdep.c: Sort headers.
10224         * arm-tdep.c: Sort headers.
10225         * arm-symbian-tdep.c: Sort headers.
10226         * arm-pikeos-tdep.c: Sort headers.
10227         * arm-obsd-tdep.c: Sort headers.
10228         * arm-nbsd-tdep.c: Sort headers.
10229         * arm-nbsd-nat.c: Sort headers.
10230         * arm-linux-tdep.c: Sort headers.
10231         * arm-linux-nat.c: Sort headers.
10232         * arm-fbsd-tdep.c: Sort headers.
10233         * arm-fbsd-nat.c: Sort headers.
10234         * arm-bsd-tdep.c: Sort headers.
10235         * arch-utils.c: Sort headers.
10236         * arc-tdep.c: Sort headers.
10237         * arc-newlib-tdep.c: Sort headers.
10238         * annotate.h: Sort headers.
10239         * annotate.c: Sort headers.
10240         * amd64-windows-tdep.c: Sort headers.
10241         * amd64-windows-nat.c: Sort headers.
10242         * amd64-tdep.c: Sort headers.
10243         * amd64-sol2-tdep.c: Sort headers.
10244         * amd64-obsd-tdep.c: Sort headers.
10245         * amd64-obsd-nat.c: Sort headers.
10246         * amd64-nbsd-tdep.c: Sort headers.
10247         * amd64-nbsd-nat.c: Sort headers.
10248         * amd64-nat.c: Sort headers.
10249         * amd64-linux-tdep.c: Sort headers.
10250         * amd64-linux-nat.c: Sort headers.
10251         * amd64-fbsd-tdep.c: Sort headers.
10252         * amd64-fbsd-nat.c: Sort headers.
10253         * amd64-dicos-tdep.c: Sort headers.
10254         * amd64-darwin-tdep.c: Sort headers.
10255         * amd64-bsd-nat.c: Sort headers.
10256         * alpha-tdep.c: Sort headers.
10257         * alpha-obsd-tdep.c: Sort headers.
10258         * alpha-nbsd-tdep.c: Sort headers.
10259         * alpha-mdebug-tdep.c: Sort headers.
10260         * alpha-linux-tdep.c: Sort headers.
10261         * alpha-linux-nat.c: Sort headers.
10262         * alpha-bsd-tdep.c: Sort headers.
10263         * alpha-bsd-nat.c: Sort headers.
10264         * aix-thread.c: Sort headers.
10265         * agent.c: Sort headers.
10266         * addrmap.c: Sort headers.
10267         * ada-varobj.c: Sort headers.
10268         * ada-valprint.c: Sort headers.
10269         * ada-typeprint.c: Sort headers.
10270         * ada-tasks.c: Sort headers.
10271         * ada-lang.c: Sort headers.
10272         * aarch64-tdep.c: Sort headers.
10273         * aarch64-ravenscar-thread.c: Sort headers.
10274         * aarch64-newlib-tdep.c: Sort headers.
10275         * aarch64-linux-tdep.c: Sort headers.
10276         * aarch64-linux-nat.c: Sort headers.
10277         * aarch64-fbsd-tdep.c: Sort headers.
10278         * aarch64-fbsd-nat.c: Sort headers.
10279         * aarch32-linux-nat.c: Sort headers.
10280
10281 2019-04-04  Tom Tromey  <tom@tromey.com>
10282
10283         * varobj.c (varobj_create): Update.
10284         * rust-exp.y (struct rust_parser) <update_innermost_block,
10285         lookup_symbol>: New methods.
10286         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10287         Rename.
10288         (rust_parser::rust_lookup_type)
10289         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10290         * printcmd.c (display_command, do_one_display): Update.
10291         * parser-defs.h (struct parser_state) <parser_state>: Add
10292         "tracker" parameter.
10293         (block_tracker): New member.
10294         (class innermost_block_tracker) <innermost_block_tracker>: Add
10295         "types" parameter.
10296         <reset>: Remove method.
10297         (innermost_block): Don't declare.
10298         (null_post_parser): Update.
10299         * parse.c (innermost_block): Remove global.
10300         (write_dollar_variable): Update.
10301         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10302         Remove "tracker_types" parameter.
10303         (parse_expression): Add "tracker" parameter.
10304         (parse_expression_for_completion): Update.
10305         (null_post_parser): Add "tracker" parameter.
10306         * p-exp.y: Update rules.
10307         * m2-exp.y: Update rules.
10308         * language.h (struct language_defn) <la_post_parser>: Add
10309         "tracker" parameter.
10310         * go-exp.y: Update rules.
10311         * f-exp.y: Update rules.
10312         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10313         parameter.
10314         * d-exp.y: Update rules.
10315         * c-exp.y: Update rules.
10316         * breakpoint.c (set_breakpoint_condition): Create an
10317         innermost_block_tracker.
10318         (watch_command_1): Likewise.
10319         * ada-lang.c (resolve): Add "tracker" parameter.
10320         (resolve_subexp): Likewise.
10321         * ada-exp.y (write_var_from_sym): Update.
10322
10323 2019-04-04  Tom Tromey  <tom@tromey.com>
10324
10325         * type-stack.h: New file.
10326         * type-stack.c: New file.
10327         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10328         type-stack.h.
10329         (insert_into_type_stack, insert_type, push_type, push_type_int)
10330         (insert_type_address_space, pop_type, pop_type_int)
10331         (pop_typelist, pop_type_stack, append_type_stack)
10332         (push_type_stack, get_type_stack, push_typelist)
10333         (follow_type_instance_flags, follow_types): Don't declare.
10334         * parse.c (type_stack): Remove global.
10335         (parse_exp_in_context): Update.
10336         (insert_into_type_stack, insert_type, push_type, push_type_int)
10337         (insert_type_address_space, pop_type, pop_type_int)
10338         (pop_typelist, pop_type_stack, append_type_stack)
10339         (push_type_stack, get_type_stack, push_typelist)
10340         (follow_type_instance_flags, follow_types): Remove (moved to
10341         type-stack.c).
10342         * f-exp.y (type_stack): New global.
10343         Update rules.
10344         (push_kind_type, f_parse): Update.
10345         * d-exp.y (type_stack): New global.
10346         Update rules.
10347         (d_parse): Update.
10348         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10349         Update rules.
10350         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10351         (HFILES_NO_SRCDIR): Add type-stack.h.
10352
10353 2019-04-04  Tom Tromey  <tom@tromey.com>
10354
10355         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10356         (rust_parser::convert_ast_to_expression, rust_parse)
10357         (rust_lex_test_completion, rust_lex_tests): Update.
10358         * parser-defs.h (struct expr_completion_state): New.
10359         (struct parser_state) <parser_state>: Add completion parameter.
10360         <mark_struct_expression, mark_completion_tag>: New methods.
10361         <parse_completion, m_completion_state>: New members.
10362         (prefixify_expression, null_post_parser): Update.
10363         (mark_struct_expression, mark_completion_tag): Don't declare.
10364         * parse.c (parse_completion, expout_last_struct)
10365         (expout_tag_completion_type, expout_completion_name): Remove
10366         globals.
10367         (parser_state::mark_struct_expression)
10368         (parser_state::mark_completion_tag): Now methods.
10369         (prefixify_expression): Add last_struct parameter.
10370         (prefixify_subexp): Likewise.
10371         (parse_exp_1): Update.
10372         (parse_exp_in_context): Add cstate parameter.  Update.
10373         (parse_expression_for_completion): Create an
10374         expr_completion_state.
10375         (null_post_parser): Add "completion" parameter.
10376         * p-exp.y: Update rules.
10377         (yylex): Update.
10378         * language.h (struct language_defn) <la_post_parser>: Add
10379         "completing" parameter.
10380         * go-exp.y: Update rules.
10381         (lex_one_token): Update.
10382         * expression.h (parse_completion): Don't declare.
10383         * d-exp.y: Update rules.
10384         (lex_one_token): Update rules.
10385         * c-exp.y: Update rules.
10386         (lex_one_token): Update.
10387         * ada-lang.c (resolve): Add "parse_completion" parameter.
10388         (resolve_subexp): Likewise.
10389         (ada_resolve_function): Likewise.
10390
10391 2019-04-04  Tom Tromey  <tom@tromey.com>
10392
10393         * parser-defs.h (struct parser_state) <start_arglist,
10394         end_arglist>: New methods.
10395         <arglist_len, m_funcall_chain>: New members.
10396         (arglist_len, start_arglist, end_arglist): Don't declare.
10397         * parse.c (arglist_len, funcall_chain): Remove global.
10398         (start_arglist, end_arglist): Remove functions.
10399         (parse_exp_in_context): Update.
10400         * p-exp.y: Update rules.
10401         * m2-exp.y: Update rules.
10402         * go-exp.y: Update rules.
10403         * f-exp.y: Update rules.
10404         * d-exp.y: Update rules.
10405         * c-exp.y: Update rules.
10406
10407 2019-04-04  Tom Tromey  <tom@tromey.com>
10408
10409         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10410         lex_operator, push_back>: New methods.
10411         Update all rules.
10412         (rust_parser::lex_hex, lex_escape): Rename and update.
10413         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10414         (rust_parser::lex_operator): Rename and update.
10415         (rust_parser::lex_number, rustyylex, rustyyerror)
10416         (rust_lex_test_init, rust_lex_test_sequence)
10417         (rust_lex_test_push_back, rust_lex_tests): Update.
10418         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10419         parameter.
10420         <lexptr, prev_lexptr>: New members.
10421         (lexptr, prev_lexptr): Don't declare.
10422         * parse.c (lexptr, prev_lexptr): Remove globals.
10423         (parse_exp_in_context): Update.
10424         * p-exp.y (yylex, yyerror): Update.
10425         * m2-exp.y (parse_number, yylex, yyerror): Update.
10426         * go-exp.y (lex_one_token, yyerror): Update.
10427         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10428         * d-exp.y (lex_one_token, yyerror): Update.
10429         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10430         (lex_one_token, yyerror): Update.
10431         * ada-lex.l (YY_INPUT): Update.
10432         (rewind_to_char): Update.
10433         * ada-exp.y (yyerror): Update.
10434
10435 2019-04-04  Tom Tromey  <tom@tromey.com>
10436
10437         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10438         * parser-defs.h (struct parser_state) <parser_state>: Add new
10439         parameter.
10440         <comma_terminates>: New member.
10441         (comma_terminates): Don't declare global.
10442         * parse.c (comma_terminates): Remove global.
10443         (parse_exp_in_context): Update.
10444         * p-exp.y (yylex): Update.
10445         * m2-exp.y (yylex): Update.
10446         * go-exp.y (lex_one_token): Update.
10447         * f-exp.y (yylex): Update.
10448         * d-exp.y (lex_one_token): Update.
10449         * c-exp.y (lex_one_token): Update.
10450         * ada-lex.l: Update.
10451
10452 2019-04-04  Tom Tromey  <tom@tromey.com>
10453
10454         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10455         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10456         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10457         * parser-defs.h (paren_depth): Don't declare.
10458         * parse.c (paren_depth): Remove global.
10459         (parse_exp_in_context): Update.
10460         * p-exp.y (paren_depth): New global.
10461         (pascal_parse): Initialize it.
10462         * m2-exp.y (paren_depth): New global.
10463         (m2_parse): Initialize it.
10464         * go-exp.y (paren_depth): New global.
10465         (go_parse): Initialize it.
10466         * f-exp.y (paren_depth): New global.
10467         (f_parse): Initialize it.
10468         * d-exp.y (paren_depth): New global.
10469         (d_parse): Initialize it.
10470         * c-exp.y (paren_depth): New global.
10471         (c_parse): Initialize it.
10472         * ada-lex.l (paren_depth): New global.
10473         (lexer_init): Initialize it.
10474
10475 2019-04-04  Tom Tromey  <tom@tromey.com>
10476
10477         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10478         (rust_parser::convert_ast_to_type)
10479         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10480         * parser-defs.h (struct parser_state) <parser_state>: Add
10481         parameters.  Initialize new members.
10482         <expression_context_block, expression_context_pc>: New members.
10483         * parse.c (expression_context_block, expression_context_pc):
10484         Remove globals.
10485         (parse_exp_in_context): Update.
10486         * p-exp.y: Update all rules.
10487         (yylex): Update.
10488         * m2-exp.y: Update all rules.
10489         (yylex): Update.
10490         * go-exp.y (yylex): Update.
10491         * f-exp.y (yylex): Update.
10492         * d-exp.y: Update all rules.
10493         (yylex): Update.
10494         * c-exp.y: Update all rules.
10495         (lex_one_token, classify_name, yylex, c_parse): Update.
10496         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10497
10498 2019-04-04  Tom Tromey  <tom@tromey.com>
10499
10500         * gdbarch.h, gdbarch.c: Rebuild.
10501         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10502         * stap-probe.h:
10503         (struct stap_parse_info): Replace "parser_state" with
10504         "expr_builder".
10505         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10506         (parser_state): New class.
10507         * parse.c (expr_builder): Rename.
10508         (expr_builder::release): Rename.
10509         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10510         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10511         (write_exp_elt_longcst, write_exp_elt_floatcst)
10512         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10513         (write_exp_string_vector, write_exp_bitstring)
10514         (write_exp_msymbol, mark_struct_expression)
10515         (write_dollar_variable)
10516         (insert_type_address_space, increase_expout_size): Replace
10517         "parser_state" with "expr_builder".
10518         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10519         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10520         "parser_state" with "expr_builder".
10521
10522 2019-04-04  Tom Tromey  <tom@tromey.com>
10523
10524         * rust-exp.y: Replace "parse_language" with method call.
10525         * p-exp.y:
10526         (yylex): Replace "parse_language" with method call.
10527         * m2-exp.y:
10528         (yylex): Replace "parse_language" with method call.
10529         * go-exp.y (classify_name): Replace "parse_language" with method
10530         call.
10531         * f-exp.y (yylex): Replace "parse_language" with method call.
10532         * d-exp.y (lex_one_token): Replace "parse_language" with method
10533         call.
10534         * c-exp.y:
10535         (lex_one_token, classify_name, yylex): Replace "parse_language"
10536         with method call.
10537         * ada-exp.y (find_primitive_type, type_char)
10538         (type_system_address): Replace "parse_language" with method call.
10539
10540 2019-04-04  Tom Tromey  <tom@tromey.com>
10541
10542         * rust-exp.y: Replace "parse_gdbarch" with method call.
10543         * parse.c (write_dollar_variable, insert_type_address_space):
10544         Replace "parse_gdbarch" with method call.
10545         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10546         call.
10547         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10548         call.
10549         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10550         "parse_gdbarch" with method call.
10551         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10552         with method call.
10553         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10554         "parse_gdbarch" with method call.
10555         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10556         "parse_gdbarch" with method call.
10557         * c-exp.y (parse_type, parse_number, classify_name): Replace
10558         "parse_gdbarch" with method call.
10559         * ada-lex.l: Replace "parse_gdbarch" with method call.
10560         * ada-exp.y (parse_type, find_primitive_type, type_char)
10561         (type_system_address): Replace "parse_gdbarch" with method call.
10562
10563 2019-04-04  Tom Tromey  <tom@tromey.com>
10564
10565         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10566         * stap-probe.c (stap_parse_argument): Update.
10567         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10568         initial_size parameter.
10569         * rust-exp.y (rust_lex_tests): Update.
10570         * parse.c (parser_state): Update.
10571         (parse_exp_in_context): Update.
10572         * parser-defs.h (struct parser_state) <parser_state>: Remove
10573         "initial_size" parameter.
10574
10575 2019-04-04  Tom Tromey  <tom@tromey.com>
10576
10577         * parser-defs.h (increase_expout_size): Don't declare.
10578         * parse.c (increase_expout_size): Now static.
10579
10580 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10581
10582         * gnu-nat.c (gnu_nat_target::wait): Fix
10583         target_waitstatus_to_string call.
10584
10585 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10586
10587         * eval.c (evaluate_subexp_standard): Handle internal functions
10588         during Fortran function call handling.
10589
10590 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10591
10592         * NEWS: Mention new internal functions.
10593         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10594         (read_base_type): Use dwarf2_init_complex_target_type.
10595         * value.c (creal_internal_fn): New function.
10596         (cimag_internal_fn): New function.
10597         (_initialize_values): Register new internal functions.
10598
10599 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10600
10601         * infrun.c (stop_all_threads): If debug_infrun, always
10602         trace the wait status after wait_one, using
10603         target_waitstatus_to_string and target_pid_to_str.
10604         (handle_inferior_event): Replace various trace of
10605         wait status kind by a single trace.
10606         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10607         wait status kind image by target_waitstatus_to_string.
10608         * target/waitstatus.c (target_waitstatus_to_string): Fix
10609         obsolete comment.
10610
10611 2019-04-01  Tom Tromey  <tromey@adacore.com>
10612
10613         PR symtab/23331:
10614         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10615
10616 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10617             Pedro Alves  <palves@redhat.com>
10618
10619         * top.c (quit_force): Call 'finalize_values'.
10620         * value.c (finalize_values): New function.
10621         * value.h (finalize_values): Declare.
10622
10623 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10624
10625         * NEWS: Announce $_gdb_major and $_gdb_minor.
10626
10627         * top.c (init_gdb_version_vars): New function.
10628         (gdb_init): Call init_gdb_version_vars.
10629
10630 2019-03-29  Tom Tromey  <tromey@adacore.com>
10631
10632         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10633         help text.  Remove dead code.
10634
10635 2019-03-29  Keith Seitz  <keiths@redhat.com>
10636
10637         From Siddhesh Poyarekar:
10638         * f-lang.h (f77_get_upperbound): Return LONGEST.
10639         (f77_get_lowerbound): Likewise.
10640         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10641         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10642         print them.
10643         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10644         plongest to format print it.
10645         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10646         (f77_get_upperbound): Likewise.
10647         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10648         LOWER_BOUND to LONGEST.
10649         (f77_create_arrayprint_offset_tbl): Likewise.
10650
10651 2019-03-29  Keith Seitz  <keiths@redhat.com>
10652
10653         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10654         %s/pulongest for TYPE_LENGTH instead of %d in format
10655         strings.
10656         * ada-typerint.c (ada_print_type): Likewise.
10657         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10658         * compile/compile-c-support.c (generate_register_struct): Likewise.
10659         * gdbtypes.c (recursive_dump_type): Likewise.
10660         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10661         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10662         instead of %d in format strings.
10663         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10664         to std::min to ULONGEST.
10665         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10666         instead of %d in format strings.
10667         * tracepoint.c (info_scope_command): Likewise.
10668         * typeprint.c (print_offset_data::update)
10669         (print_offset_data::finish): Likewise.
10670         * xtensa-tdep.c (xtensa_store_return_value)
10671         (xtensa_push_dummy_call): Likewise.
10672
10673 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10674
10675         * windows-nat.c (display_selector): Fixed format specifications
10676         for 64-bit Cygwin.
10677
10678 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10679
10680         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10681
10682 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10683
10684         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10685         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10686         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10687         (nios2_linux_init_abi): Install it.
10688
10689 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10690
10691         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10692
10693 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10694
10695         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10696
10697 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10698             Tom Tromey  <tromey@adacore.com>
10699
10700         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10701
10702 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10703
10704         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10705         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10706         method to compute the bounds of range types. Also print "[evaluated]"
10707         if the bounds' values come from a dynamic evaluation.
10708
10709 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10710
10711         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10712         whitespace when pretty printing is on.
10713
10714 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10715
10716         * ppc-linux-nat.c: Add include.
10717
10718 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10719
10720         * NEWS: Mention AArch64 Pointer Authentication.
10721
10722 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10723
10724         * arm-linux-nat.c: Add include.
10725
10726 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10727
10728         * source-cache.c (source_cache::get_source_lines): Re-read
10729         fullname after calling open_source_file.
10730
10731 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10732
10733         * NEWS: Mention TLS support for FreeBSD.
10734
10735 2019-03-25  Tom Tromey  <tromey@adacore.com>
10736
10737         * minsyms.c (BUNCH_SIZE): Update comment.
10738         (~minimal_symbol_reader): Remove old comment.
10739         (compact_minimal_symbols): Update comment.
10740         (minimal_symbol_reader::install): Remove old comment.  Update
10741         other comments.
10742
10743 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10744
10745         * s390-linux-nat.c: Add include.
10746
10747 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10748
10749         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10750         Call linux_get_hwcap.
10751         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10752         Likewise.
10753         (aarch64_linux_get_hwcap): Remove function.
10754         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10755         declaration.
10756         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10757         linux_get_hwcap.
10758         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10759         * linux-tdep.c (linux_get_hwcap): Add function.
10760         (linux_get_hwcap2): Likewise.
10761         * linux-tdep.h (linux_get_hwcap): Add declaration.
10762         (linux_get_hwcap2): Likewise.
10763         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10764         (ppc_linux_get_hwcap2): Likewise.
10765         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10766         linux_get_hwcap.
10767         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10768         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10769         (ppc_linux_nat_target::read_description): Likewise.
10770         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10771         * s390-linux-nat.c: Likewise.
10772         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10773
10774 2019-03-24  Tom Tromey  <tom@tromey.com>
10775
10776         * ada-lang.c (standard_lookup): Simplify initialization.
10777         (ada_lookup_symbol_nonlocal): Simplify return.
10778         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10779         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10780         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10781         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10782         initialization.
10783         * solib.c (solib_global_lookup): Simplify.
10784         * symtab.c (null_block_symbol): Remove.
10785         (symbol_cache_lookup): Simplify returns.
10786         (lookup_language_this): Simplify returns.
10787         (lookup_symbol_aux): Simplify return.
10788         (lookup_local_symbol): Simplify returns.
10789         (lookup_global_symbol_from_objfile): Simplify return.
10790         (lookup_symbol_in_objfile_symtabs)
10791         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10792         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10793         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10794         * cp-namespace.c (cp_lookup_bare_symbol)
10795         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10796         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10797         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10798         (cp_lookup_symbol_via_imports): Simplify initialization.
10799         (find_symbol_in_baseclass): Likewise.
10800         * symtab.h (null_block_symbol): Remove.
10801         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10802         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10803         (d_lookup_symbol_module): Likewise.
10804         (find_symbol_in_baseclass): Simplify initialization.
10805
10806 2019-03-24  Tom Tromey  <tom@tromey.com>
10807
10808         * expression.h: Don't include symtab.h.
10809         (struct block): Forward declare.
10810
10811 2019-03-24  Tom Tromey  <tom@tromey.com>
10812
10813         * c-exp.y (typebase): Remove casts.
10814         * gdbtypes.c (lookup_unsigned_typename, )
10815         (lookup_signed_typename): Remove cast.
10816         * eval.c (parse_to_comma_and_eval): Remove cast.
10817         * parse.c (write_dollar_variable): Remove cast.
10818         * block.h (struct block) <superblock>: Now const.
10819         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10820         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10821         (map_block): Make "block" const.
10822         * symfile.h (struct quick_symbol_functions)
10823         <map_matching_symbols>: Constify block argument to "callback".
10824         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10825         const.
10826         (find_pc_sect_compunit_symtab): Make "b" const.
10827         (find_symbol_at_address): Likewise.
10828         (search_symbols): Likewise.
10829         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10830         (dw2_debug_names_lookup_symbol): Likewise.
10831         (dw2_map_matching_symbols): Update.
10832         * p-valprint.c (pascal_val_print): Remove "block".
10833         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10834         (aux_add_nonlocal_symbols): Make "block" const.
10835         (resolve_subexp): Remove cast.
10836         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10837         const.
10838         (iterate_over_file_blocks): Likewise.
10839         * f-exp.y (%union) <bval>: Remove.
10840         * coffread.c (patch_opaque_types): Make "b" const.
10841         * spu-tdep.c (spu_catch_start): Make "block" const.
10842         * c-valprint.c (print_unpacked_pointer): Remove "block".
10843         * symmisc.c (dump_symtab_1): Make "b" const.
10844         (block_depth): Make "block" const.
10845         * d-exp.y (%union) <bval>: Remove.
10846         * cp-support.h (cp_lookup_rtti_type): Update.
10847         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10848         * psymtab.c (psym_lookup_symbol): Make "block" const.
10849         (maintenance_check_psymtabs): Make "b" const.
10850         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10851         (enumerate_locals, enumerate_args): Update.
10852         * python/py-symtab.c (stpy_global_block): Make "block" const.
10853         (stpy_static_block): Likewise.
10854         * inline-frame.c (block_starting_point_at): Make "new_block"
10855         const.
10856         * block.c (find_block_in_blockvector): Make return type const.
10857         (blockvector_for_pc_sect): Make "b" const.
10858         (find_block_in_blockvector): Make "b" const.
10859
10860 2019-03-23  Tom Tromey  <tom@tromey.com>
10861
10862         * varobj.c (varobj_create): Update.
10863         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10864         * printcmd.c (display_command, do_one_display): Don't reset
10865         innermost_block.
10866         * parser-defs.h (enum innermost_block_tracker_type): Move to
10867         expression.h.
10868         (innermost_block): Update comment.
10869         * parse.c (parse_exp_1): Add tracker_types parameter.
10870         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10871         tracker_types parameter.  Reset innermost_block.
10872         (parse_exp_in_context): Remove.
10873         (parse_expression_for_completion): Update.
10874         * objfiles.c (~objfile): Don't reset expression_context_block or
10875         innermost_block.
10876         * expression.h (enum innermost_block_tracker_type): Move from
10877         parser-defs.h.
10878         (parse_exp_1): Add tracker_types parameter.
10879         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10880         reset innermost_block.
10881
10882 2019-03-23  Tom Tromey  <tom@tromey.com>
10883
10884         * objfiles.h: Include bcache.h.
10885
10886 2019-03-23  Tom Tromey  <tom@tromey.com>
10887
10888         * linespec.c (get_current_search_block): Use
10889         scoped_restore_current_language.
10890         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10891
10892 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10893             Jiong Wang  <jiong.wang@arm.com>
10894
10895         * aarch64-linux-tdep.c
10896         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10897         section.
10898         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10899
10900 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10901             Jiong Wang  <jiong.wang@arm.com>
10902
10903         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10904         instructions.
10905         (aarch64_analyze_prologue_test): Add PACIASP test.
10906         (aarch64_prologue_prev_register): Unmask PC value.
10907
10908 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10909             Jiong Wang  <jiong.wang@arm.com>
10910
10911         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10912         (aarch64_dwarf2_prev_register): Unmask PC value.
10913         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10914         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10915         DW_CFA_AARCH64_negate_ra_state.
10916         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10917
10918 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10919             Jiong Wang  <jiong.wang@arm.com>
10920
10921         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10922         registers.
10923         (aarch64_pseudo_register_name): Likewise.
10924         (aarch64_pseudo_register_type): Likewise.
10925         (aarch64_pseudo_register_reggroup_p): Likewise.
10926         (aarch64_gdbarch_init): Add pauth registers.
10927         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10928         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10929         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10930         (struct gdbarch_tdep): Add regnum for ra_state.
10931
10932 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10933             Jiong Wang  <jiong.wang@arm.com>
10934
10935         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10936
10937 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10938             Jiong Wang  <jiong.wang@arm.com>
10939
10940         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10941         function.
10942         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10943         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10944         (aarch64_gdbarch_init): Add puth registers.
10945         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10946         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10947         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10948
10949 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10950             Jiong Wang  <jiong.wang@arm.com>
10951
10952         * aarch64-linux-nat.c
10953         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10954         * aarch64-linux-tdep.c
10955         (aarch64_linux_core_read_description): Likewise.
10956         (aarch64_linux_get_hwcap): New function.
10957         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10958         (aarch64_linux_get_hwcap): New declaration.
10959
10960 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10961             Jiong Wang  <jiong.wang@arm.com>
10962
10963         * aarch64-linux-nat.c
10964         (aarch64_linux_nat_target::read_description): Add pauth param.
10965         * aarch64-linux-tdep.c
10966         (aarch64_linux_core_read_description): Likewise.
10967         * aarch64-tdep.c (struct target_desc): Add in pauth.
10968         (aarch64_read_description): Add pauth param.
10969         (aarch64_gdbarch_init): Likewise.
10970         * aarch64-tdep.h (aarch64_read_description): Likewise.
10971         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10972         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10973         * features/Makefile: Add new files.
10974         * features/aarch64-pauth.c: New file.
10975         * features/aarch64-pauth.xml: New file.
10976
10977 2019-03-20  Tom Tromey  <tromey@adacore.com>
10978
10979         * infrun.c (handle_inferior_event): Rename from
10980         handle_inferior_event_1.  Create a scoped_value_mark.
10981         (handle_inferior_event): Remove.
10982
10983 2019-03-19  Tom Tromey  <tromey@adacore.com>
10984
10985         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10986         * infrun.h (print_stop_event): Add "displays" parameter.
10987         * infrun.c (print_stop_event): Add "displays" parameter.
10988
10989 2019-03-19  Pedro Alves  <palves@redhat.com>
10990
10991         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10992         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10993         to -1.  Fix TABs vs spaces.
10994         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10995         * tui/tui-out.h (tui_ui_out) Add intro comments.
10996         <m_line, m_start_of_line>: In-class initialize, and add describing
10997         comment.
10998
10999 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
11000
11001         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11002         variable names.
11003         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11004
11005 2019-03-18  Pedro Alves  <palves@redhat.com>
11006             Eli Zaretskii <eliz@gnu.org>
11007
11008         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11009         m_line and m_start_of_line.
11010
11011 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
11012
11013         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11014         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11015         it returns a newline.  This fixes a regression in TU mode, whereby
11016         the next line is output on the same screen line as the user input.
11017
11018 2019-03-18  Tom Tromey  <tromey@adacore.com>
11019
11020         * minsyms.c (minimal_symbol_reader::install): Remove call to
11021         obstack_blank.
11022
11023 2019-03-18  Pedro Alves  <palves@redhat.com>
11024
11025         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11026         New globals.
11027         (apply_style): New, factored out from ...
11028         (apply_ansi_escape): ... this.  Handle reverse video mode.
11029         (tui_set_reverse_mode): New function.
11030         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11031         * tui/tui-winsource.c (tui_show_source_line): Use
11032         tui_set_reverse_mode instead of setting A_STANDOUT.
11033         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11034         New setter methods.
11035
11036 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
11037
11038         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11039         Handle tabs.
11040
11041 2019-03-18  Tom Tromey  <tromey@adacore.com>
11042
11043         * ada-lang.c (empty_array): Add "high" parameter.
11044         (ada_evaluate_subexp): Update.
11045
11046 2019-03-17  Sergei Trofimovich <siarheit@google.com>
11047
11048         * unittests/string_view-selftests.c: Define
11049         _initialize_string_view_selftests unconditionally.
11050
11051 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11052
11053         PR gdb/24350
11054         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11055
11056 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
11057
11058         PR gdb/24351
11059         * windows-nat.c (display_selector): Fix format specifiers.
11060
11061 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
11062
11063         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11064         tui_refill_source_window instead of tui_refresh_win, to update the
11065         current execution line.  This fixes redisplay of the current line
11066         when stepping through the code with "next" or "step".
11067
11068 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11069
11070         * source-cache.c (source_cache::get_source_lines): Call
11071         find_source_lines to initialize s->nlines.  This fixes vertical
11072         scrolling of TUI source window when the DOWN arrow is pressed.
11073
11074 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11075
11076         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11077         linux-thread-db.c (_initialize_thread_db): Likewise.
11078
11079 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
11080
11081         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11082         wclrtoeol in tui_show_source_line".  This reverts changes made in
11083         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11084
11085 2019-03-15  Tom Tromey  <tom@tromey.com>
11086
11087         * symtab.h (struct minimal_symbol): Derive from
11088         general_symbol_info.
11089         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11090         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11091         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11092         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11093         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11094         (MSYMBOL_SEARCH_NAME): Update.
11095         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11096         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11097         * minsyms.c (minimal_symbol_reader::record_full): Update.
11098
11099 2019-03-15  Tom Tromey  <tom@tromey.com>
11100
11101         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11102
11103 2019-03-15  Tom Tromey  <tom@tromey.com>
11104
11105         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11106         unique_xmalloc_ptr.
11107         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11108         Update.
11109         * minsyms.c (lookup_minimal_symbol_by_pc_section)
11110         (build_minimal_symbol_hash_tables)
11111         (minimal_symbol_reader::install): Update.
11112
11113 2019-03-15  Tom Tromey  <tom@tromey.com>
11114
11115         * symtab.c (create_demangled_names_hash): Update.
11116         (symbol_set_names): Update.
11117         * objfiles.h (struct objfile_per_bfd_storage)
11118         <demangled_names_hash>: Now an htab_up.
11119         * objfiles.c (objfile_per_bfd_storage): Simplify.
11120
11121 2019-03-15  Tom Tromey  <tom@tromey.com>
11122
11123         * objfiles.h (struct objfile_per_bfd_storage): Declare
11124         destructor.
11125         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11126         New.
11127         (get_objfile_bfd_data): Use new.  Don't initialize
11128         language_of_main.
11129         (free_objfile_per_bfd_storage): Remove.
11130         (objfile_bfd_data_free, objfile::~objfile): Use delete.
11131
11132 2019-03-15  Tom Tromey  <tom@tromey.com>
11133
11134         * symfile.c (reread_symbols): Update.
11135         * objfiles.c (objfile::objfile): Update.
11136         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11137         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11138         comment.
11139         (minimal_symbol_reader::install): Update.
11140         (terminate_minimal_symbol_table): Remove.
11141         * jit.c (jit_object_close_impl): Update.
11142
11143 2019-03-15  Tom Tromey  <tom@tromey.com>
11144
11145         * minsyms.c (minimal_symbol_reader::record_full): Remove some
11146         initializations.
11147
11148 2019-03-15  Tom Tromey  <tom@tromey.com>
11149
11150         * objfiles.h (struct objfile_per_bfd_storage)
11151         <demangled_hash_languages>: Now a bitset.
11152         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11153         (lookup_minimal_symbol): Update.
11154
11155 2019-03-15  Tom Tromey  <tom@tromey.com>
11156
11157         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11158         Don't return the symbol.
11159         * coffread.c (record_minimal_symbol): Use record_full.
11160
11161 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
11162
11163         The MS-Windows port of ncurses fails to switch to a color pair if
11164         one or both of the colors are the implicit default colors.  This
11165         change records the default colors when TUI is initialized, and
11166         then specifies them explicitly when a color pair uses the default
11167         colors.  This allows color styling in TUI mode on MS-Windows.
11168
11169         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
11170         ncurses_norm_attr.
11171         (tui_initialize_io) [__MINGW32__]: Record the default terminal
11172         colors in ncurses_norm_attr.
11173         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11174         "none", replace it with the default color recorded in
11175         ncurses_norm_attr.
11176
11177 2019-03-14  Tom Tromey  <tromey@adacore.com>
11178
11179         * source-cache.h (class source_cache) <get_source_lines>: Return
11180         std::string.
11181         * source-cache.c (source_cache::extract_lines): Handle case where
11182         first_pos==npos.  Return std::string.
11183         (source_cache::get_source_lines): Update.
11184
11185 2019-03-14  Tom Tromey  <tromey@adacore.com>
11186
11187         * NEWS: Add item for "style sources" commands.
11188         * source-cache.c (source_cache::get_source_lines): Check
11189         source_styling.
11190         * cli/cli-style.c (source_styling): New global.
11191         (_initialize_cli_style): Add "style sources" commands.
11192         (show_style_sources): New function.
11193         * cli/cli-style.h (source_styling): Declare.
11194
11195 2019-03-14  Pedro Alves  <palves@redhat.com>
11196             Tom Tromey  <tromey@adacore.com>
11197
11198         * tui/tui-winsource.h (tui_refill_source_window): Declare.
11199         * tui/tui-winsource.c (tui_refill_source_window): New function,
11200         from...
11201         (tui_horizontal_source_scroll): ... here.  Move some logic.
11202         * cli/cli-style.c (set_style_enabled): Notify new observable.
11203         * tui/tui-hooks.c (tui_redisplay_source): New function.
11204         (tui_attach_detach_observers): Attach or detach
11205         tui_redisplay_source.
11206         * observable.h (source_styling_changed): New observable.
11207         * observable.c: Define source_styling_changed observable.
11208
11209 2019-03-13  Tom Tromey  <tromey@adacore.com>
11210
11211         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11212         (i386_gnu_nat_target::store_registers): Update.
11213         * target-debug.h (target_debug_print_std_string): New macro.
11214         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11215         * windows-tdep.c (display_one_tib): Update.
11216         * tui/tui-stack.c (tui_make_status_line): Update.
11217         * top.c (print_inferior_quit_action): Update.
11218         * thread.c (thr_try_catch_cmd): Update.
11219         (add_thread_with_info): Update.
11220         (thread_target_id_str): Update.
11221         (thr_try_catch_cmd): Update.
11222         (thread_command): Update.
11223         (thread_find_command): Update.
11224         * record-btrace.c (record_btrace_target::info_record)
11225         (record_btrace_resume_thread, record_btrace_target::resume)
11226         (record_btrace_cancel_resume, record_btrace_step_thread)
11227         (record_btrace_target::wait, record_btrace_target::wait)
11228         (record_btrace_target::wait, record_btrace_target::stop): Update.
11229         * progspace.c (print_program_space): Update.
11230         * process-stratum-target.c
11231         (process_stratum_target::thread_address_space): Update.
11232         * linux-fork.c (linux_fork_mourn_inferior)
11233         (detach_checkpoint_command, info_checkpoints_command)
11234         (linux_fork_context): Update.
11235         (linux_fork_detach): Update.
11236         (class scoped_switch_fork_info): Update.
11237         (delete_checkpoint_command): Update.
11238         * infrun.c (follow_fork_inferior): Update.
11239         (follow_fork_inferior): Update.
11240         (proceed_after_vfork_done): Update.
11241         (handle_vfork_child_exec_or_exit): Update.
11242         (follow_exec): Update.
11243         (displaced_step_prepare_throw): Update.
11244         (displaced_step_restore): Update.
11245         (start_step_over): Update.
11246         (resume_1): Update.
11247         (clear_proceed_status_thread): Update.
11248         (proceed): Update.
11249         (print_target_wait_results): Update.
11250         (do_target_wait): Update.
11251         (context_switch): Update.
11252         (stop_all_threads): Update.
11253         (restart_threads): Update.
11254         (finish_step_over): Update.
11255         (handle_signal_stop): Update.
11256         (switch_back_to_stepped_thread): Update.
11257         (keep_going_pass_signal): Update.
11258         (print_exited_reason): Update.
11259         (normal_stop): Update.
11260         * inferior.c (inferior_pid_to_str): Change return type.
11261         (print_selected_inferior): Update.
11262         (add_inferior): Update.
11263         (detach_inferior): Update.
11264         * dummy-frame.c (fprint_dummy_frames): Update.
11265         * dcache.c (dcache_info_1): Update.
11266         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
11267         (btrace_fetch, btrace_clear): Update.
11268         * linux-tdep.c (linux_core_pid_to_str): Change return type.
11269         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
11270         type.
11271         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
11272         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
11273         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
11274         * gdbarch.c, gdbarch.h: Rebuild.
11275         * gdbarch.sh (core_pid_to_str): Change return type.
11276         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
11277         return type.
11278         (windows_nat_target::pid_to_str): Change return type.
11279         (windows_delete_thread): Update.
11280         (windows_nat_target::attach): Update.
11281         (windows_nat_target::files_info): Update.
11282         * target-delegates.c: Rebuild.
11283         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11284         return type.
11285         (sol_thread_target::pid_to_str): Change return type.
11286         * remote.c (class remote_target) <pid_to_str>: Change return
11287         type.
11288         (remote_target::pid_to_str): Change return type.
11289         (extended_remote_target::attach, remote_target::remote_stop_ns)
11290         (remote_target::remote_notif_remove_queued_reply)
11291         (remote_target::push_stop_reply, remote_target::disable_btrace):
11292         Update.
11293         (extended_remote_target::attach): Update.
11294         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11295         type.
11296         (gdbsim_target::pid_to_str): Change return type.
11297         * ravenscar-thread.c (struct ravenscar_thread_target)
11298         <pid_to_str>: Change return type.
11299         (ravenscar_thread_target::pid_to_str): Change return type.
11300         * procfs.c (class procfs_target) <pid_to_str>: Change return
11301         type.
11302         (procfs_target::pid_to_str): Change return type.
11303         (procfs_target::attach): Update.
11304         (procfs_target::detach): Update.
11305         (procfs_target::fetch_registers): Update.
11306         (procfs_target::store_registers): Update.
11307         (procfs_target::wait): Update.
11308         (procfs_target::files_info): Update.
11309         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11310         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11311         return type.
11312         (nto_procfs_target::pid_to_str): Change return type.
11313         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11314         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11315         return type.
11316         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11317         (exit_lwp): Update.
11318         (attach_proc_task_lwp_callback, get_detach_signal)
11319         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11320         (linux_nat_target::resume, wait_lwp, stop_callback)
11321         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11322         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11323         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11324         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11325         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11326         type.
11327         (inf_ptrace_target::attach): Update.
11328         (inf_ptrace_target::files_info): Update.
11329         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11330         type.
11331         (go32_nat_target::pid_to_str): Change return type.
11332         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11333         (gnu_nat_target::wait): Update.
11334         (gnu_nat_target::wait): Update.
11335         (gnu_nat_target::resume): Update.
11336         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11337         (fbsd_nat_target::wait): Update.
11338         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11339         type.
11340         (darwin_nat_target::attach): Update.
11341         * corelow.c (class core_target) <pid_to_str>: Change return type.
11342         (core_target::pid_to_str): Change return type.
11343         * target.c (normal_pid_to_str): Change return type.
11344         (default_pid_to_str): Likewise.
11345         (target_pid_to_str): Change return type.
11346         (target_translate_tls_address): Update.
11347         (target_announce_detach): Update.
11348         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11349         return type.
11350         (bsd_uthread_target::pid_to_str): Change return type.
11351         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11352         type.
11353         (bsd_kvm_target::pid_to_str): Change return type.
11354         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11355         return type.
11356         (aix_thread_target::pid_to_str): Change return type.
11357         * target.h (struct target_ops) <pid_to_str>: Change return type.
11358         (target_pid_to_str, normal_pid_to_str): Likewise.
11359         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11360         type.
11361         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11362         type.
11363         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11364         return type.
11365         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11366         type.
11367         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11368         type.
11369         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11370         return type.
11371
11372 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11373
11374         * NEWS: Mention that the new default MI version is 3.  Mention
11375         changes to the output of commands and events that deal with
11376         multi-location breakpoints.
11377         * breakpoint.c: Include "mi/mi-out.h".
11378         (print_one_breakpoint): Change output syntax if using MI version
11379         >= 3.
11380         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11381         New.
11382         (mi_multi_location_breakpoint_output_fixed): New.
11383         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11384         (mi_cmd_fix_multi_location_breakpoint_output): New.
11385         (mi_multi_location_breakpoint_output_fixed): New.
11386         * mi/mi-cmds.c (mi_cmds): Register command
11387         -fix-multi-location-breakpoint-output.
11388         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11389         interpreter "mi".
11390
11391 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11392
11393         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11394         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11395         instantiate mi_ui_out based on interpreter name.
11396         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11397         * mi/mi-main.c (mi_load_progress): Likewise.
11398
11399 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11400
11401         * NEWS: Combine separate "New targets" sections for 8.3.
11402
11403 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11404
11405         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11406         (ppcfbsd_init_abi): Install gdbarch
11407         "fetch_tls_load_module_address" and "get_thread_local_address"
11408         methods.
11409
11410 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11411
11412         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11413         (riscv_fbsd_init_abi): Install gdbarch
11414         "fetch_tls_load_module_address" and "get_thread_local_address"
11415         methods.
11416
11417 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11418
11419         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11420         (i386fbsd_init_abi): Install gdbarch
11421         "fetch_tls_load_module_address" and "get_thread_local_address"
11422         methods.
11423
11424 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11425
11426         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11427         (amd64fbsd_init_abi): Install gdbarch
11428         "fetch_tls_load_module_address" and "get_thread_local_address"
11429         methods.
11430
11431 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11432
11433         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11434         (struct fbsd_pspace_data): New type.
11435         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11436         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11437         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11438         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11439         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11440
11441 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11442
11443         * gdbtypes.c (lookup_struct_elt): New function.
11444         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11445         * gdbtypes.h (struct struct_elt): New type.
11446         (lookup_struct_elt): New prototype.
11447
11448 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11449
11450         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11451         remove disabled code block.
11452
11453 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11454
11455         * gdbarch.sh (get_thread_local_address): New method.
11456         * gdbarch.h, gdbarch.c: Regenerate.
11457         * target.c (target_translate_tls_address): Use
11458         gdbarch_get_thread_local_address if present instead of
11459         target::get_thread_local_address.
11460
11461 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11462
11463         * target.h (target::get_thread_local_address): Update comment.
11464
11465 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11466
11467         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11468         objfile->separate_debug_objfile_backlink if not NULL.
11469
11470 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11471
11472         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11473         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11474         (amd64bsd_store_inferior_registers): Likewise.
11475         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11476         Enable segment base registers.
11477         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11478         PT_GETFSBASE and PT_GETGSBASE.
11479         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11480         PT_SETGSBASE.
11481         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11482         segment base registers.
11483         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11484
11485 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11486
11487         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11488         Update calls to i386_target_description to add 'segments'
11489         parameter.
11490         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11491         add segment base registers.
11492         * arch/i386.c (i386_create_target_description): Add 'segments'
11493         parameter to enable segment base registers.
11494         * arch/i386.h (i386_create_target_description): Likewise.
11495         * features/i386/32bit-segments.xml: New file.
11496         * features/i386/32bit-segments.c: Generate.
11497         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11498         call to i386_target_description to add 'segments' parameter.
11499         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11500         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11501         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11502         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11503         if feature is present.
11504         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11505         Add 'segments' parameter to call to i386_target_description.
11506         (i386_target_description): Add 'segments' parameter to enable
11507         segment base registers.
11508         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11509         to call to i386_target_description.
11510         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11511         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11512         Define I386_NUM_REGS.
11513         (i386_target_description): Add 'segments' parameter to enable
11514         segment base registers.
11515
11516 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11517
11518         PR/24325
11519         * source-cache.c: #undef open and close, to avoid unresolved
11520         externals during linking.
11521
11522 2019-03-12  Tom Tromey  <tromey@adacore.com>
11523
11524         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11525         const.  Add initializers.
11526         (_initialize_remote): Don't initialize ptid globals.
11527
11528 2019-03-12  Pedro Alves  <palves@redhat.com>
11529
11530         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11531
11532 2019-03-12  Pedro Alves  <palves@redhat.com>
11533
11534         * cp-name-parser.y (main): Remove unused 'len' variable.
11535
11536 2019-03-12  Tom Tromey  <tromey@adacore.com>
11537
11538         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11539         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11540
11541 2019-03-12  Tom Tromey  <tromey@adacore.com>
11542
11543         * linux-nat.c (iterate_over_lwps): Update.
11544         (stop_callback): Remove parameter.
11545         (stop_wait_callback, detach_callback, resume_set_callback)
11546         (select_singlestep_lwp_callback, set_ignore_sigint)
11547         (status_callback, resumed_callback, resume_clear_callback)
11548         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11549         data parameter.
11550         (linux_nat_target::detach, linux_nat_target::resume)
11551         (linux_stop_and_wait_all_lwps, select_event_lwp)
11552         (linux_nat_filter_event, linux_nat_wait_1)
11553         (linux_nat_target::kill, linux_nat_target::stop)
11554         (linux_nat_target::stop): Update.
11555         (linux_nat_resume_callback): Change type.
11556         (resume_stopped_resumed_lwps, count_events_callback)
11557         (select_event_lwp_callback): Likewise.
11558         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11559         * arm-linux-nat.c (struct update_registers_data): Remove.
11560         (update_registers_callback): Change type.
11561         (arm_linux_insert_hw_breakpoint1): Update.
11562         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11563         parameter.
11564         (x86_linux_dr_set_addr): Update.
11565         (x86_linux_dr_set_control): Update.
11566         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11567         (iterate_over_lwps): Use gdb::function_view.
11568         * nat/aarch64-linux-hw-point.c (struct
11569         aarch64_dr_update_callback_param): Remove.
11570         (debug_reg_change_callback): Change type.
11571         (aarch64_notify_debug_reg_change): Update.
11572         * s390-linux-nat.c (s390_refresh_per_info): Update.
11573
11574 2019-03-11  Tom Tromey  <tromey@adacore.com>
11575
11576         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11577         redundant assignment to "this_cu".
11578
11579 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11580
11581         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11582
11583 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11584
11585         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11586         from...
11587         (rank_one_type): ... this.
11588
11589 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11590
11591         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11592         from...
11593         (rank_one_type): ... this.
11594
11595 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11596
11597         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11598         from...
11599         (rank_one_type): ... this.
11600
11601 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11602
11603         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11604         from...
11605         (rank_one_type): ... this.
11606
11607 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11608
11609         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11610         from...
11611         (rank_one_type): ... this.
11612
11613 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11614
11615         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11616         from...
11617         (rank_one_type): ... this.
11618
11619 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11620
11621         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11622         from...
11623         (rank_one_type): ... this.
11624
11625 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11626
11627         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11628         from...
11629         (rank_one_type): ... this.
11630
11631 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11632
11633         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11634         from...
11635         (rank_one_type): ... this.
11636
11637 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11638
11639         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11640         from...
11641         (rank_one_type): ... this.
11642
11643 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11644
11645         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11646         from...
11647         (rank_one_type): ... this.
11648
11649 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11650
11651         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11652         from...
11653         (rank_one_type): ... this.
11654
11655 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11656
11657         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11658         inferior-events' shows the example events.
11659
11660 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11661
11662         Support styling on native MS-Windows console
11663
11664         PR/24315
11665         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11666         on MS-Windows if $TERM is not defined.
11667
11668         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11669
11670         * posix-hdep.c (gdb_console_fputs):
11671         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11672         functions.
11673         * ui-file.h (gdb_console_fputs): Add prototype.
11674
11675         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11676         back to fputs only if the former returns zero.
11677
11678 2019-03-07  Tom Tromey  <tom@tromey.com>
11679
11680         * symmisc.c (print_symbol_bcache_statistics): Update.
11681         (print_objfile_statistics): Update.
11682         * symfile.c (allocate_symtab): Update.
11683         * stabsread.c: Don't include bcache.h.
11684         * psymtab.h (struct psymbol_bcache): Don't declare.
11685         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11686         (psymbol_bcache_init, psymbol_bcache_free)
11687         (psymbol_bcache_get_bcache): Don't declare.
11688         * psymtab.c (struct psymbol_bcache): Remove.
11689         (psymtab_storage::psymtab_storage): Update.
11690         (psymtab_storage::~psymtab_storage): Update.
11691         (psymbol_bcache_init, psymbol_bcache_free)
11692         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11693         (add_psymbol_to_bcache): Update.
11694         (allocate_psymtab): Update.
11695         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11696         macro_cache>: No longer pointers.
11697         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11698         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11699         * macrotab.c (macro_bcache): Update.
11700         * macroexp.c: Don't include bcache.h.
11701         * gdbtypes.c (check_types_worklist): Update.
11702         (types_deeply_equal): Remove TRY/CATCH.  Update.
11703         * elfread.c (elf_symtab_read): Update.
11704         * dwarf2read.c: Don't include bcache.h.
11705         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11706         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11707         (print_bcache_statistics, bcache_memory_used): Don't declare.
11708         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11709         methods.  Rename all data members.
11710         * bcache.c (struct bcache): Move to bcache.h.
11711         (bcache::expand_hash_table): Rename from expand_hash_table.
11712         (bcache): Remove.
11713         (bcache::insert): Rename from bcache_full.
11714         (bcache::compare): Rename from bcache_compare.
11715         (bcache_xmalloc): Remove.
11716         (bcache::~bcache): Rename from bcache_xfree.
11717         (bcache::print_statistics): Rename from print_bcache_statistics.
11718         (bcache::memory_used): Rename from bcache_memory_used.
11719
11720 2019-03-07  Pedro Alves  <palves@redhat.com>
11721
11722         * infrun.c (normal_stop): Also check for
11723         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11724
11725 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11726
11727         * f-lang.c (value_from_host_double): Moved to...
11728         * value.c (value_from_host_double): ...here.
11729         * value.h (value_from_host_double): Declare.
11730         * guile/scm-math.c (vlscm_convert_typed_number): Use
11731         value_from_host_double.
11732         (vlscm_convert_number): Likewise.
11733         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11734         * python/py-value.c (convert_value_from_python): Likewise.
11735
11736 2019-03-06  Tom Tromey  <tom@tromey.com>
11737
11738         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11739
11740 2019-03-06  Tom Tromey  <tom@tromey.com>
11741
11742         * utils.h (free_current_contents): Don't declare.
11743         * utils.c (free_current_contents): Remove.
11744
11745 2019-03-06  Tom Tromey  <tom@tromey.com>
11746
11747         * top.c (quit_force): Update.
11748         * main.c (captured_command_loop): Update.
11749         * common/new-op.c (operator new): Update.
11750         * common/common-exceptions.c (struct catcher)
11751         <save_cleanup_chain>: Remove member.
11752         (exceptions_state_mc_init): Update.
11753         (exception_try_scope_entry): Return nullptr.
11754         (exception_try_scope_exit, exception_rethrow)
11755         (throw_exception_sjlj, throw_exception_cxx): Update.
11756         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11757         (all_cleanups, do_cleanups, discard_cleanups)
11758         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11759         (restore_cleanups, restore_final_cleanups): Don't declare.
11760         (do_final_cleanups): Remove parameter.
11761         * common/cleanups.c (cleanup_chain, make_cleanup)
11762         (make_cleanup_dtor, all_cleanups, do_cleanups)
11763         (discard_my_cleanups, discard_cleanups)
11764         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11765         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11766         (null_cleanup): Remove.
11767         (do_final_cleanups): Remove parameter.
11768
11769 2019-03-06  Tom Tromey  <tom@tromey.com>
11770
11771         * remote.c (remote_target::remote_parse_stop_reply): Use
11772         unique_xmalloc_ptr.
11773
11774 2019-03-06  Tom Tromey  <tom@tromey.com>
11775
11776         * stabsread.c (struct stabs_field_info): Rename from field_info.
11777         <list, fnlist>: Add initializers.
11778         <obstack>: New member.
11779         (read_member_functions, read_struct_fields, read_baseclasses):
11780         Allocate on obstack.  Don't use cleanups.
11781         (read_one_struct_field, read_member_functions, read_struct_fields)
11782         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11783         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11784         (read_struct_type): Update.
11785
11786 2019-03-06  Tom Tromey  <tom@tromey.com>
11787
11788         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11789         * common/filestuff.h (make_cleanup_close): Don't declare.
11790         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11791         Remove.
11792
11793 2019-03-06  Tom Tromey  <tom@tromey.com>
11794
11795         * solib-aix.c: Use make_scope_exit.
11796
11797 2019-03-06  Tom Tromey  <tom@tromey.com>
11798
11799         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11800         Use make_scope_exit.
11801
11802 2019-03-06  Tom Tromey  <tom@tromey.com>
11803
11804         * solib-svr4.c (disable_probes_interface): Remove parameter.
11805         (svr4_handle_solib_event): Use make_scope_exit.
11806
11807 2019-03-06  Tom Tromey  <tom@tromey.com>
11808
11809         * remote.c (struct stop_reply_deleter): Remove.
11810         (stop_reply_up): Update.
11811         (struct stop_reply): Derive from notif_event.  Don't typedef.
11812         <regcache>: Now a std::vector.
11813         (stop_reply_xfree): Remove.
11814         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11815         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11816         (remote_target::discard_pending_stop_replies): Use delete.
11817         (remote_target::remote_parse_stop_reply): Update.
11818         (remote_target::process_stop_reply): Update.
11819         * remote-notif.h (struct notif_event): Add virtual destructor.
11820         Remove "dtr" member.
11821         (struct notif_client) <alloc_event>: Return a unique_ptr.
11822         (notif_event_xfree): Don't declare.
11823         (notif_event_up): New typedef.
11824         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11825         (notif_event_xfree, do_notif_event_xfree): Remove.
11826         (remote_notif_state_xfree): Update.
11827
11828 2019-03-06  Tom Tromey  <tom@tromey.com>
11829
11830         * infrun.c (displaced_step_clear_cleanup): Now a
11831         forward_scope_exit type.
11832         (displaced_step_prepare_throw): Update.
11833         (displaced_step_fixup): Update.
11834
11835 2019-03-06  Tom Tromey  <tom@tromey.com>
11836
11837         * inferior.h (class inferior): Update comment.
11838         * gdbthread.h (class thread_info): Update comment.
11839
11840 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11841             Tom Tromey  <tom@tromey.com>
11842
11843         * stabsread.h (struct stab_section_list): Remove.
11844         (coffstab_build_psymtabs): Update.
11845         * dbxread.c (symbuf_sections): Now a std::vector.
11846         (sect_idx): New global.
11847         (fill_symbuf): Update.
11848         (coffstab_build_psymtabs): Change type of stabsects parameter.
11849         Update.
11850         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11851         std::vector.
11852         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11853         (coff_locate_sections): Update.
11854         (coff_symfile_read): Remove cleanups.  Update.
11855         (init_stringtab): Add storage parameter.
11856         (free_stringtab, free_stringtab_cleanup): Remove.
11857         (init_lineno): Add storage parameter.
11858         (free_linetab, free_linetab_cleanup): Remove.
11859
11860 2019-03-06  Pedro Alves  <palves@redhat.com>
11861
11862         * linux-fork.c (fork_info::clobber_regs): Delete.
11863         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11864         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11865         comment.  Adjust.
11866         (scoped_switch_fork_info::scoped_switch_fork_info)
11867         (checkpoint_command, linux_fork_context): Adjust
11868         fork_save_infrun_state calls.
11869
11870 2019-03-06  Pedro Alves  <palves@redhat.com>
11871
11872         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11873         (inf_has_multiple_threads): Return 'bool' and rewrite using
11874         inferior_info::threads().
11875
11876 2019-03-06  Pedro Alves  <palves@redhat.com>
11877
11878         * linux-fork.c: Include <list>.
11879         (fork_list): Now a std::list instance.
11880         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11881         (forks_exist_p, find_last_fork): Adjust.
11882         (new_fork): Delete.
11883         (one_fork_p): New.
11884         (add_fork): Adjust.
11885         (free_fork): Delete, folded into fork_info::~fork_info().
11886         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11887         Adjust.
11888         (init_fork_list): Delete.
11889         (linux_fork_killall, linux_fork_mourn_inferior)
11890         (linux_fork_detach, info_checkpoints_command): Adjust.
11891         (_initialize_linux_fork): No longer call init_fork_list.
11892
11893 2019-03-06  Pedro Alves  <palves@redhat.com>
11894
11895         * linux-fork.c (new_fork): New, split out of ...
11896         (add_fork): ... this.  Return void.  Move "first fork" special
11897         case from here, to ...
11898         (checkpoint_command): ... here.
11899         * linux-linux.h (add_fork): Return void.
11900
11901 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11902
11903         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11904
11905 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11906             Chris January  <chris.january@arm.com>
11907             David Lecomber  <david.lecomber@arm.com>
11908
11909         * f-exp.y: New token, UNOP_INTRINSIC.
11910         (exp): New pattern using UNOP_INTRINSIC token.
11911         (f77_keywords): Add 'abs' keyword.
11912         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11913         (value_from_host_double): New function.
11914         (evaluate_subexp_f): Support UNOP_ABS.
11915
11916 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11917
11918         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11919         types.
11920
11921 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11922
11923         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11924         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11925         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11926
11927 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11928
11929         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11930
11931 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11932             Chris January  <chris.january@arm.com>
11933
11934         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11935         * f-exp.y: Define 'KIND' token.
11936         (exp): New pattern for KIND expressions.
11937         (ptype): Handle types with a kind extension.
11938         (direct_abs_decl): Extend to spot kind extensions.
11939         (f77_keywords): Add 'kind' to the list.
11940         (push_kind_type): New function.
11941         (convert_to_kind_type): New function.
11942         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11943         * parse.c (operator_length_standard): Likewise.
11944         * parser-defs.h (enum type_pieces): Add tp_kind.
11945         * std-operator.def: Add UNOP_KIND.
11946
11947 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11948
11949         * f-exp.y (f_parse): Set yydebug.
11950
11951 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11952
11953         * f-lang.c (evaluate_subexp_f): New function.
11954         (exp_descriptor_f): New global.
11955         (f_language_defn): Use exp_descriptor_f instead of
11956         exp_descriptor_standard.
11957
11958 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11959
11960         * f-exp.y (struct token): Add comments.
11961         (dot_ops): Remove uppercase versions and the end marker.
11962         (f77_keywords): Likewise.
11963         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11964         entries in the dot_ops array are case insensitive, and use
11965         strncasecmp to compare strings.  Also some whitespace cleanup in
11966         this area.  Similar for the f77_keywords array, except entries in
11967         this list might be case sensitive.
11968
11969 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11970
11971         * f-exp.y (struct f77_boolean_val): Add comments.
11972         (boolean_values): Remove uppercase versions, and end marker.
11973         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11974         and use strncasecmp to achieve case insensitivity.  Additionally,
11975         perform whitespace cleanup around this code.
11976
11977 2019-03-06  Tom Tromey  <tromey@adacore.com>
11978
11979         * remote-sim.c (gdbsim_target_open): Use result of
11980         gdb_argv::release.
11981
11982 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11983         Dirk Schubert  <dirk.schubert@arm.com>
11984         Chris January  <chris.january@arm.com>
11985
11986         * eval.c (evaluate_subexp_standard): Call Fortran argument
11987         wrapping logic.
11988         * f-lang.c (struct value): A value which can be passed into a
11989         Fortran function call.
11990         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11991         where appropriate.
11992         (struct type): Value ready for a Fortran function call.
11993         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11994         is needed.
11995         * f-lang.h (fortran_argument_convert): Declaration.
11996         (fortran_preserve_arg_pointer): Declaration.
11997         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11998
11999 2019-03-05  Tom Tromey  <tromey@adacore.com>
12000
12001         * python/py-prettyprint.c (print_string_repr): Remove #if.
12002         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12003
12004 2019-03-05  Tom Tromey  <tromey@adacore.com>
12005
12006         * target.c (the_dummy_target): Move later.  Change type to
12007         "dummy_target".
12008         (initialize_targets): Don't initialize the_dummy_target.
12009
12010 2019-03-05  Tom Tromey  <tromey@adacore.com>
12011
12012         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12013         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12014
12015 2019-03-05  Tom Tromey  <tromey@adacore.com>
12016
12017         * windows-nat.c (windows_nat_target::attach)
12018         (windows_nat_target::detach): Don't call gdb_flush.
12019         * valprint.c (generic_val_print, val_print, val_print_string):
12020         Don't call gdb_flush.
12021         * utils.c (defaulted_query): Don't call gdb_flush.
12022         * typeprint.c (print_type_scalar): Don't call gdb_flush.
12023         * target.c (target_announce_detach): Don't call gdb_flush.
12024         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12025         * remote.c (extended_remote_target::attach): Don't call
12026         gdb_flush.
12027         * procfs.c (procfs_target::detach): Don't call gdb_flush.
12028         * printcmd.c (do_examine): Don't call gdb_flush.
12029         (info_display_command): Don't call gdb_flush.
12030         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12031         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12032         * memattr.c (info_mem_command): Don't call gdb_flush.
12033         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12034         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12035         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12036         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12037         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12038         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12039         (gnu_nat_target::detach): Don't call gdb_flush.
12040         * f-valprint.c (f_val_print): Don't call gdb_flush.
12041         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12042         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12043         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12044         gdb_flush.
12045         * c-valprint.c (c_val_print): Don't call gdb_flush.
12046         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12047
12048 2019-03-05  Tom Tromey  <tromey@adacore.com>
12049
12050         * varobj.c (update_dynamic_varobj_children): Update.
12051         (install_default_visualizer): Use reset, not release.
12052         * value.c (set_internalvar): Update.
12053         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12054         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12055         ATTRIBUTE_UNUSED_RESULT.
12056
12057 2019-03-05  Tom Tromey  <tromey@adacore.com>
12058
12059         * remote.c (class scoped_remote_fd) <release>: Add
12060         ATTRIBUTE_UNUSED_RESULT.
12061
12062 2019-03-05  Tom Tromey  <tromey@adacore.com>
12063
12064         * macroexp.c (struct macro_buffer) <release>: Add
12065         ATTRIBUTE_UNUSED_RESULT.
12066
12067 2019-03-05  Tom Tromey  <tromey@adacore.com>
12068
12069         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12070         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12071         ATTRIBUTE_UNUSED_RESULT.
12072
12073 2019-03-05  Tom Tromey  <tromey@adacore.com>
12074
12075         * common/scoped_fd.h (class scoped_fd) <release>: Add
12076         ATTRIBUTE_UNUSED_RESULT.
12077
12078 2019-03-05  Tom Tromey  <tromey@adacore.com>
12079
12080         * parser-defs.h (struct parser_state) <release>: Add
12081         ATTRIBUTE_UNUSED_RESULT.
12082
12083 2019-03-05  Tom Tromey  <tromey@adacore.com>
12084
12085         * utils.h (class gdb_argv) <release>: Add
12086         ATTRIBUTE_UNUSED_RESULT.
12087         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12088
12089 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
12090
12091         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12092         for-loop range, to avoid compiler warnings.
12093
12094         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12095         avoid compiler warnings about unused variables.
12096
12097         * NEWS: Mention end of support for native debugging on MS-Windows
12098         before XP.
12099
12100         PR gdb/24292
12101         * common/netstuff.c:
12102         * gdbserver/gdbreplay.c
12103         * gdbserver/remote-utils.c:
12104         * ser-tcp.c:
12105         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12106         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
12107         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12108         'getaddrinfo' and 'freeaddrinfo' were not available before
12109         Windows XP, and mingw.org's MinGW headers by default define
12110         _WIN32_WINNT to 0x500.
12111
12112 2019-03-01  Gary Benson <gbenson@redhat.com>
12113
12114         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12115
12116 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
12117             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
12118
12119         PR gdb/8527
12120         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12121         set_sigint_trap, clear_sigint_trap.
12122
12123 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12124
12125         * target.c (target_detach): Clear the regcache and the
12126         frame cache.
12127
12128 2019-02-27  Pedro Alves  <palves@redhat.com>
12129
12130         * utils.c (set_screen_size): When we cap the height/width sizes,
12131         tweak the corresponding command variable to show "unlimited":
12132
12133 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
12134             Pedro Alves  <palves@redhat.com>
12135
12136         * utils.c (set_screen_size): Reduce "infinite" rows and columns
12137         before calling rl_set_screen_size.
12138
12139 2019-02-27  Tom Tromey  <tromey@adacore.com>
12140
12141         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12142         define.
12143         * python/py-value.c: Remove Python 2.4 workaround.
12144         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12145         workaround.
12146         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12147         Python 2.4 workaround.
12148         * python/python-internal.h: Remove Python 2.4 comment.
12149         (Py_ssize_t): Don't define.
12150         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12151         (gdb_Py_DECREF): Remove Python 2.4 workaround.
12152         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12153         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12154         * python/python.c (do_start_initialization): Remove Python 2.4
12155         workaround.
12156         * python/py-prettyprint.c (class dummy_python_frame): Remove.
12157         (print_children): Remove Python 2.4 workaround.
12158         * python/py-inferior.c (buffer_procs): Remove Python 2.4
12159         workaround.
12160         (CHARBUFFERPROC_NAME): Remove.
12161         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12162         Python 2.4 workaround.
12163
12164 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12165
12166         * NEWS: Note minimum Python version.
12167
12168 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
12169
12170         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12171         code from these functions.  Remove corresponding ifdefs.  Use
12172         Py_buffer_up instead of explicit calls to PyBuffer_Release.
12173         Remove gotos and target of gotos.
12174         (infpy_search_memory): Likewise.
12175
12176 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12177
12178         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12179         (hppa_gdbarch_init): Don't register deleted functions with
12180         gdbarch.
12181
12182 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12183
12184         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12185         (h8300_unwind_sp): Delete.
12186         (h8300_dummy_id): Delete.
12187         (h8300_gdbarch_init): Don't register deleted functions with
12188         gdbarch.
12189
12190 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12191
12192         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12193         (ft32_unwind_pc): Delete.
12194         (ft32_unwind_sp): Delete.
12195         (ft32_gdbarch_init): Don't register deleted functions with
12196         gdbarch.
12197
12198 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12199
12200         * gdb/frv-tdep.c (frv_dummy_id): Delete.
12201         (frv_unwind_pc): Delete.
12202         (frv_unwind_sp): Delete.
12203         (frv_gdbarch_init): Don't register deleted functions with
12204         gdbarch.
12205
12206 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12207
12208         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12209         (riscv_unwind_pc): Delete.
12210         (riscv_unwind_sp): Delete.
12211         (riscv_gdbarch_init): Don't register deleted functions with
12212         gdbarch.
12213
12214 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12215
12216         * gdb/csky-tdep.c (csky_dummy_id): Delete.
12217         (csky_unwind_pc): Delete.
12218         (csky_unwind_sp): Delete.
12219         (csky_gdbarch_init): Don't register deleted functions with
12220         gdbarch.
12221
12222 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12223
12224         * gdb/cris-tdep.c (cris_dummy_id): Delete.
12225         (cris_unwind_pc): Delete.
12226         (cris_unwind_sp): Delete.
12227         (cris_gdbarch_init): Don't register deleted functions with
12228         gdbarch.
12229
12230 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12231
12232         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
12233         (bfin_unwind_pc): Delete.
12234         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
12235
12236 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12237
12238         * gdb/arm-tdep.c (arm_dummy_id): Delete.
12239         (arm_unwind_pc): Delete.
12240         (arm_unwind_sp): Delete.
12241         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
12242
12243 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12244
12245         * gdb/arc-tdep.c (arc_dummy_id): Delete.
12246         (arc_unwind_pc): Delete.
12247         (arc_unwind_sp): Delete.
12248         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
12249
12250 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12251
12252         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
12253         (alpha_unwind_pc): Delete.
12254         (alpha_gdbarch_init): Don't register deleted functions with
12255         gdbarch.
12256
12257 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12258
12259         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
12260         (aarch64_unwind_pc): Delete.
12261         (aarch64_unwind_sp): Delete.
12262         (aarch64_gdbarch_init): Don't register deleted functions with
12263         gdbarch.
12264
12265 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12266
12267         * gdbtypes.c (type_align): Don't consider static members when
12268         computing structure alignment.
12269
12270 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
12271
12272         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
12273         return 0 for other types.
12274         * arch-utils.c (default_type_align): Always return 0.
12275         * gdbarch.h: Regenerate.
12276         * gdbarch.sh (type_align): Extend comment.
12277         * gdbtypes.c (type_align): Add additional comments, always call
12278         gdbarch_type_align before applying the default rules.
12279         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
12280         generic code will then apply a suitable default.
12281         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
12282         types, return 0 for other types.
12283
12284 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12285
12286         * NEWS: Create a new section for the next release branch.
12287         Rename the section of the current branch, now that it has
12288         been cut.
12289
12290 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12291
12292         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12293         * version.in: Bump version to 8.3.50.DATE-git.
12294
12295 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12296
12297         * aix-thread.c (ptid_cmp): Remove unused variable.
12298         (get_signaled_thread): Likewise.
12299         (store_regs_user_thread): Likewise.
12300         (store_regs_kernel_thread): Likewise.
12301         (fetch_regs_kernel_thread): Remove shadowed variable.
12302
12303 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12304
12305         * features/riscv/32bit-cpu.xml: Add register numbers.
12306         * features/riscv/32bit-fpu.c: Regenerate.
12307         * features/riscv/32bit-fpu.xml: Add register numbers.
12308         * features/riscv/64bit-cpu.xml: Add register numbers.
12309         * features/riscv/64bit-fpu.c: Regenerate.
12310         * features/riscv/64bit-fpu.xml: Add register numbers.
12311
12312 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12313
12314         * NEWS: Mention two argument form of gdb.Value constructor.
12315         * python/py-value.c (convert_buffer_and_type_to_value): New
12316         function.
12317         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12318         Add support for handling an optional second argument.  Call
12319         convert_buffer_and_type_to_value as appropriate.
12320         * python/python-internal.h (Py_buffer_deleter): New struct.
12321         (Py_buffer_up): New typedef.
12322
12323 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12324
12325         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12326         instead of releasing ownership.
12327
12328 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12329
12330         * dwarf2read.c (open_and_init_dwp_file): Call
12331         elf_numsections instead of bfd_count_sections to initialize
12332         dwp_file->num_sections.
12333
12334 2019-02-25  Tom Tromey  <tromey@adacore.com>
12335
12336         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12337
12338 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12339
12340         * gcore.in: Add '--readnever' option when invoking GDB.
12341
12342 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12343
12344         * MAINTAINERS: Update my email address.
12345
12346 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12347
12348         * build-id.c (build_id_to_debug_bfd_1): New function.
12349         (build_id_to_debug_bfd): Look for separate debug file in
12350         sysroot.
12351
12352 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12353
12354         * gdbarch.sh: Update the copyright year range that is placed into
12355         generated files.
12356
12357 2019-02-22  Keith Seitz  <keiths@redhat.com>
12358
12359         PR symtab/23853
12360         * linespec.c (create_sals_line_offset): Search for the default
12361         symtab's filename instead of its fullname.
12362
12363 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12364
12365         * NEWS: Update style defaults.
12366
12367 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12368
12369         * main.c (captured_main_1): Disable styling in batch mode.
12370
12371 2019-02-20  Tom Tromey  <tom@tromey.com>
12372
12373         * symtab.c (symtab_symbol_info): Fix typos.
12374
12375 2019-02-20  Tom Tromey  <tromey@adacore.com>
12376
12377         * findcmd.c (_initialize_mem_search): Use upper case for
12378         metasyntactic variables.
12379
12380 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12381
12382         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12383         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12384
12385 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12386
12387         * top.h (source_file_name): Change to std::string.
12388         * top.c (source_file_name): Likewise.
12389         (command_line_input): Adjust.
12390         * cli/cli-script.c (script_from_file): Adjust.
12391
12392 2019-02-19  Tom Tromey  <tromey@adacore.com>
12393
12394         * ravenscar-thread.c
12395         (ravenscar_thread_target::update_thread_list): Don't call
12396         ada_build_task_list.
12397         * ada-lang.h (ada_build_task_list): Don't declare.
12398         * ada-tasks.c (struct ada_tasks_inferior_data)
12399         <task_list_valid_p>: Now bool.
12400         (read_known_tasks, ada_task_list_changed)
12401         (ada_tasks_invalidate_inferior_data): Update.
12402         (read_known_tasks_array): Return bool.
12403         (read_known_tasks_list): Likewise.
12404         (read_known_tasks): Return void.
12405         (ada_build_task_list): Now static.
12406
12407 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12408
12409         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12410         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12411
12412 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12413
12414         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12415         variant for ada_tasks_pspace_data_handle and
12416         ada_tasks_inferior_data_handle.
12417         (ada_tasks_pspace_data_cleanup): New function.
12418         (ada_tasks_inferior_data_cleanup): New function.
12419
12420 2019-02-17  Tom Tromey  <tom@tromey.com>
12421
12422         * macrotab.h (macro_source_fullname): Return a std::string.
12423         * macrotab.c (macro_include, check_for_redefinition)
12424         (macro_undef, macro_lookup_definition, foreach_macro)
12425         (foreach_macro_in_scope): Update.
12426         (macro_source_fullname): Return a std::string.
12427         * macrocmd.c (show_pp_source_pos): Update.
12428
12429 2019-02-17  Tom Tromey  <tom@tromey.com>
12430
12431         * macrocmd.c (show_pp_source_pos): Style the file names.
12432
12433 2019-02-17  Tom Tromey  <tom@tromey.com>
12434
12435         PR tui/24197:
12436         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12437
12438 2019-02-17  Tom Tromey  <tom@tromey.com>
12439
12440         * ada-lang.c (user_select_syms): Use filtered printing.
12441         * utils.c (wrap_style): New global.
12442         (desired_style): Remove.
12443         (emit_style_escape): Add stream parameter.
12444         (set_output_style, reset_terminal_style, prompt_for_continue):
12445         Update.
12446         (flush_wrap_buffer): Only flush gdb_stdout.
12447         (wrap_here): Set wrap_style.
12448         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12449         treat escape sequences as a character.  Change when wrap buffer is
12450         flushed.
12451         (fputs_styled): Do not set the output style when the default is
12452         requested.
12453         * ui-style.h (struct ui_file_style) <is_default>: New method.
12454         * source.c (print_source_lines_base): Emit escape sequences in one
12455         piece.
12456
12457 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12458
12459         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12460         integers and enumeration types.
12461
12462 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12463
12464         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12465         instead of lookup_symbol_in_language
12466         (do_exact_match): New function.
12467         (ada_get_symbol_name_matcher): Return do_exact_match when
12468         doing a verbatim match.
12469
12470 2019-02-15  Tom Tromey  <tromey@adacore.com>
12471
12472         * ravenscar-thread.c (ravenscar_thread_target::resume)
12473         (ravenscar_thread_target::wait): Special case wildcard requests.
12474
12475 2019-02-15  Tom Tromey  <tromey@adacore.com>
12476
12477         * ravenscar-thread.c (base_ptid): Remove.
12478         (struct ravenscar_thread_target) <close>: New method.
12479         <m_base_ptid>: New member.
12480         <update_inferior_ptid, active_task, task_is_currently_active,
12481         runtime_initialized>: Declare methods.
12482         <ravenscar_thread_target>: Add constructor.
12483         (ravenscar_thread_target::task_is_currently_active)
12484         (ravenscar_thread_target::update_inferior_ptid)
12485         (ravenscar_runtime_initialized): Rename.  Now methods.
12486         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12487         (ravenscar_thread_target::update_thread_list): Update.
12488         (ravenscar_thread_target::active_task): Now method.
12489         (ravenscar_thread_target::store_registers)
12490         (ravenscar_thread_target::prepare_to_store)
12491         (ravenscar_thread_target::prepare_to_store)
12492         (ravenscar_thread_target::mourn_inferior): Update.
12493         (ravenscar_inferior_created): Use "new" to create target.
12494         (ravenscar_thread_target::get_ada_task_ptid): Update.
12495         (_initialize_ravenscar): Don't initialize base_ptid.
12496         (ravenscar_ops): Remove global.
12497
12498 2019-02-15  Tom Tromey  <tromey@adacore.com>
12499
12500         * target.h (push_target): Declare new overload.
12501         * target.c (push_target): New overload, taking an rvalue reference.
12502         * remote.c (remote_target::open_1): Use push_target overload.
12503         * corelow.c (core_target_open): Use push_target overload.
12504
12505 2019-02-15  Tom Tromey  <tromey@adacore.com>
12506
12507         * ravenscar-thread.c (is_ravenscar_task)
12508         (ravenscar_task_is_currently_active): Return bool.
12509         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12510         (_initialize_ravenscar): Remove "(void)".
12511         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12512         Return bool.
12513
12514 2019-02-15  Tom Tromey  <tromey@adacore.com>
12515
12516         * ravenscar-thread.c (ravenscar_runtime_initializer)
12517         (has_ravenscar_runtime, get_running_thread_id)
12518         (ravenscar_thread_target::resume): Fix indentation.
12519
12520 2019-02-15  Tom Tromey  <tromey@adacore.com>
12521
12522         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12523         from ravenscar_arch_ops.
12524         (sparc_ravenscar_ops::fetch_registers)
12525         (sparc_ravenscar_ops::store_registers): Now methods.
12526         (sparc_ravenscar_prepare_to_store): Remove.
12527         (sparc_ravenscar_ops): Redefine.
12528         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12529         methods and destructor.  Remove members.
12530         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12531         (ravenscar_thread_target::store_registers)
12532         (ravenscar_thread_target::prepare_to_store): Update.
12533         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12534         Remove.
12535         (struct ppc_ravenscar_powerpc_ops): Derive from
12536         ravenscar_arch_ops.
12537         (ppc_ravenscar_powerpc_ops::fetch_registers)
12538         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12539         (ppc_ravenscar_powerpc_ops): Redefine.
12540         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12541         (ppc_ravenscar_e500_ops::fetch_registers)
12542         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12543         (ppc_ravenscar_e500_ops): Redefine.
12544         * aarch64-ravenscar-thread.c
12545         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12546         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12547         (aarch64_ravenscar_fetch_registers)
12548         (aarch64_ravenscar_store_registers): Now methods.
12549         (aarch64_ravenscar_ops): Redefine.
12550
12551 2019-02-15  Tom Tromey  <tromey@adacore.com>
12552
12553         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12554         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12555         (ravenscar_thread_target::stopped_by_watchpoint)
12556         (ravenscar_thread_target::stopped_data_address)
12557         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12558
12559 2019-02-15  Tom Tromey  <tromey@adacore.com>
12560
12561         * ravenscar-thread.c: Fix some typos.
12562
12563 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12564             Tom Tromey  <tromey@adacore.com>
12565
12566         * ada-lang.c (ada_exception_sal): Change addr_string to a
12567         std::string.
12568         (create_ada_exception_catchpoint): Update.
12569
12570 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12571             Tom Tromey  <tromey@adacore.com>
12572
12573         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12574         (bp_location_ops): Remove.
12575         (base_breakpoint_allocate_location): Update.
12576         (free_bp_location): Update.
12577         * ada-lang.c (class ada_catchpoint_location)
12578         <ada_catchpoint_location>: Remove ops parameter.
12579         (ada_catchpoint_location_dtor): Remove.
12580         (ada_catchpoint_location_ops): Remove.
12581         (allocate_location_exception): Update.
12582         * breakpoint.h (struct bp_location_ops): Remove.
12583         (class bp_location) <bp_location>: Remove bp_location_ops
12584         parameter.
12585         <~bp_location>: Add destructor.
12586         <ops>: Remove.
12587
12588 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12589             Pedro Alves  <palves@redhat.com>
12590
12591         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12592         'PATH_MAX'.
12593
12594 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12595             Samuel Thibault  <samuel.thibault@gnu.org>
12596             Thomas Schwinge  <thomas@codesourcery.com>
12597
12598         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12599         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12600
12601 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12602
12603         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12604         (check_empty): Use "const char *".
12605
12606         * gnu-nat.c (gnu_nat_target::detach): Instead of
12607         'detach_inferior (pid)' call
12608         'detach_inferior (find_inferior_pid (pid))'.
12609
12610         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12611         'nat/fork-inferior.o'.
12612         * gnu-nat.c: #include "nat/fork-inferior.h".
12613
12614         * gnu-nat.c (gnu_nat_target::detach): Instead of
12615         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12616         * gnu-nat.h: #include "inf-child.h".
12617         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12618         'i386_gnu_nat_target::fetch_registers'.
12619         (gnu_store_registers): Rename/move to
12620         'i386_gnu_nat_target::store_registers'.
12621
12622         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12623         * gnu-nat.h (mach_thread_info): New function.
12624         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12625
12626         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12627
12628 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12629
12630         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12631
12632 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12633
12634         * windows-nat.c (windows_add_thread): Add new parameter
12635         "main_thread_p" with default value set to false.  Update
12636         function documentation as well as all callers.
12637         (windows_delete_thread): Likewise.
12638         (fake_create_process): Update call to windows_add_thread.
12639         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12640         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12641         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12642         call to windows_delete_thread.
12643
12644 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12645
12646         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12647
12648 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12649
12650         * symfile.c (find_separate_debug_file): Use canonical path of
12651         sysroot with child_path instead of gdb_sysroot if it is valid.
12652
12653 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12654
12655         * symfile.c (find_separate_debug_file): Use child_path to
12656         determine if an object file is under a sysroot.
12657
12658 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12659
12660         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12661         unittests/child-path-selftests.c.
12662         * common/pathstuff.c (child_path): New function.
12663         * common/pathstuff.h (child_path): New prototype.
12664         * unittests/child-path-selftests.c: New file.
12665
12666 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12667
12668         * symfile.c (find_separate_debug_file): Look for separate debug
12669         files in debug directories under the sysroot.
12670
12671 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12672
12673         * symtab.h (struct minimal_symbol data_p): New const method.
12674         (struct minimal_symbol text_p): Likewise.
12675         * symtab.c (output_source_filename): Use file name style
12676         to print file name.
12677         (print_symbol_info): Likewise.
12678         (print_msymbol_info): Use address style to print addresses.
12679         Use function name style to print executable text symbols.
12680         (expand_symtab_containing_pc): Use data_p.
12681         (find_pc_sect_compunit_symtab): Likewise.
12682
12683 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12684
12685         * breakpoint.c (describe_other_breakpoints): Use address style
12686         to print addresses.
12687         (say_where): Likewise.
12688
12689 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12690
12691         * ada-typeprint.c (print_func_type): Print function name
12692         style to print function name.
12693         * c-typeprint.c (c_print_type_1): Likewise.
12694
12695 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12696
12697         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12698         for execve.
12699
12700 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12701
12702         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12703         type_stack.
12704
12705 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12706
12707         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12708         TYPE_CODE_REF types.
12709
12710 2019-02-08  Jim Wilson  <jimw@sifive.com>
12711
12712         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12713         (riscv_linux_fregset): New.
12714         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12715
12716 2019-02-07  Tom Tromey  <tom@tromey.com>
12717
12718         * thread.c (thread_cancel_execution_command): Update.
12719         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12720         methods.
12721         (struct thread_fsm_ops): Remove.
12722         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12723         (thread_fsm_should_stop, thread_fsm_return_value)
12724         (thread_fsm_set_finished, thread_fsm_finished_p)
12725         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12726         Don't declare.
12727         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12728         * infrun.c (clear_proceed_status_thread)
12729         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12730         (print_stop_event): Update.
12731         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12732         Add constructor.
12733         (step_command_fsm_ops): Remove.
12734         (new_step_command_fsm): Remove.
12735         (step_1): Update.
12736         (step_command_fsm::should_stop): Rename from
12737         step_command_fsm_should_stop.
12738         (step_command_fsm::clean_up): Rename from
12739         step_command_fsm_clean_up.
12740         (step_command_fsm::do_async_reply_reason): Rename from
12741         step_command_fsm_async_reply_reason.
12742         (struct until_next_fsm): Inherit from thread_fsm.  Add
12743         constructor.
12744         (until_next_fsm_ops): Remove.
12745         (new_until_next_fsm): Remove.
12746         (until_next_fsm::should_stop): Rename from
12747         until_next_fsm_should_stop.
12748         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12749         (until_next_fsm::do_async_reply_reason): Rename from
12750         until_next_fsm_async_reply_reason.
12751         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12752         constructor.  Change type of breakpoint.
12753         (finish_command_fsm_ops): Remove.
12754         (new_finish_command_fsm): Remove.
12755         (finish_command_fsm::should_stop): Rename from
12756         finish_command_fsm_should_stop.
12757         (finish_command_fsm::clean_up): Rename from
12758         finish_command_fsm_clean_up.
12759         (finish_command_fsm::return_value): Rename from
12760         finish_command_fsm_return_value.
12761         (finish_command_fsm::do_async_reply_reason): Rename from
12762         finish_command_fsm_async_reply_reason.
12763         (finish_command): Update.
12764         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12765         Add constructor.
12766         (call_thread_fsm_ops): Remove.
12767         (call_thread_fsm::call_thread_fsm): Rename from
12768         new_call_thread_fsm.
12769         (call_thread_fsm::should_stop): Rename from
12770         call_thread_fsm_should_stop.
12771         (call_thread_fsm::should_notify_stop): Rename from
12772         call_thread_fsm_should_notify_stop.
12773         (run_inferior_call, call_function_by_hand_dummy): Update.
12774         * cli/cli-interp.c (should_print_stop_to_console): Update.
12775         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12776         Add constructor.  Change type of location_breakpoint,
12777         caller_breakpoint.
12778         (until_break_fsm_ops): Remove.
12779         (new_until_break_fsm): Remove.
12780         (until_break_fsm::should_stop): Rename from
12781         until_break_fsm_should_stop.
12782         (until_break_fsm::clean_up): Rename from
12783         until_break_fsm_clean_up.
12784         (until_break_fsm::do_async_reply_reason): Rename from
12785         until_break_fsm_async_reply_reason.
12786         (until_break_command): Update.
12787         * thread-fsm.c: Remove.
12788         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12789
12790 2019-02-07  Tom Tromey  <tom@tromey.com>
12791
12792         * yy-remap.h: Add include guard.
12793         * xtensa-tdep.h: Add include guard.
12794         * xcoffread.h: Rename include guard.
12795         * varobj-iter.h: Add include guard.
12796         * tui/tui.h: Rename include guard.
12797         * tui/tui-winsource.h: Rename include guard.
12798         * tui/tui-wingeneral.h: Rename include guard.
12799         * tui/tui-windata.h: Rename include guard.
12800         * tui/tui-win.h: Rename include guard.
12801         * tui/tui-stack.h: Rename include guard.
12802         * tui/tui-source.h: Rename include guard.
12803         * tui/tui-regs.h: Rename include guard.
12804         * tui/tui-out.h: Rename include guard.
12805         * tui/tui-layout.h: Rename include guard.
12806         * tui/tui-io.h: Rename include guard.
12807         * tui/tui-hooks.h: Rename include guard.
12808         * tui/tui-file.h: Rename include guard.
12809         * tui/tui-disasm.h: Rename include guard.
12810         * tui/tui-data.h: Rename include guard.
12811         * tui/tui-command.h: Rename include guard.
12812         * tic6x-tdep.h: Add include guard.
12813         * target/waitstatus.h: Rename include guard.
12814         * target/wait.h: Rename include guard.
12815         * target/target.h: Rename include guard.
12816         * target/resume.h: Rename include guard.
12817         * target-float.h: Rename include guard.
12818         * stabsread.h: Add include guard.
12819         * rs6000-tdep.h: Add include guard.
12820         * riscv-fbsd-tdep.h: Add include guard.
12821         * regformats/regdef.h: Rename include guard.
12822         * record.h: Rename include guard.
12823         * python/python.h: Rename include guard.
12824         * python/python-internal.h: Rename include guard.
12825         * python/py-stopevent.h: Rename include guard.
12826         * python/py-ref.h: Rename include guard.
12827         * python/py-record.h: Rename include guard.
12828         * python/py-record-full.h: Rename include guard.
12829         * python/py-record-btrace.h: Rename include guard.
12830         * python/py-instruction.h: Rename include guard.
12831         * python/py-events.h: Rename include guard.
12832         * python/py-event.h: Rename include guard.
12833         * procfs.h: Add include guard.
12834         * proc-utils.h: Add include guard.
12835         * p-lang.h: Add include guard.
12836         * or1k-tdep.h: Rename include guard.
12837         * observable.h: Rename include guard.
12838         * nto-tdep.h: Rename include guard.
12839         * nat/x86-linux.h: Rename include guard.
12840         * nat/x86-linux-dregs.h: Rename include guard.
12841         * nat/x86-gcc-cpuid.h: Add include guard.
12842         * nat/x86-dregs.h: Rename include guard.
12843         * nat/x86-cpuid.h: Rename include guard.
12844         * nat/ppc-linux.h: Rename include guard.
12845         * nat/mips-linux-watch.h: Rename include guard.
12846         * nat/linux-waitpid.h: Rename include guard.
12847         * nat/linux-ptrace.h: Rename include guard.
12848         * nat/linux-procfs.h: Rename include guard.
12849         * nat/linux-osdata.h: Rename include guard.
12850         * nat/linux-nat.h: Rename include guard.
12851         * nat/linux-namespaces.h: Rename include guard.
12852         * nat/linux-btrace.h: Rename include guard.
12853         * nat/glibc_thread_db.h: Rename include guard.
12854         * nat/gdb_thread_db.h: Rename include guard.
12855         * nat/gdb_ptrace.h: Rename include guard.
12856         * nat/fork-inferior.h: Rename include guard.
12857         * nat/amd64-linux-siginfo.h: Rename include guard.
12858         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12859         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12860         * nat/aarch64-linux.h: Rename include guard.
12861         * nat/aarch64-linux-hw-point.h: Rename include guard.
12862         * mn10300-tdep.h: Add include guard.
12863         * mips-linux-tdep.h: Add include guard.
12864         * mi/mi-parse.h: Rename include guard.
12865         * mi/mi-out.h: Rename include guard.
12866         * mi/mi-main.h: Rename include guard.
12867         * mi/mi-interp.h: Rename include guard.
12868         * mi/mi-getopt.h: Rename include guard.
12869         * mi/mi-console.h: Rename include guard.
12870         * mi/mi-common.h: Rename include guard.
12871         * mi/mi-cmds.h: Rename include guard.
12872         * mi/mi-cmd-break.h: Rename include guard.
12873         * m2-lang.h: Add include guard.
12874         * location.h: Rename include guard.
12875         * linux-record.h: Rename include guard.
12876         * linux-nat.h: Add include guard.
12877         * linux-fork.h: Add include guard.
12878         * i386-darwin-tdep.h: Rename include guard.
12879         * hppa-linux-offsets.h: Add include guard.
12880         * guile/guile.h: Rename include guard.
12881         * guile/guile-internal.h: Rename include guard.
12882         * gnu-nat.h: Rename include guard.
12883         * gdb-stabs.h: Rename include guard.
12884         * frv-tdep.h: Add include guard.
12885         * f-lang.h: Add include guard.
12886         * event-loop.h: Add include guard.
12887         * darwin-nat.h: Rename include guard.
12888         * cp-abi.h: Rename include guard.
12889         * config/sparc/nm-sol2.h: Rename include guard.
12890         * config/nm-nto.h: Rename include guard.
12891         * config/nm-linux.h: Add include guard.
12892         * config/i386/nm-i386gnu.h: Rename include guard.
12893         * config/djgpp/nl_types.h: Rename include guard.
12894         * config/djgpp/langinfo.h: Rename include guard.
12895         * compile/gcc-cp-plugin.h: Add include guard.
12896         * compile/gcc-c-plugin.h: Add include guard.
12897         * compile/compile.h: Rename include guard.
12898         * compile/compile-object-run.h: Rename include guard.
12899         * compile/compile-object-load.h: Rename include guard.
12900         * compile/compile-internal.h: Rename include guard.
12901         * compile/compile-cplus.h: Rename include guard.
12902         * compile/compile-c.h: Rename include guard.
12903         * common/xml-utils.h: Rename include guard.
12904         * common/x86-xstate.h: Rename include guard.
12905         * common/version.h: Rename include guard.
12906         * common/vec.h: Rename include guard.
12907         * common/tdesc.h: Rename include guard.
12908         * common/selftest.h: Rename include guard.
12909         * common/scoped_restore.h: Rename include guard.
12910         * common/scoped_mmap.h: Rename include guard.
12911         * common/scoped_fd.h: Rename include guard.
12912         * common/safe-iterator.h: Rename include guard.
12913         * common/run-time-clock.h: Rename include guard.
12914         * common/refcounted-object.h: Rename include guard.
12915         * common/queue.h: Rename include guard.
12916         * common/ptid.h: Rename include guard.
12917         * common/print-utils.h: Rename include guard.
12918         * common/preprocessor.h: Rename include guard.
12919         * common/pathstuff.h: Rename include guard.
12920         * common/observable.h: Rename include guard.
12921         * common/netstuff.h: Rename include guard.
12922         * common/job-control.h: Rename include guard.
12923         * common/host-defs.h: Rename include guard.
12924         * common/gdb_wait.h: Rename include guard.
12925         * common/gdb_vecs.h: Rename include guard.
12926         * common/gdb_unlinker.h: Rename include guard.
12927         * common/gdb_unique_ptr.h: Rename include guard.
12928         * common/gdb_tilde_expand.h: Rename include guard.
12929         * common/gdb_sys_time.h: Rename include guard.
12930         * common/gdb_string_view.h: Rename include guard.
12931         * common/gdb_splay_tree.h: Rename include guard.
12932         * common/gdb_setjmp.h: Rename include guard.
12933         * common/gdb_ref_ptr.h: Rename include guard.
12934         * common/gdb_optional.h: Rename include guard.
12935         * common/gdb_locale.h: Rename include guard.
12936         * common/gdb_assert.h: Rename include guard.
12937         * common/filtered-iterator.h: Rename include guard.
12938         * common/filestuff.h: Rename include guard.
12939         * common/fileio.h: Rename include guard.
12940         * common/environ.h: Rename include guard.
12941         * common/common-utils.h: Rename include guard.
12942         * common/common-types.h: Rename include guard.
12943         * common/common-regcache.h: Rename include guard.
12944         * common/common-inferior.h: Rename include guard.
12945         * common/common-gdbthread.h: Rename include guard.
12946         * common/common-exceptions.h: Rename include guard.
12947         * common/common-defs.h: Rename include guard.
12948         * common/common-debug.h: Rename include guard.
12949         * common/cleanups.h: Rename include guard.
12950         * common/buffer.h: Rename include guard.
12951         * common/btrace-common.h: Rename include guard.
12952         * common/break-common.h: Rename include guard.
12953         * cli/cli-utils.h: Rename include guard.
12954         * cli/cli-style.h: Rename include guard.
12955         * cli/cli-setshow.h: Rename include guard.
12956         * cli/cli-script.h: Rename include guard.
12957         * cli/cli-interp.h: Rename include guard.
12958         * cli/cli-decode.h: Rename include guard.
12959         * cli/cli-cmds.h: Rename include guard.
12960         * charset-list.h: Add include guard.
12961         * buildsym-legacy.h: Rename include guard.
12962         * bfin-tdep.h: Add include guard.
12963         * ax.h: Rename include guard.
12964         * arm-linux-tdep.h: Add include guard.
12965         * arm-fbsd-tdep.h: Add include guard.
12966         * arch/xtensa.h: Rename include guard.
12967         * arch/tic6x.h: Add include guard.
12968         * arch/i386.h: Add include guard.
12969         * arch/arm.h: Rename include guard.
12970         * arch/arm-linux.h: Rename include guard.
12971         * arch/arm-get-next-pcs.h: Rename include guard.
12972         * arch/amd64.h: Add include guard.
12973         * arch/aarch64-insn.h: Rename include guard.
12974         * arch-utils.h: Rename include guard.
12975         * annotate.h: Add include guard.
12976         * amd64-darwin-tdep.h: Rename include guard.
12977         * aarch64-linux-tdep.h: Add include guard.
12978         * aarch64-fbsd-tdep.h: Add include guard.
12979         * aarch32-linux-nat.h: Add include guard.
12980
12981 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12982
12983         * macrotab.c (macro_define_internal): New function that
12984         factorizes macro_define_object_internal and macro_define_function
12985         code.
12986         (macro_define_object_internal): Use macro_define_internal.
12987         (macro_define_function): Likewise.
12988
12989 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12990
12991         * macrocmd.c (extract_identifier): Return
12992         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12993         callers.
12994
12995 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12996
12997         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12998
12999 2019-02-05  Tom Tromey  <tom@tromey.com>
13000
13001         * target.c (target_stack::unpush): Move assertion earlier.
13002
13003 2019-01-30  Tom Tromey  <tom@tromey.com>
13004
13005         PR python/23615:
13006         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13007         (gdbpy_parse_and_eval): Likewise.
13008         * python/python-internal.h (gdbpy_allow_threads): New class.
13009
13010 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
13011
13012         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13013         (aarch64_fbsd_fpregmap): Move earlier.
13014         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13015         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13016         instead of individual calls to trad_frame_set_reg_addr.
13017         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13018         earlier.
13019         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13020         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13021         instead of individual calls to trad_frame_set_reg_addr.
13022
13023 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
13024
13025         * CONTRIBUTE: Replace contribution list with wiki link.
13026
13027 2019-01-25  Tom Tromey  <tom@tromey.com>
13028
13029         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13030
13031 2019-01-25  Tom Tromey  <tom@tromey.com>
13032
13033         * xtensa-linux-nat.c: Fix common/ includes.
13034         * xml-support.h: Fix common/ includes.
13035         * xml-support.c: Fix common/ includes.
13036         * x86-linux-nat.c: Fix common/ includes.
13037         * windows-nat.c: Fix common/ includes.
13038         * varobj.h: Fix common/ includes.
13039         * varobj.c: Fix common/ includes.
13040         * value.c: Fix common/ includes.
13041         * valops.c: Fix common/ includes.
13042         * utils.c: Fix common/ includes.
13043         * unittests/xml-utils-selftests.c: Fix common/ includes.
13044         * unittests/utils-selftests.c: Fix common/ includes.
13045         * unittests/unpack-selftests.c: Fix common/ includes.
13046         * unittests/tracepoint-selftests.c: Fix common/ includes.
13047         * unittests/style-selftests.c: Fix common/ includes.
13048         * unittests/string_view-selftests.c: Fix common/ includes.
13049         * unittests/scoped_restore-selftests.c: Fix common/ includes.
13050         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13051         * unittests/scoped_fd-selftests.c: Fix common/ includes.
13052         * unittests/rsp-low-selftests.c: Fix common/ includes.
13053         * unittests/parse-connection-spec-selftests.c: Fix common/
13054         includes.
13055         * unittests/optional-selftests.c: Fix common/ includes.
13056         * unittests/offset-type-selftests.c: Fix common/ includes.
13057         * unittests/observable-selftests.c: Fix common/ includes.
13058         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13059         * unittests/memrange-selftests.c: Fix common/ includes.
13060         * unittests/memory-map-selftests.c: Fix common/ includes.
13061         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13062         * unittests/function-view-selftests.c: Fix common/ includes.
13063         * unittests/environ-selftests.c: Fix common/ includes.
13064         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13065         * unittests/common-utils-selftests.c: Fix common/ includes.
13066         * unittests/cli-utils-selftests.c: Fix common/ includes.
13067         * unittests/array-view-selftests.c: Fix common/ includes.
13068         * ui-file.c: Fix common/ includes.
13069         * tui/tui-io.c: Fix common/ includes.
13070         * tracepoint.h: Fix common/ includes.
13071         * tracepoint.c: Fix common/ includes.
13072         * tracefile-tfile.c: Fix common/ includes.
13073         * top.h: Fix common/ includes.
13074         * top.c: Fix common/ includes.
13075         * thread.c: Fix common/ includes.
13076         * target/waitstatus.h: Fix common/ includes.
13077         * target/waitstatus.c: Fix common/ includes.
13078         * target.h: Fix common/ includes.
13079         * target.c: Fix common/ includes.
13080         * target-memory.c: Fix common/ includes.
13081         * target-descriptions.c: Fix common/ includes.
13082         * symtab.h: Fix common/ includes.
13083         * symfile.c: Fix common/ includes.
13084         * stap-probe.c: Fix common/ includes.
13085         * spu-linux-nat.c: Fix common/ includes.
13086         * sparc-nat.c: Fix common/ includes.
13087         * source.c: Fix common/ includes.
13088         * solib.c: Fix common/ includes.
13089         * solib-target.c: Fix common/ includes.
13090         * ser-unix.c: Fix common/ includes.
13091         * ser-tcp.c: Fix common/ includes.
13092         * ser-pipe.c: Fix common/ includes.
13093         * ser-base.c: Fix common/ includes.
13094         * selftest-arch.c: Fix common/ includes.
13095         * s12z-tdep.c: Fix common/ includes.
13096         * rust-exp.y: Fix common/ includes.
13097         * rs6000-aix-tdep.c: Fix common/ includes.
13098         * riscv-tdep.c: Fix common/ includes.
13099         * remote.c: Fix common/ includes.
13100         * remote-notif.h: Fix common/ includes.
13101         * remote-fileio.h: Fix common/ includes.
13102         * remote-fileio.c: Fix common/ includes.
13103         * regcache.h: Fix common/ includes.
13104         * regcache.c: Fix common/ includes.
13105         * record-btrace.c: Fix common/ includes.
13106         * python/python.c: Fix common/ includes.
13107         * python/py-type.c: Fix common/ includes.
13108         * python/py-inferior.c: Fix common/ includes.
13109         * progspace.h: Fix common/ includes.
13110         * producer.c: Fix common/ includes.
13111         * procfs.c: Fix common/ includes.
13112         * proc-api.c: Fix common/ includes.
13113         * printcmd.c: Fix common/ includes.
13114         * ppc-linux-nat.c: Fix common/ includes.
13115         * parser-defs.h: Fix common/ includes.
13116         * osdata.c: Fix common/ includes.
13117         * obsd-nat.c: Fix common/ includes.
13118         * nat/x86-linux.c: Fix common/ includes.
13119         * nat/x86-linux-dregs.c: Fix common/ includes.
13120         * nat/x86-dregs.h: Fix common/ includes.
13121         * nat/x86-dregs.c: Fix common/ includes.
13122         * nat/ppc-linux.c: Fix common/ includes.
13123         * nat/mips-linux-watch.h: Fix common/ includes.
13124         * nat/mips-linux-watch.c: Fix common/ includes.
13125         * nat/linux-waitpid.c: Fix common/ includes.
13126         * nat/linux-ptrace.h: Fix common/ includes.
13127         * nat/linux-ptrace.c: Fix common/ includes.
13128         * nat/linux-procfs.c: Fix common/ includes.
13129         * nat/linux-personality.c: Fix common/ includes.
13130         * nat/linux-osdata.c: Fix common/ includes.
13131         * nat/linux-namespaces.c: Fix common/ includes.
13132         * nat/linux-btrace.h: Fix common/ includes.
13133         * nat/linux-btrace.c: Fix common/ includes.
13134         * nat/fork-inferior.c: Fix common/ includes.
13135         * nat/amd64-linux-siginfo.c: Fix common/ includes.
13136         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13137         * nat/aarch64-linux.c: Fix common/ includes.
13138         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13139         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13140         * namespace.h: Fix common/ includes.
13141         * mips-linux-tdep.c: Fix common/ includes.
13142         * minsyms.c: Fix common/ includes.
13143         * mi/mi-parse.h: Fix common/ includes.
13144         * mi/mi-main.c: Fix common/ includes.
13145         * mi/mi-cmd-env.c: Fix common/ includes.
13146         * memrange.h: Fix common/ includes.
13147         * memattr.c: Fix common/ includes.
13148         * maint.h: Fix common/ includes.
13149         * maint.c: Fix common/ includes.
13150         * main.c: Fix common/ includes.
13151         * machoread.c: Fix common/ includes.
13152         * location.c: Fix common/ includes.
13153         * linux-thread-db.c: Fix common/ includes.
13154         * linux-nat.c: Fix common/ includes.
13155         * linux-fork.c: Fix common/ includes.
13156         * inline-frame.c: Fix common/ includes.
13157         * infrun.c: Fix common/ includes.
13158         * inflow.c: Fix common/ includes.
13159         * inferior.h: Fix common/ includes.
13160         * inferior.c: Fix common/ includes.
13161         * infcmd.c: Fix common/ includes.
13162         * inf-ptrace.c: Fix common/ includes.
13163         * inf-child.c: Fix common/ includes.
13164         * ia64-linux-nat.c: Fix common/ includes.
13165         * i387-tdep.c: Fix common/ includes.
13166         * i386-tdep.c: Fix common/ includes.
13167         * i386-linux-tdep.c: Fix common/ includes.
13168         * i386-linux-nat.c: Fix common/ includes.
13169         * i386-go32-tdep.c: Fix common/ includes.
13170         * i386-fbsd-tdep.c: Fix common/ includes.
13171         * i386-fbsd-nat.c: Fix common/ includes.
13172         * guile/scm-type.c: Fix common/ includes.
13173         * guile/guile.c: Fix common/ includes.
13174         * go32-nat.c: Fix common/ includes.
13175         * gnu-nat.c: Fix common/ includes.
13176         * gdbthread.h: Fix common/ includes.
13177         * gdbarch-selftests.c: Fix common/ includes.
13178         * gdb_usleep.c: Fix common/ includes.
13179         * gdb_select.h: Fix common/ includes.
13180         * gdb_bfd.c: Fix common/ includes.
13181         * gcore.c: Fix common/ includes.
13182         * fork-child.c: Fix common/ includes.
13183         * findvar.c: Fix common/ includes.
13184         * fbsd-nat.c: Fix common/ includes.
13185         * event-top.c: Fix common/ includes.
13186         * event-loop.c: Fix common/ includes.
13187         * dwarf2read.c: Fix common/ includes.
13188         * dwarf2loc.c: Fix common/ includes.
13189         * dwarf2-frame.c: Fix common/ includes.
13190         * dwarf-index-cache.c: Fix common/ includes.
13191         * dtrace-probe.c: Fix common/ includes.
13192         * disasm-selftests.c: Fix common/ includes.
13193         * defs.h: Fix common/ includes.
13194         * csky-tdep.c: Fix common/ includes.
13195         * cp-valprint.c: Fix common/ includes.
13196         * cp-support.h: Fix common/ includes.
13197         * cp-support.c: Fix common/ includes.
13198         * corelow.c: Fix common/ includes.
13199         * completer.h: Fix common/ includes.
13200         * completer.c: Fix common/ includes.
13201         * compile/compile.c: Fix common/ includes.
13202         * compile/compile-loc2c.c: Fix common/ includes.
13203         * compile/compile-cplus-types.c: Fix common/ includes.
13204         * compile/compile-cplus-symbols.c: Fix common/ includes.
13205         * command.h: Fix common/ includes.
13206         * cli/cli-dump.c: Fix common/ includes.
13207         * cli/cli-cmds.c: Fix common/ includes.
13208         * charset.c: Fix common/ includes.
13209         * build-id.c: Fix common/ includes.
13210         * btrace.h: Fix common/ includes.
13211         * btrace.c: Fix common/ includes.
13212         * breakpoint.h: Fix common/ includes.
13213         * breakpoint.c: Fix common/ includes.
13214         * ax.h:
13215         (enum agent_op): Fix common/ includes.
13216         * ax-general.c (struct aop_map): Fix common/ includes.
13217         * ax-gdb.c: Fix common/ includes.
13218         * auxv.c: Fix common/ includes.
13219         * auto-load.c: Fix common/ includes.
13220         * arm-tdep.c: Fix common/ includes.
13221         * arch/riscv.c: Fix common/ includes.
13222         * arch/ppc-linux-common.c: Fix common/ includes.
13223         * arch/i386.c: Fix common/ includes.
13224         * arch/arm.c: Fix common/ includes.
13225         * arch/arm-linux.c: Fix common/ includes.
13226         * arch/arm-get-next-pcs.c: Fix common/ includes.
13227         * arch/amd64.c: Fix common/ includes.
13228         * arch/aarch64.c: Fix common/ includes.
13229         * arch/aarch64-insn.c: Fix common/ includes.
13230         * arch-utils.c: Fix common/ includes.
13231         * amd64-windows-tdep.c: Fix common/ includes.
13232         * amd64-tdep.c: Fix common/ includes.
13233         * amd64-sol2-tdep.c: Fix common/ includes.
13234         * amd64-obsd-tdep.c: Fix common/ includes.
13235         * amd64-nbsd-tdep.c: Fix common/ includes.
13236         * amd64-linux-tdep.c: Fix common/ includes.
13237         * amd64-linux-nat.c: Fix common/ includes.
13238         * amd64-fbsd-tdep.c: Fix common/ includes.
13239         * amd64-fbsd-nat.c: Fix common/ includes.
13240         * amd64-dicos-tdep.c: Fix common/ includes.
13241         * amd64-darwin-tdep.c: Fix common/ includes.
13242         * agent.c: Fix common/ includes.
13243         * ada-lang.h: Fix common/ includes.
13244         * ada-lang.c: Fix common/ includes.
13245         * aarch64-tdep.c: Fix common/ includes.
13246
13247 2019-01-25  Tom Tromey  <tom@tromey.com>
13248
13249         * common/create-version.sh: Use common/version.h.
13250
13251 2019-01-24  Pedro Alves  <palves@redhat.com>
13252
13253         * infrun.c (signal_stop, signal_print, signal_program)
13254         (signal_catch, signal_pass): Now arrays instead of pointers.
13255         (update_signals_program_target, do_target_resume)
13256         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
13257         * linux-nat.c (linux_nat_target::pass_signals)
13258         (linux_nat_target::create_inferior, linux_nat_target::attach):
13259         Adjust.
13260         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
13261         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
13262         * procfs.c (procfs_target::pass_signals): Adjust.
13263         * record-full.c (record_full_target::resume): Adjust.
13264         * remote.c (remote_target::pass_signals)
13265         (remote_target::program_signals): Adjust.
13266         * target-debug.h (target_debug_print_signals): Now takes a
13267         gdb::array_view as parameter.  Adjust.
13268         * target.h (target_ops) <pass_signals, program_signals>: Replace
13269         pointer and length parameters with gdb::array_view.
13270         (target_pass_signals, target_program_signals): Likewise.
13271         * target-delegates.c: Regenerate.
13272
13273 2019-01-24  Pedro Alves  <palves@redhat.com>
13274
13275         * common/forward-scope-exit.h
13276         (forward_scope_exit::forward_scope_exit): Pass arguments to
13277         m_bind_function directly, instead of creating a std::bind and
13278         copying that.
13279
13280 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
13281
13282         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13283         for static members.
13284         (pass_in_v_vfp_candidate): Likewise.
13285
13286 2019-01-23  Tom Tromey  <tom@tromey.com>
13287             Pedro Alves  <palves@redhat.com>
13288
13289         * regcache.c (class regcache_invalidator): Remove.
13290         (regcache::raw_write): Use make_scope_exit.
13291
13292 2019-01-23  Tom Tromey  <tom@tromey.com>
13293
13294         * ui-out.h (class ui_out_emit_type): Update comment.
13295
13296 2019-01-23  Tom Tromey  <tom@tromey.com>
13297
13298         * infrun.c (fetch_inferior_event): Update comment.
13299
13300 2019-01-23  Tom Tromey  <tom@tromey.com>
13301             Pedro Alves  <palves@redhat.com>
13302
13303         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13304         parameter.
13305         (fetch_inferior_event): Use SCOPE_EXIT.
13306
13307
13308 2019-01-23  Tom Tromey  <tom@tromey.com>
13309             Pedro Alves  <palves@redhat.com>
13310
13311         * infrun.c (disable_thread_events): Delete.
13312         (stop_all_threads): Use SCOPE_EXIT.
13313
13314 2019-01-23  Tom Tromey  <tom@tromey.com>
13315             Pedro Alves  <palves@redhat.com>
13316
13317         * symfile.c: Include forward-scope-exit.h.
13318         (clear_symtab_users_cleanup): Replace forward declaration with
13319         a FORWARD_SCOPE_EXIT.
13320         (syms_from_objfile_1): Use the forward_scope_exit and
13321         gdb::optional instead of cleanup_function.
13322         (reread_symbols): Use the forward_scope_exit instead of
13323         cleanup_function.
13324         (clear_symtab_users_cleanup): Remove function.
13325
13326 2019-01-23  Tom Tromey  <tom@tromey.com>
13327             Pedro Alves  <palves@redhat.com>
13328
13329         * linux-nat.c: Include scope-exit.h.
13330         (cleanup_target_stop): Remove.
13331         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13332         SCOPE_EXIT.
13333
13334 2019-01-23  Tom Tromey  <tom@tromey.com>
13335             Pedro Alves  <palves@redhat.com>
13336
13337         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13338         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13339
13340 2019-01-23  Tom Tromey  <tom@tromey.com>
13341             Andrew Burgess  <andrew.burgess@embecosm.com>
13342             Pedro Alves  <palves@redhat.com>
13343
13344         * infrun.c (fetch_inferior_event): Use scope_exit.
13345         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13346         * top.c (execute_command): Use scope_exit.
13347         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13348         * utils.c (do_bpstat_clear_actions_cleanup)
13349         (make_bpstat_clear_actions_cleanup): Remove.
13350
13351 2019-01-23  Tom Tromey  <tom@tromey.com>
13352             Pedro Alves  <palves@redhat.com>
13353
13354         * infrun.c: Include "common/scope-exit.h"
13355         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13356         (wait_for_inferior): Use SCOPE_EXIT.
13357         (fetch_inferior_event): Use scope_exit.
13358
13359 2019-01-23  Tom Tromey  <tom@tromey.com>
13360             Pedro Alves  <palves@redhat.com>
13361
13362         * breakpoint.c (create_breakpoint): Remove cleanup.
13363
13364 2019-01-23  Tom Tromey  <tom@tromey.com>
13365             Andrew Burgess  <andrew.burgess@embecosm.com>
13366             Pedro Alves  <palves@redhat.com>
13367
13368 2019-01-23  Pedro Alves  <palves@redhat.com>
13369
13370         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13371
13372 2019-01-23  Pedro Alves  <palves@redhat.com>
13373             Andrew Burgess  <andrew.burgess@embecosm.com>
13374
13375         * gdbthread.h: Include "common/forward-scope-exit.h".
13376         (scoped_finish_thread_state): Redefine custom class in terms of
13377         forward_scope_exit.
13378
13379 2019-01-23  Pedro Alves  <palves@redhat.com>
13380             Andrew Burgess  <andrew.burgess@embecosm.com>
13381
13382         * common/forward-scope-exit.h: New file.
13383
13384 2019-01-23  Pedro Alves  <palves@redhat.com>
13385             Andrew Burgess  <andrew.burgess@embecosm.com>
13386             Tom Tromey  <tom@tromey.com>
13387
13388         * common/scope-exit.h: New file.
13389
13390 2019-01-23  Pedro Alves  <palves@redhat.com>
13391
13392         * common/preprocessor.h (ESC): Rename to ...
13393         (ESC_PARENS): ... this.
13394         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13395         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13396
13397 2019-01-23  Tom Tromey  <tom@tromey.com>
13398
13399         * language.h (class scoped_switch_to_sym_language_if_auto):
13400         Initialize m_lang in both cases.
13401
13402 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13403
13404         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13405         with XCNEW.
13406
13407 2019-01-22  Tom Tromey  <tom@tromey.com>
13408
13409         * corelow.c: Do not include sys/file.h.
13410
13411 2019-01-22  Tom Tromey  <tom@tromey.com>
13412
13413         * tui/tui-wingeneral.h: Include gdb_curses.h.
13414
13415 2019-01-22  Tom Tromey  <tom@tromey.com>
13416
13417         * source-cache.h (class source_cache) <get_source_lines,
13418         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13419
13420 2019-01-22  Tom Tromey  <tom@tromey.com>
13421
13422         * remote-fileio.h (struct remote_target): Declare.
13423
13424 2019-01-22  Tom Tromey  <tom@tromey.com>
13425
13426         * python/py-arch.c: Do not include py-ref.h.
13427         * python/py-bpevent.c: Do not include py-ref.h.
13428         * python/py-cmd.c: Do not include py-ref.h.
13429         * python/py-continueevent.c: Do not include py-ref.h.
13430         * python/py-event.h: Do not include py-ref.h.
13431         * python/py-evtregistry.c: Do not include py-ref.h.
13432         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13433         * python/py-frame.c: Do not include py-ref.h.
13434         * python/py-framefilter.c: Do not include py-ref.h.
13435         * python/py-function.c: Do not include py-ref.h.
13436         * python/py-infevents.c: Do not include py-ref.h.
13437         * python/py-linetable.c: Do not include py-ref.h.
13438         * python/py-objfile.c: Do not include py-ref.h.
13439         * python/py-param.c: Do not include py-ref.h.
13440         * python/py-prettyprint.c: Do not include py-ref.h.
13441         * python/py-progspace.c: Do not include py-ref.h.
13442         * python/py-symbol.c: Do not include py-ref.h.
13443         * python/py-symtab.c: Do not include py-ref.h.
13444         * python/py-type.c: Do not include py-ref.h.
13445         * python/py-unwind.c: Do not include py-ref.h.
13446         * python/py-utils.c: Do not include py-ref.h.
13447         * python/py-value.c: Do not include py-ref.h.
13448         * python/py-varobj.c: Do not include py-ref.h.
13449         * python/py-xmethods.c: Do not include py-ref.h.
13450         * python/python.c: Do not include py-ref.h.
13451         * varobj.c: Do not include py-ref.h.
13452
13453 2019-01-22  Tom Tromey  <tom@tromey.com>
13454
13455         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13456         keyword for bcache.
13457
13458 2019-01-22  Tom Tromey  <tom@tromey.com>
13459
13460         * compile/compile-cplus-types.c: Remove a comment by #include.
13461
13462 2019-01-22  Tom Tromey  <tom@tromey.com>
13463
13464         * compile/gcc-c-plugin.h: Include compile-internal.h.
13465
13466 2019-01-22  Tom Tromey  <tom@tromey.com>
13467
13468         * stabsread.c (EXTERN): Do not define.
13469         (symnum, next_symbol_text_func, processing_gcc_compilation)
13470         (within_function, global_sym_chain, global_stabs)
13471         (previous_stab_code, this_object_header_files)
13472         (n_this_object_header_files)
13473         (n_allocated_this_object_header_files): Define.
13474         * stabsread.h (EXTERN): Never define.  Use "extern".
13475
13476 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13477
13478         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13479         history_value.
13480
13481 2019-01-21  Tom Tromey  <tom@tromey.com>
13482
13483         * ui-out.c: Fix includes.
13484         * tui/tui-source.c: Fix includes.
13485         * target.c: Fix includes.
13486         * remote.c: Fix includes.
13487         * regcache.c: Fix includes.
13488         * python/py-block.c: Fix includes.
13489         * printcmd.c: Fix includes.
13490         * or1k-tdep.c: Fix includes.
13491         * mi/mi-main.c: Fix includes.
13492         * m32r-tdep.c: Fix includes.
13493         * csky-tdep.c: Fix includes.
13494         * compile/compile-cplus-types.c: Fix includes.
13495         * cli/cli-interp.c: Fix includes.
13496
13497 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13498
13499         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13500         for padding.
13501
13502 2019-01-16  Tom Tromey  <tom@tromey.com>
13503
13504         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13505         earlier.
13506         (struct objfile) <msymbols_range>: Move from top level.
13507         <msymbols>: New method.
13508         (class objfile_msymbols): Remove.
13509         * symtab.c (default_collect_symbol_completion_matches_break_on):
13510         Update.
13511         * symmisc.c (dump_msymbols): Update.
13512         * stabsread.c (scan_file_globals): Update.
13513         * objc-lang.c (info_selectors_command, info_classes_command)
13514         (find_methods): Update.
13515         * minsyms.c (find_solib_trampoline_target): Update.
13516         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13517         * coffread.c (coff_symfile_read): Update.
13518         * ada-lang.c (ada_lookup_simple_minsym)
13519         (ada_collect_symbol_completion_matches): Update.
13520
13521 2019-01-16  Tom Tromey  <tom@tromey.com>
13522
13523         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13524         type.  Remove no-argument constructor.
13525         <iterator::operator++>: Simplify.
13526         <begin>: Update.
13527         <end>: Use minimal_symbol_count.
13528
13529 2019-01-16  Tom Tromey  <tom@tromey.com>
13530
13531         * objfiles.h (struct objfile) <psymtabs>: New method.
13532         (class objfile_psymtabs): Remove.
13533         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13534         typedef.
13535         <range>: New method.
13536         (require_partial_symbols): Change return type.
13537         * psymtab.c (require_partial_symbols)
13538         (psym_expand_symtabs_matching): Update.
13539         * mdebugread.c (parse_partial_symbols): Update.
13540         * dbxread.c (dbx_end_psymtab): Update.
13541
13542 2019-01-15  Tom Tromey  <tom@tromey.com>
13543
13544         * symtab.c (lookup_objfile_from_block)
13545         (lookup_symbol_in_objfile_symtabs)
13546         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13547         (find_line_symtab, info_sources_command)
13548         (default_collect_symbol_completion_matches_break_on)
13549         (make_source_files_completion_list): Update.
13550         * symmisc.c (print_objfile_statistics, dump_objfile)
13551         (maintenance_print_symbols, maintenance_info_symtabs)
13552         (maintenance_check_symtabs, maintenance_info_line_tables):
13553         Update.
13554         * source.c (select_source_symtab)
13555         (forget_cached_source_info_for_objfile): Update.
13556         * objfiles.h (class objfile_compunits): Remove.
13557         (struct objfile) <compunits_range>: New typedef.
13558         (compunits): New method.
13559         * objfiles.c (objfile_relocate1): Update.
13560         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13561         * maint.c (count_symtabs_and_blocks): Update.
13562         * linespec.c (iterate_over_all_matching_symtabs): Update.
13563         * cp-support.c (add_symbol_overload_list_qualified): Update.
13564         * coffread.c (coff_symtab_read): Update.
13565         * ada-lang.c (add_nonlocal_symbols)
13566         (ada_collect_symbol_completion_matches)
13567         (ada_add_global_exceptions): Update.
13568
13569 2019-01-15  Tom Tromey  <tom@tromey.com>
13570
13571         * progspace.h (program_space) <objfiles_safe_range>: New
13572         typedef.
13573         <objfiles_safe>: New method.
13574         * objfiles.h (class all_objfiles_safe): Remove.
13575         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13576         * jit.c (jit_inferior_exit_hook): Update.
13577
13578 2019-01-17  Tom Tromey  <tom@tromey.com>
13579
13580         * progspace.h (program_space) <objfiles_range>: New typedef.
13581         <objfiles>: New method.
13582         <objfiles_head>: Rename from objfiles.
13583         (object_files): Update.
13584         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13585         * guile/scm-pretty-print.c
13586         (ppscm_find_pretty_printer_from_objfiles): Update.
13587         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13588         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13589         Update.
13590         * python/py-progspace.c (pspy_get_objfiles): Update.
13591         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13592         Update.
13593         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13594         (objfpy_lookup_objfile_by_build_id): Update.
13595         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13596         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13597         Update.
13598         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13599         (expand_symtab_containing_pc, lookup_objfile_from_block)
13600         (lookup_static_symbol, basic_lookup_transparent_type)
13601         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13602         (find_line_symtab, info_sources_command)
13603         (default_collect_symbol_completion_matches_break_on)
13604         (make_source_files_completion_list, find_main_name): Update.
13605         * symmisc.c (print_symbol_bcache_statistics)
13606         (print_objfile_statistics, maintenance_print_symbols)
13607         (maintenance_print_msymbols, maintenance_print_objfiles)
13608         (maintenance_info_symtabs, maintenance_check_symtabs)
13609         (maintenance_expand_symtabs, maintenance_info_line_tables):
13610         Update.
13611         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13612         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13613         (map_overlay_command, unmap_overlay_command)
13614         (simple_overlay_update, expand_symtabs_matching)
13615         (map_symbol_filenames): Update.
13616         * symfile-debug.c (set_debug_symfile): Update.
13617         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13618         Update.
13619         * source.c (select_source_symtab, forget_cached_source_info):
13620         Update.
13621         * solib.c (solib_read_symbols): Update.
13622         * solib-spu.c (append_ocl_sos): Update.
13623         * psymtab.c (maintenance_print_psymbols)
13624         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13625         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13626         * printcmd.c (info_symbol_command): Update.
13627         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13628         Update.
13629         * objfiles.h (class all_objfiles): Remove.
13630         * objfiles.c (have_partial_symbols, have_full_symbols)
13631         (have_minimal_symbols, qsort_cmp, update_section_map)
13632         (shared_objfile_contains_address_p)
13633         (default_iterate_over_objfiles_in_search_order): Update.
13634         * objc-lang.c (info_selectors_command, info_classes_command)
13635         (find_methods): Update.
13636         * minsyms.c (find_solib_trampoline_target): Update.
13637         * maint.c (maintenance_info_sections)
13638         (maintenance_translate_address, count_symtabs_and_blocks):
13639         Update.
13640         * main.c (captured_main_1): Update.
13641         * linux-thread-db.c (try_thread_db_load_from_pdir)
13642         (has_libpthread): Update.
13643         * linespec.c (iterate_over_all_matching_symtabs)
13644         (search_minsyms_for_name): Update.
13645         * jit.c (jit_find_objf_with_entry_addr): Update.
13646         * hppa-tdep.c (find_unwind_entry)
13647         (hppa_lookup_stub_minimal_symbol): Update.
13648         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13649         Update.
13650         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13651         (elf_gnu_ifunc_resolve_by_got): Update.
13652         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13653         * dwarf-index-write.c (save_gdb_index_command): Update.
13654         * cp-support.c (add_symbol_overload_list_qualified): Update.
13655         * breakpoint.c (create_overlay_event_breakpoint)
13656         (create_longjmp_master_breakpoint)
13657         (create_std_terminate_master_breakpoint)
13658         (create_exception_master_breakpoint): Update.
13659         * blockframe.c (find_pc_partial_function): Update.
13660         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13661         (ada_collect_symbol_completion_matches)
13662         (ada_add_global_exceptions): Update.
13663
13664 2019-01-17  Tom Tromey  <tom@tromey.com>
13665
13666         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13667         declare VEC.
13668         (solib_target_parse_libraries): Change return type.
13669         (library_list_start_segment, library_list_start_section)
13670         (library_list_end_library, library_list_start_library); Update.
13671         (solib_target_free_library_list): Remove.
13672         (solib_target_parse_libraries): Remove cleanup.  Change return
13673         type.
13674         (solib_target_current_sos): Update.
13675
13676 2019-01-17  Tom Tromey  <tromey@bapiya>
13677
13678         * valprint.c: Replace "the the" with "the".
13679         * symtab.c: Replace "the the" with "the".
13680         * solib.c: Replace "the the" with "the".
13681         * solib-dsbt.c: Replace "the the" with "the".
13682         * linespec.c: Replace "the the" with "the".
13683         * dwarf2loc.h: Replace "the the" with "the".
13684         * amd64-windows-tdep.c: Replace "the the" with "the".
13685         * aarch64-tdep.c: Replace "the the" with "the".
13686
13687 2019-01-16  Keith Seitz  <keiths@redhat.com>
13688
13689         PR gdb/23773
13690         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13691         <builder>: Rename to ..
13692         <m_builder>: ... this and make private.
13693         (dwarf2_cu::get_builder): New method.  Change all users of
13694         `builder' to use this method.
13695         (dwarf2_start_symtab): Move to ...
13696         (dwarf2_cu::start_symtab): ... here.  Update all callers
13697         (setup_type_unit_groups): Move to ...
13698         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13699         callers.
13700         (dwarf2_cu::reset_builder): New method.
13701         (process_full_compunit, process_full_type_unit): Use
13702         dwarf2_cu::reset_builder.
13703         (follow_die_offset): Record the ancestor CU if it is different
13704         from the followed DIE's CU.
13705         (follow_die_sig_1): Likewise.
13706
13707 2019-01-15  Tom Tromey  <tom@tromey.com>
13708
13709         * remote.c (class remote_state) <buf>: Now a char_vector.
13710         <buf_size>: Remove.
13711         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13712         parameter.
13713         (remote_target::getpkt_or_notif_sane_1)
13714         (remote_target::getpkt_sane)
13715         (remote_target::getpkt_or_notif_sane): Likewise.
13716         (class remote_target) <putpkt>: New overload.
13717         (remote_target::read_frame): Change type of "buf_p".  Remove
13718         sizeof_p parameter.
13719         (packet_ok): New overload.
13720         (packet_check_result): New overload.
13721         Update all uses.
13722
13723 2019-01-14  Tom Tromey  <tom@tromey.com>
13724
13725         * remote-notif.c (handle_notification, remote_notif_ack)
13726         (remote_notif_parse): Make "buf" const.
13727         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13728         const.
13729         (remote_notif_parse, remote_notif_ack, handle_notification):
13730         Likewise.
13731         * remote.c (remote_notif_stop_parse): Make "buf" const.
13732         (remote_target::remote_parse_stop_reply): Make "buf" const.
13733         (remote_notif_stop_ack): Make "buf" const.
13734
13735 2019-01-14  Tom Tromey  <tom@tromey.com>
13736
13737         * remote.c (remote_console_output): Make parameter const.
13738
13739 2019-01-14  Tom Tromey  <tom@tromey.com>
13740
13741         * target-debug.h (target_debug_print_signals): Constify.
13742         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13743         * procfs.c (procfs_target::pass_signals): Update.
13744         * linux-nat.c (linux_nat_target::pass_signals): Update.
13745         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13746         * target-delegates.c: Rebuild.
13747         * remote.c (remote_target::program_signals): Update.
13748         (remote_target::pass_signals): Update.
13749         * target.c (target_pass_signals): Constify argument.
13750         (target_program_signals): Likewise.
13751         * target.h (struct target_ops) <pass_signals, program_signals>:
13752         Constify argument.
13753         (target_pass_signals, target_program_signals): Constify argument.
13754
13755 2019-01-14  Tom Tromey  <tom@tromey.com>
13756
13757         PR tui/28819:
13758         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13759
13760 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13761
13762         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13763         field.
13764         * rs6000-tdep.c: Include reggroups.h.
13765         (IS_V_ALIAS_PSEUDOREG): Define.
13766         (rs6000_register_name): Return names for the "vX" aliases.
13767         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13768         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13769         aliases.  Call default_register_reggroup_p for all other
13770         pseudo-registers.
13771         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13772         New functions.
13773         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13774         Handle "vX" aliases.
13775         (v_alias_pseudo_register_collect): New function.
13776         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13777         (rs6000_gdbarch_init): Initialize "vX" aliases as
13778         pseudo-registers.  Restore registration of
13779         rs6000_pseudo_register_reggroup_p with
13780         set_tdesc_pseudo_register_reggroup_p.
13781
13782 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13783
13784         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13785         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13786         set_gdbarch_num_pseudo_regs.
13787
13788 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13789
13790         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13791         Remove arg prefixname, add do_set and do_show.
13792         Add member functions set_list and show_list.
13793         * cli/cli-style.c (class cli_style_option): Update accordingly.
13794         (style_set_list): Move to file scope.
13795         (style_show_list): Likewise.
13796         (set_style): Call help_list.
13797         (show_style): Call cmd_show_list.
13798         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13799         Update to use the new macro.
13800
13801 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13802
13803         * ada-lang.c (_initialize_ada_language): Expand the help text
13804         for the "catch exception" command.
13805
13806 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13807
13808         * symtab.c (matching_obj_sections): Initialize obj,
13809         declare it closer to its usage.
13810
13811 2019-01-10  Tom Tromey  <tom@tromey.com>
13812
13813         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13814         (basic_inf_threads_range): Remove.
13815         (inf_threads_range, inf_non_exited_threads_range)
13816         (safe_inf_threads_range): Use next_adapter.
13817
13818 2019-01-10  Keith Seitz  <keiths@redhat.com>
13819
13820         PR gdb/23712
13821         PR symtab/23010
13822         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13823         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13824
13825 2019-01-10  Keith Seitz  <keiths@redhat.com>
13826
13827         PR gdb/23712
13828         PR symtab/23010
13829         * dictionary.c (pending_to_vector): Remove.
13830         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13831         Remove _1 suffix, replacing functions of the same name.  Update
13832         all callers.
13833         (dict_create_hashed, dict_create_hashed_expandable)
13834         (dict_create_linear, dict_create_linear_expandable, dict_free)
13835         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13836         Make functions static.
13837
13838 2019-01-10  Keith Seitz  <keiths@redhat.com>
13839
13840         PR gdb/23712
13841         PR symtab/23010
13842         * dictionary.h (struct dictionary): Replace declaration with
13843         multidictionary.
13844         (dict_create_hashed, dict_create_hashed_expandable)
13845         (dict_create_linear, dict_create_linear_expandable)
13846         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13847         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13848         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13849         taking multidictionary argument.
13850         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13851         * block.h (struct block) <dict>: Change to multidictionary
13852         and rename `multidict'.
13853         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13854         symmisc.c: Update all dictionary references to multidictionary.
13855
13856 2019-01-10  Keith Seitz  <keiths@redhat.com>
13857
13858         PR gdb/23712
13859         PR symtab/23010
13860         * dictionary.c: Include unordered_map.
13861         (pending_to_vector): New function.
13862         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13863         Rewrite the non-"_1" functions to take vector instead
13864         of linked list.
13865         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13866         "new" _1 versions of the same name.
13867         (multidictionary): Define.
13868         (std::hash<enum language): New definition.
13869         (collate_pending_symbols_by_language, mdict_create_hashed)
13870         (mdict_create_hashed_expandable, mdict_create_linear)
13871         (mdict_create_linear_expandable, mdict_free)
13872         (find_language_dictionary, create_new_language_dictionary)
13873         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13874         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13875         (mdict_size, mdict_empty): New functions.
13876         * dictionary.h (mdict_iterator): Define.
13877
13878 2019-01-10  Pedro Alves  <palves@redhat.com>
13879
13880         * breakpoint.c (read_uploaded_action)
13881         (create_tracepoint_from_upload): Adjust to use
13882         gdb::unique_xmalloc_ptr.
13883         * ctf.c (ctf_write_uploaded_tp):
13884         (SET_ARRAY_FIELD): Use emplace_back.
13885         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13886         * tracefile-tfile.c (tfile_write_uploaded_tp):
13887         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13888         gdb::unique_xmalloc_ptr.
13889         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13890         at_string, cond_string, cmd_strings>: Replace char pointers
13891         with gdb::unique_xmalloc_ptr.
13892
13893 2019-01-10  Pedro Alves  <palves@redhat.com>
13894
13895         * solib-target.c (library_list_start_library): Don't xstrdup name.
13896
13897 2019-01-10  Pedro Alves  <palves@redhat.com>
13898
13899         * mdebugread.c (parse_partial_symbols): Use
13900         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13901
13902 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13903
13904         * linux-fork.c (scoped_switch_fork_info)
13905         <~scoped_switch_fork_info>: Fix incorrect variable name.
13906
13907 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13908
13909         * linux-fork.c (scoped_switch_fork_info)
13910         <scoped_switch_fork_info>: Make explicit.
13911         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13912
13913 2019-01-10  Tom Tromey  <tom@tromey.com>
13914
13915         * objfiles.h (objfile::reset_psymtabs): Update.
13916         * objfiles.c (objfile::objfile): Update.
13917         * psymtab.h (psymtab_storage::obstack): Update.
13918         (psymtab_storage::m_obstack): Use gdb::optional.
13919         (class psymtab_storage): Update comment.  Remove objfile
13920         parameter.
13921         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13922
13923 2019-01-10  Tom Tromey  <tom@tromey.com>
13924
13925         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13926         <free_psymtabs>: Now private.
13927         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13928         (allocate_psymtab): Use new method.
13929
13930 2019-01-10  Tom Tromey  <tom@tromey.com>
13931
13932         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13933         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13934         * mdebugread.c (parse_partial_symbols): Use
13935         allocate_dependencies.
13936         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13937         allocate_dependencies.
13938         (process_psymtab_comp_unit_reader)
13939         (build_type_psymtab_dependencies): Likewise.
13940         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13941
13942 2019-01-10  Tom Tromey  <tom@tromey.com>
13943
13944         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13945         PSYMBOL_SET_LANGUAGE.
13946         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13947
13948 2019-01-10  Tom Tromey  <tom@tromey.com>
13949
13950         * psymtab.h (psymtab_storage::obstack): New method.
13951         <m_obstack>: Rename from obstack; now private.
13952         * psymtab.c (psymtab_storage): Update.
13953         * dwarf2read.c (create_addrmap_from_index)
13954         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13955         Update.
13956
13957 2019-01-10  Tom Tromey  <tom@tromey.com>
13958
13959         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13960         * objfiles.h (objfile::reset_psymtabs): New method.
13961
13962 2019-01-10  Tom Tromey  <tom@tromey.com>
13963
13964         * symmisc.c (print_symbol_bcache_statistics): Update.
13965         (print_objfile_statistics): Update.
13966         * symfile.c (reread_symbols): Update.
13967         * psymtab.h (class psymtab_storage): New.
13968         * psymtab.c (psymtab_storage): New constructor.
13969         (~psymtab_storage): New destructor.
13970         (require_partial_symbols): Update.
13971         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13972         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13973         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13974         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13975         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13976         (start_psymtab_common, end_psymtab_common)
13977         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13978         (allocate_psymtab): Update.
13979         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13980         Update.
13981         (dump_psymtab_addrmap, maintenance_print_psymbols)
13982         (maintenance_check_psymtabs): Update.
13983         (class objfile_psymtabs): Move to objfiles.h.
13984         * psympriv.h (discard_psymtab): Now inline.
13985         (psymtab_discarder::psymtab_discarder): Update.
13986         (psymtab_discarder::~psymtab_discarder): Update.
13987         (ALL_OBJFILE_PSYMTABS): Rewrite.
13988         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13989         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13990         Remove fields.
13991         <partial_symtabs>: New field.
13992         (class objfile_psymtabs): Move from psymtab.h.  Update.
13993         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13994         psymbol_cache.
13995         (objfile::~objfile): Don't destroy psymbol_cache.
13996         * mdebugread.c (parse_partial_symbols): Update.
13997         * dwarf2read.c (create_addrmap_from_index)
13998         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13999         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14000         (add_partial_subprogram, dwarf2_ranges_read): Update.
14001         * dwarf-index-write.c (write_address_map)
14002         (write_one_signatured_type, recursively_write_psymbols)
14003         (class debug_names, class debug_names, write_psymtabs_to_index):
14004         Update.
14005
14006 2019-01-10  Tom Tromey  <tom@tromey.com>
14007
14008         * symtab.h (SYMBOL_SET_NAMES): Update.
14009         (symbol_set_names): Update.
14010         (MSYMBOL_SET_NAMES): Update.
14011         * symtab.c (symbol_set_names): Change argument to be an
14012         objfile_per_bfd_storage.
14013         * psymtab.c (add_psymbol_to_bcache): Update.
14014         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14015
14016 2019-01-10  Tom Tromey  <tom@tromey.com>
14017
14018         * symtab.c (create_demangled_names_hash): Change argument to be an
14019         objfile_per_bfd_storage.
14020         (symbol_set_names): Update.
14021
14022 2019-01-10  Tom Tromey  <tom@tromey.com>
14023
14024         * xcoffread.c (xcoff_initial_scan): Unconditionally call
14025         init_psymbol_list.
14026         * psymtab.c (init_psymbol_list): Do nothing if already called.
14027         * psympriv.h (init_psymbol_list): Add comment.
14028         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14029         init_psymbol_list.
14030         * dbxread.c (dbx_symfile_read): Unconditionally call
14031         init_psymbol_list.
14032
14033 2019-01-10  Tom Tromey  <tom@tromey.com>
14034
14035         * xcoffread.c (scan_xcoff_symtab): Update.
14036         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14037         "where".
14038         * mdebugread.c (parse_partial_symbols)
14039         (handle_psymbol_enumerators): Update.
14040         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14041         * dbxread.c (read_dbx_symtab): Update.
14042         * psympriv.h (psymbol_placement): New enum.
14043         (add_psymbol_to_list): Update.
14044
14045 2019-01-10  Tom Tromey  <tom@tromey.com>
14046
14047         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14048         static_psymbols parameters.
14049         (scan_xcoff_symtab): Update.
14050         * psymtab.c (start_psymtab_common): Remove global_psymbols and
14051         static_psymbols parameters.
14052         * psympriv.h (start_psymtab_common): Update.
14053         * mdebugread.c (parse_partial_symbols): Update.
14054         * dwarf2read.c (create_partial_symtab): Update.
14055         * dbxread.c (read_dbx_symtab): Update.
14056         (start_psymtab): Remove global_psymbols and static_psymbols
14057         parameters.
14058
14059 2019-01-10  Tom Tromey  <tom@tromey.com>
14060
14061         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14062         * psymtab.c (allocate_psymtab): Add comment.
14063         * psympriv.h (allocate_psymtab): Add comment.
14064         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14065         initializations.
14066         * dbxread.c (dbx_end_psymtab): Remove some initializations.
14067
14068 2019-01-10  Tom Tromey  <tom@tromey.com>
14069
14070         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14071         Don't declare.
14072         * mipsread.c: Include mdebugread.h.
14073         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14074         Declare.
14075         * elfread.c: Include mdebugread.h.
14076
14077 2019-01-09  Tom Tromey  <tom@tromey.com>
14078
14079         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14080         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14081         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14082         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14083         (psym_lookup_symbol, psym_find_last_source_symtab)
14084         (psym_forget_cached_source_info, psym_print_stats)
14085         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14086         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14087         (psym_map_matching_symbols, psym_expand_symtabs_matching)
14088         (psym_find_compunit_symtab_by_address)
14089         (maintenance_print_psymbols, maintenance_info_psymtabs)
14090         (maintenance_check_psymtabs): Use ranged for.
14091         * psymtab.h (class objfile_psymtabs): New.
14092         (require_partial_symbols): Return objfile_psymtabs.
14093         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14094
14095 2019-01-09  Tom Tromey  <tom@tromey.com>
14096
14097         * symfile.c (overlay_invalidate_all, find_pc_overlay)
14098         (find_pc_mapped_section, list_overlays_command)
14099         (map_overlay_command, unmap_overlay_command)
14100         (simple_overlay_update): Use all_objfiles.
14101         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14102         * printcmd.c (info_symbol_command): Use all_objfiles.
14103         * objfiles.h (ALL_OBJSECTIONS): Remove.
14104         * maint.c (maintenance_translate_address): Use all_objfiles.
14105         * gcore.c (gcore_create_callback): Use all_objfiles.
14106         (objfile_find_memory_regions): Likewise.
14107
14108 2019-01-09  Tom Tromey  <tom@tromey.com>
14109
14110         * symtab.c (find_line_symtab, info_sources_command)
14111         (make_source_files_completion_list): Use objfile_compunits.
14112         * source.c (select_source_symtab): Use objfile_compunits.
14113         * objfiles.h (struct objfile): Update comment.
14114         (ALL_OBJFILES): Remove.
14115         (ALL_FILETABS): Remove.
14116         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14117         objfile_compunits.
14118
14119 2019-01-09  Tom Tromey  <tom@tromey.com>
14120
14121         * symmisc.c (print_objfile_statistics, dump_objfile)
14122         (maintenance_print_symbols): Use compunit_filetabs.
14123         * source.c (forget_cached_source_info_for_objfile): Use
14124         compunit_filetabs.
14125         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14126         (ALL_FILETABS): Use compunit_filetabs.
14127         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14128         * coffread.c (coff_symtab_read): Use compunit_filetabs.
14129
14130 2019-01-09  Tom Tromey  <tom@tromey.com>
14131
14132         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14133         (compunit_filetabs): New.
14134         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14135         compunit_filetabs.
14136         (info_sources_command, make_source_files_completion_list): Remove
14137         declaration.
14138         * symmisc.c (print_objfile_statistics, dump_objfile)
14139         (maintenance_print_symbols): Remove declaration.
14140         (maintenance_info_symtabs): Use compunit_filetabs.
14141         (maintenance_info_line_tables): Likewise.
14142         * source.c (select_source_symtab): Change local variable name.
14143         (forget_cached_source_info_for_objfile): Remove declaration.
14144         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14145         * objfiles.c (objfile_relocate1): Remove declaration.
14146         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14147         declaration.
14148         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14149         * coffread.c (coff_symtab_read): Remove declaration.
14150         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14151         compunit_filetabs.
14152
14153 2019-01-09  Tom Tromey  <tom@tromey.com>
14154
14155         * symtab.c (lookup_objfile_from_block)
14156         (find_pc_sect_compunit_symtab, search_symbols)
14157         (default_collect_symbol_completion_matches_break_on): Use
14158         objfile_compunits.
14159         * objfiles.h (ALL_COMPUNITS): Remove.
14160         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14161         * cp-support.c (add_symbol_overload_list_qualified): Use
14162         objfile_compunits.
14163         * ada-lang.c (ada_collect_symbol_completion_matches)
14164         (ada_add_global_exceptions): Use objfile_compunits.
14165
14166 2019-01-09  Tom Tromey  <tom@tromey.com>
14167
14168         * source.c (select_source_symtab)
14169         (forget_cached_source_info_for_objfile): Remove declaration.
14170         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14171         declaration.
14172         * maint.c (count_symtabs_and_blocks): Remove declaration.
14173         * cp-support.c (add_symbol_overload_list_qualified): Remove
14174         declaration.
14175         * coffread.c (coff_symtab_read): Remove declaration.
14176         * symtab.c (lookup_symbol_in_objfile_symtabs)
14177         (basic_lookup_transparent_type_1): Use objfile_compunits.
14178         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14179         (info_sources_command, search_symbols)
14180         (default_collect_symbol_completion_matches_break_on)
14181         (make_source_files_completion_list): Remove declaration.
14182         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14183         (ada_collect_symbol_completion_matches)
14184         (ada_add_global_exceptions): Remove declaration.
14185         * linespec.c (iterate_over_all_matching_symtabs): Use
14186         objfile_compunits.
14187         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14188         (class objfile_compunits): New.
14189         (ALL_COMPUNITS): Use objfile_compunits.
14190         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14191         (maintenance_check_symtabs, maintenance_info_line_tables): Use
14192         objfile_compunits.
14193         * objfiles.c (objfile_relocate1): Use objfile_compunits.
14194
14195 2019-01-09  Tom Tromey  <tom@tromey.com>
14196
14197         * symtab.c (search_symbols)
14198         (default_collect_symbol_completion_matches_break_on): Use
14199         objfile_msymbols.
14200         * ada-lang.c (ada_lookup_simple_minsym)
14201         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14202         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14203         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14204         objfile_msymbols.
14205         * coffread.c (coff_symfile_read): Use objfile_msymbols.
14206         * symmisc.c (dump_msymbols): Use objfile_msymbols.
14207         * objc-lang.c (find_methods): Use objfile_msymbols.
14208         (info_selectors_command, info_classes_command): Likewise.
14209         * stabsread.c (scan_file_globals): Use objfile_msymbols.
14210         * objfiles.h (class objfile_msymbols): New.
14211         (ALL_OBJFILE_MSYMBOLS): Remove.
14212         (ALL_MSYMBOLS): Remove.
14213
14214 2019-01-09  Tom Tromey  <tom@tromey.com>
14215
14216         * common/next-iterator.h (next_adapter): Add Iterator template
14217         parameter.
14218         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14219         (class all_objfiles_safe): New.
14220         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14221         * objfiles.c (put_objfile_before): Update comment.
14222         (add_separate_debug_objfile): Likewise.
14223         (free_all_objfiles): Use all_objfiles_safe.
14224         (objfile_purge_solibs): Likewise.
14225
14226 2019-01-09  Tom Tromey  <tom@tromey.com>
14227
14228         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14229         (expand_symtab_containing_pc, lookup_static_symbol)
14230         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
14231         (find_symbol_at_address, find_line_symtab, find_main_name): Use
14232         all_objfiles.
14233         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
14234         * breakpoint.c (create_overlay_event_breakpoint)
14235         (create_longjmp_master_breakpoint)
14236         (create_std_terminate_master_breakpoint)
14237         (create_exception_master_breakpoint): Use all_objfiles.
14238         * linux-thread-db.c (try_thread_db_load_from_pdir)
14239         (has_libpthread): Use all_objfiles.
14240         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
14241         * linespec.c (iterate_over_all_matching_symtabs)
14242         (search_minsyms_for_name): Use all_objfiles.
14243         * maint.c (maintenance_info_sections): Use all_objfiles.
14244         * main.c (captured_main_1): Use all_objfiles.
14245         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
14246         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
14247         * guile/scm-pretty-print.c
14248         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
14249         * solib-spu.c (append_ocl_sos): Use all_objfiles.
14250         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
14251         (maintenance_print_msymbols): Use all_objfiles.
14252         * source.c (select_source_symtab): Use all_objfiles.
14253         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
14254         * symfile.c (remove_symbol_file_command)
14255         (expand_symtabs_matching, map_symbol_filenames): Use
14256         all_objfiles.
14257         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
14258         all_objfiles.
14259         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
14260         * objc-lang.c (find_methods): Use all_objfiles.
14261         * objfiles.c (have_partial_symbols, have_full_symbols)
14262         (have_minimal_symbols, qsort_cmp)
14263         (default_iterate_over_objfiles_in_search_order): Use
14264         all_objfiles.
14265         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
14266         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
14267         (maintenance_check_psymtabs): Use all_objfiles.
14268         (ALL_PSYMTABS): Remove.
14269         * compile/compile-object-run.c (do_module_cleanup): Use
14270         all_objfiles.
14271         * blockframe.c (find_pc_partial_function): Use all_objfiles.
14272         * cp-support.c (add_symbol_overload_list_qualified): Use
14273         all_objfiles.
14274         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14275         Use all_objfiles.
14276         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
14277         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
14278         all_objfiles.
14279         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14280         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
14281         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14282         Uses all_objfiles.
14283         * solib.c (solib_read_symbols): Use all_objfiles
14284
14285 2019-01-09  Tom Tromey  <tom@tromey.com>
14286
14287         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14288         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14289         all_objfiles.
14290         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14291         * symmisc.c (print_symbol_bcache_statistics)
14292         (print_objfile_statistics, maintenance_print_objfiles)
14293         (maintenance_info_symtabs, maintenance_check_symtabs)
14294         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14295         all_objfiles.
14296         * source.c (forget_cached_source_info): Use all_objfiles.
14297         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14298         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14299         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14300         * objfiles.c (update_section_map): Use all_objfiles.
14301         (shared_objfile_contains_address_p): Likewise.
14302         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14303         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14304
14305 2019-01-09  Tom Tromey  <tom@tromey.com>
14306
14307         * common/next-iterator.h: New file.
14308         * objfiles.h (class all_objfiles): New.
14309         (struct objfile_iterator): New.
14310
14311 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14312
14313         * NEWS: Move the description of the changed "frame", "select-frame",
14314          and "info frame" commands to the Changed commands section.
14315
14316 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14317
14318         * gdbtypes.c (check_stub_method_group): Remove handling of old
14319         mangling schemes.
14320         * linespec.c (find_methods): Likewise.
14321         * stabsread.c (read_member_functions): Likewise.
14322         * valops.c (search_struct_method): Likewise.
14323         (value_struct_elt_for_reference): Likewise.
14324         * NEWS: Mention this change.
14325
14326 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14327
14328         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14329         print_source_lines.
14330         * source.c (print_source_lines_base): Update line number check.
14331         (print_source_lines): New function.
14332         (source_lines_range::source_lines_range): New function.
14333         * source.h (class source_lines_range): New class.
14334         (print_source_lines): New declaration.
14335
14336 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14337
14338         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14339
14340 2019-01-08  Tom Tromey  <tom@tromey.com>
14341             Simon Marchi  <simon.marchi@ericsson.com>
14342
14343         PR gdb/24060
14344         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14345         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14346         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14347         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14348         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14349         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14350
14351 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14352
14353         * source.c (select_source_symtab): Move header comment to
14354         declaration in source.h.
14355         (forget_cached_source_info_for_objfile): Likewise.
14356         (forget_cached_source_info): Likewise.
14357         (identify_source_line): Likewise.
14358         * source.h (identify_source_line): Move declaration from symtab.h
14359         and add comment from source.c
14360         (print_source_lines): Likewise.
14361         (forget_cached_source_info_for_objfile): Likewise.
14362         (forget_cached_source_info): Likewise.
14363         (select_source_symtab): Likewise.
14364         (enum print_source_lines_flag): Move definition from symtab.h.
14365         * symtab.h (identify_source_line): Move declaration to source.h.
14366         (print_source_lines): Likewise.
14367         (forget_cached_source_info_for_objfile): Likewise.
14368         (forget_cached_source_info): Likewise.
14369         (select_source_symtab): Likewise.
14370         (enum print_source_lines_flag): Move definition to source.h.
14371         * tui/tui-hooks.c: Add 'source.h' include.
14372
14373 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14374
14375         * source.c (print_source_lines_base): Handle requests to print
14376         reverse line number sequences, and guard against empty lines
14377         string.
14378
14379 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14380
14381         * source.c (print_source_lines_base): Fix skip of '\r' if next
14382         character is '\n'.
14383
14384 2019-01-06  Tom Tromey  <tom@tromey.com>
14385
14386         * c-exp.y (struct c_parse_state) <macro_original_text,
14387         expansion_obstack>: New member.
14388         (macro_original_text, expansion_obstack): Remove globals.
14389         (scan_macro_expansion, scanning_macro_expansion)
14390         (finished_macro_expansion): Update.
14391         (scan_macro_cleanup): Remove.
14392         (yylex, c_parse): Update.
14393
14394 2019-01-06  Tom Tromey  <tom@tromey.com>
14395
14396         * c-exp.y (struct c_parse_state) <strings>: New member.
14397         (operator_stoken): Update.
14398
14399 2019-01-06  Tom Tromey  <tom@tromey.com>
14400
14401         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14402         (union type_stack_elt) <typelist_val>: Now a pointer to
14403         std::vector.
14404         (type_stack_cleanup): Don't declare.
14405         (push_typelist): Update.
14406         * parse.c (pop_typelist): Return a std::vector.
14407         (push_typelist): Take a std::vector.
14408         (follow_types): Update.  Do not free args.
14409         (type_stack_cleanup): Remove.
14410         * c-exp.y (struct c_parse_state): New.
14411         (cpstate): New global.
14412         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14413         (nonempty_typelist): Update.
14414         (func_mod): Create a new vector.
14415         (c_parse): Create a c_parse_state.
14416         (check_parameter_typelist): Do not delete params.
14417         (function_method): Update.  Do not delete type_list.
14418
14419 2019-01-06  Tom Tromey  <tom@tromey.com>
14420
14421         PR gdb/28155:
14422         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14423         check_typedef.
14424         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14425         (print_return_value): Likewise.
14426
14427 2019-01-05  Tom Tromey  <tom@tromey.com>
14428
14429         * contrib/cleanup_check.py: Remove.
14430         * contrib/gcc-with-excheck: Remove.
14431         * contrib/exsummary.py: Remove.
14432         * contrib/excheck.py: Remove.
14433
14434 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14435
14436         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14437         NULL. Initialize tpprev to NULL instead of assigning it
14438         to NULL on the next statement.
14439         * windows-nat.c (windows_delete_thread): Remove check for
14440         main_thread_id before printing thread exit notifications.
14441         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14442         Remove thread ID check against main_thread_id.
14443         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14444         windows_delete_thread.
14445         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14446
14447 2019-01-04  Tom Tromey  <tom@tromey.com>
14448
14449         * compile/compile.c (_initialize_compile): Use upper case for
14450         metasyntactic variables.
14451         * symmisc.c (_initialize_symmisc): Use upper case for
14452         metasyntactic variables.
14453         * psymtab.c (_initialize_psymtab): Use upper case for
14454         metasyntactic variables.
14455         * demangle.c (demangle_command): Use upper case for metasyntactic
14456         variables.
14457         (_initialize_demangler): Likewise.
14458         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14459         variables.
14460
14461 2019-01-03  Tom Tromey  <tom@tromey.com>
14462
14463         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14464
14465 2019-01-03  Tom Tromey  <tom@tromey.com>
14466
14467         * python/py-symtab.c (salpy_str): Update.
14468         (struct salpy_sal_object) <symtab>: Now a PyObject.
14469         (salpy_dealloc): Update.
14470         (del_objfile_sal): Use gdbpy_ref.
14471
14472 2019-01-03  Tom Tromey  <tom@tromey.com>
14473
14474         * python/py-type.c (convert_field): Use new_reference.  Return
14475         gdbpy_ref.
14476         (make_fielditem): Return gdbpy_ref.
14477         (typy_fields): Update.
14478         (typy_getitem): Update.
14479         (field_name): Return gdbpy_ref.  Use new_reference.
14480         (typy_iterator_iternext): Update.
14481
14482 2019-01-03  Tom Tromey  <tom@tromey.com>
14483
14484         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14485
14486 2019-01-03  Tom Tromey  <tom@tromey.com>
14487
14488         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14489         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14490         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14491         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14492         (pspy_set_type_printers): Likewise.
14493         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14494         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14495         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14496         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14497         (objfpy_set_type_printers): Likewise.
14498
14499 2019-01-03  Tom Tromey  <tom@tromey.com>
14500
14501         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14502         (gdbpy_print_stack): Use gdbpy_err_fetch.
14503         * python/python-internal.h (class gdbpy_err_fetch): New class.
14504         (class gdbpy_enter) <m_error_type, m_error_value,
14505         m_error_traceback>: Remove.
14506         <m_error>: New member.
14507         (gdbpy_exception_to_string): Don't declare.
14508         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14509         * python/py-value.c (convert_value_from_python): Use
14510         gdbpy_err_fetch.
14511         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14512         gdbpy_exception_to_string.
14513         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14514         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14515         gdbpy_err_fetch.
14516
14517 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14518
14519         * linux-nat.c (delete_lwp_cleanup): Delete.
14520         (struct lwp_deleter): New struct.
14521         (lwp_info_up): New typedef.
14522         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14523         lwp_info_up.
14524
14525 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14526
14527         * linux-fork.c (class scoped_switch_fork_info): New class.
14528         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14529
14530 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14531
14532         * valops.c (find_overload_match): Remove use of null_cleanup, and
14533         calls to do_cleanups.
14534
14535 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14536
14537         * compile/compile-cplus-types.c
14538         (compile_cplus_instance::decl_name): Handle changes to
14539         cp_func_name.
14540         * cp-support.c (cp_func_name): Update header comment, update
14541         return type.
14542         * cp-support.h (cp_func_name): Update return type in declaration.
14543         * valops.c (find_overload_match): Move temp_func local to top
14544         level of function and change its type.  Use temp_func to hold and
14545         delete temporary string obtained from cp_func_name.
14546
14547 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14548
14549         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14550         gdb::char_vector, remove cleanup, and update uses of `msg`.
14551
14552 2019-01-03  Jim Wilson  <jimw@sifive.com>
14553
14554         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14555
14556 2019-01-02  Tom Tromey  <tom@tromey.com>
14557
14558         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14559         (tdesc_parse_xml): Remove cleanups.
14560         * target-descriptions.h (make_cleanup_free_target_description):
14561         Don't declare.
14562         (target_desc_deleter): New struct.
14563         (target_desc_up): New typedef.
14564         * target-descriptions.c (target_desc_deleter::operator()): Rename
14565         from free_target_description.
14566         (make_cleanup_free_target_description): Remove.
14567
14568 2019-01-02  Tom Tromey  <tom@tromey.com>
14569
14570         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14571         constructor, destructor.
14572         (linespec_parser): Remove typedef.
14573         (~linespec_parser): Rename from linespec_parser_delete.
14574         (linespec_lex_to_end, linespec_complete_label)
14575         (linespec_complete): Update.
14576         (decode_line_full): Remove cleanups.
14577         (decode_line_1): Update.
14578
14579 2019-01-02  Tom Tromey  <tom@tromey.com>
14580
14581         * python/python-internal.h (inferior_to_inferior_object): Change
14582         return type.
14583         * python/py-exitedevent.c (create_exited_event_object): Update.
14584         * python/py-inferior.c (inferior_to_inferior_object): Return
14585         gdbpy_ref.
14586         (python_new_inferior, python_inferior_deleted)
14587         (thread_to_thread_object, delete_thread_object)
14588         (build_inferior_list, gdbpy_selected_inferior): Update.
14589         * python/py-infthread.c (create_thread_object): Update.  Also fail
14590         if inferior_to_inferior_object fails.
14591
14592 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14593
14594         * inferior.h (class inferior) <displaced_step_state>: New field.
14595         * infrun.h (struct displaced_step_state): Move here from
14596         infrun.c.  Initialize fields, add constructor.
14597         <inf>: Remove field.
14598         <reset>: New method.
14599         * infrun.c (struct displaced_step_inferior_state): Move to
14600         infrun.h.
14601         (displaced_step_inferior_states): Remove.
14602         (get_displaced_stepping_state): Adust.
14603         (displaced_step_in_progress_any_inferior): Adjust.
14604         (displaced_step_in_progress_thread): Adjust.
14605         (displaced_step_in_progress): Adjust.
14606         (add_displaced_stepping_state): Remove.
14607         (get_displaced_step_closure_by_addr): Adjust.
14608         (remove_displaced_stepping_state): Remove.
14609         (infrun_inferior_exit): Call displaced_step_state.reset.
14610         (use_displaced_stepping): Don't check for NULL.
14611         (displaced_step_prepare_throw): Call
14612         get_displaced_stepping_state.
14613         (displaced_step_fixup): Don't check for NULL.
14614         (prepare_for_detach): Don't check for NULL.
14615
14616 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14617
14618         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14619          in case of call that did not complete.
14620
14621 2019-01-02  Andrey Utkin  <autkin@undo.io>
14622
14623         * symfile.c (find_separate_debug_file): Fix search of debug files for
14624         remote debuggee.
14625
14626 2019-01-02  Tom Tromey  <tom@tromey.com>
14627
14628         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14629         indentation.
14630         * python/py-frame.c (frapy_older): Remove cast.
14631         (frapy_newer): Likewise.
14632         * python/py-breakpoint.c (local_setattro): Remove cast.
14633         * python/py-arch.c (archpy_name): Remove local variable.
14634         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14635
14636 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14637
14638         * unittests/basic_string_view/element_access/char/empty.cc:
14639         Fix year range in copyright header.
14640
14641 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14642
14643         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14644         Delete.
14645         <operator==>: Update with for removed field.
14646         <hash>: Likewise.
14647         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14648         <isa_features>: ...this.
14649         <abi_features>: New field.
14650         (riscv_isa_flen): Update comment.
14651         (riscv_abi_xlen): New declaration.
14652         (riscv_abi_flen): New declaration.
14653         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14654         isa_features.
14655         (riscv_abi_xlen): New function.
14656         (riscv_isa_flen): Update to get answer from isa_features.
14657         (riscv_abi_flen): New function.
14658         (riscv_has_fp_abi): Update to get answer from abi_features.
14659         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14660         xlen and flen.
14661         (riscv_call_info) <xlen, flen>: Update comment.
14662         (riscv_call_arg_struct): Remove invalid assertions
14663         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14664         is removed.
14665         (riscv_gdbarch_init): Gather isa features and abi features
14666         separately, ensure both match on the gdbarch when reusing an old
14667         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14668         a target with 64-bit float hardware.
14669
14670 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14671
14672         * source.c (search_command_helper): Stop reverse search
14673         when line 1 has been searched.
14674
14675 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14676
14677         * record-full.c (record_full_base_target::close): Rewrite
14678         record_full_core_buf_list free logic.
14679
14680 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14681
14682         * break-catch-syscall.c (print_one_catch_syscall): xfree
14683         the last text.
14684
14685 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14686
14687         * top.c (print_gdb_version): Update Copyright year in version
14688         message.
14689
14690 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14691
14692         Update copyright year range in all GDB files.
14693
14694 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14695
14696         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14697
14698 For older changes see ChangeLog-2018.
14699 \f
14700 Local Variables:
14701 mode: change-log
14702 left-margin: 8
14703 fill-column: 74
14704 version-control: never
14705 coding: utf-8
14706 End:
14707