gdb/ChangeLog

   1 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
   4         linux-thread-db.c (_initialize_thread_db): Likewise.
   5
   6 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
   7
   8         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
   9         wclrtoeol in tui_show_source_line".  This reverts changes made in
  10         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  11
  12 2019-03-15  Tom Tromey  <tom@tromey.com>
  13
  14         * symtab.h (struct minimal_symbol): Derive from
  15         general_symbol_info.
  16         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
  17         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
  18         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
  19         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
  20         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
  21         (MSYMBOL_SEARCH_NAME): Update.
  22         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
  23         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
  24         * minsyms.c (minimal_symbol_reader::record_full): Update.
  25
  26 2019-03-15  Tom Tromey  <tom@tromey.com>
  27
  28         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
  29
  30 2019-03-15  Tom Tromey  <tom@tromey.com>
  31
  32         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
  33         unique_xmalloc_ptr.
  34         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
  35         Update.
  36         * minsyms.c (lookup_minimal_symbol_by_pc_section)
  37         (build_minimal_symbol_hash_tables)
  38         (minimal_symbol_reader::install): Update.
  39
  40 2019-03-15  Tom Tromey  <tom@tromey.com>
  41
  42         * symtab.c (create_demangled_names_hash): Update.
  43         (symbol_set_names): Update.
  44         * objfiles.h (struct objfile_per_bfd_storage)
  45         <demangled_names_hash>: Now an htab_up.
  46         * objfiles.c (objfile_per_bfd_storage): Simplify.
  47
  48 2019-03-15  Tom Tromey  <tom@tromey.com>
  49
  50         * objfiles.h (struct objfile_per_bfd_storage): Declare
  51         destructor.
  52         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
  53         New.
  54         (get_objfile_bfd_data): Use new.  Don't initialize
  55         language_of_main.
  56         (free_objfile_per_bfd_storage): Remove.
  57         (objfile_bfd_data_free, objfile::~objfile): Use delete.
  58
  59 2019-03-15  Tom Tromey  <tom@tromey.com>
  60
  61         * symfile.c (reread_symbols): Update.
  62         * objfiles.c (objfile::objfile): Update.
  63         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
  64         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
  65         comment.
  66         (minimal_symbol_reader::install): Update.
  67         (terminate_minimal_symbol_table): Remove.
  68         * jit.c (jit_object_close_impl): Update.
  69
  70 2019-03-15  Tom Tromey  <tom@tromey.com>
  71
  72         * minsyms.c (minimal_symbol_reader::record_full): Remove some
  73         initializations.
  74
  75 2019-03-15  Tom Tromey  <tom@tromey.com>
  76
  77         * objfiles.h (struct objfile_per_bfd_storage)
  78         <demangled_hash_languages>: Now a bitset.
  79         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
  80         (lookup_minimal_symbol): Update.
  81
  82 2019-03-15  Tom Tromey  <tom@tromey.com>
  83
  84         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
  85         Don't return the symbol.
  86         * coffread.c (record_minimal_symbol): Use record_full.
  87
  88 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
  89
  90         The MS-Windows port of ncurses fails to switch to a color pair if
  91         one or both of the colors are the implicit default colors.  This
  92         change records the default colors when TUI is initialized, and
  93         then specifies them explicitly when a color pair uses the default
  94         colors.  This allows color styling in TUI mode on MS-Windows.
  95
  96         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
  97         ncurses_norm_attr.
  98         (tui_initialize_io) [__MINGW32__]: Record the default terminal
  99         colors in ncurses_norm_attr.
 100         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 101         "none", replace it with the default color recorded in
 102         ncurses_norm_attr.
 103
 104 2019-03-14  Tom Tromey  <tromey@adacore.com>
 105
 106         * source-cache.h (class source_cache) <get_source_lines>: Return
 107         std::string.
 108         * source-cache.c (source_cache::extract_lines): Handle case where
 109         first_pos==npos.  Return std::string.
 110         (source_cache::get_source_lines): Update.
 111
 112 2019-03-14  Tom Tromey  <tromey@adacore.com>
 113
 114         * NEWS: Add item for "style sources" commands.
 115         * source-cache.c (source_cache::get_source_lines): Check
 116         source_styling.
 117         * cli/cli-style.c (source_styling): New global.
 118         (_initialize_cli_style): Add "style sources" commands.
 119         (show_style_sources): New function.
 120         * cli/cli-style.h (source_styling): Declare.
 121
 122 2019-03-14  Pedro Alves  <palves@redhat.com>
 123             Tom Tromey  <tromey@adacore.com>
 124
 125         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 126         * tui/tui-winsource.c (tui_refill_source_window): New function,
 127         from...
 128         (tui_horizontal_source_scroll): ... here.  Move some logic.
 129         * cli/cli-style.c (set_style_enabled): Notify new observable.
 130         * tui/tui-hooks.c (tui_redisplay_source): New function.
 131         (tui_attach_detach_observers): Attach or detach
 132         tui_redisplay_source.
 133         * observable.h (source_styling_changed): New observable.
 134         * observable.c: Define source_styling_changed observable.
 135
 136 2019-03-13  Tom Tromey  <tromey@adacore.com>
 137
 138         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 139         (i386_gnu_nat_target::store_registers): Update.
 140         * target-debug.h (target_debug_print_std_string): New macro.
 141         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 142         * windows-tdep.c (display_one_tib): Update.
 143         * tui/tui-stack.c (tui_make_status_line): Update.
 144         * top.c (print_inferior_quit_action): Update.
 145         * thread.c (thr_try_catch_cmd): Update.
 146         (add_thread_with_info): Update.
 147         (thread_target_id_str): Update.
 148         (thr_try_catch_cmd): Update.
 149         (thread_command): Update.
 150         (thread_find_command): Update.
 151         * record-btrace.c (record_btrace_target::info_record)
 152         (record_btrace_resume_thread, record_btrace_target::resume)
 153         (record_btrace_cancel_resume, record_btrace_step_thread)
 154         (record_btrace_target::wait, record_btrace_target::wait)
 155         (record_btrace_target::wait, record_btrace_target::stop): Update.
 156         * progspace.c (print_program_space): Update.
 157         * process-stratum-target.c
 158         (process_stratum_target::thread_address_space): Update.
 159         * linux-fork.c (linux_fork_mourn_inferior)
 160         (detach_checkpoint_command, info_checkpoints_command)
 161         (linux_fork_context): Update.
 162         (linux_fork_detach): Update.
 163         (class scoped_switch_fork_info): Update.
 164         (delete_checkpoint_command): Update.
 165         * infrun.c (follow_fork_inferior): Update.
 166         (follow_fork_inferior): Update.
 167         (proceed_after_vfork_done): Update.
 168         (handle_vfork_child_exec_or_exit): Update.
 169         (follow_exec): Update.
 170         (displaced_step_prepare_throw): Update.
 171         (displaced_step_restore): Update.
 172         (start_step_over): Update.
 173         (resume_1): Update.
 174         (clear_proceed_status_thread): Update.
 175         (proceed): Update.
 176         (print_target_wait_results): Update.
 177         (do_target_wait): Update.
 178         (context_switch): Update.
 179         (stop_all_threads): Update.
 180         (restart_threads): Update.
 181         (finish_step_over): Update.
 182         (handle_signal_stop): Update.
 183         (switch_back_to_stepped_thread): Update.
 184         (keep_going_pass_signal): Update.
 185         (print_exited_reason): Update.
 186         (normal_stop): Update.
 187         * inferior.c (inferior_pid_to_str): Change return type.
 188         (print_selected_inferior): Update.
 189         (add_inferior): Update.
 190         (detach_inferior): Update.
 191         * dummy-frame.c (fprint_dummy_frames): Update.
 192         * dcache.c (dcache_info_1): Update.
 193         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 194         (btrace_fetch, btrace_clear): Update.
 195         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 196         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 197         type.
 198         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 199         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 200         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 201         * gdbarch.c, gdbarch.h: Rebuild.
 202         * gdbarch.sh (core_pid_to_str): Change return type.
 203         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 204         return type.
 205         (windows_nat_target::pid_to_str): Change return type.
 206         (windows_delete_thread): Update.
 207         (windows_nat_target::attach): Update.
 208         (windows_nat_target::files_info): Update.
 209         * target-delegates.c: Rebuild.
 210         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 211         return type.
 212         (sol_thread_target::pid_to_str): Change return type.
 213         * remote.c (class remote_target) <pid_to_str>: Change return
 214         type.
 215         (remote_target::pid_to_str): Change return type.
 216         (extended_remote_target::attach, remote_target::remote_stop_ns)
 217         (remote_target::remote_notif_remove_queued_reply)
 218         (remote_target::push_stop_reply, remote_target::disable_btrace):
 219         Update.
 220         (extended_remote_target::attach): Update.
 221         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 222         type.
 223         (gdbsim_target::pid_to_str): Change return type.
 224         * ravenscar-thread.c (struct ravenscar_thread_target)
 225         <pid_to_str>: Change return type.
 226         (ravenscar_thread_target::pid_to_str): Change return type.
 227         * procfs.c (class procfs_target) <pid_to_str>: Change return
 228         type.
 229         (procfs_target::pid_to_str): Change return type.
 230         (procfs_target::attach): Update.
 231         (procfs_target::detach): Update.
 232         (procfs_target::fetch_registers): Update.
 233         (procfs_target::store_registers): Update.
 234         (procfs_target::wait): Update.
 235         (procfs_target::files_info): Update.
 236         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 237         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 238         return type.
 239         (nto_procfs_target::pid_to_str): Change return type.
 240         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 241         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 242         return type.
 243         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 244         (exit_lwp): Update.
 245         (attach_proc_task_lwp_callback, get_detach_signal)
 246         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 247         (linux_nat_target::resume, wait_lwp, stop_callback)
 248         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 249         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 250         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 251         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 252         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 253         type.
 254         (inf_ptrace_target::attach): Update.
 255         (inf_ptrace_target::files_info): Update.
 256         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 257         type.
 258         (go32_nat_target::pid_to_str): Change return type.
 259         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 260         (gnu_nat_target::wait): Update.
 261         (gnu_nat_target::wait): Update.
 262         (gnu_nat_target::resume): Update.
 263         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 264         (fbsd_nat_target::wait): Update.
 265         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 266         type.
 267         (darwin_nat_target::attach): Update.
 268         * corelow.c (class core_target) <pid_to_str>: Change return type.
 269         (core_target::pid_to_str): Change return type.
 270         * target.c (normal_pid_to_str): Change return type.
 271         (default_pid_to_str): Likewise.
 272         (target_pid_to_str): Change return type.
 273         (target_translate_tls_address): Update.
 274         (target_announce_detach): Update.
 275         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 276         return type.
 277         (bsd_uthread_target::pid_to_str): Change return type.
 278         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 279         type.
 280         (bsd_kvm_target::pid_to_str): Change return type.
 281         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 282         return type.
 283         (aix_thread_target::pid_to_str): Change return type.
 284         * target.h (struct target_ops) <pid_to_str>: Change return type.
 285         (target_pid_to_str, normal_pid_to_str): Likewise.
 286         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 287         type.
 288         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 289         type.
 290         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 291         return type.
 292         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 293         type.
 294         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 295         type.
 296         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 297         return type.
 298
 299 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 300
 301         * NEWS: Mention that the new default MI version is 3.  Mention
 302         changes to the output of commands and events that deal with
 303         multi-location breakpoints.
 304         * breakpoint.c: Include "mi/mi-out.h".
 305         (print_one_breakpoint): Change output syntax if using MI version
 306         >= 3.
 307         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 308         New.
 309         (mi_multi_location_breakpoint_output_fixed): New.
 310         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 311         (mi_cmd_fix_multi_location_breakpoint_output): New.
 312         (mi_multi_location_breakpoint_output_fixed): New.
 313         * mi/mi-cmds.c (mi_cmds): Register command
 314         -fix-multi-location-breakpoint-output.
 315         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 316         interpreter "mi".
 317
 318 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 319
 320         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 321         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 322         instantiate mi_ui_out based on interpreter name.
 323         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 324         * mi/mi-main.c (mi_load_progress): Likewise.
 325
 326 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 327
 328         * NEWS: Combine separate "New targets" sections for 8.3.
 329
 330 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 331
 332         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 333         (ppcfbsd_init_abi): Install gdbarch
 334         "fetch_tls_load_module_address" and "get_thread_local_address"
 335         methods.
 336
 337 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 338
 339         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 340         (riscv_fbsd_init_abi): Install gdbarch
 341         "fetch_tls_load_module_address" and "get_thread_local_address"
 342         methods.
 343
 344 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 345
 346         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 347         (i386fbsd_init_abi): Install gdbarch
 348         "fetch_tls_load_module_address" and "get_thread_local_address"
 349         methods.
 350
 351 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 352
 353         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 354         (amd64fbsd_init_abi): Install gdbarch
 355         "fetch_tls_load_module_address" and "get_thread_local_address"
 356         methods.
 357
 358 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 359
 360         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 361         (struct fbsd_pspace_data): New type.
 362         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 363         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 364         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 365         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 366         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 367
 368 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 369
 370         * gdbtypes.c (lookup_struct_elt): New function.
 371         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 372         * gdbtypes.h (struct struct_elt): New type.
 373         (lookup_struct_elt): New prototype.
 374
 375 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 376
 377         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 378         remove disabled code block.
 379
 380 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 381
 382         * gdbarch.sh (get_thread_local_address): New method.
 383         * gdbarch.h, gdbarch.c: Regenerate.
 384         * target.c (target_translate_tls_address): Use
 385         gdbarch_get_thread_local_address if present instead of
 386         target::get_thread_local_address.
 387
 388 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 389
 390         * target.h (target::get_thread_local_address): Update comment.
 391
 392 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 393
 394         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 395         objfile->separate_debug_objfile_backlink if not NULL.
 396
 397 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 398
 399         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 400         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 401         (amd64bsd_store_inferior_registers): Likewise.
 402         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 403         Enable segment base registers.
 404         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 405         PT_GETFSBASE and PT_GETGSBASE.
 406         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 407         PT_SETGSBASE.
 408         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 409         segment base registers.
 410         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 411
 412 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 413
 414         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 415         Update calls to i386_target_description to add 'segments'
 416         parameter.
 417         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 418         add segment base registers.
 419         * arch/i386.c (i386_create_target_description): Add 'segments'
 420         parameter to enable segment base registers.
 421         * arch/i386.h (i386_create_target_description): Likewise.
 422         * features/i386/32bit-segments.xml: New file.
 423         * features/i386/32bit-segments.c: Generate.
 424         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 425         call to i386_target_description to add 'segments' parameter.
 426         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 427         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 428         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 429         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 430         if feature is present.
 431         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 432         Add 'segments' parameter to call to i386_target_description.
 433         (i386_target_description): Add 'segments' parameter to enable
 434         segment base registers.
 435         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 436         to call to i386_target_description.
 437         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 438         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 439         Define I386_NUM_REGS.
 440         (i386_target_description): Add 'segments' parameter to enable
 441         segment base registers.
 442
 443 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 444
 445         PR/24325
 446         * source-cache.c: #undef open and close, to avoid unresolved
 447         externals during linking.
 448
 449 2019-03-12  Tom Tromey  <tromey@adacore.com>
 450
 451         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 452         const.  Add initializers.
 453         (_initialize_remote): Don't initialize ptid globals.
 454
 455 2019-03-12  Pedro Alves  <palves@redhat.com>
 456
 457         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 458
 459 2019-03-12  Pedro Alves  <palves@redhat.com>
 460
 461         * cp-name-parser.y (main): Remove unused 'len' variable.
 462
 463 2019-03-12  Tom Tromey  <tromey@adacore.com>
 464
 465         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 466         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 467
 468 2019-03-12  Tom Tromey  <tromey@adacore.com>
 469
 470         * linux-nat.c (iterate_over_lwps): Update.
 471         (stop_callback): Remove parameter.
 472         (stop_wait_callback, detach_callback, resume_set_callback)
 473         (select_singlestep_lwp_callback, set_ignore_sigint)
 474         (status_callback, resumed_callback, resume_clear_callback)
 475         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 476         data parameter.
 477         (linux_nat_target::detach, linux_nat_target::resume)
 478         (linux_stop_and_wait_all_lwps, select_event_lwp)
 479         (linux_nat_filter_event, linux_nat_wait_1)
 480         (linux_nat_target::kill, linux_nat_target::stop)
 481         (linux_nat_target::stop): Update.
 482         (linux_nat_resume_callback): Change type.
 483         (resume_stopped_resumed_lwps, count_events_callback)
 484         (select_event_lwp_callback): Likewise.
 485         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 486         * arm-linux-nat.c (struct update_registers_data): Remove.
 487         (update_registers_callback): Change type.
 488         (arm_linux_insert_hw_breakpoint1): Update.
 489         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 490         parameter.
 491         (x86_linux_dr_set_addr): Update.
 492         (x86_linux_dr_set_control): Update.
 493         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 494         (iterate_over_lwps): Use gdb::function_view.
 495         * nat/aarch64-linux-hw-point.c (struct
 496         aarch64_dr_update_callback_param): Remove.
 497         (debug_reg_change_callback): Change type.
 498         (aarch64_notify_debug_reg_change): Update.
 499         * s390-linux-nat.c (s390_refresh_per_info): Update.
 500
 501 2019-03-11  Tom Tromey  <tromey@adacore.com>
 502
 503         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 504         redundant assignment to "this_cu".
 505
 506 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 507
 508         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 509
 510 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 511
 512         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 513         from...
 514         (rank_one_type): ... this.
 515
 516 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 517
 518         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 519         from...
 520         (rank_one_type): ... this.
 521
 522 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 523
 524         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 525         from...
 526         (rank_one_type): ... this.
 527
 528 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 529
 530         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 531         from...
 532         (rank_one_type): ... this.
 533
 534 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 535
 536         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 537         from...
 538         (rank_one_type): ... this.
 539
 540 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 541
 542         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 543         from...
 544         (rank_one_type): ... this.
 545
 546 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 547
 548         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 549         from...
 550         (rank_one_type): ... this.
 551
 552 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 553
 554         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 555         from...
 556         (rank_one_type): ... this.
 557
 558 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 559
 560         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 561         from...
 562         (rank_one_type): ... this.
 563
 564 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 565
 566         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 567         from...
 568         (rank_one_type): ... this.
 569
 570 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 571
 572         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 573         from...
 574         (rank_one_type): ... this.
 575
 576 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 577
 578         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 579         from...
 580         (rank_one_type): ... this.
 581
 582 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 583
 584         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 585         inferior-events' shows the example events.
 586
 587 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 588
 589         Support styling on native MS-Windows console
 590
 591         PR/24315
 592         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 593         on MS-Windows if $TERM is not defined.
 594
 595         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 596
 597         * posix-hdep.c (gdb_console_fputs):
 598         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 599         functions.
 600         * ui-file.h (gdb_console_fputs): Add prototype.
 601
 602         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 603         back to fputs only if the former returns zero.
 604
 605 2019-03-07  Tom Tromey  <tom@tromey.com>
 606
 607         * symmisc.c (print_symbol_bcache_statistics): Update.
 608         (print_objfile_statistics): Update.
 609         * symfile.c (allocate_symtab): Update.
 610         * stabsread.c: Don't include bcache.h.
 611         * psymtab.h (struct psymbol_bcache): Don't declare.
 612         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 613         (psymbol_bcache_init, psymbol_bcache_free)
 614         (psymbol_bcache_get_bcache): Don't declare.
 615         * psymtab.c (struct psymbol_bcache): Remove.
 616         (psymtab_storage::psymtab_storage): Update.
 617         (psymtab_storage::~psymtab_storage): Update.
 618         (psymbol_bcache_init, psymbol_bcache_free)
 619         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 620         (add_psymbol_to_bcache): Update.
 621         (allocate_psymtab): Update.
 622         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 623         macro_cache>: No longer pointers.
 624         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 625         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 626         * macrotab.c (macro_bcache): Update.
 627         * macroexp.c: Don't include bcache.h.
 628         * gdbtypes.c (check_types_worklist): Update.
 629         (types_deeply_equal): Remove TRY/CATCH.  Update.
 630         * elfread.c (elf_symtab_read): Update.
 631         * dwarf2read.c: Don't include bcache.h.
 632         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 633         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 634         (print_bcache_statistics, bcache_memory_used): Don't declare.
 635         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 636         methods.  Rename all data members.
 637         * bcache.c (struct bcache): Move to bcache.h.
 638         (bcache::expand_hash_table): Rename from expand_hash_table.
 639         (bcache): Remove.
 640         (bcache::insert): Rename from bcache_full.
 641         (bcache::compare): Rename from bcache_compare.
 642         (bcache_xmalloc): Remove.
 643         (bcache::~bcache): Rename from bcache_xfree.
 644         (bcache::print_statistics): Rename from print_bcache_statistics.
 645         (bcache::memory_used): Rename from bcache_memory_used.
 646
 647 2019-03-07  Pedro Alves  <palves@redhat.com>
 648
 649         * infrun.c (normal_stop): Also check for
 650         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 651
 652 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 653
 654         * f-lang.c (value_from_host_double): Moved to...
 655         * value.c (value_from_host_double): ...here.
 656         * value.h (value_from_host_double): Declare.
 657         * guile/scm-math.c (vlscm_convert_typed_number): Use
 658         value_from_host_double.
 659         (vlscm_convert_number): Likewise.
 660         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 661         * python/py-value.c (convert_value_from_python): Likewise.
 662
 663 2019-03-06  Tom Tromey  <tom@tromey.com>
 664
 665         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 666
 667 2019-03-06  Tom Tromey  <tom@tromey.com>
 668
 669         * utils.h (free_current_contents): Don't declare.
 670         * utils.c (free_current_contents): Remove.
 671
 672 2019-03-06  Tom Tromey  <tom@tromey.com>
 673
 674         * top.c (quit_force): Update.
 675         * main.c (captured_command_loop): Update.
 676         * common/new-op.c (operator new): Update.
 677         * common/common-exceptions.c (struct catcher)
 678         <save_cleanup_chain>: Remove member.
 679         (exceptions_state_mc_init): Update.
 680         (exception_try_scope_entry): Return nullptr.
 681         (exception_try_scope_exit, exception_rethrow)
 682         (throw_exception_sjlj, throw_exception_cxx): Update.
 683         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 684         (all_cleanups, do_cleanups, discard_cleanups)
 685         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 686         (restore_cleanups, restore_final_cleanups): Don't declare.
 687         (do_final_cleanups): Remove parameter.
 688         * common/cleanups.c (cleanup_chain, make_cleanup)
 689         (make_cleanup_dtor, all_cleanups, do_cleanups)
 690         (discard_my_cleanups, discard_cleanups)
 691         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 692         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 693         (null_cleanup): Remove.
 694         (do_final_cleanups): Remove parameter.
 695
 696 2019-03-06  Tom Tromey  <tom@tromey.com>
 697
 698         * remote.c (remote_target::remote_parse_stop_reply): Use
 699         unique_xmalloc_ptr.
 700
 701 2019-03-06  Tom Tromey  <tom@tromey.com>
 702
 703         * stabsread.c (struct stabs_field_info): Rename from field_info.
 704         <list, fnlist>: Add initializers.
 705         <obstack>: New member.
 706         (read_member_functions, read_struct_fields, read_baseclasses):
 707         Allocate on obstack.  Don't use cleanups.
 708         (read_one_struct_field, read_member_functions, read_struct_fields)
 709         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 710         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 711         (read_struct_type): Update.
 712
 713 2019-03-06  Tom Tromey  <tom@tromey.com>
 714
 715         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 716         * common/filestuff.h (make_cleanup_close): Don't declare.
 717         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 718         Remove.
 719
 720 2019-03-06  Tom Tromey  <tom@tromey.com>
 721
 722         * solib-aix.c: Use make_scope_exit.
 723
 724 2019-03-06  Tom Tromey  <tom@tromey.com>
 725
 726         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 727         Use make_scope_exit.
 728
 729 2019-03-06  Tom Tromey  <tom@tromey.com>
 730
 731         * solib-svr4.c (disable_probes_interface): Remove parameter.
 732         (svr4_handle_solib_event): Use make_scope_exit.
 733
 734 2019-03-06  Tom Tromey  <tom@tromey.com>
 735
 736         * remote.c (struct stop_reply_deleter): Remove.
 737         (stop_reply_up): Update.
 738         (struct stop_reply): Derive from notif_event.  Don't typedef.
 739         <regcache>: Now a std::vector.
 740         (stop_reply_xfree): Remove.
 741         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 742         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 743         (remote_target::discard_pending_stop_replies): Use delete.
 744         (remote_target::remote_parse_stop_reply): Update.
 745         (remote_target::process_stop_reply): Update.
 746         * remote-notif.h (struct notif_event): Add virtual destructor.
 747         Remove "dtr" member.
 748         (struct notif_client) <alloc_event>: Return a unique_ptr.
 749         (notif_event_xfree): Don't declare.
 750         (notif_event_up): New typedef.
 751         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 752         (notif_event_xfree, do_notif_event_xfree): Remove.
 753         (remote_notif_state_xfree): Update.
 754
 755 2019-03-06  Tom Tromey  <tom@tromey.com>
 756
 757         * infrun.c (displaced_step_clear_cleanup): Now a
 758         forward_scope_exit type.
 759         (displaced_step_prepare_throw): Update.
 760         (displaced_step_fixup): Update.
 761
 762 2019-03-06  Tom Tromey  <tom@tromey.com>
 763
 764         * inferior.h (class inferior): Update comment.
 765         * gdbthread.h (class thread_info): Update comment.
 766
 767 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 768             Tom Tromey  <tom@tromey.com>
 769
 770         * stabsread.h (struct stab_section_list): Remove.
 771         (coffstab_build_psymtabs): Update.
 772         * dbxread.c (symbuf_sections): Now a std::vector.
 773         (sect_idx): New global.
 774         (fill_symbuf): Update.
 775         (coffstab_build_psymtabs): Change type of stabsects parameter.
 776         Update.
 777         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 778         std::vector.
 779         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 780         (coff_locate_sections): Update.
 781         (coff_symfile_read): Remove cleanups.  Update.
 782         (init_stringtab): Add storage parameter.
 783         (free_stringtab, free_stringtab_cleanup): Remove.
 784         (init_lineno): Add storage parameter.
 785         (free_linetab, free_linetab_cleanup): Remove.
 786
 787 2019-03-06  Pedro Alves  <palves@redhat.com>
 788
 789         * linux-fork.c (fork_info::clobber_regs): Delete.
 790         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 791         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 792         comment.  Adjust.
 793         (scoped_switch_fork_info::scoped_switch_fork_info)
 794         (checkpoint_command, linux_fork_context): Adjust
 795         fork_save_infrun_state calls.
 796
 797 2019-03-06  Pedro Alves  <palves@redhat.com>
 798
 799         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 800         (inf_has_multiple_threads): Return 'bool' and rewrite using
 801         inferior_info::threads().
 802
 803 2019-03-06  Pedro Alves  <palves@redhat.com>
 804
 805         * linux-fork.c: Include <list>.
 806         (fork_list): Now a std::list instance.
 807         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 808         (forks_exist_p, find_last_fork): Adjust.
 809         (new_fork): Delete.
 810         (one_fork_p): New.
 811         (add_fork): Adjust.
 812         (free_fork): Delete, folded into fork_info::~fork_info().
 813         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 814         Adjust.
 815         (init_fork_list): Delete.
 816         (linux_fork_killall, linux_fork_mourn_inferior)
 817         (linux_fork_detach, info_checkpoints_command): Adjust.
 818         (_initialize_linux_fork): No longer call init_fork_list.
 819
 820 2019-03-06  Pedro Alves  <palves@redhat.com>
 821
 822         * linux-fork.c (new_fork): New, split out of ...
 823         (add_fork): ... this.  Return void.  Move "first fork" special
 824         case from here, to ...
 825         (checkpoint_command): ... here.
 826         * linux-linux.h (add_fork): Return void.
 827
 828 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 829
 830         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 831
 832 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 833             Chris January  <chris.january@arm.com>
 834             David Lecomber  <david.lecomber@arm.com>
 835
 836         * f-exp.y: New token, UNOP_INTRINSIC.
 837         (exp): New pattern using UNOP_INTRINSIC token.
 838         (f77_keywords): Add 'abs' keyword.
 839         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 840         (value_from_host_double): New function.
 841         (evaluate_subexp_f): Support UNOP_ABS.
 842
 843 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 844
 845         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 846         types.
 847
 848 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 849
 850         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 851         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 852         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 853
 854 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 855
 856         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 857
 858 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 859             Chris January  <chris.january@arm.com>
 860
 861         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 862         * f-exp.y: Define 'KIND' token.
 863         (exp): New pattern for KIND expressions.
 864         (ptype): Handle types with a kind extension.
 865         (direct_abs_decl): Extend to spot kind extensions.
 866         (f77_keywords): Add 'kind' to the list.
 867         (push_kind_type): New function.
 868         (convert_to_kind_type): New function.
 869         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 870         * parse.c (operator_length_standard): Likewise.
 871         * parser-defs.h (enum type_pieces): Add tp_kind.
 872         * std-operator.def: Add UNOP_KIND.
 873
 874 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         * f-exp.y (f_parse): Set yydebug.
 877
 878 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 879
 880         * f-lang.c (evaluate_subexp_f): New function.
 881         (exp_descriptor_f): New global.
 882         (f_language_defn): Use exp_descriptor_f instead of
 883         exp_descriptor_standard.
 884
 885 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 886
 887         * f-exp.y (struct token): Add comments.
 888         (dot_ops): Remove uppercase versions and the end marker.
 889         (f77_keywords): Likewise.
 890         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 891         entries in the dot_ops array are case insensitive, and use
 892         strncasecmp to compare strings.  Also some whitespace cleanup in
 893         this area.  Similar for the f77_keywords array, except entries in
 894         this list might be case sensitive.
 895
 896 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 897
 898         * f-exp.y (struct f77_boolean_val): Add comments.
 899         (boolean_values): Remove uppercase versions, and end marker.
 900         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 901         and use strncasecmp to achieve case insensitivity.  Additionally,
 902         perform whitespace cleanup around this code.
 903
 904 2019-03-06  Tom Tromey  <tromey@adacore.com>
 905
 906         * remote-sim.c (gdbsim_target_open): Use result of
 907         gdb_argv::release.
 908
 909 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 910         Dirk Schubert  <dirk.schubert@arm.com>
 911         Chris January  <chris.january@arm.com>
 912
 913         * eval.c (evaluate_subexp_standard): Call Fortran argument
 914         wrapping logic.
 915         * f-lang.c (struct value): A value which can be passed into a
 916         Fortran function call.
 917         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 918         where appropriate.
 919         (struct type): Value ready for a Fortran function call.
 920         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 921         is needed.
 922         * f-lang.h (fortran_argument_convert): Declaration.
 923         (fortran_preserve_arg_pointer): Declaration.
 924         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 925
 926 2019-03-05  Tom Tromey  <tromey@adacore.com>
 927
 928         * python/py-prettyprint.c (print_string_repr): Remove #if.
 929         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 930
 931 2019-03-05  Tom Tromey  <tromey@adacore.com>
 932
 933         * target.c (the_dummy_target): Move later.  Change type to
 934         "dummy_target".
 935         (initialize_targets): Don't initialize the_dummy_target.
 936
 937 2019-03-05  Tom Tromey  <tromey@adacore.com>
 938
 939         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 940         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 941
 942 2019-03-05  Tom Tromey  <tromey@adacore.com>
 943
 944         * windows-nat.c (windows_nat_target::attach)
 945         (windows_nat_target::detach): Don't call gdb_flush.
 946         * valprint.c (generic_val_print, val_print, val_print_string):
 947         Don't call gdb_flush.
 948         * utils.c (defaulted_query): Don't call gdb_flush.
 949         * typeprint.c (print_type_scalar): Don't call gdb_flush.
 950         * target.c (target_announce_detach): Don't call gdb_flush.
 951         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
 952         * remote.c (extended_remote_target::attach): Don't call
 953         gdb_flush.
 954         * procfs.c (procfs_target::detach): Don't call gdb_flush.
 955         * printcmd.c (do_examine): Don't call gdb_flush.
 956         (info_display_command): Don't call gdb_flush.
 957         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
 958         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
 959         * memattr.c (info_mem_command): Don't call gdb_flush.
 960         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
 961         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
 962         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
 963         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
 964         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
 965         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
 966         (gnu_nat_target::detach): Don't call gdb_flush.
 967         * f-valprint.c (f_val_print): Don't call gdb_flush.
 968         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
 969         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
 970         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
 971         gdb_flush.
 972         * c-valprint.c (c_val_print): Don't call gdb_flush.
 973         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
 974
 975 2019-03-05  Tom Tromey  <tromey@adacore.com>
 976
 977         * varobj.c (update_dynamic_varobj_children): Update.
 978         (install_default_visualizer): Use reset, not release.
 979         * value.c (set_internalvar): Update.
 980         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
 981         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
 982         ATTRIBUTE_UNUSED_RESULT.
 983
 984 2019-03-05  Tom Tromey  <tromey@adacore.com>
 985
 986         * remote.c (class scoped_remote_fd) <release>: Add
 987         ATTRIBUTE_UNUSED_RESULT.
 988
 989 2019-03-05  Tom Tromey  <tromey@adacore.com>
 990
 991         * macroexp.c (struct macro_buffer) <release>: Add
 992         ATTRIBUTE_UNUSED_RESULT.
 993
 994 2019-03-05  Tom Tromey  <tromey@adacore.com>
 995
 996         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
 997         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
 998         ATTRIBUTE_UNUSED_RESULT.
 999
1000 2019-03-05  Tom Tromey  <tromey@adacore.com>
1001
1002         * common/scoped_fd.h (class scoped_fd) <release>: Add
1003         ATTRIBUTE_UNUSED_RESULT.
1004
1005 2019-03-05  Tom Tromey  <tromey@adacore.com>
1006
1007         * parser-defs.h (struct parser_state) <release>: Add
1008         ATTRIBUTE_UNUSED_RESULT.
1009
1010 2019-03-05  Tom Tromey  <tromey@adacore.com>
1011
1012         * utils.h (class gdb_argv) <release>: Add
1013         ATTRIBUTE_UNUSED_RESULT.
1014         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1015
1016 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1017
1018         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1019         for-loop range, to avoid compiler warnings.
1020
1021         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1022         avoid compiler warnings about unused variables.
1023
1024         * NEWS: Mention end of support for native debugging on MS-Windows
1025         before XP.
1026
1027         PR gdb/24292
1028         * common/netstuff.c:
1029         * gdbserver/gdbreplay.c
1030         * gdbserver/remote-utils.c:
1031         * ser-tcp.c:
1032         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1033         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1034         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1035         'getaddrinfo' and 'freeaddrinfo' were not available before
1036         Windows XP, and mingw.org's MinGW headers by default define
1037         _WIN32_WINNT to 0x500.
1038
1039 2019-03-01  Gary Benson <gbenson@redhat.com>
1040
1041         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1042
1043 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1044             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1045
1046         PR gdb/8527
1047         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1048         set_sigint_trap, clear_sigint_trap.
1049
1050 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1051
1052         * target.c (target_detach): Clear the regcache and the
1053         frame cache.
1054
1055 2019-02-27  Pedro Alves  <palves@redhat.com>
1056
1057         * utils.c (set_screen_size): When we cap the height/width sizes,
1058         tweak the corresponding command variable to show "unlimited":
1059
1060 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1061             Pedro Alves  <palves@redhat.com>
1062
1063         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1064         before calling rl_set_screen_size.
1065
1066 2019-02-27  Tom Tromey  <tromey@adacore.com>
1067
1068         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1069         define.
1070         * python/py-value.c: Remove Python 2.4 workaround.
1071         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1072         workaround.
1073         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1074         Python 2.4 workaround.
1075         * python/python-internal.h: Remove Python 2.4 comment.
1076         (Py_ssize_t): Don't define.
1077         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1078         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1079         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1080         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1081         * python/python.c (do_start_initialization): Remove Python 2.4
1082         workaround.
1083         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1084         (print_children): Remove Python 2.4 workaround.
1085         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1086         workaround.
1087         (CHARBUFFERPROC_NAME): Remove.
1088         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1089         Python 2.4 workaround.
1090
1091 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1092
1093         * NEWS: Note minimum Python version.
1094
1095 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1096
1097         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1098         code from these functions.  Remove corresponding ifdefs.  Use
1099         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1100         Remove gotos and target of gotos.
1101         (infpy_search_memory): Likewise.
1102
1103 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1104
1105         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1106         (hppa_gdbarch_init): Don't register deleted functions with
1107         gdbarch.
1108
1109 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1110
1111         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1112         (h8300_unwind_sp): Delete.
1113         (h8300_dummy_id): Delete.
1114         (h8300_gdbarch_init): Don't register deleted functions with
1115         gdbarch.
1116
1117 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1118
1119         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1120         (ft32_unwind_pc): Delete.
1121         (ft32_unwind_sp): Delete.
1122         (ft32_gdbarch_init): Don't register deleted functions with
1123         gdbarch.
1124
1125 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1126
1127         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1128         (frv_unwind_pc): Delete.
1129         (frv_unwind_sp): Delete.
1130         (frv_gdbarch_init): Don't register deleted functions with
1131         gdbarch.
1132
1133 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1134
1135         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1136         (riscv_unwind_pc): Delete.
1137         (riscv_unwind_sp): Delete.
1138         (riscv_gdbarch_init): Don't register deleted functions with
1139         gdbarch.
1140
1141 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1142
1143         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1144         (csky_unwind_pc): Delete.
1145         (csky_unwind_sp): Delete.
1146         (csky_gdbarch_init): Don't register deleted functions with
1147         gdbarch.
1148
1149 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1150
1151         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1152         (cris_unwind_pc): Delete.
1153         (cris_unwind_sp): Delete.
1154         (cris_gdbarch_init): Don't register deleted functions with
1155         gdbarch.
1156
1157 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1158
1159         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1160         (bfin_unwind_pc): Delete.
1161         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1162
1163 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1164
1165         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1166         (arm_unwind_pc): Delete.
1167         (arm_unwind_sp): Delete.
1168         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1169
1170 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1171
1172         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1173         (arc_unwind_pc): Delete.
1174         (arc_unwind_sp): Delete.
1175         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1176
1177 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1178
1179         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1180         (alpha_unwind_pc): Delete.
1181         (alpha_gdbarch_init): Don't register deleted functions with
1182         gdbarch.
1183
1184 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1185
1186         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1187         (aarch64_unwind_pc): Delete.
1188         (aarch64_unwind_sp): Delete.
1189         (aarch64_gdbarch_init): Don't register deleted functions with
1190         gdbarch.
1191
1192 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1193
1194         * gdbtypes.c (type_align): Don't consider static members when
1195         computing structure alignment.
1196
1197 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1198
1199         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1200         return 0 for other types.
1201         * arch-utils.c (default_type_align): Always return 0.
1202         * gdbarch.h: Regenerate.
1203         * gdbarch.sh (type_align): Extend comment.
1204         * gdbtypes.c (type_align): Add additional comments, always call
1205         gdbarch_type_align before applying the default rules.
1206         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1207         generic code will then apply a suitable default.
1208         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1209         types, return 0 for other types.
1210
1211 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1212
1213         * NEWS: Create a new section for the next release branch.
1214         Rename the section of the current branch, now that it has
1215         been cut.
1216
1217 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1218
1219         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1220         * version.in: Bump version to 8.3.50.DATE-git.
1221
1222 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1223
1224         * aix-thread.c (ptid_cmp): Remove unused variable.
1225         (get_signaled_thread): Likewise.
1226         (store_regs_user_thread): Likewise.
1227         (store_regs_kernel_thread): Likewise.
1228         (fetch_regs_kernel_thread): Remove shadowed variable.
1229
1230 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1231
1232         * features/riscv/32bit-cpu.xml: Add register numbers.
1233         * features/riscv/32bit-fpu.c: Regenerate.
1234         * features/riscv/32bit-fpu.xml: Add register numbers.
1235         * features/riscv/64bit-cpu.xml: Add register numbers.
1236         * features/riscv/64bit-fpu.c: Regenerate.
1237         * features/riscv/64bit-fpu.xml: Add register numbers.
1238
1239 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1240
1241         * NEWS: Mention two argument form of gdb.Value constructor.
1242         * python/py-value.c (convert_buffer_and_type_to_value): New
1243         function.
1244         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1245         Add support for handling an optional second argument.  Call
1246         convert_buffer_and_type_to_value as appropriate.
1247         * python/python-internal.h (Py_buffer_deleter): New struct.
1248         (Py_buffer_up): New typedef.
1249
1250 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1251
1252         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1253         instead of releasing ownership.
1254
1255 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1256
1257         * dwarf2read.c (open_and_init_dwp_file): Call
1258         elf_numsections instead of bfd_count_sections to initialize
1259         dwp_file->num_sections.
1260
1261 2019-02-25  Tom Tromey  <tromey@adacore.com>
1262
1263         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1264
1265 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1266
1267         * gcore.in: Add '--readnever' option when invoking GDB.
1268
1269 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1270
1271         * MAINTAINERS: Update my email address.
1272
1273 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1274
1275         * build-id.c (build_id_to_debug_bfd_1): New function.
1276         (build_id_to_debug_bfd): Look for separate debug file in
1277         sysroot.
1278
1279 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1280
1281         * gdbarch.sh: Update the copyright year range that is placed into
1282         generated files.
1283
1284 2019-02-22  Keith Seitz  <keiths@redhat.com>
1285
1286         PR symtab/23853
1287         * linespec.c (create_sals_line_offset): Search for the default
1288         symtab's filename instead of its fullname.
1289
1290 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1291
1292         * NEWS: Update style defaults.
1293
1294 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1295
1296         * main.c (captured_main_1): Disable styling in batch mode.
1297
1298 2019-02-20  Tom Tromey  <tom@tromey.com>
1299
1300         * symtab.c (symtab_symbol_info): Fix typos.
1301
1302 2019-02-20  Tom Tromey  <tromey@adacore.com>
1303
1304         * findcmd.c (_initialize_mem_search): Use upper case for
1305         metasyntactic variables.
1306
1307 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1308
1309         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1310         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1311
1312 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1313
1314         * top.h (source_file_name): Change to std::string.
1315         * top.c (source_file_name): Likewise.
1316         (command_line_input): Adjust.
1317         * cli/cli-script.c (script_from_file): Adjust.
1318
1319 2019-02-19  Tom Tromey  <tromey@adacore.com>
1320
1321         * ravenscar-thread.c
1322         (ravenscar_thread_target::update_thread_list): Don't call
1323         ada_build_task_list.
1324         * ada-lang.h (ada_build_task_list): Don't declare.
1325         * ada-tasks.c (struct ada_tasks_inferior_data)
1326         <task_list_valid_p>: Now bool.
1327         (read_known_tasks, ada_task_list_changed)
1328         (ada_tasks_invalidate_inferior_data): Update.
1329         (read_known_tasks_array): Return bool.
1330         (read_known_tasks_list): Likewise.
1331         (read_known_tasks): Return void.
1332         (ada_build_task_list): Now static.
1333
1334 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1335
1336         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1337         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1338
1339 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1340
1341         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1342         variant for ada_tasks_pspace_data_handle and
1343         ada_tasks_inferior_data_handle.
1344         (ada_tasks_pspace_data_cleanup): New function.
1345         (ada_tasks_inferior_data_cleanup): New function.
1346
1347 2019-02-17  Tom Tromey  <tom@tromey.com>
1348
1349         * macrotab.h (macro_source_fullname): Return a std::string.
1350         * macrotab.c (macro_include, check_for_redefinition)
1351         (macro_undef, macro_lookup_definition, foreach_macro)
1352         (foreach_macro_in_scope): Update.
1353         (macro_source_fullname): Return a std::string.
1354         * macrocmd.c (show_pp_source_pos): Update.
1355
1356 2019-02-17  Tom Tromey  <tom@tromey.com>
1357
1358         * macrocmd.c (show_pp_source_pos): Style the file names.
1359
1360 2019-02-17  Tom Tromey  <tom@tromey.com>
1361
1362         PR tui/24197:
1363         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1364
1365 2019-02-17  Tom Tromey  <tom@tromey.com>
1366
1367         * ada-lang.c (user_select_syms): Use filtered printing.
1368         * utils.c (wrap_style): New global.
1369         (desired_style): Remove.
1370         (emit_style_escape): Add stream parameter.
1371         (set_output_style, reset_terminal_style, prompt_for_continue):
1372         Update.
1373         (flush_wrap_buffer): Only flush gdb_stdout.
1374         (wrap_here): Set wrap_style.
1375         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1376         treat escape sequences as a character.  Change when wrap buffer is
1377         flushed.
1378         (fputs_styled): Do not set the output style when the default is
1379         requested.
1380         * ui-style.h (struct ui_file_style) <is_default>: New method.
1381         * source.c (print_source_lines_base): Emit escape sequences in one
1382         piece.
1383
1384 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1385
1386         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1387         integers and enumeration types.
1388
1389 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1390
1391         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1392         instead of lookup_symbol_in_language
1393         (do_exact_match): New function.
1394         (ada_get_symbol_name_matcher): Return do_exact_match when
1395         doing a verbatim match.
1396
1397 2019-02-15  Tom Tromey  <tromey@adacore.com>
1398
1399         * ravenscar-thread.c (ravenscar_thread_target::resume)
1400         (ravenscar_thread_target::wait): Special case wildcard requests.
1401
1402 2019-02-15  Tom Tromey  <tromey@adacore.com>
1403
1404         * ravenscar-thread.c (base_ptid): Remove.
1405         (struct ravenscar_thread_target) <close>: New method.
1406         <m_base_ptid>: New member.
1407         <update_inferior_ptid, active_task, task_is_currently_active,
1408         runtime_initialized>: Declare methods.
1409         <ravenscar_thread_target>: Add constructor.
1410         (ravenscar_thread_target::task_is_currently_active)
1411         (ravenscar_thread_target::update_inferior_ptid)
1412         (ravenscar_runtime_initialized): Rename.  Now methods.
1413         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1414         (ravenscar_thread_target::update_thread_list): Update.
1415         (ravenscar_thread_target::active_task): Now method.
1416         (ravenscar_thread_target::store_registers)
1417         (ravenscar_thread_target::prepare_to_store)
1418         (ravenscar_thread_target::prepare_to_store)
1419         (ravenscar_thread_target::mourn_inferior): Update.
1420         (ravenscar_inferior_created): Use "new" to create target.
1421         (ravenscar_thread_target::get_ada_task_ptid): Update.
1422         (_initialize_ravenscar): Don't initialize base_ptid.
1423         (ravenscar_ops): Remove global.
1424
1425 2019-02-15  Tom Tromey  <tromey@adacore.com>
1426
1427         * target.h (push_target): Declare new overload.
1428         * target.c (push_target): New overload, taking an rvalue reference.
1429         * remote.c (remote_target::open_1): Use push_target overload.
1430         * corelow.c (core_target_open): Use push_target overload.
1431
1432 2019-02-15  Tom Tromey  <tromey@adacore.com>
1433
1434         * ravenscar-thread.c (is_ravenscar_task)
1435         (ravenscar_task_is_currently_active): Return bool.
1436         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1437         (_initialize_ravenscar): Remove "(void)".
1438         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1439         Return bool.
1440
1441 2019-02-15  Tom Tromey  <tromey@adacore.com>
1442
1443         * ravenscar-thread.c (ravenscar_runtime_initializer)
1444         (has_ravenscar_runtime, get_running_thread_id)
1445         (ravenscar_thread_target::resume): Fix indentation.
1446
1447 2019-02-15  Tom Tromey  <tromey@adacore.com>
1448
1449         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1450         from ravenscar_arch_ops.
1451         (sparc_ravenscar_ops::fetch_registers)
1452         (sparc_ravenscar_ops::store_registers): Now methods.
1453         (sparc_ravenscar_prepare_to_store): Remove.
1454         (sparc_ravenscar_ops): Redefine.
1455         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1456         methods and destructor.  Remove members.
1457         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1458         (ravenscar_thread_target::store_registers)
1459         (ravenscar_thread_target::prepare_to_store): Update.
1460         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1461         Remove.
1462         (struct ppc_ravenscar_powerpc_ops): Derive from
1463         ravenscar_arch_ops.
1464         (ppc_ravenscar_powerpc_ops::fetch_registers)
1465         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1466         (ppc_ravenscar_powerpc_ops): Redefine.
1467         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1468         (ppc_ravenscar_e500_ops::fetch_registers)
1469         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1470         (ppc_ravenscar_e500_ops): Redefine.
1471         * aarch64-ravenscar-thread.c
1472         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1473         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1474         (aarch64_ravenscar_fetch_registers)
1475         (aarch64_ravenscar_store_registers): Now methods.
1476         (aarch64_ravenscar_ops): Redefine.
1477
1478 2019-02-15  Tom Tromey  <tromey@adacore.com>
1479
1480         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1481         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1482         (ravenscar_thread_target::stopped_by_watchpoint)
1483         (ravenscar_thread_target::stopped_data_address)
1484         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1485
1486 2019-02-15  Tom Tromey  <tromey@adacore.com>
1487
1488         * ravenscar-thread.c: Fix some typos.
1489
1490 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1491             Tom Tromey  <tromey@adacore.com>
1492
1493         * ada-lang.c (ada_exception_sal): Change addr_string to a
1494         std::string.
1495         (create_ada_exception_catchpoint): Update.
1496
1497 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1498             Tom Tromey  <tromey@adacore.com>
1499
1500         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1501         (bp_location_ops): Remove.
1502         (base_breakpoint_allocate_location): Update.
1503         (free_bp_location): Update.
1504         * ada-lang.c (class ada_catchpoint_location)
1505         <ada_catchpoint_location>: Remove ops parameter.
1506         (ada_catchpoint_location_dtor): Remove.
1507         (ada_catchpoint_location_ops): Remove.
1508         (allocate_location_exception): Update.
1509         * breakpoint.h (struct bp_location_ops): Remove.
1510         (class bp_location) <bp_location>: Remove bp_location_ops
1511         parameter.
1512         <~bp_location>: Add destructor.
1513         <ops>: Remove.
1514
1515 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1516             Pedro Alves  <palves@redhat.com>
1517
1518         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1519         'PATH_MAX'.
1520
1521 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1522             Samuel Thibault  <samuel.thibault@gnu.org>
1523             Thomas Schwinge  <thomas@codesourcery.com>
1524
1525         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1526         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1527
1528 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1529
1530         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1531         (check_empty): Use "const char *".
1532
1533         * gnu-nat.c (gnu_nat_target::detach): Instead of
1534         'detach_inferior (pid)' call
1535         'detach_inferior (find_inferior_pid (pid))'.
1536
1537         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1538         'nat/fork-inferior.o'.
1539         * gnu-nat.c: #include "nat/fork-inferior.h".
1540
1541         * gnu-nat.c (gnu_nat_target::detach): Instead of
1542         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1543         * gnu-nat.h: #include "inf-child.h".
1544         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1545         'i386_gnu_nat_target::fetch_registers'.
1546         (gnu_store_registers): Rename/move to
1547         'i386_gnu_nat_target::store_registers'.
1548
1549         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1550         * gnu-nat.h (mach_thread_info): New function.
1551         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1552
1553         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1554
1555 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1556
1557         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1558
1559 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1560
1561         * windows-nat.c (windows_add_thread): Add new parameter
1562         "main_thread_p" with default value set to false.  Update
1563         function documentation as well as all callers.
1564         (windows_delete_thread): Likewise.
1565         (fake_create_process): Update call to windows_add_thread.
1566         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1567         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1568         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1569         call to windows_delete_thread.
1570
1571 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1572
1573         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1574
1575 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1576
1577         * symfile.c (find_separate_debug_file): Use canonical path of
1578         sysroot with child_path instead of gdb_sysroot if it is valid.
1579
1580 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1581
1582         * symfile.c (find_separate_debug_file): Use child_path to
1583         determine if an object file is under a sysroot.
1584
1585 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1586
1587         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1588         unittests/child-path-selftests.c.
1589         * common/pathstuff.c (child_path): New function.
1590         * common/pathstuff.h (child_path): New prototype.
1591         * unittests/child-path-selftests.c: New file.
1592
1593 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1594
1595         * symfile.c (find_separate_debug_file): Look for separate debug
1596         files in debug directories under the sysroot.
1597
1598 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1599
1600         * symtab.h (struct minimal_symbol data_p): New const method.
1601         (struct minimal_symbol text_p): Likewise.
1602         * symtab.c (output_source_filename): Use file name style
1603         to print file name.
1604         (print_symbol_info): Likewise.
1605         (print_msymbol_info): Use address style to print addresses.
1606         Use function name style to print executable text symbols.
1607         (expand_symtab_containing_pc): Use data_p.
1608         (find_pc_sect_compunit_symtab): Likewise.
1609
1610 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1611
1612         * breakpoint.c (describe_other_breakpoints): Use address style
1613         to print addresses.
1614         (say_where): Likewise.
1615
1616 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1617
1618         * ada-typeprint.c (print_func_type): Print function name
1619         style to print function name.
1620         * c-typeprint.c (c_print_type_1): Likewise.
1621
1622 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1623
1624         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1625         for execve.
1626
1627 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1628
1629         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1630         type_stack.
1631
1632 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1633
1634         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1635         TYPE_CODE_REF types.
1636
1637 2019-02-08  Jim Wilson  <jimw@sifive.com>
1638
1639         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1640         (riscv_linux_fregset): New.
1641         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1642
1643 2019-02-07  Tom Tromey  <tom@tromey.com>
1644
1645         * thread.c (thread_cancel_execution_command): Update.
1646         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1647         methods.
1648         (struct thread_fsm_ops): Remove.
1649         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1650         (thread_fsm_should_stop, thread_fsm_return_value)
1651         (thread_fsm_set_finished, thread_fsm_finished_p)
1652         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1653         Don't declare.
1654         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1655         * infrun.c (clear_proceed_status_thread)
1656         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1657         (print_stop_event): Update.
1658         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1659         Add constructor.
1660         (step_command_fsm_ops): Remove.
1661         (new_step_command_fsm): Remove.
1662         (step_1): Update.
1663         (step_command_fsm::should_stop): Rename from
1664         step_command_fsm_should_stop.
1665         (step_command_fsm::clean_up): Rename from
1666         step_command_fsm_clean_up.
1667         (step_command_fsm::do_async_reply_reason): Rename from
1668         step_command_fsm_async_reply_reason.
1669         (struct until_next_fsm): Inherit from thread_fsm.  Add
1670         constructor.
1671         (until_next_fsm_ops): Remove.
1672         (new_until_next_fsm): Remove.
1673         (until_next_fsm::should_stop): Rename from
1674         until_next_fsm_should_stop.
1675         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1676         (until_next_fsm::do_async_reply_reason): Rename from
1677         until_next_fsm_async_reply_reason.
1678         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1679         constructor.  Change type of breakpoint.
1680         (finish_command_fsm_ops): Remove.
1681         (new_finish_command_fsm): Remove.
1682         (finish_command_fsm::should_stop): Rename from
1683         finish_command_fsm_should_stop.
1684         (finish_command_fsm::clean_up): Rename from
1685         finish_command_fsm_clean_up.
1686         (finish_command_fsm::return_value): Rename from
1687         finish_command_fsm_return_value.
1688         (finish_command_fsm::do_async_reply_reason): Rename from
1689         finish_command_fsm_async_reply_reason.
1690         (finish_command): Update.
1691         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1692         Add constructor.
1693         (call_thread_fsm_ops): Remove.
1694         (call_thread_fsm::call_thread_fsm): Rename from
1695         new_call_thread_fsm.
1696         (call_thread_fsm::should_stop): Rename from
1697         call_thread_fsm_should_stop.
1698         (call_thread_fsm::should_notify_stop): Rename from
1699         call_thread_fsm_should_notify_stop.
1700         (run_inferior_call, call_function_by_hand_dummy): Update.
1701         * cli/cli-interp.c (should_print_stop_to_console): Update.
1702         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1703         Add constructor.  Change type of location_breakpoint,
1704         caller_breakpoint.
1705         (until_break_fsm_ops): Remove.
1706         (new_until_break_fsm): Remove.
1707         (until_break_fsm::should_stop): Rename from
1708         until_break_fsm_should_stop.
1709         (until_break_fsm::clean_up): Rename from
1710         until_break_fsm_clean_up.
1711         (until_break_fsm::do_async_reply_reason): Rename from
1712         until_break_fsm_async_reply_reason.
1713         (until_break_command): Update.
1714         * thread-fsm.c: Remove.
1715         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1716
1717 2019-02-07  Tom Tromey  <tom@tromey.com>
1718
1719         * yy-remap.h: Add include guard.
1720         * xtensa-tdep.h: Add include guard.
1721         * xcoffread.h: Rename include guard.
1722         * varobj-iter.h: Add include guard.
1723         * tui/tui.h: Rename include guard.
1724         * tui/tui-winsource.h: Rename include guard.
1725         * tui/tui-wingeneral.h: Rename include guard.
1726         * tui/tui-windata.h: Rename include guard.
1727         * tui/tui-win.h: Rename include guard.
1728         * tui/tui-stack.h: Rename include guard.
1729         * tui/tui-source.h: Rename include guard.
1730         * tui/tui-regs.h: Rename include guard.
1731         * tui/tui-out.h: Rename include guard.
1732         * tui/tui-layout.h: Rename include guard.
1733         * tui/tui-io.h: Rename include guard.
1734         * tui/tui-hooks.h: Rename include guard.
1735         * tui/tui-file.h: Rename include guard.
1736         * tui/tui-disasm.h: Rename include guard.
1737         * tui/tui-data.h: Rename include guard.
1738         * tui/tui-command.h: Rename include guard.
1739         * tic6x-tdep.h: Add include guard.
1740         * target/waitstatus.h: Rename include guard.
1741         * target/wait.h: Rename include guard.
1742         * target/target.h: Rename include guard.
1743         * target/resume.h: Rename include guard.
1744         * target-float.h: Rename include guard.
1745         * stabsread.h: Add include guard.
1746         * rs6000-tdep.h: Add include guard.
1747         * riscv-fbsd-tdep.h: Add include guard.
1748         * regformats/regdef.h: Rename include guard.
1749         * record.h: Rename include guard.
1750         * python/python.h: Rename include guard.
1751         * python/python-internal.h: Rename include guard.
1752         * python/py-stopevent.h: Rename include guard.
1753         * python/py-ref.h: Rename include guard.
1754         * python/py-record.h: Rename include guard.
1755         * python/py-record-full.h: Rename include guard.
1756         * python/py-record-btrace.h: Rename include guard.
1757         * python/py-instruction.h: Rename include guard.
1758         * python/py-events.h: Rename include guard.
1759         * python/py-event.h: Rename include guard.
1760         * procfs.h: Add include guard.
1761         * proc-utils.h: Add include guard.
1762         * p-lang.h: Add include guard.
1763         * or1k-tdep.h: Rename include guard.
1764         * observable.h: Rename include guard.
1765         * nto-tdep.h: Rename include guard.
1766         * nat/x86-linux.h: Rename include guard.
1767         * nat/x86-linux-dregs.h: Rename include guard.
1768         * nat/x86-gcc-cpuid.h: Add include guard.
1769         * nat/x86-dregs.h: Rename include guard.
1770         * nat/x86-cpuid.h: Rename include guard.
1771         * nat/ppc-linux.h: Rename include guard.
1772         * nat/mips-linux-watch.h: Rename include guard.
1773         * nat/linux-waitpid.h: Rename include guard.
1774         * nat/linux-ptrace.h: Rename include guard.
1775         * nat/linux-procfs.h: Rename include guard.
1776         * nat/linux-osdata.h: Rename include guard.
1777         * nat/linux-nat.h: Rename include guard.
1778         * nat/linux-namespaces.h: Rename include guard.
1779         * nat/linux-btrace.h: Rename include guard.
1780         * nat/glibc_thread_db.h: Rename include guard.
1781         * nat/gdb_thread_db.h: Rename include guard.
1782         * nat/gdb_ptrace.h: Rename include guard.
1783         * nat/fork-inferior.h: Rename include guard.
1784         * nat/amd64-linux-siginfo.h: Rename include guard.
1785         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1786         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1787         * nat/aarch64-linux.h: Rename include guard.
1788         * nat/aarch64-linux-hw-point.h: Rename include guard.
1789         * mn10300-tdep.h: Add include guard.
1790         * mips-linux-tdep.h: Add include guard.
1791         * mi/mi-parse.h: Rename include guard.
1792         * mi/mi-out.h: Rename include guard.
1793         * mi/mi-main.h: Rename include guard.
1794         * mi/mi-interp.h: Rename include guard.
1795         * mi/mi-getopt.h: Rename include guard.
1796         * mi/mi-console.h: Rename include guard.
1797         * mi/mi-common.h: Rename include guard.
1798         * mi/mi-cmds.h: Rename include guard.
1799         * mi/mi-cmd-break.h: Rename include guard.
1800         * m2-lang.h: Add include guard.
1801         * location.h: Rename include guard.
1802         * linux-record.h: Rename include guard.
1803         * linux-nat.h: Add include guard.
1804         * linux-fork.h: Add include guard.
1805         * i386-darwin-tdep.h: Rename include guard.
1806         * hppa-linux-offsets.h: Add include guard.
1807         * guile/guile.h: Rename include guard.
1808         * guile/guile-internal.h: Rename include guard.
1809         * gnu-nat.h: Rename include guard.
1810         * gdb-stabs.h: Rename include guard.
1811         * frv-tdep.h: Add include guard.
1812         * f-lang.h: Add include guard.
1813         * event-loop.h: Add include guard.
1814         * darwin-nat.h: Rename include guard.
1815         * cp-abi.h: Rename include guard.
1816         * config/sparc/nm-sol2.h: Rename include guard.
1817         * config/nm-nto.h: Rename include guard.
1818         * config/nm-linux.h: Add include guard.
1819         * config/i386/nm-i386gnu.h: Rename include guard.
1820         * config/djgpp/nl_types.h: Rename include guard.
1821         * config/djgpp/langinfo.h: Rename include guard.
1822         * compile/gcc-cp-plugin.h: Add include guard.
1823         * compile/gcc-c-plugin.h: Add include guard.
1824         * compile/compile.h: Rename include guard.
1825         * compile/compile-object-run.h: Rename include guard.
1826         * compile/compile-object-load.h: Rename include guard.
1827         * compile/compile-internal.h: Rename include guard.
1828         * compile/compile-cplus.h: Rename include guard.
1829         * compile/compile-c.h: Rename include guard.
1830         * common/xml-utils.h: Rename include guard.
1831         * common/x86-xstate.h: Rename include guard.
1832         * common/version.h: Rename include guard.
1833         * common/vec.h: Rename include guard.
1834         * common/tdesc.h: Rename include guard.
1835         * common/selftest.h: Rename include guard.
1836         * common/scoped_restore.h: Rename include guard.
1837         * common/scoped_mmap.h: Rename include guard.
1838         * common/scoped_fd.h: Rename include guard.
1839         * common/safe-iterator.h: Rename include guard.
1840         * common/run-time-clock.h: Rename include guard.
1841         * common/refcounted-object.h: Rename include guard.
1842         * common/queue.h: Rename include guard.
1843         * common/ptid.h: Rename include guard.
1844         * common/print-utils.h: Rename include guard.
1845         * common/preprocessor.h: Rename include guard.
1846         * common/pathstuff.h: Rename include guard.
1847         * common/observable.h: Rename include guard.
1848         * common/netstuff.h: Rename include guard.
1849         * common/job-control.h: Rename include guard.
1850         * common/host-defs.h: Rename include guard.
1851         * common/gdb_wait.h: Rename include guard.
1852         * common/gdb_vecs.h: Rename include guard.
1853         * common/gdb_unlinker.h: Rename include guard.
1854         * common/gdb_unique_ptr.h: Rename include guard.
1855         * common/gdb_tilde_expand.h: Rename include guard.
1856         * common/gdb_sys_time.h: Rename include guard.
1857         * common/gdb_string_view.h: Rename include guard.
1858         * common/gdb_splay_tree.h: Rename include guard.
1859         * common/gdb_setjmp.h: Rename include guard.
1860         * common/gdb_ref_ptr.h: Rename include guard.
1861         * common/gdb_optional.h: Rename include guard.
1862         * common/gdb_locale.h: Rename include guard.
1863         * common/gdb_assert.h: Rename include guard.
1864         * common/filtered-iterator.h: Rename include guard.
1865         * common/filestuff.h: Rename include guard.
1866         * common/fileio.h: Rename include guard.
1867         * common/environ.h: Rename include guard.
1868         * common/common-utils.h: Rename include guard.
1869         * common/common-types.h: Rename include guard.
1870         * common/common-regcache.h: Rename include guard.
1871         * common/common-inferior.h: Rename include guard.
1872         * common/common-gdbthread.h: Rename include guard.
1873         * common/common-exceptions.h: Rename include guard.
1874         * common/common-defs.h: Rename include guard.
1875         * common/common-debug.h: Rename include guard.
1876         * common/cleanups.h: Rename include guard.
1877         * common/buffer.h: Rename include guard.
1878         * common/btrace-common.h: Rename include guard.
1879         * common/break-common.h: Rename include guard.
1880         * cli/cli-utils.h: Rename include guard.
1881         * cli/cli-style.h: Rename include guard.
1882         * cli/cli-setshow.h: Rename include guard.
1883         * cli/cli-script.h: Rename include guard.
1884         * cli/cli-interp.h: Rename include guard.
1885         * cli/cli-decode.h: Rename include guard.
1886         * cli/cli-cmds.h: Rename include guard.
1887         * charset-list.h: Add include guard.
1888         * buildsym-legacy.h: Rename include guard.
1889         * bfin-tdep.h: Add include guard.
1890         * ax.h: Rename include guard.
1891         * arm-linux-tdep.h: Add include guard.
1892         * arm-fbsd-tdep.h: Add include guard.
1893         * arch/xtensa.h: Rename include guard.
1894         * arch/tic6x.h: Add include guard.
1895         * arch/i386.h: Add include guard.
1896         * arch/arm.h: Rename include guard.
1897         * arch/arm-linux.h: Rename include guard.
1898         * arch/arm-get-next-pcs.h: Rename include guard.
1899         * arch/amd64.h: Add include guard.
1900         * arch/aarch64-insn.h: Rename include guard.
1901         * arch-utils.h: Rename include guard.
1902         * annotate.h: Add include guard.
1903         * amd64-darwin-tdep.h: Rename include guard.
1904         * aarch64-linux-tdep.h: Add include guard.
1905         * aarch64-fbsd-tdep.h: Add include guard.
1906         * aarch32-linux-nat.h: Add include guard.
1907
1908 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1909
1910         * macrotab.c (macro_define_internal): New function that
1911         factorizes macro_define_object_internal and macro_define_function
1912         code.
1913         (macro_define_object_internal): Use macro_define_internal.
1914         (macro_define_function): Likewise.
1915
1916 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1917
1918         * macrocmd.c (extract_identifier): Return
1919         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1920         callers.
1921
1922 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1923
1924         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1925
1926 2019-02-05  Tom Tromey  <tom@tromey.com>
1927
1928         * target.c (target_stack::unpush): Move assertion earlier.
1929
1930 2019-01-30  Tom Tromey  <tom@tromey.com>
1931
1932         PR python/23615:
1933         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1934         (gdbpy_parse_and_eval): Likewise.
1935         * python/python-internal.h (gdbpy_allow_threads): New class.
1936
1937 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1938
1939         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1940         (aarch64_fbsd_fpregmap): Move earlier.
1941         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1942         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1943         instead of individual calls to trad_frame_set_reg_addr.
1944         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1945         earlier.
1946         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1947         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1948         instead of individual calls to trad_frame_set_reg_addr.
1949
1950 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
1951
1952         * CONTRIBUTE: Replace contribution list with wiki link.
1953
1954 2019-01-25  Tom Tromey  <tom@tromey.com>
1955
1956         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
1957
1958 2019-01-25  Tom Tromey  <tom@tromey.com>
1959
1960         * xtensa-linux-nat.c: Fix common/ includes.
1961         * xml-support.h: Fix common/ includes.
1962         * xml-support.c: Fix common/ includes.
1963         * x86-linux-nat.c: Fix common/ includes.
1964         * windows-nat.c: Fix common/ includes.
1965         * varobj.h: Fix common/ includes.
1966         * varobj.c: Fix common/ includes.
1967         * value.c: Fix common/ includes.
1968         * valops.c: Fix common/ includes.
1969         * utils.c: Fix common/ includes.
1970         * unittests/xml-utils-selftests.c: Fix common/ includes.
1971         * unittests/utils-selftests.c: Fix common/ includes.
1972         * unittests/unpack-selftests.c: Fix common/ includes.
1973         * unittests/tracepoint-selftests.c: Fix common/ includes.
1974         * unittests/style-selftests.c: Fix common/ includes.
1975         * unittests/string_view-selftests.c: Fix common/ includes.
1976         * unittests/scoped_restore-selftests.c: Fix common/ includes.
1977         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
1978         * unittests/scoped_fd-selftests.c: Fix common/ includes.
1979         * unittests/rsp-low-selftests.c: Fix common/ includes.
1980         * unittests/parse-connection-spec-selftests.c: Fix common/
1981         includes.
1982         * unittests/optional-selftests.c: Fix common/ includes.
1983         * unittests/offset-type-selftests.c: Fix common/ includes.
1984         * unittests/observable-selftests.c: Fix common/ includes.
1985         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
1986         * unittests/memrange-selftests.c: Fix common/ includes.
1987         * unittests/memory-map-selftests.c: Fix common/ includes.
1988         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
1989         * unittests/function-view-selftests.c: Fix common/ includes.
1990         * unittests/environ-selftests.c: Fix common/ includes.
1991         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
1992         * unittests/common-utils-selftests.c: Fix common/ includes.
1993         * unittests/cli-utils-selftests.c: Fix common/ includes.
1994         * unittests/array-view-selftests.c: Fix common/ includes.
1995         * ui-file.c: Fix common/ includes.
1996         * tui/tui-io.c: Fix common/ includes.
1997         * tracepoint.h: Fix common/ includes.
1998         * tracepoint.c: Fix common/ includes.
1999         * tracefile-tfile.c: Fix common/ includes.
2000         * top.h: Fix common/ includes.
2001         * top.c: Fix common/ includes.
2002         * thread.c: Fix common/ includes.
2003         * target/waitstatus.h: Fix common/ includes.
2004         * target/waitstatus.c: Fix common/ includes.
2005         * target.h: Fix common/ includes.
2006         * target.c: Fix common/ includes.
2007         * target-memory.c: Fix common/ includes.
2008         * target-descriptions.c: Fix common/ includes.
2009         * symtab.h: Fix common/ includes.
2010         * symfile.c: Fix common/ includes.
2011         * stap-probe.c: Fix common/ includes.
2012         * spu-linux-nat.c: Fix common/ includes.
2013         * sparc-nat.c: Fix common/ includes.
2014         * source.c: Fix common/ includes.
2015         * solib.c: Fix common/ includes.
2016         * solib-target.c: Fix common/ includes.
2017         * ser-unix.c: Fix common/ includes.
2018         * ser-tcp.c: Fix common/ includes.
2019         * ser-pipe.c: Fix common/ includes.
2020         * ser-base.c: Fix common/ includes.
2021         * selftest-arch.c: Fix common/ includes.
2022         * s12z-tdep.c: Fix common/ includes.
2023         * rust-exp.y: Fix common/ includes.
2024         * rs6000-aix-tdep.c: Fix common/ includes.
2025         * riscv-tdep.c: Fix common/ includes.
2026         * remote.c: Fix common/ includes.
2027         * remote-notif.h: Fix common/ includes.
2028         * remote-fileio.h: Fix common/ includes.
2029         * remote-fileio.c: Fix common/ includes.
2030         * regcache.h: Fix common/ includes.
2031         * regcache.c: Fix common/ includes.
2032         * record-btrace.c: Fix common/ includes.
2033         * python/python.c: Fix common/ includes.
2034         * python/py-type.c: Fix common/ includes.
2035         * python/py-inferior.c: Fix common/ includes.
2036         * progspace.h: Fix common/ includes.
2037         * producer.c: Fix common/ includes.
2038         * procfs.c: Fix common/ includes.
2039         * proc-api.c: Fix common/ includes.
2040         * printcmd.c: Fix common/ includes.
2041         * ppc-linux-nat.c: Fix common/ includes.
2042         * parser-defs.h: Fix common/ includes.
2043         * osdata.c: Fix common/ includes.
2044         * obsd-nat.c: Fix common/ includes.
2045         * nat/x86-linux.c: Fix common/ includes.
2046         * nat/x86-linux-dregs.c: Fix common/ includes.
2047         * nat/x86-dregs.h: Fix common/ includes.
2048         * nat/x86-dregs.c: Fix common/ includes.
2049         * nat/ppc-linux.c: Fix common/ includes.
2050         * nat/mips-linux-watch.h: Fix common/ includes.
2051         * nat/mips-linux-watch.c: Fix common/ includes.
2052         * nat/linux-waitpid.c: Fix common/ includes.
2053         * nat/linux-ptrace.h: Fix common/ includes.
2054         * nat/linux-ptrace.c: Fix common/ includes.
2055         * nat/linux-procfs.c: Fix common/ includes.
2056         * nat/linux-personality.c: Fix common/ includes.
2057         * nat/linux-osdata.c: Fix common/ includes.
2058         * nat/linux-namespaces.c: Fix common/ includes.
2059         * nat/linux-btrace.h: Fix common/ includes.
2060         * nat/linux-btrace.c: Fix common/ includes.
2061         * nat/fork-inferior.c: Fix common/ includes.
2062         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2063         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2064         * nat/aarch64-linux.c: Fix common/ includes.
2065         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2066         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2067         * namespace.h: Fix common/ includes.
2068         * mips-linux-tdep.c: Fix common/ includes.
2069         * minsyms.c: Fix common/ includes.
2070         * mi/mi-parse.h: Fix common/ includes.
2071         * mi/mi-main.c: Fix common/ includes.
2072         * mi/mi-cmd-env.c: Fix common/ includes.
2073         * memrange.h: Fix common/ includes.
2074         * memattr.c: Fix common/ includes.
2075         * maint.h: Fix common/ includes.
2076         * maint.c: Fix common/ includes.
2077         * main.c: Fix common/ includes.
2078         * machoread.c: Fix common/ includes.
2079         * location.c: Fix common/ includes.
2080         * linux-thread-db.c: Fix common/ includes.
2081         * linux-nat.c: Fix common/ includes.
2082         * linux-fork.c: Fix common/ includes.
2083         * inline-frame.c: Fix common/ includes.
2084         * infrun.c: Fix common/ includes.
2085         * inflow.c: Fix common/ includes.
2086         * inferior.h: Fix common/ includes.
2087         * inferior.c: Fix common/ includes.
2088         * infcmd.c: Fix common/ includes.
2089         * inf-ptrace.c: Fix common/ includes.
2090         * inf-child.c: Fix common/ includes.
2091         * ia64-linux-nat.c: Fix common/ includes.
2092         * i387-tdep.c: Fix common/ includes.
2093         * i386-tdep.c: Fix common/ includes.
2094         * i386-linux-tdep.c: Fix common/ includes.
2095         * i386-linux-nat.c: Fix common/ includes.
2096         * i386-go32-tdep.c: Fix common/ includes.
2097         * i386-fbsd-tdep.c: Fix common/ includes.
2098         * i386-fbsd-nat.c: Fix common/ includes.
2099         * guile/scm-type.c: Fix common/ includes.
2100         * guile/guile.c: Fix common/ includes.
2101         * go32-nat.c: Fix common/ includes.
2102         * gnu-nat.c: Fix common/ includes.
2103         * gdbthread.h: Fix common/ includes.
2104         * gdbarch-selftests.c: Fix common/ includes.
2105         * gdb_usleep.c: Fix common/ includes.
2106         * gdb_select.h: Fix common/ includes.
2107         * gdb_bfd.c: Fix common/ includes.
2108         * gcore.c: Fix common/ includes.
2109         * fork-child.c: Fix common/ includes.
2110         * findvar.c: Fix common/ includes.
2111         * fbsd-nat.c: Fix common/ includes.
2112         * event-top.c: Fix common/ includes.
2113         * event-loop.c: Fix common/ includes.
2114         * dwarf2read.c: Fix common/ includes.
2115         * dwarf2loc.c: Fix common/ includes.
2116         * dwarf2-frame.c: Fix common/ includes.
2117         * dwarf-index-cache.c: Fix common/ includes.
2118         * dtrace-probe.c: Fix common/ includes.
2119         * disasm-selftests.c: Fix common/ includes.
2120         * defs.h: Fix common/ includes.
2121         * csky-tdep.c: Fix common/ includes.
2122         * cp-valprint.c: Fix common/ includes.
2123         * cp-support.h: Fix common/ includes.
2124         * cp-support.c: Fix common/ includes.
2125         * corelow.c: Fix common/ includes.
2126         * completer.h: Fix common/ includes.
2127         * completer.c: Fix common/ includes.
2128         * compile/compile.c: Fix common/ includes.
2129         * compile/compile-loc2c.c: Fix common/ includes.
2130         * compile/compile-cplus-types.c: Fix common/ includes.
2131         * compile/compile-cplus-symbols.c: Fix common/ includes.
2132         * command.h: Fix common/ includes.
2133         * cli/cli-dump.c: Fix common/ includes.
2134         * cli/cli-cmds.c: Fix common/ includes.
2135         * charset.c: Fix common/ includes.
2136         * build-id.c: Fix common/ includes.
2137         * btrace.h: Fix common/ includes.
2138         * btrace.c: Fix common/ includes.
2139         * breakpoint.h: Fix common/ includes.
2140         * breakpoint.c: Fix common/ includes.
2141         * ax.h:
2142         (enum agent_op): Fix common/ includes.
2143         * ax-general.c (struct aop_map): Fix common/ includes.
2144         * ax-gdb.c: Fix common/ includes.
2145         * auxv.c: Fix common/ includes.
2146         * auto-load.c: Fix common/ includes.
2147         * arm-tdep.c: Fix common/ includes.
2148         * arch/riscv.c: Fix common/ includes.
2149         * arch/ppc-linux-common.c: Fix common/ includes.
2150         * arch/i386.c: Fix common/ includes.
2151         * arch/arm.c: Fix common/ includes.
2152         * arch/arm-linux.c: Fix common/ includes.
2153         * arch/arm-get-next-pcs.c: Fix common/ includes.
2154         * arch/amd64.c: Fix common/ includes.
2155         * arch/aarch64.c: Fix common/ includes.
2156         * arch/aarch64-insn.c: Fix common/ includes.
2157         * arch-utils.c: Fix common/ includes.
2158         * amd64-windows-tdep.c: Fix common/ includes.
2159         * amd64-tdep.c: Fix common/ includes.
2160         * amd64-sol2-tdep.c: Fix common/ includes.
2161         * amd64-obsd-tdep.c: Fix common/ includes.
2162         * amd64-nbsd-tdep.c: Fix common/ includes.
2163         * amd64-linux-tdep.c: Fix common/ includes.
2164         * amd64-linux-nat.c: Fix common/ includes.
2165         * amd64-fbsd-tdep.c: Fix common/ includes.
2166         * amd64-fbsd-nat.c: Fix common/ includes.
2167         * amd64-dicos-tdep.c: Fix common/ includes.
2168         * amd64-darwin-tdep.c: Fix common/ includes.
2169         * agent.c: Fix common/ includes.
2170         * ada-lang.h: Fix common/ includes.
2171         * ada-lang.c: Fix common/ includes.
2172         * aarch64-tdep.c: Fix common/ includes.
2173
2174 2019-01-25  Tom Tromey  <tom@tromey.com>
2175
2176         * common/create-version.sh: Use common/version.h.
2177
2178 2019-01-24  Pedro Alves  <palves@redhat.com>
2179
2180         * infrun.c (signal_stop, signal_print, signal_program)
2181         (signal_catch, signal_pass): Now arrays instead of pointers.
2182         (update_signals_program_target, do_target_resume)
2183         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2184         * linux-nat.c (linux_nat_target::pass_signals)
2185         (linux_nat_target::create_inferior, linux_nat_target::attach):
2186         Adjust.
2187         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2188         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2189         * procfs.c (procfs_target::pass_signals): Adjust.
2190         * record-full.c (record_full_target::resume): Adjust.
2191         * remote.c (remote_target::pass_signals)
2192         (remote_target::program_signals): Adjust.
2193         * target-debug.h (target_debug_print_signals): Now takes a
2194         gdb::array_view as parameter.  Adjust.
2195         * target.h (target_ops) <pass_signals, program_signals>: Replace
2196         pointer and length parameters with gdb::array_view.
2197         (target_pass_signals, target_program_signals): Likewise.
2198         * target-delegates.c: Regenerate.
2199
2200 2019-01-24  Pedro Alves  <palves@redhat.com>
2201
2202         * common/forward-scope-exit.h
2203         (forward_scope_exit::forward_scope_exit): Pass arguments to
2204         m_bind_function directly, instead of creating a std::bind and
2205         copying that.
2206
2207 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2208
2209         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2210         for static members.
2211         (pass_in_v_vfp_candidate): Likewise.
2212
2213 2019-01-23  Tom Tromey  <tom@tromey.com>
2214             Pedro Alves  <palves@redhat.com>
2215
2216         * regcache.c (class regcache_invalidator): Remove.
2217         (regcache::raw_write): Use make_scope_exit.
2218
2219 2019-01-23  Tom Tromey  <tom@tromey.com>
2220
2221         * ui-out.h (class ui_out_emit_type): Update comment.
2222
2223 2019-01-23  Tom Tromey  <tom@tromey.com>
2224
2225         * infrun.c (fetch_inferior_event): Update comment.
2226
2227 2019-01-23  Tom Tromey  <tom@tromey.com>
2228             Pedro Alves  <palves@redhat.com>
2229
2230         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2231         parameter.
2232         (fetch_inferior_event): Use SCOPE_EXIT.
2233
2234
2235 2019-01-23  Tom Tromey  <tom@tromey.com>
2236             Pedro Alves  <palves@redhat.com>
2237
2238         * infrun.c (disable_thread_events): Delete.
2239         (stop_all_threads): Use SCOPE_EXIT.
2240
2241 2019-01-23  Tom Tromey  <tom@tromey.com>
2242             Pedro Alves  <palves@redhat.com>
2243
2244         * symfile.c: Include forward-scope-exit.h.
2245         (clear_symtab_users_cleanup): Replace forward declaration with
2246         a FORWARD_SCOPE_EXIT.
2247         (syms_from_objfile_1): Use the forward_scope_exit and
2248         gdb::optional instead of cleanup_function.
2249         (reread_symbols): Use the forward_scope_exit instead of
2250         cleanup_function.
2251         (clear_symtab_users_cleanup): Remove function.
2252
2253 2019-01-23  Tom Tromey  <tom@tromey.com>
2254             Pedro Alves  <palves@redhat.com>
2255
2256         * linux-nat.c: Include scope-exit.h.
2257         (cleanup_target_stop): Remove.
2258         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2259         SCOPE_EXIT.
2260
2261 2019-01-23  Tom Tromey  <tom@tromey.com>
2262             Pedro Alves  <palves@redhat.com>
2263
2264         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2265         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2266
2267 2019-01-23  Tom Tromey  <tom@tromey.com>
2268             Andrew Burgess  <andrew.burgess@embecosm.com>
2269             Pedro Alves  <palves@redhat.com>
2270
2271         * infrun.c (fetch_inferior_event): Use scope_exit.
2272         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2273         * top.c (execute_command): Use scope_exit.
2274         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2275         * utils.c (do_bpstat_clear_actions_cleanup)
2276         (make_bpstat_clear_actions_cleanup): Remove.
2277
2278 2019-01-23  Tom Tromey  <tom@tromey.com>
2279             Pedro Alves  <palves@redhat.com>
2280
2281         * infrun.c: Include "common/scope-exit.h"
2282         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2283         (wait_for_inferior): Use SCOPE_EXIT.
2284         (fetch_inferior_event): Use scope_exit.
2285
2286 2019-01-23  Tom Tromey  <tom@tromey.com>
2287             Pedro Alves  <palves@redhat.com>
2288
2289         * breakpoint.c (create_breakpoint): Remove cleanup.
2290
2291 2019-01-23  Tom Tromey  <tom@tromey.com>
2292             Andrew Burgess  <andrew.burgess@embecosm.com>
2293             Pedro Alves  <palves@redhat.com>
2294
2295 2019-01-23  Pedro Alves  <palves@redhat.com>
2296
2297         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2298
2299 2019-01-23  Pedro Alves  <palves@redhat.com>
2300             Andrew Burgess  <andrew.burgess@embecosm.com>
2301
2302         * gdbthread.h: Include "common/forward-scope-exit.h".
2303         (scoped_finish_thread_state): Redefine custom class in terms of
2304         forward_scope_exit.
2305
2306 2019-01-23  Pedro Alves  <palves@redhat.com>
2307             Andrew Burgess  <andrew.burgess@embecosm.com>
2308
2309         * common/forward-scope-exit.h: New file.
2310
2311 2019-01-23  Pedro Alves  <palves@redhat.com>
2312             Andrew Burgess  <andrew.burgess@embecosm.com>
2313             Tom Tromey  <tom@tromey.com>
2314
2315         * common/scope-exit.h: New file.
2316
2317 2019-01-23  Pedro Alves  <palves@redhat.com>
2318
2319         * common/preprocessor.h (ESC): Rename to ...
2320         (ESC_PARENS): ... this.
2321         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2322         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2323
2324 2019-01-23  Tom Tromey  <tom@tromey.com>
2325
2326         * language.h (class scoped_switch_to_sym_language_if_auto):
2327         Initialize m_lang in both cases.
2328
2329 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2330
2331         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2332         with XCNEW.
2333
2334 2019-01-22  Tom Tromey  <tom@tromey.com>
2335
2336         * corelow.c: Do not include sys/file.h.
2337
2338 2019-01-22  Tom Tromey  <tom@tromey.com>
2339
2340         * tui/tui-wingeneral.h: Include gdb_curses.h.
2341
2342 2019-01-22  Tom Tromey  <tom@tromey.com>
2343
2344         * source-cache.h (class source_cache) <get_source_lines,
2345         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2346
2347 2019-01-22  Tom Tromey  <tom@tromey.com>
2348
2349         * remote-fileio.h (struct remote_target): Declare.
2350
2351 2019-01-22  Tom Tromey  <tom@tromey.com>
2352
2353         * python/py-arch.c: Do not include py-ref.h.
2354         * python/py-bpevent.c: Do not include py-ref.h.
2355         * python/py-cmd.c: Do not include py-ref.h.
2356         * python/py-continueevent.c: Do not include py-ref.h.
2357         * python/py-event.h: Do not include py-ref.h.
2358         * python/py-evtregistry.c: Do not include py-ref.h.
2359         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2360         * python/py-frame.c: Do not include py-ref.h.
2361         * python/py-framefilter.c: Do not include py-ref.h.
2362         * python/py-function.c: Do not include py-ref.h.
2363         * python/py-infevents.c: Do not include py-ref.h.
2364         * python/py-linetable.c: Do not include py-ref.h.
2365         * python/py-objfile.c: Do not include py-ref.h.
2366         * python/py-param.c: Do not include py-ref.h.
2367         * python/py-prettyprint.c: Do not include py-ref.h.
2368         * python/py-progspace.c: Do not include py-ref.h.
2369         * python/py-symbol.c: Do not include py-ref.h.
2370         * python/py-symtab.c: Do not include py-ref.h.
2371         * python/py-type.c: Do not include py-ref.h.
2372         * python/py-unwind.c: Do not include py-ref.h.
2373         * python/py-utils.c: Do not include py-ref.h.
2374         * python/py-value.c: Do not include py-ref.h.
2375         * python/py-varobj.c: Do not include py-ref.h.
2376         * python/py-xmethods.c: Do not include py-ref.h.
2377         * python/python.c: Do not include py-ref.h.
2378         * varobj.c: Do not include py-ref.h.
2379
2380 2019-01-22  Tom Tromey  <tom@tromey.com>
2381
2382         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2383         keyword for bcache.
2384
2385 2019-01-22  Tom Tromey  <tom@tromey.com>
2386
2387         * compile/compile-cplus-types.c: Remove a comment by #include.
2388
2389 2019-01-22  Tom Tromey  <tom@tromey.com>
2390
2391         * compile/gcc-c-plugin.h: Include compile-internal.h.
2392
2393 2019-01-22  Tom Tromey  <tom@tromey.com>
2394
2395         * stabsread.c (EXTERN): Do not define.
2396         (symnum, next_symbol_text_func, processing_gcc_compilation)
2397         (within_function, global_sym_chain, global_stabs)
2398         (previous_stab_code, this_object_header_files)
2399         (n_this_object_header_files)
2400         (n_allocated_this_object_header_files): Define.
2401         * stabsread.h (EXTERN): Never define.  Use "extern".
2402
2403 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2404
2405         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2406         history_value.
2407
2408 2019-01-21  Tom Tromey  <tom@tromey.com>
2409
2410         * ui-out.c: Fix includes.
2411         * tui/tui-source.c: Fix includes.
2412         * target.c: Fix includes.
2413         * remote.c: Fix includes.
2414         * regcache.c: Fix includes.
2415         * python/py-block.c: Fix includes.
2416         * printcmd.c: Fix includes.
2417         * or1k-tdep.c: Fix includes.
2418         * mi/mi-main.c: Fix includes.
2419         * m32r-tdep.c: Fix includes.
2420         * csky-tdep.c: Fix includes.
2421         * compile/compile-cplus-types.c: Fix includes.
2422         * cli/cli-interp.c: Fix includes.
2423
2424 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2425
2426         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2427         for padding.
2428
2429 2019-01-16  Tom Tromey  <tom@tromey.com>
2430
2431         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2432         earlier.
2433         (struct objfile) <msymbols_range>: Move from top level.
2434         <msymbols>: New method.
2435         (class objfile_msymbols): Remove.
2436         * symtab.c (default_collect_symbol_completion_matches_break_on):
2437         Update.
2438         * symmisc.c (dump_msymbols): Update.
2439         * stabsread.c (scan_file_globals): Update.
2440         * objc-lang.c (info_selectors_command, info_classes_command)
2441         (find_methods): Update.
2442         * minsyms.c (find_solib_trampoline_target): Update.
2443         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2444         * coffread.c (coff_symfile_read): Update.
2445         * ada-lang.c (ada_lookup_simple_minsym)
2446         (ada_collect_symbol_completion_matches): Update.
2447
2448 2019-01-16  Tom Tromey  <tom@tromey.com>
2449
2450         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2451         type.  Remove no-argument constructor.
2452         <iterator::operator++>: Simplify.
2453         <begin>: Update.
2454         <end>: Use minimal_symbol_count.
2455
2456 2019-01-16  Tom Tromey  <tom@tromey.com>
2457
2458         * objfiles.h (struct objfile) <psymtabs>: New method.
2459         (class objfile_psymtabs): Remove.
2460         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2461         typedef.
2462         <range>: New method.
2463         (require_partial_symbols): Change return type.
2464         * psymtab.c (require_partial_symbols)
2465         (psym_expand_symtabs_matching): Update.
2466         * mdebugread.c (parse_partial_symbols): Update.
2467         * dbxread.c (dbx_end_psymtab): Update.
2468
2469 2019-01-15  Tom Tromey  <tom@tromey.com>
2470
2471         * symtab.c (lookup_objfile_from_block)
2472         (lookup_symbol_in_objfile_symtabs)
2473         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2474         (find_line_symtab, info_sources_command)
2475         (default_collect_symbol_completion_matches_break_on)
2476         (make_source_files_completion_list): Update.
2477         * symmisc.c (print_objfile_statistics, dump_objfile)
2478         (maintenance_print_symbols, maintenance_info_symtabs)
2479         (maintenance_check_symtabs, maintenance_info_line_tables):
2480         Update.
2481         * source.c (select_source_symtab)
2482         (forget_cached_source_info_for_objfile): Update.
2483         * objfiles.h (class objfile_compunits): Remove.
2484         (struct objfile) <compunits_range>: New typedef.
2485         (compunits): New method.
2486         * objfiles.c (objfile_relocate1): Update.
2487         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2488         * maint.c (count_symtabs_and_blocks): Update.
2489         * linespec.c (iterate_over_all_matching_symtabs): Update.
2490         * cp-support.c (add_symbol_overload_list_qualified): Update.
2491         * coffread.c (coff_symtab_read): Update.
2492         * ada-lang.c (add_nonlocal_symbols)
2493         (ada_collect_symbol_completion_matches)
2494         (ada_add_global_exceptions): Update.
2495
2496 2019-01-15  Tom Tromey  <tom@tromey.com>
2497
2498         * progspace.h (program_space) <objfiles_safe_range>: New
2499         typedef.
2500         <objfiles_safe>: New method.
2501         * objfiles.h (class all_objfiles_safe): Remove.
2502         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2503         * jit.c (jit_inferior_exit_hook): Update.
2504
2505 2019-01-17  Tom Tromey  <tom@tromey.com>
2506
2507         * progspace.h (program_space) <objfiles_range>: New typedef.
2508         <objfiles>: New method.
2509         <objfiles_head>: Rename from objfiles.
2510         (object_files): Update.
2511         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2512         * guile/scm-pretty-print.c
2513         (ppscm_find_pretty_printer_from_objfiles): Update.
2514         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2515         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2516         Update.
2517         * python/py-progspace.c (pspy_get_objfiles): Update.
2518         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2519         Update.
2520         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2521         (objfpy_lookup_objfile_by_build_id): Update.
2522         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2523         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2524         Update.
2525         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2526         (expand_symtab_containing_pc, lookup_objfile_from_block)
2527         (lookup_static_symbol, basic_lookup_transparent_type)
2528         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2529         (find_line_symtab, info_sources_command)
2530         (default_collect_symbol_completion_matches_break_on)
2531         (make_source_files_completion_list, find_main_name): Update.
2532         * symmisc.c (print_symbol_bcache_statistics)
2533         (print_objfile_statistics, maintenance_print_symbols)
2534         (maintenance_print_msymbols, maintenance_print_objfiles)
2535         (maintenance_info_symtabs, maintenance_check_symtabs)
2536         (maintenance_expand_symtabs, maintenance_info_line_tables):
2537         Update.
2538         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2539         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2540         (map_overlay_command, unmap_overlay_command)
2541         (simple_overlay_update, expand_symtabs_matching)
2542         (map_symbol_filenames): Update.
2543         * symfile-debug.c (set_debug_symfile): Update.
2544         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2545         Update.
2546         * source.c (select_source_symtab, forget_cached_source_info):
2547         Update.
2548         * solib.c (solib_read_symbols): Update.
2549         * solib-spu.c (append_ocl_sos): Update.
2550         * psymtab.c (maintenance_print_psymbols)
2551         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2552         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2553         * printcmd.c (info_symbol_command): Update.
2554         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2555         Update.
2556         * objfiles.h (class all_objfiles): Remove.
2557         * objfiles.c (have_partial_symbols, have_full_symbols)
2558         (have_minimal_symbols, qsort_cmp, update_section_map)
2559         (shared_objfile_contains_address_p)
2560         (default_iterate_over_objfiles_in_search_order): Update.
2561         * objc-lang.c (info_selectors_command, info_classes_command)
2562         (find_methods): Update.
2563         * minsyms.c (find_solib_trampoline_target): Update.
2564         * maint.c (maintenance_info_sections)
2565         (maintenance_translate_address, count_symtabs_and_blocks):
2566         Update.
2567         * main.c (captured_main_1): Update.
2568         * linux-thread-db.c (try_thread_db_load_from_pdir)
2569         (has_libpthread): Update.
2570         * linespec.c (iterate_over_all_matching_symtabs)
2571         (search_minsyms_for_name): Update.
2572         * jit.c (jit_find_objf_with_entry_addr): Update.
2573         * hppa-tdep.c (find_unwind_entry)
2574         (hppa_lookup_stub_minimal_symbol): Update.
2575         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2576         Update.
2577         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2578         (elf_gnu_ifunc_resolve_by_got): Update.
2579         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2580         * dwarf-index-write.c (save_gdb_index_command): Update.
2581         * cp-support.c (add_symbol_overload_list_qualified): Update.
2582         * breakpoint.c (create_overlay_event_breakpoint)
2583         (create_longjmp_master_breakpoint)
2584         (create_std_terminate_master_breakpoint)
2585         (create_exception_master_breakpoint): Update.
2586         * blockframe.c (find_pc_partial_function): Update.
2587         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2588         (ada_collect_symbol_completion_matches)
2589         (ada_add_global_exceptions): Update.
2590
2591 2019-01-17  Tom Tromey  <tom@tromey.com>
2592
2593         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2594         declare VEC.
2595         (solib_target_parse_libraries): Change return type.
2596         (library_list_start_segment, library_list_start_section)
2597         (library_list_end_library, library_list_start_library); Update.
2598         (solib_target_free_library_list): Remove.
2599         (solib_target_parse_libraries): Remove cleanup.  Change return
2600         type.
2601         (solib_target_current_sos): Update.
2602
2603 2019-01-17  Tom Tromey  <tromey@bapiya>
2604
2605         * valprint.c: Replace "the the" with "the".
2606         * symtab.c: Replace "the the" with "the".
2607         * solib.c: Replace "the the" with "the".
2608         * solib-dsbt.c: Replace "the the" with "the".
2609         * linespec.c: Replace "the the" with "the".
2610         * dwarf2loc.h: Replace "the the" with "the".
2611         * amd64-windows-tdep.c: Replace "the the" with "the".
2612         * aarch64-tdep.c: Replace "the the" with "the".
2613
2614 2019-01-16  Keith Seitz  <keiths@redhat.com>
2615
2616         PR gdb/23773
2617         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2618         <builder>: Rename to ..
2619         <m_builder>: ... this and make private.
2620         (dwarf2_cu::get_builder): New method.  Change all users of
2621         `builder' to use this method.
2622         (dwarf2_start_symtab): Move to ...
2623         (dwarf2_cu::start_symtab): ... here.  Update all callers
2624         (setup_type_unit_groups): Move to ...
2625         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2626         callers.
2627         (dwarf2_cu::reset_builder): New method.
2628         (process_full_compunit, process_full_type_unit): Use
2629         dwarf2_cu::reset_builder.
2630         (follow_die_offset): Record the ancestor CU if it is different
2631         from the followed DIE's CU.
2632         (follow_die_sig_1): Likewise.
2633
2634 2019-01-15  Tom Tromey  <tom@tromey.com>
2635
2636         * remote.c (class remote_state) <buf>: Now a char_vector.
2637         <buf_size>: Remove.
2638         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2639         parameter.
2640         (remote_target::getpkt_or_notif_sane_1)
2641         (remote_target::getpkt_sane)
2642         (remote_target::getpkt_or_notif_sane): Likewise.
2643         (class remote_target) <putpkt>: New overload.
2644         (remote_target::read_frame): Change type of "buf_p".  Remove
2645         sizeof_p parameter.
2646         (packet_ok): New overload.
2647         (packet_check_result): New overload.
2648         Update all uses.
2649
2650 2019-01-14  Tom Tromey  <tom@tromey.com>
2651
2652         * remote-notif.c (handle_notification, remote_notif_ack)
2653         (remote_notif_parse): Make "buf" const.
2654         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2655         const.
2656         (remote_notif_parse, remote_notif_ack, handle_notification):
2657         Likewise.
2658         * remote.c (remote_notif_stop_parse): Make "buf" const.
2659         (remote_target::remote_parse_stop_reply): Make "buf" const.
2660         (remote_notif_stop_ack): Make "buf" const.
2661
2662 2019-01-14  Tom Tromey  <tom@tromey.com>
2663
2664         * remote.c (remote_console_output): Make parameter const.
2665
2666 2019-01-14  Tom Tromey  <tom@tromey.com>
2667
2668         * target-debug.h (target_debug_print_signals): Constify.
2669         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2670         * procfs.c (procfs_target::pass_signals): Update.
2671         * linux-nat.c (linux_nat_target::pass_signals): Update.
2672         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2673         * target-delegates.c: Rebuild.
2674         * remote.c (remote_target::program_signals): Update.
2675         (remote_target::pass_signals): Update.
2676         * target.c (target_pass_signals): Constify argument.
2677         (target_program_signals): Likewise.
2678         * target.h (struct target_ops) <pass_signals, program_signals>:
2679         Constify argument.
2680         (target_pass_signals, target_program_signals): Constify argument.
2681
2682 2019-01-14  Tom Tromey  <tom@tromey.com>
2683
2684         PR tui/28819:
2685         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2686
2687 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2688
2689         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2690         field.
2691         * rs6000-tdep.c: Include reggroups.h.
2692         (IS_V_ALIAS_PSEUDOREG): Define.
2693         (rs6000_register_name): Return names for the "vX" aliases.
2694         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2695         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2696         aliases.  Call default_register_reggroup_p for all other
2697         pseudo-registers.
2698         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2699         New functions.
2700         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2701         Handle "vX" aliases.
2702         (v_alias_pseudo_register_collect): New function.
2703         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2704         (rs6000_gdbarch_init): Initialize "vX" aliases as
2705         pseudo-registers.  Restore registration of
2706         rs6000_pseudo_register_reggroup_p with
2707         set_tdesc_pseudo_register_reggroup_p.
2708
2709 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2710
2711         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2712         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2713         set_gdbarch_num_pseudo_regs.
2714
2715 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2716
2717         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2718         Remove arg prefixname, add do_set and do_show.
2719         Add member functions set_list and show_list.
2720         * cli/cli-style.c (class cli_style_option): Update accordingly.
2721         (style_set_list): Move to file scope.
2722         (style_show_list): Likewise.
2723         (set_style): Call help_list.
2724         (show_style): Call cmd_show_list.
2725         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2726         Update to use the new macro.
2727
2728 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2729
2730         * ada-lang.c (_initialize_ada_language): Expand the help text
2731         for the "catch exception" command.
2732
2733 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2734
2735         * symtab.c (matching_obj_sections): Initialize obj,
2736         declare it closer to its usage.
2737
2738 2019-01-10  Tom Tromey  <tom@tromey.com>
2739
2740         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2741         (basic_inf_threads_range): Remove.
2742         (inf_threads_range, inf_non_exited_threads_range)
2743         (safe_inf_threads_range): Use next_adapter.
2744
2745 2019-01-10  Keith Seitz  <keiths@redhat.com>
2746
2747         PR gdb/23712
2748         PR symtab/23010
2749         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2750         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2751
2752 2019-01-10  Keith Seitz  <keiths@redhat.com>
2753
2754         PR gdb/23712
2755         PR symtab/23010
2756         * dictionary.c (pending_to_vector): Remove.
2757         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2758         Remove _1 suffix, replacing functions of the same name.  Update
2759         all callers.
2760         (dict_create_hashed, dict_create_hashed_expandable)
2761         (dict_create_linear, dict_create_linear_expandable, dict_free)
2762         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2763         Make functions static.
2764
2765 2019-01-10  Keith Seitz  <keiths@redhat.com>
2766
2767         PR gdb/23712
2768         PR symtab/23010
2769         * dictionary.h (struct dictionary): Replace declaration with
2770         multidictionary.
2771         (dict_create_hashed, dict_create_hashed_expandable)
2772         (dict_create_linear, dict_create_linear_expandable)
2773         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2774         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2775         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2776         taking multidictionary argument.
2777         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2778         * block.h (struct block) <dict>: Change to multidictionary
2779         and rename `multidict'.
2780         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2781         symmisc.c: Update all dictionary references to multidictionary.
2782
2783 2019-01-10  Keith Seitz  <keiths@redhat.com>
2784
2785         PR gdb/23712
2786         PR symtab/23010
2787         * dictionary.c: Include unordered_map.
2788         (pending_to_vector): New function.
2789         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2790         Rewrite the non-"_1" functions to take vector instead
2791         of linked list.
2792         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2793         "new" _1 versions of the same name.
2794         (multidictionary): Define.
2795         (std::hash<enum language): New definition.
2796         (collate_pending_symbols_by_language, mdict_create_hashed)
2797         (mdict_create_hashed_expandable, mdict_create_linear)
2798         (mdict_create_linear_expandable, mdict_free)
2799         (find_language_dictionary, create_new_language_dictionary)
2800         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2801         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2802         (mdict_size, mdict_empty): New functions.
2803         * dictionary.h (mdict_iterator): Define.
2804
2805 2019-01-10  Pedro Alves  <palves@redhat.com>
2806
2807         * breakpoint.c (read_uploaded_action)
2808         (create_tracepoint_from_upload): Adjust to use
2809         gdb::unique_xmalloc_ptr.
2810         * ctf.c (ctf_write_uploaded_tp):
2811         (SET_ARRAY_FIELD): Use emplace_back.
2812         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2813         * tracefile-tfile.c (tfile_write_uploaded_tp):
2814         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2815         gdb::unique_xmalloc_ptr.
2816         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2817         at_string, cond_string, cmd_strings>: Replace char pointers
2818         with gdb::unique_xmalloc_ptr.
2819
2820 2019-01-10  Pedro Alves  <palves@redhat.com>
2821
2822         * solib-target.c (library_list_start_library): Don't xstrdup name.
2823
2824 2019-01-10  Pedro Alves  <palves@redhat.com>
2825
2826         * mdebugread.c (parse_partial_symbols): Use
2827         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2828
2829 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2830
2831         * linux-fork.c (scoped_switch_fork_info)
2832         <~scoped_switch_fork_info>: Fix incorrect variable name.
2833
2834 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2835
2836         * linux-fork.c (scoped_switch_fork_info)
2837         <scoped_switch_fork_info>: Make explicit.
2838         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2839
2840 2019-01-10  Tom Tromey  <tom@tromey.com>
2841
2842         * objfiles.h (objfile::reset_psymtabs): Update.
2843         * objfiles.c (objfile::objfile): Update.
2844         * psymtab.h (psymtab_storage::obstack): Update.
2845         (psymtab_storage::m_obstack): Use gdb::optional.
2846         (class psymtab_storage): Update comment.  Remove objfile
2847         parameter.
2848         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2849
2850 2019-01-10  Tom Tromey  <tom@tromey.com>
2851
2852         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2853         <free_psymtabs>: Now private.
2854         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2855         (allocate_psymtab): Use new method.
2856
2857 2019-01-10  Tom Tromey  <tom@tromey.com>
2858
2859         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2860         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2861         * mdebugread.c (parse_partial_symbols): Use
2862         allocate_dependencies.
2863         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2864         allocate_dependencies.
2865         (process_psymtab_comp_unit_reader)
2866         (build_type_psymtab_dependencies): Likewise.
2867         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2868
2869 2019-01-10  Tom Tromey  <tom@tromey.com>
2870
2871         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2872         PSYMBOL_SET_LANGUAGE.
2873         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2874
2875 2019-01-10  Tom Tromey  <tom@tromey.com>
2876
2877         * psymtab.h (psymtab_storage::obstack): New method.
2878         <m_obstack>: Rename from obstack; now private.
2879         * psymtab.c (psymtab_storage): Update.
2880         * dwarf2read.c (create_addrmap_from_index)
2881         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2882         Update.
2883
2884 2019-01-10  Tom Tromey  <tom@tromey.com>
2885
2886         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2887         * objfiles.h (objfile::reset_psymtabs): New method.
2888
2889 2019-01-10  Tom Tromey  <tom@tromey.com>
2890
2891         * symmisc.c (print_symbol_bcache_statistics): Update.
2892         (print_objfile_statistics): Update.
2893         * symfile.c (reread_symbols): Update.
2894         * psymtab.h (class psymtab_storage): New.
2895         * psymtab.c (psymtab_storage): New constructor.
2896         (~psymtab_storage): New destructor.
2897         (require_partial_symbols): Update.
2898         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2899         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2900         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2901         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2902         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2903         (start_psymtab_common, end_psymtab_common)
2904         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2905         (allocate_psymtab): Update.
2906         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2907         Update.
2908         (dump_psymtab_addrmap, maintenance_print_psymbols)
2909         (maintenance_check_psymtabs): Update.
2910         (class objfile_psymtabs): Move to objfiles.h.
2911         * psympriv.h (discard_psymtab): Now inline.
2912         (psymtab_discarder::psymtab_discarder): Update.
2913         (psymtab_discarder::~psymtab_discarder): Update.
2914         (ALL_OBJFILE_PSYMTABS): Rewrite.
2915         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2916         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2917         Remove fields.
2918         <partial_symtabs>: New field.
2919         (class objfile_psymtabs): Move from psymtab.h.  Update.
2920         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2921         psymbol_cache.
2922         (objfile::~objfile): Don't destroy psymbol_cache.
2923         * mdebugread.c (parse_partial_symbols): Update.
2924         * dwarf2read.c (create_addrmap_from_index)
2925         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2926         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2927         (add_partial_subprogram, dwarf2_ranges_read): Update.
2928         * dwarf-index-write.c (write_address_map)
2929         (write_one_signatured_type, recursively_write_psymbols)
2930         (class debug_names, class debug_names, write_psymtabs_to_index):
2931         Update.
2932
2933 2019-01-10  Tom Tromey  <tom@tromey.com>
2934
2935         * symtab.h (SYMBOL_SET_NAMES): Update.
2936         (symbol_set_names): Update.
2937         (MSYMBOL_SET_NAMES): Update.
2938         * symtab.c (symbol_set_names): Change argument to be an
2939         objfile_per_bfd_storage.
2940         * psymtab.c (add_psymbol_to_bcache): Update.
2941         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2942
2943 2019-01-10  Tom Tromey  <tom@tromey.com>
2944
2945         * symtab.c (create_demangled_names_hash): Change argument to be an
2946         objfile_per_bfd_storage.
2947         (symbol_set_names): Update.
2948
2949 2019-01-10  Tom Tromey  <tom@tromey.com>
2950
2951         * xcoffread.c (xcoff_initial_scan): Unconditionally call
2952         init_psymbol_list.
2953         * psymtab.c (init_psymbol_list): Do nothing if already called.
2954         * psympriv.h (init_psymbol_list): Add comment.
2955         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
2956         init_psymbol_list.
2957         * dbxread.c (dbx_symfile_read): Unconditionally call
2958         init_psymbol_list.
2959
2960 2019-01-10  Tom Tromey  <tom@tromey.com>
2961
2962         * xcoffread.c (scan_xcoff_symtab): Update.
2963         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
2964         "where".
2965         * mdebugread.c (parse_partial_symbols)
2966         (handle_psymbol_enumerators): Update.
2967         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
2968         * dbxread.c (read_dbx_symtab): Update.
2969         * psympriv.h (psymbol_placement): New enum.
2970         (add_psymbol_to_list): Update.
2971
2972 2019-01-10  Tom Tromey  <tom@tromey.com>
2973
2974         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
2975         static_psymbols parameters.
2976         (scan_xcoff_symtab): Update.
2977         * psymtab.c (start_psymtab_common): Remove global_psymbols and
2978         static_psymbols parameters.
2979         * psympriv.h (start_psymtab_common): Update.
2980         * mdebugread.c (parse_partial_symbols): Update.
2981         * dwarf2read.c (create_partial_symtab): Update.
2982         * dbxread.c (read_dbx_symtab): Update.
2983         (start_psymtab): Remove global_psymbols and static_psymbols
2984         parameters.
2985
2986 2019-01-10  Tom Tromey  <tom@tromey.com>
2987
2988         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
2989         * psymtab.c (allocate_psymtab): Add comment.
2990         * psympriv.h (allocate_psymtab): Add comment.
2991         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
2992         initializations.
2993         * dbxread.c (dbx_end_psymtab): Remove some initializations.
2994
2995 2019-01-10  Tom Tromey  <tom@tromey.com>
2996
2997         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
2998         Don't declare.
2999         * mipsread.c: Include mdebugread.h.
3000         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3001         Declare.
3002         * elfread.c: Include mdebugread.h.
3003
3004 2019-01-09  Tom Tromey  <tom@tromey.com>
3005
3006         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3007         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3008         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3009         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3010         (psym_lookup_symbol, psym_find_last_source_symtab)
3011         (psym_forget_cached_source_info, psym_print_stats)
3012         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3013         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3014         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3015         (psym_find_compunit_symtab_by_address)
3016         (maintenance_print_psymbols, maintenance_info_psymtabs)
3017         (maintenance_check_psymtabs): Use ranged for.
3018         * psymtab.h (class objfile_psymtabs): New.
3019         (require_partial_symbols): Return objfile_psymtabs.
3020         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3021
3022 2019-01-09  Tom Tromey  <tom@tromey.com>
3023
3024         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3025         (find_pc_mapped_section, list_overlays_command)
3026         (map_overlay_command, unmap_overlay_command)
3027         (simple_overlay_update): Use all_objfiles.
3028         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3029         * printcmd.c (info_symbol_command): Use all_objfiles.
3030         * objfiles.h (ALL_OBJSECTIONS): Remove.
3031         * maint.c (maintenance_translate_address): Use all_objfiles.
3032         * gcore.c (gcore_create_callback): Use all_objfiles.
3033         (objfile_find_memory_regions): Likewise.
3034
3035 2019-01-09  Tom Tromey  <tom@tromey.com>
3036
3037         * symtab.c (find_line_symtab, info_sources_command)
3038         (make_source_files_completion_list): Use objfile_compunits.
3039         * source.c (select_source_symtab): Use objfile_compunits.
3040         * objfiles.h (struct objfile): Update comment.
3041         (ALL_OBJFILES): Remove.
3042         (ALL_FILETABS): Remove.
3043         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3044         objfile_compunits.
3045
3046 2019-01-09  Tom Tromey  <tom@tromey.com>
3047
3048         * symmisc.c (print_objfile_statistics, dump_objfile)
3049         (maintenance_print_symbols): Use compunit_filetabs.
3050         * source.c (forget_cached_source_info_for_objfile): Use
3051         compunit_filetabs.
3052         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3053         (ALL_FILETABS): Use compunit_filetabs.
3054         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3055         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3056
3057 2019-01-09  Tom Tromey  <tom@tromey.com>
3058
3059         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3060         (compunit_filetabs): New.
3061         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3062         compunit_filetabs.
3063         (info_sources_command, make_source_files_completion_list): Remove
3064         declaration.
3065         * symmisc.c (print_objfile_statistics, dump_objfile)
3066         (maintenance_print_symbols): Remove declaration.
3067         (maintenance_info_symtabs): Use compunit_filetabs.
3068         (maintenance_info_line_tables): Likewise.
3069         * source.c (select_source_symtab): Change local variable name.
3070         (forget_cached_source_info_for_objfile): Remove declaration.
3071         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3072         * objfiles.c (objfile_relocate1): Remove declaration.
3073         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3074         declaration.
3075         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3076         * coffread.c (coff_symtab_read): Remove declaration.
3077         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3078         compunit_filetabs.
3079
3080 2019-01-09  Tom Tromey  <tom@tromey.com>
3081
3082         * symtab.c (lookup_objfile_from_block)
3083         (find_pc_sect_compunit_symtab, search_symbols)
3084         (default_collect_symbol_completion_matches_break_on): Use
3085         objfile_compunits.
3086         * objfiles.h (ALL_COMPUNITS): Remove.
3087         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3088         * cp-support.c (add_symbol_overload_list_qualified): Use
3089         objfile_compunits.
3090         * ada-lang.c (ada_collect_symbol_completion_matches)
3091         (ada_add_global_exceptions): Use objfile_compunits.
3092
3093 2019-01-09  Tom Tromey  <tom@tromey.com>
3094
3095         * source.c (select_source_symtab)
3096         (forget_cached_source_info_for_objfile): Remove declaration.
3097         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3098         declaration.
3099         * maint.c (count_symtabs_and_blocks): Remove declaration.
3100         * cp-support.c (add_symbol_overload_list_qualified): Remove
3101         declaration.
3102         * coffread.c (coff_symtab_read): Remove declaration.
3103         * symtab.c (lookup_symbol_in_objfile_symtabs)
3104         (basic_lookup_transparent_type_1): Use objfile_compunits.
3105         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3106         (info_sources_command, search_symbols)
3107         (default_collect_symbol_completion_matches_break_on)
3108         (make_source_files_completion_list): Remove declaration.
3109         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3110         (ada_collect_symbol_completion_matches)
3111         (ada_add_global_exceptions): Remove declaration.
3112         * linespec.c (iterate_over_all_matching_symtabs): Use
3113         objfile_compunits.
3114         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3115         (class objfile_compunits): New.
3116         (ALL_COMPUNITS): Use objfile_compunits.
3117         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3118         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3119         objfile_compunits.
3120         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3121
3122 2019-01-09  Tom Tromey  <tom@tromey.com>
3123
3124         * symtab.c (search_symbols)
3125         (default_collect_symbol_completion_matches_break_on): Use
3126         objfile_msymbols.
3127         * ada-lang.c (ada_lookup_simple_minsym)
3128         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3129         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3130         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3131         objfile_msymbols.
3132         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3133         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3134         * objc-lang.c (find_methods): Use objfile_msymbols.
3135         (info_selectors_command, info_classes_command): Likewise.
3136         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3137         * objfiles.h (class objfile_msymbols): New.
3138         (ALL_OBJFILE_MSYMBOLS): Remove.
3139         (ALL_MSYMBOLS): Remove.
3140
3141 2019-01-09  Tom Tromey  <tom@tromey.com>
3142
3143         * common/next-iterator.h (next_adapter): Add Iterator template
3144         parameter.
3145         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3146         (class all_objfiles_safe): New.
3147         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3148         * objfiles.c (put_objfile_before): Update comment.
3149         (add_separate_debug_objfile): Likewise.
3150         (free_all_objfiles): Use all_objfiles_safe.
3151         (objfile_purge_solibs): Likewise.
3152
3153 2019-01-09  Tom Tromey  <tom@tromey.com>
3154
3155         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3156         (expand_symtab_containing_pc, lookup_static_symbol)
3157         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3158         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3159         all_objfiles.
3160         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3161         * breakpoint.c (create_overlay_event_breakpoint)
3162         (create_longjmp_master_breakpoint)
3163         (create_std_terminate_master_breakpoint)
3164         (create_exception_master_breakpoint): Use all_objfiles.
3165         * linux-thread-db.c (try_thread_db_load_from_pdir)
3166         (has_libpthread): Use all_objfiles.
3167         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3168         * linespec.c (iterate_over_all_matching_symtabs)
3169         (search_minsyms_for_name): Use all_objfiles.
3170         * maint.c (maintenance_info_sections): Use all_objfiles.
3171         * main.c (captured_main_1): Use all_objfiles.
3172         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3173         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3174         * guile/scm-pretty-print.c
3175         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3176         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3177         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3178         (maintenance_print_msymbols): Use all_objfiles.
3179         * source.c (select_source_symtab): Use all_objfiles.
3180         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3181         * symfile.c (remove_symbol_file_command)
3182         (expand_symtabs_matching, map_symbol_filenames): Use
3183         all_objfiles.
3184         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3185         all_objfiles.
3186         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3187         * objc-lang.c (find_methods): Use all_objfiles.
3188         * objfiles.c (have_partial_symbols, have_full_symbols)
3189         (have_minimal_symbols, qsort_cmp)
3190         (default_iterate_over_objfiles_in_search_order): Use
3191         all_objfiles.
3192         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3193         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3194         (maintenance_check_psymtabs): Use all_objfiles.
3195         (ALL_PSYMTABS): Remove.
3196         * compile/compile-object-run.c (do_module_cleanup): Use
3197         all_objfiles.
3198         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3199         * cp-support.c (add_symbol_overload_list_qualified): Use
3200         all_objfiles.
3201         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3202         Use all_objfiles.
3203         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3204         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3205         all_objfiles.
3206         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3207         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3208         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3209         Uses all_objfiles.
3210         * solib.c (solib_read_symbols): Use all_objfiles
3211
3212 2019-01-09  Tom Tromey  <tom@tromey.com>
3213
3214         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3215         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3216         all_objfiles.
3217         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3218         * symmisc.c (print_symbol_bcache_statistics)
3219         (print_objfile_statistics, maintenance_print_objfiles)
3220         (maintenance_info_symtabs, maintenance_check_symtabs)
3221         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3222         all_objfiles.
3223         * source.c (forget_cached_source_info): Use all_objfiles.
3224         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3225         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3226         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3227         * objfiles.c (update_section_map): Use all_objfiles.
3228         (shared_objfile_contains_address_p): Likewise.
3229         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3230         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3231
3232 2019-01-09  Tom Tromey  <tom@tromey.com>
3233
3234         * common/next-iterator.h: New file.
3235         * objfiles.h (class all_objfiles): New.
3236         (struct objfile_iterator): New.
3237
3238 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3239
3240         * NEWS: Move the description of the changed "frame", "select-frame",
3241          and "info frame" commands to the Changed commands section.
3242
3243 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3244
3245         * gdbtypes.c (check_stub_method_group): Remove handling of old
3246         mangling schemes.
3247         * linespec.c (find_methods): Likewise.
3248         * stabsread.c (read_member_functions): Likewise.
3249         * valops.c (search_struct_method): Likewise.
3250         (value_struct_elt_for_reference): Likewise.
3251         * NEWS: Mention this change.
3252
3253 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3254
3255         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3256         print_source_lines.
3257         * source.c (print_source_lines_base): Update line number check.
3258         (print_source_lines): New function.
3259         (source_lines_range::source_lines_range): New function.
3260         * source.h (class source_lines_range): New class.
3261         (print_source_lines): New declaration.
3262
3263 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3264
3265         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3266
3267 2019-01-08  Tom Tromey  <tom@tromey.com>
3268             Simon Marchi  <simon.marchi@ericsson.com>
3269
3270         PR gdb/24060
3271         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3272         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3273         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3274         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3275         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3276         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3277
3278 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3279
3280         * source.c (select_source_symtab): Move header comment to
3281         declaration in source.h.
3282         (forget_cached_source_info_for_objfile): Likewise.
3283         (forget_cached_source_info): Likewise.
3284         (identify_source_line): Likewise.
3285         * source.h (identify_source_line): Move declaration from symtab.h
3286         and add comment from source.c
3287         (print_source_lines): Likewise.
3288         (forget_cached_source_info_for_objfile): Likewise.
3289         (forget_cached_source_info): Likewise.
3290         (select_source_symtab): Likewise.
3291         (enum print_source_lines_flag): Move definition from symtab.h.
3292         * symtab.h (identify_source_line): Move declaration to source.h.
3293         (print_source_lines): Likewise.
3294         (forget_cached_source_info_for_objfile): Likewise.
3295         (forget_cached_source_info): Likewise.
3296         (select_source_symtab): Likewise.
3297         (enum print_source_lines_flag): Move definition to source.h.
3298         * tui/tui-hooks.c: Add 'source.h' include.
3299
3300 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3301
3302         * source.c (print_source_lines_base): Handle requests to print
3303         reverse line number sequences, and guard against empty lines
3304         string.
3305
3306 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3307
3308         * source.c (print_source_lines_base): Fix skip of '\r' if next
3309         character is '\n'.
3310
3311 2019-01-06  Tom Tromey  <tom@tromey.com>
3312
3313         * c-exp.y (struct c_parse_state) <macro_original_text,
3314         expansion_obstack>: New member.
3315         (macro_original_text, expansion_obstack): Remove globals.
3316         (scan_macro_expansion, scanning_macro_expansion)
3317         (finished_macro_expansion): Update.
3318         (scan_macro_cleanup): Remove.
3319         (yylex, c_parse): Update.
3320
3321 2019-01-06  Tom Tromey  <tom@tromey.com>
3322
3323         * c-exp.y (struct c_parse_state) <strings>: New member.
3324         (operator_stoken): Update.
3325
3326 2019-01-06  Tom Tromey  <tom@tromey.com>
3327
3328         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3329         (union type_stack_elt) <typelist_val>: Now a pointer to
3330         std::vector.
3331         (type_stack_cleanup): Don't declare.
3332         (push_typelist): Update.
3333         * parse.c (pop_typelist): Return a std::vector.
3334         (push_typelist): Take a std::vector.
3335         (follow_types): Update.  Do not free args.
3336         (type_stack_cleanup): Remove.
3337         * c-exp.y (struct c_parse_state): New.
3338         (cpstate): New global.
3339         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3340         (nonempty_typelist): Update.
3341         (func_mod): Create a new vector.
3342         (c_parse): Create a c_parse_state.
3343         (check_parameter_typelist): Do not delete params.
3344         (function_method): Update.  Do not delete type_list.
3345
3346 2019-01-06  Tom Tromey  <tom@tromey.com>
3347
3348         PR gdb/28155:
3349         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3350         check_typedef.
3351         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3352         (print_return_value): Likewise.
3353
3354 2019-01-05  Tom Tromey  <tom@tromey.com>
3355
3356         * contrib/cleanup_check.py: Remove.
3357         * contrib/gcc-with-excheck: Remove.
3358         * contrib/exsummary.py: Remove.
3359         * contrib/excheck.py: Remove.
3360
3361 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3362
3363         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3364         NULL. Initialize tpprev to NULL instead of assigning it
3365         to NULL on the next statement.
3366         * windows-nat.c (windows_delete_thread): Remove check for
3367         main_thread_id before printing thread exit notifications.
3368         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3369         Remove thread ID check against main_thread_id.
3370         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3371         windows_delete_thread.
3372         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3373
3374 2019-01-04  Tom Tromey  <tom@tromey.com>
3375
3376         * compile/compile.c (_initialize_compile): Use upper case for
3377         metasyntactic variables.
3378         * symmisc.c (_initialize_symmisc): Use upper case for
3379         metasyntactic variables.
3380         * psymtab.c (_initialize_psymtab): Use upper case for
3381         metasyntactic variables.
3382         * demangle.c (demangle_command): Use upper case for metasyntactic
3383         variables.
3384         (_initialize_demangler): Likewise.
3385         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3386         variables.
3387
3388 2019-01-03  Tom Tromey  <tom@tromey.com>
3389
3390         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3391
3392 2019-01-03  Tom Tromey  <tom@tromey.com>
3393
3394         * python/py-symtab.c (salpy_str): Update.
3395         (struct salpy_sal_object) <symtab>: Now a PyObject.
3396         (salpy_dealloc): Update.
3397         (del_objfile_sal): Use gdbpy_ref.
3398
3399 2019-01-03  Tom Tromey  <tom@tromey.com>
3400
3401         * python/py-type.c (convert_field): Use new_reference.  Return
3402         gdbpy_ref.
3403         (make_fielditem): Return gdbpy_ref.
3404         (typy_fields): Update.
3405         (typy_getitem): Update.
3406         (field_name): Return gdbpy_ref.  Use new_reference.
3407         (typy_iterator_iternext): Update.
3408
3409 2019-01-03  Tom Tromey  <tom@tromey.com>
3410
3411         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3412
3413 2019-01-03  Tom Tromey  <tom@tromey.com>
3414
3415         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3416         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3417         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3418         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3419         (pspy_set_type_printers): Likewise.
3420         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3421         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3422         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3423         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3424         (objfpy_set_type_printers): Likewise.
3425
3426 2019-01-03  Tom Tromey  <tom@tromey.com>
3427
3428         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3429         (gdbpy_print_stack): Use gdbpy_err_fetch.
3430         * python/python-internal.h (class gdbpy_err_fetch): New class.
3431         (class gdbpy_enter) <m_error_type, m_error_value,
3432         m_error_traceback>: Remove.
3433         <m_error>: New member.
3434         (gdbpy_exception_to_string): Don't declare.
3435         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3436         * python/py-value.c (convert_value_from_python): Use
3437         gdbpy_err_fetch.
3438         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3439         gdbpy_exception_to_string.
3440         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3441         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3442         gdbpy_err_fetch.
3443
3444 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3445
3446         * linux-nat.c (delete_lwp_cleanup): Delete.
3447         (struct lwp_deleter): New struct.
3448         (lwp_info_up): New typedef.
3449         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3450         lwp_info_up.
3451
3452 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3453
3454         * linux-fork.c (class scoped_switch_fork_info): New class.
3455         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3456
3457 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3458
3459         * valops.c (find_overload_match): Remove use of null_cleanup, and
3460         calls to do_cleanups.
3461
3462 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3463
3464         * compile/compile-cplus-types.c
3465         (compile_cplus_instance::decl_name): Handle changes to
3466         cp_func_name.
3467         * cp-support.c (cp_func_name): Update header comment, update
3468         return type.
3469         * cp-support.h (cp_func_name): Update return type in declaration.
3470         * valops.c (find_overload_match): Move temp_func local to top
3471         level of function and change its type.  Use temp_func to hold and
3472         delete temporary string obtained from cp_func_name.
3473
3474 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3475
3476         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3477         gdb::char_vector, remove cleanup, and update uses of `msg`.
3478
3479 2019-01-03  Jim Wilson  <jimw@sifive.com>
3480
3481         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3482
3483 2019-01-02  Tom Tromey  <tom@tromey.com>
3484
3485         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3486         (tdesc_parse_xml): Remove cleanups.
3487         * target-descriptions.h (make_cleanup_free_target_description):
3488         Don't declare.
3489         (target_desc_deleter): New struct.
3490         (target_desc_up): New typedef.
3491         * target-descriptions.c (target_desc_deleter::operator()): Rename
3492         from free_target_description.
3493         (make_cleanup_free_target_description): Remove.
3494
3495 2019-01-02  Tom Tromey  <tom@tromey.com>
3496
3497         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3498         constructor, destructor.
3499         (linespec_parser): Remove typedef.
3500         (~linespec_parser): Rename from linespec_parser_delete.
3501         (linespec_lex_to_end, linespec_complete_label)
3502         (linespec_complete): Update.
3503         (decode_line_full): Remove cleanups.
3504         (decode_line_1): Update.
3505
3506 2019-01-02  Tom Tromey  <tom@tromey.com>
3507
3508         * python/python-internal.h (inferior_to_inferior_object): Change
3509         return type.
3510         * python/py-exitedevent.c (create_exited_event_object): Update.
3511         * python/py-inferior.c (inferior_to_inferior_object): Return
3512         gdbpy_ref.
3513         (python_new_inferior, python_inferior_deleted)
3514         (thread_to_thread_object, delete_thread_object)
3515         (build_inferior_list, gdbpy_selected_inferior): Update.
3516         * python/py-infthread.c (create_thread_object): Update.  Also fail
3517         if inferior_to_inferior_object fails.
3518
3519 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3520
3521         * inferior.h (class inferior) <displaced_step_state>: New field.
3522         * infrun.h (struct displaced_step_state): Move here from
3523         infrun.c.  Initialize fields, add constructor.
3524         <inf>: Remove field.
3525         <reset>: New method.
3526         * infrun.c (struct displaced_step_inferior_state): Move to
3527         infrun.h.
3528         (displaced_step_inferior_states): Remove.
3529         (get_displaced_stepping_state): Adust.
3530         (displaced_step_in_progress_any_inferior): Adjust.
3531         (displaced_step_in_progress_thread): Adjust.
3532         (displaced_step_in_progress): Adjust.
3533         (add_displaced_stepping_state): Remove.
3534         (get_displaced_step_closure_by_addr): Adjust.
3535         (remove_displaced_stepping_state): Remove.
3536         (infrun_inferior_exit): Call displaced_step_state.reset.
3537         (use_displaced_stepping): Don't check for NULL.
3538         (displaced_step_prepare_throw): Call
3539         get_displaced_stepping_state.
3540         (displaced_step_fixup): Don't check for NULL.
3541         (prepare_for_detach): Don't check for NULL.
3542
3543 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3544
3545         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3546          in case of call that did not complete.
3547
3548 2019-01-02  Andrey Utkin  <autkin@undo.io>
3549
3550         * symfile.c (find_separate_debug_file): Fix search of debug files for
3551         remote debuggee.
3552
3553 2019-01-02  Tom Tromey  <tom@tromey.com>
3554
3555         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3556         indentation.
3557         * python/py-frame.c (frapy_older): Remove cast.
3558         (frapy_newer): Likewise.
3559         * python/py-breakpoint.c (local_setattro): Remove cast.
3560         * python/py-arch.c (archpy_name): Remove local variable.
3561         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3562
3563 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3564
3565         * unittests/basic_string_view/element_access/char/empty.cc:
3566         Fix year range in copyright header.
3567
3568 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3569
3570         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3571         Delete.
3572         <operator==>: Update with for removed field.
3573         <hash>: Likewise.
3574         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3575         <isa_features>: ...this.
3576         <abi_features>: New field.
3577         (riscv_isa_flen): Update comment.
3578         (riscv_abi_xlen): New declaration.
3579         (riscv_abi_flen): New declaration.
3580         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3581         isa_features.
3582         (riscv_abi_xlen): New function.
3583         (riscv_isa_flen): Update to get answer from isa_features.
3584         (riscv_abi_flen): New function.
3585         (riscv_has_fp_abi): Update to get answer from abi_features.
3586         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3587         xlen and flen.
3588         (riscv_call_info) <xlen, flen>: Update comment.
3589         (riscv_call_arg_struct): Remove invalid assertions
3590         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3591         is removed.
3592         (riscv_gdbarch_init): Gather isa features and abi features
3593         separately, ensure both match on the gdbarch when reusing an old
3594         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3595         a target with 64-bit float hardware.
3596
3597 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3598
3599         * source.c (search_command_helper): Stop reverse search
3600         when line 1 has been searched.
3601
3602 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3603
3604         * record-full.c (record_full_base_target::close): Rewrite
3605         record_full_core_buf_list free logic.
3606
3607 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3608
3609         * break-catch-syscall.c (print_one_catch_syscall): xfree
3610         the last text.
3611
3612 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3613
3614         * top.c (print_gdb_version): Update Copyright year in version
3615         message.
3616
3617 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3618
3619         Update copyright year range in all GDB files.
3620
3621 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3622
3623         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3624
3625 For older changes see ChangeLog-2018.
3626 \f
3627 Local Variables:
3628 mode: change-log
3629 left-margin: 8
3630 fill-column: 74
3631 version-control: never
3632 coding: utf-8
3633 End:
3634