gdb/ChangeLog

   1 2019-05-17  Tom Tromey  <tromey@adacore.com>
   2
   3         * annotate.c (annotate_source): Make "filename" const.
   4         * annotate.h (annotate_source): Use const.
   5
   6 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
   7
   8         * disasm.c (set_disassembler_options): Send errors to stderr.
   9
  10 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  11
  12         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
  13         (cli_interp_base::set_logging): Check debug_redirect.
  14         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
  15         * cli/cli-logging.c (debug_redirect): Add static variable.
  16         (pop_output_files): Add default param.
  17         (handle_redirections): Print debug setting.
  18         (show_logging_command): Likewise.
  19         (_initialize_cli_logging): Add debugredirect command.
  20         * interps.c (current_interp_set_logging): Add debug_redirect
  21         parameter.
  22         * interps.h (set_logging): Add debug_redirect parameter.
  23         (current_interp_set_logging): Likewise.
  24         * mi/mi-common.h: Likewise.
  25         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
  26
  27 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
  28             Tom Tromey  <tromey@adacore.com>
  29
  30         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
  31         directly.
  32         * cli/cli-interp.h (make_logging_output): Remove declaration.
  33         * cli/cli-logging.c (make_logging_output): Remove function.
  34         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
  35         directly.
  36         * ui-file.c (tee_file::tee_file): Remove bools.
  37         (tee_file::~tee_file): Remove deletes.
  38         * ui-file.h (tee_file): Remove bools.
  39
  40 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
  41
  42         * mi/mi-cmds.h (mi_cmd_complete): New function.
  43         * mi/mi-main.c (mi_cmd_complete): Likewise.
  44         * mi/mi-cmds.c: Define new MI command -complete.
  45         * NEWS: Mention new -complete command.
  46
  47 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
  48
  49         * completer.h (complete): New function.
  50         * completer.c (complete): Likewise.
  51         * cli/cli-cmds.c: (complete_command): Update to use new complete()
  52         function defined in completer.h.
  53
  54 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
  55
  56        * MAINTAINERS (Write After Approval): Add myself.
  57
  58 2019-05-17  Tom de Vries  <tdevries@suse.de>
  59
  60         PR gdb/24094
  61         * dwarf2read.c (struct cu_partial_die_info): New struct.
  62         (find_partial_die): Return cu_partial_die_info.
  63         (partial_die_parent_scope, guess_partial_die_structure_name)
  64         (partial_die_info::fixup): Handle new return type of find_partial_die.
  65
  66 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  67
  68         * stap-probe.c (stap_parse_register_operand): Make "regname" an
  69         "std::string", simplifying the algorithm.
  70
  71 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  72
  73         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
  74         (stap_static_probe_ops::get_probes): Likewise.
  75
  76 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  77
  78         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
  79         '-')" and "else if".
  80         (stap_parse_single_operand): Join checks for
  81         "gdbarch_stap_parse_special_token_p" and
  82         "gdbarch_stap_parse_special_token" in the same "if" statement.
  83         Invert check when verifying for operation on register
  84         displacement.
  85
  86 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  87
  88         * stap-probe.c (stap_get_opcode): Update comment.
  89         (stap_get_expected_argument_type): Likewise.
  90         (handle_stap_probe): Likewise.
  91
  92 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
  93
  94         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
  95         return type to 'bool'.  Adjust comment.  Use 'bool' when
  96         appropriate.
  97         (i386_stap_parse_special_token_three_arg_disp): Likewise.
  98         * stap-probe.c (stap_parse_argument_1): Likewise.
  99         (stap_is_operator): Likewise.
 100         (stap_is_generic_prefix): Likewise.
 101         (stap_is_register_prefix): Likewise.
 102         (stap_is_register_indirection_prefix): Likewise.
 103         (stap_is_integer_prefix): Likewise.
 104         (stap_generic_check_suffix): Likewise.
 105         (stap_check_integer_suffix): Likewise.
 106         (stap_check_register_suffix): Likewise.
 107         (stap_check_register_indirection_suffix): Likewise.
 108         (stap_parse_register_operand): Likewise.
 109         (stap_parse_single_operand): Likewise.
 110         (stap_parse_argument_1): Likewise.
 111         (stap_probe::get_argument_count): Likewise.
 112         (stap_is_operator): Likewise.
 113
 114 2019-05-16  Tom Tromey  <tromey@adacore.com>
 115
 116         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 117         keyword to foreach.
 118
 119 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 120
 121         * linux-thread-db.c (try_thread_db_load_1): Change return type
 122         to bool.
 123         (try_thread_db_load): Likewise.
 124         (try_thread_db_load_from_pdir_1): Likewise.
 125         (try_thread_db_load_from_pdir): Likewise.
 126         (try_thread_db_load_from_sdir): Likewise.
 127         (try_thread_db_load_from_dir): Likewise.
 128         (thread_db_load_search): Likewise.
 129         (has_libpthread): Likewise.
 130         (thread_db_load): Likewise.
 131
 132 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 133
 134         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 135         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 136         NULL, and complain/return if that's the case.
 137
 138 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 139
 140         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 141         (advance, posn, abstract_read_memory): New functions.
 142         [struct mem_read_abstraction]: New struct.
 143         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 144
 145 2019-05-14  Tom Tromey  <tromey@adacore.com>
 146
 147         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 148         value is not lval_memory.
 149
 150 2019-05-14  Tom Tromey  <tromey@adacore.com>
 151
 152         * solib.c (info_sharedlibrary_command): Style the file name.
 153
 154 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 155
 156         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 157         (aarch64_vnv_type): Likewise.
 158         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 159         * common/tdesc.c: Likewise.
 160         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 161         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 162         * features/aarch64-fpu.xml: Add ieee half view.
 163         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 164         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 165         * gdbtypes.h (struct builtin_type): Likewise.
 166         (struct objfile_type): Likewise.
 167
 168 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 169
 170         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 171         typo.
 172         * location.h (string_to_event_location): Likewise.
 173
 174 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 175
 176         GDB 8.3 released.
 177
 178 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 179
 180         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 181         New variable declaration.
 182         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 183         New variable.
 184         (print_one_breakpoint): Use ui_out::test_flags and new global
 185         variable to compute use_fixed_output.
 186         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 187         Remove.
 188         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 189         (mi_multi_location_breakpoint_output_fixed): Remove.
 190         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 191         new variable.
 192         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 193         fix_multi_location_breakpoint_output flag if version >= 3.
 194         * ui-out.h (enum ui_out_flag)
 195         <fix_multi_location_breakpoint_output>: New enumerator.
 196
 197 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 198
 199         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 200
 201 2019-05-10  Tom Tromey  <tromey@adacore.com>
 202
 203         * ada-lang.c (catch_ada_completer): New function.
 204         (_initialize_ada_language): Use it.
 205
 206 2019-05-10  Tom Tromey  <tromey@adacore.com>
 207
 208         * thread.c (print_thread_info): Make "requested_threads" const.
 209         * gdbthread.h (print_thread_info): Make "requested_threads"
 210         const.
 211         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 212         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 213
 214 2019-05-08  Tom Tromey  <tom@tromey.com>
 215
 216         * gdbtypes.c (objfile_type_data): Change type.
 217         (objfile_type, _initialize_gdbtypes): Update.
 218
 219 2019-05-08  Tom Tromey  <tom@tromey.com>
 220
 221         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 222         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 223         (_initialize_dwarf2_frame): Update.
 224
 225 2019-05-08  Tom Tromey  <tom@tromey.com>
 226
 227         * objc-lang.c (objc_objfile_data): Change type.
 228         (find_methods): Update.
 229         (_initialize_objc_lang): Remove.
 230
 231 2019-05-08  Tom Tromey  <tom@tromey.com>
 232
 233         * stabsread.c (rs6000_builtin_type_data): Change type.
 234         (rs6000_builtin_type, _initialize_stabsread): Update.
 235
 236 2019-05-08  Tom Tromey  <tom@tromey.com>
 237
 238         * mips-tdep.c (mips_pdr_data): Remove.
 239         (_initialize_mips_tdep): Update.
 240
 241 2019-05-08  Tom Tromey  <tom@tromey.com>
 242
 243         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 244         (hppa_init_objfile_priv_data, read_unwind_info)
 245         (find_unwind_entry, _initialize_hppa_tdep): Update.
 246
 247 2019-05-08  Tom Tromey  <tom@tromey.com>
 248
 249         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 250         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 251         on obstack.
 252         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 253
 254 2019-05-08  Tom Tromey  <tom@tromey.com>
 255
 256         * mdebugread.c (basic_type_data): Change type.
 257         (basic_type, _initialize_mdebugread): Update.
 258
 259 2019-05-08  Tom Tromey  <tom@tromey.com>
 260
 261         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 262
 263 2019-05-08  Tom Tromey  <tom@tromey.com>
 264
 265         * nto-tdep.c (nto_inferior_data_reg): Change type.
 266         (nto_inferior_data): Update.
 267         (nto_inferior_data_cleanup, nto_new_inferior_data)
 268         (_initialize_nto_tdep): Remove.
 269         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 270
 271 2019-05-08  Tom Tromey  <tom@tromey.com>
 272
 273         * ada-lang.c (struct ada_inferior_data): Add initializers.
 274         (ada_inferior_data): Change type.
 275         (ada_inferior_data_cleanup): Remove.
 276         (get_ada_inferior_data, ada_inferior_exit)
 277         (struct ada_pspace_data): Add initializers, destructor.
 278         (ada_pspace_data_handle): Change type.
 279         (get_ada_pspace_data): Update.
 280         (ada_pspace_data_cleanup): Remove.
 281
 282 2019-05-08  Tom Tromey  <tom@tromey.com>
 283
 284         * coffread.c (struct coff_symfile_info): Add initializers.
 285         (coff_objfile_data_key): Move lower.  Change type.
 286         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 287         Update.
 288         (coff_free_info): Remove.
 289
 290 2019-05-08  Tom Tromey  <tom@tromey.com>
 291
 292         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 293         (fbsd_pspace_data_handle): Move lower.  Change type.
 294         (get_fbsd_pspace_data): Update.
 295         (fbsd_pspace_data_cleanup): Remove.
 296         (_initialize_fbsd_tdep): Update.
 297
 298 2019-05-08  Tom Tromey  <tom@tromey.com>
 299
 300         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 301         (get_ada_tasks_pspace_data): Update.
 302         (ada_tasks_pspace_data_cleanup): Remove.
 303         (_initialize_tasks): Update.
 304         (ada_tasks_inferior_data_handle): Change type.
 305         (get_ada_tasks_inferior_data): Update.
 306         (ada_tasks_inferior_data_cleanup): Remove.
 307         (struct ada_tasks_pspace_data): Add initializers.
 308
 309 2019-05-08  Tom Tromey  <tom@tromey.com>
 310
 311         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 312         * symfile-debug.c (debug_sym_get_probes): Change type.
 313         * stap-probe.c (handle_stap_probe):
 314         (stap_static_probe_ops::get_probes): Change type.
 315         * probe.h (class static_probe_ops) <get_probes>: Change type.
 316         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 317         (parse_probes_in_pspace): Update.
 318         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 319         Update.
 320         (any_static_probe_ops::get_probes): Change type.
 321         * elfread.c (elfread_data): New typedef.
 322         (probe_key): Change type.
 323         (elf_get_probes): Likewise.  Update.
 324         (probe_key_free): Remove.
 325         (_initialize_elfread): Update.
 326         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 327         Change type.
 328         (dtrace_process_dof_probe, dtrace_process_dof)
 329         (dtrace_static_probe_ops::get_probe): Change type.
 330
 331 2019-05-08  Tom Tromey  <tom@tromey.com>
 332
 333         * xcoffread.c (struct xcoff_symfile_info): Rename from
 334         coff_symfile_info.  Add initializers.
 335         (xcoff_objfile_data_key): Move lower.  Change type.
 336         (XCOFF_DATA): Rewrite.
 337         (xcoff_free_info): Remove.
 338         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 339         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 340         (xcoff_initial_scan): Update.
 341
 342 2019-05-08  Tom Tromey  <tom@tromey.com>
 343
 344         * solib-svr4.c (struct svr4_info): Add initializers and
 345         destructor.
 346         <probes_table>: Now an htab_up.
 347         (solib_svr4_pspace_data): Change type.
 348         (free_probes_table): Simplify.
 349         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 350         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 351         (probes_table_remove_objfile_probes, register_solib_event_probe)
 352         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 353         (_initialize_svr4_solib): Update.
 354
 355 2019-05-08  Tom Tromey  <tom@tromey.com>
 356
 357         * remote.c (remote_pspace_data): Change type.
 358         (remote_pspace_data_cleanup): Remove.
 359         (get_remote_exec_file, set_pspace_remote_exec_file)
 360         (_initialize_remote): Update.
 361
 362 2019-05-08  Tom Tromey  <tom@tromey.com>
 363
 364         * breakpoint.c (breakpoint_objfile_key): Change type.
 365         (get_breakpoint_objfile_data): Update.
 366         (free_breakpoint_objfile_data): Remove.
 367         (_initialize_breakpoint): Update.
 368
 369 2019-05-08  Tom Tromey  <tom@tromey.com>
 370
 371         * linux-tdep.c (struct linux_info): Add initializers.
 372         (linux_inferior_data): Move.  Change type.
 373         (invalidate_linux_cache_inf): Update.
 374         (linux_inferior_data_cleanup): Remove.
 375         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 376
 377 2019-05-08  Tom Tromey  <tom@tromey.com>
 378
 379         * auxv.c (auxv_inferior_data): Move.  Change type.
 380         (auxv_inferior_data_cleanup): Remove.
 381         (invalidate_auxv_cache_inf): Rewrite.
 382         (get_auxv_inferior_data, _initialize_auxv): Update.
 383
 384 2019-05-08  Tom Tromey  <tom@tromey.com>
 385
 386         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 387         (symfile_debug_objfile_data_key): Change type.
 388         (symfile_debug_installed, debug_qf_has_symbols)
 389         (debug_qf_find_last_source_symtab)
 390         (debug_qf_forget_cached_source_info)
 391         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 392         (debug_qf_print_stats, debug_qf_dump)
 393         (debug_qf_expand_symtabs_for_function)
 394         (debug_qf_expand_all_symtabs)
 395         (debug_qf_expand_symtabs_with_fullname)
 396         (debug_qf_map_matching_symbols)
 397         (debug_qf_expand_symtabs_matching)
 398         (debug_qf_find_pc_sect_compunit_symtab)
 399         (debug_qf_map_symbol_filenames)
 400         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 401         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 402         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 403         (debug_sym_read_linetable, debug_sym_relocate): Update.
 404         (symfile_debug_free_objfile): Remove.
 405         (install_symfile_debug_logging, _initialize_symfile_debug):
 406         Update.
 407
 408 2019-05-08  Tom Tromey  <tom@tromey.com>
 409
 410         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 411         allocate_on_obstack.
 412         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 413         (get_dwarf2_per_objfile): Update.
 414         (set_dwarf2_per_objfile): Remove.
 415         (dwarf2_has_info, dwarf2_get_section_info): Update.
 416         (dwarf2_free_objfile): Remove.
 417         (_initialize_dwarf2_read): Update.
 418
 419 2019-05-08  Tom Tromey  <tom@tromey.com>
 420
 421         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 422         initializers.
 423         <unsupported_script_warning_printed,
 424         script_not_found_warning_printed>: Now bool.
 425         (auto_load_pspace_data): Change type.
 426         (~auto_load_pspace_info): Rename from
 427         auto_load_pspace_data_cleanup.
 428         (get_auto_load_pspace_data, init_loaded_scripts_info)
 429         (clear_section_scripts, maybe_print_unsupported_script_warning)
 430         (maybe_print_script_not_found_warning, _initialize_auto_load):
 431         Update.
 432
 433 2019-05-08  Tom Tromey  <tom@tromey.com>
 434
 435         * objfiles.c (objfile_pspace_info): Add destructor and
 436         initializers.
 437         (objfiles_pspace_data): Change type.
 438         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 439         (get_objfile_pspace_data): Update.
 440         (objfiles_bfd_data): Change type.
 441         (get_objfile_bfd_data): Update.
 442         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 443
 444 2019-05-08  Tom Tromey  <tom@tromey.com>
 445
 446         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 447         Change type.
 448         (get_catch_syscall_inferior_data): Update.
 449         (catch_syscall_inferior_data_cleanup): Remove.
 450         (_initialize_break_catch_syscall): Update.
 451
 452 2019-05-08  Tom Tromey  <tom@tromey.com>
 453
 454         * inflow.c (struct terminal_info): Add destructor and
 455         initializers.
 456         (inflow_inferior_data): Change type.
 457         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 458         (get_inflow_inferior_data, inflow_inferior_exit)
 459         (swap_terminal_info, _initialize_inflow): Update.
 460
 461 2019-05-08  Tom Tromey  <tom@tromey.com>
 462
 463         * target-dcache.c (target_dcache_cleanup): Remove.
 464         (target_dcache_aspace_key): Change type.
 465         (target_dcache_init_p, target_dcache_invalidate)
 466         (target_dcache_get, target_dcache_get_or_init)
 467         (_initialize_target_dcache): Update.
 468         * dcache.h (struct dcache_deleter): New.
 469
 470 2019-05-08  Tom Tromey  <tom@tromey.com>
 471
 472         * symtab.c (struct symbol_cache): Add destructor and
 473         initializers.
 474         (symbol_cache_key): Move.  Change type.
 475         (make_symbol_cache, free_symbol_cache): Remove.
 476         (get_symbol_cache): Update.
 477         (symbol_cache_cleanup): Remove.
 478         (ALL_PSPACES, symbol_cache_flush)
 479         (maintenance_print_symbol_cache)
 480         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 481         Update.
 482
 483 2019-05-08  Tom Tromey  <tom@tromey.com>
 484
 485         * symtab.c (struct main_info): Add destructor and initializers.
 486         (main_progspace_key): Move.  Change type.
 487         (get_main_info): Update.
 488         (main_info_cleanup): Remove.
 489         (_initialize_symtab): Update.
 490
 491 2019-05-08  Tom Tromey  <tom@tromey.com>
 492
 493         * registry.h (DECLARE_REGISTRY): Define the _key class.
 494
 495 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 496
 497         * NEWS: Merge two 'New commands' sections.
 498
 499 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 500
 501         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 502         parameter and use Ada language definition instead.
 503         (ada_val_print_ptr): Remove unused language parameter.
 504         (ada_val_print_num): Remove language parameter and use Ada language
 505         definition instead.
 506         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 507         parameter.
 508         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 509         parameter and use Ada language definition instead.
 510         (ada_val_print_1): Update all ada_val_print_xxx calls.
 511         Remove language parameter.
 512         (ada_val_print): Update ada_val_print_1 call.
 513
 514 2019-05-08  Tom Tromey  <tromey@adacore.com>
 515
 516         * remote.c (remote_hw_watchpoint_limit)
 517         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 518         Now static.
 519
 520 2019-05-08  Tom Tromey  <tromey@adacore.com>
 521
 522         * maint.c (_initialize_maint_cmds): Move initialization code to
 523         remote.c.
 524         (watchdog, show_watchdog): Move to remote.c.
 525         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 526         "watchdog" static.
 527         (_initialize_remote): Move initialization code from maint.c.
 528         * defs.h (watchdog): Don't declare.
 529
 530 2019-05-08  Tom Tromey  <tromey@adacore.com>
 531
 532         * tui/tui-interp.c: Include main.h.
 533         * interps.c: Include main.h.
 534         * main.h (interpreter_p): Declare.
 535         * defs.h (interpreter_p): Don't declare.
 536
 537 2019-05-08  Tom Tromey  <tromey@adacore.com>
 538
 539         * dwarf2loc.c: Include dwarf2read.h.
 540         * defs.h (read_unsigned_leb128): Don't declare.
 541         * dwarf2read.h (read_unsigned_leb128): Declare.
 542
 543 2019-05-08  Tom Tromey  <tromey@adacore.com>
 544
 545         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 546         method.
 547
 548 2019-05-08  Tom Tromey  <tromey@adacore.com>
 549
 550         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 551         when no wrap column is set.
 552
 553 2019-05-08  Tom Tromey  <tromey@adacore.com>
 554
 555         * c-lang.c (c_get_string): Handle non-C-style arrays.
 556
 557 2019-05-08  Tom Tromey  <tromey@adacore.com>
 558
 559         * typeprint.c (print_offset_data::update): Print the bit offset,
 560         not the number of bits remaining.
 561
 562 2019-05-08  Tom Tromey  <tromey@adacore.com>
 563
 564         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 565         padding at end of comment.
 566
 567 2019-05-08  Tom Tromey  <tromey@adacore.com>
 568
 569         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 570         Compare main types.
 571
 572 2019-05-06  Tom Tromey  <tom@tromey.com>
 573
 574         * common/scoped_mmap.c: Include common-defs.h.
 575         * common/scoped_mmap.h: Don't include config.h.
 576
 577 2019-05-04  Tom Tromey  <tom@tromey.com>
 578
 579         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 580         (struct aarch64_call_info): Add initializers.
 581         <si>: Now a std::vector.
 582         (pass_on_stack, aarch64_push_dummy_call): Update.
 583
 584 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 585             Tom Tromey  <tom@tromey.com>
 586
 587         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 588         (ppc_threads): Now a std::vector.  Now static.
 589         (hwdebug_find_thread_points_by_tid)
 590         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 591         Update.
 592
 593 2019-05-04  Tom Tromey  <tom@tromey.com>
 594
 595         * arc-tdep.c (arc_tdesc_init): Return bool.
 596
 597 2019-05-04  Tom Tromey  <tom@tromey.com>
 598
 599         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 600         Use gdb_assert_not_reached.
 601
 602 2019-05-04  Tom Tromey  <tom@tromey.com>
 603
 604         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 605         "false".
 606
 607 2019-05-04  Tom Tromey  <tom@tromey.com>
 608
 609         * arc-tdep.c (arc_tdesc_init): Use bool.
 610
 611 2019-05-04  Tom Tromey  <tom@tromey.com>
 612
 613         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 614
 615 2019-05-04  Tom Tromey  <tom@tromey.com>
 616
 617         * cli/cli-cmds.c (valid_command_p): Return bool.
 618
 619 2019-05-04  Tom Tromey  <tom@tromey.com>
 620
 621         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 622         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 623
 624 2019-05-04  Raul Tambre  <raul@tambre.ee>
 625
 626         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 627         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 628         operator for comparison.
 629
 630 2019-05-04  Tom Tromey  <tom@tromey.com>
 631
 632         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 633         (lookup_partial_symbol, print_partial_symbols)
 634         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 635         (psymbol_compare): Update.
 636         (add_psymbol_to_bcache): Clear the entire psymbol.
 637         (maintenance_check_psymtabs): Update.
 638         * psympriv.h (struct partial_symbol): Don't derive from
 639         general_symbol_info.
 640         <obj_section, unrelocated_address, address,
 641         set_unrelocated_address>: Update.
 642         <ginfo>: New member.
 643         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 644         (debug_names::write_psymbols): Update.
 645
 646 2019-05-04  Tom de Vries  <tdevries@suse.de>
 647
 648         * contrib/cc-with-tweaks.sh: Support -n arg.
 649
 650 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 651
 652         * corelow.c (core_target::detach): Ensure frame cache and
 653         register caches are cleared.
 654         inferior.c (exit_inferior_1): Likewise.
 655
 656 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 657             Tom Tromey  <tom@tromey.com>
 658
 659         * dictionary.c (collate_pending_symbols_by_language): Remove
 660         "struct" from foreach.
 661         * symtab.c (lookup_global_symbol_from_objfile)
 662         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 663         foreach.
 664         * ser-tcp.c (net_open): Remove "struct" from foreach.
 665         * objfiles.c (objfile_relocate, objfile_rebase)
 666         (objfile_has_symbols): Remove "struct" from foreach.
 667         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 668         from foreach.
 669         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 670         foreach.
 671         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 672         "struct" from foreach.
 673         * ada-lang.c (create_excep_cond_exprs)
 674         (ada_exception_catchpoint_cond_string): Remove "struct" from
 675         foreach.
 676
 677 2019-05-03  Tom Tromey  <tromey@adacore.com>
 678
 679         * ada-exp.y (convert_char_literal): Check suffix of each
 680         enumerator.
 681
 682 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 683
 684         PR ada/21406:
 685         * ada-exp.y (yywrap): Don't define.
 686         * ada-lex.l (%option): Add noyywrap
 687         (yywrap): Remove.
 688
 689 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 690
 691         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 692         _WIN32_WINNT to the XP level, unless already defined to a higher
 693         level.
 694
 695         * unittests/parse-connection-spec-selftests.c:
 696         * ser-tcp.c:
 697         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 698         override.
 699
 700         * symfile.c (find_separate_debug_file): Remove colon from the
 701         drive spec of DOS/Windows file names of the target, so that the
 702         file name produced from DEBUGDIR and the target's directory will
 703         be valid on DOS/Windows systems.
 704
 705 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 706
 707         * rust-lang.c (val_print_struct): Handle printing structures
 708         containing strings.
 709
 710 2019-05-02  Tom Tromey  <tromey@adacore.com>
 711
 712         * valarith.c (_initialize_valarith): Remove.
 713
 714 2019-05-01  Tom Tromey  <tromey@adacore.com>
 715
 716         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 717         bitfields.
 718
 719 2019-05-01  Tom Tromey  <tromey@adacore.com>
 720
 721         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 722         for big-endian copies.
 723
 724 2019-04-30  Ali Tamur  <tamur@google.com>
 725         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 726         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 727         (read_3_bytes): New function.
 728
 729 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 730
 731         * windows-nat.c (main_thread_id): Delete.
 732         (handle_output_debug_string): Replace main_thread_id by
 733         current_event.dwThreadId.
 734         (fake_create_process): Likewise.
 735         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 736         Do not set main_thread_id.
 737         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 738         current_event.dwThreadId.
 739         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 740
 741 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 742
 743         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 744         Use current_event.dwThreadId instead of main_thread_id.
 745
 746 2019-04-30  Tom Tromey  <tromey@adacore.com>
 747
 748         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 749         (create_excep_cond_exprs): Iterate over program spaces.
 750         (ada_exception_catchpoint_cond_string): Examine all minimal
 751         symbols for exception types.
 752
 753 2019-04-30  Tom Tromey  <tromey@adacore.com>
 754
 755         PR c++/24470:
 756         * dwarf2read.c (process_structure_scope): Handle case where type
 757         has template parameters but no symbol was created.
 758
 759 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 760             Chris January  <chris.january@arm.com>
 761
 762         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 763         qualifier.
 764         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 765
 766 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 767
 768         * f-typeprint.c (f_print_type): Update rules for printing
 769         whitespace.
 770         (f_type_print_varspec_suffix): Likewise.
 771
 772 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 773             Chris January  <chris.january@arm.com>
 774
 775         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 776         function arguments.
 777
 778 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * f-lang.c (build_fortran_types): Change name of void type to
 781         lower case.
 782         * f-typeprint.c (f_type_print_base): Print the name of the void
 783         type, rather than a fixed string.
 784         * f-valprint.c (f_decorations): Use lower case void string.
 785
 786 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 787             Chris January  <chris.january@arm.com>
 788
 789         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 790         types for Fortran.
 791
 792 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 793             Chris January  <chris.january@arm.com>
 794             David Lecomber  <david.lecomber@arm.com>
 795
 796         * f-exp.y (BINOP_INTRINSIC): New token.
 797         (exp): New parser rule handling BINOP_INTRINSIC.
 798         (f77_keywords): Add new builtin procedures.
 799         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 800         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 801         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 802         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 803         (print_unop_subexp_f): New function.
 804         (print_binop_subexp_f): New function.
 805         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 806         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 807         (dump_subexp_body_f): Likewise.
 808         (operator_check_f): Likewise.
 809         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 810         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 811
 812 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 813
 814         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 815         UNOP_KIND.
 816         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 817         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 818         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 819         (operator_length_f): New fuction.
 820         (print_subexp_f): New function.
 821         (op_name_f): New function.
 822         (dump_subexp_body_f): New function.
 823         (operator_check_f): New function.
 824         (exp_descriptor_f): Replace standard expression handling functions
 825         with new functions.
 826         * gdb/fortran-operator.def: New file.
 827         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 828         * gdb/std-operator.def: Remove UNOP_KIND.
 829
 830 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 831
 832         * std-operator.def: Remove unbalanced, stray double quote
 833         character.
 834
 835 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 836             Chris January  <chris.january@arm.com>
 837             Daniel Everett  <daniel.everett@arm.com>
 838             Nick Forrington  <nick.forrington@arm.com>
 839             Richard Bunt  <richard.bunt@arm.com>
 840
 841         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 842         of depth when printing anonymous structs or unions.
 843         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 844         Don't print either the top-level value, or the children if the
 845         max-depth is exceeded.
 846         (ppscm_print_children): When printing the key of a map, allow one
 847         extra level of depth.
 848         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 849         print either the top-level value, or the children if the max-depth
 850         is exceeded.
 851         (print_children): When printing the key of a map, allow one extra
 852         level of depth.
 853         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 854         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 855         (user_print_options): Initialise max_depth field.
 856         (val_print_scalar_or_string_type_p): New function.
 857         (val_print): Check to see if the max depth has been reached.
 858         (val_print_check_max_depth): Define new function.
 859         (show_print_max_depth): New function.
 860         (_initialize_valprint): Add 'print max-depth' option.
 861         * valprint.h (struct value_print_options) <max_depth>: New field.
 862         (val_print_check_max_depth): Declare new function.
 863         * NEWS: Document new feature.
 864
 865 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 866
 867         * ada-lang.c (ada_language_defn): Initialise new field.
 868         * c-lang.c (c_is_string_type_p): New function.
 869         (c_language_defn): Initialise new field.
 870         (cplus_language_defn): Initialise new field.
 871         (asm_language_defn): Initialise new field.
 872         (minimal_language_defn): Initialise new field.
 873         * c-lang.h (c_is_string_type_p): Declare new function.
 874         * d-lang.c (d_language_defn): Initialise new field.
 875         * f-lang.c (f_is_string_type_p): New function.
 876         (f_language_defn): Initialise new field.
 877         * go-lang.c (go_is_string_type_p): New function.
 878         (go_language_defn): Initialise new field.
 879         * language.c (default_is_string_type_p): New function.
 880         (unknown_language_defn): Initialise new field.
 881         (auto_language_defn): Initialise new field.
 882         * language.h (struct language_defn) <la_is_string_type_p>: New
 883         member variable.
 884         (default_is_string_type_p): Declare new function.
 885         * m2-lang.c (m2_language_defn): Initialise new field.
 886         * objc-lang.c (objc_language_defn): Initialise new field.
 887         * opencl-lang.c (opencl_language_defn): Initialise new field.
 888         * p-lang.c (pascal_is_string_type_p): New function.
 889         (pascal_language_defn): Initialise new field.
 890         * rust-lang.c (rust_is_string_type_p): New function.
 891         (rust_language_defn): Initialise new field.
 892
 893 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 894
 895         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 896         New field.
 897         * ada-lang.c (ada_language_defn): Initialise new field.
 898         * c-lang.c (c_language_defn): Likewise.
 899         (cplus_language_defn): Likewise.
 900         (asm_language_defn): Likewise.
 901         (minimal_language_defn): Likewise.
 902         * d-lang.c (d_language_defn): Likewise.
 903         * f-lang.c (f_language_defn): Likewise.
 904         * go-lang.c (go_language_defn): Likewise.
 905         * language.c (unknown_language_defn): Likewise.
 906         (auto_language_defn): Likewise.
 907         * m2-lang.c (m2_language_defn): Likewise.
 908         * objc-lang.c (objc_language_defn): Likewise.
 909         * opencl-lang.c (opencl_language_defn): Likewise.
 910         * p-lang.c (pascal_language_defn): Likewise.
 911         * rust-lang.c (rust_language_defn): Likewise.
 912
 913 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 914
 915         * ada-lang.c (ada_is_character_type): Change return type to bool.
 916         (ada_is_string_type): Likewise.
 917         * ada-lang.h (ada_is_character_type): Update declaration
 918         (ada_is_string_type): Likewise.
 919
 920 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 921
 922         Support style in 'frame|thread apply'
 923
 924         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 925         * record.c (record_start, record_stop): Update callers of
 926         execute_command_to_string with false.
 927         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 928         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 929         methods.
 930         (class string_file): New constructor with term_out parameter.
 931         Override methods term_out and can_emit_style_escape.  New member
 932         term_out.
 933         (class stdio_file): Override can_emit_style_escape.
 934         (class tee_file): Override term_out and can_emit_style_escape.
 935         * utils.h (can_emit_style_escape): Remove.
 936         * utils.c (can_emit_style_escape): Likewise.
 937         Update all callers of can_emit_style_escape (SOMESTREAM) to
 938         SOMESTREAM->can_emit_style_escape.
 939         * source-cache.c (source_cache::get_source_lines): Likewise.
 940         * stack.c (frame_apply_command_count): Call execute_command_to_string
 941         passing the term_out characteristic of the current gdb_stdout.
 942         * thread.c (thr_try_catch_cmd): Likewise.
 943         * top.c (execute_command_to_string): pass term_out parameter
 944         to construct the string_file for the command output.
 945         * ui-file.c (term_cli_styling): New function (most code moved
 946         from utils.c can_emit_style_escape).
 947         (string_file::string_file, string_file::can_emit_style_escape,
 948         stdio_file::can_emit_style_escape, tee_file::term_out,
 949         tee_file::can_emit_style_escape): New functions.
 950
 951 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 952
 953         * NEWS: Mention the new set|show may-call-functions.
 954         * infcall.c (may_call_functions_p): New variable.
 955         (show_may_call_functions_p): New function.
 956         (call_function_by_hand_dummy): Throws an error if not
 957         may-call-functions.
 958         (_initialize_infcall): Call add_setshow_boolean_cmd for
 959         may-call-functions.
 960
 961 2019-04-25  Keith Seitz  <keiths@redhat.com>
 962
 963         PR c++/24367
 964         * cp-support.c (inspect_type): Don't attempt substitutions
 965         of symbol with the same name.
 966
 967 2019-04-25  Tom Tromey  <tromey@adacore.com>
 968
 969         PR gdb/24475:
 970         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 971         static.
 972
 973 2019-04-25  Tom Tromey  <tromey@adacore.com>
 974
 975         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 976         rvalue reference.
 977         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 978         (gdb_xml_parser::parse): Use std::move.
 979         * python/python-internal.h (gdbpy_convert_exception): Take a const
 980         reference.
 981         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 982         std::move.
 983         * python/py-utils.c (gdbpy_convert_exception): Take a const
 984         reference.
 985         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 986         Use std::move.
 987         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 988         Use std::move.
 989         * mi/mi-main.c (mi_print_exception): Take a const reference.
 990         * main.c (handle_command_errors): Take a const reference.
 991         * linespec.c (parse_linespec): Use std::move.
 992         * infcall.c (run_inferior_call): Use std::move.
 993         (call_function_by_hand_dummy): Use std::move.
 994         * exec.c (try_open_exec_file): Use std::move.
 995         * exceptions.h (exception_print, exception_fprintf)
 996         (exception_print_same): Update.
 997         * exceptions.c (print_exception, exception_print)
 998         (exception_fprintf, exception_print_same): Change parameters to
 999         const reference.
1000         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1001         * common/new-op.c: Use std::move.
1002         * common/common-exceptions.h (struct gdb_exception): Add move
1003         constructor.
1004         (struct gdb_exception_error, struct gdb_exception_quit, struct
1005         gdb_quit_bad_alloc): Change constructor to move constructor.
1006         (throw_exception): Change parameter to rvalue reference.
1007         * common/common-exceptions.c (throw_exception): Take rvalue
1008         reference.
1009         * cli/cli-interp.c (safe_execute_command): Use std::move.
1010         * breakpoint.c (insert_bp_location, location_to_sals): Use
1011         std::move.
1012
1013 2019-04-25  Tom Tromey  <tromey@adacore.com>
1014
1015         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1016         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1017         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1018         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1019         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1020         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1021         guile/scm-value.c: Use unpack.
1022         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1023         gdbscm_gdb_exception.
1024         (gdbscm_throw_gdb_exception): Likewise.
1025         (struct gdbscm_gdb_exception): New.
1026         (unpack): New function.
1027         (gdbscm_wrap): Use unpack.
1028
1029 2019-04-25  Tom Tromey  <tromey@adacore.com>
1030
1031         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1032         (gdb_rl_callback_handler): Use std::move.
1033         * common/common-exceptions.h (struct gdb_exception): Add move
1034         assignment operator.
1035         (throw_exception_sjlj): Change "exception" to const reference.
1036         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1037         (throw_exception_sjlj): Change "exception" to const reference.
1038
1039 2019-04-25  Tom Tromey  <tromey@adacore.com>
1040
1041         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1042         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1043         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1044         Update.
1045         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1046         Update.
1047         * mi/mi-interp.c (mi_interp::exec): Update.
1048         * linespec.c (parse_linespec): Update.
1049         * infcall.c (run_inferior_call): Update.
1050         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1051         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1052         (gdbscm_lookup_global_symbol): Update.
1053         * guile/scm-param.c (gdbscm_parameter_value): Update.
1054         * guile/scm-frame.c (gdbscm_frame_read_register)
1055         (gdbscm_frame_read_var): Update.
1056         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1057         * exec.c (try_open_exec_file): Update.
1058         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1059         (gdb_rl_callback_handler): Update.
1060         * common/common-exceptions.h (exception_none): Don't declare.
1061         * common/common-exceptions.c (exception_none): Don't define.
1062         (struct catcher) <exception>: Update.
1063         * cli/cli-interp.c (safe_execute_command): Update.
1064         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1065
1066 2019-04-25  Ali Tamur  <tamur@google.com>
1067
1068         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1069         (read_attribute_value): Likewise.
1070         (dwarf2_read_addr_index): Update comment.
1071         (read_str_index): Add DW_FORM_strx.
1072         (dwarf2_string_attr): Likewise.
1073         (dwarf2_const_value_attr): Likewise.
1074         (dump_die_shallow): Likewise.
1075         (dwarf2_fetch_constant_bytes): Likewise.
1076         (skip_form_bytes): Likewise.
1077         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1078
1079 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1080
1081         PR corefiles/11608
1082         PR corefiles/18187
1083         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1084         OFFSET.  Verify if current mapping contains an ELF header.
1085         (linux_find_memory_regions_full): Adjust call to
1086         dump_mapping_p.
1087
1088 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1089             Kang Li <kanglictf@gmail.com>
1090
1091         PR gdb/21600
1092
1093         * dwarf2-frame.c (read_initial_length): Be consistent about using
1094         unsigned representation of length.
1095         (decode_frame_entry_1): Likewise.  Check for wraparound of
1096         end pointer as well as buffer overflow.
1097
1098 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1099
1100         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1101         "vq".
1102
1103 2019-04-24  Tom Tromey  <tromey@adacore.com>
1104
1105         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1106
1107 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1108
1109         * s12z-tdep.c (s12z_unwind_pc): Delete.
1110         (s12z_unwind_sp): Delete.
1111         (s12z_gdbarch_init): Don't register deleted functions with
1112         gdbarch.
1113
1114 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1115
1116         * rl78-tdep.c (rl78_unwind_sp): Delete.
1117         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1118
1119 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1120
1121         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1122         (xstormy16_unwind_pc): Delete.
1123         (xstormy16_dummy_id): Delete.
1124         (xstormy16_gdbarch_init): Don't register deleted functions with
1125         gdbarch.
1126
1127 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1128
1129         * vax-tdep.c (vax_unwind_pc): Delete.
1130         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1131
1132 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1133
1134         * v850-tdep.c (v850_unwind_sp): Delete.
1135         (v850_unwind_pc): Delete.
1136         (v850_dummy_id): Delete.
1137         (v850_gdbarch_init): Don't register deleted functions with
1138         gdbarch.
1139
1140 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1141
1142         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1143         (tilegx_unwind_pc): Delete.
1144         (tilegx_unwind_dummy_id): Delete.
1145         (tilegx_gdbarch_init): Don't register deleted functions with
1146         gdbarch.
1147
1148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1149
1150         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1151         (tic6x_dummy_id): Delete.
1152         (tic6x_gdbarch_init): Don't register deleted functions with
1153         gdbarch.
1154
1155 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1156
1157         * sparc-tdep.c (sparc_unwind_pc): Delete.
1158         (sparc32_gdbarch_init): Don't register deleted function with
1159         gdbarch.
1160
1161 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1162
1163         * sh-tdep.c (sh_unwind_sp): Delete.
1164         (sh_unwind_pc): Delete.
1165         (sh_dummy_id): Delete.
1166         (sh_gdbarch_init): Don't register deleted functions with
1167         gdbarch.
1168
1169 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1170
1171         * score-tdep.c (score_unwind_sp): Delete.
1172         (score_unwind_pc): Delete.
1173         (score_dummy_id): Delete.
1174         (score_gdbarch_init): Don't register deleted functions with
1175         gdbarch.
1176
1177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1178
1179         * rx-tdep.c (rx_unwind_pc): Delete.
1180         (rx_unwind_sp): Delete.
1181         (rx_dummy_id): Delete.
1182         (rx_gdbarch_init): Don't register deleted functions with
1183         gdbarch.  Update comment.
1184
1185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1186
1187         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1188         (rs6000_dummy_id): Delete.
1189         (rs6000_gdbarch_init): Don't register deleted functions with
1190         gdbarch.
1191
1192 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1193
1194         * or1k-tdep.c (or1k_dummy_id): Delete.
1195         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1196
1197 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1198
1199         * nios2-tdep.c (nios2_dummy_id): Delete.
1200         (nios2_unwind_sp): Delete.
1201         (nios2_gdbarch_init): Don't register deleted functions with
1202         gdbarch.
1203
1204 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1205
1206         * nds32-tdep.c (nds32_dummy_id): Delete.
1207         (nds32_unwind_pc): Delete.
1208         (nds32_unwind_sp): Delete.
1209         (nds32_gdbarch_init): Don't register deleted functions with
1210         gdbarch.
1211
1212 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1213
1214         * msp430-tdep.c (msp430_unwind_pc): Delete.
1215         (msp430_unwind_sp): Delete.
1216         (msp430_dummy_id): Delete.
1217         (msp430_gdbarch_init): Don't register deleted functions with
1218         gdbarch.
1219
1220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1221
1222         * moxie-tdep.c (moxie_unwind_sp): Delete.
1223         (moxie_unwind_pc): Delete.
1224         (moxie_dummy_id): Delete.
1225         (moxie_gdbarch_init): Don't register deleted functions with
1226         gdbarch.
1227
1228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1229
1230         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1231         (mn10300_unwind_pc): Delete.
1232         (mn10300_unwind_sp): Delete.
1233         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1234         mn10300_unwind_sp.
1235         (mn10300_frame_unwind_init): Don't register deleted functions with
1236         gdbarch.
1237
1238 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1239
1240         * mep-tdep.c (mep_unwind_pc): Delete.
1241         (mep_unwind_sp): Delete.
1242         (mep_dummy_id): Delete.
1243         (mep_gdbarch_init): Don't register deleted functions with
1244         gdbarch.
1245
1246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1247
1248         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1249         (m68hc11_unwind_sp): Delete.
1250         (m68hc11_gdbarch_init): Don't register deleted functions with
1251         gdbarch.
1252
1253 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1254
1255         * m32r-tdep.c (m32r_unwind_sp): Delete.
1256         (m32r_unwind_pc): Delete.
1257         (m32r_dummy_id): Delete.
1258         (m32r_gdbarch_init): Don't register deleted functions with
1259         gdbarch.
1260
1261 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1262
1263         * m32c-tdep.c (m32c_unwind_pc): Delete.
1264         (m32c_unwind_sp): Delete.
1265         (m32c_dummy_id): Delete.
1266         (m32c_gdbarch_init): Don't register deleted functions with
1267         gdbarch.
1268
1269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1270
1271         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1272         (lm32_unwind_pc): Delete.
1273         (lm32_dummy_id): Delete.
1274         (lm32_gdbarch_init): Don't register deleted functions with
1275         gdbarch.
1276
1277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1278
1279         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1280         (iq2000_unwind_pc): Delete.
1281         (iq2000_dummy_id): Delete.
1282         (iq2000_gdbarch_init): Don't register deleted functions with
1283         gdbarch.
1284
1285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1286
1287         * nds32-tdep.c (nds32_type_align): Delete.
1288         (nds32_push_dummy_call): Use type_align instead.
1289
1290 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1291
1292         * arm-tdep.c (arm_type_align): Only handle vector override case.
1293         (arm_push_dummy_call): Use type_align.
1294         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1295
1296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1297
1298         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1299         case.
1300         (pass_on_stack): Use type_align.
1301         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1302         function.
1303
1304 2019-04-23  Tom Tromey  <tromey@adacore.com>
1305
1306         * dwarf2read.c (line_header::file_name_at): Remove unused
1307         overload.
1308
1309 2019-04-23  Tom de Vries  <tdevries@suse.de>
1310
1311         PR gdb/24438
1312         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1313         invocation.
1314
1315
1316 2019-03-27  Ali Tamur  <tamur@google.com>
1317
1318         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1319         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1320         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1321         (dwarf_expr_context::get_addr_index): Likewise
1322         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1323         (symbol_needs_eval_context::get_addr_index): Likewise
1324         (disassemble_dwarf_expression): Add DW_OP_addrx
1325         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1326         (read_cutu_die_from_dwo): Update comment
1327         (skip_one_die): Add DW_FORM_addrx
1328         (read_attribute_value): Likewise
1329         (var_decode_location): Add DW_OP_addrx
1330         (dwarf2_const_value_attr): Add DW_FORM_addrx
1331         (dump_die_shallow): Likewise
1332         (dwarf2_fetch_constant_bytes): Likewise
1333         (decode_locdesc): Add DW_OP_addrx
1334         (skip_form_bytes): Add DW_FORM_addrx
1335
1336 2019-04-22  Ali Tamur  <tamur@google.com>
1337
1338         * MAINTAINERS (Write After Approval): Add self.
1339
1340 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1341
1342         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1343         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1344         (open_symbol_file_object): Likewise.
1345         (svr4_default_sos): Add info parameter.
1346         (svr4_read_so_list): Likewise.
1347         (svr4_current_sos_direct): Adjust functions calls to pass down
1348         info.
1349         (svr4_current_sos_1): Add info parameter.
1350         (svr4_current_sos): Call get_svr4_info, pass info down to
1351         svr4_current_sos_1.
1352         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1353         get_svr4_info.
1354         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1355         get_svr4_info.
1356         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1357         to get_svr4_info.
1358         (probes_table_remove_objfile_probes): Likewise.
1359         (register_solib_event_probe): Add info parameter.
1360         (solist_update_incremental): Pass info parameter down to
1361         svr4_read_so_list.
1362         (disable_probes_interface): Add info parameter.
1363         (svr4_handle_solib_event): Pass current_program_space to
1364         get_svr4_info.  Adjust disable_probes_interface cleanup.
1365         (svr4_create_probe_breakpoints): Add info parameter, pass it
1366         down to register_solib_event_probe.
1367         (svr4_create_solib_event_breakpoints): Add info parameter,
1368         pass it down to svr4_create_probe_breakpoints.
1369         (enable_break): Pass info down to
1370         svr4_create_solib_event_breakpoints.
1371         (svr4_solib_create_inferior_hook): Pass current_program_space to
1372         get_svr4_info.
1373         (svr4_clear_solib): Likewise.
1374
1375 2019-04-22  Pedro Alves  <palves@redhat.com>
1376
1377         * solib-svr4.c (svr4_free_objfile_observer): New.
1378         (probe_and_action::objfile): New field.
1379         (probes_table_htab_remove_objfile_probes)
1380         (probes_table_remove_objfile_probes): New functions.
1381         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1382         in the new probe_and_action.  Don't store the probe in 'lookup'.
1383         (svr4_create_probe_breakpoints): Pass objfile to
1384         register_solib_event_probe.
1385         (_initialize_svr4_solib): Register a free_objfile observer.
1386
1387 2019-04-19  Tom Tromey  <tom@tromey.com>
1388
1389         * common/queue.h: Remove.
1390
1391 2019-04-19  Tom Tromey  <tom@tromey.com>
1392
1393         * event-loop.c: Don't include "common/queue.h".
1394
1395 2019-04-19  Tom Tromey  <tom@tromey.com>
1396
1397         * remote.c (remote_target): Use delete.
1398         * remote-notif.h: Include <list>, not "common/queue.h".
1399         (notif_client_p): Remove typedef.
1400         (remote_notif_state): Add constructor, destructor, initializer.
1401         <notif_queue>: Now a std::list.
1402         (remote_notif_state_xfree): Don't declare.
1403         * remote-notif.c (remote_notif_process, handle_notification)
1404         (remote_notif_state_allocate): Update.
1405         (~remote_notif_state): Rename from remote_notif_state_xfree.
1406
1407 2019-04-19  Tom Tromey  <tom@tromey.com>
1408
1409         * symfile.c (reread_symbols): Update.
1410         * objfiles.c (objfile_register_static_link)
1411         (objfile_lookup_static_link): Update
1412         (~objfile) Don't delete static_links.
1413         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1414
1415 2019-04-19  Tom Tromey  <tom@tromey.com>
1416
1417         * type-stack.h (struct type_stack) <insert>: Constify string.
1418         * type-stack.c (type_stack::insert): Constify string.
1419         * gdbtypes.h (lookup_template_type): Update.
1420         (address_space_name_to_int): Update.
1421         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1422         const.
1423         (lookup_template_type): Make name const.
1424         * c-exp.y: Update rules.
1425         (lex_one_token, classify_name, classify_inner_name)
1426         (c_print_token): Update.
1427         * p-exp.y: Update rules.
1428         (yylex): Update.
1429         * f-exp.y: Update rules.
1430         (yylex): Update.
1431         * d-exp.y: Update rules.
1432         (lex_one_token, classify_name, classify_inner_name): Update.
1433         * parse.c (write_dollar_variable, copy_name): Return std::string.
1434         * parser-defs.h (copy_name): Change return type.
1435         * m2-exp.y: Update rules.
1436         (yylex): Update.
1437         * go-exp.y (lex_one_token): Update.
1438         Update rules.
1439         (classify_unsafe_function, classify_packaged_name)
1440         (classify_name, yylex): Update.
1441
1442 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1443
1444         * configure.ac: add --enable-source-highlight switch.
1445         * configure: Regenerate.
1446         * top.c (print_gdb_version): plumb --enable-source-highlight
1447         status to "show configuration".
1448
1449 2019-04-19  Tom Tromey  <tromey@adacore.com>
1450
1451         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1452         Check ADA_TYPE_P.
1453         (empty_record, ada_template_to_fixed_record_type_1)
1454         (template_to_static_fixed_type)
1455         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1456         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1457         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1458         macros.
1459
1460 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1461
1462         PR symtab/24423:
1463         * source.c (print_source_lines_base): Advance "iter" when a
1464         control character is seen.
1465
1466 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1467
1468         * inferior.h (struct infcall_suspend_state_deleter):
1469         Catch exception in destructor to avoid crash.
1470
1471 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1472
1473         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1474         close to the add_com "shell".
1475
1476 2019-04-18  Tom Tromey  <tromey@adacore.com>
1477
1478         * process-stratum-target.h (class process_stratum_target)
1479         <stratum>: Add "final".
1480
1481 2019-04-17  Tom Tromey  <tromey@adacore.com>
1482
1483         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1484         against nullptr before use.
1485
1486 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1487
1488         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1489
1490 2019-04-17  Jim Wilson  <jimw@sifive.com>
1491             Andrew Burgess  <andrew.burgess@embecosm.com>
1492
1493         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1494         code read might fail, assume 4-byte breakpoint in that case.
1495
1496 2019-04-15  Leszek Swirski  <leszeks@google.com>
1497
1498         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1499         rather than a hand-rolled POD check when checking for forced MEMORY
1500         classification.
1501
1502 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1503
1504         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1505         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1506         function.
1507         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1508         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1509         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1510         declaration.
1511
1512 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1513
1514         * aarch64-linux-nat.c
1515         (aarch64_linux_nat_target::thread_architecture): Add override.
1516         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1517         each VQ.
1518
1519 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1520
1521         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1522
1523 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1524
1525         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1526         target types of size 96-bits, add some additional comments, and
1527         check that the builtin type we found was the correct size.
1528
1529 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1530
1531         * utils.c (prompt_for_continue): Don't restore the styling at the
1532         end, as applied_style has the wrong value.  This fixes styling in
1533         long lists of file names that are interrupted by the "Continue?"
1534         prompt.
1535
1536 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1537
1538         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1539         * c-lang.c (c_language_defn): Likewise.
1540         (cplus_language_defn): Likewise.
1541         (asm_language_defn): Likewise.
1542         (minimal_language_defn): Likewise.
1543         * d-lang.c (d_language_defn): Likewise.
1544         * f-lang.c (f_language_defn): Likewise.
1545         * go-lang.c (go_language_defn): Likewise.
1546         * language.c (unknown_language_defn): Likewise.
1547         (auto_language_defn): Likewise.
1548         * language.h (struct language_defn): Remove la_magic field.
1549         (LANG_MAGIC): Delete.
1550         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1551         * objc-lang.c (objc_language_defn): Likewise.
1552         * opencl-lang.c (opencl_language_defn): Likewise.
1553         * p-lang.c (pascal_language_defn): Likewise.
1554         * rust-lang.c (rust_language_defn): Likewise.
1555
1556 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1557
1558         * riscv-tdep.c (riscv_type_align): New function.
1559         (riscv_type_alignment): Delete.
1560         (riscv_arg_location): Use 'type_align'.
1561         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1562
1563 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1564
1565         * gdbtypes.c (type_align): A struct with no non-static fields also
1566         has alignment of 1.
1567
1568 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1569
1570         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1571         component to 0.
1572         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1573         member.
1574         (riscv_struct_info::analyse): New implementation using new
1575         analyse_inner member function.
1576         (riscv_struct_info::field_offset): New member function.
1577         (riscv_struct_info::m_offsets): New member variable.
1578         (riscv_struct_info::analyse_inner): New private member function,
1579         takes the old implementation of riscv_struct_info::analyse but
1580         extended to track field offsets.
1581         (riscv_call_arg_struct): Update the struct folding special cases
1582         to handle cases where empty C++ structs, which are non-zero
1583         length, are found.
1584         (riscv_arg_location): Initialise the length of each location, a
1585         non-zero length now indicates the location is in use.
1586         (riscv_push_dummy_call): Allow for the first location having a
1587         non-zero offset when setting up arguments.
1588         (riscv_return_value): Likewise, but for return values.
1589
1590 2019-04-11  Tom Tromey  <tromey@adacore.com>
1591
1592         * utils.c (internal_vproblem): Make "msg" const.
1593
1594 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1595
1596         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1597         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1598         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1599         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1600
1601 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1602
1603         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1604         function.
1605         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1606         of amd64_collect_native_gregset.
1607         (amd64_linux_nat_target::store_registers): Likewise.
1608
1609 2019-04-10  Tom Tromey  <tom@tromey.com>
1610
1611         * symtab.c (lookup_global_symbol_from_objfile)
1612         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1613         * objfiles.h (class separate_debug_iterator): New.
1614         (class separate_debug_range): New.
1615         (struct objfile) <separate_debug_objfiles>: New method.
1616         (objfile_separate_debug_iterate): Don't declare.
1617         * objfiles.c (separate_debug_iterator::operator++): Rename from
1618         objfile_separate_debug_iterate.
1619         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1620         iterator.
1621         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1622         iterator.
1623
1624 2019-04-10  Tom Tromey  <tom@tromey.com>
1625
1626         * symfile.c (reread_symbols): Remove old comment.
1627         * objfiles.c (free_all_objfiles): Fix a typo.
1628
1629 2019-04-10  Tom Tromey  <tom@tromey.com>
1630
1631         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1632         * minsyms.c (lookup_minimal_symbol): Use foreach.
1633         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1634         (lookup_minimal_symbol_solib_trampoline): Likewise.
1635         * symfile.c (reread_symbols): Use foreach.
1636
1637 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1638             Tom Tromey  <tromey@adacore.com>
1639
1640         PR rust/24414:
1641         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1642         (rust_lex_int_test): Change "value" to be LONGEST.
1643         (rust_lex_tests): Add test for long integer literal.
1644
1645 2019-04-09  Tom Tromey  <tromey@adacore.com>
1646
1647         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1648         to bool.
1649         (extended_remote_target::attach): Update.
1650         (remote_target::remote_notice_new_inferior): Update.
1651         (remote_target::add_current_inferior_and_thread): Update.
1652         * inferior.c (exit_inferior_1): Use "false".
1653         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1654
1655 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1656
1657         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1658         the "start" command.
1659
1660 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1661
1662         * python/py-inferior.c (infpy_thread_from_thread_handle):
1663         Adjust comments to reflect renaming of thread_from_thread_handle
1664         to thread_from_handle.  Adjust keywords.  Fix type error message.
1665         (inferior_object_methods): Add thread_from_handle.  Retain
1666         thread_from_thread_handle, but mark it as deprecated.
1667
1668 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1669
1670         * gdbthread.h (find_thread_by_handle): Revise declaration.
1671         * thread.c (find_thread_by_handle): Likewise.  Adjust
1672         implementation too.
1673         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1674         support for buffer objects as handles.
1675
1676 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1677
1678         * python/py-infthread.c (thpy_thread_handle): New function.
1679         (thread_object_methods): Register thpy_thread_handle.
1680
1681 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1682
1683         * gdbthread.h (thread_to_thread_handle): Declare.
1684         * thread.c (gdbtypes.h): Include.
1685         (thread_to_thread_handle): New function.
1686
1687         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1688         (target_thread_info_to_thread_handle): Declare.
1689         * target.c (target_thread_info_to_thread_handle): New function.
1690         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1691         * target-delegates.c: Regenerate.
1692
1693         * linux-thread-db.c (class thread_db_target): Add method
1694         thread_info_to_thread_handle.
1695         (thread_db_target::thread_info_to_thread_handle): Define.
1696         * remote.c (class remote_target): Add new method
1697         thread_info_to_thread_handle.
1698         (remote_target::thread_info_to_thread_handle): Define.
1699
1700 2019-04-08  Pedro Alves  <palves@redhat.com>
1701
1702         * common/common-exceptions.c (throw_exception): Don't create
1703         named object to throw; throw directly.
1704         (throw_it): Likewise.  Don't initialize gdb_exception::message
1705         here, with new; pass FMT and AP to the ctor instead.
1706         * common/common-exceptions.h: Include <string>.
1707         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1708         const char *, va_list)): New ctor.  Use std::make_shared.
1709         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1710         errors)): Delete.
1711         (gdb_exception_error::gdb_exception_error(enum errors, const char
1712         *, va_list)): New.
1713         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1714         Add assertion.
1715         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1716         errors)): Delete.
1717         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1718         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1719         Add assertion.
1720
1721 2019-04-08  Tom Tromey  <tom@tromey.com>
1722
1723         * valops.c (value_rtti_indirect_type): Replace throw_exception
1724         with throw.
1725         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1726         with throw.
1727         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1728         throw.
1729         * target.c (target_translate_tls_address): Replace throw_exception
1730         with throw.
1731         * stack.c (frame_apply_command_count): Replace throw_exception
1732         with throw.
1733         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1734         throw.
1735         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1736         with throw.
1737         * rs6000-tdep.c (rs6000_frame_cache)
1738         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1739         * remote.c: Replace throw_exception with throw.
1740         * record-full.c (record_full_message, record_full_wait_1)
1741         (record_full_restore): Replace throw_exception with throw.
1742         * record-btrace.c:
1743         (get_thread_current_frame_id, record_btrace_start_replaying)
1744         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1745         (cmd_record_btrace_start): Replace throw_exception with throw.
1746         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1747         throw.
1748         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1749         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1750         * linespec.c:
1751         (find_linespec_symbols): Replace throw_exception with throw.
1752         * infrun.c (displaced_step_prepare, resume): Replace
1753         throw_exception with throw.
1754         * infcmd.c (post_create_inferior): Replace throw_exception with
1755         throw.
1756         * inf-loop.c (inferior_event_handler): Replace throw_exception
1757         with throw.
1758         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1759         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1760         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1761         (get_prev_frame_always, get_frame_pc_if_available)
1762         (get_frame_address_in_block_if_available, get_frame_language):
1763         Replace throw_exception with throw.
1764         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1765         throw_exception with throw.
1766         * eval.c (fetch_subexp_value, evaluate_var_value)
1767         (evaluate_funcall, evaluate_subexp_standard): Replace
1768         throw_exception with throw.
1769         * dwarf2loc.c (call_site_find_chain)
1770         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1771         Replace throw_exception with throw.
1772         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1773         with throw.
1774         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1775         throw.
1776         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1777         * completer.c (complete_line_internal): Replace throw_exception
1778         with throw.
1779         * compile/compile-object-run.c (compile_object_run): Replace
1780         throw_exception with throw.
1781         * cli/cli-script.c (process_next_line): Replace throw_exception
1782         with throw.
1783         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1784         (btrace_enable, btrace_maint_update_pt_packets): Replace
1785         throw_exception with throw.
1786         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1787         throw_exception with throw.
1788         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1789         throw_exception with throw.
1790         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1791         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1792         * aarch64-tdep.c (aarch64_make_prologue_cache)
1793         (aarch64_make_stub_cache): Replace throw_exception with throw.
1794
1795 2019-04-08  Tom Tromey  <tom@tromey.com>
1796
1797         * common/common-exceptions.c (throw_exception): Rename from
1798         throw_exception_cxx.  Remove old copy.  Make argument const.
1799         (throw_it): Create and throw exception objects directly.
1800         * common/common-exceptions.h (throw_exception): Make argument
1801         const.
1802         (struct gdb_exception_error): Add constructor.
1803         (struct gdb_exception_quit): Add constructor.
1804
1805 2019-04-08  Tom Tromey  <tom@tromey.com>
1806
1807         * common/common-exceptions.h (exception_rethrow): Don't declare.
1808         (TRY_SJLJ): Update comment.
1809         (TRY, CATCH, END_CATCH): Remove.
1810         * common/common-exceptions.c (exception_rethrow): Remove.
1811
1812 2019-04-08  Tom Tromey  <tom@tromey.com>
1813
1814         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1815         Remove.
1816         (gdb_exception_error): Rename from
1817         gdb_exception_RETURN_MASK_ERROR.
1818         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1819         (gdb_quit_bad_alloc): Update.
1820         * aarch64-tdep.c: Update.
1821         * ada-lang.c: Update.
1822         * ada-typeprint.c: Update.
1823         * ada-valprint.c: Update.
1824         * amd64-tdep.c: Update.
1825         * arch-utils.c: Update.
1826         * break-catch-throw.c: Update.
1827         * breakpoint.c: Update.
1828         * btrace.c: Update.
1829         * c-varobj.c: Update.
1830         * cli/cli-cmds.c: Update.
1831         * cli/cli-interp.c: Update.
1832         * cli/cli-script.c: Update.
1833         * common/common-exceptions.c: Update.
1834         * common/new-op.c: Update.
1835         * common/selftest.c: Update.
1836         * compile/compile-c-symbols.c: Update.
1837         * compile/compile-cplus-symbols.c: Update.
1838         * compile/compile-object-load.c: Update.
1839         * compile/compile-object-run.c: Update.
1840         * completer.c: Update.
1841         * corelow.c: Update.
1842         * cp-abi.c: Update.
1843         * cp-support.c: Update.
1844         * cp-valprint.c: Update.
1845         * darwin-nat.c: Update.
1846         * disasm-selftests.c: Update.
1847         * dtrace-probe.c: Update.
1848         * dwarf-index-cache.c: Update.
1849         * dwarf-index-write.c: Update.
1850         * dwarf2-frame-tailcall.c: Update.
1851         * dwarf2-frame.c: Update.
1852         * dwarf2loc.c: Update.
1853         * dwarf2read.c: Update.
1854         * eval.c: Update.
1855         * event-loop.c: Update.
1856         * event-top.c: Update.
1857         * exec.c: Update.
1858         * f-valprint.c: Update.
1859         * fbsd-tdep.c: Update.
1860         * frame-unwind.c: Update.
1861         * frame.c: Update.
1862         * gdbtypes.c: Update.
1863         * gnu-v3-abi.c: Update.
1864         * guile/guile-internal.h: Update.
1865         * guile/scm-block.c: Update.
1866         * guile/scm-breakpoint.c: Update.
1867         * guile/scm-cmd.c: Update.
1868         * guile/scm-disasm.c: Update.
1869         * guile/scm-frame.c: Update.
1870         * guile/scm-lazy-string.c: Update.
1871         * guile/scm-math.c: Update.
1872         * guile/scm-param.c: Update.
1873         * guile/scm-ports.c: Update.
1874         * guile/scm-pretty-print.c: Update.
1875         * guile/scm-symbol.c: Update.
1876         * guile/scm-symtab.c: Update.
1877         * guile/scm-type.c: Update.
1878         * guile/scm-value.c: Update.
1879         * i386-linux-tdep.c: Update.
1880         * i386-tdep.c: Update.
1881         * inf-loop.c: Update.
1882         * infcall.c: Update.
1883         * infcmd.c: Update.
1884         * infrun.c: Update.
1885         * jit.c: Update.
1886         * language.c: Update.
1887         * linespec.c: Update.
1888         * linux-fork.c: Update.
1889         * linux-nat.c: Update.
1890         * linux-tdep.c: Update.
1891         * linux-thread-db.c: Update.
1892         * main.c: Update.
1893         * mi/mi-cmd-break.c: Update.
1894         * mi/mi-cmd-stack.c: Update.
1895         * mi/mi-interp.c: Update.
1896         * mi/mi-main.c: Update.
1897         * objc-lang.c: Update.
1898         * p-valprint.c: Update.
1899         * parse.c: Update.
1900         * ppc-linux-tdep.c: Update.
1901         * printcmd.c: Update.
1902         * python/py-arch.c: Update.
1903         * python/py-breakpoint.c: Update.
1904         * python/py-cmd.c: Update.
1905         * python/py-finishbreakpoint.c: Update.
1906         * python/py-frame.c: Update.
1907         * python/py-framefilter.c: Update.
1908         * python/py-gdb-readline.c: Update.
1909         * python/py-inferior.c: Update.
1910         * python/py-infthread.c: Update.
1911         * python/py-lazy-string.c: Update.
1912         * python/py-linetable.c: Update.
1913         * python/py-objfile.c: Update.
1914         * python/py-param.c: Update.
1915         * python/py-prettyprint.c: Update.
1916         * python/py-progspace.c: Update.
1917         * python/py-record-btrace.c: Update.
1918         * python/py-record.c: Update.
1919         * python/py-symbol.c: Update.
1920         * python/py-type.c: Update.
1921         * python/py-unwind.c: Update.
1922         * python/py-utils.c: Update.
1923         * python/py-value.c: Update.
1924         * python/python.c: Update.
1925         * record-btrace.c: Update.
1926         * record-full.c: Update.
1927         * remote-fileio.c: Update.
1928         * remote.c: Update.
1929         * riscv-tdep.c: Update.
1930         * rs6000-aix-tdep.c: Update.
1931         * rs6000-tdep.c: Update.
1932         * rust-exp.y: Update.
1933         * rust-lang.c: Update.
1934         * s390-tdep.c: Update.
1935         * selftest-arch.c: Update.
1936         * solib-dsbt.c: Update.
1937         * solib-frv.c: Update.
1938         * solib-spu.c: Update.
1939         * solib-svr4.c: Update.
1940         * solib.c: Update.
1941         * sparc64-linux-tdep.c: Update.
1942         * stack.c: Update.
1943         * symfile-mem.c: Update.
1944         * symmisc.c: Update.
1945         * target.c: Update.
1946         * thread.c: Update.
1947         * top.c: Update.
1948         * tracefile-tfile.c: Update.
1949         * tui/tui.c: Update.
1950         * typeprint.c: Update.
1951         * unittests/cli-utils-selftests.c: Update.
1952         * unittests/parse-connection-spec-selftests.c: Update.
1953         * valops.c: Update.
1954         * valprint.c: Update.
1955         * value.c: Update.
1956         * varobj.c: Update.
1957         * windows-nat.c: Update.
1958         * x86-linux-nat.c: Update.
1959         * xml-support.c: Update.
1960
1961 2019-04-08  Tom Tromey  <tom@tromey.com>
1962
1963         * xml-support.c: Use C++ exception handling.
1964         * x86-linux-nat.c: Use C++ exception handling.
1965         * windows-nat.c: Use C++ exception handling.
1966         * varobj.c: Use C++ exception handling.
1967         * value.c: Use C++ exception handling.
1968         * valprint.c: Use C++ exception handling.
1969         * valops.c: Use C++ exception handling.
1970         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1971         handling.
1972         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1973         * typeprint.c: Use C++ exception handling.
1974         * tui/tui.c: Use C++ exception handling.
1975         * tracefile-tfile.c: Use C++ exception handling.
1976         * top.c: Use C++ exception handling.
1977         * thread.c: Use C++ exception handling.
1978         * target.c: Use C++ exception handling.
1979         * symmisc.c: Use C++ exception handling.
1980         * symfile-mem.c: Use C++ exception handling.
1981         * stack.c: Use C++ exception handling.
1982         * sparc64-linux-tdep.c: Use C++ exception handling.
1983         * solib.c: Use C++ exception handling.
1984         * solib-svr4.c: Use C++ exception handling.
1985         * solib-spu.c: Use C++ exception handling.
1986         * solib-frv.c: Use C++ exception handling.
1987         * solib-dsbt.c: Use C++ exception handling.
1988         * selftest-arch.c: Use C++ exception handling.
1989         * s390-tdep.c: Use C++ exception handling.
1990         * rust-lang.c: Use C++ exception handling.
1991         * rust-exp.y: Use C++ exception handling.
1992         * rs6000-tdep.c: Use C++ exception handling.
1993         * rs6000-aix-tdep.c: Use C++ exception handling.
1994         * riscv-tdep.c: Use C++ exception handling.
1995         * remote.c: Use C++ exception handling.
1996         * remote-fileio.c: Use C++ exception handling.
1997         * record-full.c: Use C++ exception handling.
1998         * record-btrace.c: Use C++ exception handling.
1999         * python/python.c: Use C++ exception handling.
2000         * python/py-value.c: Use C++ exception handling.
2001         * python/py-utils.c: Use C++ exception handling.
2002         * python/py-unwind.c: Use C++ exception handling.
2003         * python/py-type.c: Use C++ exception handling.
2004         * python/py-symbol.c: Use C++ exception handling.
2005         * python/py-record.c: Use C++ exception handling.
2006         * python/py-record-btrace.c: Use C++ exception handling.
2007         * python/py-progspace.c: Use C++ exception handling.
2008         * python/py-prettyprint.c: Use C++ exception handling.
2009         * python/py-param.c: Use C++ exception handling.
2010         * python/py-objfile.c: Use C++ exception handling.
2011         * python/py-linetable.c: Use C++ exception handling.
2012         * python/py-lazy-string.c: Use C++ exception handling.
2013         * python/py-infthread.c: Use C++ exception handling.
2014         * python/py-inferior.c: Use C++ exception handling.
2015         * python/py-gdb-readline.c: Use C++ exception handling.
2016         * python/py-framefilter.c: Use C++ exception handling.
2017         * python/py-frame.c: Use C++ exception handling.
2018         * python/py-finishbreakpoint.c: Use C++ exception handling.
2019         * python/py-cmd.c: Use C++ exception handling.
2020         * python/py-breakpoint.c: Use C++ exception handling.
2021         * python/py-arch.c: Use C++ exception handling.
2022         * printcmd.c: Use C++ exception handling.
2023         * ppc-linux-tdep.c: Use C++ exception handling.
2024         * parse.c: Use C++ exception handling.
2025         * p-valprint.c: Use C++ exception handling.
2026         * objc-lang.c: Use C++ exception handling.
2027         * mi/mi-main.c: Use C++ exception handling.
2028         * mi/mi-interp.c: Use C++ exception handling.
2029         * mi/mi-cmd-stack.c: Use C++ exception handling.
2030         * mi/mi-cmd-break.c: Use C++ exception handling.
2031         * main.c: Use C++ exception handling.
2032         * linux-thread-db.c: Use C++ exception handling.
2033         * linux-tdep.c: Use C++ exception handling.
2034         * linux-nat.c: Use C++ exception handling.
2035         * linux-fork.c: Use C++ exception handling.
2036         * linespec.c: Use C++ exception handling.
2037         * language.c: Use C++ exception handling.
2038         * jit.c: Use C++ exception handling.
2039         * infrun.c: Use C++ exception handling.
2040         * infcmd.c: Use C++ exception handling.
2041         * infcall.c: Use C++ exception handling.
2042         * inf-loop.c: Use C++ exception handling.
2043         * i386-tdep.c: Use C++ exception handling.
2044         * i386-linux-tdep.c: Use C++ exception handling.
2045         * guile/scm-value.c: Use C++ exception handling.
2046         * guile/scm-type.c: Use C++ exception handling.
2047         * guile/scm-symtab.c: Use C++ exception handling.
2048         * guile/scm-symbol.c: Use C++ exception handling.
2049         * guile/scm-pretty-print.c: Use C++ exception handling.
2050         * guile/scm-ports.c: Use C++ exception handling.
2051         * guile/scm-param.c: Use C++ exception handling.
2052         * guile/scm-math.c: Use C++ exception handling.
2053         * guile/scm-lazy-string.c: Use C++ exception handling.
2054         * guile/scm-frame.c: Use C++ exception handling.
2055         * guile/scm-disasm.c: Use C++ exception handling.
2056         * guile/scm-cmd.c: Use C++ exception handling.
2057         * guile/scm-breakpoint.c: Use C++ exception handling.
2058         * guile/scm-block.c: Use C++ exception handling.
2059         * guile/guile-internal.h: Use C++ exception handling.
2060         * gnu-v3-abi.c: Use C++ exception handling.
2061         * gdbtypes.c: Use C++ exception handling.
2062         * frame.c: Use C++ exception handling.
2063         * frame-unwind.c: Use C++ exception handling.
2064         * fbsd-tdep.c: Use C++ exception handling.
2065         * f-valprint.c: Use C++ exception handling.
2066         * exec.c: Use C++ exception handling.
2067         * event-top.c: Use C++ exception handling.
2068         * event-loop.c: Use C++ exception handling.
2069         * eval.c: Use C++ exception handling.
2070         * dwarf2read.c: Use C++ exception handling.
2071         * dwarf2loc.c: Use C++ exception handling.
2072         * dwarf2-frame.c: Use C++ exception handling.
2073         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2074         * dwarf-index-write.c: Use C++ exception handling.
2075         * dwarf-index-cache.c: Use C++ exception handling.
2076         * dtrace-probe.c: Use C++ exception handling.
2077         * disasm-selftests.c: Use C++ exception handling.
2078         * darwin-nat.c: Use C++ exception handling.
2079         * cp-valprint.c: Use C++ exception handling.
2080         * cp-support.c: Use C++ exception handling.
2081         * cp-abi.c: Use C++ exception handling.
2082         * corelow.c: Use C++ exception handling.
2083         * completer.c: Use C++ exception handling.
2084         * compile/compile-object-run.c: Use C++ exception handling.
2085         * compile/compile-object-load.c: Use C++ exception handling.
2086         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2087         * compile/compile-c-symbols.c: Use C++ exception handling.
2088         * common/selftest.c: Use C++ exception handling.
2089         * common/new-op.c: Use C++ exception handling.
2090         * cli/cli-script.c: Use C++ exception handling.
2091         * cli/cli-interp.c: Use C++ exception handling.
2092         * cli/cli-cmds.c: Use C++ exception handling.
2093         * c-varobj.c: Use C++ exception handling.
2094         * btrace.c: Use C++ exception handling.
2095         * breakpoint.c: Use C++ exception handling.
2096         * break-catch-throw.c: Use C++ exception handling.
2097         * arch-utils.c: Use C++ exception handling.
2098         * amd64-tdep.c: Use C++ exception handling.
2099         * ada-valprint.c: Use C++ exception handling.
2100         * ada-typeprint.c: Use C++ exception handling.
2101         * ada-lang.c: Use C++ exception handling.
2102         * aarch64-tdep.c: Use C++ exception handling.
2103
2104 2019-04-08  Tom Tromey  <tom@tromey.com>
2105
2106         * xml-support.c (gdb_xml_parser::parse): Update.
2107         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2108         * value.c (show_convenience): Update.
2109         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2110         (test_parse_flags_qcs): Update.
2111         * thread.c (thr_try_catch_cmd): Update.
2112         * target.c (target_translate_tls_address): Update.
2113         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2114         (info_frame_command_core, frame_apply_command_count): Update.
2115         * rust-exp.y (rust_lex_exception_test): Update.
2116         * riscv-tdep.c (riscv_print_one_register_info): Update.
2117         * remote.c (remote_target::enable_btrace): Update.
2118         * record-btrace.c (record_btrace_enable_warn): Update.
2119         * python/py-utils.c (gdbpy_convert_exception): Update.
2120         * printcmd.c (do_one_display, print_variable_and_value): Update.
2121         * mi/mi-main.c (mi_print_exception): Update.
2122         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2123         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2124         * linux-nat.c (linux_nat_target::attach): Update.
2125         * linux-fork.c (class scoped_switch_fork_info): Update.
2126         * infrun.c (displaced_step_prepare): Update.
2127         * infcall.c (call_function_by_hand_dummy): Update.
2128         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2129         * gnu-v3-abi.c (print_one_vtable): Update.
2130         * frame.c (get_prev_frame_always): Update.
2131         * f-valprint.c (info_common_command_for_block): Update.
2132         * exec.c (try_open_exec_file): Update.
2133         * exceptions.c (print_exception, exception_print)
2134         (exception_fprintf, exception_print_same): Update.
2135         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2136         * dwarf-index-cache.c (index_cache::store)
2137         (index_cache::lookup_gdb_index): Update.
2138         * darwin-nat.c (maybe_cache_shell): Update.
2139         * cp-valprint.c (cp_print_value_fields): Update.
2140         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2141         (gcc_cplus_symbol_address): Update.
2142         * compile/compile-c-symbols.c (gcc_convert_symbol)
2143         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2144         * common/selftest.c: Update.
2145         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2146         a std::string.
2147         (exception_try_scope_entry, exception_try_scope_exit): Don't
2148         declare.
2149         (struct exception_try_scope): Remove.
2150         (TRY): Don't use exception_try_scope.
2151         (struct gdb_exception): Add constructor, operator=.
2152         <what>: New method.
2153         (struct gdb_exception_RETURN_MASK_ALL)
2154         (struct gdb_exception_RETURN_MASK_ERROR)
2155         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2156         (struct gdb_quit_bad_alloc): Update.
2157         * common/common-exceptions.c (exception_none): Change
2158         initializer.
2159         (struct catcher) <state, exception>: Initialize inline.
2160         <prev>: Remove member.
2161         (current_catcher): Remove.
2162         (catchers): New global.
2163         (exceptions_state_mc_init): Simplify.
2164         (catcher_pop): Remove.
2165         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2166         (try_scope_depth, exception_try_scope_entry)
2167         (exception_try_scope_exit): Remove.
2168         (throw_exception_sjlj): Update.
2169         (exception_messages, exception_messages_size): Remove.
2170         (throw_it): Simplify.
2171         (gdb_exception_sliced_copy): Remove.
2172         (throw_exception_cxx): Update.
2173         * cli/cli-script.c (script_from_file): Update.
2174         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2175         Update.
2176         * ada-valprint.c (ada_val_print): Update.
2177         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2178         (create_excep_cond_exprs): Update.
2179
2180 2019-04-08  Tom Tromey  <tom@tromey.com>
2181
2182         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2183         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2184         (TRY, CATCH, END_CATCH): Remove some definitions.
2185         * common/common-exceptions.c: Don't use GDB_XCPT.
2186         (catcher_list_size): Remove.
2187         (throw_exception, throw_it): Simplify.
2188
2189 2019-04-05  Tom Tromey  <tom@tromey.com>
2190
2191         Revert the header-sorting patch.
2192         * ft32-tdep.c: Revert.
2193         * frv-tdep.c: Revert.
2194         * frv-linux-tdep.c: Revert.
2195         * frame.c: Revert.
2196         * frame-unwind.c: Revert.
2197         * frame-base.c: Revert.
2198         * fork-child.c: Revert.
2199         * findvar.c: Revert.
2200         * findcmd.c: Revert.
2201         * filesystem.c: Revert.
2202         * filename-seen-cache.h: Revert.
2203         * filename-seen-cache.c: Revert.
2204         * fbsd-tdep.c: Revert.
2205         * fbsd-nat.h: Revert.
2206         * fbsd-nat.c: Revert.
2207         * f-valprint.c: Revert.
2208         * f-typeprint.c: Revert.
2209         * f-lang.c: Revert.
2210         * extension.h: Revert.
2211         * extension.c: Revert.
2212         * extension-priv.h: Revert.
2213         * expprint.c: Revert.
2214         * exec.h: Revert.
2215         * exec.c: Revert.
2216         * exceptions.c: Revert.
2217         * event-top.c: Revert.
2218         * event-loop.c: Revert.
2219         * eval.c: Revert.
2220         * elfread.c: Revert.
2221         * dwarf2read.h: Revert.
2222         * dwarf2read.c: Revert.
2223         * dwarf2loc.c: Revert.
2224         * dwarf2expr.h: Revert.
2225         * dwarf2expr.c: Revert.
2226         * dwarf2-frame.c: Revert.
2227         * dwarf2-frame-tailcall.c: Revert.
2228         * dwarf-index-write.h: Revert.
2229         * dwarf-index-write.c: Revert.
2230         * dwarf-index-common.c: Revert.
2231         * dwarf-index-cache.h: Revert.
2232         * dwarf-index-cache.c: Revert.
2233         * dummy-frame.c: Revert.
2234         * dtrace-probe.c: Revert.
2235         * disasm.h: Revert.
2236         * disasm.c: Revert.
2237         * disasm-selftests.c: Revert.
2238         * dictionary.c: Revert.
2239         * dicos-tdep.c: Revert.
2240         * demangle.c: Revert.
2241         * dcache.h: Revert.
2242         * dcache.c: Revert.
2243         * darwin-nat.h: Revert.
2244         * darwin-nat.c: Revert.
2245         * darwin-nat-info.c: Revert.
2246         * d-valprint.c: Revert.
2247         * d-namespace.c: Revert.
2248         * d-lang.c: Revert.
2249         * ctf.c: Revert.
2250         * csky-tdep.c: Revert.
2251         * csky-linux-tdep.c: Revert.
2252         * cris-tdep.c: Revert.
2253         * cris-linux-tdep.c: Revert.
2254         * cp-valprint.c: Revert.
2255         * cp-support.c: Revert.
2256         * cp-namespace.c: Revert.
2257         * cp-abi.c: Revert.
2258         * corelow.c: Revert.
2259         * corefile.c: Revert.
2260         * continuations.c: Revert.
2261         * completer.h: Revert.
2262         * completer.c: Revert.
2263         * complaints.c: Revert.
2264         * coffread.c: Revert.
2265         * coff-pe-read.c: Revert.
2266         * cli-out.h: Revert.
2267         * cli-out.c: Revert.
2268         * charset.c: Revert.
2269         * c-varobj.c: Revert.
2270         * c-valprint.c: Revert.
2271         * c-typeprint.c: Revert.
2272         * c-lang.c: Revert.
2273         * buildsym.c: Revert.
2274         * buildsym-legacy.c: Revert.
2275         * build-id.h: Revert.
2276         * build-id.c: Revert.
2277         * btrace.c: Revert.
2278         * bsd-uthread.c: Revert.
2279         * breakpoint.h: Revert.
2280         * breakpoint.c: Revert.
2281         * break-catch-throw.c: Revert.
2282         * break-catch-syscall.c: Revert.
2283         * break-catch-sig.c: Revert.
2284         * blockframe.c: Revert.
2285         * block.c: Revert.
2286         * bfin-tdep.c: Revert.
2287         * bfin-linux-tdep.c: Revert.
2288         * bfd-target.c: Revert.
2289         * bcache.c: Revert.
2290         * ax-general.c: Revert.
2291         * ax-gdb.h: Revert.
2292         * ax-gdb.c: Revert.
2293         * avr-tdep.c: Revert.
2294         * auxv.c: Revert.
2295         * auto-load.c: Revert.
2296         * arm-wince-tdep.c: Revert.
2297         * arm-tdep.c: Revert.
2298         * arm-symbian-tdep.c: Revert.
2299         * arm-pikeos-tdep.c: Revert.
2300         * arm-obsd-tdep.c: Revert.
2301         * arm-nbsd-tdep.c: Revert.
2302         * arm-nbsd-nat.c: Revert.
2303         * arm-linux-tdep.c: Revert.
2304         * arm-linux-nat.c: Revert.
2305         * arm-fbsd-tdep.c: Revert.
2306         * arm-fbsd-nat.c: Revert.
2307         * arm-bsd-tdep.c: Revert.
2308         * arch-utils.c: Revert.
2309         * arc-tdep.c: Revert.
2310         * arc-newlib-tdep.c: Revert.
2311         * annotate.h: Revert.
2312         * annotate.c: Revert.
2313         * amd64-windows-tdep.c: Revert.
2314         * amd64-windows-nat.c: Revert.
2315         * amd64-tdep.c: Revert.
2316         * amd64-sol2-tdep.c: Revert.
2317         * amd64-obsd-tdep.c: Revert.
2318         * amd64-obsd-nat.c: Revert.
2319         * amd64-nbsd-tdep.c: Revert.
2320         * amd64-nbsd-nat.c: Revert.
2321         * amd64-nat.c: Revert.
2322         * amd64-linux-tdep.c: Revert.
2323         * amd64-linux-nat.c: Revert.
2324         * amd64-fbsd-tdep.c: Revert.
2325         * amd64-fbsd-nat.c: Revert.
2326         * amd64-dicos-tdep.c: Revert.
2327         * amd64-darwin-tdep.c: Revert.
2328         * amd64-bsd-nat.c: Revert.
2329         * alpha-tdep.c: Revert.
2330         * alpha-obsd-tdep.c: Revert.
2331         * alpha-nbsd-tdep.c: Revert.
2332         * alpha-mdebug-tdep.c: Revert.
2333         * alpha-linux-tdep.c: Revert.
2334         * alpha-linux-nat.c: Revert.
2335         * alpha-bsd-tdep.c: Revert.
2336         * alpha-bsd-nat.c: Revert.
2337         * aix-thread.c: Revert.
2338         * agent.c: Revert.
2339         * addrmap.c: Revert.
2340         * ada-varobj.c: Revert.
2341         * ada-valprint.c: Revert.
2342         * ada-typeprint.c: Revert.
2343         * ada-tasks.c: Revert.
2344         * ada-lang.c: Revert.
2345         * aarch64-tdep.c: Revert.
2346         * aarch64-ravenscar-thread.c: Revert.
2347         * aarch64-newlib-tdep.c: Revert.
2348         * aarch64-linux-tdep.c: Revert.
2349         * aarch64-linux-nat.c: Revert.
2350         * aarch64-fbsd-tdep.c: Revert.
2351         * aarch64-fbsd-nat.c: Revert.
2352         * aarch32-linux-nat.c: Revert.
2353
2354 2019-04-05  Tom Tromey  <tom@tromey.com>
2355
2356         * ft32-tdep.c: Sort headers.
2357         * frv-tdep.c: Sort headers.
2358         * frv-linux-tdep.c: Sort headers.
2359         * frame.c: Sort headers.
2360         * frame-unwind.c: Sort headers.
2361         * frame-base.c: Sort headers.
2362         * fork-child.c: Sort headers.
2363         * findvar.c: Sort headers.
2364         * findcmd.c: Sort headers.
2365         * filesystem.c: Sort headers.
2366         * filename-seen-cache.h: Sort headers.
2367         * filename-seen-cache.c: Sort headers.
2368         * fbsd-tdep.c: Sort headers.
2369         * fbsd-nat.h: Sort headers.
2370         * fbsd-nat.c: Sort headers.
2371         * f-valprint.c: Sort headers.
2372         * f-typeprint.c: Sort headers.
2373         * f-lang.c: Sort headers.
2374         * extension.h: Sort headers.
2375         * extension.c: Sort headers.
2376         * extension-priv.h: Sort headers.
2377         * expprint.c: Sort headers.
2378         * exec.h: Sort headers.
2379         * exec.c: Sort headers.
2380         * exceptions.c: Sort headers.
2381         * event-top.c: Sort headers.
2382         * event-loop.c: Sort headers.
2383         * eval.c: Sort headers.
2384         * elfread.c: Sort headers.
2385         * dwarf2read.h: Sort headers.
2386         * dwarf2read.c: Sort headers.
2387         * dwarf2loc.c: Sort headers.
2388         * dwarf2expr.h: Sort headers.
2389         * dwarf2expr.c: Sort headers.
2390         * dwarf2-frame.c: Sort headers.
2391         * dwarf2-frame-tailcall.c: Sort headers.
2392         * dwarf-index-write.h: Sort headers.
2393         * dwarf-index-write.c: Sort headers.
2394         * dwarf-index-common.c: Sort headers.
2395         * dwarf-index-cache.h: Sort headers.
2396         * dwarf-index-cache.c: Sort headers.
2397         * dummy-frame.c: Sort headers.
2398         * dtrace-probe.c: Sort headers.
2399         * disasm.h: Sort headers.
2400         * disasm.c: Sort headers.
2401         * disasm-selftests.c: Sort headers.
2402         * dictionary.c: Sort headers.
2403         * dicos-tdep.c: Sort headers.
2404         * demangle.c: Sort headers.
2405         * dcache.h: Sort headers.
2406         * dcache.c: Sort headers.
2407         * darwin-nat.h: Sort headers.
2408         * darwin-nat.c: Sort headers.
2409         * darwin-nat-info.c: Sort headers.
2410         * d-valprint.c: Sort headers.
2411         * d-namespace.c: Sort headers.
2412         * d-lang.c: Sort headers.
2413         * ctf.c: Sort headers.
2414         * csky-tdep.c: Sort headers.
2415         * csky-linux-tdep.c: Sort headers.
2416         * cris-tdep.c: Sort headers.
2417         * cris-linux-tdep.c: Sort headers.
2418         * cp-valprint.c: Sort headers.
2419         * cp-support.c: Sort headers.
2420         * cp-namespace.c: Sort headers.
2421         * cp-abi.c: Sort headers.
2422         * corelow.c: Sort headers.
2423         * corefile.c: Sort headers.
2424         * continuations.c: Sort headers.
2425         * completer.h: Sort headers.
2426         * completer.c: Sort headers.
2427         * complaints.c: Sort headers.
2428         * coffread.c: Sort headers.
2429         * coff-pe-read.c: Sort headers.
2430         * cli-out.h: Sort headers.
2431         * cli-out.c: Sort headers.
2432         * charset.c: Sort headers.
2433         * c-varobj.c: Sort headers.
2434         * c-valprint.c: Sort headers.
2435         * c-typeprint.c: Sort headers.
2436         * c-lang.c: Sort headers.
2437         * buildsym.c: Sort headers.
2438         * buildsym-legacy.c: Sort headers.
2439         * build-id.h: Sort headers.
2440         * build-id.c: Sort headers.
2441         * btrace.c: Sort headers.
2442         * bsd-uthread.c: Sort headers.
2443         * breakpoint.h: Sort headers.
2444         * breakpoint.c: Sort headers.
2445         * break-catch-throw.c: Sort headers.
2446         * break-catch-syscall.c: Sort headers.
2447         * break-catch-sig.c: Sort headers.
2448         * blockframe.c: Sort headers.
2449         * block.c: Sort headers.
2450         * bfin-tdep.c: Sort headers.
2451         * bfin-linux-tdep.c: Sort headers.
2452         * bfd-target.c: Sort headers.
2453         * bcache.c: Sort headers.
2454         * ax-general.c: Sort headers.
2455         * ax-gdb.h: Sort headers.
2456         * ax-gdb.c: Sort headers.
2457         * avr-tdep.c: Sort headers.
2458         * auxv.c: Sort headers.
2459         * auto-load.c: Sort headers.
2460         * arm-wince-tdep.c: Sort headers.
2461         * arm-tdep.c: Sort headers.
2462         * arm-symbian-tdep.c: Sort headers.
2463         * arm-pikeos-tdep.c: Sort headers.
2464         * arm-obsd-tdep.c: Sort headers.
2465         * arm-nbsd-tdep.c: Sort headers.
2466         * arm-nbsd-nat.c: Sort headers.
2467         * arm-linux-tdep.c: Sort headers.
2468         * arm-linux-nat.c: Sort headers.
2469         * arm-fbsd-tdep.c: Sort headers.
2470         * arm-fbsd-nat.c: Sort headers.
2471         * arm-bsd-tdep.c: Sort headers.
2472         * arch-utils.c: Sort headers.
2473         * arc-tdep.c: Sort headers.
2474         * arc-newlib-tdep.c: Sort headers.
2475         * annotate.h: Sort headers.
2476         * annotate.c: Sort headers.
2477         * amd64-windows-tdep.c: Sort headers.
2478         * amd64-windows-nat.c: Sort headers.
2479         * amd64-tdep.c: Sort headers.
2480         * amd64-sol2-tdep.c: Sort headers.
2481         * amd64-obsd-tdep.c: Sort headers.
2482         * amd64-obsd-nat.c: Sort headers.
2483         * amd64-nbsd-tdep.c: Sort headers.
2484         * amd64-nbsd-nat.c: Sort headers.
2485         * amd64-nat.c: Sort headers.
2486         * amd64-linux-tdep.c: Sort headers.
2487         * amd64-linux-nat.c: Sort headers.
2488         * amd64-fbsd-tdep.c: Sort headers.
2489         * amd64-fbsd-nat.c: Sort headers.
2490         * amd64-dicos-tdep.c: Sort headers.
2491         * amd64-darwin-tdep.c: Sort headers.
2492         * amd64-bsd-nat.c: Sort headers.
2493         * alpha-tdep.c: Sort headers.
2494         * alpha-obsd-tdep.c: Sort headers.
2495         * alpha-nbsd-tdep.c: Sort headers.
2496         * alpha-mdebug-tdep.c: Sort headers.
2497         * alpha-linux-tdep.c: Sort headers.
2498         * alpha-linux-nat.c: Sort headers.
2499         * alpha-bsd-tdep.c: Sort headers.
2500         * alpha-bsd-nat.c: Sort headers.
2501         * aix-thread.c: Sort headers.
2502         * agent.c: Sort headers.
2503         * addrmap.c: Sort headers.
2504         * ada-varobj.c: Sort headers.
2505         * ada-valprint.c: Sort headers.
2506         * ada-typeprint.c: Sort headers.
2507         * ada-tasks.c: Sort headers.
2508         * ada-lang.c: Sort headers.
2509         * aarch64-tdep.c: Sort headers.
2510         * aarch64-ravenscar-thread.c: Sort headers.
2511         * aarch64-newlib-tdep.c: Sort headers.
2512         * aarch64-linux-tdep.c: Sort headers.
2513         * aarch64-linux-nat.c: Sort headers.
2514         * aarch64-fbsd-tdep.c: Sort headers.
2515         * aarch64-fbsd-nat.c: Sort headers.
2516         * aarch32-linux-nat.c: Sort headers.
2517
2518 2019-04-04  Tom Tromey  <tom@tromey.com>
2519
2520         * varobj.c (varobj_create): Update.
2521         * rust-exp.y (struct rust_parser) <update_innermost_block,
2522         lookup_symbol>: New methods.
2523         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2524         Rename.
2525         (rust_parser::rust_lookup_type)
2526         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2527         * printcmd.c (display_command, do_one_display): Update.
2528         * parser-defs.h (struct parser_state) <parser_state>: Add
2529         "tracker" parameter.
2530         (block_tracker): New member.
2531         (class innermost_block_tracker) <innermost_block_tracker>: Add
2532         "types" parameter.
2533         <reset>: Remove method.
2534         (innermost_block): Don't declare.
2535         (null_post_parser): Update.
2536         * parse.c (innermost_block): Remove global.
2537         (write_dollar_variable): Update.
2538         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2539         Remove "tracker_types" parameter.
2540         (parse_expression): Add "tracker" parameter.
2541         (parse_expression_for_completion): Update.
2542         (null_post_parser): Add "tracker" parameter.
2543         * p-exp.y: Update rules.
2544         * m2-exp.y: Update rules.
2545         * language.h (struct language_defn) <la_post_parser>: Add
2546         "tracker" parameter.
2547         * go-exp.y: Update rules.
2548         * f-exp.y: Update rules.
2549         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2550         parameter.
2551         * d-exp.y: Update rules.
2552         * c-exp.y: Update rules.
2553         * breakpoint.c (set_breakpoint_condition): Create an
2554         innermost_block_tracker.
2555         (watch_command_1): Likewise.
2556         * ada-lang.c (resolve): Add "tracker" parameter.
2557         (resolve_subexp): Likewise.
2558         * ada-exp.y (write_var_from_sym): Update.
2559
2560 2019-04-04  Tom Tromey  <tom@tromey.com>
2561
2562         * type-stack.h: New file.
2563         * type-stack.c: New file.
2564         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2565         type-stack.h.
2566         (insert_into_type_stack, insert_type, push_type, push_type_int)
2567         (insert_type_address_space, pop_type, pop_type_int)
2568         (pop_typelist, pop_type_stack, append_type_stack)
2569         (push_type_stack, get_type_stack, push_typelist)
2570         (follow_type_instance_flags, follow_types): Don't declare.
2571         * parse.c (type_stack): Remove global.
2572         (parse_exp_in_context): Update.
2573         (insert_into_type_stack, insert_type, push_type, push_type_int)
2574         (insert_type_address_space, pop_type, pop_type_int)
2575         (pop_typelist, pop_type_stack, append_type_stack)
2576         (push_type_stack, get_type_stack, push_typelist)
2577         (follow_type_instance_flags, follow_types): Remove (moved to
2578         type-stack.c).
2579         * f-exp.y (type_stack): New global.
2580         Update rules.
2581         (push_kind_type, f_parse): Update.
2582         * d-exp.y (type_stack): New global.
2583         Update rules.
2584         (d_parse): Update.
2585         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2586         Update rules.
2587         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2588         (HFILES_NO_SRCDIR): Add type-stack.h.
2589
2590 2019-04-04  Tom Tromey  <tom@tromey.com>
2591
2592         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2593         (rust_parser::convert_ast_to_expression, rust_parse)
2594         (rust_lex_test_completion, rust_lex_tests): Update.
2595         * parser-defs.h (struct expr_completion_state): New.
2596         (struct parser_state) <parser_state>: Add completion parameter.
2597         <mark_struct_expression, mark_completion_tag>: New methods.
2598         <parse_completion, m_completion_state>: New members.
2599         (prefixify_expression, null_post_parser): Update.
2600         (mark_struct_expression, mark_completion_tag): Don't declare.
2601         * parse.c (parse_completion, expout_last_struct)
2602         (expout_tag_completion_type, expout_completion_name): Remove
2603         globals.
2604         (parser_state::mark_struct_expression)
2605         (parser_state::mark_completion_tag): Now methods.
2606         (prefixify_expression): Add last_struct parameter.
2607         (prefixify_subexp): Likewise.
2608         (parse_exp_1): Update.
2609         (parse_exp_in_context): Add cstate parameter.  Update.
2610         (parse_expression_for_completion): Create an
2611         expr_completion_state.
2612         (null_post_parser): Add "completion" parameter.
2613         * p-exp.y: Update rules.
2614         (yylex): Update.
2615         * language.h (struct language_defn) <la_post_parser>: Add
2616         "completing" parameter.
2617         * go-exp.y: Update rules.
2618         (lex_one_token): Update.
2619         * expression.h (parse_completion): Don't declare.
2620         * d-exp.y: Update rules.
2621         (lex_one_token): Update rules.
2622         * c-exp.y: Update rules.
2623         (lex_one_token): Update.
2624         * ada-lang.c (resolve): Add "parse_completion" parameter.
2625         (resolve_subexp): Likewise.
2626         (ada_resolve_function): Likewise.
2627
2628 2019-04-04  Tom Tromey  <tom@tromey.com>
2629
2630         * parser-defs.h (struct parser_state) <start_arglist,
2631         end_arglist>: New methods.
2632         <arglist_len, m_funcall_chain>: New members.
2633         (arglist_len, start_arglist, end_arglist): Don't declare.
2634         * parse.c (arglist_len, funcall_chain): Remove global.
2635         (start_arglist, end_arglist): Remove functions.
2636         (parse_exp_in_context): Update.
2637         * p-exp.y: Update rules.
2638         * m2-exp.y: Update rules.
2639         * go-exp.y: Update rules.
2640         * f-exp.y: Update rules.
2641         * d-exp.y: Update rules.
2642         * c-exp.y: Update rules.
2643
2644 2019-04-04  Tom Tromey  <tom@tromey.com>
2645
2646         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2647         lex_operator, push_back>: New methods.
2648         Update all rules.
2649         (rust_parser::lex_hex, lex_escape): Rename and update.
2650         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2651         (rust_parser::lex_operator): Rename and update.
2652         (rust_parser::lex_number, rustyylex, rustyyerror)
2653         (rust_lex_test_init, rust_lex_test_sequence)
2654         (rust_lex_test_push_back, rust_lex_tests): Update.
2655         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2656         parameter.
2657         <lexptr, prev_lexptr>: New members.
2658         (lexptr, prev_lexptr): Don't declare.
2659         * parse.c (lexptr, prev_lexptr): Remove globals.
2660         (parse_exp_in_context): Update.
2661         * p-exp.y (yylex, yyerror): Update.
2662         * m2-exp.y (parse_number, yylex, yyerror): Update.
2663         * go-exp.y (lex_one_token, yyerror): Update.
2664         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2665         * d-exp.y (lex_one_token, yyerror): Update.
2666         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2667         (lex_one_token, yyerror): Update.
2668         * ada-lex.l (YY_INPUT): Update.
2669         (rewind_to_char): Update.
2670         * ada-exp.y (yyerror): Update.
2671
2672 2019-04-04  Tom Tromey  <tom@tromey.com>
2673
2674         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2675         * parser-defs.h (struct parser_state) <parser_state>: Add new
2676         parameter.
2677         <comma_terminates>: New member.
2678         (comma_terminates): Don't declare global.
2679         * parse.c (comma_terminates): Remove global.
2680         (parse_exp_in_context): Update.
2681         * p-exp.y (yylex): Update.
2682         * m2-exp.y (yylex): Update.
2683         * go-exp.y (lex_one_token): Update.
2684         * f-exp.y (yylex): Update.
2685         * d-exp.y (lex_one_token): Update.
2686         * c-exp.y (lex_one_token): Update.
2687         * ada-lex.l: Update.
2688
2689 2019-04-04  Tom Tromey  <tom@tromey.com>
2690
2691         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2692         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2693         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2694         * parser-defs.h (paren_depth): Don't declare.
2695         * parse.c (paren_depth): Remove global.
2696         (parse_exp_in_context): Update.
2697         * p-exp.y (paren_depth): New global.
2698         (pascal_parse): Initialize it.
2699         * m2-exp.y (paren_depth): New global.
2700         (m2_parse): Initialize it.
2701         * go-exp.y (paren_depth): New global.
2702         (go_parse): Initialize it.
2703         * f-exp.y (paren_depth): New global.
2704         (f_parse): Initialize it.
2705         * d-exp.y (paren_depth): New global.
2706         (d_parse): Initialize it.
2707         * c-exp.y (paren_depth): New global.
2708         (c_parse): Initialize it.
2709         * ada-lex.l (paren_depth): New global.
2710         (lexer_init): Initialize it.
2711
2712 2019-04-04  Tom Tromey  <tom@tromey.com>
2713
2714         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2715         (rust_parser::convert_ast_to_type)
2716         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2717         * parser-defs.h (struct parser_state) <parser_state>: Add
2718         parameters.  Initialize new members.
2719         <expression_context_block, expression_context_pc>: New members.
2720         * parse.c (expression_context_block, expression_context_pc):
2721         Remove globals.
2722         (parse_exp_in_context): Update.
2723         * p-exp.y: Update all rules.
2724         (yylex): Update.
2725         * m2-exp.y: Update all rules.
2726         (yylex): Update.
2727         * go-exp.y (yylex): Update.
2728         * f-exp.y (yylex): Update.
2729         * d-exp.y: Update all rules.
2730         (yylex): Update.
2731         * c-exp.y: Update all rules.
2732         (lex_one_token, classify_name, yylex, c_parse): Update.
2733         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2734
2735 2019-04-04  Tom Tromey  <tom@tromey.com>
2736
2737         * gdbarch.h, gdbarch.c: Rebuild.
2738         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2739         * stap-probe.h:
2740         (struct stap_parse_info): Replace "parser_state" with
2741         "expr_builder".
2742         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2743         (parser_state): New class.
2744         * parse.c (expr_builder): Rename.
2745         (expr_builder::release): Rename.
2746         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2747         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2748         (write_exp_elt_longcst, write_exp_elt_floatcst)
2749         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2750         (write_exp_string_vector, write_exp_bitstring)
2751         (write_exp_msymbol, mark_struct_expression)
2752         (write_dollar_variable)
2753         (insert_type_address_space, increase_expout_size): Replace
2754         "parser_state" with "expr_builder".
2755         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2756         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2757         "parser_state" with "expr_builder".
2758
2759 2019-04-04  Tom Tromey  <tom@tromey.com>
2760
2761         * rust-exp.y: Replace "parse_language" with method call.
2762         * p-exp.y:
2763         (yylex): Replace "parse_language" with method call.
2764         * m2-exp.y:
2765         (yylex): Replace "parse_language" with method call.
2766         * go-exp.y (classify_name): Replace "parse_language" with method
2767         call.
2768         * f-exp.y (yylex): Replace "parse_language" with method call.
2769         * d-exp.y (lex_one_token): Replace "parse_language" with method
2770         call.
2771         * c-exp.y:
2772         (lex_one_token, classify_name, yylex): Replace "parse_language"
2773         with method call.
2774         * ada-exp.y (find_primitive_type, type_char)
2775         (type_system_address): Replace "parse_language" with method call.
2776
2777 2019-04-04  Tom Tromey  <tom@tromey.com>
2778
2779         * rust-exp.y: Replace "parse_gdbarch" with method call.
2780         * parse.c (write_dollar_variable, insert_type_address_space):
2781         Replace "parse_gdbarch" with method call.
2782         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2783         call.
2784         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2785         call.
2786         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2787         "parse_gdbarch" with method call.
2788         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2789         with method call.
2790         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2791         "parse_gdbarch" with method call.
2792         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2793         "parse_gdbarch" with method call.
2794         * c-exp.y (parse_type, parse_number, classify_name): Replace
2795         "parse_gdbarch" with method call.
2796         * ada-lex.l: Replace "parse_gdbarch" with method call.
2797         * ada-exp.y (parse_type, find_primitive_type, type_char)
2798         (type_system_address): Replace "parse_gdbarch" with method call.
2799
2800 2019-04-04  Tom Tromey  <tom@tromey.com>
2801
2802         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2803         * stap-probe.c (stap_parse_argument): Update.
2804         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2805         initial_size parameter.
2806         * rust-exp.y (rust_lex_tests): Update.
2807         * parse.c (parser_state): Update.
2808         (parse_exp_in_context): Update.
2809         * parser-defs.h (struct parser_state) <parser_state>: Remove
2810         "initial_size" parameter.
2811
2812 2019-04-04  Tom Tromey  <tom@tromey.com>
2813
2814         * parser-defs.h (increase_expout_size): Don't declare.
2815         * parse.c (increase_expout_size): Now static.
2816
2817 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2818
2819         * gnu-nat.c (gnu_nat_target::wait): Fix
2820         target_waitstatus_to_string call.
2821
2822 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2823
2824         * eval.c (evaluate_subexp_standard): Handle internal functions
2825         during Fortran function call handling.
2826
2827 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2828
2829         * NEWS: Mention new internal functions.
2830         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2831         (read_base_type): Use dwarf2_init_complex_target_type.
2832         * value.c (creal_internal_fn): New function.
2833         (cimag_internal_fn): New function.
2834         (_initialize_values): Register new internal functions.
2835
2836 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2837
2838         * infrun.c (stop_all_threads): If debug_infrun, always
2839         trace the wait status after wait_one, using
2840         target_waitstatus_to_string and target_pid_to_str.
2841         (handle_inferior_event): Replace various trace of
2842         wait status kind by a single trace.
2843         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2844         wait status kind image by target_waitstatus_to_string.
2845         * target/waitstatus.c (target_waitstatus_to_string): Fix
2846         obsolete comment.
2847
2848 2019-04-01  Tom Tromey  <tromey@adacore.com>
2849
2850         PR symtab/23331:
2851         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2852
2853 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2854             Pedro Alves  <palves@redhat.com>
2855
2856         * top.c (quit_force): Call 'finalize_values'.
2857         * value.c (finalize_values): New function.
2858         * value.h (finalize_values): Declare.
2859
2860 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2861
2862         * NEWS: Announce $_gdb_major and $_gdb_minor.
2863
2864         * top.c (init_gdb_version_vars): New function.
2865         (gdb_init): Call init_gdb_version_vars.
2866
2867 2019-03-29  Tom Tromey  <tromey@adacore.com>
2868
2869         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2870         help text.  Remove dead code.
2871
2872 2019-03-29  Keith Seitz  <keiths@redhat.com>
2873
2874         From Siddhesh Poyarekar:
2875         * f-lang.h (f77_get_upperbound): Return LONGEST.
2876         (f77_get_lowerbound): Likewise.
2877         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2878         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2879         print them.
2880         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2881         plongest to format print it.
2882         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2883         (f77_get_upperbound): Likewise.
2884         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2885         LOWER_BOUND to LONGEST.
2886         (f77_create_arrayprint_offset_tbl): Likewise.
2887
2888 2019-03-29  Keith Seitz  <keiths@redhat.com>
2889
2890         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2891         %s/pulongest for TYPE_LENGTH instead of %d in format
2892         strings.
2893         * ada-typerint.c (ada_print_type): Likewise.
2894         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2895         * compile/compile-c-support.c (generate_register_struct): Likewise.
2896         * gdbtypes.c (recursive_dump_type): Likewise.
2897         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2898         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2899         instead of %d in format strings.
2900         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2901         to std::min to ULONGEST.
2902         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2903         instead of %d in format strings.
2904         * tracepoint.c (info_scope_command): Likewise.
2905         * typeprint.c (print_offset_data::update)
2906         (print_offset_data::finish): Likewise.
2907         * xtensa-tdep.c (xtensa_store_return_value)
2908         (xtensa_push_dummy_call): Likewise.
2909
2910 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2911
2912         * windows-nat.c (display_selector): Fixed format specifications
2913         for 64-bit Cygwin.
2914
2915 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2916
2917         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2918
2919 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2920
2921         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2922         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2923         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2924         (nios2_linux_init_abi): Install it.
2925
2926 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2927
2928         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2929
2930 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2931
2932         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2933
2934 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2935             Tom Tromey  <tromey@adacore.com>
2936
2937         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2938
2939 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2940
2941         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2942         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2943         method to compute the bounds of range types. Also print "[evaluated]"
2944         if the bounds' values come from a dynamic evaluation.
2945
2946 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2947
2948         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2949         whitespace when pretty printing is on.
2950
2951 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2952
2953         * ppc-linux-nat.c: Add include.
2954
2955 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2956
2957         * NEWS: Mention AArch64 Pointer Authentication.
2958
2959 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2960
2961         * arm-linux-nat.c: Add include.
2962
2963 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2964
2965         * source-cache.c (source_cache::get_source_lines): Re-read
2966         fullname after calling open_source_file.
2967
2968 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2969
2970         * NEWS: Mention TLS support for FreeBSD.
2971
2972 2019-03-25  Tom Tromey  <tromey@adacore.com>
2973
2974         * minsyms.c (BUNCH_SIZE): Update comment.
2975         (~minimal_symbol_reader): Remove old comment.
2976         (compact_minimal_symbols): Update comment.
2977         (minimal_symbol_reader::install): Remove old comment.  Update
2978         other comments.
2979
2980 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2981
2982         * s390-linux-nat.c: Add include.
2983
2984 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2985
2986         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2987         Call linux_get_hwcap.
2988         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2989         Likewise.
2990         (aarch64_linux_get_hwcap): Remove function.
2991         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2992         declaration.
2993         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2994         linux_get_hwcap.
2995         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2996         * linux-tdep.c (linux_get_hwcap): Add function.
2997         (linux_get_hwcap2): Likewise.
2998         * linux-tdep.h (linux_get_hwcap): Add declaration.
2999         (linux_get_hwcap2): Likewise.
3000         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3001         (ppc_linux_get_hwcap2): Likewise.
3002         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3003         linux_get_hwcap.
3004         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3005         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3006         (ppc_linux_nat_target::read_description): Likewise.
3007         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3008         * s390-linux-nat.c: Likewise.
3009         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3010
3011 2019-03-24  Tom Tromey  <tom@tromey.com>
3012
3013         * ada-lang.c (standard_lookup): Simplify initialization.
3014         (ada_lookup_symbol_nonlocal): Simplify return.
3015         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3016         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3017         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3018         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3019         initialization.
3020         * solib.c (solib_global_lookup): Simplify.
3021         * symtab.c (null_block_symbol): Remove.
3022         (symbol_cache_lookup): Simplify returns.
3023         (lookup_language_this): Simplify returns.
3024         (lookup_symbol_aux): Simplify return.
3025         (lookup_local_symbol): Simplify returns.
3026         (lookup_global_symbol_from_objfile): Simplify return.
3027         (lookup_symbol_in_objfile_symtabs)
3028         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3029         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3030         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3031         * cp-namespace.c (cp_lookup_bare_symbol)
3032         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3033         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3034         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3035         (cp_lookup_symbol_via_imports): Simplify initialization.
3036         (find_symbol_in_baseclass): Likewise.
3037         * symtab.h (null_block_symbol): Remove.
3038         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3039         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3040         (d_lookup_symbol_module): Likewise.
3041         (find_symbol_in_baseclass): Simplify initialization.
3042
3043 2019-03-24  Tom Tromey  <tom@tromey.com>
3044
3045         * expression.h: Don't include symtab.h.
3046         (struct block): Forward declare.
3047
3048 2019-03-24  Tom Tromey  <tom@tromey.com>
3049
3050         * c-exp.y (typebase): Remove casts.
3051         * gdbtypes.c (lookup_unsigned_typename, )
3052         (lookup_signed_typename): Remove cast.
3053         * eval.c (parse_to_comma_and_eval): Remove cast.
3054         * parse.c (write_dollar_variable): Remove cast.
3055         * block.h (struct block) <superblock>: Now const.
3056         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3057         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3058         (map_block): Make "block" const.
3059         * symfile.h (struct quick_symbol_functions)
3060         <map_matching_symbols>: Constify block argument to "callback".
3061         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3062         const.
3063         (find_pc_sect_compunit_symtab): Make "b" const.
3064         (find_symbol_at_address): Likewise.
3065         (search_symbols): Likewise.
3066         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3067         (dw2_debug_names_lookup_symbol): Likewise.
3068         (dw2_map_matching_symbols): Update.
3069         * p-valprint.c (pascal_val_print): Remove "block".
3070         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3071         (aux_add_nonlocal_symbols): Make "block" const.
3072         (resolve_subexp): Remove cast.
3073         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3074         const.
3075         (iterate_over_file_blocks): Likewise.
3076         * f-exp.y (%union) <bval>: Remove.
3077         * coffread.c (patch_opaque_types): Make "b" const.
3078         * spu-tdep.c (spu_catch_start): Make "block" const.
3079         * c-valprint.c (print_unpacked_pointer): Remove "block".
3080         * symmisc.c (dump_symtab_1): Make "b" const.
3081         (block_depth): Make "block" const.
3082         * d-exp.y (%union) <bval>: Remove.
3083         * cp-support.h (cp_lookup_rtti_type): Update.
3084         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3085         * psymtab.c (psym_lookup_symbol): Make "block" const.
3086         (maintenance_check_psymtabs): Make "b" const.
3087         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3088         (enumerate_locals, enumerate_args): Update.
3089         * python/py-symtab.c (stpy_global_block): Make "block" const.
3090         (stpy_static_block): Likewise.
3091         * inline-frame.c (block_starting_point_at): Make "new_block"
3092         const.
3093         * block.c (find_block_in_blockvector): Make return type const.
3094         (blockvector_for_pc_sect): Make "b" const.
3095         (find_block_in_blockvector): Make "b" const.
3096
3097 2019-03-23  Tom Tromey  <tom@tromey.com>
3098
3099         * varobj.c (varobj_create): Update.
3100         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3101         * printcmd.c (display_command, do_one_display): Don't reset
3102         innermost_block.
3103         * parser-defs.h (enum innermost_block_tracker_type): Move to
3104         expression.h.
3105         (innermost_block): Update comment.
3106         * parse.c (parse_exp_1): Add tracker_types parameter.
3107         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3108         tracker_types parameter.  Reset innermost_block.
3109         (parse_exp_in_context): Remove.
3110         (parse_expression_for_completion): Update.
3111         * objfiles.c (~objfile): Don't reset expression_context_block or
3112         innermost_block.
3113         * expression.h (enum innermost_block_tracker_type): Move from
3114         parser-defs.h.
3115         (parse_exp_1): Add tracker_types parameter.
3116         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3117         reset innermost_block.
3118
3119 2019-03-23  Tom Tromey  <tom@tromey.com>
3120
3121         * objfiles.h: Include bcache.h.
3122
3123 2019-03-23  Tom Tromey  <tom@tromey.com>
3124
3125         * linespec.c (get_current_search_block): Use
3126         scoped_restore_current_language.
3127         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3128
3129 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3130             Jiong Wang  <jiong.wang@arm.com>
3131
3132         * aarch64-linux-tdep.c
3133         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3134         section.
3135         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3136
3137 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3138             Jiong Wang  <jiong.wang@arm.com>
3139
3140         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3141         instructions.
3142         (aarch64_analyze_prologue_test): Add PACIASP test.
3143         (aarch64_prologue_prev_register): Unmask PC value.
3144
3145 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3146             Jiong Wang  <jiong.wang@arm.com>
3147
3148         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3149         (aarch64_dwarf2_prev_register): Unmask PC value.
3150         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3151         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3152         DW_CFA_AARCH64_negate_ra_state.
3153         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3154
3155 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3156             Jiong Wang  <jiong.wang@arm.com>
3157
3158         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3159         registers.
3160         (aarch64_pseudo_register_name): Likewise.
3161         (aarch64_pseudo_register_type): Likewise.
3162         (aarch64_pseudo_register_reggroup_p): Likewise.
3163         (aarch64_gdbarch_init): Add pauth registers.
3164         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3165         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3166         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3167         (struct gdbarch_tdep): Add regnum for ra_state.
3168
3169 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3170             Jiong Wang  <jiong.wang@arm.com>
3171
3172         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3173
3174 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3175             Jiong Wang  <jiong.wang@arm.com>
3176
3177         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3178         function.
3179         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3180         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3181         (aarch64_gdbarch_init): Add puth registers.
3182         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3183         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3184         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3185
3186 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3187             Jiong Wang  <jiong.wang@arm.com>
3188
3189         * aarch64-linux-nat.c
3190         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3191         * aarch64-linux-tdep.c
3192         (aarch64_linux_core_read_description): Likewise.
3193         (aarch64_linux_get_hwcap): New function.
3194         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3195         (aarch64_linux_get_hwcap): New declaration.
3196
3197 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3198             Jiong Wang  <jiong.wang@arm.com>
3199
3200         * aarch64-linux-nat.c
3201         (aarch64_linux_nat_target::read_description): Add pauth param.
3202         * aarch64-linux-tdep.c
3203         (aarch64_linux_core_read_description): Likewise.
3204         * aarch64-tdep.c (struct target_desc): Add in pauth.
3205         (aarch64_read_description): Add pauth param.
3206         (aarch64_gdbarch_init): Likewise.
3207         * aarch64-tdep.h (aarch64_read_description): Likewise.
3208         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3209         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3210         * features/Makefile: Add new files.
3211         * features/aarch64-pauth.c: New file.
3212         * features/aarch64-pauth.xml: New file.
3213
3214 2019-03-20  Tom Tromey  <tromey@adacore.com>
3215
3216         * infrun.c (handle_inferior_event): Rename from
3217         handle_inferior_event_1.  Create a scoped_value_mark.
3218         (handle_inferior_event): Remove.
3219
3220 2019-03-19  Tom Tromey  <tromey@adacore.com>
3221
3222         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3223         * infrun.h (print_stop_event): Add "displays" parameter.
3224         * infrun.c (print_stop_event): Add "displays" parameter.
3225
3226 2019-03-19  Pedro Alves  <palves@redhat.com>
3227
3228         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3229         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3230         to -1.  Fix TABs vs spaces.
3231         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3232         * tui/tui-out.h (tui_ui_out) Add intro comments.
3233         <m_line, m_start_of_line>: In-class initialize, and add describing
3234         comment.
3235
3236 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3237
3238         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3239         variable names.
3240         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3241
3242 2019-03-18  Pedro Alves  <palves@redhat.com>
3243             Eli Zaretskii <eliz@gnu.org>
3244
3245         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3246         m_line and m_start_of_line.
3247
3248 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3249
3250         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3251         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3252         it returns a newline.  This fixes a regression in TU mode, whereby
3253         the next line is output on the same screen line as the user input.
3254
3255 2019-03-18  Tom Tromey  <tromey@adacore.com>
3256
3257         * minsyms.c (minimal_symbol_reader::install): Remove call to
3258         obstack_blank.
3259
3260 2019-03-18  Pedro Alves  <palves@redhat.com>
3261
3262         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3263         New globals.
3264         (apply_style): New, factored out from ...
3265         (apply_ansi_escape): ... this.  Handle reverse video mode.
3266         (tui_set_reverse_mode): New function.
3267         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3268         * tui/tui-winsource.c (tui_show_source_line): Use
3269         tui_set_reverse_mode instead of setting A_STANDOUT.
3270         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3271         New setter methods.
3272
3273 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3274
3275         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3276         Handle tabs.
3277
3278 2019-03-18  Tom Tromey  <tromey@adacore.com>
3279
3280         * ada-lang.c (empty_array): Add "high" parameter.
3281         (ada_evaluate_subexp): Update.
3282
3283 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3284
3285         * unittests/string_view-selftests.c: Define
3286         _initialize_string_view_selftests unconditionally.
3287
3288 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3289
3290         PR gdb/24350
3291         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3292
3293 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3294
3295         PR gdb/24351
3296         * windows-nat.c (display_selector): Fix format specifiers.
3297
3298 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3299
3300         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3301         tui_refill_source_window instead of tui_refresh_win, to update the
3302         current execution line.  This fixes redisplay of the current line
3303         when stepping through the code with "next" or "step".
3304
3305 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3306
3307         * source-cache.c (source_cache::get_source_lines): Call
3308         find_source_lines to initialize s->nlines.  This fixes vertical
3309         scrolling of TUI source window when the DOWN arrow is pressed.
3310
3311 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3312
3313         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3314         linux-thread-db.c (_initialize_thread_db): Likewise.
3315
3316 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3317
3318         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3319         wclrtoeol in tui_show_source_line".  This reverts changes made in
3320         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3321
3322 2019-03-15  Tom Tromey  <tom@tromey.com>
3323
3324         * symtab.h (struct minimal_symbol): Derive from
3325         general_symbol_info.
3326         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3327         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3328         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3329         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3330         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3331         (MSYMBOL_SEARCH_NAME): Update.
3332         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3333         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3334         * minsyms.c (minimal_symbol_reader::record_full): Update.
3335
3336 2019-03-15  Tom Tromey  <tom@tromey.com>
3337
3338         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3339
3340 2019-03-15  Tom Tromey  <tom@tromey.com>
3341
3342         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3343         unique_xmalloc_ptr.
3344         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3345         Update.
3346         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3347         (build_minimal_symbol_hash_tables)
3348         (minimal_symbol_reader::install): Update.
3349
3350 2019-03-15  Tom Tromey  <tom@tromey.com>
3351
3352         * symtab.c (create_demangled_names_hash): Update.
3353         (symbol_set_names): Update.
3354         * objfiles.h (struct objfile_per_bfd_storage)
3355         <demangled_names_hash>: Now an htab_up.
3356         * objfiles.c (objfile_per_bfd_storage): Simplify.
3357
3358 2019-03-15  Tom Tromey  <tom@tromey.com>
3359
3360         * objfiles.h (struct objfile_per_bfd_storage): Declare
3361         destructor.
3362         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3363         New.
3364         (get_objfile_bfd_data): Use new.  Don't initialize
3365         language_of_main.
3366         (free_objfile_per_bfd_storage): Remove.
3367         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3368
3369 2019-03-15  Tom Tromey  <tom@tromey.com>
3370
3371         * symfile.c (reread_symbols): Update.
3372         * objfiles.c (objfile::objfile): Update.
3373         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3374         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3375         comment.
3376         (minimal_symbol_reader::install): Update.
3377         (terminate_minimal_symbol_table): Remove.
3378         * jit.c (jit_object_close_impl): Update.
3379
3380 2019-03-15  Tom Tromey  <tom@tromey.com>
3381
3382         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3383         initializations.
3384
3385 2019-03-15  Tom Tromey  <tom@tromey.com>
3386
3387         * objfiles.h (struct objfile_per_bfd_storage)
3388         <demangled_hash_languages>: Now a bitset.
3389         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3390         (lookup_minimal_symbol): Update.
3391
3392 2019-03-15  Tom Tromey  <tom@tromey.com>
3393
3394         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3395         Don't return the symbol.
3396         * coffread.c (record_minimal_symbol): Use record_full.
3397
3398 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3399
3400         The MS-Windows port of ncurses fails to switch to a color pair if
3401         one or both of the colors are the implicit default colors.  This
3402         change records the default colors when TUI is initialized, and
3403         then specifies them explicitly when a color pair uses the default
3404         colors.  This allows color styling in TUI mode on MS-Windows.
3405
3406         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3407         ncurses_norm_attr.
3408         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3409         colors in ncurses_norm_attr.
3410         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3411         "none", replace it with the default color recorded in
3412         ncurses_norm_attr.
3413
3414 2019-03-14  Tom Tromey  <tromey@adacore.com>
3415
3416         * source-cache.h (class source_cache) <get_source_lines>: Return
3417         std::string.
3418         * source-cache.c (source_cache::extract_lines): Handle case where
3419         first_pos==npos.  Return std::string.
3420         (source_cache::get_source_lines): Update.
3421
3422 2019-03-14  Tom Tromey  <tromey@adacore.com>
3423
3424         * NEWS: Add item for "style sources" commands.
3425         * source-cache.c (source_cache::get_source_lines): Check
3426         source_styling.
3427         * cli/cli-style.c (source_styling): New global.
3428         (_initialize_cli_style): Add "style sources" commands.
3429         (show_style_sources): New function.
3430         * cli/cli-style.h (source_styling): Declare.
3431
3432 2019-03-14  Pedro Alves  <palves@redhat.com>
3433             Tom Tromey  <tromey@adacore.com>
3434
3435         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3436         * tui/tui-winsource.c (tui_refill_source_window): New function,
3437         from...
3438         (tui_horizontal_source_scroll): ... here.  Move some logic.
3439         * cli/cli-style.c (set_style_enabled): Notify new observable.
3440         * tui/tui-hooks.c (tui_redisplay_source): New function.
3441         (tui_attach_detach_observers): Attach or detach
3442         tui_redisplay_source.
3443         * observable.h (source_styling_changed): New observable.
3444         * observable.c: Define source_styling_changed observable.
3445
3446 2019-03-13  Tom Tromey  <tromey@adacore.com>
3447
3448         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3449         (i386_gnu_nat_target::store_registers): Update.
3450         * target-debug.h (target_debug_print_std_string): New macro.
3451         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3452         * windows-tdep.c (display_one_tib): Update.
3453         * tui/tui-stack.c (tui_make_status_line): Update.
3454         * top.c (print_inferior_quit_action): Update.
3455         * thread.c (thr_try_catch_cmd): Update.
3456         (add_thread_with_info): Update.
3457         (thread_target_id_str): Update.
3458         (thr_try_catch_cmd): Update.
3459         (thread_command): Update.
3460         (thread_find_command): Update.
3461         * record-btrace.c (record_btrace_target::info_record)
3462         (record_btrace_resume_thread, record_btrace_target::resume)
3463         (record_btrace_cancel_resume, record_btrace_step_thread)
3464         (record_btrace_target::wait, record_btrace_target::wait)
3465         (record_btrace_target::wait, record_btrace_target::stop): Update.
3466         * progspace.c (print_program_space): Update.
3467         * process-stratum-target.c
3468         (process_stratum_target::thread_address_space): Update.
3469         * linux-fork.c (linux_fork_mourn_inferior)
3470         (detach_checkpoint_command, info_checkpoints_command)
3471         (linux_fork_context): Update.
3472         (linux_fork_detach): Update.
3473         (class scoped_switch_fork_info): Update.
3474         (delete_checkpoint_command): Update.
3475         * infrun.c (follow_fork_inferior): Update.
3476         (follow_fork_inferior): Update.
3477         (proceed_after_vfork_done): Update.
3478         (handle_vfork_child_exec_or_exit): Update.
3479         (follow_exec): Update.
3480         (displaced_step_prepare_throw): Update.
3481         (displaced_step_restore): Update.
3482         (start_step_over): Update.
3483         (resume_1): Update.
3484         (clear_proceed_status_thread): Update.
3485         (proceed): Update.
3486         (print_target_wait_results): Update.
3487         (do_target_wait): Update.
3488         (context_switch): Update.
3489         (stop_all_threads): Update.
3490         (restart_threads): Update.
3491         (finish_step_over): Update.
3492         (handle_signal_stop): Update.
3493         (switch_back_to_stepped_thread): Update.
3494         (keep_going_pass_signal): Update.
3495         (print_exited_reason): Update.
3496         (normal_stop): Update.
3497         * inferior.c (inferior_pid_to_str): Change return type.
3498         (print_selected_inferior): Update.
3499         (add_inferior): Update.
3500         (detach_inferior): Update.
3501         * dummy-frame.c (fprint_dummy_frames): Update.
3502         * dcache.c (dcache_info_1): Update.
3503         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3504         (btrace_fetch, btrace_clear): Update.
3505         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3506         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3507         type.
3508         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3509         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3510         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3511         * gdbarch.c, gdbarch.h: Rebuild.
3512         * gdbarch.sh (core_pid_to_str): Change return type.
3513         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3514         return type.
3515         (windows_nat_target::pid_to_str): Change return type.
3516         (windows_delete_thread): Update.
3517         (windows_nat_target::attach): Update.
3518         (windows_nat_target::files_info): Update.
3519         * target-delegates.c: Rebuild.
3520         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3521         return type.
3522         (sol_thread_target::pid_to_str): Change return type.
3523         * remote.c (class remote_target) <pid_to_str>: Change return
3524         type.
3525         (remote_target::pid_to_str): Change return type.
3526         (extended_remote_target::attach, remote_target::remote_stop_ns)
3527         (remote_target::remote_notif_remove_queued_reply)
3528         (remote_target::push_stop_reply, remote_target::disable_btrace):
3529         Update.
3530         (extended_remote_target::attach): Update.
3531         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3532         type.
3533         (gdbsim_target::pid_to_str): Change return type.
3534         * ravenscar-thread.c (struct ravenscar_thread_target)
3535         <pid_to_str>: Change return type.
3536         (ravenscar_thread_target::pid_to_str): Change return type.
3537         * procfs.c (class procfs_target) <pid_to_str>: Change return
3538         type.
3539         (procfs_target::pid_to_str): Change return type.
3540         (procfs_target::attach): Update.
3541         (procfs_target::detach): Update.
3542         (procfs_target::fetch_registers): Update.
3543         (procfs_target::store_registers): Update.
3544         (procfs_target::wait): Update.
3545         (procfs_target::files_info): Update.
3546         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3547         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3548         return type.
3549         (nto_procfs_target::pid_to_str): Change return type.
3550         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3551         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3552         return type.
3553         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3554         (exit_lwp): Update.
3555         (attach_proc_task_lwp_callback, get_detach_signal)
3556         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3557         (linux_nat_target::resume, wait_lwp, stop_callback)
3558         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3559         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3560         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3561         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3562         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3563         type.
3564         (inf_ptrace_target::attach): Update.
3565         (inf_ptrace_target::files_info): Update.
3566         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3567         type.
3568         (go32_nat_target::pid_to_str): Change return type.
3569         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3570         (gnu_nat_target::wait): Update.
3571         (gnu_nat_target::wait): Update.
3572         (gnu_nat_target::resume): Update.
3573         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3574         (fbsd_nat_target::wait): Update.
3575         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3576         type.
3577         (darwin_nat_target::attach): Update.
3578         * corelow.c (class core_target) <pid_to_str>: Change return type.
3579         (core_target::pid_to_str): Change return type.
3580         * target.c (normal_pid_to_str): Change return type.
3581         (default_pid_to_str): Likewise.
3582         (target_pid_to_str): Change return type.
3583         (target_translate_tls_address): Update.
3584         (target_announce_detach): Update.
3585         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3586         return type.
3587         (bsd_uthread_target::pid_to_str): Change return type.
3588         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3589         type.
3590         (bsd_kvm_target::pid_to_str): Change return type.
3591         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3592         return type.
3593         (aix_thread_target::pid_to_str): Change return type.
3594         * target.h (struct target_ops) <pid_to_str>: Change return type.
3595         (target_pid_to_str, normal_pid_to_str): Likewise.
3596         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3597         type.
3598         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3599         type.
3600         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3601         return type.
3602         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3603         type.
3604         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3605         type.
3606         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3607         return type.
3608
3609 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3610
3611         * NEWS: Mention that the new default MI version is 3.  Mention
3612         changes to the output of commands and events that deal with
3613         multi-location breakpoints.
3614         * breakpoint.c: Include "mi/mi-out.h".
3615         (print_one_breakpoint): Change output syntax if using MI version
3616         >= 3.
3617         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3618         New.
3619         (mi_multi_location_breakpoint_output_fixed): New.
3620         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3621         (mi_cmd_fix_multi_location_breakpoint_output): New.
3622         (mi_multi_location_breakpoint_output_fixed): New.
3623         * mi/mi-cmds.c (mi_cmds): Register command
3624         -fix-multi-location-breakpoint-output.
3625         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3626         interpreter "mi".
3627
3628 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3629
3630         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3631         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3632         instantiate mi_ui_out based on interpreter name.
3633         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3634         * mi/mi-main.c (mi_load_progress): Likewise.
3635
3636 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3637
3638         * NEWS: Combine separate "New targets" sections for 8.3.
3639
3640 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3641
3642         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3643         (ppcfbsd_init_abi): Install gdbarch
3644         "fetch_tls_load_module_address" and "get_thread_local_address"
3645         methods.
3646
3647 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3648
3649         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3650         (riscv_fbsd_init_abi): Install gdbarch
3651         "fetch_tls_load_module_address" and "get_thread_local_address"
3652         methods.
3653
3654 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3655
3656         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3657         (i386fbsd_init_abi): Install gdbarch
3658         "fetch_tls_load_module_address" and "get_thread_local_address"
3659         methods.
3660
3661 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3662
3663         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3664         (amd64fbsd_init_abi): Install gdbarch
3665         "fetch_tls_load_module_address" and "get_thread_local_address"
3666         methods.
3667
3668 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3669
3670         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3671         (struct fbsd_pspace_data): New type.
3672         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3673         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3674         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3675         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3676         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3677
3678 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3679
3680         * gdbtypes.c (lookup_struct_elt): New function.
3681         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3682         * gdbtypes.h (struct struct_elt): New type.
3683         (lookup_struct_elt): New prototype.
3684
3685 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3686
3687         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3688         remove disabled code block.
3689
3690 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3691
3692         * gdbarch.sh (get_thread_local_address): New method.
3693         * gdbarch.h, gdbarch.c: Regenerate.
3694         * target.c (target_translate_tls_address): Use
3695         gdbarch_get_thread_local_address if present instead of
3696         target::get_thread_local_address.
3697
3698 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3699
3700         * target.h (target::get_thread_local_address): Update comment.
3701
3702 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3703
3704         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3705         objfile->separate_debug_objfile_backlink if not NULL.
3706
3707 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3708
3709         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3710         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3711         (amd64bsd_store_inferior_registers): Likewise.
3712         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3713         Enable segment base registers.
3714         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3715         PT_GETFSBASE and PT_GETGSBASE.
3716         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3717         PT_SETGSBASE.
3718         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3719         segment base registers.
3720         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3721
3722 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3723
3724         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3725         Update calls to i386_target_description to add 'segments'
3726         parameter.
3727         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3728         add segment base registers.
3729         * arch/i386.c (i386_create_target_description): Add 'segments'
3730         parameter to enable segment base registers.
3731         * arch/i386.h (i386_create_target_description): Likewise.
3732         * features/i386/32bit-segments.xml: New file.
3733         * features/i386/32bit-segments.c: Generate.
3734         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3735         call to i386_target_description to add 'segments' parameter.
3736         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3737         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3738         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3739         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3740         if feature is present.
3741         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3742         Add 'segments' parameter to call to i386_target_description.
3743         (i386_target_description): Add 'segments' parameter to enable
3744         segment base registers.
3745         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3746         to call to i386_target_description.
3747         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3748         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3749         Define I386_NUM_REGS.
3750         (i386_target_description): Add 'segments' parameter to enable
3751         segment base registers.
3752
3753 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3754
3755         PR/24325
3756         * source-cache.c: #undef open and close, to avoid unresolved
3757         externals during linking.
3758
3759 2019-03-12  Tom Tromey  <tromey@adacore.com>
3760
3761         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3762         const.  Add initializers.
3763         (_initialize_remote): Don't initialize ptid globals.
3764
3765 2019-03-12  Pedro Alves  <palves@redhat.com>
3766
3767         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3768
3769 2019-03-12  Pedro Alves  <palves@redhat.com>
3770
3771         * cp-name-parser.y (main): Remove unused 'len' variable.
3772
3773 2019-03-12  Tom Tromey  <tromey@adacore.com>
3774
3775         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3776         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3777
3778 2019-03-12  Tom Tromey  <tromey@adacore.com>
3779
3780         * linux-nat.c (iterate_over_lwps): Update.
3781         (stop_callback): Remove parameter.
3782         (stop_wait_callback, detach_callback, resume_set_callback)
3783         (select_singlestep_lwp_callback, set_ignore_sigint)
3784         (status_callback, resumed_callback, resume_clear_callback)
3785         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3786         data parameter.
3787         (linux_nat_target::detach, linux_nat_target::resume)
3788         (linux_stop_and_wait_all_lwps, select_event_lwp)
3789         (linux_nat_filter_event, linux_nat_wait_1)
3790         (linux_nat_target::kill, linux_nat_target::stop)
3791         (linux_nat_target::stop): Update.
3792         (linux_nat_resume_callback): Change type.
3793         (resume_stopped_resumed_lwps, count_events_callback)
3794         (select_event_lwp_callback): Likewise.
3795         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3796         * arm-linux-nat.c (struct update_registers_data): Remove.
3797         (update_registers_callback): Change type.
3798         (arm_linux_insert_hw_breakpoint1): Update.
3799         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3800         parameter.
3801         (x86_linux_dr_set_addr): Update.
3802         (x86_linux_dr_set_control): Update.
3803         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3804         (iterate_over_lwps): Use gdb::function_view.
3805         * nat/aarch64-linux-hw-point.c (struct
3806         aarch64_dr_update_callback_param): Remove.
3807         (debug_reg_change_callback): Change type.
3808         (aarch64_notify_debug_reg_change): Update.
3809         * s390-linux-nat.c (s390_refresh_per_info): Update.
3810
3811 2019-03-11  Tom Tromey  <tromey@adacore.com>
3812
3813         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3814         redundant assignment to "this_cu".
3815
3816 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3817
3818         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3819
3820 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3821
3822         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3823         from...
3824         (rank_one_type): ... this.
3825
3826 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3827
3828         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3829         from...
3830         (rank_one_type): ... this.
3831
3832 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3833
3834         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3835         from...
3836         (rank_one_type): ... this.
3837
3838 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3839
3840         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3841         from...
3842         (rank_one_type): ... this.
3843
3844 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3845
3846         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3847         from...
3848         (rank_one_type): ... this.
3849
3850 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3851
3852         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3853         from...
3854         (rank_one_type): ... this.
3855
3856 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3857
3858         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3859         from...
3860         (rank_one_type): ... this.
3861
3862 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3863
3864         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3865         from...
3866         (rank_one_type): ... this.
3867
3868 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3869
3870         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3871         from...
3872         (rank_one_type): ... this.
3873
3874 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3875
3876         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3877         from...
3878         (rank_one_type): ... this.
3879
3880 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3881
3882         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3883         from...
3884         (rank_one_type): ... this.
3885
3886 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3887
3888         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3889         from...
3890         (rank_one_type): ... this.
3891
3892 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3893
3894         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3895         inferior-events' shows the example events.
3896
3897 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3898
3899         Support styling on native MS-Windows console
3900
3901         PR/24315
3902         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3903         on MS-Windows if $TERM is not defined.
3904
3905         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3906
3907         * posix-hdep.c (gdb_console_fputs):
3908         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3909         functions.
3910         * ui-file.h (gdb_console_fputs): Add prototype.
3911
3912         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3913         back to fputs only if the former returns zero.
3914
3915 2019-03-07  Tom Tromey  <tom@tromey.com>
3916
3917         * symmisc.c (print_symbol_bcache_statistics): Update.
3918         (print_objfile_statistics): Update.
3919         * symfile.c (allocate_symtab): Update.
3920         * stabsread.c: Don't include bcache.h.
3921         * psymtab.h (struct psymbol_bcache): Don't declare.
3922         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3923         (psymbol_bcache_init, psymbol_bcache_free)
3924         (psymbol_bcache_get_bcache): Don't declare.
3925         * psymtab.c (struct psymbol_bcache): Remove.
3926         (psymtab_storage::psymtab_storage): Update.
3927         (psymtab_storage::~psymtab_storage): Update.
3928         (psymbol_bcache_init, psymbol_bcache_free)
3929         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3930         (add_psymbol_to_bcache): Update.
3931         (allocate_psymtab): Update.
3932         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3933         macro_cache>: No longer pointers.
3934         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3935         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3936         * macrotab.c (macro_bcache): Update.
3937         * macroexp.c: Don't include bcache.h.
3938         * gdbtypes.c (check_types_worklist): Update.
3939         (types_deeply_equal): Remove TRY/CATCH.  Update.
3940         * elfread.c (elf_symtab_read): Update.
3941         * dwarf2read.c: Don't include bcache.h.
3942         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3943         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3944         (print_bcache_statistics, bcache_memory_used): Don't declare.
3945         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3946         methods.  Rename all data members.
3947         * bcache.c (struct bcache): Move to bcache.h.
3948         (bcache::expand_hash_table): Rename from expand_hash_table.
3949         (bcache): Remove.
3950         (bcache::insert): Rename from bcache_full.
3951         (bcache::compare): Rename from bcache_compare.
3952         (bcache_xmalloc): Remove.
3953         (bcache::~bcache): Rename from bcache_xfree.
3954         (bcache::print_statistics): Rename from print_bcache_statistics.
3955         (bcache::memory_used): Rename from bcache_memory_used.
3956
3957 2019-03-07  Pedro Alves  <palves@redhat.com>
3958
3959         * infrun.c (normal_stop): Also check for
3960         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3961
3962 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3963
3964         * f-lang.c (value_from_host_double): Moved to...
3965         * value.c (value_from_host_double): ...here.
3966         * value.h (value_from_host_double): Declare.
3967         * guile/scm-math.c (vlscm_convert_typed_number): Use
3968         value_from_host_double.
3969         (vlscm_convert_number): Likewise.
3970         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3971         * python/py-value.c (convert_value_from_python): Likewise.
3972
3973 2019-03-06  Tom Tromey  <tom@tromey.com>
3974
3975         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3976
3977 2019-03-06  Tom Tromey  <tom@tromey.com>
3978
3979         * utils.h (free_current_contents): Don't declare.
3980         * utils.c (free_current_contents): Remove.
3981
3982 2019-03-06  Tom Tromey  <tom@tromey.com>
3983
3984         * top.c (quit_force): Update.
3985         * main.c (captured_command_loop): Update.
3986         * common/new-op.c (operator new): Update.
3987         * common/common-exceptions.c (struct catcher)
3988         <save_cleanup_chain>: Remove member.
3989         (exceptions_state_mc_init): Update.
3990         (exception_try_scope_entry): Return nullptr.
3991         (exception_try_scope_exit, exception_rethrow)
3992         (throw_exception_sjlj, throw_exception_cxx): Update.
3993         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3994         (all_cleanups, do_cleanups, discard_cleanups)
3995         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3996         (restore_cleanups, restore_final_cleanups): Don't declare.
3997         (do_final_cleanups): Remove parameter.
3998         * common/cleanups.c (cleanup_chain, make_cleanup)
3999         (make_cleanup_dtor, all_cleanups, do_cleanups)
4000         (discard_my_cleanups, discard_cleanups)
4001         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4002         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4003         (null_cleanup): Remove.
4004         (do_final_cleanups): Remove parameter.
4005
4006 2019-03-06  Tom Tromey  <tom@tromey.com>
4007
4008         * remote.c (remote_target::remote_parse_stop_reply): Use
4009         unique_xmalloc_ptr.
4010
4011 2019-03-06  Tom Tromey  <tom@tromey.com>
4012
4013         * stabsread.c (struct stabs_field_info): Rename from field_info.
4014         <list, fnlist>: Add initializers.
4015         <obstack>: New member.
4016         (read_member_functions, read_struct_fields, read_baseclasses):
4017         Allocate on obstack.  Don't use cleanups.
4018         (read_one_struct_field, read_member_functions, read_struct_fields)
4019         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4020         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4021         (read_struct_type): Update.
4022
4023 2019-03-06  Tom Tromey  <tom@tromey.com>
4024
4025         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4026         * common/filestuff.h (make_cleanup_close): Don't declare.
4027         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4028         Remove.
4029
4030 2019-03-06  Tom Tromey  <tom@tromey.com>
4031
4032         * solib-aix.c: Use make_scope_exit.
4033
4034 2019-03-06  Tom Tromey  <tom@tromey.com>
4035
4036         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4037         Use make_scope_exit.
4038
4039 2019-03-06  Tom Tromey  <tom@tromey.com>
4040
4041         * solib-svr4.c (disable_probes_interface): Remove parameter.
4042         (svr4_handle_solib_event): Use make_scope_exit.
4043
4044 2019-03-06  Tom Tromey  <tom@tromey.com>
4045
4046         * remote.c (struct stop_reply_deleter): Remove.
4047         (stop_reply_up): Update.
4048         (struct stop_reply): Derive from notif_event.  Don't typedef.
4049         <regcache>: Now a std::vector.
4050         (stop_reply_xfree): Remove.
4051         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4052         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4053         (remote_target::discard_pending_stop_replies): Use delete.
4054         (remote_target::remote_parse_stop_reply): Update.
4055         (remote_target::process_stop_reply): Update.
4056         * remote-notif.h (struct notif_event): Add virtual destructor.
4057         Remove "dtr" member.
4058         (struct notif_client) <alloc_event>: Return a unique_ptr.
4059         (notif_event_xfree): Don't declare.
4060         (notif_event_up): New typedef.
4061         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4062         (notif_event_xfree, do_notif_event_xfree): Remove.
4063         (remote_notif_state_xfree): Update.
4064
4065 2019-03-06  Tom Tromey  <tom@tromey.com>
4066
4067         * infrun.c (displaced_step_clear_cleanup): Now a
4068         forward_scope_exit type.
4069         (displaced_step_prepare_throw): Update.
4070         (displaced_step_fixup): Update.
4071
4072 2019-03-06  Tom Tromey  <tom@tromey.com>
4073
4074         * inferior.h (class inferior): Update comment.
4075         * gdbthread.h (class thread_info): Update comment.
4076
4077 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4078             Tom Tromey  <tom@tromey.com>
4079
4080         * stabsread.h (struct stab_section_list): Remove.
4081         (coffstab_build_psymtabs): Update.
4082         * dbxread.c (symbuf_sections): Now a std::vector.
4083         (sect_idx): New global.
4084         (fill_symbuf): Update.
4085         (coffstab_build_psymtabs): Change type of stabsects parameter.
4086         Update.
4087         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4088         std::vector.
4089         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4090         (coff_locate_sections): Update.
4091         (coff_symfile_read): Remove cleanups.  Update.
4092         (init_stringtab): Add storage parameter.
4093         (free_stringtab, free_stringtab_cleanup): Remove.
4094         (init_lineno): Add storage parameter.
4095         (free_linetab, free_linetab_cleanup): Remove.
4096
4097 2019-03-06  Pedro Alves  <palves@redhat.com>
4098
4099         * linux-fork.c (fork_info::clobber_regs): Delete.
4100         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4101         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4102         comment.  Adjust.
4103         (scoped_switch_fork_info::scoped_switch_fork_info)
4104         (checkpoint_command, linux_fork_context): Adjust
4105         fork_save_infrun_state calls.
4106
4107 2019-03-06  Pedro Alves  <palves@redhat.com>
4108
4109         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4110         (inf_has_multiple_threads): Return 'bool' and rewrite using
4111         inferior_info::threads().
4112
4113 2019-03-06  Pedro Alves  <palves@redhat.com>
4114
4115         * linux-fork.c: Include <list>.
4116         (fork_list): Now a std::list instance.
4117         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4118         (forks_exist_p, find_last_fork): Adjust.
4119         (new_fork): Delete.
4120         (one_fork_p): New.
4121         (add_fork): Adjust.
4122         (free_fork): Delete, folded into fork_info::~fork_info().
4123         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4124         Adjust.
4125         (init_fork_list): Delete.
4126         (linux_fork_killall, linux_fork_mourn_inferior)
4127         (linux_fork_detach, info_checkpoints_command): Adjust.
4128         (_initialize_linux_fork): No longer call init_fork_list.
4129
4130 2019-03-06  Pedro Alves  <palves@redhat.com>
4131
4132         * linux-fork.c (new_fork): New, split out of ...
4133         (add_fork): ... this.  Return void.  Move "first fork" special
4134         case from here, to ...
4135         (checkpoint_command): ... here.
4136         * linux-linux.h (add_fork): Return void.
4137
4138 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4139
4140         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4141
4142 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4143             Chris January  <chris.january@arm.com>
4144             David Lecomber  <david.lecomber@arm.com>
4145
4146         * f-exp.y: New token, UNOP_INTRINSIC.
4147         (exp): New pattern using UNOP_INTRINSIC token.
4148         (f77_keywords): Add 'abs' keyword.
4149         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4150         (value_from_host_double): New function.
4151         (evaluate_subexp_f): Support UNOP_ABS.
4152
4153 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4154
4155         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4156         types.
4157
4158 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4159
4160         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4161         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4162         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4163
4164 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4165
4166         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4167
4168 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4169             Chris January  <chris.january@arm.com>
4170
4171         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4172         * f-exp.y: Define 'KIND' token.
4173         (exp): New pattern for KIND expressions.
4174         (ptype): Handle types with a kind extension.
4175         (direct_abs_decl): Extend to spot kind extensions.
4176         (f77_keywords): Add 'kind' to the list.
4177         (push_kind_type): New function.
4178         (convert_to_kind_type): New function.
4179         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4180         * parse.c (operator_length_standard): Likewise.
4181         * parser-defs.h (enum type_pieces): Add tp_kind.
4182         * std-operator.def: Add UNOP_KIND.
4183
4184 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4185
4186         * f-exp.y (f_parse): Set yydebug.
4187
4188 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4189
4190         * f-lang.c (evaluate_subexp_f): New function.
4191         (exp_descriptor_f): New global.
4192         (f_language_defn): Use exp_descriptor_f instead of
4193         exp_descriptor_standard.
4194
4195 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4196
4197         * f-exp.y (struct token): Add comments.
4198         (dot_ops): Remove uppercase versions and the end marker.
4199         (f77_keywords): Likewise.
4200         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4201         entries in the dot_ops array are case insensitive, and use
4202         strncasecmp to compare strings.  Also some whitespace cleanup in
4203         this area.  Similar for the f77_keywords array, except entries in
4204         this list might be case sensitive.
4205
4206 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4207
4208         * f-exp.y (struct f77_boolean_val): Add comments.
4209         (boolean_values): Remove uppercase versions, and end marker.
4210         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4211         and use strncasecmp to achieve case insensitivity.  Additionally,
4212         perform whitespace cleanup around this code.
4213
4214 2019-03-06  Tom Tromey  <tromey@adacore.com>
4215
4216         * remote-sim.c (gdbsim_target_open): Use result of
4217         gdb_argv::release.
4218
4219 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4220         Dirk Schubert  <dirk.schubert@arm.com>
4221         Chris January  <chris.january@arm.com>
4222
4223         * eval.c (evaluate_subexp_standard): Call Fortran argument
4224         wrapping logic.
4225         * f-lang.c (struct value): A value which can be passed into a
4226         Fortran function call.
4227         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4228         where appropriate.
4229         (struct type): Value ready for a Fortran function call.
4230         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4231         is needed.
4232         * f-lang.h (fortran_argument_convert): Declaration.
4233         (fortran_preserve_arg_pointer): Declaration.
4234         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4235
4236 2019-03-05  Tom Tromey  <tromey@adacore.com>
4237
4238         * python/py-prettyprint.c (print_string_repr): Remove #if.
4239         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4240
4241 2019-03-05  Tom Tromey  <tromey@adacore.com>
4242
4243         * target.c (the_dummy_target): Move later.  Change type to
4244         "dummy_target".
4245         (initialize_targets): Don't initialize the_dummy_target.
4246
4247 2019-03-05  Tom Tromey  <tromey@adacore.com>
4248
4249         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4250         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4251
4252 2019-03-05  Tom Tromey  <tromey@adacore.com>
4253
4254         * windows-nat.c (windows_nat_target::attach)
4255         (windows_nat_target::detach): Don't call gdb_flush.
4256         * valprint.c (generic_val_print, val_print, val_print_string):
4257         Don't call gdb_flush.
4258         * utils.c (defaulted_query): Don't call gdb_flush.
4259         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4260         * target.c (target_announce_detach): Don't call gdb_flush.
4261         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4262         * remote.c (extended_remote_target::attach): Don't call
4263         gdb_flush.
4264         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4265         * printcmd.c (do_examine): Don't call gdb_flush.
4266         (info_display_command): Don't call gdb_flush.
4267         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4268         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4269         * memattr.c (info_mem_command): Don't call gdb_flush.
4270         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4271         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4272         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4273         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4274         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4275         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4276         (gnu_nat_target::detach): Don't call gdb_flush.
4277         * f-valprint.c (f_val_print): Don't call gdb_flush.
4278         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4279         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4280         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4281         gdb_flush.
4282         * c-valprint.c (c_val_print): Don't call gdb_flush.
4283         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4284
4285 2019-03-05  Tom Tromey  <tromey@adacore.com>
4286
4287         * varobj.c (update_dynamic_varobj_children): Update.
4288         (install_default_visualizer): Use reset, not release.
4289         * value.c (set_internalvar): Update.
4290         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4291         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4292         ATTRIBUTE_UNUSED_RESULT.
4293
4294 2019-03-05  Tom Tromey  <tromey@adacore.com>
4295
4296         * remote.c (class scoped_remote_fd) <release>: Add
4297         ATTRIBUTE_UNUSED_RESULT.
4298
4299 2019-03-05  Tom Tromey  <tromey@adacore.com>
4300
4301         * macroexp.c (struct macro_buffer) <release>: Add
4302         ATTRIBUTE_UNUSED_RESULT.
4303
4304 2019-03-05  Tom Tromey  <tromey@adacore.com>
4305
4306         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4307         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4308         ATTRIBUTE_UNUSED_RESULT.
4309
4310 2019-03-05  Tom Tromey  <tromey@adacore.com>
4311
4312         * common/scoped_fd.h (class scoped_fd) <release>: Add
4313         ATTRIBUTE_UNUSED_RESULT.
4314
4315 2019-03-05  Tom Tromey  <tromey@adacore.com>
4316
4317         * parser-defs.h (struct parser_state) <release>: Add
4318         ATTRIBUTE_UNUSED_RESULT.
4319
4320 2019-03-05  Tom Tromey  <tromey@adacore.com>
4321
4322         * utils.h (class gdb_argv) <release>: Add
4323         ATTRIBUTE_UNUSED_RESULT.
4324         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4325
4326 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4327
4328         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4329         for-loop range, to avoid compiler warnings.
4330
4331         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4332         avoid compiler warnings about unused variables.
4333
4334         * NEWS: Mention end of support for native debugging on MS-Windows
4335         before XP.
4336
4337         PR gdb/24292
4338         * common/netstuff.c:
4339         * gdbserver/gdbreplay.c
4340         * gdbserver/remote-utils.c:
4341         * ser-tcp.c:
4342         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4343         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4344         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4345         'getaddrinfo' and 'freeaddrinfo' were not available before
4346         Windows XP, and mingw.org's MinGW headers by default define
4347         _WIN32_WINNT to 0x500.
4348
4349 2019-03-01  Gary Benson <gbenson@redhat.com>
4350
4351         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4352
4353 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4354             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4355
4356         PR gdb/8527
4357         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4358         set_sigint_trap, clear_sigint_trap.
4359
4360 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4361
4362         * target.c (target_detach): Clear the regcache and the
4363         frame cache.
4364
4365 2019-02-27  Pedro Alves  <palves@redhat.com>
4366
4367         * utils.c (set_screen_size): When we cap the height/width sizes,
4368         tweak the corresponding command variable to show "unlimited":
4369
4370 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4371             Pedro Alves  <palves@redhat.com>
4372
4373         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4374         before calling rl_set_screen_size.
4375
4376 2019-02-27  Tom Tromey  <tromey@adacore.com>
4377
4378         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4379         define.
4380         * python/py-value.c: Remove Python 2.4 workaround.
4381         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4382         workaround.
4383         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4384         Python 2.4 workaround.
4385         * python/python-internal.h: Remove Python 2.4 comment.
4386         (Py_ssize_t): Don't define.
4387         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4388         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4389         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4390         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4391         * python/python.c (do_start_initialization): Remove Python 2.4
4392         workaround.
4393         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4394         (print_children): Remove Python 2.4 workaround.
4395         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4396         workaround.
4397         (CHARBUFFERPROC_NAME): Remove.
4398         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4399         Python 2.4 workaround.
4400
4401 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4402
4403         * NEWS: Note minimum Python version.
4404
4405 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4406
4407         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4408         code from these functions.  Remove corresponding ifdefs.  Use
4409         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4410         Remove gotos and target of gotos.
4411         (infpy_search_memory): Likewise.
4412
4413 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4414
4415         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4416         (hppa_gdbarch_init): Don't register deleted functions with
4417         gdbarch.
4418
4419 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4420
4421         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4422         (h8300_unwind_sp): Delete.
4423         (h8300_dummy_id): Delete.
4424         (h8300_gdbarch_init): Don't register deleted functions with
4425         gdbarch.
4426
4427 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4428
4429         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4430         (ft32_unwind_pc): Delete.
4431         (ft32_unwind_sp): Delete.
4432         (ft32_gdbarch_init): Don't register deleted functions with
4433         gdbarch.
4434
4435 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4436
4437         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4438         (frv_unwind_pc): Delete.
4439         (frv_unwind_sp): Delete.
4440         (frv_gdbarch_init): Don't register deleted functions with
4441         gdbarch.
4442
4443 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4444
4445         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4446         (riscv_unwind_pc): Delete.
4447         (riscv_unwind_sp): Delete.
4448         (riscv_gdbarch_init): Don't register deleted functions with
4449         gdbarch.
4450
4451 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4452
4453         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4454         (csky_unwind_pc): Delete.
4455         (csky_unwind_sp): Delete.
4456         (csky_gdbarch_init): Don't register deleted functions with
4457         gdbarch.
4458
4459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4460
4461         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4462         (cris_unwind_pc): Delete.
4463         (cris_unwind_sp): Delete.
4464         (cris_gdbarch_init): Don't register deleted functions with
4465         gdbarch.
4466
4467 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4468
4469         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4470         (bfin_unwind_pc): Delete.
4471         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4472
4473 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4474
4475         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4476         (arm_unwind_pc): Delete.
4477         (arm_unwind_sp): Delete.
4478         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4479
4480 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4481
4482         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4483         (arc_unwind_pc): Delete.
4484         (arc_unwind_sp): Delete.
4485         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4486
4487 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4488
4489         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4490         (alpha_unwind_pc): Delete.
4491         (alpha_gdbarch_init): Don't register deleted functions with
4492         gdbarch.
4493
4494 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4495
4496         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4497         (aarch64_unwind_pc): Delete.
4498         (aarch64_unwind_sp): Delete.
4499         (aarch64_gdbarch_init): Don't register deleted functions with
4500         gdbarch.
4501
4502 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4503
4504         * gdbtypes.c (type_align): Don't consider static members when
4505         computing structure alignment.
4506
4507 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4508
4509         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4510         return 0 for other types.
4511         * arch-utils.c (default_type_align): Always return 0.
4512         * gdbarch.h: Regenerate.
4513         * gdbarch.sh (type_align): Extend comment.
4514         * gdbtypes.c (type_align): Add additional comments, always call
4515         gdbarch_type_align before applying the default rules.
4516         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4517         generic code will then apply a suitable default.
4518         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4519         types, return 0 for other types.
4520
4521 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4522
4523         * NEWS: Create a new section for the next release branch.
4524         Rename the section of the current branch, now that it has
4525         been cut.
4526
4527 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4528
4529         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4530         * version.in: Bump version to 8.3.50.DATE-git.
4531
4532 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4533
4534         * aix-thread.c (ptid_cmp): Remove unused variable.
4535         (get_signaled_thread): Likewise.
4536         (store_regs_user_thread): Likewise.
4537         (store_regs_kernel_thread): Likewise.
4538         (fetch_regs_kernel_thread): Remove shadowed variable.
4539
4540 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4541
4542         * features/riscv/32bit-cpu.xml: Add register numbers.
4543         * features/riscv/32bit-fpu.c: Regenerate.
4544         * features/riscv/32bit-fpu.xml: Add register numbers.
4545         * features/riscv/64bit-cpu.xml: Add register numbers.
4546         * features/riscv/64bit-fpu.c: Regenerate.
4547         * features/riscv/64bit-fpu.xml: Add register numbers.
4548
4549 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4550
4551         * NEWS: Mention two argument form of gdb.Value constructor.
4552         * python/py-value.c (convert_buffer_and_type_to_value): New
4553         function.
4554         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4555         Add support for handling an optional second argument.  Call
4556         convert_buffer_and_type_to_value as appropriate.
4557         * python/python-internal.h (Py_buffer_deleter): New struct.
4558         (Py_buffer_up): New typedef.
4559
4560 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4561
4562         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4563         instead of releasing ownership.
4564
4565 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4566
4567         * dwarf2read.c (open_and_init_dwp_file): Call
4568         elf_numsections instead of bfd_count_sections to initialize
4569         dwp_file->num_sections.
4570
4571 2019-02-25  Tom Tromey  <tromey@adacore.com>
4572
4573         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4574
4575 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4576
4577         * gcore.in: Add '--readnever' option when invoking GDB.
4578
4579 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4580
4581         * MAINTAINERS: Update my email address.
4582
4583 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4584
4585         * build-id.c (build_id_to_debug_bfd_1): New function.
4586         (build_id_to_debug_bfd): Look for separate debug file in
4587         sysroot.
4588
4589 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4590
4591         * gdbarch.sh: Update the copyright year range that is placed into
4592         generated files.
4593
4594 2019-02-22  Keith Seitz  <keiths@redhat.com>
4595
4596         PR symtab/23853
4597         * linespec.c (create_sals_line_offset): Search for the default
4598         symtab's filename instead of its fullname.
4599
4600 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4601
4602         * NEWS: Update style defaults.
4603
4604 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4605
4606         * main.c (captured_main_1): Disable styling in batch mode.
4607
4608 2019-02-20  Tom Tromey  <tom@tromey.com>
4609
4610         * symtab.c (symtab_symbol_info): Fix typos.
4611
4612 2019-02-20  Tom Tromey  <tromey@adacore.com>
4613
4614         * findcmd.c (_initialize_mem_search): Use upper case for
4615         metasyntactic variables.
4616
4617 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4618
4619         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4620         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4621
4622 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4623
4624         * top.h (source_file_name): Change to std::string.
4625         * top.c (source_file_name): Likewise.
4626         (command_line_input): Adjust.
4627         * cli/cli-script.c (script_from_file): Adjust.
4628
4629 2019-02-19  Tom Tromey  <tromey@adacore.com>
4630
4631         * ravenscar-thread.c
4632         (ravenscar_thread_target::update_thread_list): Don't call
4633         ada_build_task_list.
4634         * ada-lang.h (ada_build_task_list): Don't declare.
4635         * ada-tasks.c (struct ada_tasks_inferior_data)
4636         <task_list_valid_p>: Now bool.
4637         (read_known_tasks, ada_task_list_changed)
4638         (ada_tasks_invalidate_inferior_data): Update.
4639         (read_known_tasks_array): Return bool.
4640         (read_known_tasks_list): Likewise.
4641         (read_known_tasks): Return void.
4642         (ada_build_task_list): Now static.
4643
4644 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4645
4646         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4647         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4648
4649 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4650
4651         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4652         variant for ada_tasks_pspace_data_handle and
4653         ada_tasks_inferior_data_handle.
4654         (ada_tasks_pspace_data_cleanup): New function.
4655         (ada_tasks_inferior_data_cleanup): New function.
4656
4657 2019-02-17  Tom Tromey  <tom@tromey.com>
4658
4659         * macrotab.h (macro_source_fullname): Return a std::string.
4660         * macrotab.c (macro_include, check_for_redefinition)
4661         (macro_undef, macro_lookup_definition, foreach_macro)
4662         (foreach_macro_in_scope): Update.
4663         (macro_source_fullname): Return a std::string.
4664         * macrocmd.c (show_pp_source_pos): Update.
4665
4666 2019-02-17  Tom Tromey  <tom@tromey.com>
4667
4668         * macrocmd.c (show_pp_source_pos): Style the file names.
4669
4670 2019-02-17  Tom Tromey  <tom@tromey.com>
4671
4672         PR tui/24197:
4673         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4674
4675 2019-02-17  Tom Tromey  <tom@tromey.com>
4676
4677         * ada-lang.c (user_select_syms): Use filtered printing.
4678         * utils.c (wrap_style): New global.
4679         (desired_style): Remove.
4680         (emit_style_escape): Add stream parameter.
4681         (set_output_style, reset_terminal_style, prompt_for_continue):
4682         Update.
4683         (flush_wrap_buffer): Only flush gdb_stdout.
4684         (wrap_here): Set wrap_style.
4685         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4686         treat escape sequences as a character.  Change when wrap buffer is
4687         flushed.
4688         (fputs_styled): Do not set the output style when the default is
4689         requested.
4690         * ui-style.h (struct ui_file_style) <is_default>: New method.
4691         * source.c (print_source_lines_base): Emit escape sequences in one
4692         piece.
4693
4694 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4695
4696         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4697         integers and enumeration types.
4698
4699 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4700
4701         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4702         instead of lookup_symbol_in_language
4703         (do_exact_match): New function.
4704         (ada_get_symbol_name_matcher): Return do_exact_match when
4705         doing a verbatim match.
4706
4707 2019-02-15  Tom Tromey  <tromey@adacore.com>
4708
4709         * ravenscar-thread.c (ravenscar_thread_target::resume)
4710         (ravenscar_thread_target::wait): Special case wildcard requests.
4711
4712 2019-02-15  Tom Tromey  <tromey@adacore.com>
4713
4714         * ravenscar-thread.c (base_ptid): Remove.
4715         (struct ravenscar_thread_target) <close>: New method.
4716         <m_base_ptid>: New member.
4717         <update_inferior_ptid, active_task, task_is_currently_active,
4718         runtime_initialized>: Declare methods.
4719         <ravenscar_thread_target>: Add constructor.
4720         (ravenscar_thread_target::task_is_currently_active)
4721         (ravenscar_thread_target::update_inferior_ptid)
4722         (ravenscar_runtime_initialized): Rename.  Now methods.
4723         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4724         (ravenscar_thread_target::update_thread_list): Update.
4725         (ravenscar_thread_target::active_task): Now method.
4726         (ravenscar_thread_target::store_registers)
4727         (ravenscar_thread_target::prepare_to_store)
4728         (ravenscar_thread_target::prepare_to_store)
4729         (ravenscar_thread_target::mourn_inferior): Update.
4730         (ravenscar_inferior_created): Use "new" to create target.
4731         (ravenscar_thread_target::get_ada_task_ptid): Update.
4732         (_initialize_ravenscar): Don't initialize base_ptid.
4733         (ravenscar_ops): Remove global.
4734
4735 2019-02-15  Tom Tromey  <tromey@adacore.com>
4736
4737         * target.h (push_target): Declare new overload.
4738         * target.c (push_target): New overload, taking an rvalue reference.
4739         * remote.c (remote_target::open_1): Use push_target overload.
4740         * corelow.c (core_target_open): Use push_target overload.
4741
4742 2019-02-15  Tom Tromey  <tromey@adacore.com>
4743
4744         * ravenscar-thread.c (is_ravenscar_task)
4745         (ravenscar_task_is_currently_active): Return bool.
4746         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4747         (_initialize_ravenscar): Remove "(void)".
4748         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4749         Return bool.
4750
4751 2019-02-15  Tom Tromey  <tromey@adacore.com>
4752
4753         * ravenscar-thread.c (ravenscar_runtime_initializer)
4754         (has_ravenscar_runtime, get_running_thread_id)
4755         (ravenscar_thread_target::resume): Fix indentation.
4756
4757 2019-02-15  Tom Tromey  <tromey@adacore.com>
4758
4759         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4760         from ravenscar_arch_ops.
4761         (sparc_ravenscar_ops::fetch_registers)
4762         (sparc_ravenscar_ops::store_registers): Now methods.
4763         (sparc_ravenscar_prepare_to_store): Remove.
4764         (sparc_ravenscar_ops): Redefine.
4765         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4766         methods and destructor.  Remove members.
4767         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4768         (ravenscar_thread_target::store_registers)
4769         (ravenscar_thread_target::prepare_to_store): Update.
4770         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4771         Remove.
4772         (struct ppc_ravenscar_powerpc_ops): Derive from
4773         ravenscar_arch_ops.
4774         (ppc_ravenscar_powerpc_ops::fetch_registers)
4775         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4776         (ppc_ravenscar_powerpc_ops): Redefine.
4777         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4778         (ppc_ravenscar_e500_ops::fetch_registers)
4779         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4780         (ppc_ravenscar_e500_ops): Redefine.
4781         * aarch64-ravenscar-thread.c
4782         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4783         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4784         (aarch64_ravenscar_fetch_registers)
4785         (aarch64_ravenscar_store_registers): Now methods.
4786         (aarch64_ravenscar_ops): Redefine.
4787
4788 2019-02-15  Tom Tromey  <tromey@adacore.com>
4789
4790         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4791         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4792         (ravenscar_thread_target::stopped_by_watchpoint)
4793         (ravenscar_thread_target::stopped_data_address)
4794         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4795
4796 2019-02-15  Tom Tromey  <tromey@adacore.com>
4797
4798         * ravenscar-thread.c: Fix some typos.
4799
4800 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4801             Tom Tromey  <tromey@adacore.com>
4802
4803         * ada-lang.c (ada_exception_sal): Change addr_string to a
4804         std::string.
4805         (create_ada_exception_catchpoint): Update.
4806
4807 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4808             Tom Tromey  <tromey@adacore.com>
4809
4810         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4811         (bp_location_ops): Remove.
4812         (base_breakpoint_allocate_location): Update.
4813         (free_bp_location): Update.
4814         * ada-lang.c (class ada_catchpoint_location)
4815         <ada_catchpoint_location>: Remove ops parameter.
4816         (ada_catchpoint_location_dtor): Remove.
4817         (ada_catchpoint_location_ops): Remove.
4818         (allocate_location_exception): Update.
4819         * breakpoint.h (struct bp_location_ops): Remove.
4820         (class bp_location) <bp_location>: Remove bp_location_ops
4821         parameter.
4822         <~bp_location>: Add destructor.
4823         <ops>: Remove.
4824
4825 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4826             Pedro Alves  <palves@redhat.com>
4827
4828         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4829         'PATH_MAX'.
4830
4831 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4832             Samuel Thibault  <samuel.thibault@gnu.org>
4833             Thomas Schwinge  <thomas@codesourcery.com>
4834
4835         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4836         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4837
4838 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4839
4840         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4841         (check_empty): Use "const char *".
4842
4843         * gnu-nat.c (gnu_nat_target::detach): Instead of
4844         'detach_inferior (pid)' call
4845         'detach_inferior (find_inferior_pid (pid))'.
4846
4847         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4848         'nat/fork-inferior.o'.
4849         * gnu-nat.c: #include "nat/fork-inferior.h".
4850
4851         * gnu-nat.c (gnu_nat_target::detach): Instead of
4852         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4853         * gnu-nat.h: #include "inf-child.h".
4854         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4855         'i386_gnu_nat_target::fetch_registers'.
4856         (gnu_store_registers): Rename/move to
4857         'i386_gnu_nat_target::store_registers'.
4858
4859         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4860         * gnu-nat.h (mach_thread_info): New function.
4861         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4862
4863         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4864
4865 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4866
4867         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4868
4869 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4870
4871         * windows-nat.c (windows_add_thread): Add new parameter
4872         "main_thread_p" with default value set to false.  Update
4873         function documentation as well as all callers.
4874         (windows_delete_thread): Likewise.
4875         (fake_create_process): Update call to windows_add_thread.
4876         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4877         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4878         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4879         call to windows_delete_thread.
4880
4881 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4882
4883         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4884
4885 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4886
4887         * symfile.c (find_separate_debug_file): Use canonical path of
4888         sysroot with child_path instead of gdb_sysroot if it is valid.
4889
4890 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4891
4892         * symfile.c (find_separate_debug_file): Use child_path to
4893         determine if an object file is under a sysroot.
4894
4895 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4896
4897         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4898         unittests/child-path-selftests.c.
4899         * common/pathstuff.c (child_path): New function.
4900         * common/pathstuff.h (child_path): New prototype.
4901         * unittests/child-path-selftests.c: New file.
4902
4903 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4904
4905         * symfile.c (find_separate_debug_file): Look for separate debug
4906         files in debug directories under the sysroot.
4907
4908 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4909
4910         * symtab.h (struct minimal_symbol data_p): New const method.
4911         (struct minimal_symbol text_p): Likewise.
4912         * symtab.c (output_source_filename): Use file name style
4913         to print file name.
4914         (print_symbol_info): Likewise.
4915         (print_msymbol_info): Use address style to print addresses.
4916         Use function name style to print executable text symbols.
4917         (expand_symtab_containing_pc): Use data_p.
4918         (find_pc_sect_compunit_symtab): Likewise.
4919
4920 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4921
4922         * breakpoint.c (describe_other_breakpoints): Use address style
4923         to print addresses.
4924         (say_where): Likewise.
4925
4926 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4927
4928         * ada-typeprint.c (print_func_type): Print function name
4929         style to print function name.
4930         * c-typeprint.c (c_print_type_1): Likewise.
4931
4932 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4933
4934         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4935         for execve.
4936
4937 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4938
4939         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4940         type_stack.
4941
4942 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4943
4944         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4945         TYPE_CODE_REF types.
4946
4947 2019-02-08  Jim Wilson  <jimw@sifive.com>
4948
4949         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4950         (riscv_linux_fregset): New.
4951         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4952
4953 2019-02-07  Tom Tromey  <tom@tromey.com>
4954
4955         * thread.c (thread_cancel_execution_command): Update.
4956         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4957         methods.
4958         (struct thread_fsm_ops): Remove.
4959         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4960         (thread_fsm_should_stop, thread_fsm_return_value)
4961         (thread_fsm_set_finished, thread_fsm_finished_p)
4962         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4963         Don't declare.
4964         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4965         * infrun.c (clear_proceed_status_thread)
4966         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4967         (print_stop_event): Update.
4968         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4969         Add constructor.
4970         (step_command_fsm_ops): Remove.
4971         (new_step_command_fsm): Remove.
4972         (step_1): Update.
4973         (step_command_fsm::should_stop): Rename from
4974         step_command_fsm_should_stop.
4975         (step_command_fsm::clean_up): Rename from
4976         step_command_fsm_clean_up.
4977         (step_command_fsm::do_async_reply_reason): Rename from
4978         step_command_fsm_async_reply_reason.
4979         (struct until_next_fsm): Inherit from thread_fsm.  Add
4980         constructor.
4981         (until_next_fsm_ops): Remove.
4982         (new_until_next_fsm): Remove.
4983         (until_next_fsm::should_stop): Rename from
4984         until_next_fsm_should_stop.
4985         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4986         (until_next_fsm::do_async_reply_reason): Rename from
4987         until_next_fsm_async_reply_reason.
4988         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4989         constructor.  Change type of breakpoint.
4990         (finish_command_fsm_ops): Remove.
4991         (new_finish_command_fsm): Remove.
4992         (finish_command_fsm::should_stop): Rename from
4993         finish_command_fsm_should_stop.
4994         (finish_command_fsm::clean_up): Rename from
4995         finish_command_fsm_clean_up.
4996         (finish_command_fsm::return_value): Rename from
4997         finish_command_fsm_return_value.
4998         (finish_command_fsm::do_async_reply_reason): Rename from
4999         finish_command_fsm_async_reply_reason.
5000         (finish_command): Update.
5001         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5002         Add constructor.
5003         (call_thread_fsm_ops): Remove.
5004         (call_thread_fsm::call_thread_fsm): Rename from
5005         new_call_thread_fsm.
5006         (call_thread_fsm::should_stop): Rename from
5007         call_thread_fsm_should_stop.
5008         (call_thread_fsm::should_notify_stop): Rename from
5009         call_thread_fsm_should_notify_stop.
5010         (run_inferior_call, call_function_by_hand_dummy): Update.
5011         * cli/cli-interp.c (should_print_stop_to_console): Update.
5012         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5013         Add constructor.  Change type of location_breakpoint,
5014         caller_breakpoint.
5015         (until_break_fsm_ops): Remove.
5016         (new_until_break_fsm): Remove.
5017         (until_break_fsm::should_stop): Rename from
5018         until_break_fsm_should_stop.
5019         (until_break_fsm::clean_up): Rename from
5020         until_break_fsm_clean_up.
5021         (until_break_fsm::do_async_reply_reason): Rename from
5022         until_break_fsm_async_reply_reason.
5023         (until_break_command): Update.
5024         * thread-fsm.c: Remove.
5025         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5026
5027 2019-02-07  Tom Tromey  <tom@tromey.com>
5028
5029         * yy-remap.h: Add include guard.
5030         * xtensa-tdep.h: Add include guard.
5031         * xcoffread.h: Rename include guard.
5032         * varobj-iter.h: Add include guard.
5033         * tui/tui.h: Rename include guard.
5034         * tui/tui-winsource.h: Rename include guard.
5035         * tui/tui-wingeneral.h: Rename include guard.
5036         * tui/tui-windata.h: Rename include guard.
5037         * tui/tui-win.h: Rename include guard.
5038         * tui/tui-stack.h: Rename include guard.
5039         * tui/tui-source.h: Rename include guard.
5040         * tui/tui-regs.h: Rename include guard.
5041         * tui/tui-out.h: Rename include guard.
5042         * tui/tui-layout.h: Rename include guard.
5043         * tui/tui-io.h: Rename include guard.
5044         * tui/tui-hooks.h: Rename include guard.
5045         * tui/tui-file.h: Rename include guard.
5046         * tui/tui-disasm.h: Rename include guard.
5047         * tui/tui-data.h: Rename include guard.
5048         * tui/tui-command.h: Rename include guard.
5049         * tic6x-tdep.h: Add include guard.
5050         * target/waitstatus.h: Rename include guard.
5051         * target/wait.h: Rename include guard.
5052         * target/target.h: Rename include guard.
5053         * target/resume.h: Rename include guard.
5054         * target-float.h: Rename include guard.
5055         * stabsread.h: Add include guard.
5056         * rs6000-tdep.h: Add include guard.
5057         * riscv-fbsd-tdep.h: Add include guard.
5058         * regformats/regdef.h: Rename include guard.
5059         * record.h: Rename include guard.
5060         * python/python.h: Rename include guard.
5061         * python/python-internal.h: Rename include guard.
5062         * python/py-stopevent.h: Rename include guard.
5063         * python/py-ref.h: Rename include guard.
5064         * python/py-record.h: Rename include guard.
5065         * python/py-record-full.h: Rename include guard.
5066         * python/py-record-btrace.h: Rename include guard.
5067         * python/py-instruction.h: Rename include guard.
5068         * python/py-events.h: Rename include guard.
5069         * python/py-event.h: Rename include guard.
5070         * procfs.h: Add include guard.
5071         * proc-utils.h: Add include guard.
5072         * p-lang.h: Add include guard.
5073         * or1k-tdep.h: Rename include guard.
5074         * observable.h: Rename include guard.
5075         * nto-tdep.h: Rename include guard.
5076         * nat/x86-linux.h: Rename include guard.
5077         * nat/x86-linux-dregs.h: Rename include guard.
5078         * nat/x86-gcc-cpuid.h: Add include guard.
5079         * nat/x86-dregs.h: Rename include guard.
5080         * nat/x86-cpuid.h: Rename include guard.
5081         * nat/ppc-linux.h: Rename include guard.
5082         * nat/mips-linux-watch.h: Rename include guard.
5083         * nat/linux-waitpid.h: Rename include guard.
5084         * nat/linux-ptrace.h: Rename include guard.
5085         * nat/linux-procfs.h: Rename include guard.
5086         * nat/linux-osdata.h: Rename include guard.
5087         * nat/linux-nat.h: Rename include guard.
5088         * nat/linux-namespaces.h: Rename include guard.
5089         * nat/linux-btrace.h: Rename include guard.
5090         * nat/glibc_thread_db.h: Rename include guard.
5091         * nat/gdb_thread_db.h: Rename include guard.
5092         * nat/gdb_ptrace.h: Rename include guard.
5093         * nat/fork-inferior.h: Rename include guard.
5094         * nat/amd64-linux-siginfo.h: Rename include guard.
5095         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5096         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5097         * nat/aarch64-linux.h: Rename include guard.
5098         * nat/aarch64-linux-hw-point.h: Rename include guard.
5099         * mn10300-tdep.h: Add include guard.
5100         * mips-linux-tdep.h: Add include guard.
5101         * mi/mi-parse.h: Rename include guard.
5102         * mi/mi-out.h: Rename include guard.
5103         * mi/mi-main.h: Rename include guard.
5104         * mi/mi-interp.h: Rename include guard.
5105         * mi/mi-getopt.h: Rename include guard.
5106         * mi/mi-console.h: Rename include guard.
5107         * mi/mi-common.h: Rename include guard.
5108         * mi/mi-cmds.h: Rename include guard.
5109         * mi/mi-cmd-break.h: Rename include guard.
5110         * m2-lang.h: Add include guard.
5111         * location.h: Rename include guard.
5112         * linux-record.h: Rename include guard.
5113         * linux-nat.h: Add include guard.
5114         * linux-fork.h: Add include guard.
5115         * i386-darwin-tdep.h: Rename include guard.
5116         * hppa-linux-offsets.h: Add include guard.
5117         * guile/guile.h: Rename include guard.
5118         * guile/guile-internal.h: Rename include guard.
5119         * gnu-nat.h: Rename include guard.
5120         * gdb-stabs.h: Rename include guard.
5121         * frv-tdep.h: Add include guard.
5122         * f-lang.h: Add include guard.
5123         * event-loop.h: Add include guard.
5124         * darwin-nat.h: Rename include guard.
5125         * cp-abi.h: Rename include guard.
5126         * config/sparc/nm-sol2.h: Rename include guard.
5127         * config/nm-nto.h: Rename include guard.
5128         * config/nm-linux.h: Add include guard.
5129         * config/i386/nm-i386gnu.h: Rename include guard.
5130         * config/djgpp/nl_types.h: Rename include guard.
5131         * config/djgpp/langinfo.h: Rename include guard.
5132         * compile/gcc-cp-plugin.h: Add include guard.
5133         * compile/gcc-c-plugin.h: Add include guard.
5134         * compile/compile.h: Rename include guard.
5135         * compile/compile-object-run.h: Rename include guard.
5136         * compile/compile-object-load.h: Rename include guard.
5137         * compile/compile-internal.h: Rename include guard.
5138         * compile/compile-cplus.h: Rename include guard.
5139         * compile/compile-c.h: Rename include guard.
5140         * common/xml-utils.h: Rename include guard.
5141         * common/x86-xstate.h: Rename include guard.
5142         * common/version.h: Rename include guard.
5143         * common/vec.h: Rename include guard.
5144         * common/tdesc.h: Rename include guard.
5145         * common/selftest.h: Rename include guard.
5146         * common/scoped_restore.h: Rename include guard.
5147         * common/scoped_mmap.h: Rename include guard.
5148         * common/scoped_fd.h: Rename include guard.
5149         * common/safe-iterator.h: Rename include guard.
5150         * common/run-time-clock.h: Rename include guard.
5151         * common/refcounted-object.h: Rename include guard.
5152         * common/queue.h: Rename include guard.
5153         * common/ptid.h: Rename include guard.
5154         * common/print-utils.h: Rename include guard.
5155         * common/preprocessor.h: Rename include guard.
5156         * common/pathstuff.h: Rename include guard.
5157         * common/observable.h: Rename include guard.
5158         * common/netstuff.h: Rename include guard.
5159         * common/job-control.h: Rename include guard.
5160         * common/host-defs.h: Rename include guard.
5161         * common/gdb_wait.h: Rename include guard.
5162         * common/gdb_vecs.h: Rename include guard.
5163         * common/gdb_unlinker.h: Rename include guard.
5164         * common/gdb_unique_ptr.h: Rename include guard.
5165         * common/gdb_tilde_expand.h: Rename include guard.
5166         * common/gdb_sys_time.h: Rename include guard.
5167         * common/gdb_string_view.h: Rename include guard.
5168         * common/gdb_splay_tree.h: Rename include guard.
5169         * common/gdb_setjmp.h: Rename include guard.
5170         * common/gdb_ref_ptr.h: Rename include guard.
5171         * common/gdb_optional.h: Rename include guard.
5172         * common/gdb_locale.h: Rename include guard.
5173         * common/gdb_assert.h: Rename include guard.
5174         * common/filtered-iterator.h: Rename include guard.
5175         * common/filestuff.h: Rename include guard.
5176         * common/fileio.h: Rename include guard.
5177         * common/environ.h: Rename include guard.
5178         * common/common-utils.h: Rename include guard.
5179         * common/common-types.h: Rename include guard.
5180         * common/common-regcache.h: Rename include guard.
5181         * common/common-inferior.h: Rename include guard.
5182         * common/common-gdbthread.h: Rename include guard.
5183         * common/common-exceptions.h: Rename include guard.
5184         * common/common-defs.h: Rename include guard.
5185         * common/common-debug.h: Rename include guard.
5186         * common/cleanups.h: Rename include guard.
5187         * common/buffer.h: Rename include guard.
5188         * common/btrace-common.h: Rename include guard.
5189         * common/break-common.h: Rename include guard.
5190         * cli/cli-utils.h: Rename include guard.
5191         * cli/cli-style.h: Rename include guard.
5192         * cli/cli-setshow.h: Rename include guard.
5193         * cli/cli-script.h: Rename include guard.
5194         * cli/cli-interp.h: Rename include guard.
5195         * cli/cli-decode.h: Rename include guard.
5196         * cli/cli-cmds.h: Rename include guard.
5197         * charset-list.h: Add include guard.
5198         * buildsym-legacy.h: Rename include guard.
5199         * bfin-tdep.h: Add include guard.
5200         * ax.h: Rename include guard.
5201         * arm-linux-tdep.h: Add include guard.
5202         * arm-fbsd-tdep.h: Add include guard.
5203         * arch/xtensa.h: Rename include guard.
5204         * arch/tic6x.h: Add include guard.
5205         * arch/i386.h: Add include guard.
5206         * arch/arm.h: Rename include guard.
5207         * arch/arm-linux.h: Rename include guard.
5208         * arch/arm-get-next-pcs.h: Rename include guard.
5209         * arch/amd64.h: Add include guard.
5210         * arch/aarch64-insn.h: Rename include guard.
5211         * arch-utils.h: Rename include guard.
5212         * annotate.h: Add include guard.
5213         * amd64-darwin-tdep.h: Rename include guard.
5214         * aarch64-linux-tdep.h: Add include guard.
5215         * aarch64-fbsd-tdep.h: Add include guard.
5216         * aarch32-linux-nat.h: Add include guard.
5217
5218 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5219
5220         * macrotab.c (macro_define_internal): New function that
5221         factorizes macro_define_object_internal and macro_define_function
5222         code.
5223         (macro_define_object_internal): Use macro_define_internal.
5224         (macro_define_function): Likewise.
5225
5226 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5227
5228         * macrocmd.c (extract_identifier): Return
5229         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5230         callers.
5231
5232 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5233
5234         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5235
5236 2019-02-05  Tom Tromey  <tom@tromey.com>
5237
5238         * target.c (target_stack::unpush): Move assertion earlier.
5239
5240 2019-01-30  Tom Tromey  <tom@tromey.com>
5241
5242         PR python/23615:
5243         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5244         (gdbpy_parse_and_eval): Likewise.
5245         * python/python-internal.h (gdbpy_allow_threads): New class.
5246
5247 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5248
5249         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5250         (aarch64_fbsd_fpregmap): Move earlier.
5251         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5252         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5253         instead of individual calls to trad_frame_set_reg_addr.
5254         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5255         earlier.
5256         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5257         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5258         instead of individual calls to trad_frame_set_reg_addr.
5259
5260 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5261
5262         * CONTRIBUTE: Replace contribution list with wiki link.
5263
5264 2019-01-25  Tom Tromey  <tom@tromey.com>
5265
5266         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5267
5268 2019-01-25  Tom Tromey  <tom@tromey.com>
5269
5270         * xtensa-linux-nat.c: Fix common/ includes.
5271         * xml-support.h: Fix common/ includes.
5272         * xml-support.c: Fix common/ includes.
5273         * x86-linux-nat.c: Fix common/ includes.
5274         * windows-nat.c: Fix common/ includes.
5275         * varobj.h: Fix common/ includes.
5276         * varobj.c: Fix common/ includes.
5277         * value.c: Fix common/ includes.
5278         * valops.c: Fix common/ includes.
5279         * utils.c: Fix common/ includes.
5280         * unittests/xml-utils-selftests.c: Fix common/ includes.
5281         * unittests/utils-selftests.c: Fix common/ includes.
5282         * unittests/unpack-selftests.c: Fix common/ includes.
5283         * unittests/tracepoint-selftests.c: Fix common/ includes.
5284         * unittests/style-selftests.c: Fix common/ includes.
5285         * unittests/string_view-selftests.c: Fix common/ includes.
5286         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5287         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5288         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5289         * unittests/rsp-low-selftests.c: Fix common/ includes.
5290         * unittests/parse-connection-spec-selftests.c: Fix common/
5291         includes.
5292         * unittests/optional-selftests.c: Fix common/ includes.
5293         * unittests/offset-type-selftests.c: Fix common/ includes.
5294         * unittests/observable-selftests.c: Fix common/ includes.
5295         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5296         * unittests/memrange-selftests.c: Fix common/ includes.
5297         * unittests/memory-map-selftests.c: Fix common/ includes.
5298         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5299         * unittests/function-view-selftests.c: Fix common/ includes.
5300         * unittests/environ-selftests.c: Fix common/ includes.
5301         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5302         * unittests/common-utils-selftests.c: Fix common/ includes.
5303         * unittests/cli-utils-selftests.c: Fix common/ includes.
5304         * unittests/array-view-selftests.c: Fix common/ includes.
5305         * ui-file.c: Fix common/ includes.
5306         * tui/tui-io.c: Fix common/ includes.
5307         * tracepoint.h: Fix common/ includes.
5308         * tracepoint.c: Fix common/ includes.
5309         * tracefile-tfile.c: Fix common/ includes.
5310         * top.h: Fix common/ includes.
5311         * top.c: Fix common/ includes.
5312         * thread.c: Fix common/ includes.
5313         * target/waitstatus.h: Fix common/ includes.
5314         * target/waitstatus.c: Fix common/ includes.
5315         * target.h: Fix common/ includes.
5316         * target.c: Fix common/ includes.
5317         * target-memory.c: Fix common/ includes.
5318         * target-descriptions.c: Fix common/ includes.
5319         * symtab.h: Fix common/ includes.
5320         * symfile.c: Fix common/ includes.
5321         * stap-probe.c: Fix common/ includes.
5322         * spu-linux-nat.c: Fix common/ includes.
5323         * sparc-nat.c: Fix common/ includes.
5324         * source.c: Fix common/ includes.
5325         * solib.c: Fix common/ includes.
5326         * solib-target.c: Fix common/ includes.
5327         * ser-unix.c: Fix common/ includes.
5328         * ser-tcp.c: Fix common/ includes.
5329         * ser-pipe.c: Fix common/ includes.
5330         * ser-base.c: Fix common/ includes.
5331         * selftest-arch.c: Fix common/ includes.
5332         * s12z-tdep.c: Fix common/ includes.
5333         * rust-exp.y: Fix common/ includes.
5334         * rs6000-aix-tdep.c: Fix common/ includes.
5335         * riscv-tdep.c: Fix common/ includes.
5336         * remote.c: Fix common/ includes.
5337         * remote-notif.h: Fix common/ includes.
5338         * remote-fileio.h: Fix common/ includes.
5339         * remote-fileio.c: Fix common/ includes.
5340         * regcache.h: Fix common/ includes.
5341         * regcache.c: Fix common/ includes.
5342         * record-btrace.c: Fix common/ includes.
5343         * python/python.c: Fix common/ includes.
5344         * python/py-type.c: Fix common/ includes.
5345         * python/py-inferior.c: Fix common/ includes.
5346         * progspace.h: Fix common/ includes.
5347         * producer.c: Fix common/ includes.
5348         * procfs.c: Fix common/ includes.
5349         * proc-api.c: Fix common/ includes.
5350         * printcmd.c: Fix common/ includes.
5351         * ppc-linux-nat.c: Fix common/ includes.
5352         * parser-defs.h: Fix common/ includes.
5353         * osdata.c: Fix common/ includes.
5354         * obsd-nat.c: Fix common/ includes.
5355         * nat/x86-linux.c: Fix common/ includes.
5356         * nat/x86-linux-dregs.c: Fix common/ includes.
5357         * nat/x86-dregs.h: Fix common/ includes.
5358         * nat/x86-dregs.c: Fix common/ includes.
5359         * nat/ppc-linux.c: Fix common/ includes.
5360         * nat/mips-linux-watch.h: Fix common/ includes.
5361         * nat/mips-linux-watch.c: Fix common/ includes.
5362         * nat/linux-waitpid.c: Fix common/ includes.
5363         * nat/linux-ptrace.h: Fix common/ includes.
5364         * nat/linux-ptrace.c: Fix common/ includes.
5365         * nat/linux-procfs.c: Fix common/ includes.
5366         * nat/linux-personality.c: Fix common/ includes.
5367         * nat/linux-osdata.c: Fix common/ includes.
5368         * nat/linux-namespaces.c: Fix common/ includes.
5369         * nat/linux-btrace.h: Fix common/ includes.
5370         * nat/linux-btrace.c: Fix common/ includes.
5371         * nat/fork-inferior.c: Fix common/ includes.
5372         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5373         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5374         * nat/aarch64-linux.c: Fix common/ includes.
5375         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5376         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5377         * namespace.h: Fix common/ includes.
5378         * mips-linux-tdep.c: Fix common/ includes.
5379         * minsyms.c: Fix common/ includes.
5380         * mi/mi-parse.h: Fix common/ includes.
5381         * mi/mi-main.c: Fix common/ includes.
5382         * mi/mi-cmd-env.c: Fix common/ includes.
5383         * memrange.h: Fix common/ includes.
5384         * memattr.c: Fix common/ includes.
5385         * maint.h: Fix common/ includes.
5386         * maint.c: Fix common/ includes.
5387         * main.c: Fix common/ includes.
5388         * machoread.c: Fix common/ includes.
5389         * location.c: Fix common/ includes.
5390         * linux-thread-db.c: Fix common/ includes.
5391         * linux-nat.c: Fix common/ includes.
5392         * linux-fork.c: Fix common/ includes.
5393         * inline-frame.c: Fix common/ includes.
5394         * infrun.c: Fix common/ includes.
5395         * inflow.c: Fix common/ includes.
5396         * inferior.h: Fix common/ includes.
5397         * inferior.c: Fix common/ includes.
5398         * infcmd.c: Fix common/ includes.
5399         * inf-ptrace.c: Fix common/ includes.
5400         * inf-child.c: Fix common/ includes.
5401         * ia64-linux-nat.c: Fix common/ includes.
5402         * i387-tdep.c: Fix common/ includes.
5403         * i386-tdep.c: Fix common/ includes.
5404         * i386-linux-tdep.c: Fix common/ includes.
5405         * i386-linux-nat.c: Fix common/ includes.
5406         * i386-go32-tdep.c: Fix common/ includes.
5407         * i386-fbsd-tdep.c: Fix common/ includes.
5408         * i386-fbsd-nat.c: Fix common/ includes.
5409         * guile/scm-type.c: Fix common/ includes.
5410         * guile/guile.c: Fix common/ includes.
5411         * go32-nat.c: Fix common/ includes.
5412         * gnu-nat.c: Fix common/ includes.
5413         * gdbthread.h: Fix common/ includes.
5414         * gdbarch-selftests.c: Fix common/ includes.
5415         * gdb_usleep.c: Fix common/ includes.
5416         * gdb_select.h: Fix common/ includes.
5417         * gdb_bfd.c: Fix common/ includes.
5418         * gcore.c: Fix common/ includes.
5419         * fork-child.c: Fix common/ includes.
5420         * findvar.c: Fix common/ includes.
5421         * fbsd-nat.c: Fix common/ includes.
5422         * event-top.c: Fix common/ includes.
5423         * event-loop.c: Fix common/ includes.
5424         * dwarf2read.c: Fix common/ includes.
5425         * dwarf2loc.c: Fix common/ includes.
5426         * dwarf2-frame.c: Fix common/ includes.
5427         * dwarf-index-cache.c: Fix common/ includes.
5428         * dtrace-probe.c: Fix common/ includes.
5429         * disasm-selftests.c: Fix common/ includes.
5430         * defs.h: Fix common/ includes.
5431         * csky-tdep.c: Fix common/ includes.
5432         * cp-valprint.c: Fix common/ includes.
5433         * cp-support.h: Fix common/ includes.
5434         * cp-support.c: Fix common/ includes.
5435         * corelow.c: Fix common/ includes.
5436         * completer.h: Fix common/ includes.
5437         * completer.c: Fix common/ includes.
5438         * compile/compile.c: Fix common/ includes.
5439         * compile/compile-loc2c.c: Fix common/ includes.
5440         * compile/compile-cplus-types.c: Fix common/ includes.
5441         * compile/compile-cplus-symbols.c: Fix common/ includes.
5442         * command.h: Fix common/ includes.
5443         * cli/cli-dump.c: Fix common/ includes.
5444         * cli/cli-cmds.c: Fix common/ includes.
5445         * charset.c: Fix common/ includes.
5446         * build-id.c: Fix common/ includes.
5447         * btrace.h: Fix common/ includes.
5448         * btrace.c: Fix common/ includes.
5449         * breakpoint.h: Fix common/ includes.
5450         * breakpoint.c: Fix common/ includes.
5451         * ax.h:
5452         (enum agent_op): Fix common/ includes.
5453         * ax-general.c (struct aop_map): Fix common/ includes.
5454         * ax-gdb.c: Fix common/ includes.
5455         * auxv.c: Fix common/ includes.
5456         * auto-load.c: Fix common/ includes.
5457         * arm-tdep.c: Fix common/ includes.
5458         * arch/riscv.c: Fix common/ includes.
5459         * arch/ppc-linux-common.c: Fix common/ includes.
5460         * arch/i386.c: Fix common/ includes.
5461         * arch/arm.c: Fix common/ includes.
5462         * arch/arm-linux.c: Fix common/ includes.
5463         * arch/arm-get-next-pcs.c: Fix common/ includes.
5464         * arch/amd64.c: Fix common/ includes.
5465         * arch/aarch64.c: Fix common/ includes.
5466         * arch/aarch64-insn.c: Fix common/ includes.
5467         * arch-utils.c: Fix common/ includes.
5468         * amd64-windows-tdep.c: Fix common/ includes.
5469         * amd64-tdep.c: Fix common/ includes.
5470         * amd64-sol2-tdep.c: Fix common/ includes.
5471         * amd64-obsd-tdep.c: Fix common/ includes.
5472         * amd64-nbsd-tdep.c: Fix common/ includes.
5473         * amd64-linux-tdep.c: Fix common/ includes.
5474         * amd64-linux-nat.c: Fix common/ includes.
5475         * amd64-fbsd-tdep.c: Fix common/ includes.
5476         * amd64-fbsd-nat.c: Fix common/ includes.
5477         * amd64-dicos-tdep.c: Fix common/ includes.
5478         * amd64-darwin-tdep.c: Fix common/ includes.
5479         * agent.c: Fix common/ includes.
5480         * ada-lang.h: Fix common/ includes.
5481         * ada-lang.c: Fix common/ includes.
5482         * aarch64-tdep.c: Fix common/ includes.
5483
5484 2019-01-25  Tom Tromey  <tom@tromey.com>
5485
5486         * common/create-version.sh: Use common/version.h.
5487
5488 2019-01-24  Pedro Alves  <palves@redhat.com>
5489
5490         * infrun.c (signal_stop, signal_print, signal_program)
5491         (signal_catch, signal_pass): Now arrays instead of pointers.
5492         (update_signals_program_target, do_target_resume)
5493         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5494         * linux-nat.c (linux_nat_target::pass_signals)
5495         (linux_nat_target::create_inferior, linux_nat_target::attach):
5496         Adjust.
5497         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5498         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5499         * procfs.c (procfs_target::pass_signals): Adjust.
5500         * record-full.c (record_full_target::resume): Adjust.
5501         * remote.c (remote_target::pass_signals)
5502         (remote_target::program_signals): Adjust.
5503         * target-debug.h (target_debug_print_signals): Now takes a
5504         gdb::array_view as parameter.  Adjust.
5505         * target.h (target_ops) <pass_signals, program_signals>: Replace
5506         pointer and length parameters with gdb::array_view.
5507         (target_pass_signals, target_program_signals): Likewise.
5508         * target-delegates.c: Regenerate.
5509
5510 2019-01-24  Pedro Alves  <palves@redhat.com>
5511
5512         * common/forward-scope-exit.h
5513         (forward_scope_exit::forward_scope_exit): Pass arguments to
5514         m_bind_function directly, instead of creating a std::bind and
5515         copying that.
5516
5517 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5518
5519         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5520         for static members.
5521         (pass_in_v_vfp_candidate): Likewise.
5522
5523 2019-01-23  Tom Tromey  <tom@tromey.com>
5524             Pedro Alves  <palves@redhat.com>
5525
5526         * regcache.c (class regcache_invalidator): Remove.
5527         (regcache::raw_write): Use make_scope_exit.
5528
5529 2019-01-23  Tom Tromey  <tom@tromey.com>
5530
5531         * ui-out.h (class ui_out_emit_type): Update comment.
5532
5533 2019-01-23  Tom Tromey  <tom@tromey.com>
5534
5535         * infrun.c (fetch_inferior_event): Update comment.
5536
5537 2019-01-23  Tom Tromey  <tom@tromey.com>
5538             Pedro Alves  <palves@redhat.com>
5539
5540         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5541         parameter.
5542         (fetch_inferior_event): Use SCOPE_EXIT.
5543
5544
5545 2019-01-23  Tom Tromey  <tom@tromey.com>
5546             Pedro Alves  <palves@redhat.com>
5547
5548         * infrun.c (disable_thread_events): Delete.
5549         (stop_all_threads): Use SCOPE_EXIT.
5550
5551 2019-01-23  Tom Tromey  <tom@tromey.com>
5552             Pedro Alves  <palves@redhat.com>
5553
5554         * symfile.c: Include forward-scope-exit.h.
5555         (clear_symtab_users_cleanup): Replace forward declaration with
5556         a FORWARD_SCOPE_EXIT.
5557         (syms_from_objfile_1): Use the forward_scope_exit and
5558         gdb::optional instead of cleanup_function.
5559         (reread_symbols): Use the forward_scope_exit instead of
5560         cleanup_function.
5561         (clear_symtab_users_cleanup): Remove function.
5562
5563 2019-01-23  Tom Tromey  <tom@tromey.com>
5564             Pedro Alves  <palves@redhat.com>
5565
5566         * linux-nat.c: Include scope-exit.h.
5567         (cleanup_target_stop): Remove.
5568         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5569         SCOPE_EXIT.
5570
5571 2019-01-23  Tom Tromey  <tom@tromey.com>
5572             Pedro Alves  <palves@redhat.com>
5573
5574         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5575         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5576
5577 2019-01-23  Tom Tromey  <tom@tromey.com>
5578             Andrew Burgess  <andrew.burgess@embecosm.com>
5579             Pedro Alves  <palves@redhat.com>
5580
5581         * infrun.c (fetch_inferior_event): Use scope_exit.
5582         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5583         * top.c (execute_command): Use scope_exit.
5584         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5585         * utils.c (do_bpstat_clear_actions_cleanup)
5586         (make_bpstat_clear_actions_cleanup): Remove.
5587
5588 2019-01-23  Tom Tromey  <tom@tromey.com>
5589             Pedro Alves  <palves@redhat.com>
5590
5591         * infrun.c: Include "common/scope-exit.h"
5592         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5593         (wait_for_inferior): Use SCOPE_EXIT.
5594         (fetch_inferior_event): Use scope_exit.
5595
5596 2019-01-23  Tom Tromey  <tom@tromey.com>
5597             Pedro Alves  <palves@redhat.com>
5598
5599         * breakpoint.c (create_breakpoint): Remove cleanup.
5600
5601 2019-01-23  Tom Tromey  <tom@tromey.com>
5602             Andrew Burgess  <andrew.burgess@embecosm.com>
5603             Pedro Alves  <palves@redhat.com>
5604
5605 2019-01-23  Pedro Alves  <palves@redhat.com>
5606
5607         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5608
5609 2019-01-23  Pedro Alves  <palves@redhat.com>
5610             Andrew Burgess  <andrew.burgess@embecosm.com>
5611
5612         * gdbthread.h: Include "common/forward-scope-exit.h".
5613         (scoped_finish_thread_state): Redefine custom class in terms of
5614         forward_scope_exit.
5615
5616 2019-01-23  Pedro Alves  <palves@redhat.com>
5617             Andrew Burgess  <andrew.burgess@embecosm.com>
5618
5619         * common/forward-scope-exit.h: New file.
5620
5621 2019-01-23  Pedro Alves  <palves@redhat.com>
5622             Andrew Burgess  <andrew.burgess@embecosm.com>
5623             Tom Tromey  <tom@tromey.com>
5624
5625         * common/scope-exit.h: New file.
5626
5627 2019-01-23  Pedro Alves  <palves@redhat.com>
5628
5629         * common/preprocessor.h (ESC): Rename to ...
5630         (ESC_PARENS): ... this.
5631         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5632         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5633
5634 2019-01-23  Tom Tromey  <tom@tromey.com>
5635
5636         * language.h (class scoped_switch_to_sym_language_if_auto):
5637         Initialize m_lang in both cases.
5638
5639 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5640
5641         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5642         with XCNEW.
5643
5644 2019-01-22  Tom Tromey  <tom@tromey.com>
5645
5646         * corelow.c: Do not include sys/file.h.
5647
5648 2019-01-22  Tom Tromey  <tom@tromey.com>
5649
5650         * tui/tui-wingeneral.h: Include gdb_curses.h.
5651
5652 2019-01-22  Tom Tromey  <tom@tromey.com>
5653
5654         * source-cache.h (class source_cache) <get_source_lines,
5655         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5656
5657 2019-01-22  Tom Tromey  <tom@tromey.com>
5658
5659         * remote-fileio.h (struct remote_target): Declare.
5660
5661 2019-01-22  Tom Tromey  <tom@tromey.com>
5662
5663         * python/py-arch.c: Do not include py-ref.h.
5664         * python/py-bpevent.c: Do not include py-ref.h.
5665         * python/py-cmd.c: Do not include py-ref.h.
5666         * python/py-continueevent.c: Do not include py-ref.h.
5667         * python/py-event.h: Do not include py-ref.h.
5668         * python/py-evtregistry.c: Do not include py-ref.h.
5669         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5670         * python/py-frame.c: Do not include py-ref.h.
5671         * python/py-framefilter.c: Do not include py-ref.h.
5672         * python/py-function.c: Do not include py-ref.h.
5673         * python/py-infevents.c: Do not include py-ref.h.
5674         * python/py-linetable.c: Do not include py-ref.h.
5675         * python/py-objfile.c: Do not include py-ref.h.
5676         * python/py-param.c: Do not include py-ref.h.
5677         * python/py-prettyprint.c: Do not include py-ref.h.
5678         * python/py-progspace.c: Do not include py-ref.h.
5679         * python/py-symbol.c: Do not include py-ref.h.
5680         * python/py-symtab.c: Do not include py-ref.h.
5681         * python/py-type.c: Do not include py-ref.h.
5682         * python/py-unwind.c: Do not include py-ref.h.
5683         * python/py-utils.c: Do not include py-ref.h.
5684         * python/py-value.c: Do not include py-ref.h.
5685         * python/py-varobj.c: Do not include py-ref.h.
5686         * python/py-xmethods.c: Do not include py-ref.h.
5687         * python/python.c: Do not include py-ref.h.
5688         * varobj.c: Do not include py-ref.h.
5689
5690 2019-01-22  Tom Tromey  <tom@tromey.com>
5691
5692         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5693         keyword for bcache.
5694
5695 2019-01-22  Tom Tromey  <tom@tromey.com>
5696
5697         * compile/compile-cplus-types.c: Remove a comment by #include.
5698
5699 2019-01-22  Tom Tromey  <tom@tromey.com>
5700
5701         * compile/gcc-c-plugin.h: Include compile-internal.h.
5702
5703 2019-01-22  Tom Tromey  <tom@tromey.com>
5704
5705         * stabsread.c (EXTERN): Do not define.
5706         (symnum, next_symbol_text_func, processing_gcc_compilation)
5707         (within_function, global_sym_chain, global_stabs)
5708         (previous_stab_code, this_object_header_files)
5709         (n_this_object_header_files)
5710         (n_allocated_this_object_header_files): Define.
5711         * stabsread.h (EXTERN): Never define.  Use "extern".
5712
5713 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5714
5715         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5716         history_value.
5717
5718 2019-01-21  Tom Tromey  <tom@tromey.com>
5719
5720         * ui-out.c: Fix includes.
5721         * tui/tui-source.c: Fix includes.
5722         * target.c: Fix includes.
5723         * remote.c: Fix includes.
5724         * regcache.c: Fix includes.
5725         * python/py-block.c: Fix includes.
5726         * printcmd.c: Fix includes.
5727         * or1k-tdep.c: Fix includes.
5728         * mi/mi-main.c: Fix includes.
5729         * m32r-tdep.c: Fix includes.
5730         * csky-tdep.c: Fix includes.
5731         * compile/compile-cplus-types.c: Fix includes.
5732         * cli/cli-interp.c: Fix includes.
5733
5734 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5735
5736         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5737         for padding.
5738
5739 2019-01-16  Tom Tromey  <tom@tromey.com>
5740
5741         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5742         earlier.
5743         (struct objfile) <msymbols_range>: Move from top level.
5744         <msymbols>: New method.
5745         (class objfile_msymbols): Remove.
5746         * symtab.c (default_collect_symbol_completion_matches_break_on):
5747         Update.
5748         * symmisc.c (dump_msymbols): Update.
5749         * stabsread.c (scan_file_globals): Update.
5750         * objc-lang.c (info_selectors_command, info_classes_command)
5751         (find_methods): Update.
5752         * minsyms.c (find_solib_trampoline_target): Update.
5753         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5754         * coffread.c (coff_symfile_read): Update.
5755         * ada-lang.c (ada_lookup_simple_minsym)
5756         (ada_collect_symbol_completion_matches): Update.
5757
5758 2019-01-16  Tom Tromey  <tom@tromey.com>
5759
5760         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5761         type.  Remove no-argument constructor.
5762         <iterator::operator++>: Simplify.
5763         <begin>: Update.
5764         <end>: Use minimal_symbol_count.
5765
5766 2019-01-16  Tom Tromey  <tom@tromey.com>
5767
5768         * objfiles.h (struct objfile) <psymtabs>: New method.
5769         (class objfile_psymtabs): Remove.
5770         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5771         typedef.
5772         <range>: New method.
5773         (require_partial_symbols): Change return type.
5774         * psymtab.c (require_partial_symbols)
5775         (psym_expand_symtabs_matching): Update.
5776         * mdebugread.c (parse_partial_symbols): Update.
5777         * dbxread.c (dbx_end_psymtab): Update.
5778
5779 2019-01-15  Tom Tromey  <tom@tromey.com>
5780
5781         * symtab.c (lookup_objfile_from_block)
5782         (lookup_symbol_in_objfile_symtabs)
5783         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5784         (find_line_symtab, info_sources_command)
5785         (default_collect_symbol_completion_matches_break_on)
5786         (make_source_files_completion_list): Update.
5787         * symmisc.c (print_objfile_statistics, dump_objfile)
5788         (maintenance_print_symbols, maintenance_info_symtabs)
5789         (maintenance_check_symtabs, maintenance_info_line_tables):
5790         Update.
5791         * source.c (select_source_symtab)
5792         (forget_cached_source_info_for_objfile): Update.
5793         * objfiles.h (class objfile_compunits): Remove.
5794         (struct objfile) <compunits_range>: New typedef.
5795         (compunits): New method.
5796         * objfiles.c (objfile_relocate1): Update.
5797         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5798         * maint.c (count_symtabs_and_blocks): Update.
5799         * linespec.c (iterate_over_all_matching_symtabs): Update.
5800         * cp-support.c (add_symbol_overload_list_qualified): Update.
5801         * coffread.c (coff_symtab_read): Update.
5802         * ada-lang.c (add_nonlocal_symbols)
5803         (ada_collect_symbol_completion_matches)
5804         (ada_add_global_exceptions): Update.
5805
5806 2019-01-15  Tom Tromey  <tom@tromey.com>
5807
5808         * progspace.h (program_space) <objfiles_safe_range>: New
5809         typedef.
5810         <objfiles_safe>: New method.
5811         * objfiles.h (class all_objfiles_safe): Remove.
5812         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5813         * jit.c (jit_inferior_exit_hook): Update.
5814
5815 2019-01-17  Tom Tromey  <tom@tromey.com>
5816
5817         * progspace.h (program_space) <objfiles_range>: New typedef.
5818         <objfiles>: New method.
5819         <objfiles_head>: Rename from objfiles.
5820         (object_files): Update.
5821         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5822         * guile/scm-pretty-print.c
5823         (ppscm_find_pretty_printer_from_objfiles): Update.
5824         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5825         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5826         Update.
5827         * python/py-progspace.c (pspy_get_objfiles): Update.
5828         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5829         Update.
5830         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5831         (objfpy_lookup_objfile_by_build_id): Update.
5832         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5833         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5834         Update.
5835         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5836         (expand_symtab_containing_pc, lookup_objfile_from_block)
5837         (lookup_static_symbol, basic_lookup_transparent_type)
5838         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5839         (find_line_symtab, info_sources_command)
5840         (default_collect_symbol_completion_matches_break_on)
5841         (make_source_files_completion_list, find_main_name): Update.
5842         * symmisc.c (print_symbol_bcache_statistics)
5843         (print_objfile_statistics, maintenance_print_symbols)
5844         (maintenance_print_msymbols, maintenance_print_objfiles)
5845         (maintenance_info_symtabs, maintenance_check_symtabs)
5846         (maintenance_expand_symtabs, maintenance_info_line_tables):
5847         Update.
5848         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5849         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5850         (map_overlay_command, unmap_overlay_command)
5851         (simple_overlay_update, expand_symtabs_matching)
5852         (map_symbol_filenames): Update.
5853         * symfile-debug.c (set_debug_symfile): Update.
5854         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5855         Update.
5856         * source.c (select_source_symtab, forget_cached_source_info):
5857         Update.
5858         * solib.c (solib_read_symbols): Update.
5859         * solib-spu.c (append_ocl_sos): Update.
5860         * psymtab.c (maintenance_print_psymbols)
5861         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5862         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5863         * printcmd.c (info_symbol_command): Update.
5864         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5865         Update.
5866         * objfiles.h (class all_objfiles): Remove.
5867         * objfiles.c (have_partial_symbols, have_full_symbols)
5868         (have_minimal_symbols, qsort_cmp, update_section_map)
5869         (shared_objfile_contains_address_p)
5870         (default_iterate_over_objfiles_in_search_order): Update.
5871         * objc-lang.c (info_selectors_command, info_classes_command)
5872         (find_methods): Update.
5873         * minsyms.c (find_solib_trampoline_target): Update.
5874         * maint.c (maintenance_info_sections)
5875         (maintenance_translate_address, count_symtabs_and_blocks):
5876         Update.
5877         * main.c (captured_main_1): Update.
5878         * linux-thread-db.c (try_thread_db_load_from_pdir)
5879         (has_libpthread): Update.
5880         * linespec.c (iterate_over_all_matching_symtabs)
5881         (search_minsyms_for_name): Update.
5882         * jit.c (jit_find_objf_with_entry_addr): Update.
5883         * hppa-tdep.c (find_unwind_entry)
5884         (hppa_lookup_stub_minimal_symbol): Update.
5885         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5886         Update.
5887         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5888         (elf_gnu_ifunc_resolve_by_got): Update.
5889         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5890         * dwarf-index-write.c (save_gdb_index_command): Update.
5891         * cp-support.c (add_symbol_overload_list_qualified): Update.
5892         * breakpoint.c (create_overlay_event_breakpoint)
5893         (create_longjmp_master_breakpoint)
5894         (create_std_terminate_master_breakpoint)
5895         (create_exception_master_breakpoint): Update.
5896         * blockframe.c (find_pc_partial_function): Update.
5897         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5898         (ada_collect_symbol_completion_matches)
5899         (ada_add_global_exceptions): Update.
5900
5901 2019-01-17  Tom Tromey  <tom@tromey.com>
5902
5903         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5904         declare VEC.
5905         (solib_target_parse_libraries): Change return type.
5906         (library_list_start_segment, library_list_start_section)
5907         (library_list_end_library, library_list_start_library); Update.
5908         (solib_target_free_library_list): Remove.
5909         (solib_target_parse_libraries): Remove cleanup.  Change return
5910         type.
5911         (solib_target_current_sos): Update.
5912
5913 2019-01-17  Tom Tromey  <tromey@bapiya>
5914
5915         * valprint.c: Replace "the the" with "the".
5916         * symtab.c: Replace "the the" with "the".
5917         * solib.c: Replace "the the" with "the".
5918         * solib-dsbt.c: Replace "the the" with "the".
5919         * linespec.c: Replace "the the" with "the".
5920         * dwarf2loc.h: Replace "the the" with "the".
5921         * amd64-windows-tdep.c: Replace "the the" with "the".
5922         * aarch64-tdep.c: Replace "the the" with "the".
5923
5924 2019-01-16  Keith Seitz  <keiths@redhat.com>
5925
5926         PR gdb/23773
5927         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5928         <builder>: Rename to ..
5929         <m_builder>: ... this and make private.
5930         (dwarf2_cu::get_builder): New method.  Change all users of
5931         `builder' to use this method.
5932         (dwarf2_start_symtab): Move to ...
5933         (dwarf2_cu::start_symtab): ... here.  Update all callers
5934         (setup_type_unit_groups): Move to ...
5935         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5936         callers.
5937         (dwarf2_cu::reset_builder): New method.
5938         (process_full_compunit, process_full_type_unit): Use
5939         dwarf2_cu::reset_builder.
5940         (follow_die_offset): Record the ancestor CU if it is different
5941         from the followed DIE's CU.
5942         (follow_die_sig_1): Likewise.
5943
5944 2019-01-15  Tom Tromey  <tom@tromey.com>
5945
5946         * remote.c (class remote_state) <buf>: Now a char_vector.
5947         <buf_size>: Remove.
5948         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5949         parameter.
5950         (remote_target::getpkt_or_notif_sane_1)
5951         (remote_target::getpkt_sane)
5952         (remote_target::getpkt_or_notif_sane): Likewise.
5953         (class remote_target) <putpkt>: New overload.
5954         (remote_target::read_frame): Change type of "buf_p".  Remove
5955         sizeof_p parameter.
5956         (packet_ok): New overload.
5957         (packet_check_result): New overload.
5958         Update all uses.
5959
5960 2019-01-14  Tom Tromey  <tom@tromey.com>
5961
5962         * remote-notif.c (handle_notification, remote_notif_ack)
5963         (remote_notif_parse): Make "buf" const.
5964         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5965         const.
5966         (remote_notif_parse, remote_notif_ack, handle_notification):
5967         Likewise.
5968         * remote.c (remote_notif_stop_parse): Make "buf" const.
5969         (remote_target::remote_parse_stop_reply): Make "buf" const.
5970         (remote_notif_stop_ack): Make "buf" const.
5971
5972 2019-01-14  Tom Tromey  <tom@tromey.com>
5973
5974         * remote.c (remote_console_output): Make parameter const.
5975
5976 2019-01-14  Tom Tromey  <tom@tromey.com>
5977
5978         * target-debug.h (target_debug_print_signals): Constify.
5979         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5980         * procfs.c (procfs_target::pass_signals): Update.
5981         * linux-nat.c (linux_nat_target::pass_signals): Update.
5982         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5983         * target-delegates.c: Rebuild.
5984         * remote.c (remote_target::program_signals): Update.
5985         (remote_target::pass_signals): Update.
5986         * target.c (target_pass_signals): Constify argument.
5987         (target_program_signals): Likewise.
5988         * target.h (struct target_ops) <pass_signals, program_signals>:
5989         Constify argument.
5990         (target_pass_signals, target_program_signals): Constify argument.
5991
5992 2019-01-14  Tom Tromey  <tom@tromey.com>
5993
5994         PR tui/28819:
5995         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5996
5997 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5998
5999         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6000         field.
6001         * rs6000-tdep.c: Include reggroups.h.
6002         (IS_V_ALIAS_PSEUDOREG): Define.
6003         (rs6000_register_name): Return names for the "vX" aliases.
6004         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6005         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6006         aliases.  Call default_register_reggroup_p for all other
6007         pseudo-registers.
6008         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6009         New functions.
6010         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6011         Handle "vX" aliases.
6012         (v_alias_pseudo_register_collect): New function.
6013         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6014         (rs6000_gdbarch_init): Initialize "vX" aliases as
6015         pseudo-registers.  Restore registration of
6016         rs6000_pseudo_register_reggroup_p with
6017         set_tdesc_pseudo_register_reggroup_p.
6018
6019 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6020
6021         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6022         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6023         set_gdbarch_num_pseudo_regs.
6024
6025 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6026
6027         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6028         Remove arg prefixname, add do_set and do_show.
6029         Add member functions set_list and show_list.
6030         * cli/cli-style.c (class cli_style_option): Update accordingly.
6031         (style_set_list): Move to file scope.
6032         (style_show_list): Likewise.
6033         (set_style): Call help_list.
6034         (show_style): Call cmd_show_list.
6035         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6036         Update to use the new macro.
6037
6038 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6039
6040         * ada-lang.c (_initialize_ada_language): Expand the help text
6041         for the "catch exception" command.
6042
6043 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6044
6045         * symtab.c (matching_obj_sections): Initialize obj,
6046         declare it closer to its usage.
6047
6048 2019-01-10  Tom Tromey  <tom@tromey.com>
6049
6050         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6051         (basic_inf_threads_range): Remove.
6052         (inf_threads_range, inf_non_exited_threads_range)
6053         (safe_inf_threads_range): Use next_adapter.
6054
6055 2019-01-10  Keith Seitz  <keiths@redhat.com>
6056
6057         PR gdb/23712
6058         PR symtab/23010
6059         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6060         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6061
6062 2019-01-10  Keith Seitz  <keiths@redhat.com>
6063
6064         PR gdb/23712
6065         PR symtab/23010
6066         * dictionary.c (pending_to_vector): Remove.
6067         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6068         Remove _1 suffix, replacing functions of the same name.  Update
6069         all callers.
6070         (dict_create_hashed, dict_create_hashed_expandable)
6071         (dict_create_linear, dict_create_linear_expandable, dict_free)
6072         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6073         Make functions static.
6074
6075 2019-01-10  Keith Seitz  <keiths@redhat.com>
6076
6077         PR gdb/23712
6078         PR symtab/23010
6079         * dictionary.h (struct dictionary): Replace declaration with
6080         multidictionary.
6081         (dict_create_hashed, dict_create_hashed_expandable)
6082         (dict_create_linear, dict_create_linear_expandable)
6083         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6084         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6085         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6086         taking multidictionary argument.
6087         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6088         * block.h (struct block) <dict>: Change to multidictionary
6089         and rename `multidict'.
6090         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6091         symmisc.c: Update all dictionary references to multidictionary.
6092
6093 2019-01-10  Keith Seitz  <keiths@redhat.com>
6094
6095         PR gdb/23712
6096         PR symtab/23010
6097         * dictionary.c: Include unordered_map.
6098         (pending_to_vector): New function.
6099         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6100         Rewrite the non-"_1" functions to take vector instead
6101         of linked list.
6102         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6103         "new" _1 versions of the same name.
6104         (multidictionary): Define.
6105         (std::hash<enum language): New definition.
6106         (collate_pending_symbols_by_language, mdict_create_hashed)
6107         (mdict_create_hashed_expandable, mdict_create_linear)
6108         (mdict_create_linear_expandable, mdict_free)
6109         (find_language_dictionary, create_new_language_dictionary)
6110         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6111         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6112         (mdict_size, mdict_empty): New functions.
6113         * dictionary.h (mdict_iterator): Define.
6114
6115 2019-01-10  Pedro Alves  <palves@redhat.com>
6116
6117         * breakpoint.c (read_uploaded_action)
6118         (create_tracepoint_from_upload): Adjust to use
6119         gdb::unique_xmalloc_ptr.
6120         * ctf.c (ctf_write_uploaded_tp):
6121         (SET_ARRAY_FIELD): Use emplace_back.
6122         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6123         * tracefile-tfile.c (tfile_write_uploaded_tp):
6124         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6125         gdb::unique_xmalloc_ptr.
6126         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6127         at_string, cond_string, cmd_strings>: Replace char pointers
6128         with gdb::unique_xmalloc_ptr.
6129
6130 2019-01-10  Pedro Alves  <palves@redhat.com>
6131
6132         * solib-target.c (library_list_start_library): Don't xstrdup name.
6133
6134 2019-01-10  Pedro Alves  <palves@redhat.com>
6135
6136         * mdebugread.c (parse_partial_symbols): Use
6137         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6138
6139 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6140
6141         * linux-fork.c (scoped_switch_fork_info)
6142         <~scoped_switch_fork_info>: Fix incorrect variable name.
6143
6144 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6145
6146         * linux-fork.c (scoped_switch_fork_info)
6147         <scoped_switch_fork_info>: Make explicit.
6148         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6149
6150 2019-01-10  Tom Tromey  <tom@tromey.com>
6151
6152         * objfiles.h (objfile::reset_psymtabs): Update.
6153         * objfiles.c (objfile::objfile): Update.
6154         * psymtab.h (psymtab_storage::obstack): Update.
6155         (psymtab_storage::m_obstack): Use gdb::optional.
6156         (class psymtab_storage): Update comment.  Remove objfile
6157         parameter.
6158         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6159
6160 2019-01-10  Tom Tromey  <tom@tromey.com>
6161
6162         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6163         <free_psymtabs>: Now private.
6164         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6165         (allocate_psymtab): Use new method.
6166
6167 2019-01-10  Tom Tromey  <tom@tromey.com>
6168
6169         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6170         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6171         * mdebugread.c (parse_partial_symbols): Use
6172         allocate_dependencies.
6173         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6174         allocate_dependencies.
6175         (process_psymtab_comp_unit_reader)
6176         (build_type_psymtab_dependencies): Likewise.
6177         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6178
6179 2019-01-10  Tom Tromey  <tom@tromey.com>
6180
6181         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6182         PSYMBOL_SET_LANGUAGE.
6183         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6184
6185 2019-01-10  Tom Tromey  <tom@tromey.com>
6186
6187         * psymtab.h (psymtab_storage::obstack): New method.
6188         <m_obstack>: Rename from obstack; now private.
6189         * psymtab.c (psymtab_storage): Update.
6190         * dwarf2read.c (create_addrmap_from_index)
6191         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6192         Update.
6193
6194 2019-01-10  Tom Tromey  <tom@tromey.com>
6195
6196         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6197         * objfiles.h (objfile::reset_psymtabs): New method.
6198
6199 2019-01-10  Tom Tromey  <tom@tromey.com>
6200
6201         * symmisc.c (print_symbol_bcache_statistics): Update.
6202         (print_objfile_statistics): Update.
6203         * symfile.c (reread_symbols): Update.
6204         * psymtab.h (class psymtab_storage): New.
6205         * psymtab.c (psymtab_storage): New constructor.
6206         (~psymtab_storage): New destructor.
6207         (require_partial_symbols): Update.
6208         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6209         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6210         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6211         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6212         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6213         (start_psymtab_common, end_psymtab_common)
6214         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6215         (allocate_psymtab): Update.
6216         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6217         Update.
6218         (dump_psymtab_addrmap, maintenance_print_psymbols)
6219         (maintenance_check_psymtabs): Update.
6220         (class objfile_psymtabs): Move to objfiles.h.
6221         * psympriv.h (discard_psymtab): Now inline.
6222         (psymtab_discarder::psymtab_discarder): Update.
6223         (psymtab_discarder::~psymtab_discarder): Update.
6224         (ALL_OBJFILE_PSYMTABS): Rewrite.
6225         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6226         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6227         Remove fields.
6228         <partial_symtabs>: New field.
6229         (class objfile_psymtabs): Move from psymtab.h.  Update.
6230         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6231         psymbol_cache.
6232         (objfile::~objfile): Don't destroy psymbol_cache.
6233         * mdebugread.c (parse_partial_symbols): Update.
6234         * dwarf2read.c (create_addrmap_from_index)
6235         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6236         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6237         (add_partial_subprogram, dwarf2_ranges_read): Update.
6238         * dwarf-index-write.c (write_address_map)
6239         (write_one_signatured_type, recursively_write_psymbols)
6240         (class debug_names, class debug_names, write_psymtabs_to_index):
6241         Update.
6242
6243 2019-01-10  Tom Tromey  <tom@tromey.com>
6244
6245         * symtab.h (SYMBOL_SET_NAMES): Update.
6246         (symbol_set_names): Update.
6247         (MSYMBOL_SET_NAMES): Update.
6248         * symtab.c (symbol_set_names): Change argument to be an
6249         objfile_per_bfd_storage.
6250         * psymtab.c (add_psymbol_to_bcache): Update.
6251         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6252
6253 2019-01-10  Tom Tromey  <tom@tromey.com>
6254
6255         * symtab.c (create_demangled_names_hash): Change argument to be an
6256         objfile_per_bfd_storage.
6257         (symbol_set_names): Update.
6258
6259 2019-01-10  Tom Tromey  <tom@tromey.com>
6260
6261         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6262         init_psymbol_list.
6263         * psymtab.c (init_psymbol_list): Do nothing if already called.
6264         * psympriv.h (init_psymbol_list): Add comment.
6265         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6266         init_psymbol_list.
6267         * dbxread.c (dbx_symfile_read): Unconditionally call
6268         init_psymbol_list.
6269
6270 2019-01-10  Tom Tromey  <tom@tromey.com>
6271
6272         * xcoffread.c (scan_xcoff_symtab): Update.
6273         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6274         "where".
6275         * mdebugread.c (parse_partial_symbols)
6276         (handle_psymbol_enumerators): Update.
6277         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6278         * dbxread.c (read_dbx_symtab): Update.
6279         * psympriv.h (psymbol_placement): New enum.
6280         (add_psymbol_to_list): Update.
6281
6282 2019-01-10  Tom Tromey  <tom@tromey.com>
6283
6284         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6285         static_psymbols parameters.
6286         (scan_xcoff_symtab): Update.
6287         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6288         static_psymbols parameters.
6289         * psympriv.h (start_psymtab_common): Update.
6290         * mdebugread.c (parse_partial_symbols): Update.
6291         * dwarf2read.c (create_partial_symtab): Update.
6292         * dbxread.c (read_dbx_symtab): Update.
6293         (start_psymtab): Remove global_psymbols and static_psymbols
6294         parameters.
6295
6296 2019-01-10  Tom Tromey  <tom@tromey.com>
6297
6298         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6299         * psymtab.c (allocate_psymtab): Add comment.
6300         * psympriv.h (allocate_psymtab): Add comment.
6301         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6302         initializations.
6303         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6304
6305 2019-01-10  Tom Tromey  <tom@tromey.com>
6306
6307         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6308         Don't declare.
6309         * mipsread.c: Include mdebugread.h.
6310         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6311         Declare.
6312         * elfread.c: Include mdebugread.h.
6313
6314 2019-01-09  Tom Tromey  <tom@tromey.com>
6315
6316         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6317         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6318         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6319         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6320         (psym_lookup_symbol, psym_find_last_source_symtab)
6321         (psym_forget_cached_source_info, psym_print_stats)
6322         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6323         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6324         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6325         (psym_find_compunit_symtab_by_address)
6326         (maintenance_print_psymbols, maintenance_info_psymtabs)
6327         (maintenance_check_psymtabs): Use ranged for.
6328         * psymtab.h (class objfile_psymtabs): New.
6329         (require_partial_symbols): Return objfile_psymtabs.
6330         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6331
6332 2019-01-09  Tom Tromey  <tom@tromey.com>
6333
6334         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6335         (find_pc_mapped_section, list_overlays_command)
6336         (map_overlay_command, unmap_overlay_command)
6337         (simple_overlay_update): Use all_objfiles.
6338         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6339         * printcmd.c (info_symbol_command): Use all_objfiles.
6340         * objfiles.h (ALL_OBJSECTIONS): Remove.
6341         * maint.c (maintenance_translate_address): Use all_objfiles.
6342         * gcore.c (gcore_create_callback): Use all_objfiles.
6343         (objfile_find_memory_regions): Likewise.
6344
6345 2019-01-09  Tom Tromey  <tom@tromey.com>
6346
6347         * symtab.c (find_line_symtab, info_sources_command)
6348         (make_source_files_completion_list): Use objfile_compunits.
6349         * source.c (select_source_symtab): Use objfile_compunits.
6350         * objfiles.h (struct objfile): Update comment.
6351         (ALL_OBJFILES): Remove.
6352         (ALL_FILETABS): Remove.
6353         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6354         objfile_compunits.
6355
6356 2019-01-09  Tom Tromey  <tom@tromey.com>
6357
6358         * symmisc.c (print_objfile_statistics, dump_objfile)
6359         (maintenance_print_symbols): Use compunit_filetabs.
6360         * source.c (forget_cached_source_info_for_objfile): Use
6361         compunit_filetabs.
6362         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6363         (ALL_FILETABS): Use compunit_filetabs.
6364         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6365         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6366
6367 2019-01-09  Tom Tromey  <tom@tromey.com>
6368
6369         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6370         (compunit_filetabs): New.
6371         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6372         compunit_filetabs.
6373         (info_sources_command, make_source_files_completion_list): Remove
6374         declaration.
6375         * symmisc.c (print_objfile_statistics, dump_objfile)
6376         (maintenance_print_symbols): Remove declaration.
6377         (maintenance_info_symtabs): Use compunit_filetabs.
6378         (maintenance_info_line_tables): Likewise.
6379         * source.c (select_source_symtab): Change local variable name.
6380         (forget_cached_source_info_for_objfile): Remove declaration.
6381         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6382         * objfiles.c (objfile_relocate1): Remove declaration.
6383         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6384         declaration.
6385         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6386         * coffread.c (coff_symtab_read): Remove declaration.
6387         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6388         compunit_filetabs.
6389
6390 2019-01-09  Tom Tromey  <tom@tromey.com>
6391
6392         * symtab.c (lookup_objfile_from_block)
6393         (find_pc_sect_compunit_symtab, search_symbols)
6394         (default_collect_symbol_completion_matches_break_on): Use
6395         objfile_compunits.
6396         * objfiles.h (ALL_COMPUNITS): Remove.
6397         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6398         * cp-support.c (add_symbol_overload_list_qualified): Use
6399         objfile_compunits.
6400         * ada-lang.c (ada_collect_symbol_completion_matches)
6401         (ada_add_global_exceptions): Use objfile_compunits.
6402
6403 2019-01-09  Tom Tromey  <tom@tromey.com>
6404
6405         * source.c (select_source_symtab)
6406         (forget_cached_source_info_for_objfile): Remove declaration.
6407         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6408         declaration.
6409         * maint.c (count_symtabs_and_blocks): Remove declaration.
6410         * cp-support.c (add_symbol_overload_list_qualified): Remove
6411         declaration.
6412         * coffread.c (coff_symtab_read): Remove declaration.
6413         * symtab.c (lookup_symbol_in_objfile_symtabs)
6414         (basic_lookup_transparent_type_1): Use objfile_compunits.
6415         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6416         (info_sources_command, search_symbols)
6417         (default_collect_symbol_completion_matches_break_on)
6418         (make_source_files_completion_list): Remove declaration.
6419         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6420         (ada_collect_symbol_completion_matches)
6421         (ada_add_global_exceptions): Remove declaration.
6422         * linespec.c (iterate_over_all_matching_symtabs): Use
6423         objfile_compunits.
6424         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6425         (class objfile_compunits): New.
6426         (ALL_COMPUNITS): Use objfile_compunits.
6427         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6428         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6429         objfile_compunits.
6430         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6431
6432 2019-01-09  Tom Tromey  <tom@tromey.com>
6433
6434         * symtab.c (search_symbols)
6435         (default_collect_symbol_completion_matches_break_on): Use
6436         objfile_msymbols.
6437         * ada-lang.c (ada_lookup_simple_minsym)
6438         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6439         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6440         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6441         objfile_msymbols.
6442         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6443         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6444         * objc-lang.c (find_methods): Use objfile_msymbols.
6445         (info_selectors_command, info_classes_command): Likewise.
6446         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6447         * objfiles.h (class objfile_msymbols): New.
6448         (ALL_OBJFILE_MSYMBOLS): Remove.
6449         (ALL_MSYMBOLS): Remove.
6450
6451 2019-01-09  Tom Tromey  <tom@tromey.com>
6452
6453         * common/next-iterator.h (next_adapter): Add Iterator template
6454         parameter.
6455         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6456         (class all_objfiles_safe): New.
6457         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6458         * objfiles.c (put_objfile_before): Update comment.
6459         (add_separate_debug_objfile): Likewise.
6460         (free_all_objfiles): Use all_objfiles_safe.
6461         (objfile_purge_solibs): Likewise.
6462
6463 2019-01-09  Tom Tromey  <tom@tromey.com>
6464
6465         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6466         (expand_symtab_containing_pc, lookup_static_symbol)
6467         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6468         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6469         all_objfiles.
6470         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6471         * breakpoint.c (create_overlay_event_breakpoint)
6472         (create_longjmp_master_breakpoint)
6473         (create_std_terminate_master_breakpoint)
6474         (create_exception_master_breakpoint): Use all_objfiles.
6475         * linux-thread-db.c (try_thread_db_load_from_pdir)
6476         (has_libpthread): Use all_objfiles.
6477         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6478         * linespec.c (iterate_over_all_matching_symtabs)
6479         (search_minsyms_for_name): Use all_objfiles.
6480         * maint.c (maintenance_info_sections): Use all_objfiles.
6481         * main.c (captured_main_1): Use all_objfiles.
6482         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6483         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6484         * guile/scm-pretty-print.c
6485         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6486         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6487         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6488         (maintenance_print_msymbols): Use all_objfiles.
6489         * source.c (select_source_symtab): Use all_objfiles.
6490         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6491         * symfile.c (remove_symbol_file_command)
6492         (expand_symtabs_matching, map_symbol_filenames): Use
6493         all_objfiles.
6494         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6495         all_objfiles.
6496         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6497         * objc-lang.c (find_methods): Use all_objfiles.
6498         * objfiles.c (have_partial_symbols, have_full_symbols)
6499         (have_minimal_symbols, qsort_cmp)
6500         (default_iterate_over_objfiles_in_search_order): Use
6501         all_objfiles.
6502         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6503         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6504         (maintenance_check_psymtabs): Use all_objfiles.
6505         (ALL_PSYMTABS): Remove.
6506         * compile/compile-object-run.c (do_module_cleanup): Use
6507         all_objfiles.
6508         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6509         * cp-support.c (add_symbol_overload_list_qualified): Use
6510         all_objfiles.
6511         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6512         Use all_objfiles.
6513         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6514         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6515         all_objfiles.
6516         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6517         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6518         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6519         Uses all_objfiles.
6520         * solib.c (solib_read_symbols): Use all_objfiles
6521
6522 2019-01-09  Tom Tromey  <tom@tromey.com>
6523
6524         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6525         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6526         all_objfiles.
6527         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6528         * symmisc.c (print_symbol_bcache_statistics)
6529         (print_objfile_statistics, maintenance_print_objfiles)
6530         (maintenance_info_symtabs, maintenance_check_symtabs)
6531         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6532         all_objfiles.
6533         * source.c (forget_cached_source_info): Use all_objfiles.
6534         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6535         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6536         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6537         * objfiles.c (update_section_map): Use all_objfiles.
6538         (shared_objfile_contains_address_p): Likewise.
6539         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6540         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6541
6542 2019-01-09  Tom Tromey  <tom@tromey.com>
6543
6544         * common/next-iterator.h: New file.
6545         * objfiles.h (class all_objfiles): New.
6546         (struct objfile_iterator): New.
6547
6548 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6549
6550         * NEWS: Move the description of the changed "frame", "select-frame",
6551          and "info frame" commands to the Changed commands section.
6552
6553 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6554
6555         * gdbtypes.c (check_stub_method_group): Remove handling of old
6556         mangling schemes.
6557         * linespec.c (find_methods): Likewise.
6558         * stabsread.c (read_member_functions): Likewise.
6559         * valops.c (search_struct_method): Likewise.
6560         (value_struct_elt_for_reference): Likewise.
6561         * NEWS: Mention this change.
6562
6563 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6564
6565         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6566         print_source_lines.
6567         * source.c (print_source_lines_base): Update line number check.
6568         (print_source_lines): New function.
6569         (source_lines_range::source_lines_range): New function.
6570         * source.h (class source_lines_range): New class.
6571         (print_source_lines): New declaration.
6572
6573 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6574
6575         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6576
6577 2019-01-08  Tom Tromey  <tom@tromey.com>
6578             Simon Marchi  <simon.marchi@ericsson.com>
6579
6580         PR gdb/24060
6581         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6582         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6583         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6584         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6585         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6586         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6587
6588 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6589
6590         * source.c (select_source_symtab): Move header comment to
6591         declaration in source.h.
6592         (forget_cached_source_info_for_objfile): Likewise.
6593         (forget_cached_source_info): Likewise.
6594         (identify_source_line): Likewise.
6595         * source.h (identify_source_line): Move declaration from symtab.h
6596         and add comment from source.c
6597         (print_source_lines): Likewise.
6598         (forget_cached_source_info_for_objfile): Likewise.
6599         (forget_cached_source_info): Likewise.
6600         (select_source_symtab): Likewise.
6601         (enum print_source_lines_flag): Move definition from symtab.h.
6602         * symtab.h (identify_source_line): Move declaration to source.h.
6603         (print_source_lines): Likewise.
6604         (forget_cached_source_info_for_objfile): Likewise.
6605         (forget_cached_source_info): Likewise.
6606         (select_source_symtab): Likewise.
6607         (enum print_source_lines_flag): Move definition to source.h.
6608         * tui/tui-hooks.c: Add 'source.h' include.
6609
6610 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6611
6612         * source.c (print_source_lines_base): Handle requests to print
6613         reverse line number sequences, and guard against empty lines
6614         string.
6615
6616 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6617
6618         * source.c (print_source_lines_base): Fix skip of '\r' if next
6619         character is '\n'.
6620
6621 2019-01-06  Tom Tromey  <tom@tromey.com>
6622
6623         * c-exp.y (struct c_parse_state) <macro_original_text,
6624         expansion_obstack>: New member.
6625         (macro_original_text, expansion_obstack): Remove globals.
6626         (scan_macro_expansion, scanning_macro_expansion)
6627         (finished_macro_expansion): Update.
6628         (scan_macro_cleanup): Remove.
6629         (yylex, c_parse): Update.
6630
6631 2019-01-06  Tom Tromey  <tom@tromey.com>
6632
6633         * c-exp.y (struct c_parse_state) <strings>: New member.
6634         (operator_stoken): Update.
6635
6636 2019-01-06  Tom Tromey  <tom@tromey.com>
6637
6638         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6639         (union type_stack_elt) <typelist_val>: Now a pointer to
6640         std::vector.
6641         (type_stack_cleanup): Don't declare.
6642         (push_typelist): Update.
6643         * parse.c (pop_typelist): Return a std::vector.
6644         (push_typelist): Take a std::vector.
6645         (follow_types): Update.  Do not free args.
6646         (type_stack_cleanup): Remove.
6647         * c-exp.y (struct c_parse_state): New.
6648         (cpstate): New global.
6649         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6650         (nonempty_typelist): Update.
6651         (func_mod): Create a new vector.
6652         (c_parse): Create a c_parse_state.
6653         (check_parameter_typelist): Do not delete params.
6654         (function_method): Update.  Do not delete type_list.
6655
6656 2019-01-06  Tom Tromey  <tom@tromey.com>
6657
6658         PR gdb/28155:
6659         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6660         check_typedef.
6661         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6662         (print_return_value): Likewise.
6663
6664 2019-01-05  Tom Tromey  <tom@tromey.com>
6665
6666         * contrib/cleanup_check.py: Remove.
6667         * contrib/gcc-with-excheck: Remove.
6668         * contrib/exsummary.py: Remove.
6669         * contrib/excheck.py: Remove.
6670
6671 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6672
6673         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6674         NULL. Initialize tpprev to NULL instead of assigning it
6675         to NULL on the next statement.
6676         * windows-nat.c (windows_delete_thread): Remove check for
6677         main_thread_id before printing thread exit notifications.
6678         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6679         Remove thread ID check against main_thread_id.
6680         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6681         windows_delete_thread.
6682         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6683
6684 2019-01-04  Tom Tromey  <tom@tromey.com>
6685
6686         * compile/compile.c (_initialize_compile): Use upper case for
6687         metasyntactic variables.
6688         * symmisc.c (_initialize_symmisc): Use upper case for
6689         metasyntactic variables.
6690         * psymtab.c (_initialize_psymtab): Use upper case for
6691         metasyntactic variables.
6692         * demangle.c (demangle_command): Use upper case for metasyntactic
6693         variables.
6694         (_initialize_demangler): Likewise.
6695         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6696         variables.
6697
6698 2019-01-03  Tom Tromey  <tom@tromey.com>
6699
6700         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6701
6702 2019-01-03  Tom Tromey  <tom@tromey.com>
6703
6704         * python/py-symtab.c (salpy_str): Update.
6705         (struct salpy_sal_object) <symtab>: Now a PyObject.
6706         (salpy_dealloc): Update.
6707         (del_objfile_sal): Use gdbpy_ref.
6708
6709 2019-01-03  Tom Tromey  <tom@tromey.com>
6710
6711         * python/py-type.c (convert_field): Use new_reference.  Return
6712         gdbpy_ref.
6713         (make_fielditem): Return gdbpy_ref.
6714         (typy_fields): Update.
6715         (typy_getitem): Update.
6716         (field_name): Return gdbpy_ref.  Use new_reference.
6717         (typy_iterator_iternext): Update.
6718
6719 2019-01-03  Tom Tromey  <tom@tromey.com>
6720
6721         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6722
6723 2019-01-03  Tom Tromey  <tom@tromey.com>
6724
6725         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6726         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6727         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6728         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6729         (pspy_set_type_printers): Likewise.
6730         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6731         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6732         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6733         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6734         (objfpy_set_type_printers): Likewise.
6735
6736 2019-01-03  Tom Tromey  <tom@tromey.com>
6737
6738         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6739         (gdbpy_print_stack): Use gdbpy_err_fetch.
6740         * python/python-internal.h (class gdbpy_err_fetch): New class.
6741         (class gdbpy_enter) <m_error_type, m_error_value,
6742         m_error_traceback>: Remove.
6743         <m_error>: New member.
6744         (gdbpy_exception_to_string): Don't declare.
6745         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6746         * python/py-value.c (convert_value_from_python): Use
6747         gdbpy_err_fetch.
6748         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6749         gdbpy_exception_to_string.
6750         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6751         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6752         gdbpy_err_fetch.
6753
6754 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6755
6756         * linux-nat.c (delete_lwp_cleanup): Delete.
6757         (struct lwp_deleter): New struct.
6758         (lwp_info_up): New typedef.
6759         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6760         lwp_info_up.
6761
6762 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6763
6764         * linux-fork.c (class scoped_switch_fork_info): New class.
6765         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6766
6767 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6768
6769         * valops.c (find_overload_match): Remove use of null_cleanup, and
6770         calls to do_cleanups.
6771
6772 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6773
6774         * compile/compile-cplus-types.c
6775         (compile_cplus_instance::decl_name): Handle changes to
6776         cp_func_name.
6777         * cp-support.c (cp_func_name): Update header comment, update
6778         return type.
6779         * cp-support.h (cp_func_name): Update return type in declaration.
6780         * valops.c (find_overload_match): Move temp_func local to top
6781         level of function and change its type.  Use temp_func to hold and
6782         delete temporary string obtained from cp_func_name.
6783
6784 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6785
6786         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6787         gdb::char_vector, remove cleanup, and update uses of `msg`.
6788
6789 2019-01-03  Jim Wilson  <jimw@sifive.com>
6790
6791         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6792
6793 2019-01-02  Tom Tromey  <tom@tromey.com>
6794
6795         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6796         (tdesc_parse_xml): Remove cleanups.
6797         * target-descriptions.h (make_cleanup_free_target_description):
6798         Don't declare.
6799         (target_desc_deleter): New struct.
6800         (target_desc_up): New typedef.
6801         * target-descriptions.c (target_desc_deleter::operator()): Rename
6802         from free_target_description.
6803         (make_cleanup_free_target_description): Remove.
6804
6805 2019-01-02  Tom Tromey  <tom@tromey.com>
6806
6807         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6808         constructor, destructor.
6809         (linespec_parser): Remove typedef.
6810         (~linespec_parser): Rename from linespec_parser_delete.
6811         (linespec_lex_to_end, linespec_complete_label)
6812         (linespec_complete): Update.
6813         (decode_line_full): Remove cleanups.
6814         (decode_line_1): Update.
6815
6816 2019-01-02  Tom Tromey  <tom@tromey.com>
6817
6818         * python/python-internal.h (inferior_to_inferior_object): Change
6819         return type.
6820         * python/py-exitedevent.c (create_exited_event_object): Update.
6821         * python/py-inferior.c (inferior_to_inferior_object): Return
6822         gdbpy_ref.
6823         (python_new_inferior, python_inferior_deleted)
6824         (thread_to_thread_object, delete_thread_object)
6825         (build_inferior_list, gdbpy_selected_inferior): Update.
6826         * python/py-infthread.c (create_thread_object): Update.  Also fail
6827         if inferior_to_inferior_object fails.
6828
6829 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6830
6831         * inferior.h (class inferior) <displaced_step_state>: New field.
6832         * infrun.h (struct displaced_step_state): Move here from
6833         infrun.c.  Initialize fields, add constructor.
6834         <inf>: Remove field.
6835         <reset>: New method.
6836         * infrun.c (struct displaced_step_inferior_state): Move to
6837         infrun.h.
6838         (displaced_step_inferior_states): Remove.
6839         (get_displaced_stepping_state): Adust.
6840         (displaced_step_in_progress_any_inferior): Adjust.
6841         (displaced_step_in_progress_thread): Adjust.
6842         (displaced_step_in_progress): Adjust.
6843         (add_displaced_stepping_state): Remove.
6844         (get_displaced_step_closure_by_addr): Adjust.
6845         (remove_displaced_stepping_state): Remove.
6846         (infrun_inferior_exit): Call displaced_step_state.reset.
6847         (use_displaced_stepping): Don't check for NULL.
6848         (displaced_step_prepare_throw): Call
6849         get_displaced_stepping_state.
6850         (displaced_step_fixup): Don't check for NULL.
6851         (prepare_for_detach): Don't check for NULL.
6852
6853 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6854
6855         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6856          in case of call that did not complete.
6857
6858 2019-01-02  Andrey Utkin  <autkin@undo.io>
6859
6860         * symfile.c (find_separate_debug_file): Fix search of debug files for
6861         remote debuggee.
6862
6863 2019-01-02  Tom Tromey  <tom@tromey.com>
6864
6865         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6866         indentation.
6867         * python/py-frame.c (frapy_older): Remove cast.
6868         (frapy_newer): Likewise.
6869         * python/py-breakpoint.c (local_setattro): Remove cast.
6870         * python/py-arch.c (archpy_name): Remove local variable.
6871         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6872
6873 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6874
6875         * unittests/basic_string_view/element_access/char/empty.cc:
6876         Fix year range in copyright header.
6877
6878 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6879
6880         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6881         Delete.
6882         <operator==>: Update with for removed field.
6883         <hash>: Likewise.
6884         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6885         <isa_features>: ...this.
6886         <abi_features>: New field.
6887         (riscv_isa_flen): Update comment.
6888         (riscv_abi_xlen): New declaration.
6889         (riscv_abi_flen): New declaration.
6890         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6891         isa_features.
6892         (riscv_abi_xlen): New function.
6893         (riscv_isa_flen): Update to get answer from isa_features.
6894         (riscv_abi_flen): New function.
6895         (riscv_has_fp_abi): Update to get answer from abi_features.
6896         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6897         xlen and flen.
6898         (riscv_call_info) <xlen, flen>: Update comment.
6899         (riscv_call_arg_struct): Remove invalid assertions
6900         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6901         is removed.
6902         (riscv_gdbarch_init): Gather isa features and abi features
6903         separately, ensure both match on the gdbarch when reusing an old
6904         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6905         a target with 64-bit float hardware.
6906
6907 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6908
6909         * source.c (search_command_helper): Stop reverse search
6910         when line 1 has been searched.
6911
6912 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6913
6914         * record-full.c (record_full_base_target::close): Rewrite
6915         record_full_core_buf_list free logic.
6916
6917 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6918
6919         * break-catch-syscall.c (print_one_catch_syscall): xfree
6920         the last text.
6921
6922 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6923
6924         * top.c (print_gdb_version): Update Copyright year in version
6925         message.
6926
6927 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6928
6929         Update copyright year range in all GDB files.
6930
6931 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6932
6933         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6934
6935 For older changes see ChangeLog-2018.
6936 \f
6937 Local Variables:
6938 mode: change-log
6939 left-margin: 8
6940 fill-column: 74
6941 version-control: never
6942 coding: utf-8
6943 End:
6944