gdb/ChangeLog

   1 2019-05-04  Tom Tromey  <tom@tromey.com>
   2
   3         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
   4         Use gdb_assert_not_reached.
   5
   6 2019-05-04  Tom Tromey  <tom@tromey.com>
   7
   8         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
   9         "false".
  10
  11 2019-05-04  Tom Tromey  <tom@tromey.com>
  12
  13         * arc-tdep.c (arc_tdesc_init): Use bool.
  14
  15 2019-05-04  Tom Tromey  <tom@tromey.com>
  16
  17         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
  18
  19 2019-05-04  Tom Tromey  <tom@tromey.com>
  20
  21         * cli/cli-cmds.c (valid_command_p): Return bool.
  22
  23 2019-05-04  Tom Tromey  <tom@tromey.com>
  24
  25         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
  26         * command.h (valid_user_defined_cmd_name_p): Channge return type.
  27
  28 2019-05-04  Raul Tambre  <raul@tambre.ee>
  29
  30         * python/lib/gdb/prompt.py (_ExtendedPrompt)
  31         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
  32         operator for comparison.
  33
  34 2019-05-04  Tom Tromey  <tom@tromey.com>
  35
  36         * psymtab.c (psymbol_name_matches, match_partial_symbol)
  37         (lookup_partial_symbol, print_partial_symbols)
  38         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
  39         (psymbol_compare): Update.
  40         (add_psymbol_to_bcache): Clear the entire psymbol.
  41         (maintenance_check_psymtabs): Update.
  42         * psympriv.h (struct partial_symbol): Don't derive from
  43         general_symbol_info.
  44         <obj_section, unrelocated_address, address,
  45         set_unrelocated_address>: Update.
  46         <ginfo>: New member.
  47         * dwarf-index-write.c (write_psymbols, debug_names::insert)
  48         (debug_names::write_psymbols): Update.
  49
  50 2019-05-04  Tom de Vries  <tdevries@suse.de>
  51
  52         * contrib/cc-with-tweaks.sh: Support -n arg.
  53
  54 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  55
  56         * corelow.c (core_target::detach): Ensure frame cache and
  57         register caches are cleared.
  58         inferior.c (exit_inferior_1): Likewise.
  59
  60 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
  61             Tom Tromey  <tom@tromey.com>
  62
  63         * dictionary.c (collate_pending_symbols_by_language): Remove
  64         "struct" from foreach.
  65         * symtab.c (lookup_global_symbol_from_objfile)
  66         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
  67         foreach.
  68         * ser-tcp.c (net_open): Remove "struct" from foreach.
  69         * objfiles.c (objfile_relocate, objfile_rebase)
  70         (objfile_has_symbols): Remove "struct" from foreach.
  71         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
  72         from foreach.
  73         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
  74         foreach.
  75         * darwin-nat.c (thread_info_from_private_thread_info): Remove
  76         "struct" from foreach.
  77         * ada-lang.c (create_excep_cond_exprs)
  78         (ada_exception_catchpoint_cond_string): Remove "struct" from
  79         foreach.
  80
  81 2019-05-03  Tom Tromey  <tromey@adacore.com>
  82
  83         * ada-exp.y (convert_char_literal): Check suffix of each
  84         enumerator.
  85
  86 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
  87
  88         PR ada/21406:
  89         * ada-exp.y (yywrap): Don't define.
  90         * ada-lex.l (%option): Add noyywrap
  91         (yywrap): Remove.
  92
  93 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
  94
  95         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
  96         _WIN32_WINNT to the XP level, unless already defined to a higher
  97         level.
  98
  99         * unittests/parse-connection-spec-selftests.c:
 100         * ser-tcp.c:
 101         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 102         override.
 103
 104         * symfile.c (find_separate_debug_file): Remove colon from the
 105         drive spec of DOS/Windows file names of the target, so that the
 106         file name produced from DEBUGDIR and the target's directory will
 107         be valid on DOS/Windows systems.
 108
 109 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 110
 111         * rust-lang.c (val_print_struct): Handle printing structures
 112         containing strings.
 113
 114 2019-05-02  Tom Tromey  <tromey@adacore.com>
 115
 116         * valarith.c (_initialize_valarith): Remove.
 117
 118 2019-05-01  Tom Tromey  <tromey@adacore.com>
 119
 120         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 121         bitfields.
 122
 123 2019-05-01  Tom Tromey  <tromey@adacore.com>
 124
 125         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 126         for big-endian copies.
 127
 128 2019-04-30  Ali Tamur  <tamur@google.com>
 129         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 130         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 131         (read_3_bytes): New function.
 132
 133 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 134
 135         * windows-nat.c (main_thread_id): Delete.
 136         (handle_output_debug_string): Replace main_thread_id by
 137         current_event.dwThreadId.
 138         (fake_create_process): Likewise.
 139         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 140         Do not set main_thread_id.
 141         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 142         current_event.dwThreadId.
 143         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 144
 145 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 146
 147         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 148         Use current_event.dwThreadId instead of main_thread_id.
 149
 150 2019-04-30  Tom Tromey  <tromey@adacore.com>
 151
 152         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 153         (create_excep_cond_exprs): Iterate over program spaces.
 154         (ada_exception_catchpoint_cond_string): Examine all minimal
 155         symbols for exception types.
 156
 157 2019-04-30  Tom Tromey  <tromey@adacore.com>
 158
 159         PR c++/24470:
 160         * dwarf2read.c (process_structure_scope): Handle case where type
 161         has template parameters but no symbol was created.
 162
 163 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 164             Chris January  <chris.january@arm.com>
 165
 166         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 167         qualifier.
 168         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 169
 170 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 171
 172         * f-typeprint.c (f_print_type): Update rules for printing
 173         whitespace.
 174         (f_type_print_varspec_suffix): Likewise.
 175
 176 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 177             Chris January  <chris.january@arm.com>
 178
 179         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 180         function arguments.
 181
 182 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 183
 184         * f-lang.c (build_fortran_types): Change name of void type to
 185         lower case.
 186         * f-typeprint.c (f_type_print_base): Print the name of the void
 187         type, rather than a fixed string.
 188         * f-valprint.c (f_decorations): Use lower case void string.
 189
 190 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 191             Chris January  <chris.january@arm.com>
 192
 193         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 194         types for Fortran.
 195
 196 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 197             Chris January  <chris.january@arm.com>
 198             David Lecomber  <david.lecomber@arm.com>
 199
 200         * f-exp.y (BINOP_INTRINSIC): New token.
 201         (exp): New parser rule handling BINOP_INTRINSIC.
 202         (f77_keywords): Add new builtin procedures.
 203         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 204         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 205         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 206         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 207         (print_unop_subexp_f): New function.
 208         (print_binop_subexp_f): New function.
 209         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 210         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 211         (dump_subexp_body_f): Likewise.
 212         (operator_check_f): Likewise.
 213         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 214         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 215
 216 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 217
 218         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 219         UNOP_KIND.
 220         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 221         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 222         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 223         (operator_length_f): New fuction.
 224         (print_subexp_f): New function.
 225         (op_name_f): New function.
 226         (dump_subexp_body_f): New function.
 227         (operator_check_f): New function.
 228         (exp_descriptor_f): Replace standard expression handling functions
 229         with new functions.
 230         * gdb/fortran-operator.def: New file.
 231         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 232         * gdb/std-operator.def: Remove UNOP_KIND.
 233
 234 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 235
 236         * std-operator.def: Remove unbalanced, stray double quote
 237         character.
 238
 239 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 240             Chris January  <chris.january@arm.com>
 241             Daniel Everett  <daniel.everett@arm.com>
 242             Nick Forrington  <nick.forrington@arm.com>
 243             Richard Bunt  <richard.bunt@arm.com>
 244
 245         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 246         of depth when printing anonymous structs or unions.
 247         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 248         Don't print either the top-level value, or the children if the
 249         max-depth is exceeded.
 250         (ppscm_print_children): When printing the key of a map, allow one
 251         extra level of depth.
 252         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 253         print either the top-level value, or the children if the max-depth
 254         is exceeded.
 255         (print_children): When printing the key of a map, allow one extra
 256         level of depth.
 257         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 258         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 259         (user_print_options): Initialise max_depth field.
 260         (val_print_scalar_or_string_type_p): New function.
 261         (val_print): Check to see if the max depth has been reached.
 262         (val_print_check_max_depth): Define new function.
 263         (show_print_max_depth): New function.
 264         (_initialize_valprint): Add 'print max-depth' option.
 265         * valprint.h (struct value_print_options) <max_depth>: New field.
 266         (val_print_check_max_depth): Declare new function.
 267         * NEWS: Document new feature.
 268
 269 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 270
 271         * ada-lang.c (ada_language_defn): Initialise new field.
 272         * c-lang.c (c_is_string_type_p): New function.
 273         (c_language_defn): Initialise new field.
 274         (cplus_language_defn): Initialise new field.
 275         (asm_language_defn): Initialise new field.
 276         (minimal_language_defn): Initialise new field.
 277         * c-lang.h (c_is_string_type_p): Declare new function.
 278         * d-lang.c (d_language_defn): Initialise new field.
 279         * f-lang.c (f_is_string_type_p): New function.
 280         (f_language_defn): Initialise new field.
 281         * go-lang.c (go_is_string_type_p): New function.
 282         (go_language_defn): Initialise new field.
 283         * language.c (default_is_string_type_p): New function.
 284         (unknown_language_defn): Initialise new field.
 285         (auto_language_defn): Initialise new field.
 286         * language.h (struct language_defn) <la_is_string_type_p>: New
 287         member variable.
 288         (default_is_string_type_p): Declare new function.
 289         * m2-lang.c (m2_language_defn): Initialise new field.
 290         * objc-lang.c (objc_language_defn): Initialise new field.
 291         * opencl-lang.c (opencl_language_defn): Initialise new field.
 292         * p-lang.c (pascal_is_string_type_p): New function.
 293         (pascal_language_defn): Initialise new field.
 294         * rust-lang.c (rust_is_string_type_p): New function.
 295         (rust_language_defn): Initialise new field.
 296
 297 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 298
 299         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 300         New field.
 301         * ada-lang.c (ada_language_defn): Initialise new field.
 302         * c-lang.c (c_language_defn): Likewise.
 303         (cplus_language_defn): Likewise.
 304         (asm_language_defn): Likewise.
 305         (minimal_language_defn): Likewise.
 306         * d-lang.c (d_language_defn): Likewise.
 307         * f-lang.c (f_language_defn): Likewise.
 308         * go-lang.c (go_language_defn): Likewise.
 309         * language.c (unknown_language_defn): Likewise.
 310         (auto_language_defn): Likewise.
 311         * m2-lang.c (m2_language_defn): Likewise.
 312         * objc-lang.c (objc_language_defn): Likewise.
 313         * opencl-lang.c (opencl_language_defn): Likewise.
 314         * p-lang.c (pascal_language_defn): Likewise.
 315         * rust-lang.c (rust_language_defn): Likewise.
 316
 317 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 318
 319         * ada-lang.c (ada_is_character_type): Change return type to bool.
 320         (ada_is_string_type): Likewise.
 321         * ada-lang.h (ada_is_character_type): Update declaration
 322         (ada_is_string_type): Likewise.
 323
 324 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 325
 326         Support style in 'frame|thread apply'
 327
 328         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 329         * record.c (record_start, record_stop): Update callers of
 330         execute_command_to_string with false.
 331         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 332         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 333         methods.
 334         (class string_file): New constructor with term_out parameter.
 335         Override methods term_out and can_emit_style_escape.  New member
 336         term_out.
 337         (class stdio_file): Override can_emit_style_escape.
 338         (class tee_file): Override term_out and can_emit_style_escape.
 339         * utils.h (can_emit_style_escape): Remove.
 340         * utils.c (can_emit_style_escape): Likewise.
 341         Update all callers of can_emit_style_escape (SOMESTREAM) to
 342         SOMESTREAM->can_emit_style_escape.
 343         * source-cache.c (source_cache::get_source_lines): Likewise.
 344         * stack.c (frame_apply_command_count): Call execute_command_to_string
 345         passing the term_out characteristic of the current gdb_stdout.
 346         * thread.c (thr_try_catch_cmd): Likewise.
 347         * top.c (execute_command_to_string): pass term_out parameter
 348         to construct the string_file for the command output.
 349         * ui-file.c (term_cli_styling): New function (most code moved
 350         from utils.c can_emit_style_escape).
 351         (string_file::string_file, string_file::can_emit_style_escape,
 352         stdio_file::can_emit_style_escape, tee_file::term_out,
 353         tee_file::can_emit_style_escape): New functions.
 354
 355 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 356
 357         * NEWS: Mention the new set|show may-call-functions.
 358         * infcall.c (may_call_functions_p): New variable.
 359         (show_may_call_functions_p): New function.
 360         (call_function_by_hand_dummy): Throws an error if not
 361         may-call-functions.
 362         (_initialize_infcall): Call add_setshow_boolean_cmd for
 363         may-call-functions.
 364
 365 2019-04-25  Keith Seitz  <keiths@redhat.com>
 366
 367         PR c++/24367
 368         * cp-support.c (inspect_type): Don't attempt substitutions
 369         of symbol with the same name.
 370
 371 2019-04-25  Tom Tromey  <tromey@adacore.com>
 372
 373         PR gdb/24475:
 374         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 375         static.
 376
 377 2019-04-25  Tom Tromey  <tromey@adacore.com>
 378
 379         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 380         rvalue reference.
 381         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 382         (gdb_xml_parser::parse): Use std::move.
 383         * python/python-internal.h (gdbpy_convert_exception): Take a const
 384         reference.
 385         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 386         std::move.
 387         * python/py-utils.c (gdbpy_convert_exception): Take a const
 388         reference.
 389         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 390         Use std::move.
 391         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 392         Use std::move.
 393         * mi/mi-main.c (mi_print_exception): Take a const reference.
 394         * main.c (handle_command_errors): Take a const reference.
 395         * linespec.c (parse_linespec): Use std::move.
 396         * infcall.c (run_inferior_call): Use std::move.
 397         (call_function_by_hand_dummy): Use std::move.
 398         * exec.c (try_open_exec_file): Use std::move.
 399         * exceptions.h (exception_print, exception_fprintf)
 400         (exception_print_same): Update.
 401         * exceptions.c (print_exception, exception_print)
 402         (exception_fprintf, exception_print_same): Change parameters to
 403         const reference.
 404         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 405         * common/new-op.c: Use std::move.
 406         * common/common-exceptions.h (struct gdb_exception): Add move
 407         constructor.
 408         (struct gdb_exception_error, struct gdb_exception_quit, struct
 409         gdb_quit_bad_alloc): Change constructor to move constructor.
 410         (throw_exception): Change parameter to rvalue reference.
 411         * common/common-exceptions.c (throw_exception): Take rvalue
 412         reference.
 413         * cli/cli-interp.c (safe_execute_command): Use std::move.
 414         * breakpoint.c (insert_bp_location, location_to_sals): Use
 415         std::move.
 416
 417 2019-04-25  Tom Tromey  <tromey@adacore.com>
 418
 419         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 420         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 421         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 422         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 423         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 424         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 425         guile/scm-value.c: Use unpack.
 426         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 427         gdbscm_gdb_exception.
 428         (gdbscm_throw_gdb_exception): Likewise.
 429         (struct gdbscm_gdb_exception): New.
 430         (unpack): New function.
 431         (gdbscm_wrap): Use unpack.
 432
 433 2019-04-25  Tom Tromey  <tromey@adacore.com>
 434
 435         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 436         (gdb_rl_callback_handler): Use std::move.
 437         * common/common-exceptions.h (struct gdb_exception): Add move
 438         assignment operator.
 439         (throw_exception_sjlj): Change "exception" to const reference.
 440         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 441         (throw_exception_sjlj): Change "exception" to const reference.
 442
 443 2019-04-25  Tom Tromey  <tromey@adacore.com>
 444
 445         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 446         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 447         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 448         Update.
 449         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 450         Update.
 451         * mi/mi-interp.c (mi_interp::exec): Update.
 452         * linespec.c (parse_linespec): Update.
 453         * infcall.c (run_inferior_call): Update.
 454         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 455         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 456         (gdbscm_lookup_global_symbol): Update.
 457         * guile/scm-param.c (gdbscm_parameter_value): Update.
 458         * guile/scm-frame.c (gdbscm_frame_read_register)
 459         (gdbscm_frame_read_var): Update.
 460         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 461         * exec.c (try_open_exec_file): Update.
 462         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 463         (gdb_rl_callback_handler): Update.
 464         * common/common-exceptions.h (exception_none): Don't declare.
 465         * common/common-exceptions.c (exception_none): Don't define.
 466         (struct catcher) <exception>: Update.
 467         * cli/cli-interp.c (safe_execute_command): Update.
 468         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 469
 470 2019-04-25  Ali Tamur  <tamur@google.com>
 471
 472         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 473         (read_attribute_value): Likewise.
 474         (dwarf2_read_addr_index): Update comment.
 475         (read_str_index): Add DW_FORM_strx.
 476         (dwarf2_string_attr): Likewise.
 477         (dwarf2_const_value_attr): Likewise.
 478         (dump_die_shallow): Likewise.
 479         (dwarf2_fetch_constant_bytes): Likewise.
 480         (skip_form_bytes): Likewise.
 481         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 482
 483 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 484
 485         PR corefiles/11608
 486         PR corefiles/18187
 487         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 488         OFFSET.  Verify if current mapping contains an ELF header.
 489         (linux_find_memory_regions_full): Adjust call to
 490         dump_mapping_p.
 491
 492 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 493             Kang Li <kanglictf@gmail.com>
 494
 495         PR gdb/21600
 496
 497         * dwarf2-frame.c (read_initial_length): Be consistent about using
 498         unsigned representation of length.
 499         (decode_frame_entry_1): Likewise.  Check for wraparound of
 500         end pointer as well as buffer overflow.
 501
 502 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 503
 504         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 505         "vq".
 506
 507 2019-04-24  Tom Tromey  <tromey@adacore.com>
 508
 509         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 510
 511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 512
 513         * s12z-tdep.c (s12z_unwind_pc): Delete.
 514         (s12z_unwind_sp): Delete.
 515         (s12z_gdbarch_init): Don't register deleted functions with
 516         gdbarch.
 517
 518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 519
 520         * rl78-tdep.c (rl78_unwind_sp): Delete.
 521         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 522
 523 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 524
 525         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 526         (xstormy16_unwind_pc): Delete.
 527         (xstormy16_dummy_id): Delete.
 528         (xstormy16_gdbarch_init): Don't register deleted functions with
 529         gdbarch.
 530
 531 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 532
 533         * vax-tdep.c (vax_unwind_pc): Delete.
 534         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 535
 536 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 537
 538         * v850-tdep.c (v850_unwind_sp): Delete.
 539         (v850_unwind_pc): Delete.
 540         (v850_dummy_id): Delete.
 541         (v850_gdbarch_init): Don't register deleted functions with
 542         gdbarch.
 543
 544 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 545
 546         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 547         (tilegx_unwind_pc): Delete.
 548         (tilegx_unwind_dummy_id): Delete.
 549         (tilegx_gdbarch_init): Don't register deleted functions with
 550         gdbarch.
 551
 552 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 553
 554         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 555         (tic6x_dummy_id): Delete.
 556         (tic6x_gdbarch_init): Don't register deleted functions with
 557         gdbarch.
 558
 559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 560
 561         * sparc-tdep.c (sparc_unwind_pc): Delete.
 562         (sparc32_gdbarch_init): Don't register deleted function with
 563         gdbarch.
 564
 565 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 566
 567         * sh-tdep.c (sh_unwind_sp): Delete.
 568         (sh_unwind_pc): Delete.
 569         (sh_dummy_id): Delete.
 570         (sh_gdbarch_init): Don't register deleted functions with
 571         gdbarch.
 572
 573 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 574
 575         * score-tdep.c (score_unwind_sp): Delete.
 576         (score_unwind_pc): Delete.
 577         (score_dummy_id): Delete.
 578         (score_gdbarch_init): Don't register deleted functions with
 579         gdbarch.
 580
 581 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 582
 583         * rx-tdep.c (rx_unwind_pc): Delete.
 584         (rx_unwind_sp): Delete.
 585         (rx_dummy_id): Delete.
 586         (rx_gdbarch_init): Don't register deleted functions with
 587         gdbarch.  Update comment.
 588
 589 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 590
 591         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 592         (rs6000_dummy_id): Delete.
 593         (rs6000_gdbarch_init): Don't register deleted functions with
 594         gdbarch.
 595
 596 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 597
 598         * or1k-tdep.c (or1k_dummy_id): Delete.
 599         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 600
 601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 602
 603         * nios2-tdep.c (nios2_dummy_id): Delete.
 604         (nios2_unwind_sp): Delete.
 605         (nios2_gdbarch_init): Don't register deleted functions with
 606         gdbarch.
 607
 608 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 609
 610         * nds32-tdep.c (nds32_dummy_id): Delete.
 611         (nds32_unwind_pc): Delete.
 612         (nds32_unwind_sp): Delete.
 613         (nds32_gdbarch_init): Don't register deleted functions with
 614         gdbarch.
 615
 616 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 617
 618         * msp430-tdep.c (msp430_unwind_pc): Delete.
 619         (msp430_unwind_sp): Delete.
 620         (msp430_dummy_id): Delete.
 621         (msp430_gdbarch_init): Don't register deleted functions with
 622         gdbarch.
 623
 624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 625
 626         * moxie-tdep.c (moxie_unwind_sp): Delete.
 627         (moxie_unwind_pc): Delete.
 628         (moxie_dummy_id): Delete.
 629         (moxie_gdbarch_init): Don't register deleted functions with
 630         gdbarch.
 631
 632 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 633
 634         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 635         (mn10300_unwind_pc): Delete.
 636         (mn10300_unwind_sp): Delete.
 637         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 638         mn10300_unwind_sp.
 639         (mn10300_frame_unwind_init): Don't register deleted functions with
 640         gdbarch.
 641
 642 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 643
 644         * mep-tdep.c (mep_unwind_pc): Delete.
 645         (mep_unwind_sp): Delete.
 646         (mep_dummy_id): Delete.
 647         (mep_gdbarch_init): Don't register deleted functions with
 648         gdbarch.
 649
 650 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 651
 652         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 653         (m68hc11_unwind_sp): Delete.
 654         (m68hc11_gdbarch_init): Don't register deleted functions with
 655         gdbarch.
 656
 657 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 658
 659         * m32r-tdep.c (m32r_unwind_sp): Delete.
 660         (m32r_unwind_pc): Delete.
 661         (m32r_dummy_id): Delete.
 662         (m32r_gdbarch_init): Don't register deleted functions with
 663         gdbarch.
 664
 665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 666
 667         * m32c-tdep.c (m32c_unwind_pc): Delete.
 668         (m32c_unwind_sp): Delete.
 669         (m32c_dummy_id): Delete.
 670         (m32c_gdbarch_init): Don't register deleted functions with
 671         gdbarch.
 672
 673 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 674
 675         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 676         (lm32_unwind_pc): Delete.
 677         (lm32_dummy_id): Delete.
 678         (lm32_gdbarch_init): Don't register deleted functions with
 679         gdbarch.
 680
 681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 682
 683         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 684         (iq2000_unwind_pc): Delete.
 685         (iq2000_dummy_id): Delete.
 686         (iq2000_gdbarch_init): Don't register deleted functions with
 687         gdbarch.
 688
 689 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 690
 691         * nds32-tdep.c (nds32_type_align): Delete.
 692         (nds32_push_dummy_call): Use type_align instead.
 693
 694 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 695
 696         * arm-tdep.c (arm_type_align): Only handle vector override case.
 697         (arm_push_dummy_call): Use type_align.
 698         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 699
 700 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 701
 702         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 703         case.
 704         (pass_on_stack): Use type_align.
 705         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 706         function.
 707
 708 2019-04-23  Tom Tromey  <tromey@adacore.com>
 709
 710         * dwarf2read.c (line_header::file_name_at): Remove unused
 711         overload.
 712
 713 2019-04-23  Tom de Vries  <tdevries@suse.de>
 714
 715         PR gdb/24438
 716         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 717         invocation.
 718
 719
 720 2019-03-27  Ali Tamur  <tamur@google.com>
 721
 722         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 723         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 724         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 725         (dwarf_expr_context::get_addr_index): Likewise
 726         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 727         (symbol_needs_eval_context::get_addr_index): Likewise
 728         (disassemble_dwarf_expression): Add DW_OP_addrx
 729         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 730         (read_cutu_die_from_dwo): Update comment
 731         (skip_one_die): Add DW_FORM_addrx
 732         (read_attribute_value): Likewise
 733         (var_decode_location): Add DW_OP_addrx
 734         (dwarf2_const_value_attr): Add DW_FORM_addrx
 735         (dump_die_shallow): Likewise
 736         (dwarf2_fetch_constant_bytes): Likewise
 737         (decode_locdesc): Add DW_OP_addrx
 738         (skip_form_bytes): Add DW_FORM_addrx
 739
 740 2019-04-22  Ali Tamur  <tamur@google.com>
 741
 742         * MAINTAINERS (Write After Approval): Add self.
 743
 744 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 745
 746         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 747         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 748         (open_symbol_file_object): Likewise.
 749         (svr4_default_sos): Add info parameter.
 750         (svr4_read_so_list): Likewise.
 751         (svr4_current_sos_direct): Adjust functions calls to pass down
 752         info.
 753         (svr4_current_sos_1): Add info parameter.
 754         (svr4_current_sos): Call get_svr4_info, pass info down to
 755         svr4_current_sos_1.
 756         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 757         get_svr4_info.
 758         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 759         get_svr4_info.
 760         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 761         to get_svr4_info.
 762         (probes_table_remove_objfile_probes): Likewise.
 763         (register_solib_event_probe): Add info parameter.
 764         (solist_update_incremental): Pass info parameter down to
 765         svr4_read_so_list.
 766         (disable_probes_interface): Add info parameter.
 767         (svr4_handle_solib_event): Pass current_program_space to
 768         get_svr4_info.  Adjust disable_probes_interface cleanup.
 769         (svr4_create_probe_breakpoints): Add info parameter, pass it
 770         down to register_solib_event_probe.
 771         (svr4_create_solib_event_breakpoints): Add info parameter,
 772         pass it down to svr4_create_probe_breakpoints.
 773         (enable_break): Pass info down to
 774         svr4_create_solib_event_breakpoints.
 775         (svr4_solib_create_inferior_hook): Pass current_program_space to
 776         get_svr4_info.
 777         (svr4_clear_solib): Likewise.
 778
 779 2019-04-22  Pedro Alves  <palves@redhat.com>
 780
 781         * solib-svr4.c (svr4_free_objfile_observer): New.
 782         (probe_and_action::objfile): New field.
 783         (probes_table_htab_remove_objfile_probes)
 784         (probes_table_remove_objfile_probes): New functions.
 785         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 786         in the new probe_and_action.  Don't store the probe in 'lookup'.
 787         (svr4_create_probe_breakpoints): Pass objfile to
 788         register_solib_event_probe.
 789         (_initialize_svr4_solib): Register a free_objfile observer.
 790
 791 2019-04-19  Tom Tromey  <tom@tromey.com>
 792
 793         * common/queue.h: Remove.
 794
 795 2019-04-19  Tom Tromey  <tom@tromey.com>
 796
 797         * event-loop.c: Don't include "common/queue.h".
 798
 799 2019-04-19  Tom Tromey  <tom@tromey.com>
 800
 801         * remote.c (remote_target): Use delete.
 802         * remote-notif.h: Include <list>, not "common/queue.h".
 803         (notif_client_p): Remove typedef.
 804         (remote_notif_state): Add constructor, destructor, initializer.
 805         <notif_queue>: Now a std::list.
 806         (remote_notif_state_xfree): Don't declare.
 807         * remote-notif.c (remote_notif_process, handle_notification)
 808         (remote_notif_state_allocate): Update.
 809         (~remote_notif_state): Rename from remote_notif_state_xfree.
 810
 811 2019-04-19  Tom Tromey  <tom@tromey.com>
 812
 813         * symfile.c (reread_symbols): Update.
 814         * objfiles.c (objfile_register_static_link)
 815         (objfile_lookup_static_link): Update
 816         (~objfile) Don't delete static_links.
 817         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 818
 819 2019-04-19  Tom Tromey  <tom@tromey.com>
 820
 821         * type-stack.h (struct type_stack) <insert>: Constify string.
 822         * type-stack.c (type_stack::insert): Constify string.
 823         * gdbtypes.h (lookup_template_type): Update.
 824         (address_space_name_to_int): Update.
 825         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 826         const.
 827         (lookup_template_type): Make name const.
 828         * c-exp.y: Update rules.
 829         (lex_one_token, classify_name, classify_inner_name)
 830         (c_print_token): Update.
 831         * p-exp.y: Update rules.
 832         (yylex): Update.
 833         * f-exp.y: Update rules.
 834         (yylex): Update.
 835         * d-exp.y: Update rules.
 836         (lex_one_token, classify_name, classify_inner_name): Update.
 837         * parse.c (write_dollar_variable, copy_name): Return std::string.
 838         * parser-defs.h (copy_name): Change return type.
 839         * m2-exp.y: Update rules.
 840         (yylex): Update.
 841         * go-exp.y (lex_one_token): Update.
 842         Update rules.
 843         (classify_unsafe_function, classify_packaged_name)
 844         (classify_name, yylex): Update.
 845
 846 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 847
 848         * configure.ac: add --enable-source-highlight switch.
 849         * configure: Regenerate.
 850         * top.c (print_gdb_version): plumb --enable-source-highlight
 851         status to "show configuration".
 852
 853 2019-04-19  Tom Tromey  <tromey@adacore.com>
 854
 855         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 856         Check ADA_TYPE_P.
 857         (empty_record, ada_template_to_fixed_record_type_1)
 858         (template_to_static_fixed_type)
 859         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 860         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 861         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 862         macros.
 863
 864 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 865
 866         PR symtab/24423:
 867         * source.c (print_source_lines_base): Advance "iter" when a
 868         control character is seen.
 869
 870 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 871
 872         * inferior.h (struct infcall_suspend_state_deleter):
 873         Catch exception in destructor to avoid crash.
 874
 875 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 876
 877         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 878         close to the add_com "shell".
 879
 880 2019-04-18  Tom Tromey  <tromey@adacore.com>
 881
 882         * process-stratum-target.h (class process_stratum_target)
 883         <stratum>: Add "final".
 884
 885 2019-04-17  Tom Tromey  <tromey@adacore.com>
 886
 887         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 888         against nullptr before use.
 889
 890 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 891
 892         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 893
 894 2019-04-17  Jim Wilson  <jimw@sifive.com>
 895             Andrew Burgess  <andrew.burgess@embecosm.com>
 896
 897         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 898         code read might fail, assume 4-byte breakpoint in that case.
 899
 900 2019-04-15  Leszek Swirski  <leszeks@google.com>
 901
 902         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 903         rather than a hand-rolled POD check when checking for forced MEMORY
 904         classification.
 905
 906 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 907
 908         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 909         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 910         function.
 911         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 912         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 913         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 914         declaration.
 915
 916 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 917
 918         * aarch64-linux-nat.c
 919         (aarch64_linux_nat_target::thread_architecture): Add override.
 920         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 921         each VQ.
 922
 923 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 924
 925         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 926
 927 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 928
 929         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 930         target types of size 96-bits, add some additional comments, and
 931         check that the builtin type we found was the correct size.
 932
 933 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 934
 935         * utils.c (prompt_for_continue): Don't restore the styling at the
 936         end, as applied_style has the wrong value.  This fixes styling in
 937         long lists of file names that are interrupted by the "Continue?"
 938         prompt.
 939
 940 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 941
 942         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 943         * c-lang.c (c_language_defn): Likewise.
 944         (cplus_language_defn): Likewise.
 945         (asm_language_defn): Likewise.
 946         (minimal_language_defn): Likewise.
 947         * d-lang.c (d_language_defn): Likewise.
 948         * f-lang.c (f_language_defn): Likewise.
 949         * go-lang.c (go_language_defn): Likewise.
 950         * language.c (unknown_language_defn): Likewise.
 951         (auto_language_defn): Likewise.
 952         * language.h (struct language_defn): Remove la_magic field.
 953         (LANG_MAGIC): Delete.
 954         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 955         * objc-lang.c (objc_language_defn): Likewise.
 956         * opencl-lang.c (opencl_language_defn): Likewise.
 957         * p-lang.c (pascal_language_defn): Likewise.
 958         * rust-lang.c (rust_language_defn): Likewise.
 959
 960 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 961
 962         * riscv-tdep.c (riscv_type_align): New function.
 963         (riscv_type_alignment): Delete.
 964         (riscv_arg_location): Use 'type_align'.
 965         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 966
 967 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 968
 969         * gdbtypes.c (type_align): A struct with no non-static fields also
 970         has alignment of 1.
 971
 972 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 973
 974         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 975         component to 0.
 976         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 977         member.
 978         (riscv_struct_info::analyse): New implementation using new
 979         analyse_inner member function.
 980         (riscv_struct_info::field_offset): New member function.
 981         (riscv_struct_info::m_offsets): New member variable.
 982         (riscv_struct_info::analyse_inner): New private member function,
 983         takes the old implementation of riscv_struct_info::analyse but
 984         extended to track field offsets.
 985         (riscv_call_arg_struct): Update the struct folding special cases
 986         to handle cases where empty C++ structs, which are non-zero
 987         length, are found.
 988         (riscv_arg_location): Initialise the length of each location, a
 989         non-zero length now indicates the location is in use.
 990         (riscv_push_dummy_call): Allow for the first location having a
 991         non-zero offset when setting up arguments.
 992         (riscv_return_value): Likewise, but for return values.
 993
 994 2019-04-11  Tom Tromey  <tromey@adacore.com>
 995
 996         * utils.c (internal_vproblem): Make "msg" const.
 997
 998 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 999
1000         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1001         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1002         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1003         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1004
1005 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1006
1007         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1008         function.
1009         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1010         of amd64_collect_native_gregset.
1011         (amd64_linux_nat_target::store_registers): Likewise.
1012
1013 2019-04-10  Tom Tromey  <tom@tromey.com>
1014
1015         * symtab.c (lookup_global_symbol_from_objfile)
1016         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1017         * objfiles.h (class separate_debug_iterator): New.
1018         (class separate_debug_range): New.
1019         (struct objfile) <separate_debug_objfiles>: New method.
1020         (objfile_separate_debug_iterate): Don't declare.
1021         * objfiles.c (separate_debug_iterator::operator++): Rename from
1022         objfile_separate_debug_iterate.
1023         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1024         iterator.
1025         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1026         iterator.
1027
1028 2019-04-10  Tom Tromey  <tom@tromey.com>
1029
1030         * symfile.c (reread_symbols): Remove old comment.
1031         * objfiles.c (free_all_objfiles): Fix a typo.
1032
1033 2019-04-10  Tom Tromey  <tom@tromey.com>
1034
1035         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1036         * minsyms.c (lookup_minimal_symbol): Use foreach.
1037         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1038         (lookup_minimal_symbol_solib_trampoline): Likewise.
1039         * symfile.c (reread_symbols): Use foreach.
1040
1041 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1042             Tom Tromey  <tromey@adacore.com>
1043
1044         PR rust/24414:
1045         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1046         (rust_lex_int_test): Change "value" to be LONGEST.
1047         (rust_lex_tests): Add test for long integer literal.
1048
1049 2019-04-09  Tom Tromey  <tromey@adacore.com>
1050
1051         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1052         to bool.
1053         (extended_remote_target::attach): Update.
1054         (remote_target::remote_notice_new_inferior): Update.
1055         (remote_target::add_current_inferior_and_thread): Update.
1056         * inferior.c (exit_inferior_1): Use "false".
1057         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1058
1059 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1060
1061         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1062         the "start" command.
1063
1064 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1065
1066         * python/py-inferior.c (infpy_thread_from_thread_handle):
1067         Adjust comments to reflect renaming of thread_from_thread_handle
1068         to thread_from_handle.  Adjust keywords.  Fix type error message.
1069         (inferior_object_methods): Add thread_from_handle.  Retain
1070         thread_from_thread_handle, but mark it as deprecated.
1071
1072 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1073
1074         * gdbthread.h (find_thread_by_handle): Revise declaration.
1075         * thread.c (find_thread_by_handle): Likewise.  Adjust
1076         implementation too.
1077         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1078         support for buffer objects as handles.
1079
1080 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1081
1082         * python/py-infthread.c (thpy_thread_handle): New function.
1083         (thread_object_methods): Register thpy_thread_handle.
1084
1085 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1086
1087         * gdbthread.h (thread_to_thread_handle): Declare.
1088         * thread.c (gdbtypes.h): Include.
1089         (thread_to_thread_handle): New function.
1090
1091         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1092         (target_thread_info_to_thread_handle): Declare.
1093         * target.c (target_thread_info_to_thread_handle): New function.
1094         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1095         * target-delegates.c: Regenerate.
1096
1097         * linux-thread-db.c (class thread_db_target): Add method
1098         thread_info_to_thread_handle.
1099         (thread_db_target::thread_info_to_thread_handle): Define.
1100         * remote.c (class remote_target): Add new method
1101         thread_info_to_thread_handle.
1102         (remote_target::thread_info_to_thread_handle): Define.
1103
1104 2019-04-08  Pedro Alves  <palves@redhat.com>
1105
1106         * common/common-exceptions.c (throw_exception): Don't create
1107         named object to throw; throw directly.
1108         (throw_it): Likewise.  Don't initialize gdb_exception::message
1109         here, with new; pass FMT and AP to the ctor instead.
1110         * common/common-exceptions.h: Include <string>.
1111         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1112         const char *, va_list)): New ctor.  Use std::make_shared.
1113         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1114         errors)): Delete.
1115         (gdb_exception_error::gdb_exception_error(enum errors, const char
1116         *, va_list)): New.
1117         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1118         Add assertion.
1119         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1120         errors)): Delete.
1121         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1122         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1123         Add assertion.
1124
1125 2019-04-08  Tom Tromey  <tom@tromey.com>
1126
1127         * valops.c (value_rtti_indirect_type): Replace throw_exception
1128         with throw.
1129         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1130         with throw.
1131         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1132         throw.
1133         * target.c (target_translate_tls_address): Replace throw_exception
1134         with throw.
1135         * stack.c (frame_apply_command_count): Replace throw_exception
1136         with throw.
1137         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1138         throw.
1139         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1140         with throw.
1141         * rs6000-tdep.c (rs6000_frame_cache)
1142         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1143         * remote.c: Replace throw_exception with throw.
1144         * record-full.c (record_full_message, record_full_wait_1)
1145         (record_full_restore): Replace throw_exception with throw.
1146         * record-btrace.c:
1147         (get_thread_current_frame_id, record_btrace_start_replaying)
1148         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1149         (cmd_record_btrace_start): Replace throw_exception with throw.
1150         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1151         throw.
1152         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1153         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1154         * linespec.c:
1155         (find_linespec_symbols): Replace throw_exception with throw.
1156         * infrun.c (displaced_step_prepare, resume): Replace
1157         throw_exception with throw.
1158         * infcmd.c (post_create_inferior): Replace throw_exception with
1159         throw.
1160         * inf-loop.c (inferior_event_handler): Replace throw_exception
1161         with throw.
1162         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1163         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1164         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1165         (get_prev_frame_always, get_frame_pc_if_available)
1166         (get_frame_address_in_block_if_available, get_frame_language):
1167         Replace throw_exception with throw.
1168         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1169         throw_exception with throw.
1170         * eval.c (fetch_subexp_value, evaluate_var_value)
1171         (evaluate_funcall, evaluate_subexp_standard): Replace
1172         throw_exception with throw.
1173         * dwarf2loc.c (call_site_find_chain)
1174         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1175         Replace throw_exception with throw.
1176         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1177         with throw.
1178         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1179         throw.
1180         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1181         * completer.c (complete_line_internal): Replace throw_exception
1182         with throw.
1183         * compile/compile-object-run.c (compile_object_run): Replace
1184         throw_exception with throw.
1185         * cli/cli-script.c (process_next_line): Replace throw_exception
1186         with throw.
1187         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1188         (btrace_enable, btrace_maint_update_pt_packets): Replace
1189         throw_exception with throw.
1190         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1191         throw_exception with throw.
1192         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1193         throw_exception with throw.
1194         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1195         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1196         * aarch64-tdep.c (aarch64_make_prologue_cache)
1197         (aarch64_make_stub_cache): Replace throw_exception with throw.
1198
1199 2019-04-08  Tom Tromey  <tom@tromey.com>
1200
1201         * common/common-exceptions.c (throw_exception): Rename from
1202         throw_exception_cxx.  Remove old copy.  Make argument const.
1203         (throw_it): Create and throw exception objects directly.
1204         * common/common-exceptions.h (throw_exception): Make argument
1205         const.
1206         (struct gdb_exception_error): Add constructor.
1207         (struct gdb_exception_quit): Add constructor.
1208
1209 2019-04-08  Tom Tromey  <tom@tromey.com>
1210
1211         * common/common-exceptions.h (exception_rethrow): Don't declare.
1212         (TRY_SJLJ): Update comment.
1213         (TRY, CATCH, END_CATCH): Remove.
1214         * common/common-exceptions.c (exception_rethrow): Remove.
1215
1216 2019-04-08  Tom Tromey  <tom@tromey.com>
1217
1218         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1219         Remove.
1220         (gdb_exception_error): Rename from
1221         gdb_exception_RETURN_MASK_ERROR.
1222         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1223         (gdb_quit_bad_alloc): Update.
1224         * aarch64-tdep.c: Update.
1225         * ada-lang.c: Update.
1226         * ada-typeprint.c: Update.
1227         * ada-valprint.c: Update.
1228         * amd64-tdep.c: Update.
1229         * arch-utils.c: Update.
1230         * break-catch-throw.c: Update.
1231         * breakpoint.c: Update.
1232         * btrace.c: Update.
1233         * c-varobj.c: Update.
1234         * cli/cli-cmds.c: Update.
1235         * cli/cli-interp.c: Update.
1236         * cli/cli-script.c: Update.
1237         * common/common-exceptions.c: Update.
1238         * common/new-op.c: Update.
1239         * common/selftest.c: Update.
1240         * compile/compile-c-symbols.c: Update.
1241         * compile/compile-cplus-symbols.c: Update.
1242         * compile/compile-object-load.c: Update.
1243         * compile/compile-object-run.c: Update.
1244         * completer.c: Update.
1245         * corelow.c: Update.
1246         * cp-abi.c: Update.
1247         * cp-support.c: Update.
1248         * cp-valprint.c: Update.
1249         * darwin-nat.c: Update.
1250         * disasm-selftests.c: Update.
1251         * dtrace-probe.c: Update.
1252         * dwarf-index-cache.c: Update.
1253         * dwarf-index-write.c: Update.
1254         * dwarf2-frame-tailcall.c: Update.
1255         * dwarf2-frame.c: Update.
1256         * dwarf2loc.c: Update.
1257         * dwarf2read.c: Update.
1258         * eval.c: Update.
1259         * event-loop.c: Update.
1260         * event-top.c: Update.
1261         * exec.c: Update.
1262         * f-valprint.c: Update.
1263         * fbsd-tdep.c: Update.
1264         * frame-unwind.c: Update.
1265         * frame.c: Update.
1266         * gdbtypes.c: Update.
1267         * gnu-v3-abi.c: Update.
1268         * guile/guile-internal.h: Update.
1269         * guile/scm-block.c: Update.
1270         * guile/scm-breakpoint.c: Update.
1271         * guile/scm-cmd.c: Update.
1272         * guile/scm-disasm.c: Update.
1273         * guile/scm-frame.c: Update.
1274         * guile/scm-lazy-string.c: Update.
1275         * guile/scm-math.c: Update.
1276         * guile/scm-param.c: Update.
1277         * guile/scm-ports.c: Update.
1278         * guile/scm-pretty-print.c: Update.
1279         * guile/scm-symbol.c: Update.
1280         * guile/scm-symtab.c: Update.
1281         * guile/scm-type.c: Update.
1282         * guile/scm-value.c: Update.
1283         * i386-linux-tdep.c: Update.
1284         * i386-tdep.c: Update.
1285         * inf-loop.c: Update.
1286         * infcall.c: Update.
1287         * infcmd.c: Update.
1288         * infrun.c: Update.
1289         * jit.c: Update.
1290         * language.c: Update.
1291         * linespec.c: Update.
1292         * linux-fork.c: Update.
1293         * linux-nat.c: Update.
1294         * linux-tdep.c: Update.
1295         * linux-thread-db.c: Update.
1296         * main.c: Update.
1297         * mi/mi-cmd-break.c: Update.
1298         * mi/mi-cmd-stack.c: Update.
1299         * mi/mi-interp.c: Update.
1300         * mi/mi-main.c: Update.
1301         * objc-lang.c: Update.
1302         * p-valprint.c: Update.
1303         * parse.c: Update.
1304         * ppc-linux-tdep.c: Update.
1305         * printcmd.c: Update.
1306         * python/py-arch.c: Update.
1307         * python/py-breakpoint.c: Update.
1308         * python/py-cmd.c: Update.
1309         * python/py-finishbreakpoint.c: Update.
1310         * python/py-frame.c: Update.
1311         * python/py-framefilter.c: Update.
1312         * python/py-gdb-readline.c: Update.
1313         * python/py-inferior.c: Update.
1314         * python/py-infthread.c: Update.
1315         * python/py-lazy-string.c: Update.
1316         * python/py-linetable.c: Update.
1317         * python/py-objfile.c: Update.
1318         * python/py-param.c: Update.
1319         * python/py-prettyprint.c: Update.
1320         * python/py-progspace.c: Update.
1321         * python/py-record-btrace.c: Update.
1322         * python/py-record.c: Update.
1323         * python/py-symbol.c: Update.
1324         * python/py-type.c: Update.
1325         * python/py-unwind.c: Update.
1326         * python/py-utils.c: Update.
1327         * python/py-value.c: Update.
1328         * python/python.c: Update.
1329         * record-btrace.c: Update.
1330         * record-full.c: Update.
1331         * remote-fileio.c: Update.
1332         * remote.c: Update.
1333         * riscv-tdep.c: Update.
1334         * rs6000-aix-tdep.c: Update.
1335         * rs6000-tdep.c: Update.
1336         * rust-exp.y: Update.
1337         * rust-lang.c: Update.
1338         * s390-tdep.c: Update.
1339         * selftest-arch.c: Update.
1340         * solib-dsbt.c: Update.
1341         * solib-frv.c: Update.
1342         * solib-spu.c: Update.
1343         * solib-svr4.c: Update.
1344         * solib.c: Update.
1345         * sparc64-linux-tdep.c: Update.
1346         * stack.c: Update.
1347         * symfile-mem.c: Update.
1348         * symmisc.c: Update.
1349         * target.c: Update.
1350         * thread.c: Update.
1351         * top.c: Update.
1352         * tracefile-tfile.c: Update.
1353         * tui/tui.c: Update.
1354         * typeprint.c: Update.
1355         * unittests/cli-utils-selftests.c: Update.
1356         * unittests/parse-connection-spec-selftests.c: Update.
1357         * valops.c: Update.
1358         * valprint.c: Update.
1359         * value.c: Update.
1360         * varobj.c: Update.
1361         * windows-nat.c: Update.
1362         * x86-linux-nat.c: Update.
1363         * xml-support.c: Update.
1364
1365 2019-04-08  Tom Tromey  <tom@tromey.com>
1366
1367         * xml-support.c: Use C++ exception handling.
1368         * x86-linux-nat.c: Use C++ exception handling.
1369         * windows-nat.c: Use C++ exception handling.
1370         * varobj.c: Use C++ exception handling.
1371         * value.c: Use C++ exception handling.
1372         * valprint.c: Use C++ exception handling.
1373         * valops.c: Use C++ exception handling.
1374         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1375         handling.
1376         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1377         * typeprint.c: Use C++ exception handling.
1378         * tui/tui.c: Use C++ exception handling.
1379         * tracefile-tfile.c: Use C++ exception handling.
1380         * top.c: Use C++ exception handling.
1381         * thread.c: Use C++ exception handling.
1382         * target.c: Use C++ exception handling.
1383         * symmisc.c: Use C++ exception handling.
1384         * symfile-mem.c: Use C++ exception handling.
1385         * stack.c: Use C++ exception handling.
1386         * sparc64-linux-tdep.c: Use C++ exception handling.
1387         * solib.c: Use C++ exception handling.
1388         * solib-svr4.c: Use C++ exception handling.
1389         * solib-spu.c: Use C++ exception handling.
1390         * solib-frv.c: Use C++ exception handling.
1391         * solib-dsbt.c: Use C++ exception handling.
1392         * selftest-arch.c: Use C++ exception handling.
1393         * s390-tdep.c: Use C++ exception handling.
1394         * rust-lang.c: Use C++ exception handling.
1395         * rust-exp.y: Use C++ exception handling.
1396         * rs6000-tdep.c: Use C++ exception handling.
1397         * rs6000-aix-tdep.c: Use C++ exception handling.
1398         * riscv-tdep.c: Use C++ exception handling.
1399         * remote.c: Use C++ exception handling.
1400         * remote-fileio.c: Use C++ exception handling.
1401         * record-full.c: Use C++ exception handling.
1402         * record-btrace.c: Use C++ exception handling.
1403         * python/python.c: Use C++ exception handling.
1404         * python/py-value.c: Use C++ exception handling.
1405         * python/py-utils.c: Use C++ exception handling.
1406         * python/py-unwind.c: Use C++ exception handling.
1407         * python/py-type.c: Use C++ exception handling.
1408         * python/py-symbol.c: Use C++ exception handling.
1409         * python/py-record.c: Use C++ exception handling.
1410         * python/py-record-btrace.c: Use C++ exception handling.
1411         * python/py-progspace.c: Use C++ exception handling.
1412         * python/py-prettyprint.c: Use C++ exception handling.
1413         * python/py-param.c: Use C++ exception handling.
1414         * python/py-objfile.c: Use C++ exception handling.
1415         * python/py-linetable.c: Use C++ exception handling.
1416         * python/py-lazy-string.c: Use C++ exception handling.
1417         * python/py-infthread.c: Use C++ exception handling.
1418         * python/py-inferior.c: Use C++ exception handling.
1419         * python/py-gdb-readline.c: Use C++ exception handling.
1420         * python/py-framefilter.c: Use C++ exception handling.
1421         * python/py-frame.c: Use C++ exception handling.
1422         * python/py-finishbreakpoint.c: Use C++ exception handling.
1423         * python/py-cmd.c: Use C++ exception handling.
1424         * python/py-breakpoint.c: Use C++ exception handling.
1425         * python/py-arch.c: Use C++ exception handling.
1426         * printcmd.c: Use C++ exception handling.
1427         * ppc-linux-tdep.c: Use C++ exception handling.
1428         * parse.c: Use C++ exception handling.
1429         * p-valprint.c: Use C++ exception handling.
1430         * objc-lang.c: Use C++ exception handling.
1431         * mi/mi-main.c: Use C++ exception handling.
1432         * mi/mi-interp.c: Use C++ exception handling.
1433         * mi/mi-cmd-stack.c: Use C++ exception handling.
1434         * mi/mi-cmd-break.c: Use C++ exception handling.
1435         * main.c: Use C++ exception handling.
1436         * linux-thread-db.c: Use C++ exception handling.
1437         * linux-tdep.c: Use C++ exception handling.
1438         * linux-nat.c: Use C++ exception handling.
1439         * linux-fork.c: Use C++ exception handling.
1440         * linespec.c: Use C++ exception handling.
1441         * language.c: Use C++ exception handling.
1442         * jit.c: Use C++ exception handling.
1443         * infrun.c: Use C++ exception handling.
1444         * infcmd.c: Use C++ exception handling.
1445         * infcall.c: Use C++ exception handling.
1446         * inf-loop.c: Use C++ exception handling.
1447         * i386-tdep.c: Use C++ exception handling.
1448         * i386-linux-tdep.c: Use C++ exception handling.
1449         * guile/scm-value.c: Use C++ exception handling.
1450         * guile/scm-type.c: Use C++ exception handling.
1451         * guile/scm-symtab.c: Use C++ exception handling.
1452         * guile/scm-symbol.c: Use C++ exception handling.
1453         * guile/scm-pretty-print.c: Use C++ exception handling.
1454         * guile/scm-ports.c: Use C++ exception handling.
1455         * guile/scm-param.c: Use C++ exception handling.
1456         * guile/scm-math.c: Use C++ exception handling.
1457         * guile/scm-lazy-string.c: Use C++ exception handling.
1458         * guile/scm-frame.c: Use C++ exception handling.
1459         * guile/scm-disasm.c: Use C++ exception handling.
1460         * guile/scm-cmd.c: Use C++ exception handling.
1461         * guile/scm-breakpoint.c: Use C++ exception handling.
1462         * guile/scm-block.c: Use C++ exception handling.
1463         * guile/guile-internal.h: Use C++ exception handling.
1464         * gnu-v3-abi.c: Use C++ exception handling.
1465         * gdbtypes.c: Use C++ exception handling.
1466         * frame.c: Use C++ exception handling.
1467         * frame-unwind.c: Use C++ exception handling.
1468         * fbsd-tdep.c: Use C++ exception handling.
1469         * f-valprint.c: Use C++ exception handling.
1470         * exec.c: Use C++ exception handling.
1471         * event-top.c: Use C++ exception handling.
1472         * event-loop.c: Use C++ exception handling.
1473         * eval.c: Use C++ exception handling.
1474         * dwarf2read.c: Use C++ exception handling.
1475         * dwarf2loc.c: Use C++ exception handling.
1476         * dwarf2-frame.c: Use C++ exception handling.
1477         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1478         * dwarf-index-write.c: Use C++ exception handling.
1479         * dwarf-index-cache.c: Use C++ exception handling.
1480         * dtrace-probe.c: Use C++ exception handling.
1481         * disasm-selftests.c: Use C++ exception handling.
1482         * darwin-nat.c: Use C++ exception handling.
1483         * cp-valprint.c: Use C++ exception handling.
1484         * cp-support.c: Use C++ exception handling.
1485         * cp-abi.c: Use C++ exception handling.
1486         * corelow.c: Use C++ exception handling.
1487         * completer.c: Use C++ exception handling.
1488         * compile/compile-object-run.c: Use C++ exception handling.
1489         * compile/compile-object-load.c: Use C++ exception handling.
1490         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1491         * compile/compile-c-symbols.c: Use C++ exception handling.
1492         * common/selftest.c: Use C++ exception handling.
1493         * common/new-op.c: Use C++ exception handling.
1494         * cli/cli-script.c: Use C++ exception handling.
1495         * cli/cli-interp.c: Use C++ exception handling.
1496         * cli/cli-cmds.c: Use C++ exception handling.
1497         * c-varobj.c: Use C++ exception handling.
1498         * btrace.c: Use C++ exception handling.
1499         * breakpoint.c: Use C++ exception handling.
1500         * break-catch-throw.c: Use C++ exception handling.
1501         * arch-utils.c: Use C++ exception handling.
1502         * amd64-tdep.c: Use C++ exception handling.
1503         * ada-valprint.c: Use C++ exception handling.
1504         * ada-typeprint.c: Use C++ exception handling.
1505         * ada-lang.c: Use C++ exception handling.
1506         * aarch64-tdep.c: Use C++ exception handling.
1507
1508 2019-04-08  Tom Tromey  <tom@tromey.com>
1509
1510         * xml-support.c (gdb_xml_parser::parse): Update.
1511         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1512         * value.c (show_convenience): Update.
1513         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1514         (test_parse_flags_qcs): Update.
1515         * thread.c (thr_try_catch_cmd): Update.
1516         * target.c (target_translate_tls_address): Update.
1517         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1518         (info_frame_command_core, frame_apply_command_count): Update.
1519         * rust-exp.y (rust_lex_exception_test): Update.
1520         * riscv-tdep.c (riscv_print_one_register_info): Update.
1521         * remote.c (remote_target::enable_btrace): Update.
1522         * record-btrace.c (record_btrace_enable_warn): Update.
1523         * python/py-utils.c (gdbpy_convert_exception): Update.
1524         * printcmd.c (do_one_display, print_variable_and_value): Update.
1525         * mi/mi-main.c (mi_print_exception): Update.
1526         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1527         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1528         * linux-nat.c (linux_nat_target::attach): Update.
1529         * linux-fork.c (class scoped_switch_fork_info): Update.
1530         * infrun.c (displaced_step_prepare): Update.
1531         * infcall.c (call_function_by_hand_dummy): Update.
1532         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1533         * gnu-v3-abi.c (print_one_vtable): Update.
1534         * frame.c (get_prev_frame_always): Update.
1535         * f-valprint.c (info_common_command_for_block): Update.
1536         * exec.c (try_open_exec_file): Update.
1537         * exceptions.c (print_exception, exception_print)
1538         (exception_fprintf, exception_print_same): Update.
1539         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1540         * dwarf-index-cache.c (index_cache::store)
1541         (index_cache::lookup_gdb_index): Update.
1542         * darwin-nat.c (maybe_cache_shell): Update.
1543         * cp-valprint.c (cp_print_value_fields): Update.
1544         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1545         (gcc_cplus_symbol_address): Update.
1546         * compile/compile-c-symbols.c (gcc_convert_symbol)
1547         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1548         * common/selftest.c: Update.
1549         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1550         a std::string.
1551         (exception_try_scope_entry, exception_try_scope_exit): Don't
1552         declare.
1553         (struct exception_try_scope): Remove.
1554         (TRY): Don't use exception_try_scope.
1555         (struct gdb_exception): Add constructor, operator=.
1556         <what>: New method.
1557         (struct gdb_exception_RETURN_MASK_ALL)
1558         (struct gdb_exception_RETURN_MASK_ERROR)
1559         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1560         (struct gdb_quit_bad_alloc): Update.
1561         * common/common-exceptions.c (exception_none): Change
1562         initializer.
1563         (struct catcher) <state, exception>: Initialize inline.
1564         <prev>: Remove member.
1565         (current_catcher): Remove.
1566         (catchers): New global.
1567         (exceptions_state_mc_init): Simplify.
1568         (catcher_pop): Remove.
1569         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1570         (try_scope_depth, exception_try_scope_entry)
1571         (exception_try_scope_exit): Remove.
1572         (throw_exception_sjlj): Update.
1573         (exception_messages, exception_messages_size): Remove.
1574         (throw_it): Simplify.
1575         (gdb_exception_sliced_copy): Remove.
1576         (throw_exception_cxx): Update.
1577         * cli/cli-script.c (script_from_file): Update.
1578         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1579         Update.
1580         * ada-valprint.c (ada_val_print): Update.
1581         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1582         (create_excep_cond_exprs): Update.
1583
1584 2019-04-08  Tom Tromey  <tom@tromey.com>
1585
1586         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1587         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1588         (TRY, CATCH, END_CATCH): Remove some definitions.
1589         * common/common-exceptions.c: Don't use GDB_XCPT.
1590         (catcher_list_size): Remove.
1591         (throw_exception, throw_it): Simplify.
1592
1593 2019-04-05  Tom Tromey  <tom@tromey.com>
1594
1595         Revert the header-sorting patch.
1596         * ft32-tdep.c: Revert.
1597         * frv-tdep.c: Revert.
1598         * frv-linux-tdep.c: Revert.
1599         * frame.c: Revert.
1600         * frame-unwind.c: Revert.
1601         * frame-base.c: Revert.
1602         * fork-child.c: Revert.
1603         * findvar.c: Revert.
1604         * findcmd.c: Revert.
1605         * filesystem.c: Revert.
1606         * filename-seen-cache.h: Revert.
1607         * filename-seen-cache.c: Revert.
1608         * fbsd-tdep.c: Revert.
1609         * fbsd-nat.h: Revert.
1610         * fbsd-nat.c: Revert.
1611         * f-valprint.c: Revert.
1612         * f-typeprint.c: Revert.
1613         * f-lang.c: Revert.
1614         * extension.h: Revert.
1615         * extension.c: Revert.
1616         * extension-priv.h: Revert.
1617         * expprint.c: Revert.
1618         * exec.h: Revert.
1619         * exec.c: Revert.
1620         * exceptions.c: Revert.
1621         * event-top.c: Revert.
1622         * event-loop.c: Revert.
1623         * eval.c: Revert.
1624         * elfread.c: Revert.
1625         * dwarf2read.h: Revert.
1626         * dwarf2read.c: Revert.
1627         * dwarf2loc.c: Revert.
1628         * dwarf2expr.h: Revert.
1629         * dwarf2expr.c: Revert.
1630         * dwarf2-frame.c: Revert.
1631         * dwarf2-frame-tailcall.c: Revert.
1632         * dwarf-index-write.h: Revert.
1633         * dwarf-index-write.c: Revert.
1634         * dwarf-index-common.c: Revert.
1635         * dwarf-index-cache.h: Revert.
1636         * dwarf-index-cache.c: Revert.
1637         * dummy-frame.c: Revert.
1638         * dtrace-probe.c: Revert.
1639         * disasm.h: Revert.
1640         * disasm.c: Revert.
1641         * disasm-selftests.c: Revert.
1642         * dictionary.c: Revert.
1643         * dicos-tdep.c: Revert.
1644         * demangle.c: Revert.
1645         * dcache.h: Revert.
1646         * dcache.c: Revert.
1647         * darwin-nat.h: Revert.
1648         * darwin-nat.c: Revert.
1649         * darwin-nat-info.c: Revert.
1650         * d-valprint.c: Revert.
1651         * d-namespace.c: Revert.
1652         * d-lang.c: Revert.
1653         * ctf.c: Revert.
1654         * csky-tdep.c: Revert.
1655         * csky-linux-tdep.c: Revert.
1656         * cris-tdep.c: Revert.
1657         * cris-linux-tdep.c: Revert.
1658         * cp-valprint.c: Revert.
1659         * cp-support.c: Revert.
1660         * cp-namespace.c: Revert.
1661         * cp-abi.c: Revert.
1662         * corelow.c: Revert.
1663         * corefile.c: Revert.
1664         * continuations.c: Revert.
1665         * completer.h: Revert.
1666         * completer.c: Revert.
1667         * complaints.c: Revert.
1668         * coffread.c: Revert.
1669         * coff-pe-read.c: Revert.
1670         * cli-out.h: Revert.
1671         * cli-out.c: Revert.
1672         * charset.c: Revert.
1673         * c-varobj.c: Revert.
1674         * c-valprint.c: Revert.
1675         * c-typeprint.c: Revert.
1676         * c-lang.c: Revert.
1677         * buildsym.c: Revert.
1678         * buildsym-legacy.c: Revert.
1679         * build-id.h: Revert.
1680         * build-id.c: Revert.
1681         * btrace.c: Revert.
1682         * bsd-uthread.c: Revert.
1683         * breakpoint.h: Revert.
1684         * breakpoint.c: Revert.
1685         * break-catch-throw.c: Revert.
1686         * break-catch-syscall.c: Revert.
1687         * break-catch-sig.c: Revert.
1688         * blockframe.c: Revert.
1689         * block.c: Revert.
1690         * bfin-tdep.c: Revert.
1691         * bfin-linux-tdep.c: Revert.
1692         * bfd-target.c: Revert.
1693         * bcache.c: Revert.
1694         * ax-general.c: Revert.
1695         * ax-gdb.h: Revert.
1696         * ax-gdb.c: Revert.
1697         * avr-tdep.c: Revert.
1698         * auxv.c: Revert.
1699         * auto-load.c: Revert.
1700         * arm-wince-tdep.c: Revert.
1701         * arm-tdep.c: Revert.
1702         * arm-symbian-tdep.c: Revert.
1703         * arm-pikeos-tdep.c: Revert.
1704         * arm-obsd-tdep.c: Revert.
1705         * arm-nbsd-tdep.c: Revert.
1706         * arm-nbsd-nat.c: Revert.
1707         * arm-linux-tdep.c: Revert.
1708         * arm-linux-nat.c: Revert.
1709         * arm-fbsd-tdep.c: Revert.
1710         * arm-fbsd-nat.c: Revert.
1711         * arm-bsd-tdep.c: Revert.
1712         * arch-utils.c: Revert.
1713         * arc-tdep.c: Revert.
1714         * arc-newlib-tdep.c: Revert.
1715         * annotate.h: Revert.
1716         * annotate.c: Revert.
1717         * amd64-windows-tdep.c: Revert.
1718         * amd64-windows-nat.c: Revert.
1719         * amd64-tdep.c: Revert.
1720         * amd64-sol2-tdep.c: Revert.
1721         * amd64-obsd-tdep.c: Revert.
1722         * amd64-obsd-nat.c: Revert.
1723         * amd64-nbsd-tdep.c: Revert.
1724         * amd64-nbsd-nat.c: Revert.
1725         * amd64-nat.c: Revert.
1726         * amd64-linux-tdep.c: Revert.
1727         * amd64-linux-nat.c: Revert.
1728         * amd64-fbsd-tdep.c: Revert.
1729         * amd64-fbsd-nat.c: Revert.
1730         * amd64-dicos-tdep.c: Revert.
1731         * amd64-darwin-tdep.c: Revert.
1732         * amd64-bsd-nat.c: Revert.
1733         * alpha-tdep.c: Revert.
1734         * alpha-obsd-tdep.c: Revert.
1735         * alpha-nbsd-tdep.c: Revert.
1736         * alpha-mdebug-tdep.c: Revert.
1737         * alpha-linux-tdep.c: Revert.
1738         * alpha-linux-nat.c: Revert.
1739         * alpha-bsd-tdep.c: Revert.
1740         * alpha-bsd-nat.c: Revert.
1741         * aix-thread.c: Revert.
1742         * agent.c: Revert.
1743         * addrmap.c: Revert.
1744         * ada-varobj.c: Revert.
1745         * ada-valprint.c: Revert.
1746         * ada-typeprint.c: Revert.
1747         * ada-tasks.c: Revert.
1748         * ada-lang.c: Revert.
1749         * aarch64-tdep.c: Revert.
1750         * aarch64-ravenscar-thread.c: Revert.
1751         * aarch64-newlib-tdep.c: Revert.
1752         * aarch64-linux-tdep.c: Revert.
1753         * aarch64-linux-nat.c: Revert.
1754         * aarch64-fbsd-tdep.c: Revert.
1755         * aarch64-fbsd-nat.c: Revert.
1756         * aarch32-linux-nat.c: Revert.
1757
1758 2019-04-05  Tom Tromey  <tom@tromey.com>
1759
1760         * ft32-tdep.c: Sort headers.
1761         * frv-tdep.c: Sort headers.
1762         * frv-linux-tdep.c: Sort headers.
1763         * frame.c: Sort headers.
1764         * frame-unwind.c: Sort headers.
1765         * frame-base.c: Sort headers.
1766         * fork-child.c: Sort headers.
1767         * findvar.c: Sort headers.
1768         * findcmd.c: Sort headers.
1769         * filesystem.c: Sort headers.
1770         * filename-seen-cache.h: Sort headers.
1771         * filename-seen-cache.c: Sort headers.
1772         * fbsd-tdep.c: Sort headers.
1773         * fbsd-nat.h: Sort headers.
1774         * fbsd-nat.c: Sort headers.
1775         * f-valprint.c: Sort headers.
1776         * f-typeprint.c: Sort headers.
1777         * f-lang.c: Sort headers.
1778         * extension.h: Sort headers.
1779         * extension.c: Sort headers.
1780         * extension-priv.h: Sort headers.
1781         * expprint.c: Sort headers.
1782         * exec.h: Sort headers.
1783         * exec.c: Sort headers.
1784         * exceptions.c: Sort headers.
1785         * event-top.c: Sort headers.
1786         * event-loop.c: Sort headers.
1787         * eval.c: Sort headers.
1788         * elfread.c: Sort headers.
1789         * dwarf2read.h: Sort headers.
1790         * dwarf2read.c: Sort headers.
1791         * dwarf2loc.c: Sort headers.
1792         * dwarf2expr.h: Sort headers.
1793         * dwarf2expr.c: Sort headers.
1794         * dwarf2-frame.c: Sort headers.
1795         * dwarf2-frame-tailcall.c: Sort headers.
1796         * dwarf-index-write.h: Sort headers.
1797         * dwarf-index-write.c: Sort headers.
1798         * dwarf-index-common.c: Sort headers.
1799         * dwarf-index-cache.h: Sort headers.
1800         * dwarf-index-cache.c: Sort headers.
1801         * dummy-frame.c: Sort headers.
1802         * dtrace-probe.c: Sort headers.
1803         * disasm.h: Sort headers.
1804         * disasm.c: Sort headers.
1805         * disasm-selftests.c: Sort headers.
1806         * dictionary.c: Sort headers.
1807         * dicos-tdep.c: Sort headers.
1808         * demangle.c: Sort headers.
1809         * dcache.h: Sort headers.
1810         * dcache.c: Sort headers.
1811         * darwin-nat.h: Sort headers.
1812         * darwin-nat.c: Sort headers.
1813         * darwin-nat-info.c: Sort headers.
1814         * d-valprint.c: Sort headers.
1815         * d-namespace.c: Sort headers.
1816         * d-lang.c: Sort headers.
1817         * ctf.c: Sort headers.
1818         * csky-tdep.c: Sort headers.
1819         * csky-linux-tdep.c: Sort headers.
1820         * cris-tdep.c: Sort headers.
1821         * cris-linux-tdep.c: Sort headers.
1822         * cp-valprint.c: Sort headers.
1823         * cp-support.c: Sort headers.
1824         * cp-namespace.c: Sort headers.
1825         * cp-abi.c: Sort headers.
1826         * corelow.c: Sort headers.
1827         * corefile.c: Sort headers.
1828         * continuations.c: Sort headers.
1829         * completer.h: Sort headers.
1830         * completer.c: Sort headers.
1831         * complaints.c: Sort headers.
1832         * coffread.c: Sort headers.
1833         * coff-pe-read.c: Sort headers.
1834         * cli-out.h: Sort headers.
1835         * cli-out.c: Sort headers.
1836         * charset.c: Sort headers.
1837         * c-varobj.c: Sort headers.
1838         * c-valprint.c: Sort headers.
1839         * c-typeprint.c: Sort headers.
1840         * c-lang.c: Sort headers.
1841         * buildsym.c: Sort headers.
1842         * buildsym-legacy.c: Sort headers.
1843         * build-id.h: Sort headers.
1844         * build-id.c: Sort headers.
1845         * btrace.c: Sort headers.
1846         * bsd-uthread.c: Sort headers.
1847         * breakpoint.h: Sort headers.
1848         * breakpoint.c: Sort headers.
1849         * break-catch-throw.c: Sort headers.
1850         * break-catch-syscall.c: Sort headers.
1851         * break-catch-sig.c: Sort headers.
1852         * blockframe.c: Sort headers.
1853         * block.c: Sort headers.
1854         * bfin-tdep.c: Sort headers.
1855         * bfin-linux-tdep.c: Sort headers.
1856         * bfd-target.c: Sort headers.
1857         * bcache.c: Sort headers.
1858         * ax-general.c: Sort headers.
1859         * ax-gdb.h: Sort headers.
1860         * ax-gdb.c: Sort headers.
1861         * avr-tdep.c: Sort headers.
1862         * auxv.c: Sort headers.
1863         * auto-load.c: Sort headers.
1864         * arm-wince-tdep.c: Sort headers.
1865         * arm-tdep.c: Sort headers.
1866         * arm-symbian-tdep.c: Sort headers.
1867         * arm-pikeos-tdep.c: Sort headers.
1868         * arm-obsd-tdep.c: Sort headers.
1869         * arm-nbsd-tdep.c: Sort headers.
1870         * arm-nbsd-nat.c: Sort headers.
1871         * arm-linux-tdep.c: Sort headers.
1872         * arm-linux-nat.c: Sort headers.
1873         * arm-fbsd-tdep.c: Sort headers.
1874         * arm-fbsd-nat.c: Sort headers.
1875         * arm-bsd-tdep.c: Sort headers.
1876         * arch-utils.c: Sort headers.
1877         * arc-tdep.c: Sort headers.
1878         * arc-newlib-tdep.c: Sort headers.
1879         * annotate.h: Sort headers.
1880         * annotate.c: Sort headers.
1881         * amd64-windows-tdep.c: Sort headers.
1882         * amd64-windows-nat.c: Sort headers.
1883         * amd64-tdep.c: Sort headers.
1884         * amd64-sol2-tdep.c: Sort headers.
1885         * amd64-obsd-tdep.c: Sort headers.
1886         * amd64-obsd-nat.c: Sort headers.
1887         * amd64-nbsd-tdep.c: Sort headers.
1888         * amd64-nbsd-nat.c: Sort headers.
1889         * amd64-nat.c: Sort headers.
1890         * amd64-linux-tdep.c: Sort headers.
1891         * amd64-linux-nat.c: Sort headers.
1892         * amd64-fbsd-tdep.c: Sort headers.
1893         * amd64-fbsd-nat.c: Sort headers.
1894         * amd64-dicos-tdep.c: Sort headers.
1895         * amd64-darwin-tdep.c: Sort headers.
1896         * amd64-bsd-nat.c: Sort headers.
1897         * alpha-tdep.c: Sort headers.
1898         * alpha-obsd-tdep.c: Sort headers.
1899         * alpha-nbsd-tdep.c: Sort headers.
1900         * alpha-mdebug-tdep.c: Sort headers.
1901         * alpha-linux-tdep.c: Sort headers.
1902         * alpha-linux-nat.c: Sort headers.
1903         * alpha-bsd-tdep.c: Sort headers.
1904         * alpha-bsd-nat.c: Sort headers.
1905         * aix-thread.c: Sort headers.
1906         * agent.c: Sort headers.
1907         * addrmap.c: Sort headers.
1908         * ada-varobj.c: Sort headers.
1909         * ada-valprint.c: Sort headers.
1910         * ada-typeprint.c: Sort headers.
1911         * ada-tasks.c: Sort headers.
1912         * ada-lang.c: Sort headers.
1913         * aarch64-tdep.c: Sort headers.
1914         * aarch64-ravenscar-thread.c: Sort headers.
1915         * aarch64-newlib-tdep.c: Sort headers.
1916         * aarch64-linux-tdep.c: Sort headers.
1917         * aarch64-linux-nat.c: Sort headers.
1918         * aarch64-fbsd-tdep.c: Sort headers.
1919         * aarch64-fbsd-nat.c: Sort headers.
1920         * aarch32-linux-nat.c: Sort headers.
1921
1922 2019-04-04  Tom Tromey  <tom@tromey.com>
1923
1924         * varobj.c (varobj_create): Update.
1925         * rust-exp.y (struct rust_parser) <update_innermost_block,
1926         lookup_symbol>: New methods.
1927         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1928         Rename.
1929         (rust_parser::rust_lookup_type)
1930         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1931         * printcmd.c (display_command, do_one_display): Update.
1932         * parser-defs.h (struct parser_state) <parser_state>: Add
1933         "tracker" parameter.
1934         (block_tracker): New member.
1935         (class innermost_block_tracker) <innermost_block_tracker>: Add
1936         "types" parameter.
1937         <reset>: Remove method.
1938         (innermost_block): Don't declare.
1939         (null_post_parser): Update.
1940         * parse.c (innermost_block): Remove global.
1941         (write_dollar_variable): Update.
1942         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1943         Remove "tracker_types" parameter.
1944         (parse_expression): Add "tracker" parameter.
1945         (parse_expression_for_completion): Update.
1946         (null_post_parser): Add "tracker" parameter.
1947         * p-exp.y: Update rules.
1948         * m2-exp.y: Update rules.
1949         * language.h (struct language_defn) <la_post_parser>: Add
1950         "tracker" parameter.
1951         * go-exp.y: Update rules.
1952         * f-exp.y: Update rules.
1953         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1954         parameter.
1955         * d-exp.y: Update rules.
1956         * c-exp.y: Update rules.
1957         * breakpoint.c (set_breakpoint_condition): Create an
1958         innermost_block_tracker.
1959         (watch_command_1): Likewise.
1960         * ada-lang.c (resolve): Add "tracker" parameter.
1961         (resolve_subexp): Likewise.
1962         * ada-exp.y (write_var_from_sym): Update.
1963
1964 2019-04-04  Tom Tromey  <tom@tromey.com>
1965
1966         * type-stack.h: New file.
1967         * type-stack.c: New file.
1968         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1969         type-stack.h.
1970         (insert_into_type_stack, insert_type, push_type, push_type_int)
1971         (insert_type_address_space, pop_type, pop_type_int)
1972         (pop_typelist, pop_type_stack, append_type_stack)
1973         (push_type_stack, get_type_stack, push_typelist)
1974         (follow_type_instance_flags, follow_types): Don't declare.
1975         * parse.c (type_stack): Remove global.
1976         (parse_exp_in_context): Update.
1977         (insert_into_type_stack, insert_type, push_type, push_type_int)
1978         (insert_type_address_space, pop_type, pop_type_int)
1979         (pop_typelist, pop_type_stack, append_type_stack)
1980         (push_type_stack, get_type_stack, push_typelist)
1981         (follow_type_instance_flags, follow_types): Remove (moved to
1982         type-stack.c).
1983         * f-exp.y (type_stack): New global.
1984         Update rules.
1985         (push_kind_type, f_parse): Update.
1986         * d-exp.y (type_stack): New global.
1987         Update rules.
1988         (d_parse): Update.
1989         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1990         Update rules.
1991         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1992         (HFILES_NO_SRCDIR): Add type-stack.h.
1993
1994 2019-04-04  Tom Tromey  <tom@tromey.com>
1995
1996         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1997         (rust_parser::convert_ast_to_expression, rust_parse)
1998         (rust_lex_test_completion, rust_lex_tests): Update.
1999         * parser-defs.h (struct expr_completion_state): New.
2000         (struct parser_state) <parser_state>: Add completion parameter.
2001         <mark_struct_expression, mark_completion_tag>: New methods.
2002         <parse_completion, m_completion_state>: New members.
2003         (prefixify_expression, null_post_parser): Update.
2004         (mark_struct_expression, mark_completion_tag): Don't declare.
2005         * parse.c (parse_completion, expout_last_struct)
2006         (expout_tag_completion_type, expout_completion_name): Remove
2007         globals.
2008         (parser_state::mark_struct_expression)
2009         (parser_state::mark_completion_tag): Now methods.
2010         (prefixify_expression): Add last_struct parameter.
2011         (prefixify_subexp): Likewise.
2012         (parse_exp_1): Update.
2013         (parse_exp_in_context): Add cstate parameter.  Update.
2014         (parse_expression_for_completion): Create an
2015         expr_completion_state.
2016         (null_post_parser): Add "completion" parameter.
2017         * p-exp.y: Update rules.
2018         (yylex): Update.
2019         * language.h (struct language_defn) <la_post_parser>: Add
2020         "completing" parameter.
2021         * go-exp.y: Update rules.
2022         (lex_one_token): Update.
2023         * expression.h (parse_completion): Don't declare.
2024         * d-exp.y: Update rules.
2025         (lex_one_token): Update rules.
2026         * c-exp.y: Update rules.
2027         (lex_one_token): Update.
2028         * ada-lang.c (resolve): Add "parse_completion" parameter.
2029         (resolve_subexp): Likewise.
2030         (ada_resolve_function): Likewise.
2031
2032 2019-04-04  Tom Tromey  <tom@tromey.com>
2033
2034         * parser-defs.h (struct parser_state) <start_arglist,
2035         end_arglist>: New methods.
2036         <arglist_len, m_funcall_chain>: New members.
2037         (arglist_len, start_arglist, end_arglist): Don't declare.
2038         * parse.c (arglist_len, funcall_chain): Remove global.
2039         (start_arglist, end_arglist): Remove functions.
2040         (parse_exp_in_context): Update.
2041         * p-exp.y: Update rules.
2042         * m2-exp.y: Update rules.
2043         * go-exp.y: Update rules.
2044         * f-exp.y: Update rules.
2045         * d-exp.y: Update rules.
2046         * c-exp.y: Update rules.
2047
2048 2019-04-04  Tom Tromey  <tom@tromey.com>
2049
2050         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2051         lex_operator, push_back>: New methods.
2052         Update all rules.
2053         (rust_parser::lex_hex, lex_escape): Rename and update.
2054         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2055         (rust_parser::lex_operator): Rename and update.
2056         (rust_parser::lex_number, rustyylex, rustyyerror)
2057         (rust_lex_test_init, rust_lex_test_sequence)
2058         (rust_lex_test_push_back, rust_lex_tests): Update.
2059         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2060         parameter.
2061         <lexptr, prev_lexptr>: New members.
2062         (lexptr, prev_lexptr): Don't declare.
2063         * parse.c (lexptr, prev_lexptr): Remove globals.
2064         (parse_exp_in_context): Update.
2065         * p-exp.y (yylex, yyerror): Update.
2066         * m2-exp.y (parse_number, yylex, yyerror): Update.
2067         * go-exp.y (lex_one_token, yyerror): Update.
2068         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2069         * d-exp.y (lex_one_token, yyerror): Update.
2070         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2071         (lex_one_token, yyerror): Update.
2072         * ada-lex.l (YY_INPUT): Update.
2073         (rewind_to_char): Update.
2074         * ada-exp.y (yyerror): Update.
2075
2076 2019-04-04  Tom Tromey  <tom@tromey.com>
2077
2078         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2079         * parser-defs.h (struct parser_state) <parser_state>: Add new
2080         parameter.
2081         <comma_terminates>: New member.
2082         (comma_terminates): Don't declare global.
2083         * parse.c (comma_terminates): Remove global.
2084         (parse_exp_in_context): Update.
2085         * p-exp.y (yylex): Update.
2086         * m2-exp.y (yylex): Update.
2087         * go-exp.y (lex_one_token): Update.
2088         * f-exp.y (yylex): Update.
2089         * d-exp.y (lex_one_token): Update.
2090         * c-exp.y (lex_one_token): Update.
2091         * ada-lex.l: Update.
2092
2093 2019-04-04  Tom Tromey  <tom@tromey.com>
2094
2095         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2096         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2097         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2098         * parser-defs.h (paren_depth): Don't declare.
2099         * parse.c (paren_depth): Remove global.
2100         (parse_exp_in_context): Update.
2101         * p-exp.y (paren_depth): New global.
2102         (pascal_parse): Initialize it.
2103         * m2-exp.y (paren_depth): New global.
2104         (m2_parse): Initialize it.
2105         * go-exp.y (paren_depth): New global.
2106         (go_parse): Initialize it.
2107         * f-exp.y (paren_depth): New global.
2108         (f_parse): Initialize it.
2109         * d-exp.y (paren_depth): New global.
2110         (d_parse): Initialize it.
2111         * c-exp.y (paren_depth): New global.
2112         (c_parse): Initialize it.
2113         * ada-lex.l (paren_depth): New global.
2114         (lexer_init): Initialize it.
2115
2116 2019-04-04  Tom Tromey  <tom@tromey.com>
2117
2118         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2119         (rust_parser::convert_ast_to_type)
2120         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2121         * parser-defs.h (struct parser_state) <parser_state>: Add
2122         parameters.  Initialize new members.
2123         <expression_context_block, expression_context_pc>: New members.
2124         * parse.c (expression_context_block, expression_context_pc):
2125         Remove globals.
2126         (parse_exp_in_context): Update.
2127         * p-exp.y: Update all rules.
2128         (yylex): Update.
2129         * m2-exp.y: Update all rules.
2130         (yylex): Update.
2131         * go-exp.y (yylex): Update.
2132         * f-exp.y (yylex): Update.
2133         * d-exp.y: Update all rules.
2134         (yylex): Update.
2135         * c-exp.y: Update all rules.
2136         (lex_one_token, classify_name, yylex, c_parse): Update.
2137         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2138
2139 2019-04-04  Tom Tromey  <tom@tromey.com>
2140
2141         * gdbarch.h, gdbarch.c: Rebuild.
2142         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2143         * stap-probe.h:
2144         (struct stap_parse_info): Replace "parser_state" with
2145         "expr_builder".
2146         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2147         (parser_state): New class.
2148         * parse.c (expr_builder): Rename.
2149         (expr_builder::release): Rename.
2150         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2151         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2152         (write_exp_elt_longcst, write_exp_elt_floatcst)
2153         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2154         (write_exp_string_vector, write_exp_bitstring)
2155         (write_exp_msymbol, mark_struct_expression)
2156         (write_dollar_variable)
2157         (insert_type_address_space, increase_expout_size): Replace
2158         "parser_state" with "expr_builder".
2159         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2160         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2161         "parser_state" with "expr_builder".
2162
2163 2019-04-04  Tom Tromey  <tom@tromey.com>
2164
2165         * rust-exp.y: Replace "parse_language" with method call.
2166         * p-exp.y:
2167         (yylex): Replace "parse_language" with method call.
2168         * m2-exp.y:
2169         (yylex): Replace "parse_language" with method call.
2170         * go-exp.y (classify_name): Replace "parse_language" with method
2171         call.
2172         * f-exp.y (yylex): Replace "parse_language" with method call.
2173         * d-exp.y (lex_one_token): Replace "parse_language" with method
2174         call.
2175         * c-exp.y:
2176         (lex_one_token, classify_name, yylex): Replace "parse_language"
2177         with method call.
2178         * ada-exp.y (find_primitive_type, type_char)
2179         (type_system_address): Replace "parse_language" with method call.
2180
2181 2019-04-04  Tom Tromey  <tom@tromey.com>
2182
2183         * rust-exp.y: Replace "parse_gdbarch" with method call.
2184         * parse.c (write_dollar_variable, insert_type_address_space):
2185         Replace "parse_gdbarch" with method call.
2186         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2187         call.
2188         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2189         call.
2190         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2191         "parse_gdbarch" with method call.
2192         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2193         with method call.
2194         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2195         "parse_gdbarch" with method call.
2196         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2197         "parse_gdbarch" with method call.
2198         * c-exp.y (parse_type, parse_number, classify_name): Replace
2199         "parse_gdbarch" with method call.
2200         * ada-lex.l: Replace "parse_gdbarch" with method call.
2201         * ada-exp.y (parse_type, find_primitive_type, type_char)
2202         (type_system_address): Replace "parse_gdbarch" with method call.
2203
2204 2019-04-04  Tom Tromey  <tom@tromey.com>
2205
2206         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2207         * stap-probe.c (stap_parse_argument): Update.
2208         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2209         initial_size parameter.
2210         * rust-exp.y (rust_lex_tests): Update.
2211         * parse.c (parser_state): Update.
2212         (parse_exp_in_context): Update.
2213         * parser-defs.h (struct parser_state) <parser_state>: Remove
2214         "initial_size" parameter.
2215
2216 2019-04-04  Tom Tromey  <tom@tromey.com>
2217
2218         * parser-defs.h (increase_expout_size): Don't declare.
2219         * parse.c (increase_expout_size): Now static.
2220
2221 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2222
2223         * gnu-nat.c (gnu_nat_target::wait): Fix
2224         target_waitstatus_to_string call.
2225
2226 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2227
2228         * eval.c (evaluate_subexp_standard): Handle internal functions
2229         during Fortran function call handling.
2230
2231 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2232
2233         * NEWS: Mention new internal functions.
2234         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2235         (read_base_type): Use dwarf2_init_complex_target_type.
2236         * value.c (creal_internal_fn): New function.
2237         (cimag_internal_fn): New function.
2238         (_initialize_values): Register new internal functions.
2239
2240 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2241
2242         * infrun.c (stop_all_threads): If debug_infrun, always
2243         trace the wait status after wait_one, using
2244         target_waitstatus_to_string and target_pid_to_str.
2245         (handle_inferior_event): Replace various trace of
2246         wait status kind by a single trace.
2247         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2248         wait status kind image by target_waitstatus_to_string.
2249         * target/waitstatus.c (target_waitstatus_to_string): Fix
2250         obsolete comment.
2251
2252 2019-04-01  Tom Tromey  <tromey@adacore.com>
2253
2254         PR symtab/23331:
2255         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2256
2257 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2258             Pedro Alves  <palves@redhat.com>
2259
2260         * top.c (quit_force): Call 'finalize_values'.
2261         * value.c (finalize_values): New function.
2262         * value.h (finalize_values): Declare.
2263
2264 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2265
2266         * NEWS: Announce $_gdb_major and $_gdb_minor.
2267
2268         * top.c (init_gdb_version_vars): New function.
2269         (gdb_init): Call init_gdb_version_vars.
2270
2271 2019-03-29  Tom Tromey  <tromey@adacore.com>
2272
2273         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2274         help text.  Remove dead code.
2275
2276 2019-03-29  Keith Seitz  <keiths@redhat.com>
2277
2278         From Siddhesh Poyarekar:
2279         * f-lang.h (f77_get_upperbound): Return LONGEST.
2280         (f77_get_lowerbound): Likewise.
2281         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2282         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2283         print them.
2284         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2285         plongest to format print it.
2286         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2287         (f77_get_upperbound): Likewise.
2288         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2289         LOWER_BOUND to LONGEST.
2290         (f77_create_arrayprint_offset_tbl): Likewise.
2291
2292 2019-03-29  Keith Seitz  <keiths@redhat.com>
2293
2294         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2295         %s/pulongest for TYPE_LENGTH instead of %d in format
2296         strings.
2297         * ada-typerint.c (ada_print_type): Likewise.
2298         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2299         * compile/compile-c-support.c (generate_register_struct): Likewise.
2300         * gdbtypes.c (recursive_dump_type): Likewise.
2301         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2302         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2303         instead of %d in format strings.
2304         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2305         to std::min to ULONGEST.
2306         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2307         instead of %d in format strings.
2308         * tracepoint.c (info_scope_command): Likewise.
2309         * typeprint.c (print_offset_data::update)
2310         (print_offset_data::finish): Likewise.
2311         * xtensa-tdep.c (xtensa_store_return_value)
2312         (xtensa_push_dummy_call): Likewise.
2313
2314 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2315
2316         * windows-nat.c (display_selector): Fixed format specifications
2317         for 64-bit Cygwin.
2318
2319 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2320
2321         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2322
2323 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2324
2325         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2326         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2327         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2328         (nios2_linux_init_abi): Install it.
2329
2330 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2331
2332         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2333
2334 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2335
2336         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2337
2338 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2339             Tom Tromey  <tromey@adacore.com>
2340
2341         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2342
2343 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2344
2345         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2346         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2347         method to compute the bounds of range types. Also print "[evaluated]"
2348         if the bounds' values come from a dynamic evaluation.
2349
2350 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2351
2352         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2353         whitespace when pretty printing is on.
2354
2355 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2356
2357         * ppc-linux-nat.c: Add include.
2358
2359 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2360
2361         * NEWS: Mention AArch64 Pointer Authentication.
2362
2363 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2364
2365         * arm-linux-nat.c: Add include.
2366
2367 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2368
2369         * source-cache.c (source_cache::get_source_lines): Re-read
2370         fullname after calling open_source_file.
2371
2372 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2373
2374         * NEWS: Mention TLS support for FreeBSD.
2375
2376 2019-03-25  Tom Tromey  <tromey@adacore.com>
2377
2378         * minsyms.c (BUNCH_SIZE): Update comment.
2379         (~minimal_symbol_reader): Remove old comment.
2380         (compact_minimal_symbols): Update comment.
2381         (minimal_symbol_reader::install): Remove old comment.  Update
2382         other comments.
2383
2384 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2385
2386         * s390-linux-nat.c: Add include.
2387
2388 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2389
2390         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2391         Call linux_get_hwcap.
2392         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2393         Likewise.
2394         (aarch64_linux_get_hwcap): Remove function.
2395         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2396         declaration.
2397         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2398         linux_get_hwcap.
2399         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2400         * linux-tdep.c (linux_get_hwcap): Add function.
2401         (linux_get_hwcap2): Likewise.
2402         * linux-tdep.h (linux_get_hwcap): Add declaration.
2403         (linux_get_hwcap2): Likewise.
2404         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2405         (ppc_linux_get_hwcap2): Likewise.
2406         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2407         linux_get_hwcap.
2408         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2409         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2410         (ppc_linux_nat_target::read_description): Likewise.
2411         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2412         * s390-linux-nat.c: Likewise.
2413         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2414
2415 2019-03-24  Tom Tromey  <tom@tromey.com>
2416
2417         * ada-lang.c (standard_lookup): Simplify initialization.
2418         (ada_lookup_symbol_nonlocal): Simplify return.
2419         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2420         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2421         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2422         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2423         initialization.
2424         * solib.c (solib_global_lookup): Simplify.
2425         * symtab.c (null_block_symbol): Remove.
2426         (symbol_cache_lookup): Simplify returns.
2427         (lookup_language_this): Simplify returns.
2428         (lookup_symbol_aux): Simplify return.
2429         (lookup_local_symbol): Simplify returns.
2430         (lookup_global_symbol_from_objfile): Simplify return.
2431         (lookup_symbol_in_objfile_symtabs)
2432         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2433         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2434         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2435         * cp-namespace.c (cp_lookup_bare_symbol)
2436         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2437         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2438         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2439         (cp_lookup_symbol_via_imports): Simplify initialization.
2440         (find_symbol_in_baseclass): Likewise.
2441         * symtab.h (null_block_symbol): Remove.
2442         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2443         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2444         (d_lookup_symbol_module): Likewise.
2445         (find_symbol_in_baseclass): Simplify initialization.
2446
2447 2019-03-24  Tom Tromey  <tom@tromey.com>
2448
2449         * expression.h: Don't include symtab.h.
2450         (struct block): Forward declare.
2451
2452 2019-03-24  Tom Tromey  <tom@tromey.com>
2453
2454         * c-exp.y (typebase): Remove casts.
2455         * gdbtypes.c (lookup_unsigned_typename, )
2456         (lookup_signed_typename): Remove cast.
2457         * eval.c (parse_to_comma_and_eval): Remove cast.
2458         * parse.c (write_dollar_variable): Remove cast.
2459         * block.h (struct block) <superblock>: Now const.
2460         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2461         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2462         (map_block): Make "block" const.
2463         * symfile.h (struct quick_symbol_functions)
2464         <map_matching_symbols>: Constify block argument to "callback".
2465         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2466         const.
2467         (find_pc_sect_compunit_symtab): Make "b" const.
2468         (find_symbol_at_address): Likewise.
2469         (search_symbols): Likewise.
2470         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2471         (dw2_debug_names_lookup_symbol): Likewise.
2472         (dw2_map_matching_symbols): Update.
2473         * p-valprint.c (pascal_val_print): Remove "block".
2474         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2475         (aux_add_nonlocal_symbols): Make "block" const.
2476         (resolve_subexp): Remove cast.
2477         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2478         const.
2479         (iterate_over_file_blocks): Likewise.
2480         * f-exp.y (%union) <bval>: Remove.
2481         * coffread.c (patch_opaque_types): Make "b" const.
2482         * spu-tdep.c (spu_catch_start): Make "block" const.
2483         * c-valprint.c (print_unpacked_pointer): Remove "block".
2484         * symmisc.c (dump_symtab_1): Make "b" const.
2485         (block_depth): Make "block" const.
2486         * d-exp.y (%union) <bval>: Remove.
2487         * cp-support.h (cp_lookup_rtti_type): Update.
2488         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2489         * psymtab.c (psym_lookup_symbol): Make "block" const.
2490         (maintenance_check_psymtabs): Make "b" const.
2491         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2492         (enumerate_locals, enumerate_args): Update.
2493         * python/py-symtab.c (stpy_global_block): Make "block" const.
2494         (stpy_static_block): Likewise.
2495         * inline-frame.c (block_starting_point_at): Make "new_block"
2496         const.
2497         * block.c (find_block_in_blockvector): Make return type const.
2498         (blockvector_for_pc_sect): Make "b" const.
2499         (find_block_in_blockvector): Make "b" const.
2500
2501 2019-03-23  Tom Tromey  <tom@tromey.com>
2502
2503         * varobj.c (varobj_create): Update.
2504         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2505         * printcmd.c (display_command, do_one_display): Don't reset
2506         innermost_block.
2507         * parser-defs.h (enum innermost_block_tracker_type): Move to
2508         expression.h.
2509         (innermost_block): Update comment.
2510         * parse.c (parse_exp_1): Add tracker_types parameter.
2511         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2512         tracker_types parameter.  Reset innermost_block.
2513         (parse_exp_in_context): Remove.
2514         (parse_expression_for_completion): Update.
2515         * objfiles.c (~objfile): Don't reset expression_context_block or
2516         innermost_block.
2517         * expression.h (enum innermost_block_tracker_type): Move from
2518         parser-defs.h.
2519         (parse_exp_1): Add tracker_types parameter.
2520         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2521         reset innermost_block.
2522
2523 2019-03-23  Tom Tromey  <tom@tromey.com>
2524
2525         * objfiles.h: Include bcache.h.
2526
2527 2019-03-23  Tom Tromey  <tom@tromey.com>
2528
2529         * linespec.c (get_current_search_block): Use
2530         scoped_restore_current_language.
2531         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2532
2533 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2534             Jiong Wang  <jiong.wang@arm.com>
2535
2536         * aarch64-linux-tdep.c
2537         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2538         section.
2539         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2540
2541 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2542             Jiong Wang  <jiong.wang@arm.com>
2543
2544         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2545         instructions.
2546         (aarch64_analyze_prologue_test): Add PACIASP test.
2547         (aarch64_prologue_prev_register): Unmask PC value.
2548
2549 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2550             Jiong Wang  <jiong.wang@arm.com>
2551
2552         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2553         (aarch64_dwarf2_prev_register): Unmask PC value.
2554         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2555         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2556         DW_CFA_AARCH64_negate_ra_state.
2557         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2558
2559 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2560             Jiong Wang  <jiong.wang@arm.com>
2561
2562         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2563         registers.
2564         (aarch64_pseudo_register_name): Likewise.
2565         (aarch64_pseudo_register_type): Likewise.
2566         (aarch64_pseudo_register_reggroup_p): Likewise.
2567         (aarch64_gdbarch_init): Add pauth registers.
2568         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2569         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2570         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2571         (struct gdbarch_tdep): Add regnum for ra_state.
2572
2573 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2574             Jiong Wang  <jiong.wang@arm.com>
2575
2576         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2577
2578 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2579             Jiong Wang  <jiong.wang@arm.com>
2580
2581         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2582         function.
2583         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2584         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2585         (aarch64_gdbarch_init): Add puth registers.
2586         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2587         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2588         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2589
2590 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2591             Jiong Wang  <jiong.wang@arm.com>
2592
2593         * aarch64-linux-nat.c
2594         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2595         * aarch64-linux-tdep.c
2596         (aarch64_linux_core_read_description): Likewise.
2597         (aarch64_linux_get_hwcap): New function.
2598         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2599         (aarch64_linux_get_hwcap): New declaration.
2600
2601 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2602             Jiong Wang  <jiong.wang@arm.com>
2603
2604         * aarch64-linux-nat.c
2605         (aarch64_linux_nat_target::read_description): Add pauth param.
2606         * aarch64-linux-tdep.c
2607         (aarch64_linux_core_read_description): Likewise.
2608         * aarch64-tdep.c (struct target_desc): Add in pauth.
2609         (aarch64_read_description): Add pauth param.
2610         (aarch64_gdbarch_init): Likewise.
2611         * aarch64-tdep.h (aarch64_read_description): Likewise.
2612         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2613         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2614         * features/Makefile: Add new files.
2615         * features/aarch64-pauth.c: New file.
2616         * features/aarch64-pauth.xml: New file.
2617
2618 2019-03-20  Tom Tromey  <tromey@adacore.com>
2619
2620         * infrun.c (handle_inferior_event): Rename from
2621         handle_inferior_event_1.  Create a scoped_value_mark.
2622         (handle_inferior_event): Remove.
2623
2624 2019-03-19  Tom Tromey  <tromey@adacore.com>
2625
2626         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2627         * infrun.h (print_stop_event): Add "displays" parameter.
2628         * infrun.c (print_stop_event): Add "displays" parameter.
2629
2630 2019-03-19  Pedro Alves  <palves@redhat.com>
2631
2632         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2633         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2634         to -1.  Fix TABs vs spaces.
2635         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2636         * tui/tui-out.h (tui_ui_out) Add intro comments.
2637         <m_line, m_start_of_line>: In-class initialize, and add describing
2638         comment.
2639
2640 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2641
2642         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2643         variable names.
2644         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2645
2646 2019-03-18  Pedro Alves  <palves@redhat.com>
2647             Eli Zaretskii <eliz@gnu.org>
2648
2649         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2650         m_line and m_start_of_line.
2651
2652 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2653
2654         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2655         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2656         it returns a newline.  This fixes a regression in TU mode, whereby
2657         the next line is output on the same screen line as the user input.
2658
2659 2019-03-18  Tom Tromey  <tromey@adacore.com>
2660
2661         * minsyms.c (minimal_symbol_reader::install): Remove call to
2662         obstack_blank.
2663
2664 2019-03-18  Pedro Alves  <palves@redhat.com>
2665
2666         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2667         New globals.
2668         (apply_style): New, factored out from ...
2669         (apply_ansi_escape): ... this.  Handle reverse video mode.
2670         (tui_set_reverse_mode): New function.
2671         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2672         * tui/tui-winsource.c (tui_show_source_line): Use
2673         tui_set_reverse_mode instead of setting A_STANDOUT.
2674         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2675         New setter methods.
2676
2677 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2678
2679         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2680         Handle tabs.
2681
2682 2019-03-18  Tom Tromey  <tromey@adacore.com>
2683
2684         * ada-lang.c (empty_array): Add "high" parameter.
2685         (ada_evaluate_subexp): Update.
2686
2687 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2688
2689         * unittests/string_view-selftests.c: Define
2690         _initialize_string_view_selftests unconditionally.
2691
2692 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2693
2694         PR gdb/24350
2695         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2696
2697 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2698
2699         PR gdb/24351
2700         * windows-nat.c (display_selector): Fix format specifiers.
2701
2702 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2703
2704         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2705         tui_refill_source_window instead of tui_refresh_win, to update the
2706         current execution line.  This fixes redisplay of the current line
2707         when stepping through the code with "next" or "step".
2708
2709 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2710
2711         * source-cache.c (source_cache::get_source_lines): Call
2712         find_source_lines to initialize s->nlines.  This fixes vertical
2713         scrolling of TUI source window when the DOWN arrow is pressed.
2714
2715 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2716
2717         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2718         linux-thread-db.c (_initialize_thread_db): Likewise.
2719
2720 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2721
2722         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2723         wclrtoeol in tui_show_source_line".  This reverts changes made in
2724         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2725
2726 2019-03-15  Tom Tromey  <tom@tromey.com>
2727
2728         * symtab.h (struct minimal_symbol): Derive from
2729         general_symbol_info.
2730         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2731         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2732         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2733         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2734         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2735         (MSYMBOL_SEARCH_NAME): Update.
2736         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2737         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2738         * minsyms.c (minimal_symbol_reader::record_full): Update.
2739
2740 2019-03-15  Tom Tromey  <tom@tromey.com>
2741
2742         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2743
2744 2019-03-15  Tom Tromey  <tom@tromey.com>
2745
2746         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2747         unique_xmalloc_ptr.
2748         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2749         Update.
2750         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2751         (build_minimal_symbol_hash_tables)
2752         (minimal_symbol_reader::install): Update.
2753
2754 2019-03-15  Tom Tromey  <tom@tromey.com>
2755
2756         * symtab.c (create_demangled_names_hash): Update.
2757         (symbol_set_names): Update.
2758         * objfiles.h (struct objfile_per_bfd_storage)
2759         <demangled_names_hash>: Now an htab_up.
2760         * objfiles.c (objfile_per_bfd_storage): Simplify.
2761
2762 2019-03-15  Tom Tromey  <tom@tromey.com>
2763
2764         * objfiles.h (struct objfile_per_bfd_storage): Declare
2765         destructor.
2766         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2767         New.
2768         (get_objfile_bfd_data): Use new.  Don't initialize
2769         language_of_main.
2770         (free_objfile_per_bfd_storage): Remove.
2771         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2772
2773 2019-03-15  Tom Tromey  <tom@tromey.com>
2774
2775         * symfile.c (reread_symbols): Update.
2776         * objfiles.c (objfile::objfile): Update.
2777         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2778         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2779         comment.
2780         (minimal_symbol_reader::install): Update.
2781         (terminate_minimal_symbol_table): Remove.
2782         * jit.c (jit_object_close_impl): Update.
2783
2784 2019-03-15  Tom Tromey  <tom@tromey.com>
2785
2786         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2787         initializations.
2788
2789 2019-03-15  Tom Tromey  <tom@tromey.com>
2790
2791         * objfiles.h (struct objfile_per_bfd_storage)
2792         <demangled_hash_languages>: Now a bitset.
2793         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2794         (lookup_minimal_symbol): Update.
2795
2796 2019-03-15  Tom Tromey  <tom@tromey.com>
2797
2798         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2799         Don't return the symbol.
2800         * coffread.c (record_minimal_symbol): Use record_full.
2801
2802 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2803
2804         The MS-Windows port of ncurses fails to switch to a color pair if
2805         one or both of the colors are the implicit default colors.  This
2806         change records the default colors when TUI is initialized, and
2807         then specifies them explicitly when a color pair uses the default
2808         colors.  This allows color styling in TUI mode on MS-Windows.
2809
2810         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2811         ncurses_norm_attr.
2812         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2813         colors in ncurses_norm_attr.
2814         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2815         "none", replace it with the default color recorded in
2816         ncurses_norm_attr.
2817
2818 2019-03-14  Tom Tromey  <tromey@adacore.com>
2819
2820         * source-cache.h (class source_cache) <get_source_lines>: Return
2821         std::string.
2822         * source-cache.c (source_cache::extract_lines): Handle case where
2823         first_pos==npos.  Return std::string.
2824         (source_cache::get_source_lines): Update.
2825
2826 2019-03-14  Tom Tromey  <tromey@adacore.com>
2827
2828         * NEWS: Add item for "style sources" commands.
2829         * source-cache.c (source_cache::get_source_lines): Check
2830         source_styling.
2831         * cli/cli-style.c (source_styling): New global.
2832         (_initialize_cli_style): Add "style sources" commands.
2833         (show_style_sources): New function.
2834         * cli/cli-style.h (source_styling): Declare.
2835
2836 2019-03-14  Pedro Alves  <palves@redhat.com>
2837             Tom Tromey  <tromey@adacore.com>
2838
2839         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2840         * tui/tui-winsource.c (tui_refill_source_window): New function,
2841         from...
2842         (tui_horizontal_source_scroll): ... here.  Move some logic.
2843         * cli/cli-style.c (set_style_enabled): Notify new observable.
2844         * tui/tui-hooks.c (tui_redisplay_source): New function.
2845         (tui_attach_detach_observers): Attach or detach
2846         tui_redisplay_source.
2847         * observable.h (source_styling_changed): New observable.
2848         * observable.c: Define source_styling_changed observable.
2849
2850 2019-03-13  Tom Tromey  <tromey@adacore.com>
2851
2852         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2853         (i386_gnu_nat_target::store_registers): Update.
2854         * target-debug.h (target_debug_print_std_string): New macro.
2855         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2856         * windows-tdep.c (display_one_tib): Update.
2857         * tui/tui-stack.c (tui_make_status_line): Update.
2858         * top.c (print_inferior_quit_action): Update.
2859         * thread.c (thr_try_catch_cmd): Update.
2860         (add_thread_with_info): Update.
2861         (thread_target_id_str): Update.
2862         (thr_try_catch_cmd): Update.
2863         (thread_command): Update.
2864         (thread_find_command): Update.
2865         * record-btrace.c (record_btrace_target::info_record)
2866         (record_btrace_resume_thread, record_btrace_target::resume)
2867         (record_btrace_cancel_resume, record_btrace_step_thread)
2868         (record_btrace_target::wait, record_btrace_target::wait)
2869         (record_btrace_target::wait, record_btrace_target::stop): Update.
2870         * progspace.c (print_program_space): Update.
2871         * process-stratum-target.c
2872         (process_stratum_target::thread_address_space): Update.
2873         * linux-fork.c (linux_fork_mourn_inferior)
2874         (detach_checkpoint_command, info_checkpoints_command)
2875         (linux_fork_context): Update.
2876         (linux_fork_detach): Update.
2877         (class scoped_switch_fork_info): Update.
2878         (delete_checkpoint_command): Update.
2879         * infrun.c (follow_fork_inferior): Update.
2880         (follow_fork_inferior): Update.
2881         (proceed_after_vfork_done): Update.
2882         (handle_vfork_child_exec_or_exit): Update.
2883         (follow_exec): Update.
2884         (displaced_step_prepare_throw): Update.
2885         (displaced_step_restore): Update.
2886         (start_step_over): Update.
2887         (resume_1): Update.
2888         (clear_proceed_status_thread): Update.
2889         (proceed): Update.
2890         (print_target_wait_results): Update.
2891         (do_target_wait): Update.
2892         (context_switch): Update.
2893         (stop_all_threads): Update.
2894         (restart_threads): Update.
2895         (finish_step_over): Update.
2896         (handle_signal_stop): Update.
2897         (switch_back_to_stepped_thread): Update.
2898         (keep_going_pass_signal): Update.
2899         (print_exited_reason): Update.
2900         (normal_stop): Update.
2901         * inferior.c (inferior_pid_to_str): Change return type.
2902         (print_selected_inferior): Update.
2903         (add_inferior): Update.
2904         (detach_inferior): Update.
2905         * dummy-frame.c (fprint_dummy_frames): Update.
2906         * dcache.c (dcache_info_1): Update.
2907         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2908         (btrace_fetch, btrace_clear): Update.
2909         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2910         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2911         type.
2912         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2913         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2914         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2915         * gdbarch.c, gdbarch.h: Rebuild.
2916         * gdbarch.sh (core_pid_to_str): Change return type.
2917         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2918         return type.
2919         (windows_nat_target::pid_to_str): Change return type.
2920         (windows_delete_thread): Update.
2921         (windows_nat_target::attach): Update.
2922         (windows_nat_target::files_info): Update.
2923         * target-delegates.c: Rebuild.
2924         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2925         return type.
2926         (sol_thread_target::pid_to_str): Change return type.
2927         * remote.c (class remote_target) <pid_to_str>: Change return
2928         type.
2929         (remote_target::pid_to_str): Change return type.
2930         (extended_remote_target::attach, remote_target::remote_stop_ns)
2931         (remote_target::remote_notif_remove_queued_reply)
2932         (remote_target::push_stop_reply, remote_target::disable_btrace):
2933         Update.
2934         (extended_remote_target::attach): Update.
2935         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2936         type.
2937         (gdbsim_target::pid_to_str): Change return type.
2938         * ravenscar-thread.c (struct ravenscar_thread_target)
2939         <pid_to_str>: Change return type.
2940         (ravenscar_thread_target::pid_to_str): Change return type.
2941         * procfs.c (class procfs_target) <pid_to_str>: Change return
2942         type.
2943         (procfs_target::pid_to_str): Change return type.
2944         (procfs_target::attach): Update.
2945         (procfs_target::detach): Update.
2946         (procfs_target::fetch_registers): Update.
2947         (procfs_target::store_registers): Update.
2948         (procfs_target::wait): Update.
2949         (procfs_target::files_info): Update.
2950         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2951         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2952         return type.
2953         (nto_procfs_target::pid_to_str): Change return type.
2954         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2955         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2956         return type.
2957         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2958         (exit_lwp): Update.
2959         (attach_proc_task_lwp_callback, get_detach_signal)
2960         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2961         (linux_nat_target::resume, wait_lwp, stop_callback)
2962         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2963         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2964         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2965         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2966         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2967         type.
2968         (inf_ptrace_target::attach): Update.
2969         (inf_ptrace_target::files_info): Update.
2970         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2971         type.
2972         (go32_nat_target::pid_to_str): Change return type.
2973         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2974         (gnu_nat_target::wait): Update.
2975         (gnu_nat_target::wait): Update.
2976         (gnu_nat_target::resume): Update.
2977         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2978         (fbsd_nat_target::wait): Update.
2979         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2980         type.
2981         (darwin_nat_target::attach): Update.
2982         * corelow.c (class core_target) <pid_to_str>: Change return type.
2983         (core_target::pid_to_str): Change return type.
2984         * target.c (normal_pid_to_str): Change return type.
2985         (default_pid_to_str): Likewise.
2986         (target_pid_to_str): Change return type.
2987         (target_translate_tls_address): Update.
2988         (target_announce_detach): Update.
2989         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2990         return type.
2991         (bsd_uthread_target::pid_to_str): Change return type.
2992         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2993         type.
2994         (bsd_kvm_target::pid_to_str): Change return type.
2995         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2996         return type.
2997         (aix_thread_target::pid_to_str): Change return type.
2998         * target.h (struct target_ops) <pid_to_str>: Change return type.
2999         (target_pid_to_str, normal_pid_to_str): Likewise.
3000         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3001         type.
3002         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3003         type.
3004         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3005         return type.
3006         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3007         type.
3008         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3009         type.
3010         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3011         return type.
3012
3013 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3014
3015         * NEWS: Mention that the new default MI version is 3.  Mention
3016         changes to the output of commands and events that deal with
3017         multi-location breakpoints.
3018         * breakpoint.c: Include "mi/mi-out.h".
3019         (print_one_breakpoint): Change output syntax if using MI version
3020         >= 3.
3021         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3022         New.
3023         (mi_multi_location_breakpoint_output_fixed): New.
3024         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3025         (mi_cmd_fix_multi_location_breakpoint_output): New.
3026         (mi_multi_location_breakpoint_output_fixed): New.
3027         * mi/mi-cmds.c (mi_cmds): Register command
3028         -fix-multi-location-breakpoint-output.
3029         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3030         interpreter "mi".
3031
3032 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3033
3034         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3035         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3036         instantiate mi_ui_out based on interpreter name.
3037         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3038         * mi/mi-main.c (mi_load_progress): Likewise.
3039
3040 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3041
3042         * NEWS: Combine separate "New targets" sections for 8.3.
3043
3044 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3045
3046         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3047         (ppcfbsd_init_abi): Install gdbarch
3048         "fetch_tls_load_module_address" and "get_thread_local_address"
3049         methods.
3050
3051 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3052
3053         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3054         (riscv_fbsd_init_abi): Install gdbarch
3055         "fetch_tls_load_module_address" and "get_thread_local_address"
3056         methods.
3057
3058 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3059
3060         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3061         (i386fbsd_init_abi): Install gdbarch
3062         "fetch_tls_load_module_address" and "get_thread_local_address"
3063         methods.
3064
3065 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3066
3067         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3068         (amd64fbsd_init_abi): Install gdbarch
3069         "fetch_tls_load_module_address" and "get_thread_local_address"
3070         methods.
3071
3072 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3073
3074         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3075         (struct fbsd_pspace_data): New type.
3076         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3077         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3078         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3079         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3080         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3081
3082 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3083
3084         * gdbtypes.c (lookup_struct_elt): New function.
3085         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3086         * gdbtypes.h (struct struct_elt): New type.
3087         (lookup_struct_elt): New prototype.
3088
3089 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3090
3091         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3092         remove disabled code block.
3093
3094 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3095
3096         * gdbarch.sh (get_thread_local_address): New method.
3097         * gdbarch.h, gdbarch.c: Regenerate.
3098         * target.c (target_translate_tls_address): Use
3099         gdbarch_get_thread_local_address if present instead of
3100         target::get_thread_local_address.
3101
3102 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3103
3104         * target.h (target::get_thread_local_address): Update comment.
3105
3106 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3107
3108         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3109         objfile->separate_debug_objfile_backlink if not NULL.
3110
3111 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3112
3113         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3114         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3115         (amd64bsd_store_inferior_registers): Likewise.
3116         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3117         Enable segment base registers.
3118         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3119         PT_GETFSBASE and PT_GETGSBASE.
3120         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3121         PT_SETGSBASE.
3122         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3123         segment base registers.
3124         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3125
3126 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3127
3128         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3129         Update calls to i386_target_description to add 'segments'
3130         parameter.
3131         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3132         add segment base registers.
3133         * arch/i386.c (i386_create_target_description): Add 'segments'
3134         parameter to enable segment base registers.
3135         * arch/i386.h (i386_create_target_description): Likewise.
3136         * features/i386/32bit-segments.xml: New file.
3137         * features/i386/32bit-segments.c: Generate.
3138         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3139         call to i386_target_description to add 'segments' parameter.
3140         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3141         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3142         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3143         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3144         if feature is present.
3145         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3146         Add 'segments' parameter to call to i386_target_description.
3147         (i386_target_description): Add 'segments' parameter to enable
3148         segment base registers.
3149         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3150         to call to i386_target_description.
3151         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3152         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3153         Define I386_NUM_REGS.
3154         (i386_target_description): Add 'segments' parameter to enable
3155         segment base registers.
3156
3157 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3158
3159         PR/24325
3160         * source-cache.c: #undef open and close, to avoid unresolved
3161         externals during linking.
3162
3163 2019-03-12  Tom Tromey  <tromey@adacore.com>
3164
3165         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3166         const.  Add initializers.
3167         (_initialize_remote): Don't initialize ptid globals.
3168
3169 2019-03-12  Pedro Alves  <palves@redhat.com>
3170
3171         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3172
3173 2019-03-12  Pedro Alves  <palves@redhat.com>
3174
3175         * cp-name-parser.y (main): Remove unused 'len' variable.
3176
3177 2019-03-12  Tom Tromey  <tromey@adacore.com>
3178
3179         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3180         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3181
3182 2019-03-12  Tom Tromey  <tromey@adacore.com>
3183
3184         * linux-nat.c (iterate_over_lwps): Update.
3185         (stop_callback): Remove parameter.
3186         (stop_wait_callback, detach_callback, resume_set_callback)
3187         (select_singlestep_lwp_callback, set_ignore_sigint)
3188         (status_callback, resumed_callback, resume_clear_callback)
3189         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3190         data parameter.
3191         (linux_nat_target::detach, linux_nat_target::resume)
3192         (linux_stop_and_wait_all_lwps, select_event_lwp)
3193         (linux_nat_filter_event, linux_nat_wait_1)
3194         (linux_nat_target::kill, linux_nat_target::stop)
3195         (linux_nat_target::stop): Update.
3196         (linux_nat_resume_callback): Change type.
3197         (resume_stopped_resumed_lwps, count_events_callback)
3198         (select_event_lwp_callback): Likewise.
3199         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3200         * arm-linux-nat.c (struct update_registers_data): Remove.
3201         (update_registers_callback): Change type.
3202         (arm_linux_insert_hw_breakpoint1): Update.
3203         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3204         parameter.
3205         (x86_linux_dr_set_addr): Update.
3206         (x86_linux_dr_set_control): Update.
3207         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3208         (iterate_over_lwps): Use gdb::function_view.
3209         * nat/aarch64-linux-hw-point.c (struct
3210         aarch64_dr_update_callback_param): Remove.
3211         (debug_reg_change_callback): Change type.
3212         (aarch64_notify_debug_reg_change): Update.
3213         * s390-linux-nat.c (s390_refresh_per_info): Update.
3214
3215 2019-03-11  Tom Tromey  <tromey@adacore.com>
3216
3217         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3218         redundant assignment to "this_cu".
3219
3220 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3221
3222         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3223
3224 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3225
3226         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3227         from...
3228         (rank_one_type): ... this.
3229
3230 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3231
3232         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3233         from...
3234         (rank_one_type): ... this.
3235
3236 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3237
3238         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3239         from...
3240         (rank_one_type): ... this.
3241
3242 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3243
3244         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3245         from...
3246         (rank_one_type): ... this.
3247
3248 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3249
3250         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3251         from...
3252         (rank_one_type): ... this.
3253
3254 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3255
3256         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3257         from...
3258         (rank_one_type): ... this.
3259
3260 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3261
3262         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3263         from...
3264         (rank_one_type): ... this.
3265
3266 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3267
3268         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3269         from...
3270         (rank_one_type): ... this.
3271
3272 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3273
3274         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3275         from...
3276         (rank_one_type): ... this.
3277
3278 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3279
3280         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3281         from...
3282         (rank_one_type): ... this.
3283
3284 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3285
3286         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3287         from...
3288         (rank_one_type): ... this.
3289
3290 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3291
3292         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3293         from...
3294         (rank_one_type): ... this.
3295
3296 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3297
3298         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3299         inferior-events' shows the example events.
3300
3301 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3302
3303         Support styling on native MS-Windows console
3304
3305         PR/24315
3306         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3307         on MS-Windows if $TERM is not defined.
3308
3309         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3310
3311         * posix-hdep.c (gdb_console_fputs):
3312         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3313         functions.
3314         * ui-file.h (gdb_console_fputs): Add prototype.
3315
3316         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3317         back to fputs only if the former returns zero.
3318
3319 2019-03-07  Tom Tromey  <tom@tromey.com>
3320
3321         * symmisc.c (print_symbol_bcache_statistics): Update.
3322         (print_objfile_statistics): Update.
3323         * symfile.c (allocate_symtab): Update.
3324         * stabsread.c: Don't include bcache.h.
3325         * psymtab.h (struct psymbol_bcache): Don't declare.
3326         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3327         (psymbol_bcache_init, psymbol_bcache_free)
3328         (psymbol_bcache_get_bcache): Don't declare.
3329         * psymtab.c (struct psymbol_bcache): Remove.
3330         (psymtab_storage::psymtab_storage): Update.
3331         (psymtab_storage::~psymtab_storage): Update.
3332         (psymbol_bcache_init, psymbol_bcache_free)
3333         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3334         (add_psymbol_to_bcache): Update.
3335         (allocate_psymtab): Update.
3336         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3337         macro_cache>: No longer pointers.
3338         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3339         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3340         * macrotab.c (macro_bcache): Update.
3341         * macroexp.c: Don't include bcache.h.
3342         * gdbtypes.c (check_types_worklist): Update.
3343         (types_deeply_equal): Remove TRY/CATCH.  Update.
3344         * elfread.c (elf_symtab_read): Update.
3345         * dwarf2read.c: Don't include bcache.h.
3346         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3347         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3348         (print_bcache_statistics, bcache_memory_used): Don't declare.
3349         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3350         methods.  Rename all data members.
3351         * bcache.c (struct bcache): Move to bcache.h.
3352         (bcache::expand_hash_table): Rename from expand_hash_table.
3353         (bcache): Remove.
3354         (bcache::insert): Rename from bcache_full.
3355         (bcache::compare): Rename from bcache_compare.
3356         (bcache_xmalloc): Remove.
3357         (bcache::~bcache): Rename from bcache_xfree.
3358         (bcache::print_statistics): Rename from print_bcache_statistics.
3359         (bcache::memory_used): Rename from bcache_memory_used.
3360
3361 2019-03-07  Pedro Alves  <palves@redhat.com>
3362
3363         * infrun.c (normal_stop): Also check for
3364         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3365
3366 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3367
3368         * f-lang.c (value_from_host_double): Moved to...
3369         * value.c (value_from_host_double): ...here.
3370         * value.h (value_from_host_double): Declare.
3371         * guile/scm-math.c (vlscm_convert_typed_number): Use
3372         value_from_host_double.
3373         (vlscm_convert_number): Likewise.
3374         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3375         * python/py-value.c (convert_value_from_python): Likewise.
3376
3377 2019-03-06  Tom Tromey  <tom@tromey.com>
3378
3379         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3380
3381 2019-03-06  Tom Tromey  <tom@tromey.com>
3382
3383         * utils.h (free_current_contents): Don't declare.
3384         * utils.c (free_current_contents): Remove.
3385
3386 2019-03-06  Tom Tromey  <tom@tromey.com>
3387
3388         * top.c (quit_force): Update.
3389         * main.c (captured_command_loop): Update.
3390         * common/new-op.c (operator new): Update.
3391         * common/common-exceptions.c (struct catcher)
3392         <save_cleanup_chain>: Remove member.
3393         (exceptions_state_mc_init): Update.
3394         (exception_try_scope_entry): Return nullptr.
3395         (exception_try_scope_exit, exception_rethrow)
3396         (throw_exception_sjlj, throw_exception_cxx): Update.
3397         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3398         (all_cleanups, do_cleanups, discard_cleanups)
3399         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3400         (restore_cleanups, restore_final_cleanups): Don't declare.
3401         (do_final_cleanups): Remove parameter.
3402         * common/cleanups.c (cleanup_chain, make_cleanup)
3403         (make_cleanup_dtor, all_cleanups, do_cleanups)
3404         (discard_my_cleanups, discard_cleanups)
3405         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3406         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3407         (null_cleanup): Remove.
3408         (do_final_cleanups): Remove parameter.
3409
3410 2019-03-06  Tom Tromey  <tom@tromey.com>
3411
3412         * remote.c (remote_target::remote_parse_stop_reply): Use
3413         unique_xmalloc_ptr.
3414
3415 2019-03-06  Tom Tromey  <tom@tromey.com>
3416
3417         * stabsread.c (struct stabs_field_info): Rename from field_info.
3418         <list, fnlist>: Add initializers.
3419         <obstack>: New member.
3420         (read_member_functions, read_struct_fields, read_baseclasses):
3421         Allocate on obstack.  Don't use cleanups.
3422         (read_one_struct_field, read_member_functions, read_struct_fields)
3423         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3424         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3425         (read_struct_type): Update.
3426
3427 2019-03-06  Tom Tromey  <tom@tromey.com>
3428
3429         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3430         * common/filestuff.h (make_cleanup_close): Don't declare.
3431         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3432         Remove.
3433
3434 2019-03-06  Tom Tromey  <tom@tromey.com>
3435
3436         * solib-aix.c: Use make_scope_exit.
3437
3438 2019-03-06  Tom Tromey  <tom@tromey.com>
3439
3440         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3441         Use make_scope_exit.
3442
3443 2019-03-06  Tom Tromey  <tom@tromey.com>
3444
3445         * solib-svr4.c (disable_probes_interface): Remove parameter.
3446         (svr4_handle_solib_event): Use make_scope_exit.
3447
3448 2019-03-06  Tom Tromey  <tom@tromey.com>
3449
3450         * remote.c (struct stop_reply_deleter): Remove.
3451         (stop_reply_up): Update.
3452         (struct stop_reply): Derive from notif_event.  Don't typedef.
3453         <regcache>: Now a std::vector.
3454         (stop_reply_xfree): Remove.
3455         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3456         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3457         (remote_target::discard_pending_stop_replies): Use delete.
3458         (remote_target::remote_parse_stop_reply): Update.
3459         (remote_target::process_stop_reply): Update.
3460         * remote-notif.h (struct notif_event): Add virtual destructor.
3461         Remove "dtr" member.
3462         (struct notif_client) <alloc_event>: Return a unique_ptr.
3463         (notif_event_xfree): Don't declare.
3464         (notif_event_up): New typedef.
3465         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3466         (notif_event_xfree, do_notif_event_xfree): Remove.
3467         (remote_notif_state_xfree): Update.
3468
3469 2019-03-06  Tom Tromey  <tom@tromey.com>
3470
3471         * infrun.c (displaced_step_clear_cleanup): Now a
3472         forward_scope_exit type.
3473         (displaced_step_prepare_throw): Update.
3474         (displaced_step_fixup): Update.
3475
3476 2019-03-06  Tom Tromey  <tom@tromey.com>
3477
3478         * inferior.h (class inferior): Update comment.
3479         * gdbthread.h (class thread_info): Update comment.
3480
3481 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3482             Tom Tromey  <tom@tromey.com>
3483
3484         * stabsread.h (struct stab_section_list): Remove.
3485         (coffstab_build_psymtabs): Update.
3486         * dbxread.c (symbuf_sections): Now a std::vector.
3487         (sect_idx): New global.
3488         (fill_symbuf): Update.
3489         (coffstab_build_psymtabs): Change type of stabsects parameter.
3490         Update.
3491         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3492         std::vector.
3493         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3494         (coff_locate_sections): Update.
3495         (coff_symfile_read): Remove cleanups.  Update.
3496         (init_stringtab): Add storage parameter.
3497         (free_stringtab, free_stringtab_cleanup): Remove.
3498         (init_lineno): Add storage parameter.
3499         (free_linetab, free_linetab_cleanup): Remove.
3500
3501 2019-03-06  Pedro Alves  <palves@redhat.com>
3502
3503         * linux-fork.c (fork_info::clobber_regs): Delete.
3504         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3505         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3506         comment.  Adjust.
3507         (scoped_switch_fork_info::scoped_switch_fork_info)
3508         (checkpoint_command, linux_fork_context): Adjust
3509         fork_save_infrun_state calls.
3510
3511 2019-03-06  Pedro Alves  <palves@redhat.com>
3512
3513         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3514         (inf_has_multiple_threads): Return 'bool' and rewrite using
3515         inferior_info::threads().
3516
3517 2019-03-06  Pedro Alves  <palves@redhat.com>
3518
3519         * linux-fork.c: Include <list>.
3520         (fork_list): Now a std::list instance.
3521         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3522         (forks_exist_p, find_last_fork): Adjust.
3523         (new_fork): Delete.
3524         (one_fork_p): New.
3525         (add_fork): Adjust.
3526         (free_fork): Delete, folded into fork_info::~fork_info().
3527         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3528         Adjust.
3529         (init_fork_list): Delete.
3530         (linux_fork_killall, linux_fork_mourn_inferior)
3531         (linux_fork_detach, info_checkpoints_command): Adjust.
3532         (_initialize_linux_fork): No longer call init_fork_list.
3533
3534 2019-03-06  Pedro Alves  <palves@redhat.com>
3535
3536         * linux-fork.c (new_fork): New, split out of ...
3537         (add_fork): ... this.  Return void.  Move "first fork" special
3538         case from here, to ...
3539         (checkpoint_command): ... here.
3540         * linux-linux.h (add_fork): Return void.
3541
3542 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3543
3544         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3545
3546 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3547             Chris January  <chris.january@arm.com>
3548             David Lecomber  <david.lecomber@arm.com>
3549
3550         * f-exp.y: New token, UNOP_INTRINSIC.
3551         (exp): New pattern using UNOP_INTRINSIC token.
3552         (f77_keywords): Add 'abs' keyword.
3553         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3554         (value_from_host_double): New function.
3555         (evaluate_subexp_f): Support UNOP_ABS.
3556
3557 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3558
3559         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3560         types.
3561
3562 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3563
3564         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3565         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3566         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3567
3568 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3569
3570         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3571
3572 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3573             Chris January  <chris.january@arm.com>
3574
3575         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3576         * f-exp.y: Define 'KIND' token.
3577         (exp): New pattern for KIND expressions.
3578         (ptype): Handle types with a kind extension.
3579         (direct_abs_decl): Extend to spot kind extensions.
3580         (f77_keywords): Add 'kind' to the list.
3581         (push_kind_type): New function.
3582         (convert_to_kind_type): New function.
3583         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3584         * parse.c (operator_length_standard): Likewise.
3585         * parser-defs.h (enum type_pieces): Add tp_kind.
3586         * std-operator.def: Add UNOP_KIND.
3587
3588 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3589
3590         * f-exp.y (f_parse): Set yydebug.
3591
3592 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3593
3594         * f-lang.c (evaluate_subexp_f): New function.
3595         (exp_descriptor_f): New global.
3596         (f_language_defn): Use exp_descriptor_f instead of
3597         exp_descriptor_standard.
3598
3599 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3600
3601         * f-exp.y (struct token): Add comments.
3602         (dot_ops): Remove uppercase versions and the end marker.
3603         (f77_keywords): Likewise.
3604         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3605         entries in the dot_ops array are case insensitive, and use
3606         strncasecmp to compare strings.  Also some whitespace cleanup in
3607         this area.  Similar for the f77_keywords array, except entries in
3608         this list might be case sensitive.
3609
3610 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3611
3612         * f-exp.y (struct f77_boolean_val): Add comments.
3613         (boolean_values): Remove uppercase versions, and end marker.
3614         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3615         and use strncasecmp to achieve case insensitivity.  Additionally,
3616         perform whitespace cleanup around this code.
3617
3618 2019-03-06  Tom Tromey  <tromey@adacore.com>
3619
3620         * remote-sim.c (gdbsim_target_open): Use result of
3621         gdb_argv::release.
3622
3623 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3624         Dirk Schubert  <dirk.schubert@arm.com>
3625         Chris January  <chris.january@arm.com>
3626
3627         * eval.c (evaluate_subexp_standard): Call Fortran argument
3628         wrapping logic.
3629         * f-lang.c (struct value): A value which can be passed into a
3630         Fortran function call.
3631         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3632         where appropriate.
3633         (struct type): Value ready for a Fortran function call.
3634         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3635         is needed.
3636         * f-lang.h (fortran_argument_convert): Declaration.
3637         (fortran_preserve_arg_pointer): Declaration.
3638         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3639
3640 2019-03-05  Tom Tromey  <tromey@adacore.com>
3641
3642         * python/py-prettyprint.c (print_string_repr): Remove #if.
3643         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3644
3645 2019-03-05  Tom Tromey  <tromey@adacore.com>
3646
3647         * target.c (the_dummy_target): Move later.  Change type to
3648         "dummy_target".
3649         (initialize_targets): Don't initialize the_dummy_target.
3650
3651 2019-03-05  Tom Tromey  <tromey@adacore.com>
3652
3653         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3654         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3655
3656 2019-03-05  Tom Tromey  <tromey@adacore.com>
3657
3658         * windows-nat.c (windows_nat_target::attach)
3659         (windows_nat_target::detach): Don't call gdb_flush.
3660         * valprint.c (generic_val_print, val_print, val_print_string):
3661         Don't call gdb_flush.
3662         * utils.c (defaulted_query): Don't call gdb_flush.
3663         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3664         * target.c (target_announce_detach): Don't call gdb_flush.
3665         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3666         * remote.c (extended_remote_target::attach): Don't call
3667         gdb_flush.
3668         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3669         * printcmd.c (do_examine): Don't call gdb_flush.
3670         (info_display_command): Don't call gdb_flush.
3671         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3672         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3673         * memattr.c (info_mem_command): Don't call gdb_flush.
3674         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3675         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3676         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3677         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3678         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3679         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3680         (gnu_nat_target::detach): Don't call gdb_flush.
3681         * f-valprint.c (f_val_print): Don't call gdb_flush.
3682         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3683         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3684         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3685         gdb_flush.
3686         * c-valprint.c (c_val_print): Don't call gdb_flush.
3687         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3688
3689 2019-03-05  Tom Tromey  <tromey@adacore.com>
3690
3691         * varobj.c (update_dynamic_varobj_children): Update.
3692         (install_default_visualizer): Use reset, not release.
3693         * value.c (set_internalvar): Update.
3694         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3695         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3696         ATTRIBUTE_UNUSED_RESULT.
3697
3698 2019-03-05  Tom Tromey  <tromey@adacore.com>
3699
3700         * remote.c (class scoped_remote_fd) <release>: Add
3701         ATTRIBUTE_UNUSED_RESULT.
3702
3703 2019-03-05  Tom Tromey  <tromey@adacore.com>
3704
3705         * macroexp.c (struct macro_buffer) <release>: Add
3706         ATTRIBUTE_UNUSED_RESULT.
3707
3708 2019-03-05  Tom Tromey  <tromey@adacore.com>
3709
3710         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3711         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3712         ATTRIBUTE_UNUSED_RESULT.
3713
3714 2019-03-05  Tom Tromey  <tromey@adacore.com>
3715
3716         * common/scoped_fd.h (class scoped_fd) <release>: Add
3717         ATTRIBUTE_UNUSED_RESULT.
3718
3719 2019-03-05  Tom Tromey  <tromey@adacore.com>
3720
3721         * parser-defs.h (struct parser_state) <release>: Add
3722         ATTRIBUTE_UNUSED_RESULT.
3723
3724 2019-03-05  Tom Tromey  <tromey@adacore.com>
3725
3726         * utils.h (class gdb_argv) <release>: Add
3727         ATTRIBUTE_UNUSED_RESULT.
3728         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3729
3730 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3731
3732         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3733         for-loop range, to avoid compiler warnings.
3734
3735         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3736         avoid compiler warnings about unused variables.
3737
3738         * NEWS: Mention end of support for native debugging on MS-Windows
3739         before XP.
3740
3741         PR gdb/24292
3742         * common/netstuff.c:
3743         * gdbserver/gdbreplay.c
3744         * gdbserver/remote-utils.c:
3745         * ser-tcp.c:
3746         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3747         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3748         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3749         'getaddrinfo' and 'freeaddrinfo' were not available before
3750         Windows XP, and mingw.org's MinGW headers by default define
3751         _WIN32_WINNT to 0x500.
3752
3753 2019-03-01  Gary Benson <gbenson@redhat.com>
3754
3755         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3756
3757 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3758             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3759
3760         PR gdb/8527
3761         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3762         set_sigint_trap, clear_sigint_trap.
3763
3764 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3765
3766         * target.c (target_detach): Clear the regcache and the
3767         frame cache.
3768
3769 2019-02-27  Pedro Alves  <palves@redhat.com>
3770
3771         * utils.c (set_screen_size): When we cap the height/width sizes,
3772         tweak the corresponding command variable to show "unlimited":
3773
3774 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3775             Pedro Alves  <palves@redhat.com>
3776
3777         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3778         before calling rl_set_screen_size.
3779
3780 2019-02-27  Tom Tromey  <tromey@adacore.com>
3781
3782         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3783         define.
3784         * python/py-value.c: Remove Python 2.4 workaround.
3785         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3786         workaround.
3787         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3788         Python 2.4 workaround.
3789         * python/python-internal.h: Remove Python 2.4 comment.
3790         (Py_ssize_t): Don't define.
3791         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3792         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3793         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3794         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3795         * python/python.c (do_start_initialization): Remove Python 2.4
3796         workaround.
3797         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3798         (print_children): Remove Python 2.4 workaround.
3799         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3800         workaround.
3801         (CHARBUFFERPROC_NAME): Remove.
3802         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3803         Python 2.4 workaround.
3804
3805 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3806
3807         * NEWS: Note minimum Python version.
3808
3809 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3810
3811         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3812         code from these functions.  Remove corresponding ifdefs.  Use
3813         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3814         Remove gotos and target of gotos.
3815         (infpy_search_memory): Likewise.
3816
3817 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3818
3819         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3820         (hppa_gdbarch_init): Don't register deleted functions with
3821         gdbarch.
3822
3823 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3824
3825         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3826         (h8300_unwind_sp): Delete.
3827         (h8300_dummy_id): Delete.
3828         (h8300_gdbarch_init): Don't register deleted functions with
3829         gdbarch.
3830
3831 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3832
3833         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3834         (ft32_unwind_pc): Delete.
3835         (ft32_unwind_sp): Delete.
3836         (ft32_gdbarch_init): Don't register deleted functions with
3837         gdbarch.
3838
3839 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3840
3841         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3842         (frv_unwind_pc): Delete.
3843         (frv_unwind_sp): Delete.
3844         (frv_gdbarch_init): Don't register deleted functions with
3845         gdbarch.
3846
3847 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3848
3849         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3850         (riscv_unwind_pc): Delete.
3851         (riscv_unwind_sp): Delete.
3852         (riscv_gdbarch_init): Don't register deleted functions with
3853         gdbarch.
3854
3855 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3856
3857         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3858         (csky_unwind_pc): Delete.
3859         (csky_unwind_sp): Delete.
3860         (csky_gdbarch_init): Don't register deleted functions with
3861         gdbarch.
3862
3863 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3864
3865         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3866         (cris_unwind_pc): Delete.
3867         (cris_unwind_sp): Delete.
3868         (cris_gdbarch_init): Don't register deleted functions with
3869         gdbarch.
3870
3871 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3872
3873         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3874         (bfin_unwind_pc): Delete.
3875         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3876
3877 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3878
3879         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3880         (arm_unwind_pc): Delete.
3881         (arm_unwind_sp): Delete.
3882         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3883
3884 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3885
3886         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3887         (arc_unwind_pc): Delete.
3888         (arc_unwind_sp): Delete.
3889         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3890
3891 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3892
3893         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3894         (alpha_unwind_pc): Delete.
3895         (alpha_gdbarch_init): Don't register deleted functions with
3896         gdbarch.
3897
3898 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3899
3900         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3901         (aarch64_unwind_pc): Delete.
3902         (aarch64_unwind_sp): Delete.
3903         (aarch64_gdbarch_init): Don't register deleted functions with
3904         gdbarch.
3905
3906 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3907
3908         * gdbtypes.c (type_align): Don't consider static members when
3909         computing structure alignment.
3910
3911 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3912
3913         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3914         return 0 for other types.
3915         * arch-utils.c (default_type_align): Always return 0.
3916         * gdbarch.h: Regenerate.
3917         * gdbarch.sh (type_align): Extend comment.
3918         * gdbtypes.c (type_align): Add additional comments, always call
3919         gdbarch_type_align before applying the default rules.
3920         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3921         generic code will then apply a suitable default.
3922         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3923         types, return 0 for other types.
3924
3925 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3926
3927         * NEWS: Create a new section for the next release branch.
3928         Rename the section of the current branch, now that it has
3929         been cut.
3930
3931 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3932
3933         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3934         * version.in: Bump version to 8.3.50.DATE-git.
3935
3936 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3937
3938         * aix-thread.c (ptid_cmp): Remove unused variable.
3939         (get_signaled_thread): Likewise.
3940         (store_regs_user_thread): Likewise.
3941         (store_regs_kernel_thread): Likewise.
3942         (fetch_regs_kernel_thread): Remove shadowed variable.
3943
3944 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3945
3946         * features/riscv/32bit-cpu.xml: Add register numbers.
3947         * features/riscv/32bit-fpu.c: Regenerate.
3948         * features/riscv/32bit-fpu.xml: Add register numbers.
3949         * features/riscv/64bit-cpu.xml: Add register numbers.
3950         * features/riscv/64bit-fpu.c: Regenerate.
3951         * features/riscv/64bit-fpu.xml: Add register numbers.
3952
3953 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3954
3955         * NEWS: Mention two argument form of gdb.Value constructor.
3956         * python/py-value.c (convert_buffer_and_type_to_value): New
3957         function.
3958         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3959         Add support for handling an optional second argument.  Call
3960         convert_buffer_and_type_to_value as appropriate.
3961         * python/python-internal.h (Py_buffer_deleter): New struct.
3962         (Py_buffer_up): New typedef.
3963
3964 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3965
3966         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3967         instead of releasing ownership.
3968
3969 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3970
3971         * dwarf2read.c (open_and_init_dwp_file): Call
3972         elf_numsections instead of bfd_count_sections to initialize
3973         dwp_file->num_sections.
3974
3975 2019-02-25  Tom Tromey  <tromey@adacore.com>
3976
3977         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3978
3979 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3980
3981         * gcore.in: Add '--readnever' option when invoking GDB.
3982
3983 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3984
3985         * MAINTAINERS: Update my email address.
3986
3987 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3988
3989         * build-id.c (build_id_to_debug_bfd_1): New function.
3990         (build_id_to_debug_bfd): Look for separate debug file in
3991         sysroot.
3992
3993 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3994
3995         * gdbarch.sh: Update the copyright year range that is placed into
3996         generated files.
3997
3998 2019-02-22  Keith Seitz  <keiths@redhat.com>
3999
4000         PR symtab/23853
4001         * linespec.c (create_sals_line_offset): Search for the default
4002         symtab's filename instead of its fullname.
4003
4004 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4005
4006         * NEWS: Update style defaults.
4007
4008 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4009
4010         * main.c (captured_main_1): Disable styling in batch mode.
4011
4012 2019-02-20  Tom Tromey  <tom@tromey.com>
4013
4014         * symtab.c (symtab_symbol_info): Fix typos.
4015
4016 2019-02-20  Tom Tromey  <tromey@adacore.com>
4017
4018         * findcmd.c (_initialize_mem_search): Use upper case for
4019         metasyntactic variables.
4020
4021 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4022
4023         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4024         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4025
4026 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4027
4028         * top.h (source_file_name): Change to std::string.
4029         * top.c (source_file_name): Likewise.
4030         (command_line_input): Adjust.
4031         * cli/cli-script.c (script_from_file): Adjust.
4032
4033 2019-02-19  Tom Tromey  <tromey@adacore.com>
4034
4035         * ravenscar-thread.c
4036         (ravenscar_thread_target::update_thread_list): Don't call
4037         ada_build_task_list.
4038         * ada-lang.h (ada_build_task_list): Don't declare.
4039         * ada-tasks.c (struct ada_tasks_inferior_data)
4040         <task_list_valid_p>: Now bool.
4041         (read_known_tasks, ada_task_list_changed)
4042         (ada_tasks_invalidate_inferior_data): Update.
4043         (read_known_tasks_array): Return bool.
4044         (read_known_tasks_list): Likewise.
4045         (read_known_tasks): Return void.
4046         (ada_build_task_list): Now static.
4047
4048 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4049
4050         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4051         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4052
4053 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4054
4055         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4056         variant for ada_tasks_pspace_data_handle and
4057         ada_tasks_inferior_data_handle.
4058         (ada_tasks_pspace_data_cleanup): New function.
4059         (ada_tasks_inferior_data_cleanup): New function.
4060
4061 2019-02-17  Tom Tromey  <tom@tromey.com>
4062
4063         * macrotab.h (macro_source_fullname): Return a std::string.
4064         * macrotab.c (macro_include, check_for_redefinition)
4065         (macro_undef, macro_lookup_definition, foreach_macro)
4066         (foreach_macro_in_scope): Update.
4067         (macro_source_fullname): Return a std::string.
4068         * macrocmd.c (show_pp_source_pos): Update.
4069
4070 2019-02-17  Tom Tromey  <tom@tromey.com>
4071
4072         * macrocmd.c (show_pp_source_pos): Style the file names.
4073
4074 2019-02-17  Tom Tromey  <tom@tromey.com>
4075
4076         PR tui/24197:
4077         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4078
4079 2019-02-17  Tom Tromey  <tom@tromey.com>
4080
4081         * ada-lang.c (user_select_syms): Use filtered printing.
4082         * utils.c (wrap_style): New global.
4083         (desired_style): Remove.
4084         (emit_style_escape): Add stream parameter.
4085         (set_output_style, reset_terminal_style, prompt_for_continue):
4086         Update.
4087         (flush_wrap_buffer): Only flush gdb_stdout.
4088         (wrap_here): Set wrap_style.
4089         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4090         treat escape sequences as a character.  Change when wrap buffer is
4091         flushed.
4092         (fputs_styled): Do not set the output style when the default is
4093         requested.
4094         * ui-style.h (struct ui_file_style) <is_default>: New method.
4095         * source.c (print_source_lines_base): Emit escape sequences in one
4096         piece.
4097
4098 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4099
4100         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4101         integers and enumeration types.
4102
4103 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4104
4105         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4106         instead of lookup_symbol_in_language
4107         (do_exact_match): New function.
4108         (ada_get_symbol_name_matcher): Return do_exact_match when
4109         doing a verbatim match.
4110
4111 2019-02-15  Tom Tromey  <tromey@adacore.com>
4112
4113         * ravenscar-thread.c (ravenscar_thread_target::resume)
4114         (ravenscar_thread_target::wait): Special case wildcard requests.
4115
4116 2019-02-15  Tom Tromey  <tromey@adacore.com>
4117
4118         * ravenscar-thread.c (base_ptid): Remove.
4119         (struct ravenscar_thread_target) <close>: New method.
4120         <m_base_ptid>: New member.
4121         <update_inferior_ptid, active_task, task_is_currently_active,
4122         runtime_initialized>: Declare methods.
4123         <ravenscar_thread_target>: Add constructor.
4124         (ravenscar_thread_target::task_is_currently_active)
4125         (ravenscar_thread_target::update_inferior_ptid)
4126         (ravenscar_runtime_initialized): Rename.  Now methods.
4127         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4128         (ravenscar_thread_target::update_thread_list): Update.
4129         (ravenscar_thread_target::active_task): Now method.
4130         (ravenscar_thread_target::store_registers)
4131         (ravenscar_thread_target::prepare_to_store)
4132         (ravenscar_thread_target::prepare_to_store)
4133         (ravenscar_thread_target::mourn_inferior): Update.
4134         (ravenscar_inferior_created): Use "new" to create target.
4135         (ravenscar_thread_target::get_ada_task_ptid): Update.
4136         (_initialize_ravenscar): Don't initialize base_ptid.
4137         (ravenscar_ops): Remove global.
4138
4139 2019-02-15  Tom Tromey  <tromey@adacore.com>
4140
4141         * target.h (push_target): Declare new overload.
4142         * target.c (push_target): New overload, taking an rvalue reference.
4143         * remote.c (remote_target::open_1): Use push_target overload.
4144         * corelow.c (core_target_open): Use push_target overload.
4145
4146 2019-02-15  Tom Tromey  <tromey@adacore.com>
4147
4148         * ravenscar-thread.c (is_ravenscar_task)
4149         (ravenscar_task_is_currently_active): Return bool.
4150         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4151         (_initialize_ravenscar): Remove "(void)".
4152         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4153         Return bool.
4154
4155 2019-02-15  Tom Tromey  <tromey@adacore.com>
4156
4157         * ravenscar-thread.c (ravenscar_runtime_initializer)
4158         (has_ravenscar_runtime, get_running_thread_id)
4159         (ravenscar_thread_target::resume): Fix indentation.
4160
4161 2019-02-15  Tom Tromey  <tromey@adacore.com>
4162
4163         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4164         from ravenscar_arch_ops.
4165         (sparc_ravenscar_ops::fetch_registers)
4166         (sparc_ravenscar_ops::store_registers): Now methods.
4167         (sparc_ravenscar_prepare_to_store): Remove.
4168         (sparc_ravenscar_ops): Redefine.
4169         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4170         methods and destructor.  Remove members.
4171         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4172         (ravenscar_thread_target::store_registers)
4173         (ravenscar_thread_target::prepare_to_store): Update.
4174         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4175         Remove.
4176         (struct ppc_ravenscar_powerpc_ops): Derive from
4177         ravenscar_arch_ops.
4178         (ppc_ravenscar_powerpc_ops::fetch_registers)
4179         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4180         (ppc_ravenscar_powerpc_ops): Redefine.
4181         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4182         (ppc_ravenscar_e500_ops::fetch_registers)
4183         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4184         (ppc_ravenscar_e500_ops): Redefine.
4185         * aarch64-ravenscar-thread.c
4186         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4187         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4188         (aarch64_ravenscar_fetch_registers)
4189         (aarch64_ravenscar_store_registers): Now methods.
4190         (aarch64_ravenscar_ops): Redefine.
4191
4192 2019-02-15  Tom Tromey  <tromey@adacore.com>
4193
4194         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4195         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4196         (ravenscar_thread_target::stopped_by_watchpoint)
4197         (ravenscar_thread_target::stopped_data_address)
4198         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4199
4200 2019-02-15  Tom Tromey  <tromey@adacore.com>
4201
4202         * ravenscar-thread.c: Fix some typos.
4203
4204 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4205             Tom Tromey  <tromey@adacore.com>
4206
4207         * ada-lang.c (ada_exception_sal): Change addr_string to a
4208         std::string.
4209         (create_ada_exception_catchpoint): Update.
4210
4211 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4212             Tom Tromey  <tromey@adacore.com>
4213
4214         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4215         (bp_location_ops): Remove.
4216         (base_breakpoint_allocate_location): Update.
4217         (free_bp_location): Update.
4218         * ada-lang.c (class ada_catchpoint_location)
4219         <ada_catchpoint_location>: Remove ops parameter.
4220         (ada_catchpoint_location_dtor): Remove.
4221         (ada_catchpoint_location_ops): Remove.
4222         (allocate_location_exception): Update.
4223         * breakpoint.h (struct bp_location_ops): Remove.
4224         (class bp_location) <bp_location>: Remove bp_location_ops
4225         parameter.
4226         <~bp_location>: Add destructor.
4227         <ops>: Remove.
4228
4229 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4230             Pedro Alves  <palves@redhat.com>
4231
4232         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4233         'PATH_MAX'.
4234
4235 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4236             Samuel Thibault  <samuel.thibault@gnu.org>
4237             Thomas Schwinge  <thomas@codesourcery.com>
4238
4239         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4240         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4241
4242 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4243
4244         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4245         (check_empty): Use "const char *".
4246
4247         * gnu-nat.c (gnu_nat_target::detach): Instead of
4248         'detach_inferior (pid)' call
4249         'detach_inferior (find_inferior_pid (pid))'.
4250
4251         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4252         'nat/fork-inferior.o'.
4253         * gnu-nat.c: #include "nat/fork-inferior.h".
4254
4255         * gnu-nat.c (gnu_nat_target::detach): Instead of
4256         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4257         * gnu-nat.h: #include "inf-child.h".
4258         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4259         'i386_gnu_nat_target::fetch_registers'.
4260         (gnu_store_registers): Rename/move to
4261         'i386_gnu_nat_target::store_registers'.
4262
4263         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4264         * gnu-nat.h (mach_thread_info): New function.
4265         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4266
4267         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4268
4269 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4270
4271         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4272
4273 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4274
4275         * windows-nat.c (windows_add_thread): Add new parameter
4276         "main_thread_p" with default value set to false.  Update
4277         function documentation as well as all callers.
4278         (windows_delete_thread): Likewise.
4279         (fake_create_process): Update call to windows_add_thread.
4280         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4281         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4282         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4283         call to windows_delete_thread.
4284
4285 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4286
4287         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4288
4289 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4290
4291         * symfile.c (find_separate_debug_file): Use canonical path of
4292         sysroot with child_path instead of gdb_sysroot if it is valid.
4293
4294 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4295
4296         * symfile.c (find_separate_debug_file): Use child_path to
4297         determine if an object file is under a sysroot.
4298
4299 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4300
4301         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4302         unittests/child-path-selftests.c.
4303         * common/pathstuff.c (child_path): New function.
4304         * common/pathstuff.h (child_path): New prototype.
4305         * unittests/child-path-selftests.c: New file.
4306
4307 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4308
4309         * symfile.c (find_separate_debug_file): Look for separate debug
4310         files in debug directories under the sysroot.
4311
4312 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4313
4314         * symtab.h (struct minimal_symbol data_p): New const method.
4315         (struct minimal_symbol text_p): Likewise.
4316         * symtab.c (output_source_filename): Use file name style
4317         to print file name.
4318         (print_symbol_info): Likewise.
4319         (print_msymbol_info): Use address style to print addresses.
4320         Use function name style to print executable text symbols.
4321         (expand_symtab_containing_pc): Use data_p.
4322         (find_pc_sect_compunit_symtab): Likewise.
4323
4324 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4325
4326         * breakpoint.c (describe_other_breakpoints): Use address style
4327         to print addresses.
4328         (say_where): Likewise.
4329
4330 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4331
4332         * ada-typeprint.c (print_func_type): Print function name
4333         style to print function name.
4334         * c-typeprint.c (c_print_type_1): Likewise.
4335
4336 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4337
4338         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4339         for execve.
4340
4341 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4342
4343         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4344         type_stack.
4345
4346 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4347
4348         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4349         TYPE_CODE_REF types.
4350
4351 2019-02-08  Jim Wilson  <jimw@sifive.com>
4352
4353         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4354         (riscv_linux_fregset): New.
4355         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4356
4357 2019-02-07  Tom Tromey  <tom@tromey.com>
4358
4359         * thread.c (thread_cancel_execution_command): Update.
4360         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4361         methods.
4362         (struct thread_fsm_ops): Remove.
4363         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4364         (thread_fsm_should_stop, thread_fsm_return_value)
4365         (thread_fsm_set_finished, thread_fsm_finished_p)
4366         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4367         Don't declare.
4368         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4369         * infrun.c (clear_proceed_status_thread)
4370         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4371         (print_stop_event): Update.
4372         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4373         Add constructor.
4374         (step_command_fsm_ops): Remove.
4375         (new_step_command_fsm): Remove.
4376         (step_1): Update.
4377         (step_command_fsm::should_stop): Rename from
4378         step_command_fsm_should_stop.
4379         (step_command_fsm::clean_up): Rename from
4380         step_command_fsm_clean_up.
4381         (step_command_fsm::do_async_reply_reason): Rename from
4382         step_command_fsm_async_reply_reason.
4383         (struct until_next_fsm): Inherit from thread_fsm.  Add
4384         constructor.
4385         (until_next_fsm_ops): Remove.
4386         (new_until_next_fsm): Remove.
4387         (until_next_fsm::should_stop): Rename from
4388         until_next_fsm_should_stop.
4389         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4390         (until_next_fsm::do_async_reply_reason): Rename from
4391         until_next_fsm_async_reply_reason.
4392         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4393         constructor.  Change type of breakpoint.
4394         (finish_command_fsm_ops): Remove.
4395         (new_finish_command_fsm): Remove.
4396         (finish_command_fsm::should_stop): Rename from
4397         finish_command_fsm_should_stop.
4398         (finish_command_fsm::clean_up): Rename from
4399         finish_command_fsm_clean_up.
4400         (finish_command_fsm::return_value): Rename from
4401         finish_command_fsm_return_value.
4402         (finish_command_fsm::do_async_reply_reason): Rename from
4403         finish_command_fsm_async_reply_reason.
4404         (finish_command): Update.
4405         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4406         Add constructor.
4407         (call_thread_fsm_ops): Remove.
4408         (call_thread_fsm::call_thread_fsm): Rename from
4409         new_call_thread_fsm.
4410         (call_thread_fsm::should_stop): Rename from
4411         call_thread_fsm_should_stop.
4412         (call_thread_fsm::should_notify_stop): Rename from
4413         call_thread_fsm_should_notify_stop.
4414         (run_inferior_call, call_function_by_hand_dummy): Update.
4415         * cli/cli-interp.c (should_print_stop_to_console): Update.
4416         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4417         Add constructor.  Change type of location_breakpoint,
4418         caller_breakpoint.
4419         (until_break_fsm_ops): Remove.
4420         (new_until_break_fsm): Remove.
4421         (until_break_fsm::should_stop): Rename from
4422         until_break_fsm_should_stop.
4423         (until_break_fsm::clean_up): Rename from
4424         until_break_fsm_clean_up.
4425         (until_break_fsm::do_async_reply_reason): Rename from
4426         until_break_fsm_async_reply_reason.
4427         (until_break_command): Update.
4428         * thread-fsm.c: Remove.
4429         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4430
4431 2019-02-07  Tom Tromey  <tom@tromey.com>
4432
4433         * yy-remap.h: Add include guard.
4434         * xtensa-tdep.h: Add include guard.
4435         * xcoffread.h: Rename include guard.
4436         * varobj-iter.h: Add include guard.
4437         * tui/tui.h: Rename include guard.
4438         * tui/tui-winsource.h: Rename include guard.
4439         * tui/tui-wingeneral.h: Rename include guard.
4440         * tui/tui-windata.h: Rename include guard.
4441         * tui/tui-win.h: Rename include guard.
4442         * tui/tui-stack.h: Rename include guard.
4443         * tui/tui-source.h: Rename include guard.
4444         * tui/tui-regs.h: Rename include guard.
4445         * tui/tui-out.h: Rename include guard.
4446         * tui/tui-layout.h: Rename include guard.
4447         * tui/tui-io.h: Rename include guard.
4448         * tui/tui-hooks.h: Rename include guard.
4449         * tui/tui-file.h: Rename include guard.
4450         * tui/tui-disasm.h: Rename include guard.
4451         * tui/tui-data.h: Rename include guard.
4452         * tui/tui-command.h: Rename include guard.
4453         * tic6x-tdep.h: Add include guard.
4454         * target/waitstatus.h: Rename include guard.
4455         * target/wait.h: Rename include guard.
4456         * target/target.h: Rename include guard.
4457         * target/resume.h: Rename include guard.
4458         * target-float.h: Rename include guard.
4459         * stabsread.h: Add include guard.
4460         * rs6000-tdep.h: Add include guard.
4461         * riscv-fbsd-tdep.h: Add include guard.
4462         * regformats/regdef.h: Rename include guard.
4463         * record.h: Rename include guard.
4464         * python/python.h: Rename include guard.
4465         * python/python-internal.h: Rename include guard.
4466         * python/py-stopevent.h: Rename include guard.
4467         * python/py-ref.h: Rename include guard.
4468         * python/py-record.h: Rename include guard.
4469         * python/py-record-full.h: Rename include guard.
4470         * python/py-record-btrace.h: Rename include guard.
4471         * python/py-instruction.h: Rename include guard.
4472         * python/py-events.h: Rename include guard.
4473         * python/py-event.h: Rename include guard.
4474         * procfs.h: Add include guard.
4475         * proc-utils.h: Add include guard.
4476         * p-lang.h: Add include guard.
4477         * or1k-tdep.h: Rename include guard.
4478         * observable.h: Rename include guard.
4479         * nto-tdep.h: Rename include guard.
4480         * nat/x86-linux.h: Rename include guard.
4481         * nat/x86-linux-dregs.h: Rename include guard.
4482         * nat/x86-gcc-cpuid.h: Add include guard.
4483         * nat/x86-dregs.h: Rename include guard.
4484         * nat/x86-cpuid.h: Rename include guard.
4485         * nat/ppc-linux.h: Rename include guard.
4486         * nat/mips-linux-watch.h: Rename include guard.
4487         * nat/linux-waitpid.h: Rename include guard.
4488         * nat/linux-ptrace.h: Rename include guard.
4489         * nat/linux-procfs.h: Rename include guard.
4490         * nat/linux-osdata.h: Rename include guard.
4491         * nat/linux-nat.h: Rename include guard.
4492         * nat/linux-namespaces.h: Rename include guard.
4493         * nat/linux-btrace.h: Rename include guard.
4494         * nat/glibc_thread_db.h: Rename include guard.
4495         * nat/gdb_thread_db.h: Rename include guard.
4496         * nat/gdb_ptrace.h: Rename include guard.
4497         * nat/fork-inferior.h: Rename include guard.
4498         * nat/amd64-linux-siginfo.h: Rename include guard.
4499         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4500         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4501         * nat/aarch64-linux.h: Rename include guard.
4502         * nat/aarch64-linux-hw-point.h: Rename include guard.
4503         * mn10300-tdep.h: Add include guard.
4504         * mips-linux-tdep.h: Add include guard.
4505         * mi/mi-parse.h: Rename include guard.
4506         * mi/mi-out.h: Rename include guard.
4507         * mi/mi-main.h: Rename include guard.
4508         * mi/mi-interp.h: Rename include guard.
4509         * mi/mi-getopt.h: Rename include guard.
4510         * mi/mi-console.h: Rename include guard.
4511         * mi/mi-common.h: Rename include guard.
4512         * mi/mi-cmds.h: Rename include guard.
4513         * mi/mi-cmd-break.h: Rename include guard.
4514         * m2-lang.h: Add include guard.
4515         * location.h: Rename include guard.
4516         * linux-record.h: Rename include guard.
4517         * linux-nat.h: Add include guard.
4518         * linux-fork.h: Add include guard.
4519         * i386-darwin-tdep.h: Rename include guard.
4520         * hppa-linux-offsets.h: Add include guard.
4521         * guile/guile.h: Rename include guard.
4522         * guile/guile-internal.h: Rename include guard.
4523         * gnu-nat.h: Rename include guard.
4524         * gdb-stabs.h: Rename include guard.
4525         * frv-tdep.h: Add include guard.
4526         * f-lang.h: Add include guard.
4527         * event-loop.h: Add include guard.
4528         * darwin-nat.h: Rename include guard.
4529         * cp-abi.h: Rename include guard.
4530         * config/sparc/nm-sol2.h: Rename include guard.
4531         * config/nm-nto.h: Rename include guard.
4532         * config/nm-linux.h: Add include guard.
4533         * config/i386/nm-i386gnu.h: Rename include guard.
4534         * config/djgpp/nl_types.h: Rename include guard.
4535         * config/djgpp/langinfo.h: Rename include guard.
4536         * compile/gcc-cp-plugin.h: Add include guard.
4537         * compile/gcc-c-plugin.h: Add include guard.
4538         * compile/compile.h: Rename include guard.
4539         * compile/compile-object-run.h: Rename include guard.
4540         * compile/compile-object-load.h: Rename include guard.
4541         * compile/compile-internal.h: Rename include guard.
4542         * compile/compile-cplus.h: Rename include guard.
4543         * compile/compile-c.h: Rename include guard.
4544         * common/xml-utils.h: Rename include guard.
4545         * common/x86-xstate.h: Rename include guard.
4546         * common/version.h: Rename include guard.
4547         * common/vec.h: Rename include guard.
4548         * common/tdesc.h: Rename include guard.
4549         * common/selftest.h: Rename include guard.
4550         * common/scoped_restore.h: Rename include guard.
4551         * common/scoped_mmap.h: Rename include guard.
4552         * common/scoped_fd.h: Rename include guard.
4553         * common/safe-iterator.h: Rename include guard.
4554         * common/run-time-clock.h: Rename include guard.
4555         * common/refcounted-object.h: Rename include guard.
4556         * common/queue.h: Rename include guard.
4557         * common/ptid.h: Rename include guard.
4558         * common/print-utils.h: Rename include guard.
4559         * common/preprocessor.h: Rename include guard.
4560         * common/pathstuff.h: Rename include guard.
4561         * common/observable.h: Rename include guard.
4562         * common/netstuff.h: Rename include guard.
4563         * common/job-control.h: Rename include guard.
4564         * common/host-defs.h: Rename include guard.
4565         * common/gdb_wait.h: Rename include guard.
4566         * common/gdb_vecs.h: Rename include guard.
4567         * common/gdb_unlinker.h: Rename include guard.
4568         * common/gdb_unique_ptr.h: Rename include guard.
4569         * common/gdb_tilde_expand.h: Rename include guard.
4570         * common/gdb_sys_time.h: Rename include guard.
4571         * common/gdb_string_view.h: Rename include guard.
4572         * common/gdb_splay_tree.h: Rename include guard.
4573         * common/gdb_setjmp.h: Rename include guard.
4574         * common/gdb_ref_ptr.h: Rename include guard.
4575         * common/gdb_optional.h: Rename include guard.
4576         * common/gdb_locale.h: Rename include guard.
4577         * common/gdb_assert.h: Rename include guard.
4578         * common/filtered-iterator.h: Rename include guard.
4579         * common/filestuff.h: Rename include guard.
4580         * common/fileio.h: Rename include guard.
4581         * common/environ.h: Rename include guard.
4582         * common/common-utils.h: Rename include guard.
4583         * common/common-types.h: Rename include guard.
4584         * common/common-regcache.h: Rename include guard.
4585         * common/common-inferior.h: Rename include guard.
4586         * common/common-gdbthread.h: Rename include guard.
4587         * common/common-exceptions.h: Rename include guard.
4588         * common/common-defs.h: Rename include guard.
4589         * common/common-debug.h: Rename include guard.
4590         * common/cleanups.h: Rename include guard.
4591         * common/buffer.h: Rename include guard.
4592         * common/btrace-common.h: Rename include guard.
4593         * common/break-common.h: Rename include guard.
4594         * cli/cli-utils.h: Rename include guard.
4595         * cli/cli-style.h: Rename include guard.
4596         * cli/cli-setshow.h: Rename include guard.
4597         * cli/cli-script.h: Rename include guard.
4598         * cli/cli-interp.h: Rename include guard.
4599         * cli/cli-decode.h: Rename include guard.
4600         * cli/cli-cmds.h: Rename include guard.
4601         * charset-list.h: Add include guard.
4602         * buildsym-legacy.h: Rename include guard.
4603         * bfin-tdep.h: Add include guard.
4604         * ax.h: Rename include guard.
4605         * arm-linux-tdep.h: Add include guard.
4606         * arm-fbsd-tdep.h: Add include guard.
4607         * arch/xtensa.h: Rename include guard.
4608         * arch/tic6x.h: Add include guard.
4609         * arch/i386.h: Add include guard.
4610         * arch/arm.h: Rename include guard.
4611         * arch/arm-linux.h: Rename include guard.
4612         * arch/arm-get-next-pcs.h: Rename include guard.
4613         * arch/amd64.h: Add include guard.
4614         * arch/aarch64-insn.h: Rename include guard.
4615         * arch-utils.h: Rename include guard.
4616         * annotate.h: Add include guard.
4617         * amd64-darwin-tdep.h: Rename include guard.
4618         * aarch64-linux-tdep.h: Add include guard.
4619         * aarch64-fbsd-tdep.h: Add include guard.
4620         * aarch32-linux-nat.h: Add include guard.
4621
4622 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4623
4624         * macrotab.c (macro_define_internal): New function that
4625         factorizes macro_define_object_internal and macro_define_function
4626         code.
4627         (macro_define_object_internal): Use macro_define_internal.
4628         (macro_define_function): Likewise.
4629
4630 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4631
4632         * macrocmd.c (extract_identifier): Return
4633         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4634         callers.
4635
4636 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4637
4638         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4639
4640 2019-02-05  Tom Tromey  <tom@tromey.com>
4641
4642         * target.c (target_stack::unpush): Move assertion earlier.
4643
4644 2019-01-30  Tom Tromey  <tom@tromey.com>
4645
4646         PR python/23615:
4647         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4648         (gdbpy_parse_and_eval): Likewise.
4649         * python/python-internal.h (gdbpy_allow_threads): New class.
4650
4651 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4652
4653         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4654         (aarch64_fbsd_fpregmap): Move earlier.
4655         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4656         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4657         instead of individual calls to trad_frame_set_reg_addr.
4658         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4659         earlier.
4660         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4661         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4662         instead of individual calls to trad_frame_set_reg_addr.
4663
4664 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4665
4666         * CONTRIBUTE: Replace contribution list with wiki link.
4667
4668 2019-01-25  Tom Tromey  <tom@tromey.com>
4669
4670         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4671
4672 2019-01-25  Tom Tromey  <tom@tromey.com>
4673
4674         * xtensa-linux-nat.c: Fix common/ includes.
4675         * xml-support.h: Fix common/ includes.
4676         * xml-support.c: Fix common/ includes.
4677         * x86-linux-nat.c: Fix common/ includes.
4678         * windows-nat.c: Fix common/ includes.
4679         * varobj.h: Fix common/ includes.
4680         * varobj.c: Fix common/ includes.
4681         * value.c: Fix common/ includes.
4682         * valops.c: Fix common/ includes.
4683         * utils.c: Fix common/ includes.
4684         * unittests/xml-utils-selftests.c: Fix common/ includes.
4685         * unittests/utils-selftests.c: Fix common/ includes.
4686         * unittests/unpack-selftests.c: Fix common/ includes.
4687         * unittests/tracepoint-selftests.c: Fix common/ includes.
4688         * unittests/style-selftests.c: Fix common/ includes.
4689         * unittests/string_view-selftests.c: Fix common/ includes.
4690         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4691         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4692         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4693         * unittests/rsp-low-selftests.c: Fix common/ includes.
4694         * unittests/parse-connection-spec-selftests.c: Fix common/
4695         includes.
4696         * unittests/optional-selftests.c: Fix common/ includes.
4697         * unittests/offset-type-selftests.c: Fix common/ includes.
4698         * unittests/observable-selftests.c: Fix common/ includes.
4699         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4700         * unittests/memrange-selftests.c: Fix common/ includes.
4701         * unittests/memory-map-selftests.c: Fix common/ includes.
4702         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4703         * unittests/function-view-selftests.c: Fix common/ includes.
4704         * unittests/environ-selftests.c: Fix common/ includes.
4705         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4706         * unittests/common-utils-selftests.c: Fix common/ includes.
4707         * unittests/cli-utils-selftests.c: Fix common/ includes.
4708         * unittests/array-view-selftests.c: Fix common/ includes.
4709         * ui-file.c: Fix common/ includes.
4710         * tui/tui-io.c: Fix common/ includes.
4711         * tracepoint.h: Fix common/ includes.
4712         * tracepoint.c: Fix common/ includes.
4713         * tracefile-tfile.c: Fix common/ includes.
4714         * top.h: Fix common/ includes.
4715         * top.c: Fix common/ includes.
4716         * thread.c: Fix common/ includes.
4717         * target/waitstatus.h: Fix common/ includes.
4718         * target/waitstatus.c: Fix common/ includes.
4719         * target.h: Fix common/ includes.
4720         * target.c: Fix common/ includes.
4721         * target-memory.c: Fix common/ includes.
4722         * target-descriptions.c: Fix common/ includes.
4723         * symtab.h: Fix common/ includes.
4724         * symfile.c: Fix common/ includes.
4725         * stap-probe.c: Fix common/ includes.
4726         * spu-linux-nat.c: Fix common/ includes.
4727         * sparc-nat.c: Fix common/ includes.
4728         * source.c: Fix common/ includes.
4729         * solib.c: Fix common/ includes.
4730         * solib-target.c: Fix common/ includes.
4731         * ser-unix.c: Fix common/ includes.
4732         * ser-tcp.c: Fix common/ includes.
4733         * ser-pipe.c: Fix common/ includes.
4734         * ser-base.c: Fix common/ includes.
4735         * selftest-arch.c: Fix common/ includes.
4736         * s12z-tdep.c: Fix common/ includes.
4737         * rust-exp.y: Fix common/ includes.
4738         * rs6000-aix-tdep.c: Fix common/ includes.
4739         * riscv-tdep.c: Fix common/ includes.
4740         * remote.c: Fix common/ includes.
4741         * remote-notif.h: Fix common/ includes.
4742         * remote-fileio.h: Fix common/ includes.
4743         * remote-fileio.c: Fix common/ includes.
4744         * regcache.h: Fix common/ includes.
4745         * regcache.c: Fix common/ includes.
4746         * record-btrace.c: Fix common/ includes.
4747         * python/python.c: Fix common/ includes.
4748         * python/py-type.c: Fix common/ includes.
4749         * python/py-inferior.c: Fix common/ includes.
4750         * progspace.h: Fix common/ includes.
4751         * producer.c: Fix common/ includes.
4752         * procfs.c: Fix common/ includes.
4753         * proc-api.c: Fix common/ includes.
4754         * printcmd.c: Fix common/ includes.
4755         * ppc-linux-nat.c: Fix common/ includes.
4756         * parser-defs.h: Fix common/ includes.
4757         * osdata.c: Fix common/ includes.
4758         * obsd-nat.c: Fix common/ includes.
4759         * nat/x86-linux.c: Fix common/ includes.
4760         * nat/x86-linux-dregs.c: Fix common/ includes.
4761         * nat/x86-dregs.h: Fix common/ includes.
4762         * nat/x86-dregs.c: Fix common/ includes.
4763         * nat/ppc-linux.c: Fix common/ includes.
4764         * nat/mips-linux-watch.h: Fix common/ includes.
4765         * nat/mips-linux-watch.c: Fix common/ includes.
4766         * nat/linux-waitpid.c: Fix common/ includes.
4767         * nat/linux-ptrace.h: Fix common/ includes.
4768         * nat/linux-ptrace.c: Fix common/ includes.
4769         * nat/linux-procfs.c: Fix common/ includes.
4770         * nat/linux-personality.c: Fix common/ includes.
4771         * nat/linux-osdata.c: Fix common/ includes.
4772         * nat/linux-namespaces.c: Fix common/ includes.
4773         * nat/linux-btrace.h: Fix common/ includes.
4774         * nat/linux-btrace.c: Fix common/ includes.
4775         * nat/fork-inferior.c: Fix common/ includes.
4776         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4777         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4778         * nat/aarch64-linux.c: Fix common/ includes.
4779         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4780         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4781         * namespace.h: Fix common/ includes.
4782         * mips-linux-tdep.c: Fix common/ includes.
4783         * minsyms.c: Fix common/ includes.
4784         * mi/mi-parse.h: Fix common/ includes.
4785         * mi/mi-main.c: Fix common/ includes.
4786         * mi/mi-cmd-env.c: Fix common/ includes.
4787         * memrange.h: Fix common/ includes.
4788         * memattr.c: Fix common/ includes.
4789         * maint.h: Fix common/ includes.
4790         * maint.c: Fix common/ includes.
4791         * main.c: Fix common/ includes.
4792         * machoread.c: Fix common/ includes.
4793         * location.c: Fix common/ includes.
4794         * linux-thread-db.c: Fix common/ includes.
4795         * linux-nat.c: Fix common/ includes.
4796         * linux-fork.c: Fix common/ includes.
4797         * inline-frame.c: Fix common/ includes.
4798         * infrun.c: Fix common/ includes.
4799         * inflow.c: Fix common/ includes.
4800         * inferior.h: Fix common/ includes.
4801         * inferior.c: Fix common/ includes.
4802         * infcmd.c: Fix common/ includes.
4803         * inf-ptrace.c: Fix common/ includes.
4804         * inf-child.c: Fix common/ includes.
4805         * ia64-linux-nat.c: Fix common/ includes.
4806         * i387-tdep.c: Fix common/ includes.
4807         * i386-tdep.c: Fix common/ includes.
4808         * i386-linux-tdep.c: Fix common/ includes.
4809         * i386-linux-nat.c: Fix common/ includes.
4810         * i386-go32-tdep.c: Fix common/ includes.
4811         * i386-fbsd-tdep.c: Fix common/ includes.
4812         * i386-fbsd-nat.c: Fix common/ includes.
4813         * guile/scm-type.c: Fix common/ includes.
4814         * guile/guile.c: Fix common/ includes.
4815         * go32-nat.c: Fix common/ includes.
4816         * gnu-nat.c: Fix common/ includes.
4817         * gdbthread.h: Fix common/ includes.
4818         * gdbarch-selftests.c: Fix common/ includes.
4819         * gdb_usleep.c: Fix common/ includes.
4820         * gdb_select.h: Fix common/ includes.
4821         * gdb_bfd.c: Fix common/ includes.
4822         * gcore.c: Fix common/ includes.
4823         * fork-child.c: Fix common/ includes.
4824         * findvar.c: Fix common/ includes.
4825         * fbsd-nat.c: Fix common/ includes.
4826         * event-top.c: Fix common/ includes.
4827         * event-loop.c: Fix common/ includes.
4828         * dwarf2read.c: Fix common/ includes.
4829         * dwarf2loc.c: Fix common/ includes.
4830         * dwarf2-frame.c: Fix common/ includes.
4831         * dwarf-index-cache.c: Fix common/ includes.
4832         * dtrace-probe.c: Fix common/ includes.
4833         * disasm-selftests.c: Fix common/ includes.
4834         * defs.h: Fix common/ includes.
4835         * csky-tdep.c: Fix common/ includes.
4836         * cp-valprint.c: Fix common/ includes.
4837         * cp-support.h: Fix common/ includes.
4838         * cp-support.c: Fix common/ includes.
4839         * corelow.c: Fix common/ includes.
4840         * completer.h: Fix common/ includes.
4841         * completer.c: Fix common/ includes.
4842         * compile/compile.c: Fix common/ includes.
4843         * compile/compile-loc2c.c: Fix common/ includes.
4844         * compile/compile-cplus-types.c: Fix common/ includes.
4845         * compile/compile-cplus-symbols.c: Fix common/ includes.
4846         * command.h: Fix common/ includes.
4847         * cli/cli-dump.c: Fix common/ includes.
4848         * cli/cli-cmds.c: Fix common/ includes.
4849         * charset.c: Fix common/ includes.
4850         * build-id.c: Fix common/ includes.
4851         * btrace.h: Fix common/ includes.
4852         * btrace.c: Fix common/ includes.
4853         * breakpoint.h: Fix common/ includes.
4854         * breakpoint.c: Fix common/ includes.
4855         * ax.h:
4856         (enum agent_op): Fix common/ includes.
4857         * ax-general.c (struct aop_map): Fix common/ includes.
4858         * ax-gdb.c: Fix common/ includes.
4859         * auxv.c: Fix common/ includes.
4860         * auto-load.c: Fix common/ includes.
4861         * arm-tdep.c: Fix common/ includes.
4862         * arch/riscv.c: Fix common/ includes.
4863         * arch/ppc-linux-common.c: Fix common/ includes.
4864         * arch/i386.c: Fix common/ includes.
4865         * arch/arm.c: Fix common/ includes.
4866         * arch/arm-linux.c: Fix common/ includes.
4867         * arch/arm-get-next-pcs.c: Fix common/ includes.
4868         * arch/amd64.c: Fix common/ includes.
4869         * arch/aarch64.c: Fix common/ includes.
4870         * arch/aarch64-insn.c: Fix common/ includes.
4871         * arch-utils.c: Fix common/ includes.
4872         * amd64-windows-tdep.c: Fix common/ includes.
4873         * amd64-tdep.c: Fix common/ includes.
4874         * amd64-sol2-tdep.c: Fix common/ includes.
4875         * amd64-obsd-tdep.c: Fix common/ includes.
4876         * amd64-nbsd-tdep.c: Fix common/ includes.
4877         * amd64-linux-tdep.c: Fix common/ includes.
4878         * amd64-linux-nat.c: Fix common/ includes.
4879         * amd64-fbsd-tdep.c: Fix common/ includes.
4880         * amd64-fbsd-nat.c: Fix common/ includes.
4881         * amd64-dicos-tdep.c: Fix common/ includes.
4882         * amd64-darwin-tdep.c: Fix common/ includes.
4883         * agent.c: Fix common/ includes.
4884         * ada-lang.h: Fix common/ includes.
4885         * ada-lang.c: Fix common/ includes.
4886         * aarch64-tdep.c: Fix common/ includes.
4887
4888 2019-01-25  Tom Tromey  <tom@tromey.com>
4889
4890         * common/create-version.sh: Use common/version.h.
4891
4892 2019-01-24  Pedro Alves  <palves@redhat.com>
4893
4894         * infrun.c (signal_stop, signal_print, signal_program)
4895         (signal_catch, signal_pass): Now arrays instead of pointers.
4896         (update_signals_program_target, do_target_resume)
4897         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4898         * linux-nat.c (linux_nat_target::pass_signals)
4899         (linux_nat_target::create_inferior, linux_nat_target::attach):
4900         Adjust.
4901         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4902         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4903         * procfs.c (procfs_target::pass_signals): Adjust.
4904         * record-full.c (record_full_target::resume): Adjust.
4905         * remote.c (remote_target::pass_signals)
4906         (remote_target::program_signals): Adjust.
4907         * target-debug.h (target_debug_print_signals): Now takes a
4908         gdb::array_view as parameter.  Adjust.
4909         * target.h (target_ops) <pass_signals, program_signals>: Replace
4910         pointer and length parameters with gdb::array_view.
4911         (target_pass_signals, target_program_signals): Likewise.
4912         * target-delegates.c: Regenerate.
4913
4914 2019-01-24  Pedro Alves  <palves@redhat.com>
4915
4916         * common/forward-scope-exit.h
4917         (forward_scope_exit::forward_scope_exit): Pass arguments to
4918         m_bind_function directly, instead of creating a std::bind and
4919         copying that.
4920
4921 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4922
4923         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4924         for static members.
4925         (pass_in_v_vfp_candidate): Likewise.
4926
4927 2019-01-23  Tom Tromey  <tom@tromey.com>
4928             Pedro Alves  <palves@redhat.com>
4929
4930         * regcache.c (class regcache_invalidator): Remove.
4931         (regcache::raw_write): Use make_scope_exit.
4932
4933 2019-01-23  Tom Tromey  <tom@tromey.com>
4934
4935         * ui-out.h (class ui_out_emit_type): Update comment.
4936
4937 2019-01-23  Tom Tromey  <tom@tromey.com>
4938
4939         * infrun.c (fetch_inferior_event): Update comment.
4940
4941 2019-01-23  Tom Tromey  <tom@tromey.com>
4942             Pedro Alves  <palves@redhat.com>
4943
4944         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4945         parameter.
4946         (fetch_inferior_event): Use SCOPE_EXIT.
4947
4948
4949 2019-01-23  Tom Tromey  <tom@tromey.com>
4950             Pedro Alves  <palves@redhat.com>
4951
4952         * infrun.c (disable_thread_events): Delete.
4953         (stop_all_threads): Use SCOPE_EXIT.
4954
4955 2019-01-23  Tom Tromey  <tom@tromey.com>
4956             Pedro Alves  <palves@redhat.com>
4957
4958         * symfile.c: Include forward-scope-exit.h.
4959         (clear_symtab_users_cleanup): Replace forward declaration with
4960         a FORWARD_SCOPE_EXIT.
4961         (syms_from_objfile_1): Use the forward_scope_exit and
4962         gdb::optional instead of cleanup_function.
4963         (reread_symbols): Use the forward_scope_exit instead of
4964         cleanup_function.
4965         (clear_symtab_users_cleanup): Remove function.
4966
4967 2019-01-23  Tom Tromey  <tom@tromey.com>
4968             Pedro Alves  <palves@redhat.com>
4969
4970         * linux-nat.c: Include scope-exit.h.
4971         (cleanup_target_stop): Remove.
4972         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4973         SCOPE_EXIT.
4974
4975 2019-01-23  Tom Tromey  <tom@tromey.com>
4976             Pedro Alves  <palves@redhat.com>
4977
4978         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4979         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4980
4981 2019-01-23  Tom Tromey  <tom@tromey.com>
4982             Andrew Burgess  <andrew.burgess@embecosm.com>
4983             Pedro Alves  <palves@redhat.com>
4984
4985         * infrun.c (fetch_inferior_event): Use scope_exit.
4986         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4987         * top.c (execute_command): Use scope_exit.
4988         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4989         * utils.c (do_bpstat_clear_actions_cleanup)
4990         (make_bpstat_clear_actions_cleanup): Remove.
4991
4992 2019-01-23  Tom Tromey  <tom@tromey.com>
4993             Pedro Alves  <palves@redhat.com>
4994
4995         * infrun.c: Include "common/scope-exit.h"
4996         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4997         (wait_for_inferior): Use SCOPE_EXIT.
4998         (fetch_inferior_event): Use scope_exit.
4999
5000 2019-01-23  Tom Tromey  <tom@tromey.com>
5001             Pedro Alves  <palves@redhat.com>
5002
5003         * breakpoint.c (create_breakpoint): Remove cleanup.
5004
5005 2019-01-23  Tom Tromey  <tom@tromey.com>
5006             Andrew Burgess  <andrew.burgess@embecosm.com>
5007             Pedro Alves  <palves@redhat.com>
5008
5009 2019-01-23  Pedro Alves  <palves@redhat.com>
5010
5011         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5012
5013 2019-01-23  Pedro Alves  <palves@redhat.com>
5014             Andrew Burgess  <andrew.burgess@embecosm.com>
5015
5016         * gdbthread.h: Include "common/forward-scope-exit.h".
5017         (scoped_finish_thread_state): Redefine custom class in terms of
5018         forward_scope_exit.
5019
5020 2019-01-23  Pedro Alves  <palves@redhat.com>
5021             Andrew Burgess  <andrew.burgess@embecosm.com>
5022
5023         * common/forward-scope-exit.h: New file.
5024
5025 2019-01-23  Pedro Alves  <palves@redhat.com>
5026             Andrew Burgess  <andrew.burgess@embecosm.com>
5027             Tom Tromey  <tom@tromey.com>
5028
5029         * common/scope-exit.h: New file.
5030
5031 2019-01-23  Pedro Alves  <palves@redhat.com>
5032
5033         * common/preprocessor.h (ESC): Rename to ...
5034         (ESC_PARENS): ... this.
5035         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5036         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5037
5038 2019-01-23  Tom Tromey  <tom@tromey.com>
5039
5040         * language.h (class scoped_switch_to_sym_language_if_auto):
5041         Initialize m_lang in both cases.
5042
5043 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5044
5045         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5046         with XCNEW.
5047
5048 2019-01-22  Tom Tromey  <tom@tromey.com>
5049
5050         * corelow.c: Do not include sys/file.h.
5051
5052 2019-01-22  Tom Tromey  <tom@tromey.com>
5053
5054         * tui/tui-wingeneral.h: Include gdb_curses.h.
5055
5056 2019-01-22  Tom Tromey  <tom@tromey.com>
5057
5058         * source-cache.h (class source_cache) <get_source_lines,
5059         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5060
5061 2019-01-22  Tom Tromey  <tom@tromey.com>
5062
5063         * remote-fileio.h (struct remote_target): Declare.
5064
5065 2019-01-22  Tom Tromey  <tom@tromey.com>
5066
5067         * python/py-arch.c: Do not include py-ref.h.
5068         * python/py-bpevent.c: Do not include py-ref.h.
5069         * python/py-cmd.c: Do not include py-ref.h.
5070         * python/py-continueevent.c: Do not include py-ref.h.
5071         * python/py-event.h: Do not include py-ref.h.
5072         * python/py-evtregistry.c: Do not include py-ref.h.
5073         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5074         * python/py-frame.c: Do not include py-ref.h.
5075         * python/py-framefilter.c: Do not include py-ref.h.
5076         * python/py-function.c: Do not include py-ref.h.
5077         * python/py-infevents.c: Do not include py-ref.h.
5078         * python/py-linetable.c: Do not include py-ref.h.
5079         * python/py-objfile.c: Do not include py-ref.h.
5080         * python/py-param.c: Do not include py-ref.h.
5081         * python/py-prettyprint.c: Do not include py-ref.h.
5082         * python/py-progspace.c: Do not include py-ref.h.
5083         * python/py-symbol.c: Do not include py-ref.h.
5084         * python/py-symtab.c: Do not include py-ref.h.
5085         * python/py-type.c: Do not include py-ref.h.
5086         * python/py-unwind.c: Do not include py-ref.h.
5087         * python/py-utils.c: Do not include py-ref.h.
5088         * python/py-value.c: Do not include py-ref.h.
5089         * python/py-varobj.c: Do not include py-ref.h.
5090         * python/py-xmethods.c: Do not include py-ref.h.
5091         * python/python.c: Do not include py-ref.h.
5092         * varobj.c: Do not include py-ref.h.
5093
5094 2019-01-22  Tom Tromey  <tom@tromey.com>
5095
5096         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5097         keyword for bcache.
5098
5099 2019-01-22  Tom Tromey  <tom@tromey.com>
5100
5101         * compile/compile-cplus-types.c: Remove a comment by #include.
5102
5103 2019-01-22  Tom Tromey  <tom@tromey.com>
5104
5105         * compile/gcc-c-plugin.h: Include compile-internal.h.
5106
5107 2019-01-22  Tom Tromey  <tom@tromey.com>
5108
5109         * stabsread.c (EXTERN): Do not define.
5110         (symnum, next_symbol_text_func, processing_gcc_compilation)
5111         (within_function, global_sym_chain, global_stabs)
5112         (previous_stab_code, this_object_header_files)
5113         (n_this_object_header_files)
5114         (n_allocated_this_object_header_files): Define.
5115         * stabsread.h (EXTERN): Never define.  Use "extern".
5116
5117 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5118
5119         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5120         history_value.
5121
5122 2019-01-21  Tom Tromey  <tom@tromey.com>
5123
5124         * ui-out.c: Fix includes.
5125         * tui/tui-source.c: Fix includes.
5126         * target.c: Fix includes.
5127         * remote.c: Fix includes.
5128         * regcache.c: Fix includes.
5129         * python/py-block.c: Fix includes.
5130         * printcmd.c: Fix includes.
5131         * or1k-tdep.c: Fix includes.
5132         * mi/mi-main.c: Fix includes.
5133         * m32r-tdep.c: Fix includes.
5134         * csky-tdep.c: Fix includes.
5135         * compile/compile-cplus-types.c: Fix includes.
5136         * cli/cli-interp.c: Fix includes.
5137
5138 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5139
5140         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5141         for padding.
5142
5143 2019-01-16  Tom Tromey  <tom@tromey.com>
5144
5145         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5146         earlier.
5147         (struct objfile) <msymbols_range>: Move from top level.
5148         <msymbols>: New method.
5149         (class objfile_msymbols): Remove.
5150         * symtab.c (default_collect_symbol_completion_matches_break_on):
5151         Update.
5152         * symmisc.c (dump_msymbols): Update.
5153         * stabsread.c (scan_file_globals): Update.
5154         * objc-lang.c (info_selectors_command, info_classes_command)
5155         (find_methods): Update.
5156         * minsyms.c (find_solib_trampoline_target): Update.
5157         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5158         * coffread.c (coff_symfile_read): Update.
5159         * ada-lang.c (ada_lookup_simple_minsym)
5160         (ada_collect_symbol_completion_matches): Update.
5161
5162 2019-01-16  Tom Tromey  <tom@tromey.com>
5163
5164         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5165         type.  Remove no-argument constructor.
5166         <iterator::operator++>: Simplify.
5167         <begin>: Update.
5168         <end>: Use minimal_symbol_count.
5169
5170 2019-01-16  Tom Tromey  <tom@tromey.com>
5171
5172         * objfiles.h (struct objfile) <psymtabs>: New method.
5173         (class objfile_psymtabs): Remove.
5174         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5175         typedef.
5176         <range>: New method.
5177         (require_partial_symbols): Change return type.
5178         * psymtab.c (require_partial_symbols)
5179         (psym_expand_symtabs_matching): Update.
5180         * mdebugread.c (parse_partial_symbols): Update.
5181         * dbxread.c (dbx_end_psymtab): Update.
5182
5183 2019-01-15  Tom Tromey  <tom@tromey.com>
5184
5185         * symtab.c (lookup_objfile_from_block)
5186         (lookup_symbol_in_objfile_symtabs)
5187         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5188         (find_line_symtab, info_sources_command)
5189         (default_collect_symbol_completion_matches_break_on)
5190         (make_source_files_completion_list): Update.
5191         * symmisc.c (print_objfile_statistics, dump_objfile)
5192         (maintenance_print_symbols, maintenance_info_symtabs)
5193         (maintenance_check_symtabs, maintenance_info_line_tables):
5194         Update.
5195         * source.c (select_source_symtab)
5196         (forget_cached_source_info_for_objfile): Update.
5197         * objfiles.h (class objfile_compunits): Remove.
5198         (struct objfile) <compunits_range>: New typedef.
5199         (compunits): New method.
5200         * objfiles.c (objfile_relocate1): Update.
5201         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5202         * maint.c (count_symtabs_and_blocks): Update.
5203         * linespec.c (iterate_over_all_matching_symtabs): Update.
5204         * cp-support.c (add_symbol_overload_list_qualified): Update.
5205         * coffread.c (coff_symtab_read): Update.
5206         * ada-lang.c (add_nonlocal_symbols)
5207         (ada_collect_symbol_completion_matches)
5208         (ada_add_global_exceptions): Update.
5209
5210 2019-01-15  Tom Tromey  <tom@tromey.com>
5211
5212         * progspace.h (program_space) <objfiles_safe_range>: New
5213         typedef.
5214         <objfiles_safe>: New method.
5215         * objfiles.h (class all_objfiles_safe): Remove.
5216         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5217         * jit.c (jit_inferior_exit_hook): Update.
5218
5219 2019-01-17  Tom Tromey  <tom@tromey.com>
5220
5221         * progspace.h (program_space) <objfiles_range>: New typedef.
5222         <objfiles>: New method.
5223         <objfiles_head>: Rename from objfiles.
5224         (object_files): Update.
5225         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5226         * guile/scm-pretty-print.c
5227         (ppscm_find_pretty_printer_from_objfiles): Update.
5228         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5229         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5230         Update.
5231         * python/py-progspace.c (pspy_get_objfiles): Update.
5232         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5233         Update.
5234         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5235         (objfpy_lookup_objfile_by_build_id): Update.
5236         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5237         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5238         Update.
5239         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5240         (expand_symtab_containing_pc, lookup_objfile_from_block)
5241         (lookup_static_symbol, basic_lookup_transparent_type)
5242         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5243         (find_line_symtab, info_sources_command)
5244         (default_collect_symbol_completion_matches_break_on)
5245         (make_source_files_completion_list, find_main_name): Update.
5246         * symmisc.c (print_symbol_bcache_statistics)
5247         (print_objfile_statistics, maintenance_print_symbols)
5248         (maintenance_print_msymbols, maintenance_print_objfiles)
5249         (maintenance_info_symtabs, maintenance_check_symtabs)
5250         (maintenance_expand_symtabs, maintenance_info_line_tables):
5251         Update.
5252         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5253         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5254         (map_overlay_command, unmap_overlay_command)
5255         (simple_overlay_update, expand_symtabs_matching)
5256         (map_symbol_filenames): Update.
5257         * symfile-debug.c (set_debug_symfile): Update.
5258         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5259         Update.
5260         * source.c (select_source_symtab, forget_cached_source_info):
5261         Update.
5262         * solib.c (solib_read_symbols): Update.
5263         * solib-spu.c (append_ocl_sos): Update.
5264         * psymtab.c (maintenance_print_psymbols)
5265         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5266         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5267         * printcmd.c (info_symbol_command): Update.
5268         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5269         Update.
5270         * objfiles.h (class all_objfiles): Remove.
5271         * objfiles.c (have_partial_symbols, have_full_symbols)
5272         (have_minimal_symbols, qsort_cmp, update_section_map)
5273         (shared_objfile_contains_address_p)
5274         (default_iterate_over_objfiles_in_search_order): Update.
5275         * objc-lang.c (info_selectors_command, info_classes_command)
5276         (find_methods): Update.
5277         * minsyms.c (find_solib_trampoline_target): Update.
5278         * maint.c (maintenance_info_sections)
5279         (maintenance_translate_address, count_symtabs_and_blocks):
5280         Update.
5281         * main.c (captured_main_1): Update.
5282         * linux-thread-db.c (try_thread_db_load_from_pdir)
5283         (has_libpthread): Update.
5284         * linespec.c (iterate_over_all_matching_symtabs)
5285         (search_minsyms_for_name): Update.
5286         * jit.c (jit_find_objf_with_entry_addr): Update.
5287         * hppa-tdep.c (find_unwind_entry)
5288         (hppa_lookup_stub_minimal_symbol): Update.
5289         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5290         Update.
5291         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5292         (elf_gnu_ifunc_resolve_by_got): Update.
5293         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5294         * dwarf-index-write.c (save_gdb_index_command): Update.
5295         * cp-support.c (add_symbol_overload_list_qualified): Update.
5296         * breakpoint.c (create_overlay_event_breakpoint)
5297         (create_longjmp_master_breakpoint)
5298         (create_std_terminate_master_breakpoint)
5299         (create_exception_master_breakpoint): Update.
5300         * blockframe.c (find_pc_partial_function): Update.
5301         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5302         (ada_collect_symbol_completion_matches)
5303         (ada_add_global_exceptions): Update.
5304
5305 2019-01-17  Tom Tromey  <tom@tromey.com>
5306
5307         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5308         declare VEC.
5309         (solib_target_parse_libraries): Change return type.
5310         (library_list_start_segment, library_list_start_section)
5311         (library_list_end_library, library_list_start_library); Update.
5312         (solib_target_free_library_list): Remove.
5313         (solib_target_parse_libraries): Remove cleanup.  Change return
5314         type.
5315         (solib_target_current_sos): Update.
5316
5317 2019-01-17  Tom Tromey  <tromey@bapiya>
5318
5319         * valprint.c: Replace "the the" with "the".
5320         * symtab.c: Replace "the the" with "the".
5321         * solib.c: Replace "the the" with "the".
5322         * solib-dsbt.c: Replace "the the" with "the".
5323         * linespec.c: Replace "the the" with "the".
5324         * dwarf2loc.h: Replace "the the" with "the".
5325         * amd64-windows-tdep.c: Replace "the the" with "the".
5326         * aarch64-tdep.c: Replace "the the" with "the".
5327
5328 2019-01-16  Keith Seitz  <keiths@redhat.com>
5329
5330         PR gdb/23773
5331         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5332         <builder>: Rename to ..
5333         <m_builder>: ... this and make private.
5334         (dwarf2_cu::get_builder): New method.  Change all users of
5335         `builder' to use this method.
5336         (dwarf2_start_symtab): Move to ...
5337         (dwarf2_cu::start_symtab): ... here.  Update all callers
5338         (setup_type_unit_groups): Move to ...
5339         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5340         callers.
5341         (dwarf2_cu::reset_builder): New method.
5342         (process_full_compunit, process_full_type_unit): Use
5343         dwarf2_cu::reset_builder.
5344         (follow_die_offset): Record the ancestor CU if it is different
5345         from the followed DIE's CU.
5346         (follow_die_sig_1): Likewise.
5347
5348 2019-01-15  Tom Tromey  <tom@tromey.com>
5349
5350         * remote.c (class remote_state) <buf>: Now a char_vector.
5351         <buf_size>: Remove.
5352         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5353         parameter.
5354         (remote_target::getpkt_or_notif_sane_1)
5355         (remote_target::getpkt_sane)
5356         (remote_target::getpkt_or_notif_sane): Likewise.
5357         (class remote_target) <putpkt>: New overload.
5358         (remote_target::read_frame): Change type of "buf_p".  Remove
5359         sizeof_p parameter.
5360         (packet_ok): New overload.
5361         (packet_check_result): New overload.
5362         Update all uses.
5363
5364 2019-01-14  Tom Tromey  <tom@tromey.com>
5365
5366         * remote-notif.c (handle_notification, remote_notif_ack)
5367         (remote_notif_parse): Make "buf" const.
5368         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5369         const.
5370         (remote_notif_parse, remote_notif_ack, handle_notification):
5371         Likewise.
5372         * remote.c (remote_notif_stop_parse): Make "buf" const.
5373         (remote_target::remote_parse_stop_reply): Make "buf" const.
5374         (remote_notif_stop_ack): Make "buf" const.
5375
5376 2019-01-14  Tom Tromey  <tom@tromey.com>
5377
5378         * remote.c (remote_console_output): Make parameter const.
5379
5380 2019-01-14  Tom Tromey  <tom@tromey.com>
5381
5382         * target-debug.h (target_debug_print_signals): Constify.
5383         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5384         * procfs.c (procfs_target::pass_signals): Update.
5385         * linux-nat.c (linux_nat_target::pass_signals): Update.
5386         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5387         * target-delegates.c: Rebuild.
5388         * remote.c (remote_target::program_signals): Update.
5389         (remote_target::pass_signals): Update.
5390         * target.c (target_pass_signals): Constify argument.
5391         (target_program_signals): Likewise.
5392         * target.h (struct target_ops) <pass_signals, program_signals>:
5393         Constify argument.
5394         (target_pass_signals, target_program_signals): Constify argument.
5395
5396 2019-01-14  Tom Tromey  <tom@tromey.com>
5397
5398         PR tui/28819:
5399         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5400
5401 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5402
5403         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5404         field.
5405         * rs6000-tdep.c: Include reggroups.h.
5406         (IS_V_ALIAS_PSEUDOREG): Define.
5407         (rs6000_register_name): Return names for the "vX" aliases.
5408         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5409         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5410         aliases.  Call default_register_reggroup_p for all other
5411         pseudo-registers.
5412         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5413         New functions.
5414         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5415         Handle "vX" aliases.
5416         (v_alias_pseudo_register_collect): New function.
5417         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5418         (rs6000_gdbarch_init): Initialize "vX" aliases as
5419         pseudo-registers.  Restore registration of
5420         rs6000_pseudo_register_reggroup_p with
5421         set_tdesc_pseudo_register_reggroup_p.
5422
5423 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5424
5425         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5426         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5427         set_gdbarch_num_pseudo_regs.
5428
5429 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5430
5431         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5432         Remove arg prefixname, add do_set and do_show.
5433         Add member functions set_list and show_list.
5434         * cli/cli-style.c (class cli_style_option): Update accordingly.
5435         (style_set_list): Move to file scope.
5436         (style_show_list): Likewise.
5437         (set_style): Call help_list.
5438         (show_style): Call cmd_show_list.
5439         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5440         Update to use the new macro.
5441
5442 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5443
5444         * ada-lang.c (_initialize_ada_language): Expand the help text
5445         for the "catch exception" command.
5446
5447 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5448
5449         * symtab.c (matching_obj_sections): Initialize obj,
5450         declare it closer to its usage.
5451
5452 2019-01-10  Tom Tromey  <tom@tromey.com>
5453
5454         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5455         (basic_inf_threads_range): Remove.
5456         (inf_threads_range, inf_non_exited_threads_range)
5457         (safe_inf_threads_range): Use next_adapter.
5458
5459 2019-01-10  Keith Seitz  <keiths@redhat.com>
5460
5461         PR gdb/23712
5462         PR symtab/23010
5463         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5464         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5465
5466 2019-01-10  Keith Seitz  <keiths@redhat.com>
5467
5468         PR gdb/23712
5469         PR symtab/23010
5470         * dictionary.c (pending_to_vector): Remove.
5471         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5472         Remove _1 suffix, replacing functions of the same name.  Update
5473         all callers.
5474         (dict_create_hashed, dict_create_hashed_expandable)
5475         (dict_create_linear, dict_create_linear_expandable, dict_free)
5476         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5477         Make functions static.
5478
5479 2019-01-10  Keith Seitz  <keiths@redhat.com>
5480
5481         PR gdb/23712
5482         PR symtab/23010
5483         * dictionary.h (struct dictionary): Replace declaration with
5484         multidictionary.
5485         (dict_create_hashed, dict_create_hashed_expandable)
5486         (dict_create_linear, dict_create_linear_expandable)
5487         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5488         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5489         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5490         taking multidictionary argument.
5491         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5492         * block.h (struct block) <dict>: Change to multidictionary
5493         and rename `multidict'.
5494         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5495         symmisc.c: Update all dictionary references to multidictionary.
5496
5497 2019-01-10  Keith Seitz  <keiths@redhat.com>
5498
5499         PR gdb/23712
5500         PR symtab/23010
5501         * dictionary.c: Include unordered_map.
5502         (pending_to_vector): New function.
5503         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5504         Rewrite the non-"_1" functions to take vector instead
5505         of linked list.
5506         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5507         "new" _1 versions of the same name.
5508         (multidictionary): Define.
5509         (std::hash<enum language): New definition.
5510         (collate_pending_symbols_by_language, mdict_create_hashed)
5511         (mdict_create_hashed_expandable, mdict_create_linear)
5512         (mdict_create_linear_expandable, mdict_free)
5513         (find_language_dictionary, create_new_language_dictionary)
5514         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5515         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5516         (mdict_size, mdict_empty): New functions.
5517         * dictionary.h (mdict_iterator): Define.
5518
5519 2019-01-10  Pedro Alves  <palves@redhat.com>
5520
5521         * breakpoint.c (read_uploaded_action)
5522         (create_tracepoint_from_upload): Adjust to use
5523         gdb::unique_xmalloc_ptr.
5524         * ctf.c (ctf_write_uploaded_tp):
5525         (SET_ARRAY_FIELD): Use emplace_back.
5526         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5527         * tracefile-tfile.c (tfile_write_uploaded_tp):
5528         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5529         gdb::unique_xmalloc_ptr.
5530         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5531         at_string, cond_string, cmd_strings>: Replace char pointers
5532         with gdb::unique_xmalloc_ptr.
5533
5534 2019-01-10  Pedro Alves  <palves@redhat.com>
5535
5536         * solib-target.c (library_list_start_library): Don't xstrdup name.
5537
5538 2019-01-10  Pedro Alves  <palves@redhat.com>
5539
5540         * mdebugread.c (parse_partial_symbols): Use
5541         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5542
5543 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5544
5545         * linux-fork.c (scoped_switch_fork_info)
5546         <~scoped_switch_fork_info>: Fix incorrect variable name.
5547
5548 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5549
5550         * linux-fork.c (scoped_switch_fork_info)
5551         <scoped_switch_fork_info>: Make explicit.
5552         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5553
5554 2019-01-10  Tom Tromey  <tom@tromey.com>
5555
5556         * objfiles.h (objfile::reset_psymtabs): Update.
5557         * objfiles.c (objfile::objfile): Update.
5558         * psymtab.h (psymtab_storage::obstack): Update.
5559         (psymtab_storage::m_obstack): Use gdb::optional.
5560         (class psymtab_storage): Update comment.  Remove objfile
5561         parameter.
5562         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5563
5564 2019-01-10  Tom Tromey  <tom@tromey.com>
5565
5566         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5567         <free_psymtabs>: Now private.
5568         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5569         (allocate_psymtab): Use new method.
5570
5571 2019-01-10  Tom Tromey  <tom@tromey.com>
5572
5573         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5574         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5575         * mdebugread.c (parse_partial_symbols): Use
5576         allocate_dependencies.
5577         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5578         allocate_dependencies.
5579         (process_psymtab_comp_unit_reader)
5580         (build_type_psymtab_dependencies): Likewise.
5581         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5582
5583 2019-01-10  Tom Tromey  <tom@tromey.com>
5584
5585         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5586         PSYMBOL_SET_LANGUAGE.
5587         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5588
5589 2019-01-10  Tom Tromey  <tom@tromey.com>
5590
5591         * psymtab.h (psymtab_storage::obstack): New method.
5592         <m_obstack>: Rename from obstack; now private.
5593         * psymtab.c (psymtab_storage): Update.
5594         * dwarf2read.c (create_addrmap_from_index)
5595         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5596         Update.
5597
5598 2019-01-10  Tom Tromey  <tom@tromey.com>
5599
5600         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5601         * objfiles.h (objfile::reset_psymtabs): New method.
5602
5603 2019-01-10  Tom Tromey  <tom@tromey.com>
5604
5605         * symmisc.c (print_symbol_bcache_statistics): Update.
5606         (print_objfile_statistics): Update.
5607         * symfile.c (reread_symbols): Update.
5608         * psymtab.h (class psymtab_storage): New.
5609         * psymtab.c (psymtab_storage): New constructor.
5610         (~psymtab_storage): New destructor.
5611         (require_partial_symbols): Update.
5612         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5613         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5614         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5615         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5616         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5617         (start_psymtab_common, end_psymtab_common)
5618         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5619         (allocate_psymtab): Update.
5620         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5621         Update.
5622         (dump_psymtab_addrmap, maintenance_print_psymbols)
5623         (maintenance_check_psymtabs): Update.
5624         (class objfile_psymtabs): Move to objfiles.h.
5625         * psympriv.h (discard_psymtab): Now inline.
5626         (psymtab_discarder::psymtab_discarder): Update.
5627         (psymtab_discarder::~psymtab_discarder): Update.
5628         (ALL_OBJFILE_PSYMTABS): Rewrite.
5629         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5630         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5631         Remove fields.
5632         <partial_symtabs>: New field.
5633         (class objfile_psymtabs): Move from psymtab.h.  Update.
5634         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5635         psymbol_cache.
5636         (objfile::~objfile): Don't destroy psymbol_cache.
5637         * mdebugread.c (parse_partial_symbols): Update.
5638         * dwarf2read.c (create_addrmap_from_index)
5639         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5640         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5641         (add_partial_subprogram, dwarf2_ranges_read): Update.
5642         * dwarf-index-write.c (write_address_map)
5643         (write_one_signatured_type, recursively_write_psymbols)
5644         (class debug_names, class debug_names, write_psymtabs_to_index):
5645         Update.
5646
5647 2019-01-10  Tom Tromey  <tom@tromey.com>
5648
5649         * symtab.h (SYMBOL_SET_NAMES): Update.
5650         (symbol_set_names): Update.
5651         (MSYMBOL_SET_NAMES): Update.
5652         * symtab.c (symbol_set_names): Change argument to be an
5653         objfile_per_bfd_storage.
5654         * psymtab.c (add_psymbol_to_bcache): Update.
5655         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5656
5657 2019-01-10  Tom Tromey  <tom@tromey.com>
5658
5659         * symtab.c (create_demangled_names_hash): Change argument to be an
5660         objfile_per_bfd_storage.
5661         (symbol_set_names): Update.
5662
5663 2019-01-10  Tom Tromey  <tom@tromey.com>
5664
5665         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5666         init_psymbol_list.
5667         * psymtab.c (init_psymbol_list): Do nothing if already called.
5668         * psympriv.h (init_psymbol_list): Add comment.
5669         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5670         init_psymbol_list.
5671         * dbxread.c (dbx_symfile_read): Unconditionally call
5672         init_psymbol_list.
5673
5674 2019-01-10  Tom Tromey  <tom@tromey.com>
5675
5676         * xcoffread.c (scan_xcoff_symtab): Update.
5677         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5678         "where".
5679         * mdebugread.c (parse_partial_symbols)
5680         (handle_psymbol_enumerators): Update.
5681         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5682         * dbxread.c (read_dbx_symtab): Update.
5683         * psympriv.h (psymbol_placement): New enum.
5684         (add_psymbol_to_list): Update.
5685
5686 2019-01-10  Tom Tromey  <tom@tromey.com>
5687
5688         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5689         static_psymbols parameters.
5690         (scan_xcoff_symtab): Update.
5691         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5692         static_psymbols parameters.
5693         * psympriv.h (start_psymtab_common): Update.
5694         * mdebugread.c (parse_partial_symbols): Update.
5695         * dwarf2read.c (create_partial_symtab): Update.
5696         * dbxread.c (read_dbx_symtab): Update.
5697         (start_psymtab): Remove global_psymbols and static_psymbols
5698         parameters.
5699
5700 2019-01-10  Tom Tromey  <tom@tromey.com>
5701
5702         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5703         * psymtab.c (allocate_psymtab): Add comment.
5704         * psympriv.h (allocate_psymtab): Add comment.
5705         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5706         initializations.
5707         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5708
5709 2019-01-10  Tom Tromey  <tom@tromey.com>
5710
5711         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5712         Don't declare.
5713         * mipsread.c: Include mdebugread.h.
5714         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5715         Declare.
5716         * elfread.c: Include mdebugread.h.
5717
5718 2019-01-09  Tom Tromey  <tom@tromey.com>
5719
5720         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5721         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5722         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5723         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5724         (psym_lookup_symbol, psym_find_last_source_symtab)
5725         (psym_forget_cached_source_info, psym_print_stats)
5726         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5727         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5728         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5729         (psym_find_compunit_symtab_by_address)
5730         (maintenance_print_psymbols, maintenance_info_psymtabs)
5731         (maintenance_check_psymtabs): Use ranged for.
5732         * psymtab.h (class objfile_psymtabs): New.
5733         (require_partial_symbols): Return objfile_psymtabs.
5734         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5735
5736 2019-01-09  Tom Tromey  <tom@tromey.com>
5737
5738         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5739         (find_pc_mapped_section, list_overlays_command)
5740         (map_overlay_command, unmap_overlay_command)
5741         (simple_overlay_update): Use all_objfiles.
5742         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5743         * printcmd.c (info_symbol_command): Use all_objfiles.
5744         * objfiles.h (ALL_OBJSECTIONS): Remove.
5745         * maint.c (maintenance_translate_address): Use all_objfiles.
5746         * gcore.c (gcore_create_callback): Use all_objfiles.
5747         (objfile_find_memory_regions): Likewise.
5748
5749 2019-01-09  Tom Tromey  <tom@tromey.com>
5750
5751         * symtab.c (find_line_symtab, info_sources_command)
5752         (make_source_files_completion_list): Use objfile_compunits.
5753         * source.c (select_source_symtab): Use objfile_compunits.
5754         * objfiles.h (struct objfile): Update comment.
5755         (ALL_OBJFILES): Remove.
5756         (ALL_FILETABS): Remove.
5757         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5758         objfile_compunits.
5759
5760 2019-01-09  Tom Tromey  <tom@tromey.com>
5761
5762         * symmisc.c (print_objfile_statistics, dump_objfile)
5763         (maintenance_print_symbols): Use compunit_filetabs.
5764         * source.c (forget_cached_source_info_for_objfile): Use
5765         compunit_filetabs.
5766         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5767         (ALL_FILETABS): Use compunit_filetabs.
5768         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5769         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5770
5771 2019-01-09  Tom Tromey  <tom@tromey.com>
5772
5773         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5774         (compunit_filetabs): New.
5775         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5776         compunit_filetabs.
5777         (info_sources_command, make_source_files_completion_list): Remove
5778         declaration.
5779         * symmisc.c (print_objfile_statistics, dump_objfile)
5780         (maintenance_print_symbols): Remove declaration.
5781         (maintenance_info_symtabs): Use compunit_filetabs.
5782         (maintenance_info_line_tables): Likewise.
5783         * source.c (select_source_symtab): Change local variable name.
5784         (forget_cached_source_info_for_objfile): Remove declaration.
5785         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5786         * objfiles.c (objfile_relocate1): Remove declaration.
5787         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5788         declaration.
5789         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5790         * coffread.c (coff_symtab_read): Remove declaration.
5791         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5792         compunit_filetabs.
5793
5794 2019-01-09  Tom Tromey  <tom@tromey.com>
5795
5796         * symtab.c (lookup_objfile_from_block)
5797         (find_pc_sect_compunit_symtab, search_symbols)
5798         (default_collect_symbol_completion_matches_break_on): Use
5799         objfile_compunits.
5800         * objfiles.h (ALL_COMPUNITS): Remove.
5801         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5802         * cp-support.c (add_symbol_overload_list_qualified): Use
5803         objfile_compunits.
5804         * ada-lang.c (ada_collect_symbol_completion_matches)
5805         (ada_add_global_exceptions): Use objfile_compunits.
5806
5807 2019-01-09  Tom Tromey  <tom@tromey.com>
5808
5809         * source.c (select_source_symtab)
5810         (forget_cached_source_info_for_objfile): Remove declaration.
5811         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5812         declaration.
5813         * maint.c (count_symtabs_and_blocks): Remove declaration.
5814         * cp-support.c (add_symbol_overload_list_qualified): Remove
5815         declaration.
5816         * coffread.c (coff_symtab_read): Remove declaration.
5817         * symtab.c (lookup_symbol_in_objfile_symtabs)
5818         (basic_lookup_transparent_type_1): Use objfile_compunits.
5819         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5820         (info_sources_command, search_symbols)
5821         (default_collect_symbol_completion_matches_break_on)
5822         (make_source_files_completion_list): Remove declaration.
5823         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5824         (ada_collect_symbol_completion_matches)
5825         (ada_add_global_exceptions): Remove declaration.
5826         * linespec.c (iterate_over_all_matching_symtabs): Use
5827         objfile_compunits.
5828         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5829         (class objfile_compunits): New.
5830         (ALL_COMPUNITS): Use objfile_compunits.
5831         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5832         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5833         objfile_compunits.
5834         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5835
5836 2019-01-09  Tom Tromey  <tom@tromey.com>
5837
5838         * symtab.c (search_symbols)
5839         (default_collect_symbol_completion_matches_break_on): Use
5840         objfile_msymbols.
5841         * ada-lang.c (ada_lookup_simple_minsym)
5842         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5843         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5844         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5845         objfile_msymbols.
5846         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5847         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5848         * objc-lang.c (find_methods): Use objfile_msymbols.
5849         (info_selectors_command, info_classes_command): Likewise.
5850         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5851         * objfiles.h (class objfile_msymbols): New.
5852         (ALL_OBJFILE_MSYMBOLS): Remove.
5853         (ALL_MSYMBOLS): Remove.
5854
5855 2019-01-09  Tom Tromey  <tom@tromey.com>
5856
5857         * common/next-iterator.h (next_adapter): Add Iterator template
5858         parameter.
5859         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5860         (class all_objfiles_safe): New.
5861         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5862         * objfiles.c (put_objfile_before): Update comment.
5863         (add_separate_debug_objfile): Likewise.
5864         (free_all_objfiles): Use all_objfiles_safe.
5865         (objfile_purge_solibs): Likewise.
5866
5867 2019-01-09  Tom Tromey  <tom@tromey.com>
5868
5869         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5870         (expand_symtab_containing_pc, lookup_static_symbol)
5871         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5872         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5873         all_objfiles.
5874         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5875         * breakpoint.c (create_overlay_event_breakpoint)
5876         (create_longjmp_master_breakpoint)
5877         (create_std_terminate_master_breakpoint)
5878         (create_exception_master_breakpoint): Use all_objfiles.
5879         * linux-thread-db.c (try_thread_db_load_from_pdir)
5880         (has_libpthread): Use all_objfiles.
5881         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5882         * linespec.c (iterate_over_all_matching_symtabs)
5883         (search_minsyms_for_name): Use all_objfiles.
5884         * maint.c (maintenance_info_sections): Use all_objfiles.
5885         * main.c (captured_main_1): Use all_objfiles.
5886         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5887         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5888         * guile/scm-pretty-print.c
5889         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5890         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5891         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5892         (maintenance_print_msymbols): Use all_objfiles.
5893         * source.c (select_source_symtab): Use all_objfiles.
5894         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5895         * symfile.c (remove_symbol_file_command)
5896         (expand_symtabs_matching, map_symbol_filenames): Use
5897         all_objfiles.
5898         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5899         all_objfiles.
5900         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5901         * objc-lang.c (find_methods): Use all_objfiles.
5902         * objfiles.c (have_partial_symbols, have_full_symbols)
5903         (have_minimal_symbols, qsort_cmp)
5904         (default_iterate_over_objfiles_in_search_order): Use
5905         all_objfiles.
5906         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5907         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5908         (maintenance_check_psymtabs): Use all_objfiles.
5909         (ALL_PSYMTABS): Remove.
5910         * compile/compile-object-run.c (do_module_cleanup): Use
5911         all_objfiles.
5912         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5913         * cp-support.c (add_symbol_overload_list_qualified): Use
5914         all_objfiles.
5915         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5916         Use all_objfiles.
5917         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5918         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5919         all_objfiles.
5920         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5921         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5922         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5923         Uses all_objfiles.
5924         * solib.c (solib_read_symbols): Use all_objfiles
5925
5926 2019-01-09  Tom Tromey  <tom@tromey.com>
5927
5928         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5929         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5930         all_objfiles.
5931         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5932         * symmisc.c (print_symbol_bcache_statistics)
5933         (print_objfile_statistics, maintenance_print_objfiles)
5934         (maintenance_info_symtabs, maintenance_check_symtabs)
5935         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5936         all_objfiles.
5937         * source.c (forget_cached_source_info): Use all_objfiles.
5938         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5939         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5940         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5941         * objfiles.c (update_section_map): Use all_objfiles.
5942         (shared_objfile_contains_address_p): Likewise.
5943         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5944         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5945
5946 2019-01-09  Tom Tromey  <tom@tromey.com>
5947
5948         * common/next-iterator.h: New file.
5949         * objfiles.h (class all_objfiles): New.
5950         (struct objfile_iterator): New.
5951
5952 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5953
5954         * NEWS: Move the description of the changed "frame", "select-frame",
5955          and "info frame" commands to the Changed commands section.
5956
5957 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5958
5959         * gdbtypes.c (check_stub_method_group): Remove handling of old
5960         mangling schemes.
5961         * linespec.c (find_methods): Likewise.
5962         * stabsread.c (read_member_functions): Likewise.
5963         * valops.c (search_struct_method): Likewise.
5964         (value_struct_elt_for_reference): Likewise.
5965         * NEWS: Mention this change.
5966
5967 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5968
5969         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5970         print_source_lines.
5971         * source.c (print_source_lines_base): Update line number check.
5972         (print_source_lines): New function.
5973         (source_lines_range::source_lines_range): New function.
5974         * source.h (class source_lines_range): New class.
5975         (print_source_lines): New declaration.
5976
5977 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5978
5979         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5980
5981 2019-01-08  Tom Tromey  <tom@tromey.com>
5982             Simon Marchi  <simon.marchi@ericsson.com>
5983
5984         PR gdb/24060
5985         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5986         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5987         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5988         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5989         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5990         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5991
5992 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5993
5994         * source.c (select_source_symtab): Move header comment to
5995         declaration in source.h.
5996         (forget_cached_source_info_for_objfile): Likewise.
5997         (forget_cached_source_info): Likewise.
5998         (identify_source_line): Likewise.
5999         * source.h (identify_source_line): Move declaration from symtab.h
6000         and add comment from source.c
6001         (print_source_lines): Likewise.
6002         (forget_cached_source_info_for_objfile): Likewise.
6003         (forget_cached_source_info): Likewise.
6004         (select_source_symtab): Likewise.
6005         (enum print_source_lines_flag): Move definition from symtab.h.
6006         * symtab.h (identify_source_line): Move declaration to source.h.
6007         (print_source_lines): Likewise.
6008         (forget_cached_source_info_for_objfile): Likewise.
6009         (forget_cached_source_info): Likewise.
6010         (select_source_symtab): Likewise.
6011         (enum print_source_lines_flag): Move definition to source.h.
6012         * tui/tui-hooks.c: Add 'source.h' include.
6013
6014 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6015
6016         * source.c (print_source_lines_base): Handle requests to print
6017         reverse line number sequences, and guard against empty lines
6018         string.
6019
6020 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6021
6022         * source.c (print_source_lines_base): Fix skip of '\r' if next
6023         character is '\n'.
6024
6025 2019-01-06  Tom Tromey  <tom@tromey.com>
6026
6027         * c-exp.y (struct c_parse_state) <macro_original_text,
6028         expansion_obstack>: New member.
6029         (macro_original_text, expansion_obstack): Remove globals.
6030         (scan_macro_expansion, scanning_macro_expansion)
6031         (finished_macro_expansion): Update.
6032         (scan_macro_cleanup): Remove.
6033         (yylex, c_parse): Update.
6034
6035 2019-01-06  Tom Tromey  <tom@tromey.com>
6036
6037         * c-exp.y (struct c_parse_state) <strings>: New member.
6038         (operator_stoken): Update.
6039
6040 2019-01-06  Tom Tromey  <tom@tromey.com>
6041
6042         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6043         (union type_stack_elt) <typelist_val>: Now a pointer to
6044         std::vector.
6045         (type_stack_cleanup): Don't declare.
6046         (push_typelist): Update.
6047         * parse.c (pop_typelist): Return a std::vector.
6048         (push_typelist): Take a std::vector.
6049         (follow_types): Update.  Do not free args.
6050         (type_stack_cleanup): Remove.
6051         * c-exp.y (struct c_parse_state): New.
6052         (cpstate): New global.
6053         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6054         (nonempty_typelist): Update.
6055         (func_mod): Create a new vector.
6056         (c_parse): Create a c_parse_state.
6057         (check_parameter_typelist): Do not delete params.
6058         (function_method): Update.  Do not delete type_list.
6059
6060 2019-01-06  Tom Tromey  <tom@tromey.com>
6061
6062         PR gdb/28155:
6063         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6064         check_typedef.
6065         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6066         (print_return_value): Likewise.
6067
6068 2019-01-05  Tom Tromey  <tom@tromey.com>
6069
6070         * contrib/cleanup_check.py: Remove.
6071         * contrib/gcc-with-excheck: Remove.
6072         * contrib/exsummary.py: Remove.
6073         * contrib/excheck.py: Remove.
6074
6075 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6076
6077         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6078         NULL. Initialize tpprev to NULL instead of assigning it
6079         to NULL on the next statement.
6080         * windows-nat.c (windows_delete_thread): Remove check for
6081         main_thread_id before printing thread exit notifications.
6082         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6083         Remove thread ID check against main_thread_id.
6084         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6085         windows_delete_thread.
6086         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6087
6088 2019-01-04  Tom Tromey  <tom@tromey.com>
6089
6090         * compile/compile.c (_initialize_compile): Use upper case for
6091         metasyntactic variables.
6092         * symmisc.c (_initialize_symmisc): Use upper case for
6093         metasyntactic variables.
6094         * psymtab.c (_initialize_psymtab): Use upper case for
6095         metasyntactic variables.
6096         * demangle.c (demangle_command): Use upper case for metasyntactic
6097         variables.
6098         (_initialize_demangler): Likewise.
6099         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6100         variables.
6101
6102 2019-01-03  Tom Tromey  <tom@tromey.com>
6103
6104         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6105
6106 2019-01-03  Tom Tromey  <tom@tromey.com>
6107
6108         * python/py-symtab.c (salpy_str): Update.
6109         (struct salpy_sal_object) <symtab>: Now a PyObject.
6110         (salpy_dealloc): Update.
6111         (del_objfile_sal): Use gdbpy_ref.
6112
6113 2019-01-03  Tom Tromey  <tom@tromey.com>
6114
6115         * python/py-type.c (convert_field): Use new_reference.  Return
6116         gdbpy_ref.
6117         (make_fielditem): Return gdbpy_ref.
6118         (typy_fields): Update.
6119         (typy_getitem): Update.
6120         (field_name): Return gdbpy_ref.  Use new_reference.
6121         (typy_iterator_iternext): Update.
6122
6123 2019-01-03  Tom Tromey  <tom@tromey.com>
6124
6125         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6126
6127 2019-01-03  Tom Tromey  <tom@tromey.com>
6128
6129         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6130         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6131         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6132         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6133         (pspy_set_type_printers): Likewise.
6134         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6135         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6136         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6137         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6138         (objfpy_set_type_printers): Likewise.
6139
6140 2019-01-03  Tom Tromey  <tom@tromey.com>
6141
6142         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6143         (gdbpy_print_stack): Use gdbpy_err_fetch.
6144         * python/python-internal.h (class gdbpy_err_fetch): New class.
6145         (class gdbpy_enter) <m_error_type, m_error_value,
6146         m_error_traceback>: Remove.
6147         <m_error>: New member.
6148         (gdbpy_exception_to_string): Don't declare.
6149         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6150         * python/py-value.c (convert_value_from_python): Use
6151         gdbpy_err_fetch.
6152         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6153         gdbpy_exception_to_string.
6154         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6155         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6156         gdbpy_err_fetch.
6157
6158 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6159
6160         * linux-nat.c (delete_lwp_cleanup): Delete.
6161         (struct lwp_deleter): New struct.
6162         (lwp_info_up): New typedef.
6163         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6164         lwp_info_up.
6165
6166 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6167
6168         * linux-fork.c (class scoped_switch_fork_info): New class.
6169         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6170
6171 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6172
6173         * valops.c (find_overload_match): Remove use of null_cleanup, and
6174         calls to do_cleanups.
6175
6176 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6177
6178         * compile/compile-cplus-types.c
6179         (compile_cplus_instance::decl_name): Handle changes to
6180         cp_func_name.
6181         * cp-support.c (cp_func_name): Update header comment, update
6182         return type.
6183         * cp-support.h (cp_func_name): Update return type in declaration.
6184         * valops.c (find_overload_match): Move temp_func local to top
6185         level of function and change its type.  Use temp_func to hold and
6186         delete temporary string obtained from cp_func_name.
6187
6188 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6189
6190         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6191         gdb::char_vector, remove cleanup, and update uses of `msg`.
6192
6193 2019-01-03  Jim Wilson  <jimw@sifive.com>
6194
6195         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6196
6197 2019-01-02  Tom Tromey  <tom@tromey.com>
6198
6199         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6200         (tdesc_parse_xml): Remove cleanups.
6201         * target-descriptions.h (make_cleanup_free_target_description):
6202         Don't declare.
6203         (target_desc_deleter): New struct.
6204         (target_desc_up): New typedef.
6205         * target-descriptions.c (target_desc_deleter::operator()): Rename
6206         from free_target_description.
6207         (make_cleanup_free_target_description): Remove.
6208
6209 2019-01-02  Tom Tromey  <tom@tromey.com>
6210
6211         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6212         constructor, destructor.
6213         (linespec_parser): Remove typedef.
6214         (~linespec_parser): Rename from linespec_parser_delete.
6215         (linespec_lex_to_end, linespec_complete_label)
6216         (linespec_complete): Update.
6217         (decode_line_full): Remove cleanups.
6218         (decode_line_1): Update.
6219
6220 2019-01-02  Tom Tromey  <tom@tromey.com>
6221
6222         * python/python-internal.h (inferior_to_inferior_object): Change
6223         return type.
6224         * python/py-exitedevent.c (create_exited_event_object): Update.
6225         * python/py-inferior.c (inferior_to_inferior_object): Return
6226         gdbpy_ref.
6227         (python_new_inferior, python_inferior_deleted)
6228         (thread_to_thread_object, delete_thread_object)
6229         (build_inferior_list, gdbpy_selected_inferior): Update.
6230         * python/py-infthread.c (create_thread_object): Update.  Also fail
6231         if inferior_to_inferior_object fails.
6232
6233 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6234
6235         * inferior.h (class inferior) <displaced_step_state>: New field.
6236         * infrun.h (struct displaced_step_state): Move here from
6237         infrun.c.  Initialize fields, add constructor.
6238         <inf>: Remove field.
6239         <reset>: New method.
6240         * infrun.c (struct displaced_step_inferior_state): Move to
6241         infrun.h.
6242         (displaced_step_inferior_states): Remove.
6243         (get_displaced_stepping_state): Adust.
6244         (displaced_step_in_progress_any_inferior): Adjust.
6245         (displaced_step_in_progress_thread): Adjust.
6246         (displaced_step_in_progress): Adjust.
6247         (add_displaced_stepping_state): Remove.
6248         (get_displaced_step_closure_by_addr): Adjust.
6249         (remove_displaced_stepping_state): Remove.
6250         (infrun_inferior_exit): Call displaced_step_state.reset.
6251         (use_displaced_stepping): Don't check for NULL.
6252         (displaced_step_prepare_throw): Call
6253         get_displaced_stepping_state.
6254         (displaced_step_fixup): Don't check for NULL.
6255         (prepare_for_detach): Don't check for NULL.
6256
6257 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6258
6259         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6260          in case of call that did not complete.
6261
6262 2019-01-02  Andrey Utkin  <autkin@undo.io>
6263
6264         * symfile.c (find_separate_debug_file): Fix search of debug files for
6265         remote debuggee.
6266
6267 2019-01-02  Tom Tromey  <tom@tromey.com>
6268
6269         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6270         indentation.
6271         * python/py-frame.c (frapy_older): Remove cast.
6272         (frapy_newer): Likewise.
6273         * python/py-breakpoint.c (local_setattro): Remove cast.
6274         * python/py-arch.c (archpy_name): Remove local variable.
6275         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6276
6277 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6278
6279         * unittests/basic_string_view/element_access/char/empty.cc:
6280         Fix year range in copyright header.
6281
6282 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6283
6284         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6285         Delete.
6286         <operator==>: Update with for removed field.
6287         <hash>: Likewise.
6288         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6289         <isa_features>: ...this.
6290         <abi_features>: New field.
6291         (riscv_isa_flen): Update comment.
6292         (riscv_abi_xlen): New declaration.
6293         (riscv_abi_flen): New declaration.
6294         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6295         isa_features.
6296         (riscv_abi_xlen): New function.
6297         (riscv_isa_flen): Update to get answer from isa_features.
6298         (riscv_abi_flen): New function.
6299         (riscv_has_fp_abi): Update to get answer from abi_features.
6300         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6301         xlen and flen.
6302         (riscv_call_info) <xlen, flen>: Update comment.
6303         (riscv_call_arg_struct): Remove invalid assertions
6304         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6305         is removed.
6306         (riscv_gdbarch_init): Gather isa features and abi features
6307         separately, ensure both match on the gdbarch when reusing an old
6308         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6309         a target with 64-bit float hardware.
6310
6311 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6312
6313         * source.c (search_command_helper): Stop reverse search
6314         when line 1 has been searched.
6315
6316 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6317
6318         * record-full.c (record_full_base_target::close): Rewrite
6319         record_full_core_buf_list free logic.
6320
6321 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6322
6323         * break-catch-syscall.c (print_one_catch_syscall): xfree
6324         the last text.
6325
6326 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6327
6328         * top.c (print_gdb_version): Update Copyright year in version
6329         message.
6330
6331 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6332
6333         Update copyright year range in all GDB files.
6334
6335 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6336
6337         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6338
6339 For older changes see ChangeLog-2018.
6340 \f
6341 Local Variables:
6342 mode: change-log
6343 left-margin: 8
6344 fill-column: 74
6345 version-control: never
6346 coding: utf-8
6347 End:
6348