gdb/ChangeLog

   1 2019-02-20  Tom Tromey  <tom@tromey.com>
   2
   3         * symtab.c (symtab_symbol_info): Fix typos.
   4
   5 2019-02-20  Tom Tromey  <tromey@adacore.com>
   6
   7         * findcmd.c (_initialize_mem_search): Use upper case for
   8         metasyntactic variables.
   9
  10 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
  11
  12         * aarch64-tdep.c (aarch64_add_reggroups): New function.
  13         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
  14
  15 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
  16
  17         * top.h (source_file_name): Change to std::string.
  18         * top.c (source_file_name): Likewise.
  19         (command_line_input): Adjust.
  20         * cli/cli-script.c (script_from_file): Adjust.
  21
  22 2019-02-19  Tom Tromey  <tromey@adacore.com>
  23
  24         * ravenscar-thread.c
  25         (ravenscar_thread_target::update_thread_list): Don't call
  26         ada_build_task_list.
  27         * ada-lang.h (ada_build_task_list): Don't declare.
  28         * ada-tasks.c (struct ada_tasks_inferior_data)
  29         <task_list_valid_p>: Now bool.
  30         (read_known_tasks, ada_task_list_changed)
  31         (ada_tasks_invalidate_inferior_data): Update.
  32         (read_known_tasks_array): Return bool.
  33         (read_known_tasks_list): Likewise.
  34         (read_known_tasks): Return void.
  35         (ada_build_task_list): Now static.
  36
  37 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  38
  39         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
  40         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
  41
  42 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  43
  44         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
  45         variant for ada_tasks_pspace_data_handle and
  46         ada_tasks_inferior_data_handle.
  47         (ada_tasks_pspace_data_cleanup): New function.
  48         (ada_tasks_inferior_data_cleanup): New function.
  49
  50 2019-02-17  Tom Tromey  <tom@tromey.com>
  51
  52         * macrotab.h (macro_source_fullname): Return a std::string.
  53         * macrotab.c (macro_include, check_for_redefinition)
  54         (macro_undef, macro_lookup_definition, foreach_macro)
  55         (foreach_macro_in_scope): Update.
  56         (macro_source_fullname): Return a std::string.
  57         * macrocmd.c (show_pp_source_pos): Update.
  58
  59 2019-02-17  Tom Tromey  <tom@tromey.com>
  60
  61         * macrocmd.c (show_pp_source_pos): Style the file names.
  62
  63 2019-02-17  Tom Tromey  <tom@tromey.com>
  64
  65         PR tui/24197:
  66         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
  67
  68 2019-02-17  Tom Tromey  <tom@tromey.com>
  69
  70         * ada-lang.c (user_select_syms): Use filtered printing.
  71         * utils.c (wrap_style): New global.
  72         (desired_style): Remove.
  73         (emit_style_escape): Add stream parameter.
  74         (set_output_style, reset_terminal_style, prompt_for_continue):
  75         Update.
  76         (flush_wrap_buffer): Only flush gdb_stdout.
  77         (wrap_here): Set wrap_style.
  78         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
  79         treat escape sequences as a character.  Change when wrap buffer is
  80         flushed.
  81         (fputs_styled): Do not set the output style when the default is
  82         requested.
  83         * ui-style.h (struct ui_file_style) <is_default>: New method.
  84         * source.c (print_source_lines_base): Emit escape sequences in one
  85         piece.
  86
  87 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  88
  89         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
  90         integers and enumeration types.
  91
  92 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  93
  94         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
  95         instead of lookup_symbol_in_language
  96         (do_exact_match): New function.
  97         (ada_get_symbol_name_matcher): Return do_exact_match when
  98         doing a verbatim match.
  99
 100 2019-02-15  Tom Tromey  <tromey@adacore.com>
 101
 102         * ravenscar-thread.c (ravenscar_thread_target::resume)
 103         (ravenscar_thread_target::wait): Special case wildcard requests.
 104
 105 2019-02-15  Tom Tromey  <tromey@adacore.com>
 106
 107         * ravenscar-thread.c (base_ptid): Remove.
 108         (struct ravenscar_thread_target) <close>: New method.
 109         <m_base_ptid>: New member.
 110         <update_inferior_ptid, active_task, task_is_currently_active,
 111         runtime_initialized>: Declare methods.
 112         <ravenscar_thread_target>: Add constructor.
 113         (ravenscar_thread_target::task_is_currently_active)
 114         (ravenscar_thread_target::update_inferior_ptid)
 115         (ravenscar_runtime_initialized): Rename.  Now methods.
 116         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 117         (ravenscar_thread_target::update_thread_list): Update.
 118         (ravenscar_thread_target::active_task): Now method.
 119         (ravenscar_thread_target::store_registers)
 120         (ravenscar_thread_target::prepare_to_store)
 121         (ravenscar_thread_target::prepare_to_store)
 122         (ravenscar_thread_target::mourn_inferior): Update.
 123         (ravenscar_inferior_created): Use "new" to create target.
 124         (ravenscar_thread_target::get_ada_task_ptid): Update.
 125         (_initialize_ravenscar): Don't initialize base_ptid.
 126         (ravenscar_ops): Remove global.
 127
 128 2019-02-15  Tom Tromey  <tromey@adacore.com>
 129
 130         * target.h (push_target): Declare new overload.
 131         * target.c (push_target): New overload, taking an rvalue reference.
 132         * remote.c (remote_target::open_1): Use push_target overload.
 133         * corelow.c (core_target_open): Use push_target overload.
 134
 135 2019-02-15  Tom Tromey  <tromey@adacore.com>
 136
 137         * ravenscar-thread.c (is_ravenscar_task)
 138         (ravenscar_task_is_currently_active): Return bool.
 139         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 140         (_initialize_ravenscar): Remove "(void)".
 141         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 142         Return bool.
 143
 144 2019-02-15  Tom Tromey  <tromey@adacore.com>
 145
 146         * ravenscar-thread.c (ravenscar_runtime_initializer)
 147         (has_ravenscar_runtime, get_running_thread_id)
 148         (ravenscar_thread_target::resume): Fix indentation.
 149
 150 2019-02-15  Tom Tromey  <tromey@adacore.com>
 151
 152         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 153         from ravenscar_arch_ops.
 154         (sparc_ravenscar_ops::fetch_registers)
 155         (sparc_ravenscar_ops::store_registers): Now methods.
 156         (sparc_ravenscar_prepare_to_store): Remove.
 157         (sparc_ravenscar_ops): Redefine.
 158         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 159         methods and destructor.  Remove members.
 160         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 161         (ravenscar_thread_target::store_registers)
 162         (ravenscar_thread_target::prepare_to_store): Update.
 163         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 164         Remove.
 165         (struct ppc_ravenscar_powerpc_ops): Derive from
 166         ravenscar_arch_ops.
 167         (ppc_ravenscar_powerpc_ops::fetch_registers)
 168         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 169         (ppc_ravenscar_powerpc_ops): Redefine.
 170         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 171         (ppc_ravenscar_e500_ops::fetch_registers)
 172         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 173         (ppc_ravenscar_e500_ops): Redefine.
 174         * aarch64-ravenscar-thread.c
 175         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 176         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 177         (aarch64_ravenscar_fetch_registers)
 178         (aarch64_ravenscar_store_registers): Now methods.
 179         (aarch64_ravenscar_ops): Redefine.
 180
 181 2019-02-15  Tom Tromey  <tromey@adacore.com>
 182
 183         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 184         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 185         (ravenscar_thread_target::stopped_by_watchpoint)
 186         (ravenscar_thread_target::stopped_data_address)
 187         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 188
 189 2019-02-15  Tom Tromey  <tromey@adacore.com>
 190
 191         * ravenscar-thread.c: Fix some typos.
 192
 193 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 194             Tom Tromey  <tromey@adacore.com>
 195
 196         * ada-lang.c (ada_exception_sal): Change addr_string to a
 197         std::string.
 198         (create_ada_exception_catchpoint): Update.
 199
 200 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 201             Tom Tromey  <tromey@adacore.com>
 202
 203         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 204         (bp_location_ops): Remove.
 205         (base_breakpoint_allocate_location): Update.
 206         (free_bp_location): Update.
 207         * ada-lang.c (class ada_catchpoint_location)
 208         <ada_catchpoint_location>: Remove ops parameter.
 209         (ada_catchpoint_location_dtor): Remove.
 210         (ada_catchpoint_location_ops): Remove.
 211         (allocate_location_exception): Update.
 212         * breakpoint.h (struct bp_location_ops): Remove.
 213         (class bp_location) <bp_location>: Remove bp_location_ops
 214         parameter.
 215         <~bp_location>: Add destructor.
 216         <ops>: Remove.
 217
 218 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 219             Pedro Alves  <palves@redhat.com>
 220
 221         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 222         'PATH_MAX'.
 223
 224 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 225             Samuel Thibault  <samuel.thibault@gnu.org>
 226             Thomas Schwinge  <thomas@codesourcery.com>
 227
 228         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 229         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 230
 231 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 232
 233         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 234         (check_empty): Use "const char *".
 235
 236         * gnu-nat.c (gnu_nat_target::detach): Instead of
 237         'detach_inferior (pid)' call
 238         'detach_inferior (find_inferior_pid (pid))'.
 239
 240         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 241         'nat/fork-inferior.o'.
 242         * gnu-nat.c: #include "nat/fork-inferior.h".
 243
 244         * gnu-nat.c (gnu_nat_target::detach): Instead of
 245         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 246         * gnu-nat.h: #include "inf-child.h".
 247         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 248         'i386_gnu_nat_target::fetch_registers'.
 249         (gnu_store_registers): Rename/move to
 250         'i386_gnu_nat_target::store_registers'.
 251
 252         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 253         * gnu-nat.h (mach_thread_info): New function.
 254         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 255
 256         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 257
 258 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 259
 260         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 261
 262 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 263
 264         * windows-nat.c (windows_add_thread): Add new parameter
 265         "main_thread_p" with default value set to false.  Update
 266         function documentation as well as all callers.
 267         (windows_delete_thread): Likewise.
 268         (fake_create_process): Update call to windows_add_thread.
 269         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 270         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 271         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 272         call to windows_delete_thread.
 273
 274 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 275
 276         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 277
 278 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 279
 280         * symfile.c (find_separate_debug_file): Use canonical path of
 281         sysroot with child_path instead of gdb_sysroot if it is valid.
 282
 283 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 284
 285         * symfile.c (find_separate_debug_file): Use child_path to
 286         determine if an object file is under a sysroot.
 287
 288 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 289
 290         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 291         unittests/child-path-selftests.c.
 292         * common/pathstuff.c (child_path): New function.
 293         * common/pathstuff.h (child_path): New prototype.
 294         * unittests/child-path-selftests.c: New file.
 295
 296 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 297
 298         * symfile.c (find_separate_debug_file): Look for separate debug
 299         files in debug directories under the sysroot.
 300
 301 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 302
 303         * symtab.h (struct minimal_symbol data_p): New const method.
 304         (struct minimal_symbol text_p): Likewise.
 305         * symtab.c (output_source_filename): Use file name style
 306         to print file name.
 307         (print_symbol_info): Likewise.
 308         (print_msymbol_info): Use address style to print addresses.
 309         Use function name style to print executable text symbols.
 310         (expand_symtab_containing_pc): Use data_p.
 311         (find_pc_sect_compunit_symtab): Likewise.
 312
 313 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 314
 315         * breakpoint.c (describe_other_breakpoints): Use address style
 316         to print addresses.
 317         (say_where): Likewise.
 318
 319 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 320
 321         * ada-typeprint.c (print_func_type): Print function name
 322         style to print function name.
 323         * c-typeprint.c (c_print_type_1): Likewise.
 324
 325 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 326
 327         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 328         for execve.
 329
 330 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 331
 332         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 333         type_stack.
 334
 335 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 336
 337         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 338         TYPE_CODE_REF types.
 339
 340 2019-02-08  Jim Wilson  <jimw@sifive.com>
 341
 342         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 343         (riscv_linux_fregset): New.
 344         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 345
 346 2019-02-07  Tom Tromey  <tom@tromey.com>
 347
 348         * thread.c (thread_cancel_execution_command): Update.
 349         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 350         methods.
 351         (struct thread_fsm_ops): Remove.
 352         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 353         (thread_fsm_should_stop, thread_fsm_return_value)
 354         (thread_fsm_set_finished, thread_fsm_finished_p)
 355         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 356         Don't declare.
 357         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 358         * infrun.c (clear_proceed_status_thread)
 359         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 360         (print_stop_event): Update.
 361         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 362         Add constructor.
 363         (step_command_fsm_ops): Remove.
 364         (new_step_command_fsm): Remove.
 365         (step_1): Update.
 366         (step_command_fsm::should_stop): Rename from
 367         step_command_fsm_should_stop.
 368         (step_command_fsm::clean_up): Rename from
 369         step_command_fsm_clean_up.
 370         (step_command_fsm::do_async_reply_reason): Rename from
 371         step_command_fsm_async_reply_reason.
 372         (struct until_next_fsm): Inherit from thread_fsm.  Add
 373         constructor.
 374         (until_next_fsm_ops): Remove.
 375         (new_until_next_fsm): Remove.
 376         (until_next_fsm::should_stop): Rename from
 377         until_next_fsm_should_stop.
 378         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 379         (until_next_fsm::do_async_reply_reason): Rename from
 380         until_next_fsm_async_reply_reason.
 381         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 382         constructor.  Change type of breakpoint.
 383         (finish_command_fsm_ops): Remove.
 384         (new_finish_command_fsm): Remove.
 385         (finish_command_fsm::should_stop): Rename from
 386         finish_command_fsm_should_stop.
 387         (finish_command_fsm::clean_up): Rename from
 388         finish_command_fsm_clean_up.
 389         (finish_command_fsm::return_value): Rename from
 390         finish_command_fsm_return_value.
 391         (finish_command_fsm::do_async_reply_reason): Rename from
 392         finish_command_fsm_async_reply_reason.
 393         (finish_command): Update.
 394         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 395         Add constructor.
 396         (call_thread_fsm_ops): Remove.
 397         (call_thread_fsm::call_thread_fsm): Rename from
 398         new_call_thread_fsm.
 399         (call_thread_fsm::should_stop): Rename from
 400         call_thread_fsm_should_stop.
 401         (call_thread_fsm::should_notify_stop): Rename from
 402         call_thread_fsm_should_notify_stop.
 403         (run_inferior_call, call_function_by_hand_dummy): Update.
 404         * cli/cli-interp.c (should_print_stop_to_console): Update.
 405         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 406         Add constructor.  Change type of location_breakpoint,
 407         caller_breakpoint.
 408         (until_break_fsm_ops): Remove.
 409         (new_until_break_fsm): Remove.
 410         (until_break_fsm::should_stop): Rename from
 411         until_break_fsm_should_stop.
 412         (until_break_fsm::clean_up): Rename from
 413         until_break_fsm_clean_up.
 414         (until_break_fsm::do_async_reply_reason): Rename from
 415         until_break_fsm_async_reply_reason.
 416         (until_break_command): Update.
 417         * thread-fsm.c: Remove.
 418         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 419
 420 2019-02-07  Tom Tromey  <tom@tromey.com>
 421
 422         * yy-remap.h: Add include guard.
 423         * xtensa-tdep.h: Add include guard.
 424         * xcoffread.h: Rename include guard.
 425         * varobj-iter.h: Add include guard.
 426         * tui/tui.h: Rename include guard.
 427         * tui/tui-winsource.h: Rename include guard.
 428         * tui/tui-wingeneral.h: Rename include guard.
 429         * tui/tui-windata.h: Rename include guard.
 430         * tui/tui-win.h: Rename include guard.
 431         * tui/tui-stack.h: Rename include guard.
 432         * tui/tui-source.h: Rename include guard.
 433         * tui/tui-regs.h: Rename include guard.
 434         * tui/tui-out.h: Rename include guard.
 435         * tui/tui-layout.h: Rename include guard.
 436         * tui/tui-io.h: Rename include guard.
 437         * tui/tui-hooks.h: Rename include guard.
 438         * tui/tui-file.h: Rename include guard.
 439         * tui/tui-disasm.h: Rename include guard.
 440         * tui/tui-data.h: Rename include guard.
 441         * tui/tui-command.h: Rename include guard.
 442         * tic6x-tdep.h: Add include guard.
 443         * target/waitstatus.h: Rename include guard.
 444         * target/wait.h: Rename include guard.
 445         * target/target.h: Rename include guard.
 446         * target/resume.h: Rename include guard.
 447         * target-float.h: Rename include guard.
 448         * stabsread.h: Add include guard.
 449         * rs6000-tdep.h: Add include guard.
 450         * riscv-fbsd-tdep.h: Add include guard.
 451         * regformats/regdef.h: Rename include guard.
 452         * record.h: Rename include guard.
 453         * python/python.h: Rename include guard.
 454         * python/python-internal.h: Rename include guard.
 455         * python/py-stopevent.h: Rename include guard.
 456         * python/py-ref.h: Rename include guard.
 457         * python/py-record.h: Rename include guard.
 458         * python/py-record-full.h: Rename include guard.
 459         * python/py-record-btrace.h: Rename include guard.
 460         * python/py-instruction.h: Rename include guard.
 461         * python/py-events.h: Rename include guard.
 462         * python/py-event.h: Rename include guard.
 463         * procfs.h: Add include guard.
 464         * proc-utils.h: Add include guard.
 465         * p-lang.h: Add include guard.
 466         * or1k-tdep.h: Rename include guard.
 467         * observable.h: Rename include guard.
 468         * nto-tdep.h: Rename include guard.
 469         * nat/x86-linux.h: Rename include guard.
 470         * nat/x86-linux-dregs.h: Rename include guard.
 471         * nat/x86-gcc-cpuid.h: Add include guard.
 472         * nat/x86-dregs.h: Rename include guard.
 473         * nat/x86-cpuid.h: Rename include guard.
 474         * nat/ppc-linux.h: Rename include guard.
 475         * nat/mips-linux-watch.h: Rename include guard.
 476         * nat/linux-waitpid.h: Rename include guard.
 477         * nat/linux-ptrace.h: Rename include guard.
 478         * nat/linux-procfs.h: Rename include guard.
 479         * nat/linux-osdata.h: Rename include guard.
 480         * nat/linux-nat.h: Rename include guard.
 481         * nat/linux-namespaces.h: Rename include guard.
 482         * nat/linux-btrace.h: Rename include guard.
 483         * nat/glibc_thread_db.h: Rename include guard.
 484         * nat/gdb_thread_db.h: Rename include guard.
 485         * nat/gdb_ptrace.h: Rename include guard.
 486         * nat/fork-inferior.h: Rename include guard.
 487         * nat/amd64-linux-siginfo.h: Rename include guard.
 488         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 489         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 490         * nat/aarch64-linux.h: Rename include guard.
 491         * nat/aarch64-linux-hw-point.h: Rename include guard.
 492         * mn10300-tdep.h: Add include guard.
 493         * mips-linux-tdep.h: Add include guard.
 494         * mi/mi-parse.h: Rename include guard.
 495         * mi/mi-out.h: Rename include guard.
 496         * mi/mi-main.h: Rename include guard.
 497         * mi/mi-interp.h: Rename include guard.
 498         * mi/mi-getopt.h: Rename include guard.
 499         * mi/mi-console.h: Rename include guard.
 500         * mi/mi-common.h: Rename include guard.
 501         * mi/mi-cmds.h: Rename include guard.
 502         * mi/mi-cmd-break.h: Rename include guard.
 503         * m2-lang.h: Add include guard.
 504         * location.h: Rename include guard.
 505         * linux-record.h: Rename include guard.
 506         * linux-nat.h: Add include guard.
 507         * linux-fork.h: Add include guard.
 508         * i386-darwin-tdep.h: Rename include guard.
 509         * hppa-linux-offsets.h: Add include guard.
 510         * guile/guile.h: Rename include guard.
 511         * guile/guile-internal.h: Rename include guard.
 512         * gnu-nat.h: Rename include guard.
 513         * gdb-stabs.h: Rename include guard.
 514         * frv-tdep.h: Add include guard.
 515         * f-lang.h: Add include guard.
 516         * event-loop.h: Add include guard.
 517         * darwin-nat.h: Rename include guard.
 518         * cp-abi.h: Rename include guard.
 519         * config/sparc/nm-sol2.h: Rename include guard.
 520         * config/nm-nto.h: Rename include guard.
 521         * config/nm-linux.h: Add include guard.
 522         * config/i386/nm-i386gnu.h: Rename include guard.
 523         * config/djgpp/nl_types.h: Rename include guard.
 524         * config/djgpp/langinfo.h: Rename include guard.
 525         * compile/gcc-cp-plugin.h: Add include guard.
 526         * compile/gcc-c-plugin.h: Add include guard.
 527         * compile/compile.h: Rename include guard.
 528         * compile/compile-object-run.h: Rename include guard.
 529         * compile/compile-object-load.h: Rename include guard.
 530         * compile/compile-internal.h: Rename include guard.
 531         * compile/compile-cplus.h: Rename include guard.
 532         * compile/compile-c.h: Rename include guard.
 533         * common/xml-utils.h: Rename include guard.
 534         * common/x86-xstate.h: Rename include guard.
 535         * common/version.h: Rename include guard.
 536         * common/vec.h: Rename include guard.
 537         * common/tdesc.h: Rename include guard.
 538         * common/selftest.h: Rename include guard.
 539         * common/scoped_restore.h: Rename include guard.
 540         * common/scoped_mmap.h: Rename include guard.
 541         * common/scoped_fd.h: Rename include guard.
 542         * common/safe-iterator.h: Rename include guard.
 543         * common/run-time-clock.h: Rename include guard.
 544         * common/refcounted-object.h: Rename include guard.
 545         * common/queue.h: Rename include guard.
 546         * common/ptid.h: Rename include guard.
 547         * common/print-utils.h: Rename include guard.
 548         * common/preprocessor.h: Rename include guard.
 549         * common/pathstuff.h: Rename include guard.
 550         * common/observable.h: Rename include guard.
 551         * common/netstuff.h: Rename include guard.
 552         * common/job-control.h: Rename include guard.
 553         * common/host-defs.h: Rename include guard.
 554         * common/gdb_wait.h: Rename include guard.
 555         * common/gdb_vecs.h: Rename include guard.
 556         * common/gdb_unlinker.h: Rename include guard.
 557         * common/gdb_unique_ptr.h: Rename include guard.
 558         * common/gdb_tilde_expand.h: Rename include guard.
 559         * common/gdb_sys_time.h: Rename include guard.
 560         * common/gdb_string_view.h: Rename include guard.
 561         * common/gdb_splay_tree.h: Rename include guard.
 562         * common/gdb_setjmp.h: Rename include guard.
 563         * common/gdb_ref_ptr.h: Rename include guard.
 564         * common/gdb_optional.h: Rename include guard.
 565         * common/gdb_locale.h: Rename include guard.
 566         * common/gdb_assert.h: Rename include guard.
 567         * common/filtered-iterator.h: Rename include guard.
 568         * common/filestuff.h: Rename include guard.
 569         * common/fileio.h: Rename include guard.
 570         * common/environ.h: Rename include guard.
 571         * common/common-utils.h: Rename include guard.
 572         * common/common-types.h: Rename include guard.
 573         * common/common-regcache.h: Rename include guard.
 574         * common/common-inferior.h: Rename include guard.
 575         * common/common-gdbthread.h: Rename include guard.
 576         * common/common-exceptions.h: Rename include guard.
 577         * common/common-defs.h: Rename include guard.
 578         * common/common-debug.h: Rename include guard.
 579         * common/cleanups.h: Rename include guard.
 580         * common/buffer.h: Rename include guard.
 581         * common/btrace-common.h: Rename include guard.
 582         * common/break-common.h: Rename include guard.
 583         * cli/cli-utils.h: Rename include guard.
 584         * cli/cli-style.h: Rename include guard.
 585         * cli/cli-setshow.h: Rename include guard.
 586         * cli/cli-script.h: Rename include guard.
 587         * cli/cli-interp.h: Rename include guard.
 588         * cli/cli-decode.h: Rename include guard.
 589         * cli/cli-cmds.h: Rename include guard.
 590         * charset-list.h: Add include guard.
 591         * buildsym-legacy.h: Rename include guard.
 592         * bfin-tdep.h: Add include guard.
 593         * ax.h: Rename include guard.
 594         * arm-linux-tdep.h: Add include guard.
 595         * arm-fbsd-tdep.h: Add include guard.
 596         * arch/xtensa.h: Rename include guard.
 597         * arch/tic6x.h: Add include guard.
 598         * arch/i386.h: Add include guard.
 599         * arch/arm.h: Rename include guard.
 600         * arch/arm-linux.h: Rename include guard.
 601         * arch/arm-get-next-pcs.h: Rename include guard.
 602         * arch/amd64.h: Add include guard.
 603         * arch/aarch64-insn.h: Rename include guard.
 604         * arch-utils.h: Rename include guard.
 605         * annotate.h: Add include guard.
 606         * amd64-darwin-tdep.h: Rename include guard.
 607         * aarch64-linux-tdep.h: Add include guard.
 608         * aarch64-fbsd-tdep.h: Add include guard.
 609         * aarch32-linux-nat.h: Add include guard.
 610
 611 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 612
 613         * macrotab.c (macro_define_internal): New function that
 614         factorizes macro_define_object_internal and macro_define_function
 615         code.
 616         (macro_define_object_internal): Use macro_define_internal.
 617         (macro_define_function): Likewise.
 618
 619 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 620
 621         * macrocmd.c (extract_identifier): Return
 622         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 623         callers.
 624
 625 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 626
 627         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 628
 629 2019-02-05  Tom Tromey  <tom@tromey.com>
 630
 631         * target.c (target_stack::unpush): Move assertion earlier.
 632
 633 2019-01-30  Tom Tromey  <tom@tromey.com>
 634
 635         PR python/23615:
 636         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 637         (gdbpy_parse_and_eval): Likewise.
 638         * python/python-internal.h (gdbpy_allow_threads): New class.
 639
 640 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 641
 642         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 643         (aarch64_fbsd_fpregmap): Move earlier.
 644         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 645         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 646         instead of individual calls to trad_frame_set_reg_addr.
 647         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 648         earlier.
 649         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 650         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 651         instead of individual calls to trad_frame_set_reg_addr.
 652
 653 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 654
 655         * CONTRIBUTE: Replace contribution list with wiki link.
 656
 657 2019-01-25  Tom Tromey  <tom@tromey.com>
 658
 659         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 660
 661 2019-01-25  Tom Tromey  <tom@tromey.com>
 662
 663         * xtensa-linux-nat.c: Fix common/ includes.
 664         * xml-support.h: Fix common/ includes.
 665         * xml-support.c: Fix common/ includes.
 666         * x86-linux-nat.c: Fix common/ includes.
 667         * windows-nat.c: Fix common/ includes.
 668         * varobj.h: Fix common/ includes.
 669         * varobj.c: Fix common/ includes.
 670         * value.c: Fix common/ includes.
 671         * valops.c: Fix common/ includes.
 672         * utils.c: Fix common/ includes.
 673         * unittests/xml-utils-selftests.c: Fix common/ includes.
 674         * unittests/utils-selftests.c: Fix common/ includes.
 675         * unittests/unpack-selftests.c: Fix common/ includes.
 676         * unittests/tracepoint-selftests.c: Fix common/ includes.
 677         * unittests/style-selftests.c: Fix common/ includes.
 678         * unittests/string_view-selftests.c: Fix common/ includes.
 679         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 680         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 681         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 682         * unittests/rsp-low-selftests.c: Fix common/ includes.
 683         * unittests/parse-connection-spec-selftests.c: Fix common/
 684         includes.
 685         * unittests/optional-selftests.c: Fix common/ includes.
 686         * unittests/offset-type-selftests.c: Fix common/ includes.
 687         * unittests/observable-selftests.c: Fix common/ includes.
 688         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 689         * unittests/memrange-selftests.c: Fix common/ includes.
 690         * unittests/memory-map-selftests.c: Fix common/ includes.
 691         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 692         * unittests/function-view-selftests.c: Fix common/ includes.
 693         * unittests/environ-selftests.c: Fix common/ includes.
 694         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 695         * unittests/common-utils-selftests.c: Fix common/ includes.
 696         * unittests/cli-utils-selftests.c: Fix common/ includes.
 697         * unittests/array-view-selftests.c: Fix common/ includes.
 698         * ui-file.c: Fix common/ includes.
 699         * tui/tui-io.c: Fix common/ includes.
 700         * tracepoint.h: Fix common/ includes.
 701         * tracepoint.c: Fix common/ includes.
 702         * tracefile-tfile.c: Fix common/ includes.
 703         * top.h: Fix common/ includes.
 704         * top.c: Fix common/ includes.
 705         * thread.c: Fix common/ includes.
 706         * target/waitstatus.h: Fix common/ includes.
 707         * target/waitstatus.c: Fix common/ includes.
 708         * target.h: Fix common/ includes.
 709         * target.c: Fix common/ includes.
 710         * target-memory.c: Fix common/ includes.
 711         * target-descriptions.c: Fix common/ includes.
 712         * symtab.h: Fix common/ includes.
 713         * symfile.c: Fix common/ includes.
 714         * stap-probe.c: Fix common/ includes.
 715         * spu-linux-nat.c: Fix common/ includes.
 716         * sparc-nat.c: Fix common/ includes.
 717         * source.c: Fix common/ includes.
 718         * solib.c: Fix common/ includes.
 719         * solib-target.c: Fix common/ includes.
 720         * ser-unix.c: Fix common/ includes.
 721         * ser-tcp.c: Fix common/ includes.
 722         * ser-pipe.c: Fix common/ includes.
 723         * ser-base.c: Fix common/ includes.
 724         * selftest-arch.c: Fix common/ includes.
 725         * s12z-tdep.c: Fix common/ includes.
 726         * rust-exp.y: Fix common/ includes.
 727         * rs6000-aix-tdep.c: Fix common/ includes.
 728         * riscv-tdep.c: Fix common/ includes.
 729         * remote.c: Fix common/ includes.
 730         * remote-notif.h: Fix common/ includes.
 731         * remote-fileio.h: Fix common/ includes.
 732         * remote-fileio.c: Fix common/ includes.
 733         * regcache.h: Fix common/ includes.
 734         * regcache.c: Fix common/ includes.
 735         * record-btrace.c: Fix common/ includes.
 736         * python/python.c: Fix common/ includes.
 737         * python/py-type.c: Fix common/ includes.
 738         * python/py-inferior.c: Fix common/ includes.
 739         * progspace.h: Fix common/ includes.
 740         * producer.c: Fix common/ includes.
 741         * procfs.c: Fix common/ includes.
 742         * proc-api.c: Fix common/ includes.
 743         * printcmd.c: Fix common/ includes.
 744         * ppc-linux-nat.c: Fix common/ includes.
 745         * parser-defs.h: Fix common/ includes.
 746         * osdata.c: Fix common/ includes.
 747         * obsd-nat.c: Fix common/ includes.
 748         * nat/x86-linux.c: Fix common/ includes.
 749         * nat/x86-linux-dregs.c: Fix common/ includes.
 750         * nat/x86-dregs.h: Fix common/ includes.
 751         * nat/x86-dregs.c: Fix common/ includes.
 752         * nat/ppc-linux.c: Fix common/ includes.
 753         * nat/mips-linux-watch.h: Fix common/ includes.
 754         * nat/mips-linux-watch.c: Fix common/ includes.
 755         * nat/linux-waitpid.c: Fix common/ includes.
 756         * nat/linux-ptrace.h: Fix common/ includes.
 757         * nat/linux-ptrace.c: Fix common/ includes.
 758         * nat/linux-procfs.c: Fix common/ includes.
 759         * nat/linux-personality.c: Fix common/ includes.
 760         * nat/linux-osdata.c: Fix common/ includes.
 761         * nat/linux-namespaces.c: Fix common/ includes.
 762         * nat/linux-btrace.h: Fix common/ includes.
 763         * nat/linux-btrace.c: Fix common/ includes.
 764         * nat/fork-inferior.c: Fix common/ includes.
 765         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 766         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 767         * nat/aarch64-linux.c: Fix common/ includes.
 768         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 769         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 770         * namespace.h: Fix common/ includes.
 771         * mips-linux-tdep.c: Fix common/ includes.
 772         * minsyms.c: Fix common/ includes.
 773         * mi/mi-parse.h: Fix common/ includes.
 774         * mi/mi-main.c: Fix common/ includes.
 775         * mi/mi-cmd-env.c: Fix common/ includes.
 776         * memrange.h: Fix common/ includes.
 777         * memattr.c: Fix common/ includes.
 778         * maint.h: Fix common/ includes.
 779         * maint.c: Fix common/ includes.
 780         * main.c: Fix common/ includes.
 781         * machoread.c: Fix common/ includes.
 782         * location.c: Fix common/ includes.
 783         * linux-thread-db.c: Fix common/ includes.
 784         * linux-nat.c: Fix common/ includes.
 785         * linux-fork.c: Fix common/ includes.
 786         * inline-frame.c: Fix common/ includes.
 787         * infrun.c: Fix common/ includes.
 788         * inflow.c: Fix common/ includes.
 789         * inferior.h: Fix common/ includes.
 790         * inferior.c: Fix common/ includes.
 791         * infcmd.c: Fix common/ includes.
 792         * inf-ptrace.c: Fix common/ includes.
 793         * inf-child.c: Fix common/ includes.
 794         * ia64-linux-nat.c: Fix common/ includes.
 795         * i387-tdep.c: Fix common/ includes.
 796         * i386-tdep.c: Fix common/ includes.
 797         * i386-linux-tdep.c: Fix common/ includes.
 798         * i386-linux-nat.c: Fix common/ includes.
 799         * i386-go32-tdep.c: Fix common/ includes.
 800         * i386-fbsd-tdep.c: Fix common/ includes.
 801         * i386-fbsd-nat.c: Fix common/ includes.
 802         * guile/scm-type.c: Fix common/ includes.
 803         * guile/guile.c: Fix common/ includes.
 804         * go32-nat.c: Fix common/ includes.
 805         * gnu-nat.c: Fix common/ includes.
 806         * gdbthread.h: Fix common/ includes.
 807         * gdbarch-selftests.c: Fix common/ includes.
 808         * gdb_usleep.c: Fix common/ includes.
 809         * gdb_select.h: Fix common/ includes.
 810         * gdb_bfd.c: Fix common/ includes.
 811         * gcore.c: Fix common/ includes.
 812         * fork-child.c: Fix common/ includes.
 813         * findvar.c: Fix common/ includes.
 814         * fbsd-nat.c: Fix common/ includes.
 815         * event-top.c: Fix common/ includes.
 816         * event-loop.c: Fix common/ includes.
 817         * dwarf2read.c: Fix common/ includes.
 818         * dwarf2loc.c: Fix common/ includes.
 819         * dwarf2-frame.c: Fix common/ includes.
 820         * dwarf-index-cache.c: Fix common/ includes.
 821         * dtrace-probe.c: Fix common/ includes.
 822         * disasm-selftests.c: Fix common/ includes.
 823         * defs.h: Fix common/ includes.
 824         * csky-tdep.c: Fix common/ includes.
 825         * cp-valprint.c: Fix common/ includes.
 826         * cp-support.h: Fix common/ includes.
 827         * cp-support.c: Fix common/ includes.
 828         * corelow.c: Fix common/ includes.
 829         * completer.h: Fix common/ includes.
 830         * completer.c: Fix common/ includes.
 831         * compile/compile.c: Fix common/ includes.
 832         * compile/compile-loc2c.c: Fix common/ includes.
 833         * compile/compile-cplus-types.c: Fix common/ includes.
 834         * compile/compile-cplus-symbols.c: Fix common/ includes.
 835         * command.h: Fix common/ includes.
 836         * cli/cli-dump.c: Fix common/ includes.
 837         * cli/cli-cmds.c: Fix common/ includes.
 838         * charset.c: Fix common/ includes.
 839         * build-id.c: Fix common/ includes.
 840         * btrace.h: Fix common/ includes.
 841         * btrace.c: Fix common/ includes.
 842         * breakpoint.h: Fix common/ includes.
 843         * breakpoint.c: Fix common/ includes.
 844         * ax.h:
 845         (enum agent_op): Fix common/ includes.
 846         * ax-general.c (struct aop_map): Fix common/ includes.
 847         * ax-gdb.c: Fix common/ includes.
 848         * auxv.c: Fix common/ includes.
 849         * auto-load.c: Fix common/ includes.
 850         * arm-tdep.c: Fix common/ includes.
 851         * arch/riscv.c: Fix common/ includes.
 852         * arch/ppc-linux-common.c: Fix common/ includes.
 853         * arch/i386.c: Fix common/ includes.
 854         * arch/arm.c: Fix common/ includes.
 855         * arch/arm-linux.c: Fix common/ includes.
 856         * arch/arm-get-next-pcs.c: Fix common/ includes.
 857         * arch/amd64.c: Fix common/ includes.
 858         * arch/aarch64.c: Fix common/ includes.
 859         * arch/aarch64-insn.c: Fix common/ includes.
 860         * arch-utils.c: Fix common/ includes.
 861         * amd64-windows-tdep.c: Fix common/ includes.
 862         * amd64-tdep.c: Fix common/ includes.
 863         * amd64-sol2-tdep.c: Fix common/ includes.
 864         * amd64-obsd-tdep.c: Fix common/ includes.
 865         * amd64-nbsd-tdep.c: Fix common/ includes.
 866         * amd64-linux-tdep.c: Fix common/ includes.
 867         * amd64-linux-nat.c: Fix common/ includes.
 868         * amd64-fbsd-tdep.c: Fix common/ includes.
 869         * amd64-fbsd-nat.c: Fix common/ includes.
 870         * amd64-dicos-tdep.c: Fix common/ includes.
 871         * amd64-darwin-tdep.c: Fix common/ includes.
 872         * agent.c: Fix common/ includes.
 873         * ada-lang.h: Fix common/ includes.
 874         * ada-lang.c: Fix common/ includes.
 875         * aarch64-tdep.c: Fix common/ includes.
 876
 877 2019-01-25  Tom Tromey  <tom@tromey.com>
 878
 879         * common/create-version.sh: Use common/version.h.
 880
 881 2019-01-24  Pedro Alves  <palves@redhat.com>
 882
 883         * infrun.c (signal_stop, signal_print, signal_program)
 884         (signal_catch, signal_pass): Now arrays instead of pointers.
 885         (update_signals_program_target, do_target_resume)
 886         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 887         * linux-nat.c (linux_nat_target::pass_signals)
 888         (linux_nat_target::create_inferior, linux_nat_target::attach):
 889         Adjust.
 890         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 891         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 892         * procfs.c (procfs_target::pass_signals): Adjust.
 893         * record-full.c (record_full_target::resume): Adjust.
 894         * remote.c (remote_target::pass_signals)
 895         (remote_target::program_signals): Adjust.
 896         * target-debug.h (target_debug_print_signals): Now takes a
 897         gdb::array_view as parameter.  Adjust.
 898         * target.h (target_ops) <pass_signals, program_signals>: Replace
 899         pointer and length parameters with gdb::array_view.
 900         (target_pass_signals, target_program_signals): Likewise.
 901         * target-delegates.c: Regenerate.
 902
 903 2019-01-24  Pedro Alves  <palves@redhat.com>
 904
 905         * common/forward-scope-exit.h
 906         (forward_scope_exit::forward_scope_exit): Pass arguments to
 907         m_bind_function directly, instead of creating a std::bind and
 908         copying that.
 909
 910 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 911
 912         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 913         for static members.
 914         (pass_in_v_vfp_candidate): Likewise.
 915
 916 2019-01-23  Tom Tromey  <tom@tromey.com>
 917             Pedro Alves  <palves@redhat.com>
 918
 919         * regcache.c (class regcache_invalidator): Remove.
 920         (regcache::raw_write): Use make_scope_exit.
 921
 922 2019-01-23  Tom Tromey  <tom@tromey.com>
 923
 924         * ui-out.h (class ui_out_emit_type): Update comment.
 925
 926 2019-01-23  Tom Tromey  <tom@tromey.com>
 927
 928         * infrun.c (fetch_inferior_event): Update comment.
 929
 930 2019-01-23  Tom Tromey  <tom@tromey.com>
 931             Pedro Alves  <palves@redhat.com>
 932
 933         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 934         parameter.
 935         (fetch_inferior_event): Use SCOPE_EXIT.
 936
 937
 938 2019-01-23  Tom Tromey  <tom@tromey.com>
 939             Pedro Alves  <palves@redhat.com>
 940
 941         * infrun.c (disable_thread_events): Delete.
 942         (stop_all_threads): Use SCOPE_EXIT.
 943
 944 2019-01-23  Tom Tromey  <tom@tromey.com>
 945             Pedro Alves  <palves@redhat.com>
 946
 947         * symfile.c: Include forward-scope-exit.h.
 948         (clear_symtab_users_cleanup): Replace forward declaration with
 949         a FORWARD_SCOPE_EXIT.
 950         (syms_from_objfile_1): Use the forward_scope_exit and
 951         gdb::optional instead of cleanup_function.
 952         (reread_symbols): Use the forward_scope_exit instead of
 953         cleanup_function.
 954         (clear_symtab_users_cleanup): Remove function.
 955
 956 2019-01-23  Tom Tromey  <tom@tromey.com>
 957             Pedro Alves  <palves@redhat.com>
 958
 959         * linux-nat.c: Include scope-exit.h.
 960         (cleanup_target_stop): Remove.
 961         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 962         SCOPE_EXIT.
 963
 964 2019-01-23  Tom Tromey  <tom@tromey.com>
 965             Pedro Alves  <palves@redhat.com>
 966
 967         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 968         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 969
 970 2019-01-23  Tom Tromey  <tom@tromey.com>
 971             Andrew Burgess  <andrew.burgess@embecosm.com>
 972             Pedro Alves  <palves@redhat.com>
 973
 974         * infrun.c (fetch_inferior_event): Use scope_exit.
 975         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 976         * top.c (execute_command): Use scope_exit.
 977         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 978         * utils.c (do_bpstat_clear_actions_cleanup)
 979         (make_bpstat_clear_actions_cleanup): Remove.
 980
 981 2019-01-23  Tom Tromey  <tom@tromey.com>
 982             Pedro Alves  <palves@redhat.com>
 983
 984         * infrun.c: Include "common/scope-exit.h"
 985         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 986         (wait_for_inferior): Use SCOPE_EXIT.
 987         (fetch_inferior_event): Use scope_exit.
 988
 989 2019-01-23  Tom Tromey  <tom@tromey.com>
 990             Pedro Alves  <palves@redhat.com>
 991
 992         * breakpoint.c (create_breakpoint): Remove cleanup.
 993
 994 2019-01-23  Tom Tromey  <tom@tromey.com>
 995             Andrew Burgess  <andrew.burgess@embecosm.com>
 996             Pedro Alves  <palves@redhat.com>
 997
 998 2019-01-23  Pedro Alves  <palves@redhat.com>
 999
1000         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1001
1002 2019-01-23  Pedro Alves  <palves@redhat.com>
1003             Andrew Burgess  <andrew.burgess@embecosm.com>
1004
1005         * gdbthread.h: Include "common/forward-scope-exit.h".
1006         (scoped_finish_thread_state): Redefine custom class in terms of
1007         forward_scope_exit.
1008
1009 2019-01-23  Pedro Alves  <palves@redhat.com>
1010             Andrew Burgess  <andrew.burgess@embecosm.com>
1011
1012         * common/forward-scope-exit.h: New file.
1013
1014 2019-01-23  Pedro Alves  <palves@redhat.com>
1015             Andrew Burgess  <andrew.burgess@embecosm.com>
1016             Tom Tromey  <tom@tromey.com>
1017
1018         * common/scope-exit.h: New file.
1019
1020 2019-01-23  Pedro Alves  <palves@redhat.com>
1021
1022         * common/preprocessor.h (ESC): Rename to ...
1023         (ESC_PARENS): ... this.
1024         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1025         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1026
1027 2019-01-23  Tom Tromey  <tom@tromey.com>
1028
1029         * language.h (class scoped_switch_to_sym_language_if_auto):
1030         Initialize m_lang in both cases.
1031
1032 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1033
1034         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1035         with XCNEW.
1036
1037 2019-01-22  Tom Tromey  <tom@tromey.com>
1038
1039         * corelow.c: Do not include sys/file.h.
1040
1041 2019-01-22  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui-wingeneral.h: Include gdb_curses.h.
1044
1045 2019-01-22  Tom Tromey  <tom@tromey.com>
1046
1047         * source-cache.h (class source_cache) <get_source_lines,
1048         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1049
1050 2019-01-22  Tom Tromey  <tom@tromey.com>
1051
1052         * remote-fileio.h (struct remote_target): Declare.
1053
1054 2019-01-22  Tom Tromey  <tom@tromey.com>
1055
1056         * python/py-arch.c: Do not include py-ref.h.
1057         * python/py-bpevent.c: Do not include py-ref.h.
1058         * python/py-cmd.c: Do not include py-ref.h.
1059         * python/py-continueevent.c: Do not include py-ref.h.
1060         * python/py-event.h: Do not include py-ref.h.
1061         * python/py-evtregistry.c: Do not include py-ref.h.
1062         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1063         * python/py-frame.c: Do not include py-ref.h.
1064         * python/py-framefilter.c: Do not include py-ref.h.
1065         * python/py-function.c: Do not include py-ref.h.
1066         * python/py-infevents.c: Do not include py-ref.h.
1067         * python/py-linetable.c: Do not include py-ref.h.
1068         * python/py-objfile.c: Do not include py-ref.h.
1069         * python/py-param.c: Do not include py-ref.h.
1070         * python/py-prettyprint.c: Do not include py-ref.h.
1071         * python/py-progspace.c: Do not include py-ref.h.
1072         * python/py-symbol.c: Do not include py-ref.h.
1073         * python/py-symtab.c: Do not include py-ref.h.
1074         * python/py-type.c: Do not include py-ref.h.
1075         * python/py-unwind.c: Do not include py-ref.h.
1076         * python/py-utils.c: Do not include py-ref.h.
1077         * python/py-value.c: Do not include py-ref.h.
1078         * python/py-varobj.c: Do not include py-ref.h.
1079         * python/py-xmethods.c: Do not include py-ref.h.
1080         * python/python.c: Do not include py-ref.h.
1081         * varobj.c: Do not include py-ref.h.
1082
1083 2019-01-22  Tom Tromey  <tom@tromey.com>
1084
1085         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1086         keyword for bcache.
1087
1088 2019-01-22  Tom Tromey  <tom@tromey.com>
1089
1090         * compile/compile-cplus-types.c: Remove a comment by #include.
1091
1092 2019-01-22  Tom Tromey  <tom@tromey.com>
1093
1094         * compile/gcc-c-plugin.h: Include compile-internal.h.
1095
1096 2019-01-22  Tom Tromey  <tom@tromey.com>
1097
1098         * stabsread.c (EXTERN): Do not define.
1099         (symnum, next_symbol_text_func, processing_gcc_compilation)
1100         (within_function, global_sym_chain, global_stabs)
1101         (previous_stab_code, this_object_header_files)
1102         (n_this_object_header_files)
1103         (n_allocated_this_object_header_files): Define.
1104         * stabsread.h (EXTERN): Never define.  Use "extern".
1105
1106 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1107
1108         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1109         history_value.
1110
1111 2019-01-21  Tom Tromey  <tom@tromey.com>
1112
1113         * ui-out.c: Fix includes.
1114         * tui/tui-source.c: Fix includes.
1115         * target.c: Fix includes.
1116         * remote.c: Fix includes.
1117         * regcache.c: Fix includes.
1118         * python/py-block.c: Fix includes.
1119         * printcmd.c: Fix includes.
1120         * or1k-tdep.c: Fix includes.
1121         * mi/mi-main.c: Fix includes.
1122         * m32r-tdep.c: Fix includes.
1123         * csky-tdep.c: Fix includes.
1124         * compile/compile-cplus-types.c: Fix includes.
1125         * cli/cli-interp.c: Fix includes.
1126
1127 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1128
1129         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1130         for padding.
1131
1132 2019-01-16  Tom Tromey  <tom@tromey.com>
1133
1134         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1135         earlier.
1136         (struct objfile) <msymbols_range>: Move from top level.
1137         <msymbols>: New method.
1138         (class objfile_msymbols): Remove.
1139         * symtab.c (default_collect_symbol_completion_matches_break_on):
1140         Update.
1141         * symmisc.c (dump_msymbols): Update.
1142         * stabsread.c (scan_file_globals): Update.
1143         * objc-lang.c (info_selectors_command, info_classes_command)
1144         (find_methods): Update.
1145         * minsyms.c (find_solib_trampoline_target): Update.
1146         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1147         * coffread.c (coff_symfile_read): Update.
1148         * ada-lang.c (ada_lookup_simple_minsym)
1149         (ada_collect_symbol_completion_matches): Update.
1150
1151 2019-01-16  Tom Tromey  <tom@tromey.com>
1152
1153         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1154         type.  Remove no-argument constructor.
1155         <iterator::operator++>: Simplify.
1156         <begin>: Update.
1157         <end>: Use minimal_symbol_count.
1158
1159 2019-01-16  Tom Tromey  <tom@tromey.com>
1160
1161         * objfiles.h (struct objfile) <psymtabs>: New method.
1162         (class objfile_psymtabs): Remove.
1163         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1164         typedef.
1165         <range>: New method.
1166         (require_partial_symbols): Change return type.
1167         * psymtab.c (require_partial_symbols)
1168         (psym_expand_symtabs_matching): Update.
1169         * mdebugread.c (parse_partial_symbols): Update.
1170         * dbxread.c (dbx_end_psymtab): Update.
1171
1172 2019-01-15  Tom Tromey  <tom@tromey.com>
1173
1174         * symtab.c (lookup_objfile_from_block)
1175         (lookup_symbol_in_objfile_symtabs)
1176         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1177         (find_line_symtab, info_sources_command)
1178         (default_collect_symbol_completion_matches_break_on)
1179         (make_source_files_completion_list): Update.
1180         * symmisc.c (print_objfile_statistics, dump_objfile)
1181         (maintenance_print_symbols, maintenance_info_symtabs)
1182         (maintenance_check_symtabs, maintenance_info_line_tables):
1183         Update.
1184         * source.c (select_source_symtab)
1185         (forget_cached_source_info_for_objfile): Update.
1186         * objfiles.h (class objfile_compunits): Remove.
1187         (struct objfile) <compunits_range>: New typedef.
1188         (compunits): New method.
1189         * objfiles.c (objfile_relocate1): Update.
1190         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1191         * maint.c (count_symtabs_and_blocks): Update.
1192         * linespec.c (iterate_over_all_matching_symtabs): Update.
1193         * cp-support.c (add_symbol_overload_list_qualified): Update.
1194         * coffread.c (coff_symtab_read): Update.
1195         * ada-lang.c (add_nonlocal_symbols)
1196         (ada_collect_symbol_completion_matches)
1197         (ada_add_global_exceptions): Update.
1198
1199 2019-01-15  Tom Tromey  <tom@tromey.com>
1200
1201         * progspace.h (program_space) <objfiles_safe_range>: New
1202         typedef.
1203         <objfiles_safe>: New method.
1204         * objfiles.h (class all_objfiles_safe): Remove.
1205         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1206         * jit.c (jit_inferior_exit_hook): Update.
1207
1208 2019-01-17  Tom Tromey  <tom@tromey.com>
1209
1210         * progspace.h (program_space) <objfiles_range>: New typedef.
1211         <objfiles>: New method.
1212         <objfiles_head>: Rename from objfiles.
1213         (object_files): Update.
1214         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1215         * guile/scm-pretty-print.c
1216         (ppscm_find_pretty_printer_from_objfiles): Update.
1217         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1218         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1219         Update.
1220         * python/py-progspace.c (pspy_get_objfiles): Update.
1221         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1222         Update.
1223         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1224         (objfpy_lookup_objfile_by_build_id): Update.
1225         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1226         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1227         Update.
1228         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1229         (expand_symtab_containing_pc, lookup_objfile_from_block)
1230         (lookup_static_symbol, basic_lookup_transparent_type)
1231         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1232         (find_line_symtab, info_sources_command)
1233         (default_collect_symbol_completion_matches_break_on)
1234         (make_source_files_completion_list, find_main_name): Update.
1235         * symmisc.c (print_symbol_bcache_statistics)
1236         (print_objfile_statistics, maintenance_print_symbols)
1237         (maintenance_print_msymbols, maintenance_print_objfiles)
1238         (maintenance_info_symtabs, maintenance_check_symtabs)
1239         (maintenance_expand_symtabs, maintenance_info_line_tables):
1240         Update.
1241         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1242         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1243         (map_overlay_command, unmap_overlay_command)
1244         (simple_overlay_update, expand_symtabs_matching)
1245         (map_symbol_filenames): Update.
1246         * symfile-debug.c (set_debug_symfile): Update.
1247         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1248         Update.
1249         * source.c (select_source_symtab, forget_cached_source_info):
1250         Update.
1251         * solib.c (solib_read_symbols): Update.
1252         * solib-spu.c (append_ocl_sos): Update.
1253         * psymtab.c (maintenance_print_psymbols)
1254         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1255         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1256         * printcmd.c (info_symbol_command): Update.
1257         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1258         Update.
1259         * objfiles.h (class all_objfiles): Remove.
1260         * objfiles.c (have_partial_symbols, have_full_symbols)
1261         (have_minimal_symbols, qsort_cmp, update_section_map)
1262         (shared_objfile_contains_address_p)
1263         (default_iterate_over_objfiles_in_search_order): Update.
1264         * objc-lang.c (info_selectors_command, info_classes_command)
1265         (find_methods): Update.
1266         * minsyms.c (find_solib_trampoline_target): Update.
1267         * maint.c (maintenance_info_sections)
1268         (maintenance_translate_address, count_symtabs_and_blocks):
1269         Update.
1270         * main.c (captured_main_1): Update.
1271         * linux-thread-db.c (try_thread_db_load_from_pdir)
1272         (has_libpthread): Update.
1273         * linespec.c (iterate_over_all_matching_symtabs)
1274         (search_minsyms_for_name): Update.
1275         * jit.c (jit_find_objf_with_entry_addr): Update.
1276         * hppa-tdep.c (find_unwind_entry)
1277         (hppa_lookup_stub_minimal_symbol): Update.
1278         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1279         Update.
1280         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1281         (elf_gnu_ifunc_resolve_by_got): Update.
1282         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1283         * dwarf-index-write.c (save_gdb_index_command): Update.
1284         * cp-support.c (add_symbol_overload_list_qualified): Update.
1285         * breakpoint.c (create_overlay_event_breakpoint)
1286         (create_longjmp_master_breakpoint)
1287         (create_std_terminate_master_breakpoint)
1288         (create_exception_master_breakpoint): Update.
1289         * blockframe.c (find_pc_partial_function): Update.
1290         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1291         (ada_collect_symbol_completion_matches)
1292         (ada_add_global_exceptions): Update.
1293
1294 2019-01-17  Tom Tromey  <tom@tromey.com>
1295
1296         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1297         declare VEC.
1298         (solib_target_parse_libraries): Change return type.
1299         (library_list_start_segment, library_list_start_section)
1300         (library_list_end_library, library_list_start_library); Update.
1301         (solib_target_free_library_list): Remove.
1302         (solib_target_parse_libraries): Remove cleanup.  Change return
1303         type.
1304         (solib_target_current_sos): Update.
1305
1306 2019-01-17  Tom Tromey  <tromey@bapiya>
1307
1308         * valprint.c: Replace "the the" with "the".
1309         * symtab.c: Replace "the the" with "the".
1310         * solib.c: Replace "the the" with "the".
1311         * solib-dsbt.c: Replace "the the" with "the".
1312         * linespec.c: Replace "the the" with "the".
1313         * dwarf2loc.h: Replace "the the" with "the".
1314         * amd64-windows-tdep.c: Replace "the the" with "the".
1315         * aarch64-tdep.c: Replace "the the" with "the".
1316
1317 2019-01-16  Keith Seitz  <keiths@redhat.com>
1318
1319         PR gdb/23773
1320         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1321         <builder>: Rename to ..
1322         <m_builder>: ... this and make private.
1323         (dwarf2_cu::get_builder): New method.  Change all users of
1324         `builder' to use this method.
1325         (dwarf2_start_symtab): Move to ...
1326         (dwarf2_cu::start_symtab): ... here.  Update all callers
1327         (setup_type_unit_groups): Move to ...
1328         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1329         callers.
1330         (dwarf2_cu::reset_builder): New method.
1331         (process_full_compunit, process_full_type_unit): Use
1332         dwarf2_cu::reset_builder.
1333         (follow_die_offset): Record the ancestor CU if it is different
1334         from the followed DIE's CU.
1335         (follow_die_sig_1): Likewise.
1336
1337 2019-01-15  Tom Tromey  <tom@tromey.com>
1338
1339         * remote.c (class remote_state) <buf>: Now a char_vector.
1340         <buf_size>: Remove.
1341         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1342         parameter.
1343         (remote_target::getpkt_or_notif_sane_1)
1344         (remote_target::getpkt_sane)
1345         (remote_target::getpkt_or_notif_sane): Likewise.
1346         (class remote_target) <putpkt>: New overload.
1347         (remote_target::read_frame): Change type of "buf_p".  Remove
1348         sizeof_p parameter.
1349         (packet_ok): New overload.
1350         (packet_check_result): New overload.
1351         Update all uses.
1352
1353 2019-01-14  Tom Tromey  <tom@tromey.com>
1354
1355         * remote-notif.c (handle_notification, remote_notif_ack)
1356         (remote_notif_parse): Make "buf" const.
1357         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1358         const.
1359         (remote_notif_parse, remote_notif_ack, handle_notification):
1360         Likewise.
1361         * remote.c (remote_notif_stop_parse): Make "buf" const.
1362         (remote_target::remote_parse_stop_reply): Make "buf" const.
1363         (remote_notif_stop_ack): Make "buf" const.
1364
1365 2019-01-14  Tom Tromey  <tom@tromey.com>
1366
1367         * remote.c (remote_console_output): Make parameter const.
1368
1369 2019-01-14  Tom Tromey  <tom@tromey.com>
1370
1371         * target-debug.h (target_debug_print_signals): Constify.
1372         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1373         * procfs.c (procfs_target::pass_signals): Update.
1374         * linux-nat.c (linux_nat_target::pass_signals): Update.
1375         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1376         * target-delegates.c: Rebuild.
1377         * remote.c (remote_target::program_signals): Update.
1378         (remote_target::pass_signals): Update.
1379         * target.c (target_pass_signals): Constify argument.
1380         (target_program_signals): Likewise.
1381         * target.h (struct target_ops) <pass_signals, program_signals>:
1382         Constify argument.
1383         (target_pass_signals, target_program_signals): Constify argument.
1384
1385 2019-01-14  Tom Tromey  <tom@tromey.com>
1386
1387         PR tui/28819:
1388         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1389
1390 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1391
1392         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1393         field.
1394         * rs6000-tdep.c: Include reggroups.h.
1395         (IS_V_ALIAS_PSEUDOREG): Define.
1396         (rs6000_register_name): Return names for the "vX" aliases.
1397         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1398         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1399         aliases.  Call default_register_reggroup_p for all other
1400         pseudo-registers.
1401         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1402         New functions.
1403         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1404         Handle "vX" aliases.
1405         (v_alias_pseudo_register_collect): New function.
1406         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1407         (rs6000_gdbarch_init): Initialize "vX" aliases as
1408         pseudo-registers.  Restore registration of
1409         rs6000_pseudo_register_reggroup_p with
1410         set_tdesc_pseudo_register_reggroup_p.
1411
1412 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1413
1414         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1415         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1416         set_gdbarch_num_pseudo_regs.
1417
1418 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1419
1420         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1421         Remove arg prefixname, add do_set and do_show.
1422         Add member functions set_list and show_list.
1423         * cli/cli-style.c (class cli_style_option): Update accordingly.
1424         (style_set_list): Move to file scope.
1425         (style_show_list): Likewise.
1426         (set_style): Call help_list.
1427         (show_style): Call cmd_show_list.
1428         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1429         Update to use the new macro.
1430
1431 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1432
1433         * ada-lang.c (_initialize_ada_language): Expand the help text
1434         for the "catch exception" command.
1435
1436 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1437
1438         * symtab.c (matching_obj_sections): Initialize obj,
1439         declare it closer to its usage.
1440
1441 2019-01-10  Tom Tromey  <tom@tromey.com>
1442
1443         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1444         (basic_inf_threads_range): Remove.
1445         (inf_threads_range, inf_non_exited_threads_range)
1446         (safe_inf_threads_range): Use next_adapter.
1447
1448 2019-01-10  Keith Seitz  <keiths@redhat.com>
1449
1450         PR gdb/23712
1451         PR symtab/23010
1452         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1453         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1454
1455 2019-01-10  Keith Seitz  <keiths@redhat.com>
1456
1457         PR gdb/23712
1458         PR symtab/23010
1459         * dictionary.c (pending_to_vector): Remove.
1460         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1461         Remove _1 suffix, replacing functions of the same name.  Update
1462         all callers.
1463         (dict_create_hashed, dict_create_hashed_expandable)
1464         (dict_create_linear, dict_create_linear_expandable, dict_free)
1465         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1466         Make functions static.
1467
1468 2019-01-10  Keith Seitz  <keiths@redhat.com>
1469
1470         PR gdb/23712
1471         PR symtab/23010
1472         * dictionary.h (struct dictionary): Replace declaration with
1473         multidictionary.
1474         (dict_create_hashed, dict_create_hashed_expandable)
1475         (dict_create_linear, dict_create_linear_expandable)
1476         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1477         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1478         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1479         taking multidictionary argument.
1480         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1481         * block.h (struct block) <dict>: Change to multidictionary
1482         and rename `multidict'.
1483         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1484         symmisc.c: Update all dictionary references to multidictionary.
1485
1486 2019-01-10  Keith Seitz  <keiths@redhat.com>
1487
1488         PR gdb/23712
1489         PR symtab/23010
1490         * dictionary.c: Include unordered_map.
1491         (pending_to_vector): New function.
1492         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1493         Rewrite the non-"_1" functions to take vector instead
1494         of linked list.
1495         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1496         "new" _1 versions of the same name.
1497         (multidictionary): Define.
1498         (std::hash<enum language): New definition.
1499         (collate_pending_symbols_by_language, mdict_create_hashed)
1500         (mdict_create_hashed_expandable, mdict_create_linear)
1501         (mdict_create_linear_expandable, mdict_free)
1502         (find_language_dictionary, create_new_language_dictionary)
1503         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1504         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1505         (mdict_size, mdict_empty): New functions.
1506         * dictionary.h (mdict_iterator): Define.
1507
1508 2019-01-10  Pedro Alves  <palves@redhat.com>
1509
1510         * breakpoint.c (read_uploaded_action)
1511         (create_tracepoint_from_upload): Adjust to use
1512         gdb::unique_xmalloc_ptr.
1513         * ctf.c (ctf_write_uploaded_tp):
1514         (SET_ARRAY_FIELD): Use emplace_back.
1515         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1516         * tracefile-tfile.c (tfile_write_uploaded_tp):
1517         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1518         gdb::unique_xmalloc_ptr.
1519         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1520         at_string, cond_string, cmd_strings>: Replace char pointers
1521         with gdb::unique_xmalloc_ptr.
1522
1523 2019-01-10  Pedro Alves  <palves@redhat.com>
1524
1525         * solib-target.c (library_list_start_library): Don't xstrdup name.
1526
1527 2019-01-10  Pedro Alves  <palves@redhat.com>
1528
1529         * mdebugread.c (parse_partial_symbols): Use
1530         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1531
1532 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1533
1534         * linux-fork.c (scoped_switch_fork_info)
1535         <~scoped_switch_fork_info>: Fix incorrect variable name.
1536
1537 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1538
1539         * linux-fork.c (scoped_switch_fork_info)
1540         <scoped_switch_fork_info>: Make explicit.
1541         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1542
1543 2019-01-10  Tom Tromey  <tom@tromey.com>
1544
1545         * objfiles.h (objfile::reset_psymtabs): Update.
1546         * objfiles.c (objfile::objfile): Update.
1547         * psymtab.h (psymtab_storage::obstack): Update.
1548         (psymtab_storage::m_obstack): Use gdb::optional.
1549         (class psymtab_storage): Update comment.  Remove objfile
1550         parameter.
1551         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1552
1553 2019-01-10  Tom Tromey  <tom@tromey.com>
1554
1555         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1556         <free_psymtabs>: Now private.
1557         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1558         (allocate_psymtab): Use new method.
1559
1560 2019-01-10  Tom Tromey  <tom@tromey.com>
1561
1562         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1563         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1564         * mdebugread.c (parse_partial_symbols): Use
1565         allocate_dependencies.
1566         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1567         allocate_dependencies.
1568         (process_psymtab_comp_unit_reader)
1569         (build_type_psymtab_dependencies): Likewise.
1570         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1571
1572 2019-01-10  Tom Tromey  <tom@tromey.com>
1573
1574         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1575         PSYMBOL_SET_LANGUAGE.
1576         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1577
1578 2019-01-10  Tom Tromey  <tom@tromey.com>
1579
1580         * psymtab.h (psymtab_storage::obstack): New method.
1581         <m_obstack>: Rename from obstack; now private.
1582         * psymtab.c (psymtab_storage): Update.
1583         * dwarf2read.c (create_addrmap_from_index)
1584         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1585         Update.
1586
1587 2019-01-10  Tom Tromey  <tom@tromey.com>
1588
1589         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1590         * objfiles.h (objfile::reset_psymtabs): New method.
1591
1592 2019-01-10  Tom Tromey  <tom@tromey.com>
1593
1594         * symmisc.c (print_symbol_bcache_statistics): Update.
1595         (print_objfile_statistics): Update.
1596         * symfile.c (reread_symbols): Update.
1597         * psymtab.h (class psymtab_storage): New.
1598         * psymtab.c (psymtab_storage): New constructor.
1599         (~psymtab_storage): New destructor.
1600         (require_partial_symbols): Update.
1601         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1602         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1603         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1604         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1605         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1606         (start_psymtab_common, end_psymtab_common)
1607         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1608         (allocate_psymtab): Update.
1609         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1610         Update.
1611         (dump_psymtab_addrmap, maintenance_print_psymbols)
1612         (maintenance_check_psymtabs): Update.
1613         (class objfile_psymtabs): Move to objfiles.h.
1614         * psympriv.h (discard_psymtab): Now inline.
1615         (psymtab_discarder::psymtab_discarder): Update.
1616         (psymtab_discarder::~psymtab_discarder): Update.
1617         (ALL_OBJFILE_PSYMTABS): Rewrite.
1618         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1619         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1620         Remove fields.
1621         <partial_symtabs>: New field.
1622         (class objfile_psymtabs): Move from psymtab.h.  Update.
1623         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1624         psymbol_cache.
1625         (objfile::~objfile): Don't destroy psymbol_cache.
1626         * mdebugread.c (parse_partial_symbols): Update.
1627         * dwarf2read.c (create_addrmap_from_index)
1628         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1629         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1630         (add_partial_subprogram, dwarf2_ranges_read): Update.
1631         * dwarf-index-write.c (write_address_map)
1632         (write_one_signatured_type, recursively_write_psymbols)
1633         (class debug_names, class debug_names, write_psymtabs_to_index):
1634         Update.
1635
1636 2019-01-10  Tom Tromey  <tom@tromey.com>
1637
1638         * symtab.h (SYMBOL_SET_NAMES): Update.
1639         (symbol_set_names): Update.
1640         (MSYMBOL_SET_NAMES): Update.
1641         * symtab.c (symbol_set_names): Change argument to be an
1642         objfile_per_bfd_storage.
1643         * psymtab.c (add_psymbol_to_bcache): Update.
1644         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1645
1646 2019-01-10  Tom Tromey  <tom@tromey.com>
1647
1648         * symtab.c (create_demangled_names_hash): Change argument to be an
1649         objfile_per_bfd_storage.
1650         (symbol_set_names): Update.
1651
1652 2019-01-10  Tom Tromey  <tom@tromey.com>
1653
1654         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1655         init_psymbol_list.
1656         * psymtab.c (init_psymbol_list): Do nothing if already called.
1657         * psympriv.h (init_psymbol_list): Add comment.
1658         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1659         init_psymbol_list.
1660         * dbxread.c (dbx_symfile_read): Unconditionally call
1661         init_psymbol_list.
1662
1663 2019-01-10  Tom Tromey  <tom@tromey.com>
1664
1665         * xcoffread.c (scan_xcoff_symtab): Update.
1666         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1667         "where".
1668         * mdebugread.c (parse_partial_symbols)
1669         (handle_psymbol_enumerators): Update.
1670         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1671         * dbxread.c (read_dbx_symtab): Update.
1672         * psympriv.h (psymbol_placement): New enum.
1673         (add_psymbol_to_list): Update.
1674
1675 2019-01-10  Tom Tromey  <tom@tromey.com>
1676
1677         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1678         static_psymbols parameters.
1679         (scan_xcoff_symtab): Update.
1680         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1681         static_psymbols parameters.
1682         * psympriv.h (start_psymtab_common): Update.
1683         * mdebugread.c (parse_partial_symbols): Update.
1684         * dwarf2read.c (create_partial_symtab): Update.
1685         * dbxread.c (read_dbx_symtab): Update.
1686         (start_psymtab): Remove global_psymbols and static_psymbols
1687         parameters.
1688
1689 2019-01-10  Tom Tromey  <tom@tromey.com>
1690
1691         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1692         * psymtab.c (allocate_psymtab): Add comment.
1693         * psympriv.h (allocate_psymtab): Add comment.
1694         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1695         initializations.
1696         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1697
1698 2019-01-10  Tom Tromey  <tom@tromey.com>
1699
1700         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1701         Don't declare.
1702         * mipsread.c: Include mdebugread.h.
1703         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1704         Declare.
1705         * elfread.c: Include mdebugread.h.
1706
1707 2019-01-09  Tom Tromey  <tom@tromey.com>
1708
1709         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1710         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1711         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1712         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1713         (psym_lookup_symbol, psym_find_last_source_symtab)
1714         (psym_forget_cached_source_info, psym_print_stats)
1715         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1716         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1717         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1718         (psym_find_compunit_symtab_by_address)
1719         (maintenance_print_psymbols, maintenance_info_psymtabs)
1720         (maintenance_check_psymtabs): Use ranged for.
1721         * psymtab.h (class objfile_psymtabs): New.
1722         (require_partial_symbols): Return objfile_psymtabs.
1723         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1724
1725 2019-01-09  Tom Tromey  <tom@tromey.com>
1726
1727         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1728         (find_pc_mapped_section, list_overlays_command)
1729         (map_overlay_command, unmap_overlay_command)
1730         (simple_overlay_update): Use all_objfiles.
1731         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1732         * printcmd.c (info_symbol_command): Use all_objfiles.
1733         * objfiles.h (ALL_OBJSECTIONS): Remove.
1734         * maint.c (maintenance_translate_address): Use all_objfiles.
1735         * gcore.c (gcore_create_callback): Use all_objfiles.
1736         (objfile_find_memory_regions): Likewise.
1737
1738 2019-01-09  Tom Tromey  <tom@tromey.com>
1739
1740         * symtab.c (find_line_symtab, info_sources_command)
1741         (make_source_files_completion_list): Use objfile_compunits.
1742         * source.c (select_source_symtab): Use objfile_compunits.
1743         * objfiles.h (struct objfile): Update comment.
1744         (ALL_OBJFILES): Remove.
1745         (ALL_FILETABS): Remove.
1746         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1747         objfile_compunits.
1748
1749 2019-01-09  Tom Tromey  <tom@tromey.com>
1750
1751         * symmisc.c (print_objfile_statistics, dump_objfile)
1752         (maintenance_print_symbols): Use compunit_filetabs.
1753         * source.c (forget_cached_source_info_for_objfile): Use
1754         compunit_filetabs.
1755         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1756         (ALL_FILETABS): Use compunit_filetabs.
1757         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1758         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1759
1760 2019-01-09  Tom Tromey  <tom@tromey.com>
1761
1762         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1763         (compunit_filetabs): New.
1764         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1765         compunit_filetabs.
1766         (info_sources_command, make_source_files_completion_list): Remove
1767         declaration.
1768         * symmisc.c (print_objfile_statistics, dump_objfile)
1769         (maintenance_print_symbols): Remove declaration.
1770         (maintenance_info_symtabs): Use compunit_filetabs.
1771         (maintenance_info_line_tables): Likewise.
1772         * source.c (select_source_symtab): Change local variable name.
1773         (forget_cached_source_info_for_objfile): Remove declaration.
1774         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1775         * objfiles.c (objfile_relocate1): Remove declaration.
1776         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1777         declaration.
1778         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1779         * coffread.c (coff_symtab_read): Remove declaration.
1780         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1781         compunit_filetabs.
1782
1783 2019-01-09  Tom Tromey  <tom@tromey.com>
1784
1785         * symtab.c (lookup_objfile_from_block)
1786         (find_pc_sect_compunit_symtab, search_symbols)
1787         (default_collect_symbol_completion_matches_break_on): Use
1788         objfile_compunits.
1789         * objfiles.h (ALL_COMPUNITS): Remove.
1790         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1791         * cp-support.c (add_symbol_overload_list_qualified): Use
1792         objfile_compunits.
1793         * ada-lang.c (ada_collect_symbol_completion_matches)
1794         (ada_add_global_exceptions): Use objfile_compunits.
1795
1796 2019-01-09  Tom Tromey  <tom@tromey.com>
1797
1798         * source.c (select_source_symtab)
1799         (forget_cached_source_info_for_objfile): Remove declaration.
1800         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1801         declaration.
1802         * maint.c (count_symtabs_and_blocks): Remove declaration.
1803         * cp-support.c (add_symbol_overload_list_qualified): Remove
1804         declaration.
1805         * coffread.c (coff_symtab_read): Remove declaration.
1806         * symtab.c (lookup_symbol_in_objfile_symtabs)
1807         (basic_lookup_transparent_type_1): Use objfile_compunits.
1808         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1809         (info_sources_command, search_symbols)
1810         (default_collect_symbol_completion_matches_break_on)
1811         (make_source_files_completion_list): Remove declaration.
1812         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1813         (ada_collect_symbol_completion_matches)
1814         (ada_add_global_exceptions): Remove declaration.
1815         * linespec.c (iterate_over_all_matching_symtabs): Use
1816         objfile_compunits.
1817         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1818         (class objfile_compunits): New.
1819         (ALL_COMPUNITS): Use objfile_compunits.
1820         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1821         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1822         objfile_compunits.
1823         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1824
1825 2019-01-09  Tom Tromey  <tom@tromey.com>
1826
1827         * symtab.c (search_symbols)
1828         (default_collect_symbol_completion_matches_break_on): Use
1829         objfile_msymbols.
1830         * ada-lang.c (ada_lookup_simple_minsym)
1831         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1832         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1833         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1834         objfile_msymbols.
1835         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1836         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1837         * objc-lang.c (find_methods): Use objfile_msymbols.
1838         (info_selectors_command, info_classes_command): Likewise.
1839         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1840         * objfiles.h (class objfile_msymbols): New.
1841         (ALL_OBJFILE_MSYMBOLS): Remove.
1842         (ALL_MSYMBOLS): Remove.
1843
1844 2019-01-09  Tom Tromey  <tom@tromey.com>
1845
1846         * common/next-iterator.h (next_adapter): Add Iterator template
1847         parameter.
1848         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1849         (class all_objfiles_safe): New.
1850         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1851         * objfiles.c (put_objfile_before): Update comment.
1852         (add_separate_debug_objfile): Likewise.
1853         (free_all_objfiles): Use all_objfiles_safe.
1854         (objfile_purge_solibs): Likewise.
1855
1856 2019-01-09  Tom Tromey  <tom@tromey.com>
1857
1858         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1859         (expand_symtab_containing_pc, lookup_static_symbol)
1860         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1861         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1862         all_objfiles.
1863         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1864         * breakpoint.c (create_overlay_event_breakpoint)
1865         (create_longjmp_master_breakpoint)
1866         (create_std_terminate_master_breakpoint)
1867         (create_exception_master_breakpoint): Use all_objfiles.
1868         * linux-thread-db.c (try_thread_db_load_from_pdir)
1869         (has_libpthread): Use all_objfiles.
1870         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1871         * linespec.c (iterate_over_all_matching_symtabs)
1872         (search_minsyms_for_name): Use all_objfiles.
1873         * maint.c (maintenance_info_sections): Use all_objfiles.
1874         * main.c (captured_main_1): Use all_objfiles.
1875         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1876         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1877         * guile/scm-pretty-print.c
1878         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1879         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1880         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1881         (maintenance_print_msymbols): Use all_objfiles.
1882         * source.c (select_source_symtab): Use all_objfiles.
1883         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1884         * symfile.c (remove_symbol_file_command)
1885         (expand_symtabs_matching, map_symbol_filenames): Use
1886         all_objfiles.
1887         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1888         all_objfiles.
1889         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1890         * objc-lang.c (find_methods): Use all_objfiles.
1891         * objfiles.c (have_partial_symbols, have_full_symbols)
1892         (have_minimal_symbols, qsort_cmp)
1893         (default_iterate_over_objfiles_in_search_order): Use
1894         all_objfiles.
1895         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1896         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1897         (maintenance_check_psymtabs): Use all_objfiles.
1898         (ALL_PSYMTABS): Remove.
1899         * compile/compile-object-run.c (do_module_cleanup): Use
1900         all_objfiles.
1901         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1902         * cp-support.c (add_symbol_overload_list_qualified): Use
1903         all_objfiles.
1904         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1905         Use all_objfiles.
1906         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1907         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1908         all_objfiles.
1909         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1910         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1911         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1912         Uses all_objfiles.
1913         * solib.c (solib_read_symbols): Use all_objfiles
1914
1915 2019-01-09  Tom Tromey  <tom@tromey.com>
1916
1917         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1918         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1919         all_objfiles.
1920         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1921         * symmisc.c (print_symbol_bcache_statistics)
1922         (print_objfile_statistics, maintenance_print_objfiles)
1923         (maintenance_info_symtabs, maintenance_check_symtabs)
1924         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1925         all_objfiles.
1926         * source.c (forget_cached_source_info): Use all_objfiles.
1927         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1928         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1929         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1930         * objfiles.c (update_section_map): Use all_objfiles.
1931         (shared_objfile_contains_address_p): Likewise.
1932         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1933         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1934
1935 2019-01-09  Tom Tromey  <tom@tromey.com>
1936
1937         * common/next-iterator.h: New file.
1938         * objfiles.h (class all_objfiles): New.
1939         (struct objfile_iterator): New.
1940
1941 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1942
1943         * NEWS: Move the description of the changed "frame", "select-frame",
1944          and "info frame" commands to the Changed commands section.
1945
1946 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1947
1948         * gdbtypes.c (check_stub_method_group): Remove handling of old
1949         mangling schemes.
1950         * linespec.c (find_methods): Likewise.
1951         * stabsread.c (read_member_functions): Likewise.
1952         * valops.c (search_struct_method): Likewise.
1953         (value_struct_elt_for_reference): Likewise.
1954         * NEWS: Mention this change.
1955
1956 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1957
1958         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1959         print_source_lines.
1960         * source.c (print_source_lines_base): Update line number check.
1961         (print_source_lines): New function.
1962         (source_lines_range::source_lines_range): New function.
1963         * source.h (class source_lines_range): New class.
1964         (print_source_lines): New declaration.
1965
1966 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1967
1968         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1969
1970 2019-01-08  Tom Tromey  <tom@tromey.com>
1971             Simon Marchi  <simon.marchi@ericsson.com>
1972
1973         PR gdb/24060
1974         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1975         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1976         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1977         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1978         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1979         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1980
1981 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1982
1983         * source.c (select_source_symtab): Move header comment to
1984         declaration in source.h.
1985         (forget_cached_source_info_for_objfile): Likewise.
1986         (forget_cached_source_info): Likewise.
1987         (identify_source_line): Likewise.
1988         * source.h (identify_source_line): Move declaration from symtab.h
1989         and add comment from source.c
1990         (print_source_lines): Likewise.
1991         (forget_cached_source_info_for_objfile): Likewise.
1992         (forget_cached_source_info): Likewise.
1993         (select_source_symtab): Likewise.
1994         (enum print_source_lines_flag): Move definition from symtab.h.
1995         * symtab.h (identify_source_line): Move declaration to source.h.
1996         (print_source_lines): Likewise.
1997         (forget_cached_source_info_for_objfile): Likewise.
1998         (forget_cached_source_info): Likewise.
1999         (select_source_symtab): Likewise.
2000         (enum print_source_lines_flag): Move definition to source.h.
2001         * tui/tui-hooks.c: Add 'source.h' include.
2002
2003 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2004
2005         * source.c (print_source_lines_base): Handle requests to print
2006         reverse line number sequences, and guard against empty lines
2007         string.
2008
2009 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2010
2011         * source.c (print_source_lines_base): Fix skip of '\r' if next
2012         character is '\n'.
2013
2014 2019-01-06  Tom Tromey  <tom@tromey.com>
2015
2016         * c-exp.y (struct c_parse_state) <macro_original_text,
2017         expansion_obstack>: New member.
2018         (macro_original_text, expansion_obstack): Remove globals.
2019         (scan_macro_expansion, scanning_macro_expansion)
2020         (finished_macro_expansion): Update.
2021         (scan_macro_cleanup): Remove.
2022         (yylex, c_parse): Update.
2023
2024 2019-01-06  Tom Tromey  <tom@tromey.com>
2025
2026         * c-exp.y (struct c_parse_state) <strings>: New member.
2027         (operator_stoken): Update.
2028
2029 2019-01-06  Tom Tromey  <tom@tromey.com>
2030
2031         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2032         (union type_stack_elt) <typelist_val>: Now a pointer to
2033         std::vector.
2034         (type_stack_cleanup): Don't declare.
2035         (push_typelist): Update.
2036         * parse.c (pop_typelist): Return a std::vector.
2037         (push_typelist): Take a std::vector.
2038         (follow_types): Update.  Do not free args.
2039         (type_stack_cleanup): Remove.
2040         * c-exp.y (struct c_parse_state): New.
2041         (cpstate): New global.
2042         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2043         (nonempty_typelist): Update.
2044         (func_mod): Create a new vector.
2045         (c_parse): Create a c_parse_state.
2046         (check_parameter_typelist): Do not delete params.
2047         (function_method): Update.  Do not delete type_list.
2048
2049 2019-01-06  Tom Tromey  <tom@tromey.com>
2050
2051         PR gdb/28155:
2052         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2053         check_typedef.
2054         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2055         (print_return_value): Likewise.
2056
2057 2019-01-05  Tom Tromey  <tom@tromey.com>
2058
2059         * contrib/cleanup_check.py: Remove.
2060         * contrib/gcc-with-excheck: Remove.
2061         * contrib/exsummary.py: Remove.
2062         * contrib/excheck.py: Remove.
2063
2064 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2065
2066         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2067         NULL. Initialize tpprev to NULL instead of assigning it
2068         to NULL on the next statement.
2069         * windows-nat.c (windows_delete_thread): Remove check for
2070         main_thread_id before printing thread exit notifications.
2071         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2072         Remove thread ID check against main_thread_id.
2073         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2074         windows_delete_thread.
2075         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2076
2077 2019-01-04  Tom Tromey  <tom@tromey.com>
2078
2079         * compile/compile.c (_initialize_compile): Use upper case for
2080         metasyntactic variables.
2081         * symmisc.c (_initialize_symmisc): Use upper case for
2082         metasyntactic variables.
2083         * psymtab.c (_initialize_psymtab): Use upper case for
2084         metasyntactic variables.
2085         * demangle.c (demangle_command): Use upper case for metasyntactic
2086         variables.
2087         (_initialize_demangler): Likewise.
2088         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2089         variables.
2090
2091 2019-01-03  Tom Tromey  <tom@tromey.com>
2092
2093         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2094
2095 2019-01-03  Tom Tromey  <tom@tromey.com>
2096
2097         * python/py-symtab.c (salpy_str): Update.
2098         (struct salpy_sal_object) <symtab>: Now a PyObject.
2099         (salpy_dealloc): Update.
2100         (del_objfile_sal): Use gdbpy_ref.
2101
2102 2019-01-03  Tom Tromey  <tom@tromey.com>
2103
2104         * python/py-type.c (convert_field): Use new_reference.  Return
2105         gdbpy_ref.
2106         (make_fielditem): Return gdbpy_ref.
2107         (typy_fields): Update.
2108         (typy_getitem): Update.
2109         (field_name): Return gdbpy_ref.  Use new_reference.
2110         (typy_iterator_iternext): Update.
2111
2112 2019-01-03  Tom Tromey  <tom@tromey.com>
2113
2114         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2115
2116 2019-01-03  Tom Tromey  <tom@tromey.com>
2117
2118         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2119         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2120         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2121         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2122         (pspy_set_type_printers): Likewise.
2123         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2124         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2125         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2126         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2127         (objfpy_set_type_printers): Likewise.
2128
2129 2019-01-03  Tom Tromey  <tom@tromey.com>
2130
2131         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2132         (gdbpy_print_stack): Use gdbpy_err_fetch.
2133         * python/python-internal.h (class gdbpy_err_fetch): New class.
2134         (class gdbpy_enter) <m_error_type, m_error_value,
2135         m_error_traceback>: Remove.
2136         <m_error>: New member.
2137         (gdbpy_exception_to_string): Don't declare.
2138         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2139         * python/py-value.c (convert_value_from_python): Use
2140         gdbpy_err_fetch.
2141         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2142         gdbpy_exception_to_string.
2143         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2144         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2145         gdbpy_err_fetch.
2146
2147 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2148
2149         * linux-nat.c (delete_lwp_cleanup): Delete.
2150         (struct lwp_deleter): New struct.
2151         (lwp_info_up): New typedef.
2152         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2153         lwp_info_up.
2154
2155 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2156
2157         * linux-fork.c (class scoped_switch_fork_info): New class.
2158         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2159
2160 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2161
2162         * valops.c (find_overload_match): Remove use of null_cleanup, and
2163         calls to do_cleanups.
2164
2165 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2166
2167         * compile/compile-cplus-types.c
2168         (compile_cplus_instance::decl_name): Handle changes to
2169         cp_func_name.
2170         * cp-support.c (cp_func_name): Update header comment, update
2171         return type.
2172         * cp-support.h (cp_func_name): Update return type in declaration.
2173         * valops.c (find_overload_match): Move temp_func local to top
2174         level of function and change its type.  Use temp_func to hold and
2175         delete temporary string obtained from cp_func_name.
2176
2177 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2178
2179         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2180         gdb::char_vector, remove cleanup, and update uses of `msg`.
2181
2182 2019-01-03  Jim Wilson  <jimw@sifive.com>
2183
2184         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2185
2186 2019-01-02  Tom Tromey  <tom@tromey.com>
2187
2188         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2189         (tdesc_parse_xml): Remove cleanups.
2190         * target-descriptions.h (make_cleanup_free_target_description):
2191         Don't declare.
2192         (target_desc_deleter): New struct.
2193         (target_desc_up): New typedef.
2194         * target-descriptions.c (target_desc_deleter::operator()): Rename
2195         from free_target_description.
2196         (make_cleanup_free_target_description): Remove.
2197
2198 2019-01-02  Tom Tromey  <tom@tromey.com>
2199
2200         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2201         constructor, destructor.
2202         (linespec_parser): Remove typedef.
2203         (~linespec_parser): Rename from linespec_parser_delete.
2204         (linespec_lex_to_end, linespec_complete_label)
2205         (linespec_complete): Update.
2206         (decode_line_full): Remove cleanups.
2207         (decode_line_1): Update.
2208
2209 2019-01-02  Tom Tromey  <tom@tromey.com>
2210
2211         * python/python-internal.h (inferior_to_inferior_object): Change
2212         return type.
2213         * python/py-exitedevent.c (create_exited_event_object): Update.
2214         * python/py-inferior.c (inferior_to_inferior_object): Return
2215         gdbpy_ref.
2216         (python_new_inferior, python_inferior_deleted)
2217         (thread_to_thread_object, delete_thread_object)
2218         (build_inferior_list, gdbpy_selected_inferior): Update.
2219         * python/py-infthread.c (create_thread_object): Update.  Also fail
2220         if inferior_to_inferior_object fails.
2221
2222 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2223
2224         * inferior.h (class inferior) <displaced_step_state>: New field.
2225         * infrun.h (struct displaced_step_state): Move here from
2226         infrun.c.  Initialize fields, add constructor.
2227         <inf>: Remove field.
2228         <reset>: New method.
2229         * infrun.c (struct displaced_step_inferior_state): Move to
2230         infrun.h.
2231         (displaced_step_inferior_states): Remove.
2232         (get_displaced_stepping_state): Adust.
2233         (displaced_step_in_progress_any_inferior): Adjust.
2234         (displaced_step_in_progress_thread): Adjust.
2235         (displaced_step_in_progress): Adjust.
2236         (add_displaced_stepping_state): Remove.
2237         (get_displaced_step_closure_by_addr): Adjust.
2238         (remove_displaced_stepping_state): Remove.
2239         (infrun_inferior_exit): Call displaced_step_state.reset.
2240         (use_displaced_stepping): Don't check for NULL.
2241         (displaced_step_prepare_throw): Call
2242         get_displaced_stepping_state.
2243         (displaced_step_fixup): Don't check for NULL.
2244         (prepare_for_detach): Don't check for NULL.
2245
2246 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2247
2248         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2249          in case of call that did not complete.
2250
2251 2019-01-02  Andrey Utkin  <autkin@undo.io>
2252
2253         * symfile.c (find_separate_debug_file): Fix search of debug files for
2254         remote debuggee.
2255
2256 2019-01-02  Tom Tromey  <tom@tromey.com>
2257
2258         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2259         indentation.
2260         * python/py-frame.c (frapy_older): Remove cast.
2261         (frapy_newer): Likewise.
2262         * python/py-breakpoint.c (local_setattro): Remove cast.
2263         * python/py-arch.c (archpy_name): Remove local variable.
2264         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2265
2266 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2267
2268         * unittests/basic_string_view/element_access/char/empty.cc:
2269         Fix year range in copyright header.
2270
2271 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2272
2273         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2274         Delete.
2275         <operator==>: Update with for removed field.
2276         <hash>: Likewise.
2277         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2278         <isa_features>: ...this.
2279         <abi_features>: New field.
2280         (riscv_isa_flen): Update comment.
2281         (riscv_abi_xlen): New declaration.
2282         (riscv_abi_flen): New declaration.
2283         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2284         isa_features.
2285         (riscv_abi_xlen): New function.
2286         (riscv_isa_flen): Update to get answer from isa_features.
2287         (riscv_abi_flen): New function.
2288         (riscv_has_fp_abi): Update to get answer from abi_features.
2289         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2290         xlen and flen.
2291         (riscv_call_info) <xlen, flen>: Update comment.
2292         (riscv_call_arg_struct): Remove invalid assertions
2293         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2294         is removed.
2295         (riscv_gdbarch_init): Gather isa features and abi features
2296         separately, ensure both match on the gdbarch when reusing an old
2297         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2298         a target with 64-bit float hardware.
2299
2300 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2301
2302         * source.c (search_command_helper): Stop reverse search
2303         when line 1 has been searched.
2304
2305 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2306
2307         * record-full.c (record_full_base_target::close): Rewrite
2308         record_full_core_buf_list free logic.
2309
2310 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2311
2312         * break-catch-syscall.c (print_one_catch_syscall): xfree
2313         the last text.
2314
2315 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2316
2317         * top.c (print_gdb_version): Update Copyright year in version
2318         message.
2319
2320 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2321
2322         Update copyright year range in all GDB files.
2323
2324 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2325
2326         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2327
2328 For older changes see ChangeLog-2018.
2329 \f
2330 Local Variables:
2331 mode: change-log
2332 left-margin: 8
2333 fill-column: 74
2334 version-control: never
2335 coding: utf-8
2336 End:
2337