gdb/ChangeLog

   1 2019-09-18  Christian Groessler  <chris@groessler.org>
   2
   3         * alpha-linux-nat.c: Include gdbarch.h.
   4
   5 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
   6
   7         * ui-file.c: Include cli/cli-style.h.
   8         (term_cli_styling): Remove cli_styling declaration.
   9
  10 2019-09-18  Alan Modra  <amodra@gmail.com>
  11
  12         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
  13         to bfd_asymbol_section.
  14
  15 2019-09-18  Alan Modra  <amodra@gmail.com>
  16
  17         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
  18         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
  19         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
  20
  21 2019-09-18  Alan Modra  <amodra@gmail.com>
  22
  23         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
  24         * spu-linux-nat.c (spu_bfd_open): Likewise.
  25
  26 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
  27
  28         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
  29         to bool to match definition in dwarf2read.c.
  30
  31 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
  32
  33         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
  34         (print_signatures): Likewise.
  35         (trust_pad_over_xvs): Likewise.
  36         * arch/aarch64-insn.c (aarch64_debug): Likewise.
  37         * arch/aarch64-insn.h (aarch64_debug): Likewise.
  38         * arm-linux-nat.c (arm_apcs_32): Likewise.
  39         * arm-linux-tdep.c (arm_apcs_32): Likewise.
  40         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
  41         * arm-tdep.c (arm_debug): Likewise.
  42         (arm_apcs_32): Likewise.
  43         * auto-load.c (debug_auto_load): Likewise.
  44         (auto_load_gdb_scripts): Likewise.
  45         (global_auto_load): Likewise.
  46         (auto_load_local_gdbinit): Likewise.
  47         (auto_load_local_gdbinit_loaded): Likewise.
  48         * auto-load.h (global_auto_load): Likewise.
  49         (auto_load_local_gdbinit): Likewise.
  50         (auto_load_local_gdbinit_loaded): Likewise.
  51         * breakpoint.c (disconnected_dprintf): Likewise.
  52         (breakpoint_proceeded): Likewise.
  53         (automatic_hardware_breakpoints): Likewise.
  54         (always_inserted_mode): Likewise.
  55         (target_exact_watchpoints): Likewise.
  56         (_initialize_breakpoint): Update.
  57         * breakpoint.h (target_exact_watchpoints): Change to bool.
  58         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
  59         * cli/cli-cmds.c (trace_commands): Likewise.
  60         * cli/cli-cmds.h (trace_commands): Likewise.
  61         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
  62         to bool*.
  63         * cli/cli-logging.c (logging_overwrite): Change to bool.
  64         (logging_redirect): Likewise.
  65         (debug_redirect): Likewise.
  66         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
  67         (struct boolean_option_def) <get_var_address_cb_>: Change return type
  68         to bool.
  69         <boolean_option_def>: Update.
  70         (struct flag_option_def): Change default type of Context to bool
  71         from int.
  72         <flag_option_def>: Change return type of var_address_cb_ to bool*.
  73         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
  74         (get_setshow_command_value_string): Likewise.
  75         * cli/cli-style.c (cli_styling): Change to bool.
  76         (source_styling): Likewise.
  77         * cli/cli-style.h (source_styling): Likewise.
  78         (cli_styling): Likewise.
  79         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
  80         to bool.
  81         * command.h (var_types): Update comment.
  82         (add_setshow_boolean_cmd): Change int* var argument to bool*.
  83         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
  84         bool.
  85         (debug_compile_cplus_scopes): Likewise.
  86         * compile/compile-internal.h (compile_debug): Likewise.
  87         * compile/compile.c (compile_debug): Likewise.
  88         (struct compile_options) <raw>: Likewise.
  89         * cp-support.c (catch_demangler_crashes): Likewise.
  90         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
  91         (usr_cmd_cris_dwarf2_cfi): Likewise.
  92         * csky-tdep.c (csky_debug): Likewise.
  93         * darwin-nat.c (enable_mach_exceptions): Likewise.
  94         * dcache.c (dcache_enabled_p): Likewise.
  95         * defs.h (info_verbose): Likewise.
  96         * demangle.c (demangle): Likewise.
  97         (asm_demangle): Likewise.
  98         * dwarf-index-cache.c (debug_index_cache): Likewise.
  99         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 100         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 101         * dwarf2read.c (check_physname): Likewise.
 102         (use_deprecated_index_sections): Likewise.
 103         (dwarf_always_disassemble): Likewise.
 104         * eval.c (overload_resolution): Likewise.
 105         * event-top.c (set_editing_cmd_var): Likewise.
 106         (exec_done_display_p): Likewise.
 107         * event-top.h (set_editing_cmd_var): Likewise.
 108         (exec_done_display_p): Likewise.
 109         * exec.c (write_files): Likewise.
 110         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 111         (debug_fbsd_nat): Likewise.
 112         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 113         Likewise.
 114         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 115         <backtrace_past_entry> Likewise.
 116         * gdb-demangle.h (demangle): Likewise.
 117         (asm_demangle): Likewise.
 118         * gdb_bfd.c (bfd_sharing): Likewise.
 119         * gdbcore.h (write_files): Likewise.
 120         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 121         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 122         * gdbthread.h (print_thread_events): Likewise.
 123         * gdbtypes.c (opaque_type_resolution): Likewise.
 124         (strict_type_checking): Likewise.
 125         * gnu-nat.c (gnu_debug_flag): Likewise.
 126         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 127         * guile/scm-param.c (pascm_variable): Add boolval.
 128         (add_setshow_generic): Update.
 129         (pascm_param_value): Update.
 130         (pascm_set_param_value_x): Update.
 131         * hppa-tdep.c (hppa_debug): Change to bool..
 132         * infcall.c (may_call_functions_p): Likewise.
 133         (coerce_float_to_double_p): Likewise.
 134         (unwind_on_signal_p): Likewise.
 135         (unwind_on_terminating_exception_p): Likewise.
 136         * infcmd.c (startup_with_shell): Likewise.
 137         * inferior.c (print_inferior_events): Likewise.
 138         * inferior.h (startup_with_shell): Likewise.
 139         (print_inferior_events): Likewise.
 140         * infrun.c (step_stop_if_no_debug): Likewise.
 141         (detach_fork): Likewise.
 142         (debug_displaced): Likewise.
 143         (disable_randomization): Likewise.
 144         (non_stop): Likewise.
 145         (non_stop_1): Likewise.
 146         (observer_mode): Likewise.
 147         (observer_mode_1): Likewise.
 148         (set_observer_mode): Update.
 149         (sched_multi): Change to bool.
 150         * infrun.h (debug_displaced): Likewise.
 151         (sched_multi): Likewise.
 152         (step_stop_if_no_debug): Likewise.
 153         (non_stop): Likewise.
 154         (disable_randomization): Likewise.
 155         * linux-tdep.c (use_coredump_filter): Likewise.
 156         (dump_excluded_mappings): Likewise.
 157         * linux-thread-db.c (auto_load_thread_db): Likewise.
 158         (check_thread_db_on_load): Likewise.
 159         * main.c (captured_main_1): Update.
 160         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 161         xx2_opt, boolean_opt>: Change to bool.
 162         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 163         * maint.c (maintenance_profile_p): Likewise.
 164         (per_command_time): Likewise.
 165         (per_command_space): Likewise.
 166         (per_command_symtab): Likewise.
 167         * memattr.c (inaccessible_by_default): Likewise.
 168         * mi/mi-main.c (mi_async): Likewise.
 169         (mi_async_1): Likewise.
 170         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 171         * nat/fork-inferior.h (startup_with_shell): Likewise.
 172         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 173         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 174         * nios2-tdep.c (nios2_debug): Likewise.
 175         * or1k-tdep.c (or1k_debug): Likewise.
 176         * parse.c (parser_debug): Likewise.
 177         * parser-defs.h (parser_debug): Likewise.
 178         * printcmd.c (print_symbol_filename): Likewise.
 179         * proc-api.c (procfs_trace): Likewise.
 180         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 181         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 182         (set_parameter_value): Update.
 183         (add_setshow_generic): Update.
 184         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 185         to bool*.
 186         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 187         int*.
 188         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 189         * record-btrace.c (record_btrace_target::store_registers): Update.
 190         * record-full.c (record_full_memory_query): Change to bool.
 191         (record_full_stop_at_limit): Likewise.
 192         * record-full.h (record_full_memory_query): Likewise.
 193         * remote-notif.c (notif_debug): Likewise.
 194         * remote-notif.h (notif_debug): Likewise.
 195         * remote.c (use_range_stepping): Likewise.
 196         (interrupt_on_connect): Likewise.
 197         (remote_break): Likewise.
 198         * ser-tcp.c (tcp_auto_retry): Likewise.
 199         * ser-unix.c (serial_hwflow): Likewise.
 200         * skip.c (debug_skip): Likewise.
 201         * solib-aix.c (solib_aix_debug): Likewise.
 202         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 203         (spu_auto_flush_cache_p): Likewise.
 204         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 205         Likewise.
 206         (struct info_print_options) <quiet>: Likewise.
 207         * symfile-debug.c (debug_symfile): Likewise.
 208         * symfile.c (auto_solib_add): Likewise.
 209         (separate_debug_file_debug): Likewise.
 210         * symfile.h (auto_solib_add): Likewise.
 211         (separate_debug_file_debug): Likewise.
 212         * symtab.c (basenames_may_differ): Likewise.
 213         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 214         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 215         (struct info_types_options) <quiet>: Likewise.
 216         * symtab.h (demangle): Likewise.
 217         (basenames_may_differ): Likewise.
 218         * target-dcache.c (stack_cache_enabled_1): Likewise.
 219         (code_cache_enabled_1): Likewise.
 220         * target.c (trust_readonly): Likewise.
 221         (may_write_registers): Likewise.
 222         (may_write_memory): Likewise.
 223         (may_insert_breakpoints): Likewise.
 224         (may_insert_tracepoints): Likewise.
 225         (may_insert_fast_tracepoints): Likewise.
 226         (may_stop): Likewise.
 227         (auto_connect_native_target): Likewise.
 228         (target_stop_and_wait): Update.
 229         (target_async_permitted): Change to bool.
 230         (target_async_permitted_1): Likewise.
 231         (may_write_registers_1): Likewise.
 232         (may_write_memory_1): Likewise.
 233         (may_insert_breakpoints_1): Likewise.
 234         (may_insert_tracepoints_1): Likewise.
 235         (may_insert_fast_tracepoints_1): Likewise.
 236         (may_stop_1): Likewise.
 237         * target.h (target_async_permitted): Likewise.
 238         (may_write_registers): Likewise.
 239         (may_write_memory): Likewise.
 240         (may_insert_breakpoints): Likewise.
 241         (may_insert_tracepoints): Likewise.
 242         (may_insert_fast_tracepoints): Likewise.
 243         (may_stop): Likewise.
 244         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 245         (make_thread_apply_all_options_def_group): Change argument from int*
 246         to bool*.
 247         (thread_apply_all_command): Update.
 248         (print_thread_events): Change to bool.
 249         * top.c (confirm): Likewise.
 250         (command_editing_p): Likewise.
 251         (history_expansion_p): Likewise.
 252         (write_history_p): Likewise.
 253         (info_verbose): Likewise.
 254         * top.h (confirm): Likewise.
 255         (history_expansion_p): Likewise.
 256         * tracepoint.c (disconnected_tracing): Likewise.
 257         (circular_trace_buffer): Likewise.
 258         * typeprint.c (print_methods): Likewise.
 259         (print_typedefs): Likewise.
 260         * utils.c (debug_timestamp): Likewise.
 261         (sevenbit_strings): Likewise.
 262         (pagination_enabled): Likewise.
 263         * utils.h (sevenbit_strings): Likewise.
 264         (pagination_enabled): Likewise.
 265         * valops.c (overload_resolution): Likewise.
 266         * valprint.h (struct value_print_options) <prettyformat_arrays,
 267         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 268         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 269         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 270         Likewise.
 271         * windows-nat.c (new_console): Likewise.
 272         (cygwin_exceptions): Likewise.
 273         (new_group): Likewise.
 274         (debug_exec): Likewise.
 275         (debug_events): Likewise.
 276         (debug_memory): Likewise.
 277         (debug_exceptions): Likewise.
 278         (useshell): Likewise.
 279         * windows-tdep.c (maint_display_all_tib): Likewise.
 280         * xml-support.c (debug_xml): Likewise.
 281
 282 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 283
 284         * source.c (prepare_path_for_appending): New function.
 285         (openp): Make use of new function.
 286         (find_and_open_source): Search for the compilation directory and
 287         source file as a relative path beneath the directory search path.
 288
 289 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 290
 291         * source-cache.c (source_cache::get_line_charpos): Catch
 292         exceptions and return false, this matches the behaviour documented
 293         in the header file.
 294
 295 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 296
 297         * ada-tasks.c (info_task): Remove quoting of the task's name.
 298
 299 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 300
 301         * symfile.c (auto_solib_add): Replace comment with a reference
 302         to the header file.
 303
 304 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 305
 306         * NEWS: Mention that gdb can now be compiled with Python 3
 307         on Windows.
 308
 309 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 310
 311         * maint.c (maint_print_section_data::maint_print_section_data):
 312         Force use of 'float log10 (float)' by casting the argument to
 313         float.
 314
 315 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 316
 317         * maint.c: Add 'cmath' include.
 318         (struct maint_print_section_data): New structure.
 319         (print_section_index): New function.
 320         (print_bfd_section_info): Add header comment, small whitespace
 321         cleanup, and update to call new print_section_index function.
 322         (print_objfile_section_info): Likewise.
 323         (maint_obj_section_from_bfd_section): New function.
 324         (print_bfd_section_info_maybe_relocated): New function.
 325         (maintenance_info_sections): Add header comment, always use
 326         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 327
 328 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 329
 330         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 331         inner scope, add check that the objfile has psymtabs before
 332         checking psymtabs_addrmap.
 333         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 334
 335 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 336
 337         * NEWS: Announce that Ada task names are now shown at more places,
 338         and between quotes (except in info task output).
 339         * gdb/ada-tasks.c (task_to_str): New function.
 340         (display_current_task_id): Call task_to_str.
 341         (task_command_1): Likewise.
 342         (print_ada_task_info): In non-mi mode, Properly align headers and data
 343         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 344
 345 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 346
 347         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 348         prstatus.pr_lwp.pr_info instead of making it up.
 349
 350 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 351
 352         * auto-load.c (auto_load_expand_dir_vars): Update.
 353         * defs.h (gdb_datadir): Change to std::string.
 354         (python_libdir): Likewise.
 355         (relocate_gdb_directory): Change return type to std::string.
 356         * guile/guile.c (gdbscm_data_directory): Update.
 357         (initialize_scheme_side): Update.
 358         * jit.c (jit_reader_dir): Change to std::string.
 359         (jit_reader_load_command): Update.
 360         * main.c (gdb_datadir): Change to std::string.
 361         (python_libdir): Likewise.
 362         (set_gdb_data_directory): Update.
 363         (relocate_path): Change to return std::string.
 364         (relocate_gdb_directory): Change to return std::string.
 365         (relocate_gdbinit_path_maybe_in_datadir): Update.
 366         (captured_main_1): Update.
 367         * python/python.c (do_start_initialization): Update.
 368         * top.c (show_gdb_datadir): Update.
 369         * xml-syscall.c (xml_init_syscalls_info): Update.
 370         (init_syscalls_info): Update.
 371
 372 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 373
 374         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 375         out of get_init_files.
 376         (get_init_files): Update.
 377
 378 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 379
 380         * main.c (get_init_files): Change to use std::string.
 381         (captured_main_1): Update.
 382         (print_gdb_help): Update.
 383
 384 2019-09-11  Ali Tamur  <tamur@google.com>
 385
 386         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 387         implementation.
 388
 389 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 390
 391         * dbxread.c (read_dbx_symtab): Update.
 392         * dwarf2read.c (load_partial_dies): Update.
 393         * mdebugread.c (parse_partial_symbols): Update.
 394         (handle_psymbol_enumerators): Update.
 395         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 396         * psymtab.c (add_psymbol_to_bcache): Likewise.
 397         (add_psymbol_to_list): Likewise.
 398         * symtab.c (symbol_set_names): Likewise.
 399         * symtab.h (symbol_set_names): Likewise.
 400         * xcoffread.c (scan_xcoff_symtab): Update.
 401
 402 2019-09-11  Tom Tromey  <tom@tromey.com>
 403
 404         * symfile-mem.c (symbol_file_add_from_memory): Use
 405         bfd_set_filename.
 406         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 407         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 408
 409 2019-09-10  Tom Tromey  <tromey@adacore.com>
 410
 411         * dwarf-index-write.c (write_psymbols): Extend error message.
 412         (debug_names::insert): Add Ada code.
 413         (debug_names::write_psymbols): Remove Ada check.
 414         (debug_names) <m_string_obstack>: New member.
 415         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 416         (gdb_index_symbol_name_matcher::matches): Remove.
 417         (mapped_index_base::find_name_components_bounds): Add "lang"
 418         parameter.
 419         (mapped_index_base::build_name_components): Also split names
 420         according to Ada syntax.
 421         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 422         type of "match_callback".
 423         (check_match, check_find_bounds_finds)
 424         (dw2_expand_symtabs_matching): Update.
 425         (dw2_debug_names_iterator): Add new constructor.
 426         (dw2_debug_names_map_matching_symbols): New function.
 427         (dw2_debug_names_expand_symtabs_matching): Update.
 428         (dwarf2_debug_names_functions): Use
 429         dw2_debug_names_map_matching_symbols.
 430
 431 2019-09-10  Tom Tromey  <tromey@adacore.com>
 432
 433         * dwarf2read.c (dw2_get_file_names_reader): Add the
 434         CU's file name to the results.
 435
 436 2019-09-10  Tom Tromey  <tromey@adacore.com>
 437
 438         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 439         map_matching_symbols.  Update.
 440         * dwarf2read.c (dw2_map_matching_symbols): Update.
 441         * psymtab.c (match_partial_symbol): Change type; update.
 442         (psym_map_matching_symbols): Likewise.
 443         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 444         type; update.
 445         * symfile.h (struct quick_symbol_functions)
 446         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 447         Remove "match".
 448
 449 2019-09-10  Tom Tromey  <tromey@adacore.com>
 450
 451         * psymtab.c (map_block): Remove.
 452         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 453         * symtab.c (iterate_over_symbols_terminated): New function.
 454         * symtab.c (iterate_over_symbols_terminated): Declare.
 455
 456 2019-09-10  Tom Tromey  <tromey@adacore.com>
 457
 458         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 459         * language.h (struct language_defn) <la_iterate_over_symbols>:
 460         Return bool.
 461         * symtab.c (iterate_over_symbols): Return bool.
 462         * symtab.h (iterate_over_symbols): Return bool.
 463
 464 2019-09-10  Tom Tromey  <tromey@adacore.com>
 465
 466         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 467         (add_nonlocal_symbols): Update.
 468         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 469         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 470         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 471         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 472         Change type of "callback".  Remove "data".
 473
 474
 475 2019-09-09  Ali Tamur  <tamur@google.com>
 476
 477         * dwarf2read.c (comp_unit_head): Update comment.
 478         (dwarf2_dwo_name): New function declaration.
 479         (dwarf_unit_type_name): New function declaration.
 480         (read_comp_unit_head): Add support for new compilation units,
 481         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 482         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 483         (currently named as "signature") in their header. Also clarify error
 484         messages.
 485         (lookup_dwo_id): New function. Returns the dwo id of the given
 486         compile unit.
 487         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 488         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 489         functions.
 490         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 491         (dwarf2_dwo_name): Get the dwo name if present.
 492         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 493         purposes.
 494
 495 2019-09-09  Tom Tromey  <tom@tromey.com>
 496
 497         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 498
 499 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 500
 501         * python/python.c (do_start_initialization): Make progname_copy static,
 502         to avoid a leak report.
 503
 504 2019-09-08  Tom Tromey  <tom@tromey.com>
 505
 506         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 507
 508 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 509
 510         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 511         Change type to gdb::optional<block_enum>.
 512         (dw2_symtab_iter_init): Change block_index parameter type
 513         to gdb::optional<block_enum>.
 514         (dw2_lookup_symbol): Change block_index parameter
 515         type to block_enum.c
 516         (dw2_debug_names_lookup_symbol): Likewise.
 517         * psymtab.c (psym_lookup_symbol): Likewise.
 518         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 519         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 520         Likewise.
 521
 522 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 523
 524         * defs.h (relocate_gdb_directory): Change int to bool in
 525         signature and rename flag to relocatable.
 526         * main.c (relocate_path): Likewise.
 527         (relocate_gdb_directory): Likewise.
 528
 529 2019-09-06  Alan Modra  <amodra@gmail.com>
 530
 531         * coffread.c (coff_symfile_read): Constify filename variable.
 532         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 533         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 534         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 535         * solib.c (reload_shared_libraries_1): Likewise.
 536         * symfile.c (reread_symbols): Likewise.
 537         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 538         * solib-darwin.c (darwin_bfd_open): Likewise.
 539         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 540
 541 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 542
 543         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 544         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 545
 546 2019-09-03  Tom Tromey  <tromey@adacore.com>
 547
 548         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 549         types.
 550         (has_negatives): Unbias a range type bound.
 551         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 552         * gdbtypes.c (operator==): Handle new field.
 553         (create_range_type): Add "bias" parameter.
 554         (create_static_range_type, resolve_dynamic_range): Update.
 555         * gdbtypes.h (struct range_bounds) <bias>: New member.
 556         (create_range_type): Add bias parameter.
 557         * printcmd.c (print_scalar_formatted): Unbias range types.
 558         * value.c (unpack_long): Unbias range types.
 559         (pack_long): Bias range types.
 560
 561 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 562
 563         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 564         probe arguments.
 565
 566 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 567
 568         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 569         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 570         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 571         (compile_probe_arg): Likewise.
 572         * probe.h (get_argument_count): Likewise.
 573         * solib-svr4.c (solib_event_probe_action): Likewise.
 574         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 575
 576 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 577
 578         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 579         code to here...
 580         (svr4_create_solib_event_breakpoints): ...from here.
 581
 582 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 583
 584         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 585         suffix from warning message.
 586
 587 2019-08-30  Tom Tromey  <tom@tromey.com>
 588
 589         * tui/tui-winsource.h (struct tui_source_window_base)
 590         <refresh_all>: Don't declare.
 591         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 592         Remove.
 593         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 594         tui_show_locator_content.
 595         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 596         declare.
 597         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 598         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 599         declare.
 600
 601 2019-08-30  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 604
 605 2019-08-30  Tom Tromey  <tom@tromey.com>
 606
 607         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 608         Remove unnecessary forward declarations.
 609
 610 2019-08-30  Tom Tromey  <tom@tromey.com>
 611
 612         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 613         rerender.
 614         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 615         tui_show_locator_content.
 616
 617 2019-08-30  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 620         (tui_locator_window::rerender): Rewrite using body of previous
 621         tui_show_locator_content.
 622
 623 2019-08-30  Tom Tromey  <tom@tromey.com>
 624
 625         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 626         set_locator_fullname>: New methods.
 627         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 628         Rename from tui_set_locator_fullname.
 629         (tui_locator_window::set_locator_info): Rename from
 630         tui_set_locator_info.  Return bool.
 631         (tui_update_locator_fullname, tui_show_frame_info): Update.
 632
 633 2019-08-30  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 636
 637 2019-08-30  Tom Tromey  <tom@tromey.com>
 638
 639         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 640         call touchwin.
 641
 642 2019-08-30  Tom Tromey  <tom@tromey.com>
 643
 644         * tui/tui-wingeneral.c (box_win): Assume win_info and
 645         win_info->handle cannot be NULL.
 646
 647 2019-08-30  Tom Tromey  <tom@tromey.com>
 648
 649         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 650         refresh_window>: Declare.
 651         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 652         resize.
 653         (tui_data_item_window::rerender): Rename from
 654         tui_display_register.
 655         (tui_data_item_window::refresh_window): New method.
 656         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 657         no-op.
 658
 659 2019-08-30  Tom Tromey  <tom@tromey.com>
 660
 661         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 662         regs_column_count, current_group>: Move later.  Now private.
 663         <get_current_group>: New method.
 664         * tui/tui-regs.c (tui_reg_command): Update.
 665         * tui/tui-layout.c (tui_set_layout): Update.
 666
 667 2019-08-30  Tom Tromey  <tom@tromey.com>
 668
 669         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 670         (tui_data_window::rerender): Don't call
 671         check_and_display_highlight_if_needed.
 672         (tui_data_window::refresh_all): Remove call to
 673         erase_data_content.
 674
 675 2019-08-30  Tom Tromey  <tom@tromey.com>
 676
 677         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 678         (tui_data_window::display_registers_from)
 679         (tui_data_window::display_reg_element_at_line)
 680         (tui_data_window::display_registers_from_line): Remove checks of
 681         "empty".
 682
 683 2019-08-30  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 686         Don't declare.
 687         * tui/tui-regs.c (tui_data_window::show_registers): Call
 688         rerender.
 689         (tui_data_window::rerender): Rename from display_all_data.
 690         (tui_data_window::rerender): Remove old implementation.
 691
 692 2019-08-30  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 695         text.
 696         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 697
 698 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 699             Sergio Durigan Junior  <sergiodj@redhat.com>
 700
 701         PR win32/24284
 702         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 703
 704 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 705
 706         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 707         when searching for types.
 708
 709 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 710
 711         * f-lang.c (f_language_defn): Use f_print_typedef.
 712         * f-lang.h (f_print_typedef): Declare.
 713         * f-typeprint.c (f_print_typedef): Define.
 714
 715 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 716
 717         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 718
 719 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 720
 721         * cli/cli-utils.c (info_print_options_defs): Delete.
 722         (make_info_print_options_def_group): Delete.
 723         (extract_info_print_options): Delete.
 724         (info_print_command_completer): Delete.
 725         (info_print_args_help): Add extra parameter, and optionally
 726         include text about -n flag.
 727         * cli/cli-utils.h (struct info_print_options): Delete.
 728         (extract_info_print_options): Delete declaration.
 729         (info_print_command_completer): Delete declaration.
 730         (info_print_args_help): Add extra parameter, extend header
 731         comment.
 732         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 733         search_symbols.
 734         * stack.c (struct info_print_options): New type.
 735         (info_print_options_defs): New file scoped variable.
 736         (make_info_print_options_def_group): New static function.
 737         (info_print_command_completer): New static function.
 738         (info_locals_command): Update to use new local functions.
 739         (info_args_command): Likewise.
 740         (_initialize_stack): Add extra parameter to calls to
 741         info_print_args_help.
 742         * symtab.c (search_symbols): Add extra parameter, use this to
 743         possibly excluse non-debug symbols.
 744         (symtab_symbol_info): Add extra parameter, which is passed on to
 745         search_symbols.
 746         (struct info_print_options): New type.
 747         (info_print_options_defs): New file scoped variable.
 748         (make_info_print_options_def_group): New static function.
 749         (info_print_command_completer): New static function.
 750         (info_variables_command): Update to use local functions, and pass
 751         extra parameter through to symtab_symbol_info.
 752         (info_functions_command): Likewise.
 753         (info_types_command): Pass additional argument through to
 754         symtab_symbol_info.
 755         (rbreak_command): Pass extra argument to search_symbols.
 756         (_initialize_symtab): Add extra arguments for calls to
 757         info_print_args_help, and update help text for 'info variables',
 758         'whereis', and 'info functions' commands.
 759         * symtab.h (search_symbols): Add extra argument to declaration.
 760         * NEWS: Mention new flags.
 761
 762 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 763
 764         * symtab.c (lookup_static_symbol): Call the new function (and move
 765         it down to be next to lookup_global_symbol).
 766         (struct global_sym_lookup_data): Add block_enum member and rename to...
 767         (struct global_or_static_sym_lookup_data): ...this.
 768         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 769         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 770         (lookup_symbol_global_or_static_iterator_cb): ...this.
 771         (lookup_global_or_static_symbol): New function.
 772         (lookup_global_symbol): Call new function.
 773
 774 2019-08-26  Tom de Vries  <tdevries@suse.de>
 775
 776         PR c++/24852
 777         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 778         when pc_probe.prob == NULL.
 779
 780 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 781
 782         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 783         variable symbol_linkage to symbol_linkage_.
 784
 785 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 786
 787         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 788         represent whether the symbol is static, dynamic, or we don't
 789         know.
 790
 791 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 792
 793         * gdb/rx-tdep.c (rx_register_names): New.
 794         (rx_register_name): Delete.
 795         (rx_psw_type): Delete.
 796         (rx_fpsw_type): Delete.
 797         (rx_register_type): Delete.
 798         (rx_gdbarch_init): Convert target-descriptions.
 799         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 800         * gdb/features/Makefile: Add rx.xml.
 801         * gdb/features/rx.xml: New.
 802         * gdb/features/rx.c: Generated.
 803         * gdb/NEWS: Mention target description support.
 804
 805 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 806
 807         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 808         *slot_ptr.
 809
 810 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 811
 812         * configure.ac: Don't check for 'dlfcn.h' (moved to
 813         gdbsupport/common.m4).
 814         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 815         'gdbsupport/'.
 816         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 817         * compile/compile-c-support.c: Include
 818         'gdbsupport/gdb-dlfcn.h'.
 819         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 820         * gdb-dlfcn.c: Move to...
 821         * gdbsupport/gdb-dlfcn.c: ... here.
 822         * gdb-dlfcn.h: Move to...
 823         * gdbsupport/gdb-dlfcn.h: ... here.
 824
 825 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 826
 827         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 828         the offset field signed.
 829
 830 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 831
 832         * python/lib/gdb/__init__.py (_execute_file): New function.
 833         * python/python.c (python_run_simple_file): Call gdb._execute_file
 834         on Windows.
 835
 836 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 837
 838         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 839         all uses as this was never set to anything but a zero value.
 840
 841 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 842
 843         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 844
 845 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 846
 847         * tui/tui-data.h (tui_gen_win_info): Add an =default
 848         move constructor, required by some GCC versions.
 849
 850 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 851
 852         * go32-nat.c (go32_sysinfo): Add hygon_p.
 853
 854 2019-08-20  Tom Tromey  <tom@tromey.com>
 855
 856         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 857         line_from_reg_element_no, first_reg_element_no_inline,
 858         display_all_data, delete_data_content_windows,
 859         erase_data_content>: Now private.
 860
 861 2019-08-20  Tom Tromey  <tom@tromey.com>
 862
 863         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 864         (tui_unhighlight_win, tui_highlight_win)
 865         (tui_win_info::make_window): Update.
 866         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 867
 868 2019-08-20  Tom Tromey  <tom@tromey.com>
 869
 870         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 871         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 872         (MAX_PID_WIDTH): Move to tui-stack.c.
 873         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 874         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 875         (MAX_PID_WIDTH): Move from tui-data.h.
 876
 877 2019-08-20  Tom Tromey  <tom@tromey.com>
 878
 879         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 880         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 881         (box_win): Update.
 882         (tui_gen_win_info::make_window): Rename from tui_make_window.
 883         (tui_win_info::make_window): New method.
 884         (tui_gen_win_info::make_visible): Update.
 885         * tui/tui-source.c (tui_source_window::set_contents): Update.
 886         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 887         (tui_data_window::display_registers_from): Update.
 888         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 889         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 890         Declare.
 891         <can_box>: Remove.
 892         <title>: Remove.
 893         (struct tui_win_info) <make_window>: Declare.
 894         <can_box>: Now virtual.
 895         <title>: New member.
 896         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 897         * tui/tui-command.c (tui_cmd_window::resize): Update.
 898
 899 2019-08-20  Tom Tromey  <tom@tromey.com>
 900
 901         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 902         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 903         (tui_data_window::check_register_values): Update.
 904
 905 2019-08-20  Tom Tromey  <tom@tromey.com>
 906
 907         * tui/tui-regs.h (struct tui_data_window): Use
 908         DISABLE_COPY_AND_ASSIGN.
 909         <regs_content>: Change type, removing unique_ptr.
 910         <tui_data_window>: Add move constructor.
 911         * tui/tui-regs.c (tui_data_window::show_registers)
 912         (tui_data_window::show_register_group)
 913         (tui_data_window::display_registers_from)
 914         (tui_data_window::display_registers_from)
 915         (tui_data_window::first_data_item_displayed)
 916         (tui_data_window::delete_data_content_windows)
 917         (tui_data_window::rerender, tui_data_window::refresh_window)
 918         (tui_data_window::check_register_values): Update.
 919
 920 2019-08-20  Tom Tromey  <tom@tromey.com>
 921
 922         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 923         show_register_group>: Declare.
 924         (tui_show_register_group): Don't declare.
 925         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 926         tui_show_registers.
 927         (tui_data_window::show_register_group): Rename from
 928         tui_show_register_group.
 929         (tui_data_window::check_register_values, tui_reg_command):
 930         Update.
 931         * tui/tui-layout.c (tui_set_layout): Update.
 932
 933 2019-08-20  Tom Tromey  <tom@tromey.com>
 934
 935         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 936         Declare.
 937         (tui_check_register_values): Don't declare.
 938         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 939         from tui_check_register_values.
 940         * tui/tui-hooks.c (tui_register_changed): Update.
 941
 942 2019-08-20  Tom Tromey  <tom@tromey.com>
 943
 944         * tui/tui-regs.c (tui_reg_layout): Move later.
 945         (tui_show_registers): Don't enable TUI mode or change layout.
 946
 947 2019-08-20  Tom Tromey  <tom@tromey.com>
 948
 949         * tui/tui-regs.h (struct tui_data_item_window)
 950         <~tui_data_item_window>: Remove.
 951         <content>: Now a unique_xmalloc_ptr.
 952         * tui/tui-regs.c (tui_register_format): Return a
 953         unique_xmalloc_ptr.
 954         (tui_get_register): Update.
 955         (~tui_data_item_window): Remove.
 956         (tui_data_window::display_registers_from, tui_display_register):
 957         Update.
 958         * tui/tui-io.h (tui_expand_tabs): Update.
 959         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 960         Remove "col" parameter.
 961
 962 2019-08-20  Tom Tromey  <tom@tromey.com>
 963
 964         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 965         field.
 966         * tui/tui-regs.c (~tui_data_item_window): Update.
 967
 968 2019-08-20  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 971         earlier.
 972
 973 2019-08-20  Tom Tromey  <tom@tromey.com>
 974
 975         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 976
 977 2019-08-20  Tom Tromey  <tom@tromey.com>
 978
 979         * tui/tui-source.h (struct tui_source_window): Update.
 980         * tui/tui-regs.c (tui_show_registers): Update.
 981         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 982         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 983         (NO_REGS_STRING): Remove defines.
 984
 985 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 986
 987         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 988         unnecessary thread walk if remote doesn't support the packet.
 989
 990 2019-08-19  Tom Tromey  <tromey@adacore.com>
 991
 992         * python/py-value.c (value_has_field): Fix indentation.
 993
 994 2019-08-19  Tom Tromey  <tromey@adacore.com>
 995
 996         * printcmd.c (do_one_display, info_display_command): Update.
 997         * block.h (contained_in): Return bool.  Add allow_nested
 998         parameter.
 999         * block.c (contained_in): Return bool.  Add allow_nested
1000         parameter.
1001
1002 2019-08-19  Tom Tromey  <tom@tromey.com>
1003
1004         * configure: Rebuild.
1005         * configure.ac: Disallow the combination of -static-libstdc++ and
1006         source highlight.
1007         * source-cache.c (get_language_name): Handle rust.
1008         (source_cache::get_source_lines): Ignore highlighting exceptions.
1009
1010 2019-08-16  Tom Tromey  <tom@tromey.com>
1011
1012         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1013         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1014         (struct tui_source_window_base) <make_visible, refresh_window,
1015         resize>: Remove methods.
1016         <execution_info>: Remove field.
1017         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1018         (tui_show_source_line, tui_source_window_base)
1019         (~tui_source_window_base): Update.
1020         (tui_source_window_base::resize)
1021         (tui_source_window_base::make_visible)
1022         (tui_source_window_base::refresh_window): Remove.
1023         (tui_source_window_base::update_exec_info): Update.
1024         * tui/tui-source.c (tui_source_window::set_contents): Update.
1025         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1026
1027 2019-08-16  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1030         deprecated_query_hook.
1031
1032 2019-08-16  Tom Tromey  <tom@tromey.com>
1033
1034         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1035         (tui_update_source_windows_with_line): Update.
1036         * tui/tui-source.h (struct tui_source_window)
1037         <show_symtab_source>: Declare.
1038         (tui_show_symtab_source): Don't declare.
1039         * tui/tui-source.c (tui_show_symtab_source): Rename from
1040         tui_show_symtab_source.
1041
1042 2019-08-16  Tom Tromey  <tom@tromey.com>
1043
1044         * tui/tui-winsource.h (struct tui_source_window_base)
1045         <set_contents>: Declare.
1046         * tui/tui-winsource.c
1047         (tui_source_window_base::update_source_window_as_is): Update.
1048         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1049         Declare.
1050         (tui_set_source_content): Don't declare.
1051         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1052         tui_set_source_content.
1053         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1054         Declare.
1055         (tui_set_disassem_content): Don't declare.
1056         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1057         tui_set_disassem_content.
1058
1059 2019-08-16  Tom Tromey  <tom@tromey.com>
1060
1061         * tui/tui-winsource.h (struct tui_source_window_base)
1062         <update_breakpoint_info>: Declare.
1063         (tui_update_breakpoint_info): Don't declare.
1064         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1065         (tui_update_all_breakpoint_info): Update.
1066         (tui_source_window_base::update_breakpoint_info): Rename from
1067         tui_update_breakpoint_info.
1068         (tui_source_window_base::update_exec_info): Update.
1069
1070 2019-08-16  Tom Tromey  <tom@tromey.com>
1071
1072         * tui/tui-winsource.h (struct tui_source_window_base)
1073         <update_source_window>: Declare.
1074         (tui_update_source_window): Don't declare.
1075         * tui/tui-winsource.c
1076         (tui_source_window_base::update_source_window): Rename from
1077         tui_update_source_window.
1078         (tui_source_window_base::rerender): Update.
1079         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1080         * tui/tui-disasm.c (tui_show_disassem)
1081         (tui_show_disassem_and_update_source)
1082         (tui_disasm_window::maybe_update): Update.
1083
1084 2019-08-16  Tom Tromey  <tom@tromey.com>
1085
1086         * tui/tui-winsource.h (struct tui_source_window_base)
1087         <update_source_window_as_is>: Declare.
1088         (tui_update_source_window_as_is): Don't declare.
1089         * tui/tui-winsource.c (tui_update_source_window): Update
1090         (tui_source_window_base::update_source_window_as_is): Rename from
1091         tui_update_source_window_as_is.
1092         (tui_source_window_base::refill): Update.
1093         * tui/tui-source.c (tui_show_symtab_source): Update.
1094         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1095         Update.
1096
1097 2019-08-16  Tom Tromey  <tom@tromey.com>
1098
1099         * tui/tui-winsource.h (tui_update_source_window)
1100         (tui_update_source_window_as_is): Remove "noerror" parameter.
1101         * tui/tui-winsource.c (tui_update_source_window)
1102         (tui_update_source_window_as_is): Remove "noerror" parameter.
1103         (tui_update_source_windows_with_addr)
1104         (tui_update_source_windows_with_line)
1105         (tui_source_window_base::rerender)
1106         (tui_source_window_base::refill): Update.
1107         * tui/tui-source.h (tui_set_source_content)
1108         (tui_show_symtab_source): Remove "noerror" parameter.
1109         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1110         parameter.
1111         (tui_show_symtab_source): Likewise.
1112         (tui_source_window::maybe_update): Update.
1113         * tui/tui-disasm.c (tui_show_disassem)
1114         (tui_show_disassem_and_update_source)
1115         (tui_disasm_window::do_scroll_vertical)
1116         (tui_disasm_window::maybe_update): Update.
1117
1118 2019-08-16  Tom Tromey  <tom@tromey.com>
1119
1120         * tui/tui.c (tui_is_window_visible): Update.
1121         * tui/tui-wingeneral.c (tui_make_window)
1122         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1123         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1124         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1125         (tui_set_win_height_command, parse_scrolling_args): Update.
1126         * tui/tui-source.c (tui_source_window::style_changed): Update.
1127         * tui/tui-regs.c (tui_show_registers)
1128         (tui_data_window::first_data_item_displayed)
1129         (tui_data_window::delete_data_content_windows)
1130         (tui_check_register_values, tui_reg_command): Update.
1131         * tui/tui-disasm.c (tui_show_disassem): Update.
1132         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1133         method.
1134         <is_visible>: Remove field.
1135         * tui/tui-data.c (tui_next_win, tui_prev_win)
1136         (tui_delete_invisible_windows): Update.
1137
1138 2019-08-16  Tom Tromey  <tom@tromey.com>
1139
1140         * tui/tui-winsource.h (struct tui_source_window_base)
1141         <m_has_locator>: Remove.
1142         * tui/tui-layout.c (show_source_disasm_command, show_data)
1143         (show_source_or_disasm_and_command): Update.
1144
1145 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1146
1147         * NEWS (Other MI changes): New subsection.
1148         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1149         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1150         * arch-utils.c (default_get_pc_address_flags): New function.
1151         * arch-utils.h (default_get_pc_address_flags): New declaration.
1152         * gdbarch.sh: Add get_pc_address_flags.
1153         * gdbarch.c: Regenerate.
1154         * gdbarch.h: Likewise.
1155         * stack.c (print_pc): New function.
1156         (print_frame_info) (print_frame): Call print_pc.
1157
1158 2019-08-16  Tom de Vries  <tdevries@suse.de>
1159
1160         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1161         print_objfile_section_info.
1162
1163 2019-08-15  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1166         calling update_cmdwin_start_line.
1167         * tui/tui-winsource.h (struct tui_source_window_base)
1168         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1169         <rerender>: Declare.
1170         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1171         Call rerender.
1172         (tui_source_window_base::set_new_height): Remove.
1173         (tui_source_window_base::rerender): Rename from
1174         do_make_visible_with_new_height.
1175         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1176         resize method.
1177         (tui_win_info::make_invisible_and_set_new_height)
1178         (tui_win_info::make_visible_with_new_height): Remove.
1179         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1180         Declare.
1181         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1182         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1183         do_make_visible_with_new_height>: Don't declare.
1184         <rerender>: Declare.
1185         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1186         set_new_height.
1187         (tui_data_window::do_make_visible_with_new_height): Remove.
1188         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1189         call tui_show_locator_content.
1190         (tui_gen_win_info::resize): Call rerender.
1191         (show_source_or_disasm_and_command): Don't call
1192         tui_show_locator_content.
1193         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1194         method.
1195         (struct tui_win_info) <rerender>: Declare.
1196         <set_new_height, make_invisible_and_set_new_height,
1197         make_visible_with_new_height>: Don't declare.
1198         * tui/tui-data.c (tui_win_list::rerender): New method.
1199         * tui/tui-command.h (struct tui_cmd_window)
1200         <do_make_visible_with_new_height>: Don't declare.
1201         * tui/tui-command.c
1202         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1203
1204 2019-08-15  Tom Tromey  <tromey@adacore.com>
1205
1206         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1207         * ada-lang.c (ada_enum_name): Likewise.
1208
1209 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1210
1211         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1212         leading underscore.
1213         (GdbOutputErrorFile): Likewise.
1214         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1215         accordingly.
1216         (execute_unwinders): Rename to have a leading underscore.
1217         (auto_load_packages): Likewise.
1218         (global scope): Adjust call to auto_load_packages accordingly.
1219         (GdbSetPythonDirectory): Likewise.
1220         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1221         instead of execute_unwinders.
1222
1223 2019-08-15  Tom Tromey  <tom@tromey.com>
1224
1225         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1226         (show_data): Don't change window visibility.
1227         (tui_gen_win_info::resize): Remove special case for command
1228         window.  Use wresize, when available.
1229         (show_source_or_disasm_and_command): Don't change window
1230         visibility.
1231         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1232         <make_visible>: New method.
1233         * tui/tui-command.c (tui_cmd_window::resize): New method.
1234
1235 2019-08-15  Tom Tromey  <tom@tromey.com>
1236
1237         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1238         (struct tui_source_windows): New.
1239         * tui/tui-winsource.c (tui_display_main): Update.
1240         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1241         (new_height_ok, parse_scrolling_args): Update.
1242         * tui/tui-layout.c (show_layout, show_data): Update.
1243         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1244         (tui_add_to_source_windows): Don't declare.
1245         * tui/tui-data.c (source_windows, tui_source_windows)
1246         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1247
1248 2019-08-15  Tom Tromey  <tom@tromey.com>
1249
1250         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1251         Rename from reset.
1252         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1253         * tui/tui-layout.c (show_source_disasm_command, show_data):
1254         Update.
1255         (tui_gen_win_info::resize): Rename.
1256         (show_source_or_disasm_and_command): Update.
1257         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1258         reset.
1259
1260 2019-08-15  Tom Tromey  <tom@tromey.com>
1261
1262         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1263         * tui/tui-interp.c (tui_interp::init): Don't call
1264         tui_initialize_static_data.
1265         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1266
1267 2019-08-15  Tom Tromey  <tom@tromey.com>
1268
1269         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1270         examine tui_win_list.
1271
1272 2019-08-15  Tom Tromey  <tom@tromey.com>
1273
1274         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1275         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1276         tui_clear_source_content.
1277         (tui_clear_source_content): Remove.
1278         (tui_source_window_base::do_erase_source_content): Hoist call to
1279         content.clear().
1280         * tui/tui-stack.c (tui_show_frame_info): Don't call
1281         tui_clear_source_content.
1282
1283 2019-08-15  Tom Tromey  <tom@tromey.com>
1284
1285         * tui/tui-winsource.h (struct tui_source_window_base)
1286         <do_erase_source_content>: New method.
1287         <erase_source_content>: New method.
1288         (tui_erase_source_content): Don't declare.
1289         * tui/tui-winsource.c (tui_clear_source_content): Update.
1290         (tui_source_window_base::do_erase_source_content): Rename from
1291         tui_erase_source_content.
1292         (tui_source_window_base::show_source_content): Update.
1293         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1294         * tui/tui-source.h (struct tui_source_window)
1295         <erase_source_content>: New method.
1296         * tui/tui-disasm.h (struct tui_disasm_window)
1297         <erase_source_content>: New method.
1298
1299 2019-08-15  Tom Tromey  <tom@tromey.com>
1300
1301         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1302         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1303         constructor.
1304         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1305         * tui/tui-source.c (tui_set_source_content): Update.
1306         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1307
1308 2019-08-15  Tom Tromey  <tom@tromey.com>
1309
1310         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1311         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1312         tui-source.c.
1313         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1314         Declare.
1315         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1316         method.
1317         (tui_source_window::maybe_update): Update.
1318
1319 2019-08-15  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1322         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1323         tui-disasm.c.
1324         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1325         Declare.
1326         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1327         method.
1328         (tui_disasm_window::maybe_update): Update.
1329
1330 2019-08-15  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-winsource.h (struct tui_source_window_base)
1333         <maybe_update>: Declare.
1334         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1335         method.
1336         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1337         Declare.
1338         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1339         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1340         Declare.
1341         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1342
1343 2019-08-15  Tom Tromey  <tom@tromey.com>
1344
1345         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1346
1347 2019-08-15  Tom Tromey  <tom@tromey.com>
1348
1349         * tui/tui-wingeneral.c: Include tui-stack.h.
1350         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1351         (struct tui_locator_window): Move from tui-data.h.
1352         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1353         (tui_initialize_static_data): Move from tui-data.c.
1354         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1355         (struct tui_locator_window): Move to tui-stack.c.
1356         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1357         (tui_initialize_static_data): Move to tui-stack.c.
1358
1359 2019-08-15  Tom Tromey  <tom@tromey.com>
1360
1361         * tui/tui-layout.c (show_source_disasm_command)
1362         (show_source_or_disasm_and_command): Use make_visible method, not
1363         tui_make_window.
1364         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1365         Remove.
1366
1367 2019-08-15  Tom Tromey  <tom@tromey.com>
1368
1369         * tui/tui-wingeneral.h (tui_make_window): Update.
1370         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1371         parameter.
1372         (tui_gen_win_info::make_visible): Update.
1373         * tui/tui-regs.c (tui_data_window::display_registers_from):
1374         Update.
1375         * tui/tui-layout.c (show_source_disasm_command)
1376         (show_source_or_disasm_and_command): Update.
1377         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1378         (enum tui_box): Remove.
1379         (struct tui_win_info) <can_box>: New method.
1380         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1381         method.
1382
1383 2019-08-15  Tom de Vries  <tdevries@suse.de>
1384
1385         * linux-nat-trad.c: Include gdbarch.h.
1386
1387 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1388
1389         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1390         register sizes.
1391
1392 2019-08-14  Tom Tromey  <tromey@adacore.com>
1393
1394         * darwin-nat.c: Include gdbarch.h.
1395         * darwin-nat-info.c: Include gdbarch.h.
1396
1397 2019-08-13  Tom Tromey  <tom@tromey.com>
1398
1399         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1400         Remove.
1401         * tui/tui-data.c (tui_initialize_static_data): Update.
1402
1403 2019-08-13  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-winsource.h (struct tui_exec_info_window)
1406         <~tui_exec_info_window, maybe_allocate_content, get_content,
1407         m_content>: Remove.
1408         (struct tui_source_window_base) <set_exec_info_content,
1409         show_exec_info_content>: Don't declare.
1410         * tui/tui-winsource.c
1411         (tui_exec_info_window::maybe_allocate_content): Remove.
1412         (tui_source_window_base::update_exec_info): Rename from
1413         set_exec_info_content.
1414         (tui_source_window_base::show_exec_info_content)
1415         (tui_source_window_base::update_exec_info): Remove.
1416
1417 2019-08-13  Tom Tromey  <tom@tromey.com>
1418
1419         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1420         declare.
1421         * tui/tui-winsource.c (tui_update_source_window_as_is)
1422         (tui_update_source_windows_with_addr, tui_erase_source_content):
1423         Update.
1424         (tui_clear_exec_info_content): Remove.
1425
1426 2019-08-13  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1429         declare.
1430         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1431         call tui_erase_exec_info_content.
1432         (tui_clear_exec_info_content): Rename from
1433         tui_erase_exec_info_content.
1434         (tui_clear_exec_info_content): Delete.
1435
1436 2019-08-13  Tom Tromey  <tom@tromey.com>
1437
1438         * tui/tui-winsource.h (struct tui_source_window_base)
1439         <show_exec_info_content>: Declare.
1440         (tui_show_exec_info_content): Don't declare.
1441         * tui/tui-winsource.c
1442         (tui_source_window_base::show_exec_info_content): Rename from
1443         tui_show_exec_info_content.
1444         (tui_source_window_base::update_exec_info): Update.
1445
1446 2019-08-13  Tom Tromey  <tom@tromey.com>
1447
1448         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1449         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1450         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1451         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1452         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1453         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1454         ... here.
1455
1456 2019-08-13  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-winsource.h (struct tui_source_window_base)
1459         <update_exec_info>: Declare.
1460         (tui_update_exec_info): Don't declare.
1461         * tui/tui-winsource.c (tui_update_source_window_as_is)
1462         (tui_source_window_base::refresh_all)
1463         (tui_update_all_breakpoint_info): Update.
1464         (tui_source_window_base::update_exec_info): Rename from
1465         tui_update_exec_info.
1466         * tui/tui-stack.c (tui_show_frame_info): Update.
1467
1468 2019-08-13  Tom Tromey  <tom@tromey.com>
1469
1470         * tui/tui-winsource.h (struct tui_source_window_base)
1471         <set_exec_info_content>: Declare.
1472         (tui_set_exec_info_content): Don't declare.
1473         * tui/tui-winsource.c
1474         (tui_source_window_base::set_exec_info_content): Rename from
1475         tui_set_exec_info_content.
1476         (tui_update_exec_info): Update.
1477
1478 2019-08-13  Tom Tromey  <tom@tromey.com>
1479
1480         * tui/tui-winsource.h (struct tui_source_window_base)
1481         <show_source_content>: Declare.
1482         (tui_show_source_content): Don't declare.
1483         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1484         (tui_source_window_base::show_source_content): Rename from
1485         tui_show_source_content.
1486         (tui_source_window_base::refresh_all): Update.
1487         * tui/tui-layout.c (show_source_disasm_command)
1488         (show_source_or_disasm_and_command): Update.
1489
1490 2019-08-13  Tom Tromey  <tom@tromey.com>
1491
1492         * tui/tui-winsource.c (tui_erase_source_content)
1493         (tui_show_source_content, tui_source_window_base::refresh_all):
1494         Update.
1495         * tui/tui-wingeneral.h
1496         (tui_check_and_display_highlight_if_needed): Don't declare.
1497         * tui/tui-wingeneral.c
1498         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1499         check_and_display_highlight_if_needed.
1500         * tui/tui-win.c (tui_rehighlight_all)
1501         (tui_win_info::make_visible_with_new_height): Update.
1502         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1503         (tui_data_window::erase_data_content)
1504         (tui_data_window::display_all_data): Update.
1505         * tui/tui-data.h (struct tui_win_info)
1506         <check_and_display_highlight_if_needed>: Declare.
1507
1508 2019-08-13  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-win.c (tui_resize_all): Call
1511         tui_delete_invisible_windows.
1512         * tui/tui-layout.c (show_layout): Call
1513         tui_delete_invisible_windows.
1514         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1515         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1516
1517 2019-08-13  Tom Tromey  <tom@tromey.com>
1518
1519         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1520         tui_add_win_to_layout.
1521
1522 2019-08-13  Tom Tromey  <tom@tromey.com>
1523
1524         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1525         * tui/tui-layout.c (tui_default_win_height): Now static.
1526
1527 2019-08-13  Tom Tromey  <tom@tromey.com>
1528
1529         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1530         single switch.
1531         (show_source_disasm_command, show_source_or_disasm_and_command):
1532         Don't check current layout.
1533
1534 2019-08-13  Tom Tromey  <tom@tromey.com>
1535
1536         * tui/tui-wingeneral.c (make_all_visible): Remove.
1537         (tui_make_all_invisible): Simplify.
1538         * tui/tui-layout.c (tui_make_all_invisible): Move from
1539         tui-wingeneral.c; simplify.
1540         (show_layout): Hoist call to tui_make_all_invisible.
1541         (show_data): Don't call tui_make_all_invisible.
1542
1543 2019-08-13  Tom Tromey  <tom@tromey.com>
1544
1545         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1546         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1547
1548 2019-08-13  Tom Tromey  <tom@tromey.com>
1549
1550         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1551         tui-data.c.
1552         (show_source_disasm_command, show_data)
1553         (show_source_or_disasm_and_command): Don't use
1554         tui_set_current_layout_to.
1555         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1556         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1557         tui-layout.c.
1558         (tui_set_current_layout_to): Remove.
1559
1560 2019-08-13  Tom Tromey  <tom@tromey.com>
1561
1562         * tui/tui-layout.c (tui_set_layout): Update.
1563         * tui/tui-data.h (struct tui_layout_def): Remove.
1564         (tui_layout_def): Don't declare.
1565         * tui/tui-data.c (layout_def): Remove.
1566         (tui_layout_def): Remove.
1567
1568 2019-08-13  Tom Tromey  <tom@tromey.com>
1569
1570         * tui/tui-winsource.h (struct tui_source_window_base)
1571         <clear_detail>: No longer "override".
1572         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1573         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1574         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1575         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1576         Remove.
1577         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1578
1579 2019-08-13  Tom Tromey  <tromey@adacore.com>
1580
1581         * tracepoint.c: Don't include readline.h or history.h.
1582
1583 2019-08-12  Tom Tromey  <tom@tromey.com>
1584
1585         * configure: Rebuild.
1586         * configure.ac: Check for readline 7.
1587         * NEWS: Mention readline 7 requirement.
1588         * README: Update.
1589
1590 2019-08-12  Tom Tromey  <tom@tromey.com>
1591
1592         * mingw-hdep.c (gdb_select): Remove readline hack.
1593
1594 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1595
1596         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1597         when the function fails.
1598
1599 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1600
1601         * s390-tdep.c (s390_type_align): New function.
1602         (s390_gdbarch_init): Set it as type_align gdbarch method.
1603
1604 2019-08-09  Tom de Vries  <tdevries@suse.de>
1605
1606         PR gdb/24591
1607         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1608         pc_low with relocation offset.
1609
1610 2019-08-07  Tom Tromey  <tromey@adacore.com>
1611
1612         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1613         (print_frame_args): Update.
1614         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1615         Update.
1616         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1617         * frame.h (struct frame_arg): Add initializers.
1618         <error>: Now a unique_xmalloc_ptr.
1619
1620 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1621
1622         * NEWS: Expand the Pointer Authentication entry.
1623         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1624         (aarch64_frame_unmask_lr): ... to this.
1625         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1626         Call aarch64_frame_unmask_lr.
1627         * frame.c (struct frame_info): Add "masked" variable.
1628         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1629         (fprint_frame): Check for masked pc.
1630         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1631         declarations.
1632         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1633         * stack.c (print_frame): Check for masked pc.
1634
1635 2019-08-06  Tom Tromey  <tom@tromey.com>
1636
1637         * stabsread.c (patch_block_stabs, read_one_struct_field)
1638         (read_enum_type): Use obstack_strndup.
1639         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1640         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1641         * dwarf2read.c (guess_full_die_structure_name)
1642         (anonymous_struct_prefix): Use obstack_strndup.
1643         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1644         * c-exp.y (yylex): Use obstack_strndup.
1645         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1646         (write_var_or_type): Use obstack_strndup.
1647
1648 2019-08-06  Tom Tromey  <tom@tromey.com>
1649
1650         * symfile.c (reread_symbols): Use obstack_strdup.
1651         * stabsread.c (read_type): Use obstack_strdup.
1652         * gdb_obstack.h (obstack_strdup): New overload.
1653         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1654         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1655         (dwarf2_canonicalize_name): Use obstack_strdup.
1656         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1657         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1658         Use obstack_strdup.
1659
1660 2019-08-06  Tom Tromey  <tom@tromey.com>
1661
1662         * gdb_obstack.h (obstack_strdup): Define.
1663         * gdb_obstack.c (obstack_strdup): Don't define.
1664
1665 2019-08-06  Tom Tromey  <tom@tromey.com>
1666
1667         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1668         obstack_strdup.
1669         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1670         obstack_strdup.
1671         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1672         * stabsread.c (common_block_start): Use obstack_strdup.
1673         * objfiles.c (set_objfile_main_name, objfile): Use
1674         obstack_strdup.
1675         * namespace.c (add_using_directive): Use obstack_strdup.
1676         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1677         * jit.c (finalize_symtab): Use obstack_strdup.
1678         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1679         (guess_partial_die_structure_name, partial_die_info::fixup)
1680         (dwarf2_name): Use obstack_strdup.
1681         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1682         obstack_strdup.
1683         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1684         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1685         obstack_strdup.
1686         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1687
1688 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1689
1690         * unittests/help-doc-selftests.c: New file.
1691         * Makefile.in: Add the new file.
1692
1693 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1694
1695         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1696         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1697         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1698         the trailing '.' is not output, and the first character is uppercased.
1699         (print_help_for_command): Update call to print_doc_line.
1700         (print_doc_of_command): Likewise.
1701         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1702         * cli/cli-option.c (append_indented_doc): Do not append newline.
1703         (build_help_option): Append newline after first appended_indented_doc
1704         only if a second call is done.
1705         (build_help): Append 2 new lines before each option, except the first
1706         one.
1707         * compile/compile.c (_initialize_compile): Add new lines after
1708         %OPTIONS%, when not at the end of the help.
1709         Change help doc or code
1710         producing the help doc to respect the invariants.
1711         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1712         Also removed the new line after 'Options:', as all other commands
1713         do not put an empty line between 'Options:' and the first option.
1714         * printcmd.c (_initialize_printcmd): Likewise.
1715         * stack.c (_initialize_stack): Likewise.
1716         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1717         incorrectly telling COMMAND is optional.
1718         * ada-lang.c (_initialize_ada_language): Change help doc or code
1719         producing the help doc to respect the invariants.
1720         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1721         * breakpoint.c (_initialize_breakpoint): Likewise.
1722         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1723         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1724         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1725         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1726         _initialize_cli_style): Likewise.
1727         * corelow.c (core_target_info): Likewise.
1728         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1729         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1730         * filesystem.c (_initialize_filesystem): Likewise.
1731         * frame.c (_initialize_frame): Likewise.
1732         * gnu-nat.c (add_task_commands): Likewise.
1733         * infcall.c (_initialize_infcall): Likewise.
1734         * infcmd.c (_initialize_infcmd): Likewise.
1735         * interps.c (_initialize_interpreter): Likewise.
1736         * language.c (_initialize_language): Likewise.
1737         * linux-fork.c (_initialize_linux_fork): Likewise.
1738         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1739         * maint.c (_initialize_maint_cmds): Likewise.
1740         * memattr.c (_initialize_mem): Likewise.
1741         * printcmd.c (_initialize_printcmd): Likewise.
1742         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1743         _RegEx): Likewise.
1744         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1745         * record-btrace.c (_initialize_record_btrace): Likewise.
1746         * record-full.c (_initialize_record_full): Likewise.
1747         * record.c (_initialize_record): Likewise.
1748         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1749         * regcache.c (_initialize_regcache): Likewise.
1750         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1751         _initialize_remote): Likewise.
1752         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1753         * serial.c (_initialize_serial): Likewise.
1754         * skip.c (_initialize_step_skip): Likewise.
1755         * source.c (_initialize_source): Likewise.
1756         * stack.c (_initialize_stack): Likewise.
1757         * symfile.c (_initialize_symfile): Likewise.
1758         * symtab.c (_initialize_symtab): Likewise.
1759         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1760         * top.c (init_main): Likewise.
1761         * tracefile-tfile.c (tfile_target_info): Likewise.
1762         * tracepoint.c (_initialize_tracepoint): Likewise.
1763         * tui/tui-win.c (_initialize_tui_win): Likewise.
1764         * utils.c (add_internal_problem_command): Likewise.
1765         * valprint.c (value_print_option_defs): Likewise.
1766
1767 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1768
1769         PR build/24886
1770         * configure.ac: Drop enable-libmcheck support.
1771         * configure, config.in: Rebuild.
1772         * libmcheck.m4: Remove.
1773         * acinclude.m4: Don't include it.
1774         * Makefile.in: Don't distribute it.
1775         * top.c (print_gdb_configuration): Don't mention it.
1776
1777 2019-08-06  Tom Tromey  <tom@tromey.com>
1778
1779         * utils.c (set_output_style): Sometimes pass stream to
1780         emit_style_escape.
1781         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1782         * record-btrace.c (btrace_insn_history): Update.
1783         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1784         method.
1785         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1786         Update initializers.
1787         <m_uiout>: New field.
1788         <m_di>: Move lower.
1789         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1790         Remove "uiout" parameter.
1791         (dump_insns): Update.
1792         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1793         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1794
1795 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1796
1797         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1798         (error_in_psymtab_expansion): Likewise.
1799         (lookup_symbol_via_quick_fns): Likewise.
1800         (basic_lookup_transparent_type_quick): Likewise.
1801         (basic_lookup_transparent_type_1): Likewise.
1802
1803 2019-08-06  Tom Tromey  <tromey@adacore.com>
1804
1805         * source.c (last_source_error): Now bool.
1806         (print_source_lines_base): Make "noprint" bool.  Only open
1807         source file when last_source_visited changes.
1808
1809 2019-08-06  Tom Tromey  <tromey@adacore.com>
1810
1811         * annotate.c (annotate_source_line): Use g_source_cache.
1812         * source-cache.c (source_cache::get_plain_source_lines): Change
1813         parameters.  Populate m_offset_cache.
1814         (source_cache::ensure): New method.
1815         (source_cache::get_line_charpos): New method.
1816         (extract_lines): Move lower.  Change parameters.
1817         (source_cache::get_source_lines): Move lower.
1818         * source-cache.h (class source_cache): Update comment.
1819         <get_line_charpos>: New method.
1820         <get_source_lines>: Update comment.
1821         <clear>: Clear m_offset_cache.
1822         <get_plain_source_lines>: Change parameters.
1823         <ensure>: New method
1824         <m_offset_cache>: New member.
1825         * source.c (forget_cached_source_info_for_objfile): Update.
1826         (info_source_command): Use g_source_cache.
1827         (find_source_lines, open_source_file_with_line_charpos): Remove.
1828         (print_source_lines_base, search_command_helper): Use g_source_cache.
1829         * source.h (open_source_file_with_line_charpos): Don't declare.
1830         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1831         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1832         Use g_source_cache.
1833
1834 2019-08-06  Tom Tromey  <tromey@adacore.com>
1835
1836         * source-cache.c (source_cache::get_plain_source_lines):
1837         Remove "first_line" and "last_line" parameters.
1838         (source_cache::get_source_lines): Cache plain text.
1839         * source-cache.h (class source_cache)
1840         <get_plain_source_lines>: Update.
1841
1842 2019-08-06  Tom Tromey  <tromey@adacore.com>
1843
1844         * source-cache.c (extract_lines): No longer a method.
1845         Changed type of parameter.  Include final newline.
1846         (selftests::extract_lines_test): New function.
1847         (_initialize_source_cache): Likewise.
1848         * source-cache.h (class source_cache)
1849         <extract_lines>: Don't declare.
1850
1851 2019-08-06  Tom Tromey  <tromey@adacore.com>
1852
1853         * breakpoint.c (init_breakpoint_sal): Update.
1854         (breakpoint): Update.
1855         * breakpoint.h (struct breakpoint) <filter>: Now a
1856         unique_xmalloc_ptr.
1857
1858 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1859
1860         * NEWS: Mention dictionary access on blocks.
1861         * python/py-block.c (blpy_getitem): New function.
1862         (block_object_as_mapping): New struct.
1863         (block_object_type): Use new struct for tp_as_mapping field.
1864
1865 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1866
1867         * objfiles.h (objfile): Add a comment describing partial symbols.
1868
1869 2019-08-05  Tom Tromey  <tromey@adacore.com>
1870
1871         * compile/compile.c (_initialize_compile): Use _(), not N_().
1872         * thread.c (_initialize_thread): Use _(), not N_().
1873         * stack.c (_initialize_stack): Use _(), not N_().
1874         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1875
1876 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1877
1878         * dwarf2read.c (struct dw2_symtab_iterator):
1879         <want_specific_block>: Remove.
1880         <block_index>: Change type to gdb::optional.
1881         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1882         change type of BLOCK_INDEX parameter to gdb::optional.
1883         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1884         (dw2_lookup_symbol): Don't pass argument for
1885         WANT_SPECIFIC_BLOCK.
1886         (dw2_expand_symtabs_for_function): Don't pass argument for
1887         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1888         (class dw2_debug_names_iterator)
1889         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1890         parameter, change BLOCK_INDEX type to gdb::optional.
1891         <m_want_specific_block>: Remove.
1892         <m_block_index>: Change type to gdb::optional.
1893         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1894         gdb::optional.  Re-write in function of gdb::optional.
1895         (dw2_debug_names_lookup_symbol): Don't pass argument for
1896         WANT_SPECIFIC_BLOCK.
1897         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1898         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1899         BLOCK_INDEX.
1900
1901 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1902
1903         * NEWS: Mention changes to "info sources" command.
1904
1905 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1906
1907         * symtab.c (filename_partial_match_opts): New struct type.
1908         (struct output_source_filename_data): New members
1909         regexp, c_regexp, partial_match.
1910         (output_source_filename): Use new members to decide to print file.
1911         (info_sources_option_defs): New variable.
1912         (make_info_sources_options_def_group, print_info_sources_header,
1913         info_sources_command_completer):
1914         New functions.
1915         (info_sources_command): Read new optional arguments.
1916         (_initialize_symtab): Update info sources help.
1917
1918 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1919
1920         * ada-lang.c (exception_support_info_v0): Renamed from...
1921         (default_exception_support_info): ... this.  Create new
1922         definition for v1.
1923         (ada_has_this_exception_support): Look up catch_handlers_sym.
1924         (ada_exception_support_info_sniffer): Try v0 after default.
1925
1926 2019-08-01  Tom Tromey  <tromey@adacore.com>
1927
1928         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1929         gdbarch.h.
1930
1931 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1932
1933         * s12z-tdep.c: Fix include path for s12z-opc.h.
1934
1935 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1936
1937         * NEWS: Require GNU make 3.82.
1938
1939 2019-07-16  Tom Tromey  <tom@tromey.com>
1940
1941         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1942         declare.
1943
1944 2019-07-30  Tom Tromey  <tromey@adacore.com>
1945
1946         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1947
1948 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1949
1950         * printcmd.c (print_address_symbolic): Print negative offsets.
1951         (build_address_symbolic): Force signed arithmetic when computing
1952         offset.
1953
1954 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1955
1956         PR/24474: Add a function to lookup static variables.
1957         * NEWS: Mention this new function.
1958         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1959         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1960         * python/python.c (python_GdbMethods): Add new function.
1961
1962 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1963
1964         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1965         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1966         (objfpy_lookup_static_symbol): New function.
1967         (objfile_object_methods): Add new functions.
1968
1969 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1970
1971         * NEWS: Mention 'set|show print frame-info'.  Mention new
1972         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1973         backtrace argument.  Mention that python frame filtering code
1974         is now consistent with what 'backtrace' command prints.
1975
1976 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1977
1978         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1979         comments.
1980         (print_frame_info_auto, print_frame_info_source_line,
1981         print_frame_info_location, print_frame_info_source_and_location,
1982         print_frame_info_location_and_address, print_frame_info_short_location):
1983         New declarations.
1984         (struct frame_print_options): New member print_frame_info.
1985         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1986         * stack.h (get_user_print_what_frame_info): New declaration.
1987         (frame_show_address): New declaration.
1988         * stack.c (print_frame_arguments_choices): New value 'presence'.
1989         (print_frame_info_auto, print_frame_info_source_line,
1990         print_frame_info_location, print_frame_info_source_and_location,
1991         print_frame_info_location_and_address, print_frame_info_short_location,
1992         print_frame_info_choices, print_frame_info_print_what): New definitions.
1993         (print_frame_args): Only print dots for args if print frame-arguments
1994         is 'presence'.
1995         (frame_print_option_defs): New element for "frame-info".
1996         (get_user_print_what_frame_info): New function.
1997         (frame_show_address): Make non static.  Move comment to stack.h.
1998         (print_frame_info_to_print_what): New function.
1999         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2000         to decide what to print.
2001         (backtrace_command_1): Handle the new print_frame_arguments_presence
2002         value.
2003         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2004         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2005         (py_print_frame): In non-mi mode, use LOCATION as default for
2006         print_what, similarly to frame information printed directly by
2007         backtrace command. Handle frame-info user option in non MI mode.
2008
2009 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2010
2011         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2012         Add case for debugging 32-bit target on 64-bit host.  Revise
2013         comment.
2014
2015 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2016
2017         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2018         instead of find_function_entry_range_from_pc.
2019
2020 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2021
2022         * stack.c (find_frame_funname): Remove code which preferred
2023         minsym over symtab sym in "certain pathological cases".
2024
2025         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2026         parameter.  Change type of "do_demangle" to bool.
2027         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2028         Pass suitable "prefer_sym_over_minsym" flag to
2029         build_address_symbolic().  Don't output "+" for negative offsets.
2030         * printcmd.c (print_address_symbolic): Update invocation of
2031         build_address_symbolic to include a "prefer_sym_over_minsym"
2032         flag.
2033         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2034         Restrict cases in which use of minimal symbol is preferred to that
2035         of a found symbol.  Update comments.
2036
2037         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2038         for entry pc when entry pc is out of range for that FDE.
2039
2040 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2041
2042         PR gdb/24839:
2043         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2044         type.
2045
2046 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2047
2048         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2049         this function's Python signature.
2050
2051
2052 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2053
2054         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2055         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2056         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2057         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2058         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2059
2060
2061 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2062
2063         * h8300-tdep.c (h8300_register_name_common): New.
2064         h8300_register_name): Use h8300_register_name_common.
2065         (h8300s_register_name): Likewise.
2066         (h8300sx_register_name): Likewise.
2067         (h8300h_register_nam): New.
2068         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2069
2070
2071 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2072
2073         * arm-tdep.c (arm_skip_cmse_entry): New function.
2074         (arm_is_sgstubs_section): New function.
2075         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2076
2077 2019-07-22  Tom Tromey  <tom@tromey.com>
2078
2079         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2080         Don't self-assign.
2081
2082 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2083
2084         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2085         type_print.
2086
2087 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2088
2089         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2090         so that GDB doesn't match any msymbols when searching in the
2091         TYPES_DOMAIN.
2092         (print_symbol_info): Print using typedef_print or type_print based
2093         on the type of the symbol.  Add updated FIXME comment moved from...
2094         (_initialize_symtab): ... move and update FIXME comment to above.
2095
2096 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2097
2098         * NEWS: Mention adding -q option to "info types".
2099         * symtab.c (struct info_types_options): New struct.
2100         (info_types_options_defs): New variable.
2101         (make_info_types_options_def_group): New function.
2102         (info_types_command): Use gdb::option framework to parse options.
2103         (info_types_command_completer): New function.
2104         (_initialize_symtab): Extend the help text on "info types" and
2105         register command completer.
2106
2107 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2108
2109         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2110         (lookup_symbol_in_objfile): Change int to block_enum and add a
2111         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2112
2113 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2114
2115         * MAINTAINERS (Write After Approval): Add self.
2116
2117 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2118
2119         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2120         instruction to the dummy code region.
2121
2122 2019-07-19  Tom Tromey  <tromey@adacore.com>
2123
2124         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2125         (ARGSUSED, PARAMS, __func__): Remove rules.
2126
2127 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2128
2129         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2130         * features/arm/arm-with-iwmmxt.c: Remove.
2131         * features/arm/arm-with-iwmmxt.xml: Remove.
2132         * features/arm/arm-with-m-fpa-layout.c: Remove.
2133         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2134         * features/arm/arm-with-m-vfp-d16.c: Remove.
2135         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2136         * features/arm/arm-with-m.c: Remove.
2137         * features/arm/arm-with-m.xml: Remove.
2138         * features/arm/arm-with-neon.c: Remove.
2139         * features/arm/arm-with-neon.xml: Remove.
2140         * features/arm/arm-with-vfpv2.c: Remove.
2141         * features/arm/arm-with-vfpv2.xml: Remove.
2142         * features/arm/arm-with-vfpv3.c: Remove.
2143         * features/arm/arm-with-vfpv3.xml: Remove.
2144
2145 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2146
2147         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2148
2149 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2150
2151         * arch/aarch32.c (aarch32_create_target_description): Create
2152         target descriptions using features.
2153         * arch/arm.c (arm_create_target_description)
2154         (arm_create_mprofile_target_description): Likewise.
2155         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2156
2157 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2158
2159         * Makefile.in: Add new files.
2160         * aarch32-tdep.c: New file.
2161         * aarch32-tdep.h: New file.
2162         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2163         Call aarch32_read_description.
2164         * arch/aarch32.c: New file.
2165         * arch/aarch32.h: New file.
2166         * arch/arm.c (arm_create_target_description)
2167         (arm_create_mprofile_target_description): New function.
2168         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2169         (arm_create_target_description)
2170         (arm_create_mprofile_target_description): New declaration.
2171         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2172         read_description functions.
2173         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2174         Likewise.
2175         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2176         * arm-tdep.c (tdesc_arm_list): New variable.
2177         (arm_register_g_packet_guesses): Call create description functions.
2178         (arm_read_description) (arm_read_mprofile_description): New
2179         function.
2180         * arm-tdep.h (arm_read_description)
2181         (arm_read_mprofile_description): Add declaration.
2182         * configure.tgt: Add new files.
2183
2184 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2185
2186         * top.c (new_ui_command): Open specified terminal just once.
2187
2188 2019-07-18  Tom Tromey  <tromey@adacore.com>
2189
2190         * symtab.c (main_name): Constify return type.
2191         * symfile.c (set_initial_language): Update.
2192         * symtab.h (main_name): Constify return type.
2193
2194 2019-07-17  Tom Tromey  <tom@tromey.com>
2195
2196         * tui/tui-winsource.c (tui_update_source_window)
2197         (tui_update_source_window_as_is)
2198         (tui_update_source_windows_with_line): Remove return.
2199         * tui/tui-disasm.c (tui_show_disassem)
2200         (tui_show_disassem_and_update_source): Remove return.
2201         * tui/tui.c (tui_reset): Remove return.
2202         * tui/tui-wingeneral.c
2203         (tui_check_and_display_highlight_if_needed): Remove return.
2204
2205 2019-07-17  Tom Tromey  <tom@tromey.com>
2206
2207         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2208
2209 2019-07-17  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-winsource.h (struct tui_exec_info_window)
2212         (struct tui_source_window_base): Move from tui-data.h.
2213         * tui/tui-winsource.c: Move many method definitions from
2214         elsewhere.  Remove "structuring" comments.
2215         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2216         (tui_source_window_base::refresh_window): Move to
2217         tui-winsource.c.
2218         * tui/tui-win.c (tui_source_window_base::refresh_all)
2219         (tui_source_window_base::update_tab_width)
2220         (tui_source_window_base::set_new_height)
2221         (tui_source_window_base::do_make_visible_with_new_height): Move to
2222         tui-winsource.c.
2223         * tui/tui-source.h: Update.
2224         * tui/tui-source.c (tui_source_window_base::reset): Move to
2225         tui-winsource.c.
2226         * tui/tui-disasm.h: Update.
2227         * tui/tui-data.h (struct tui_exec_info_window): Move to
2228         tui-winsource.h.
2229         (struct tui_source_window_base): Likewise.
2230         * tui/tui-data.c (tui_source_window_base::clear_detail)
2231         (tui_source_window_base, ~tui_source_window_base): Move to
2232         tui-winsource.c.
2233
2234 2019-07-17  Tom Tromey  <tom@tromey.com>
2235
2236         * tui/tui-win.c (tui_resize_all)
2237         (tui_source_window_base::update_tab_width)
2238         (tui_adjust_win_heights): Update.
2239         (tui_win_info::make_invisible_and_set_new_height): Rename from
2240         make_invisible_and_set_new_height.
2241         * tui/tui-data.h (struct tui_win_info)
2242         <make_invisible_and_set_new_height>: New method.
2243
2244 2019-07-17  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui.c: Update.
2247         * tui/tui-source.h (struct tui_source_window): Move from
2248         tui-data.h.
2249         * tui/tui-layout.c: Update.
2250         * tui/tui-disasm.c: Update.
2251         * tui/tui-data.h (struct tui_source_window): Move to
2252         tui-source.h.
2253
2254 2019-07-17  Tom Tromey  <tom@tromey.com>
2255
2256         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2257         tui-data.h.
2258         * tui/tui-data.h (struct tui_disasm_window): Move to
2259         tui-disasm.h.
2260
2261 2019-07-17  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-regs.h (struct tui_data_item_window): Move from
2264         tui-data.h.
2265         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2266         * tui/tui-data.h (struct tui_data_item_window): Move to
2267         tui-regs.h.
2268         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2269
2270 2019-07-17  Tom Tromey  <tom@tromey.com>
2271
2272         * tui/tui.c: Update.
2273         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2274         (tui_cmd_window::max_height): Move to tui-command.c.
2275         * tui/tui-layout.c: Update.
2276         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2277         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2278         tui-command.c.
2279         * tui/tui-command.h (struct tui_cmd_window): Move from
2280         tui-data.h.
2281         * tui/tui-command.c: Remove "structuring" comments.
2282         (tui_cmd_window::clear_detail)
2283         (tui_cmd_window::do_make_visible_with_new_height)
2284         (tui_cmd_window::max_height): Move from elsewhere.
2285
2286 2019-07-17  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2289         Now static.
2290         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2291         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2292
2293 2019-07-17  Tom Tromey  <tom@tromey.com>
2294
2295         * tui/tui.c: Update.
2296         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2297         tui-regs.c.
2298         * tui/tui-windata.h: Remove file.
2299         * tui/tui-windata.c: Remove file.
2300         * tui/tui-win.c (tui_data_window::set_new_height)
2301         (tui_data_window::do_make_visible_with_new_height): Move to
2302         tui-regs.c.
2303         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2304         * tui/tui-regs.c: Remove "structuring" comments.
2305         (tui_data_window::first_data_item_displayed)
2306         (tui_data_window::delete_data_content_windows)
2307         (tui_data_window::erase_data_content)
2308         (tui_data_window::display_all_data)
2309         (tui_data_window::refresh_all)
2310         (tui_data_window::do_scroll_vertical)
2311         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2312         (tui_data_window::do_make_visible_with_new_height)
2313         (tui_data_window::refresh_window): Move from elsewhere.
2314         (_initialize_tui_regs): Move to end of file.
2315         * tui/tui-layout.c: Update.
2316         * tui/tui-hooks.c: Update.
2317         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2318         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2319         tui-regs.c.
2320         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2321
2322 2019-07-17  Tom Tromey  <tom@tromey.com>
2323
2324         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2325         seen.
2326
2327 2019-07-17  Tom Tromey  <tom@tromey.com>
2328
2329         * tui/tui-win.c (tui_source_window_base::set_new_height)
2330         (tui_source_window_base::do_make_visible_with_new_height): Use
2331         m_has_locator field directly.
2332         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2333         method.
2334         (struct tui_source_window_base) <has_locator>: Likewise.
2335
2336 2019-07-17  Tom Tromey  <tom@tromey.com>
2337
2338         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2339         Don't declare.
2340         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2341         Remove.
2342         * tui/tui-win.c (tui_source_window_base::set_new_height)
2343         (tui_source_window_base::set_new_height)
2344         (make_invisible_and_set_new_height)
2345         (tui_source_window_base::do_make_visible_with_new_height)
2346         (tui_source_window_base::do_make_visible_with_new_height):
2347         Update.
2348         * tui/tui-layout.c (show_source_disasm_command, show_data)
2349         (show_source_or_disasm_and_command): Update.
2350         * tui/tui-layout.c (show_layout): Update.
2351
2352 2019-07-17  Tom Tromey  <tom@tromey.com>
2353
2354         * tui/tui-layout.c (make_data_window): Remove.
2355         (show_data): Unify creation and re-initialization cases.
2356
2357 2019-07-17  Tom Tromey  <tom@tromey.com>
2358
2359         * tui/tui-layout.c (make_source_window, make_disasm_window):
2360         Remove.
2361         (show_data): Unify creation and re-initialization cases.
2362
2363 2019-07-17  Tom Tromey  <tom@tromey.com>
2364
2365         * tui/tui-layout.c (make_command_window): Remove.
2366         (show_source_disasm_command, show_source_or_disasm_and_command):
2367         Unify creation and re-initialization cases.
2368
2369 2019-07-17  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2372         creation and re-initialization cases.
2373
2374 2019-07-17  Tom Tromey  <tom@tromey.com>
2375
2376         * tui/tui-regs.c (tui_get_register): Return void.
2377
2378 2019-07-17  Tom Tromey  <tom@tromey.com>
2379
2380         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2381         Simplify.
2382
2383 2019-07-17  Tom Tromey  <tom@tromey.com>
2384
2385         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2386         resetting.
2387
2388 2019-07-17  Tom Tromey  <tom@tromey.com>
2389
2390         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2391         * tui/tui-regs.c (tui_reg_layout): New function.
2392         (tui_show_registers, tui_reg_command): Use it.
2393         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2394         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2395         parameters.
2396         (tui_layout_command): Remove.
2397
2398 2019-07-17  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-layout.h (tui/tui-layout): Return void.
2401         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2402
2403 2019-07-17  Tom Tromey  <tom@tromey.com>
2404
2405         * tui/tui-layout.c (show_source_disasm_command, show_data):
2406         Update.
2407         (reset_locator): Remove.
2408         (show_source_or_disasm_and_command): Update.
2409
2410 2019-07-17  Tom Tromey  <tom@tromey.com>
2411
2412         * tui/tui-source.c (tui_source_window_base::reset): Remove
2413         win_type parameter.
2414         * tui/tui-layout.c (make_command_window, make_source_window)
2415         (make_disasm_window, make_data_window)
2416         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2417         (reset_locator, show_source_or_disasm_and_command): Update.
2418         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2419         win_type parameter.
2420         (struct tui_source_window_base) <reset>: Likewise.
2421
2422 2019-07-17  Tom Tromey  <tom@tromey.com>
2423
2424         * tui/tui-layout.c (show_source_disasm_command): Use
2425         reset_locator.
2426         (reset_locator): New function.
2427         (init_and_make_win): Remove.
2428         (show_source_or_disasm_and_command): Use reset_locator.
2429
2430 2019-07-17  Tom Tromey  <tom@tromey.com>
2431
2432         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2433         condition.
2434         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2435         Remove condition.
2436         * tui/tui-source.c (tui_source_window_base::reset): New method.
2437         * tui/tui-layout.c (make_command_window): Don't call
2438         init_and_make_win.
2439         (make_source_window, make_disasm_window): Don't call
2440         make_source_or_disasm_window.
2441         (make_data_window): Don't call init_and_make_win.  Change calling
2442         convention.
2443         (show_source_disasm_command, show_data): Simplify.
2444         (make_source_or_disasm_window): Remove.
2445         (show_source_or_disasm_and_command): Simplify.
2446         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2447         (struct tui_source_window_base) <reset>: Likewise.
2448         <execution_info>: Remove initializer.
2449         * tui/tui-data.c (tui_source_window_base): Initialize
2450         execution_info.
2451
2452 2019-07-17  Tom Tromey  <tom@tromey.com>
2453
2454         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2455         variable.
2456
2457 2019-07-17  Tom Tromey  <tom@tromey.com>
2458
2459         * tui/tui.c (tui_rl_other_window): Update.
2460         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2461         superclass method first.  Always iterate over regs_content.
2462         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2463         method.
2464         * tui/tui-win.c (tui_set_focus_command): Update.
2465
2466 2019-07-17  Tom Tromey  <tom@tromey.com>
2467
2468         * tui/tui-win.c (tui_set_focus_command): Rename from
2469         tui_set_focus.  Call tui_enable.
2470         (tui_set_focus_command): Remove.
2471
2472 2019-07-17  Tom Tromey  <tom@tromey.com>
2473
2474         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2475         refresh_window.
2476         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2477         touchwin.
2478         (tui_data_window::refresh_window): Call refresh_window on data
2479         items.  Always call superclass refresh_window.
2480         (tui_win_info::refresh): Remove.
2481         (tui_source_window_base::refresh_window): Update.
2482         (tui_refresh_all): Update.
2483         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2484         refresh_window.
2485         (show_source_or_disasm_and_command): Likewise.
2486         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2487         (struct tui_source_window_base) <refresh>: Likewise.
2488
2489 2019-07-17  Tom Tromey  <tom@tromey.com>
2490
2491         * tui/tui-winsource.c (tui_clear_source_content)
2492         (tui_show_source_content): Update.
2493         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2494         whether content is empty.
2495         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2496         Remove.
2497
2498 2019-07-17  Tom Tromey  <tom@tromey.com>
2499
2500         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2501         window's contents.
2502         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2503         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2504
2505 2019-07-17  Tom Tromey  <tom@tromey.com>
2506
2507         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2508         (struct tui_data_item_window): Update.
2509
2510 2019-07-17  Tom Tromey  <tom@tromey.com>
2511
2512         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2513         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2514         defines.
2515
2516 2019-07-17  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-winsource.h (tui_erase_source_content)
2519         (tui_clear_source_content): Remove "display_prompt" parameter.
2520         * tui/tui-winsource.c (tui_update_source_window_as_is)
2521         (tui_update_source_windows_with_addr): Update.
2522         (tui_clear_source_content): Remove "display_prompt" parameter.
2523         (tui_erase_source_content): Likewise.  Simplify.
2524         (tui_show_source_content): Update.
2525         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2526         * tui/tui-stack.c (tui_show_frame_info): Update.
2527         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2528         Remove defines.
2529
2530 2019-07-17  Tom Tromey  <tom@tromey.com>
2531
2532         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2533         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2534         parameter.
2535         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2536         parameter.
2537
2538 2019-07-17  Tom Tromey  <tom@tromey.com>
2539
2540         * tui/tui-winsource.c (tui_clear_source_content)
2541         (tui_show_source_content, tui_show_exec_info_content)
2542         (tui_clear_exec_info_content): Update.
2543         * tui/tui-stack.c (tui_show_locator_content): Update.
2544         (tui_show_frame_info): Update.
2545         * tui/tui-source.h (tui_source_window): Don't declare.
2546         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2547         from tui_source_is_displayed.
2548         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2549         Remove field.
2550         (struct tui_source_window_base) <content_in_use>: New field.  Now
2551         bool.
2552         (struct tui_source_window) <showing_source_p>: New method.
2553         (TUI_SRC_WIN): Change cast.
2554         * tui/tui-data.c (tui_initialize_static_data): Update.
2555
2556 2019-07-17  Tom Tromey  <tom@tromey.com>
2557
2558         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2559         location_matches_p.
2560         * tui/tui-source.c (tui_source_window::location_matches_p): New
2561         method.
2562         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2563         method.
2564         * tui/tui-data.h (struct tui_source_window_base)
2565         <location_matches_p>: New method.
2566         (struct tui_source_window, struct tui_disasm_window)
2567         <location_matches_p>: Likewise.
2568
2569 2019-07-17  Tom Tromey  <tom@tromey.com>
2570
2571         * tui/tui-win.c (tui_set_win_height_command): Rename from
2572         tui_set_win_height.
2573         (tui_set_win_height_command): Remove.
2574
2575 2019-07-17  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-source.c (tui_source_window): New constructor.  Add
2578         observer.
2579         (~tui_source_window): New destructor.
2580         (tui_source_window::style_changed): New method.
2581         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2582         (tui_attach_detach_observers): Update.
2583         * tui/tui-data.h (struct tui_source_window): Make constructor not
2584         inline.  Add destructor.
2585         (struct tui_source_window) <style_changed>: New method.
2586         <m_observable>: New member.
2587
2588 2019-07-17  Tom Tromey  <tom@tromey.com>
2589
2590         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2591         * tui/tui-win.c (tui_resize_all): Fix typo.
2592
2593 2019-07-17  Tom Tromey  <tom@tromey.com>
2594
2595         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2596         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2597         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2598         * tui/tui-win.c (window_name_completer): Use foreach.
2599         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2600         (update_tab_width): Likewise.
2601         * tui/tui-layout.c (show_layout): Update.
2602         * tui/tui-data.h (class tui_window_iterator): New.
2603         (struct all_tui_windows): New.
2604         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2605
2606 2019-07-17  Tom Tromey  <tom@tromey.com>
2607
2608         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2609         parameter.  Don't reference globals.
2610         (tui_reg_command): Update.
2611
2612 2019-07-17  Tom Tromey  <tom@tromey.com>
2613
2614         * tui/tui-regs.c (tui_show_registers): Simplify.
2615
2616 2019-07-17  Tom Tromey  <tom@tromey.com>
2617
2618         * tui/tui-regs.c (tui_show_registers): Update.
2619         (tui_show_register_group): Add win_info parameter.
2620
2621 2019-07-17  Tom Tromey  <tom@tromey.com>
2622
2623         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2624         Rename from tui_display_reg_element_at_line.
2625         (tui_data_window::display_registers_from_line): Update.
2626         * tui/tui-data.h (struct tui_data_window)
2627         <display_reg_element_at_line>: New method.
2628
2629 2019-07-17  Tom Tromey  <tom@tromey.com>
2630
2631         * tui/tui-regs.h (tui_display_registers_from)
2632         (tui_display_registers_from_line): Don't declare.
2633         * tui/tui-windata.c (tui_data_window::display_all_data)
2634         (tui_data_window::refresh_all)
2635         (tui_data_window::do_scroll_vertical): Update.
2636         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2637         from tui_display_registers_from.
2638         (tui_display_reg_element_at_line): Update.
2639         (tui_data_window::display_registers_from_line): Rename from
2640         tui_display_registers_from_line.
2641         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2642         display_registers_from_line>: New methods.
2643
2644 2019-07-17  Tom Tromey  <tom@tromey.com>
2645
2646         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2647         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2648         from tui_erase_data_content.
2649         (tui_data_window::display_all_data)
2650         (tui_data_window::refresh_all)
2651         (tui_data_window::do_scroll_vertical): Update.
2652         * tui/tui-regs.c (tui_show_registers): Update.
2653         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2654         New method.
2655
2656 2019-07-17  Tom Tromey  <tom@tromey.com>
2657
2658         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2659         declare.
2660         * tui/tui-windata.c
2661         (tui_data_window::delete_data_content_windows): Rename from
2662         tui_delete_data_content_windows.
2663         (tui_data_window::display_all_data)
2664         (tui_data_window::do_scroll_vertical): Update.
2665         * tui/tui-data.h (struct tui_data_window)
2666         <delete_data_content_windows>: New method.
2667
2668 2019-07-17  Tom Tromey  <tom@tromey.com>
2669
2670         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2671         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2672
2673 2019-07-17  Tom Tromey  <tom@tromey.com>
2674
2675         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2676         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2677         from tui_display_all_data.
2678         * tui/tui-win.c
2679         (tui_data_window::do_make_visible_with_new_height): Update.
2680         * tui/tui-regs.c (tui_show_registers): Update.
2681         * tui/tui-layout.c (tui_set_layout): Update.
2682         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2683         method.
2684
2685 2019-07-17  Tom Tromey  <tom@tromey.com>
2686
2687         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2688         * tui/tui-windata.c (tui_display_data_from): Remove.
2689         (tui_data_window::refresh_all): Update.
2690
2691 2019-07-17  Tom Tromey  <tom@tromey.com>
2692
2693         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2694         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2695         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2696         tui_display_registers_from_line.
2697         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2698         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2699         "force_display" parameter.
2700
2701 2019-07-17  Tom Tromey  <tom@tromey.com>
2702
2703         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2704         declare.
2705         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2706         Rename from tui_first_reg_element_no_inline.
2707         (tui_display_reg_element_at_line)
2708         (tui_display_registers_from_line): Update.
2709         * tui/tui-data.h (struct tui_data_window)
2710         <first_reg_element_no_inline>: New method.
2711
2712 2019-07-17  Tom Tromey  <tom@tromey.com>
2713
2714         * tui/tui-windata.c (tui_display_data_from)
2715         (tui_data_window::do_scroll_vertical): Update.
2716         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2717         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2718         Rename from tui_line_from_reg_element_no.
2719         (tui_display_registers_from_line): Update.
2720         * tui/tui-data.h (struct tui_data_window)
2721         <line_from_reg_element_no>: New method.
2722
2723 2019-07-17  Tom Tromey  <tom@tromey.com>
2724
2725         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2726         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2727         tui_last_regs_line_no.
2728         (tui_display_reg_element_at_line)
2729         (tui_display_registers_from_line): Update.
2730         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2731         method.
2732
2733 2019-07-17  Tom Tromey  <tom@tromey.com>
2734
2735         PR tui/24722:
2736         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2737         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2738         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2739         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2740         (tui_update_breakpoint_info): Likewise.
2741         * tui/tui-hooks.c (tui_event_create_breakpoint)
2742         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2743         Update.
2744
2745 2019-07-17  Tom Tromey  <tom@tromey.com>
2746
2747         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2748
2749 2019-07-17  Tom Tromey  <tom@tromey.com>
2750
2751         * tui/tui-winsource.c (tui_update_source_window_as_is)
2752         (tui_update_source_windows_with_addr): Update.
2753         * tui/tui-source.h (tui_set_source_content)
2754         (tui_show_symtab_source): Add "win_info" parameter.
2755         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2756         parameter.
2757         (tui_show_symtab_source): Likewise.
2758
2759 2019-07-17  Tom Tromey  <tom@tromey.com>
2760
2761         * tui/tui-wingeneral.c
2762         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2763
2764 2019-07-17  Tom Tromey  <tom@tromey.com>
2765
2766         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2767         (struct tui_cmd_window) <can_scroll>: New method.
2768         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2769         method.
2770
2771 2019-07-17  Tom Tromey  <tromey@adacore.com>
2772
2773         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2774         do_field_signed>: Rename.  Change type of "value".
2775         * ui-out.c (ui_out::field_signed): Rename from field_int.
2776         Change type of "value".
2777         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2778         type of "value".
2779         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2780         do_field_int.  Change type of "value".
2781         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2782         do_field_int.  Change type of "value".
2783         * tracepoint.c (trace_status_mi, tfind_1)
2784         (print_one_static_tracepoint_marker): Update.
2785         * thread.c (print_thread_info_1, print_selected_thread_frame):
2786         Update.
2787         * stack.c (print_frame, print_frame_info): Update.
2788         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2789         Update.
2790         * source.c (print_source_lines_base): Update.
2791         * skip.c (info_skip_command): Update.
2792         * record-btrace.c (btrace_ui_out_decode_error)
2793         (btrace_call_history_src_line): Update.
2794         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2795         Update.
2796         * progspace.c (print_program_space): Update.
2797         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2798         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2799         do_field_int.  Change type of "value".
2800         * mi/mi-out.c (mi_ui_out::do_table_begin)
2801         (mi_ui_out::do_table_header): Update.
2802         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2803         type of "value".
2804         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2805         (mi_cmd_data_list_changed_registers, output_register)
2806         (mi_cmd_data_read_memory, mi_load_progress)
2807         (mi_cmd_trace_frame_collected): Update.
2808         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2809         Update.
2810         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2811         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2812         (mi_cmd_var_list_children, varobj_update_one): Update.
2813         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2814         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2815         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2816         * inferior.c (print_inferior): Update.
2817         * gdb_bfd.c (print_one_bfd): Update.
2818         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2819         Update.
2820         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2821         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2822         do_field_int.  Change type of "value".
2823         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2824         do_field_int.  Change type of "value".
2825         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2826         (print_one_breakpoint_location, print_it_catch_fork)
2827         (print_one_catch_fork, print_it_catch_vfork)
2828         (print_one_catch_vfork, print_it_catch_solib)
2829         (print_it_catch_exec, print_it_ranged_breakpoint)
2830         (print_mention_watchpoint, print_mention_masked_watchpoint)
2831         (bkpt_print_it, update_static_tracepoint): Update.
2832         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2833         * break-catch-syscall.c (print_it_catch_syscall): Update.
2834         * ada-tasks.c (print_ada_task_info): Update.
2835         * ada-lang.c (print_it_exception, print_mention_exception):
2836         Update.
2837
2838 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2839
2840         PR breakpoints/24541
2841         * gdbarch.c: Regenerate.
2842         * gdbarch.h: Regenerate.
2843         * gdbarch.sh: Adjust return type and parameter types for
2844         'stap_adjust_register'.
2845         (i386_stap_adjust_register): Adjust signature and return new
2846         register name.
2847         * stap-probe.c (stap_parse_register_operand): Adjust use of
2848         'gdbarch_stap_adjust_register'.
2849
2850 2019-07-17  Tom Tromey  <tromey@adacore.com>
2851
2852         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2853         declare VEC.
2854         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2855         std::vector.
2856         (struct s390_process_info): Add initializers.
2857         (s390_add_process): Use new.
2858         (s390_linux_nat_target::low_forget_process): Use delete.
2859         (s390_linux_nat_target::low_new_fork)
2860         (s390_linux_nat_target::stopped_by_watchpoint)
2861         (s390_linux_nat_target::low_prepare_to_resume)
2862         (s390_linux_nat_target::insert_watchpoint)
2863         (s390_linux_nat_target::insert_hw_breakpoint)
2864         (s390_linux_nat_target::remove_watchpoint)
2865         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2866
2867 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2868
2869         * aarch64-fbsd-nat.c: Include regcache.h.
2870         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2871         argument.
2872         (aarch64_fbsd_nat_target::fetch_registers)
2873         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2874         variable.
2875         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2876
2877 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2878
2879         * fbsd-nat.c: Include gdbarch.h.
2880
2881 2019-07-15  Tom Tromey  <tromey@adacore.com>
2882
2883         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2884
2885 2019-07-15  Tom Tromey  <tromey@adacore.com>
2886
2887         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2888         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2889         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2890         * cli-out.c (cli_ui_out::do_field_int): New method.
2891         * ui-out.c (ui_out::field_unsigned): New method.
2892         * symfile.c (generic_load): Use field_unsigned.
2893         (print_transfer_performance): Likewise.
2894         * record-btrace.c (ui_out_field_uint): Remove.
2895         (btrace_call_history_insn_range, btrace_call_history): Use
2896         field_unsigned.
2897         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2898         field_unsigned.
2899         * ui-out.h (class ui_out) <field_unsigned>: New method.
2900         <do_field_unsigned>: Likewise.
2901
2902 2019-07-15  Tom Tromey  <tromey@adacore.com>
2903
2904         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2905         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2906         * target.c (flash_erase_command): Use field_string.
2907         * infrun.c (print_signal_received_reason): Use field_string.
2908         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2909         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2910         field_string.
2911         * ada-tasks.c (print_ada_task_info): Use field_string.
2912
2913 2019-07-15  Tom Tromey  <tromey@adacore.com>
2914
2915         * target.c (flash_erase_command): Use field_core_addr.
2916         * symfile.c (generic_load): Use field_core_addr.
2917         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2918         Use field_core_addr.
2919         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2920         field_core_addr.
2921
2922 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2923
2924         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2925         value if its desired type is smaller than a CORE_ADDR and signed.
2926
2927 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2928
2929         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2930         of changes to field names, and use new is_reference field to
2931         decide if a property is a reference or not.
2932         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2933         field.
2934         (struct dwarf2_property_baton): Update header comment, rename
2935         'referenced_type' to 'property_type' and update comments.
2936         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2937         default property type, store in property baton, update to take
2938         accound of renamed field.
2939         (read_func_scope): Update call to attr_to_dynamic_prop.
2940         (read_array_type): Likewise.
2941         (dwarf2_per_cu_addr_sized_int_type): New function.
2942         (read_subrange_index_type): Move type finding code to
2943         dwarf2_per_cu_addr_sized_int_type.
2944         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2945         (dwarf2_per_cu_addr_type): New function.
2946         (set_die_type): Update calls to attr_to_dynamic_prop.
2947
2948 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2949
2950         * dwarf2read.c (read_subrange_index_type): New function.
2951         (read_subrange_type): Move code into new function and call it.
2952         * gdbtypes.c (create_range_type): Add some asserts.
2953
2954 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2955
2956         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2957         update return statements.
2958         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2959         declaration, and update comment to match.
2960         * gdbtypes.c (resolve_dynamic_array): Update call to
2961         dwarf2_evaluate_property to match new return type.
2962
2963 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2964
2965         * valarith.c (value_subscripted_rvalue): Change lowerbound
2966         parameter type from int to LONGEST.
2967         * value.h (value_subscripted_rvalue): Likewise in declaration.
2968
2969 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2970
2971         * cli/cli-utils.c (info_print_command_completer): New function.
2972         * cli/cli-utils.h: Add 'completer.h' include, and forward
2973         declaration for 'struct cmd_list_element'.
2974         (info_print_command_completer): Declare.
2975         * stack.c (_initialize_stack): Add completer for 'info locals' and
2976         'info args'.
2977         * symtab.c (_initialize_symtab): Add completer for 'info
2978         variables' and 'info functions'.
2979         * NEWS: Mention completion for additional info commands.
2980
2981 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2982
2983         * cli/cli-utils.c (extract_info_print_args): Delete.
2984         (extract_arg_maybe_quoted): Delete.
2985         (info_print_options_defs): New variable.
2986         (make_info_print_options_def_group): New function.
2987         (extract_info_print_options): Define new function.
2988         * cli/cli-utils.h (extract_info_print_args): Delete.
2989         (struct info_print_options): New structure.
2990         (extract_info_print_options): Declare new function.
2991         * stack.c (info_locals_command): Update to use new
2992         extract_info_print_options, also add a header comment.
2993         (info_args_command): Likewise.
2994         * symtab.c (info_variables_command): Likewise.
2995         (info_functions_command): Likewise.
2996
2997 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2998
2999         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3000         to extract string arguments.
3001         * common/common-utils.c (extract_string_maybe_quoted): New function.
3002         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3003
3004 2019-07-11  Tom Tromey  <tromey@adacore.com>
3005
3006         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3007         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3008         * top.h (gdbinit): Don't declare.
3009         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3010         into...
3011         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3012         * top.c (gdb_init): Don't call init_cli_cmds.
3013         (gdbinit): Remove.
3014         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3015
3016 2019-07-11  Tom Tromey  <tromey@adacore.com>
3017
3018         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3019         after it has been moved.
3020
3021 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3022
3023         * valops.c (value_must_coerce_to_target): Change return type to
3024         bool.
3025         * value.h (value_must_coerce_to_target): Likewise.
3026
3027 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3028
3029         * breakpoint.c (is_hardware_watchpoint): Remove
3030         forward-declaration.
3031         (is_masked_watchpoint): Change return type to bool.
3032         (is_tracepoint): Likewise.
3033         (is_breakpoint): Likewise.
3034         (is_hardware_watchpoint): Likewise.
3035         (is_watchpoint): Likewise.
3036         (is_no_memory_software_watchpoint): Likewise.
3037         (is_catchpoint): Likewise.
3038         (breakpoint_1): Make FILTER parameter's return type bool.
3039         is_masked_watchpoint): Change return type to bool.
3040         (save_breakpoints): Make FILTER parameter's return type bool.
3041         * breakpoint.h (is_breakpoint): Change return type to bool.
3042         (is_watchpoint): Likewise.
3043         (is_catchpoint): Likewise.
3044         (is_tracepoint): Likewise.
3045
3046 2019-07-10  Tom Tromey  <tom@tromey.com>
3047
3048         * defs.h: Don't include gdbarch.h.
3049         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3050         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3051         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3052         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3053         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3054         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3055         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3056         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3057         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3058         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3059         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3060         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3061         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3062         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3063         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3064         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3065         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3066         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3067         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3068         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3069         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3070         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3071         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3072         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3073         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3074         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3075         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3076
3077 2019-07-10  Tom Tromey  <tromey@adacore.com>
3078
3079         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3080         * breakpoint.c (init_ada_exception_breakpoint): Register as
3081         bp_catchpoint.
3082         (print_one_breakpoint_location, print_one_breakpoint): Use
3083         is_ada_exception_catchpoint.
3084         * ada-lang.c (class ada_catchpoint_location): Pass
3085         bp_loc_software_breakpoint to bp_location constructor.
3086         (is_ada_exception_catchpoint): New function.
3087
3088 2019-07-10  Tom Tromey  <tromey@adacore.com>
3089
3090         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3091         VEC.
3092         (struct arm_exidx_entry): New method operator<.
3093         (struct arm_exidx_data) <section_maps>: Change type.
3094         (arm_exidx_data_free): Remove.
3095         (arm_exidx_data_key): Change type.  Move lower.
3096         (arm_exidx_new_objfile): Update.
3097         (arm_compare_exidx_entries): Remove.
3098         (arm_find_exidx_entry, _initialize_arm_tdep)
3099
3100 2019-07-10  Tom Tromey  <tromey@adacore.com>
3101
3102         * solib-spu.c (ocl_program_data_key): Change type.
3103         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3104         Update.
3105
3106 2019-07-10  Tom Tromey  <tromey@adacore.com>
3107
3108         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3109         (struct solib_aix_inferior_data) <library_list>: Change type.
3110         (solib_aix_inferior_data_handle): Change type.
3111         (get_solib_aix_inferior_data): Update.
3112         (solib_aix_free_library_list): Remove.
3113         (library_list_start_library): Update.
3114         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3115         return type.
3116         (solib_aix_get_library_list)
3117         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3118         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3119
3120 2019-07-10  Tom Tromey  <tromey@adacore.com>
3121
3122         * solib-dsbt.c (struct dsbt_info): Add initializers.
3123         (solib_dsbt_pspace_data): Change type.
3124         (dsbt_pspace_data_cleanup): Remove.
3125         (get_dsbt_info, _initialize_dsbt_solib): Update.
3126
3127 2019-07-10  Tom Tromey  <tromey@adacore.com>
3128
3129         * spu-tdep.c (spu_overlay_data): Change type.
3130         (spu_get_overlay_table, spu_overlay_new_objfile)
3131         (_initialize_spu_tdep): Update.
3132
3133 2019-07-10  Tom Tromey  <tromey@adacore.com>
3134
3135         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3136         destructor.
3137         (dbx_objfile_data_key): Change type and declare later.
3138         (DBX_SYMFILE_INFO): Rewrite.
3139         * dbxread.c (dbx_objfile_data_key): Change type.
3140         (dbx_symfile_init): Update.
3141         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3142         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3143         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3144
3145 2019-07-10  Tom Tromey  <tromey@adacore.com>
3146
3147         * jit.c (jit_program_space_key): Change type.  Move lower.
3148         (get_jit_program_space_data): Update.
3149         (jit_program_space_data_cleanup): Remove.
3150         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3151         Update.
3152         (struct jit_program_space_data): Add initializers.
3153
3154 2019-07-10  Tom Tromey  <tromey@adacore.com>
3155
3156         * solib-darwin.c (struct darwin_info): Add initializers.
3157         (solib_darwin_pspace_data): Change type.
3158         (darwin_pspace_data_cleanup): Remove.
3159         (get_darwin_info, _initialize_darwin_solib): Update.
3160
3161 2019-07-10  Tom Tromey  <tromey@adacore.com>
3162
3163         * remote-sim.c (struct sim_inferior_data): Add initializers,
3164         constructor, and destructor.
3165         (sim_inferior_data_key): Change type.  Move lower.
3166         (check_for_duplicate_sim_descriptor): Update.
3167         (get_sim_inferior_data): Use new.  Update.
3168         (~sim_inferior_data_cleanup): Rename from
3169         sim_inferior_data_cleanup.  Simplify.
3170         (gdbsim_close_inferior, simulator_command)
3171         (sim_command_completer, _initialize_remote_sim): Update.
3172         (next_pid, INITIAL_PID): Move earlier.
3173
3174 2019-07-10  Tom Tromey  <tromey@adacore.com>
3175
3176         * python/python-internal.h (create_thread_object): Return
3177         gdbpy_ref.
3178         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3179         * python/py-inferior.c (struct threadlist_entry): Add
3180         constructor.
3181         <thread_obj>: Now a gdbpy_ref.
3182         (thread_to_thread_object): Update.
3183         (add_thread_object): Use new.
3184         (delete_thread_object): Use delete.
3185         (infpy_threads): Update.
3186         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3187         GIL.
3188
3189 2019-07-10  Tom Tromey  <tromey@adacore.com>
3190
3191         * valops.c (value_cast): Specialize error message for Ada.
3192
3193 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3194
3195         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3196
3197 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3198
3199         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3200         bpstat_should_step): Return bool, adjust comments.
3201         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3202         bpstat_should_step): Likewise.
3203
3204 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3205
3206         * features/Makefile: Use feature target descriptions for Arm.
3207         * features/arm/arm-core.c: Generate new file.
3208         * features/arm/arm-fpa.c: Likewise.
3209         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3210         * features/arm/arm-m-profile.c: Likewise.
3211         * features/arm/arm-vfpv2.c: Likewise.
3212         * features/arm/arm-vfpv3.c: Likewise.
3213         * features/arm/xscale-iwmmxt.c: Likewise.
3214         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3215
3216 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3217
3218         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3219         ptrace earlier.
3220
3221 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3222
3223         * features/aarch64-pauth.c: Regenerate.
3224
3225 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3226
3227         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3228         bool.
3229         (bpstat_what): Use false instead of 0.
3230
3231 2019-07-09  Pedro Alves  <palves@redhat.com>
3232
3233         * break-catch-throw.c (is_exception_catchpoint): New.
3234         * breakpoint.c (print_one_breakpoint_location): New parameter
3235         'raw_loc'.  Handle it.  Use
3236         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3237         looking at the breakpoint's type.
3238         (print_one_breakpoint): If handling "maint info breakpoints", also
3239         print locations of exception catchpoints.
3240         * breakpoint.h (is_exception_catchpoint): Declare.
3241
3242 2019-07-09  Pedro Alves  <palves@redhat.com>
3243
3244         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3245         "addr" field.
3246         (allocate_location_exception_catchpoint): New.
3247         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3248         (initialize_throw_catchpoint_ops): Install
3249         allocate_location_exception_catchpoint as allocate_location
3250         method.
3251         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3252         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3253         bp_loc_other.
3254         (breakpoint_address_is_meaningful): Delete.
3255         (bl_address_is_meaningful): New.
3256         (breakpoint_locations_match): Adjust comment.
3257         (bp_location_from_bp_type): New, factored out of...
3258         (bp_location::bp_location(breakpoint *)): ... this.
3259         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3260         factored out of...
3261         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3262         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3263         breakpoint_address_is_meaningful.
3264         (bp_locations_compare): Adjust comment.
3265         (update_global_location_list): Use bl_address_is_meaningful
3266         instead of breakpoint_address_is_meaningful.
3267         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3268         explicit.
3269         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3270         * python/py-breakpoint.c (bppy_get_location): No longer check
3271         whether location is null.
3272
3273 2019-07-09  Pedro Alves  <palves@redhat.com>
3274
3275         PR c++/15468
3276         * breakpoint.c (print_one_breakpoint_location): Remove
3277         single-location assert.
3278
3279 2019-07-09  Tom Tromey  <tom@tromey.com>
3280
3281         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3282         * configure: Rebuild.
3283         * configure.ac: Change common to gdbsupport.
3284         * gdbsupport: Rename from common.
3285         * acinclude.m4: Change common to gdbsupport.
3286         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3287         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3288         gdbsupport.
3289         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3290         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3291         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3292         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3293         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3294         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3295         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3296         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3297         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3298         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3299         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3300         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3301         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3302         coff-pe-read.c, command.h, compile/compile-c-support.c,
3303         compile/compile-c.h, compile/compile-cplus-symbols.c,
3304         compile/compile-cplus-types.c, compile/compile-cplus.h,
3305         compile/compile-loc2c.c, compile/compile.c, completer.c,
3306         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3307         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3308         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3309         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3310         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3311         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3312         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3313         features/aarch64-core.c, features/aarch64-fpu.c,
3314         features/aarch64-pauth.c, features/aarch64-sve.c,
3315         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3316         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3317         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3318         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3319         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3320         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3321         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3322         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3323         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3324         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3325         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3326         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3327         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3328         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3329         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3330         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3331         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3332         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3333         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3334         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3335         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3336         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3337         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3338         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3339         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3340         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3341         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3342         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3343         minsyms.c, mips-linux-tdep.c, namespace.h,
3344         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3345         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3346         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3347         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3348         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3349         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3350         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3351         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3352         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3353         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3354         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3355         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3356         procfs.c, producer.c, progspace.h, psymtab.h,
3357         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3358         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3359         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3360         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3361         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3362         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3363         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3364         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3365         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3366         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3367         target-memory.c, target.c, target.h, target/waitstatus.c,
3368         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3369         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3370         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3371         unittests/array-view-selftests.c,
3372         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3373         unittests/common-utils-selftests.c,
3374         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3375         unittests/format_pieces-selftests.c,
3376         unittests/function-view-selftests.c,
3377         unittests/lookup_name_info-selftests.c,
3378         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3379         unittests/mkdir-recursive-selftests.c,
3380         unittests/observable-selftests.c,
3381         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3382         unittests/parse-connection-spec-selftests.c,
3383         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3384         unittests/scoped_fd-selftests.c,
3385         unittests/scoped_mmap-selftests.c,
3386         unittests/scoped_restore-selftests.c,
3387         unittests/string_view-selftests.c, unittests/style-selftests.c,
3388         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3389         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3390         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3391         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3392         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3393         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3394
3395 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3396
3397         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3398         bool value.
3399         (decode_digits_ordinary): Set explicit_line field in sal.
3400         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3401         symtab_and_line that was set on an explicit line number in
3402         assembler code.  Do always update the recorded symtab and line if
3403         we do skip the prologue.
3404
3405 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3406
3407         * breakpoint.c (set_breakpoint_location_function): Remove
3408         explicit_loc parameter.
3409         (momentary_breakpoint_from_master): Update call to
3410         set_breakpoint_location_function.
3411         (add_location_to_breakpoint): Likewise.
3412
3413 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3414
3415         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3416         required features based on default bfd type when no specific bfd
3417         is present.
3418
3419 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3420
3421         * NEWS: Mention that GDB printf and eval commands can now print
3422         C-style and Ada-style convenience var strings without
3423         calling the inferior.
3424         * printcmd.c (printf_c_string): Locally print GDB internal var
3425         instead of transiting via the inferior.
3426         (printf_wide_c_string): Likewise.
3427
3428 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3429
3430         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3431
3432 2019-07-04  Tom Tromey  <tom@tromey.com>
3433
3434         PR tui/24724:
3435         * tui/tui-winsource.c (tui_clear_source_content): Update.
3436         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3437         (tui_update_breakpoint_info): Update.
3438         (tui_set_exec_info_content): Update.
3439         * tui/tui-source.c (tui_set_source_content_nil): Update.
3440         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3441         has_break.
3442         * tui/tui-data.h (enum tui_bp_flag): New.
3443         (tui_bp_flags): New enum flags type.
3444         (struct tui_source_element) <break_mode>: Change type.  Rename
3445         from has_break.
3446         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3447         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3448         constants.
3449         * tui/tui-winsource.h: Fix comment.
3450
3451 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3452
3453         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3454         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3455         (store_fpregs_to_thread)
3456         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3457         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3458         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3459         (IWMMXT_REGS_SIZE): Add define.
3460         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3461         (fetch_vfp_regs, store_vfp_regs)
3462         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3463         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3464
3465 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3466
3467         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3468         defines.
3469         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3470         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3471         (ARM_INT_REGISTER_SIZE): ...to this.
3472         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3473         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3474         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3475         (arm_linux_collect_gregset, supply_nwfpe_register)
3476         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3477         defines.
3478         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3479         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3480         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3481         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3482         (arm_return_in_memory, arm_store_return_value)
3483         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3484         (arm_record_ld_st_multiple): Likewise.
3485         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3486         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3487
3488 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3489
3490         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3491         AARCH64_DISPLACED_MODIFIED_INSNS.
3492         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3493         (aarch64_displaced_step_copy_insn): Likewise.
3494         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3495         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3496         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3497         ARM_DISPLACED_MODIFIED_INSNS.
3498         * arm-tdep.c (arm_gdbarch_init): Likewise.
3499         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3500         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3501         (struct arm_displaced_step_closure): Use
3502         ARM_DISPLACED_MODIFIED_INSNS.
3503
3504 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3505
3506         * features/Makefile: Remove unused xml files.
3507         * features/aarch64.xml: Remove.
3508         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3509         * features/i386/amd64-avx-avx512.xml: Remove.
3510         * features/i386/amd64-avx-linux.xml: Remove.
3511         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3512         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3513         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3514         * features/i386/amd64-avx-mpx.xml: Remove.
3515         * features/i386/amd64-avx.xml: Remove.
3516         * features/i386/amd64-linux.xml: Remove.
3517         * features/i386/amd64-mpx-linux.xml: Remove.
3518         * features/i386/amd64-mpx.xml: Remove.
3519         * features/i386/amd64.xml: Remove.
3520         * features/i386/i386-avx-avx512-linux.xml: Remove.
3521         * features/i386/i386-avx-avx512.xml: Remove.
3522         * features/i386/i386-avx-linux.xml: Remove.
3523         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3524         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3525         * features/i386/i386-avx-mpx-linux.xml: Remove.
3526         * features/i386/i386-avx-mpx.xml: Remove.
3527         * features/i386/i386-avx.xml: Remove.
3528         * features/i386/i386-linux.xml: Remove.
3529         * features/i386/i386-mmx-linux.xml: Remove.
3530         * features/i386/i386-mmx.xml: Remove.
3531         * features/i386/i386-mpx-linux.xml: Remove.
3532         * features/i386/i386-mpx.xml: Remove.
3533         * features/i386/i386.xml: Remove.
3534         * features/i386/x32-avx-avx512-linux.xml: Remove.
3535         * features/i386/x32-avx-linux.xml: Remove.
3536         * features/i386/x32-linux.xml: Remove.
3537
3538 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3539
3540         * regformats/aarch64.dat: Remove.
3541         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3542         * regformats/i386/amd64-avx-linux.dat: Remove.
3543         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3544         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3545         * regformats/i386/amd64-linux.dat: Remove.
3546         * regformats/i386/amd64-mpx-linux.dat: Remove.
3547         * regformats/i386/amd64.dat: Remove.
3548         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3549         * regformats/i386/i386-avx-linux.dat: Remove.
3550         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3551         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3552         * regformats/i386/i386-linux.dat: Remove.
3553         * regformats/i386/i386-mmx-linux.dat: Remove.
3554         * regformats/i386/i386-mpx-linux.dat: Remove.
3555         * regformats/i386/i386.dat: Remove.
3556         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3557         * regformats/i386/x32-avx-linux.dat: Remove.
3558         * regformats/i386/x32-linux.dat: Remove.
3559
3560 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3561
3562         * aarch64-tdep.c: Remove xml self tests.
3563         * amd64-linux-tdep.c: Likewise.
3564         * amd64-tdep.c: Likewise.
3565         * i386-linux-tdep.c: Likewise.
3566         * i386-tdep.c: Likewise.
3567
3568 2019-07-03  Pedro Alves  <palves@redhat.com>
3569
3570         PR cli/24732
3571         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3572         (pipe_cmd_option_defs): New.
3573         (make_pipe_cmd_options_def_group): New.
3574         (pipe_command): Use gdb::option::process_options.
3575         (pipe_command_completer): New function.
3576         (_initialize_cli_cmds): Install completer for "pipe" command.
3577
3578 2019-07-03  Pedro Alves  <palves@redhat.com>
3579
3580         * cli/cli-option.c (union option_value) <string>: New field.
3581         (struct option_def_and_value): Add ctor, move ctor, dtor and
3582         use DISABLE_COPY_AND_ASSIGN.
3583         (option_def_and_value::clear_value): New.
3584         (parse_option, save_option_value_in_ctx, get_val_type_str)
3585         (add_setshow_cmds_for_options): Handle var_string.
3586         * cli-option.h (union option_def::var_address) <string>: New
3587         field.
3588         (struct string_option_def): New.
3589         * maint-test-options.c (struct test_options_opts): Add default
3590         ctor and use DISABLE_COPY_AND_ASSIGN.
3591         <string_opt>: New field.
3592         (test_options_opts::~test_options_opts): New.
3593         (test_options_opts::dump): Also dump "-string".
3594         (test_options_option_defs): Install "string.
3595
3596 2019-07-03  Pedro Alves  <palves@redhat.com>
3597
3598         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3599         option_value with a null enumeration.
3600         (complete_options): Save the option values in the context.
3601         (save_option_value_in_ctx): New, factored out from ...
3602         (process_options): ... here.
3603         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3604         of the function.
3605         * maint-test-options.c (test_options_opts::dump): New, factored
3606         out from ...
3607         (maintenance_test_options_command_mode): ... here.
3608         (maintenance_test_options_command_completion_result): Delete.
3609         (maintenance_test_options_command_completion_text): Update
3610         comment.
3611         (maintenance_show_test_options_completion_result): Change
3612         prototype.  Just print
3613         maintenance_test_options_command_completion_text.
3614         (save_completion_result): New.
3615         (maintenance_test_options_completer_mode): Pass options context to
3616         complete_options, and then save a dump.
3617         (_initialize_maint_test_options): Use add_cmd to install "maint
3618         show test-options-completion-result".
3619
3620 2019-07-03  Pedro Alves  <palves@redhat.com>
3621
3622         * NEWS (New commands): Mention "with" and "maint with".
3623         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3624         (with_command, with_command_completer): New.
3625         (pipe_command): Adjust to new repeat_previous
3626         interface.
3627         (_initialize_cli_cmds): Install the "with" command and its "w"
3628         alias.
3629         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3630         declarations.
3631         * cli/cli-setshow.c (parse_cli_var_uinteger)
3632         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3633         argument strings for all var_types.
3634         (get_setshow_command_value_string): New, factored out from ...
3635         (do_show_command): ... this.
3636         * cli/cli-setshow.h: Include <string>.
3637         (get_setshow_command_value_string): Declare.
3638         * command.h (repeat_previous): Now returns const char *.  Adjust
3639         comment.
3640         * maint.c: Include "cli/cli-cmds.h".
3641         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3642         (_initialize_maint_cmds): Register the "maintenance with" command.
3643         * top.c (repeat_previous): Move bits from pipe_command here:
3644         Return the saved command line, if any; error out if there's no
3645         command to relaunch.
3646
3647 2019-07-03  Pedro Alves  <palves@redhat.com>
3648
3649         * NEWS (New commands): Mention "maint set/show test-settings"
3650         instead of "maint test-settings".
3651         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3652         (maintenance_test_settings_set_list): Rename to ...
3653         (maintenance_set_test_settings_list): ... this.
3654         (maintenance_test_settings_show_list): Rename to  ...
3655         (maintenance_show_test_settings_list): ... this.
3656         (maintenance_test_settings_cmd): Delete.
3657         (maintenance_test_settings_set_cmd): ...
3658         (maintenance_set_test_settings_cmd): ... this.
3659         (maintenance_test_settings_show_cmd): ...
3660         (maintenance_show_test_settings_cmd): ... this.
3661         (maintenance_test_settings_show_value_cmd):
3662         (maintenance_show_test_settings_value_cmd): ... this.
3663         (_initialize_maint_test_settings): No longer install the "maint
3664         test-settings" prefix command.  Rename "maint test-settings set"
3665         to "maint set test-settings", and "maint test-settings show" to
3666         "maint show test-settings".  Adjust all subcommands.
3667
3668 2019-07-03  Pedro Alves  <palves@redhat.com>
3669
3670         * maint-test-settings.c: Fix file's intro comment.  Replace all
3671         references to "test-options" with references to "test-settings",
3672         in comments.
3673
3674 2019-07-03  Pedro Alves  <palves@redhat.com>
3675
3676         * maint-test-settings.c (maintenance_test_settings_xxx)
3677         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3678         New.
3679         (maintenance_test_settings_enums): Use them.
3680         (maintenance_test_settings_enum): Default to
3681         maintenance_test_settings_xxx.
3682         (_initialize_maint_test_settings): Initialize
3683         MAINTENANCE_TEST_SETTINGS_FILENAME.
3684
3685 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3686
3687         * breakpoint.h (remove_breakpoints_inf): Change return type to
3688         void, move function documentation here.
3689         * breakpoint.c (remove_breakpoints_inf): Change return type to
3690         void, move function documentation to header.
3691
3692 2019-07-02  Pedro Alves  <palves@redhat.com>
3693
3694         * NEWS (Completion improvements): Mention "info threads".
3695         * thread.c (struct info_threads_opts, info_threads_option_defs)
3696         (make_info_threads_options_def_group): New.
3697         (info_threads_command): Use gdb::option::process_options.
3698         (info_threads_command_completer): New.
3699         (_initialize_thread): Use gdb::option::build_help to build the
3700         help text for "info threads".
3701
3702 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3703
3704         * defs.h (generic_load): Move from here...
3705         * symfile.h (generic_load): ... to here.  Rename name parameter
3706         to args.
3707         * symfile.c (generic_load): Add comment.
3708
3709 2019-07-01  Tom Tromey  <tromey@adacore.com>
3710
3711         * dwarf2read.c
3712         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3713         declaration of without_params.  Fix formatting.
3714
3715 2019-07-01  Tom Tromey  <tromey@adacore.com>
3716
3717         * ada-exp.y (find_primitive_type): Update.
3718         * ada-lang.h (ada_lookup_symbol): Update.
3719         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3720         parameter.
3721         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3722
3723 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3724
3725         PR breakpoints/24541
3726         * gdbarch.c: Regenerate.
3727         * gdbarch.h: Regenerate.
3728         * gdbarch.sh: Add 'stap_adjust_register'.
3729         * i386-tdep.c: Include '<unordered_set>'.
3730         (i386_stap_adjust_register): New function.
3731         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3732         * stap-probe.c (stap_parse_register_operand): Call
3733         'gdbarch_stap_adjust_register'.
3734
3735 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3736
3737         PR python/24742
3738         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3739         * python/python.c (do_start_initialization): Use 'xmalloc'
3740         instead of 'PyMem_Malloc'.
3741
3742 2019-06-28  Tom Tromey  <tromey@adacore.com>
3743
3744         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3745         for Ada.
3746
3747 2019-06-27  Tom Tromey  <tromey@adacore.com>
3748
3749         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3750         objfile_key.
3751         (arm_find_mapping_symbol, arm_record_special_symbol)
3752         (_initialize_arm_tdep): Update.
3753         (arm_objfile_data_free): Remove.
3754
3755 2019-06-27  Tom Tromey  <tromey@adacore.com>
3756
3757         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3758         to cp_print_static_field.
3759
3760 2019-06-26  Tom Tromey  <tromey@adacore.com>
3761
3762         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3763         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3764         declare.
3765
3766 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3767
3768         * features/aarch64-core.c (create_feature_aarch64_core):
3769         Regenerate.
3770         * features/aarch64-core.xml: Add cpsr flags.
3771
3772 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3773
3774         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3775         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3776
3777 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3778
3779         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3780         field.
3781         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3782         use.
3783         (arm_record_special_symbol): Don't insert new symbol in sorted
3784         position, push it at the end.
3785
3786 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3787
3788         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3789         (arm_mapping_symbol_s): Remove.
3790         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3791         (arm_mapping_symbol_vec): New typedef.
3792         (struct arm_per_objfile): Add constructor.
3793         <section_maps>: Change type to
3794         std::unique_ptr<arm_mapping_symbol_vec[]>.
3795         (arm_compare_mapping_symbols): Remove.
3796         (arm_find_mapping_symbol): Adjust to section_maps type change.
3797         (arm_objfile_data_free): Call delete on arm_per_objfile.
3798         (arm_record_special_symbol): Adjust to section_maps type change.
3799         Allocate arm_per_objfile with new.
3800
3801 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3802
3803         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3804         with the command prefix.
3805
3806 2019-06-25  Tom Tromey  <tom@tromey.com>
3807
3808         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3809         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3810
3811 2019-06-25  Tom Tromey  <tom@tromey.com>
3812
3813         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3814         type.
3815         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3816         protected.
3817
3818 2019-06-25  Tom Tromey  <tom@tromey.com>
3819
3820         * tui/tui-winsource.c
3821         (tui_source_window_base::set_is_exec_point_at): Add check against
3822         LOA_ADDRESS.
3823
3824 2019-06-25  Tom Tromey  <tom@tromey.com>
3825
3826         * tui/tui-source.c (tui_set_source_content): Don't check before
3827         xfree.
3828         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3829
3830 2019-06-25  Tom Tromey  <tom@tromey.com>
3831
3832         * tui/tui-winsource.h (tui_update_source_window_as_is)
3833         (tui_alloc_source_buffer, tui_line_is_displayed)
3834         (tui_addr_is_displayed): Change type of win_info.
3835         * tui/tui-winsource.c (tui_update_source_window_as_is)
3836         (tui_clear_source_content, tui_show_source_line)
3837         (tui_show_source_content, tui_source_window_base::refill)
3838         (tui_source_window_base::set_is_exec_point_at)
3839         (tui_source_window_base::set_is_exec_point_at)
3840         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3841         (tui_alloc_source_buffer, tui_line_is_displayed)
3842         (tui_addr_is_displayed): Change type of win_info.  Update.
3843         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3844         (tui_source_window_base::do_make_visible_with_new_height):
3845         Update.
3846         * tui/tui-source.c (tui_set_source_content)
3847         (tui_set_source_content_nil)
3848         (tui_source_window::do_scroll_vertical): Update.
3849         * tui/tui-layout.c (show_layout): Update.
3850         * tui/tui-disasm.c (tui_set_disassem_content)
3851         (tui_disasm_window::do_scroll_vertical): Update.
3852         * tui/tui-data.h (tui_win_content): Remove.
3853         (struct tui_gen_win_info) <content, content_size>: Remove.
3854         (struct tui_source_element): Add initializers and destructor.
3855         (union tui_which_element, struct tui_win_element): Remove.
3856         (struct tui_source_window_base) <content>: New field.
3857         (struct tui_data_window): Remove destructor.
3858         (tui_alloc_content, tui_free_win_content)
3859         (tui_free_all_source_wins_content): Don't declare.
3860         * tui/tui-data.c (tui_initialize_static_data): Update.
3861         (init_content_element, tui_alloc_content): Remove.
3862         (~tui_gen_win_info): Update.
3863         (~tui_data_window, tui_free_all_source_wins_content)
3864         (tui_free_win_content, free_content, free_content_elements):
3865         Remove.
3866
3867 2019-06-25  Tom Tromey  <tom@tromey.com>
3868
3869         * tui/tui-winsource.h (tui_clear_source_content)
3870         (tui_erase_source_content, tui_show_source_content): Change type
3871         of win_info.
3872         * tui/tui-winsource.c (tui_clear_source_content)
3873         (tui_erase_source_content, tui_show_source_content): Change type
3874         of win_info.
3875         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3876         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3877         win_info.
3878         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3879         win_info.
3880         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3881
3882 2019-06-25  Tom Tromey  <tom@tromey.com>
3883
3884         * tui/tui-winsource.c (tui_clear_source_content)
3885         (tui_source_window_base::set_is_exec_point_at): Update.
3886         * tui/tui-source.c (tui_set_source_content_nil): Update.
3887         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3888         a bool.
3889         * tui/tui-data.c (init_content_element): Update.
3890
3891 2019-06-25  Tom Tromey  <tom@tromey.com>
3892
3893         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3894         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3895         * tui/tui-layout.c (init_and_make_win): Update.
3896         * tui/tui.h (enum tui_win_type): Update.
3897         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3898         tui_win_is_auxillary.
3899         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3900         tui_win_is_auxillary.
3901
3902 2019-06-25  Tom Tromey  <tom@tromey.com>
3903
3904         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3905         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3906         (tui_delete_data_content_windows, tui_display_all_data)
3907         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3908         Update.
3909         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3910         * tui/tui-regs.c (tui_last_regs_line_no)
3911         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3912         (tui_show_registers): Update.
3913         (tui_show_register_group): Return void.  Update.
3914         (tui_display_registers_from, tui_display_reg_element_at_line)
3915         (tui_display_registers_from_line, tui_check_register_values):
3916         Update.
3917         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3918         member.
3919         (struct tui_data_window) <regs_content>: Now a std::vector.
3920         <regs_content_count>: Remove.
3921         (tui_add_content_elements, tui_free_data_content): Don't declare.
3922         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3923         (init_content_element): Remove DATA_WIN case.  Add assert.
3924         (tui_add_content_elements): Remove.
3925         (tui_data_window): Update.
3926         (tui_free_data_content): Remove.
3927         (free_content_elements): Remove DATA_WIN case.
3928
3929 2019-06-25  Tom Tromey  <tom@tromey.com>
3930
3931         * tui/tui-data.c (tui_data_item_window): Update.
3932         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3933         * tui/tui-windata.c (tui_display_all_data)
3934         (tui_display_data_from_line): Update.
3935         (tui_check_data_values): Remove.
3936         * tui/tui-regs.c (tui_show_register_group)
3937         (tui_display_reg_element_at_line): Update.
3938         * tui/tui-hooks.c (tui_register_changed)
3939         (tui_refresh_frame_and_register_information): Call
3940         tui_check_register_values.
3941         * tui/tui-data.h (struct tui_data_window) <data_content,
3942         data_content_count, data_type>: Remove.
3943         (enum tui_data_type): Remove.
3944
3945         * tui/tui-data.c (tui_data_window::clear_detail)
3946         (~tui_data_window): Update.
3947
3948 2019-06-25  Tom Tromey  <tom@tromey.com>
3949
3950         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3951         declare.
3952         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3953         Rename from tui_first_data_item_displayed.  Update.
3954         (tui_data_window::refresh_all)
3955         (tui_data_window::do_scroll_vertical): Update.
3956         * tui/tui-data.h (struct tui_data_window)
3957         <first_data_item_displayed>: Declare new method.
3958
3959 2019-06-25  Tom Tromey  <tom@tromey.com>
3960
3961         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3962         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3963         contents...
3964         (tui_initialize_static_data): ...here.
3965
3966 2019-06-25  Tom Tromey  <tom@tromey.com>
3967
3968         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3969         (tui_display_registers_from, tui_check_register_values): Update.
3970         (tui_display_register): Remove win_info parameter; update.
3971         (tui_get_register): Change type of parameters.
3972         * tui/tui-data.h (struct tui_data_element): Remove.
3973         (union tui_which_element) <data>: Remove.
3974         <data_window>: Change type.
3975         (struct tui_data_item_window): New.
3976         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3977         case.  Add assert.
3978         (~tui_data_item_window): New destructor.
3979         (free_content_elements): Remove DATA_ITEM_WIN case.
3980
3981 2019-06-25  Tom Tromey  <tom@tromey.com>
3982
3983         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3984         Remove.
3985
3986 2019-06-25  Tom Tromey  <tom@tromey.com>
3987
3988         * tui/tui-data.h (struct tui_command_element): Remove.
3989         (union tui_which_element) <command>: Remove.
3990         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3991         assert.
3992         (free_content_elements): Remove CMD_WIN case.
3993
3994 2019-06-25  Tom Tromey  <tom@tromey.com>
3995
3996         * tui/tui-layout.c (tui_set_layout): Update.
3997         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3998         * tui/tui-data.c (layout_def): Update.
3999
4000 2019-06-25  Tom Tromey  <tom@tromey.com>
4001
4002         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4003         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4004         (tui_source_window_base::set_new_height): Update.
4005         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4006         Update.
4007         (tui_set_locator_fullname, tui_set_locator_info)
4008         (tui_show_frame_info): Update.
4009         * tui/tui-source.c (tui_set_source_content)
4010         (tui_source_is_displayed): Update.
4011         * tui/tui-layout.c (show_source_disasm_command, show_data)
4012         (show_source_or_disasm_and_command): Update.
4013         * tui/tui-disasm.c (tui_set_disassem_content)
4014         (tui_get_begin_asm_address): Update.
4015         * tui/tui-data.h (struct tui_locator_element): Remove.
4016         (union tui_which_element) <locator>: Remove.
4017         (struct tui_locator_window): New.
4018         (tui_locator_win_info_ptr): Change return type.
4019         * tui/tui-data.c (_locator): Change type.
4020         (tui_locator_win_info_ptr): Change return type.
4021         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4022         (tui_alloc_content): Add assert.
4023
4024 2019-06-25  Tom Tromey  <tom@tromey.com>
4025
4026         * tui/tui-winsource.c
4027         (tui_exec_info_window::maybe_allocate_content): New method.
4028         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4029         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4030         (make_source_or_disasm_window): Add cast.
4031         * tui/tui-data.h (union tui_which_element) <simple_string>:
4032         Remove.
4033         (struct tui_source_info): New.
4034         (struct tui_source_window_base) <execution_info>: Change type.
4035         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4036         case, and add assert.
4037         (tui_alloc_content): Add assert.
4038
4039 2019-06-25  Tom Tromey  <tom@tromey.com>
4040
4041         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4042         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4043         * tui/tui-data.c (tui_alloc_win_info): Remove.
4044
4045 2019-06-25  Tom Tromey  <tom@tromey.com>
4046
4047         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4048         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4049         can_highlight.
4050
4051 2019-06-25  Tom Tromey  <tom@tromey.com>
4052
4053         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4054         make_visible_with_new_height method.
4055         (tui_win_info::make_visible_with_new_height): New method.
4056         (tui_source_window_base::do_make_visible_with_new_height)
4057         (tui_data_window::do_make_visible_with_new_height)
4058         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4059         (make_visible_with_new_height): Remove.
4060         (tui_resize_all, tui_adjust_win_heights): Use
4061         make_visible_with_new_height method.
4062         * tui/tui-data.h (struct tui_win_info)
4063         <do_make_visible_with_new_height, make_visible_with_new_height>:
4064         New methods.
4065         (struct tui_source_window_base, struct tui_data_window)
4066         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4067         methods.
4068
4069 2019-06-25  Tom Tromey  <tom@tromey.com>
4070
4071         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4072         method.
4073         (update_tab_width): Call update_tab_width method.
4074         * tui/tui-data.h (struct tui_win_info)
4075         (struct tui_source_window_base) <update_tab_width>: New methods.
4076
4077 2019-06-25  Tom Tromey  <tom@tromey.com>
4078
4079         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4080         parameter.
4081         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4082         parameter.
4083         (tui_gen_win_info::make_visible): Update.
4084         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4085         parameter.
4086         * tui/tui-data.h (enum tui_box): New enum.
4087         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4088
4089 2019-06-25  Tom Tromey  <tom@tromey.com>
4090
4091         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4092         init_and_make_win for EXEC_INFO_WIN.
4093         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4094         longer inline.
4095         (struct tui_win_info) <~tui_win_info>: Inline.
4096         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4097         Don't declare.
4098         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4099         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4100         Remove.
4101         (tui_initialize_static_data): Update.
4102         (~tui_gen_win_info): Handle more cleanup here.
4103         (~tui_source_window_base): Delete "execution_info".
4104         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4105
4106 2019-06-25  Tom Tromey  <tom@tromey.com>
4107
4108         * tui/tui-layout.c (make_command_window): Don't set
4109         can_highlight.
4110         (show_source_disasm_command): Call the reset method.
4111         (show_data): Don't set can_highlight.  Call the reset method.
4112         (tui_gen_win_info::reset): Rename from init_gen_win_info
4113         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4114         (show_source_or_disasm_and_command): Call the reset method.
4115         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4116         (struct tui_cmd_window): Set can_highlight.
4117
4118 2019-06-25  Tom Tromey  <tom@tromey.com>
4119
4120         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4121         from make_visible.
4122         (tui_make_visible, tui_make_invisible): Rewrite.
4123         (tui_win_info::make_visible): Remove.
4124         (tui_source_window_base::make_visible): Update.
4125         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4126         method.  Moved from...
4127         (struct tui_win_info) <make_visible>: ...here.
4128
4129 2019-06-25  Tom Tromey  <tom@tromey.com>
4130
4131         * tui/tui-winsource.c
4132         (tui_source_window_base::do_scroll_horizontal): Remove direction
4133         parameter.
4134         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4135         direction parameter.
4136         * tui/tui-win.c (tui_win_info::forward_scroll)
4137         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4138         (tui_win_info::right_scroll): Update.
4139         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4140         direction parameter.
4141         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4142         direction parameter.
4143         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4144         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4145         Remove direction parameter.
4146         (struct tui_source_window_base, struct tui_source_window)
4147         (struct tui_disasm_window, struct tui_data_window)
4148         (struct tui_cmd_window): Update.
4149
4150 2019-06-25  Tom Tromey  <tom@tromey.com>
4151
4152         * tui/tui-winsource.h (tui_set_exec_info_content)
4153         (tui_show_exec_info_content, tui_erase_exec_info_content)
4154         (tui_clear_exec_info_content, tui_update_exec_info): Change
4155         argument to tui_source_window_base.
4156         * tui/tui-winsource.c (tui_set_exec_info_content)
4157         (tui_show_exec_info_content, tui_erase_exec_info_content)
4158         (tui_clear_exec_info_content, tui_update_exec_info): Change
4159         argument to tui_source_window_base.
4160
4161 2019-06-25  Tom Tromey  <tom@tromey.com>
4162
4163         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4164         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4165
4166 2019-06-25  Tom Tromey  <tom@tromey.com>
4167
4168         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4169         check.
4170
4171 2019-06-25  Tom Tromey  <tom@tromey.com>
4172
4173         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4174         type to void.
4175         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4176         type to void.
4177         * tui/tui-source.c (tui_set_source_content): Update.
4178         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4179
4180 2019-06-25  Tom Tromey  <tom@tromey.com>
4181
4182         * tui/tui-win.c (window_name_completer, tui_set_focus)
4183         (tui_all_windows_info): Use name method.
4184         * tui/tui-data.h (struct tui_gen_win_info)
4185         (struct tui_source_window, struct tui_disasm_window)
4186         (struct tui_data_window, struct tui_cmd_window) <name>: New
4187         method.
4188         (tui_win_name): Don't declare.
4189         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4190         (tui_win_name): Remove.
4191
4192 2019-06-25  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-winsource.h (tui_update_source_window)
4195         (tui_update_source_window_as_is): Change parameter type.
4196         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4197         to be a tui_source_window_base.
4198         (tui_update_source_window_as_is): Likewise.
4199         * tui/tui-win.c (make_visible_with_new_height): Update.
4200
4201 2019-06-25  Tom Tromey  <tom@tromey.com>
4202
4203         * tui/tui-winsource.c (tui_erase_source_content)
4204         (tui_show_source_content, tui_show_exec_info_content)
4205         (tui_erase_exec_info_content): Use refresh_window method.
4206         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4207         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4208         from tui_refresh_win.
4209         (tui_data_window::refresh_window): New method.
4210         (tui_win_info::refresh, tui_source_window_base::refresh)
4211         (tui_refresh_all): Use refresh_window method.
4212         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4213         method.
4214         * tui/tui-regs.c (tui_display_register): Call refresh_window
4215         method.
4216         * tui/tui-layout.c (show_source_disasm_command)
4217         (show_source_or_disasm_and_command): Call refresh_window method.
4218         * tui/tui-data.h (struct tui_gen_win_info)
4219         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4220         New method.
4221
4222 2019-06-25  Tom Tromey  <tom@tromey.com>
4223
4224         * tui/tui.c (tui_rl_other_window, tui_enable)
4225         (tui_is_window_visible, tui_get_command_dimension): Update.
4226         * tui/tui-winsource.c (tui_update_source_window_as_is)
4227         (tui_clear_source_content, tui_erase_source_content)
4228         (tui_show_source_line, tui_source_window_base::refill)
4229         (tui_source_window_base::do_scroll_horizontal)
4230         (tui_source_window_base::set_is_exec_point_at)
4231         (tui_update_breakpoint_info, tui_set_exec_info_content)
4232         (tui_alloc_source_buffer, tui_line_is_displayed)
4233         (tui_addr_is_displayed): Update.
4234         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4235         (tui_check_and_display_highlight_if_needed)
4236         (tui_win_info::make_visible, tui_win_info::refresh)
4237         (tui_refresh_all): Update.
4238         * tui/tui-windata.c (tui_first_data_item_displayed)
4239         (tui_delete_data_content_windows, tui_erase_data_content)
4240         (tui_display_all_data, tui_data_window::refresh_all)
4241         (tui_check_data_values): Update.
4242         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4243         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4244         (tui_win_info::backward_scroll, tui_refresh_all_win)
4245         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4246         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4247         (tui_source_window_base::set_new_height)
4248         (tui_data_window::set_new_height)
4249         (make_invisible_and_set_new_height)
4250         (make_visible_with_new_height, new_height_ok)
4251         (parse_scrolling_args): Update.
4252         * tui/tui-stack.c (tui_show_frame_info): Update.
4253         * tui/tui-source.c (tui_set_source_content)
4254         (tui_set_source_content_nil, tui_source_is_displayed)
4255         (tui_source_window::do_scroll_vertical): Update.
4256         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4257         (tui_display_registers_from, tui_display_reg_element_at_line)
4258         (tui_check_register_values, tui_reg_command): Update.
4259         * tui/tui-layout.c (tui_default_win_height)
4260         (show_source_disasm_command, show_data, init_and_make_win)
4261         (show_source_or_disasm_and_command): Update.
4262         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4263         (tui_redisplay_readline, tui_mld_flush)
4264         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4265         (tui_getc): Update.
4266         * tui/tui-disasm.c (tui_set_disassem_content)
4267         (tui_disasm_window::do_scroll_vertical): Update.
4268         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4269         Now virtual.
4270         (struct tui_win_info): Derive from tui_gen_win_info.
4271         <~tui_win_info>: Mark as override.
4272         <generic>: Remove member.
4273         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4274         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4275         (~tui_data_window, ~tui_win_info)
4276         (tui_free_all_source_wins_content): Update.
4277         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4278
4279 2019-06-25  Tom Tromey  <tom@tromey.com>
4280
4281         * tui/tui-layout.c (init_and_make_win): Use new.
4282         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4283         destructor, initializers.
4284         (tui_alloc_generic_win_info): Don't declare.
4285         * tui/tui-data.c (_locator): Add argument to constructor.
4286         (source_win, disasm_win): New globals.
4287         (exec_info): Remove.
4288         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4289         Update.
4290         (tui_alloc_generic_win_info): Remove.
4291         (init_content_element): Use new.
4292         (tui_win_info::tui_win_info): Update.
4293         (free_content_elements) <case DATA_WIN>: Use delete.
4294
4295 2019-06-25  Tom Tromey  <tom@tromey.com>
4296
4297         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4298         * tui/tui-windata.c (tui_first_data_item_displayed)
4299         (tui_delete_data_content_windows): Update.
4300         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4301         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4302         (tui_display_registers_from, tui_check_register_values): Update.
4303         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4304         pointer.
4305         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4306         window.
4307         (tui_free_data_content): Update.
4308         (free_content_elements) <case DATA_WIN>: Free the window.
4309
4310 2019-06-25  Tom Tromey  <tom@tromey.com>
4311
4312         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4313         Update.
4314         * tui/tui-layout.c (make_command_window)
4315         (show_source_disasm_command, show_data, init_and_make_win)
4316         (show_source_or_disasm_and_command): Update.
4317         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4318         method.
4319         <can_highight, is_highlighted>: Now bool.
4320         (tui_set_win_highlight): Don't declare.
4321         * tui/tui-data.c (tui_set_win_highlight): Remove.
4322
4323 2019-06-25  Tom Tromey  <tom@tromey.com>
4324
4325         * tui/tui-wingeneral.c (make_visible): Remove check of window
4326         type.
4327
4328 2019-06-25  Tom Tromey  <tom@tromey.com>
4329
4330         * tui/tui-win.c (tui_win_info::max_height)
4331         (tui_cmd_window::max_height): New methods.
4332         (new_height_ok): Call max_height.
4333         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4334         <max_height>: New method.
4335
4336 2019-06-25  Tom Tromey  <tom@tromey.com>
4337
4338         * tui/tui-win.c (tui_source_window_base::set_new_height)
4339         (tui_data_window::set_new_height): New methods.
4340         (make_invisible_and_set_new_height): Call set_new_height method.
4341         * tui/tui-data.h (struct tui_win_info)
4342         (struct tui_source_window_base, struct tui_data_window)
4343         <set_new_height>: New method.
4344
4345 2019-06-25  Tom Tromey  <tom@tromey.com>
4346
4347         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4348         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4349         tui_refresh_data_win.
4350         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4351         method.
4352         (tui_refresh_all_win): Call the refresh_all method.
4353         (tui_set_focus): Likewise.
4354         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4355         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4356         Likewise.
4357
4358 2019-06-25  Tom Tromey  <tom@tromey.com>
4359
4360         * tui/tui-winsource.h (tui_refill_source_window)
4361         (tui_set_is_exec_point_at): Don't declare.
4362         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4363         (tui_source_window_base::refill): Rename from
4364         tui_refill_source_window.
4365         (tui_source_window_base::do_scroll_horizontal): Update.
4366         (tui_source_window_base::set_is_exec_point_at): Rename from
4367         tui_set_is_exec_point_at.
4368         (tui_update_all_breakpoint_info): Update.
4369         * tui/tui-stack.c (tui_show_frame_info): Update.
4370         * tui/tui-layout.c (show_data): Add cast.
4371         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4372         * tui/tui-data.h (struct tui_source_window_base) <refill,
4373         set_is_exec_point_at>: New methods.
4374         (tui_source_windows, tui_add_to_source_windows): Update types.
4375         (tui_add_to_source_windows): Remove redundant declaration.
4376         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4377         (tui_source_windows): Change return type.
4378         (tui_clear_source_windows_detail): Update.
4379         (tui_add_to_source_windows): Change type of parameter.
4380         (tui_free_all_source_wins_content): Update.
4381
4382 2019-06-25  Tom Tromey  <tom@tromey.com>
4383
4384         * tui/tui-wingeneral.c (tui_win_info::refresh)
4385         (tui_source_window_base::refresh): New methods.
4386         (tui_refresh_all): Call the refresh method.
4387         * tui/tui-data.h (struct tui_win_info)
4388         (struct tui_source_window_base) <refresh>: New method.
4389
4390 2019-06-25  Tom Tromey  <tom@tromey.com>
4391
4392         * tui/tui.h (tui_is_window_visible): Return bool.
4393         * tui/tui.c (tui_is_window_visible): Return bool.
4394         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4395         (tui_make_visible, tui_make_invisible)
4396         (tui_win_info::make_visible)
4397         (tui_source_window_base::make_visible, make_all_visible)
4398         (tui_make_all_visible, tui_make_all_invisible): Update.
4399         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4400         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4401         bool.
4402         (struct tui_win_info, struct tui_source_window_base)
4403         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4404         * tui/tui-data.c (tui_init_generic_part): Update.
4405
4406 2019-06-25  Tom Tromey  <tom@tromey.com>
4407
4408         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4409         (tui_source_window_base::make_visible): New methods.
4410         (make_all_visible): Make method call.
4411         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4412         (struct tui_source_window_base, struct tui_cmd_window): Override
4413         make_visible.
4414         (tui_win_is_source_type): Don't declare.
4415         * tui/tui-data.c (tui_win_is_source_type): Remove.
4416
4417 2019-06-25  Tom Tromey  <tom@tromey.com>
4418
4419         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4420         NULL check.
4421
4422 2019-06-25  Tom Tromey  <tom@tromey.com>
4423
4424         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4425         Inline constructor.  Add initializers for members.
4426         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4427         constructors; now inline in class.
4428
4429 2019-06-25  Tom Tromey  <tom@tromey.com>
4430
4431         * tui/tui-regs.c (tui_show_registers): Update.
4432         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4433         bool.
4434         * tui/tui-data.c (tui_data_window::clear_detail)
4435         (tui_data_window): Update.
4436
4437 2019-06-25  Tom Tromey  <tom@tromey.com>
4438
4439         * tui/tui-windata.c (tui_display_all_data)
4440         (tui_display_data_from_line, tui_display_data_from)
4441         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4442         Update.
4443         * tui/tui-regs.c (tui_last_regs_line_no)
4444         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4445         (tui_show_registers, tui_show_register_group)
4446         (tui_display_registers_from, tui_display_reg_element_at_line)
4447         (tui_display_registers_from_line, tui_check_register_values)
4448         (tui_reg_next, tui_reg_prev): Update.
4449         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4450         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4451         tui_data_window.
4452         (struct tui_win_info) <detail>: Remove.  Add new fields from
4453         tui_data_info.
4454         (TUI_DATA_WIN): Add cast.
4455         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4456         (~tui_data_window): Simplify.
4457
4458 2019-06-25  Tom Tromey  <tom@tromey.com>
4459
4460         * tui/tui-layout.c (show_source_disasm_command)
4461         (show_source_or_disasm_and_command): Update.
4462         * tui/tui-io.c (update_cmdwin_start_line)
4463         (tui_redisplay_readline): Update.
4464         * tui/tui-data.h (struct tui_command_info): Remove.
4465         (struct tui_win_info) <detail>: Remove command_info member.
4466         (struct tui_data_window) <start_line>: New member, from
4467         tui_command_info.
4468         (TUI_CMD_WIN): Add casts.
4469
4470 2019-06-25  Tom Tromey  <tom@tromey.com>
4471
4472         * tui/tui-winsource.c (tui_update_source_window)
4473         (tui_refill_source_window)
4474         (tui_source_window_base::do_scroll_horizontal)
4475         (tui_update_breakpoint_info, tui_set_exec_info_content)
4476         (tui_show_exec_info_content, tui_erase_exec_info_content)
4477         (tui_clear_exec_info_content): Update.
4478         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4479         Update.
4480         * tui/tui-win.c (make_invisible_and_set_new_height)
4481         (make_visible_with_new_height): Update.
4482         * tui/tui-source.c (tui_set_source_content)
4483         (tui_show_symtab_source): Update.
4484         * tui/tui-layout.c (extract_display_start_addr)
4485         (show_source_disasm_command, show_data)
4486         (make_source_or_disasm_window)
4487         (show_source_or_disasm_and_command): Update.
4488         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4489         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4490         "gdbarch".
4491         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4492         to tui_source_window_base.
4493         (struct tui_win_info) <detail>: Remove source_info member.
4494         (struct tui_source_window_base) <has_locator>: Inline.
4495         Move contents from tui_source_info; rename has_locator member to
4496         m_has_locator.
4497         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4498         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4499         header file.
4500         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4501         Simplify.
4502         (tui_free_all_source_wins_content): Cast to
4503         tui_source_window_base.
4504
4505 2019-06-25  Tom Tromey  <tom@tromey.com>
4506
4507         * tui/tui-win.c (make_invisible_and_set_new_height)
4508         (make_visible_with_new_height): Call has_locator method.
4509         * tui/tui-layout.c (show_source_disasm_command, show_data)
4510         (show_source_or_disasm_and_command): Update for bool change.
4511         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4512         (tui_win_info) <has_locator>: New method.
4513         (struct tui_source_window_base) <has_locator>: New method.
4514         (tui_win_has_locator): Don't declare.
4515         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4516         from tui_win_has_locator.
4517         (tui_source_window_base): Use false, not FALSE.
4518
4519 2019-06-25  Tom Tromey  <tom@tromey.com>
4520
4521         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4522         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4523         clear_detail method directly.
4524         (tui_clear_win_detail): Remove.
4525
4526 2019-06-25  Tom Tromey  <tom@tromey.com>
4527
4528         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4529         "this", not TUI_DISASM_WIN.
4530
4531 2019-06-25  Tom Tromey  <tom@tromey.com>
4532
4533         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4534         declare.
4535         * tui/tui-winsource.c
4536         (tui_source_window_base::do_scroll_horizontal): Rename from
4537         tui_horizontal_source_scroll.
4538         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4539         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4540         from tui_vertical_data_scroll.
4541         * tui/tui-win.h (tui_scroll): Don't declare.
4542         * tui/tui-win.c (tui_win_info::forward_scroll)
4543         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4544         (tui_win_info::right_scroll): Rename and update.
4545         (tui_scroll_forward_command, tui_scroll_backward_command)
4546         (tui_scroll_left_command, tui_scroll_right_command): Update.
4547         (tui_scroll): Remove.
4548         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4549         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4550         from tui_vertical_source_scroll.
4551         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4552         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4553         from tui_vertical_disassem_scroll.
4554         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4555         do_scroll_horizontal>: New methods.
4556         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4557         Likewise.
4558         (struct tui_source_window_base): Add do_scroll_horizontal.
4559         (struct tui_source_window, struct tui_disasm_window): Add
4560         do_scroll_vertical.
4561         (struct tui_data_window, struct tui_cmd_window): Add
4562         do_scroll_horizontal and do_scroll_vertical.
4563         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4564
4565 2019-06-25  Tom Tromey  <tom@tromey.com>
4566
4567         * tui/tui-data.h (struct tui_source_window_base): New struct.
4568         (struct tui_source_window): Derive from tui_source_window_base.
4569         (struct tui_disasm_window): New struct.
4570         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4571         from tui_source_window::clear_detail.
4572         (tui_source_window_base): Rename from tui_source_window.
4573         (~tui_source_window_base): Rename from ~tui_source_window.
4574         (tui_alloc_win_info): Create a tui_disasm_window.
4575
4576 2019-06-25  Tom Tromey  <tom@tromey.com>
4577
4578         * tui/tui-data.h (struct tui_source_window)
4579         (struct tui_data_window): Declare destructors.
4580         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4581         destructors.
4582         (tui_win_info): Simplify.
4583
4584 2019-06-25  Tom Tromey  <tom@tromey.com>
4585
4586         * tui/tui-winsource.c (tui_display_main)
4587         (tui_update_source_windows_with_addr)
4588         (tui_update_all_breakpoint_info): Update.
4589         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4590         (new_height_ok, parse_scrolling_args): Update.
4591         * tui/tui-stack.c (tui_show_frame_info): Update.
4592         * tui/tui-data.h (struct tui_list): Remove.
4593         (tui_source_windows): Return a reference to a std::vector.
4594         * tui/tui-data.c (source_windows): Now a std::vector.
4595         (tui_source_windows): Change return type.
4596         (tui_clear_source_windows): Rewrite.
4597         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4598         (tui_free_all_source_wins_content): Rewrite.
4599
4600 2019-06-25  Tom Tromey  <tom@tromey.com>
4601
4602         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4603         (struct tui_data_window, struct tui_cmd_window): Declare
4604         clear_detail method.
4605         * tui/tui-data.c (tui_source_window::clear_detail)
4606         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4607         methods.
4608         (tui_clear_win_detail): Simplify.
4609
4610 2019-06-25  Tom Tromey  <tom@tromey.com>
4611
4612         * tui/tui-layout.c (make_source_window, make_disasm_window)
4613         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4614         Return the new window.
4615         (show_source_disasm_command, show_data)
4616         (show_source_or_disasm_and_command): Update.
4617
4618 2019-06-25  Tom Tromey  <tom@tromey.com>
4619
4620         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4621         parameter.  Return the new window.
4622         (show_source_disasm_command): Update and remove NULL check.
4623         (show_source_or_disasm_and_command): Update.
4624
4625 2019-06-25  Tom Tromey  <tom@tromey.com>
4626
4627         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4628
4629 2019-06-25  Tom Tromey  <tom@tromey.com>
4630
4631         * tui/tui-data.h (struct tui_win_info): Make constructor
4632         protected.  Make destructor virtual.  Add initializers.
4633         (tui_source_window, tui_data_window, tui_cmd_window): New
4634         classes.
4635         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4636         constructor.  Add "type" parameter.
4637         (tui_source_window, tui_data_window, tui_cmd_window): New
4638         constructors.
4639         (tui_alloc_win_info): Instantiate the appropriate subclass.
4640
4641 2019-06-25  Tom Tromey  <tom@tromey.com>
4642
4643         * tui/tui-win.c (tui_resize_all): Use delete.
4644         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4645         destructor.
4646         (tui_free_window): Don't declare.
4647         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4648         Update.
4649
4650 2019-06-25  Tom Tromey  <tom@tromey.com>
4651
4652         * tui/tui-data.h (struct tui_win_info): Add constructor.
4653         * tui/tui-data.c (tui_alloc_win_info): Use new.
4654         (tui_free_window): Use delete.
4655
4656 2019-06-22  Tom Tromey  <tom@tromey.com>
4657
4658         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4659         declare.
4660         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4661
4662 2019-06-22  Tom Tromey  <tom@tromey.com>
4663
4664         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4665         declare.
4666         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4667
4668 2019-06-22  Tom de Vries  <tdevries@suse.de>
4669
4670         * dwarf2read.c (create_addrmap_from_aranges)
4671         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4672         instead of '%zu'.
4673
4674 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4675
4676         * dwarf2read.h (dwarf2_section_info_def): Remove.
4677         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4678         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4679         std::vector<dwarf2_section_info>.
4680         (struct dwo_file) <~dwo_file>: Remove.
4681         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4682         types field.
4683         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4684         (dwarf2_read_debug_names): Likewise.
4685         (create_debug_types_hash_table): Change parameter type to
4686         array_view, adjust code accordingly.
4687         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4688         (partial_die_info::fixup): Likewise.
4689         (determine_prefix): Likewise.
4690         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4691
4692 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4693
4694         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4695         gdb_bfd_ref_ptr.
4696         <~dwo_file>: Remove call to gdb_bfd_unref.
4697         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4698         gdb_bfd_ref_ptr::get.
4699
4700 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4701
4702         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4703         type to htab_up.
4704         * dwarf2read.c (struct dwo_file): Initialize fields.
4705         <~dwo_file>: New.
4706         (free_dwo_file): Remove, move content to ~dwo_file.
4707         (struct dwo_file_deleter): Remove.
4708         (dwo_file_up>: Remove custom deleter.
4709         (free_dwo_files): Remove.
4710         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4711         dwo_files.
4712         (process_skeletonless_type_units): Call unique_ptr::get.
4713         (allocate_dwo_file_hash_table): Add deleter to created hash
4714         table.  Change return type to htab_up.
4715         (lookup_dwo_file_slot): Don't memset dwo_file, call
4716         unique_ptr::get.
4717         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4718         (create_dwo_unit_in_dwp_v2): Likewise.
4719         (open_and_init_dwo_file): Likewise.
4720         (free_dwo_file_from_slot): Remove.
4721
4722 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4723
4724         * dwarf2read.h (struct dwarf2_section_info) <readin,
4725         is_virtual>: Change type to bool.
4726         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4727         true instead of 1.
4728
4729 2019-06-19  Tom Tromey  <tom@tromey.com>
4730
4731         * tui/tui-data.h (tui_init_content_element): Don't declare.
4732
4733 2019-06-19  Tom Tromey  <tom@tromey.com>
4734
4735         * tui/tui-data.h (tui_init_win_info): Don't declare.
4736
4737 2019-06-19  Tom de Vries  <tdevries@suse.de>
4738
4739         * dwarf2read.h (abstract_to_concrete): Change type to
4740         std::unordered_map<sect_offset, std::vector<sect_offset>,
4741         gdb::hash_enum<sect_offset>>.
4742
4743 2019-06-19  Tom Tromey  <tromey@adacore.com>
4744
4745         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4746         EVAL_AVOID_SIDE_EFFECTS specially.
4747
4748 2019-06-19  Tom Tromey  <tromey@adacore.com>
4749
4750         * source-cache.c (highlighter): New global.
4751         (source_cache::get_source_lines): Create a highlighter on demand.
4752
4753 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4754
4755         * defs.h (deprecated_interactive_hook): Delete declaration.
4756         * interps.c (clear_interpreter_hooks): Remove use of
4757         deprecated_interactive_hook.
4758         * top.c (deprecated_interactive_hook): Delete definition.
4759         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4760
4761 2019-06-18  Tom de Vries  <tdevries@suse.de>
4762
4763         PR gdb/24515
4764         * dwarf2read.h (abstract_to_concrete): Change type from
4765         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4766         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4767         * dwarf2read.c (read_variable): Update.
4768         (dwarf2_fetch_die_loc_sect_off): Update.
4769
4770 2019-06-17  Tom de Vries  <tdevries@suse.de>
4771
4772         PR gdb/24617
4773         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4774         accessing parent[parent_len - 1].
4775
4776 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4777
4778         PR gdb/24364
4779         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4780         call dtrace_process_dof with NULL dof.
4781
4782 2019-06-16  Tom de Vries  <tdevries@suse.de>
4783
4784         PR gdb/24445
4785         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4786
4787 2019-06-16  Tom Tromey  <tom@tromey.com>
4788
4789         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4790         (make_all_visible): Use address of member.
4791
4792 2019-06-16  Tom Tromey  <tom@tromey.com>
4793
4794         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4795         (tui_free_window, free_content, free_content_elements): Remove
4796         unnecessary cast.
4797         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4798         cast.
4799         * tui/tui-regs.c (tui_show_register_group)
4800         (tui_display_registers_from, tui_display_reg_element_at_line):
4801         Remove unnecessary cast.
4802
4803 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4804
4805         * linux-nat.c (normal_mask): Delete.
4806         (_initialize_linux_nat): Don't initialise normal_mask.
4807
4808 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4809
4810         PR gdb/24445
4811         * dwarf-index-write.h (write_psymtabs_to_index): Add
4812         dwz_basename parameter.
4813         * dwarf-index-write.c (write_gdbindex): Move file writing to
4814         write_gdbindex_1.  Change return type void.
4815         (assert_file_size): Move up, remove filename parameter.
4816         (write_gdbindex_1): New function.
4817         (write_debug_names): Change return type to void, call
4818         assert_file_size.
4819         (struct index_wip_file): New struct.
4820         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4821         file logic to index_wip_file.  Write index for dwz file if
4822         needed.
4823         (save_gdb_index_command): Pass basename of dwz file, if present.
4824         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4825         build-id of dwz file, if present.
4826         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4827         (dwarf2_get_dwz_file): Likewise.
4828         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4829         (dwarf2_get_dwz_file): Likewise.
4830
4831 2019-06-16  Tom Tromey  <tom@tromey.com>
4832
4833         * coffread.c (process_coff_symbol): Use xstrdup.
4834         * value.c (create_internalvar): Use xstrdup.
4835
4836 2019-06-16  Tom Tromey  <tom@tromey.com>
4837
4838         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4839         * breakpoint.c (stopin_command, stopat_command)
4840         (until_break_command, decode_location_default): Remove unnecessary
4841         cast.
4842         * utils.c (subset_compare): Remove unnecessary cast.
4843         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4844         cast.
4845         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4846         cast.
4847         * infcmd.c (path_command): Remove unnecessary cast.
4848         * coffread.c (decode_type): Remove unnecessary cast.
4849         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4850         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4851         * tui/tui-stack.c (tui_show_locator_content)
4852         (tui_show_frame_info): Remove unnecessary cast.
4853         * tui/tui-win.c (tui_scroll_forward_command)
4854         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4855         (parse_scrolling_args): Remove unnecessary cast.
4856         * tui/tui-data.c (init_win_info, tui_del_window)
4857         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4858         (free_content_elements): Remove unnecessary cast.
4859         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4860         unnecessary cast.
4861         * tui/tui-source.c (tui_set_source_content)
4862         (tui_vertical_source_scroll): Remove unnecessary cast.
4863         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4864         cast.
4865         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4866         * tui/tui-regs.c (tui_display_registers_from)
4867         (tui_display_register): Remove unnecessary cast.
4868         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4869         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4870         (make_visible): Remove unnecessary cast.
4871         * tui/tui-winsource.c (tui_erase_source_content)
4872         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4873         unnecessary cast.
4874         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4875         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4876         * stabsread.c (read_type, read_array_type, read_range_type):
4877         Remove unnecessary cast.
4878         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4879         (parse_symbol, parse_type, upgrade_type, parse_external)
4880         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4881         unnecessary cast.
4882         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4883
4884 2019-06-16  Tom Tromey  <tom@tromey.com>
4885
4886         * tui/tui-data.c (tui_alloc_generic_win_info)
4887         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4888         checks.
4889
4890 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4891             Andrew Burgess  <andrew.burgess@embecosm.com>
4892
4893         * f-typeprint.c (f_print_type): Don't return early for not
4894         associated or not allocated types.
4895         (f_type_print_varspec_suffix): Add print_rank parameter and print
4896         ranks of array types in case they dangling.
4897         (f_type_print_base): Add print_rank parameter.
4898
4899 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4900
4901         * NEWS: Mention new MI commands.
4902         * break-catch-throw.c (enum exception_event_kind): Move to
4903         breakpoint.h.
4904         (print_mention_exception_catchpoint): Output text as a single
4905         message.
4906         (catch_exception_command_1): Rename to...
4907         (catch_exception_event): ...this, make non-static, update header
4908         command, and change some parameter types.
4909         (catch_catch_command): Update for changes to
4910         catch_exception_command_1.
4911         (catch_throw_command): Likewise.
4912         (catch_rethrow_command): Likewise.
4913         * breakpoint.c (enum exception_event_kind): Delete.
4914         * breakpoint.h (enum exception_event_kind): Moved here from
4915         break-catch-throw.c.
4916         (catch_exception_event): Declare.
4917         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4918         (mi_cmd_catch_throw): New function.
4919         (mi_cmd_catch_rethrow): New function.
4920         (mi_cmd_catch_catch): New function.
4921         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4922         'catch-catch' entries.
4923         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4924         (mi_cmd_catch_rethrow): Declare.
4925         (mi_cmd_catch_catch): Declare.
4926
4927 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4928
4929         * annotate.c (annotate_source_line): Change return type to void,
4930         update implementation to match.
4931         * annotate.h (annotate_source_line): Change return type to void,
4932         update header comment.
4933         * stack.c (print_frame_info): Don't change what frame information
4934         is printed based on whether annotations are on or not.
4935
4936 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4937
4938         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4939         (annotate_source): Make static.
4940         (annotate_source_line): Moved from source.c and renamed from
4941         identify_source_line.  Update the return type.
4942         * annotate.h (annotate_source): Delete declaration.
4943         (annotate_source_line): Declaration moved from source.h, and
4944         renamed from identify_source_line.  Return type updated.
4945         * source.c (identify_source_line): Moved to annotate.c and renamed
4946         to annotate_source_line.
4947         (info_line_command): Remove check of annotation_level.
4948         * source.h (identify_source_line): Move declaration to annotate.h
4949         and rename to annotate_source_line.
4950         * stack.c: Add 'annotate.h' include.
4951         (print_frame_info): Remove check of annotation_level before
4952         calling annotate_source_line.
4953
4954 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4955
4956         * source-cache.c (source_cache::get_plain_source_lines): Use
4957         open_source_file_with_line_charpos instead of just
4958         open_source_file, remove call to find_source_lines.
4959         (source_cache::get_source_lines): Likewise.
4960         * source.c (find_source_lines): Make static.
4961         (get_filename_and_charpos): Renamed into...
4962         (open_source_file_with_line_charpos): ..this along with changes to
4963         return a scoped_fd, and some other minor clean ups.
4964         (identify_source_line): Use open_source_file_with_line_charpos.
4965         (search_command_helper): Use open_source_file_with_line_charpos
4966         instead of just open_source_file, remove call to
4967         find_source_lines.
4968         * source.h (open_source_file_with_line_charpos): Declare new
4969         function.
4970         (find_source_lines): Delete declaration.
4971
4972 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4973
4974         * source.c (get_filename_and_charpos): Remove fullname
4975         parameter.
4976         (identify_source_line): Update call to get_filename_and_charpos.
4977
4978 2019-06-14  Tom Tromey  <tromey@adacore.com>
4979
4980         PR gdb/24502:
4981         * ui-style.h (skip_ansi_escape): Update comment.
4982         * ui-file.h (class no_terminal_escape_file): New class.
4983         * ui-file.c (no_terminal_escape_file::write)
4984         (no_terminal_escape_file::puts): New methods.
4985         * cli/cli-logging.c (handle_redirections): Use
4986         no_terminal_escape_file.
4987
4988 2019-06-14  Tom Tromey  <tromey@adacore.com>
4989
4990         * NEWS: Move convenience variable news above Python news.
4991
4992 2019-06-14  Tom Tromey  <tom@tromey.com>
4993
4994         * gnulib: Move directory to top-level.
4995         * configure.ac: Don't configure gnulib.
4996         * configure: Rebuild.
4997         * common/common-defs.h: Use new path to gnulib.
4998         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4999         (GNULIB_H): Remove.
5000         (INCGNU): Look in new gnulib location.
5001         (HFILES_NO_SRCDIR): Remove gnulib files.
5002         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5003         (generated_files): Remove GNULIB_H.
5004         ($(LIBGNU), all-lib): Remove targets.
5005         (distclean): Don't mention GNULIB_BUILDDIR.
5006         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5007
5008 2019-06-14  Tom Tromey  <tromey@adacore.com>
5009
5010         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5011         Warn if symbol file does not provide any symbols.
5012
5013 2019-06-14  Tom Tromey  <tromey@adacore.com>
5014
5015         * source.c (find_and_open_source): Respect basenames_may_differ.
5016
5017 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5018
5019         * annotate.c (annotate_breakpoints_invalid): Make use of
5020         scoped_restore_terminal_state.
5021         (annotate_frames_invalid): Likewise.
5022
5023 2019-06-14  Tom Tromey  <tromey@adacore.com>
5024
5025         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5026         allow assignment to an internalvar.
5027
5028 2019-06-14  Tom Tromey  <tromey@adacore.com>
5029
5030         * ada-lex.l: Allow "_" in attribute names.
5031
5032 2019-06-14  Tom Tromey  <tromey@adacore.com>
5033
5034         PR gdb/24653:
5035         * regcache.c (registers_changed): Don't call alloca.
5036         * top.c (execute_command): Don't call alloca.
5037
5038 2019-06-13  Pedro Alves  <palves@redhat.com>
5039
5040         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5041         'expression'.  When parsing an expression, error out if there's
5042         junk after "unlimited".
5043         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5044         (do_set_command): Adjust calls to is_unlimited_literal.
5045
5046 2019-06-13  Pedro Alves  <palves@redhat.com>
5047
5048         * compile/compile.c (make_compile_options_def_group): Add braces
5049         around array_view initializer.
5050         * thread.c (make_thread_apply_all_options_def_group)
5051         (make_thread_apply_all_options_def_group): Likewise.
5052
5053 2019-06-13  Pedro Alves  <palves@redhat.com>
5054
5055         * NEWS (New commands): Mention "maint test-options
5056         require-delimiter", "maint test-options unknown-is-error", "maint
5057         test-options unknown-is-operand" and "maint show
5058         test-options-completion-result".
5059         (New command options, command completion): New section.
5060         (Completion improvements): New section.
5061         Mention that you can abbreviate "unlimited".
5062
5063 2019-06-13  Pedro Alves  <palves@redhat.com>
5064
5065         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5066         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5067         * unittests/cli-utils-selftests.c (test_parse_flags)
5068         (test_parse_flags_qcs): Delete.
5069         (test_cli_utils): Don't call deleted functions.
5070
5071 2019-06-13  Pedro Alves  <palves@redhat.com>
5072
5073         * thread.c: Include "cli/cli-option.h".
5074         (tp_array_compar_ascending): Global.
5075         (tp_array_compar): Delete function.
5076         (tp_array_compar_ascending, tp_array_compar_descending): New
5077         functions.
5078         (ascending_option_def, qcs_flag_option_def)
5079         (thr_qcs_flags_option_defs)
5080         (make_thread_apply_all_options_def_group)
5081         (make_thread_apply_options_def_group): New.
5082         (thread_apply_all_command): Use gdb::option::process_options.
5083         (thread_apply_command_completer)
5084         (thread_apply_all_command_completer): New.
5085         (thread_apply_command): Use gdb::option::process_options.
5086         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5087         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5088         to generate help text of "thread apply".  Adjust "taas"'s help.
5089         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5090         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5091
5092 2019-06-13  Pedro Alves  <palves@redhat.com>
5093
5094         * thread.c (thread_apply_command): Check for invalid TID with
5095         isdigit instead of !isalpha.
5096
5097 2019-06-13  Pedro Alves  <palves@redhat.com>
5098
5099         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5100         (validate_flags_qcs): New.
5101         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5102         (validate_flags_qcs): Declare.
5103         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5104         (make_frame_apply_options_def_group): New.
5105         (frame_apply_command_count): Process options with
5106         gdb::option::process_options.
5107         (frame_apply_completer): New.
5108         (frame_apply_level_completer, frame_apply_all_completer)
5109         (frame_apply_completer): New.
5110         (_initialize_stack): Update help of "frame apply", "frame apply
5111         level", "frame apply all" and "faas" to mention supported options
5112         and install command completers.
5113         * stack.h (frame_apply_all_completer): Declare.
5114         * thread.c: Include "stack.h".
5115         (tfaas_command): Add "--".
5116         (_initialize_thread): Update help "tfaas" to mention supported
5117         options and install command completer.
5118
5119 2019-06-13  Pedro Alves  <palves@redhat.com>
5120
5121         * completer.c (complete_nested_command_line): New.
5122         (gdb_completion_word_break_characters_throw): Add assertion.
5123         * completer.h (complete_nested_command_line): Declare.
5124
5125 2019-06-13  Pedro Alves  <palves@redhat.com>
5126
5127         * stack.c (parse_backtrace_qualifiers): New.
5128         (backtrace_command): Use it.
5129         (backtrace_command_completer): Complete on qualifiers.
5130
5131 2019-06-13  Pedro Alves  <palves@redhat.com>
5132
5133         * frame.c: Include "cli/cli-option.h.
5134         (user_set_backtrace_options): New.
5135         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5136         Delete.
5137         (get_prev_frame): Adjust.
5138         (boolean_option_def, uinteger_option_def)
5139         (set_backtrace_option_defs): New.
5140         (_initialize_frame): Adjust and use
5141         gdb::option::add_setshow_cmds_for_options to install "set
5142         backtrace past-main" and "set backtrace past-entry".
5143         * frame.h: Include "cli/cli-option.h".
5144         (struct frame_print_options): Forward declare.
5145         (print_frame_arguments_all, print_frame_arguments_scalars)
5146         (print_frame_arguments_none): Declare.
5147         (print_entry_values): Delete declaration.
5148         (struct frame_print_options, user_frame_print_options): New.
5149         (struct set_backtrace_options): New.
5150         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5151         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5152         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5153         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5154         (list_args_or_locals): Add frame_print_options parameter.
5155         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5156         * python/py-framefilter.c (enumerate_args): Pass down
5157         USER_FRAME_PRINT_OPTIONS.
5158         * stack.c: Include "cli/cli-option.h".
5159         (print_frame_arguments_all, print_frame_arguments_scalars)
5160         (print_frame_arguments_none): Declare.
5161         (print_raw_frame_arguments, print_entry_values): Delete.
5162         (user_frame_print_options): New.
5163         (boolean_option_def, enum_option_def, frame_print_option_defs):
5164         New.
5165         (struct backtrace_cmd_options): New.
5166         (bt_flag_option_def): New.
5167         (backtrace_command_option_defs): New.
5168         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5169         (print_frame_arg, read_frame_arg, print_frame_args)
5170         (print_frame_info, print_frame): Add frame_print_options parameter
5171         and use it.
5172         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5173         (backtrace_command_1): Add frame_print_options and
5174         backtrace_cmd_options parameters and use them.
5175         (make_backtrace_options_def_group): New.
5176         (backtrace_command): Process command options with
5177         gdb::option::process_options.
5178         (backtrace_command_completer): New.
5179         (_initialize_stack): Extend "backtrace"'s help to mention
5180         supported options.  Install completer for "backtrace".
5181         Install some settings commands with add_setshow_cmds_for_options.
5182
5183 2019-06-13  Pedro Alves  <palves@redhat.com>
5184
5185         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5186         and that "set/show print raw frame-arguments" are now deprecated.
5187
5188         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5189         command.
5190         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5191         * stack.c (_initialize_stack): Install "set/show print
5192         raw-frame-arguments", and deprecate "set/show print raw
5193         frame-arguments".
5194         * valprint.c (_initialize_valprint): Deprecate "set/show print
5195         raw".
5196
5197 2019-06-13  Pedro Alves  <palves@redhat.com>
5198
5199         * compile/compile.c (struct compile_options): New.
5200         (compile_flag_option_def, compile_command_option_defs)
5201         (make_compile_options_def_group): New.
5202         (compile_file_command): Handle options with
5203         gdb::option::process_options.
5204         (compile_file_command_completer): New function.
5205         (compile_code_command): Handle options with
5206         gdb::option::process_options.
5207         (compile_code_command_completer): New function.
5208         (_initialize_compiler): Install completers for "compile code" and
5209         "compile file".  Mention available options in "compile code" and
5210         "compile code"'s help.
5211         * completer.c (advance_to_completion_word): New, factored out from
5212         ...
5213         (advance_to_expression_complete_word_point): ... this.
5214         (advance_to_filename_complete_word_point): New.
5215         * completer.h (advance_to_filename_complete_word_point): New
5216         declaration.
5217
5218 2019-06-13  Pedro Alves  <palves@redhat.com>
5219
5220         * compile/compile.c: Include "cli/cli-option.h".
5221         (compile_print_value): Scope data pointer is now a
5222         value_print_options pointer; adjust.
5223         (compile_print_command): Process options.  Scope data pointer is
5224         now a value_print_options pointer; adjust.
5225         (_initialize_compile): Update "compile print"'s help to include
5226         supported options.  Install a completer for "compile print".
5227         * cp-valprint.c (show_vtblprint, show_objectprint)
5228         (show_static_field_print): Delete.
5229         (_initialize_cp_valprint): Don't install "set print
5230         static-members", "set print vtbl", "set print object" here.
5231         * printcmd.c: Include "cli/cli-option.h" and
5232         "common/gdb_optional.h".
5233         (print_command_parse_format): Rework to fill in a
5234         value_print_options instead of a format_data.
5235         (print_value): Change parameter type from format_data pointer to
5236         value_print_options reference.  Adjust.
5237         (print_command_1): Process options.  Adjust to pass down a
5238         value_print_options.
5239         (print_command_completer): New.
5240         (_initialize_printcmd): Install print_command_completer as
5241         handle_brkchars completer for the "print" command.  Update
5242         "print"'s help to include supported options.
5243         * valprint.c: Include "cli/cli-option.h".
5244         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5245         here from cp-valprint.c.
5246         (boolean_option_def, uinteger_option_def)
5247         (value_print_option_defs, make_value_print_options_def_group):
5248         New.  Use gdb::option::add_setshow_cmds_for_options to install
5249         "set print elements", "set print null-stop", "set print repeats",
5250         "set print pretty", "set print union", "set print array", "set
5251         print address", "set print symbol", "set print array-indexes".
5252         * valprint.h: Include <string> and "cli/cli-option.h".
5253         (make_value_print_options_def_group): Declare.
5254         (print_value): Change parameter type from format_data pointer to
5255         value_print_options reference.
5256         (print_command_completer): Declare.
5257
5258 2019-06-13  Pedro Alves  <palves@redhat.com>
5259
5260         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5261         (COMMON_SFILES): Add maint-test-settings.c.
5262         * cli/cli-decode.c (boolean_enums): New global, factored out from
5263         ...
5264         (add_setshow_boolean_cmd): ... here.
5265         * cli/cli-decode.h (boolean_enums): Declare.
5266         * cli/cli-option.c: New file.
5267         * cli/cli-option.h: New file.
5268         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5269         factored out from ...
5270         (parse_cli_boolean_value(const char *)): ... this.
5271         (is_unlimited_literal): Change parameter type to pointer to
5272         pointer.  Adjust and advance ARG pointer.
5273         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5274         (parse_cli_var_enum): New, factored out from ...
5275         (do_set_command): ... this.  Adjust.
5276         * cli/cli-setshow.h (parse_cli_boolean_value)
5277         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5278         (parse_cli_var_enum): Declare.
5279         * cli/cli-utils.c: Include "cli/cli-option.h".
5280         (get_ulongest): New.
5281         * cli/cli-utils.h (get_ulongest): Declare.
5282         (check_for_argument): New overloads.
5283         * maint-test-options.c: New file.
5284
5285 2019-06-13  Pedro Alves  <palves@redhat.com>
5286
5287         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5288         parse a range if "-" is at the end of the string.
5289
5290 2019-06-13  Pedro Alves  <palves@redhat.com>
5291
5292         * cli/cli-setshow.c (parse_auto_binary_operation)
5293         (parse_cli_boolean_value): Don't allow "o".
5294
5295 2019-06-13  Pedro Alves  <palves@redhat.com>
5296
5297         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5298         * NEWS: Mention maint test-settings KIND.
5299         * maint-test-settings.c: New file.
5300
5301 2019-06-13  Pedro Alves  <palves@redhat.com>
5302
5303         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5304         completer.
5305         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5306         "set" completers.
5307
5308 2019-06-13  Pedro Alves  <palves@redhat.com>
5309
5310         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5311         after item.
5312
5313 2019-06-13  Pedro Alves  <palves@redhat.com>
5314
5315         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5316
5317 2019-06-13  Pedro Alves <palves@redhat.com>
5318
5319         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5320         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5321         call.
5322         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5323         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5324         calls.
5325         (check_for_argument): Skip spaces after argument.
5326
5327 2019-06-13  Pedro Alves  <palves@redhat.com>
5328
5329         * thread.c (thread_apply_command): Adjust TID parsing.
5330         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5331         detected before end of string.
5332         (tid_is_in_list): Error out if LIST is invalid.
5333
5334 2019-06-13  Pedro Alves  <palves@redhat.com>
5335
5336         * completer.c (complete_line_internal_1): Rewind completion word
5337         point.
5338         (completion_tracker::advance_custom_word_point_by): Change
5339         parameter type to int.
5340         * completer.h (completion_tracker::advance_custom_word_point_by):
5341         Likewise.
5342
5343 2019-06-13  Pedro Alves  <palves@redhat.com>
5344
5345         * completer.c (advance_to_completion_word): Handle delimiters.
5346
5347 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5348
5349         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5350
5351 2019-06-11  Tom Tromey  <tom@tromey.com>
5352
5353         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5354         (xmalloc_failed): Move to alloc.c.
5355         * alloc.c: New file.
5356         * Makefile.in (COMMON_SFILES): Add alloc.c.
5357
5358 2019-06-11  Tom Tromey  <tom@tromey.com>
5359
5360         * nat/linux-waitpid.c: Don't include server.h.
5361         (linux_debug): Remove.
5362         (my_waitpid): Update.
5363
5364 2019-06-11  Tom Tromey  <tromey@adacore.com>
5365
5366         * infcall.c (_initialize_infcall): Remove trailing newline from
5367         help.
5368         * user-regs.c (_initialize_user_regs): Remove trailing newline
5369         from help.
5370         * typeprint.c (_initialize_typeprint): Remove trailing newline
5371         from help.
5372         * reverse.c (_initialize_reverse): Remove trailing newlines from
5373         help.
5374         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5375         from help.
5376         * language.c (add_set_language_command): Remove trailing newline
5377         from help.
5378         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5379         help.
5380         * disasm.c (_initialize_disasm): Remove trailing newline from
5381         help.
5382         * top.c (init_main): Remove trailing newline from help.
5383         * interps.c (_initialize_interpreter): Remove trailing newline
5384         from help.
5385         * btrace.c (_initialize_btrace): Remove trailing newlines from
5386         help.
5387         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5388         from help.
5389         * python/python.c (_initialize_python): Remove trailing newline
5390         from help.
5391         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5392         help.
5393         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5394         from help.  Reformat some text.
5395         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5396         from help.
5397         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5398         newline from help.
5399
5400 2019-06-11  Tom Tromey  <tromey@adacore.com>
5401
5402         * darwin-nat.c (darwin_decode_exception_message)
5403         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5404
5405 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5406
5407         * valops.c (value_slice): Check for not allocated or not
5408         associated values.
5409
5410 2019-06-10  Tom de Vries  <tdevries@suse.de>
5411
5412         PR gdb/24618
5413         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5414         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5415         invalid.
5416
5417 2019-06-10  Tom de Vries  <tdevries@suse.de>
5418
5419         PR gdb/24611
5420         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5421         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5422
5423 2019-06-10  Tom de Vries  <tdevries@suse.de>
5424
5425         PR symtab/24545
5426         * symtab.c (struct demangled_name_entry): Add language field.
5427         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5428         static minimal symbol".  Set and use language field.
5429
5430 2019-06-10  Tom Tromey  <tromey@adacore.com>
5431
5432         * ada-lang.c (_initialize_ada_language): Update help text.
5433
5434 2019-06-10  Tom Tromey  <tromey@adacore.com>
5435
5436         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5437         with a newline.
5438         * guile/guile.c (handle_boot_error): Don't end warning with a
5439         newline.
5440         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5441         warning with a newline.
5442         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5443         newline.
5444         (s12z_frame_cache): Likewise.
5445         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5446         a newline.
5447         * solib-svr4.c (disable_probes_interface): Don't end warning with
5448         a newline.
5449         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5450         newline.
5451         * python/python.c (do_finish_initialization): Don't end warning
5452         with a newline.
5453
5454 2019-06-10  Tom Tromey  <tom@tromey.com>
5455
5456         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5457         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5458         gdbpy_enter.
5459
5460 2019-06-10  Tom Tromey  <tromey@adacore.com>
5461
5462         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5463         data.
5464         (elf_new_init): Don't call stabsread_new_init.
5465         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5466         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5467         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5468
5469 2019-06-10  Tom de Vries  <tdevries@suse.de>
5470
5471         PR symtab/16264
5472         PR symtab/24517
5473         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5474
5475 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5476
5477         * source.c (find_and_open_source): Also rewrite relative file
5478         names.
5479
5480 2019-04-26  Amos Bird  <amosbird@gmail.com>
5481
5482         * annotate.c (annotate_thread_exited): Add "thread-exited"
5483         annotation.
5484
5485 2019-06-06  Tom Tromey  <tromey@adacore.com>
5486
5487         * maint.h (class scoped_command_stats): Use
5488         DISABLE_COPY_AND_ASSIGN.
5489         <print_time>: New method.
5490         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5491         print_time.
5492         (scoped_command_stats::print_time): New method.
5493
5494 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5495
5496         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5497         instructions of lengths 6 or 8 bytes.
5498
5499 2019-06-04  Pedro Alves  <palves@redhat.com>
5500
5501         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5502
5503         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5504         * breakpoint.c (condition_completer): Likewise.
5505         * cli/cli-dump.c (scan_expression): Likewise.
5506         * common/filestuff.c (mkdir_recursive): Likewise.
5507         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5508         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5509         (gdb_abspath): Likewise.
5510         * compile/compile-cplus-types.c
5511         (compile_cplus_instance::decl_name): Likewise.
5512         * completer.c (complete_explicit_location):
5513         (signal_completer, reg_or_group_completer_1): Likewise.
5514         * cp-support.c (cp_remove_params_if_any): Likewise.
5515         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5516         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5517         * infcmd.c (strip_bg_char): Likewise.
5518         * linespec.c (copy_token_string): Likewise.
5519         * mi/mi-main.c (output_cores): Likewise.
5520         * psymtab.c (psymtab_search_name):
5521         * symfile.c (test_set_ext_lang_command): Likewise.
5522         * target.c (target_fileio_read_stralloc): Likewise.
5523         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5524         * value.c (complete_internalvar): Likewise.
5525
5526 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5527
5528         Add objfile property to gdb.Type.
5529         * NEWS: Mention Python API addition.
5530         * python/py-type.c (typy_get_objfile): New method.
5531
5532 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5533
5534         * NEWS: Mention the new set|show style [title|highlight].
5535         Mention changes to "show style", "help" and "apropos".
5536
5537 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5538
5539         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5540         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5541         instead of print_help_for_command.
5542         (print_doc_of_command): New function.
5543         (help_list): Add 'apropos -v word' suggestion.
5544         (print_help_for_command): Style the command name using title style.
5545         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5546         (_initialize_cli_cmds): Describe -v in apropos_command help.
5547
5548 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5549
5550         * cli/cli-style.h (cli_style_option): Add name in constructor,
5551         add m_name class member, add constructor with intensity,
5552         add name class function.
5553         (cli_style_option::add_setshow_commands): Remove name argument.
5554         (highlight_style, title_style): New styles.
5555         * cli/cli-style.c (do_show): New function that shows a style
5556         characteristic styling the style name with itself.
5557         (set_style_name): New function.
5558         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5559         Update all callers according to the changes in cli/cli-style.h.
5560         * utils.h (fputs_highlighted): New function.
5561         * utils.c (fputs_highlighted): Likewise.
5562
5563 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5564
5565         * NEWS: Mention new pipe command and new convenience variables.
5566
5567 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5568
5569         * cli/cli-cmds.c (pipe_command): New function.
5570         (_initialize_cli_cmds): Call add_com for pipe_command.
5571         Define | as an alias for pipe.
5572         (exit_status_set_internal_vars): New function.
5573         (shell_escape): Call exit_status_set_internal_vars.
5574         cli/cli-decode.c (find_command_name_length): Recognize | as
5575         a single character command.
5576
5577 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5578
5579         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5580         top.c (execute_command_to_ui_file): New function, mostly a copy
5581         of execute_command_to_string.
5582         (execute_command_to_string): Implement by calling
5583         execute_command_to_ui_file.
5584
5585 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5586
5587         * top.h (saved_command_line): Remove declaration.
5588         * top.c (previous_saved_command_line, previous_repeat_arguments):
5589         New variables.
5590         (saved_command_line): Make static, define together with other
5591         'repeat variables'.
5592         (dont_repeat): Clear repeat_arguments.
5593         (repeat_previous, get_saved_command_line, save_command_line):
5594         New functions.
5595         (gdb_init): Initialize saved_command_line
5596         and previous_saved_command_line.
5597         * main.c (captured_main_1): Remove saved_command_line initialization.
5598         * event-top.c (handle_line_of_input): Update to use
5599         the new 'repeat' related functions instead of direct access to
5600         saved_command_line.
5601         * command.h (repeat_previous, get_saved_command_line,
5602         save_command_line): New declarations.
5603         (dont_repeat): Add comment.
5604
5605 2019-05-30  Tom Tromey  <tromey@adacore.com>
5606
5607         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5608         Fix comment.
5609         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5610
5611 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5612
5613         PR cli/24587
5614         * completer.c (complete): Initialize variable word.
5615
5616 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5617
5618         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5619         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5620         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5621         'body' is NULL to the outter 'if', protecting the '!is_define'
5622         situation as well.
5623
5624 2019-05-29  Tom Tromey  <tromey@adacore.com>
5625
5626         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5627         (dwarf_unknown): New function.
5628         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5629         (dwarf_type_encoding_name): Use dwarf_unknown.
5630
5631 2019-05-29  Tom Tromey  <tromey@adacore.com>
5632
5633         PR c++/20020:
5634         * cp-valprint.c (cp_print_value_fields): Call
5635         cp_print_static_field inside "try".
5636
5637 2019-05-29  Tom Tromey  <tromey@adacore.com>
5638
5639         * inflow.c (struct terminal_info): Add default operator=.
5640         * configure: Rebuild.
5641         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5642         -Wdeprecated-copy-dtor, -Wredundant-move.
5643
5644 2019-05-29  Tom Tromey  <tromey@adacore.com>
5645
5646         * NEWS: Add entry.
5647         * infcmd.c (print_return_value_1): Handle finish_print
5648         option.
5649         (show_print_finish): New function.
5650         (_initialize_infcmd): Add "set/show print finish" commands.
5651         * valprint.c (user_print_options): Initialize new member.
5652         * valprint.h (struct value_print_options) <finish_print>: New
5653         member.
5654
5655 2019-05-28  Tom Tromey  <tromey@adacore.com>
5656
5657         * ada-lang.c (ada_remove_Xbn_suffix)
5658         (find_old_style_renaming_symbol)
5659         (parse_old_style_renaming): Remove.
5660         (ada_find_renaming_symbol): Don't call
5661         find_old_style_renaming_symbol.
5662         (ada_is_renaming_symbol): Rename from
5663         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5664         bool.  Now static.
5665         (ada_read_var_value): Update and simplify.
5666         * ada-exp.y (write_var_or_type): Remove old code.
5667
5668 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5669
5670         * event-top.c: Remove include comment.
5671         * inflow.c (class scoped_ignore_sigttou): Move from here...
5672         * inflow.h (class scoped_ignore_sigttou): ...to here.
5673         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5674         * top.c:  Remove include comment.
5675
5676 2019-05-27  Tom Tromey  <tom@tromey.com>
5677
5678         * NEWS: Fix typo.
5679
5680 2019-05-22  Tom Tromey  <tromey@adacore.com>
5681
5682         * target.c (target_follow_exec): Constify parameter.
5683         * target-delegates.c: Rebuild.
5684         * remote.c (remote_target::follow_exec): Constify parameter.
5685         * infrun.c (follow_exec): Constify parameter.
5686         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5687         (target_follow_exec): Likewise.
5688
5689 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5690
5691         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5692         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5693
5694 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5695
5696         * NEWS: Add debugredirect and testsuite sections.
5697
5698 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5699
5700         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5701         target descriptions using exclusively floating point register name
5702         aliases.
5703
5704 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5705
5706         PR gdb/18644:
5707         * f-lang.c (build_fortran_types): Handle the case where
5708         gdbarch_floatformat_for_type returns a nullptr.
5709
5710 2019-05-21  Tom de Vries  <tdevries@suse.de>
5711
5712         PR cli/24587
5713         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5714
5715 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5716
5717         PR gdb/18644:
5718         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5719         16-byte floats.
5720         * i386-tdep.c (i386_floatformat_for_type): Use
5721         floatformats_ia64_quad for the 16-byte floating point component
5722         within a fortran 32-byte complex number.
5723
5724 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5725
5726         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5727         delete default constructor.
5728         (find_partial_die): Update to return const struct.
5729         (partial_die_parent_scope): Move variable declaration into scope
5730         of its use and change its type to auto.
5731         (guess_partial_die_structure_name): Likewise.
5732         (partial_die_info::fixup): Likewise.
5733
5734 2019-05-17  Tom Tromey  <tromey@adacore.com>
5735
5736         * source.c (find_and_open_source): Remove cast.
5737
5738 2019-05-17  Tom Tromey  <tromey@adacore.com>
5739
5740         * annotate.c (annotate_source): Make "filename" const.
5741         * annotate.h (annotate_source): Use const.
5742
5743 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5744
5745         * disasm.c (set_disassembler_options): Send errors to stderr.
5746
5747 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5748
5749         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5750         (cli_interp_base::set_logging): Check debug_redirect.
5751         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5752         * cli/cli-logging.c (debug_redirect): Add static variable.
5753         (pop_output_files): Add default param.
5754         (handle_redirections): Print debug setting.
5755         (show_logging_command): Likewise.
5756         (_initialize_cli_logging): Add debugredirect command.
5757         * interps.c (current_interp_set_logging): Add debug_redirect
5758         parameter.
5759         * interps.h (set_logging): Add debug_redirect parameter.
5760         (current_interp_set_logging): Likewise.
5761         * mi/mi-common.h: Likewise.
5762         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5763
5764 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5765             Tom Tromey  <tromey@adacore.com>
5766
5767         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5768         directly.
5769         * cli/cli-interp.h (make_logging_output): Remove declaration.
5770         * cli/cli-logging.c (make_logging_output): Remove function.
5771         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5772         directly.
5773         * ui-file.c (tee_file::tee_file): Remove bools.
5774         (tee_file::~tee_file): Remove deletes.
5775         * ui-file.h (tee_file): Remove bools.
5776
5777 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5778
5779         * mi/mi-cmds.h (mi_cmd_complete): New function.
5780         * mi/mi-main.c (mi_cmd_complete): Likewise.
5781         * mi/mi-cmds.c: Define new MI command -complete.
5782         * NEWS: Mention new -complete command.
5783
5784 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5785
5786         * completer.h (complete): New function.
5787         * completer.c (complete): Likewise.
5788         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5789         function defined in completer.h.
5790
5791 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5792
5793         * MAINTAINERS (Write After Approval): Add myself.
5794
5795 2019-05-17  Tom de Vries  <tdevries@suse.de>
5796
5797         PR gdb/24094
5798         * dwarf2read.c (struct cu_partial_die_info): New struct.
5799         (find_partial_die): Return cu_partial_die_info.
5800         (partial_die_parent_scope, guess_partial_die_structure_name)
5801         (partial_die_info::fixup): Handle new return type of find_partial_die.
5802
5803 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5804
5805         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5806         "std::string", simplifying the algorithm.
5807
5808 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5809
5810         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5811         (stap_static_probe_ops::get_probes): Likewise.
5812
5813 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5814
5815         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5816         '-')" and "else if".
5817         (stap_parse_single_operand): Join checks for
5818         "gdbarch_stap_parse_special_token_p" and
5819         "gdbarch_stap_parse_special_token" in the same "if" statement.
5820         Invert check when verifying for operation on register
5821         displacement.
5822
5823 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5824
5825         * stap-probe.c (stap_get_opcode): Update comment.
5826         (stap_get_expected_argument_type): Likewise.
5827         (handle_stap_probe): Likewise.
5828
5829 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5830
5831         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5832         return type to 'bool'.  Adjust comment.  Use 'bool' when
5833         appropriate.
5834         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5835         * stap-probe.c (stap_parse_argument_1): Likewise.
5836         (stap_is_operator): Likewise.
5837         (stap_is_generic_prefix): Likewise.
5838         (stap_is_register_prefix): Likewise.
5839         (stap_is_register_indirection_prefix): Likewise.
5840         (stap_is_integer_prefix): Likewise.
5841         (stap_generic_check_suffix): Likewise.
5842         (stap_check_integer_suffix): Likewise.
5843         (stap_check_register_suffix): Likewise.
5844         (stap_check_register_indirection_suffix): Likewise.
5845         (stap_parse_register_operand): Likewise.
5846         (stap_parse_single_operand): Likewise.
5847         (stap_parse_argument_1): Likewise.
5848         (stap_probe::get_argument_count): Likewise.
5849         (stap_is_operator): Likewise.
5850
5851 2019-05-16  Tom Tromey  <tromey@adacore.com>
5852
5853         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5854         keyword to foreach.
5855
5856 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5857
5858         * linux-thread-db.c (try_thread_db_load_1): Change return type
5859         to bool.
5860         (try_thread_db_load): Likewise.
5861         (try_thread_db_load_from_pdir_1): Likewise.
5862         (try_thread_db_load_from_pdir): Likewise.
5863         (try_thread_db_load_from_sdir): Likewise.
5864         (try_thread_db_load_from_dir): Likewise.
5865         (thread_db_load_search): Likewise.
5866         (has_libpthread): Likewise.
5867         (thread_db_load): Likewise.
5868
5869 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5870
5871         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5872         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5873         NULL, and complain/return if that's the case.
5874
5875 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5876
5877         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5878         (advance, posn, abstract_read_memory): New functions.
5879         [struct mem_read_abstraction]: New struct.
5880         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5881
5882 2019-05-14  Tom Tromey  <tromey@adacore.com>
5883
5884         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5885         value is not lval_memory.
5886
5887 2019-05-14  Tom Tromey  <tromey@adacore.com>
5888
5889         * solib.c (info_sharedlibrary_command): Style the file name.
5890
5891 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5892
5893         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5894         (aarch64_vnv_type): Likewise.
5895         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5896         * common/tdesc.c: Likewise.
5897         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5898         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5899         * features/aarch64-fpu.xml: Add ieee half view.
5900         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5901         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5902         * gdbtypes.h (struct builtin_type): Likewise.
5903         (struct objfile_type): Likewise.
5904
5905 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5906
5907         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5908         typo.
5909         * location.h (string_to_event_location): Likewise.
5910
5911 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5912
5913         GDB 8.3 released.
5914
5915 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5916
5917         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5918         New variable declaration.
5919         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5920         New variable.
5921         (print_one_breakpoint): Use ui_out::test_flags and new global
5922         variable to compute use_fixed_output.
5923         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5924         Remove.
5925         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5926         (mi_multi_location_breakpoint_output_fixed): Remove.
5927         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5928         new variable.
5929         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5930         fix_multi_location_breakpoint_output flag if version >= 3.
5931         * ui-out.h (enum ui_out_flag)
5932         <fix_multi_location_breakpoint_output>: New enumerator.
5933
5934 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5935
5936         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5937
5938 2019-05-10  Tom Tromey  <tromey@adacore.com>
5939
5940         * ada-lang.c (catch_ada_completer): New function.
5941         (_initialize_ada_language): Use it.
5942
5943 2019-05-10  Tom Tromey  <tromey@adacore.com>
5944
5945         * thread.c (print_thread_info): Make "requested_threads" const.
5946         * gdbthread.h (print_thread_info): Make "requested_threads"
5947         const.
5948         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5949         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5950
5951 2019-05-08  Tom Tromey  <tom@tromey.com>
5952
5953         * gdbtypes.c (objfile_type_data): Change type.
5954         (objfile_type, _initialize_gdbtypes): Update.
5955
5956 2019-05-08  Tom Tromey  <tom@tromey.com>
5957
5958         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5959         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5960         (_initialize_dwarf2_frame): Update.
5961
5962 2019-05-08  Tom Tromey  <tom@tromey.com>
5963
5964         * objc-lang.c (objc_objfile_data): Change type.
5965         (find_methods): Update.
5966         (_initialize_objc_lang): Remove.
5967
5968 2019-05-08  Tom Tromey  <tom@tromey.com>
5969
5970         * stabsread.c (rs6000_builtin_type_data): Change type.
5971         (rs6000_builtin_type, _initialize_stabsread): Update.
5972
5973 2019-05-08  Tom Tromey  <tom@tromey.com>
5974
5975         * mips-tdep.c (mips_pdr_data): Remove.
5976         (_initialize_mips_tdep): Update.
5977
5978 2019-05-08  Tom Tromey  <tom@tromey.com>
5979
5980         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5981         (hppa_init_objfile_priv_data, read_unwind_info)
5982         (find_unwind_entry, _initialize_hppa_tdep): Update.
5983
5984 2019-05-08  Tom Tromey  <tom@tromey.com>
5985
5986         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5987         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5988         on obstack.
5989         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5990
5991 2019-05-08  Tom Tromey  <tom@tromey.com>
5992
5993         * mdebugread.c (basic_type_data): Change type.
5994         (basic_type, _initialize_mdebugread): Update.
5995
5996 2019-05-08  Tom Tromey  <tom@tromey.com>
5997
5998         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5999
6000 2019-05-08  Tom Tromey  <tom@tromey.com>
6001
6002         * nto-tdep.c (nto_inferior_data_reg): Change type.
6003         (nto_inferior_data): Update.
6004         (nto_inferior_data_cleanup, nto_new_inferior_data)
6005         (_initialize_nto_tdep): Remove.
6006         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6007
6008 2019-05-08  Tom Tromey  <tom@tromey.com>
6009
6010         * ada-lang.c (struct ada_inferior_data): Add initializers.
6011         (ada_inferior_data): Change type.
6012         (ada_inferior_data_cleanup): Remove.
6013         (get_ada_inferior_data, ada_inferior_exit)
6014         (struct ada_pspace_data): Add initializers, destructor.
6015         (ada_pspace_data_handle): Change type.
6016         (get_ada_pspace_data): Update.
6017         (ada_pspace_data_cleanup): Remove.
6018
6019 2019-05-08  Tom Tromey  <tom@tromey.com>
6020
6021         * coffread.c (struct coff_symfile_info): Add initializers.
6022         (coff_objfile_data_key): Move lower.  Change type.
6023         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6024         Update.
6025         (coff_free_info): Remove.
6026
6027 2019-05-08  Tom Tromey  <tom@tromey.com>
6028
6029         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6030         (fbsd_pspace_data_handle): Move lower.  Change type.
6031         (get_fbsd_pspace_data): Update.
6032         (fbsd_pspace_data_cleanup): Remove.
6033         (_initialize_fbsd_tdep): Update.
6034
6035 2019-05-08  Tom Tromey  <tom@tromey.com>
6036
6037         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6038         (get_ada_tasks_pspace_data): Update.
6039         (ada_tasks_pspace_data_cleanup): Remove.
6040         (_initialize_tasks): Update.
6041         (ada_tasks_inferior_data_handle): Change type.
6042         (get_ada_tasks_inferior_data): Update.
6043         (ada_tasks_inferior_data_cleanup): Remove.
6044         (struct ada_tasks_pspace_data): Add initializers.
6045
6046 2019-05-08  Tom Tromey  <tom@tromey.com>
6047
6048         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6049         * symfile-debug.c (debug_sym_get_probes): Change type.
6050         * stap-probe.c (handle_stap_probe):
6051         (stap_static_probe_ops::get_probes): Change type.
6052         * probe.h (class static_probe_ops) <get_probes>: Change type.
6053         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6054         (parse_probes_in_pspace): Update.
6055         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6056         Update.
6057         (any_static_probe_ops::get_probes): Change type.
6058         * elfread.c (elfread_data): New typedef.
6059         (probe_key): Change type.
6060         (elf_get_probes): Likewise.  Update.
6061         (probe_key_free): Remove.
6062         (_initialize_elfread): Update.
6063         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6064         Change type.
6065         (dtrace_process_dof_probe, dtrace_process_dof)
6066         (dtrace_static_probe_ops::get_probe): Change type.
6067
6068 2019-05-08  Tom Tromey  <tom@tromey.com>
6069
6070         * xcoffread.c (struct xcoff_symfile_info): Rename from
6071         coff_symfile_info.  Add initializers.
6072         (xcoff_objfile_data_key): Move lower.  Change type.
6073         (XCOFF_DATA): Rewrite.
6074         (xcoff_free_info): Remove.
6075         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6076         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6077         (xcoff_initial_scan): Update.
6078
6079 2019-05-08  Tom Tromey  <tom@tromey.com>
6080
6081         * solib-svr4.c (struct svr4_info): Add initializers and
6082         destructor.
6083         <probes_table>: Now an htab_up.
6084         (solib_svr4_pspace_data): Change type.
6085         (free_probes_table): Simplify.
6086         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6087         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6088         (probes_table_remove_objfile_probes, register_solib_event_probe)
6089         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6090         (_initialize_svr4_solib): Update.
6091
6092 2019-05-08  Tom Tromey  <tom@tromey.com>
6093
6094         * remote.c (remote_pspace_data): Change type.
6095         (remote_pspace_data_cleanup): Remove.
6096         (get_remote_exec_file, set_pspace_remote_exec_file)
6097         (_initialize_remote): Update.
6098
6099 2019-05-08  Tom Tromey  <tom@tromey.com>
6100
6101         * breakpoint.c (breakpoint_objfile_key): Change type.
6102         (get_breakpoint_objfile_data): Update.
6103         (free_breakpoint_objfile_data): Remove.
6104         (_initialize_breakpoint): Update.
6105
6106 2019-05-08  Tom Tromey  <tom@tromey.com>
6107
6108         * linux-tdep.c (struct linux_info): Add initializers.
6109         (linux_inferior_data): Move.  Change type.
6110         (invalidate_linux_cache_inf): Update.
6111         (linux_inferior_data_cleanup): Remove.
6112         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6113
6114 2019-05-08  Tom Tromey  <tom@tromey.com>
6115
6116         * auxv.c (auxv_inferior_data): Move.  Change type.
6117         (auxv_inferior_data_cleanup): Remove.
6118         (invalidate_auxv_cache_inf): Rewrite.
6119         (get_auxv_inferior_data, _initialize_auxv): Update.
6120
6121 2019-05-08  Tom Tromey  <tom@tromey.com>
6122
6123         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6124         (symfile_debug_objfile_data_key): Change type.
6125         (symfile_debug_installed, debug_qf_has_symbols)
6126         (debug_qf_find_last_source_symtab)
6127         (debug_qf_forget_cached_source_info)
6128         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6129         (debug_qf_print_stats, debug_qf_dump)
6130         (debug_qf_expand_symtabs_for_function)
6131         (debug_qf_expand_all_symtabs)
6132         (debug_qf_expand_symtabs_with_fullname)
6133         (debug_qf_map_matching_symbols)
6134         (debug_qf_expand_symtabs_matching)
6135         (debug_qf_find_pc_sect_compunit_symtab)
6136         (debug_qf_map_symbol_filenames)
6137         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6138         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6139         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6140         (debug_sym_read_linetable, debug_sym_relocate): Update.
6141         (symfile_debug_free_objfile): Remove.
6142         (install_symfile_debug_logging, _initialize_symfile_debug):
6143         Update.
6144
6145 2019-05-08  Tom Tromey  <tom@tromey.com>
6146
6147         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6148         allocate_on_obstack.
6149         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6150         (get_dwarf2_per_objfile): Update.
6151         (set_dwarf2_per_objfile): Remove.
6152         (dwarf2_has_info, dwarf2_get_section_info): Update.
6153         (dwarf2_free_objfile): Remove.
6154         (_initialize_dwarf2_read): Update.
6155
6156 2019-05-08  Tom Tromey  <tom@tromey.com>
6157
6158         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6159         initializers.
6160         <unsupported_script_warning_printed,
6161         script_not_found_warning_printed>: Now bool.
6162         (auto_load_pspace_data): Change type.
6163         (~auto_load_pspace_info): Rename from
6164         auto_load_pspace_data_cleanup.
6165         (get_auto_load_pspace_data, init_loaded_scripts_info)
6166         (clear_section_scripts, maybe_print_unsupported_script_warning)
6167         (maybe_print_script_not_found_warning, _initialize_auto_load):
6168         Update.
6169
6170 2019-05-08  Tom Tromey  <tom@tromey.com>
6171
6172         * objfiles.c (objfile_pspace_info): Add destructor and
6173         initializers.
6174         (objfiles_pspace_data): Change type.
6175         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6176         (get_objfile_pspace_data): Update.
6177         (objfiles_bfd_data): Change type.
6178         (get_objfile_bfd_data): Update.
6179         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6180
6181 2019-05-08  Tom Tromey  <tom@tromey.com>
6182
6183         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6184         Change type.
6185         (get_catch_syscall_inferior_data): Update.
6186         (catch_syscall_inferior_data_cleanup): Remove.
6187         (_initialize_break_catch_syscall): Update.
6188
6189 2019-05-08  Tom Tromey  <tom@tromey.com>
6190
6191         * inflow.c (struct terminal_info): Add destructor and
6192         initializers.
6193         (inflow_inferior_data): Change type.
6194         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6195         (get_inflow_inferior_data, inflow_inferior_exit)
6196         (swap_terminal_info, _initialize_inflow): Update.
6197
6198 2019-05-08  Tom Tromey  <tom@tromey.com>
6199
6200         * target-dcache.c (target_dcache_cleanup): Remove.
6201         (target_dcache_aspace_key): Change type.
6202         (target_dcache_init_p, target_dcache_invalidate)
6203         (target_dcache_get, target_dcache_get_or_init)
6204         (_initialize_target_dcache): Update.
6205         * dcache.h (struct dcache_deleter): New.
6206
6207 2019-05-08  Tom Tromey  <tom@tromey.com>
6208
6209         * symtab.c (struct symbol_cache): Add destructor and
6210         initializers.
6211         (symbol_cache_key): Move.  Change type.
6212         (make_symbol_cache, free_symbol_cache): Remove.
6213         (get_symbol_cache): Update.
6214         (symbol_cache_cleanup): Remove.
6215         (ALL_PSPACES, symbol_cache_flush)
6216         (maintenance_print_symbol_cache)
6217         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6218         Update.
6219
6220 2019-05-08  Tom Tromey  <tom@tromey.com>
6221
6222         * symtab.c (struct main_info): Add destructor and initializers.
6223         (main_progspace_key): Move.  Change type.
6224         (get_main_info): Update.
6225         (main_info_cleanup): Remove.
6226         (_initialize_symtab): Update.
6227
6228 2019-05-08  Tom Tromey  <tom@tromey.com>
6229
6230         * registry.h (DECLARE_REGISTRY): Define the _key class.
6231
6232 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6233
6234         * NEWS: Merge two 'New commands' sections.
6235
6236 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6237
6238         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6239         parameter and use Ada language definition instead.
6240         (ada_val_print_ptr): Remove unused language parameter.
6241         (ada_val_print_num): Remove language parameter and use Ada language
6242         definition instead.
6243         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6244         parameter.
6245         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6246         parameter and use Ada language definition instead.
6247         (ada_val_print_1): Update all ada_val_print_xxx calls.
6248         Remove language parameter.
6249         (ada_val_print): Update ada_val_print_1 call.
6250
6251 2019-05-08  Tom Tromey  <tromey@adacore.com>
6252
6253         * remote.c (remote_hw_watchpoint_limit)
6254         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6255         Now static.
6256
6257 2019-05-08  Tom Tromey  <tromey@adacore.com>
6258
6259         * maint.c (_initialize_maint_cmds): Move initialization code to
6260         remote.c.
6261         (watchdog, show_watchdog): Move to remote.c.
6262         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6263         "watchdog" static.
6264         (_initialize_remote): Move initialization code from maint.c.
6265         * defs.h (watchdog): Don't declare.
6266
6267 2019-05-08  Tom Tromey  <tromey@adacore.com>
6268
6269         * tui/tui-interp.c: Include main.h.
6270         * interps.c: Include main.h.
6271         * main.h (interpreter_p): Declare.
6272         * defs.h (interpreter_p): Don't declare.
6273
6274 2019-05-08  Tom Tromey  <tromey@adacore.com>
6275
6276         * dwarf2loc.c: Include dwarf2read.h.
6277         * defs.h (read_unsigned_leb128): Don't declare.
6278         * dwarf2read.h (read_unsigned_leb128): Declare.
6279
6280 2019-05-08  Tom Tromey  <tromey@adacore.com>
6281
6282         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6283         method.
6284
6285 2019-05-08  Tom Tromey  <tromey@adacore.com>
6286
6287         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6288         when no wrap column is set.
6289
6290 2019-05-08  Tom Tromey  <tromey@adacore.com>
6291
6292         * c-lang.c (c_get_string): Handle non-C-style arrays.
6293
6294 2019-05-08  Tom Tromey  <tromey@adacore.com>
6295
6296         * typeprint.c (print_offset_data::update): Print the bit offset,
6297         not the number of bits remaining.
6298
6299 2019-05-08  Tom Tromey  <tromey@adacore.com>
6300
6301         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6302         padding at end of comment.
6303
6304 2019-05-08  Tom Tromey  <tromey@adacore.com>
6305
6306         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6307         Compare main types.
6308
6309 2019-05-06  Tom Tromey  <tom@tromey.com>
6310
6311         * common/scoped_mmap.c: Include common-defs.h.
6312         * common/scoped_mmap.h: Don't include config.h.
6313
6314 2019-05-04  Tom Tromey  <tom@tromey.com>
6315
6316         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6317         (struct aarch64_call_info): Add initializers.
6318         <si>: Now a std::vector.
6319         (pass_on_stack, aarch64_push_dummy_call): Update.
6320
6321 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6322             Tom Tromey  <tom@tromey.com>
6323
6324         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6325         (ppc_threads): Now a std::vector.  Now static.
6326         (hwdebug_find_thread_points_by_tid)
6327         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6328         Update.
6329
6330 2019-05-04  Tom Tromey  <tom@tromey.com>
6331
6332         * arc-tdep.c (arc_tdesc_init): Return bool.
6333
6334 2019-05-04  Tom Tromey  <tom@tromey.com>
6335
6336         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6337         Use gdb_assert_not_reached.
6338
6339 2019-05-04  Tom Tromey  <tom@tromey.com>
6340
6341         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6342         "false".
6343
6344 2019-05-04  Tom Tromey  <tom@tromey.com>
6345
6346         * arc-tdep.c (arc_tdesc_init): Use bool.
6347
6348 2019-05-04  Tom Tromey  <tom@tromey.com>
6349
6350         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6351
6352 2019-05-04  Tom Tromey  <tom@tromey.com>
6353
6354         * cli/cli-cmds.c (valid_command_p): Return bool.
6355
6356 2019-05-04  Tom Tromey  <tom@tromey.com>
6357
6358         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6359         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6360
6361 2019-05-04  Raul Tambre  <raul@tambre.ee>
6362
6363         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6364         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6365         operator for comparison.
6366
6367 2019-05-04  Tom Tromey  <tom@tromey.com>
6368
6369         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6370         (lookup_partial_symbol, print_partial_symbols)
6371         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6372         (psymbol_compare): Update.
6373         (add_psymbol_to_bcache): Clear the entire psymbol.
6374         (maintenance_check_psymtabs): Update.
6375         * psympriv.h (struct partial_symbol): Don't derive from
6376         general_symbol_info.
6377         <obj_section, unrelocated_address, address,
6378         set_unrelocated_address>: Update.
6379         <ginfo>: New member.
6380         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6381         (debug_names::write_psymbols): Update.
6382
6383 2019-05-04  Tom de Vries  <tdevries@suse.de>
6384
6385         * contrib/cc-with-tweaks.sh: Support -n arg.
6386
6387 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6388
6389         * corelow.c (core_target::detach): Ensure frame cache and
6390         register caches are cleared.
6391         inferior.c (exit_inferior_1): Likewise.
6392
6393 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6394             Tom Tromey  <tom@tromey.com>
6395
6396         * dictionary.c (collate_pending_symbols_by_language): Remove
6397         "struct" from foreach.
6398         * symtab.c (lookup_global_symbol_from_objfile)
6399         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6400         foreach.
6401         * ser-tcp.c (net_open): Remove "struct" from foreach.
6402         * objfiles.c (objfile_relocate, objfile_rebase)
6403         (objfile_has_symbols): Remove "struct" from foreach.
6404         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6405         from foreach.
6406         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6407         foreach.
6408         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6409         "struct" from foreach.
6410         * ada-lang.c (create_excep_cond_exprs)
6411         (ada_exception_catchpoint_cond_string): Remove "struct" from
6412         foreach.
6413
6414 2019-05-03  Tom Tromey  <tromey@adacore.com>
6415
6416         * ada-exp.y (convert_char_literal): Check suffix of each
6417         enumerator.
6418
6419 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6420
6421         PR ada/21406:
6422         * ada-exp.y (yywrap): Don't define.
6423         * ada-lex.l (%option): Add noyywrap
6424         (yywrap): Remove.
6425
6426 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6427
6428         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6429         _WIN32_WINNT to the XP level, unless already defined to a higher
6430         level.
6431
6432         * unittests/parse-connection-spec-selftests.c:
6433         * ser-tcp.c:
6434         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6435         override.
6436
6437         * symfile.c (find_separate_debug_file): Remove colon from the
6438         drive spec of DOS/Windows file names of the target, so that the
6439         file name produced from DEBUGDIR and the target's directory will
6440         be valid on DOS/Windows systems.
6441
6442 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6443
6444         * rust-lang.c (val_print_struct): Handle printing structures
6445         containing strings.
6446
6447 2019-05-02  Tom Tromey  <tromey@adacore.com>
6448
6449         * valarith.c (_initialize_valarith): Remove.
6450
6451 2019-05-01  Tom Tromey  <tromey@adacore.com>
6452
6453         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6454         bitfields.
6455
6456 2019-05-01  Tom Tromey  <tromey@adacore.com>
6457
6458         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6459         for big-endian copies.
6460
6461 2019-04-30  Ali Tamur  <tamur@google.com>
6462         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6463         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6464         (read_3_bytes): New function.
6465
6466 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6467
6468         * windows-nat.c (main_thread_id): Delete.
6469         (handle_output_debug_string): Replace main_thread_id by
6470         current_event.dwThreadId.
6471         (fake_create_process): Likewise.
6472         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6473         Do not set main_thread_id.
6474         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6475         current_event.dwThreadId.
6476         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6477
6478 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6479
6480         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6481         Use current_event.dwThreadId instead of main_thread_id.
6482
6483 2019-04-30  Tom Tromey  <tromey@adacore.com>
6484
6485         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6486         (create_excep_cond_exprs): Iterate over program spaces.
6487         (ada_exception_catchpoint_cond_string): Examine all minimal
6488         symbols for exception types.
6489
6490 2019-04-30  Tom Tromey  <tromey@adacore.com>
6491
6492         PR c++/24470:
6493         * dwarf2read.c (process_structure_scope): Handle case where type
6494         has template parameters but no symbol was created.
6495
6496 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6497             Chris January  <chris.january@arm.com>
6498
6499         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6500         qualifier.
6501         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6502
6503 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6504
6505         * f-typeprint.c (f_print_type): Update rules for printing
6506         whitespace.
6507         (f_type_print_varspec_suffix): Likewise.
6508
6509 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6510             Chris January  <chris.january@arm.com>
6511
6512         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6513         function arguments.
6514
6515 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6516
6517         * f-lang.c (build_fortran_types): Change name of void type to
6518         lower case.
6519         * f-typeprint.c (f_type_print_base): Print the name of the void
6520         type, rather than a fixed string.
6521         * f-valprint.c (f_decorations): Use lower case void string.
6522
6523 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6524             Chris January  <chris.january@arm.com>
6525
6526         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6527         types for Fortran.
6528
6529 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6530             Chris January  <chris.january@arm.com>
6531             David Lecomber  <david.lecomber@arm.com>
6532
6533         * f-exp.y (BINOP_INTRINSIC): New token.
6534         (exp): New parser rule handling BINOP_INTRINSIC.
6535         (f77_keywords): Add new builtin procedures.
6536         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6537         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6538         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6539         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6540         (print_unop_subexp_f): New function.
6541         (print_binop_subexp_f): New function.
6542         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6543         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6544         (dump_subexp_body_f): Likewise.
6545         (operator_check_f): Likewise.
6546         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6547         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6548
6549 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6550
6551         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6552         UNOP_KIND.
6553         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6554         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6555         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6556         (operator_length_f): New fuction.
6557         (print_subexp_f): New function.
6558         (op_name_f): New function.
6559         (dump_subexp_body_f): New function.
6560         (operator_check_f): New function.
6561         (exp_descriptor_f): Replace standard expression handling functions
6562         with new functions.
6563         * gdb/fortran-operator.def: New file.
6564         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6565         * gdb/std-operator.def: Remove UNOP_KIND.
6566
6567 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6568
6569         * std-operator.def: Remove unbalanced, stray double quote
6570         character.
6571
6572 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6573             Chris January  <chris.january@arm.com>
6574             Daniel Everett  <daniel.everett@arm.com>
6575             Nick Forrington  <nick.forrington@arm.com>
6576             Richard Bunt  <richard.bunt@arm.com>
6577
6578         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6579         of depth when printing anonymous structs or unions.
6580         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6581         Don't print either the top-level value, or the children if the
6582         max-depth is exceeded.
6583         (ppscm_print_children): When printing the key of a map, allow one
6584         extra level of depth.
6585         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6586         print either the top-level value, or the children if the max-depth
6587         is exceeded.
6588         (print_children): When printing the key of a map, allow one extra
6589         level of depth.
6590         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6591         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6592         (user_print_options): Initialise max_depth field.
6593         (val_print_scalar_or_string_type_p): New function.
6594         (val_print): Check to see if the max depth has been reached.
6595         (val_print_check_max_depth): Define new function.
6596         (show_print_max_depth): New function.
6597         (_initialize_valprint): Add 'print max-depth' option.
6598         * valprint.h (struct value_print_options) <max_depth>: New field.
6599         (val_print_check_max_depth): Declare new function.
6600         * NEWS: Document new feature.
6601
6602 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6603
6604         * ada-lang.c (ada_language_defn): Initialise new field.
6605         * c-lang.c (c_is_string_type_p): New function.
6606         (c_language_defn): Initialise new field.
6607         (cplus_language_defn): Initialise new field.
6608         (asm_language_defn): Initialise new field.
6609         (minimal_language_defn): Initialise new field.
6610         * c-lang.h (c_is_string_type_p): Declare new function.
6611         * d-lang.c (d_language_defn): Initialise new field.
6612         * f-lang.c (f_is_string_type_p): New function.
6613         (f_language_defn): Initialise new field.
6614         * go-lang.c (go_is_string_type_p): New function.
6615         (go_language_defn): Initialise new field.
6616         * language.c (default_is_string_type_p): New function.
6617         (unknown_language_defn): Initialise new field.
6618         (auto_language_defn): Initialise new field.
6619         * language.h (struct language_defn) <la_is_string_type_p>: New
6620         member variable.
6621         (default_is_string_type_p): Declare new function.
6622         * m2-lang.c (m2_language_defn): Initialise new field.
6623         * objc-lang.c (objc_language_defn): Initialise new field.
6624         * opencl-lang.c (opencl_language_defn): Initialise new field.
6625         * p-lang.c (pascal_is_string_type_p): New function.
6626         (pascal_language_defn): Initialise new field.
6627         * rust-lang.c (rust_is_string_type_p): New function.
6628         (rust_language_defn): Initialise new field.
6629
6630 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6631
6632         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6633         New field.
6634         * ada-lang.c (ada_language_defn): Initialise new field.
6635         * c-lang.c (c_language_defn): Likewise.
6636         (cplus_language_defn): Likewise.
6637         (asm_language_defn): Likewise.
6638         (minimal_language_defn): Likewise.
6639         * d-lang.c (d_language_defn): Likewise.
6640         * f-lang.c (f_language_defn): Likewise.
6641         * go-lang.c (go_language_defn): Likewise.
6642         * language.c (unknown_language_defn): Likewise.
6643         (auto_language_defn): Likewise.
6644         * m2-lang.c (m2_language_defn): Likewise.
6645         * objc-lang.c (objc_language_defn): Likewise.
6646         * opencl-lang.c (opencl_language_defn): Likewise.
6647         * p-lang.c (pascal_language_defn): Likewise.
6648         * rust-lang.c (rust_language_defn): Likewise.
6649
6650 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6651
6652         * ada-lang.c (ada_is_character_type): Change return type to bool.
6653         (ada_is_string_type): Likewise.
6654         * ada-lang.h (ada_is_character_type): Update declaration
6655         (ada_is_string_type): Likewise.
6656
6657 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6658
6659         Support style in 'frame|thread apply'
6660
6661         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6662         * record.c (record_start, record_stop): Update callers of
6663         execute_command_to_string with false.
6664         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6665         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6666         methods.
6667         (class string_file): New constructor with term_out parameter.
6668         Override methods term_out and can_emit_style_escape.  New member
6669         term_out.
6670         (class stdio_file): Override can_emit_style_escape.
6671         (class tee_file): Override term_out and can_emit_style_escape.
6672         * utils.h (can_emit_style_escape): Remove.
6673         * utils.c (can_emit_style_escape): Likewise.
6674         Update all callers of can_emit_style_escape (SOMESTREAM) to
6675         SOMESTREAM->can_emit_style_escape.
6676         * source-cache.c (source_cache::get_source_lines): Likewise.
6677         * stack.c (frame_apply_command_count): Call execute_command_to_string
6678         passing the term_out characteristic of the current gdb_stdout.
6679         * thread.c (thr_try_catch_cmd): Likewise.
6680         * top.c (execute_command_to_string): pass term_out parameter
6681         to construct the string_file for the command output.
6682         * ui-file.c (term_cli_styling): New function (most code moved
6683         from utils.c can_emit_style_escape).
6684         (string_file::string_file, string_file::can_emit_style_escape,
6685         stdio_file::can_emit_style_escape, tee_file::term_out,
6686         tee_file::can_emit_style_escape): New functions.
6687
6688 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6689
6690         * NEWS: Mention the new set|show may-call-functions.
6691         * infcall.c (may_call_functions_p): New variable.
6692         (show_may_call_functions_p): New function.
6693         (call_function_by_hand_dummy): Throws an error if not
6694         may-call-functions.
6695         (_initialize_infcall): Call add_setshow_boolean_cmd for
6696         may-call-functions.
6697
6698 2019-04-25  Keith Seitz  <keiths@redhat.com>
6699
6700         PR c++/24367
6701         * cp-support.c (inspect_type): Don't attempt substitutions
6702         of symbol with the same name.
6703
6704 2019-04-25  Tom Tromey  <tromey@adacore.com>
6705
6706         PR gdb/24475:
6707         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6708         static.
6709
6710 2019-04-25  Tom Tromey  <tromey@adacore.com>
6711
6712         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6713         rvalue reference.
6714         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6715         (gdb_xml_parser::parse): Use std::move.
6716         * python/python-internal.h (gdbpy_convert_exception): Take a const
6717         reference.
6718         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6719         std::move.
6720         * python/py-utils.c (gdbpy_convert_exception): Take a const
6721         reference.
6722         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6723         Use std::move.
6724         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6725         Use std::move.
6726         * mi/mi-main.c (mi_print_exception): Take a const reference.
6727         * main.c (handle_command_errors): Take a const reference.
6728         * linespec.c (parse_linespec): Use std::move.
6729         * infcall.c (run_inferior_call): Use std::move.
6730         (call_function_by_hand_dummy): Use std::move.
6731         * exec.c (try_open_exec_file): Use std::move.
6732         * exceptions.h (exception_print, exception_fprintf)
6733         (exception_print_same): Update.
6734         * exceptions.c (print_exception, exception_print)
6735         (exception_fprintf, exception_print_same): Change parameters to
6736         const reference.
6737         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6738         * common/new-op.c: Use std::move.
6739         * common/common-exceptions.h (struct gdb_exception): Add move
6740         constructor.
6741         (struct gdb_exception_error, struct gdb_exception_quit, struct
6742         gdb_quit_bad_alloc): Change constructor to move constructor.
6743         (throw_exception): Change parameter to rvalue reference.
6744         * common/common-exceptions.c (throw_exception): Take rvalue
6745         reference.
6746         * cli/cli-interp.c (safe_execute_command): Use std::move.
6747         * breakpoint.c (insert_bp_location, location_to_sals): Use
6748         std::move.
6749
6750 2019-04-25  Tom Tromey  <tromey@adacore.com>
6751
6752         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6753         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6754         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6755         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6756         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6757         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6758         guile/scm-value.c: Use unpack.
6759         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6760         gdbscm_gdb_exception.
6761         (gdbscm_throw_gdb_exception): Likewise.
6762         (struct gdbscm_gdb_exception): New.
6763         (unpack): New function.
6764         (gdbscm_wrap): Use unpack.
6765
6766 2019-04-25  Tom Tromey  <tromey@adacore.com>
6767
6768         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6769         (gdb_rl_callback_handler): Use std::move.
6770         * common/common-exceptions.h (struct gdb_exception): Add move
6771         assignment operator.
6772         (throw_exception_sjlj): Change "exception" to const reference.
6773         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6774         (throw_exception_sjlj): Change "exception" to const reference.
6775
6776 2019-04-25  Tom Tromey  <tromey@adacore.com>
6777
6778         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6779         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6780         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6781         Update.
6782         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6783         Update.
6784         * mi/mi-interp.c (mi_interp::exec): Update.
6785         * linespec.c (parse_linespec): Update.
6786         * infcall.c (run_inferior_call): Update.
6787         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6788         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6789         (gdbscm_lookup_global_symbol): Update.
6790         * guile/scm-param.c (gdbscm_parameter_value): Update.
6791         * guile/scm-frame.c (gdbscm_frame_read_register)
6792         (gdbscm_frame_read_var): Update.
6793         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6794         * exec.c (try_open_exec_file): Update.
6795         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6796         (gdb_rl_callback_handler): Update.
6797         * common/common-exceptions.h (exception_none): Don't declare.
6798         * common/common-exceptions.c (exception_none): Don't define.
6799         (struct catcher) <exception>: Update.
6800         * cli/cli-interp.c (safe_execute_command): Update.
6801         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6802
6803 2019-04-25  Ali Tamur  <tamur@google.com>
6804
6805         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6806         (read_attribute_value): Likewise.
6807         (dwarf2_read_addr_index): Update comment.
6808         (read_str_index): Add DW_FORM_strx.
6809         (dwarf2_string_attr): Likewise.
6810         (dwarf2_const_value_attr): Likewise.
6811         (dump_die_shallow): Likewise.
6812         (dwarf2_fetch_constant_bytes): Likewise.
6813         (skip_form_bytes): Likewise.
6814         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6815
6816 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6817
6818         PR corefiles/11608
6819         PR corefiles/18187
6820         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6821         OFFSET.  Verify if current mapping contains an ELF header.
6822         (linux_find_memory_regions_full): Adjust call to
6823         dump_mapping_p.
6824
6825 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6826             Kang Li <kanglictf@gmail.com>
6827
6828         PR gdb/21600
6829
6830         * dwarf2-frame.c (read_initial_length): Be consistent about using
6831         unsigned representation of length.
6832         (decode_frame_entry_1): Likewise.  Check for wraparound of
6833         end pointer as well as buffer overflow.
6834
6835 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6836
6837         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6838         "vq".
6839
6840 2019-04-24  Tom Tromey  <tromey@adacore.com>
6841
6842         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6843
6844 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6845
6846         * s12z-tdep.c (s12z_unwind_pc): Delete.
6847         (s12z_unwind_sp): Delete.
6848         (s12z_gdbarch_init): Don't register deleted functions with
6849         gdbarch.
6850
6851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6852
6853         * rl78-tdep.c (rl78_unwind_sp): Delete.
6854         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6855
6856 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6857
6858         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6859         (xstormy16_unwind_pc): Delete.
6860         (xstormy16_dummy_id): Delete.
6861         (xstormy16_gdbarch_init): Don't register deleted functions with
6862         gdbarch.
6863
6864 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6865
6866         * vax-tdep.c (vax_unwind_pc): Delete.
6867         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6868
6869 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6870
6871         * v850-tdep.c (v850_unwind_sp): Delete.
6872         (v850_unwind_pc): Delete.
6873         (v850_dummy_id): Delete.
6874         (v850_gdbarch_init): Don't register deleted functions with
6875         gdbarch.
6876
6877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6878
6879         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6880         (tilegx_unwind_pc): Delete.
6881         (tilegx_unwind_dummy_id): Delete.
6882         (tilegx_gdbarch_init): Don't register deleted functions with
6883         gdbarch.
6884
6885 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6886
6887         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6888         (tic6x_dummy_id): Delete.
6889         (tic6x_gdbarch_init): Don't register deleted functions with
6890         gdbarch.
6891
6892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6893
6894         * sparc-tdep.c (sparc_unwind_pc): Delete.
6895         (sparc32_gdbarch_init): Don't register deleted function with
6896         gdbarch.
6897
6898 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6899
6900         * sh-tdep.c (sh_unwind_sp): Delete.
6901         (sh_unwind_pc): Delete.
6902         (sh_dummy_id): Delete.
6903         (sh_gdbarch_init): Don't register deleted functions with
6904         gdbarch.
6905
6906 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6907
6908         * score-tdep.c (score_unwind_sp): Delete.
6909         (score_unwind_pc): Delete.
6910         (score_dummy_id): Delete.
6911         (score_gdbarch_init): Don't register deleted functions with
6912         gdbarch.
6913
6914 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6915
6916         * rx-tdep.c (rx_unwind_pc): Delete.
6917         (rx_unwind_sp): Delete.
6918         (rx_dummy_id): Delete.
6919         (rx_gdbarch_init): Don't register deleted functions with
6920         gdbarch.  Update comment.
6921
6922 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6923
6924         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6925         (rs6000_dummy_id): Delete.
6926         (rs6000_gdbarch_init): Don't register deleted functions with
6927         gdbarch.
6928
6929 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6930
6931         * or1k-tdep.c (or1k_dummy_id): Delete.
6932         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6933
6934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6935
6936         * nios2-tdep.c (nios2_dummy_id): Delete.
6937         (nios2_unwind_sp): Delete.
6938         (nios2_gdbarch_init): Don't register deleted functions with
6939         gdbarch.
6940
6941 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6942
6943         * nds32-tdep.c (nds32_dummy_id): Delete.
6944         (nds32_unwind_pc): Delete.
6945         (nds32_unwind_sp): Delete.
6946         (nds32_gdbarch_init): Don't register deleted functions with
6947         gdbarch.
6948
6949 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6950
6951         * msp430-tdep.c (msp430_unwind_pc): Delete.
6952         (msp430_unwind_sp): Delete.
6953         (msp430_dummy_id): Delete.
6954         (msp430_gdbarch_init): Don't register deleted functions with
6955         gdbarch.
6956
6957 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6958
6959         * moxie-tdep.c (moxie_unwind_sp): Delete.
6960         (moxie_unwind_pc): Delete.
6961         (moxie_dummy_id): Delete.
6962         (moxie_gdbarch_init): Don't register deleted functions with
6963         gdbarch.
6964
6965 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6966
6967         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6968         (mn10300_unwind_pc): Delete.
6969         (mn10300_unwind_sp): Delete.
6970         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6971         mn10300_unwind_sp.
6972         (mn10300_frame_unwind_init): Don't register deleted functions with
6973         gdbarch.
6974
6975 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6976
6977         * mep-tdep.c (mep_unwind_pc): Delete.
6978         (mep_unwind_sp): Delete.
6979         (mep_dummy_id): Delete.
6980         (mep_gdbarch_init): Don't register deleted functions with
6981         gdbarch.
6982
6983 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6984
6985         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6986         (m68hc11_unwind_sp): Delete.
6987         (m68hc11_gdbarch_init): Don't register deleted functions with
6988         gdbarch.
6989
6990 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6991
6992         * m32r-tdep.c (m32r_unwind_sp): Delete.
6993         (m32r_unwind_pc): Delete.
6994         (m32r_dummy_id): Delete.
6995         (m32r_gdbarch_init): Don't register deleted functions with
6996         gdbarch.
6997
6998 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6999
7000         * m32c-tdep.c (m32c_unwind_pc): Delete.
7001         (m32c_unwind_sp): Delete.
7002         (m32c_dummy_id): Delete.
7003         (m32c_gdbarch_init): Don't register deleted functions with
7004         gdbarch.
7005
7006 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7007
7008         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7009         (lm32_unwind_pc): Delete.
7010         (lm32_dummy_id): Delete.
7011         (lm32_gdbarch_init): Don't register deleted functions with
7012         gdbarch.
7013
7014 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7015
7016         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7017         (iq2000_unwind_pc): Delete.
7018         (iq2000_dummy_id): Delete.
7019         (iq2000_gdbarch_init): Don't register deleted functions with
7020         gdbarch.
7021
7022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7023
7024         * nds32-tdep.c (nds32_type_align): Delete.
7025         (nds32_push_dummy_call): Use type_align instead.
7026
7027 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7028
7029         * arm-tdep.c (arm_type_align): Only handle vector override case.
7030         (arm_push_dummy_call): Use type_align.
7031         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7032
7033 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7034
7035         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7036         case.
7037         (pass_on_stack): Use type_align.
7038         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7039         function.
7040
7041 2019-04-23  Tom Tromey  <tromey@adacore.com>
7042
7043         * dwarf2read.c (line_header::file_name_at): Remove unused
7044         overload.
7045
7046 2019-04-23  Tom de Vries  <tdevries@suse.de>
7047
7048         PR gdb/24438
7049         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7050         invocation.
7051
7052
7053 2019-03-27  Ali Tamur  <tamur@google.com>
7054
7055         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7056         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7057         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7058         (dwarf_expr_context::get_addr_index): Likewise
7059         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7060         (symbol_needs_eval_context::get_addr_index): Likewise
7061         (disassemble_dwarf_expression): Add DW_OP_addrx
7062         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7063         (read_cutu_die_from_dwo): Update comment
7064         (skip_one_die): Add DW_FORM_addrx
7065         (read_attribute_value): Likewise
7066         (var_decode_location): Add DW_OP_addrx
7067         (dwarf2_const_value_attr): Add DW_FORM_addrx
7068         (dump_die_shallow): Likewise
7069         (dwarf2_fetch_constant_bytes): Likewise
7070         (decode_locdesc): Add DW_OP_addrx
7071         (skip_form_bytes): Add DW_FORM_addrx
7072
7073 2019-04-22  Ali Tamur  <tamur@google.com>
7074
7075         * MAINTAINERS (Write After Approval): Add self.
7076
7077 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7078
7079         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7080         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7081         (open_symbol_file_object): Likewise.
7082         (svr4_default_sos): Add info parameter.
7083         (svr4_read_so_list): Likewise.
7084         (svr4_current_sos_direct): Adjust functions calls to pass down
7085         info.
7086         (svr4_current_sos_1): Add info parameter.
7087         (svr4_current_sos): Call get_svr4_info, pass info down to
7088         svr4_current_sos_1.
7089         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7090         get_svr4_info.
7091         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7092         get_svr4_info.
7093         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7094         to get_svr4_info.
7095         (probes_table_remove_objfile_probes): Likewise.
7096         (register_solib_event_probe): Add info parameter.
7097         (solist_update_incremental): Pass info parameter down to
7098         svr4_read_so_list.
7099         (disable_probes_interface): Add info parameter.
7100         (svr4_handle_solib_event): Pass current_program_space to
7101         get_svr4_info.  Adjust disable_probes_interface cleanup.
7102         (svr4_create_probe_breakpoints): Add info parameter, pass it
7103         down to register_solib_event_probe.
7104         (svr4_create_solib_event_breakpoints): Add info parameter,
7105         pass it down to svr4_create_probe_breakpoints.
7106         (enable_break): Pass info down to
7107         svr4_create_solib_event_breakpoints.
7108         (svr4_solib_create_inferior_hook): Pass current_program_space to
7109         get_svr4_info.
7110         (svr4_clear_solib): Likewise.
7111
7112 2019-04-22  Pedro Alves  <palves@redhat.com>
7113
7114         * solib-svr4.c (svr4_free_objfile_observer): New.
7115         (probe_and_action::objfile): New field.
7116         (probes_table_htab_remove_objfile_probes)
7117         (probes_table_remove_objfile_probes): New functions.
7118         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7119         in the new probe_and_action.  Don't store the probe in 'lookup'.
7120         (svr4_create_probe_breakpoints): Pass objfile to
7121         register_solib_event_probe.
7122         (_initialize_svr4_solib): Register a free_objfile observer.
7123
7124 2019-04-19  Tom Tromey  <tom@tromey.com>
7125
7126         * common/queue.h: Remove.
7127
7128 2019-04-19  Tom Tromey  <tom@tromey.com>
7129
7130         * event-loop.c: Don't include "common/queue.h".
7131
7132 2019-04-19  Tom Tromey  <tom@tromey.com>
7133
7134         * remote.c (remote_target): Use delete.
7135         * remote-notif.h: Include <list>, not "common/queue.h".
7136         (notif_client_p): Remove typedef.
7137         (remote_notif_state): Add constructor, destructor, initializer.
7138         <notif_queue>: Now a std::list.
7139         (remote_notif_state_xfree): Don't declare.
7140         * remote-notif.c (remote_notif_process, handle_notification)
7141         (remote_notif_state_allocate): Update.
7142         (~remote_notif_state): Rename from remote_notif_state_xfree.
7143
7144 2019-04-19  Tom Tromey  <tom@tromey.com>
7145
7146         * symfile.c (reread_symbols): Update.
7147         * objfiles.c (objfile_register_static_link)
7148         (objfile_lookup_static_link): Update
7149         (~objfile) Don't delete static_links.
7150         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7151
7152 2019-04-19  Tom Tromey  <tom@tromey.com>
7153
7154         * type-stack.h (struct type_stack) <insert>: Constify string.
7155         * type-stack.c (type_stack::insert): Constify string.
7156         * gdbtypes.h (lookup_template_type): Update.
7157         (address_space_name_to_int): Update.
7158         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7159         const.
7160         (lookup_template_type): Make name const.
7161         * c-exp.y: Update rules.
7162         (lex_one_token, classify_name, classify_inner_name)
7163         (c_print_token): Update.
7164         * p-exp.y: Update rules.
7165         (yylex): Update.
7166         * f-exp.y: Update rules.
7167         (yylex): Update.
7168         * d-exp.y: Update rules.
7169         (lex_one_token, classify_name, classify_inner_name): Update.
7170         * parse.c (write_dollar_variable, copy_name): Return std::string.
7171         * parser-defs.h (copy_name): Change return type.
7172         * m2-exp.y: Update rules.
7173         (yylex): Update.
7174         * go-exp.y (lex_one_token): Update.
7175         Update rules.
7176         (classify_unsafe_function, classify_packaged_name)
7177         (classify_name, yylex): Update.
7178
7179 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7180
7181         * configure.ac: add --enable-source-highlight switch.
7182         * configure: Regenerate.
7183         * top.c (print_gdb_version): plumb --enable-source-highlight
7184         status to "show configuration".
7185
7186 2019-04-19  Tom Tromey  <tromey@adacore.com>
7187
7188         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7189         Check ADA_TYPE_P.
7190         (empty_record, ada_template_to_fixed_record_type_1)
7191         (template_to_static_fixed_type)
7192         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7193         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7194         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7195         macros.
7196
7197 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7198
7199         PR symtab/24423:
7200         * source.c (print_source_lines_base): Advance "iter" when a
7201         control character is seen.
7202
7203 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7204
7205         * inferior.h (struct infcall_suspend_state_deleter):
7206         Catch exception in destructor to avoid crash.
7207
7208 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7209
7210         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7211         close to the add_com "shell".
7212
7213 2019-04-18  Tom Tromey  <tromey@adacore.com>
7214
7215         * process-stratum-target.h (class process_stratum_target)
7216         <stratum>: Add "final".
7217
7218 2019-04-17  Tom Tromey  <tromey@adacore.com>
7219
7220         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7221         against nullptr before use.
7222
7223 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7224
7225         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7226
7227 2019-04-17  Jim Wilson  <jimw@sifive.com>
7228             Andrew Burgess  <andrew.burgess@embecosm.com>
7229
7230         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7231         code read might fail, assume 4-byte breakpoint in that case.
7232
7233 2019-04-15  Leszek Swirski  <leszeks@google.com>
7234
7235         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7236         rather than a hand-rolled POD check when checking for forced MEMORY
7237         classification.
7238
7239 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7240
7241         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7242         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7243         function.
7244         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7245         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7246         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7247         declaration.
7248
7249 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7250
7251         * aarch64-linux-nat.c
7252         (aarch64_linux_nat_target::thread_architecture): Add override.
7253         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7254         each VQ.
7255
7256 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7257
7258         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7259
7260 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7261
7262         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7263         target types of size 96-bits, add some additional comments, and
7264         check that the builtin type we found was the correct size.
7265
7266 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7267
7268         * utils.c (prompt_for_continue): Don't restore the styling at the
7269         end, as applied_style has the wrong value.  This fixes styling in
7270         long lists of file names that are interrupted by the "Continue?"
7271         prompt.
7272
7273 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7274
7275         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7276         * c-lang.c (c_language_defn): Likewise.
7277         (cplus_language_defn): Likewise.
7278         (asm_language_defn): Likewise.
7279         (minimal_language_defn): Likewise.
7280         * d-lang.c (d_language_defn): Likewise.
7281         * f-lang.c (f_language_defn): Likewise.
7282         * go-lang.c (go_language_defn): Likewise.
7283         * language.c (unknown_language_defn): Likewise.
7284         (auto_language_defn): Likewise.
7285         * language.h (struct language_defn): Remove la_magic field.
7286         (LANG_MAGIC): Delete.
7287         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7288         * objc-lang.c (objc_language_defn): Likewise.
7289         * opencl-lang.c (opencl_language_defn): Likewise.
7290         * p-lang.c (pascal_language_defn): Likewise.
7291         * rust-lang.c (rust_language_defn): Likewise.
7292
7293 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7294
7295         * riscv-tdep.c (riscv_type_align): New function.
7296         (riscv_type_alignment): Delete.
7297         (riscv_arg_location): Use 'type_align'.
7298         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7299
7300 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7301
7302         * gdbtypes.c (type_align): A struct with no non-static fields also
7303         has alignment of 1.
7304
7305 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7306
7307         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7308         component to 0.
7309         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7310         member.
7311         (riscv_struct_info::analyse): New implementation using new
7312         analyse_inner member function.
7313         (riscv_struct_info::field_offset): New member function.
7314         (riscv_struct_info::m_offsets): New member variable.
7315         (riscv_struct_info::analyse_inner): New private member function,
7316         takes the old implementation of riscv_struct_info::analyse but
7317         extended to track field offsets.
7318         (riscv_call_arg_struct): Update the struct folding special cases
7319         to handle cases where empty C++ structs, which are non-zero
7320         length, are found.
7321         (riscv_arg_location): Initialise the length of each location, a
7322         non-zero length now indicates the location is in use.
7323         (riscv_push_dummy_call): Allow for the first location having a
7324         non-zero offset when setting up arguments.
7325         (riscv_return_value): Likewise, but for return values.
7326
7327 2019-04-11  Tom Tromey  <tromey@adacore.com>
7328
7329         * utils.c (internal_vproblem): Make "msg" const.
7330
7331 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7332
7333         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7334         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7335         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7336         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7337
7338 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7339
7340         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7341         function.
7342         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7343         of amd64_collect_native_gregset.
7344         (amd64_linux_nat_target::store_registers): Likewise.
7345
7346 2019-04-10  Tom Tromey  <tom@tromey.com>
7347
7348         * symtab.c (lookup_global_symbol_from_objfile)
7349         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7350         * objfiles.h (class separate_debug_iterator): New.
7351         (class separate_debug_range): New.
7352         (struct objfile) <separate_debug_objfiles>: New method.
7353         (objfile_separate_debug_iterate): Don't declare.
7354         * objfiles.c (separate_debug_iterator::operator++): Rename from
7355         objfile_separate_debug_iterate.
7356         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7357         iterator.
7358         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7359         iterator.
7360
7361 2019-04-10  Tom Tromey  <tom@tromey.com>
7362
7363         * symfile.c (reread_symbols): Remove old comment.
7364         * objfiles.c (free_all_objfiles): Fix a typo.
7365
7366 2019-04-10  Tom Tromey  <tom@tromey.com>
7367
7368         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7369         * minsyms.c (lookup_minimal_symbol): Use foreach.
7370         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7371         (lookup_minimal_symbol_solib_trampoline): Likewise.
7372         * symfile.c (reread_symbols): Use foreach.
7373
7374 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7375             Tom Tromey  <tromey@adacore.com>
7376
7377         PR rust/24414:
7378         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7379         (rust_lex_int_test): Change "value" to be LONGEST.
7380         (rust_lex_tests): Add test for long integer literal.
7381
7382 2019-04-09  Tom Tromey  <tromey@adacore.com>
7383
7384         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7385         to bool.
7386         (extended_remote_target::attach): Update.
7387         (remote_target::remote_notice_new_inferior): Update.
7388         (remote_target::add_current_inferior_and_thread): Update.
7389         * inferior.c (exit_inferior_1): Use "false".
7390         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7391
7392 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7393
7394         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7395         the "start" command.
7396
7397 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7398
7399         * python/py-inferior.c (infpy_thread_from_thread_handle):
7400         Adjust comments to reflect renaming of thread_from_thread_handle
7401         to thread_from_handle.  Adjust keywords.  Fix type error message.
7402         (inferior_object_methods): Add thread_from_handle.  Retain
7403         thread_from_thread_handle, but mark it as deprecated.
7404
7405 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7406
7407         * gdbthread.h (find_thread_by_handle): Revise declaration.
7408         * thread.c (find_thread_by_handle): Likewise.  Adjust
7409         implementation too.
7410         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7411         support for buffer objects as handles.
7412
7413 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7414
7415         * python/py-infthread.c (thpy_thread_handle): New function.
7416         (thread_object_methods): Register thpy_thread_handle.
7417
7418 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7419
7420         * gdbthread.h (thread_to_thread_handle): Declare.
7421         * thread.c (gdbtypes.h): Include.
7422         (thread_to_thread_handle): New function.
7423
7424         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7425         (target_thread_info_to_thread_handle): Declare.
7426         * target.c (target_thread_info_to_thread_handle): New function.
7427         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7428         * target-delegates.c: Regenerate.
7429
7430         * linux-thread-db.c (class thread_db_target): Add method
7431         thread_info_to_thread_handle.
7432         (thread_db_target::thread_info_to_thread_handle): Define.
7433         * remote.c (class remote_target): Add new method
7434         thread_info_to_thread_handle.
7435         (remote_target::thread_info_to_thread_handle): Define.
7436
7437 2019-04-08  Pedro Alves  <palves@redhat.com>
7438
7439         * common/common-exceptions.c (throw_exception): Don't create
7440         named object to throw; throw directly.
7441         (throw_it): Likewise.  Don't initialize gdb_exception::message
7442         here, with new; pass FMT and AP to the ctor instead.
7443         * common/common-exceptions.h: Include <string>.
7444         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7445         const char *, va_list)): New ctor.  Use std::make_shared.
7446         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7447         errors)): Delete.
7448         (gdb_exception_error::gdb_exception_error(enum errors, const char
7449         *, va_list)): New.
7450         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7451         Add assertion.
7452         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7453         errors)): Delete.
7454         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7455         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7456         Add assertion.
7457
7458 2019-04-08  Tom Tromey  <tom@tromey.com>
7459
7460         * valops.c (value_rtti_indirect_type): Replace throw_exception
7461         with throw.
7462         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7463         with throw.
7464         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7465         throw.
7466         * target.c (target_translate_tls_address): Replace throw_exception
7467         with throw.
7468         * stack.c (frame_apply_command_count): Replace throw_exception
7469         with throw.
7470         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7471         throw.
7472         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7473         with throw.
7474         * rs6000-tdep.c (rs6000_frame_cache)
7475         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7476         * remote.c: Replace throw_exception with throw.
7477         * record-full.c (record_full_message, record_full_wait_1)
7478         (record_full_restore): Replace throw_exception with throw.
7479         * record-btrace.c:
7480         (get_thread_current_frame_id, record_btrace_start_replaying)
7481         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7482         (cmd_record_btrace_start): Replace throw_exception with throw.
7483         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7484         throw.
7485         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7486         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7487         * linespec.c:
7488         (find_linespec_symbols): Replace throw_exception with throw.
7489         * infrun.c (displaced_step_prepare, resume): Replace
7490         throw_exception with throw.
7491         * infcmd.c (post_create_inferior): Replace throw_exception with
7492         throw.
7493         * inf-loop.c (inferior_event_handler): Replace throw_exception
7494         with throw.
7495         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7496         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7497         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7498         (get_prev_frame_always, get_frame_pc_if_available)
7499         (get_frame_address_in_block_if_available, get_frame_language):
7500         Replace throw_exception with throw.
7501         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7502         throw_exception with throw.
7503         * eval.c (fetch_subexp_value, evaluate_var_value)
7504         (evaluate_funcall, evaluate_subexp_standard): Replace
7505         throw_exception with throw.
7506         * dwarf2loc.c (call_site_find_chain)
7507         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7508         Replace throw_exception with throw.
7509         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7510         with throw.
7511         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7512         throw.
7513         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7514         * completer.c (complete_line_internal): Replace throw_exception
7515         with throw.
7516         * compile/compile-object-run.c (compile_object_run): Replace
7517         throw_exception with throw.
7518         * cli/cli-script.c (process_next_line): Replace throw_exception
7519         with throw.
7520         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7521         (btrace_enable, btrace_maint_update_pt_packets): Replace
7522         throw_exception with throw.
7523         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7524         throw_exception with throw.
7525         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7526         throw_exception with throw.
7527         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7528         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7529         * aarch64-tdep.c (aarch64_make_prologue_cache)
7530         (aarch64_make_stub_cache): Replace throw_exception with throw.
7531
7532 2019-04-08  Tom Tromey  <tom@tromey.com>
7533
7534         * common/common-exceptions.c (throw_exception): Rename from
7535         throw_exception_cxx.  Remove old copy.  Make argument const.
7536         (throw_it): Create and throw exception objects directly.
7537         * common/common-exceptions.h (throw_exception): Make argument
7538         const.
7539         (struct gdb_exception_error): Add constructor.
7540         (struct gdb_exception_quit): Add constructor.
7541
7542 2019-04-08  Tom Tromey  <tom@tromey.com>
7543
7544         * common/common-exceptions.h (exception_rethrow): Don't declare.
7545         (TRY_SJLJ): Update comment.
7546         (TRY, CATCH, END_CATCH): Remove.
7547         * common/common-exceptions.c (exception_rethrow): Remove.
7548
7549 2019-04-08  Tom Tromey  <tom@tromey.com>
7550
7551         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7552         Remove.
7553         (gdb_exception_error): Rename from
7554         gdb_exception_RETURN_MASK_ERROR.
7555         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7556         (gdb_quit_bad_alloc): Update.
7557         * aarch64-tdep.c: Update.
7558         * ada-lang.c: Update.
7559         * ada-typeprint.c: Update.
7560         * ada-valprint.c: Update.
7561         * amd64-tdep.c: Update.
7562         * arch-utils.c: Update.
7563         * break-catch-throw.c: Update.
7564         * breakpoint.c: Update.
7565         * btrace.c: Update.
7566         * c-varobj.c: Update.
7567         * cli/cli-cmds.c: Update.
7568         * cli/cli-interp.c: Update.
7569         * cli/cli-script.c: Update.
7570         * common/common-exceptions.c: Update.
7571         * common/new-op.c: Update.
7572         * common/selftest.c: Update.
7573         * compile/compile-c-symbols.c: Update.
7574         * compile/compile-cplus-symbols.c: Update.
7575         * compile/compile-object-load.c: Update.
7576         * compile/compile-object-run.c: Update.
7577         * completer.c: Update.
7578         * corelow.c: Update.
7579         * cp-abi.c: Update.
7580         * cp-support.c: Update.
7581         * cp-valprint.c: Update.
7582         * darwin-nat.c: Update.
7583         * disasm-selftests.c: Update.
7584         * dtrace-probe.c: Update.
7585         * dwarf-index-cache.c: Update.
7586         * dwarf-index-write.c: Update.
7587         * dwarf2-frame-tailcall.c: Update.
7588         * dwarf2-frame.c: Update.
7589         * dwarf2loc.c: Update.
7590         * dwarf2read.c: Update.
7591         * eval.c: Update.
7592         * event-loop.c: Update.
7593         * event-top.c: Update.
7594         * exec.c: Update.
7595         * f-valprint.c: Update.
7596         * fbsd-tdep.c: Update.
7597         * frame-unwind.c: Update.
7598         * frame.c: Update.
7599         * gdbtypes.c: Update.
7600         * gnu-v3-abi.c: Update.
7601         * guile/guile-internal.h: Update.
7602         * guile/scm-block.c: Update.
7603         * guile/scm-breakpoint.c: Update.
7604         * guile/scm-cmd.c: Update.
7605         * guile/scm-disasm.c: Update.
7606         * guile/scm-frame.c: Update.
7607         * guile/scm-lazy-string.c: Update.
7608         * guile/scm-math.c: Update.
7609         * guile/scm-param.c: Update.
7610         * guile/scm-ports.c: Update.
7611         * guile/scm-pretty-print.c: Update.
7612         * guile/scm-symbol.c: Update.
7613         * guile/scm-symtab.c: Update.
7614         * guile/scm-type.c: Update.
7615         * guile/scm-value.c: Update.
7616         * i386-linux-tdep.c: Update.
7617         * i386-tdep.c: Update.
7618         * inf-loop.c: Update.
7619         * infcall.c: Update.
7620         * infcmd.c: Update.
7621         * infrun.c: Update.
7622         * jit.c: Update.
7623         * language.c: Update.
7624         * linespec.c: Update.
7625         * linux-fork.c: Update.
7626         * linux-nat.c: Update.
7627         * linux-tdep.c: Update.
7628         * linux-thread-db.c: Update.
7629         * main.c: Update.
7630         * mi/mi-cmd-break.c: Update.
7631         * mi/mi-cmd-stack.c: Update.
7632         * mi/mi-interp.c: Update.
7633         * mi/mi-main.c: Update.
7634         * objc-lang.c: Update.
7635         * p-valprint.c: Update.
7636         * parse.c: Update.
7637         * ppc-linux-tdep.c: Update.
7638         * printcmd.c: Update.
7639         * python/py-arch.c: Update.
7640         * python/py-breakpoint.c: Update.
7641         * python/py-cmd.c: Update.
7642         * python/py-finishbreakpoint.c: Update.
7643         * python/py-frame.c: Update.
7644         * python/py-framefilter.c: Update.
7645         * python/py-gdb-readline.c: Update.
7646         * python/py-inferior.c: Update.
7647         * python/py-infthread.c: Update.
7648         * python/py-lazy-string.c: Update.
7649         * python/py-linetable.c: Update.
7650         * python/py-objfile.c: Update.
7651         * python/py-param.c: Update.
7652         * python/py-prettyprint.c: Update.
7653         * python/py-progspace.c: Update.
7654         * python/py-record-btrace.c: Update.
7655         * python/py-record.c: Update.
7656         * python/py-symbol.c: Update.
7657         * python/py-type.c: Update.
7658         * python/py-unwind.c: Update.
7659         * python/py-utils.c: Update.
7660         * python/py-value.c: Update.
7661         * python/python.c: Update.
7662         * record-btrace.c: Update.
7663         * record-full.c: Update.
7664         * remote-fileio.c: Update.
7665         * remote.c: Update.
7666         * riscv-tdep.c: Update.
7667         * rs6000-aix-tdep.c: Update.
7668         * rs6000-tdep.c: Update.
7669         * rust-exp.y: Update.
7670         * rust-lang.c: Update.
7671         * s390-tdep.c: Update.
7672         * selftest-arch.c: Update.
7673         * solib-dsbt.c: Update.
7674         * solib-frv.c: Update.
7675         * solib-spu.c: Update.
7676         * solib-svr4.c: Update.
7677         * solib.c: Update.
7678         * sparc64-linux-tdep.c: Update.
7679         * stack.c: Update.
7680         * symfile-mem.c: Update.
7681         * symmisc.c: Update.
7682         * target.c: Update.
7683         * thread.c: Update.
7684         * top.c: Update.
7685         * tracefile-tfile.c: Update.
7686         * tui/tui.c: Update.
7687         * typeprint.c: Update.
7688         * unittests/cli-utils-selftests.c: Update.
7689         * unittests/parse-connection-spec-selftests.c: Update.
7690         * valops.c: Update.
7691         * valprint.c: Update.
7692         * value.c: Update.
7693         * varobj.c: Update.
7694         * windows-nat.c: Update.
7695         * x86-linux-nat.c: Update.
7696         * xml-support.c: Update.
7697
7698 2019-04-08  Tom Tromey  <tom@tromey.com>
7699
7700         * xml-support.c: Use C++ exception handling.
7701         * x86-linux-nat.c: Use C++ exception handling.
7702         * windows-nat.c: Use C++ exception handling.
7703         * varobj.c: Use C++ exception handling.
7704         * value.c: Use C++ exception handling.
7705         * valprint.c: Use C++ exception handling.
7706         * valops.c: Use C++ exception handling.
7707         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7708         handling.
7709         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7710         * typeprint.c: Use C++ exception handling.
7711         * tui/tui.c: Use C++ exception handling.
7712         * tracefile-tfile.c: Use C++ exception handling.
7713         * top.c: Use C++ exception handling.
7714         * thread.c: Use C++ exception handling.
7715         * target.c: Use C++ exception handling.
7716         * symmisc.c: Use C++ exception handling.
7717         * symfile-mem.c: Use C++ exception handling.
7718         * stack.c: Use C++ exception handling.
7719         * sparc64-linux-tdep.c: Use C++ exception handling.
7720         * solib.c: Use C++ exception handling.
7721         * solib-svr4.c: Use C++ exception handling.
7722         * solib-spu.c: Use C++ exception handling.
7723         * solib-frv.c: Use C++ exception handling.
7724         * solib-dsbt.c: Use C++ exception handling.
7725         * selftest-arch.c: Use C++ exception handling.
7726         * s390-tdep.c: Use C++ exception handling.
7727         * rust-lang.c: Use C++ exception handling.
7728         * rust-exp.y: Use C++ exception handling.
7729         * rs6000-tdep.c: Use C++ exception handling.
7730         * rs6000-aix-tdep.c: Use C++ exception handling.
7731         * riscv-tdep.c: Use C++ exception handling.
7732         * remote.c: Use C++ exception handling.
7733         * remote-fileio.c: Use C++ exception handling.
7734         * record-full.c: Use C++ exception handling.
7735         * record-btrace.c: Use C++ exception handling.
7736         * python/python.c: Use C++ exception handling.
7737         * python/py-value.c: Use C++ exception handling.
7738         * python/py-utils.c: Use C++ exception handling.
7739         * python/py-unwind.c: Use C++ exception handling.
7740         * python/py-type.c: Use C++ exception handling.
7741         * python/py-symbol.c: Use C++ exception handling.
7742         * python/py-record.c: Use C++ exception handling.
7743         * python/py-record-btrace.c: Use C++ exception handling.
7744         * python/py-progspace.c: Use C++ exception handling.
7745         * python/py-prettyprint.c: Use C++ exception handling.
7746         * python/py-param.c: Use C++ exception handling.
7747         * python/py-objfile.c: Use C++ exception handling.
7748         * python/py-linetable.c: Use C++ exception handling.
7749         * python/py-lazy-string.c: Use C++ exception handling.
7750         * python/py-infthread.c: Use C++ exception handling.
7751         * python/py-inferior.c: Use C++ exception handling.
7752         * python/py-gdb-readline.c: Use C++ exception handling.
7753         * python/py-framefilter.c: Use C++ exception handling.
7754         * python/py-frame.c: Use C++ exception handling.
7755         * python/py-finishbreakpoint.c: Use C++ exception handling.
7756         * python/py-cmd.c: Use C++ exception handling.
7757         * python/py-breakpoint.c: Use C++ exception handling.
7758         * python/py-arch.c: Use C++ exception handling.
7759         * printcmd.c: Use C++ exception handling.
7760         * ppc-linux-tdep.c: Use C++ exception handling.
7761         * parse.c: Use C++ exception handling.
7762         * p-valprint.c: Use C++ exception handling.
7763         * objc-lang.c: Use C++ exception handling.
7764         * mi/mi-main.c: Use C++ exception handling.
7765         * mi/mi-interp.c: Use C++ exception handling.
7766         * mi/mi-cmd-stack.c: Use C++ exception handling.
7767         * mi/mi-cmd-break.c: Use C++ exception handling.
7768         * main.c: Use C++ exception handling.
7769         * linux-thread-db.c: Use C++ exception handling.
7770         * linux-tdep.c: Use C++ exception handling.
7771         * linux-nat.c: Use C++ exception handling.
7772         * linux-fork.c: Use C++ exception handling.
7773         * linespec.c: Use C++ exception handling.
7774         * language.c: Use C++ exception handling.
7775         * jit.c: Use C++ exception handling.
7776         * infrun.c: Use C++ exception handling.
7777         * infcmd.c: Use C++ exception handling.
7778         * infcall.c: Use C++ exception handling.
7779         * inf-loop.c: Use C++ exception handling.
7780         * i386-tdep.c: Use C++ exception handling.
7781         * i386-linux-tdep.c: Use C++ exception handling.
7782         * guile/scm-value.c: Use C++ exception handling.
7783         * guile/scm-type.c: Use C++ exception handling.
7784         * guile/scm-symtab.c: Use C++ exception handling.
7785         * guile/scm-symbol.c: Use C++ exception handling.
7786         * guile/scm-pretty-print.c: Use C++ exception handling.
7787         * guile/scm-ports.c: Use C++ exception handling.
7788         * guile/scm-param.c: Use C++ exception handling.
7789         * guile/scm-math.c: Use C++ exception handling.
7790         * guile/scm-lazy-string.c: Use C++ exception handling.
7791         * guile/scm-frame.c: Use C++ exception handling.
7792         * guile/scm-disasm.c: Use C++ exception handling.
7793         * guile/scm-cmd.c: Use C++ exception handling.
7794         * guile/scm-breakpoint.c: Use C++ exception handling.
7795         * guile/scm-block.c: Use C++ exception handling.
7796         * guile/guile-internal.h: Use C++ exception handling.
7797         * gnu-v3-abi.c: Use C++ exception handling.
7798         * gdbtypes.c: Use C++ exception handling.
7799         * frame.c: Use C++ exception handling.
7800         * frame-unwind.c: Use C++ exception handling.
7801         * fbsd-tdep.c: Use C++ exception handling.
7802         * f-valprint.c: Use C++ exception handling.
7803         * exec.c: Use C++ exception handling.
7804         * event-top.c: Use C++ exception handling.
7805         * event-loop.c: Use C++ exception handling.
7806         * eval.c: Use C++ exception handling.
7807         * dwarf2read.c: Use C++ exception handling.
7808         * dwarf2loc.c: Use C++ exception handling.
7809         * dwarf2-frame.c: Use C++ exception handling.
7810         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7811         * dwarf-index-write.c: Use C++ exception handling.
7812         * dwarf-index-cache.c: Use C++ exception handling.
7813         * dtrace-probe.c: Use C++ exception handling.
7814         * disasm-selftests.c: Use C++ exception handling.
7815         * darwin-nat.c: Use C++ exception handling.
7816         * cp-valprint.c: Use C++ exception handling.
7817         * cp-support.c: Use C++ exception handling.
7818         * cp-abi.c: Use C++ exception handling.
7819         * corelow.c: Use C++ exception handling.
7820         * completer.c: Use C++ exception handling.
7821         * compile/compile-object-run.c: Use C++ exception handling.
7822         * compile/compile-object-load.c: Use C++ exception handling.
7823         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7824         * compile/compile-c-symbols.c: Use C++ exception handling.
7825         * common/selftest.c: Use C++ exception handling.
7826         * common/new-op.c: Use C++ exception handling.
7827         * cli/cli-script.c: Use C++ exception handling.
7828         * cli/cli-interp.c: Use C++ exception handling.
7829         * cli/cli-cmds.c: Use C++ exception handling.
7830         * c-varobj.c: Use C++ exception handling.
7831         * btrace.c: Use C++ exception handling.
7832         * breakpoint.c: Use C++ exception handling.
7833         * break-catch-throw.c: Use C++ exception handling.
7834         * arch-utils.c: Use C++ exception handling.
7835         * amd64-tdep.c: Use C++ exception handling.
7836         * ada-valprint.c: Use C++ exception handling.
7837         * ada-typeprint.c: Use C++ exception handling.
7838         * ada-lang.c: Use C++ exception handling.
7839         * aarch64-tdep.c: Use C++ exception handling.
7840
7841 2019-04-08  Tom Tromey  <tom@tromey.com>
7842
7843         * xml-support.c (gdb_xml_parser::parse): Update.
7844         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7845         * value.c (show_convenience): Update.
7846         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7847         (test_parse_flags_qcs): Update.
7848         * thread.c (thr_try_catch_cmd): Update.
7849         * target.c (target_translate_tls_address): Update.
7850         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7851         (info_frame_command_core, frame_apply_command_count): Update.
7852         * rust-exp.y (rust_lex_exception_test): Update.
7853         * riscv-tdep.c (riscv_print_one_register_info): Update.
7854         * remote.c (remote_target::enable_btrace): Update.
7855         * record-btrace.c (record_btrace_enable_warn): Update.
7856         * python/py-utils.c (gdbpy_convert_exception): Update.
7857         * printcmd.c (do_one_display, print_variable_and_value): Update.
7858         * mi/mi-main.c (mi_print_exception): Update.
7859         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7860         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7861         * linux-nat.c (linux_nat_target::attach): Update.
7862         * linux-fork.c (class scoped_switch_fork_info): Update.
7863         * infrun.c (displaced_step_prepare): Update.
7864         * infcall.c (call_function_by_hand_dummy): Update.
7865         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7866         * gnu-v3-abi.c (print_one_vtable): Update.
7867         * frame.c (get_prev_frame_always): Update.
7868         * f-valprint.c (info_common_command_for_block): Update.
7869         * exec.c (try_open_exec_file): Update.
7870         * exceptions.c (print_exception, exception_print)
7871         (exception_fprintf, exception_print_same): Update.
7872         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7873         * dwarf-index-cache.c (index_cache::store)
7874         (index_cache::lookup_gdb_index): Update.
7875         * darwin-nat.c (maybe_cache_shell): Update.
7876         * cp-valprint.c (cp_print_value_fields): Update.
7877         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7878         (gcc_cplus_symbol_address): Update.
7879         * compile/compile-c-symbols.c (gcc_convert_symbol)
7880         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7881         * common/selftest.c: Update.
7882         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7883         a std::string.
7884         (exception_try_scope_entry, exception_try_scope_exit): Don't
7885         declare.
7886         (struct exception_try_scope): Remove.
7887         (TRY): Don't use exception_try_scope.
7888         (struct gdb_exception): Add constructor, operator=.
7889         <what>: New method.
7890         (struct gdb_exception_RETURN_MASK_ALL)
7891         (struct gdb_exception_RETURN_MASK_ERROR)
7892         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7893         (struct gdb_quit_bad_alloc): Update.
7894         * common/common-exceptions.c (exception_none): Change
7895         initializer.
7896         (struct catcher) <state, exception>: Initialize inline.
7897         <prev>: Remove member.
7898         (current_catcher): Remove.
7899         (catchers): New global.
7900         (exceptions_state_mc_init): Simplify.
7901         (catcher_pop): Remove.
7902         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7903         (try_scope_depth, exception_try_scope_entry)
7904         (exception_try_scope_exit): Remove.
7905         (throw_exception_sjlj): Update.
7906         (exception_messages, exception_messages_size): Remove.
7907         (throw_it): Simplify.
7908         (gdb_exception_sliced_copy): Remove.
7909         (throw_exception_cxx): Update.
7910         * cli/cli-script.c (script_from_file): Update.
7911         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7912         Update.
7913         * ada-valprint.c (ada_val_print): Update.
7914         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7915         (create_excep_cond_exprs): Update.
7916
7917 2019-04-08  Tom Tromey  <tom@tromey.com>
7918
7919         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7920         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7921         (TRY, CATCH, END_CATCH): Remove some definitions.
7922         * common/common-exceptions.c: Don't use GDB_XCPT.
7923         (catcher_list_size): Remove.
7924         (throw_exception, throw_it): Simplify.
7925
7926 2019-04-05  Tom Tromey  <tom@tromey.com>
7927
7928         Revert the header-sorting patch.
7929         * ft32-tdep.c: Revert.
7930         * frv-tdep.c: Revert.
7931         * frv-linux-tdep.c: Revert.
7932         * frame.c: Revert.
7933         * frame-unwind.c: Revert.
7934         * frame-base.c: Revert.
7935         * fork-child.c: Revert.
7936         * findvar.c: Revert.
7937         * findcmd.c: Revert.
7938         * filesystem.c: Revert.
7939         * filename-seen-cache.h: Revert.
7940         * filename-seen-cache.c: Revert.
7941         * fbsd-tdep.c: Revert.
7942         * fbsd-nat.h: Revert.
7943         * fbsd-nat.c: Revert.
7944         * f-valprint.c: Revert.
7945         * f-typeprint.c: Revert.
7946         * f-lang.c: Revert.
7947         * extension.h: Revert.
7948         * extension.c: Revert.
7949         * extension-priv.h: Revert.
7950         * expprint.c: Revert.
7951         * exec.h: Revert.
7952         * exec.c: Revert.
7953         * exceptions.c: Revert.
7954         * event-top.c: Revert.
7955         * event-loop.c: Revert.
7956         * eval.c: Revert.
7957         * elfread.c: Revert.
7958         * dwarf2read.h: Revert.
7959         * dwarf2read.c: Revert.
7960         * dwarf2loc.c: Revert.
7961         * dwarf2expr.h: Revert.
7962         * dwarf2expr.c: Revert.
7963         * dwarf2-frame.c: Revert.
7964         * dwarf2-frame-tailcall.c: Revert.
7965         * dwarf-index-write.h: Revert.
7966         * dwarf-index-write.c: Revert.
7967         * dwarf-index-common.c: Revert.
7968         * dwarf-index-cache.h: Revert.
7969         * dwarf-index-cache.c: Revert.
7970         * dummy-frame.c: Revert.
7971         * dtrace-probe.c: Revert.
7972         * disasm.h: Revert.
7973         * disasm.c: Revert.
7974         * disasm-selftests.c: Revert.
7975         * dictionary.c: Revert.
7976         * dicos-tdep.c: Revert.
7977         * demangle.c: Revert.
7978         * dcache.h: Revert.
7979         * dcache.c: Revert.
7980         * darwin-nat.h: Revert.
7981         * darwin-nat.c: Revert.
7982         * darwin-nat-info.c: Revert.
7983         * d-valprint.c: Revert.
7984         * d-namespace.c: Revert.
7985         * d-lang.c: Revert.
7986         * ctf.c: Revert.
7987         * csky-tdep.c: Revert.
7988         * csky-linux-tdep.c: Revert.
7989         * cris-tdep.c: Revert.
7990         * cris-linux-tdep.c: Revert.
7991         * cp-valprint.c: Revert.
7992         * cp-support.c: Revert.
7993         * cp-namespace.c: Revert.
7994         * cp-abi.c: Revert.
7995         * corelow.c: Revert.
7996         * corefile.c: Revert.
7997         * continuations.c: Revert.
7998         * completer.h: Revert.
7999         * completer.c: Revert.
8000         * complaints.c: Revert.
8001         * coffread.c: Revert.
8002         * coff-pe-read.c: Revert.
8003         * cli-out.h: Revert.
8004         * cli-out.c: Revert.
8005         * charset.c: Revert.
8006         * c-varobj.c: Revert.
8007         * c-valprint.c: Revert.
8008         * c-typeprint.c: Revert.
8009         * c-lang.c: Revert.
8010         * buildsym.c: Revert.
8011         * buildsym-legacy.c: Revert.
8012         * build-id.h: Revert.
8013         * build-id.c: Revert.
8014         * btrace.c: Revert.
8015         * bsd-uthread.c: Revert.
8016         * breakpoint.h: Revert.
8017         * breakpoint.c: Revert.
8018         * break-catch-throw.c: Revert.
8019         * break-catch-syscall.c: Revert.
8020         * break-catch-sig.c: Revert.
8021         * blockframe.c: Revert.
8022         * block.c: Revert.
8023         * bfin-tdep.c: Revert.
8024         * bfin-linux-tdep.c: Revert.
8025         * bfd-target.c: Revert.
8026         * bcache.c: Revert.
8027         * ax-general.c: Revert.
8028         * ax-gdb.h: Revert.
8029         * ax-gdb.c: Revert.
8030         * avr-tdep.c: Revert.
8031         * auxv.c: Revert.
8032         * auto-load.c: Revert.
8033         * arm-wince-tdep.c: Revert.
8034         * arm-tdep.c: Revert.
8035         * arm-symbian-tdep.c: Revert.
8036         * arm-pikeos-tdep.c: Revert.
8037         * arm-obsd-tdep.c: Revert.
8038         * arm-nbsd-tdep.c: Revert.
8039         * arm-nbsd-nat.c: Revert.
8040         * arm-linux-tdep.c: Revert.
8041         * arm-linux-nat.c: Revert.
8042         * arm-fbsd-tdep.c: Revert.
8043         * arm-fbsd-nat.c: Revert.
8044         * arm-bsd-tdep.c: Revert.
8045         * arch-utils.c: Revert.
8046         * arc-tdep.c: Revert.
8047         * arc-newlib-tdep.c: Revert.
8048         * annotate.h: Revert.
8049         * annotate.c: Revert.
8050         * amd64-windows-tdep.c: Revert.
8051         * amd64-windows-nat.c: Revert.
8052         * amd64-tdep.c: Revert.
8053         * amd64-sol2-tdep.c: Revert.
8054         * amd64-obsd-tdep.c: Revert.
8055         * amd64-obsd-nat.c: Revert.
8056         * amd64-nbsd-tdep.c: Revert.
8057         * amd64-nbsd-nat.c: Revert.
8058         * amd64-nat.c: Revert.
8059         * amd64-linux-tdep.c: Revert.
8060         * amd64-linux-nat.c: Revert.
8061         * amd64-fbsd-tdep.c: Revert.
8062         * amd64-fbsd-nat.c: Revert.
8063         * amd64-dicos-tdep.c: Revert.
8064         * amd64-darwin-tdep.c: Revert.
8065         * amd64-bsd-nat.c: Revert.
8066         * alpha-tdep.c: Revert.
8067         * alpha-obsd-tdep.c: Revert.
8068         * alpha-nbsd-tdep.c: Revert.
8069         * alpha-mdebug-tdep.c: Revert.
8070         * alpha-linux-tdep.c: Revert.
8071         * alpha-linux-nat.c: Revert.
8072         * alpha-bsd-tdep.c: Revert.
8073         * alpha-bsd-nat.c: Revert.
8074         * aix-thread.c: Revert.
8075         * agent.c: Revert.
8076         * addrmap.c: Revert.
8077         * ada-varobj.c: Revert.
8078         * ada-valprint.c: Revert.
8079         * ada-typeprint.c: Revert.
8080         * ada-tasks.c: Revert.
8081         * ada-lang.c: Revert.
8082         * aarch64-tdep.c: Revert.
8083         * aarch64-ravenscar-thread.c: Revert.
8084         * aarch64-newlib-tdep.c: Revert.
8085         * aarch64-linux-tdep.c: Revert.
8086         * aarch64-linux-nat.c: Revert.
8087         * aarch64-fbsd-tdep.c: Revert.
8088         * aarch64-fbsd-nat.c: Revert.
8089         * aarch32-linux-nat.c: Revert.
8090
8091 2019-04-05  Tom Tromey  <tom@tromey.com>
8092
8093         * ft32-tdep.c: Sort headers.
8094         * frv-tdep.c: Sort headers.
8095         * frv-linux-tdep.c: Sort headers.
8096         * frame.c: Sort headers.
8097         * frame-unwind.c: Sort headers.
8098         * frame-base.c: Sort headers.
8099         * fork-child.c: Sort headers.
8100         * findvar.c: Sort headers.
8101         * findcmd.c: Sort headers.
8102         * filesystem.c: Sort headers.
8103         * filename-seen-cache.h: Sort headers.
8104         * filename-seen-cache.c: Sort headers.
8105         * fbsd-tdep.c: Sort headers.
8106         * fbsd-nat.h: Sort headers.
8107         * fbsd-nat.c: Sort headers.
8108         * f-valprint.c: Sort headers.
8109         * f-typeprint.c: Sort headers.
8110         * f-lang.c: Sort headers.
8111         * extension.h: Sort headers.
8112         * extension.c: Sort headers.
8113         * extension-priv.h: Sort headers.
8114         * expprint.c: Sort headers.
8115         * exec.h: Sort headers.
8116         * exec.c: Sort headers.
8117         * exceptions.c: Sort headers.
8118         * event-top.c: Sort headers.
8119         * event-loop.c: Sort headers.
8120         * eval.c: Sort headers.
8121         * elfread.c: Sort headers.
8122         * dwarf2read.h: Sort headers.
8123         * dwarf2read.c: Sort headers.
8124         * dwarf2loc.c: Sort headers.
8125         * dwarf2expr.h: Sort headers.
8126         * dwarf2expr.c: Sort headers.
8127         * dwarf2-frame.c: Sort headers.
8128         * dwarf2-frame-tailcall.c: Sort headers.
8129         * dwarf-index-write.h: Sort headers.
8130         * dwarf-index-write.c: Sort headers.
8131         * dwarf-index-common.c: Sort headers.
8132         * dwarf-index-cache.h: Sort headers.
8133         * dwarf-index-cache.c: Sort headers.
8134         * dummy-frame.c: Sort headers.
8135         * dtrace-probe.c: Sort headers.
8136         * disasm.h: Sort headers.
8137         * disasm.c: Sort headers.
8138         * disasm-selftests.c: Sort headers.
8139         * dictionary.c: Sort headers.
8140         * dicos-tdep.c: Sort headers.
8141         * demangle.c: Sort headers.
8142         * dcache.h: Sort headers.
8143         * dcache.c: Sort headers.
8144         * darwin-nat.h: Sort headers.
8145         * darwin-nat.c: Sort headers.
8146         * darwin-nat-info.c: Sort headers.
8147         * d-valprint.c: Sort headers.
8148         * d-namespace.c: Sort headers.
8149         * d-lang.c: Sort headers.
8150         * ctf.c: Sort headers.
8151         * csky-tdep.c: Sort headers.
8152         * csky-linux-tdep.c: Sort headers.
8153         * cris-tdep.c: Sort headers.
8154         * cris-linux-tdep.c: Sort headers.
8155         * cp-valprint.c: Sort headers.
8156         * cp-support.c: Sort headers.
8157         * cp-namespace.c: Sort headers.
8158         * cp-abi.c: Sort headers.
8159         * corelow.c: Sort headers.
8160         * corefile.c: Sort headers.
8161         * continuations.c: Sort headers.
8162         * completer.h: Sort headers.
8163         * completer.c: Sort headers.
8164         * complaints.c: Sort headers.
8165         * coffread.c: Sort headers.
8166         * coff-pe-read.c: Sort headers.
8167         * cli-out.h: Sort headers.
8168         * cli-out.c: Sort headers.
8169         * charset.c: Sort headers.
8170         * c-varobj.c: Sort headers.
8171         * c-valprint.c: Sort headers.
8172         * c-typeprint.c: Sort headers.
8173         * c-lang.c: Sort headers.
8174         * buildsym.c: Sort headers.
8175         * buildsym-legacy.c: Sort headers.
8176         * build-id.h: Sort headers.
8177         * build-id.c: Sort headers.
8178         * btrace.c: Sort headers.
8179         * bsd-uthread.c: Sort headers.
8180         * breakpoint.h: Sort headers.
8181         * breakpoint.c: Sort headers.
8182         * break-catch-throw.c: Sort headers.
8183         * break-catch-syscall.c: Sort headers.
8184         * break-catch-sig.c: Sort headers.
8185         * blockframe.c: Sort headers.
8186         * block.c: Sort headers.
8187         * bfin-tdep.c: Sort headers.
8188         * bfin-linux-tdep.c: Sort headers.
8189         * bfd-target.c: Sort headers.
8190         * bcache.c: Sort headers.
8191         * ax-general.c: Sort headers.
8192         * ax-gdb.h: Sort headers.
8193         * ax-gdb.c: Sort headers.
8194         * avr-tdep.c: Sort headers.
8195         * auxv.c: Sort headers.
8196         * auto-load.c: Sort headers.
8197         * arm-wince-tdep.c: Sort headers.
8198         * arm-tdep.c: Sort headers.
8199         * arm-symbian-tdep.c: Sort headers.
8200         * arm-pikeos-tdep.c: Sort headers.
8201         * arm-obsd-tdep.c: Sort headers.
8202         * arm-nbsd-tdep.c: Sort headers.
8203         * arm-nbsd-nat.c: Sort headers.
8204         * arm-linux-tdep.c: Sort headers.
8205         * arm-linux-nat.c: Sort headers.
8206         * arm-fbsd-tdep.c: Sort headers.
8207         * arm-fbsd-nat.c: Sort headers.
8208         * arm-bsd-tdep.c: Sort headers.
8209         * arch-utils.c: Sort headers.
8210         * arc-tdep.c: Sort headers.
8211         * arc-newlib-tdep.c: Sort headers.
8212         * annotate.h: Sort headers.
8213         * annotate.c: Sort headers.
8214         * amd64-windows-tdep.c: Sort headers.
8215         * amd64-windows-nat.c: Sort headers.
8216         * amd64-tdep.c: Sort headers.
8217         * amd64-sol2-tdep.c: Sort headers.
8218         * amd64-obsd-tdep.c: Sort headers.
8219         * amd64-obsd-nat.c: Sort headers.
8220         * amd64-nbsd-tdep.c: Sort headers.
8221         * amd64-nbsd-nat.c: Sort headers.
8222         * amd64-nat.c: Sort headers.
8223         * amd64-linux-tdep.c: Sort headers.
8224         * amd64-linux-nat.c: Sort headers.
8225         * amd64-fbsd-tdep.c: Sort headers.
8226         * amd64-fbsd-nat.c: Sort headers.
8227         * amd64-dicos-tdep.c: Sort headers.
8228         * amd64-darwin-tdep.c: Sort headers.
8229         * amd64-bsd-nat.c: Sort headers.
8230         * alpha-tdep.c: Sort headers.
8231         * alpha-obsd-tdep.c: Sort headers.
8232         * alpha-nbsd-tdep.c: Sort headers.
8233         * alpha-mdebug-tdep.c: Sort headers.
8234         * alpha-linux-tdep.c: Sort headers.
8235         * alpha-linux-nat.c: Sort headers.
8236         * alpha-bsd-tdep.c: Sort headers.
8237         * alpha-bsd-nat.c: Sort headers.
8238         * aix-thread.c: Sort headers.
8239         * agent.c: Sort headers.
8240         * addrmap.c: Sort headers.
8241         * ada-varobj.c: Sort headers.
8242         * ada-valprint.c: Sort headers.
8243         * ada-typeprint.c: Sort headers.
8244         * ada-tasks.c: Sort headers.
8245         * ada-lang.c: Sort headers.
8246         * aarch64-tdep.c: Sort headers.
8247         * aarch64-ravenscar-thread.c: Sort headers.
8248         * aarch64-newlib-tdep.c: Sort headers.
8249         * aarch64-linux-tdep.c: Sort headers.
8250         * aarch64-linux-nat.c: Sort headers.
8251         * aarch64-fbsd-tdep.c: Sort headers.
8252         * aarch64-fbsd-nat.c: Sort headers.
8253         * aarch32-linux-nat.c: Sort headers.
8254
8255 2019-04-04  Tom Tromey  <tom@tromey.com>
8256
8257         * varobj.c (varobj_create): Update.
8258         * rust-exp.y (struct rust_parser) <update_innermost_block,
8259         lookup_symbol>: New methods.
8260         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8261         Rename.
8262         (rust_parser::rust_lookup_type)
8263         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8264         * printcmd.c (display_command, do_one_display): Update.
8265         * parser-defs.h (struct parser_state) <parser_state>: Add
8266         "tracker" parameter.
8267         (block_tracker): New member.
8268         (class innermost_block_tracker) <innermost_block_tracker>: Add
8269         "types" parameter.
8270         <reset>: Remove method.
8271         (innermost_block): Don't declare.
8272         (null_post_parser): Update.
8273         * parse.c (innermost_block): Remove global.
8274         (write_dollar_variable): Update.
8275         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8276         Remove "tracker_types" parameter.
8277         (parse_expression): Add "tracker" parameter.
8278         (parse_expression_for_completion): Update.
8279         (null_post_parser): Add "tracker" parameter.
8280         * p-exp.y: Update rules.
8281         * m2-exp.y: Update rules.
8282         * language.h (struct language_defn) <la_post_parser>: Add
8283         "tracker" parameter.
8284         * go-exp.y: Update rules.
8285         * f-exp.y: Update rules.
8286         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8287         parameter.
8288         * d-exp.y: Update rules.
8289         * c-exp.y: Update rules.
8290         * breakpoint.c (set_breakpoint_condition): Create an
8291         innermost_block_tracker.
8292         (watch_command_1): Likewise.
8293         * ada-lang.c (resolve): Add "tracker" parameter.
8294         (resolve_subexp): Likewise.
8295         * ada-exp.y (write_var_from_sym): Update.
8296
8297 2019-04-04  Tom Tromey  <tom@tromey.com>
8298
8299         * type-stack.h: New file.
8300         * type-stack.c: New file.
8301         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8302         type-stack.h.
8303         (insert_into_type_stack, insert_type, push_type, push_type_int)
8304         (insert_type_address_space, pop_type, pop_type_int)
8305         (pop_typelist, pop_type_stack, append_type_stack)
8306         (push_type_stack, get_type_stack, push_typelist)
8307         (follow_type_instance_flags, follow_types): Don't declare.
8308         * parse.c (type_stack): Remove global.
8309         (parse_exp_in_context): Update.
8310         (insert_into_type_stack, insert_type, push_type, push_type_int)
8311         (insert_type_address_space, pop_type, pop_type_int)
8312         (pop_typelist, pop_type_stack, append_type_stack)
8313         (push_type_stack, get_type_stack, push_typelist)
8314         (follow_type_instance_flags, follow_types): Remove (moved to
8315         type-stack.c).
8316         * f-exp.y (type_stack): New global.
8317         Update rules.
8318         (push_kind_type, f_parse): Update.
8319         * d-exp.y (type_stack): New global.
8320         Update rules.
8321         (d_parse): Update.
8322         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8323         Update rules.
8324         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8325         (HFILES_NO_SRCDIR): Add type-stack.h.
8326
8327 2019-04-04  Tom Tromey  <tom@tromey.com>
8328
8329         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8330         (rust_parser::convert_ast_to_expression, rust_parse)
8331         (rust_lex_test_completion, rust_lex_tests): Update.
8332         * parser-defs.h (struct expr_completion_state): New.
8333         (struct parser_state) <parser_state>: Add completion parameter.
8334         <mark_struct_expression, mark_completion_tag>: New methods.
8335         <parse_completion, m_completion_state>: New members.
8336         (prefixify_expression, null_post_parser): Update.
8337         (mark_struct_expression, mark_completion_tag): Don't declare.
8338         * parse.c (parse_completion, expout_last_struct)
8339         (expout_tag_completion_type, expout_completion_name): Remove
8340         globals.
8341         (parser_state::mark_struct_expression)
8342         (parser_state::mark_completion_tag): Now methods.
8343         (prefixify_expression): Add last_struct parameter.
8344         (prefixify_subexp): Likewise.
8345         (parse_exp_1): Update.
8346         (parse_exp_in_context): Add cstate parameter.  Update.
8347         (parse_expression_for_completion): Create an
8348         expr_completion_state.
8349         (null_post_parser): Add "completion" parameter.
8350         * p-exp.y: Update rules.
8351         (yylex): Update.
8352         * language.h (struct language_defn) <la_post_parser>: Add
8353         "completing" parameter.
8354         * go-exp.y: Update rules.
8355         (lex_one_token): Update.
8356         * expression.h (parse_completion): Don't declare.
8357         * d-exp.y: Update rules.
8358         (lex_one_token): Update rules.
8359         * c-exp.y: Update rules.
8360         (lex_one_token): Update.
8361         * ada-lang.c (resolve): Add "parse_completion" parameter.
8362         (resolve_subexp): Likewise.
8363         (ada_resolve_function): Likewise.
8364
8365 2019-04-04  Tom Tromey  <tom@tromey.com>
8366
8367         * parser-defs.h (struct parser_state) <start_arglist,
8368         end_arglist>: New methods.
8369         <arglist_len, m_funcall_chain>: New members.
8370         (arglist_len, start_arglist, end_arglist): Don't declare.
8371         * parse.c (arglist_len, funcall_chain): Remove global.
8372         (start_arglist, end_arglist): Remove functions.
8373         (parse_exp_in_context): Update.
8374         * p-exp.y: Update rules.
8375         * m2-exp.y: Update rules.
8376         * go-exp.y: Update rules.
8377         * f-exp.y: Update rules.
8378         * d-exp.y: Update rules.
8379         * c-exp.y: Update rules.
8380
8381 2019-04-04  Tom Tromey  <tom@tromey.com>
8382
8383         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8384         lex_operator, push_back>: New methods.
8385         Update all rules.
8386         (rust_parser::lex_hex, lex_escape): Rename and update.
8387         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8388         (rust_parser::lex_operator): Rename and update.
8389         (rust_parser::lex_number, rustyylex, rustyyerror)
8390         (rust_lex_test_init, rust_lex_test_sequence)
8391         (rust_lex_test_push_back, rust_lex_tests): Update.
8392         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8393         parameter.
8394         <lexptr, prev_lexptr>: New members.
8395         (lexptr, prev_lexptr): Don't declare.
8396         * parse.c (lexptr, prev_lexptr): Remove globals.
8397         (parse_exp_in_context): Update.
8398         * p-exp.y (yylex, yyerror): Update.
8399         * m2-exp.y (parse_number, yylex, yyerror): Update.
8400         * go-exp.y (lex_one_token, yyerror): Update.
8401         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8402         * d-exp.y (lex_one_token, yyerror): Update.
8403         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8404         (lex_one_token, yyerror): Update.
8405         * ada-lex.l (YY_INPUT): Update.
8406         (rewind_to_char): Update.
8407         * ada-exp.y (yyerror): Update.
8408
8409 2019-04-04  Tom Tromey  <tom@tromey.com>
8410
8411         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8412         * parser-defs.h (struct parser_state) <parser_state>: Add new
8413         parameter.
8414         <comma_terminates>: New member.
8415         (comma_terminates): Don't declare global.
8416         * parse.c (comma_terminates): Remove global.
8417         (parse_exp_in_context): Update.
8418         * p-exp.y (yylex): Update.
8419         * m2-exp.y (yylex): Update.
8420         * go-exp.y (lex_one_token): Update.
8421         * f-exp.y (yylex): Update.
8422         * d-exp.y (lex_one_token): Update.
8423         * c-exp.y (lex_one_token): Update.
8424         * ada-lex.l: Update.
8425
8426 2019-04-04  Tom Tromey  <tom@tromey.com>
8427
8428         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8429         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8430         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8431         * parser-defs.h (paren_depth): Don't declare.
8432         * parse.c (paren_depth): Remove global.
8433         (parse_exp_in_context): Update.
8434         * p-exp.y (paren_depth): New global.
8435         (pascal_parse): Initialize it.
8436         * m2-exp.y (paren_depth): New global.
8437         (m2_parse): Initialize it.
8438         * go-exp.y (paren_depth): New global.
8439         (go_parse): Initialize it.
8440         * f-exp.y (paren_depth): New global.
8441         (f_parse): Initialize it.
8442         * d-exp.y (paren_depth): New global.
8443         (d_parse): Initialize it.
8444         * c-exp.y (paren_depth): New global.
8445         (c_parse): Initialize it.
8446         * ada-lex.l (paren_depth): New global.
8447         (lexer_init): Initialize it.
8448
8449 2019-04-04  Tom Tromey  <tom@tromey.com>
8450
8451         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8452         (rust_parser::convert_ast_to_type)
8453         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8454         * parser-defs.h (struct parser_state) <parser_state>: Add
8455         parameters.  Initialize new members.
8456         <expression_context_block, expression_context_pc>: New members.
8457         * parse.c (expression_context_block, expression_context_pc):
8458         Remove globals.
8459         (parse_exp_in_context): Update.
8460         * p-exp.y: Update all rules.
8461         (yylex): Update.
8462         * m2-exp.y: Update all rules.
8463         (yylex): Update.
8464         * go-exp.y (yylex): Update.
8465         * f-exp.y (yylex): Update.
8466         * d-exp.y: Update all rules.
8467         (yylex): Update.
8468         * c-exp.y: Update all rules.
8469         (lex_one_token, classify_name, yylex, c_parse): Update.
8470         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8471
8472 2019-04-04  Tom Tromey  <tom@tromey.com>
8473
8474         * gdbarch.h, gdbarch.c: Rebuild.
8475         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8476         * stap-probe.h:
8477         (struct stap_parse_info): Replace "parser_state" with
8478         "expr_builder".
8479         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8480         (parser_state): New class.
8481         * parse.c (expr_builder): Rename.
8482         (expr_builder::release): Rename.
8483         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8484         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8485         (write_exp_elt_longcst, write_exp_elt_floatcst)
8486         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8487         (write_exp_string_vector, write_exp_bitstring)
8488         (write_exp_msymbol, mark_struct_expression)
8489         (write_dollar_variable)
8490         (insert_type_address_space, increase_expout_size): Replace
8491         "parser_state" with "expr_builder".
8492         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8493         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8494         "parser_state" with "expr_builder".
8495
8496 2019-04-04  Tom Tromey  <tom@tromey.com>
8497
8498         * rust-exp.y: Replace "parse_language" with method call.
8499         * p-exp.y:
8500         (yylex): Replace "parse_language" with method call.
8501         * m2-exp.y:
8502         (yylex): Replace "parse_language" with method call.
8503         * go-exp.y (classify_name): Replace "parse_language" with method
8504         call.
8505         * f-exp.y (yylex): Replace "parse_language" with method call.
8506         * d-exp.y (lex_one_token): Replace "parse_language" with method
8507         call.
8508         * c-exp.y:
8509         (lex_one_token, classify_name, yylex): Replace "parse_language"
8510         with method call.
8511         * ada-exp.y (find_primitive_type, type_char)
8512         (type_system_address): Replace "parse_language" with method call.
8513
8514 2019-04-04  Tom Tromey  <tom@tromey.com>
8515
8516         * rust-exp.y: Replace "parse_gdbarch" with method call.
8517         * parse.c (write_dollar_variable, insert_type_address_space):
8518         Replace "parse_gdbarch" with method call.
8519         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8520         call.
8521         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8522         call.
8523         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8524         "parse_gdbarch" with method call.
8525         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8526         with method call.
8527         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8528         "parse_gdbarch" with method call.
8529         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8530         "parse_gdbarch" with method call.
8531         * c-exp.y (parse_type, parse_number, classify_name): Replace
8532         "parse_gdbarch" with method call.
8533         * ada-lex.l: Replace "parse_gdbarch" with method call.
8534         * ada-exp.y (parse_type, find_primitive_type, type_char)
8535         (type_system_address): Replace "parse_gdbarch" with method call.
8536
8537 2019-04-04  Tom Tromey  <tom@tromey.com>
8538
8539         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8540         * stap-probe.c (stap_parse_argument): Update.
8541         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8542         initial_size parameter.
8543         * rust-exp.y (rust_lex_tests): Update.
8544         * parse.c (parser_state): Update.
8545         (parse_exp_in_context): Update.
8546         * parser-defs.h (struct parser_state) <parser_state>: Remove
8547         "initial_size" parameter.
8548
8549 2019-04-04  Tom Tromey  <tom@tromey.com>
8550
8551         * parser-defs.h (increase_expout_size): Don't declare.
8552         * parse.c (increase_expout_size): Now static.
8553
8554 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8555
8556         * gnu-nat.c (gnu_nat_target::wait): Fix
8557         target_waitstatus_to_string call.
8558
8559 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8560
8561         * eval.c (evaluate_subexp_standard): Handle internal functions
8562         during Fortran function call handling.
8563
8564 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8565
8566         * NEWS: Mention new internal functions.
8567         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8568         (read_base_type): Use dwarf2_init_complex_target_type.
8569         * value.c (creal_internal_fn): New function.
8570         (cimag_internal_fn): New function.
8571         (_initialize_values): Register new internal functions.
8572
8573 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8574
8575         * infrun.c (stop_all_threads): If debug_infrun, always
8576         trace the wait status after wait_one, using
8577         target_waitstatus_to_string and target_pid_to_str.
8578         (handle_inferior_event): Replace various trace of
8579         wait status kind by a single trace.
8580         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8581         wait status kind image by target_waitstatus_to_string.
8582         * target/waitstatus.c (target_waitstatus_to_string): Fix
8583         obsolete comment.
8584
8585 2019-04-01  Tom Tromey  <tromey@adacore.com>
8586
8587         PR symtab/23331:
8588         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8589
8590 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8591             Pedro Alves  <palves@redhat.com>
8592
8593         * top.c (quit_force): Call 'finalize_values'.
8594         * value.c (finalize_values): New function.
8595         * value.h (finalize_values): Declare.
8596
8597 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8598
8599         * NEWS: Announce $_gdb_major and $_gdb_minor.
8600
8601         * top.c (init_gdb_version_vars): New function.
8602         (gdb_init): Call init_gdb_version_vars.
8603
8604 2019-03-29  Tom Tromey  <tromey@adacore.com>
8605
8606         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8607         help text.  Remove dead code.
8608
8609 2019-03-29  Keith Seitz  <keiths@redhat.com>
8610
8611         From Siddhesh Poyarekar:
8612         * f-lang.h (f77_get_upperbound): Return LONGEST.
8613         (f77_get_lowerbound): Likewise.
8614         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8615         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8616         print them.
8617         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8618         plongest to format print it.
8619         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8620         (f77_get_upperbound): Likewise.
8621         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8622         LOWER_BOUND to LONGEST.
8623         (f77_create_arrayprint_offset_tbl): Likewise.
8624
8625 2019-03-29  Keith Seitz  <keiths@redhat.com>
8626
8627         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8628         %s/pulongest for TYPE_LENGTH instead of %d in format
8629         strings.
8630         * ada-typerint.c (ada_print_type): Likewise.
8631         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8632         * compile/compile-c-support.c (generate_register_struct): Likewise.
8633         * gdbtypes.c (recursive_dump_type): Likewise.
8634         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8635         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8636         instead of %d in format strings.
8637         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8638         to std::min to ULONGEST.
8639         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8640         instead of %d in format strings.
8641         * tracepoint.c (info_scope_command): Likewise.
8642         * typeprint.c (print_offset_data::update)
8643         (print_offset_data::finish): Likewise.
8644         * xtensa-tdep.c (xtensa_store_return_value)
8645         (xtensa_push_dummy_call): Likewise.
8646
8647 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8648
8649         * windows-nat.c (display_selector): Fixed format specifications
8650         for 64-bit Cygwin.
8651
8652 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8653
8654         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8655
8656 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8657
8658         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8659         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8660         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8661         (nios2_linux_init_abi): Install it.
8662
8663 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8664
8665         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8666
8667 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8668
8669         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8670
8671 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8672             Tom Tromey  <tromey@adacore.com>
8673
8674         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8675
8676 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8677
8678         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8679         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8680         method to compute the bounds of range types. Also print "[evaluated]"
8681         if the bounds' values come from a dynamic evaluation.
8682
8683 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8684
8685         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8686         whitespace when pretty printing is on.
8687
8688 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8689
8690         * ppc-linux-nat.c: Add include.
8691
8692 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8693
8694         * NEWS: Mention AArch64 Pointer Authentication.
8695
8696 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8697
8698         * arm-linux-nat.c: Add include.
8699
8700 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8701
8702         * source-cache.c (source_cache::get_source_lines): Re-read
8703         fullname after calling open_source_file.
8704
8705 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8706
8707         * NEWS: Mention TLS support for FreeBSD.
8708
8709 2019-03-25  Tom Tromey  <tromey@adacore.com>
8710
8711         * minsyms.c (BUNCH_SIZE): Update comment.
8712         (~minimal_symbol_reader): Remove old comment.
8713         (compact_minimal_symbols): Update comment.
8714         (minimal_symbol_reader::install): Remove old comment.  Update
8715         other comments.
8716
8717 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8718
8719         * s390-linux-nat.c: Add include.
8720
8721 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8722
8723         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8724         Call linux_get_hwcap.
8725         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8726         Likewise.
8727         (aarch64_linux_get_hwcap): Remove function.
8728         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8729         declaration.
8730         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8731         linux_get_hwcap.
8732         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8733         * linux-tdep.c (linux_get_hwcap): Add function.
8734         (linux_get_hwcap2): Likewise.
8735         * linux-tdep.h (linux_get_hwcap): Add declaration.
8736         (linux_get_hwcap2): Likewise.
8737         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8738         (ppc_linux_get_hwcap2): Likewise.
8739         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8740         linux_get_hwcap.
8741         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8742         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8743         (ppc_linux_nat_target::read_description): Likewise.
8744         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8745         * s390-linux-nat.c: Likewise.
8746         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8747
8748 2019-03-24  Tom Tromey  <tom@tromey.com>
8749
8750         * ada-lang.c (standard_lookup): Simplify initialization.
8751         (ada_lookup_symbol_nonlocal): Simplify return.
8752         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8753         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8754         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8755         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8756         initialization.
8757         * solib.c (solib_global_lookup): Simplify.
8758         * symtab.c (null_block_symbol): Remove.
8759         (symbol_cache_lookup): Simplify returns.
8760         (lookup_language_this): Simplify returns.
8761         (lookup_symbol_aux): Simplify return.
8762         (lookup_local_symbol): Simplify returns.
8763         (lookup_global_symbol_from_objfile): Simplify return.
8764         (lookup_symbol_in_objfile_symtabs)
8765         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8766         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8767         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8768         * cp-namespace.c (cp_lookup_bare_symbol)
8769         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8770         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8771         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8772         (cp_lookup_symbol_via_imports): Simplify initialization.
8773         (find_symbol_in_baseclass): Likewise.
8774         * symtab.h (null_block_symbol): Remove.
8775         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8776         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8777         (d_lookup_symbol_module): Likewise.
8778         (find_symbol_in_baseclass): Simplify initialization.
8779
8780 2019-03-24  Tom Tromey  <tom@tromey.com>
8781
8782         * expression.h: Don't include symtab.h.
8783         (struct block): Forward declare.
8784
8785 2019-03-24  Tom Tromey  <tom@tromey.com>
8786
8787         * c-exp.y (typebase): Remove casts.
8788         * gdbtypes.c (lookup_unsigned_typename, )
8789         (lookup_signed_typename): Remove cast.
8790         * eval.c (parse_to_comma_and_eval): Remove cast.
8791         * parse.c (write_dollar_variable): Remove cast.
8792         * block.h (struct block) <superblock>: Now const.
8793         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8794         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8795         (map_block): Make "block" const.
8796         * symfile.h (struct quick_symbol_functions)
8797         <map_matching_symbols>: Constify block argument to "callback".
8798         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8799         const.
8800         (find_pc_sect_compunit_symtab): Make "b" const.
8801         (find_symbol_at_address): Likewise.
8802         (search_symbols): Likewise.
8803         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8804         (dw2_debug_names_lookup_symbol): Likewise.
8805         (dw2_map_matching_symbols): Update.
8806         * p-valprint.c (pascal_val_print): Remove "block".
8807         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8808         (aux_add_nonlocal_symbols): Make "block" const.
8809         (resolve_subexp): Remove cast.
8810         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8811         const.
8812         (iterate_over_file_blocks): Likewise.
8813         * f-exp.y (%union) <bval>: Remove.
8814         * coffread.c (patch_opaque_types): Make "b" const.
8815         * spu-tdep.c (spu_catch_start): Make "block" const.
8816         * c-valprint.c (print_unpacked_pointer): Remove "block".
8817         * symmisc.c (dump_symtab_1): Make "b" const.
8818         (block_depth): Make "block" const.
8819         * d-exp.y (%union) <bval>: Remove.
8820         * cp-support.h (cp_lookup_rtti_type): Update.
8821         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8822         * psymtab.c (psym_lookup_symbol): Make "block" const.
8823         (maintenance_check_psymtabs): Make "b" const.
8824         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8825         (enumerate_locals, enumerate_args): Update.
8826         * python/py-symtab.c (stpy_global_block): Make "block" const.
8827         (stpy_static_block): Likewise.
8828         * inline-frame.c (block_starting_point_at): Make "new_block"
8829         const.
8830         * block.c (find_block_in_blockvector): Make return type const.
8831         (blockvector_for_pc_sect): Make "b" const.
8832         (find_block_in_blockvector): Make "b" const.
8833
8834 2019-03-23  Tom Tromey  <tom@tromey.com>
8835
8836         * varobj.c (varobj_create): Update.
8837         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8838         * printcmd.c (display_command, do_one_display): Don't reset
8839         innermost_block.
8840         * parser-defs.h (enum innermost_block_tracker_type): Move to
8841         expression.h.
8842         (innermost_block): Update comment.
8843         * parse.c (parse_exp_1): Add tracker_types parameter.
8844         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8845         tracker_types parameter.  Reset innermost_block.
8846         (parse_exp_in_context): Remove.
8847         (parse_expression_for_completion): Update.
8848         * objfiles.c (~objfile): Don't reset expression_context_block or
8849         innermost_block.
8850         * expression.h (enum innermost_block_tracker_type): Move from
8851         parser-defs.h.
8852         (parse_exp_1): Add tracker_types parameter.
8853         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8854         reset innermost_block.
8855
8856 2019-03-23  Tom Tromey  <tom@tromey.com>
8857
8858         * objfiles.h: Include bcache.h.
8859
8860 2019-03-23  Tom Tromey  <tom@tromey.com>
8861
8862         * linespec.c (get_current_search_block): Use
8863         scoped_restore_current_language.
8864         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8865
8866 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8867             Jiong Wang  <jiong.wang@arm.com>
8868
8869         * aarch64-linux-tdep.c
8870         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8871         section.
8872         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8873
8874 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8875             Jiong Wang  <jiong.wang@arm.com>
8876
8877         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8878         instructions.
8879         (aarch64_analyze_prologue_test): Add PACIASP test.
8880         (aarch64_prologue_prev_register): Unmask PC value.
8881
8882 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8883             Jiong Wang  <jiong.wang@arm.com>
8884
8885         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8886         (aarch64_dwarf2_prev_register): Unmask PC value.
8887         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8888         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8889         DW_CFA_AARCH64_negate_ra_state.
8890         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8891
8892 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8893             Jiong Wang  <jiong.wang@arm.com>
8894
8895         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8896         registers.
8897         (aarch64_pseudo_register_name): Likewise.
8898         (aarch64_pseudo_register_type): Likewise.
8899         (aarch64_pseudo_register_reggroup_p): Likewise.
8900         (aarch64_gdbarch_init): Add pauth registers.
8901         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8902         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8903         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8904         (struct gdbarch_tdep): Add regnum for ra_state.
8905
8906 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8907             Jiong Wang  <jiong.wang@arm.com>
8908
8909         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8910
8911 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8912             Jiong Wang  <jiong.wang@arm.com>
8913
8914         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8915         function.
8916         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8917         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8918         (aarch64_gdbarch_init): Add puth registers.
8919         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8920         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8921         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8922
8923 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8924             Jiong Wang  <jiong.wang@arm.com>
8925
8926         * aarch64-linux-nat.c
8927         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8928         * aarch64-linux-tdep.c
8929         (aarch64_linux_core_read_description): Likewise.
8930         (aarch64_linux_get_hwcap): New function.
8931         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8932         (aarch64_linux_get_hwcap): New declaration.
8933
8934 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8935             Jiong Wang  <jiong.wang@arm.com>
8936
8937         * aarch64-linux-nat.c
8938         (aarch64_linux_nat_target::read_description): Add pauth param.
8939         * aarch64-linux-tdep.c
8940         (aarch64_linux_core_read_description): Likewise.
8941         * aarch64-tdep.c (struct target_desc): Add in pauth.
8942         (aarch64_read_description): Add pauth param.
8943         (aarch64_gdbarch_init): Likewise.
8944         * aarch64-tdep.h (aarch64_read_description): Likewise.
8945         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8946         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8947         * features/Makefile: Add new files.
8948         * features/aarch64-pauth.c: New file.
8949         * features/aarch64-pauth.xml: New file.
8950
8951 2019-03-20  Tom Tromey  <tromey@adacore.com>
8952
8953         * infrun.c (handle_inferior_event): Rename from
8954         handle_inferior_event_1.  Create a scoped_value_mark.
8955         (handle_inferior_event): Remove.
8956
8957 2019-03-19  Tom Tromey  <tromey@adacore.com>
8958
8959         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8960         * infrun.h (print_stop_event): Add "displays" parameter.
8961         * infrun.c (print_stop_event): Add "displays" parameter.
8962
8963 2019-03-19  Pedro Alves  <palves@redhat.com>
8964
8965         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8966         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8967         to -1.  Fix TABs vs spaces.
8968         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8969         * tui/tui-out.h (tui_ui_out) Add intro comments.
8970         <m_line, m_start_of_line>: In-class initialize, and add describing
8971         comment.
8972
8973 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8974
8975         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8976         variable names.
8977         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8978
8979 2019-03-18  Pedro Alves  <palves@redhat.com>
8980             Eli Zaretskii <eliz@gnu.org>
8981
8982         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8983         m_line and m_start_of_line.
8984
8985 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8986
8987         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8988         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8989         it returns a newline.  This fixes a regression in TU mode, whereby
8990         the next line is output on the same screen line as the user input.
8991
8992 2019-03-18  Tom Tromey  <tromey@adacore.com>
8993
8994         * minsyms.c (minimal_symbol_reader::install): Remove call to
8995         obstack_blank.
8996
8997 2019-03-18  Pedro Alves  <palves@redhat.com>
8998
8999         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9000         New globals.
9001         (apply_style): New, factored out from ...
9002         (apply_ansi_escape): ... this.  Handle reverse video mode.
9003         (tui_set_reverse_mode): New function.
9004         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9005         * tui/tui-winsource.c (tui_show_source_line): Use
9006         tui_set_reverse_mode instead of setting A_STANDOUT.
9007         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9008         New setter methods.
9009
9010 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9011
9012         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9013         Handle tabs.
9014
9015 2019-03-18  Tom Tromey  <tromey@adacore.com>
9016
9017         * ada-lang.c (empty_array): Add "high" parameter.
9018         (ada_evaluate_subexp): Update.
9019
9020 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9021
9022         * unittests/string_view-selftests.c: Define
9023         _initialize_string_view_selftests unconditionally.
9024
9025 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9026
9027         PR gdb/24350
9028         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9029
9030 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9031
9032         PR gdb/24351
9033         * windows-nat.c (display_selector): Fix format specifiers.
9034
9035 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9036
9037         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9038         tui_refill_source_window instead of tui_refresh_win, to update the
9039         current execution line.  This fixes redisplay of the current line
9040         when stepping through the code with "next" or "step".
9041
9042 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9043
9044         * source-cache.c (source_cache::get_source_lines): Call
9045         find_source_lines to initialize s->nlines.  This fixes vertical
9046         scrolling of TUI source window when the DOWN arrow is pressed.
9047
9048 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9049
9050         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9051         linux-thread-db.c (_initialize_thread_db): Likewise.
9052
9053 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9054
9055         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9056         wclrtoeol in tui_show_source_line".  This reverts changes made in
9057         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9058
9059 2019-03-15  Tom Tromey  <tom@tromey.com>
9060
9061         * symtab.h (struct minimal_symbol): Derive from
9062         general_symbol_info.
9063         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9064         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9065         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9066         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9067         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9068         (MSYMBOL_SEARCH_NAME): Update.
9069         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9070         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9071         * minsyms.c (minimal_symbol_reader::record_full): Update.
9072
9073 2019-03-15  Tom Tromey  <tom@tromey.com>
9074
9075         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9076
9077 2019-03-15  Tom Tromey  <tom@tromey.com>
9078
9079         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9080         unique_xmalloc_ptr.
9081         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9082         Update.
9083         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9084         (build_minimal_symbol_hash_tables)
9085         (minimal_symbol_reader::install): Update.
9086
9087 2019-03-15  Tom Tromey  <tom@tromey.com>
9088
9089         * symtab.c (create_demangled_names_hash): Update.
9090         (symbol_set_names): Update.
9091         * objfiles.h (struct objfile_per_bfd_storage)
9092         <demangled_names_hash>: Now an htab_up.
9093         * objfiles.c (objfile_per_bfd_storage): Simplify.
9094
9095 2019-03-15  Tom Tromey  <tom@tromey.com>
9096
9097         * objfiles.h (struct objfile_per_bfd_storage): Declare
9098         destructor.
9099         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9100         New.
9101         (get_objfile_bfd_data): Use new.  Don't initialize
9102         language_of_main.
9103         (free_objfile_per_bfd_storage): Remove.
9104         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9105
9106 2019-03-15  Tom Tromey  <tom@tromey.com>
9107
9108         * symfile.c (reread_symbols): Update.
9109         * objfiles.c (objfile::objfile): Update.
9110         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9111         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9112         comment.
9113         (minimal_symbol_reader::install): Update.
9114         (terminate_minimal_symbol_table): Remove.
9115         * jit.c (jit_object_close_impl): Update.
9116
9117 2019-03-15  Tom Tromey  <tom@tromey.com>
9118
9119         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9120         initializations.
9121
9122 2019-03-15  Tom Tromey  <tom@tromey.com>
9123
9124         * objfiles.h (struct objfile_per_bfd_storage)
9125         <demangled_hash_languages>: Now a bitset.
9126         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9127         (lookup_minimal_symbol): Update.
9128
9129 2019-03-15  Tom Tromey  <tom@tromey.com>
9130
9131         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9132         Don't return the symbol.
9133         * coffread.c (record_minimal_symbol): Use record_full.
9134
9135 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9136
9137         The MS-Windows port of ncurses fails to switch to a color pair if
9138         one or both of the colors are the implicit default colors.  This
9139         change records the default colors when TUI is initialized, and
9140         then specifies them explicitly when a color pair uses the default
9141         colors.  This allows color styling in TUI mode on MS-Windows.
9142
9143         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9144         ncurses_norm_attr.
9145         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9146         colors in ncurses_norm_attr.
9147         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9148         "none", replace it with the default color recorded in
9149         ncurses_norm_attr.
9150
9151 2019-03-14  Tom Tromey  <tromey@adacore.com>
9152
9153         * source-cache.h (class source_cache) <get_source_lines>: Return
9154         std::string.
9155         * source-cache.c (source_cache::extract_lines): Handle case where
9156         first_pos==npos.  Return std::string.
9157         (source_cache::get_source_lines): Update.
9158
9159 2019-03-14  Tom Tromey  <tromey@adacore.com>
9160
9161         * NEWS: Add item for "style sources" commands.
9162         * source-cache.c (source_cache::get_source_lines): Check
9163         source_styling.
9164         * cli/cli-style.c (source_styling): New global.
9165         (_initialize_cli_style): Add "style sources" commands.
9166         (show_style_sources): New function.
9167         * cli/cli-style.h (source_styling): Declare.
9168
9169 2019-03-14  Pedro Alves  <palves@redhat.com>
9170             Tom Tromey  <tromey@adacore.com>
9171
9172         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9173         * tui/tui-winsource.c (tui_refill_source_window): New function,
9174         from...
9175         (tui_horizontal_source_scroll): ... here.  Move some logic.
9176         * cli/cli-style.c (set_style_enabled): Notify new observable.
9177         * tui/tui-hooks.c (tui_redisplay_source): New function.
9178         (tui_attach_detach_observers): Attach or detach
9179         tui_redisplay_source.
9180         * observable.h (source_styling_changed): New observable.
9181         * observable.c: Define source_styling_changed observable.
9182
9183 2019-03-13  Tom Tromey  <tromey@adacore.com>
9184
9185         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9186         (i386_gnu_nat_target::store_registers): Update.
9187         * target-debug.h (target_debug_print_std_string): New macro.
9188         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9189         * windows-tdep.c (display_one_tib): Update.
9190         * tui/tui-stack.c (tui_make_status_line): Update.
9191         * top.c (print_inferior_quit_action): Update.
9192         * thread.c (thr_try_catch_cmd): Update.
9193         (add_thread_with_info): Update.
9194         (thread_target_id_str): Update.
9195         (thr_try_catch_cmd): Update.
9196         (thread_command): Update.
9197         (thread_find_command): Update.
9198         * record-btrace.c (record_btrace_target::info_record)
9199         (record_btrace_resume_thread, record_btrace_target::resume)
9200         (record_btrace_cancel_resume, record_btrace_step_thread)
9201         (record_btrace_target::wait, record_btrace_target::wait)
9202         (record_btrace_target::wait, record_btrace_target::stop): Update.
9203         * progspace.c (print_program_space): Update.
9204         * process-stratum-target.c
9205         (process_stratum_target::thread_address_space): Update.
9206         * linux-fork.c (linux_fork_mourn_inferior)
9207         (detach_checkpoint_command, info_checkpoints_command)
9208         (linux_fork_context): Update.
9209         (linux_fork_detach): Update.
9210         (class scoped_switch_fork_info): Update.
9211         (delete_checkpoint_command): Update.
9212         * infrun.c (follow_fork_inferior): Update.
9213         (follow_fork_inferior): Update.
9214         (proceed_after_vfork_done): Update.
9215         (handle_vfork_child_exec_or_exit): Update.
9216         (follow_exec): Update.
9217         (displaced_step_prepare_throw): Update.
9218         (displaced_step_restore): Update.
9219         (start_step_over): Update.
9220         (resume_1): Update.
9221         (clear_proceed_status_thread): Update.
9222         (proceed): Update.
9223         (print_target_wait_results): Update.
9224         (do_target_wait): Update.
9225         (context_switch): Update.
9226         (stop_all_threads): Update.
9227         (restart_threads): Update.
9228         (finish_step_over): Update.
9229         (handle_signal_stop): Update.
9230         (switch_back_to_stepped_thread): Update.
9231         (keep_going_pass_signal): Update.
9232         (print_exited_reason): Update.
9233         (normal_stop): Update.
9234         * inferior.c (inferior_pid_to_str): Change return type.
9235         (print_selected_inferior): Update.
9236         (add_inferior): Update.
9237         (detach_inferior): Update.
9238         * dummy-frame.c (fprint_dummy_frames): Update.
9239         * dcache.c (dcache_info_1): Update.
9240         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9241         (btrace_fetch, btrace_clear): Update.
9242         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9243         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9244         type.
9245         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9246         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9247         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9248         * gdbarch.c, gdbarch.h: Rebuild.
9249         * gdbarch.sh (core_pid_to_str): Change return type.
9250         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9251         return type.
9252         (windows_nat_target::pid_to_str): Change return type.
9253         (windows_delete_thread): Update.
9254         (windows_nat_target::attach): Update.
9255         (windows_nat_target::files_info): Update.
9256         * target-delegates.c: Rebuild.
9257         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9258         return type.
9259         (sol_thread_target::pid_to_str): Change return type.
9260         * remote.c (class remote_target) <pid_to_str>: Change return
9261         type.
9262         (remote_target::pid_to_str): Change return type.
9263         (extended_remote_target::attach, remote_target::remote_stop_ns)
9264         (remote_target::remote_notif_remove_queued_reply)
9265         (remote_target::push_stop_reply, remote_target::disable_btrace):
9266         Update.
9267         (extended_remote_target::attach): Update.
9268         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9269         type.
9270         (gdbsim_target::pid_to_str): Change return type.
9271         * ravenscar-thread.c (struct ravenscar_thread_target)
9272         <pid_to_str>: Change return type.
9273         (ravenscar_thread_target::pid_to_str): Change return type.
9274         * procfs.c (class procfs_target) <pid_to_str>: Change return
9275         type.
9276         (procfs_target::pid_to_str): Change return type.
9277         (procfs_target::attach): Update.
9278         (procfs_target::detach): Update.
9279         (procfs_target::fetch_registers): Update.
9280         (procfs_target::store_registers): Update.
9281         (procfs_target::wait): Update.
9282         (procfs_target::files_info): Update.
9283         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9284         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9285         return type.
9286         (nto_procfs_target::pid_to_str): Change return type.
9287         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9288         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9289         return type.
9290         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9291         (exit_lwp): Update.
9292         (attach_proc_task_lwp_callback, get_detach_signal)
9293         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9294         (linux_nat_target::resume, wait_lwp, stop_callback)
9295         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9296         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9297         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9298         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9299         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9300         type.
9301         (inf_ptrace_target::attach): Update.
9302         (inf_ptrace_target::files_info): Update.
9303         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9304         type.
9305         (go32_nat_target::pid_to_str): Change return type.
9306         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9307         (gnu_nat_target::wait): Update.
9308         (gnu_nat_target::wait): Update.
9309         (gnu_nat_target::resume): Update.
9310         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9311         (fbsd_nat_target::wait): Update.
9312         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9313         type.
9314         (darwin_nat_target::attach): Update.
9315         * corelow.c (class core_target) <pid_to_str>: Change return type.
9316         (core_target::pid_to_str): Change return type.
9317         * target.c (normal_pid_to_str): Change return type.
9318         (default_pid_to_str): Likewise.
9319         (target_pid_to_str): Change return type.
9320         (target_translate_tls_address): Update.
9321         (target_announce_detach): Update.
9322         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9323         return type.
9324         (bsd_uthread_target::pid_to_str): Change return type.
9325         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9326         type.
9327         (bsd_kvm_target::pid_to_str): Change return type.
9328         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9329         return type.
9330         (aix_thread_target::pid_to_str): Change return type.
9331         * target.h (struct target_ops) <pid_to_str>: Change return type.
9332         (target_pid_to_str, normal_pid_to_str): Likewise.
9333         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9334         type.
9335         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9336         type.
9337         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9338         return type.
9339         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9340         type.
9341         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9342         type.
9343         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9344         return type.
9345
9346 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9347
9348         * NEWS: Mention that the new default MI version is 3.  Mention
9349         changes to the output of commands and events that deal with
9350         multi-location breakpoints.
9351         * breakpoint.c: Include "mi/mi-out.h".
9352         (print_one_breakpoint): Change output syntax if using MI version
9353         >= 3.
9354         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9355         New.
9356         (mi_multi_location_breakpoint_output_fixed): New.
9357         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9358         (mi_cmd_fix_multi_location_breakpoint_output): New.
9359         (mi_multi_location_breakpoint_output_fixed): New.
9360         * mi/mi-cmds.c (mi_cmds): Register command
9361         -fix-multi-location-breakpoint-output.
9362         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9363         interpreter "mi".
9364
9365 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9366
9367         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9368         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9369         instantiate mi_ui_out based on interpreter name.
9370         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9371         * mi/mi-main.c (mi_load_progress): Likewise.
9372
9373 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9374
9375         * NEWS: Combine separate "New targets" sections for 8.3.
9376
9377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9378
9379         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9380         (ppcfbsd_init_abi): Install gdbarch
9381         "fetch_tls_load_module_address" and "get_thread_local_address"
9382         methods.
9383
9384 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9385
9386         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9387         (riscv_fbsd_init_abi): Install gdbarch
9388         "fetch_tls_load_module_address" and "get_thread_local_address"
9389         methods.
9390
9391 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9392
9393         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9394         (i386fbsd_init_abi): Install gdbarch
9395         "fetch_tls_load_module_address" and "get_thread_local_address"
9396         methods.
9397
9398 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9399
9400         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9401         (amd64fbsd_init_abi): Install gdbarch
9402         "fetch_tls_load_module_address" and "get_thread_local_address"
9403         methods.
9404
9405 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9406
9407         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9408         (struct fbsd_pspace_data): New type.
9409         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9410         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9411         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9412         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9413         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9414
9415 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9416
9417         * gdbtypes.c (lookup_struct_elt): New function.
9418         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9419         * gdbtypes.h (struct struct_elt): New type.
9420         (lookup_struct_elt): New prototype.
9421
9422 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9423
9424         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9425         remove disabled code block.
9426
9427 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9428
9429         * gdbarch.sh (get_thread_local_address): New method.
9430         * gdbarch.h, gdbarch.c: Regenerate.
9431         * target.c (target_translate_tls_address): Use
9432         gdbarch_get_thread_local_address if present instead of
9433         target::get_thread_local_address.
9434
9435 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9436
9437         * target.h (target::get_thread_local_address): Update comment.
9438
9439 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9440
9441         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9442         objfile->separate_debug_objfile_backlink if not NULL.
9443
9444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9445
9446         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9447         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9448         (amd64bsd_store_inferior_registers): Likewise.
9449         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9450         Enable segment base registers.
9451         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9452         PT_GETFSBASE and PT_GETGSBASE.
9453         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9454         PT_SETGSBASE.
9455         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9456         segment base registers.
9457         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9458
9459 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9460
9461         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9462         Update calls to i386_target_description to add 'segments'
9463         parameter.
9464         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9465         add segment base registers.
9466         * arch/i386.c (i386_create_target_description): Add 'segments'
9467         parameter to enable segment base registers.
9468         * arch/i386.h (i386_create_target_description): Likewise.
9469         * features/i386/32bit-segments.xml: New file.
9470         * features/i386/32bit-segments.c: Generate.
9471         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9472         call to i386_target_description to add 'segments' parameter.
9473         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9474         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9475         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9476         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9477         if feature is present.
9478         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9479         Add 'segments' parameter to call to i386_target_description.
9480         (i386_target_description): Add 'segments' parameter to enable
9481         segment base registers.
9482         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9483         to call to i386_target_description.
9484         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9485         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9486         Define I386_NUM_REGS.
9487         (i386_target_description): Add 'segments' parameter to enable
9488         segment base registers.
9489
9490 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9491
9492         PR/24325
9493         * source-cache.c: #undef open and close, to avoid unresolved
9494         externals during linking.
9495
9496 2019-03-12  Tom Tromey  <tromey@adacore.com>
9497
9498         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9499         const.  Add initializers.
9500         (_initialize_remote): Don't initialize ptid globals.
9501
9502 2019-03-12  Pedro Alves  <palves@redhat.com>
9503
9504         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9505
9506 2019-03-12  Pedro Alves  <palves@redhat.com>
9507
9508         * cp-name-parser.y (main): Remove unused 'len' variable.
9509
9510 2019-03-12  Tom Tromey  <tromey@adacore.com>
9511
9512         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9513         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9514
9515 2019-03-12  Tom Tromey  <tromey@adacore.com>
9516
9517         * linux-nat.c (iterate_over_lwps): Update.
9518         (stop_callback): Remove parameter.
9519         (stop_wait_callback, detach_callback, resume_set_callback)
9520         (select_singlestep_lwp_callback, set_ignore_sigint)
9521         (status_callback, resumed_callback, resume_clear_callback)
9522         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9523         data parameter.
9524         (linux_nat_target::detach, linux_nat_target::resume)
9525         (linux_stop_and_wait_all_lwps, select_event_lwp)
9526         (linux_nat_filter_event, linux_nat_wait_1)
9527         (linux_nat_target::kill, linux_nat_target::stop)
9528         (linux_nat_target::stop): Update.
9529         (linux_nat_resume_callback): Change type.
9530         (resume_stopped_resumed_lwps, count_events_callback)
9531         (select_event_lwp_callback): Likewise.
9532         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9533         * arm-linux-nat.c (struct update_registers_data): Remove.
9534         (update_registers_callback): Change type.
9535         (arm_linux_insert_hw_breakpoint1): Update.
9536         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9537         parameter.
9538         (x86_linux_dr_set_addr): Update.
9539         (x86_linux_dr_set_control): Update.
9540         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9541         (iterate_over_lwps): Use gdb::function_view.
9542         * nat/aarch64-linux-hw-point.c (struct
9543         aarch64_dr_update_callback_param): Remove.
9544         (debug_reg_change_callback): Change type.
9545         (aarch64_notify_debug_reg_change): Update.
9546         * s390-linux-nat.c (s390_refresh_per_info): Update.
9547
9548 2019-03-11  Tom Tromey  <tromey@adacore.com>
9549
9550         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9551         redundant assignment to "this_cu".
9552
9553 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9554
9555         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9556
9557 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9558
9559         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9560         from...
9561         (rank_one_type): ... this.
9562
9563 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9564
9565         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9566         from...
9567         (rank_one_type): ... this.
9568
9569 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9570
9571         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9572         from...
9573         (rank_one_type): ... this.
9574
9575 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9576
9577         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9578         from...
9579         (rank_one_type): ... this.
9580
9581 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9582
9583         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9584         from...
9585         (rank_one_type): ... this.
9586
9587 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9588
9589         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9590         from...
9591         (rank_one_type): ... this.
9592
9593 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9594
9595         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9596         from...
9597         (rank_one_type): ... this.
9598
9599 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9600
9601         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9602         from...
9603         (rank_one_type): ... this.
9604
9605 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9606
9607         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9608         from...
9609         (rank_one_type): ... this.
9610
9611 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9612
9613         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9614         from...
9615         (rank_one_type): ... this.
9616
9617 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9618
9619         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9620         from...
9621         (rank_one_type): ... this.
9622
9623 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9624
9625         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9626         from...
9627         (rank_one_type): ... this.
9628
9629 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9630
9631         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9632         inferior-events' shows the example events.
9633
9634 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9635
9636         Support styling on native MS-Windows console
9637
9638         PR/24315
9639         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9640         on MS-Windows if $TERM is not defined.
9641
9642         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9643
9644         * posix-hdep.c (gdb_console_fputs):
9645         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9646         functions.
9647         * ui-file.h (gdb_console_fputs): Add prototype.
9648
9649         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9650         back to fputs only if the former returns zero.
9651
9652 2019-03-07  Tom Tromey  <tom@tromey.com>
9653
9654         * symmisc.c (print_symbol_bcache_statistics): Update.
9655         (print_objfile_statistics): Update.
9656         * symfile.c (allocate_symtab): Update.
9657         * stabsread.c: Don't include bcache.h.
9658         * psymtab.h (struct psymbol_bcache): Don't declare.
9659         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9660         (psymbol_bcache_init, psymbol_bcache_free)
9661         (psymbol_bcache_get_bcache): Don't declare.
9662         * psymtab.c (struct psymbol_bcache): Remove.
9663         (psymtab_storage::psymtab_storage): Update.
9664         (psymtab_storage::~psymtab_storage): Update.
9665         (psymbol_bcache_init, psymbol_bcache_free)
9666         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9667         (add_psymbol_to_bcache): Update.
9668         (allocate_psymtab): Update.
9669         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9670         macro_cache>: No longer pointers.
9671         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9672         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9673         * macrotab.c (macro_bcache): Update.
9674         * macroexp.c: Don't include bcache.h.
9675         * gdbtypes.c (check_types_worklist): Update.
9676         (types_deeply_equal): Remove TRY/CATCH.  Update.
9677         * elfread.c (elf_symtab_read): Update.
9678         * dwarf2read.c: Don't include bcache.h.
9679         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9680         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9681         (print_bcache_statistics, bcache_memory_used): Don't declare.
9682         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9683         methods.  Rename all data members.
9684         * bcache.c (struct bcache): Move to bcache.h.
9685         (bcache::expand_hash_table): Rename from expand_hash_table.
9686         (bcache): Remove.
9687         (bcache::insert): Rename from bcache_full.
9688         (bcache::compare): Rename from bcache_compare.
9689         (bcache_xmalloc): Remove.
9690         (bcache::~bcache): Rename from bcache_xfree.
9691         (bcache::print_statistics): Rename from print_bcache_statistics.
9692         (bcache::memory_used): Rename from bcache_memory_used.
9693
9694 2019-03-07  Pedro Alves  <palves@redhat.com>
9695
9696         * infrun.c (normal_stop): Also check for
9697         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9698
9699 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9700
9701         * f-lang.c (value_from_host_double): Moved to...
9702         * value.c (value_from_host_double): ...here.
9703         * value.h (value_from_host_double): Declare.
9704         * guile/scm-math.c (vlscm_convert_typed_number): Use
9705         value_from_host_double.
9706         (vlscm_convert_number): Likewise.
9707         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9708         * python/py-value.c (convert_value_from_python): Likewise.
9709
9710 2019-03-06  Tom Tromey  <tom@tromey.com>
9711
9712         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9713
9714 2019-03-06  Tom Tromey  <tom@tromey.com>
9715
9716         * utils.h (free_current_contents): Don't declare.
9717         * utils.c (free_current_contents): Remove.
9718
9719 2019-03-06  Tom Tromey  <tom@tromey.com>
9720
9721         * top.c (quit_force): Update.
9722         * main.c (captured_command_loop): Update.
9723         * common/new-op.c (operator new): Update.
9724         * common/common-exceptions.c (struct catcher)
9725         <save_cleanup_chain>: Remove member.
9726         (exceptions_state_mc_init): Update.
9727         (exception_try_scope_entry): Return nullptr.
9728         (exception_try_scope_exit, exception_rethrow)
9729         (throw_exception_sjlj, throw_exception_cxx): Update.
9730         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9731         (all_cleanups, do_cleanups, discard_cleanups)
9732         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9733         (restore_cleanups, restore_final_cleanups): Don't declare.
9734         (do_final_cleanups): Remove parameter.
9735         * common/cleanups.c (cleanup_chain, make_cleanup)
9736         (make_cleanup_dtor, all_cleanups, do_cleanups)
9737         (discard_my_cleanups, discard_cleanups)
9738         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9739         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9740         (null_cleanup): Remove.
9741         (do_final_cleanups): Remove parameter.
9742
9743 2019-03-06  Tom Tromey  <tom@tromey.com>
9744
9745         * remote.c (remote_target::remote_parse_stop_reply): Use
9746         unique_xmalloc_ptr.
9747
9748 2019-03-06  Tom Tromey  <tom@tromey.com>
9749
9750         * stabsread.c (struct stabs_field_info): Rename from field_info.
9751         <list, fnlist>: Add initializers.
9752         <obstack>: New member.
9753         (read_member_functions, read_struct_fields, read_baseclasses):
9754         Allocate on obstack.  Don't use cleanups.
9755         (read_one_struct_field, read_member_functions, read_struct_fields)
9756         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9757         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9758         (read_struct_type): Update.
9759
9760 2019-03-06  Tom Tromey  <tom@tromey.com>
9761
9762         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9763         * common/filestuff.h (make_cleanup_close): Don't declare.
9764         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9765         Remove.
9766
9767 2019-03-06  Tom Tromey  <tom@tromey.com>
9768
9769         * solib-aix.c: Use make_scope_exit.
9770
9771 2019-03-06  Tom Tromey  <tom@tromey.com>
9772
9773         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9774         Use make_scope_exit.
9775
9776 2019-03-06  Tom Tromey  <tom@tromey.com>
9777
9778         * solib-svr4.c (disable_probes_interface): Remove parameter.
9779         (svr4_handle_solib_event): Use make_scope_exit.
9780
9781 2019-03-06  Tom Tromey  <tom@tromey.com>
9782
9783         * remote.c (struct stop_reply_deleter): Remove.
9784         (stop_reply_up): Update.
9785         (struct stop_reply): Derive from notif_event.  Don't typedef.
9786         <regcache>: Now a std::vector.
9787         (stop_reply_xfree): Remove.
9788         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9789         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9790         (remote_target::discard_pending_stop_replies): Use delete.
9791         (remote_target::remote_parse_stop_reply): Update.
9792         (remote_target::process_stop_reply): Update.
9793         * remote-notif.h (struct notif_event): Add virtual destructor.
9794         Remove "dtr" member.
9795         (struct notif_client) <alloc_event>: Return a unique_ptr.
9796         (notif_event_xfree): Don't declare.
9797         (notif_event_up): New typedef.
9798         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9799         (notif_event_xfree, do_notif_event_xfree): Remove.
9800         (remote_notif_state_xfree): Update.
9801
9802 2019-03-06  Tom Tromey  <tom@tromey.com>
9803
9804         * infrun.c (displaced_step_clear_cleanup): Now a
9805         forward_scope_exit type.
9806         (displaced_step_prepare_throw): Update.
9807         (displaced_step_fixup): Update.
9808
9809 2019-03-06  Tom Tromey  <tom@tromey.com>
9810
9811         * inferior.h (class inferior): Update comment.
9812         * gdbthread.h (class thread_info): Update comment.
9813
9814 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9815             Tom Tromey  <tom@tromey.com>
9816
9817         * stabsread.h (struct stab_section_list): Remove.
9818         (coffstab_build_psymtabs): Update.
9819         * dbxread.c (symbuf_sections): Now a std::vector.
9820         (sect_idx): New global.
9821         (fill_symbuf): Update.
9822         (coffstab_build_psymtabs): Change type of stabsects parameter.
9823         Update.
9824         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9825         std::vector.
9826         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9827         (coff_locate_sections): Update.
9828         (coff_symfile_read): Remove cleanups.  Update.
9829         (init_stringtab): Add storage parameter.
9830         (free_stringtab, free_stringtab_cleanup): Remove.
9831         (init_lineno): Add storage parameter.
9832         (free_linetab, free_linetab_cleanup): Remove.
9833
9834 2019-03-06  Pedro Alves  <palves@redhat.com>
9835
9836         * linux-fork.c (fork_info::clobber_regs): Delete.
9837         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9838         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9839         comment.  Adjust.
9840         (scoped_switch_fork_info::scoped_switch_fork_info)
9841         (checkpoint_command, linux_fork_context): Adjust
9842         fork_save_infrun_state calls.
9843
9844 2019-03-06  Pedro Alves  <palves@redhat.com>
9845
9846         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9847         (inf_has_multiple_threads): Return 'bool' and rewrite using
9848         inferior_info::threads().
9849
9850 2019-03-06  Pedro Alves  <palves@redhat.com>
9851
9852         * linux-fork.c: Include <list>.
9853         (fork_list): Now a std::list instance.
9854         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9855         (forks_exist_p, find_last_fork): Adjust.
9856         (new_fork): Delete.
9857         (one_fork_p): New.
9858         (add_fork): Adjust.
9859         (free_fork): Delete, folded into fork_info::~fork_info().
9860         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9861         Adjust.
9862         (init_fork_list): Delete.
9863         (linux_fork_killall, linux_fork_mourn_inferior)
9864         (linux_fork_detach, info_checkpoints_command): Adjust.
9865         (_initialize_linux_fork): No longer call init_fork_list.
9866
9867 2019-03-06  Pedro Alves  <palves@redhat.com>
9868
9869         * linux-fork.c (new_fork): New, split out of ...
9870         (add_fork): ... this.  Return void.  Move "first fork" special
9871         case from here, to ...
9872         (checkpoint_command): ... here.
9873         * linux-linux.h (add_fork): Return void.
9874
9875 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9876
9877         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9878
9879 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9880             Chris January  <chris.january@arm.com>
9881             David Lecomber  <david.lecomber@arm.com>
9882
9883         * f-exp.y: New token, UNOP_INTRINSIC.
9884         (exp): New pattern using UNOP_INTRINSIC token.
9885         (f77_keywords): Add 'abs' keyword.
9886         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9887         (value_from_host_double): New function.
9888         (evaluate_subexp_f): Support UNOP_ABS.
9889
9890 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9891
9892         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9893         types.
9894
9895 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9896
9897         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9898         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9899         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9900
9901 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9902
9903         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9904
9905 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9906             Chris January  <chris.january@arm.com>
9907
9908         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9909         * f-exp.y: Define 'KIND' token.
9910         (exp): New pattern for KIND expressions.
9911         (ptype): Handle types with a kind extension.
9912         (direct_abs_decl): Extend to spot kind extensions.
9913         (f77_keywords): Add 'kind' to the list.
9914         (push_kind_type): New function.
9915         (convert_to_kind_type): New function.
9916         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9917         * parse.c (operator_length_standard): Likewise.
9918         * parser-defs.h (enum type_pieces): Add tp_kind.
9919         * std-operator.def: Add UNOP_KIND.
9920
9921 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9922
9923         * f-exp.y (f_parse): Set yydebug.
9924
9925 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9926
9927         * f-lang.c (evaluate_subexp_f): New function.
9928         (exp_descriptor_f): New global.
9929         (f_language_defn): Use exp_descriptor_f instead of
9930         exp_descriptor_standard.
9931
9932 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9933
9934         * f-exp.y (struct token): Add comments.
9935         (dot_ops): Remove uppercase versions and the end marker.
9936         (f77_keywords): Likewise.
9937         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9938         entries in the dot_ops array are case insensitive, and use
9939         strncasecmp to compare strings.  Also some whitespace cleanup in
9940         this area.  Similar for the f77_keywords array, except entries in
9941         this list might be case sensitive.
9942
9943 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9944
9945         * f-exp.y (struct f77_boolean_val): Add comments.
9946         (boolean_values): Remove uppercase versions, and end marker.
9947         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9948         and use strncasecmp to achieve case insensitivity.  Additionally,
9949         perform whitespace cleanup around this code.
9950
9951 2019-03-06  Tom Tromey  <tromey@adacore.com>
9952
9953         * remote-sim.c (gdbsim_target_open): Use result of
9954         gdb_argv::release.
9955
9956 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9957         Dirk Schubert  <dirk.schubert@arm.com>
9958         Chris January  <chris.january@arm.com>
9959
9960         * eval.c (evaluate_subexp_standard): Call Fortran argument
9961         wrapping logic.
9962         * f-lang.c (struct value): A value which can be passed into a
9963         Fortran function call.
9964         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9965         where appropriate.
9966         (struct type): Value ready for a Fortran function call.
9967         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9968         is needed.
9969         * f-lang.h (fortran_argument_convert): Declaration.
9970         (fortran_preserve_arg_pointer): Declaration.
9971         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9972
9973 2019-03-05  Tom Tromey  <tromey@adacore.com>
9974
9975         * python/py-prettyprint.c (print_string_repr): Remove #if.
9976         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9977
9978 2019-03-05  Tom Tromey  <tromey@adacore.com>
9979
9980         * target.c (the_dummy_target): Move later.  Change type to
9981         "dummy_target".
9982         (initialize_targets): Don't initialize the_dummy_target.
9983
9984 2019-03-05  Tom Tromey  <tromey@adacore.com>
9985
9986         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9987         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9988
9989 2019-03-05  Tom Tromey  <tromey@adacore.com>
9990
9991         * windows-nat.c (windows_nat_target::attach)
9992         (windows_nat_target::detach): Don't call gdb_flush.
9993         * valprint.c (generic_val_print, val_print, val_print_string):
9994         Don't call gdb_flush.
9995         * utils.c (defaulted_query): Don't call gdb_flush.
9996         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9997         * target.c (target_announce_detach): Don't call gdb_flush.
9998         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9999         * remote.c (extended_remote_target::attach): Don't call
10000         gdb_flush.
10001         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10002         * printcmd.c (do_examine): Don't call gdb_flush.
10003         (info_display_command): Don't call gdb_flush.
10004         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10005         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10006         * memattr.c (info_mem_command): Don't call gdb_flush.
10007         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10008         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10009         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10010         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10011         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10012         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10013         (gnu_nat_target::detach): Don't call gdb_flush.
10014         * f-valprint.c (f_val_print): Don't call gdb_flush.
10015         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10016         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10017         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10018         gdb_flush.
10019         * c-valprint.c (c_val_print): Don't call gdb_flush.
10020         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10021
10022 2019-03-05  Tom Tromey  <tromey@adacore.com>
10023
10024         * varobj.c (update_dynamic_varobj_children): Update.
10025         (install_default_visualizer): Use reset, not release.
10026         * value.c (set_internalvar): Update.
10027         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10028         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10029         ATTRIBUTE_UNUSED_RESULT.
10030
10031 2019-03-05  Tom Tromey  <tromey@adacore.com>
10032
10033         * remote.c (class scoped_remote_fd) <release>: Add
10034         ATTRIBUTE_UNUSED_RESULT.
10035
10036 2019-03-05  Tom Tromey  <tromey@adacore.com>
10037
10038         * macroexp.c (struct macro_buffer) <release>: Add
10039         ATTRIBUTE_UNUSED_RESULT.
10040
10041 2019-03-05  Tom Tromey  <tromey@adacore.com>
10042
10043         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10044         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10045         ATTRIBUTE_UNUSED_RESULT.
10046
10047 2019-03-05  Tom Tromey  <tromey@adacore.com>
10048
10049         * common/scoped_fd.h (class scoped_fd) <release>: Add
10050         ATTRIBUTE_UNUSED_RESULT.
10051
10052 2019-03-05  Tom Tromey  <tromey@adacore.com>
10053
10054         * parser-defs.h (struct parser_state) <release>: Add
10055         ATTRIBUTE_UNUSED_RESULT.
10056
10057 2019-03-05  Tom Tromey  <tromey@adacore.com>
10058
10059         * utils.h (class gdb_argv) <release>: Add
10060         ATTRIBUTE_UNUSED_RESULT.
10061         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10062
10063 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10064
10065         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10066         for-loop range, to avoid compiler warnings.
10067
10068         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10069         avoid compiler warnings about unused variables.
10070
10071         * NEWS: Mention end of support for native debugging on MS-Windows
10072         before XP.
10073
10074         PR gdb/24292
10075         * common/netstuff.c:
10076         * gdbserver/gdbreplay.c
10077         * gdbserver/remote-utils.c:
10078         * ser-tcp.c:
10079         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10080         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10081         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10082         'getaddrinfo' and 'freeaddrinfo' were not available before
10083         Windows XP, and mingw.org's MinGW headers by default define
10084         _WIN32_WINNT to 0x500.
10085
10086 2019-03-01  Gary Benson <gbenson@redhat.com>
10087
10088         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10089
10090 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10091             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10092
10093         PR gdb/8527
10094         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10095         set_sigint_trap, clear_sigint_trap.
10096
10097 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10098
10099         * target.c (target_detach): Clear the regcache and the
10100         frame cache.
10101
10102 2019-02-27  Pedro Alves  <palves@redhat.com>
10103
10104         * utils.c (set_screen_size): When we cap the height/width sizes,
10105         tweak the corresponding command variable to show "unlimited":
10106
10107 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10108             Pedro Alves  <palves@redhat.com>
10109
10110         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10111         before calling rl_set_screen_size.
10112
10113 2019-02-27  Tom Tromey  <tromey@adacore.com>
10114
10115         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10116         define.
10117         * python/py-value.c: Remove Python 2.4 workaround.
10118         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10119         workaround.
10120         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10121         Python 2.4 workaround.
10122         * python/python-internal.h: Remove Python 2.4 comment.
10123         (Py_ssize_t): Don't define.
10124         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10125         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10126         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10127         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10128         * python/python.c (do_start_initialization): Remove Python 2.4
10129         workaround.
10130         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10131         (print_children): Remove Python 2.4 workaround.
10132         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10133         workaround.
10134         (CHARBUFFERPROC_NAME): Remove.
10135         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10136         Python 2.4 workaround.
10137
10138 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10139
10140         * NEWS: Note minimum Python version.
10141
10142 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10143
10144         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10145         code from these functions.  Remove corresponding ifdefs.  Use
10146         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10147         Remove gotos and target of gotos.
10148         (infpy_search_memory): Likewise.
10149
10150 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10151
10152         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10153         (hppa_gdbarch_init): Don't register deleted functions with
10154         gdbarch.
10155
10156 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10157
10158         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10159         (h8300_unwind_sp): Delete.
10160         (h8300_dummy_id): Delete.
10161         (h8300_gdbarch_init): Don't register deleted functions with
10162         gdbarch.
10163
10164 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10165
10166         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10167         (ft32_unwind_pc): Delete.
10168         (ft32_unwind_sp): Delete.
10169         (ft32_gdbarch_init): Don't register deleted functions with
10170         gdbarch.
10171
10172 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10173
10174         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10175         (frv_unwind_pc): Delete.
10176         (frv_unwind_sp): Delete.
10177         (frv_gdbarch_init): Don't register deleted functions with
10178         gdbarch.
10179
10180 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10181
10182         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10183         (riscv_unwind_pc): Delete.
10184         (riscv_unwind_sp): Delete.
10185         (riscv_gdbarch_init): Don't register deleted functions with
10186         gdbarch.
10187
10188 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10189
10190         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10191         (csky_unwind_pc): Delete.
10192         (csky_unwind_sp): Delete.
10193         (csky_gdbarch_init): Don't register deleted functions with
10194         gdbarch.
10195
10196 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10197
10198         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10199         (cris_unwind_pc): Delete.
10200         (cris_unwind_sp): Delete.
10201         (cris_gdbarch_init): Don't register deleted functions with
10202         gdbarch.
10203
10204 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10205
10206         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10207         (bfin_unwind_pc): Delete.
10208         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10209
10210 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10211
10212         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10213         (arm_unwind_pc): Delete.
10214         (arm_unwind_sp): Delete.
10215         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10216
10217 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10218
10219         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10220         (arc_unwind_pc): Delete.
10221         (arc_unwind_sp): Delete.
10222         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10223
10224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10225
10226         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10227         (alpha_unwind_pc): Delete.
10228         (alpha_gdbarch_init): Don't register deleted functions with
10229         gdbarch.
10230
10231 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10232
10233         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10234         (aarch64_unwind_pc): Delete.
10235         (aarch64_unwind_sp): Delete.
10236         (aarch64_gdbarch_init): Don't register deleted functions with
10237         gdbarch.
10238
10239 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10240
10241         * gdbtypes.c (type_align): Don't consider static members when
10242         computing structure alignment.
10243
10244 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10245
10246         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10247         return 0 for other types.
10248         * arch-utils.c (default_type_align): Always return 0.
10249         * gdbarch.h: Regenerate.
10250         * gdbarch.sh (type_align): Extend comment.
10251         * gdbtypes.c (type_align): Add additional comments, always call
10252         gdbarch_type_align before applying the default rules.
10253         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10254         generic code will then apply a suitable default.
10255         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10256         types, return 0 for other types.
10257
10258 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10259
10260         * NEWS: Create a new section for the next release branch.
10261         Rename the section of the current branch, now that it has
10262         been cut.
10263
10264 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10265
10266         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10267         * version.in: Bump version to 8.3.50.DATE-git.
10268
10269 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10270
10271         * aix-thread.c (ptid_cmp): Remove unused variable.
10272         (get_signaled_thread): Likewise.
10273         (store_regs_user_thread): Likewise.
10274         (store_regs_kernel_thread): Likewise.
10275         (fetch_regs_kernel_thread): Remove shadowed variable.
10276
10277 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10278
10279         * features/riscv/32bit-cpu.xml: Add register numbers.
10280         * features/riscv/32bit-fpu.c: Regenerate.
10281         * features/riscv/32bit-fpu.xml: Add register numbers.
10282         * features/riscv/64bit-cpu.xml: Add register numbers.
10283         * features/riscv/64bit-fpu.c: Regenerate.
10284         * features/riscv/64bit-fpu.xml: Add register numbers.
10285
10286 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10287
10288         * NEWS: Mention two argument form of gdb.Value constructor.
10289         * python/py-value.c (convert_buffer_and_type_to_value): New
10290         function.
10291         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10292         Add support for handling an optional second argument.  Call
10293         convert_buffer_and_type_to_value as appropriate.
10294         * python/python-internal.h (Py_buffer_deleter): New struct.
10295         (Py_buffer_up): New typedef.
10296
10297 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10298
10299         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10300         instead of releasing ownership.
10301
10302 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10303
10304         * dwarf2read.c (open_and_init_dwp_file): Call
10305         elf_numsections instead of bfd_count_sections to initialize
10306         dwp_file->num_sections.
10307
10308 2019-02-25  Tom Tromey  <tromey@adacore.com>
10309
10310         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10311
10312 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10313
10314         * gcore.in: Add '--readnever' option when invoking GDB.
10315
10316 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10317
10318         * MAINTAINERS: Update my email address.
10319
10320 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10321
10322         * build-id.c (build_id_to_debug_bfd_1): New function.
10323         (build_id_to_debug_bfd): Look for separate debug file in
10324         sysroot.
10325
10326 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10327
10328         * gdbarch.sh: Update the copyright year range that is placed into
10329         generated files.
10330
10331 2019-02-22  Keith Seitz  <keiths@redhat.com>
10332
10333         PR symtab/23853
10334         * linespec.c (create_sals_line_offset): Search for the default
10335         symtab's filename instead of its fullname.
10336
10337 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10338
10339         * NEWS: Update style defaults.
10340
10341 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10342
10343         * main.c (captured_main_1): Disable styling in batch mode.
10344
10345 2019-02-20  Tom Tromey  <tom@tromey.com>
10346
10347         * symtab.c (symtab_symbol_info): Fix typos.
10348
10349 2019-02-20  Tom Tromey  <tromey@adacore.com>
10350
10351         * findcmd.c (_initialize_mem_search): Use upper case for
10352         metasyntactic variables.
10353
10354 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10355
10356         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10357         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10358
10359 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10360
10361         * top.h (source_file_name): Change to std::string.
10362         * top.c (source_file_name): Likewise.
10363         (command_line_input): Adjust.
10364         * cli/cli-script.c (script_from_file): Adjust.
10365
10366 2019-02-19  Tom Tromey  <tromey@adacore.com>
10367
10368         * ravenscar-thread.c
10369         (ravenscar_thread_target::update_thread_list): Don't call
10370         ada_build_task_list.
10371         * ada-lang.h (ada_build_task_list): Don't declare.
10372         * ada-tasks.c (struct ada_tasks_inferior_data)
10373         <task_list_valid_p>: Now bool.
10374         (read_known_tasks, ada_task_list_changed)
10375         (ada_tasks_invalidate_inferior_data): Update.
10376         (read_known_tasks_array): Return bool.
10377         (read_known_tasks_list): Likewise.
10378         (read_known_tasks): Return void.
10379         (ada_build_task_list): Now static.
10380
10381 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10382
10383         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10384         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10385
10386 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10387
10388         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10389         variant for ada_tasks_pspace_data_handle and
10390         ada_tasks_inferior_data_handle.
10391         (ada_tasks_pspace_data_cleanup): New function.
10392         (ada_tasks_inferior_data_cleanup): New function.
10393
10394 2019-02-17  Tom Tromey  <tom@tromey.com>
10395
10396         * macrotab.h (macro_source_fullname): Return a std::string.
10397         * macrotab.c (macro_include, check_for_redefinition)
10398         (macro_undef, macro_lookup_definition, foreach_macro)
10399         (foreach_macro_in_scope): Update.
10400         (macro_source_fullname): Return a std::string.
10401         * macrocmd.c (show_pp_source_pos): Update.
10402
10403 2019-02-17  Tom Tromey  <tom@tromey.com>
10404
10405         * macrocmd.c (show_pp_source_pos): Style the file names.
10406
10407 2019-02-17  Tom Tromey  <tom@tromey.com>
10408
10409         PR tui/24197:
10410         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10411
10412 2019-02-17  Tom Tromey  <tom@tromey.com>
10413
10414         * ada-lang.c (user_select_syms): Use filtered printing.
10415         * utils.c (wrap_style): New global.
10416         (desired_style): Remove.
10417         (emit_style_escape): Add stream parameter.
10418         (set_output_style, reset_terminal_style, prompt_for_continue):
10419         Update.
10420         (flush_wrap_buffer): Only flush gdb_stdout.
10421         (wrap_here): Set wrap_style.
10422         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10423         treat escape sequences as a character.  Change when wrap buffer is
10424         flushed.
10425         (fputs_styled): Do not set the output style when the default is
10426         requested.
10427         * ui-style.h (struct ui_file_style) <is_default>: New method.
10428         * source.c (print_source_lines_base): Emit escape sequences in one
10429         piece.
10430
10431 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10432
10433         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10434         integers and enumeration types.
10435
10436 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10437
10438         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10439         instead of lookup_symbol_in_language
10440         (do_exact_match): New function.
10441         (ada_get_symbol_name_matcher): Return do_exact_match when
10442         doing a verbatim match.
10443
10444 2019-02-15  Tom Tromey  <tromey@adacore.com>
10445
10446         * ravenscar-thread.c (ravenscar_thread_target::resume)
10447         (ravenscar_thread_target::wait): Special case wildcard requests.
10448
10449 2019-02-15  Tom Tromey  <tromey@adacore.com>
10450
10451         * ravenscar-thread.c (base_ptid): Remove.
10452         (struct ravenscar_thread_target) <close>: New method.
10453         <m_base_ptid>: New member.
10454         <update_inferior_ptid, active_task, task_is_currently_active,
10455         runtime_initialized>: Declare methods.
10456         <ravenscar_thread_target>: Add constructor.
10457         (ravenscar_thread_target::task_is_currently_active)
10458         (ravenscar_thread_target::update_inferior_ptid)
10459         (ravenscar_runtime_initialized): Rename.  Now methods.
10460         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10461         (ravenscar_thread_target::update_thread_list): Update.
10462         (ravenscar_thread_target::active_task): Now method.
10463         (ravenscar_thread_target::store_registers)
10464         (ravenscar_thread_target::prepare_to_store)
10465         (ravenscar_thread_target::prepare_to_store)
10466         (ravenscar_thread_target::mourn_inferior): Update.
10467         (ravenscar_inferior_created): Use "new" to create target.
10468         (ravenscar_thread_target::get_ada_task_ptid): Update.
10469         (_initialize_ravenscar): Don't initialize base_ptid.
10470         (ravenscar_ops): Remove global.
10471
10472 2019-02-15  Tom Tromey  <tromey@adacore.com>
10473
10474         * target.h (push_target): Declare new overload.
10475         * target.c (push_target): New overload, taking an rvalue reference.
10476         * remote.c (remote_target::open_1): Use push_target overload.
10477         * corelow.c (core_target_open): Use push_target overload.
10478
10479 2019-02-15  Tom Tromey  <tromey@adacore.com>
10480
10481         * ravenscar-thread.c (is_ravenscar_task)
10482         (ravenscar_task_is_currently_active): Return bool.
10483         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10484         (_initialize_ravenscar): Remove "(void)".
10485         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10486         Return bool.
10487
10488 2019-02-15  Tom Tromey  <tromey@adacore.com>
10489
10490         * ravenscar-thread.c (ravenscar_runtime_initializer)
10491         (has_ravenscar_runtime, get_running_thread_id)
10492         (ravenscar_thread_target::resume): Fix indentation.
10493
10494 2019-02-15  Tom Tromey  <tromey@adacore.com>
10495
10496         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10497         from ravenscar_arch_ops.
10498         (sparc_ravenscar_ops::fetch_registers)
10499         (sparc_ravenscar_ops::store_registers): Now methods.
10500         (sparc_ravenscar_prepare_to_store): Remove.
10501         (sparc_ravenscar_ops): Redefine.
10502         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10503         methods and destructor.  Remove members.
10504         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10505         (ravenscar_thread_target::store_registers)
10506         (ravenscar_thread_target::prepare_to_store): Update.
10507         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10508         Remove.
10509         (struct ppc_ravenscar_powerpc_ops): Derive from
10510         ravenscar_arch_ops.
10511         (ppc_ravenscar_powerpc_ops::fetch_registers)
10512         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10513         (ppc_ravenscar_powerpc_ops): Redefine.
10514         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10515         (ppc_ravenscar_e500_ops::fetch_registers)
10516         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10517         (ppc_ravenscar_e500_ops): Redefine.
10518         * aarch64-ravenscar-thread.c
10519         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10520         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10521         (aarch64_ravenscar_fetch_registers)
10522         (aarch64_ravenscar_store_registers): Now methods.
10523         (aarch64_ravenscar_ops): Redefine.
10524
10525 2019-02-15  Tom Tromey  <tromey@adacore.com>
10526
10527         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10528         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10529         (ravenscar_thread_target::stopped_by_watchpoint)
10530         (ravenscar_thread_target::stopped_data_address)
10531         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10532
10533 2019-02-15  Tom Tromey  <tromey@adacore.com>
10534
10535         * ravenscar-thread.c: Fix some typos.
10536
10537 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10538             Tom Tromey  <tromey@adacore.com>
10539
10540         * ada-lang.c (ada_exception_sal): Change addr_string to a
10541         std::string.
10542         (create_ada_exception_catchpoint): Update.
10543
10544 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10545             Tom Tromey  <tromey@adacore.com>
10546
10547         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10548         (bp_location_ops): Remove.
10549         (base_breakpoint_allocate_location): Update.
10550         (free_bp_location): Update.
10551         * ada-lang.c (class ada_catchpoint_location)
10552         <ada_catchpoint_location>: Remove ops parameter.
10553         (ada_catchpoint_location_dtor): Remove.
10554         (ada_catchpoint_location_ops): Remove.
10555         (allocate_location_exception): Update.
10556         * breakpoint.h (struct bp_location_ops): Remove.
10557         (class bp_location) <bp_location>: Remove bp_location_ops
10558         parameter.
10559         <~bp_location>: Add destructor.
10560         <ops>: Remove.
10561
10562 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10563             Pedro Alves  <palves@redhat.com>
10564
10565         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10566         'PATH_MAX'.
10567
10568 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10569             Samuel Thibault  <samuel.thibault@gnu.org>
10570             Thomas Schwinge  <thomas@codesourcery.com>
10571
10572         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10573         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10574
10575 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10576
10577         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10578         (check_empty): Use "const char *".
10579
10580         * gnu-nat.c (gnu_nat_target::detach): Instead of
10581         'detach_inferior (pid)' call
10582         'detach_inferior (find_inferior_pid (pid))'.
10583
10584         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10585         'nat/fork-inferior.o'.
10586         * gnu-nat.c: #include "nat/fork-inferior.h".
10587
10588         * gnu-nat.c (gnu_nat_target::detach): Instead of
10589         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10590         * gnu-nat.h: #include "inf-child.h".
10591         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10592         'i386_gnu_nat_target::fetch_registers'.
10593         (gnu_store_registers): Rename/move to
10594         'i386_gnu_nat_target::store_registers'.
10595
10596         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10597         * gnu-nat.h (mach_thread_info): New function.
10598         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10599
10600         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10601
10602 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10603
10604         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10605
10606 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10607
10608         * windows-nat.c (windows_add_thread): Add new parameter
10609         "main_thread_p" with default value set to false.  Update
10610         function documentation as well as all callers.
10611         (windows_delete_thread): Likewise.
10612         (fake_create_process): Update call to windows_add_thread.
10613         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10614         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10615         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10616         call to windows_delete_thread.
10617
10618 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10619
10620         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10621
10622 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10623
10624         * symfile.c (find_separate_debug_file): Use canonical path of
10625         sysroot with child_path instead of gdb_sysroot if it is valid.
10626
10627 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10628
10629         * symfile.c (find_separate_debug_file): Use child_path to
10630         determine if an object file is under a sysroot.
10631
10632 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10633
10634         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10635         unittests/child-path-selftests.c.
10636         * common/pathstuff.c (child_path): New function.
10637         * common/pathstuff.h (child_path): New prototype.
10638         * unittests/child-path-selftests.c: New file.
10639
10640 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10641
10642         * symfile.c (find_separate_debug_file): Look for separate debug
10643         files in debug directories under the sysroot.
10644
10645 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10646
10647         * symtab.h (struct minimal_symbol data_p): New const method.
10648         (struct minimal_symbol text_p): Likewise.
10649         * symtab.c (output_source_filename): Use file name style
10650         to print file name.
10651         (print_symbol_info): Likewise.
10652         (print_msymbol_info): Use address style to print addresses.
10653         Use function name style to print executable text symbols.
10654         (expand_symtab_containing_pc): Use data_p.
10655         (find_pc_sect_compunit_symtab): Likewise.
10656
10657 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10658
10659         * breakpoint.c (describe_other_breakpoints): Use address style
10660         to print addresses.
10661         (say_where): Likewise.
10662
10663 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10664
10665         * ada-typeprint.c (print_func_type): Print function name
10666         style to print function name.
10667         * c-typeprint.c (c_print_type_1): Likewise.
10668
10669 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10670
10671         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10672         for execve.
10673
10674 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10675
10676         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10677         type_stack.
10678
10679 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10680
10681         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10682         TYPE_CODE_REF types.
10683
10684 2019-02-08  Jim Wilson  <jimw@sifive.com>
10685
10686         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10687         (riscv_linux_fregset): New.
10688         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10689
10690 2019-02-07  Tom Tromey  <tom@tromey.com>
10691
10692         * thread.c (thread_cancel_execution_command): Update.
10693         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10694         methods.
10695         (struct thread_fsm_ops): Remove.
10696         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10697         (thread_fsm_should_stop, thread_fsm_return_value)
10698         (thread_fsm_set_finished, thread_fsm_finished_p)
10699         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10700         Don't declare.
10701         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10702         * infrun.c (clear_proceed_status_thread)
10703         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10704         (print_stop_event): Update.
10705         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10706         Add constructor.
10707         (step_command_fsm_ops): Remove.
10708         (new_step_command_fsm): Remove.
10709         (step_1): Update.
10710         (step_command_fsm::should_stop): Rename from
10711         step_command_fsm_should_stop.
10712         (step_command_fsm::clean_up): Rename from
10713         step_command_fsm_clean_up.
10714         (step_command_fsm::do_async_reply_reason): Rename from
10715         step_command_fsm_async_reply_reason.
10716         (struct until_next_fsm): Inherit from thread_fsm.  Add
10717         constructor.
10718         (until_next_fsm_ops): Remove.
10719         (new_until_next_fsm): Remove.
10720         (until_next_fsm::should_stop): Rename from
10721         until_next_fsm_should_stop.
10722         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10723         (until_next_fsm::do_async_reply_reason): Rename from
10724         until_next_fsm_async_reply_reason.
10725         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10726         constructor.  Change type of breakpoint.
10727         (finish_command_fsm_ops): Remove.
10728         (new_finish_command_fsm): Remove.
10729         (finish_command_fsm::should_stop): Rename from
10730         finish_command_fsm_should_stop.
10731         (finish_command_fsm::clean_up): Rename from
10732         finish_command_fsm_clean_up.
10733         (finish_command_fsm::return_value): Rename from
10734         finish_command_fsm_return_value.
10735         (finish_command_fsm::do_async_reply_reason): Rename from
10736         finish_command_fsm_async_reply_reason.
10737         (finish_command): Update.
10738         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10739         Add constructor.
10740         (call_thread_fsm_ops): Remove.
10741         (call_thread_fsm::call_thread_fsm): Rename from
10742         new_call_thread_fsm.
10743         (call_thread_fsm::should_stop): Rename from
10744         call_thread_fsm_should_stop.
10745         (call_thread_fsm::should_notify_stop): Rename from
10746         call_thread_fsm_should_notify_stop.
10747         (run_inferior_call, call_function_by_hand_dummy): Update.
10748         * cli/cli-interp.c (should_print_stop_to_console): Update.
10749         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10750         Add constructor.  Change type of location_breakpoint,
10751         caller_breakpoint.
10752         (until_break_fsm_ops): Remove.
10753         (new_until_break_fsm): Remove.
10754         (until_break_fsm::should_stop): Rename from
10755         until_break_fsm_should_stop.
10756         (until_break_fsm::clean_up): Rename from
10757         until_break_fsm_clean_up.
10758         (until_break_fsm::do_async_reply_reason): Rename from
10759         until_break_fsm_async_reply_reason.
10760         (until_break_command): Update.
10761         * thread-fsm.c: Remove.
10762         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10763
10764 2019-02-07  Tom Tromey  <tom@tromey.com>
10765
10766         * yy-remap.h: Add include guard.
10767         * xtensa-tdep.h: Add include guard.
10768         * xcoffread.h: Rename include guard.
10769         * varobj-iter.h: Add include guard.
10770         * tui/tui.h: Rename include guard.
10771         * tui/tui-winsource.h: Rename include guard.
10772         * tui/tui-wingeneral.h: Rename include guard.
10773         * tui/tui-windata.h: Rename include guard.
10774         * tui/tui-win.h: Rename include guard.
10775         * tui/tui-stack.h: Rename include guard.
10776         * tui/tui-source.h: Rename include guard.
10777         * tui/tui-regs.h: Rename include guard.
10778         * tui/tui-out.h: Rename include guard.
10779         * tui/tui-layout.h: Rename include guard.
10780         * tui/tui-io.h: Rename include guard.
10781         * tui/tui-hooks.h: Rename include guard.
10782         * tui/tui-file.h: Rename include guard.
10783         * tui/tui-disasm.h: Rename include guard.
10784         * tui/tui-data.h: Rename include guard.
10785         * tui/tui-command.h: Rename include guard.
10786         * tic6x-tdep.h: Add include guard.
10787         * target/waitstatus.h: Rename include guard.
10788         * target/wait.h: Rename include guard.
10789         * target/target.h: Rename include guard.
10790         * target/resume.h: Rename include guard.
10791         * target-float.h: Rename include guard.
10792         * stabsread.h: Add include guard.
10793         * rs6000-tdep.h: Add include guard.
10794         * riscv-fbsd-tdep.h: Add include guard.
10795         * regformats/regdef.h: Rename include guard.
10796         * record.h: Rename include guard.
10797         * python/python.h: Rename include guard.
10798         * python/python-internal.h: Rename include guard.
10799         * python/py-stopevent.h: Rename include guard.
10800         * python/py-ref.h: Rename include guard.
10801         * python/py-record.h: Rename include guard.
10802         * python/py-record-full.h: Rename include guard.
10803         * python/py-record-btrace.h: Rename include guard.
10804         * python/py-instruction.h: Rename include guard.
10805         * python/py-events.h: Rename include guard.
10806         * python/py-event.h: Rename include guard.
10807         * procfs.h: Add include guard.
10808         * proc-utils.h: Add include guard.
10809         * p-lang.h: Add include guard.
10810         * or1k-tdep.h: Rename include guard.
10811         * observable.h: Rename include guard.
10812         * nto-tdep.h: Rename include guard.
10813         * nat/x86-linux.h: Rename include guard.
10814         * nat/x86-linux-dregs.h: Rename include guard.
10815         * nat/x86-gcc-cpuid.h: Add include guard.
10816         * nat/x86-dregs.h: Rename include guard.
10817         * nat/x86-cpuid.h: Rename include guard.
10818         * nat/ppc-linux.h: Rename include guard.
10819         * nat/mips-linux-watch.h: Rename include guard.
10820         * nat/linux-waitpid.h: Rename include guard.
10821         * nat/linux-ptrace.h: Rename include guard.
10822         * nat/linux-procfs.h: Rename include guard.
10823         * nat/linux-osdata.h: Rename include guard.
10824         * nat/linux-nat.h: Rename include guard.
10825         * nat/linux-namespaces.h: Rename include guard.
10826         * nat/linux-btrace.h: Rename include guard.
10827         * nat/glibc_thread_db.h: Rename include guard.
10828         * nat/gdb_thread_db.h: Rename include guard.
10829         * nat/gdb_ptrace.h: Rename include guard.
10830         * nat/fork-inferior.h: Rename include guard.
10831         * nat/amd64-linux-siginfo.h: Rename include guard.
10832         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10833         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10834         * nat/aarch64-linux.h: Rename include guard.
10835         * nat/aarch64-linux-hw-point.h: Rename include guard.
10836         * mn10300-tdep.h: Add include guard.
10837         * mips-linux-tdep.h: Add include guard.
10838         * mi/mi-parse.h: Rename include guard.
10839         * mi/mi-out.h: Rename include guard.
10840         * mi/mi-main.h: Rename include guard.
10841         * mi/mi-interp.h: Rename include guard.
10842         * mi/mi-getopt.h: Rename include guard.
10843         * mi/mi-console.h: Rename include guard.
10844         * mi/mi-common.h: Rename include guard.
10845         * mi/mi-cmds.h: Rename include guard.
10846         * mi/mi-cmd-break.h: Rename include guard.
10847         * m2-lang.h: Add include guard.
10848         * location.h: Rename include guard.
10849         * linux-record.h: Rename include guard.
10850         * linux-nat.h: Add include guard.
10851         * linux-fork.h: Add include guard.
10852         * i386-darwin-tdep.h: Rename include guard.
10853         * hppa-linux-offsets.h: Add include guard.
10854         * guile/guile.h: Rename include guard.
10855         * guile/guile-internal.h: Rename include guard.
10856         * gnu-nat.h: Rename include guard.
10857         * gdb-stabs.h: Rename include guard.
10858         * frv-tdep.h: Add include guard.
10859         * f-lang.h: Add include guard.
10860         * event-loop.h: Add include guard.
10861         * darwin-nat.h: Rename include guard.
10862         * cp-abi.h: Rename include guard.
10863         * config/sparc/nm-sol2.h: Rename include guard.
10864         * config/nm-nto.h: Rename include guard.
10865         * config/nm-linux.h: Add include guard.
10866         * config/i386/nm-i386gnu.h: Rename include guard.
10867         * config/djgpp/nl_types.h: Rename include guard.
10868         * config/djgpp/langinfo.h: Rename include guard.
10869         * compile/gcc-cp-plugin.h: Add include guard.
10870         * compile/gcc-c-plugin.h: Add include guard.
10871         * compile/compile.h: Rename include guard.
10872         * compile/compile-object-run.h: Rename include guard.
10873         * compile/compile-object-load.h: Rename include guard.
10874         * compile/compile-internal.h: Rename include guard.
10875         * compile/compile-cplus.h: Rename include guard.
10876         * compile/compile-c.h: Rename include guard.
10877         * common/xml-utils.h: Rename include guard.
10878         * common/x86-xstate.h: Rename include guard.
10879         * common/version.h: Rename include guard.
10880         * common/vec.h: Rename include guard.
10881         * common/tdesc.h: Rename include guard.
10882         * common/selftest.h: Rename include guard.
10883         * common/scoped_restore.h: Rename include guard.
10884         * common/scoped_mmap.h: Rename include guard.
10885         * common/scoped_fd.h: Rename include guard.
10886         * common/safe-iterator.h: Rename include guard.
10887         * common/run-time-clock.h: Rename include guard.
10888         * common/refcounted-object.h: Rename include guard.
10889         * common/queue.h: Rename include guard.
10890         * common/ptid.h: Rename include guard.
10891         * common/print-utils.h: Rename include guard.
10892         * common/preprocessor.h: Rename include guard.
10893         * common/pathstuff.h: Rename include guard.
10894         * common/observable.h: Rename include guard.
10895         * common/netstuff.h: Rename include guard.
10896         * common/job-control.h: Rename include guard.
10897         * common/host-defs.h: Rename include guard.
10898         * common/gdb_wait.h: Rename include guard.
10899         * common/gdb_vecs.h: Rename include guard.
10900         * common/gdb_unlinker.h: Rename include guard.
10901         * common/gdb_unique_ptr.h: Rename include guard.
10902         * common/gdb_tilde_expand.h: Rename include guard.
10903         * common/gdb_sys_time.h: Rename include guard.
10904         * common/gdb_string_view.h: Rename include guard.
10905         * common/gdb_splay_tree.h: Rename include guard.
10906         * common/gdb_setjmp.h: Rename include guard.
10907         * common/gdb_ref_ptr.h: Rename include guard.
10908         * common/gdb_optional.h: Rename include guard.
10909         * common/gdb_locale.h: Rename include guard.
10910         * common/gdb_assert.h: Rename include guard.
10911         * common/filtered-iterator.h: Rename include guard.
10912         * common/filestuff.h: Rename include guard.
10913         * common/fileio.h: Rename include guard.
10914         * common/environ.h: Rename include guard.
10915         * common/common-utils.h: Rename include guard.
10916         * common/common-types.h: Rename include guard.
10917         * common/common-regcache.h: Rename include guard.
10918         * common/common-inferior.h: Rename include guard.
10919         * common/common-gdbthread.h: Rename include guard.
10920         * common/common-exceptions.h: Rename include guard.
10921         * common/common-defs.h: Rename include guard.
10922         * common/common-debug.h: Rename include guard.
10923         * common/cleanups.h: Rename include guard.
10924         * common/buffer.h: Rename include guard.
10925         * common/btrace-common.h: Rename include guard.
10926         * common/break-common.h: Rename include guard.
10927         * cli/cli-utils.h: Rename include guard.
10928         * cli/cli-style.h: Rename include guard.
10929         * cli/cli-setshow.h: Rename include guard.
10930         * cli/cli-script.h: Rename include guard.
10931         * cli/cli-interp.h: Rename include guard.
10932         * cli/cli-decode.h: Rename include guard.
10933         * cli/cli-cmds.h: Rename include guard.
10934         * charset-list.h: Add include guard.
10935         * buildsym-legacy.h: Rename include guard.
10936         * bfin-tdep.h: Add include guard.
10937         * ax.h: Rename include guard.
10938         * arm-linux-tdep.h: Add include guard.
10939         * arm-fbsd-tdep.h: Add include guard.
10940         * arch/xtensa.h: Rename include guard.
10941         * arch/tic6x.h: Add include guard.
10942         * arch/i386.h: Add include guard.
10943         * arch/arm.h: Rename include guard.
10944         * arch/arm-linux.h: Rename include guard.
10945         * arch/arm-get-next-pcs.h: Rename include guard.
10946         * arch/amd64.h: Add include guard.
10947         * arch/aarch64-insn.h: Rename include guard.
10948         * arch-utils.h: Rename include guard.
10949         * annotate.h: Add include guard.
10950         * amd64-darwin-tdep.h: Rename include guard.
10951         * aarch64-linux-tdep.h: Add include guard.
10952         * aarch64-fbsd-tdep.h: Add include guard.
10953         * aarch32-linux-nat.h: Add include guard.
10954
10955 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10956
10957         * macrotab.c (macro_define_internal): New function that
10958         factorizes macro_define_object_internal and macro_define_function
10959         code.
10960         (macro_define_object_internal): Use macro_define_internal.
10961         (macro_define_function): Likewise.
10962
10963 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10964
10965         * macrocmd.c (extract_identifier): Return
10966         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10967         callers.
10968
10969 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10970
10971         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10972
10973 2019-02-05  Tom Tromey  <tom@tromey.com>
10974
10975         * target.c (target_stack::unpush): Move assertion earlier.
10976
10977 2019-01-30  Tom Tromey  <tom@tromey.com>
10978
10979         PR python/23615:
10980         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10981         (gdbpy_parse_and_eval): Likewise.
10982         * python/python-internal.h (gdbpy_allow_threads): New class.
10983
10984 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10985
10986         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10987         (aarch64_fbsd_fpregmap): Move earlier.
10988         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10989         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10990         instead of individual calls to trad_frame_set_reg_addr.
10991         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10992         earlier.
10993         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10994         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10995         instead of individual calls to trad_frame_set_reg_addr.
10996
10997 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10998
10999         * CONTRIBUTE: Replace contribution list with wiki link.
11000
11001 2019-01-25  Tom Tromey  <tom@tromey.com>
11002
11003         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11004
11005 2019-01-25  Tom Tromey  <tom@tromey.com>
11006
11007         * xtensa-linux-nat.c: Fix common/ includes.
11008         * xml-support.h: Fix common/ includes.
11009         * xml-support.c: Fix common/ includes.
11010         * x86-linux-nat.c: Fix common/ includes.
11011         * windows-nat.c: Fix common/ includes.
11012         * varobj.h: Fix common/ includes.
11013         * varobj.c: Fix common/ includes.
11014         * value.c: Fix common/ includes.
11015         * valops.c: Fix common/ includes.
11016         * utils.c: Fix common/ includes.
11017         * unittests/xml-utils-selftests.c: Fix common/ includes.
11018         * unittests/utils-selftests.c: Fix common/ includes.
11019         * unittests/unpack-selftests.c: Fix common/ includes.
11020         * unittests/tracepoint-selftests.c: Fix common/ includes.
11021         * unittests/style-selftests.c: Fix common/ includes.
11022         * unittests/string_view-selftests.c: Fix common/ includes.
11023         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11024         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11025         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11026         * unittests/rsp-low-selftests.c: Fix common/ includes.
11027         * unittests/parse-connection-spec-selftests.c: Fix common/
11028         includes.
11029         * unittests/optional-selftests.c: Fix common/ includes.
11030         * unittests/offset-type-selftests.c: Fix common/ includes.
11031         * unittests/observable-selftests.c: Fix common/ includes.
11032         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11033         * unittests/memrange-selftests.c: Fix common/ includes.
11034         * unittests/memory-map-selftests.c: Fix common/ includes.
11035         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11036         * unittests/function-view-selftests.c: Fix common/ includes.
11037         * unittests/environ-selftests.c: Fix common/ includes.
11038         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11039         * unittests/common-utils-selftests.c: Fix common/ includes.
11040         * unittests/cli-utils-selftests.c: Fix common/ includes.
11041         * unittests/array-view-selftests.c: Fix common/ includes.
11042         * ui-file.c: Fix common/ includes.
11043         * tui/tui-io.c: Fix common/ includes.
11044         * tracepoint.h: Fix common/ includes.
11045         * tracepoint.c: Fix common/ includes.
11046         * tracefile-tfile.c: Fix common/ includes.
11047         * top.h: Fix common/ includes.
11048         * top.c: Fix common/ includes.
11049         * thread.c: Fix common/ includes.
11050         * target/waitstatus.h: Fix common/ includes.
11051         * target/waitstatus.c: Fix common/ includes.
11052         * target.h: Fix common/ includes.
11053         * target.c: Fix common/ includes.
11054         * target-memory.c: Fix common/ includes.
11055         * target-descriptions.c: Fix common/ includes.
11056         * symtab.h: Fix common/ includes.
11057         * symfile.c: Fix common/ includes.
11058         * stap-probe.c: Fix common/ includes.
11059         * spu-linux-nat.c: Fix common/ includes.
11060         * sparc-nat.c: Fix common/ includes.
11061         * source.c: Fix common/ includes.
11062         * solib.c: Fix common/ includes.
11063         * solib-target.c: Fix common/ includes.
11064         * ser-unix.c: Fix common/ includes.
11065         * ser-tcp.c: Fix common/ includes.
11066         * ser-pipe.c: Fix common/ includes.
11067         * ser-base.c: Fix common/ includes.
11068         * selftest-arch.c: Fix common/ includes.
11069         * s12z-tdep.c: Fix common/ includes.
11070         * rust-exp.y: Fix common/ includes.
11071         * rs6000-aix-tdep.c: Fix common/ includes.
11072         * riscv-tdep.c: Fix common/ includes.
11073         * remote.c: Fix common/ includes.
11074         * remote-notif.h: Fix common/ includes.
11075         * remote-fileio.h: Fix common/ includes.
11076         * remote-fileio.c: Fix common/ includes.
11077         * regcache.h: Fix common/ includes.
11078         * regcache.c: Fix common/ includes.
11079         * record-btrace.c: Fix common/ includes.
11080         * python/python.c: Fix common/ includes.
11081         * python/py-type.c: Fix common/ includes.
11082         * python/py-inferior.c: Fix common/ includes.
11083         * progspace.h: Fix common/ includes.
11084         * producer.c: Fix common/ includes.
11085         * procfs.c: Fix common/ includes.
11086         * proc-api.c: Fix common/ includes.
11087         * printcmd.c: Fix common/ includes.
11088         * ppc-linux-nat.c: Fix common/ includes.
11089         * parser-defs.h: Fix common/ includes.
11090         * osdata.c: Fix common/ includes.
11091         * obsd-nat.c: Fix common/ includes.
11092         * nat/x86-linux.c: Fix common/ includes.
11093         * nat/x86-linux-dregs.c: Fix common/ includes.
11094         * nat/x86-dregs.h: Fix common/ includes.
11095         * nat/x86-dregs.c: Fix common/ includes.
11096         * nat/ppc-linux.c: Fix common/ includes.
11097         * nat/mips-linux-watch.h: Fix common/ includes.
11098         * nat/mips-linux-watch.c: Fix common/ includes.
11099         * nat/linux-waitpid.c: Fix common/ includes.
11100         * nat/linux-ptrace.h: Fix common/ includes.
11101         * nat/linux-ptrace.c: Fix common/ includes.
11102         * nat/linux-procfs.c: Fix common/ includes.
11103         * nat/linux-personality.c: Fix common/ includes.
11104         * nat/linux-osdata.c: Fix common/ includes.
11105         * nat/linux-namespaces.c: Fix common/ includes.
11106         * nat/linux-btrace.h: Fix common/ includes.
11107         * nat/linux-btrace.c: Fix common/ includes.
11108         * nat/fork-inferior.c: Fix common/ includes.
11109         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11110         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11111         * nat/aarch64-linux.c: Fix common/ includes.
11112         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11113         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11114         * namespace.h: Fix common/ includes.
11115         * mips-linux-tdep.c: Fix common/ includes.
11116         * minsyms.c: Fix common/ includes.
11117         * mi/mi-parse.h: Fix common/ includes.
11118         * mi/mi-main.c: Fix common/ includes.
11119         * mi/mi-cmd-env.c: Fix common/ includes.
11120         * memrange.h: Fix common/ includes.
11121         * memattr.c: Fix common/ includes.
11122         * maint.h: Fix common/ includes.
11123         * maint.c: Fix common/ includes.
11124         * main.c: Fix common/ includes.
11125         * machoread.c: Fix common/ includes.
11126         * location.c: Fix common/ includes.
11127         * linux-thread-db.c: Fix common/ includes.
11128         * linux-nat.c: Fix common/ includes.
11129         * linux-fork.c: Fix common/ includes.
11130         * inline-frame.c: Fix common/ includes.
11131         * infrun.c: Fix common/ includes.
11132         * inflow.c: Fix common/ includes.
11133         * inferior.h: Fix common/ includes.
11134         * inferior.c: Fix common/ includes.
11135         * infcmd.c: Fix common/ includes.
11136         * inf-ptrace.c: Fix common/ includes.
11137         * inf-child.c: Fix common/ includes.
11138         * ia64-linux-nat.c: Fix common/ includes.
11139         * i387-tdep.c: Fix common/ includes.
11140         * i386-tdep.c: Fix common/ includes.
11141         * i386-linux-tdep.c: Fix common/ includes.
11142         * i386-linux-nat.c: Fix common/ includes.
11143         * i386-go32-tdep.c: Fix common/ includes.
11144         * i386-fbsd-tdep.c: Fix common/ includes.
11145         * i386-fbsd-nat.c: Fix common/ includes.
11146         * guile/scm-type.c: Fix common/ includes.
11147         * guile/guile.c: Fix common/ includes.
11148         * go32-nat.c: Fix common/ includes.
11149         * gnu-nat.c: Fix common/ includes.
11150         * gdbthread.h: Fix common/ includes.
11151         * gdbarch-selftests.c: Fix common/ includes.
11152         * gdb_usleep.c: Fix common/ includes.
11153         * gdb_select.h: Fix common/ includes.
11154         * gdb_bfd.c: Fix common/ includes.
11155         * gcore.c: Fix common/ includes.
11156         * fork-child.c: Fix common/ includes.
11157         * findvar.c: Fix common/ includes.
11158         * fbsd-nat.c: Fix common/ includes.
11159         * event-top.c: Fix common/ includes.
11160         * event-loop.c: Fix common/ includes.
11161         * dwarf2read.c: Fix common/ includes.
11162         * dwarf2loc.c: Fix common/ includes.
11163         * dwarf2-frame.c: Fix common/ includes.
11164         * dwarf-index-cache.c: Fix common/ includes.
11165         * dtrace-probe.c: Fix common/ includes.
11166         * disasm-selftests.c: Fix common/ includes.
11167         * defs.h: Fix common/ includes.
11168         * csky-tdep.c: Fix common/ includes.
11169         * cp-valprint.c: Fix common/ includes.
11170         * cp-support.h: Fix common/ includes.
11171         * cp-support.c: Fix common/ includes.
11172         * corelow.c: Fix common/ includes.
11173         * completer.h: Fix common/ includes.
11174         * completer.c: Fix common/ includes.
11175         * compile/compile.c: Fix common/ includes.
11176         * compile/compile-loc2c.c: Fix common/ includes.
11177         * compile/compile-cplus-types.c: Fix common/ includes.
11178         * compile/compile-cplus-symbols.c: Fix common/ includes.
11179         * command.h: Fix common/ includes.
11180         * cli/cli-dump.c: Fix common/ includes.
11181         * cli/cli-cmds.c: Fix common/ includes.
11182         * charset.c: Fix common/ includes.
11183         * build-id.c: Fix common/ includes.
11184         * btrace.h: Fix common/ includes.
11185         * btrace.c: Fix common/ includes.
11186         * breakpoint.h: Fix common/ includes.
11187         * breakpoint.c: Fix common/ includes.
11188         * ax.h:
11189         (enum agent_op): Fix common/ includes.
11190         * ax-general.c (struct aop_map): Fix common/ includes.
11191         * ax-gdb.c: Fix common/ includes.
11192         * auxv.c: Fix common/ includes.
11193         * auto-load.c: Fix common/ includes.
11194         * arm-tdep.c: Fix common/ includes.
11195         * arch/riscv.c: Fix common/ includes.
11196         * arch/ppc-linux-common.c: Fix common/ includes.
11197         * arch/i386.c: Fix common/ includes.
11198         * arch/arm.c: Fix common/ includes.
11199         * arch/arm-linux.c: Fix common/ includes.
11200         * arch/arm-get-next-pcs.c: Fix common/ includes.
11201         * arch/amd64.c: Fix common/ includes.
11202         * arch/aarch64.c: Fix common/ includes.
11203         * arch/aarch64-insn.c: Fix common/ includes.
11204         * arch-utils.c: Fix common/ includes.
11205         * amd64-windows-tdep.c: Fix common/ includes.
11206         * amd64-tdep.c: Fix common/ includes.
11207         * amd64-sol2-tdep.c: Fix common/ includes.
11208         * amd64-obsd-tdep.c: Fix common/ includes.
11209         * amd64-nbsd-tdep.c: Fix common/ includes.
11210         * amd64-linux-tdep.c: Fix common/ includes.
11211         * amd64-linux-nat.c: Fix common/ includes.
11212         * amd64-fbsd-tdep.c: Fix common/ includes.
11213         * amd64-fbsd-nat.c: Fix common/ includes.
11214         * amd64-dicos-tdep.c: Fix common/ includes.
11215         * amd64-darwin-tdep.c: Fix common/ includes.
11216         * agent.c: Fix common/ includes.
11217         * ada-lang.h: Fix common/ includes.
11218         * ada-lang.c: Fix common/ includes.
11219         * aarch64-tdep.c: Fix common/ includes.
11220
11221 2019-01-25  Tom Tromey  <tom@tromey.com>
11222
11223         * common/create-version.sh: Use common/version.h.
11224
11225 2019-01-24  Pedro Alves  <palves@redhat.com>
11226
11227         * infrun.c (signal_stop, signal_print, signal_program)
11228         (signal_catch, signal_pass): Now arrays instead of pointers.
11229         (update_signals_program_target, do_target_resume)
11230         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11231         * linux-nat.c (linux_nat_target::pass_signals)
11232         (linux_nat_target::create_inferior, linux_nat_target::attach):
11233         Adjust.
11234         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11235         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11236         * procfs.c (procfs_target::pass_signals): Adjust.
11237         * record-full.c (record_full_target::resume): Adjust.
11238         * remote.c (remote_target::pass_signals)
11239         (remote_target::program_signals): Adjust.
11240         * target-debug.h (target_debug_print_signals): Now takes a
11241         gdb::array_view as parameter.  Adjust.
11242         * target.h (target_ops) <pass_signals, program_signals>: Replace
11243         pointer and length parameters with gdb::array_view.
11244         (target_pass_signals, target_program_signals): Likewise.
11245         * target-delegates.c: Regenerate.
11246
11247 2019-01-24  Pedro Alves  <palves@redhat.com>
11248
11249         * common/forward-scope-exit.h
11250         (forward_scope_exit::forward_scope_exit): Pass arguments to
11251         m_bind_function directly, instead of creating a std::bind and
11252         copying that.
11253
11254 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11255
11256         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11257         for static members.
11258         (pass_in_v_vfp_candidate): Likewise.
11259
11260 2019-01-23  Tom Tromey  <tom@tromey.com>
11261             Pedro Alves  <palves@redhat.com>
11262
11263         * regcache.c (class regcache_invalidator): Remove.
11264         (regcache::raw_write): Use make_scope_exit.
11265
11266 2019-01-23  Tom Tromey  <tom@tromey.com>
11267
11268         * ui-out.h (class ui_out_emit_type): Update comment.
11269
11270 2019-01-23  Tom Tromey  <tom@tromey.com>
11271
11272         * infrun.c (fetch_inferior_event): Update comment.
11273
11274 2019-01-23  Tom Tromey  <tom@tromey.com>
11275             Pedro Alves  <palves@redhat.com>
11276
11277         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11278         parameter.
11279         (fetch_inferior_event): Use SCOPE_EXIT.
11280
11281
11282 2019-01-23  Tom Tromey  <tom@tromey.com>
11283             Pedro Alves  <palves@redhat.com>
11284
11285         * infrun.c (disable_thread_events): Delete.
11286         (stop_all_threads): Use SCOPE_EXIT.
11287
11288 2019-01-23  Tom Tromey  <tom@tromey.com>
11289             Pedro Alves  <palves@redhat.com>
11290
11291         * symfile.c: Include forward-scope-exit.h.
11292         (clear_symtab_users_cleanup): Replace forward declaration with
11293         a FORWARD_SCOPE_EXIT.
11294         (syms_from_objfile_1): Use the forward_scope_exit and
11295         gdb::optional instead of cleanup_function.
11296         (reread_symbols): Use the forward_scope_exit instead of
11297         cleanup_function.
11298         (clear_symtab_users_cleanup): Remove function.
11299
11300 2019-01-23  Tom Tromey  <tom@tromey.com>
11301             Pedro Alves  <palves@redhat.com>
11302
11303         * linux-nat.c: Include scope-exit.h.
11304         (cleanup_target_stop): Remove.
11305         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11306         SCOPE_EXIT.
11307
11308 2019-01-23  Tom Tromey  <tom@tromey.com>
11309             Pedro Alves  <palves@redhat.com>
11310
11311         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11312         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11313
11314 2019-01-23  Tom Tromey  <tom@tromey.com>
11315             Andrew Burgess  <andrew.burgess@embecosm.com>
11316             Pedro Alves  <palves@redhat.com>
11317
11318         * infrun.c (fetch_inferior_event): Use scope_exit.
11319         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11320         * top.c (execute_command): Use scope_exit.
11321         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11322         * utils.c (do_bpstat_clear_actions_cleanup)
11323         (make_bpstat_clear_actions_cleanup): Remove.
11324
11325 2019-01-23  Tom Tromey  <tom@tromey.com>
11326             Pedro Alves  <palves@redhat.com>
11327
11328         * infrun.c: Include "common/scope-exit.h"
11329         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11330         (wait_for_inferior): Use SCOPE_EXIT.
11331         (fetch_inferior_event): Use scope_exit.
11332
11333 2019-01-23  Tom Tromey  <tom@tromey.com>
11334             Pedro Alves  <palves@redhat.com>
11335
11336         * breakpoint.c (create_breakpoint): Remove cleanup.
11337
11338 2019-01-23  Tom Tromey  <tom@tromey.com>
11339             Andrew Burgess  <andrew.burgess@embecosm.com>
11340             Pedro Alves  <palves@redhat.com>
11341
11342 2019-01-23  Pedro Alves  <palves@redhat.com>
11343
11344         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11345
11346 2019-01-23  Pedro Alves  <palves@redhat.com>
11347             Andrew Burgess  <andrew.burgess@embecosm.com>
11348
11349         * gdbthread.h: Include "common/forward-scope-exit.h".
11350         (scoped_finish_thread_state): Redefine custom class in terms of
11351         forward_scope_exit.
11352
11353 2019-01-23  Pedro Alves  <palves@redhat.com>
11354             Andrew Burgess  <andrew.burgess@embecosm.com>
11355
11356         * common/forward-scope-exit.h: New file.
11357
11358 2019-01-23  Pedro Alves  <palves@redhat.com>
11359             Andrew Burgess  <andrew.burgess@embecosm.com>
11360             Tom Tromey  <tom@tromey.com>
11361
11362         * common/scope-exit.h: New file.
11363
11364 2019-01-23  Pedro Alves  <palves@redhat.com>
11365
11366         * common/preprocessor.h (ESC): Rename to ...
11367         (ESC_PARENS): ... this.
11368         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11369         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11370
11371 2019-01-23  Tom Tromey  <tom@tromey.com>
11372
11373         * language.h (class scoped_switch_to_sym_language_if_auto):
11374         Initialize m_lang in both cases.
11375
11376 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11377
11378         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11379         with XCNEW.
11380
11381 2019-01-22  Tom Tromey  <tom@tromey.com>
11382
11383         * corelow.c: Do not include sys/file.h.
11384
11385 2019-01-22  Tom Tromey  <tom@tromey.com>
11386
11387         * tui/tui-wingeneral.h: Include gdb_curses.h.
11388
11389 2019-01-22  Tom Tromey  <tom@tromey.com>
11390
11391         * source-cache.h (class source_cache) <get_source_lines,
11392         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11393
11394 2019-01-22  Tom Tromey  <tom@tromey.com>
11395
11396         * remote-fileio.h (struct remote_target): Declare.
11397
11398 2019-01-22  Tom Tromey  <tom@tromey.com>
11399
11400         * python/py-arch.c: Do not include py-ref.h.
11401         * python/py-bpevent.c: Do not include py-ref.h.
11402         * python/py-cmd.c: Do not include py-ref.h.
11403         * python/py-continueevent.c: Do not include py-ref.h.
11404         * python/py-event.h: Do not include py-ref.h.
11405         * python/py-evtregistry.c: Do not include py-ref.h.
11406         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11407         * python/py-frame.c: Do not include py-ref.h.
11408         * python/py-framefilter.c: Do not include py-ref.h.
11409         * python/py-function.c: Do not include py-ref.h.
11410         * python/py-infevents.c: Do not include py-ref.h.
11411         * python/py-linetable.c: Do not include py-ref.h.
11412         * python/py-objfile.c: Do not include py-ref.h.
11413         * python/py-param.c: Do not include py-ref.h.
11414         * python/py-prettyprint.c: Do not include py-ref.h.
11415         * python/py-progspace.c: Do not include py-ref.h.
11416         * python/py-symbol.c: Do not include py-ref.h.
11417         * python/py-symtab.c: Do not include py-ref.h.
11418         * python/py-type.c: Do not include py-ref.h.
11419         * python/py-unwind.c: Do not include py-ref.h.
11420         * python/py-utils.c: Do not include py-ref.h.
11421         * python/py-value.c: Do not include py-ref.h.
11422         * python/py-varobj.c: Do not include py-ref.h.
11423         * python/py-xmethods.c: Do not include py-ref.h.
11424         * python/python.c: Do not include py-ref.h.
11425         * varobj.c: Do not include py-ref.h.
11426
11427 2019-01-22  Tom Tromey  <tom@tromey.com>
11428
11429         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11430         keyword for bcache.
11431
11432 2019-01-22  Tom Tromey  <tom@tromey.com>
11433
11434         * compile/compile-cplus-types.c: Remove a comment by #include.
11435
11436 2019-01-22  Tom Tromey  <tom@tromey.com>
11437
11438         * compile/gcc-c-plugin.h: Include compile-internal.h.
11439
11440 2019-01-22  Tom Tromey  <tom@tromey.com>
11441
11442         * stabsread.c (EXTERN): Do not define.
11443         (symnum, next_symbol_text_func, processing_gcc_compilation)
11444         (within_function, global_sym_chain, global_stabs)
11445         (previous_stab_code, this_object_header_files)
11446         (n_this_object_header_files)
11447         (n_allocated_this_object_header_files): Define.
11448         * stabsread.h (EXTERN): Never define.  Use "extern".
11449
11450 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11451
11452         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11453         history_value.
11454
11455 2019-01-21  Tom Tromey  <tom@tromey.com>
11456
11457         * ui-out.c: Fix includes.
11458         * tui/tui-source.c: Fix includes.
11459         * target.c: Fix includes.
11460         * remote.c: Fix includes.
11461         * regcache.c: Fix includes.
11462         * python/py-block.c: Fix includes.
11463         * printcmd.c: Fix includes.
11464         * or1k-tdep.c: Fix includes.
11465         * mi/mi-main.c: Fix includes.
11466         * m32r-tdep.c: Fix includes.
11467         * csky-tdep.c: Fix includes.
11468         * compile/compile-cplus-types.c: Fix includes.
11469         * cli/cli-interp.c: Fix includes.
11470
11471 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11472
11473         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11474         for padding.
11475
11476 2019-01-16  Tom Tromey  <tom@tromey.com>
11477
11478         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11479         earlier.
11480         (struct objfile) <msymbols_range>: Move from top level.
11481         <msymbols>: New method.
11482         (class objfile_msymbols): Remove.
11483         * symtab.c (default_collect_symbol_completion_matches_break_on):
11484         Update.
11485         * symmisc.c (dump_msymbols): Update.
11486         * stabsread.c (scan_file_globals): Update.
11487         * objc-lang.c (info_selectors_command, info_classes_command)
11488         (find_methods): Update.
11489         * minsyms.c (find_solib_trampoline_target): Update.
11490         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11491         * coffread.c (coff_symfile_read): Update.
11492         * ada-lang.c (ada_lookup_simple_minsym)
11493         (ada_collect_symbol_completion_matches): Update.
11494
11495 2019-01-16  Tom Tromey  <tom@tromey.com>
11496
11497         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11498         type.  Remove no-argument constructor.
11499         <iterator::operator++>: Simplify.
11500         <begin>: Update.
11501         <end>: Use minimal_symbol_count.
11502
11503 2019-01-16  Tom Tromey  <tom@tromey.com>
11504
11505         * objfiles.h (struct objfile) <psymtabs>: New method.
11506         (class objfile_psymtabs): Remove.
11507         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11508         typedef.
11509         <range>: New method.
11510         (require_partial_symbols): Change return type.
11511         * psymtab.c (require_partial_symbols)
11512         (psym_expand_symtabs_matching): Update.
11513         * mdebugread.c (parse_partial_symbols): Update.
11514         * dbxread.c (dbx_end_psymtab): Update.
11515
11516 2019-01-15  Tom Tromey  <tom@tromey.com>
11517
11518         * symtab.c (lookup_objfile_from_block)
11519         (lookup_symbol_in_objfile_symtabs)
11520         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11521         (find_line_symtab, info_sources_command)
11522         (default_collect_symbol_completion_matches_break_on)
11523         (make_source_files_completion_list): Update.
11524         * symmisc.c (print_objfile_statistics, dump_objfile)
11525         (maintenance_print_symbols, maintenance_info_symtabs)
11526         (maintenance_check_symtabs, maintenance_info_line_tables):
11527         Update.
11528         * source.c (select_source_symtab)
11529         (forget_cached_source_info_for_objfile): Update.
11530         * objfiles.h (class objfile_compunits): Remove.
11531         (struct objfile) <compunits_range>: New typedef.
11532         (compunits): New method.
11533         * objfiles.c (objfile_relocate1): Update.
11534         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11535         * maint.c (count_symtabs_and_blocks): Update.
11536         * linespec.c (iterate_over_all_matching_symtabs): Update.
11537         * cp-support.c (add_symbol_overload_list_qualified): Update.
11538         * coffread.c (coff_symtab_read): Update.
11539         * ada-lang.c (add_nonlocal_symbols)
11540         (ada_collect_symbol_completion_matches)
11541         (ada_add_global_exceptions): Update.
11542
11543 2019-01-15  Tom Tromey  <tom@tromey.com>
11544
11545         * progspace.h (program_space) <objfiles_safe_range>: New
11546         typedef.
11547         <objfiles_safe>: New method.
11548         * objfiles.h (class all_objfiles_safe): Remove.
11549         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11550         * jit.c (jit_inferior_exit_hook): Update.
11551
11552 2019-01-17  Tom Tromey  <tom@tromey.com>
11553
11554         * progspace.h (program_space) <objfiles_range>: New typedef.
11555         <objfiles>: New method.
11556         <objfiles_head>: Rename from objfiles.
11557         (object_files): Update.
11558         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11559         * guile/scm-pretty-print.c
11560         (ppscm_find_pretty_printer_from_objfiles): Update.
11561         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11562         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11563         Update.
11564         * python/py-progspace.c (pspy_get_objfiles): Update.
11565         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11566         Update.
11567         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11568         (objfpy_lookup_objfile_by_build_id): Update.
11569         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11570         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11571         Update.
11572         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11573         (expand_symtab_containing_pc, lookup_objfile_from_block)
11574         (lookup_static_symbol, basic_lookup_transparent_type)
11575         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11576         (find_line_symtab, info_sources_command)
11577         (default_collect_symbol_completion_matches_break_on)
11578         (make_source_files_completion_list, find_main_name): Update.
11579         * symmisc.c (print_symbol_bcache_statistics)
11580         (print_objfile_statistics, maintenance_print_symbols)
11581         (maintenance_print_msymbols, maintenance_print_objfiles)
11582         (maintenance_info_symtabs, maintenance_check_symtabs)
11583         (maintenance_expand_symtabs, maintenance_info_line_tables):
11584         Update.
11585         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11586         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11587         (map_overlay_command, unmap_overlay_command)
11588         (simple_overlay_update, expand_symtabs_matching)
11589         (map_symbol_filenames): Update.
11590         * symfile-debug.c (set_debug_symfile): Update.
11591         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11592         Update.
11593         * source.c (select_source_symtab, forget_cached_source_info):
11594         Update.
11595         * solib.c (solib_read_symbols): Update.
11596         * solib-spu.c (append_ocl_sos): Update.
11597         * psymtab.c (maintenance_print_psymbols)
11598         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11599         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11600         * printcmd.c (info_symbol_command): Update.
11601         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11602         Update.
11603         * objfiles.h (class all_objfiles): Remove.
11604         * objfiles.c (have_partial_symbols, have_full_symbols)
11605         (have_minimal_symbols, qsort_cmp, update_section_map)
11606         (shared_objfile_contains_address_p)
11607         (default_iterate_over_objfiles_in_search_order): Update.
11608         * objc-lang.c (info_selectors_command, info_classes_command)
11609         (find_methods): Update.
11610         * minsyms.c (find_solib_trampoline_target): Update.
11611         * maint.c (maintenance_info_sections)
11612         (maintenance_translate_address, count_symtabs_and_blocks):
11613         Update.
11614         * main.c (captured_main_1): Update.
11615         * linux-thread-db.c (try_thread_db_load_from_pdir)
11616         (has_libpthread): Update.
11617         * linespec.c (iterate_over_all_matching_symtabs)
11618         (search_minsyms_for_name): Update.
11619         * jit.c (jit_find_objf_with_entry_addr): Update.
11620         * hppa-tdep.c (find_unwind_entry)
11621         (hppa_lookup_stub_minimal_symbol): Update.
11622         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11623         Update.
11624         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11625         (elf_gnu_ifunc_resolve_by_got): Update.
11626         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11627         * dwarf-index-write.c (save_gdb_index_command): Update.
11628         * cp-support.c (add_symbol_overload_list_qualified): Update.
11629         * breakpoint.c (create_overlay_event_breakpoint)
11630         (create_longjmp_master_breakpoint)
11631         (create_std_terminate_master_breakpoint)
11632         (create_exception_master_breakpoint): Update.
11633         * blockframe.c (find_pc_partial_function): Update.
11634         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11635         (ada_collect_symbol_completion_matches)
11636         (ada_add_global_exceptions): Update.
11637
11638 2019-01-17  Tom Tromey  <tom@tromey.com>
11639
11640         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11641         declare VEC.
11642         (solib_target_parse_libraries): Change return type.
11643         (library_list_start_segment, library_list_start_section)
11644         (library_list_end_library, library_list_start_library); Update.
11645         (solib_target_free_library_list): Remove.
11646         (solib_target_parse_libraries): Remove cleanup.  Change return
11647         type.
11648         (solib_target_current_sos): Update.
11649
11650 2019-01-17  Tom Tromey  <tromey@bapiya>
11651
11652         * valprint.c: Replace "the the" with "the".
11653         * symtab.c: Replace "the the" with "the".
11654         * solib.c: Replace "the the" with "the".
11655         * solib-dsbt.c: Replace "the the" with "the".
11656         * linespec.c: Replace "the the" with "the".
11657         * dwarf2loc.h: Replace "the the" with "the".
11658         * amd64-windows-tdep.c: Replace "the the" with "the".
11659         * aarch64-tdep.c: Replace "the the" with "the".
11660
11661 2019-01-16  Keith Seitz  <keiths@redhat.com>
11662
11663         PR gdb/23773
11664         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11665         <builder>: Rename to ..
11666         <m_builder>: ... this and make private.
11667         (dwarf2_cu::get_builder): New method.  Change all users of
11668         `builder' to use this method.
11669         (dwarf2_start_symtab): Move to ...
11670         (dwarf2_cu::start_symtab): ... here.  Update all callers
11671         (setup_type_unit_groups): Move to ...
11672         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11673         callers.
11674         (dwarf2_cu::reset_builder): New method.
11675         (process_full_compunit, process_full_type_unit): Use
11676         dwarf2_cu::reset_builder.
11677         (follow_die_offset): Record the ancestor CU if it is different
11678         from the followed DIE's CU.
11679         (follow_die_sig_1): Likewise.
11680
11681 2019-01-15  Tom Tromey  <tom@tromey.com>
11682
11683         * remote.c (class remote_state) <buf>: Now a char_vector.
11684         <buf_size>: Remove.
11685         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11686         parameter.
11687         (remote_target::getpkt_or_notif_sane_1)
11688         (remote_target::getpkt_sane)
11689         (remote_target::getpkt_or_notif_sane): Likewise.
11690         (class remote_target) <putpkt>: New overload.
11691         (remote_target::read_frame): Change type of "buf_p".  Remove
11692         sizeof_p parameter.
11693         (packet_ok): New overload.
11694         (packet_check_result): New overload.
11695         Update all uses.
11696
11697 2019-01-14  Tom Tromey  <tom@tromey.com>
11698
11699         * remote-notif.c (handle_notification, remote_notif_ack)
11700         (remote_notif_parse): Make "buf" const.
11701         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11702         const.
11703         (remote_notif_parse, remote_notif_ack, handle_notification):
11704         Likewise.
11705         * remote.c (remote_notif_stop_parse): Make "buf" const.
11706         (remote_target::remote_parse_stop_reply): Make "buf" const.
11707         (remote_notif_stop_ack): Make "buf" const.
11708
11709 2019-01-14  Tom Tromey  <tom@tromey.com>
11710
11711         * remote.c (remote_console_output): Make parameter const.
11712
11713 2019-01-14  Tom Tromey  <tom@tromey.com>
11714
11715         * target-debug.h (target_debug_print_signals): Constify.
11716         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11717         * procfs.c (procfs_target::pass_signals): Update.
11718         * linux-nat.c (linux_nat_target::pass_signals): Update.
11719         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11720         * target-delegates.c: Rebuild.
11721         * remote.c (remote_target::program_signals): Update.
11722         (remote_target::pass_signals): Update.
11723         * target.c (target_pass_signals): Constify argument.
11724         (target_program_signals): Likewise.
11725         * target.h (struct target_ops) <pass_signals, program_signals>:
11726         Constify argument.
11727         (target_pass_signals, target_program_signals): Constify argument.
11728
11729 2019-01-14  Tom Tromey  <tom@tromey.com>
11730
11731         PR tui/28819:
11732         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11733
11734 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11735
11736         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11737         field.
11738         * rs6000-tdep.c: Include reggroups.h.
11739         (IS_V_ALIAS_PSEUDOREG): Define.
11740         (rs6000_register_name): Return names for the "vX" aliases.
11741         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11742         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11743         aliases.  Call default_register_reggroup_p for all other
11744         pseudo-registers.
11745         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11746         New functions.
11747         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11748         Handle "vX" aliases.
11749         (v_alias_pseudo_register_collect): New function.
11750         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11751         (rs6000_gdbarch_init): Initialize "vX" aliases as
11752         pseudo-registers.  Restore registration of
11753         rs6000_pseudo_register_reggroup_p with
11754         set_tdesc_pseudo_register_reggroup_p.
11755
11756 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11757
11758         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11759         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11760         set_gdbarch_num_pseudo_regs.
11761
11762 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11763
11764         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11765         Remove arg prefixname, add do_set and do_show.
11766         Add member functions set_list and show_list.
11767         * cli/cli-style.c (class cli_style_option): Update accordingly.
11768         (style_set_list): Move to file scope.
11769         (style_show_list): Likewise.
11770         (set_style): Call help_list.
11771         (show_style): Call cmd_show_list.
11772         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11773         Update to use the new macro.
11774
11775 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11776
11777         * ada-lang.c (_initialize_ada_language): Expand the help text
11778         for the "catch exception" command.
11779
11780 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11781
11782         * symtab.c (matching_obj_sections): Initialize obj,
11783         declare it closer to its usage.
11784
11785 2019-01-10  Tom Tromey  <tom@tromey.com>
11786
11787         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11788         (basic_inf_threads_range): Remove.
11789         (inf_threads_range, inf_non_exited_threads_range)
11790         (safe_inf_threads_range): Use next_adapter.
11791
11792 2019-01-10  Keith Seitz  <keiths@redhat.com>
11793
11794         PR gdb/23712
11795         PR symtab/23010
11796         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11797         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11798
11799 2019-01-10  Keith Seitz  <keiths@redhat.com>
11800
11801         PR gdb/23712
11802         PR symtab/23010
11803         * dictionary.c (pending_to_vector): Remove.
11804         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11805         Remove _1 suffix, replacing functions of the same name.  Update
11806         all callers.
11807         (dict_create_hashed, dict_create_hashed_expandable)
11808         (dict_create_linear, dict_create_linear_expandable, dict_free)
11809         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11810         Make functions static.
11811
11812 2019-01-10  Keith Seitz  <keiths@redhat.com>
11813
11814         PR gdb/23712
11815         PR symtab/23010
11816         * dictionary.h (struct dictionary): Replace declaration with
11817         multidictionary.
11818         (dict_create_hashed, dict_create_hashed_expandable)
11819         (dict_create_linear, dict_create_linear_expandable)
11820         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11821         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11822         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11823         taking multidictionary argument.
11824         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11825         * block.h (struct block) <dict>: Change to multidictionary
11826         and rename `multidict'.
11827         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11828         symmisc.c: Update all dictionary references to multidictionary.
11829
11830 2019-01-10  Keith Seitz  <keiths@redhat.com>
11831
11832         PR gdb/23712
11833         PR symtab/23010
11834         * dictionary.c: Include unordered_map.
11835         (pending_to_vector): New function.
11836         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11837         Rewrite the non-"_1" functions to take vector instead
11838         of linked list.
11839         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11840         "new" _1 versions of the same name.
11841         (multidictionary): Define.
11842         (std::hash<enum language): New definition.
11843         (collate_pending_symbols_by_language, mdict_create_hashed)
11844         (mdict_create_hashed_expandable, mdict_create_linear)
11845         (mdict_create_linear_expandable, mdict_free)
11846         (find_language_dictionary, create_new_language_dictionary)
11847         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11848         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11849         (mdict_size, mdict_empty): New functions.
11850         * dictionary.h (mdict_iterator): Define.
11851
11852 2019-01-10  Pedro Alves  <palves@redhat.com>
11853
11854         * breakpoint.c (read_uploaded_action)
11855         (create_tracepoint_from_upload): Adjust to use
11856         gdb::unique_xmalloc_ptr.
11857         * ctf.c (ctf_write_uploaded_tp):
11858         (SET_ARRAY_FIELD): Use emplace_back.
11859         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11860         * tracefile-tfile.c (tfile_write_uploaded_tp):
11861         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11862         gdb::unique_xmalloc_ptr.
11863         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11864         at_string, cond_string, cmd_strings>: Replace char pointers
11865         with gdb::unique_xmalloc_ptr.
11866
11867 2019-01-10  Pedro Alves  <palves@redhat.com>
11868
11869         * solib-target.c (library_list_start_library): Don't xstrdup name.
11870
11871 2019-01-10  Pedro Alves  <palves@redhat.com>
11872
11873         * mdebugread.c (parse_partial_symbols): Use
11874         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11875
11876 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11877
11878         * linux-fork.c (scoped_switch_fork_info)
11879         <~scoped_switch_fork_info>: Fix incorrect variable name.
11880
11881 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11882
11883         * linux-fork.c (scoped_switch_fork_info)
11884         <scoped_switch_fork_info>: Make explicit.
11885         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11886
11887 2019-01-10  Tom Tromey  <tom@tromey.com>
11888
11889         * objfiles.h (objfile::reset_psymtabs): Update.
11890         * objfiles.c (objfile::objfile): Update.
11891         * psymtab.h (psymtab_storage::obstack): Update.
11892         (psymtab_storage::m_obstack): Use gdb::optional.
11893         (class psymtab_storage): Update comment.  Remove objfile
11894         parameter.
11895         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11896
11897 2019-01-10  Tom Tromey  <tom@tromey.com>
11898
11899         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11900         <free_psymtabs>: Now private.
11901         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11902         (allocate_psymtab): Use new method.
11903
11904 2019-01-10  Tom Tromey  <tom@tromey.com>
11905
11906         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11907         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11908         * mdebugread.c (parse_partial_symbols): Use
11909         allocate_dependencies.
11910         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11911         allocate_dependencies.
11912         (process_psymtab_comp_unit_reader)
11913         (build_type_psymtab_dependencies): Likewise.
11914         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11915
11916 2019-01-10  Tom Tromey  <tom@tromey.com>
11917
11918         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11919         PSYMBOL_SET_LANGUAGE.
11920         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11921
11922 2019-01-10  Tom Tromey  <tom@tromey.com>
11923
11924         * psymtab.h (psymtab_storage::obstack): New method.
11925         <m_obstack>: Rename from obstack; now private.
11926         * psymtab.c (psymtab_storage): Update.
11927         * dwarf2read.c (create_addrmap_from_index)
11928         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11929         Update.
11930
11931 2019-01-10  Tom Tromey  <tom@tromey.com>
11932
11933         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11934         * objfiles.h (objfile::reset_psymtabs): New method.
11935
11936 2019-01-10  Tom Tromey  <tom@tromey.com>
11937
11938         * symmisc.c (print_symbol_bcache_statistics): Update.
11939         (print_objfile_statistics): Update.
11940         * symfile.c (reread_symbols): Update.
11941         * psymtab.h (class psymtab_storage): New.
11942         * psymtab.c (psymtab_storage): New constructor.
11943         (~psymtab_storage): New destructor.
11944         (require_partial_symbols): Update.
11945         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11946         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11947         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11948         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11949         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11950         (start_psymtab_common, end_psymtab_common)
11951         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11952         (allocate_psymtab): Update.
11953         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11954         Update.
11955         (dump_psymtab_addrmap, maintenance_print_psymbols)
11956         (maintenance_check_psymtabs): Update.
11957         (class objfile_psymtabs): Move to objfiles.h.
11958         * psympriv.h (discard_psymtab): Now inline.
11959         (psymtab_discarder::psymtab_discarder): Update.
11960         (psymtab_discarder::~psymtab_discarder): Update.
11961         (ALL_OBJFILE_PSYMTABS): Rewrite.
11962         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11963         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11964         Remove fields.
11965         <partial_symtabs>: New field.
11966         (class objfile_psymtabs): Move from psymtab.h.  Update.
11967         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11968         psymbol_cache.
11969         (objfile::~objfile): Don't destroy psymbol_cache.
11970         * mdebugread.c (parse_partial_symbols): Update.
11971         * dwarf2read.c (create_addrmap_from_index)
11972         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11973         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11974         (add_partial_subprogram, dwarf2_ranges_read): Update.
11975         * dwarf-index-write.c (write_address_map)
11976         (write_one_signatured_type, recursively_write_psymbols)
11977         (class debug_names, class debug_names, write_psymtabs_to_index):
11978         Update.
11979
11980 2019-01-10  Tom Tromey  <tom@tromey.com>
11981
11982         * symtab.h (SYMBOL_SET_NAMES): Update.
11983         (symbol_set_names): Update.
11984         (MSYMBOL_SET_NAMES): Update.
11985         * symtab.c (symbol_set_names): Change argument to be an
11986         objfile_per_bfd_storage.
11987         * psymtab.c (add_psymbol_to_bcache): Update.
11988         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11989
11990 2019-01-10  Tom Tromey  <tom@tromey.com>
11991
11992         * symtab.c (create_demangled_names_hash): Change argument to be an
11993         objfile_per_bfd_storage.
11994         (symbol_set_names): Update.
11995
11996 2019-01-10  Tom Tromey  <tom@tromey.com>
11997
11998         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11999         init_psymbol_list.
12000         * psymtab.c (init_psymbol_list): Do nothing if already called.
12001         * psympriv.h (init_psymbol_list): Add comment.
12002         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12003         init_psymbol_list.
12004         * dbxread.c (dbx_symfile_read): Unconditionally call
12005         init_psymbol_list.
12006
12007 2019-01-10  Tom Tromey  <tom@tromey.com>
12008
12009         * xcoffread.c (scan_xcoff_symtab): Update.
12010         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12011         "where".
12012         * mdebugread.c (parse_partial_symbols)
12013         (handle_psymbol_enumerators): Update.
12014         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12015         * dbxread.c (read_dbx_symtab): Update.
12016         * psympriv.h (psymbol_placement): New enum.
12017         (add_psymbol_to_list): Update.
12018
12019 2019-01-10  Tom Tromey  <tom@tromey.com>
12020
12021         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12022         static_psymbols parameters.
12023         (scan_xcoff_symtab): Update.
12024         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12025         static_psymbols parameters.
12026         * psympriv.h (start_psymtab_common): Update.
12027         * mdebugread.c (parse_partial_symbols): Update.
12028         * dwarf2read.c (create_partial_symtab): Update.
12029         * dbxread.c (read_dbx_symtab): Update.
12030         (start_psymtab): Remove global_psymbols and static_psymbols
12031         parameters.
12032
12033 2019-01-10  Tom Tromey  <tom@tromey.com>
12034
12035         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12036         * psymtab.c (allocate_psymtab): Add comment.
12037         * psympriv.h (allocate_psymtab): Add comment.
12038         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12039         initializations.
12040         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12041
12042 2019-01-10  Tom Tromey  <tom@tromey.com>
12043
12044         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12045         Don't declare.
12046         * mipsread.c: Include mdebugread.h.
12047         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12048         Declare.
12049         * elfread.c: Include mdebugread.h.
12050
12051 2019-01-09  Tom Tromey  <tom@tromey.com>
12052
12053         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12054         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12055         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12056         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12057         (psym_lookup_symbol, psym_find_last_source_symtab)
12058         (psym_forget_cached_source_info, psym_print_stats)
12059         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12060         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12061         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12062         (psym_find_compunit_symtab_by_address)
12063         (maintenance_print_psymbols, maintenance_info_psymtabs)
12064         (maintenance_check_psymtabs): Use ranged for.
12065         * psymtab.h (class objfile_psymtabs): New.
12066         (require_partial_symbols): Return objfile_psymtabs.
12067         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12068
12069 2019-01-09  Tom Tromey  <tom@tromey.com>
12070
12071         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12072         (find_pc_mapped_section, list_overlays_command)
12073         (map_overlay_command, unmap_overlay_command)
12074         (simple_overlay_update): Use all_objfiles.
12075         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12076         * printcmd.c (info_symbol_command): Use all_objfiles.
12077         * objfiles.h (ALL_OBJSECTIONS): Remove.
12078         * maint.c (maintenance_translate_address): Use all_objfiles.
12079         * gcore.c (gcore_create_callback): Use all_objfiles.
12080         (objfile_find_memory_regions): Likewise.
12081
12082 2019-01-09  Tom Tromey  <tom@tromey.com>
12083
12084         * symtab.c (find_line_symtab, info_sources_command)
12085         (make_source_files_completion_list): Use objfile_compunits.
12086         * source.c (select_source_symtab): Use objfile_compunits.
12087         * objfiles.h (struct objfile): Update comment.
12088         (ALL_OBJFILES): Remove.
12089         (ALL_FILETABS): Remove.
12090         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12091         objfile_compunits.
12092
12093 2019-01-09  Tom Tromey  <tom@tromey.com>
12094
12095         * symmisc.c (print_objfile_statistics, dump_objfile)
12096         (maintenance_print_symbols): Use compunit_filetabs.
12097         * source.c (forget_cached_source_info_for_objfile): Use
12098         compunit_filetabs.
12099         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12100         (ALL_FILETABS): Use compunit_filetabs.
12101         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12102         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12103
12104 2019-01-09  Tom Tromey  <tom@tromey.com>
12105
12106         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12107         (compunit_filetabs): New.
12108         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12109         compunit_filetabs.
12110         (info_sources_command, make_source_files_completion_list): Remove
12111         declaration.
12112         * symmisc.c (print_objfile_statistics, dump_objfile)
12113         (maintenance_print_symbols): Remove declaration.
12114         (maintenance_info_symtabs): Use compunit_filetabs.
12115         (maintenance_info_line_tables): Likewise.
12116         * source.c (select_source_symtab): Change local variable name.
12117         (forget_cached_source_info_for_objfile): Remove declaration.
12118         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12119         * objfiles.c (objfile_relocate1): Remove declaration.
12120         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12121         declaration.
12122         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12123         * coffread.c (coff_symtab_read): Remove declaration.
12124         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12125         compunit_filetabs.
12126
12127 2019-01-09  Tom Tromey  <tom@tromey.com>
12128
12129         * symtab.c (lookup_objfile_from_block)
12130         (find_pc_sect_compunit_symtab, search_symbols)
12131         (default_collect_symbol_completion_matches_break_on): Use
12132         objfile_compunits.
12133         * objfiles.h (ALL_COMPUNITS): Remove.
12134         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12135         * cp-support.c (add_symbol_overload_list_qualified): Use
12136         objfile_compunits.
12137         * ada-lang.c (ada_collect_symbol_completion_matches)
12138         (ada_add_global_exceptions): Use objfile_compunits.
12139
12140 2019-01-09  Tom Tromey  <tom@tromey.com>
12141
12142         * source.c (select_source_symtab)
12143         (forget_cached_source_info_for_objfile): Remove declaration.
12144         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12145         declaration.
12146         * maint.c (count_symtabs_and_blocks): Remove declaration.
12147         * cp-support.c (add_symbol_overload_list_qualified): Remove
12148         declaration.
12149         * coffread.c (coff_symtab_read): Remove declaration.
12150         * symtab.c (lookup_symbol_in_objfile_symtabs)
12151         (basic_lookup_transparent_type_1): Use objfile_compunits.
12152         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12153         (info_sources_command, search_symbols)
12154         (default_collect_symbol_completion_matches_break_on)
12155         (make_source_files_completion_list): Remove declaration.
12156         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12157         (ada_collect_symbol_completion_matches)
12158         (ada_add_global_exceptions): Remove declaration.
12159         * linespec.c (iterate_over_all_matching_symtabs): Use
12160         objfile_compunits.
12161         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12162         (class objfile_compunits): New.
12163         (ALL_COMPUNITS): Use objfile_compunits.
12164         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12165         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12166         objfile_compunits.
12167         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12168
12169 2019-01-09  Tom Tromey  <tom@tromey.com>
12170
12171         * symtab.c (search_symbols)
12172         (default_collect_symbol_completion_matches_break_on): Use
12173         objfile_msymbols.
12174         * ada-lang.c (ada_lookup_simple_minsym)
12175         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12176         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12177         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12178         objfile_msymbols.
12179         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12180         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12181         * objc-lang.c (find_methods): Use objfile_msymbols.
12182         (info_selectors_command, info_classes_command): Likewise.
12183         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12184         * objfiles.h (class objfile_msymbols): New.
12185         (ALL_OBJFILE_MSYMBOLS): Remove.
12186         (ALL_MSYMBOLS): Remove.
12187
12188 2019-01-09  Tom Tromey  <tom@tromey.com>
12189
12190         * common/next-iterator.h (next_adapter): Add Iterator template
12191         parameter.
12192         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12193         (class all_objfiles_safe): New.
12194         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12195         * objfiles.c (put_objfile_before): Update comment.
12196         (add_separate_debug_objfile): Likewise.
12197         (free_all_objfiles): Use all_objfiles_safe.
12198         (objfile_purge_solibs): Likewise.
12199
12200 2019-01-09  Tom Tromey  <tom@tromey.com>
12201
12202         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12203         (expand_symtab_containing_pc, lookup_static_symbol)
12204         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12205         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12206         all_objfiles.
12207         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12208         * breakpoint.c (create_overlay_event_breakpoint)
12209         (create_longjmp_master_breakpoint)
12210         (create_std_terminate_master_breakpoint)
12211         (create_exception_master_breakpoint): Use all_objfiles.
12212         * linux-thread-db.c (try_thread_db_load_from_pdir)
12213         (has_libpthread): Use all_objfiles.
12214         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12215         * linespec.c (iterate_over_all_matching_symtabs)
12216         (search_minsyms_for_name): Use all_objfiles.
12217         * maint.c (maintenance_info_sections): Use all_objfiles.
12218         * main.c (captured_main_1): Use all_objfiles.
12219         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12220         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12221         * guile/scm-pretty-print.c
12222         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12223         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12224         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12225         (maintenance_print_msymbols): Use all_objfiles.
12226         * source.c (select_source_symtab): Use all_objfiles.
12227         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12228         * symfile.c (remove_symbol_file_command)
12229         (expand_symtabs_matching, map_symbol_filenames): Use
12230         all_objfiles.
12231         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12232         all_objfiles.
12233         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12234         * objc-lang.c (find_methods): Use all_objfiles.
12235         * objfiles.c (have_partial_symbols, have_full_symbols)
12236         (have_minimal_symbols, qsort_cmp)
12237         (default_iterate_over_objfiles_in_search_order): Use
12238         all_objfiles.
12239         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12240         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12241         (maintenance_check_psymtabs): Use all_objfiles.
12242         (ALL_PSYMTABS): Remove.
12243         * compile/compile-object-run.c (do_module_cleanup): Use
12244         all_objfiles.
12245         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12246         * cp-support.c (add_symbol_overload_list_qualified): Use
12247         all_objfiles.
12248         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12249         Use all_objfiles.
12250         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12251         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12252         all_objfiles.
12253         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12254         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12255         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12256         Uses all_objfiles.
12257         * solib.c (solib_read_symbols): Use all_objfiles
12258
12259 2019-01-09  Tom Tromey  <tom@tromey.com>
12260
12261         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12262         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12263         all_objfiles.
12264         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12265         * symmisc.c (print_symbol_bcache_statistics)
12266         (print_objfile_statistics, maintenance_print_objfiles)
12267         (maintenance_info_symtabs, maintenance_check_symtabs)
12268         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12269         all_objfiles.
12270         * source.c (forget_cached_source_info): Use all_objfiles.
12271         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12272         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12273         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12274         * objfiles.c (update_section_map): Use all_objfiles.
12275         (shared_objfile_contains_address_p): Likewise.
12276         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12277         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12278
12279 2019-01-09  Tom Tromey  <tom@tromey.com>
12280
12281         * common/next-iterator.h: New file.
12282         * objfiles.h (class all_objfiles): New.
12283         (struct objfile_iterator): New.
12284
12285 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12286
12287         * NEWS: Move the description of the changed "frame", "select-frame",
12288          and "info frame" commands to the Changed commands section.
12289
12290 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12291
12292         * gdbtypes.c (check_stub_method_group): Remove handling of old
12293         mangling schemes.
12294         * linespec.c (find_methods): Likewise.
12295         * stabsread.c (read_member_functions): Likewise.
12296         * valops.c (search_struct_method): Likewise.
12297         (value_struct_elt_for_reference): Likewise.
12298         * NEWS: Mention this change.
12299
12300 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12301
12302         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12303         print_source_lines.
12304         * source.c (print_source_lines_base): Update line number check.
12305         (print_source_lines): New function.
12306         (source_lines_range::source_lines_range): New function.
12307         * source.h (class source_lines_range): New class.
12308         (print_source_lines): New declaration.
12309
12310 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12311
12312         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12313
12314 2019-01-08  Tom Tromey  <tom@tromey.com>
12315             Simon Marchi  <simon.marchi@ericsson.com>
12316
12317         PR gdb/24060
12318         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12319         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12320         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12321         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12322         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12323         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12324
12325 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12326
12327         * source.c (select_source_symtab): Move header comment to
12328         declaration in source.h.
12329         (forget_cached_source_info_for_objfile): Likewise.
12330         (forget_cached_source_info): Likewise.
12331         (identify_source_line): Likewise.
12332         * source.h (identify_source_line): Move declaration from symtab.h
12333         and add comment from source.c
12334         (print_source_lines): Likewise.
12335         (forget_cached_source_info_for_objfile): Likewise.
12336         (forget_cached_source_info): Likewise.
12337         (select_source_symtab): Likewise.
12338         (enum print_source_lines_flag): Move definition from symtab.h.
12339         * symtab.h (identify_source_line): Move declaration to source.h.
12340         (print_source_lines): Likewise.
12341         (forget_cached_source_info_for_objfile): Likewise.
12342         (forget_cached_source_info): Likewise.
12343         (select_source_symtab): Likewise.
12344         (enum print_source_lines_flag): Move definition to source.h.
12345         * tui/tui-hooks.c: Add 'source.h' include.
12346
12347 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12348
12349         * source.c (print_source_lines_base): Handle requests to print
12350         reverse line number sequences, and guard against empty lines
12351         string.
12352
12353 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12354
12355         * source.c (print_source_lines_base): Fix skip of '\r' if next
12356         character is '\n'.
12357
12358 2019-01-06  Tom Tromey  <tom@tromey.com>
12359
12360         * c-exp.y (struct c_parse_state) <macro_original_text,
12361         expansion_obstack>: New member.
12362         (macro_original_text, expansion_obstack): Remove globals.
12363         (scan_macro_expansion, scanning_macro_expansion)
12364         (finished_macro_expansion): Update.
12365         (scan_macro_cleanup): Remove.
12366         (yylex, c_parse): Update.
12367
12368 2019-01-06  Tom Tromey  <tom@tromey.com>
12369
12370         * c-exp.y (struct c_parse_state) <strings>: New member.
12371         (operator_stoken): Update.
12372
12373 2019-01-06  Tom Tromey  <tom@tromey.com>
12374
12375         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12376         (union type_stack_elt) <typelist_val>: Now a pointer to
12377         std::vector.
12378         (type_stack_cleanup): Don't declare.
12379         (push_typelist): Update.
12380         * parse.c (pop_typelist): Return a std::vector.
12381         (push_typelist): Take a std::vector.
12382         (follow_types): Update.  Do not free args.
12383         (type_stack_cleanup): Remove.
12384         * c-exp.y (struct c_parse_state): New.
12385         (cpstate): New global.
12386         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12387         (nonempty_typelist): Update.
12388         (func_mod): Create a new vector.
12389         (c_parse): Create a c_parse_state.
12390         (check_parameter_typelist): Do not delete params.
12391         (function_method): Update.  Do not delete type_list.
12392
12393 2019-01-06  Tom Tromey  <tom@tromey.com>
12394
12395         PR gdb/28155:
12396         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12397         check_typedef.
12398         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12399         (print_return_value): Likewise.
12400
12401 2019-01-05  Tom Tromey  <tom@tromey.com>
12402
12403         * contrib/cleanup_check.py: Remove.
12404         * contrib/gcc-with-excheck: Remove.
12405         * contrib/exsummary.py: Remove.
12406         * contrib/excheck.py: Remove.
12407
12408 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12409
12410         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12411         NULL. Initialize tpprev to NULL instead of assigning it
12412         to NULL on the next statement.
12413         * windows-nat.c (windows_delete_thread): Remove check for
12414         main_thread_id before printing thread exit notifications.
12415         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12416         Remove thread ID check against main_thread_id.
12417         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12418         windows_delete_thread.
12419         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12420
12421 2019-01-04  Tom Tromey  <tom@tromey.com>
12422
12423         * compile/compile.c (_initialize_compile): Use upper case for
12424         metasyntactic variables.
12425         * symmisc.c (_initialize_symmisc): Use upper case for
12426         metasyntactic variables.
12427         * psymtab.c (_initialize_psymtab): Use upper case for
12428         metasyntactic variables.
12429         * demangle.c (demangle_command): Use upper case for metasyntactic
12430         variables.
12431         (_initialize_demangler): Likewise.
12432         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12433         variables.
12434
12435 2019-01-03  Tom Tromey  <tom@tromey.com>
12436
12437         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12438
12439 2019-01-03  Tom Tromey  <tom@tromey.com>
12440
12441         * python/py-symtab.c (salpy_str): Update.
12442         (struct salpy_sal_object) <symtab>: Now a PyObject.
12443         (salpy_dealloc): Update.
12444         (del_objfile_sal): Use gdbpy_ref.
12445
12446 2019-01-03  Tom Tromey  <tom@tromey.com>
12447
12448         * python/py-type.c (convert_field): Use new_reference.  Return
12449         gdbpy_ref.
12450         (make_fielditem): Return gdbpy_ref.
12451         (typy_fields): Update.
12452         (typy_getitem): Update.
12453         (field_name): Return gdbpy_ref.  Use new_reference.
12454         (typy_iterator_iternext): Update.
12455
12456 2019-01-03  Tom Tromey  <tom@tromey.com>
12457
12458         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12459
12460 2019-01-03  Tom Tromey  <tom@tromey.com>
12461
12462         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12463         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12464         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12465         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12466         (pspy_set_type_printers): Likewise.
12467         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12468         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12469         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12470         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12471         (objfpy_set_type_printers): Likewise.
12472
12473 2019-01-03  Tom Tromey  <tom@tromey.com>
12474
12475         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12476         (gdbpy_print_stack): Use gdbpy_err_fetch.
12477         * python/python-internal.h (class gdbpy_err_fetch): New class.
12478         (class gdbpy_enter) <m_error_type, m_error_value,
12479         m_error_traceback>: Remove.
12480         <m_error>: New member.
12481         (gdbpy_exception_to_string): Don't declare.
12482         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12483         * python/py-value.c (convert_value_from_python): Use
12484         gdbpy_err_fetch.
12485         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12486         gdbpy_exception_to_string.
12487         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12488         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12489         gdbpy_err_fetch.
12490
12491 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12492
12493         * linux-nat.c (delete_lwp_cleanup): Delete.
12494         (struct lwp_deleter): New struct.
12495         (lwp_info_up): New typedef.
12496         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12497         lwp_info_up.
12498
12499 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12500
12501         * linux-fork.c (class scoped_switch_fork_info): New class.
12502         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12503
12504 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12505
12506         * valops.c (find_overload_match): Remove use of null_cleanup, and
12507         calls to do_cleanups.
12508
12509 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12510
12511         * compile/compile-cplus-types.c
12512         (compile_cplus_instance::decl_name): Handle changes to
12513         cp_func_name.
12514         * cp-support.c (cp_func_name): Update header comment, update
12515         return type.
12516         * cp-support.h (cp_func_name): Update return type in declaration.
12517         * valops.c (find_overload_match): Move temp_func local to top
12518         level of function and change its type.  Use temp_func to hold and
12519         delete temporary string obtained from cp_func_name.
12520
12521 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12522
12523         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12524         gdb::char_vector, remove cleanup, and update uses of `msg`.
12525
12526 2019-01-03  Jim Wilson  <jimw@sifive.com>
12527
12528         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12529
12530 2019-01-02  Tom Tromey  <tom@tromey.com>
12531
12532         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12533         (tdesc_parse_xml): Remove cleanups.
12534         * target-descriptions.h (make_cleanup_free_target_description):
12535         Don't declare.
12536         (target_desc_deleter): New struct.
12537         (target_desc_up): New typedef.
12538         * target-descriptions.c (target_desc_deleter::operator()): Rename
12539         from free_target_description.
12540         (make_cleanup_free_target_description): Remove.
12541
12542 2019-01-02  Tom Tromey  <tom@tromey.com>
12543
12544         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12545         constructor, destructor.
12546         (linespec_parser): Remove typedef.
12547         (~linespec_parser): Rename from linespec_parser_delete.
12548         (linespec_lex_to_end, linespec_complete_label)
12549         (linespec_complete): Update.
12550         (decode_line_full): Remove cleanups.
12551         (decode_line_1): Update.
12552
12553 2019-01-02  Tom Tromey  <tom@tromey.com>
12554
12555         * python/python-internal.h (inferior_to_inferior_object): Change
12556         return type.
12557         * python/py-exitedevent.c (create_exited_event_object): Update.
12558         * python/py-inferior.c (inferior_to_inferior_object): Return
12559         gdbpy_ref.
12560         (python_new_inferior, python_inferior_deleted)
12561         (thread_to_thread_object, delete_thread_object)
12562         (build_inferior_list, gdbpy_selected_inferior): Update.
12563         * python/py-infthread.c (create_thread_object): Update.  Also fail
12564         if inferior_to_inferior_object fails.
12565
12566 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12567
12568         * inferior.h (class inferior) <displaced_step_state>: New field.
12569         * infrun.h (struct displaced_step_state): Move here from
12570         infrun.c.  Initialize fields, add constructor.
12571         <inf>: Remove field.
12572         <reset>: New method.
12573         * infrun.c (struct displaced_step_inferior_state): Move to
12574         infrun.h.
12575         (displaced_step_inferior_states): Remove.
12576         (get_displaced_stepping_state): Adust.
12577         (displaced_step_in_progress_any_inferior): Adjust.
12578         (displaced_step_in_progress_thread): Adjust.
12579         (displaced_step_in_progress): Adjust.
12580         (add_displaced_stepping_state): Remove.
12581         (get_displaced_step_closure_by_addr): Adjust.
12582         (remove_displaced_stepping_state): Remove.
12583         (infrun_inferior_exit): Call displaced_step_state.reset.
12584         (use_displaced_stepping): Don't check for NULL.
12585         (displaced_step_prepare_throw): Call
12586         get_displaced_stepping_state.
12587         (displaced_step_fixup): Don't check for NULL.
12588         (prepare_for_detach): Don't check for NULL.
12589
12590 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12591
12592         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12593          in case of call that did not complete.
12594
12595 2019-01-02  Andrey Utkin  <autkin@undo.io>
12596
12597         * symfile.c (find_separate_debug_file): Fix search of debug files for
12598         remote debuggee.
12599
12600 2019-01-02  Tom Tromey  <tom@tromey.com>
12601
12602         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12603         indentation.
12604         * python/py-frame.c (frapy_older): Remove cast.
12605         (frapy_newer): Likewise.
12606         * python/py-breakpoint.c (local_setattro): Remove cast.
12607         * python/py-arch.c (archpy_name): Remove local variable.
12608         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12609
12610 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12611
12612         * unittests/basic_string_view/element_access/char/empty.cc:
12613         Fix year range in copyright header.
12614
12615 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12616
12617         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12618         Delete.
12619         <operator==>: Update with for removed field.
12620         <hash>: Likewise.
12621         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12622         <isa_features>: ...this.
12623         <abi_features>: New field.
12624         (riscv_isa_flen): Update comment.
12625         (riscv_abi_xlen): New declaration.
12626         (riscv_abi_flen): New declaration.
12627         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12628         isa_features.
12629         (riscv_abi_xlen): New function.
12630         (riscv_isa_flen): Update to get answer from isa_features.
12631         (riscv_abi_flen): New function.
12632         (riscv_has_fp_abi): Update to get answer from abi_features.
12633         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12634         xlen and flen.
12635         (riscv_call_info) <xlen, flen>: Update comment.
12636         (riscv_call_arg_struct): Remove invalid assertions
12637         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12638         is removed.
12639         (riscv_gdbarch_init): Gather isa features and abi features
12640         separately, ensure both match on the gdbarch when reusing an old
12641         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12642         a target with 64-bit float hardware.
12643
12644 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12645
12646         * source.c (search_command_helper): Stop reverse search
12647         when line 1 has been searched.
12648
12649 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12650
12651         * record-full.c (record_full_base_target::close): Rewrite
12652         record_full_core_buf_list free logic.
12653
12654 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12655
12656         * break-catch-syscall.c (print_one_catch_syscall): xfree
12657         the last text.
12658
12659 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12660
12661         * top.c (print_gdb_version): Update Copyright year in version
12662         message.
12663
12664 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12665
12666         Update copyright year range in all GDB files.
12667
12668 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12669
12670         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12671
12672 For older changes see ChangeLog-2018.
12673 \f
12674 Local Variables:
12675 mode: change-log
12676 left-margin: 8
12677 fill-column: 74
12678 version-control: never
12679 coding: utf-8
12680 End:
12681