gdb/ChangeLog

   1 2019-07-15  Tom Tromey  <tromey@adacore.com>
   2
   3         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
   4         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
   5         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
   6         * cli-out.c (cli_ui_out::do_field_int): New method.
   7         * ui-out.c (ui_out::field_unsigned): New method.
   8         * symfile.c (generic_load): Use field_unsigned.
   9         (print_transfer_performance): Likewise.
  10         * record-btrace.c (ui_out_field_uint): Remove.
  11         (btrace_call_history_insn_range, btrace_call_history): Use
  12         field_unsigned.
  13         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
  14         field_unsigned.
  15         * ui-out.h (class ui_out) <field_unsigned>: New method.
  16         <do_field_unsigned>: Likewise.
  17
  18 2019-07-15  Tom Tromey  <tromey@adacore.com>
  19
  20         * mi/mi-main.c (list_available_thread_groups): Use field_string.
  21         * mi/mi-interp.c (mi_memory_changed): Use field_string.
  22         * target.c (flash_erase_command): Use field_string.
  23         * infrun.c (print_signal_received_reason): Use field_string.
  24         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
  25         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
  26         field_string.
  27         * ada-tasks.c (print_ada_task_info): Use field_string.
  28
  29 2019-07-15  Tom Tromey  <tromey@adacore.com>
  30
  31         * target.c (flash_erase_command): Use field_core_addr.
  32         * symfile.c (generic_load): Use field_core_addr.
  33         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
  34         Use field_core_addr.
  35         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
  36         field_core_addr.
  37
  38 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  39
  40         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
  41         value if its desired type is smaller than a CORE_ADDR and signed.
  42
  43 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  44
  45         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
  46         of changes to field names, and use new is_reference field to
  47         decide if a property is a reference or not.
  48         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
  49         field.
  50         (struct dwarf2_property_baton): Update header comment, rename
  51         'referenced_type' to 'property_type' and update comments.
  52         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
  53         default property type, store in property baton, update to take
  54         accound of renamed field.
  55         (read_func_scope): Update call to attr_to_dynamic_prop.
  56         (read_array_type): Likewise.
  57         (dwarf2_per_cu_addr_sized_int_type): New function.
  58         (read_subrange_index_type): Move type finding code to
  59         dwarf2_per_cu_addr_sized_int_type.
  60         (read_subrange_type): Update calls to attr_to_dynamic_prop.
  61         (dwarf2_per_cu_addr_type): New function.
  62         (set_die_type): Update calls to attr_to_dynamic_prop.
  63
  64 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  65
  66         * dwarf2read.c (read_subrange_index_type): New function.
  67         (read_subrange_type): Move code into new function and call it.
  68         * gdbtypes.c (create_range_type): Add some asserts.
  69
  70 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  71
  72         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
  73         update return statements.
  74         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
  75         declaration, and update comment to match.
  76         * gdbtypes.c (resolve_dynamic_array): Update call to
  77         dwarf2_evaluate_property to match new return type.
  78
  79 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  80
  81         * valarith.c (value_subscripted_rvalue): Change lowerbound
  82         parameter type from int to LONGEST.
  83         * value.h (value_subscripted_rvalue): Likewise in declaration.
  84
  85 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  86
  87         * cli/cli-utils.c (info_print_command_completer): New function.
  88         * cli/cli-utils.h: Add 'completer.h' include, and forward
  89         declaration for 'struct cmd_list_element'.
  90         (info_print_command_completer): Declare.
  91         * stack.c (_initialize_stack): Add completer for 'info locals' and
  92         'info args'.
  93         * symtab.c (_initialize_symtab): Add completer for 'info
  94         variables' and 'info functions'.
  95         * NEWS: Mention completion for additional info commands.
  96
  97 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
  98
  99         * cli/cli-utils.c (extract_info_print_args): Delete.
 100         (extract_arg_maybe_quoted): Delete.
 101         (info_print_options_defs): New variable.
 102         (make_info_print_options_def_group): New function.
 103         (extract_info_print_options): Define new function.
 104         * cli/cli-utils.h (extract_info_print_args): Delete.
 105         (struct info_print_options): New structure.
 106         (extract_info_print_options): Declare new function.
 107         * stack.c (info_locals_command): Update to use new
 108         extract_info_print_options, also add a header comment.
 109         (info_args_command): Likewise.
 110         * symtab.c (info_variables_command): Likewise.
 111         (info_functions_command): Likewise.
 112
 113 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 114
 115         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 116         to extract string arguments.
 117         * common/common-utils.c (extract_string_maybe_quoted): New function.
 118         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 119
 120 2019-07-11  Tom Tromey  <tromey@adacore.com>
 121
 122         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 123         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 124         * top.h (gdbinit): Don't declare.
 125         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 126         into...
 127         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 128         * top.c (gdb_init): Don't call init_cli_cmds.
 129         (gdbinit): Remove.
 130         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 131
 132 2019-07-11  Tom Tromey  <tromey@adacore.com>
 133
 134         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 135         after it has been moved.
 136
 137 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 138
 139         * valops.c (value_must_coerce_to_target): Change return type to
 140         bool.
 141         * value.h (value_must_coerce_to_target): Likewise.
 142
 143 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 144
 145         * breakpoint.c (is_hardware_watchpoint): Remove
 146         forward-declaration.
 147         (is_masked_watchpoint): Change return type to bool.
 148         (is_tracepoint): Likewise.
 149         (is_breakpoint): Likewise.
 150         (is_hardware_watchpoint): Likewise.
 151         (is_watchpoint): Likewise.
 152         (is_no_memory_software_watchpoint): Likewise.
 153         (is_catchpoint): Likewise.
 154         (breakpoint_1): Make FILTER parameter's return type bool.
 155         is_masked_watchpoint): Change return type to bool.
 156         (save_breakpoints): Make FILTER parameter's return type bool.
 157         * breakpoint.h (is_breakpoint): Change return type to bool.
 158         (is_watchpoint): Likewise.
 159         (is_catchpoint): Likewise.
 160         (is_tracepoint): Likewise.
 161
 162 2019-07-10  Tom Tromey  <tom@tromey.com>
 163
 164         * defs.h: Don't include gdbarch.h.
 165         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 166         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 167         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 168         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 169         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 170         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 171         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 172         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 173         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 174         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 175         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 176         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 177         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 178         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 179         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 180         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 181         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 182         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 183         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 184         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 185         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 186         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 187         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 188         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 189         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 190         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 191         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 192
 193 2019-07-10  Tom Tromey  <tromey@adacore.com>
 194
 195         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 196         * breakpoint.c (init_ada_exception_breakpoint): Register as
 197         bp_catchpoint.
 198         (print_one_breakpoint_location, print_one_breakpoint): Use
 199         is_ada_exception_catchpoint.
 200         * ada-lang.c (class ada_catchpoint_location): Pass
 201         bp_loc_software_breakpoint to bp_location constructor.
 202         (is_ada_exception_catchpoint): New function.
 203
 204 2019-07-10  Tom Tromey  <tromey@adacore.com>
 205
 206         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 207         VEC.
 208         (struct arm_exidx_entry): New method operator<.
 209         (struct arm_exidx_data) <section_maps>: Change type.
 210         (arm_exidx_data_free): Remove.
 211         (arm_exidx_data_key): Change type.  Move lower.
 212         (arm_exidx_new_objfile): Update.
 213         (arm_compare_exidx_entries): Remove.
 214         (arm_find_exidx_entry, _initialize_arm_tdep)
 215
 216 2019-07-10  Tom Tromey  <tromey@adacore.com>
 217
 218         * solib-spu.c (ocl_program_data_key): Change type.
 219         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 220         Update.
 221
 222 2019-07-10  Tom Tromey  <tromey@adacore.com>
 223
 224         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 225         (struct solib_aix_inferior_data) <library_list>: Change type.
 226         (solib_aix_inferior_data_handle): Change type.
 227         (get_solib_aix_inferior_data): Update.
 228         (solib_aix_free_library_list): Remove.
 229         (library_list_start_library): Update.
 230         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 231         return type.
 232         (solib_aix_get_library_list)
 233         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 234         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 235
 236 2019-07-10  Tom Tromey  <tromey@adacore.com>
 237
 238         * solib-dsbt.c (struct dsbt_info): Add initializers.
 239         (solib_dsbt_pspace_data): Change type.
 240         (dsbt_pspace_data_cleanup): Remove.
 241         (get_dsbt_info, _initialize_dsbt_solib): Update.
 242
 243 2019-07-10  Tom Tromey  <tromey@adacore.com>
 244
 245         * spu-tdep.c (spu_overlay_data): Change type.
 246         (spu_get_overlay_table, spu_overlay_new_objfile)
 247         (_initialize_spu_tdep): Update.
 248
 249 2019-07-10  Tom Tromey  <tromey@adacore.com>
 250
 251         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 252         destructor.
 253         (dbx_objfile_data_key): Change type and declare later.
 254         (DBX_SYMFILE_INFO): Rewrite.
 255         * dbxread.c (dbx_objfile_data_key): Change type.
 256         (dbx_symfile_init): Update.
 257         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 258         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 259         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 260
 261 2019-07-10  Tom Tromey  <tromey@adacore.com>
 262
 263         * jit.c (jit_program_space_key): Change type.  Move lower.
 264         (get_jit_program_space_data): Update.
 265         (jit_program_space_data_cleanup): Remove.
 266         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 267         Update.
 268         (struct jit_program_space_data): Add initializers.
 269
 270 2019-07-10  Tom Tromey  <tromey@adacore.com>
 271
 272         * solib-darwin.c (struct darwin_info): Add initializers.
 273         (solib_darwin_pspace_data): Change type.
 274         (darwin_pspace_data_cleanup): Remove.
 275         (get_darwin_info, _initialize_darwin_solib): Update.
 276
 277 2019-07-10  Tom Tromey  <tromey@adacore.com>
 278
 279         * remote-sim.c (struct sim_inferior_data): Add initializers,
 280         constructor, and destructor.
 281         (sim_inferior_data_key): Change type.  Move lower.
 282         (check_for_duplicate_sim_descriptor): Update.
 283         (get_sim_inferior_data): Use new.  Update.
 284         (~sim_inferior_data_cleanup): Rename from
 285         sim_inferior_data_cleanup.  Simplify.
 286         (gdbsim_close_inferior, simulator_command)
 287         (sim_command_completer, _initialize_remote_sim): Update.
 288         (next_pid, INITIAL_PID): Move earlier.
 289
 290 2019-07-10  Tom Tromey  <tromey@adacore.com>
 291
 292         * python/python-internal.h (create_thread_object): Return
 293         gdbpy_ref.
 294         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 295         * python/py-inferior.c (struct threadlist_entry): Add
 296         constructor.
 297         <thread_obj>: Now a gdbpy_ref.
 298         (thread_to_thread_object): Update.
 299         (add_thread_object): Use new.
 300         (delete_thread_object): Use delete.
 301         (infpy_threads): Update.
 302         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 303         GIL.
 304
 305 2019-07-10  Tom Tromey  <tromey@adacore.com>
 306
 307         * valops.c (value_cast): Specialize error message for Ada.
 308
 309 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 310
 311         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 312
 313 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 314
 315         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 316         bpstat_should_step): Return bool, adjust comments.
 317         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 318         bpstat_should_step): Likewise.
 319
 320 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 321
 322         * features/Makefile: Use feature target descriptions for Arm.
 323         * features/arm/arm-core.c: Generate new file.
 324         * features/arm/arm-fpa.c: Likewise.
 325         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 326         * features/arm/arm-m-profile.c: Likewise.
 327         * features/arm/arm-vfpv2.c: Likewise.
 328         * features/arm/arm-vfpv3.c: Likewise.
 329         * features/arm/xscale-iwmmxt.c: Likewise.
 330         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 331
 332 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 333
 334         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 335         ptrace earlier.
 336
 337 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 338
 339         * features/aarch64-pauth.c: Regenerate.
 340
 341 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 342
 343         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 344         bool.
 345         (bpstat_what): Use false instead of 0.
 346
 347 2019-07-09  Pedro Alves  <palves@redhat.com>
 348
 349         * break-catch-throw.c (is_exception_catchpoint): New.
 350         * breakpoint.c (print_one_breakpoint_location): New parameter
 351         'raw_loc'.  Handle it.  Use
 352         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 353         looking at the breakpoint's type.
 354         (print_one_breakpoint): If handling "maint info breakpoints", also
 355         print locations of exception catchpoints.
 356         * breakpoint.h (is_exception_catchpoint): Declare.
 357
 358 2019-07-09  Pedro Alves  <palves@redhat.com>
 359
 360         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 361         "addr" field.
 362         (allocate_location_exception_catchpoint): New.
 363         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 364         (initialize_throw_catchpoint_ops): Install
 365         allocate_location_exception_catchpoint as allocate_location
 366         method.
 367         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 368         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 369         bp_loc_other.
 370         (breakpoint_address_is_meaningful): Delete.
 371         (bl_address_is_meaningful): New.
 372         (breakpoint_locations_match): Adjust comment.
 373         (bp_location_from_bp_type): New, factored out of...
 374         (bp_location::bp_location(breakpoint *)): ... this.
 375         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 376         factored out of...
 377         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 378         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 379         breakpoint_address_is_meaningful.
 380         (bp_locations_compare): Adjust comment.
 381         (update_global_location_list): Use bl_address_is_meaningful
 382         instead of breakpoint_address_is_meaningful.
 383         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 384         explicit.
 385         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 386         * python/py-breakpoint.c (bppy_get_location): No longer check
 387         whether location is null.
 388
 389 2019-07-09  Pedro Alves  <palves@redhat.com>
 390
 391         PR c++/15468
 392         * breakpoint.c (print_one_breakpoint_location): Remove
 393         single-location assert.
 394
 395 2019-07-09  Tom Tromey  <tom@tromey.com>
 396
 397         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 398         * configure: Rebuild.
 399         * configure.ac: Change common to gdbsupport.
 400         * gdbsupport: Rename from common.
 401         * acinclude.m4: Change common to gdbsupport.
 402         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 403         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 404         gdbsupport.
 405         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 406         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 407         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 408         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 409         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 410         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 411         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 412         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 413         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 414         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 415         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 416         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 417         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 418         coff-pe-read.c, command.h, compile/compile-c-support.c,
 419         compile/compile-c.h, compile/compile-cplus-symbols.c,
 420         compile/compile-cplus-types.c, compile/compile-cplus.h,
 421         compile/compile-loc2c.c, compile/compile.c, completer.c,
 422         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 423         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 424         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 425         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 426         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 427         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 428         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 429         features/aarch64-core.c, features/aarch64-fpu.c,
 430         features/aarch64-pauth.c, features/aarch64-sve.c,
 431         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 432         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 433         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 434         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 435         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 436         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 437         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 438         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 439         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 440         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 441         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 442         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 443         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 444         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 445         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 446         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 447         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 448         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 449         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 450         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 451         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 452         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 453         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 454         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 455         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 456         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 457         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 458         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 459         minsyms.c, mips-linux-tdep.c, namespace.h,
 460         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 461         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 462         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 463         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 464         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 465         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 466         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 467         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 468         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 469         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 470         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 471         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 472         procfs.c, producer.c, progspace.h, psymtab.h,
 473         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 474         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 475         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 476         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 477         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 478         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 479         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 480         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 481         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 482         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 483         target-memory.c, target.c, target.h, target/waitstatus.c,
 484         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 485         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 486         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 487         unittests/array-view-selftests.c,
 488         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 489         unittests/common-utils-selftests.c,
 490         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 491         unittests/format_pieces-selftests.c,
 492         unittests/function-view-selftests.c,
 493         unittests/lookup_name_info-selftests.c,
 494         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 495         unittests/mkdir-recursive-selftests.c,
 496         unittests/observable-selftests.c,
 497         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 498         unittests/parse-connection-spec-selftests.c,
 499         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 500         unittests/scoped_fd-selftests.c,
 501         unittests/scoped_mmap-selftests.c,
 502         unittests/scoped_restore-selftests.c,
 503         unittests/string_view-selftests.c, unittests/style-selftests.c,
 504         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 505         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 506         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 507         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 508         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 509         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 510
 511 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 512
 513         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 514         bool value.
 515         (decode_digits_ordinary): Set explicit_line field in sal.
 516         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 517         symtab_and_line that was set on an explicit line number in
 518         assembler code.  Do always update the recorded symtab and line if
 519         we do skip the prologue.
 520
 521 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 522
 523         * breakpoint.c (set_breakpoint_location_function): Remove
 524         explicit_loc parameter.
 525         (momentary_breakpoint_from_master): Update call to
 526         set_breakpoint_location_function.
 527         (add_location_to_breakpoint): Likewise.
 528
 529 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 530
 531         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 532         required features based on default bfd type when no specific bfd
 533         is present.
 534
 535 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 536
 537         * NEWS: Mention that GDB printf and eval commands can now print
 538         C-style and Ada-style convenience var strings without
 539         calling the inferior.
 540         * printcmd.c (printf_c_string): Locally print GDB internal var
 541         instead of transiting via the inferior.
 542         (printf_wide_c_string): Likewise.
 543
 544 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 545
 546         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 547
 548 2019-07-04  Tom Tromey  <tom@tromey.com>
 549
 550         PR tui/24724:
 551         * tui/tui-winsource.c (tui_clear_source_content): Update.
 552         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 553         (tui_update_breakpoint_info): Update.
 554         (tui_set_exec_info_content): Update.
 555         * tui/tui-source.c (tui_set_source_content_nil): Update.
 556         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 557         has_break.
 558         * tui/tui-data.h (enum tui_bp_flag): New.
 559         (tui_bp_flags): New enum flags type.
 560         (struct tui_source_element) <break_mode>: Change type.  Rename
 561         from has_break.
 562         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 563         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 564         constants.
 565         * tui/tui-winsource.h: Fix comment.
 566
 567 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 568
 569         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 570         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 571         (store_fpregs_to_thread)
 572         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 573         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 574         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 575         (IWMMXT_REGS_SIZE): Add define.
 576         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 577         (fetch_vfp_regs, store_vfp_regs)
 578         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 579         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 580
 581 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 582
 583         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 584         defines.
 585         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 586         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 587         (ARM_INT_REGISTER_SIZE): ...to this.
 588         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 589         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 590         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 591         (arm_linux_collect_gregset, supply_nwfpe_register)
 592         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 593         defines.
 594         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 595         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 596         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 597         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 598         (arm_return_in_memory, arm_store_return_value)
 599         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 600         (arm_record_ld_st_multiple): Likewise.
 601         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 602         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 603
 604 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 605
 606         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 607         AARCH64_DISPLACED_MODIFIED_INSNS.
 608         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 609         (aarch64_displaced_step_copy_insn): Likewise.
 610         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 611         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 612         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 613         ARM_DISPLACED_MODIFIED_INSNS.
 614         * arm-tdep.c (arm_gdbarch_init): Likewise.
 615         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 616         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 617         (struct arm_displaced_step_closure): Use
 618         ARM_DISPLACED_MODIFIED_INSNS.
 619
 620 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 621
 622         * features/Makefile: Remove unused xml files.
 623         * features/aarch64.xml: Remove.
 624         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 625         * features/i386/amd64-avx-avx512.xml: Remove.
 626         * features/i386/amd64-avx-linux.xml: Remove.
 627         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 628         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 629         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 630         * features/i386/amd64-avx-mpx.xml: Remove.
 631         * features/i386/amd64-avx.xml: Remove.
 632         * features/i386/amd64-linux.xml: Remove.
 633         * features/i386/amd64-mpx-linux.xml: Remove.
 634         * features/i386/amd64-mpx.xml: Remove.
 635         * features/i386/amd64.xml: Remove.
 636         * features/i386/i386-avx-avx512-linux.xml: Remove.
 637         * features/i386/i386-avx-avx512.xml: Remove.
 638         * features/i386/i386-avx-linux.xml: Remove.
 639         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 640         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 641         * features/i386/i386-avx-mpx-linux.xml: Remove.
 642         * features/i386/i386-avx-mpx.xml: Remove.
 643         * features/i386/i386-avx.xml: Remove.
 644         * features/i386/i386-linux.xml: Remove.
 645         * features/i386/i386-mmx-linux.xml: Remove.
 646         * features/i386/i386-mmx.xml: Remove.
 647         * features/i386/i386-mpx-linux.xml: Remove.
 648         * features/i386/i386-mpx.xml: Remove.
 649         * features/i386/i386.xml: Remove.
 650         * features/i386/x32-avx-avx512-linux.xml: Remove.
 651         * features/i386/x32-avx-linux.xml: Remove.
 652         * features/i386/x32-linux.xml: Remove.
 653
 654 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 655
 656         * regformats/aarch64.dat: Remove.
 657         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 658         * regformats/i386/amd64-avx-linux.dat: Remove.
 659         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 660         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 661         * regformats/i386/amd64-linux.dat: Remove.
 662         * regformats/i386/amd64-mpx-linux.dat: Remove.
 663         * regformats/i386/amd64.dat: Remove.
 664         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 665         * regformats/i386/i386-avx-linux.dat: Remove.
 666         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 667         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 668         * regformats/i386/i386-linux.dat: Remove.
 669         * regformats/i386/i386-mmx-linux.dat: Remove.
 670         * regformats/i386/i386-mpx-linux.dat: Remove.
 671         * regformats/i386/i386.dat: Remove.
 672         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 673         * regformats/i386/x32-avx-linux.dat: Remove.
 674         * regformats/i386/x32-linux.dat: Remove.
 675
 676 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 677
 678         * aarch64-tdep.c: Remove xml self tests.
 679         * amd64-linux-tdep.c: Likewise.
 680         * amd64-tdep.c: Likewise.
 681         * i386-linux-tdep.c: Likewise.
 682         * i386-tdep.c: Likewise.
 683
 684 2019-07-03  Pedro Alves  <palves@redhat.com>
 685
 686         PR cli/24732
 687         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 688         (pipe_cmd_option_defs): New.
 689         (make_pipe_cmd_options_def_group): New.
 690         (pipe_command): Use gdb::option::process_options.
 691         (pipe_command_completer): New function.
 692         (_initialize_cli_cmds): Install completer for "pipe" command.
 693
 694 2019-07-03  Pedro Alves  <palves@redhat.com>
 695
 696         * cli/cli-option.c (union option_value) <string>: New field.
 697         (struct option_def_and_value): Add ctor, move ctor, dtor and
 698         use DISABLE_COPY_AND_ASSIGN.
 699         (option_def_and_value::clear_value): New.
 700         (parse_option, save_option_value_in_ctx, get_val_type_str)
 701         (add_setshow_cmds_for_options): Handle var_string.
 702         * cli-option.h (union option_def::var_address) <string>: New
 703         field.
 704         (struct string_option_def): New.
 705         * maint-test-options.c (struct test_options_opts): Add default
 706         ctor and use DISABLE_COPY_AND_ASSIGN.
 707         <string_opt>: New field.
 708         (test_options_opts::~test_options_opts): New.
 709         (test_options_opts::dump): Also dump "-string".
 710         (test_options_option_defs): Install "string.
 711
 712 2019-07-03  Pedro Alves  <palves@redhat.com>
 713
 714         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 715         option_value with a null enumeration.
 716         (complete_options): Save the option values in the context.
 717         (save_option_value_in_ctx): New, factored out from ...
 718         (process_options): ... here.
 719         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 720         of the function.
 721         * maint-test-options.c (test_options_opts::dump): New, factored
 722         out from ...
 723         (maintenance_test_options_command_mode): ... here.
 724         (maintenance_test_options_command_completion_result): Delete.
 725         (maintenance_test_options_command_completion_text): Update
 726         comment.
 727         (maintenance_show_test_options_completion_result): Change
 728         prototype.  Just print
 729         maintenance_test_options_command_completion_text.
 730         (save_completion_result): New.
 731         (maintenance_test_options_completer_mode): Pass options context to
 732         complete_options, and then save a dump.
 733         (_initialize_maint_test_options): Use add_cmd to install "maint
 734         show test-options-completion-result".
 735
 736 2019-07-03  Pedro Alves  <palves@redhat.com>
 737
 738         * NEWS (New commands): Mention "with" and "maint with".
 739         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 740         (with_command, with_command_completer): New.
 741         (pipe_command): Adjust to new repeat_previous
 742         interface.
 743         (_initialize_cli_cmds): Install the "with" command and its "w"
 744         alias.
 745         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 746         declarations.
 747         * cli/cli-setshow.c (parse_cli_var_uinteger)
 748         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 749         argument strings for all var_types.
 750         (get_setshow_command_value_string): New, factored out from ...
 751         (do_show_command): ... this.
 752         * cli/cli-setshow.h: Include <string>.
 753         (get_setshow_command_value_string): Declare.
 754         * command.h (repeat_previous): Now returns const char *.  Adjust
 755         comment.
 756         * maint.c: Include "cli/cli-cmds.h".
 757         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 758         (_initialize_maint_cmds): Register the "maintenance with" command.
 759         * top.c (repeat_previous): Move bits from pipe_command here:
 760         Return the saved command line, if any; error out if there's no
 761         command to relaunch.
 762
 763 2019-07-03  Pedro Alves  <palves@redhat.com>
 764
 765         * NEWS (New commands): Mention "maint set/show test-settings"
 766         instead of "maint test-settings".
 767         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 768         (maintenance_test_settings_set_list): Rename to ...
 769         (maintenance_set_test_settings_list): ... this.
 770         (maintenance_test_settings_show_list): Rename to  ...
 771         (maintenance_show_test_settings_list): ... this.
 772         (maintenance_test_settings_cmd): Delete.
 773         (maintenance_test_settings_set_cmd): ...
 774         (maintenance_set_test_settings_cmd): ... this.
 775         (maintenance_test_settings_show_cmd): ...
 776         (maintenance_show_test_settings_cmd): ... this.
 777         (maintenance_test_settings_show_value_cmd):
 778         (maintenance_show_test_settings_value_cmd): ... this.
 779         (_initialize_maint_test_settings): No longer install the "maint
 780         test-settings" prefix command.  Rename "maint test-settings set"
 781         to "maint set test-settings", and "maint test-settings show" to
 782         "maint show test-settings".  Adjust all subcommands.
 783
 784 2019-07-03  Pedro Alves  <palves@redhat.com>
 785
 786         * maint-test-settings.c: Fix file's intro comment.  Replace all
 787         references to "test-options" with references to "test-settings",
 788         in comments.
 789
 790 2019-07-03  Pedro Alves  <palves@redhat.com>
 791
 792         * maint-test-settings.c (maintenance_test_settings_xxx)
 793         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 794         New.
 795         (maintenance_test_settings_enums): Use them.
 796         (maintenance_test_settings_enum): Default to
 797         maintenance_test_settings_xxx.
 798         (_initialize_maint_test_settings): Initialize
 799         MAINTENANCE_TEST_SETTINGS_FILENAME.
 800
 801 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 802
 803         * breakpoint.h (remove_breakpoints_inf): Change return type to
 804         void, move function documentation here.
 805         * breakpoint.c (remove_breakpoints_inf): Change return type to
 806         void, move function documentation to header.
 807
 808 2019-07-02  Pedro Alves  <palves@redhat.com>
 809
 810         * NEWS (Completion improvements): Mention "info threads".
 811         * thread.c (struct info_threads_opts, info_threads_option_defs)
 812         (make_info_threads_options_def_group): New.
 813         (info_threads_command): Use gdb::option::process_options.
 814         (info_threads_command_completer): New.
 815         (_initialize_thread): Use gdb::option::build_help to build the
 816         help text for "info threads".
 817
 818 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 819
 820         * defs.h (generic_load): Move from here...
 821         * symfile.h (generic_load): ... to here.  Rename name parameter
 822         to args.
 823         * symfile.c (generic_load): Add comment.
 824
 825 2019-07-01  Tom Tromey  <tromey@adacore.com>
 826
 827         * dwarf2read.c
 828         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 829         declaration of without_params.  Fix formatting.
 830
 831 2019-07-01  Tom Tromey  <tromey@adacore.com>
 832
 833         * ada-exp.y (find_primitive_type): Update.
 834         * ada-lang.h (ada_lookup_symbol): Update.
 835         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 836         parameter.
 837         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 838
 839 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 840
 841         PR breakpoints/24541
 842         * gdbarch.c: Regenerate.
 843         * gdbarch.h: Regenerate.
 844         * gdbarch.sh: Add 'stap_adjust_register'.
 845         * i386-tdep.c: Include '<unordered_set>'.
 846         (i386_stap_adjust_register): New function.
 847         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 848         * stap-probe.c (stap_parse_register_operand): Call
 849         'gdbarch_stap_adjust_register'.
 850
 851 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 852
 853         PR python/24742
 854         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 855         * python/python.c (do_start_initialization): Use 'xmalloc'
 856         instead of 'PyMem_Malloc'.
 857
 858 2019-06-28  Tom Tromey  <tromey@adacore.com>
 859
 860         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 861         for Ada.
 862
 863 2019-06-27  Tom Tromey  <tromey@adacore.com>
 864
 865         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 866         objfile_key.
 867         (arm_find_mapping_symbol, arm_record_special_symbol)
 868         (_initialize_arm_tdep): Update.
 869         (arm_objfile_data_free): Remove.
 870
 871 2019-06-27  Tom Tromey  <tromey@adacore.com>
 872
 873         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 874         to cp_print_static_field.
 875
 876 2019-06-26  Tom Tromey  <tromey@adacore.com>
 877
 878         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 879         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 880         declare.
 881
 882 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 883
 884         * features/aarch64-core.c (create_feature_aarch64_core):
 885         Regenerate.
 886         * features/aarch64-core.xml: Add cpsr flags.
 887
 888 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 889
 890         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 891         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 892
 893 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 894
 895         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 896         field.
 897         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 898         use.
 899         (arm_record_special_symbol): Don't insert new symbol in sorted
 900         position, push it at the end.
 901
 902 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 903
 904         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 905         (arm_mapping_symbol_s): Remove.
 906         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 907         (arm_mapping_symbol_vec): New typedef.
 908         (struct arm_per_objfile): Add constructor.
 909         <section_maps>: Change type to
 910         std::unique_ptr<arm_mapping_symbol_vec[]>.
 911         (arm_compare_mapping_symbols): Remove.
 912         (arm_find_mapping_symbol): Adjust to section_maps type change.
 913         (arm_objfile_data_free): Call delete on arm_per_objfile.
 914         (arm_record_special_symbol): Adjust to section_maps type change.
 915         Allocate arm_per_objfile with new.
 916
 917 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 918
 919         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 920         with the command prefix.
 921
 922 2019-06-25  Tom Tromey  <tom@tromey.com>
 923
 924         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 925         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 926
 927 2019-06-25  Tom Tromey  <tom@tromey.com>
 928
 929         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 930         type.
 931         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 932         protected.
 933
 934 2019-06-25  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui-winsource.c
 937         (tui_source_window_base::set_is_exec_point_at): Add check against
 938         LOA_ADDRESS.
 939
 940 2019-06-25  Tom Tromey  <tom@tromey.com>
 941
 942         * tui/tui-source.c (tui_set_source_content): Don't check before
 943         xfree.
 944         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 945
 946 2019-06-25  Tom Tromey  <tom@tromey.com>
 947
 948         * tui/tui-winsource.h (tui_update_source_window_as_is)
 949         (tui_alloc_source_buffer, tui_line_is_displayed)
 950         (tui_addr_is_displayed): Change type of win_info.
 951         * tui/tui-winsource.c (tui_update_source_window_as_is)
 952         (tui_clear_source_content, tui_show_source_line)
 953         (tui_show_source_content, tui_source_window_base::refill)
 954         (tui_source_window_base::set_is_exec_point_at)
 955         (tui_source_window_base::set_is_exec_point_at)
 956         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 957         (tui_alloc_source_buffer, tui_line_is_displayed)
 958         (tui_addr_is_displayed): Change type of win_info.  Update.
 959         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 960         (tui_source_window_base::do_make_visible_with_new_height):
 961         Update.
 962         * tui/tui-source.c (tui_set_source_content)
 963         (tui_set_source_content_nil)
 964         (tui_source_window::do_scroll_vertical): Update.
 965         * tui/tui-layout.c (show_layout): Update.
 966         * tui/tui-disasm.c (tui_set_disassem_content)
 967         (tui_disasm_window::do_scroll_vertical): Update.
 968         * tui/tui-data.h (tui_win_content): Remove.
 969         (struct tui_gen_win_info) <content, content_size>: Remove.
 970         (struct tui_source_element): Add initializers and destructor.
 971         (union tui_which_element, struct tui_win_element): Remove.
 972         (struct tui_source_window_base) <content>: New field.
 973         (struct tui_data_window): Remove destructor.
 974         (tui_alloc_content, tui_free_win_content)
 975         (tui_free_all_source_wins_content): Don't declare.
 976         * tui/tui-data.c (tui_initialize_static_data): Update.
 977         (init_content_element, tui_alloc_content): Remove.
 978         (~tui_gen_win_info): Update.
 979         (~tui_data_window, tui_free_all_source_wins_content)
 980         (tui_free_win_content, free_content, free_content_elements):
 981         Remove.
 982
 983 2019-06-25  Tom Tromey  <tom@tromey.com>
 984
 985         * tui/tui-winsource.h (tui_clear_source_content)
 986         (tui_erase_source_content, tui_show_source_content): Change type
 987         of win_info.
 988         * tui/tui-winsource.c (tui_clear_source_content)
 989         (tui_erase_source_content, tui_show_source_content): Change type
 990         of win_info.
 991         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 992         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 993         win_info.
 994         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 995         win_info.
 996         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 997
 998 2019-06-25  Tom Tromey  <tom@tromey.com>
 999
1000         * tui/tui-winsource.c (tui_clear_source_content)
1001         (tui_source_window_base::set_is_exec_point_at): Update.
1002         * tui/tui-source.c (tui_set_source_content_nil): Update.
1003         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1004         a bool.
1005         * tui/tui-data.c (init_content_element): Update.
1006
1007 2019-06-25  Tom Tromey  <tom@tromey.com>
1008
1009         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1010         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1011         * tui/tui-layout.c (init_and_make_win): Update.
1012         * tui/tui.h (enum tui_win_type): Update.
1013         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1014         tui_win_is_auxillary.
1015         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1016         tui_win_is_auxillary.
1017
1018 2019-06-25  Tom Tromey  <tom@tromey.com>
1019
1020         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1021         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1022         (tui_delete_data_content_windows, tui_display_all_data)
1023         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1024         Update.
1025         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1026         * tui/tui-regs.c (tui_last_regs_line_no)
1027         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1028         (tui_show_registers): Update.
1029         (tui_show_register_group): Return void.  Update.
1030         (tui_display_registers_from, tui_display_reg_element_at_line)
1031         (tui_display_registers_from_line, tui_check_register_values):
1032         Update.
1033         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1034         member.
1035         (struct tui_data_window) <regs_content>: Now a std::vector.
1036         <regs_content_count>: Remove.
1037         (tui_add_content_elements, tui_free_data_content): Don't declare.
1038         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1039         (init_content_element): Remove DATA_WIN case.  Add assert.
1040         (tui_add_content_elements): Remove.
1041         (tui_data_window): Update.
1042         (tui_free_data_content): Remove.
1043         (free_content_elements): Remove DATA_WIN case.
1044
1045 2019-06-25  Tom Tromey  <tom@tromey.com>
1046
1047         * tui/tui-data.c (tui_data_item_window): Update.
1048         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1049         * tui/tui-windata.c (tui_display_all_data)
1050         (tui_display_data_from_line): Update.
1051         (tui_check_data_values): Remove.
1052         * tui/tui-regs.c (tui_show_register_group)
1053         (tui_display_reg_element_at_line): Update.
1054         * tui/tui-hooks.c (tui_register_changed)
1055         (tui_refresh_frame_and_register_information): Call
1056         tui_check_register_values.
1057         * tui/tui-data.h (struct tui_data_window) <data_content,
1058         data_content_count, data_type>: Remove.
1059         (enum tui_data_type): Remove.
1060
1061         * tui/tui-data.c (tui_data_window::clear_detail)
1062         (~tui_data_window): Update.
1063
1064 2019-06-25  Tom Tromey  <tom@tromey.com>
1065
1066         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1067         declare.
1068         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1069         Rename from tui_first_data_item_displayed.  Update.
1070         (tui_data_window::refresh_all)
1071         (tui_data_window::do_scroll_vertical): Update.
1072         * tui/tui-data.h (struct tui_data_window)
1073         <first_data_item_displayed>: Declare new method.
1074
1075 2019-06-25  Tom Tromey  <tom@tromey.com>
1076
1077         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1078         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1079         contents...
1080         (tui_initialize_static_data): ...here.
1081
1082 2019-06-25  Tom Tromey  <tom@tromey.com>
1083
1084         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1085         (tui_display_registers_from, tui_check_register_values): Update.
1086         (tui_display_register): Remove win_info parameter; update.
1087         (tui_get_register): Change type of parameters.
1088         * tui/tui-data.h (struct tui_data_element): Remove.
1089         (union tui_which_element) <data>: Remove.
1090         <data_window>: Change type.
1091         (struct tui_data_item_window): New.
1092         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1093         case.  Add assert.
1094         (~tui_data_item_window): New destructor.
1095         (free_content_elements): Remove DATA_ITEM_WIN case.
1096
1097 2019-06-25  Tom Tromey  <tom@tromey.com>
1098
1099         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1100         Remove.
1101
1102 2019-06-25  Tom Tromey  <tom@tromey.com>
1103
1104         * tui/tui-data.h (struct tui_command_element): Remove.
1105         (union tui_which_element) <command>: Remove.
1106         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1107         assert.
1108         (free_content_elements): Remove CMD_WIN case.
1109
1110 2019-06-25  Tom Tromey  <tom@tromey.com>
1111
1112         * tui/tui-layout.c (tui_set_layout): Update.
1113         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1114         * tui/tui-data.c (layout_def): Update.
1115
1116 2019-06-25  Tom Tromey  <tom@tromey.com>
1117
1118         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1119         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1120         (tui_source_window_base::set_new_height): Update.
1121         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1122         Update.
1123         (tui_set_locator_fullname, tui_set_locator_info)
1124         (tui_show_frame_info): Update.
1125         * tui/tui-source.c (tui_set_source_content)
1126         (tui_source_is_displayed): Update.
1127         * tui/tui-layout.c (show_source_disasm_command, show_data)
1128         (show_source_or_disasm_and_command): Update.
1129         * tui/tui-disasm.c (tui_set_disassem_content)
1130         (tui_get_begin_asm_address): Update.
1131         * tui/tui-data.h (struct tui_locator_element): Remove.
1132         (union tui_which_element) <locator>: Remove.
1133         (struct tui_locator_window): New.
1134         (tui_locator_win_info_ptr): Change return type.
1135         * tui/tui-data.c (_locator): Change type.
1136         (tui_locator_win_info_ptr): Change return type.
1137         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1138         (tui_alloc_content): Add assert.
1139
1140 2019-06-25  Tom Tromey  <tom@tromey.com>
1141
1142         * tui/tui-winsource.c
1143         (tui_exec_info_window::maybe_allocate_content): New method.
1144         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1145         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1146         (make_source_or_disasm_window): Add cast.
1147         * tui/tui-data.h (union tui_which_element) <simple_string>:
1148         Remove.
1149         (struct tui_source_info): New.
1150         (struct tui_source_window_base) <execution_info>: Change type.
1151         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1152         case, and add assert.
1153         (tui_alloc_content): Add assert.
1154
1155 2019-06-25  Tom Tromey  <tom@tromey.com>
1156
1157         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1158         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1159         * tui/tui-data.c (tui_alloc_win_info): Remove.
1160
1161 2019-06-25  Tom Tromey  <tom@tromey.com>
1162
1163         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1164         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1165         can_highlight.
1166
1167 2019-06-25  Tom Tromey  <tom@tromey.com>
1168
1169         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1170         make_visible_with_new_height method.
1171         (tui_win_info::make_visible_with_new_height): New method.
1172         (tui_source_window_base::do_make_visible_with_new_height)
1173         (tui_data_window::do_make_visible_with_new_height)
1174         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1175         (make_visible_with_new_height): Remove.
1176         (tui_resize_all, tui_adjust_win_heights): Use
1177         make_visible_with_new_height method.
1178         * tui/tui-data.h (struct tui_win_info)
1179         <do_make_visible_with_new_height, make_visible_with_new_height>:
1180         New methods.
1181         (struct tui_source_window_base, struct tui_data_window)
1182         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1183         methods.
1184
1185 2019-06-25  Tom Tromey  <tom@tromey.com>
1186
1187         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1188         method.
1189         (update_tab_width): Call update_tab_width method.
1190         * tui/tui-data.h (struct tui_win_info)
1191         (struct tui_source_window_base) <update_tab_width>: New methods.
1192
1193 2019-06-25  Tom Tromey  <tom@tromey.com>
1194
1195         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1196         parameter.
1197         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1198         parameter.
1199         (tui_gen_win_info::make_visible): Update.
1200         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1201         parameter.
1202         * tui/tui-data.h (enum tui_box): New enum.
1203         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1204
1205 2019-06-25  Tom Tromey  <tom@tromey.com>
1206
1207         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1208         init_and_make_win for EXEC_INFO_WIN.
1209         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1210         longer inline.
1211         (struct tui_win_info) <~tui_win_info>: Inline.
1212         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1213         Don't declare.
1214         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1215         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1216         Remove.
1217         (tui_initialize_static_data): Update.
1218         (~tui_gen_win_info): Handle more cleanup here.
1219         (~tui_source_window_base): Delete "execution_info".
1220         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1221
1222 2019-06-25  Tom Tromey  <tom@tromey.com>
1223
1224         * tui/tui-layout.c (make_command_window): Don't set
1225         can_highlight.
1226         (show_source_disasm_command): Call the reset method.
1227         (show_data): Don't set can_highlight.  Call the reset method.
1228         (tui_gen_win_info::reset): Rename from init_gen_win_info
1229         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1230         (show_source_or_disasm_and_command): Call the reset method.
1231         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1232         (struct tui_cmd_window): Set can_highlight.
1233
1234 2019-06-25  Tom Tromey  <tom@tromey.com>
1235
1236         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1237         from make_visible.
1238         (tui_make_visible, tui_make_invisible): Rewrite.
1239         (tui_win_info::make_visible): Remove.
1240         (tui_source_window_base::make_visible): Update.
1241         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1242         method.  Moved from...
1243         (struct tui_win_info) <make_visible>: ...here.
1244
1245 2019-06-25  Tom Tromey  <tom@tromey.com>
1246
1247         * tui/tui-winsource.c
1248         (tui_source_window_base::do_scroll_horizontal): Remove direction
1249         parameter.
1250         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1251         direction parameter.
1252         * tui/tui-win.c (tui_win_info::forward_scroll)
1253         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1254         (tui_win_info::right_scroll): Update.
1255         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1256         direction parameter.
1257         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1258         direction parameter.
1259         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1260         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1261         Remove direction parameter.
1262         (struct tui_source_window_base, struct tui_source_window)
1263         (struct tui_disasm_window, struct tui_data_window)
1264         (struct tui_cmd_window): Update.
1265
1266 2019-06-25  Tom Tromey  <tom@tromey.com>
1267
1268         * tui/tui-winsource.h (tui_set_exec_info_content)
1269         (tui_show_exec_info_content, tui_erase_exec_info_content)
1270         (tui_clear_exec_info_content, tui_update_exec_info): Change
1271         argument to tui_source_window_base.
1272         * tui/tui-winsource.c (tui_set_exec_info_content)
1273         (tui_show_exec_info_content, tui_erase_exec_info_content)
1274         (tui_clear_exec_info_content, tui_update_exec_info): Change
1275         argument to tui_source_window_base.
1276
1277 2019-06-25  Tom Tromey  <tom@tromey.com>
1278
1279         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1280         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1281
1282 2019-06-25  Tom Tromey  <tom@tromey.com>
1283
1284         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1285         check.
1286
1287 2019-06-25  Tom Tromey  <tom@tromey.com>
1288
1289         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1290         type to void.
1291         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1292         type to void.
1293         * tui/tui-source.c (tui_set_source_content): Update.
1294         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1295
1296 2019-06-25  Tom Tromey  <tom@tromey.com>
1297
1298         * tui/tui-win.c (window_name_completer, tui_set_focus)
1299         (tui_all_windows_info): Use name method.
1300         * tui/tui-data.h (struct tui_gen_win_info)
1301         (struct tui_source_window, struct tui_disasm_window)
1302         (struct tui_data_window, struct tui_cmd_window) <name>: New
1303         method.
1304         (tui_win_name): Don't declare.
1305         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1306         (tui_win_name): Remove.
1307
1308 2019-06-25  Tom Tromey  <tom@tromey.com>
1309
1310         * tui/tui-winsource.h (tui_update_source_window)
1311         (tui_update_source_window_as_is): Change parameter type.
1312         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1313         to be a tui_source_window_base.
1314         (tui_update_source_window_as_is): Likewise.
1315         * tui/tui-win.c (make_visible_with_new_height): Update.
1316
1317 2019-06-25  Tom Tromey  <tom@tromey.com>
1318
1319         * tui/tui-winsource.c (tui_erase_source_content)
1320         (tui_show_source_content, tui_show_exec_info_content)
1321         (tui_erase_exec_info_content): Use refresh_window method.
1322         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1323         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1324         from tui_refresh_win.
1325         (tui_data_window::refresh_window): New method.
1326         (tui_win_info::refresh, tui_source_window_base::refresh)
1327         (tui_refresh_all): Use refresh_window method.
1328         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1329         method.
1330         * tui/tui-regs.c (tui_display_register): Call refresh_window
1331         method.
1332         * tui/tui-layout.c (show_source_disasm_command)
1333         (show_source_or_disasm_and_command): Call refresh_window method.
1334         * tui/tui-data.h (struct tui_gen_win_info)
1335         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1336         New method.
1337
1338 2019-06-25  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui.c (tui_rl_other_window, tui_enable)
1341         (tui_is_window_visible, tui_get_command_dimension): Update.
1342         * tui/tui-winsource.c (tui_update_source_window_as_is)
1343         (tui_clear_source_content, tui_erase_source_content)
1344         (tui_show_source_line, tui_source_window_base::refill)
1345         (tui_source_window_base::do_scroll_horizontal)
1346         (tui_source_window_base::set_is_exec_point_at)
1347         (tui_update_breakpoint_info, tui_set_exec_info_content)
1348         (tui_alloc_source_buffer, tui_line_is_displayed)
1349         (tui_addr_is_displayed): Update.
1350         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1351         (tui_check_and_display_highlight_if_needed)
1352         (tui_win_info::make_visible, tui_win_info::refresh)
1353         (tui_refresh_all): Update.
1354         * tui/tui-windata.c (tui_first_data_item_displayed)
1355         (tui_delete_data_content_windows, tui_erase_data_content)
1356         (tui_display_all_data, tui_data_window::refresh_all)
1357         (tui_check_data_values): Update.
1358         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1359         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1360         (tui_win_info::backward_scroll, tui_refresh_all_win)
1361         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1362         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1363         (tui_source_window_base::set_new_height)
1364         (tui_data_window::set_new_height)
1365         (make_invisible_and_set_new_height)
1366         (make_visible_with_new_height, new_height_ok)
1367         (parse_scrolling_args): Update.
1368         * tui/tui-stack.c (tui_show_frame_info): Update.
1369         * tui/tui-source.c (tui_set_source_content)
1370         (tui_set_source_content_nil, tui_source_is_displayed)
1371         (tui_source_window::do_scroll_vertical): Update.
1372         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1373         (tui_display_registers_from, tui_display_reg_element_at_line)
1374         (tui_check_register_values, tui_reg_command): Update.
1375         * tui/tui-layout.c (tui_default_win_height)
1376         (show_source_disasm_command, show_data, init_and_make_win)
1377         (show_source_or_disasm_and_command): Update.
1378         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1379         (tui_redisplay_readline, tui_mld_flush)
1380         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1381         (tui_getc): Update.
1382         * tui/tui-disasm.c (tui_set_disassem_content)
1383         (tui_disasm_window::do_scroll_vertical): Update.
1384         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1385         Now virtual.
1386         (struct tui_win_info): Derive from tui_gen_win_info.
1387         <~tui_win_info>: Mark as override.
1388         <generic>: Remove member.
1389         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1390         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1391         (~tui_data_window, ~tui_win_info)
1392         (tui_free_all_source_wins_content): Update.
1393         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1394
1395 2019-06-25  Tom Tromey  <tom@tromey.com>
1396
1397         * tui/tui-layout.c (init_and_make_win): Use new.
1398         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1399         destructor, initializers.
1400         (tui_alloc_generic_win_info): Don't declare.
1401         * tui/tui-data.c (_locator): Add argument to constructor.
1402         (source_win, disasm_win): New globals.
1403         (exec_info): Remove.
1404         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1405         Update.
1406         (tui_alloc_generic_win_info): Remove.
1407         (init_content_element): Use new.
1408         (tui_win_info::tui_win_info): Update.
1409         (free_content_elements) <case DATA_WIN>: Use delete.
1410
1411 2019-06-25  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1414         * tui/tui-windata.c (tui_first_data_item_displayed)
1415         (tui_delete_data_content_windows): Update.
1416         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1417         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1418         (tui_display_registers_from, tui_check_register_values): Update.
1419         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1420         pointer.
1421         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1422         window.
1423         (tui_free_data_content): Update.
1424         (free_content_elements) <case DATA_WIN>: Free the window.
1425
1426 2019-06-25  Tom Tromey  <tom@tromey.com>
1427
1428         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1429         Update.
1430         * tui/tui-layout.c (make_command_window)
1431         (show_source_disasm_command, show_data, init_and_make_win)
1432         (show_source_or_disasm_and_command): Update.
1433         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1434         method.
1435         <can_highight, is_highlighted>: Now bool.
1436         (tui_set_win_highlight): Don't declare.
1437         * tui/tui-data.c (tui_set_win_highlight): Remove.
1438
1439 2019-06-25  Tom Tromey  <tom@tromey.com>
1440
1441         * tui/tui-wingeneral.c (make_visible): Remove check of window
1442         type.
1443
1444 2019-06-25  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-win.c (tui_win_info::max_height)
1447         (tui_cmd_window::max_height): New methods.
1448         (new_height_ok): Call max_height.
1449         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1450         <max_height>: New method.
1451
1452 2019-06-25  Tom Tromey  <tom@tromey.com>
1453
1454         * tui/tui-win.c (tui_source_window_base::set_new_height)
1455         (tui_data_window::set_new_height): New methods.
1456         (make_invisible_and_set_new_height): Call set_new_height method.
1457         * tui/tui-data.h (struct tui_win_info)
1458         (struct tui_source_window_base, struct tui_data_window)
1459         <set_new_height>: New method.
1460
1461 2019-06-25  Tom Tromey  <tom@tromey.com>
1462
1463         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1464         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1465         tui_refresh_data_win.
1466         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1467         method.
1468         (tui_refresh_all_win): Call the refresh_all method.
1469         (tui_set_focus): Likewise.
1470         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1471         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1472         Likewise.
1473
1474 2019-06-25  Tom Tromey  <tom@tromey.com>
1475
1476         * tui/tui-winsource.h (tui_refill_source_window)
1477         (tui_set_is_exec_point_at): Don't declare.
1478         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1479         (tui_source_window_base::refill): Rename from
1480         tui_refill_source_window.
1481         (tui_source_window_base::do_scroll_horizontal): Update.
1482         (tui_source_window_base::set_is_exec_point_at): Rename from
1483         tui_set_is_exec_point_at.
1484         (tui_update_all_breakpoint_info): Update.
1485         * tui/tui-stack.c (tui_show_frame_info): Update.
1486         * tui/tui-layout.c (show_data): Add cast.
1487         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1488         * tui/tui-data.h (struct tui_source_window_base) <refill,
1489         set_is_exec_point_at>: New methods.
1490         (tui_source_windows, tui_add_to_source_windows): Update types.
1491         (tui_add_to_source_windows): Remove redundant declaration.
1492         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1493         (tui_source_windows): Change return type.
1494         (tui_clear_source_windows_detail): Update.
1495         (tui_add_to_source_windows): Change type of parameter.
1496         (tui_free_all_source_wins_content): Update.
1497
1498 2019-06-25  Tom Tromey  <tom@tromey.com>
1499
1500         * tui/tui-wingeneral.c (tui_win_info::refresh)
1501         (tui_source_window_base::refresh): New methods.
1502         (tui_refresh_all): Call the refresh method.
1503         * tui/tui-data.h (struct tui_win_info)
1504         (struct tui_source_window_base) <refresh>: New method.
1505
1506 2019-06-25  Tom Tromey  <tom@tromey.com>
1507
1508         * tui/tui.h (tui_is_window_visible): Return bool.
1509         * tui/tui.c (tui_is_window_visible): Return bool.
1510         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1511         (tui_make_visible, tui_make_invisible)
1512         (tui_win_info::make_visible)
1513         (tui_source_window_base::make_visible, make_all_visible)
1514         (tui_make_all_visible, tui_make_all_invisible): Update.
1515         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1516         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1517         bool.
1518         (struct tui_win_info, struct tui_source_window_base)
1519         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1520         * tui/tui-data.c (tui_init_generic_part): Update.
1521
1522 2019-06-25  Tom Tromey  <tom@tromey.com>
1523
1524         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1525         (tui_source_window_base::make_visible): New methods.
1526         (make_all_visible): Make method call.
1527         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1528         (struct tui_source_window_base, struct tui_cmd_window): Override
1529         make_visible.
1530         (tui_win_is_source_type): Don't declare.
1531         * tui/tui-data.c (tui_win_is_source_type): Remove.
1532
1533 2019-06-25  Tom Tromey  <tom@tromey.com>
1534
1535         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1536         NULL check.
1537
1538 2019-06-25  Tom Tromey  <tom@tromey.com>
1539
1540         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1541         Inline constructor.  Add initializers for members.
1542         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1543         constructors; now inline in class.
1544
1545 2019-06-25  Tom Tromey  <tom@tromey.com>
1546
1547         * tui/tui-regs.c (tui_show_registers): Update.
1548         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1549         bool.
1550         * tui/tui-data.c (tui_data_window::clear_detail)
1551         (tui_data_window): Update.
1552
1553 2019-06-25  Tom Tromey  <tom@tromey.com>
1554
1555         * tui/tui-windata.c (tui_display_all_data)
1556         (tui_display_data_from_line, tui_display_data_from)
1557         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1558         Update.
1559         * tui/tui-regs.c (tui_last_regs_line_no)
1560         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1561         (tui_show_registers, tui_show_register_group)
1562         (tui_display_registers_from, tui_display_reg_element_at_line)
1563         (tui_display_registers_from_line, tui_check_register_values)
1564         (tui_reg_next, tui_reg_prev): Update.
1565         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1566         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1567         tui_data_window.
1568         (struct tui_win_info) <detail>: Remove.  Add new fields from
1569         tui_data_info.
1570         (TUI_DATA_WIN): Add cast.
1571         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1572         (~tui_data_window): Simplify.
1573
1574 2019-06-25  Tom Tromey  <tom@tromey.com>
1575
1576         * tui/tui-layout.c (show_source_disasm_command)
1577         (show_source_or_disasm_and_command): Update.
1578         * tui/tui-io.c (update_cmdwin_start_line)
1579         (tui_redisplay_readline): Update.
1580         * tui/tui-data.h (struct tui_command_info): Remove.
1581         (struct tui_win_info) <detail>: Remove command_info member.
1582         (struct tui_data_window) <start_line>: New member, from
1583         tui_command_info.
1584         (TUI_CMD_WIN): Add casts.
1585
1586 2019-06-25  Tom Tromey  <tom@tromey.com>
1587
1588         * tui/tui-winsource.c (tui_update_source_window)
1589         (tui_refill_source_window)
1590         (tui_source_window_base::do_scroll_horizontal)
1591         (tui_update_breakpoint_info, tui_set_exec_info_content)
1592         (tui_show_exec_info_content, tui_erase_exec_info_content)
1593         (tui_clear_exec_info_content): Update.
1594         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1595         Update.
1596         * tui/tui-win.c (make_invisible_and_set_new_height)
1597         (make_visible_with_new_height): Update.
1598         * tui/tui-source.c (tui_set_source_content)
1599         (tui_show_symtab_source): Update.
1600         * tui/tui-layout.c (extract_display_start_addr)
1601         (show_source_disasm_command, show_data)
1602         (make_source_or_disasm_window)
1603         (show_source_or_disasm_and_command): Update.
1604         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1605         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1606         "gdbarch".
1607         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1608         to tui_source_window_base.
1609         (struct tui_win_info) <detail>: Remove source_info member.
1610         (struct tui_source_window_base) <has_locator>: Inline.
1611         Move contents from tui_source_info; rename has_locator member to
1612         m_has_locator.
1613         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1614         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1615         header file.
1616         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1617         Simplify.
1618         (tui_free_all_source_wins_content): Cast to
1619         tui_source_window_base.
1620
1621 2019-06-25  Tom Tromey  <tom@tromey.com>
1622
1623         * tui/tui-win.c (make_invisible_and_set_new_height)
1624         (make_visible_with_new_height): Call has_locator method.
1625         * tui/tui-layout.c (show_source_disasm_command, show_data)
1626         (show_source_or_disasm_and_command): Update for bool change.
1627         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1628         (tui_win_info) <has_locator>: New method.
1629         (struct tui_source_window_base) <has_locator>: New method.
1630         (tui_win_has_locator): Don't declare.
1631         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1632         from tui_win_has_locator.
1633         (tui_source_window_base): Use false, not FALSE.
1634
1635 2019-06-25  Tom Tromey  <tom@tromey.com>
1636
1637         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1638         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1639         clear_detail method directly.
1640         (tui_clear_win_detail): Remove.
1641
1642 2019-06-25  Tom Tromey  <tom@tromey.com>
1643
1644         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1645         "this", not TUI_DISASM_WIN.
1646
1647 2019-06-25  Tom Tromey  <tom@tromey.com>
1648
1649         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1650         declare.
1651         * tui/tui-winsource.c
1652         (tui_source_window_base::do_scroll_horizontal): Rename from
1653         tui_horizontal_source_scroll.
1654         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1655         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1656         from tui_vertical_data_scroll.
1657         * tui/tui-win.h (tui_scroll): Don't declare.
1658         * tui/tui-win.c (tui_win_info::forward_scroll)
1659         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1660         (tui_win_info::right_scroll): Rename and update.
1661         (tui_scroll_forward_command, tui_scroll_backward_command)
1662         (tui_scroll_left_command, tui_scroll_right_command): Update.
1663         (tui_scroll): Remove.
1664         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1665         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1666         from tui_vertical_source_scroll.
1667         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1668         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1669         from tui_vertical_disassem_scroll.
1670         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1671         do_scroll_horizontal>: New methods.
1672         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1673         Likewise.
1674         (struct tui_source_window_base): Add do_scroll_horizontal.
1675         (struct tui_source_window, struct tui_disasm_window): Add
1676         do_scroll_vertical.
1677         (struct tui_data_window, struct tui_cmd_window): Add
1678         do_scroll_horizontal and do_scroll_vertical.
1679         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1680
1681 2019-06-25  Tom Tromey  <tom@tromey.com>
1682
1683         * tui/tui-data.h (struct tui_source_window_base): New struct.
1684         (struct tui_source_window): Derive from tui_source_window_base.
1685         (struct tui_disasm_window): New struct.
1686         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1687         from tui_source_window::clear_detail.
1688         (tui_source_window_base): Rename from tui_source_window.
1689         (~tui_source_window_base): Rename from ~tui_source_window.
1690         (tui_alloc_win_info): Create a tui_disasm_window.
1691
1692 2019-06-25  Tom Tromey  <tom@tromey.com>
1693
1694         * tui/tui-data.h (struct tui_source_window)
1695         (struct tui_data_window): Declare destructors.
1696         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1697         destructors.
1698         (tui_win_info): Simplify.
1699
1700 2019-06-25  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-winsource.c (tui_display_main)
1703         (tui_update_source_windows_with_addr)
1704         (tui_update_all_breakpoint_info): Update.
1705         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1706         (new_height_ok, parse_scrolling_args): Update.
1707         * tui/tui-stack.c (tui_show_frame_info): Update.
1708         * tui/tui-data.h (struct tui_list): Remove.
1709         (tui_source_windows): Return a reference to a std::vector.
1710         * tui/tui-data.c (source_windows): Now a std::vector.
1711         (tui_source_windows): Change return type.
1712         (tui_clear_source_windows): Rewrite.
1713         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1714         (tui_free_all_source_wins_content): Rewrite.
1715
1716 2019-06-25  Tom Tromey  <tom@tromey.com>
1717
1718         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1719         (struct tui_data_window, struct tui_cmd_window): Declare
1720         clear_detail method.
1721         * tui/tui-data.c (tui_source_window::clear_detail)
1722         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1723         methods.
1724         (tui_clear_win_detail): Simplify.
1725
1726 2019-06-25  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-layout.c (make_source_window, make_disasm_window)
1729         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1730         Return the new window.
1731         (show_source_disasm_command, show_data)
1732         (show_source_or_disasm_and_command): Update.
1733
1734 2019-06-25  Tom Tromey  <tom@tromey.com>
1735
1736         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1737         parameter.  Return the new window.
1738         (show_source_disasm_command): Update and remove NULL check.
1739         (show_source_or_disasm_and_command): Update.
1740
1741 2019-06-25  Tom Tromey  <tom@tromey.com>
1742
1743         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1744
1745 2019-06-25  Tom Tromey  <tom@tromey.com>
1746
1747         * tui/tui-data.h (struct tui_win_info): Make constructor
1748         protected.  Make destructor virtual.  Add initializers.
1749         (tui_source_window, tui_data_window, tui_cmd_window): New
1750         classes.
1751         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1752         constructor.  Add "type" parameter.
1753         (tui_source_window, tui_data_window, tui_cmd_window): New
1754         constructors.
1755         (tui_alloc_win_info): Instantiate the appropriate subclass.
1756
1757 2019-06-25  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-win.c (tui_resize_all): Use delete.
1760         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1761         destructor.
1762         (tui_free_window): Don't declare.
1763         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1764         Update.
1765
1766 2019-06-25  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-data.h (struct tui_win_info): Add constructor.
1769         * tui/tui-data.c (tui_alloc_win_info): Use new.
1770         (tui_free_window): Use delete.
1771
1772 2019-06-22  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1775         declare.
1776         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1777
1778 2019-06-22  Tom Tromey  <tom@tromey.com>
1779
1780         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1781         declare.
1782         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1783
1784 2019-06-22  Tom de Vries  <tdevries@suse.de>
1785
1786         * dwarf2read.c (create_addrmap_from_aranges)
1787         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1788         instead of '%zu'.
1789
1790 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1791
1792         * dwarf2read.h (dwarf2_section_info_def): Remove.
1793         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1794         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1795         std::vector<dwarf2_section_info>.
1796         (struct dwo_file) <~dwo_file>: Remove.
1797         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1798         types field.
1799         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1800         (dwarf2_read_debug_names): Likewise.
1801         (create_debug_types_hash_table): Change parameter type to
1802         array_view, adjust code accordingly.
1803         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1804         (partial_die_info::fixup): Likewise.
1805         (determine_prefix): Likewise.
1806         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1807
1808 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1809
1810         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1811         gdb_bfd_ref_ptr.
1812         <~dwo_file>: Remove call to gdb_bfd_unref.
1813         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1814         gdb_bfd_ref_ptr::get.
1815
1816 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1817
1818         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1819         type to htab_up.
1820         * dwarf2read.c (struct dwo_file): Initialize fields.
1821         <~dwo_file>: New.
1822         (free_dwo_file): Remove, move content to ~dwo_file.
1823         (struct dwo_file_deleter): Remove.
1824         (dwo_file_up>: Remove custom deleter.
1825         (free_dwo_files): Remove.
1826         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1827         dwo_files.
1828         (process_skeletonless_type_units): Call unique_ptr::get.
1829         (allocate_dwo_file_hash_table): Add deleter to created hash
1830         table.  Change return type to htab_up.
1831         (lookup_dwo_file_slot): Don't memset dwo_file, call
1832         unique_ptr::get.
1833         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1834         (create_dwo_unit_in_dwp_v2): Likewise.
1835         (open_and_init_dwo_file): Likewise.
1836         (free_dwo_file_from_slot): Remove.
1837
1838 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1839
1840         * dwarf2read.h (struct dwarf2_section_info) <readin,
1841         is_virtual>: Change type to bool.
1842         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1843         true instead of 1.
1844
1845 2019-06-19  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-data.h (tui_init_content_element): Don't declare.
1848
1849 2019-06-19  Tom Tromey  <tom@tromey.com>
1850
1851         * tui/tui-data.h (tui_init_win_info): Don't declare.
1852
1853 2019-06-19  Tom de Vries  <tdevries@suse.de>
1854
1855         * dwarf2read.h (abstract_to_concrete): Change type to
1856         std::unordered_map<sect_offset, std::vector<sect_offset>,
1857         gdb::hash_enum<sect_offset>>.
1858
1859 2019-06-19  Tom Tromey  <tromey@adacore.com>
1860
1861         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1862         EVAL_AVOID_SIDE_EFFECTS specially.
1863
1864 2019-06-19  Tom Tromey  <tromey@adacore.com>
1865
1866         * source-cache.c (highlighter): New global.
1867         (source_cache::get_source_lines): Create a highlighter on demand.
1868
1869 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1870
1871         * defs.h (deprecated_interactive_hook): Delete declaration.
1872         * interps.c (clear_interpreter_hooks): Remove use of
1873         deprecated_interactive_hook.
1874         * top.c (deprecated_interactive_hook): Delete definition.
1875         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1876
1877 2019-06-18  Tom de Vries  <tdevries@suse.de>
1878
1879         PR gdb/24515
1880         * dwarf2read.h (abstract_to_concrete): Change type from
1881         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1882         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1883         * dwarf2read.c (read_variable): Update.
1884         (dwarf2_fetch_die_loc_sect_off): Update.
1885
1886 2019-06-17  Tom de Vries  <tdevries@suse.de>
1887
1888         PR gdb/24617
1889         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1890         accessing parent[parent_len - 1].
1891
1892 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1893
1894         PR gdb/24364
1895         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1896         call dtrace_process_dof with NULL dof.
1897
1898 2019-06-16  Tom de Vries  <tdevries@suse.de>
1899
1900         PR gdb/24445
1901         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1902
1903 2019-06-16  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1906         (make_all_visible): Use address of member.
1907
1908 2019-06-16  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1911         (tui_free_window, free_content, free_content_elements): Remove
1912         unnecessary cast.
1913         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1914         cast.
1915         * tui/tui-regs.c (tui_show_register_group)
1916         (tui_display_registers_from, tui_display_reg_element_at_line):
1917         Remove unnecessary cast.
1918
1919 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1920
1921         * linux-nat.c (normal_mask): Delete.
1922         (_initialize_linux_nat): Don't initialise normal_mask.
1923
1924 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1925
1926         PR gdb/24445
1927         * dwarf-index-write.h (write_psymtabs_to_index): Add
1928         dwz_basename parameter.
1929         * dwarf-index-write.c (write_gdbindex): Move file writing to
1930         write_gdbindex_1.  Change return type void.
1931         (assert_file_size): Move up, remove filename parameter.
1932         (write_gdbindex_1): New function.
1933         (write_debug_names): Change return type to void, call
1934         assert_file_size.
1935         (struct index_wip_file): New struct.
1936         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1937         file logic to index_wip_file.  Write index for dwz file if
1938         needed.
1939         (save_gdb_index_command): Pass basename of dwz file, if present.
1940         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1941         build-id of dwz file, if present.
1942         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1943         (dwarf2_get_dwz_file): Likewise.
1944         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1945         (dwarf2_get_dwz_file): Likewise.
1946
1947 2019-06-16  Tom Tromey  <tom@tromey.com>
1948
1949         * coffread.c (process_coff_symbol): Use xstrdup.
1950         * value.c (create_internalvar): Use xstrdup.
1951
1952 2019-06-16  Tom Tromey  <tom@tromey.com>
1953
1954         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1955         * breakpoint.c (stopin_command, stopat_command)
1956         (until_break_command, decode_location_default): Remove unnecessary
1957         cast.
1958         * utils.c (subset_compare): Remove unnecessary cast.
1959         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1960         cast.
1961         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1962         cast.
1963         * infcmd.c (path_command): Remove unnecessary cast.
1964         * coffread.c (decode_type): Remove unnecessary cast.
1965         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1966         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1967         * tui/tui-stack.c (tui_show_locator_content)
1968         (tui_show_frame_info): Remove unnecessary cast.
1969         * tui/tui-win.c (tui_scroll_forward_command)
1970         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1971         (parse_scrolling_args): Remove unnecessary cast.
1972         * tui/tui-data.c (init_win_info, tui_del_window)
1973         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1974         (free_content_elements): Remove unnecessary cast.
1975         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1976         unnecessary cast.
1977         * tui/tui-source.c (tui_set_source_content)
1978         (tui_vertical_source_scroll): Remove unnecessary cast.
1979         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1980         cast.
1981         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1982         * tui/tui-regs.c (tui_display_registers_from)
1983         (tui_display_register): Remove unnecessary cast.
1984         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1985         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1986         (make_visible): Remove unnecessary cast.
1987         * tui/tui-winsource.c (tui_erase_source_content)
1988         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1989         unnecessary cast.
1990         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1991         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1992         * stabsread.c (read_type, read_array_type, read_range_type):
1993         Remove unnecessary cast.
1994         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1995         (parse_symbol, parse_type, upgrade_type, parse_external)
1996         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1997         unnecessary cast.
1998         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1999
2000 2019-06-16  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-data.c (tui_alloc_generic_win_info)
2003         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2004         checks.
2005
2006 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2007             Andrew Burgess  <andrew.burgess@embecosm.com>
2008
2009         * f-typeprint.c (f_print_type): Don't return early for not
2010         associated or not allocated types.
2011         (f_type_print_varspec_suffix): Add print_rank parameter and print
2012         ranks of array types in case they dangling.
2013         (f_type_print_base): Add print_rank parameter.
2014
2015 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2016
2017         * NEWS: Mention new MI commands.
2018         * break-catch-throw.c (enum exception_event_kind): Move to
2019         breakpoint.h.
2020         (print_mention_exception_catchpoint): Output text as a single
2021         message.
2022         (catch_exception_command_1): Rename to...
2023         (catch_exception_event): ...this, make non-static, update header
2024         command, and change some parameter types.
2025         (catch_catch_command): Update for changes to
2026         catch_exception_command_1.
2027         (catch_throw_command): Likewise.
2028         (catch_rethrow_command): Likewise.
2029         * breakpoint.c (enum exception_event_kind): Delete.
2030         * breakpoint.h (enum exception_event_kind): Moved here from
2031         break-catch-throw.c.
2032         (catch_exception_event): Declare.
2033         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2034         (mi_cmd_catch_throw): New function.
2035         (mi_cmd_catch_rethrow): New function.
2036         (mi_cmd_catch_catch): New function.
2037         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2038         'catch-catch' entries.
2039         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2040         (mi_cmd_catch_rethrow): Declare.
2041         (mi_cmd_catch_catch): Declare.
2042
2043 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2044
2045         * annotate.c (annotate_source_line): Change return type to void,
2046         update implementation to match.
2047         * annotate.h (annotate_source_line): Change return type to void,
2048         update header comment.
2049         * stack.c (print_frame_info): Don't change what frame information
2050         is printed based on whether annotations are on or not.
2051
2052 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2053
2054         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2055         (annotate_source): Make static.
2056         (annotate_source_line): Moved from source.c and renamed from
2057         identify_source_line.  Update the return type.
2058         * annotate.h (annotate_source): Delete declaration.
2059         (annotate_source_line): Declaration moved from source.h, and
2060         renamed from identify_source_line.  Return type updated.
2061         * source.c (identify_source_line): Moved to annotate.c and renamed
2062         to annotate_source_line.
2063         (info_line_command): Remove check of annotation_level.
2064         * source.h (identify_source_line): Move declaration to annotate.h
2065         and rename to annotate_source_line.
2066         * stack.c: Add 'annotate.h' include.
2067         (print_frame_info): Remove check of annotation_level before
2068         calling annotate_source_line.
2069
2070 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2071
2072         * source-cache.c (source_cache::get_plain_source_lines): Use
2073         open_source_file_with_line_charpos instead of just
2074         open_source_file, remove call to find_source_lines.
2075         (source_cache::get_source_lines): Likewise.
2076         * source.c (find_source_lines): Make static.
2077         (get_filename_and_charpos): Renamed into...
2078         (open_source_file_with_line_charpos): ..this along with changes to
2079         return a scoped_fd, and some other minor clean ups.
2080         (identify_source_line): Use open_source_file_with_line_charpos.
2081         (search_command_helper): Use open_source_file_with_line_charpos
2082         instead of just open_source_file, remove call to
2083         find_source_lines.
2084         * source.h (open_source_file_with_line_charpos): Declare new
2085         function.
2086         (find_source_lines): Delete declaration.
2087
2088 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2089
2090         * source.c (get_filename_and_charpos): Remove fullname
2091         parameter.
2092         (identify_source_line): Update call to get_filename_and_charpos.
2093
2094 2019-06-14  Tom Tromey  <tromey@adacore.com>
2095
2096         PR gdb/24502:
2097         * ui-style.h (skip_ansi_escape): Update comment.
2098         * ui-file.h (class no_terminal_escape_file): New class.
2099         * ui-file.c (no_terminal_escape_file::write)
2100         (no_terminal_escape_file::puts): New methods.
2101         * cli/cli-logging.c (handle_redirections): Use
2102         no_terminal_escape_file.
2103
2104 2019-06-14  Tom Tromey  <tromey@adacore.com>
2105
2106         * NEWS: Move convenience variable news above Python news.
2107
2108 2019-06-14  Tom Tromey  <tom@tromey.com>
2109
2110         * gnulib: Move directory to top-level.
2111         * configure.ac: Don't configure gnulib.
2112         * configure: Rebuild.
2113         * common/common-defs.h: Use new path to gnulib.
2114         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2115         (GNULIB_H): Remove.
2116         (INCGNU): Look in new gnulib location.
2117         (HFILES_NO_SRCDIR): Remove gnulib files.
2118         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2119         (generated_files): Remove GNULIB_H.
2120         ($(LIBGNU), all-lib): Remove targets.
2121         (distclean): Don't mention GNULIB_BUILDDIR.
2122         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2123
2124 2019-06-14  Tom Tromey  <tromey@adacore.com>
2125
2126         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2127         Warn if symbol file does not provide any symbols.
2128
2129 2019-06-14  Tom Tromey  <tromey@adacore.com>
2130
2131         * source.c (find_and_open_source): Respect basenames_may_differ.
2132
2133 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2134
2135         * annotate.c (annotate_breakpoints_invalid): Make use of
2136         scoped_restore_terminal_state.
2137         (annotate_frames_invalid): Likewise.
2138
2139 2019-06-14  Tom Tromey  <tromey@adacore.com>
2140
2141         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2142         allow assignment to an internalvar.
2143
2144 2019-06-14  Tom Tromey  <tromey@adacore.com>
2145
2146         * ada-lex.l: Allow "_" in attribute names.
2147
2148 2019-06-14  Tom Tromey  <tromey@adacore.com>
2149
2150         PR gdb/24653:
2151         * regcache.c (registers_changed): Don't call alloca.
2152         * top.c (execute_command): Don't call alloca.
2153
2154 2019-06-13  Pedro Alves  <palves@redhat.com>
2155
2156         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2157         'expression'.  When parsing an expression, error out if there's
2158         junk after "unlimited".
2159         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2160         (do_set_command): Adjust calls to is_unlimited_literal.
2161
2162 2019-06-13  Pedro Alves  <palves@redhat.com>
2163
2164         * compile/compile.c (make_compile_options_def_group): Add braces
2165         around array_view initializer.
2166         * thread.c (make_thread_apply_all_options_def_group)
2167         (make_thread_apply_all_options_def_group): Likewise.
2168
2169 2019-06-13  Pedro Alves  <palves@redhat.com>
2170
2171         * NEWS (New commands): Mention "maint test-options
2172         require-delimiter", "maint test-options unknown-is-error", "maint
2173         test-options unknown-is-operand" and "maint show
2174         test-options-completion-result".
2175         (New command options, command completion): New section.
2176         (Completion improvements): New section.
2177         Mention that you can abbreviate "unlimited".
2178
2179 2019-06-13  Pedro Alves  <palves@redhat.com>
2180
2181         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2182         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2183         * unittests/cli-utils-selftests.c (test_parse_flags)
2184         (test_parse_flags_qcs): Delete.
2185         (test_cli_utils): Don't call deleted functions.
2186
2187 2019-06-13  Pedro Alves  <palves@redhat.com>
2188
2189         * thread.c: Include "cli/cli-option.h".
2190         (tp_array_compar_ascending): Global.
2191         (tp_array_compar): Delete function.
2192         (tp_array_compar_ascending, tp_array_compar_descending): New
2193         functions.
2194         (ascending_option_def, qcs_flag_option_def)
2195         (thr_qcs_flags_option_defs)
2196         (make_thread_apply_all_options_def_group)
2197         (make_thread_apply_options_def_group): New.
2198         (thread_apply_all_command): Use gdb::option::process_options.
2199         (thread_apply_command_completer)
2200         (thread_apply_all_command_completer): New.
2201         (thread_apply_command): Use gdb::option::process_options.
2202         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2203         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2204         to generate help text of "thread apply".  Adjust "taas"'s help.
2205         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2206         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2207
2208 2019-06-13  Pedro Alves  <palves@redhat.com>
2209
2210         * thread.c (thread_apply_command): Check for invalid TID with
2211         isdigit instead of !isalpha.
2212
2213 2019-06-13  Pedro Alves  <palves@redhat.com>
2214
2215         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2216         (validate_flags_qcs): New.
2217         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2218         (validate_flags_qcs): Declare.
2219         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2220         (make_frame_apply_options_def_group): New.
2221         (frame_apply_command_count): Process options with
2222         gdb::option::process_options.
2223         (frame_apply_completer): New.
2224         (frame_apply_level_completer, frame_apply_all_completer)
2225         (frame_apply_completer): New.
2226         (_initialize_stack): Update help of "frame apply", "frame apply
2227         level", "frame apply all" and "faas" to mention supported options
2228         and install command completers.
2229         * stack.h (frame_apply_all_completer): Declare.
2230         * thread.c: Include "stack.h".
2231         (tfaas_command): Add "--".
2232         (_initialize_thread): Update help "tfaas" to mention supported
2233         options and install command completer.
2234
2235 2019-06-13  Pedro Alves  <palves@redhat.com>
2236
2237         * completer.c (complete_nested_command_line): New.
2238         (gdb_completion_word_break_characters_throw): Add assertion.
2239         * completer.h (complete_nested_command_line): Declare.
2240
2241 2019-06-13  Pedro Alves  <palves@redhat.com>
2242
2243         * stack.c (parse_backtrace_qualifiers): New.
2244         (backtrace_command): Use it.
2245         (backtrace_command_completer): Complete on qualifiers.
2246
2247 2019-06-13  Pedro Alves  <palves@redhat.com>
2248
2249         * frame.c: Include "cli/cli-option.h.
2250         (user_set_backtrace_options): New.
2251         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2252         Delete.
2253         (get_prev_frame): Adjust.
2254         (boolean_option_def, uinteger_option_def)
2255         (set_backtrace_option_defs): New.
2256         (_initialize_frame): Adjust and use
2257         gdb::option::add_setshow_cmds_for_options to install "set
2258         backtrace past-main" and "set backtrace past-entry".
2259         * frame.h: Include "cli/cli-option.h".
2260         (struct frame_print_options): Forward declare.
2261         (print_frame_arguments_all, print_frame_arguments_scalars)
2262         (print_frame_arguments_none): Declare.
2263         (print_entry_values): Delete declaration.
2264         (struct frame_print_options, user_frame_print_options): New.
2265         (struct set_backtrace_options): New.
2266         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2267         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2268         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2269         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2270         (list_args_or_locals): Add frame_print_options parameter.
2271         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2272         * python/py-framefilter.c (enumerate_args): Pass down
2273         USER_FRAME_PRINT_OPTIONS.
2274         * stack.c: Include "cli/cli-option.h".
2275         (print_frame_arguments_all, print_frame_arguments_scalars)
2276         (print_frame_arguments_none): Declare.
2277         (print_raw_frame_arguments, print_entry_values): Delete.
2278         (user_frame_print_options): New.
2279         (boolean_option_def, enum_option_def, frame_print_option_defs):
2280         New.
2281         (struct backtrace_cmd_options): New.
2282         (bt_flag_option_def): New.
2283         (backtrace_command_option_defs): New.
2284         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2285         (print_frame_arg, read_frame_arg, print_frame_args)
2286         (print_frame_info, print_frame): Add frame_print_options parameter
2287         and use it.
2288         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2289         (backtrace_command_1): Add frame_print_options and
2290         backtrace_cmd_options parameters and use them.
2291         (make_backtrace_options_def_group): New.
2292         (backtrace_command): Process command options with
2293         gdb::option::process_options.
2294         (backtrace_command_completer): New.
2295         (_initialize_stack): Extend "backtrace"'s help to mention
2296         supported options.  Install completer for "backtrace".
2297         Install some settings commands with add_setshow_cmds_for_options.
2298
2299 2019-06-13  Pedro Alves  <palves@redhat.com>
2300
2301         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2302         and that "set/show print raw frame-arguments" are now deprecated.
2303
2304         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2305         command.
2306         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2307         * stack.c (_initialize_stack): Install "set/show print
2308         raw-frame-arguments", and deprecate "set/show print raw
2309         frame-arguments".
2310         * valprint.c (_initialize_valprint): Deprecate "set/show print
2311         raw".
2312
2313 2019-06-13  Pedro Alves  <palves@redhat.com>
2314
2315         * compile/compile.c (struct compile_options): New.
2316         (compile_flag_option_def, compile_command_option_defs)
2317         (make_compile_options_def_group): New.
2318         (compile_file_command): Handle options with
2319         gdb::option::process_options.
2320         (compile_file_command_completer): New function.
2321         (compile_code_command): Handle options with
2322         gdb::option::process_options.
2323         (compile_code_command_completer): New function.
2324         (_initialize_compiler): Install completers for "compile code" and
2325         "compile file".  Mention available options in "compile code" and
2326         "compile code"'s help.
2327         * completer.c (advance_to_completion_word): New, factored out from
2328         ...
2329         (advance_to_expression_complete_word_point): ... this.
2330         (advance_to_filename_complete_word_point): New.
2331         * completer.h (advance_to_filename_complete_word_point): New
2332         declaration.
2333
2334 2019-06-13  Pedro Alves  <palves@redhat.com>
2335
2336         * compile/compile.c: Include "cli/cli-option.h".
2337         (compile_print_value): Scope data pointer is now a
2338         value_print_options pointer; adjust.
2339         (compile_print_command): Process options.  Scope data pointer is
2340         now a value_print_options pointer; adjust.
2341         (_initialize_compile): Update "compile print"'s help to include
2342         supported options.  Install a completer for "compile print".
2343         * cp-valprint.c (show_vtblprint, show_objectprint)
2344         (show_static_field_print): Delete.
2345         (_initialize_cp_valprint): Don't install "set print
2346         static-members", "set print vtbl", "set print object" here.
2347         * printcmd.c: Include "cli/cli-option.h" and
2348         "common/gdb_optional.h".
2349         (print_command_parse_format): Rework to fill in a
2350         value_print_options instead of a format_data.
2351         (print_value): Change parameter type from format_data pointer to
2352         value_print_options reference.  Adjust.
2353         (print_command_1): Process options.  Adjust to pass down a
2354         value_print_options.
2355         (print_command_completer): New.
2356         (_initialize_printcmd): Install print_command_completer as
2357         handle_brkchars completer for the "print" command.  Update
2358         "print"'s help to include supported options.
2359         * valprint.c: Include "cli/cli-option.h".
2360         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2361         here from cp-valprint.c.
2362         (boolean_option_def, uinteger_option_def)
2363         (value_print_option_defs, make_value_print_options_def_group):
2364         New.  Use gdb::option::add_setshow_cmds_for_options to install
2365         "set print elements", "set print null-stop", "set print repeats",
2366         "set print pretty", "set print union", "set print array", "set
2367         print address", "set print symbol", "set print array-indexes".
2368         * valprint.h: Include <string> and "cli/cli-option.h".
2369         (make_value_print_options_def_group): Declare.
2370         (print_value): Change parameter type from format_data pointer to
2371         value_print_options reference.
2372         (print_command_completer): Declare.
2373
2374 2019-06-13  Pedro Alves  <palves@redhat.com>
2375
2376         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2377         (COMMON_SFILES): Add maint-test-settings.c.
2378         * cli/cli-decode.c (boolean_enums): New global, factored out from
2379         ...
2380         (add_setshow_boolean_cmd): ... here.
2381         * cli/cli-decode.h (boolean_enums): Declare.
2382         * cli/cli-option.c: New file.
2383         * cli/cli-option.h: New file.
2384         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2385         factored out from ...
2386         (parse_cli_boolean_value(const char *)): ... this.
2387         (is_unlimited_literal): Change parameter type to pointer to
2388         pointer.  Adjust and advance ARG pointer.
2389         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2390         (parse_cli_var_enum): New, factored out from ...
2391         (do_set_command): ... this.  Adjust.
2392         * cli/cli-setshow.h (parse_cli_boolean_value)
2393         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2394         (parse_cli_var_enum): Declare.
2395         * cli/cli-utils.c: Include "cli/cli-option.h".
2396         (get_ulongest): New.
2397         * cli/cli-utils.h (get_ulongest): Declare.
2398         (check_for_argument): New overloads.
2399         * maint-test-options.c: New file.
2400
2401 2019-06-13  Pedro Alves  <palves@redhat.com>
2402
2403         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2404         parse a range if "-" is at the end of the string.
2405
2406 2019-06-13  Pedro Alves  <palves@redhat.com>
2407
2408         * cli/cli-setshow.c (parse_auto_binary_operation)
2409         (parse_cli_boolean_value): Don't allow "o".
2410
2411 2019-06-13  Pedro Alves  <palves@redhat.com>
2412
2413         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2414         * NEWS: Mention maint test-settings KIND.
2415         * maint-test-settings.c: New file.
2416
2417 2019-06-13  Pedro Alves  <palves@redhat.com>
2418
2419         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2420         completer.
2421         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2422         "set" completers.
2423
2424 2019-06-13  Pedro Alves  <palves@redhat.com>
2425
2426         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2427         after item.
2428
2429 2019-06-13  Pedro Alves  <palves@redhat.com>
2430
2431         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2432
2433 2019-06-13  Pedro Alves <palves@redhat.com>
2434
2435         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2436         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2437         call.
2438         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2439         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2440         calls.
2441         (check_for_argument): Skip spaces after argument.
2442
2443 2019-06-13  Pedro Alves  <palves@redhat.com>
2444
2445         * thread.c (thread_apply_command): Adjust TID parsing.
2446         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2447         detected before end of string.
2448         (tid_is_in_list): Error out if LIST is invalid.
2449
2450 2019-06-13  Pedro Alves  <palves@redhat.com>
2451
2452         * completer.c (complete_line_internal_1): Rewind completion word
2453         point.
2454         (completion_tracker::advance_custom_word_point_by): Change
2455         parameter type to int.
2456         * completer.h (completion_tracker::advance_custom_word_point_by):
2457         Likewise.
2458
2459 2019-06-13  Pedro Alves  <palves@redhat.com>
2460
2461         * completer.c (advance_to_completion_word): Handle delimiters.
2462
2463 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2464
2465         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2466
2467 2019-06-11  Tom Tromey  <tom@tromey.com>
2468
2469         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2470         (xmalloc_failed): Move to alloc.c.
2471         * alloc.c: New file.
2472         * Makefile.in (COMMON_SFILES): Add alloc.c.
2473
2474 2019-06-11  Tom Tromey  <tom@tromey.com>
2475
2476         * nat/linux-waitpid.c: Don't include server.h.
2477         (linux_debug): Remove.
2478         (my_waitpid): Update.
2479
2480 2019-06-11  Tom Tromey  <tromey@adacore.com>
2481
2482         * infcall.c (_initialize_infcall): Remove trailing newline from
2483         help.
2484         * user-regs.c (_initialize_user_regs): Remove trailing newline
2485         from help.
2486         * typeprint.c (_initialize_typeprint): Remove trailing newline
2487         from help.
2488         * reverse.c (_initialize_reverse): Remove trailing newlines from
2489         help.
2490         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2491         from help.
2492         * language.c (add_set_language_command): Remove trailing newline
2493         from help.
2494         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2495         help.
2496         * disasm.c (_initialize_disasm): Remove trailing newline from
2497         help.
2498         * top.c (init_main): Remove trailing newline from help.
2499         * interps.c (_initialize_interpreter): Remove trailing newline
2500         from help.
2501         * btrace.c (_initialize_btrace): Remove trailing newlines from
2502         help.
2503         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2504         from help.
2505         * python/python.c (_initialize_python): Remove trailing newline
2506         from help.
2507         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2508         help.
2509         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2510         from help.  Reformat some text.
2511         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2512         from help.
2513         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2514         newline from help.
2515
2516 2019-06-11  Tom Tromey  <tromey@adacore.com>
2517
2518         * darwin-nat.c (darwin_decode_exception_message)
2519         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2520
2521 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2522
2523         * valops.c (value_slice): Check for not allocated or not
2524         associated values.
2525
2526 2019-06-10  Tom de Vries  <tdevries@suse.de>
2527
2528         PR gdb/24618
2529         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2530         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2531         invalid.
2532
2533 2019-06-10  Tom de Vries  <tdevries@suse.de>
2534
2535         PR gdb/24611
2536         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2537         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2538
2539 2019-06-10  Tom de Vries  <tdevries@suse.de>
2540
2541         PR symtab/24545
2542         * symtab.c (struct demangled_name_entry): Add language field.
2543         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2544         static minimal symbol".  Set and use language field.
2545
2546 2019-06-10  Tom Tromey  <tromey@adacore.com>
2547
2548         * ada-lang.c (_initialize_ada_language): Update help text.
2549
2550 2019-06-10  Tom Tromey  <tromey@adacore.com>
2551
2552         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2553         with a newline.
2554         * guile/guile.c (handle_boot_error): Don't end warning with a
2555         newline.
2556         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2557         warning with a newline.
2558         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2559         newline.
2560         (s12z_frame_cache): Likewise.
2561         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2562         a newline.
2563         * solib-svr4.c (disable_probes_interface): Don't end warning with
2564         a newline.
2565         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2566         newline.
2567         * python/python.c (do_finish_initialization): Don't end warning
2568         with a newline.
2569
2570 2019-06-10  Tom Tromey  <tom@tromey.com>
2571
2572         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2573         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2574         gdbpy_enter.
2575
2576 2019-06-10  Tom Tromey  <tromey@adacore.com>
2577
2578         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2579         data.
2580         (elf_new_init): Don't call stabsread_new_init.
2581         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2582         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2583         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2584
2585 2019-06-10  Tom de Vries  <tdevries@suse.de>
2586
2587         PR symtab/16264
2588         PR symtab/24517
2589         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2590
2591 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2592
2593         * source.c (find_and_open_source): Also rewrite relative file
2594         names.
2595
2596 2019-04-26  Amos Bird  <amosbird@gmail.com>
2597
2598         * annotate.c (annotate_thread_exited): Add "thread-exited"
2599         annotation.
2600
2601 2019-06-06  Tom Tromey  <tromey@adacore.com>
2602
2603         * maint.h (class scoped_command_stats): Use
2604         DISABLE_COPY_AND_ASSIGN.
2605         <print_time>: New method.
2606         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2607         print_time.
2608         (scoped_command_stats::print_time): New method.
2609
2610 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2611
2612         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2613         instructions of lengths 6 or 8 bytes.
2614
2615 2019-06-04  Pedro Alves  <palves@redhat.com>
2616
2617         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2618
2619         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2620         * breakpoint.c (condition_completer): Likewise.
2621         * cli/cli-dump.c (scan_expression): Likewise.
2622         * common/filestuff.c (mkdir_recursive): Likewise.
2623         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2624         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2625         (gdb_abspath): Likewise.
2626         * compile/compile-cplus-types.c
2627         (compile_cplus_instance::decl_name): Likewise.
2628         * completer.c (complete_explicit_location):
2629         (signal_completer, reg_or_group_completer_1): Likewise.
2630         * cp-support.c (cp_remove_params_if_any): Likewise.
2631         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2632         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2633         * infcmd.c (strip_bg_char): Likewise.
2634         * linespec.c (copy_token_string): Likewise.
2635         * mi/mi-main.c (output_cores): Likewise.
2636         * psymtab.c (psymtab_search_name):
2637         * symfile.c (test_set_ext_lang_command): Likewise.
2638         * target.c (target_fileio_read_stralloc): Likewise.
2639         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2640         * value.c (complete_internalvar): Likewise.
2641
2642 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2643
2644         Add objfile property to gdb.Type.
2645         * NEWS: Mention Python API addition.
2646         * python/py-type.c (typy_get_objfile): New method.
2647
2648 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2649
2650         * NEWS: Mention the new set|show style [title|highlight].
2651         Mention changes to "show style", "help" and "apropos".
2652
2653 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2654
2655         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2656         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2657         instead of print_help_for_command.
2658         (print_doc_of_command): New function.
2659         (help_list): Add 'apropos -v word' suggestion.
2660         (print_help_for_command): Style the command name using title style.
2661         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2662         (_initialize_cli_cmds): Describe -v in apropos_command help.
2663
2664 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2665
2666         * cli/cli-style.h (cli_style_option): Add name in constructor,
2667         add m_name class member, add constructor with intensity,
2668         add name class function.
2669         (cli_style_option::add_setshow_commands): Remove name argument.
2670         (highlight_style, title_style): New styles.
2671         * cli/cli-style.c (do_show): New function that shows a style
2672         characteristic styling the style name with itself.
2673         (set_style_name): New function.
2674         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2675         Update all callers according to the changes in cli/cli-style.h.
2676         * utils.h (fputs_highlighted): New function.
2677         * utils.c (fputs_highlighted): Likewise.
2678
2679 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2680
2681         * NEWS: Mention new pipe command and new convenience variables.
2682
2683 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2684
2685         * cli/cli-cmds.c (pipe_command): New function.
2686         (_initialize_cli_cmds): Call add_com for pipe_command.
2687         Define | as an alias for pipe.
2688         (exit_status_set_internal_vars): New function.
2689         (shell_escape): Call exit_status_set_internal_vars.
2690         cli/cli-decode.c (find_command_name_length): Recognize | as
2691         a single character command.
2692
2693 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2694
2695         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2696         top.c (execute_command_to_ui_file): New function, mostly a copy
2697         of execute_command_to_string.
2698         (execute_command_to_string): Implement by calling
2699         execute_command_to_ui_file.
2700
2701 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2702
2703         * top.h (saved_command_line): Remove declaration.
2704         * top.c (previous_saved_command_line, previous_repeat_arguments):
2705         New variables.
2706         (saved_command_line): Make static, define together with other
2707         'repeat variables'.
2708         (dont_repeat): Clear repeat_arguments.
2709         (repeat_previous, get_saved_command_line, save_command_line):
2710         New functions.
2711         (gdb_init): Initialize saved_command_line
2712         and previous_saved_command_line.
2713         * main.c (captured_main_1): Remove saved_command_line initialization.
2714         * event-top.c (handle_line_of_input): Update to use
2715         the new 'repeat' related functions instead of direct access to
2716         saved_command_line.
2717         * command.h (repeat_previous, get_saved_command_line,
2718         save_command_line): New declarations.
2719         (dont_repeat): Add comment.
2720
2721 2019-05-30  Tom Tromey  <tromey@adacore.com>
2722
2723         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2724         Fix comment.
2725         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2726
2727 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2728
2729         PR cli/24587
2730         * completer.c (complete): Initialize variable word.
2731
2732 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2733
2734         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2735         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2736         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2737         'body' is NULL to the outter 'if', protecting the '!is_define'
2738         situation as well.
2739
2740 2019-05-29  Tom Tromey  <tromey@adacore.com>
2741
2742         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2743         (dwarf_unknown): New function.
2744         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2745         (dwarf_type_encoding_name): Use dwarf_unknown.
2746
2747 2019-05-29  Tom Tromey  <tromey@adacore.com>
2748
2749         PR c++/20020:
2750         * cp-valprint.c (cp_print_value_fields): Call
2751         cp_print_static_field inside "try".
2752
2753 2019-05-29  Tom Tromey  <tromey@adacore.com>
2754
2755         * inflow.c (struct terminal_info): Add default operator=.
2756         * configure: Rebuild.
2757         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2758         -Wdeprecated-copy-dtor, -Wredundant-move.
2759
2760 2019-05-29  Tom Tromey  <tromey@adacore.com>
2761
2762         * NEWS: Add entry.
2763         * infcmd.c (print_return_value_1): Handle finish_print
2764         option.
2765         (show_print_finish): New function.
2766         (_initialize_infcmd): Add "set/show print finish" commands.
2767         * valprint.c (user_print_options): Initialize new member.
2768         * valprint.h (struct value_print_options) <finish_print>: New
2769         member.
2770
2771 2019-05-28  Tom Tromey  <tromey@adacore.com>
2772
2773         * ada-lang.c (ada_remove_Xbn_suffix)
2774         (find_old_style_renaming_symbol)
2775         (parse_old_style_renaming): Remove.
2776         (ada_find_renaming_symbol): Don't call
2777         find_old_style_renaming_symbol.
2778         (ada_is_renaming_symbol): Rename from
2779         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2780         bool.  Now static.
2781         (ada_read_var_value): Update and simplify.
2782         * ada-exp.y (write_var_or_type): Remove old code.
2783
2784 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2785
2786         * event-top.c: Remove include comment.
2787         * inflow.c (class scoped_ignore_sigttou): Move from here...
2788         * inflow.h (class scoped_ignore_sigttou): ...to here.
2789         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2790         * top.c:  Remove include comment.
2791
2792 2019-05-27  Tom Tromey  <tom@tromey.com>
2793
2794         * NEWS: Fix typo.
2795
2796 2019-05-22  Tom Tromey  <tromey@adacore.com>
2797
2798         * target.c (target_follow_exec): Constify parameter.
2799         * target-delegates.c: Rebuild.
2800         * remote.c (remote_target::follow_exec): Constify parameter.
2801         * infrun.c (follow_exec): Constify parameter.
2802         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2803         (target_follow_exec): Likewise.
2804
2805 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2806
2807         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2808         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2809
2810 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2811
2812         * NEWS: Add debugredirect and testsuite sections.
2813
2814 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2815
2816         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2817         target descriptions using exclusively floating point register name
2818         aliases.
2819
2820 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2821
2822         PR gdb/18644:
2823         * f-lang.c (build_fortran_types): Handle the case where
2824         gdbarch_floatformat_for_type returns a nullptr.
2825
2826 2019-05-21  Tom de Vries  <tdevries@suse.de>
2827
2828         PR cli/24587
2829         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2830
2831 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2832
2833         PR gdb/18644:
2834         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2835         16-byte floats.
2836         * i386-tdep.c (i386_floatformat_for_type): Use
2837         floatformats_ia64_quad for the 16-byte floating point component
2838         within a fortran 32-byte complex number.
2839
2840 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2841
2842         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2843         delete default constructor.
2844         (find_partial_die): Update to return const struct.
2845         (partial_die_parent_scope): Move variable declaration into scope
2846         of its use and change its type to auto.
2847         (guess_partial_die_structure_name): Likewise.
2848         (partial_die_info::fixup): Likewise.
2849
2850 2019-05-17  Tom Tromey  <tromey@adacore.com>
2851
2852         * source.c (find_and_open_source): Remove cast.
2853
2854 2019-05-17  Tom Tromey  <tromey@adacore.com>
2855
2856         * annotate.c (annotate_source): Make "filename" const.
2857         * annotate.h (annotate_source): Use const.
2858
2859 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2860
2861         * disasm.c (set_disassembler_options): Send errors to stderr.
2862
2863 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2864
2865         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2866         (cli_interp_base::set_logging): Check debug_redirect.
2867         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2868         * cli/cli-logging.c (debug_redirect): Add static variable.
2869         (pop_output_files): Add default param.
2870         (handle_redirections): Print debug setting.
2871         (show_logging_command): Likewise.
2872         (_initialize_cli_logging): Add debugredirect command.
2873         * interps.c (current_interp_set_logging): Add debug_redirect
2874         parameter.
2875         * interps.h (set_logging): Add debug_redirect parameter.
2876         (current_interp_set_logging): Likewise.
2877         * mi/mi-common.h: Likewise.
2878         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2879
2880 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2881             Tom Tromey  <tromey@adacore.com>
2882
2883         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2884         directly.
2885         * cli/cli-interp.h (make_logging_output): Remove declaration.
2886         * cli/cli-logging.c (make_logging_output): Remove function.
2887         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2888         directly.
2889         * ui-file.c (tee_file::tee_file): Remove bools.
2890         (tee_file::~tee_file): Remove deletes.
2891         * ui-file.h (tee_file): Remove bools.
2892
2893 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2894
2895         * mi/mi-cmds.h (mi_cmd_complete): New function.
2896         * mi/mi-main.c (mi_cmd_complete): Likewise.
2897         * mi/mi-cmds.c: Define new MI command -complete.
2898         * NEWS: Mention new -complete command.
2899
2900 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2901
2902         * completer.h (complete): New function.
2903         * completer.c (complete): Likewise.
2904         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2905         function defined in completer.h.
2906
2907 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2908
2909         * MAINTAINERS (Write After Approval): Add myself.
2910
2911 2019-05-17  Tom de Vries  <tdevries@suse.de>
2912
2913         PR gdb/24094
2914         * dwarf2read.c (struct cu_partial_die_info): New struct.
2915         (find_partial_die): Return cu_partial_die_info.
2916         (partial_die_parent_scope, guess_partial_die_structure_name)
2917         (partial_die_info::fixup): Handle new return type of find_partial_die.
2918
2919 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2920
2921         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2922         "std::string", simplifying the algorithm.
2923
2924 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2925
2926         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2927         (stap_static_probe_ops::get_probes): Likewise.
2928
2929 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2930
2931         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2932         '-')" and "else if".
2933         (stap_parse_single_operand): Join checks for
2934         "gdbarch_stap_parse_special_token_p" and
2935         "gdbarch_stap_parse_special_token" in the same "if" statement.
2936         Invert check when verifying for operation on register
2937         displacement.
2938
2939 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2940
2941         * stap-probe.c (stap_get_opcode): Update comment.
2942         (stap_get_expected_argument_type): Likewise.
2943         (handle_stap_probe): Likewise.
2944
2945 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2946
2947         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2948         return type to 'bool'.  Adjust comment.  Use 'bool' when
2949         appropriate.
2950         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2951         * stap-probe.c (stap_parse_argument_1): Likewise.
2952         (stap_is_operator): Likewise.
2953         (stap_is_generic_prefix): Likewise.
2954         (stap_is_register_prefix): Likewise.
2955         (stap_is_register_indirection_prefix): Likewise.
2956         (stap_is_integer_prefix): Likewise.
2957         (stap_generic_check_suffix): Likewise.
2958         (stap_check_integer_suffix): Likewise.
2959         (stap_check_register_suffix): Likewise.
2960         (stap_check_register_indirection_suffix): Likewise.
2961         (stap_parse_register_operand): Likewise.
2962         (stap_parse_single_operand): Likewise.
2963         (stap_parse_argument_1): Likewise.
2964         (stap_probe::get_argument_count): Likewise.
2965         (stap_is_operator): Likewise.
2966
2967 2019-05-16  Tom Tromey  <tromey@adacore.com>
2968
2969         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2970         keyword to foreach.
2971
2972 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2973
2974         * linux-thread-db.c (try_thread_db_load_1): Change return type
2975         to bool.
2976         (try_thread_db_load): Likewise.
2977         (try_thread_db_load_from_pdir_1): Likewise.
2978         (try_thread_db_load_from_pdir): Likewise.
2979         (try_thread_db_load_from_sdir): Likewise.
2980         (try_thread_db_load_from_dir): Likewise.
2981         (thread_db_load_search): Likewise.
2982         (has_libpthread): Likewise.
2983         (thread_db_load): Likewise.
2984
2985 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2986
2987         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2988         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2989         NULL, and complain/return if that's the case.
2990
2991 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2992
2993         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2994         (advance, posn, abstract_read_memory): New functions.
2995         [struct mem_read_abstraction]: New struct.
2996         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2997
2998 2019-05-14  Tom Tromey  <tromey@adacore.com>
2999
3000         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3001         value is not lval_memory.
3002
3003 2019-05-14  Tom Tromey  <tromey@adacore.com>
3004
3005         * solib.c (info_sharedlibrary_command): Style the file name.
3006
3007 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3008
3009         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3010         (aarch64_vnv_type): Likewise.
3011         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3012         * common/tdesc.c: Likewise.
3013         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3014         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3015         * features/aarch64-fpu.xml: Add ieee half view.
3016         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3017         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3018         * gdbtypes.h (struct builtin_type): Likewise.
3019         (struct objfile_type): Likewise.
3020
3021 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3022
3023         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3024         typo.
3025         * location.h (string_to_event_location): Likewise.
3026
3027 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3028
3029         GDB 8.3 released.
3030
3031 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3032
3033         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3034         New variable declaration.
3035         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3036         New variable.
3037         (print_one_breakpoint): Use ui_out::test_flags and new global
3038         variable to compute use_fixed_output.
3039         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3040         Remove.
3041         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3042         (mi_multi_location_breakpoint_output_fixed): Remove.
3043         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3044         new variable.
3045         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3046         fix_multi_location_breakpoint_output flag if version >= 3.
3047         * ui-out.h (enum ui_out_flag)
3048         <fix_multi_location_breakpoint_output>: New enumerator.
3049
3050 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3051
3052         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3053
3054 2019-05-10  Tom Tromey  <tromey@adacore.com>
3055
3056         * ada-lang.c (catch_ada_completer): New function.
3057         (_initialize_ada_language): Use it.
3058
3059 2019-05-10  Tom Tromey  <tromey@adacore.com>
3060
3061         * thread.c (print_thread_info): Make "requested_threads" const.
3062         * gdbthread.h (print_thread_info): Make "requested_threads"
3063         const.
3064         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3065         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3066
3067 2019-05-08  Tom Tromey  <tom@tromey.com>
3068
3069         * gdbtypes.c (objfile_type_data): Change type.
3070         (objfile_type, _initialize_gdbtypes): Update.
3071
3072 2019-05-08  Tom Tromey  <tom@tromey.com>
3073
3074         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3075         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3076         (_initialize_dwarf2_frame): Update.
3077
3078 2019-05-08  Tom Tromey  <tom@tromey.com>
3079
3080         * objc-lang.c (objc_objfile_data): Change type.
3081         (find_methods): Update.
3082         (_initialize_objc_lang): Remove.
3083
3084 2019-05-08  Tom Tromey  <tom@tromey.com>
3085
3086         * stabsread.c (rs6000_builtin_type_data): Change type.
3087         (rs6000_builtin_type, _initialize_stabsread): Update.
3088
3089 2019-05-08  Tom Tromey  <tom@tromey.com>
3090
3091         * mips-tdep.c (mips_pdr_data): Remove.
3092         (_initialize_mips_tdep): Update.
3093
3094 2019-05-08  Tom Tromey  <tom@tromey.com>
3095
3096         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3097         (hppa_init_objfile_priv_data, read_unwind_info)
3098         (find_unwind_entry, _initialize_hppa_tdep): Update.
3099
3100 2019-05-08  Tom Tromey  <tom@tromey.com>
3101
3102         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3103         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3104         on obstack.
3105         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3106
3107 2019-05-08  Tom Tromey  <tom@tromey.com>
3108
3109         * mdebugread.c (basic_type_data): Change type.
3110         (basic_type, _initialize_mdebugread): Update.
3111
3112 2019-05-08  Tom Tromey  <tom@tromey.com>
3113
3114         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3115
3116 2019-05-08  Tom Tromey  <tom@tromey.com>
3117
3118         * nto-tdep.c (nto_inferior_data_reg): Change type.
3119         (nto_inferior_data): Update.
3120         (nto_inferior_data_cleanup, nto_new_inferior_data)
3121         (_initialize_nto_tdep): Remove.
3122         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3123
3124 2019-05-08  Tom Tromey  <tom@tromey.com>
3125
3126         * ada-lang.c (struct ada_inferior_data): Add initializers.
3127         (ada_inferior_data): Change type.
3128         (ada_inferior_data_cleanup): Remove.
3129         (get_ada_inferior_data, ada_inferior_exit)
3130         (struct ada_pspace_data): Add initializers, destructor.
3131         (ada_pspace_data_handle): Change type.
3132         (get_ada_pspace_data): Update.
3133         (ada_pspace_data_cleanup): Remove.
3134
3135 2019-05-08  Tom Tromey  <tom@tromey.com>
3136
3137         * coffread.c (struct coff_symfile_info): Add initializers.
3138         (coff_objfile_data_key): Move lower.  Change type.
3139         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3140         Update.
3141         (coff_free_info): Remove.
3142
3143 2019-05-08  Tom Tromey  <tom@tromey.com>
3144
3145         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3146         (fbsd_pspace_data_handle): Move lower.  Change type.
3147         (get_fbsd_pspace_data): Update.
3148         (fbsd_pspace_data_cleanup): Remove.
3149         (_initialize_fbsd_tdep): Update.
3150
3151 2019-05-08  Tom Tromey  <tom@tromey.com>
3152
3153         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3154         (get_ada_tasks_pspace_data): Update.
3155         (ada_tasks_pspace_data_cleanup): Remove.
3156         (_initialize_tasks): Update.
3157         (ada_tasks_inferior_data_handle): Change type.
3158         (get_ada_tasks_inferior_data): Update.
3159         (ada_tasks_inferior_data_cleanup): Remove.
3160         (struct ada_tasks_pspace_data): Add initializers.
3161
3162 2019-05-08  Tom Tromey  <tom@tromey.com>
3163
3164         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3165         * symfile-debug.c (debug_sym_get_probes): Change type.
3166         * stap-probe.c (handle_stap_probe):
3167         (stap_static_probe_ops::get_probes): Change type.
3168         * probe.h (class static_probe_ops) <get_probes>: Change type.
3169         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3170         (parse_probes_in_pspace): Update.
3171         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3172         Update.
3173         (any_static_probe_ops::get_probes): Change type.
3174         * elfread.c (elfread_data): New typedef.
3175         (probe_key): Change type.
3176         (elf_get_probes): Likewise.  Update.
3177         (probe_key_free): Remove.
3178         (_initialize_elfread): Update.
3179         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3180         Change type.
3181         (dtrace_process_dof_probe, dtrace_process_dof)
3182         (dtrace_static_probe_ops::get_probe): Change type.
3183
3184 2019-05-08  Tom Tromey  <tom@tromey.com>
3185
3186         * xcoffread.c (struct xcoff_symfile_info): Rename from
3187         coff_symfile_info.  Add initializers.
3188         (xcoff_objfile_data_key): Move lower.  Change type.
3189         (XCOFF_DATA): Rewrite.
3190         (xcoff_free_info): Remove.
3191         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3192         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3193         (xcoff_initial_scan): Update.
3194
3195 2019-05-08  Tom Tromey  <tom@tromey.com>
3196
3197         * solib-svr4.c (struct svr4_info): Add initializers and
3198         destructor.
3199         <probes_table>: Now an htab_up.
3200         (solib_svr4_pspace_data): Change type.
3201         (free_probes_table): Simplify.
3202         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3203         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3204         (probes_table_remove_objfile_probes, register_solib_event_probe)
3205         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3206         (_initialize_svr4_solib): Update.
3207
3208 2019-05-08  Tom Tromey  <tom@tromey.com>
3209
3210         * remote.c (remote_pspace_data): Change type.
3211         (remote_pspace_data_cleanup): Remove.
3212         (get_remote_exec_file, set_pspace_remote_exec_file)
3213         (_initialize_remote): Update.
3214
3215 2019-05-08  Tom Tromey  <tom@tromey.com>
3216
3217         * breakpoint.c (breakpoint_objfile_key): Change type.
3218         (get_breakpoint_objfile_data): Update.
3219         (free_breakpoint_objfile_data): Remove.
3220         (_initialize_breakpoint): Update.
3221
3222 2019-05-08  Tom Tromey  <tom@tromey.com>
3223
3224         * linux-tdep.c (struct linux_info): Add initializers.
3225         (linux_inferior_data): Move.  Change type.
3226         (invalidate_linux_cache_inf): Update.
3227         (linux_inferior_data_cleanup): Remove.
3228         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3229
3230 2019-05-08  Tom Tromey  <tom@tromey.com>
3231
3232         * auxv.c (auxv_inferior_data): Move.  Change type.
3233         (auxv_inferior_data_cleanup): Remove.
3234         (invalidate_auxv_cache_inf): Rewrite.
3235         (get_auxv_inferior_data, _initialize_auxv): Update.
3236
3237 2019-05-08  Tom Tromey  <tom@tromey.com>
3238
3239         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3240         (symfile_debug_objfile_data_key): Change type.
3241         (symfile_debug_installed, debug_qf_has_symbols)
3242         (debug_qf_find_last_source_symtab)
3243         (debug_qf_forget_cached_source_info)
3244         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3245         (debug_qf_print_stats, debug_qf_dump)
3246         (debug_qf_expand_symtabs_for_function)
3247         (debug_qf_expand_all_symtabs)
3248         (debug_qf_expand_symtabs_with_fullname)
3249         (debug_qf_map_matching_symbols)
3250         (debug_qf_expand_symtabs_matching)
3251         (debug_qf_find_pc_sect_compunit_symtab)
3252         (debug_qf_map_symbol_filenames)
3253         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3254         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3255         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3256         (debug_sym_read_linetable, debug_sym_relocate): Update.
3257         (symfile_debug_free_objfile): Remove.
3258         (install_symfile_debug_logging, _initialize_symfile_debug):
3259         Update.
3260
3261 2019-05-08  Tom Tromey  <tom@tromey.com>
3262
3263         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3264         allocate_on_obstack.
3265         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3266         (get_dwarf2_per_objfile): Update.
3267         (set_dwarf2_per_objfile): Remove.
3268         (dwarf2_has_info, dwarf2_get_section_info): Update.
3269         (dwarf2_free_objfile): Remove.
3270         (_initialize_dwarf2_read): Update.
3271
3272 2019-05-08  Tom Tromey  <tom@tromey.com>
3273
3274         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3275         initializers.
3276         <unsupported_script_warning_printed,
3277         script_not_found_warning_printed>: Now bool.
3278         (auto_load_pspace_data): Change type.
3279         (~auto_load_pspace_info): Rename from
3280         auto_load_pspace_data_cleanup.
3281         (get_auto_load_pspace_data, init_loaded_scripts_info)
3282         (clear_section_scripts, maybe_print_unsupported_script_warning)
3283         (maybe_print_script_not_found_warning, _initialize_auto_load):
3284         Update.
3285
3286 2019-05-08  Tom Tromey  <tom@tromey.com>
3287
3288         * objfiles.c (objfile_pspace_info): Add destructor and
3289         initializers.
3290         (objfiles_pspace_data): Change type.
3291         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3292         (get_objfile_pspace_data): Update.
3293         (objfiles_bfd_data): Change type.
3294         (get_objfile_bfd_data): Update.
3295         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3296
3297 2019-05-08  Tom Tromey  <tom@tromey.com>
3298
3299         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3300         Change type.
3301         (get_catch_syscall_inferior_data): Update.
3302         (catch_syscall_inferior_data_cleanup): Remove.
3303         (_initialize_break_catch_syscall): Update.
3304
3305 2019-05-08  Tom Tromey  <tom@tromey.com>
3306
3307         * inflow.c (struct terminal_info): Add destructor and
3308         initializers.
3309         (inflow_inferior_data): Change type.
3310         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3311         (get_inflow_inferior_data, inflow_inferior_exit)
3312         (swap_terminal_info, _initialize_inflow): Update.
3313
3314 2019-05-08  Tom Tromey  <tom@tromey.com>
3315
3316         * target-dcache.c (target_dcache_cleanup): Remove.
3317         (target_dcache_aspace_key): Change type.
3318         (target_dcache_init_p, target_dcache_invalidate)
3319         (target_dcache_get, target_dcache_get_or_init)
3320         (_initialize_target_dcache): Update.
3321         * dcache.h (struct dcache_deleter): New.
3322
3323 2019-05-08  Tom Tromey  <tom@tromey.com>
3324
3325         * symtab.c (struct symbol_cache): Add destructor and
3326         initializers.
3327         (symbol_cache_key): Move.  Change type.
3328         (make_symbol_cache, free_symbol_cache): Remove.
3329         (get_symbol_cache): Update.
3330         (symbol_cache_cleanup): Remove.
3331         (ALL_PSPACES, symbol_cache_flush)
3332         (maintenance_print_symbol_cache)
3333         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3334         Update.
3335
3336 2019-05-08  Tom Tromey  <tom@tromey.com>
3337
3338         * symtab.c (struct main_info): Add destructor and initializers.
3339         (main_progspace_key): Move.  Change type.
3340         (get_main_info): Update.
3341         (main_info_cleanup): Remove.
3342         (_initialize_symtab): Update.
3343
3344 2019-05-08  Tom Tromey  <tom@tromey.com>
3345
3346         * registry.h (DECLARE_REGISTRY): Define the _key class.
3347
3348 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3349
3350         * NEWS: Merge two 'New commands' sections.
3351
3352 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3353
3354         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3355         parameter and use Ada language definition instead.
3356         (ada_val_print_ptr): Remove unused language parameter.
3357         (ada_val_print_num): Remove language parameter and use Ada language
3358         definition instead.
3359         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3360         parameter.
3361         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3362         parameter and use Ada language definition instead.
3363         (ada_val_print_1): Update all ada_val_print_xxx calls.
3364         Remove language parameter.
3365         (ada_val_print): Update ada_val_print_1 call.
3366
3367 2019-05-08  Tom Tromey  <tromey@adacore.com>
3368
3369         * remote.c (remote_hw_watchpoint_limit)
3370         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3371         Now static.
3372
3373 2019-05-08  Tom Tromey  <tromey@adacore.com>
3374
3375         * maint.c (_initialize_maint_cmds): Move initialization code to
3376         remote.c.
3377         (watchdog, show_watchdog): Move to remote.c.
3378         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3379         "watchdog" static.
3380         (_initialize_remote): Move initialization code from maint.c.
3381         * defs.h (watchdog): Don't declare.
3382
3383 2019-05-08  Tom Tromey  <tromey@adacore.com>
3384
3385         * tui/tui-interp.c: Include main.h.
3386         * interps.c: Include main.h.
3387         * main.h (interpreter_p): Declare.
3388         * defs.h (interpreter_p): Don't declare.
3389
3390 2019-05-08  Tom Tromey  <tromey@adacore.com>
3391
3392         * dwarf2loc.c: Include dwarf2read.h.
3393         * defs.h (read_unsigned_leb128): Don't declare.
3394         * dwarf2read.h (read_unsigned_leb128): Declare.
3395
3396 2019-05-08  Tom Tromey  <tromey@adacore.com>
3397
3398         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3399         method.
3400
3401 2019-05-08  Tom Tromey  <tromey@adacore.com>
3402
3403         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3404         when no wrap column is set.
3405
3406 2019-05-08  Tom Tromey  <tromey@adacore.com>
3407
3408         * c-lang.c (c_get_string): Handle non-C-style arrays.
3409
3410 2019-05-08  Tom Tromey  <tromey@adacore.com>
3411
3412         * typeprint.c (print_offset_data::update): Print the bit offset,
3413         not the number of bits remaining.
3414
3415 2019-05-08  Tom Tromey  <tromey@adacore.com>
3416
3417         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3418         padding at end of comment.
3419
3420 2019-05-08  Tom Tromey  <tromey@adacore.com>
3421
3422         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3423         Compare main types.
3424
3425 2019-05-06  Tom Tromey  <tom@tromey.com>
3426
3427         * common/scoped_mmap.c: Include common-defs.h.
3428         * common/scoped_mmap.h: Don't include config.h.
3429
3430 2019-05-04  Tom Tromey  <tom@tromey.com>
3431
3432         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3433         (struct aarch64_call_info): Add initializers.
3434         <si>: Now a std::vector.
3435         (pass_on_stack, aarch64_push_dummy_call): Update.
3436
3437 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3438             Tom Tromey  <tom@tromey.com>
3439
3440         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3441         (ppc_threads): Now a std::vector.  Now static.
3442         (hwdebug_find_thread_points_by_tid)
3443         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3444         Update.
3445
3446 2019-05-04  Tom Tromey  <tom@tromey.com>
3447
3448         * arc-tdep.c (arc_tdesc_init): Return bool.
3449
3450 2019-05-04  Tom Tromey  <tom@tromey.com>
3451
3452         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3453         Use gdb_assert_not_reached.
3454
3455 2019-05-04  Tom Tromey  <tom@tromey.com>
3456
3457         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3458         "false".
3459
3460 2019-05-04  Tom Tromey  <tom@tromey.com>
3461
3462         * arc-tdep.c (arc_tdesc_init): Use bool.
3463
3464 2019-05-04  Tom Tromey  <tom@tromey.com>
3465
3466         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3467
3468 2019-05-04  Tom Tromey  <tom@tromey.com>
3469
3470         * cli/cli-cmds.c (valid_command_p): Return bool.
3471
3472 2019-05-04  Tom Tromey  <tom@tromey.com>
3473
3474         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3475         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3476
3477 2019-05-04  Raul Tambre  <raul@tambre.ee>
3478
3479         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3480         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3481         operator for comparison.
3482
3483 2019-05-04  Tom Tromey  <tom@tromey.com>
3484
3485         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3486         (lookup_partial_symbol, print_partial_symbols)
3487         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3488         (psymbol_compare): Update.
3489         (add_psymbol_to_bcache): Clear the entire psymbol.
3490         (maintenance_check_psymtabs): Update.
3491         * psympriv.h (struct partial_symbol): Don't derive from
3492         general_symbol_info.
3493         <obj_section, unrelocated_address, address,
3494         set_unrelocated_address>: Update.
3495         <ginfo>: New member.
3496         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3497         (debug_names::write_psymbols): Update.
3498
3499 2019-05-04  Tom de Vries  <tdevries@suse.de>
3500
3501         * contrib/cc-with-tweaks.sh: Support -n arg.
3502
3503 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3504
3505         * corelow.c (core_target::detach): Ensure frame cache and
3506         register caches are cleared.
3507         inferior.c (exit_inferior_1): Likewise.
3508
3509 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3510             Tom Tromey  <tom@tromey.com>
3511
3512         * dictionary.c (collate_pending_symbols_by_language): Remove
3513         "struct" from foreach.
3514         * symtab.c (lookup_global_symbol_from_objfile)
3515         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3516         foreach.
3517         * ser-tcp.c (net_open): Remove "struct" from foreach.
3518         * objfiles.c (objfile_relocate, objfile_rebase)
3519         (objfile_has_symbols): Remove "struct" from foreach.
3520         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3521         from foreach.
3522         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3523         foreach.
3524         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3525         "struct" from foreach.
3526         * ada-lang.c (create_excep_cond_exprs)
3527         (ada_exception_catchpoint_cond_string): Remove "struct" from
3528         foreach.
3529
3530 2019-05-03  Tom Tromey  <tromey@adacore.com>
3531
3532         * ada-exp.y (convert_char_literal): Check suffix of each
3533         enumerator.
3534
3535 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3536
3537         PR ada/21406:
3538         * ada-exp.y (yywrap): Don't define.
3539         * ada-lex.l (%option): Add noyywrap
3540         (yywrap): Remove.
3541
3542 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3543
3544         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3545         _WIN32_WINNT to the XP level, unless already defined to a higher
3546         level.
3547
3548         * unittests/parse-connection-spec-selftests.c:
3549         * ser-tcp.c:
3550         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3551         override.
3552
3553         * symfile.c (find_separate_debug_file): Remove colon from the
3554         drive spec of DOS/Windows file names of the target, so that the
3555         file name produced from DEBUGDIR and the target's directory will
3556         be valid on DOS/Windows systems.
3557
3558 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3559
3560         * rust-lang.c (val_print_struct): Handle printing structures
3561         containing strings.
3562
3563 2019-05-02  Tom Tromey  <tromey@adacore.com>
3564
3565         * valarith.c (_initialize_valarith): Remove.
3566
3567 2019-05-01  Tom Tromey  <tromey@adacore.com>
3568
3569         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3570         bitfields.
3571
3572 2019-05-01  Tom Tromey  <tromey@adacore.com>
3573
3574         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3575         for big-endian copies.
3576
3577 2019-04-30  Ali Tamur  <tamur@google.com>
3578         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3579         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3580         (read_3_bytes): New function.
3581
3582 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3583
3584         * windows-nat.c (main_thread_id): Delete.
3585         (handle_output_debug_string): Replace main_thread_id by
3586         current_event.dwThreadId.
3587         (fake_create_process): Likewise.
3588         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3589         Do not set main_thread_id.
3590         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3591         current_event.dwThreadId.
3592         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3593
3594 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3595
3596         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3597         Use current_event.dwThreadId instead of main_thread_id.
3598
3599 2019-04-30  Tom Tromey  <tromey@adacore.com>
3600
3601         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3602         (create_excep_cond_exprs): Iterate over program spaces.
3603         (ada_exception_catchpoint_cond_string): Examine all minimal
3604         symbols for exception types.
3605
3606 2019-04-30  Tom Tromey  <tromey@adacore.com>
3607
3608         PR c++/24470:
3609         * dwarf2read.c (process_structure_scope): Handle case where type
3610         has template parameters but no symbol was created.
3611
3612 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3613             Chris January  <chris.january@arm.com>
3614
3615         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3616         qualifier.
3617         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3618
3619 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3620
3621         * f-typeprint.c (f_print_type): Update rules for printing
3622         whitespace.
3623         (f_type_print_varspec_suffix): Likewise.
3624
3625 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3626             Chris January  <chris.january@arm.com>
3627
3628         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3629         function arguments.
3630
3631 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3632
3633         * f-lang.c (build_fortran_types): Change name of void type to
3634         lower case.
3635         * f-typeprint.c (f_type_print_base): Print the name of the void
3636         type, rather than a fixed string.
3637         * f-valprint.c (f_decorations): Use lower case void string.
3638
3639 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3640             Chris January  <chris.january@arm.com>
3641
3642         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3643         types for Fortran.
3644
3645 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3646             Chris January  <chris.january@arm.com>
3647             David Lecomber  <david.lecomber@arm.com>
3648
3649         * f-exp.y (BINOP_INTRINSIC): New token.
3650         (exp): New parser rule handling BINOP_INTRINSIC.
3651         (f77_keywords): Add new builtin procedures.
3652         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3653         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3654         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3655         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3656         (print_unop_subexp_f): New function.
3657         (print_binop_subexp_f): New function.
3658         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3659         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3660         (dump_subexp_body_f): Likewise.
3661         (operator_check_f): Likewise.
3662         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3663         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3664
3665 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3666
3667         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3668         UNOP_KIND.
3669         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3670         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3671         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3672         (operator_length_f): New fuction.
3673         (print_subexp_f): New function.
3674         (op_name_f): New function.
3675         (dump_subexp_body_f): New function.
3676         (operator_check_f): New function.
3677         (exp_descriptor_f): Replace standard expression handling functions
3678         with new functions.
3679         * gdb/fortran-operator.def: New file.
3680         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3681         * gdb/std-operator.def: Remove UNOP_KIND.
3682
3683 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3684
3685         * std-operator.def: Remove unbalanced, stray double quote
3686         character.
3687
3688 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3689             Chris January  <chris.january@arm.com>
3690             Daniel Everett  <daniel.everett@arm.com>
3691             Nick Forrington  <nick.forrington@arm.com>
3692             Richard Bunt  <richard.bunt@arm.com>
3693
3694         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3695         of depth when printing anonymous structs or unions.
3696         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3697         Don't print either the top-level value, or the children if the
3698         max-depth is exceeded.
3699         (ppscm_print_children): When printing the key of a map, allow one
3700         extra level of depth.
3701         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3702         print either the top-level value, or the children if the max-depth
3703         is exceeded.
3704         (print_children): When printing the key of a map, allow one extra
3705         level of depth.
3706         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3707         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3708         (user_print_options): Initialise max_depth field.
3709         (val_print_scalar_or_string_type_p): New function.
3710         (val_print): Check to see if the max depth has been reached.
3711         (val_print_check_max_depth): Define new function.
3712         (show_print_max_depth): New function.
3713         (_initialize_valprint): Add 'print max-depth' option.
3714         * valprint.h (struct value_print_options) <max_depth>: New field.
3715         (val_print_check_max_depth): Declare new function.
3716         * NEWS: Document new feature.
3717
3718 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3719
3720         * ada-lang.c (ada_language_defn): Initialise new field.
3721         * c-lang.c (c_is_string_type_p): New function.
3722         (c_language_defn): Initialise new field.
3723         (cplus_language_defn): Initialise new field.
3724         (asm_language_defn): Initialise new field.
3725         (minimal_language_defn): Initialise new field.
3726         * c-lang.h (c_is_string_type_p): Declare new function.
3727         * d-lang.c (d_language_defn): Initialise new field.
3728         * f-lang.c (f_is_string_type_p): New function.
3729         (f_language_defn): Initialise new field.
3730         * go-lang.c (go_is_string_type_p): New function.
3731         (go_language_defn): Initialise new field.
3732         * language.c (default_is_string_type_p): New function.
3733         (unknown_language_defn): Initialise new field.
3734         (auto_language_defn): Initialise new field.
3735         * language.h (struct language_defn) <la_is_string_type_p>: New
3736         member variable.
3737         (default_is_string_type_p): Declare new function.
3738         * m2-lang.c (m2_language_defn): Initialise new field.
3739         * objc-lang.c (objc_language_defn): Initialise new field.
3740         * opencl-lang.c (opencl_language_defn): Initialise new field.
3741         * p-lang.c (pascal_is_string_type_p): New function.
3742         (pascal_language_defn): Initialise new field.
3743         * rust-lang.c (rust_is_string_type_p): New function.
3744         (rust_language_defn): Initialise new field.
3745
3746 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3747
3748         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3749         New field.
3750         * ada-lang.c (ada_language_defn): Initialise new field.
3751         * c-lang.c (c_language_defn): Likewise.
3752         (cplus_language_defn): Likewise.
3753         (asm_language_defn): Likewise.
3754         (minimal_language_defn): Likewise.
3755         * d-lang.c (d_language_defn): Likewise.
3756         * f-lang.c (f_language_defn): Likewise.
3757         * go-lang.c (go_language_defn): Likewise.
3758         * language.c (unknown_language_defn): Likewise.
3759         (auto_language_defn): Likewise.
3760         * m2-lang.c (m2_language_defn): Likewise.
3761         * objc-lang.c (objc_language_defn): Likewise.
3762         * opencl-lang.c (opencl_language_defn): Likewise.
3763         * p-lang.c (pascal_language_defn): Likewise.
3764         * rust-lang.c (rust_language_defn): Likewise.
3765
3766 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3767
3768         * ada-lang.c (ada_is_character_type): Change return type to bool.
3769         (ada_is_string_type): Likewise.
3770         * ada-lang.h (ada_is_character_type): Update declaration
3771         (ada_is_string_type): Likewise.
3772
3773 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3774
3775         Support style in 'frame|thread apply'
3776
3777         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3778         * record.c (record_start, record_stop): Update callers of
3779         execute_command_to_string with false.
3780         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3781         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3782         methods.
3783         (class string_file): New constructor with term_out parameter.
3784         Override methods term_out and can_emit_style_escape.  New member
3785         term_out.
3786         (class stdio_file): Override can_emit_style_escape.
3787         (class tee_file): Override term_out and can_emit_style_escape.
3788         * utils.h (can_emit_style_escape): Remove.
3789         * utils.c (can_emit_style_escape): Likewise.
3790         Update all callers of can_emit_style_escape (SOMESTREAM) to
3791         SOMESTREAM->can_emit_style_escape.
3792         * source-cache.c (source_cache::get_source_lines): Likewise.
3793         * stack.c (frame_apply_command_count): Call execute_command_to_string
3794         passing the term_out characteristic of the current gdb_stdout.
3795         * thread.c (thr_try_catch_cmd): Likewise.
3796         * top.c (execute_command_to_string): pass term_out parameter
3797         to construct the string_file for the command output.
3798         * ui-file.c (term_cli_styling): New function (most code moved
3799         from utils.c can_emit_style_escape).
3800         (string_file::string_file, string_file::can_emit_style_escape,
3801         stdio_file::can_emit_style_escape, tee_file::term_out,
3802         tee_file::can_emit_style_escape): New functions.
3803
3804 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3805
3806         * NEWS: Mention the new set|show may-call-functions.
3807         * infcall.c (may_call_functions_p): New variable.
3808         (show_may_call_functions_p): New function.
3809         (call_function_by_hand_dummy): Throws an error if not
3810         may-call-functions.
3811         (_initialize_infcall): Call add_setshow_boolean_cmd for
3812         may-call-functions.
3813
3814 2019-04-25  Keith Seitz  <keiths@redhat.com>
3815
3816         PR c++/24367
3817         * cp-support.c (inspect_type): Don't attempt substitutions
3818         of symbol with the same name.
3819
3820 2019-04-25  Tom Tromey  <tromey@adacore.com>
3821
3822         PR gdb/24475:
3823         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3824         static.
3825
3826 2019-04-25  Tom Tromey  <tromey@adacore.com>
3827
3828         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3829         rvalue reference.
3830         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3831         (gdb_xml_parser::parse): Use std::move.
3832         * python/python-internal.h (gdbpy_convert_exception): Take a const
3833         reference.
3834         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3835         std::move.
3836         * python/py-utils.c (gdbpy_convert_exception): Take a const
3837         reference.
3838         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3839         Use std::move.
3840         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3841         Use std::move.
3842         * mi/mi-main.c (mi_print_exception): Take a const reference.
3843         * main.c (handle_command_errors): Take a const reference.
3844         * linespec.c (parse_linespec): Use std::move.
3845         * infcall.c (run_inferior_call): Use std::move.
3846         (call_function_by_hand_dummy): Use std::move.
3847         * exec.c (try_open_exec_file): Use std::move.
3848         * exceptions.h (exception_print, exception_fprintf)
3849         (exception_print_same): Update.
3850         * exceptions.c (print_exception, exception_print)
3851         (exception_fprintf, exception_print_same): Change parameters to
3852         const reference.
3853         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3854         * common/new-op.c: Use std::move.
3855         * common/common-exceptions.h (struct gdb_exception): Add move
3856         constructor.
3857         (struct gdb_exception_error, struct gdb_exception_quit, struct
3858         gdb_quit_bad_alloc): Change constructor to move constructor.
3859         (throw_exception): Change parameter to rvalue reference.
3860         * common/common-exceptions.c (throw_exception): Take rvalue
3861         reference.
3862         * cli/cli-interp.c (safe_execute_command): Use std::move.
3863         * breakpoint.c (insert_bp_location, location_to_sals): Use
3864         std::move.
3865
3866 2019-04-25  Tom Tromey  <tromey@adacore.com>
3867
3868         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3869         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3870         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3871         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3872         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3873         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3874         guile/scm-value.c: Use unpack.
3875         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3876         gdbscm_gdb_exception.
3877         (gdbscm_throw_gdb_exception): Likewise.
3878         (struct gdbscm_gdb_exception): New.
3879         (unpack): New function.
3880         (gdbscm_wrap): Use unpack.
3881
3882 2019-04-25  Tom Tromey  <tromey@adacore.com>
3883
3884         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3885         (gdb_rl_callback_handler): Use std::move.
3886         * common/common-exceptions.h (struct gdb_exception): Add move
3887         assignment operator.
3888         (throw_exception_sjlj): Change "exception" to const reference.
3889         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3890         (throw_exception_sjlj): Change "exception" to const reference.
3891
3892 2019-04-25  Tom Tromey  <tromey@adacore.com>
3893
3894         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3895         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3896         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3897         Update.
3898         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3899         Update.
3900         * mi/mi-interp.c (mi_interp::exec): Update.
3901         * linespec.c (parse_linespec): Update.
3902         * infcall.c (run_inferior_call): Update.
3903         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3904         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3905         (gdbscm_lookup_global_symbol): Update.
3906         * guile/scm-param.c (gdbscm_parameter_value): Update.
3907         * guile/scm-frame.c (gdbscm_frame_read_register)
3908         (gdbscm_frame_read_var): Update.
3909         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3910         * exec.c (try_open_exec_file): Update.
3911         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3912         (gdb_rl_callback_handler): Update.
3913         * common/common-exceptions.h (exception_none): Don't declare.
3914         * common/common-exceptions.c (exception_none): Don't define.
3915         (struct catcher) <exception>: Update.
3916         * cli/cli-interp.c (safe_execute_command): Update.
3917         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3918
3919 2019-04-25  Ali Tamur  <tamur@google.com>
3920
3921         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3922         (read_attribute_value): Likewise.
3923         (dwarf2_read_addr_index): Update comment.
3924         (read_str_index): Add DW_FORM_strx.
3925         (dwarf2_string_attr): Likewise.
3926         (dwarf2_const_value_attr): Likewise.
3927         (dump_die_shallow): Likewise.
3928         (dwarf2_fetch_constant_bytes): Likewise.
3929         (skip_form_bytes): Likewise.
3930         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3931
3932 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3933
3934         PR corefiles/11608
3935         PR corefiles/18187
3936         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3937         OFFSET.  Verify if current mapping contains an ELF header.
3938         (linux_find_memory_regions_full): Adjust call to
3939         dump_mapping_p.
3940
3941 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3942             Kang Li <kanglictf@gmail.com>
3943
3944         PR gdb/21600
3945
3946         * dwarf2-frame.c (read_initial_length): Be consistent about using
3947         unsigned representation of length.
3948         (decode_frame_entry_1): Likewise.  Check for wraparound of
3949         end pointer as well as buffer overflow.
3950
3951 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3952
3953         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3954         "vq".
3955
3956 2019-04-24  Tom Tromey  <tromey@adacore.com>
3957
3958         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3959
3960 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3961
3962         * s12z-tdep.c (s12z_unwind_pc): Delete.
3963         (s12z_unwind_sp): Delete.
3964         (s12z_gdbarch_init): Don't register deleted functions with
3965         gdbarch.
3966
3967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3968
3969         * rl78-tdep.c (rl78_unwind_sp): Delete.
3970         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3971
3972 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3973
3974         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3975         (xstormy16_unwind_pc): Delete.
3976         (xstormy16_dummy_id): Delete.
3977         (xstormy16_gdbarch_init): Don't register deleted functions with
3978         gdbarch.
3979
3980 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3981
3982         * vax-tdep.c (vax_unwind_pc): Delete.
3983         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3984
3985 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3986
3987         * v850-tdep.c (v850_unwind_sp): Delete.
3988         (v850_unwind_pc): Delete.
3989         (v850_dummy_id): Delete.
3990         (v850_gdbarch_init): Don't register deleted functions with
3991         gdbarch.
3992
3993 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3994
3995         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3996         (tilegx_unwind_pc): Delete.
3997         (tilegx_unwind_dummy_id): Delete.
3998         (tilegx_gdbarch_init): Don't register deleted functions with
3999         gdbarch.
4000
4001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4002
4003         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4004         (tic6x_dummy_id): Delete.
4005         (tic6x_gdbarch_init): Don't register deleted functions with
4006         gdbarch.
4007
4008 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4009
4010         * sparc-tdep.c (sparc_unwind_pc): Delete.
4011         (sparc32_gdbarch_init): Don't register deleted function with
4012         gdbarch.
4013
4014 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4015
4016         * sh-tdep.c (sh_unwind_sp): Delete.
4017         (sh_unwind_pc): Delete.
4018         (sh_dummy_id): Delete.
4019         (sh_gdbarch_init): Don't register deleted functions with
4020         gdbarch.
4021
4022 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4023
4024         * score-tdep.c (score_unwind_sp): Delete.
4025         (score_unwind_pc): Delete.
4026         (score_dummy_id): Delete.
4027         (score_gdbarch_init): Don't register deleted functions with
4028         gdbarch.
4029
4030 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4031
4032         * rx-tdep.c (rx_unwind_pc): Delete.
4033         (rx_unwind_sp): Delete.
4034         (rx_dummy_id): Delete.
4035         (rx_gdbarch_init): Don't register deleted functions with
4036         gdbarch.  Update comment.
4037
4038 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4039
4040         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4041         (rs6000_dummy_id): Delete.
4042         (rs6000_gdbarch_init): Don't register deleted functions with
4043         gdbarch.
4044
4045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4046
4047         * or1k-tdep.c (or1k_dummy_id): Delete.
4048         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4049
4050 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4051
4052         * nios2-tdep.c (nios2_dummy_id): Delete.
4053         (nios2_unwind_sp): Delete.
4054         (nios2_gdbarch_init): Don't register deleted functions with
4055         gdbarch.
4056
4057 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4058
4059         * nds32-tdep.c (nds32_dummy_id): Delete.
4060         (nds32_unwind_pc): Delete.
4061         (nds32_unwind_sp): Delete.
4062         (nds32_gdbarch_init): Don't register deleted functions with
4063         gdbarch.
4064
4065 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4066
4067         * msp430-tdep.c (msp430_unwind_pc): Delete.
4068         (msp430_unwind_sp): Delete.
4069         (msp430_dummy_id): Delete.
4070         (msp430_gdbarch_init): Don't register deleted functions with
4071         gdbarch.
4072
4073 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4074
4075         * moxie-tdep.c (moxie_unwind_sp): Delete.
4076         (moxie_unwind_pc): Delete.
4077         (moxie_dummy_id): Delete.
4078         (moxie_gdbarch_init): Don't register deleted functions with
4079         gdbarch.
4080
4081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4082
4083         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4084         (mn10300_unwind_pc): Delete.
4085         (mn10300_unwind_sp): Delete.
4086         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4087         mn10300_unwind_sp.
4088         (mn10300_frame_unwind_init): Don't register deleted functions with
4089         gdbarch.
4090
4091 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4092
4093         * mep-tdep.c (mep_unwind_pc): Delete.
4094         (mep_unwind_sp): Delete.
4095         (mep_dummy_id): Delete.
4096         (mep_gdbarch_init): Don't register deleted functions with
4097         gdbarch.
4098
4099 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4100
4101         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4102         (m68hc11_unwind_sp): Delete.
4103         (m68hc11_gdbarch_init): Don't register deleted functions with
4104         gdbarch.
4105
4106 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4107
4108         * m32r-tdep.c (m32r_unwind_sp): Delete.
4109         (m32r_unwind_pc): Delete.
4110         (m32r_dummy_id): Delete.
4111         (m32r_gdbarch_init): Don't register deleted functions with
4112         gdbarch.
4113
4114 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4115
4116         * m32c-tdep.c (m32c_unwind_pc): Delete.
4117         (m32c_unwind_sp): Delete.
4118         (m32c_dummy_id): Delete.
4119         (m32c_gdbarch_init): Don't register deleted functions with
4120         gdbarch.
4121
4122 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4123
4124         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4125         (lm32_unwind_pc): Delete.
4126         (lm32_dummy_id): Delete.
4127         (lm32_gdbarch_init): Don't register deleted functions with
4128         gdbarch.
4129
4130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4131
4132         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4133         (iq2000_unwind_pc): Delete.
4134         (iq2000_dummy_id): Delete.
4135         (iq2000_gdbarch_init): Don't register deleted functions with
4136         gdbarch.
4137
4138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4139
4140         * nds32-tdep.c (nds32_type_align): Delete.
4141         (nds32_push_dummy_call): Use type_align instead.
4142
4143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4144
4145         * arm-tdep.c (arm_type_align): Only handle vector override case.
4146         (arm_push_dummy_call): Use type_align.
4147         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4148
4149 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4150
4151         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4152         case.
4153         (pass_on_stack): Use type_align.
4154         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4155         function.
4156
4157 2019-04-23  Tom Tromey  <tromey@adacore.com>
4158
4159         * dwarf2read.c (line_header::file_name_at): Remove unused
4160         overload.
4161
4162 2019-04-23  Tom de Vries  <tdevries@suse.de>
4163
4164         PR gdb/24438
4165         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4166         invocation.
4167
4168
4169 2019-03-27  Ali Tamur  <tamur@google.com>
4170
4171         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4172         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4173         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4174         (dwarf_expr_context::get_addr_index): Likewise
4175         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4176         (symbol_needs_eval_context::get_addr_index): Likewise
4177         (disassemble_dwarf_expression): Add DW_OP_addrx
4178         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4179         (read_cutu_die_from_dwo): Update comment
4180         (skip_one_die): Add DW_FORM_addrx
4181         (read_attribute_value): Likewise
4182         (var_decode_location): Add DW_OP_addrx
4183         (dwarf2_const_value_attr): Add DW_FORM_addrx
4184         (dump_die_shallow): Likewise
4185         (dwarf2_fetch_constant_bytes): Likewise
4186         (decode_locdesc): Add DW_OP_addrx
4187         (skip_form_bytes): Add DW_FORM_addrx
4188
4189 2019-04-22  Ali Tamur  <tamur@google.com>
4190
4191         * MAINTAINERS (Write After Approval): Add self.
4192
4193 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4194
4195         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4196         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4197         (open_symbol_file_object): Likewise.
4198         (svr4_default_sos): Add info parameter.
4199         (svr4_read_so_list): Likewise.
4200         (svr4_current_sos_direct): Adjust functions calls to pass down
4201         info.
4202         (svr4_current_sos_1): Add info parameter.
4203         (svr4_current_sos): Call get_svr4_info, pass info down to
4204         svr4_current_sos_1.
4205         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4206         get_svr4_info.
4207         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4208         get_svr4_info.
4209         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4210         to get_svr4_info.
4211         (probes_table_remove_objfile_probes): Likewise.
4212         (register_solib_event_probe): Add info parameter.
4213         (solist_update_incremental): Pass info parameter down to
4214         svr4_read_so_list.
4215         (disable_probes_interface): Add info parameter.
4216         (svr4_handle_solib_event): Pass current_program_space to
4217         get_svr4_info.  Adjust disable_probes_interface cleanup.
4218         (svr4_create_probe_breakpoints): Add info parameter, pass it
4219         down to register_solib_event_probe.
4220         (svr4_create_solib_event_breakpoints): Add info parameter,
4221         pass it down to svr4_create_probe_breakpoints.
4222         (enable_break): Pass info down to
4223         svr4_create_solib_event_breakpoints.
4224         (svr4_solib_create_inferior_hook): Pass current_program_space to
4225         get_svr4_info.
4226         (svr4_clear_solib): Likewise.
4227
4228 2019-04-22  Pedro Alves  <palves@redhat.com>
4229
4230         * solib-svr4.c (svr4_free_objfile_observer): New.
4231         (probe_and_action::objfile): New field.
4232         (probes_table_htab_remove_objfile_probes)
4233         (probes_table_remove_objfile_probes): New functions.
4234         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4235         in the new probe_and_action.  Don't store the probe in 'lookup'.
4236         (svr4_create_probe_breakpoints): Pass objfile to
4237         register_solib_event_probe.
4238         (_initialize_svr4_solib): Register a free_objfile observer.
4239
4240 2019-04-19  Tom Tromey  <tom@tromey.com>
4241
4242         * common/queue.h: Remove.
4243
4244 2019-04-19  Tom Tromey  <tom@tromey.com>
4245
4246         * event-loop.c: Don't include "common/queue.h".
4247
4248 2019-04-19  Tom Tromey  <tom@tromey.com>
4249
4250         * remote.c (remote_target): Use delete.
4251         * remote-notif.h: Include <list>, not "common/queue.h".
4252         (notif_client_p): Remove typedef.
4253         (remote_notif_state): Add constructor, destructor, initializer.
4254         <notif_queue>: Now a std::list.
4255         (remote_notif_state_xfree): Don't declare.
4256         * remote-notif.c (remote_notif_process, handle_notification)
4257         (remote_notif_state_allocate): Update.
4258         (~remote_notif_state): Rename from remote_notif_state_xfree.
4259
4260 2019-04-19  Tom Tromey  <tom@tromey.com>
4261
4262         * symfile.c (reread_symbols): Update.
4263         * objfiles.c (objfile_register_static_link)
4264         (objfile_lookup_static_link): Update
4265         (~objfile) Don't delete static_links.
4266         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4267
4268 2019-04-19  Tom Tromey  <tom@tromey.com>
4269
4270         * type-stack.h (struct type_stack) <insert>: Constify string.
4271         * type-stack.c (type_stack::insert): Constify string.
4272         * gdbtypes.h (lookup_template_type): Update.
4273         (address_space_name_to_int): Update.
4274         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4275         const.
4276         (lookup_template_type): Make name const.
4277         * c-exp.y: Update rules.
4278         (lex_one_token, classify_name, classify_inner_name)
4279         (c_print_token): Update.
4280         * p-exp.y: Update rules.
4281         (yylex): Update.
4282         * f-exp.y: Update rules.
4283         (yylex): Update.
4284         * d-exp.y: Update rules.
4285         (lex_one_token, classify_name, classify_inner_name): Update.
4286         * parse.c (write_dollar_variable, copy_name): Return std::string.
4287         * parser-defs.h (copy_name): Change return type.
4288         * m2-exp.y: Update rules.
4289         (yylex): Update.
4290         * go-exp.y (lex_one_token): Update.
4291         Update rules.
4292         (classify_unsafe_function, classify_packaged_name)
4293         (classify_name, yylex): Update.
4294
4295 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4296
4297         * configure.ac: add --enable-source-highlight switch.
4298         * configure: Regenerate.
4299         * top.c (print_gdb_version): plumb --enable-source-highlight
4300         status to "show configuration".
4301
4302 2019-04-19  Tom Tromey  <tromey@adacore.com>
4303
4304         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4305         Check ADA_TYPE_P.
4306         (empty_record, ada_template_to_fixed_record_type_1)
4307         (template_to_static_fixed_type)
4308         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4309         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4310         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4311         macros.
4312
4313 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4314
4315         PR symtab/24423:
4316         * source.c (print_source_lines_base): Advance "iter" when a
4317         control character is seen.
4318
4319 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4320
4321         * inferior.h (struct infcall_suspend_state_deleter):
4322         Catch exception in destructor to avoid crash.
4323
4324 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4325
4326         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4327         close to the add_com "shell".
4328
4329 2019-04-18  Tom Tromey  <tromey@adacore.com>
4330
4331         * process-stratum-target.h (class process_stratum_target)
4332         <stratum>: Add "final".
4333
4334 2019-04-17  Tom Tromey  <tromey@adacore.com>
4335
4336         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4337         against nullptr before use.
4338
4339 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4340
4341         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4342
4343 2019-04-17  Jim Wilson  <jimw@sifive.com>
4344             Andrew Burgess  <andrew.burgess@embecosm.com>
4345
4346         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4347         code read might fail, assume 4-byte breakpoint in that case.
4348
4349 2019-04-15  Leszek Swirski  <leszeks@google.com>
4350
4351         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4352         rather than a hand-rolled POD check when checking for forced MEMORY
4353         classification.
4354
4355 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4356
4357         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4358         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4359         function.
4360         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4361         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4362         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4363         declaration.
4364
4365 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4366
4367         * aarch64-linux-nat.c
4368         (aarch64_linux_nat_target::thread_architecture): Add override.
4369         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4370         each VQ.
4371
4372 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4373
4374         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4375
4376 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4377
4378         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4379         target types of size 96-bits, add some additional comments, and
4380         check that the builtin type we found was the correct size.
4381
4382 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4383
4384         * utils.c (prompt_for_continue): Don't restore the styling at the
4385         end, as applied_style has the wrong value.  This fixes styling in
4386         long lists of file names that are interrupted by the "Continue?"
4387         prompt.
4388
4389 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4390
4391         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4392         * c-lang.c (c_language_defn): Likewise.
4393         (cplus_language_defn): Likewise.
4394         (asm_language_defn): Likewise.
4395         (minimal_language_defn): Likewise.
4396         * d-lang.c (d_language_defn): Likewise.
4397         * f-lang.c (f_language_defn): Likewise.
4398         * go-lang.c (go_language_defn): Likewise.
4399         * language.c (unknown_language_defn): Likewise.
4400         (auto_language_defn): Likewise.
4401         * language.h (struct language_defn): Remove la_magic field.
4402         (LANG_MAGIC): Delete.
4403         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4404         * objc-lang.c (objc_language_defn): Likewise.
4405         * opencl-lang.c (opencl_language_defn): Likewise.
4406         * p-lang.c (pascal_language_defn): Likewise.
4407         * rust-lang.c (rust_language_defn): Likewise.
4408
4409 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4410
4411         * riscv-tdep.c (riscv_type_align): New function.
4412         (riscv_type_alignment): Delete.
4413         (riscv_arg_location): Use 'type_align'.
4414         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4415
4416 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4417
4418         * gdbtypes.c (type_align): A struct with no non-static fields also
4419         has alignment of 1.
4420
4421 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4422
4423         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4424         component to 0.
4425         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4426         member.
4427         (riscv_struct_info::analyse): New implementation using new
4428         analyse_inner member function.
4429         (riscv_struct_info::field_offset): New member function.
4430         (riscv_struct_info::m_offsets): New member variable.
4431         (riscv_struct_info::analyse_inner): New private member function,
4432         takes the old implementation of riscv_struct_info::analyse but
4433         extended to track field offsets.
4434         (riscv_call_arg_struct): Update the struct folding special cases
4435         to handle cases where empty C++ structs, which are non-zero
4436         length, are found.
4437         (riscv_arg_location): Initialise the length of each location, a
4438         non-zero length now indicates the location is in use.
4439         (riscv_push_dummy_call): Allow for the first location having a
4440         non-zero offset when setting up arguments.
4441         (riscv_return_value): Likewise, but for return values.
4442
4443 2019-04-11  Tom Tromey  <tromey@adacore.com>
4444
4445         * utils.c (internal_vproblem): Make "msg" const.
4446
4447 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4448
4449         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4450         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4451         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4452         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4453
4454 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4455
4456         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4457         function.
4458         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4459         of amd64_collect_native_gregset.
4460         (amd64_linux_nat_target::store_registers): Likewise.
4461
4462 2019-04-10  Tom Tromey  <tom@tromey.com>
4463
4464         * symtab.c (lookup_global_symbol_from_objfile)
4465         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4466         * objfiles.h (class separate_debug_iterator): New.
4467         (class separate_debug_range): New.
4468         (struct objfile) <separate_debug_objfiles>: New method.
4469         (objfile_separate_debug_iterate): Don't declare.
4470         * objfiles.c (separate_debug_iterator::operator++): Rename from
4471         objfile_separate_debug_iterate.
4472         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4473         iterator.
4474         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4475         iterator.
4476
4477 2019-04-10  Tom Tromey  <tom@tromey.com>
4478
4479         * symfile.c (reread_symbols): Remove old comment.
4480         * objfiles.c (free_all_objfiles): Fix a typo.
4481
4482 2019-04-10  Tom Tromey  <tom@tromey.com>
4483
4484         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4485         * minsyms.c (lookup_minimal_symbol): Use foreach.
4486         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4487         (lookup_minimal_symbol_solib_trampoline): Likewise.
4488         * symfile.c (reread_symbols): Use foreach.
4489
4490 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4491             Tom Tromey  <tromey@adacore.com>
4492
4493         PR rust/24414:
4494         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4495         (rust_lex_int_test): Change "value" to be LONGEST.
4496         (rust_lex_tests): Add test for long integer literal.
4497
4498 2019-04-09  Tom Tromey  <tromey@adacore.com>
4499
4500         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4501         to bool.
4502         (extended_remote_target::attach): Update.
4503         (remote_target::remote_notice_new_inferior): Update.
4504         (remote_target::add_current_inferior_and_thread): Update.
4505         * inferior.c (exit_inferior_1): Use "false".
4506         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4507
4508 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4509
4510         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4511         the "start" command.
4512
4513 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4514
4515         * python/py-inferior.c (infpy_thread_from_thread_handle):
4516         Adjust comments to reflect renaming of thread_from_thread_handle
4517         to thread_from_handle.  Adjust keywords.  Fix type error message.
4518         (inferior_object_methods): Add thread_from_handle.  Retain
4519         thread_from_thread_handle, but mark it as deprecated.
4520
4521 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4522
4523         * gdbthread.h (find_thread_by_handle): Revise declaration.
4524         * thread.c (find_thread_by_handle): Likewise.  Adjust
4525         implementation too.
4526         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4527         support for buffer objects as handles.
4528
4529 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4530
4531         * python/py-infthread.c (thpy_thread_handle): New function.
4532         (thread_object_methods): Register thpy_thread_handle.
4533
4534 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4535
4536         * gdbthread.h (thread_to_thread_handle): Declare.
4537         * thread.c (gdbtypes.h): Include.
4538         (thread_to_thread_handle): New function.
4539
4540         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4541         (target_thread_info_to_thread_handle): Declare.
4542         * target.c (target_thread_info_to_thread_handle): New function.
4543         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4544         * target-delegates.c: Regenerate.
4545
4546         * linux-thread-db.c (class thread_db_target): Add method
4547         thread_info_to_thread_handle.
4548         (thread_db_target::thread_info_to_thread_handle): Define.
4549         * remote.c (class remote_target): Add new method
4550         thread_info_to_thread_handle.
4551         (remote_target::thread_info_to_thread_handle): Define.
4552
4553 2019-04-08  Pedro Alves  <palves@redhat.com>
4554
4555         * common/common-exceptions.c (throw_exception): Don't create
4556         named object to throw; throw directly.
4557         (throw_it): Likewise.  Don't initialize gdb_exception::message
4558         here, with new; pass FMT and AP to the ctor instead.
4559         * common/common-exceptions.h: Include <string>.
4560         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4561         const char *, va_list)): New ctor.  Use std::make_shared.
4562         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4563         errors)): Delete.
4564         (gdb_exception_error::gdb_exception_error(enum errors, const char
4565         *, va_list)): New.
4566         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4567         Add assertion.
4568         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4569         errors)): Delete.
4570         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4571         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4572         Add assertion.
4573
4574 2019-04-08  Tom Tromey  <tom@tromey.com>
4575
4576         * valops.c (value_rtti_indirect_type): Replace throw_exception
4577         with throw.
4578         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4579         with throw.
4580         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4581         throw.
4582         * target.c (target_translate_tls_address): Replace throw_exception
4583         with throw.
4584         * stack.c (frame_apply_command_count): Replace throw_exception
4585         with throw.
4586         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4587         throw.
4588         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4589         with throw.
4590         * rs6000-tdep.c (rs6000_frame_cache)
4591         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4592         * remote.c: Replace throw_exception with throw.
4593         * record-full.c (record_full_message, record_full_wait_1)
4594         (record_full_restore): Replace throw_exception with throw.
4595         * record-btrace.c:
4596         (get_thread_current_frame_id, record_btrace_start_replaying)
4597         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4598         (cmd_record_btrace_start): Replace throw_exception with throw.
4599         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4600         throw.
4601         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4602         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4603         * linespec.c:
4604         (find_linespec_symbols): Replace throw_exception with throw.
4605         * infrun.c (displaced_step_prepare, resume): Replace
4606         throw_exception with throw.
4607         * infcmd.c (post_create_inferior): Replace throw_exception with
4608         throw.
4609         * inf-loop.c (inferior_event_handler): Replace throw_exception
4610         with throw.
4611         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4612         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4613         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4614         (get_prev_frame_always, get_frame_pc_if_available)
4615         (get_frame_address_in_block_if_available, get_frame_language):
4616         Replace throw_exception with throw.
4617         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4618         throw_exception with throw.
4619         * eval.c (fetch_subexp_value, evaluate_var_value)
4620         (evaluate_funcall, evaluate_subexp_standard): Replace
4621         throw_exception with throw.
4622         * dwarf2loc.c (call_site_find_chain)
4623         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4624         Replace throw_exception with throw.
4625         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4626         with throw.
4627         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4628         throw.
4629         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4630         * completer.c (complete_line_internal): Replace throw_exception
4631         with throw.
4632         * compile/compile-object-run.c (compile_object_run): Replace
4633         throw_exception with throw.
4634         * cli/cli-script.c (process_next_line): Replace throw_exception
4635         with throw.
4636         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4637         (btrace_enable, btrace_maint_update_pt_packets): Replace
4638         throw_exception with throw.
4639         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4640         throw_exception with throw.
4641         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4642         throw_exception with throw.
4643         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4644         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4645         * aarch64-tdep.c (aarch64_make_prologue_cache)
4646         (aarch64_make_stub_cache): Replace throw_exception with throw.
4647
4648 2019-04-08  Tom Tromey  <tom@tromey.com>
4649
4650         * common/common-exceptions.c (throw_exception): Rename from
4651         throw_exception_cxx.  Remove old copy.  Make argument const.
4652         (throw_it): Create and throw exception objects directly.
4653         * common/common-exceptions.h (throw_exception): Make argument
4654         const.
4655         (struct gdb_exception_error): Add constructor.
4656         (struct gdb_exception_quit): Add constructor.
4657
4658 2019-04-08  Tom Tromey  <tom@tromey.com>
4659
4660         * common/common-exceptions.h (exception_rethrow): Don't declare.
4661         (TRY_SJLJ): Update comment.
4662         (TRY, CATCH, END_CATCH): Remove.
4663         * common/common-exceptions.c (exception_rethrow): Remove.
4664
4665 2019-04-08  Tom Tromey  <tom@tromey.com>
4666
4667         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4668         Remove.
4669         (gdb_exception_error): Rename from
4670         gdb_exception_RETURN_MASK_ERROR.
4671         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4672         (gdb_quit_bad_alloc): Update.
4673         * aarch64-tdep.c: Update.
4674         * ada-lang.c: Update.
4675         * ada-typeprint.c: Update.
4676         * ada-valprint.c: Update.
4677         * amd64-tdep.c: Update.
4678         * arch-utils.c: Update.
4679         * break-catch-throw.c: Update.
4680         * breakpoint.c: Update.
4681         * btrace.c: Update.
4682         * c-varobj.c: Update.
4683         * cli/cli-cmds.c: Update.
4684         * cli/cli-interp.c: Update.
4685         * cli/cli-script.c: Update.
4686         * common/common-exceptions.c: Update.
4687         * common/new-op.c: Update.
4688         * common/selftest.c: Update.
4689         * compile/compile-c-symbols.c: Update.
4690         * compile/compile-cplus-symbols.c: Update.
4691         * compile/compile-object-load.c: Update.
4692         * compile/compile-object-run.c: Update.
4693         * completer.c: Update.
4694         * corelow.c: Update.
4695         * cp-abi.c: Update.
4696         * cp-support.c: Update.
4697         * cp-valprint.c: Update.
4698         * darwin-nat.c: Update.
4699         * disasm-selftests.c: Update.
4700         * dtrace-probe.c: Update.
4701         * dwarf-index-cache.c: Update.
4702         * dwarf-index-write.c: Update.
4703         * dwarf2-frame-tailcall.c: Update.
4704         * dwarf2-frame.c: Update.
4705         * dwarf2loc.c: Update.
4706         * dwarf2read.c: Update.
4707         * eval.c: Update.
4708         * event-loop.c: Update.
4709         * event-top.c: Update.
4710         * exec.c: Update.
4711         * f-valprint.c: Update.
4712         * fbsd-tdep.c: Update.
4713         * frame-unwind.c: Update.
4714         * frame.c: Update.
4715         * gdbtypes.c: Update.
4716         * gnu-v3-abi.c: Update.
4717         * guile/guile-internal.h: Update.
4718         * guile/scm-block.c: Update.
4719         * guile/scm-breakpoint.c: Update.
4720         * guile/scm-cmd.c: Update.
4721         * guile/scm-disasm.c: Update.
4722         * guile/scm-frame.c: Update.
4723         * guile/scm-lazy-string.c: Update.
4724         * guile/scm-math.c: Update.
4725         * guile/scm-param.c: Update.
4726         * guile/scm-ports.c: Update.
4727         * guile/scm-pretty-print.c: Update.
4728         * guile/scm-symbol.c: Update.
4729         * guile/scm-symtab.c: Update.
4730         * guile/scm-type.c: Update.
4731         * guile/scm-value.c: Update.
4732         * i386-linux-tdep.c: Update.
4733         * i386-tdep.c: Update.
4734         * inf-loop.c: Update.
4735         * infcall.c: Update.
4736         * infcmd.c: Update.
4737         * infrun.c: Update.
4738         * jit.c: Update.
4739         * language.c: Update.
4740         * linespec.c: Update.
4741         * linux-fork.c: Update.
4742         * linux-nat.c: Update.
4743         * linux-tdep.c: Update.
4744         * linux-thread-db.c: Update.
4745         * main.c: Update.
4746         * mi/mi-cmd-break.c: Update.
4747         * mi/mi-cmd-stack.c: Update.
4748         * mi/mi-interp.c: Update.
4749         * mi/mi-main.c: Update.
4750         * objc-lang.c: Update.
4751         * p-valprint.c: Update.
4752         * parse.c: Update.
4753         * ppc-linux-tdep.c: Update.
4754         * printcmd.c: Update.
4755         * python/py-arch.c: Update.
4756         * python/py-breakpoint.c: Update.
4757         * python/py-cmd.c: Update.
4758         * python/py-finishbreakpoint.c: Update.
4759         * python/py-frame.c: Update.
4760         * python/py-framefilter.c: Update.
4761         * python/py-gdb-readline.c: Update.
4762         * python/py-inferior.c: Update.
4763         * python/py-infthread.c: Update.
4764         * python/py-lazy-string.c: Update.
4765         * python/py-linetable.c: Update.
4766         * python/py-objfile.c: Update.
4767         * python/py-param.c: Update.
4768         * python/py-prettyprint.c: Update.
4769         * python/py-progspace.c: Update.
4770         * python/py-record-btrace.c: Update.
4771         * python/py-record.c: Update.
4772         * python/py-symbol.c: Update.
4773         * python/py-type.c: Update.
4774         * python/py-unwind.c: Update.
4775         * python/py-utils.c: Update.
4776         * python/py-value.c: Update.
4777         * python/python.c: Update.
4778         * record-btrace.c: Update.
4779         * record-full.c: Update.
4780         * remote-fileio.c: Update.
4781         * remote.c: Update.
4782         * riscv-tdep.c: Update.
4783         * rs6000-aix-tdep.c: Update.
4784         * rs6000-tdep.c: Update.
4785         * rust-exp.y: Update.
4786         * rust-lang.c: Update.
4787         * s390-tdep.c: Update.
4788         * selftest-arch.c: Update.
4789         * solib-dsbt.c: Update.
4790         * solib-frv.c: Update.
4791         * solib-spu.c: Update.
4792         * solib-svr4.c: Update.
4793         * solib.c: Update.
4794         * sparc64-linux-tdep.c: Update.
4795         * stack.c: Update.
4796         * symfile-mem.c: Update.
4797         * symmisc.c: Update.
4798         * target.c: Update.
4799         * thread.c: Update.
4800         * top.c: Update.
4801         * tracefile-tfile.c: Update.
4802         * tui/tui.c: Update.
4803         * typeprint.c: Update.
4804         * unittests/cli-utils-selftests.c: Update.
4805         * unittests/parse-connection-spec-selftests.c: Update.
4806         * valops.c: Update.
4807         * valprint.c: Update.
4808         * value.c: Update.
4809         * varobj.c: Update.
4810         * windows-nat.c: Update.
4811         * x86-linux-nat.c: Update.
4812         * xml-support.c: Update.
4813
4814 2019-04-08  Tom Tromey  <tom@tromey.com>
4815
4816         * xml-support.c: Use C++ exception handling.
4817         * x86-linux-nat.c: Use C++ exception handling.
4818         * windows-nat.c: Use C++ exception handling.
4819         * varobj.c: Use C++ exception handling.
4820         * value.c: Use C++ exception handling.
4821         * valprint.c: Use C++ exception handling.
4822         * valops.c: Use C++ exception handling.
4823         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4824         handling.
4825         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4826         * typeprint.c: Use C++ exception handling.
4827         * tui/tui.c: Use C++ exception handling.
4828         * tracefile-tfile.c: Use C++ exception handling.
4829         * top.c: Use C++ exception handling.
4830         * thread.c: Use C++ exception handling.
4831         * target.c: Use C++ exception handling.
4832         * symmisc.c: Use C++ exception handling.
4833         * symfile-mem.c: Use C++ exception handling.
4834         * stack.c: Use C++ exception handling.
4835         * sparc64-linux-tdep.c: Use C++ exception handling.
4836         * solib.c: Use C++ exception handling.
4837         * solib-svr4.c: Use C++ exception handling.
4838         * solib-spu.c: Use C++ exception handling.
4839         * solib-frv.c: Use C++ exception handling.
4840         * solib-dsbt.c: Use C++ exception handling.
4841         * selftest-arch.c: Use C++ exception handling.
4842         * s390-tdep.c: Use C++ exception handling.
4843         * rust-lang.c: Use C++ exception handling.
4844         * rust-exp.y: Use C++ exception handling.
4845         * rs6000-tdep.c: Use C++ exception handling.
4846         * rs6000-aix-tdep.c: Use C++ exception handling.
4847         * riscv-tdep.c: Use C++ exception handling.
4848         * remote.c: Use C++ exception handling.
4849         * remote-fileio.c: Use C++ exception handling.
4850         * record-full.c: Use C++ exception handling.
4851         * record-btrace.c: Use C++ exception handling.
4852         * python/python.c: Use C++ exception handling.
4853         * python/py-value.c: Use C++ exception handling.
4854         * python/py-utils.c: Use C++ exception handling.
4855         * python/py-unwind.c: Use C++ exception handling.
4856         * python/py-type.c: Use C++ exception handling.
4857         * python/py-symbol.c: Use C++ exception handling.
4858         * python/py-record.c: Use C++ exception handling.
4859         * python/py-record-btrace.c: Use C++ exception handling.
4860         * python/py-progspace.c: Use C++ exception handling.
4861         * python/py-prettyprint.c: Use C++ exception handling.
4862         * python/py-param.c: Use C++ exception handling.
4863         * python/py-objfile.c: Use C++ exception handling.
4864         * python/py-linetable.c: Use C++ exception handling.
4865         * python/py-lazy-string.c: Use C++ exception handling.
4866         * python/py-infthread.c: Use C++ exception handling.
4867         * python/py-inferior.c: Use C++ exception handling.
4868         * python/py-gdb-readline.c: Use C++ exception handling.
4869         * python/py-framefilter.c: Use C++ exception handling.
4870         * python/py-frame.c: Use C++ exception handling.
4871         * python/py-finishbreakpoint.c: Use C++ exception handling.
4872         * python/py-cmd.c: Use C++ exception handling.
4873         * python/py-breakpoint.c: Use C++ exception handling.
4874         * python/py-arch.c: Use C++ exception handling.
4875         * printcmd.c: Use C++ exception handling.
4876         * ppc-linux-tdep.c: Use C++ exception handling.
4877         * parse.c: Use C++ exception handling.
4878         * p-valprint.c: Use C++ exception handling.
4879         * objc-lang.c: Use C++ exception handling.
4880         * mi/mi-main.c: Use C++ exception handling.
4881         * mi/mi-interp.c: Use C++ exception handling.
4882         * mi/mi-cmd-stack.c: Use C++ exception handling.
4883         * mi/mi-cmd-break.c: Use C++ exception handling.
4884         * main.c: Use C++ exception handling.
4885         * linux-thread-db.c: Use C++ exception handling.
4886         * linux-tdep.c: Use C++ exception handling.
4887         * linux-nat.c: Use C++ exception handling.
4888         * linux-fork.c: Use C++ exception handling.
4889         * linespec.c: Use C++ exception handling.
4890         * language.c: Use C++ exception handling.
4891         * jit.c: Use C++ exception handling.
4892         * infrun.c: Use C++ exception handling.
4893         * infcmd.c: Use C++ exception handling.
4894         * infcall.c: Use C++ exception handling.
4895         * inf-loop.c: Use C++ exception handling.
4896         * i386-tdep.c: Use C++ exception handling.
4897         * i386-linux-tdep.c: Use C++ exception handling.
4898         * guile/scm-value.c: Use C++ exception handling.
4899         * guile/scm-type.c: Use C++ exception handling.
4900         * guile/scm-symtab.c: Use C++ exception handling.
4901         * guile/scm-symbol.c: Use C++ exception handling.
4902         * guile/scm-pretty-print.c: Use C++ exception handling.
4903         * guile/scm-ports.c: Use C++ exception handling.
4904         * guile/scm-param.c: Use C++ exception handling.
4905         * guile/scm-math.c: Use C++ exception handling.
4906         * guile/scm-lazy-string.c: Use C++ exception handling.
4907         * guile/scm-frame.c: Use C++ exception handling.
4908         * guile/scm-disasm.c: Use C++ exception handling.
4909         * guile/scm-cmd.c: Use C++ exception handling.
4910         * guile/scm-breakpoint.c: Use C++ exception handling.
4911         * guile/scm-block.c: Use C++ exception handling.
4912         * guile/guile-internal.h: Use C++ exception handling.
4913         * gnu-v3-abi.c: Use C++ exception handling.
4914         * gdbtypes.c: Use C++ exception handling.
4915         * frame.c: Use C++ exception handling.
4916         * frame-unwind.c: Use C++ exception handling.
4917         * fbsd-tdep.c: Use C++ exception handling.
4918         * f-valprint.c: Use C++ exception handling.
4919         * exec.c: Use C++ exception handling.
4920         * event-top.c: Use C++ exception handling.
4921         * event-loop.c: Use C++ exception handling.
4922         * eval.c: Use C++ exception handling.
4923         * dwarf2read.c: Use C++ exception handling.
4924         * dwarf2loc.c: Use C++ exception handling.
4925         * dwarf2-frame.c: Use C++ exception handling.
4926         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4927         * dwarf-index-write.c: Use C++ exception handling.
4928         * dwarf-index-cache.c: Use C++ exception handling.
4929         * dtrace-probe.c: Use C++ exception handling.
4930         * disasm-selftests.c: Use C++ exception handling.
4931         * darwin-nat.c: Use C++ exception handling.
4932         * cp-valprint.c: Use C++ exception handling.
4933         * cp-support.c: Use C++ exception handling.
4934         * cp-abi.c: Use C++ exception handling.
4935         * corelow.c: Use C++ exception handling.
4936         * completer.c: Use C++ exception handling.
4937         * compile/compile-object-run.c: Use C++ exception handling.
4938         * compile/compile-object-load.c: Use C++ exception handling.
4939         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4940         * compile/compile-c-symbols.c: Use C++ exception handling.
4941         * common/selftest.c: Use C++ exception handling.
4942         * common/new-op.c: Use C++ exception handling.
4943         * cli/cli-script.c: Use C++ exception handling.
4944         * cli/cli-interp.c: Use C++ exception handling.
4945         * cli/cli-cmds.c: Use C++ exception handling.
4946         * c-varobj.c: Use C++ exception handling.
4947         * btrace.c: Use C++ exception handling.
4948         * breakpoint.c: Use C++ exception handling.
4949         * break-catch-throw.c: Use C++ exception handling.
4950         * arch-utils.c: Use C++ exception handling.
4951         * amd64-tdep.c: Use C++ exception handling.
4952         * ada-valprint.c: Use C++ exception handling.
4953         * ada-typeprint.c: Use C++ exception handling.
4954         * ada-lang.c: Use C++ exception handling.
4955         * aarch64-tdep.c: Use C++ exception handling.
4956
4957 2019-04-08  Tom Tromey  <tom@tromey.com>
4958
4959         * xml-support.c (gdb_xml_parser::parse): Update.
4960         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4961         * value.c (show_convenience): Update.
4962         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4963         (test_parse_flags_qcs): Update.
4964         * thread.c (thr_try_catch_cmd): Update.
4965         * target.c (target_translate_tls_address): Update.
4966         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4967         (info_frame_command_core, frame_apply_command_count): Update.
4968         * rust-exp.y (rust_lex_exception_test): Update.
4969         * riscv-tdep.c (riscv_print_one_register_info): Update.
4970         * remote.c (remote_target::enable_btrace): Update.
4971         * record-btrace.c (record_btrace_enable_warn): Update.
4972         * python/py-utils.c (gdbpy_convert_exception): Update.
4973         * printcmd.c (do_one_display, print_variable_and_value): Update.
4974         * mi/mi-main.c (mi_print_exception): Update.
4975         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4976         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4977         * linux-nat.c (linux_nat_target::attach): Update.
4978         * linux-fork.c (class scoped_switch_fork_info): Update.
4979         * infrun.c (displaced_step_prepare): Update.
4980         * infcall.c (call_function_by_hand_dummy): Update.
4981         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4982         * gnu-v3-abi.c (print_one_vtable): Update.
4983         * frame.c (get_prev_frame_always): Update.
4984         * f-valprint.c (info_common_command_for_block): Update.
4985         * exec.c (try_open_exec_file): Update.
4986         * exceptions.c (print_exception, exception_print)
4987         (exception_fprintf, exception_print_same): Update.
4988         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4989         * dwarf-index-cache.c (index_cache::store)
4990         (index_cache::lookup_gdb_index): Update.
4991         * darwin-nat.c (maybe_cache_shell): Update.
4992         * cp-valprint.c (cp_print_value_fields): Update.
4993         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4994         (gcc_cplus_symbol_address): Update.
4995         * compile/compile-c-symbols.c (gcc_convert_symbol)
4996         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4997         * common/selftest.c: Update.
4998         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4999         a std::string.
5000         (exception_try_scope_entry, exception_try_scope_exit): Don't
5001         declare.
5002         (struct exception_try_scope): Remove.
5003         (TRY): Don't use exception_try_scope.
5004         (struct gdb_exception): Add constructor, operator=.
5005         <what>: New method.
5006         (struct gdb_exception_RETURN_MASK_ALL)
5007         (struct gdb_exception_RETURN_MASK_ERROR)
5008         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5009         (struct gdb_quit_bad_alloc): Update.
5010         * common/common-exceptions.c (exception_none): Change
5011         initializer.
5012         (struct catcher) <state, exception>: Initialize inline.
5013         <prev>: Remove member.
5014         (current_catcher): Remove.
5015         (catchers): New global.
5016         (exceptions_state_mc_init): Simplify.
5017         (catcher_pop): Remove.
5018         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5019         (try_scope_depth, exception_try_scope_entry)
5020         (exception_try_scope_exit): Remove.
5021         (throw_exception_sjlj): Update.
5022         (exception_messages, exception_messages_size): Remove.
5023         (throw_it): Simplify.
5024         (gdb_exception_sliced_copy): Remove.
5025         (throw_exception_cxx): Update.
5026         * cli/cli-script.c (script_from_file): Update.
5027         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5028         Update.
5029         * ada-valprint.c (ada_val_print): Update.
5030         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5031         (create_excep_cond_exprs): Update.
5032
5033 2019-04-08  Tom Tromey  <tom@tromey.com>
5034
5035         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5036         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5037         (TRY, CATCH, END_CATCH): Remove some definitions.
5038         * common/common-exceptions.c: Don't use GDB_XCPT.
5039         (catcher_list_size): Remove.
5040         (throw_exception, throw_it): Simplify.
5041
5042 2019-04-05  Tom Tromey  <tom@tromey.com>
5043
5044         Revert the header-sorting patch.
5045         * ft32-tdep.c: Revert.
5046         * frv-tdep.c: Revert.
5047         * frv-linux-tdep.c: Revert.
5048         * frame.c: Revert.
5049         * frame-unwind.c: Revert.
5050         * frame-base.c: Revert.
5051         * fork-child.c: Revert.
5052         * findvar.c: Revert.
5053         * findcmd.c: Revert.
5054         * filesystem.c: Revert.
5055         * filename-seen-cache.h: Revert.
5056         * filename-seen-cache.c: Revert.
5057         * fbsd-tdep.c: Revert.
5058         * fbsd-nat.h: Revert.
5059         * fbsd-nat.c: Revert.
5060         * f-valprint.c: Revert.
5061         * f-typeprint.c: Revert.
5062         * f-lang.c: Revert.
5063         * extension.h: Revert.
5064         * extension.c: Revert.
5065         * extension-priv.h: Revert.
5066         * expprint.c: Revert.
5067         * exec.h: Revert.
5068         * exec.c: Revert.
5069         * exceptions.c: Revert.
5070         * event-top.c: Revert.
5071         * event-loop.c: Revert.
5072         * eval.c: Revert.
5073         * elfread.c: Revert.
5074         * dwarf2read.h: Revert.
5075         * dwarf2read.c: Revert.
5076         * dwarf2loc.c: Revert.
5077         * dwarf2expr.h: Revert.
5078         * dwarf2expr.c: Revert.
5079         * dwarf2-frame.c: Revert.
5080         * dwarf2-frame-tailcall.c: Revert.
5081         * dwarf-index-write.h: Revert.
5082         * dwarf-index-write.c: Revert.
5083         * dwarf-index-common.c: Revert.
5084         * dwarf-index-cache.h: Revert.
5085         * dwarf-index-cache.c: Revert.
5086         * dummy-frame.c: Revert.
5087         * dtrace-probe.c: Revert.
5088         * disasm.h: Revert.
5089         * disasm.c: Revert.
5090         * disasm-selftests.c: Revert.
5091         * dictionary.c: Revert.
5092         * dicos-tdep.c: Revert.
5093         * demangle.c: Revert.
5094         * dcache.h: Revert.
5095         * dcache.c: Revert.
5096         * darwin-nat.h: Revert.
5097         * darwin-nat.c: Revert.
5098         * darwin-nat-info.c: Revert.
5099         * d-valprint.c: Revert.
5100         * d-namespace.c: Revert.
5101         * d-lang.c: Revert.
5102         * ctf.c: Revert.
5103         * csky-tdep.c: Revert.
5104         * csky-linux-tdep.c: Revert.
5105         * cris-tdep.c: Revert.
5106         * cris-linux-tdep.c: Revert.
5107         * cp-valprint.c: Revert.
5108         * cp-support.c: Revert.
5109         * cp-namespace.c: Revert.
5110         * cp-abi.c: Revert.
5111         * corelow.c: Revert.
5112         * corefile.c: Revert.
5113         * continuations.c: Revert.
5114         * completer.h: Revert.
5115         * completer.c: Revert.
5116         * complaints.c: Revert.
5117         * coffread.c: Revert.
5118         * coff-pe-read.c: Revert.
5119         * cli-out.h: Revert.
5120         * cli-out.c: Revert.
5121         * charset.c: Revert.
5122         * c-varobj.c: Revert.
5123         * c-valprint.c: Revert.
5124         * c-typeprint.c: Revert.
5125         * c-lang.c: Revert.
5126         * buildsym.c: Revert.
5127         * buildsym-legacy.c: Revert.
5128         * build-id.h: Revert.
5129         * build-id.c: Revert.
5130         * btrace.c: Revert.
5131         * bsd-uthread.c: Revert.
5132         * breakpoint.h: Revert.
5133         * breakpoint.c: Revert.
5134         * break-catch-throw.c: Revert.
5135         * break-catch-syscall.c: Revert.
5136         * break-catch-sig.c: Revert.
5137         * blockframe.c: Revert.
5138         * block.c: Revert.
5139         * bfin-tdep.c: Revert.
5140         * bfin-linux-tdep.c: Revert.
5141         * bfd-target.c: Revert.
5142         * bcache.c: Revert.
5143         * ax-general.c: Revert.
5144         * ax-gdb.h: Revert.
5145         * ax-gdb.c: Revert.
5146         * avr-tdep.c: Revert.
5147         * auxv.c: Revert.
5148         * auto-load.c: Revert.
5149         * arm-wince-tdep.c: Revert.
5150         * arm-tdep.c: Revert.
5151         * arm-symbian-tdep.c: Revert.
5152         * arm-pikeos-tdep.c: Revert.
5153         * arm-obsd-tdep.c: Revert.
5154         * arm-nbsd-tdep.c: Revert.
5155         * arm-nbsd-nat.c: Revert.
5156         * arm-linux-tdep.c: Revert.
5157         * arm-linux-nat.c: Revert.
5158         * arm-fbsd-tdep.c: Revert.
5159         * arm-fbsd-nat.c: Revert.
5160         * arm-bsd-tdep.c: Revert.
5161         * arch-utils.c: Revert.
5162         * arc-tdep.c: Revert.
5163         * arc-newlib-tdep.c: Revert.
5164         * annotate.h: Revert.
5165         * annotate.c: Revert.
5166         * amd64-windows-tdep.c: Revert.
5167         * amd64-windows-nat.c: Revert.
5168         * amd64-tdep.c: Revert.
5169         * amd64-sol2-tdep.c: Revert.
5170         * amd64-obsd-tdep.c: Revert.
5171         * amd64-obsd-nat.c: Revert.
5172         * amd64-nbsd-tdep.c: Revert.
5173         * amd64-nbsd-nat.c: Revert.
5174         * amd64-nat.c: Revert.
5175         * amd64-linux-tdep.c: Revert.
5176         * amd64-linux-nat.c: Revert.
5177         * amd64-fbsd-tdep.c: Revert.
5178         * amd64-fbsd-nat.c: Revert.
5179         * amd64-dicos-tdep.c: Revert.
5180         * amd64-darwin-tdep.c: Revert.
5181         * amd64-bsd-nat.c: Revert.
5182         * alpha-tdep.c: Revert.
5183         * alpha-obsd-tdep.c: Revert.
5184         * alpha-nbsd-tdep.c: Revert.
5185         * alpha-mdebug-tdep.c: Revert.
5186         * alpha-linux-tdep.c: Revert.
5187         * alpha-linux-nat.c: Revert.
5188         * alpha-bsd-tdep.c: Revert.
5189         * alpha-bsd-nat.c: Revert.
5190         * aix-thread.c: Revert.
5191         * agent.c: Revert.
5192         * addrmap.c: Revert.
5193         * ada-varobj.c: Revert.
5194         * ada-valprint.c: Revert.
5195         * ada-typeprint.c: Revert.
5196         * ada-tasks.c: Revert.
5197         * ada-lang.c: Revert.
5198         * aarch64-tdep.c: Revert.
5199         * aarch64-ravenscar-thread.c: Revert.
5200         * aarch64-newlib-tdep.c: Revert.
5201         * aarch64-linux-tdep.c: Revert.
5202         * aarch64-linux-nat.c: Revert.
5203         * aarch64-fbsd-tdep.c: Revert.
5204         * aarch64-fbsd-nat.c: Revert.
5205         * aarch32-linux-nat.c: Revert.
5206
5207 2019-04-05  Tom Tromey  <tom@tromey.com>
5208
5209         * ft32-tdep.c: Sort headers.
5210         * frv-tdep.c: Sort headers.
5211         * frv-linux-tdep.c: Sort headers.
5212         * frame.c: Sort headers.
5213         * frame-unwind.c: Sort headers.
5214         * frame-base.c: Sort headers.
5215         * fork-child.c: Sort headers.
5216         * findvar.c: Sort headers.
5217         * findcmd.c: Sort headers.
5218         * filesystem.c: Sort headers.
5219         * filename-seen-cache.h: Sort headers.
5220         * filename-seen-cache.c: Sort headers.
5221         * fbsd-tdep.c: Sort headers.
5222         * fbsd-nat.h: Sort headers.
5223         * fbsd-nat.c: Sort headers.
5224         * f-valprint.c: Sort headers.
5225         * f-typeprint.c: Sort headers.
5226         * f-lang.c: Sort headers.
5227         * extension.h: Sort headers.
5228         * extension.c: Sort headers.
5229         * extension-priv.h: Sort headers.
5230         * expprint.c: Sort headers.
5231         * exec.h: Sort headers.
5232         * exec.c: Sort headers.
5233         * exceptions.c: Sort headers.
5234         * event-top.c: Sort headers.
5235         * event-loop.c: Sort headers.
5236         * eval.c: Sort headers.
5237         * elfread.c: Sort headers.
5238         * dwarf2read.h: Sort headers.
5239         * dwarf2read.c: Sort headers.
5240         * dwarf2loc.c: Sort headers.
5241         * dwarf2expr.h: Sort headers.
5242         * dwarf2expr.c: Sort headers.
5243         * dwarf2-frame.c: Sort headers.
5244         * dwarf2-frame-tailcall.c: Sort headers.
5245         * dwarf-index-write.h: Sort headers.
5246         * dwarf-index-write.c: Sort headers.
5247         * dwarf-index-common.c: Sort headers.
5248         * dwarf-index-cache.h: Sort headers.
5249         * dwarf-index-cache.c: Sort headers.
5250         * dummy-frame.c: Sort headers.
5251         * dtrace-probe.c: Sort headers.
5252         * disasm.h: Sort headers.
5253         * disasm.c: Sort headers.
5254         * disasm-selftests.c: Sort headers.
5255         * dictionary.c: Sort headers.
5256         * dicos-tdep.c: Sort headers.
5257         * demangle.c: Sort headers.
5258         * dcache.h: Sort headers.
5259         * dcache.c: Sort headers.
5260         * darwin-nat.h: Sort headers.
5261         * darwin-nat.c: Sort headers.
5262         * darwin-nat-info.c: Sort headers.
5263         * d-valprint.c: Sort headers.
5264         * d-namespace.c: Sort headers.
5265         * d-lang.c: Sort headers.
5266         * ctf.c: Sort headers.
5267         * csky-tdep.c: Sort headers.
5268         * csky-linux-tdep.c: Sort headers.
5269         * cris-tdep.c: Sort headers.
5270         * cris-linux-tdep.c: Sort headers.
5271         * cp-valprint.c: Sort headers.
5272         * cp-support.c: Sort headers.
5273         * cp-namespace.c: Sort headers.
5274         * cp-abi.c: Sort headers.
5275         * corelow.c: Sort headers.
5276         * corefile.c: Sort headers.
5277         * continuations.c: Sort headers.
5278         * completer.h: Sort headers.
5279         * completer.c: Sort headers.
5280         * complaints.c: Sort headers.
5281         * coffread.c: Sort headers.
5282         * coff-pe-read.c: Sort headers.
5283         * cli-out.h: Sort headers.
5284         * cli-out.c: Sort headers.
5285         * charset.c: Sort headers.
5286         * c-varobj.c: Sort headers.
5287         * c-valprint.c: Sort headers.
5288         * c-typeprint.c: Sort headers.
5289         * c-lang.c: Sort headers.
5290         * buildsym.c: Sort headers.
5291         * buildsym-legacy.c: Sort headers.
5292         * build-id.h: Sort headers.
5293         * build-id.c: Sort headers.
5294         * btrace.c: Sort headers.
5295         * bsd-uthread.c: Sort headers.
5296         * breakpoint.h: Sort headers.
5297         * breakpoint.c: Sort headers.
5298         * break-catch-throw.c: Sort headers.
5299         * break-catch-syscall.c: Sort headers.
5300         * break-catch-sig.c: Sort headers.
5301         * blockframe.c: Sort headers.
5302         * block.c: Sort headers.
5303         * bfin-tdep.c: Sort headers.
5304         * bfin-linux-tdep.c: Sort headers.
5305         * bfd-target.c: Sort headers.
5306         * bcache.c: Sort headers.
5307         * ax-general.c: Sort headers.
5308         * ax-gdb.h: Sort headers.
5309         * ax-gdb.c: Sort headers.
5310         * avr-tdep.c: Sort headers.
5311         * auxv.c: Sort headers.
5312         * auto-load.c: Sort headers.
5313         * arm-wince-tdep.c: Sort headers.
5314         * arm-tdep.c: Sort headers.
5315         * arm-symbian-tdep.c: Sort headers.
5316         * arm-pikeos-tdep.c: Sort headers.
5317         * arm-obsd-tdep.c: Sort headers.
5318         * arm-nbsd-tdep.c: Sort headers.
5319         * arm-nbsd-nat.c: Sort headers.
5320         * arm-linux-tdep.c: Sort headers.
5321         * arm-linux-nat.c: Sort headers.
5322         * arm-fbsd-tdep.c: Sort headers.
5323         * arm-fbsd-nat.c: Sort headers.
5324         * arm-bsd-tdep.c: Sort headers.
5325         * arch-utils.c: Sort headers.
5326         * arc-tdep.c: Sort headers.
5327         * arc-newlib-tdep.c: Sort headers.
5328         * annotate.h: Sort headers.
5329         * annotate.c: Sort headers.
5330         * amd64-windows-tdep.c: Sort headers.
5331         * amd64-windows-nat.c: Sort headers.
5332         * amd64-tdep.c: Sort headers.
5333         * amd64-sol2-tdep.c: Sort headers.
5334         * amd64-obsd-tdep.c: Sort headers.
5335         * amd64-obsd-nat.c: Sort headers.
5336         * amd64-nbsd-tdep.c: Sort headers.
5337         * amd64-nbsd-nat.c: Sort headers.
5338         * amd64-nat.c: Sort headers.
5339         * amd64-linux-tdep.c: Sort headers.
5340         * amd64-linux-nat.c: Sort headers.
5341         * amd64-fbsd-tdep.c: Sort headers.
5342         * amd64-fbsd-nat.c: Sort headers.
5343         * amd64-dicos-tdep.c: Sort headers.
5344         * amd64-darwin-tdep.c: Sort headers.
5345         * amd64-bsd-nat.c: Sort headers.
5346         * alpha-tdep.c: Sort headers.
5347         * alpha-obsd-tdep.c: Sort headers.
5348         * alpha-nbsd-tdep.c: Sort headers.
5349         * alpha-mdebug-tdep.c: Sort headers.
5350         * alpha-linux-tdep.c: Sort headers.
5351         * alpha-linux-nat.c: Sort headers.
5352         * alpha-bsd-tdep.c: Sort headers.
5353         * alpha-bsd-nat.c: Sort headers.
5354         * aix-thread.c: Sort headers.
5355         * agent.c: Sort headers.
5356         * addrmap.c: Sort headers.
5357         * ada-varobj.c: Sort headers.
5358         * ada-valprint.c: Sort headers.
5359         * ada-typeprint.c: Sort headers.
5360         * ada-tasks.c: Sort headers.
5361         * ada-lang.c: Sort headers.
5362         * aarch64-tdep.c: Sort headers.
5363         * aarch64-ravenscar-thread.c: Sort headers.
5364         * aarch64-newlib-tdep.c: Sort headers.
5365         * aarch64-linux-tdep.c: Sort headers.
5366         * aarch64-linux-nat.c: Sort headers.
5367         * aarch64-fbsd-tdep.c: Sort headers.
5368         * aarch64-fbsd-nat.c: Sort headers.
5369         * aarch32-linux-nat.c: Sort headers.
5370
5371 2019-04-04  Tom Tromey  <tom@tromey.com>
5372
5373         * varobj.c (varobj_create): Update.
5374         * rust-exp.y (struct rust_parser) <update_innermost_block,
5375         lookup_symbol>: New methods.
5376         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5377         Rename.
5378         (rust_parser::rust_lookup_type)
5379         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5380         * printcmd.c (display_command, do_one_display): Update.
5381         * parser-defs.h (struct parser_state) <parser_state>: Add
5382         "tracker" parameter.
5383         (block_tracker): New member.
5384         (class innermost_block_tracker) <innermost_block_tracker>: Add
5385         "types" parameter.
5386         <reset>: Remove method.
5387         (innermost_block): Don't declare.
5388         (null_post_parser): Update.
5389         * parse.c (innermost_block): Remove global.
5390         (write_dollar_variable): Update.
5391         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5392         Remove "tracker_types" parameter.
5393         (parse_expression): Add "tracker" parameter.
5394         (parse_expression_for_completion): Update.
5395         (null_post_parser): Add "tracker" parameter.
5396         * p-exp.y: Update rules.
5397         * m2-exp.y: Update rules.
5398         * language.h (struct language_defn) <la_post_parser>: Add
5399         "tracker" parameter.
5400         * go-exp.y: Update rules.
5401         * f-exp.y: Update rules.
5402         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5403         parameter.
5404         * d-exp.y: Update rules.
5405         * c-exp.y: Update rules.
5406         * breakpoint.c (set_breakpoint_condition): Create an
5407         innermost_block_tracker.
5408         (watch_command_1): Likewise.
5409         * ada-lang.c (resolve): Add "tracker" parameter.
5410         (resolve_subexp): Likewise.
5411         * ada-exp.y (write_var_from_sym): Update.
5412
5413 2019-04-04  Tom Tromey  <tom@tromey.com>
5414
5415         * type-stack.h: New file.
5416         * type-stack.c: New file.
5417         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5418         type-stack.h.
5419         (insert_into_type_stack, insert_type, push_type, push_type_int)
5420         (insert_type_address_space, pop_type, pop_type_int)
5421         (pop_typelist, pop_type_stack, append_type_stack)
5422         (push_type_stack, get_type_stack, push_typelist)
5423         (follow_type_instance_flags, follow_types): Don't declare.
5424         * parse.c (type_stack): Remove global.
5425         (parse_exp_in_context): Update.
5426         (insert_into_type_stack, insert_type, push_type, push_type_int)
5427         (insert_type_address_space, pop_type, pop_type_int)
5428         (pop_typelist, pop_type_stack, append_type_stack)
5429         (push_type_stack, get_type_stack, push_typelist)
5430         (follow_type_instance_flags, follow_types): Remove (moved to
5431         type-stack.c).
5432         * f-exp.y (type_stack): New global.
5433         Update rules.
5434         (push_kind_type, f_parse): Update.
5435         * d-exp.y (type_stack): New global.
5436         Update rules.
5437         (d_parse): Update.
5438         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5439         Update rules.
5440         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5441         (HFILES_NO_SRCDIR): Add type-stack.h.
5442
5443 2019-04-04  Tom Tromey  <tom@tromey.com>
5444
5445         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5446         (rust_parser::convert_ast_to_expression, rust_parse)
5447         (rust_lex_test_completion, rust_lex_tests): Update.
5448         * parser-defs.h (struct expr_completion_state): New.
5449         (struct parser_state) <parser_state>: Add completion parameter.
5450         <mark_struct_expression, mark_completion_tag>: New methods.
5451         <parse_completion, m_completion_state>: New members.
5452         (prefixify_expression, null_post_parser): Update.
5453         (mark_struct_expression, mark_completion_tag): Don't declare.
5454         * parse.c (parse_completion, expout_last_struct)
5455         (expout_tag_completion_type, expout_completion_name): Remove
5456         globals.
5457         (parser_state::mark_struct_expression)
5458         (parser_state::mark_completion_tag): Now methods.
5459         (prefixify_expression): Add last_struct parameter.
5460         (prefixify_subexp): Likewise.
5461         (parse_exp_1): Update.
5462         (parse_exp_in_context): Add cstate parameter.  Update.
5463         (parse_expression_for_completion): Create an
5464         expr_completion_state.
5465         (null_post_parser): Add "completion" parameter.
5466         * p-exp.y: Update rules.
5467         (yylex): Update.
5468         * language.h (struct language_defn) <la_post_parser>: Add
5469         "completing" parameter.
5470         * go-exp.y: Update rules.
5471         (lex_one_token): Update.
5472         * expression.h (parse_completion): Don't declare.
5473         * d-exp.y: Update rules.
5474         (lex_one_token): Update rules.
5475         * c-exp.y: Update rules.
5476         (lex_one_token): Update.
5477         * ada-lang.c (resolve): Add "parse_completion" parameter.
5478         (resolve_subexp): Likewise.
5479         (ada_resolve_function): Likewise.
5480
5481 2019-04-04  Tom Tromey  <tom@tromey.com>
5482
5483         * parser-defs.h (struct parser_state) <start_arglist,
5484         end_arglist>: New methods.
5485         <arglist_len, m_funcall_chain>: New members.
5486         (arglist_len, start_arglist, end_arglist): Don't declare.
5487         * parse.c (arglist_len, funcall_chain): Remove global.
5488         (start_arglist, end_arglist): Remove functions.
5489         (parse_exp_in_context): Update.
5490         * p-exp.y: Update rules.
5491         * m2-exp.y: Update rules.
5492         * go-exp.y: Update rules.
5493         * f-exp.y: Update rules.
5494         * d-exp.y: Update rules.
5495         * c-exp.y: Update rules.
5496
5497 2019-04-04  Tom Tromey  <tom@tromey.com>
5498
5499         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5500         lex_operator, push_back>: New methods.
5501         Update all rules.
5502         (rust_parser::lex_hex, lex_escape): Rename and update.
5503         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5504         (rust_parser::lex_operator): Rename and update.
5505         (rust_parser::lex_number, rustyylex, rustyyerror)
5506         (rust_lex_test_init, rust_lex_test_sequence)
5507         (rust_lex_test_push_back, rust_lex_tests): Update.
5508         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5509         parameter.
5510         <lexptr, prev_lexptr>: New members.
5511         (lexptr, prev_lexptr): Don't declare.
5512         * parse.c (lexptr, prev_lexptr): Remove globals.
5513         (parse_exp_in_context): Update.
5514         * p-exp.y (yylex, yyerror): Update.
5515         * m2-exp.y (parse_number, yylex, yyerror): Update.
5516         * go-exp.y (lex_one_token, yyerror): Update.
5517         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5518         * d-exp.y (lex_one_token, yyerror): Update.
5519         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5520         (lex_one_token, yyerror): Update.
5521         * ada-lex.l (YY_INPUT): Update.
5522         (rewind_to_char): Update.
5523         * ada-exp.y (yyerror): Update.
5524
5525 2019-04-04  Tom Tromey  <tom@tromey.com>
5526
5527         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5528         * parser-defs.h (struct parser_state) <parser_state>: Add new
5529         parameter.
5530         <comma_terminates>: New member.
5531         (comma_terminates): Don't declare global.
5532         * parse.c (comma_terminates): Remove global.
5533         (parse_exp_in_context): Update.
5534         * p-exp.y (yylex): Update.
5535         * m2-exp.y (yylex): Update.
5536         * go-exp.y (lex_one_token): Update.
5537         * f-exp.y (yylex): Update.
5538         * d-exp.y (lex_one_token): Update.
5539         * c-exp.y (lex_one_token): Update.
5540         * ada-lex.l: Update.
5541
5542 2019-04-04  Tom Tromey  <tom@tromey.com>
5543
5544         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5545         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5546         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5547         * parser-defs.h (paren_depth): Don't declare.
5548         * parse.c (paren_depth): Remove global.
5549         (parse_exp_in_context): Update.
5550         * p-exp.y (paren_depth): New global.
5551         (pascal_parse): Initialize it.
5552         * m2-exp.y (paren_depth): New global.
5553         (m2_parse): Initialize it.
5554         * go-exp.y (paren_depth): New global.
5555         (go_parse): Initialize it.
5556         * f-exp.y (paren_depth): New global.
5557         (f_parse): Initialize it.
5558         * d-exp.y (paren_depth): New global.
5559         (d_parse): Initialize it.
5560         * c-exp.y (paren_depth): New global.
5561         (c_parse): Initialize it.
5562         * ada-lex.l (paren_depth): New global.
5563         (lexer_init): Initialize it.
5564
5565 2019-04-04  Tom Tromey  <tom@tromey.com>
5566
5567         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5568         (rust_parser::convert_ast_to_type)
5569         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5570         * parser-defs.h (struct parser_state) <parser_state>: Add
5571         parameters.  Initialize new members.
5572         <expression_context_block, expression_context_pc>: New members.
5573         * parse.c (expression_context_block, expression_context_pc):
5574         Remove globals.
5575         (parse_exp_in_context): Update.
5576         * p-exp.y: Update all rules.
5577         (yylex): Update.
5578         * m2-exp.y: Update all rules.
5579         (yylex): Update.
5580         * go-exp.y (yylex): Update.
5581         * f-exp.y (yylex): Update.
5582         * d-exp.y: Update all rules.
5583         (yylex): Update.
5584         * c-exp.y: Update all rules.
5585         (lex_one_token, classify_name, yylex, c_parse): Update.
5586         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5587
5588 2019-04-04  Tom Tromey  <tom@tromey.com>
5589
5590         * gdbarch.h, gdbarch.c: Rebuild.
5591         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5592         * stap-probe.h:
5593         (struct stap_parse_info): Replace "parser_state" with
5594         "expr_builder".
5595         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5596         (parser_state): New class.
5597         * parse.c (expr_builder): Rename.
5598         (expr_builder::release): Rename.
5599         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5600         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5601         (write_exp_elt_longcst, write_exp_elt_floatcst)
5602         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5603         (write_exp_string_vector, write_exp_bitstring)
5604         (write_exp_msymbol, mark_struct_expression)
5605         (write_dollar_variable)
5606         (insert_type_address_space, increase_expout_size): Replace
5607         "parser_state" with "expr_builder".
5608         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5609         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5610         "parser_state" with "expr_builder".
5611
5612 2019-04-04  Tom Tromey  <tom@tromey.com>
5613
5614         * rust-exp.y: Replace "parse_language" with method call.
5615         * p-exp.y:
5616         (yylex): Replace "parse_language" with method call.
5617         * m2-exp.y:
5618         (yylex): Replace "parse_language" with method call.
5619         * go-exp.y (classify_name): Replace "parse_language" with method
5620         call.
5621         * f-exp.y (yylex): Replace "parse_language" with method call.
5622         * d-exp.y (lex_one_token): Replace "parse_language" with method
5623         call.
5624         * c-exp.y:
5625         (lex_one_token, classify_name, yylex): Replace "parse_language"
5626         with method call.
5627         * ada-exp.y (find_primitive_type, type_char)
5628         (type_system_address): Replace "parse_language" with method call.
5629
5630 2019-04-04  Tom Tromey  <tom@tromey.com>
5631
5632         * rust-exp.y: Replace "parse_gdbarch" with method call.
5633         * parse.c (write_dollar_variable, insert_type_address_space):
5634         Replace "parse_gdbarch" with method call.
5635         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5636         call.
5637         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5638         call.
5639         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5640         "parse_gdbarch" with method call.
5641         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5642         with method call.
5643         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5644         "parse_gdbarch" with method call.
5645         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5646         "parse_gdbarch" with method call.
5647         * c-exp.y (parse_type, parse_number, classify_name): Replace
5648         "parse_gdbarch" with method call.
5649         * ada-lex.l: Replace "parse_gdbarch" with method call.
5650         * ada-exp.y (parse_type, find_primitive_type, type_char)
5651         (type_system_address): Replace "parse_gdbarch" with method call.
5652
5653 2019-04-04  Tom Tromey  <tom@tromey.com>
5654
5655         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5656         * stap-probe.c (stap_parse_argument): Update.
5657         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5658         initial_size parameter.
5659         * rust-exp.y (rust_lex_tests): Update.
5660         * parse.c (parser_state): Update.
5661         (parse_exp_in_context): Update.
5662         * parser-defs.h (struct parser_state) <parser_state>: Remove
5663         "initial_size" parameter.
5664
5665 2019-04-04  Tom Tromey  <tom@tromey.com>
5666
5667         * parser-defs.h (increase_expout_size): Don't declare.
5668         * parse.c (increase_expout_size): Now static.
5669
5670 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5671
5672         * gnu-nat.c (gnu_nat_target::wait): Fix
5673         target_waitstatus_to_string call.
5674
5675 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5676
5677         * eval.c (evaluate_subexp_standard): Handle internal functions
5678         during Fortran function call handling.
5679
5680 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5681
5682         * NEWS: Mention new internal functions.
5683         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5684         (read_base_type): Use dwarf2_init_complex_target_type.
5685         * value.c (creal_internal_fn): New function.
5686         (cimag_internal_fn): New function.
5687         (_initialize_values): Register new internal functions.
5688
5689 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5690
5691         * infrun.c (stop_all_threads): If debug_infrun, always
5692         trace the wait status after wait_one, using
5693         target_waitstatus_to_string and target_pid_to_str.
5694         (handle_inferior_event): Replace various trace of
5695         wait status kind by a single trace.
5696         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5697         wait status kind image by target_waitstatus_to_string.
5698         * target/waitstatus.c (target_waitstatus_to_string): Fix
5699         obsolete comment.
5700
5701 2019-04-01  Tom Tromey  <tromey@adacore.com>
5702
5703         PR symtab/23331:
5704         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5705
5706 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5707             Pedro Alves  <palves@redhat.com>
5708
5709         * top.c (quit_force): Call 'finalize_values'.
5710         * value.c (finalize_values): New function.
5711         * value.h (finalize_values): Declare.
5712
5713 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5714
5715         * NEWS: Announce $_gdb_major and $_gdb_minor.
5716
5717         * top.c (init_gdb_version_vars): New function.
5718         (gdb_init): Call init_gdb_version_vars.
5719
5720 2019-03-29  Tom Tromey  <tromey@adacore.com>
5721
5722         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5723         help text.  Remove dead code.
5724
5725 2019-03-29  Keith Seitz  <keiths@redhat.com>
5726
5727         From Siddhesh Poyarekar:
5728         * f-lang.h (f77_get_upperbound): Return LONGEST.
5729         (f77_get_lowerbound): Likewise.
5730         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5731         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5732         print them.
5733         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5734         plongest to format print it.
5735         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5736         (f77_get_upperbound): Likewise.
5737         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5738         LOWER_BOUND to LONGEST.
5739         (f77_create_arrayprint_offset_tbl): Likewise.
5740
5741 2019-03-29  Keith Seitz  <keiths@redhat.com>
5742
5743         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5744         %s/pulongest for TYPE_LENGTH instead of %d in format
5745         strings.
5746         * ada-typerint.c (ada_print_type): Likewise.
5747         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5748         * compile/compile-c-support.c (generate_register_struct): Likewise.
5749         * gdbtypes.c (recursive_dump_type): Likewise.
5750         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5751         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5752         instead of %d in format strings.
5753         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5754         to std::min to ULONGEST.
5755         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5756         instead of %d in format strings.
5757         * tracepoint.c (info_scope_command): Likewise.
5758         * typeprint.c (print_offset_data::update)
5759         (print_offset_data::finish): Likewise.
5760         * xtensa-tdep.c (xtensa_store_return_value)
5761         (xtensa_push_dummy_call): Likewise.
5762
5763 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5764
5765         * windows-nat.c (display_selector): Fixed format specifications
5766         for 64-bit Cygwin.
5767
5768 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5769
5770         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5771
5772 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5773
5774         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5775         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5776         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5777         (nios2_linux_init_abi): Install it.
5778
5779 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5780
5781         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5782
5783 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5784
5785         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5786
5787 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5788             Tom Tromey  <tromey@adacore.com>
5789
5790         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5791
5792 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5793
5794         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5795         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5796         method to compute the bounds of range types. Also print "[evaluated]"
5797         if the bounds' values come from a dynamic evaluation.
5798
5799 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5800
5801         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5802         whitespace when pretty printing is on.
5803
5804 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5805
5806         * ppc-linux-nat.c: Add include.
5807
5808 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5809
5810         * NEWS: Mention AArch64 Pointer Authentication.
5811
5812 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5813
5814         * arm-linux-nat.c: Add include.
5815
5816 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5817
5818         * source-cache.c (source_cache::get_source_lines): Re-read
5819         fullname after calling open_source_file.
5820
5821 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5822
5823         * NEWS: Mention TLS support for FreeBSD.
5824
5825 2019-03-25  Tom Tromey  <tromey@adacore.com>
5826
5827         * minsyms.c (BUNCH_SIZE): Update comment.
5828         (~minimal_symbol_reader): Remove old comment.
5829         (compact_minimal_symbols): Update comment.
5830         (minimal_symbol_reader::install): Remove old comment.  Update
5831         other comments.
5832
5833 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5834
5835         * s390-linux-nat.c: Add include.
5836
5837 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5838
5839         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5840         Call linux_get_hwcap.
5841         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5842         Likewise.
5843         (aarch64_linux_get_hwcap): Remove function.
5844         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5845         declaration.
5846         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5847         linux_get_hwcap.
5848         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5849         * linux-tdep.c (linux_get_hwcap): Add function.
5850         (linux_get_hwcap2): Likewise.
5851         * linux-tdep.h (linux_get_hwcap): Add declaration.
5852         (linux_get_hwcap2): Likewise.
5853         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5854         (ppc_linux_get_hwcap2): Likewise.
5855         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5856         linux_get_hwcap.
5857         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5858         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5859         (ppc_linux_nat_target::read_description): Likewise.
5860         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5861         * s390-linux-nat.c: Likewise.
5862         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5863
5864 2019-03-24  Tom Tromey  <tom@tromey.com>
5865
5866         * ada-lang.c (standard_lookup): Simplify initialization.
5867         (ada_lookup_symbol_nonlocal): Simplify return.
5868         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5869         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5870         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5871         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5872         initialization.
5873         * solib.c (solib_global_lookup): Simplify.
5874         * symtab.c (null_block_symbol): Remove.
5875         (symbol_cache_lookup): Simplify returns.
5876         (lookup_language_this): Simplify returns.
5877         (lookup_symbol_aux): Simplify return.
5878         (lookup_local_symbol): Simplify returns.
5879         (lookup_global_symbol_from_objfile): Simplify return.
5880         (lookup_symbol_in_objfile_symtabs)
5881         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5882         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5883         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5884         * cp-namespace.c (cp_lookup_bare_symbol)
5885         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5886         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5887         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5888         (cp_lookup_symbol_via_imports): Simplify initialization.
5889         (find_symbol_in_baseclass): Likewise.
5890         * symtab.h (null_block_symbol): Remove.
5891         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5892         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5893         (d_lookup_symbol_module): Likewise.
5894         (find_symbol_in_baseclass): Simplify initialization.
5895
5896 2019-03-24  Tom Tromey  <tom@tromey.com>
5897
5898         * expression.h: Don't include symtab.h.
5899         (struct block): Forward declare.
5900
5901 2019-03-24  Tom Tromey  <tom@tromey.com>
5902
5903         * c-exp.y (typebase): Remove casts.
5904         * gdbtypes.c (lookup_unsigned_typename, )
5905         (lookup_signed_typename): Remove cast.
5906         * eval.c (parse_to_comma_and_eval): Remove cast.
5907         * parse.c (write_dollar_variable): Remove cast.
5908         * block.h (struct block) <superblock>: Now const.
5909         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5910         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5911         (map_block): Make "block" const.
5912         * symfile.h (struct quick_symbol_functions)
5913         <map_matching_symbols>: Constify block argument to "callback".
5914         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5915         const.
5916         (find_pc_sect_compunit_symtab): Make "b" const.
5917         (find_symbol_at_address): Likewise.
5918         (search_symbols): Likewise.
5919         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5920         (dw2_debug_names_lookup_symbol): Likewise.
5921         (dw2_map_matching_symbols): Update.
5922         * p-valprint.c (pascal_val_print): Remove "block".
5923         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5924         (aux_add_nonlocal_symbols): Make "block" const.
5925         (resolve_subexp): Remove cast.
5926         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5927         const.
5928         (iterate_over_file_blocks): Likewise.
5929         * f-exp.y (%union) <bval>: Remove.
5930         * coffread.c (patch_opaque_types): Make "b" const.
5931         * spu-tdep.c (spu_catch_start): Make "block" const.
5932         * c-valprint.c (print_unpacked_pointer): Remove "block".
5933         * symmisc.c (dump_symtab_1): Make "b" const.
5934         (block_depth): Make "block" const.
5935         * d-exp.y (%union) <bval>: Remove.
5936         * cp-support.h (cp_lookup_rtti_type): Update.
5937         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5938         * psymtab.c (psym_lookup_symbol): Make "block" const.
5939         (maintenance_check_psymtabs): Make "b" const.
5940         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5941         (enumerate_locals, enumerate_args): Update.
5942         * python/py-symtab.c (stpy_global_block): Make "block" const.
5943         (stpy_static_block): Likewise.
5944         * inline-frame.c (block_starting_point_at): Make "new_block"
5945         const.
5946         * block.c (find_block_in_blockvector): Make return type const.
5947         (blockvector_for_pc_sect): Make "b" const.
5948         (find_block_in_blockvector): Make "b" const.
5949
5950 2019-03-23  Tom Tromey  <tom@tromey.com>
5951
5952         * varobj.c (varobj_create): Update.
5953         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5954         * printcmd.c (display_command, do_one_display): Don't reset
5955         innermost_block.
5956         * parser-defs.h (enum innermost_block_tracker_type): Move to
5957         expression.h.
5958         (innermost_block): Update comment.
5959         * parse.c (parse_exp_1): Add tracker_types parameter.
5960         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5961         tracker_types parameter.  Reset innermost_block.
5962         (parse_exp_in_context): Remove.
5963         (parse_expression_for_completion): Update.
5964         * objfiles.c (~objfile): Don't reset expression_context_block or
5965         innermost_block.
5966         * expression.h (enum innermost_block_tracker_type): Move from
5967         parser-defs.h.
5968         (parse_exp_1): Add tracker_types parameter.
5969         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5970         reset innermost_block.
5971
5972 2019-03-23  Tom Tromey  <tom@tromey.com>
5973
5974         * objfiles.h: Include bcache.h.
5975
5976 2019-03-23  Tom Tromey  <tom@tromey.com>
5977
5978         * linespec.c (get_current_search_block): Use
5979         scoped_restore_current_language.
5980         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5981
5982 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5983             Jiong Wang  <jiong.wang@arm.com>
5984
5985         * aarch64-linux-tdep.c
5986         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5987         section.
5988         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5989
5990 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5991             Jiong Wang  <jiong.wang@arm.com>
5992
5993         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5994         instructions.
5995         (aarch64_analyze_prologue_test): Add PACIASP test.
5996         (aarch64_prologue_prev_register): Unmask PC value.
5997
5998 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5999             Jiong Wang  <jiong.wang@arm.com>
6000
6001         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6002         (aarch64_dwarf2_prev_register): Unmask PC value.
6003         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6004         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6005         DW_CFA_AARCH64_negate_ra_state.
6006         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6007
6008 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6009             Jiong Wang  <jiong.wang@arm.com>
6010
6011         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6012         registers.
6013         (aarch64_pseudo_register_name): Likewise.
6014         (aarch64_pseudo_register_type): Likewise.
6015         (aarch64_pseudo_register_reggroup_p): Likewise.
6016         (aarch64_gdbarch_init): Add pauth registers.
6017         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6018         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6019         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6020         (struct gdbarch_tdep): Add regnum for ra_state.
6021
6022 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6023             Jiong Wang  <jiong.wang@arm.com>
6024
6025         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6026
6027 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6028             Jiong Wang  <jiong.wang@arm.com>
6029
6030         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6031         function.
6032         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6033         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6034         (aarch64_gdbarch_init): Add puth registers.
6035         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6036         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6037         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6038
6039 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6040             Jiong Wang  <jiong.wang@arm.com>
6041
6042         * aarch64-linux-nat.c
6043         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6044         * aarch64-linux-tdep.c
6045         (aarch64_linux_core_read_description): Likewise.
6046         (aarch64_linux_get_hwcap): New function.
6047         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6048         (aarch64_linux_get_hwcap): New declaration.
6049
6050 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6051             Jiong Wang  <jiong.wang@arm.com>
6052
6053         * aarch64-linux-nat.c
6054         (aarch64_linux_nat_target::read_description): Add pauth param.
6055         * aarch64-linux-tdep.c
6056         (aarch64_linux_core_read_description): Likewise.
6057         * aarch64-tdep.c (struct target_desc): Add in pauth.
6058         (aarch64_read_description): Add pauth param.
6059         (aarch64_gdbarch_init): Likewise.
6060         * aarch64-tdep.h (aarch64_read_description): Likewise.
6061         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6062         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6063         * features/Makefile: Add new files.
6064         * features/aarch64-pauth.c: New file.
6065         * features/aarch64-pauth.xml: New file.
6066
6067 2019-03-20  Tom Tromey  <tromey@adacore.com>
6068
6069         * infrun.c (handle_inferior_event): Rename from
6070         handle_inferior_event_1.  Create a scoped_value_mark.
6071         (handle_inferior_event): Remove.
6072
6073 2019-03-19  Tom Tromey  <tromey@adacore.com>
6074
6075         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6076         * infrun.h (print_stop_event): Add "displays" parameter.
6077         * infrun.c (print_stop_event): Add "displays" parameter.
6078
6079 2019-03-19  Pedro Alves  <palves@redhat.com>
6080
6081         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6082         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6083         to -1.  Fix TABs vs spaces.
6084         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6085         * tui/tui-out.h (tui_ui_out) Add intro comments.
6086         <m_line, m_start_of_line>: In-class initialize, and add describing
6087         comment.
6088
6089 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6090
6091         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6092         variable names.
6093         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6094
6095 2019-03-18  Pedro Alves  <palves@redhat.com>
6096             Eli Zaretskii <eliz@gnu.org>
6097
6098         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6099         m_line and m_start_of_line.
6100
6101 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6102
6103         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6104         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6105         it returns a newline.  This fixes a regression in TU mode, whereby
6106         the next line is output on the same screen line as the user input.
6107
6108 2019-03-18  Tom Tromey  <tromey@adacore.com>
6109
6110         * minsyms.c (minimal_symbol_reader::install): Remove call to
6111         obstack_blank.
6112
6113 2019-03-18  Pedro Alves  <palves@redhat.com>
6114
6115         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6116         New globals.
6117         (apply_style): New, factored out from ...
6118         (apply_ansi_escape): ... this.  Handle reverse video mode.
6119         (tui_set_reverse_mode): New function.
6120         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6121         * tui/tui-winsource.c (tui_show_source_line): Use
6122         tui_set_reverse_mode instead of setting A_STANDOUT.
6123         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6124         New setter methods.
6125
6126 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6127
6128         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6129         Handle tabs.
6130
6131 2019-03-18  Tom Tromey  <tromey@adacore.com>
6132
6133         * ada-lang.c (empty_array): Add "high" parameter.
6134         (ada_evaluate_subexp): Update.
6135
6136 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6137
6138         * unittests/string_view-selftests.c: Define
6139         _initialize_string_view_selftests unconditionally.
6140
6141 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6142
6143         PR gdb/24350
6144         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6145
6146 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6147
6148         PR gdb/24351
6149         * windows-nat.c (display_selector): Fix format specifiers.
6150
6151 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6152
6153         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6154         tui_refill_source_window instead of tui_refresh_win, to update the
6155         current execution line.  This fixes redisplay of the current line
6156         when stepping through the code with "next" or "step".
6157
6158 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6159
6160         * source-cache.c (source_cache::get_source_lines): Call
6161         find_source_lines to initialize s->nlines.  This fixes vertical
6162         scrolling of TUI source window when the DOWN arrow is pressed.
6163
6164 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6165
6166         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6167         linux-thread-db.c (_initialize_thread_db): Likewise.
6168
6169 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6170
6171         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6172         wclrtoeol in tui_show_source_line".  This reverts changes made in
6173         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6174
6175 2019-03-15  Tom Tromey  <tom@tromey.com>
6176
6177         * symtab.h (struct minimal_symbol): Derive from
6178         general_symbol_info.
6179         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6180         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6181         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6182         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6183         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6184         (MSYMBOL_SEARCH_NAME): Update.
6185         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6186         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6187         * minsyms.c (minimal_symbol_reader::record_full): Update.
6188
6189 2019-03-15  Tom Tromey  <tom@tromey.com>
6190
6191         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6192
6193 2019-03-15  Tom Tromey  <tom@tromey.com>
6194
6195         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6196         unique_xmalloc_ptr.
6197         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6198         Update.
6199         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6200         (build_minimal_symbol_hash_tables)
6201         (minimal_symbol_reader::install): Update.
6202
6203 2019-03-15  Tom Tromey  <tom@tromey.com>
6204
6205         * symtab.c (create_demangled_names_hash): Update.
6206         (symbol_set_names): Update.
6207         * objfiles.h (struct objfile_per_bfd_storage)
6208         <demangled_names_hash>: Now an htab_up.
6209         * objfiles.c (objfile_per_bfd_storage): Simplify.
6210
6211 2019-03-15  Tom Tromey  <tom@tromey.com>
6212
6213         * objfiles.h (struct objfile_per_bfd_storage): Declare
6214         destructor.
6215         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6216         New.
6217         (get_objfile_bfd_data): Use new.  Don't initialize
6218         language_of_main.
6219         (free_objfile_per_bfd_storage): Remove.
6220         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6221
6222 2019-03-15  Tom Tromey  <tom@tromey.com>
6223
6224         * symfile.c (reread_symbols): Update.
6225         * objfiles.c (objfile::objfile): Update.
6226         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6227         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6228         comment.
6229         (minimal_symbol_reader::install): Update.
6230         (terminate_minimal_symbol_table): Remove.
6231         * jit.c (jit_object_close_impl): Update.
6232
6233 2019-03-15  Tom Tromey  <tom@tromey.com>
6234
6235         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6236         initializations.
6237
6238 2019-03-15  Tom Tromey  <tom@tromey.com>
6239
6240         * objfiles.h (struct objfile_per_bfd_storage)
6241         <demangled_hash_languages>: Now a bitset.
6242         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6243         (lookup_minimal_symbol): Update.
6244
6245 2019-03-15  Tom Tromey  <tom@tromey.com>
6246
6247         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6248         Don't return the symbol.
6249         * coffread.c (record_minimal_symbol): Use record_full.
6250
6251 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6252
6253         The MS-Windows port of ncurses fails to switch to a color pair if
6254         one or both of the colors are the implicit default colors.  This
6255         change records the default colors when TUI is initialized, and
6256         then specifies them explicitly when a color pair uses the default
6257         colors.  This allows color styling in TUI mode on MS-Windows.
6258
6259         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6260         ncurses_norm_attr.
6261         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6262         colors in ncurses_norm_attr.
6263         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6264         "none", replace it with the default color recorded in
6265         ncurses_norm_attr.
6266
6267 2019-03-14  Tom Tromey  <tromey@adacore.com>
6268
6269         * source-cache.h (class source_cache) <get_source_lines>: Return
6270         std::string.
6271         * source-cache.c (source_cache::extract_lines): Handle case where
6272         first_pos==npos.  Return std::string.
6273         (source_cache::get_source_lines): Update.
6274
6275 2019-03-14  Tom Tromey  <tromey@adacore.com>
6276
6277         * NEWS: Add item for "style sources" commands.
6278         * source-cache.c (source_cache::get_source_lines): Check
6279         source_styling.
6280         * cli/cli-style.c (source_styling): New global.
6281         (_initialize_cli_style): Add "style sources" commands.
6282         (show_style_sources): New function.
6283         * cli/cli-style.h (source_styling): Declare.
6284
6285 2019-03-14  Pedro Alves  <palves@redhat.com>
6286             Tom Tromey  <tromey@adacore.com>
6287
6288         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6289         * tui/tui-winsource.c (tui_refill_source_window): New function,
6290         from...
6291         (tui_horizontal_source_scroll): ... here.  Move some logic.
6292         * cli/cli-style.c (set_style_enabled): Notify new observable.
6293         * tui/tui-hooks.c (tui_redisplay_source): New function.
6294         (tui_attach_detach_observers): Attach or detach
6295         tui_redisplay_source.
6296         * observable.h (source_styling_changed): New observable.
6297         * observable.c: Define source_styling_changed observable.
6298
6299 2019-03-13  Tom Tromey  <tromey@adacore.com>
6300
6301         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6302         (i386_gnu_nat_target::store_registers): Update.
6303         * target-debug.h (target_debug_print_std_string): New macro.
6304         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6305         * windows-tdep.c (display_one_tib): Update.
6306         * tui/tui-stack.c (tui_make_status_line): Update.
6307         * top.c (print_inferior_quit_action): Update.
6308         * thread.c (thr_try_catch_cmd): Update.
6309         (add_thread_with_info): Update.
6310         (thread_target_id_str): Update.
6311         (thr_try_catch_cmd): Update.
6312         (thread_command): Update.
6313         (thread_find_command): Update.
6314         * record-btrace.c (record_btrace_target::info_record)
6315         (record_btrace_resume_thread, record_btrace_target::resume)
6316         (record_btrace_cancel_resume, record_btrace_step_thread)
6317         (record_btrace_target::wait, record_btrace_target::wait)
6318         (record_btrace_target::wait, record_btrace_target::stop): Update.
6319         * progspace.c (print_program_space): Update.
6320         * process-stratum-target.c
6321         (process_stratum_target::thread_address_space): Update.
6322         * linux-fork.c (linux_fork_mourn_inferior)
6323         (detach_checkpoint_command, info_checkpoints_command)
6324         (linux_fork_context): Update.
6325         (linux_fork_detach): Update.
6326         (class scoped_switch_fork_info): Update.
6327         (delete_checkpoint_command): Update.
6328         * infrun.c (follow_fork_inferior): Update.
6329         (follow_fork_inferior): Update.
6330         (proceed_after_vfork_done): Update.
6331         (handle_vfork_child_exec_or_exit): Update.
6332         (follow_exec): Update.
6333         (displaced_step_prepare_throw): Update.
6334         (displaced_step_restore): Update.
6335         (start_step_over): Update.
6336         (resume_1): Update.
6337         (clear_proceed_status_thread): Update.
6338         (proceed): Update.
6339         (print_target_wait_results): Update.
6340         (do_target_wait): Update.
6341         (context_switch): Update.
6342         (stop_all_threads): Update.
6343         (restart_threads): Update.
6344         (finish_step_over): Update.
6345         (handle_signal_stop): Update.
6346         (switch_back_to_stepped_thread): Update.
6347         (keep_going_pass_signal): Update.
6348         (print_exited_reason): Update.
6349         (normal_stop): Update.
6350         * inferior.c (inferior_pid_to_str): Change return type.
6351         (print_selected_inferior): Update.
6352         (add_inferior): Update.
6353         (detach_inferior): Update.
6354         * dummy-frame.c (fprint_dummy_frames): Update.
6355         * dcache.c (dcache_info_1): Update.
6356         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6357         (btrace_fetch, btrace_clear): Update.
6358         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6359         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6360         type.
6361         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6362         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6363         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6364         * gdbarch.c, gdbarch.h: Rebuild.
6365         * gdbarch.sh (core_pid_to_str): Change return type.
6366         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6367         return type.
6368         (windows_nat_target::pid_to_str): Change return type.
6369         (windows_delete_thread): Update.
6370         (windows_nat_target::attach): Update.
6371         (windows_nat_target::files_info): Update.
6372         * target-delegates.c: Rebuild.
6373         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6374         return type.
6375         (sol_thread_target::pid_to_str): Change return type.
6376         * remote.c (class remote_target) <pid_to_str>: Change return
6377         type.
6378         (remote_target::pid_to_str): Change return type.
6379         (extended_remote_target::attach, remote_target::remote_stop_ns)
6380         (remote_target::remote_notif_remove_queued_reply)
6381         (remote_target::push_stop_reply, remote_target::disable_btrace):
6382         Update.
6383         (extended_remote_target::attach): Update.
6384         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6385         type.
6386         (gdbsim_target::pid_to_str): Change return type.
6387         * ravenscar-thread.c (struct ravenscar_thread_target)
6388         <pid_to_str>: Change return type.
6389         (ravenscar_thread_target::pid_to_str): Change return type.
6390         * procfs.c (class procfs_target) <pid_to_str>: Change return
6391         type.
6392         (procfs_target::pid_to_str): Change return type.
6393         (procfs_target::attach): Update.
6394         (procfs_target::detach): Update.
6395         (procfs_target::fetch_registers): Update.
6396         (procfs_target::store_registers): Update.
6397         (procfs_target::wait): Update.
6398         (procfs_target::files_info): Update.
6399         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6400         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6401         return type.
6402         (nto_procfs_target::pid_to_str): Change return type.
6403         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6404         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6405         return type.
6406         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6407         (exit_lwp): Update.
6408         (attach_proc_task_lwp_callback, get_detach_signal)
6409         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6410         (linux_nat_target::resume, wait_lwp, stop_callback)
6411         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6412         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6413         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6414         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6415         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6416         type.
6417         (inf_ptrace_target::attach): Update.
6418         (inf_ptrace_target::files_info): Update.
6419         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6420         type.
6421         (go32_nat_target::pid_to_str): Change return type.
6422         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6423         (gnu_nat_target::wait): Update.
6424         (gnu_nat_target::wait): Update.
6425         (gnu_nat_target::resume): Update.
6426         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6427         (fbsd_nat_target::wait): Update.
6428         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6429         type.
6430         (darwin_nat_target::attach): Update.
6431         * corelow.c (class core_target) <pid_to_str>: Change return type.
6432         (core_target::pid_to_str): Change return type.
6433         * target.c (normal_pid_to_str): Change return type.
6434         (default_pid_to_str): Likewise.
6435         (target_pid_to_str): Change return type.
6436         (target_translate_tls_address): Update.
6437         (target_announce_detach): Update.
6438         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6439         return type.
6440         (bsd_uthread_target::pid_to_str): Change return type.
6441         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6442         type.
6443         (bsd_kvm_target::pid_to_str): Change return type.
6444         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6445         return type.
6446         (aix_thread_target::pid_to_str): Change return type.
6447         * target.h (struct target_ops) <pid_to_str>: Change return type.
6448         (target_pid_to_str, normal_pid_to_str): Likewise.
6449         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6450         type.
6451         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6452         type.
6453         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6454         return type.
6455         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6456         type.
6457         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6458         type.
6459         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6460         return type.
6461
6462 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6463
6464         * NEWS: Mention that the new default MI version is 3.  Mention
6465         changes to the output of commands and events that deal with
6466         multi-location breakpoints.
6467         * breakpoint.c: Include "mi/mi-out.h".
6468         (print_one_breakpoint): Change output syntax if using MI version
6469         >= 3.
6470         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6471         New.
6472         (mi_multi_location_breakpoint_output_fixed): New.
6473         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6474         (mi_cmd_fix_multi_location_breakpoint_output): New.
6475         (mi_multi_location_breakpoint_output_fixed): New.
6476         * mi/mi-cmds.c (mi_cmds): Register command
6477         -fix-multi-location-breakpoint-output.
6478         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6479         interpreter "mi".
6480
6481 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6482
6483         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6484         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6485         instantiate mi_ui_out based on interpreter name.
6486         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6487         * mi/mi-main.c (mi_load_progress): Likewise.
6488
6489 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6490
6491         * NEWS: Combine separate "New targets" sections for 8.3.
6492
6493 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6494
6495         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6496         (ppcfbsd_init_abi): Install gdbarch
6497         "fetch_tls_load_module_address" and "get_thread_local_address"
6498         methods.
6499
6500 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6501
6502         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6503         (riscv_fbsd_init_abi): Install gdbarch
6504         "fetch_tls_load_module_address" and "get_thread_local_address"
6505         methods.
6506
6507 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6508
6509         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6510         (i386fbsd_init_abi): Install gdbarch
6511         "fetch_tls_load_module_address" and "get_thread_local_address"
6512         methods.
6513
6514 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6515
6516         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6517         (amd64fbsd_init_abi): Install gdbarch
6518         "fetch_tls_load_module_address" and "get_thread_local_address"
6519         methods.
6520
6521 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6522
6523         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6524         (struct fbsd_pspace_data): New type.
6525         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6526         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6527         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6528         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6529         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6530
6531 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6532
6533         * gdbtypes.c (lookup_struct_elt): New function.
6534         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6535         * gdbtypes.h (struct struct_elt): New type.
6536         (lookup_struct_elt): New prototype.
6537
6538 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6539
6540         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6541         remove disabled code block.
6542
6543 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6544
6545         * gdbarch.sh (get_thread_local_address): New method.
6546         * gdbarch.h, gdbarch.c: Regenerate.
6547         * target.c (target_translate_tls_address): Use
6548         gdbarch_get_thread_local_address if present instead of
6549         target::get_thread_local_address.
6550
6551 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6552
6553         * target.h (target::get_thread_local_address): Update comment.
6554
6555 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6556
6557         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6558         objfile->separate_debug_objfile_backlink if not NULL.
6559
6560 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6561
6562         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6563         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6564         (amd64bsd_store_inferior_registers): Likewise.
6565         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6566         Enable segment base registers.
6567         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6568         PT_GETFSBASE and PT_GETGSBASE.
6569         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6570         PT_SETGSBASE.
6571         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6572         segment base registers.
6573         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6574
6575 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6576
6577         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6578         Update calls to i386_target_description to add 'segments'
6579         parameter.
6580         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6581         add segment base registers.
6582         * arch/i386.c (i386_create_target_description): Add 'segments'
6583         parameter to enable segment base registers.
6584         * arch/i386.h (i386_create_target_description): Likewise.
6585         * features/i386/32bit-segments.xml: New file.
6586         * features/i386/32bit-segments.c: Generate.
6587         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6588         call to i386_target_description to add 'segments' parameter.
6589         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6590         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6591         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6592         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6593         if feature is present.
6594         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6595         Add 'segments' parameter to call to i386_target_description.
6596         (i386_target_description): Add 'segments' parameter to enable
6597         segment base registers.
6598         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6599         to call to i386_target_description.
6600         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6601         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6602         Define I386_NUM_REGS.
6603         (i386_target_description): Add 'segments' parameter to enable
6604         segment base registers.
6605
6606 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6607
6608         PR/24325
6609         * source-cache.c: #undef open and close, to avoid unresolved
6610         externals during linking.
6611
6612 2019-03-12  Tom Tromey  <tromey@adacore.com>
6613
6614         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6615         const.  Add initializers.
6616         (_initialize_remote): Don't initialize ptid globals.
6617
6618 2019-03-12  Pedro Alves  <palves@redhat.com>
6619
6620         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6621
6622 2019-03-12  Pedro Alves  <palves@redhat.com>
6623
6624         * cp-name-parser.y (main): Remove unused 'len' variable.
6625
6626 2019-03-12  Tom Tromey  <tromey@adacore.com>
6627
6628         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6629         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6630
6631 2019-03-12  Tom Tromey  <tromey@adacore.com>
6632
6633         * linux-nat.c (iterate_over_lwps): Update.
6634         (stop_callback): Remove parameter.
6635         (stop_wait_callback, detach_callback, resume_set_callback)
6636         (select_singlestep_lwp_callback, set_ignore_sigint)
6637         (status_callback, resumed_callback, resume_clear_callback)
6638         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6639         data parameter.
6640         (linux_nat_target::detach, linux_nat_target::resume)
6641         (linux_stop_and_wait_all_lwps, select_event_lwp)
6642         (linux_nat_filter_event, linux_nat_wait_1)
6643         (linux_nat_target::kill, linux_nat_target::stop)
6644         (linux_nat_target::stop): Update.
6645         (linux_nat_resume_callback): Change type.
6646         (resume_stopped_resumed_lwps, count_events_callback)
6647         (select_event_lwp_callback): Likewise.
6648         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6649         * arm-linux-nat.c (struct update_registers_data): Remove.
6650         (update_registers_callback): Change type.
6651         (arm_linux_insert_hw_breakpoint1): Update.
6652         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6653         parameter.
6654         (x86_linux_dr_set_addr): Update.
6655         (x86_linux_dr_set_control): Update.
6656         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6657         (iterate_over_lwps): Use gdb::function_view.
6658         * nat/aarch64-linux-hw-point.c (struct
6659         aarch64_dr_update_callback_param): Remove.
6660         (debug_reg_change_callback): Change type.
6661         (aarch64_notify_debug_reg_change): Update.
6662         * s390-linux-nat.c (s390_refresh_per_info): Update.
6663
6664 2019-03-11  Tom Tromey  <tromey@adacore.com>
6665
6666         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6667         redundant assignment to "this_cu".
6668
6669 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6670
6671         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6672
6673 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6674
6675         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6676         from...
6677         (rank_one_type): ... this.
6678
6679 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6680
6681         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6682         from...
6683         (rank_one_type): ... this.
6684
6685 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6686
6687         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6688         from...
6689         (rank_one_type): ... this.
6690
6691 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6692
6693         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6694         from...
6695         (rank_one_type): ... this.
6696
6697 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6698
6699         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6700         from...
6701         (rank_one_type): ... this.
6702
6703 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6704
6705         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6706         from...
6707         (rank_one_type): ... this.
6708
6709 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6710
6711         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6712         from...
6713         (rank_one_type): ... this.
6714
6715 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6716
6717         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6718         from...
6719         (rank_one_type): ... this.
6720
6721 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6722
6723         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6724         from...
6725         (rank_one_type): ... this.
6726
6727 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6728
6729         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6730         from...
6731         (rank_one_type): ... this.
6732
6733 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6734
6735         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6736         from...
6737         (rank_one_type): ... this.
6738
6739 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6740
6741         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6742         from...
6743         (rank_one_type): ... this.
6744
6745 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6746
6747         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6748         inferior-events' shows the example events.
6749
6750 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6751
6752         Support styling on native MS-Windows console
6753
6754         PR/24315
6755         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6756         on MS-Windows if $TERM is not defined.
6757
6758         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6759
6760         * posix-hdep.c (gdb_console_fputs):
6761         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6762         functions.
6763         * ui-file.h (gdb_console_fputs): Add prototype.
6764
6765         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6766         back to fputs only if the former returns zero.
6767
6768 2019-03-07  Tom Tromey  <tom@tromey.com>
6769
6770         * symmisc.c (print_symbol_bcache_statistics): Update.
6771         (print_objfile_statistics): Update.
6772         * symfile.c (allocate_symtab): Update.
6773         * stabsread.c: Don't include bcache.h.
6774         * psymtab.h (struct psymbol_bcache): Don't declare.
6775         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6776         (psymbol_bcache_init, psymbol_bcache_free)
6777         (psymbol_bcache_get_bcache): Don't declare.
6778         * psymtab.c (struct psymbol_bcache): Remove.
6779         (psymtab_storage::psymtab_storage): Update.
6780         (psymtab_storage::~psymtab_storage): Update.
6781         (psymbol_bcache_init, psymbol_bcache_free)
6782         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6783         (add_psymbol_to_bcache): Update.
6784         (allocate_psymtab): Update.
6785         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6786         macro_cache>: No longer pointers.
6787         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6788         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6789         * macrotab.c (macro_bcache): Update.
6790         * macroexp.c: Don't include bcache.h.
6791         * gdbtypes.c (check_types_worklist): Update.
6792         (types_deeply_equal): Remove TRY/CATCH.  Update.
6793         * elfread.c (elf_symtab_read): Update.
6794         * dwarf2read.c: Don't include bcache.h.
6795         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6796         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6797         (print_bcache_statistics, bcache_memory_used): Don't declare.
6798         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6799         methods.  Rename all data members.
6800         * bcache.c (struct bcache): Move to bcache.h.
6801         (bcache::expand_hash_table): Rename from expand_hash_table.
6802         (bcache): Remove.
6803         (bcache::insert): Rename from bcache_full.
6804         (bcache::compare): Rename from bcache_compare.
6805         (bcache_xmalloc): Remove.
6806         (bcache::~bcache): Rename from bcache_xfree.
6807         (bcache::print_statistics): Rename from print_bcache_statistics.
6808         (bcache::memory_used): Rename from bcache_memory_used.
6809
6810 2019-03-07  Pedro Alves  <palves@redhat.com>
6811
6812         * infrun.c (normal_stop): Also check for
6813         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6814
6815 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6816
6817         * f-lang.c (value_from_host_double): Moved to...
6818         * value.c (value_from_host_double): ...here.
6819         * value.h (value_from_host_double): Declare.
6820         * guile/scm-math.c (vlscm_convert_typed_number): Use
6821         value_from_host_double.
6822         (vlscm_convert_number): Likewise.
6823         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6824         * python/py-value.c (convert_value_from_python): Likewise.
6825
6826 2019-03-06  Tom Tromey  <tom@tromey.com>
6827
6828         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6829
6830 2019-03-06  Tom Tromey  <tom@tromey.com>
6831
6832         * utils.h (free_current_contents): Don't declare.
6833         * utils.c (free_current_contents): Remove.
6834
6835 2019-03-06  Tom Tromey  <tom@tromey.com>
6836
6837         * top.c (quit_force): Update.
6838         * main.c (captured_command_loop): Update.
6839         * common/new-op.c (operator new): Update.
6840         * common/common-exceptions.c (struct catcher)
6841         <save_cleanup_chain>: Remove member.
6842         (exceptions_state_mc_init): Update.
6843         (exception_try_scope_entry): Return nullptr.
6844         (exception_try_scope_exit, exception_rethrow)
6845         (throw_exception_sjlj, throw_exception_cxx): Update.
6846         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6847         (all_cleanups, do_cleanups, discard_cleanups)
6848         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6849         (restore_cleanups, restore_final_cleanups): Don't declare.
6850         (do_final_cleanups): Remove parameter.
6851         * common/cleanups.c (cleanup_chain, make_cleanup)
6852         (make_cleanup_dtor, all_cleanups, do_cleanups)
6853         (discard_my_cleanups, discard_cleanups)
6854         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6855         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6856         (null_cleanup): Remove.
6857         (do_final_cleanups): Remove parameter.
6858
6859 2019-03-06  Tom Tromey  <tom@tromey.com>
6860
6861         * remote.c (remote_target::remote_parse_stop_reply): Use
6862         unique_xmalloc_ptr.
6863
6864 2019-03-06  Tom Tromey  <tom@tromey.com>
6865
6866         * stabsread.c (struct stabs_field_info): Rename from field_info.
6867         <list, fnlist>: Add initializers.
6868         <obstack>: New member.
6869         (read_member_functions, read_struct_fields, read_baseclasses):
6870         Allocate on obstack.  Don't use cleanups.
6871         (read_one_struct_field, read_member_functions, read_struct_fields)
6872         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6873         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6874         (read_struct_type): Update.
6875
6876 2019-03-06  Tom Tromey  <tom@tromey.com>
6877
6878         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6879         * common/filestuff.h (make_cleanup_close): Don't declare.
6880         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6881         Remove.
6882
6883 2019-03-06  Tom Tromey  <tom@tromey.com>
6884
6885         * solib-aix.c: Use make_scope_exit.
6886
6887 2019-03-06  Tom Tromey  <tom@tromey.com>
6888
6889         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6890         Use make_scope_exit.
6891
6892 2019-03-06  Tom Tromey  <tom@tromey.com>
6893
6894         * solib-svr4.c (disable_probes_interface): Remove parameter.
6895         (svr4_handle_solib_event): Use make_scope_exit.
6896
6897 2019-03-06  Tom Tromey  <tom@tromey.com>
6898
6899         * remote.c (struct stop_reply_deleter): Remove.
6900         (stop_reply_up): Update.
6901         (struct stop_reply): Derive from notif_event.  Don't typedef.
6902         <regcache>: Now a std::vector.
6903         (stop_reply_xfree): Remove.
6904         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6905         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6906         (remote_target::discard_pending_stop_replies): Use delete.
6907         (remote_target::remote_parse_stop_reply): Update.
6908         (remote_target::process_stop_reply): Update.
6909         * remote-notif.h (struct notif_event): Add virtual destructor.
6910         Remove "dtr" member.
6911         (struct notif_client) <alloc_event>: Return a unique_ptr.
6912         (notif_event_xfree): Don't declare.
6913         (notif_event_up): New typedef.
6914         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6915         (notif_event_xfree, do_notif_event_xfree): Remove.
6916         (remote_notif_state_xfree): Update.
6917
6918 2019-03-06  Tom Tromey  <tom@tromey.com>
6919
6920         * infrun.c (displaced_step_clear_cleanup): Now a
6921         forward_scope_exit type.
6922         (displaced_step_prepare_throw): Update.
6923         (displaced_step_fixup): Update.
6924
6925 2019-03-06  Tom Tromey  <tom@tromey.com>
6926
6927         * inferior.h (class inferior): Update comment.
6928         * gdbthread.h (class thread_info): Update comment.
6929
6930 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6931             Tom Tromey  <tom@tromey.com>
6932
6933         * stabsread.h (struct stab_section_list): Remove.
6934         (coffstab_build_psymtabs): Update.
6935         * dbxread.c (symbuf_sections): Now a std::vector.
6936         (sect_idx): New global.
6937         (fill_symbuf): Update.
6938         (coffstab_build_psymtabs): Change type of stabsects parameter.
6939         Update.
6940         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6941         std::vector.
6942         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6943         (coff_locate_sections): Update.
6944         (coff_symfile_read): Remove cleanups.  Update.
6945         (init_stringtab): Add storage parameter.
6946         (free_stringtab, free_stringtab_cleanup): Remove.
6947         (init_lineno): Add storage parameter.
6948         (free_linetab, free_linetab_cleanup): Remove.
6949
6950 2019-03-06  Pedro Alves  <palves@redhat.com>
6951
6952         * linux-fork.c (fork_info::clobber_regs): Delete.
6953         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6954         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6955         comment.  Adjust.
6956         (scoped_switch_fork_info::scoped_switch_fork_info)
6957         (checkpoint_command, linux_fork_context): Adjust
6958         fork_save_infrun_state calls.
6959
6960 2019-03-06  Pedro Alves  <palves@redhat.com>
6961
6962         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6963         (inf_has_multiple_threads): Return 'bool' and rewrite using
6964         inferior_info::threads().
6965
6966 2019-03-06  Pedro Alves  <palves@redhat.com>
6967
6968         * linux-fork.c: Include <list>.
6969         (fork_list): Now a std::list instance.
6970         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6971         (forks_exist_p, find_last_fork): Adjust.
6972         (new_fork): Delete.
6973         (one_fork_p): New.
6974         (add_fork): Adjust.
6975         (free_fork): Delete, folded into fork_info::~fork_info().
6976         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6977         Adjust.
6978         (init_fork_list): Delete.
6979         (linux_fork_killall, linux_fork_mourn_inferior)
6980         (linux_fork_detach, info_checkpoints_command): Adjust.
6981         (_initialize_linux_fork): No longer call init_fork_list.
6982
6983 2019-03-06  Pedro Alves  <palves@redhat.com>
6984
6985         * linux-fork.c (new_fork): New, split out of ...
6986         (add_fork): ... this.  Return void.  Move "first fork" special
6987         case from here, to ...
6988         (checkpoint_command): ... here.
6989         * linux-linux.h (add_fork): Return void.
6990
6991 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6992
6993         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6994
6995 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6996             Chris January  <chris.january@arm.com>
6997             David Lecomber  <david.lecomber@arm.com>
6998
6999         * f-exp.y: New token, UNOP_INTRINSIC.
7000         (exp): New pattern using UNOP_INTRINSIC token.
7001         (f77_keywords): Add 'abs' keyword.
7002         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7003         (value_from_host_double): New function.
7004         (evaluate_subexp_f): Support UNOP_ABS.
7005
7006 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7007
7008         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7009         types.
7010
7011 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7012
7013         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7014         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7015         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7016
7017 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7018
7019         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7020
7021 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7022             Chris January  <chris.january@arm.com>
7023
7024         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7025         * f-exp.y: Define 'KIND' token.
7026         (exp): New pattern for KIND expressions.
7027         (ptype): Handle types with a kind extension.
7028         (direct_abs_decl): Extend to spot kind extensions.
7029         (f77_keywords): Add 'kind' to the list.
7030         (push_kind_type): New function.
7031         (convert_to_kind_type): New function.
7032         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7033         * parse.c (operator_length_standard): Likewise.
7034         * parser-defs.h (enum type_pieces): Add tp_kind.
7035         * std-operator.def: Add UNOP_KIND.
7036
7037 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7038
7039         * f-exp.y (f_parse): Set yydebug.
7040
7041 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7042
7043         * f-lang.c (evaluate_subexp_f): New function.
7044         (exp_descriptor_f): New global.
7045         (f_language_defn): Use exp_descriptor_f instead of
7046         exp_descriptor_standard.
7047
7048 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7049
7050         * f-exp.y (struct token): Add comments.
7051         (dot_ops): Remove uppercase versions and the end marker.
7052         (f77_keywords): Likewise.
7053         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7054         entries in the dot_ops array are case insensitive, and use
7055         strncasecmp to compare strings.  Also some whitespace cleanup in
7056         this area.  Similar for the f77_keywords array, except entries in
7057         this list might be case sensitive.
7058
7059 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7060
7061         * f-exp.y (struct f77_boolean_val): Add comments.
7062         (boolean_values): Remove uppercase versions, and end marker.
7063         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7064         and use strncasecmp to achieve case insensitivity.  Additionally,
7065         perform whitespace cleanup around this code.
7066
7067 2019-03-06  Tom Tromey  <tromey@adacore.com>
7068
7069         * remote-sim.c (gdbsim_target_open): Use result of
7070         gdb_argv::release.
7071
7072 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7073         Dirk Schubert  <dirk.schubert@arm.com>
7074         Chris January  <chris.january@arm.com>
7075
7076         * eval.c (evaluate_subexp_standard): Call Fortran argument
7077         wrapping logic.
7078         * f-lang.c (struct value): A value which can be passed into a
7079         Fortran function call.
7080         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7081         where appropriate.
7082         (struct type): Value ready for a Fortran function call.
7083         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7084         is needed.
7085         * f-lang.h (fortran_argument_convert): Declaration.
7086         (fortran_preserve_arg_pointer): Declaration.
7087         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7088
7089 2019-03-05  Tom Tromey  <tromey@adacore.com>
7090
7091         * python/py-prettyprint.c (print_string_repr): Remove #if.
7092         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7093
7094 2019-03-05  Tom Tromey  <tromey@adacore.com>
7095
7096         * target.c (the_dummy_target): Move later.  Change type to
7097         "dummy_target".
7098         (initialize_targets): Don't initialize the_dummy_target.
7099
7100 2019-03-05  Tom Tromey  <tromey@adacore.com>
7101
7102         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7103         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7104
7105 2019-03-05  Tom Tromey  <tromey@adacore.com>
7106
7107         * windows-nat.c (windows_nat_target::attach)
7108         (windows_nat_target::detach): Don't call gdb_flush.
7109         * valprint.c (generic_val_print, val_print, val_print_string):
7110         Don't call gdb_flush.
7111         * utils.c (defaulted_query): Don't call gdb_flush.
7112         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7113         * target.c (target_announce_detach): Don't call gdb_flush.
7114         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7115         * remote.c (extended_remote_target::attach): Don't call
7116         gdb_flush.
7117         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7118         * printcmd.c (do_examine): Don't call gdb_flush.
7119         (info_display_command): Don't call gdb_flush.
7120         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7121         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7122         * memattr.c (info_mem_command): Don't call gdb_flush.
7123         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7124         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7125         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7126         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7127         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7128         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7129         (gnu_nat_target::detach): Don't call gdb_flush.
7130         * f-valprint.c (f_val_print): Don't call gdb_flush.
7131         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7132         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7133         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7134         gdb_flush.
7135         * c-valprint.c (c_val_print): Don't call gdb_flush.
7136         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7137
7138 2019-03-05  Tom Tromey  <tromey@adacore.com>
7139
7140         * varobj.c (update_dynamic_varobj_children): Update.
7141         (install_default_visualizer): Use reset, not release.
7142         * value.c (set_internalvar): Update.
7143         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7144         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7145         ATTRIBUTE_UNUSED_RESULT.
7146
7147 2019-03-05  Tom Tromey  <tromey@adacore.com>
7148
7149         * remote.c (class scoped_remote_fd) <release>: Add
7150         ATTRIBUTE_UNUSED_RESULT.
7151
7152 2019-03-05  Tom Tromey  <tromey@adacore.com>
7153
7154         * macroexp.c (struct macro_buffer) <release>: Add
7155         ATTRIBUTE_UNUSED_RESULT.
7156
7157 2019-03-05  Tom Tromey  <tromey@adacore.com>
7158
7159         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7160         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7161         ATTRIBUTE_UNUSED_RESULT.
7162
7163 2019-03-05  Tom Tromey  <tromey@adacore.com>
7164
7165         * common/scoped_fd.h (class scoped_fd) <release>: Add
7166         ATTRIBUTE_UNUSED_RESULT.
7167
7168 2019-03-05  Tom Tromey  <tromey@adacore.com>
7169
7170         * parser-defs.h (struct parser_state) <release>: Add
7171         ATTRIBUTE_UNUSED_RESULT.
7172
7173 2019-03-05  Tom Tromey  <tromey@adacore.com>
7174
7175         * utils.h (class gdb_argv) <release>: Add
7176         ATTRIBUTE_UNUSED_RESULT.
7177         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7178
7179 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7180
7181         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7182         for-loop range, to avoid compiler warnings.
7183
7184         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7185         avoid compiler warnings about unused variables.
7186
7187         * NEWS: Mention end of support for native debugging on MS-Windows
7188         before XP.
7189
7190         PR gdb/24292
7191         * common/netstuff.c:
7192         * gdbserver/gdbreplay.c
7193         * gdbserver/remote-utils.c:
7194         * ser-tcp.c:
7195         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7196         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7197         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7198         'getaddrinfo' and 'freeaddrinfo' were not available before
7199         Windows XP, and mingw.org's MinGW headers by default define
7200         _WIN32_WINNT to 0x500.
7201
7202 2019-03-01  Gary Benson <gbenson@redhat.com>
7203
7204         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7205
7206 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7207             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7208
7209         PR gdb/8527
7210         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7211         set_sigint_trap, clear_sigint_trap.
7212
7213 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7214
7215         * target.c (target_detach): Clear the regcache and the
7216         frame cache.
7217
7218 2019-02-27  Pedro Alves  <palves@redhat.com>
7219
7220         * utils.c (set_screen_size): When we cap the height/width sizes,
7221         tweak the corresponding command variable to show "unlimited":
7222
7223 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7224             Pedro Alves  <palves@redhat.com>
7225
7226         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7227         before calling rl_set_screen_size.
7228
7229 2019-02-27  Tom Tromey  <tromey@adacore.com>
7230
7231         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7232         define.
7233         * python/py-value.c: Remove Python 2.4 workaround.
7234         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7235         workaround.
7236         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7237         Python 2.4 workaround.
7238         * python/python-internal.h: Remove Python 2.4 comment.
7239         (Py_ssize_t): Don't define.
7240         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7241         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7242         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7243         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7244         * python/python.c (do_start_initialization): Remove Python 2.4
7245         workaround.
7246         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7247         (print_children): Remove Python 2.4 workaround.
7248         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7249         workaround.
7250         (CHARBUFFERPROC_NAME): Remove.
7251         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7252         Python 2.4 workaround.
7253
7254 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7255
7256         * NEWS: Note minimum Python version.
7257
7258 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7259
7260         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7261         code from these functions.  Remove corresponding ifdefs.  Use
7262         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7263         Remove gotos and target of gotos.
7264         (infpy_search_memory): Likewise.
7265
7266 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7267
7268         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7269         (hppa_gdbarch_init): Don't register deleted functions with
7270         gdbarch.
7271
7272 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7273
7274         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7275         (h8300_unwind_sp): Delete.
7276         (h8300_dummy_id): Delete.
7277         (h8300_gdbarch_init): Don't register deleted functions with
7278         gdbarch.
7279
7280 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7281
7282         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7283         (ft32_unwind_pc): Delete.
7284         (ft32_unwind_sp): Delete.
7285         (ft32_gdbarch_init): Don't register deleted functions with
7286         gdbarch.
7287
7288 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7289
7290         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7291         (frv_unwind_pc): Delete.
7292         (frv_unwind_sp): Delete.
7293         (frv_gdbarch_init): Don't register deleted functions with
7294         gdbarch.
7295
7296 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7297
7298         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7299         (riscv_unwind_pc): Delete.
7300         (riscv_unwind_sp): Delete.
7301         (riscv_gdbarch_init): Don't register deleted functions with
7302         gdbarch.
7303
7304 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7305
7306         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7307         (csky_unwind_pc): Delete.
7308         (csky_unwind_sp): Delete.
7309         (csky_gdbarch_init): Don't register deleted functions with
7310         gdbarch.
7311
7312 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7313
7314         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7315         (cris_unwind_pc): Delete.
7316         (cris_unwind_sp): Delete.
7317         (cris_gdbarch_init): Don't register deleted functions with
7318         gdbarch.
7319
7320 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7321
7322         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7323         (bfin_unwind_pc): Delete.
7324         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7325
7326 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7327
7328         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7329         (arm_unwind_pc): Delete.
7330         (arm_unwind_sp): Delete.
7331         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7332
7333 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7334
7335         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7336         (arc_unwind_pc): Delete.
7337         (arc_unwind_sp): Delete.
7338         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7339
7340 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7341
7342         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7343         (alpha_unwind_pc): Delete.
7344         (alpha_gdbarch_init): Don't register deleted functions with
7345         gdbarch.
7346
7347 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7348
7349         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7350         (aarch64_unwind_pc): Delete.
7351         (aarch64_unwind_sp): Delete.
7352         (aarch64_gdbarch_init): Don't register deleted functions with
7353         gdbarch.
7354
7355 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7356
7357         * gdbtypes.c (type_align): Don't consider static members when
7358         computing structure alignment.
7359
7360 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7361
7362         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7363         return 0 for other types.
7364         * arch-utils.c (default_type_align): Always return 0.
7365         * gdbarch.h: Regenerate.
7366         * gdbarch.sh (type_align): Extend comment.
7367         * gdbtypes.c (type_align): Add additional comments, always call
7368         gdbarch_type_align before applying the default rules.
7369         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7370         generic code will then apply a suitable default.
7371         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7372         types, return 0 for other types.
7373
7374 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7375
7376         * NEWS: Create a new section for the next release branch.
7377         Rename the section of the current branch, now that it has
7378         been cut.
7379
7380 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7381
7382         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7383         * version.in: Bump version to 8.3.50.DATE-git.
7384
7385 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7386
7387         * aix-thread.c (ptid_cmp): Remove unused variable.
7388         (get_signaled_thread): Likewise.
7389         (store_regs_user_thread): Likewise.
7390         (store_regs_kernel_thread): Likewise.
7391         (fetch_regs_kernel_thread): Remove shadowed variable.
7392
7393 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7394
7395         * features/riscv/32bit-cpu.xml: Add register numbers.
7396         * features/riscv/32bit-fpu.c: Regenerate.
7397         * features/riscv/32bit-fpu.xml: Add register numbers.
7398         * features/riscv/64bit-cpu.xml: Add register numbers.
7399         * features/riscv/64bit-fpu.c: Regenerate.
7400         * features/riscv/64bit-fpu.xml: Add register numbers.
7401
7402 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7403
7404         * NEWS: Mention two argument form of gdb.Value constructor.
7405         * python/py-value.c (convert_buffer_and_type_to_value): New
7406         function.
7407         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7408         Add support for handling an optional second argument.  Call
7409         convert_buffer_and_type_to_value as appropriate.
7410         * python/python-internal.h (Py_buffer_deleter): New struct.
7411         (Py_buffer_up): New typedef.
7412
7413 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7414
7415         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7416         instead of releasing ownership.
7417
7418 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7419
7420         * dwarf2read.c (open_and_init_dwp_file): Call
7421         elf_numsections instead of bfd_count_sections to initialize
7422         dwp_file->num_sections.
7423
7424 2019-02-25  Tom Tromey  <tromey@adacore.com>
7425
7426         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7427
7428 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7429
7430         * gcore.in: Add '--readnever' option when invoking GDB.
7431
7432 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7433
7434         * MAINTAINERS: Update my email address.
7435
7436 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7437
7438         * build-id.c (build_id_to_debug_bfd_1): New function.
7439         (build_id_to_debug_bfd): Look for separate debug file in
7440         sysroot.
7441
7442 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7443
7444         * gdbarch.sh: Update the copyright year range that is placed into
7445         generated files.
7446
7447 2019-02-22  Keith Seitz  <keiths@redhat.com>
7448
7449         PR symtab/23853
7450         * linespec.c (create_sals_line_offset): Search for the default
7451         symtab's filename instead of its fullname.
7452
7453 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7454
7455         * NEWS: Update style defaults.
7456
7457 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7458
7459         * main.c (captured_main_1): Disable styling in batch mode.
7460
7461 2019-02-20  Tom Tromey  <tom@tromey.com>
7462
7463         * symtab.c (symtab_symbol_info): Fix typos.
7464
7465 2019-02-20  Tom Tromey  <tromey@adacore.com>
7466
7467         * findcmd.c (_initialize_mem_search): Use upper case for
7468         metasyntactic variables.
7469
7470 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7471
7472         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7473         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7474
7475 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7476
7477         * top.h (source_file_name): Change to std::string.
7478         * top.c (source_file_name): Likewise.
7479         (command_line_input): Adjust.
7480         * cli/cli-script.c (script_from_file): Adjust.
7481
7482 2019-02-19  Tom Tromey  <tromey@adacore.com>
7483
7484         * ravenscar-thread.c
7485         (ravenscar_thread_target::update_thread_list): Don't call
7486         ada_build_task_list.
7487         * ada-lang.h (ada_build_task_list): Don't declare.
7488         * ada-tasks.c (struct ada_tasks_inferior_data)
7489         <task_list_valid_p>: Now bool.
7490         (read_known_tasks, ada_task_list_changed)
7491         (ada_tasks_invalidate_inferior_data): Update.
7492         (read_known_tasks_array): Return bool.
7493         (read_known_tasks_list): Likewise.
7494         (read_known_tasks): Return void.
7495         (ada_build_task_list): Now static.
7496
7497 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7498
7499         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7500         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7501
7502 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7503
7504         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7505         variant for ada_tasks_pspace_data_handle and
7506         ada_tasks_inferior_data_handle.
7507         (ada_tasks_pspace_data_cleanup): New function.
7508         (ada_tasks_inferior_data_cleanup): New function.
7509
7510 2019-02-17  Tom Tromey  <tom@tromey.com>
7511
7512         * macrotab.h (macro_source_fullname): Return a std::string.
7513         * macrotab.c (macro_include, check_for_redefinition)
7514         (macro_undef, macro_lookup_definition, foreach_macro)
7515         (foreach_macro_in_scope): Update.
7516         (macro_source_fullname): Return a std::string.
7517         * macrocmd.c (show_pp_source_pos): Update.
7518
7519 2019-02-17  Tom Tromey  <tom@tromey.com>
7520
7521         * macrocmd.c (show_pp_source_pos): Style the file names.
7522
7523 2019-02-17  Tom Tromey  <tom@tromey.com>
7524
7525         PR tui/24197:
7526         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7527
7528 2019-02-17  Tom Tromey  <tom@tromey.com>
7529
7530         * ada-lang.c (user_select_syms): Use filtered printing.
7531         * utils.c (wrap_style): New global.
7532         (desired_style): Remove.
7533         (emit_style_escape): Add stream parameter.
7534         (set_output_style, reset_terminal_style, prompt_for_continue):
7535         Update.
7536         (flush_wrap_buffer): Only flush gdb_stdout.
7537         (wrap_here): Set wrap_style.
7538         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7539         treat escape sequences as a character.  Change when wrap buffer is
7540         flushed.
7541         (fputs_styled): Do not set the output style when the default is
7542         requested.
7543         * ui-style.h (struct ui_file_style) <is_default>: New method.
7544         * source.c (print_source_lines_base): Emit escape sequences in one
7545         piece.
7546
7547 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7548
7549         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7550         integers and enumeration types.
7551
7552 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7553
7554         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7555         instead of lookup_symbol_in_language
7556         (do_exact_match): New function.
7557         (ada_get_symbol_name_matcher): Return do_exact_match when
7558         doing a verbatim match.
7559
7560 2019-02-15  Tom Tromey  <tromey@adacore.com>
7561
7562         * ravenscar-thread.c (ravenscar_thread_target::resume)
7563         (ravenscar_thread_target::wait): Special case wildcard requests.
7564
7565 2019-02-15  Tom Tromey  <tromey@adacore.com>
7566
7567         * ravenscar-thread.c (base_ptid): Remove.
7568         (struct ravenscar_thread_target) <close>: New method.
7569         <m_base_ptid>: New member.
7570         <update_inferior_ptid, active_task, task_is_currently_active,
7571         runtime_initialized>: Declare methods.
7572         <ravenscar_thread_target>: Add constructor.
7573         (ravenscar_thread_target::task_is_currently_active)
7574         (ravenscar_thread_target::update_inferior_ptid)
7575         (ravenscar_runtime_initialized): Rename.  Now methods.
7576         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7577         (ravenscar_thread_target::update_thread_list): Update.
7578         (ravenscar_thread_target::active_task): Now method.
7579         (ravenscar_thread_target::store_registers)
7580         (ravenscar_thread_target::prepare_to_store)
7581         (ravenscar_thread_target::prepare_to_store)
7582         (ravenscar_thread_target::mourn_inferior): Update.
7583         (ravenscar_inferior_created): Use "new" to create target.
7584         (ravenscar_thread_target::get_ada_task_ptid): Update.
7585         (_initialize_ravenscar): Don't initialize base_ptid.
7586         (ravenscar_ops): Remove global.
7587
7588 2019-02-15  Tom Tromey  <tromey@adacore.com>
7589
7590         * target.h (push_target): Declare new overload.
7591         * target.c (push_target): New overload, taking an rvalue reference.
7592         * remote.c (remote_target::open_1): Use push_target overload.
7593         * corelow.c (core_target_open): Use push_target overload.
7594
7595 2019-02-15  Tom Tromey  <tromey@adacore.com>
7596
7597         * ravenscar-thread.c (is_ravenscar_task)
7598         (ravenscar_task_is_currently_active): Return bool.
7599         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7600         (_initialize_ravenscar): Remove "(void)".
7601         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7602         Return bool.
7603
7604 2019-02-15  Tom Tromey  <tromey@adacore.com>
7605
7606         * ravenscar-thread.c (ravenscar_runtime_initializer)
7607         (has_ravenscar_runtime, get_running_thread_id)
7608         (ravenscar_thread_target::resume): Fix indentation.
7609
7610 2019-02-15  Tom Tromey  <tromey@adacore.com>
7611
7612         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7613         from ravenscar_arch_ops.
7614         (sparc_ravenscar_ops::fetch_registers)
7615         (sparc_ravenscar_ops::store_registers): Now methods.
7616         (sparc_ravenscar_prepare_to_store): Remove.
7617         (sparc_ravenscar_ops): Redefine.
7618         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7619         methods and destructor.  Remove members.
7620         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7621         (ravenscar_thread_target::store_registers)
7622         (ravenscar_thread_target::prepare_to_store): Update.
7623         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7624         Remove.
7625         (struct ppc_ravenscar_powerpc_ops): Derive from
7626         ravenscar_arch_ops.
7627         (ppc_ravenscar_powerpc_ops::fetch_registers)
7628         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7629         (ppc_ravenscar_powerpc_ops): Redefine.
7630         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7631         (ppc_ravenscar_e500_ops::fetch_registers)
7632         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7633         (ppc_ravenscar_e500_ops): Redefine.
7634         * aarch64-ravenscar-thread.c
7635         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7636         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7637         (aarch64_ravenscar_fetch_registers)
7638         (aarch64_ravenscar_store_registers): Now methods.
7639         (aarch64_ravenscar_ops): Redefine.
7640
7641 2019-02-15  Tom Tromey  <tromey@adacore.com>
7642
7643         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7644         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7645         (ravenscar_thread_target::stopped_by_watchpoint)
7646         (ravenscar_thread_target::stopped_data_address)
7647         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7648
7649 2019-02-15  Tom Tromey  <tromey@adacore.com>
7650
7651         * ravenscar-thread.c: Fix some typos.
7652
7653 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7654             Tom Tromey  <tromey@adacore.com>
7655
7656         * ada-lang.c (ada_exception_sal): Change addr_string to a
7657         std::string.
7658         (create_ada_exception_catchpoint): Update.
7659
7660 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7661             Tom Tromey  <tromey@adacore.com>
7662
7663         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7664         (bp_location_ops): Remove.
7665         (base_breakpoint_allocate_location): Update.
7666         (free_bp_location): Update.
7667         * ada-lang.c (class ada_catchpoint_location)
7668         <ada_catchpoint_location>: Remove ops parameter.
7669         (ada_catchpoint_location_dtor): Remove.
7670         (ada_catchpoint_location_ops): Remove.
7671         (allocate_location_exception): Update.
7672         * breakpoint.h (struct bp_location_ops): Remove.
7673         (class bp_location) <bp_location>: Remove bp_location_ops
7674         parameter.
7675         <~bp_location>: Add destructor.
7676         <ops>: Remove.
7677
7678 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7679             Pedro Alves  <palves@redhat.com>
7680
7681         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7682         'PATH_MAX'.
7683
7684 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7685             Samuel Thibault  <samuel.thibault@gnu.org>
7686             Thomas Schwinge  <thomas@codesourcery.com>
7687
7688         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7689         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7690
7691 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7692
7693         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7694         (check_empty): Use "const char *".
7695
7696         * gnu-nat.c (gnu_nat_target::detach): Instead of
7697         'detach_inferior (pid)' call
7698         'detach_inferior (find_inferior_pid (pid))'.
7699
7700         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7701         'nat/fork-inferior.o'.
7702         * gnu-nat.c: #include "nat/fork-inferior.h".
7703
7704         * gnu-nat.c (gnu_nat_target::detach): Instead of
7705         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7706         * gnu-nat.h: #include "inf-child.h".
7707         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7708         'i386_gnu_nat_target::fetch_registers'.
7709         (gnu_store_registers): Rename/move to
7710         'i386_gnu_nat_target::store_registers'.
7711
7712         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7713         * gnu-nat.h (mach_thread_info): New function.
7714         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7715
7716         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7717
7718 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7719
7720         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7721
7722 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7723
7724         * windows-nat.c (windows_add_thread): Add new parameter
7725         "main_thread_p" with default value set to false.  Update
7726         function documentation as well as all callers.
7727         (windows_delete_thread): Likewise.
7728         (fake_create_process): Update call to windows_add_thread.
7729         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7730         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7731         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7732         call to windows_delete_thread.
7733
7734 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7735
7736         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7737
7738 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7739
7740         * symfile.c (find_separate_debug_file): Use canonical path of
7741         sysroot with child_path instead of gdb_sysroot if it is valid.
7742
7743 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7744
7745         * symfile.c (find_separate_debug_file): Use child_path to
7746         determine if an object file is under a sysroot.
7747
7748 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7749
7750         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7751         unittests/child-path-selftests.c.
7752         * common/pathstuff.c (child_path): New function.
7753         * common/pathstuff.h (child_path): New prototype.
7754         * unittests/child-path-selftests.c: New file.
7755
7756 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7757
7758         * symfile.c (find_separate_debug_file): Look for separate debug
7759         files in debug directories under the sysroot.
7760
7761 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7762
7763         * symtab.h (struct minimal_symbol data_p): New const method.
7764         (struct minimal_symbol text_p): Likewise.
7765         * symtab.c (output_source_filename): Use file name style
7766         to print file name.
7767         (print_symbol_info): Likewise.
7768         (print_msymbol_info): Use address style to print addresses.
7769         Use function name style to print executable text symbols.
7770         (expand_symtab_containing_pc): Use data_p.
7771         (find_pc_sect_compunit_symtab): Likewise.
7772
7773 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7774
7775         * breakpoint.c (describe_other_breakpoints): Use address style
7776         to print addresses.
7777         (say_where): Likewise.
7778
7779 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7780
7781         * ada-typeprint.c (print_func_type): Print function name
7782         style to print function name.
7783         * c-typeprint.c (c_print_type_1): Likewise.
7784
7785 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7786
7787         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7788         for execve.
7789
7790 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7791
7792         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7793         type_stack.
7794
7795 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7796
7797         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7798         TYPE_CODE_REF types.
7799
7800 2019-02-08  Jim Wilson  <jimw@sifive.com>
7801
7802         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7803         (riscv_linux_fregset): New.
7804         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7805
7806 2019-02-07  Tom Tromey  <tom@tromey.com>
7807
7808         * thread.c (thread_cancel_execution_command): Update.
7809         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7810         methods.
7811         (struct thread_fsm_ops): Remove.
7812         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7813         (thread_fsm_should_stop, thread_fsm_return_value)
7814         (thread_fsm_set_finished, thread_fsm_finished_p)
7815         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7816         Don't declare.
7817         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7818         * infrun.c (clear_proceed_status_thread)
7819         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7820         (print_stop_event): Update.
7821         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7822         Add constructor.
7823         (step_command_fsm_ops): Remove.
7824         (new_step_command_fsm): Remove.
7825         (step_1): Update.
7826         (step_command_fsm::should_stop): Rename from
7827         step_command_fsm_should_stop.
7828         (step_command_fsm::clean_up): Rename from
7829         step_command_fsm_clean_up.
7830         (step_command_fsm::do_async_reply_reason): Rename from
7831         step_command_fsm_async_reply_reason.
7832         (struct until_next_fsm): Inherit from thread_fsm.  Add
7833         constructor.
7834         (until_next_fsm_ops): Remove.
7835         (new_until_next_fsm): Remove.
7836         (until_next_fsm::should_stop): Rename from
7837         until_next_fsm_should_stop.
7838         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7839         (until_next_fsm::do_async_reply_reason): Rename from
7840         until_next_fsm_async_reply_reason.
7841         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7842         constructor.  Change type of breakpoint.
7843         (finish_command_fsm_ops): Remove.
7844         (new_finish_command_fsm): Remove.
7845         (finish_command_fsm::should_stop): Rename from
7846         finish_command_fsm_should_stop.
7847         (finish_command_fsm::clean_up): Rename from
7848         finish_command_fsm_clean_up.
7849         (finish_command_fsm::return_value): Rename from
7850         finish_command_fsm_return_value.
7851         (finish_command_fsm::do_async_reply_reason): Rename from
7852         finish_command_fsm_async_reply_reason.
7853         (finish_command): Update.
7854         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7855         Add constructor.
7856         (call_thread_fsm_ops): Remove.
7857         (call_thread_fsm::call_thread_fsm): Rename from
7858         new_call_thread_fsm.
7859         (call_thread_fsm::should_stop): Rename from
7860         call_thread_fsm_should_stop.
7861         (call_thread_fsm::should_notify_stop): Rename from
7862         call_thread_fsm_should_notify_stop.
7863         (run_inferior_call, call_function_by_hand_dummy): Update.
7864         * cli/cli-interp.c (should_print_stop_to_console): Update.
7865         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7866         Add constructor.  Change type of location_breakpoint,
7867         caller_breakpoint.
7868         (until_break_fsm_ops): Remove.
7869         (new_until_break_fsm): Remove.
7870         (until_break_fsm::should_stop): Rename from
7871         until_break_fsm_should_stop.
7872         (until_break_fsm::clean_up): Rename from
7873         until_break_fsm_clean_up.
7874         (until_break_fsm::do_async_reply_reason): Rename from
7875         until_break_fsm_async_reply_reason.
7876         (until_break_command): Update.
7877         * thread-fsm.c: Remove.
7878         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7879
7880 2019-02-07  Tom Tromey  <tom@tromey.com>
7881
7882         * yy-remap.h: Add include guard.
7883         * xtensa-tdep.h: Add include guard.
7884         * xcoffread.h: Rename include guard.
7885         * varobj-iter.h: Add include guard.
7886         * tui/tui.h: Rename include guard.
7887         * tui/tui-winsource.h: Rename include guard.
7888         * tui/tui-wingeneral.h: Rename include guard.
7889         * tui/tui-windata.h: Rename include guard.
7890         * tui/tui-win.h: Rename include guard.
7891         * tui/tui-stack.h: Rename include guard.
7892         * tui/tui-source.h: Rename include guard.
7893         * tui/tui-regs.h: Rename include guard.
7894         * tui/tui-out.h: Rename include guard.
7895         * tui/tui-layout.h: Rename include guard.
7896         * tui/tui-io.h: Rename include guard.
7897         * tui/tui-hooks.h: Rename include guard.
7898         * tui/tui-file.h: Rename include guard.
7899         * tui/tui-disasm.h: Rename include guard.
7900         * tui/tui-data.h: Rename include guard.
7901         * tui/tui-command.h: Rename include guard.
7902         * tic6x-tdep.h: Add include guard.
7903         * target/waitstatus.h: Rename include guard.
7904         * target/wait.h: Rename include guard.
7905         * target/target.h: Rename include guard.
7906         * target/resume.h: Rename include guard.
7907         * target-float.h: Rename include guard.
7908         * stabsread.h: Add include guard.
7909         * rs6000-tdep.h: Add include guard.
7910         * riscv-fbsd-tdep.h: Add include guard.
7911         * regformats/regdef.h: Rename include guard.
7912         * record.h: Rename include guard.
7913         * python/python.h: Rename include guard.
7914         * python/python-internal.h: Rename include guard.
7915         * python/py-stopevent.h: Rename include guard.
7916         * python/py-ref.h: Rename include guard.
7917         * python/py-record.h: Rename include guard.
7918         * python/py-record-full.h: Rename include guard.
7919         * python/py-record-btrace.h: Rename include guard.
7920         * python/py-instruction.h: Rename include guard.
7921         * python/py-events.h: Rename include guard.
7922         * python/py-event.h: Rename include guard.
7923         * procfs.h: Add include guard.
7924         * proc-utils.h: Add include guard.
7925         * p-lang.h: Add include guard.
7926         * or1k-tdep.h: Rename include guard.
7927         * observable.h: Rename include guard.
7928         * nto-tdep.h: Rename include guard.
7929         * nat/x86-linux.h: Rename include guard.
7930         * nat/x86-linux-dregs.h: Rename include guard.
7931         * nat/x86-gcc-cpuid.h: Add include guard.
7932         * nat/x86-dregs.h: Rename include guard.
7933         * nat/x86-cpuid.h: Rename include guard.
7934         * nat/ppc-linux.h: Rename include guard.
7935         * nat/mips-linux-watch.h: Rename include guard.
7936         * nat/linux-waitpid.h: Rename include guard.
7937         * nat/linux-ptrace.h: Rename include guard.
7938         * nat/linux-procfs.h: Rename include guard.
7939         * nat/linux-osdata.h: Rename include guard.
7940         * nat/linux-nat.h: Rename include guard.
7941         * nat/linux-namespaces.h: Rename include guard.
7942         * nat/linux-btrace.h: Rename include guard.
7943         * nat/glibc_thread_db.h: Rename include guard.
7944         * nat/gdb_thread_db.h: Rename include guard.
7945         * nat/gdb_ptrace.h: Rename include guard.
7946         * nat/fork-inferior.h: Rename include guard.
7947         * nat/amd64-linux-siginfo.h: Rename include guard.
7948         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7949         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7950         * nat/aarch64-linux.h: Rename include guard.
7951         * nat/aarch64-linux-hw-point.h: Rename include guard.
7952         * mn10300-tdep.h: Add include guard.
7953         * mips-linux-tdep.h: Add include guard.
7954         * mi/mi-parse.h: Rename include guard.
7955         * mi/mi-out.h: Rename include guard.
7956         * mi/mi-main.h: Rename include guard.
7957         * mi/mi-interp.h: Rename include guard.
7958         * mi/mi-getopt.h: Rename include guard.
7959         * mi/mi-console.h: Rename include guard.
7960         * mi/mi-common.h: Rename include guard.
7961         * mi/mi-cmds.h: Rename include guard.
7962         * mi/mi-cmd-break.h: Rename include guard.
7963         * m2-lang.h: Add include guard.
7964         * location.h: Rename include guard.
7965         * linux-record.h: Rename include guard.
7966         * linux-nat.h: Add include guard.
7967         * linux-fork.h: Add include guard.
7968         * i386-darwin-tdep.h: Rename include guard.
7969         * hppa-linux-offsets.h: Add include guard.
7970         * guile/guile.h: Rename include guard.
7971         * guile/guile-internal.h: Rename include guard.
7972         * gnu-nat.h: Rename include guard.
7973         * gdb-stabs.h: Rename include guard.
7974         * frv-tdep.h: Add include guard.
7975         * f-lang.h: Add include guard.
7976         * event-loop.h: Add include guard.
7977         * darwin-nat.h: Rename include guard.
7978         * cp-abi.h: Rename include guard.
7979         * config/sparc/nm-sol2.h: Rename include guard.
7980         * config/nm-nto.h: Rename include guard.
7981         * config/nm-linux.h: Add include guard.
7982         * config/i386/nm-i386gnu.h: Rename include guard.
7983         * config/djgpp/nl_types.h: Rename include guard.
7984         * config/djgpp/langinfo.h: Rename include guard.
7985         * compile/gcc-cp-plugin.h: Add include guard.
7986         * compile/gcc-c-plugin.h: Add include guard.
7987         * compile/compile.h: Rename include guard.
7988         * compile/compile-object-run.h: Rename include guard.
7989         * compile/compile-object-load.h: Rename include guard.
7990         * compile/compile-internal.h: Rename include guard.
7991         * compile/compile-cplus.h: Rename include guard.
7992         * compile/compile-c.h: Rename include guard.
7993         * common/xml-utils.h: Rename include guard.
7994         * common/x86-xstate.h: Rename include guard.
7995         * common/version.h: Rename include guard.
7996         * common/vec.h: Rename include guard.
7997         * common/tdesc.h: Rename include guard.
7998         * common/selftest.h: Rename include guard.
7999         * common/scoped_restore.h: Rename include guard.
8000         * common/scoped_mmap.h: Rename include guard.
8001         * common/scoped_fd.h: Rename include guard.
8002         * common/safe-iterator.h: Rename include guard.
8003         * common/run-time-clock.h: Rename include guard.
8004         * common/refcounted-object.h: Rename include guard.
8005         * common/queue.h: Rename include guard.
8006         * common/ptid.h: Rename include guard.
8007         * common/print-utils.h: Rename include guard.
8008         * common/preprocessor.h: Rename include guard.
8009         * common/pathstuff.h: Rename include guard.
8010         * common/observable.h: Rename include guard.
8011         * common/netstuff.h: Rename include guard.
8012         * common/job-control.h: Rename include guard.
8013         * common/host-defs.h: Rename include guard.
8014         * common/gdb_wait.h: Rename include guard.
8015         * common/gdb_vecs.h: Rename include guard.
8016         * common/gdb_unlinker.h: Rename include guard.
8017         * common/gdb_unique_ptr.h: Rename include guard.
8018         * common/gdb_tilde_expand.h: Rename include guard.
8019         * common/gdb_sys_time.h: Rename include guard.
8020         * common/gdb_string_view.h: Rename include guard.
8021         * common/gdb_splay_tree.h: Rename include guard.
8022         * common/gdb_setjmp.h: Rename include guard.
8023         * common/gdb_ref_ptr.h: Rename include guard.
8024         * common/gdb_optional.h: Rename include guard.
8025         * common/gdb_locale.h: Rename include guard.
8026         * common/gdb_assert.h: Rename include guard.
8027         * common/filtered-iterator.h: Rename include guard.
8028         * common/filestuff.h: Rename include guard.
8029         * common/fileio.h: Rename include guard.
8030         * common/environ.h: Rename include guard.
8031         * common/common-utils.h: Rename include guard.
8032         * common/common-types.h: Rename include guard.
8033         * common/common-regcache.h: Rename include guard.
8034         * common/common-inferior.h: Rename include guard.
8035         * common/common-gdbthread.h: Rename include guard.
8036         * common/common-exceptions.h: Rename include guard.
8037         * common/common-defs.h: Rename include guard.
8038         * common/common-debug.h: Rename include guard.
8039         * common/cleanups.h: Rename include guard.
8040         * common/buffer.h: Rename include guard.
8041         * common/btrace-common.h: Rename include guard.
8042         * common/break-common.h: Rename include guard.
8043         * cli/cli-utils.h: Rename include guard.
8044         * cli/cli-style.h: Rename include guard.
8045         * cli/cli-setshow.h: Rename include guard.
8046         * cli/cli-script.h: Rename include guard.
8047         * cli/cli-interp.h: Rename include guard.
8048         * cli/cli-decode.h: Rename include guard.
8049         * cli/cli-cmds.h: Rename include guard.
8050         * charset-list.h: Add include guard.
8051         * buildsym-legacy.h: Rename include guard.
8052         * bfin-tdep.h: Add include guard.
8053         * ax.h: Rename include guard.
8054         * arm-linux-tdep.h: Add include guard.
8055         * arm-fbsd-tdep.h: Add include guard.
8056         * arch/xtensa.h: Rename include guard.
8057         * arch/tic6x.h: Add include guard.
8058         * arch/i386.h: Add include guard.
8059         * arch/arm.h: Rename include guard.
8060         * arch/arm-linux.h: Rename include guard.
8061         * arch/arm-get-next-pcs.h: Rename include guard.
8062         * arch/amd64.h: Add include guard.
8063         * arch/aarch64-insn.h: Rename include guard.
8064         * arch-utils.h: Rename include guard.
8065         * annotate.h: Add include guard.
8066         * amd64-darwin-tdep.h: Rename include guard.
8067         * aarch64-linux-tdep.h: Add include guard.
8068         * aarch64-fbsd-tdep.h: Add include guard.
8069         * aarch32-linux-nat.h: Add include guard.
8070
8071 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8072
8073         * macrotab.c (macro_define_internal): New function that
8074         factorizes macro_define_object_internal and macro_define_function
8075         code.
8076         (macro_define_object_internal): Use macro_define_internal.
8077         (macro_define_function): Likewise.
8078
8079 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8080
8081         * macrocmd.c (extract_identifier): Return
8082         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8083         callers.
8084
8085 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8086
8087         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8088
8089 2019-02-05  Tom Tromey  <tom@tromey.com>
8090
8091         * target.c (target_stack::unpush): Move assertion earlier.
8092
8093 2019-01-30  Tom Tromey  <tom@tromey.com>
8094
8095         PR python/23615:
8096         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8097         (gdbpy_parse_and_eval): Likewise.
8098         * python/python-internal.h (gdbpy_allow_threads): New class.
8099
8100 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8101
8102         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8103         (aarch64_fbsd_fpregmap): Move earlier.
8104         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8105         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8106         instead of individual calls to trad_frame_set_reg_addr.
8107         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8108         earlier.
8109         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8110         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8111         instead of individual calls to trad_frame_set_reg_addr.
8112
8113 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8114
8115         * CONTRIBUTE: Replace contribution list with wiki link.
8116
8117 2019-01-25  Tom Tromey  <tom@tromey.com>
8118
8119         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8120
8121 2019-01-25  Tom Tromey  <tom@tromey.com>
8122
8123         * xtensa-linux-nat.c: Fix common/ includes.
8124         * xml-support.h: Fix common/ includes.
8125         * xml-support.c: Fix common/ includes.
8126         * x86-linux-nat.c: Fix common/ includes.
8127         * windows-nat.c: Fix common/ includes.
8128         * varobj.h: Fix common/ includes.
8129         * varobj.c: Fix common/ includes.
8130         * value.c: Fix common/ includes.
8131         * valops.c: Fix common/ includes.
8132         * utils.c: Fix common/ includes.
8133         * unittests/xml-utils-selftests.c: Fix common/ includes.
8134         * unittests/utils-selftests.c: Fix common/ includes.
8135         * unittests/unpack-selftests.c: Fix common/ includes.
8136         * unittests/tracepoint-selftests.c: Fix common/ includes.
8137         * unittests/style-selftests.c: Fix common/ includes.
8138         * unittests/string_view-selftests.c: Fix common/ includes.
8139         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8140         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8141         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8142         * unittests/rsp-low-selftests.c: Fix common/ includes.
8143         * unittests/parse-connection-spec-selftests.c: Fix common/
8144         includes.
8145         * unittests/optional-selftests.c: Fix common/ includes.
8146         * unittests/offset-type-selftests.c: Fix common/ includes.
8147         * unittests/observable-selftests.c: Fix common/ includes.
8148         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8149         * unittests/memrange-selftests.c: Fix common/ includes.
8150         * unittests/memory-map-selftests.c: Fix common/ includes.
8151         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8152         * unittests/function-view-selftests.c: Fix common/ includes.
8153         * unittests/environ-selftests.c: Fix common/ includes.
8154         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8155         * unittests/common-utils-selftests.c: Fix common/ includes.
8156         * unittests/cli-utils-selftests.c: Fix common/ includes.
8157         * unittests/array-view-selftests.c: Fix common/ includes.
8158         * ui-file.c: Fix common/ includes.
8159         * tui/tui-io.c: Fix common/ includes.
8160         * tracepoint.h: Fix common/ includes.
8161         * tracepoint.c: Fix common/ includes.
8162         * tracefile-tfile.c: Fix common/ includes.
8163         * top.h: Fix common/ includes.
8164         * top.c: Fix common/ includes.
8165         * thread.c: Fix common/ includes.
8166         * target/waitstatus.h: Fix common/ includes.
8167         * target/waitstatus.c: Fix common/ includes.
8168         * target.h: Fix common/ includes.
8169         * target.c: Fix common/ includes.
8170         * target-memory.c: Fix common/ includes.
8171         * target-descriptions.c: Fix common/ includes.
8172         * symtab.h: Fix common/ includes.
8173         * symfile.c: Fix common/ includes.
8174         * stap-probe.c: Fix common/ includes.
8175         * spu-linux-nat.c: Fix common/ includes.
8176         * sparc-nat.c: Fix common/ includes.
8177         * source.c: Fix common/ includes.
8178         * solib.c: Fix common/ includes.
8179         * solib-target.c: Fix common/ includes.
8180         * ser-unix.c: Fix common/ includes.
8181         * ser-tcp.c: Fix common/ includes.
8182         * ser-pipe.c: Fix common/ includes.
8183         * ser-base.c: Fix common/ includes.
8184         * selftest-arch.c: Fix common/ includes.
8185         * s12z-tdep.c: Fix common/ includes.
8186         * rust-exp.y: Fix common/ includes.
8187         * rs6000-aix-tdep.c: Fix common/ includes.
8188         * riscv-tdep.c: Fix common/ includes.
8189         * remote.c: Fix common/ includes.
8190         * remote-notif.h: Fix common/ includes.
8191         * remote-fileio.h: Fix common/ includes.
8192         * remote-fileio.c: Fix common/ includes.
8193         * regcache.h: Fix common/ includes.
8194         * regcache.c: Fix common/ includes.
8195         * record-btrace.c: Fix common/ includes.
8196         * python/python.c: Fix common/ includes.
8197         * python/py-type.c: Fix common/ includes.
8198         * python/py-inferior.c: Fix common/ includes.
8199         * progspace.h: Fix common/ includes.
8200         * producer.c: Fix common/ includes.
8201         * procfs.c: Fix common/ includes.
8202         * proc-api.c: Fix common/ includes.
8203         * printcmd.c: Fix common/ includes.
8204         * ppc-linux-nat.c: Fix common/ includes.
8205         * parser-defs.h: Fix common/ includes.
8206         * osdata.c: Fix common/ includes.
8207         * obsd-nat.c: Fix common/ includes.
8208         * nat/x86-linux.c: Fix common/ includes.
8209         * nat/x86-linux-dregs.c: Fix common/ includes.
8210         * nat/x86-dregs.h: Fix common/ includes.
8211         * nat/x86-dregs.c: Fix common/ includes.
8212         * nat/ppc-linux.c: Fix common/ includes.
8213         * nat/mips-linux-watch.h: Fix common/ includes.
8214         * nat/mips-linux-watch.c: Fix common/ includes.
8215         * nat/linux-waitpid.c: Fix common/ includes.
8216         * nat/linux-ptrace.h: Fix common/ includes.
8217         * nat/linux-ptrace.c: Fix common/ includes.
8218         * nat/linux-procfs.c: Fix common/ includes.
8219         * nat/linux-personality.c: Fix common/ includes.
8220         * nat/linux-osdata.c: Fix common/ includes.
8221         * nat/linux-namespaces.c: Fix common/ includes.
8222         * nat/linux-btrace.h: Fix common/ includes.
8223         * nat/linux-btrace.c: Fix common/ includes.
8224         * nat/fork-inferior.c: Fix common/ includes.
8225         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8226         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8227         * nat/aarch64-linux.c: Fix common/ includes.
8228         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8229         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8230         * namespace.h: Fix common/ includes.
8231         * mips-linux-tdep.c: Fix common/ includes.
8232         * minsyms.c: Fix common/ includes.
8233         * mi/mi-parse.h: Fix common/ includes.
8234         * mi/mi-main.c: Fix common/ includes.
8235         * mi/mi-cmd-env.c: Fix common/ includes.
8236         * memrange.h: Fix common/ includes.
8237         * memattr.c: Fix common/ includes.
8238         * maint.h: Fix common/ includes.
8239         * maint.c: Fix common/ includes.
8240         * main.c: Fix common/ includes.
8241         * machoread.c: Fix common/ includes.
8242         * location.c: Fix common/ includes.
8243         * linux-thread-db.c: Fix common/ includes.
8244         * linux-nat.c: Fix common/ includes.
8245         * linux-fork.c: Fix common/ includes.
8246         * inline-frame.c: Fix common/ includes.
8247         * infrun.c: Fix common/ includes.
8248         * inflow.c: Fix common/ includes.
8249         * inferior.h: Fix common/ includes.
8250         * inferior.c: Fix common/ includes.
8251         * infcmd.c: Fix common/ includes.
8252         * inf-ptrace.c: Fix common/ includes.
8253         * inf-child.c: Fix common/ includes.
8254         * ia64-linux-nat.c: Fix common/ includes.
8255         * i387-tdep.c: Fix common/ includes.
8256         * i386-tdep.c: Fix common/ includes.
8257         * i386-linux-tdep.c: Fix common/ includes.
8258         * i386-linux-nat.c: Fix common/ includes.
8259         * i386-go32-tdep.c: Fix common/ includes.
8260         * i386-fbsd-tdep.c: Fix common/ includes.
8261         * i386-fbsd-nat.c: Fix common/ includes.
8262         * guile/scm-type.c: Fix common/ includes.
8263         * guile/guile.c: Fix common/ includes.
8264         * go32-nat.c: Fix common/ includes.
8265         * gnu-nat.c: Fix common/ includes.
8266         * gdbthread.h: Fix common/ includes.
8267         * gdbarch-selftests.c: Fix common/ includes.
8268         * gdb_usleep.c: Fix common/ includes.
8269         * gdb_select.h: Fix common/ includes.
8270         * gdb_bfd.c: Fix common/ includes.
8271         * gcore.c: Fix common/ includes.
8272         * fork-child.c: Fix common/ includes.
8273         * findvar.c: Fix common/ includes.
8274         * fbsd-nat.c: Fix common/ includes.
8275         * event-top.c: Fix common/ includes.
8276         * event-loop.c: Fix common/ includes.
8277         * dwarf2read.c: Fix common/ includes.
8278         * dwarf2loc.c: Fix common/ includes.
8279         * dwarf2-frame.c: Fix common/ includes.
8280         * dwarf-index-cache.c: Fix common/ includes.
8281         * dtrace-probe.c: Fix common/ includes.
8282         * disasm-selftests.c: Fix common/ includes.
8283         * defs.h: Fix common/ includes.
8284         * csky-tdep.c: Fix common/ includes.
8285         * cp-valprint.c: Fix common/ includes.
8286         * cp-support.h: Fix common/ includes.
8287         * cp-support.c: Fix common/ includes.
8288         * corelow.c: Fix common/ includes.
8289         * completer.h: Fix common/ includes.
8290         * completer.c: Fix common/ includes.
8291         * compile/compile.c: Fix common/ includes.
8292         * compile/compile-loc2c.c: Fix common/ includes.
8293         * compile/compile-cplus-types.c: Fix common/ includes.
8294         * compile/compile-cplus-symbols.c: Fix common/ includes.
8295         * command.h: Fix common/ includes.
8296         * cli/cli-dump.c: Fix common/ includes.
8297         * cli/cli-cmds.c: Fix common/ includes.
8298         * charset.c: Fix common/ includes.
8299         * build-id.c: Fix common/ includes.
8300         * btrace.h: Fix common/ includes.
8301         * btrace.c: Fix common/ includes.
8302         * breakpoint.h: Fix common/ includes.
8303         * breakpoint.c: Fix common/ includes.
8304         * ax.h:
8305         (enum agent_op): Fix common/ includes.
8306         * ax-general.c (struct aop_map): Fix common/ includes.
8307         * ax-gdb.c: Fix common/ includes.
8308         * auxv.c: Fix common/ includes.
8309         * auto-load.c: Fix common/ includes.
8310         * arm-tdep.c: Fix common/ includes.
8311         * arch/riscv.c: Fix common/ includes.
8312         * arch/ppc-linux-common.c: Fix common/ includes.
8313         * arch/i386.c: Fix common/ includes.
8314         * arch/arm.c: Fix common/ includes.
8315         * arch/arm-linux.c: Fix common/ includes.
8316         * arch/arm-get-next-pcs.c: Fix common/ includes.
8317         * arch/amd64.c: Fix common/ includes.
8318         * arch/aarch64.c: Fix common/ includes.
8319         * arch/aarch64-insn.c: Fix common/ includes.
8320         * arch-utils.c: Fix common/ includes.
8321         * amd64-windows-tdep.c: Fix common/ includes.
8322         * amd64-tdep.c: Fix common/ includes.
8323         * amd64-sol2-tdep.c: Fix common/ includes.
8324         * amd64-obsd-tdep.c: Fix common/ includes.
8325         * amd64-nbsd-tdep.c: Fix common/ includes.
8326         * amd64-linux-tdep.c: Fix common/ includes.
8327         * amd64-linux-nat.c: Fix common/ includes.
8328         * amd64-fbsd-tdep.c: Fix common/ includes.
8329         * amd64-fbsd-nat.c: Fix common/ includes.
8330         * amd64-dicos-tdep.c: Fix common/ includes.
8331         * amd64-darwin-tdep.c: Fix common/ includes.
8332         * agent.c: Fix common/ includes.
8333         * ada-lang.h: Fix common/ includes.
8334         * ada-lang.c: Fix common/ includes.
8335         * aarch64-tdep.c: Fix common/ includes.
8336
8337 2019-01-25  Tom Tromey  <tom@tromey.com>
8338
8339         * common/create-version.sh: Use common/version.h.
8340
8341 2019-01-24  Pedro Alves  <palves@redhat.com>
8342
8343         * infrun.c (signal_stop, signal_print, signal_program)
8344         (signal_catch, signal_pass): Now arrays instead of pointers.
8345         (update_signals_program_target, do_target_resume)
8346         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8347         * linux-nat.c (linux_nat_target::pass_signals)
8348         (linux_nat_target::create_inferior, linux_nat_target::attach):
8349         Adjust.
8350         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8351         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8352         * procfs.c (procfs_target::pass_signals): Adjust.
8353         * record-full.c (record_full_target::resume): Adjust.
8354         * remote.c (remote_target::pass_signals)
8355         (remote_target::program_signals): Adjust.
8356         * target-debug.h (target_debug_print_signals): Now takes a
8357         gdb::array_view as parameter.  Adjust.
8358         * target.h (target_ops) <pass_signals, program_signals>: Replace
8359         pointer and length parameters with gdb::array_view.
8360         (target_pass_signals, target_program_signals): Likewise.
8361         * target-delegates.c: Regenerate.
8362
8363 2019-01-24  Pedro Alves  <palves@redhat.com>
8364
8365         * common/forward-scope-exit.h
8366         (forward_scope_exit::forward_scope_exit): Pass arguments to
8367         m_bind_function directly, instead of creating a std::bind and
8368         copying that.
8369
8370 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8371
8372         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8373         for static members.
8374         (pass_in_v_vfp_candidate): Likewise.
8375
8376 2019-01-23  Tom Tromey  <tom@tromey.com>
8377             Pedro Alves  <palves@redhat.com>
8378
8379         * regcache.c (class regcache_invalidator): Remove.
8380         (regcache::raw_write): Use make_scope_exit.
8381
8382 2019-01-23  Tom Tromey  <tom@tromey.com>
8383
8384         * ui-out.h (class ui_out_emit_type): Update comment.
8385
8386 2019-01-23  Tom Tromey  <tom@tromey.com>
8387
8388         * infrun.c (fetch_inferior_event): Update comment.
8389
8390 2019-01-23  Tom Tromey  <tom@tromey.com>
8391             Pedro Alves  <palves@redhat.com>
8392
8393         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8394         parameter.
8395         (fetch_inferior_event): Use SCOPE_EXIT.
8396
8397
8398 2019-01-23  Tom Tromey  <tom@tromey.com>
8399             Pedro Alves  <palves@redhat.com>
8400
8401         * infrun.c (disable_thread_events): Delete.
8402         (stop_all_threads): Use SCOPE_EXIT.
8403
8404 2019-01-23  Tom Tromey  <tom@tromey.com>
8405             Pedro Alves  <palves@redhat.com>
8406
8407         * symfile.c: Include forward-scope-exit.h.
8408         (clear_symtab_users_cleanup): Replace forward declaration with
8409         a FORWARD_SCOPE_EXIT.
8410         (syms_from_objfile_1): Use the forward_scope_exit and
8411         gdb::optional instead of cleanup_function.
8412         (reread_symbols): Use the forward_scope_exit instead of
8413         cleanup_function.
8414         (clear_symtab_users_cleanup): Remove function.
8415
8416 2019-01-23  Tom Tromey  <tom@tromey.com>
8417             Pedro Alves  <palves@redhat.com>
8418
8419         * linux-nat.c: Include scope-exit.h.
8420         (cleanup_target_stop): Remove.
8421         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8422         SCOPE_EXIT.
8423
8424 2019-01-23  Tom Tromey  <tom@tromey.com>
8425             Pedro Alves  <palves@redhat.com>
8426
8427         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8428         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8429
8430 2019-01-23  Tom Tromey  <tom@tromey.com>
8431             Andrew Burgess  <andrew.burgess@embecosm.com>
8432             Pedro Alves  <palves@redhat.com>
8433
8434         * infrun.c (fetch_inferior_event): Use scope_exit.
8435         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8436         * top.c (execute_command): Use scope_exit.
8437         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8438         * utils.c (do_bpstat_clear_actions_cleanup)
8439         (make_bpstat_clear_actions_cleanup): Remove.
8440
8441 2019-01-23  Tom Tromey  <tom@tromey.com>
8442             Pedro Alves  <palves@redhat.com>
8443
8444         * infrun.c: Include "common/scope-exit.h"
8445         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8446         (wait_for_inferior): Use SCOPE_EXIT.
8447         (fetch_inferior_event): Use scope_exit.
8448
8449 2019-01-23  Tom Tromey  <tom@tromey.com>
8450             Pedro Alves  <palves@redhat.com>
8451
8452         * breakpoint.c (create_breakpoint): Remove cleanup.
8453
8454 2019-01-23  Tom Tromey  <tom@tromey.com>
8455             Andrew Burgess  <andrew.burgess@embecosm.com>
8456             Pedro Alves  <palves@redhat.com>
8457
8458 2019-01-23  Pedro Alves  <palves@redhat.com>
8459
8460         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8461
8462 2019-01-23  Pedro Alves  <palves@redhat.com>
8463             Andrew Burgess  <andrew.burgess@embecosm.com>
8464
8465         * gdbthread.h: Include "common/forward-scope-exit.h".
8466         (scoped_finish_thread_state): Redefine custom class in terms of
8467         forward_scope_exit.
8468
8469 2019-01-23  Pedro Alves  <palves@redhat.com>
8470             Andrew Burgess  <andrew.burgess@embecosm.com>
8471
8472         * common/forward-scope-exit.h: New file.
8473
8474 2019-01-23  Pedro Alves  <palves@redhat.com>
8475             Andrew Burgess  <andrew.burgess@embecosm.com>
8476             Tom Tromey  <tom@tromey.com>
8477
8478         * common/scope-exit.h: New file.
8479
8480 2019-01-23  Pedro Alves  <palves@redhat.com>
8481
8482         * common/preprocessor.h (ESC): Rename to ...
8483         (ESC_PARENS): ... this.
8484         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8485         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8486
8487 2019-01-23  Tom Tromey  <tom@tromey.com>
8488
8489         * language.h (class scoped_switch_to_sym_language_if_auto):
8490         Initialize m_lang in both cases.
8491
8492 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8493
8494         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8495         with XCNEW.
8496
8497 2019-01-22  Tom Tromey  <tom@tromey.com>
8498
8499         * corelow.c: Do not include sys/file.h.
8500
8501 2019-01-22  Tom Tromey  <tom@tromey.com>
8502
8503         * tui/tui-wingeneral.h: Include gdb_curses.h.
8504
8505 2019-01-22  Tom Tromey  <tom@tromey.com>
8506
8507         * source-cache.h (class source_cache) <get_source_lines,
8508         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8509
8510 2019-01-22  Tom Tromey  <tom@tromey.com>
8511
8512         * remote-fileio.h (struct remote_target): Declare.
8513
8514 2019-01-22  Tom Tromey  <tom@tromey.com>
8515
8516         * python/py-arch.c: Do not include py-ref.h.
8517         * python/py-bpevent.c: Do not include py-ref.h.
8518         * python/py-cmd.c: Do not include py-ref.h.
8519         * python/py-continueevent.c: Do not include py-ref.h.
8520         * python/py-event.h: Do not include py-ref.h.
8521         * python/py-evtregistry.c: Do not include py-ref.h.
8522         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8523         * python/py-frame.c: Do not include py-ref.h.
8524         * python/py-framefilter.c: Do not include py-ref.h.
8525         * python/py-function.c: Do not include py-ref.h.
8526         * python/py-infevents.c: Do not include py-ref.h.
8527         * python/py-linetable.c: Do not include py-ref.h.
8528         * python/py-objfile.c: Do not include py-ref.h.
8529         * python/py-param.c: Do not include py-ref.h.
8530         * python/py-prettyprint.c: Do not include py-ref.h.
8531         * python/py-progspace.c: Do not include py-ref.h.
8532         * python/py-symbol.c: Do not include py-ref.h.
8533         * python/py-symtab.c: Do not include py-ref.h.
8534         * python/py-type.c: Do not include py-ref.h.
8535         * python/py-unwind.c: Do not include py-ref.h.
8536         * python/py-utils.c: Do not include py-ref.h.
8537         * python/py-value.c: Do not include py-ref.h.
8538         * python/py-varobj.c: Do not include py-ref.h.
8539         * python/py-xmethods.c: Do not include py-ref.h.
8540         * python/python.c: Do not include py-ref.h.
8541         * varobj.c: Do not include py-ref.h.
8542
8543 2019-01-22  Tom Tromey  <tom@tromey.com>
8544
8545         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8546         keyword for bcache.
8547
8548 2019-01-22  Tom Tromey  <tom@tromey.com>
8549
8550         * compile/compile-cplus-types.c: Remove a comment by #include.
8551
8552 2019-01-22  Tom Tromey  <tom@tromey.com>
8553
8554         * compile/gcc-c-plugin.h: Include compile-internal.h.
8555
8556 2019-01-22  Tom Tromey  <tom@tromey.com>
8557
8558         * stabsread.c (EXTERN): Do not define.
8559         (symnum, next_symbol_text_func, processing_gcc_compilation)
8560         (within_function, global_sym_chain, global_stabs)
8561         (previous_stab_code, this_object_header_files)
8562         (n_this_object_header_files)
8563         (n_allocated_this_object_header_files): Define.
8564         * stabsread.h (EXTERN): Never define.  Use "extern".
8565
8566 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8567
8568         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8569         history_value.
8570
8571 2019-01-21  Tom Tromey  <tom@tromey.com>
8572
8573         * ui-out.c: Fix includes.
8574         * tui/tui-source.c: Fix includes.
8575         * target.c: Fix includes.
8576         * remote.c: Fix includes.
8577         * regcache.c: Fix includes.
8578         * python/py-block.c: Fix includes.
8579         * printcmd.c: Fix includes.
8580         * or1k-tdep.c: Fix includes.
8581         * mi/mi-main.c: Fix includes.
8582         * m32r-tdep.c: Fix includes.
8583         * csky-tdep.c: Fix includes.
8584         * compile/compile-cplus-types.c: Fix includes.
8585         * cli/cli-interp.c: Fix includes.
8586
8587 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8588
8589         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8590         for padding.
8591
8592 2019-01-16  Tom Tromey  <tom@tromey.com>
8593
8594         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8595         earlier.
8596         (struct objfile) <msymbols_range>: Move from top level.
8597         <msymbols>: New method.
8598         (class objfile_msymbols): Remove.
8599         * symtab.c (default_collect_symbol_completion_matches_break_on):
8600         Update.
8601         * symmisc.c (dump_msymbols): Update.
8602         * stabsread.c (scan_file_globals): Update.
8603         * objc-lang.c (info_selectors_command, info_classes_command)
8604         (find_methods): Update.
8605         * minsyms.c (find_solib_trampoline_target): Update.
8606         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8607         * coffread.c (coff_symfile_read): Update.
8608         * ada-lang.c (ada_lookup_simple_minsym)
8609         (ada_collect_symbol_completion_matches): Update.
8610
8611 2019-01-16  Tom Tromey  <tom@tromey.com>
8612
8613         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8614         type.  Remove no-argument constructor.
8615         <iterator::operator++>: Simplify.
8616         <begin>: Update.
8617         <end>: Use minimal_symbol_count.
8618
8619 2019-01-16  Tom Tromey  <tom@tromey.com>
8620
8621         * objfiles.h (struct objfile) <psymtabs>: New method.
8622         (class objfile_psymtabs): Remove.
8623         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8624         typedef.
8625         <range>: New method.
8626         (require_partial_symbols): Change return type.
8627         * psymtab.c (require_partial_symbols)
8628         (psym_expand_symtabs_matching): Update.
8629         * mdebugread.c (parse_partial_symbols): Update.
8630         * dbxread.c (dbx_end_psymtab): Update.
8631
8632 2019-01-15  Tom Tromey  <tom@tromey.com>
8633
8634         * symtab.c (lookup_objfile_from_block)
8635         (lookup_symbol_in_objfile_symtabs)
8636         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8637         (find_line_symtab, info_sources_command)
8638         (default_collect_symbol_completion_matches_break_on)
8639         (make_source_files_completion_list): Update.
8640         * symmisc.c (print_objfile_statistics, dump_objfile)
8641         (maintenance_print_symbols, maintenance_info_symtabs)
8642         (maintenance_check_symtabs, maintenance_info_line_tables):
8643         Update.
8644         * source.c (select_source_symtab)
8645         (forget_cached_source_info_for_objfile): Update.
8646         * objfiles.h (class objfile_compunits): Remove.
8647         (struct objfile) <compunits_range>: New typedef.
8648         (compunits): New method.
8649         * objfiles.c (objfile_relocate1): Update.
8650         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8651         * maint.c (count_symtabs_and_blocks): Update.
8652         * linespec.c (iterate_over_all_matching_symtabs): Update.
8653         * cp-support.c (add_symbol_overload_list_qualified): Update.
8654         * coffread.c (coff_symtab_read): Update.
8655         * ada-lang.c (add_nonlocal_symbols)
8656         (ada_collect_symbol_completion_matches)
8657         (ada_add_global_exceptions): Update.
8658
8659 2019-01-15  Tom Tromey  <tom@tromey.com>
8660
8661         * progspace.h (program_space) <objfiles_safe_range>: New
8662         typedef.
8663         <objfiles_safe>: New method.
8664         * objfiles.h (class all_objfiles_safe): Remove.
8665         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8666         * jit.c (jit_inferior_exit_hook): Update.
8667
8668 2019-01-17  Tom Tromey  <tom@tromey.com>
8669
8670         * progspace.h (program_space) <objfiles_range>: New typedef.
8671         <objfiles>: New method.
8672         <objfiles_head>: Rename from objfiles.
8673         (object_files): Update.
8674         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8675         * guile/scm-pretty-print.c
8676         (ppscm_find_pretty_printer_from_objfiles): Update.
8677         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8678         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8679         Update.
8680         * python/py-progspace.c (pspy_get_objfiles): Update.
8681         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8682         Update.
8683         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8684         (objfpy_lookup_objfile_by_build_id): Update.
8685         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8686         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8687         Update.
8688         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8689         (expand_symtab_containing_pc, lookup_objfile_from_block)
8690         (lookup_static_symbol, basic_lookup_transparent_type)
8691         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8692         (find_line_symtab, info_sources_command)
8693         (default_collect_symbol_completion_matches_break_on)
8694         (make_source_files_completion_list, find_main_name): Update.
8695         * symmisc.c (print_symbol_bcache_statistics)
8696         (print_objfile_statistics, maintenance_print_symbols)
8697         (maintenance_print_msymbols, maintenance_print_objfiles)
8698         (maintenance_info_symtabs, maintenance_check_symtabs)
8699         (maintenance_expand_symtabs, maintenance_info_line_tables):
8700         Update.
8701         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8702         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8703         (map_overlay_command, unmap_overlay_command)
8704         (simple_overlay_update, expand_symtabs_matching)
8705         (map_symbol_filenames): Update.
8706         * symfile-debug.c (set_debug_symfile): Update.
8707         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8708         Update.
8709         * source.c (select_source_symtab, forget_cached_source_info):
8710         Update.
8711         * solib.c (solib_read_symbols): Update.
8712         * solib-spu.c (append_ocl_sos): Update.
8713         * psymtab.c (maintenance_print_psymbols)
8714         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8715         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8716         * printcmd.c (info_symbol_command): Update.
8717         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8718         Update.
8719         * objfiles.h (class all_objfiles): Remove.
8720         * objfiles.c (have_partial_symbols, have_full_symbols)
8721         (have_minimal_symbols, qsort_cmp, update_section_map)
8722         (shared_objfile_contains_address_p)
8723         (default_iterate_over_objfiles_in_search_order): Update.
8724         * objc-lang.c (info_selectors_command, info_classes_command)
8725         (find_methods): Update.
8726         * minsyms.c (find_solib_trampoline_target): Update.
8727         * maint.c (maintenance_info_sections)
8728         (maintenance_translate_address, count_symtabs_and_blocks):
8729         Update.
8730         * main.c (captured_main_1): Update.
8731         * linux-thread-db.c (try_thread_db_load_from_pdir)
8732         (has_libpthread): Update.
8733         * linespec.c (iterate_over_all_matching_symtabs)
8734         (search_minsyms_for_name): Update.
8735         * jit.c (jit_find_objf_with_entry_addr): Update.
8736         * hppa-tdep.c (find_unwind_entry)
8737         (hppa_lookup_stub_minimal_symbol): Update.
8738         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8739         Update.
8740         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8741         (elf_gnu_ifunc_resolve_by_got): Update.
8742         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8743         * dwarf-index-write.c (save_gdb_index_command): Update.
8744         * cp-support.c (add_symbol_overload_list_qualified): Update.
8745         * breakpoint.c (create_overlay_event_breakpoint)
8746         (create_longjmp_master_breakpoint)
8747         (create_std_terminate_master_breakpoint)
8748         (create_exception_master_breakpoint): Update.
8749         * blockframe.c (find_pc_partial_function): Update.
8750         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8751         (ada_collect_symbol_completion_matches)
8752         (ada_add_global_exceptions): Update.
8753
8754 2019-01-17  Tom Tromey  <tom@tromey.com>
8755
8756         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8757         declare VEC.
8758         (solib_target_parse_libraries): Change return type.
8759         (library_list_start_segment, library_list_start_section)
8760         (library_list_end_library, library_list_start_library); Update.
8761         (solib_target_free_library_list): Remove.
8762         (solib_target_parse_libraries): Remove cleanup.  Change return
8763         type.
8764         (solib_target_current_sos): Update.
8765
8766 2019-01-17  Tom Tromey  <tromey@bapiya>
8767
8768         * valprint.c: Replace "the the" with "the".
8769         * symtab.c: Replace "the the" with "the".
8770         * solib.c: Replace "the the" with "the".
8771         * solib-dsbt.c: Replace "the the" with "the".
8772         * linespec.c: Replace "the the" with "the".
8773         * dwarf2loc.h: Replace "the the" with "the".
8774         * amd64-windows-tdep.c: Replace "the the" with "the".
8775         * aarch64-tdep.c: Replace "the the" with "the".
8776
8777 2019-01-16  Keith Seitz  <keiths@redhat.com>
8778
8779         PR gdb/23773
8780         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8781         <builder>: Rename to ..
8782         <m_builder>: ... this and make private.
8783         (dwarf2_cu::get_builder): New method.  Change all users of
8784         `builder' to use this method.
8785         (dwarf2_start_symtab): Move to ...
8786         (dwarf2_cu::start_symtab): ... here.  Update all callers
8787         (setup_type_unit_groups): Move to ...
8788         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8789         callers.
8790         (dwarf2_cu::reset_builder): New method.
8791         (process_full_compunit, process_full_type_unit): Use
8792         dwarf2_cu::reset_builder.
8793         (follow_die_offset): Record the ancestor CU if it is different
8794         from the followed DIE's CU.
8795         (follow_die_sig_1): Likewise.
8796
8797 2019-01-15  Tom Tromey  <tom@tromey.com>
8798
8799         * remote.c (class remote_state) <buf>: Now a char_vector.
8800         <buf_size>: Remove.
8801         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8802         parameter.
8803         (remote_target::getpkt_or_notif_sane_1)
8804         (remote_target::getpkt_sane)
8805         (remote_target::getpkt_or_notif_sane): Likewise.
8806         (class remote_target) <putpkt>: New overload.
8807         (remote_target::read_frame): Change type of "buf_p".  Remove
8808         sizeof_p parameter.
8809         (packet_ok): New overload.
8810         (packet_check_result): New overload.
8811         Update all uses.
8812
8813 2019-01-14  Tom Tromey  <tom@tromey.com>
8814
8815         * remote-notif.c (handle_notification, remote_notif_ack)
8816         (remote_notif_parse): Make "buf" const.
8817         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8818         const.
8819         (remote_notif_parse, remote_notif_ack, handle_notification):
8820         Likewise.
8821         * remote.c (remote_notif_stop_parse): Make "buf" const.
8822         (remote_target::remote_parse_stop_reply): Make "buf" const.
8823         (remote_notif_stop_ack): Make "buf" const.
8824
8825 2019-01-14  Tom Tromey  <tom@tromey.com>
8826
8827         * remote.c (remote_console_output): Make parameter const.
8828
8829 2019-01-14  Tom Tromey  <tom@tromey.com>
8830
8831         * target-debug.h (target_debug_print_signals): Constify.
8832         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8833         * procfs.c (procfs_target::pass_signals): Update.
8834         * linux-nat.c (linux_nat_target::pass_signals): Update.
8835         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8836         * target-delegates.c: Rebuild.
8837         * remote.c (remote_target::program_signals): Update.
8838         (remote_target::pass_signals): Update.
8839         * target.c (target_pass_signals): Constify argument.
8840         (target_program_signals): Likewise.
8841         * target.h (struct target_ops) <pass_signals, program_signals>:
8842         Constify argument.
8843         (target_pass_signals, target_program_signals): Constify argument.
8844
8845 2019-01-14  Tom Tromey  <tom@tromey.com>
8846
8847         PR tui/28819:
8848         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8849
8850 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8851
8852         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8853         field.
8854         * rs6000-tdep.c: Include reggroups.h.
8855         (IS_V_ALIAS_PSEUDOREG): Define.
8856         (rs6000_register_name): Return names for the "vX" aliases.
8857         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8858         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8859         aliases.  Call default_register_reggroup_p for all other
8860         pseudo-registers.
8861         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8862         New functions.
8863         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8864         Handle "vX" aliases.
8865         (v_alias_pseudo_register_collect): New function.
8866         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8867         (rs6000_gdbarch_init): Initialize "vX" aliases as
8868         pseudo-registers.  Restore registration of
8869         rs6000_pseudo_register_reggroup_p with
8870         set_tdesc_pseudo_register_reggroup_p.
8871
8872 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8873
8874         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8875         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8876         set_gdbarch_num_pseudo_regs.
8877
8878 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8879
8880         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8881         Remove arg prefixname, add do_set and do_show.
8882         Add member functions set_list and show_list.
8883         * cli/cli-style.c (class cli_style_option): Update accordingly.
8884         (style_set_list): Move to file scope.
8885         (style_show_list): Likewise.
8886         (set_style): Call help_list.
8887         (show_style): Call cmd_show_list.
8888         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8889         Update to use the new macro.
8890
8891 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8892
8893         * ada-lang.c (_initialize_ada_language): Expand the help text
8894         for the "catch exception" command.
8895
8896 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8897
8898         * symtab.c (matching_obj_sections): Initialize obj,
8899         declare it closer to its usage.
8900
8901 2019-01-10  Tom Tromey  <tom@tromey.com>
8902
8903         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8904         (basic_inf_threads_range): Remove.
8905         (inf_threads_range, inf_non_exited_threads_range)
8906         (safe_inf_threads_range): Use next_adapter.
8907
8908 2019-01-10  Keith Seitz  <keiths@redhat.com>
8909
8910         PR gdb/23712
8911         PR symtab/23010
8912         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8913         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8914
8915 2019-01-10  Keith Seitz  <keiths@redhat.com>
8916
8917         PR gdb/23712
8918         PR symtab/23010
8919         * dictionary.c (pending_to_vector): Remove.
8920         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8921         Remove _1 suffix, replacing functions of the same name.  Update
8922         all callers.
8923         (dict_create_hashed, dict_create_hashed_expandable)
8924         (dict_create_linear, dict_create_linear_expandable, dict_free)
8925         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8926         Make functions static.
8927
8928 2019-01-10  Keith Seitz  <keiths@redhat.com>
8929
8930         PR gdb/23712
8931         PR symtab/23010
8932         * dictionary.h (struct dictionary): Replace declaration with
8933         multidictionary.
8934         (dict_create_hashed, dict_create_hashed_expandable)
8935         (dict_create_linear, dict_create_linear_expandable)
8936         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8937         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8938         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8939         taking multidictionary argument.
8940         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8941         * block.h (struct block) <dict>: Change to multidictionary
8942         and rename `multidict'.
8943         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8944         symmisc.c: Update all dictionary references to multidictionary.
8945
8946 2019-01-10  Keith Seitz  <keiths@redhat.com>
8947
8948         PR gdb/23712
8949         PR symtab/23010
8950         * dictionary.c: Include unordered_map.
8951         (pending_to_vector): New function.
8952         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8953         Rewrite the non-"_1" functions to take vector instead
8954         of linked list.
8955         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8956         "new" _1 versions of the same name.
8957         (multidictionary): Define.
8958         (std::hash<enum language): New definition.
8959         (collate_pending_symbols_by_language, mdict_create_hashed)
8960         (mdict_create_hashed_expandable, mdict_create_linear)
8961         (mdict_create_linear_expandable, mdict_free)
8962         (find_language_dictionary, create_new_language_dictionary)
8963         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8964         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8965         (mdict_size, mdict_empty): New functions.
8966         * dictionary.h (mdict_iterator): Define.
8967
8968 2019-01-10  Pedro Alves  <palves@redhat.com>
8969
8970         * breakpoint.c (read_uploaded_action)
8971         (create_tracepoint_from_upload): Adjust to use
8972         gdb::unique_xmalloc_ptr.
8973         * ctf.c (ctf_write_uploaded_tp):
8974         (SET_ARRAY_FIELD): Use emplace_back.
8975         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8976         * tracefile-tfile.c (tfile_write_uploaded_tp):
8977         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8978         gdb::unique_xmalloc_ptr.
8979         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8980         at_string, cond_string, cmd_strings>: Replace char pointers
8981         with gdb::unique_xmalloc_ptr.
8982
8983 2019-01-10  Pedro Alves  <palves@redhat.com>
8984
8985         * solib-target.c (library_list_start_library): Don't xstrdup name.
8986
8987 2019-01-10  Pedro Alves  <palves@redhat.com>
8988
8989         * mdebugread.c (parse_partial_symbols): Use
8990         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8991
8992 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8993
8994         * linux-fork.c (scoped_switch_fork_info)
8995         <~scoped_switch_fork_info>: Fix incorrect variable name.
8996
8997 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8998
8999         * linux-fork.c (scoped_switch_fork_info)
9000         <scoped_switch_fork_info>: Make explicit.
9001         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9002
9003 2019-01-10  Tom Tromey  <tom@tromey.com>
9004
9005         * objfiles.h (objfile::reset_psymtabs): Update.
9006         * objfiles.c (objfile::objfile): Update.
9007         * psymtab.h (psymtab_storage::obstack): Update.
9008         (psymtab_storage::m_obstack): Use gdb::optional.
9009         (class psymtab_storage): Update comment.  Remove objfile
9010         parameter.
9011         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9012
9013 2019-01-10  Tom Tromey  <tom@tromey.com>
9014
9015         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9016         <free_psymtabs>: Now private.
9017         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9018         (allocate_psymtab): Use new method.
9019
9020 2019-01-10  Tom Tromey  <tom@tromey.com>
9021
9022         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9023         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9024         * mdebugread.c (parse_partial_symbols): Use
9025         allocate_dependencies.
9026         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9027         allocate_dependencies.
9028         (process_psymtab_comp_unit_reader)
9029         (build_type_psymtab_dependencies): Likewise.
9030         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9031
9032 2019-01-10  Tom Tromey  <tom@tromey.com>
9033
9034         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9035         PSYMBOL_SET_LANGUAGE.
9036         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9037
9038 2019-01-10  Tom Tromey  <tom@tromey.com>
9039
9040         * psymtab.h (psymtab_storage::obstack): New method.
9041         <m_obstack>: Rename from obstack; now private.
9042         * psymtab.c (psymtab_storage): Update.
9043         * dwarf2read.c (create_addrmap_from_index)
9044         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9045         Update.
9046
9047 2019-01-10  Tom Tromey  <tom@tromey.com>
9048
9049         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9050         * objfiles.h (objfile::reset_psymtabs): New method.
9051
9052 2019-01-10  Tom Tromey  <tom@tromey.com>
9053
9054         * symmisc.c (print_symbol_bcache_statistics): Update.
9055         (print_objfile_statistics): Update.
9056         * symfile.c (reread_symbols): Update.
9057         * psymtab.h (class psymtab_storage): New.
9058         * psymtab.c (psymtab_storage): New constructor.
9059         (~psymtab_storage): New destructor.
9060         (require_partial_symbols): Update.
9061         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9062         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9063         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9064         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9065         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9066         (start_psymtab_common, end_psymtab_common)
9067         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9068         (allocate_psymtab): Update.
9069         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9070         Update.
9071         (dump_psymtab_addrmap, maintenance_print_psymbols)
9072         (maintenance_check_psymtabs): Update.
9073         (class objfile_psymtabs): Move to objfiles.h.
9074         * psympriv.h (discard_psymtab): Now inline.
9075         (psymtab_discarder::psymtab_discarder): Update.
9076         (psymtab_discarder::~psymtab_discarder): Update.
9077         (ALL_OBJFILE_PSYMTABS): Rewrite.
9078         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9079         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9080         Remove fields.
9081         <partial_symtabs>: New field.
9082         (class objfile_psymtabs): Move from psymtab.h.  Update.
9083         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9084         psymbol_cache.
9085         (objfile::~objfile): Don't destroy psymbol_cache.
9086         * mdebugread.c (parse_partial_symbols): Update.
9087         * dwarf2read.c (create_addrmap_from_index)
9088         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9089         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9090         (add_partial_subprogram, dwarf2_ranges_read): Update.
9091         * dwarf-index-write.c (write_address_map)
9092         (write_one_signatured_type, recursively_write_psymbols)
9093         (class debug_names, class debug_names, write_psymtabs_to_index):
9094         Update.
9095
9096 2019-01-10  Tom Tromey  <tom@tromey.com>
9097
9098         * symtab.h (SYMBOL_SET_NAMES): Update.
9099         (symbol_set_names): Update.
9100         (MSYMBOL_SET_NAMES): Update.
9101         * symtab.c (symbol_set_names): Change argument to be an
9102         objfile_per_bfd_storage.
9103         * psymtab.c (add_psymbol_to_bcache): Update.
9104         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9105
9106 2019-01-10  Tom Tromey  <tom@tromey.com>
9107
9108         * symtab.c (create_demangled_names_hash): Change argument to be an
9109         objfile_per_bfd_storage.
9110         (symbol_set_names): Update.
9111
9112 2019-01-10  Tom Tromey  <tom@tromey.com>
9113
9114         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9115         init_psymbol_list.
9116         * psymtab.c (init_psymbol_list): Do nothing if already called.
9117         * psympriv.h (init_psymbol_list): Add comment.
9118         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9119         init_psymbol_list.
9120         * dbxread.c (dbx_symfile_read): Unconditionally call
9121         init_psymbol_list.
9122
9123 2019-01-10  Tom Tromey  <tom@tromey.com>
9124
9125         * xcoffread.c (scan_xcoff_symtab): Update.
9126         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9127         "where".
9128         * mdebugread.c (parse_partial_symbols)
9129         (handle_psymbol_enumerators): Update.
9130         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9131         * dbxread.c (read_dbx_symtab): Update.
9132         * psympriv.h (psymbol_placement): New enum.
9133         (add_psymbol_to_list): Update.
9134
9135 2019-01-10  Tom Tromey  <tom@tromey.com>
9136
9137         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9138         static_psymbols parameters.
9139         (scan_xcoff_symtab): Update.
9140         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9141         static_psymbols parameters.
9142         * psympriv.h (start_psymtab_common): Update.
9143         * mdebugread.c (parse_partial_symbols): Update.
9144         * dwarf2read.c (create_partial_symtab): Update.
9145         * dbxread.c (read_dbx_symtab): Update.
9146         (start_psymtab): Remove global_psymbols and static_psymbols
9147         parameters.
9148
9149 2019-01-10  Tom Tromey  <tom@tromey.com>
9150
9151         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9152         * psymtab.c (allocate_psymtab): Add comment.
9153         * psympriv.h (allocate_psymtab): Add comment.
9154         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9155         initializations.
9156         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9157
9158 2019-01-10  Tom Tromey  <tom@tromey.com>
9159
9160         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9161         Don't declare.
9162         * mipsread.c: Include mdebugread.h.
9163         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9164         Declare.
9165         * elfread.c: Include mdebugread.h.
9166
9167 2019-01-09  Tom Tromey  <tom@tromey.com>
9168
9169         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9170         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9171         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9172         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9173         (psym_lookup_symbol, psym_find_last_source_symtab)
9174         (psym_forget_cached_source_info, psym_print_stats)
9175         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9176         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9177         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9178         (psym_find_compunit_symtab_by_address)
9179         (maintenance_print_psymbols, maintenance_info_psymtabs)
9180         (maintenance_check_psymtabs): Use ranged for.
9181         * psymtab.h (class objfile_psymtabs): New.
9182         (require_partial_symbols): Return objfile_psymtabs.
9183         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9184
9185 2019-01-09  Tom Tromey  <tom@tromey.com>
9186
9187         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9188         (find_pc_mapped_section, list_overlays_command)
9189         (map_overlay_command, unmap_overlay_command)
9190         (simple_overlay_update): Use all_objfiles.
9191         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9192         * printcmd.c (info_symbol_command): Use all_objfiles.
9193         * objfiles.h (ALL_OBJSECTIONS): Remove.
9194         * maint.c (maintenance_translate_address): Use all_objfiles.
9195         * gcore.c (gcore_create_callback): Use all_objfiles.
9196         (objfile_find_memory_regions): Likewise.
9197
9198 2019-01-09  Tom Tromey  <tom@tromey.com>
9199
9200         * symtab.c (find_line_symtab, info_sources_command)
9201         (make_source_files_completion_list): Use objfile_compunits.
9202         * source.c (select_source_symtab): Use objfile_compunits.
9203         * objfiles.h (struct objfile): Update comment.
9204         (ALL_OBJFILES): Remove.
9205         (ALL_FILETABS): Remove.
9206         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9207         objfile_compunits.
9208
9209 2019-01-09  Tom Tromey  <tom@tromey.com>
9210
9211         * symmisc.c (print_objfile_statistics, dump_objfile)
9212         (maintenance_print_symbols): Use compunit_filetabs.
9213         * source.c (forget_cached_source_info_for_objfile): Use
9214         compunit_filetabs.
9215         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9216         (ALL_FILETABS): Use compunit_filetabs.
9217         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9218         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9219
9220 2019-01-09  Tom Tromey  <tom@tromey.com>
9221
9222         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9223         (compunit_filetabs): New.
9224         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9225         compunit_filetabs.
9226         (info_sources_command, make_source_files_completion_list): Remove
9227         declaration.
9228         * symmisc.c (print_objfile_statistics, dump_objfile)
9229         (maintenance_print_symbols): Remove declaration.
9230         (maintenance_info_symtabs): Use compunit_filetabs.
9231         (maintenance_info_line_tables): Likewise.
9232         * source.c (select_source_symtab): Change local variable name.
9233         (forget_cached_source_info_for_objfile): Remove declaration.
9234         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9235         * objfiles.c (objfile_relocate1): Remove declaration.
9236         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9237         declaration.
9238         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9239         * coffread.c (coff_symtab_read): Remove declaration.
9240         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9241         compunit_filetabs.
9242
9243 2019-01-09  Tom Tromey  <tom@tromey.com>
9244
9245         * symtab.c (lookup_objfile_from_block)
9246         (find_pc_sect_compunit_symtab, search_symbols)
9247         (default_collect_symbol_completion_matches_break_on): Use
9248         objfile_compunits.
9249         * objfiles.h (ALL_COMPUNITS): Remove.
9250         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9251         * cp-support.c (add_symbol_overload_list_qualified): Use
9252         objfile_compunits.
9253         * ada-lang.c (ada_collect_symbol_completion_matches)
9254         (ada_add_global_exceptions): Use objfile_compunits.
9255
9256 2019-01-09  Tom Tromey  <tom@tromey.com>
9257
9258         * source.c (select_source_symtab)
9259         (forget_cached_source_info_for_objfile): Remove declaration.
9260         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9261         declaration.
9262         * maint.c (count_symtabs_and_blocks): Remove declaration.
9263         * cp-support.c (add_symbol_overload_list_qualified): Remove
9264         declaration.
9265         * coffread.c (coff_symtab_read): Remove declaration.
9266         * symtab.c (lookup_symbol_in_objfile_symtabs)
9267         (basic_lookup_transparent_type_1): Use objfile_compunits.
9268         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9269         (info_sources_command, search_symbols)
9270         (default_collect_symbol_completion_matches_break_on)
9271         (make_source_files_completion_list): Remove declaration.
9272         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9273         (ada_collect_symbol_completion_matches)
9274         (ada_add_global_exceptions): Remove declaration.
9275         * linespec.c (iterate_over_all_matching_symtabs): Use
9276         objfile_compunits.
9277         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9278         (class objfile_compunits): New.
9279         (ALL_COMPUNITS): Use objfile_compunits.
9280         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9281         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9282         objfile_compunits.
9283         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9284
9285 2019-01-09  Tom Tromey  <tom@tromey.com>
9286
9287         * symtab.c (search_symbols)
9288         (default_collect_symbol_completion_matches_break_on): Use
9289         objfile_msymbols.
9290         * ada-lang.c (ada_lookup_simple_minsym)
9291         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9292         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9293         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9294         objfile_msymbols.
9295         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9296         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9297         * objc-lang.c (find_methods): Use objfile_msymbols.
9298         (info_selectors_command, info_classes_command): Likewise.
9299         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9300         * objfiles.h (class objfile_msymbols): New.
9301         (ALL_OBJFILE_MSYMBOLS): Remove.
9302         (ALL_MSYMBOLS): Remove.
9303
9304 2019-01-09  Tom Tromey  <tom@tromey.com>
9305
9306         * common/next-iterator.h (next_adapter): Add Iterator template
9307         parameter.
9308         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9309         (class all_objfiles_safe): New.
9310         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9311         * objfiles.c (put_objfile_before): Update comment.
9312         (add_separate_debug_objfile): Likewise.
9313         (free_all_objfiles): Use all_objfiles_safe.
9314         (objfile_purge_solibs): Likewise.
9315
9316 2019-01-09  Tom Tromey  <tom@tromey.com>
9317
9318         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9319         (expand_symtab_containing_pc, lookup_static_symbol)
9320         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9321         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9322         all_objfiles.
9323         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9324         * breakpoint.c (create_overlay_event_breakpoint)
9325         (create_longjmp_master_breakpoint)
9326         (create_std_terminate_master_breakpoint)
9327         (create_exception_master_breakpoint): Use all_objfiles.
9328         * linux-thread-db.c (try_thread_db_load_from_pdir)
9329         (has_libpthread): Use all_objfiles.
9330         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9331         * linespec.c (iterate_over_all_matching_symtabs)
9332         (search_minsyms_for_name): Use all_objfiles.
9333         * maint.c (maintenance_info_sections): Use all_objfiles.
9334         * main.c (captured_main_1): Use all_objfiles.
9335         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9336         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9337         * guile/scm-pretty-print.c
9338         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9339         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9340         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9341         (maintenance_print_msymbols): Use all_objfiles.
9342         * source.c (select_source_symtab): Use all_objfiles.
9343         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9344         * symfile.c (remove_symbol_file_command)
9345         (expand_symtabs_matching, map_symbol_filenames): Use
9346         all_objfiles.
9347         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9348         all_objfiles.
9349         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9350         * objc-lang.c (find_methods): Use all_objfiles.
9351         * objfiles.c (have_partial_symbols, have_full_symbols)
9352         (have_minimal_symbols, qsort_cmp)
9353         (default_iterate_over_objfiles_in_search_order): Use
9354         all_objfiles.
9355         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9356         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9357         (maintenance_check_psymtabs): Use all_objfiles.
9358         (ALL_PSYMTABS): Remove.
9359         * compile/compile-object-run.c (do_module_cleanup): Use
9360         all_objfiles.
9361         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9362         * cp-support.c (add_symbol_overload_list_qualified): Use
9363         all_objfiles.
9364         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9365         Use all_objfiles.
9366         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9367         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9368         all_objfiles.
9369         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9370         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9371         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9372         Uses all_objfiles.
9373         * solib.c (solib_read_symbols): Use all_objfiles
9374
9375 2019-01-09  Tom Tromey  <tom@tromey.com>
9376
9377         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9378         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9379         all_objfiles.
9380         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9381         * symmisc.c (print_symbol_bcache_statistics)
9382         (print_objfile_statistics, maintenance_print_objfiles)
9383         (maintenance_info_symtabs, maintenance_check_symtabs)
9384         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9385         all_objfiles.
9386         * source.c (forget_cached_source_info): Use all_objfiles.
9387         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9388         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9389         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9390         * objfiles.c (update_section_map): Use all_objfiles.
9391         (shared_objfile_contains_address_p): Likewise.
9392         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9393         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9394
9395 2019-01-09  Tom Tromey  <tom@tromey.com>
9396
9397         * common/next-iterator.h: New file.
9398         * objfiles.h (class all_objfiles): New.
9399         (struct objfile_iterator): New.
9400
9401 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9402
9403         * NEWS: Move the description of the changed "frame", "select-frame",
9404          and "info frame" commands to the Changed commands section.
9405
9406 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9407
9408         * gdbtypes.c (check_stub_method_group): Remove handling of old
9409         mangling schemes.
9410         * linespec.c (find_methods): Likewise.
9411         * stabsread.c (read_member_functions): Likewise.
9412         * valops.c (search_struct_method): Likewise.
9413         (value_struct_elt_for_reference): Likewise.
9414         * NEWS: Mention this change.
9415
9416 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9417
9418         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9419         print_source_lines.
9420         * source.c (print_source_lines_base): Update line number check.
9421         (print_source_lines): New function.
9422         (source_lines_range::source_lines_range): New function.
9423         * source.h (class source_lines_range): New class.
9424         (print_source_lines): New declaration.
9425
9426 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9427
9428         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9429
9430 2019-01-08  Tom Tromey  <tom@tromey.com>
9431             Simon Marchi  <simon.marchi@ericsson.com>
9432
9433         PR gdb/24060
9434         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9435         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9436         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9437         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9438         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9439         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9440
9441 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9442
9443         * source.c (select_source_symtab): Move header comment to
9444         declaration in source.h.
9445         (forget_cached_source_info_for_objfile): Likewise.
9446         (forget_cached_source_info): Likewise.
9447         (identify_source_line): Likewise.
9448         * source.h (identify_source_line): Move declaration from symtab.h
9449         and add comment from source.c
9450         (print_source_lines): Likewise.
9451         (forget_cached_source_info_for_objfile): Likewise.
9452         (forget_cached_source_info): Likewise.
9453         (select_source_symtab): Likewise.
9454         (enum print_source_lines_flag): Move definition from symtab.h.
9455         * symtab.h (identify_source_line): Move declaration to source.h.
9456         (print_source_lines): Likewise.
9457         (forget_cached_source_info_for_objfile): Likewise.
9458         (forget_cached_source_info): Likewise.
9459         (select_source_symtab): Likewise.
9460         (enum print_source_lines_flag): Move definition to source.h.
9461         * tui/tui-hooks.c: Add 'source.h' include.
9462
9463 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9464
9465         * source.c (print_source_lines_base): Handle requests to print
9466         reverse line number sequences, and guard against empty lines
9467         string.
9468
9469 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9470
9471         * source.c (print_source_lines_base): Fix skip of '\r' if next
9472         character is '\n'.
9473
9474 2019-01-06  Tom Tromey  <tom@tromey.com>
9475
9476         * c-exp.y (struct c_parse_state) <macro_original_text,
9477         expansion_obstack>: New member.
9478         (macro_original_text, expansion_obstack): Remove globals.
9479         (scan_macro_expansion, scanning_macro_expansion)
9480         (finished_macro_expansion): Update.
9481         (scan_macro_cleanup): Remove.
9482         (yylex, c_parse): Update.
9483
9484 2019-01-06  Tom Tromey  <tom@tromey.com>
9485
9486         * c-exp.y (struct c_parse_state) <strings>: New member.
9487         (operator_stoken): Update.
9488
9489 2019-01-06  Tom Tromey  <tom@tromey.com>
9490
9491         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9492         (union type_stack_elt) <typelist_val>: Now a pointer to
9493         std::vector.
9494         (type_stack_cleanup): Don't declare.
9495         (push_typelist): Update.
9496         * parse.c (pop_typelist): Return a std::vector.
9497         (push_typelist): Take a std::vector.
9498         (follow_types): Update.  Do not free args.
9499         (type_stack_cleanup): Remove.
9500         * c-exp.y (struct c_parse_state): New.
9501         (cpstate): New global.
9502         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9503         (nonempty_typelist): Update.
9504         (func_mod): Create a new vector.
9505         (c_parse): Create a c_parse_state.
9506         (check_parameter_typelist): Do not delete params.
9507         (function_method): Update.  Do not delete type_list.
9508
9509 2019-01-06  Tom Tromey  <tom@tromey.com>
9510
9511         PR gdb/28155:
9512         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9513         check_typedef.
9514         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9515         (print_return_value): Likewise.
9516
9517 2019-01-05  Tom Tromey  <tom@tromey.com>
9518
9519         * contrib/cleanup_check.py: Remove.
9520         * contrib/gcc-with-excheck: Remove.
9521         * contrib/exsummary.py: Remove.
9522         * contrib/excheck.py: Remove.
9523
9524 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9525
9526         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9527         NULL. Initialize tpprev to NULL instead of assigning it
9528         to NULL on the next statement.
9529         * windows-nat.c (windows_delete_thread): Remove check for
9530         main_thread_id before printing thread exit notifications.
9531         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9532         Remove thread ID check against main_thread_id.
9533         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9534         windows_delete_thread.
9535         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9536
9537 2019-01-04  Tom Tromey  <tom@tromey.com>
9538
9539         * compile/compile.c (_initialize_compile): Use upper case for
9540         metasyntactic variables.
9541         * symmisc.c (_initialize_symmisc): Use upper case for
9542         metasyntactic variables.
9543         * psymtab.c (_initialize_psymtab): Use upper case for
9544         metasyntactic variables.
9545         * demangle.c (demangle_command): Use upper case for metasyntactic
9546         variables.
9547         (_initialize_demangler): Likewise.
9548         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9549         variables.
9550
9551 2019-01-03  Tom Tromey  <tom@tromey.com>
9552
9553         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9554
9555 2019-01-03  Tom Tromey  <tom@tromey.com>
9556
9557         * python/py-symtab.c (salpy_str): Update.
9558         (struct salpy_sal_object) <symtab>: Now a PyObject.
9559         (salpy_dealloc): Update.
9560         (del_objfile_sal): Use gdbpy_ref.
9561
9562 2019-01-03  Tom Tromey  <tom@tromey.com>
9563
9564         * python/py-type.c (convert_field): Use new_reference.  Return
9565         gdbpy_ref.
9566         (make_fielditem): Return gdbpy_ref.
9567         (typy_fields): Update.
9568         (typy_getitem): Update.
9569         (field_name): Return gdbpy_ref.  Use new_reference.
9570         (typy_iterator_iternext): Update.
9571
9572 2019-01-03  Tom Tromey  <tom@tromey.com>
9573
9574         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9575
9576 2019-01-03  Tom Tromey  <tom@tromey.com>
9577
9578         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9579         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9580         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9581         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9582         (pspy_set_type_printers): Likewise.
9583         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9584         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9585         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9586         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9587         (objfpy_set_type_printers): Likewise.
9588
9589 2019-01-03  Tom Tromey  <tom@tromey.com>
9590
9591         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9592         (gdbpy_print_stack): Use gdbpy_err_fetch.
9593         * python/python-internal.h (class gdbpy_err_fetch): New class.
9594         (class gdbpy_enter) <m_error_type, m_error_value,
9595         m_error_traceback>: Remove.
9596         <m_error>: New member.
9597         (gdbpy_exception_to_string): Don't declare.
9598         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9599         * python/py-value.c (convert_value_from_python): Use
9600         gdbpy_err_fetch.
9601         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9602         gdbpy_exception_to_string.
9603         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9604         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9605         gdbpy_err_fetch.
9606
9607 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9608
9609         * linux-nat.c (delete_lwp_cleanup): Delete.
9610         (struct lwp_deleter): New struct.
9611         (lwp_info_up): New typedef.
9612         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9613         lwp_info_up.
9614
9615 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9616
9617         * linux-fork.c (class scoped_switch_fork_info): New class.
9618         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9619
9620 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9621
9622         * valops.c (find_overload_match): Remove use of null_cleanup, and
9623         calls to do_cleanups.
9624
9625 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9626
9627         * compile/compile-cplus-types.c
9628         (compile_cplus_instance::decl_name): Handle changes to
9629         cp_func_name.
9630         * cp-support.c (cp_func_name): Update header comment, update
9631         return type.
9632         * cp-support.h (cp_func_name): Update return type in declaration.
9633         * valops.c (find_overload_match): Move temp_func local to top
9634         level of function and change its type.  Use temp_func to hold and
9635         delete temporary string obtained from cp_func_name.
9636
9637 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9638
9639         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9640         gdb::char_vector, remove cleanup, and update uses of `msg`.
9641
9642 2019-01-03  Jim Wilson  <jimw@sifive.com>
9643
9644         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9645
9646 2019-01-02  Tom Tromey  <tom@tromey.com>
9647
9648         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9649         (tdesc_parse_xml): Remove cleanups.
9650         * target-descriptions.h (make_cleanup_free_target_description):
9651         Don't declare.
9652         (target_desc_deleter): New struct.
9653         (target_desc_up): New typedef.
9654         * target-descriptions.c (target_desc_deleter::operator()): Rename
9655         from free_target_description.
9656         (make_cleanup_free_target_description): Remove.
9657
9658 2019-01-02  Tom Tromey  <tom@tromey.com>
9659
9660         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9661         constructor, destructor.
9662         (linespec_parser): Remove typedef.
9663         (~linespec_parser): Rename from linespec_parser_delete.
9664         (linespec_lex_to_end, linespec_complete_label)
9665         (linespec_complete): Update.
9666         (decode_line_full): Remove cleanups.
9667         (decode_line_1): Update.
9668
9669 2019-01-02  Tom Tromey  <tom@tromey.com>
9670
9671         * python/python-internal.h (inferior_to_inferior_object): Change
9672         return type.
9673         * python/py-exitedevent.c (create_exited_event_object): Update.
9674         * python/py-inferior.c (inferior_to_inferior_object): Return
9675         gdbpy_ref.
9676         (python_new_inferior, python_inferior_deleted)
9677         (thread_to_thread_object, delete_thread_object)
9678         (build_inferior_list, gdbpy_selected_inferior): Update.
9679         * python/py-infthread.c (create_thread_object): Update.  Also fail
9680         if inferior_to_inferior_object fails.
9681
9682 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9683
9684         * inferior.h (class inferior) <displaced_step_state>: New field.
9685         * infrun.h (struct displaced_step_state): Move here from
9686         infrun.c.  Initialize fields, add constructor.
9687         <inf>: Remove field.
9688         <reset>: New method.
9689         * infrun.c (struct displaced_step_inferior_state): Move to
9690         infrun.h.
9691         (displaced_step_inferior_states): Remove.
9692         (get_displaced_stepping_state): Adust.
9693         (displaced_step_in_progress_any_inferior): Adjust.
9694         (displaced_step_in_progress_thread): Adjust.
9695         (displaced_step_in_progress): Adjust.
9696         (add_displaced_stepping_state): Remove.
9697         (get_displaced_step_closure_by_addr): Adjust.
9698         (remove_displaced_stepping_state): Remove.
9699         (infrun_inferior_exit): Call displaced_step_state.reset.
9700         (use_displaced_stepping): Don't check for NULL.
9701         (displaced_step_prepare_throw): Call
9702         get_displaced_stepping_state.
9703         (displaced_step_fixup): Don't check for NULL.
9704         (prepare_for_detach): Don't check for NULL.
9705
9706 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9707
9708         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9709          in case of call that did not complete.
9710
9711 2019-01-02  Andrey Utkin  <autkin@undo.io>
9712
9713         * symfile.c (find_separate_debug_file): Fix search of debug files for
9714         remote debuggee.
9715
9716 2019-01-02  Tom Tromey  <tom@tromey.com>
9717
9718         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9719         indentation.
9720         * python/py-frame.c (frapy_older): Remove cast.
9721         (frapy_newer): Likewise.
9722         * python/py-breakpoint.c (local_setattro): Remove cast.
9723         * python/py-arch.c (archpy_name): Remove local variable.
9724         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9725
9726 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9727
9728         * unittests/basic_string_view/element_access/char/empty.cc:
9729         Fix year range in copyright header.
9730
9731 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9732
9733         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9734         Delete.
9735         <operator==>: Update with for removed field.
9736         <hash>: Likewise.
9737         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9738         <isa_features>: ...this.
9739         <abi_features>: New field.
9740         (riscv_isa_flen): Update comment.
9741         (riscv_abi_xlen): New declaration.
9742         (riscv_abi_flen): New declaration.
9743         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9744         isa_features.
9745         (riscv_abi_xlen): New function.
9746         (riscv_isa_flen): Update to get answer from isa_features.
9747         (riscv_abi_flen): New function.
9748         (riscv_has_fp_abi): Update to get answer from abi_features.
9749         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9750         xlen and flen.
9751         (riscv_call_info) <xlen, flen>: Update comment.
9752         (riscv_call_arg_struct): Remove invalid assertions
9753         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9754         is removed.
9755         (riscv_gdbarch_init): Gather isa features and abi features
9756         separately, ensure both match on the gdbarch when reusing an old
9757         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9758         a target with 64-bit float hardware.
9759
9760 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9761
9762         * source.c (search_command_helper): Stop reverse search
9763         when line 1 has been searched.
9764
9765 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9766
9767         * record-full.c (record_full_base_target::close): Rewrite
9768         record_full_core_buf_list free logic.
9769
9770 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9771
9772         * break-catch-syscall.c (print_one_catch_syscall): xfree
9773         the last text.
9774
9775 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9776
9777         * top.c (print_gdb_version): Update Copyright year in version
9778         message.
9779
9780 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9781
9782         Update copyright year range in all GDB files.
9783
9784 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9785
9786         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9787
9788 For older changes see ChangeLog-2018.
9789 \f
9790 Local Variables:
9791 mode: change-log
9792 left-margin: 8
9793 fill-column: 74
9794 version-control: never
9795 coding: utf-8
9796 End:
9797