gdb/ChangeLog

   1 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
   4         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
   5
   6 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   7
   8         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
   9         variant for ada_tasks_pspace_data_handle and
  10         ada_tasks_inferior_data_handle.
  11         (ada_tasks_pspace_data_cleanup): New function.
  12         (ada_tasks_inferior_data_cleanup): New function.
  13
  14 2019-02-17  Tom Tromey  <tom@tromey.com>
  15
  16         * macrotab.h (macro_source_fullname): Return a std::string.
  17         * macrotab.c (macro_include, check_for_redefinition)
  18         (macro_undef, macro_lookup_definition, foreach_macro)
  19         (foreach_macro_in_scope): Update.
  20         (macro_source_fullname): Return a std::string.
  21         * macrocmd.c (show_pp_source_pos): Update.
  22
  23 2019-02-17  Tom Tromey  <tom@tromey.com>
  24
  25         * macrocmd.c (show_pp_source_pos): Style the file names.
  26
  27 2019-02-17  Tom Tromey  <tom@tromey.com>
  28
  29         PR tui/24197:
  30         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
  31
  32 2019-02-17  Tom Tromey  <tom@tromey.com>
  33
  34         * ada-lang.c (user_select_syms): Use filtered printing.
  35         * utils.c (wrap_style): New global.
  36         (desired_style): Remove.
  37         (emit_style_escape): Add stream parameter.
  38         (set_output_style, reset_terminal_style, prompt_for_continue):
  39         Update.
  40         (flush_wrap_buffer): Only flush gdb_stdout.
  41         (wrap_here): Set wrap_style.
  42         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
  43         treat escape sequences as a character.  Change when wrap buffer is
  44         flushed.
  45         (fputs_styled): Do not set the output style when the default is
  46         requested.
  47         * ui-style.h (struct ui_file_style) <is_default>: New method.
  48         * source.c (print_source_lines_base): Emit escape sequences in one
  49         piece.
  50
  51 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  52
  53         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
  54         integers and enumeration types.
  55
  56 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
  57
  58         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
  59         instead of lookup_symbol_in_language
  60         (do_exact_match): New function.
  61         (ada_get_symbol_name_matcher): Return do_exact_match when
  62         doing a verbatim match.
  63
  64 2019-02-15  Tom Tromey  <tromey@adacore.com>
  65
  66         * ravenscar-thread.c (ravenscar_thread_target::resume)
  67         (ravenscar_thread_target::wait): Special case wildcard requests.
  68
  69 2019-02-15  Tom Tromey  <tromey@adacore.com>
  70
  71         * ravenscar-thread.c (base_ptid): Remove.
  72         (struct ravenscar_thread_target) <close>: New method.
  73         <m_base_ptid>: New member.
  74         <update_inferior_ptid, active_task, task_is_currently_active,
  75         runtime_initialized>: Declare methods.
  76         <ravenscar_thread_target>: Add constructor.
  77         (ravenscar_thread_target::task_is_currently_active)
  78         (ravenscar_thread_target::update_inferior_ptid)
  79         (ravenscar_runtime_initialized): Rename.  Now methods.
  80         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
  81         (ravenscar_thread_target::update_thread_list): Update.
  82         (ravenscar_thread_target::active_task): Now method.
  83         (ravenscar_thread_target::store_registers)
  84         (ravenscar_thread_target::prepare_to_store)
  85         (ravenscar_thread_target::prepare_to_store)
  86         (ravenscar_thread_target::mourn_inferior): Update.
  87         (ravenscar_inferior_created): Use "new" to create target.
  88         (ravenscar_thread_target::get_ada_task_ptid): Update.
  89         (_initialize_ravenscar): Don't initialize base_ptid.
  90         (ravenscar_ops): Remove global.
  91
  92 2019-02-15  Tom Tromey  <tromey@adacore.com>
  93
  94         * target.h (push_target): Declare new overload.
  95         * target.c (push_target): New overload, taking an rvalue reference.
  96         * remote.c (remote_target::open_1): Use push_target overload.
  97         * corelow.c (core_target_open): Use push_target overload.
  98
  99 2019-02-15  Tom Tromey  <tromey@adacore.com>
 100
 101         * ravenscar-thread.c (is_ravenscar_task)
 102         (ravenscar_task_is_currently_active): Return bool.
 103         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 104         (_initialize_ravenscar): Remove "(void)".
 105         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 106         Return bool.
 107
 108 2019-02-15  Tom Tromey  <tromey@adacore.com>
 109
 110         * ravenscar-thread.c (ravenscar_runtime_initializer)
 111         (has_ravenscar_runtime, get_running_thread_id)
 112         (ravenscar_thread_target::resume): Fix indentation.
 113
 114 2019-02-15  Tom Tromey  <tromey@adacore.com>
 115
 116         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 117         from ravenscar_arch_ops.
 118         (sparc_ravenscar_ops::fetch_registers)
 119         (sparc_ravenscar_ops::store_registers): Now methods.
 120         (sparc_ravenscar_prepare_to_store): Remove.
 121         (sparc_ravenscar_ops): Redefine.
 122         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 123         methods and destructor.  Remove members.
 124         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 125         (ravenscar_thread_target::store_registers)
 126         (ravenscar_thread_target::prepare_to_store): Update.
 127         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 128         Remove.
 129         (struct ppc_ravenscar_powerpc_ops): Derive from
 130         ravenscar_arch_ops.
 131         (ppc_ravenscar_powerpc_ops::fetch_registers)
 132         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 133         (ppc_ravenscar_powerpc_ops): Redefine.
 134         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 135         (ppc_ravenscar_e500_ops::fetch_registers)
 136         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 137         (ppc_ravenscar_e500_ops): Redefine.
 138         * aarch64-ravenscar-thread.c
 139         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 140         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 141         (aarch64_ravenscar_fetch_registers)
 142         (aarch64_ravenscar_store_registers): Now methods.
 143         (aarch64_ravenscar_ops): Redefine.
 144
 145 2019-02-15  Tom Tromey  <tromey@adacore.com>
 146
 147         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 148         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 149         (ravenscar_thread_target::stopped_by_watchpoint)
 150         (ravenscar_thread_target::stopped_data_address)
 151         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 152
 153 2019-02-15  Tom Tromey  <tromey@adacore.com>
 154
 155         * ravenscar-thread.c: Fix some typos.
 156
 157 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 158             Tom Tromey  <tromey@adacore.com>
 159
 160         * ada-lang.c (ada_exception_sal): Change addr_string to a
 161         std::string.
 162         (create_ada_exception_catchpoint): Update.
 163
 164 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 165             Tom Tromey  <tromey@adacore.com>
 166
 167         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 168         (bp_location_ops): Remove.
 169         (base_breakpoint_allocate_location): Update.
 170         (free_bp_location): Update.
 171         * ada-lang.c (class ada_catchpoint_location)
 172         <ada_catchpoint_location>: Remove ops parameter.
 173         (ada_catchpoint_location_dtor): Remove.
 174         (ada_catchpoint_location_ops): Remove.
 175         (allocate_location_exception): Update.
 176         * breakpoint.h (struct bp_location_ops): Remove.
 177         (class bp_location) <bp_location>: Remove bp_location_ops
 178         parameter.
 179         <~bp_location>: Add destructor.
 180         <ops>: Remove.
 181
 182 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 183             Pedro Alves  <palves@redhat.com>
 184
 185         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 186         'PATH_MAX'.
 187
 188 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 189             Samuel Thibault  <samuel.thibault@gnu.org>
 190             Thomas Schwinge  <thomas@codesourcery.com>
 191
 192         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 193         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 194
 195 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 196
 197         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 198         (check_empty): Use "const char *".
 199
 200         * gnu-nat.c (gnu_nat_target::detach): Instead of
 201         'detach_inferior (pid)' call
 202         'detach_inferior (find_inferior_pid (pid))'.
 203
 204         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 205         'nat/fork-inferior.o'.
 206         * gnu-nat.c: #include "nat/fork-inferior.h".
 207
 208         * gnu-nat.c (gnu_nat_target::detach): Instead of
 209         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 210         * gnu-nat.h: #include "inf-child.h".
 211         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 212         'i386_gnu_nat_target::fetch_registers'.
 213         (gnu_store_registers): Rename/move to
 214         'i386_gnu_nat_target::store_registers'.
 215
 216         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 217         * gnu-nat.h (mach_thread_info): New function.
 218         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 219
 220         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 221
 222 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 223
 224         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 225
 226 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 227
 228         * windows-nat.c (windows_add_thread): Add new parameter
 229         "main_thread_p" with default value set to false.  Update
 230         function documentation as well as all callers.
 231         (windows_delete_thread): Likewise.
 232         (fake_create_process): Update call to windows_add_thread.
 233         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 234         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 235         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 236         call to windows_delete_thread.
 237
 238 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 239
 240         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 241
 242 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 243
 244         * symfile.c (find_separate_debug_file): Use canonical path of
 245         sysroot with child_path instead of gdb_sysroot if it is valid.
 246
 247 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 248
 249         * symfile.c (find_separate_debug_file): Use child_path to
 250         determine if an object file is under a sysroot.
 251
 252 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 253
 254         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 255         unittests/child-path-selftests.c.
 256         * common/pathstuff.c (child_path): New function.
 257         * common/pathstuff.h (child_path): New prototype.
 258         * unittests/child-path-selftests.c: New file.
 259
 260 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 261
 262         * symfile.c (find_separate_debug_file): Look for separate debug
 263         files in debug directories under the sysroot.
 264
 265 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 266
 267         * symtab.h (struct minimal_symbol data_p): New const method.
 268         (struct minimal_symbol text_p): Likewise.
 269         * symtab.c (output_source_filename): Use file name style
 270         to print file name.
 271         (print_symbol_info): Likewise.
 272         (print_msymbol_info): Use address style to print addresses.
 273         Use function name style to print executable text symbols.
 274         (expand_symtab_containing_pc): Use data_p.
 275         (find_pc_sect_compunit_symtab): Likewise.
 276
 277 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 278
 279         * breakpoint.c (describe_other_breakpoints): Use address style
 280         to print addresses.
 281         (say_where): Likewise.
 282
 283 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 284
 285         * ada-typeprint.c (print_func_type): Print function name
 286         style to print function name.
 287         * c-typeprint.c (c_print_type_1): Likewise.
 288
 289 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 290
 291         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 292         for execve.
 293
 294 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 295
 296         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 297         type_stack.
 298
 299 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 300
 301         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 302         TYPE_CODE_REF types.
 303
 304 2019-02-08  Jim Wilson  <jimw@sifive.com>
 305
 306         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 307         (riscv_linux_fregset): New.
 308         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 309
 310 2019-02-07  Tom Tromey  <tom@tromey.com>
 311
 312         * thread.c (thread_cancel_execution_command): Update.
 313         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 314         methods.
 315         (struct thread_fsm_ops): Remove.
 316         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 317         (thread_fsm_should_stop, thread_fsm_return_value)
 318         (thread_fsm_set_finished, thread_fsm_finished_p)
 319         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 320         Don't declare.
 321         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 322         * infrun.c (clear_proceed_status_thread)
 323         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 324         (print_stop_event): Update.
 325         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 326         Add constructor.
 327         (step_command_fsm_ops): Remove.
 328         (new_step_command_fsm): Remove.
 329         (step_1): Update.
 330         (step_command_fsm::should_stop): Rename from
 331         step_command_fsm_should_stop.
 332         (step_command_fsm::clean_up): Rename from
 333         step_command_fsm_clean_up.
 334         (step_command_fsm::do_async_reply_reason): Rename from
 335         step_command_fsm_async_reply_reason.
 336         (struct until_next_fsm): Inherit from thread_fsm.  Add
 337         constructor.
 338         (until_next_fsm_ops): Remove.
 339         (new_until_next_fsm): Remove.
 340         (until_next_fsm::should_stop): Rename from
 341         until_next_fsm_should_stop.
 342         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 343         (until_next_fsm::do_async_reply_reason): Rename from
 344         until_next_fsm_async_reply_reason.
 345         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 346         constructor.  Change type of breakpoint.
 347         (finish_command_fsm_ops): Remove.
 348         (new_finish_command_fsm): Remove.
 349         (finish_command_fsm::should_stop): Rename from
 350         finish_command_fsm_should_stop.
 351         (finish_command_fsm::clean_up): Rename from
 352         finish_command_fsm_clean_up.
 353         (finish_command_fsm::return_value): Rename from
 354         finish_command_fsm_return_value.
 355         (finish_command_fsm::do_async_reply_reason): Rename from
 356         finish_command_fsm_async_reply_reason.
 357         (finish_command): Update.
 358         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 359         Add constructor.
 360         (call_thread_fsm_ops): Remove.
 361         (call_thread_fsm::call_thread_fsm): Rename from
 362         new_call_thread_fsm.
 363         (call_thread_fsm::should_stop): Rename from
 364         call_thread_fsm_should_stop.
 365         (call_thread_fsm::should_notify_stop): Rename from
 366         call_thread_fsm_should_notify_stop.
 367         (run_inferior_call, call_function_by_hand_dummy): Update.
 368         * cli/cli-interp.c (should_print_stop_to_console): Update.
 369         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 370         Add constructor.  Change type of location_breakpoint,
 371         caller_breakpoint.
 372         (until_break_fsm_ops): Remove.
 373         (new_until_break_fsm): Remove.
 374         (until_break_fsm::should_stop): Rename from
 375         until_break_fsm_should_stop.
 376         (until_break_fsm::clean_up): Rename from
 377         until_break_fsm_clean_up.
 378         (until_break_fsm::do_async_reply_reason): Rename from
 379         until_break_fsm_async_reply_reason.
 380         (until_break_command): Update.
 381         * thread-fsm.c: Remove.
 382         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 383
 384 2019-02-07  Tom Tromey  <tom@tromey.com>
 385
 386         * yy-remap.h: Add include guard.
 387         * xtensa-tdep.h: Add include guard.
 388         * xcoffread.h: Rename include guard.
 389         * varobj-iter.h: Add include guard.
 390         * tui/tui.h: Rename include guard.
 391         * tui/tui-winsource.h: Rename include guard.
 392         * tui/tui-wingeneral.h: Rename include guard.
 393         * tui/tui-windata.h: Rename include guard.
 394         * tui/tui-win.h: Rename include guard.
 395         * tui/tui-stack.h: Rename include guard.
 396         * tui/tui-source.h: Rename include guard.
 397         * tui/tui-regs.h: Rename include guard.
 398         * tui/tui-out.h: Rename include guard.
 399         * tui/tui-layout.h: Rename include guard.
 400         * tui/tui-io.h: Rename include guard.
 401         * tui/tui-hooks.h: Rename include guard.
 402         * tui/tui-file.h: Rename include guard.
 403         * tui/tui-disasm.h: Rename include guard.
 404         * tui/tui-data.h: Rename include guard.
 405         * tui/tui-command.h: Rename include guard.
 406         * tic6x-tdep.h: Add include guard.
 407         * target/waitstatus.h: Rename include guard.
 408         * target/wait.h: Rename include guard.
 409         * target/target.h: Rename include guard.
 410         * target/resume.h: Rename include guard.
 411         * target-float.h: Rename include guard.
 412         * stabsread.h: Add include guard.
 413         * rs6000-tdep.h: Add include guard.
 414         * riscv-fbsd-tdep.h: Add include guard.
 415         * regformats/regdef.h: Rename include guard.
 416         * record.h: Rename include guard.
 417         * python/python.h: Rename include guard.
 418         * python/python-internal.h: Rename include guard.
 419         * python/py-stopevent.h: Rename include guard.
 420         * python/py-ref.h: Rename include guard.
 421         * python/py-record.h: Rename include guard.
 422         * python/py-record-full.h: Rename include guard.
 423         * python/py-record-btrace.h: Rename include guard.
 424         * python/py-instruction.h: Rename include guard.
 425         * python/py-events.h: Rename include guard.
 426         * python/py-event.h: Rename include guard.
 427         * procfs.h: Add include guard.
 428         * proc-utils.h: Add include guard.
 429         * p-lang.h: Add include guard.
 430         * or1k-tdep.h: Rename include guard.
 431         * observable.h: Rename include guard.
 432         * nto-tdep.h: Rename include guard.
 433         * nat/x86-linux.h: Rename include guard.
 434         * nat/x86-linux-dregs.h: Rename include guard.
 435         * nat/x86-gcc-cpuid.h: Add include guard.
 436         * nat/x86-dregs.h: Rename include guard.
 437         * nat/x86-cpuid.h: Rename include guard.
 438         * nat/ppc-linux.h: Rename include guard.
 439         * nat/mips-linux-watch.h: Rename include guard.
 440         * nat/linux-waitpid.h: Rename include guard.
 441         * nat/linux-ptrace.h: Rename include guard.
 442         * nat/linux-procfs.h: Rename include guard.
 443         * nat/linux-osdata.h: Rename include guard.
 444         * nat/linux-nat.h: Rename include guard.
 445         * nat/linux-namespaces.h: Rename include guard.
 446         * nat/linux-btrace.h: Rename include guard.
 447         * nat/glibc_thread_db.h: Rename include guard.
 448         * nat/gdb_thread_db.h: Rename include guard.
 449         * nat/gdb_ptrace.h: Rename include guard.
 450         * nat/fork-inferior.h: Rename include guard.
 451         * nat/amd64-linux-siginfo.h: Rename include guard.
 452         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 453         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 454         * nat/aarch64-linux.h: Rename include guard.
 455         * nat/aarch64-linux-hw-point.h: Rename include guard.
 456         * mn10300-tdep.h: Add include guard.
 457         * mips-linux-tdep.h: Add include guard.
 458         * mi/mi-parse.h: Rename include guard.
 459         * mi/mi-out.h: Rename include guard.
 460         * mi/mi-main.h: Rename include guard.
 461         * mi/mi-interp.h: Rename include guard.
 462         * mi/mi-getopt.h: Rename include guard.
 463         * mi/mi-console.h: Rename include guard.
 464         * mi/mi-common.h: Rename include guard.
 465         * mi/mi-cmds.h: Rename include guard.
 466         * mi/mi-cmd-break.h: Rename include guard.
 467         * m2-lang.h: Add include guard.
 468         * location.h: Rename include guard.
 469         * linux-record.h: Rename include guard.
 470         * linux-nat.h: Add include guard.
 471         * linux-fork.h: Add include guard.
 472         * i386-darwin-tdep.h: Rename include guard.
 473         * hppa-linux-offsets.h: Add include guard.
 474         * guile/guile.h: Rename include guard.
 475         * guile/guile-internal.h: Rename include guard.
 476         * gnu-nat.h: Rename include guard.
 477         * gdb-stabs.h: Rename include guard.
 478         * frv-tdep.h: Add include guard.
 479         * f-lang.h: Add include guard.
 480         * event-loop.h: Add include guard.
 481         * darwin-nat.h: Rename include guard.
 482         * cp-abi.h: Rename include guard.
 483         * config/sparc/nm-sol2.h: Rename include guard.
 484         * config/nm-nto.h: Rename include guard.
 485         * config/nm-linux.h: Add include guard.
 486         * config/i386/nm-i386gnu.h: Rename include guard.
 487         * config/djgpp/nl_types.h: Rename include guard.
 488         * config/djgpp/langinfo.h: Rename include guard.
 489         * compile/gcc-cp-plugin.h: Add include guard.
 490         * compile/gcc-c-plugin.h: Add include guard.
 491         * compile/compile.h: Rename include guard.
 492         * compile/compile-object-run.h: Rename include guard.
 493         * compile/compile-object-load.h: Rename include guard.
 494         * compile/compile-internal.h: Rename include guard.
 495         * compile/compile-cplus.h: Rename include guard.
 496         * compile/compile-c.h: Rename include guard.
 497         * common/xml-utils.h: Rename include guard.
 498         * common/x86-xstate.h: Rename include guard.
 499         * common/version.h: Rename include guard.
 500         * common/vec.h: Rename include guard.
 501         * common/tdesc.h: Rename include guard.
 502         * common/selftest.h: Rename include guard.
 503         * common/scoped_restore.h: Rename include guard.
 504         * common/scoped_mmap.h: Rename include guard.
 505         * common/scoped_fd.h: Rename include guard.
 506         * common/safe-iterator.h: Rename include guard.
 507         * common/run-time-clock.h: Rename include guard.
 508         * common/refcounted-object.h: Rename include guard.
 509         * common/queue.h: Rename include guard.
 510         * common/ptid.h: Rename include guard.
 511         * common/print-utils.h: Rename include guard.
 512         * common/preprocessor.h: Rename include guard.
 513         * common/pathstuff.h: Rename include guard.
 514         * common/observable.h: Rename include guard.
 515         * common/netstuff.h: Rename include guard.
 516         * common/job-control.h: Rename include guard.
 517         * common/host-defs.h: Rename include guard.
 518         * common/gdb_wait.h: Rename include guard.
 519         * common/gdb_vecs.h: Rename include guard.
 520         * common/gdb_unlinker.h: Rename include guard.
 521         * common/gdb_unique_ptr.h: Rename include guard.
 522         * common/gdb_tilde_expand.h: Rename include guard.
 523         * common/gdb_sys_time.h: Rename include guard.
 524         * common/gdb_string_view.h: Rename include guard.
 525         * common/gdb_splay_tree.h: Rename include guard.
 526         * common/gdb_setjmp.h: Rename include guard.
 527         * common/gdb_ref_ptr.h: Rename include guard.
 528         * common/gdb_optional.h: Rename include guard.
 529         * common/gdb_locale.h: Rename include guard.
 530         * common/gdb_assert.h: Rename include guard.
 531         * common/filtered-iterator.h: Rename include guard.
 532         * common/filestuff.h: Rename include guard.
 533         * common/fileio.h: Rename include guard.
 534         * common/environ.h: Rename include guard.
 535         * common/common-utils.h: Rename include guard.
 536         * common/common-types.h: Rename include guard.
 537         * common/common-regcache.h: Rename include guard.
 538         * common/common-inferior.h: Rename include guard.
 539         * common/common-gdbthread.h: Rename include guard.
 540         * common/common-exceptions.h: Rename include guard.
 541         * common/common-defs.h: Rename include guard.
 542         * common/common-debug.h: Rename include guard.
 543         * common/cleanups.h: Rename include guard.
 544         * common/buffer.h: Rename include guard.
 545         * common/btrace-common.h: Rename include guard.
 546         * common/break-common.h: Rename include guard.
 547         * cli/cli-utils.h: Rename include guard.
 548         * cli/cli-style.h: Rename include guard.
 549         * cli/cli-setshow.h: Rename include guard.
 550         * cli/cli-script.h: Rename include guard.
 551         * cli/cli-interp.h: Rename include guard.
 552         * cli/cli-decode.h: Rename include guard.
 553         * cli/cli-cmds.h: Rename include guard.
 554         * charset-list.h: Add include guard.
 555         * buildsym-legacy.h: Rename include guard.
 556         * bfin-tdep.h: Add include guard.
 557         * ax.h: Rename include guard.
 558         * arm-linux-tdep.h: Add include guard.
 559         * arm-fbsd-tdep.h: Add include guard.
 560         * arch/xtensa.h: Rename include guard.
 561         * arch/tic6x.h: Add include guard.
 562         * arch/i386.h: Add include guard.
 563         * arch/arm.h: Rename include guard.
 564         * arch/arm-linux.h: Rename include guard.
 565         * arch/arm-get-next-pcs.h: Rename include guard.
 566         * arch/amd64.h: Add include guard.
 567         * arch/aarch64-insn.h: Rename include guard.
 568         * arch-utils.h: Rename include guard.
 569         * annotate.h: Add include guard.
 570         * amd64-darwin-tdep.h: Rename include guard.
 571         * aarch64-linux-tdep.h: Add include guard.
 572         * aarch64-fbsd-tdep.h: Add include guard.
 573         * aarch32-linux-nat.h: Add include guard.
 574
 575 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 576
 577         * macrotab.c (macro_define_internal): New function that
 578         factorizes macro_define_object_internal and macro_define_function
 579         code.
 580         (macro_define_object_internal): Use macro_define_internal.
 581         (macro_define_function): Likewise.
 582
 583 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 584
 585         * macrocmd.c (extract_identifier): Return
 586         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 587         callers.
 588
 589 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 590
 591         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 592
 593 2019-02-05  Tom Tromey  <tom@tromey.com>
 594
 595         * target.c (target_stack::unpush): Move assertion earlier.
 596
 597 2019-01-30  Tom Tromey  <tom@tromey.com>
 598
 599         PR python/23615:
 600         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 601         (gdbpy_parse_and_eval): Likewise.
 602         * python/python-internal.h (gdbpy_allow_threads): New class.
 603
 604 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 605
 606         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 607         (aarch64_fbsd_fpregmap): Move earlier.
 608         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 609         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 610         instead of individual calls to trad_frame_set_reg_addr.
 611         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 612         earlier.
 613         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 614         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 615         instead of individual calls to trad_frame_set_reg_addr.
 616
 617 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 618
 619         * CONTRIBUTE: Replace contribution list with wiki link.
 620
 621 2019-01-25  Tom Tromey  <tom@tromey.com>
 622
 623         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 624
 625 2019-01-25  Tom Tromey  <tom@tromey.com>
 626
 627         * xtensa-linux-nat.c: Fix common/ includes.
 628         * xml-support.h: Fix common/ includes.
 629         * xml-support.c: Fix common/ includes.
 630         * x86-linux-nat.c: Fix common/ includes.
 631         * windows-nat.c: Fix common/ includes.
 632         * varobj.h: Fix common/ includes.
 633         * varobj.c: Fix common/ includes.
 634         * value.c: Fix common/ includes.
 635         * valops.c: Fix common/ includes.
 636         * utils.c: Fix common/ includes.
 637         * unittests/xml-utils-selftests.c: Fix common/ includes.
 638         * unittests/utils-selftests.c: Fix common/ includes.
 639         * unittests/unpack-selftests.c: Fix common/ includes.
 640         * unittests/tracepoint-selftests.c: Fix common/ includes.
 641         * unittests/style-selftests.c: Fix common/ includes.
 642         * unittests/string_view-selftests.c: Fix common/ includes.
 643         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 644         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 645         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 646         * unittests/rsp-low-selftests.c: Fix common/ includes.
 647         * unittests/parse-connection-spec-selftests.c: Fix common/
 648         includes.
 649         * unittests/optional-selftests.c: Fix common/ includes.
 650         * unittests/offset-type-selftests.c: Fix common/ includes.
 651         * unittests/observable-selftests.c: Fix common/ includes.
 652         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 653         * unittests/memrange-selftests.c: Fix common/ includes.
 654         * unittests/memory-map-selftests.c: Fix common/ includes.
 655         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 656         * unittests/function-view-selftests.c: Fix common/ includes.
 657         * unittests/environ-selftests.c: Fix common/ includes.
 658         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 659         * unittests/common-utils-selftests.c: Fix common/ includes.
 660         * unittests/cli-utils-selftests.c: Fix common/ includes.
 661         * unittests/array-view-selftests.c: Fix common/ includes.
 662         * ui-file.c: Fix common/ includes.
 663         * tui/tui-io.c: Fix common/ includes.
 664         * tracepoint.h: Fix common/ includes.
 665         * tracepoint.c: Fix common/ includes.
 666         * tracefile-tfile.c: Fix common/ includes.
 667         * top.h: Fix common/ includes.
 668         * top.c: Fix common/ includes.
 669         * thread.c: Fix common/ includes.
 670         * target/waitstatus.h: Fix common/ includes.
 671         * target/waitstatus.c: Fix common/ includes.
 672         * target.h: Fix common/ includes.
 673         * target.c: Fix common/ includes.
 674         * target-memory.c: Fix common/ includes.
 675         * target-descriptions.c: Fix common/ includes.
 676         * symtab.h: Fix common/ includes.
 677         * symfile.c: Fix common/ includes.
 678         * stap-probe.c: Fix common/ includes.
 679         * spu-linux-nat.c: Fix common/ includes.
 680         * sparc-nat.c: Fix common/ includes.
 681         * source.c: Fix common/ includes.
 682         * solib.c: Fix common/ includes.
 683         * solib-target.c: Fix common/ includes.
 684         * ser-unix.c: Fix common/ includes.
 685         * ser-tcp.c: Fix common/ includes.
 686         * ser-pipe.c: Fix common/ includes.
 687         * ser-base.c: Fix common/ includes.
 688         * selftest-arch.c: Fix common/ includes.
 689         * s12z-tdep.c: Fix common/ includes.
 690         * rust-exp.y: Fix common/ includes.
 691         * rs6000-aix-tdep.c: Fix common/ includes.
 692         * riscv-tdep.c: Fix common/ includes.
 693         * remote.c: Fix common/ includes.
 694         * remote-notif.h: Fix common/ includes.
 695         * remote-fileio.h: Fix common/ includes.
 696         * remote-fileio.c: Fix common/ includes.
 697         * regcache.h: Fix common/ includes.
 698         * regcache.c: Fix common/ includes.
 699         * record-btrace.c: Fix common/ includes.
 700         * python/python.c: Fix common/ includes.
 701         * python/py-type.c: Fix common/ includes.
 702         * python/py-inferior.c: Fix common/ includes.
 703         * progspace.h: Fix common/ includes.
 704         * producer.c: Fix common/ includes.
 705         * procfs.c: Fix common/ includes.
 706         * proc-api.c: Fix common/ includes.
 707         * printcmd.c: Fix common/ includes.
 708         * ppc-linux-nat.c: Fix common/ includes.
 709         * parser-defs.h: Fix common/ includes.
 710         * osdata.c: Fix common/ includes.
 711         * obsd-nat.c: Fix common/ includes.
 712         * nat/x86-linux.c: Fix common/ includes.
 713         * nat/x86-linux-dregs.c: Fix common/ includes.
 714         * nat/x86-dregs.h: Fix common/ includes.
 715         * nat/x86-dregs.c: Fix common/ includes.
 716         * nat/ppc-linux.c: Fix common/ includes.
 717         * nat/mips-linux-watch.h: Fix common/ includes.
 718         * nat/mips-linux-watch.c: Fix common/ includes.
 719         * nat/linux-waitpid.c: Fix common/ includes.
 720         * nat/linux-ptrace.h: Fix common/ includes.
 721         * nat/linux-ptrace.c: Fix common/ includes.
 722         * nat/linux-procfs.c: Fix common/ includes.
 723         * nat/linux-personality.c: Fix common/ includes.
 724         * nat/linux-osdata.c: Fix common/ includes.
 725         * nat/linux-namespaces.c: Fix common/ includes.
 726         * nat/linux-btrace.h: Fix common/ includes.
 727         * nat/linux-btrace.c: Fix common/ includes.
 728         * nat/fork-inferior.c: Fix common/ includes.
 729         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 730         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 731         * nat/aarch64-linux.c: Fix common/ includes.
 732         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 733         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 734         * namespace.h: Fix common/ includes.
 735         * mips-linux-tdep.c: Fix common/ includes.
 736         * minsyms.c: Fix common/ includes.
 737         * mi/mi-parse.h: Fix common/ includes.
 738         * mi/mi-main.c: Fix common/ includes.
 739         * mi/mi-cmd-env.c: Fix common/ includes.
 740         * memrange.h: Fix common/ includes.
 741         * memattr.c: Fix common/ includes.
 742         * maint.h: Fix common/ includes.
 743         * maint.c: Fix common/ includes.
 744         * main.c: Fix common/ includes.
 745         * machoread.c: Fix common/ includes.
 746         * location.c: Fix common/ includes.
 747         * linux-thread-db.c: Fix common/ includes.
 748         * linux-nat.c: Fix common/ includes.
 749         * linux-fork.c: Fix common/ includes.
 750         * inline-frame.c: Fix common/ includes.
 751         * infrun.c: Fix common/ includes.
 752         * inflow.c: Fix common/ includes.
 753         * inferior.h: Fix common/ includes.
 754         * inferior.c: Fix common/ includes.
 755         * infcmd.c: Fix common/ includes.
 756         * inf-ptrace.c: Fix common/ includes.
 757         * inf-child.c: Fix common/ includes.
 758         * ia64-linux-nat.c: Fix common/ includes.
 759         * i387-tdep.c: Fix common/ includes.
 760         * i386-tdep.c: Fix common/ includes.
 761         * i386-linux-tdep.c: Fix common/ includes.
 762         * i386-linux-nat.c: Fix common/ includes.
 763         * i386-go32-tdep.c: Fix common/ includes.
 764         * i386-fbsd-tdep.c: Fix common/ includes.
 765         * i386-fbsd-nat.c: Fix common/ includes.
 766         * guile/scm-type.c: Fix common/ includes.
 767         * guile/guile.c: Fix common/ includes.
 768         * go32-nat.c: Fix common/ includes.
 769         * gnu-nat.c: Fix common/ includes.
 770         * gdbthread.h: Fix common/ includes.
 771         * gdbarch-selftests.c: Fix common/ includes.
 772         * gdb_usleep.c: Fix common/ includes.
 773         * gdb_select.h: Fix common/ includes.
 774         * gdb_bfd.c: Fix common/ includes.
 775         * gcore.c: Fix common/ includes.
 776         * fork-child.c: Fix common/ includes.
 777         * findvar.c: Fix common/ includes.
 778         * fbsd-nat.c: Fix common/ includes.
 779         * event-top.c: Fix common/ includes.
 780         * event-loop.c: Fix common/ includes.
 781         * dwarf2read.c: Fix common/ includes.
 782         * dwarf2loc.c: Fix common/ includes.
 783         * dwarf2-frame.c: Fix common/ includes.
 784         * dwarf-index-cache.c: Fix common/ includes.
 785         * dtrace-probe.c: Fix common/ includes.
 786         * disasm-selftests.c: Fix common/ includes.
 787         * defs.h: Fix common/ includes.
 788         * csky-tdep.c: Fix common/ includes.
 789         * cp-valprint.c: Fix common/ includes.
 790         * cp-support.h: Fix common/ includes.
 791         * cp-support.c: Fix common/ includes.
 792         * corelow.c: Fix common/ includes.
 793         * completer.h: Fix common/ includes.
 794         * completer.c: Fix common/ includes.
 795         * compile/compile.c: Fix common/ includes.
 796         * compile/compile-loc2c.c: Fix common/ includes.
 797         * compile/compile-cplus-types.c: Fix common/ includes.
 798         * compile/compile-cplus-symbols.c: Fix common/ includes.
 799         * command.h: Fix common/ includes.
 800         * cli/cli-dump.c: Fix common/ includes.
 801         * cli/cli-cmds.c: Fix common/ includes.
 802         * charset.c: Fix common/ includes.
 803         * build-id.c: Fix common/ includes.
 804         * btrace.h: Fix common/ includes.
 805         * btrace.c: Fix common/ includes.
 806         * breakpoint.h: Fix common/ includes.
 807         * breakpoint.c: Fix common/ includes.
 808         * ax.h:
 809         (enum agent_op): Fix common/ includes.
 810         * ax-general.c (struct aop_map): Fix common/ includes.
 811         * ax-gdb.c: Fix common/ includes.
 812         * auxv.c: Fix common/ includes.
 813         * auto-load.c: Fix common/ includes.
 814         * arm-tdep.c: Fix common/ includes.
 815         * arch/riscv.c: Fix common/ includes.
 816         * arch/ppc-linux-common.c: Fix common/ includes.
 817         * arch/i386.c: Fix common/ includes.
 818         * arch/arm.c: Fix common/ includes.
 819         * arch/arm-linux.c: Fix common/ includes.
 820         * arch/arm-get-next-pcs.c: Fix common/ includes.
 821         * arch/amd64.c: Fix common/ includes.
 822         * arch/aarch64.c: Fix common/ includes.
 823         * arch/aarch64-insn.c: Fix common/ includes.
 824         * arch-utils.c: Fix common/ includes.
 825         * amd64-windows-tdep.c: Fix common/ includes.
 826         * amd64-tdep.c: Fix common/ includes.
 827         * amd64-sol2-tdep.c: Fix common/ includes.
 828         * amd64-obsd-tdep.c: Fix common/ includes.
 829         * amd64-nbsd-tdep.c: Fix common/ includes.
 830         * amd64-linux-tdep.c: Fix common/ includes.
 831         * amd64-linux-nat.c: Fix common/ includes.
 832         * amd64-fbsd-tdep.c: Fix common/ includes.
 833         * amd64-fbsd-nat.c: Fix common/ includes.
 834         * amd64-dicos-tdep.c: Fix common/ includes.
 835         * amd64-darwin-tdep.c: Fix common/ includes.
 836         * agent.c: Fix common/ includes.
 837         * ada-lang.h: Fix common/ includes.
 838         * ada-lang.c: Fix common/ includes.
 839         * aarch64-tdep.c: Fix common/ includes.
 840
 841 2019-01-25  Tom Tromey  <tom@tromey.com>
 842
 843         * common/create-version.sh: Use common/version.h.
 844
 845 2019-01-24  Pedro Alves  <palves@redhat.com>
 846
 847         * infrun.c (signal_stop, signal_print, signal_program)
 848         (signal_catch, signal_pass): Now arrays instead of pointers.
 849         (update_signals_program_target, do_target_resume)
 850         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 851         * linux-nat.c (linux_nat_target::pass_signals)
 852         (linux_nat_target::create_inferior, linux_nat_target::attach):
 853         Adjust.
 854         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 855         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 856         * procfs.c (procfs_target::pass_signals): Adjust.
 857         * record-full.c (record_full_target::resume): Adjust.
 858         * remote.c (remote_target::pass_signals)
 859         (remote_target::program_signals): Adjust.
 860         * target-debug.h (target_debug_print_signals): Now takes a
 861         gdb::array_view as parameter.  Adjust.
 862         * target.h (target_ops) <pass_signals, program_signals>: Replace
 863         pointer and length parameters with gdb::array_view.
 864         (target_pass_signals, target_program_signals): Likewise.
 865         * target-delegates.c: Regenerate.
 866
 867 2019-01-24  Pedro Alves  <palves@redhat.com>
 868
 869         * common/forward-scope-exit.h
 870         (forward_scope_exit::forward_scope_exit): Pass arguments to
 871         m_bind_function directly, instead of creating a std::bind and
 872         copying that.
 873
 874 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 875
 876         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 877         for static members.
 878         (pass_in_v_vfp_candidate): Likewise.
 879
 880 2019-01-23  Tom Tromey  <tom@tromey.com>
 881             Pedro Alves  <palves@redhat.com>
 882
 883         * regcache.c (class regcache_invalidator): Remove.
 884         (regcache::raw_write): Use make_scope_exit.
 885
 886 2019-01-23  Tom Tromey  <tom@tromey.com>
 887
 888         * ui-out.h (class ui_out_emit_type): Update comment.
 889
 890 2019-01-23  Tom Tromey  <tom@tromey.com>
 891
 892         * infrun.c (fetch_inferior_event): Update comment.
 893
 894 2019-01-23  Tom Tromey  <tom@tromey.com>
 895             Pedro Alves  <palves@redhat.com>
 896
 897         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 898         parameter.
 899         (fetch_inferior_event): Use SCOPE_EXIT.
 900
 901
 902 2019-01-23  Tom Tromey  <tom@tromey.com>
 903             Pedro Alves  <palves@redhat.com>
 904
 905         * infrun.c (disable_thread_events): Delete.
 906         (stop_all_threads): Use SCOPE_EXIT.
 907
 908 2019-01-23  Tom Tromey  <tom@tromey.com>
 909             Pedro Alves  <palves@redhat.com>
 910
 911         * symfile.c: Include forward-scope-exit.h.
 912         (clear_symtab_users_cleanup): Replace forward declaration with
 913         a FORWARD_SCOPE_EXIT.
 914         (syms_from_objfile_1): Use the forward_scope_exit and
 915         gdb::optional instead of cleanup_function.
 916         (reread_symbols): Use the forward_scope_exit instead of
 917         cleanup_function.
 918         (clear_symtab_users_cleanup): Remove function.
 919
 920 2019-01-23  Tom Tromey  <tom@tromey.com>
 921             Pedro Alves  <palves@redhat.com>
 922
 923         * linux-nat.c: Include scope-exit.h.
 924         (cleanup_target_stop): Remove.
 925         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 926         SCOPE_EXIT.
 927
 928 2019-01-23  Tom Tromey  <tom@tromey.com>
 929             Pedro Alves  <palves@redhat.com>
 930
 931         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 932         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 933
 934 2019-01-23  Tom Tromey  <tom@tromey.com>
 935             Andrew Burgess  <andrew.burgess@embecosm.com>
 936             Pedro Alves  <palves@redhat.com>
 937
 938         * infrun.c (fetch_inferior_event): Use scope_exit.
 939         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 940         * top.c (execute_command): Use scope_exit.
 941         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 942         * utils.c (do_bpstat_clear_actions_cleanup)
 943         (make_bpstat_clear_actions_cleanup): Remove.
 944
 945 2019-01-23  Tom Tromey  <tom@tromey.com>
 946             Pedro Alves  <palves@redhat.com>
 947
 948         * infrun.c: Include "common/scope-exit.h"
 949         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 950         (wait_for_inferior): Use SCOPE_EXIT.
 951         (fetch_inferior_event): Use scope_exit.
 952
 953 2019-01-23  Tom Tromey  <tom@tromey.com>
 954             Pedro Alves  <palves@redhat.com>
 955
 956         * breakpoint.c (create_breakpoint): Remove cleanup.
 957
 958 2019-01-23  Tom Tromey  <tom@tromey.com>
 959             Andrew Burgess  <andrew.burgess@embecosm.com>
 960             Pedro Alves  <palves@redhat.com>
 961
 962 2019-01-23  Pedro Alves  <palves@redhat.com>
 963
 964         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 965
 966 2019-01-23  Pedro Alves  <palves@redhat.com>
 967             Andrew Burgess  <andrew.burgess@embecosm.com>
 968
 969         * gdbthread.h: Include "common/forward-scope-exit.h".
 970         (scoped_finish_thread_state): Redefine custom class in terms of
 971         forward_scope_exit.
 972
 973 2019-01-23  Pedro Alves  <palves@redhat.com>
 974             Andrew Burgess  <andrew.burgess@embecosm.com>
 975
 976         * common/forward-scope-exit.h: New file.
 977
 978 2019-01-23  Pedro Alves  <palves@redhat.com>
 979             Andrew Burgess  <andrew.burgess@embecosm.com>
 980             Tom Tromey  <tom@tromey.com>
 981
 982         * common/scope-exit.h: New file.
 983
 984 2019-01-23  Pedro Alves  <palves@redhat.com>
 985
 986         * common/preprocessor.h (ESC): Rename to ...
 987         (ESC_PARENS): ... this.
 988         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 989         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 990
 991 2019-01-23  Tom Tromey  <tom@tromey.com>
 992
 993         * language.h (class scoped_switch_to_sym_language_if_auto):
 994         Initialize m_lang in both cases.
 995
 996 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 997
 998         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 999         with XCNEW.
1000
1001 2019-01-22  Tom Tromey  <tom@tromey.com>
1002
1003         * corelow.c: Do not include sys/file.h.
1004
1005 2019-01-22  Tom Tromey  <tom@tromey.com>
1006
1007         * tui/tui-wingeneral.h: Include gdb_curses.h.
1008
1009 2019-01-22  Tom Tromey  <tom@tromey.com>
1010
1011         * source-cache.h (class source_cache) <get_source_lines,
1012         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1013
1014 2019-01-22  Tom Tromey  <tom@tromey.com>
1015
1016         * remote-fileio.h (struct remote_target): Declare.
1017
1018 2019-01-22  Tom Tromey  <tom@tromey.com>
1019
1020         * python/py-arch.c: Do not include py-ref.h.
1021         * python/py-bpevent.c: Do not include py-ref.h.
1022         * python/py-cmd.c: Do not include py-ref.h.
1023         * python/py-continueevent.c: Do not include py-ref.h.
1024         * python/py-event.h: Do not include py-ref.h.
1025         * python/py-evtregistry.c: Do not include py-ref.h.
1026         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1027         * python/py-frame.c: Do not include py-ref.h.
1028         * python/py-framefilter.c: Do not include py-ref.h.
1029         * python/py-function.c: Do not include py-ref.h.
1030         * python/py-infevents.c: Do not include py-ref.h.
1031         * python/py-linetable.c: Do not include py-ref.h.
1032         * python/py-objfile.c: Do not include py-ref.h.
1033         * python/py-param.c: Do not include py-ref.h.
1034         * python/py-prettyprint.c: Do not include py-ref.h.
1035         * python/py-progspace.c: Do not include py-ref.h.
1036         * python/py-symbol.c: Do not include py-ref.h.
1037         * python/py-symtab.c: Do not include py-ref.h.
1038         * python/py-type.c: Do not include py-ref.h.
1039         * python/py-unwind.c: Do not include py-ref.h.
1040         * python/py-utils.c: Do not include py-ref.h.
1041         * python/py-value.c: Do not include py-ref.h.
1042         * python/py-varobj.c: Do not include py-ref.h.
1043         * python/py-xmethods.c: Do not include py-ref.h.
1044         * python/python.c: Do not include py-ref.h.
1045         * varobj.c: Do not include py-ref.h.
1046
1047 2019-01-22  Tom Tromey  <tom@tromey.com>
1048
1049         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1050         keyword for bcache.
1051
1052 2019-01-22  Tom Tromey  <tom@tromey.com>
1053
1054         * compile/compile-cplus-types.c: Remove a comment by #include.
1055
1056 2019-01-22  Tom Tromey  <tom@tromey.com>
1057
1058         * compile/gcc-c-plugin.h: Include compile-internal.h.
1059
1060 2019-01-22  Tom Tromey  <tom@tromey.com>
1061
1062         * stabsread.c (EXTERN): Do not define.
1063         (symnum, next_symbol_text_func, processing_gcc_compilation)
1064         (within_function, global_sym_chain, global_stabs)
1065         (previous_stab_code, this_object_header_files)
1066         (n_this_object_header_files)
1067         (n_allocated_this_object_header_files): Define.
1068         * stabsread.h (EXTERN): Never define.  Use "extern".
1069
1070 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1071
1072         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1073         history_value.
1074
1075 2019-01-21  Tom Tromey  <tom@tromey.com>
1076
1077         * ui-out.c: Fix includes.
1078         * tui/tui-source.c: Fix includes.
1079         * target.c: Fix includes.
1080         * remote.c: Fix includes.
1081         * regcache.c: Fix includes.
1082         * python/py-block.c: Fix includes.
1083         * printcmd.c: Fix includes.
1084         * or1k-tdep.c: Fix includes.
1085         * mi/mi-main.c: Fix includes.
1086         * m32r-tdep.c: Fix includes.
1087         * csky-tdep.c: Fix includes.
1088         * compile/compile-cplus-types.c: Fix includes.
1089         * cli/cli-interp.c: Fix includes.
1090
1091 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1092
1093         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1094         for padding.
1095
1096 2019-01-16  Tom Tromey  <tom@tromey.com>
1097
1098         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1099         earlier.
1100         (struct objfile) <msymbols_range>: Move from top level.
1101         <msymbols>: New method.
1102         (class objfile_msymbols): Remove.
1103         * symtab.c (default_collect_symbol_completion_matches_break_on):
1104         Update.
1105         * symmisc.c (dump_msymbols): Update.
1106         * stabsread.c (scan_file_globals): Update.
1107         * objc-lang.c (info_selectors_command, info_classes_command)
1108         (find_methods): Update.
1109         * minsyms.c (find_solib_trampoline_target): Update.
1110         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1111         * coffread.c (coff_symfile_read): Update.
1112         * ada-lang.c (ada_lookup_simple_minsym)
1113         (ada_collect_symbol_completion_matches): Update.
1114
1115 2019-01-16  Tom Tromey  <tom@tromey.com>
1116
1117         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1118         type.  Remove no-argument constructor.
1119         <iterator::operator++>: Simplify.
1120         <begin>: Update.
1121         <end>: Use minimal_symbol_count.
1122
1123 2019-01-16  Tom Tromey  <tom@tromey.com>
1124
1125         * objfiles.h (struct objfile) <psymtabs>: New method.
1126         (class objfile_psymtabs): Remove.
1127         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1128         typedef.
1129         <range>: New method.
1130         (require_partial_symbols): Change return type.
1131         * psymtab.c (require_partial_symbols)
1132         (psym_expand_symtabs_matching): Update.
1133         * mdebugread.c (parse_partial_symbols): Update.
1134         * dbxread.c (dbx_end_psymtab): Update.
1135
1136 2019-01-15  Tom Tromey  <tom@tromey.com>
1137
1138         * symtab.c (lookup_objfile_from_block)
1139         (lookup_symbol_in_objfile_symtabs)
1140         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1141         (find_line_symtab, info_sources_command)
1142         (default_collect_symbol_completion_matches_break_on)
1143         (make_source_files_completion_list): Update.
1144         * symmisc.c (print_objfile_statistics, dump_objfile)
1145         (maintenance_print_symbols, maintenance_info_symtabs)
1146         (maintenance_check_symtabs, maintenance_info_line_tables):
1147         Update.
1148         * source.c (select_source_symtab)
1149         (forget_cached_source_info_for_objfile): Update.
1150         * objfiles.h (class objfile_compunits): Remove.
1151         (struct objfile) <compunits_range>: New typedef.
1152         (compunits): New method.
1153         * objfiles.c (objfile_relocate1): Update.
1154         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1155         * maint.c (count_symtabs_and_blocks): Update.
1156         * linespec.c (iterate_over_all_matching_symtabs): Update.
1157         * cp-support.c (add_symbol_overload_list_qualified): Update.
1158         * coffread.c (coff_symtab_read): Update.
1159         * ada-lang.c (add_nonlocal_symbols)
1160         (ada_collect_symbol_completion_matches)
1161         (ada_add_global_exceptions): Update.
1162
1163 2019-01-15  Tom Tromey  <tom@tromey.com>
1164
1165         * progspace.h (program_space) <objfiles_safe_range>: New
1166         typedef.
1167         <objfiles_safe>: New method.
1168         * objfiles.h (class all_objfiles_safe): Remove.
1169         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1170         * jit.c (jit_inferior_exit_hook): Update.
1171
1172 2019-01-17  Tom Tromey  <tom@tromey.com>
1173
1174         * progspace.h (program_space) <objfiles_range>: New typedef.
1175         <objfiles>: New method.
1176         <objfiles_head>: Rename from objfiles.
1177         (object_files): Update.
1178         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1179         * guile/scm-pretty-print.c
1180         (ppscm_find_pretty_printer_from_objfiles): Update.
1181         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1182         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1183         Update.
1184         * python/py-progspace.c (pspy_get_objfiles): Update.
1185         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1186         Update.
1187         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1188         (objfpy_lookup_objfile_by_build_id): Update.
1189         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1190         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1191         Update.
1192         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1193         (expand_symtab_containing_pc, lookup_objfile_from_block)
1194         (lookup_static_symbol, basic_lookup_transparent_type)
1195         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1196         (find_line_symtab, info_sources_command)
1197         (default_collect_symbol_completion_matches_break_on)
1198         (make_source_files_completion_list, find_main_name): Update.
1199         * symmisc.c (print_symbol_bcache_statistics)
1200         (print_objfile_statistics, maintenance_print_symbols)
1201         (maintenance_print_msymbols, maintenance_print_objfiles)
1202         (maintenance_info_symtabs, maintenance_check_symtabs)
1203         (maintenance_expand_symtabs, maintenance_info_line_tables):
1204         Update.
1205         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1206         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1207         (map_overlay_command, unmap_overlay_command)
1208         (simple_overlay_update, expand_symtabs_matching)
1209         (map_symbol_filenames): Update.
1210         * symfile-debug.c (set_debug_symfile): Update.
1211         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1212         Update.
1213         * source.c (select_source_symtab, forget_cached_source_info):
1214         Update.
1215         * solib.c (solib_read_symbols): Update.
1216         * solib-spu.c (append_ocl_sos): Update.
1217         * psymtab.c (maintenance_print_psymbols)
1218         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1219         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1220         * printcmd.c (info_symbol_command): Update.
1221         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1222         Update.
1223         * objfiles.h (class all_objfiles): Remove.
1224         * objfiles.c (have_partial_symbols, have_full_symbols)
1225         (have_minimal_symbols, qsort_cmp, update_section_map)
1226         (shared_objfile_contains_address_p)
1227         (default_iterate_over_objfiles_in_search_order): Update.
1228         * objc-lang.c (info_selectors_command, info_classes_command)
1229         (find_methods): Update.
1230         * minsyms.c (find_solib_trampoline_target): Update.
1231         * maint.c (maintenance_info_sections)
1232         (maintenance_translate_address, count_symtabs_and_blocks):
1233         Update.
1234         * main.c (captured_main_1): Update.
1235         * linux-thread-db.c (try_thread_db_load_from_pdir)
1236         (has_libpthread): Update.
1237         * linespec.c (iterate_over_all_matching_symtabs)
1238         (search_minsyms_for_name): Update.
1239         * jit.c (jit_find_objf_with_entry_addr): Update.
1240         * hppa-tdep.c (find_unwind_entry)
1241         (hppa_lookup_stub_minimal_symbol): Update.
1242         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1243         Update.
1244         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1245         (elf_gnu_ifunc_resolve_by_got): Update.
1246         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1247         * dwarf-index-write.c (save_gdb_index_command): Update.
1248         * cp-support.c (add_symbol_overload_list_qualified): Update.
1249         * breakpoint.c (create_overlay_event_breakpoint)
1250         (create_longjmp_master_breakpoint)
1251         (create_std_terminate_master_breakpoint)
1252         (create_exception_master_breakpoint): Update.
1253         * blockframe.c (find_pc_partial_function): Update.
1254         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1255         (ada_collect_symbol_completion_matches)
1256         (ada_add_global_exceptions): Update.
1257
1258 2019-01-17  Tom Tromey  <tom@tromey.com>
1259
1260         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1261         declare VEC.
1262         (solib_target_parse_libraries): Change return type.
1263         (library_list_start_segment, library_list_start_section)
1264         (library_list_end_library, library_list_start_library); Update.
1265         (solib_target_free_library_list): Remove.
1266         (solib_target_parse_libraries): Remove cleanup.  Change return
1267         type.
1268         (solib_target_current_sos): Update.
1269
1270 2019-01-17  Tom Tromey  <tromey@bapiya>
1271
1272         * valprint.c: Replace "the the" with "the".
1273         * symtab.c: Replace "the the" with "the".
1274         * solib.c: Replace "the the" with "the".
1275         * solib-dsbt.c: Replace "the the" with "the".
1276         * linespec.c: Replace "the the" with "the".
1277         * dwarf2loc.h: Replace "the the" with "the".
1278         * amd64-windows-tdep.c: Replace "the the" with "the".
1279         * aarch64-tdep.c: Replace "the the" with "the".
1280
1281 2019-01-16  Keith Seitz  <keiths@redhat.com>
1282
1283         PR gdb/23773
1284         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1285         <builder>: Rename to ..
1286         <m_builder>: ... this and make private.
1287         (dwarf2_cu::get_builder): New method.  Change all users of
1288         `builder' to use this method.
1289         (dwarf2_start_symtab): Move to ...
1290         (dwarf2_cu::start_symtab): ... here.  Update all callers
1291         (setup_type_unit_groups): Move to ...
1292         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1293         callers.
1294         (dwarf2_cu::reset_builder): New method.
1295         (process_full_compunit, process_full_type_unit): Use
1296         dwarf2_cu::reset_builder.
1297         (follow_die_offset): Record the ancestor CU if it is different
1298         from the followed DIE's CU.
1299         (follow_die_sig_1): Likewise.
1300
1301 2019-01-15  Tom Tromey  <tom@tromey.com>
1302
1303         * remote.c (class remote_state) <buf>: Now a char_vector.
1304         <buf_size>: Remove.
1305         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1306         parameter.
1307         (remote_target::getpkt_or_notif_sane_1)
1308         (remote_target::getpkt_sane)
1309         (remote_target::getpkt_or_notif_sane): Likewise.
1310         (class remote_target) <putpkt>: New overload.
1311         (remote_target::read_frame): Change type of "buf_p".  Remove
1312         sizeof_p parameter.
1313         (packet_ok): New overload.
1314         (packet_check_result): New overload.
1315         Update all uses.
1316
1317 2019-01-14  Tom Tromey  <tom@tromey.com>
1318
1319         * remote-notif.c (handle_notification, remote_notif_ack)
1320         (remote_notif_parse): Make "buf" const.
1321         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1322         const.
1323         (remote_notif_parse, remote_notif_ack, handle_notification):
1324         Likewise.
1325         * remote.c (remote_notif_stop_parse): Make "buf" const.
1326         (remote_target::remote_parse_stop_reply): Make "buf" const.
1327         (remote_notif_stop_ack): Make "buf" const.
1328
1329 2019-01-14  Tom Tromey  <tom@tromey.com>
1330
1331         * remote.c (remote_console_output): Make parameter const.
1332
1333 2019-01-14  Tom Tromey  <tom@tromey.com>
1334
1335         * target-debug.h (target_debug_print_signals): Constify.
1336         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1337         * procfs.c (procfs_target::pass_signals): Update.
1338         * linux-nat.c (linux_nat_target::pass_signals): Update.
1339         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1340         * target-delegates.c: Rebuild.
1341         * remote.c (remote_target::program_signals): Update.
1342         (remote_target::pass_signals): Update.
1343         * target.c (target_pass_signals): Constify argument.
1344         (target_program_signals): Likewise.
1345         * target.h (struct target_ops) <pass_signals, program_signals>:
1346         Constify argument.
1347         (target_pass_signals, target_program_signals): Constify argument.
1348
1349 2019-01-14  Tom Tromey  <tom@tromey.com>
1350
1351         PR tui/28819:
1352         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1353
1354 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1355
1356         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1357         field.
1358         * rs6000-tdep.c: Include reggroups.h.
1359         (IS_V_ALIAS_PSEUDOREG): Define.
1360         (rs6000_register_name): Return names for the "vX" aliases.
1361         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1362         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1363         aliases.  Call default_register_reggroup_p for all other
1364         pseudo-registers.
1365         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1366         New functions.
1367         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1368         Handle "vX" aliases.
1369         (v_alias_pseudo_register_collect): New function.
1370         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1371         (rs6000_gdbarch_init): Initialize "vX" aliases as
1372         pseudo-registers.  Restore registration of
1373         rs6000_pseudo_register_reggroup_p with
1374         set_tdesc_pseudo_register_reggroup_p.
1375
1376 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1377
1378         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1379         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1380         set_gdbarch_num_pseudo_regs.
1381
1382 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1383
1384         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1385         Remove arg prefixname, add do_set and do_show.
1386         Add member functions set_list and show_list.
1387         * cli/cli-style.c (class cli_style_option): Update accordingly.
1388         (style_set_list): Move to file scope.
1389         (style_show_list): Likewise.
1390         (set_style): Call help_list.
1391         (show_style): Call cmd_show_list.
1392         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1393         Update to use the new macro.
1394
1395 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1396
1397         * ada-lang.c (_initialize_ada_language): Expand the help text
1398         for the "catch exception" command.
1399
1400 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1401
1402         * symtab.c (matching_obj_sections): Initialize obj,
1403         declare it closer to its usage.
1404
1405 2019-01-10  Tom Tromey  <tom@tromey.com>
1406
1407         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1408         (basic_inf_threads_range): Remove.
1409         (inf_threads_range, inf_non_exited_threads_range)
1410         (safe_inf_threads_range): Use next_adapter.
1411
1412 2019-01-10  Keith Seitz  <keiths@redhat.com>
1413
1414         PR gdb/23712
1415         PR symtab/23010
1416         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1417         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1418
1419 2019-01-10  Keith Seitz  <keiths@redhat.com>
1420
1421         PR gdb/23712
1422         PR symtab/23010
1423         * dictionary.c (pending_to_vector): Remove.
1424         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1425         Remove _1 suffix, replacing functions of the same name.  Update
1426         all callers.
1427         (dict_create_hashed, dict_create_hashed_expandable)
1428         (dict_create_linear, dict_create_linear_expandable, dict_free)
1429         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1430         Make functions static.
1431
1432 2019-01-10  Keith Seitz  <keiths@redhat.com>
1433
1434         PR gdb/23712
1435         PR symtab/23010
1436         * dictionary.h (struct dictionary): Replace declaration with
1437         multidictionary.
1438         (dict_create_hashed, dict_create_hashed_expandable)
1439         (dict_create_linear, dict_create_linear_expandable)
1440         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1441         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1442         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1443         taking multidictionary argument.
1444         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1445         * block.h (struct block) <dict>: Change to multidictionary
1446         and rename `multidict'.
1447         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1448         symmisc.c: Update all dictionary references to multidictionary.
1449
1450 2019-01-10  Keith Seitz  <keiths@redhat.com>
1451
1452         PR gdb/23712
1453         PR symtab/23010
1454         * dictionary.c: Include unordered_map.
1455         (pending_to_vector): New function.
1456         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1457         Rewrite the non-"_1" functions to take vector instead
1458         of linked list.
1459         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1460         "new" _1 versions of the same name.
1461         (multidictionary): Define.
1462         (std::hash<enum language): New definition.
1463         (collate_pending_symbols_by_language, mdict_create_hashed)
1464         (mdict_create_hashed_expandable, mdict_create_linear)
1465         (mdict_create_linear_expandable, mdict_free)
1466         (find_language_dictionary, create_new_language_dictionary)
1467         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1468         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1469         (mdict_size, mdict_empty): New functions.
1470         * dictionary.h (mdict_iterator): Define.
1471
1472 2019-01-10  Pedro Alves  <palves@redhat.com>
1473
1474         * breakpoint.c (read_uploaded_action)
1475         (create_tracepoint_from_upload): Adjust to use
1476         gdb::unique_xmalloc_ptr.
1477         * ctf.c (ctf_write_uploaded_tp):
1478         (SET_ARRAY_FIELD): Use emplace_back.
1479         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1480         * tracefile-tfile.c (tfile_write_uploaded_tp):
1481         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1482         gdb::unique_xmalloc_ptr.
1483         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1484         at_string, cond_string, cmd_strings>: Replace char pointers
1485         with gdb::unique_xmalloc_ptr.
1486
1487 2019-01-10  Pedro Alves  <palves@redhat.com>
1488
1489         * solib-target.c (library_list_start_library): Don't xstrdup name.
1490
1491 2019-01-10  Pedro Alves  <palves@redhat.com>
1492
1493         * mdebugread.c (parse_partial_symbols): Use
1494         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1495
1496 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1497
1498         * linux-fork.c (scoped_switch_fork_info)
1499         <~scoped_switch_fork_info>: Fix incorrect variable name.
1500
1501 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1502
1503         * linux-fork.c (scoped_switch_fork_info)
1504         <scoped_switch_fork_info>: Make explicit.
1505         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1506
1507 2019-01-10  Tom Tromey  <tom@tromey.com>
1508
1509         * objfiles.h (objfile::reset_psymtabs): Update.
1510         * objfiles.c (objfile::objfile): Update.
1511         * psymtab.h (psymtab_storage::obstack): Update.
1512         (psymtab_storage::m_obstack): Use gdb::optional.
1513         (class psymtab_storage): Update comment.  Remove objfile
1514         parameter.
1515         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1516
1517 2019-01-10  Tom Tromey  <tom@tromey.com>
1518
1519         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1520         <free_psymtabs>: Now private.
1521         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1522         (allocate_psymtab): Use new method.
1523
1524 2019-01-10  Tom Tromey  <tom@tromey.com>
1525
1526         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1527         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1528         * mdebugread.c (parse_partial_symbols): Use
1529         allocate_dependencies.
1530         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1531         allocate_dependencies.
1532         (process_psymtab_comp_unit_reader)
1533         (build_type_psymtab_dependencies): Likewise.
1534         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1535
1536 2019-01-10  Tom Tromey  <tom@tromey.com>
1537
1538         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1539         PSYMBOL_SET_LANGUAGE.
1540         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1541
1542 2019-01-10  Tom Tromey  <tom@tromey.com>
1543
1544         * psymtab.h (psymtab_storage::obstack): New method.
1545         <m_obstack>: Rename from obstack; now private.
1546         * psymtab.c (psymtab_storage): Update.
1547         * dwarf2read.c (create_addrmap_from_index)
1548         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1549         Update.
1550
1551 2019-01-10  Tom Tromey  <tom@tromey.com>
1552
1553         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1554         * objfiles.h (objfile::reset_psymtabs): New method.
1555
1556 2019-01-10  Tom Tromey  <tom@tromey.com>
1557
1558         * symmisc.c (print_symbol_bcache_statistics): Update.
1559         (print_objfile_statistics): Update.
1560         * symfile.c (reread_symbols): Update.
1561         * psymtab.h (class psymtab_storage): New.
1562         * psymtab.c (psymtab_storage): New constructor.
1563         (~psymtab_storage): New destructor.
1564         (require_partial_symbols): Update.
1565         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1566         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1567         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1568         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1569         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1570         (start_psymtab_common, end_psymtab_common)
1571         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1572         (allocate_psymtab): Update.
1573         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1574         Update.
1575         (dump_psymtab_addrmap, maintenance_print_psymbols)
1576         (maintenance_check_psymtabs): Update.
1577         (class objfile_psymtabs): Move to objfiles.h.
1578         * psympriv.h (discard_psymtab): Now inline.
1579         (psymtab_discarder::psymtab_discarder): Update.
1580         (psymtab_discarder::~psymtab_discarder): Update.
1581         (ALL_OBJFILE_PSYMTABS): Rewrite.
1582         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1583         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1584         Remove fields.
1585         <partial_symtabs>: New field.
1586         (class objfile_psymtabs): Move from psymtab.h.  Update.
1587         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1588         psymbol_cache.
1589         (objfile::~objfile): Don't destroy psymbol_cache.
1590         * mdebugread.c (parse_partial_symbols): Update.
1591         * dwarf2read.c (create_addrmap_from_index)
1592         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1593         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1594         (add_partial_subprogram, dwarf2_ranges_read): Update.
1595         * dwarf-index-write.c (write_address_map)
1596         (write_one_signatured_type, recursively_write_psymbols)
1597         (class debug_names, class debug_names, write_psymtabs_to_index):
1598         Update.
1599
1600 2019-01-10  Tom Tromey  <tom@tromey.com>
1601
1602         * symtab.h (SYMBOL_SET_NAMES): Update.
1603         (symbol_set_names): Update.
1604         (MSYMBOL_SET_NAMES): Update.
1605         * symtab.c (symbol_set_names): Change argument to be an
1606         objfile_per_bfd_storage.
1607         * psymtab.c (add_psymbol_to_bcache): Update.
1608         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1609
1610 2019-01-10  Tom Tromey  <tom@tromey.com>
1611
1612         * symtab.c (create_demangled_names_hash): Change argument to be an
1613         objfile_per_bfd_storage.
1614         (symbol_set_names): Update.
1615
1616 2019-01-10  Tom Tromey  <tom@tromey.com>
1617
1618         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1619         init_psymbol_list.
1620         * psymtab.c (init_psymbol_list): Do nothing if already called.
1621         * psympriv.h (init_psymbol_list): Add comment.
1622         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1623         init_psymbol_list.
1624         * dbxread.c (dbx_symfile_read): Unconditionally call
1625         init_psymbol_list.
1626
1627 2019-01-10  Tom Tromey  <tom@tromey.com>
1628
1629         * xcoffread.c (scan_xcoff_symtab): Update.
1630         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1631         "where".
1632         * mdebugread.c (parse_partial_symbols)
1633         (handle_psymbol_enumerators): Update.
1634         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1635         * dbxread.c (read_dbx_symtab): Update.
1636         * psympriv.h (psymbol_placement): New enum.
1637         (add_psymbol_to_list): Update.
1638
1639 2019-01-10  Tom Tromey  <tom@tromey.com>
1640
1641         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1642         static_psymbols parameters.
1643         (scan_xcoff_symtab): Update.
1644         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1645         static_psymbols parameters.
1646         * psympriv.h (start_psymtab_common): Update.
1647         * mdebugread.c (parse_partial_symbols): Update.
1648         * dwarf2read.c (create_partial_symtab): Update.
1649         * dbxread.c (read_dbx_symtab): Update.
1650         (start_psymtab): Remove global_psymbols and static_psymbols
1651         parameters.
1652
1653 2019-01-10  Tom Tromey  <tom@tromey.com>
1654
1655         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1656         * psymtab.c (allocate_psymtab): Add comment.
1657         * psympriv.h (allocate_psymtab): Add comment.
1658         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1659         initializations.
1660         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1661
1662 2019-01-10  Tom Tromey  <tom@tromey.com>
1663
1664         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1665         Don't declare.
1666         * mipsread.c: Include mdebugread.h.
1667         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1668         Declare.
1669         * elfread.c: Include mdebugread.h.
1670
1671 2019-01-09  Tom Tromey  <tom@tromey.com>
1672
1673         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1674         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1675         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1676         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1677         (psym_lookup_symbol, psym_find_last_source_symtab)
1678         (psym_forget_cached_source_info, psym_print_stats)
1679         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1680         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1681         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1682         (psym_find_compunit_symtab_by_address)
1683         (maintenance_print_psymbols, maintenance_info_psymtabs)
1684         (maintenance_check_psymtabs): Use ranged for.
1685         * psymtab.h (class objfile_psymtabs): New.
1686         (require_partial_symbols): Return objfile_psymtabs.
1687         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1688
1689 2019-01-09  Tom Tromey  <tom@tromey.com>
1690
1691         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1692         (find_pc_mapped_section, list_overlays_command)
1693         (map_overlay_command, unmap_overlay_command)
1694         (simple_overlay_update): Use all_objfiles.
1695         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1696         * printcmd.c (info_symbol_command): Use all_objfiles.
1697         * objfiles.h (ALL_OBJSECTIONS): Remove.
1698         * maint.c (maintenance_translate_address): Use all_objfiles.
1699         * gcore.c (gcore_create_callback): Use all_objfiles.
1700         (objfile_find_memory_regions): Likewise.
1701
1702 2019-01-09  Tom Tromey  <tom@tromey.com>
1703
1704         * symtab.c (find_line_symtab, info_sources_command)
1705         (make_source_files_completion_list): Use objfile_compunits.
1706         * source.c (select_source_symtab): Use objfile_compunits.
1707         * objfiles.h (struct objfile): Update comment.
1708         (ALL_OBJFILES): Remove.
1709         (ALL_FILETABS): Remove.
1710         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1711         objfile_compunits.
1712
1713 2019-01-09  Tom Tromey  <tom@tromey.com>
1714
1715         * symmisc.c (print_objfile_statistics, dump_objfile)
1716         (maintenance_print_symbols): Use compunit_filetabs.
1717         * source.c (forget_cached_source_info_for_objfile): Use
1718         compunit_filetabs.
1719         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1720         (ALL_FILETABS): Use compunit_filetabs.
1721         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1722         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1723
1724 2019-01-09  Tom Tromey  <tom@tromey.com>
1725
1726         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1727         (compunit_filetabs): New.
1728         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1729         compunit_filetabs.
1730         (info_sources_command, make_source_files_completion_list): Remove
1731         declaration.
1732         * symmisc.c (print_objfile_statistics, dump_objfile)
1733         (maintenance_print_symbols): Remove declaration.
1734         (maintenance_info_symtabs): Use compunit_filetabs.
1735         (maintenance_info_line_tables): Likewise.
1736         * source.c (select_source_symtab): Change local variable name.
1737         (forget_cached_source_info_for_objfile): Remove declaration.
1738         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1739         * objfiles.c (objfile_relocate1): Remove declaration.
1740         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1741         declaration.
1742         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1743         * coffread.c (coff_symtab_read): Remove declaration.
1744         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1745         compunit_filetabs.
1746
1747 2019-01-09  Tom Tromey  <tom@tromey.com>
1748
1749         * symtab.c (lookup_objfile_from_block)
1750         (find_pc_sect_compunit_symtab, search_symbols)
1751         (default_collect_symbol_completion_matches_break_on): Use
1752         objfile_compunits.
1753         * objfiles.h (ALL_COMPUNITS): Remove.
1754         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1755         * cp-support.c (add_symbol_overload_list_qualified): Use
1756         objfile_compunits.
1757         * ada-lang.c (ada_collect_symbol_completion_matches)
1758         (ada_add_global_exceptions): Use objfile_compunits.
1759
1760 2019-01-09  Tom Tromey  <tom@tromey.com>
1761
1762         * source.c (select_source_symtab)
1763         (forget_cached_source_info_for_objfile): Remove declaration.
1764         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1765         declaration.
1766         * maint.c (count_symtabs_and_blocks): Remove declaration.
1767         * cp-support.c (add_symbol_overload_list_qualified): Remove
1768         declaration.
1769         * coffread.c (coff_symtab_read): Remove declaration.
1770         * symtab.c (lookup_symbol_in_objfile_symtabs)
1771         (basic_lookup_transparent_type_1): Use objfile_compunits.
1772         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1773         (info_sources_command, search_symbols)
1774         (default_collect_symbol_completion_matches_break_on)
1775         (make_source_files_completion_list): Remove declaration.
1776         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1777         (ada_collect_symbol_completion_matches)
1778         (ada_add_global_exceptions): Remove declaration.
1779         * linespec.c (iterate_over_all_matching_symtabs): Use
1780         objfile_compunits.
1781         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1782         (class objfile_compunits): New.
1783         (ALL_COMPUNITS): Use objfile_compunits.
1784         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1785         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1786         objfile_compunits.
1787         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1788
1789 2019-01-09  Tom Tromey  <tom@tromey.com>
1790
1791         * symtab.c (search_symbols)
1792         (default_collect_symbol_completion_matches_break_on): Use
1793         objfile_msymbols.
1794         * ada-lang.c (ada_lookup_simple_minsym)
1795         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1796         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1797         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1798         objfile_msymbols.
1799         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1800         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1801         * objc-lang.c (find_methods): Use objfile_msymbols.
1802         (info_selectors_command, info_classes_command): Likewise.
1803         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1804         * objfiles.h (class objfile_msymbols): New.
1805         (ALL_OBJFILE_MSYMBOLS): Remove.
1806         (ALL_MSYMBOLS): Remove.
1807
1808 2019-01-09  Tom Tromey  <tom@tromey.com>
1809
1810         * common/next-iterator.h (next_adapter): Add Iterator template
1811         parameter.
1812         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1813         (class all_objfiles_safe): New.
1814         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1815         * objfiles.c (put_objfile_before): Update comment.
1816         (add_separate_debug_objfile): Likewise.
1817         (free_all_objfiles): Use all_objfiles_safe.
1818         (objfile_purge_solibs): Likewise.
1819
1820 2019-01-09  Tom Tromey  <tom@tromey.com>
1821
1822         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1823         (expand_symtab_containing_pc, lookup_static_symbol)
1824         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1825         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1826         all_objfiles.
1827         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1828         * breakpoint.c (create_overlay_event_breakpoint)
1829         (create_longjmp_master_breakpoint)
1830         (create_std_terminate_master_breakpoint)
1831         (create_exception_master_breakpoint): Use all_objfiles.
1832         * linux-thread-db.c (try_thread_db_load_from_pdir)
1833         (has_libpthread): Use all_objfiles.
1834         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1835         * linespec.c (iterate_over_all_matching_symtabs)
1836         (search_minsyms_for_name): Use all_objfiles.
1837         * maint.c (maintenance_info_sections): Use all_objfiles.
1838         * main.c (captured_main_1): Use all_objfiles.
1839         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1840         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1841         * guile/scm-pretty-print.c
1842         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1843         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1844         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1845         (maintenance_print_msymbols): Use all_objfiles.
1846         * source.c (select_source_symtab): Use all_objfiles.
1847         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1848         * symfile.c (remove_symbol_file_command)
1849         (expand_symtabs_matching, map_symbol_filenames): Use
1850         all_objfiles.
1851         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1852         all_objfiles.
1853         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1854         * objc-lang.c (find_methods): Use all_objfiles.
1855         * objfiles.c (have_partial_symbols, have_full_symbols)
1856         (have_minimal_symbols, qsort_cmp)
1857         (default_iterate_over_objfiles_in_search_order): Use
1858         all_objfiles.
1859         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1860         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1861         (maintenance_check_psymtabs): Use all_objfiles.
1862         (ALL_PSYMTABS): Remove.
1863         * compile/compile-object-run.c (do_module_cleanup): Use
1864         all_objfiles.
1865         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1866         * cp-support.c (add_symbol_overload_list_qualified): Use
1867         all_objfiles.
1868         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1869         Use all_objfiles.
1870         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1871         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1872         all_objfiles.
1873         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1874         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1875         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1876         Uses all_objfiles.
1877         * solib.c (solib_read_symbols): Use all_objfiles
1878
1879 2019-01-09  Tom Tromey  <tom@tromey.com>
1880
1881         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1882         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1883         all_objfiles.
1884         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1885         * symmisc.c (print_symbol_bcache_statistics)
1886         (print_objfile_statistics, maintenance_print_objfiles)
1887         (maintenance_info_symtabs, maintenance_check_symtabs)
1888         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1889         all_objfiles.
1890         * source.c (forget_cached_source_info): Use all_objfiles.
1891         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1892         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1893         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1894         * objfiles.c (update_section_map): Use all_objfiles.
1895         (shared_objfile_contains_address_p): Likewise.
1896         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1897         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1898
1899 2019-01-09  Tom Tromey  <tom@tromey.com>
1900
1901         * common/next-iterator.h: New file.
1902         * objfiles.h (class all_objfiles): New.
1903         (struct objfile_iterator): New.
1904
1905 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1906
1907         * NEWS: Move the description of the changed "frame", "select-frame",
1908          and "info frame" commands to the Changed commands section.
1909
1910 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1911
1912         * gdbtypes.c (check_stub_method_group): Remove handling of old
1913         mangling schemes.
1914         * linespec.c (find_methods): Likewise.
1915         * stabsread.c (read_member_functions): Likewise.
1916         * valops.c (search_struct_method): Likewise.
1917         (value_struct_elt_for_reference): Likewise.
1918         * NEWS: Mention this change.
1919
1920 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1921
1922         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1923         print_source_lines.
1924         * source.c (print_source_lines_base): Update line number check.
1925         (print_source_lines): New function.
1926         (source_lines_range::source_lines_range): New function.
1927         * source.h (class source_lines_range): New class.
1928         (print_source_lines): New declaration.
1929
1930 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1931
1932         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1933
1934 2019-01-08  Tom Tromey  <tom@tromey.com>
1935             Simon Marchi  <simon.marchi@ericsson.com>
1936
1937         PR gdb/24060
1938         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1939         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1940         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1941         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1942         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1943         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1944
1945 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1946
1947         * source.c (select_source_symtab): Move header comment to
1948         declaration in source.h.
1949         (forget_cached_source_info_for_objfile): Likewise.
1950         (forget_cached_source_info): Likewise.
1951         (identify_source_line): Likewise.
1952         * source.h (identify_source_line): Move declaration from symtab.h
1953         and add comment from source.c
1954         (print_source_lines): Likewise.
1955         (forget_cached_source_info_for_objfile): Likewise.
1956         (forget_cached_source_info): Likewise.
1957         (select_source_symtab): Likewise.
1958         (enum print_source_lines_flag): Move definition from symtab.h.
1959         * symtab.h (identify_source_line): Move declaration to source.h.
1960         (print_source_lines): Likewise.
1961         (forget_cached_source_info_for_objfile): Likewise.
1962         (forget_cached_source_info): Likewise.
1963         (select_source_symtab): Likewise.
1964         (enum print_source_lines_flag): Move definition to source.h.
1965         * tui/tui-hooks.c: Add 'source.h' include.
1966
1967 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1968
1969         * source.c (print_source_lines_base): Handle requests to print
1970         reverse line number sequences, and guard against empty lines
1971         string.
1972
1973 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1974
1975         * source.c (print_source_lines_base): Fix skip of '\r' if next
1976         character is '\n'.
1977
1978 2019-01-06  Tom Tromey  <tom@tromey.com>
1979
1980         * c-exp.y (struct c_parse_state) <macro_original_text,
1981         expansion_obstack>: New member.
1982         (macro_original_text, expansion_obstack): Remove globals.
1983         (scan_macro_expansion, scanning_macro_expansion)
1984         (finished_macro_expansion): Update.
1985         (scan_macro_cleanup): Remove.
1986         (yylex, c_parse): Update.
1987
1988 2019-01-06  Tom Tromey  <tom@tromey.com>
1989
1990         * c-exp.y (struct c_parse_state) <strings>: New member.
1991         (operator_stoken): Update.
1992
1993 2019-01-06  Tom Tromey  <tom@tromey.com>
1994
1995         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1996         (union type_stack_elt) <typelist_val>: Now a pointer to
1997         std::vector.
1998         (type_stack_cleanup): Don't declare.
1999         (push_typelist): Update.
2000         * parse.c (pop_typelist): Return a std::vector.
2001         (push_typelist): Take a std::vector.
2002         (follow_types): Update.  Do not free args.
2003         (type_stack_cleanup): Remove.
2004         * c-exp.y (struct c_parse_state): New.
2005         (cpstate): New global.
2006         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2007         (nonempty_typelist): Update.
2008         (func_mod): Create a new vector.
2009         (c_parse): Create a c_parse_state.
2010         (check_parameter_typelist): Do not delete params.
2011         (function_method): Update.  Do not delete type_list.
2012
2013 2019-01-06  Tom Tromey  <tom@tromey.com>
2014
2015         PR gdb/28155:
2016         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2017         check_typedef.
2018         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2019         (print_return_value): Likewise.
2020
2021 2019-01-05  Tom Tromey  <tom@tromey.com>
2022
2023         * contrib/cleanup_check.py: Remove.
2024         * contrib/gcc-with-excheck: Remove.
2025         * contrib/exsummary.py: Remove.
2026         * contrib/excheck.py: Remove.
2027
2028 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2029
2030         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2031         NULL. Initialize tpprev to NULL instead of assigning it
2032         to NULL on the next statement.
2033         * windows-nat.c (windows_delete_thread): Remove check for
2034         main_thread_id before printing thread exit notifications.
2035         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2036         Remove thread ID check against main_thread_id.
2037         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2038         windows_delete_thread.
2039         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2040
2041 2019-01-04  Tom Tromey  <tom@tromey.com>
2042
2043         * compile/compile.c (_initialize_compile): Use upper case for
2044         metasyntactic variables.
2045         * symmisc.c (_initialize_symmisc): Use upper case for
2046         metasyntactic variables.
2047         * psymtab.c (_initialize_psymtab): Use upper case for
2048         metasyntactic variables.
2049         * demangle.c (demangle_command): Use upper case for metasyntactic
2050         variables.
2051         (_initialize_demangler): Likewise.
2052         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2053         variables.
2054
2055 2019-01-03  Tom Tromey  <tom@tromey.com>
2056
2057         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2058
2059 2019-01-03  Tom Tromey  <tom@tromey.com>
2060
2061         * python/py-symtab.c (salpy_str): Update.
2062         (struct salpy_sal_object) <symtab>: Now a PyObject.
2063         (salpy_dealloc): Update.
2064         (del_objfile_sal): Use gdbpy_ref.
2065
2066 2019-01-03  Tom Tromey  <tom@tromey.com>
2067
2068         * python/py-type.c (convert_field): Use new_reference.  Return
2069         gdbpy_ref.
2070         (make_fielditem): Return gdbpy_ref.
2071         (typy_fields): Update.
2072         (typy_getitem): Update.
2073         (field_name): Return gdbpy_ref.  Use new_reference.
2074         (typy_iterator_iternext): Update.
2075
2076 2019-01-03  Tom Tromey  <tom@tromey.com>
2077
2078         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2079
2080 2019-01-03  Tom Tromey  <tom@tromey.com>
2081
2082         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2083         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2084         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2085         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2086         (pspy_set_type_printers): Likewise.
2087         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2088         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2089         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2090         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2091         (objfpy_set_type_printers): Likewise.
2092
2093 2019-01-03  Tom Tromey  <tom@tromey.com>
2094
2095         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2096         (gdbpy_print_stack): Use gdbpy_err_fetch.
2097         * python/python-internal.h (class gdbpy_err_fetch): New class.
2098         (class gdbpy_enter) <m_error_type, m_error_value,
2099         m_error_traceback>: Remove.
2100         <m_error>: New member.
2101         (gdbpy_exception_to_string): Don't declare.
2102         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2103         * python/py-value.c (convert_value_from_python): Use
2104         gdbpy_err_fetch.
2105         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2106         gdbpy_exception_to_string.
2107         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2108         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2109         gdbpy_err_fetch.
2110
2111 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2112
2113         * linux-nat.c (delete_lwp_cleanup): Delete.
2114         (struct lwp_deleter): New struct.
2115         (lwp_info_up): New typedef.
2116         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2117         lwp_info_up.
2118
2119 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2120
2121         * linux-fork.c (class scoped_switch_fork_info): New class.
2122         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2123
2124 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2125
2126         * valops.c (find_overload_match): Remove use of null_cleanup, and
2127         calls to do_cleanups.
2128
2129 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2130
2131         * compile/compile-cplus-types.c
2132         (compile_cplus_instance::decl_name): Handle changes to
2133         cp_func_name.
2134         * cp-support.c (cp_func_name): Update header comment, update
2135         return type.
2136         * cp-support.h (cp_func_name): Update return type in declaration.
2137         * valops.c (find_overload_match): Move temp_func local to top
2138         level of function and change its type.  Use temp_func to hold and
2139         delete temporary string obtained from cp_func_name.
2140
2141 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2142
2143         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2144         gdb::char_vector, remove cleanup, and update uses of `msg`.
2145
2146 2019-01-03  Jim Wilson  <jimw@sifive.com>
2147
2148         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2149
2150 2019-01-02  Tom Tromey  <tom@tromey.com>
2151
2152         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2153         (tdesc_parse_xml): Remove cleanups.
2154         * target-descriptions.h (make_cleanup_free_target_description):
2155         Don't declare.
2156         (target_desc_deleter): New struct.
2157         (target_desc_up): New typedef.
2158         * target-descriptions.c (target_desc_deleter::operator()): Rename
2159         from free_target_description.
2160         (make_cleanup_free_target_description): Remove.
2161
2162 2019-01-02  Tom Tromey  <tom@tromey.com>
2163
2164         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2165         constructor, destructor.
2166         (linespec_parser): Remove typedef.
2167         (~linespec_parser): Rename from linespec_parser_delete.
2168         (linespec_lex_to_end, linespec_complete_label)
2169         (linespec_complete): Update.
2170         (decode_line_full): Remove cleanups.
2171         (decode_line_1): Update.
2172
2173 2019-01-02  Tom Tromey  <tom@tromey.com>
2174
2175         * python/python-internal.h (inferior_to_inferior_object): Change
2176         return type.
2177         * python/py-exitedevent.c (create_exited_event_object): Update.
2178         * python/py-inferior.c (inferior_to_inferior_object): Return
2179         gdbpy_ref.
2180         (python_new_inferior, python_inferior_deleted)
2181         (thread_to_thread_object, delete_thread_object)
2182         (build_inferior_list, gdbpy_selected_inferior): Update.
2183         * python/py-infthread.c (create_thread_object): Update.  Also fail
2184         if inferior_to_inferior_object fails.
2185
2186 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2187
2188         * inferior.h (class inferior) <displaced_step_state>: New field.
2189         * infrun.h (struct displaced_step_state): Move here from
2190         infrun.c.  Initialize fields, add constructor.
2191         <inf>: Remove field.
2192         <reset>: New method.
2193         * infrun.c (struct displaced_step_inferior_state): Move to
2194         infrun.h.
2195         (displaced_step_inferior_states): Remove.
2196         (get_displaced_stepping_state): Adust.
2197         (displaced_step_in_progress_any_inferior): Adjust.
2198         (displaced_step_in_progress_thread): Adjust.
2199         (displaced_step_in_progress): Adjust.
2200         (add_displaced_stepping_state): Remove.
2201         (get_displaced_step_closure_by_addr): Adjust.
2202         (remove_displaced_stepping_state): Remove.
2203         (infrun_inferior_exit): Call displaced_step_state.reset.
2204         (use_displaced_stepping): Don't check for NULL.
2205         (displaced_step_prepare_throw): Call
2206         get_displaced_stepping_state.
2207         (displaced_step_fixup): Don't check for NULL.
2208         (prepare_for_detach): Don't check for NULL.
2209
2210 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2211
2212         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2213          in case of call that did not complete.
2214
2215 2019-01-02  Andrey Utkin  <autkin@undo.io>
2216
2217         * symfile.c (find_separate_debug_file): Fix search of debug files for
2218         remote debuggee.
2219
2220 2019-01-02  Tom Tromey  <tom@tromey.com>
2221
2222         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2223         indentation.
2224         * python/py-frame.c (frapy_older): Remove cast.
2225         (frapy_newer): Likewise.
2226         * python/py-breakpoint.c (local_setattro): Remove cast.
2227         * python/py-arch.c (archpy_name): Remove local variable.
2228         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2229
2230 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2231
2232         * unittests/basic_string_view/element_access/char/empty.cc:
2233         Fix year range in copyright header.
2234
2235 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2236
2237         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2238         Delete.
2239         <operator==>: Update with for removed field.
2240         <hash>: Likewise.
2241         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2242         <isa_features>: ...this.
2243         <abi_features>: New field.
2244         (riscv_isa_flen): Update comment.
2245         (riscv_abi_xlen): New declaration.
2246         (riscv_abi_flen): New declaration.
2247         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2248         isa_features.
2249         (riscv_abi_xlen): New function.
2250         (riscv_isa_flen): Update to get answer from isa_features.
2251         (riscv_abi_flen): New function.
2252         (riscv_has_fp_abi): Update to get answer from abi_features.
2253         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2254         xlen and flen.
2255         (riscv_call_info) <xlen, flen>: Update comment.
2256         (riscv_call_arg_struct): Remove invalid assertions
2257         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2258         is removed.
2259         (riscv_gdbarch_init): Gather isa features and abi features
2260         separately, ensure both match on the gdbarch when reusing an old
2261         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2262         a target with 64-bit float hardware.
2263
2264 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2265
2266         * source.c (search_command_helper): Stop reverse search
2267         when line 1 has been searched.
2268
2269 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2270
2271         * record-full.c (record_full_base_target::close): Rewrite
2272         record_full_core_buf_list free logic.
2273
2274 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2275
2276         * break-catch-syscall.c (print_one_catch_syscall): xfree
2277         the last text.
2278
2279 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2280
2281         * top.c (print_gdb_version): Update Copyright year in version
2282         message.
2283
2284 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2285
2286         Update copyright year range in all GDB files.
2287
2288 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2289
2290         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2291
2292 For older changes see ChangeLog-2018.
2293 \f
2294 Local Variables:
2295 mode: change-log
2296 left-margin: 8
2297 fill-column: 74
2298 version-control: never
2299 coding: utf-8
2300 End:
2301