gdb/ChangeLog

   1 2019-02-27  Pedro Alves  <palves@redhat.com>
   2
   3         * utils.c (set_screen_size): When we cap the height/width sizes,
   4         tweak the corresponding command variable to show "unlimited":
   5
   6 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
   7             Pedro Alves  <palves@redhat.com>
   8
   9         * utils.c (set_screen_size): Reduce "infinite" rows and columns
  10         before calling rl_set_screen_size.
  11
  12 2019-02-27  Tom Tromey  <tromey@adacore.com>
  13
  14         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
  15         define.
  16         * python/py-value.c: Remove Python 2.4 workaround.
  17         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
  18         workaround.
  19         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
  20         Python 2.4 workaround.
  21         * python/python-internal.h: Remove Python 2.4 comment.
  22         (Py_ssize_t): Don't define.
  23         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
  24         (gdb_Py_DECREF): Remove Python 2.4 workaround.
  25         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
  26         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
  27         * python/python.c (do_start_initialization): Remove Python 2.4
  28         workaround.
  29         * python/py-prettyprint.c (class dummy_python_frame): Remove.
  30         (print_children): Remove Python 2.4 workaround.
  31         * python/py-inferior.c (buffer_procs): Remove Python 2.4
  32         workaround.
  33         (CHARBUFFERPROC_NAME): Remove.
  34         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
  35         Python 2.4 workaround.
  36
  37 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
  38
  39         * NEWS: Note minimum Python version.
  40
  41 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
  42
  43         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
  44         code from these functions.  Remove corresponding ifdefs.  Use
  45         Py_buffer_up instead of explicit calls to PyBuffer_Release.
  46         Remove gotos and target of gotos.
  47         (infpy_search_memory): Likewise.
  48
  49 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  50
  51         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
  52         (hppa_gdbarch_init): Don't register deleted functions with
  53         gdbarch.
  54
  55 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  56
  57         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
  58         (h8300_unwind_sp): Delete.
  59         (h8300_dummy_id): Delete.
  60         (h8300_gdbarch_init): Don't register deleted functions with
  61         gdbarch.
  62
  63 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  64
  65         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
  66         (ft32_unwind_pc): Delete.
  67         (ft32_unwind_sp): Delete.
  68         (ft32_gdbarch_init): Don't register deleted functions with
  69         gdbarch.
  70
  71 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  72
  73         * gdb/frv-tdep.c (frv_dummy_id): Delete.
  74         (frv_unwind_pc): Delete.
  75         (frv_unwind_sp): Delete.
  76         (frv_gdbarch_init): Don't register deleted functions with
  77         gdbarch.
  78
  79 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  80
  81         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
  82         (riscv_unwind_pc): Delete.
  83         (riscv_unwind_sp): Delete.
  84         (riscv_gdbarch_init): Don't register deleted functions with
  85         gdbarch.
  86
  87 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  88
  89         * gdb/csky-tdep.c (csky_dummy_id): Delete.
  90         (csky_unwind_pc): Delete.
  91         (csky_unwind_sp): Delete.
  92         (csky_gdbarch_init): Don't register deleted functions with
  93         gdbarch.
  94
  95 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
  96
  97         * gdb/cris-tdep.c (cris_dummy_id): Delete.
  98         (cris_unwind_pc): Delete.
  99         (cris_unwind_sp): Delete.
 100         (cris_gdbarch_init): Don't register deleted functions with
 101         gdbarch.
 102
 103 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 104
 105         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
 106         (bfin_unwind_pc): Delete.
 107         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
 108
 109 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 110
 111         * gdb/arm-tdep.c (arm_dummy_id): Delete.
 112         (arm_unwind_pc): Delete.
 113         (arm_unwind_sp): Delete.
 114         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
 115
 116 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 117
 118         * gdb/arc-tdep.c (arc_dummy_id): Delete.
 119         (arc_unwind_pc): Delete.
 120         (arc_unwind_sp): Delete.
 121         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
 122
 123 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 124
 125         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
 126         (alpha_unwind_pc): Delete.
 127         (alpha_gdbarch_init): Don't register deleted functions with
 128         gdbarch.
 129
 130 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 131
 132         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
 133         (aarch64_unwind_pc): Delete.
 134         (aarch64_unwind_sp): Delete.
 135         (aarch64_gdbarch_init): Don't register deleted functions with
 136         gdbarch.
 137
 138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 139
 140         * gdbtypes.c (type_align): Don't consider static members when
 141         computing structure alignment.
 142
 143 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 144
 145         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
 146         return 0 for other types.
 147         * arch-utils.c (default_type_align): Always return 0.
 148         * gdbarch.h: Regenerate.
 149         * gdbarch.sh (type_align): Extend comment.
 150         * gdbtypes.c (type_align): Add additional comments, always call
 151         gdbarch_type_align before applying the default rules.
 152         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
 153         generic code will then apply a suitable default.
 154         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
 155         types, return 0 for other types.
 156
 157 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 158
 159         * NEWS: Create a new section for the next release branch.
 160         Rename the section of the current branch, now that it has
 161         been cut.
 162
 163 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
 164
 165         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
 166         * version.in: Bump version to 8.3.50.DATE-git.
 167
 168 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
 169
 170         * aix-thread.c (ptid_cmp): Remove unused variable.
 171         (get_signaled_thread): Likewise.
 172         (store_regs_user_thread): Likewise.
 173         (store_regs_kernel_thread): Likewise.
 174         (fetch_regs_kernel_thread): Remove shadowed variable.
 175
 176 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
 177
 178         * features/riscv/32bit-cpu.xml: Add register numbers.
 179         * features/riscv/32bit-fpu.c: Regenerate.
 180         * features/riscv/32bit-fpu.xml: Add register numbers.
 181         * features/riscv/64bit-cpu.xml: Add register numbers.
 182         * features/riscv/64bit-fpu.c: Regenerate.
 183         * features/riscv/64bit-fpu.xml: Add register numbers.
 184
 185 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
 186
 187         * NEWS: Mention two argument form of gdb.Value constructor.
 188         * python/py-value.c (convert_buffer_and_type_to_value): New
 189         function.
 190         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
 191         Add support for handling an optional second argument.  Call
 192         convert_buffer_and_type_to_value as appropriate.
 193         * python/python-internal.h (Py_buffer_deleter): New struct.
 194         (Py_buffer_up): New typedef.
 195
 196 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
 197
 198         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
 199         instead of releasing ownership.
 200
 201 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
 202
 203         * dwarf2read.c (open_and_init_dwp_file): Call
 204         elf_numsections instead of bfd_count_sections to initialize
 205         dwp_file->num_sections.
 206
 207 2019-02-25  Tom Tromey  <tromey@adacore.com>
 208
 209         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
 210
 211 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 212
 213         * gcore.in: Add '--readnever' option when invoking GDB.
 214
 215 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 216
 217         * MAINTAINERS: Update my email address.
 218
 219 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
 220
 221         * build-id.c (build_id_to_debug_bfd_1): New function.
 222         (build_id_to_debug_bfd): Look for separate debug file in
 223         sysroot.
 224
 225 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 226
 227         * gdbarch.sh: Update the copyright year range that is placed into
 228         generated files.
 229
 230 2019-02-22  Keith Seitz  <keiths@redhat.com>
 231
 232         PR symtab/23853
 233         * linespec.c (create_sals_line_offset): Search for the default
 234         symtab's filename instead of its fullname.
 235
 236 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 237
 238         * NEWS: Update style defaults.
 239
 240 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
 241
 242         * main.c (captured_main_1): Disable styling in batch mode.
 243
 244 2019-02-20  Tom Tromey  <tom@tromey.com>
 245
 246         * symtab.c (symtab_symbol_info): Fix typos.
 247
 248 2019-02-20  Tom Tromey  <tromey@adacore.com>
 249
 250         * findcmd.c (_initialize_mem_search): Use upper case for
 251         metasyntactic variables.
 252
 253 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
 254
 255         * aarch64-tdep.c (aarch64_add_reggroups): New function.
 256         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
 257
 258 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
 259
 260         * top.h (source_file_name): Change to std::string.
 261         * top.c (source_file_name): Likewise.
 262         (command_line_input): Adjust.
 263         * cli/cli-script.c (script_from_file): Adjust.
 264
 265 2019-02-19  Tom Tromey  <tromey@adacore.com>
 266
 267         * ravenscar-thread.c
 268         (ravenscar_thread_target::update_thread_list): Don't call
 269         ada_build_task_list.
 270         * ada-lang.h (ada_build_task_list): Don't declare.
 271         * ada-tasks.c (struct ada_tasks_inferior_data)
 272         <task_list_valid_p>: Now bool.
 273         (read_known_tasks, ada_task_list_changed)
 274         (ada_tasks_invalidate_inferior_data): Update.
 275         (read_known_tasks_array): Return bool.
 276         (read_known_tasks_list): Likewise.
 277         (read_known_tasks): Return void.
 278         (ada_build_task_list): Now static.
 279
 280 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 281
 282         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
 283         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
 284
 285 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 286
 287         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
 288         variant for ada_tasks_pspace_data_handle and
 289         ada_tasks_inferior_data_handle.
 290         (ada_tasks_pspace_data_cleanup): New function.
 291         (ada_tasks_inferior_data_cleanup): New function.
 292
 293 2019-02-17  Tom Tromey  <tom@tromey.com>
 294
 295         * macrotab.h (macro_source_fullname): Return a std::string.
 296         * macrotab.c (macro_include, check_for_redefinition)
 297         (macro_undef, macro_lookup_definition, foreach_macro)
 298         (foreach_macro_in_scope): Update.
 299         (macro_source_fullname): Return a std::string.
 300         * macrocmd.c (show_pp_source_pos): Update.
 301
 302 2019-02-17  Tom Tromey  <tom@tromey.com>
 303
 304         * macrocmd.c (show_pp_source_pos): Style the file names.
 305
 306 2019-02-17  Tom Tromey  <tom@tromey.com>
 307
 308         PR tui/24197:
 309         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
 310
 311 2019-02-17  Tom Tromey  <tom@tromey.com>
 312
 313         * ada-lang.c (user_select_syms): Use filtered printing.
 314         * utils.c (wrap_style): New global.
 315         (desired_style): Remove.
 316         (emit_style_escape): Add stream parameter.
 317         (set_output_style, reset_terminal_style, prompt_for_continue):
 318         Update.
 319         (flush_wrap_buffer): Only flush gdb_stdout.
 320         (wrap_here): Set wrap_style.
 321         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
 322         treat escape sequences as a character.  Change when wrap buffer is
 323         flushed.
 324         (fputs_styled): Do not set the output style when the default is
 325         requested.
 326         * ui-style.h (struct ui_file_style) <is_default>: New method.
 327         * source.c (print_source_lines_base): Emit escape sequences in one
 328         piece.
 329
 330 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 331
 332         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
 333         integers and enumeration types.
 334
 335 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
 336
 337         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
 338         instead of lookup_symbol_in_language
 339         (do_exact_match): New function.
 340         (ada_get_symbol_name_matcher): Return do_exact_match when
 341         doing a verbatim match.
 342
 343 2019-02-15  Tom Tromey  <tromey@adacore.com>
 344
 345         * ravenscar-thread.c (ravenscar_thread_target::resume)
 346         (ravenscar_thread_target::wait): Special case wildcard requests.
 347
 348 2019-02-15  Tom Tromey  <tromey@adacore.com>
 349
 350         * ravenscar-thread.c (base_ptid): Remove.
 351         (struct ravenscar_thread_target) <close>: New method.
 352         <m_base_ptid>: New member.
 353         <update_inferior_ptid, active_task, task_is_currently_active,
 354         runtime_initialized>: Declare methods.
 355         <ravenscar_thread_target>: Add constructor.
 356         (ravenscar_thread_target::task_is_currently_active)
 357         (ravenscar_thread_target::update_inferior_ptid)
 358         (ravenscar_runtime_initialized): Rename.  Now methods.
 359         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
 360         (ravenscar_thread_target::update_thread_list): Update.
 361         (ravenscar_thread_target::active_task): Now method.
 362         (ravenscar_thread_target::store_registers)
 363         (ravenscar_thread_target::prepare_to_store)
 364         (ravenscar_thread_target::prepare_to_store)
 365         (ravenscar_thread_target::mourn_inferior): Update.
 366         (ravenscar_inferior_created): Use "new" to create target.
 367         (ravenscar_thread_target::get_ada_task_ptid): Update.
 368         (_initialize_ravenscar): Don't initialize base_ptid.
 369         (ravenscar_ops): Remove global.
 370
 371 2019-02-15  Tom Tromey  <tromey@adacore.com>
 372
 373         * target.h (push_target): Declare new overload.
 374         * target.c (push_target): New overload, taking an rvalue reference.
 375         * remote.c (remote_target::open_1): Use push_target overload.
 376         * corelow.c (core_target_open): Use push_target overload.
 377
 378 2019-02-15  Tom Tromey  <tromey@adacore.com>
 379
 380         * ravenscar-thread.c (is_ravenscar_task)
 381         (ravenscar_task_is_currently_active): Return bool.
 382         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
 383         (_initialize_ravenscar): Remove "(void)".
 384         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
 385         Return bool.
 386
 387 2019-02-15  Tom Tromey  <tromey@adacore.com>
 388
 389         * ravenscar-thread.c (ravenscar_runtime_initializer)
 390         (has_ravenscar_runtime, get_running_thread_id)
 391         (ravenscar_thread_target::resume): Fix indentation.
 392
 393 2019-02-15  Tom Tromey  <tromey@adacore.com>
 394
 395         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
 396         from ravenscar_arch_ops.
 397         (sparc_ravenscar_ops::fetch_registers)
 398         (sparc_ravenscar_ops::store_registers): Now methods.
 399         (sparc_ravenscar_prepare_to_store): Remove.
 400         (sparc_ravenscar_ops): Redefine.
 401         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
 402         methods and destructor.  Remove members.
 403         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
 404         (ravenscar_thread_target::store_registers)
 405         (ravenscar_thread_target::prepare_to_store): Update.
 406         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
 407         Remove.
 408         (struct ppc_ravenscar_powerpc_ops): Derive from
 409         ravenscar_arch_ops.
 410         (ppc_ravenscar_powerpc_ops::fetch_registers)
 411         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
 412         (ppc_ravenscar_powerpc_ops): Redefine.
 413         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
 414         (ppc_ravenscar_e500_ops::fetch_registers)
 415         (ppc_ravenscar_e500_ops::store_registers): Now methods.
 416         (ppc_ravenscar_e500_ops): Redefine.
 417         * aarch64-ravenscar-thread.c
 418         (aarch64_ravenscar_generic_prepare_to_store): Remove.
 419         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
 420         (aarch64_ravenscar_fetch_registers)
 421         (aarch64_ravenscar_store_registers): Now methods.
 422         (aarch64_ravenscar_ops): Redefine.
 423
 424 2019-02-15  Tom Tromey  <tromey@adacore.com>
 425
 426         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
 427         (ravenscar_thread_target::stopped_by_hw_breakpoint)
 428         (ravenscar_thread_target::stopped_by_watchpoint)
 429         (ravenscar_thread_target::stopped_data_address)
 430         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
 431
 432 2019-02-15  Tom Tromey  <tromey@adacore.com>
 433
 434         * ravenscar-thread.c: Fix some typos.
 435
 436 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 437             Tom Tromey  <tromey@adacore.com>
 438
 439         * ada-lang.c (ada_exception_sal): Change addr_string to a
 440         std::string.
 441         (create_ada_exception_catchpoint): Update.
 442
 443 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 444             Tom Tromey  <tromey@adacore.com>
 445
 446         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
 447         (bp_location_ops): Remove.
 448         (base_breakpoint_allocate_location): Update.
 449         (free_bp_location): Update.
 450         * ada-lang.c (class ada_catchpoint_location)
 451         <ada_catchpoint_location>: Remove ops parameter.
 452         (ada_catchpoint_location_dtor): Remove.
 453         (ada_catchpoint_location_ops): Remove.
 454         (allocate_location_exception): Update.
 455         * breakpoint.h (struct bp_location_ops): Remove.
 456         (class bp_location) <bp_location>: Remove bp_location_ops
 457         parameter.
 458         <~bp_location>: Add destructor.
 459         <ops>: Remove.
 460
 461 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 462             Pedro Alves  <palves@redhat.com>
 463
 464         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
 465         'PATH_MAX'.
 466
 467 2019-02-14  David Michael  <fedora.dm0@gmail.com>
 468             Samuel Thibault  <samuel.thibault@gnu.org>
 469             Thomas Schwinge  <thomas@codesourcery.com>
 470
 471         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
 472         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
 473
 474 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
 475
 476         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
 477         (check_empty): Use "const char *".
 478
 479         * gnu-nat.c (gnu_nat_target::detach): Instead of
 480         'detach_inferior (pid)' call
 481         'detach_inferior (find_inferior_pid (pid))'.
 482
 483         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
 484         'nat/fork-inferior.o'.
 485         * gnu-nat.c: #include "nat/fork-inferior.h".
 486
 487         * gnu-nat.c (gnu_nat_target::detach): Instead of
 488         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
 489         * gnu-nat.h: #include "inf-child.h".
 490         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
 491         'i386_gnu_nat_target::fetch_registers'.
 492         (gnu_store_registers): Rename/move to
 493         'i386_gnu_nat_target::store_registers'.
 494
 495         * config/i386/nm-i386gnu.h: Don't "#include" any files.
 496         * gnu-nat.h (mach_thread_info): New function.
 497         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
 498
 499         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
 500
 501 2019-02-14  Frederic Konrad  <konrad@adacore.com>
 502
 503         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
 504
 505 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
 506
 507         * windows-nat.c (windows_add_thread): Add new parameter
 508         "main_thread_p" with default value set to false.  Update
 509         function documentation as well as all callers.
 510         (windows_delete_thread): Likewise.
 511         (fake_create_process): Update call to windows_add_thread.
 512         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
 513         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
 514         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
 515         call to windows_delete_thread.
 516
 517 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
 518
 519         * MAINTAINERS: Add Andrew Burgess as global maintainer.
 520
 521 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 522
 523         * symfile.c (find_separate_debug_file): Use canonical path of
 524         sysroot with child_path instead of gdb_sysroot if it is valid.
 525
 526 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 527
 528         * symfile.c (find_separate_debug_file): Use child_path to
 529         determine if an object file is under a sysroot.
 530
 531 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 532
 533         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 534         unittests/child-path-selftests.c.
 535         * common/pathstuff.c (child_path): New function.
 536         * common/pathstuff.h (child_path): New prototype.
 537         * unittests/child-path-selftests.c: New file.
 538
 539 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
 540
 541         * symfile.c (find_separate_debug_file): Look for separate debug
 542         files in debug directories under the sysroot.
 543
 544 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 545
 546         * symtab.h (struct minimal_symbol data_p): New const method.
 547         (struct minimal_symbol text_p): Likewise.
 548         * symtab.c (output_source_filename): Use file name style
 549         to print file name.
 550         (print_symbol_info): Likewise.
 551         (print_msymbol_info): Use address style to print addresses.
 552         Use function name style to print executable text symbols.
 553         (expand_symtab_containing_pc): Use data_p.
 554         (find_pc_sect_compunit_symtab): Likewise.
 555
 556 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 557
 558         * breakpoint.c (describe_other_breakpoints): Use address style
 559         to print addresses.
 560         (say_where): Likewise.
 561
 562 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 563
 564         * ada-typeprint.c (print_func_type): Print function name
 565         style to print function name.
 566         * c-typeprint.c (c_print_type_1): Likewise.
 567
 568 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 569
 570         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 571         for execve.
 572
 573 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 574
 575         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 576         type_stack.
 577
 578 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 579
 580         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 581         TYPE_CODE_REF types.
 582
 583 2019-02-08  Jim Wilson  <jimw@sifive.com>
 584
 585         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 586         (riscv_linux_fregset): New.
 587         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 588
 589 2019-02-07  Tom Tromey  <tom@tromey.com>
 590
 591         * thread.c (thread_cancel_execution_command): Update.
 592         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 593         methods.
 594         (struct thread_fsm_ops): Remove.
 595         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 596         (thread_fsm_should_stop, thread_fsm_return_value)
 597         (thread_fsm_set_finished, thread_fsm_finished_p)
 598         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 599         Don't declare.
 600         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 601         * infrun.c (clear_proceed_status_thread)
 602         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 603         (print_stop_event): Update.
 604         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 605         Add constructor.
 606         (step_command_fsm_ops): Remove.
 607         (new_step_command_fsm): Remove.
 608         (step_1): Update.
 609         (step_command_fsm::should_stop): Rename from
 610         step_command_fsm_should_stop.
 611         (step_command_fsm::clean_up): Rename from
 612         step_command_fsm_clean_up.
 613         (step_command_fsm::do_async_reply_reason): Rename from
 614         step_command_fsm_async_reply_reason.
 615         (struct until_next_fsm): Inherit from thread_fsm.  Add
 616         constructor.
 617         (until_next_fsm_ops): Remove.
 618         (new_until_next_fsm): Remove.
 619         (until_next_fsm::should_stop): Rename from
 620         until_next_fsm_should_stop.
 621         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 622         (until_next_fsm::do_async_reply_reason): Rename from
 623         until_next_fsm_async_reply_reason.
 624         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 625         constructor.  Change type of breakpoint.
 626         (finish_command_fsm_ops): Remove.
 627         (new_finish_command_fsm): Remove.
 628         (finish_command_fsm::should_stop): Rename from
 629         finish_command_fsm_should_stop.
 630         (finish_command_fsm::clean_up): Rename from
 631         finish_command_fsm_clean_up.
 632         (finish_command_fsm::return_value): Rename from
 633         finish_command_fsm_return_value.
 634         (finish_command_fsm::do_async_reply_reason): Rename from
 635         finish_command_fsm_async_reply_reason.
 636         (finish_command): Update.
 637         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 638         Add constructor.
 639         (call_thread_fsm_ops): Remove.
 640         (call_thread_fsm::call_thread_fsm): Rename from
 641         new_call_thread_fsm.
 642         (call_thread_fsm::should_stop): Rename from
 643         call_thread_fsm_should_stop.
 644         (call_thread_fsm::should_notify_stop): Rename from
 645         call_thread_fsm_should_notify_stop.
 646         (run_inferior_call, call_function_by_hand_dummy): Update.
 647         * cli/cli-interp.c (should_print_stop_to_console): Update.
 648         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 649         Add constructor.  Change type of location_breakpoint,
 650         caller_breakpoint.
 651         (until_break_fsm_ops): Remove.
 652         (new_until_break_fsm): Remove.
 653         (until_break_fsm::should_stop): Rename from
 654         until_break_fsm_should_stop.
 655         (until_break_fsm::clean_up): Rename from
 656         until_break_fsm_clean_up.
 657         (until_break_fsm::do_async_reply_reason): Rename from
 658         until_break_fsm_async_reply_reason.
 659         (until_break_command): Update.
 660         * thread-fsm.c: Remove.
 661         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 662
 663 2019-02-07  Tom Tromey  <tom@tromey.com>
 664
 665         * yy-remap.h: Add include guard.
 666         * xtensa-tdep.h: Add include guard.
 667         * xcoffread.h: Rename include guard.
 668         * varobj-iter.h: Add include guard.
 669         * tui/tui.h: Rename include guard.
 670         * tui/tui-winsource.h: Rename include guard.
 671         * tui/tui-wingeneral.h: Rename include guard.
 672         * tui/tui-windata.h: Rename include guard.
 673         * tui/tui-win.h: Rename include guard.
 674         * tui/tui-stack.h: Rename include guard.
 675         * tui/tui-source.h: Rename include guard.
 676         * tui/tui-regs.h: Rename include guard.
 677         * tui/tui-out.h: Rename include guard.
 678         * tui/tui-layout.h: Rename include guard.
 679         * tui/tui-io.h: Rename include guard.
 680         * tui/tui-hooks.h: Rename include guard.
 681         * tui/tui-file.h: Rename include guard.
 682         * tui/tui-disasm.h: Rename include guard.
 683         * tui/tui-data.h: Rename include guard.
 684         * tui/tui-command.h: Rename include guard.
 685         * tic6x-tdep.h: Add include guard.
 686         * target/waitstatus.h: Rename include guard.
 687         * target/wait.h: Rename include guard.
 688         * target/target.h: Rename include guard.
 689         * target/resume.h: Rename include guard.
 690         * target-float.h: Rename include guard.
 691         * stabsread.h: Add include guard.
 692         * rs6000-tdep.h: Add include guard.
 693         * riscv-fbsd-tdep.h: Add include guard.
 694         * regformats/regdef.h: Rename include guard.
 695         * record.h: Rename include guard.
 696         * python/python.h: Rename include guard.
 697         * python/python-internal.h: Rename include guard.
 698         * python/py-stopevent.h: Rename include guard.
 699         * python/py-ref.h: Rename include guard.
 700         * python/py-record.h: Rename include guard.
 701         * python/py-record-full.h: Rename include guard.
 702         * python/py-record-btrace.h: Rename include guard.
 703         * python/py-instruction.h: Rename include guard.
 704         * python/py-events.h: Rename include guard.
 705         * python/py-event.h: Rename include guard.
 706         * procfs.h: Add include guard.
 707         * proc-utils.h: Add include guard.
 708         * p-lang.h: Add include guard.
 709         * or1k-tdep.h: Rename include guard.
 710         * observable.h: Rename include guard.
 711         * nto-tdep.h: Rename include guard.
 712         * nat/x86-linux.h: Rename include guard.
 713         * nat/x86-linux-dregs.h: Rename include guard.
 714         * nat/x86-gcc-cpuid.h: Add include guard.
 715         * nat/x86-dregs.h: Rename include guard.
 716         * nat/x86-cpuid.h: Rename include guard.
 717         * nat/ppc-linux.h: Rename include guard.
 718         * nat/mips-linux-watch.h: Rename include guard.
 719         * nat/linux-waitpid.h: Rename include guard.
 720         * nat/linux-ptrace.h: Rename include guard.
 721         * nat/linux-procfs.h: Rename include guard.
 722         * nat/linux-osdata.h: Rename include guard.
 723         * nat/linux-nat.h: Rename include guard.
 724         * nat/linux-namespaces.h: Rename include guard.
 725         * nat/linux-btrace.h: Rename include guard.
 726         * nat/glibc_thread_db.h: Rename include guard.
 727         * nat/gdb_thread_db.h: Rename include guard.
 728         * nat/gdb_ptrace.h: Rename include guard.
 729         * nat/fork-inferior.h: Rename include guard.
 730         * nat/amd64-linux-siginfo.h: Rename include guard.
 731         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 732         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 733         * nat/aarch64-linux.h: Rename include guard.
 734         * nat/aarch64-linux-hw-point.h: Rename include guard.
 735         * mn10300-tdep.h: Add include guard.
 736         * mips-linux-tdep.h: Add include guard.
 737         * mi/mi-parse.h: Rename include guard.
 738         * mi/mi-out.h: Rename include guard.
 739         * mi/mi-main.h: Rename include guard.
 740         * mi/mi-interp.h: Rename include guard.
 741         * mi/mi-getopt.h: Rename include guard.
 742         * mi/mi-console.h: Rename include guard.
 743         * mi/mi-common.h: Rename include guard.
 744         * mi/mi-cmds.h: Rename include guard.
 745         * mi/mi-cmd-break.h: Rename include guard.
 746         * m2-lang.h: Add include guard.
 747         * location.h: Rename include guard.
 748         * linux-record.h: Rename include guard.
 749         * linux-nat.h: Add include guard.
 750         * linux-fork.h: Add include guard.
 751         * i386-darwin-tdep.h: Rename include guard.
 752         * hppa-linux-offsets.h: Add include guard.
 753         * guile/guile.h: Rename include guard.
 754         * guile/guile-internal.h: Rename include guard.
 755         * gnu-nat.h: Rename include guard.
 756         * gdb-stabs.h: Rename include guard.
 757         * frv-tdep.h: Add include guard.
 758         * f-lang.h: Add include guard.
 759         * event-loop.h: Add include guard.
 760         * darwin-nat.h: Rename include guard.
 761         * cp-abi.h: Rename include guard.
 762         * config/sparc/nm-sol2.h: Rename include guard.
 763         * config/nm-nto.h: Rename include guard.
 764         * config/nm-linux.h: Add include guard.
 765         * config/i386/nm-i386gnu.h: Rename include guard.
 766         * config/djgpp/nl_types.h: Rename include guard.
 767         * config/djgpp/langinfo.h: Rename include guard.
 768         * compile/gcc-cp-plugin.h: Add include guard.
 769         * compile/gcc-c-plugin.h: Add include guard.
 770         * compile/compile.h: Rename include guard.
 771         * compile/compile-object-run.h: Rename include guard.
 772         * compile/compile-object-load.h: Rename include guard.
 773         * compile/compile-internal.h: Rename include guard.
 774         * compile/compile-cplus.h: Rename include guard.
 775         * compile/compile-c.h: Rename include guard.
 776         * common/xml-utils.h: Rename include guard.
 777         * common/x86-xstate.h: Rename include guard.
 778         * common/version.h: Rename include guard.
 779         * common/vec.h: Rename include guard.
 780         * common/tdesc.h: Rename include guard.
 781         * common/selftest.h: Rename include guard.
 782         * common/scoped_restore.h: Rename include guard.
 783         * common/scoped_mmap.h: Rename include guard.
 784         * common/scoped_fd.h: Rename include guard.
 785         * common/safe-iterator.h: Rename include guard.
 786         * common/run-time-clock.h: Rename include guard.
 787         * common/refcounted-object.h: Rename include guard.
 788         * common/queue.h: Rename include guard.
 789         * common/ptid.h: Rename include guard.
 790         * common/print-utils.h: Rename include guard.
 791         * common/preprocessor.h: Rename include guard.
 792         * common/pathstuff.h: Rename include guard.
 793         * common/observable.h: Rename include guard.
 794         * common/netstuff.h: Rename include guard.
 795         * common/job-control.h: Rename include guard.
 796         * common/host-defs.h: Rename include guard.
 797         * common/gdb_wait.h: Rename include guard.
 798         * common/gdb_vecs.h: Rename include guard.
 799         * common/gdb_unlinker.h: Rename include guard.
 800         * common/gdb_unique_ptr.h: Rename include guard.
 801         * common/gdb_tilde_expand.h: Rename include guard.
 802         * common/gdb_sys_time.h: Rename include guard.
 803         * common/gdb_string_view.h: Rename include guard.
 804         * common/gdb_splay_tree.h: Rename include guard.
 805         * common/gdb_setjmp.h: Rename include guard.
 806         * common/gdb_ref_ptr.h: Rename include guard.
 807         * common/gdb_optional.h: Rename include guard.
 808         * common/gdb_locale.h: Rename include guard.
 809         * common/gdb_assert.h: Rename include guard.
 810         * common/filtered-iterator.h: Rename include guard.
 811         * common/filestuff.h: Rename include guard.
 812         * common/fileio.h: Rename include guard.
 813         * common/environ.h: Rename include guard.
 814         * common/common-utils.h: Rename include guard.
 815         * common/common-types.h: Rename include guard.
 816         * common/common-regcache.h: Rename include guard.
 817         * common/common-inferior.h: Rename include guard.
 818         * common/common-gdbthread.h: Rename include guard.
 819         * common/common-exceptions.h: Rename include guard.
 820         * common/common-defs.h: Rename include guard.
 821         * common/common-debug.h: Rename include guard.
 822         * common/cleanups.h: Rename include guard.
 823         * common/buffer.h: Rename include guard.
 824         * common/btrace-common.h: Rename include guard.
 825         * common/break-common.h: Rename include guard.
 826         * cli/cli-utils.h: Rename include guard.
 827         * cli/cli-style.h: Rename include guard.
 828         * cli/cli-setshow.h: Rename include guard.
 829         * cli/cli-script.h: Rename include guard.
 830         * cli/cli-interp.h: Rename include guard.
 831         * cli/cli-decode.h: Rename include guard.
 832         * cli/cli-cmds.h: Rename include guard.
 833         * charset-list.h: Add include guard.
 834         * buildsym-legacy.h: Rename include guard.
 835         * bfin-tdep.h: Add include guard.
 836         * ax.h: Rename include guard.
 837         * arm-linux-tdep.h: Add include guard.
 838         * arm-fbsd-tdep.h: Add include guard.
 839         * arch/xtensa.h: Rename include guard.
 840         * arch/tic6x.h: Add include guard.
 841         * arch/i386.h: Add include guard.
 842         * arch/arm.h: Rename include guard.
 843         * arch/arm-linux.h: Rename include guard.
 844         * arch/arm-get-next-pcs.h: Rename include guard.
 845         * arch/amd64.h: Add include guard.
 846         * arch/aarch64-insn.h: Rename include guard.
 847         * arch-utils.h: Rename include guard.
 848         * annotate.h: Add include guard.
 849         * amd64-darwin-tdep.h: Rename include guard.
 850         * aarch64-linux-tdep.h: Add include guard.
 851         * aarch64-fbsd-tdep.h: Add include guard.
 852         * aarch32-linux-nat.h: Add include guard.
 853
 854 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 855
 856         * macrotab.c (macro_define_internal): New function that
 857         factorizes macro_define_object_internal and macro_define_function
 858         code.
 859         (macro_define_object_internal): Use macro_define_internal.
 860         (macro_define_function): Likewise.
 861
 862 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 863
 864         * macrocmd.c (extract_identifier): Return
 865         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 866         callers.
 867
 868 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 869
 870         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 871
 872 2019-02-05  Tom Tromey  <tom@tromey.com>
 873
 874         * target.c (target_stack::unpush): Move assertion earlier.
 875
 876 2019-01-30  Tom Tromey  <tom@tromey.com>
 877
 878         PR python/23615:
 879         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 880         (gdbpy_parse_and_eval): Likewise.
 881         * python/python-internal.h (gdbpy_allow_threads): New class.
 882
 883 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 884
 885         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 886         (aarch64_fbsd_fpregmap): Move earlier.
 887         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 888         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 889         instead of individual calls to trad_frame_set_reg_addr.
 890         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 891         earlier.
 892         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 893         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 894         instead of individual calls to trad_frame_set_reg_addr.
 895
 896 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 897
 898         * CONTRIBUTE: Replace contribution list with wiki link.
 899
 900 2019-01-25  Tom Tromey  <tom@tromey.com>
 901
 902         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 903
 904 2019-01-25  Tom Tromey  <tom@tromey.com>
 905
 906         * xtensa-linux-nat.c: Fix common/ includes.
 907         * xml-support.h: Fix common/ includes.
 908         * xml-support.c: Fix common/ includes.
 909         * x86-linux-nat.c: Fix common/ includes.
 910         * windows-nat.c: Fix common/ includes.
 911         * varobj.h: Fix common/ includes.
 912         * varobj.c: Fix common/ includes.
 913         * value.c: Fix common/ includes.
 914         * valops.c: Fix common/ includes.
 915         * utils.c: Fix common/ includes.
 916         * unittests/xml-utils-selftests.c: Fix common/ includes.
 917         * unittests/utils-selftests.c: Fix common/ includes.
 918         * unittests/unpack-selftests.c: Fix common/ includes.
 919         * unittests/tracepoint-selftests.c: Fix common/ includes.
 920         * unittests/style-selftests.c: Fix common/ includes.
 921         * unittests/string_view-selftests.c: Fix common/ includes.
 922         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 923         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 924         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 925         * unittests/rsp-low-selftests.c: Fix common/ includes.
 926         * unittests/parse-connection-spec-selftests.c: Fix common/
 927         includes.
 928         * unittests/optional-selftests.c: Fix common/ includes.
 929         * unittests/offset-type-selftests.c: Fix common/ includes.
 930         * unittests/observable-selftests.c: Fix common/ includes.
 931         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 932         * unittests/memrange-selftests.c: Fix common/ includes.
 933         * unittests/memory-map-selftests.c: Fix common/ includes.
 934         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 935         * unittests/function-view-selftests.c: Fix common/ includes.
 936         * unittests/environ-selftests.c: Fix common/ includes.
 937         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 938         * unittests/common-utils-selftests.c: Fix common/ includes.
 939         * unittests/cli-utils-selftests.c: Fix common/ includes.
 940         * unittests/array-view-selftests.c: Fix common/ includes.
 941         * ui-file.c: Fix common/ includes.
 942         * tui/tui-io.c: Fix common/ includes.
 943         * tracepoint.h: Fix common/ includes.
 944         * tracepoint.c: Fix common/ includes.
 945         * tracefile-tfile.c: Fix common/ includes.
 946         * top.h: Fix common/ includes.
 947         * top.c: Fix common/ includes.
 948         * thread.c: Fix common/ includes.
 949         * target/waitstatus.h: Fix common/ includes.
 950         * target/waitstatus.c: Fix common/ includes.
 951         * target.h: Fix common/ includes.
 952         * target.c: Fix common/ includes.
 953         * target-memory.c: Fix common/ includes.
 954         * target-descriptions.c: Fix common/ includes.
 955         * symtab.h: Fix common/ includes.
 956         * symfile.c: Fix common/ includes.
 957         * stap-probe.c: Fix common/ includes.
 958         * spu-linux-nat.c: Fix common/ includes.
 959         * sparc-nat.c: Fix common/ includes.
 960         * source.c: Fix common/ includes.
 961         * solib.c: Fix common/ includes.
 962         * solib-target.c: Fix common/ includes.
 963         * ser-unix.c: Fix common/ includes.
 964         * ser-tcp.c: Fix common/ includes.
 965         * ser-pipe.c: Fix common/ includes.
 966         * ser-base.c: Fix common/ includes.
 967         * selftest-arch.c: Fix common/ includes.
 968         * s12z-tdep.c: Fix common/ includes.
 969         * rust-exp.y: Fix common/ includes.
 970         * rs6000-aix-tdep.c: Fix common/ includes.
 971         * riscv-tdep.c: Fix common/ includes.
 972         * remote.c: Fix common/ includes.
 973         * remote-notif.h: Fix common/ includes.
 974         * remote-fileio.h: Fix common/ includes.
 975         * remote-fileio.c: Fix common/ includes.
 976         * regcache.h: Fix common/ includes.
 977         * regcache.c: Fix common/ includes.
 978         * record-btrace.c: Fix common/ includes.
 979         * python/python.c: Fix common/ includes.
 980         * python/py-type.c: Fix common/ includes.
 981         * python/py-inferior.c: Fix common/ includes.
 982         * progspace.h: Fix common/ includes.
 983         * producer.c: Fix common/ includes.
 984         * procfs.c: Fix common/ includes.
 985         * proc-api.c: Fix common/ includes.
 986         * printcmd.c: Fix common/ includes.
 987         * ppc-linux-nat.c: Fix common/ includes.
 988         * parser-defs.h: Fix common/ includes.
 989         * osdata.c: Fix common/ includes.
 990         * obsd-nat.c: Fix common/ includes.
 991         * nat/x86-linux.c: Fix common/ includes.
 992         * nat/x86-linux-dregs.c: Fix common/ includes.
 993         * nat/x86-dregs.h: Fix common/ includes.
 994         * nat/x86-dregs.c: Fix common/ includes.
 995         * nat/ppc-linux.c: Fix common/ includes.
 996         * nat/mips-linux-watch.h: Fix common/ includes.
 997         * nat/mips-linux-watch.c: Fix common/ includes.
 998         * nat/linux-waitpid.c: Fix common/ includes.
 999         * nat/linux-ptrace.h: Fix common/ includes.
1000         * nat/linux-ptrace.c: Fix common/ includes.
1001         * nat/linux-procfs.c: Fix common/ includes.
1002         * nat/linux-personality.c: Fix common/ includes.
1003         * nat/linux-osdata.c: Fix common/ includes.
1004         * nat/linux-namespaces.c: Fix common/ includes.
1005         * nat/linux-btrace.h: Fix common/ includes.
1006         * nat/linux-btrace.c: Fix common/ includes.
1007         * nat/fork-inferior.c: Fix common/ includes.
1008         * nat/amd64-linux-siginfo.c: Fix common/ includes.
1009         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
1010         * nat/aarch64-linux.c: Fix common/ includes.
1011         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
1012         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
1013         * namespace.h: Fix common/ includes.
1014         * mips-linux-tdep.c: Fix common/ includes.
1015         * minsyms.c: Fix common/ includes.
1016         * mi/mi-parse.h: Fix common/ includes.
1017         * mi/mi-main.c: Fix common/ includes.
1018         * mi/mi-cmd-env.c: Fix common/ includes.
1019         * memrange.h: Fix common/ includes.
1020         * memattr.c: Fix common/ includes.
1021         * maint.h: Fix common/ includes.
1022         * maint.c: Fix common/ includes.
1023         * main.c: Fix common/ includes.
1024         * machoread.c: Fix common/ includes.
1025         * location.c: Fix common/ includes.
1026         * linux-thread-db.c: Fix common/ includes.
1027         * linux-nat.c: Fix common/ includes.
1028         * linux-fork.c: Fix common/ includes.
1029         * inline-frame.c: Fix common/ includes.
1030         * infrun.c: Fix common/ includes.
1031         * inflow.c: Fix common/ includes.
1032         * inferior.h: Fix common/ includes.
1033         * inferior.c: Fix common/ includes.
1034         * infcmd.c: Fix common/ includes.
1035         * inf-ptrace.c: Fix common/ includes.
1036         * inf-child.c: Fix common/ includes.
1037         * ia64-linux-nat.c: Fix common/ includes.
1038         * i387-tdep.c: Fix common/ includes.
1039         * i386-tdep.c: Fix common/ includes.
1040         * i386-linux-tdep.c: Fix common/ includes.
1041         * i386-linux-nat.c: Fix common/ includes.
1042         * i386-go32-tdep.c: Fix common/ includes.
1043         * i386-fbsd-tdep.c: Fix common/ includes.
1044         * i386-fbsd-nat.c: Fix common/ includes.
1045         * guile/scm-type.c: Fix common/ includes.
1046         * guile/guile.c: Fix common/ includes.
1047         * go32-nat.c: Fix common/ includes.
1048         * gnu-nat.c: Fix common/ includes.
1049         * gdbthread.h: Fix common/ includes.
1050         * gdbarch-selftests.c: Fix common/ includes.
1051         * gdb_usleep.c: Fix common/ includes.
1052         * gdb_select.h: Fix common/ includes.
1053         * gdb_bfd.c: Fix common/ includes.
1054         * gcore.c: Fix common/ includes.
1055         * fork-child.c: Fix common/ includes.
1056         * findvar.c: Fix common/ includes.
1057         * fbsd-nat.c: Fix common/ includes.
1058         * event-top.c: Fix common/ includes.
1059         * event-loop.c: Fix common/ includes.
1060         * dwarf2read.c: Fix common/ includes.
1061         * dwarf2loc.c: Fix common/ includes.
1062         * dwarf2-frame.c: Fix common/ includes.
1063         * dwarf-index-cache.c: Fix common/ includes.
1064         * dtrace-probe.c: Fix common/ includes.
1065         * disasm-selftests.c: Fix common/ includes.
1066         * defs.h: Fix common/ includes.
1067         * csky-tdep.c: Fix common/ includes.
1068         * cp-valprint.c: Fix common/ includes.
1069         * cp-support.h: Fix common/ includes.
1070         * cp-support.c: Fix common/ includes.
1071         * corelow.c: Fix common/ includes.
1072         * completer.h: Fix common/ includes.
1073         * completer.c: Fix common/ includes.
1074         * compile/compile.c: Fix common/ includes.
1075         * compile/compile-loc2c.c: Fix common/ includes.
1076         * compile/compile-cplus-types.c: Fix common/ includes.
1077         * compile/compile-cplus-symbols.c: Fix common/ includes.
1078         * command.h: Fix common/ includes.
1079         * cli/cli-dump.c: Fix common/ includes.
1080         * cli/cli-cmds.c: Fix common/ includes.
1081         * charset.c: Fix common/ includes.
1082         * build-id.c: Fix common/ includes.
1083         * btrace.h: Fix common/ includes.
1084         * btrace.c: Fix common/ includes.
1085         * breakpoint.h: Fix common/ includes.
1086         * breakpoint.c: Fix common/ includes.
1087         * ax.h:
1088         (enum agent_op): Fix common/ includes.
1089         * ax-general.c (struct aop_map): Fix common/ includes.
1090         * ax-gdb.c: Fix common/ includes.
1091         * auxv.c: Fix common/ includes.
1092         * auto-load.c: Fix common/ includes.
1093         * arm-tdep.c: Fix common/ includes.
1094         * arch/riscv.c: Fix common/ includes.
1095         * arch/ppc-linux-common.c: Fix common/ includes.
1096         * arch/i386.c: Fix common/ includes.
1097         * arch/arm.c: Fix common/ includes.
1098         * arch/arm-linux.c: Fix common/ includes.
1099         * arch/arm-get-next-pcs.c: Fix common/ includes.
1100         * arch/amd64.c: Fix common/ includes.
1101         * arch/aarch64.c: Fix common/ includes.
1102         * arch/aarch64-insn.c: Fix common/ includes.
1103         * arch-utils.c: Fix common/ includes.
1104         * amd64-windows-tdep.c: Fix common/ includes.
1105         * amd64-tdep.c: Fix common/ includes.
1106         * amd64-sol2-tdep.c: Fix common/ includes.
1107         * amd64-obsd-tdep.c: Fix common/ includes.
1108         * amd64-nbsd-tdep.c: Fix common/ includes.
1109         * amd64-linux-tdep.c: Fix common/ includes.
1110         * amd64-linux-nat.c: Fix common/ includes.
1111         * amd64-fbsd-tdep.c: Fix common/ includes.
1112         * amd64-fbsd-nat.c: Fix common/ includes.
1113         * amd64-dicos-tdep.c: Fix common/ includes.
1114         * amd64-darwin-tdep.c: Fix common/ includes.
1115         * agent.c: Fix common/ includes.
1116         * ada-lang.h: Fix common/ includes.
1117         * ada-lang.c: Fix common/ includes.
1118         * aarch64-tdep.c: Fix common/ includes.
1119
1120 2019-01-25  Tom Tromey  <tom@tromey.com>
1121
1122         * common/create-version.sh: Use common/version.h.
1123
1124 2019-01-24  Pedro Alves  <palves@redhat.com>
1125
1126         * infrun.c (signal_stop, signal_print, signal_program)
1127         (signal_catch, signal_pass): Now arrays instead of pointers.
1128         (update_signals_program_target, do_target_resume)
1129         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
1130         * linux-nat.c (linux_nat_target::pass_signals)
1131         (linux_nat_target::create_inferior, linux_nat_target::attach):
1132         Adjust.
1133         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
1134         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
1135         * procfs.c (procfs_target::pass_signals): Adjust.
1136         * record-full.c (record_full_target::resume): Adjust.
1137         * remote.c (remote_target::pass_signals)
1138         (remote_target::program_signals): Adjust.
1139         * target-debug.h (target_debug_print_signals): Now takes a
1140         gdb::array_view as parameter.  Adjust.
1141         * target.h (target_ops) <pass_signals, program_signals>: Replace
1142         pointer and length parameters with gdb::array_view.
1143         (target_pass_signals, target_program_signals): Likewise.
1144         * target-delegates.c: Regenerate.
1145
1146 2019-01-24  Pedro Alves  <palves@redhat.com>
1147
1148         * common/forward-scope-exit.h
1149         (forward_scope_exit::forward_scope_exit): Pass arguments to
1150         m_bind_function directly, instead of creating a std::bind and
1151         copying that.
1152
1153 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
1154
1155         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1156         for static members.
1157         (pass_in_v_vfp_candidate): Likewise.
1158
1159 2019-01-23  Tom Tromey  <tom@tromey.com>
1160             Pedro Alves  <palves@redhat.com>
1161
1162         * regcache.c (class regcache_invalidator): Remove.
1163         (regcache::raw_write): Use make_scope_exit.
1164
1165 2019-01-23  Tom Tromey  <tom@tromey.com>
1166
1167         * ui-out.h (class ui_out_emit_type): Update comment.
1168
1169 2019-01-23  Tom Tromey  <tom@tromey.com>
1170
1171         * infrun.c (fetch_inferior_event): Update comment.
1172
1173 2019-01-23  Tom Tromey  <tom@tromey.com>
1174             Pedro Alves  <palves@redhat.com>
1175
1176         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
1177         parameter.
1178         (fetch_inferior_event): Use SCOPE_EXIT.
1179
1180
1181 2019-01-23  Tom Tromey  <tom@tromey.com>
1182             Pedro Alves  <palves@redhat.com>
1183
1184         * infrun.c (disable_thread_events): Delete.
1185         (stop_all_threads): Use SCOPE_EXIT.
1186
1187 2019-01-23  Tom Tromey  <tom@tromey.com>
1188             Pedro Alves  <palves@redhat.com>
1189
1190         * symfile.c: Include forward-scope-exit.h.
1191         (clear_symtab_users_cleanup): Replace forward declaration with
1192         a FORWARD_SCOPE_EXIT.
1193         (syms_from_objfile_1): Use the forward_scope_exit and
1194         gdb::optional instead of cleanup_function.
1195         (reread_symbols): Use the forward_scope_exit instead of
1196         cleanup_function.
1197         (clear_symtab_users_cleanup): Remove function.
1198
1199 2019-01-23  Tom Tromey  <tom@tromey.com>
1200             Pedro Alves  <palves@redhat.com>
1201
1202         * linux-nat.c: Include scope-exit.h.
1203         (cleanup_target_stop): Remove.
1204         (linux_nat_target::static_tracepoint_markers_by_strid): Use
1205         SCOPE_EXIT.
1206
1207 2019-01-23  Tom Tromey  <tom@tromey.com>
1208             Pedro Alves  <palves@redhat.com>
1209
1210         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
1211         (call_function_by_hand_dummy): Use SCOPE_EXIT.
1212
1213 2019-01-23  Tom Tromey  <tom@tromey.com>
1214             Andrew Burgess  <andrew.burgess@embecosm.com>
1215             Pedro Alves  <palves@redhat.com>
1216
1217         * infrun.c (fetch_inferior_event): Use scope_exit.
1218         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
1219         * top.c (execute_command): Use scope_exit.
1220         * breakpoint.c (bpstat_do_actions): Use scope_exit.
1221         * utils.c (do_bpstat_clear_actions_cleanup)
1222         (make_bpstat_clear_actions_cleanup): Remove.
1223
1224 2019-01-23  Tom Tromey  <tom@tromey.com>
1225             Pedro Alves  <palves@redhat.com>
1226
1227         * infrun.c: Include "common/scope-exit.h"
1228         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
1229         (wait_for_inferior): Use SCOPE_EXIT.
1230         (fetch_inferior_event): Use scope_exit.
1231
1232 2019-01-23  Tom Tromey  <tom@tromey.com>
1233             Pedro Alves  <palves@redhat.com>
1234
1235         * breakpoint.c (create_breakpoint): Remove cleanup.
1236
1237 2019-01-23  Tom Tromey  <tom@tromey.com>
1238             Andrew Burgess  <andrew.burgess@embecosm.com>
1239             Pedro Alves  <palves@redhat.com>
1240
1241 2019-01-23  Pedro Alves  <palves@redhat.com>
1242
1243         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
1244
1245 2019-01-23  Pedro Alves  <palves@redhat.com>
1246             Andrew Burgess  <andrew.burgess@embecosm.com>
1247
1248         * gdbthread.h: Include "common/forward-scope-exit.h".
1249         (scoped_finish_thread_state): Redefine custom class in terms of
1250         forward_scope_exit.
1251
1252 2019-01-23  Pedro Alves  <palves@redhat.com>
1253             Andrew Burgess  <andrew.burgess@embecosm.com>
1254
1255         * common/forward-scope-exit.h: New file.
1256
1257 2019-01-23  Pedro Alves  <palves@redhat.com>
1258             Andrew Burgess  <andrew.burgess@embecosm.com>
1259             Tom Tromey  <tom@tromey.com>
1260
1261         * common/scope-exit.h: New file.
1262
1263 2019-01-23  Pedro Alves  <palves@redhat.com>
1264
1265         * common/preprocessor.h (ESC): Rename to ...
1266         (ESC_PARENS): ... this.
1267         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
1268         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
1269
1270 2019-01-23  Tom Tromey  <tom@tromey.com>
1271
1272         * language.h (class scoped_switch_to_sym_language_if_auto):
1273         Initialize m_lang in both cases.
1274
1275 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
1276
1277         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
1278         with XCNEW.
1279
1280 2019-01-22  Tom Tromey  <tom@tromey.com>
1281
1282         * corelow.c: Do not include sys/file.h.
1283
1284 2019-01-22  Tom Tromey  <tom@tromey.com>
1285
1286         * tui/tui-wingeneral.h: Include gdb_curses.h.
1287
1288 2019-01-22  Tom Tromey  <tom@tromey.com>
1289
1290         * source-cache.h (class source_cache) <get_source_lines,
1291         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
1292
1293 2019-01-22  Tom Tromey  <tom@tromey.com>
1294
1295         * remote-fileio.h (struct remote_target): Declare.
1296
1297 2019-01-22  Tom Tromey  <tom@tromey.com>
1298
1299         * python/py-arch.c: Do not include py-ref.h.
1300         * python/py-bpevent.c: Do not include py-ref.h.
1301         * python/py-cmd.c: Do not include py-ref.h.
1302         * python/py-continueevent.c: Do not include py-ref.h.
1303         * python/py-event.h: Do not include py-ref.h.
1304         * python/py-evtregistry.c: Do not include py-ref.h.
1305         * python/py-finishbreakpoint.c: Do not include py-ref.h.
1306         * python/py-frame.c: Do not include py-ref.h.
1307         * python/py-framefilter.c: Do not include py-ref.h.
1308         * python/py-function.c: Do not include py-ref.h.
1309         * python/py-infevents.c: Do not include py-ref.h.
1310         * python/py-linetable.c: Do not include py-ref.h.
1311         * python/py-objfile.c: Do not include py-ref.h.
1312         * python/py-param.c: Do not include py-ref.h.
1313         * python/py-prettyprint.c: Do not include py-ref.h.
1314         * python/py-progspace.c: Do not include py-ref.h.
1315         * python/py-symbol.c: Do not include py-ref.h.
1316         * python/py-symtab.c: Do not include py-ref.h.
1317         * python/py-type.c: Do not include py-ref.h.
1318         * python/py-unwind.c: Do not include py-ref.h.
1319         * python/py-utils.c: Do not include py-ref.h.
1320         * python/py-value.c: Do not include py-ref.h.
1321         * python/py-varobj.c: Do not include py-ref.h.
1322         * python/py-xmethods.c: Do not include py-ref.h.
1323         * python/python.c: Do not include py-ref.h.
1324         * varobj.c: Do not include py-ref.h.
1325
1326 2019-01-22  Tom Tromey  <tom@tromey.com>
1327
1328         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
1329         keyword for bcache.
1330
1331 2019-01-22  Tom Tromey  <tom@tromey.com>
1332
1333         * compile/compile-cplus-types.c: Remove a comment by #include.
1334
1335 2019-01-22  Tom Tromey  <tom@tromey.com>
1336
1337         * compile/gcc-c-plugin.h: Include compile-internal.h.
1338
1339 2019-01-22  Tom Tromey  <tom@tromey.com>
1340
1341         * stabsread.c (EXTERN): Do not define.
1342         (symnum, next_symbol_text_func, processing_gcc_compilation)
1343         (within_function, global_sym_chain, global_stabs)
1344         (previous_stab_code, this_object_header_files)
1345         (n_this_object_header_files)
1346         (n_allocated_this_object_header_files): Define.
1347         * stabsread.h (EXTERN): Never define.  Use "extern".
1348
1349 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1350
1351         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
1352         history_value.
1353
1354 2019-01-21  Tom Tromey  <tom@tromey.com>
1355
1356         * ui-out.c: Fix includes.
1357         * tui/tui-source.c: Fix includes.
1358         * target.c: Fix includes.
1359         * remote.c: Fix includes.
1360         * regcache.c: Fix includes.
1361         * python/py-block.c: Fix includes.
1362         * printcmd.c: Fix includes.
1363         * or1k-tdep.c: Fix includes.
1364         * mi/mi-main.c: Fix includes.
1365         * m32r-tdep.c: Fix includes.
1366         * csky-tdep.c: Fix includes.
1367         * compile/compile-cplus-types.c: Fix includes.
1368         * cli/cli-interp.c: Fix includes.
1369
1370 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
1371
1372         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
1373         for padding.
1374
1375 2019-01-16  Tom Tromey  <tom@tromey.com>
1376
1377         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
1378         earlier.
1379         (struct objfile) <msymbols_range>: Move from top level.
1380         <msymbols>: New method.
1381         (class objfile_msymbols): Remove.
1382         * symtab.c (default_collect_symbol_completion_matches_break_on):
1383         Update.
1384         * symmisc.c (dump_msymbols): Update.
1385         * stabsread.c (scan_file_globals): Update.
1386         * objc-lang.c (info_selectors_command, info_classes_command)
1387         (find_methods): Update.
1388         * minsyms.c (find_solib_trampoline_target): Update.
1389         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1390         * coffread.c (coff_symfile_read): Update.
1391         * ada-lang.c (ada_lookup_simple_minsym)
1392         (ada_collect_symbol_completion_matches): Update.
1393
1394 2019-01-16  Tom Tromey  <tom@tromey.com>
1395
1396         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
1397         type.  Remove no-argument constructor.
1398         <iterator::operator++>: Simplify.
1399         <begin>: Update.
1400         <end>: Use minimal_symbol_count.
1401
1402 2019-01-16  Tom Tromey  <tom@tromey.com>
1403
1404         * objfiles.h (struct objfile) <psymtabs>: New method.
1405         (class objfile_psymtabs): Remove.
1406         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
1407         typedef.
1408         <range>: New method.
1409         (require_partial_symbols): Change return type.
1410         * psymtab.c (require_partial_symbols)
1411         (psym_expand_symtabs_matching): Update.
1412         * mdebugread.c (parse_partial_symbols): Update.
1413         * dbxread.c (dbx_end_psymtab): Update.
1414
1415 2019-01-15  Tom Tromey  <tom@tromey.com>
1416
1417         * symtab.c (lookup_objfile_from_block)
1418         (lookup_symbol_in_objfile_symtabs)
1419         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
1420         (find_line_symtab, info_sources_command)
1421         (default_collect_symbol_completion_matches_break_on)
1422         (make_source_files_completion_list): Update.
1423         * symmisc.c (print_objfile_statistics, dump_objfile)
1424         (maintenance_print_symbols, maintenance_info_symtabs)
1425         (maintenance_check_symtabs, maintenance_info_line_tables):
1426         Update.
1427         * source.c (select_source_symtab)
1428         (forget_cached_source_info_for_objfile): Update.
1429         * objfiles.h (class objfile_compunits): Remove.
1430         (struct objfile) <compunits_range>: New typedef.
1431         (compunits): New method.
1432         * objfiles.c (objfile_relocate1): Update.
1433         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1434         * maint.c (count_symtabs_and_blocks): Update.
1435         * linespec.c (iterate_over_all_matching_symtabs): Update.
1436         * cp-support.c (add_symbol_overload_list_qualified): Update.
1437         * coffread.c (coff_symtab_read): Update.
1438         * ada-lang.c (add_nonlocal_symbols)
1439         (ada_collect_symbol_completion_matches)
1440         (ada_add_global_exceptions): Update.
1441
1442 2019-01-15  Tom Tromey  <tom@tromey.com>
1443
1444         * progspace.h (program_space) <objfiles_safe_range>: New
1445         typedef.
1446         <objfiles_safe>: New method.
1447         * objfiles.h (class all_objfiles_safe): Remove.
1448         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
1449         * jit.c (jit_inferior_exit_hook): Update.
1450
1451 2019-01-17  Tom Tromey  <tom@tromey.com>
1452
1453         * progspace.h (program_space) <objfiles_range>: New typedef.
1454         <objfiles>: New method.
1455         <objfiles_head>: Rename from objfiles.
1456         (object_files): Update.
1457         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
1458         * guile/scm-pretty-print.c
1459         (ppscm_find_pretty_printer_from_objfiles): Update.
1460         * guile/scm-objfile.c (gdbscm_objfiles): Update.
1461         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
1462         Update.
1463         * python/py-progspace.c (pspy_get_objfiles): Update.
1464         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1465         Update.
1466         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1467         (objfpy_lookup_objfile_by_build_id): Update.
1468         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1469         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1470         Update.
1471         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1472         (expand_symtab_containing_pc, lookup_objfile_from_block)
1473         (lookup_static_symbol, basic_lookup_transparent_type)
1474         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1475         (find_line_symtab, info_sources_command)
1476         (default_collect_symbol_completion_matches_break_on)
1477         (make_source_files_completion_list, find_main_name): Update.
1478         * symmisc.c (print_symbol_bcache_statistics)
1479         (print_objfile_statistics, maintenance_print_symbols)
1480         (maintenance_print_msymbols, maintenance_print_objfiles)
1481         (maintenance_info_symtabs, maintenance_check_symtabs)
1482         (maintenance_expand_symtabs, maintenance_info_line_tables):
1483         Update.
1484         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1485         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1486         (map_overlay_command, unmap_overlay_command)
1487         (simple_overlay_update, expand_symtabs_matching)
1488         (map_symbol_filenames): Update.
1489         * symfile-debug.c (set_debug_symfile): Update.
1490         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1491         Update.
1492         * source.c (select_source_symtab, forget_cached_source_info):
1493         Update.
1494         * solib.c (solib_read_symbols): Update.
1495         * solib-spu.c (append_ocl_sos): Update.
1496         * psymtab.c (maintenance_print_psymbols)
1497         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1498         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1499         * printcmd.c (info_symbol_command): Update.
1500         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1501         Update.
1502         * objfiles.h (class all_objfiles): Remove.
1503         * objfiles.c (have_partial_symbols, have_full_symbols)
1504         (have_minimal_symbols, qsort_cmp, update_section_map)
1505         (shared_objfile_contains_address_p)
1506         (default_iterate_over_objfiles_in_search_order): Update.
1507         * objc-lang.c (info_selectors_command, info_classes_command)
1508         (find_methods): Update.
1509         * minsyms.c (find_solib_trampoline_target): Update.
1510         * maint.c (maintenance_info_sections)
1511         (maintenance_translate_address, count_symtabs_and_blocks):
1512         Update.
1513         * main.c (captured_main_1): Update.
1514         * linux-thread-db.c (try_thread_db_load_from_pdir)
1515         (has_libpthread): Update.
1516         * linespec.c (iterate_over_all_matching_symtabs)
1517         (search_minsyms_for_name): Update.
1518         * jit.c (jit_find_objf_with_entry_addr): Update.
1519         * hppa-tdep.c (find_unwind_entry)
1520         (hppa_lookup_stub_minimal_symbol): Update.
1521         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1522         Update.
1523         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1524         (elf_gnu_ifunc_resolve_by_got): Update.
1525         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1526         * dwarf-index-write.c (save_gdb_index_command): Update.
1527         * cp-support.c (add_symbol_overload_list_qualified): Update.
1528         * breakpoint.c (create_overlay_event_breakpoint)
1529         (create_longjmp_master_breakpoint)
1530         (create_std_terminate_master_breakpoint)
1531         (create_exception_master_breakpoint): Update.
1532         * blockframe.c (find_pc_partial_function): Update.
1533         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1534         (ada_collect_symbol_completion_matches)
1535         (ada_add_global_exceptions): Update.
1536
1537 2019-01-17  Tom Tromey  <tom@tromey.com>
1538
1539         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1540         declare VEC.
1541         (solib_target_parse_libraries): Change return type.
1542         (library_list_start_segment, library_list_start_section)
1543         (library_list_end_library, library_list_start_library); Update.
1544         (solib_target_free_library_list): Remove.
1545         (solib_target_parse_libraries): Remove cleanup.  Change return
1546         type.
1547         (solib_target_current_sos): Update.
1548
1549 2019-01-17  Tom Tromey  <tromey@bapiya>
1550
1551         * valprint.c: Replace "the the" with "the".
1552         * symtab.c: Replace "the the" with "the".
1553         * solib.c: Replace "the the" with "the".
1554         * solib-dsbt.c: Replace "the the" with "the".
1555         * linespec.c: Replace "the the" with "the".
1556         * dwarf2loc.h: Replace "the the" with "the".
1557         * amd64-windows-tdep.c: Replace "the the" with "the".
1558         * aarch64-tdep.c: Replace "the the" with "the".
1559
1560 2019-01-16  Keith Seitz  <keiths@redhat.com>
1561
1562         PR gdb/23773
1563         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1564         <builder>: Rename to ..
1565         <m_builder>: ... this and make private.
1566         (dwarf2_cu::get_builder): New method.  Change all users of
1567         `builder' to use this method.
1568         (dwarf2_start_symtab): Move to ...
1569         (dwarf2_cu::start_symtab): ... here.  Update all callers
1570         (setup_type_unit_groups): Move to ...
1571         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1572         callers.
1573         (dwarf2_cu::reset_builder): New method.
1574         (process_full_compunit, process_full_type_unit): Use
1575         dwarf2_cu::reset_builder.
1576         (follow_die_offset): Record the ancestor CU if it is different
1577         from the followed DIE's CU.
1578         (follow_die_sig_1): Likewise.
1579
1580 2019-01-15  Tom Tromey  <tom@tromey.com>
1581
1582         * remote.c (class remote_state) <buf>: Now a char_vector.
1583         <buf_size>: Remove.
1584         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1585         parameter.
1586         (remote_target::getpkt_or_notif_sane_1)
1587         (remote_target::getpkt_sane)
1588         (remote_target::getpkt_or_notif_sane): Likewise.
1589         (class remote_target) <putpkt>: New overload.
1590         (remote_target::read_frame): Change type of "buf_p".  Remove
1591         sizeof_p parameter.
1592         (packet_ok): New overload.
1593         (packet_check_result): New overload.
1594         Update all uses.
1595
1596 2019-01-14  Tom Tromey  <tom@tromey.com>
1597
1598         * remote-notif.c (handle_notification, remote_notif_ack)
1599         (remote_notif_parse): Make "buf" const.
1600         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1601         const.
1602         (remote_notif_parse, remote_notif_ack, handle_notification):
1603         Likewise.
1604         * remote.c (remote_notif_stop_parse): Make "buf" const.
1605         (remote_target::remote_parse_stop_reply): Make "buf" const.
1606         (remote_notif_stop_ack): Make "buf" const.
1607
1608 2019-01-14  Tom Tromey  <tom@tromey.com>
1609
1610         * remote.c (remote_console_output): Make parameter const.
1611
1612 2019-01-14  Tom Tromey  <tom@tromey.com>
1613
1614         * target-debug.h (target_debug_print_signals): Constify.
1615         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1616         * procfs.c (procfs_target::pass_signals): Update.
1617         * linux-nat.c (linux_nat_target::pass_signals): Update.
1618         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1619         * target-delegates.c: Rebuild.
1620         * remote.c (remote_target::program_signals): Update.
1621         (remote_target::pass_signals): Update.
1622         * target.c (target_pass_signals): Constify argument.
1623         (target_program_signals): Likewise.
1624         * target.h (struct target_ops) <pass_signals, program_signals>:
1625         Constify argument.
1626         (target_pass_signals, target_program_signals): Constify argument.
1627
1628 2019-01-14  Tom Tromey  <tom@tromey.com>
1629
1630         PR tui/28819:
1631         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1632
1633 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1634
1635         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1636         field.
1637         * rs6000-tdep.c: Include reggroups.h.
1638         (IS_V_ALIAS_PSEUDOREG): Define.
1639         (rs6000_register_name): Return names for the "vX" aliases.
1640         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1641         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1642         aliases.  Call default_register_reggroup_p for all other
1643         pseudo-registers.
1644         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1645         New functions.
1646         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1647         Handle "vX" aliases.
1648         (v_alias_pseudo_register_collect): New function.
1649         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1650         (rs6000_gdbarch_init): Initialize "vX" aliases as
1651         pseudo-registers.  Restore registration of
1652         rs6000_pseudo_register_reggroup_p with
1653         set_tdesc_pseudo_register_reggroup_p.
1654
1655 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1656
1657         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1658         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1659         set_gdbarch_num_pseudo_regs.
1660
1661 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1662
1663         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1664         Remove arg prefixname, add do_set and do_show.
1665         Add member functions set_list and show_list.
1666         * cli/cli-style.c (class cli_style_option): Update accordingly.
1667         (style_set_list): Move to file scope.
1668         (style_show_list): Likewise.
1669         (set_style): Call help_list.
1670         (show_style): Call cmd_show_list.
1671         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1672         Update to use the new macro.
1673
1674 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1675
1676         * ada-lang.c (_initialize_ada_language): Expand the help text
1677         for the "catch exception" command.
1678
1679 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1680
1681         * symtab.c (matching_obj_sections): Initialize obj,
1682         declare it closer to its usage.
1683
1684 2019-01-10  Tom Tromey  <tom@tromey.com>
1685
1686         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1687         (basic_inf_threads_range): Remove.
1688         (inf_threads_range, inf_non_exited_threads_range)
1689         (safe_inf_threads_range): Use next_adapter.
1690
1691 2019-01-10  Keith Seitz  <keiths@redhat.com>
1692
1693         PR gdb/23712
1694         PR symtab/23010
1695         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1696         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1697
1698 2019-01-10  Keith Seitz  <keiths@redhat.com>
1699
1700         PR gdb/23712
1701         PR symtab/23010
1702         * dictionary.c (pending_to_vector): Remove.
1703         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1704         Remove _1 suffix, replacing functions of the same name.  Update
1705         all callers.
1706         (dict_create_hashed, dict_create_hashed_expandable)
1707         (dict_create_linear, dict_create_linear_expandable, dict_free)
1708         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1709         Make functions static.
1710
1711 2019-01-10  Keith Seitz  <keiths@redhat.com>
1712
1713         PR gdb/23712
1714         PR symtab/23010
1715         * dictionary.h (struct dictionary): Replace declaration with
1716         multidictionary.
1717         (dict_create_hashed, dict_create_hashed_expandable)
1718         (dict_create_linear, dict_create_linear_expandable)
1719         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1720         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1721         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1722         taking multidictionary argument.
1723         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1724         * block.h (struct block) <dict>: Change to multidictionary
1725         and rename `multidict'.
1726         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1727         symmisc.c: Update all dictionary references to multidictionary.
1728
1729 2019-01-10  Keith Seitz  <keiths@redhat.com>
1730
1731         PR gdb/23712
1732         PR symtab/23010
1733         * dictionary.c: Include unordered_map.
1734         (pending_to_vector): New function.
1735         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1736         Rewrite the non-"_1" functions to take vector instead
1737         of linked list.
1738         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1739         "new" _1 versions of the same name.
1740         (multidictionary): Define.
1741         (std::hash<enum language): New definition.
1742         (collate_pending_symbols_by_language, mdict_create_hashed)
1743         (mdict_create_hashed_expandable, mdict_create_linear)
1744         (mdict_create_linear_expandable, mdict_free)
1745         (find_language_dictionary, create_new_language_dictionary)
1746         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1747         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1748         (mdict_size, mdict_empty): New functions.
1749         * dictionary.h (mdict_iterator): Define.
1750
1751 2019-01-10  Pedro Alves  <palves@redhat.com>
1752
1753         * breakpoint.c (read_uploaded_action)
1754         (create_tracepoint_from_upload): Adjust to use
1755         gdb::unique_xmalloc_ptr.
1756         * ctf.c (ctf_write_uploaded_tp):
1757         (SET_ARRAY_FIELD): Use emplace_back.
1758         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1759         * tracefile-tfile.c (tfile_write_uploaded_tp):
1760         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1761         gdb::unique_xmalloc_ptr.
1762         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1763         at_string, cond_string, cmd_strings>: Replace char pointers
1764         with gdb::unique_xmalloc_ptr.
1765
1766 2019-01-10  Pedro Alves  <palves@redhat.com>
1767
1768         * solib-target.c (library_list_start_library): Don't xstrdup name.
1769
1770 2019-01-10  Pedro Alves  <palves@redhat.com>
1771
1772         * mdebugread.c (parse_partial_symbols): Use
1773         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1774
1775 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1776
1777         * linux-fork.c (scoped_switch_fork_info)
1778         <~scoped_switch_fork_info>: Fix incorrect variable name.
1779
1780 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1781
1782         * linux-fork.c (scoped_switch_fork_info)
1783         <scoped_switch_fork_info>: Make explicit.
1784         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1785
1786 2019-01-10  Tom Tromey  <tom@tromey.com>
1787
1788         * objfiles.h (objfile::reset_psymtabs): Update.
1789         * objfiles.c (objfile::objfile): Update.
1790         * psymtab.h (psymtab_storage::obstack): Update.
1791         (psymtab_storage::m_obstack): Use gdb::optional.
1792         (class psymtab_storage): Update comment.  Remove objfile
1793         parameter.
1794         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1795
1796 2019-01-10  Tom Tromey  <tom@tromey.com>
1797
1798         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1799         <free_psymtabs>: Now private.
1800         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1801         (allocate_psymtab): Use new method.
1802
1803 2019-01-10  Tom Tromey  <tom@tromey.com>
1804
1805         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1806         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1807         * mdebugread.c (parse_partial_symbols): Use
1808         allocate_dependencies.
1809         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1810         allocate_dependencies.
1811         (process_psymtab_comp_unit_reader)
1812         (build_type_psymtab_dependencies): Likewise.
1813         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1814
1815 2019-01-10  Tom Tromey  <tom@tromey.com>
1816
1817         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1818         PSYMBOL_SET_LANGUAGE.
1819         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1820
1821 2019-01-10  Tom Tromey  <tom@tromey.com>
1822
1823         * psymtab.h (psymtab_storage::obstack): New method.
1824         <m_obstack>: Rename from obstack; now private.
1825         * psymtab.c (psymtab_storage): Update.
1826         * dwarf2read.c (create_addrmap_from_index)
1827         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1828         Update.
1829
1830 2019-01-10  Tom Tromey  <tom@tromey.com>
1831
1832         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1833         * objfiles.h (objfile::reset_psymtabs): New method.
1834
1835 2019-01-10  Tom Tromey  <tom@tromey.com>
1836
1837         * symmisc.c (print_symbol_bcache_statistics): Update.
1838         (print_objfile_statistics): Update.
1839         * symfile.c (reread_symbols): Update.
1840         * psymtab.h (class psymtab_storage): New.
1841         * psymtab.c (psymtab_storage): New constructor.
1842         (~psymtab_storage): New destructor.
1843         (require_partial_symbols): Update.
1844         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1845         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1846         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1847         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1848         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1849         (start_psymtab_common, end_psymtab_common)
1850         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1851         (allocate_psymtab): Update.
1852         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1853         Update.
1854         (dump_psymtab_addrmap, maintenance_print_psymbols)
1855         (maintenance_check_psymtabs): Update.
1856         (class objfile_psymtabs): Move to objfiles.h.
1857         * psympriv.h (discard_psymtab): Now inline.
1858         (psymtab_discarder::psymtab_discarder): Update.
1859         (psymtab_discarder::~psymtab_discarder): Update.
1860         (ALL_OBJFILE_PSYMTABS): Rewrite.
1861         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1862         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1863         Remove fields.
1864         <partial_symtabs>: New field.
1865         (class objfile_psymtabs): Move from psymtab.h.  Update.
1866         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1867         psymbol_cache.
1868         (objfile::~objfile): Don't destroy psymbol_cache.
1869         * mdebugread.c (parse_partial_symbols): Update.
1870         * dwarf2read.c (create_addrmap_from_index)
1871         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1872         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1873         (add_partial_subprogram, dwarf2_ranges_read): Update.
1874         * dwarf-index-write.c (write_address_map)
1875         (write_one_signatured_type, recursively_write_psymbols)
1876         (class debug_names, class debug_names, write_psymtabs_to_index):
1877         Update.
1878
1879 2019-01-10  Tom Tromey  <tom@tromey.com>
1880
1881         * symtab.h (SYMBOL_SET_NAMES): Update.
1882         (symbol_set_names): Update.
1883         (MSYMBOL_SET_NAMES): Update.
1884         * symtab.c (symbol_set_names): Change argument to be an
1885         objfile_per_bfd_storage.
1886         * psymtab.c (add_psymbol_to_bcache): Update.
1887         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1888
1889 2019-01-10  Tom Tromey  <tom@tromey.com>
1890
1891         * symtab.c (create_demangled_names_hash): Change argument to be an
1892         objfile_per_bfd_storage.
1893         (symbol_set_names): Update.
1894
1895 2019-01-10  Tom Tromey  <tom@tromey.com>
1896
1897         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1898         init_psymbol_list.
1899         * psymtab.c (init_psymbol_list): Do nothing if already called.
1900         * psympriv.h (init_psymbol_list): Add comment.
1901         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1902         init_psymbol_list.
1903         * dbxread.c (dbx_symfile_read): Unconditionally call
1904         init_psymbol_list.
1905
1906 2019-01-10  Tom Tromey  <tom@tromey.com>
1907
1908         * xcoffread.c (scan_xcoff_symtab): Update.
1909         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1910         "where".
1911         * mdebugread.c (parse_partial_symbols)
1912         (handle_psymbol_enumerators): Update.
1913         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1914         * dbxread.c (read_dbx_symtab): Update.
1915         * psympriv.h (psymbol_placement): New enum.
1916         (add_psymbol_to_list): Update.
1917
1918 2019-01-10  Tom Tromey  <tom@tromey.com>
1919
1920         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1921         static_psymbols parameters.
1922         (scan_xcoff_symtab): Update.
1923         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1924         static_psymbols parameters.
1925         * psympriv.h (start_psymtab_common): Update.
1926         * mdebugread.c (parse_partial_symbols): Update.
1927         * dwarf2read.c (create_partial_symtab): Update.
1928         * dbxread.c (read_dbx_symtab): Update.
1929         (start_psymtab): Remove global_psymbols and static_psymbols
1930         parameters.
1931
1932 2019-01-10  Tom Tromey  <tom@tromey.com>
1933
1934         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1935         * psymtab.c (allocate_psymtab): Add comment.
1936         * psympriv.h (allocate_psymtab): Add comment.
1937         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1938         initializations.
1939         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1940
1941 2019-01-10  Tom Tromey  <tom@tromey.com>
1942
1943         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1944         Don't declare.
1945         * mipsread.c: Include mdebugread.h.
1946         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1947         Declare.
1948         * elfread.c: Include mdebugread.h.
1949
1950 2019-01-09  Tom Tromey  <tom@tromey.com>
1951
1952         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1953         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1954         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1955         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1956         (psym_lookup_symbol, psym_find_last_source_symtab)
1957         (psym_forget_cached_source_info, psym_print_stats)
1958         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1959         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1960         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1961         (psym_find_compunit_symtab_by_address)
1962         (maintenance_print_psymbols, maintenance_info_psymtabs)
1963         (maintenance_check_psymtabs): Use ranged for.
1964         * psymtab.h (class objfile_psymtabs): New.
1965         (require_partial_symbols): Return objfile_psymtabs.
1966         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1967
1968 2019-01-09  Tom Tromey  <tom@tromey.com>
1969
1970         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1971         (find_pc_mapped_section, list_overlays_command)
1972         (map_overlay_command, unmap_overlay_command)
1973         (simple_overlay_update): Use all_objfiles.
1974         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1975         * printcmd.c (info_symbol_command): Use all_objfiles.
1976         * objfiles.h (ALL_OBJSECTIONS): Remove.
1977         * maint.c (maintenance_translate_address): Use all_objfiles.
1978         * gcore.c (gcore_create_callback): Use all_objfiles.
1979         (objfile_find_memory_regions): Likewise.
1980
1981 2019-01-09  Tom Tromey  <tom@tromey.com>
1982
1983         * symtab.c (find_line_symtab, info_sources_command)
1984         (make_source_files_completion_list): Use objfile_compunits.
1985         * source.c (select_source_symtab): Use objfile_compunits.
1986         * objfiles.h (struct objfile): Update comment.
1987         (ALL_OBJFILES): Remove.
1988         (ALL_FILETABS): Remove.
1989         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1990         objfile_compunits.
1991
1992 2019-01-09  Tom Tromey  <tom@tromey.com>
1993
1994         * symmisc.c (print_objfile_statistics, dump_objfile)
1995         (maintenance_print_symbols): Use compunit_filetabs.
1996         * source.c (forget_cached_source_info_for_objfile): Use
1997         compunit_filetabs.
1998         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1999         (ALL_FILETABS): Use compunit_filetabs.
2000         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
2001         * coffread.c (coff_symtab_read): Use compunit_filetabs.
2002
2003 2019-01-09  Tom Tromey  <tom@tromey.com>
2004
2005         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
2006         (compunit_filetabs): New.
2007         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
2008         compunit_filetabs.
2009         (info_sources_command, make_source_files_completion_list): Remove
2010         declaration.
2011         * symmisc.c (print_objfile_statistics, dump_objfile)
2012         (maintenance_print_symbols): Remove declaration.
2013         (maintenance_info_symtabs): Use compunit_filetabs.
2014         (maintenance_info_line_tables): Likewise.
2015         * source.c (select_source_symtab): Change local variable name.
2016         (forget_cached_source_info_for_objfile): Remove declaration.
2017         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
2018         * objfiles.c (objfile_relocate1): Remove declaration.
2019         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2020         declaration.
2021         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
2022         * coffread.c (coff_symtab_read): Remove declaration.
2023         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2024         compunit_filetabs.
2025
2026 2019-01-09  Tom Tromey  <tom@tromey.com>
2027
2028         * symtab.c (lookup_objfile_from_block)
2029         (find_pc_sect_compunit_symtab, search_symbols)
2030         (default_collect_symbol_completion_matches_break_on): Use
2031         objfile_compunits.
2032         * objfiles.h (ALL_COMPUNITS): Remove.
2033         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
2034         * cp-support.c (add_symbol_overload_list_qualified): Use
2035         objfile_compunits.
2036         * ada-lang.c (ada_collect_symbol_completion_matches)
2037         (ada_add_global_exceptions): Use objfile_compunits.
2038
2039 2019-01-09  Tom Tromey  <tom@tromey.com>
2040
2041         * source.c (select_source_symtab)
2042         (forget_cached_source_info_for_objfile): Remove declaration.
2043         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
2044         declaration.
2045         * maint.c (count_symtabs_and_blocks): Remove declaration.
2046         * cp-support.c (add_symbol_overload_list_qualified): Remove
2047         declaration.
2048         * coffread.c (coff_symtab_read): Remove declaration.
2049         * symtab.c (lookup_symbol_in_objfile_symtabs)
2050         (basic_lookup_transparent_type_1): Use objfile_compunits.
2051         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
2052         (info_sources_command, search_symbols)
2053         (default_collect_symbol_completion_matches_break_on)
2054         (make_source_files_completion_list): Remove declaration.
2055         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
2056         (ada_collect_symbol_completion_matches)
2057         (ada_add_global_exceptions): Remove declaration.
2058         * linespec.c (iterate_over_all_matching_symtabs): Use
2059         objfile_compunits.
2060         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
2061         (class objfile_compunits): New.
2062         (ALL_COMPUNITS): Use objfile_compunits.
2063         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
2064         (maintenance_check_symtabs, maintenance_info_line_tables): Use
2065         objfile_compunits.
2066         * objfiles.c (objfile_relocate1): Use objfile_compunits.
2067
2068 2019-01-09  Tom Tromey  <tom@tromey.com>
2069
2070         * symtab.c (search_symbols)
2071         (default_collect_symbol_completion_matches_break_on): Use
2072         objfile_msymbols.
2073         * ada-lang.c (ada_lookup_simple_minsym)
2074         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
2075         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
2076         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
2077         objfile_msymbols.
2078         * coffread.c (coff_symfile_read): Use objfile_msymbols.
2079         * symmisc.c (dump_msymbols): Use objfile_msymbols.
2080         * objc-lang.c (find_methods): Use objfile_msymbols.
2081         (info_selectors_command, info_classes_command): Likewise.
2082         * stabsread.c (scan_file_globals): Use objfile_msymbols.
2083         * objfiles.h (class objfile_msymbols): New.
2084         (ALL_OBJFILE_MSYMBOLS): Remove.
2085         (ALL_MSYMBOLS): Remove.
2086
2087 2019-01-09  Tom Tromey  <tom@tromey.com>
2088
2089         * common/next-iterator.h (next_adapter): Add Iterator template
2090         parameter.
2091         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
2092         (class all_objfiles_safe): New.
2093         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
2094         * objfiles.c (put_objfile_before): Update comment.
2095         (add_separate_debug_objfile): Likewise.
2096         (free_all_objfiles): Use all_objfiles_safe.
2097         (objfile_purge_solibs): Likewise.
2098
2099 2019-01-09  Tom Tromey  <tom@tromey.com>
2100
2101         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2102         (expand_symtab_containing_pc, lookup_static_symbol)
2103         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
2104         (find_symbol_at_address, find_line_symtab, find_main_name): Use
2105         all_objfiles.
2106         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
2107         * breakpoint.c (create_overlay_event_breakpoint)
2108         (create_longjmp_master_breakpoint)
2109         (create_std_terminate_master_breakpoint)
2110         (create_exception_master_breakpoint): Use all_objfiles.
2111         * linux-thread-db.c (try_thread_db_load_from_pdir)
2112         (has_libpthread): Use all_objfiles.
2113         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
2114         * linespec.c (iterate_over_all_matching_symtabs)
2115         (search_minsyms_for_name): Use all_objfiles.
2116         * maint.c (maintenance_info_sections): Use all_objfiles.
2117         * main.c (captured_main_1): Use all_objfiles.
2118         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
2119         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
2120         * guile/scm-pretty-print.c
2121         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
2122         * solib-spu.c (append_ocl_sos): Use all_objfiles.
2123         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
2124         (maintenance_print_msymbols): Use all_objfiles.
2125         * source.c (select_source_symtab): Use all_objfiles.
2126         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
2127         * symfile.c (remove_symbol_file_command)
2128         (expand_symtabs_matching, map_symbol_filenames): Use
2129         all_objfiles.
2130         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
2131         all_objfiles.
2132         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
2133         * objc-lang.c (find_methods): Use all_objfiles.
2134         * objfiles.c (have_partial_symbols, have_full_symbols)
2135         (have_minimal_symbols, qsort_cmp)
2136         (default_iterate_over_objfiles_in_search_order): Use
2137         all_objfiles.
2138         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
2139         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
2140         (maintenance_check_psymtabs): Use all_objfiles.
2141         (ALL_PSYMTABS): Remove.
2142         * compile/compile-object-run.c (do_module_cleanup): Use
2143         all_objfiles.
2144         * blockframe.c (find_pc_partial_function): Use all_objfiles.
2145         * cp-support.c (add_symbol_overload_list_qualified): Use
2146         all_objfiles.
2147         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2148         Use all_objfiles.
2149         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
2150         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
2151         all_objfiles.
2152         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2153         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
2154         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2155         Uses all_objfiles.
2156         * solib.c (solib_read_symbols): Use all_objfiles
2157
2158 2019-01-09  Tom Tromey  <tom@tromey.com>
2159
2160         * probe.c (parse_probes_in_pspace): Use all_objfiles.
2161         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
2162         all_objfiles.
2163         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
2164         * symmisc.c (print_symbol_bcache_statistics)
2165         (print_objfile_statistics, maintenance_print_objfiles)
2166         (maintenance_info_symtabs, maintenance_check_symtabs)
2167         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
2168         all_objfiles.
2169         * source.c (forget_cached_source_info): Use all_objfiles.
2170         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
2171         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2172         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
2173         * objfiles.c (update_section_map): Use all_objfiles.
2174         (shared_objfile_contains_address_p): Likewise.
2175         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
2176         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
2177
2178 2019-01-09  Tom Tromey  <tom@tromey.com>
2179
2180         * common/next-iterator.h: New file.
2181         * objfiles.h (class all_objfiles): New.
2182         (struct objfile_iterator): New.
2183
2184 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2185
2186         * NEWS: Move the description of the changed "frame", "select-frame",
2187          and "info frame" commands to the Changed commands section.
2188
2189 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
2190
2191         * gdbtypes.c (check_stub_method_group): Remove handling of old
2192         mangling schemes.
2193         * linespec.c (find_methods): Likewise.
2194         * stabsread.c (read_member_functions): Likewise.
2195         * valops.c (search_struct_method): Likewise.
2196         (value_struct_elt_for_reference): Likewise.
2197         * NEWS: Mention this change.
2198
2199 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2200
2201         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
2202         print_source_lines.
2203         * source.c (print_source_lines_base): Update line number check.
2204         (print_source_lines): New function.
2205         (source_lines_range::source_lines_range): New function.
2206         * source.h (class source_lines_range): New class.
2207         (print_source_lines): New declaration.
2208
2209 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2210
2211         * linespec.c (linespec_state_destructor): Free self->canonical_names.
2212
2213 2019-01-08  Tom Tromey  <tom@tromey.com>
2214             Simon Marchi  <simon.marchi@ericsson.com>
2215
2216         PR gdb/24060
2217         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
2218         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
2219         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2220         * f-exp.y (DOLLAR_VARIABLE): Likewise.
2221         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
2222         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
2223
2224 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2225
2226         * source.c (select_source_symtab): Move header comment to
2227         declaration in source.h.
2228         (forget_cached_source_info_for_objfile): Likewise.
2229         (forget_cached_source_info): Likewise.
2230         (identify_source_line): Likewise.
2231         * source.h (identify_source_line): Move declaration from symtab.h
2232         and add comment from source.c
2233         (print_source_lines): Likewise.
2234         (forget_cached_source_info_for_objfile): Likewise.
2235         (forget_cached_source_info): Likewise.
2236         (select_source_symtab): Likewise.
2237         (enum print_source_lines_flag): Move definition from symtab.h.
2238         * symtab.h (identify_source_line): Move declaration to source.h.
2239         (print_source_lines): Likewise.
2240         (forget_cached_source_info_for_objfile): Likewise.
2241         (forget_cached_source_info): Likewise.
2242         (select_source_symtab): Likewise.
2243         (enum print_source_lines_flag): Move definition to source.h.
2244         * tui/tui-hooks.c: Add 'source.h' include.
2245
2246 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2247
2248         * source.c (print_source_lines_base): Handle requests to print
2249         reverse line number sequences, and guard against empty lines
2250         string.
2251
2252 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2253
2254         * source.c (print_source_lines_base): Fix skip of '\r' if next
2255         character is '\n'.
2256
2257 2019-01-06  Tom Tromey  <tom@tromey.com>
2258
2259         * c-exp.y (struct c_parse_state) <macro_original_text,
2260         expansion_obstack>: New member.
2261         (macro_original_text, expansion_obstack): Remove globals.
2262         (scan_macro_expansion, scanning_macro_expansion)
2263         (finished_macro_expansion): Update.
2264         (scan_macro_cleanup): Remove.
2265         (yylex, c_parse): Update.
2266
2267 2019-01-06  Tom Tromey  <tom@tromey.com>
2268
2269         * c-exp.y (struct c_parse_state) <strings>: New member.
2270         (operator_stoken): Update.
2271
2272 2019-01-06  Tom Tromey  <tom@tromey.com>
2273
2274         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
2275         (union type_stack_elt) <typelist_val>: Now a pointer to
2276         std::vector.
2277         (type_stack_cleanup): Don't declare.
2278         (push_typelist): Update.
2279         * parse.c (pop_typelist): Return a std::vector.
2280         (push_typelist): Take a std::vector.
2281         (follow_types): Update.  Do not free args.
2282         (type_stack_cleanup): Remove.
2283         * c-exp.y (struct c_parse_state): New.
2284         (cpstate): New global.
2285         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
2286         (nonempty_typelist): Update.
2287         (func_mod): Create a new vector.
2288         (c_parse): Create a c_parse_state.
2289         (check_parameter_typelist): Do not delete params.
2290         (function_method): Update.  Do not delete type_list.
2291
2292 2019-01-06  Tom Tromey  <tom@tromey.com>
2293
2294         PR gdb/28155:
2295         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
2296         check_typedef.
2297         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
2298         (print_return_value): Likewise.
2299
2300 2019-01-05  Tom Tromey  <tom@tromey.com>
2301
2302         * contrib/cleanup_check.py: Remove.
2303         * contrib/gcc-with-excheck: Remove.
2304         * contrib/exsummary.py: Remove.
2305         * contrib/excheck.py: Remove.
2306
2307 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
2308
2309         * thread.c (delete_thread_1): Add gdb_assert that THR is not
2310         NULL. Initialize tpprev to NULL instead of assigning it
2311         to NULL on the next statement.
2312         * windows-nat.c (windows_delete_thread): Remove check for
2313         main_thread_id before printing thread exit notifications.
2314         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
2315         Remove thread ID check against main_thread_id.
2316         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
2317         windows_delete_thread.
2318         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
2319
2320 2019-01-04  Tom Tromey  <tom@tromey.com>
2321
2322         * compile/compile.c (_initialize_compile): Use upper case for
2323         metasyntactic variables.
2324         * symmisc.c (_initialize_symmisc): Use upper case for
2325         metasyntactic variables.
2326         * psymtab.c (_initialize_psymtab): Use upper case for
2327         metasyntactic variables.
2328         * demangle.c (demangle_command): Use upper case for metasyntactic
2329         variables.
2330         (_initialize_demangler): Likewise.
2331         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
2332         variables.
2333
2334 2019-01-03  Tom Tromey  <tom@tromey.com>
2335
2336         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
2337
2338 2019-01-03  Tom Tromey  <tom@tromey.com>
2339
2340         * python/py-symtab.c (salpy_str): Update.
2341         (struct salpy_sal_object) <symtab>: Now a PyObject.
2342         (salpy_dealloc): Update.
2343         (del_objfile_sal): Use gdbpy_ref.
2344
2345 2019-01-03  Tom Tromey  <tom@tromey.com>
2346
2347         * python/py-type.c (convert_field): Use new_reference.  Return
2348         gdbpy_ref.
2349         (make_fielditem): Return gdbpy_ref.
2350         (typy_fields): Update.
2351         (typy_getitem): Update.
2352         (field_name): Return gdbpy_ref.  Use new_reference.
2353         (typy_iterator_iternext): Update.
2354
2355 2019-01-03  Tom Tromey  <tom@tromey.com>
2356
2357         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
2358
2359 2019-01-03  Tom Tromey  <tom@tromey.com>
2360
2361         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
2362         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
2363         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
2364         (pspy_set_frame_filters, pspy_set_frame_unwinders)
2365         (pspy_set_type_printers): Likewise.
2366         * python/py-function.c (fnpy_init): Use gdbpy_ref.
2367         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
2368         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
2369         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
2370         (objfpy_set_type_printers): Likewise.
2371
2372 2019-01-03  Tom Tromey  <tom@tromey.com>
2373
2374         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
2375         (gdbpy_print_stack): Use gdbpy_err_fetch.
2376         * python/python-internal.h (class gdbpy_err_fetch): New class.
2377         (class gdbpy_enter) <m_error_type, m_error_value,
2378         m_error_traceback>: Remove.
2379         <m_error>: New member.
2380         (gdbpy_exception_to_string): Don't declare.
2381         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
2382         * python/py-value.c (convert_value_from_python): Use
2383         gdbpy_err_fetch.
2384         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
2385         gdbpy_exception_to_string.
2386         (gdbpy_handle_exception): Use gdbpy_err_fetch.
2387         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2388         gdbpy_err_fetch.
2389
2390 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2391
2392         * linux-nat.c (delete_lwp_cleanup): Delete.
2393         (struct lwp_deleter): New struct.
2394         (lwp_info_up): New typedef.
2395         (linux_nat_target::follow_fork): Delete cleanup, and make use of
2396         lwp_info_up.
2397
2398 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2399
2400         * linux-fork.c (class scoped_switch_fork_info): New class.
2401         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
2402
2403 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2404
2405         * valops.c (find_overload_match): Remove use of null_cleanup, and
2406         calls to do_cleanups.
2407
2408 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2409
2410         * compile/compile-cplus-types.c
2411         (compile_cplus_instance::decl_name): Handle changes to
2412         cp_func_name.
2413         * cp-support.c (cp_func_name): Update header comment, update
2414         return type.
2415         * cp-support.h (cp_func_name): Update return type in declaration.
2416         * valops.c (find_overload_match): Move temp_func local to top
2417         level of function and change its type.  Use temp_func to hold and
2418         delete temporary string obtained from cp_func_name.
2419
2420 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2421
2422         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
2423         gdb::char_vector, remove cleanup, and update uses of `msg`.
2424
2425 2019-01-03  Jim Wilson  <jimw@sifive.com>
2426
2427         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
2428
2429 2019-01-02  Tom Tromey  <tom@tromey.com>
2430
2431         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
2432         (tdesc_parse_xml): Remove cleanups.
2433         * target-descriptions.h (make_cleanup_free_target_description):
2434         Don't declare.
2435         (target_desc_deleter): New struct.
2436         (target_desc_up): New typedef.
2437         * target-descriptions.c (target_desc_deleter::operator()): Rename
2438         from free_target_description.
2439         (make_cleanup_free_target_description): Remove.
2440
2441 2019-01-02  Tom Tromey  <tom@tromey.com>
2442
2443         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
2444         constructor, destructor.
2445         (linespec_parser): Remove typedef.
2446         (~linespec_parser): Rename from linespec_parser_delete.
2447         (linespec_lex_to_end, linespec_complete_label)
2448         (linespec_complete): Update.
2449         (decode_line_full): Remove cleanups.
2450         (decode_line_1): Update.
2451
2452 2019-01-02  Tom Tromey  <tom@tromey.com>
2453
2454         * python/python-internal.h (inferior_to_inferior_object): Change
2455         return type.
2456         * python/py-exitedevent.c (create_exited_event_object): Update.
2457         * python/py-inferior.c (inferior_to_inferior_object): Return
2458         gdbpy_ref.
2459         (python_new_inferior, python_inferior_deleted)
2460         (thread_to_thread_object, delete_thread_object)
2461         (build_inferior_list, gdbpy_selected_inferior): Update.
2462         * python/py-infthread.c (create_thread_object): Update.  Also fail
2463         if inferior_to_inferior_object fails.
2464
2465 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2466
2467         * inferior.h (class inferior) <displaced_step_state>: New field.
2468         * infrun.h (struct displaced_step_state): Move here from
2469         infrun.c.  Initialize fields, add constructor.
2470         <inf>: Remove field.
2471         <reset>: New method.
2472         * infrun.c (struct displaced_step_inferior_state): Move to
2473         infrun.h.
2474         (displaced_step_inferior_states): Remove.
2475         (get_displaced_stepping_state): Adust.
2476         (displaced_step_in_progress_any_inferior): Adjust.
2477         (displaced_step_in_progress_thread): Adjust.
2478         (displaced_step_in_progress): Adjust.
2479         (add_displaced_stepping_state): Remove.
2480         (get_displaced_step_closure_by_addr): Adjust.
2481         (remove_displaced_stepping_state): Remove.
2482         (infrun_inferior_exit): Call displaced_step_state.reset.
2483         (use_displaced_stepping): Don't check for NULL.
2484         (displaced_step_prepare_throw): Call
2485         get_displaced_stepping_state.
2486         (displaced_step_fixup): Don't check for NULL.
2487         (prepare_for_detach): Don't check for NULL.
2488
2489 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2490
2491         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2492          in case of call that did not complete.
2493
2494 2019-01-02  Andrey Utkin  <autkin@undo.io>
2495
2496         * symfile.c (find_separate_debug_file): Fix search of debug files for
2497         remote debuggee.
2498
2499 2019-01-02  Tom Tromey  <tom@tromey.com>
2500
2501         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2502         indentation.
2503         * python/py-frame.c (frapy_older): Remove cast.
2504         (frapy_newer): Likewise.
2505         * python/py-breakpoint.c (local_setattro): Remove cast.
2506         * python/py-arch.c (archpy_name): Remove local variable.
2507         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2508
2509 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2510
2511         * unittests/basic_string_view/element_access/char/empty.cc:
2512         Fix year range in copyright header.
2513
2514 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2515
2516         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2517         Delete.
2518         <operator==>: Update with for removed field.
2519         <hash>: Likewise.
2520         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2521         <isa_features>: ...this.
2522         <abi_features>: New field.
2523         (riscv_isa_flen): Update comment.
2524         (riscv_abi_xlen): New declaration.
2525         (riscv_abi_flen): New declaration.
2526         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2527         isa_features.
2528         (riscv_abi_xlen): New function.
2529         (riscv_isa_flen): Update to get answer from isa_features.
2530         (riscv_abi_flen): New function.
2531         (riscv_has_fp_abi): Update to get answer from abi_features.
2532         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2533         xlen and flen.
2534         (riscv_call_info) <xlen, flen>: Update comment.
2535         (riscv_call_arg_struct): Remove invalid assertions
2536         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2537         is removed.
2538         (riscv_gdbarch_init): Gather isa features and abi features
2539         separately, ensure both match on the gdbarch when reusing an old
2540         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2541         a target with 64-bit float hardware.
2542
2543 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2544
2545         * source.c (search_command_helper): Stop reverse search
2546         when line 1 has been searched.
2547
2548 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2549
2550         * record-full.c (record_full_base_target::close): Rewrite
2551         record_full_core_buf_list free logic.
2552
2553 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2554
2555         * break-catch-syscall.c (print_one_catch_syscall): xfree
2556         the last text.
2557
2558 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2559
2560         * top.c (print_gdb_version): Update Copyright year in version
2561         message.
2562
2563 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2564
2565         Update copyright year range in all GDB files.
2566
2567 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2568
2569         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2570
2571 For older changes see ChangeLog-2018.
2572 \f
2573 Local Variables:
2574 mode: change-log
2575 left-margin: 8
2576 fill-column: 74
2577 version-control: never
2578 coding: utf-8
2579 End:
2580